[chromium] introduce WebUserGestureIndicator
[WebKit-https.git] / Tools / ChangeLog
1 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
2
3         [chromium] introduce WebUserGestureIndicator
4         https://bugs.webkit.org/show_bug.cgi?id=111531
5
6         Reviewed by Adam Barth.
7
8         * DumpRenderTree/chromium/WebViewHost.cpp:
9         (WebViewHost::createView):
10
11 2013-03-06  Alan Cutter  <alancutter@chromium.org>
12
13         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
14         https://bugs.webkit.org/show_bug.cgi?id=73482
15
16         Reviewed by Ryosuke Niwa.
17
18         Added input checking to the UpdateChromiumDEPS step.
19         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
20
21         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
22         (RollChromiumDEPS):
23         (RollChromiumDEPS._parse_args):
24         (RollChromiumDEPS.execute):
25         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
26         (IRCCommandTest.test_roll_chromium_deps):
27         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
28         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
29         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
30         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
31         (UpdateChromiumDEPS._fetch_last_known_good_revision):
32         (UpdateChromiumDEPS):
33         (UpdateChromiumDEPS._parse_revision_number):
34         (UpdateChromiumDEPS._validate_revisions):
35         (UpdateChromiumDEPS.run):
36         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
37         (UpdateChromiumDEPSTest):
38         (UpdateChromiumDEPSTest.test_parse_revision_number):
39         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
40         (RollChromiumDEPS):
41         (PostChromiumDEPSRoll):
42
43 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
44
45         [Qt][MiniBrowser] Touch mocking broken for chained getures
46         https://bugs.webkit.org/show_bug.cgi?id=111430
47
48         Reviewed by Jocelyn Turcotte.
49
50         Make it possible again to use touch mocking to test gesture chains
51         like pan->pinch->pan->pinch without lifting the primary "finger".
52         For this to work we need to track the pressed mouse buttons and
53         only synthesize touch release events when the ctrl key is released
54         if no mouse button is pressed. Else the pressed mouse button(s)
55         should result in a stationary touch point in a touch update event.
56         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
57         to check for the state of the ctrl key modifier instead of getting
58         it from the mouse events.
59
60         * MiniBrowser/qt/MiniBrowserApplication.cpp:
61         (MiniBrowserApplication::MiniBrowserApplication):
62         (MiniBrowserApplication::notify):
63
64 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
65
66         [chromium] don't use custom freetype on linux asan for now
67         https://bugs.webkit.org/show_bug.cgi?id=111516
68
69         Unreviewed, build fix.
70
71         Turns out the custom lib is getting picked up by other binaries
72         on our bot, which is bad.
73
74         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
75
76 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
77
78         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
79         https://bugs.webkit.org/show_bug.cgi?id=111509
80
81         Unreviewed, build fix.
82
83         Actually comment out the flag :(.
84
85         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
86
87 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
88
89         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
90         https://bugs.webkit.org/show_bug.cgi?id=111509
91
92         Unreviewed, build fix.
93
94         r144863 appears to have broken the xcode build; I'm temporarily
95         trying this instead, and if this doesn't work, I'll revert the
96         other changes.
97
98         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
99
100 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
101
102         [chromium] build a DumpRenderTree.pak even on windows
103         https://bugs.webkit.org/show_bug.cgi?id=111504
104
105         Reviewed by Tony Chang.
106
107         The Chromium Aura build uses the default theme to draw
108         controls, and that theme requires the ui ResourceBundle
109         to be initialized. On every other platform, we build
110         a DumpRenderTree.pak that works for this, but on Windows we
111         still compile the resources directly into DRT. As a first step,
112         let's build the pak file. I will then need to land a patch
113         in Chromium to actually load it. Then I can go back and move
114         the resources over to just use the .pak file and no longer need
115         the .rc's.
116
117         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
118
119 2013-03-05  Julie Parent  <jparent@chromium.org>
120         Dashboard cleanup: move string utilities into their own namespace.
121         
122         https://bugs.webkit.org/show_bug.cgi?id=111485
123
124         Reviewed by Ojan Vafai.
125         
126         One of many pieces to clean up dashboard_base.
127         
128         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
129
130         * TestResultServer/static-dashboards/aggregate_results.html:
131         * TestResultServer/static-dashboards/dashboard_base.js:
132         (isTreeMap):
133         (isFlakinessDashboard):
134         * TestResultServer/static-dashboards/flakiness_dashboard.html:
135         * TestResultServer/static-dashboards/flakiness_dashboard.js:
136         (determineWKPlatform):
137         (chromiumPlatform):
138         (platformAndBuildType):
139         (substringList):
140         (individualTestsForSubstringList):
141         (filterBugs):
142         (populateExpectationsData):
143         (processMissingTestsWithExpectations):
144         (processMissingAndExtraExpectations):
145         (htmlForSingleTestRow):
146         (.dummyNode.onload):
147         (expectationsTitle):
148         * TestResultServer/static-dashboards/run-embedded-unittests.html:
149         * TestResultServer/static-dashboards/run-unittests.html:
150         * TestResultServer/static-dashboards/string.js: Added.
151         * TestResultServer/static-dashboards/timeline_explorer.html:
152         * TestResultServer/static-dashboards/treemap.html:
153
154 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
155
156         [EFL] Build break with latest EFL libraries
157         https://bugs.webkit.org/show_bug.cgi?id=111028
158
159         Reviewed by Dirk Pranke.
160
161         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
162         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
163         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
164
165 2013-03-05  Roger Fong  <roger_fong@apple.com>
166
167         Increase number of WinEWS iterations to 20.
168         Don't reboot after each iteration set.
169         Make EWS bots just build temporarily so that the queue catches up again.
170
171         * EWSTools/start-queue-win.sh:
172         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
173         (WinEWS):
174
175 2013-03-04  James Robinson  <jamesr@chromium.org>
176
177         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
178         https://bugs.webkit.org/show_bug.cgi?id=111386
179
180         Reviewed by Adrienne Walker.
181
182         * DumpRenderTree/chromium/TestShell.cpp:
183         (TestShell::initialize):
184
185 2013-03-05  Min Qin  <qinmin@chromium.org>
186
187         Copy dictionary to the external storage before running layout test on android
188         https://bugs.webkit.org/show_bug.cgi?id=111480
189
190         Reviewed by Adam Barth.
191
192         TestWebKitPlatformSupport now needs to read an external dictionary file.
193         This file does not exist on the device. We need to copy it before running layout tests.
194
195         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
196         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
197         (ChromiumAndroidDriver._push_platform_resources):
198
199 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
200
201         [chromium] DRT crashes in an Aura/Win build
202         https://bugs.webkit.org/show_bug.cgi?id=111394
203
204         Reviewed by Tony Chang.
205
206         When building (and running) with use_aura=1, we assume that
207         we're using the default theme engine, but DRT creates the
208         DRTWin theme engine and overwrites the default, leading to crashes
209         in basically every test from the mismatch.
210
211         This fix gets us down to at least "lots of crashes" :).
212
213         * DumpRenderTree/chromium/TestShellWin.cpp:
214         (platformInit):
215
216 2013-03-05  Eric Seidel  <eric@webkit.org>
217
218         Add html-parser-threaded perf test now that the threaded parser is enabled by default
219         https://bugs.webkit.org/show_bug.cgi?id=111200
220
221         Reviewed by Ryosuke Niwa.
222
223         Had to teach run-perf-tests to ignore one more warning.
224
225         * Scripts/webkitpy/performance_tests/perftest.py:
226         (PerfTest):
227
228 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
229
230         Update list of builders for test results server
231         https://bugs.webkit.org/show_bug.cgi?id=111166
232
233         Reviewed by Ojan Vafai.
234
235         * TestResultServer/static-dashboards/builders.jsonp:
236
237 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
238
239         [GTK] Move basic dependency installation to a script
240         https://bugs.webkit.org/show_bug.cgi?id=110692
241
242         Reviewed by Gustavo Noronha Silva.
243
244         * gtk/install-dependencies: Added. A Script which installs all dependencies
245         necessary for building for Debian-based distributions and Fedora.
246
247 2013-03-05  James Robinson  <jamesr@chromium.org>
248
249         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
250         https://bugs.webkit.org/show_bug.cgi?id=111440
251
252         Reviewed by Adrienne Walker.
253
254         Remove unnecessary WebCompositorSupport::shutdown call
255
256         * DumpRenderTree/chromium/DumpRenderTree.cpp:
257         (main):
258
259 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
260
261         Unreviewed build fix.
262
263         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
264
265 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
266
267         [Qt][MiniBrowser] Improve the update of touch indicators
268         https://bugs.webkit.org/show_bug.cgi?id=111429
269
270         Reviewed by Jocelyn Turcotte.
271
272         MiniBrowserApplication::sendTouchEvent sends an empty list
273         to BrowserWindow::updateVisualMockTouchPoints if the control
274         button is released, in which case the touch indicators should
275         be hidden so that we never end up with a leftover indicator
276         sticking on the screen.
277         This patch also simplifies the lookup of the indicator items by
278         replacing the findChild search in the item tree with a QHash
279         that stores the touch ID's and the pointers to the corresponding
280         indicator items.
281
282         * MiniBrowser/qt/BrowserWindow.cpp:
283         (BrowserWindow::updateVisualMockTouchPoints):
284         * MiniBrowser/qt/BrowserWindow.h:
285         (BrowserWindow):
286
287 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
288
289         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
290         https://bugs.webkit.org/show_bug.cgi?id=81042
291
292         Reviewed by Enrica Casucci.
293
294         Add setAsynchronousSpellCheckingEnabled implementation for
295         WebKitTestRunner to have the possibility to test asynchronous
296         spell checking implementation from bug 109577.
297
298         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
299         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
300         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
301         * WebKitTestRunner/InjectedBundle/TestRunner.h:
302         * WebKitTestRunner/TestController.cpp:
303         (WTR::TestController::resetStateToConsistentValues):
304
305 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
306
307         MediaStream API: Add the getStreamById method on RTCPeerConnection
308         https://bugs.webkit.org/show_bug.cgi?id=111311
309
310         Reviewed by Adam Barth.
311
312         Changing mocks to be more realistic.
313
314         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
315         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
316         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
317         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
318         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
319
320 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
321
322         Add content shell bots to garden-o-matic for general failurse
323         https://bugs.webkit.org/show_bug.cgi?id=111168
324
325         Reviewed by Adam Barth.
326
327         All but the WebKit (Content Shell) Android bot is stable enough. While
328         they're not green yet, there must not be any non-layout test failures on
329         them.
330
331         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
332         (.):
333
334 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
335
336         [chromium] remove deprecated WebTestRunner::setFocus API
337         https://bugs.webkit.org/show_bug.cgi?id=111354
338
339         Reviewed by James Robinson.
340
341         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
342         (WebTestDelegate):
343
344 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
345
346         Run the bindings generation tests on EWS and CQ bots
347         https://bugs.webkit.org/show_bug.cgi?id=111358
348
349         Reviewed by Adam Barth.
350
351         The tests are super fast and not flaky.
352
353         * Scripts/webkitpy/common/config/ports.py:
354         (DeprecatedPort.run_bindings_tests_command):
355         * Scripts/webkitpy/common/config/ports_mock.py:
356         (MockPort.run_webkit_tests_command):
357         (MockPort):
358         (MockPort.run_bindings_tests_command):
359         * Scripts/webkitpy/tool/commands/download_unittest.py:
360         * Scripts/webkitpy/tool/steps/runtests.py:
361         (RunTests.run):
362         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
363         (RunTestsTest.test_webkit_run_unit_tests):
364         * Scripts/webkitpy/tool/steps/steps_unittest.py:
365
366 2013-03-04  Eric Seidel  <eric@webkit.org>
367
368         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
369         https://bugs.webkit.org/show_bug.cgi?id=111384
370
371         Reviewed by Ryosuke Niwa.
372
373         Sometimes I want to know why various LayoutTests are slow
374         without having to convert them into PerformanceTests in order
375         to use our fancy profiling.  The Driver already knows how to
376         do the right thing, we just need to expose the options to the user.
377
378         Handling of these options is already unittested in the perftests_unittest.
379
380         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
381         (parse_args):
382
383 2013-03-04  Alan Cutter  <alancutter@chromium.org>
384
385         check-webkit-style says "Have to enable auto props in the subversion config file"
386         https://bugs.webkit.org/show_bug.cgi?id=107724
387
388         Reviewed by Tony Chang.
389
390         Added a standard svn config file for WebKit developers to use.
391         Updated the style and commit queue bot build scripts to load this file.
392
393         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
394         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
395         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
396         * svn-config: Added.
397
398 2013-03-04  James Robinson  <jamesr@chromium.org>
399
400         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
401         https://bugs.webkit.org/show_bug.cgi?id=111285
402
403         Reviewed by Adrienne Walker.
404
405         This removes the need for WebCompositorSupport::initialize and exposes
406         slightly fewer entry points across the repository boundary.
407
408         * DumpRenderTree/chromium/TestShell.cpp:
409         (TestShell::initialize):
410         * DumpRenderTree/chromium/TestShell.h:
411         (TestShell::webCompositorThread):
412         (TestShell):
413         * DumpRenderTree/chromium/WebViewHost.cpp:
414         (WebViewHost::initializeLayerTreeView):
415
416 2013-03-04  Roger Fong  <roger_fong@apple.com>
417
418         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
419
420         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
421
422 2013-03-04  David Kilzer  <ddkilzer@apple.com>
423
424         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
425
426             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
427                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
428                                         ^         ~~~~~~~~~~~~~~~~~~~~~
429             1 error generated.
430
431         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
432         AccessibilityCommonMac.h.
433
434 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
435
436         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
437         https://bugs.webkit.org/show_bug.cgi?id=109828
438
439         Reviewed by Kenneth Rohde Christiansen.
440
441         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
442         callbacks.
443
444         * TestWebKitAPI/CMakeLists.txt:
445
446             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
447             considered.
448
449         * TestWebKitAPI/PlatformEfl.cmake:
450         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
451         (TestWebKitAPI):
452         (TestWebKitAPI::didFinishLoadForFrame):
453         (TestWebKitAPI::setPageLoaderClient):
454         (TestWebKitAPI::webProcessCrashed):
455         (TestWebKitAPI::webProcessDidRelaunch):
456         (TestWebKitAPI::setViewClient):
457         (TestWebKitAPI::TEST):
458
459 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
460
461         AX: Upstream iOS Accessibility DumpRenderTree changes
462         https://bugs.webkit.org/show_bug.cgi?id=111220
463
464         Reviewed by David Kilzer.
465
466         Upstream the iOS changes for accessibility in DumpRenderTree.
467
468         * DumpRenderTree/AccessibilityUIElement.cpp:
469         (headerElementAtIndexCallback):
470         (linkedElementCallback):
471         (elementsForRangeCallback):
472         (increaseTextSelectionCallback):
473         (decreaseTextSelectionCallback):
474         (assistiveTechnologySimulatedFocusCallback):
475         (stringForSelectionCallback):
476         (getIPhoneLabelCallback):
477         (getIPhoneHintCallback):
478         (getIPhoneValueCallback):
479         (getIPhoneIdentifierCallback):
480         (getIPhoneTraitsCallback):
481         (getIPhoneIsElementCallback):
482         (getIPhoneElementTextPositionCallback):
483         (getIPhoneElementTextLengthCallback):
484         (AccessibilityUIElement::getJSClass):
485         * DumpRenderTree/AccessibilityUIElement.h:
486         (AccessibilityUIElement):
487         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
488         * DumpRenderTree/ios: Added.
489         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
490         (AccessibilityController::AccessibilityController):
491         (AccessibilityController::~AccessibilityController):
492         (AccessibilityController::elementAtPoint):
493         (AccessibilityController::focusedElement):
494         (AccessibilityController::rootElement):
495         (findAccessibleObjectById):
496         (AccessibilityController::accessibleElementById):
497         (AccessibilityController::setLogFocusEvents):
498         (AccessibilityController::setLogScrollingStartEvents):
499         (AccessibilityController::setLogValueChangeEvents):
500         (AccessibilityController::setLogAccessibilityEvents):
501         (AccessibilityController::addNotificationListener):
502         (AccessibilityController::removeNotificationListener):
503         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
504         (AccessibilityUIElement::AccessibilityUIElement):
505         (AccessibilityUIElement::~AccessibilityUIElement):
506         (concatenateAttributeAndValue):
507         (AccessibilityUIElement::iphoneLabel):
508         (AccessibilityUIElement::iphoneHint):
509         (AccessibilityUIElement::iphoneValue):
510         (AccessibilityUIElement::iphoneIdentifier):
511         (AccessibilityUIElement::iphoneTraits):
512         (AccessibilityUIElement::iphoneIsElement):
513         (AccessibilityUIElement::iphoneElementTextPosition):
514         (AccessibilityUIElement::iphoneElementTextLength):
515         (AccessibilityUIElement::url):
516         (AccessibilityUIElement::x):
517         (AccessibilityUIElement::y):
518         (AccessibilityUIElement::width):
519         (AccessibilityUIElement::height):
520         (AccessibilityUIElement::clickPointX):
521         (AccessibilityUIElement::clickPointY):
522         (AccessibilityUIElement::getChildren):
523         (AccessibilityUIElement::getChildrenWithRange):
524         (AccessibilityUIElement::childrenCount):
525         (AccessibilityUIElement::elementAtPoint):
526         (AccessibilityUIElement::indexOfChild):
527         (AccessibilityUIElement::getChildAtIndex):
528         (AccessibilityUIElement::headerElementAtIndex):
529         (AccessibilityUIElement::linkedElement):
530         (AccessibilityUIElement::linkedUIElementAtIndex):
531         (AccessibilityUIElement::ariaOwnsElementAtIndex):
532         (AccessibilityUIElement::ariaFlowToElementAtIndex):
533         (AccessibilityUIElement::disclosedRowAtIndex):
534         (AccessibilityUIElement::selectedRowAtIndex):
535         (AccessibilityUIElement::rowAtIndex):
536         (AccessibilityUIElement::titleUIElement):
537         (AccessibilityUIElement::parentElement):
538         (AccessibilityUIElement::disclosedByRow):
539         (AccessibilityUIElement::increaseTextSelection):
540         (AccessibilityUIElement::decreaseTextSelection):
541         (AccessibilityUIElement::stringForSelection):
542         (AccessibilityUIElement::stringForRange):
543         (AccessibilityUIElement::attributedStringForRange):
544         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
545         (AccessibilityUIElement::elementsForRange):
546         (AccessibilityUIElement::getLinkedUIElements):
547         (AccessibilityUIElement::getDocumentLinks):
548         (AccessibilityUIElement::attributesOfLinkedUIElements):
549         (AccessibilityUIElement::attributesOfDocumentLinks):
550         (AccessibilityUIElement::attributesOfChildren):
551         (AccessibilityUIElement::allAttributes):
552         (AccessibilityUIElement::stringAttributeValue):
553         (AccessibilityUIElement::isPressActionSupported):
554         (AccessibilityUIElement::isIncrementActionSupported):
555         (AccessibilityUIElement::isDecrementActionSupported):
556         (AccessibilityUIElement::boolAttributeValue):
557         (AccessibilityUIElement::isAttributeSettable):
558         (AccessibilityUIElement::isAttributeSupported):
559         (AccessibilityUIElement::parameterizedAttributeNames):
560         (AccessibilityUIElement::role):
561         (AccessibilityUIElement::subrole):
562         (AccessibilityUIElement::roleDescription):
563         (AccessibilityUIElement::title):
564         (AccessibilityUIElement::description):
565         (AccessibilityUIElement::orientation):
566         (AccessibilityUIElement::stringValue):
567         (AccessibilityUIElement::language):
568         (AccessibilityUIElement::helpText):
569         (AccessibilityUIElement::intValue):
570         (AccessibilityUIElement::minValue):
571         (AccessibilityUIElement::maxValue):
572         (AccessibilityUIElement::valueDescription):
573         (AccessibilityUIElement::insertionPointLineNumber):
574         (AccessibilityUIElement::isEnabled):
575         (AccessibilityUIElement::isRequired):
576         (AccessibilityUIElement::isFocused):
577         (AccessibilityUIElement::isSelected):
578         (AccessibilityUIElement::isExpanded):
579         (AccessibilityUIElement::isChecked):
580         (AccessibilityUIElement::hierarchicalLevel):
581         (AccessibilityUIElement::ariaIsGrabbed):
582         (AccessibilityUIElement::ariaDropEffects):
583         (AccessibilityUIElement::lineForIndex):
584         (AccessibilityUIElement::boundsForRange):
585         (AccessibilityUIElement::attributesOfColumnHeaders):
586         (AccessibilityUIElement::attributesOfRowHeaders):
587         (AccessibilityUIElement::attributesOfColumns):
588         (AccessibilityUIElement::attributesOfRows):
589         (AccessibilityUIElement::attributesOfVisibleCells):
590         (AccessibilityUIElement::attributesOfHeader):
591         (AccessibilityUIElement::rowCount):
592         (AccessibilityUIElement::columnCount):
593         (AccessibilityUIElement::indexInTable):
594         (AccessibilityUIElement::rowIndexRange):
595         (AccessibilityUIElement::columnIndexRange):
596         (AccessibilityUIElement::cellForColumnAndRow):
597         (AccessibilityUIElement::selectedTextRange):
598         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
599         (AccessibilityUIElement::setSelectedTextRange):
600         (AccessibilityUIElement::increment):
601         (AccessibilityUIElement::decrement):
602         (AccessibilityUIElement::showMenu):
603         (AccessibilityUIElement::press):
604         (AccessibilityUIElement::accessibilityValue):
605         (AccessibilityUIElement::documentEncoding):
606         (AccessibilityUIElement::documentURI):
607         (_accessibilityNotificationCallback):
608         (AccessibilityUIElement::addNotificationListener):
609         (AccessibilityUIElement::removeNotificationListener):
610         (AccessibilityUIElement::isFocusable):
611         (AccessibilityUIElement::isSelectable):
612         (AccessibilityUIElement::isMultiSelectable):
613         (AccessibilityUIElement::isSelectedOptionActive):
614         (AccessibilityUIElement::isVisible):
615         (AccessibilityUIElement::isOffScreen):
616         (AccessibilityUIElement::isCollapsed):
617         (AccessibilityUIElement::isIgnored):
618         (AccessibilityUIElement::hasPopup):
619         (AccessibilityUIElement::takeFocus):
620         (AccessibilityUIElement::takeSelection):
621         (AccessibilityUIElement::addSelection):
622         (AccessibilityUIElement::removeSelection):
623         (AccessibilityUIElement::uiElementForSearchPredicate):
624         (AccessibilityUIElement::numberAttributeValue):
625
626 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
627
628         [chromium] pass all focus handling methods through the WebTestDelegate
629         https://bugs.webkit.org/show_bug.cgi?id=111328
630
631         Reviewed by Nico Weber.
632
633         In content_shell, the focus handling is asynchronous. To allow for
634         switching the focus synchronously between WebViews, we need to intercept
635         didFocus and didBlur and forward it to the WebTestDelegate.
636
637         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
638         (WebTestDelegate):
639         (WebTestRunner::WebTestDelegate::setFocus):
640         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
641         (WebTestRunner::WebTestProxy::didFocus):
642         (WebTestRunner::WebTestProxy::didBlur):
643         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
644         (WebTestRunner::TestRunner::setWindowIsKey):
645         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
646         (WebTestRunner::WebTestProxyBase::didFocus):
647         (WebTestRunner):
648         (WebTestRunner::WebTestProxyBase::didBlur):
649         * DumpRenderTree/chromium/WebViewHost.cpp:
650         (WebViewHost::didFocus):
651         (WebViewHost::didBlur):
652         (WebViewHost::setFocus):
653         * DumpRenderTree/chromium/WebViewHost.h:
654         (WebViewHost):
655
656 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
657
658         [GTK] No need to manually add system paths to jhbuildrc
659         https://bugs.webkit.org/show_bug.cgi?id=110850
660
661         Reviewed by Gustavo Noronha Silva.
662
663         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
664         already takes care of.
665
666 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
667
668         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
669         https://bugs.webkit.org/show_bug.cgi?id=111284
670
671         Disabling the failing two tests on Android.
672
673         Reviewed by Jochen Eisinger.
674
675         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
676         (TestWebKitAPI):
677         (TestWebKitAPI::TEST):
678
679 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
680
681         Add build flag for FontLoader
682         https://bugs.webkit.org/show_bug.cgi?id=111289
683
684         Reviewed by Benjamin Poulain.
685
686         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
687
688         * Scripts/webkitperl/FeatureList.pm:
689         * qmake/mkspecs/features/features.pri:
690
691 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
692
693         [Mac] Get rid of a useless method from DOMHTMLInputElement
694         https://bugs.webkit.org/show_bug.cgi?id=111279
695
696         Reviewed by Sam Weinig.
697
698         * DumpRenderTree/mac/TestRunnerMac.mm:
699         (TestRunner::setValueForUser):
700         The method _setValueForUser: was added for testing. This feature is already
701         exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
702         in real use cases. Get rid of the method created for testing, use the real thing
703         instead.
704
705 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
706
707         Some perf. tests have variances that differ greatly between runs
708         https://bugs.webkit.org/show_bug.cgi?id=97510
709
710         Reviewed by Benjamin Poulain.
711
712         Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
713         environment on test results (we run each instance after one another, not in parallel).
714
715         We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
716         iterations as it was done previously in single process. These values are hard-coded in perftest.py
717         and runner.js but they are to be configurable in the future.
718
719         Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
720         metric now reports an array of the length 4 with each element containing an array of 5 iteration
721         values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
722
723         Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
724         and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
725         as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
726
727         * Scripts/webkitpy/performance_tests/perftest.py:
728         (PerfTestMetric.append_group): Renamed from append.
729         (PerfTestMetric.grouped_iteration_values): Added.
730         (PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
731
732         (PerfTest.__init__): Takes the number of processes (drivers) to run tests with.
733         This parameter is only used by SingleProcessPerfTest.
734
735         (PerfTest.run): Repeat tests using different driver processes.
736         (PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
737         since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
738         We instead use _ensure_metrics to obtain the matched metrics and store the data there.
739         (PerfTest._ensure_metrics): Added.
740
741         (SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
742         instances of DumpRenderTree/WebKitTestRunner takes too long.
743         (SingleProcessPerfTest.__init__):
744
745         (ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
746
747         (PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
748
749         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
750         _run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
751         the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
752
753         (TestPerfTestMetric.test_append): Updated per name and added some test cases for
754         grouped_iteration_values.
755
756         (TestPerfTest._assert_results_are_correct):
757
758         (TestSingleProcessPerfTest): Added.
759         (TestSingleProcessPerfTest.test_use_only_one_process):
760         (TestSingleProcessPerfTest.test_use_only_one_process.run_single):
761
762         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
763         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
764
765         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
766         sample standard deviations since we're now running tests 4 times.
767         (MainTest._test_run_with_json_output.mock_upload_json):
768         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
769
770 2013-03-03  Alexandre Elias  <aelias@chromium.org>
771
772         [chromium] Remove WebLayerTreeView::setViewportSize call
773         https://bugs.webkit.org/show_bug.cgi?id=110727
774
775         Reviewed by James Robinson.
776
777         After https://codereview.chromium.org/12328080 lands,
778         setViewportSize is called from the Chromium side. The multiplication
779         by deviceScaleFactor here was prone to off-by-one errors.
780         The layoutSize() function was only used here so delete it as well.
781
782         DumpRenderTree WebViewHost must now call this method as well.
783
784         * DumpRenderTree/chromium/WebViewHost.cpp:
785         (WebViewHost::initializeLayerTreeView):
786         (WebViewHost::setWindowRect):
787         (WebViewHost::setDeviceScaleFactor):
788         (WebViewHost::updateViewportSize):
789         * DumpRenderTree/chromium/WebViewHost.h:
790         (WebViewHost):
791
792 2013-02-27  Darin Adler  <darin@apple.com>
793
794         StringHasher functions require alignment that call sites do not all guarantee
795         https://bugs.webkit.org/show_bug.cgi?id=110171
796
797         Reviewed by Benjamin Poulain.
798
799         * TestWebKitAPI/CMakeLists.txt:
800         * TestWebKitAPI/GNUmakefile.am:
801         * TestWebKitAPI/TestWebKitAPI.gypi:
802         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
803         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
804         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
805         * TestWebKitAPI/Tests/WTF/WTF.pro:
806         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
807         Added the StringHasher.cpp file.
808
809         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
810         for the functions in the StringHasher class.
811
812 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
813
814         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
815         https://bugs.webkit.org/show_bug.cgi?id=109772
816
817         Reviewed by Andreas Kling.
818
819         * DumpRenderTree/TestRunner.cpp:
820         (TestRunner::staticFunctions):
821         * DumpRenderTree/TestRunner.h:
822         (TestRunner):
823         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
824         * DumpRenderTree/efl/TestRunnerEfl.cpp:
825         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
826         * DumpRenderTree/mac/TestRunnerMac.mm:
827         * DumpRenderTree/qt/TestRunnerQt.cpp:
828         * DumpRenderTree/qt/TestRunnerQt.h:
829         (TestRunner):
830         * DumpRenderTree/win/TestRunnerWin.cpp:
831         * DumpRenderTree/wx/TestRunnerWx.cpp:
832         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
833         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
834         * WebKitTestRunner/InjectedBundle/TestRunner.h:
835         (TestRunner):
836
837 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
838
839         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
840         https://bugs.webkit.org/show_bug.cgi?id=110943
841
842         Reviewed by Yury Semikhatsky.
843
844         Unfortunately in many cases raw pointer may point to an object that has been deleted.
845         There is no working solution to solve this problem in general.
846         It could be solved only on case by case basis.
847
848         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
849         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
850         (TestWebKitAPI::TEST):
851
852 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
853
854         Move markerTextForListItem from TestRunner to Internals
855         https://bugs.webkit.org/show_bug.cgi?id=110939
856
857         Reviewed by Benjamin Poulain.
858
859         * DumpRenderTree/TestRunner.cpp:
860         (TestRunner::staticFunctions):
861         * DumpRenderTree/TestRunner.h:
862         (TestRunner):
863         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
864         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
865         (WebTestRunner::TestRunner::TestRunner):
866         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
867         (TestRunner):
868         * DumpRenderTree/efl/TestRunnerEfl.cpp:
869         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
870         * DumpRenderTree/mac/TestRunnerMac.mm:
871         * DumpRenderTree/qt/TestRunnerQt.cpp:
872         * DumpRenderTree/qt/TestRunnerQt.h:
873         (TestRunnerQt):
874         * DumpRenderTree/win/TestRunnerWin.cpp:
875         * DumpRenderTree/wx/TestRunnerWx.cpp:
876         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
877         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
878         * WebKitTestRunner/InjectedBundle/TestRunner.h:
879         (TestRunner):
880
881 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
882
883         Don't use legacy test names when returning results from PerfTest.run
884         https://bugs.webkit.org/show_bug.cgi?id=111148
885
886         Reviewed by Dirk Pranke.
887
888         * Scripts/webkitpy/performance_tests/perftest.py:
889         (PerfTestMetric.name): Renamed from metric.
890         (PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
891         (PerfTest.run): Use metric name instead of the legacy name to store iteration values.
892         (ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
893
894         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
895         (TestPerfTestMetric.test_init_set_time_metric):
896         (TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
897         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
898         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
899
900         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
901         (PerfTestsRunner.__init__):
902         (PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
903         to obtain the trac URL instead of hard coding it.
904         (PerfTestsRunner._run_tests_set):
905
906 2013-03-01  Roger Fong  <roger_fong@apple.com>
907
908         Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
909         https://bugs.webkit.org/show_bug.cgi?id=111202
910
911         This is useful for running VCExpress builds from command line because there is
912         no unified solution output, only per project build logs.
913         The project will be run as the last project in the solution.
914
915         * win/AssembleBuildLogs: Added.
916         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
917         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
918         * win/AssembleBuildLogs/AssembleLogs.cmd: Added.
919         * win/AssembleBuildLogs/README: Added.
920
921 2013-03-01  Roger Fong  <roger_fong@apple.com>
922
923         Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
924
925         * EWSTools/start-queue-win.sh:
926
927 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
928
929         Don't return statistics in PerfTest.run
930         https://bugs.webkit.org/show_bug.cgi?id=111145
931
932         Reviewed by Dirk Pranke.
933
934         Simply return a list of values obtained in each iteration from PerfTest.run.
935         Also simplify various methods as needed.
936
937         * Scripts/webkitpy/performance_tests/perftest.py:
938         (PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
939         as needed from PerfTestsRunner._generate_results_dict.
940
941         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
942         that we don't have to worry about the backward compatibility here.
943
944         (PerfTestMetric.iteration_values): Added.
945         (PerfTestMetric.unit): Added.
946         (PerfTestMetric.metric_to_unit):
947         (PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
948
949         (PerfTest.run):
950         (PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
951
952         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
953         (TestPerfTestMetric.test_init_set_missing_unit):
954         (TestPerfTestMetric.test_init_set_time_metric): Added.
955         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
956         (TestPerfTestMetric.test_append):
957         (TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
958         test cases and it's not critical to keep math right as they're not used in output JSON anymore.
959         (TestPerfTest._assert_results_are_correct):
960         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
961         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
962
963         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
964         (PerfTestsRunner._generate_results_dict):
965
966         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
967         (EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
968         (SomeParserTestData): Ditto.
969         (MemoryTestData): Ditto.
970
971 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
972
973         [Qt] Enable LINK_PREFETCH
974         https://bugs.webkit.org/show_bug.cgi?id=111158
975
976         Reviewed by Simon Hausmann.
977
978         * qmake/mkspecs/features/features.pri:
979
980 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
981
982         [Qt] Update features.pri with new features
983         https://bugs.webkit.org/show_bug.cgi?id=111157
984
985         Reviewed by Jocelyn Turcotte.
986
987         * qmake/mkspecs/features/features.pri:
988
989 2013-03-01  Jochen Eisinger  <jochen@chromium.org>
990
991         [chromium] put WebTestProxy::scheduleComposite back in place
992         https://bugs.webkit.org/show_bug.cgi?id=111146
993
994         Reviewed by Nico Weber.
995
996         The call was removed in http://trac.webkit.org/changeset/144398 because
997         DRT doesn't need it. However, content shell depends on this call.
998
999         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1000         (WebTestRunner::WebTestProxy::scheduleComposite):
1001
1002 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1003
1004         Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
1005         https://bugs.webkit.org/show_bug.cgi?id=111142
1006
1007         Reviewed by Adam Barth.
1008
1009         Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
1010
1011         Also removed _print_status since it's never used anywhere.
1012
1013         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1014         (PerfTestsRunner.run):
1015         (PerfTestsRunner._run_tests_set):
1016         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1017         (MainTest.run_test):
1018         (MainTest.test_run_test_set):
1019         (MainTest.test_run_test_set_kills_drt_per_run):
1020         (MainTest.test_run_test_set_for_parser_tests):
1021
1022 2013-02-28  Kiran Muppala  <cmuppala@apple.com>
1023
1024         Disable window occlusion detection for WebKitTestRunner Web View on Mac
1025         https://bugs.webkit.org/show_bug.cgi?id=111116
1026
1027         Reviewed by Simon Fraser.
1028
1029         Window occlusion notifications were causing WebKitTestRunner's Web View
1030         to be detected as occluded and causing a few JavaScript timer layout
1031         tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
1032         by initializing the page visibility to "visible" after creating the view.
1033         But a better solution is to disable window occlusion detection, so that
1034         not only the page but also the view is treated as visible.
1035
1036         * WebKitTestRunner/TestController.cpp:
1037         (WTR::TestController::createWebViewWithOptions): Remove call to
1038         setVisibilityState, since it is no longer necessary.
1039         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1040         (WTR::PlatformWebView::PlatformWebView): Disable window occlusion
1041         detection for the created WKView.
1042
1043 2013-02-28  Li Yin  <li.yin@intel.com>
1044
1045         [chromium] Events can't be triggered on MediaStreamTrack
1046         https://bugs.webkit.org/show_bug.cgi?id=110930
1047
1048         Reviewed by Kentaro Hara.
1049
1050         Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
1051
1052         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
1053         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
1054
1055 2013-02-27  James Robinson  <jamesr@chromium.org>
1056
1057         [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
1058         https://bugs.webkit.org/show_bug.cgi?id=111017
1059
1060         Reviewed by Adam Barth.
1061
1062         This decouples DumpRenderTree from WebLayerTreeViewClient.
1063
1064         * DumpRenderTree/chromium/WebViewHost.cpp:
1065         (WebViewHostDRTLayerTreeViewClient):
1066         (WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
1067         (WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
1068         (WebViewHostDRTLayerTreeViewClient::Layout):
1069         (WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
1070         (WebViewHost::initializeLayerTreeView):
1071         * DumpRenderTree/chromium/WebViewHost.h:
1072         (webkit_support):
1073         (WebViewHost):
1074
1075 2013-02-28  Ryuan Choi  <ryuan.choi@samsung.com>
1076
1077         Unreviewed, add my secondary email address to the list.
1078
1079         * Scripts/webkitpy/common/config/committers.py:
1080
1081 2013-02-28  Philip Rogers  <pdr@google.com>
1082
1083         Add Philip Rogers as a reviewer.
1084
1085         Unreviewed update of committers.py.
1086
1087         * Scripts/webkitpy/common/config/committers.py:
1088
1089 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1090
1091         Merge more methods on PerfTest
1092         https://bugs.webkit.org/show_bug.cgi?id=111030
1093
1094         Reviewed by Dirk Pranke.
1095
1096         Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
1097         and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
1098
1099         This makes the control flow a lot more comprehensible.
1100
1101         * Scripts/webkitpy/performance_tests/perftest.py:
1102         (PerfTest._run_with_driver):
1103         (PerfTest._should_ignore_line):
1104         (PerfTest._filter_output):
1105
1106         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1107         (TestPerfTest._assert_results_are_correct):
1108         (test_ignored_stderr_lines):
1109
1110 2013-02-28  Robert Hogan  <robert@webkit.org>
1111
1112         Update my IRC nick
1113
1114         Unreviewed.
1115
1116         * Scripts/webkitpy/common/config/committers.py:
1117
1118 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1119
1120         [Qt] Enable thin archives before parsing the project files
1121
1122         Rubber-stamped by Simon Hausmann.
1123
1124         The targetSubDir() function can be called before default_post.prf has been
1125         parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
1126         which is parsed before the main project file.
1127         This issue was revealed by r144299 and fixes the clean build.
1128
1129         * qmake/mkspecs/features/default_post.prf:
1130         * qmake/mkspecs/features/default_pre.prf:
1131
1132 2013-02-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1133
1134         [Qt] Enable CANVAS_PATH flag
1135         https://bugs.webkit.org/show_bug.cgi?id=108508
1136
1137         Reviewed by Simon Hausmann.
1138
1139         Also enable CANVAS_PATH flag for Qt.
1140
1141         * qmake/mkspecs/features/features.pri:
1142
1143 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1144
1145         [Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
1146
1147         Rubber-stamped by Csaba Osztrogonác.
1148
1149         Besides suppressing a warning about the non-existing function this
1150         fixes the build if there is a subdirectory (eg. debug-and-release).
1151
1152         * TestWebKitAPI/InjectedBundle.pri:
1153         * TestWebKitAPI/TestWebKitAPI.pri:
1154
1155 2013-02-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1156
1157         [EFL][WTR] WTR cannot load injected bundle
1158         https://bugs.webkit.org/show_bug.cgi?id=111063
1159
1160         Reviewed by Csaba Osztrogonác.
1161
1162         WTR was not able to load injected bundle because of undefined 
1163         symbols for AccessibilityUIElement::scrollToMakeVisible(). 
1164         Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
1165         solves the problem.
1166
1167         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1168         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1169
1170 2013-02-28  Alberto Garcia  <albgarcia@rim.com>
1171
1172         [BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
1173         https://bugs.webkit.org/show_bug.cgi?id=110464
1174
1175         Reviewed by Rob Buis.
1176
1177         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1178
1179 2013-02-28  Xan Lopez  <xlopez@rim.com>
1180
1181         [BlackBerry] DumpRenderTreeSupport: update the set position methods
1182         https://bugs.webkit.org/show_bug.cgi?id=110578
1183
1184         Reviewed by Rob Buis.
1185
1186         TestRunner::setMockGeolocationPosition() changed in r130416:
1187         http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
1188
1189         DumpRenderTreeSupport::setMockGeolocationError() was renamed to
1190         setMockGeolocationPositionUnavailableError() in r129444:
1191         http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
1192
1193         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1194         (TestRunner::setMockGeolocationPosition):
1195         (TestRunner::setMockGeolocationPositionUnavailableError):
1196
1197 2013-02-28  Xan Lopez  <xlopez@rim.com>
1198
1199         [BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
1200         https://bugs.webkit.org/show_bug.cgi?id=110465
1201
1202         Reviewed by Rob Buis.
1203
1204         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1205         (LoadItem::invoke):
1206
1207 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1208
1209         PerfTestRunner doesn't need _needs_http and _has_http_lock
1210         https://bugs.webkit.org/show_bug.cgi?id=111037
1211
1212         Reviewed by Adam Barth.
1213
1214         Delete these variables in favor of using a local variable.
1215
1216         Member variables are like global variables. They introduce implicit dependencies
1217         between member functions.
1218
1219         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1220         (PerfTestsRunner.__init__):
1221         (PerfTestsRunner._start_http_servers):
1222         (PerfTestsRunner):
1223         (PerfTestsRunner._stop_http_servers):
1224         (PerfTestsRunner.run):
1225
1226 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1227
1228         Unreviewed, rolling out r144224.
1229         http://trac.webkit.org/changeset/144224
1230         https://bugs.webkit.org/show_bug.cgi?id=111045
1231
1232         Caused plugins/pass-different-npp-struct.html to time out
1233         (Requested by abarth on #webkit).
1234
1235         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1236         (PassDifferentNPPStruct::NPP_SetWindow):
1237         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1238         (NPP_SetWindow):
1239
1240 2013-02-27  Adam Barth  <abarth@webkit.org>
1241
1242         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
1243         https://bugs.webkit.org/show_bug.cgi?id=110907
1244
1245         Reviewed by Eric Seidel.
1246
1247         This patch changes --enable-threaded-html-parser into
1248         --disable-threaded-html-parser and thereby enables the threaded HTML
1249         parser by default for the Chromium port.
1250
1251         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1252         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1253         (WebTestRunner::WebPreferences::reset):
1254         * DumpRenderTree/chromium/TestShell.cpp:
1255         (TestShell::TestShell):
1256
1257 2013-02-27  Kiran Muppala  <cmuppala@apple.com>
1258
1259         Initialize page visibility after creating WebKitTestRunner WebView on Mac
1260         https://bugs.webkit.org/show_bug.cgi?id=111025
1261
1262         Reviewed by Simon Fraser.
1263
1264         Set page visibility to "visible" after creating WebView to override
1265         visibility state inferred from window occlusion notifications on Mac.
1266
1267         * WebKitTestRunner/TestController.cpp:
1268         (WTR::TestController::createWebViewWithOptions): Add call to
1269         setVisibilityState.
1270
1271 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1272
1273         Merge PageLoadingPerfTest into ReplayPerfTest
1274         https://bugs.webkit.org/show_bug.cgi?id=111027
1275
1276         Reviewed by Dirk Pranke.
1277
1278         Merged two classes.
1279
1280         We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
1281         part of ReplayPerfTest.
1282
1283         * Scripts/webkitpy/performance_tests/perftest.py:
1284         (ReplayPerfTest): Moved _FORCE_GC_FILE here.
1285         (ReplayPerfTest.__init__):
1286         (ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
1287         (ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
1288         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1289         (TestReplayPerfTest):
1290         (TestReplayPerfTest.test_run_single.run_test):
1291         (TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
1292         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
1293         TestPageLoadingPerfTest.test_run.
1294         (TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
1295         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
1296         TestPageLoadingPerfTest.test_run_with_memory_output
1297         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
1298         (TestReplayPerfTest.test_prepare_calls_run_single):
1299
1300 2013-02-27  Eric Seidel  <eric@webkit.org>
1301
1302         Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
1303         https://bugs.webkit.org/show_bug.cgi?id=111021
1304
1305         Reviewed by Dirk Pranke.
1306
1307         The underlying code (which is shared with run-webkit-tests)
1308         already knew how to support this option, it just wasn't exposed
1309         via the run-perf-tests front-end.  This patch fixes that.
1310
1311         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1312         (PerfTestsRunner._parse_args):
1313
1314 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1315
1316         Stop uploading results to webkit-perf.appspot.com
1317         https://bugs.webkit.org/show_bug.cgi?id=110954
1318
1319         Reviewed by Benjamin Poulain.
1320
1321         Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
1322
1323         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1324         (RunAndUploadPerfTests):
1325
1326 2013-02-27  James Simonsen  <simonjam@chromium.org>
1327
1328         [chromium] Lower priority of preloaded images
1329         https://bugs.webkit.org/show_bug.cgi?id=110527
1330
1331         Plumb the didChangePriority signal into DRT so it can be tested.
1332
1333         Reviewed by Nate Chapin.
1334
1335         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1336         (WebKit):
1337         (WebTestRunner::WebTestProxy::didChangeResourcePriority):
1338         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1339         (WebTestRunner::TestRunner::TestRunner):
1340         (WebTestRunner::TestRunner::reset):
1341         (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
1342         (WebTestRunner):
1343         (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
1344         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1345         (TestRunner):
1346         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1347         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
1348         (WebTestRunner::WebTestProxyBase::willSendRequest):
1349         (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
1350         (WebTestRunner):
1351
1352 2013-02-27  Chris Fleizach  <cfleizach@apple.com>
1353
1354         AX: Mac platform should support ability to scroll an element into visible
1355         https://bugs.webkit.org/show_bug.cgi?id=109860
1356
1357         Reviewed by Beth Dakin.
1358
1359         * DumpRenderTree/AccessibilityUIElement.cpp:
1360         (scrollToMakeVisibleCallback):
1361         (AccessibilityUIElement::getJSClass):
1362         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1363         (AccessibilityUIElement::scrollToMakeVisible):
1364         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1365         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1366         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1367         (AccessibilityUIElement):
1368         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1369         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1370         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1371         (WTR):
1372
1373 2013-02-27  John Bauman  <jbauman@chromium.org>
1374
1375         Plugin in iframe may not display
1376         https://bugs.webkit.org/show_bug.cgi?id=109879
1377
1378         Reviewed by Simon Fraser.
1379
1380         LogNPPSetWindow will be used with other ports as well.
1381
1382         * DumpRenderTree/DumpRenderTree.gypi:
1383         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1384
1385 2013-02-27  Jochen Eisinger  <jochen@chromium.org>
1386
1387         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
1388         https://bugs.webkit.org/show_bug.cgi?id=110973
1389
1390         Reviewed by Adam Barth.
1391
1392         There is nothing that ensures that the log messages from the plugin
1393         come in before the layout test finished loading.
1394
1395         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1396         (PassDifferentNPPStruct::NPP_SetWindow):
1397         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1398         (NPP_SetWindow):
1399
1400 2013-02-27  Glenn Adams  <glenn@skynav.com>
1401
1402         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
1403         https://bugs.webkit.org/show_bug.cgi?id=110944
1404
1405         Reviewed by Dean Jackson.
1406
1407         * Scripts/webkitperl/FeatureList.pm:
1408         * qmake/mkspecs/features/features.pri:
1409
1410 2013-02-27  Yong Li  <yong.li.webkit@outlook.com>
1411
1412         Unreviewed. Remove myself from watchlist.
1413
1414         * Scripts/webkitpy/common/config/watchlist:
1415
1416 2013-02-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1417
1418         Switch QtWebKit to GStreamer 1.0.
1419         https://bugs.webkit.org/show_bug.cgi?id=106669.
1420
1421         Original patch by Sebastian Dröge.
1422         Reviewed by Csaba Osztrogonác.
1423
1424         Build with GStreamer 1.0 if available, but support GStreamer 0.10 
1425         temporarily to make upgrading easy and the patch suitable for Qt5.
1426
1427         * qmake/mkspecs/features/features.prf:
1428
1429 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
1430
1431         Unreviewed. Added myself to committers.py
1432
1433         * Scripts/webkitpy/common/config/committers.py:
1434
1435 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1436
1437         Unreviewed, rolling out r144192.
1438         http://trac.webkit.org/changeset/144192
1439         https://bugs.webkit.org/show_bug.cgi?id=110984
1440
1441         Stored svn password on wrong computer (Requested by kkristof
1442         on #webkit).
1443
1444         * Scripts/webkitpy/common/config/committers.py:
1445
1446 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
1447
1448         Unreviewed. Added myself to committers.py
1449
1450         * Scripts/webkitpy/common/config/committers.py:
1451
1452 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1453
1454         Build fix after r144155. The report page is located at /api/report, not /api/test/report.
1455
1456         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1457         (PerfTestsRunner._upload_json):
1458
1459 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1460
1461         Stop uploading results to webkit-perf.appspot.com
1462         https://bugs.webkit.org/show_bug.cgi?id=110954
1463
1464         Reviewed by Benjamin Poulain.
1465
1466         When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
1467         Also, always use the new JSON format. Removed the code to generate the old format.
1468
1469         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1470         (PerfTestsRunner._generate_and_show_results):
1471         (PerfTestsRunner._generate_results_dict):
1472         (PerfTestsRunner._merge_slave_config_json):
1473         (PerfTestsRunner._generate_output_files):
1474
1475 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1476
1477         Unreviewed, rolling out r144136, r144143, and r144147.
1478         http://trac.webkit.org/changeset/144136
1479         http://trac.webkit.org/changeset/144143
1480         http://trac.webkit.org/changeset/144147
1481         https://bugs.webkit.org/show_bug.cgi?id=110950
1482
1483         Caused some timeouts and flaky crashes (Requested by abarth on
1484         #webkit).
1485
1486         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1487         (main):
1488         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1489         (WebTestRunner::WebPreferences::reset):
1490         * DumpRenderTree/chromium/TestShell.cpp:
1491         (TestShell::TestShell):
1492
1493 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1494
1495         Use perf.webkit.org JSON format in results page
1496         https://bugs.webkit.org/show_bug.cgi?id=110842
1497
1498         Reviewed by Benjamin Poulain.
1499
1500         Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
1501
1502         A whole bunch of integration tests have been updated to use the new JSON format.
1503
1504         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1505         (PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
1506         and legacy_output_json_path respectively.
1507         (PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
1508         (PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
1509         JSON file and the results page out of perf_webkit_output instead of legacy_output.
1510
1511         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1512         (MainTest.test_run_memory_test):
1513         (MainTest._test_run_with_json_output.mock_upload_json):
1514         (MainTest):
1515         (MainTest.test_run_with_json_output):
1516         (MainTest.test_run_with_description):
1517         (MainTest.test_run_generates_json_by_default):
1518         (MainTest.test_run_merges_output_by_default):
1519         (MainTest.test_run_respects_reset_results):
1520         (MainTest.test_run_generates_and_show_results_page):
1521         (MainTest.test_run_with_slave_config_json):
1522         (MainTest.test_run_with_multiple_repositories):
1523         (MainTest.test_run_with_upload_json):
1524         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1525
1526 2013-02-26  Adam Barth  <abarth@webkit.org>
1527
1528         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
1529         https://bugs.webkit.org/show_bug.cgi?id=110907
1530
1531         Reviewed by Eric Seidel.
1532
1533         This patch changes --enable-threaded-html-parser into
1534         --disable-threaded-html-parser and thereby enables the threaded HTML
1535         parser by default for the Chromium port.
1536
1537         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1538         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1539         (WebTestRunner::WebPreferences::reset):
1540         * DumpRenderTree/chromium/TestShell.cpp:
1541         (TestShell::TestShell):
1542
1543 2013-02-26  Dirk Pranke  <dpranke@chromium.org>
1544
1545         [chromium] Re-enable the fixed version of freetype on linux
1546         https://bugs.webkit.org/show_bug.cgi?id=110542
1547
1548         Reviewed by Tony Chang.
1549
1550         Re-land the change in r143794 to switch to building with a fixed
1551         version of FreeType for just DumpRenderTree. This allows us to share
1552         one version of pixel baselines for both Lucid and Precise, and run the
1553         layout tests in a stock Precise install (instead of a Lucid chroot).
1554         Going forward, this approach isolates us from os-level changes to the
1555         version of FreeType. Note that Chromium itself still uses the system
1556         FreeType and is unaffected by this change.
1557         
1558         This setting can still be turned off (at compile/gyp-time) by
1559         manually setting use_custom_freetype=0.
1560
1561         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1562
1563 2013-02-26  Nico Weber  <thakis@chromium.org>
1564
1565         [chromium] content shell drt: Enable WebKit::setLayoutTestMode()
1566         https://bugs.webkit.org/show_bug.cgi?id=110890
1567
1568         Reviewed by Jochen Eisinger.
1569
1570         Several functions in webkit check that bit to change rendering
1571         in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
1572         disables font smoothing in this mode. TestShell and DRT both set
1573         this flag, so content shell drt should set it too.
1574
1575         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1576         (WebTestRunner::TestInterfaces::TestInterfaces):
1577
1578 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
1579
1580         new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
1581         https://bugs.webkit.org/show_bug.cgi?id=110884
1582
1583         Reviewed by Csaba Osztrogonác.
1584
1585         Adding the missing spaces before ':' in the unit test.
1586
1587         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1588
1589 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
1590
1591         new-commit-bot: Some IRC clients doesn't linkify rollout messages
1592         https://bugs.webkit.org/show_bug.cgi?id=110861
1593
1594         Reviewed by Ryosuke Niwa.
1595
1596         Adding the space before ':' in order to fix the links shown for the rollout message.
1597
1598         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1599         (NewCommitBot._summarize_commit_log):
1600
1601 2013-02-26  Joone Hur  <joone.hur@intel.com>
1602
1603         [GTK] Add Clutter to jhbuild
1604         https://bugs.webkit.org/show_bug.cgi?id=110245
1605
1606         Reviewed by Martin Robinson.
1607
1608         Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
1609         This allows to build WebKitGtk+ with clutter as an acceleration backend
1610         within the jhbuild environment. 
1611
1612         * gtk/jhbuild-optional.modules:
1613
1614 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1615
1616         Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
1617
1618         * Scripts/webkitpy/common/checkout/scm/svn.py:
1619         (SVN.value_from_svn_info):
1620
1621 2013-02-25  Alan Cutter  <alancutter@chromium.org>
1622
1623         GCE EWS bots failing intermittently on HTTP 502 error while updating their status
1624         https://bugs.webkit.org/show_bug.cgi?id=110845
1625
1626         Unreviewed EWS bot fix.
1627
1628         Switch the Queue Status Server address the EWS bots use to a more direct URL that
1629         doesn't seem to be having problems from GCE like queues.webkit.org.
1630
1631         * Scripts/webkitpy/common/net/statusserver.py:
1632         (StatusServer):
1633
1634 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
1635
1636         Forgot to delete a no-longer-needed unit test after r143980.
1637
1638         Unreviewed, build fix.
1639
1640         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1641         (ChromiumWinTest.test_path_to_image_diff):
1642
1643 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1644
1645         Build fix. run-perf-tests was reporting with revision numbers ending with \r.
1646         Don't include \r at the end of svn info lines on Windows.
1647
1648         This is similar to r143839.
1649
1650         * Scripts/webkitpy/common/checkout/scm/svn.py:
1651         (SVN.value_from_svn_info):
1652
1653 2013-02-25  James Simonsen  <simonjam@chromium.org>
1654
1655         [Resource Timing] Update test suite so it can be exported to the W3C
1656         https://bugs.webkit.org/show_bug.cgi?id=107343
1657
1658         Reviewed by Tony Gentilcore.
1659
1660         * Scripts/export-w3c-performance-wg-tests: Clean up output.
1661         * Scripts/import-w3c-performance-wg-tests:
1662
1663 2013-02-25  Anders Carlsson  <andersca@apple.com>
1664
1665         Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
1666         https://bugs.webkit.org/show_bug.cgi?id=110821
1667         <rdar://problem/13265303>
1668
1669         Reviewed by Beth Dakin.
1670
1671         Update for WebKit2 changes.
1672
1673         * MiniBrowser/mac/WK2BrowserWindowController.m:
1674         (-[WK2BrowserWindowController awakeFromNib]):
1675         * WebKitTestRunner/TestController.cpp:
1676         (WTR::TestController::createOtherPage):
1677         (WTR::TestController::createWebViewWithOptions):
1678         (WTR::TestController::unavailablePluginButtonClicked):
1679         * WebKitTestRunner/TestController.h:
1680         (TestController):
1681
1682 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
1683
1684         Optionally partition cache to prevent using cache for tracking
1685         https://bugs.webkit.org/show_bug.cgi?id=110269
1686
1687         Reviewed by Maciej Stachowiak.
1688
1689         Add test suite for public suffix functions on Mac.
1690
1691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1692         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
1693         (TestWebKitAPI):
1694         (TestWebKitAPI::TEST_F):
1695
1696 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
1697
1698         nrwt: reenable multiple http shards on chromium win
1699         https://bugs.webkit.org/show_bug.cgi?id=110814
1700
1701         Reviewed by Tony Chang.
1702
1703         The underlying bug in DumpRenderTree that was causing us to look for a
1704         pac file and timeout under load was fixed a while ago.
1705
1706         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1707         (ChromiumWinPort.relative_test_filename):
1708
1709 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
1710
1711         Make ninja the default w/ build-webkit --chromium on windows.
1712         https://bugs.webkit.org/show_bug.cgi?id=110731
1713
1714         Unreviewed - TBR'ing thakis :).
1715
1716         * Scripts/update-webkit-chromium:
1717
1718 2013-02-25  Anders Carlsson  <andersca@apple.com>
1719
1720         Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
1721         https://bugs.webkit.org/show_bug.cgi?id=110793
1722         <rdar://problem/13265303>
1723
1724         Reviewed by Sam Weinig.
1725
1726         Update for WebKit2 API changes.
1727
1728         * MiniBrowser/mac/WK2BrowserWindowController.m:
1729         (-[WK2BrowserWindowController awakeFromNib]):
1730         * WebKitTestRunner/TestController.cpp:
1731         (WTR::TestController::createWebViewWithOptions):
1732
1733 2013-02-25  Nico Weber  <thakis@chromium.org>
1734
1735         Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
1736         https://bugs.webkit.org/show_bug.cgi?id=110775
1737
1738         Unreviewed, basically a rebaseline.
1739
1740         * Scripts/webkitpy/common/config/watchlist:
1741
1742 2013-02-25  Nico Weber  <thakis@chromium.org>
1743
1744         [chromium] Try to get the webkit builder to use msvs again
1745         https://bugs.webkit.org/show_bug.cgi?id=110771
1746
1747         Reviewed by Eric Seidel.
1748
1749         The msvs gyp generator apparently doesn't write the sln file on every
1750         run, so check the vcxproj file instead.
1751
1752         * Scripts/webkitdirs.pm:
1753         (determineIsChromiumNinja):
1754
1755 2013-02-25  Nico Weber  <thakis@chromium.org>
1756
1757         [chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
1758         https://bugs.webkit.org/show_bug.cgi?id=110767
1759
1760         Reviewed by Eric Seidel.
1761
1762         The tester runs gyp, which generates out/Release/build.ninja. The bot
1763         scripts use existence (and timestamp) of that file to decide if the
1764         current build is supposed to be ninja or xcodebuild. The file exists,
1765         so the snapshot is extracted to out/Release. The snapshot doesn't
1766         contain build.ninja however due to
1767         http://trac.webkit.org/changeset/140375 , so after extracting the
1768         snapshot the scripts think that this is an xcodebuild build. So remove
1769         the part of that revision that removed ninja files from the archive,
1770         and the bots should be happy again.
1771
1772         * BuildSlaveSupport/built-product-archive:
1773         (archiveBuiltProduct):
1774
1775 2013-02-25  Nico Weber  <thakis@chromium.org>
1776
1777         Fix tests after r143910
1778         https://bugs.webkit.org/show_bug.cgi?id=110757
1779
1780         Reviewed by Andreas Kling.
1781
1782         While here, also add a test for the bug r143910 fixed.
1783
1784         * Scripts/webkitpy/common/system/executive_unittest.py:
1785         (ScriptErrorTest.test_message_with_output):
1786         (ScriptErrorTest):
1787         (ScriptErrorTest.test_message_with_tuple):
1788
1789 2013-02-25  Nico Weber  <thakis@chromium.org>
1790
1791         [chromium] Apparently built-product-archive is written in Python, not Perl :-/
1792         https://bugs.webkit.org/show_bug.cgi?id=110755
1793
1794         Reviewed by Jochen Eisinger.
1795
1796         * BuildSlaveSupport/built-product-archive:
1797         (archiveBuiltProduct):
1798         (extractBuiltProduct):
1799
1800 2013-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1801
1802         Unreviewed, rolling out r143895.
1803         http://trac.webkit.org/changeset/143895
1804         https://bugs.webkit.org/show_bug.cgi?id=110758
1805
1806         broke a bunch of tests (Requested by thakis__ on #webkit).
1807
1808         * Scripts/update-webkit-chromium:
1809
1810 2013-02-25  Andreas Kling  <akling@apple.com>
1811
1812         Unreviewed, fix simple mistake in r143903.
1813         <http://webkit.org/b/110746>
1814
1815         Reviewed by Andreas Kling.
1816
1817         Pass git revision, not svn revision, to git shell command.
1818
1819         * Scripts/webkitpy/common/checkout/scm/git.py:
1820         (Git.timestamp_of_latest_commit):
1821
1822 2013-02-25  Nico Weber  <thakis@chromium.org>
1823
1824         [chromium] Let built-product-archive log which directory it's archiving from and extracting to
1825         https://bugs.webkit.org/show_bug.cgi?id=110748
1826
1827         Reviewed by Jochen Eisinger.
1828
1829         One of the mac testers runs DRT from out/ but WebKitUnitTests from
1830         xcodebuild. I'm trying to understand what's going on.
1831
1832         * BuildSlaveSupport/built-product-archive:
1833         (archiveBuiltProduct):
1834         (extractBuiltProduct):
1835
1836 2013-02-23  Ilya Tikhonovsky  <loislo@chromium.org>
1837
1838         Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
1839         https://bugs.webkit.org/show_bug.cgi?id=110599
1840
1841         Reviewed by Yury Semikhatsky.
1842
1843         Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
1844         that were given us via MemoryInstrumentation calls.
1845         So I extended client api with registerString method that pushes the strings
1846         down to the serializer.
1847
1848         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1849         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
1850         (TestWebKitAPI::Helper::Helper):
1851         (Helper):
1852         (TestWebKitAPI::Helper::addNode):
1853         (TestWebKitAPI::TEST):
1854
1855 2013-02-25  Nico Weber  <thakis@chromium.org>
1856
1857         Make ScriptError not crash when args is a tuple
1858         https://bugs.webkit.org/show_bug.cgi?id=110747
1859
1860         Reviewed by Jochen Eisinger.
1861
1862         I'm trying to understand the error on
1863         http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
1864         better. I'll likely have to revert the ninja switch on windows, but
1865         having error reporting code that doesn't itself crash sounds like a
1866         good thing to have anyways.
1867
1868         The problem is that '%s' % (1, 2) errors out, and args is sometimes a
1869         tuple not a list.
1870
1871         * Scripts/run-chromium-webkit-unit-tests:
1872         * Scripts/webkitpy/common/system/executive.py:
1873         (ScriptError.__init__):
1874
1875 2013-02-25  Laszlo Gombos  <l.gombos@samsung.com>
1876
1877         [EFL] Align feature defaults
1878         https://bugs.webkit.org/show_bug.cgi?id=110715
1879
1880         Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
1881         OptionsEfl.cmake.
1882
1883         Reviewed by Gyuyoung Kim.
1884
1885         * Scripts/webkitperl/FeatureList.pm:
1886
1887 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1888
1889         run-perf-tests reports wrong commit time
1890         https://bugs.webkit.org/show_bug.cgi?id=110746
1891
1892         Reviewed by Andreas Kling.
1893
1894         The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
1895         of when the subdirectory was last modified.
1896
1897         Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
1898         insufficient since running "svn log -r <revision>" on a partial checkout only returns
1899         an empty result if the revision didn't modify the subdirectory.
1900
1901         For git, there is no partial checkout, so we just need to pass in "-r" option to keep
1902         the interface compatible with svn.
1903
1904         * Scripts/webkitpy/common/checkout/scm/git.py:
1905         (Git.timestamp_of_latest_commit):
1906         * Scripts/webkitpy/common/checkout/scm/scm.py:
1907         (SCM.timestamp_of_latest_commit):
1908         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1909         (MockSCM.timestamp_of_latest_commit):
1910         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1911         (test_timestamp_of_latest_commit):
1912         * Scripts/webkitpy/common/checkout/scm/svn.py:
1913         (SVN.timestamp_of_latest_commit):
1914         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1915         (PerfTestsRunner._generate_results_dict):
1916
1917 2013-02-25  Jochen Eisinger  <jochen@chromium.org>
1918
1919         [chromium] move WebRuntimeFeatures configuration to TestRunner library
1920         https://bugs.webkit.org/show_bug.cgi?id=110712
1921
1922         Reviewed by Nico Weber.
1923
1924         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1925         (WebTestRunner::TestInterfaces::TestInterfaces):
1926         * DumpRenderTree/chromium/TestShell.cpp:
1927         (TestShell::TestShell):
1928
1929 2013-02-25  Nico Weber  <thakis@chromium.org>
1930
1931         Make ninja the default build system for build-webkit --chromium on windows
1932         https://bugs.webkit.org/show_bug.cgi?id=110731
1933
1934         Reviewed by Jochen Eisinger.
1935
1936         With http://crbug.com/169945 fixed, this should now work.
1937
1938         * Scripts/update-webkit-chromium:
1939
1940 2013-02-24  Gustavo Noronha Silva  <gns@gnome.org>
1941
1942         [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
1943         https://bugs.webkit.org/show_bug.cgi?id=110702
1944
1945         Reviewed by Martin Robinson.
1946
1947         * GtkLauncher/main.c: include autotoolsconfig.h.
1948         * Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
1949         the include ordering check, since it uses autotoolsconfig.h which needs to
1950         come first.
1951
1952 2013-02-24  Hajime Morrita  <morrita@google.com>
1953
1954         [Custom Elements] Implement bare-bone document.register()
1955         https://bugs.webkit.org/show_bug.cgi?id=100229
1956
1957         Reviewed by Adam Barth.
1958
1959         Added enableCustomDOMElements flag.
1960
1961         * DumpRenderTree/chromium/TestShell.cpp:
1962         (TestShell::TestShell):
1963
1964 2013-02-23  Mark Pilgrim  <pilgrim@chromium.org>
1965
1966         [Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
1967         https://bugs.webkit.org/show_bug.cgi?id=110606
1968
1969         Reviewed by Adam Barth.
1970
1971         Part of a larger refactoring series; see tracking bug 82948.
1972
1973         * DumpRenderTree/DumpRenderTree.gypi:
1974         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1975         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
1976         (WebKitSupportTestEnvironment::mockPlatform):
1977         (WebKitSupportTestEnvironment):
1978         * DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
1979         (MockPlatform::create):
1980         (MockPlatform::MockPlatform):
1981         (MockPlatform::~MockPlatform):
1982         (MockPlatform::setInterfaces):
1983         (MockPlatform::cryptographicallyRandomValues):
1984         (MockPlatform::createMediaStreamCenter):
1985         (MockPlatform::createRTCPeerConnectionHandler):
1986         * DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
1987         (MockPlatform):
1988         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
1989         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
1990         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1991         (WebTestDelegate):
1992         * DumpRenderTree/chromium/TestShell.cpp:
1993         (TestShell::initialize):
1994         * DumpRenderTree/chromium/TestShell.h:
1995         (TestShell):
1996
1997 2013-02-23  Ryosuke Niwa  <rniwa@webkit.org>
1998
1999         Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
2000
2001         * Scripts/webkitpy/common/checkout/scm/svn.py:
2002         (SVN.timestamp_of_latest_commit):
2003
2004 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
2005
2006         Move setAutofilled from TestRunner to WebCore
2007         https://bugs.webkit.org/show_bug.cgi?id=110521
2008
2009         Reviewed by Benjamin Poulain.
2010
2011         * DumpRenderTree/TestRunner.cpp:
2012         (TestRunner::staticFunctions):
2013         * DumpRenderTree/TestRunner.h:
2014         (TestRunner):
2015         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2016         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2017         (WebTestRunner::TestRunner::TestRunner):
2018         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2019         (TestRunner):
2020         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2021         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2022         * DumpRenderTree/mac/TestRunnerMac.mm:
2023         * DumpRenderTree/qt/TestRunnerQt.cpp:
2024         * DumpRenderTree/qt/TestRunnerQt.h:
2025         (TestRunnerQt):
2026         * DumpRenderTree/win/TestRunnerWin.cpp:
2027         * DumpRenderTree/wx/TestRunnerWx.cpp:
2028
2029 2013-02-22  Ryosuke Niwa  <rniwa@webkit.org>
2030
2031         Upload results to perf.webkit.org in addition to the one specified by --test-results-server
2032         https://bugs.webkit.org/show_bug.cgi?id=108577
2033
2034         Reviewed by Dirk Pranke.
2035
2036         Upload results to perf.webkit.org using new JSON format as well as the host specified by
2037         --test-results-server. The new format is needed to provide extra information perf.webkit.org
2038         need such as the subversion commit time and test URLs. This is a temporarily measure until
2039         we complete the transition and the old JSON format and the code to upload results to
2040         webkit-perf.appspot.com can be deleted.
2041
2042         This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
2043         in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
2044         so that the app can sort performance test results based on the timestamp of the last commit.
2045
2046         It also changes the repository names returned by port objects to be properly capitalized
2047         human readable names such as WebKit instead of lowercased names such as webkit since these names
2048         are displayed on perf.webkit.org for humans. Several users of this feature has been updated
2049         to explicitly lowercase the names.
2050
2051
2052         * Scripts/webkitpy/common/checkout/scm/git.py:
2053         (Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
2054         git's timestamp granularity is seconds so we're losing some information compared to using a regular
2055         subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
2056         UTC so we're going to manually fiddle with timezone.
2057
2058         * Scripts/webkitpy/common/checkout/scm/scm.py:
2059         (SCM.timestamp_of_latest_commit): Added.
2060
2061         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2062         (MockSCM.timestamp_of_latest_commit): Added.
2063
2064         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2065         (test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.
2066
2067         * Scripts/webkitpy/common/checkout/scm/svn.py:
2068         (SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
2069         the timestamp which is always in UTC.
2070
2071         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2072         (JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
2073         'chromium' needs to be substituted by 'chrome' for historical reasons.
2074
2075         * Scripts/webkitpy/layout_tests/port/base.py:
2076         (Port.repository_paths): Return WebKit instead of webkit as noted above.
2077
2078         * Scripts/webkitpy/layout_tests/port/chromium.py:
2079         (ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.
2080
2081         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2082         (PerfTestsRunner.__init__): Store the current time in UTC as well as in local time.
2083         (PerfTestsRunner._collect_tests):
2084
2085         (PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
2086         and upload them appropriately.
2087
2088         (PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
2089         in revisions_for_perf_webkit and construct an output for perf.webkit.org.
2090
2091         (PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.
2092
2093         (PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
2094         and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
2095         e.g. "processor" would be renamed to "builderProcessor".
2096
2097         (PerfTestsRunner._generate_output_files):
2098
2099         (PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
2100         on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
2101         to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
2102         webkit-perf.appspot.com which spits out a plaintext response.
2103
2104         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2105         (MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
2106         (MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
2107         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.
2108
2109         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2110         (MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
2111         cases to parse JSON responses.
2112         (MainTest.test_upload_json.MockFileUploader): Refactored.
2113         (MainTest.test_upload_json.MockFileUploader.reset): Added.
2114         (MainTest.test_upload_json.MockFileUploader.__init__):
2115         (MainTest.test_upload_json.MockFileUploader.upload_single_text_file):
2116
2117 2013-02-22  Roger Fong  <roger_fong@apple.com>
2118
2119         Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.
2120
2121         * BuildSlaveSupport/build.webkit.org-config/config.json:
2122
2123 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2124
2125         Unreviewed, rolling out r143794.
2126         http://trac.webkit.org/changeset/143794
2127         https://bugs.webkit.org/show_bug.cgi?id=110542
2128
2129         debug linux builds broken?
2130
2131         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2132
2133 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2134
2135         [chromium] enable the fixed version of freetype on linux
2136         https://bugs.webkit.org/show_bug.cgi?id=110542
2137
2138         Reviewed by Tony Chang.
2139
2140         Switch to building with a fixed version of FreeType for
2141         just DumpRenderTree. This allows us to share one version
2142         of pixel baselines for both Lucid and Precise, and run
2143         the layout tests in a stock Precise install (instead of a Lucid
2144         chroot). Going forward, this approach isolates us from os-level
2145         changes to the version of FreeType. Note that Chromium itself
2146         still uses the system FreeType and is unaffected by this change.
2147         
2148         This setting can still be turned off (at compile/gyp-time) by
2149         manually setting use_custom_freetype=0.
2150
2151         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2152
2153 2013-02-22  Anders Carlsson  <andersca@apple.com>
2154
2155         Move pluginLoadPolicy to the page loader client
2156         https://bugs.webkit.org/show_bug.cgi?id=110635
2157
2158         Reviewed by Sam Weinig.
2159
2160         * MiniBrowser/mac/WK2BrowserWindowController.m:
2161         (-[WK2BrowserWindowController awakeFromNib]):
2162         * WebKitTestRunner/TestController.cpp:
2163         (WTR::TestController::createOtherPage):
2164         (WTR::TestController::createWebViewWithOptions):
2165
2166 2013-02-22  Kenneth Russell  <kbr@google.com>
2167
2168         Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.
2169
2170         * Scripts/webkitpy/common/config/committers.py:
2171
2172 2013-02-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2173
2174         [WTR] Do not dump information about empty subframes.
2175         https://bugs.webkit.org/show_bug.cgi?id=110585
2176
2177         Reviewed by Simon Fraser.
2178
2179         Follow DumpRenderTree more closely by skipping empty frames
2180         (frames which have no document). We are not really interested in
2181         showing anything about them.
2182
2183         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2184         (WTR::dumpDescendantFramesText): Do not print subframe names when they
2185         have no associated Document.
2186
2187 2013-02-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2188
2189         [EFL][DRT] Do not dump empty frames.
2190         https://bugs.webkit.org/show_bug.cgi?id=110474
2191
2192         Reviewed by Kenneth Rohde Christiansen.
2193
2194         Follow the original Mac implementation more closely by skipping
2195         empty frames (frames which have no document). We are not really
2196         interested in showing anything about them.
2197
2198         * DumpRenderTree/efl/DumpRenderTree.cpp:
2199         (dumpFramesAsText):
2200
2201 2013-02-21  Dirk Pranke  <dpranke@chromium.org>
2202
2203         [chromium] support the lucid version of freetype on precise in DRT
2204         https://bugs.webkit.org/show_bug.cgi?id=107338
2205
2206         Reviewed by Tony Chang.
2207
2208         Modify the DRT build so that we can optionally link against
2209         a fixed version of Freetype2. This allows us to share pixel test
2210         results across multiple versions of Ubuntu without having to
2211         worry about differences in font rendering.
2212
2213         At the moment this feature is off by default. Eventually it will
2214         be on by default on linux.
2215
2216         Note that this only affects DRT; the regular Chromium binary
2217         (and, for now, content_shell) will still use the system version
2218         of Freetype.
2219
2220         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2221
2222 2013-02-21  Rouslan Solomakhin  <rouslan@chromium.org>
2223
2224         [Chromium] Remove the word "cheher" from the list of misspelled words
2225         https://bugs.webkit.org/show_bug.cgi?id=110447
2226
2227         Reviewed by Tony Chang.
2228
2229         Other platforms do not mark "cheher" as a misspelled word in layout tests.
2230         This change is to bring Chromium platform in line with the rest of the
2231         platforms.
2232
2233         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
2234         (WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
2235         (WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
2236         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.
2237
2238 2013-02-21  Jochen Eisinger  <jochen@chromium.org>
2239
2240         [chromium] document WebTestDelegate and WebTestRunner interfaces
2241         https://bugs.webkit.org/show_bug.cgi?id=110472
2242
2243         Reviewed by Adam Barth.
2244
2245         Also remove the default implementation of the remaining WebTestDelegate
2246         methods now that all embedders provide this interface.
2247
2248         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2249         (WebTestDelegate):
2250         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2251         (WebTestRunner):
2252
2253 2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
2254
2255         Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
2256         https://bugs.webkit.org/show_bug.cgi?id=106059
2257
2258         Reviewed by Geoffrey Garen.
2259
2260         Added new tests for the WebKit API portion of the JSC Objective-C API.
2261
2262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2263         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
2264         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
2265         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.
2266         (-[MyConsole log:]):
2267         (-[MyConsole printHelloWorld]):
2268         (-[MyConsole add:to:]):
2269         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
2270         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
2271         (TestWebKitAPI):
2272         (TestWebKitAPI::TEST):
2273
2274 2013-02-21  Stephen Chenney  <schenney@chromium.org>
2275
2276         Unreviewed, add myself as a reviewer
2277
2278         * Scripts/webkitpy/common/config/committers.py:
2279
2280 2013-02-21  Jer Noble  <jer.noble@apple.com>
2281
2282         Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.
2283
2284         * Scripts/webkitpy/common/config/committers.py:
2285         * Scripts/webkitpy/common/config/watchlist:
2286
2287 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
2288
2289         gtk/DumpRenderTree.cpp is missing <locale.h> include
2290         https://bugs.webkit.org/show_bug.cgi?id=109386
2291
2292         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build
2293         by include locale.h when we use setlocale.
2294
2295 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
2296
2297         [GTK] Move feature overriding to the configure phase
2298         https://bugs.webkit.org/show_bug.cgi?id=110293
2299
2300         Reviewed by Gustavo Noronha Silva.
2301
2302         * Scripts/webkitdirs.pm:
2303         (runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
2304         WebKitFeatureOverrides.txt to better match the other filenames used in
2305         the new feature processing.
2306         * gtk/generate-feature-defines-files: Added. A script which takes as an argument
2307         the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
2308         and writes WebKitFeatures.txt and WebKitFeatures.h.
2309         * gtk/override-feature-defines: Removed.
2310
2311 2013-02-21  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
2312
2313         [Qt] Remove obsolete DEPENDPATH assignment
2314
2315         Reviewed by Simon Hausmann
2316
2317         qmake now adds CONFIG+=depend_includepath by default, making manual
2318         DEPENDPATH setup unnecessary.
2319
2320         * qmake/mkspecs/features/default_post.prf:
2321
2322 2013-02-20  Vivek Galatage  <vivekg@webkit.org>
2323
2324         Unreviewed. Changing primary email id.
2325
2326         * Scripts/webkitpy/common/config/committers.py:
2327
2328 2013-02-14  James Robinson  <jamesr@chromium.org>
2329
2330         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
2331         https://bugs.webkit.org/show_bug.cgi?id=109634
2332
2333         Reviewed by Adrienne Walker.
2334
2335         * DumpRenderTree/chromium/WebViewHost.cpp:
2336         (WebViewHost::createOutputSurface):
2337         (WebViewHost::initializeLayerTreeView):
2338
2339 2013-02-20  Martin Robinson  <mrobinson@igalia.com>
2340
2341         [GTK] Re-enable 3D CSS transforms when using build-webkit
2342         https://bugs.webkit.org/show_bug.cgi?id=110402
2343
2344         Reviewed by Xan Lopez.
2345
2346         * Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
2347         when building WebKitGTK+.
2348
2349 2013-02-20  Roger Fong  <roger_fong@apple.com>
2350
2351         Get VS2010 Solution B&I ready.
2352         <rdar://problem/1322988>
2353
2354         Rubberstamped by Timothy Horton.        
2355         
2356         Add Production configurations.
2357         
2358         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2359         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2360         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Added.
2361         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
2362         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Added.
2363         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
2364         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2365         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2366         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Added.
2367         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
2368         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Added.
2369         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
2370         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2371         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Added.
2372         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
2373         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2374         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Added.
2375         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
2376         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2377         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2378         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Added.
2379         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
2380         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Added.
2381         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
2382         * win/record-memory/record-memory.vcxproj:
2383         * win/record-memory/record-memoryProduction.props: Added.
2384         * win/record-memory/record-memoryRelease.props:
2385
2386 2013-02-20  Dirk Schulze  <krit@webkit.org>
2387
2388         Enable CANVAS_PATH flag
2389         https://bugs.webkit.org/show_bug.cgi?id=108508
2390
2391         Reviewed by Simon Fraser.
2392
2393         Enable CANVAS_PATH flag on trunk.
2394
2395         * Scripts/webkitperl/FeatureList.pm:
2396
2397 2013-02-20  Tony Chang  <tony@chromium.org>
2398
2399         Parse author names with commas in ChangeLogs
2400         https://bugs.webkit.org/show_bug.cgi?id=110356
2401
2402         Reviewed by Dirk Pranke.
2403
2404         Paweł's name has a comma in it, which was confusing the ChangeLog parser.
2405
2406         * Scripts/webkitpy/common/checkout/changelog.py:
2407         (ChangeLogEntry): Move name splitting regexp into a constant.
2408         (ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
2409         (ChangeLogEntry._split_reviewer_names): Rename to be more specific.
2410         (ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
2411         (ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
2412         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2413         (test_parse_authors): Test case with Paweł's name.
2414
2415 2013-02-15  Dirk Schulze  <krit@webkit.org>
2416
2417         [Chromium] Add runtime flag for CanvasPath
2418         https://bugs.webkit.org/show_bug.cgi?id=109997
2419
2420         Reviewed by Adam Barth.
2421
2422         Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
2423         the constructor for Path on DOMWindow would never be activatable, since the script
2424         is running after creating the DOMWindow object.
2425
2426         * DumpRenderTree/chromium/TestShell.cpp:
2427         (TestShell::TestShell):
2428
2429 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
2430
2431         [chromium] use a WebTestProxyBase pointer to identify the window we need the history for
2432         https://bugs.webkit.org/show_bug.cgi?id=110346
2433
2434         Reviewed by Adam Barth.
2435
2436         Using an index is very brittle, as the TestRunner API does not define
2437         any ordering of windows.
2438
2439         Also, make TestRunner::shouldDumpBackForwardList() so content shell can
2440         trigger the capturing in the browser process before generating the
2441         text dump.
2442
2443         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2444         (WebTestRunner):
2445         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
2446         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2447         (WebTestRunner):
2448         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2449         (TestRunner):
2450         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2451         (WebTestRunner::WebTestProxyBase::captureTree):
2452         * DumpRenderTree/chromium/WebViewHost.cpp:
2453         (WebViewHost::captureHistoryForWindow):
2454         * DumpRenderTree/chromium/WebViewHost.h:
2455         (WebViewHost):
2456
2457 2013-02-19  Rouslan Solomakhin  <rouslan@chromium.org>
2458
2459         [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
2460         https://bugs.webkit.org/show_bug.cgi?id=109220
2461
2462         Reviewed by Tony Chang.
2463
2464         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
2465         (WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
2466         (WebTestRunner):
2467         (WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
2468         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.
2469         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
2470         (MockSpellCheck):
2471         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
2472         (WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.
2473
2474 2013-02-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2475
2476         [Gtk] HTML5 Media controls require a design refresh
2477         https://bugs.webkit.org/show_bug.cgi?id=83869
2478
2479         Reviewed by Philippe Normand.
2480
2481         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2482         (initializeGtkFontSettings): Added gnome as default icon theme for
2483         the DRT.
2484         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2485         (WTR::initializeGtkSettings): Added gnome as default icon theme for
2486         the WTR.
2487         * gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external
2488         dependency.
2489
2490 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
2491
2492         [chromium] move most of the remaining mocks to TestRunner library
2493         https://bugs.webkit.org/show_bug.cgi?id=110217
2494
2495         Reviewed by Nico Weber.
2496
2497         While most of the functionality provided by these mocks is also
2498         available in the content module, there is no straight forward way to
2499         inject the mock results required for layout tests.
2500
2501         * DumpRenderTree/DumpRenderTree.gypi:
2502         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2503         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2504         (WebKit):
2505         (WebTestRunner):
2506         (WebTestRunner::WebTestProxy::geolocationClient):
2507         (WebTestRunner::WebTestProxy::speechInputController):
2508         (WebTestRunner::WebTestProxy::speechRecognizer):
2509         (WebTestRunner::WebTestProxy::deviceOrientationClient):
2510         (WebTestRunner::WebTestProxy::requestPointerLock):
2511         (WebTestRunner::WebTestProxy::requestPointerUnlock):
2512         (WebTestRunner::WebTestProxy::isPointerLocked):
2513         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
2514         (WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
2515         (WebTestRunner):
2516         (WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
2517         (WebTestRunner::MockWebSpeechInputController::setDelegate):
2518         (WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
2519         (WebTestRunner::MockWebSpeechInputController::setDumpRect):
2520         (WebTestRunner::MockWebSpeechInputController::clearResults):
2521         (WebTestRunner::MockWebSpeechInputController::startRecognition):
2522         (WebTestRunner::MockWebSpeechInputController::cancelRecognition):
2523         (WebTestRunner::MockWebSpeechInputController::stopRecording):
2524         (WebTestRunner::MockWebSpeechInputController::speechTaskFired):
2525         (WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
2526         (WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
2527         (WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
2528         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
2529         (WebKit):
2530         (WebTestRunner):
2531         (MockWebSpeechInputController):
2532         (WebTestRunner::MockWebSpeechInputController::taskList):
2533         (SpeechTask):
2534         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
2535         (WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
2536         (WebTestRunner):
2537         (WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
2538         (WebTestRunner::MockWebSpeechRecognizer::setDelegate):
2539         (WebTestRunner::MockWebSpeechRecognizer::start):
2540         (WebTestRunner::MockWebSpeechRecognizer::stop):
2541         (WebTestRunner::MockWebSpeechRecognizer::abort):
2542         (WebTestRunner::MockWebSpeechRecognizer::addMockResult):
2543         (WebTestRunner::MockWebSpeechRecognizer::setError):
2544         (WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
2545         (WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
2546         (WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
2547         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
2548         (WebKit):
2549         (WebTestRunner):
2550         (MockWebSpeechRecognizer):
2551         (WebTestRunner::MockWebSpeechRecognizer::wasAborted):
2552         (WebTestRunner::MockWebSpeechRecognizer::client):
2553         (WebTestRunner::MockWebSpeechRecognizer::handle):
2554         (WebTestRunner::MockWebSpeechRecognizer::taskList):
2555         (Task):
2556         (WebTestRunner::MockWebSpeechRecognizer::Task::Task):
2557         (WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
2558         (StepTask):
2559         (WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
2560         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2561         (WebTestRunner::TestInterfaces::TestInterfaces):
2562         (WebTestRunner::TestInterfaces::windowOpened):
2563         (WebTestRunner):
2564         (WebTestRunner::TestInterfaces::windowClosed):
2565         (WebTestRunner::TestInterfaces::windowList):
2566         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2567         (TestInterfaces):
2568         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2569         (WebTestRunner::TestRunner::TestRunner):
2570         (WebTestRunner::TestRunner::reset):
2571         (WebTestRunner::TestRunner::requestPointerLock):
2572         (WebTestRunner):
2573         (WebTestRunner::TestRunner::requestPointerUnlock):
2574         (WebTestRunner::TestRunner::isPointerLocked):
2575         (WebTestRunner::TestRunner::didAcquirePointerLockInternal):
2576         (WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
2577         (WebTestRunner::TestRunner::didLosePointerLockInternal):
2578         (WebTestRunner::TestRunner::windowCount):
2579         (WebTestRunner::TestRunner::setMockDeviceOrientation):
2580         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
2581         (WebTestRunner::TestRunner::setGeolocationPermission):
2582         (WebTestRunner::TestRunner::setMockGeolocationPosition):
2583         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
2584         (WebTestRunner::TestRunner::addMockSpeechInputResult):
2585         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
2586         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
2587         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
2588         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
2589         (WebTestRunner::TestRunner::didAcquirePointerLock):
2590         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
2591         (WebTestRunner::TestRunner::didLosePointerLock):
2592         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
2593         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
2594         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2595         (WebTestRunner):
2596         (TestRunner):
2597         (HostMethodTask):
2598         (WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
2599         (WebTestRunner::TestRunner::HostMethodTask::runIfValid):
2600         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2601         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
2602         (WebTestRunner::WebTestProxyBase::setInterfaces):
2603         (WebTestRunner::WebTestProxyBase::setDelegate):
2604         (WebTestRunner::WebTestProxyBase::reset):
2605         (WebTestRunner::WebTestProxyBase::captureTree):
2606         (WebTestRunner::WebTestProxyBase::geolocationClientMock):
2607         (WebTestRunner):
2608         (WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
2609         (WebTestRunner::WebTestProxyBase::speechInputControllerMock):
2610         (WebTestRunner::WebTestProxyBase::speechRecognizerMock):
2611         (WebTestRunner::WebTestProxyBase::geolocationClient):
2612         (WebTestRunner::WebTestProxyBase::speechInputController):
2613         (WebTestRunner::WebTestProxyBase::speechRecognizer):
2614         (WebTestRunner::WebTestProxyBase::deviceOrientationClient):
2615         (WebTestRunner::WebTestProxyBase::requestPointerLock):
2616         (WebTestRunner::WebTestProxyBase::requestPointerUnlock):
2617         (WebTestRunner::WebTestProxyBase::isPointerLocked):
2618         * DumpRenderTree/chromium/WebViewHost.cpp:
2619         (WebViewHost::reset):
2620         * DumpRenderTree/chromium/WebViewHost.h:
2621         (WebKit):
2622         (WebViewHost):
2623
2624 2013-02-20  Andras Becsi  <andras.becsi@digia.com>
2625
2626         [Qt] Make debug builds possible on 32bit Linux
2627         https://bugs.webkit.org/show_bug.cgi?id=110231
2628
2629         Reviewed by Tor Arne Vestbø.
2630
2631         Use the stabs format for debug builds to make the object files
2632         a bit smaller so that they can be linked on a 32bit system.
2633
2634         * qmake/mkspecs/features/unix/default_post.prf:
2635
2636 2013-02-20  Takashi Toyoshima  <toyoshim@chromium.org>
2637
2638         Unreviewed. Add myself to watch lists.
2639
2640         * Scripts/webkitpy/common/config/committers.py:
2641         * Scripts/webkitpy/common/config/watchlist:
2642
2643 2013-02-19  Joshua Bell  <jsbell@chromium.org>
2644
2645         Remove warning from run-bindings-tests
2646         https://bugs.webkit.org/show_bug.cgi?id=110285
2647
2648         Reviewed by Kentaro Hara.
2649
2650         Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
2651         "Unknown option: idlattributesfile". That option was removed from
2652         bindings/scripts/preprocess-idls.pl but was still being passed by
2653         the test script. Remove it.
2654
2655         * Scripts/webkitpy/bindings/main.py:
2656         (BindingsTests.generate_supplemental_dependency): Remove unused arg.
2657
2658 2013-02-19  Elliott Sprehn  <esprehn@chromium.org>
2659
2660         Unreviewed. Add myself to watch lists.
2661
2662         * Scripts/webkitpy/common/config/committers.py:
2663         * Scripts/webkitpy/common/config/watchlist:
2664
2665 2013-02-19  Hans Muller  <hmuller@adobe.com>
2666
2667         Unreviewed, corrected primary email.
2668
2669         * Scripts/webkitpy/common/config/committers.py:
2670
2671 2013-02-19  Hans Muller  <hmuller@adobe.com>
2672
2673         Unreviewed. Adding myself as a committer.
2674
2675         * Scripts/webkitpy/common/config/committers.py:
2676
2677 2013-02-19  Pravin D  <pravind@webkit.org>
2678
2679         Unreviewed, changing primary email.
2680
2681         * Scripts/webkitpy/common/config/committers.py:
2682
2683 2013-02-19  Alan Cutter  <alancutter@chromium.org>
2684
2685         REGRESSION: Sheriffbot is failing to process rollout requests
2686         https://bugs.webkit.org/show_bug.cgi?id=106945
2687
2688         Reviewed by Adam Barth.
2689
2690         Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
2691         This resolves problems when Sheriffbot attempts to perform a rollout request.
2692
2693         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2694         * EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
2695         * EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
2696
2697 2013-02-19  Claudio Saavedra  <csaavedra@igalia.com>
2698
2699         Unreviewed build fix.
2700
2701         * efl/jhbuild.modules:
2702         * gtk/jhbuild.modules:
2703
2704         Bump harfbuzz module to 0.9.7. See related bug 110145.
2705
2706 2013-02-19  Simon Hausmann  <simon.hausmann@digia.com>
2707
2708         [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
2709         https://bugs.webkit.org/show_bug.cgi?id=110215
2710
2711         Reviewed by Tor Arne Vestbø.
2712
2713         Check that gperf, python, ruby, perl, bison and flex are in the PATH before
2714         continuing the build. Otherwise skip with an error message explaining which
2715         programs are missing from the build.
2716
2717         * qmake/mkspecs/features/configure.prf:
2718         * qmake/mkspecs/features/functions.prf:
2719
2720 2013-02-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2721
2722         Unreviewed, rolling out r143319.
2723         http://trac.webkit.org/changeset/143319
2724         https://bugs.webkit.org/show_bug.cgi?id=110214
2725
2726         Causes build issues on win32 (Requested by carewolf on
2727         #webkit).
2728
2729         * qmake/mkspecs/features/features.pri:
2730
2731 2013-02-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2732
2733         [Qt] Enable MathML
2734         https://bugs.webkit.org/show_bug.cgi?id=110205
2735
2736         Reviewed by Simon Hausmann.
2737
2738         * qmake/mkspecs/features/features.pri:
2739
2740 2013-02-17  Andrei Bucur  <abucur@adobe.com>
2741
2742         Unreviewed. Adding myself as a committer.
2743
2744         * Scripts/webkitpy/common/config/committers.py:
2745
2746 2013-02-19  Hajime Morrita  <morrita@google.com>
2747
2748         Unreviewed, updated spelling of my name.
2749
2750         * Scripts/webkitpy/common/config/committers.py:
2751
2752 2013-02-18  Ilya Tikhonovsky  <loislo@chromium.org>
2753
2754         Unreviewed. Adjust expectations.
2755
2756         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
2757         (TestWebKitAPI::TEST):
2758
2759 2013-02-18  Zan Dobersek  <zdobersek@igalia.com>
2760
2761         Unreviewed GTK gardening.
2762
2763         * Scripts/run-gtk-tests:
2764         (TestRunner): Skipped the ReloadPageAfterCrash unit test as it is flakily timing out.
2765
2766 2013-02-18  Adenilson Cavalcanti  <cavalcantii@gmail.com>
2767
2768         [Qt][WK2] Remove duped test name and append new test in project file
2769         https://bugs.webkit.org/show_bug.cgi?id=110117
2770
2771         A new WK2 API test has landed recently (ResizeWindowAfterCrash), this patch will
2772         add this test into the runnable test suite and remove a duped test in project file.
2773
2774         Reviewed by Jocelyn Turcotte.
2775
2776         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
2777
2778 2013-02-18  Jochen Eisinger  <jochen@chromium.org>
2779
2780         [chromium] remove log spew from dumpAllBackForwardLists
2781         https://bugs.webkit.org/show_bug.cgi?id=110108
2782
2783         Reviewed by Nico Weber.
2784
2785         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2786
2787 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2788
2789         [EFL][WK2] Disable failing API tests
2790         https://bugs.webkit.org/show_bug.cgi?id=110081
2791
2792         Reviewed by Kenneth Rohde Christiansen.
2793
2794         Disable DOMWindowExtensionBasic WK2 test on EFL port as it times out.
2795
2796         * TestWebKitAPI/PlatformEfl.cmake:
2797
2798 2013-02-18  Simon Hausmann  <simon.hausmann@digia.com>
2799
2800         [Qt] Disable the build if certain configure checks fail
2801         https://bugs.webkit.org/show_bug.cgi?id=110094
2802
2803         Reviewed by Tor Arne Vestbø.
2804
2805         Allow for the build to be skipped (clear out SUBDIRS) if certain
2806         configure conditions aren't met.
2807
2808         * qmake/mkspecs/features/configure.prf:
2809
2810 2013-02-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2811
2812         [Qt][WK2] Support WK2 API tests
2813         https://bugs.webkit.org/show_bug.cgi?id=109843
2814
2815         Reviewed by Jocelyn Turcotte.
2816
2817         * TestWebKitAPI/DerivedSources.pri: Added.
2818         * TestWebKitAPI/InjectedBundle.pri: Added.
2819         * TestWebKitAPI/PlatformWebView.h:
2820         * TestWebKitAPI/TestWebKitAPI.pri:
2821         * TestWebKitAPI/TestWebKitAPI.pro:
2822         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Added.
2823         * TestWebKitAPI/Tests/WTF/WTF.pro:
2824         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Added.
2825         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp:
2826         (TestWebKitAPI::Util::sleep):
2827         (TestWebKitAPI::Util::createInjectedBundlePath):
2828         (TestWebKitAPI::Util::createURLForResource):
2829         (TestWebKitAPI::Util::isKeyDown):
2830         (Util):
2831         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Added.
2832         (TestWebKitAPI):
2833         (WrapperWindow):
2834         (TestWebKitAPI::WrapperWindow::WrapperWindow):
2835         (TestWebKitAPI::WrapperWindow::handleStatusChanged):
2836         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2837         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2838         (TestWebKitAPI::PlatformWebView::resizeTo):
2839         (TestWebKitAPI::PlatformWebView::page):
2840         (TestWebKitAPI::PlatformWebView::focus):
2841         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2842         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2843         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2844         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2845         * TestWebKitAPI/qt/main.cpp:
2846         (addQtWebProcessToPath):
2847         (main):
2848
2849 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2850
2851         [EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API
2852         https://bugs.webkit.org/show_bug.cgi?id=108598
2853
2854         Reviewed by Kenneth Rohde Christiansen.
2855
2856         Update EFL's MiniBrowser to make use of new Ewk_Favicon API.
2857
2858         * MiniBrowser/efl/main.c:
2859         (update_view_favicon):
2860         (on_view_favicon_changed):
2861         (window_create):
2862
2863 2013-02-18  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2864
2865         Unreviewed. Add myself as a committer.
2866
2867         * Scripts/webkitpy/common/config/committers.py:
2868
2869 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
2870
2871         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
2872         https://bugs.webkit.org/show_bug.cgi?id=109554
2873
2874         In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
2875         can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
2876
2877         Drive by fix: I introduced a client interface for the HeapGraphSerializer.
2878         It helps me to do the tests for the serializer.
2879
2880         Reviewed by Yury Semikhatsky.
2881
2882         It is covered by newly added tests in TestWebKitAPI.
2883
2884         * TestWebKitAPI/TestWebKitAPI.gypi:
2885         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
2886         (TestWebKitAPI):
2887         (HeapGraphReceiver):
2888         (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
2889         (TestWebKitAPI::HeapGraphReceiver::printGraph):
2890         (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
2891         (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
2892         (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
2893         (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
2894         (TestWebKitAPI::HeapGraphReceiver::serializer):
2895         (TestWebKitAPI::HeapGraphReceiver::chunkPart):
2896         (TestWebKitAPI::HeapGraphReceiver::dumpPart):
2897         (TestWebKitAPI::HeapGraphReceiver::stringValue):
2898         (TestWebKitAPI::HeapGraphReceiver::intValue):
2899         (TestWebKitAPI::HeapGraphReceiver::nodeToString):
2900         (TestWebKitAPI::HeapGraphReceiver::edgeToString):
2901         (TestWebKitAPI::HeapGraphReceiver::printNode):
2902         (Helper):
2903         (TestWebKitAPI::Helper::Helper):
2904         (TestWebKitAPI::Helper::addNode):
2905         (TestWebKitAPI::Helper::addEdge):
2906         (TestWebKitAPI::Helper::done):
2907         (Object):
2908         (TestWebKitAPI::Helper::Object::Object):
2909         (TestWebKitAPI::TEST):
2910         (Owner):
2911         (TestWebKitAPI::Owner::Owner):
2912         (TestWebKitAPI::Owner::reportMemoryUsage):
2913
2914 2013-02-18  Ryosuke Niwa  <rniwa@webkit.org>
2915
2916         WKR build fix. Always use ascii since irclib/ircbot doesn't support unicode.
2917
2918         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2919         (NewCommitBot.next_work_item):
2920
2921 2013-02-17  Kangil Han  <kangil.han@samsung.com>
2922
2923         Unreviewed. Add myself as a committer.
2924
2925         * Scripts/webkitpy/common/config/committers.py:
2926
2927 2013-02-17  Alan Cutter  <alancutter@chromium.org>
2928
2929         GCE EWS bots are all offline
2930         https://bugs.webkit.org/show_bug.cgi?id=110069
2931
2932         Reviewed by Eric Seidel.
2933
2934         Updated GCE EWS build scripts to use the gcel-10-04-v20130104 image instead of the obsoleted ubuntu-10-04-v20120621.
2935         This changed the ephemeral disk path to /dev/sdb and required /etc/hosts to be chmodded to 644.
2936
2937         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2938         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2939         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
2940         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2941         * EWSTools/build-vm.sh:
2942         * EWSTools/start-queue.sh:
2943
2944 2013-02-18  Eugene Klyuchnikov  <eustas@chromium.org>
2945
2946         Unreviewed, add myself to commiters.py.
2947
2948         * Scripts/webkitpy/common/config/committers.py:
2949
2950 2013-02-17  Dongwoo Joshua Im  <dw.im@samsung.com>
2951
2952         Unreviewed. Add myself as a committer.
2953
2954         * Scripts/webkitpy/common/config/committers.py:
2955
2956 2013-02-17  Roger Fong  <roger_fong@apple.com>
2957
2958         Unreviewed. Fix typo in script.
2959
2960         * EWSTools/start-queue-win.sh:
2961
2962 2013-02-15  Roger Fong  <roger_fong@apple.com>
2963
2964         Pass in bot name as parameter to start-queue-win script.
2965         https://bugs.webkit.org/show_bug.cgi?id=109998.
2966
2967         Reviewed by Darin Adler.
2968
2969         * EWSTools/start-queue-win.sh:
2970
2971 2013-02-18  Byungwoo Lee  <bw80.lee@samsung.com>
2972
2973         Unreviewed. Add myself as a committer.
2974
2975         * Scripts/webkitpy/common/config/committers.py:
2976
2977 2013-02-17  Ryosuke Niwa  <rniwa@webkit.org>
2978
2979         Rename new-commit-bot to WKR to disambiguate it from commit-queue.
2980
2981         Rubber-stamped by Andreas Kling.
2982
2983         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2984         (NewCommitBot.begin_work_queue):
2985
2986 2013-02-16  Glenn Adams  <glenn@skynav.com>
2987
2988         Unreviewed. Add myself as a committer.
2989
2990         * Scripts/webkitpy/common/config/committers.py:
2991
2992 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
2993
2994         new-commit-bot should report the full name of committer and reviewer instead of just nicks
2995         https://bugs.webkit.org/show_bug.cgi?id=110040
2996
2997         Reviewed by Darin Adler.
2998
2999         Have it report names like "Ryosuke Niwa (rniwa)" instead of just "rniwa".
3000
3001         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3002         (NewCommitBot):
3003         (NewCommitBot._summarize_commit_log):
3004         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3005
3006 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
3007
3008         We need a CIA replacement
3009         https://bugs.webkit.org/show_bug.cgi?id=110008
3010
3011         Reviewed by Andreas Kling.
3012
3013         Added new-commit-bot.
3014
3015         * Scripts/webkitpy/tool/bot/queueengine.py:
3016         (QueueEngine.__init__):
3017         (QueueEngine): Made the sleep tiem configurable.
3018         (QueueEngine._sleep_message):
3019         (QueueEngine._sleep):
3020         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3021         (QueueEngineTest.test_sleep_message):
3022         * Scripts/webkitpy/tool/commands/__init__.py:
3023         * Scripts/webkitpy/tool/commands/newcommitbot.py: Added.
3024         (PingPong): Added. Implements the ping pong protocol.
3025         (NewCommitBot):
3026         (NewCommitBot.begin_work_queue):
3027         (NewCommitBot.work_item_log_path):
3028         (NewCommitBot.next_work_item): Update SVN revision and report any new commits made since
3029         the last time we checked the head SVN revision.
3030         (NewCommitBot.process_work_item):
3031         (NewCommitBot._update_checkout): svn up.
3032         (NewCommitBot._new_svn_revisions): Returns a range of new revisions.
3033         (NewCommitBot._summarize_commit_log): Summarize a commit log to be posted on IRC.
3034         (NewCommitBot.handle_unexpected_error):
3035         (NewCommitBot.handle_script_error):
3036         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Added.
3037         (NewCommitBotTest.test_summarize_commit_log_basic): Tests for summarizing non-rollout commits.
3038         (NewCommitBotTest.test_summarize_commit_log_rollout): Tests for summarizing rollouts.
3039         * Scripts/webkitpy/tool/commands/queues.py:
3040         (AbstractQueue.execute):
3041         * Scripts/webkitpy/tool/commands/queuestest.py:
3042         (MockQueueEngine.__init__):
3043         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3044         (SheriffBotTest.test_command_aliases):
3045         * Scripts/webkitpy/tool/main.py:
3046         (WebKitPatch):
3047
3048 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
3049
3050         [chromium] initialize all variables of TestRunner classes
3051         https://bugs.webkit.org/show_bug.cgi?id=110013
3052
3053         Reviewed by Adam Barth.
3054
3055         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3056         (WebTestRunner::TestInterfaces::TestInterfaces):
3057         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3058         (WebTestRunner::TestRunner::TestRunner):
3059
3060 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
3061
3062         [chromium] destroy the TestPlugin when the destroy() method is invoked.
3063         https://bugs.webkit.org/show_bug.cgi?id=110012
3064
3065         Reviewed by Adam Barth.
3066
3067         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3068         (WebTestRunner::TestPlugin::destroy):
3069
3070 2013-02-15  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3071
3072         [WK2] Write a test to simulate crashed WebProcess followed by Window resize
3073         https://bugs.webkit.org/show_bug.cgi?id=109842
3074
3075         Reviewed by Benjamin Poulain.
3076
3077         This new test will kill WebProcess, followed by next resizing the Window. It helps to
3078         identify if the port is testing for WebPageProxy data members state (e.g. DrawingArea, Frames)
3079         before making calls into them.
3080
3081         * TestWebKitAPI/GNUmakefile.am:
3082         * TestWebKitAPI/PlatformEfl.cmake:
3083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3084         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Added.
3085         (TestWebKitAPI):
3086         (TestWebKitAPI::didFinishLoad):
3087         (TestWebKitAPI::didCrash):
3088         (TestWebKitAPI::TEST):
3089
3090 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3091
3092         Add CString operators for comparison with const char*
3093         https://bugs.webkit.org/show_bug.cgi?id=109947
3094
3095         Reviewed by Darin Adler.
3096
3097         Add tests for WTF::CString's comparison operators.
3098
3099         * TestWebKitAPI/Tests/WTF/CString.cpp:
3100         (TEST):
3101
3102 2013-02-15  Zan Dobersek  <zdobersek@igalia.com>
3103
3104         webkit-patch suggest-reviewers should limit itself to 5 reviewers
3105         https://bugs.webkit.org/show_bug.cgi?id=107528
3106
3107         Reviewed by Eric Seidel.
3108
3109         * Scripts/webkitpy/common/checkout/checkout.py:
3110         (Checkout.suggested_reviewers): Iterate through the sorted commit info list,
3111         scraping reviewers from the commit information and in the end producing a list
3112         of reviewers that's sorted from the most to least recent activity of any reviewer
3113         that has reviewed or authored patches for the changed files.
3114         * Scripts/webkitpy/tool/commands/queries.py:
3115         (SuggestReviewers): Use the SuggestReviewers step instead of reimplementing much of
3116         the same logic.
3117         (SuggestReviewers._prepare_state): Force the reviewer suggestion because the option
3118         defaults to False.
3119         * Scripts/webkitpy/tool/steps/suggestreviewers.py:
3120         (SuggestReviewers.run): Only list the first five suggested reviewers, now printed out
3121         on a single line.  Only ask for CC-ing the suggested reviewers to the bug if the
3122         bug ID is located in the command's state.
3123
3124 2013-02-15  Pablo Flouret  <pablof@motorola.com>
3125
3126         Unreviewed. Add myself as a committer.
3127
3128         * Scripts/webkitpy/common/config/committers.py:
3129
3130 2013-02-15  Roger Fong  <roger_fong@apple.com>
3131
3132         Get Win EWS startup script checked into tree so we can make changes to all the EWS bots more easily.
3133
3134         * EWSTools/start-queue-win.sh: Added.
3135
3136 2013-02-15  Andreas Kling  <akling@apple.com>
3137
3138         Unbreak webkit-patch -- can't have both Committer and Contributor entry with same e-mail address.
3139
3140         * Scripts/webkitpy/common/config/committers.py:
3141
3142 2013-02-15  Joanmarie Diggs  <jdiggs@igalia.com>
3143
3144         Unreviewed. Add myself as a committer.
3145
3146         * Scripts/webkitpy/common/config/committers.py:
3147
3148 2013-02-15  Ryosuke Niwa  <rniwa@webkit.org>
3149
3150         NRWT: ML Debug Test bot is timing out after cleaning up ports
3151         https://bugs.webkit.org/show_bug.cgi?id=109912
3152
3153         Reviewed by Simon Fraser.
3154
3155         Added more debug messgaes to diagnose the issue.
3156
3157         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3158         (Manager.run):
3159
3160 2013-02-15  Claudio Saavedra  <csaavedra@igalia.com>
3161
3162         Unreviewed. Add myself as a committer.
3163
3164         * Scripts/webkitpy/common/config/committers.py:
3165
3166 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3167
3168         Unreviewed. Update Yi Shen, Antonio Gomes and Laszlo Gombos'
3169         emails on their behalf.
3170
3171         * Scripts/webkitpy/common/config/committers.py:
3172
3173 2013-02-15  Andrey Lushnikov  <lushnikov@chromium.org>
3174
3175         Web Inspector: implement smart braces functionality
3176         https://bugs.webkit.org/show_bug.cgi?id=109200
3177
3178         Reviewed by Pavel Feldman.
3179
3180         Fix eventSender.keyDown implementation to correctly process opening
3181         round brace symbol.
3182
3183         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3184         (WebTestRunner):
3185         (WebTestRunner::EventSender::keyDown):
3186
3187 2013-02-15  Jochen Eisinger  <jochen@chromium.org>
3188
3189         Speculative build fix for chromium-win.
3190
3191         Unreviewed build fix.
3192
3193         Add declarations of the copy constructor and assignment operator to
3194         WebTestProxyBase, so VS doesn't try to generate them.
3195
3196         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3197
3198 2013-02-15  Simon Hausmann  <simon.hausmann@digia.com>
3199
3200         [Qt] Port GCController to JSC C API
3201         https://bugs.webkit.org/show_bug.cgi?id=109690
3202
3203         Reviewed by Benjamin Poulain.
3204
3205         Rename TestRunner to TestRunnerQt to avoid conflict when
3206         including TestRunner.h in the future.
3207
3208         Replaced QObject based GCController implementation with JSC C API
3209         based one.
3210
3211         * DumpRenderTree/qt/DumpRenderTree.pro:
3212         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3213         (WebCore::DumpRenderTree::DumpRenderTree):
3214         (WebCore::DumpRenderTree::open):
3215         (WebCore::DumpRenderTree::initJSObjects):
3216         (WebCore::methodNameStringForFailedTest):
3217         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3218         (WebCore::DumpRenderTree::testRunner):
3219         (DumpRenderTree):
3220         * DumpRenderTree/qt/GCControllerQt.cpp:
3221         (GCController::getJSObjectCount):
3222         * DumpRenderTree/qt/GCControllerQt.h: Removed.
3223         * DumpRenderTree/qt/TestRunnerQt.cpp:
3224         (TestRunnerQt::TestRunnerQt):
3225         (TestRunnerQt::reset):
3226         (TestRunnerQt::dumpNotifications):
3227         (TestRunnerQt::processWork):
3228         (TestRunnerQt::maybeDump):
3229         (TestRunnerQt::dumpAsText):
3230         (TestRunnerQt::waitUntilDone):
3231         (TestRunnerQt::setViewModeMediaFeature):
3232         (TestRunnerQt::webHistoryItemCount):
3233         (TestRunnerQt::keepWebHistory):
3234         (TestRunnerQt::notifyDone):
3235         (TestRunnerQt::windowCount):
3236         (TestRunnerQt::grantWebNotificationPermission):
3237         (TestRunnerQt::ignoreLegacyWebNotificationPermissionRequests):
3238         (TestRunnerQt::denyWebNotificationPermission):
3239         (TestRunnerQt::removeAllWebNotificationPermissions):
3240         (TestRunnerQt::simulateWebNotificationClick):
3241         (TestRunnerQt::simulateLegacyWebNotificationClick):
3242         (TestRunnerQt::display):
3243         (TestRunnerQt::displayInvalidatedRegion):
3244         (TestRunnerQt::clearBackForwardList):
3245         (TestRunnerQt::pathToLocalResource):
3246         (TestRunnerQt::dumpEditingCallbacks):
3247         (TestRunnerQt::dumpFrameLoadCallbacks):
3248         (TestRunnerQt::dumpProgressFinishedCallback):
3249         (TestRunnerQt::dumpUserGestureInFrameLoadCallbacks):
3250         (TestRunnerQt::dumpResourceLoadCallbacks):
3251         (TestRunnerQt::dumpResourceResponseMIMETypes):
3252         (TestRunnerQt::dumpWillCacheResponse):
3253         (TestRunnerQt::dumpHistoryCallbacks):
3254         (TestRunnerQt::setWillSendRequestReturnsNullOnRedirect):
3255         (TestRunnerQt::setWillSendRequestReturnsNull):
3256         (TestRunnerQt::setWillSendRequestClearHeader):
3257         (TestRunnerQt::setDeferMainResourceDataLoad):
3258         (TestRunnerQt::queueBackNavigation):
3259         (TestRunnerQt::queueForwardNavigation):
3260         (TestRunnerQt::queueLoad):
3261         (TestRunnerQt::queueLoadHTMLString):
3262         (TestRunnerQt::queueReload):
3263         (TestRunnerQt::queueLoadingScript):
3264         (TestRunnerQt::queueNonLoadingScript):
3265         (TestRunnerQt::provisionalLoad):
3266         (TestRunnerQt::timerEvent):
3267         (TestRunnerQt::encodeHostName):
3268         (TestRunnerQt::decodeHostName):
3269         (TestRunnerQt::closeWebInspector):
3270         (TestRunnerQt::setDeveloperExtrasEnabled):
3271         (TestRunnerQt::setAsynchronousSpellCheckingEnabled):
3272         (TestRunnerQt::showWebInspector):
3273         (TestRunnerQt::evaluateInWebInspector):
3274         (TestRunnerQt::goBack):
3275         (TestRunnerQt::setDefersLoading):
3276         (TestRunnerQt::setAllowUniversalAccessFromFileURLs):
3277         (TestRunnerQt::setAllowFileAccessFromFileURLs):
3278         (TestRunnerQt::setAppCacheMaximumSize):
3279         (TestRunnerQt::setAutofilled):
3280         (TestRunnerQt::setValueForUser):
3281         (TestRunnerQt::setFixedContentsSize):
3282         (TestRunnerQt::setPrivateBrowsingEnabled):
3283         (TestRunnerQt::setSpatialNavigationEnabled):
3284         (TestRunnerQt::setPopupBlockingEnabled):
3285         (TestRunnerQt::setPluginsEnabled):
3286         (TestRunnerQt::setPOSIXLocale):
3287         (TestRunnerQt::setWindowIsKey):
3288         (TestRunnerQt::setMainFrameIsFirstResponder):
3289         (TestRunnerQt::setJavaScriptCanAccessClipboard):
3290         (TestRunnerQt::setXSSAuditorEnabled):
3291         (TestRunnerQt::dispatchPendingLoadRequests):
3292         (TestRunnerQt::clearAllApplicationCaches):
3293         (TestRunnerQt::clearApplicationCacheForOrigin):
3294         (TestRunnerQt::localStorageDiskUsageForOrigin):
3295         (TestRunnerQt::setApplicationCacheOriginQuota):
3296         (TestRunnerQt::applicationCacheDiskUsageForOrigin):
3297         (TestRunnerQt::originsWithApplicationCache):
3298         (TestRunnerQt::setCacheModel):
3299         (TestRunnerQt::setDatabaseQuota):
3300         (TestRunnerQt::clearAllDatabases):
3301         (TestRunnerQt::addOriginAccessWhitelistEntry):
3302         (TestRunnerQt::removeOriginAccessWhitelistEntry):
3303         (TestRunnerQt::setCustomPolicyDelegate):
3304         (TestRunnerQt::waitForPolicyDelegate):
3305         (TestRunnerQt::overridePreference):
3306         (TestRunnerQt::setUserStyleSheetLocation):
3307         (TestRunnerQt::setCaretBrowsingEnabled):
3308         (TestRunnerQt::setAuthorAndUserStylesEnabled):
3309         (TestRunnerQt::setUserStyleSheetEnabled):
3310         (TestRunnerQt::setDomainRelaxationForbiddenForURLScheme):
3311         (TestRunnerQt::callShouldCloseOnWebView):
3312         (TestRunnerQt::setScrollbarPolicy):
3313         (TestRunnerQt::setSmartInsertDeleteEnabled):
3314         (TestRunnerQt::setSelectTrailingWhitespaceEnabled):
3315         (TestRunnerQt::execCommand):
3316         (TestRunnerQt::isCommandEnabled):
3317         (TestRunnerQt::findString):
3318         (TestRunnerQt::markerTextForListItem):
3319         (TestRunnerQt::computedStyleIncludingVisitedInfo):
3320         (TestRunnerQt::elementDoesAutoCompleteForElementWithId):
3321         (TestRunnerQt::authenticateSession):
3322         (TestRunnerQt::setIconDatabaseEnabled):
3323         (TestRunnerQt::setMockDeviceOrientation):
3324         (TestRunnerQt::setGeolocationPermission):
3325         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3326         (TestRunnerQt::setGeolocationPermissionCommon):
3327         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3328         (TestRunnerQt::setMockGeolocationPosition):
3329         (TestRunnerQt::addMockSpeechInputResult):
3330         (TestRunnerQt::setMockSpeechInputDumpRect):
3331         (TestRunnerQt::startSpeechInput):
3332         (TestRunnerQt::evaluateScriptInIsolatedWorldAndReturnValue):
3333         (TestRunnerQt::evaluateScriptInIsolatedWorld):
3334         (TestRunnerQt::addUserStyleSheet):
3335         (TestRunnerQt::removeAllVisitedLinks):
3336         (TestRunnerQt::addURLToRedirect):
3337         (TestRunnerQt::originsWithLocalStorage):
3338         (TestRunnerQt::deleteAllLocalStorage):
3339         (TestRunnerQt::deleteLocalStorageForOrigin):
3340         (TestRunnerQt::observeStorageTrackerNotifications):
3341         (TestRunnerQt::syncLocalStorage):
3342         (TestRunnerQt::resetPageVisibility):
3343         (TestRunnerQt::setPageVisibility):
3344         (TestRunnerQt::setAutomaticLinkDetectionEnabled):
3345         (TestRunnerQt::setTextDirection):
3346         (TestRunnerQt::setAlwaysAcceptCookies):
3347         (TestRunnerQt::setAlwaysBlockCookies):
3348         (TestRunnerQt::setAudioData):
3349         * DumpRenderTree/qt/TestRunnerQt.h:
3350         (TestRunnerQt):
3351
3352 2013-02-14  Karen Grunberg  <kareng@chromium.org>
3353
3354         adding myself as a committer
3355
3356         * Scripts/webkitpy/common/config/committers.py:
3357
3358 2013-02-14  Glenn Adams  <glenn@skynav.com>
3359
3360         new-run-webkit-tests needs a shared TestExpectations between all WebKit ports
3361         https://bugs.webkit.org/show_bug.cgi?id=37565
3362
3363         Introduce generic TestExpectations file that applies as a fallback for all ports, the location of which
3364         is LayoutTests/TestExpectations.
3365
3366         Reviewed by Dirk Pranke.
3367
3368         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3369         (FakePort.path_to_generic_test_expectations_file):
3370         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3371         (TestExpectations.__init__):
3372         * Scripts/webkitpy/layout_tests/port/base.py:
3373         (Port.path_to_generic_test_expectations_file):
3374         (Port):
3375         (Port._port_specific_expectations_files):
3376         (Port.expectations_files):
3377         * Scripts/webkitpy/layout_tests/port/chromium.py:
3378         (ChromiumPort._port_specific_expectations_files):
3379         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3380         (ChromiumAndroidPort._port_specific_expectations_files):
3381         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
3382         (ChromiumPortTestCase.test_expectations_files):
3383         * Scripts/webkitpy/layout_tests/port/efl.py:
3384         (EflPort._port_specific_expectations_files):
3385         * Scripts/webkitpy/layout_tests/port/gtk.py:
3386         (GtkPort._port_specific_expectations_files):
3387         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3388         (GtkPortTest.test_expectations_files):
3389         * Scripts/webkitpy/layout_tests/port/mac.py:
3390         (MacPort._port_specific_expectations_files):
3391         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3392         (PortTestCase.test_expectations_ordering):
3393         (test_expectations_files):
3394         * Scripts/webkitpy/layout_tests/port/qt.py:
3395         (QtPort._port_specific_expectations_files):
3396         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3397         (QtPortTest.test_expectations_files):
3398         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3399         (WinPortTest.test_expectations_files):
3400         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3401         (PrintExpectationsTest.test_paths):
3402         * Scripts/webkitpy/tool/commands/rebaseline.py:
3403         (RebaselineTest._update_expectations_file):
3404
3405 2013-02-14  Jochen Eisinger  <jochen@chromium.org>
3406
3407         [chromium] move pixel generation logic to TestRunner library
3408         https://bugs.webkit.org/show_bug.cgi?id=109686
3409
3410         Reviewed by Stephen White.
3411
3412         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3413         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3414         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3415         (WebTestRunner):
3416         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3417         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3418         (WebTestRunner):
3419         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3420         (WebTestRunner::TestInterfaces::~TestInterfaces):
3421         (WebTestRunner::TestInterfaces::setWebView):
3422         (WebTestRunner::TestInterfaces::proxy):
3423         (WebTestRunner):
3424         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3425         (WebTestRunner):
3426         (TestInterfaces):
3427         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3428         (WebTestRunner::TestRunner::setWebView):
3429         (WebTestRunner):
3430         (WebTestRunner::TestRunner::setBackingScaleFactor):
3431         (WebTestRunner::TestRunner::display):
3432         (WebTestRunner::TestRunner::displayInvalidatedRegion):
3433         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3434         (WebTestRunner):
3435         (TestRunner):
3436         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3437         (WebTestRunner::WebTestInterfaces::setWebView):
3438         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3439         (WebTestRunner::WebTestProxyBase::reset):
3440         (WebTestRunner::WebTestProxyBase::capturePixels):
3441         (WebTestRunner):
3442         (WebTestRunner::WebTestProxyBase::paintRect):
3443         (WebTestRunner::WebTestProxyBase::paintInvalidatedRegion):
3444         (WebTestRunner::WebTestProxyBase::paintPagesWithBoundaries):
3445         (WebTestRunner::WebTestProxyBase::canvas):
3446         (WebTestRunner::WebTestProxyBase::displayRepaintMask):
3447         (WebTestRunner::WebTestProxyBase::display):
3448         (WebTestRunner::WebTestProxyBase::displayInvalidatedRegion):
3449         (WebTestRunner::WebTestProxyBase::discardBackingStore):
3450         (WebTestRunner::WebTestProxyBase::setWindowRect):
3451         (WebTestRunner::WebTestProxyBase::userMediaClient):
3452         * DumpRenderTree/chromium/TestShell.cpp:
3453         (TestShell::createMainWindow):
3454         (TestShell::~TestShell):
3455         (TestShell::showDevTools):
3456         (TestShell::closeDevTools):
3457         (TestShell::dump):
3458         * DumpRenderTree/chromium/WebViewHost.cpp:
3459         (WebViewHost::setWindowRect):
3460         (WebViewHost::setDeviceScaleFactor):
3461         (WebViewHost::reset):
3462         * DumpRenderTree/chromium/WebViewHost.h:
3463         (WebViewHost):
3464
3465 2013-02-14  Tony Chang  <tony@chromium.org>
3466
3467         Unreviewed, set svn:eol-style native for .sln, .vcproj, and .vsprops files.
3468         https://bugs.webkit.org/show_bug.cgi?id=96934
3469
3470         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3471         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3472         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added property svn:eol-style.
3473         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added property svn:eol-style.
3474         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added property svn:eol-style.
3475         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3476         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added property svn:eol-style.
3477         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added property svn:eol-style.
3478         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3479         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added property svn:eol-style.
3480         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added property svn:eol-style.
3481         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added property svn:eol-style.
3482         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3483         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added property svn:eol-style.
3484         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added property svn:eol-style.
3485         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3486         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added property svn:eol-style.
3487         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3488         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added property svn:eol-style.
3489         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added property svn:eol-style.
3490         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added property svn:eol-style.
3491         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3492         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added property svn:eol-style.
3493         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added property svn:eol-style.
3494         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3495         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added property svn:eol-style.
3496         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added property svn:eol-style.
3497         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added property svn:eol-style.
3498         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added property svn:eol-style.
3499         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added property svn:eol-style.
3500         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added property svn:eol-style.
3501         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3502         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added property svn:eol-style.
3503         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
3504         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added property svn:eol-style.
3505         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added property svn:eol-style.
3506         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added property svn:eol-style.
3507         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3508         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added property svn:eol-style.
3509         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added property svn:eol-style.
3510         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3511         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added property svn:eol-style.
3512         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added property svn:eol-style.
3513         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added property svn:eol-style.
3514         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3515         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added property svn:eol-style.
3516         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added property svn:eol-style.
3517         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3518
3519 2013-02-14  Tony Chang  <tony@chromium.org>
3520
3521         Unreviewed, set svn:eol-style CRLF for .sln files.
3522
3523         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3524         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3525         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3526         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
3527
3528 2013-02-14  Zan Dobersek  <zdobersek@igalia.com>
3529
3530         [GTK] Errors when building WebKit2 with Clang
3531         https://bugs.webkit.org/show_bug.cgi?id=109603
3532
3533         Reviewed by Alexey Proskuryakov.
3534
3535         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3536         (WTR::PlatformWebView::resizeTo): Cast the width and height parameters to the integer
3537         type when constructing the GtkAllocation.
3538
3539         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3540         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3541         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3542         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
3543
3544 2013-02-14  Roger Fong  <roger_fong@apple.com>
3545
3546         Add eol-style=native to solution files. Add a new solution file.
3547
3548         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added property svn:eol-style.
3549         * TestWebKitAPI/TestWebKitAPI.vcxproj: Added property svn:eol-style. Modified property svn:ignore.
3550         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Added.
3551
3552 2013-02-14  Mario Sanchez Prada  <mario.prada@samsung.com>
3553
3554         [GTK] Missing call to g_object_ref while retrieving accessible table cells
3555         https://bugs.webkit.org/show_bug.cgi?id=106903
3556
3557         Reviewed by Martin Robinson.
3558
3559         Both DRT and WKTR need to call g_object_unref() now that an extra
3560         reference is added in the implementation of atk_table_ref_at().
3561
3562         * DumpRenderTree/atk/AccessibilityUIElementGtk.cpp:
3563         (AccessibilityUIElement::cellForColumnAndRow): Call g_object_unref
3564         before returning the new instance of AccessibilityUIElement.
3565         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3566         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
3567
3568 2013-02-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3569
3570         Unreviewed, rolling out r142841.
3571         http://trac.webkit.org/changeset/142841
3572         https://bugs.webkit.org/show_bug.cgi?id=109791
3573
3574         Caused webkit_unit_tests to crash on chromium bots. (Requested
3575         by atwilson_ on #webkit).
3576
3577         * DumpRenderTree/chromium/WebViewHost.cpp:
3578         (WebViewHost::createOutputSurface):
3579         (WebViewHost::initializeLayerTreeView):
3580
3581 2013-02-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3582
3583         [EFL][jhbuild] Silence GSettings-related warning.
3584         https://bugs.webkit.org/show_bug.cgi?id=109749
3585
3586         Reviewed by Martin Robinson.
3587
3588         Apply the same change done to the GTK+ port in r109127; this
3589         silences the warnings printed by glib about the memory GSettings
3590         backend being used.
3591
3592         Not only does this make the bots (as well as manual runs of, say,
3593         WebKitTestRunner) much more silent, but it also removes an stderr
3594         line (which run-perf-tests considers as a failure).
3595
3596         * Scripts/webkitpy/layout_tests/port/efl.py:
3597         (EflPort.setup_environ_for_server): Explicitly set the
3598         GSETTINGS_BACKEND environment variable to "memory".
3599
3600 2013-02-14  Jochen Eisinger  <jochen@chromium.org>
3601
3602         [chromium] move mock notification presenter to TestRunner library
3603         https://bugs.webkit.org/show_bug.cgi?id=109706
3604
3605         Reviewed by Adam Barth.
3606
3607         * DumpRenderTree/DumpRenderTree.gypi:
3608         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3609         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3610         (WebKit):
3611         (WebTestRunner::WebTestProxy::notificationPresenter):
3612         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.cpp.
3613         (WebTestRunner::NotificationPresenter::NotificationPresenter):
3614         (WebTestRunner):
3615         (WebTestRunner::NotificationPresenter::~NotificationPresenter):
3616         (WebTestRunner::NotificationPresenter::grantPermission):
3617         (WebTestRunner::NotificationPresenter::simulateClick):
3618         (WebTestRunner::NotificationPresenter::show):
3619         (WebTestRunner::NotificationPresenter::cancel):
3620         (WebTestRunner::NotificationPresenter::objectDestroyed):
3621         (WebTestRunner::NotificationPresenter::checkPermission):
3622         (WebTestRunner::NotificationPresenter::requestPermission):
3623         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.h.
3624         (WebTestRunner):
3625         (NotificationPresenter):
3626         (WebTestRunner::NotificationPresenter::setDelegate):
3627         (WebTestRunner::NotificationPresenter::reset):
3628         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3629         (WebTestRunner::TestRunner::TestRunner):
3630         (WebTestRunner::TestRunner::setDelegate):
3631         (WebTestRunner::TestRunner::reset):
3632         (WebTestRunner::TestRunner::notificationPresenter):
3633         (WebTestRunner):
3634         (WebTestRunner::TestRunner::grantWebNotificationPermission):
3635         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
3636         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3637         (WebKit):
3638         (WebTestRunner):
3639         (TestRunner):
3640         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3641         (WebTestRunner::WebTestProxyBase::notificationPresenter):
3642         (WebTestRunner):
3643         * DumpRenderTree/chromium/TestShell.cpp:
3644         (TestShell::initialize):
3645         (TestShell::resetTestController):
3646         * DumpRenderTree/chromium/TestShell.h:
3647         (WebKit):
3648         (TestShell):
3649         * DumpRenderTree/chromium/WebViewHost.cpp:
3650         * DumpRenderTree/chromium/WebViewHost.h:
3651
3652 2013-02-13  Roger Fong  <roger_fong@apple.com>
3653
3654         Unreviewed. Add separate DumpRenderTree VS2010 solution file.
3655
3656         * DumpRenderTree/DumpRenderTree.vcxproj: Added property svn:ignore.
3657         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added.
3658
3659 2013-02-12  James Robinson  <jamesr@chromium.org>
3660
3661         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
3662         https://bugs.webkit.org/show_bug.cgi?id=109634
3663
3664         Reviewed by Adrienne Walker.
3665
3666         * DumpRenderTree/chromium/WebViewHost.cpp:
3667         (WebViewHost::createOutputSurface):
3668         (WebViewHost::initializeLayerTreeView):
3669
3670 2013-02-13  David Farler  <dfarler@apple.com>
3671
3672         TestWebKitAPI fails to build for iphonesimulator: 'CFNetwork/CFNetworkDefs.h' file not found
3673         https://bugs.webkit.org/show_bug.cgi?id=109766
3674
3675         Reviewed by David Kilzer.
3676
3677         * TestWebKitAPI/Configurations/Base.xcconfig:
3678         - Don't search Mac OS X header search paths when building on iOS
3679
3680 2013-02-13  Zan Dobersek  <zdobersek@igalia.com>
3681
3682         The 'global isinf/isnan' compiler quirk required when using clang with libstdc++
3683         https://bugs.webkit.org/show_bug.cgi?id=109325
3684
3685         Reviewed by Anders Carlsson.
3686
3687         Prefix calls to the isinf and isnan methods with std::, declaring we want to use the
3688         two methods as they're provided by the C++ standard library being used.
3689
3690         * DumpRenderTree/TestRunner.cpp:
3691         (setAppCacheMaximumSizeCallback):
3692         (setApplicationCacheOriginQuotaCallback):
3693         (setDatabaseQuotaCallback):
3694
3695 2013-02-13  Alan Cutter  <alancutter@chromium.org>
3696
3697         cr-linux debug should use clang and maybe be a components build
3698         https://bugs.webkit.org/show_bug.cgi?id=108512
3699
3700         Reviewed by Adam Barth.
3701
3702         Modified GCE cr-linux-debug-ews bot build scripts to configure clang over gcc for build performance.
3703         Build bots will update clang with each bot cycle.
3704         Updated GCE image paths to suit gcutil 1.6.1.
3705
3706         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3707         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3708         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
3709         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3710         * EWSTools/configure-clang-linux.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
3711         * EWSTools/start-queue.sh:
3712
3713 2013-02-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3714
3715         Unreviewed, rolling out r142747.
3716         http://trac.webkit.org/changeset/142747
3717         https://bugs.webkit.org/show_bug.cgi?id=109746
3718
3719         broke component build (Requested by alecf_gardening on
3720         #webkit).
3721
3722         * TestWebKitAPI/TestWebKitAPI.gypi:
3723         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
3724
3725 2013-02-13  Jochen Eisinger  <jochen@chromium.org>
3726
3727         [chromium] fix TestRunner build with enable_webrtc=0
3728         https://bugs.webkit.org/show_bug.cgi?id=109700
3729
3730         Reviewed by Tony Chang.
3731
3732         We can't use ENABLE() macros in the TestRunner library, however,
3733         ENABLE_WEBRTC is defined by build/common.gypi, so we can use it.
3734
3735         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp:
3736         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
3737         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp:
3738         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp:
3739         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3740         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3741         (WebTestRunner):
3742         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3743         (WebTestRunner::WebTestProxyBase::userMediaClient):
3744         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
3745
3746 2013-02-12  Roger Fong  <roger_fong@apple.com>
3747
3748         TestWebKitAPI and record-memory projects and property sheets for VS2010.
3749         https://bugs.webkit.org/show_bug.cgi?id=107034
3750
3751         Reviewed by Brent Fulgham.
3752
3753         * TestWebKitAPI/TestWebKitAPI.vcxproj: Added.
3754         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Added.
3755         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Added.
3756         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd.
3757         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd.
3758         * win/record-memory: Added.
3759         * win/record-memory/main.cpp: Copied from Tools/record-memory-win/main.cpp.
3760         * win/record-memory/record-memory.vcxproj: Added.
3761         * win/record-memory/record-memory.vcxproj.filters: Added.
3762         * win/record-memory/record-memoryCommon.props: Added.
3763         * win/record-memory/record-memoryDebug.props: Added.
3764         * win/record-memory/record-memoryRelease.props: Added.
3765
3766 2013-02-13  Tommy Widenflycht  <tommyw@google.com>
3767
3768         MediaStream API: Use the source id when creating new tracks
3769         https://bugs.webkit.org/show_bug.cgi?id=109688
3770
3771         Reviewed by Adam Barth.
3772
3773         Switching mock to new API.
3774
3775         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
3776         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
3777
3778 2013-02-13  Brent Fulgham  <bfulgham@webkit.org>
3779
3780         [Windows] Unreviewed VS2010 fix to add $(ConfigurationBuildDir)/private
3781         to include paths, to match VS2005 build behavior.
3782
3783         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
3784         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
3785         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
3786         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
3787         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
3788
3789 2013-02-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3790
3791         Unreviewed, rolling out r142736.
3792         http://trac.webkit.org/changeset/142736
3793         https://bugs.webkit.org/show_bug.cgi?id=109716
3794
3795         Broke ABI, nightly builds crash on launch (Requested by ap on
3796         #webkit).
3797
3798         * MiniBrowser/mac/WK2BrowserWindowController.m:
3799         (-[WK2BrowserWindowController awakeFromNib]):
3800         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3801         (WTR::InjectedBundlePage::InjectedBundlePage):
3802         * WebKitTestRunner/TestController.cpp:
3803         (WTR::TestController::createWebViewWithOptions):
3804
3805 2013-02-13  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3806
3807         [WK2][EFL][WTR] Regression(r141836): WTR crashes on exit
3808         https://bugs.webkit.org/show_bug.cgi?id=109456
3809
3810         Reviewed by Anders Carlsson.
3811
3812         WebView instance must not live longer than EwkView, as EwkView owns
3813         objects that page proxy refers to, doing otherwise leads to a crash.
3814
3815         Test controller has own ptr containing WebView. Invoking of ewk_shutdown()
3816         leads to evas objects deletion. So, the problem was that test controller was
3817         deleted after ewk_shutdown() had been called in main() function causing
3818         crashes on WTR exit.
3819
3820         The patch introduces a scope for test controller so that it is deleted first.
3821
3822         * WebKitTestRunner/efl/main.cpp:
3823         (main):
3824
3825 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
3826
3827         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
3828         https://bugs.webkit.org/show_bug.cgi?id=109554
3829
3830         In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
3831         can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
3832
3833         Drive by fix: I introduced a client interface for the HeapGraphSerializer.
3834         It helps me to do the tests for the serializer.
3835
3836         Reviewed by Yury Semikhatsky.
3837
3838         It is covered by newly added tests in TestWebKitAPI.
3839
3840         * TestWebKitAPI/TestWebKitAPI.gypi:
3841         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
3842         (TestWebKitAPI):
3843         (HeapGraphReceiver):
3844         (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
3845         (TestWebKitAPI::HeapGraphReceiver::printGraph):
3846         (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
3847         (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
3848         (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
3849         (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
3850         (TestWebKitAPI::HeapGraphReceiver::serializer):
3851         (TestWebKitAPI::HeapGraphReceiver::chunkPart):
3852         (TestWebKitAPI::HeapGraphReceiver::dumpPart):
3853         (TestWebKitAPI::HeapGraphReceiver::stringValue):
3854         (TestWebKitAPI::HeapGraphReceiver::intValue):
3855         (TestWebKitAPI::HeapGraphReceiver::nodeToString):
3856         (TestWebKitAPI::HeapGraphReceiver::edgeToString):
3857         (TestWebKitAPI::HeapGraphReceiver::printNode):
3858         (Helper):
3859         (TestWebKitAPI::Helper::Helper):
3860         (TestWebKitAPI::Helper::addNode):
3861         (TestWebKitAPI::Helper::addEdge):
3862         (TestWebKitAPI::Helper::done):
3863         (Object):
3864         (TestWebKitAPI::Helper::Object::Object):
3865         (TestWebKitAPI::TEST):
3866         (Owner):
3867         (TestWebKitAPI::Owner::Owner):
3868         (TestWebKitAPI::Owner::reportMemoryUsage):
3869
3870 2013-02-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3871
3872         [WK2] Remove web intents callbacks
3873         https://bugs.webkit.org/show_bug.cgi?id=109654
3874
3875         Reviewed by Benjamin Poulain.
3876
3877         Web intents was removed by r142549.
3878
3879         * MiniBrowser/mac/WK2BrowserWindowController.m:
3880         (-[WK2BrowserWindowController awakeFromNib]):
3881         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3882         (WTR::InjectedBundlePage::InjectedBundlePage):
3883         * WebKitTestRunner/TestController.cpp:
3884         (WTR::TestController::createWebViewWithOptions):
3885
3886 2013-02-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3887
3888         [WK2] Page reloading will crash UIProcess after WebProcess was killed
3889         https://bugs.webkit.org/show_bug.cgi?id=109305
3890
3891         Reviewed by Benjamin Poulain.
3892
3893         Adding a new test to simulate the case of WebProcess crash followed by a trying
3894         to load a new page.
3895
3896         * TestWebKitAPI/GNUmakefile.am:
3897         * TestWebKitAPI/PlatformEfl.cmake:
3898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3899         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Added.
3900         (TestWebKitAPI):
3901         (TestWebKitAPI::didFinishLoad):
3902         (TestWebKitAPI::TEST):
3903
3904 2013-02-11  Brent Fulgham  <bfulgham@webkit.org>
3905
3906         Update WebKitDirs.pm for new Windows paths
3907         https://bugs.webkit.org/show_bug.cgi?id=107714
3908
3909         Reviewed by Daniel Bates.
3910
3911         * Scripts/webkitdirs.pm: For each existing Windows environment
3912         variable, also include creation of the 'new' variables. The
3913         'old' variables will be removed in a future update.
3914         (windowsSourceSourceDir): New helper routine to return the
3915         actual 'Source' folder of the WebKit source tree.
3916
3917 2013-02-12  Alec Flett  <alecflett@chromium.org>
3918
3919         Fix signedness in WebTestProxy
3920         https://bugs.webkit.org/show_bug.cgi?id=109623
3921
3922         Reviewed by Adam Barth.
3923
3924         Fix signedness problem, using size_t instead of int.
3925
3926         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3927
3928 2013-02-12  Raymond Toy  <rtoy@google.com>
3929
3930         Add alias
3931         https://bugs.webkit.org/show_bug.cgi?id=109621
3932
3933         No review needed.
3934
3935         * Scripts/webkitpy/common/config/committers.py:
3936
3937 2013-02-12  Jochen Eisinger  <jochen@chromium.org>
3938
3939         [chromium] move text dump generation to TestRunner library
3940         https://bugs.webkit.org/show_bug.cgi?id=109575
3941
3942         Reviewed by Adam Barth.
3943
3944         * DumpRenderTree/DumpRenderTree.gypi:
3945         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3946         (WebKit):
3947         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
3948         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3949         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3950         (WebTestRunner):
3951         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.h.
3952         (WebTestRunner::normalizeLayoutTestURL):
3953         (WebTestRunner):
3954         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h:
3955         (WebTestRunner):
3956         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3957         (WebTestRunner::TestRunner::checkResponseMimeType):
3958         (WebTestRunner):
3959         (WebTestRunner::TestRunner::shouldDumpAsText):
3960         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
3961         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3962         (TestRunner):
3963         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
3964         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3965         (WebTestRunner::WebTestProxyBase::captureTree):
3966         (WebTestRunner):
3967         * DumpRenderTree/chromium/TestShell.cpp:
3968         (TestShell::dump):
3969         (TestShell::captureHistoryForWindow):
3970         * DumpRenderTree/chromium/TestShell.h:
3971         (TestShell):
3972         * DumpRenderTree/chromium/WebViewHost.cpp:
3973         (WebViewHost::captureHistoryForWindow):
3974         * DumpRenderTree/chromium/WebViewHost.h:
3975
3976 2013-02-12  Jessie Berlin  <jberlin@apple.com>
3977
3978         Rollout r142618, it broke all the Mac builds.
3979
3980         * TestWebKitAPI/TestWebKitAPI.gypi:
3981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3982         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
3983         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3984
3985 2013-02-12  Yury Semikhatsky  <yurys@chromium.org>
3986
3987         Unreviewed. Fix Chromium compilation after r142618.
3988
3989         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
3990         (TestWebKitAPI::HeapGraphReceiver::printNode):
3991
3992 2013-02-12  Martin Robinson  <mrobinson@igalia.com>
3993
3994         [GTK] Add an optional moduleset with hard to get packages (including libsecret)
3995         https://bugs.webkit.org/show_bug.cgi?id=109195
3996
3997         Reviewed by Philippe Normand.
3998
3999         Add an optional moduleset that includes libsecret. This moduleset will
4000         be used to install some annoyingly hard to obtain dependencies on older
4001         distributions.
4002
4003         * gtk/jhbuild-optional.modules: Added.
4004         * gtk/jhbuild.modules: Add a reference to the new moduleset file.
4005
4006 2013-02-12  Ilya Tikhonovsky  <loislo@chromium.org>
4007
4008         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
4009         https://bugs.webkit.org/show_bug.cgi?id=109554
4010
4011         In some cases leaves have no pointer. As example when we report a leaf via addPrivateBuffer.
4012         This patch has new set of tests for HeapGraphSerializer.
4013
4014         Reviewed by Yury Semikhatsky.
4015
4016         * TestWebKitAPI/TestWebKitAPI.gypi:
4017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4018         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
4019         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4020
4021 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
4022
4023         Unreviewed followup to r142606, the EFL port also enables the CSS image-set
4024         feature so the new configuration option's default value should reflect that.
4025
4026         * Scripts/webkitperl/FeatureList.pm:
4027
4028 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
4029
4030         [GTK] Enable CSS Variables feature in development builds
4031         https://bugs.webkit.org/show_bug.cgi?id=109474
4032
4033         Reviewed by Martin Robinson.
4034
4035         * Scripts/webkitperl/FeatureList.pm: Enable the feature on development
4036         builds of the GTK port.
4037
4038 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
4039
4040         [GTK] Enable CSS image-set support in development builds
4041         https://bugs.webkit.org/show_bug.cgi?id=109475
4042
4043         Reviewed by Martin Robinson.
4044
4045         * Scripts/webkitperl/FeatureList.pm: Add the configuration option for the feature.
4046         Note that the Mac port also enables the feature but does so in Platform.h as the feature
4047         is also enabled for the iOS port which can't at the moment be detected via webkitperl.
4048
4049 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
4050
4051         [GTK] Enable DOM4 events constructors in development builds
4052         https://bugs.webkit.org/show_bug.cgi?id=109471
4053
4054         Reviewed by Martin Robinson.
4055
4056         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the GTK port as well.
4057
4058 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
4059
4060         Remove unnecessary variables from FeatureList.pm
4061         https://bugs.webkit.org/show_bug.cgi?id=109558
4062
4063         Reviewed by Daniel Bates.
4064
4065         A small cleanup, removing unused variables for which the related configuration
4066         options were already removed.
4067
4068         * Scripts/webkitperl/FeatureList.pm:
4069
4070 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
4071
4072         Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
4073         https://bugs.webkit.org/show_bug.cgi?id=109481
4074
4075         Reviewed by Daniel Bates.
4076
4077         The ENABLE_XHR_RESPONSE_BLOB feature define was removed from the code
4078         back in r120574. There are still occurrences of it in various build systems
4079         which should all be removed as they are useless.
4080
4081         * Scripts/webkitperl/FeatureList.pm:
4082
4083 2013-02-12  Jochen Eisinger  <jochen@chromium.org>
4084
4085         [chromium] move webrtc mocks to testrunner library
4086         https://bugs.webkit.org/show_bug.cgi?id=109041
4087
4088         Reviewed by Adam Barth.
4089
4090         * DumpRenderTree/DumpRenderTree.gypi:
4091         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4092         (WebKitSupportTestEnvironment):
4093         (WebKitSupportTestEnvironment::mockPlatform):
4094         (main):
4095         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
4096         (MockWebKitPlatformSupport::setInterfaces):
4097         (MockWebKitPlatformSupport::createMediaStreamCenter):
4098         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
4099         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
4100         (WebTestRunner):
4101         (MockWebKitPlatformSupport):
4102         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
4103         (WebKit):
4104         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4105         (WebKit):
4106         (WebTestRunner):
4107         (WebTestRunner::WebTestProxy::showContextMenu):
4108         (WebTestRunner::WebTestProxy::userMediaClient):
4109         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.cpp.
4110         (WebTestRunner::MockConstraints::verifyConstraints):
4111         (WebTestRunner):
4112         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.h.
4113         (WebKit):
4114         (WebTestRunner):
4115         (MockConstraints):
4116         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp.
4117         (WebTestRunner):
4118         (WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
4119         (WebTestRunner::MockWebMediaStreamCenter::queryMediaStreamSources):
4120         (WebTestRunner::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
4121         (WebTestRunner::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
4122         (WebTestRunner::MockWebMediaStreamCenter::didAddMediaStreamTrack):
4123         (WebTestRunner::MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
4124         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
4125         (MockWebAudioDestinationConsumer):
4126         (WebTestRunner::MockWebAudioDestinationConsumer::~MockWebAudioDestinationConsumer):
4127         (WebTestRunner::MockWebMediaStreamCenter::didCreateMediaStream):
4128         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.h.
4129         (WebKit):
4130         (WebTestRunner):
4131         (MockWebMediaStreamCenter):
4132         (WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
4133         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.cpp.
4134         (WebTestRunner):
4135         (DTMFSenderToneTask):
4136         (WebTestRunner::DTMFSenderToneTask::DTMFSenderToneTask):
4137         (WebTestRunner::MockWebRTCDTMFSenderHandler::MockWebRTCDTMFSenderHandler):
4138         (WebTestRunner::MockWebRTCDTMFSenderHandler::setClient):
4139         (WebTestRunner::MockWebRTCDTMFSenderHandler::currentToneBuffer):
4140         (WebTestRunner::MockWebRTCDTMFSenderHandler::canInsertDTMF):
4141         (WebTestRunner::MockWebRTCDTMFSenderHandler::insertDTMF):
4142         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.h.
4143         (WebTestRunner):
4144         (MockWebRTCDTMFSenderHandler):
4145         (WebTestRunner::MockWebRTCDTMFSenderHandler::taskList):
4146         (WebTestRunner::MockWebRTCDTMFSenderHandler::clearToneBuffer):
4147         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.cpp.
4148         (WebTestRunner):
4149         (DataChannelReadyStateTask):
4150         (WebTestRunner::DataChannelReadyStateTask::DataChannelReadyStateTask):
4151         (WebTestRunner::MockWebRTCDataChannelHandler::MockWebRTCDataChannelHandler):
4152         (WebTestRunner::MockWebRTCDataChannelHandler::setClient):
4153         (WebTestRunner::MockWebRTCDataChannelHandler::bufferedAmount):
4154         (WebTestRunner::MockWebRTCDataChannelHandler::sendStringData):
4155         (WebTestRunner::MockWebRTCDataChannelHandler::sendRawData):
4156         (WebTestRunner::MockWebRTCDataChannelHandler::close):
4157         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.h.
4158         (WebTestRunner):
4159         (MockWebRTCDataChannelHandler):
4160         (WebTestRunner::MockWebRTCDataChannelHandler::taskList):
4161         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp.
4162         (WebTestRunner):
4163         (RTCSessionDescriptionRequestSuccededTask):
4164         (WebTestRunner::RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
4165         (RTCSessionDescriptionRequestFailedTask):
4166         (WebTestRunner::RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
4167         (RTCStatsRequestSucceededTask):
4168         (WebTestRunner::RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
4169         (RTCVoidRequestTask):
4170         (WebTestRunner::RTCVoidRequestTask::RTCVoidRequestTask):
4171         (RTCPeerConnectionStateTask):
4172         (WebTestRunner::RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
4173         (RemoteDataChannelTask):
4174         (WebTestRunner::RemoteDataChannelTask::RemoteDataChannelTask):
4175         (WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
4176         (WebTestRunner::MockWebRTCPeerConnectionHandler::initialize):
4177         (WebTestRunner::MockWebRTCPeerConnectionHandler::createOffer):
4178         (WebTestRunner::MockWebRTCPeerConnectionHandler::createAnswer):
4179         (WebTestRunner::MockWebRTCPeerConnectionHandler::setLocalDescription):
4180         (WebTestRunner::MockWebRTCPeerConnectionHandler::setRemoteDescription):
4181         (WebTestRunner::MockWebRTCPeerConnectionHandler::localDescription):
4182         (WebTestRunner::MockWebRTCPeerConnectionHandler::remoteDescription):
4183         (WebTestRunner::MockWebRTCPeerConnectionHandler::updateICE):
4184         (WebTestRunner::MockWebRTCPeerConnectionHandler::addICECandidate):
4185         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
4186         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
4187         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
4188         (WebTestRunner::MockWebRTCPeerConnectionHandler::createDataChannel):
4189         (WebTestRunner::MockWebRTCPeerConnectionHandler::createDTMFSender):
4190         (WebTestRunner::MockWebRTCPeerConnectionHandler::stop):
4191         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.
4192         (WebKit):
4193         (WebTestRunner):
4194         (MockWebRTCPeerConnectionHandler):
4195         (WebTestRunner::MockWebRTCPeerConnectionHandler::taskList):
4196         (WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
4197         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4198         (WebTestRunner::TestInterfaces::TestInterfaces):
4199         (WebTestRunner::TestInterfaces::setDelegate):
4200         (WebTestRunner::TestInterfaces::delegate):
4201         (WebTestRunner):
4202         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
4203         (TestInterfaces):
4204         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
4205         (WebTestRunner::WebTestInterfaces::createMediaStreamCenter):
4206         (WebTestRunner):
4207         (WebTestRunner::WebTestInterfaces::createWebRTCPeerConnectionHandler):
4208         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4209         (WebTestRunner::WebTestProxyBase::userMediaClient):
4210         (WebTestRunner):
4211         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp.
4212         (WebTestRunner):
4213         (UserMediaRequestTask):
4214         (WebTestRunner::UserMediaRequestTask::UserMediaRequestTask):
4215         (MockExtraData):
4216         (WebTestRunner::WebUserMediaClientMock::WebUserMediaClientMock):
4217         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
4218         (WebTestRunner::WebUserMediaClientMock::cancelUserMediaRequest):
4219         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h.
4220         (WebTestRunner):
4221         (WebUserMediaClientMock):
4222         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
4223         (WebTestRunner::WebUserMediaClientMock::taskList):
4224         * DumpRenderTree/chromium/TestShell.cpp:
4225         (TestShell::initialize):
4226         * DumpRenderTree/chromium/TestShell.h:
4227         (TestShell):
4228         * DumpRenderTree/chromium/WebViewHost.cpp:
4229         * DumpRenderTree/chromium/WebViewHost.h:
4230         (WebViewHost):
4231
4232 2013-02-11  Timothy Loh  <timloh@chromium.com>
4233
4234         webkit-patch upload regenerates the WebCore ChangeLog every time it's called
4235         https://bugs.webkit.org/show_bug.cgi?id=108983
4236
4237         Reviewed by Ryosuke Niwa.
4238
4239         This patch puts the behaviour from Bug 74358 behind the flag (default=OFF)
4240         `--update-changelogs', and removes the flag `--no-prepare-changelogs'.
4241         The flag name change from prepare to update is since we still want to
4242         prepare changelogs in the default case when none currently exist.
4243
4244         * Scripts/webkitpy/tool/commands/commandtest.py:
4245         (CommandsTest.assert_execute_outputs):
4246         * Scripts/webkitpy/tool/steps/options.py:
4247         (Options):
4248         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4249         (PrepareChangeLog.options):
4250         (PrepareChangeLog.run):
4251
4252 2013-02-11  Jochen Eisinger  <jochen@chromium.org>
4253
4254         [chromium] move printPage() implementation to testRunner library
4255         https://bugs.webkit.org/show_bug.cgi?id=109436
4256
4257         Reviewed by Adam Barth.
4258
4259         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4260         (WebTestRunner::WebTestProxy::showContextMenu):
4261         (WebTestRunner::WebTestProxy::printPage):
4262         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4263         (WebTestRunner):
4264         (WebTestRunner::WebTestProxyBase::printPage):
4265         * DumpRenderTree/chromium/WebViewHost.cpp:
4266         * DumpRenderTree/chromium/WebViewHost.h:
4267
4268 2013-02-11  James Robinson  <jamesr@chromium.org>
4269
4270         [Chromium] Get rid of WebAnimationController
4271         https://bugs.webkit.org/show_bug.cgi?id=109235
4272
<