Add a DiagnosticLogging method taking an arbitrary dictionary of values.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2
3         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
4         https://bugs.webkit.org/show_bug.cgi?id=196773
5
6         Reviewed by Jer Noble.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
9         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
10         (TEST):
11
12 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
13
14         ews-build should clearly indicate flaky test failures
15         https://bugs.webkit.org/show_bug.cgi?id=196947
16
17         Reviewed by Lucas Forschler.
18
19         * BuildSlaveSupport/ews-build/steps.py:
20         (AnalyzeAPITestsResults.analyzeResults):
21
22 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
23
24         InjectedBundle parameters often need initialization function called before unarchiving
25         https://bugs.webkit.org/show_bug.cgi?id=189709
26         <rdar://problem/44573653>
27
28         Reviewed by Ryosuke Niwa.
29
30         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
31         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
32
33 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
34
35         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
36         https://bugs.webkit.org/show_bug.cgi?id=196681
37
38         Reviewed by Darin Adler.
39
40         Added tests.
41
42         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
43         (WTF_HashSet.RemoveIf):
44         (WTF_HashSet.RemoveIfShrinkToBestSize):
45
46 2019-04-15  John Wilander  <wilander@apple.com>
47
48         Send delayed Ad Click Attribution conversion requests to the click source
49         https://bugs.webkit.org/show_bug.cgi?id=196838
50         <rdar://problem/47650157>
51
52         Reviewed by Chris Dumez and Youenn Fablet.
53
54         This patch adds test infrastructure to override the default behavior in
55         WebKit::NetworkAdClickAttribution.
56
57         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
58         (TestWebKitAPI::TEST):
59         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
60         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
61         (WTR::TestRunner::dumpAdClickAttribution):
62         (WTR::TestRunner::clearAdClickAttribution):
63         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
64         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
65         * WebKitTestRunner/InjectedBundle/TestRunner.h:
66         * WebKitTestRunner/TestController.cpp:
67         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
68         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
69         * WebKitTestRunner/TestController.h:
70         * WebKitTestRunner/TestInvocation.cpp:
71         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
72
73 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
74
75         [ews-app] status-bubble should display position in queue
76         https://bugs.webkit.org/show_bug.cgi?id=196607
77
78         Reviewed by Lucas Forschler.
79
80         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
81         (StatusBubble._build_bubble):
82         (StatusBubble._queue_position): Method to calculate patch's position in queue.
83
84 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
85
86         [ews-build] Do not run clean build by default on EWS builders
87         https://bugs.webkit.org/show_bug.cgi?id=196897
88
89         Reviewed by Lucas Forschler.
90
91         * BuildSlaveSupport/ews-build/steps.py:
92         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
93         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
94         untracked directories like WebKitBuild).
95         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
96         untracked files/directories (like WebKitBuild).
97
98 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
99
100         TestRunner::notifyDone() should be safely reentrant
101         https://bugs.webkit.org/show_bug.cgi?id=196898
102
103         Reviewed by Darin Adler.
104
105         It is currently possible that TestRunner::notifyDone() will call itself, since
106         notifyDone() will force a repaint, which can start executing JavaScript, which
107         may call notifyDone() again. This can lead to test failures and flakiness.
108         Fix this by setting the m_waitToDump flag before calling the dump() method.
109
110         * DumpRenderTree/mac/TestRunnerMac.mm:
111         (TestRunner::notifyDone):
112         (TestRunner::forceImmediateCompletion):
113         * DumpRenderTree/win/TestRunnerWin.cpp:
114         (TestRunner::notifyDone):
115         (TestRunner::forceImmediateCompletion):
116
117 2019-04-15  Philippe Normand  <pnormand@igalia.com>
118
119         [GTK][WPE] Add enable-media websetting
120         https://bugs.webkit.org/show_bug.cgi?id=196863
121
122         Reviewed by Michael Catanzaro.
123
124         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
125         (testWebKitSettings): Add test for the enable-media web-setting.
126
127 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
128
129         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
130         https://bugs.webkit.org/show_bug.cgi?id=196905
131         <rdar://problem/49886096>
132
133         Reviewed by Tim Horton.
134
135         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
136         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
137         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
138         delay timer, we end up with this sequence of events in the problematic (failure) case:
139
140         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
141             ...IPC from UI to web process...
142         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
143             ...IPC from web to UI process...
144         (c) [UI]    Invoke completion handler for script #1
145         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
146             ...IPC from UI to web process...
147         (e) [Web]   Evaluate script #2 in the web process
148         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
149
150         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
151         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
152         #2 is run in step (e).
153
154         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
155         the UI process by waiting on a script message posted by the web process, after attachment updates are
156         dispatched.
157
158         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
159         (TestWebKitAPI::TEST):
160
161 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
162
163         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
164         https://bugs.webkit.org/show_bug.cgi?id=196909
165
166         Reviewed by Wenson Hsieh.
167
168         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
169         (TestWebKitAPI::TEST):
170
171 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
172
173         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
174         https://bugs.webkit.org/show_bug.cgi?id=196880
175
176         Reviewed by Yusuke Suzuki.
177
178         Add a new function for bytecode cache tests that does not forceDiskCache
179         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
180         test added in this patch, since the code is invalid and therefore won't be
181         cached. It should also be useful for tests that evaluate dynamically
182         generated code.
183
184         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
185         * Scripts/run-jsc-stress-tests:
186
187 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
188
189         Update AudioSession route sharing policy
190         https://bugs.webkit.org/show_bug.cgi?id=196776
191         <rdar://problem/46501611>
192
193         Reviewed by Jer Noble.
194
195         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
196         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
197         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
198         (TestWebKitAPI::TEST):
199
200 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
201
202         [iOS] Software keyboard is shown too frequently on some websites
203         https://bugs.webkit.org/show_bug.cgi?id=195856
204         <rdar://problem/49191395>
205
206         Reviewed by Darin Adler.
207
208         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
209
210         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
211         (WTR::UIScriptController::setHardwareKeyboardAttached):
212         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
213         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
214         (WTR::UIScriptController::setHardwareKeyboardAttached):
215         * TestRunnerShared/UIScriptContext/UIScriptController.h:
216         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
217
218         Additionally link against GraphicsServices in WebKitTestRunner.
219
220         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
221         (WTR::TestController::platformResetStateToConsistentValues):
222         (WTR::UIScriptController::setHardwareKeyboardAttached):
223
224 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
225
226         [GTK][WPE] Fix pacman install-dependencies packages
227         https://bugs.webkit.org/show_bug.cgi?id=196817
228
229         Reviewed by Žan Doberšek.
230         
231         python3-setuptools is called python-setuptools
232         ruby-highline is only available on AUR
233         libv4l-devel is incorporated in v4l-utils
234
235         * gtk/install-dependencies:
236         * wpe/install-dependencies:
237
238 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
239
240         [GTK] REGRESSION(r243860): Many tests failing
241         https://bugs.webkit.org/show_bug.cgi?id=196791
242
243         Reviewed by Joanmarie Diggs.
244
245         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
246         multiple documents and check that accessibility hierarchy is updated after a navigation.
247
248         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
249         (loadChangedCallback):
250         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
251         (AccessibilityTest::AccessibilityTest):
252         (AccessibilityTest::~AccessibilityTest):
253         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
254         (AccessibilityTest::findTestServerApplication):
255         (AccessibilityTest::findDocumentWeb):
256         (AccessibilityTest::findRootObject):
257         (AccessibilityTest::waitUntilChildrenRemoved):
258         (AccessibilityTest::ensureProxy):
259         (testAtspiBasicHierarchy):
260         (beforeAll):
261         (afterAll):
262
263 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
264
265         [ews-build] Handle bug titles with unicode characters
266         https://bugs.webkit.org/show_bug.cgi?id=196802
267
268         Reviewed by Dewei Zhu.
269
270         * BuildSlaveSupport/ews-build/steps.py:
271         (ValidatePatch._is_bug_closed):
272
273 2019-04-11  Michael Saboff  <msaboff@apple.com>
274
275         Improve the Inline Cache Stats code
276         https://bugs.webkit.org/show_bug.cgi?id=196836
277
278         Reviewed by Saam Barati.
279
280         Added a new script to consolidate and arrange the output of --useICStats option.
281
282         This script merges the output from every group into one large table and sorts it from most common to
283         least common.  It also counts the slow path GetById and PutById variants and then calculates the
284         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
285         Put together, this is useful to see what property accesses are not getting cached.
286
287         * Scripts/ic-stats.py: Added.
288         (ICStats):
289         (ICStats.__init__):
290         (ICStats.parse):
291         (ICStats.dumpStats):
292         (usage):
293
294 2019-04-10  Alex Christensen  <achristensen@webkit.org>
295
296         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
297         https://bugs.webkit.org/show_bug.cgi?id=196809
298         <rdar://49800762>
299
300         Reviewed by Brady Eidson.
301
302         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
303         (TEST):
304
305 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
306
307         requestAnimationFrame should execute before the next frame
308         https://bugs.webkit.org/show_bug.cgi?id=177484
309
310         Reviewed by Simon Fraser.
311
312         Add trace points for the page RenderingUpdate.
313
314         * Tracing/SystemTracePoints.plist:
315
316 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
317
318         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
319         https://bugs.webkit.org/show_bug.cgi?id=196760
320
321         Reviewed by Don Olmstead.
322
323         vswhere.exe has been bundled since Visual Studio 2017 version
324         15.2. We shouldn't download vswhere.exe.
325
326         * Scripts/build-jsc: Do not call update-vswhere.py.
327         * Scripts/build-webkit: Ditto.
328         * Scripts/update-vswhere.py: Removed.
329         * Scripts/webkitdirs.pm:
330         (requireModulesForVSWhere): Deleted.
331         (pickCurrentVisualStudioInstallation): Deleted.
332         (visualStudioInstallDirVSWhere): Return the latest installed VS
333         installation path by using the bundled vswhere.exe.
334         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
335         (visualStudioInstallDirFallback): Removed.
336
337 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
338
339         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
340         https://bugs.webkit.org/show_bug.cgi?id=196780
341
342         Reviewed by Alexey Proskuryakov.
343
344         * BuildSlaveSupport/ews-build/steps.py:
345         * BuildSlaveSupport/ews-build/steps_unittest.py:
346
347 2019-04-10  Alex Christensen  <achristensen@webkit.org>
348
349         Add SPI WKNavigationResponse._downloadAttribute
350         https://bugs.webkit.org/show_bug.cgi?id=196755
351         <rdar://49587365>
352
353         Reviewed by Brady Eidson.
354
355         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
356         (-[NavigationResponseTestDelegate navigationResponse]):
357         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
358         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
359         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
360         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
361         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
362         (readRequest):
363         (writeResponse):
364         (TEST):
365
366 2019-04-10  Tim Horton  <timothy_horton@apple.com>
367
368         Add modern API for overriding the page's specified viewport configuration
369         https://bugs.webkit.org/show_bug.cgi?id=167734
370         <rdar://problem/30331795>
371
372         Reviewed by Simon Fraser.
373
374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
375         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
376
377 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
378
379         Add support for incremental bytecode cache updates
380         https://bugs.webkit.org/show_bug.cgi?id=195000
381
382         Reviewed by Filip Pizlo.
383
384         Exit when the initial run to generate bytecode fails.
385
386         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
387
388 2019-04-10  Alex Christensen  <achristensen@webkit.org>
389
390         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
391         https://bugs.webkit.org/show_bug.cgi?id=196744
392         <rdar://49415309>
393
394         Reviewed by Chris Dumez.
395
396         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
397         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
398
399 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
400
401         Add a way to opt into modern compatibility mode in layout tests
402         https://bugs.webkit.org/show_bug.cgi?id=196770
403         <rdar://problem/49777550>
404
405         Reviewed by Antoine Quint.
406
407         Add a new test option to enable modern compatibility mode in layout tests.
408
409         * WebKitTestRunner/TestController.cpp:
410         (WTR::updateTestOptionsFromTestHeader):
411         * WebKitTestRunner/TestController.h:
412         * WebKitTestRunner/TestOptions.h:
413         (WTR::TestOptions::hasSameInitializationOptions const):
414         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
415         (WTR::TestController::platformCreateWebView):
416         (WTR::TestController::enableModernCompatibilityMode):
417
418 2019-04-10  Andy Estes  <aestes@apple.com>
419
420         Try to fix the 32-bit watchOS build.
421
422         * TestWebKitAPI/cocoa/TestWKWebView.mm:
423         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
424
425 2019-04-10  Antoine Quint  <graouts@apple.com>
426
427         Enable Pointer Events on watchOS
428         https://bugs.webkit.org/show_bug.cgi?id=196771
429         <rdar://problem/49040909>
430
431         Reviewed by Dean Jackson.
432
433         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
434
435 2019-04-10  Philippe Normand  <pnormand@igalia.com>
436
437         Unreviewed. Fix WPE accessibility tests after r244059.
438
439         We are failing to load the injected bundle due to undefined symbol
440         AccessibilityUIElement::replaceTextInRange().
441
442         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
443         (WTR::AccessibilityUIElement::replaceTextInRange):
444
445 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
446
447         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
448         https://bugs.webkit.org/show_bug.cgi?id=196727
449
450         Reviewed by Fujii Hironori.
451
452         * MiniBrowser/win/WebKitBrowserWindow.cpp:
453         (WebKitBrowserWindow::create):
454
455 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
456
457         [ews-build] Add unit tests for PrintConfiguration
458         https://bugs.webkit.org/show_bug.cgi?id=196752
459
460         Reviewed by Dewei Zhu.
461
462         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
463
464 2019-04-09  Keith Rollin  <krollin@apple.com>
465
466         Unreviewed build maintenance -- update .xcfilelists.
467
468         * DumpRenderTree/DerivedSources-input.xcfilelist:
469         * DumpRenderTree/DerivedSources-output.xcfilelist:
470
471 2019-04-09  Zalan Bujtas  <zalan@apple.com>
472
473         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
474         https://bugs.webkit.org/show_bug.cgi?id=196743
475         <rdar://problem/43897551>
476
477         Reviewed by Tim Horton.
478
479         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
480         (TEST):
481
482 2019-04-09  Youenn Fablet  <youenn@apple.com>
483
484         Close service worker database on network process suspension
485         https://bugs.webkit.org/show_bug.cgi?id=196623
486         <rdar://problem/48930869>
487
488         Reviewed by Alex Christensen.
489
490         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
491
492 2019-04-09  Daniel Bates  <dabates@apple.com>
493
494         [iPad] Should open popover when the spacebar is pressed
495         https://bugs.webkit.org/show_bug.cgi?id=196360
496         <rdar://problem/49389129>
497
498         Reviewed by Brent Fulgham.
499
500         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
501
502         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
503         (WTR::UIScriptController::isShowingPopover const): Added.
504         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
505         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
506         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
507         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
508         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
509         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
510         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
511         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
512         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
513         (WTR::UIScriptController::isShowingPopover const): Added.
514         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
515         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
516         * TestRunnerShared/UIScriptContext/UIScriptController.h:
517         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
518         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
519         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
520         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
521         (-[TestRunnerWKWebView _willPresentPopover]): Added.
522         (-[TestRunnerWKWebView _didDismissPopover]): Added.
523         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
524         (WTR::UIScriptController::isShowingPopover const): Added.
525         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
526         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
527
528 2019-04-09  Alex Christensen  <achristensen@webkit.org>
529
530         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
531         https://bugs.webkit.org/show_bug.cgi?id=196665
532         <rdar://45115669>
533
534         Reviewed by Geoff Garen.
535
536         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
537         (goBack):
538         (+[SimpleLookupContext sharedLookupContext]):
539         (-[SimpleLookupContext lookUpURL:completionHandler:]):
540         (TEST):
541         (+[Simple3LookupContext sharedLookupContext]): Deleted.
542         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
543
544 2019-04-09  John Wilander  <wilander@apple.com>
545
546         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
547         https://bugs.webkit.org/show_bug.cgi?id=196558
548         <rdar://problem/47650245>
549
550         Reviewed by Youenn Fablet.
551
552         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
553         (TestWebKitAPI::TEST):
554             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
555
556 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
557
558         [CMake] Apple builds should use ICU_INCLUDE_DIRS
559         https://bugs.webkit.org/show_bug.cgi?id=196720
560
561         Reviewed by Konstantin Tokarev.
562
563         * TestWebKitAPI/PlatformMac.cmake:
564
565 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
566
567         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
568         https://bugs.webkit.org/show_bug.cgi?id=196694
569         <rdar://problem/48388734>
570
571         Rubber-stamped by Aakash Jain.
572
573         * Scripts/webkitpy/port/image_diff.py:
574         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
575         * Scripts/webkitpy/port/server_process.py:
576         (ServerProcess.has_available_stdout): Check if stdout has data in it.
577         (ServerProcess._wait_for_data_and_update_buffers_using_select):
578         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
579         * Scripts/webkitpy/port/server_process_mock.py:
580         (MockServerProcess.has_available_stdout):
581         * Scripts/webkitpy/port/server_process_unittest.py:
582         (TestServerProcess.serial_test_basic):
583
584 2019-04-09  Jer Noble  <jer.noble@apple.com>
585
586         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
587         https://bugs.webkit.org/show_bug.cgi?id=196097
588
589         Reviewed by Eric Carlson.
590
591         Drive-by bug fix: allow tests to play audio without a user gesture by default.
592
593         * DumpRenderTree/mac/DumpRenderTree.mm:
594         (resetWebPreferencesToConsistentValues):
595         * WebKitTestRunner/TestController.cpp:
596         (WTR::TestController::resetPreferencesToConsistentValues):
597
598 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
599
600         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
601         https://bugs.webkit.org/show_bug.cgi?id=196690
602
603         Reviewed by Michael Catanzaro.
604
605         * QueueStatusServer/config/queues.py:
606         * Scripts/webkitpy/common/config/ews.json:
607         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
608         (test_ews_name):
609
610 2019-04-09  Chris Dumez  <cdumez@apple.com>
611
612         Loads using loadHTMLString() cause flashing when process-swapping
613         https://bugs.webkit.org/show_bug.cgi?id=196714
614         <rdar://problem/49637354>
615
616         Reviewed by Antti Koivisto.
617
618         Add API test coverage.
619
620         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
621
622 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
623
624         Unreviewed. Fix ATK accessibility tests after r244059.
625
626         We are failing to load the injected bundle due to undefined symbol
627         AccessibilityUIElement::replaceTextInRange().
628
629         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
630         (WTR::AccessibilityUIElement::replaceTextInRange):
631
632 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
633
634         AX: Support API: accessibilityReplaceRange:withText
635         https://bugs.webkit.org/show_bug.cgi?id=196636
636
637         Unreviewed build fix for Windows port.
638
639         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
640         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
641
642 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
643
644         [CMake][WinCairo] Separate copied headers into different directories
645         https://bugs.webkit.org/show_bug.cgi?id=196655
646
647         Reviewed by Michael Catanzaro.
648
649         * DumpRenderTree/CMakeLists.txt:
650         * MiniBrowser/win/CMakeLists.txt:
651         * TestWebKitAPI/CMakeLists.txt:
652         * TestWebKitAPI/PlatformWin.cmake:
653
654 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
655
656         Log stack-trace for run-webkit-tests when interrupted
657         https://bugs.webkit.org/show_bug.cgi?id=176393
658         <rdar://problem/34262310>
659
660         Reviewed by Lucas Forschler.
661
662         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
663         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
664         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
665         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
666         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
667         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
668         (main): Set handlers to log stack trace on interruption.
669
670 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
671
672         AX: Support API: accessibilityReplaceRange:withText
673         https://bugs.webkit.org/show_bug.cgi?id=196636
674
675         Unreviewed build fix for Windows port.
676
677         * DumpRenderTree/AccessibilityUIElement.cpp:
678         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
679
680 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
681
682         [ews-build] Scripts using Buildbot API have CORS error
683         https://bugs.webkit.org/show_bug.cgi?id=196709
684
685         Reviewed by Alexey Proskuryakov.
686
687         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
688
689 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
690
691         AX: Support API: accessibilityReplaceRange:withText
692         https://bugs.webkit.org/show_bug.cgi?id=196636
693
694         Reviewed by Daniel Bates.
695
696         * DumpRenderTree/AccessibilityUIElement.cpp:
697         (replaceTextInRangeCallback):
698         (AccessibilityUIElement::replaceTextInRange):
699         (AccessibilityUIElement::getJSClass):
700         * DumpRenderTree/AccessibilityUIElement.h:
701         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
702         (AccessibilityUIElement::replaceTextInRange):
703         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
704         (AccessibilityUIElement::replaceTextInRange):
705         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
706         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
707         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
708         (WTR::AccessibilityUIElement::replaceTextInRange):
709         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
710         (WTR::AccessibilityUIElement::replaceTextInRange):
711
712 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
713
714         [iOS] Do not allow starting selection drags when selection views are not visible
715         https://bugs.webkit.org/show_bug.cgi?id=196686
716         <rdar://problem/49399192>
717
718         Reviewed by Tim Horton.
719
720         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
721         also add some new API tests to cover scenarios where the web view is not first responder.
722
723         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
724         (TestWebKitAPI::TEST):
725         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
726
727         Add a switch to optionally make the web view first responder when starting the simulated drag.
728
729         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
730         (-[DragAndDropSimulator initWithWebView:]):
731         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
732
733 2019-04-08  Justin Fan  <justin_fan@apple.com>
734
735         [Web GPU] Fix Web GPU experimental feature on iOS
736         https://bugs.webkit.org/show_bug.cgi?id=196632
737
738         Reviewed by Myles C. Maxfield.
739
740         Properly make Web GPU available on iOS 11+.
741
742         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
743
744 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
745
746         [ews-build] Do not upload archive when Compile Fails
747         https://bugs.webkit.org/show_bug.cgi?id=196674
748
749         Reviewed by Alexey Proskuryakov.
750
751         * BuildSlaveSupport/ews-build/factories.py:
752         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
753         * BuildSlaveSupport/ews-build/steps.py:
754         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
755         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
756         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
757
758 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
759
760         Enable DFG on MIPS
761         https://bugs.webkit.org/show_bug.cgi?id=196689
762
763         Reviewed by Žan Doberšek.
764
765         Since the bytecode change, we enabled the baseline JIT on mips in
766         r240432, but DFG is still missing. With this change, all tests are
767         passing on a ci20 board.
768
769         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
770
771 2019-04-08  Philippe Normand  <pnormand@igalia.com>
772
773         [Flatpak] Second run update-webkitwpe-flatpak fails
774         https://bugs.webkit.org/show_bug.cgi?id=192702
775
776         Reviewed by Carlos Garcia Campos.
777
778         * flatpak/flatpakutils.py:
779         (FlatpakObject.flatpak): Fix typo.
780         (FlatpakPackage.install): When installing, also update to the configured remote commit.
781         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
782
783 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
784
785         [GTK][WPE] outlook.live.com displays old-fashioned UI
786         https://bugs.webkit.org/show_bug.cgi?id=196642
787
788         Reviewed by Carlos Garcia Campos.
789
790         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
791         (TestWebKitAPI::TEST): New Mac platform quirk test.
792
793 2019-04-07  Commit Queue  <commit-queue@webkit.org>
794
795         Unreviewed, rolling out r243956.
796         https://bugs.webkit.org/show_bug.cgi?id=196688
797
798         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
799         by aakashjain on #webkit).
800
801         Reverted changeset:
802
803         "Clicking "Go Back" from a safe browsing warning from an
804         iframe should navigate the WKWebView back to the previous
805         page"
806         https://bugs.webkit.org/show_bug.cgi?id=196665
807         https://trac.webkit.org/changeset/243956
808
809 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
810
811         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
812         https://bugs.webkit.org/show_bug.cgi?id=196669
813
814         Reviewed by Geoffrey Garen.
815
816         Added three new unit tests for WeakHashSet.
817
818         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
819         (WTF_WeakPtr.WeakHashSetConstObjects):
820         (WTF_WeakPtr.WeakHashSetComputesEmpty):
821         (WTF_WeakPtr.WeakHashSetComputeSize):
822
823 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
824
825         Hide next and previous form control buttons when WKWebView is editable
826         https://bugs.webkit.org/show_bug.cgi?id=196672
827         <rdar://problem/35625321>
828
829         Reviewed by Tim Horton.
830
831         Add a new API test.
832
833         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
834         (-[TestWKWebView lastTrailingBarButtonGroup]):
835         (TestWebKitAPI::TEST):
836         * TestWebKitAPI/ios/UIKitSPI.h:
837
838 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
839
840         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
841         https://bugs.webkit.org/show_bug.cgi?id=196077
842         <rdar://problem/49108202>
843
844         Reviewed by Chris Dumez.
845
846         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
847         on new web view.
848
849         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
850
851 2019-04-05  Saam Barati  <sbarati@apple.com>
852
853         Make compare-results understand MotionMark
854         https://bugs.webkit.org/show_bug.cgi?id=196666
855
856         Reviewed by Yusuke Suzuki.
857
858         * Scripts/compare-results:
859         (PLT5Results):
860         (detectMotionMark):
861         (detectMotionMark1_1):
862         (motionMarkResults):
863         (motionMark1_1Results):
864         (detectBenchmark):
865         (biggerIsBetter):
866         (main):
867
868 2019-04-05  Alex Christensen  <achristensen@webkit.org>
869
870         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
871         https://bugs.webkit.org/show_bug.cgi?id=196665
872         <rdar://45115669>
873
874         Reviewed by Geoff Garen.
875
876         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
877         (goBack):
878         (+[SimpleLookupContext sharedLookupContext]):
879         (-[SimpleLookupContext lookUpURL:completionHandler:]):
880         (TEST):
881         (+[Simple3LookupContext sharedLookupContext]): Deleted.
882         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
883
884 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
885
886         [ews-build] Add configuration and architecture for windows builders
887         https://bugs.webkit.org/show_bug.cgi?id=196660
888
889         Reviewed by Lucas Forschler.
890
891         * BuildSlaveSupport/ews-build/config.json:
892
893 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
894
895         webkitpy: Don't run subsequent rounds if interrupted
896         https://bugs.webkit.org/show_bug.cgi?id=196646
897
898         Reviewed by Aakash Jain.
899
900         * Scripts/webkitpy/layout_tests/controllers/manager.py:
901         (Manager.run): Bail out if interrupted.
902
903 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
904
905         Test sessionStorage in PSON private browsing mode
906         https://bugs.webkit.org/show_bug.cgi?id=196561
907
908         Reviewed by Alex Christensen.
909
910         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
911
912 2019-04-05  Commit Queue  <commit-queue@webkit.org>
913
914         Unreviewed, rolling out r243833.
915         https://bugs.webkit.org/show_bug.cgi?id=196645
916
917         This change breaks build of WPE and GTK ports (Requested by
918         annulen on #webkit).
919
920         Reverted changeset:
921
922         "[CMake][WTF] Mirror XCode header directories"
923         https://bugs.webkit.org/show_bug.cgi?id=191662
924         https://trac.webkit.org/changeset/243833
925
926 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
927
928         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
929         https://bugs.webkit.org/show_bug.cgi?id=196635
930
931         Reviewed by Antti Koivisto.
932         
933         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
934         for a test to enable async frame scrolling via:
935             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
936         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
937         
938         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
939
940         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
941         (WTR::InjectedBundle::beginTesting):
942         * WebKitTestRunner/TestController.cpp:
943         (WTR::TestController::resetPreferencesToConsistentValues):
944
945 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
946
947         Use a correct LC_RPATH when building with ASan
948         https://bugs.webkit.org/show_bug.cgi?id=196576
949
950         Reviewed by David Kilzer.
951
952         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
953         so that ../Frameworks is checked. This is simpler and more reliable than updating
954         each SPC service xcconfig.
955
956 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
957
958         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
959         https://bugs.webkit.org/show_bug.cgi?id=196629
960
961         Reviewed by Lucas Forschler.
962
963         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
964
965 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
966
967         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
968         https://bugs.webkit.org/show_bug.cgi?id=196618
969
970         Reviewed by Lucas Forschler.
971
972         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
973         (StatusBubble): Added QUEUE_TRIGGERS.
974         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
975         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
976         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
977         its parent(builder).
978
979 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
980
981         [ews-app] Status-bubble steps are sometimes displayed in reverse order
982         https://bugs.webkit.org/show_bug.cgi?id=196625
983
984         Reviewed by Lucas Forschler.
985
986         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
987         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
988
989 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
990
991         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
992         https://bugs.webkit.org/show_bug.cgi?id=196630
993
994         Reviewed by Wenson Hsieh.
995
996         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
997
998 2019-04-04  Youenn Fablet  <youenn@apple.com>
999
1000         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1001         https://bugs.webkit.org/show_bug.cgi?id=196543
1002
1003         Reviewed by Alex Christensen.
1004
1005         * WebKitTestRunner/TestController.cpp:
1006         (WTR::TestController::generatePageConfiguration):
1007
1008 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1009
1010         [ews-app] Status bubble should not display skipped buildbot steps
1011         https://bugs.webkit.org/show_bug.cgi?id=196584
1012
1013         Reviewed by Lucas Forschler.
1014
1015         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1016
1017 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1018
1019         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1020         https://bugs.webkit.org/show_bug.cgi?id=196620
1021
1022         Reviewed by Lucas Forschler.
1023
1024         * BuildSlaveSupport/ews-app/ews/config.py:
1025
1026 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1027
1028         [Win] DumpRenderTreeWatchDog.py is not checked into source
1029         https://bugs.webkit.org/show_bug.cgi?id=196567
1030         <rdar://problem/49525901>
1031
1032         Reviewed by Lucas Forschler.
1033
1034         This script is used on Win EWS bots to terminate hanging DRT processes.
1035
1036         * EWSTools/dumprendertreewatchdog.py: Added.
1037
1038 2019-04-04  Chris Dumez  <cdumez@apple.com>
1039
1040         Unreviewed, roll out r243858 which made tests time out.
1041
1042         Disable new API tests on Windows instead.
1043
1044         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1045         (TestWebKitAPI::TEST):
1046
1047 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1048
1049         [ATK] Cleanup WebPageAccessibilityObjectAtk
1050         https://bugs.webkit.org/show_bug.cgi?id=196537
1051
1052         Reviewed by Michael Catanzaro.
1053
1054         Also consider files under atk directories as exceptions for GObject conventions.
1055
1056         * Scripts/webkitpy/style/checkers/cpp.py:
1057         (check_identifier_name_in_declaration):
1058
1059 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1060
1061         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1062         https://bugs.webkit.org/show_bug.cgi?id=196588
1063         <rdar://problem/49365787>
1064
1065         Unreviewed build fix for Windows port.
1066
1067         error C3861: 'kill': identifier not found
1068
1069         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1070         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1071
1072 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1073
1074         [ews-build] Cancel build and similar operations should have authentication
1075         https://bugs.webkit.org/show_bug.cgi?id=196520
1076
1077         Reviewed by Dewei Zhu.
1078
1079         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1080         environment variables.
1081
1082 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1083
1084         [ews-build] Do not trigger queues which are not in production yet
1085         https://bugs.webkit.org/show_bug.cgi?id=196581
1086
1087         Reviewed by Dewei Zhu.
1088
1089         * BuildSlaveSupport/ews-build/config.json:
1090
1091 2019-04-03  Chris Dumez  <cdumez@apple.com>
1092
1093         Unreviewed, fix typo in the name of API test added in r243848.
1094
1095         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1096         (TestWebKitAPI::TEST):
1097
1098 2019-04-03  Chris Dumez  <cdumez@apple.com>
1099
1100         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1101         https://bugs.webkit.org/show_bug.cgi?id=196588
1102         <rdar://problem/49365787>
1103
1104         Reviewed by Ryosuke Niwa.
1105
1106         Add API test coverage.
1107
1108         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1109         (TestWebKitAPI::nullJavaScriptCallback):
1110         (TestWebKitAPI::didCrashCheckFrames):
1111         (TestWebKitAPI::TEST):
1112
1113 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1114
1115         run-webkit-tests: Upload test results (new results database)
1116         https://bugs.webkit.org/show_bug.cgi?id=196577
1117         <rdar://problem/34841155>
1118
1119         Reviewed by Lucas Forschler.
1120
1121         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1122         (Manager.run): Upload results after each device shard, since the configuration will be
1123         different for each device.
1124         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1125         uploaded to a results database.
1126         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1127         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1128
1129 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1130
1131         -apple-trailing-word is needed for browser detection
1132         https://bugs.webkit.org/show_bug.cgi?id=196575
1133
1134         Unreviewed.
1135
1136         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1137
1138 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1139
1140         [CMake][WTF] Mirror XCode header directories
1141         https://bugs.webkit.org/show_bug.cgi?id=191662
1142
1143         Reviewed by Konstantin Tokarev.
1144
1145         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1146         builds.
1147
1148         * CMakeLists.txt:
1149         * DumpRenderTree/CMakeLists.txt:
1150         * DumpRenderTree/PlatformWin.cmake:
1151         * MiniBrowser/win/CMakeLists.txt:
1152         * TestWebKitAPI/CMakeLists.txt:
1153         * TestWebKitAPI/PlatformWin.cmake:
1154         * WebKitTestRunner/PlatformGTK.cmake:
1155         * WebKitTestRunner/PlatformWin.cmake:
1156
1157 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1158
1159         [ews-app] Status bubble should not display certain infrastructure status messages
1160         https://bugs.webkit.org/show_bug.cgi?id=196550
1161
1162         Reviewed by Lucas Forschler.
1163
1164         Do not display the steps which are un-needed for end-user. This information is still avaiable
1165         if the user click on the bubble and look at the Buildbot build.
1166         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1167         (StatusBubble._steps_messages):
1168         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1169
1170 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1171
1172         [ews-build] Use https for sending data to ews-app
1173         https://bugs.webkit.org/show_bug.cgi?id=196492
1174
1175         Reviewed by Lucas Forschler.
1176
1177         * BuildSlaveSupport/ews-build/events.py:
1178
1179 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1180
1181         Remove support for -apple-trailing-word
1182         https://bugs.webkit.org/show_bug.cgi?id=196525
1183
1184         Reviewed by Zalan Bujtas.
1185
1186         This CSS property is nonstandard and not used.
1187
1188         * Scripts/webkitperl/FeatureList.pm:
1189         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1190
1191 2019-04-03  Youenn Fablet  <youenn@apple.com>
1192
1193         Add a test for DOMCache on multiple browsing in case of private browsing
1194         https://bugs.webkit.org/show_bug.cgi?id=196524
1195
1196         Reviewed by Alex Christensen.
1197
1198         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1199         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1200
1201 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1202
1203         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1204         https://bugs.webkit.org/show_bug.cgi?id=196540
1205
1206         Reviewed by Aakash Jain.
1207
1208         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1209
1210 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1211
1212         Add plumbing for a compatibility mode preference in WebKit
1213         https://bugs.webkit.org/show_bug.cgi?id=196005
1214
1215         Reviewed by Tim Horton.
1216
1217         Add new API tests.
1218
1219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1220         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1221
1222 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1223
1224         [WPE][GTK] Update libsrtp dependency package for Debian
1225         https://bugs.webkit.org/show_bug.cgi?id=196528
1226
1227         Reviewed by Frédéric Wang.
1228
1229         * gtk/install-dependencies:
1230         * wpe/install-dependencies:
1231
1232 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1233
1234         [WK2] Add support for Window's beforeprint / afterprint events
1235         https://bugs.webkit.org/show_bug.cgi?id=196478
1236         <rdar://problem/49535124>
1237
1238         Unreviewed build fix for MSVC.
1239
1240         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1241
1242         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1243
1244         * WebKitTestRunner/TestController.cpp:
1245         (WTR::printFrame): Use int and float literals.
1246
1247 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1248
1249         [ews-build] Reassign bots to queues
1250
1251         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1252
1253 2019-04-02  Chris Dumez  <cdumez@apple.com>
1254
1255         [WK2] Add support for Window's beforeprint / afterprint events
1256         https://bugs.webkit.org/show_bug.cgi?id=196478
1257
1258         Reviewed by Alex Christensen.
1259
1260         Add minimal implementation for printFrame in WebKitTestRunner.
1261
1262         * WebKitTestRunner/TestController.cpp:
1263         (WTR::printFrame):
1264         (WTR::TestController::createOtherPage):
1265         (WTR::TestController::createWebViewWithOptions):
1266
1267 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1268
1269         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1270         https://bugs.webkit.org/show_bug.cgi?id=196491
1271
1272         Reviewed by Lucas Forschler.
1273
1274         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1275
1276 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1277
1278         [ews-build] Configure buildbot try credentials in environment variables
1279         https://bugs.webkit.org/show_bug.cgi?id=196501
1280
1281         Reviewed by Lucas Forschler.
1282
1283         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1284         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1285         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1286
1287 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1288
1289         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1290         https://bugs.webkit.org/show_bug.cgi?id=196496
1291         <rdar://problem/49521634>
1292
1293         Reviewed by Chris Dumez.
1294
1295         Add new API tests (see WebKit ChangeLog for more detail).
1296
1297         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1298         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1299         (TEST):
1300
1301 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1302
1303         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1304         <https://webkit.org/b/196499>
1305
1306         Reviewed by Alexey Proskuryakov.
1307
1308         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1309         ENABLE_ADDRESS_SANITIZER.
1310
1311 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1312
1313         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1314         https://bugs.webkit.org/show_bug.cgi?id=182757
1315
1316         Reviewed by Don Olmstead.
1317
1318         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1319         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1320
1321 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1322
1323         run-api-tests: Upload test results
1324         https://bugs.webkit.org/show_bug.cgi?id=196323
1325         <rdar://problem/49356714>
1326
1327         Reviewed by Lucas Forschler.
1328
1329         * Scripts/webkitpy/api_tests/manager.py:
1330         (Manager):
1331         (Manager.run): Upload results to a results database.
1332         * Scripts/webkitpy/api_tests/run_api_tests.py:
1333         (parse_args): Add upload arguments.
1334         * Scripts/webkitpy/port/base.py:
1335         (Port):
1336         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1337         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1338         with commits from any other associated repositories.
1339         * Scripts/webkitpy/port/device.py:
1340         (Device):
1341         (Device.build_version): Access build_versoin of underlying platform device.
1342         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1343         (IOSSimulatorTest):
1344         (IOSSimulatorTest.test_configuration_for_upload):
1345         * Scripts/webkitpy/port/device_port.py:
1346         (DevicePort):
1347         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1348         the same as the machine uploading results.
1349         * Scripts/webkitpy/port/mac.py:
1350         (MacPort):
1351         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1352         * Scripts/webkitpy/port/mac_unittest.py:
1353         (MacTest):
1354         (MacTest.test_configuration_for_upload):
1355         * Scripts/webkitpy/xcode/simulated_device.py:
1356         (SimulatedDeviceManager._create_device_with_runtime):
1357         (SimulatedDevice.__init__): Create simulated device with a build_version.
1358         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1359         (test_existing_simulator):
1360
1361 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1362
1363         Remove extra newline characters (Follow-up fix to r243707)
1364
1365         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1366
1367 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1368
1369         [ews-app] Use API_KEY to accept results data
1370         https://bugs.webkit.org/show_bug.cgi?id=196461
1371
1372         Reviewed by Dewei Zhu.
1373
1374         * BuildSlaveSupport/ews-app/ews/views/results.py:
1375         (Results.post): Validate EWS_API_KEY before accepting any data.
1376         * BuildSlaveSupport/ews-build/events.py:
1377         (Events.sendData): Send EWS_API_KEY if available along with event data.
1378
1379 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1380
1381         Unable to copy and paste a PDF from Notes into Mail compose body
1382         https://bugs.webkit.org/show_bug.cgi?id=196442
1383         <rdar://problem/48573098>
1384
1385         Reviewed by Tim Horton.
1386
1387         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1388         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1389         to be specified on the item providers.
1390
1391         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1392         (TestWebKitAPI::mapItemForTesting):
1393         (TestWebKitAPI::contactItemForTesting):
1394
1395 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1396
1397         Make UIWKDocumentContext rects per-character instead of per-word
1398         https://bugs.webkit.org/show_bug.cgi?id=196459
1399
1400         Reviewed by Wenson Hsieh.
1401
1402         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1403         (TEST):
1404         Adjust test results due to switching to per-character rects.
1405
1406 2019-04-01  Chris Dumez  <cdumez@apple.com>
1407
1408         UIProcess crash when a prewarmed process is terminated
1409         https://bugs.webkit.org/show_bug.cgi?id=196451
1410         <rdar://problem/49245471>
1411
1412         Reviewed by Geoffrey Garen.
1413
1414         Add API test coverage.
1415
1416         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1417         (TEST):
1418
1419 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1420
1421         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1422         https://bugs.webkit.org/show_bug.cgi?id=196449
1423
1424         Reviewed by Lucas Forschler.
1425
1426         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1427         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1428         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1429         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1430
1431 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1432
1433         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1434         https://bugs.webkit.org/show_bug.cgi?id=196444
1435
1436         Reviewed by Lucas Forschler.
1437
1438         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1439
1440 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1441
1442         Add SPI to canonicalize NSURLs with WTF::URL
1443         https://bugs.webkit.org/show_bug.cgi?id=196415
1444         <rdar://problem/44980271>
1445
1446         Reviewed by Darin Adler.
1447
1448         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1449         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1450         (TestWebKitAPI::TEST):
1451
1452 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1453
1454         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1455         https://bugs.webkit.org/show_bug.cgi?id=196441
1456
1457         Reviewed by Carlos Garcia Campos.
1458
1459         Don't cache the wpe_view_backend object that might not exist yet at the
1460         time of EventSenderProxy constructor invocation, but instead retrieve
1461         that object whenever it's required for event dispatching. This should
1462         avoid crashes in this constructor now that it's invoked before any
1463         PlatformWindow has been set up (as changed in r243496).
1464
1465         * WebKitTestRunner/EventSenderProxy.h:
1466         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1467         (WTR::viewBackend):
1468         (WTR::EventSenderProxy::EventSenderProxy):
1469         (WTR::EventSenderProxy::mouseDown):
1470         (WTR::EventSenderProxy::mouseUp):
1471         (WTR::EventSenderProxy::mouseMoveTo):
1472         (WTR::EventSenderProxy::mouseScrollBy):
1473         (WTR::EventSenderProxy::keyDown):
1474         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1475
1476 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1477
1478         [Win][WebKit] MiniBrowser should support high DPI display
1479         https://bugs.webkit.org/show_bug.cgi?id=196391
1480
1481         Reviewed by Alex Christensen.
1482
1483         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1484         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1485         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1486         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1487
1488 2019-03-31  Sam Weinig  <weinig@apple.com>
1489
1490         Remove more i386 specific configurations
1491         https://bugs.webkit.org/show_bug.cgi?id=196430
1492
1493         Reviewed by Alexey Proskuryakov.
1494
1495         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1496         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1497
1498 2019-03-31  Andy Estes  <aestes@apple.com>
1499
1500         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1501         https://bugs.webkit.org/show_bug.cgi?id=196433
1502         <rdar://problem/49293305>
1503
1504         Reviewed by Tim Horton.
1505
1506         Enhanced API test coverage to include all navigation response policy decisions in both
1507         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1508
1509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1510         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1511         (TestWebKitAPI::TEST):
1512         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1513         (readFile):
1514         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1515         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1516         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1517         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1518         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1519         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1520         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1521         (-[QuickLookDelegate _downloadDidStart:]):
1522         (-[QuickLookDelegate _download:didReceiveResponse:]):
1523         (-[QuickLookDelegate _download:didReceiveData:]):
1524         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1525         (-[QuickLookDelegate _downloadDidFinish:]):
1526         (-[QuickLookDelegate _download:didFailWithError:]):
1527         (-[QuickLookDelegate _downloadDidCancel:]):
1528         (-[QuickLookDelegate verifyDownload]):
1529         (runTest):
1530         (runTestDecideBeforeLoading):
1531         (runTestDecideAfterLoading):
1532         (TEST):
1533         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1534         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1535         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1536         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1537         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1538         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1539         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1540         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1541         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1542         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1543         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1544         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1545         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1546         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1547
1548 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1549
1550         [CMake] add testdfg as target with build-jsc
1551         https://bugs.webkit.org/show_bug.cgi?id=196393
1552
1553         Reviewed by Saam Barati.
1554
1555         Added testdfg as one of the targets to build when
1556         using CMake.
1557
1558         * Scripts/build-jsc:
1559
1560 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1561
1562         Delete WebMetal implementation in favor of WebGPU
1563         https://bugs.webkit.org/show_bug.cgi?id=195418
1564
1565         Reviewed by Dean Jackson.
1566
1567         * DumpRenderTree/mac/DumpRenderTree.mm:
1568         (enableExperimentalFeatures):
1569         (resetWebPreferencesToConsistentValues):
1570         * Scripts/webkitperl/FeatureList.pm:
1571         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1573         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1574         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1575         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1576         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1577         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1578         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1579         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1580         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1581         (WTR::InjectedBundle::beginTesting):
1582         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1583         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1584         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1585
1586 2019-03-29  Chris Dumez  <cdumez@apple.com>
1587
1588         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1589         https://bugs.webkit.org/show_bug.cgi?id=196405
1590         <rdar://problem/49428130>
1591
1592         Reviewed by Wenson Hsieh.
1593
1594         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1595         the popover presentation methods to be no-ops. Use this in the new test added in
1596         r243523 so that we do not swizzle those methods for all tests. This is needed because
1597         those WatchOS tests rely on the popover getting presented and interactive.
1598
1599         * WebKitTestRunner/TestController.cpp:
1600         (WTR::updateTestOptionsFromTestHeader):
1601         * WebKitTestRunner/TestController.h:
1602         * WebKitTestRunner/TestOptions.h:
1603         (WTR::TestOptions::hasSameInitializationOptions const):
1604         * WebKitTestRunner/ios/TestControllerIOS.mm:
1605         (WTR::TestController::platformInitialize):
1606         (WTR::TestController::platformResetStateToConsistentValues):
1607
1608 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1609
1610         [Curl] Add Server Trust Evaluation Support.
1611         https://bugs.webkit.org/show_bug.cgi?id=191646
1612
1613         Reviewed by Fujii Hironori.
1614
1615         Implemented MiniBrowser UI for asking if user trusts the server.
1616
1617         * MiniBrowser/win/Common.cpp:
1618         (askServerTrustEvaluation):
1619         (replaceString):
1620         * MiniBrowser/win/Common.h:
1621         * MiniBrowser/win/MiniBrowserLib.rc:
1622         * MiniBrowser/win/MiniBrowserLibResource.h:
1623         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1624         (createPEMString):
1625         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1626         (WebKitBrowserWindow::canTrustServerCertificate):
1627         * MiniBrowser/win/WebKitBrowserWindow.h:
1628
1629 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1630
1631         Implement ResizeObserver.
1632         https://bugs.webkit.org/show_bug.cgi?id=157743
1633
1634         Reviewed by Simon Fraser.
1635
1636         Support resizeObserverEnabled webPreferences.
1637
1638         * DumpRenderTree/TestOptions.cpp:
1639         (TestOptions::TestOptions):
1640         * DumpRenderTree/TestOptions.h:
1641         * DumpRenderTree/mac/DumpRenderTree.mm:
1642         (setWebPreferencesForTestOptions):
1643         * DumpRenderTree/win/DumpRenderTree.cpp:
1644         (enableExperimentalFeatures):
1645         * Scripts/webkitperl/FeatureList.pm:
1646         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1647
1648 2019-03-28  John Wilander  <wilander@apple.com>
1649
1650         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1651         https://bugs.webkit.org/show_bug.cgi?id=196281
1652         <rdar://problem/48938748>
1653
1654         Reviewed by Alex Christensen.
1655
1656         This patch adds the function isStatisticsHasLocalStorage() to the
1657         TestRunner. With it, the page can query the WebsiteDataStore in the
1658         UI process to make sure that it sees LocalStorage.
1659
1660         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1661         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1662         (WTR::TestRunner::isStatisticsHasLocalStorage):
1663         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1664         * WebKitTestRunner/TestController.cpp:
1665         (WTR::TestController::isStatisticsHasLocalStorage):
1666         * WebKitTestRunner/TestController.h:
1667         * WebKitTestRunner/TestInvocation.cpp:
1668         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1669
1670 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1671
1672         API::Data::createWithoutCopying should do a null check before calling CFRelease
1673         https://bugs.webkit.org/show_bug.cgi?id=196276
1674         <rdar://problem/48059859>
1675
1676         Reviewed by Alex Christensen.
1677
1678         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1679
1680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1681         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1682         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1683         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1684         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1685         (TestWebKitAPI::TEST):
1686
1687 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1688
1689         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1690         https://bugs.webkit.org/show_bug.cgi?id=186276
1691
1692         Reviewed by Carlos Garcia Campos.
1693
1694         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1695         (webViewLoadChanged):
1696         (testWebResourceGetDataError):
1697         (testWebResourceGetDataEmpty):
1698         (beforeAll):
1699         (webViewloadChanged): Deleted.
1700
1701 2019-03-27  Andy Estes  <aestes@apple.com>
1702
1703         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1704         https://bugs.webkit.org/show_bug.cgi?id=196317
1705
1706         Reviewed by Dan Bernstein.
1707
1708         package-root copies built products into a staging directory using ditto(1), which does not
1709         follow symbolic links as it traverses a directory. Now that the files in
1710         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1711         itself, these become broken links when ditto'd into the staging directory.
1712
1713         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1714
1715         * Scripts/package-root:
1716
1717 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1718
1719         [ews-app] Update display text of Submit for ews analysis
1720         https://bugs.webkit.org/show_bug.cgi?id=196309
1721
1722         Reviewed by Dewei Zhu.
1723
1724         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1725
1726 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1727
1728         run-webkit-tests should check for leaks in WebKit processes
1729         <https://webkit.org/b/193772>
1730         <rdar://problem/46526680>
1731
1732         Reviewed by Ryosuke Niwa.
1733
1734         This works by doing the following:
1735         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1736           The list of child processes are returned one per line:
1737           process.name: pid
1738         - Run the "#LIST CHILD PROCESSES" command just before the
1739           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1740           processes on the ServerProcess object.
1741         - When the `--leaks` switch is handled, run check_for_leaks() on
1742           each child process after the main test harness.
1743
1744         * DumpRenderTree/mac/DumpRenderTree.mm:
1745         (handleControlCommand):
1746         - Use strncmp() instead of strcmp().
1747         - Add support for handling "#LIST CHILD PROCESSES" command.
1748
1749         * Scripts/webkitpy/port/base.py:
1750         (Port.check_for_leaks):
1751         * Scripts/webkitpy/port/darwin.py:
1752         (DarwinPort.check_for_leaks):
1753         - Rename redundant 'process_pid' argument to 'process_id'.
1754
1755         * Scripts/webkitpy/port/driver.py:
1756         (Driver.do_post_tests_work):
1757         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1758           longer the only command this sends to WebKitTestRunner.
1759         - If the `--leaks` switch is present, send the
1760           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1761           result using Port.set_webkit_processes().
1762         (Driver._parse_child_processes_output):
1763         - Add helper method to parse list of child process names and
1764           process IDs returned from WebKitTestRunner.
1765
1766         * Scripts/webkitpy/port/ios_device.py:
1767         (IOSDevicePort.check_for_leaks):
1768         - Rename redundant 'process_pid' argument to 'process_id'.
1769
1770         * Scripts/webkitpy/port/leakdetector.py:
1771         (LeakDetector._parse_leaks_output):
1772         - Return early if there is no leaks_output.
1773         (LeakDetector.check_for_leaks):
1774         - Rename redundant 'process_pid' argument to 'process_id'.
1775
1776         * Scripts/webkitpy/port/server_process.py:
1777         (ServerProcess.__init__):
1778         (ServerProcess.child_processes):
1779         (ServerProcess.set_child_processes):
1780         - Add instance variable to Port to store list of child process
1781           names and process IDs returned from WebKitTestRunner.
1782         (ServerProcess._start):
1783         - Clear self._child_processes.
1784         (ServerProcess.stop):
1785         - If self._child_processes is set, call
1786           self._port.check_for_leaks() for each child process.
1787
1788         * Scripts/webkitpy/port/server_process_unittest.py:
1789         (TrivialMockPort.check_for_leaks):
1790         - Rename redundant 'process_pid' argument to 'process_id'.
1791
1792         * Scripts/webkitpy/port/simulator_process.py:
1793         (SimulatorProcess.stop):
1794         - If self._child_processes is set, call
1795           self._port.check_for_leaks() for each child process.
1796
1797         * Scripts/webkitpy/port/watch_device.py:
1798         (WatchDevicePort.check_for_leaks):
1799         - Rename redundant 'process_pid' argument to 'process_id'.
1800
1801         * WebKitTestRunner/TestController.cpp:
1802         (WTR::TestController::dumpResponse):
1803         - Extract method from findAndDumpWorldLeaks() so that it may be
1804           reused by findAndDumpWebKitProcessIdentifiers().
1805         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1806         - Add method to output process name and process ID of both the
1807           WebContent and Networking processes.
1808         (WTR::TestController::findAndDumpWorldLeaks):
1809         - Fix missing newline in output when there were no abandoned
1810           documents.
1811         - Call dumpResponse() for extracted code.
1812         (WTR::TestController::handleControlCommand):
1813         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1814         - Use strncmp() instead of strcmp().
1815         - Call findAndDumpWebKitProcessIdentifiers() when
1816           "#LIST CHILD PROCESSES" command is sent.
1817         * WebKitTestRunner/TestController.h:
1818         (WTR::TestController::dumpResponse):
1819         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1820         - Declare methods.
1821
1822 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1823
1824         Unreviewed. Add GLib API test cases after r243434.
1825
1826         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1827         (testWebViewActiveURI):
1828         (serverCallback):
1829         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1830         (sendRequestCallback):
1831
1832 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1833
1834         Geolocation request not complete when watch request was started in a different web process
1835         https://bugs.webkit.org/show_bug.cgi?id=195996
1836
1837         Reviewed by Alex Christensen.
1838
1839         Add a test case.
1840
1841         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1842         (TestWebKitAPI::runJavaScriptAlert):
1843         (TestWebKitAPI::TEST):
1844
1845 2019-03-26  Keith Rollin  <krollin@apple.com>
1846
1847         Update the way generate-xcfilelists returns strings from functions
1848         https://bugs.webkit.org/show_bug.cgi?id=195975
1849         <rdar://problem/49040807>
1850
1851         Reviewed by Dean Jackson.
1852
1853         There are places where generate-xcfilelists executes assignments with
1854         statements like:
1855
1856             FOO=$(some_function)
1857
1858         where "some_function" return a string by echoing it. E.g.
1859
1860             some_function()
1861             {
1862                 echo "Hello, World"
1863             }
1864
1865         This is a common idiom, but it has a problem if "some_function" needs
1866         to call "exit" in an attempt to halt the entire script right then and
1867         there. Since "some_function" is called inside of $(), it's being
1868         executed in a sub-shell. Calling exit in that sub-shell simply exits
1869         that shell; it doesn't not exit the outer shell in which the main part
1870         of the script is still running. As such, the main script keeps
1871         executing when the intent was for the script to halt.
1872
1873         The solution to this is to use a different idiom for returning
1874         strings. The one we now is to pass in the name of the variable to
1875         receive the string result:
1876
1877             some_function()
1878             {
1879                 variable_name=$1
1880                 eval $variable_name ="Hello, World"
1881             }
1882
1883         The call site now looks like
1884
1885             some_function FOO
1886
1887         Because there's no invocation of a sub-shell, some_function can now
1888         call "exit" if it wants to, and the entire script will exit at that
1889         point.
1890
1891         * Scripts/generate-xcfilelists:
1892
1893 2019-03-26  Chris Dumez  <cdumez@apple.com>
1894
1895         Add basic layout test coverage for File Picker on iOS
1896         https://bugs.webkit.org/show_bug.cgi?id=196265
1897
1898         Reviewed by Wenson Hsieh.
1899
1900         Add layout test infrastructure to test the file picker on iOS.
1901
1902         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1903         (WTR::UIScriptController::dismissFilePicker):
1904         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1905         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1906         (WTR::UIScriptController::dismissFilePicker):
1907         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1908         * WebKitTestRunner/TestController.cpp:
1909         (WTR::TestController::createWebViewWithOptions):
1910         (WTR::updateTestOptionsFromTestHeader):
1911         * WebKitTestRunner/TestOptions.h:
1912         (WTR::TestOptions::hasSameInitializationOptions const):
1913         * WebKitTestRunner/ios/TestControllerIOS.mm:
1914         (overridePresentViewController):
1915         (WTR::TestController::platformInitialize):
1916         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1917         (WTR::UIScriptController::dismissFilePicker):
1918
1919 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1920
1921         Implement async paste method on UIWKInteractionViewProtocol
1922         https://bugs.webkit.org/show_bug.cgi?id=196267
1923         <rdar://problem/49236346>
1924
1925         Reviewed by Tim Horton.
1926
1927         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1928         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1929         are now a part of all iOS 12 internal SDKs.
1930
1931         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1932
1933         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1934         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1935
1936         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1937         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1938         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1939         * TestWebKitAPI/ios/UIKitSPI.h:
1940
1941 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1942
1943         [ews-build] Use PostgreSQL for ews.webkit.org database
1944         https://bugs.webkit.org/show_bug.cgi?id=196270
1945
1946         Reviewed by Lucas Forschler.
1947
1948         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1949
1950 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1951
1952         [ews] Reset simctl states on reboot
1953         https://bugs.webkit.org/show_bug.cgi?id=196260
1954
1955         Rubber-stamped by Aakash Jain.
1956
1957         * EWSTools/start-queue-mac.sh:
1958
1959 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1960
1961         [ews-build] Use PostgreSQL for ews-build database
1962         https://bugs.webkit.org/show_bug.cgi?id=196229
1963
1964         Reviewed by Lucas Forschler.
1965
1966         * BuildSlaveSupport/ews-build/master.cfg:
1967
1968 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1969
1970         [ews-build] Get master_hostname dynamically in master.cfg
1971         https://bugs.webkit.org/show_bug.cgi?id=196255
1972
1973         Reviewed by Lucas Forschler.
1974
1975         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1976         send events data in test mode.
1977
1978 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1979
1980         [ews-app] Set db_constraint to False for Foreign Keys
1981         https://bugs.webkit.org/show_bug.cgi?id=196252
1982
1983         Reviewed by Lucas Forschler.
1984
1985         * BuildSlaveSupport/ews-app/ews/models/build.py:
1986         * BuildSlaveSupport/ews-app/ews/models/step.py:
1987
1988 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1989
1990         [ews-build] is_test_mode_enabled should default to True
1991         https://bugs.webkit.org/show_bug.cgi?id=196248
1992
1993         Reviewed by Lucas Forschler.
1994
1995         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1996
1997 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1998
1999         [ews-app] Add webkitperl to ENABLED_QUEUES
2000         https://bugs.webkit.org/show_bug.cgi?id=196253
2001
2002         Reviewed by Lucas Forschler.
2003
2004         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2005
2006 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2007
2008         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2009         https://bugs.webkit.org/show_bug.cgi?id=196211
2010         rdar://problem/49110552
2011
2012         Reviewed by Tim Horton.
2013
2014         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2015         Make sure that EventSenderProxy always exists when running tests. We used to create
2016         it when resetting before the first test, which is a bit too late.
2017
2018         * WebKitTestRunner/TestController.h:
2019         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2020         (WTR::TestController::platformCreateWebView):
2021         (WTR::TestController::platformCreateOtherPage):
2022         (WTR::TestController::finishCreatingPlatformWebView):
2023         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2024         (WTR::PlatformWebView::PlatformWebView):
2025         Moved some code that made NSWindow use NSEvent during web view creation. We may
2026         need to move more if some other case us found, but this is enough for now.
2027
2028 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2029
2030         Unreviewed. Fix typo in GLib geolocation API after r243285.
2031
2032         gelocation -> geolocation.
2033
2034         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2035         (testGeolocationManagerWatchPosition):
2036
2037 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2038
2039         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2040         https://bugs.webkit.org/show_bug.cgi?id=196213
2041
2042         Reviewed by Geoff Garen.
2043
2044         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2045         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2046         (credentialWithIdentityAndKeychainPath):
2047         (-[ChallengeDelegate webView:didFinishNavigation:]):
2048         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2049         (TestWebKitAPI::TEST):
2050
2051 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2052
2053         Expected shouldn't assume its contained types are copyable
2054         https://bugs.webkit.org/show_bug.cgi?id=195986
2055
2056         Reviewed by JF Bastien.
2057
2058         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2059         (TestWebKitAPI::NonCopyable::operator== const):
2060         (TestWebKitAPI::NonCopyable::operator!= const):
2061         (TestWebKitAPI::TEST):
2062
2063 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2064
2065         Remove some now-unnecessary dynamic class lookup
2066         https://bugs.webkit.org/show_bug.cgi?id=196237
2067
2068         Reviewed by Simon Fraser.
2069
2070         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2071         (makeRequest):
2072         (TEST):
2073
2074 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2075
2076         Unreviewed, rolling out r243450.
2077
2078         AppleWin and WinCairo port builds get broken.
2079
2080         Reverted changeset:
2081
2082         "Add test for fix of #196095"
2083         https://bugs.webkit.org/show_bug.cgi?id=196097
2084         https://trac.webkit.org/changeset/243450
2085
2086 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2087
2088         Unreviewed, rolling out r243465.
2089         https://bugs.webkit.org/show_bug.cgi?id=196226
2090
2091         the test doesn't build (Requested by thorton on #webkit).
2092
2093         Reverted changeset:
2094
2095         "Do not terminate the NetworkProcess if a third party
2096         application sends a NSCredential with a SecIdentityRef"
2097         https://bugs.webkit.org/show_bug.cgi?id=196213
2098         https://trac.webkit.org/changeset/243465
2099
2100 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2101
2102         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2103         https://bugs.webkit.org/show_bug.cgi?id=196213
2104
2105         Reviewed by Geoff Garen.
2106
2107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2108         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2109         (credentialWithIdentityAndKeychainPath):
2110         (-[ChallengeDelegate webView:didFinishNavigation:]):
2111         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2112         (TestWebKitAPI::TEST):
2113
2114 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2115
2116         [ews-build] Gracefully handle missing patch_id in events
2117         https://bugs.webkit.org/show_bug.cgi?id=196216
2118
2119         Reviewed by Lucas Forschler.
2120
2121         * BuildSlaveSupport/ews-build/events.py:
2122
2123 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2124
2125         [ews-build] use lz4 compression for improving buildbot performance
2126         https://bugs.webkit.org/show_bug.cgi?id=196155
2127
2128         Reviewed by Lucas Forschler.
2129
2130         * BuildSlaveSupport/ews-build/master.cfg:
2131
2132 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2133
2134         Pull some API testing helper methods out of TestWKWebView
2135         https://bugs.webkit.org/show_bug.cgi?id=196212
2136
2137         Reviewed by Tim Horton.
2138
2139         Refactor some more API testing utility methods, so that they can be used in
2140         tests that do not use TestWKWebView.
2141
2142         * TestWebKitAPI/cocoa/TestWKWebView.h:
2143         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2144         (-[WKWebView loadTestPageNamed:]):
2145         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2146         (-[WKWebView synchronouslyLoadHTMLString:]):
2147         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2148         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2149         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2150         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2151         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2152
2153 2019-03-25  Jer Noble  <jer.noble@apple.com>
2154
2155         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2156         https://bugs.webkit.org/show_bug.cgi?id=196097
2157
2158         Reviewed by Eric Carlson.
2159
2160         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2161
2162         * DumpRenderTree/mac/DumpRenderTree.mm:
2163         (resetWebPreferencesToConsistentValues):
2164         * WebKitTestRunner/TestController.cpp:
2165         (WTR::TestController::resetPreferencesToConsistentValues):
2166
2167 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2168
2169         Pull IPadUserInterfaceSwizzler out into a separate header file
2170         https://bugs.webkit.org/show_bug.cgi?id=196193
2171
2172         Reviewed by Anders Carlsson.
2173
2174         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2175         be used in other API tests.
2176
2177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2178         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2179         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2180         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2181         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2182         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2183         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2184
2185 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2186
2187         Remove NavigatorContentUtils in WebCore/Modules
2188         https://bugs.webkit.org/show_bug.cgi?id=196070
2189
2190         Reviewed by Alex Christensen.
2191
2192         NavigatorContentUtils was to support the custom scheme spec [1].
2193         However, in WebKit side, no port has supported the feature in
2194         WebKit layer after EFL port was removed. So there has been the
2195         only IDL implementation of the NavigatorContentUtils in WebCore.
2196         So we don't need to keep the implementation in WebCore anymore.
2197
2198         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2199
2200         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2201
2202 2019-03-24  Andy Estes  <aestes@apple.com>
2203
2204         [watchOS] Remove unused Proximity Networking code
2205         https://bugs.webkit.org/show_bug.cgi?id=196188
2206
2207         Reviewed by Tim Horton.
2208
2209         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2210         (TEST):
2211
2212 2019-03-23  Keith Miller  <keith_miller@apple.com>
2213
2214         Refactor clz/ctz and fix getLSBSet.
2215         https://bugs.webkit.org/show_bug.cgi?id=196162
2216
2217         Reviewed by Saam Barati.
2218
2219         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2220
2221         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2222         (TestWebKitAPI::TEST):
2223
2224 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2225
2226         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2227         https://bugs.webkit.org/show_bug.cgi?id=196143
2228
2229         Reviewed by Michael Catanzaro.
2230
2231         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2232         directories.
2233
2234         * Scripts/webkitpy/style/checkers/cpp.py:
2235         (check_identifier_name_in_declaration):
2236         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2237         (WebKitStyleTest.test_names):
2238
2239 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2240
2241         [Flatpak] Manifest expanding fails for qt WPE extension
2242         https://bugs.webkit.org/show_bug.cgi?id=196148
2243
2244         Reviewed by Alex Christensen.
2245
2246         * flatpak/flatpakutils.py:
2247         (expand_submodules_recurse): The last recurse manifest expand
2248         iteration might lead to a single module so take it into account
2249         and don't try to recurse further.
2250
2251 2019-03-22  Chris Dumez  <cdumez@apple.com>
2252
2253         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2254         https://bugs.webkit.org/show_bug.cgi?id=195348
2255         <rdar://problem/48622090>
2256
2257         Reviewed by Alex Christensen.
2258
2259         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2260         to NO when test.options().shouldIgnoreMetaViewport is false.
2261
2262         * WebKitTestRunner/ios/TestControllerIOS.mm:
2263         (WTR::TestController::platformConfigureViewForTest):
2264
2265 2019-03-22  Chris Dumez  <cdumez@apple.com>
2266
2267         Prewarmed processes should be usable with any website data store
2268         https://bugs.webkit.org/show_bug.cgi?id=196104
2269
2270         Reviewed by Alex Christensen.
2271
2272         Add API test coverage.
2273
2274         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2275         (runInitialWarmedProcessUsedTest):
2276         (TEST):
2277
2278 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2279
2280         Back out local changes to Alex's Subversion working directory
2281
2282         They were accidentally committed.
2283
2284         * Scripts/webkitpy/common/system/abstractexecutive.py:
2285         (AbstractExecutive.wait_newest):
2286         * Scripts/webkitpy/common/system/executive.py:
2287         (Executive.running_pids):
2288         * Scripts/webkitpy/common/system/executive_mock.py:
2289         (MockExecutive.running_pids):
2290         * Scripts/webkitpy/common/system/executive_unittest.py:
2291         (ExecutiveTest.serial_test_running_pids):
2292         * Scripts/webkitpy/port/darwin.py:
2293         (DarwinPort.check_for_leaks):
2294         * Scripts/webkitpy/port/leakdetector.py:
2295         (LeakDetector.check_for_leaks):
2296         - This was the hack attached to Bug 193772.
2297
2298         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2299         (+[WebKitTestRunnerEvent mouseLocation]):
2300         - This works around a crash on an internal build.
2301
2302 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2303
2304         Fix the build after r243354
2305         https://bugs.webkit.org/show_bug.cgi?id=196138
2306         <rdar://problem/49145951>
2307
2308         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2309         (TEST):
2310         * TestWebKitAPI/ios/UIKitSPI.h:
2311
2312 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2313
2314         Adopt UIWKDocumentContext
2315         https://bugs.webkit.org/show_bug.cgi?id=196040
2316         <rdar://problem/48642440>
2317
2318         Reviewed by Ryosuke Niwa.
2319
2320         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2321         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2322         (makeRequest):
2323         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2324         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2325         (applyStyle):
2326         (TEST):
2327         Add tests for UIWKDocumentContext.
2328
2329         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2330         (TEST):
2331         (recursiveFindWKContentView): Deleted.
2332         * TestWebKitAPI/cocoa/TestWKWebView.h:
2333         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2334         (recursiveFindWKContentView):
2335         (-[TestWKWebView wkContentView]):
2336         * TestWebKitAPI/ios/UIKitSPI.h:
2337         Share the WKContentView finding code between tests.
2338
2339 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2340
2341         [iOS WK2] Turn on async overflow scrolling by default
2342         https://bugs.webkit.org/show_bug.cgi?id=196011
2343         rdar://problem/48453859
2344
2345         Reviewed by Antti Koivisto.
2346         
2347         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2348         since so many basic layout tests have different results when compositing is triggered for
2349         overflow.
2350         
2351         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2352
2353         * WebKitTestRunner/TestController.cpp:
2354         (WTR::TestController::resetPreferencesToConsistentValues):
2355
2356 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2357
2358         [ews-build] Retry API test in case of failures
2359         https://bugs.webkit.org/show_bug.cgi?id=196004
2360
2361         Reviewed by Lucas Forschler.
2362
2363         * BuildSlaveSupport/ews-build/steps.py:
2364         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2365         (CompileWebKitToT.doStepIf): Ditto.
2366         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2367         (ReRunAPITests): Re-run API tests.
2368         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2369         (RunAPITestsWithoutPatch): Run API tests without patch.
2370         (RunAPITestsWithoutPatch.doStepIf):
2371         (RunAPITestsWithoutPatch.hideStepIf):
2372         (RunAPITestsWithoutPatch.evaluateCommand):
2373         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2374         (AnalyzeAPITestsResults.start):
2375         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2376         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2377         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2378         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2379
2380 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2381
2382         [ews-build] Update queues configurations
2383         https://bugs.webkit.org/show_bug.cgi?id=196074
2384
2385         Reviewed by Dewei Zhu.
2386
2387         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2388         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2389
2390 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2391
2392         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2393         https://bugs.webkit.org/show_bug.cgi?id=195680
2394         <rdar://problem/48903534>
2395
2396         Unreviewed infrastructure fix.
2397
2398         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2399         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2400
2401 2019-03-21  Andy Estes  <aestes@apple.com>
2402
2403         [iOS] Apple Pay should be available in documents with no user agent scripts
2404         https://bugs.webkit.org/show_bug.cgi?id=196061
2405         <rdar://problem/48649391>
2406
2407         Reviewed by Brady Eidson.
2408
2409         Added API tests and related infrastructure.
2410
2411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2412         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2413         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2414         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2415         (TestWebKitAPI::TEST):
2416         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2417         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2418         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2419         * TestWebKitAPI/cocoa/TestProtocol.mm:
2420         (-[TestProtocol startLoading]):
2421         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2422         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2423         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2424         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2425
2426 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2427
2428         REGRESSSION (r243297): webkitpy tests broken
2429         https://bugs.webkit.org/show_bug.cgi?id=196108
2430
2431         Reviewed by Aakash Jain.
2432
2433         r243297 updated contributors.json, which broke a few unit tests.
2434
2435         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2436         (IRCCommandTest.test_whois):
2437         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2438
2439 2019-03-21  Chris Dumez  <cdumez@apple.com>
2440
2441         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2442         https://bugs.webkit.org/show_bug.cgi?id=196041
2443         <rdar://problem/49083230>
2444
2445         Reviewed by Alex Christensen.
2446
2447         Add API test coverage.
2448
2449         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2450         (TEST):
2451
2452 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2453
2454         Add SPI to inform applications of WKContentRuleList actions
2455         https://bugs.webkit.org/show_bug.cgi?id=195965
2456         <rdar://problem/42664365>
2457
2458         Reviewed by Geoff Garen.
2459
2460         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2461         (TestWebKitAPI::allActionsForResourceLoad):
2462         (TestWebKitAPI::testRequest):
2463         (TestWebKitAPI::TEST_F):
2464         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2465         (Notification::description):
2466         (Notification::operator== const):
2467         (toVector):
2468         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2469         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2470         (makeContentRuleList):
2471         (TEST):
2472         (makeWarnContentRuleList): Deleted.
2473
2474 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2475
2476         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2477         https://bugs.webkit.org/show_bug.cgi?id=196088
2478
2479         Reviewed by Brian Burg.
2480
2481         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2482         Support checks when only one platform is specified. Also deprecate macosx() and
2483         force the use of macos() instead.
2484
2485         * Scripts/webkitpy/style/checkers/cpp.py:
2486         (check_min_versions_of_wk_api_available):
2487         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2488         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2489
2490 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2491
2492         Update status inactive committers' status to 'contributor'.
2493
2494         * Scripts/webkitpy/common/config/contributors.json:
2495
2496 2019-03-21  Xan Lopez  <xan@igalia.com>
2497
2498         [JSC][x86] Drop support for x87 floating point
2499         https://bugs.webkit.org/show_bug.cgi?id=194853
2500
2501         Reviewed by Don Olmstead.
2502
2503         Force SSE2 on x86/32bit builds.
2504
2505         * Scripts/webkitdirs.pm:
2506         (generateBuildSystemFromCMakeProject):
2507
2508 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2509
2510         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2511         https://bugs.webkit.org/show_bug.cgi?id=196073
2512
2513         Reviewed by Michael Catanzaro.
2514
2515         Add test cases to check functions and constructors with no arguments but receiving user data.
2516
2517         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2518         (checkUserData):
2519         (testJSCFunction):
2520         (fooCreateWithUserData):
2521         (testJSCClass):
2522
2523 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2524
2525         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2526
2527         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2528
2529         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2530
2531 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2532
2533         [GTK][WPE] Add API to provide geolocation information
2534         https://bugs.webkit.org/show_bug.cgi?id=195940
2535
2536         Reviewed by Michael Catanzaro.
2537
2538         Add a new test to check the new API.
2539
2540         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2541         (testGeolocationManagerCurrentPosition):
2542         (testGeolocationManagerWatchPosition):
2543         (beforeAll):
2544         (afterAll):
2545         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2546         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2547         (beforeAll): Ditto.
2548         * TestWebKitAPI/glib/CMakeLists.txt:
2549
2550 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2551
2552         [GLib] Returning G_TYPE_OBJECT from a method does not work
2553         https://bugs.webkit.org/show_bug.cgi?id=195574
2554
2555         Reviewed by Michael Catanzaro.
2556
2557         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2558
2559         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2560         (getGFile):
2561         (getParent):
2562         (createGString):
2563         (getGString):
2564         (getGStringCopyWillRaise):
2565         (getGStringCopy):
2566         (getGStringStr):
2567         (getGStringLen):
2568         (freeGString):
2569         (testJSCClass):
2570
2571 2019-03-20  Saam Barati  <sbarati@apple.com>
2572
2573         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2574         https://bugs.webkit.org/show_bug.cgi?id=195721
2575
2576         Reviewed by Filip Pizlo.
2577
2578         * Scripts/run-javascriptcore-tests:
2579
2580 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2581
2582         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2583         https://bugs.webkit.org/show_bug.cgi?id=196049
2584
2585         Reviewed by Tim Horton.
2586
2587         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2588         overflow scrolling in general, so rename it.
2589
2590         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2591
2592 2019-03-20  Daniel Bates  <dabates@apple.com>
2593
2594         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2595         https://bugs.webkit.org/show_bug.cgi?id=196031
2596         <rdar://problem/49078172>
2597
2598         Reviewed by Tim Horton.
2599
2600         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2601         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2602         same code path used when the Done button is pressed to dismiss the <select> picker.
2603
2604         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2605         (TestWebKitAPI::TEST):
2606
2607 2019-03-20  Chris Dumez  <cdumez@apple.com>
2608
2609         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2610         https://bugs.webkit.org/show_bug.cgi?id=196029
2611         <rdar://problem/48954651>
2612
2613         Reviewed by Tim Horton.
2614
2615         Add API test coverage.
2616
2617         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2618
2619 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2620
2621         [ews-build] Improve failure summary string for ApplyPatch step
2622         https://bugs.webkit.org/show_bug.cgi?id=195995
2623
2624         Reviewed by Alexey Proskuryakov.
2625
2626         * BuildSlaveSupport/ews-build/steps.py:
2627         (ApplyPatch.getResultSummary): Override getResultSummary.
2628
2629 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2630
2631         AX: Implement support for new meter ARIA role
2632         https://bugs.webkit.org/show_bug.cgi?id=195966
2633
2634         Reviewed by Chris Fleizach.
2635
2636         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2637         to AXLevelIndicator.
2638
2639         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2640
2641 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2642
2643         [WebAuthN] Implement FIDO AppID extension
2644         https://bugs.webkit.org/show_bug.cgi?id=143491
2645         <rdar://problem/48298273>
2646
2647         Reviewed by Brent Fulgham.
2648
2649         Add a test that covers the new flag of convertToU2fSignCommand.
2650
2651         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2652         (TestWebKitAPI::TEST):
2653         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2654         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2655         (TestWebKitAPI::TEST):
2656
2657 2019-03-19  Keith Rollin  <krollin@apple.com>
2658
2659         Add support for more platforms to generate-xcfilelists
2660         https://bugs.webkit.org/show_bug.cgi?id=195977
2661
2662         Reviewed by Alexey Proskuryakov.
2663
2664         generate-xcfilelists incorrectly complains when involved with building
2665         WebKit for iphonesimulator:
2666
2667             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2668             …
2669             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2670
2671         Address this by teaching generate-xcfilelists about more platforms.
2672
2673         * Scripts/generate-xcfilelists:
2674
2675 2019-03-19  John Wilander  <wilander@apple.com>
2676
2677         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2678         https://bugs.webkit.org/show_bug.cgi?id=195923
2679         <rdar://problem/49001272>
2680
2681         Reviewed by Alex Christensen.
2682
2683         This patch does the following to the TestRunner:
2684         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2685         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2686         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2687
2688         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2689         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2690         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2691         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2692         * WebKitTestRunner/TestController.cpp:
2693         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2694         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2695         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2696         * WebKitTestRunner/TestController.h:
2697         * WebKitTestRunner/TestInvocation.cpp:
2698         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2699
2700 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2701
2702         [CMake] Support more clang and gcc sanitizers
2703         https://bugs.webkit.org/show_bug.cgi?id=195956
2704
2705         Reviewed by Michael Catanzaro.
2706
2707         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2708
2709 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2710
2711         [ews-build] Improve summary for PrintConfiguration step
2712         https://bugs.webkit.org/show_bug.cgi?id=195945
2713
2714         Reviewed by Lucas Forschler.
2715
2716         * BuildSlaveSupport/ews-build/steps.py:
2717         (PrintConfiguration.getResultSummary): Override getResultSummary.
2718
2719 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2720
2721         [ews-build] Improve summary for CheckOutSource step
2722         https://bugs.webkit.org/show_bug.cgi?id=195963
2723
2724         Reviewed by Lucas Forschler.
2725
2726         * BuildSlaveSupport/ews-build/steps.py:
2727         (CheckOutSource.getResultSummary):
2728
2729 2019-03-19  Daniel Bates  <dabates@apple.com>
2730
2731         [iOS] Focus not preserved when switching between tabs
2732         https://bugs.webkit.org/show_bug.cgi?id=195820
2733         <rdar://problem/43614450>
2734
2735         Reviewed by Brent Fulgham.
2736
2737         Add tests to ensure that we restore focus when resigning and becoming first responder.
2738
2739         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2740         (TestWebKitAPI::TEST):
2741
2742 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2743
2744         Make WTFLogChannelState and WTFLogLevel enum classes
2745         https://bugs.webkit.org/show_bug.cgi?id=195904
2746
2747         Reviewed by Eric Carlson.
2748
2749         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2750         (TestWebKitAPI::TEST_F):
2751
2752 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2753
2754         [GStreamer][EME] Backported mssdemux protection data crash fix
2755         https://bugs.webkit.org/show_bug.cgi?id=195918
2756
2757         Reviewed by Philippe Normand.
2758
2759         * gstreamer/jhbuild.modules:
2760         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2761
2762 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2763
2764         Unreviewed, rolling out r243132.
2765
2766         Broke GTK build
2767
2768         Reverted changeset:
2769
2770         "Make WTFLogChannelState and WTFLogLevel enum classes"
2771         https://bugs.webkit.org/show_bug.cgi?id=195904
2772         https://trac.webkit.org/changeset/243132
2773
2774 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2775
2776         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2777
2778         * Scripts/webkitdirs.pm:
2779         (builtDylibPathForName): Adjust the shared library name that's changed
2780         with the API version bump in r243073.
2781
2782 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2783
2784         Make WTFLogChannelState and WTFLogLevel enum classes
2785         https://bugs.webkit.org/show_bug.cgi?id=195904
2786
2787         Reviewed by Eric Carlson.
2788
2789         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2790         (TestWebKitAPI::TEST_F):
2791
2792 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2793
2794         Disable flaky test added in r2431100
2795         https://webkit.org/b/195785
2796
2797         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2798         (TestWebKitAPI::TEST):
2799         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2800
2801 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2802
2803         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2804         https://bugs.webkit.org/show_bug.cgi?id=195916
2805
2806         Reviewed by Tim Horton.
2807
2808         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2809         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2810
2811 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2812
2813         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2814
2815         * Scripts/webkitpy/common/config/contributors.json:
2816
2817 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2818
2819         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2820         https://bugs.webkit.org/show_bug.cgi?id=195785
2821
2822         Reviewed by Geoffrey Garen.
2823
2824         * TestWebKitAPI/TCPServer.cpp: Added.
2825         (TestWebKitAPI::TCPServer::TCPServer):
2826         (TestWebKitAPI::TCPServer::~TCPServer):
2827         (TestWebKitAPI::TCPServer::socketBindListen):
2828         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2829         * TestWebKitAPI/TCPServer.h: Added.
2830         (TestWebKitAPI::TCPServer::port const):
2831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2832         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2833         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2834         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2835         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2836         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2837         (TestWebKitAPI::respondSlowly):
2838         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2839         (TestWebKitAPI::downloadAtRate):
2840         (TestWebKitAPI::TEST):
2841
2842 2019-03-18  Saam Barati  <sbarati@apple.com>
2843
2844         Add a plan file for JetStream 2
2845         https://bugs.webkit.org/show_bug.cgi?id=190734
2846
2847         Reviewed by Mark Lam.
2848
2849         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2850
2851 2019-03-18  Chris Dumez  <cdumez@apple.com>
2852
2853         Delay WebProcess launch until a load is triggered in a Web view
2854         https://bugs.webkit.org/show_bug.cgi?id=195758
2855         <rdar://problem/48126013>
2856
2857         Reviewed by Geoff Garen.
2858
2859         Add API test coverage. Also update some existing API tests to not expect
2860         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2861
2862         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2863         (TestWebKitAPI::TEST):
2864         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2865         (TestWebKitAPI::TEST):
2866         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2867         (TEST):
2868         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2869         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2870         (TEST):
2871         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2872         (TEST):
2873         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2874
2875 2019-03-18  Xan Lopez  <xan@igalia.com>
2876
2877         [CMake] Prevent potential warning when determining $architecture
2878         https://bugs.webkit.org/show_bug.cgi?id=195891
2879
2880         Reviewed by Michael Catanzaro.
2881
2882         It's possible for generateBuildSystemForCMakeProject to be called
2883         before determineArchitecture() is ever called. This will make the
2884         first eq check with $architecture to be bogus (and print a
2885         warning). Change that to an eq check with architecture(), which
2886         implicitly calls determineArchitecture() if needed, and change all
2887         the other similar cases in the method in the same way to prevent
2888         future bugs like this one.
2889
2890         * Scripts/webkitdirs.pm:
2891         (generateBuildSystemFromCMakeProject):
2892
2893 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2894
2895         [WPE] Tarballs generated with “make dist” cannot build documentation
2896         https://bugs.webkit.org/show_bug.cgi?id=195885
2897
2898         Reviewed by Carlos Garcia Campos.
2899
2900         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2901
2902 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2903
2904         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2905         https://bugs.webkit.org/show_bug.cgi?id=195883
2906
2907         Reviewed by Carlos Garcia Campos.
2908
2909         * gtkdoc/gtkdoc.py:
2910         (GTKDoc._run_command): When commands fail to run, include the full command line for
2911         the program invocation and the output it has generated on the standard error stream.
2912
2913 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2914
2915         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2916         https://bugs.webkit.org/show_bug.cgi?id=195786
2917
2918         Reviewed by Philippe Normand.
2919
2920         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2921         * wpe/jhbuild.modules: Ditto.
2922
2923 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2924
2925         [ews-build] Don't run clean builds on EWS builders
2926         https://bugs.webkit.org/show_bug.cgi?id=195851
2927
2928         Reviewed by Geoffrey Garen.
2929
2930         * BuildSlaveSupport/ews-build/factories.py:
2931
2932 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2933
2934         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2935         https://bugs.webkit.org/show_bug.cgi?id=195849
2936
2937         Reviewed by Chris Dumez.
2938
2939         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2940
2941         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2942         (runWebsiteDataStoreCustomPaths):
2943
2944 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2945
2946         webkitpy: Upload test results
2947         https://bugs.webkit.org/show_bug.cgi?id=195755
2948         <rdar://problem/48896182>
2949
2950         Reviewed by Aakash Jain.
2951
2952         Establish a new format for uploading results that is not tied to layout tests, apply
2953         that format to webkitpy tests.
2954
2955         * Scripts/webkitpy/common/checkout/scm/git.py:
2956         (Git.native_branch): Return what branch the current checkout is on.
2957         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2958         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2959         * Scripts/webkitpy/common/checkout/scm/svn.py:
2960         (SVN.native_branch): Ditto.
2961         * Scripts/webkitpy/common/system/platforminfo.py:
2962         (PlatformInfo.build_version): Return a build version for Mac.
2963         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2964         (MockPlatformInfo.__init__):
2965         (MockPlatformInfo.build_version):
2966         * Scripts/webkitpy/results: Added.
2967         * Scripts/webkitpy/results/__init__.py: Added.
2968         * Scripts/webkitpy/results/options.py: Added.
2969         (upload_options): OptParse list for upload options.
2970         * Scripts/webkitpy/results/upload.py: Added.
2971         (Upload): Class which enforces the upload format expected by the results server.
2972         (Upload.Expectations):
2973         (Upload.create_configuration):
2974         (Upload.create_commit):
2975         (Upload.create_details):
2976         (Upload.create_run_stats):
2977         (Upload.create_test_result):
2978         (Upload.__init__):
2979         (Upload.Encoder): Encode Upload object as json.
2980         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2981         * Scripts/webkitpy/results/upload_unittest.py: Added.
2982         * Scripts/webkitpy/test/main.py:
2983         (Tester._parse_args): Add upload arguments.
2984         (Tester._run_tests): Allow results to be uploaded.
2985         * Scripts/webkitpy/test/runner.py:
2986         (Runner.__init__): Record which tests were run, rather than just counting them.
2987         (Runner.handle):
2988         * Scripts/webkitpy/test/runner_unittest.py:
2989         (RunnerTest.test_run):
2990         * Scripts/webkitpy/thirdparty/__init__.py:
2991         (AutoinstallImportHook.find_module): Add requests auto-install.
2992         (AutoinstallImportHook._install_requests):
2993         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2994         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2995
2996 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2997
2998         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2999         https://bugs.webkit.org/show_bug.cgi?id=195810
3000
3001         Reviewed by Tim Horton.
3002
3003         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3004         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3005         ending certain layout tests.
3006
3007         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3008         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3009         (-[TestRunnerWKWebView dealloc]):
3010         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3011
3012         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3013         helper method when destroying the web view, and when resetting state between tests.
3014
3015         * WebKitTestRunner/ios/TestControllerIOS.mm:
3016         (WTR::TestController::platformResetStateToConsistentValues):
3017
3018         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3019
3020 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3021
3022         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3023         https://bugs.webkit.org/show_bug.cgi?id=190350
3024         <rdar://problem/45089503>
3025
3026         Reviewed by Geoffrey Garen.
3027
3028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3029         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3030         (TEST):
3031         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3032         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3033         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3034         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3035         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3036         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3037         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3038         (runTest):
3039         (createDirectories):
3040         (TEST):
3041         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3042         (TEST):
3043         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3044         (TEST):
3045
3046 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3047
3048         Add support to WebPage for getting the contents as an attributed string.
3049         https://bugs.webkit.org/show_bug.cgi?id=195636
3050         rdar://problem/45055697
3051
3052         Reviewed by Tim Horton.
3053
3054         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3055         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3056
3057 2019-03-15  Chris Dumez  <cdumez@apple.com>
3058
3059         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3060         https://bugs.webkit.org/show_bug.cgi?id=195747
3061
3062         Reviewed by Geoff Garen.
3063
3064         Add API test coverage.
3065
3066         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3067
3068 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3069
3070         Unreviewed, rolling out r242952.
3071
3072         Causing API failures on iOS Simulator
3073
3074         Reverted changeset:
3075
3076         "[PSON] Make sure the WebProcessCache is leverage when
3077         relaunching a process after termination"
3078         https://bugs.webkit.org/show_bug.cgi?id=195747
3079         https://trac.webkit.org/changeset/242952
3080
3081 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3082
3083         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3084         https://bugs.webkit.org/show_bug.cgi?id=195740
3085
3086         Reviewed by Ross Kirsling.
3087
3088         window.open doesn't work for WebKitBrowserWindow because it is not
3089         implemented yet.
3090
3091         1. Implemented createNewPage callback of WKPageUIClient.
3092         2. Changed MainWindow to take a BrowserWindow factory function
3093           instead of BrowserWindowType to be flexible to create
3094           BrowserWindow with extra settings.
3095         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3096           because it is not relevant with MainWindow anymore.
3097
3098         * MiniBrowser/win/Common.cpp:
3099         (parseCommandLine):
3100         * MiniBrowser/win/Common.h:
3101         (CommandLineOptions::CommandLineOptions):
3102         * MiniBrowser/win/MainWindow.cpp:
3103         (MainWindow::MainWindow):
3104         (MainWindow::create):
3105         (MainWindow::init):
3106         (MainWindow::WndProc):
3107         * MiniBrowser/win/MainWindow.h:
3108         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3109         (PrintWebUIDelegate::createWebViewWithRequest):
3110         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3111         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3112         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3113         (WebKitBrowserWindow::updateProxySettings):
3114         (WebKitBrowserWindow::createNewPage):
3115         * MiniBrowser/win/WebKitBrowserWindow.h:
3116         * MiniBrowser/win/WinMain.cpp:
3117         (wWinMain):
3118
3119 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3120
3121         Make it possible to test scrolling tree layer manipulation more easily
3122         https://bugs.webkit.org/show_bug.cgi?id=195780
3123
3124         Reviewed by Tim Horton.
3125         
3126         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3127         cuts off communication of scrolling tree scrolls back to the web process
3128         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3129         allows tests to trigger scrolls which run the scrolling tree layer positioning
3130         logic, but never get another commit from the web process that might mask
3131         scrolling tree bugs.
3132         
3133         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3134         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3135         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3136
3137         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3138         (WTR::UIScriptController::scrollUpdatesDisabled const):
3139         (WTR::UIScriptController::setScrollUpdatesDisabled):
3140         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3141         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3142         (WTR::UIScriptController::scrollUpdatesDisabled const):
3143         (WTR::UIScriptController::setScrollUpdatesDisabled):
3144         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3145         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3146         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3147         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3148         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3149         * WebKitTestRunner/ios/TestControllerIOS.mm:
3150         (WTR::TestController::platformResetStateToConsistentValues):
3151         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3152         (WTR::UIScriptController::scrollUpdatesDisabled const):
3153         (WTR::UIScriptController::setScrollUpdatesDisabled):
3154
3155 2019-03-14  Youenn Fablet  <youenn@apple.com>
3156
3157         Move IDB storage in private browsing mode to NetworkProcess
3158         https://bugs.webkit.org/show_bug.cgi?id=195602
3159
3160         Reviewed by Brady Eidson.
3161
3162         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3163         (TEST):
3164
3165 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3166
3167         [ews-build] Make descriptionDone messages more readable
3168         https://bugs.webkit.org/show_bug.cgi?id=195760
3169
3170         Reviewed by Lucas Forschler.
3171
3172         * BuildSlaveSupport/ews-build/steps.py:
3173         * BuildSlaveSupport/ews-build/steps_unittest.py:
3174
3175 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3176
3177         [ews-build] Generate status-bubble hover-over messages
3178         https://bugs.webkit.org/show_bug.cgi?id=195680
3179
3180         Reviewed by Lucas Forschler.
3181
3182         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3183         (StatusBubble):
3184         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3185         on hover-over.
3186         (StatusBubble._iso_time):
3187         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3188         hover-over message.
3189         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3190
3191 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3192
3193         [ews-app] Gracefully handle the case when state_string is None
3194         https://bugs.webkit.org/show_bug.cgi?id=195753
3195
3196         Reviewed by Lucas Forschler.
3197
3198         * BuildSlaveSupport/ews-app/ews/models/build.py:
3199         * BuildSlaveSupport/ews-app/ews/models/step.py:
3200
3201 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3202
3203         [ews-app] Status bubble display pending for currently running build step
3204         https://bugs.webkit.org/show_bug.cgi?id=195744
3205
3206         Reviewed by Lucas Forschler.
3207
3208         * BuildSlaveSupport/ews-build/events.py:
3209         (Events.stepStarted): If state_string is pending, replace it with step name.
3210
3211 2019-03-14  Chris Dumez  <cdumez@apple.com>
3212
3213         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3214         https://bugs.webkit.org/show_bug.cgi?id=195750
3215
3216         Reviewed by Geoffrey Garen.
3217
3218         Add API test coverage.
3219
3220         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3221         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3222         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3223         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3224
3225 2019-03-14  Chris Dumez  <cdumez@apple.com>
3226
3227         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3228         https://bugs.webkit.org/show_bug.cgi?id=195747
3229
3230         Reviewed by Geoff Garen.
3231
3232         Add API test coverage.
3233
3234         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3235
3236 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3237
3238         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3239         https://bugs.webkit.org/show_bug.cgi?id=195725
3240         <rdar://problem/48545062>
3241
3242         Reviewed by Tim Horton.
3243
3244         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3245         handler is nil.
3246
3247         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3248         (TestWebKitAPI::TEST):
3249
3250 2019-03-13  Sam Weinig  <sam@webkit.org>
3251
3252         Add utility function to allow easy reverse range-based iteration of a container
3253         https://bugs.webkit.org/show_bug.cgi?id=195542
3254
3255         Reviewed by Antti Koivisto.
3256
3257         * TestWebKitAPI/CMakeLists.txt:
3258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3259         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3260         (TestWebKitAPI::TEST):
3261         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3262
3263 2019-03-13  Chris Dumez  <cdumez@apple.com>
3264
3265         Use a ServiceWorker process per registrable domain
3266         https://bugs.webkit.org/show_bug.cgi?id=195649
3267
3268         Reviewed by Youenn Fablet.
3269
3270         Update API test coverage.
3271
3272         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3273
3274 2019-03-13  Chris Dumez  <cdumez@apple.com>
3275
3276         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3277         https://bugs.webkit.org/show_bug.cgi?id=195684
3278         <rdar://problem/48294714>
3279
3280         Reviewed by Antti Koivisto.
3281
3282         Add API test coverage.
3283
3284         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3285
3286 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3287
3288         [ews-app] Remove unused patch view
3289         https://bugs.webkit.org/show_bug.cgi?id=195669
3290
3291         Reviewed by Lucas Forschler.
3292
3293         * BuildSlaveSupport/ews-app/ews/urls.py:
3294         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3295
3296 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3297
3298         [ews-app] Use Buildbot result code variables
3299         https://bugs.webkit.org/show_bug.cgi?id=195668
3300
3301         Reviewed by Alexey Proskuryakov.
3302
3303         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3304         (Buildbot): Added Buildbot result code variables.
3305         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3306         (StatusBubble._build_bubble): Used Buildbot result code variables.
3307
3308 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3309
3310         [Flatpak] Expand submodule recursively
3311         https://bugs.webkit.org/show_bug.cgi?id=195672
3312
3313         Building WPE with flatpak was impossible without that as it was raising an exception.
3314         Also update wpebackend-fdo to match what is built in jhbuild
3315
3316         Reviewed by Philippe Normand.
3317
3318         * flatpak/flatpakutils.py:
3319         (expand_submodules_recurse):
3320         (expand_manifest):
3321         * flatpak/org.webkit.WPEModules.yaml:
3322
3323 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3324
3325         [ews-app] status bubble should be hidden for certain builds
3326         https://bugs.webkit.org/show_bug.cgi?id=194597
3327
3328         Reviewed by Dewei Zhu.
3329
3330         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3331         (StatusBubble._build_bubble):
3332         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3333         because the patch didn't have relevant changes.
3334         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3335         in production yet.
3336
3337 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3338
3339         [Win] Fix a slew of simple clang-cl warnings.
3340         https://bugs.webkit.org/show_bug.cgi?id=195652
3341
3342         Reviewed by Don Olmstead.
3343
3344         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3345         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3346
3347 2019-03-12  Justin Fan  <justin_fan@apple.com>
3348
3349         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3350         https://bugs.webkit.org/show_bug.cgi?id=195518
3351         <rdar://problem/46322356>
3352
3353         Reviewed by Myles C. Maxfield.
3354
3355         * DumpRenderTree/DerivedSources-input.xcfilelist:
3356         * DumpRenderTree/DerivedSources-output.xcfilelist:
3357
3358 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3359
3360         Unreviewed, rolling out r242825.
3361         https://bugs.webkit.org/show_bug.cgi?id=195648
3362
3363         "Broke webkitpy tests with my change to
3364         lldb_dump_class_layout.py" (Requested by rmorisset on
3365         #webkit).
3366
3367         Reverted changeset:
3368
3369         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3370         classes with suspicious padding"
3371         https://bugs.webkit.org/show_bug.cgi?id=195573
3372         https://trac.webkit.org/changeset/242825
3373
3374 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3375
3376         [ews-build] Show status bubbles while the patch is waiting in queue
3377         https://bugs.webkit.org/show_bug.cgi?id=195618
3378
3379         Reviewed by Lucas Forschler.
3380
3381         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3382         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3383         enabled in initial deployment.
3384         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3385         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3386         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3387         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3388         (StatusBubble._build_bubbles_for_patch):
3389
3390 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3391
3392         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3393         https://bugs.webkit.org/show_bug.cgi?id=195573
3394
3395         Reviewed by Simon Fraser.
3396
3397         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3398
3399         * Scripts/dump-class-layout:
3400         (main):
3401         * lldb/lldb_dump_class_layout.py:
3402         (ClassLayout.__init__):
3403         (ClassLayout._compute_padding_recursive):
3404         (LLDBDebuggerInstance.dump_layout_for_classname):
3405         (LLDBDebuggerInstance):
3406         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3407         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3408
3409 2019-03-12  Chris Dumez  <cdumez@apple.com>
3410
3411         Device Orientation access permission should be denied unless explicitly granted by the client
3412         https://bugs.webkit.org/show_bug.cgi?id=195625
3413
3414         Reviewed by Youenn Fablet.
3415
3416         add API test coverage.
3417
3418         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3419         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3420         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3421         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3422         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3423         (runDeviceOrientationTest):
3424         (TEST):
3425         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3426         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3427
3428 2019-03-12  Jer Noble  <jer.noble@apple.com>
3429
3430         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3431         https://bugs.webkit.org/show_bug.cgi?id=195137
3432         <rdar://problem/48810307>
3433
3434         Reviewed by Eric Carlson.
3435
3436         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3437         (TestWebKitAPI::TEST):
3438
3439 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3440
3441         [ews-build] Change urls from uat to production
3442         https://bugs.webkit.org/show_bug.cgi?id=195566
3443
3444         Reviewed by Lucas Forschler.
3445
3446         * BuildSlaveSupport/ews-app/ews/config.py:
3447         * BuildSlaveSupport/ews-build/events.py:
3448         * BuildSlaveSupport/ews-build/steps.py:
3449
3450 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3451
3452         [ews-build] change max_builds for local-worker to 1
3453         https://bugs.webkit.org/show_bug.cgi?id=195568
3454
3455         Reviewed by Lucas Forschler.
3456
3457         * BuildSlaveSupport/ews-build/loadConfig.py:
3458
3459 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3460
3461         Fix the build
3462
3463         * TestRunnerShared/spi/PencilKitTestSPI.h:
3464         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3465
3466 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3467
3468         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3469         https://bugs.webkit.org/show_bug.cgi?id=194131
3470
3471         Reviewed by Michael Catanzaro.
3472
3473         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3474         (uriChanged):
3475         (testUnfinishedSubresourceLoad):
3476         (serverCallback):
3477         (beforeAll):
3478
3479 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3480
3481         WTF::Expected should use std::addressof instead of operator&
3482         https://bugs.webkit.org/show_bug.cgi?id=195604
3483
3484         Reviewed by Myles Maxfield.
3485
3486         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3487         (TestWebKitAPI::Unique::Unique):
3488         (TestWebKitAPI::Unique::operator&):
3489         (TestWebKitAPI::TEST):
3490
3491 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3492
3493         Add Optional to Forward.h.
3494         https://bugs.webkit.org/show_bug.cgi?id=195586
3495
3496         Reviewed by Darin Adler.
3497
3498         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3499         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3500         Remove unnecessary includes from headers.
3501
3502 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3503
3504         Add testing API to hit-test and scroll overflow scrollers
3505         https://bugs.webkit.org/show_bug.cgi?id=195278
3506
3507         Reviewed by Antti Koivisto.
3508         
3509         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3510         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3511         
3512         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3513
3514         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3515         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3516         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3517         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3518         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3519         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3520         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3521         (WTR::enclosingScrollViewIncludingSelf):
3522         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3523
3524 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3525
3526         API test WebKit.RequestTextInputContext fails on iOS
3527         https://bugs.webkit.org/show_bug.cgi?id=195585
3528
3529         Reviewed by Wenson Hsieh and Simon Fraser.
3530
3531         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3532         (applyStyle):
3533         (TEST):
3534         Add a viewport, so that the coordinates match up on iOS.
3535         Scroll by moving the UIScrollView's contentOffset.
3536
3537 2019-03-11  Chris Dumez  <cdumez@apple.com>
3538
3539         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3540         https://bugs.webkit.org/show_bug.cgi?id=195506
3541         <rdar://problem/48733477>
3542
3543         Reviewed by Alex Christensen.
3544
3545         Add API test coverage.
3546
3547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3548
3549 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3550
3551         Adding myself to contributors.json
3552
3553         Unreviewed, addming myself to contributors.json .
3554
3555         * Scripts/webkitpy/common/config/contributors.json:
3556
3557 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3558
3559         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3560         https://bugs.webkit.org/show_bug.cgi?id=195511
3561         <rdar://problem/44873269>
3562
3563         Reviewed by Darin Adler.
3564
3565         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3566         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3567         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3568         (TEST_F):
3569
3570 2019-03-11  Chris Dumez  <cdumez@apple.com>
3571
3572         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3573         https://bugs.webkit.org/show_bug.cgi?id=195561
3574
3575         Reviewed by Youenn Fablet.
3576
3577         Make sure the JS in the test requests for permission to receive device orientation events.
3578
3579         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3580
3581 2019-03-11  Youenn Fablet  <youenn@apple.com>
3582
3583         Allow storage quota increase by default in WTR
3584         https://bugs.webkit.org/show_bug.cgi?id=195541
3585
3586         Reviewed by Geoffrey Garen.
3587
3588         Allow storage quota increase by default in WTR.
3589         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3590         Use this for tests that explicitly need cache increase.
3591
3592         Instead of increasing quota by 2, make sure the next request is
3593         granted by adding all given parameters.
3594
3595         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3596         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3597         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3598         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3599         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3600         * WebKitTestRunner/TestController.cpp:
3601         (WTR::TestController::setAllowStorageQuotaIncrease):
3602         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3603         * WebKitTestRunner/TestController.h:
3604         * WebKitTestRunner/TestInvocation.cpp:
3605         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3606         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3607         (WTR::TestController::cocoaResetStateToConsistentValues):
3608         (WTR::TestController::setAllowStorageQuotaIncrease):
3609         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3610         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3611         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3612
3613 2019-03-11  Xan Lopez  <xan@igalia.com>
3614
3615         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3616         https://bugs.webkit.org/show_bug.cgi?id=194147
3617
3618         Reviewed by Michael Saboff.
3619
3620         To make --32-bit work correctly on Linux/64bit we need to:
3621
3622         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3623         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3624         unfortunately CMake only allows us to do this during
3625         crosscompilation, which is overkill here.
3626         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3627         pkg-config detection module uses the x86 .pc files instead of the
3628         x86_64 ones.
3629         - Set the -m32 flags for the compiler.
3630
3631         * Scripts/webkitdirs.pm:
3632         (generateBuildSystemFromCMakeProject):
3633
3634 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3635
3636         Add MotionMark-1.1 plan file for run-benchmark script.
3637         https://bugs.webkit.org/show_bug.cgi?id=195481
3638
3639         Rubber-stamped by Darin Adler.
3640
3641         Run-benchmark script should support MontionMark-1.1.
3642
3643         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3644
3645 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3646
3647         [ews-app] Add support for submit-to-ews url
3648         https://bugs.webkit.org/show_bug.cgi?id=195477
3649
3650         Reviewed by Lucas Forschler.
3651
3652         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3653         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3654         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3655         * BuildSlaveSupport/ews-app/ews/urls.py:
3656         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3657
3658 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3659
3660         Unreviewed, rolling out r242688, r242643, r242624.
3661
3662         Caused multiple layout test failures and crashes on iOS and macOS.
3663
3664         Reverted changeset:
3665
3666         "requestAnimationFrame should execute before the next frame"
3667         https://bugs.webkit.org/show_bug.cgi?id=177484
3668         https://trac.webkit.org/changeset/242624/webkit
3669
3670         * Tracing/SystemTracePoints.plist:
3671
3672 2019-03-11  John Wilander  <wilander@apple.com>
3673
3674         Resource Load Statistics: Make it possible exclude localhost from classification
3675         https://bugs.webkit.org/show_bug.cgi?id=195474
3676         <rdar://problem/47520577>
3677
3678         Reviewed by Brent Fulgham.
3679
3680         This patch allows for localhost to be excluded from classification and
3681         treatment as a prevalent resource.
3682
3683         The WebKit Tools change adds a new function called
3684         testRunner.setStatisticsIsRunningTest() which can be used to control this
3685         behavior.
3686
3687         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3688         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3689         (WTR::TestRunner::setStatisticsIsRunningTest):
3690         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3691         * WebKitTestRunner/TestController.cpp:
3692         (WTR::TestController::setStatisticsIsRunningTest):
3693         * WebKitTestRunner/TestController.h:
3694         * WebKitTestRunner/TestInvocation.cpp:
3695         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3696
3697 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3698
3699         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3700         https://bugs.webkit.org/show_bug.cgi?id=195560
3701
3702         Reviewed by Lucas Forschler.
3703
3704         * BuildSlaveSupport/ews-build/master.cfg:
3705
3706 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3707
3708         Unreviewed, rolling out r242698.
3709
3710         API test crashes on bots.
3711
3712         Reverted changeset:
3713
3714         "Add a WKContentRuleList variant that uses copied memory
3715         instead of mmap'd shared memory for class A containerized
3716         apps"
3717         https://bugs.webkit.org/show_bug.cgi?id=195511
3718         https://trac.webkit.org/changeset/242698
3719
3720 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3721
3722         [WPE] Enable web process sandbox
3723         https://bugs.webkit.org/show_bug.cgi?id=195169
3724
3725         Reviewed by Daniel Bates.
3726
3727         * wpe/install-dependencies:
3728         * wpe/jhbuild.modules:
3729
3730 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3731
3732         [ews-app] Use port 17000 for worker communication
3733         https://bugs.webkit.org/show_bug.cgi?id=195558
3734
3735         Reviewed by Lucas Forschler.
3736
3737         * BuildSlaveSupport/ews-build/master.cfg:
3738
3739 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3740
3741         [ews-build] unit-tests fail when passwords.json is missing
3742         https://bugs.webkit.org/show_bug.cgi?id=195557
3743
3744         Reviewed by Lucas Forschler.
3745
3746         * BuildSlaveSupport/ews-build/loadConfig.py:
3747         (loadBuilderConfig):
3748         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3749         (ConfigDotJSONTest.test_configuration):
3750         * BuildSlaveSupport/ews-build/master.cfg:
3751
3752 2019-03-11  Truitt Savell  <tsavell@apple.com>
3753
3754         Unreviewed, rolling out r242702.
3755
3756         Broke High Sierra builders.
3757
3758         Reverted changeset:
3759
3760         "Add utility function to allow easy reverse range-based
3761         iteration of a container"
3762         https://bugs.webkit.org/show_bug.cgi?id=195542
3763         https://trac.webkit.org/changeset/242702
3764
3765 2019-03-11  Sam Weinig  <sam@webkit.org>
3766
3767         Add utility function to allow easy reverse range-based iteration of a container
3768         https://bugs.webkit.org/show_bug.cgi?id=195542
3769
3770         Reviewed by Antti Koivisto.
3771
3772         * TestWebKitAPI/CMakeLists.txt:
3773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3774         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3775         (TestWebKitAPI::TEST):
3776         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3777
3778 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3779
3780         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3781         https://bugs.webkit.org/show_bug.cgi?id=195511
3782         <rdar://problem/44873269>
3783
3784         Reviewed by Darin Adler.
3785
3786         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3787         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3788         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3789         (TEST_F):
3790
3791 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3792
3793         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3794         https://bugs.webkit.org/show_bug.cgi?id=195499
3795
3796         Reviewed by Darin Adler.
3797
3798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3799         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3800         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3801         (-[WKWebView synchronouslyFocusTextInputContext:]):
3802         (applyStyle):
3803         (applyIframe):
3804         (TEST):
3805         Add some tests for this SPI.
3806
3807 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3808
3809         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3810         https://bugs.webkit.org/show_bug.cgi?id=181151
3811
3812         Reviewed by Don Olmstead.
3813
3814         * TestWebKitAPI/CMakeLists.txt:
3815         * TestWebKitAPI/PlatformWin.cmake:
3816         Enable TestWTF RunLoop tests in all platforms.
3817
3818         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3819         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3820         (TestWebKitAPI::DerivedOneShotTimer::fired):
3821         (TestWebKitAPI::TEST):
3822         Only a few platforms support nested RunLoop.
3823
3824         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3825         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3826
3827 2019-03-10  David Quesada  <david_quesada@apple.com>
3828
3829         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3830         https://bugs.webkit.org/show_bug.cgi?id=152480
3831
3832         Reviewed by Chris Dumez.
3833
3834         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3835         there are no additional references to the process pool besides the one held by
3836         the download, waits for the download to finish (in the sense that the
3837         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3838         measure, also check that the process pool has been deallocated at the end of the
3839         test. The test wouldn't be meaningful if the process pool were still alive.
3840
3841         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3842         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3843         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3844             The download will be canceled because the delegate does not implement the
3845             method to decide the download's destination, so this is where we know the
3846             DownloadProxyMap is done with the DownloadProxy.
3847         (TEST):
3848
3849 2019-03-08  Chris Dumez  <cdumez@apple.com>
3850
3851         Add support for Device Orientation / Motion permission API
3852         https://bugs.webkit.org/show_bug.cgi?id=195329
3853         <rdar://problem/47645367>
3854
3855         Reviewed by Geoffrey Garen.
3856
3857         Add test infrastructure to help test the Device Orientation / Motion permission API.
3858
3859         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3860         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3861         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3862         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3863         * WebKitTestRunner/TestController.cpp:
3864         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3865         (WTR::TestController::createWebViewWithOptions):
3866         (WTR::TestController::resetStateToConsistentValues):
3867         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3868         * WebKitTestRunner/TestController.h:
3869         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3870         * WebKitTestRunner/TestInvocation.cpp:
3871         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3872
3873 2019-03-08  Saam barati  <sbarati@apple.com>
3874
3875         Add a compare-results script to compare benchmark results
3876         https://bugs.webkit.org/show_bug.cgi?id=195486
3877         <rdar://problem/48723397>
3878
3879         Reviewed by Geoffrey Garen.
3880
3881         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3882         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3883         to extend it to learn about our other benchmarks.
3884
3885         * Scripts/compare-results: Added.
3886         (readJSONFile):
3887         (detectJetStream2):
3888         (JetStream2Results):
3889         (detectSpeedometer2):
3890         (Speedometer2Results):
3891         (detectPLT5):
3892         (PLT5Results):
3893         (detectBenchmark):
3894         (biggerIsBetter):
3895         (ttest):
3896         (getOptions):
3897         (main):
3898
3899 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3900
3901         Ensure old tab state is cleared between iterations of run-benchmark
3902         https://bugs.webkit.org/show_bug.cgi?id=195393
3903         <rdar://problem/46885583>
3904
3905         Reviewed by Dewei Zhu.
3906
3907         a) ensure the default to restore state is not set
3908         b) terminate Safari correctly
3909         c) Set the system default to ignore Persistent State in Safari
3910
3911         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3912         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3913         (OSXBrowserDriver.prepare_env): 
3914         (OSXBrowserDriver.restore_env):
3915         (OSXBrowserDriver.close_browsers):
3916         (OSXBrowserDriver._terminate_processes):
3917         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3918         (OSXChromeDriver):
3919         (OSXChromeCanaryDriver):
3920         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3921         (OSXFirefoxDriver):
3922         (OSXFirefoxNightlyDriver):
3923         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3924         (OSXSafariDriver):
3925         (OSXSafariDriver.prepare_env):
3926
3927 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3928
3929         [GTK] Several InputMethodFilter tests are failing
3930         https://bugs.webkit.org/show_bug.cgi?id=195408
3931
3932         Reviewed by Carlos Garcia Campos.
3933
3934         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3935         Regressed in r241751.
3936         Hexadecimal values of keycodes are expressed now in upper letters.
3937         Composited characters should be cast to UTF8 strings.
3938
3939         (TestWebKitAPI::TEST):
3940
3941 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3942
3943         [GTK] Make Tools/gtkdoc python3 compatible
3944         https://bugs.webkit.org/show_bug.cgi?id=195359
3945
3946         Reviewed by Carlos Garcia Campos.
3947
3948         * gtkdoc/generate-gtkdoc:
3949         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3950         work with Python 2 and 3.
3951         (get_gtkdoc_module_paths):
3952         The iteritems() was removed in Python 3, so let's use items() that's
3953         available in Python 2 and 3.
3954         (get_generator_for_config):
3955         * gtkdoc/gtkdoc.py:
3956         (GTKDoc._run_command):
3957         The sys.stdout.write() is expecting str in Python 3 and not bytes
3958         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3959         for passing the bytes there.
3960
3961 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3962
3963         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3964         https://bugs.webkit.org/show_bug.cgi?id=195346
3965         <rdar://problem/48667048>
3966
3967         Unreviewed build fix for clang-cl.
3968
3969         * DumpRenderTree/win/DumpRenderTree.cpp:
3970         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3971
3972 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3973
3974         requestAnimationFrame should execute before the next frame
3975         https://bugs.webkit.org/show_bug.cgi?id=177484
3976
3977         Reviewed by Simon Fraser.
3978
3979         Add trace points for the page RenderingUpdate.
3980
3981         * Tracing/SystemTracePoints.plist:
3982
3983 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3984
3985         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3986         https://bugs.webkit.org/show_bug.cgi?id=195353
3987         <rdar://problem/48626394>
3988
3989         Reviewed by Simon Fraser.
3990
3991         * WebKitTestRunner/ios/TestControllerIOS.mm:
3992         (WTR::TestController::platformResetPreferencesToConsistentValues):
3993
3994 2019-03-07  John Wilander  <wilander@apple.com>
3995
3996         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3997         https://bugs.webkit.org/show_bug.cgi?id=195383
3998         <rdar://problem/48570136>
3999
4000         Reviewed by Brent Fulgham.
4001
4002         This patch adds test infrastructure to purge only script-accessible cookies,
4003         including a new testRunner function called statisticsDeleteCookiesForHost().git a
4004
4005         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4006         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4007         (WTR::TestRunner::statisticsDeleteCookiesForHost):
4008         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4009         * WebKitTestRunner/TestController.cpp:
4010         (WTR::TestController::statisticsDeleteCookiesForHost):
4011         * WebKitTestRunner/TestController.h:
4012         * WebKitTestRunner/TestInvocation.cpp:
4013         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4014
4015 2019-03-07  Commit Queue  <commit-queue@webkit.org>
4016
4017         Unreviewed, rolling out r242354.
4018         https://bugs.webkit.org/show_bug.cgi?id=195402
4019
4020         breaks layout tests in all configurations (Requested by
4021         zdobersek on #webkit).
4022
4023         Reverted changeset:
4024
4025         "[WPE] Enable web process sandbox"
4026         https://bugs.webkit.org/show_bug.cgi?id=195169
4027         https://trac.webkit.org/changeset/242354
4028
4029 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
4030
4031         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4032         https://bugs.webkit.org/show_bug.cgi?id=195346
4033
4034         Reviewed by Fujii Hironori.
4035
4036         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4037         (TestWebKitAPI::TEST):
4038         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
4039
4040         * DumpRenderTree/win/DumpRenderTree.cpp:
4041         (findFontFallback):
4042         (addFontFallbackIfPresent):
4043         (removeFontFallbackIfPresent):
4044         (main):
4045         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4046         (TestWebKitAPI::Util::moduleDirectory):
4047         (TestWebKitAPI::Util::createInjectedBundlePath):
4048         Use wchar helpers as needed.
4049
4050 2019-03-06  Rob Buis  <rbuis@igalia.com>
4051
4052         Consider supporting the `referrerpolicy` attribute.
4053         https://bugs.webkit.org/show_bug.cgi?id=179053
4054
4055         Reviewed by Darin Adler.
4056
4057         Add a runtime flag for referrerpolicy attribute.
4058
4059         * DumpRenderTree/mac/DumpRenderTree.mm:
4060         (enableExperimentalFeatures):
4061
4062 2019-03-05  Daniel Bates  <dabates@apple.com>
4063
4064         Update expected API test result following r242379
4065         (https://bugs.webkit.org/show_bug.cgi?id=195125)
4066
4067         Update expected x-coordinate of selection rect now that the left padding of
4068         a textarea is sized in ems (so dependent on the font size) just like the left
4069         padding of a text field.
4070
4071         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4072         (TestWebKitAPI::TEST):
4073
4074 2019-03-05  David Quesada  <david_quesada@apple.com>
4075
4076         [WK2] It should be possible to follow links with 'download' attributes
4077         https://bugs.webkit.org/show_bug.cgi?id=195145
4078         rdar://problem/48462642
4079
4080         Reviewed by Alex Christensen.
4081
4082         Add a unit test to verify that activating links with 'download' attributes now
4083         navigates to the linked resource, rather than starts downloading it. Add another
4084         to verify that it is still possible to explicitly download the link via the
4085         'Download' navigation action policy.
4086
4087         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4088         (-[DownloadAttributeTestDelegate init]):
4089         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
4090         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
4091         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
4092         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
4093         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4094         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
4095         (TEST):
4096         * WebKitTestRunner/TestController.cpp:
4097         (WTR::TestController::decidePolicyForNavigationAction):
4098         * WebKitTestRunner/TestController.h:
4099
4100 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4101
4102         [Curl] Implement Cookie Accept Policy.
4103         https://bugs.webkit.org/show_bug.cgi?id=191645
4104
4105         Reviewed by Fujii Hironori.
4106
4107         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4108         (TestWebKitAPI::Curl::TEST_F):
4109
4110 2019-03-05  Youenn Fablet  <youenn@apple.com>
4111
4112         Rename requestCacheStorageSpace to requestStorageSpace
4113         https://bugs.webkit.org/show_bug.cgi?id=195282
4114
4115         Reviewed by Chris Dumez.
4116
4117         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4118         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4119         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4120
4121 2019-03-05  Brady Eidson  <beidson@apple.com>
4122
4123         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4124         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4125
4126         Reviewed by Tim Horton.
4127
4128         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4129         different directory into that same WKWebView should work.
4130
4131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4132         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4133
4134 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4135
4136         Add WeakHashSet
4137         https://bugs.webkit.org/show_bug.cgi?id=195152
4138
4139         Reviewed by Antti Koivisto.
4140
4141         Added tests for WeakHashSet.
4142
4143         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4144         (TestWebKitAPI::Base::Base): Moved.
4145         (TestWebKitAPI::Derived::foo): Moved.
4146         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4147         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4148         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4149         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4150
4151 2019-03-04  Chris Dumez  <cdumez@apple.com>
4152
4153         Do not share WebProcesses between private and regular sessions
4154         https://bugs.webkit.org/show_bug.cgi?id=195189
4155         <rdar://problem/48421064>
4156
4157         Reviewed by Alex Christensen.
4158
4159         Add API test coverage.
4160
4161         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4162         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4163
4164 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4165
4166         [WPE] Enable web process sandbox
4167         https://bugs.webkit.org/show_bug.cgi?id=195169
4168
4169         Reviewed by Daniel Bates.
4170
4171         * wpe/install-dependencies:
4172         * wpe/jhbuild.modules:
4173
4174 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4175
4176         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4177         https://bugs.webkit.org/show_bug.cgi?id=195206
4178
4179         Reviewed by Žan Doberšek.
4180
4181         Add a new test case.
4182
4183         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4184         (testJSCClass):
4185
4186 2019-03-04  Charlie Turner  <cturner@igalia.com>
4187
4188         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4189         https://bugs.webkit.org/show_bug.cgi?id=194898
4190
4191         Reviewed by Žan Doberšek.
4192
4193         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4194         a GCC extension that permits arithmetic on void* pointer. Inline
4195         the macro until this issue is fixed upstream.
4196
4197 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4198
4199         Rid the world of WK_API_ENABLED
4200         https://bugs.webkit.org/show_bug.cgi?id=195263
4201
4202         Reviewed by Dan Bernstein.
4203
4204         List of changed files elided because it's useless.
4205
4206 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4207
4208         Unreviewed follow-up to r242292.
4209
4210         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4211
4212         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4213         (TestWebKitAPI::testStrip): Renamed from strip.
4214         (TestWebKitAPI::TEST):
4215
4216 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4217
4218         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4219
4220         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4221         and bug #194272 for details.
4222
4223         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4224
4225 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4226
4227         Remove some more unused 32-bit code
4228         https://bugs.webkit.org/show_bug.cgi?id=195255
4229
4230         Reviewed by Darin Adler.
4231
4232         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4233         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4234         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4235         (NPP_New):
4236         (NPP_HandleEvent):
4237         (handleEventCarbon): Deleted.
4238
4239 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4240
4241         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4242
4243         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4244         (TestWebKitAPI::TEST):
4245
4246 2019-03-01  Darin Adler  <darin@apple.com>
4247
4248         Finish removing String::format
4249         https://bugs.webkit.org/show_bug.cgi?id=194893
4250
4251         Reviewed by Daniel Bates.
4252 '
4253         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4254
4255 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4256
4257         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4258         https://bugs.webkit.org/show_bug.cgi?id=195229
4259         <rdar://problem/48520362>
4260
4261         Reviewed by Chris Dumez.
4262
4263         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4264         (TEST):
4265
4266 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4267
4268         Add a system trace scope for event region building
4269         https://bugs.webkit.org/show_bug.cgi?id=195226
4270
4271         Reviewed by Jon Lee.
4272
4273         This trace scope measures the time spend converting element rects into Region objects,
4274         which can be large on some pages.
4275
4276         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4277
4278         * Tracing/SystemTracePoints.plist:
4279
4280 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4281
4282         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4283         https://bugs.webkit.org/show_bug.cgi?id=194612
4284
4285         Reviewed by Alex Christensen.
4286
4287         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4288         Just test the new string-processing function and don't touch the actual environment.
4289         (Test cases are all as before, but based on operator== instead of strcmp.)
4290
4291 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4292
4293         [ews-app] Update primary keys for handling multiple Buildbot instances
4294         https://bugs.webkit.org/show_bug.cgi?id=195120
4295
4296         Reviewed by Stephanie Lewis.
4297
4298         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4299         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4300         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4301
4302         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4303         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4304         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4305         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4306         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4307         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4308
4309 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4310
4311         [WinCairo] Enable service worker
4312         https://bugs.webkit.org/show_bug.cgi?id=188318
4313
4314         Reviewed by Youenn Fablet.
4315
4316         * DumpRenderTree/DumpRenderTreePrefix.h:
4317         * TestWebKitAPI/PlatformWin.cmake:
4318         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4319         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4320         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4321
4322 2019-03-01  Justin Fan  <justin_fan@apple.com>
4323
4324         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4325         https://bugs.webkit.org/show_bug.cgi?id=195191
4326
4327         Rubber-stamped by Dean Jackson.
4328
4329         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4330
4331         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4332
4333 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4334
4335         Unreviewed, fix lldb webkitpy tests
4336         https://bugs.webkit.org/show_bug.cgi?id=194375
4337
4338         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4339
4340         * lldb/lldb_webkit.py:
4341         (WTFStringImplProvider.is_8bit):
4342
4343 2019-02-28  David Quesada  <david_quesada@apple.com>
4344
4345         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4346         https://bugs.webkit.org/show_bug.cgi?id=195121
4347         rdar://problem/48450302
4348
4349         Reviewed by Alex Christensen.
4350
4351         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4352         configurations where the 'download' attribute is absent, blank, or populated
4353         with a filename, and where the anchor element is same-origin or cross-origin
4354         (meaning the 'download' attribute shouldn't be honored).
4355
4356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4357         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4358         (-[NavigationActionTestDelegate init]):
4359         (-[NavigationActionTestDelegate navigationAction]):
4360         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4361         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4362