WKR (new-commit-bot) is too slow
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
2
3         WKR (new-commit-bot) is too slow
4         https://bugs.webkit.org/show_bug.cgi?id=110087
5
6         Reviewed by Geoffrey Garen.
7
8         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
9         Just run "svn log -r <revision>" instead to cut down the delay.
10
11         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
12
13         * Scripts/webkitpy/tool/commands/newcommitbot.py:
14         (NewCommitBot):
15         (NewCommitBot.next_work_item):
16         (NewCommitBot._is_empty_log):
17         (NewCommitBot._update_checkout):
18
19 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
20
21         Build fix. Can't remove appendCustomBuildFlags.
22
23         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
24         (appendCustomBuildFlags):
25
26 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
27
28         Remove Chromium builders from build.webkit.org
29         https://bugs.webkit.org/show_bug.cgi?id=113990
30
31         Reviewed by Benjamin Poulain.
32
33         Removed.
34
35         * BuildSlaveSupport/build.webkit.org-config/config.json:
36         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
37         (InstallGtkDependencies):
38         (RunUnitTests.start):
39         (RunWebKit2Tests.start):
40         (Factory.__init__):
41         (unitTestsSupported):
42         (TestFactory.__init__):
43         (BuildAndTestFactory.__init__):
44         (BuildAndPerfTestFactory.__init__):
45         (BuildAndPerfTestWebKit2Factory.__init__):
46         (DownloadAndPerfTestFactory.__init__):
47         (loadBuilderConfig):
48         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
49
50 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
51
52         Remove HTML Notification
53         https://bugs.webkit.org/show_bug.cgi?id=114231
54
55         Reviewed by Ryosuke Niwa.
56
57         * qmake/mkspecs/features/features.pri:
58
59 2013-04-08  Glenn Adams  <glenn@skynav.com>
60
61         Remove chromium EWS support, and fix broken test.
62         https://bugs.webkit.org/show_bug.cgi?id=114221
63
64         Reviewed by Ryosuke Niwa.
65
66         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
67         (AbstractChromiumEWS): Removed.
68         (ChromiumLinuxEWS): Removed.
69         (ChromiumLinuxDebugEWS): Removed.
70         (ChromiumWindowsEWS): Removed.
71         (ChromiumAndroidEWS): Removed.
72         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
73         (EarlyWarningSystemTest): Fix misspelled class name.
74         (test_ewses): Fix entry point name to ensure test is run.
75
76 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
77
78         [WIN] Remove WebKit2 source code
79         https://bugs.webkit.org/show_bug.cgi?id=114096
80
81         Reviewed by Anders Carlsson.
82
83         Remove the windows specific parts of the MiniBrowser.
84
85         * MiniBrowser/MiniBrowser.vcproj: Removed.
86         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
87         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
88         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
89         * MiniBrowser/win/BrowserView.cpp: Removed.
90         * MiniBrowser/win/BrowserView.h: Removed.
91         * MiniBrowser/win/BrowserWindow.cpp: Removed.
92         * MiniBrowser/win/BrowserWindow.h: Removed.
93         * MiniBrowser/win/MiniBrowser.cpp: Removed.
94         * MiniBrowser/win/MiniBrowser.h: Removed.
95         * MiniBrowser/win/MiniBrowser.rc: Removed.
96         * MiniBrowser/win/main.cpp: Removed.
97         * MiniBrowser/win/resource.h: Removed.
98         * MiniBrowser/win/stdafx.cpp: Removed.
99         * MiniBrowser/win/stdafx.h: Removed.
100
101 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
102
103         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
104
105         * Scripts/webkitpy/common/config/irc.py:
106
107 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
108
109         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
110         https://bugs.webkit.org/show_bug.cgi?id=113139
111
112         Reviewed by Anders Carlsson.
113
114         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
115         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
116         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
117         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
118         (ToStringAndValueOfObject):
119         (ToStringAndValueOfObject::ToStringAndValueOfObject):
120         (ScriptableObject):
121         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
122         (ToStringAndValueOfObject::ScriptableObject::invoke):
123         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
124         (ToStringAndValueOfObject::NPP_GetValue):
125         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
126         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
127         * GNUmakefile.am:
128
129 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
130
131         [GTK] Bump gnome-themes-standard to 3.6.0
132         https://bugs.webkit.org/show_bug.cgi?id=114155
133
134         Reviewed by Martin Robinson.
135
136         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
137         dependency of gnome-themes-standard accordingly.
138
139 2013-04-08  David Levin  <levin@chromium.org>
140
141         Remove my watchlist entries.
142         https://bugs.webkit.org/show_bug.cgi?id=114180
143
144         Reviewed by Adam Barth.
145
146         * Scripts/webkitpy/common/config/committers.py:
147         * Scripts/webkitpy/common/config/watchlist:
148
149 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
150
151         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
152         https://bugs.webkit.org/show_bug.cgi?id=114161
153
154         Reviewed by Gyuyoung Kim.
155
156         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
157         as it is crashing due to Bug 111074.
158
159         * TestWebKitAPI/PlatformEfl.cmake:
160
161 2013-04-07  David Kilzer  <ddkilzer@apple.com>
162
163         Remove the rest of SVG_DOM_OBJC_BINDINGS
164         <http://webkit.org/b/114112>
165
166         Reviewed by Geoffrey Garen.
167
168         * Scripts/webkitperl/FeatureList.pm:
169         - Remove --svg-dom-objc-bindings switch.
170         * qmake/mkspecs/features/features.pri:
171         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
172
173 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
174
175         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
176         https://bugs.webkit.org/show_bug.cgi?id=114089
177
178         Reviewed by Chris Fleizach.
179
180         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
181         * DumpRenderTree/AccessibilityController.cpp:
182         * DumpRenderTree/AccessibilityUIElement.cpp:
183         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
184         (DumpRenderTreeChrome::DumpRenderTreeChrome):
185         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
186         (DumpRenderTreeChrome):
187
188 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
189
190         Build fix after r147857, remove remaining USE(JSC) guards.
191
192         Unreviewed.
193
194         * DumpRenderTree/config.h:
195         * TestWebKitAPI/config.h:
196         * WebKitTestRunner/config.h:
197
198 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
199
200         Rename sheriffbot to webkitbot
201         https://bugs.webkit.org/show_bug.cgi?id=114109
202
203         Reviewed by Benjamin Poulain.
204
205         Renamed since sheriffbot will be used in Blink.
206
207         * Scripts/webkitpy/tool/commands/sheriffbot.py:
208         (SheriffBot):
209         (SheriffBot.begin_work_queue):
210
211 2013-04-06  Oliver Hunt  <oliver@apple.com>
212
213         Unify the many and varied stack trace mechanisms, and make the result sane.
214         https://bugs.webkit.org/show_bug.cgi?id=114072
215
216         Reviewed by Filip Pizlo.
217
218         The commandline jsc executable no longer requires arguments, so
219         I've made run-jsc work without them.
220
221         * Scripts/run-jsc:
222
223 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
224
225         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
226         https://bugs.webkit.org/show_bug.cgi?id=114086
227
228         Reviewed by Tim Horton.
229
230         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
231
232 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
233
234         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
235         https://bugs.webkit.org/show_bug.cgi?id=114083
236
237         Reviewed by Ryosuke Niwa.
238
239         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
240         in TestWebKitAPI and WebKitTestRunner.
241
242         * TestWebKitAPI/config.h:
243         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
244         (TestWebKitAPI::InjectedBundleController::platformInitialize):
245         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
246         (WTR::InjectedBundle::platformInitialize):
247
248 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
249
250         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
251         https://bugs.webkit.org/show_bug.cgi?id=114094
252
253         Reviewed by Anders Carlsson.
254
255         * Scripts/run-jsc:
256
257 2013-04-05  Ojan Vafai  <ojan@chromium.org>
258
259         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
260         https://bugs.webkit.org/show_bug.cgi?id=114080
261
262         Reviewed by Ryosuke Niwa.
263
264         This way, the WebKit and Blink dashboard code can change as appropriate without
265         needing to consider the other project's needs. This still doesn't update the
266         buildbots to upload to the new location, or the dashboard code to pull the
267         results.json files from the new location, but it at least allows for changing the
268         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
269
270         * TestResultServer/app.yaml:
271
272 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
273
274         Re-enable testing on the commit queue
275         https://bugs.webkit.org/show_bug.cgi?id=114078
276
277         Reviewed by Darin Adler.
278
279         Re-enabled the feature and the associated tests.
280
281         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
282         (CommitQueueTask.run):
283         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
284         (CommitQueueTaskTest._run_through_task):
285         * Scripts/webkitpy/tool/commands/queues_unittest.py:
286         (CommitQueueTest._mock_test_result):
287
288 2013-04-05  Oliver Hunt  <oliver@apple.com>
289
290         Unify the many and varied stack trace mechanisms, and make the result sane.
291         https://bugs.webkit.org/show_bug.cgi?id=114072
292
293         Reviewed by Filip Pizlo.
294
295         The commandline jsc executable no longer requires arguments, so
296         I've made run-jsc work without them.
297
298         * Scripts/run-jsc:
299
300 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
301
302         AX: Make SVG Group containers accessible elements
303         https://bugs.webkit.org/show_bug.cgi?id=113939
304
305         Reviewed by Simon Fraser.
306
307         Implement axController.elementAtPoint for iOS.
308         Implement a correct version of clickPoint for iOS.
309
310         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
311         (AccessibilityController::elementAtPoint):
312         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
313         (AccessibilityUIElement::clickPointX):
314         (AccessibilityUIElement::clickPointY):
315
316 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
317
318         Unreviewed, rolling out r147773 and r147774.
319         http://trac.webkit.org/changeset/147773
320         http://trac.webkit.org/changeset/147774
321         https://bugs.webkit.org/show_bug.cgi?id=114056
322
323         Causing some exceptions on AppEngine I don't understand
324         (Requested by rniwa on #webkit).
325
326         * QueueStatusServer/config/queues.py:
327         * QueueStatusServer/model/queues.py:
328         (Queue.short_name):
329         (Queue.display_name):
330         * QueueStatusServer/model/queues_unittest.py:
331         (QueueTest.test_short_name):
332         (QueueTest.test_display_name):
333         (QueueTest.test_name_with_underscores):
334
335 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
336
337         Fixed run-bindings-tests by removing V8
338         https://bugs.webkit.org/show_bug.cgi?id=114053
339
340         Reviewed by Benjamin Poulain.
341
342         * Scripts/run-bindings-tests:
343         (main):
344
345 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
346
347         Build fix.
348
349         * QueueStatusServer/model/queues.py:
350         (Queue.short_name):
351         (Queue.display_name):
352
353 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
354
355         Remove Chromium EWS bots from the queue status server
356         https://bugs.webkit.org/show_bug.cgi?id=113988
357
358         Reviewed by Benjamin Poulain.
359
360         Removed Chromium EWS bots.
361
362         * QueueStatusServer/config/queues.py:
363         * QueueStatusServer/model/queues.py:
364         (Queue.short_name):
365         (Queue.display_name):
366         * QueueStatusServer/model/queues_unittest.py:
367         (QueueTest.test_short_name):
368         (QueueTest.test_display_name):
369         (QueueTest.test_name_with_underscores):
370
371 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
372
373         [EFL] Enable indexed database
374         https://bugs.webkit.org/show_bug.cgi?id=107248
375
376         Reviewed by Alexis Menard.
377
378         * Scripts/webkitperl/FeatureList.pm:
379
380 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
381
382         Remove vestiges of Chromium bits from watchlists.
383         https://bugs.webkit.org/show_bug.cgi?id=114047
384
385         Reviewed by Ryosuke Niwa.
386
387         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
388
389 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
390
391         Add James Craig to the contributors list.
392
393         * Scripts/webkitpy/common/config/committers.py:
394
395 2013-04-04  Kent Tamura  <tkent@chromium.org>
396
397         Remove ChromiumPublicApi pattern, and cc/message rules for it.
398
399         * Scripts/webkitpy/common/config/watchlist:
400
401 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
402
403         Temporarily disable the Python unittests broken by the commit queue not running layout tests
404         https://bugs.webkit.org/show_bug.cgi?id=113997
405
406         Reviewed by Ryosuke Niwa.
407
408         Disable the tests until Ryosuke gets the time and hardware to have
409         a testing commit-queue.
410
411         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
412         (CommitQueueTaskTest):
413         * Scripts/webkitpy/tool/commands/queues_unittest.py:
414         (CommitQueueTest):
415
416 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
417
418         Remove Chromium builders from build.webkit.org
419         https://bugs.webkit.org/show_bug.cgi?id=113990
420
421         Reviewed by Benjamin Poulain.
422
423         Land the part to disable triggering of Chromium builders first so that we may start
424         deleting more Chromium code that breaks the update step.
425
426         * BuildSlaveSupport/build.webkit.org-config/config.json:
427
428 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
429
430         Remove Chromium's DumpRenderTree
431         https://bugs.webkit.org/show_bug.cgi?id=113989
432
433         Reviewed by Kent Tamura.
434
435         On second thought, let's not go to Camelot. It is a silly place.
436
437         * DumpRenderTree/mac/DumpRenderTree.mm:
438         (resetDefaultsToConsistentValues):
439
440 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
441
442         Nixed the defunct chromium folder from DumpRenderTree
443         https://bugs.webkit.org/show_bug.cgi?id=113993
444
445         Reviewed by Ryosuke Niwa.
446
447         * DumpRenderTree/chromium: Removed.
448         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
449         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
450         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
451         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
452         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
453         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
454         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
455         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
456         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
457         * DumpRenderTree/chromium/MockPlatform.h: Removed.
458         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
459         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
460         * DumpRenderTree/chromium/Task.cpp: Removed.
461         * DumpRenderTree/chromium/Task.h: Removed.
462         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
463         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
464         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
465         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
466         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
467         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
468         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
469         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
470         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
471         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
472         * DumpRenderTree/chromium/TestRunner: Removed.
473         * DumpRenderTree/chromium/TestRunner/public: Removed.
474         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
475         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
476         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
477         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
478         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
479         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
480         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
481         * DumpRenderTree/chromium/TestRunner/src: Removed.
482         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
483         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
484         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
485         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
486         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
487         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
488         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
489         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
490         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
491         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
492         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
493         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
494         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
495         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
496         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
497         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
498         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
499         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
500         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
501         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
502         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
503         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
504         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
505         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
506         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
507         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
508         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
509         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
510         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
511         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
512         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
513         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
514         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
515         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
516         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
517         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
518         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
519         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
520         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
521         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
522         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
523         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
524         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
525         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
526         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
527         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
528         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
529         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
530         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
531         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
532         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
533         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
534         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
535         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
536         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
537         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
538         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
539         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
540         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
541         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
542         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
543         * DumpRenderTree/chromium/TestShell.cpp: Removed.
544         * DumpRenderTree/chromium/TestShell.h: Removed.
545         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
546         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
547         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
548         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
549         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
550         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
551         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
552         * DumpRenderTree/chromium/WebViewHost.h: Removed.
553         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
554         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
555         * DumpRenderTree/chromium/config.h: Removed.
556         * DumpRenderTree/chromium/fonts.conf: Removed.
557
558 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
559
560         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
561
562         Rubber stamped by Benjamin Poulain.
563
564         * RebaselineQueueServer: Removed.
565         * RebaselineQueueServer/app.yaml: Removed.
566         * RebaselineQueueServer/handlers: Removed.
567         * RebaselineQueueServer/handlers/__init__.py: Removed.
568         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
569         * RebaselineQueueServer/handlers/pages.py: Removed.
570         * RebaselineQueueServer/index.yaml: Removed.
571         * RebaselineQueueServer/main.py: Removed.
572         * RebaselineQueueServer/model: Removed.
573         * RebaselineQueueServer/model/__init__.py: Removed.
574         * RebaselineQueueServer/model/queueentry.py: Removed.
575         * RebaselineQueueServer/static: Removed.
576         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
577         * RebaselineQueueServer/static/styles.css: Removed.
578         * RebaselineQueueServer/templates: Removed.
579         * RebaselineQueueServer/templates/builder-picker.html: Removed.
580         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
581         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
582         * RebaselineQueueServer/templates/home.html: Removed.
583
584 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
585
586         Fix setup-commit-queue and temporarily disable testing on commit-queue
587         https://bugs.webkit.org/show_bug.cgi?id=113979
588
589         Reviewed by Benjamin Poulain.
590
591         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
592         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
593
594         * EWSTools/setup-commit-queue.sh:
595         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
596         (CommitQueueTask.run):
597
598 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
599
600         temporarily make flakiness dashboard work again webkit.org bots
601         https://bugs.webkit.org/show_bug.cgi?id=113972
602
603         Reviewed by Ojan Vafai.
604
605         This patch disables the chromium.org layout test bots TestExpectations
606         parsing temporarily until we can work out the right way to split into
607         two instances for webkit.org and chromium.org and figure out which
608         code to delete where :).
609
610         * TestResultServer/static-dashboards/flakiness_dashboard.js:
611
612 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
613
614         Fix webkitpy tests after r147678.
615
616         * Scripts/webkitpy/tool/commands/queues_unittest.py:
617         (CommitQueueTest.test_commit_queue):
618         (test_manual_reject_during_processing):
619
620 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
621
622         The commit queue should use Mac MountainLion port
623         https://bugs.webkit.org/show_bug.cgi?id=113971
624
625         Reviewed by Lucas Forschler.
626
627         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
628         * Scripts/webkitpy/tool/commands/queues.py:
629         (CommitQueue):
630
631 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
632
633         turn off running tests on chromium linux EWS bots
634         https://bugs.webkit.org/show_bug.cgi?id=113959
635
636         Reviewed by Geoffrey Garen.
637
638         Now that the Chromium port is no longer being maintained
639         there's little point in running the tests. Soon we should
640         just shut this bot off altogether.
641
642         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
643         (ChromiumLinuxEWS):
644
645 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
646
647         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
648
649         * Scripts/webkitpy/common/config/watchlist:
650
651 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
652
653         Indentation fix to get webkit-patch working again after r147625
654
655         Unreviewed.
656
657         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
658         (MacEWS):
659         (MacWK2EWS):
660
661 2013-04-04  Lucas Forschler  <lforschler@apple.com>
662
663         Turn tests back on for Mac WK1/WK2 EWS.
664         
665         Unreviewed.
666         
667         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
668         (MacEWS):
669         (MacWK2EWS):
670
671 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
672
673         [GTK][WK2] MiniBrowser custom URI scheme support
674         https://bugs.webkit.org/show_bug.cgi?id=112419
675
676         Reviewed by Carlos Garcia Campos.
677
678         Add support for about URIs in MiniBrowser. An example about page is show
679         with URI "about:minibrowser", the rest of the cases it will show a
680         proper message explaining that the about page didn't exist.
681
682         Internally it uses "minibrowser-about" prefix instead of "about", but
683         from the user point of view it works with "about" prefix.
684
685         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
686         (getInternalURI): Method to convert URIs from "about" prefix to
687         "minibrowser-about".
688         (getExternalURI): Opposite method.
689         (webViewURIChanged): Use "about" prefix to show the URI to users.
690         (webViewEnterFullScreen): Ditto.
691         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
692         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
693         (aboutURISchemeRequestCallback): Callback to manage about calls.
694         (main): Register the URI scheme to manage about URIs.
695
696 2013-04-03  Roger Fong  <roger_fong@apple.com>
697
698         Re-enable WinEWS tests.
699
700         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
701         (WinEWS):
702
703 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
704
705         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
706         https://bugs.webkit.org/show_bug.cgi?id=113883
707
708         Reviewed by Martin Robinson.
709
710         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
711         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
712         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
713
714 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
715
716         [GTK] Include Pango in jhbuild-optional.modules
717         https://bugs.webkit.org/show_bug.cgi?id=113878
718
719         Reviewed by Martin Robinson.
720
721         Since r147547 Pango 1.32.0 is required. Including the module in the
722         JHBuild optional moduleset.
723
724         * gtk/jhbuild-optional.modules: Add Pango module.
725
726 2013-04-03  Zeno Albisser  <zeno@webkit.org>
727
728         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
729         https://bugs.webkit.org/show_bug.cgi?id=113864
730
731         Moving setDefersLoading from TestRunnerQt to TestRunner
732         requires access to the non-Qt TestRunner.
733         As long as we instantiate both TestRunner and TestRunnerQt,
734         we need a separate getter for the non-Qt TestRunner instance.
735
736         Reviewed by Simon Hausmann.
737
738         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
739         (WebPage::resetSettings):
740         * DumpRenderTree/qt/DumpRenderTreeQt.h:
741         (DumpRenderTree::jscTestRunner):
742         * DumpRenderTree/qt/TestRunnerQt.cpp:
743         (TestRunner::setDefersLoading):
744             Moving setDefersLoading from TestRunnerQt
745             to TestRunner.
746         * DumpRenderTree/qt/TestRunnerQt.h:
747         (TestRunnerQt):
748
749 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
750
751         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
752         https://bugs.webkit.org/show_bug.cgi?id=104779
753
754         Reviewed by Carlos Garcia Campos.
755
756         * Scripts/run-gtk-tests:
757         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
758         passing in current trunk.
759
760 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
761
762         Fix HAVE(QTTESTSUPPORT) logic
763
764         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
765         resulting in HAVE(QTTESTSUPPORT) never being true.
766         Move that logic down in sanitizeFeatures.
767
768         Rubber-stamped by Tor Arne Vestbø.
769
770         * qmake/mkspecs/features/features.prf:
771
772 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
773
774         [GTK] Bump required versions of some dependencies
775         https://bugs.webkit.org/show_bug.cgi?id=113282
776
777         Reviewed by Martin Robinson.
778
779         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
780
781 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
782
783         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
784         https://bugs.webkit.org/show_bug.cgi?id=113809
785
786         Reviewed by Philippe Normand.
787
788         Newer Linux kernels have removed some deprecated macros from v4l2
789         headers, causing gst-plugins-good's build to break. We don't need it
790         right now, so just disable it.
791
792         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
793
794 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
795
796         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
797         https://bugs.webkit.org/show_bug.cgi?id=113535
798
799         Reviewed by Simon Hausmann.
800
801         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
802
803         * qmake/mkspecs/features/features.prf:
804
805 2013-04-03  Zeno Albisser  <zeno@webkit.org>
806
807         [Qt] Move logic of simple forwarding functions to TestRunner.
808         https://bugs.webkit.org/show_bug.cgi?id=113863
809
810         Reviewed by Simon Hausmann.
811
812         * DumpRenderTree/qt/TestRunnerQt.cpp:
813         (TestRunner::setTextDirection):
814         (TestRunner::goBack):
815         (TestRunner::evaluateScriptInIsolatedWorld):
816         (TestRunner::addUserStyleSheet):
817         * DumpRenderTree/qt/TestRunnerQt.h:
818         (TestRunnerQt):
819
820 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
821
822         [Qt] Disable media support using QuickTime if deployment target != SDK
823
824         We link to a single libWebKitSystemInterface static lib, so unless the
825         deployment target matches the SDK let's not pretend like we'll be able
826         to run on anything lower than the SDK version.
827
828         Reviewed by Simon Hausmann.
829
830         * qmake/mkspecs/features/features.prf:
831
832 2013-04-02  James Craig  <james@cookiecrook.com>
833
834         AXRoleDescripton for DL is "list"; should be "description list"
835         https://bugs.webkit.org/show_bug.cgi?id=111665
836
837         Reviewed by Chris Fleizach.
838
839         Defining the role and description strings.
840
841         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
842
843 2013-04-02  Roger Fong  <roger_fong@apple.com>
844
845         Unreviewed. Disable running tests on Win EWS queue.
846
847         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
848         (WinEWS):
849
850 2013-04-02  Lucas Forschler  <lforschler@apple.com>
851
852         Disable running tests on the MAC WK2 EWS queue.
853         
854         Unreviewed.
855         
856         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
857         (MacWK2EWS):
858
859 2013-04-02  Julie Parent  <jparent@chromium.org>
860
861         Dashboard refactor: Move dashboard specific history related features to History.
862         https://bugs.webkit.org/show_bug.cgi?id=113717
863
864         Reviewed by Ojan Vafai.
865         
866         Each dashboard now creates its own History object, with a custom
867         configuration. This changes from just overriding global functions
868         to passing in callbacks for generatePage, handleValidHashParameter,
869         and handleQueryParameterChange. Same with passing in defaultStateValues
870         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
871         variables.
872         
873         All functions related to these features are now (mostly) private
874         function on History. 
875         
876         Loader no longer needs a loadingComplete callback, since it can just
877         initialize the history object itself.
878
879         * TestResultServer/static-dashboards/aggregate_results.js:
880         (handleValidHashParameter):
881         * TestResultServer/static-dashboards/dashboard_base.js:
882         * TestResultServer/static-dashboards/flakiness_dashboard.js:
883         (generatePage):
884         (.switch.return):
885         (handleQueryParameterChange):
886         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
887         (resetGlobals):
888         * TestResultServer/static-dashboards/history.js:
889         (.):
890         * TestResultServer/static-dashboards/loader.js:
891         (.):
892         * TestResultServer/static-dashboards/loader_unittests.js:
893         * TestResultServer/static-dashboards/timeline_explorer.js:
894         (generatePage):
895         (initCurrentBuilderTestResults):
896         * TestResultServer/static-dashboards/treemap.js:
897         (generatePage):
898         (.switch.return):
899         (handleQueryParameterChange):
900
901 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
902
903         Unreviewed, rolling out r147401.
904         http://trac.webkit.org/changeset/147401
905         https://bugs.webkit.org/show_bug.cgi?id=113767
906
907         The patch makes it extremely hard to set up the dependencies
908         properly on the GTK builders (Requested by zdobersek on
909         #webkit).
910
911         * gtk/jhbuild.modules:
912
913 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
914
915         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
916         https://bugs.webkit.org/show_bug.cgi?id=113382
917
918         Reviewed by Gyuyoung Kim.
919
920         Do not show the empty tooltip box if the text is null.
921
922         * MiniBrowser/efl/main.c:
923         (popup_menu_populate):
924
925 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
926
927         [GTK] Bump required versions of some dependencies
928         https://bugs.webkit.org/show_bug.cgi?id=113282
929
930         Reviewed by Martin Robinson.
931
932         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
933
934 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
935
936         Unreviewed, rolling out r147319.
937         http://trac.webkit.org/changeset/147319
938         https://bugs.webkit.org/show_bug.cgi?id=113707
939
940         The unit test is still failing on the buildbot (Requested by
941         zdobersek on #webkit).
942
943         * Scripts/run-gtk-tests:
944         (TestRunner):
945
946 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
947
948         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
949         https://bugs.webkit.org/show_bug.cgi?id=104779
950
951         Reviewed by Carlos Garcia Campos.
952
953         * Scripts/run-gtk-tests:
954         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
955         passing in current trunk.
956
957 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
958
959         Unreviewed, rolling out r147289.
960         http://trac.webkit.org/changeset/147289
961         https://bugs.webkit.org/show_bug.cgi?id=113678
962
963         broke Win7 (dbg) build (Requested by shinyak|gardener on
964         #webkit).
965
966         * DumpRenderTree/DumpRenderTree.gypi:
967         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
968         (WebTestRunner):
969         (WebUserMediaClientMock):
970         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
971         (WebTestRunner::WebUserMediaClientMock::taskList):
972         * Scripts/webkitpy/style/checkers/cpp.py:
973         (check_function_definition):
974
975 2013-03-31  Adam Barth  <abarth@webkit.org>
976
977         configure-svn-config.sh fails
978         https://codereview.chromium.org/13392007/
979
980         Reviewed by Eric Seidel.
981
982         This script was trying to use "svn checkout" to dowload a file from
983         svn.webkit.org, but "svn checkout" only works with directories.
984         Instead, we should use "svn export".
985
986         * EWSTools/configure-svn-config.sh:
987
988 2013-03-31  Wei Jia  <wjia@chromium.org>
989
990         Allow WebUserMediaClientMock to be used by client
991         https://bugs.webkit.org/show_bug.cgi?id=113633
992
993         Reviewed by Adam Barth.
994
995         Export WebUserMediaClientMock.
996         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
997
998         * DumpRenderTree/DumpRenderTree.gypi:
999         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1000         (WebUserMediaClientMock):
1001         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1002         * Scripts/webkitpy/style/checkers/cpp.py:
1003         (check_function_definition):
1004
1005 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1006
1007         Expose FeatureObserver data to WebKit clients
1008         https://bugs.webkit.org/show_bug.cgi?id=113613
1009
1010         Reviewed by Sam Weinig.
1011
1012         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1013         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1014
1015 2013-03-29  Greg Hughes  <ghughes@apple.com>
1016
1017         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1018         https://bugs.webkit.org/show_bug.cgi?id=112276
1019
1020         Reviewed by Chris Fleizach.
1021
1022         Added support to test accessibility search predicates with multiple keys.  
1023
1024         * DumpRenderTree/AccessibilityUIElement.cpp:
1025         (uiElementForSearchPredicateCallback):
1026         * DumpRenderTree/AccessibilityUIElement.h:
1027         (AccessibilityUIElement):
1028         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1029         (AccessibilityUIElement::uiElementForSearchPredicate):
1030         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1031         (AccessibilityUIElement::uiElementForSearchPredicate):
1032         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1033         (AccessibilityUIElement::uiElementForSearchPredicate):
1034         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1035         (AccessibilityUIElement::uiElementForSearchPredicate):
1036         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1037         (AccessibilityUIElement::uiElementForSearchPredicate):
1038         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1039         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1040         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1041         (AccessibilityUIElement):
1042         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1043         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1044         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1045         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1046         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1047
1048 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1049
1050         Fix a typo in r147147 to fix Mac EWS.
1051
1052         * Scripts/webkitpy/tool/commands/queues.py:
1053         (PatchProcessingQueue._new_port_name_from_old):
1054
1055 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1056
1057         [EFL] Build break with latest EFL libraries after r146265
1058         https://bugs.webkit.org/show_bug.cgi?id=113558
1059
1060         Unreviewed build fix.
1061
1062         * TestWebKitAPI/PlatformWebView.h:
1063         * WebKitTestRunner/PlatformWebView.h:
1064
1065 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1066
1067         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1068
1069         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1070         in libgcrypt build.
1071
1072 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1073
1074         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1075
1076         Unreviewed.
1077
1078         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1079         (MacEWS):
1080
1081 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1082
1083         Use the right OS name on Mac EWS instead of mac-future.
1084
1085         Rubber-stamped by Dirk Pranke.
1086
1087         * Scripts/webkitpy/tool/commands/queues.py:
1088         (PatchProcessingQueue._new_port_name_from_old):
1089         (PatchProcessingQueue.begin_work_queue):
1090         (PatchProcessingQueue._upload_results_archive_for_patch):
1091
1092 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1093
1094         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1095         https://bugs.webkit.org/show_bug.cgi?id=112546
1096
1097         Reviewed by Martin Robinson.
1098
1099         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1100         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1101
1102 2013-03-28  Ming Xie  <mxie@blackberry.com>
1103
1104         [BlackBerry] Committer Email Updates
1105         https://bugs.webkit.org/show_bug.cgi?id=113435
1106
1107         Reviewed by Rob Buis.
1108
1109         Add the @blackberry.com email address for all our BlackBerry
1110         WebKit committers. This is the first step for our email address
1111         migration.
1112
1113         * Scripts/webkitpy/common/config/committers.py:
1114
1115 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1116
1117         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1118         https://bugs.webkit.org/show_bug.cgi?id=113508
1119
1120         Reviewed by Martin Robinson.
1121
1122         Prevent the GStreamer plugin scanner to load system-wide
1123         plugins. Only the ones built in JHBuild should be loaded and used
1124         at runtime.
1125
1126         * efl/jhbuildrc:
1127         * gtk/jhbuildrc:
1128
1129 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1130
1131         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1132         https://bugs.webkit.org/show_bug.cgi?id=113386
1133
1134         Reviewed by Carlos Garcia Campos.
1135
1136         * Scripts/webkitdirs.pm:
1137         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1138         version to 3.0. Reflect this change so the builtDylibPathForName
1139         function doesn't fail to report the library as found.
1140
1141 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1142
1143         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1144         https://bugs.webkit.org/show_bug.cgi?id=113484
1145
1146         Unreviewed build fix.
1147
1148         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1149
1150         * TestWebKitAPI/CMakeLists.txt:
1151         * WebKitTestRunner/CMakeLists.txt:
1152
1153 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1154
1155         Revision for the internal jhbuild is too old
1156         https://bugs.webkit.org/show_bug.cgi?id=113324
1157
1158         Reviewed by Martin Robinson.
1159
1160         Update the minimum required version to a point where jhbuild won't
1161         fail installing packages when trying to remove a symlink to a directory.
1162
1163         * jhbuild/jhbuild-wrapper: Updated revision.
1164
1165 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1166
1167         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1168         https://bugs.webkit.org/show_bug.cgi?id=113203
1169
1170         Reviewed by Philippe Normand.
1171
1172         We build our libsoup without GNOME support. gst-plugins-good does separate
1173         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1174         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1175         build failures as the headers of those diverge. We do not use souphttpsrc, so
1176         disable it when building gst-plugins-good.
1177
1178         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1179
1180 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1181
1182         Build fix after r146852. Please another reference to the Lion leaks builder.
1183
1184         * BuildSlaveSupport/build.webkit.org-config/config.json:
1185
1186 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1187
1188         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1189         https://bugs.webkit.org/show_bug.cgi?id=113421
1190
1191         Reviewed by Dirk Pranke.
1192
1193         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1194         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1195         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1196         in the GTK-specific TestExpectations files.
1197
1198         To avoid this only enable the warnings only when not using WKTR.
1199
1200         * Scripts/webkitpy/layout_tests/port/gtk.py:
1201         (GtkPort.warn_if_bug_missing_in_test_expectations):
1202
1203 2013-03-27  Antti Koivisto  <antti@apple.com>
1204
1205         Fix Zalan's email.
1206
1207         * Scripts/webkitpy/common/config/committers.py:
1208
1209 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1210
1211         master.cfg cleanup
1212         https://bugs.webkit.org/show_bug.cgi?id=113195
1213
1214         Reviewed by Ryosuke Niwa.
1215
1216         * BuildSlaveSupport/build.webkit.org-config/config.json:
1217         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1218
1219 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1220
1221         master.cfg fine-tuning for Qt Mountain Lion Release bot
1222         https://bugs.webkit.org/show_bug.cgi?id=113191
1223
1224         Reviewed by Ryosuke Niwa.
1225
1226         * BuildSlaveSupport/build.webkit.org-config/config.json:
1227           - Rename the slave due to its location change.
1228           - Update the platform of the slave.
1229         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1230         (RunQtAPITests): Enable running WK2 API tests on Qt.
1231         (RunQtAPITests.start):
1232         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1233         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1234
1235 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1236
1237         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1238         https://bugs.webkit.org/show_bug.cgi?id=113403
1239
1240         Reviewed by Kenneth Rohde Christiansen.
1241
1242         As of Evas 1.7.5, when Wayland is detected on the system, support for
1243         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1244         The code, however, seems to depend on a few other flags which must be
1245         explicitly enabled.
1246
1247         If those additional GL-related options are passed, we end up
1248         having issues on the WebKit side, so disable Wayland support for
1249         now.
1250
1251         * efl/jhbuild.modules:
1252
1253 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1254
1255         Unreviewed, rolling out r146864.
1256         http://trac.webkit.org/changeset/146864
1257         https://bugs.webkit.org/show_bug.cgi?id=113391
1258
1259         causes crashes on Wk2 EFL release bot (Requested by drott on
1260         #webkit).
1261
1262         * Scripts/webkitperl/FeatureList.pm:
1263
1264 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1265
1266         [jhbuild] Correctly specify an alternate number of make jobs.
1267         https://bugs.webkit.org/show_bug.cgi?id=113396
1268
1269         Reviewed by Philippe Normand.
1270
1271         So far, we were using the `MAKEFLAGS' environment variable to pass the
1272         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1273         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1274
1275         We now behave more closely to the rest of the WebKit tools by first
1276         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1277         not set, just letting jhbuild itself figure out how many jobs to use.
1278
1279         * efl/jhbuildrc:
1280         * gtk/jhbuildrc:
1281
1282 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1283
1284         [Qt] Remove Qt specific WorkQueueItem definitions.
1285         https://bugs.webkit.org/show_bug.cgi?id=112891
1286
1287         This patch is preparation work for removing
1288         WorkQueue related code from TestRunnerQt and
1289         replacing it with generic TestRunner code.
1290
1291         Reviewed by Benjamin Poulain.
1292
1293         * DumpRenderTree/qt/TestRunnerQt.cpp:
1294         (TestRunnerQt::queueBackNavigation):
1295         (TestRunnerQt::queueForwardNavigation):
1296         (TestRunnerQt::queueLoadHTMLString):
1297         (TestRunnerQt::queueReload):
1298         (TestRunnerQt::queueLoadingScript):
1299         (TestRunnerQt::queueNonLoadingScript):
1300         (TestRunner::queueLoad):
1301         * DumpRenderTree/qt/TestRunnerQt.h:
1302         (TestRunnerQt):
1303         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1304         (LoadItem::invoke):
1305         (LoadHTMLStringItem::invoke):
1306         (LoadAlternateHTMLStringItem::invoke):
1307         (ReloadItem::invoke):
1308         (ScriptItem::invoke):
1309         (BackForwardItem::invoke):
1310         * DumpRenderTree/qt/WorkQueueItemQt.h:
1311         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1312         (LoadAlternateHTMLStringItem):
1313
1314 2013-03-26  Julie Parent  <jparent@chromium.org>
1315
1316         Flakiness dashboard: simplify logic around which tests to show.
1317         https://bugs.webkit.org/show_bug.cgi?id=113250
1318
1319         Reviewed by Ojan Vafai.
1320         
1321         The different filters for showing results are only used for layout
1322         tests, otherwise, we show everything.
1323         
1324         Change the defaults to false (what layout tests used), and only
1325         look at the values when viewing layout tests.
1326
1327         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1328         (htmlForTestsWithExpectationsButNoFailures):
1329         (shouldHideTest):
1330
1331 2013-03-26  Isaac Levy  <ilevy@google.com>
1332
1333         Update bots on test-results.appspot
1334         https://bugs.webkit.org/show_bug.cgi?id=113333
1335
1336         Reviewed by Ojan Vafai.
1337
1338         * TestResultServer/static-dashboards/builders.jsonp:
1339
1340 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1341
1342         Unreviewed GTK gardening.
1343
1344         * Scripts/run-gtk-tests:
1345         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1346
1347 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1348
1349         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1350         https://bugs.webkit.org/show_bug.cgi?id=113287
1351
1352         Reviewed by Jocelyn Turcotte.
1353
1354         * Scripts/run-qtwebkit-tests:
1355         (Options.__init__):
1356
1357 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1358
1359         [EFL] Enable IndexedDB by default
1360         https://bugs.webkit.org/show_bug.cgi?id=107248
1361
1362         Reviewed by Laszlo Gombos.
1363
1364         * Scripts/webkitperl/FeatureList.pm:
1365         Enable IndexedDB by default on EFL.
1366
1367 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1368
1369         Sheriffbot should explain rollout failures in a human readable form.
1370         https://bugs.webkit.org/show_bug.cgi?id=107092
1371
1372         Reviewed by Ryosuke Niwa.
1373
1374         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1375
1376         * Scripts/webkitpy/tool/bot/irc_command.py:
1377         (Rollout._check_diff_failure):
1378         (Rollout.execute):
1379         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1380         (IRCCommandTest.test_rollout):
1381
1382 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1383
1384         Unreviewed GTK gardening.
1385
1386         * Scripts/run-gtk-tests:
1387         (TestRunner): Skipping a failing unit test after r146518.
1388
1389 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1390
1391         Remove Lion leaks builder
1392         https://bugs.webkit.org/show_bug.cgi?id=113252
1393
1394         Reviewed by Andreas Kling.
1395
1396         Removed.
1397
1398         * BuildSlaveSupport/build.webkit.org-config/config.json:
1399
1400 2013-03-25  Kent Tamura  <tkent@chromium.org>
1401
1402         Rename ENABLE_INPUT_TYPE_DATETIME
1403         https://bugs.webkit.org/show_bug.cgi?id=113254
1404
1405         Reviewed by Kentaro Hara.
1406
1407         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1408         Actually I'd like to remove the code, but we shouldn't remove it yet
1409         because we shipped products with it on some platforms.
1410
1411         * Scripts/webkitperl/FeatureList.pm:
1412         * qmake/mkspecs/features/features.pri:
1413
1414 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1415
1416         Remove one more line that was intended to be removed in r146657.
1417
1418         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1419         (summarize_results):
1420
1421 2013-03-25  Roger Fong  <roger_fong@apple.com>
1422
1423         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1424         Re-enable WinEWS tests.
1425
1426         * Scripts/webkitpy/common/config/ports.py:
1427         (WinPort.run_bindings_tests_command):
1428         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1429         (WinEWS):
1430
1431 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1432
1433         Unreviewed, rolling out r146793.
1434         http://trac.webkit.org/changeset/146793
1435         https://bugs.webkit.org/show_bug.cgi?id=113248
1436
1437         Fix did not work (Requested by rfong on #webkit).
1438
1439         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1440         (WinEWS):
1441
1442 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1443
1444         REGRESSION(r146657): Test failures reported incorrectly
1445         https://bugs.webkit.org/show_bug.cgi?id=113223
1446
1447         Reviewed by Dirk Pranke.
1448
1449         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1450
1451         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1452         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1453
1454         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1455         (Manager.run):
1456
1457         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1458         (RunDetails.__init__):
1459         (summarize_results): Remove the line I intended to remove in r146657.
1460
1461         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1462         (logging_run): Return details instead of the exit code.
1463         (run_and_capture): Ditto.
1464
1465         (RunTest.test_full_results_html):
1466         (RunTest.test_hung_thread):
1467         (RunTest.test_no_tests_found):
1468         (RunTest.test_no_tests_found_2):
1469         (RunTest.test_repeat_each_iterations_num_tests):
1470         (RunTest.test_run_singly_actually_runs_tests):
1471         (RunTest.test_test_list):
1472         (RunTest.test_missing_and_unexpected_results):
1473         (RunTest.test_pixel_test_directories):
1474         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1475         (RunTest.test_crash_with_stderr):
1476         (RunTest.test_no_image_failure_with_image_diff):
1477         (RunTest.test_crash_log):
1478         (RunTest.test_exit_after_n_failures_upload):
1479         (RunTest.test_results_directory_absolute):
1480         (RunTest.test_results_directory_relative):
1481         (RunTest.test_retrying_and_flaky_tests):
1482         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1483         (RunTest.test_retrying_uses_retries_directory):
1484         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1485         (RunTest.test_output_diffs):
1486         (EndToEndTest.test_reftest_with_two_notrefs):
1487         (RebaselineTest.test_reset_results):
1488         (RebaselineTest.test_missing_results):
1489         (RebaselineTest.test_new_baseline):
1490
1491         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1492         (BuildBotPrinter.print_results):
1493         (BuildBotPrinter.print_unexpected_results):
1494         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1495         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1496
1497 2013-03-25  Julie Parent  <jparent@chromium.org>
1498
1499         Dashboard refactor: Move cross dashboard history related code into history.js.
1500         https://bugs.webkit.org/show_bug.cgi?id=113104
1501
1502         Reviewed by Ojan Vafai.
1503
1504         All functions relating to cross dashboard behavior move from being
1505         globals to methods on the history.History object. Names stay the same,
1506         except many are made private, ones that should have been constants now
1507         are, and the long standing TODO to change "currentState" to 
1508         dashboardSpecificState is done.
1509         
1510         We now create a global history object in dashboard_base, as an 
1511         intermediate measure.  Once the dashboard specific code is
1512         added to history, each DB will need to create its own, and this
1513         global will be eliminated.
1514         
1515         * TestResultServer/static-dashboards/aggregate_results.js:
1516         (handleValidHashParameter):
1517         (htmlForBuilder):
1518         (rawValuesHTML):
1519         * TestResultServer/static-dashboards/dashboard_base.js:
1520         (parseDashboardSpecificParameters):
1521         (defaultValue):
1522         (currentBuilderGroupCategory):
1523         (currentBuilderGroupName):
1524         (handleLocationChange):
1525         (expectationsMap):
1526         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1527         (generatePage):
1528         (.switch.return):
1529         (platformAndBuildType):
1530         (individualTests):
1531         (substringList):
1532         (processMissingAndExtraExpectations):
1533         (pathToFailureLog):
1534         (showPopupForBuild):
1535         (htmlForTestsWithExpectationsButNoFailures):
1536         (shouldHideTest):
1537         (isCrossBuilderView):
1538         (tableHeaders):
1539         (htmlForSingleTestRow):
1540         (htmlForTableColumnHeader):
1541         (generatePageForExpectationsUpdate):
1542         (handleUpdate):
1543         (nextUpdate):
1544         (setUpdateIndex):
1545         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
1546         (.appendExpectationsItem):
1547         (loadExpectations):
1548         (.dummyNode.onload):
1549         (loadExpectationsLayoutTests):
1550         (appendExpectations):
1551         (htmlForNavBar):
1552         (checkBoxToToggleState):
1553         (linkHTMLToToggleState):
1554         (generatePageForBuilder):
1555         (isInvalidKeyForCrossBuilderView):
1556         (handleQueryParameterChange):
1557         (showLegend):
1558         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1559         (resetGlobals):
1560         (test):
1561         * TestResultServer/static-dashboards/history.js:
1562         (.):
1563         * TestResultServer/static-dashboards/history_unittests.js:
1564         * TestResultServer/static-dashboards/loader.js:
1565         (.):
1566         * TestResultServer/static-dashboards/loader_unittests.js:
1567         * TestResultServer/static-dashboards/timeline_explorer.js:
1568         (generatePage):
1569         (initCurrentBuilderTestResults):
1570         (selectBuild):
1571         (showResultsDelta):
1572         * TestResultServer/static-dashboards/treemap.js:
1573         (generatePage):
1574         (.switch.return):
1575         (handleFocus):
1576         * TestResultServer/static-dashboards/ui.js:
1577
1578 2013-03-25  Roger Fong  <roger_fong@apple.com>
1579
1580         Unreviewed. Enable WinEWS tests again.
1581
1582         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1583         (WinEWS):
1584
1585 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
1586
1587         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
1588         https://bugs.webkit.org/show_bug.cgi?id=112166
1589
1590         HarfBuzz 0.9.14 merged my patch for icu detection without
1591         pkg-config files, as needed by for example Ubuntu 12.04.
1592         This obsoletes our local workaround. Removed it for GTK and EFL.
1593
1594         Reviewed by Martin Robinson.
1595
1596         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1597         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
1598         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
1599         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
1600
1601 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
1602
1603         Unreviewed.  Move self from contributor to committer list.
1604
1605         * Scripts/webkitpy/common/config/committers.py:
1606
1607 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1608
1609         EWS should use a human readable port name when uploading layout test archives
1610         https://bugs.webkit.org/show_bug.cgi?id=113099
1611
1612         Reviewed by Dirk Pranke.
1613
1614         Use new port's object's name() method to report human readable port names.
1615         This will also help us resolving the bug to apply layout test results posted by EWS.
1616
1617         * Scripts/webkitpy/tool/bot/botinfo.py:
1618         (BotInfo.__init__): Take port's name.
1619         (BotInfo.summary_text):
1620
1621         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1622         (BotInfoTest.test_summary_text):
1623
1624         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1625         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
1626
1627         * Scripts/webkitpy/tool/commands/queues.py:
1628         (PatchProcessingQueue.__init__): Initialize self._port.
1629         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
1630         and use that for the attachment filename and the comment posted.
1631
1632         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1633         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
1634         "mac-snowleopard" as expected for TestPort.
1635
1636 2013-03-22  Roger Fong  <roger_fong@apple.com>
1637
1638         Unreviewed. Turn off EWS test on Win again.
1639         The battle continues.
1640
1641         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1642         (WinEWS):
1643
1644 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
1645
1646         NRWT: Enable pixel tests when retrying tests
1647         https://bugs.webkit.org/show_bug.cgi?id=112898
1648
1649         Reviewed by Dirk Pranke.
1650
1651         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1652         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
1653         if we've forced pixel tests in the retry.
1654         (Manager._run_tests):
1655         (Manager._clean_up_run): Fixed the capitalizations.
1656         (Manager._force_pixel_tests_if_needed): Added.
1657
1658         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1659         (_interpret_test_failures): Now that this function maybe called multiple times, only set
1660         'image_diff_percent' if it doesn't already exist.
1661
1662         (summarize_results): When the first attempt resulted in a text failure and the second attempt
1663         resulted in image and text failures and we've forced to run pixel tests in the retry run,
1664         treat this as a regular regression instead of a flakiness.
1665
1666         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
1667         run had image diffs.
1668
1669         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1670         (summarized_results):
1671
1672         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1673         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
1674         Also removed some dead code.
1675
1676         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
1677         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
1678         is set and pixel_tests_enabled is set to false.
1679         (EndToEndTest.test_reftest_with_two_notrefs):
1680
1681 2013-03-22  Tim Horton  <timothy_horton@apple.com>
1682
1683         Make it possible to run layout tests on Retina MBP
1684         https://bugs.webkit.org/show_bug.cgi?id=93673
1685
1686         Reviewed by Ryosuke Niwa.
1687
1688         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
1689         windows on 2x machines still run at 1x.
1690
1691         * DumpRenderTree/mac/DumpRenderTree.mm:
1692         (createWebViewAndOffscreenWindow):
1693         Reset the window resolution to 1x on creation.
1694         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
1695         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1696         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
1697         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1698         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
1699         (WTR::PlatformWebView::PlatformWebView):
1700         Add NSWindow details, reset the window resolution to 1x on creation.
1701
1702 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1703
1704         Leak bots shouldn't build
1705         https://bugs.webkit.org/show_bug.cgi?id=112774
1706
1707         Reviewed by Simon Fraser.
1708
1709         Since leak bots use regular debug builds, there is no need to build on these bots.
1710         Simply downloading builds will dramatically improve the cycle time of these bots.
1711
1712         * BuildSlaveSupport/build.webkit.org-config/config.json:
1713         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1714         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
1715         TestFactory instead of BuildAndTestFactory.
1716
1717 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
1718
1719         [Qt] Fix the TestWebKitAPI build
1720         https://bugs.webkit.org/show_bug.cgi?id=113044
1721
1722         Reviewed by Tor Arne Vestbø.
1723
1724         The generate-forwarding-headers script would only be run
1725         after the targets in InjectedBundle.pri since the second
1726         addStrictSubdirOrderBetween call in
1727         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
1728         the derived_sources -> injected_bundle order in SUBDIRS.
1729
1730         Fix it by only moving the dependent target at the end of
1731         SUBDIRS, don't touch its dependency.
1732
1733         * qmake/mkspecs/features/functions.prf:
1734
1735 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1736
1737         [EFL][WK2] View is not focused when fullscreen mode toggled
1738         https://bugs.webkit.org/show_bug.cgi?id=113009
1739
1740         Reviewed by Laszlo Gombos.
1741
1742         Set focus on view when fullscreen mode enabled/disabled
1743         by FullScreen API.
1744
1745         * MiniBrowser/efl/main.c:
1746         (on_fullscreen_accept):
1747         (on_fullscreen_deny):
1748
1749 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1750
1751         nrwt is no longer saving retry results in the retries/ subdirectory
1752         https://bugs.webkit.org/show_bug.cgi?id=112995
1753
1754         Reviewed by Ojan Vafai.
1755
1756         I think this has been broken a long time, unfortunately. This
1757         patch should fix that.
1758
1759         In order to do so, I had to pass the directory to use from
1760         the Worker object through the SingleTestWriter to the
1761         TestResultWriter. While I was plumbing that through, I rationalized
1762         the order of the parameter arguments a bit ...
1763
1764         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1765         (Worker._run_single_test):
1766         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1767         (run_single_test):
1768         (SingleTestRunner.__init__):
1769         (SingleTestRunner._run_compare_test):
1770         (SingleTestRunner._run_rebaseline):
1771         (SingleTestRunner._run_reftest):
1772         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1773         (write_test_result):
1774         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1775         (TestResultWriterTest.test_reftest_diff_image):
1776         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1777         (RunTest.test_retrying_uses_retries_directory):
1778
1779 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
1780
1781         JSC profiler should have an at-a-glance report of the success of DFG optimization
1782         https://bugs.webkit.org/show_bug.cgi?id=112988
1783
1784         Reviewed by Geoffrey Garen.
1785
1786         * Scripts/display-profiler-output:
1787
1788 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1789
1790         [chromium] Linux ASAN WebKit canary is running out of memory
1791         https://bugs.webkit.org/show_bug.cgi?id=112978
1792
1793         Reviewed by Tony Chang.
1794
1795         Running the AddressSanitizer on a crash takes a lot of
1796         memory, so we should serialize access to it to avoid running
1797         out of memory on a machine.
1798
1799         * Scripts/webkitpy/layout_tests/port/chromium.py:
1800         (ChromiumPort._get_crash_log):
1801         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1802         (HttpLock.__init__):
1803         (HttpLock.wait_for_httpd_lock):
1804
1805 2013-03-21  Min Qin  <qinmin@chromium.org>
1806
1807         Cleanup android media layout test code
1808         https://bugs.webkit.org/show_bug.cgi?id=112944
1809
1810         Reviewed by Adam Barth.
1811
1812         Chromium change: https://codereview.chromium.org/12892010/
1813         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
1814         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
1815         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
1816         Instead, we should switch to use content shell for layout tests.
1817
1818         * DumpRenderTree/chromium/TestShell.cpp:
1819         (TestShell::resetTestController):
1820
1821 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
1822
1823         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
1824         https://bugs.webkit.org/show_bug.cgi?id=112953
1825
1826         Reviewed by Tony Chang.
1827
1828         When I created the DumpRenderTree_resources target in r144863 I
1829         forgot to declare the needed dependencies on the other resource
1830         targets. Due to a quirk of ordering, this appears to have been fine
1831         w/ ninja but not w/ Xcode (which is still being used on the chromium
1832         mac valgrind bots). Declaring the dependencies fixes the build
1833         failures.
1834
1835         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1836
1837 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
1838
1839         [WinCairo] Correct assert in Empty BitmapImage Test.
1840         https://bugs.webkit.org/show_bug.cgi?id=112934
1841
1842         Reviewed by Tim Horton.
1843
1844         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1845         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
1846         to avoid ref counting assertion when leaving test scope.
1847
1848 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
1849
1850         [GTK] generate-feature-defines-files is incompatible with Python3
1851         https://bugs.webkit.org/show_bug.cgi?id=112956
1852
1853         Reviewed by Martin Robinson.
1854
1855         Make the generate-feature-defines-files compatible with Python3 by calling the items()
1856         method on the dictionary objects when iterating through said dictionaries.
1857
1858         * gtk/generate-feature-defines-files:
1859         (write_feature_defines_header):
1860         (write_flattened_feature_defines_file):
1861
1862 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1863
1864         kill-old-processes spits out error messages on Mac
1865         https://bugs.webkit.org/show_bug.cgi?id=112878
1866
1867         Reviewed by Jessie Berlin.
1868
1869         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1870         included in the list of options grep --help shows.
1871
1872         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1873
1874         * BuildSlaveSupport/kill-old-processes:
1875         (main):
1876
1877 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1878
1879         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1880         https://bugs.webkit.org/show_bug.cgi?id=112597
1881
1882         Reviewed by Xan Lopez.
1883
1884         These were introduced for the Chromium port in r105295. We need
1885         dummy implementations in order to compile the BlackBerry port.
1886
1887         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1888         (AccessibilityUIElement::scrollToMakeVisible):
1889         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1890         (AccessibilityUIElement::scrollToGlobalPoint):
1891
1892 2013-03-21  Roger Fong  <roger_fong@apple.com>
1893
1894         Re-enable WinEWS tests following r146376.
1895
1896         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1897         (WinEWS):
1898
1899 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1900
1901         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1902
1903         * Scripts/webkitpy/common/config/committers.py:
1904
1905 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1906
1907         [GTK] Missing atk in install-dependencies script
1908         https://bugs.webkit.org/show_bug.cgi?id=112272
1909
1910         Reviewed by Gustavo Noronha Silva.
1911
1912         * gtk/install-dependencies: Add missing atk dependency.
1913
1914 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1915
1916         [GTK] Missing backslash in install-dependencies script
1917         https://bugs.webkit.org/show_bug.cgi?id=112907
1918
1919         Reviewed by Philippe Normand.
1920
1921         * gtk/install-dependencies: Add missing backslash to dependencies
1922         list.
1923
1924 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1925
1926         EWS bots have stopped uploading results to bugzilla
1927         https://bugs.webkit.org/show_bug.cgi?id=101091
1928
1929         Reviewed by Adam Barth.
1930
1931         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1932         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1933         this relative file path resoled to a file inside a non-existent directory for "zip".
1934
1935         Fixed the bug by resolving both test results directory and zip archive paths in
1936         LayoutTestResultsReader.archive.
1937
1938         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1939         in the future.
1940
1941         * Scripts/webkitpy/common/system/filesystem_mock.py:
1942         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1943
1944         * Scripts/webkitpy/common/system/workspace.py:
1945         (Workspace.create_zip): Log the source path when "zip" failed.
1946
1947         * Scripts/webkitpy/common/system/workspace_mock.py:
1948         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1949
1950         * Scripts/webkitpy/common/system/workspace_unittest.py:
1951         (WorkspaceTest.test_create_zip_exception): Test that.
1952
1953         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1954         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1955         This is the actual bug fix.
1956
1957         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1958         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1959
1960 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1961
1962         [chromium] move WebThemeEngine implementations to TestRunner library
1963         https://bugs.webkit.org/show_bug.cgi?id=112751
1964
1965         Reviewed by Adam Barth.
1966
1967         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1968         * DumpRenderTree/DumpRenderTree.gypi:
1969         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1970         (WebKit):
1971         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1972         (WebTestRunner::TestInterfaces::themeEngine):
1973         (WebTestRunner):
1974         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1975         (WebKit):
1976         (TestInterfaces):
1977         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1978         (WebTestRunner::WebTestInterfaces::themeEngine):
1979         (WebTestRunner):
1980         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1981         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1982         (WebTestRunner):
1983         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1984         (WebTestRunner::WebTestThemeControlWin::box):
1985         (WebTestRunner::WebTestThemeControlWin::line):
1986         (WebTestRunner::WebTestThemeControlWin::triangle):
1987         (WebTestRunner::WebTestThemeControlWin::roundRect):
1988         (WebTestRunner::WebTestThemeControlWin::oval):
1989         (WebTestRunner::WebTestThemeControlWin::circle):
1990         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1991         (WebTestRunner::WebTestThemeControlWin::markState):
1992         (WebTestRunner::WebTestThemeControlWin::draw):
1993         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1994         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1995         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1996         (WebTestRunner):
1997         (WebTestThemeControlWin):
1998         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1999         (WebTestRunner):
2000         (WebTestThemeEngineMac):
2001         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2002         (+[FakeActiveWindow alwaysActiveWindow]):
2003         (+[FakeActiveWindow alwaysInactiveWindow]):
2004         (-[FakeActiveWindow initWithActiveControls:]):
2005         (-[FakeActiveWindow _hasActiveControls]):
2006         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2007         (WebTestRunner):
2008         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2009         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2010         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2011         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2012         (WebTestRunner):
2013         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2014         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2015         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2016         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2017         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2018         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2019         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2020         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2021         (WebTestRunner::WebTestThemeEngineWin::getSize):
2022         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2023         (WebTestRunner):
2024         (WebTestThemeEngineWin):
2025         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2026         * DumpRenderTree/chromium/TestShell.cpp:
2027         (TestShell::initialize):
2028         * DumpRenderTree/chromium/TestShell.h:
2029         (WebKit):
2030         * DumpRenderTree/chromium/TestShellMac.mm:
2031         (platformInit):
2032         * DumpRenderTree/chromium/TestShellWin.cpp:
2033         (platformInit):
2034         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2035
2036 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2037
2038         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2039
2040         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2041         New property sheet that does not link against CoreFoundation and
2042         CFNetwork.
2043         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2044         Use new TestWebKitAPICommonWinCairo property sheet.
2045         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2046         Ditto.
2047
2048 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2049
2050         [WinCairo] Unreviewed build fix for VS2010.
2051
2052         Had to add WinCairo-specific property sheets to deal with some
2053         library and path differences with the main Apple port.
2054
2055         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2056         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2057         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2058         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2059         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2060         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2061
2062 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2063
2064         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2065         https://bugs.webkit.org/show_bug.cgi?id=112849
2066
2067         Reviewed by Sam Weinig.
2068
2069         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2070         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2071         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2072
2073 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2074
2075         [WinCairo] Build WebKit Tools under VS2010
2076         https://bugs.webkit.org/show_bug.cgi?id=112821
2077
2078         Reviewed by Tim Horton.
2079
2080         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2081         Add WinCairo-specific build target.
2082         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2083         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2084         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2085         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2086         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2087         Add WinCairo-specific build target.
2088         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2089         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2090         Add WinCairo-specific build target.
2091         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2092         WinCairo-specific build target.
2093         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2094         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2095         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2096         specific build target.
2097         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2098         WinCairo-specific build target.
2099         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2100         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2101         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2102
2103 2013-03-20  Roger Fong  <roger_fong@apple.com>
2104
2105         API test gardening AppleWin port.
2106
2107         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2108
2109         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2110         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2111
2112 2013-03-20  Roger Fong  <roger_fong@apple.com>
2113
2114         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2115
2116         * EWSTools/start-queue-win.sh:
2117
2118 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2119
2120         Unreviewed, add myself to committers.py.
2121
2122 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2123
2124         Unreviewed. Adding another email for me.
2125
2126         * Scripts/webkitpy/common/config/committers.py:
2127
2128 2013-03-20  Justin Novosad  <junov@google.com>
2129
2130         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2131         https://bugs.webkit.org/show_bug.cgi?id=112605
2132
2133         Reviewed by James Robinson.
2134
2135         Deleting all the code that was used for propagating and supporting
2136         the Chromium setting for disabling deferred 2d canvas rendering.
2137
2138         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2139         (main):
2140         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2141         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2142         (WebTestRunner::WebPreferences::reset):
2143         (WebTestRunner::WebPreferences::applyTo):
2144         * DumpRenderTree/chromium/TestShell.cpp:
2145         (TestShell::TestShell):
2146         (TestShell::resetWebSettings):
2147         (TestShell::runFileTest):
2148         * DumpRenderTree/chromium/TestShell.h:
2149         (TestShell):
2150
2151 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2152
2153         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2154         https://bugs.webkit.org/show_bug.cgi?id=112699.
2155
2156         Reviewed by Adam Barth.
2157
2158         * Scripts/webkitpy/layout_tests/port/qt.py:
2159         (QtPort._search_paths):
2160         (QtPort._port_specific_expectations_files):
2161         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2162         (QtPortTest):
2163         (QtPortTest._assert_search_path):
2164         (QtPortTest._assert_expectations_files):
2165
2166 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2167
2168         [Qt] Enable kerning by default
2169         https://bugs.webkit.org/show_bug.cgi?id=112704
2170
2171         Reviewed by Jocelyn Turcotte.
2172
2173         Disable kerning by default, since some reference test expectations
2174         expect kerning to be default off.
2175
2176         * DumpRenderTree/qt/TestRunnerQt.cpp:
2177         (TestRunnerQt::reset):
2178         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2179         (WTR::activateFonts):
2180
2181 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2182
2183         [Qt] Remove empty function stubs from TestRunnerQt.
2184         https://bugs.webkit.org/show_bug.cgi?id=112799
2185
2186         We are reducing the code in TestRunnerQt step by step,
2187         in order to finally replace all of it with the generic
2188         TestRunner implementation.
2189         This patch removes several simple function stubs that
2190         currently do not implement any actual functionality.
2191
2192         Reviewed by Kenneth Rohde Christiansen.
2193
2194         * DumpRenderTree/qt/TestRunnerQt.cpp:
2195         * DumpRenderTree/qt/TestRunnerQt.h:
2196         (TestRunnerQt):
2197
2198 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2199
2200         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2201         https://bugs.webkit.org/show_bug.cgi?id=112687
2202
2203         Reviewed by Kenneth Rohde Christiansen.
2204
2205         Hide the SearchBar by default on window creation.
2206
2207         * MiniBrowser/efl/main.c:
2208         (window_create):
2209
2210 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2211
2212         Unreviewed, rolling out r146304.
2213         http://trac.webkit.org/changeset/146304
2214         https://bugs.webkit.org/show_bug.cgi?id=112788
2215
2216         to many expectations to update (Requested by antonm on
2217         #webkit).
2218
2219         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2220         * DumpRenderTree/DumpRenderTree.gypi:
2221         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2222         (WebKit):
2223         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2224         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2225         (TestInterfaces):
2226         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2227         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2228         * DumpRenderTree/chromium/TestShell.cpp:
2229         (TestShell::initialize):
2230         * DumpRenderTree/chromium/TestShell.h:
2231         (WebKit):
2232         * DumpRenderTree/chromium/TestShellMac.mm:
2233         (platformInit):
2234         * DumpRenderTree/chromium/TestShellWin.cpp:
2235         (platformInit):
2236         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2237         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2238         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2239         (WebThemeControlDRTWin::box):
2240         (WebThemeControlDRTWin::line):
2241         (WebThemeControlDRTWin::triangle):
2242         (WebThemeControlDRTWin::roundRect):
2243         (WebThemeControlDRTWin::oval):
2244         (WebThemeControlDRTWin::circle):
2245         (WebThemeControlDRTWin::nestedBoxes):
2246         (WebThemeControlDRTWin::markState):
2247         (WebThemeControlDRTWin::draw):
2248         (WebThemeControlDRTWin::drawTextField):
2249         (WebThemeControlDRTWin::drawProgressBar):
2250         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2251         (WebThemeControlDRTWin):
2252         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2253         (WebThemeEngineDRTMac):
2254         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2255         (+[FakeActiveWindow alwaysActiveWindow]):
2256         (+[FakeActiveWindow alwaysInactiveWindow]):
2257         (-[FakeActiveWindow initWithActiveControls:]):
2258         (-[FakeActiveWindow _hasActiveControls]):
2259         (WebThemeEngineDRTMac::paintScrollbarThumb):
2260         (stateToHIEnableState):
2261         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2262         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2263         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2264         (webRectToSkIRect):
2265         (drawControl):
2266         (drawTextField):
2267         (drawProgressBar):
2268         (WebThemeEngineDRTWin::paintButton):
2269         (WebThemeEngineDRTWin::paintMenuList):
2270         (WebThemeEngineDRTWin::paintScrollbarArrow):
2271         (WebThemeEngineDRTWin::paintScrollbarThumb):
2272         (WebThemeEngineDRTWin::paintScrollbarTrack):
2273         (WebThemeEngineDRTWin::paintSpinButton):
2274         (WebThemeEngineDRTWin::paintTextField):
2275         (WebThemeEngineDRTWin::paintTrackbar):
2276         (WebThemeEngineDRTWin::paintProgressBar):
2277         (WebThemeEngineDRTWin::getSize):
2278         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2279         (WebThemeEngineDRTWin):
2280         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2281
2282 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2283
2284         [Qt] Support -webkit-font-smoothing
2285         https://bugs.webkit.org/show_bug.cgi?id=106009
2286
2287         Reviewed by Jocelyn Turcotte.
2288
2289         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2290
2291         * DumpRenderTree/qt/TestRunnerQt.cpp:
2292         (TestRunnerQt::reset):
2293
2294 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2295
2296         [GTK] accessibility/aria-scrollbar-role.html is failing
2297         https://bugs.webkit.org/show_bug.cgi?id=98358
2298
2299         Reviewed by Martin Robinson.
2300
2301         Adds support for checking accessibility object's orientation.
2302         Orientation is checked by retrieving proper state of accessibility object.
2303
2304         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2305         (checkElementState):
2306         (AccessibilityUIElement::orientation):
2307         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2308         (WTR::AccessibilityUIElement::orientation):
2309
2310 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2311
2312         [chromium] move WebThemeEngine implementations to TestRunner library
2313         https://bugs.webkit.org/show_bug.cgi?id=112751
2314
2315         Reviewed by Adam Barth.
2316
2317         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2318         * DumpRenderTree/DumpRenderTree.gypi:
2319         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2320         (WebKit):
2321         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2322         (WebTestRunner::TestInterfaces::themeEngine):
2323         (WebTestRunner):
2324         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2325         (WebKit):
2326         (TestInterfaces):
2327         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2328         (WebTestRunner::WebTestInterfaces::themeEngine):
2329         (WebTestRunner):
2330         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2331         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2332         (WebTestRunner):
2333         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2334         (WebTestRunner::WebTestThemeControlWin::box):
2335         (WebTestRunner::WebTestThemeControlWin::line):
2336         (WebTestRunner::WebTestThemeControlWin::triangle):
2337         (WebTestRunner::WebTestThemeControlWin::roundRect):
2338         (WebTestRunner::WebTestThemeControlWin::oval):
2339         (WebTestRunner::WebTestThemeControlWin::circle):
2340         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2341         (WebTestRunner::WebTestThemeControlWin::markState):
2342         (WebTestRunner::WebTestThemeControlWin::draw):
2343         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2344         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2345         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2346         (WebTestRunner):
2347         (WebTestThemeControlWin):
2348         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2349         (WebTestRunner):
2350         (WebTestThemeEngineMac):
2351         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2352         (+[FakeActiveWindow alwaysActiveWindow]):
2353         (+[FakeActiveWindow alwaysInactiveWindow]):
2354         (-[FakeActiveWindow initWithActiveControls:]):
2355         (-[FakeActiveWindow _hasActiveControls]):
2356         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2357         (WebTestRunner):
2358         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2359         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2360         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2361         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2362         (WebTestRunner):
2363         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2364         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2365         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2366         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2367         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2368         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2369         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2370         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2371         (WebTestRunner::WebTestThemeEngineWin::getSize):
2372         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2373         (WebTestRunner):
2374         (WebTestThemeEngineWin):
2375         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2376         * DumpRenderTree/chromium/TestShell.cpp:
2377         (TestShell::initialize):
2378         * DumpRenderTree/chromium/TestShell.h:
2379         (WebKit):
2380         * DumpRenderTree/chromium/TestShellMac.mm:
2381         (platformInit):
2382         * DumpRenderTree/chromium/TestShellWin.cpp:
2383         (platformInit):
2384         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2385
2386 2013-03-19  Tony Chang  <tony@chromium.org>
2387
2388         Move testRunner.setTouchDragDropEnabled to internals.settings
2389         https://bugs.webkit.org/show_bug.cgi?id=112739
2390
2391         Reviewed by Adam Barth.
2392
2393         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2394         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2395         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2396         (TestRunner): Remove unnecessary code.
2397         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2398         (WebTestRunner::WebPreferences::reset):
2399         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2400
2401 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2402
2403         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2404         https://bugs.webkit.org/show_bug.cgi?id=112754
2405
2406         Reviewed by Darin Fisher.
2407
2408         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2409         now that it's always defined.
2410
2411         * DumpRenderTree/chromium/WebViewHost.cpp:
2412         * DumpRenderTree/chromium/WebViewHost.h:
2413         (WebViewHost):
2414
2415 2013-03-19  Kenneth Russell  <kbr@google.com>
2416
2417         Unreviewed, rolling out r146290.
2418         http://trac.webkit.org/changeset/146290
2419         https://bugs.webkit.org/show_bug.cgi?id=112751
2420
2421         Broke Chromium Mac build.
2422
2423         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2424         * DumpRenderTree/DumpRenderTree.gypi:
2425         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2426         (WebKit):
2427         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2428         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2429         (TestInterfaces):
2430         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2431         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2432         * DumpRenderTree/chromium/TestShell.cpp:
2433         (TestShell::initialize):
2434         * DumpRenderTree/chromium/TestShell.h:
2435         (WebKit):
2436         * DumpRenderTree/chromium/TestShellMac.mm:
2437         (platformInit):
2438         * DumpRenderTree/chromium/TestShellWin.cpp:
2439         (platformInit):
2440         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2441         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2442         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2443         (WebThemeControlDRTWin::box):
2444         (WebThemeControlDRTWin::line):
2445         (WebThemeControlDRTWin::triangle):
2446         (WebThemeControlDRTWin::roundRect):
2447         (WebThemeControlDRTWin::oval):
2448         (WebThemeControlDRTWin::circle):
2449         (WebThemeControlDRTWin::nestedBoxes):
2450         (WebThemeControlDRTWin::markState):
2451         (WebThemeControlDRTWin::draw):
2452         (WebThemeControlDRTWin::drawTextField):
2453         (WebThemeControlDRTWin::drawProgressBar):
2454         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2455         (WebThemeControlDRTWin):
2456         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2457         (WebThemeEngineDRTMac):
2458         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2459         (+[FakeActiveWindow alwaysActiveWindow]):
2460         (+[FakeActiveWindow alwaysInactiveWindow]):
2461         (-[FakeActiveWindow initWithActiveControls:]):
2462         (-[FakeActiveWindow _hasActiveControls]):
2463         (WebThemeEngineDRTMac::paintScrollbarThumb):
2464         (stateToHIEnableState):
2465         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2466         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2467         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2468         (webRectToSkIRect):
2469         (drawControl):
2470         (drawTextField):
2471         (drawProgressBar):
2472         (WebThemeEngineDRTWin::paintButton):
2473         (WebThemeEngineDRTWin::paintMenuList):
2474         (WebThemeEngineDRTWin::paintScrollbarArrow):
2475         (WebThemeEngineDRTWin::paintScrollbarThumb):
2476         (WebThemeEngineDRTWin::paintScrollbarTrack):
2477         (WebThemeEngineDRTWin::paintSpinButton):
2478         (WebThemeEngineDRTWin::paintTextField):
2479         (WebThemeEngineDRTWin::paintTrackbar):
2480         (WebThemeEngineDRTWin::paintProgressBar):
2481         (WebThemeEngineDRTWin::getSize):
2482         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2483         (WebThemeEngineDRTWin):
2484         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2485
2486 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2487
2488         [EFL] canvas-fallback-content.html is failing
2489         https://bugs.webkit.org/show_bug.cgi?id=111998
2490
2491         Reviewed by Chris Fleizach.
2492
2493         Adds support for getting platform name.
2494
2495         * DumpRenderTree/TestRunner.cpp:
2496         (TestRunner::staticValues):
2497         * DumpRenderTree/TestRunner.h:
2498         (TestRunner):
2499         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2500         (TestRunner::platformName):
2501
2502 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2503
2504         [chromium] move WebThemeEngine implementations to TestRunner library
2505         https://bugs.webkit.org/show_bug.cgi?id=112751
2506
2507         Reviewed by Adam Barth.
2508
2509         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2510         * DumpRenderTree/DumpRenderTree.gypi:
2511         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2512         (WebKit):
2513         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2514         (WebTestRunner::TestInterfaces::themeEngine):
2515         (WebTestRunner):
2516         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2517         (WebKit):
2518         (TestInterfaces):
2519         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2520         (WebTestRunner::WebTestInterfaces::themeEngine):
2521         (WebTestRunner):
2522         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2523         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2524         (WebTestRunner):
2525         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2526         (WebTestRunner::WebTestThemeControlWin::box):
2527         (WebTestRunner::WebTestThemeControlWin::line):
2528         (WebTestRunner::WebTestThemeControlWin::triangle):
2529         (WebTestRunner::WebTestThemeControlWin::roundRect):
2530         (WebTestRunner::WebTestThemeControlWin::oval):
2531         (WebTestRunner::WebTestThemeControlWin::circle):
2532         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2533         (WebTestRunner::WebTestThemeControlWin::markState):
2534         (WebTestRunner::WebTestThemeControlWin::draw):
2535         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2536         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2537         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2538         (WebTestRunner):
2539         (WebTestThemeControlWin):
2540         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2541         (WebTestRunner):
2542         (WebTestThemeEngineMac):
2543         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2544         (+[FakeActiveWindow alwaysActiveWindow]):
2545         (+[FakeActiveWindow alwaysInactiveWindow]):
2546         (-[FakeActiveWindow initWithActiveControls:]):
2547         (-[FakeActiveWindow _hasActiveControls]):
2548         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2549         (WebTestRunner):
2550         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2551         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2552         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2553         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2554         (WebTestRunner):
2555         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2556         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2557         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2558         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2559         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2560         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2561         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2562         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2563         (WebTestRunner::WebTestThemeEngineWin::getSize):
2564         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2565         (WebTestRunner):
2566         (WebTestThemeEngineWin):
2567         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2568         * DumpRenderTree/chromium/TestShell.cpp:
2569         (TestShell::initialize):
2570         * DumpRenderTree/chromium/TestShell.h:
2571         (WebKit):
2572         * DumpRenderTree/chromium/TestShellMac.mm:
2573         (platformInit):
2574         * DumpRenderTree/chromium/TestShellWin.cpp:
2575         (platformInit):
2576         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2577
2578 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2579
2580         [EFL][WK2] Separate WebView further from EwkView
2581         https://bugs.webkit.org/show_bug.cgi?id=111591
2582
2583         Reviewed by Caio Marcelo de Oliveira Filho.
2584
2585         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
2586         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
2587         since we can afford it having EWKViewGetWKView() private API to access WKView.
2588
2589         * TestWebKitAPI/PlatformWebView.h:
2590         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2591         (TestWebKitAPI::TEST):
2592         * TestWebKitAPI/efl/PlatformWebView.cpp:
2593         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2594         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2595         (TestWebKitAPI::PlatformWebView::resizeTo):
2596         (TestWebKitAPI::PlatformWebView::page):
2597         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2598         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2599         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2600         * WebKitTestRunner/PlatformWebView.h:
2601         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2602         (WTR::EventSenderProxy::dispatchEvent):
2603         (WTR::EventSenderProxy::keyDown):
2604         (WTR::EventSenderProxy::sendTouchEvent):
2605         (WTR::EventSenderProxy::setTouchModifier):
2606         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2607         (WTR::PlatformWebView::PlatformWebView):
2608         (WTR::PlatformWebView::~PlatformWebView):
2609         (WTR::PlatformWebView::resizeTo):
2610         (WTR::PlatformWebView::page):
2611         (WTR::PlatformWebView::focus):
2612         (WTR::PlatformWebView::windowSnapshotImage):
2613
2614 2013-03-19  Roger Fong  <roger_fong@apple.com>
2615
2616         Changes to VS2010 project files should only trigger builds on Windows bots.
2617         https://bugs.webkit.org/show_bug.cgi?id=112731
2618
2619         Reviewed by Timothy Horton.
2620
2621         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2622         (_should_file_trigger_build):
2623
2624 2013-03-19  Roger Fong  <roger_fong@apple.com>
2625
2626         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
2627
2628         * Scripts/webkitpy/tool/steps/runtests.py:
2629         (RunTests.run):
2630         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2631         (RunTestsTest.test_webkit_run_unit_tests):
2632
2633 2013-03-19  Julie Parent  <jparent@chromium.org>
2634
2635         Dashboards: Introduce history namespace and unit tests.
2636         https://bugs.webkit.org/show_bug.cgi?id=112645
2637
2638         Reviewed by Ojan Vafai.
2639         
2640         Laying the framework for introducing the new history object and
2641         namespace.  This moves only static functions into the history
2642         namespace, and moves corresponding unit tests into seperate
2643         unit test file.
2644
2645         * TestResultServer/static-dashboards/aggregate_results.html:
2646         * TestResultServer/static-dashboards/dashboard_base.js:
2647         (parseCrossDashboardParameters):
2648         (parseDashboardSpecificParameters):
2649         (parseParameters):
2650         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2651         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2652         (.switch.return):
2653         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2654         * TestResultServer/static-dashboards/history.js: Added.
2655         * TestResultServer/static-dashboards/history_unittests.js: Added.
2656         * TestResultServer/static-dashboards/loader.js:
2657         (.):
2658         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2659         * TestResultServer/static-dashboards/run-unittests.html:
2660         * TestResultServer/static-dashboards/timeline_explorer.html:
2661         * TestResultServer/static-dashboards/timeline_explorer.js:
2662         * TestResultServer/static-dashboards/treemap.html:
2663         * TestResultServer/static-dashboards/treemap.js:
2664         (.switch.return):
2665         * TestResultServer/static-dashboards/ui.js:
2666
2667 2013-03-19  Daniel Bates  <dbates@webkit.org>
2668
2669         svn-apply has trouble applying a patch that adds a Windows newline to EOF
2670         https://bugs.webkit.org/show_bug.cgi?id=112732
2671
2672         Reviewed by Eric Seidel.
2673
2674         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
2675         of an existing file cannot be applied.
2676
2677         In particular, svn-{apply, unapply} compensate for differences in line endings
2678         by converting the line endings in a diff to match the line endings in the target
2679         file. The diff(1) command precedes the last line of a diff that adds a newline
2680         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
2681         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
2682         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
2683         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
2684         the newline characters in this special character sequence to match the line endings
2685         in the target file.
2686
2687         * Scripts/VCSUtils.pm:
2688         (parseDiff):
2689         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
2690         Added tests:
2691             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2692             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2693             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
2694             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
2695         (escapeNewLineCharacters): Added.
2696         (toMacLineEndings): Added.
2697
2698 2013-03-19  James Robinson  <jamesr@chromium.org>
2699
2700         [chromium] Remove compositor settings that don't go through WebKit
2701         https://bugs.webkit.org/show_bug.cgi?id=112718
2702
2703         Reviewed by Adam Barth.
2704
2705         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2706         (main):
2707         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2708         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2709         (WebTestRunner::WebPreferences::reset):
2710         (WebTestRunner::WebPreferences::applyTo):
2711         * DumpRenderTree/chromium/TestShell.cpp:
2712         (TestShell::TestShell):
2713         (TestShell::resetWebSettings):
2714         * DumpRenderTree/chromium/TestShell.h:
2715         (TestShell):
2716
2717 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
2718
2719         Unreviewed, rolling out r146101.
2720         https://bugs.webkit.org/show_bug.cgi?id=111884
2721
2722         re-enable custom freetype on asan; this needs to be on
2723         now that the bot is running lucid.
2724
2725         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2726
2727 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
2728
2729         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
2730         https://bugs.webkit.org/show_bug.cgi?id=112365
2731
2732         Reviewed by Benjamin Poulain.
2733
2734         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
2735         harcoding it in wtf/Platform.h
2736
2737         * Scripts/webkitperl/FeatureList.pm:
2738
2739 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2740
2741         [Qt] Make ImageDiff similar to Chromium's ImageDiff
2742         https://bugs.webkit.org/show_bug.cgi?id=94782
2743
2744         Based on patch by Csaba Osztrogonác.
2745         Reviewed by Jocelyn Turcotte.
2746
2747         The diff image is generated with bright red indicating errors, but letting the base image
2748         shine through so the context of the error-pixel can be identified.
2749
2750         * DumpRenderTree/qt/ImageDiff.cpp:
2751         (main):
2752
2753 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
2754
2755         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
2756
2757         Rubber-stamped by Csaba Osztrogonác.
2758
2759         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
2760         since the latter might not cover the former.
2761
2762         * QtTestBrowser/launcherwindow.cpp:
2763         (LauncherWindow::print):
2764
2765 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2766
2767         Style tweeks to default.css.
2768         
2769         Rubber-stamped by David Kilzer.
2770         
2771         Give visited links a different color to other links, so you can
2772         see which builds you've viewed.
2773         
2774         Make the <small> text less tiny.
2775
2776         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2777         (small):
2778         (a:link,a:visited,a:active):
2779         (a:visited):
2780
2781 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2782
2783         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
2784         https://bugs.webkit.org/show_bug.cgi?id=112494
2785
2786         Reviewed by Dirk Pranke.
2787
2788         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
2789         Also merged two pairs of methods to cleanup the code.
2790
2791         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2792         (PerfTestsRunner.run): Merged _upload_and_show_results.
2793         (PerfTestsRunner._generate_results): Merged _generate_output_files.
2794
2795 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2796
2797         [chromium] build xdisplaycheck when building DRT
2798         https://bugs.webkit.org/show_bug.cgi?id=112636
2799
2800         Reviewed by Tony Chang.
2801
2802         It appears that we need xdisplaycheck to be built in order for
2803         Xvfb to be started correctly on the bots, and DRT was missing
2804         a dependency on it. This may be the cause of the ASAN bot not
2805         starting up properly (it only builds DRT).
2806
2807         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2808
2809 2013-03-18  David Levin  <levin@chromium.org>
2810
2811         Implement icon change notification dump for Chromium's test shell.
2812         https://bugs.webkit.org/show_bug.cgi?id=112614
2813
2814         This was previously implemented for some other platforms in r58111
2815         and r116547.
2816
2817         In r122806, fast/dom/icon-url-property.html stopped using it, but
2818         it is useful for tests, so I plan to re-add it to that test again.
2819
2820         Reviewed by Jochen Eisinger.
2821
2822         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2823         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
2824          icon change notifications from WebKit may be logged in test output.
2825         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2826         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
2827         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
2828         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
2829         (WebTestRunner):
2830         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
2831         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2832         (TestRunner):
2833         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2834         (WebTestRunner::WebTestProxyBase::didChangeIcon):
2835         (WebTestRunner):
2836         * DumpRenderTree/chromium/WebViewHost.cpp:
2837         (WebViewHost::didChangeIcon): Add the output about changing the icon.
2838         * DumpRenderTree/chromium/WebViewHost.h:
2839         (WebViewHost):
2840
2841 2013-03-18  Julie Parent  <jparent@chromium.org>
2842
2843         Cleanup: Move js for treemap and aggregate_results into own js files.
2844         https://bugs.webkit.org/show_bug.cgi?id=112618
2845
2846         Reviewed by Dirk Pranke.
2847         
2848         No functional changes, just moving the code into separate js file
2849         rather than inlined in the html, so we can test it, make it more
2850         modular, etc.  Other dashboard types are already done this way.
2851
2852         * TestResultServer/static-dashboards/aggregate_results.html:
2853         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
2854         (generatePage):
2855         (handleValidHashParameter):
2856         (htmlForBuilder):
2857         (rawValuesHTML):
2858         (chartHTML):
2859         (filteredValues):
2860         (chart):
2861         (htmlForRevisionRows):
2862         (wrapHTMLInTable):
2863         (htmlForSummaryTable):
2864         (valuesPerExpectation):
2865         (htmlForTestType):
2866         (htmlForTableRow):
2867         (extendedEncode):
2868         * TestResultServer/static-dashboards/treemap.html:
2869         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2870         (humanReadableTime):
2871         (convertToWebTreemapFormat):
2872         (reverseSortByAverage):
2873         (generatePage):
2874         (focusPath):
2875         (.switch.return):
2876         (handleQueryParameterChange):
2877         (extractName):
2878         (fullName):
2879         (handleFocus.):
2880         (handleFocus):
2881
2882 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2883
2884         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2885         https://bugs.webkit.org/show_bug.cgi?id=112622
2886
2887         Reviewed by Dirk Pranke.
2888
2889         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2890         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2891
2892 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2893
2894         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2895         https://bugs.webkit.org/show_bug.cgi?id=112619
2896
2897         Reviewed by Dirk Pranke.
2898
2899         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2900         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2901
2902         * Scripts/webkitpy/layout_tests/port/gtk.py:
2903         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2904         Port._webkit_baseline_path method.
2905         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2906         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2907         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2908         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2909         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2910         that are expected based on the builder name.
2911
2912 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2913
2914         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2915         https://bugs.webkit.org/show_bug.cgi?id=112571
2916
2917         Reviewed by Adam Barth.
2918
2919         Update function declarations for new WebFileSystemType enum. (All
2920         changes are behind an #ifdef so we can sync required changes in embedders.)
2921
2922         * DumpRenderTree/chromium/WebViewHost.cpp:
2923         (WebViewHost::openFileSystem):
2924         (WebViewHost::deleteFileSystem):
2925         * DumpRenderTree/chromium/WebViewHost.h:
2926         (WebViewHost):
2927
2928 2013-03-18  Julie Parent  <jparent@chromium.org>
2929
2930         Cleanup: Move timeline_exporer js out of html file into js.
2931         https://bugs.webkit.org/show_bug.cgi?id=112188
2932
2933         Reviewed by Dirk Pranke.
2934         
2935         Moves the javascript out of the html file and into a new js file.
2936         This follows the format of flakiness_dashboard.{html|js}.
2937         
2938         Also moves code from dashboard_base that is used only by this one
2939         dashboard, and makes it private to the dashboard.
2940
2941         * TestResultServer/static-dashboards/dashboard_base.js:
2942         * TestResultServer/static-dashboards/timeline_explorer.html:
2943         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2944         (generatePage):
2945         (initCurrentBuilderTestResults):
2946         (shouldShowWebKitRevisionsOnly):
2947         (updateTimelineForBuilder.):
2948         (updateTimelineForBuilder):
2949         (selectBuild):
2950         (updateBuildIndicator):
2951         (.addRow):
2952         (.addNumberRow):
2953         (.inspectorNode.getElementsByTagName.0.onclick):
2954         (.inspectorNode.getElementsByTagName.1.onclick):
2955         (.inspectorNode.getElementsByTagName.2.onclick):
2956         (updateBuildInspector):
2957         (showResultsDelta):
2958         (decompressResults.addFlakyDelta):
2959         (decompressResults):
2960
2961 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2962
2963         Unreviewed, rolling out r145272.
2964         http://trac.webkit.org/changeset/145272
2965         https://bugs.webkit.org/show_bug.cgi?id=111884
2966
2967         Turns out the ASAN build is still broken; possibly there's
2968         something still setting LD_LIBRARY_PATH, or possibly there's
2969         something else wrong. In the meantime, we need it to work again.
2970
2971         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2972
2973 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2974
2975         delete-stale-build-files is too aggressive
2976         https://bugs.webkit.org/show_bug.cgi?id=112595
2977
2978         Reviewed by Tim Horton.
2979
2980         It appears that whitelisting file extensions to keep is not a good idea.
2981         Blacklist files to delete instead, and only delete .o files for now.
2982         We can add more file extensions as needed.
2983
2984         * BuildSlaveSupport/delete-stale-build-files:
2985
2986 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2987
2988         Disable accessibility notifications after each test
2989         https://bugs.webkit.org/show_bug.cgi?id=112579
2990
2991         Reviewed by Tim Horton.
2992         
2993         In WebKitTestRunner, if any tests triggered accessibility notifications,
2994         the global notification handler would thereafter be active, and fire
2995         notifications for all subsequent tests.
2996         
2997         Fix by implementing AccessibilityController::resetToConsistentState() for
2998         Mac, and using it to clear the global notification handler.
2999
3000         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3001         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3002         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3003         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3004         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3005         (e.g. because of -autorelease).
3006         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3007         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3008         if there is one.
3009         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3010         Add -stopObserving
3011         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3012         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3013         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3014         center.
3015
3016 2013-03-18  Dana Jansens  <danakj@chromium.org>
3017
3018         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3019         https://bugs.webkit.org/show_bug.cgi?id=112392
3020
3021         Reviewed by James Robinson.
3022
3023         Removes the command line flag option from DRT.
3024
3025         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3026         (main):
3027
3028 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3029
3030         [GTK] plugins/plugin-clip-subframe.html is failing
3031         https://bugs.webkit.org/show_bug.cgi?id=112570
3032
3033         Reviewed by Martin Robinson.
3034
3035         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3036
3037 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3038
3039         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3040         https://bugs.webkit.org/show_bug.cgi?id=112442
3041
3042         Reviewed by Gustavo Noronha Silva.
3043
3044         * GtkLauncher/main.c:
3045         (reloadCb):
3046         (createToolbar):
3047         (createWindow):
3048
3049 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3050
3051         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3052         https://bugs.webkit.org/show_bug.cgi?id=112205
3053
3054         Disable this API test until Geoff can fix it.
3055
3056         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3057         (TestWebKitAPI::TEST):
3058
3059 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3060
3061         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3062         https://bugs.webkit.org/show_bug.cgi?id=112478
3063
3064         Reviewed by Tony Chang.
3065
3066         There is nothing that ensures that the log messages from the plugin
3067         come in before the layout test finished loading.
3068
3069         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3070         (PassDifferentNPPStruct::NPP_SetWindow):
3071         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3072         (NPP_SetWindow):
3073
3074 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3075
3076         Have the mac port support per_test_timeout in webkitpy
3077         https://bugs.webkit.org/show_bug.cgi?id=112466
3078
3079         Reviewed by Dirk Pranke.
3080         
3081         Both WTR and DRT handle --timeout arguments, so we can
3082         have the scripts pass the timeout values down to the tools.
3083
3084         * Scripts/webkitpy/layout_tests/port/mac.py:
3085         (MacPort.supports_per_test_timeout):
3086
3087 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3088
3089         Remove setAsynchronousSpellCheckingEnabled from test runners
3090         https://bugs.webkit.org/show_bug.cgi?id=112362
3091
3092         Reviewed by Tony Chang.
3093
3094         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3095         in internals.settings, so all ports can share it.
3096
3097         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3098         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3099         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3100         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3101         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3102         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3103         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3104         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3105         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3106         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3107         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3108         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3109
3110 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3111
3112         Fix the stupid unit tests.
3113
3114         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3115         (test_sample_process):
3116
3117 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3118
3119         Collect samples for unresponsive web processes
3120         https://bugs.webkit.org/show_bug.cgi?id=112409
3121
3122         Reviewed by Tim Horton.
3123         
3124         When we detect that a subprocess was unresponsive, run the 'sample'
3125         tool on that process, for the Mac port.
3126         
3127         The sample will be linked to from the results.html page, next
3128         to the crash log link.
3129
3130         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3131         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3132         look for samples on disk.
3133         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3134         (TestResultWriter):
3135         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3136         -sample.txt files, and have it copy their contents to a new file
3137         next to the test that spawned them (as we do for crash logs).
3138         * Scripts/webkitpy/layout_tests/port/base.py:
3139         (Port.look_for_new_samples): Base class does nothing for sampling.
3140         * Scripts/webkitpy/layout_tests/port/driver.py:
3141         (Driver._check_for_driver_crash): Kick off a sample if we detected
3142         that the subprocess was unresponsive.
3143         * Scripts/webkitpy/layout_tests/port/mac.py:
3144         (MacPort.sample_file_path): Utility to generate the file path
3145         to the generated sample files at the top level of layout-test-results.
3146         (MacPort.look_for_new_crash_logs): Fix typo
3147         (MacPort.look_for_new_samples): New function to find sample files.
3148         (MacPort.sample_process): Use the utility function to get the file path.
3149
3150 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3151
3152         [Qt] Remove simple getters and setters from TestRunnerQt
3153         https://bugs.webkit.org/show_bug.cgi?id=112343
3154
3155         Reviewed by Benjamin Poulain.
3156
3157         The removed functions and boolean members
3158         are being replaced by the implementations in the
3159         generic TestRunner.h.
3160
3161         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3162         (DumpRenderTree::dumpFrameScrollPosition):
3163         (DumpRenderTree::dumpFramesAsText):
3164         (DumpRenderTree::dump):
3165         (DumpRenderTree::titleChanged):
3166         (DumpRenderTree::dumpDatabaseQuota):
3167         (DumpRenderTree::dumpApplicationCacheQuota):
3168         (DumpRenderTree::statusBarMessage):
3169         (DumpRenderTree::createWindow):
3170         * DumpRenderTree/qt/TestRunnerQt.cpp:
3171         (TestRunnerQt::reset):
3172         * DumpRenderTree/qt/TestRunnerQt.h:
3173         (TestRunnerQt):
3174
3175 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3176
3177         Update the link on build.webkit.org to refer to perf.webkit.org
3178         https://bugs.webkit.org/show_bug.cgi?id=112416
3179
3180         Reviewed by Philip Rogers.
3181
3182         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3183
3184         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3185
3186 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3187
3188         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3189         https://bugs.webkit.org/show_bug.cgi?id=112394
3190
3191         Reviewed by Philippe Normand.
3192
3193         * GtkLauncher/main.c:
3194         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3195
3196 2013-03-14  Andreas Kling  <akling@apple.com>
3197
3198         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3199         <http://webkit.org/b/111815>
3200         <rdar://problem/13380145>
3201
3202         Reviewed by Anders Carlsson.
3203
3204         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3205         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3206         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3207
3208         * WebKitTestRunner/PlatformWebView.h:
3209         (PlatformWebView):
3210         * WebKitTestRunner/TestController.cpp:
3211         (WTR::TestController::createOtherPage):
3212         (WTR::TestController::createWebViewWithOptions):
3213         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3214         (WTR::PlatformWebView::didInitializeClients):
3215
3216 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3217
3218         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3219         https://bugs.webkit.org/show_bug.cgi?id=112122
3220
3221         Reviewed by Kenneth Rohde Christiansen.
3222
3223         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3224
3225         * MiniBrowser/efl/main.c:
3226         (_Browser_Window):
3227         (search_box_show):
3228         (search_box_hide):
3229         (on_key_down):
3230         (on_url_changed):
3231         (on_search_field_aborted):
3232         (on_search_field_activated):
3233         (on_search_field_clicked):
3234         (on_search_backward_button_clicked):
3235         (on_search_forward_button_clicked):
3236         (window_create):
3237
3238 2013-03-14  Julie Parent  <jparent@chromium.org>
3239
3240         Cleanup: Remove g_resourceLoader.
3241         https://bugs.webkit.org/show_bug.cgi?id=112305
3242
3243         Reviewed by Dirk Pranke.
3244         
3245         Removing another global.
3246         
3247         Now, each dashboard creates its own loader, rather than having
3248         a general global one.
3249         
3250         Remove usage of g_resourceLoader.isLoadingComplete from 
3251         handleLocationChange by ensuring that handleLocationChange is
3252         never called before the loader is done.  It was called in two
3253         places before: 1 was from the callback when the loader is done,
3254         so that was obviously true, and the other was from onhashchange,
3255         where it would just return rather than running.  Instead, lets
3256         only register the onhashchange handler once the loader is
3257         setup, so the check is no longer necessary.
3258         
3259         Remove isLoadingComplete since it is now unused.
3260         
3261         Callback for loader is now initializeHistory, rather than just
3262         handleLocationChange which will set up the hashchange handler now.
3263         This will all eventually be moving to a new History object.
3264
3265         * TestResultServer/static-dashboards/aggregate_results.html:
3266         * TestResultServer/static-dashboards/dashboard_base.js:
3267         (handleLocationChange):
3268         (intializeHistory):
3269         (decompressResults):
3270         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3271         (generatePage):
3272         * TestResultServer/static-dashboards/loader.js:
3273         (.):
3274         * TestResultServer/static-dashboards/loader_unittests.js:
3275         * TestResultServer/static-dashboards/timeline_explorer.html:
3276         * TestResultServer/static-dashboards/treemap.html:
3277
3278 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3279
3280         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3281         https://bugs.webkit.org/show_bug.cgi?id=109404
3282
3283         Reviewed by Tony Chang.
3284
3285         Removes all the code related to smartInsertDeleteEnabled and
3286         selectTrailingWhitespaceEnabled settings as they will be managed from
3287         internals from now on.
3288
3289         * DumpRenderTree/TestRunner.cpp:
3290         (TestRunner::staticFunctions):
3291         * DumpRenderTree/TestRunner.h:
3292         (TestRunner):
3293         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3294         (WebKit):
3295         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3296         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3297         (DumpRenderTree):
3298         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3299         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3300         (WebTestRunner::WebTestProxy::didStopLoading):
3301         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3302         (WebTestRunner::TestRunner::TestRunner):
3303         (WebTestRunner::TestRunner::reset):
3304         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3305         (TestRunner):
3306         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3307         (WebTestRunner::WebPreferences::applyTo): Set default values for
3308         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3309         Chromium DRT default values are different from Chromium browser.
3310         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3311         * DumpRenderTree/chromium/WebViewHost.cpp:
3312         * DumpRenderTree/chromium/WebViewHost.h:
3313         (WebViewHost):
3314         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3315         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3316         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3317         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3318         (resetDefaultsToConsistentValues):
3319         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3320         * DumpRenderTree/mac/DumpRenderTree.mm:
3321         (resetWebViewToConsistentStateBeforeTesting):
3322         * DumpRenderTree/mac/TestRunnerMac.mm:
3323         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3324         (WebCore::WebPage::resetSettings):
3325         * DumpRenderTree/qt/TestRunnerQt.cpp:
3326         * DumpRenderTree/qt/TestRunnerQt.h:
3327         (TestRunnerQt):
3328         * DumpRenderTree/win/DumpRenderTree.cpp:
3329         (resetWebViewToConsistentStateBeforeTesting):
3330         * DumpRenderTree/win/TestRunnerWin.cpp:
3331         * DumpRenderTree/wx/TestRunnerWx.cpp:
3332
3333 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3334
3335         [Qt] Disable DRT on Windows
3336
3337         Reviewed by Jocelyn Turcotte.
3338
3339         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3340
3341         * qmake/mkspecs/features/configure.prf:
3342
3343 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3344
3345         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3346         https://bugs.webkit.org/show_bug.cgi?id=110728
3347
3348         Reviewed by Gyuyoung Kim.
3349
3350         Use the page group to create the view object.
3351
3352         * MiniBrowser/efl/main.c:
3353         (window_create):
3354
3355 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3356
3357         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3358
3359         Reviewed by Tor Arne Vestbø.
3360
3361         The mock versions of these web facing features should be instantiated when
3362         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3363         such as QtLocation are actually needed.
3364
3365         This patch decouples enabling device orientation/motion and geolocation from
3366         the underlying Qt modules and makes them available in developer builds
3367         (!production_build) and backed by mock backends when running in drt.
3368
3369         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3370         developers the web facing features are always enabled (although requests will
3371         time out) and the mock backends are enabled inside DRT, allowing for the layout
3372         tests to run with less dependencies.
3373
3374         In addition this also enables the mock device motion client, which was
3375         previously never instantiated.
3376
3377         * qmake/mkspecs/features/features.prf:
3378
3379 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3380
3381         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3382         https://bugs.webkit.org/show_bug.cgi?id=112340
3383
3384         Reviewed by Simon Hausmann.
3385
3386         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3387         (DumpRenderTree::dump):
3388             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3389         (DumpRenderTree::dumpApplicationCacheQuota):
3390         * DumpRenderTree/qt/TestRunnerQt.cpp:
3391         (TestRunnerQt::reset):
3392         * DumpRenderTree/qt/TestRunnerQt.h:
3393         (TestRunnerQt):
3394
3395 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3396
3397         [Qt] Port DRT to use TestRunner::dumpAsText()
3398         https://bugs.webkit.org/show_bug.cgi?id=112260
3399
3400         Reviewed by Benjamin Poulain.
3401
3402         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3403         (WebCore::DumpRenderTree::open):
3404         (WebCore::methodNameStringForFailedTest):
3405             Change parameter from type TestRunnerQt* to TestRunner*.
3406         (WebCore::DumpRenderTree::dump):
3407             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3408             Instead we should rely on TestRunner::generatePixelResults().
3409         * DumpRenderTree/qt/TestRunnerQt.cpp:
3410         (TestRunnerQt::reset):
3411         * DumpRenderTree/qt/TestRunnerQt.h:
3412         (TestRunnerQt):
3413
3414 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3415
3416         Implement FontLoader interface
3417         https://bugs.webkit.org/show_bug.cgi?id=98395
3418
3419         Reviewed by Eric Seidel.
3420
3421         Enable FontLoadEvents runtime flag for TestShell.
3422
3423         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3424         (WebTestRunner::TestInterfaces::TestInterfaces):
3425
3426 2013-03-13  Julie Parent  <jparent@chromium.org>
3427
3428         CLeanup: remove unnecessary call to parseParameters.
3429         https://bugs.webkit.org/show_bug.cgi?id=112309
3430
3431         Reviewed by Ojan Vafai.
3432         
3433         We call parseCrossDashboardParameters when the dashboard initially
3434         loads to set the state required for loadBuildersList, and then we
3435         call it again once we are fully done with loading, so there is no
3436         reason to call it in the middle of the loading process here.
3437
3438         * TestResultServer/static-dashboards/loader.js:
3439         (.):
3440
3441 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
3442
3443         Unreviewed. Now I'm a reviewer :)
3444
3445         * Scripts/webkitpy/common/config/committers.py:
3446
3447 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
3448
3449         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
3450         https://bugs.webkit.org/show_bug.cgi?id=112277
3451
3452         Reviewed by Adam Barth.
3453
3454         * Scripts/webkitperl/FeatureList.pm:
3455         * qmake/mkspecs/features/features.pri:
3456
3457 2013-03-13  Adam Barth  <abarth@webkit.org>
3458
3459         run-perf-tests should support content_shell
3460         https://bugs.webkit.org/show_bug.cgi?id=112291
3461
3462         Reviewed by Eric Seidel.
3463
3464         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3465         (PerfTestsRunner._parse_args):
3466
3467 2013-03-13  Oliver Hunt  <oliver@apple.com>
3468
3469         Simplify Checked<> multiplication
3470         https://bugs.webkit.org/show_bug.cgi?id=112286
3471
3472         Reviewed by James Robinson.
3473
3474         Add tests for multiplication by zero and max to ensure we don't
3475         mess them up should we ever make changes to Checked<> in future.
3476
3477         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3478         (TestWebKitAPI):
3479
3480 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3481
3482         [Qt] Unreviewed prospective Windows build fix
3483
3484         Do the usual thing, include the moc generated code in the .cpp file instead
3485         of compiling it standalone, to ensure that config.h is included, too, and
3486         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
3487
3488         * DumpRenderTree/qt/EventSenderQt.cpp:
3489
3490 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3491
3492         [Qt] Port TestRunner::findString to shared interface
3493         https://bugs.webkit.org/show_bug.cgi?id=112147
3494
3495         Reviewed by Jocelyn Turcotte.
3496
3497         This patch also removes DumpRenderTree and some other helper classes from
3498         the WebCore namespace, to which they do not really belong.
3499
3500         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3501         (main):
3502         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3503         (DumpRenderTree::DumpRenderTree):
3504         (DumpRenderTree::~DumpRenderTree):
3505         (DumpRenderTree::instance):
3506         (DumpRenderTree::setShouldTimeout):
3507         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3508         (DumpRenderTree):
3509         * DumpRenderTree/qt/EventSenderQt.cpp:
3510         (EventSender::contextClick):
3511         (EventSender::sendEvent):
3512         (EventSender::postEvent):
3513         * DumpRenderTree/qt/EventSenderQt.h:
3514         (EventSender::isGraphicsBased):
3515         * DumpRenderTree/qt/TestRunnerQt.cpp:
3516         (TestRunnerQt::TestRunnerQt):
3517         (TestRunner::findString):
3518         (TestRunnerQt::setMockDeviceOrientation):
3519         (TestRunnerQt::setGeolocationPermission):
3520         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3521         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3522         (TestRunnerQt::setMockGeolocationPosition):
3523         * DumpRenderTree/qt/TestRunnerQt.h:
3524         (TestRunnerQt):
3525
3526 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
3527
3528         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
3529         https://bugs.webkit.org/show_bug.cgi?id=112129
3530
3531         Reviewed by Adam Barth.
3532
3533         Following Chromium
3534         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
3535         this is being renamed to better explain what it does.
3536
3537         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3538
3539 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
3540
3541         [Qt] Unreviewed trivial typo fix
3542
3543         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
3544         TextRunner.h. Thanks Zeno :)
3545
3546 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
3547
3548         [Qt] Prepare DRT for transition to shared TestRunner interface
3549         https://bugs.webkit.org/show_bug.cgi?id=112144
3550
3551         Reviewed by Benjamin Poulain.
3552
3553         Prepare Qt's DRT for a transition from the QObject based TestRunner to
3554         the JSC C API based one.
3555
3556         This is impplemented by instantiating the QObject based testRunner in
3557         the global object, then instantiating the JSC C based TestRunner
3558         separately and placing it "behind" the QObject based testRunner through
3559         injection of the individual functions through proxies. (prototype
3560         chaining doesn't work due to the this object and Function.prototype.bind
3561         doesn't work due to the native function)
3562
3563         This allows for porting over method by method by removing the method
3564         from the QObject TestRunnerQt and implementing it in the JSC C based
3565         TestRunner.
3566
3567         In order for this to link and run dummy implementations of all the
3568         necessary TestRunner functions are provided.
3569
3570         * DumpRenderTree/qt/DumpRenderTree.pro:
3571         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3572         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3573         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3574         (WebCore::DumpRenderTree::initJSObjects):
3575         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3576         (DumpRenderTree):
3577         * DumpRenderTree/qt/TestRunnerQt.cpp:
3578         (TestRunner::~TestRunner):
3579         (TestRunner::addDisallowedURL):
3580         (TestRunner::queueLoad):
3581         (TestRunner::removeAllVisitedLinks):
3582         (TestRunner::setAcceptsEditing):
3583         (TestRunner::simulateLegacyWebNotificationClick):
3584         (TestRunner::setWindowIsKey):
3585         (TestRunner::setAlwaysAcceptCookies):
3586         (TestRunner::addOriginAccessWhitelistEntry):
3587         (TestRunner::setWebViewEditable):
3588         (TestRunner::clearAllApplicationCaches):
3589         (TestRunner::setTextDirection):
3590         (TestRunner::notifyDone):
3591         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3592         (TestRunner::overridePreference):
3593         (TestRunner::pathToLocalResource):
3594         (TestRunner::removeAllWebNotificationPermissions):
3595         (TestRunner::simulateWebNotificationClick):
3596         (TestRunner::closeIdleLocalStorageDatabases):
3597         (TestRunner::focusWebView):
3598         (TestRunner::setBackingScaleFactor):
3599         (TestRunner::removeChromeInputField):
3600         (TestRunner::addChromeInputField):
3601         (TestRunner::originsWithLocalStorage):
3602         (TestRunner::deleteAllLocalStorage):
3603         (TestRunner::deleteLocalStorageForOrigin):
3604         (TestRunner::observeStorageTrackerNotifications):
3605         (TestRunner::syncLocalStorage):
3606         (TestRunner::windowCount):
3607         (TestRunner::setWaitToDump):
3608         (TestRunner::waitForPolicyDelegate):
3609         (TestRunner::webHistoryItemCount):
3610         (TestRunner::showWebInspector):
3611         (TestRunner::closeWebInspector):
3612         (TestRunner::evaluateInWebInspector):
3613         (TestRunner::setSerializeHTTPLoads):
3614         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3615         (TestRunner::setCustomPolicyDelegate):
3616         (TestRunner::setDatabaseQuota):
3617         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3618         (TestRunner::resetPageVisibility):
3619         (TestRunner::keepWebHistory):
3620         (TestRunner::goBack):
3621         (TestRunner::originsWithApplicationCache):
3622         (TestRunner::applicationCacheDiskUsageForOrigin):
3623         (TestRunner::display):
3624         (TestRunner::dispatchPendingLoadRequests):
3625         (TestRunner::clearPersistentUserStyleSheet):
3626         (TestRunner::callShouldCloseOnWebView):
3627         (TestRunner::copyDecodedHostName):
3628         (TestRunner::clearBackForwardList):
3629         (TestRunner::clearAllDatabases):
3630         (TestRunner::clearApplicationCacheForOrigin):
3631         (TestRunner::apiTestGoToCurrentBackForwardItem):
3632         (TestRunner::authenticateSession):
3633         (TestRunner::abortModal):
3634         (TestRunner::setStorageDatabaseIdleInterval):
3635         (TestRunner::setAsynchronousSpellCheckingEnabled):
3636         (TestRunner::setXSSAuditorEnabled):
3637         (TestRunner::setSpatialNavigationEnabled):
3638         (TestRunner::setScrollbarPolicy):
3639         (TestRunner::setJavaScriptCanAccessClipboard):
3640         (TestRunner::setAutomaticLinkDetectionEnabled):
3641         (TestRunner::setUserStyleSheetEnabled):
3642         (TestRunner::setUserStyleSheetLocation):
3643         (TestRunner::setUseDashboardCompatibilityMode):
3644         (TestRunner::setTabKeyCyclesThroughElements):
3645         (TestRunner::setSmartInsertDeleteEnabled):
3646         (TestRunner::setSelectTrailingWhitespaceEnabled):
3647         (TestRunner::setPrivateBrowsingEnabled):
3648         (TestRunner::setPluginsEnabled):
3649         (TestRunner::setPopupBlockingEnabled):
3650         (TestRunner::setMockSpeechInputDumpRect):
3651         (TestRunner::setPersistentUserStyleSheetLocation):
3652         (TestRunner::setMockGeolocationPosition):
3653         (TestRunner::setMockGeolocationPositionUnavailableError):
3654         (TestRunner::setMockDeviceOrientation):
3655         (TestRunner::setMainFrameIsFirstResponder):
3656         (TestRunner::setIconDatabaseEnabled):
3657         (TestRunner::setGeolocationPermission):
3658         (TestRunner::setDefersLoading):
3659         (TestRunner::setCacheModel):
3660         (TestRunner::setAuthorAndUserStylesEnabled):
3661         (TestRunner::setAllowFileAccessFromFileURLs):
3662         (TestRunner::setAppCacheMaximumSize):
3663         (TestRunner::setAllowUniversalAccessFromFileURLs):
3664         (TestRunner::setApplicationCacheOriginQuota):
3665         (TestRunner::denyWebNotificationPermission):
3666         (TestRunner::grantWebNotificationPermission):
3667         (TestRunner::setValueForUser):
3668         (TestRunner::setViewModeMediaFeature):
3669         (TestRunner::setPageVisibility):
3670         (TestRunner::addMockSpeechInputResult):
3671         (TestRunner::removeOriginAccessWhitelistEntry):
3672         (TestRunner::addUserScript):
3673         (TestRunner::isCommandEnabled):
3674         (TestRunner::evaluateScriptInIsolatedWorld):
3675         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
3676         (TestRunner::copyEncodedHostName):
3677         (TestRunner::addUserStyleSheet):
3678         (TestRunner::findString):
3679         (TestRunner::execCommand):
3680         (TestRunner::localStorageDiskUsageForOrigin):
3681
3682 2013-03-12  Julie Parent  <jparent@chromium.org>
3683
3684         Cleanup: Move flatten-trie to loader.
3685         https://bugs.webkit.org/show_bug.cgi?id=112196
3686
3687         Reviewed by Dirk Pranke.
3688
3689         flatten-trie is used only by the loader, so move it there and make it
3690         private, rather than global in dashbaord_base. Moved the corresponding
3691         unit test from flakiness_dashboard_unittests to loader_unittests.
3692         
3693         * TestResultServer/static-dashboards/dashboard_base.js:
3694         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3695         * TestResultServer/static-dashboards/loader.js:
3696         (.):
3697         * TestResultServer/static-dashboards/loader_unittests.js:
3698
3699 2013-03-12  Oliver Hunt  <oliver@apple.com>
3700
3701         Unbreak api tests
3702
3703         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3704         (TestWebKitAPI):
3705
3706 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3707
3708         Unreviewed, disabling tests for Win EWS.
3709
3710         win-ews obviously cannot keep up with running tests, it's >300 behind.
3711         Probably doesn't help that its (likely) running tests serially.
3712
3713         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3714         (WinEWS):
3715
3716 2013-03-12  Tim Horton  <timothy_horton@apple.com>
3717
3718         Add a --build-directory argument to delete-stale-build-files
3719         https://bugs.webkit.org/show_bug.cgi?id=112198
3720
3721         Reviewed by Ryosuke Niwa.
3722
3723         * BuildSlaveSupport/delete-stale-build-files:
3724         (main): Add --build-directory argument.
3725
3726 2013-03-12  Oliver Hunt  <oliver@apple.com>
3727
3728         Appease MSVC
3729
3730         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3731         (TestWebKitAPI):
3732
3733 2013-03-12  Oliver Hunt  <oliver@apple.com>
3734
3735         Add more Checked<> tests
3736         https://bugs.webkit.org/show_bug.cgi?id=112190
3737
3738         Reviewed by Geoffrey Garen.
3739
3740         Tests!
3741
3742         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3743         (TestWebKitAPI):
3744
3745 2013-03-12  Julie Parent  <jparent@chromium.org>
3746
3747         Cleanup: Move loading complete function into callback, rather than global.
3748         https://bugs.webkit.org/show_bug.cgi?id=112167
3749
3750         Reviewed by Dirk Pranke.
3751         
3752         Stop calling global functions, pass in proper handler to Loader
3753         constructor. Note that the callback is optional, as tests, and
3754         some potential dashboards, do not need one.
3755
3756         * TestResultServer/static-dashboards/dashboard_base.js:
3757         * TestResultServer/static-dashboards/loader.js:
3758         (.):
3759         * TestResultServer/static-dashboards/loader_unittests.js:
3760
3761 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3762
3763         [EFL][WK2] Add popup menu support to MiniBrowser
3764         https://bugs.webkit.org/show_bug.cgi?id=108934
3765
3766         Reviewed by Kenneth Rohde Christiansen.
3767
3768         Implement popup menu support in MiniBrowser by handling popup_menu_show
3769         and popup_menu_hide smart functions on the view and using the Ewk popup
3770         menu API.
3771
3772         * MiniBrowser/efl/main.c:
3773         (_Browser_Window):
3774         (on_popup_menu_discarded):
3775         (on_popup_menu_item_clicked):
3776         (popup_menu_populate):
3777         (on_popup_menu_show):
3778         (on_popup_menu_hide):
3779         (window_create): Use calloc() instead of malloc() to allocate memory for
3780         Browser_Window. This makes sure all the structs members are initialized
3781         to 0 (such as the new elm_popup_menu pointer).
3782
3783 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3784
3785         [GTK] Set up the libPlatformGtk.la library
3786         https://bugs.webkit.org/show_bug.cgi?id=111738
3787
3788         Reviewed by Martin Robinson.
3789
3790         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3791         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
3792         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
3793
3794 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
3795
3796         [GTK] Enable Web Audio in development builds
3797         https://bugs.webkit.org/show_bug.cgi?id=111831
3798
3799         Reviewed by Philippe Normand.
3800
3801         Web Audio is already quite well supported on the GTK port but still has a few issues
3802         that must be addressed before it is enabled by default. Despite that it should be enabled
3803         in development builds just so we are up-to-date with future feature infrastructure changes.
3804         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3805         that's an obvious goal before enabling the feature in release builds.
3806
3807         * Scripts/webkitperl/FeatureList.pm:
3808
3809 2013-03-11  Andreas Kling  <akling@apple.com>
3810
3811         [Mac][WK1] Add support for alert() in MiniBrowser.
3812         <http://webkit.org/b/112090>
3813
3814         Reviewed by Anders Carlsson.
3815
3816         * MiniBrowser/mac/WK1BrowserWindowController.m:
3817         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3818
3819 2013-03-11  Julie Parent  <jparent@chromium.org>
3820
3821         Dashboard cleanup: Create ui.Errors
3822         https://bugs.webkit.org/show_bug.cgi?id=111785
3823
3824         Reviewed by Ojan Vafai.
3825         
3826         Create ui.Errors for handling errors the dashboards
3827         encounter. Loader now has a Error object that it can add to,
3828         and individual dashboards can show errors when desired.
3829         Currently, only flakiness_db shows errors, but this is 
3830         generic and there is no reason why other dbs wouldn't want to
3831         show errors.
3832
3833         * TestResultServer/static-dashboards/dashboard_base.js:
3834         (resourceLoadingComplete):
3835         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3836         (generatePage):
3837         * TestResultServer/static-dashboards/loader.js:
3838         (.):
3839         * TestResultServer/static-dashboards/ui.js:
3840         (.):
3841
3842 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
3843
3844         Some StringHasher tests are broken because of missing null termination
3845         https://bugs.webkit.org/show_bug.cgi?id=111284
3846
3847         Reviewed by Darin Adler.
3848
3849         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3850         (TestWebKitAPI): Added null termination since C strings are null-terminated.
3851         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
3852         the bug caught by it is now fixed.
3853
3854 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3855
3856         Unreviewed, rolling out r145200.
3857         http://trac.webkit.org/changeset/145200
3858         https://bugs.webkit.org/show_bug.cgi?id=112063
3859
3860         Broke a couple of unit tests (Requested by zdobersek on
3861         #webkit).
3862
3863         * Scripts/webkitperl/FeatureList.pm:
3864
3865 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3866
3867         [GTK] WebKit2-only build fails
3868         https://bugs.webkit.org/show_bug.cgi?id=112033
3869
3870         Reviewed by Gustavo Noronha Silva.
3871
3872         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3873         generic part, WebKit1-specific part and WebKit2-specific part.
3874         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3875         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3876         directly.
3877
3878 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3879
3880         Adding myself to the committers list.
3881
3882         Unreviewed.
3883
3884         * Scripts/webkitpy/common/config/committers.py:
3885
3886 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3887
3888         [BlackBerry] Disable MathML support
3889         https://bugs.webkit.org/show_bug.cgi?id=111929
3890
3891         Reviewed by Rob Buis.
3892
3893         * Scripts/webkitperl/FeatureList.pm:
3894
3895 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3896
3897         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3898         https://bugs.webkit.org/show_bug.cgi?id=111970
3899
3900         Reviewed by Chris Fleizach.
3901
3902         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3903         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3904         undefined symbol.
3905
3906         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3907         (WTR::AccessibilityUIElement::supportedActions):
3908         (WTR):
3909
3910 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3911
3912         [chromium] Android apk targets should depend directly on Java library targets
3913         https://bugs.webkit.org/show_bug.cgi?id=111746
3914
3915         Reviewed by Eric Seidel.
3916
3917         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3918         Make DumpRenderTree_apk depend directly on base_java and net_java.
3919         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3920         Make TestWebKitAPI_apk depend directly on base_java.
3921
3922 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3923
3924         [chromium] remove obsolete user gesture methods from WebFrame
3925         https://bugs.webkit.org/show_bug.cgi?id=111696
3926
3927         Reviewed by Adam Barth.
3928
3929         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3930         (WebTestRunner::TestPlugin::handleInputEvent):
3931         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3932
3933 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3934
3935         Unreviewed, add myself to commiters.py.
3936
3937         * Scripts/webkitpy/common/config/committers.py:
3938
3939 2013-03-08  Julie Parent  <jparent@chromium.org>
3940
3941         Cleanup: Remove dead code.
3942         https://bugs.webkit.org/show_bug.cgi?id=111900
3943
3944         Reviewed by Dirk Pranke.
3945         
3946         Treemap overrides a global function that used to be in 
3947         dashboard_base, but was removed months ago in
3948         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
3949         no caller. 
3950
3951         * TestResultServer/static-dashboards/treemap.html:
3952
3953 2013-03-08  Harald Alvestrand  <hta@chromium.org>
3954
3955         Implemented new API for RTCStatsReport object.
3956         https://bugs.webkit.org/show_bug.cgi?id=110333
3957
3958         Reviewed by Adam Barth.
3959
3960         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3961         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3962
3963 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
3964
3965         [chromium] use custom freetype on linux asan builds again
3966         https://bugs.webkit.org/show_bug.cgi?id=111884
3967
3968         Reviewed by Tony Chang.
3969
3970         We no longer need the workaround after chromium r186540.
3971
3972         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3973
3974 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
3975
3976         Warning about the user not having edit rights on Bugzilla is confusing new contributors
3977         https://bugs.webkit.org/show_bug.cgi?id=111798
3978
3979         Reviewed by Dirk Pranke.
3980
3981         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
3982
3983         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3984
3985 2013-03-08  James Robinson  <jamesr@chromium.org>
3986
3987         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
3988         https://bugs.webkit.org/show_bug.cgi?id=111632
3989
3990         Reviewed by Adrienne Walker.
3991
3992         * DumpRenderTree/chromium/WebViewHost.cpp:
3993         (WebViewHost::initializeLayerTreeView):
3994         * DumpRenderTree/chromium/WebViewHost.h:
3995         (WebViewHost):
3996
3997 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
3998
3999         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
4000         https://bugs.webkit.org/show_bug.cgi?id=111297
4001
4002         Reviewed by Kenneth Rohde Christiansen.
4003
4004         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4005         (WTR::TestRunner::setViewModeMediaFeature):
4006
4007 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
4008
4009         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
4010         https://bugs.webkit.org/show_bug.cgi?id=111814
4011
4012         Reviewed by Ryosuke Niwa.
4013
4014         Add the needed supportedActions() attribute to WKTestRunner.
4015
4016         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4017         (WTR::AccessibilityUIElement::supportedActions):
4018         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4019         (AccessibilityUIElement):
4020         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4021         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4022         (WTR::AccessibilityUIElement::supportedActions):
4023
4024 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4025
4026         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
4027         https://bugs.webkit.org/show_bug.cgi?id=111851
4028
4029         Reviewed by Kenneth Rohde Christiansen.
4030
4031         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
4032         (TestWebKitAPI::TEST):
4033
4034             Fixed WKURLRef instance leaking.
4035
4036 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4037
4038         [EFL] [WK2] Some authentication tests fail in WebKit2
4039         https://bugs.webkit.org/show_bug.cgi?id=106407
4040
4041         Reviewed by Kenneth Rohde Christiansen.
4042
4043         Add patch from upstream for libsoup 2.40 to fix several authentication
4044         test cases.
4045
4046         * efl/jhbuild.modules:
4047         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
4048
4049 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
4050
4051         [GTK] Enable Web Audio in development builds
4052         https://bugs.webkit.org/show_bug.cgi?id=111831
4053
4054         Reviewed by Philippe Normand.
4055
4056         Web Audio is already quite well supported on the GTK port but still has a few issues
4057         that must be addressed before it is enabled by default. Despite that it should be enabled
4058         in development builds just so we are up-to-date with future feature infrastructure changes.
4059         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
4060         that's an obvious goal before enabling the feature in release builds.
4061
4062         * Scripts/webkitperl/FeatureList.pm:
4063
4064 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
4065
4066         [chromium] delay clearing the TestRunners until the main view was deleted
4067         https://bugs.webkit.org/show_bug.cgi?id=111823
4068
4069         Reviewed by Eric Seidel.
4070
4071         During WebViewHost::shutdown, we navigate the WebView to about:blank.
4072         This may call into the test runners which assume that the delegate is
4073         always non-NULL.
4074
4075         * DumpRenderTree/chromium/TestShell.cpp:
4076         (TestShell::~TestShell):
4077
4078 2013-03-07  Alan Cutter  <alancutter@chromium.org>
4079
4080         Sheriffbot whois command can't search by full name
4081         https://bugs.webkit.org/show_bug.cgi?id=111825
4082
4083         Reviewed by Eric Seidel.
4084
4085         Allowed multiple arguments to Sheriffbot's whois command.
4086         Updated test expectations.
4087
4088         * Scripts/webkitpy/tool/bot/irc_command.py:
4089         (Whois.execute):
4090         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
4091         (IRCCommandTest.test_whois):
4092
4093 2013-03-07  Nils Barth  <nbarth@chromium.org>
4094
4095         Add Nils Barth and Koji Hara to committers.py
4096         https://bugs.webkit.org/show_bug.cgi?id=111806
4097
4098         Reviewed by Eric Seidel.
4099
4100         * Scripts/webkitpy/common/config/committers.py:
4101
4102 2013-03-07  Glenn Adams  <glenn@skynav.com>
4103
4104         run-pert-tests should have a --test-runner-count option
4105         https://bugs.webkit.org/show_bug.cgi?id=111726
4106
4107         Reviewed by Ryosuke Niwa.
4108
4109         Add --test-runner-count option to run-perf-tests, with default value of 4.
4110         This option allows command line configuration of the number of times to invoke
4111         the test runner (serially, not in parallel) when running a specific test in
4112         a test set.
4113
4114         * Scripts/webkitpy/performance_tests/perftest.py:
4115         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
4116         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
4117         (PerfTest.run): Rename process_run_count to test_runner_count.
4118         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
4119         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
4120         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
4121         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
4122         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4123         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
4124         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
4125         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
4126         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
4127         (MainTest.test_run_with_repeat):
4128         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
4129         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4130         (MainTest.test_default_args): Add test for default option argument values.
4131         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
4132
4133 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
4134
4135         Add myself to reviewers.py
4136         https://bugs.webkit.org/show_bug.cgi?id=111757
4137
4138         Reviewed by Eric Seidel.
4139
4140         * Scripts/webkitpy/common/config/committers.py:
4141
4142 2013-03-07  Glenn Adams  <glenn@skynav.com>
4143
4144         run-perf-tests should have a --repeat option
4145         https://bugs.webkit.org/show_bug.cgi?id=100030
4146
4147         Reviewed by Ryosuke Niwa.
4148
4149         Add --repeat option to run-perf-tests, with default value of 1. When greater
4150         than 1, runs test set specified number of times. Note that multiple runs are
4151         not aggregated for statistical purposes.
4152
4153         Incidentally fixed typo: s/suceeds/succeeds/.
4154
4155         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4156         (PerfTestsRunner._parse_args): Add repeat option.
4157         (PerfTestsRunner.run): Add outer repeat loop.
4158         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
4159         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
4160         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
4161         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
4162         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
4163         (MainTest.test_run_with_json_output): Fix typo.
4164         (MainTest.test_run_with_description): Fix typo.
4165         (MainTest.test_run_respects_no_results): Fix typo.
4166         (MainTest.test_run_with_slave_config_json): Fix typo.
4167         (MainTest.test_run_with_multiple_repositories): Fix typo.
4168         (MainTest.test_run_with_upload_json): Fix typo.
4169         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
4170         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
4171         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4172         (MainTest.test_parse_args): Add test for repeat option parsing.
4173
4174 2013-03-07  Julie Parent  <jparent@chromium.org>
4175
4176         showAllRuns checkbox no longer works on the stats dashboard
4177         https://bugs.webkit.org/show_bug.cgi?id=111673
4178
4179         Reviewed by Ojan Vafai.
4180
4181         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
4182         so we were trying to index into an undefined object.
4183         
4184         * TestResultServer/static-dashboards/dashboard_base.js:
4185         (invalidateQueryParameters):
4186
4187 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
4188
4189         [Chromium] Update #include for WebStorageNamespace.h
4190         https://bugs.webkit.org/show_bug.cgi?id=111748
4191
4192         Reviewed by Adam Barth.
4193
4194         In anticipation of removing
4195         WK/chromium/public/WebStorageNamespace.h (once downstream
4196         references have been updated)
4197
4198         * DumpRenderTree/chromium/WebViewHost.cpp:
4199
4200 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
4201
4202         run-perf-tests fails due to svn_revision not working on a pure git clone
4203         https://bugs.webkit.org/show_bug.cgi?id=110839
4204
4205         Reviewed by Ryosuke Niwa.
4206
4207         Previously we would call git svn find-rev to look up the commit for
4208         a given revision, and that'll hang in a pure git checkout.
4209
4210         This patch changes the way we look up svn revisions in a git
4211         repository to use git log --grep 'git-svn-id', which is much faster
4212         than grepping ourselves. It also renames timestamp_of_latest_commit()
4213         to timestamp_of_revision() in order to accurately reflect what
4214         the method is doing. Note that this patch only changes the logic
4215         inside latest_revision() and svn_revision(). I'll file a separate
4216         bug to change git_commit_from_svn_revision().
4217
4218         This patch also contains some fixes to unit tests that had bit-rotted
4219         or were otherwise fragile, so that test-webkitpy --all would pass
4220         cleanly, and a fix to outputcapture so that
4221         test-webkitpy -p would work correctly again.
4222
4223         * Scripts/webkitpy/common/checkout/scm/git.py:
4224         (Git.svn_revision):
4225         (Git.timestamp_of_revision):
4226         * Scripts/webkitpy/common/checkout/scm/scm.py:
4227         (SCM.svn_revision):
4228         (SCM.timestamp_of_revision):
4229         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
4230         (MockSCM.timestamp_of_revision):
4231         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4232         (_shared_test_commit_with_message):
4233         (test_commit_without_authorization):
4234         (test_timestamp_of_revision):
4235         * Scripts/webkitpy/common/checkout/scm/svn.py:
4236         (SVN.timestamp_of_revision):
4237         * Scripts/webkitpy/common/system/outputcapture.py:
4238           Importing unittest2 directly may not be safe if this module is
4239           imported before the autoinstaller gets a chance to set things up
4240           properly. We don't actually need unittest2 here.
4241         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4242         (PerfTestsRunner._generate_results_dict):
4243
4244 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
4245
4246         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
4247         https://bugs.webkit.org/show_bug.cgi?id=111756
4248
4249         Reviewed by Kenneth Rohde Christiansen.
4250
4251         Bump libsoup to v2.40.3 to fix the regressions introduced by
4252         previous v2.40.0 bump.
4253
4254         * efl/jhbuild.modules:
4255
4256 2013-03-07  Roger Fong  <roger_fong@apple.com>
4257
4258         Re-enable Win EWS tests.
4259
4260         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4261         (WinEWS):
4262
4263 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
4264
4265         [nrwt] handle corrupt http server pid files cleanly
4266         https://bugs.webkit.org/show_bug.cgi?id=111628
4267
4268         Reviewed by Eric Seidel.
4269
4270         If the pid file from a previous http server is corrupt for some
4271         reason, NRWT will just raise errors and not clean it up or recover.
4272         This patch fixes that to at least delete the pid file and
4273         not throw; not that we may still have stale http servers left on
4274         the system, since there's no way to know which pid to kill if
4275         the file was corrupted.
4276
4277         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
4278         (HttpServerBase.start):
4279         (HttpServerBase.stop):
4280         (HttpServerBase._remove_pid_file):
4281         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
4282         (TestHttpServerBase):
4283         (TestHttpServerBase.test_corrupt_pid_file):
4284
4285 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
4286
4287         AX: Can't activate links with VoiceOver in Safari
4288         https://bugs.webkit.org/show_bug.cgi?id=111755
4289
4290         Reviewed by Tim Horton.
4291