InjectedBundle parameters often need initialization function called before unarchiving
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2
3         InjectedBundle parameters often need initialization function called before unarchiving
4         https://bugs.webkit.org/show_bug.cgi?id=189709
5         <rdar://problem/44573653>
6
7         Reviewed by Ryosuke Niwa.
8
9         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
10         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
11
12 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
13
14         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
15         https://bugs.webkit.org/show_bug.cgi?id=196681
16
17         Reviewed by Darin Adler.
18
19         Added tests.
20
21         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
22         (WTF_HashSet.RemoveIf):
23         (WTF_HashSet.RemoveIfShrinkToBestSize):
24
25 2019-04-15  John Wilander  <wilander@apple.com>
26
27         Send delayed Ad Click Attribution conversion requests to the click source
28         https://bugs.webkit.org/show_bug.cgi?id=196838
29         <rdar://problem/47650157>
30
31         Reviewed by Chris Dumez and Youenn Fablet.
32
33         This patch adds test infrastructure to override the default behavior in
34         WebKit::NetworkAdClickAttribution.
35
36         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
37         (TestWebKitAPI::TEST):
38         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
39         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
40         (WTR::TestRunner::dumpAdClickAttribution):
41         (WTR::TestRunner::clearAdClickAttribution):
42         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
43         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
44         * WebKitTestRunner/InjectedBundle/TestRunner.h:
45         * WebKitTestRunner/TestController.cpp:
46         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
47         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
48         * WebKitTestRunner/TestController.h:
49         * WebKitTestRunner/TestInvocation.cpp:
50         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
51
52 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
53
54         [ews-app] status-bubble should display position in queue
55         https://bugs.webkit.org/show_bug.cgi?id=196607
56
57         Reviewed by Lucas Forschler.
58
59         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
60         (StatusBubble._build_bubble):
61         (StatusBubble._queue_position): Method to calculate patch's position in queue.
62
63 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
64
65         [ews-build] Do not run clean build by default on EWS builders
66         https://bugs.webkit.org/show_bug.cgi?id=196897
67
68         Reviewed by Lucas Forschler.
69
70         * BuildSlaveSupport/ews-build/steps.py:
71         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
72         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
73         untracked directories like WebKitBuild).
74         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
75         untracked files/directories (like WebKitBuild).
76
77 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
78
79         TestRunner::notifyDone() should be safely reentrant
80         https://bugs.webkit.org/show_bug.cgi?id=196898
81
82         Reviewed by Darin Adler.
83
84         It is currently possible that TestRunner::notifyDone() will call itself, since
85         notifyDone() will force a repaint, which can start executing JavaScript, which
86         may call notifyDone() again. This can lead to test failures and flakiness.
87         Fix this by setting the m_waitToDump flag before calling the dump() method.
88
89         * DumpRenderTree/mac/TestRunnerMac.mm:
90         (TestRunner::notifyDone):
91         (TestRunner::forceImmediateCompletion):
92         * DumpRenderTree/win/TestRunnerWin.cpp:
93         (TestRunner::notifyDone):
94         (TestRunner::forceImmediateCompletion):
95
96 2019-04-15  Philippe Normand  <pnormand@igalia.com>
97
98         [GTK][WPE] Add enable-media websetting
99         https://bugs.webkit.org/show_bug.cgi?id=196863
100
101         Reviewed by Michael Catanzaro.
102
103         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
104         (testWebKitSettings): Add test for the enable-media web-setting.
105
106 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
107
108         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
109         https://bugs.webkit.org/show_bug.cgi?id=196905
110         <rdar://problem/49886096>
111
112         Reviewed by Tim Horton.
113
114         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
115         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
116         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
117         delay timer, we end up with this sequence of events in the problematic (failure) case:
118
119         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
120             ...IPC from UI to web process...
121         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
122             ...IPC from web to UI process...
123         (c) [UI]    Invoke completion handler for script #1
124         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
125             ...IPC from UI to web process...
126         (e) [Web]   Evaluate script #2 in the web process
127         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
128
129         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
130         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
131         #2 is run in step (e).
132
133         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
134         the UI process by waiting on a script message posted by the web process, after attachment updates are
135         dispatched.
136
137         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
138         (TestWebKitAPI::TEST):
139
140 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
141
142         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
143         https://bugs.webkit.org/show_bug.cgi?id=196909
144
145         Reviewed by Wenson Hsieh.
146
147         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
148         (TestWebKitAPI::TEST):
149
150 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
151
152         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
153         https://bugs.webkit.org/show_bug.cgi?id=196880
154
155         Reviewed by Yusuke Suzuki.
156
157         Add a new function for bytecode cache tests that does not forceDiskCache
158         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
159         test added in this patch, since the code is invalid and therefore won't be
160         cached. It should also be useful for tests that evaluate dynamically
161         generated code.
162
163         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
164         * Scripts/run-jsc-stress-tests:
165
166 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
167
168         Update AudioSession route sharing policy
169         https://bugs.webkit.org/show_bug.cgi?id=196776
170         <rdar://problem/46501611>
171
172         Reviewed by Jer Noble.
173
174         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
175         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
176         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
177         (TestWebKitAPI::TEST):
178
179 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
180
181         [iOS] Software keyboard is shown too frequently on some websites
182         https://bugs.webkit.org/show_bug.cgi?id=195856
183         <rdar://problem/49191395>
184
185         Reviewed by Darin Adler.
186
187         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
188
189         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
190         (WTR::UIScriptController::setHardwareKeyboardAttached):
191         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
192         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
193         (WTR::UIScriptController::setHardwareKeyboardAttached):
194         * TestRunnerShared/UIScriptContext/UIScriptController.h:
195         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
196
197         Additionally link against GraphicsServices in WebKitTestRunner.
198
199         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
200         (WTR::TestController::platformResetStateToConsistentValues):
201         (WTR::UIScriptController::setHardwareKeyboardAttached):
202
203 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
204
205         [GTK][WPE] Fix pacman install-dependencies packages
206         https://bugs.webkit.org/show_bug.cgi?id=196817
207
208         Reviewed by Žan Doberšek.
209         
210         python3-setuptools is called python-setuptools
211         ruby-highline is only available on AUR
212         libv4l-devel is incorporated in v4l-utils
213
214         * gtk/install-dependencies:
215         * wpe/install-dependencies:
216
217 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
218
219         [GTK] REGRESSION(r243860): Many tests failing
220         https://bugs.webkit.org/show_bug.cgi?id=196791
221
222         Reviewed by Joanmarie Diggs.
223
224         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
225         multiple documents and check that accessibility hierarchy is updated after a navigation.
226
227         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
228         (loadChangedCallback):
229         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
230         (AccessibilityTest::AccessibilityTest):
231         (AccessibilityTest::~AccessibilityTest):
232         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
233         (AccessibilityTest::findTestServerApplication):
234         (AccessibilityTest::findDocumentWeb):
235         (AccessibilityTest::findRootObject):
236         (AccessibilityTest::waitUntilChildrenRemoved):
237         (AccessibilityTest::ensureProxy):
238         (testAtspiBasicHierarchy):
239         (beforeAll):
240         (afterAll):
241
242 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
243
244         [ews-build] Handle bug titles with unicode characters
245         https://bugs.webkit.org/show_bug.cgi?id=196802
246
247         Reviewed by Dewei Zhu.
248
249         * BuildSlaveSupport/ews-build/steps.py:
250         (ValidatePatch._is_bug_closed):
251
252 2019-04-11  Michael Saboff  <msaboff@apple.com>
253
254         Improve the Inline Cache Stats code
255         https://bugs.webkit.org/show_bug.cgi?id=196836
256
257         Reviewed by Saam Barati.
258
259         Added a new script to consolidate and arrange the output of --useICStats option.
260
261         This script merges the output from every group into one large table and sorts it from most common to
262         least common.  It also counts the slow path GetById and PutById variants and then calculates the
263         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
264         Put together, this is useful to see what property accesses are not getting cached.
265
266         * Scripts/ic-stats.py: Added.
267         (ICStats):
268         (ICStats.__init__):
269         (ICStats.parse):
270         (ICStats.dumpStats):
271         (usage):
272
273 2019-04-10  Alex Christensen  <achristensen@webkit.org>
274
275         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
276         https://bugs.webkit.org/show_bug.cgi?id=196809
277         <rdar://49800762>
278
279         Reviewed by Brady Eidson.
280
281         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
282         (TEST):
283
284 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
285
286         requestAnimationFrame should execute before the next frame
287         https://bugs.webkit.org/show_bug.cgi?id=177484
288
289         Reviewed by Simon Fraser.
290
291         Add trace points for the page RenderingUpdate.
292
293         * Tracing/SystemTracePoints.plist:
294
295 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
296
297         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
298         https://bugs.webkit.org/show_bug.cgi?id=196760
299
300         Reviewed by Don Olmstead.
301
302         vswhere.exe has been bundled since Visual Studio 2017 version
303         15.2. We shouldn't download vswhere.exe.
304
305         * Scripts/build-jsc: Do not call update-vswhere.py.
306         * Scripts/build-webkit: Ditto.
307         * Scripts/update-vswhere.py: Removed.
308         * Scripts/webkitdirs.pm:
309         (requireModulesForVSWhere): Deleted.
310         (pickCurrentVisualStudioInstallation): Deleted.
311         (visualStudioInstallDirVSWhere): Return the latest installed VS
312         installation path by using the bundled vswhere.exe.
313         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
314         (visualStudioInstallDirFallback): Removed.
315
316 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
317
318         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
319         https://bugs.webkit.org/show_bug.cgi?id=196780
320
321         Reviewed by Alexey Proskuryakov.
322
323         * BuildSlaveSupport/ews-build/steps.py:
324         * BuildSlaveSupport/ews-build/steps_unittest.py:
325
326 2019-04-10  Alex Christensen  <achristensen@webkit.org>
327
328         Add SPI WKNavigationResponse._downloadAttribute
329         https://bugs.webkit.org/show_bug.cgi?id=196755
330         <rdar://49587365>
331
332         Reviewed by Brady Eidson.
333
334         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
335         (-[NavigationResponseTestDelegate navigationResponse]):
336         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
337         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
338         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
339         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
340         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
341         (readRequest):
342         (writeResponse):
343         (TEST):
344
345 2019-04-10  Tim Horton  <timothy_horton@apple.com>
346
347         Add modern API for overriding the page's specified viewport configuration
348         https://bugs.webkit.org/show_bug.cgi?id=167734
349         <rdar://problem/30331795>
350
351         Reviewed by Simon Fraser.
352
353         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
354         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
355
356 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
357
358         Add support for incremental bytecode cache updates
359         https://bugs.webkit.org/show_bug.cgi?id=195000
360
361         Reviewed by Filip Pizlo.
362
363         Exit when the initial run to generate bytecode fails.
364
365         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
366
367 2019-04-10  Alex Christensen  <achristensen@webkit.org>
368
369         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
370         https://bugs.webkit.org/show_bug.cgi?id=196744
371         <rdar://49415309>
372
373         Reviewed by Chris Dumez.
374
375         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
376         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
377
378 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
379
380         Add a way to opt into modern compatibility mode in layout tests
381         https://bugs.webkit.org/show_bug.cgi?id=196770
382         <rdar://problem/49777550>
383
384         Reviewed by Antoine Quint.
385
386         Add a new test option to enable modern compatibility mode in layout tests.
387
388         * WebKitTestRunner/TestController.cpp:
389         (WTR::updateTestOptionsFromTestHeader):
390         * WebKitTestRunner/TestController.h:
391         * WebKitTestRunner/TestOptions.h:
392         (WTR::TestOptions::hasSameInitializationOptions const):
393         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
394         (WTR::TestController::platformCreateWebView):
395         (WTR::TestController::enableModernCompatibilityMode):
396
397 2019-04-10  Andy Estes  <aestes@apple.com>
398
399         Try to fix the 32-bit watchOS build.
400
401         * TestWebKitAPI/cocoa/TestWKWebView.mm:
402         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
403
404 2019-04-10  Antoine Quint  <graouts@apple.com>
405
406         Enable Pointer Events on watchOS
407         https://bugs.webkit.org/show_bug.cgi?id=196771
408         <rdar://problem/49040909>
409
410         Reviewed by Dean Jackson.
411
412         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
413
414 2019-04-10  Philippe Normand  <pnormand@igalia.com>
415
416         Unreviewed. Fix WPE accessibility tests after r244059.
417
418         We are failing to load the injected bundle due to undefined symbol
419         AccessibilityUIElement::replaceTextInRange().
420
421         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
422         (WTR::AccessibilityUIElement::replaceTextInRange):
423
424 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
425
426         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
427         https://bugs.webkit.org/show_bug.cgi?id=196727
428
429         Reviewed by Fujii Hironori.
430
431         * MiniBrowser/win/WebKitBrowserWindow.cpp:
432         (WebKitBrowserWindow::create):
433
434 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
435
436         [ews-build] Add unit tests for PrintConfiguration
437         https://bugs.webkit.org/show_bug.cgi?id=196752
438
439         Reviewed by Dewei Zhu.
440
441         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
442
443 2019-04-09  Keith Rollin  <krollin@apple.com>
444
445         Unreviewed build maintenance -- update .xcfilelists.
446
447         * DumpRenderTree/DerivedSources-input.xcfilelist:
448         * DumpRenderTree/DerivedSources-output.xcfilelist:
449
450 2019-04-09  Zalan Bujtas  <zalan@apple.com>
451
452         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
453         https://bugs.webkit.org/show_bug.cgi?id=196743
454         <rdar://problem/43897551>
455
456         Reviewed by Tim Horton.
457
458         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
459         (TEST):
460
461 2019-04-09  Youenn Fablet  <youenn@apple.com>
462
463         Close service worker database on network process suspension
464         https://bugs.webkit.org/show_bug.cgi?id=196623
465         <rdar://problem/48930869>
466
467         Reviewed by Alex Christensen.
468
469         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
470
471 2019-04-09  Daniel Bates  <dabates@apple.com>
472
473         [iPad] Should open popover when the spacebar is pressed
474         https://bugs.webkit.org/show_bug.cgi?id=196360
475         <rdar://problem/49389129>
476
477         Reviewed by Brent Fulgham.
478
479         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
480
481         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
482         (WTR::UIScriptController::isShowingPopover const): Added.
483         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
484         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
485         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
486         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
487         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
488         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
489         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
490         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
491         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
492         (WTR::UIScriptController::isShowingPopover const): Added.
493         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
494         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
495         * TestRunnerShared/UIScriptContext/UIScriptController.h:
496         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
497         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
498         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
499         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
500         (-[TestRunnerWKWebView _willPresentPopover]): Added.
501         (-[TestRunnerWKWebView _didDismissPopover]): Added.
502         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
503         (WTR::UIScriptController::isShowingPopover const): Added.
504         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
505         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
506
507 2019-04-09  Alex Christensen  <achristensen@webkit.org>
508
509         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
510         https://bugs.webkit.org/show_bug.cgi?id=196665
511         <rdar://45115669>
512
513         Reviewed by Geoff Garen.
514
515         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
516         (goBack):
517         (+[SimpleLookupContext sharedLookupContext]):
518         (-[SimpleLookupContext lookUpURL:completionHandler:]):
519         (TEST):
520         (+[Simple3LookupContext sharedLookupContext]): Deleted.
521         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
522
523 2019-04-09  John Wilander  <wilander@apple.com>
524
525         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
526         https://bugs.webkit.org/show_bug.cgi?id=196558
527         <rdar://problem/47650245>
528
529         Reviewed by Youenn Fablet.
530
531         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
532         (TestWebKitAPI::TEST):
533             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
534
535 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
536
537         [CMake] Apple builds should use ICU_INCLUDE_DIRS
538         https://bugs.webkit.org/show_bug.cgi?id=196720
539
540         Reviewed by Konstantin Tokarev.
541
542         * TestWebKitAPI/PlatformMac.cmake:
543
544 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
545
546         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
547         https://bugs.webkit.org/show_bug.cgi?id=196694
548         <rdar://problem/48388734>
549
550         Rubber-stamped by Aakash Jain.
551
552         * Scripts/webkitpy/port/image_diff.py:
553         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
554         * Scripts/webkitpy/port/server_process.py:
555         (ServerProcess.has_available_stdout): Check if stdout has data in it.
556         (ServerProcess._wait_for_data_and_update_buffers_using_select):
557         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
558         * Scripts/webkitpy/port/server_process_mock.py:
559         (MockServerProcess.has_available_stdout):
560         * Scripts/webkitpy/port/server_process_unittest.py:
561         (TestServerProcess.serial_test_basic):
562
563 2019-04-09  Jer Noble  <jer.noble@apple.com>
564
565         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
566         https://bugs.webkit.org/show_bug.cgi?id=196097
567
568         Reviewed by Eric Carlson.
569
570         Drive-by bug fix: allow tests to play audio without a user gesture by default.
571
572         * DumpRenderTree/mac/DumpRenderTree.mm:
573         (resetWebPreferencesToConsistentValues):
574         * WebKitTestRunner/TestController.cpp:
575         (WTR::TestController::resetPreferencesToConsistentValues):
576
577 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
578
579         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
580         https://bugs.webkit.org/show_bug.cgi?id=196690
581
582         Reviewed by Michael Catanzaro.
583
584         * QueueStatusServer/config/queues.py:
585         * Scripts/webkitpy/common/config/ews.json:
586         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
587         (test_ews_name):
588
589 2019-04-09  Chris Dumez  <cdumez@apple.com>
590
591         Loads using loadHTMLString() cause flashing when process-swapping
592         https://bugs.webkit.org/show_bug.cgi?id=196714
593         <rdar://problem/49637354>
594
595         Reviewed by Antti Koivisto.
596
597         Add API test coverage.
598
599         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
600
601 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
602
603         Unreviewed. Fix ATK accessibility tests after r244059.
604
605         We are failing to load the injected bundle due to undefined symbol
606         AccessibilityUIElement::replaceTextInRange().
607
608         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
609         (WTR::AccessibilityUIElement::replaceTextInRange):
610
611 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
612
613         AX: Support API: accessibilityReplaceRange:withText
614         https://bugs.webkit.org/show_bug.cgi?id=196636
615
616         Unreviewed build fix for Windows port.
617
618         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
619         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
620
621 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
622
623         [CMake][WinCairo] Separate copied headers into different directories
624         https://bugs.webkit.org/show_bug.cgi?id=196655
625
626         Reviewed by Michael Catanzaro.
627
628         * DumpRenderTree/CMakeLists.txt:
629         * MiniBrowser/win/CMakeLists.txt:
630         * TestWebKitAPI/CMakeLists.txt:
631         * TestWebKitAPI/PlatformWin.cmake:
632
633 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
634
635         Log stack-trace for run-webkit-tests when interrupted
636         https://bugs.webkit.org/show_bug.cgi?id=176393
637         <rdar://problem/34262310>
638
639         Reviewed by Lucas Forschler.
640
641         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
642         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
643         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
644         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
645         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
646         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
647         (main): Set handlers to log stack trace on interruption.
648
649 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
650
651         AX: Support API: accessibilityReplaceRange:withText
652         https://bugs.webkit.org/show_bug.cgi?id=196636
653
654         Unreviewed build fix for Windows port.
655
656         * DumpRenderTree/AccessibilityUIElement.cpp:
657         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
658
659 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
660
661         [ews-build] Scripts using Buildbot API have CORS error
662         https://bugs.webkit.org/show_bug.cgi?id=196709
663
664         Reviewed by Alexey Proskuryakov.
665
666         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
667
668 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
669
670         AX: Support API: accessibilityReplaceRange:withText
671         https://bugs.webkit.org/show_bug.cgi?id=196636
672
673         Reviewed by Daniel Bates.
674
675         * DumpRenderTree/AccessibilityUIElement.cpp:
676         (replaceTextInRangeCallback):
677         (AccessibilityUIElement::replaceTextInRange):
678         (AccessibilityUIElement::getJSClass):
679         * DumpRenderTree/AccessibilityUIElement.h:
680         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
681         (AccessibilityUIElement::replaceTextInRange):
682         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
683         (AccessibilityUIElement::replaceTextInRange):
684         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
685         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
686         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
687         (WTR::AccessibilityUIElement::replaceTextInRange):
688         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
689         (WTR::AccessibilityUIElement::replaceTextInRange):
690
691 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
692
693         [iOS] Do not allow starting selection drags when selection views are not visible
694         https://bugs.webkit.org/show_bug.cgi?id=196686
695         <rdar://problem/49399192>
696
697         Reviewed by Tim Horton.
698
699         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
700         also add some new API tests to cover scenarios where the web view is not first responder.
701
702         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
703         (TestWebKitAPI::TEST):
704         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
705
706         Add a switch to optionally make the web view first responder when starting the simulated drag.
707
708         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
709         (-[DragAndDropSimulator initWithWebView:]):
710         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
711
712 2019-04-08  Justin Fan  <justin_fan@apple.com>
713
714         [Web GPU] Fix Web GPU experimental feature on iOS
715         https://bugs.webkit.org/show_bug.cgi?id=196632
716
717         Reviewed by Myles C. Maxfield.
718
719         Properly make Web GPU available on iOS 11+.
720
721         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
722
723 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
724
725         [ews-build] Do not upload archive when Compile Fails
726         https://bugs.webkit.org/show_bug.cgi?id=196674
727
728         Reviewed by Alexey Proskuryakov.
729
730         * BuildSlaveSupport/ews-build/factories.py:
731         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
732         * BuildSlaveSupport/ews-build/steps.py:
733         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
734         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
735         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
736
737 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
738
739         Enable DFG on MIPS
740         https://bugs.webkit.org/show_bug.cgi?id=196689
741
742         Reviewed by Žan Doberšek.
743
744         Since the bytecode change, we enabled the baseline JIT on mips in
745         r240432, but DFG is still missing. With this change, all tests are
746         passing on a ci20 board.
747
748         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
749
750 2019-04-08  Philippe Normand  <pnormand@igalia.com>
751
752         [Flatpak] Second run update-webkitwpe-flatpak fails
753         https://bugs.webkit.org/show_bug.cgi?id=192702
754
755         Reviewed by Carlos Garcia Campos.
756
757         * flatpak/flatpakutils.py:
758         (FlatpakObject.flatpak): Fix typo.
759         (FlatpakPackage.install): When installing, also update to the configured remote commit.
760         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
761
762 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
763
764         [GTK][WPE] outlook.live.com displays old-fashioned UI
765         https://bugs.webkit.org/show_bug.cgi?id=196642
766
767         Reviewed by Carlos Garcia Campos.
768
769         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
770         (TestWebKitAPI::TEST): New Mac platform quirk test.
771
772 2019-04-07  Commit Queue  <commit-queue@webkit.org>
773
774         Unreviewed, rolling out r243956.
775         https://bugs.webkit.org/show_bug.cgi?id=196688
776
777         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
778         by aakashjain on #webkit).
779
780         Reverted changeset:
781
782         "Clicking "Go Back" from a safe browsing warning from an
783         iframe should navigate the WKWebView back to the previous
784         page"
785         https://bugs.webkit.org/show_bug.cgi?id=196665
786         https://trac.webkit.org/changeset/243956
787
788 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
789
790         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
791         https://bugs.webkit.org/show_bug.cgi?id=196669
792
793         Reviewed by Geoffrey Garen.
794
795         Added three new unit tests for WeakHashSet.
796
797         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
798         (WTF_WeakPtr.WeakHashSetConstObjects):
799         (WTF_WeakPtr.WeakHashSetComputesEmpty):
800         (WTF_WeakPtr.WeakHashSetComputeSize):
801
802 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
803
804         Hide next and previous form control buttons when WKWebView is editable
805         https://bugs.webkit.org/show_bug.cgi?id=196672
806         <rdar://problem/35625321>
807
808         Reviewed by Tim Horton.
809
810         Add a new API test.
811
812         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
813         (-[TestWKWebView lastTrailingBarButtonGroup]):
814         (TestWebKitAPI::TEST):
815         * TestWebKitAPI/ios/UIKitSPI.h:
816
817 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
818
819         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
820         https://bugs.webkit.org/show_bug.cgi?id=196077
821         <rdar://problem/49108202>
822
823         Reviewed by Chris Dumez.
824
825         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
826         on new web view.
827
828         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
829
830 2019-04-05  Saam Barati  <sbarati@apple.com>
831
832         Make compare-results understand MotionMark
833         https://bugs.webkit.org/show_bug.cgi?id=196666
834
835         Reviewed by Yusuke Suzuki.
836
837         * Scripts/compare-results:
838         (PLT5Results):
839         (detectMotionMark):
840         (detectMotionMark1_1):
841         (motionMarkResults):
842         (motionMark1_1Results):
843         (detectBenchmark):
844         (biggerIsBetter):
845         (main):
846
847 2019-04-05  Alex Christensen  <achristensen@webkit.org>
848
849         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
850         https://bugs.webkit.org/show_bug.cgi?id=196665
851         <rdar://45115669>
852
853         Reviewed by Geoff Garen.
854
855         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
856         (goBack):
857         (+[SimpleLookupContext sharedLookupContext]):
858         (-[SimpleLookupContext lookUpURL:completionHandler:]):
859         (TEST):
860         (+[Simple3LookupContext sharedLookupContext]): Deleted.
861         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
862
863 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
864
865         [ews-build] Add configuration and architecture for windows builders
866         https://bugs.webkit.org/show_bug.cgi?id=196660
867
868         Reviewed by Lucas Forschler.
869
870         * BuildSlaveSupport/ews-build/config.json:
871
872 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
873
874         webkitpy: Don't run subsequent rounds if interrupted
875         https://bugs.webkit.org/show_bug.cgi?id=196646
876
877         Reviewed by Aakash Jain.
878
879         * Scripts/webkitpy/layout_tests/controllers/manager.py:
880         (Manager.run): Bail out if interrupted.
881
882 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
883
884         Test sessionStorage in PSON private browsing mode
885         https://bugs.webkit.org/show_bug.cgi?id=196561
886
887         Reviewed by Alex Christensen.
888
889         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
890
891 2019-04-05  Commit Queue  <commit-queue@webkit.org>
892
893         Unreviewed, rolling out r243833.
894         https://bugs.webkit.org/show_bug.cgi?id=196645
895
896         This change breaks build of WPE and GTK ports (Requested by
897         annulen on #webkit).
898
899         Reverted changeset:
900
901         "[CMake][WTF] Mirror XCode header directories"
902         https://bugs.webkit.org/show_bug.cgi?id=191662
903         https://trac.webkit.org/changeset/243833
904
905 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
906
907         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
908         https://bugs.webkit.org/show_bug.cgi?id=196635
909
910         Reviewed by Antti Koivisto.
911         
912         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
913         for a test to enable async frame scrolling via:
914             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
915         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
916         
917         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
918
919         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
920         (WTR::InjectedBundle::beginTesting):
921         * WebKitTestRunner/TestController.cpp:
922         (WTR::TestController::resetPreferencesToConsistentValues):
923
924 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
925
926         Use a correct LC_RPATH when building with ASan
927         https://bugs.webkit.org/show_bug.cgi?id=196576
928
929         Reviewed by David Kilzer.
930
931         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
932         so that ../Frameworks is checked. This is simpler and more reliable than updating
933         each SPC service xcconfig.
934
935 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
936
937         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
938         https://bugs.webkit.org/show_bug.cgi?id=196629
939
940         Reviewed by Lucas Forschler.
941
942         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
943
944 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
945
946         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
947         https://bugs.webkit.org/show_bug.cgi?id=196618
948
949         Reviewed by Lucas Forschler.
950
951         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
952         (StatusBubble): Added QUEUE_TRIGGERS.
953         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
954         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
955         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
956         its parent(builder).
957
958 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
959
960         [ews-app] Status-bubble steps are sometimes displayed in reverse order
961         https://bugs.webkit.org/show_bug.cgi?id=196625
962
963         Reviewed by Lucas Forschler.
964
965         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
966         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
967
968 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
969
970         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
971         https://bugs.webkit.org/show_bug.cgi?id=196630
972
973         Reviewed by Wenson Hsieh.
974
975         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
976
977 2019-04-04  Youenn Fablet  <youenn@apple.com>
978
979         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
980         https://bugs.webkit.org/show_bug.cgi?id=196543
981
982         Reviewed by Alex Christensen.
983
984         * WebKitTestRunner/TestController.cpp:
985         (WTR::TestController::generatePageConfiguration):
986
987 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
988
989         [ews-app] Status bubble should not display skipped buildbot steps
990         https://bugs.webkit.org/show_bug.cgi?id=196584
991
992         Reviewed by Lucas Forschler.
993
994         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
995
996 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
997
998         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
999         https://bugs.webkit.org/show_bug.cgi?id=196620
1000
1001         Reviewed by Lucas Forschler.
1002
1003         * BuildSlaveSupport/ews-app/ews/config.py:
1004
1005 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1006
1007         [Win] DumpRenderTreeWatchDog.py is not checked into source
1008         https://bugs.webkit.org/show_bug.cgi?id=196567
1009         <rdar://problem/49525901>
1010
1011         Reviewed by Lucas Forschler.
1012
1013         This script is used on Win EWS bots to terminate hanging DRT processes.
1014
1015         * EWSTools/dumprendertreewatchdog.py: Added.
1016
1017 2019-04-04  Chris Dumez  <cdumez@apple.com>
1018
1019         Unreviewed, roll out r243858 which made tests time out.
1020
1021         Disable new API tests on Windows instead.
1022
1023         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1024         (TestWebKitAPI::TEST):
1025
1026 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1027
1028         [ATK] Cleanup WebPageAccessibilityObjectAtk
1029         https://bugs.webkit.org/show_bug.cgi?id=196537
1030
1031         Reviewed by Michael Catanzaro.
1032
1033         Also consider files under atk directories as exceptions for GObject conventions.
1034
1035         * Scripts/webkitpy/style/checkers/cpp.py:
1036         (check_identifier_name_in_declaration):
1037
1038 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1039
1040         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1041         https://bugs.webkit.org/show_bug.cgi?id=196588
1042         <rdar://problem/49365787>
1043
1044         Unreviewed build fix for Windows port.
1045
1046         error C3861: 'kill': identifier not found
1047
1048         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1049         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1050
1051 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1052
1053         [ews-build] Cancel build and similar operations should have authentication
1054         https://bugs.webkit.org/show_bug.cgi?id=196520
1055
1056         Reviewed by Dewei Zhu.
1057
1058         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1059         environment variables.
1060
1061 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1062
1063         [ews-build] Do not trigger queues which are not in production yet
1064         https://bugs.webkit.org/show_bug.cgi?id=196581
1065
1066         Reviewed by Dewei Zhu.
1067
1068         * BuildSlaveSupport/ews-build/config.json:
1069
1070 2019-04-03  Chris Dumez  <cdumez@apple.com>
1071
1072         Unreviewed, fix typo in the name of API test added in r243848.
1073
1074         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1075         (TestWebKitAPI::TEST):
1076
1077 2019-04-03  Chris Dumez  <cdumez@apple.com>
1078
1079         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1080         https://bugs.webkit.org/show_bug.cgi?id=196588
1081         <rdar://problem/49365787>
1082
1083         Reviewed by Ryosuke Niwa.
1084
1085         Add API test coverage.
1086
1087         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1088         (TestWebKitAPI::nullJavaScriptCallback):
1089         (TestWebKitAPI::didCrashCheckFrames):
1090         (TestWebKitAPI::TEST):
1091
1092 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1093
1094         run-webkit-tests: Upload test results (new results database)
1095         https://bugs.webkit.org/show_bug.cgi?id=196577
1096         <rdar://problem/34841155>
1097
1098         Reviewed by Lucas Forschler.
1099
1100         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1101         (Manager.run): Upload results after each device shard, since the configuration will be
1102         different for each device.
1103         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1104         uploaded to a results database.
1105         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1106         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1107
1108 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1109
1110         -apple-trailing-word is needed for browser detection
1111         https://bugs.webkit.org/show_bug.cgi?id=196575
1112
1113         Unreviewed.
1114
1115         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1116
1117 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1118
1119         [CMake][WTF] Mirror XCode header directories
1120         https://bugs.webkit.org/show_bug.cgi?id=191662
1121
1122         Reviewed by Konstantin Tokarev.
1123
1124         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1125         builds.
1126
1127         * CMakeLists.txt:
1128         * DumpRenderTree/CMakeLists.txt:
1129         * DumpRenderTree/PlatformWin.cmake:
1130         * MiniBrowser/win/CMakeLists.txt:
1131         * TestWebKitAPI/CMakeLists.txt:
1132         * TestWebKitAPI/PlatformWin.cmake:
1133         * WebKitTestRunner/PlatformGTK.cmake:
1134         * WebKitTestRunner/PlatformWin.cmake:
1135
1136 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1137
1138         [ews-app] Status bubble should not display certain infrastructure status messages
1139         https://bugs.webkit.org/show_bug.cgi?id=196550
1140
1141         Reviewed by Lucas Forschler.
1142
1143         Do not display the steps which are un-needed for end-user. This information is still avaiable
1144         if the user click on the bubble and look at the Buildbot build.
1145         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1146         (StatusBubble._steps_messages):
1147         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1148
1149 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1150
1151         [ews-build] Use https for sending data to ews-app
1152         https://bugs.webkit.org/show_bug.cgi?id=196492
1153
1154         Reviewed by Lucas Forschler.
1155
1156         * BuildSlaveSupport/ews-build/events.py:
1157
1158 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1159
1160         Remove support for -apple-trailing-word
1161         https://bugs.webkit.org/show_bug.cgi?id=196525
1162
1163         Reviewed by Zalan Bujtas.
1164
1165         This CSS property is nonstandard and not used.
1166
1167         * Scripts/webkitperl/FeatureList.pm:
1168         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1169
1170 2019-04-03  Youenn Fablet  <youenn@apple.com>
1171
1172         Add a test for DOMCache on multiple browsing in case of private browsing
1173         https://bugs.webkit.org/show_bug.cgi?id=196524
1174
1175         Reviewed by Alex Christensen.
1176
1177         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1178         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1179
1180 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1181
1182         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1183         https://bugs.webkit.org/show_bug.cgi?id=196540
1184
1185         Reviewed by Aakash Jain.
1186
1187         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1188
1189 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1190
1191         Add plumbing for a compatibility mode preference in WebKit
1192         https://bugs.webkit.org/show_bug.cgi?id=196005
1193
1194         Reviewed by Tim Horton.
1195
1196         Add new API tests.
1197
1198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1199         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1200
1201 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1202
1203         [WPE][GTK] Update libsrtp dependency package for Debian
1204         https://bugs.webkit.org/show_bug.cgi?id=196528
1205
1206         Reviewed by Frédéric Wang.
1207
1208         * gtk/install-dependencies:
1209         * wpe/install-dependencies:
1210
1211 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1212
1213         [WK2] Add support for Window's beforeprint / afterprint events
1214         https://bugs.webkit.org/show_bug.cgi?id=196478
1215         <rdar://problem/49535124>
1216
1217         Unreviewed build fix for MSVC.
1218
1219         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1220
1221         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1222
1223         * WebKitTestRunner/TestController.cpp:
1224         (WTR::printFrame): Use int and float literals.
1225
1226 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1227
1228         [ews-build] Reassign bots to queues
1229
1230         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1231
1232 2019-04-02  Chris Dumez  <cdumez@apple.com>
1233
1234         [WK2] Add support for Window's beforeprint / afterprint events
1235         https://bugs.webkit.org/show_bug.cgi?id=196478
1236
1237         Reviewed by Alex Christensen.
1238
1239         Add minimal implementation for printFrame in WebKitTestRunner.
1240
1241         * WebKitTestRunner/TestController.cpp:
1242         (WTR::printFrame):
1243         (WTR::TestController::createOtherPage):
1244         (WTR::TestController::createWebViewWithOptions):
1245
1246 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1247
1248         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1249         https://bugs.webkit.org/show_bug.cgi?id=196491
1250
1251         Reviewed by Lucas Forschler.
1252
1253         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1254
1255 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1256
1257         [ews-build] Configure buildbot try credentials in environment variables
1258         https://bugs.webkit.org/show_bug.cgi?id=196501
1259
1260         Reviewed by Lucas Forschler.
1261
1262         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1263         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1264         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1265
1266 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1267
1268         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1269         https://bugs.webkit.org/show_bug.cgi?id=196496
1270         <rdar://problem/49521634>
1271
1272         Reviewed by Chris Dumez.
1273
1274         Add new API tests (see WebKit ChangeLog for more detail).
1275
1276         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1277         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1278         (TEST):
1279
1280 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1281
1282         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1283         <https://webkit.org/b/196499>
1284
1285         Reviewed by Alexey Proskuryakov.
1286
1287         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1288         ENABLE_ADDRESS_SANITIZER.
1289
1290 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1291
1292         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1293         https://bugs.webkit.org/show_bug.cgi?id=182757
1294
1295         Reviewed by Don Olmstead.
1296
1297         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1298         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1299
1300 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1301
1302         run-api-tests: Upload test results
1303         https://bugs.webkit.org/show_bug.cgi?id=196323
1304         <rdar://problem/49356714>
1305
1306         Reviewed by Lucas Forschler.
1307
1308         * Scripts/webkitpy/api_tests/manager.py:
1309         (Manager):
1310         (Manager.run): Upload results to a results database.
1311         * Scripts/webkitpy/api_tests/run_api_tests.py:
1312         (parse_args): Add upload arguments.
1313         * Scripts/webkitpy/port/base.py:
1314         (Port):
1315         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1316         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1317         with commits from any other associated repositories.
1318         * Scripts/webkitpy/port/device.py:
1319         (Device):
1320         (Device.build_version): Access build_versoin of underlying platform device.
1321         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1322         (IOSSimulatorTest):
1323         (IOSSimulatorTest.test_configuration_for_upload):
1324         * Scripts/webkitpy/port/device_port.py:
1325         (DevicePort):
1326         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1327         the same as the machine uploading results.
1328         * Scripts/webkitpy/port/mac.py:
1329         (MacPort):
1330         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1331         * Scripts/webkitpy/port/mac_unittest.py:
1332         (MacTest):
1333         (MacTest.test_configuration_for_upload):
1334         * Scripts/webkitpy/xcode/simulated_device.py:
1335         (SimulatedDeviceManager._create_device_with_runtime):
1336         (SimulatedDevice.__init__): Create simulated device with a build_version.
1337         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1338         (test_existing_simulator):
1339
1340 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1341
1342         Remove extra newline characters (Follow-up fix to r243707)
1343
1344         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1345
1346 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1347
1348         [ews-app] Use API_KEY to accept results data
1349         https://bugs.webkit.org/show_bug.cgi?id=196461
1350
1351         Reviewed by Dewei Zhu.
1352
1353         * BuildSlaveSupport/ews-app/ews/views/results.py:
1354         (Results.post): Validate EWS_API_KEY before accepting any data.
1355         * BuildSlaveSupport/ews-build/events.py:
1356         (Events.sendData): Send EWS_API_KEY if available along with event data.
1357
1358 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1359
1360         Unable to copy and paste a PDF from Notes into Mail compose body
1361         https://bugs.webkit.org/show_bug.cgi?id=196442
1362         <rdar://problem/48573098>
1363
1364         Reviewed by Tim Horton.
1365
1366         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1367         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1368         to be specified on the item providers.
1369
1370         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1371         (TestWebKitAPI::mapItemForTesting):
1372         (TestWebKitAPI::contactItemForTesting):
1373
1374 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1375
1376         Make UIWKDocumentContext rects per-character instead of per-word
1377         https://bugs.webkit.org/show_bug.cgi?id=196459
1378
1379         Reviewed by Wenson Hsieh.
1380
1381         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1382         (TEST):
1383         Adjust test results due to switching to per-character rects.
1384
1385 2019-04-01  Chris Dumez  <cdumez@apple.com>
1386
1387         UIProcess crash when a prewarmed process is terminated
1388         https://bugs.webkit.org/show_bug.cgi?id=196451
1389         <rdar://problem/49245471>
1390
1391         Reviewed by Geoffrey Garen.
1392
1393         Add API test coverage.
1394
1395         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1396         (TEST):
1397
1398 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1399
1400         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1401         https://bugs.webkit.org/show_bug.cgi?id=196449
1402
1403         Reviewed by Lucas Forschler.
1404
1405         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1406         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1407         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1408         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1409
1410 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1411
1412         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1413         https://bugs.webkit.org/show_bug.cgi?id=196444
1414
1415         Reviewed by Lucas Forschler.
1416
1417         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1418
1419 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1420
1421         Add SPI to canonicalize NSURLs with WTF::URL
1422         https://bugs.webkit.org/show_bug.cgi?id=196415
1423         <rdar://problem/44980271>
1424
1425         Reviewed by Darin Adler.
1426
1427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1428         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1429         (TestWebKitAPI::TEST):
1430
1431 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1432
1433         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1434         https://bugs.webkit.org/show_bug.cgi?id=196441
1435
1436         Reviewed by Carlos Garcia Campos.
1437
1438         Don't cache the wpe_view_backend object that might not exist yet at the
1439         time of EventSenderProxy constructor invocation, but instead retrieve
1440         that object whenever it's required for event dispatching. This should
1441         avoid crashes in this constructor now that it's invoked before any
1442         PlatformWindow has been set up (as changed in r243496).
1443
1444         * WebKitTestRunner/EventSenderProxy.h:
1445         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1446         (WTR::viewBackend):
1447         (WTR::EventSenderProxy::EventSenderProxy):
1448         (WTR::EventSenderProxy::mouseDown):
1449         (WTR::EventSenderProxy::mouseUp):
1450         (WTR::EventSenderProxy::mouseMoveTo):
1451         (WTR::EventSenderProxy::mouseScrollBy):
1452         (WTR::EventSenderProxy::keyDown):
1453         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1454
1455 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1456
1457         [Win][WebKit] MiniBrowser should support high DPI display
1458         https://bugs.webkit.org/show_bug.cgi?id=196391
1459
1460         Reviewed by Alex Christensen.
1461
1462         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1463         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1464         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1465         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1466
1467 2019-03-31  Sam Weinig  <weinig@apple.com>
1468
1469         Remove more i386 specific configurations
1470         https://bugs.webkit.org/show_bug.cgi?id=196430
1471
1472         Reviewed by Alexey Proskuryakov.
1473
1474         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1475         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1476
1477 2019-03-31  Andy Estes  <aestes@apple.com>
1478
1479         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1480         https://bugs.webkit.org/show_bug.cgi?id=196433
1481         <rdar://problem/49293305>
1482
1483         Reviewed by Tim Horton.
1484
1485         Enhanced API test coverage to include all navigation response policy decisions in both
1486         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1487
1488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1489         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1490         (TestWebKitAPI::TEST):
1491         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1492         (readFile):
1493         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1494         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1495         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1496         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1497         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1498         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1499         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1500         (-[QuickLookDelegate _downloadDidStart:]):
1501         (-[QuickLookDelegate _download:didReceiveResponse:]):
1502         (-[QuickLookDelegate _download:didReceiveData:]):
1503         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1504         (-[QuickLookDelegate _downloadDidFinish:]):
1505         (-[QuickLookDelegate _download:didFailWithError:]):
1506         (-[QuickLookDelegate _downloadDidCancel:]):
1507         (-[QuickLookDelegate verifyDownload]):
1508         (runTest):
1509         (runTestDecideBeforeLoading):
1510         (runTestDecideAfterLoading):
1511         (TEST):
1512         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1513         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1514         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1515         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1516         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1517         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1518         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1519         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1520         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1521         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1522         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1523         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1524         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1525         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1526
1527 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1528
1529         [CMake] add testdfg as target with build-jsc
1530         https://bugs.webkit.org/show_bug.cgi?id=196393
1531
1532         Reviewed by Saam Barati.
1533
1534         Added testdfg as one of the targets to build when
1535         using CMake.
1536
1537         * Scripts/build-jsc:
1538
1539 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1540
1541         Delete WebMetal implementation in favor of WebGPU
1542         https://bugs.webkit.org/show_bug.cgi?id=195418
1543
1544         Reviewed by Dean Jackson.
1545
1546         * DumpRenderTree/mac/DumpRenderTree.mm:
1547         (enableExperimentalFeatures):
1548         (resetWebPreferencesToConsistentValues):
1549         * Scripts/webkitperl/FeatureList.pm:
1550         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1551         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1552         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1553         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1554         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1555         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1556         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1557         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1558         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1559         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1560         (WTR::InjectedBundle::beginTesting):
1561         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1562         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1563         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1564
1565 2019-03-29  Chris Dumez  <cdumez@apple.com>
1566
1567         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1568         https://bugs.webkit.org/show_bug.cgi?id=196405
1569         <rdar://problem/49428130>
1570
1571         Reviewed by Wenson Hsieh.
1572
1573         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1574         the popover presentation methods to be no-ops. Use this in the new test added in
1575         r243523 so that we do not swizzle those methods for all tests. This is needed because
1576         those WatchOS tests rely on the popover getting presented and interactive.
1577
1578         * WebKitTestRunner/TestController.cpp:
1579         (WTR::updateTestOptionsFromTestHeader):
1580         * WebKitTestRunner/TestController.h:
1581         * WebKitTestRunner/TestOptions.h:
1582         (WTR::TestOptions::hasSameInitializationOptions const):
1583         * WebKitTestRunner/ios/TestControllerIOS.mm:
1584         (WTR::TestController::platformInitialize):
1585         (WTR::TestController::platformResetStateToConsistentValues):
1586
1587 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1588
1589         [Curl] Add Server Trust Evaluation Support.
1590         https://bugs.webkit.org/show_bug.cgi?id=191646
1591
1592         Reviewed by Fujii Hironori.
1593
1594         Implemented MiniBrowser UI for asking if user trusts the server.
1595
1596         * MiniBrowser/win/Common.cpp:
1597         (askServerTrustEvaluation):
1598         (replaceString):
1599         * MiniBrowser/win/Common.h:
1600         * MiniBrowser/win/MiniBrowserLib.rc:
1601         * MiniBrowser/win/MiniBrowserLibResource.h:
1602         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1603         (createPEMString):
1604         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1605         (WebKitBrowserWindow::canTrustServerCertificate):
1606         * MiniBrowser/win/WebKitBrowserWindow.h:
1607
1608 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1609
1610         Implement ResizeObserver.
1611         https://bugs.webkit.org/show_bug.cgi?id=157743
1612
1613         Reviewed by Simon Fraser.
1614
1615         Support resizeObserverEnabled webPreferences.
1616
1617         * DumpRenderTree/TestOptions.cpp:
1618         (TestOptions::TestOptions):
1619         * DumpRenderTree/TestOptions.h:
1620         * DumpRenderTree/mac/DumpRenderTree.mm:
1621         (setWebPreferencesForTestOptions):
1622         * DumpRenderTree/win/DumpRenderTree.cpp:
1623         (enableExperimentalFeatures):
1624         * Scripts/webkitperl/FeatureList.pm:
1625         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1626
1627 2019-03-28  John Wilander  <wilander@apple.com>
1628
1629         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1630         https://bugs.webkit.org/show_bug.cgi?id=196281
1631         <rdar://problem/48938748>
1632
1633         Reviewed by Alex Christensen.
1634
1635         This patch adds the function isStatisticsHasLocalStorage() to the
1636         TestRunner. With it, the page can query the WebsiteDataStore in the
1637         UI process to make sure that it sees LocalStorage.
1638
1639         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1640         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1641         (WTR::TestRunner::isStatisticsHasLocalStorage):
1642         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1643         * WebKitTestRunner/TestController.cpp:
1644         (WTR::TestController::isStatisticsHasLocalStorage):
1645         * WebKitTestRunner/TestController.h:
1646         * WebKitTestRunner/TestInvocation.cpp:
1647         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1648
1649 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1650
1651         API::Data::createWithoutCopying should do a null check before calling CFRelease
1652         https://bugs.webkit.org/show_bug.cgi?id=196276
1653         <rdar://problem/48059859>
1654
1655         Reviewed by Alex Christensen.
1656
1657         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1658
1659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1660         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1661         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1662         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1663         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1664         (TestWebKitAPI::TEST):
1665
1666 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1667
1668         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1669         https://bugs.webkit.org/show_bug.cgi?id=186276
1670
1671         Reviewed by Carlos Garcia Campos.
1672
1673         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1674         (webViewLoadChanged):
1675         (testWebResourceGetDataError):
1676         (testWebResourceGetDataEmpty):
1677         (beforeAll):
1678         (webViewloadChanged): Deleted.
1679
1680 2019-03-27  Andy Estes  <aestes@apple.com>
1681
1682         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1683         https://bugs.webkit.org/show_bug.cgi?id=196317
1684
1685         Reviewed by Dan Bernstein.
1686
1687         package-root copies built products into a staging directory using ditto(1), which does not
1688         follow symbolic links as it traverses a directory. Now that the files in
1689         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1690         itself, these become broken links when ditto'd into the staging directory.
1691
1692         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1693
1694         * Scripts/package-root:
1695
1696 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1697
1698         [ews-app] Update display text of Submit for ews analysis
1699         https://bugs.webkit.org/show_bug.cgi?id=196309
1700
1701         Reviewed by Dewei Zhu.
1702
1703         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1704
1705 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1706
1707         run-webkit-tests should check for leaks in WebKit processes
1708         <https://webkit.org/b/193772>
1709         <rdar://problem/46526680>
1710
1711         Reviewed by Ryosuke Niwa.
1712
1713         This works by doing the following:
1714         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1715           The list of child processes are returned one per line:
1716           process.name: pid
1717         - Run the "#LIST CHILD PROCESSES" command just before the
1718           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1719           processes on the ServerProcess object.
1720         - When the `--leaks` switch is handled, run check_for_leaks() on
1721           each child process after the main test harness.
1722
1723         * DumpRenderTree/mac/DumpRenderTree.mm:
1724         (handleControlCommand):
1725         - Use strncmp() instead of strcmp().
1726         - Add support for handling "#LIST CHILD PROCESSES" command.
1727
1728         * Scripts/webkitpy/port/base.py:
1729         (Port.check_for_leaks):
1730         * Scripts/webkitpy/port/darwin.py:
1731         (DarwinPort.check_for_leaks):
1732         - Rename redundant 'process_pid' argument to 'process_id'.
1733
1734         * Scripts/webkitpy/port/driver.py:
1735         (Driver.do_post_tests_work):
1736         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1737           longer the only command this sends to WebKitTestRunner.
1738         - If the `--leaks` switch is present, send the
1739           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1740           result using Port.set_webkit_processes().
1741         (Driver._parse_child_processes_output):
1742         - Add helper method to parse list of child process names and
1743           process IDs returned from WebKitTestRunner.
1744
1745         * Scripts/webkitpy/port/ios_device.py:
1746         (IOSDevicePort.check_for_leaks):
1747         - Rename redundant 'process_pid' argument to 'process_id'.
1748
1749         * Scripts/webkitpy/port/leakdetector.py:
1750         (LeakDetector._parse_leaks_output):
1751         - Return early if there is no leaks_output.
1752         (LeakDetector.check_for_leaks):
1753         - Rename redundant 'process_pid' argument to 'process_id'.
1754
1755         * Scripts/webkitpy/port/server_process.py:
1756         (ServerProcess.__init__):
1757         (ServerProcess.child_processes):
1758         (ServerProcess.set_child_processes):
1759         - Add instance variable to Port to store list of child process
1760           names and process IDs returned from WebKitTestRunner.
1761         (ServerProcess._start):
1762         - Clear self._child_processes.
1763         (ServerProcess.stop):
1764         - If self._child_processes is set, call
1765           self._port.check_for_leaks() for each child process.
1766
1767         * Scripts/webkitpy/port/server_process_unittest.py:
1768         (TrivialMockPort.check_for_leaks):
1769         - Rename redundant 'process_pid' argument to 'process_id'.
1770
1771         * Scripts/webkitpy/port/simulator_process.py:
1772         (SimulatorProcess.stop):
1773         - If self._child_processes is set, call
1774           self._port.check_for_leaks() for each child process.
1775
1776         * Scripts/webkitpy/port/watch_device.py:
1777         (WatchDevicePort.check_for_leaks):
1778         - Rename redundant 'process_pid' argument to 'process_id'.
1779
1780         * WebKitTestRunner/TestController.cpp:
1781         (WTR::TestController::dumpResponse):
1782         - Extract method from findAndDumpWorldLeaks() so that it may be
1783           reused by findAndDumpWebKitProcessIdentifiers().
1784         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1785         - Add method to output process name and process ID of both the
1786           WebContent and Networking processes.
1787         (WTR::TestController::findAndDumpWorldLeaks):
1788         - Fix missing newline in output when there were no abandoned
1789           documents.
1790         - Call dumpResponse() for extracted code.
1791         (WTR::TestController::handleControlCommand):
1792         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1793         - Use strncmp() instead of strcmp().
1794         - Call findAndDumpWebKitProcessIdentifiers() when
1795           "#LIST CHILD PROCESSES" command is sent.
1796         * WebKitTestRunner/TestController.h:
1797         (WTR::TestController::dumpResponse):
1798         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1799         - Declare methods.
1800
1801 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1802
1803         Unreviewed. Add GLib API test cases after r243434.
1804
1805         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1806         (testWebViewActiveURI):
1807         (serverCallback):
1808         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1809         (sendRequestCallback):
1810
1811 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1812
1813         Geolocation request not complete when watch request was started in a different web process
1814         https://bugs.webkit.org/show_bug.cgi?id=195996
1815
1816         Reviewed by Alex Christensen.
1817
1818         Add a test case.
1819
1820         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1821         (TestWebKitAPI::runJavaScriptAlert):
1822         (TestWebKitAPI::TEST):
1823
1824 2019-03-26  Keith Rollin  <krollin@apple.com>
1825
1826         Update the way generate-xcfilelists returns strings from functions
1827         https://bugs.webkit.org/show_bug.cgi?id=195975
1828         <rdar://problem/49040807>
1829
1830         Reviewed by Dean Jackson.
1831
1832         There are places where generate-xcfilelists executes assignments with
1833         statements like:
1834
1835             FOO=$(some_function)
1836
1837         where "some_function" return a string by echoing it. E.g.
1838
1839             some_function()
1840             {
1841                 echo "Hello, World"
1842             }
1843
1844         This is a common idiom, but it has a problem if "some_function" needs
1845         to call "exit" in an attempt to halt the entire script right then and
1846         there. Since "some_function" is called inside of $(), it's being
1847         executed in a sub-shell. Calling exit in that sub-shell simply exits
1848         that shell; it doesn't not exit the outer shell in which the main part
1849         of the script is still running. As such, the main script keeps
1850         executing when the intent was for the script to halt.
1851
1852         The solution to this is to use a different idiom for returning
1853         strings. The one we now is to pass in the name of the variable to
1854         receive the string result:
1855
1856             some_function()
1857             {
1858                 variable_name=$1
1859                 eval $variable_name ="Hello, World"
1860             }
1861
1862         The call site now looks like
1863
1864             some_function FOO
1865
1866         Because there's no invocation of a sub-shell, some_function can now
1867         call "exit" if it wants to, and the entire script will exit at that
1868         point.
1869
1870         * Scripts/generate-xcfilelists:
1871
1872 2019-03-26  Chris Dumez  <cdumez@apple.com>
1873
1874         Add basic layout test coverage for File Picker on iOS
1875         https://bugs.webkit.org/show_bug.cgi?id=196265
1876
1877         Reviewed by Wenson Hsieh.
1878
1879         Add layout test infrastructure to test the file picker on iOS.
1880
1881         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1882         (WTR::UIScriptController::dismissFilePicker):
1883         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1884         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1885         (WTR::UIScriptController::dismissFilePicker):
1886         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1887         * WebKitTestRunner/TestController.cpp:
1888         (WTR::TestController::createWebViewWithOptions):
1889         (WTR::updateTestOptionsFromTestHeader):
1890         * WebKitTestRunner/TestOptions.h:
1891         (WTR::TestOptions::hasSameInitializationOptions const):
1892         * WebKitTestRunner/ios/TestControllerIOS.mm:
1893         (overridePresentViewController):
1894         (WTR::TestController::platformInitialize):
1895         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1896         (WTR::UIScriptController::dismissFilePicker):
1897
1898 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1899
1900         Implement async paste method on UIWKInteractionViewProtocol
1901         https://bugs.webkit.org/show_bug.cgi?id=196267
1902         <rdar://problem/49236346>
1903
1904         Reviewed by Tim Horton.
1905
1906         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1907         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1908         are now a part of all iOS 12 internal SDKs.
1909
1910         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1911
1912         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1913         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1914
1915         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1916         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1917         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1918         * TestWebKitAPI/ios/UIKitSPI.h:
1919
1920 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1921
1922         [ews-build] Use PostgreSQL for ews.webkit.org database
1923         https://bugs.webkit.org/show_bug.cgi?id=196270
1924
1925         Reviewed by Lucas Forschler.
1926
1927         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1928
1929 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1930
1931         [ews] Reset simctl states on reboot
1932         https://bugs.webkit.org/show_bug.cgi?id=196260
1933
1934         Rubber-stamped by Aakash Jain.
1935
1936         * EWSTools/start-queue-mac.sh:
1937
1938 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1939
1940         [ews-build] Use PostgreSQL for ews-build database
1941         https://bugs.webkit.org/show_bug.cgi?id=196229
1942
1943         Reviewed by Lucas Forschler.
1944
1945         * BuildSlaveSupport/ews-build/master.cfg:
1946
1947 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1948
1949         [ews-build] Get master_hostname dynamically in master.cfg
1950         https://bugs.webkit.org/show_bug.cgi?id=196255
1951
1952         Reviewed by Lucas Forschler.
1953
1954         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1955         send events data in test mode.
1956
1957 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1958
1959         [ews-app] Set db_constraint to False for Foreign Keys
1960         https://bugs.webkit.org/show_bug.cgi?id=196252
1961
1962         Reviewed by Lucas Forschler.
1963
1964         * BuildSlaveSupport/ews-app/ews/models/build.py:
1965         * BuildSlaveSupport/ews-app/ews/models/step.py:
1966
1967 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1968
1969         [ews-build] is_test_mode_enabled should default to True
1970         https://bugs.webkit.org/show_bug.cgi?id=196248
1971
1972         Reviewed by Lucas Forschler.
1973
1974         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1975
1976 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1977
1978         [ews-app] Add webkitperl to ENABLED_QUEUES
1979         https://bugs.webkit.org/show_bug.cgi?id=196253
1980
1981         Reviewed by Lucas Forschler.
1982
1983         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1984
1985 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1986
1987         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1988         https://bugs.webkit.org/show_bug.cgi?id=196211
1989         rdar://problem/49110552
1990
1991         Reviewed by Tim Horton.
1992
1993         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1994         Make sure that EventSenderProxy always exists when running tests. We used to create
1995         it when resetting before the first test, which is a bit too late.
1996
1997         * WebKitTestRunner/TestController.h:
1998         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1999         (WTR::TestController::platformCreateWebView):
2000         (WTR::TestController::platformCreateOtherPage):
2001         (WTR::TestController::finishCreatingPlatformWebView):
2002         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2003         (WTR::PlatformWebView::PlatformWebView):
2004         Moved some code that made NSWindow use NSEvent during web view creation. We may
2005         need to move more if some other case us found, but this is enough for now.
2006
2007 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2008
2009         Unreviewed. Fix typo in GLib geolocation API after r243285.
2010
2011         gelocation -> geolocation.
2012
2013         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2014         (testGeolocationManagerWatchPosition):
2015
2016 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2017
2018         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2019         https://bugs.webkit.org/show_bug.cgi?id=196213
2020
2021         Reviewed by Geoff Garen.
2022
2023         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2024         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2025         (credentialWithIdentityAndKeychainPath):
2026         (-[ChallengeDelegate webView:didFinishNavigation:]):
2027         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2028         (TestWebKitAPI::TEST):
2029
2030 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2031
2032         Expected shouldn't assume its contained types are copyable
2033         https://bugs.webkit.org/show_bug.cgi?id=195986
2034
2035         Reviewed by JF Bastien.
2036
2037         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2038         (TestWebKitAPI::NonCopyable::operator== const):
2039         (TestWebKitAPI::NonCopyable::operator!= const):
2040         (TestWebKitAPI::TEST):
2041
2042 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2043
2044         Remove some now-unnecessary dynamic class lookup
2045         https://bugs.webkit.org/show_bug.cgi?id=196237
2046
2047         Reviewed by Simon Fraser.
2048
2049         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2050         (makeRequest):
2051         (TEST):
2052
2053 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2054
2055         Unreviewed, rolling out r243450.
2056
2057         AppleWin and WinCairo port builds get broken.
2058
2059         Reverted changeset:
2060
2061         "Add test for fix of #196095"
2062         https://bugs.webkit.org/show_bug.cgi?id=196097
2063         https://trac.webkit.org/changeset/243450
2064
2065 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2066
2067         Unreviewed, rolling out r243465.
2068         https://bugs.webkit.org/show_bug.cgi?id=196226
2069
2070         the test doesn't build (Requested by thorton on #webkit).
2071
2072         Reverted changeset:
2073
2074         "Do not terminate the NetworkProcess if a third party
2075         application sends a NSCredential with a SecIdentityRef"
2076         https://bugs.webkit.org/show_bug.cgi?id=196213
2077         https://trac.webkit.org/changeset/243465
2078
2079 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2080
2081         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2082         https://bugs.webkit.org/show_bug.cgi?id=196213
2083
2084         Reviewed by Geoff Garen.
2085
2086         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2087         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2088         (credentialWithIdentityAndKeychainPath):
2089         (-[ChallengeDelegate webView:didFinishNavigation:]):
2090         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2091         (TestWebKitAPI::TEST):
2092
2093 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2094
2095         [ews-build] Gracefully handle missing patch_id in events
2096         https://bugs.webkit.org/show_bug.cgi?id=196216
2097
2098         Reviewed by Lucas Forschler.
2099
2100         * BuildSlaveSupport/ews-build/events.py:
2101
2102 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2103
2104         [ews-build] use lz4 compression for improving buildbot performance
2105         https://bugs.webkit.org/show_bug.cgi?id=196155
2106
2107         Reviewed by Lucas Forschler.
2108
2109         * BuildSlaveSupport/ews-build/master.cfg:
2110
2111 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2112
2113         Pull some API testing helper methods out of TestWKWebView
2114         https://bugs.webkit.org/show_bug.cgi?id=196212
2115
2116         Reviewed by Tim Horton.
2117
2118         Refactor some more API testing utility methods, so that they can be used in
2119         tests that do not use TestWKWebView.
2120
2121         * TestWebKitAPI/cocoa/TestWKWebView.h:
2122         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2123         (-[WKWebView loadTestPageNamed:]):
2124         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2125         (-[WKWebView synchronouslyLoadHTMLString:]):
2126         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2127         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2128         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2129         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2130         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2131
2132 2019-03-25  Jer Noble  <jer.noble@apple.com>
2133
2134         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2135         https://bugs.webkit.org/show_bug.cgi?id=196097
2136
2137         Reviewed by Eric Carlson.
2138
2139         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2140
2141         * DumpRenderTree/mac/DumpRenderTree.mm:
2142         (resetWebPreferencesToConsistentValues):
2143         * WebKitTestRunner/TestController.cpp:
2144         (WTR::TestController::resetPreferencesToConsistentValues):
2145
2146 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2147
2148         Pull IPadUserInterfaceSwizzler out into a separate header file
2149         https://bugs.webkit.org/show_bug.cgi?id=196193
2150
2151         Reviewed by Anders Carlsson.
2152
2153         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2154         be used in other API tests.
2155
2156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2157         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2158         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2159         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2160         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2161         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2162         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2163
2164 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2165
2166         Remove NavigatorContentUtils in WebCore/Modules
2167         https://bugs.webkit.org/show_bug.cgi?id=196070
2168
2169         Reviewed by Alex Christensen.
2170
2171         NavigatorContentUtils was to support the custom scheme spec [1].
2172         However, in WebKit side, no port has supported the feature in
2173         WebKit layer after EFL port was removed. So there has been the
2174         only IDL implementation of the NavigatorContentUtils in WebCore.
2175         So we don't need to keep the implementation in WebCore anymore.
2176
2177         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2178
2179         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2180
2181 2019-03-24  Andy Estes  <aestes@apple.com>
2182
2183         [watchOS] Remove unused Proximity Networking code
2184         https://bugs.webkit.org/show_bug.cgi?id=196188
2185
2186         Reviewed by Tim Horton.
2187
2188         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2189         (TEST):
2190
2191 2019-03-23  Keith Miller  <keith_miller@apple.com>
2192
2193         Refactor clz/ctz and fix getLSBSet.
2194         https://bugs.webkit.org/show_bug.cgi?id=196162
2195
2196         Reviewed by Saam Barati.
2197
2198         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2199
2200         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2201         (TestWebKitAPI::TEST):
2202
2203 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2204
2205         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2206         https://bugs.webkit.org/show_bug.cgi?id=196143
2207
2208         Reviewed by Michael Catanzaro.
2209
2210         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2211         directories.
2212
2213         * Scripts/webkitpy/style/checkers/cpp.py:
2214         (check_identifier_name_in_declaration):
2215         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2216         (WebKitStyleTest.test_names):
2217
2218 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2219
2220         [Flatpak] Manifest expanding fails for qt WPE extension
2221         https://bugs.webkit.org/show_bug.cgi?id=196148
2222
2223         Reviewed by Alex Christensen.
2224
2225         * flatpak/flatpakutils.py:
2226         (expand_submodules_recurse): The last recurse manifest expand
2227         iteration might lead to a single module so take it into account
2228         and don't try to recurse further.
2229
2230 2019-03-22  Chris Dumez  <cdumez@apple.com>
2231
2232         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2233         https://bugs.webkit.org/show_bug.cgi?id=195348
2234         <rdar://problem/48622090>
2235
2236         Reviewed by Alex Christensen.
2237
2238         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2239         to NO when test.options().shouldIgnoreMetaViewport is false.
2240
2241         * WebKitTestRunner/ios/TestControllerIOS.mm:
2242         (WTR::TestController::platformConfigureViewForTest):
2243
2244 2019-03-22  Chris Dumez  <cdumez@apple.com>
2245
2246         Prewarmed processes should be usable with any website data store
2247         https://bugs.webkit.org/show_bug.cgi?id=196104
2248
2249         Reviewed by Alex Christensen.
2250
2251         Add API test coverage.
2252
2253         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2254         (runInitialWarmedProcessUsedTest):
2255         (TEST):
2256
2257 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2258
2259         Back out local changes to Alex's Subversion working directory
2260
2261         They were accidentally committed.
2262
2263         * Scripts/webkitpy/common/system/abstractexecutive.py:
2264         (AbstractExecutive.wait_newest):
2265         * Scripts/webkitpy/common/system/executive.py:
2266         (Executive.running_pids):
2267         * Scripts/webkitpy/common/system/executive_mock.py:
2268         (MockExecutive.running_pids):
2269         * Scripts/webkitpy/common/system/executive_unittest.py:
2270         (ExecutiveTest.serial_test_running_pids):
2271         * Scripts/webkitpy/port/darwin.py:
2272         (DarwinPort.check_for_leaks):
2273         * Scripts/webkitpy/port/leakdetector.py:
2274         (LeakDetector.check_for_leaks):
2275         - This was the hack attached to Bug 193772.
2276
2277         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2278         (+[WebKitTestRunnerEvent mouseLocation]):
2279         - This works around a crash on an internal build.
2280
2281 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2282
2283         Fix the build after r243354
2284         https://bugs.webkit.org/show_bug.cgi?id=196138
2285         <rdar://problem/49145951>
2286
2287         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2288         (TEST):
2289         * TestWebKitAPI/ios/UIKitSPI.h:
2290
2291 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2292
2293         Adopt UIWKDocumentContext
2294         https://bugs.webkit.org/show_bug.cgi?id=196040
2295         <rdar://problem/48642440>
2296
2297         Reviewed by Ryosuke Niwa.
2298
2299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2300         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2301         (makeRequest):
2302         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2303         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2304         (applyStyle):
2305         (TEST):
2306         Add tests for UIWKDocumentContext.
2307
2308         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2309         (TEST):
2310         (recursiveFindWKContentView): Deleted.
2311         * TestWebKitAPI/cocoa/TestWKWebView.h:
2312         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2313         (recursiveFindWKContentView):
2314         (-[TestWKWebView wkContentView]):
2315         * TestWebKitAPI/ios/UIKitSPI.h:
2316         Share the WKContentView finding code between tests.
2317
2318 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2319
2320         [iOS WK2] Turn on async overflow scrolling by default
2321         https://bugs.webkit.org/show_bug.cgi?id=196011
2322         rdar://problem/48453859
2323
2324         Reviewed by Antti Koivisto.
2325         
2326         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2327         since so many basic layout tests have different results when compositing is triggered for
2328         overflow.
2329         
2330         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2331
2332         * WebKitTestRunner/TestController.cpp:
2333         (WTR::TestController::resetPreferencesToConsistentValues):
2334
2335 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2336
2337         [ews-build] Retry API test in case of failures
2338         https://bugs.webkit.org/show_bug.cgi?id=196004
2339
2340         Reviewed by Lucas Forschler.
2341
2342         * BuildSlaveSupport/ews-build/steps.py:
2343         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2344         (CompileWebKitToT.doStepIf): Ditto.
2345         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2346         (ReRunAPITests): Re-run API tests.
2347         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2348         (RunAPITestsWithoutPatch): Run API tests without patch.
2349         (RunAPITestsWithoutPatch.doStepIf):
2350         (RunAPITestsWithoutPatch.hideStepIf):
2351         (RunAPITestsWithoutPatch.evaluateCommand):
2352         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2353         (AnalyzeAPITestsResults.start):
2354         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2355         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2356         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2357         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2358
2359 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2360
2361         [ews-build] Update queues configurations
2362         https://bugs.webkit.org/show_bug.cgi?id=196074
2363
2364         Reviewed by Dewei Zhu.
2365
2366         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2367         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2368
2369 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2370
2371         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2372         https://bugs.webkit.org/show_bug.cgi?id=195680
2373         <rdar://problem/48903534>
2374
2375         Unreviewed infrastructure fix.
2376
2377         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2378         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2379
2380 2019-03-21  Andy Estes  <aestes@apple.com>
2381
2382         [iOS] Apple Pay should be available in documents with no user agent scripts
2383         https://bugs.webkit.org/show_bug.cgi?id=196061
2384         <rdar://problem/48649391>
2385
2386         Reviewed by Brady Eidson.
2387
2388         Added API tests and related infrastructure.
2389
2390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2391         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2392         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2393         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2394         (TestWebKitAPI::TEST):
2395         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2396         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2397         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2398         * TestWebKitAPI/cocoa/TestProtocol.mm:
2399         (-[TestProtocol startLoading]):
2400         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2401         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2402         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2403         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2404
2405 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2406
2407         REGRESSSION (r243297): webkitpy tests broken
2408         https://bugs.webkit.org/show_bug.cgi?id=196108
2409
2410         Reviewed by Aakash Jain.
2411
2412         r243297 updated contributors.json, which broke a few unit tests.
2413
2414         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2415         (IRCCommandTest.test_whois):
2416         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2417
2418 2019-03-21  Chris Dumez  <cdumez@apple.com>
2419
2420         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2421         https://bugs.webkit.org/show_bug.cgi?id=196041
2422         <rdar://problem/49083230>
2423
2424         Reviewed by Alex Christensen.
2425
2426         Add API test coverage.
2427
2428         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2429         (TEST):
2430
2431 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2432
2433         Add SPI to inform applications of WKContentRuleList actions
2434         https://bugs.webkit.org/show_bug.cgi?id=195965
2435         <rdar://problem/42664365>
2436
2437         Reviewed by Geoff Garen.
2438
2439         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2440         (TestWebKitAPI::allActionsForResourceLoad):
2441         (TestWebKitAPI::testRequest):
2442         (TestWebKitAPI::TEST_F):
2443         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2444         (Notification::description):
2445         (Notification::operator== const):
2446         (toVector):
2447         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2448         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2449         (makeContentRuleList):
2450         (TEST):
2451         (makeWarnContentRuleList): Deleted.
2452
2453 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2454
2455         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2456         https://bugs.webkit.org/show_bug.cgi?id=196088
2457
2458         Reviewed by Brian Burg.
2459
2460         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2461         Support checks when only one platform is specified. Also deprecate macosx() and
2462         force the use of macos() instead.
2463
2464         * Scripts/webkitpy/style/checkers/cpp.py:
2465         (check_min_versions_of_wk_api_available):
2466         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2467         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2468
2469 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2470
2471         Update status inactive committers' status to 'contributor'.
2472
2473         * Scripts/webkitpy/common/config/contributors.json:
2474
2475 2019-03-21  Xan Lopez  <xan@igalia.com>
2476
2477         [JSC][x86] Drop support for x87 floating point
2478         https://bugs.webkit.org/show_bug.cgi?id=194853
2479
2480         Reviewed by Don Olmstead.
2481
2482         Force SSE2 on x86/32bit builds.
2483
2484         * Scripts/webkitdirs.pm:
2485         (generateBuildSystemFromCMakeProject):
2486
2487 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2488
2489         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2490         https://bugs.webkit.org/show_bug.cgi?id=196073
2491
2492         Reviewed by Michael Catanzaro.
2493
2494         Add test cases to check functions and constructors with no arguments but receiving user data.
2495
2496         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2497         (checkUserData):
2498         (testJSCFunction):
2499         (fooCreateWithUserData):
2500         (testJSCClass):
2501
2502 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2503
2504         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2505
2506         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2507
2508         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2509
2510 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2511
2512         [GTK][WPE] Add API to provide geolocation information
2513         https://bugs.webkit.org/show_bug.cgi?id=195940
2514
2515         Reviewed by Michael Catanzaro.
2516
2517         Add a new test to check the new API.
2518
2519         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2520         (testGeolocationManagerCurrentPosition):
2521         (testGeolocationManagerWatchPosition):
2522         (beforeAll):
2523         (afterAll):
2524         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2525         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2526         (beforeAll): Ditto.
2527         * TestWebKitAPI/glib/CMakeLists.txt:
2528
2529 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2530
2531         [GLib] Returning G_TYPE_OBJECT from a method does not work
2532         https://bugs.webkit.org/show_bug.cgi?id=195574
2533
2534         Reviewed by Michael Catanzaro.
2535
2536         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2537
2538         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2539         (getGFile):
2540         (getParent):
2541         (createGString):
2542         (getGString):
2543         (getGStringCopyWillRaise):
2544         (getGStringCopy):
2545         (getGStringStr):
2546         (getGStringLen):
2547         (freeGString):
2548         (testJSCClass):
2549
2550 2019-03-20  Saam Barati  <sbarati@apple.com>
2551
2552         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2553         https://bugs.webkit.org/show_bug.cgi?id=195721
2554
2555         Reviewed by Filip Pizlo.
2556
2557         * Scripts/run-javascriptcore-tests:
2558
2559 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2560
2561         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2562         https://bugs.webkit.org/show_bug.cgi?id=196049
2563
2564         Reviewed by Tim Horton.
2565
2566         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2567         overflow scrolling in general, so rename it.
2568
2569         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2570
2571 2019-03-20  Daniel Bates  <dabates@apple.com>
2572
2573         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2574         https://bugs.webkit.org/show_bug.cgi?id=196031
2575         <rdar://problem/49078172>
2576
2577         Reviewed by Tim Horton.
2578
2579         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2580         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2581         same code path used when the Done button is pressed to dismiss the <select> picker.
2582
2583         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2584         (TestWebKitAPI::TEST):
2585
2586 2019-03-20  Chris Dumez  <cdumez@apple.com>
2587
2588         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2589         https://bugs.webkit.org/show_bug.cgi?id=196029
2590         <rdar://problem/48954651>
2591
2592         Reviewed by Tim Horton.
2593
2594         Add API test coverage.
2595
2596         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2597
2598 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2599
2600         [ews-build] Improve failure summary string for ApplyPatch step
2601         https://bugs.webkit.org/show_bug.cgi?id=195995
2602
2603         Reviewed by Alexey Proskuryakov.
2604
2605         * BuildSlaveSupport/ews-build/steps.py:
2606         (ApplyPatch.getResultSummary): Override getResultSummary.
2607
2608 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2609
2610         AX: Implement support for new meter ARIA role
2611         https://bugs.webkit.org/show_bug.cgi?id=195966
2612
2613         Reviewed by Chris Fleizach.
2614
2615         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2616         to AXLevelIndicator.
2617
2618         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2619
2620 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2621
2622         [WebAuthN] Implement FIDO AppID extension
2623         https://bugs.webkit.org/show_bug.cgi?id=143491
2624         <rdar://problem/48298273>
2625
2626         Reviewed by Brent Fulgham.
2627
2628         Add a test that covers the new flag of convertToU2fSignCommand.
2629
2630         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2631         (TestWebKitAPI::TEST):
2632         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2633         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2634         (TestWebKitAPI::TEST):
2635
2636 2019-03-19  Keith Rollin  <krollin@apple.com>
2637
2638         Add support for more platforms to generate-xcfilelists
2639         https://bugs.webkit.org/show_bug.cgi?id=195977
2640
2641         Reviewed by Alexey Proskuryakov.
2642
2643         generate-xcfilelists incorrectly complains when involved with building
2644         WebKit for iphonesimulator:
2645
2646             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2647             …
2648             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2649
2650         Address this by teaching generate-xcfilelists about more platforms.
2651
2652         * Scripts/generate-xcfilelists:
2653
2654 2019-03-19  John Wilander  <wilander@apple.com>
2655
2656         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2657         https://bugs.webkit.org/show_bug.cgi?id=195923
2658         <rdar://problem/49001272>
2659
2660         Reviewed by Alex Christensen.
2661
2662         This patch does the following to the TestRunner:
2663         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2664         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2665         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2666
2667         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2668         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2669         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2670         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2671         * WebKitTestRunner/TestController.cpp:
2672         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2673         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2674         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2675         * WebKitTestRunner/TestController.h:
2676         * WebKitTestRunner/TestInvocation.cpp:
2677         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2678
2679 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2680
2681         [CMake] Support more clang and gcc sanitizers
2682         https://bugs.webkit.org/show_bug.cgi?id=195956
2683
2684         Reviewed by Michael Catanzaro.
2685
2686         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2687
2688 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2689
2690         [ews-build] Improve summary for PrintConfiguration step
2691         https://bugs.webkit.org/show_bug.cgi?id=195945
2692
2693         Reviewed by Lucas Forschler.
2694
2695         * BuildSlaveSupport/ews-build/steps.py:
2696         (PrintConfiguration.getResultSummary): Override getResultSummary.
2697
2698 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2699
2700         [ews-build] Improve summary for CheckOutSource step
2701         https://bugs.webkit.org/show_bug.cgi?id=195963
2702
2703         Reviewed by Lucas Forschler.
2704
2705         * BuildSlaveSupport/ews-build/steps.py:
2706         (CheckOutSource.getResultSummary):
2707
2708 2019-03-19  Daniel Bates  <dabates@apple.com>
2709
2710         [iOS] Focus not preserved when switching between tabs
2711         https://bugs.webkit.org/show_bug.cgi?id=195820
2712         <rdar://problem/43614450>
2713
2714         Reviewed by Brent Fulgham.
2715
2716         Add tests to ensure that we restore focus when resigning and becoming first responder.
2717
2718         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2719         (TestWebKitAPI::TEST):
2720
2721 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2722
2723         Make WTFLogChannelState and WTFLogLevel enum classes
2724         https://bugs.webkit.org/show_bug.cgi?id=195904
2725
2726         Reviewed by Eric Carlson.
2727
2728         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2729         (TestWebKitAPI::TEST_F):
2730
2731 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2732
2733         [GStreamer][EME] Backported mssdemux protection data crash fix
2734         https://bugs.webkit.org/show_bug.cgi?id=195918
2735
2736         Reviewed by Philippe Normand.
2737
2738         * gstreamer/jhbuild.modules:
2739         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2740
2741 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2742
2743         Unreviewed, rolling out r243132.
2744
2745         Broke GTK build
2746
2747         Reverted changeset:
2748
2749         "Make WTFLogChannelState and WTFLogLevel enum classes"
2750         https://bugs.webkit.org/show_bug.cgi?id=195904
2751         https://trac.webkit.org/changeset/243132
2752
2753 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2754
2755         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2756
2757         * Scripts/webkitdirs.pm:
2758         (builtDylibPathForName): Adjust the shared library name that's changed
2759         with the API version bump in r243073.
2760
2761 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2762
2763         Make WTFLogChannelState and WTFLogLevel enum classes
2764         https://bugs.webkit.org/show_bug.cgi?id=195904
2765
2766         Reviewed by Eric Carlson.
2767
2768         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2769         (TestWebKitAPI::TEST_F):
2770
2771 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2772
2773         Disable flaky test added in r2431100
2774         https://webkit.org/b/195785
2775
2776         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2777         (TestWebKitAPI::TEST):
2778         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2779
2780 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2781
2782         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2783         https://bugs.webkit.org/show_bug.cgi?id=195916
2784
2785         Reviewed by Tim Horton.
2786
2787         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2788         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2789
2790 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2791
2792         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2793
2794         * Scripts/webkitpy/common/config/contributors.json:
2795
2796 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2797
2798         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2799         https://bugs.webkit.org/show_bug.cgi?id=195785
2800
2801         Reviewed by Geoffrey Garen.
2802
2803         * TestWebKitAPI/TCPServer.cpp: Added.
2804         (TestWebKitAPI::TCPServer::TCPServer):
2805         (TestWebKitAPI::TCPServer::~TCPServer):
2806         (TestWebKitAPI::TCPServer::socketBindListen):
2807         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2808         * TestWebKitAPI/TCPServer.h: Added.
2809         (TestWebKitAPI::TCPServer::port const):
2810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2811         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2812         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2813         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2814         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2815         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2816         (TestWebKitAPI::respondSlowly):
2817         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2818         (TestWebKitAPI::downloadAtRate):
2819         (TestWebKitAPI::TEST):
2820
2821 2019-03-18  Saam Barati  <sbarati@apple.com>
2822
2823         Add a plan file for JetStream 2
2824         https://bugs.webkit.org/show_bug.cgi?id=190734
2825
2826         Reviewed by Mark Lam.
2827
2828         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2829
2830 2019-03-18  Chris Dumez  <cdumez@apple.com>
2831
2832         Delay WebProcess launch until a load is triggered in a Web view
2833         https://bugs.webkit.org/show_bug.cgi?id=195758
2834         <rdar://problem/48126013>
2835
2836         Reviewed by Geoff Garen.
2837
2838         Add API test coverage. Also update some existing API tests to not expect
2839         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2840
2841         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2842         (TestWebKitAPI::TEST):
2843         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2844         (TestWebKitAPI::TEST):
2845         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2846         (TEST):
2847         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2848         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2849         (TEST):
2850         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2851         (TEST):
2852         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2853
2854 2019-03-18  Xan Lopez  <xan@igalia.com>
2855
2856         [CMake] Prevent potential warning when determining $architecture
2857         https://bugs.webkit.org/show_bug.cgi?id=195891
2858
2859         Reviewed by Michael Catanzaro.
2860
2861         It's possible for generateBuildSystemForCMakeProject to be called
2862         before determineArchitecture() is ever called. This will make the
2863         first eq check with $architecture to be bogus (and print a
2864         warning). Change that to an eq check with architecture(), which
2865         implicitly calls determineArchitecture() if needed, and change all
2866         the other similar cases in the method in the same way to prevent
2867         future bugs like this one.
2868
2869         * Scripts/webkitdirs.pm:
2870         (generateBuildSystemFromCMakeProject):
2871
2872 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2873
2874         [WPE] Tarballs generated with “make dist” cannot build documentation
2875         https://bugs.webkit.org/show_bug.cgi?id=195885
2876
2877         Reviewed by Carlos Garcia Campos.
2878
2879         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2880
2881 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2882
2883         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2884         https://bugs.webkit.org/show_bug.cgi?id=195883
2885
2886         Reviewed by Carlos Garcia Campos.
2887
2888         * gtkdoc/gtkdoc.py:
2889         (GTKDoc._run_command): When commands fail to run, include the full command line for
2890         the program invocation and the output it has generated on the standard error stream.
2891
2892 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2893
2894         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2895         https://bugs.webkit.org/show_bug.cgi?id=195786
2896
2897         Reviewed by Philippe Normand.
2898
2899         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2900         * wpe/jhbuild.modules: Ditto.
2901
2902 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2903
2904         [ews-build] Don't run clean builds on EWS builders
2905         https://bugs.webkit.org/show_bug.cgi?id=195851
2906
2907         Reviewed by Geoffrey Garen.
2908
2909         * BuildSlaveSupport/ews-build/factories.py:
2910
2911 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2912
2913         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2914         https://bugs.webkit.org/show_bug.cgi?id=195849
2915
2916         Reviewed by Chris Dumez.
2917
2918         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2919
2920         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2921         (runWebsiteDataStoreCustomPaths):
2922
2923 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2924
2925         webkitpy: Upload test results
2926         https://bugs.webkit.org/show_bug.cgi?id=195755
2927         <rdar://problem/48896182>
2928
2929         Reviewed by Aakash Jain.
2930
2931         Establish a new format for uploading results that is not tied to layout tests, apply
2932         that format to webkitpy tests.
2933
2934         * Scripts/webkitpy/common/checkout/scm/git.py:
2935         (Git.native_branch): Return what branch the current checkout is on.
2936         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2937         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2938         * Scripts/webkitpy/common/checkout/scm/svn.py:
2939         (SVN.native_branch): Ditto.
2940         * Scripts/webkitpy/common/system/platforminfo.py:
2941         (PlatformInfo.build_version): Return a build version for Mac.
2942         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2943         (MockPlatformInfo.__init__):
2944         (MockPlatformInfo.build_version):
2945         * Scripts/webkitpy/results: Added.
2946         * Scripts/webkitpy/results/__init__.py: Added.
2947         * Scripts/webkitpy/results/options.py: Added.
2948         (upload_options): OptParse list for upload options.
2949         * Scripts/webkitpy/results/upload.py: Added.
2950         (Upload): Class which enforces the upload format expected by the results server.
2951         (Upload.Expectations):
2952         (Upload.create_configuration):
2953         (Upload.create_commit):
2954         (Upload.create_details):
2955         (Upload.create_run_stats):
2956         (Upload.create_test_result):
2957         (Upload.__init__):
2958         (Upload.Encoder): Encode Upload object as json.
2959         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2960         * Scripts/webkitpy/results/upload_unittest.py: Added.
2961         * Scripts/webkitpy/test/main.py:
2962         (Tester._parse_args): Add upload arguments.
2963         (Tester._run_tests): Allow results to be uploaded.
2964         * Scripts/webkitpy/test/runner.py:
2965         (Runner.__init__): Record which tests were run, rather than just counting them.
2966         (Runner.handle):
2967         * Scripts/webkitpy/test/runner_unittest.py:
2968         (RunnerTest.test_run):
2969         * Scripts/webkitpy/thirdparty/__init__.py:
2970         (AutoinstallImportHook.find_module): Add requests auto-install.
2971         (AutoinstallImportHook._install_requests):
2972         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2973         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2974
2975 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2976
2977         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2978         https://bugs.webkit.org/show_bug.cgi?id=195810
2979
2980         Reviewed by Tim Horton.
2981
2982         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2983         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2984         ending certain layout tests.
2985
2986         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2987         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2988         (-[TestRunnerWKWebView dealloc]):
2989         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2990
2991         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2992         helper method when destroying the web view, and when resetting state between tests.
2993
2994         * WebKitTestRunner/ios/TestControllerIOS.mm:
2995         (WTR::TestController::platformResetStateToConsistentValues):
2996
2997         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2998
2999 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3000
3001         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3002         https://bugs.webkit.org/show_bug.cgi?id=190350
3003         <rdar://problem/45089503>
3004
3005         Reviewed by Geoffrey Garen.
3006
3007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3008         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3009         (TEST):
3010         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3011         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3012         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3013         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3014         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3015         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3016         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3017         (runTest):
3018         (createDirectories):
3019         (TEST):
3020         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3021         (TEST):
3022         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3023         (TEST):
3024
3025 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3026
3027         Add support to WebPage for getting the contents as an attributed string.
3028         https://bugs.webkit.org/show_bug.cgi?id=195636
3029         rdar://problem/45055697
3030
3031         Reviewed by Tim Horton.
3032
3033         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3034         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3035
3036 2019-03-15  Chris Dumez  <cdumez@apple.com>
3037
3038         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3039         https://bugs.webkit.org/show_bug.cgi?id=195747
3040
3041         Reviewed by Geoff Garen.
3042
3043         Add API test coverage.
3044
3045         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3046
3047 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3048
3049         Unreviewed, rolling out r242952.
3050
3051         Causing API failures on iOS Simulator
3052
3053         Reverted changeset:
3054
3055         "[PSON] Make sure the WebProcessCache is leverage when
3056         relaunching a process after termination"
3057         https://bugs.webkit.org/show_bug.cgi?id=195747
3058         https://trac.webkit.org/changeset/242952
3059
3060 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3061
3062         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3063         https://bugs.webkit.org/show_bug.cgi?id=195740
3064
3065         Reviewed by Ross Kirsling.
3066
3067         window.open doesn't work for WebKitBrowserWindow because it is not
3068         implemented yet.
3069
3070         1. Implemented createNewPage callback of WKPageUIClient.
3071         2. Changed MainWindow to take a BrowserWindow factory function
3072           instead of BrowserWindowType to be flexible to create
3073           BrowserWindow with extra settings.
3074         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3075           because it is not relevant with MainWindow anymore.
3076
3077         * MiniBrowser/win/Common.cpp:
3078         (parseCommandLine):
3079         * MiniBrowser/win/Common.h:
3080         (CommandLineOptions::CommandLineOptions):
3081         * MiniBrowser/win/MainWindow.cpp:
3082         (MainWindow::MainWindow):
3083         (MainWindow::create):
3084         (MainWindow::init):
3085         (MainWindow::WndProc):
3086         * MiniBrowser/win/MainWindow.h:
3087         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3088         (PrintWebUIDelegate::createWebViewWithRequest):
3089         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3090         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3091         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3092         (WebKitBrowserWindow::updateProxySettings):
3093         (WebKitBrowserWindow::createNewPage):
3094         * MiniBrowser/win/WebKitBrowserWindow.h:
3095         * MiniBrowser/win/WinMain.cpp:
3096         (wWinMain):
3097
3098 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3099
3100         Make it possible to test scrolling tree layer manipulation more easily
3101         https://bugs.webkit.org/show_bug.cgi?id=195780
3102
3103         Reviewed by Tim Horton.
3104         
3105         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3106         cuts off communication of scrolling tree scrolls back to the web process
3107         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3108         allows tests to trigger scrolls which run the scrolling tree layer positioning
3109         logic, but never get another commit from the web process that might mask
3110         scrolling tree bugs.
3111         
3112         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3113         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3114         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3115
3116         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3117         (WTR::UIScriptController::scrollUpdatesDisabled const):
3118         (WTR::UIScriptController::setScrollUpdatesDisabled):
3119         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3120         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3121         (WTR::UIScriptController::scrollUpdatesDisabled const):
3122         (WTR::UIScriptController::setScrollUpdatesDisabled):
3123         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3124         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3125         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3126         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3127         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3128         * WebKitTestRunner/ios/TestControllerIOS.mm:
3129         (WTR::TestController::platformResetStateToConsistentValues):
3130         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3131         (WTR::UIScriptController::scrollUpdatesDisabled const):
3132         (WTR::UIScriptController::setScrollUpdatesDisabled):
3133
3134 2019-03-14  Youenn Fablet  <youenn@apple.com>
3135
3136         Move IDB storage in private browsing mode to NetworkProcess
3137         https://bugs.webkit.org/show_bug.cgi?id=195602
3138
3139         Reviewed by Brady Eidson.
3140
3141         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3142         (TEST):
3143
3144 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3145
3146         [ews-build] Make descriptionDone messages more readable
3147         https://bugs.webkit.org/show_bug.cgi?id=195760
3148
3149         Reviewed by Lucas Forschler.
3150
3151         * BuildSlaveSupport/ews-build/steps.py:
3152         * BuildSlaveSupport/ews-build/steps_unittest.py:
3153
3154 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3155
3156         [ews-build] Generate status-bubble hover-over messages
3157         https://bugs.webkit.org/show_bug.cgi?id=195680
3158
3159         Reviewed by Lucas Forschler.
3160
3161         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3162         (StatusBubble):
3163         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3164         on hover-over.
3165         (StatusBubble._iso_time):
3166         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3167         hover-over message.
3168         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3169
3170 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3171
3172         [ews-app] Gracefully handle the case when state_string is None
3173         https://bugs.webkit.org/show_bug.cgi?id=195753
3174
3175         Reviewed by Lucas Forschler.
3176
3177         * BuildSlaveSupport/ews-app/ews/models/build.py:
3178         * BuildSlaveSupport/ews-app/ews/models/step.py:
3179
3180 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3181
3182         [ews-app] Status bubble display pending for currently running build step
3183         https://bugs.webkit.org/show_bug.cgi?id=195744
3184
3185         Reviewed by Lucas Forschler.
3186
3187         * BuildSlaveSupport/ews-build/events.py:
3188         (Events.stepStarted): If state_string is pending, replace it with step name.
3189
3190 2019-03-14  Chris Dumez  <cdumez@apple.com>
3191
3192         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3193         https://bugs.webkit.org/show_bug.cgi?id=195750
3194
3195         Reviewed by Geoffrey Garen.
3196
3197         Add API test coverage.
3198
3199         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3200         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3201         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3202         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3203
3204 2019-03-14  Chris Dumez  <cdumez@apple.com>
3205
3206         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3207         https://bugs.webkit.org/show_bug.cgi?id=195747
3208
3209         Reviewed by Geoff Garen.
3210
3211         Add API test coverage.
3212
3213         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3214
3215 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3216
3217         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3218         https://bugs.webkit.org/show_bug.cgi?id=195725
3219         <rdar://problem/48545062>
3220
3221         Reviewed by Tim Horton.
3222
3223         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3224         handler is nil.
3225
3226         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3227         (TestWebKitAPI::TEST):
3228
3229 2019-03-13  Sam Weinig  <sam@webkit.org>
3230
3231         Add utility function to allow easy reverse range-based iteration of a container
3232         https://bugs.webkit.org/show_bug.cgi?id=195542
3233
3234         Reviewed by Antti Koivisto.
3235
3236         * TestWebKitAPI/CMakeLists.txt:
3237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3238         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3239         (TestWebKitAPI::TEST):
3240         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3241
3242 2019-03-13  Chris Dumez  <cdumez@apple.com>
3243
3244         Use a ServiceWorker process per registrable domain
3245         https://bugs.webkit.org/show_bug.cgi?id=195649
3246
3247         Reviewed by Youenn Fablet.
3248
3249         Update API test coverage.
3250
3251         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3252
3253 2019-03-13  Chris Dumez  <cdumez@apple.com>
3254
3255         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3256         https://bugs.webkit.org/show_bug.cgi?id=195684
3257         <rdar://problem/48294714>
3258
3259         Reviewed by Antti Koivisto.
3260
3261         Add API test coverage.
3262
3263         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3264
3265 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3266
3267         [ews-app] Remove unused patch view
3268         https://bugs.webkit.org/show_bug.cgi?id=195669
3269
3270         Reviewed by Lucas Forschler.
3271
3272         * BuildSlaveSupport/ews-app/ews/urls.py:
3273         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3274
3275 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3276
3277         [ews-app] Use Buildbot result code variables
3278         https://bugs.webkit.org/show_bug.cgi?id=195668
3279
3280         Reviewed by Alexey Proskuryakov.
3281
3282         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3283         (Buildbot): Added Buildbot result code variables.
3284         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3285         (StatusBubble._build_bubble): Used Buildbot result code variables.
3286
3287 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3288
3289         [Flatpak] Expand submodule recursively
3290         https://bugs.webkit.org/show_bug.cgi?id=195672
3291
3292         Building WPE with flatpak was impossible without that as it was raising an exception.
3293         Also update wpebackend-fdo to match what is built in jhbuild
3294
3295         Reviewed by Philippe Normand.
3296
3297         * flatpak/flatpakutils.py:
3298         (expand_submodules_recurse):
3299         (expand_manifest):
3300         * flatpak/org.webkit.WPEModules.yaml:
3301
3302 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3303
3304         [ews-app] status bubble should be hidden for certain builds
3305         https://bugs.webkit.org/show_bug.cgi?id=194597
3306
3307         Reviewed by Dewei Zhu.
3308
3309         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3310         (StatusBubble._build_bubble):
3311         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3312         because the patch didn't have relevant changes.
3313         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3314         in production yet.
3315
3316 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3317
3318         [Win] Fix a slew of simple clang-cl warnings.
3319         https://bugs.webkit.org/show_bug.cgi?id=195652
3320
3321         Reviewed by Don Olmstead.
3322
3323         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3324         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3325
3326 2019-03-12  Justin Fan  <justin_fan@apple.com>
3327
3328         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3329         https://bugs.webkit.org/show_bug.cgi?id=195518
3330         <rdar://problem/46322356>
3331
3332         Reviewed by Myles C. Maxfield.
3333
3334         * DumpRenderTree/DerivedSources-input.xcfilelist:
3335         * DumpRenderTree/DerivedSources-output.xcfilelist:
3336
3337 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3338
3339         Unreviewed, rolling out r242825.
3340         https://bugs.webkit.org/show_bug.cgi?id=195648
3341
3342         "Broke webkitpy tests with my change to
3343         lldb_dump_class_layout.py" (Requested by rmorisset on
3344         #webkit).
3345
3346         Reverted changeset:
3347
3348         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3349         classes with suspicious padding"
3350         https://bugs.webkit.org/show_bug.cgi?id=195573
3351         https://trac.webkit.org/changeset/242825
3352
3353 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3354
3355         [ews-build] Show status bubbles while the patch is waiting in queue
3356         https://bugs.webkit.org/show_bug.cgi?id=195618
3357
3358         Reviewed by Lucas Forschler.
3359
3360         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3361         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3362         enabled in initial deployment.
3363         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3364         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3365         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3366         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3367         (StatusBubble._build_bubbles_for_patch):
3368
3369 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3370
3371         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3372         https://bugs.webkit.org/show_bug.cgi?id=195573
3373
3374         Reviewed by Simon Fraser.
3375
3376         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3377
3378         * Scripts/dump-class-layout:
3379         (main):
3380         * lldb/lldb_dump_class_layout.py:
3381         (ClassLayout.__init__):
3382         (ClassLayout._compute_padding_recursive):
3383         (LLDBDebuggerInstance.dump_layout_for_classname):
3384         (LLDBDebuggerInstance):
3385         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3386         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3387
3388 2019-03-12  Chris Dumez  <cdumez@apple.com>
3389
3390         Device Orientation access permission should be denied unless explicitly granted by the client
3391         https://bugs.webkit.org/show_bug.cgi?id=195625
3392
3393         Reviewed by Youenn Fablet.
3394
3395         add API test coverage.
3396
3397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3398         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3399         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3400         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3401         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3402         (runDeviceOrientationTest):
3403         (TEST):
3404         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3405         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3406
3407 2019-03-12  Jer Noble  <jer.noble@apple.com>
3408
3409         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3410         https://bugs.webkit.org/show_bug.cgi?id=195137
3411         <rdar://problem/48810307>
3412
3413         Reviewed by Eric Carlson.
3414
3415         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3416         (TestWebKitAPI::TEST):
3417
3418 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3419
3420         [ews-build] Change urls from uat to production
3421         https://bugs.webkit.org/show_bug.cgi?id=195566
3422
3423         Reviewed by Lucas Forschler.
3424
3425         * BuildSlaveSupport/ews-app/ews/config.py:
3426         * BuildSlaveSupport/ews-build/events.py:
3427         * BuildSlaveSupport/ews-build/steps.py:
3428
3429 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3430
3431         [ews-build] change max_builds for local-worker to 1
3432         https://bugs.webkit.org/show_bug.cgi?id=195568
3433
3434         Reviewed by Lucas Forschler.
3435
3436         * BuildSlaveSupport/ews-build/loadConfig.py:
3437
3438 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3439
3440         Fix the build
3441
3442         * TestRunnerShared/spi/PencilKitTestSPI.h:
3443         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3444
3445 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3446
3447         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3448         https://bugs.webkit.org/show_bug.cgi?id=194131
3449
3450         Reviewed by Michael Catanzaro.
3451
3452         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3453         (uriChanged):
3454         (testUnfinishedSubresourceLoad):
3455         (serverCallback):
3456         (beforeAll):
3457
3458 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3459
3460         WTF::Expected should use std::addressof instead of operator&
3461         https://bugs.webkit.org/show_bug.cgi?id=195604
3462
3463         Reviewed by Myles Maxfield.
3464
3465         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3466         (TestWebKitAPI::Unique::Unique):
3467         (TestWebKitAPI::Unique::operator&):
3468         (TestWebKitAPI::TEST):
3469
3470 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3471
3472         Add Optional to Forward.h.
3473         https://bugs.webkit.org/show_bug.cgi?id=195586
3474
3475         Reviewed by Darin Adler.
3476
3477         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3478         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3479         Remove unnecessary includes from headers.
3480
3481 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3482
3483         Add testing API to hit-test and scroll overflow scrollers
3484         https://bugs.webkit.org/show_bug.cgi?id=195278
3485
3486         Reviewed by Antti Koivisto.
3487         
3488         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3489         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3490         
3491         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3492
3493         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3494         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3495         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3496         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3497         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3498         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3499         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3500         (WTR::enclosingScrollViewIncludingSelf):
3501         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3502
3503 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3504
3505         API test WebKit.RequestTextInputContext fails on iOS
3506         https://bugs.webkit.org/show_bug.cgi?id=195585
3507
3508         Reviewed by Wenson Hsieh and Simon Fraser.
3509
3510         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3511         (applyStyle):
3512         (TEST):
3513         Add a viewport, so that the coordinates match up on iOS.
3514         Scroll by moving the UIScrollView's contentOffset.
3515
3516 2019-03-11  Chris Dumez  <cdumez@apple.com>
3517
3518         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3519         https://bugs.webkit.org/show_bug.cgi?id=195506
3520         <rdar://problem/48733477>
3521
3522         Reviewed by Alex Christensen.
3523
3524         Add API test coverage.
3525
3526         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3527
3528 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3529
3530         Adding myself to contributors.json
3531
3532         Unreviewed, addming myself to contributors.json .
3533
3534         * Scripts/webkitpy/common/config/contributors.json:
3535
3536 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3537
3538         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3539         https://bugs.webkit.org/show_bug.cgi?id=195511
3540         <rdar://problem/44873269>
3541
3542         Reviewed by Darin Adler.
3543
3544         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3545         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3546         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3547         (TEST_F):
3548
3549 2019-03-11  Chris Dumez  <cdumez@apple.com>
3550
3551         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3552         https://bugs.webkit.org/show_bug.cgi?id=195561
3553
3554         Reviewed by Youenn Fablet.
3555
3556         Make sure the JS in the test requests for permission to receive device orientation events.
3557
3558         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3559
3560 2019-03-11  Youenn Fablet  <youenn@apple.com>
3561
3562         Allow storage quota increase by default in WTR
3563         https://bugs.webkit.org/show_bug.cgi?id=195541
3564
3565         Reviewed by Geoffrey Garen.
3566
3567         Allow storage quota increase by default in WTR.
3568         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3569         Use this for tests that explicitly need cache increase.
3570
3571         Instead of increasing quota by 2, make sure the next request is
3572         granted by adding all given parameters.
3573
3574         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3575         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3576         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3577         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3578         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3579         * WebKitTestRunner/TestController.cpp:
3580         (WTR::TestController::setAllowStorageQuotaIncrease):
3581         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3582         * WebKitTestRunner/TestController.h:
3583         * WebKitTestRunner/TestInvocation.cpp:
3584         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3585         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3586         (WTR::TestController::cocoaResetStateToConsistentValues):
3587         (WTR::TestController::setAllowStorageQuotaIncrease):
3588         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3589         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3590         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3591
3592 2019-03-11  Xan Lopez  <xan@igalia.com>
3593
3594         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3595         https://bugs.webkit.org/show_bug.cgi?id=194147
3596
3597         Reviewed by Michael Saboff.
3598
3599         To make --32-bit work correctly on Linux/64bit we need to:
3600
3601         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3602         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3603         unfortunately CMake only allows us to do this during
3604         crosscompilation, which is overkill here.
3605         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3606         pkg-config detection module uses the x86 .pc files instead of the
3607         x86_64 ones.
3608         - Set the -m32 flags for the compiler.
3609
3610         * Scripts/webkitdirs.pm:
3611         (generateBuildSystemFromCMakeProject):
3612
3613 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3614
3615         Add MotionMark-1.1 plan file for run-benchmark script.
3616         https://bugs.webkit.org/show_bug.cgi?id=195481
3617
3618         Rubber-stamped by Darin Adler.
3619
3620         Run-benchmark script should support MontionMark-1.1.
3621
3622         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3623
3624 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3625
3626         [ews-app] Add support for submit-to-ews url
3627         https://bugs.webkit.org/show_bug.cgi?id=195477
3628
3629         Reviewed by Lucas Forschler.
3630
3631         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3632         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3633         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3634         * BuildSlaveSupport/ews-app/ews/urls.py:
3635         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3636
3637 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3638
3639         Unreviewed, rolling out r242688, r242643, r242624.
3640
3641         Caused multiple layout test failures and crashes on iOS and macOS.
3642
3643         Reverted changeset:
3644
3645         "requestAnimationFrame should execute before the next frame"
3646         https://bugs.webkit.org/show_bug.cgi?id=177484
3647         https://trac.webkit.org/changeset/242624/webkit
3648
3649         * Tracing/SystemTracePoints.plist:
3650
3651 2019-03-11  John Wilander  <wilander@apple.com>
3652
3653         Resource Load Statistics: Make it possible exclude localhost from classification
3654         https://bugs.webkit.org/show_bug.cgi?id=195474
3655         <rdar://problem/47520577>
3656
3657         Reviewed by Brent Fulgham.
3658
3659         This patch allows for localhost to be excluded from classification and
3660         treatment as a prevalent resource.
3661
3662         The WebKit Tools change adds a new function called
3663         testRunner.setStatisticsIsRunningTest() which can be used to control this
3664         behavior.
3665
3666         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3667         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3668         (WTR::TestRunner::setStatisticsIsRunningTest):
3669         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3670         * WebKitTestRunner/TestController.cpp:
3671         (WTR::TestController::setStatisticsIsRunningTest):
3672         * WebKitTestRunner/TestController.h:
3673         * WebKitTestRunner/TestInvocation.cpp:
3674         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3675
3676 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3677
3678         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3679         https://bugs.webkit.org/show_bug.cgi?id=195560
3680
3681         Reviewed by Lucas Forschler.
3682
3683         * BuildSlaveSupport/ews-build/master.cfg:
3684
3685 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3686
3687         Unreviewed, rolling out r242698.
3688
3689         API test crashes on bots.
3690
3691         Reverted changeset:
3692
3693         "Add a WKContentRuleList variant that uses copied memory
3694         instead of mmap'd shared memory for class A containerized
3695         apps"
3696         https://bugs.webkit.org/show_bug.cgi?id=195511
3697         https://trac.webkit.org/changeset/242698
3698
3699 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3700
3701         [WPE] Enable web process sandbox
3702         https://bugs.webkit.org/show_bug.cgi?id=195169
3703
3704         Reviewed by Daniel Bates.
3705
3706         * wpe/install-dependencies:
3707         * wpe/jhbuild.modules:
3708
3709 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3710
3711         [ews-app] Use port 17000 for worker communication
3712         https://bugs.webkit.org/show_bug.cgi?id=195558
3713
3714         Reviewed by Lucas Forschler.
3715
3716         * BuildSlaveSupport/ews-build/master.cfg:
3717
3718 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3719
3720         [ews-build] unit-tests fail when passwords.json is missing
3721         https://bugs.webkit.org/show_bug.cgi?id=195557
3722
3723         Reviewed by Lucas Forschler.
3724
3725         * BuildSlaveSupport/ews-build/loadConfig.py:
3726         (loadBuilderConfig):
3727         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3728         (ConfigDotJSONTest.test_configuration):
3729         * BuildSlaveSupport/ews-build/master.cfg:
3730
3731 2019-03-11  Truitt Savell  <tsavell@apple.com>
3732
3733         Unreviewed, rolling out r242702.
3734
3735         Broke High Sierra builders.
3736
3737         Reverted changeset:
3738
3739         "Add utility function to allow easy reverse range-based
3740         iteration of a container"
3741         https://bugs.webkit.org/show_bug.cgi?id=195542
3742         https://trac.webkit.org/changeset/242702
3743
3744 2019-03-11  Sam Weinig  <sam@webkit.org>
3745
3746         Add utility function to allow easy reverse range-based iteration of a container
3747         https://bugs.webkit.org/show_bug.cgi?id=195542
3748
3749         Reviewed by Antti Koivisto.
3750
3751         * TestWebKitAPI/CMakeLists.txt:
3752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3753         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3754         (TestWebKitAPI::TEST):
3755         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3756
3757 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3758
3759         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3760         https://bugs.webkit.org/show_bug.cgi?id=195511
3761         <rdar://problem/44873269>
3762
3763         Reviewed by Darin Adler.
3764
3765         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3766         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3767         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3768         (TEST_F):
3769
3770 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3771
3772         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3773         https://bugs.webkit.org/show_bug.cgi?id=195499
3774
3775         Reviewed by Darin Adler.
3776
3777         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3778         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3779         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3780         (-[WKWebView synchronouslyFocusTextInputContext:]):
3781         (applyStyle):
3782         (applyIframe):
3783         (TEST):
3784         Add some tests for this SPI.
3785
3786 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3787
3788         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3789         https://bugs.webkit.org/show_bug.cgi?id=181151
3790
3791         Reviewed by Don Olmstead.
3792
3793         * TestWebKitAPI/CMakeLists.txt:
3794         * TestWebKitAPI/PlatformWin.cmake:
3795         Enable TestWTF RunLoop tests in all platforms.
3796
3797         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3798         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3799         (TestWebKitAPI::DerivedOneShotTimer::fired):
3800         (TestWebKitAPI::TEST):
3801         Only a few platforms support nested RunLoop.
3802
3803         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3804         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3805
3806 2019-03-10  David Quesada  <david_quesada@apple.com>
3807
3808         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3809         https://bugs.webkit.org/show_bug.cgi?id=152480
3810
3811         Reviewed by Chris Dumez.
3812
3813         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3814         there are no additional references to the process pool besides the one held by
3815         the download, waits for the download to finish (in the sense that the
3816         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3817         measure, also check that the process pool has been deallocated at the end of the
3818         test. The test wouldn't be meaningful if the process pool were still alive.
3819
3820         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3821         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3822         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3823             The download will be canceled because the delegate does not implement the
3824             method to decide the download's destination, so this is where we know the
3825             DownloadProxyMap is done with the DownloadProxy.
3826         (TEST):
3827
3828 2019-03-08  Chris Dumez  <cdumez@apple.com>
3829
3830         Add support for Device Orientation / Motion permission API
3831         https://bugs.webkit.org/show_bug.cgi?id=195329
3832         <rdar://problem/47645367>
3833
3834         Reviewed by Geoffrey Garen.
3835
3836         Add test infrastructure to help test the Device Orientation / Motion permission API.
3837
3838         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3839         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3840         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3841         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3842         * WebKitTestRunner/TestController.cpp:
3843         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3844         (WTR::TestController::createWebViewWithOptions):
3845         (WTR::TestController::resetStateToConsistentValues):
3846         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3847         * WebKitTestRunner/TestController.h:
3848         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3849         * WebKitTestRunner/TestInvocation.cpp:
3850         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3851
3852 2019-03-08  Saam barati  <sbarati@apple.com>
3853
3854         Add a compare-results script to compare benchmark results
3855         https://bugs.webkit.org/show_bug.cgi?id=195486
3856         <rdar://problem/48723397>
3857
3858         Reviewed by Geoffrey Garen.
3859
3860         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3861         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3862         to extend it to learn about our other benchmarks.
3863
3864         * Scripts/compare-results: Added.
3865         (readJSONFile):
3866         (detectJetStream2):
3867         (JetStream2Results):
3868         (detectSpeedometer2):
3869         (Speedometer2Results):
3870         (detectPLT5):
3871         (PLT5Results):
3872         (detectBenchmark):
3873         (biggerIsBetter):
3874         (ttest):
3875         (getOptions):
3876         (main):
3877
3878 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3879
3880         Ensure old tab state is cleared between iterations of run-benchmark
3881         https://bugs.webkit.org/show_bug.cgi?id=195393
3882         <rdar://problem/46885583>
3883
3884         Reviewed by Dewei Zhu.
3885
3886         a) ensure the default to restore state is not set
3887         b) terminate Safari correctly
3888         c) Set the system default to ignore Persistent State in Safari
3889
3890         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3891         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3892         (OSXBrowserDriver.prepare_env): 
3893         (OSXBrowserDriver.restore_env):
3894         (OSXBrowserDriver.close_browsers):
3895         (OSXBrowserDriver._terminate_processes):
3896         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3897         (OSXChromeDriver):
3898         (OSXChromeCanaryDriver):
3899         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3900         (OSXFirefoxDriver):
3901         (OSXFirefoxNightlyDriver):
3902         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3903         (OSXSafariDriver):
3904         (OSXSafariDriver.prepare_env):
3905
3906 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3907
3908         [GTK] Several InputMethodFilter tests are failing
3909         https://bugs.webkit.org/show_bug.cgi?id=195408
3910
3911         Reviewed by Carlos Garcia Campos.
3912
3913         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3914         Regressed in r241751.
3915         Hexadecimal values of keycodes are expressed now in upper letters.
3916         Composited characters should be cast to UTF8 strings.
3917
3918         (TestWebKitAPI::TEST):
3919
3920 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3921
3922         [GTK] Make Tools/gtkdoc python3 compatible
3923         https://bugs.webkit.org/show_bug.cgi?id=195359
3924
3925         Reviewed by Carlos Garcia Campos.
3926
3927         * gtkdoc/generate-gtkdoc:
3928         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3929         work with Python 2 and 3.
3930         (get_gtkdoc_module_paths):
3931         The iteritems() was removed in Python 3, so let's use items() that's
3932         available in Python 2 and 3.
3933         (get_generator_for_config):
3934         * gtkdoc/gtkdoc.py:
3935         (GTKDoc._run_command):
3936         The sys.stdout.write() is expecting str in Python 3 and not bytes
3937         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3938         for passing the bytes there.
3939
3940 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3941
3942         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3943         https://bugs.webkit.org/show_bug.cgi?id=195346
3944         <rdar://problem/48667048>
3945
3946         Unreviewed build fix for clang-cl.
3947
3948         * DumpRenderTree/win/DumpRenderTree.cpp:
3949         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3950
3951 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3952
3953         requestAnimationFrame should execute before the next frame
3954         https://bugs.webkit.org/show_bug.cgi?id=177484
3955
3956         Reviewed by Simon Fraser.
3957
3958         Add trace points for the page RenderingUpdate.
3959
3960         * Tracing/SystemTracePoints.plist:
3961
3962 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3963
3964         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3965         https://bugs.webkit.org/show_bug.cgi?id=195353
3966         <rdar://problem/48626394>
3967
3968         Reviewed by Simon Fraser.
3969
3970         * WebKitTestRunner/ios/TestControllerIOS.mm:
3971         (WTR::TestController::platformResetPreferencesToConsistentValues):
3972
3973 2019-03-07  John Wilander  <wilander@apple.com>
3974
3975         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3976         https://bugs.webkit.org/show_bug.cgi?id=195383
3977         <rdar://problem/48570136>
3978
3979         Reviewed by Brent Fulgham.
3980
3981         This patch adds test infrastructure to purge only script-accessible cookies,
3982         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3983
3984         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3985         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3986         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3987         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3988         * WebKitTestRunner/TestController.cpp:
3989         (WTR::TestController::statisticsDeleteCookiesForHost):
3990         * WebKitTestRunner/TestController.h:
3991         * WebKitTestRunner/TestInvocation.cpp:
3992         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3993
3994 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3995
3996         Unreviewed, rolling out r242354.
3997         https://bugs.webkit.org/show_bug.cgi?id=195402
3998
3999         breaks layout tests in all configurations (Requested by
4000         zdobersek on #webkit).
4001
4002         Reverted changeset:
4003
4004         "[WPE] Enable web process sandbox"
4005         https://bugs.webkit.org/show_bug.cgi?id=195169
4006         https://trac.webkit.org/changeset/242354
4007
4008 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
4009
4010         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4011         https://bugs.webkit.org/show_bug.cgi?id=195346
4012
4013         Reviewed by Fujii Hironori.
4014
4015         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
4016         (TestWebKitAPI::TEST):
4017         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
4018
4019         * DumpRenderTree/win/DumpRenderTree.cpp:
4020         (findFontFallback):
4021         (addFontFallbackIfPresent):
4022         (removeFontFallbackIfPresent):
4023         (main):
4024         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4025         (TestWebKitAPI::Util::moduleDirectory):
4026         (TestWebKitAPI::Util::createInjectedBundlePath):
4027         Use wchar helpers as needed.
4028
4029 2019-03-06  Rob Buis  <rbuis@igalia.com>
4030
4031         Consider supporting the `referrerpolicy` attribute.
4032         https://bugs.webkit.org/show_bug.cgi?id=179053
4033
4034         Reviewed by Darin Adler.
4035
4036         Add a runtime flag for referrerpolicy attribute.
4037
4038         * DumpRenderTree/mac/DumpRenderTree.mm:
4039         (enableExperimentalFeatures):
4040
4041 2019-03-05  Daniel Bates  <dabates@apple.com>
4042
4043         Update expected API test result following r242379
4044         (https://bugs.webkit.org/show_bug.cgi?id=195125)
4045
4046         Update expected x-coordinate of selection rect now that the left padding of
4047         a textarea is sized in ems (so dependent on the font size) just like the left
4048         padding of a text field.
4049
4050         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4051         (TestWebKitAPI::TEST):
4052
4053 2019-03-05  David Quesada  <david_quesada@apple.com>
4054
4055         [WK2] It should be possible to follow links with 'download' attributes
4056         https://bugs.webkit.org/show_bug.cgi?id=195145
4057         rdar://problem/48462642
4058
4059         Reviewed by Alex Christensen.
4060
4061         Add a unit test to verify that activating links with 'download' attributes now
4062         navigates to the linked resource, rather than starts downloading it. Add another
4063         to verify that it is still possible to explicitly download the link via the
4064         'Download' navigation action policy.
4065
4066         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4067         (-[DownloadAttributeTestDelegate init]):
4068         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
4069         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
4070         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
4071         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
4072         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4073         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
4074         (TEST):
4075         * WebKitTestRunner/TestController.cpp:
4076         (WTR::TestController::decidePolicyForNavigationAction):
4077         * WebKitTestRunner/TestController.h:
4078
4079 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
4080
4081         [Curl] Implement Cookie Accept Policy.
4082         https://bugs.webkit.org/show_bug.cgi?id=191645
4083
4084         Reviewed by Fujii Hironori.
4085
4086         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
4087         (TestWebKitAPI::Curl::TEST_F):
4088
4089 2019-03-05  Youenn Fablet  <youenn@apple.com>
4090
4091         Rename requestCacheStorageSpace to requestStorageSpace
4092         https://bugs.webkit.org/show_bug.cgi?id=195282
4093
4094         Reviewed by Chris Dumez.
4095
4096         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4097         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4098         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
4099
4100 2019-03-05  Brady Eidson  <beidson@apple.com>
4101
4102         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
4103         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
4104
4105         Reviewed by Tim Horton.
4106
4107         Loading a file: URL into a WKWebView and then loading another file: url from a completely
4108         different directory into that same WKWebView should work.
4109
4110         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4111         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
4112
4113 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
4114
4115         Add WeakHashSet
4116         https://bugs.webkit.org/show_bug.cgi?id=195152
4117
4118         Reviewed by Antti Koivisto.
4119
4120         Added tests for WeakHashSet.
4121
4122         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
4123         (TestWebKitAPI::Base::Base): Moved.
4124         (TestWebKitAPI::Derived::foo): Moved.
4125         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
4126         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
4127         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
4128         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
4129
4130 2019-03-04  Chris Dumez  <cdumez@apple.com>
4131
4132         Do not share WebProcesses between private and regular sessions
4133         https://bugs.webkit.org/show_bug.cgi?id=195189
4134         <rdar://problem/48421064>
4135
4136         Reviewed by Alex Christensen.
4137
4138         Add API test coverage.
4139
4140         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4141         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4142
4143 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
4144
4145         [WPE] Enable web process sandbox
4146         https://bugs.webkit.org/show_bug.cgi?id=195169
4147
4148         Reviewed by Daniel Bates.
4149
4150         * wpe/install-dependencies:
4151         * wpe/jhbuild.modules:
4152
4153 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4154
4155         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
4156         https://bugs.webkit.org/show_bug.cgi?id=195206
4157
4158         Reviewed by Žan Doberšek.
4159
4160         Add a new test case.
4161
4162         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4163         (testJSCClass):
4164
4165 2019-03-04  Charlie Turner  <cturner@igalia.com>
4166
4167         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
4168         https://bugs.webkit.org/show_bug.cgi?id=194898
4169
4170         Reviewed by Žan Doberšek.
4171
4172         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
4173         a GCC extension that permits arithmetic on void* pointer. Inline
4174         the macro until this issue is fixed upstream.
4175
4176 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4177
4178         Rid the world of WK_API_ENABLED
4179         https://bugs.webkit.org/show_bug.cgi?id=195263
4180
4181         Reviewed by Dan Bernstein.
4182
4183         List of changed files elided because it's useless.
4184
4185 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
4186
4187         Unreviewed follow-up to r242292.
4188
4189         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
4190
4191         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4192         (TestWebKitAPI::testStrip): Renamed from strip.
4193         (TestWebKitAPI::TEST):
4194
4195 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4196
4197         Unreviewed, remove accidentally-committed URLHelpers.cpp test
4198
4199         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
4200         and bug #194272 for details.
4201
4202         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4203
4204 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4205
4206         Remove some more unused 32-bit code
4207         https://bugs.webkit.org/show_bug.cgi?id=195255
4208
4209         Reviewed by Darin Adler.
4210
4211         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4212         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4213         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4214         (NPP_New):
4215         (NPP_HandleEvent):
4216         (handleEventCarbon): Deleted.
4217
4218 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4219
4220         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4221
4222         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4223         (TestWebKitAPI::TEST):
4224
4225 2019-03-01  Darin Adler  <darin@apple.com>
4226
4227         Finish removing String::format
4228         https://bugs.webkit.org/show_bug.cgi?id=194893
4229
4230         Reviewed by Daniel Bates.
4231 '
4232         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4233
4234 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4235
4236         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4237         https://bugs.webkit.org/show_bug.cgi?id=195229
4238         <rdar://problem/48520362>
4239
4240         Reviewed by Chris Dumez.
4241
4242         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4243         (TEST):
4244
4245 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4246
4247         Add a system trace scope for event region building
4248         https://bugs.webkit.org/show_bug.cgi?id=195226
4249
4250         Reviewed by Jon Lee.
4251
4252         This trace scope measures the time spend converting element rects into Region objects,
4253         which can be large on some pages.
4254
4255         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4256
4257         * Tracing/SystemTracePoints.plist:
4258
4259 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4260
4261         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4262         https://bugs.webkit.org/show_bug.cgi?id=194612
4263
4264         Reviewed by Alex Christensen.
4265
4266         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4267         Just test the new string-processing function and don't touch the actual environment.
4268         (Test cases are all as before, but based on operator== instead of strcmp.)
4269
4270 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4271
4272         [ews-app] Update primary keys for handling multiple Buildbot instances
4273         https://bugs.webkit.org/show_bug.cgi?id=195120
4274
4275         Reviewed by Stephanie Lewis.
4276
4277         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4278         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4279         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4280
4281         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4282         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4283         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4284         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4285         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4286         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4287
4288 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4289
4290         [WinCairo] Enable service worker
4291         https://bugs.webkit.org/show_bug.cgi?id=188318
4292
4293         Reviewed by Youenn Fablet.
4294
4295         * DumpRenderTree/DumpRenderTreePrefix.h:
4296         * TestWebKitAPI/PlatformWin.cmake:
4297         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4298         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4299         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4300
4301 2019-03-01  Justin Fan  <justin_fan@apple.com>
4302
4303         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4304         https://bugs.webkit.org/show_bug.cgi?id=195191
4305
4306         Rubber-stamped by Dean Jackson.
4307
4308         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4309
4310         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4311
4312 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4313
4314         Unreviewed, fix lldb webkitpy tests
4315         https://bugs.webkit.org/show_bug.cgi?id=194375
4316
4317         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4318
4319         * lldb/lldb_webkit.py:
4320         (WTFStringImplProvider.is_8bit):
4321
4322 2019-02-28  David Quesada  <david_quesada@apple.com>
4323
4324         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4325         https://bugs.webkit.org/show_bug.cgi?id=195121
4326         rdar://problem/48450302
4327
4328         Reviewed by Alex Christensen.
4329
4330         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4331         configurations where the 'download' attribute is absent, blank, or populated
4332         with a filename, and where the anchor element is same-origin or cross-origin
4333         (meaning the 'download' attribute shouldn't be honored).
4334
4335         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4336         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4337         (-[NavigationActionTestDelegate init]):
4338         (-[NavigationActionTestDelegate navigationAction]):
4339         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4340         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4341         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4342         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4343         (TEST):
4344
4345 2019-02-28  Antoine Quint  <graouts@apple.com>
4346
4347         Enable the Pointer Events runtime flag by default
4348         https://bugs.webkit.org/show_bug.cgi?id=195156
4349
4350         Reviewed by Dean Jackson.
4351
4352         * DumpRenderTree/mac/DumpRenderTree.mm:
4353         (enableExperimentalFeatures):
4354
4355 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4356
4357         Several PasteImage API tests are flaky
4358         https://bugs.webkit.org/show_bug.cgi?id=195160
4359
4360         Reviewed by Tim Horton.
4361
4362         Some of these tests