Hide next and previous form control buttons when WKWebView is editable
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Hide next and previous form control buttons when WKWebView is editable
4         https://bugs.webkit.org/show_bug.cgi?id=196672
5         <rdar://problem/35625321>
6
7         Reviewed by Tim Horton.
8
9         Add a new API test.
10
11         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
12         (-[TestWKWebView lastTrailingBarButtonGroup]):
13         (TestWebKitAPI::TEST):
14         * TestWebKitAPI/ios/UIKitSPI.h:
15
16 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
17
18         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
19         https://bugs.webkit.org/show_bug.cgi?id=196077
20         <rdar://problem/49108202>
21
22         Reviewed by Chris Dumez.
23
24         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
25         on new web view.
26
27         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
28
29 2019-04-05  Saam Barati  <sbarati@apple.com>
30
31         Make compare-results understand MotionMark
32         https://bugs.webkit.org/show_bug.cgi?id=196666
33
34         Reviewed by Yusuke Suzuki.
35
36         * Scripts/compare-results:
37         (PLT5Results):
38         (detectMotionMark):
39         (detectMotionMark1_1):
40         (motionMarkResults):
41         (motionMark1_1Results):
42         (detectBenchmark):
43         (biggerIsBetter):
44         (main):
45
46 2019-04-05  Alex Christensen  <achristensen@webkit.org>
47
48         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
49         https://bugs.webkit.org/show_bug.cgi?id=196665
50         <rdar://45115669>
51
52         Reviewed by Geoff Garen.
53
54         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
55         (goBack):
56         (+[SimpleLookupContext sharedLookupContext]):
57         (-[SimpleLookupContext lookUpURL:completionHandler:]):
58         (TEST):
59         (+[Simple3LookupContext sharedLookupContext]): Deleted.
60         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
61
62 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
63
64         [ews-build] Add configuration and architecture for windows builders
65         https://bugs.webkit.org/show_bug.cgi?id=196660
66
67         Reviewed by Lucas Forschler.
68
69         * BuildSlaveSupport/ews-build/config.json:
70
71 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
72
73         webkitpy: Don't run subsequent rounds if interrupted
74         https://bugs.webkit.org/show_bug.cgi?id=196646
75
76         Reviewed by Aakash Jain.
77
78         * Scripts/webkitpy/layout_tests/controllers/manager.py:
79         (Manager.run): Bail out if interrupted.
80
81 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
82
83         Test sessionStorage in PSON private browsing mode
84         https://bugs.webkit.org/show_bug.cgi?id=196561
85
86         Reviewed by Alex Christensen.
87
88         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
89
90 2019-04-05  Commit Queue  <commit-queue@webkit.org>
91
92         Unreviewed, rolling out r243833.
93         https://bugs.webkit.org/show_bug.cgi?id=196645
94
95         This change breaks build of WPE and GTK ports (Requested by
96         annulen on #webkit).
97
98         Reverted changeset:
99
100         "[CMake][WTF] Mirror XCode header directories"
101         https://bugs.webkit.org/show_bug.cgi?id=191662
102         https://trac.webkit.org/changeset/243833
103
104 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
105
106         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
107         https://bugs.webkit.org/show_bug.cgi?id=196635
108
109         Reviewed by Antti Koivisto.
110         
111         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
112         for a test to enable async frame scrolling via:
113             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
114         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
115         
116         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
117
118         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
119         (WTR::InjectedBundle::beginTesting):
120         * WebKitTestRunner/TestController.cpp:
121         (WTR::TestController::resetPreferencesToConsistentValues):
122
123 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
124
125         Use a correct LC_RPATH when building with ASan
126         https://bugs.webkit.org/show_bug.cgi?id=196576
127
128         Reviewed by David Kilzer.
129
130         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
131         so that ../Frameworks is checked. This is simpler and more reliable than updating
132         each SPC service xcconfig.
133
134 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
135
136         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
137         https://bugs.webkit.org/show_bug.cgi?id=196629
138
139         Reviewed by Lucas Forschler.
140
141         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
142
143 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
144
145         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
146         https://bugs.webkit.org/show_bug.cgi?id=196618
147
148         Reviewed by Lucas Forschler.
149
150         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
151         (StatusBubble): Added QUEUE_TRIGGERS.
152         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
153         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
154         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
155         its parent(builder).
156
157 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
158
159         [ews-app] Status-bubble steps are sometimes displayed in reverse order
160         https://bugs.webkit.org/show_bug.cgi?id=196625
161
162         Reviewed by Lucas Forschler.
163
164         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
165         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
166
167 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
168
169         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
170         https://bugs.webkit.org/show_bug.cgi?id=196630
171
172         Reviewed by Wenson Hsieh.
173
174         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
175
176 2019-04-04  Youenn Fablet  <youenn@apple.com>
177
178         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
179         https://bugs.webkit.org/show_bug.cgi?id=196543
180
181         Reviewed by Alex Christensen.
182
183         * WebKitTestRunner/TestController.cpp:
184         (WTR::TestController::generatePageConfiguration):
185
186 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
187
188         [ews-app] Status bubble should not display skipped buildbot steps
189         https://bugs.webkit.org/show_bug.cgi?id=196584
190
191         Reviewed by Lucas Forschler.
192
193         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
194
195 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
196
197         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
198         https://bugs.webkit.org/show_bug.cgi?id=196620
199
200         Reviewed by Lucas Forschler.
201
202         * BuildSlaveSupport/ews-app/ews/config.py:
203
204 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
205
206         [Win] DumpRenderTreeWatchDog.py is not checked into source
207         https://bugs.webkit.org/show_bug.cgi?id=196567
208         <rdar://problem/49525901>
209
210         Reviewed by Lucas Forschler.
211
212         This script is used on Win EWS bots to terminate hanging DRT processes.
213
214         * EWSTools/dumprendertreewatchdog.py: Added.
215
216 2019-04-04  Chris Dumez  <cdumez@apple.com>
217
218         Unreviewed, roll out r243858 which made tests time out.
219
220         Disable new API tests on Windows instead.
221
222         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
223         (TestWebKitAPI::TEST):
224
225 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
226
227         [ATK] Cleanup WebPageAccessibilityObjectAtk
228         https://bugs.webkit.org/show_bug.cgi?id=196537
229
230         Reviewed by Michael Catanzaro.
231
232         Also consider files under atk directories as exceptions for GObject conventions.
233
234         * Scripts/webkitpy/style/checkers/cpp.py:
235         (check_identifier_name_in_declaration):
236
237 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
238
239         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
240         https://bugs.webkit.org/show_bug.cgi?id=196588
241         <rdar://problem/49365787>
242
243         Unreviewed build fix for Windows port.
244
245         error C3861: 'kill': identifier not found
246
247         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
248         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
249
250 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
251
252         [ews-build] Cancel build and similar operations should have authentication
253         https://bugs.webkit.org/show_bug.cgi?id=196520
254
255         Reviewed by Dewei Zhu.
256
257         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
258         environment variables.
259
260 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
261
262         [ews-build] Do not trigger queues which are not in production yet
263         https://bugs.webkit.org/show_bug.cgi?id=196581
264
265         Reviewed by Dewei Zhu.
266
267         * BuildSlaveSupport/ews-build/config.json:
268
269 2019-04-03  Chris Dumez  <cdumez@apple.com>
270
271         Unreviewed, fix typo in the name of API test added in r243848.
272
273         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
274         (TestWebKitAPI::TEST):
275
276 2019-04-03  Chris Dumez  <cdumez@apple.com>
277
278         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
279         https://bugs.webkit.org/show_bug.cgi?id=196588
280         <rdar://problem/49365787>
281
282         Reviewed by Ryosuke Niwa.
283
284         Add API test coverage.
285
286         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
287         (TestWebKitAPI::nullJavaScriptCallback):
288         (TestWebKitAPI::didCrashCheckFrames):
289         (TestWebKitAPI::TEST):
290
291 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
292
293         run-webkit-tests: Upload test results (new results database)
294         https://bugs.webkit.org/show_bug.cgi?id=196577
295         <rdar://problem/34841155>
296
297         Reviewed by Lucas Forschler.
298
299         * Scripts/webkitpy/layout_tests/controllers/manager.py:
300         (Manager.run): Upload results after each device shard, since the configuration will be
301         different for each device.
302         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
303         uploaded to a results database.
304         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
305         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
306
307 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
308
309         -apple-trailing-word is needed for browser detection
310         https://bugs.webkit.org/show_bug.cgi?id=196575
311
312         Unreviewed.
313
314         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
315
316 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
317
318         [CMake][WTF] Mirror XCode header directories
319         https://bugs.webkit.org/show_bug.cgi?id=191662
320
321         Reviewed by Konstantin Tokarev.
322
323         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
324         builds.
325
326         * CMakeLists.txt:
327         * DumpRenderTree/CMakeLists.txt:
328         * DumpRenderTree/PlatformWin.cmake:
329         * MiniBrowser/win/CMakeLists.txt:
330         * TestWebKitAPI/CMakeLists.txt:
331         * TestWebKitAPI/PlatformWin.cmake:
332         * WebKitTestRunner/PlatformGTK.cmake:
333         * WebKitTestRunner/PlatformWin.cmake:
334
335 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
336
337         [ews-app] Status bubble should not display certain infrastructure status messages
338         https://bugs.webkit.org/show_bug.cgi?id=196550
339
340         Reviewed by Lucas Forschler.
341
342         Do not display the steps which are un-needed for end-user. This information is still avaiable
343         if the user click on the bubble and look at the Buildbot build.
344         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
345         (StatusBubble._steps_messages):
346         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
347
348 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
349
350         [ews-build] Use https for sending data to ews-app
351         https://bugs.webkit.org/show_bug.cgi?id=196492
352
353         Reviewed by Lucas Forschler.
354
355         * BuildSlaveSupport/ews-build/events.py:
356
357 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
358
359         Remove support for -apple-trailing-word
360         https://bugs.webkit.org/show_bug.cgi?id=196525
361
362         Reviewed by Zalan Bujtas.
363
364         This CSS property is nonstandard and not used.
365
366         * Scripts/webkitperl/FeatureList.pm:
367         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
368
369 2019-04-03  Youenn Fablet  <youenn@apple.com>
370
371         Add a test for DOMCache on multiple browsing in case of private browsing
372         https://bugs.webkit.org/show_bug.cgi?id=196524
373
374         Reviewed by Alex Christensen.
375
376         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
377         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
378
379 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
380
381         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
382         https://bugs.webkit.org/show_bug.cgi?id=196540
383
384         Reviewed by Aakash Jain.
385
386         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
387
388 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
389
390         Add plumbing for a compatibility mode preference in WebKit
391         https://bugs.webkit.org/show_bug.cgi?id=196005
392
393         Reviewed by Tim Horton.
394
395         Add new API tests.
396
397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
398         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
399
400 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
401
402         [WPE][GTK] Update libsrtp dependency package for Debian
403         https://bugs.webkit.org/show_bug.cgi?id=196528
404
405         Reviewed by Frédéric Wang.
406
407         * gtk/install-dependencies:
408         * wpe/install-dependencies:
409
410 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
411
412         [WK2] Add support for Window's beforeprint / afterprint events
413         https://bugs.webkit.org/show_bug.cgi?id=196478
414         <rdar://problem/49535124>
415
416         Unreviewed build fix for MSVC.
417
418         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
419
420         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
421
422         * WebKitTestRunner/TestController.cpp:
423         (WTR::printFrame): Use int and float literals.
424
425 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
426
427         [ews-build] Reassign bots to queues
428
429         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
430
431 2019-04-02  Chris Dumez  <cdumez@apple.com>
432
433         [WK2] Add support for Window's beforeprint / afterprint events
434         https://bugs.webkit.org/show_bug.cgi?id=196478
435
436         Reviewed by Alex Christensen.
437
438         Add minimal implementation for printFrame in WebKitTestRunner.
439
440         * WebKitTestRunner/TestController.cpp:
441         (WTR::printFrame):
442         (WTR::TestController::createOtherPage):
443         (WTR::TestController::createWebViewWithOptions):
444
445 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
446
447         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
448         https://bugs.webkit.org/show_bug.cgi?id=196491
449
450         Reviewed by Lucas Forschler.
451
452         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
453
454 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
455
456         [ews-build] Configure buildbot try credentials in environment variables
457         https://bugs.webkit.org/show_bug.cgi?id=196501
458
459         Reviewed by Lucas Forschler.
460
461         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
462         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
463         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
464
465 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
466
467         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
468         https://bugs.webkit.org/show_bug.cgi?id=196496
469         <rdar://problem/49521634>
470
471         Reviewed by Chris Dumez.
472
473         Add new API tests (see WebKit ChangeLog for more detail).
474
475         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
476         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
477         (TEST):
478
479 2019-04-02  David Kilzer  <ddkilzer@apple.com>
480
481         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
482         <https://webkit.org/b/196499>
483
484         Reviewed by Alexey Proskuryakov.
485
486         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
487         ENABLE_ADDRESS_SANITIZER.
488
489 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
490
491         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
492         https://bugs.webkit.org/show_bug.cgi?id=182757
493
494         Reviewed by Don Olmstead.
495
496         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
497         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
498
499 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
500
501         run-api-tests: Upload test results
502         https://bugs.webkit.org/show_bug.cgi?id=196323
503         <rdar://problem/49356714>
504
505         Reviewed by Lucas Forschler.
506
507         * Scripts/webkitpy/api_tests/manager.py:
508         (Manager):
509         (Manager.run): Upload results to a results database.
510         * Scripts/webkitpy/api_tests/run_api_tests.py:
511         (parse_args): Add upload arguments.
512         * Scripts/webkitpy/port/base.py:
513         (Port):
514         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
515         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
516         with commits from any other associated repositories.
517         * Scripts/webkitpy/port/device.py:
518         (Device):
519         (Device.build_version): Access build_versoin of underlying platform device.
520         * Scripts/webkitpy/port/ios_simulator_unittest.py:
521         (IOSSimulatorTest):
522         (IOSSimulatorTest.test_configuration_for_upload):
523         * Scripts/webkitpy/port/device_port.py:
524         (DevicePort):
525         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
526         the same as the machine uploading results.
527         * Scripts/webkitpy/port/mac.py:
528         (MacPort):
529         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
530         * Scripts/webkitpy/port/mac_unittest.py:
531         (MacTest):
532         (MacTest.test_configuration_for_upload):
533         * Scripts/webkitpy/xcode/simulated_device.py:
534         (SimulatedDeviceManager._create_device_with_runtime):
535         (SimulatedDevice.__init__): Create simulated device with a build_version.
536         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
537         (test_existing_simulator):
538
539 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
540
541         Remove extra newline characters (Follow-up fix to r243707)
542
543         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
544
545 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
546
547         [ews-app] Use API_KEY to accept results data
548         https://bugs.webkit.org/show_bug.cgi?id=196461
549
550         Reviewed by Dewei Zhu.
551
552         * BuildSlaveSupport/ews-app/ews/views/results.py:
553         (Results.post): Validate EWS_API_KEY before accepting any data.
554         * BuildSlaveSupport/ews-build/events.py:
555         (Events.sendData): Send EWS_API_KEY if available along with event data.
556
557 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
558
559         Unable to copy and paste a PDF from Notes into Mail compose body
560         https://bugs.webkit.org/show_bug.cgi?id=196442
561         <rdar://problem/48573098>
562
563         Reviewed by Tim Horton.
564
565         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
566         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
567         to be specified on the item providers.
568
569         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
570         (TestWebKitAPI::mapItemForTesting):
571         (TestWebKitAPI::contactItemForTesting):
572
573 2019-04-01  Tim Horton  <timothy_horton@apple.com>
574
575         Make UIWKDocumentContext rects per-character instead of per-word
576         https://bugs.webkit.org/show_bug.cgi?id=196459
577
578         Reviewed by Wenson Hsieh.
579
580         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
581         (TEST):
582         Adjust test results due to switching to per-character rects.
583
584 2019-04-01  Chris Dumez  <cdumez@apple.com>
585
586         UIProcess crash when a prewarmed process is terminated
587         https://bugs.webkit.org/show_bug.cgi?id=196451
588         <rdar://problem/49245471>
589
590         Reviewed by Geoffrey Garen.
591
592         Add API test coverage.
593
594         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
595         (TEST):
596
597 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
598
599         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
600         https://bugs.webkit.org/show_bug.cgi?id=196449
601
602         Reviewed by Lucas Forschler.
603
604         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
605         (StatusBubble.get_os_details): Method to get OS and Xcode details.
606         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
607         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
608
609 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
610
611         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
612         https://bugs.webkit.org/show_bug.cgi?id=196444
613
614         Reviewed by Lucas Forschler.
615
616         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
617
618 2019-04-01  Alex Christensen  <achristensen@webkit.org>
619
620         Add SPI to canonicalize NSURLs with WTF::URL
621         https://bugs.webkit.org/show_bug.cgi?id=196415
622         <rdar://problem/44980271>
623
624         Reviewed by Darin Adler.
625
626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
627         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
628         (TestWebKitAPI::TEST):
629
630 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
631
632         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
633         https://bugs.webkit.org/show_bug.cgi?id=196441
634
635         Reviewed by Carlos Garcia Campos.
636
637         Don't cache the wpe_view_backend object that might not exist yet at the
638         time of EventSenderProxy constructor invocation, but instead retrieve
639         that object whenever it's required for event dispatching. This should
640         avoid crashes in this constructor now that it's invoked before any
641         PlatformWindow has been set up (as changed in r243496).
642
643         * WebKitTestRunner/EventSenderProxy.h:
644         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
645         (WTR::viewBackend):
646         (WTR::EventSenderProxy::EventSenderProxy):
647         (WTR::EventSenderProxy::mouseDown):
648         (WTR::EventSenderProxy::mouseUp):
649         (WTR::EventSenderProxy::mouseMoveTo):
650         (WTR::EventSenderProxy::mouseScrollBy):
651         (WTR::EventSenderProxy::keyDown):
652         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
653
654 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
655
656         [Win][WebKit] MiniBrowser should support high DPI display
657         https://bugs.webkit.org/show_bug.cgi?id=196391
658
659         Reviewed by Alex Christensen.
660
661         * MiniBrowser/win/WebKitBrowserWindow.cpp:
662         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
663         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
664         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
665
666 2019-03-31  Sam Weinig  <weinig@apple.com>
667
668         Remove more i386 specific configurations
669         https://bugs.webkit.org/show_bug.cgi?id=196430
670
671         Reviewed by Alexey Proskuryakov.
672
673         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
674         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
675
676 2019-03-31  Andy Estes  <aestes@apple.com>
677
678         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
679         https://bugs.webkit.org/show_bug.cgi?id=196433
680         <rdar://problem/49293305>
681
682         Reviewed by Tim Horton.
683
684         Enhanced API test coverage to include all navigation response policy decisions in both
685         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
686
687         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
688         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
689         (TestWebKitAPI::TEST):
690         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
691         (readFile):
692         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
693         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
694         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
695         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
696         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
697         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
698         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
699         (-[QuickLookDelegate _downloadDidStart:]):
700         (-[QuickLookDelegate _download:didReceiveResponse:]):
701         (-[QuickLookDelegate _download:didReceiveData:]):
702         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
703         (-[QuickLookDelegate _downloadDidFinish:]):
704         (-[QuickLookDelegate _download:didFailWithError:]):
705         (-[QuickLookDelegate _downloadDidCancel:]):
706         (-[QuickLookDelegate verifyDownload]):
707         (runTest):
708         (runTestDecideBeforeLoading):
709         (runTestDecideAfterLoading):
710         (TEST):
711         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
712         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
713         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
714         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
715         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
716         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
717         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
718         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
719         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
720         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
721         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
722         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
723         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
724         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
725
726 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
727
728         [CMake] add testdfg as target with build-jsc
729         https://bugs.webkit.org/show_bug.cgi?id=196393
730
731         Reviewed by Saam Barati.
732
733         Added testdfg as one of the targets to build when
734         using CMake.
735
736         * Scripts/build-jsc:
737
738 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
739
740         Delete WebMetal implementation in favor of WebGPU
741         https://bugs.webkit.org/show_bug.cgi?id=195418
742
743         Reviewed by Dean Jackson.
744
745         * DumpRenderTree/mac/DumpRenderTree.mm:
746         (enableExperimentalFeatures):
747         (resetWebPreferencesToConsistentValues):
748         * Scripts/webkitperl/FeatureList.pm:
749         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
751         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
752         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
753         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
754         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
755         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
756         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
757         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
758         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
759         (WTR::InjectedBundle::beginTesting):
760         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
761         (WTR::TestRunner::setWebMetalEnabled): Deleted.
762         * WebKitTestRunner/InjectedBundle/TestRunner.h:
763
764 2019-03-29  Chris Dumez  <cdumez@apple.com>
765
766         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
767         https://bugs.webkit.org/show_bug.cgi?id=196405
768         <rdar://problem/49428130>
769
770         Reviewed by Wenson Hsieh.
771
772         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
773         the popover presentation methods to be no-ops. Use this in the new test added in
774         r243523 so that we do not swizzle those methods for all tests. This is needed because
775         those WatchOS tests rely on the popover getting presented and interactive.
776
777         * WebKitTestRunner/TestController.cpp:
778         (WTR::updateTestOptionsFromTestHeader):
779         * WebKitTestRunner/TestController.h:
780         * WebKitTestRunner/TestOptions.h:
781         (WTR::TestOptions::hasSameInitializationOptions const):
782         * WebKitTestRunner/ios/TestControllerIOS.mm:
783         (WTR::TestController::platformInitialize):
784         (WTR::TestController::platformResetStateToConsistentValues):
785
786 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
787
788         [Curl] Add Server Trust Evaluation Support.
789         https://bugs.webkit.org/show_bug.cgi?id=191646
790
791         Reviewed by Fujii Hironori.
792
793         Implemented MiniBrowser UI for asking if user trusts the server.
794
795         * MiniBrowser/win/Common.cpp:
796         (askServerTrustEvaluation):
797         (replaceString):
798         * MiniBrowser/win/Common.h:
799         * MiniBrowser/win/MiniBrowserLib.rc:
800         * MiniBrowser/win/MiniBrowserLibResource.h:
801         * MiniBrowser/win/WebKitBrowserWindow.cpp:
802         (createPEMString):
803         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
804         (WebKitBrowserWindow::canTrustServerCertificate):
805         * MiniBrowser/win/WebKitBrowserWindow.h:
806
807 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
808
809         Implement ResizeObserver.
810         https://bugs.webkit.org/show_bug.cgi?id=157743
811
812         Reviewed by Simon Fraser.
813
814         Support resizeObserverEnabled webPreferences.
815
816         * DumpRenderTree/TestOptions.cpp:
817         (TestOptions::TestOptions):
818         * DumpRenderTree/TestOptions.h:
819         * DumpRenderTree/mac/DumpRenderTree.mm:
820         (setWebPreferencesForTestOptions):
821         * DumpRenderTree/win/DumpRenderTree.cpp:
822         (enableExperimentalFeatures):
823         * Scripts/webkitperl/FeatureList.pm:
824         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
825
826 2019-03-28  John Wilander  <wilander@apple.com>
827
828         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
829         https://bugs.webkit.org/show_bug.cgi?id=196281
830         <rdar://problem/48938748>
831
832         Reviewed by Alex Christensen.
833
834         This patch adds the function isStatisticsHasLocalStorage() to the
835         TestRunner. With it, the page can query the WebsiteDataStore in the
836         UI process to make sure that it sees LocalStorage.
837
838         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
839         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
840         (WTR::TestRunner::isStatisticsHasLocalStorage):
841         * WebKitTestRunner/InjectedBundle/TestRunner.h:
842         * WebKitTestRunner/TestController.cpp:
843         (WTR::TestController::isStatisticsHasLocalStorage):
844         * WebKitTestRunner/TestController.h:
845         * WebKitTestRunner/TestInvocation.cpp:
846         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
847
848 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
849
850         API::Data::createWithoutCopying should do a null check before calling CFRelease
851         https://bugs.webkit.org/show_bug.cgi?id=196276
852         <rdar://problem/48059859>
853
854         Reviewed by Alex Christensen.
855
856         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
857
858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
859         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
860         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
861         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
862         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
863         (TestWebKitAPI::TEST):
864
865 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
866
867         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
868         https://bugs.webkit.org/show_bug.cgi?id=186276
869
870         Reviewed by Carlos Garcia Campos.
871
872         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
873         (webViewLoadChanged):
874         (testWebResourceGetDataError):
875         (testWebResourceGetDataEmpty):
876         (beforeAll):
877         (webViewloadChanged): Deleted.
878
879 2019-03-27  Andy Estes  <aestes@apple.com>
880
881         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
882         https://bugs.webkit.org/show_bug.cgi?id=196317
883
884         Reviewed by Dan Bernstein.
885
886         package-root copies built products into a staging directory using ditto(1), which does not
887         follow symbolic links as it traverses a directory. Now that the files in
888         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
889         itself, these become broken links when ditto'd into the staging directory.
890
891         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
892
893         * Scripts/package-root:
894
895 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
896
897         [ews-app] Update display text of Submit for ews analysis
898         https://bugs.webkit.org/show_bug.cgi?id=196309
899
900         Reviewed by Dewei Zhu.
901
902         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
903
904 2019-03-27  David Kilzer  <ddkilzer@apple.com>
905
906         run-webkit-tests should check for leaks in WebKit processes
907         <https://webkit.org/b/193772>
908         <rdar://problem/46526680>
909
910         Reviewed by Ryosuke Niwa.
911
912         This works by doing the following:
913         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
914           The list of child processes are returned one per line:
915           process.name: pid
916         - Run the "#LIST CHILD PROCESSES" command just before the
917           "#CHECK FOR WORLD LEAKS" command, and store the list of child
918           processes on the ServerProcess object.
919         - When the `--leaks` switch is handled, run check_for_leaks() on
920           each child process after the main test harness.
921
922         * DumpRenderTree/mac/DumpRenderTree.mm:
923         (handleControlCommand):
924         - Use strncmp() instead of strcmp().
925         - Add support for handling "#LIST CHILD PROCESSES" command.
926
927         * Scripts/webkitpy/port/base.py:
928         (Port.check_for_leaks):
929         * Scripts/webkitpy/port/darwin.py:
930         (DarwinPort.check_for_leaks):
931         - Rename redundant 'process_pid' argument to 'process_id'.
932
933         * Scripts/webkitpy/port/driver.py:
934         (Driver.do_post_tests_work):
935         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
936           longer the only command this sends to WebKitTestRunner.
937         - If the `--leaks` switch is present, send the
938           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
939           result using Port.set_webkit_processes().
940         (Driver._parse_child_processes_output):
941         - Add helper method to parse list of child process names and
942           process IDs returned from WebKitTestRunner.
943
944         * Scripts/webkitpy/port/ios_device.py:
945         (IOSDevicePort.check_for_leaks):
946         - Rename redundant 'process_pid' argument to 'process_id'.
947
948         * Scripts/webkitpy/port/leakdetector.py:
949         (LeakDetector._parse_leaks_output):
950         - Return early if there is no leaks_output.
951         (LeakDetector.check_for_leaks):
952         - Rename redundant 'process_pid' argument to 'process_id'.
953
954         * Scripts/webkitpy/port/server_process.py:
955         (ServerProcess.__init__):
956         (ServerProcess.child_processes):
957         (ServerProcess.set_child_processes):
958         - Add instance variable to Port to store list of child process
959           names and process IDs returned from WebKitTestRunner.
960         (ServerProcess._start):
961         - Clear self._child_processes.
962         (ServerProcess.stop):
963         - If self._child_processes is set, call
964           self._port.check_for_leaks() for each child process.
965
966         * Scripts/webkitpy/port/server_process_unittest.py:
967         (TrivialMockPort.check_for_leaks):
968         - Rename redundant 'process_pid' argument to 'process_id'.
969
970         * Scripts/webkitpy/port/simulator_process.py:
971         (SimulatorProcess.stop):
972         - If self._child_processes is set, call
973           self._port.check_for_leaks() for each child process.
974
975         * Scripts/webkitpy/port/watch_device.py:
976         (WatchDevicePort.check_for_leaks):
977         - Rename redundant 'process_pid' argument to 'process_id'.
978
979         * WebKitTestRunner/TestController.cpp:
980         (WTR::TestController::dumpResponse):
981         - Extract method from findAndDumpWorldLeaks() so that it may be
982           reused by findAndDumpWebKitProcessIdentifiers().
983         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
984         - Add method to output process name and process ID of both the
985           WebContent and Networking processes.
986         (WTR::TestController::findAndDumpWorldLeaks):
987         - Fix missing newline in output when there were no abandoned
988           documents.
989         - Call dumpResponse() for extracted code.
990         (WTR::TestController::handleControlCommand):
991         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
992         - Use strncmp() instead of strcmp().
993         - Call findAndDumpWebKitProcessIdentifiers() when
994           "#LIST CHILD PROCESSES" command is sent.
995         * WebKitTestRunner/TestController.h:
996         (WTR::TestController::dumpResponse):
997         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
998         - Declare methods.
999
1000 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1001
1002         Unreviewed. Add GLib API test cases after r243434.
1003
1004         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1005         (testWebViewActiveURI):
1006         (serverCallback):
1007         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1008         (sendRequestCallback):
1009
1010 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1011
1012         Geolocation request not complete when watch request was started in a different web process
1013         https://bugs.webkit.org/show_bug.cgi?id=195996
1014
1015         Reviewed by Alex Christensen.
1016
1017         Add a test case.
1018
1019         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1020         (TestWebKitAPI::runJavaScriptAlert):
1021         (TestWebKitAPI::TEST):
1022
1023 2019-03-26  Keith Rollin  <krollin@apple.com>
1024
1025         Update the way generate-xcfilelists returns strings from functions
1026         https://bugs.webkit.org/show_bug.cgi?id=195975
1027         <rdar://problem/49040807>
1028
1029         Reviewed by Dean Jackson.
1030
1031         There are places where generate-xcfilelists executes assignments with
1032         statements like:
1033
1034             FOO=$(some_function)
1035
1036         where "some_function" return a string by echoing it. E.g.
1037
1038             some_function()
1039             {
1040                 echo "Hello, World"
1041             }
1042
1043         This is a common idiom, but it has a problem if "some_function" needs
1044         to call "exit" in an attempt to halt the entire script right then and
1045         there. Since "some_function" is called inside of $(), it's being
1046         executed in a sub-shell. Calling exit in that sub-shell simply exits
1047         that shell; it doesn't not exit the outer shell in which the main part
1048         of the script is still running. As such, the main script keeps
1049         executing when the intent was for the script to halt.
1050
1051         The solution to this is to use a different idiom for returning
1052         strings. The one we now is to pass in the name of the variable to
1053         receive the string result:
1054
1055             some_function()
1056             {
1057                 variable_name=$1
1058                 eval $variable_name ="Hello, World"
1059             }
1060
1061         The call site now looks like
1062
1063             some_function FOO
1064
1065         Because there's no invocation of a sub-shell, some_function can now
1066         call "exit" if it wants to, and the entire script will exit at that
1067         point.
1068
1069         * Scripts/generate-xcfilelists:
1070
1071 2019-03-26  Chris Dumez  <cdumez@apple.com>
1072
1073         Add basic layout test coverage for File Picker on iOS
1074         https://bugs.webkit.org/show_bug.cgi?id=196265
1075
1076         Reviewed by Wenson Hsieh.
1077
1078         Add layout test infrastructure to test the file picker on iOS.
1079
1080         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1081         (WTR::UIScriptController::dismissFilePicker):
1082         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1083         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1084         (WTR::UIScriptController::dismissFilePicker):
1085         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1086         * WebKitTestRunner/TestController.cpp:
1087         (WTR::TestController::createWebViewWithOptions):
1088         (WTR::updateTestOptionsFromTestHeader):
1089         * WebKitTestRunner/TestOptions.h:
1090         (WTR::TestOptions::hasSameInitializationOptions const):
1091         * WebKitTestRunner/ios/TestControllerIOS.mm:
1092         (overridePresentViewController):
1093         (WTR::TestController::platformInitialize):
1094         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1095         (WTR::UIScriptController::dismissFilePicker):
1096
1097 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1098
1099         Implement async paste method on UIWKInteractionViewProtocol
1100         https://bugs.webkit.org/show_bug.cgi?id=196267
1101         <rdar://problem/49236346>
1102
1103         Reviewed by Tim Horton.
1104
1105         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1106         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1107         are now a part of all iOS 12 internal SDKs.
1108
1109         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1110
1111         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1112         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1113
1114         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1115         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1116         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1117         * TestWebKitAPI/ios/UIKitSPI.h:
1118
1119 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1120
1121         [ews-build] Use PostgreSQL for ews.webkit.org database
1122         https://bugs.webkit.org/show_bug.cgi?id=196270
1123
1124         Reviewed by Lucas Forschler.
1125
1126         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1127
1128 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1129
1130         [ews] Reset simctl states on reboot
1131         https://bugs.webkit.org/show_bug.cgi?id=196260
1132
1133         Rubber-stamped by Aakash Jain.
1134
1135         * EWSTools/start-queue-mac.sh:
1136
1137 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1138
1139         [ews-build] Use PostgreSQL for ews-build database
1140         https://bugs.webkit.org/show_bug.cgi?id=196229
1141
1142         Reviewed by Lucas Forschler.
1143
1144         * BuildSlaveSupport/ews-build/master.cfg:
1145
1146 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1147
1148         [ews-build] Get master_hostname dynamically in master.cfg
1149         https://bugs.webkit.org/show_bug.cgi?id=196255
1150
1151         Reviewed by Lucas Forschler.
1152
1153         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1154         send events data in test mode.
1155
1156 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1157
1158         [ews-app] Set db_constraint to False for Foreign Keys
1159         https://bugs.webkit.org/show_bug.cgi?id=196252
1160
1161         Reviewed by Lucas Forschler.
1162
1163         * BuildSlaveSupport/ews-app/ews/models/build.py:
1164         * BuildSlaveSupport/ews-app/ews/models/step.py:
1165
1166 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1167
1168         [ews-build] is_test_mode_enabled should default to True
1169         https://bugs.webkit.org/show_bug.cgi?id=196248
1170
1171         Reviewed by Lucas Forschler.
1172
1173         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1174
1175 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1176
1177         [ews-app] Add webkitperl to ENABLED_QUEUES
1178         https://bugs.webkit.org/show_bug.cgi?id=196253
1179
1180         Reviewed by Lucas Forschler.
1181
1182         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1183
1184 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1185
1186         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1187         https://bugs.webkit.org/show_bug.cgi?id=196211
1188         rdar://problem/49110552
1189
1190         Reviewed by Tim Horton.
1191
1192         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1193         Make sure that EventSenderProxy always exists when running tests. We used to create
1194         it when resetting before the first test, which is a bit too late.
1195
1196         * WebKitTestRunner/TestController.h:
1197         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1198         (WTR::TestController::platformCreateWebView):
1199         (WTR::TestController::platformCreateOtherPage):
1200         (WTR::TestController::finishCreatingPlatformWebView):
1201         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1202         (WTR::PlatformWebView::PlatformWebView):
1203         Moved some code that made NSWindow use NSEvent during web view creation. We may
1204         need to move more if some other case us found, but this is enough for now.
1205
1206 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1207
1208         Unreviewed. Fix typo in GLib geolocation API after r243285.
1209
1210         gelocation -> geolocation.
1211
1212         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1213         (testGeolocationManagerWatchPosition):
1214
1215 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1216
1217         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1218         https://bugs.webkit.org/show_bug.cgi?id=196213
1219
1220         Reviewed by Geoff Garen.
1221
1222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1223         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1224         (credentialWithIdentityAndKeychainPath):
1225         (-[ChallengeDelegate webView:didFinishNavigation:]):
1226         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1227         (TestWebKitAPI::TEST):
1228
1229 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1230
1231         Expected shouldn't assume its contained types are copyable
1232         https://bugs.webkit.org/show_bug.cgi?id=195986
1233
1234         Reviewed by JF Bastien.
1235
1236         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1237         (TestWebKitAPI::NonCopyable::operator== const):
1238         (TestWebKitAPI::NonCopyable::operator!= const):
1239         (TestWebKitAPI::TEST):
1240
1241 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1242
1243         Remove some now-unnecessary dynamic class lookup
1244         https://bugs.webkit.org/show_bug.cgi?id=196237
1245
1246         Reviewed by Simon Fraser.
1247
1248         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1249         (makeRequest):
1250         (TEST):
1251
1252 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1253
1254         Unreviewed, rolling out r243450.
1255
1256         AppleWin and WinCairo port builds get broken.
1257
1258         Reverted changeset:
1259
1260         "Add test for fix of #196095"
1261         https://bugs.webkit.org/show_bug.cgi?id=196097
1262         https://trac.webkit.org/changeset/243450
1263
1264 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1265
1266         Unreviewed, rolling out r243465.
1267         https://bugs.webkit.org/show_bug.cgi?id=196226
1268
1269         the test doesn't build (Requested by thorton on #webkit).
1270
1271         Reverted changeset:
1272
1273         "Do not terminate the NetworkProcess if a third party
1274         application sends a NSCredential with a SecIdentityRef"
1275         https://bugs.webkit.org/show_bug.cgi?id=196213
1276         https://trac.webkit.org/changeset/243465
1277
1278 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1279
1280         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1281         https://bugs.webkit.org/show_bug.cgi?id=196213
1282
1283         Reviewed by Geoff Garen.
1284
1285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1286         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1287         (credentialWithIdentityAndKeychainPath):
1288         (-[ChallengeDelegate webView:didFinishNavigation:]):
1289         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1290         (TestWebKitAPI::TEST):
1291
1292 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1293
1294         [ews-build] Gracefully handle missing patch_id in events
1295         https://bugs.webkit.org/show_bug.cgi?id=196216
1296
1297         Reviewed by Lucas Forschler.
1298
1299         * BuildSlaveSupport/ews-build/events.py:
1300
1301 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1302
1303         [ews-build] use lz4 compression for improving buildbot performance
1304         https://bugs.webkit.org/show_bug.cgi?id=196155
1305
1306         Reviewed by Lucas Forschler.
1307
1308         * BuildSlaveSupport/ews-build/master.cfg:
1309
1310 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1311
1312         Pull some API testing helper methods out of TestWKWebView
1313         https://bugs.webkit.org/show_bug.cgi?id=196212
1314
1315         Reviewed by Tim Horton.
1316
1317         Refactor some more API testing utility methods, so that they can be used in
1318         tests that do not use TestWKWebView.
1319
1320         * TestWebKitAPI/cocoa/TestWKWebView.h:
1321         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1322         (-[WKWebView loadTestPageNamed:]):
1323         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1324         (-[WKWebView synchronouslyLoadHTMLString:]):
1325         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1326         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1327         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1328         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1329         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1330
1331 2019-03-25  Jer Noble  <jer.noble@apple.com>
1332
1333         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1334         https://bugs.webkit.org/show_bug.cgi?id=196097
1335
1336         Reviewed by Eric Carlson.
1337
1338         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1339
1340         * DumpRenderTree/mac/DumpRenderTree.mm:
1341         (resetWebPreferencesToConsistentValues):
1342         * WebKitTestRunner/TestController.cpp:
1343         (WTR::TestController::resetPreferencesToConsistentValues):
1344
1345 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1346
1347         Pull IPadUserInterfaceSwizzler out into a separate header file
1348         https://bugs.webkit.org/show_bug.cgi?id=196193
1349
1350         Reviewed by Anders Carlsson.
1351
1352         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1353         be used in other API tests.
1354
1355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1356         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1357         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1358         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1359         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1360         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1361         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1362
1363 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1364
1365         Remove NavigatorContentUtils in WebCore/Modules
1366         https://bugs.webkit.org/show_bug.cgi?id=196070
1367
1368         Reviewed by Alex Christensen.
1369
1370         NavigatorContentUtils was to support the custom scheme spec [1].
1371         However, in WebKit side, no port has supported the feature in
1372         WebKit layer after EFL port was removed. So there has been the
1373         only IDL implementation of the NavigatorContentUtils in WebCore.
1374         So we don't need to keep the implementation in WebCore anymore.
1375
1376         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1377
1378         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1379
1380 2019-03-24  Andy Estes  <aestes@apple.com>
1381
1382         [watchOS] Remove unused Proximity Networking code
1383         https://bugs.webkit.org/show_bug.cgi?id=196188
1384
1385         Reviewed by Tim Horton.
1386
1387         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1388         (TEST):
1389
1390 2019-03-23  Keith Miller  <keith_miller@apple.com>
1391
1392         Refactor clz/ctz and fix getLSBSet.
1393         https://bugs.webkit.org/show_bug.cgi?id=196162
1394
1395         Reviewed by Saam Barati.
1396
1397         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1398
1399         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1400         (TestWebKitAPI::TEST):
1401
1402 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1403
1404         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1405         https://bugs.webkit.org/show_bug.cgi?id=196143
1406
1407         Reviewed by Michael Catanzaro.
1408
1409         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1410         directories.
1411
1412         * Scripts/webkitpy/style/checkers/cpp.py:
1413         (check_identifier_name_in_declaration):
1414         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1415         (WebKitStyleTest.test_names):
1416
1417 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1418
1419         [Flatpak] Manifest expanding fails for qt WPE extension
1420         https://bugs.webkit.org/show_bug.cgi?id=196148
1421
1422         Reviewed by Alex Christensen.
1423
1424         * flatpak/flatpakutils.py:
1425         (expand_submodules_recurse): The last recurse manifest expand
1426         iteration might lead to a single module so take it into account
1427         and don't try to recurse further.
1428
1429 2019-03-22  Chris Dumez  <cdumez@apple.com>
1430
1431         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1432         https://bugs.webkit.org/show_bug.cgi?id=195348
1433         <rdar://problem/48622090>
1434
1435         Reviewed by Alex Christensen.
1436
1437         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1438         to NO when test.options().shouldIgnoreMetaViewport is false.
1439
1440         * WebKitTestRunner/ios/TestControllerIOS.mm:
1441         (WTR::TestController::platformConfigureViewForTest):
1442
1443 2019-03-22  Chris Dumez  <cdumez@apple.com>
1444
1445         Prewarmed processes should be usable with any website data store
1446         https://bugs.webkit.org/show_bug.cgi?id=196104
1447
1448         Reviewed by Alex Christensen.
1449
1450         Add API test coverage.
1451
1452         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1453         (runInitialWarmedProcessUsedTest):
1454         (TEST):
1455
1456 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1457
1458         Back out local changes to Alex's Subversion working directory
1459
1460         They were accidentally committed.
1461
1462         * Scripts/webkitpy/common/system/abstractexecutive.py:
1463         (AbstractExecutive.wait_newest):
1464         * Scripts/webkitpy/common/system/executive.py:
1465         (Executive.running_pids):
1466         * Scripts/webkitpy/common/system/executive_mock.py:
1467         (MockExecutive.running_pids):
1468         * Scripts/webkitpy/common/system/executive_unittest.py:
1469         (ExecutiveTest.serial_test_running_pids):
1470         * Scripts/webkitpy/port/darwin.py:
1471         (DarwinPort.check_for_leaks):
1472         * Scripts/webkitpy/port/leakdetector.py:
1473         (LeakDetector.check_for_leaks):
1474         - This was the hack attached to Bug 193772.
1475
1476         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1477         (+[WebKitTestRunnerEvent mouseLocation]):
1478         - This works around a crash on an internal build.
1479
1480 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1481
1482         Fix the build after r243354
1483         https://bugs.webkit.org/show_bug.cgi?id=196138
1484         <rdar://problem/49145951>
1485
1486         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1487         (TEST):
1488         * TestWebKitAPI/ios/UIKitSPI.h:
1489
1490 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1491
1492         Adopt UIWKDocumentContext
1493         https://bugs.webkit.org/show_bug.cgi?id=196040
1494         <rdar://problem/48642440>
1495
1496         Reviewed by Ryosuke Niwa.
1497
1498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1499         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1500         (makeRequest):
1501         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1502         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1503         (applyStyle):
1504         (TEST):
1505         Add tests for UIWKDocumentContext.
1506
1507         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1508         (TEST):
1509         (recursiveFindWKContentView): Deleted.
1510         * TestWebKitAPI/cocoa/TestWKWebView.h:
1511         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1512         (recursiveFindWKContentView):
1513         (-[TestWKWebView wkContentView]):
1514         * TestWebKitAPI/ios/UIKitSPI.h:
1515         Share the WKContentView finding code between tests.
1516
1517 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1518
1519         [iOS WK2] Turn on async overflow scrolling by default
1520         https://bugs.webkit.org/show_bug.cgi?id=196011
1521         rdar://problem/48453859
1522
1523         Reviewed by Antti Koivisto.
1524         
1525         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1526         since so many basic layout tests have different results when compositing is triggered for
1527         overflow.
1528         
1529         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1530
1531         * WebKitTestRunner/TestController.cpp:
1532         (WTR::TestController::resetPreferencesToConsistentValues):
1533
1534 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1535
1536         [ews-build] Retry API test in case of failures
1537         https://bugs.webkit.org/show_bug.cgi?id=196004
1538
1539         Reviewed by Lucas Forschler.
1540
1541         * BuildSlaveSupport/ews-build/steps.py:
1542         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1543         (CompileWebKitToT.doStepIf): Ditto.
1544         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1545         (ReRunAPITests): Re-run API tests.
1546         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1547         (RunAPITestsWithoutPatch): Run API tests without patch.
1548         (RunAPITestsWithoutPatch.doStepIf):
1549         (RunAPITestsWithoutPatch.hideStepIf):
1550         (RunAPITestsWithoutPatch.evaluateCommand):
1551         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1552         (AnalyzeAPITestsResults.start):
1553         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1554         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1555         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1556         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1557
1558 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1559
1560         [ews-build] Update queues configurations
1561         https://bugs.webkit.org/show_bug.cgi?id=196074
1562
1563         Reviewed by Dewei Zhu.
1564
1565         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1566         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1567
1568 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1569
1570         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1571         https://bugs.webkit.org/show_bug.cgi?id=195680
1572         <rdar://problem/48903534>
1573
1574         Unreviewed infrastructure fix.
1575
1576         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1577         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1578
1579 2019-03-21  Andy Estes  <aestes@apple.com>
1580
1581         [iOS] Apple Pay should be available in documents with no user agent scripts
1582         https://bugs.webkit.org/show_bug.cgi?id=196061
1583         <rdar://problem/48649391>
1584
1585         Reviewed by Brady Eidson.
1586
1587         Added API tests and related infrastructure.
1588
1589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1590         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1591         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1592         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1593         (TestWebKitAPI::TEST):
1594         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1595         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1596         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1597         * TestWebKitAPI/cocoa/TestProtocol.mm:
1598         (-[TestProtocol startLoading]):
1599         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1600         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1601         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1602         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1603
1604 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1605
1606         REGRESSSION (r243297): webkitpy tests broken
1607         https://bugs.webkit.org/show_bug.cgi?id=196108
1608
1609         Reviewed by Aakash Jain.
1610
1611         r243297 updated contributors.json, which broke a few unit tests.
1612
1613         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1614         (IRCCommandTest.test_whois):
1615         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1616
1617 2019-03-21  Chris Dumez  <cdumez@apple.com>
1618
1619         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1620         https://bugs.webkit.org/show_bug.cgi?id=196041
1621         <rdar://problem/49083230>
1622
1623         Reviewed by Alex Christensen.
1624
1625         Add API test coverage.
1626
1627         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1628         (TEST):
1629
1630 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1631
1632         Add SPI to inform applications of WKContentRuleList actions
1633         https://bugs.webkit.org/show_bug.cgi?id=195965
1634         <rdar://problem/42664365>
1635
1636         Reviewed by Geoff Garen.
1637
1638         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1639         (TestWebKitAPI::allActionsForResourceLoad):
1640         (TestWebKitAPI::testRequest):
1641         (TestWebKitAPI::TEST_F):
1642         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1643         (Notification::description):
1644         (Notification::operator== const):
1645         (toVector):
1646         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1647         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1648         (makeContentRuleList):
1649         (TEST):
1650         (makeWarnContentRuleList): Deleted.
1651
1652 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1653
1654         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1655         https://bugs.webkit.org/show_bug.cgi?id=196088
1656
1657         Reviewed by Brian Burg.
1658
1659         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1660         Support checks when only one platform is specified. Also deprecate macosx() and
1661         force the use of macos() instead.
1662
1663         * Scripts/webkitpy/style/checkers/cpp.py:
1664         (check_min_versions_of_wk_api_available):
1665         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1666         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1667
1668 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1669
1670         Update status inactive committers' status to 'contributor'.
1671
1672         * Scripts/webkitpy/common/config/contributors.json:
1673
1674 2019-03-21  Xan Lopez  <xan@igalia.com>
1675
1676         [JSC][x86] Drop support for x87 floating point
1677         https://bugs.webkit.org/show_bug.cgi?id=194853
1678
1679         Reviewed by Don Olmstead.
1680
1681         Force SSE2 on x86/32bit builds.
1682
1683         * Scripts/webkitdirs.pm:
1684         (generateBuildSystemFromCMakeProject):
1685
1686 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1687
1688         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1689         https://bugs.webkit.org/show_bug.cgi?id=196073
1690
1691         Reviewed by Michael Catanzaro.
1692
1693         Add test cases to check functions and constructors with no arguments but receiving user data.
1694
1695         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1696         (checkUserData):
1697         (testJSCFunction):
1698         (fooCreateWithUserData):
1699         (testJSCClass):
1700
1701 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1702
1703         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1704
1705         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1706
1707         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1708
1709 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1710
1711         [GTK][WPE] Add API to provide geolocation information
1712         https://bugs.webkit.org/show_bug.cgi?id=195940
1713
1714         Reviewed by Michael Catanzaro.
1715
1716         Add a new test to check the new API.
1717
1718         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1719         (testGeolocationManagerCurrentPosition):
1720         (testGeolocationManagerWatchPosition):
1721         (beforeAll):
1722         (afterAll):
1723         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1724         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1725         (beforeAll): Ditto.
1726         * TestWebKitAPI/glib/CMakeLists.txt:
1727
1728 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1729
1730         [GLib] Returning G_TYPE_OBJECT from a method does not work
1731         https://bugs.webkit.org/show_bug.cgi?id=195574
1732
1733         Reviewed by Michael Catanzaro.
1734
1735         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1736
1737         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1738         (getGFile):
1739         (getParent):
1740         (createGString):
1741         (getGString):
1742         (getGStringCopyWillRaise):
1743         (getGStringCopy):
1744         (getGStringStr):
1745         (getGStringLen):
1746         (freeGString):
1747         (testJSCClass):
1748
1749 2019-03-20  Saam Barati  <sbarati@apple.com>
1750
1751         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1752         https://bugs.webkit.org/show_bug.cgi?id=195721
1753
1754         Reviewed by Filip Pizlo.
1755
1756         * Scripts/run-javascriptcore-tests:
1757
1758 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1759
1760         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1761         https://bugs.webkit.org/show_bug.cgi?id=196049
1762
1763         Reviewed by Tim Horton.
1764
1765         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1766         overflow scrolling in general, so rename it.
1767
1768         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1769
1770 2019-03-20  Daniel Bates  <dabates@apple.com>
1771
1772         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1773         https://bugs.webkit.org/show_bug.cgi?id=196031
1774         <rdar://problem/49078172>
1775
1776         Reviewed by Tim Horton.
1777
1778         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1779         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1780         same code path used when the Done button is pressed to dismiss the <select> picker.
1781
1782         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1783         (TestWebKitAPI::TEST):
1784
1785 2019-03-20  Chris Dumez  <cdumez@apple.com>
1786
1787         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1788         https://bugs.webkit.org/show_bug.cgi?id=196029
1789         <rdar://problem/48954651>
1790
1791         Reviewed by Tim Horton.
1792
1793         Add API test coverage.
1794
1795         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1796
1797 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1798
1799         [ews-build] Improve failure summary string for ApplyPatch step
1800         https://bugs.webkit.org/show_bug.cgi?id=195995
1801
1802         Reviewed by Alexey Proskuryakov.
1803
1804         * BuildSlaveSupport/ews-build/steps.py:
1805         (ApplyPatch.getResultSummary): Override getResultSummary.
1806
1807 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1808
1809         AX: Implement support for new meter ARIA role
1810         https://bugs.webkit.org/show_bug.cgi?id=195966
1811
1812         Reviewed by Chris Fleizach.
1813
1814         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1815         to AXLevelIndicator.
1816
1817         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1818
1819 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1820
1821         [WebAuthN] Implement FIDO AppID extension
1822         https://bugs.webkit.org/show_bug.cgi?id=143491
1823         <rdar://problem/48298273>
1824
1825         Reviewed by Brent Fulgham.
1826
1827         Add a test that covers the new flag of convertToU2fSignCommand.
1828
1829         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1830         (TestWebKitAPI::TEST):
1831         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1832         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1833         (TestWebKitAPI::TEST):
1834
1835 2019-03-19  Keith Rollin  <krollin@apple.com>
1836
1837         Add support for more platforms to generate-xcfilelists
1838         https://bugs.webkit.org/show_bug.cgi?id=195977
1839
1840         Reviewed by Alexey Proskuryakov.
1841
1842         generate-xcfilelists incorrectly complains when involved with building
1843         WebKit for iphonesimulator:
1844
1845             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1846             …
1847             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1848
1849         Address this by teaching generate-xcfilelists about more platforms.
1850
1851         * Scripts/generate-xcfilelists:
1852
1853 2019-03-19  John Wilander  <wilander@apple.com>
1854
1855         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1856         https://bugs.webkit.org/show_bug.cgi?id=195923
1857         <rdar://problem/49001272>
1858
1859         Reviewed by Alex Christensen.
1860
1861         This patch does the following to the TestRunner:
1862         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1863         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1864         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1865
1866         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1867         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1868         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1869         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1870         * WebKitTestRunner/TestController.cpp:
1871         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1872         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1873         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1874         * WebKitTestRunner/TestController.h:
1875         * WebKitTestRunner/TestInvocation.cpp:
1876         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1877
1878 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1879
1880         [CMake] Support more clang and gcc sanitizers
1881         https://bugs.webkit.org/show_bug.cgi?id=195956
1882
1883         Reviewed by Michael Catanzaro.
1884
1885         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1886
1887 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1888
1889         [ews-build] Improve summary for PrintConfiguration step
1890         https://bugs.webkit.org/show_bug.cgi?id=195945
1891
1892         Reviewed by Lucas Forschler.
1893
1894         * BuildSlaveSupport/ews-build/steps.py:
1895         (PrintConfiguration.getResultSummary): Override getResultSummary.
1896
1897 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1898
1899         [ews-build] Improve summary for CheckOutSource step
1900         https://bugs.webkit.org/show_bug.cgi?id=195963
1901
1902         Reviewed by Lucas Forschler.
1903
1904         * BuildSlaveSupport/ews-build/steps.py:
1905         (CheckOutSource.getResultSummary):
1906
1907 2019-03-19  Daniel Bates  <dabates@apple.com>
1908
1909         [iOS] Focus not preserved when switching between tabs
1910         https://bugs.webkit.org/show_bug.cgi?id=195820
1911         <rdar://problem/43614450>
1912
1913         Reviewed by Brent Fulgham.
1914
1915         Add tests to ensure that we restore focus when resigning and becoming first responder.
1916
1917         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1918         (TestWebKitAPI::TEST):
1919
1920 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1921
1922         Make WTFLogChannelState and WTFLogLevel enum classes
1923         https://bugs.webkit.org/show_bug.cgi?id=195904
1924
1925         Reviewed by Eric Carlson.
1926
1927         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1928         (TestWebKitAPI::TEST_F):
1929
1930 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1931
1932         [GStreamer][EME] Backported mssdemux protection data crash fix
1933         https://bugs.webkit.org/show_bug.cgi?id=195918
1934
1935         Reviewed by Philippe Normand.
1936
1937         * gstreamer/jhbuild.modules:
1938         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1939
1940 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1941
1942         Unreviewed, rolling out r243132.
1943
1944         Broke GTK build
1945
1946         Reverted changeset:
1947
1948         "Make WTFLogChannelState and WTFLogLevel enum classes"
1949         https://bugs.webkit.org/show_bug.cgi?id=195904
1950         https://trac.webkit.org/changeset/243132
1951
1952 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1953
1954         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1955
1956         * Scripts/webkitdirs.pm:
1957         (builtDylibPathForName): Adjust the shared library name that's changed
1958         with the API version bump in r243073.
1959
1960 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1961
1962         Make WTFLogChannelState and WTFLogLevel enum classes
1963         https://bugs.webkit.org/show_bug.cgi?id=195904
1964
1965         Reviewed by Eric Carlson.
1966
1967         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1968         (TestWebKitAPI::TEST_F):
1969
1970 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1971
1972         Disable flaky test added in r2431100
1973         https://webkit.org/b/195785
1974
1975         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1976         (TestWebKitAPI::TEST):
1977         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1978
1979 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1980
1981         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1982         https://bugs.webkit.org/show_bug.cgi?id=195916
1983
1984         Reviewed by Tim Horton.
1985
1986         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1987         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1988
1989 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1990
1991         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1992
1993         * Scripts/webkitpy/common/config/contributors.json:
1994
1995 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1996
1997         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1998         https://bugs.webkit.org/show_bug.cgi?id=195785
1999
2000         Reviewed by Geoffrey Garen.
2001
2002         * TestWebKitAPI/TCPServer.cpp: Added.
2003         (TestWebKitAPI::TCPServer::TCPServer):
2004         (TestWebKitAPI::TCPServer::~TCPServer):
2005         (TestWebKitAPI::TCPServer::socketBindListen):
2006         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2007         * TestWebKitAPI/TCPServer.h: Added.
2008         (TestWebKitAPI::TCPServer::port const):
2009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2010         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2011         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2012         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2013         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2014         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2015         (TestWebKitAPI::respondSlowly):
2016         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2017         (TestWebKitAPI::downloadAtRate):
2018         (TestWebKitAPI::TEST):
2019
2020 2019-03-18  Saam Barati  <sbarati@apple.com>
2021
2022         Add a plan file for JetStream 2
2023         https://bugs.webkit.org/show_bug.cgi?id=190734
2024
2025         Reviewed by Mark Lam.
2026
2027         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2028
2029 2019-03-18  Chris Dumez  <cdumez@apple.com>
2030
2031         Delay WebProcess launch until a load is triggered in a Web view
2032         https://bugs.webkit.org/show_bug.cgi?id=195758
2033         <rdar://problem/48126013>
2034
2035         Reviewed by Geoff Garen.
2036
2037         Add API test coverage. Also update some existing API tests to not expect
2038         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2039
2040         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2041         (TestWebKitAPI::TEST):
2042         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2043         (TestWebKitAPI::TEST):
2044         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2045         (TEST):
2046         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2047         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2048         (TEST):
2049         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2050         (TEST):
2051         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2052
2053 2019-03-18  Xan Lopez  <xan@igalia.com>
2054
2055         [CMake] Prevent potential warning when determining $architecture
2056         https://bugs.webkit.org/show_bug.cgi?id=195891
2057
2058         Reviewed by Michael Catanzaro.
2059
2060         It's possible for generateBuildSystemForCMakeProject to be called
2061         before determineArchitecture() is ever called. This will make the
2062         first eq check with $architecture to be bogus (and print a
2063         warning). Change that to an eq check with architecture(), which
2064         implicitly calls determineArchitecture() if needed, and change all
2065         the other similar cases in the method in the same way to prevent
2066         future bugs like this one.
2067
2068         * Scripts/webkitdirs.pm:
2069         (generateBuildSystemFromCMakeProject):
2070
2071 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2072
2073         [WPE] Tarballs generated with “make dist” cannot build documentation
2074         https://bugs.webkit.org/show_bug.cgi?id=195885
2075
2076         Reviewed by Carlos Garcia Campos.
2077
2078         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2079
2080 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2081
2082         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2083         https://bugs.webkit.org/show_bug.cgi?id=195883
2084
2085         Reviewed by Carlos Garcia Campos.
2086
2087         * gtkdoc/gtkdoc.py:
2088         (GTKDoc._run_command): When commands fail to run, include the full command line for
2089         the program invocation and the output it has generated on the standard error stream.
2090
2091 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2092
2093         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2094         https://bugs.webkit.org/show_bug.cgi?id=195786
2095
2096         Reviewed by Philippe Normand.
2097
2098         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2099         * wpe/jhbuild.modules: Ditto.
2100
2101 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2102
2103         [ews-build] Don't run clean builds on EWS builders
2104         https://bugs.webkit.org/show_bug.cgi?id=195851
2105
2106         Reviewed by Geoffrey Garen.
2107
2108         * BuildSlaveSupport/ews-build/factories.py:
2109
2110 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2111
2112         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2113         https://bugs.webkit.org/show_bug.cgi?id=195849
2114
2115         Reviewed by Chris Dumez.
2116
2117         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2118
2119         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2120         (runWebsiteDataStoreCustomPaths):
2121
2122 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2123
2124         webkitpy: Upload test results
2125         https://bugs.webkit.org/show_bug.cgi?id=195755
2126         <rdar://problem/48896182>
2127
2128         Reviewed by Aakash Jain.
2129
2130         Establish a new format for uploading results that is not tied to layout tests, apply
2131         that format to webkitpy tests.
2132
2133         * Scripts/webkitpy/common/checkout/scm/git.py:
2134         (Git.native_branch): Return what branch the current checkout is on.
2135         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2136         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2137         * Scripts/webkitpy/common/checkout/scm/svn.py:
2138         (SVN.native_branch): Ditto.
2139         * Scripts/webkitpy/common/system/platforminfo.py:
2140         (PlatformInfo.build_version): Return a build version for Mac.
2141         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2142         (MockPlatformInfo.__init__):
2143         (MockPlatformInfo.build_version):
2144         * Scripts/webkitpy/results: Added.
2145         * Scripts/webkitpy/results/__init__.py: Added.
2146         * Scripts/webkitpy/results/options.py: Added.
2147         (upload_options): OptParse list for upload options.
2148         * Scripts/webkitpy/results/upload.py: Added.
2149         (Upload): Class which enforces the upload format expected by the results server.
2150         (Upload.Expectations):
2151         (Upload.create_configuration):
2152         (Upload.create_commit):
2153         (Upload.create_details):
2154         (Upload.create_run_stats):
2155         (Upload.create_test_result):
2156         (Upload.__init__):
2157         (Upload.Encoder): Encode Upload object as json.
2158         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2159         * Scripts/webkitpy/results/upload_unittest.py: Added.
2160         * Scripts/webkitpy/test/main.py:
2161         (Tester._parse_args): Add upload arguments.
2162         (Tester._run_tests): Allow results to be uploaded.
2163         * Scripts/webkitpy/test/runner.py:
2164         (Runner.__init__): Record which tests were run, rather than just counting them.
2165         (Runner.handle):
2166         * Scripts/webkitpy/test/runner_unittest.py:
2167         (RunnerTest.test_run):
2168         * Scripts/webkitpy/thirdparty/__init__.py:
2169         (AutoinstallImportHook.find_module): Add requests auto-install.
2170         (AutoinstallImportHook._install_requests):
2171         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2172         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2173
2174 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2175
2176         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2177         https://bugs.webkit.org/show_bug.cgi?id=195810
2178
2179         Reviewed by Tim Horton.
2180
2181         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2182         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2183         ending certain layout tests.
2184
2185         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2186         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2187         (-[TestRunnerWKWebView dealloc]):
2188         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2189
2190         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2191         helper method when destroying the web view, and when resetting state between tests.
2192
2193         * WebKitTestRunner/ios/TestControllerIOS.mm:
2194         (WTR::TestController::platformResetStateToConsistentValues):
2195
2196         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2197
2198 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2199
2200         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2201         https://bugs.webkit.org/show_bug.cgi?id=190350
2202         <rdar://problem/45089503>
2203
2204         Reviewed by Geoffrey Garen.
2205
2206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2207         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2208         (TEST):
2209         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2210         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2211         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2212         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2213         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2214         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2215         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2216         (runTest):
2217         (createDirectories):
2218         (TEST):
2219         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2220         (TEST):
2221         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2222         (TEST):
2223
2224 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2225
2226         Add support to WebPage for getting the contents as an attributed string.
2227         https://bugs.webkit.org/show_bug.cgi?id=195636
2228         rdar://problem/45055697
2229
2230         Reviewed by Tim Horton.
2231
2232         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2233         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2234
2235 2019-03-15  Chris Dumez  <cdumez@apple.com>
2236
2237         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2238         https://bugs.webkit.org/show_bug.cgi?id=195747
2239
2240         Reviewed by Geoff Garen.
2241
2242         Add API test coverage.
2243
2244         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2245
2246 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2247
2248         Unreviewed, rolling out r242952.
2249
2250         Causing API failures on iOS Simulator
2251
2252         Reverted changeset:
2253
2254         "[PSON] Make sure the WebProcessCache is leverage when
2255         relaunching a process after termination"
2256         https://bugs.webkit.org/show_bug.cgi?id=195747
2257         https://trac.webkit.org/changeset/242952
2258
2259 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2260
2261         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2262         https://bugs.webkit.org/show_bug.cgi?id=195740
2263
2264         Reviewed by Ross Kirsling.
2265
2266         window.open doesn't work for WebKitBrowserWindow because it is not
2267         implemented yet.
2268
2269         1. Implemented createNewPage callback of WKPageUIClient.
2270         2. Changed MainWindow to take a BrowserWindow factory function
2271           instead of BrowserWindowType to be flexible to create
2272           BrowserWindow with extra settings.
2273         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2274           because it is not relevant with MainWindow anymore.
2275
2276         * MiniBrowser/win/Common.cpp:
2277         (parseCommandLine):
2278         * MiniBrowser/win/Common.h:
2279         (CommandLineOptions::CommandLineOptions):
2280         * MiniBrowser/win/MainWindow.cpp:
2281         (MainWindow::MainWindow):
2282         (MainWindow::create):
2283         (MainWindow::init):
2284         (MainWindow::WndProc):
2285         * MiniBrowser/win/MainWindow.h:
2286         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2287         (PrintWebUIDelegate::createWebViewWithRequest):
2288         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2289         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2290         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2291         (WebKitBrowserWindow::updateProxySettings):
2292         (WebKitBrowserWindow::createNewPage):
2293         * MiniBrowser/win/WebKitBrowserWindow.h:
2294         * MiniBrowser/win/WinMain.cpp:
2295         (wWinMain):
2296
2297 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2298
2299         Make it possible to test scrolling tree layer manipulation more easily
2300         https://bugs.webkit.org/show_bug.cgi?id=195780
2301
2302         Reviewed by Tim Horton.
2303         
2304         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2305         cuts off communication of scrolling tree scrolls back to the web process
2306         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2307         allows tests to trigger scrolls which run the scrolling tree layer positioning
2308         logic, but never get another commit from the web process that might mask
2309         scrolling tree bugs.
2310         
2311         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2312         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2313         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2314
2315         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2316         (WTR::UIScriptController::scrollUpdatesDisabled const):
2317         (WTR::UIScriptController::setScrollUpdatesDisabled):
2318         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2319         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2320         (WTR::UIScriptController::scrollUpdatesDisabled const):
2321         (WTR::UIScriptController::setScrollUpdatesDisabled):
2322         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2323         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2324         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2325         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2326         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2327         * WebKitTestRunner/ios/TestControllerIOS.mm:
2328         (WTR::TestController::platformResetStateToConsistentValues):
2329         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2330         (WTR::UIScriptController::scrollUpdatesDisabled const):
2331         (WTR::UIScriptController::setScrollUpdatesDisabled):
2332
2333 2019-03-14  Youenn Fablet  <youenn@apple.com>
2334
2335         Move IDB storage in private browsing mode to NetworkProcess
2336         https://bugs.webkit.org/show_bug.cgi?id=195602
2337
2338         Reviewed by Brady Eidson.
2339
2340         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2341         (TEST):
2342
2343 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2344
2345         [ews-build] Make descriptionDone messages more readable
2346         https://bugs.webkit.org/show_bug.cgi?id=195760
2347
2348         Reviewed by Lucas Forschler.
2349
2350         * BuildSlaveSupport/ews-build/steps.py:
2351         * BuildSlaveSupport/ews-build/steps_unittest.py:
2352
2353 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2354
2355         [ews-build] Generate status-bubble hover-over messages
2356         https://bugs.webkit.org/show_bug.cgi?id=195680
2357
2358         Reviewed by Lucas Forschler.
2359
2360         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2361         (StatusBubble):
2362         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2363         on hover-over.
2364         (StatusBubble._iso_time):
2365         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2366         hover-over message.
2367         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2368
2369 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2370
2371         [ews-app] Gracefully handle the case when state_string is None
2372         https://bugs.webkit.org/show_bug.cgi?id=195753
2373
2374         Reviewed by Lucas Forschler.
2375
2376         * BuildSlaveSupport/ews-app/ews/models/build.py:
2377         * BuildSlaveSupport/ews-app/ews/models/step.py:
2378
2379 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2380
2381         [ews-app] Status bubble display pending for currently running build step
2382         https://bugs.webkit.org/show_bug.cgi?id=195744
2383
2384         Reviewed by Lucas Forschler.
2385
2386         * BuildSlaveSupport/ews-build/events.py:
2387         (Events.stepStarted): If state_string is pending, replace it with step name.
2388
2389 2019-03-14  Chris Dumez  <cdumez@apple.com>
2390
2391         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2392         https://bugs.webkit.org/show_bug.cgi?id=195750
2393
2394         Reviewed by Geoffrey Garen.
2395
2396         Add API test coverage.
2397
2398         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2399         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2400         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2401         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2402
2403 2019-03-14  Chris Dumez  <cdumez@apple.com>
2404
2405         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2406         https://bugs.webkit.org/show_bug.cgi?id=195747
2407
2408         Reviewed by Geoff Garen.
2409
2410         Add API test coverage.
2411
2412         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2413
2414 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2415
2416         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2417         https://bugs.webkit.org/show_bug.cgi?id=195725
2418         <rdar://problem/48545062>
2419
2420         Reviewed by Tim Horton.
2421
2422         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2423         handler is nil.
2424
2425         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2426         (TestWebKitAPI::TEST):
2427
2428 2019-03-13  Sam Weinig  <sam@webkit.org>
2429
2430         Add utility function to allow easy reverse range-based iteration of a container
2431         https://bugs.webkit.org/show_bug.cgi?id=195542
2432
2433         Reviewed by Antti Koivisto.
2434
2435         * TestWebKitAPI/CMakeLists.txt:
2436         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2437         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2438         (TestWebKitAPI::TEST):
2439         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2440
2441 2019-03-13  Chris Dumez  <cdumez@apple.com>
2442
2443         Use a ServiceWorker process per registrable domain
2444         https://bugs.webkit.org/show_bug.cgi?id=195649
2445
2446         Reviewed by Youenn Fablet.
2447
2448         Update API test coverage.
2449
2450         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2451
2452 2019-03-13  Chris Dumez  <cdumez@apple.com>
2453
2454         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2455         https://bugs.webkit.org/show_bug.cgi?id=195684
2456         <rdar://problem/48294714>
2457
2458         Reviewed by Antti Koivisto.
2459
2460         Add API test coverage.
2461
2462         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2463
2464 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2465
2466         [ews-app] Remove unused patch view
2467         https://bugs.webkit.org/show_bug.cgi?id=195669
2468
2469         Reviewed by Lucas Forschler.
2470
2471         * BuildSlaveSupport/ews-app/ews/urls.py:
2472         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2473
2474 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2475
2476         [ews-app] Use Buildbot result code variables
2477         https://bugs.webkit.org/show_bug.cgi?id=195668
2478
2479         Reviewed by Alexey Proskuryakov.
2480
2481         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2482         (Buildbot): Added Buildbot result code variables.
2483         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2484         (StatusBubble._build_bubble): Used Buildbot result code variables.
2485
2486 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2487
2488         [Flatpak] Expand submodule recursively
2489         https://bugs.webkit.org/show_bug.cgi?id=195672
2490
2491         Building WPE with flatpak was impossible without that as it was raising an exception.
2492         Also update wpebackend-fdo to match what is built in jhbuild
2493
2494         Reviewed by Philippe Normand.
2495
2496         * flatpak/flatpakutils.py:
2497         (expand_submodules_recurse):
2498         (expand_manifest):
2499         * flatpak/org.webkit.WPEModules.yaml:
2500
2501 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2502
2503         [ews-app] status bubble should be hidden for certain builds
2504         https://bugs.webkit.org/show_bug.cgi?id=194597
2505
2506         Reviewed by Dewei Zhu.
2507
2508         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2509         (StatusBubble._build_bubble):
2510         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2511         because the patch didn't have relevant changes.
2512         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2513         in production yet.
2514
2515 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2516
2517         [Win] Fix a slew of simple clang-cl warnings.
2518         https://bugs.webkit.org/show_bug.cgi?id=195652
2519
2520         Reviewed by Don Olmstead.
2521
2522         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2523         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2524
2525 2019-03-12  Justin Fan  <justin_fan@apple.com>
2526
2527         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2528         https://bugs.webkit.org/show_bug.cgi?id=195518
2529         <rdar://problem/46322356>
2530
2531         Reviewed by Myles C. Maxfield.
2532
2533         * DumpRenderTree/DerivedSources-input.xcfilelist:
2534         * DumpRenderTree/DerivedSources-output.xcfilelist:
2535
2536 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2537
2538         Unreviewed, rolling out r242825.
2539         https://bugs.webkit.org/show_bug.cgi?id=195648
2540
2541         "Broke webkitpy tests with my change to
2542         lldb_dump_class_layout.py" (Requested by rmorisset on
2543         #webkit).
2544
2545         Reverted changeset:
2546
2547         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2548         classes with suspicious padding"
2549         https://bugs.webkit.org/show_bug.cgi?id=195573
2550         https://trac.webkit.org/changeset/242825
2551
2552 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2553
2554         [ews-build] Show status bubbles while the patch is waiting in queue
2555         https://bugs.webkit.org/show_bug.cgi?id=195618
2556
2557         Reviewed by Lucas Forschler.
2558
2559         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2560         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2561         enabled in initial deployment.
2562         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2563         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2564         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2565         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2566         (StatusBubble._build_bubbles_for_patch):
2567
2568 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2569
2570         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2571         https://bugs.webkit.org/show_bug.cgi?id=195573
2572
2573         Reviewed by Simon Fraser.
2574
2575         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2576
2577         * Scripts/dump-class-layout:
2578         (main):
2579         * lldb/lldb_dump_class_layout.py:
2580         (ClassLayout.__init__):
2581         (ClassLayout._compute_padding_recursive):
2582         (LLDBDebuggerInstance.dump_layout_for_classname):
2583         (LLDBDebuggerInstance):
2584         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2585         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2586
2587 2019-03-12  Chris Dumez  <cdumez@apple.com>
2588
2589         Device Orientation access permission should be denied unless explicitly granted by the client
2590         https://bugs.webkit.org/show_bug.cgi?id=195625
2591
2592         Reviewed by Youenn Fablet.
2593
2594         add API test coverage.
2595
2596         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2597         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2598         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2599         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2600         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2601         (runDeviceOrientationTest):
2602         (TEST):
2603         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2604         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2605
2606 2019-03-12  Jer Noble  <jer.noble@apple.com>
2607
2608         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2609         https://bugs.webkit.org/show_bug.cgi?id=195137
2610         <rdar://problem/48810307>
2611
2612         Reviewed by Eric Carlson.
2613
2614         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2615         (TestWebKitAPI::TEST):
2616
2617 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2618
2619         [ews-build] Change urls from uat to production
2620         https://bugs.webkit.org/show_bug.cgi?id=195566
2621
2622         Reviewed by Lucas Forschler.
2623
2624         * BuildSlaveSupport/ews-app/ews/config.py:
2625         * BuildSlaveSupport/ews-build/events.py:
2626         * BuildSlaveSupport/ews-build/steps.py:
2627
2628 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2629
2630         [ews-build] change max_builds for local-worker to 1
2631         https://bugs.webkit.org/show_bug.cgi?id=195568
2632
2633         Reviewed by Lucas Forschler.
2634
2635         * BuildSlaveSupport/ews-build/loadConfig.py:
2636
2637 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2638
2639         Fix the build
2640
2641         * TestRunnerShared/spi/PencilKitTestSPI.h:
2642         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2643
2644 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2645
2646         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2647         https://bugs.webkit.org/show_bug.cgi?id=194131
2648
2649         Reviewed by Michael Catanzaro.
2650
2651         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2652         (uriChanged):
2653         (testUnfinishedSubresourceLoad):
2654         (serverCallback):
2655         (beforeAll):
2656
2657 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2658
2659         WTF::Expected should use std::addressof instead of operator&
2660         https://bugs.webkit.org/show_bug.cgi?id=195604
2661
2662         Reviewed by Myles Maxfield.
2663
2664         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2665         (TestWebKitAPI::Unique::Unique):
2666         (TestWebKitAPI::Unique::operator&):
2667         (TestWebKitAPI::TEST):
2668
2669 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2670
2671         Add Optional to Forward.h.
2672         https://bugs.webkit.org/show_bug.cgi?id=195586
2673
2674         Reviewed by Darin Adler.
2675
2676         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2677         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2678         Remove unnecessary includes from headers.
2679
2680 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2681
2682         Add testing API to hit-test and scroll overflow scrollers
2683         https://bugs.webkit.org/show_bug.cgi?id=195278
2684
2685         Reviewed by Antti Koivisto.
2686         
2687         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2688         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2689         
2690         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2691
2692         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2693         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2694         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2695         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2696         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2697         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2698         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2699         (WTR::enclosingScrollViewIncludingSelf):
2700         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2701
2702 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2703
2704         API test WebKit.RequestTextInputContext fails on iOS
2705         https://bugs.webkit.org/show_bug.cgi?id=195585
2706
2707         Reviewed by Wenson Hsieh and Simon Fraser.
2708
2709         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2710         (applyStyle):
2711         (TEST):
2712         Add a viewport, so that the coordinates match up on iOS.
2713         Scroll by moving the UIScrollView's contentOffset.
2714
2715 2019-03-11  Chris Dumez  <cdumez@apple.com>
2716
2717         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2718         https://bugs.webkit.org/show_bug.cgi?id=195506
2719         <rdar://problem/48733477>
2720
2721         Reviewed by Alex Christensen.
2722
2723         Add API test coverage.
2724
2725         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2726
2727 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2728
2729         Adding myself to contributors.json
2730
2731         Unreviewed, addming myself to contributors.json .
2732
2733         * Scripts/webkitpy/common/config/contributors.json:
2734
2735 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2736
2737         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2738         https://bugs.webkit.org/show_bug.cgi?id=195511
2739         <rdar://problem/44873269>
2740
2741         Reviewed by Darin Adler.
2742
2743         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2744         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2745         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2746         (TEST_F):
2747
2748 2019-03-11  Chris Dumez  <cdumez@apple.com>
2749
2750         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2751         https://bugs.webkit.org/show_bug.cgi?id=195561
2752
2753         Reviewed by Youenn Fablet.
2754
2755         Make sure the JS in the test requests for permission to receive device orientation events.
2756
2757         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2758
2759 2019-03-11  Youenn Fablet  <youenn@apple.com>
2760
2761         Allow storage quota increase by default in WTR
2762         https://bugs.webkit.org/show_bug.cgi?id=195541
2763
2764         Reviewed by Geoffrey Garen.
2765
2766         Allow storage quota increase by default in WTR.
2767         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2768         Use this for tests that explicitly need cache increase.
2769
2770         Instead of increasing quota by 2, make sure the next request is
2771         granted by adding all given parameters.
2772
2773         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2774         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2775         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2776         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2777         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2778         * WebKitTestRunner/TestController.cpp:
2779         (WTR::TestController::setAllowStorageQuotaIncrease):
2780         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2781         * WebKitTestRunner/TestController.h:
2782         * WebKitTestRunner/TestInvocation.cpp:
2783         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2784         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2785         (WTR::TestController::cocoaResetStateToConsistentValues):
2786         (WTR::TestController::setAllowStorageQuotaIncrease):
2787         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2788         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2789         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2790
2791 2019-03-11  Xan Lopez  <xan@igalia.com>
2792
2793         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2794         https://bugs.webkit.org/show_bug.cgi?id=194147
2795
2796         Reviewed by Michael Saboff.
2797
2798         To make --32-bit work correctly on Linux/64bit we need to:
2799
2800         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2801         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2802         unfortunately CMake only allows us to do this during
2803         crosscompilation, which is overkill here.
2804         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2805         pkg-config detection module uses the x86 .pc files instead of the
2806         x86_64 ones.
2807         - Set the -m32 flags for the compiler.
2808
2809         * Scripts/webkitdirs.pm:
2810         (generateBuildSystemFromCMakeProject):
2811
2812 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2813
2814         Add MotionMark-1.1 plan file for run-benchmark script.
2815         https://bugs.webkit.org/show_bug.cgi?id=195481
2816
2817         Rubber-stamped by Darin Adler.
2818
2819         Run-benchmark script should support MontionMark-1.1.
2820
2821         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2822
2823 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2824
2825         [ews-app] Add support for submit-to-ews url
2826         https://bugs.webkit.org/show_bug.cgi?id=195477
2827
2828         Reviewed by Lucas Forschler.
2829
2830         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2831         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2832         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2833         * BuildSlaveSupport/ews-app/ews/urls.py:
2834         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2835
2836 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2837
2838         Unreviewed, rolling out r242688, r242643, r242624.
2839
2840         Caused multiple layout test failures and crashes on iOS and macOS.
2841
2842         Reverted changeset:
2843
2844         "requestAnimationFrame should execute before the next frame"
2845         https://bugs.webkit.org/show_bug.cgi?id=177484
2846         https://trac.webkit.org/changeset/242624/webkit
2847
2848         * Tracing/SystemTracePoints.plist:
2849
2850 2019-03-11  John Wilander  <wilander@apple.com>
2851
2852         Resource Load Statistics: Make it possible exclude localhost from classification
2853         https://bugs.webkit.org/show_bug.cgi?id=195474
2854         <rdar://problem/47520577>
2855
2856         Reviewed by Brent Fulgham.
2857
2858         This patch allows for localhost to be excluded from classification and
2859         treatment as a prevalent resource.
2860
2861         The WebKit Tools change adds a new function called
2862         testRunner.setStatisticsIsRunningTest() which can be used to control this
2863         behavior.
2864
2865         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2866         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2867         (WTR::TestRunner::setStatisticsIsRunningTest):
2868         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2869         * WebKitTestRunner/TestController.cpp:
2870         (WTR::TestController::setStatisticsIsRunningTest):
2871         * WebKitTestRunner/TestController.h:
2872         * WebKitTestRunner/TestInvocation.cpp:
2873         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2874
2875 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2876
2877         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2878         https://bugs.webkit.org/show_bug.cgi?id=195560
2879
2880         Reviewed by Lucas Forschler.
2881
2882         * BuildSlaveSupport/ews-build/master.cfg:
2883
2884 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2885
2886         Unreviewed, rolling out r242698.
2887
2888         API test crashes on bots.
2889
2890         Reverted changeset:
2891
2892         "Add a WKContentRuleList variant that uses copied memory
2893         instead of mmap'd shared memory for class A containerized
2894         apps"
2895         https://bugs.webkit.org/show_bug.cgi?id=195511
2896         https://trac.webkit.org/changeset/242698
2897
2898 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2899
2900         [WPE] Enable web process sandbox
2901         https://bugs.webkit.org/show_bug.cgi?id=195169
2902
2903         Reviewed by Daniel Bates.
2904
2905         * wpe/install-dependencies:
2906         * wpe/jhbuild.modules:
2907
2908 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2909
2910         [ews-app] Use port 17000 for worker communication
2911         https://bugs.webkit.org/show_bug.cgi?id=195558
2912
2913         Reviewed by Lucas Forschler.
2914
2915         * BuildSlaveSupport/ews-build/master.cfg:
2916
2917 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2918
2919         [ews-build] unit-tests fail when passwords.json is missing
2920         https://bugs.webkit.org/show_bug.cgi?id=195557
2921
2922         Reviewed by Lucas Forschler.
2923
2924         * BuildSlaveSupport/ews-build/loadConfig.py:
2925         (loadBuilderConfig):
2926         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2927         (ConfigDotJSONTest.test_configuration):
2928         * BuildSlaveSupport/ews-build/master.cfg:
2929
2930 2019-03-11  Truitt Savell  <tsavell@apple.com>
2931
2932         Unreviewed, rolling out r242702.
2933
2934         Broke High Sierra builders.
2935
2936         Reverted changeset:
2937
2938         "Add utility function to allow easy reverse range-based
2939         iteration of a container"
2940         https://bugs.webkit.org/show_bug.cgi?id=195542
2941         https://trac.webkit.org/changeset/242702
2942
2943 2019-03-11  Sam Weinig  <sam@webkit.org>
2944
2945         Add utility function to allow easy reverse range-based iteration of a container
2946         https://bugs.webkit.org/show_bug.cgi?id=195542
2947
2948         Reviewed by Antti Koivisto.
2949
2950         * TestWebKitAPI/CMakeLists.txt:
2951         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2952         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2953         (TestWebKitAPI::TEST):
2954         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2955
2956 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2957
2958         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2959         https://bugs.webkit.org/show_bug.cgi?id=195511
2960         <rdar://problem/44873269>
2961
2962         Reviewed by Darin Adler.
2963
2964         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2965         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2966         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2967         (TEST_F):
2968
2969 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2970
2971         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2972         https://bugs.webkit.org/show_bug.cgi?id=195499
2973
2974         Reviewed by Darin Adler.
2975
2976         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2977         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2978         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2979         (-[WKWebView synchronouslyFocusTextInputContext:]):
2980         (applyStyle):
2981         (applyIframe):
2982         (TEST):
2983         Add some tests for this SPI.
2984
2985 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2986
2987         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2988         https://bugs.webkit.org/show_bug.cgi?id=181151
2989
2990         Reviewed by Don Olmstead.
2991
2992         * TestWebKitAPI/CMakeLists.txt:
2993         * TestWebKitAPI/PlatformWin.cmake:
2994         Enable TestWTF RunLoop tests in all platforms.
2995
2996         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2997         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2998         (TestWebKitAPI::DerivedOneShotTimer::fired):
2999         (TestWebKitAPI::TEST):
3000         Only a few platforms support nested RunLoop.
3001
3002         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3003         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3004
3005 2019-03-10  David Quesada  <david_quesada@apple.com>
3006
3007         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3008         https://bugs.webkit.org/show_bug.cgi?id=152480
3009
3010         Reviewed by Chris Dumez.
3011
3012         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3013         there are no additional references to the process pool besides the one held by
3014         the download, waits for the download to finish (in the sense that the
3015         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3016         measure, also check that the process pool has been deallocated at the end of the
3017         test. The test wouldn't be meaningful if the process pool were still alive.
3018
3019         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3020         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3021         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3022             The download will be canceled because the delegate does not implement the
3023             method to decide the download's destination, so this is where we know the
3024             DownloadProxyMap is done with the DownloadProxy.
3025         (TEST):
3026
3027 2019-03-08  Chris Dumez  <cdumez@apple.com>
3028
3029         Add support for Device Orientation / Motion permission API
3030         https://bugs.webkit.org/show_bug.cgi?id=195329
3031         <rdar://problem/47645367>
3032
3033         Reviewed by Geoffrey Garen.
3034
3035         Add test infrastructure to help test the Device Orientation / Motion permission API.
3036
3037         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3038         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3039         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3040         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3041         * WebKitTestRunner/TestController.cpp:
3042         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3043         (WTR::TestController::createWebViewWithOptions):
3044         (WTR::TestController::resetStateToConsistentValues):
3045         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3046         * WebKitTestRunner/TestController.h:
3047         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3048         * WebKitTestRunner/TestInvocation.cpp:
3049         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3050
3051 2019-03-08  Saam barati  <sbarati@apple.com>
3052
3053         Add a compare-results script to compare benchmark results
3054         https://bugs.webkit.org/show_bug.cgi?id=195486
3055         <rdar://problem/48723397>
3056
3057         Reviewed by Geoffrey Garen.
3058
3059         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3060         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3061         to extend it to learn about our other benchmarks.
3062
3063         * Scripts/compare-results: Added.
3064         (readJSONFile):
3065         (detectJetStream2):
3066         (JetStream2Results):
3067         (detectSpeedometer2):
3068         (Speedometer2Results):
3069         (detectPLT5):
3070         (PLT5Results):
3071         (detectBenchmark):
3072         (biggerIsBetter):
3073         (ttest):
3074         (getOptions):
3075         (main):
3076
3077 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3078
3079         Ensure old tab state is cleared between iterations of run-benchmark
3080         https://bugs.webkit.org/show_bug.cgi?id=195393
3081         <rdar://problem/46885583>
3082
3083         Reviewed by Dewei Zhu.
3084
3085         a) ensure the default to restore state is not set
3086         b) terminate Safari correctly
3087         c) Set the system default to ignore Persistent State in Safari
3088
3089         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3090         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3091         (OSXBrowserDriver.prepare_env): 
3092         (OSXBrowserDriver.restore_env):
3093         (OSXBrowserDriver.close_browsers):
3094         (OSXBrowserDriver._terminate_processes):
3095         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3096         (OSXChromeDriver):
3097         (OSXChromeCanaryDriver):
3098         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3099         (OSXFirefoxDriver):
3100         (OSXFirefoxNightlyDriver):
3101         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3102         (OSXSafariDriver):
3103         (OSXSafariDriver.prepare_env):
3104
3105 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3106
3107         [GTK] Several InputMethodFilter tests are failing
3108         https://bugs.webkit.org/show_bug.cgi?id=195408
3109
3110         Reviewed by Carlos Garcia Campos.
3111
3112         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3113         Regressed in r241751.
3114         Hexadecimal values of keycodes are expressed now in upper letters.
3115         Composited characters should be cast to UTF8 strings.
3116
3117         (TestWebKitAPI::TEST):
3118
3119 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3120
3121         [GTK] Make Tools/gtkdoc python3 compatible
3122         https://bugs.webkit.org/show_bug.cgi?id=195359
3123
3124         Reviewed by Carlos Garcia Campos.
3125
3126         * gtkdoc/generate-gtkdoc:
3127         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3128         work with Python 2 and 3.
3129         (get_gtkdoc_module_paths):
3130         The iteritems() was removed in Python 3, so let's use items() that's
3131         available in Python 2 and 3.
3132         (get_generator_for_config):
3133         * gtkdoc/gtkdoc.py:
3134         (GTKDoc._run_command):
3135         The sys.stdout.write() is expecting str in Python 3 and not bytes
3136         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3137         for passing the bytes there.
3138
3139 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3140
3141         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3142         https://bugs.webkit.org/show_bug.cgi?id=195346
3143         <rdar://problem/48667048>
3144
3145         Unreviewed build fix for clang-cl.
3146
3147         * DumpRenderTree/win/DumpRenderTree.cpp:
3148         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3149
3150 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3151
3152         requestAnimationFrame should execute before the next frame
3153         https://bugs.webkit.org/show_bug.cgi?id=177484
3154
3155         Reviewed by Simon Fraser.
3156
3157         Add trace points for the page RenderingUpdate.
3158
3159         * Tracing/SystemTracePoints.plist:
3160
3161 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3162
3163         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3164         https://bugs.webkit.org/show_bug.cgi?id=195353
3165         <rdar://problem/48626394>
3166
3167         Reviewed by Simon Fraser.
3168
3169         * WebKitTestRunner/ios/TestControllerIOS.mm:
3170         (WTR::TestController::platformResetPreferencesToConsistentValues):
3171
3172 2019-03-07  John Wilander  <wilander@apple.com>
3173
3174         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3175         https://bugs.webkit.org/show_bug.cgi?id=195383
3176         <rdar://problem/48570136>
3177
3178         Reviewed by Brent Fulgham.
3179
3180         This patch adds test infrastructure to purge only script-accessible cookies,
3181         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3182
3183         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3184         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3185         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3186         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3187         * WebKitTestRunner/TestController.cpp:
3188         (WTR::TestController::statisticsDeleteCookiesForHost):
3189         * WebKitTestRunner/TestController.h:
3190         * WebKitTestRunner/TestInvocation.cpp:
3191         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3192
3193 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3194
3195         Unreviewed, rolling out r242354.
3196         https://bugs.webkit.org/show_bug.cgi?id=195402
3197
3198         breaks layout tests in all configurations (Requested by
3199         zdobersek on #webkit).
3200
3201         Reverted changeset:
3202
3203         "[WPE] Enable web process sandbox"
3204         https://bugs.webkit.org/show_bug.cgi?id=195169
3205         https://trac.webkit.org/changeset/242354
3206
3207 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3208
3209         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3210         https://bugs.webkit.org/show_bug.cgi?id=195346
3211
3212         Reviewed by Fujii Hironori.
3213
3214         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3215         (TestWebKitAPI::TEST):
3216         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3217
3218         * DumpRenderTree/win/DumpRenderTree.cpp:
3219         (findFontFallback):
3220         (addFontFallbackIfPresent):
3221         (removeFontFallbackIfPresent):
3222         (main):
3223         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3224         (TestWebKitAPI::Util::moduleDirectory):
3225         (TestWebKitAPI::Util::createInjectedBundlePath):
3226         Use wchar helpers as needed.
3227
3228 2019-03-06  Rob Buis  <rbuis@igalia.com>
3229
3230         Consider supporting the `referrerpolicy` attribute.
3231         https://bugs.webkit.org/show_bug.cgi?id=179053
3232
3233         Reviewed by Darin Adler.
3234
3235         Add a runtime flag for referrerpolicy attribute.
3236
3237         * DumpRenderTree/mac/DumpRenderTree.mm:
3238         (enableExperimentalFeatures):
3239
3240 2019-03-05  Daniel Bates  <dabates@apple.com>
3241
3242         Update expected API test result following r242379
3243         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3244
3245         Update expected x-coordinate of selection rect now that the left padding of
3246         a textarea is sized in ems (so dependent on the font size) just like the left
3247         padding of a text field.
3248
3249         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3250         (TestWebKitAPI::TEST):
3251
3252 2019-03-05  David Quesada  <david_quesada@apple.com>
3253
3254         [WK2] It should be possible to follow links with 'download' attributes
3255         https://bugs.webkit.org/show_bug.cgi?id=195145
3256         rdar://problem/48462642
3257
3258         Reviewed by Alex Christensen.
3259
3260         Add a unit test to verify that activating links with 'download' attributes now
3261         navigates to the linked resource, rather than starts downloading it. Add another
3262         to verify that it is still possible to explicitly download the link via the
3263         'Download' navigation action policy.
3264
3265         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3266         (-[DownloadAttributeTestDelegate init]):
3267         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3268         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3269         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3270         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3271         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3272         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3273         (TEST):
3274         * WebKitTestRunner/TestController.cpp:
3275         (WTR::TestController::decidePolicyForNavigationAction):
3276         * WebKitTestRunner/TestController.h:
3277
3278 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3279
3280         [Curl] Implement Cookie Accept Policy.
3281         https://bugs.webkit.org/show_bug.cgi?id=191645
3282
3283         Reviewed by Fujii Hironori.
3284
3285         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3286         (TestWebKitAPI::Curl::TEST_F):
3287
3288 2019-03-05  Youenn Fablet  <youenn@apple.com>
3289
3290         Rename requestCacheStorageSpace to requestStorageSpace
3291         https://bugs.webkit.org/show_bug.cgi?id=195282
3292
3293         Reviewed by Chris Dumez.
3294
3295         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3296         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3297         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3298
3299 2019-03-05  Brady Eidson  <beidson@apple.com>
3300
3301         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3302         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3303
3304         Reviewed by Tim Horton.
3305
3306         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3307         different directory into that same WKWebView should work.
3308
3309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3310         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3311
3312 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3313
3314         Add WeakHashSet
3315         https://bugs.webkit.org/show_bug.cgi?id=195152
3316
3317         Reviewed by Antti Koivisto.
3318
3319         Added tests for WeakHashSet.
3320
3321         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3322         (TestWebKitAPI::Base::Base): Moved.
3323         (TestWebKitAPI::Derived::foo): Moved.
3324         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3325         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3326         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3327         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3328
3329 2019-03-04  Chris Dumez  <cdumez@apple.com>
3330
3331         Do not share WebProcesses between private and regular sessions
3332         https://bugs.webkit.org/show_bug.cgi?id=195189
3333         <rdar://problem/48421064>
3334
3335         Reviewed by Alex Christensen.
3336
3337         Add API test coverage.
3338
3339         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3340         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3341
3342 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3343
3344         [WPE] Enable web process sandbox
3345         https://bugs.webkit.org/show_bug.cgi?id=195169
3346
3347         Reviewed by Daniel Bates.
3348
3349         * wpe/install-dependencies:
3350         * wpe/jhbuild.modules:
3351
3352 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3353
3354         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3355         https://bugs.webkit.org/show_bug.cgi?id=195206
3356
3357         Reviewed by Žan Doberšek.
3358
3359         Add a new test case.
3360
3361         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3362         (testJSCClass):
3363
3364 2019-03-04  Charlie Turner  <cturner@igalia.com>
3365
3366         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3367         https://bugs.webkit.org/show_bug.cgi?id=194898
3368
3369         Reviewed by Žan Doberšek.
3370
3371         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3372         a GCC extension that permits arithmetic on void* pointer. Inline
3373         the macro until this issue is fixed upstream.
3374
3375 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3376
3377         Rid the world of WK_API_ENABLED
3378         https://bugs.webkit.org/show_bug.cgi?id=195263
3379
3380         Reviewed by Dan Bernstein.
3381
3382         List of changed files elided because it's useless.
3383
3384 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3385
3386         Unreviewed follow-up to r242292.
3387
3388         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3389
3390         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3391         (TestWebKitAPI::testStrip): Renamed from strip.
3392         (TestWebKitAPI::TEST):
3393
3394 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3395
3396         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3397
3398         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3399         and bug #194272 for details.
3400
3401         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3402
3403 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3404
3405         Remove some more unused 32-bit code
3406         https://bugs.webkit.org/show_bug.cgi?id=195255
3407
3408         Reviewed by Darin Adler.
3409
3410         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3411         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3412         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3413         (NPP_New):
3414         (NPP_HandleEvent):
3415         (handleEventCarbon): Deleted.
3416
3417 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3418
3419         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3420
3421         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3422         (TestWebKitAPI::TEST):
3423
3424 2019-03-01  Darin Adler  <darin@apple.com>
3425
3426         Finish removing String::format
3427         https://bugs.webkit.org/show_bug.cgi?id=194893
3428
3429         Reviewed by Daniel Bates.
3430 '
3431         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3432
3433 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3434
3435         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3436         https://bugs.webkit.org/show_bug.cgi?id=195229
3437         <rdar://problem/48520362>
3438
3439         Reviewed by Chris Dumez.
3440
3441         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3442         (TEST):
3443
3444 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3445
3446         Add a system trace scope for event region building
3447         https://bugs.webkit.org/show_bug.cgi?id=195226
3448
3449         Reviewed by Jon Lee.
3450
3451         This trace scope measures the time spend converting element rects into Region objects,
3452         which can be large on some pages.
3453
3454         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3455
3456         * Tracing/SystemTracePoints.plist:
3457
3458 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3459
3460         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3461         https://bugs.webkit.org/show_bug.cgi?id=194612
3462
3463         Reviewed by Alex Christensen.
3464
3465         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3466         Just test the new string-processing function and don't touch the actual environment.
3467         (Test cases are all as before, but based on operator== instead of strcmp.)
3468
3469 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3470
3471         [ews-app] Update primary keys for handling multiple Buildbot instances
3472         https://bugs.webkit.org/show_bug.cgi?id=195120
3473
3474         Reviewed by Stephanie Lewis.
3475
3476         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3477         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3478         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3479
3480         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3481         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3482         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3483         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3484         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3485         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3486
3487 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3488
3489         [WinCairo] Enable service worker
3490         https://bugs.webkit.org/show_bug.cgi?id=188318
3491
3492         Reviewed by Youenn Fablet.
3493
3494         * DumpRenderTree/DumpRenderTreePrefix.h:
3495         * TestWebKitAPI/PlatformWin.cmake:
3496         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3497         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3498         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3499
3500 2019-03-01  Justin Fan  <justin_fan@apple.com>
3501
3502         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3503         https://bugs.webkit.org/show_bug.cgi?id=195191
3504
3505         Rubber-stamped by Dean Jackson.
3506
3507         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3508
3509         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3510
3511 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3512
3513         Unreviewed, fix lldb webkitpy tests
3514         https://bugs.webkit.org/show_bug.cgi?id=194375
3515
3516         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3517
3518         * lldb/lldb_webkit.py:
3519         (WTFStringImplProvider.is_8bit):
3520
3521 2019-02-28  David Quesada  <david_quesada@apple.com>
3522
3523         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3524         https://bugs.webkit.org/show_bug.cgi?id=195121
3525         rdar://problem/48450302
3526
3527         Reviewed by Alex Christensen.
3528
3529         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3530         configurations where the 'download' attribute is absent, blank, or populated
3531         with a filename, and where the anchor element is same-origin or cross-origin
3532         (meaning the 'download' attribute shouldn't be honored).
3533
3534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3535         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3536         (-[NavigationActionTestDelegate init]):
3537         (-[NavigationActionTestDelegate navigationAction]):
3538         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3539         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3540         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3541         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3542         (TEST):
3543
3544 2019-02-28  Antoine Quint  <graouts@apple.com>
3545
3546         Enable the Pointer Events runtime flag by default
3547         https://bugs.webkit.org/show_bug.cgi?id=195156
3548
3549         Reviewed by Dean Jackson.
3550
3551         * DumpRenderTree/mac/DumpRenderTree.mm:
3552         (enableExperimentalFeatures):
3553
3554 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3555
3556         Several PasteImage API tests are flaky
3557         https://bugs.webkit.org/show_bug.cgi?id=195160
3558
3559         Reviewed by Tim Horton.
3560
3561         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3562         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3563         listening for a "load" event after image load is already complete.
3564
3565         To address this, make these tests first register a "load" event handler, then run script to insert an image
3566         element into the document, and finally wait until the load event is observed before checking image size.
3567
3568         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3569
3570 2019-02-28  Chris Dumez  <cdumez@apple.com>
3571
3572         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3573         https://bugs.webkit.org/show_bug.cgi?id=195107
3574
3575         Reviewed by Alex Christensen.
3576
3577         Give some time for the zoom level to get restored.
3578
3579         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3580
3581 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3582
3583         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3584         https://bugs.webkit.org/show_bug.cgi?id=194958
3585
3586         Reviewed by Geoffrey Garen.
3587
3588         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3589         (TEST):
3590
3591 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3592
3593         [ews-app] Update method to save build to handle builder_display_name
3594         https://bugs.webkit.org/show_bug.cgi?id=195047
3595
3596         Reviewed by Dewei Zhu.
3597
3598         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3599         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3600
3601 2019-02-28  Justin Fan  <justin_fan@apple.com>
3602
3603         [Web GPU] Enable Web GPU only on 64-bit
3604         https://bugs.webkit.org/show_bug.cgi?id=195139
3605
3606         Because Metal is only supported on 64 bit apps.
3607
3608         Unreviewed build fix.
3609
3610         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3611
3612 2019-02-27  Youenn Fablet  <youenn@apple.com>
3613
3614         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3615         https://bugs.webkit.org/show_bug.cgi?id=194959
3616
3617         Reviewed by Chris Dumez.
3618
3619         Spin loop until getting the condition to remove flakiness.
3620
3621         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3622
3623 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3624
3625         [ews-build] Buildbot should include builder_display_name in the build events
3626         https://bugs.webkit.org/show_bug.cgi?id=195045
3627
3628         Reviewed by Dewei Zhu.
3629
3630         * BuildSlaveSupport/ews-build/events.py:
3631         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3632         buildername to builder_name to be consistent in naming style.
3633         (Events.buildFinished): Ditto.
3634
3635 2019-02-27  Chris Dumez  <cdumez@apple.com>
3636
3637         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3638         https://bugs.webkit.org/show_bug.cgi?id=194480
3639
3640         Reviewed by Brady Eidson.
3641
3642         Update existing API test to make it more likely to reproduce the issue.
3643
3644         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3645
3646 2019-02-27  Brady Eidson  <beidson@apple.com>
3647
3648         Universal links from Google search results pages don't open the app.
3649         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3650
3651         Reviewed by Geoffrey Garen.
3652
3653         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3654         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3655         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3656         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3657
3658 2019-02-27  Chris Dumez  <cdumez@apple.com>
3659
3660         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3661         https://bugs.webkit.org/show_bug.cgi?id=195102
3662
3663         Reviewed by Geoffrey Garen.
3664
3665         If the number of processes is not yet what we expect, wait a bit and check again to give
3666         processes some time to exit.
3667
3668         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3669
3670 2019-02-27  Chris Dumez  <cdumez@apple.com>
3671
3672         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3673         https://bugs.webkit.org/show_bug.cgi?id=194545
3674
3675         Reviewed by Brady Eidson.
3676
3677         Make sure the test navigates forward and then back only once. Previously, navigating
3678         back would trigger a navigation again in a timer.
3679
3680         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3681
3682 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3683
3684         High Sierra Debug JSC test queue should use faster hardware
3685         https://bugs.webkit.org/show_bug.cgi?id=194603
3686
3687         Rubber-stamped by Alexey Proskuryakov.
3688
3689         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3690
3691         * BuildSlaveSupport/build.webkit.org-config/config.json:
3692         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3693         (BubbleQueueServer):
3694         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3695         (WebKitBuildbot):
3696         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3697         * QueueStatusServer/config/queues.py:
3698         * Scripts/webkitpy/common/config/ews.json:
3699         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3700         (test_ews_name):
3701
3702 2019-02-27  John Wilander  <wilander@apple.com>
3703
3704         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3705         https://bugs.webkit.org/show_bug.cgi?id=195071
3706         <rdar://problem/48417690>
3707
3708         Reviewed by Alex Christensen and Brent Fulgham.
3709
3710         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3711         (TestWebKitAPI::createURL):
3712             Convenience function.
3713         (TestWebKitAPI::TEST):
3714             WebCore::AdClickAttribution now takes a URL when creating Source and
3715             Destination.
3716         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3717         (TestWebKitAPI::TEST):
3718             WebCore::AdClickAttribution now takes a URL when creating Source and
3719             Destination.
3720
3721 2019-02-27  Antoine Quint  <graouts@apple.com>
3722
3723         Support Pointer Events on macOS
3724         https://bugs.webkit.org/show_bug.cgi?id=195008
3725         <rdar://problem/47454419>
3726
3727         Reviewed by Dean Jackson.
3728
3729         * DumpRenderTree/mac/DumpRenderTree.mm:
3730         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3731         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3732
3733 2019-02-26  Mark Lam  <mark.lam@apple.com>
3734
3735         Remove remaining poisoning code.
3736         https://bugs.webkit.org/show_bug.cgi?id=194138
3737
3738         Reviewed by Saam Barati.
3739
3740         * TestWebKitAPI/CMakeLists.txt:
3741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3742         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3743         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3744         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3745         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3746         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3747         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3748
3749 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3750
3751         Move ephemeral local storage from WebProcess to UIProcess
3752         https://bugs.webkit.org/show_bug.cgi?id=195074
3753         <rdar://problem/47937975>
3754
3755         Reviewed by Geoff Garen.
3756
3757         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3758
3759 2019-02-20  Jer Noble  <jer.noble@apple.com>
3760
3761         [Cocoa] Media elements will restart network buffering just before suspending
3762         https://bugs.webkit.org/show_bug.cgi?id=193691
3763
3764         Reviewed by Eric Carlson.
3765
3766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3767         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3768         (TEST):
3769
3770 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3771
3772         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3773         https://bugs.webkit.org/show_bug.cgi?id=191652
3774
3775         Reviewed by Alex Christensen.
3776
3777         Fix WinCairo MiniBrowser behavior of authentication dialog.
3778
3779         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3780         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3781
3782 2019-02-26  Youenn Fablet  <youenn@apple.com>
3783
3784         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3785         https://bugs.webkit.org/show_bug.cgi?id=195028
3786         <rdar://problem/48243733>
3787
3788         Reviewed by Eric Carlson.
3789
3790         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3791
3792 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3793
3794         [WPE] Add API for webview background color configuration
3795         https://bugs.webkit.org/show_bug.cgi?id=192305
3796
3797         Reviewed by Michael Catanzaro.
3798
3799         * MiniBrowser/wpe/main.cpp:
3800         (main): Add a new option to configure the webview background
3801         color. Example: --bg-color=transparent.
3802         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3803         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3804         (beforeAll): Ditto.
3805
3806 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3807
3808         scalableNativeWebpageParameters() is not preserved on new page navigation.
3809         https://bugs.webkit.org/show_bug.cgi?id=194892
3810         <rdar://problem/47538280>
3811
3812         Reviewed by Wenson Hsieh.
3813         
3814         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3815
3816         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3817         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3818         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3819         (WTR::UIScriptController::allowsViewportShrinkToFit):
3820         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3821         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3822         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3823         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3824         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3825         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3826
3827 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3828
3829         [ews-app] Add model for handling multiple Buildbot instances
3830         https://bugs.webkit.org/show_bug.cgi?id=194863
3831
3832         Reviewed by Stephanie Lewis.
3833
3834         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3835
3836 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3837
3838         [ews-app] Remove BuilderMapping table
3839         https://bugs.webkit.org/show_bug.cgi?id=194961
3840
3841         Reviewed by Stephanie Lewis.
3842
3843         Store builder name directly in build table, instead of having a separate
3844         table for it.
3845
3846         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3847         * BuildSlaveSupport/ews-app/ews/models/build.py:
3848         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3849         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3850
3851 2019-02-25  John Wilander  <wilander@apple.com>
3852
3853         Introduce and adopt new class RegistrableDomain for eTLD+1
3854         https://bugs.webkit.org/show_bug.cgi?id=194791
3855         <rdar://problem/48179240>
3856
3857         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3858
3859         This patch adds an API test and replaces two instances of
3860         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3861
3862         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3863         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3864         (TestWebKitAPI::TEST):
3865             Changed two strings to make sure the registrable domains are still considered
3866             invalid and pass the test.
3867         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3868         (TestWebKitAPI::TEST):
3869         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3870         (WTR::InjectedBundle::didReceiveMessageToPage):
3871
3872 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3873
3874         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3875         https://bugs.webkit.org/show_bug.cgi?id=195001
3876
3877         Reviewed by Carlos Garcia Campos.
3878
3879         API version 1.0 always includes the functionality previously guarded with
3880         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3881         unconditionally.
3882
3883         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3884         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3885         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3886         (WebViewTest::showInWindow): Ditto.
3887         (WebViewTest::hideView): Ditto.
3888         * wpe/backends/HeadlessViewBackend.cpp:
3889         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3890         * wpe/backends/ViewBackend.cpp:
3891         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3892         * wpe/backends/WindowViewBackend.cpp:
3893         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3894         WPE_BACKEND_CHECK_VERSION().
3895         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3896
3897 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3898
3899         [Flatpak] Add support for flatpak > 1.1.2
3900         https://bugs.webkit.org/show_bug.cgi?id=194088
3901
3902         Flatpak 1.2 is now out so we need to support that
3903         version now.
3904
3905         Reviewed by Michael Catanzaro.
3906
3907         * flatpak/flatpakutils.py:
3908         (check_flatpak):
3909         (FlatpakPackages.__init__):
3910         (FlatpakPackages.__detect_packages):
3911         (FlatpakPackages.__detect_packages.in):
3912         (FlatpakRepos.update):
3913
3914 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3915
3916         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3917         https://bugs.webkit.org/show_bug.cgi?id=194998
3918
3919         Reviewed by Carlos Garcia Campos.
3920
3921         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3922         to a Git checkout and using the latest commit containing various fixes
3923         and improvements.
3924
3925 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3926
3927         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3928         https://bugs.webkit.org/show_bug.cgi?id=194981
3929
3930         Reviewed by Žan Doberšek.
3931
3932         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3933         (TestWebKitAPI::TEST):
3934
3935 2019-02-23  Keith Miller  <keith_miller@apple.com>
3936
3937         Add new mac target numbers
3938         https://bugs.webkit.org/show_bug.cgi?id=194955
3939
3940         Reviewed by Tim Horton.
3941
3942         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3943         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3944         * MiniBrowser/Configurations/Base.xcconfig:
3945         * TestWebKitAPI/Configurations/Base.xcconfig:
3946         * WebKitTestRunner/Configurations/Base.xcconfig:
3947
3948 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3949
3950         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3951         https://bugs.webkit.org/show_bug.cgi?id=194846
3952
3953         Reviewed by Don Olmstead.
3954
3955         Added _search_paths() and _port_specific_expectations_files() for
3956         WinCairoPort.
3957
3958         * Scripts/webkitpy/port/win.py:
3959         (WinCairoPort.default_baseline_search_path):
3960         (WinCairoPort):
3961         (WinCairoPort._port_specific_expectations_files):
3962         (WinCairoPort._search_paths):
3963
3964 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3965
3966         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3967         https://bugs.webkit.org/show_bug.cgi?id=194963
3968
3969         Reviewed by Dean Jackson.
3970
3971         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3972         Do a `contains` check instead of `equals`, because in debug builds we
3973         put the GraphicsLayer pointer in a prefix.
3974
3975 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3976
3977         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3978         https://bugs.webkit.org/show_bug.cgi?id=194873
3979         <rdar://problem/46701974>
3980
3981         Reviewed by Tim Horton.
3982
3983         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3984
3985         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3986         (WTR::UIScriptController::menuRect const):
3987         (WTR::UIScriptController::isShowingMenu const):
3988         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3989         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3990         (WTR::UIScriptController::menuRect const):
3991
3992         Add a function to query the bounds of the callout menu in content coordinates.
3993
3994         (WTR::UIScriptController::isShowingMenu const):
3995
3996         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3997
3998         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3999         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4000         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4001         (WTR::UIScriptController::rectForMenuAction const):
4002         (WTR::UIScriptController::menuRect const):
4003         (WTR::UIScriptController::isShowingMenu const):
4004         (WTR::findViewInHierarchyOfType): Deleted.
4005
4006 2019-02-22  Chris Dumez  <cdumez@apple.com>
4007
4008         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4009         https://bugs.webkit.org/show_bug.cgi?id=194954
4010         <rdar://problem/48127957>
4011
4012         Reviewed by Alex Christensen.
4013
4014         Add API test coverage.
4015
4016         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4017         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4018         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4019         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4020
4021 2019-02-22  Chris Dumez  <cdumez@apple.com>
4022
4023         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4024         https://bugs.webkit.org/show_bug.cgi?id=194924
4025         <rdar://problem/48216125>
4026
4027         Reviewed by Geoffrey Garen.
4028
4029         Add API test coverage.
4030
4031         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4032
4033 2019-02-22  Chris Dumez  <cdumez@apple.com>
4034
4035         Unreviewed, disable API test added in r241928 on iOS.
4036
4037         The cache is not enabled on devices with less than 3GB of RAM.
4038
4039         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4040
4041 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4042
4043         Hardcode Visual Viewports on everywhere except iOS WK1
4044         https://bugs.webkit.org/show_bug.cgi?id=194928
4045
4046         Reviewed by Zalan Bujtas.
4047
4048         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4049         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4050         set it to false. The setting has shipped for several years and there's no need to turn
4051         it off now.
4052
4053         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4054         Visual Viewports are not enabled.
4055         
4056         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4057         that only runs in WK2
4058
4059         * MiniBrowser/mac/SettingsController.h:
4060         * MiniBrowser/mac/SettingsController.m:
4061         (-[SettingsController init]):
4062         (-[SettingsController _populateMenu]):
4063         (-[SettingsController validateMenuItem:]):
4064         (-[SettingsController visualViewportEnabled]): Deleted.
4065         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4066         * MiniBrowser/mac/WK1BrowserWindowController.m:
4067         (-[WK1BrowserWindowController didChangeSettings]):
4068         * MiniBrowser/mac/WK2BrowserWindowController.m:
4069         (-[WK2BrowserWindowController didChangeSettings]):
4070
4071 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4072
4073         Discard cached processes when clearing website data store
4074         https://bugs.webkit.org/show_bug.cgi?id=194894
4075
4076         Reviewed by Chris Dumez.
4077
4078         Added a test case.
4079
4080         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4081         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4082
4083 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4084
4085         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4086         https://bugs.webkit.org/show_bug.cgi?id=194914
4087         <rdar://problem/47586889>
4088
4089         Reviewed by Geoffrey Garen.
4090
4091         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4092         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4093         (TEST):
4094         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4095
4096 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4097
4098         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4099         <https://webkit.org/b/194761>
4100
4101         Reviewed by Myles Maxfield.
4102
4103         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4104         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4105         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4106         to use ARC-compliant cast.
4107         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4108         ARC-compliant cast.
4109         (WTR::installFakeHelvetica): Log `error` to console if
4110         CTFontManagerRegisterFontsForURL() fails, but only on supported
4111         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4112         Call CFRelease() on `error` to fix the leak.  Update to use
4113         ARC-compliant cast.
4114         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4115         cast.
4116
4117 2019-02-21  Chris Dumez  <cdumez@apple.com>
4118
4119         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4120         https://bugs.webkit.org/show_bug.cgi?id=194481
4121
4122         Reviewed by Alex Christensen.
4123
4124         Give the processes a chance to shutdown and wait until we reached the expected number
4125         of processes.
4126
4127         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4128
4129 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4130
4131         Fix the macOS build
4132
4133         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4134
4135 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4136
4137         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4138
4139         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4140         I am a backwards.
4141
4142 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4143
4144         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4145
4146         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4147         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4148         We could force on UI-side compositing, but I feel like the test might be more
4149         valuable exercising the normal path on each platform (though the original
4150         bug was also UI-side specific). Though we can't validate that the overlay
4151         layer was installed successfully, there are layout tests that do that.
4152
4153 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4154
4155         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4156         https://bugs.webkit.org/show_bug.cgi?id=194845
4157         <rdar://problem/47944579>
4158
4159         Reviewed by Antti Koivisto.
4160
4161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4162         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4163
4164 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4165
4166         [LFC][Floats] Add support for placing formatting roots in-between floats.
4167         https://bugs.webkit.org/show_bug.cgi?id=194902
4168
4169         Reviewed by Antti Koivisto.
4170
4171         * LayoutReloaded/misc/LFC-passing-tests.txt:
4172
4173 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4174
4175         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4176         https://bugs.webkit.org/show_bug.cgi?id=194901
4177
4178         Unreviewed build fix.
4179
4180         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4181         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4182         WPEBackend-fdo-0.1 as library name.
4183
4184 2019-02-21  Rob Buis  <rbuis@igalia.com>
4185
4186         Update MIME type parser
4187         https://bugs.webkit.org/show_bug.cgi?id=180526
4188
4189         Reviewed by Darin Adler.
4190
4191         Add tests involving leading and trailing whitespace, non-token
4192         characters and quoted strings.
4193
4194         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4195         (TestWebKitAPI::TEST):
4196
4197 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4198
4199         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4200         https://bugs.webkit.org/show_bug.cgi?id=194884
4201
4202         Reviewed by Michael Catanzaro.
4203
4204         * PlatformWin.cmake:
4205
4206 2019-02-20  Chris Dumez  <cdumez@apple.com>
4207
4208         Add API test for <rdar://problem/47471222>
4209         https://bugs.webkit.org/show_bug.cgi?id=194847
4210
4211         Reviewed by Alex Christensen.
4212
4213         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4214
4215 2019-02-20  Chris Dumez  <cdumez@apple.com>
4216
4217         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4218         https://bugs.webkit.org/show_bug.cgi?id=194872
4219         <rdar://problem/47924500>
4220
4221         Reviewed by Alex Christensen.
4222
4223         Add API test coverage.
4224
4225         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4226
4227 2019-02-20  Jer Noble  <jer.noble@apple.com>
4228
4229         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4230         https://bugs.webkit.org/show_bug.cgi?id=191332
4231
4232         Reviewed by Dean Jackson.
4233
4234         * Scripts/git-is-in-range: Added.
4235
4236 2019-02-20  Andy Estes  <aestes@apple.com>
4237
4238         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4239         https://bugs.webkit.org/show_bug.cgi?id=194869
4240
4241         Rubber-stamped by Jer Noble.
4242
4243         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4244         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4245         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4246         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4248         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4249
4250 2019-02-20  Chris Dumez  <cdumez@apple.com>
4251
4252         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4253         https://bugs.webkit.org/show_bug.cgi?id=194857
4254         <rdar://problem/47759323>
4255
4256         Reviewed by Alex Christensen.
4257
4258         Add API test coverage.
4259
4260         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4261
4262 2019-02-20  Chris Dumez  <cdumez@apple.com>
4263
4264         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4265         https://bugs.webkit.org/show_bug.cgi?id=194829
4266         <rdar://problem/47889906>
4267
4268         Reviewed by Alexey Proskuryakov.
4269
4270         Every time the TestOptions were changing we were creating both a new Web view and
4271         a new WKContext, which would start a new Network process. In most cases, we only
4272         need to contruct a new Web view and we do can keep reusing the same WKContext.
4273         This patch implements this optimization and thus avoids spinning a lot of new
4274         Network processes while running the layout tests.
4275
4276         * WebKitTestRunner/TestController.cpp:
4277         (WTR::TestController::generateContextConfiguration const):
4278         (WTR::TestController::generatePageConfiguration):
4279         (WTR::TestController::createWebViewWithOptions):
4280         (WTR::TestController::resetPreferencesToConsistentValues):
4281         (WTR::updateTestOptionsFromTestHeader):
4282         * WebKitTestRunner/TestController.h:
4283         * WebKitTestRunner/TestOptions.h:
4284         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4285         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4286         (WTR::TestOptions::hasSameInitializationOptions const):
4287         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4288         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4289         (WTR::TestController::platformAddTestOptions const):
4290
4291 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4292
4293         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4294         https://bugs.webkit.org/show_bug.cgi?id=167941
4295
4296         Reviewed by Carlos Garcia Campos.
4297
4298         * MiniBrowser/gtk/main.c:
4299         (filterSavedCallback): Added.
4300         (main): Support loading a JSON rule set file for content filtering.
4301         * MiniBrowser/wpe/main.cpp:
4302         (filterSavedCallback): Added.
4303         (main): Support loading a JSON rule set file for content filtering.
4304         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4305         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4306         (WTF::derefGPtr): Ditto.
4307         (testEmptyStore):
4308         (testSaveInvalidFilter):
4309         (testSaveLoadFilter):
4310         (testSavedFilterIdentifierMatch):
4311         (testRemoveFilter):
4312         (testSaveMultipleFilters):
4313         (testSaveFilterFromFile):
4314         (testFilterPersistence):
4315         (beforeAll):
4316         (afterAll):
4317         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4318         (removeOldInjectedContentAndResetLists): Also reset content filters.
4319         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4320         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4321         the element affected by the style sheet.
4322         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4323         and returns it to be used by tests.
4324         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4325         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4326         (serverCallback): Add support for serving a CSS style sheet for testing.
4327         (beforeAll): Add call to testUserContentManagerContentFilter().
4328         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4329
4330 2019-02-19  Keith Rollin  <krollin@apple.com>
4331
4332         Add timing information to build output
4333         https://bugs.webkit.org/show_bug.cgi?id=194839
4334         <rdar://problem/48219609>
4335
4336         Reviewed by Alexey Proskuryakov.
4337
4338         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4339         emit each project's build time to its output. E.g.,
4340
4341             ** BUILD SUCCEEDED ** [0.132 sec]
4342
4343         * Scripts/webkitdirs.pm:
4344         (XcodeOptions):
4345
4346 2019-02-19  Truitt Savell  <tsavell@apple.com>
4347
4348         Unreviewed, rolling out r241784.
4349
4350         Broke all OpenSource builds.
4351
4352         Reverted changeset:
4353
4354         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4355         instances view"
4356         https://bugs.webkit.org/show_bug.cgi?id=172848
4357         https://trac.webkit.org/changeset/241784
4358
4359 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4360
4361         [LFC][Floats] Remove redundant intersecting logic
4362         https://bugs.webkit.org/show_bug.cgi?id=194804
4363
4364         Reviewed by Antti Koivisto.
4365
4366