Define media buffering policy
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
2
3         Define media buffering policy
4         https://bugs.webkit.org/show_bug.cgi?id=196979
5         <rdar://problem/28383861>
6
7         Reviewed by Jer Noble.
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
11         (waitUntilBufferingPolicyIsEqualTo):
12         (TEST):
13
14 2019-05-07  Alex Christensen  <achristensen@webkit.org>
15
16         Add SPI to set a list of hosts to which to send custom header fields cross-origin
17         https://bugs.webkit.org/show_bug.cgi?id=197397
18
19         Reviewed by Geoff Garen.
20
21         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
22         (TEST):
23         (expectLegacyHeaders):
24         (expectHeaders):
25         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
26         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
27         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
28
29 2019-05-07  Keith Rollin  <krollin@apple.com>
30
31         Add option to build-webkit to control whether or not XCBuild is used
32         https://bugs.webkit.org/show_bug.cgi?id=197668
33         <rdar://problem/50549728>
34
35         Reviewed by Tim Horton.
36
37         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
38         Also update build-webkit and the makefiles with the foundation for
39         automatically using XCBuild when the conditions allow it. This latter
40         facility is currently turned off until Xcode fully supports building
41         WebKit with XCBuild.
42
43         * Scripts/build-webkit:
44         * Scripts/webkitdirs.pm:
45         (XcodeOptions):
46         (canUseXCBuild):
47
48 2019-05-07  Andy Estes  <aestes@apple.com>
49
50         run-bindings-tests should test global scope constructor generation
51         https://bugs.webkit.org/show_bug.cgi?id=197669
52
53         Reviewed by Alex Christensen.
54
55         * Scripts/webkitpy/bindings/main.py:
56         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
57         invoking preprocess-idls.pl.
58
59 2019-05-07  Youenn Fablet  <youenn@apple.com>
60
61         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
62         https://bugs.webkit.org/show_bug.cgi?id=195997
63         <rdar://problem/50509884>
64
65         Reviewed by Chris Dumez.
66
67         Spin test until successful.
68
69         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
70
71 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
72
73         [Flatpak] webkit-build fails due to missing GTK2 in build environment
74         https://bugs.webkit.org/show_bug.cgi?id=197352
75
76         Reviewed by Philippe Normand.
77
78         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
79         to build it ourselves on top in order to be able to build the GTK 2.x plugin
80         process.
81
82         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
83
84 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
85
86         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
87         https://bugs.webkit.org/show_bug.cgi?id=197644
88         <rdar://problem/50526364>
89
90         Reviewed by Tim Horton.
91
92         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
93
94         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
95         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
96         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
97         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
98
99 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
100
101         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
102         https://bugs.webkit.org/show_bug.cgi?id=197651
103
104         Reviewed by Žan Doberšek.
105
106         This is required since the process creation was delayed until something is loaded in the view.
107
108         * MiniBrowser/gtk/BrowserWindow.c:
109         (browser_window_get_or_create_web_view_for_automation):
110         * MiniBrowser/wpe/main.cpp:
111         (main):
112
113 2019-05-06  Tim Horton  <timothy_horton@apple.com>
114
115         _overrideViewportWithArguments does not work when called before loading
116         https://bugs.webkit.org/show_bug.cgi?id=197638
117         <rdar://problem/50505111>
118
119         Reviewed by Wenson Hsieh.
120
121         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
122         (TEST):
123
124 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
125
126         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
127         https://bugs.webkit.org/show_bug.cgi?id=197510
128
129         Reviewed by Alex Christensen.
130
131         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
132         (TestWebKitAPI::TEST):
133
134 2019-05-06  Keith Rollin  <krollin@apple.com>
135
136         Temporarily disable generate-xcfilelists
137         https://bugs.webkit.org/show_bug.cgi?id=197619
138         <rdar://problem/50507392>
139
140         Reviewed by Alex Christensen.
141
142         We need to perform a significant update to the generate-xcfilelist
143         scripts. This work involves coordinated work with another facility. If
144         the work does not occur in tandem, the build will be broken. To avoid
145         this, disable the invoking of the scripts during the transition. The
146         checking will be restored once the new scripts are in place.
147
148         * DumpRenderTree/Scripts/check-xcfilelists.sh:
149         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
150
151 2019-05-04  Alex Christensen  <achristensen@webkit.org>
152
153         Revert r244953 and r244954 because they broke internal builds.
154         https://bugs.webkit.org/show_bug.cgi?id=197534
155
156         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
157         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
158         * DumpRenderTree/mac/DumpRenderTree.mm:
159         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
160         * DumpRenderTree/mac/TestRunnerMac.mm:
161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
162         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
163         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
164         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
165         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
166         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
167         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
168         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
169         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
170         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
171         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
172         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
173         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
174         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
175         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
176         * TestWebKitAPI/cocoa/TestWKWebView.mm:
177         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
178         * TestWebKitAPI/ios/UIKitSPI.h: Added.
179         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
180         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
181         * WebKitTestRunner/ios/HIDEventGenerator.h:
182         * WebKitTestRunner/ios/HIDEventGenerator.mm:
183         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
184         * WebKitTestRunner/ios/TestControllerIOS.mm:
185         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
186         * WebKitTestRunner/ios/mainIOS.mm:
187
188 2019-05-04  Alex Christensen  <achristensen@webkit.org>
189
190         Merge the three UIKitSPI.h files into a single one in PAL
191         https://bugs.webkit.org/show_bug.cgi?id=197534
192
193         Reviewed by Darin Adler.
194
195         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
196         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
197         * DumpRenderTree/mac/DumpRenderTree.mm:
198         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
199         * DumpRenderTree/mac/TestRunnerMac.mm:
200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
201         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
202         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
203         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
204         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
205         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
206         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
207         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
208         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
209         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
210         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
211         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
212         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
213         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
214         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
215         * TestWebKitAPI/cocoa/TestWKWebView.mm:
216         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
217         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
218         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
219         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
220         * WebKitTestRunner/ios/HIDEventGenerator.h:
221         * WebKitTestRunner/ios/HIDEventGenerator.mm:
222         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
223         * WebKitTestRunner/ios/TestControllerIOS.mm:
224         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
225         * WebKitTestRunner/ios/mainIOS.mm:
226
227 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
228
229         Web Inspector: Provide UIString descriptions to improve localizations
230         https://bugs.webkit.org/show_bug.cgi?id=195132
231         <rdar://problem/48457817>
232
233         Reviewed by Devin Rousso.
234
235         Allow WI.UIString to take:
236         - WI.UIString(string, key, comment)
237         - WI.UIString(string, comment)
238         - WI.UIString(string)
239
240         * Scripts/extract-localizable-js-strings:
241
242 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
243
244         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
245         https://bugs.webkit.org/show_bug.cgi?id=197579
246
247         Reviewed by Tim Horton.
248
249         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
250         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
251         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
252         ensure that the the focused element has been blurred.
253
254         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
255
256 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
257
258         Add a tool to block spammer accounts
259         https://bugs.webkit.org/show_bug.cgi?id=197537
260
261         Reviewed by Darin Adler.
262
263         Usage: block-spammers email1 email2 ...
264
265         The tool finds and hides all bugs and comments from this account. Before any work
266         is done, these bugs and comments are displayed for confirmation.
267
268         * Scripts/block-spammers: Added.
269         (get_bugzilla_token):
270         (invalidate_bugzilla_token):
271         (get_user_info):
272         (get_user_info_self):
273         (can_use_this_tool):
274         (disable_user):
275         (get_bugs_created_by_user):
276         (get_bugs_commented_on_by_user):
277         (get_comments):
278         (hide_bug):
279         (hide_comments):
280         (ask_yes_no):
281         (sanitized_string):
282         (main):
283
284 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
285
286         run-apit-tests: Add --iterations and --repeat-each
287         https://bugs.webkit.org/show_bug.cgi?id=197563
288
289         Reviewed by Aakash Jain.
290
291         * Scripts/webkitpy/api_tests/manager.py:
292         (Manager.run): Add --iterations and --repeat-each/
293         * Scripts/webkitpy/api_tests/run_api_tests.py:
294         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
295
296 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
297
298         New EWS: Clicking on white bubble navigates to page with only bubbles
299         https://bugs.webkit.org/show_bug.cgi?id=197520
300
301         Reviewed by Lucas Forschler.
302
303         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
304
305 2019-05-03  Daniel Bates  <dabates@apple.com>
306
307         [lldb-webkit] Support adding pretty-printing for qualified types
308         https://bugs.webkit.org/show_bug.cgi?id=197518
309
310         Reviewed by Darin Adler.
311
312         Remove all "::"s from the name of the specified type when computing the name for the Python classes
313         that will provide summary and synthetic details as LLDB is not happy about registering such classes
314         when they contain :: in their name.
315
316         * lldb/lldb_webkit.py:
317         (addSummaryAndSyntheticFormattersForRawBitmaskType):
318
319 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
320
321         New EWS: patches on recently added queues listed as #1 for older bugs
322         https://bugs.webkit.org/show_bug.cgi?id=197496
323
324         Reviewed by Lucas Forschler.
325
326         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
327         (StatusBubble._build_bubble):
328         (StatusBubble._queue_position):
329
330 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
331
332         webkit-patch --no-review upload does not submit patch to New EWS
333         https://bugs.webkit.org/show_bug.cgi?id=197519
334         <rdar://problem/50424887>
335
336         Reviewed by Lucas Forschler.
337
338         * Scripts/webkitpy/tool/steps/submittoews.py:
339         (SubmitToEWS.run): Submit to both old and new EWS.
340         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
341         * Scripts/webkitpy/common/net/ewsserver.py: Added.
342         (EWSServer._server_url): Method to return server url.
343         (EWSServer._post_patch_to_ews): Method to post patch to ews.
344         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
345         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
346         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
347         * Scripts/webkitpy/common/net/statusserver_mock.py:
348         (MockStatusServer.submit_to_ews): Updated the log text.
349         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
350         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
351         * Scripts/webkitpy/tool/main.py:
352         (WebKitPatch.__init__): Initialize ews_server. 
353         * Scripts/webkitpy/tool/mocktool.py:
354         (MockTool.__init__): Ditto.
355
356 2019-05-03  Chris Dumez  <cdumez@apple.com>
357
358         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
359         https://bugs.webkit.org/show_bug.cgi?id=197574
360         <rdar://problem/50453181>
361
362         Reviewed by Tim Horton.
363
364         Add API test coverage.
365
366         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
367         (TEST):
368
369 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
370
371         [JSC] Generator CodeBlock generation should be idempotent
372         https://bugs.webkit.org/show_bug.cgi?id=197552
373
374         Reviewed by Keith Miller.
375
376         * Scripts/run-javascriptcore-tests:
377         (runJSCStressTests):
378         * Scripts/run-jsc-stress-tests:
379
380 2019-05-03  Commit Queue  <commit-queue@webkit.org>
381
382         Unreviewed, rolling out r244881.
383         https://bugs.webkit.org/show_bug.cgi?id=197559
384
385         Breaks compilation of jsconly on linux, breaking compilation
386         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
387         guijemont on #webkit).
388
389         Reverted changeset:
390
391         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
392         WEBKIT_COPY_FILES"
393         https://bugs.webkit.org/show_bug.cgi?id=197174
394         https://trac.webkit.org/changeset/244881
395
396 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
397
398         Unreviewed WPE build fix after r244898.
399
400         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
401         (WTR::TestController::abortModal): Add the missing (no-op) definition.
402
403 2019-05-02  Alex Christensen  <achristensen@webkit.org>
404
405         Mark U+01C0 as a homograph of U+006C
406         https://bugs.webkit.org/show_bug.cgi?id=197526
407         <rdar://problem/50301904>
408
409         Reviewed by Tim Horton.
410
411         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
412         (TestWebKitAPI::TEST):
413
414 2019-05-02  Chris Dumez  <cdumez@apple.com>
415
416         Add test coverage for <rdar://problem/49731231>
417         https://bugs.webkit.org/show_bug.cgi?id=196730
418         <rdar://problem/49731231>
419
420         Reviewed by Ryosuke Niwa.
421
422         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
423         to match DumpRenderTree.
424
425         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
426         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
427         (WTR::TestRunner::abortModal):
428         * WebKitTestRunner/InjectedBundle/TestRunner.h:
429         * WebKitTestRunner/TestController.cpp:
430         (WTR::TestController::runModal):
431         * WebKitTestRunner/TestController.h:
432         * WebKitTestRunner/TestInvocation.cpp:
433         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
434         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
435         (WTR::TestController::abortModal):
436         * WebKitTestRunner/ios/TestControllerIOS.mm:
437         (WTR::TestController::abortModal):
438         * WebKitTestRunner/mac/TestControllerMac.mm:
439         (WTR::TestController::abortModal):
440         * WebKitTestRunner/win/TestControllerWin.cpp:
441         (WTR::TestController::abortModal):
442
443 2019-05-02  Christopher Reid  <chris.reid@sony.com>
444
445         [CMake] Add support for LTO builds
446         https://bugs.webkit.org/show_bug.cgi?id=188986
447
448         Reviewed by Don Olmstead.
449
450         Add support to configure --lto-mode with cmake builds.
451
452         * Scripts/build-webkit:
453         * Scripts/webkitdirs.pm:
454         (generateBuildSystemFromCMakeProject):
455
456 2019-05-02  John Wilander  <wilander@apple.com>
457
458         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
459         https://bugs.webkit.org/show_bug.cgi?id=197521
460         <rdar://problem/49651503>
461
462         Reviewed by Brent Fulgham.
463
464         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
465         (TestWebKitAPI::TEST):
466            Added a test for host strings with leading dots since they are
467            often used for the domain attribute in cookies.
468
469 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
470
471         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
472         https://bugs.webkit.org/show_bug.cgi?id=197510
473
474         Reviewed by Alex Christensen.
475
476         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
477         (TestWebKitAPI::TEST):
478
479 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
480
481         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
482         https://bugs.webkit.org/show_bug.cgi?id=197174
483
484         Reviewed by Alex Christensen.
485
486         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
487
488         * TestWebKitAPI/PlatformGTK.cmake:
489         * TestWebKitAPI/PlatformWPE.cmake:
490
491 2019-05-02  Alex Christensen  <achristensen@webkit.org>
492
493         Build fix for internal branch.
494
495         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
496         RetainPtr.h was not explicitly included.
497
498 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
499
500         webkitpy: Ignore errors when shutting down an already shutdown simulator
501         <https://bugs.webkit.org/show_bug.cgi?id=197514>
502         <rdar://problem/50390247>
503
504         Reviewed by Lucas Forschler.
505
506         * Scripts/webkitpy/xcode/simulated_device.py:
507         (SimulatedDevice._shut_down):
508
509 2019-05-02  Frederic Wang  <fwang@igalia.com>
510
511         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
512         https://bugs.webkit.org/show_bug.cgi?id=196142
513
514         This patch introduces some experimental runtime flag to let users
515         disable MathML features that are removed from MathML Core [1]. For now,
516         these features are only disabled on GTK and WPE ports.
517
518         [1] https://mathml-refresh.github.io/mathml-core/
519
520         Reviewed by Rob Buis.
521
522         * DumpRenderTree/TestOptions.cpp:
523         (TestOptions::TestOptions):
524         * DumpRenderTree/TestOptions.h:
525         * DumpRenderTree/mac/DumpRenderTree.mm:
526         (setWebPreferencesForTestOptions):
527
528 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
529
530         TestWebKitAPI config.h should be aware of what suite is being built
531         https://bugs.webkit.org/show_bug.cgi?id=196583
532
533         Reviewed by Konstantin Tokarev.
534
535         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
536         benefit the macro defines BUILDING_* for the executable which allows the includes
537         of the config.h to be tailored to the test suite being built. Because of that the
538         dependencies of the Test* executable are specific to the test suite which may
539         speed up the build.
540
541         Some source files were including "PlatformUtilities.h" which includes WebKit headers
542         when "Utilities.h" is what was needed.
543
544         * TestWebKitAPI/CMakeLists.txt:
545         * TestWebKitAPI/PlatformGTK.cmake:
546         * TestWebKitAPI/PlatformJSCOnly.cmake:
547         * TestWebKitAPI/PlatformMac.cmake:
548         * TestWebKitAPI/PlatformPlayStation.cmake:
549         * TestWebKitAPI/PlatformUtilities.h:
550         * TestWebKitAPI/PlatformWPE.cmake:
551         * TestWebKitAPI/PlatformWin.cmake:
552         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
553         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
554         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
555         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
556         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
557         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
558         * TestWebKitAPI/config.h:
559
560 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
561
562         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
563         https://bugs.webkit.org/show_bug.cgi?id=181950
564         <rdar://problem/43357371>
565
566         Reviewed by Brent Fulgham.
567
568         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
569         (TestWebKitAPI::TEST_F):
570
571 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
572
573         Remove webkitpy and bindings EWS queues from dashboard
574         https://bugs.webkit.org/show_bug.cgi?id=197475
575
576         Reviewed by Alexey Proskuryakov.
577
578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
579
580 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
581
582         Remove webkitpy and bindings test queues from old EWS
583         https://bugs.webkit.org/show_bug.cgi?id=197468
584
585         Reviewed by Alexey Proskuryakov.
586
587         * QueueStatusServer/config/queues.py:
588
589 2019-04-30  Tim Horton  <timothy_horton@apple.com>
590
591         Fix the WebKitTestRunner build
592         https://bugs.webkit.org/show_bug.cgi?id=197449
593         <rdar://problem/50334169>
594
595         Reviewed by Alexey Proskuryakov.
596
597         * WebKitTestRunner/mac/EventSenderProxy.mm:
598         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
599         (WTR::EventSenderProxy::mouseForceChanged):
600         Use some SPI instead of IPI.
601
602 2019-04-30  Chris Dumez  <cdumez@apple.com>
603
604         Regression(PSON) URL scheme handlers can no longer respond asynchronously
605         https://bugs.webkit.org/show_bug.cgi?id=197426
606         <rdar://problem/50256169>
607
608         Reviewed by Brady Eidson.
609
610         Add API test coverage.
611
612         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
613         (-[PSONScheme setShouldRespondAsynchronously:]):
614         (-[PSONScheme webView:startURLSchemeTask:]):
615         (-[PSONScheme webView:stopURLSchemeTask:]):
616
617 2019-04-30  Chris Dumez  <cdumez@apple.com>
618
619         Unreviewed, rolling out r244802.
620
621         Caused an API test failure
622
623         Reverted changeset:
624
625         "Regression(PSON) URL scheme handlers can no longer respond
626         asynchronously"
627         https://bugs.webkit.org/show_bug.cgi?id=197426
628         https://trac.webkit.org/changeset/244802
629
630 2019-04-30  Chris Dumez  <cdumez@apple.com>
631
632         Regression(PSON) URL scheme handlers can no longer respond asynchronously
633         https://bugs.webkit.org/show_bug.cgi?id=197426
634         <rdar://problem/50256169>
635
636         Reviewed by Brady Eidson.
637
638         Add API test coverage.
639
640         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
641         (-[PSONScheme setShouldRespondAsynchronously:]):
642         (-[PSONScheme webView:startURLSchemeTask:]):
643         (-[PSONScheme webView:stopURLSchemeTask:]):
644
645 2019-04-30  Chris Dumez  <cdumez@apple.com>
646
647         Only use a related page's process if that page has not been closed yet
648         https://bugs.webkit.org/show_bug.cgi?id=197393
649         <rdar://problem/50302423>
650
651         Reviewed by Tim Horton.
652
653         Add API test coverage.
654
655         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
656
657 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
658
659         [ews-build] Enable Bindings tests queue on new EWS
660         https://bugs.webkit.org/show_bug.cgi?id=197424
661
662         Reviewed by Lucas Forschler.
663
664         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
665         (StatusBubble):
666         * BuildSlaveSupport/ews-build/config.json:
667
668 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
669
670         [ews-build] Configure ews151 for running various tests
671         https://bugs.webkit.org/show_bug.cgi?id=197419
672
673         Reviewed by Lucas Forschler.
674
675         * BuildSlaveSupport/ews-build/config.json:
676
677 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
678
679         [ews-build] Parse and display bindings test failures
680         https://bugs.webkit.org/show_bug.cgi?id=197423
681
682         Reviewed by Lucas Forschler.
683
684         * BuildSlaveSupport/ews-build/steps.py:
685         (RunBindingsTests.__init__): Set timeout of 5 minutes.
686         (RunBindingsTests.start): Initialize log_observer for json output.
687         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
688         (RunBindingsTests._addToLog): Method to add message to log.
689         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
690
691 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
692
693         Unreviewed. Add myself as a committer.
694
695         * Scripts/webkitpy/common/config/contributors.json:
696
697 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
698
699         [ews-build] Enable webkitpy queue on new EWS
700         https://bugs.webkit.org/show_bug.cgi?id=197396
701
702         Reviewed by Lucas Forschler.
703
704         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
705         (StatusBubble):
706         * BuildSlaveSupport/ews-build/config.json:
707
708 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
709
710         [ews-build] Parse and display webkitpy failures
711         https://bugs.webkit.org/show_bug.cgi?id=197395
712
713         Reviewed by Lucas Forschler.
714
715         * BuildSlaveSupport/ews-build/steps.py:
716         (RunWebKitPyTests.start): Initialize log_observer for json output.
717         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
718         (RunWebKitPyTests._addToLog): Method to add message to log.
719         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
720
721 2019-04-29  Alex Christensen  <achristensen@webkit.org>
722
723         <rdar://problem/50299396> Fix internal High Sierra build
724         https://bugs.webkit.org/show_bug.cgi?id=197388
725
726         * DumpRenderTree/mac/Configurations/Base.xcconfig:
727         * MiniBrowser/Configurations/Base.xcconfig:
728         * MobileMiniBrowser/Configurations/Base.xcconfig:
729         * TestWebKitAPI/Configurations/Base.xcconfig:
730         * WebKitTestRunner/Configurations/Base.xcconfig:
731
732 2019-04-29  Youenn Fablet  <youenn@apple.com>
733
734         Remove spurious GVA printf logging
735         https://bugs.webkit.org/show_bug.cgi?id=197368
736         <rdar://problem/35975256>
737
738         Reviewed by Alexey Proskuryakov.
739
740         * Scripts/webkitpy/port/mac.py:
741         (MacPort.logging_patterns_to_strip):
742
743 2019-04-29  Youenn Fablet  <youenn@apple.com>
744
745         getDisplayMedia should be called on user gesture
746         https://bugs.webkit.org/show_bug.cgi?id=197356
747         <rdar://problem/50296074>
748
749         Reviewed by Eric Carlson.
750
751         Update test configuration to inject internals
752         so that we can use it to simulate a user click to call getDisplayMedia.
753
754         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
755         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
756         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
757
758 2019-04-26  Stephanie Lewis  <slewis@apple.com>
759
760         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
761         https://bugs.webkit.org/show_bug.cgi?id=197339
762
763         Reviewed by Dewei Zhu.
764
765         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
766         test run for setup steps that are too expensive to do every iteration.
767
768         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
769         (BenchmarkRunner._run_benchmark):
770         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
771         (BrowserDriver):
772         (BrowserDriver.prepare_initial_env):
773         (BrowserDriver.restore_env_after_all_testing):
774         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
775         (LinuxBrowserDriver.prepare_initial_env):
776         (LinuxBrowserDriver.restore_env_after_all_testing):
777         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
778         (OSXBrowserDriver.prepare_initial_env):
779         (OSXBrowserDriver.restore_env_after_all_testing):
780
781 2019-04-28  Andy Estes  <aestes@apple.com>
782
783         Fix the watchOS engineering build.
784
785         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
786         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
787
788 2019-04-27  Chris Dumez  <cdumez@apple.com>
789
790         [WKTR] Move test timeout handling to the UIProcess
791         https://bugs.webkit.org/show_bug.cgi?id=197333
792
793         Reviewed by Darin Adler.
794
795         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
796         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
797         every WebContent process in the case of swapping.
798
799         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
800         would lead to crashes when firing the timer.
801
802         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
803         (WTR::InjectedBundle::didReceiveMessageToPage):
804         (WTR::InjectedBundle::done):
805         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
806         (WTR::InjectedBundle::shouldDumpPixels const):
807         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
808         (WTR::TestRunner::TestRunner):
809         (WTR::TestRunner::waitUntilDone):
810         (WTR::TestRunner::setWaitUntilDone):
811         * WebKitTestRunner/InjectedBundle/TestRunner.h:
812         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
813         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
814         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
815         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
816         * WebKitTestRunner/TestInvocation.cpp:
817         (WTR::TestInvocation::TestInvocation):
818         (WTR::TestInvocation::createTestSettingsDictionary):
819         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
820         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
821         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
822         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
823         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
824         (WTR::TestInvocation::setWaitUntilDone):
825         (WTR::TestInvocation::done):
826         * WebKitTestRunner/TestInvocation.h:
827
828 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
829
830         [JSC] linkPolymorphicCall now does GC
831         https://bugs.webkit.org/show_bug.cgi?id=197306
832
833         Reviewed by Saam Barati.
834
835         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
836         To add this test, we add `runWithoutBaseOption`.
837
838         * Scripts/run-jsc-stress-tests:
839
840 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
841
842         Update inactive reviewers' status to 'contributor'.
843
844         Accidentally skipped one at first.
845
846         * Scripts/webkitpy/common/config/contributors.json:
847
848 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
849
850         Update inactive reviewers' status to 'contributor'.
851
852         * Scripts/webkitpy/common/config/contributors.json: The change.
853
854         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
855         * Scripts/webkitpy/common/checkout/checkout_mock.py:
856         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
857         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
858         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
859         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
860         * Scripts/webkitpy/tool/commands/queries_unittest.py:
861         * Scripts/webkitpy/tool/commands/upload_unittest.py:
862         Sadly, regression tests operate on a crazy mix of mock and live data for
863         contributors.json. It would be a substantial project to mock all code paths,
864         so changing the tests instead.
865
866 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
867
868         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
869         https://bugs.webkit.org/show_bug.cgi?id=197171
870         <rdar://problem/47454979>
871
872         Reviewed by Youenn Fablet.
873
874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
875         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
876         (TestWebKitAPI::TEST):
877
878 2019-04-26  David Kilzer  <ddkilzer@apple.com>
879
880         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
881         <https://webkit.org/b/197314>
882         <rdar://problem/50245252>
883
884         Reviewed by Simon Fraser.
885
886         * WebKitTestRunner/UIScriptControllerCocoa.mm:
887         (WTR::UIScriptController::lastUndoLabel const):
888         (WTR::UIScriptController::firstRedoLabel const):
889         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
890
891         * WebKitTestRunner/ios/HIDEventGenerator.mm:
892         (-[HIDEventGenerator sendEventStream:completionBlock:]):
893         - Call -autorelease to fix leak of NSDictionary.
894
895         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
896         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
897         (WTR::UIScriptController::selectFormPopoverTitle const):
898         (WTR::UIScriptController::textContentType const):
899         (WTR::UIScriptController::formInputLabel const):
900         (WTR::UIScriptController::scrollingTreeAsText const):
901         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
902
903 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
904
905         webkitpy: Running a single test will always use the default device
906         https://bugs.webkit.org/show_bug.cgi?id=195472
907         <rdar://problem/48724825>
908
909         Reviewed by Lucas Forschler.
910
911         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
912         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
913         requested will be run regardless of what shard they are in.
914
915         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
916         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
917         * Scripts/webkitpy/layout_tests/controllers/manager.py:
918         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
919         on the default device type.
920         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
921         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
922         (RunTest.test_run_part): Ditto.
923
924 2019-04-26  Alex Christensen  <achristensen@webkit.org>
925
926         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
927         https://bugs.webkit.org/show_bug.cgi?id=197165
928
929         Reviewed by Youenn Fablet.
930
931         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
932
933 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
934
935         Replace iOS build queue hardware
936         https://bugs.webkit.org/show_bug.cgi?id=197312
937
938         Reviewed by Aakash Jain.
939
940         * BuildSlaveSupport/build.webkit.org-config/config.json:
941         Use newer hardware that supports macOS Mojave.
942
943 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
944
945         check-webkit-style complains the first block in while loop.
946         https://bugs.webkit.org/show_bug.cgi?id=197307
947
948         The style checker shouldn't complain about an open brace on
949         its own line if the last non-whitespace character on the previous
950         non-blank line is another open brace, because it's likely to
951         indicate the begining of a nested code block.
952
953         Reviewed by Alex Christensen.
954
955         * Scripts/webkitpy/style/checkers/cpp.py:
956         (check_braces):
957         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
958         (WebKitStyleTest.test_braces):
959
960 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
961
962         Stop IDB transactions to release locked database files when network process is ready to suspend
963         https://bugs.webkit.org/show_bug.cgi?id=196372
964         <rdar://problem/48930116>
965
966         Reviewed by Brady Eidson.
967
968         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
969         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
970         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
971         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
972         (runTestAndCheckResult):
973         (keepNetworkProcessActive):
974         (TEST):
975
976 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
977
978         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
979         https://bugs.webkit.org/show_bug.cgi?id=188357
980         <rdar://problem/42986633>
981
982         Reviewed by Dean Jackson.
983
984         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
985         tests would fall into low memory mode and have different behavior.
986         
987         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
988         to Internals, so it's shared by DRT and WTR.
989         
990         We no longer need the WK2 C SPI glue.
991
992         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
993         (WTR::InjectedBundlePage::prepare):
994
995 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
996
997         webkitpy: Including skipped tests in the final count
998         https://bugs.webkit.org/show_bug.cgi?id=197298
999         <rdar://problem/49705424>
1000
1001         Reviewed by Lucas Forschler.
1002
1003         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1004         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
1005
1006 2019-04-25  Timothy Hatcher  <timothy@apple.com>
1007
1008         Disable date and time inputs on iOSMac.
1009         https://bugs.webkit.org/show_bug.cgi?id=197287
1010         rdar://problem/46794376
1011
1012         Reviewed by Wenson Hsieh.
1013
1014         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1015
1016 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1017
1018         Fix test-webkitpy after r244653
1019         https://bugs.webkit.org/show_bug.cgi?id=197131
1020
1021         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1022         Also use C++17.
1023
1024 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
1025
1026         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
1027         https://bugs.webkit.org/show_bug.cgi?id=196991
1028         <rdar://problem/45507423>
1029
1030         Reviewed by Alex Christensen.
1031
1032         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1033         (-[NavigationTestDelegate init]):
1034         (-[NavigationTestDelegate waitForDidFinishNavigation]):
1035         (-[NavigationTestDelegate webView:didFinishNavigation:]):
1036         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1037         (TestWebKitAPI::TEST):
1038         (TEST): Deleted.
1039
1040 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1041
1042         Revert some code accidentally committed with r244653
1043         https://bugs.webkit.org/show_bug.cgi?id=197131
1044
1045         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1046         (TestWebKitAPI::TEST):
1047
1048 2019-04-25  Alex Christensen  <achristensen@webkit.org>
1049
1050         Start using C++17
1051         https://bugs.webkit.org/show_bug.cgi?id=197131
1052
1053         Reviewed by Darin Adler.
1054
1055         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1056         * MiniBrowser/Configurations/Base.xcconfig:
1057         * MobileMiniBrowser/Configurations/Base.xcconfig:
1058         * TestWebKitAPI/Configurations/Base.xcconfig:
1059         * WebKitTestRunner/Configurations/Base.xcconfig:
1060
1061 2019-04-25  Commit Queue  <commit-queue@webkit.org>
1062
1063         Unreviewed, rolling out r244627.
1064         https://bugs.webkit.org/show_bug.cgi?id=197282
1065
1066         Causing internal build failures (Requested by ShawnRoberts on
1067         #webkit).
1068
1069         Reverted changeset:
1070
1071         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1072         https://bugs.webkit.org/show_bug.cgi?id=197171
1073         https://trac.webkit.org/changeset/244627
1074
1075 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1076
1077         [GTK] Hardcoded text color in input fields
1078         https://bugs.webkit.org/show_bug.cgi?id=126907
1079
1080         Reviewed by Michael Catanzaro.
1081
1082         Add dark-mode command line option to MiniBrowser.
1083
1084         * MiniBrowser/gtk/main.c:
1085         (main):
1086
1087 2019-04-24  Zalan Bujtas  <zalan@apple.com>
1088
1089         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1090         https://bugs.webkit.org/show_bug.cgi?id=196948
1091         <rdar://problem/49927131>
1092
1093         Reviewed by Tim Horton.
1094
1095         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1096         (TEST):
1097         The expected order of incoming events is
1098         1. didInvalidateIntrinsicContentSize
1099         2. didFirstLayout
1100         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1101         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1102         (and remember, all we care about is ordering).
1103
1104 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
1105
1106         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1107         https://bugs.webkit.org/show_bug.cgi?id=197171
1108         <rdar://problem/47454979>
1109
1110         Reviewed by Youenn Fablet.
1111
1112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1113         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1114         (TestWebKitAPI::TEST):
1115
1116 2019-04-24  Brady Eidson  <beidson@apple.com>
1117
1118         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
1119         https://bugs.webkit.org/show_bug.cgi?id=191362
1120
1121         Reviewed by Alex Christensen.
1122
1123         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1124           from an XHR to a custom protocol.
1125
1126 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1127
1128         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1129         https://bugs.webkit.org/show_bug.cgi?id=197273
1130
1131         Reviewed by Dean Jackson.
1132
1133         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1134         so that WebCoreTestSupport::resetInternalsObject() is always run.
1135
1136         * DumpRenderTree/mac/DumpRenderTree.mm:
1137         (resetWebViewToConsistentStateBeforeTesting):
1138         (runTest):
1139
1140 2019-04-24  John Wilander  <wilander@apple.com>
1141
1142         Age out unconverted Ad Click Attributions after one week.
1143         https://bugs.webkit.org/show_bug.cgi?id=197238
1144         <rdar://problem/50177349>
1145
1146         Reviewed by Chris Dumez.
1147
1148         This patch adds infrastructure to allow tests to expire all unconverted
1149         attributions early.
1150
1151         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1152         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1153         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1154         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1155         * WebKitTestRunner/TestController.cpp:
1156         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1157         * WebKitTestRunner/TestController.h:
1158         * WebKitTestRunner/TestInvocation.cpp:
1159         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1160
1161 2019-04-24  Chris Dumez  <cdumez@apple.com>
1162
1163         Fix flaky crashes in a couple of PSON API tests
1164         https://bugs.webkit.org/show_bug.cgi?id=197239
1165
1166         Reviewed by Tim Horton.
1167
1168         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1169
1170         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1171
1172 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1173
1174         Make it possible to control the renderTreeAsText output by setting options on testRunner
1175         https://bugs.webkit.org/show_bug.cgi?id=197133
1176
1177         Reviewed by Sam Weinig.
1178
1179         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1180         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1181         these flags through the various framework layers.
1182
1183         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1184
1185         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1186         and hand-code DumpRenderTree bindings.
1187
1188         Some cleanup of the TestRunners, using member initializers.
1189
1190         * DumpRenderTree/TestRunner.cpp:
1191         (TestRunner::TestRunner):
1192         (setRenderTreeDumpOptionsCallback):
1193         (TestRunner::staticFunctions):
1194         (TestRunner::setRenderTreeDumpOptions):
1195         * DumpRenderTree/TestRunner.h:
1196         (TestRunner::renderTreeDumpOptions const):
1197         * DumpRenderTree/mac/DumpRenderTree.mm:
1198         (dump):
1199         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1200         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1201         (WTR::InjectedBundlePage::dump):
1202         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1203         (WTR::TestRunner::TestRunner):
1204         (WTR::TestRunner::setRenderTreeDumpOptions):
1205         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1206         (WTR::TestRunner::renderTreeDumpOptions const):
1207
1208 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1209
1210         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1211         https://bugs.webkit.org/show_bug.cgi?id=197078
1212         <rdar://problem/49564348>
1213
1214         Reviewed by Geoff Garen.
1215
1216         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1217         (TEST_F):
1218         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1219         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1220         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1221
1222 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1223
1224         Add unit test for r239322
1225         https://bugs.webkit.org/show_bug.cgi?id=197236
1226
1227         Reviewed by Chris Dumez.
1228
1229         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1230         May as well add the test infrastructure which was needed before and will be needed in the future.
1231
1232         * TestWebKitAPI/TCPServer.cpp:
1233         (TestWebKitAPI::TCPServer::TCPServer):
1234         * TestWebKitAPI/TCPServer.h:
1235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1236         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1237         (TestWebKitAPI::TEST):
1238         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1239         (TestWebKitAPI::downloadAtRate):
1240         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1241         (TEST):
1242         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1243         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1244         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1245         (TestWebKitAPI::TEST):
1246         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1247         (TEST):
1248
1249 2019-04-24  Chris Dumez  <cdumez@apple.com>
1250
1251         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1252         https://bugs.webkit.org/show_bug.cgi?id=197214
1253         <rdar://problem/49237544>
1254
1255         Reviewed by Alex Christensen.
1256
1257         Extend API test coverage.
1258
1259         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1260         (TEST):
1261
1262 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1263
1264         [Build][GStreamer] Update to 1.16.0
1265         https://bugs.webkit.org/show_bug.cgi?id=197157
1266
1267         Reviewed by Xabier Rodriguez-Calvar.
1268
1269         The upstreamed patches were removed and a new one was added for a
1270         regression detected in the scaletempo GStreamer element. The GNOME
1271         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1272         on the way, as it is the preferred build system now in GStreamer
1273         1.16.
1274
1275         * flatpak/files/httpd-autogen.sh:
1276         * flatpak/flatpakutils.py:
1277         (FlatpakPackage.install):
1278         (WebkitFlatpak.run_in_sandbox):
1279         * flatpak/org.webkit.CommonModules.yaml:
1280         * flatpak/org.webkit.WebKit.yaml:
1281         * gstreamer/jhbuild.modules:
1282         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1283         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1284         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1285         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1286         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1287         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1288         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1289         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1290         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1291         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1292         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1293         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1294         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1295         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1296         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1297         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1298         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1299         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1300         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1301         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1302         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1303         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1304
1305 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1306
1307         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1308         https://bugs.webkit.org/show_bug.cgi?id=197156
1309
1310         Reviewed by Michael Catanzaro.
1311
1312         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1313         support was added.
1314
1315         * MiniBrowser/gtk/BrowserTab.c:
1316         (browser_tab_set_background_color): Set the passed in color as web view background color.
1317         * MiniBrowser/gtk/BrowserTab.h:
1318         * MiniBrowser/gtk/BrowserWindow.c:
1319         (browser_window_init): Initialize backgroundColor.
1320         (browser_window_append_view): Call browser_tab_set_background_color().
1321         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1322         are added.
1323         * MiniBrowser/gtk/main.c:
1324         (main): Call browser_window_set_background_color() before creating the tabs.
1325
1326 2019-04-23  John Wilander  <wilander@apple.com>
1327
1328         Move Ad Click Attribution from internal feature to experimental feature
1329         https://bugs.webkit.org/show_bug.cgi?id=197218
1330         <rdar://problem/47651691>
1331
1332         Reviewed by Brent Fulgham.
1333
1334         * DumpRenderTree/TestOptions.cpp:
1335         (TestOptions::TestOptions):
1336
1337 2019-04-23  Andy Estes  <aestes@apple.com>
1338
1339         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1340         https://bugs.webkit.org/show_bug.cgi?id=196749
1341         <rdar://problem/35773454>
1342
1343         Reviewed by Daniel Bates.
1344
1345         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1346
1347         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1348         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1349         (-[QuickLookDelegate webView:didFinishNavigation:]):
1350         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1351         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1352         (runTest):
1353         (runTestDecideBeforeLoading):
1354         (runTestDecideAfterLoading):
1355         (TEST):
1356
1357 2019-04-23  John Wilander  <wilander@apple.com>
1358
1359         Remove Ad Click Attribution data when removing website data
1360         https://bugs.webkit.org/show_bug.cgi?id=197215
1361         <rdar://problem/47668988>
1362
1363         Reviewed by Chris Dumez.
1364
1365         This patch adds test infrastructure to delete Ad Click Attribution data
1366         through WebsiteDataStore::removeData().
1367
1368         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1369         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1370         (WTR::TestRunner::clearAdClickAttribution):
1371         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1372         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1373         * WebKitTestRunner/TestController.cpp:
1374         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1375         * WebKitTestRunner/TestController.h:
1376         * WebKitTestRunner/TestInvocation.cpp:
1377         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1378
1379 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1380
1381         webkitpy: Kill unresponsive worker processes
1382         https://bugs.webkit.org/show_bug.cgi?id=197205
1383         <rdar://problem/50104388>
1384
1385         Reviewed by Lucas Forschler.
1386
1387         * Scripts/webkitpy/common/message_pool.py:
1388         (_MessagePool.__init__): Add close timeout.
1389         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1390
1391 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1392
1393         Add unit tests for WKWebView.serverTrust
1394         https://bugs.webkit.org/show_bug.cgi?id=197202
1395
1396         Reviewed by Youenn Fablet
1397
1398         * TestWebKitAPI/TCPServer.cpp:
1399         (TestWebKitAPI::deleter<BIO>::operator()):
1400         (TestWebKitAPI::deleter<SSL>::operator()):
1401         (TestWebKitAPI::deleter<X509>::operator()):
1402         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1403         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1404         (TestWebKitAPI::TCPServer::TCPServer):
1405         (TestWebKitAPI::TCPServer::listenForConnections):
1406         * TestWebKitAPI/TCPServer.h:
1407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1408         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1409         (TestWebKitAPI::TEST):
1410         (verifyCertificateAndPublicKey):
1411         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1412         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1413         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1414         (TestWebKitAPI::downloadAtRate):
1415         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1416         (TEST):
1417         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1418         (TEST):
1419
1420 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1421
1422         Unreviewed, rolling out r244556.
1423         https://bugs.webkit.org/show_bug.cgi?id=197212
1424
1425         Causing build failures on multiple builders (Requested by
1426         ShawnRoberts on #webkit).
1427
1428         Reverted changeset:
1429
1430         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1431         https://bugs.webkit.org/show_bug.cgi?id=197171
1432         https://trac.webkit.org/changeset/244556
1433
1434 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1435
1436         Fix iOS build.
1437         https://bugs.webkit.org/show_bug.cgi?id=195537
1438
1439         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1440         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1441         AdoptWK constructor is private now.  Use adoptWK instead.
1442
1443 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1444
1445         Accessibility text search and selection API enhancements.
1446         https://bugs.webkit.org/show_bug.cgi?id=197095
1447         <rdar://problem/48181791>
1448
1449         Reviewed by Chris Fleizach.
1450
1451         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1452
1453         * DumpRenderTree/AccessibilityTextMarker.h:
1454         * DumpRenderTree/AccessibilityUIElement.cpp:
1455         (searchTextWithCriteriaCallback):
1456         (AccessibilityUIElement::getJSClass):
1457         * DumpRenderTree/AccessibilityUIElement.h:
1458         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1459         (convertVectorToObjectArray):
1460         (convertNSArrayToVector):
1461         (searchTextParameterizedAttributeForCriteria):
1462         (AccessibilityUIElement::getLinkedUIElements):
1463         (AccessibilityUIElement::getDocumentLinks):
1464         (AccessibilityUIElement::getChildren):
1465         (AccessibilityUIElement::getChildrenWithRange):
1466         (AccessibilityUIElement::rowHeaders const):
1467         (AccessibilityUIElement::columnHeaders const):
1468         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1469         (AccessibilityUIElement::searchTextWithCriteria):
1470         (AccessibilityUIElement::attributesOfColumnHeaders):
1471         (AccessibilityUIElement::attributesOfRowHeaders):
1472         (AccessibilityUIElement::attributesOfColumns):
1473         (AccessibilityUIElement::attributesOfRows):
1474         (AccessibilityUIElement::attributesOfVisibleCells):
1475         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1476         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1477         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1478         (WTR::convertVectorToObjectArray):
1479         (WTR::convertNSArrayToVector):
1480         (WTR::searchTextParameterizedAttributeForCriteria):
1481         (WTR::AccessibilityUIElement::getLinkedUIElements):
1482         (WTR::AccessibilityUIElement::getDocumentLinks):
1483         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1484         (WTR::AccessibilityUIElement::getChildren):
1485         (WTR::AccessibilityUIElement::getChildrenWithRange):
1486         (WTR::AccessibilityUIElement::rowHeaders const):
1487         (WTR::AccessibilityUIElement::columnHeaders const):
1488         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1489         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1490         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1491         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1492         (WTR::AccessibilityUIElement::attributesOfColumns):
1493         (WTR::AccessibilityUIElement::attributesOfRows):
1494         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1495         (WTR::convertElementsToObjectArray): Deleted.
1496
1497 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1498
1499         Multiple File Input Icon Set Regardless of File List
1500         https://bugs.webkit.org/show_bug.cgi?id=195537
1501
1502         Reviewed by Alexey Proskuryakov.
1503
1504         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1505         display string in iOS file inputs
1506
1507         * DumpRenderTree/TestRunner.cpp:
1508         (SetOpenPanelFilesMediaIconCallback):
1509         (TestRunner::staticFunctions):
1510         (TestRunner::setOpenPanelFilesMediaIcon):
1511         * DumpRenderTree/TestRunner.h:
1512         (TestRunner::openPanelFilesMediaIcon const):
1513         * DumpRenderTree/mac/UIDelegate.mm:
1514         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1515         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1516         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1517         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1518         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1519         * WebKitTestRunner/TestController.cpp:
1520         (WTR::runOpenPanel):
1521         (WTR::TestController::resetStateToConsistentValues):
1522         * WebKitTestRunner/TestController.h:
1523         (WTR::TestController::openPanelFileURLsMediaIcon const):
1524         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1525         * WebKitTestRunner/TestInvocation.cpp:
1526         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1527
1528 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1529
1530         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1531         https://bugs.webkit.org/show_bug.cgi?id=197171
1532         <rdar://problem/47454979>
1533
1534         Reviewed by Youenn Fablet.
1535
1536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1537         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1538         (TestWebKitAPI::TEST):
1539
1540 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1541
1542         [ews-build] Add unit tests for UnApplyPatchIfRequired
1543         https://bugs.webkit.org/show_bug.cgi?id=197197
1544
1545         Reviewed by Lucas Forschler.
1546
1547         * BuildSlaveSupport/ews-build/steps_unittest.py:
1548         (TestUnApplyPatchIfRequired):
1549         (TestUnApplyPatchIfRequired.test_success):
1550         (TestUnApplyPatchIfRequired.test_failure):
1551         (TestUnApplyPatchIfRequired.test_skip):
1552
1553 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1554
1555         [ews-build] Add unit tests for CleanWorkingDirectory
1556         https://bugs.webkit.org/show_bug.cgi?id=197195
1557
1558         Reviewed by Lucas Forschler.
1559
1560         * BuildSlaveSupport/ews-build/steps_unittest.py:
1561         (TestCleanWorkingDirectory):
1562         (TestCleanWorkingDirectory.test_success):
1563         (TestCleanWorkingDirectory.test_failure):
1564
1565 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1566
1567         [ews-build] Use explicit imports instead of wildcard imports
1568         https://bugs.webkit.org/show_bug.cgi?id=197194
1569
1570         Reviewed by Lucas Forschler.
1571
1572         * BuildSlaveSupport/ews-build/factories.py:
1573         * BuildSlaveSupport/ews-build/loadConfig.py:
1574         * BuildSlaveSupport/ews-build/steps_unittest.py:
1575
1576 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1577
1578         [ews-build] Add unit tests for DownloadBuiltProduct
1579         https://bugs.webkit.org/show_bug.cgi?id=197193
1580
1581         Reviewed by Lucas Forschler.
1582
1583         * BuildSlaveSupport/ews-build/steps_unittest.py:
1584         (TestDownloadBuiltProduct):
1585         (TestDownloadBuiltProduct.setUp):
1586         (TestDownloadBuiltProduct.tearDown):
1587         (TestDownloadBuiltProduct.test_success):
1588         (TestDownloadBuiltProduct.test_failure):
1589
1590 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1591
1592         [ews-app] Exception while loading status-bubble when no build step has started
1593         https://bugs.webkit.org/show_bug.cgi?id=196676
1594
1595         Reviewed by Lucas Forschler.
1596
1597         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1598         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1599
1600 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1601
1602         [PlayStation] Support running of JSC tests on remote playstation devices
1603         https://bugs.webkit.org/show_bug.cgi?id=197170
1604
1605         Reviewed by Ross Kirsling.
1606
1607         Script changes
1608
1609         * Scripts/run-javascriptcore-tests:
1610         (runJSCStressTests): Pass arguments for playstation to
1611         run-jsc-stress-tests
1612         * Scripts/run-jsc-stress-tests:
1613         Handle $hostOS=="playstation" for determineArchitecture, turning
1614         off $isFTLPlatform and runProfiler and defaulting test writer.
1615         * Scripts/webkitdirs.pm:
1616         (jscPath): PlayStation WebKit executables have .elf extension
1617         (executableProductDir): PlayStation builds on Windows hosts but
1618         uses bin directory rather than bin64/bin32 for executable output
1619         location.
1620         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1621
1622 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1623
1624         [CMake][Win] Use target oriented design for WebKit
1625         https://bugs.webkit.org/show_bug.cgi?id=197173
1626
1627         Reviewed by Alex Christensen.
1628
1629         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1630         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1631
1632 2019-04-23  Chris Dumez  <cdumez@apple.com>
1633
1634         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1635         https://bugs.webkit.org/show_bug.cgi?id=197097
1636         <rdar://problem/50048318>
1637
1638         Reviewed by Alex Christensen.
1639
1640         Add API test coverage.
1641
1642         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1643         (-[PSONScheme webView:startURLSchemeTask:]):
1644
1645 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1646
1647         [ATK] Implement AtkComponentIface scroll_to methods
1648         https://bugs.webkit.org/show_bug.cgi?id=196856
1649
1650         Reviewed by Michael Catanzaro.
1651
1652         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1653         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1654         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1655         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1656
1657 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1658
1659         [ews-build] Improve summary for UploadBuiltProduct step
1660         https://bugs.webkit.org/show_bug.cgi?id=197182
1661
1662         Reviewed by Lucas Forschler.
1663
1664         * BuildSlaveSupport/ews-build/steps.py:
1665         (UploadBuiltProduct): Added descriptionDone.
1666         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1667         * BuildSlaveSupport/ews-build/steps_unittest.py:
1668         (TestUploadBuiltProduct.test_success): Updated unit-test.
1669         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1670
1671 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1672
1673         [ews-build] Trigger queues only after uploading the archive
1674         https://bugs.webkit.org/show_bug.cgi?id=197180
1675
1676         Reviewed by Lucas Forschler.
1677
1678         * BuildSlaveSupport/ews-build/factories.py:
1679         (Factory.__init__):
1680         (BuildFactory.__init__): Remove trigger step from factories.
1681         (BuildFactory.propertiesToPassToTriggers): Deleted.
1682         * BuildSlaveSupport/ews-build/steps.py:
1683         (ConfigureBuild.__init__): Confiure triggers property.
1684         (Trigger): Step to trigger other queues.
1685         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1686         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1687
1688 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1689
1690         Deprecate WKContextCreateWithInjectedBundlePath
1691         https://bugs.webkit.org/show_bug.cgi?id=197169
1692
1693         Reviewed by Youenn Fablet.
1694
1695         * TestWebKitAPI/PlatformUtilities.cpp:
1696         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1697         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1698
1699 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1700
1701         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1702         https://bugs.webkit.org/show_bug.cgi?id=197093
1703         <rdar://problem/49708268>
1704
1705         Reviewed by Chris Dumez.
1706
1707         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1708         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1709         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1710         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1711         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1712
1713         * TestWebKitAPI/TCPServer.cpp:
1714         (TestWebKitAPI::TCPServer::TCPServer):
1715         (TestWebKitAPI::TCPServer::~TCPServer):
1716         (TestWebKitAPI::TCPServer::socketBindListen):
1717         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1718         * TestWebKitAPI/TCPServer.h:
1719         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1720         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1721         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1722         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1723         (respondWithChallengeThenOK):
1724         (TestWebKitAPI::TEST):
1725         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1726         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1727         (TEST):
1728
1729 2019-04-22  Chris Dumez  <cdumez@apple.com>
1730
1731         Delayed WebProcessLaunch may break the _relatedWebView SPI
1732         https://bugs.webkit.org/show_bug.cgi?id=197160
1733
1734         Reviewed by Alex Christensen.
1735
1736         Add API test coverage.
1737
1738         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1739
1740 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1741
1742         Use curl to download packages for webkitpy autoinstaller
1743         https://bugs.webkit.org/show_bug.cgi?id=197164
1744
1745         Reviewed by Darin Adler.
1746
1747         * Scripts/webkitpy/common/system/autoinstall.py:
1748         (AutoInstaller._download): Use curl(1) to download packages necessary for
1749         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1750         errors which are not present when using curl(1).
1751
1752 2019-04-22  Chris Dumez  <cdumez@apple.com>
1753
1754         Unreviewed, rolling out r244502.
1755
1756         Caused crashes on the bots
1757
1758         Reverted changeset:
1759
1760         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1761         https://bugs.webkit.org/show_bug.cgi?id=197160
1762         https://trac.webkit.org/changeset/244502
1763
1764 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1765
1766         Unreviewed, rolling out r244437.
1767
1768         Still breaks internal tests.
1769
1770         Reverted changeset:
1771
1772         "InjectedBundle parameters often need initialization function
1773         called before unarchiving"
1774         https://bugs.webkit.org/show_bug.cgi?id=189709
1775         https://trac.webkit.org/changeset/244437
1776
1777 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1778
1779         [ews-build] Use singular verb in failure description in case of single api test failure
1780         https://bugs.webkit.org/show_bug.cgi?id=197013
1781
1782         Reviewed by Lucas Forschler.
1783
1784         * BuildSlaveSupport/ews-build/steps.py:
1785         (AnalyzeAPITestsResults.analyzeResults):
1786
1787 2019-04-22  Chris Dumez  <cdumez@apple.com>
1788
1789         Delayed WebProcessLaunch may break the _relatedWebView SPI
1790         https://bugs.webkit.org/show_bug.cgi?id=197160
1791
1792         Reviewed by Alex Christensen.
1793
1794         Add API test coverage.
1795
1796         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1797
1798 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1799
1800         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1801         https://bugs.webkit.org/show_bug.cgi?id=194630
1802
1803         Reviewed by Michael Catanzaro.
1804
1805         Return early from getAttributeSet() is passed in accessible is nullptr.
1806
1807         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1808
1809 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1810
1811         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1812         https://bugs.webkit.org/show_bug.cgi?id=197145
1813         <rdar://problem/50078170>
1814
1815         Reviewed by Darin Adler.
1816
1817         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1818         focus, or showing the font manager.
1819
1820         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1821         (TestWebKitAPI::TEST):
1822         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1823         (TEST):
1824         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1825         (TestWebKitAPI::TEST):
1826
1827 2019-04-21  Brian Burg  <bburg@apple.com>
1828
1829         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1830         https://bugs.webkit.org/show_bug.cgi?id=197125
1831         <rdar://problem/50061468>
1832
1833         Reviewed by Darin Adler.
1834
1835         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1836         using this class rather than making our own ./wpt serve invocation.
1837
1838         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1839         (WebDriverW3CWebServer):
1840         (WebDriverW3CWebServer.document_root): Expose this to clients.
1841         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1842
1843         (WebDriverW3CWebServer.__enter__):
1844         (WebDriverW3CWebServer.__exit__):
1845         Make it possible to use the web server with a 'with' statement.
1846
1847 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1848
1849         [CMake][Win] Use target oriented design for WebKitLegacy
1850         https://bugs.webkit.org/show_bug.cgi?id=197112
1851
1852         Reviewed by Konstantin Tokarev.
1853
1854         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1855
1856         * DumpRenderTree/CMakeLists.txt:
1857         * DumpRenderTree/PlatformWin.cmake:
1858         * DumpRenderTree/win/EventSender.cpp:
1859
1860 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1861
1862         Update text for old EWS submit button
1863         https://bugs.webkit.org/show_bug.cgi?id=197140
1864
1865         Reviewed by Alexey Proskuryakov.
1866
1867         * QueueStatusServer/templates/statusbubble.html:
1868
1869 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1870
1871         [ews-app] New EWS should poll bugzilla more frequently
1872         https://bugs.webkit.org/show_bug.cgi?id=197138
1873
1874         Reviewed by Alexey Proskuryakov.
1875
1876         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1877         (FetchLoop.__init__):
1878
1879 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1880
1881         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1882         https://bugs.webkit.org/show_bug.cgi?id=197139
1883
1884         Reviewed by Alexey Proskuryakov.
1885
1886         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1887         * QueueStatusServer/templates/statusbubble.html:
1888
1889 2019-04-20  Chris Dumez  <cdumez@apple.com>
1890
1891         Unreviewed, fix iOS build with recent SDKs.
1892
1893         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1894
1895 2019-04-19  Keith Miller  <keith_miller@apple.com>
1896
1897         Add script to merge run_benchmark jsons
1898         https://bugs.webkit.org/show_bug.cgi?id=197107
1899
1900         Reviewed by Michael Saboff.
1901
1902         The script basically recursively decends through all json objects until it gets
1903         to an array or JSON primitive and concats or takes the first value, respectively.
1904
1905         This patch also adds +x bits to the compare-results script so it
1906         can be run directly from the command line. I had to add a new line so that svn
1907         will accept the change... yay svn!
1908
1909         * Scripts/compare-results:
1910         * Scripts/merge-result-jsons: Added.
1911         (readJSONFile):
1912         (deepAppend):
1913         (mergeJSONs):
1914         (main):
1915
1916 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1917
1918         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1919         https://bugs.webkit.org/show_bug.cgi?id=197079
1920
1921         Reviewed by Darin Adler.
1922
1923         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1924
1925         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1926         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1927
1928 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1929
1930         Unreviewed, rolling out r244434.
1931         https://bugs.webkit.org/show_bug.cgi?id=197089
1932
1933         caused 1 API test failure (Requested by zalan on #webkit).
1934
1935         Reverted changeset:
1936
1937         "Regression (r244291): Broken API Test
1938         AutoLayoutRenderingProgressRelativeOrdering"
1939         https://bugs.webkit.org/show_bug.cgi?id=196948
1940         https://trac.webkit.org/changeset/244434
1941
1942 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1943
1944         Add new compatibility mode API on WKNavigation
1945         https://bugs.webkit.org/show_bug.cgi?id=197069
1946         <rdar://problem/50025800>
1947
1948         Reviewed by Tim Horton.
1949
1950         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1951
1952         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1953         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1954         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1955
1956 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1957
1958         [CMake] Make WebCore headers copies
1959         https://bugs.webkit.org/show_bug.cgi?id=182512
1960         <rdar://problem/37510435>
1961
1962         Reviewed by Alex Christensen.
1963
1964         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1965         ports.
1966
1967         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1968         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1969
1970         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1971         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1972         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1973         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1974         * TestWebKitAPI/CMakeLists.txt:
1975         * TestWebKitAPI/PlatformWin.cmake:
1976         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1977         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1978         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1979
1980 2019-04-18  Jer Noble  <jer.noble@apple.com>
1981
1982         Add support for parsing FairPlayStreaming PSSH boxes.
1983         https://bugs.webkit.org/show_bug.cgi?id=197064
1984
1985         Reviewed by Eric Carlson.
1986
1987         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1988         (TestWebKitAPI::TEST):
1989
1990 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1991
1992         InjectedBundle parameters often need initialization function called before unarchiving
1993         https://bugs.webkit.org/show_bug.cgi?id=189709
1994         <rdar://problem/44573653>
1995
1996         Reviewed by Ryosuke Niwa.
1997
1998         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1999         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2000
2001 2019-04-18  Zalan Bujtas  <zalan@apple.com>
2002
2003         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2004         https://bugs.webkit.org/show_bug.cgi?id=196948
2005         <rdar://problem/49927131>
2006
2007         Reviewed by Tim Horton.
2008
2009         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2010         (TEST): 
2011         The expected order of incoming events is
2012         1. didInvalidateIntrinsicContentSize
2013         2. didFirstLayout
2014         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2015         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2016         (and remember, all we care about is ordering).
2017
2018 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
2019
2020         Unreviewed, rolling out r244299.
2021
2022         Breaks internal tests.
2023
2024         Reverted changeset:
2025
2026         "InjectedBundle parameters often need initialization function
2027         called before unarchiving"
2028         https://bugs.webkit.org/show_bug.cgi?id=189709
2029         https://trac.webkit.org/changeset/244299
2030
2031 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
2032
2033         [WTF] StringBuilder should set correct m_is8Bit flag when merging
2034         https://bugs.webkit.org/show_bug.cgi?id=197053
2035
2036         Reviewed by Saam Barati.
2037
2038         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2039         (TestWebKitAPI::TEST):
2040
2041 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2042
2043         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
2044         https://bugs.webkit.org/show_bug.cgi?id=197028
2045         <rdar://problem/49985290>
2046
2047         Reviewed by Wenson Hsieh.
2048
2049         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
2050         (TEST):
2051         Liberal application of waitForNextPresentationUpdate works around a race
2052         where if the page rapidly changes its viewport arguments (or an API client
2053         rapidly changes its viewport arguments), we'd get stuck thinking that the
2054         user had intentionally zoomed the page, and stop resetting the initial scale.
2055         This deserves a separate bug, but no need to keep the test failing while
2056         we think about it.
2057
2058 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2059
2060         REGRESSION (r241988): Switching tabs is slow
2061         https://bugs.webkit.org/show_bug.cgi?id=197037
2062         <rdar://problem/49951473>
2063
2064         Reviewed by Simon Fraser.
2065
2066         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2067         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
2068         (TEST):
2069         * TestWebKitAPI/cocoa/TestWKWebView.h:
2070         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2071         (-[TestWKWebView addToTestWindow]):
2072         Add a test that hangs without this fix.
2073
2074 2019-04-17  Truitt Savell  <tsavell@apple.com>
2075
2076         Unreviewed, rolling out r244400.
2077
2078         Caused testing to exit early with assertionon Debug WK2
2079
2080         Reverted changeset:
2081
2082         "UI↔Web deadlock when printing with a JavaScript alert
2083         visible"
2084         https://bugs.webkit.org/show_bug.cgi?id=196839
2085         https://trac.webkit.org/changeset/244400
2086
2087 2019-04-17  Brady Eidson  <beidson@apple.com>
2088
2089         Link clicks in PDFs shouldn't send referrer headers.
2090         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
2091
2092         Reviewed by Tim Horton.
2093
2094         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2095         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
2096         (putPDFBytesCallback):
2097         (emptyReleaseInfoCallback):
2098         (createPDFWithLinkToURL):
2099         (TEST):
2100
2101 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2102
2103         UI↔Web deadlock when printing with a JavaScript alert visible
2104         https://bugs.webkit.org/show_bug.cgi?id=196839
2105         <rdar://problem/49157642>
2106
2107         Reviewed by Andy Estes.
2108
2109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2110         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
2111         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2112         (TEST):
2113
2114 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2115
2116         WKRetainPtr's adoption constructor should be private
2117         https://bugs.webkit.org/show_bug.cgi?id=197019
2118
2119         Reviewed by Tim Horton.
2120
2121         * DumpRenderTree/mac/DumpRenderTree.mm:
2122         (dumpFramesAsText):
2123         * TestWebKitAPI/InjectedBundleController.cpp:
2124         (TestWebKitAPI::InjectedBundleController::initialize):
2125         * TestWebKitAPI/PlatformUtilities.cpp:
2126         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2127         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2128         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2129         (TestWebKitAPI::Util::toWK):
2130         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2131         (TestWebKitAPI::TEST):
2132         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2133         (TestWebKitAPI::TEST):
2134         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2135         (TestWebKitAPI::TEST):
2136         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2137         (TestWebKitAPI::TEST):
2138         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2139         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2140         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2141         (TestWebKitAPI::TEST):
2142         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2143         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2144         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2145         (TestWebKitAPI::TEST):
2146         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2147         (TestWebKitAPI::TEST):
2148         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2149         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2150         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2151         (TestWebKitAPI::TEST):
2152         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2153         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2154         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2155         (TestWebKitAPI::TEST):
2156         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2157         (TestWebKitAPI::TEST):
2158         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2159         (TestWebKitAPI::TEST):
2160         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2161         (TestWebKitAPI::TEST):
2162         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2163         (TestWebKitAPI::TEST):
2164         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2165         (TestWebKitAPI::TEST):
2166         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2167         (TestWebKitAPI::TEST):
2168         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2169         (TestWebKitAPI::TEST):
2170         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2171         (TestWebKitAPI::TEST):
2172         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2173         (TestWebKitAPI::TEST):
2174         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2175         (TestWebKitAPI::TEST):
2176         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2177         (TestWebKitAPI::TEST):
2178         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2179         (TestWebKitAPI::TEST):
2180         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2181         (TestWebKitAPI::TEST):
2182         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2183         (TestWebKitAPI::TEST):
2184         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2185         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2186         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2187         (TestWebKitAPI::TEST):
2188         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2189         (TestWebKitAPI::TEST):
2190         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2191         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2192         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2193         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2194         (TestWebKitAPI::TEST):
2195         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2196         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2197         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2198         (TestWebKitAPI::TEST):
2199         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2200         (TestWebKitAPI::TEST):
2201         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2202         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2203         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2204         (TestWebKitAPI::TEST):
2205         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2206         (TestWebKitAPI::loadAlternateHTMLString):
2207         (TestWebKitAPI::TEST):
2208         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2209         (TestWebKitAPI::TEST):
2210         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2211         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2212         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2213         (TestWebKitAPI::buildAndPerformTest):
2214         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2215         (TestWebKitAPI::TEST):
2216         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2217         (TestWebKitAPI::TEST):
2218         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2219         (TestWebKitAPI::TEST):
2220         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2221         (TestWebKitAPI::TEST):
2222         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2223         (TestWebKitAPI::TEST):
2224         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2225         (TestWebKitAPI::TEST):
2226         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2227         (TestWebKitAPI::TEST):
2228         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2229         (TestWebKitAPI::TEST):
2230         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2231         (TestWebKitAPI::TEST):
2232         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2233         (TestWebKitAPI::TEST):
2234         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2235         (TestWebKitAPI::TEST):
2236         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2237         (TestWebKitAPI::TEST):
2238         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2239         (TestWebKitAPI::TEST):
2240         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2241         (TestWebKitAPI::TEST):
2242         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2243         (TestWebKitAPI::TEST):
2244         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2245         (TestWebKitAPI::TEST):
2246         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2247         (TestWebKitAPI::TEST):
2248         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2249         (TestWebKitAPI::TEST):
2250         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2251         (TestWebKitAPI::TEST):
2252         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2253         (TestWebKitAPI::TEST):
2254         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2255         (TestWebKitAPI::TEST):
2256         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2257         (TestWebKitAPI::TEST):
2258         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2259         (TestWebKitAPI::TEST):
2260         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2261         (TestWebKitAPI::TEST):
2262         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2263         (TestWebKitAPI::TEST):
2264         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2265         (TestWebKitAPI::TEST):
2266         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2267         (TestWebKitAPI::TEST):
2268         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2269         (TestWebKitAPI::TEST):
2270         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2271         (TestWebKitAPI::TEST):
2272         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2273         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2274         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2275         (TestWebKitAPI::TEST):
2276         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2277         (TestWebKitAPI::TEST):
2278         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2279         (TestWebKitAPI::TEST):
2280         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2281         (TestWebKitAPI::TEST):
2282         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2283         (TestWebKitAPI::TEST):
2284         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2285         (TestWebKitAPI::TEST):
2286         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2287         (TestWebKitAPI::TEST):
2288         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2289         (TestWebKitAPI::TEST):
2290         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2291         (TestWebKitAPI::TEST):
2292         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2293         (TestWebKitAPI::TEST):
2294         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2295         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2296         (TEST):
2297         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2298         (TEST):
2299         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2300         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2301         (TEST):
2302         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2303         (TestWebKitAPI::TEST):
2304         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2305         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2306         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2307         (WTR::getMenuItemTitleCallback):
2308         (WTR::createMouseMessageBody):
2309         (WTR::EventSendingController::mouseDown):
2310         (WTR::EventSendingController::mouseUp):
2311         (WTR::EventSendingController::mouseMoveTo):
2312         (WTR::EventSendingController::mouseForceClick):
2313         (WTR::EventSendingController::startAndCancelMouseForceClick):
2314         (WTR::EventSendingController::mouseForceDown):
2315         (WTR::EventSendingController::mouseForceUp):
2316         (WTR::EventSendingController::mouseForceChanged):
2317         (WTR::EventSendingController::leapForward):
2318         (WTR::EventSendingController::scheduleAsynchronousClick):
2319         (WTR::createKeyDownMessageBody):
2320         (WTR::EventSendingController::keyDown):
2321         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2322         (WTR::EventSendingController::mouseScrollBy):
2323         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2324         (WTR::EventSendingController::continuousMouseScrollBy):
2325         (WTR::EventSendingController::addTouchPoint):
2326         (WTR::EventSendingController::updateTouchPoint):
2327         (WTR::EventSendingController::setTouchModifier):
2328         (WTR::EventSendingController::setTouchPointRadius):
2329         (WTR::EventSendingController::touchStart):
2330         (WTR::EventSendingController::touchMove):
2331         (WTR::EventSendingController::touchEnd):
2332         (WTR::EventSendingController::touchCancel):
2333         (WTR::EventSendingController::clearTouchPoints):
2334         (WTR::EventSendingController::releaseTouchPoint):
2335         (WTR::EventSendingController::cancelTouchPoint):
2336         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2337         (WTR::InjectedBundle::didCreatePage):
2338         (WTR::InjectedBundle::didReceiveMessage):
2339         (WTR::InjectedBundle::didReceiveMessageToPage):
2340         (WTR::InjectedBundle::booleanForKey):
2341         (WTR::InjectedBundle::done):
2342         (WTR::InjectedBundle::dumpToStdErr):
2343         (WTR::InjectedBundle::outputText):
2344         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2345         (WTR::InjectedBundle::postAddChromeInputField):
2346         (WTR::InjectedBundle::postRemoveChromeInputField):
2347         (WTR::InjectedBundle::postFocusWebView):
2348         (WTR::InjectedBundle::postSetBackingScaleFactor):
2349         (WTR::InjectedBundle::postSetWindowIsKey):
2350         (WTR::InjectedBundle::postSetViewSize):
2351         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2352         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2353         (WTR::InjectedBundle::setGeolocationPermission):
2354         (WTR::InjectedBundle::setMockGeolocationPosition):
2355         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2356         (WTR::InjectedBundle::isGeolocationProviderActive const):
2357         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2358         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2359         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2360         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2361         (WTR::InjectedBundle::setCustomPolicyDelegate):
2362         (WTR::InjectedBundle::setHidden):
2363         (WTR::InjectedBundle::setCacheModel):
2364         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2365         (WTR::InjectedBundle::processWorkQueue):
2366         (WTR::InjectedBundle::queueBackNavigation):
2367         (WTR::InjectedBundle::queueForwardNavigation):
2368         (WTR::InjectedBundle::queueLoad):
2369         (WTR::InjectedBundle::queueLoadHTMLString):
2370         (WTR::InjectedBundle::queueReload):
2371         (WTR::InjectedBundle::queueLoadingScript):
2372         (WTR::InjectedBundle::queueNonLoadingScript):
2373         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2374         (WTR::frameToStr):
2375         (WTR::InjectedBundlePage::InjectedBundlePage):
2376         (WTR::dumpFrameDescriptionSuitableForTestResult):
2377         (WTR::dumpFrameScrollPosition):
2378         (WTR::dumpDescendantFrameScrollPositions):
2379         (WTR::dumpFrameText):
2380         (WTR::dumpDescendantFramesText):
2381         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2382         (WTR::TestRunner::shouldDumpPixels const):
2383         (WTR::TestRunner::setDumpPixels):
2384         (WTR::TestRunner::whatToDump const):
2385         (WTR::TestRunner::setWhatToDump):
2386         (WTR::TestRunner::setWaitUntilDone):
2387         (WTR::TestRunner::shouldWaitUntilDone const):
2388         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2389         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2390         (WTR::TestRunner::clearAllDatabases):
2391         (WTR::TestRunner::setIDBPerOriginQuota):
2392         (WTR::TestRunner::originsWithApplicationCache):
2393         (WTR::TestRunner::setCanOpenWindows):
2394         (WTR::TestRunner::setXSSAuditorEnabled):
2395         (WTR::TestRunner::setMediaDevicesEnabled):
2396         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2397         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2398         (WTR::TestRunner::setCustomUserAgent):
2399         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2400         (WTR::TestRunner::setModernMediaControlsEnabled):
2401         (WTR::TestRunner::setWebGL2Enabled):
2402         (WTR::TestRunner::setWritableStreamAPIEnabled):
2403         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2404         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2405         (WTR::TestRunner::setAllowsAnySSLCertificate):
2406         (WTR::TestRunner::setPluginsEnabled):
2407         (WTR::TestRunner::setValueForUser):
2408         (WTR::TestRunner::setAudioResult):
2409         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2410         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2411         (WTR::TestRunner::setAlwaysAcceptCookies):
2412         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2413         (WTR::TestRunner::isDoingMediaCapture const):
2414         (WTR::TestRunner::queueLoad):
2415         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2416         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2417         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2418         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2419         (WTR::TestRunner::setAuthenticationUsername):
2420         (WTR::TestRunner::setAuthenticationPassword):
2421         (WTR::TestRunner::secureEventInputIsEnabled const):
2422         (WTR::TestRunner::setBlockAllPlugins):
2423         (WTR::TestRunner::setPluginSupportedMode):
2424         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2425         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2426         (WTR::TestRunner::setNavigationGesturesEnabled):
2427         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2428         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2429         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2430         (WTR::TestRunner::terminateNetworkProcess):
2431         (WTR::TestRunner::terminateServiceWorkerProcess):
2432         (WTR::TestRunner::runUIScript):
2433         (WTR::TestRunner::setStatisticsDebugMode):
2434         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2435         (WTR::TestRunner::setStatisticsLastSeen):
2436         (WTR::TestRunner::setStatisticsPrevalentResource):
2437         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2438         (WTR::TestRunner::dumpResourceLoadStatistics):
2439         (WTR::TestRunner::isStatisticsPrevalentResource):
2440         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2441         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2442         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2443         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2444         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2445         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2446         (WTR::TestRunner::setStatisticsGrandfathered):
2447         (WTR::TestRunner::isStatisticsGrandfathered):
2448         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2449         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2450         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2451         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2452         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2453         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2454         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2455         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2456         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2457         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2458         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2459         (WTR::TestRunner::statisticsSubmitTelemetry):
2460         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2461         (WTR::TestRunner::setStatisticsIsRunningTest):
2462         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2463         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2464         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2465         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2466         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2467         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2468         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2469         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2470         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2471         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2472         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2473         (WTR::TestRunner::statisticsResetToConsistentState):
2474         (WTR::TestRunner::setStorageAccessAPIEnabled):
2475         (WTR::TestRunner::getAllStorageAccessEntries):
2476         (WTR::TestRunner::addMockMediaDevice):
2477         (WTR::TestRunner::clearMockMediaDevices):
2478         (WTR::TestRunner::removeMockMediaDevice):
2479         (WTR::TestRunner::resetMockMediaDevices):
2480         (WTR::TestRunner::connectMockGamepad):
2481         (WTR::TestRunner::disconnectMockGamepad):
2482         (WTR::TestRunner::setMockGamepadDetails):
2483         (WTR::TestRunner::setMockGamepadAxisValue):
2484         (WTR::TestRunner::setMockGamepadButtonValue):
2485         (WTR::TestRunner::removeAllSessionCredentials):
2486         (WTR::TestRunner::clearDOMCache):
2487         (WTR::TestRunner::clearDOMCaches):
2488         (WTR::TestRunner::hasDOMCache):
2489         (WTR::TestRunner::domCacheSize):
2490         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2491         (WTR::TestRunner::getApplicationManifestThen):
2492         (WTR::TestRunner::injectUserScript):
2493         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2494         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2495         (WTR::TestRunner::addTestKeyToKeychain):
2496         (WTR::TestRunner::cleanUpKeychain):
2497         (WTR::TestRunner::keyExistsInKeychain):
2498         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2499         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2500         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2501         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2502         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2503         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2504         * WebKitTestRunner/TestController.cpp:
2505         (WTR::TestController::initialize):
2506         (WTR::parseStringTestHeaderValueAsRelativePath):
2507         (WTR::updateTestOptionsFromTestHeader):
2508         (WTR::TestController::runTest):
2509         (WTR::TestController::didReceiveLiveDocumentsList):
2510         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2511         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2512         (WTR::TestController::didFinishNavigation):
2513         (WTR::TestController::didReceiveAuthenticationChallenge):
2514         * WebKitTestRunner/TestInvocation.cpp:
2515         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2516         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2517         (WTR::TestInvocation::uiScriptDidComplete):
2518         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2519         * WebKitTestRunner/WebNotificationProvider.cpp:
2520         (WTR::WebNotificationProvider::closeWebNotification):
2521         * WebKitTestRunner/WorkQueueManager.cpp:
2522         (WTR::ScriptItem::ScriptItem):
2523         (WTR::WorkQueueManager::queueLoad):
2524         (WTR::WorkQueueManager::queueLoadHTMLString):
2525
2526 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2527
2528         Add a comment to make my test from r244139 less mysterious.
2529         https://bugs.webkit.org/show_bug.cgi?id=196744
2530
2531         As suggested by Darin Adler.
2532
2533         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2534         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2535
2536 2019-04-17  Chris Dumez  <cdumez@apple.com>
2537
2538         Remember device orientation permission for the duration of the browsing session
2539         https://bugs.webkit.org/show_bug.cgi?id=196992
2540         <rdar://problem/49946067>
2541
2542         Reviewed by Alex Christensen.
2543
2544         Add API test coverage.
2545
2546         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2547         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2548         (TEST):
2549
2550 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2551
2552         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2553         https://bugs.webkit.org/show_bug.cgi?id=196675
2554
2555         Reviewed by Lucas Forschler.
2556
2557         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2558         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2559
2560 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2561
2562         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2563         https://bugs.webkit.org/show_bug.cgi?id=196919
2564         <rdar://problem/41630459>
2565
2566         Reviewed by Tim Horton.
2567
2568         Add iOS support for several new testing hooks. See below for more detail.
2569
2570         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2571         (WTR::UIScriptController::isDismissingMenu const):
2572
2573         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2574         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2575         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2576
2577         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2578         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2579         (WTR::UIScriptController::isDismissingMenu const):
2580         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2581         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2582         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2583         (WTR::InjectedBundle::didReceiveMessageToPage):
2584         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2585         (WTR::TestRunner::setAllowedMenuActions):
2586
2587         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2588         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2589         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2590         against the name of the custom action.
2591
2592         (WTR::TestRunner::installCustomMenuAction):
2593
2594         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2595         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2596         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2597         triggered.
2598
2599         (WTR::TestRunner::performCustomMenuAction):
2600
2601         Invoked when the custom menu action is triggered.
2602
2603         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2604         * WebKitTestRunner/TestController.cpp:
2605         (WTR::TestController::installCustomMenuAction):
2606         (WTR::TestController::setAllowedMenuActions):
2607         * WebKitTestRunner/TestController.h:
2608         * WebKitTestRunner/TestInvocation.cpp:
2609         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2610         (WTR::TestInvocation::performCustomMenuAction):
2611
2612         Add plumbing to call back into the injected bundle when performing the custom action.
2613
2614         * WebKitTestRunner/TestInvocation.h:
2615         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2616         (WTR::TestController::installCustomMenuAction):
2617         (WTR::TestController::setAllowedMenuActions):
2618         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2619         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2620         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2621         (-[TestRunnerWKWebView becomeFirstResponder]):
2622         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2623
2624         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2625         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2626         in the Mail app on iOS.
2627
2628         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2629         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2630         (-[TestRunnerWKWebView resetCustomMenuAction]):
2631         (-[TestRunnerWKWebView performCustomAction:]):
2632         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2633         (-[TestRunnerWKWebView _willHideMenu]):
2634         (-[TestRunnerWKWebView _didHideMenu]):
2635         * WebKitTestRunner/ios/TestControllerIOS.mm:
2636         (WTR::TestController::platformResetStateToConsistentValues):
2637
2638         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2639         if specified.
2640
2641         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2642         (WTR::UIScriptController::isDismissingMenu const):
2643
2644 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2645
2646         Allow sharing from imageSheet on an image document
2647         https://bugs.webkit.org/show_bug.cgi?id=196891
2648         <rdar://problem/25377386>
2649
2650         Reviewed by Tim Horton.
2651
2652         Test to make sure that the correct imageURL is extracted from an image element.
2653
2654         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2655         (TestWebKitAPI::TEST):
2656
2657 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2658
2659         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2660         https://bugs.webkit.org/show_bug.cgi?id=196995
2661
2662         Reviewed by Brady Eidson.
2663
2664         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2665         (TEST):
2666
2667 2019-04-16  Chris Dumez  <cdumez@apple.com>
2668
2669         URL set by document.open() is not communicated to the UIProcess
2670         https://bugs.webkit.org/show_bug.cgi?id=196941
2671         <rdar://problem/49237544>
2672
2673         Reviewed by Geoff Garen.
2674
2675         Add API test coverage.
2676
2677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2678         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2679         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2680         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2681         (TEST):
2682
2683 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2684
2685         Unreviewed, rolling out r244321.
2686         https://bugs.webkit.org/show_bug.cgi?id=196968
2687
2688         Causing all WK2 Debug builds to exit early after Assertion
2689         failures. (Requested by ShawnRoberts on #webkit).
2690
2691         Reverted changeset:
2692
2693         "URL set by document.open() is not communicated to the
2694         UIProcess"
2695         https://bugs.webkit.org/show_bug.cgi?id=196941
2696         https://trac.webkit.org/changeset/244321
2697
2698 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2699
2700         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2701         https://bugs.webkit.org/show_bug.cgi?id=196948
2702
2703         Reviewed by Zalan Bujtas.
2704
2705         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2706         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2707
2708 2019-04-15  Chris Dumez  <cdumez@apple.com>
2709
2710         URL set by document.open() is not communicated to the UIProcess
2711         https://bugs.webkit.org/show_bug.cgi?id=196941
2712         <rdar://problem/49237544>
2713
2714         Reviewed by Geoffrey Garen.
2715
2716         Add API test coverage.
2717
2718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2719         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2720         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2721         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2722         (TEST):
2723
2724 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2725
2726         Using Tools/Scripts/clean-webkit should not install requests
2727         https://bugs.webkit.org/show_bug.cgi?id=196940
2728
2729         Reviewed by Lucas Forschler.
2730
2731         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2732         existing, depending on the path autoinstalled is run through.
2733         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2734         needed.
2735         (Port.configuration_for_upload):
2736         (Port.commits_for_upload):
2737
2738 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2739
2740         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2741         https://bugs.webkit.org/show_bug.cgi?id=196773
2742
2743         Reviewed by Jer Noble.
2744
2745         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2746         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2747         (TEST):
2748
2749 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2750
2751         ews-build should clearly indicate flaky test failures
2752         https://bugs.webkit.org/show_bug.cgi?id=196947
2753
2754         Reviewed by Lucas Forschler.
2755
2756         * BuildSlaveSupport/ews-build/steps.py:
2757         (AnalyzeAPITestsResults.analyzeResults):
2758
2759 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2760
2761         InjectedBundle parameters often need initialization function called before unarchiving
2762         https://bugs.webkit.org/show_bug.cgi?id=189709
2763         <rdar://problem/44573653>
2764
2765         Reviewed by Ryosuke Niwa.
2766
2767         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2768         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2769
2770 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2771
2772         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2773         https://bugs.webkit.org/show_bug.cgi?id=196681
2774
2775         Reviewed by Darin Adler.
2776
2777         Added tests.
2778
2779         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2780         (WTF_HashSet.RemoveIf):
2781         (WTF_HashSet.RemoveIfShrinkToBestSize):
2782
2783 2019-04-15  John Wilander  <wilander@apple.com>
2784
2785         Send delayed Ad Click Attribution conversion requests to the click source
2786         https://bugs.webkit.org/show_bug.cgi?id=196838
2787         <rdar://problem/47650157>
2788
2789         Reviewed by Chris Dumez and Youenn Fablet.
2790
2791         This patch adds test infrastructure to override the default behavior in
2792         WebKit::NetworkAdClickAttribution.
2793
2794         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2795         (TestWebKitAPI::TEST):
2796         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2797         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2798         (WTR::TestRunner::dumpAdClickAttribution):
2799         (WTR::TestRunner::clearAdClickAttribution):
2800         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2801         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2802         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2803         * WebKitTestRunner/TestController.cpp:
2804         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2805         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2806         * WebKitTestRunner/TestController.h:
2807         * WebKitTestRunner/TestInvocation.cpp:
2808         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2809
2810 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2811
2812         [ews-app] status-bubble should display position in queue
2813         https://bugs.webkit.org/show_bug.cgi?id=196607
2814
2815         Reviewed by Lucas Forschler.
2816
2817         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2818         (StatusBubble._build_bubble):
2819         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2820
2821 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2822
2823         [ews-build] Do not run clean build by default on EWS builders
2824         https://bugs.webkit.org/show_bug.cgi?id=196897
2825
2826         Reviewed by Lucas Forschler.
2827
2828         * BuildSlaveSupport/ews-build/steps.py:
2829         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2830         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2831         untracked directories like WebKitBuild).
2832         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2833         untracked files/directories (like WebKitBuild).
2834
2835 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2836
2837         TestRunner::notifyDone() should be safely reentrant
2838         https://bugs.webkit.org/show_bug.cgi?id=196898
2839
2840         Reviewed by Darin Adler.
2841
2842         It is currently possible that TestRunner::notifyDone() will call itself, since
2843         notifyDone() will force a repaint, which can start executing JavaScript, which
2844         may call notifyDone() again. This can lead to test failures and flakiness.
2845         Fix this by setting the m_waitToDump flag before calling the dump() method.
2846
2847         * DumpRenderTree/mac/TestRunnerMac.mm:
2848         (TestRunner::notifyDone):
2849         (TestRunner::forceImmediateCompletion):
2850         * DumpRenderTree/win/TestRunnerWin.cpp:
2851         (TestRunner::notifyDone):
2852         (TestRunner::forceImmediateCompletion):
2853
2854 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2855
2856         [GTK][WPE] Add enable-media websetting
2857         https://bugs.webkit.org/show_bug.cgi?id=196863
2858
2859         Reviewed by Michael Catanzaro.
2860
2861         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2862         (testWebKitSettings): Add test for the enable-media web-setting.
2863
2864 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2865
2866         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2867         https://bugs.webkit.org/show_bug.cgi?id=196905
2868         <rdar://problem/49886096>
2869
2870         Reviewed by Tim Horton.
2871
2872         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2873         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2874         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2875         delay timer, we end up with this sequence of events in the problematic (failure) case:
2876
2877         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2878             ...IPC from UI to web process...
2879         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2880             ...IPC from web to UI process...
2881         (c) [UI]    Invoke completion handler for script #1
2882         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2883             ...IPC from UI to web process...
2884         (e) [Web]   Evaluate script #2 in the web process
2885         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2886
2887         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2888         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2889         #2 is run in step (e).
2890
2891         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2892         the UI process by waiting on a script message posted by the web process, after attachment updates are
2893         dispatched.
2894
2895         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2896         (TestWebKitAPI::TEST):
2897
2898 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2899
2900         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2901         https://bugs.webkit.org/show_bug.cgi?id=196909
2902
2903         Reviewed by Wenson Hsieh.
2904
2905         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2906         (TestWebKitAPI::TEST):
2907
2908 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2909
2910         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2911         https://bugs.webkit.org/show_bug.cgi?id=196880
2912
2913         Reviewed by Yusuke Suzuki.
2914
2915         Add a new function for bytecode cache tests that does not forceDiskCache
2916         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2917         test added in this patch, since the code is invalid and therefore won't be
2918         cached. It should also be useful for tests that evaluate dynamically
2919         generated code.
2920
2921         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2922         * Scripts/run-jsc-stress-tests:
2923
2924 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2925
2926         Update AudioSession route sharing policy
2927         https://bugs.webkit.org/show_bug.cgi?id=196776
2928         <rdar://problem/46501611>
2929
2930         Reviewed by Jer Noble.
2931
2932         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2933         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2934         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2935         (TestWebKitAPI::TEST):
2936
2937 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2938
2939         [iOS] Software keyboard is shown too frequently on some websites
2940         https://bugs.webkit.org/show_bug.cgi?id=195856
2941         <rdar://problem/49191395>
2942
2943         Reviewed by Darin Adler.
2944
2945         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2946
2947         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2948         (WTR::UIScriptController::setHardwareKeyboardAttached):
2949         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2950         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2951         (WTR::UIScriptController::setHardwareKeyboardAttached):
2952         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2953         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2954
2955         Additionally link against GraphicsServices in WebKitTestRunner.
2956
2957         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2958         (WTR::TestController::platformResetStateToConsistentValues):
2959         (WTR::UIScriptController::setHardwareKeyboardAttached):
2960
2961 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2962
2963         [GTK][WPE] Fix pacman install-dependencies packages
2964         https://bugs.webkit.org/show_bug.cgi?id=196817
2965
2966         Reviewed by Žan Doberšek.
2967         
2968         python3-setuptools is called python-setuptools
2969         ruby-highline is only available on AUR
2970         libv4l-devel is incorporated in v4l-utils
2971
2972         * gtk/install-dependencies:
2973         * wpe/install-dependencies:
2974
2975 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2976
2977         [GTK] REGRESSION(r243860): Many tests failing
2978         https://bugs.webkit.org/show_bug.cgi?id=196791
2979
2980         Reviewed by Joanmarie Diggs.
2981
2982         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2983         multiple documents and check that accessibility hierarchy is updated after a navigation.
2984
2985         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2986         (loadChangedCallback):
2987         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2988         (AccessibilityTest::AccessibilityTest):
2989         (AccessibilityTest::~AccessibilityTest):
2990         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2991         (AccessibilityTest::findTestServerApplication):
2992         (AccessibilityTest::findDocumentWeb):
2993         (AccessibilityTest::findRootObject):
2994         (AccessibilityTest::waitUntilChildrenRemoved):
2995         (AccessibilityTest::ensureProxy):
2996         (testAtspiBasicHierarchy):
2997         (beforeAll):
2998         (afterAll):
2999
3000 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
3001
3002         [ews-build] Handle bug titles with unicode characters
3003         https://bugs.webkit.org/show_bug.cgi?id=196802
3004
3005         Reviewed by Dewei Zhu.
3006
3007         * BuildSlaveSupport/ews-build/steps.py:
3008         (ValidatePatch._is_bug_closed):
3009
3010 2019-04-11  Michael Saboff  <msaboff@apple.com>
3011
3012         Improve the Inline Cache Stats code
3013         https://bugs.webkit.org/show_bug.cgi?id=196836
3014
3015         Reviewed by Saam Barati.
3016
3017         Added a new script to consolidate and arrange the output of --useICStats option.
3018
3019         This script merges the output from every group into one large table and sorts it from most common to
3020         least common.  It also counts the slow path GetById and PutById variants and then calculates the
3021         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
3022         Put together, this is useful to see what property accesses are not getting cached.
3023
3024         * Scripts/ic-stats.py: Added.
3025         (ICStats):
3026         (ICStats.__init__):
3027         (ICStats.parse):
3028         (ICStats.dumpStats):
3029         (usage):
3030
3031 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3032
3033         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
3034         https://bugs.webkit.org/show_bug.cgi?id=196809
3035         <rdar://49800762>
3036
3037         Reviewed by Brady Eidson.
3038
3039         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3040         (TEST):
3041
3042 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
3043
3044         requestAnimationFrame should execute before the next frame
3045         https://bugs.webkit.org/show_bug.cgi?id=177484
3046
3047         Reviewed by Simon Fraser.
3048
3049         Add trace points for the page RenderingUpdate.
3050
3051         * Tracing/SystemTracePoints.plist:
3052
3053 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3054
3055         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
3056         https://bugs.webkit.org/show_bug.cgi?id=196760
3057
3058         Reviewed by Don Olmstead.
3059
3060         vswhere.exe has been bundled since Visual Studio 2017 version
3061         15.2. We shouldn't download vswhere.exe.
3062
3063         * Scripts/build-jsc: Do not call update-vswhere.py.
3064         * Scripts/build-webkit: Ditto.
3065         * Scripts/update-vswhere.py: Removed.
3066         * Scripts/webkitdirs.pm:
3067         (requireModulesForVSWhere): Deleted.
3068         (pickCurrentVisualStudioInstallation): Deleted.
3069         (visualStudioInstallDirVSWhere): Return the latest installed VS
3070         installation path by using the bundled vswhere.exe.
3071         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
3072         (visualStudioInstallDirFallback): Removed.
3073
3074 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
3075
3076         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
3077         https://bugs.webkit.org/show_bug.cgi?id=196780
3078
3079         Reviewed by Alexey Proskuryakov.
3080
3081         * BuildSlaveSupport/ews-build/steps.py:
3082         * BuildSlaveSupport/ews-build/steps_unittest.py:
3083
3084 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3085
3086         Add SPI WKNavigationResponse._downloadAttribute
3087         https://bugs.webkit.org/show_bug.cgi?id=196755
3088         <rdar://49587365>
3089
3090         Reviewed by Brady Eidson.
3091
3092         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3093         (-[NavigationResponseTestDelegate navigationResponse]):
3094         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
3095         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
3096         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3097         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
3098         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3099         (readRequest):
3100         (writeResponse):
3101         (TEST):
3102
3103 2019-04-10  Tim Horton  <timothy_horton@apple.com>
3104
3105         Add modern API for overriding the page's specified viewport configuration
3106         https://bugs.webkit.org/show_bug.cgi?id=167734
3107         <rdar://problem/30331795>
3108
3109         Reviewed by Simon Fraser.
3110
3111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3112         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
3113
3114 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
3115
3116         Add support for incremental bytecode cache updates
3117         https://bugs.webkit.org/show_bug.cgi?id=195000
3118
3119         Reviewed by Filip Pizlo.
3120
3121         Exit when the initial run to generate bytecode fails.
3122
3123         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3124
3125 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3126
3127         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
3128         https://bugs.webkit.org/show_bug.cgi?id=196744
3129         <rdar://49415309>
3130
3131         Reviewed by Chris Dumez.
3132
3133         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3134         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3135
3136 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3137
3138         Add a way to opt into modern compatibility mode in layout tests
3139         https://bugs.webkit.org/show_bug.cgi?id=196770
3140         <rdar://problem/49777550>
3141
3142         Reviewed by Antoine Quint.
3143
3144         Add a new test option to enable modern compatibility mode in layout tests.
3145
3146         * WebKitTestRunner/TestController.cpp:
3147         (WTR::updateTestOptionsFromTestHeader):
3148         * WebKitTestRunner/TestController.h:
3149         * WebKitTestRunner/TestOptions.h:
3150         (WTR::TestOptions::hasSameInitializationOptions const):
3151         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3152         (WTR::TestController::platformCreateWebView):
3153         (WTR::TestController::enableModernCompatibilityMode):
3154
3155 2019-04-10  Andy Estes  <aestes@apple.com>
3156
3157         Try to fix the 32-bit watchOS build.
3158
3159         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3160         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3161
3162 2019-04-10  Antoine Quint  <graouts@apple.com>
3163
3164         Enable Pointer Events on watchOS
3165         https://bugs.webkit.org/show_bug.cgi?id=196771
3166         <rdar://problem/49040909>
3167
3168         Reviewed by Dean Jackson.
3169
3170         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3171
3172 2019-04-10  Philippe Normand  <pnormand@igalia.com>
3173
3174         Unreviewed. Fix WPE accessibility tests after r244059.
3175
3176         We are failing to load the injected bundle due to undefined symbol
3177         AccessibilityUIElement::replaceTextInRange().
3178
3179         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3180         (WTR::AccessibilityUIElement::replaceTextInRange):
3181
3182 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
3183
3184         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
3185         https://bugs.webkit.org/show_bug.cgi?id=196727
3186
3187         Reviewed by Fujii Hironori.
3188
3189         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3190         (WebKitBrowserWindow::create):
3191
3192 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
3193
3194         [ews-build] Add unit tests for PrintConfiguration
3195         https://bugs.webkit.org/show_bug.cgi?id=196752
3196
3197         Reviewed by Dewei Zhu.
3198
3199         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3200
3201 2019-04-09  Keith Rollin  <krollin@apple.com>
3202
3203         Unreviewed build maintenance -- update .xcfilelists.
3204
3205         * DumpRenderTree/DerivedSources-input.xcfilelist:
3206         * DumpRenderTree/DerivedSources-output.xcfilelist:
3207
3208 2019-04-09  Zalan Bujtas  <zalan@apple.com>
3209
3210         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
3211         https://bugs.webkit.org/show_bug.cgi?id=196743
3212         <rdar://problem/43897551>
3213
3214         Reviewed by Tim Horton.
3215
3216         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
3217         (TEST):
3218
3219 2019-04-09  Youenn Fablet  <youenn@apple.com>
3220
3221         Close service worker database on network process suspension
3222         https://bugs.webkit.org/show_bug.cgi?id=196623
3223         <rdar://problem/48930869>
3224
3225         Reviewed by Alex Christensen.
3226
3227         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3228
3229 2019-04-09  Daniel Bates  <dabates@apple.com>
3230
3231         [iPad] Should open popover when the spacebar is pressed
3232         https://bugs.webkit.org/show_bug.cgi?id=196360
3233         <rdar://problem/49389129>
3234
3235         Reviewed by Brent Fulgham.
3236
3237         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
3238
3239         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3240         (WTR::UIScriptController::isShowingPopover const): Added.
3241         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3242         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3243         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3244         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3245         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3246         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
3247         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
3248         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
3249         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
3250         (WTR::UIScriptController::isShowingPopover const): Added.
3251         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3252         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3253         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3254         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3255         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3256         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
3257         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
3258         (-[TestRunnerWKWebView _willPresentPopover]): Added.
3259         (-[TestRunnerWKWebView _didDismissPopover]): Added.
3260         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3261         (WTR::UIScriptController::isShowingPopover const): Added.
3262         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3263         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3264
3265 2019-04-09  Alex Christensen  <achristensen@webkit.org>
3266
3267         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3268         https://bugs.webkit.org/show_bug.cgi?id=196665
3269         <rdar://45115669>
3270
3271         Reviewed by Geoff Garen.
3272
3273         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3274         (goBack):
3275         (+[SimpleLookupContext sharedLookupContext]):
3276         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3277         (TEST):
3278         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3279         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3280
3281 2019-04-09  John Wilander  <wilander@apple.com>
3282
3283         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
3284         https://bugs.webkit.org/show_bug.cgi?id=196558
3285         <rdar://problem/47650245>
3286
3287         Reviewed by Youenn Fablet.
3288
3289         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3290         (TestWebKitAPI::TEST):
3291             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
3292
3293 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
3294
3295         [CMake] Apple builds should use ICU_INCLUDE_DIRS
3296         https://bugs.webkit.org/show_bug.cgi?id=196720
3297
3298         Reviewed by Konstantin Tokarev.
3299
3300         * TestWebKitAPI/PlatformMac.cmake:
3301
3302 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
3303
3304         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
3305         https://bugs.webkit.org/show_bug.cgi?id=196694
3306         <rdar://problem/48388734>
3307
3308         Rubber-stamped by Aakash Jain.
3309
3310         * Scripts/webkitpy/port/image_diff.py:
3311         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
3312         * Scripts/webkitpy/port/server_process.py:
3313         (ServerProcess.has_available_stdout): Check if stdout has data in it.
3314         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3315         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
3316         * Scripts/webkitpy/port/server_process_mock.py:
3317         (MockServerProcess.has_available_stdout):
3318         * Scripts/webkitpy/port/server_process_unittest.py:
3319         (TestServerProcess.serial_test_basic):
3320
3321 2019-04-09  Jer Noble  <jer.noble@apple.com>
3322
3323         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3324         https://bugs.webkit.org/show_bug.cgi?id=196097
3325
3326         Reviewed by Eric Carlson.
3327
3328         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3329
3330         * DumpRenderTree/mac/DumpRenderTree.mm:
3331         (resetWebPreferencesToConsistentValues):
3332         * WebKitTestRunner/TestController.cpp:
3333         (WTR::TestController::resetPreferencesToConsistentValues):
3334
3335 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3336
3337         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3338         https://bugs.webkit.org/show_bug.cgi?id=196690
3339
3340         Reviewed by Michael Catanzaro.
3341
3342         * QueueStatusServer/config/queues.py:
3343         * Scripts/webkitpy/common/config/ews.json:
3344         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3345         (test_ews_name):
3346
3347 2019-04-09  Chris Dumez  <cdumez@apple.com>
3348
3349         Loads using loadHTMLString() cause flashing when process-swapping
3350         https://bugs.webkit.org/show_bug.cgi?id=196714
3351         <rdar://problem/49637354>
3352
3353         Reviewed by Antti Koivisto.
3354
3355         Add API test coverage.
3356
3357         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3358
3359 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3360
3361         Unreviewed. Fix ATK accessibility tests after r244059.
3362
3363         We are failing to load the injected bundle due to undefined symbol
3364         AccessibilityUIElement::replaceTextInRange().
3365
3366         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3367         (WTR::AccessibilityUIElement::replaceTextInRange):
3368
3369 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3370
3371         AX: Support API: accessibilityReplaceRange:withText
3372         https://bugs.webkit.org/show_bug.cgi?id=196636
3373
3374         Unreviewed build fix for Windows port.
3375
3376         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3377         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3378
3379 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3380
3381         [CMake][WinCairo] Separate copied headers into different directories
3382         https://bugs.webkit.org/show_bug.cgi?id=196655
3383
3384         Reviewed by Michael Catanzaro.
3385
3386         * DumpRenderTree/CMakeLists.txt:
3387         * MiniBrowser/win/CMakeLists.txt:
3388         * TestWebKitAPI/CMakeLists.txt:
3389         * TestWebKitAPI/PlatformWin.cmake:
3390
3391 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3392
3393         Log stack-trace for run-webkit-tests when interrupted
3394         https://bugs.webkit.org/show_bug.cgi?id=176393
3395         <rdar://problem/34262310>
3396
3397         Reviewed by Lucas Forschler.
3398
3399         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3400         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3401         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3402         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3403         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3404         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3405         (main): Set handlers to log stack trace on interruption.
3406
3407 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3408
3409         AX: Support API: accessibilityReplaceRange:withText
3410         https://bugs.webkit.org/show_bug.cgi?id=196636
3411
3412         Unreviewed build fix for Windows port.
3413
3414         * DumpRenderTree/AccessibilityUIElement.cpp:
3415         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3416
3417 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3418
3419         [ews-build] Scripts using Buildbot API have CORS error
3420         https://bugs.webkit.org/show_bug.cgi?id=196709
3421
3422         Reviewed by Alexey Proskuryakov.
3423
3424         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3425
3426 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3427
3428         AX: Support API: accessibilityReplaceRange:withText
3429         https://bugs.webkit.org/show_bug.cgi?id=196636
3430
3431         Reviewed by Daniel Bates.
3432
3433         * DumpRenderTree/AccessibilityUIElement.cpp:
3434         (replaceTextInRangeCallback):
3435         (AccessibilityUIElement::replaceTextInRange):
3436         (AccessibilityUIElement::getJSClass):
3437         * DumpRenderTree/AccessibilityUIElement.h:
3438         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3439         (AccessibilityUIElement::replaceTextInRange):
3440         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3441         (AccessibilityUIElement::replaceTextInRange):
3442         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3443         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3444         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3445         (WTR::AccessibilityUIElement::replaceTextInRange):
3446         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3447         (WTR::AccessibilityUIElement::replaceTextInRange):
3448
3449 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3450
3451         [iOS] Do not allow starting selection drags when selection views are not visible
3452         https://bugs.webkit.org/show_bug.cgi?id=196686
3453         <rdar://problem/49399192>
3454
3455         Reviewed by Tim Horton.
3456
3457         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3458         also add some new API tests to cover scenarios where the web view is not first responder.
3459
3460         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3461         (TestWebKitAPI::TEST):
3462         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3463
3464         Add a switch to optionally make the web view first responder when starting the simulated drag.
3465
3466         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3467         (-[DragAndDropSimulator initWithWebView:]):
3468         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3469
3470 2019-04-08  Justin Fan  <justin_fan@apple.com>
3471
3472         [Web GPU] Fix Web GPU experimental feature on iOS
3473         https://bugs.webkit.org/show_bug.cgi?id=196632
3474
3475         Reviewed by Myles C. Maxfield.
3476
3477         Properly make Web GPU available on iOS 11+.
3478
3479         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3480
3481 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3482
3483         [ews-build] Do not upload archive when Compile Fails
3484         https://bugs.webkit.org/show_bug.cgi?id=196674
3485
3486         Reviewed by Alexey Proskuryakov.
3487
3488         * BuildSlaveSupport/ews-build/factories.py:
3489         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3490         * BuildSlaveSupport/ews-build/steps.py:
3491         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3492         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3493         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3494
3495 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3496
3497         Enable DFG on MIPS
3498         https://bugs.webkit.org/show_bug.cgi?id=196689
3499
3500         Reviewed by Žan Doberšek.
3501
3502         Since the bytecode change, we enabled the baseline JIT on mips in
3503         r240432, but DFG is still missing. With this change, all tests are
3504         passing on a ci20 board.
3505
3506         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3507
3508 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3509
3510         [Flatpak] Second run update-webkitwpe-flatpak fails
3511         https://bugs.webkit.org/show_bug.cgi?id=192702
3512
3513         Reviewed by Carlos Garcia Campos.
3514
3515         * flatpak/flatpakutils.py:
3516         (FlatpakObject.flatpak): Fix typo.
3517         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3518         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3519
3520 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3521
3522         [GTK][WPE] outlook.live.com displays old-fashioned UI
3523         https://bugs.webkit.org/show_bug.cgi?id=196642
3524
3525         Reviewed by Carlos Garcia Campos.
3526
3527         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3528         (TestWebKitAPI::TEST): New Mac platform quirk test.
3529
3530 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3531
3532         Unreviewed, rolling out r243956.
3533         https://bugs.webkit.org/show_bug.cgi?id=196688
3534
3535         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
3536         by aakashjain on #webkit).
3537
3538         Reverted changeset:
3539
3540         "Clicking "Go Back" from a safe browsing warning from an
3541         iframe should navigate the WKWebView back to the previous
3542         page"
3543         https://bugs.webkit.org/show_bug.cgi?id=196665
3544         https://trac.webkit.org/changeset/243956
3545
3546 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
3547
3548         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
3549         https://bugs.webkit.org/show_bug.cgi?id=196669
3550
3551         Reviewed by Geoffrey Garen.
3552
3553         Added three new unit tests for WeakHashSet.
3554
3555         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3556         (WTF_WeakPtr.WeakHashSetConstObjects):
3557         (WTF_WeakPtr.WeakHashSetComputesEmpty):
3558         (WTF_WeakPtr.WeakHashSetComputeSize):
3559
3560 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3561
3562         Hide next and previous form control buttons when WKWebView is editable
3563         https://bugs.webkit.org/show_bug.cgi?id=196672
3564         <rdar://problem/35625321>
3565
3566         Reviewed by Tim Horton.
3567
3568         Add a new API test.
3569
3570         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3571         (-[TestWKWebView lastTrailingBarButtonGroup]):
3572         (TestWebKitAPI::TEST):
3573         * TestWebKitAPI/ios/UIKitSPI.h:
3574
3575 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3576
3577         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3578         https://bugs.webkit.org/show_bug.cgi?id=196077
3579         <rdar://problem/49108202>
3580
3581         Reviewed by Chris Dumez.
3582
3583         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3584         on new web view.
3585
3586         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3587
3588 2019-04-05  Saam Barati  <sbarati@apple.com>
3589
3590         Make compare-results understand MotionMark
3591         https://bugs.webkit.org/show_bug.cgi?id=196666
3592
3593         Reviewed by Yusuke Suzuki.
3594
3595         * Scripts/compare-results:
3596         (PLT5Results):
3597         (detectMotionMark):
3598         (detectMotionMark1_1):
3599         (motionMarkResults):
3600         (motionMark1_1Results):
3601         (detectBenchmark):
3602         (biggerIsBetter):
3603         (main):
3604
3605 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3606
3607         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3608         https://bugs.webkit.org/show_bug.cgi?id=196665
3609         <rdar://45115669>
3610
3611         Reviewed by Geoff Garen.
3612
3613         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3614         (goBack):
3615         (+[SimpleLookupContext sharedLookupContext]):
3616         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3617         (TEST):
3618         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3619         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3620
3621 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3622
3623         [ews-build] Add configuration and architecture for windows builders
3624         https://bugs.webkit.org/show_bug.cgi?id=196660
3625
3626         Reviewed by Lucas Forschler.
3627
3628         * BuildSlaveSupport/ews-build/config.json:
3629
3630 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3631
3632         webkitpy: Don't run subsequent rounds if interrupted
3633         https://bugs.webkit.org/show_bug.cgi?id=196646
3634
3635         Reviewed by Aakash Jain.
3636
3637         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3638         (Manager.run): Bail out if interrupted.
3639
3640 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3641
3642         Test sessionStorage in PSON private browsing mode
3643         https://bugs.webkit.org/show_bug.cgi?id=196561
3644
3645         Reviewed by Alex Christensen.
3646
3647         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3648
3649 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3650
3651         Unreviewed, rolling out r243833.
3652         https://bugs.webkit.org/show_bug.cgi?id=196645
3653
3654         This change breaks build of WPE and GTK ports (Requested by
3655         annulen on #webkit).
3656
3657         Reverted changeset:
3658
3659         "[CMake][WTF] Mirror XCode header directories"
3660         https://bugs.webkit.org/show_bug.cgi?id=191662
3661         https://trac.webkit.org/changeset/243833
3662
3663 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3664
3665         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3666         https://bugs.webkit.org/show_bug.cgi?id=196635
3667
3668         Reviewed by Antti Koivisto.
3669         
3670         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3671         for a test to enable async frame scrolling via:
3672             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3673         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3674         
3675         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3676
3677         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3678         (WTR::InjectedBundle::beginTesting):
3679         * WebKitTestRunner/TestController.cpp:
3680         (WTR::TestController::resetPreferencesToConsistentValues):
3681
3682 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3683
3684         Use a correct LC_RPATH when building with ASan
3685         https://bugs.webkit.org/show_bug.cgi?id=196576
3686
3687         Reviewed by David Kilzer.
3688
3689         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3690         so that ../Frameworks is checked. This is simpler and more reliable than updating
3691         each SPC service xcconfig.
3692
3693 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3694
3695         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3696         https://bugs.webkit.org/show_bug.cgi?id=196629
3697
3698         Reviewed by Lucas Forschler.
3699
3700         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3701
3702 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3703
3704         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3705         https://bugs.webkit.org/show_bug.cgi?id=196618
3706
3707         Reviewed by Lucas Forschler.
3708
3709         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3710         (StatusBubble): Added QUEUE_TRIGGERS.
3711         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3712         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3713         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3714         its parent(builder).
3715
3716 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3717
3718         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3719         https://bugs.webkit.org/show_bug.cgi?id=196625
3720
3721         Reviewed by Lucas Forschler.
3722
3723         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3724         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3725
3726 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3727
3728         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3729         https://bugs.webkit.org/show_bug.cgi?id=196630
3730
3731         Reviewed by Wenson Hsieh.
3732
3733         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3734
3735 2019-04-04  Youenn Fablet  <youenn@apple.com>
3736
3737         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3738         https://bugs.webkit.org/show_bug.cgi?id=196543
3739
3740         Reviewed by Alex Christensen.
3741
3742         * WebKitTestRunner/TestController.cpp:
3743         (WTR::TestController::generatePageConfiguration):
3744
3745 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3746
3747         [ews-app] Status bubble should not display skipped buildbot steps
3748         https://bugs.webkit.org/show_bug.cgi?id=196584
3749
3750         Reviewed by Lucas Forschler.
3751
3752         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3753
3754 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3755
3756         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3757         https://bugs.webkit.org/show_bug.cgi?id=196620
3758
3759         Reviewed by Lucas Forschler.
3760
3761         * BuildSlaveSupport/ews-app/ews/config.py:
3762
3763 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3764
3765         [Win] DumpRenderTreeWatchDog.py is not checked into source
3766         https://bugs.webkit.org/show_bug.cgi?id=196567
3767         <rdar://problem/49525901>
3768
3769         Reviewed by Lucas Forschler.
3770
3771         This script is used on Win EWS bots to terminate hanging DRT processes.
3772
3773         * EWSTools/dumprendertreewatchdog.py: Added.
3774
3775 2019-04-04  Chris Dumez  <cdumez@apple.com>
3776
3777         Unreviewed, roll out r243858 which made tests time out.
3778
3779         Disable new API tests on Windows instead.
3780
3781         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3782         (TestWebKitAPI::TEST):
3783
3784 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3785
3786         [ATK] Cleanup WebPageAccessibilityObjectAtk
3787         https://bugs.webkit.org/show_bug.cgi?id=196537
3788
3789         Reviewed by Michael Catanzaro.
3790
3791         Also consider files under atk directories as exceptions for GObject conventions.
3792
3793         * Scripts/webkitpy/style/checkers/cpp.py:
3794         (check_identifier_name_in_declaration):
3795
3796 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3797
3798         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3799         https://bugs.webkit.org/show_bug.cgi?id=196588
3800         <rdar://problem/49365787>
3801
3802         Unreviewed build fix for Windows port.
3803
3804         error C3861: 'kill': identifier not found
3805
3806         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3807         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3808
3809 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3810
3811         [ews-build] Cancel build and similar operations should have authentication
3812         https://bugs.webkit.org/show_bug.cgi?id=196520
3813
3814         Reviewed by Dewei Zhu.
3815
3816         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3817         environment variables.
3818
3819 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3820
3821         [ews-build] Do not trigger queues which are not in production yet
3822         https://bugs.webkit.org/show_bug.cgi?id=196581
3823
3824         Reviewed by Dewei Zhu.
3825
3826         * BuildSlaveSupport/ews-build/config.json:
3827
3828 2019-04-03  Chris Dumez  <cdumez@apple.com>
3829
3830         Unreviewed, fix typo in the name of API test added in r243848.
3831
3832         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3833         (TestWebKitAPI::TEST):
3834
3835 2019-04-03  Chris Dumez  <cdumez@apple.com>
3836
3837         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3838         https://bugs.webkit.org/show_bug.cgi?id=196588
3839         <rdar://problem/49365787>
3840
3841         Reviewed by Ryosuke Niwa.
3842
3843         Add API test coverage.
3844
3845         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3846         (TestWebKitAPI::nullJavaScriptCallback):
3847         (TestWebKitAPI::didCrashCheckFrames):
3848         (TestWebKitAPI::TEST):
3849
3850 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3851
3852         run-webkit-tests: Upload test results (new results database)
3853         https://bugs.webkit.org/show_bug.cgi?id=196577
3854         <rdar://problem/34841155>
3855
3856         Reviewed by Lucas Forschler.
3857
3858         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3859         (Manager.run): Upload results after each device shard, since the configuration will be
3860         different for each device.
3861         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3862         uploaded to a results database.
3863         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3864         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3865
3866 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3867
3868         -apple-trailing-word is needed for browser detection
3869         https://bugs.webkit.org/show_bug.cgi?id=196575
3870
3871         Unreviewed.
3872
3873         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3874
3875 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3876
3877         [CMake][WTF] Mirror XCode header directories
3878         https://bugs.webkit.org/show_bug.cgi?id=191662
3879
3880         Reviewed by Konstantin Tokarev.
3881
3882         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3883         builds.
3884
3885         * CMakeLists.txt:
3886         * DumpRenderTree/CMakeLists.txt:
3887         * DumpRenderTree/PlatformWin.cmake:
3888         * MiniBrowser/win/CMakeLists.txt:
3889         * TestWebKitAPI/CMakeLists.txt:
3890         * TestWebKitAPI/PlatformWin.cmake:
3891         * WebKitTestRunner/PlatformGTK.cmake:
3892         * WebKitTestRunner/PlatformWin.cmake:
3893
3894 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3895
3896         [ews-app] Status bubble should not display certain infrastructure status messages
3897         https://bugs.webkit.org/show_bug.cgi?id=196550
3898
3899         Reviewed by Lucas Forschler.
3900
3901         Do not display the steps which are un-needed for end-user. This information is still avaiable
3902         if the user click on the bubble and look at the Buildbot build.
3903         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3904         (StatusBubble._steps_messages):
3905         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3906
3907 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3908
3909         [ews-build] Use https for sending data to ews-app
3910         https://bugs.webkit.org/show_bug.cgi?id=196492
3911
3912         Reviewed by Lucas Forschler.
3913
3914         * BuildSlaveSupport/ews-build/events.py:
3915
3916 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3917
3918         Remove support for -apple-trailing-word
3919         https://bugs.webkit.org/show_bug.cgi?id=196525
3920
3921         Reviewed by Zalan Bujtas.
3922
3923         This CSS property is nonstandard and not used.
3924
3925         * Scripts/webkitperl/FeatureList.pm:
3926         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3927
3928 2019-04-03  Youenn Fablet  <youenn@apple.com>
3929
3930         Add a test for DOMCache on multiple browsing in case of private browsing
3931         https://bugs.webkit.org/show_bug.cgi?id=196524
3932
3933         Reviewed by Alex Christensen.
3934
3935         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3936         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3937
3938 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3939
3940         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3941         https://bugs.webkit.org/show_bug.cgi?id=196540
3942
3943         Reviewed by Aakash Jain.
3944
3945         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3946
3947 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3948
3949         Add plumbing for a compatibility mode preference in WebKit
3950         https://bugs.webkit.org/show_bug.cgi?id=196005
3951
3952         Reviewed by Tim Horton.
3953
3954         Add new API tests.
3955
3956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3957         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3958
3959 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3960
3961         [WPE][GTK] Update libsrtp dependency package for Debian
3962         https://bugs.webkit.org/show_bug.cgi?id=196528
3963
3964         Reviewed by Frédéric Wang.
3965
3966         * gtk/install-dependencies:
3967         * wpe/install-dependencies:
3968
3969 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3970
3971         [WK2] Add support for Window's beforeprint / afterprint events
3972         https://bugs.webkit.org/show_bug.cgi?id=196478
3973         <rdar://problem/49535124>
3974
3975         Unreviewed build fix for MSVC.
3976
3977         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3978
3979         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3980
3981         * WebKitTestRunner/TestController.cpp:
3982         (WTR::printFrame): Use int and float literals.
3983
3984 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3985
3986         [ews-build] Reassign bots to queues
3987
3988         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3989
3990 2019-04-02  Chris Dumez  <cdumez@apple.com>
3991
3992         [WK2] Add support for Window's beforeprint / afterprint events
3993         https://bugs.webkit.org/show_bug.cgi?id=196478
3994
3995         Reviewed by Alex Christensen.
3996
3997         Add minimal implementation for printFrame in WebKitTestRunner.
3998
3999         * WebKitTestRunner/TestController.cpp:
4000         (WTR::printFrame):
4001         (WTR::TestController::createOtherPage):
4002         (WTR::TestController::createWebViewWithOptions):
4003
4004 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
4005
4006         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
4007         https://bugs.webkit.org/show_bug.cgi?id=196491
4008
4009         Reviewed by Lucas Forschler.
4010
4011         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4012
4013 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
4014
4015         [ews-build] Configure buildbot try credentials in environment variables
4016         https://bugs.webkit.org/show_bug.cgi?id=196501
4017
4018         Reviewed by Lucas Forschler.
4019
4020         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
4021         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
4022         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
4023
4024 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
4025
4026         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
4027         https://bugs.webkit.org/show_bug.cgi?id=196496
4028         <rdar://problem/49521634>
4029
4030         Reviewed by Chris Dumez.
4031
4032         Add new API tests (see WebKit ChangeLog for more detail).
4033
4034         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4035         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4036         (TEST):
4037
4038 2019-04-02  David Kilzer  <ddkilzer@apple.com>
4039
4040         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
4041         <https://webkit.org/b/196499>
4042
4043         Reviewed by Alexey Proskuryakov.
4044
4045         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
4046         ENABLE_ADDRESS_SANITIZER.
4047
4048 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
4049
4050         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
4051         https://bugs.webkit.org/show_bug.cgi?id=182757
4052
4053         Reviewed by Don Olmstead.
4054
4055         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
4056         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
4057
4058 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
4059
4060         run-api-tests: Upload test results
4061         https://bugs.webkit.org/show_bug.cgi?id=196323
4062         <rdar://problem/49356714>
4063
4064         Reviewed by Lucas Forschler.
4065
4066         * Scripts/webkitpy/api_tests/manager.py:
4067         (Manager):
4068         (Manager.run): Upload results to a results database.
4069         * Scripts/webkitpy/api_tests/run_api_tests.py:
4070         (parse_args): Add upload arguments.
4071         * Scripts/webkitpy/port/base.py:
4072         (Port):
4073         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
4074         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
4075         with commits from any other associated repositories.
4076         * Scripts/webkitpy/port/device.py:
4077         (Device):
4078         (Device.build_version): Access build_versoin of underlying platform device.
4079         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4080         (IOSSimulatorTest):
4081         (IOSSimulatorTest.test_configuration_for_upload):
4082         * Scripts/webkitpy/port/device_port.py:
4083         (DevicePort):
4084         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
4085         the same as the machine uploading results.
4086         * Scripts/webkitpy/port/mac.py:
4087         (MacPort):
4088         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
4089         * Scripts/webkitpy/port/mac_unittest.py:
4090         (MacTest):
4091         (MacTest.test_configuration_for_upload):
4092         * Scripts/webkitpy/xcode/simulated_device.py:
4093         (SimulatedDeviceManager._create_device_with_runtime):
4094         (SimulatedDevice.__init__): Create simulated device with a build_version.
4095         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
4096         (test_existing_simulator):
4097
4098 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4099
4100         Remove extra newline characters (Follow-up fix to r243707)
4101
4102         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4103
4104 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4105
4106         [ews-app] Use API_KEY to accept results data
4107         https://bugs.webkit.org/show_bug.cgi?id=196461
4108
4109         Reviewed by Dewei Zhu.
4110
4111         * BuildSlaveSupport/ews-app/ews/views/results.py:
4112         (Results.post): Validate EWS_API_KEY before accepting any data.
4113         * BuildSlaveSupport/ews-build/events.py:
4114         (Events.sendData): Send EWS_API_KEY if available along with event data.
4115
4116 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
4117
4118         Unable to copy and paste a PDF from Notes into Mail compose body
4119         https://bugs.webkit.org/show_bug.cgi?id=196442
4120         <rdar://problem/48573098>
4121
4122         Reviewed by Tim Horton.
4123
4124         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
4125         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
4126         to be specified on the item providers.
4127
4128         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4129         (TestWebKitAPI::mapItemForTesting):
4130         (TestWebKitAPI::contactItemForTesting):
4131
4132 2019-04-01  Tim Horton  <timothy_horton@apple.com>
4133
4134         Make UIWKDocumentContext rects per-character instead of per-word
4135         https://bugs.webkit.org/show_bug.cgi?id=196459
4136
4137         Reviewed by Wenson Hsieh.
4138
4139         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4140         (TEST):
4141         Adjust test results due to switching to per-character rects.
4142
4143 2019-04-01  Chris Dumez  <cdumez@apple.com>
4144
4145         UIProcess crash when a prewarmed process is terminated
4146         https://bugs.webkit.org/show_bug.cgi?id=196451
4147         <rdar://problem/49245471>
4148
4149         Reviewed by Geoffrey Garen.
4150
4151         Add API test coverage.
4152
4153         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
4154         (TEST):
4155
4156 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4157
4158         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
4159         https://bugs.webkit.org/show_bug.cgi?id=196449
4160
4161         Reviewed by Lucas Forschler.
4162
4163         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4164         (StatusBubble.get_os_details): Method to get OS and Xcode details.
4165         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
4166         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
4167
4168 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4169
4170         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
4171         https://bugs.webkit.org/show_bug.cgi?id=196444
4172
4173         Reviewed by Lucas Forschler.
4174
4175         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
4176
4177 2019-04-01  Alex Christensen  <achristensen@webkit.org>
4178
4179         Add SPI to canonicalize NSURLs with WTF::URL
4180         https://bugs.webkit.org/show_bug.cgi?id=196415
4181         <rdar://problem/44980271>
4182
4183         Reviewed by Darin Adler.
4184
4185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4186         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
4187         (TestWebKitAPI::TEST):
4188
4189 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
4190
4191         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
4192         https://bugs.webkit.org/show_bug.cgi?id=196441
4193
4194         Reviewed by Carlos Garcia Campos.
4195
4196         Don't cache the wpe_view_backend object that might not exist yet at the
4197         time of EventSenderProxy constructor invocation, but instead retrieve
4198         that object whenever it's required for event dispatching. This should
4199         avoid crashes in this constructor now that it's invoked before any
4200         PlatformWindow has been set up (as changed in r243496).
4201
4202         * WebKitTestRunner/EventSenderProxy.h:
4203         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
4204         (WTR::viewBackend):
4205         (WTR::EventSenderProxy::EventSenderProxy):
4206         (WTR::EventSenderProxy::mouseDown):
4207         (WTR::EventSenderProxy::mouseUp):
4208         (WTR::EventSenderProxy::mouseMoveTo):
4209         (WTR::EventSenderProxy::mouseScrollBy):
4210         (WTR::EventSenderProxy::keyDown):
4211         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
4212
4213 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
4214
4215         [Win][WebKit] MiniBrowser should support high DPI display
4216         https://bugs.webkit.org/show_bug.cgi?id=196391
4217
4218         Reviewed by Alex Christensen.
4219
4220         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4221         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
4222         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
4223         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
4224
4225 2019-03-31  Sam Weinig  <weinig@apple.com>
4226
4227         Remove more i386 specific configurations
4228         https://bugs.webkit.org/show_bug.cgi?id=196430
4229
4230         Reviewed by Alexey Proskuryakov.
4231
4232         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4233         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
4234
4235 2019-03-31  Andy Estes  <aestes@apple.com>
4236
4237         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
4238         https://bugs.webkit.org/show_bug.cgi?id=196433
4239         <rdar://problem/49293305>
4240
4241         Reviewed by Tim Horton.
4242
4243         Enhanced API test coverage to include all navigation response policy decisions in both
4244         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
4245
4246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4247         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
4248         (TestWebKitAPI::TEST):
4249         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
4250         (readFile):
4251         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
4252         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
4253         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4254         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4255         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4256         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
4257         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
4258         (-[QuickLookDelegate _downloadDidStart:]):
4259         (-[QuickLookDelegate _download:didReceiveResponse:]):
4260         (-[QuickLookDelegate _download:didReceiveData:]):
4261         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4262         (-[QuickLookDelegate _downloadDidFinish:]):
4263         (-[QuickLookDelegate _download:didFailWithError:]):
4264         (-[QuickLookDelegate _downloadDidCancel:]):
4265         (-[QuickLookDelegate verifyDownload]):
4266         (runTest):
4267         (runTestDecideBeforeLoading):
4268         (runTestDecideAfterLoading):
4269         (TEST):
4270         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4271         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4272         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
4273         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
4274         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
4275         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
4276         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
4277         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
4278         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
4279         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
4280         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
4281         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
4282         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
4283         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
4284
4285 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
4286
4287         [CMake] add testdfg as target with build-jsc
4288         https://bugs.webkit.org/show_bug.cgi?id=196393
4289
4290         Reviewed by Saam Barati.
4291
4292         Added testdfg as one of the targets to build when
4293         using CMake.
4294
4295         * Scripts/build-jsc:
4296
4297 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
4298
4299         Delete WebMetal implementation in favor of WebGPU
4300         https://bugs.webkit.org/show_bug.cgi?id=195418
4301
4302         Reviewed by Dean Jackson.
4303
4304         * DumpRenderTree/mac/DumpRenderTree.mm:
4305         (enableExperimentalFeatures):
4306         (resetWebPreferencesToConsistentValues):
4307         * Scripts/webkitperl/FeatureList.pm:
4308         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4310         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
4311         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
4312         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
4313         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
4314         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.