[WHLSL] It shouldn’t be possible to use ternary expressions as l-values
[WebKit-https.git] / Tools / ChangeLog
1 2018-09-24  Thomas Denney  <tdenney@apple.com>
2
3         [WHLSL] It shouldn’t be possible to use ternary expressions as l-values
4         https://bugs.webkit.org/show_bug.cgi?id=189290
5
6         Reviewed by Myles C. Maxfield.
7
8         It is no longer possible for a ternary expression to be treated as an
9         l-value. This patch adds several test cases to verify that this is the
10         case.
11
12         * WebGPUShadingLanguageRI/Checker.js:
13         (Checker.prototype.visitTernaryExpression): No longer check isLValue.
14         * WebGPUShadingLanguageRI/NormalUsePropertyResolver:
15         (NormalUsePropertyResolver.visitTernaryExpression): Deleted.
16         * WebGPUShadingLanguageRI/Rewriter.js:
17         (Rewriter.prototype.visitTernaryExpression): No longer copy isLValue.
18         * WebGPUShadingLanguageRI/TernaryExpression.js:
19         (TernaryExpression):
20         (TernaryExpression.prototype.get elseExpression):
21         (TernaryExpression.prototype.get isLValue): Deleted.
22         (TernaryExpression.prototype.set isLValue): Deleted.
23         * WebGPUShadingLanguageRI/Test.js:
24         (tests.ternaryExpression): Add checks for failure if a failure is used
25         as an l-value.
26         (ternaryExpressionIsLValue.node.TernaryExpressionVisitor.prototype.visitTernaryExpression): Deleted.
27         (ternaryExpressionIsLValue.node.TernaryExpressionVisitor): Deleted.
28         (tests.ternaryExpressionIsLValue): Deleted.
29
30 2018-09-24  Jer Noble  <jer.noble@apple.com>
31
32         SharedBuffer should have an equality test
33         https://bugs.webkit.org/show_bug.cgi?id=189919
34
35         Reviewed by Alex Christensen.
36
37         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
38         (TestWebKitAPI::TEST_F):
39
40 2018-09-24  Alex Christensen  <achristensen@webkit.org>
41
42         Prepare to replace WKBundleFileHandleCreateWithPath with a version that takes a WKBundlePageRef
43         https://bugs.webkit.org/show_bug.cgi?id=189929
44
45         Reviewed by Andy Estes.
46
47         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp:
48
49 2018-09-24  Thomas Denney  <tdenney@apple.com>
50
51         [WHLSL] Casting user-created types to themselves should always work
52         https://bugs.webkit.org/show_bug.cgi?id=189113
53
54         Reviewed by Myles C. Maxfield.
55
56         Casting user-defined types to themselves worked already, but we didn't
57         test it anywhere.
58
59         * WebGPUShadingLanguageRI/Test.js:
60         (tests.selfCasts):
61
62 2018-09-24  Zan Dobersek  <zdobersek@igalia.com>
63
64         Unreviewed build fix for Jhbuild-using ports.
65
66         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch:
67         Adjust the patch so it applies cleanly on the 1.14.3 version of the
68         gst-plugins-good package.
69
70 2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
71
72         Update flakiness dashboard configuration for iOS 12 queues
73         https://bugs.webkit.org/show_bug.cgi?id=189688
74
75         Reviewed by Alexey Proskuryakov.
76
77         * TestResultServer/static-dashboards/builders.jsonp:
78
79 2018-09-24  Alicia Boya García  <aboya@igalia.com>
80
81         [GStreamer] Unreviewed build fix.
82
83         A GStreamer patch was not applying cleanly on 1.14.3.
84
85         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch:
86
87 2018-09-24  Alicia Boya García  <aboya@igalia.com>
88
89         [MSE][GStreamer] Use no-more-pads event for noticing initialization segments
90         https://bugs.webkit.org/show_bug.cgi?id=189868
91
92         Reviewed by Xabier Rodriguez-Calvar.
93
94         Added patch from https://bugzilla.gnome.org/show_bug.cgi?id=797187
95
96         * gstreamer/jhbuild.modules:
97         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Added.
98
99 2018-09-24  Alicia Boya García  <aboya@igalia.com>
100         [MSE][GStreamer] Add patch to jhbuild: matroskademux: Allow Matroska headers to be read more than once
101         https://bugs.webkit.org/show_bug.cgi?id=185731
102
103         Reviewed by Xabier Rodriguez-Calvar.
104
105         Upstream bug in GStreamer: https://bugzilla.gnome.org/show_bug.cgi?id=793333
106
107         This fixes YTTV 35. AppendMultipleInitOpusAudio (and any other use
108         case where two WebM initialization segments are appended on a row).
109
110         * gstreamer/jhbuild.modules:
111         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Added.
112         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Added.
113         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Added.
114
115 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
116
117         [WHSL] Need grammar to specify kernel group size
118         https://bugs.webkit.org/show_bug.cgi?id=189108
119
120         Reviewed by Dean Jackson.
121
122         In HLSL, compute functions are annotated with their workgroup size.
123         For example,
124
125         [numthreads(3, 4, 5)] compute void foo(...) { ... }
126
127         * WebGPUShadingLanguageRI/All.js:
128         * WebGPUShadingLanguageRI/Func.js:
129         (Func):
130         (Func.prototype.get attributeBlock):
131         * WebGPUShadingLanguageRI/FuncAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
132         (FuncAttribute):
133         * WebGPUShadingLanguageRI/FuncDef.js:
134         (FuncDef):
135         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
136         (FuncNumThreadsAttribute):
137         (FuncNumThreadsAttribute.prototype.get x):
138         (FuncNumThreadsAttribute.prototype.get y):
139         (FuncNumThreadsAttribute.prototype.get z):
140         * WebGPUShadingLanguageRI/LateChecker.js:
141         (LateChecker.prototype._checkShaderType):
142         * WebGPUShadingLanguageRI/Parse.js:
143         (parseAttributeBlock):
144         (parseFuncDecl):
145         (parseFuncDef):
146         (parseNativeFunc):
147         * WebGPUShadingLanguageRI/SPIRV.html:
148         * WebGPUShadingLanguageRI/StatementCloner.js:
149         (StatementCloner.prototype.visitFuncDef):
150         (StatementCloner.prototype.visitFuncNumThreadsAttribute):
151         (StatementCloner):
152         * WebGPUShadingLanguageRI/Test.html:
153         * WebGPUShadingLanguageRI/Test.js:
154         (tests.numThreads):
155         * WebGPUShadingLanguageRI/Visitor.js:
156         (Visitor.prototype.visitFunc):
157         (Visitor.prototype.visitFuncNumThreadsAttribute):
158         (Visitor):
159         * WebGPUShadingLanguageRI/index.html:
160
161 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
162
163         Native functions which accept pointers need to do null checks
164         https://bugs.webkit.org/show_bug.cgi?id=189883
165
166         Reviewed by Dean Jackson.
167
168         Simply guard all the places where we write through an author-provided pointer.
169
170         * WebGPUShadingLanguageRI/Intrinsics.js:
171         (Intrinsics.):
172         * WebGPUShadingLanguageRI/Test.js:
173         (tests.textureDimensionsNull):
174
175 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
176
177         [WHLSL] Implement atomic operations and barriers
178         https://bugs.webkit.org/show_bug.cgi?id=189025
179
180         Reviewed by Dean Jackson.
181
182         In the interpreter, atomic operations don't need to be atomic.
183
184         * WebGPUShadingLanguageRI/Intrinsics.js:
185         (Intrinsics.):
186         * WebGPUShadingLanguageRI/StandardLibrary.js:
187         (let.standardLibrary):
188         * WebGPUShadingLanguageRI/Test.js:
189         (tests.atomics):
190
191 2018-09-22  Thibault Saunier  <tsaunier@igalia.com>
192
193         [WPE] Be very permissive in the MiniBrowser.
194         https://bugs.webkit.org/show_bug.cgi?id=189800
195
196         This is just a test tool and we should make
197         it just work, security and privacy is not really
198         a primary focus here.
199
200         Reviewed by Žan Doberšek.
201
202         * MiniBrowser/wpe/main.cpp:
203         (decidePermissionRequest):
204         (main):
205
206 2018-09-21  Thomas Denney  <tdenney@apple.com>
207
208         [WHLSL] Local variables should be statically allocated
209         https://bugs.webkit.org/show_bug.cgi?id=188402
210
211         Reviewed by Myles C. Maxfield.
212
213         An additional preparation stage is now performed so that all local
214         variables and function parameters are allocated in a single struct at
215         entry points. A pointer to this struct is then passed for function
216         calls.
217
218         * WebGPUShadingLanguageRI/All.js: Update dependencies.
219         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Added new stage.
220         * WebGPUShadingLanguageRI/CallExpression.js:
221         (CallExpression.prototype.set argumentList): Add setter because
222         allocateAtEntryPoints needs to change this.
223         * WebGPUShadingLanguageRI/EBufferBuilder.js: Remove a redundant
224         constructor that wasn't used anywhere.
225         * WebGPUShadingLanguageRI/Func.js:
226         (Func.prototype.set parameters): Add setter.
227         * WebGPUShadingLanguageRI/FuncDef.js:
228         (FuncDef.prototype.set body): Ditto.
229         * WebGPUShadingLanguageRI/Prepare.js:
230         (let.prepare): Add call to allocateAtEntryPoints. This call cannot
231         happen any earlier because it depends on having types for call
232         arguments.
233         * WebGPUShadingLanguageRI/Rewriter.js:
234         (Rewriter.prototype.visitReturn): Resolve issue where the return
235         statement's function wasn't copied. A null check is required as the
236         Rewriter might be used before this property is set.
237         * WebGPUShadingLanguageRI/SPIRV.html: Update dependencies.
238         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Abstracted logic
239         into a separate function so that allocateAtEntryPoints can create the
240         accessors for the struct type it introduces.
241         * WebGPUShadingLanguageRI/Test.html: Update dependencies.
242         * WebGPUShadingLanguageRI/Test.js: Add new tests to verify the static
243         allocation transform works safely.
244         * WebGPUShadingLanguageRI/index.html: Update dependencies.
245
246 2018-09-21  Jonathan Bedard  <jbedard@apple.com>
247
248         Bring up queues for iOS 12 (Build fix)
249         https://bugs.webkit.org/show_bug.cgi?id=189683
250
251         Unreviewed build fix.
252
253         We should not build ImageDiff as x86 by default since 32 bit projects are
254         deprecated in Xcode. ImageDiff should only be built once.
255
256         * Scripts/build-webkit:
257         * Scripts/webkitdirs.pm:
258         (argumentsForConfiguration):
259
260 2018-09-21  Adrian Perez de Castro  <aperez@igalia.com>
261
262         [WPE] Built RPM of WPE webkit fails to install with "nothing provides libWPEToolingBackends.so()"
263         https://bugs.webkit.org/show_bug.cgi?id=189797
264
265         Reviewed by Žan Doberšek.
266
267         * wpe/backends/CMakeLists.txt: Make libWPEToolingBackends a static library to avoid
268         the need for installing it. This works fine because the library only contains utility
269         code intended to be reused from other various components (MiniBrowser, WebKitTestRunner).
270
271 2018-09-20  Daniel Bates  <dabates@apple.com>
272
273         Move IOKitSPI.h from TestRunnerShared to PAL
274         https://bugs.webkit.org/show_bug.cgi?id=189804
275
276         Reviewed by Wenson Hsieh.
277
278         Towards fixing <https://bugs.webkit.org/show_bug.cgi?id=189604> move the IOKit SPI forward
279         declarations to PAL so that they can be shared by WebKit, DumpRenderTree and WebKitTestRunner.
280
281         No functionality changed. So, no new tests.
282
283         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
284         * TestRunnerShared/spi/UIKitTestSPI.h:
285         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
286         * WebKitTestRunner/ios/HIDEventGenerator.mm:
287
288 2018-09-20  Thomas Denney  <tdenney@apple.com>
289
290         [WHLSL] Metal code generation
291         https://bugs.webkit.org/show_bug.cgi?id=187735
292
293         Reviewed by Myles C. Maxfield.
294
295         Adds support for generating Metal Shading Language from WHLSL. Clients
296         should include the file MetalCodegenAll.js and then call whlslToMsl
297         with their program source code to compile to Metal.
298
299         * WebGPUShadingLanguageRI/ArrayType.js:
300         (ArrayType.prototype.get arrayRefType): Adds the arrayRefType method to
301         all types to find the type of that expression when it is used in a
302         MakeArrayRefExpression.
303         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js:
304         (MakeArrayRefExpression):
305         (MakeArrayRefExpression.prototype.get type): Uses the new arrayRefType
306         getter on all types to find the type of the expression.
307         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Added.
308         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Added.
309         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Added.
310         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Added.
311         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Added.
312         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Added.
313         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Added.
314         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Added.
315         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Added.
316         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Added.
317         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Added.
318         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Added.
319         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Added.
320         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Added.
321         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Added.
322         * WebGPUShadingLanguageRI/PropertyResolver.js:
323         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
324         * WebGPUShadingLanguageRI/Test.js: Added awkward tests for the compiler
325         to generate code for.
326         (tests.incrementAndDecrement):
327         (tests.returnIntLiteralUint):
328         (tests.returnIntLiteralFloat):
329         (tests.nestedSubscriptWithArraysInStructs):
330         (tests.nestedSubscript):
331         (tests.lotsOfLocalVariables):
332         * WebGPUShadingLanguageRI/Type.js:
333         (Type.prototype.get arrayRefType): See above.
334
335 2018-09-20  Ryan Haddad  <ryanhaddad@apple.com>
336
337         Bring up queues for iOS 12
338         https://bugs.webkit.org/show_bug.cgi?id=189683
339
340         Unreviewed infrastructure fix.
341
342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png.
343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
344         (BubbleQueueServer): Move EWS bubbles to the iOS 12 section of the dashboard.
345
346 2018-09-20  Ryan Haddad  <ryanhaddad@apple.com>
347
348         Bring up queues for iOS 12
349         https://bugs.webkit.org/show_bug.cgi?id=189683
350
351         Reviewed by Aakash Jain.
352
353         * BuildSlaveSupport/build.webkit.org-config/config.json:
354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png: Added.
355         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png: Added.
356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png: Added.
357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png: Added.
358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
360         (WebKitBuildbot):
361         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
362         (table.queue-grid tr.platform.ios-simulator-12 img.logo):
363         (table.queue-grid tr.platform.ios-12 img.logo):
364         (table.queue-grid tr.platform.ios-simulator-11 img.logo): Deleted.
365         (table.queue-grid tr.platform.ios-11 img.logo): Deleted.
366         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
367         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
368         (_should_file_trigger_build):
369         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
370         (ShouldBuildTest):
371         (ShouldBuildTest.test_should_build):
372
373 2018-09-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
374
375         [Win] TestRunner::queueLoad() fails to generate correct url for some urls.
376         https://bugs.webkit.org/show_bug.cgi?id=189679
377
378         Reviewed by Fujii Hironori.
379
380         Replace the implementation with correct API call.
381
382         * DumpRenderTree/win/TestRunnerWin.cpp:
383         (TestRunner::queueLoad): Call UrlCombineW.
384
385 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
386
387         [WPE] fails to build on ARM arches complaining about undefined reference to `epoxy_eglMakeCurrent'
388         https://bugs.webkit.org/show_bug.cgi?id=189556
389
390         Reviewed by Konstantin Tokarev.
391
392         This is only a speculative build fix as I didn't attempt to reproduce. Explicitly link to
393         libepoxy.
394
395         * wpe/backends/CMakeLists.txt:
396
397 2018-09-20  Daniel Bates  <dabates@apple.com>
398
399         [iOS] Support testing more hardware special keys
400         https://bugs.webkit.org/show_bug.cgi?id=189793
401
402         Reviewed by Simon Fraser.
403
404         * TestRunnerShared/spi/IOKitSPI.h: Add more SPI constants.
405         * WebKitTestRunner/ios/HIDEventGenerator.mm:
406         (keyCodeForDOMFunctionKey): Extracted out logic from hidUsageCodeForCharacter() to return the
407         key code for the F1, F2, ..., F12 keys and extended the code to compute the key code for the
408         F13, F14, ..., F24 keys.
409         (hidUsageCodeForCharacter): Modified to call keyCodeForDOMFunctionKey().
410
411 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
412
413         Unreviewed, remove accidentally-committed debugging changes from flatpakutils script
414
415         Aaaaaah maybe this is why changes are supposed to be reviewed.
416
417         * flatpak/flatpakutils.py:
418         (WebkitFlatpak.clean_args):
419
420 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
421
422         Unreviewed, manually rollout our switch to master runtime
423
424         Phil wants html5-codecs, which aren't available yet here. Let's switch back to 3.28 in the
425         meantime, where we were already building GStreamer ourselves anyway. But use an updated
426         SDK revision.
427
428         * flatpak/files/httpd-autogen.sh: Added.
429         * flatpak/flatpakutils.py:
430         (WebkitFlatpak.clean_args):
431         * flatpak/org.webkit.GTK.yaml:
432         * flatpak/org.webkit.WebKit.yaml:
433         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
434         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Added.
435
436 2018-09-20  Thibault Saunier  <tsaunier@igalia.com>
437
438         [WPE][GTK] webkit-flatpak intercepts --help for other commands
439         https://bugs.webkit.org/show_bug.cgi?id=189058
440
441         The approach of run_in_sandbox_if_available is that we basically have the
442         same set of arguments to setup the sandbox (ie. port name, build type, etc...)
443         and we can pass those args first to setup the flatpak launcher object
444         and then to the underlying script. That doesn't work well with the `--help` argument
445         as once processed it 1. prints the help (which make no sense to the user of the calling script)
446         2. exits the app - The solution is to just make sure that `--help` is not used when using
447         flatpakutils from any script that is not `webkit-flatpak` itself.
448
449         Reviewed by Michael Catanzaro.
450
451         * flatpak/flatpakutils.py:
452         (WebkitFlatpak.load_from_args):
453         (run_in_sandbox_if_available):
454
455 2018-09-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
456
457         Unreviewed. Add W3C imported tests to the MSEEME watchlist.
458
459         * Scripts/webkitpy/common/config/watchlist:
460
461 2018-09-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
462
463         Unreviewed. Fix the Streams API watchlist.
464
465         * Scripts/webkitpy/common/config/watchlist:
466
467 2018-09-19  Chris Dumez  <cdumez@apple.com>
468
469         Crash under WebProcessProxy::suspendedPageWasDestroyed(WebKit::SuspendedPageProxy&)
470         https://bugs.webkit.org/show_bug.cgi?id=189721
471         <rdar://problem/44359788>
472
473         Reviewed by Geoffrey Garen.
474
475         Add API test coverage.
476
477         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
478
479 2018-09-19  Thomas Denney  <tdenney@apple.com>
480
481         [WHLSL] Improve test suite type safety
482         https://bugs.webkit.org/show_bug.cgi?id=189502
483
484         Reviewed by Myles C. Maxfield.
485
486         Each of the 'makeT' functions now call the relevant cast function on the
487         value before hand. The checkNumber function has also been removed and
488         its uses have been replaced with functions that also check the type.
489         Some of the arithmetic checks have been updated to reflect that the
490         casts happen outside of WHLSL evaluation. Other tests have also been
491         updated to reflect that some values cannot be precisely expressed in
492         32-bit floating point.
493
494         * WebGPUShadingLanguageRI/Casts.js:
495         (castToBool): Added.
496         (castAndCheckValue): Added.
497         (isBitwiseEquivalent): Moved from Intrinsics.js.
498         * WebGPUShadingLanguageRI/Intrinsics.js: Ditto.
499         * WebGPUShadingLanguageRI/SPIRV.html: Update depdencies.
500         * WebGPUShadingLanguageRI/Test.html: Ditto.
501         * WebGPUShadingLanguageRI/Test.js: Update makeT functions to do a cast
502         and check the result. Some tests were also updated to reflect the change
503         in the behavior of these functions.
504         * WebGPUShadingLanguageRI/index.html: Update dependencies.
505
506 2018-09-19  John Wilander  <wilander@apple.com>
507
508         Resource Load Statistics: Add optional cap on partitioned cache max age
509         https://bugs.webkit.org/show_bug.cgi?id=189711
510         <rdar://problem/39246837>
511
512         Reviewed by Antti Koivisto and Chris Dumez.
513
514         This change adds infrastructure for layout tests of capped cache max age.
515
516         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
517         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
518         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
519         * WebKitTestRunner/InjectedBundle/TestRunner.h:
520         * WebKitTestRunner/TestController.cpp:
521         (WTR::TestController::setStatisticsCacheMaxAgeCap):
522         * WebKitTestRunner/TestController.h:
523         * WebKitTestRunner/TestInvocation.cpp:
524         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
525
526 2018-09-19  Dawei Fenton  <realdawei@apple.com>
527
528        Unreviewed. Update my email and alias in list of contributors.
529
530         * Scripts/webkitpy/common/config/contributors.json:
531
532 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
533
534         [WPE][GTK] Unreviewed, try #3 to fix a typo
535
536         I feel like Charlie Brown, how hard this has been for me....
537
538         * Scripts/run-minibrowser:
539         * Scripts/webkitdirs.pm:
540         (runInFlatpakIfAvailable):
541         (runInFlatpakIfAvailible): Deleted.
542
543 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
544
545         [WPE][GTK] Unreviewed, fix that typo in more places
546
547         It got copied into webkitdirs.pm!
548
549         * Scripts/webkitdirs.pm:
550         (runInFlatpakIfAvailible):
551         (runInFlatpakIfAvalaible): Deleted.
552
553 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
554
555         [WPE][GTK] Unreviewed, fix a pervasive typo in the webkit-flatpak script
556
557         * flatpak/flatpakutils.py:
558         (WebkitFlatpak.load_from_args):
559         (WebkitFlatpak.__init__):
560         (WebkitFlatpak.run):
561
562 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
563
564         [WPE][GTK] Unreviewed, update to latest GNOME SDK
565
566         * flatpak/org.webkit.WebKit.yaml:
567
568 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
569
570         Unreviewed, rolling out r235500.
571
572         Time to switch back to master runtime
573
574         Reverted changeset:
575
576         "Unreviewed, rolling out r235114."
577         https://bugs.webkit.org/show_bug.cgi?id=188731
578         https://trac.webkit.org/changeset/235500
579
580 2018-09-19  Adrian Perez de Castro  <aperez@igalia.com>
581
582         Unreviewed. Add Pablo Saavedra to the list of contributors.
583
584         * Scripts/webkitpy/common/config/contributors.json:
585
586 2018-09-19  Philippe Normand  <pnormand@igalia.com>
587
588         [GStreamer] Add support for AV1 decoding
589         https://bugs.webkit.org/show_bug.cgi?id=189647
590
591         Reviewed by Žan Doberšek.
592
593         Add patches required for AV1 decoding support. They're all
594         upstream already and will be shipped in GStreamer 1.16. The aom
595         GStreamer plugin depends on the aom library for which there's no
596         official release yet.
597
598         * gstreamer/jhbuild.modules:
599         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Added.
600         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Added.
601         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Added. This one is unrelated but an implicit dependency of the next one.
602         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Added.
603         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Added.
604         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Added.
605
606 2018-09-18  Jonathan Bedard  <jbedard@apple.com>
607
608         webkitpy: Clobbering and building occurs multiple times for iOS Simulator ports
609         https://bugs.webkit.org/show_bug.cgi?id=189702
610         <rdar://problem/44541704>
611
612         Reviewed by Aakash Jain.
613
614         * Scripts/webkitpy/layout_tests/controllers/manager.py:
615         (Manager._set_up_run): Move build check and clobbering to run, since set up is
616         run multiple times for iOS simulator.
617         (Manager.run):
618
619 2018-09-18  Chris Dumez  <cdumez@apple.com>
620
621         "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache
622         https://bugs.webkit.org/show_bug.cgi?id=189681
623         <rdar://problem/44526171>
624
625         Reviewed by Alex Christensen and Zalan Bujtas.
626
627         Add API test coverage.
628
629         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
630         (TestWebKitAPI::didFinishNavigation):
631         (TestWebKitAPI::TEST):
632
633 2018-09-18  Claudio Saavedra  <csaavedra@igalia.com>
634
635         [WPE] Implement mouse event modifiers
636         https://bugs.webkit.org/show_bug.cgi?id=189697
637
638         Reviewed by Carlos Garcia Campos.
639
640         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
641         (WTR::wkEventModifiersToWPE):
642         (WTR::EventSenderProxy::mouseDown):
643         (WTR::EventSenderProxy::mouseUp):
644
645 2018-09-17  Yusuke Suzuki  <utatane.tea@gmail.com>
646
647         [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t
648         https://bugs.webkit.org/show_bug.cgi?id=185339
649
650         Reviewed by Mark Lam.
651
652         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
653         (TestWebKitAPI::ToUpperConverter::stopProducing):
654         (TestWebKitAPI::ToUpperConverter::stopConsuming):
655
656 2018-09-17  Simon Fraser  <simon.fraser@apple.com>
657
658         Many modern media control tests leak documents in testing
659         https://bugs.webkit.org/show_bug.cgi?id=189437
660
661         Reviewed by Darin Adler.
662         
663         In order to accurately detect leaks in media controls tests which use lots of
664         SVGImages, we have to:
665         - Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
666           to clear references to elements.
667         - Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
668           to drop the last handle to the CachedResource for an SVGImage.
669         - Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
670           to run again after that timer has fired.
671         
672         This should fix most of the spurious leak reports involving SVGImage documents.
673
674         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
675         (WTR::InjectedBundle::reportLiveDocuments):
676         (WTR::InjectedBundle::didReceiveMessageToPage):
677
678 2018-09-17  Chris Dumez  <cdumez@apple.com>
679
680         PSON: window.open() with 'noopener' should only process-swap cross-site, not cross-origin
681         https://bugs.webkit.org/show_bug.cgi?id=189602
682         <rdar://problem/44430549>
683
684         Reviewed by Geoff Garen.
685
686         Add API test coverage.
687
688         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
689
690 2018-09-17  Philippe Normand  <pnormand@igalia.com>
691
692         [JHBuild] Update to GStreamer 1.14.3
693         https://bugs.webkit.org/show_bug.cgi?id=189450
694
695         Reviewed by Xabier Rodriguez-Calvar.
696
697         * gstreamer/jhbuild.modules: Bump GStreamer modules from 1.14.1 to 1.14.3.
698
699 2018-09-17  Philippe Normand  <pnormand@igalia.com>
700
701         [JHBuild] Doesn't check sha256 sums
702         https://bugs.webkit.org/show_bug.cgi?id=189646
703
704         Reviewed by Michael Catanzaro.
705
706         * gstreamer/jhbuild.modules: Properly set the sha256: prefix on hashes.
707
708 2018-09-17  Sihui Liu  <sihui_liu@apple.com>
709
710         Move IndexedDB to Network Process
711         https://bugs.webkit.org/show_bug.cgi?id=189415
712         <rdar://problem/44396973>
713
714         Reviewed by Chris Dumez.
715
716         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
717         (TEST):
718         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
719         (TEST):
720         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
721         (TEST):
722         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
723         (TEST):
724         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
725         (TEST):
726
727 2018-09-08  Darin Adler  <darin@apple.com>
728
729         Streamline JSRetainPtr, fix leaks of JSString and JSGlobalContext
730         https://bugs.webkit.org/show_bug.cgi?id=189455
731
732         Reviewed by Keith Miller.
733
734         There is a lot of copied and pasted code for WebKit vs. Legacy WebKit
735         testing and even for macOS vs. iOS vs. Windows platform-specific code.
736         For now, this patch just makes corresponding changes to the copied code.
737         Later we might get better results by merging more code instead of having
738         all these separate copies.
739
740         * DumpRenderTree/AccessibilityController.cpp:
741         (AccessibilityController::makeWindowObject): Use the adopt function
742         instead of the special Adopt constructor of JSRetainPtr.
743
744         * DumpRenderTree/AccessibilityTextMarker.cpp: Removed unneeded include.
745
746         * DumpRenderTree/AccessibilityUIElement.cpp: Ditto.
747         (allAttributesCallback): Don't adopt at this level; changed the
748         underlying function to return a JSRetainPtr so the adopt is right next
749         to the call to the create or copy function.
750         (attributesOfLinkedUIElementsCallback): Ditto.
751         (attributesOfDocumentLinksCallback): Ditto.
752         (attributesOfChildrenCallback): Ditto.
753         (parameterizedAttributeNamesCallback): Ditto.
754         (attributesOfColumnHeadersCallback): Ditto.
755         (attributesOfRowHeadersCallback): Ditto.
756         (attributesOfColumnsCallback): Ditto.
757         (attributesOfRowsCallback): Ditto.
758         (attributesOfVisibleCellsCallback): Ditto.
759         (attributesOfHeaderCallback): Ditto.
760         (rowIndexRangeCallback): Ditto.
761         (columnIndexRangeCallback): Ditto.
762         (rangeForLineCallback): Ditto.
763         (boundsForRangeCallback): Ditto.
764         (rangeForPositionCallback): Ditto.
765         (stringForRangeCallback): Ditto.
766         (attributedStringForRangeCallback): Ditto.
767         (uiElementCountForSearchPredicateCallback): Use the free adopt
768         function instead of the adopt member function.
769         (uiElementForSearchPredicateCallback): Ditto.
770         (selectTextWithCriteriaCallback): Don't adopt at this level.
771         (attributedStringForElementCallback): Ditto.
772         (setValueCallback): Use free adopt.
773         (stringAttributeValueCallback): Don't adopt at this level.
774         (uiElementArrayAttributeValueCallback): Ditto.
775         (uiElementAttributeValueCallback): Ditto.
776         (stringForTextMarkerRangeCallback): Ditto.
777         (attributedStringForTextMarkerRangeCallback): Ditto.
778         (attributedStringForTextMarkerRangeWithOptionsCallback): Ditto.
779         (getARIADropEffectsCallback): Ditto.
780         (getClassListCallback): Ditto.
781         (getRoleCallback): Ditto.
782         (getSubroleCallback): Ditto.
783         (getRoleDescriptionCallback): Ditto.
784         (getComputedRoleStringCallback): Ditto.
785         (getTitleCallback): Ditto.
786         (getDescriptionCallback): Ditto.
787         (getStringValueCallback): Ditto.
788         (getLanguageCallback): Ditto.
789         (getHelpTextCallback): Ditto.
790         (getOrientationCallback): Ditto.
791         (getPathDescriptionCallback): Ditto.
792         (getSelectedTextRangeCallback): Ditto.
793         (speakAsCallback): Ditto.
794         (getValueDescriptionCallback): Ditto.
795         (getAccessibilityValueCallback): Ditto.
796         (getDocumentEncodingCallback): Ditto.
797         (getDocumentURICallback): Ditto.
798         (getURLCallback): Ditto.
799         (characterAtOffsetCallback): Ditto.
800         (wordAtOffsetCallback): Ditto.
801         (lineAtOffsetCallback): Ditto.
802         (sentenceAtOffsetCallback): Ditto.
803         (stringForSelectionCallback): Ditto.
804         (getIdentifierCallback): Ditto.
805         (getTraitsCallback): Ditto.
806         (supportedActionsCallback): Ditto.
807         (mathPostscriptsDescriptionCallback): Ditto.
808         (mathPrescriptsDescriptionCallback): Ditto.
809         (AccessibilityUIElement::rangeForLine): Updated to return JSRetainPtr.
810         (AccessibilityUIElement::rangeForPosition): Ditto.
811         (AccessibilityUIElement::speakAs): Ditto.
812         (AccessibilityUIElement::pathDescription const): Ditto.
813         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
814         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
815         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
816
817         * DumpRenderTree/AccessibilityUIElement.h: Use JSRetainPtr instead of
818         raw pointers for the results of the functions that create strings.
819         The old way was difficult to get right; the functions didn't even follow
820         the create/copy naming rule.
821
822         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
823         (_platformTypeConstructor): Use the adopt function instead of the
824         JSRetainPtr adopt constructor. Also nullptr instead of 0.
825
826         * DumpRenderTree/GCController.cpp:
827         (GCController::makeWindowObject): Use adopt function instead of constructor.
828
829         * DumpRenderTree/TestRunner.cpp:
830         (pathToLocalResourceCallback): Use adopt function instead of constructor.
831         (addDisallowedURLCallback): Ditto.
832         (addURLToRedirectCallback): Ditto.
833         (clearApplicationCacheForOriginCallback): Ditto.
834         (applicationCacheDiskUsageForOriginCallback): Ditto.
835         (decodeHostNameCallback): Don't adopt at this level.
836         (encodeHostNameCallback): Ditto.
837         (execCommandCallback): Use adopt instead of JSRetainPtr::adopt.
838         (findStringCallback): Use adopt function instead of constructor.
839         (isCommandEnabledCallback): Ditto.
840         (overridePreferenceCallback): Ditto.
841         (queueLoadCallback): Ditto.
842         (queueLoadHTMLStringCallback): Ditto.
843         (queueLoadingScriptCallback): Ditto.
844         (queueNonLoadingScriptCallback): Ditto.
845         (setAuthenticationPasswordCallback): Ditto.
846         (setAuthenticationUsernameCallback): Ditto.
847         (setDomainRelaxationForbiddenForURLSchemeCallback): Ditto.
848         (setMockGeolocationPositionUnavailableErrorCallback): Ditto.
849         (setPOSIXLocaleCallback): Ditto.
850         (setPersistentUserStyleSheetLocationCallback): Ditto.
851         (setUserStyleSheetLocationCallback): Ditto.
852         (setValueForUserCallback): Ditto.
853         (setWillSendRequestClearHeaderCallback): Ditto.
854         (setPageVisibilityCallback): Ditto.
855         (evaluateInWebInspectorCallback): Ditto.
856         (evaluateScriptInIsolatedWorldCallback): Ditto.
857         (evaluateScriptInIsolatedWorldAndReturnValueCallback): Ditto.
858         (addOriginAccessWhitelistEntryCallback): Ditto.
859         (removeOriginAccessWhitelistEntryCallback): Ditto.
860         (setScrollbarPolicyCallback): Ditto.
861         (addUserScriptCallback): Ditto.
862         (addUserStyleSheetCallback): Ditto.
863         (apiTestNewWindowDataLoadBaseURLCallback): Ditto.
864         (authenticateSessionCallback): Ditto.
865         (getTitleTextDirectionCallback): Ditto.
866         (getInspectorTestStubURLCallback): Ditto.
867         (simulateLegacyWebNotificationClickCallback): Ditto.
868         (setTextDirectionCallback): Ditto.
869         (grantWebNotificationPermissionCallback): Ditto.
870         (denyWebNotificationPermissionCallback): Ditto.
871         (accummulateLogsForChannel): Ditto.
872         (runUIScriptCallback): Ditto.
873         (TestRunner::makeWindowObject): Ditto.
874         (TestRunner::uiScriptDidComplete): Ditto.
875         (TestRunner::setOpenPanelFiles): Ditto.
876
877         * DumpRenderTree/TestRunner.h: Use JSRetainPtr instead of
878         raw pointers for the results of the functions that create strings.
879
880         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
881         (AccessibilityController::platformName const): Use the adopt
882         function instead of the adopt constructor.
883
884         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
885         (createEmptyJSString): Added. This helper function makes reduces the
886         repetitive code to create empty strings.
887         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
888         (AccessibilityUIElement::identifier): Ditto.
889         (AccessibilityUIElement::traits): Ditto.
890         (AccessibilityUIElement::url): Ditto.
891         (AccessibilityUIElement::speakAs): Ditto.
892         (AccessibilityUIElement::stringForSelection): Ditto.
893         (AccessibilityUIElement::stringForRange): Ditto.
894         (AccessibilityUIElement::attributedStringForRange): Ditto.
895         (AccessibilityUIElement::attributedStringForElement): Ditto.
896         (AccessibilityUIElement::pathDescription const): Ditto.
897         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
898         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
899         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
900         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
901         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
902         (AccessibilityUIElement::attributesOfChildren): Ditto.
903         (AccessibilityUIElement::allAttributes): Ditto.
904         (AccessibilityUIElement::stringAttributeValue): Ditto.
905         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
906         (AccessibilityUIElement::role): Ditto.
907         (AccessibilityUIElement::subrole): Ditto.
908         (AccessibilityUIElement::roleDescription): Ditto.
909         (AccessibilityUIElement::computedRoleString): Ditto.
910         (AccessibilityUIElement::title): Ditto.
911         (AccessibilityUIElement::description): Ditto.
912         (AccessibilityUIElement::orientation const): Ditto.
913         (AccessibilityUIElement::stringValue): Ditto.
914         (AccessibilityUIElement::language): Ditto.
915         (AccessibilityUIElement::helpText const): Ditto.
916         (AccessibilityUIElement::valueDescription): Ditto.
917         (AccessibilityUIElement::ariaDropEffects const): Ditto.
918         (AccessibilityUIElement::boundsForRange): Ditto.
919         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
920         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
921         (AccessibilityUIElement::attributesOfColumns): Ditto.
922         (AccessibilityUIElement::attributesOfRows): Ditto.
923         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
924         (AccessibilityUIElement::attributesOfHeader): Ditto.
925         (AccessibilityUIElement::rowIndexRange): Ditto.
926         (AccessibilityUIElement::columnIndexRange): Ditto.
927         (AccessibilityUIElement::selectedTextRange): Ditto.
928         (AccessibilityUIElement::accessibilityValue const): Ditto.
929         (AccessibilityUIElement::documentEncoding): Ditto.
930         (AccessibilityUIElement::documentURI): Ditto.
931         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
932         (AccessibilityUIElement::classList const): Ditto.
933
934         * DumpRenderTree/mac/AccessibilityCommonMac.h: Changed the
935         createJSStringRef method to return a JSRetainPtr.
936         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
937         (-[NSString createJSStringRef]): Ditto.
938         (searchPredicateParameterizedAttributeForSearchCriteria): Use the
939         adopt function instead of the adopt constructor.
940         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
941         (AccessibilityController::platformName const): Ditto.
942
943         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
944         (-[NSString createJSStringRef]): Return a JSRetainPtr.
945         (makeValueRefForValue): Updated for the above, no adopt needed here now.
946         (makeObjectRefForDictionary): Ditto.
947         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
948
949         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
950         (createEmptyJSString): Added. This helper function makes reduces the
951         repetitive code to create empty strings.
952         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
953         (descriptionOfElements): Ditto.
954         (selectTextParameterizedAttributeForCriteria): Ditto.
955         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
956         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
957         (AccessibilityUIElement::attributesOfChildren): Ditto.
958         (AccessibilityUIElement::allAttributes): Ditto.
959         (AccessibilityUIElement::stringAttributeValue): Ditto.
960         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
961         (AccessibilityUIElement::role): Ditto.
962         (AccessibilityUIElement::subrole): Ditto.
963         (AccessibilityUIElement::roleDescription): Ditto.
964         (AccessibilityUIElement::computedRoleString): Ditto.
965         (AccessibilityUIElement::title): Ditto.
966         (AccessibilityUIElement::description): Ditto.
967         (AccessibilityUIElement::orientation const): Ditto.
968         (AccessibilityUIElement::stringValue): Ditto.
969         (AccessibilityUIElement::language): Ditto.
970         (AccessibilityUIElement::helpText const): Ditto.
971         (AccessibilityUIElement::valueDescription): Ditto.
972         (AccessibilityUIElement::speakAs): Ditto.
973         (AccessibilityUIElement::classList const): Ditto.
974         (AccessibilityUIElement::ariaDropEffects const): Ditto.
975         (AccessibilityUIElement::rangeForLine): Ditto.
976         (AccessibilityUIElement::rangeForPosition): Ditto.
977         (AccessibilityUIElement::boundsForRange): Ditto.
978         (AccessibilityUIElement::stringForRange): Ditto.
979         (AccessibilityUIElement::attributedStringForRange): Ditto.
980         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
981         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
982         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
983         (AccessibilityUIElement::attributesOfColumns): Ditto.
984         (AccessibilityUIElement::attributesOfRows): Ditto.
985         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
986         (AccessibilityUIElement::attributesOfHeader): Ditto.
987         (AccessibilityUIElement::rowIndexRange): Ditto.
988         (AccessibilityUIElement::columnIndexRange): Ditto.
989         (AccessibilityUIElement::pathDescription const): Ditto.
990         (AccessibilityUIElement::selectedTextRange): Ditto.
991         (AccessibilityUIElement::accessibilityValue const): Ditto.
992         (AccessibilityUIElement::documentEncoding): Ditto.
993         (AccessibilityUIElement::documentURI): Ditto.
994         (AccessibilityUIElement::url): Ditto.
995         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
996         (createJSStringRef): Ditto.
997         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
998         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
999         (AccessibilityUIElement::supportedActions): Ditto.
1000         (AccessibilityUIElement::mathPostscriptsDescription const): Ditto.
1001         (AccessibilityUIElement::mathPrescriptsDescription const): Ditto.
1002
1003         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1004         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1005         Use the adopt function instead of the adopt constructor.
1006         * DumpRenderTree/mac/TestRunnerMac.mm:
1007         (originsArrayToJS): Ditto.
1008         (TestRunner::copyDecodedHostName): Return a JSRetainPtr.
1009         (TestRunner::copyEncodedHostName): Ditto.
1010         (TestRunner::pathToLocalResource): Ditto.
1011         (TestRunner::queueLoad): Use adopt function instead of constructor.
1012         (TestRunner::findString): Ditto.
1013         (TestRunner::inspectorTestStubURL): Return a JSRetainPtr.
1014
1015         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1016         (AccessibilityController::winNotificationReceived): Use adopt function
1017         instead of adopt constructor.
1018         (AccessibilityController::platformName const): Ditto.
1019
1020         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1021         (createEmptyJSString): Added. This helper function makes reduces the
1022         repetitive code to create empty strings.
1023         (AccessibilityUIElement::allAttributes): Changed to return a JSRetainPtr.
1024         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
1025         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
1026         (AccessibilityUIElement::attributesOfChildren): Ditto.
1027         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
1028         (AccessibilityUIElement::role): Ditto.
1029         (AccessibilityUIElement::subrole): Ditto.
1030         (AccessibilityUIElement::roleDescription): Ditto.
1031         (AccessibilityUIElement::computedRoleString): Ditto.
1032         (AccessibilityUIElement::title): Ditto.
1033         (AccessibilityUIElement::description): Ditto.
1034         (AccessibilityUIElement::stringValue): Ditto.
1035         (AccessibilityUIElement::language): Ditto.
1036         (AccessibilityUIElement::helpText const): Ditto.
1037         (AccessibilityUIElement::valueDescription): Ditto.
1038         (AccessibilityUIElement::ariaDropEffects const): Ditto.
1039         (AccessibilityUIElement::orientation const): Ditto.
1040         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
1041         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
1042         (AccessibilityUIElement::attributesOfColumns): Ditto.
1043         (AccessibilityUIElement::attributesOfRows): Ditto.
1044         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
1045         (AccessibilityUIElement::attributesOfHeader): Ditto.
1046         (AccessibilityUIElement::rowIndexRange): Ditto.
1047         (AccessibilityUIElement::columnIndexRange): Ditto.
1048         (AccessibilityUIElement::boundsForRange): Ditto.
1049         (AccessibilityUIElement::stringForRange): Ditto.
1050         (AccessibilityUIElement::attributedStringForRange): Ditto.
1051         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
1052         (AccessibilityUIElement::selectedTextRange): Ditto.
1053         (AccessibilityUIElement::stringAttributeValue): Ditto.
1054         (AccessibilityUIElement::accessibilityValue const): Ditto.
1055         (AccessibilityUIElement::documentEncoding): Ditto.
1056         (AccessibilityUIElement::documentURI): Ditto.
1057         (AccessibilityUIElement::url): Ditto.
1058         (AccessibilityUIElement::classList const): Ditto.
1059
1060         * DumpRenderTree/win/TestRunnerWin.cpp:
1061         (TestRunner::copyDecodedHostName): Changed to return a JSRetainPtr.
1062         (TestRunner::copyEncodedHostName): Ditto.
1063         (TestRunner::pathToLocalResource): Ditto.
1064         (TestRunner::queueLoad): Ditto.
1065         (TestRunner::findString): Ditto.
1066         (TestRunner::inspectorTestStubURL): Ditto.
1067
1068         * TestRunnerShared/Bindings/JSWrapper.h:
1069         (WTR::setProperty): Use adopt function instead of constructor.
1070         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1071         (UIScriptContext::UIScriptContext): Ditto.
1072         (UIScriptContext::runUIScript): Ditto.
1073         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1074         (WTR::toDeviceOrientation): Ditto.
1075
1076         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1077         (nsTextCheckingType): Changed this function to not take an rvalue
1078         reference to a JSRetainPtr since it doesn't take ownership.
1079         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Updated
1080         for the above change.
1081
1082         * TestWebKitAPI/JavaScriptTest.cpp:
1083         (TestWebKitAPI::javaScriptCallback): Use adopt function instead of
1084         adopt member function.
1085
1086         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp: Removed unneeded include.
1087         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm: Ditto.
1088         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Use adopt function instead of
1089         adopt constructor.
1090         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm: Ditto.
1091
1092         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1093         Removed unneeded includes.
1094         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Ditto.
1095         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Ditto.
1096         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Ditto.
1097
1098         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1099         (_platformTypeConstructor): Use the adopt function instead of the
1100         JSRetainPtr adopt constructor. Also nullptr instead of 0.
1101
1102         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1103         (WTR::arrayLength): Use adopt function instead of constructor.
1104         (WTR::parseModifierArray): Ditto.
1105         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1106         (WTR::propertyValue): Ditto.
1107         (WTR::dumpPath): Ditto.
1108         (WTR::toJS): Ditto.
1109         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1110         (WTR::TestRunner::findString): Ditto.
1111         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Ditto.
1112         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): Ditto.
1113         (WTR::TestRunner::setOpenPanelFiles): Ditto.
1114         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1115         (WTR::AccessibilityController::platformName): Ditto.
1116
1117         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1118         (-[NSString createJSStringRef]): Return a JSRetainPtr.
1119         This fixes storage leaks in many functions below, which were using
1120         the create function and putting the value right into a JSRetainPtr
1121         without adoption.
1122         (WTR::createEmptyJSString): Added. This helper function reduces the
1123         repetitive code to create empty strings.
1124         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
1125         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1126         Use createEmptyJSString, fixing a storage leak due to missing adoption.
1127         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
1128         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
1129         (WTR::AccessibilityUIElement::allAttributes): Ditto.
1130         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1131         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Ditto.
1132         (WTR::AccessibilityUIElement::role): Ditto.
1133         (WTR::AccessibilityUIElement::subrole): Ditto.
1134         (WTR::AccessibilityUIElement::roleDescription): Ditto.
1135         (WTR::AccessibilityUIElement::computedRoleString): Ditto.
1136         (WTR::AccessibilityUIElement::title): Ditto.
1137         (WTR::AccessibilityUIElement::orientation const): Ditto.
1138         (WTR::AccessibilityUIElement::language): Ditto.
1139         (WTR::AccessibilityUIElement::valueDescription): Ditto.
1140         (WTR::AccessibilityUIElement::ariaDropEffects const): Ditto.
1141         (WTR::AccessibilityUIElement::boundsForRange): Ditto.
1142         (WTR::AccessibilityUIElement::stringForRange): Removed unneeded null check.
1143         (WTR::AccessibilityUIElement::attributedStringForRange): Ditto.
1144         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1145         Use createEmptyJSString, fixing a storage leak due to missing adoption.
1146         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Ditto.
1147         (WTR::AccessibilityUIElement::attributesOfColumns): Ditto.
1148         (WTR::AccessibilityUIElement::attributesOfRows): Ditto.
1149         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Ditto.
1150         (WTR::AccessibilityUIElement::attributesOfHeader): Ditto.
1151         (WTR::AccessibilityUIElement::selectedTextRange): Ditto.
1152         (WTR::AccessibilityUIElement::accessibilityValue const): Ditto.
1153         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
1154         (WTR::AccessibilityUIElement::documentURI): Ditto.
1155         (WTR::AccessibilityUIElement::stringForSelection): Removed unneeded
1156         null check.
1157         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1158         Use createEmptyJSString, fixing a storage leak due to missing adoption.
1159
1160         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1161         Use JSRetainPtr for the return value of createJSStringRef.
1162         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1163         (-[NSString createJSStringRef]): Ditto.
1164         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Use the
1165         adopt function instead of the adopt constructor.
1166         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1167         (WTR::AccessibilityController::platformName): Ditto
1168
1169         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1170         (-[NSString createJSStringRef]): Return a JSRetainPtr.
1171         (makeValueRefForValue): Updated for above by removing adopt.
1172         (makeObjectRefForDictionary): Ditto.
1173         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
1174
1175         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1176         (WTR::createEmptyJSString): Added. This helper function makes reduces the
1177         repetitive code to create empty strings.
1178         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
1179         (WTR::descriptionOfElements): Ditto.
1180         (WTR::selectTextParameterizedAttributeForCriteria): Ditto.
1181         (WTR::AccessibilityUIElement::accessibilityValue const): Use createEmptyJSString,
1182         fixing a storage leak due to missing adoption.
1183         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
1184         (WTR::AccessibilityUIElement::documentURI): Ditto.
1185         (WTR::createJSStringRef): Return a JSRetainPtr.
1186
1187         * WebKitTestRunner/StringFunctions.h:
1188         (WTR::toWK): Take a const& to eliminate a little bit of reference count churn.
1189         (WTR::toJS): Use the adopt function instead of the constructor.
1190
1191 2018-09-14  Dean Jackson  <dino@grorg.org>
1192
1193         Add Justin Michaud.
1194
1195         * Scripts/webkitpy/common/config/contributors.json:
1196
1197 2018-09-14  Ryan Haddad  <ryanhaddad@apple.com>
1198
1199         bots should pass --clobber-old-results to run-webkit-tests
1200         https://bugs.webkit.org/show_bug.cgi?id=189623
1201
1202         Reviewed by Aakash Jain.
1203
1204         In order to ensure that bots to not produce confusing results due to transient execptions,
1205         or run out of space if they continually hit an exception, old layout test results should be clobbered.
1206
1207         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1208         (RunWebKitTests):
1209
1210 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
1211
1212         Unreviewed, rolling out r235954.
1213
1214         Breaks the watchOS build.
1215
1216         Reverted changeset:
1217
1218         "Move IndexedDB to Network Process"
1219         https://bugs.webkit.org/show_bug.cgi?id=189415
1220         https://trac.webkit.org/changeset/235954
1221
1222 2018-09-13  Daniel Bates  <dabates@apple.com>
1223
1224         Add Copy WebKit Permalink plugin for Sublime Text
1225         https://bugs.webkit.org/show_bug.cgi?id=189589
1226
1227         Rubber-stamped by Joseph Pecoraro.
1228
1229         Port the Copy WebKit Permalink Automator service to a Sublime Text plugin. Once installed you can
1230         use the plugin to copy to the Clipboard a trac.webkit.org hyperlink to the selected line in the
1231         active document with or without blame annotations.
1232
1233         Once installed, you can Control-click (on Mac) or right-click (on Windows and Linux) on a line and
1234         choose Copy WebKit Permalink or Copy WebKit Permalink to Blame from the context menu to copy to the
1235         Clipboard a permanent hyperlink to the selected line without or with blame annotations, respectively.
1236         On Mac you can also invoke the same functionality using the keyboard shortcuts Command + Shift + Control + C
1237         and Command + Shift + Control + Option + C, respectively.
1238
1239         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu: Added.
1240         * CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py: Added.
1241         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Default (OSX).sublime-keymap: Added.
1242         * CopyPermalink/Sublime Text/INSTALL: Added.
1243         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/Info.plist: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist.
1244         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/document.wflow: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow.
1245         * CopyPermalink/Xcode/INSTALL: Renamed from Tools/CopyPermalink/README.
1246
1247 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1248
1249         Unreviewed. Fix WebDriver tests after r235225.
1250
1251         Use wpt serve command to run the http server.
1252
1253         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1254         (WebDriverW3CWebServer.__init__):
1255         (WebDriverW3CWebServer.start):
1256         (WebDriverW3CWebServer.stop):
1257
1258 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1259
1260         [GTK][WPE] Allow to run script dialogs asynchronously in the UI process
1261         https://bugs.webkit.org/show_bug.cgi?id=189544
1262
1263         Reviewed by Michael Catanzaro.
1264
1265         Add test cases for the new API.
1266
1267         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1268         (testWebViewJavaScriptDialogs):
1269
1270 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1271
1272         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
1273         https://bugs.webkit.org/show_bug.cgi?id=189496
1274         <rdar://problem/44370981>
1275
1276         Unreviewed warning fix.
1277
1278         r235929 has introduced a new compilation warning:
1279         > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:34:70: warning: unused parameter ‘imageSize’ [-Wunused-parameter]
1280
1281         * ImageDiff/cairo/PlatformImageCairo.cpp:
1282         (ImageDiff::PlatformImage::createFromStdin): Removed the variable name.
1283
1284 2018-09-12  Dan Bernstein  <mitz@apple.com>
1285
1286         [Cocoa] Complete support for Paste as Quotation
1287         https://bugs.webkit.org/show_bug.cgi?id=189504
1288
1289         Reviewed by Wenson Hsieh.
1290
1291         * MiniBrowser/mac/MainMenu.xib: Added a Paste as Quotation command in the Edit menu.
1292
1293 2018-09-12  Sihui Liu  <sihui_liu@apple.com>
1294
1295         Move IndexedDB to Network Process
1296         https://bugs.webkit.org/show_bug.cgi?id=189415
1297
1298         Reviewed by Geoffrey Garen.
1299
1300         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
1301         (TEST):
1302         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1303         (TEST):
1304         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
1305         (TEST):
1306         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
1307         (TEST):
1308         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1309         (TEST):
1310
1311 2018-09-12  Chris Dumez  <cdumez@apple.com>
1312
1313         PSON: No process swap on back navigation after URL bar navigation
1314         https://bugs.webkit.org/show_bug.cgi?id=189557
1315         <rdar://problem/44353108>
1316
1317         Reviewed by Alex Christensen.
1318
1319         Add API test coverage.
1320
1321         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1322
1323 2018-09-11  Dean Jackson  <dino@apple.com>
1324
1325         Header parsing for experimental and internal debug features
1326         https://bugs.webkit.org/show_bug.cgi?id=189486
1327         <rdar://problem/44320618>
1328
1329         Reviewed by Tim Horton.
1330
1331         Keep track of experimental and internal debug features in TestOptions, and
1332         allow webkit-test-runner headers to toggle them by name.
1333
1334         * DumpRenderTree/TestOptions.cpp:
1335         (TestOptions::TestOptions):
1336         * WebKitTestRunner/TestController.cpp:
1337         (WTR::TestController::resetPreferencesToConsistentValues):
1338         (WTR::updateTestOptionsFromTestHeader):
1339         * WebKitTestRunner/TestOptions.h:
1340         (WTR::TestOptions::hasSameInitializationOptions const):
1341
1342 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1343
1344         [Win][Clang][DumpRenderTree] 0 and nullptr can't be implicitly converted to AccessibilityUIElement
1345         https://bugs.webkit.org/show_bug.cgi?id=189492
1346
1347         Reviewed by Alex Christensen.
1348
1349         0 and nullptr can't be implicitly converted to
1350         AccessibilityUIElement because only Windows port typedefs
1351         PlatformUIElement as COMPtr<IAccessible> not a pointer.
1352
1353         Replaced "return 0" and "return nullptr" with "return { nullptr }".
1354
1355         * DumpRenderTree/AccessibilityUIElement.cpp:
1356         (AccessibilityUIElement::horizontalScrollbar const):
1357         (AccessibilityUIElement::verticalScrollbar const):
1358         (AccessibilityUIElement::uiElementAttributeValue const):
1359         (AccessibilityUIElement::accessibilityElementForTextMarker):
1360         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1361         (AccessibilityController::elementAtPoint):
1362         (AccessibilityController::accessibleElementById):
1363         (AccessibilityController::focusedElement):
1364         (AccessibilityController::rootElement):
1365         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1366         (AccessibilityUIElement::elementAtPoint):
1367         (AccessibilityUIElement::linkedUIElementAtIndex):
1368         (AccessibilityUIElement::getChildAtIndex):
1369         (AccessibilityUIElement::titleUIElement):
1370         (AccessibilityUIElement::parentElement):
1371         (AccessibilityUIElement::uiElementForSearchPredicate):
1372         (AccessibilityUIElement::cellForColumnAndRow):
1373         (AccessibilityUIElement::disclosedRowAtIndex):
1374         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1375         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1376         (AccessibilityUIElement::ariaControlsElementAtIndex):
1377         (AccessibilityUIElement::selectedRowAtIndex):
1378         (AccessibilityUIElement::rowAtIndex):
1379         (AccessibilityUIElement::disclosedByRow):
1380         (AccessibilityUIElement::selectedChildAtIndex const):
1381
1382 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1383
1384         FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
1385         https://bugs.webkit.org/show_bug.cgi?id=189382
1386
1387         Reviewed by Ryosuke Niwa.
1388
1389         Fix the test by specifying colors in RGB colorspace.
1390
1391         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1392         (TestWebKitAPI::TEST):
1393
1394 2018-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1395
1396         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
1397         https://bugs.webkit.org/show_bug.cgi?id=189496
1398
1399         Reviewed by Alex Christensen.
1400
1401         * ImageDiff/cairo/PlatformImageCairo.cpp:
1402         (ImageDiff::PlatformImage::createFromStdin): Removed unnecessary ReadContext struct.
1403         (ImageDiff::PlatformImage::writeAsPNGToStdout): Use '%lu' format type specifier for unsigned long.
1404
1405 2018-09-07  Dean Jackson  <dino@apple.com>
1406
1407         Add and expose Internal features from WebKit
1408         https://bugs.webkit.org/show_bug.cgi?id=189442
1409         <rdar://problem/44243404>
1410
1411         Reviewed by Simon Fraser.
1412
1413         Update MiniBrowser to expose an Internal feature menu.
1414
1415         * MiniBrowser/mac/AppDelegate.m:
1416         (defaultConfiguration):
1417         * MiniBrowser/mac/SettingsController.m:
1418         (-[SettingsController _populateMenu]):
1419         (-[SettingsController validateMenuItem:]):
1420         (-[SettingsController toggleExperimentalFeature:]):
1421         (-[SettingsController toggleInternalDebugFeature:]):
1422
1423 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1424
1425         [macOS] [WK2] Support changing foreground colors via color panel
1426         https://bugs.webkit.org/show_bug.cgi?id=189382
1427         <rdar://problem/44227311>
1428
1429         Reviewed by Ryosuke Niwa.
1430
1431         Add an API test that uses NSColorPanel to change the color of selected text, and also apply typing styles when
1432         the selection is collapsed. The test also exercises switching between opaque colors (alpha = 1) and transparent
1433         colors, as well as making different parts of a word different colors.
1434
1435         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1436         (-[TestWKWebView collapseToEnd]):
1437         (webViewForFontManagerTesting):
1438         (TestWebKitAPI::TEST):
1439         * TestWebKitAPI/cocoa/TestWKWebView.h:
1440
1441 == Rolled over to ChangeLog-2018-09-11 ==