[iOS] Mouse/Touch/Pointer events are missing modifier keys
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-11  Daniel Bates  <dabates@apple.com>
2
3         [iOS] Mouse/Touch/Pointer events are missing modifier keys
4         https://bugs.webkit.org/show_bug.cgi?id=191446
5         <rdar://problem/45929460>
6
7         Reviewed by Tim Horton.
8
9         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
10
11         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
12         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
13         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
14         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
15         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
16         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
17         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
18         * TestRunnerShared/UIScriptContext/UIScriptController.h:
19         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
20         (WTR::arrayLength):
21         (WTR::parseModifierArray):
22         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
23         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
24         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
25         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
26
27 2019-02-11  Commit Queue  <commit-queue@webkit.org>
28
29         Unreviewed, rolling out r241272 and r241276.
30         https://bugs.webkit.org/show_bug.cgi?id=194514
31
32         Broke the Apple Internal build and the fix requires human
33         intervention :( (Requested by dydz on #webkit).
34
35         Reverted changesets:
36
37         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
38         https://bugs.webkit.org/show_bug.cgi?id=191446
39         https://trac.webkit.org/changeset/241272
40
41         "Fix internal iOS build after r241272"
42         https://bugs.webkit.org/show_bug.cgi?id=191446
43         https://trac.webkit.org/changeset/241276
44
45 2019-02-11  Truitt Savell  <tsavell@apple.com>
46
47         Unreviewed, rolling out r241269.
48
49         Caused 5 layout tests crashes on Mac WK1
50
51         Reverted changeset:
52
53         "DumpRenderTree should report unknown options"
54         https://bugs.webkit.org/show_bug.cgi?id=191303
55         https://trac.webkit.org/changeset/241269
56
57 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
58
59         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
60         https://bugs.webkit.org/show_bug.cgi?id=194313
61
62         Reviewed by Tim Horton.
63
64         Add a helper to determine whether the web view is presenting modal UI.
65
66         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
67         (WTR::UIScriptController::isPresentingModally const):
68         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
69         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
70         (WTR::UIScriptController::isPresentingModally const):
71         * TestRunnerShared/UIScriptContext/UIScriptController.h:
72         * WebKitTestRunner/UIScriptControllerCocoa.mm:
73         (WTR::UIScriptController::calendarType const): Deleted.
74         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
75         (WTR::UIScriptController::isPresentingModally const):
76         (WTR::UIScriptController::calendarType const):
77         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
78         (WTR::UIScriptController::calendarType const):
79
80 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
81
82         GCHeapInspector: Show the retained sizes in more places
83         https://bugs.webkit.org/show_bug.cgi?id=194464
84
85         Reviewed by Simon Fraser.
86
87         * GCHeapInspector/gc-heap-inspector.html:
88         * GCHeapInspector/script/interface.js:
89         (HeapInspectorUtils.humanReadableSize):
90         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
91         (HeapInspectorUtils.spanForNode.span.span):
92         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
93         (HeapSnapshotInspector.prototype.buildRoots):
94
95 2019-02-11  Daniel Bates  <dabates@apple.com>
96
97         [iOS] Mouse/Touch/Pointer events are missing modifier keys
98         https://bugs.webkit.org/show_bug.cgi?id=191446
99         <rdar://problem/45929460>
100
101         Reviewed by Tim Horton.
102
103         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
104
105         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
106         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
107         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
108         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
109         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
110         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
111         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
112         * TestRunnerShared/UIScriptContext/UIScriptController.h:
113         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
114         (WTR::arrayLength):
115         (WTR::parseModifierArray):
116         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
117         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
118         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
119         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
120
121 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
122
123         DumpRenderTree should report unknown options
124         https://bugs.webkit.org/show_bug.cgi?id=191303
125
126         Reviewed by Frédéric Wang.
127
128         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
129         to report unknown options.
130         Added and assigned test options which are currently used in tests.
131
132         * DumpRenderTree/TestOptions.cpp:
133         (TestOptions::TestOptions):
134
135 2019-02-11  Truitt Savell  <tsavell@apple.com>
136
137         Unreviewed, rolling out r241229.
138
139         Revision broke internal builds for watchOS.
140
141         Reverted changeset:
142
143         "[Cocoa] Ask platform for generic font family mappings"
144         https://bugs.webkit.org/show_bug.cgi?id=187723
145         https://trac.webkit.org/changeset/241229
146
147 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
148
149         [WinCairo][MiniBrowser] Basic authentication always fails.
150         https://bugs.webkit.org/show_bug.cgi?id=194496
151
152         Reviewed by Don Olmstead.
153
154         * MiniBrowser/win/DialogHelper.h:
155         (Dialog::getText):
156
157 2019-02-11  Philippe Normand  <pnormand@igalia.com>
158
159         [GStreamer] GstMappedBuffer testsuite build fails
160         https://bugs.webkit.org/show_bug.cgi?id=194495
161
162         Reviewed by Carlos Garcia Campos.
163
164         Fix the build by explicitely adding the gstreamer1.0-audio include
165         directories to the include path.
166
167         * TestWebKitAPI/PlatformGTK.cmake:
168         * TestWebKitAPI/PlatformWPE.cmake:
169
170 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
171
172         [GTK][WPE] Add enable-javascript-markup setting
173         https://bugs.webkit.org/show_bug.cgi?id=193439
174
175         Reviewed by Michael Catanzaro.
176
177         Add test cases to check the new setting.
178
179         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
180         (testWebKitSettings):
181         (testWebKitSettingsJavaScriptMarkup):
182         (beforeAll):
183
184 2019-02-10  Darin Adler  <darin@apple.com>
185
186         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
187         https://bugs.webkit.org/show_bug.cgi?id=194485
188
189         Reviewed by Daniel Bates.
190
191         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
192
193 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
194
195         Add more tests for clampTo<>()
196         https://bugs.webkit.org/show_bug.cgi?id=194462
197
198         Reviewed by Geoffrey Garen.
199
200         Darin suggested to test the very last floating point number
201         at the boundaries when truncating to integer.
202         I added test for max/min and max-1/min-1.
203
204         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
205         (TestWebKitAPI::TEST):
206
207 2019-02-09  Darin Adler  <darin@apple.com>
208
209         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
210         https://bugs.webkit.org/show_bug.cgi?id=194021
211
212         Reviewed by Geoffrey Garen.
213
214         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
215         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
216         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
217
218 2019-02-09  Zalan Bujtas  <zalan@apple.com>
219
220         [LFC][IFC] Add intrinsic width support for basic inline containers
221         https://bugs.webkit.org/show_bug.cgi?id=194473
222
223         Reviewed by Antti Koivisto.
224
225         Expand tests coverage (11 new tests -> 798)
226
227         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
228
229 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
230
231         Fix MiniBrowser's entitlements
232         https://bugs.webkit.org/show_bug.cgi?id=192431
233
234         Reviewed by Joseph Pecoraro.
235
236         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
237         files, making it impossible to load any extension.
238
239         * MiniBrowser/MiniBrowser.entitlements:
240
241 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
242
243         [Cocoa] Ask platform for generic font family mappings
244         https://bugs.webkit.org/show_bug.cgi?id=187723
245         <rdar://problem/41892438>
246
247         Reviewed by Brent Fulgham.
248
249         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
250
251         * DumpRenderTree/mac/DumpRenderTree.mm:
252         (allowedFontFamilySet):
253         * WebKitTestRunner/mac/TestControllerMac.mm:
254         (WTR::allowedFontFamilySet):
255
256 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
257
258         [GTK] Implement back/forward touchpad gesture
259         https://bugs.webkit.org/show_bug.cgi?id=193919
260
261         Reviewed by Michael Catanzaro.
262
263         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
264         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
265
266 2019-02-08  Alex Christensen  <achristensen@webkit.org>
267
268         Add SPI to use networking daemon instead of XPC service
269         https://bugs.webkit.org/show_bug.cgi?id=194427
270
271         Reviewed by Geoffrey Garen
272
273         * MiniBrowser/MiniBrowser.entitlements:
274
275 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
276
277         [ews-build] Ensure that every builder in config.json has short name
278         https://bugs.webkit.org/show_bug.cgi?id=194461
279
280         Reviewed by Lucas Forschler.
281
282         * BuildSlaveSupport/ews-build/loadConfig.py:
283         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
284
285 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
286
287         [ews-build] Add short name to config.json
288         https://bugs.webkit.org/show_bug.cgi?id=194456
289
290         Reviewed by Lucas Forschler.
291
292         * BuildSlaveSupport/ews-build/config.json: Added short name.
293         * BuildSlaveSupport/ews-build/loadConfig.py:
294         (loadBuilderConfig): Set the short name as the builder description.
295
296 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
297
298         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
299         https://bugs.webkit.org/show_bug.cgi?id=194418
300
301         Reviewed by Lucas Forschler.
302
303         Do not include errors trying when finding crashlogs at the end of
304         a run-webkit-tests run since we don't process those errors.
305
306         * Scripts/webkitpy/port/darwin.py:
307         (DarwinPort._look_for_all_crash_logs_in_log_dir):
308         * Scripts/webkitpy/port/ios_device.py:
309         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
310         * Scripts/webkitpy/port/watch_device.py:
311         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
312
313 2019-02-08  Beth Dakin  <bdakin@apple.com>
314
315         Add afterScreenUpdates to WKSnapshotConfiguration
316         https://bugs.webkit.org/show_bug.cgi?id=194362
317         -and corresponding-
318         <rdar://problem/40655528> Please add an "after screen updates" property to 
319         WKSnapshotConfiguration (to solve blank snapshots)
320
321         Reviewed by Tim Horton.
322
323         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
324         (TEST):
325
326 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
327
328         clampTo(): do not convert the input to double when dealing with integers
329         https://bugs.webkit.org/show_bug.cgi?id=194263
330         <rdar://problem/47692312>
331
332         Reviewed by Darin Adler.
333
334         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
335         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
336         (TestWebKitAPI::testClampFloatingPointToInteger):
337         (TestWebKitAPI::testClampSameSignIntegers):
338         (TestWebKitAPI::testClampUnsignedToSigned):
339         (TestWebKitAPI::testClampSignedToUnsigned):
340
341 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
342
343         webkitpy: Respect --dedicated-simulators flag
344         https://bugs.webkit.org/show_bug.cgi?id=194416
345         <rdar://problem/47894722>
346
347         Reviewed by Lucas Forschler.
348
349         * Scripts/webkitpy/port/device_port.py:
350         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
351         available devices can be safely ignored.
352
353 2019-02-07  Keith Rollin  <krollin@apple.com>
354
355         Remove extra copy of 100x100-red.tga
356         https://bugs.webkit.org/show_bug.cgi?id=194371
357         <rdar://problem/47873465>
358
359         Reviewed by Said Abou-Hallawa.
360
361         In order to help it pass its tests, Bug 194190 added a second copy of
362         the file 100x100-red.tga. However, it turns out that this additional
363         file wasn't actually needed, and that that sole previous copy was
364         sufficient. At the same time, this second copy -- which was copied to
365         the same location in the build output as the first copy -- now caused
366         XCBuild to complain because there were two production rules for the
367         same output file. Address this by removing the newly-added extra copy.
368
369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
370         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
371
372 2019-02-07  Alex Christensen  <achristensen@webkit.org>
373
374         Deprecate WKBundlePageSetDefersLoading
375         https://bugs.webkit.org/show_bug.cgi?id=191394
376
377         Reviewed by Dean Jackson.
378
379         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
380         (WTR::TestRunner::setDefersLoading):
381
382 2019-02-07  Zalan Bujtas  <zalan@apple.com>
383
384         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
385         https://bugs.webkit.org/show_bug.cgi?id=194391
386
387         Reviewed by Antti Koivisto.
388
389         * LayoutReloaded/misc/LFC-passing-tests.txt:
390
391 2019-02-06  Keith Rollin  <krollin@apple.com>
392
393         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
394         https://bugs.webkit.org/show_bug.cgi?id=193975
395         <rdar://problem/47643306>
396
397         Reviewed by Tim Horton.
398
399         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
400         the Info.plist file into the bundle. This step is not necessary as the
401         implicit "bundle up all the build products into a framework" build
402         phase does this already. Having the Copy Bundle Resources phase do
403         this causes a conflict under XCBuild, which objects to two build
404         phases producing the same file (Info.plist). Address this by removing
405         Info.plist from the Copy Bundle Resources phase.
406
407         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
408
409 2019-02-06  Keith Rollin  <krollin@apple.com>
410
411         Really enable the automatic checking and regenerations of .xcfilelists during builds
412         https://bugs.webkit.org/show_bug.cgi?id=194357
413         <rdar://problem/47861231>
414
415         Reviewed by Chris Dumez.
416
417         Bug 194124 was supposed to enable the automatic checking and
418         regenerating of .xcfilelist files during the build. While related
419         changes were included in that patch, the change to actually enable the
420         operation somehow was omitted. This patch actually enables the
421         operation. The check-xcfilelist.sh scripts now check
422         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
423         from the checking.
424
425         * DumpRenderTree/Scripts/check-xcfilelists.sh:
426         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
427
428 2019-02-06  David Kilzer  <ddkilzer@apple.com>
429
430         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
431         <https://webkit.org/b/194286>
432         <rdar://problem/47815558>
433
434         Reviewed by Alexey Proskuryakov.
435
436         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
437         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
438         WKRetainPtr<> to avoid leaking the WKDataRef.
439
440 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
441
442         Unreviewed, fix a typo
443
444         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
445
446 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
447
448         [GTK][WPE] force libpsl build to use ICU in jhbuild
449         https://bugs.webkit.org/show_bug.cgi?id=194288
450
451         Reviewed by Carlos Garcia Campos.
452
453         * gtk/jhbuild.modules:
454         Require ICU for libpsl build in jhbuild, like done in WPE.
455
456 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
457
458         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
459         https://bugs.webkit.org/show_bug.cgi?id=194209
460
461         Reviewed by Carlos Garcia Campos.
462
463         Enhance TestCookieManager to ensure this doesn't happen again.
464
465         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
466         (testCookieManagerPersistentStorage):
467         (beforeAll):
468
469 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
470
471         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
472         https://bugs.webkit.org/show_bug.cgi?id=194324
473
474         Reviewed by Andy Estes.
475
476         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
477         part of the name is already implicit, since this is in testing code in TestOptions.
478
479         * WebKitTestRunner/TestController.cpp:
480         (WTR::TestController::generateContextConfiguration const):
481         (WTR::updateTestOptionsFromTestHeader):
482         * WebKitTestRunner/TestOptions.h:
483         (WTR::TestOptions::hasSameInitializationOptions const):
484
485 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
486
487         [ews-build] Allow * as platform for builders and workers
488         https://bugs.webkit.org/show_bug.cgi?id=188533
489
490         Reviewed by Lucas Forschler.
491
492         * BuildSlaveSupport/ews-build/loadConfig.py:
493         (checkWorkersAndBuildersForConsistency):
494
495 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
496
497         [ews-build] Add few bots to config.json
498         https://bugs.webkit.org/show_bug.cgi?id=194304
499
500         Reviewed by Lucas Forschler.
501
502         * BuildSlaveSupport/ews-build/config.json:
503
504 2019-02-05  Keith Rollin  <krollin@apple.com>
505
506         Enable the automatic checking and regenerations of .xcfilelists during builds
507         https://bugs.webkit.org/show_bug.cgi?id=194124
508         <rdar://problem/47721277>
509
510         Reviewed by Tim Horton.
511
512         Bug 193790 add a facility for checking -- during build time -- that
513         any needed .xcfilelist files are up-to-date and for updating them if
514         they are not. This facility was initially opt-in by setting
515         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
516         the process seemed robust. Its now time to enable this facility and
517         make it opt-out. If there is a need to disable this facility, set and
518         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
519         running `make` or `build-webkit`, or before running Xcode from the
520         command line.
521
522         Additionally, remove the step that generates a list of source files
523         going into the UnifiedSources build step. It's only necessarily to
524         specify Sources.txt and SourcesCocoa.txt as inputs.
525
526         * Scripts/generate-xcfilelists:
527
528 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
529
530         [GTK][WPE] force libpsl build to use ICU in jhbuild
531         https://bugs.webkit.org/show_bug.cgi?id=194288
532
533         Reviewed by Philippe Normand.
534
535         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
536         This can cause build failures if libidn is detected but libunistring is not available.
537
538         Make sure that ICU is used for runtime and builtin PSL data.
539
540         * gtk/jhbuild.modules:
541         * wpe/jhbuild.modules:
542
543 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
544
545         [ews-app] Modified timestamp should be updated on updating data
546         https://bugs.webkit.org/show_bug.cgi?id=194295
547
548         Reviewed by Lucas Forschler.
549
550         * BuildSlaveSupport/ews-app/ews/models/build.py:
551         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
552         * BuildSlaveSupport/ews-app/ews/models/step.py:
553
554 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
555
556         Unreviewed, rolling out r240742.
557
558         Causes crashes on iOS simulator.
559
560         Reverted changeset:
561
562         "[iOS] Keyups for non-modifier keys identified as "Dead" when
563         not focused in a content-editable element"
564         https://bugs.webkit.org/show_bug.cgi?id=192824
565         https://trac.webkit.org/changeset/240742
566
567 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
568
569         run-webkit-tests emits message "...running None" when running tests
570         https://bugs.webkit.org/show_bug.cgi?id=194133
571         <rdar://problem/47724738>
572
573         Reviewed by Lucas Forschler.
574
575         * Scripts/webkitpy/xcode/device_type.py:
576         (DeviceType.__str__): Use both version mapping tables and use just the variant
577         name if no version name is available.
578         * Scripts/webkitpy/xcode/device_type_unittest.py:
579         (DeviceTypeTest):
580         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
581         an associated named.
582
583 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
584
585         [WPE] require python3-setuptools for meson build in jhbuild
586         https://bugs.webkit.org/show_bug.cgi?id=194287
587
588         Reviewed by Philippe Normand.
589
590         python3-setuptools is needed to build meson in jhbuild.
591         It is already required by the GTK port.
592
593         * wpe/install-dependencies:
594
595 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
596
597         [ews-app] Add method to save BuilderMapping to database
598         https://bugs.webkit.org/show_bug.cgi?id=194264
599
600         Reviewed by Lucas Forschler.
601
602         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
603         (BuilderMapping.__str__):
604         (BuilderMapping):
605         (BuilderMapping.save_mapping):
606         (BuilderMapping.update_mapping):
607         (BuilderMapping.get_existing_mapping):
608         (BuilderMapping.is_valid_mapping):
609
610 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
611
612         [ews-app] Add timestamp fields for BuilderMappings
613         https://bugs.webkit.org/show_bug.cgi?id=194266
614
615         Reviewed by Lucas Forschler.
616
617         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
618         (BuilderMapping):
619
620 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
621
622         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
623         https://bugs.webkit.org/show_bug.cgi?id=174816
624
625         Reviewed by Michael Catanzaro.
626
627         Add tests for webkit_uri_for_display().
628
629         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
630         (testURIForDisplayUnaffected):
631         (testURIForDisplayAffected):
632         (beforeAll):
633         (afterAll):
634         * TestWebKitAPI/glib/CMakeLists.txt:
635
636 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
637
638         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
639         https://bugs.webkit.org/show_bug.cgi?id=194158
640         <rdar://problem/47737268>
641
642         Rubber-stamped by Aakash Jain.
643
644         * Scripts/webkitpy/port/device_port.py:
645         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
646
647 2019-02-04  Said Abou-Hallawa  <said@apple.com>
648
649         [CG] Enable setAdditionalSupportedImageTypes for WK1
650         https://bugs.webkit.org/show_bug.cgi?id=194190
651
652         Reviewed by Tim Horton.
653
654         Add a test similar to the one under WebKit Cocoa but make it create a
655         WebView instead of a WKWebView.
656
657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
658         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
659         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
660         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
661         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
662         (TestWebKitAPI::runTest):
663         (TestWebKitAPI::TEST):
664
665 2019-02-04  Zalan Bujtas  <zalan@apple.com>
666
667         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
668         https://bugs.webkit.org/show_bug.cgi?id=194168
669
670         Reviewed by Simon Fraser.
671
672         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
673
674         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
675         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
676         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
677         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
678         (TEST):
679         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
680         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
681
682 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
683
684         REGRESSION (r237269): webkit-patch what-broke is broken 
685         https://bugs.webkit.org/show_bug.cgi?id=193025
686
687         Reviewed by Aakash Jain.
688
689         * Scripts/webkitpy/common/host.py:
690         (Host.buildbot):
691         (Host.bugzilla): Renamed to 'buildbot'.
692
693 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
694
695         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
696         https://bugs.webkit.org/show_bug.cgi?id=194207
697
698         Reviewed by Tim Horton.
699
700         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
701         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
702         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
703         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
704         start and delete forwards to remove the original attachment.
705
706         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
707         (TestWebKitAPI::TEST):
708
709 2019-02-04  Youenn Fablet  <youenn@apple.com>
710
711         Capture state should be managed consistently when doing process swapping
712         https://bugs.webkit.org/show_bug.cgi?id=194122
713         <rdar://problem/47609293>
714
715         Reviewed by Eric Carlson.
716
717         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
718         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
719         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
720         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
721         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
722         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
723         (WTR::TestRunner::isDoingMediaCapture const):
724         * WebKitTestRunner/InjectedBundle/TestRunner.h:
725         * WebKitTestRunner/TestController.cpp:
726         (WTR::TestController::isDoingMediaCapture const):
727         * WebKitTestRunner/TestController.h:
728         * WebKitTestRunner/TestInvocation.cpp:
729         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
730         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
731         (WTR::TestController::isDoingMediaCapture const):
732
733 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
734
735         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
736         https://bugs.webkit.org/show_bug.cgi?id=194142
737
738         Reviewed by Ross Kirsling.
739
740         There three 'separator' variables in TestController.cpp. Renamed
741         it 'pathSeparator', and unified them.
742
743         * WebKitTestRunner/TestController.cpp:
744         (WTR::TestController::generateContextConfiguration const):
745         (WTR::createTestURL):
746         (WTR::TestController::platformAdjustContext):
747
748 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
749
750         Make setNeedsLayout on the root more explicitly about triggering its side-effects
751         https://bugs.webkit.org/show_bug.cgi?id=194198
752
753         Reviewed by Antti Koivisto.
754
755         No need to set the banner heights on navigation now, since Page stores them.
756
757         * MiniBrowser/mac/WK2BrowserWindowController.m:
758         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
759
760 2019-02-03  John Wilander  <wilander@apple.com>
761
762         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
763         https://bugs.webkit.org/show_bug.cgi?id=194104
764         <rdar://problem/47649991>
765
766         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
767
768         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
769         (TestWebKitAPI::TEST):
770             Changed numeric types from unsigned short to uint32_t.
771
772 2019-02-02  David Kilzer  <ddkilzer@apple.com>
773
774         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
775         <https://webkit.org/b/194178>
776         <rdar://problem/47753473>
777
778         Reviewed by Alexey Proskuryakov.
779
780         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
781         (WTR::uninstallFakeHelvetica): Pass nullptr into
782         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
783
784 2019-02-02  Zalan Bujtas  <zalan@apple.com>
785
786         [LFC] Initialize ICB's style with fixed width/height.
787         https://bugs.webkit.org/show_bug.cgi?id=194188
788
789         Reviewed by Antti Koivisto.
790
791         * LayoutReloaded/misc/LFC-passing-tests.txt:
792
793 2019-02-02  Zalan Bujtas  <zalan@apple.com>
794
795         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
796         https://bugs.webkit.org/show_bug.cgi?id=194185
797
798         Reviewed by Antti Koivisto.
799
800         * LayoutReloaded/misc/LFC-passing-tests.txt:
801
802 2018-12-16  Darin Adler  <darin@apple.com>
803
804         Convert additional String::format clients to alternative approaches
805         https://bugs.webkit.org/show_bug.cgi?id=192746
806
807         Reviewed by Alexey Proskuryakov.
808
809         * WebKitTestRunner/TestController.cpp:
810         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
811         as an intermediate in code that ultimately constructs a WTF::String.
812         (WTR::userMediaOriginHash): Use makeString.
813         (WTR::TestController::didNavigateWithNavigationData): More of the same.
814         (WTR::TestController::didPerformClientRedirect): Ditto.
815         (WTR::TestController::didPerformServerRedirect): Ditto.
816         (WTR::TestController::didUpdateHistoryTitle): Ditto.
817
818 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
819
820         [ews-build] Add unit test to verify builder keys
821         https://bugs.webkit.org/show_bug.cgi?id=194152
822
823         Reviewed by Lucas Forschler.
824
825         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
826         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
827
828 2019-02-01  Zalan Bujtas  <zalan@apple.com>
829
830         [LFC] Expand tests coverage (12 new tests -> 787)
831
832         Unreviewed test gardening.
833
834         * LayoutReloaded/misc/LFC-passing-tests.txt:
835
836 2019-02-01  Zalan Bujtas  <zalan@apple.com>
837
838         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
839         https://bugs.webkit.org/show_bug.cgi?id=194163
840
841         Reviewed by Simon Fraser.
842
843         775
844
845         * LayoutReloaded/misc/LFC-passing-tests.txt:
846
847 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
848
849         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
850         https://bugs.webkit.org/show_bug.cgi?id=194140
851         <rdar://problem/47728098>
852
853         Reviewed by Tim Horton.
854
855         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
856         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
857         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
858
859         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
860         test to induce an IPC deadlock when presenting a modal alert during touch start.
861
862         * WebKitTestRunner/InjectedBundle/TestRunner.h:
863         * WebKitTestRunner/TestController.cpp:
864         (WTR::runJavaScriptAlert):
865
866         Add a client callback function for running JavaScript alerts.
867
868         (WTR::TestController::createOtherPage):
869         (WTR::TestController::generateContextConfiguration const):
870
871         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
872         the fix in this patch.
873
874         (WTR::TestController::createWebViewWithOptions):
875
876         Plumb TestOptions to generateContextConfiguration.
877
878         (WTR::TestController::resetPreferencesToConsistentValues):
879         (WTR::TestController::resetStateToConsistentValues):
880         (WTR::updateTestOptionsFromTestHeader):
881         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
882         (WTR::TestController::handleJavaScriptAlert):
883         * WebKitTestRunner/TestController.h:
884         * WebKitTestRunner/TestInvocation.cpp:
885         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
886         * WebKitTestRunner/TestOptions.h:
887         (WTR::TestOptions::hasSameInitializationOptions const):
888
889 2019-02-01  Chris Dumez  <cdumez@apple.com>
890
891         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
892         https://bugs.webkit.org/show_bug.cgi?id=193740
893         <rdar://problem/47527267>
894
895         Reviewed by Alex Christensen.
896
897         Add API test coverage.
898
899         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
900
901 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
902
903         [ews-app] Add display name field to BuilderMapping model
904         https://bugs.webkit.org/show_bug.cgi?id=194153
905
906         Reviewed by Lucas Forschler.
907
908         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
909         (BuilderMapping):
910
911 2019-02-01  Youenn Fablet  <youenn@apple.com>
912
913         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
914         https://bugs.webkit.org/show_bug.cgi?id=194155
915
916         Reviewed by Eric Carlson.
917
918         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
919         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
920         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
921
922 2019-02-01  Zalan Bujtas  <zalan@apple.com>
923
924         [LFC] Adjust replaced element's intrinsic ratio
925         https://bugs.webkit.org/show_bug.cgi?id=194154
926
927         Reviewed by Antti Koivisto.
928
929         761
930
931         * LayoutReloaded/misc/LFC-passing-tests.txt:
932
933 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
934
935         [WPE] Show test results in minibrowser
936         https://bugs.webkit.org/show_bug.cgi?id=194150
937
938         Reviewed by Žan Doberšek.
939
940         * Scripts/webkitpy/port/wpe.py:
941         (WPEPort.show_results_html_file):
942
943 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
944
945         [WPE] MiniBrowser: add ky bindings for back/forward navigation
946         https://bugs.webkit.org/show_bug.cgi?id=194151
947
948         Reviewed by Žan Doberšek.
949
950         ALT + <- go back
951         ALT + -> go forward
952
953         * MiniBrowser/wpe/main.cpp:
954         (main):
955
956 2019-02-01  Zalan Bujtas  <zalan@apple.com>
957
958         [LFC] Set intrinsic size on Layout::Replaced
959         https://bugs.webkit.org/show_bug.cgi?id=194139
960
961         Reviewed by Antti Koivisto.
962
963         744
964
965         * LayoutReloaded/misc/LFC-passing-tests.txt:
966
967 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
968
969         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
970         https://bugs.webkit.org/show_bug.cgi?id=194146
971
972         Reviewed by Xabier Rodriguez-Calvar.
973
974         It allows to open relative paths.
975
976         * MiniBrowser/wpe/main.cpp:
977         (main):
978
979 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
980
981         Update flakiness dashboard configuration after recent queue changes
982         https://bugs.webkit.org/show_bug.cgi?id=194127
983
984         Rubber-stamped by Aakash Jain.
985
986         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
987
988         * TestResultServer/static-dashboards/builders.jsonp:
989
990 2019-01-31  Youenn Fablet  <youenn@apple.com>
991
992         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
993         https://bugs.webkit.org/show_bug.cgi?id=194106
994         <rdar://problem/47676333>
995
996         Reviewed by Ryosuke Niwa.
997
998         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
999         (TestWebKitAPI::didFinishNavigation):
1000         (TestWebKitAPI::TEST):
1001         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1002
1003 2019-01-31  Chris Dumez  <cdumez@apple.com>
1004
1005         Page zoom level is lost after a process swap or a crash
1006         https://bugs.webkit.org/show_bug.cgi?id=194105
1007         <rdar://problem/47610781>
1008
1009         Reviewed by Alex Christensen.
1010
1011         Add API test coverage.
1012
1013         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1014         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1015
1016 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1017
1018         Revert r238819 which is unneeded and caused a performance regression.
1019         https://bugs.webkit.org/show_bug.cgi?id=192272
1020         <rdar://problem/46664625>
1021
1022         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1023         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1024         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1025
1026 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1027
1028         Formalize WebKitAdditions mechanism of LoadOptimizer
1029         https://bugs.webkit.org/show_bug.cgi?id=193886
1030         <rdar://problem/47696809>
1031
1032         Reviewed by Brent Fulgham.
1033
1034         * MiniBrowser/MiniBrowser.entitlements:
1035         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1036
1037 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1038
1039         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1040         https://bugs.webkit.org/show_bug.cgi?id=194090
1041
1042         Reviewed by Antti Koivisto.
1043
1044         * LayoutReloaded/misc/LFC-passing-tests.txt:
1045
1046 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1047
1048         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1049         https://bugs.webkit.org/show_bug.cgi?id=194074
1050
1051         Reviewed by Antti Koivisto.
1052
1053         * LayoutReloaded/misc/LFC-passing-tests.txt:
1054
1055 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1056
1057         [LFC][BFC] Add support for block level replaced box.
1058         https://bugs.webkit.org/show_bug.cgi?id=194071
1059
1060         Reviewed by Antti Koivisto.
1061
1062         * LayoutReloaded/misc/LFC-passing-tests.txt:
1063
1064 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1065
1066         Fix WebKitTestRunner's testPath with Windows full paths
1067         https://bugs.webkit.org/show_bug.cgi?id=194012
1068
1069         Reviewed by Alex Christensen.
1070
1071         updateTestOptionsFromTestHeader failed to open test files because
1072         testPath returned wrong file paths. It returned a path "/C:/..."
1073         if a URL "file:///C:/..." was given.
1074
1075         * WebKitTestRunner/TestController.cpp:
1076         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1077
1078 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1079
1080         [WPE] Bump font related dependencies to match the GTK+ port
1081         https://bugs.webkit.org/show_bug.cgi?id=194017
1082
1083         Reviewed by Žan Doberšek.
1084
1085         * wpe/jhbuild.modules:
1086         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1087         * wpe/patches/icudata-stdlibs.patch: Added.
1088
1089 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1090
1091         Enable swipe tests on iOS
1092         https://bugs.webkit.org/show_bug.cgi?id=194076
1093
1094         Reviewed by Geoffrey Garen.
1095
1096         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1097         it causes a debug assertion failure in runUIScript.
1098
1099         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1100         (WTR::UIScriptController::beginBackSwipe):
1101         (WTR::UIScriptController::completeBackSwipe):
1102
1103 2019-01-30  Keith Rollin  <krollin@apple.com>
1104
1105         Use correct printf format specifier
1106         https://bugs.webkit.org/show_bug.cgi?id=194062
1107         <rdar://problem/47686167>
1108
1109         Reviewed by Alexey Proskuryakov.
1110
1111         LayoutTestSpellChecker.mm is trying to format a variable of type
1112         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1113         actually an unsigned long long. Fix this by formatting with %llu.
1114
1115         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1116         (-[LayoutTestTextCheckingResult description]):
1117
1118 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1119
1120         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1121         https://bugs.webkit.org/show_bug.cgi?id=193979
1122
1123         Reviewed by Wenson Hsieh.
1124
1125         Fix the test for iOS. Make the test work with iOS UA string.
1126
1127         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1128
1129 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1130
1131         Replace High Sierra LLINT CLoop bot due to hardware failure
1132         https://bugs.webkit.org/show_bug.cgi?id=194066
1133
1134         Reviewed by Aakash Jain.
1135
1136         * BuildSlaveSupport/build.webkit.org-config/config.json:
1137
1138 2019-01-30  Keith Rollin  <krollin@apple.com>
1139
1140         [NSDragItem init] is unavailable
1141         https://bugs.webkit.org/show_bug.cgi?id=194059
1142         <rdar://problem/47685715>
1143
1144         Reviewed by Wenson Hsieh.
1145
1146         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1147         DumpRenderTree and TestWebKitAPI, which both try to create an
1148         NSDragItem in a manner that invokes this method. Address this by using
1149         -initWithPasteboardWriter instead.
1150
1151         Note that the parameter passed to initWithPasteboardWriter is likely
1152         incorrect. In both cases, the object passed does not conform to
1153         NSPasteboardWriting. However, with this fix, we're no worse off than
1154         before, and can now perform builds with newer compilers and SDKs until
1155         a real fix can be crafted. That work is tracked in
1156         https://bugs.webkit.org/show_bug.cgi?id=194060
1157
1158         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1159         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1160         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1161         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1162
1163 2019-01-30  Daniel Bates  <dabates@apple.com>
1164
1165         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1166         https://bugs.webkit.org/show_bug.cgi?id=192824
1167         <rdar://problem/47100332>
1168
1169         Reviewed by Wenson Hsieh.
1170
1171         Fix a bug where the wrong usage code was used for F13 thru F24.
1172
1173         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1174         (keyCodeForDOMFunctionKey):
1175
1176 2019-01-30  Chris Dumez  <cdumez@apple.com>
1177
1178         Regression(PSON) Load hang can occur on history navigation
1179         https://bugs.webkit.org/show_bug.cgi?id=194030
1180         <rdar://problem/47656939>
1181
1182         Reviewed by Antti Koivisto.
1183
1184         Add API test coverage.
1185
1186         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1187
1188 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1189
1190         [LFC] Expand tests coverage.
1191
1192         Unreviewed test gardening.
1193
1194         * LayoutReloaded/misc/LFC-passing-tests.txt:
1195
1196 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1197
1198         [Flatpak] Add openjpeg support
1199         https://bugs.webkit.org/show_bug.cgi?id=194019
1200
1201         Reviewed by Michael Catanzaro.
1202
1203         * flatpak/org.webkit.CommonModules.yaml:
1204
1205 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1206
1207         Unreviewed, rolling out r240708.
1208         https://bugs.webkit.org/show_bug.cgi?id=194022
1209
1210         It broke WPE build (Requested by KaL on #webkit).
1211
1212         Reverted changeset:
1213
1214         "[WPE] Bump font related dependencies to match the GTK+ port"
1215         https://bugs.webkit.org/show_bug.cgi?id=194017
1216         https://trac.webkit.org/changeset/240708
1217
1218 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1219
1220         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1221         https://bugs.webkit.org/show_bug.cgi?id=194001
1222
1223         Reviewed by Antti Koivisto.
1224
1225         * LayoutReloaded/misc/LFC-passing-tests.txt:
1226
1227 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1228
1229         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1230         https://bugs.webkit.org/show_bug.cgi?id=194020
1231
1232         Reviewed by Antti Koivisto.
1233
1234         * LayoutReloaded/misc/LFC-passing-tests.txt:
1235
1236 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1237
1238         AX: Support color well on iOS
1239         https://bugs.webkit.org/show_bug.cgi?id=194010
1240
1241         Reviewed by Joanmarie Diggs.
1242
1243         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1244         (WTR::AccessibilityUIElement::stringAttributeValue):
1245
1246 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1247
1248         [WPE] Bump font related dependencies to match the GTK+ port
1249         https://bugs.webkit.org/show_bug.cgi?id=194017
1250
1251         Reviewed by Žan Doberšek.
1252
1253         * wpe/jhbuild.modules:
1254         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1255         * wpe/patches/icudata-stdlibs.patch: Added.
1256
1257 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1258
1259         [Mac] Update window scale API usage
1260         https://bugs.webkit.org/show_bug.cgi?id=193991
1261         rdar://problem/47614795
1262
1263         Reviewed by Tim Horton.
1264
1265         * DumpRenderTree/mac/DumpRenderTree.mm:
1266         (changeWindowScaleIfNeeded):
1267         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1268         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1269         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1270
1271 2019-01-29  Chris Dumez  <cdumez@apple.com>
1272
1273         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1274         https://bugs.webkit.org/show_bug.cgi?id=193977
1275         <rdar://problem/47643716>
1276
1277         Reviewed by Geoff Garen.
1278
1279         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1280         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1281         to the previous provisional committing *before* we make the last load. 
1282
1283         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1284
1285 2019-01-29  Youenn Fablet  <youenn@apple.com>
1286
1287         Adopt new SPI to evaluate server certificate trust
1288         https://bugs.webkit.org/show_bug.cgi?id=193355
1289
1290         Reviewed by Alex Christensen.
1291
1292         Add infrastructure to handle HTTPS server trust evaluation testing.
1293
1294         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1295         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1296         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1297         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1298         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1299         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1300         * WebKitTestRunner/TestController.cpp:
1301         (WTR::TestController::resetPreferencesToConsistentValues):
1302         (WTR::TestController::didReceiveAuthenticationChallenge):
1303         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1304         * WebKitTestRunner/TestController.h:
1305         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1306         * WebKitTestRunner/TestInvocation.cpp:
1307         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1308         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1309         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1310
1311 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1312
1313         [ews-build] Add build step to print bot Configuration
1314         https://bugs.webkit.org/show_bug.cgi?id=193887
1315
1316         Reviewed by Lucas Forschler.
1317
1318         * BuildSlaveSupport/ews-build/steps.py:
1319         (PrintConfiguration): Build step to print configuration.
1320         * BuildSlaveSupport/ews-build/factories.py:
1321
1322 2019-01-29  Chris Dumez  <cdumez@apple.com>
1323
1324         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1325         https://bugs.webkit.org/show_bug.cgi?id=193967
1326         <rdar://problem/47635348>
1327
1328         Reviewed by Alex Christensen.
1329
1330         Add API test coverage.
1331
1332         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1333         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1334
1335 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1336
1337         [ews-app] Handle incoming results data
1338         https://bugs.webkit.org/show_bug.cgi?id=193973
1339
1340         Reviewed by Lucas Forschler.
1341
1342         * BuildSlaveSupport/ews-app/ews/views/results.py:
1343
1344 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1345
1346         [ews-app] Make the results url generic
1347         https://bugs.webkit.org/show_bug.cgi?id=193928
1348
1349         Reviewed by Lucas Forschler.
1350
1351         * BuildSlaveSupport/ews-app/ews/urls.py:
1352
1353 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1354
1355         [ews-build] Configure buildbot to send events to ews-app
1356         https://bugs.webkit.org/show_bug.cgi?id=193968
1357
1358         Reviewed by Lucas Forschler.
1359
1360         * BuildSlaveSupport/ews-build/events.py: Added.
1361         * BuildSlaveSupport/ews-build/master.cfg:
1362
1363 2019-01-29  Keith Rollin  <krollin@apple.com>
1364
1365         Add .xcfilelists to Run Script build phases
1366         https://bugs.webkit.org/show_bug.cgi?id=193792
1367         <rdar://problem/47201785>
1368
1369         Reviewed by Alex Christensen.
1370
1371         As part of supporting XCBuild, update the necessary Run Script build
1372         phases in their Xcode projects to refer to their associated
1373         .xcfilelist files.
1374
1375         Note that the addition of these files bumps the Xcode project version
1376         number to something that's Xcode 10 compatible. This change means that
1377         older versions of the Xcode IDE can't read these projects. Nor can it
1378         fully load workspaces that refer to these projects (the updated
1379         projects are shown as non-expandable placeholders). `xcodebuild` can
1380         still build these projects; it's just that the IDE can't open them.
1381
1382         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1383         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1384
1385 2019-01-29  John Wilander  <wilander@apple.com>
1386
1387         Add data abstraction and validation for Ad Click Attribution
1388         https://bugs.webkit.org/show_bug.cgi?id=193916
1389         <rdar://problem/47603481>
1390
1391         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1392
1393         Ad click attribution has two steps. First, the storage of an ad
1394         campaign ID for a click that takes the user to a destination
1395         site. Second, a conversion on the destination site that can be
1396         attributed to the ad click.
1397
1398         This patch adds a class that represents a request for ad click
1399         attribution. Validation makes sure that the bits of entropy
1400         reported through this mechanism is limited.
1401
1402         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1403         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1404         (TestWebKitAPI::TEST):
1405
1406 2019-01-29  Chris Dumez  <cdumez@apple.com>
1407
1408         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1409         https://bugs.webkit.org/show_bug.cgi?id=193932
1410         <rdar://problem/47598947>
1411
1412         Reviewed by Brady Eidson.
1413
1414         Add API test coverage.
1415
1416         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1417
1418 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1419
1420         Adding new passing LFC tests.
1421
1422         Unreviewed test gardening.
1423
1424         * LayoutReloaded/misc/LFC-passing-tests.txt:
1425
1426 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1427
1428         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1429         https://bugs.webkit.org/show_bug.cgi?id=193964
1430
1431         Reviewed by Antti Koivisto.
1432
1433         * LayoutReloaded/misc/LFC-passing-tests.txt:
1434
1435 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1436
1437         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1438         https://bugs.webkit.org/show_bug.cgi?id=193954
1439
1440         Reviewed by Antti Koivisto.
1441
1442         * LayoutReloaded/misc/LFC-passing-tests.txt:
1443
1444 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1445
1446         WebDriver: add support for running subtests
1447         https://bugs.webkit.org/show_bug.cgi?id=193904
1448
1449         Reviewed by Michael Catanzaro.
1450
1451         pytest already supports it by passing test.py::subtest, so we can do the same.
1452
1453         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1454         (get_item_name): Made this global.
1455         (CollectRecorder.__init__): Receive the parameter to ignore.
1456         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1457         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1458         (collect): Add parameter to ignore.
1459         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1460         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1461         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1462         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1463         (WebDriverTestRunnerSelenium.run): Ditto.
1464         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1465         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1466         (WebDriverTestRunnerW3C.run): Ditto.
1467
1468 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1469
1470         User agent string override for navigator.userAgent should be site specific quirks
1471         https://bugs.webkit.org/show_bug.cgi?id=193950
1472
1473         Reviewed by Brent Fulgham.
1474
1475         Updated per the _WKWebsitePolicies rename.
1476
1477         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1478         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1479
1480 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1481
1482         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1483         https://bugs.webkit.org/show_bug.cgi?id=193941
1484
1485         Reviewed by Alex Christensen.
1486
1487         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1488         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1489         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1490         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1491         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1492         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1493         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1494         * TestWebKitAPI/Tests/WTF/Time.cpp:
1495         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1496         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1497         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1498         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1499
1500 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1501
1502         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1503
1504         * Scripts/webkitpy/common/config/contributors.json:
1505
1506 2019-01-28  Andy Estes  <aestes@apple.com>
1507
1508         [watchOS] Enable Parental Controls content filtering
1509         https://bugs.webkit.org/show_bug.cgi?id=193939
1510         <rdar://problem/46641912>
1511
1512         Reviewed by Ryosuke Niwa.
1513
1514         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1515
1516 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1517
1518         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1519         <https://webkit.org/b/193884>
1520
1521         Reviewed by Jiewen Tan.
1522
1523         * Scripts/webkitpy/style/checkers/cpp.py:
1524         (check_language): Add LocalAuthentication to
1525         `frameworks_with_soft_links`.
1526
1527 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1528
1529         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1530         https://bugs.webkit.org/show_bug.cgi?id=193891
1531
1532         Reviewed by Ross Kirsling.
1533
1534         There were three problems in window sizes of WebView and the host window.
1535         1. The sizes of pixel image output were incorrect.
1536         2. The host window is going to appear after window.resize was invoked.
1537         3. window.resize resized only the host window, not WebView.
1538
1539         This change solves them with a following approach.
1540         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1541         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1542            as well as DumpRenderTree in order to match the client area and the window area.
1543         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1544         d. PlatformWebView::setWindowFrame changes both window sizes.
1545         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1546
1547         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1548         (WTR::PlatformWebView::PlatformWebView): Create the host window
1549         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1550         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1551         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1552
1553 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1554
1555         [ews-app] Add method to save Step data to database
1556         https://bugs.webkit.org/show_bug.cgi?id=193890
1557
1558         Reviewed by Lucas Forschler.
1559
1560         * BuildSlaveSupport/ews-app/ews/models/step.py:
1561         (Step.save_step): Method to save step data.
1562         (Step.update_step): Method to update step data.
1563         (Step.get_existing_step): Method to fetch existing step from database.
1564         (Step.is_valid_result): Method to validate valid step result.
1565
1566 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1567
1568         [ews-app] Add method to save Build data to database
1569         https://bugs.webkit.org/show_bug.cgi?id=193735
1570
1571         Reviewed by Lucas Forschler.
1572
1573         * BuildSlaveSupport/ews-app/ews/models/build.py:
1574         (Build.save_build): Method to save build information to database.
1575         (Build.get_existing_build): Method to fetch existing build from database.
1576         (Build.is_valid_result): Method to validate build result.
1577         * BuildSlaveSupport/ews-app/ews/common/util.py:
1578         (is_valid_int_id): Method to validate valid id.
1579
1580 2019-01-28  Chris Dumez  <cdumez@apple.com>
1581
1582         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1583         https://bugs.webkit.org/show_bug.cgi?id=193915
1584         <rdar://problem/47560907>
1585
1586         Reviewed by Alex Christensen.
1587
1588         Add API test coverage.
1589
1590         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1591
1592 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1593
1594         [ews-app] Rename id variables
1595         https://bugs.webkit.org/show_bug.cgi?id=193883
1596
1597         Reviewed by Lucas Forschler.
1598
1599         * BuildSlaveSupport/ews-app/ews/models/build.py:
1600         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1601         * BuildSlaveSupport/ews-app/ews/models/step.py:
1602         * BuildSlaveSupport/ews-app/ews/urls.py:
1603         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1604         * BuildSlaveSupport/ews-app/ews/views/results.py:
1605         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1606
1607 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1608
1609         [ews-app] Allow certain fields to be empty
1610         https://bugs.webkit.org/show_bug.cgi?id=193892
1611
1612         Reviewed by Lucas Forschler.
1613
1614         * BuildSlaveSupport/ews-app/ews/models/build.py:
1615         * BuildSlaveSupport/ews-app/ews/models/step.py:
1616
1617 2019-01-28  Rob Buis  <rbuis@igalia.com>
1618
1619         Update MIME type parser
1620         https://bugs.webkit.org/show_bug.cgi?id=180526
1621
1622         Reviewed by Frédéric Wang.
1623
1624         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1625         (TestWebKitAPI::TEST):
1626
1627 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1628
1629         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1630         https://bugs.webkit.org/show_bug.cgi?id=193896
1631
1632         Reviewed by Antti Koivisto.
1633
1634         * LayoutReloaded/misc/LFC-passing-tests.txt:
1635
1636 2018-12-15  Darin Adler  <darin@apple.com>
1637
1638         Replace many uses of String::format with more type-safe alternatives
1639         https://bugs.webkit.org/show_bug.cgi?id=192742
1640
1641         Reviewed by Mark Lam.
1642
1643         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1644         (WTR::cacheTestRunnerCallback): Use makeString.
1645         * WebKitTestRunner/TestController.cpp:
1646         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1647         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1648
1649 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1650
1651         Use a load optimizer for some sites
1652         https://bugs.webkit.org/show_bug.cgi?id=193881
1653         <rdar://problem/46325455>
1654
1655         Reviewed by Brent Fulgham.
1656
1657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1658         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1659
1660 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1661
1662         AX: Introduce a static accessibility tree
1663         https://bugs.webkit.org/show_bug.cgi?id=193348
1664         <rdar://problem/47203295>
1665
1666         Reviewed by Ryosuke Niwa.
1667
1668         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1669
1670 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1671
1672         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1673         https://bugs.webkit.org/show_bug.cgi?id=193867
1674
1675         Reviewed by Antti Koivisto.
1676
1677         * LayoutReloaded/misc/LFC-passing-tests.txt:
1678
1679 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1680
1681         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1682         https://bugs.webkit.org/show_bug.cgi?id=193865
1683
1684         Reviewed by Antti Koivisto.
1685
1686         * LayoutReloaded/misc/LFC-passing-tests.txt:
1687
1688 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1689
1690         Need a mechanism to override navigator.userAgent
1691         https://bugs.webkit.org/show_bug.cgi?id=193762
1692         <rdar://problem/47504939>
1693
1694         Reviewed by Brent Fulgham.
1695
1696         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1697
1698         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1699         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1700         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1701
1702 2019-01-25  Dean Jackson  <dino@apple.com>
1703
1704         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1705         https://bugs.webkit.org/show_bug.cgi?id=193831
1706         <rdar://problem/47399263>
1707
1708         Reviewed by Chris Dumez.
1709
1710         Two new tests that exercise cross-origin and same-origin System
1711         Previews.
1712
1713         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1714
1715 2019-01-25  Keith Rollin  <krollin@apple.com>
1716
1717         Update Xcode projects with "Check .xcfilelists" build phase
1718         https://bugs.webkit.org/show_bug.cgi?id=193790
1719         <rdar://problem/47201374>
1720
1721         Reviewed by Alex Christensen.
1722
1723         Support for XCBuild includes specifying inputs and outputs to various
1724         Run Script build phases. These inputs and outputs are specified as
1725         .xcfilelist files. Once created, these .xcfilelist files need to be
1726         kept up-to-date. In order to check that they are up-to-date or not,
1727         add an Xcode build step that invokes an external script that performs
1728         the checking. If the .xcfilelists are found to be out-of-date, update
1729         them, halt the build, and instruct the developer to restart the build
1730         with up-to-date files.
1731
1732         At this time, the checking and regenerating is performed only if the
1733         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1734         who want to use this facility can set this variable and test out the
1735         checking/regenerating. Once it seems like there are no egregious
1736         issues that upset a developer's workflow, we'll unconditionally enable
1737         this facility.
1738
1739         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1740         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1741         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1742         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1743
1744 2019-01-25  Keith Rollin  <krollin@apple.com>
1745
1746         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1747         https://bugs.webkit.org/show_bug.cgi?id=193781
1748         <rdar://problem/47201153>
1749
1750         Reviewed by Alex Christensen.
1751
1752         Part of generating the .xcfilelists used as part of adopting XCBuild
1753         includes running `make DerivedSources.make` from a standalone script.
1754         It’s important for this invocation to have the same environment as
1755         when the actual build invokes `make DerivedSources.make`. If the
1756         environments are different, then the two invocations will provide
1757         different results. In order to get the same environment in the
1758         standalone script, have the script launch xcodebuild targeting the
1759         "Apply Configuration to XCFileLists" build target, which will then
1760         re-invoke our standalone script. The script is now running again, this
1761         time in an environment with all workspace, project, target, xcconfig
1762         and other environment variables established.
1763
1764         The "Apply Configuration to XCFileLists" build target accomplishes
1765         this task via a small embedded shell script that consists only of:
1766
1767             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1768
1769         The process that invokes "Apply Configuration to XCFileLists" first
1770         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1771         evaluated and exports it into the shell environment. When xcodebuild
1772         is invoked, it inherits the value of this variable and can `eval` the
1773         contents of that variable. Our external standalone script can then set
1774         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1775         of command-line parameters needed to restart itself in the appropriate
1776         state.
1777
1778         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1779         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1780
1781 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1782
1783         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1784         https://bugs.webkit.org/show_bug.cgi?id=193802
1785         <rdar://problem/46010580>
1786
1787         Reviewed by Andy Estes.
1788
1789         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1790         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1791         (TEST):
1792
1793 2019-01-25  Daniel Bates  <dabates@apple.com>
1794
1795         [iOS] uiController.keyDown() does not translate Control modified key
1796         https://bugs.webkit.org/show_bug.cgi?id=192898
1797
1798         Reviewed by Wenson Hsieh.
1799
1800         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1801         key translation, as applicable. Among other cases, key translation occurs when performing
1802         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1803         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1804         human pressing down and releasing key(s) using a hardware keyboard.
1805
1806         * WebKitTestRunner/ios/HIDEventGenerator.h:
1807         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1808         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1809
1810         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1811         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1812         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1813         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1814         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1815         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1816         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1817         (-[HIDEventGenerator longPress:completionBlock:]):
1818         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1819         Update code for above renaming.
1820
1821         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1822         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1823
1824         (-[HIDEventGenerator keyDown:]): Added.
1825         (-[HIDEventGenerator keyUp:]): Added.
1826         (-[HIDEventGenerator keyPress:completionBlock:]):
1827         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1828         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1829         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1830         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1831         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1832         (WTR::parseModifier): Deleted.
1833
1834 2019-01-25  Keith Rollin  <krollin@apple.com>
1835
1836         Complete the implementation of generate-xcfilelists
1837         https://bugs.webkit.org/show_bug.cgi?id=193782
1838
1839         Reviewed by Alex Christensen.
1840
1841         A preliminary version of generate-xcfilelists was added in r238008.
1842         This patch updates that script in order to:
1843
1844         - Support checking of .xcfilelists
1845         - Perform better execution of `make DerivedSources.make` by
1846           relaunching generate-xcfilelists under xcodebuild
1847         - Support incremental generation and checking of .xcfilelists
1848         - Support supplementary .xcfilelists files from WebKitAdditions
1849         - Support being wrapped by parallel version of generate-xcfilelists in
1850           Internal that adds support for (re)generating WebKit projects in
1851           that repo.
1852         - Support builds that have been performed in WebKitBuild as well as
1853           ~/Library/Developer/code/DerivedData
1854         - Increase robustness and debugging facilities.
1855
1856         * Scripts/generate-xcfilelists:
1857
1858 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1859
1860         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1861         https://bugs.webkit.org/show_bug.cgi?id=193297
1862         <rdar://problem/47158841>
1863
1864         Unreviewed test case fix.
1865
1866         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1867         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1868
1869         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1870         (TEST):
1871
1872 2019-01-25  Keith Rollin  <krollin@apple.com>
1873
1874         Update existing .xcfilelists
1875         https://bugs.webkit.org/show_bug.cgi?id=193791
1876         <rdar://problem/47201706>
1877
1878         Reviewed by Alex Christensen.
1879
1880         Many .xcfilelist files were added in r238824 in order to support
1881         XCBuild. Update these with recent changes to the set of build files
1882         and with the current generate-xcfilelist script.
1883
1884         * DumpRenderTree/DerivedSources-input.xcfilelist:
1885         * DumpRenderTree/DerivedSources-output.xcfilelist:
1886         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1887         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1888
1889 2019-01-25  Keith Rollin  <krollin@apple.com>
1890
1891         Fix missing dependencies in extract-dependencies-from-makefile
1892         https://bugs.webkit.org/show_bug.cgi?id=193783
1893         <rdar://problem/47201571>
1894
1895         Reviewed by Alex Christensen.
1896
1897         The extract-dependencies-from-makefile script generates .xcfilelists
1898         for XCBuild by invoking a makefile in --debug mode, parsing the
1899         dependency information in the output, and extracting information
1900         regarding targets and dependents. However, the way `make` emits this
1901         dependency information is not rigorous, and so we need to determine
1902         what lines to look for and parse by trial and error. This approach
1903         didn't coriginally atch all the information we needed to collect, so
1904         update the script to look for the additional lines we now know to look
1905         for.
1906
1907         * Scripts/extract-dependencies-from-makefile:
1908         (Parser):
1909         (Parser.addTarget):
1910         (Parser.addPrereq):
1911         (Parser.doParse):
1912
1913 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1914
1915         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1916         https://bugs.webkit.org/show_bug.cgi?id=193297
1917         <rdar://problem/47158841>
1918
1919         Reviewed by Alex Christensen.
1920
1921         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1922             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1923         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1924         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1925         activating the message used to trigger the callback when it is set.
1926
1927 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1928
1929         WKWebView.goBack should reload if there is a safe browsing warning
1930         https://bugs.webkit.org/show_bug.cgi?id=193805
1931         <rdar://problem/46908216>
1932
1933         Reviewed by Geoff Garen.
1934
1935         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1936         (+[Simple3LookupContext sharedLookupContext]):
1937         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1938         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1939         (TEST):
1940
1941 2019-01-25  Chris Dumez  <cdumez@apple.com>
1942
1943         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1944         https://bugs.webkit.org/show_bug.cgi?id=193788
1945         <rdar://problem/47531231>
1946
1947         Reviewed by Alex Christensen.
1948
1949         Add API test coverage.
1950
1951         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1952         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1953
1954 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1955
1956         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1957         https://bugs.webkit.org/show_bug.cgi?id=193771
1958
1959         Unreviewed infrastructure fix.
1960
1961         * Scripts/webkitpy/port/darwin.py:
1962         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1963
1964 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1965
1966         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1967
1968 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1969
1970         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1971
1972         * Scripts/webkitpy/common/config/contributors.json:
1973
1974 2019-01-25  Chris Dumez  <cdumez@apple.com>
1975
1976         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1977         https://bugs.webkit.org/show_bug.cgi?id=193779
1978         <rdar://problem/46170903>
1979
1980         Reviewed by Antti Koivisto.
1981
1982         Add API test that quickly navigates forward to a previous process without waiting for it to
1983         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1984         the process' previous page when reconnecting the it for the forward navigation.
1985
1986         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1987
1988 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1989
1990         Need a way for JavaScript (or bundle) code to participate in undo
1991         https://bugs.webkit.org/show_bug.cgi?id=190009
1992         <rdar://problem/44807048>
1993
1994         Reviewed by Ryosuke Niwa.
1995
1996         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1997         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1998
1999         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2000         (WTR::UIScriptController::lastUndoLabel const):
2001         (WTR::UIScriptController::firstRedoLabel const):
2002         (WTR::UIScriptController::platformUndoManager const):
2003         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2004         (WTR::UIScriptController::lastUndoLabel const):
2005         (WTR::UIScriptController::firstRedoLabel const):
2006         (WTR::UIScriptController::platformUndoManager const):
2007         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2008         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2009         (WTR::UIScriptController::lastUndoLabel const):
2010         (WTR::UIScriptController::firstRedoLabel const):
2011         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2012         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2013         (WTR::UIScriptController::lastUndoLabel const):
2014         (WTR::UIScriptController::firstRedoLabel const):
2015         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2016         (WTR::UIScriptController::platformUndoManager const):
2017         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2018         (WTR::UIScriptController::platformUndoManager const):
2019
2020 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2021
2022         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2023         https://bugs.webkit.org/show_bug.cgi?id=193824
2024
2025         Reviewed by Antti Koivisto.
2026
2027         * LayoutReloaded/misc/LFC-passing-tests.txt:
2028
2029 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2030
2031         Update macOS JSC bot configurations
2032         https://bugs.webkit.org/show_bug.cgi?id=193739
2033
2034         Reviewed by Alexey Proskuryakov.
2035
2036         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2038         (BubbleQueueServer): Move JSC EWS to Mojave section.
2039         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2040         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2041         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2042
2043 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2044
2045         [Win][WebKitTestRunner] Implement EventSenderProxy
2046         https://bugs.webkit.org/show_bug.cgi?id=193755
2047
2048         Reviewed by Don Olmstead.
2049
2050         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2051         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2052         (WTR::EventSenderProxy::dispatchMessage):
2053         (WTR::EventSenderProxy::EventSenderProxy):
2054         (WTR::EventSenderProxy::mouseDown):
2055         (WTR::EventSenderProxy::mouseUp):
2056         (WTR::EventSenderProxy::mouseMoveTo):
2057         (WTR::EventSenderProxy::mouseScrollBy):
2058         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2059
2060 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2061
2062         Unreviewed fix for API test failure after r240437.
2063
2064         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2065
2066         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2067
2068 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2069
2070         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2071         https://bugs.webkit.org/show_bug.cgi?id=193787
2072         <rdar://problem/47497634>
2073
2074         Reviewed by Alexey Proskuryakov.
2075
2076         * Scripts/webkitdirs.pm:
2077         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2078
2079 2019-01-24  Truitt Savell  <tsavell@apple.com>
2080
2081         Unreviewed, rolling out r240446.
2082
2083         Casued 5 API failures
2084
2085         Reverted changeset:
2086
2087         "Activate the WebResourceLoadStatisticsStore in the
2088         NetworkProcess and deactivate it in the UIProcess."
2089         https://bugs.webkit.org/show_bug.cgi?id=193297
2090         https://trac.webkit.org/changeset/240446
2091
2092 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2093
2094         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2095         https://bugs.webkit.org/show_bug.cgi?id=193741
2096         <rdar://problem/47135030>
2097
2098         Reviewed by Antti Koivisto and Simon Fraser.
2099
2100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2101         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2102         (TestWebKitAPI::TEST):
2103
2104 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2105
2106         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2107         https://bugs.webkit.org/show_bug.cgi?id=193297
2108         <rdar://problem/47158841>
2109
2110         Reviewed by Alex Christensen.
2111
2112         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2113         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2114         activating the message used to trigger the callback when it is set.
2115
2116 2019-01-24  John Wilander  <wilander@apple.com>
2117
2118         Add Ad Click Attribution as an internal/experimental feature
2119         https://bugs.webkit.org/show_bug.cgi?id=193685
2120         <rdar://problem/47450399>
2121
2122         Reviewed by Brent Fulgham.
2123
2124         Added test option adClickAttributionEnabled.
2125
2126         * DumpRenderTree/TestOptions.cpp:
2127         (TestOptions::TestOptions):
2128         * DumpRenderTree/TestOptions.h:
2129         * DumpRenderTree/mac/DumpRenderTree.mm:
2130         (setWebPreferencesForTestOptions):
2131
2132 2019-01-24  Antti Koivisto  <antti@apple.com>
2133
2134         [PSON] Flash on back navigation on Mac
2135         https://bugs.webkit.org/show_bug.cgi?id=193716
2136         <rdar://problem/47148458>
2137
2138         Reviewed by Chris Dumez.
2139
2140         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2141
2142         Closing of the previous page is delayed so waiting for didFinishNavigation is
2143         not sufficient to guarantee we have received all the messages. Wait for them.
2144
2145 2019-01-24  Chris Dumez  <cdumez@apple.com>
2146
2147         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2148         https://bugs.webkit.org/show_bug.cgi?id=193761
2149         <rdar://problem/47456405>
2150
2151         Reviewed by Alex Christensen.
2152
2153         Add API test coverage.
2154
2155         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2156
2157 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2158
2159         webkitpy: Missing PID in crashlog name should not be fatal
2160         https://bugs.webkit.org/show_bug.cgi?id=193771
2161
2162         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2163         of raising an exception.
2164
2165         Reviewed by Lucas Forschler.
2166
2167         * Scripts/webkitpy/port/darwin.py:
2168         (DarwinPort._merge_crash_logs):
2169
2170 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2171
2172         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2173         https://bugs.webkit.org/show_bug.cgi?id=193746
2174
2175         Reviewed by Youenn Fablet.
2176
2177         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2178         so we'd best just not call it.
2179
2180         * Scripts/webkitpy/w3c/test_exporter.py:
2181         (WebPlatformTestExporter.create_branch_with_patch):
2182
2183 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2184
2185         Move FileSystem to WTF
2186         https://bugs.webkit.org/show_bug.cgi?id=193602
2187
2188         Reviewed by Yusuke Suzuki.
2189
2190         * DumpRenderTree/win/DumpRenderTree.cpp:
2191         * TestWebKitAPI/CMakeLists.txt:
2192         * TestWebKitAPI/PlatformGTK.cmake:
2193         * TestWebKitAPI/PlatformJSCOnly.cmake:
2194         * TestWebKitAPI/PlatformPlayStation.cmake:
2195         * TestWebKitAPI/PlatformWPE.cmake:
2196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2197         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2198         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2199         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2200         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2201         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2202         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2203         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2204         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2205         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2206
2207 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2208
2209         [WPE] Remove hard dependency on subprocess32 for the API tests
2210
2211         Rubber-stamped by Carlos Garcia Campos.
2212
2213         * glib/api_test_runner.py:
2214         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2215         its presence only when running WPEQt tests.
2216
2217 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2218
2219         [GLIB] Expose JavaScriptCore options in GLib public API
2220         https://bugs.webkit.org/show_bug.cgi?id=188742
2221
2222         Reviewed by Michael Catanzaro.
2223
2224         Add a test for the new API.
2225
2226         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2227         (testsJSCOptions):
2228         (main):
2229
2230 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2231
2232         [GTK][WPE] Support JPEG 2000 images
2233         https://bugs.webkit.org/show_bug.cgi?id=186272
2234
2235         Reviewed by Žan Doberšek.
2236
2237         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2238
2239         * gtk/jhbuild.modules:
2240         * wpe/jhbuild.modules:
2241
2242 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2243
2244         check-webkit-style should warn when using soft-linking macros in a header
2245         <https://webkit.org/b/193750>
2246
2247         Reviewed by Darin Adler.
2248
2249         * Scripts/webkitpy/style/checkers/cpp.py:
2250         (check_language): Add softlink/header check by refactoring the
2251         softlink/framework check.
2252         (CppChecker): Enable softlink/header check by default.
2253         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2254         (CppStyleTest.test_softlink_framework): Rename from
2255         CppStyleTest.test_softlink() and change test framework name in
2256         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2257         files. Set file_name for macros that only appear in headers.
2258         (CppStyleTest.test_softlink_header): Add tests for using
2259         soft-link macros in headers.
2260
2261 2019-01-23  Chris Dumez  <cdumez@apple.com>
2262
2263         Deprecate API to limit the maximum number of WebProcesses
2264         https://bugs.webkit.org/show_bug.cgi?id=193725
2265         <rdar://problem/47464879>
2266
2267         Reviewed by Geoff Garen.
2268
2269         Update existing API tests to stop using deprecated API.
2270
2271         * MiniBrowser/mac/AppDelegate.m:
2272         (defaultConfiguration):
2273         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2274         (TestWebKitAPI::TEST):
2275         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2276         (TestWebKitAPI::TEST):
2277         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2278         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2279         (TEST):
2280         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2281         (TEST):
2282
2283 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2284
2285         [ews-app] Rename ews model buildermappings to buildermapping
2286         https://bugs.webkit.org/show_bug.cgi?id=193729
2287
2288         Reviewed by Lucas Forschler.
2289
2290         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2291         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2292         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2293
2294 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2295
2296         [ews-app] Rename ews model steps to step
2297         https://bugs.webkit.org/show_bug.cgi?id=193697
2298
2299         Reviewed by Lucas Forschler.
2300
2301         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2302         (Step): Renamed Steps to Step.
2303
2304 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2305
2306         Clean up IndexedDB files between tests
2307         https://bugs.webkit.org/show_bug.cgi?id=192796
2308         <rdar://problem/46824999>
2309
2310         Reviewed by Geoffrey Garen.
2311
2312         * DumpRenderTree/mac/DumpRenderTree.mm:
2313         (runTest):
2314         * WebKitTestRunner/TestController.cpp:
2315         (WTR::TestController::resetStateToConsistentValues):
2316         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2317         (WTR::RemoveAllIndexedDatabasesCallback):
2318         (WTR::TestController::ClearIndexedDatabases):
2319         * WebKitTestRunner/TestController.h:
2320         * WebKitTestRunner/TestInvocation.cpp:
2321         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2322
2323 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2324
2325         [ews-app] Rename ews model Builds to Build
2326         https://bugs.webkit.org/show_bug.cgi?id=193695
2327
2328         Reviewed by Lucas Forschler.
2329
2330         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2331         (Build): Renamed Builds to Build.
2332
2333 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2334
2335         webkitpy: Wait longer when launching WebKitTestRunner
2336         https://bugs.webkit.org/show_bug.cgi?id=193734
2337
2338         Reviewed by Aakash Jain.
2339
2340         * Scripts/webkitpy/port/simulator_process.py:
2341         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2342
2343 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2344
2345         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2346         https://bugs.webkit.org/show_bug.cgi?id=193182
2347         <rdar://problem/47452154>
2348
2349         Reviewed by Tim Horton.
2350
2351         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2352         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2353         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2354
2355         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2356         preventing later tests from recognizing gestures.
2357
2358         * WebKitTestRunner/ios/TestControllerIOS.mm:
2359         (WTR::TestController::platformResetStateToConsistentValues):
2360
2361         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2362
2363 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2364
2365         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2366         https://bugs.webkit.org/show_bug.cgi?id=193722
2367         <rdar://problem/47481475>
2368
2369         Reviewed by Lucas Forschler.
2370
2371         iPhone and iPad ports should both use the iOS config.
2372
2373         * Scripts/webkitpy/port/ios_simulator.py:
2374         (IPhoneSimulatorPort.__init__):
2375         (IPadSimulatorPort.__init__):
2376
2377 2019-01-23  Rob Buis  <rbuis@igalia.com>
2378
2379         Update MIME type parser
2380         https://bugs.webkit.org/show_bug.cgi?id=180526
2381
2382         Reviewed by Frédéric Wang.
2383
2384         Add unit tests for both parse modes of ParsedContentType.
2385
2386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2387         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2388         (TestWebKitAPI::TEST):
2389
2390 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2391
2392         [ews-app] fetch loop should not stop on network issues
2393         https://bugs.webkit.org/show_bug.cgi?id=193666
2394
2395         Reviewed by Lucas Forschler.
2396
2397         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2398         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2399
2400 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2401
2402         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2403         https://bugs.webkit.org/show_bug.cgi?id=189165
2404         <rdar://problem/47433765>
2405
2406         Reviewed by Tim Horton.
2407
2408         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2409         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2410         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2411         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2412         would make its way to the UI process by the time the layer tree commit is finished.
2413
2414         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2415         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2416         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2417         will fail because it asks for -_autofillContext too early.
2418
2419         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2420         is handled in the UI process.
2421
2422         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2423
2424         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2425         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2426         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2427         input session.
2428
2429         (-[AutofillTestView textInputHasAutofillContext]):
2430
2431         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2432
2433         * TestWebKitAPI/cocoa/TestWKWebView.h:
2434         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2435         (nextInputSessionChangeCount):
2436
2437         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2438         This includes changing the focused element from one to another.
2439
2440         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2441         (-[TestWKWebView didStartFormControlInteraction]):
2442         (-[TestWKWebView didEndFormControlInteraction]):
2443         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2444
2445         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2446         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2447         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2448         that doesn't require an input session to one that doesn't.
2449
2450 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2451
2452         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2453         <https://webkit.org/b/193676>
2454
2455         Reviewed by Alexey Proskuryakov.
2456
2457         * Scripts/webkitpy/style/checkers/cpp.py:
2458         (check_member_initialization_list):
2459         - Don't report missing whitespace around colon if the colon at
2460           the start of the line is formatted correctly.
2461         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2462         (WebKitStyleTest.test_member_initialization_list):
2463         - Add a test for a missing permutation of existing tests.
2464         - Add a test this false-positive.
2465         - Add blank lines between subtests to make them easier to read.
2466
2467 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2468
2469         [build.webkit.org] Unit-test failure after r237113
2470         https://bugs.webkit.org/show_bug.cgi?id=193669
2471
2472         Reviewed by Michael Catanzaro.
2473
2474         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2475         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2476         multiple or zero flags.
2477
2478 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2479
2480         Cache bytecode to disk
2481         https://bugs.webkit.org/show_bug.cgi?id=192782
2482         <rdar://problem/46084932>
2483
2484         Reviewed by Keith Miller.
2485
2486         Add test helper to execute bytecode-cache tests: it executes each test
2487         twice, the first with JSC_diskCachePath set to a temporary directory
2488         and second with JSC_forceDiskCache=true (in addition to the cache path)
2489         to guarantee that only the disk cache is being used and no new
2490         UnlinkedCodeBlocks are being created.
2491
2492         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2493         * Scripts/run-jsc-stress-tests:
2494
2495 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2496
2497         [css-logical] Implement flow-relative margin, padding and border shorthands
2498         https://bugs.webkit.org/show_bug.cgi?id=188697
2499
2500         Reviewed by Simon Fraser and Antti Koivisto.
2501
2502         * DumpRenderTree/TestOptions.cpp:
2503         (TestOptions::TestOptions):
2504         * DumpRenderTree/TestOptions.h:
2505         * DumpRenderTree/mac/DumpRenderTree.mm:
2506         (setWebPreferencesForTestOptions):
2507         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2508
2509         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2510         (JSONCSSPropertiesChecker.check_codegen_properties):
2511         Allow CSS property definitions to have a 'runtime-flag' parameter which
2512         disables the property when the specified runtime flag is disabled.
2513
2514 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2515
2516         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2517         https://bugs.webkit.org/show_bug.cgi?id=193643
2518
2519         Reviewed by Michael Catanzaro.
2520
2521         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2522         * wpe/jhbuild.modules: Ditto.
2523
2524 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2525
2526         [LFC][Floats] Take float top position into account when computing containing block height.
2527         https://bugs.webkit.org/show_bug.cgi?id=193655
2528
2529         Reviewed by Antti Koivisto.
2530
2531         * LayoutReloaded/misc/LFC-passing-tests.txt:
2532
2533 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2534
2535         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2536         <https://webkit.org/b/193645>
2537         <rdar://problem/47421574>
2538
2539         Reviewed by Alex Christensen.
2540
2541         - Now checks for local soft-linking of all frameworks that have
2542           their own *SoftLinking.{cpp,h,mm} files.
2543         - Changes softlink/uikit warning to softlink/framework.
2544
2545         * Scripts/webkitpy/style/checkers/cpp.py:
2546         (check_language):
2547         (CppChecker):
2548         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2549         (CppStyleTest):
2550
2551 2019-01-20  Saam Barati  <sbarati@apple.com>
2552
2553         Rollout r240210: It broke tests on iOS
2554         https://bugs.webkit.org/show_bug.cgi?id=193640
2555
2556         Unreviewed.
2557
2558         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2559         * Scripts/run-jsc-stress-tests:
2560
2561 2019-01-20  chris fleizach  <cfleizach@apple.com>
2562
2563         AX: Support returning relative frames for accessibility
2564         https://bugs.webkit.org/show_bug.cgi?id=193414
2565         <rdar://problem/47268501>
2566
2567         Reviewed by Zalan Bujtas.
2568
2569         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2570         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2571         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2572         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2573         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2574         (WTR::attributesOfElement):
2575         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2576
2577 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2578
2579         Unreviewed, add my new email address
2580
2581         * Scripts/webkitpy/common/config/contributors.json:
2582
2583 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2584
2585         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2586         https://bugs.webkit.org/show_bug.cgi?id=193617
2587
2588         Reviewed by Antti Koivisto.
2589
2590         * LayoutReloaded/misc/LFC-passing-tests.txt:
2591
2592 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2593
2594         Unreviewed, rolling out r240209.
2595
2596         Broke GTK/WPE injected bundle
2597
2598         Reverted changeset:
2599
2600         "AX: Support returning relative frames for accessibility"
2601         https://bugs.webkit.org/show_bug.cgi?id=193414
2602         https://trac.webkit.org/changeset/240209
2603
2604 2019-01-12  Dan Bernstein  <mitz@apple.com>
2605
2606         [Cocoa] Avoid importing directly from subumbrella frameworks
2607         https://bugs.webkit.org/show_bug.cgi?id=186016
2608         <rdar://problem/40591038>
2609
2610         Reviewed by Sam Weinig.
2611
2612         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2613           LaunchServices header.
2614         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2615           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2616         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2617           when using SDKs earlier than 10.13.
2618         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2619           and OTHER_CPLUSPLUSFLAGS.
2620         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2621           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2622         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2623           LaunchServices header.
2624
2625 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2626
2627         Cache bytecode to disk
2628         https://bugs.webkit.org/show_bug.cgi?id=192782
2629         <rdar://problem/46084932>
2630
2631         Reviewed by Keith Miller.
2632
2633         Add test helper to execute bytecode-cache tests: it executes each test
2634         twice, the first with JSC_diskCachePath set to a temporary directory
2635         and second with JSC_forceDiskCache=true (in addition to the cache path)
2636         to guarantee that only the disk cache is being used and no new
2637         UnlinkedCodeBlocks are being created.
2638
2639         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2640         * Scripts/run-jsc-stress-tests:
2641
2642 2019-01-20  chris fleizach  <cfleizach@apple.com>
2643
2644         AX: Support returning relative frames for accessibility
2645         https://bugs.webkit.org/show_bug.cgi?id=193414
2646         <rdar://problem/47268501>
2647
2648         Reviewed by Zalan Bujtas.
2649
2650         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2651         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2652         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2653         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2654         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2655         (WTR::attributesOfElement):
2656         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2657
2658 2019-01-20  Antoine Quint  <graouts@apple.com>
2659
2660         Add a POINTER_EVENTS feature flag
2661         https://bugs.webkit.org/show_bug.cgi?id=193577
2662         <rdar://problem/47408511>
2663
2664         Unreviewed. Also enable Pointer Events for iosmac.
2665
2666         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2667
2668 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2669
2670         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2671         https://bugs.webkit.org/show_bug.cgi?id=193613
2672
2673         Reviewed by Antti Koivisto.
2674
2675         * LayoutReloaded/misc/LFC-passing-tests.txt:
2676
2677 2019-01-19  Antoine Quint  <graouts@apple.com>
2678
2679         Add a POINTER_EVENTS feature flag
2680         https://bugs.webkit.org/show_bug.cgi?id=193577
2681
2682         Reviewed by Dean Jackson.
2683
2684         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2685
2686 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2687
2688         Disable the run-jsc-stress-test remote host key check [second round].
2689         https://bugs.webkit.org/show_bug.cgi?id=192988
2690
2691         Reviewed by Dewei Zhu.
2692
2693         * Scripts/run-jsc-stress-tests:
2694
2695 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2696
2697         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2698         https://bugs.webkit.org/show_bug.cgi?id=193597
2699
2700         Reviewed by Lucas Forschler.
2701
2702         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2703
2704 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2705
2706         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2707         https://bugs.webkit.org/show_bug.cgi?id=193595
2708
2709         Reviewed by Lucas Forschler.
2710
2711         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2712         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2713         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2714
2715 2019-01-18  Chris Dumez  <cdumez@apple.com>
2716
2717         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2718         https://bugs.webkit.org/show_bug.cgi?id=193588
2719         <rdar://problem/47131566>
2720
2721         Reviewed by Alex Christensen.
2722
2723         Add layout test coverage.
2724
2725         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2726
2727 2019-01-18  Jer Noble  <jer.noble@apple.com>
2728
2729         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2730         https://bugs.webkit.org/show_bug.cgi?id=189553
2731
2732         Reviewed by Tim Horton.
2733
2734         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2735
2736         * ContentExtensionTester/Configurations/Base.xcconfig:
2737         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2738         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2739         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2740         * ImageDiff/cg/Configurations/Base.xcconfig:
2741         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2742         * MiniBrowser/Configurations/Base.xcconfig:
2743         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2744         * MobileMiniBrowser/Configurations/Base.xcconfig:
2745         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2746         * Scripts/webkitpy/style/checker.py:
2747         (_all_categories):
2748         (FileType):
2749         (CheckerDispatcher._file_type):
2750         (CheckerDispatcher._create_checker):
2751         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2752         (SDKVariantChecker):
2753         (SDKVariantChecker.__init__):
2754         (SDKVariantChecker.check):
2755         * TestWebKitAPI/Configurations/Base.xcconfig:
2756         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2757         * WebEditingTester/Configurations/Base.xcconfig:
2758         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2759         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2760         * WebKitTestRunner/Configurations/Base.xcconfig:
2761         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2762         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2763         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2764
2765 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2766
2767         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2768         <https://webkit.org/b/193568>
2769         <rdar://problem/47381130>
2770
2771         Reviewed by Alex Christensen.
2772
2773         Make sure no one re-introduces UIKit soft-linking by adding a
2774         style rule.
2775
2776         * Scripts/webkitpy/style/checkers/cpp.py:
2777         (check_language): Add softlink/uikit check.
2778         (CppChecker): Enable softlink/uikit check.
2779         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2780         (CppStyleTest): Add test for softlink/uikit.
2781
2782 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2783
2784         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2785         https://bugs.webkit.org/show_bug.cgi?id=193584
2786
2787         Change "-dev" to "-devel".
2788
2789         Reviewed by Michael Catanzaro.
2790
2791         * gtk/install-dependencies:
2792
2793 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2794
2795         webkitpy: Add iPhone and iPad ports
2796         https://bugs.webkit.org/show_bug.cgi?id=193537
2797         <rdar://problem/47353390>
2798
2799         Reviewed by Lucas Forschler.
2800
2801         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2802         ports. Note that this separation is optional, the --ios-simulator command remains.
2803
2804         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2805         (RunTest.test_device_type_test_division): Drive-by fix.
2806         (RunTest.test_device_type_specific_listing): Ditto.
2807         (RunTest.test_ipad_test_division):
2808         (RunTest):
2809         (RunTest.test_ipad_listing):
2810         * Scripts/webkitpy/port/factory.py:
2811         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2812         (PortFactory):
2813         * Scripts/webkitpy/port/ios_simulator.py:
2814         (IPhoneSimulatorPort):
2815         (IPadSimulatorPort):
2816
2817 2019-01-18  Chris Dumez  <cdumez@apple.com>
2818
2819         Regression(PSON) Scroll position is not always restored properly when navigating back
2820         https://bugs.webkit.org/show_bug.cgi?id=193578
2821         <rdar://problem/47386331>
2822
2823         Reviewed by Tim Horton.
2824
2825         Add API test coverage.
2826
2827         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2828
2829 2019-01-18  Youenn Fablet  <youenn@apple.com>
2830
2831         Add a new SPI to request for cache storage quota increase
2832         https://bugs.webkit.org/show_bug.cgi?id=193323
2833
2834         Reviewed by Alex Christensen.
2835
2836         Implement WebsiteDataStore quota delegate to handle quota requests.
2837         By default, do not update quota.
2838         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2839
2840         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2841         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2842         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2843         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2844         * WebKitTestRunner/TestController.cpp:
2845         (WTR::TestController::allowCacheStorageQuotaIncrease):
2846         * WebKitTestRunner/TestController.h:
2847         * WebKitTestRunner/TestInvocation.cpp:
2848         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2849         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2850         (-[CacheStorageQuotaManager init]):
2851         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2852         (WTR::initializeWebViewConfiguration):
2853         (WTR::TestController::cocoaResetStateToConsistentValues):
2854         (WTR::TestController::allowCacheStorageQuotaIncrease):
2855
2856 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2857
2858         [ews-build] Pass owner to the triggered builds
2859         https://bugs.webkit.org/show_bug.cgi?id=193574
2860
2861         Reviewed by Lucas Forschler.
2862
2863         * BuildSlaveSupport/ews-build/factories.py:
2864         (BuildFactory.propertiesToPassToTriggers):
2865
2866 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2867
2868         [ews-app] Send patch author as a build property
2869         https://bugs.webkit.org/show_bug.cgi?id=193560
2870
2871         Reviewed by Lucas Forschler.
2872
2873         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2874         (BugzillaPatchFetcher.fetch):
2875
2876 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2877
2878         webkitpy: Implement device type specific expected results (Follow-up fix)
2879         https://bugs.webkit.org/show_bug.cgi?id=192162
2880         <rdar://problem/46345449>
2881
2882         Unreviewed infrastructure fix.
2883
2884         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2885         (Manager.run): Don't boot a device if no tests are available to run on it.
2886
2887 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2888
2889         webkitpy: Implement device type specific expected results (Follow-up fix)
2890         https://bugs.webkit.org/show_bug.cgi?id=192162
2891         <rdar://problem/46345449>
2892
2893         Unreviewed infrastructure fix.
2894
2895         * Scripts/webkitpy/api_tests/manager.py:
2896         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2897
2898 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2899
2900         webkitpy: Implement device type specific expected results (Part 2)
2901         https://bugs.webkit.org/show_bug.cgi?id=192162
2902         <rdar://problem/46345449>
2903
2904         Rubber-stamped by Aakash Jain.
2905
2906         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2907         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2908         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2909
2910         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2911         (LayoutTestFinder.find_tests): Pass device_type through.
2912         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2913         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2914         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2915         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2916         (Manager._collect_tests): Pass device type to test finder.
2917         (Manager._needs_web_platform_test):
2918         (Manager._prepare_lists): Index _expectations by device type.
2919         (Manager._test_input_for_file):
2920         (Manager._test_is_slow): Ditto.
2921         (Manager._test_should_dump_jsconsolelog_in_stderr):
2922         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2923         (Manager._get_test_inputs):
2924         (Manager._update_worker_count):
2925         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2926         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2927         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2928         the one which runs the test.
2929         (Manager._run_test_subset):
2930         (Manager._run_tests): Index _expectations by current_device_type.
2931         (Manager._print_expectation_line_for_test): Ditto.
2932         (Manager._print_expectations_for_subset): Ditto.
2933         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2934         Unlike run, this function will behave the same regardless of what devices are available.
2935         (Manager._custom_device_for_test): Deleted.
2936         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2937         (ManagerTest.test_uses_custom_device): Deleted.
2938         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2939         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2940         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2941         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2942         all of the expectations.
2943         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2944         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2945         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2946         (TestExpectations.__init__): Allow device_type to be passed through.
2947         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2948         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2949         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2950         (summarize_results):
2951         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2952         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2953         a test ran with, one must check all expectations to find the first non-skip expectation.
2954         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2955         (RunTest.test_device_type_test_division):
2956         (RunTest):
2957         (RunTest.test_device_type_specific_listing):
2958         * Scripts/webkitpy/port/base.py:
2959         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2960         (Port.supported_device_types): The result of this function will change based on what devices are available.
2961         * Scripts/webkitpy/port/device_port.py:
2962         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2963         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2964         can be used.
2965         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2966         any, or the DEFAULT_DEVICE_TYPES of the port.
2967         * Scripts/webkitpy/port/ios.py:
2968         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2969         * Scripts/webkitpy/port/ios_simulator.py:
2970         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2971         * Scripts/webkitpy/port/watch.py:
2972         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2973         * Scripts/webkitpy/port/watch_simulator.py:
2974         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2975         * Scripts/webkitpy/xcode/device_type.py:
2976         (DeviceType):
2977         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2978
2979 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2980
2981         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2982         https://bugs.webkit.org/show_bug.cgi?id=193575
2983
2984         Reviewed by Michael Catanzaro.
2985
2986         Allow the script to run without explicit port argument because
2987         it's specific to the WPE port anyway.
2988
2989         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2990         and simplify the rest of the code accordingly.
2991
2992 2019-01-18  Charlie Turner  <cturner@igalia.com>
2993
2994         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2995         https://bugs.webkit.org/show_bug.cgi?id=192229
2996
2997         Reviewed by Xabier Rodriguez-Calvar.
2998
2999         * MiniBrowser/wpe/main.cpp:
3000         (main): Enable encrypted-media by default.
3001
3002 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3003
3004         [Flatpak] Missing KeyboardInterrupt exception handler
3005         https://bugs.webkit.org/show_bug.cgi?id=193570
3006
3007         Reviewed by Michael Catanzaro.
3008
3009         * flatpak/flatpakutils.py:
3010         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3011
3012 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3013
3014         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3015         https://bugs.webkit.org/show_bug.cgi?id=193564
3016
3017         Reviewed by Antti Koivisto.
3018
3019         * LayoutReloaded/misc/LFC-passing-tests.txt:
3020
3021 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3022
3023         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3024         https://bugs.webkit.org/show_bug.cgi?id=193562
3025
3026         Reviewed by Antti Koivisto.
3027
3028         * LayoutReloaded/misc/LFC-passing-tests.txt:
3029
3030 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3031
3032         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3033         https://bugs.webkit.org/show_bug.cgi?id=193555
3034
3035         Reviewed by Antti Koivisto.
3036
3037         * LayoutReloaded/misc/LFC-passing-tests.txt:
3038
3039 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3040
3041         [WPE] Add Qt extension
3042         https://bugs.webkit.org/show_bug.cgi?id=191464
3043
3044         Reviewed by Carlos Garcia Campos.
3045
3046         MiniBrowser and API tests for the WPE Qt API. To run the
3047         MiniBrowser a new script is introduced. Example invocation:
3048
3049         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3050
3051         Also note-worthy is the introduction of the python2-subprocess32
3052         dependency to run the GLib API tests.
3053
3054         * MiniBrowser/wpe/CMakeLists.txt:
3055         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3056         * MiniBrowser/wpe/qt/main.cpp: Added.
3057         (main):
3058         * MiniBrowser/wpe/qt/main.qml: Added.
3059         * MiniBrowser/wpe/qt/qml.qrc: Added.
3060         * Scripts/run-gtk-tests:
3061         (GtkTestRunner.is_google_test):
3062         (GtkTestRunner):
3063         (GtkTestRunner.is_qt_test):
3064         * Scripts/run-qt-wpe-minibrowser: Added.
3065         * Scripts/run-wpe-tests:
3066         (WPETestRunner):
3067         (WPETestRunner.is_google_test):
3068         (WPETestRunner.is_qt_test):
3069         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3070         (TestLoad::main):
3071         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3072         (TestLoadHtml::main):
3073         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3074         (TestLoadRequest::main):
3075         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3076         (TestRunJavaScript::main):
3077         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3078         (waitForSignal):
3079         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3080         (LoadSpy::LoadSpy):
3081         (LoadSpy::~LoadSpy):
3082         (LoadSpy::onLoadingChanged):
3083         (LoadStartedCatcher::LoadStartedCatcher):
3084         (LoadStartedCatcher::~LoadStartedCatcher):
3085         (LoadStartedCatcher::onLoadingChanged):
3086         (waitForLoadSucceeded):
3087         (waitForLoadFailed):
3088         * TestWebKitAPI/glib/CMakeLists.txt:
3089         * flatpak/flatpakutils.py:
3090         (WebkitFlatpak.load_from_args):
3091         (WebkitFlatpak.__init__):
3092         (WebkitFlatpak.clean_args):
3093         (WebkitFlatpak.run_in_sandbox):
3094         * flatpak/org.webkit.CommonModules.yaml:
3095         * flatpak/org.webkit.WPE.yaml:
3096         * flatpak/org.webkit.WPEModules.yaml:
3097         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3098         * flatpak/org.webkit.WebKit.yaml:
3099         * glib/api_test_runner.py:
3100         (TestRunner._run_test_qt):
3101         (TestRunner.is_qt_test):
3102         (TestRunner._run_test):
3103
3104 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3105
3106         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3107         https://bugs.webkit.org/show_bug.cgi?id=193494
3108         <rdar://problem/46859627>
3109
3110         Reviewed by Simon Fraser and Tim Horton.
3111
3112         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3113         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3114
3115         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3116         (WTR::UIScriptController::contentOffsetX const):
3117         (WTR::UIScriptController::contentOffsetY const):
3118         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3119         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3120         (WTR::UIScriptController::contentOffsetX const):
3121         (WTR::UIScriptController::contentOffsetY const):
3122         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3123
3124         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3125
3126         * WebKitTestRunner/TestController.cpp:
3127         (WTR::updateTestOptionsFromTestHeader):
3128         * WebKitTestRunner/TestOptions.h:
3129         (WTR::TestOptions::hasSameInitializationOptions const):
3130         * WebKitTestRunner/ios/TestControllerIOS.mm:
3131         (WTR::TestController::platformResetStateToConsistentValues):
3132         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3133         (WTR::UIScriptController::contentOffsetX const):
3134         (WTR::UIScriptController::contentOffsetY const):
3135
3136 2019-01-17  Truitt Savell  <tsavell@apple.com>
3137
3138         Unreviewed, rolling out r240124.
3139
3140         This commit broke an internal build.
3141
3142         Reverted changeset:
3143
3144         "SDK_VARIANT build destinations should be separate from non-
3145         SDK_VARIANT builds"
3146         https://bugs.webkit.org/show_bug.cgi?id=189553
3147         https://trac.webkit.org/changeset/240124
3148
3149 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3150
3151         Fix string concatenation API test after r239920
3152         https://bugs.webkit.org/show_bug.cgi?id=193551
3153         <rdar://problem/47359304>
3154
3155         Reviewed by Youenn Fablet.
3156
3157         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3158         (TestWebKitAPI::TEST):
3159         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3160         in WebKit's build configuration like it apparently is on Linux.
3161
3162 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3163
3164         [ews-build] validate-patch should handle the case when bug_id is None
3165         https://bugs.webkit.org/show_bug.cgi?id=193547
3166
3167         Reviewed by Lucas Forschler.
3168
3169         * BuildSlaveSupport/ews-build/steps.py:
3170         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3171         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3172
3173 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3174
3175         [ews-build] Add patch author information in build
3176         https://bugs.webkit.org/show_bug.cgi?id=193465
3177
3178         Reviewed by Lucas Forschler.
3179
3180         * BuildSlaveSupport/ews-build/steps.py:
3181         (ValidatePatch._is_patch_obsolete):
3182
3183 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3184
3185         [ews-build] Pass bug_id to the triggered builds
3186         https://bugs.webkit.org/show_bug.cgi?id=193548
3187
3188         Reviewed by Lucas Forschler.
3189
3190         * BuildSlaveSupport/ews-build/factories.py:
3191         (BuildFactory.propertiesToPassToTriggers):
3192
3193 2019-01-17  Jer Noble  <jer.noble@apple.com>
3194
3195         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3196         https://bugs.webkit.org/show_bug.cgi?id=189553
3197
3198         Reviewed by Tim Horton.
3199
3200         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3201
3202         * ContentExtensionTester/Configurations/Base.xcconfig:
3203         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3204         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3205         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3206         * ImageDiff/cg/Configurations/Base.xcconfig:
3207         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3208         * MiniBrowser/Configurations/Base.xcconfig:
3209         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3210         * MobileMiniBrowser/Configurations/Base.xcconfig:
3211         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3212         * Scripts/webkitpy/style/checker.py:
3213         (_all_categories):
3214         (FileType):
3215         (CheckerDispatcher._file_type):
3216         (CheckerDispatcher._create_checker):
3217         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3218         (SDKVariantChecker):
3219         (SDKVariantChecker.__init__):
3220         (SDKVariantChecker.check):
3221         * TestWebKitAPI/Configurations/Base.xcconfig:
3222         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3223         * WebEditingTester/Configurations/Base.xcconfig:
3224         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3225         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3226         * WebKitTestRunner/Configurations/Base.xcconfig:
3227         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3228         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3229         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3230
3231 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3232
3233         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3234         https://bugs.webkit.org/show_bug.cgi?id=193534
3235
3236         Reviewed by Antti Koivisto.
3237
3238         * LayoutReloaded/misc/LFC-passing-tests.txt:
3239
3240 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3241
3242         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3243         https://bugs.webkit.org/show_bug.cgi?id=193528
3244
3245         Reviewed by Antti Koivisto.
3246
3247         * LayoutReloaded/misc/LFC-passing-tests.txt:
3248
3249 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3250
3251         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3252         https://bugs.webkit.org/show_bug.cgi?id=193520
3253
3254         Reviewed by Antti Koivisto.
3255
3256         * LayoutReloaded/misc/LFC-passing-tests.txt:
3257
3258 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3259
3260         [ews-build] unapply-patch step should not update source
3261         https://bugs.webkit.org/show_bug.cgi?id=193234
3262
3263         Reviewed by Lucas Forschler.
3264
3265         * BuildSlaveSupport/ews-build/steps.py:
3266         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3267         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3268
3269 2019-01-16  Youenn Fablet  <youenn@apple.com>
3270
3271         Add a new SPI for controlling getUserMedia
3272         https://bugs.webkit.org/show_bug.cgi?id=192793
3273
3274         Reviewed by Eric Carlson.
3275
3276         * MiniBrowser/mac/WK2BrowserWindowController.m:
3277         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3278         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3279         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3280         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3281         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3282         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3283         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3284         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3285         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3286         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3287         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3288         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3289         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3290         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3291
3292 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3293
3294         [LFC][BFC] Inflow non-replaced used width should not be negative.
3295         https://bugs.webkit.org/show_bug.cgi?id=193495
3296
3297         Reviewed by Antti Koivisto.
3298
3299         * LayoutReloaded/misc/LFC-passing-tests.txt:
3300
3301 2019-01-16  Chris Dumez  <cdumez@apple.com>
3302
3303         Regression(PSON) View becomes blank after click a cross-site download link
3304         https://bugs.webkit.org/show_bug.cgi?id=193361
3305         <rdar://problem/47099573>
3306
3307         Reviewed by Geoffrey Garen.
3308
3309         Add API test coverage.
3310
3311         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3312         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3313
3314 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3315
3316         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3317         https://bugs.webkit.org/show_bug.cgi?id=193470
3318
3319         Reviewed by Antti Koivisto.
3320
3321         * LayoutReloaded/misc/LFC-passing-tests.txt:
3322
3323 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3324
3325         [LFC] Adjust margin box verification.
3326         https://bugs.webkit.org/show_bug.cgi?id=193482
3327
3328         Reviewed by Antti Koivisto.
3329
3330         * LayoutReloaded/misc/LFC-passing-tests.txt:
3331
3332 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3333
3334         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3335         https://bugs.webkit.org/show_bug.cgi?id=193451
3336
3337         Reviewed by Geoffrey Garen.
3338
3339         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3340         (TEST):
3341         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3342         (runWebsiteDataStoreCustomPaths):
3343
3344 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3345
3346         webkitpy: Support boolean simctl isAvailable
3347         https://bugs.webkit.org/show_bug.cgi?id=193472
3348         <rdar://problem/47296150>
3349
3350         Reviewed by Ryosuke Niwa.
3351
3352         * Scripts/webkitpy/xcode/simulated_device.py:
3353         (SimulatedDeviceManager._create_runtimes):
3354         (SimulatedDeviceManager._create_device_with_runtime):
3355
3356 2019-01-15  Chris Dumez  <cdumez@apple.com>
3357
3358         Unreviewed, rolling out r239993, r239995, r239997, and
3359         r239999.
3360
3361         Caused assertions under
3362         ViewGestureController::disconnectFromProcess()
3363
3364         Reverted changesets:
3365
3366         "Regression(PSON) View becomes blank after click a cross-site
3367         download link"
3368         https://bugs.webkit.org/show_bug.cgi?id=193361
3369         https://trac.webkit.org/changeset/239993
3370
3371         "Unreviewed iOS build fix after r239993."
3372         https://trac.webkit.org/changeset/239995
3373
3374         "Fix iOS build after r239993"
3375         https://bugs.webkit.org/show_bug.cgi?id=193361
3376         https://trac.webkit.org/changeset/239997
3377
3378         "Unreviewed, revert part of r239997 as it is not needed to fix
3379         the build."
3380         https://trac.webkit.org/changeset/239999
3381
3382 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3383
3384         Cannot tab out of WKWebView on macOS
3385         https://bugs.webkit.org/show_bug.cgi?id=161448
3386         <rdar://problem/28100085>
3387
3388         Reviewed by Dean Jackson.
3389
3390         Add a test that tabbing into and out of WKWebView works correctly.
3391
3392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3393         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3394         (WebKit2_CommandBackForwardTest::SetUp):
3395         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3396         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3397         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3398         (-[FocusableView canBecomeKeyView]):
3399         (TEST):
3400         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3401         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3402         (-[OffscreenWindow initWithSize:]):
3403         (-[OffscreenWindow isKeyWindow]):
3404         (-[OffscreenWindow isVisible]):
3405         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3406         (TestWebKitAPI::PlatformWebView::initialize):
3407         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3408         (-[ActiveOffscreenWindow isVisible]): Deleted.
3409         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3410
3411 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3412
3413         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3414         https://bugs.webkit.org/show_bug.cgi?id=193459
3415
3416         Reviewed by Mark Lam.
3417
3418         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3419         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3420
3421 2019-01-15  Chris Dumez  <cdumez@apple.com>
3422
3423         Regression(PSON) View becomes blank after click a cross-site download link
3424         https://bugs.webkit.org/show_bug.cgi?id=193361
3425         <rdar://problem/47099573>
3426
3427         Reviewed by Geoff Garen.
3428
3429         Add API test coverage.
3430
3431         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3432         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3433
3434 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3435
3436         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3437         https://bugs.webkit.org/show_bug.cgi?id=193448
3438
3439         Reviewed by Antti Koivisto.
3440
3441         * LayoutReloaded/misc/LFC-passing-tests.txt:
3442
3443 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3444
3445         webkitpy: Implement device type specific expected results (Part 1)
3446         https://bugs.webkit.org/show_bug.cgi?id=192162
3447
3448         Reviewed by Lucas Forschler.
3449
3450         Device type specific expected results covers two related ideas. The first (covered by this change)
3451         is where to search for -expected.* files. The second is which tests to run based on the
3452         TestExpectations.txt file.
3453
3454         After this change, the baseline search path will be determined by the type of device running a
3455         test. Device type will be passed into any function which picks a file based on the baseline search
3456         path.
3457
3458         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3459         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3460         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3461         (Manager.run): Print baseline search path for each round of devices.
3462         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3463         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3464         (SingleTestRunner._expected_driver_output): Ditto.
3465         (SingleTestRunner._driver_input): Ditto.
3466         * Scripts/webkitpy/layout_tests/views/printing.py:
3467         (Printer.print_config): Move printing of baseline search path to a separate function.
3468         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3469         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3470         (Testprinter.test_print_config):
3471         (Testprinter.test_print_baseline_search_path):
3472         * Scripts/webkitpy/port/base.py:
3473         (Port.baseline_search_path): Pass device_type through.
3474         (Port._expected_baselines_for_suffixes): Ditto.
3475         (Port.expected_baselines): Ditto.
3476         (Port.expected_filename): Ditto.
3477         (Port.expected_checksum): Ditto.
3478         (Port.expected_image): Ditto.
3479         (Port.expected_audio): Ditto.
3480         (Port.expected_text): Ditto.
3481         (Port.reference_files): Ditto.
3482         (Port.tests): Ditto.
3483         (Port._expanded_paths): Ditto.
3484         (Port.skipped_layout_tests): Ditto.
3485         (Port.expectations_dict): Ditto.
3486         (Port._port_specific_expectations_files): Ditto.
3487         (Port.expectations_files): Ditto.
3488         (Port.test_search_path): Ditto.
3489         (Port._tests_for_other_platforms): Ditto.
3490         * Scripts/webkitpy/port/base_unittest.py:
3491         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3492         (PortTest.test_nonexistant_expectations): Ditto.
3493         (test_ref_tests_platform_directory): Ditto.
3494         * Scripts/webkitpy/port/darwin.py:
3495         (DarwinPort._port_specific_expectations_files): Accept device_type.
3496         * Scripts/webkitpy/port/driver.py:
3497         (DriverProxy):
3498         (DriverProxy.host): Expose _target_host for device_type information.
3499         * Scripts/webkitpy/port/gtk.py:
3500         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3501         * Scripts/webkitpy/port/ios.py:
3502         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3503         * Scripts/webkitpy/port/mac.py:
3504         (MacPort. default_baseline_search_path): Ditto.
3505         * Scripts/webkitpy/port/port_testcase.py:
3506         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3507         * Scripts/webkitpy/port/test.py:
3508         * Scripts/webkitpy/port/watch.py:
3509         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3510         * Scripts/webkitpy/port/win.py:
3511         (WinPort.test_search_path): Accept, but do not use, device_type.
3512         * Scripts/webkitpy/port/wpe.py:
3513         (WPEPort._port_specific_expectations_files): Ditto.
3514         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3515         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3516
3517 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3518
3519         [LFC] Use the containing block's padding box to position out-of-flow elements.
3520         https://bugs.webkit.org/show_bug.cgi?id=193431
3521
3522         Reviewed by Antti Koivisto.
3523
3524         * LayoutReloaded/misc/LFC-passing-tests.txt:
3525
3526 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3527
3528         Move a test implementation file that got misplaced in the Xcode project
3529
3530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3531
3532 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3533
3534         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3535         r239913, and r239914.
3536         https://bugs.webkit.org/show_bug.cgi?id=193407
3537
3538         These revisions caused an internal failure (Requested by
3539         Truitt on #webkit).
3540
3541         Reverted changesets:
3542
3543         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3544         https://bugs.webkit.org/show_bug.cgi?id=186016
3545         https://trac.webkit.org/changeset/239901
3546
3547         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3548         https://trac.webkit.org/changeset/239909
3549
3550         "Tried to fix the build."
3551         https://trac.webkit.org/changeset/239910
3552
3553         "Fixed iOS builds after r239910."
3554         https://trac.webkit.org/changeset/239912
3555
3556         "More build fixing."
3557         https://trac.webkit.org/changeset/239913
3558
3559         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3560         https://trac.webkit.org/changeset/239914
3561
3562 2019-01-14  Mark Lam  <mark.lam@apple.com>
3563
3564         Re-enable ability to build --cloop builds.
3565         https://bugs.webkit.org/show_bug.cgi?id=192955
3566         <rdar://problem/46882363>
3567
3568         Reviewed by Saam barati and Keith Miller.
3569
3570         The --cloop build option was being ignored this whole time since r236381.
3571         This patch makes it possible to build CLoop builds again.
3572
3573         * Scripts/build-jsc:
3574         * Scripts/webkitperl/FeatureList.pm:
3575         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3576
3577 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3578
3579         webkitpy: Expose device_type from host-like objects
3580         https://bugs.webkit.org/show_bug.cgi?id=193406
3581         <rdar://problem/47262305>
3582
3583         Reviewed by Lucas Forschler.
3584
3585         Devices should expose device_type. As a result, all host objects should
3586         provide a device_type property, even if they do not yet define a device_type.
3587
3588         * Scripts/webkitpy/common/system/systemhost.py:
3589         (SystemHost):
3590         (SystemHost.device_type):
3591         * Scripts/webkitpy/common/system/systemhost_mock.py:
3592         (MockSystemHost):
3593         (MockSystemHost.device_type):
3594         * Scripts/webkitpy/port/device.py:
3595         (Device):
3596         (Device.device_type):
3597         * Scripts/webkitpy/xcode/simulated_device.py:
3598         (SimulatedDeviceManager._find_exisiting_device_for_request):
3599         (SimulatedDeviceManager._disambiguate_device_type):
3600         (SimulatedDeviceManager._does_fulfill_request):
3601         (SimulatedDeviceManager.device_count_for_type):
3602         (SimulatedDeviceManager.initialize_devices):
3603         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3604         (test_available_devices):
3605         (test_swapping_devices):
3606
3607 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3608
3609         webkitpy: Support alternate simctl device list output (Follow-up fix)
3610         https://bugs.webkit.org/show_bug.cgi?id=193362
3611         <rdar://problem/47122965>
3612
3613         Rubber-stamped by Lucas Forschler.
3614
3615         * Scripts/webkitpy/xcode/simulated_device.py:
3616         (SimulatedDeviceManager.populate_available_devices):
3617
3618 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3619
3620         [iOS] Expose SPI to access the current sentence boundary and selection state
3621         https://bugs.webkit.org/show_bug.cgi?id=193398
3622         <rdar://problem/45893108>
3623
3624         Reviewed by Dean Jackson.
3625
3626         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3627         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3628         expected.
3629
3630         * TestWebKitAPI/EditingTestHarness.h:
3631         * TestWebKitAPI/EditingTestHarness.mm:
3632         (-[EditingTestHarness moveBackward]):
3633         (-[EditingTestHarness moveForward]):
3634         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3635
3636         Add a couple of new helper methods on EditingTestHarness.
3637
3638         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3639         (-[SelectionChangeObserver initWithWebView:]):
3640         (-[SelectionChangeObserver webView]):
3641         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3642         (-[SelectionChangeObserver currentSelectionAttributes]):
3643
3644 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3645
3646         [LFC][BFC] Add basic box-sizing support.
3647         https://bugs.webkit.org/show_bug.cgi?id=193392
3648
3649         Reviewed by Antti Koivisto.
3650
3651         * LayoutReloaded/misc/LFC-passing-tests.txt:
3652
3653 2019-01-14  Charlie Turner  <cturner@igalia.com>
3654
3655         [WPE] API test gardening
3656         https://bugs.webkit.org/show_bug.cgi?id=193319
3657
3658         Reviewed by Michael Catanzaro.
3659
3660         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3661         passing tests.
3662
3663 2019-01-14  Charlie Turner  <cturner@igalia.com>
3664
3665         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3666         https://bugs.webkit.org/show_bug.cgi?id=192977
3667
3668         Reviewed by Carlos Garcia Campos.
3669
3670         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3671         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3672         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3673         (TestWebKitAPI::GStreamerTest::SetUp):
3674         (TestWebKitAPI::GStreamerTest::TearDown):
3675         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3676         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3677         (TestWebKitAPI::TEST_F):
3678
3679 2019-01-14  Charlie Turner  <cturner@igalia.com>
3680
3681         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3682         https://bugs.webkit.org/show_bug.cgi?id=193332
3683
3684         Reviewed by Michael Catanzaro.
3685
3686         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3687         defined as a char16_t, which changed in ICU 59, the
3688         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3689         unsigned short. This test is relying on the behaviour that
3690         UChar=unsigned short, which doesn't hold across platforms and ICU
3691         library versions. The full fix would be a special syntax for
3692         literal characters so that these ambiguities do not arise. That
3693         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3694         (TestWebKitAPI::TEST):
3695
3696 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3697
3698         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3699
3700         * Scripts/make-dist:
3701         (Distcheck.configure):
3702
3703 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3704
3705         [ews-build] Update macOS queue configurations
3706         https://bugs.webkit.org/show_bug.cgi?id=193365
3707         <rdar://problem/47221073>
3708
3709         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3710
3711         * BuildSlaveSupport/ews-build/config.json:
3712
3713 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3714
3715         [LFC] Adjust assert for statically positioned fixed elements
3716         https://bugs.webkit.org/show_bug.cgi?id=193385
3717
3718         Reviewed by Antti Koivisto.
3719
3720         * LayoutReloaded/misc/LFC-passing-tests.txt:
3721
3722 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3723
3724         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3725         https://bugs.webkit.org/show_bug.cgi?id=193387
3726
3727         Reviewed by Carlos Garcia Campos.
3728
3729         * MiniBrowser/wpe/main.cpp:
3730         (main):
3731
3732 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3733
3734         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3735         https://bugs.webkit.org/show_bug.cgi?id=191655
3736         rdar://problem/46074680
3737
3738         Reviewed by Megan Gardner.
3739
3740         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3741         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3742
3743 2019-01-12  Dan Bernstein  <mitz@apple.com>
3744
3745         [Cocoa] Avoid importing directly from subumbrella frameworks
3746         https://bugs.webkit.org/show_bug.cgi?id=186016
3747         <rdar://problem/40591038>
3748
3749         Reviewed by Sam Weinig.
3750
3751         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3752           LaunchServices header.
3753         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3754           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3755         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3756           when using SDKs earlier than 10.13.
3757         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3758           and OTHER_CPLUSPLUSFLAGS.
3759         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3760           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3761         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3762           LaunchServices header.
3763
3764 2019-01-11  John Wilander  <wilander@apple.com>
3765
3766         Compile out Web API Statistics Collection
3767         https://bugs.webkit.org/show_bug.cgi?id=193370
3768         <rdar://problem/45388584>
3769
3770         Reviewed by Brent Fulgham.
3771
3772         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3773             Defined ENABLE_WEB_API_STATISTICS, off by default.
3774
3775 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3776
3777         [WPE] Add gtk-doc
3778         https://bugs.webkit.org/show_bug.cgi?id=178900
3779
3780         Reviewed by Michael Catanzaro.
3781
3782         Add Tools/gtkdoc to manifest.txt.in files.
3783         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3784
3785         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3786         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3787
3788 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3789
3790         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3791         https://bugs.webkit.org/show_bug.cgi?id=193364
3792         <rdar://problem/47214117>
3793
3794         Reviewed by Tim Horton.
3795
3796         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3797         precise, whereas dragging near the middle of the textarea does.
3798
3799         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3800         (TestWebKitAPI::TEST):
3801
3802 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3803
3804         webkitpy: Support alternate simctl device list output
3805         https://bugs.webkit.org/show_bug.cgi?id=193362
3806         <rdar://problem/47122965>
3807
3808         Reviewed by Lucas Forschler.
3809
3810         * Scripts/webkitpy/xcode/simulated_device.py:
3811         (SimulatedDeviceManager.populate_available_devices):
3812
3813 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3814
3815         [ews-build] Update macOS queue configurations
3816         https://bugs.webkit.org/show_bug.cgi?id=193365
3817
3818         Reviewed by Lucas Forschler.
3819
3820         * BuildSlaveSupport/ews-build/config.json:
3821
3822 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3823
3824         webkitpy: Incorporate device type into baseline search path
3825         https://bugs.webkit.org/show_bug.cgi?id=193356
3826         <rdar://problem/47215515>
3827
3828         Reviewed by Lucas Forschler.
3829
3830         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3831
3832         * Scripts/webkitpy/port/base.py:
3833         (Port.default_baseline_search_path): Allow device type to be passed in.
3834         * Scripts/webkitpy/port/gtk.py:
3835         (GtkPort.default_baseline_search_path): Ignore device type.
3836         * Scripts/webkitpy/port/ios.py:
3837         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3838         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3839         * Scripts/webkitpy/port/ios_device_unittest.py:
3840         (IOSDeviceTest):
3841         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3842         (IOSSimulatorTest):
3843         * Scripts/webkitpy/port/mac.py:
3844         (MacPort.default_baseline_search_path): Ignore device type.
3845         * Scripts/webkitpy/port/watch.py:
3846         (WatchPort.default_baseline_search_path): Ditto.
3847         * Scripts/webkitpy/port/win.py:
3848         (WinPort.default_baseline_search_path): Ditto.
3849         (WinCairoPort.default_baseline_search_path): Ditto.
3850         * Scripts/webkitpy/port/wpe.py:
3851         (WPEPort.default_baseline_search_path): Ditto.
3852
3853 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3854
3855         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3856         https://bugs.webkit.org/show_bug.cgi?id=193352
3857         <rdar://problem/47210736>
3858
3859         Reviewed by Lucas Forschler.
3860
3861         * Scripts/webkitpy/layout_tests/views/printing.py:
3862         (Printer.print_config): Print list on only baseline search paths which exist. 
3863         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3864         (Testprinter.test_print_config):
3865
3866 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3867
3868         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3869         https://bugs.webkit.org/show_bug.cgi?id=193340
3870
3871         Reviewed by David Kilzer.
3872
3873         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3874         (WTR::InjectedBundle::didReceiveMessageToPage):
3875         Pull the strings out into a WKRetainPtr.
3876
3877         * WebKitTestRunner/WebNotificationProvider.cpp:
3878         (WTR::WebNotificationProvider::closeWebNotification):
3879         Adopt the created value into the WKRetainPtr.
3880
3881         * WebKitTestRunner/mac/TestControllerMac.mm:
3882         (WTR::generateWhitelist):
3883         Immediately adopt a created value to avoid potential mistakes.
3884
3885 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3886
3887         Enable DFG on ARM/Linux again
3888         https://bugs.webkit.org/show_bug.cgi?id=192496
3889
3890         Reviewed by Yusuke Suzuki.
3891
3892         After changing the bytecode format DFG was disabled on all 32-bit
3893         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3894         on ARM by default.
3895
3896         * Scripts/run-jsc-stress-tests:
3897
3898 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3899
3900         Unreviewed, fix #ifdef in API test added in r239851.
3901         https://bugs.webkit.org/show_bug.cgi?id=193327
3902         rdar://problem/47093222
3903
3904         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3905
3906 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3907
3908         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3909         https://bugs.webkit.org/show_bug.cgi?id=193109
3910         <rdar://problem/44807048>
3911
3912         Reviewed by Ryosuke Niwa.
3913
3914         Introduce and respect a test option to enable the UndoManager API.
3915
3916         * WebKitTestRunner/TestController.cpp:
3917         (WTR::updateTestOptionsFromTestHeader):
3918         * WebKitTestRunner/TestOptions.h:
3919         (WTR::TestOptions::hasSameInitializationOptions const):
3920         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3921         (WTR::TestController::platformCreateWebView):
3922
3923 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3924
3925         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3926         https://bugs.webkit.org/show_bug.cgi?id=193346
3927
3928         Reviewed by Antti Koivisto.
3929
3930         * LayoutReloaded/misc/LFC-passing-tests.txt:
3931
3932 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3933
3934         Unreviewed, fix typo that breaks dashboard link.
3935
3936         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3937         (WebKitBuildbot):
3938
3939 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3940
3941         Update macOS queue configurations
3942         https://bugs.webkit.org/show_bug.cgi?id=193329
3943
3944         Reviewed by Alexey Proskuryakov.
3945
3946         * BuildSlaveSupport/build.webkit.org-config/config.json:
3947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3948         (BubbleQueueServer):
3949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3951         (WebKitBuildbot):
3952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3953         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3954         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3955
3956 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3957
3958         MiniBrowser should be able to navigate to about:blank
3959         https://bugs.webkit.org/show_bug.cgi?id=193345
3960
3961         Reviewed by Simon Fraser.
3962
3963         * MiniBrowser/mac/BrowserWindowController.m:
3964         (-[BrowserWindowController addProtocolIfNecessary:]):
3965         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3966
3967         * MiniBrowser/mac/WK1BrowserWindowController.m:
3968         (-[WK1BrowserWindowController fetch:]):
3969         * MiniBrowser/mac/WK2BrowserWindowController.m:
3970         (-[WK2BrowserWindowController fetch:]):
3971         Clean up the code that uses this to match style.
3972
3973 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3974
3975         Remove MiniBrowser custom "Process Swap" menu item which does not work
3976         https://bugs.webkit.org/show_bug.cgi?id=193344
3977
3978         Reviewed by Simon Fraser.
3979
3980         There is a menu item under the Experimental menu that does work.
3981
3982         * MiniBrowser/mac/AppDelegate.m:
3983         (defaultConfiguration):
3984         * MiniBrowser/mac/SettingsController.h:
3985         * MiniBrowser/mac/SettingsController.m:
3986         (-[SettingsController _populateMenu]):
3987         (-[SettingsController validateMenuItem:]):
3988         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3989         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3990
3991 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3992
3993         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3994         https://bugs.webkit.org/show_bug.cgi?id=193327
3995         rdar://problem/47093222
3996
3997         Reviewed by Tim Horton.
3998
3999         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4000         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
4001         (TestWebKitAPI::didFinishNavigation):
4002         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4003         (TestWebKitAPI::TEST):
4004         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
4005         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
4006         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
4007         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
4008         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
4009
4010 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4011
4012         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
4013         https://bugs.webkit.org/show_bug.cgi?id=193338
4014         <rdar://problem/46664774>
4015
4016         Reviewed by David Kilzer.
4017
4018         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4019         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
4020
4021 2019-01-10  Commit Queue  <commit-queue@webkit.org>
4022
4023         Unreviewed, rolling out r239825.
4024         https://bugs.webkit.org/show_bug.cgi?id=193330
4025
4026         Broke tests on armv7/linux bots (Requested by guijemont on
4027         #webkit).
4028
4029         Reverted changeset:
4030
4031         "Enable DFG on ARM/Linux again"
4032         https://bugs.webkit.org/show_bug.cgi?id=192496
4033         https://trac.webkit.org/changeset/239825
4034
4035 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
4036
4037         Disable the run-jsc-stress-test remote host key check.
4038         https://bugs.webkit.org/show_bug.cgi?id=192988
4039
4040         Reviewed by Alexey Proskuryakov.
4041
4042         * Scripts/run-jsc-stress-tests:
4043
4044 2019-01-10  John Wilander  <wilander@apple.com>
4045
4046         Override the session configuration for cookieAcceptPolicy
4047         https://bugs.webkit.org/show_bug.cgi?id=190925
4048         <rdar://problem/45497382>
4049
4050         Reviewed by Alexey Proskuryakov and Alex Christensen.
4051
4052         Test infrastructure for setting a first-party-only cookie policy.
4053
4054         * DumpRenderTree/TestRunner.cpp:
4055         (setOnlyAcceptFirstPartyCookiesCallback):
4056         (TestRunner::staticFunctions):
4057         * DumpRenderTree/TestRunner.h:
4058         * DumpRenderTree/mac/TestRunnerMac.mm:
4059         (TestRunner::setOnlyAcceptFirstPartyCookies):
4060         * DumpRenderTree/win/TestRunnerWin.cpp:
4061         (TestRunner::setOnlyAcceptFirstPartyCookies):
4062         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4063         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4064         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
4065         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4066         * WebKitTestRunner/TestInvocation.cpp:
4067         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4068
4069 2019-01-09  Matt Rajca  <mrajca@apple.com>
4070
4071         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
4072         https://bugs.webkit.org/show_bug.cgi?id=193301
4073
4074         Reviewed by Jer Noble.
4075         
4076         Added API tests.
4077
4078         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4079         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4080         (TEST):
4081         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
4082
4083 2019-01-10  Zalan Bujtas  <zalan@apple.com>
4084
4085         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
4086         https://bugs.webkit.org/show_bug.cgi?id=193310
4087
4088         Reviewed by Antti Koivisto.
4089
4090         * LayoutReloaded/misc/LFC-passing-tests.txt:
4091
4092 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
4093
4094         Enable DFG on ARM/Linux again
4095         https://bugs.webkit.org/show_bug.cgi?id=192496
4096
4097         Reviewed by Yusuke Suzuki.
4098
4099         After changing the bytecode format DFG was disabled on all 32-bit
4100         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4101         on ARM by default.
4102
4103         * Scripts/run-jsc-stress-tests:
4104
4105 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
4106
4107         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
4108         https://bugs.webkit.org/show_bug.cgi?id=193271
4109
4110         Reviewed by Brent Fulgham.
4111
4112         BSTR is a special data structure created by SysAllocString, not a
4113         wchar_t null-terminated string.
4114
4115         * DumpRenderTree/win/TestRunnerWin.cpp:
4116         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
4117         * MiniBrowser/win/MiniBrowserWebHost.cpp:
4118         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
4119         BSTR from wide string literals.
4120
4121 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
4122
4123         Tweak wording for build/version_check style checker error
4124         https://bugs.webkit.org/show_bug.cgi?id=193256
4125
4126         Reviewed by Tim Horton.
4127
4128         * Scripts/webkitpy/style/checkers/cpp.py:
4129         (check_os_version_checks):
4130         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4131         (WebKitStyleTest.test_os_version_checks):
4132
4133 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4134
4135         [ews-build] Add link to bug along with bug title
4136         https://bugs.webkit.org/show_bug.cgi?id=193293
4137
4138         Reviewed by Lucas Forschler.
4139
4140         * BuildSlaveSupport/ews-build/steps.py:
4141         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
4142         (ConfigureBuild.add_bug_id_url): Deleted.
4143         (ConfigureBuild.getBugURL): Deleted.
4144
4145 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4146
4147         [ews-build] Use https for ews-build server
4148         https://bugs.webkit.org/show_bug.cgi?id=193193
4149
4150         Reviewed by Lucas Forschler.
4151
4152         * BuildSlaveSupport/ews-build/steps.py:
4153
4154 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4155
4156         [ews-build] Parse and display number of style failures
4157         https://bugs.webkit.org/show_bug.cgi?id=193280
4158
4159         Reviewed by Lucas Forschler.
4160
4161         * BuildSlaveSupport/ews-build/steps.py:
4162         (CheckStyle): Use TestWithFailureCount as base class.
4163         (CheckStyle.countFailures): Count the number of style failures.
4164
4165 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4166
4167         [ews-build] use patch_id instead of ewspatchid
4168         https://bugs.webkit.org/show_bug.cgi?id=193235
4169
4170         Reviewed by Lucas Forschler.
4171
4172         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
4173         * BuildSlaveSupport/ews-build/steps.py: Ditto.
4174         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
4175
4176 2019-01-09  Zalan Bujtas  <zalan@apple.com>
4177
4178         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
4179         https://bugs.webkit.org/show_bug.cgi?id=192625
4180
4181         Reviewed by Antti Koivisto.
4182
4183         * LayoutReloaded/misc/LFC-passing-tests.txt:
4184
4185 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
4186
4187         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
4188         https://bugs.webkit.org/show_bug.cgi?id=192841
4189
4190         Reviewed by Carlos Garcia Campos.
4191
4192         There are separate g_assert_*() macros for use in tests, which we use inconsistently
4193         currently. Use them always. We'll get nicer error messages now when tests fail, and the
4194         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
4195
4196         Note that the documentation of g_assert() says that it is not to be used when writing tests.
4197
4198         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4199         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
4200         (WebKitWebEditorTest::testSelectionChanged):
4201         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
4202         (WebKitFrameTest::testMainFrame):
4203         (WebKitFrameTest::testURI):
4204         (WebKitFrameTest::testJavaScriptContext):
4205         (WebKitFrameTest::testJavaScriptValues):
4206         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
4207         (testWebViewAuthenticationRequest):
4208         (testWebViewAuthenticationLoadCancelled):
4209         (testWebViewAuthenticationFailure):
4210         (testWebViewAuthenticationStorage):
4211         (ProxyAuthenticationTest::ProxyAuthenticationTest):
4212         (testWebViewAuthenticationProxy):
4213         (testWebViewAuthenticationProxyHTTPS):
4214         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4215         (testAutomationSessionRequestSession):
4216         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
4217         (testBackForwardListNavigation):
4218         (testWebKitWebViewSessionState):
4219         (testWebKitWebViewSessionStateWithFormData):
4220         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
4221         (ConsoleMessageTest::consoleMessageReceivedCallback):
4222         (testWebKitConsoleMessageConsoleAPI):
4223         (testWebKitConsoleMessageJavaScriptException):
4224         (testWebKitConsoleMessageNetworkError):
4225         (testWebKitConsoleMessageSecurityError):
4226         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4227         (testCookieManagerAcceptPolicy):
4228         (testCookieManagerCookiesChanged):
4229         (testCookieManagerPersistentStorage):
4230         (testCookieManagerPersistentStorageDeleteAll):
4231         (testCookieManagerEphemeral):
4232         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
4233         (testWebKitDOMElementAutoFill):
4234         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
4235         (downloadLocalFileSuccessfully):
4236         (createFileAtDestination):
4237         (testDownloadOverwriteDestinationDisallowed):
4238         (testDownloadLocalFileError):
4239         (testDownloadRemoteFile):
4240         (testDownloadRemoteFileError):
4241         (testWebViewDownloadURI):
4242         (testPolicyResponseDownload):
4243         (testPolicyResponseDownloadCancel):
4244         (testDownloadMIMEType):
4245         (contextMenuCallback):
4246         (testContextMenuDownloadActions):
4247         (testBlobDownload):
4248         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
4249         (testWebKitWebEditorSelectionChanged):
4250         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
4251         (testWebKitFrameMainFrame):
4252         (testWebKitFrameURI):
4253         (testWebKitFrameJavaScriptContext):
4254         (testWebKitFrameJavaScriptValues):
4255         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4256         (LoadStopTrackingTest::loadFailed):
4257         (testWebViewTitle):
4258         (testURIRequestHTTPHeaders):
4259         (testURIRequestHTTPMethod):
4260         (testURIResponseHTTPHeaders):
4261         (testRedirectToDataURI):
4262         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
4263         (testProcessPerWebView):
4264         (testWebProcessLimit):
4265         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4266         (testWebViewResources):
4267         (testWebResourceLoading):
4268         (testWebResourceSuggestedFilename):
4269         (testWebResourceGetData):
4270         (testWebResourceGetDataError):
4271         (testWebViewResourcesHistoryCache):
4272         (testWebResourceSendRequest):
4273         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
4274         (testSSL):
4275         (testInsecureContent):
4276         (testTLSErrorsPolicy):
4277         (testTLSErrorsRedirect):
4278         (testTLSErrorsHTTPAuth):
4279         (testLoadFailedWithTLSErrors):
4280         (testSubresourceLoadFailedWithTLSErrors):
4281         (httpsServerCallback):
4282         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
4283         (testWebViewCreateNavigationData):
4284         (testWebViewJavaScriptDialogs):
4285         (testWebViewWindowProperties):
4286         (testWebViewMouseTarget):
4287         (testWebViewFileChooserRequest):
4288         (testWebViewColorChooserRequest):
4289         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
4290         (testWebExtensionGetTitle):
4291         (testDocumentLoadedSignal):
4292         (testWebKitWebViewProcessCrashed):
4293         (testWebExtensionWindowObjectCleared):
4294         (testWebExtensionIsolatedWorld):
4295         (permissionRequestCallback):
4296         (didAssociateFormControlsCallback):
4297         (testWebExtensionFormControlsAssociated):
4298         (FormSubmissionTest::FormSubmissionTest):
4299         (FormSubmissionTest::testFormSubmissionResult):
4300         (testWebExtensionFormSubmissionSteps):
4301         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
4302         (testNotInitialized):
4303         (testClearDatabase):
4304         (testPrivateBrowsing):
4305         (testGetFavicon):
4306         (testWebViewFavicon):
4307         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
4308         (testFindControllerTextFound):
4309         (testFindControllerTextNotFound):
4310         (testFindControllerMatchCount):
4311         (testFindControllerMaxMatchCount):
4312         (testFindControllerNext):
4313         (testFindControllerPrevious):
4314         (testFindControllerCountedMatches):
4315         (testFindControllerOptions):
4316         (testFindControllerHide):
4317         (testFindControllerInstance):
4318         (testFindControllerGetters):
4319         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
4320         (testNavigationPolicy):
4321         (testResponsePolicy):
4322         (testNewWindowPolicy):
4323         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
4324         (testSecurityOriginBasicConstructor):
4325         (testSecurityOriginURIConstructor):
4326         (testSecurityOriginDefaultPort):
4327         (testSecurityOriginFileURI):
4328         (testOpaqueSecurityOrigin):
4329         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4330         (testWebKitSettings):
4331         (testWebKitSettingsNewWithSettings):
4332         (testWebKitSettingsUserAgent):
4333         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4334         (testWebViewNewWithUserContentManager):
4335         (isStyleSheetInjectedForURLAtPath):
4336         (isScriptInjectedForURLAtPath):
4337         (testUserContentManagerInjectedStyleSheet):