Fix the build after r212254
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Fix the build after r212254
4
5         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
6         (-[DataInteractionSimulator _currentLocation]):
7
8 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
9
10         [WK2] Add test infrastructure and unit tests for data interaction
11         https://bugs.webkit.org/show_bug.cgi?id=168159
12         <rdar://problem/30477634>
13
14         Reviewed by Tim Horton.
15
16         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
17         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
18         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
19         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
20         gesture has already been recognized) at regular intervals over the course of the test.
21
22         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
24         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
25         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
26
27         New test pages for data interaction.
28
29         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
30         (TestWebKitAPI::runTestsExpectingToObserveEvents):
31         (TestWebKitAPI::TEST):
32         * TestWebKitAPI/cocoa/TestWKWebView.mm:
33         (-[TestWKWebView stringByEvaluatingJavaScript:]):
34         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
35         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
36         (-[MockLongPressGestureRecognizer initWithWindow:]):
37         (-[MockLongPressGestureRecognizer locationInView:]):
38         (-[MockLongPressGestureRecognizer state]):
39         (-[MockLongPressGestureRecognizer numberOfTouches]):
40         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
41         (-[DataInteractionSimulator dealloc]):
42         (-[DataInteractionSimulator run]):
43
44         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
45         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
46         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
47
48         (-[DataInteractionSimulator _advanceProgress]):
49
50         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
51         completed, and calls _finishDataInteraction when progress is at 1.
52
53         (-[DataInteractionSimulator _finishDataInteraction]):
54         (-[DataInteractionSimulator _currentLocation]):
55         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
56         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
57         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
58         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
59         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
60
61 2017-02-13  Alex Christensen  <achristensen@webkit.org>
62
63         Percent should be allowed in non-special URL hosts
64         https://bugs.webkit.org/show_bug.cgi?id=168255
65
66         Reviewed by Tim Horton.
67
68         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
69         (TestWebKitAPI::TEST_F):
70
71 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
72
73         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
74         https://bugs.webkit.org/show_bug.cgi?id=168221
75
76         Reviewed by Ryosuke Niwa.
77
78         There is a logic error in comparing mismatch ref test images. In
79         mismatch ref tests, it should be failed if two images has no diff.
80         But, if the hashes are different, nwtr unexpectedly pass the
81         mismatch ref test.
82
83         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
84         (SingleTestRunner._compare_output_with_reference): Fail the
85         mismatch ref test if hashes of two images are equal. Invoke
86         ImageDiff if the hashes don't match.
87
88 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
89
90         Update custom line breaking iterators to the latest version of Unicode
91         https://bugs.webkit.org/show_bug.cgi?id=168182
92
93         Reviewed by Zalan Bujtas.
94
95         Treat the system's ICU as the source of truth to compare breaking positions against.
96
97         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
98         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
99         (generateJavaScriptForTest):
100         (breakingLocationsFromICU):
101         (testAFewStrings):
102         (TEST):
103         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
104         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
105
106 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
107
108         [GTK] Several failing WebViewEditor API tests
109         https://bugs.webkit.org/show_bug.cgi?id=161608
110
111         Reviewed by Carlos Garcia Campos.
112
113         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
114         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
115         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
116         except the first one, which is still broken due to unrelated bug #151654.
117
118         * Scripts/run-gtk-tests:
119         (TestRunner):
120         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
121
122 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
123
124         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
125
126         * Scripts/run-gtk-tests:
127         (TestRunner):
128
129 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
130
131         Unreviewed, skip flaky form-controls-associated-signal test
132
133         * Scripts/run-gtk-tests:
134         (TestRunner):
135
136 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
137
138         [GTK] Handle caps lock indicator in event modifiers
139         https://bugs.webkit.org/show_bug.cgi?id=168186
140
141         Reviewed by Michael Catanzaro.
142
143         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
144         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
145
146 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
147
148         MiniBrowser WK1 fails to update URL for within-page navigations
149         https://bugs.webkit.org/show_bug.cgi?id=168173
150
151         Reviewed by Tim Horton.
152         
153         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
154         anchors updates the URL field.
155
156         * MiniBrowser/mac/WK1BrowserWindowController.m:
157         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
158
159 2017-02-10  John Wilander  <wilander@apple.com>
160
161         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
162         https://bugs.webkit.org/show_bug.cgi?id=167474
163         <rdar://problem/24681808>
164         <rdar://problem/24703286>
165         <rdar://problem/30290270>
166
167         This patch adds test infrastructure to allow testing 
168         of the various rules in place for data records removal.
169
170         Reviewed by Andy Estes.
171
172         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
173         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
174         (WTR::InjectedBundle::didReceiveMessageToPage):
175             Callback mechanism to tell pages that a website data store
176             scan has happened.
177         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
178         (WTR::TestRunner::setStatisticsPrevalentResource):
179         (WTR::TestRunner::isStatisticsPrevalentResource):
180         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
181         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
182         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
183         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
184         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
185         (WTR::TestRunner::statisticsFireDataModificationHandler):
186         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
187         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
188         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
189         (WTR::TestRunner::statisticsResetToConsistentState):
190         * WebKitTestRunner/InjectedBundle/TestRunner.h:
191         * WebKitTestRunner/TestController.cpp:
192         (WTR::TestController::setStatisticsPrevalentResource):
193         (WTR::TestController::isStatisticsPrevalentResource):
194         (WTR::TestController::setStatisticsHasHadUserInteraction):
195         (WTR::TestController::isStatisticsHasHadUserInteraction):
196         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
197         (WTR::TestController::statisticsFireDataModificationHandler):
198         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
199         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
200         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
201         (WTR::TestController::statisticsResetToConsistentState):
202         * WebKitTestRunner/TestController.h:
203             These are all configuration and test functions.
204         * WebKitTestRunner/TestInvocation.cpp:
205         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
206
207 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
208
209         REGRESSION(r182916) run-perf-tests never timeouts
210         https://bugs.webkit.org/show_bug.cgi?id=167626
211
212         Reviewed by Ryosuke Niwa.
213
214         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
215         was beeing ignored because the driver was created with no_timeout=True
216         unconditionally.
217         This adds a new parameter --no-timeout (disabled by default), that
218         allows to use the driver with the expected timeout values.
219         It also passes --no-timeout to DRT/WTR to ensure that timeouts
220         are always controlled by the Python Driver.
221
222         * Scripts/webkitpy/performance_tests/perftest.py:
223         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
224         (PerfTest.run): Disabling timeout should be done when the Driver is created.
225         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
226         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
227         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
228         (_run_tests_set): Pass the no-timeout parameter.
229         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
230         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
231         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
232         (MainTest.test_parse_args): Test that the argument no-timeout.
233
234 2017-02-10  Daniel Bates  <dabates@apple.com>
235
236         Detach frame from document when entering page cache
237         https://bugs.webkit.org/show_bug.cgi?id=166774
238         <rdar://problem/29904368>
239
240         Reviewed by Chris Dumez.
241
242         * DumpRenderTree/mac/DumpRenderTree.mm:
243         (resetWebPreferencesToConsistentValues):
244         * DumpRenderTree/win/DumpRenderTree.cpp:
245         (resetWebPreferencesToConsistentValues):
246         * WebKitTestRunner/TestController.cpp:
247         (WTR::TestController::resetPreferencesToConsistentValues):
248
249 2017-02-10  Tim Horton  <timothy_horton@apple.com>
250
251         Infinite UI process hang under ensurePositionInformationIsUpToDate
252         https://bugs.webkit.org/show_bug.cgi?id=168154
253         <rdar://problem/30428673>
254
255         Reviewed by Simon Fraser.
256
257         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
258         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
259         (recursiveFindHighlightLongPressRecognizer):
260         (TEST):
261         Add a somewhat nasty test that does an async interaction information update, but
262         kills the Web process before it arrives, and then does a sync interaction
263         information update, which will wait for the oustanding async interaction
264         information update if we still think it's coming. Before the patch, this
265         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
266
267 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
268
269         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
270         https://bugs.webkit.org/show_bug.cgi?id=168127
271         rdar://problem/30467120
272
273         Reviewed by Tim Horton.
274
275         Reparent the web view before we try to fetch it via:
276             [[[window contentView] subviews] objectAtIndex:0];
277         which would throw an exception if the test unparented it.
278
279         * DumpRenderTree/mac/DumpRenderTree.mm:
280         (resetWebViewToConsistentStateBeforeTesting):
281         (runTest):
282
283 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
284
285         [Resource Timing] Enable Resource Timing by default in Tests
286         https://bugs.webkit.org/show_bug.cgi?id=168145
287
288         Reviewed by Ryosuke Niwa.
289
290         * DumpRenderTree/mac/DumpRenderTree.mm:
291         (resetWebPreferencesToConsistentValues):
292         * DumpRenderTree/win/DumpRenderTree.cpp:
293         (resetWebPreferencesToConsistentValues):
294         * WebKitTestRunner/TestController.cpp:
295         (WTR::TestController::resetPreferencesToConsistentValues):
296
297 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
298
299         Removing LayoutTestRelay
300         https://bugs.webkit.org/show_bug.cgi?id=165927
301
302         Reviewed by Daniel Bates.
303         Part 2
304
305         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
306         simulators through simctl (iOS 10 and later), use this functionality instead.
307
308         * BuildSlaveSupport/built-product-archive:
309         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
310         Added a FIXME that we will need to implement similar archiving machinery once we build
311         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
312         * BuildSlaveSupport/kill-old-processes:
313         (main): Remove LayoutTestRelay from list of processes.
314         * LayoutTestRelay: Removed LayoutTestRelay.
315         * Makefile:
316         * Scripts/build-layouttestrelay: Removed.
317         * Scripts/build-webkit: Removed LayoutTestRelay references.
318
319 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
320
321         [WebCrypto] Add WebCryptoAPI to watchlist
322         https://bugs.webkit.org/show_bug.cgi?id=168138
323
324         Reviewed by Youenn Fablet.
325
326         * Scripts/webkitpy/common/config/watchlist:
327
328 2017-02-10  Brady Eidson  <beidson@apple.com>
329
330         Replace all WebKit Library Version checks in WK2 with SDK version checks.
331         https://bugs.webkit.org/show_bug.cgi?id=168124
332
333         Reviewed by Geoffrey Garen.
334
335         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
336         
337         * MiniBrowser/mac/main.m:
338         (main):
339         * MobileMiniBrowser/MobileMiniBrowser/main.m:
340         (main):
341         * TestWebKitAPI/ios/mainIOS.mm:
342         (main):
343         * TestWebKitAPI/mac/mainMac.mm:
344         (main):
345         * WebKitTestRunner/ios/mainIOS.mm:
346         (main):
347         * WebKitTestRunner/mac/main.mm:
348         (setDefaultsToConsistentValuesForTesting):
349
350 2017-02-10  Alex Christensen  <achristensen@webkit.org>
351
352         Fix El Capitan build.
353
354         * Scripts/build-webkit:
355         Don't build libwebrtc anywhere for now.
356
357 2017-02-10  Andy Estes  <aestes@apple.com>
358
359         Move two MiniBrowserBundle settings out of the .pbxproj
360         https://bugs.webkit.org/show_bug.cgi?id=168106
361
362         Reviewed by Tim Horton.
363
364         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
365         the project file. This removes the project file override.
366
367         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
368
369         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
370         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
371
372 2017-02-10  Alex Christensen  <achristensen@webkit.org>
373
374         Fix 32-and-64-bit build on El Capitan.
375
376         * Scripts/build-webkit:
377         Somebody's building with something like this:
378         build-webkit ARCHS="i386 x86_64"
379         We want this to also not build libwebrtc for now.
380
381 2017-02-10  Alex Christensen  <achristensen@webkit.org>
382
383         Fix 32-bit build on El Capitan.
384
385         * Scripts/build-webkit:
386         The bot uses ARCHS=i386 instead of --32-bit.
387         This is a hack, but it should fix the bot until I can do a better fix in the morning.
388
389 2017-02-10  Alex Christensen  <achristensen@webkit.org>
390
391         Fix 32-bit build on El Capitan.
392
393         * Scripts/build-webkit:
394         Don't build i386 libwebrtc.
395
396 2017-02-09  Alex Christensen  <achristensen@webkit.org>
397
398         Unreviewed, rolling out r212040.
399
400         Broke build.  I'm not surprised
401
402         Reverted changeset:
403
404         "[WebRTC][Mac] Activate libwebrtc"
405         https://bugs.webkit.org/show_bug.cgi?id=167293
406         http://trac.webkit.org/changeset/212040
407
408 2017-02-09  Alex Christensen  <achristensen@webkit.org>
409
410         Build libwebrtc on bots without using it yet
411         https://bugs.webkit.org/show_bug.cgi?id=168062
412
413         Reviewed by Brent Fulgham.
414
415         * Scripts/build-webkit:
416
417 2017-02-09  Alex Christensen  <achristensen@webkit.org>
418
419         Don't build libwebrtc.
420
421         * Scripts/build-webkit:
422         Not ready yet.  It broke El Capitan and iOS.
423
424 2017-02-09  Alex Christensen  <achristensen@webkit.org>
425
426         Build libwebrtc on bots without using it yet
427         https://bugs.webkit.org/show_bug.cgi?id=168062
428
429         Reviewed by Brent Fulgham.
430
431         * Scripts/build-webkit:
432
433 2017-02-09  Alex Christensen  <achristensen@webkit.org>
434
435         Rename isAppleMacWebKit to isAppleCocoaWebKit
436         https://bugs.webkit.org/show_bug.cgi?id=168075
437
438         Reviewed by Geoffrey Garen.
439
440         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
441
442         * Scripts/build-api-tests:
443         * Scripts/build-dumprendertree:
444         * Scripts/build-jsc:
445         (buildMyProject):
446         * Scripts/build-layouttestrelay:
447         * Scripts/build-webkit:
448         * Scripts/build-webkittestrunner:
449         * Scripts/run-api-tests:
450         (isSupportedPlatform):
451         (runTest):
452         (listAllTests):
453         (prepareEnvironmentForRunningTestTool):
454         * Scripts/run-content-extension-tester:
455         * Scripts/run-javascriptcore-tests:
456         * Scripts/run-minibrowser:
457         * Scripts/show-pretty-diff:
458         * Scripts/webkitdirs.pm:
459         (determineBaseProductDir):
460         (determineArchitecture):
461         (determinePassedArchitecture):
462         (safariPath):
463         (builtDylibPathForName):
464         (checkFrameworks):
465         (isAppleWebKit):
466         (isAppleCocoaWebKit):
467         (determineNmPath):
468         (launcherName):
469         (wrapperPrefixIfNeeded):
470         (isCMakeBuild):
471         (mobileSafariBundle):
472         (debugSafari):
473         (runSafari):
474         (runMiniBrowser):
475         (debugMiniBrowser):
476         (runWebKitTestRunner):
477         (debugWebKitTestRunner):
478         (isAppleMacWebKit): Deleted.
479         * Scripts/webkitperl/FeatureList.pm:
480
481 2017-02-09  Alex Christensen  <achristensen@webkit.org>
482
483         Revert r211991
484         https://bugs.webkit.org/show_bug.cgi?id=168062
485
486         * Scripts/build-webkit:
487         Not quite ready yet.
488
489 2017-02-09  Alex Christensen  <achristensen@webkit.org>
490
491         Build libwebrtc on bots without using it yet
492         https://bugs.webkit.org/show_bug.cgi?id=168062
493
494         Reviewed by Brent Fulgham.
495
496         * Scripts/build-webkit:
497         Build libwebrtc on Mac when we build ANGLE.
498
499 2017-02-09  Youenn Fablet  <youenn@apple.com>
500
501         Improve W3C importer command line options
502         https://bugs.webkit.org/show_bug.cgi?id=167448
503
504         Reviewed by Ryosuke Niwa.
505
506         Making the list of test paths to import the main arguments of the script.
507         Allow passing the source directory to import as a -s option.
508         Adding a warning when given test paths are skipped by default in ImportExpectations.
509
510         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
511         Link conversion rules do not change when imported tests are downloaded by the script.
512
513         * Scripts/webkitpy/w3c/test_importer.py:
514         (main):
515         (parse_args):
516         (TestImporter.__init__):
517         (TestImporter.do_import):
518         (TestImporter):
519         (TestImporter.check_imported_expectations):
520
521 2017-02-08  Chris Dumez  <cdumez@apple.com>
522
523         Update web-platform-tests resources
524         https://bugs.webkit.org/show_bug.cgi?id=168026
525
526         Reviewed by Youenn Fablet.
527
528         Stop copying testharness.js from resources/ to web-platform-tests/resources.
529
530         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
531         (WebPlatformTestServer._copy_webkit_test_files):
532
533 2017-02-08  Andy Estes  <aestes@apple.com>
534
535         Custom protocols should not continue loading after a network process crash
536         https://bugs.webkit.org/show_bug.cgi?id=168028
537         <rdar://problem/27607520>
538
539         Reviewed by Brady Eidson.
540
541         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
542         (processGroup):
543         (-[CloseWhileStartingProtocol startLoading]):
544         (-[CloseWhileStartingProtocol stopLoading]):
545         (TestWebKitAPI::runTest):
546         (TestWebKitAPI::TEST):
547
548 2017-02-08  Dan Bernstein  <mitz@apple.com>
549
550         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
551         https://bugs.webkit.org/show_bug.cgi?id=168031
552
553         Reviewed by Tim Horton.
554
555         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
556         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
557         (TEST):
558         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
559         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
560
561 2017-02-08  Chris Dumez  <cdumez@apple.com>
562
563         Use smaller tiles in windows that are not active to facilitate App Napping
564         https://bugs.webkit.org/show_bug.cgi?id=167997
565         <rdar://problem/30358835>
566
567         Reviewed by Simon Fraser.
568
569         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
570         (WTR::PlatformWebView::setWindowIsKey):
571         Actually update windowIsKey state of NSWindow so the WebView
572         properly updates its activity state.
573
574 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
575
576         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
577         https://bugs.webkit.org/show_bug.cgi?id=167942
578         <rdar://problem/30315079>
579
580         Reviewed by Tim Horton.
581
582         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
583         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
584         contenteditable in these cases.
585
586         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
587         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
588         performDragOperation:) directly.
589
590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
591         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
592         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
593         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
594         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
595         (-[DragSource draggingSourceOperationMaskForLocal:]):
596         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
597         (-[DragInfo lastMousePosition]):
598         (-[DragInfo setLastMousePosition:]):
599         (-[DragInfo draggingDestinationWindow]):
600         (-[DragInfo draggingSourceOperationMask]):
601         (-[DragInfo draggingLocation]):
602         (-[DragInfo draggedImageLocation]):
603         (-[DragInfo draggedImage]):
604         (-[DragInfo draggingPasteboard]):
605         (-[DragInfo draggingSource]):
606         (-[DragInfo draggingSequenceNumber]):
607         (-[DragInfo slideDraggedImageTo:]):
608         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
609         (-[DragInfo draggingFormation]):
610         (-[DragInfo setDraggingFormation:]):
611         (-[DragInfo animatesToDestination]):
612         (-[DragInfo setAnimatesToDestination:]):
613         (-[DragInfo numberOfValidItemsForDrop]):
614         (-[DragInfo setNumberOfValidItemsForDrop:]):
615         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
616         (-[DragInfo springLoadingHighlight]):
617         (-[DragInfo resetSpringLoading]):
618         (TestWebKitAPI::getTestImage):
619         (TestWebKitAPI::webViewAfterPerformingDragOperation):
620         (TestWebKitAPI::TEST):
621         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
622
623 2017-02-08  Jer Noble  <jer.noble@apple.com>
624
625         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
626         https://bugs.webkit.org/show_bug.cgi?id=168007
627
628         Reviewed by Alex Christensen.
629
630         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
631         (didFinishLoadForFrame):
632         (TestWebKitAPI::TEST):
633
634 2017-02-08  Commit Queue  <commit-queue@webkit.org>
635
636         Unreviewed, rolling out r211873.
637         https://bugs.webkit.org/show_bug.cgi?id=168001
638
639         It's in jhbuild for consistent layout tests (Requested by
640         mcatanzaro on #webkit).
641
642         Reverted changeset:
643
644         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
645         https://bugs.webkit.org/show_bug.cgi?id=167993
646         http://trac.webkit.org/changeset/211873
647
648 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
649
650         [GTK] Add icu packages to Tools/gtk/install-dependencies
651         https://bugs.webkit.org/show_bug.cgi?id=167993
652
653         Reviewed by Michael Catanzaro.
654
655         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
656         depending in the GNU/Linux distribution)
657
658 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
659
660         Update flakiness dashboard configuration.
661         https://bugs.webkit.org/show_bug.cgi?id=167957
662
663         Reviewed by Alexey Proskuryakov.
664
665         * TestResultServer/static-dashboards/builders.jsonp:
666
667 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
668
669         Replace a bot that has an incorrect configuration.
670         https://bugs.webkit.org/show_bug.cgi?id=167747
671
672         Rubber-stamped by Alexey Proskuryakov.
673
674         * BuildSlaveSupport/build.webkit.org-config/config.json:
675
676 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
677
678         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
679         https://bugs.webkit.org/show_bug.cgi?id=167927
680
681         Reviewed by Brent Fulgham.
682
683         Enable ComplexTextController API tests on the Win and GTK ports.
684
685         * TestWebKitAPI/PlatformGTK.cmake:
686         * TestWebKitAPI/PlatformWin.cmake:
687
688 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
689
690         File index appended to previous file in svn-create-patch with SVN 1.9
691         https://bugs.webkit.org/show_bug.cgi?id=167903
692         <rdar://problem/30387395>
693
694         Reviewed by Daniel Bates.
695
696         * Scripts/VCSUtils.pm:
697         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
698         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
699         trailing newline character from the expected result before comparing it to the actual result.
700
701 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
702
703         [webkitdirs] remove unused host_processor variable in determineArchitecture()
704         https://bugs.webkit.org/show_bug.cgi?id=167936
705
706         Reviewed by Michael Catanzaro.
707
708         * Scripts/webkitdirs.pm:
709         (determineArchitecture):
710         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
711         since r195083.
712
713 2017-02-07  Youenn Fablet  <youenn@apple.com>
714
715         Use a JSON file to define which WPT files/folders to import
716         https://bugs.webkit.org/show_bug.cgi?id=167923
717
718         Reviewed by Alex Christensen.
719
720         * Scripts/webkitpy/w3c/test_downloader.py:
721         (TestDownloader.__init__):
722         (TestDownloader._init_paths_from_expectations):
723         * Scripts/webkitpy/w3c/test_importer.py:
724         (parse_args):
725         * Scripts/webkitpy/w3c/test_importer_unittest.py:
726
727 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
728
729         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
730         https://bugs.webkit.org/show_bug.cgi?id=167916
731
732         Reviewed by Carlos Garcia Campos.
733
734         URL of mesa-11.0.6.tar.xz has been moved.
735
736         * gtk/jhbuild.modules: Fix the module path.
737
738 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
739
740         Static Analyzer: Address some leaks in MiniBrowser
741         https://bugs.webkit.org/show_bug.cgi?id=167897
742
743         Reviewed by Alexey Proskuryakov.
744
745         * MiniBrowser/mac/BrowserWindowController.m:
746         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
747         * MiniBrowser/mac/ExtensionManagerWindowController.m:
748         (-[ExtensionManagerWindowController add:]):
749         (-[ExtensionManagerWindowController remove:]):
750         * MiniBrowser/mac/SettingsController.m:
751         (-[SettingsController _populateMenu]):
752         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
753         Address obvious leaks caught by the static analyzer.
754
755 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
756
757         Migrate ComplexTextController to use platform-independent types
758         https://bugs.webkit.org/show_bug.cgi?id=167833
759
760         Reviewed by Brent Fulgham.
761
762         Migrate tests away from platform-dependent types.
763
764         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
765         (TestWebKitAPI::TEST_F):
766
767 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
768
769         Correct File Path Handling in SecurityOrigin and FileSystem
770         https://bugs.webkit.org/show_bug.cgi?id=167894
771         <rdar://problem/30380080>
772
773         Reviewed by Alexey Proskuryakov.
774
775         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
776         and perform same-volume checks using filesystem-compatible paths.        
777         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
778         filesystem paths, and perform validation of same-volume checks.
779         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
780         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
781         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
782         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
783
784 2017-02-06  Jer Noble  <jer.noble@apple.com>
785
786         Playback stalls when a SourceBuffer append causes frame eviction
787         https://bugs.webkit.org/show_bug.cgi?id=167834
788
789         Reviewed by Eric Carlson.
790
791         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
792         for the WTF::MediaTime class.
793
794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
795         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
796         (TestWebKitAPI::TEST):
797         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
798         (WTF::operator<<):
799         (TestWebKitAPI::TestSample::create):
800         (TestWebKitAPI::TestSample::TestSample):
801         (TestWebKitAPI::TEST_F):
802
803 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
804
805         Change capitalization in platform name after r211735.
806
807         Unreviewed dashboard fix.
808
809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
810         (WebKitBuildbot):
811
812 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
813
814         Move the Leaks bot to Sierra
815         https://bugs.webkit.org/show_bug.cgi?id=167886
816
817         Reviewed by Daniel Bates.
818
819         * BuildSlaveSupport/build.webkit.org-config/config.json:
820         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
821         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
822         (LeaksViewer._displayURLPrompt):
823         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
824         (WebKitBuildbot):
825
826 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
827
828         Prevent app crash on launch during simctl install workaround
829         https://bugs.webkit.org/show_bug.cgi?id=167685
830
831         Reviewed by Daniel Bates.
832
833         * Scripts/webkitpy/port/simulator_process.py:
834         (SimulatorProcess.__init__): Pass environment to install.
835         * Scripts/webkitpy/xcode/simulator.py:
836         (Device.install_app): Accept environment, pass environment to launch.
837
838 2017-02-06  Alex Christensen  <achristensen@webkit.org>
839
840         Rebase API tests after r211638
841         https://bugs.webkit.org/show_bug.cgi?id=167779
842
843         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
844         (TestWebKitAPI::TEST_F):
845         URLs with non-special schemes and characters like % in the host now fail to parse,
846         more like their special counterparts and according to spec.
847
848 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
849
850         Unreviewed trivial fix after r211697.
851         https://bugs.webkit.org/show_bug.cgi?id=167863
852
853         * Scripts/run-javascriptcore-tests:
854         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
855
856 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
857
858         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
859         https://bugs.webkit.org/show_bug.cgi?id=167850
860
861         Reviewed by Tim Horton.
862
863         * DumpRenderTree/TestRunner.cpp:
864         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
865
866 2017-02-04  Andreas Kling  <akling@apple.com>
867
868         Plug some leaks in TestController and UIScriptContext.
869         <https://webkit.org/b/167839>
870
871         Reviewed by Alexey Proskuryakov.
872
873         Fix a couple of the leaks seen on the leaks bot.
874
875         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
876         (UIScriptContext::runUIScript):
877         * WebKitTestRunner/TestController.cpp:
878         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
879         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
880
881 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
882
883         WK1 mouse events are missing movementX and movementY for pointerlock.
884         https://bugs.webkit.org/show_bug.cgi?id=167775
885         rdar://problem/30343810
886
887         Reviewed by Alexey Proskuryakov.
888
889         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
890
891         * DumpRenderTree/mac/EventSendingController.mm:
892         (-[EventSendingController mouseMoveToX:Y:]):
893         * WebKitTestRunner/mac/EventSenderProxy.mm:
894         (WTR::EventSenderProxy::mouseMoveTo):
895
896 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
897
898         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
899         https://bugs.webkit.org/show_bug.cgi?id=167774
900
901         Reviewed by Tim Horton.
902
903         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
904         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
905         web process are async, so the callback fires after the web process gets the new state.
906
907         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
908         (WTR::UIScriptController::removeViewFromWindow):
909         (WTR::UIScriptController::addViewToWindow):
910         * DumpRenderTree/mac/DumpRenderTree.mm:
911         (createWebViewAndOffscreenWindow):
912         (resetWebViewToConsistentStateBeforeTesting):
913         * DumpRenderTree/mac/DumpRenderTreeMac.h:
914         * DumpRenderTree/mac/UIScriptControllerMac.mm:
915         (WTR::UIScriptController::removeViewFromWindow):
916         (WTR::UIScriptController::addViewToWindow):
917         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
918         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
919         (WTR::UIScriptController::removeViewFromWindow):
920         (WTR::UIScriptController::addViewToWindow):
921         * TestRunnerShared/UIScriptContext/UIScriptController.h:
922         * WebKitTestRunner/PlatformWebView.h:
923         * WebKitTestRunner/TestController.cpp:
924         (WTR::TestController::resetStateToConsistentValues):
925         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
926         (WTR::PlatformWebView::removeFromWindow):
927         (WTR::PlatformWebView::addToWindow):
928         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
929         (WTR::UIScriptController::removeViewFromWindow):
930         (WTR::UIScriptController::addViewToWindow):
931         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
932         (WTR::PlatformWebView::removeFromWindow):
933         (WTR::PlatformWebView::addToWindow):
934         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
935         (WTR::UIScriptController::removeViewFromWindow):
936         (WTR::UIScriptController::addViewToWindow):
937
938 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
939
940         Remove check for SkipSafariExecutableEntitlementChecks
941         https://bugs.webkit.org/show_bug.cgi?id=167762
942
943         Reviewed by Dan Bernstein.
944
945         Follow-up fix: don't break internal behavior.
946
947         * Scripts/webkitdirs.pm:
948         (safariPath):
949         (executableHasEntitlements): Deleted.
950         (safariPathFromSafariBundle): Deleted.
951         (installedSafariPath): Deleted.
952
953 2017-02-03  Daniel Bates  <dabates@apple.com>
954
955         [Mac][WK2] Add SPI to override the Content Security Policy of a page
956         https://bugs.webkit.org/show_bug.cgi?id=167810
957         <rdar://problem/30102568>
958
959         Reviewed by Anders Carlsson.
960
961         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
962
963         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
964         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
965         (TEST):
966         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
967         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
968         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
969         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
970
971 2017-02-02  Alex Christensen  <achristensen@webkit.org>
972
973         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
974         https://bugs.webkit.org/show_bug.cgi?id=167773
975         <rdar://problem/30221102>
976
977         Reviewed by Ryosuke Niwa.
978
979         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
980         (TestWebKitAPI::TEST_F):
981
982 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
983
984         Remove check for SkipSafariExecutableEntitlementChecks
985         https://bugs.webkit.org/show_bug.cgi?id=167762
986         rdar://problem/22480673
987
988         Reviewed by Dan Bernstein.
989
990         * Scripts/webkitdirs.pm:
991         (safariPathFromSafariBundle):
992         (skipSafariExecutableEntitlementChecks): Deleted.
993
994 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
995
996         Undefined subroutine in svn-create-patch
997         https://bugs.webkit.org/show_bug.cgi?id=167742
998
999         Unreviewed build-fix after r211543.
1000
1001         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1002
1003 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1004
1005         Unreviewed. Fix jhbuild dependencies build.
1006
1007         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1008         Patch updated.
1009
1010 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1011
1012         [EME][GStreamer] Fixed decryptor selection
1013         https://bugs.webkit.org/show_bug.cgi?id=167588
1014
1015         Reviewed by Žan Doberšek.
1016
1017         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1018
1019         * gtk/jhbuild.modules: Added patches to gstreamer and
1020         gst-plugins-good packages.
1021         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1022         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1023
1024 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1025
1026         Make run-benchmark script supports 'config' key in test plan.
1027         https://bugs.webkit.org/show_bug.cgi?id=167715
1028
1029         Reviewed by Ryosuke Niwa.
1030
1031         Add support for 'config' key in test paln.
1032         'config' key is a dictionary that specifies environment configurations while test is running.
1033         Specifies orientation to be portrait in MotionMark benchmark.
1034
1035         * Scripts/webkitpy/benchmark_runner/README.md:
1036         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1037         (BenchmarkRunner.__init__):
1038         (BenchmarkRunner._run_benchmark):
1039         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1040         (BrowserDriver.prepare_env):
1041         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1042         (LinuxBrowserDriver.prepare_env):
1043         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1044         (OSXBrowserDriver.prepare_env):
1045         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1046         (OSXSafariDriver.prepare_env):
1047         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1048
1049 2017-02-01  Daniel Bates  <dabates@apple.com>
1050
1051         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1052         https://bugs.webkit.org/show_bug.cgi?id=167169
1053
1054         Reviewed by David Kilzer.
1055
1056         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1057         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1058         header from the output of "svn diff" on a file that was copied or moved.
1059
1060         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1061         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1062         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1063         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1064         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1065         of a file with only a property change also does not contain any chunk range lines. Therefore
1066         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1067         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1068         we should directly test for the presence of a leading SVN diff header with an empty body and
1069         remove such lines from the diff.
1070
1071         * Scripts/VCSUtils.pm:
1072         (fixSVNPatchForAdditionWithHistory): Added.
1073         * Scripts/svn-create-patch:
1074         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1075         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1076         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1077
1078 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1079
1080         [Mac] Update CARingBuffer class
1081         https://bugs.webkit.org/show_bug.cgi?id=167656
1082
1083         Reviewed by Jer Noble.
1084
1085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1086         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1087         (TestWebKitAPI::CARingBufferTest::SetUp):
1088         (TestWebKitAPI::CARingBufferTest::setup):
1089         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1090         (TestWebKitAPI::CARingBufferTest::description):
1091         (TestWebKitAPI::CARingBufferTest::bufferList):
1092         (TestWebKitAPI::CARingBufferTest::ringBuffer):
1093         (TestWebKitAPI::CARingBufferTest::capacity):
1094         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
1095         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
1096         (TestWebKitAPI::TEST_F):
1097         (TestWebKitAPI::MixingTest::run):
1098
1099 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
1100
1101         [Mac] TestWebKitAPI includes system frameworks incorrectly
1102         https://bugs.webkit.org/show_bug.cgi?id=167703
1103         rdar://problem/30301498
1104
1105         Reviewed by Ryosuke Niwa.
1106
1107         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
1108         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
1109
1110         Also, reduced the number of subframework search paths, looks like we only need one now.
1111
1112         * TestWebKitAPI/Configurations/Base.xcconfig:
1113
1114 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
1115
1116         Correct "filesHaveSameVolume" predicate
1117         https://bugs.webkit.org/show_bug.cgi?id=167696
1118         <rdar://problem/30298722>
1119
1120         Reviewed by David Kilzer.
1121
1122         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
1123         percent-escaped path inputs.
1124
1125         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1126         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
1127         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
1128         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
1129         (TestWebKitAPI::TEST_F):
1130
1131 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1132
1133         Unreviewed. Fix coding style in MiniBrowser
1134
1135         * MiniBrowser/gtk/BrowserWindow.c:
1136         (editingCommandCallback):
1137         (insertImageCommandCallback):
1138         (insertLinkCommandCallback):
1139
1140 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1141
1142         [GTK] Add an API to add a custom tab into the print dialog
1143         https://bugs.webkit.org/show_bug.cgi?id=151998
1144
1145         Reviewed by Carlos Garcia Campos.
1146
1147         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1148         that is testing a newly added API.
1149
1150         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1151         (testPrintCustomWidget):
1152         (beforeAll):
1153
1154 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1155
1156         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1157         https://bugs.webkit.org/show_bug.cgi?id=166529
1158
1159         Reviewed by Xabier Rodriguez-Calvar.
1160
1161         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1162         New patch version accepted in GStreamer upstream.
1163
1164 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1165
1166         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1167         https://bugs.webkit.org/show_bug.cgi?id=167498
1168
1169         Reviewed by Carlos Garcia Campos.
1170
1171         Depending on the distro version you can need either libxfont1-dev
1172         or libfont-dev to build with jhbuild.
1173
1174         * gtk/install-dependencies:
1175
1176 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1177
1178         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1179         https://bugs.webkit.org/show_bug.cgi?id=167594
1180
1181         Unreviewed test gardening.
1182
1183         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1184
1185         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1186         (TEST):
1187
1188 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1189
1190         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1191         https://bugs.webkit.org/show_bug.cgi?id=167676
1192
1193         Reviewed by Saam Barati.
1194
1195         * Scripts/run-javascriptcore-tests:
1196         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1197
1198 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1199
1200         Make Dump Render Tree not crash
1201         https://bugs.webkit.org/show_bug.cgi?id=167667
1202
1203         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1204         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1205         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1206         This does not fix any tests, it just fixes the crash.
1207         
1208         Reviewed by Simon Fraser.
1209
1210         * DumpRenderTree/TestRunner.cpp:
1211         (TestRunner::callUIScriptCallback):
1212
1213 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1214
1215         Workaround for simctl install failing to report install failure
1216         https://bugs.webkit.org/show_bug.cgi?id=167654
1217
1218         Reviewed by Daniel Bates.
1219
1220         simctl install will sometimes report success even though install has failed.
1221         To workaround this bug, we attempt an app launch after install to ensure
1222         install has succeeded.
1223
1224         * Scripts/webkitpy/xcode/simulator.py:
1225         (Device.install_app): Attempt app launch after install, retry install if launch fails.
1226         (Device.launch_app): Correct comment.
1227
1228 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1229
1230         Unreviewed webkitpy fix after r211405.
1231
1232         * Scripts/webkitpy/xcode/simulator.py:
1233         (Device.launch_app): Remove @staticmethod on _log_debug_error.
1234
1235 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1236
1237         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
1238
1239         * gtk/manifest.txt.in:
1240
1241 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
1242
1243         AX: enable search predication for iOS
1244         https://bugs.webkit.org/show_bug.cgi?id=167558
1245         <rdar://problem/30251367>
1246
1247         Reviewed by Joanmarie Diggs.
1248
1249         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1250         (AccessibilityUIElement::uiElementForSearchPredicate):
1251         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1252         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1253         (searchPredicateParameterizedAttributeForSearchCriteria):
1254         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1255         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1256         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1257         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1258         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1259         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1260         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1261         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1262         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1263         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1264         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1265
1266 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1267
1268         Workaround for simctl launch bug
1269         https://bugs.webkit.org/show_bug.cgi?id=167613
1270
1271         Reviewed by Daniel Bates.
1272
1273         simctl launch will sometimes fail because of a race condition when many
1274         simulators are being run simultaneously. These failures will always have
1275         an exit code of 1. This change attempts to launch an app multiple times
1276         before reporting a failure to workaround this bug.
1277
1278         * Scripts/webkitpy/xcode/simulator.py:
1279         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1280
1281 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1282
1283         Commit queue fails to look at real name aliases for the reviewer
1284         https://bugs.webkit.org/show_bug.cgi?id=167422
1285
1286         Reviewed by Joseph Pecoraro.
1287
1288         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1289         (test_has_valid_reviewer): Added tests.
1290
1291         * Scripts/webkitpy/common/config/committers.py:
1292         (CommitterList._name_to_contributor_map):
1293         Made _name_to_contributor_map include alias names.
1294
1295         * Scripts/webkitpy/common/config/committers_unittest.py:
1296         (CommittersTest.test_contributors_by_fuzzy_match):
1297         Removed subtests that are now obsolete, as these matches are strict. It is not
1298         obvious if distance based fuzzy matching for names is useful at all, but we can
1299         look into that some other time.
1300
1301 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1302
1303         QueueStatusServer should have an explicit timeout for _fetch_url
1304         https://bugs.webkit.org/show_bug.cgi?id=167467
1305
1306         Reviewed by Alexey Proskuryakov.
1307
1308         * Scripts/webkitpy/common/net/statusserver.py:
1309         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1310
1311 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1312
1313         Add support for Trac instances that host multiple projects.
1314         https://bugs.webkit.org/show_bug.cgi?id=167524
1315
1316         Reviewed by Alexey Proskuryakov.
1317
1318         When multiple projects are hosted on a single Trac instance, the current
1319         behavior will retrieve changesets from all tracked projects.
1320         This patch teaches Trac.js to get project-specific changesets from Trac.
1321         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1322         when querying the Trac timeline.
1323
1324         To tell Trac to be aware of multi-project instances we leverage the 
1325         `options` parameter when creating a new instance: 
1326
1327             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1328
1329         If this option is not provided, the original behaviour will prevail.
1330         Additionally, add corresponding tests.
1331
1332         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1333         (Trac): Reason about new optional parameter 'projectIdentifier'.
1334         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1335         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1336         replace default parameter `changeset=on` with `repo-projectname=on`.
1337         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1339         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1340         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1341         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1342         Add the following tests:
1343             test("revisionURL")
1344             test("revisionURL with Trac Identifier")
1345             test("_xmlTimelineURL")
1346             test("_xmlTimelineURL with Trac Identifier")
1347         (this.view._latestProductiveIteration): Fix missing ';'.
1348
1349 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1350
1351         Correct spacing regression on inter-element complex path shaping on some fonts
1352         https://bugs.webkit.org/show_bug.cgi?id=166013
1353
1354         Reviewed by Simon Fraser.
1355
1356         Unskip existing tests and make some new tests:
1357         - Testing complex text with no origins
1358         - Testing initial expansions
1359         - Testing the sign of vertical advances
1360
1361         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1362         (TestWebKitAPI::TEST_F):
1363
1364 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1365
1366         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1367         https://bugs.webkit.org/show_bug.cgi?id=167596
1368
1369         Reviewed by Daniel Bates.
1370
1371         We avoid needing a thin directory by invoking the zip program with
1372         the list of directories from the build directory to be zipped,
1373         and by using the zip feature to exclude files matching a pattern.
1374
1375         * BuildSlaveSupport/built-product-archive:
1376         (copyBuildFiles):
1377         (createZipFromList):
1378         (archiveBuiltProduct):
1379
1380 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1381
1382         Use simctl instead of LayoutTestRelay
1383         https://bugs.webkit.org/show_bug.cgi?id=165927
1384
1385         Reviewed by Daniel Bates.
1386
1387         Part 1
1388
1389         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1390         simulators through simctl (iOS 10 and later), use this functionality instead.
1391
1392         * Scripts/webkitpy/port/base.py:
1393         (Port.__init__): Added _test_runner_process_constructor.
1394         * Scripts/webkitpy/port/darwin.py:
1395         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1396         * Scripts/webkitpy/port/driver.py:
1397         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1398         (IOSSimulatorDriver): Deleted.
1399         * Scripts/webkitpy/port/driver_unittest.py:
1400         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1401         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1402         (DriverTest.test_start_actually_starts): Ditto.
1403         * Scripts/webkitpy/port/ios.py:
1404         (IOSSimulatorPort): Remove relay_name.
1405         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1406         (IOSSimulatorPort._create_simulators): Formatting change.
1407         (IOSSimulatorPort.relay_path): Deleted.
1408         (IOSSimulatorPort._check_relay): Deleted.
1409         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1410         (IOSSimulatorPort._build_relay): Deleted.
1411         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1412         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1413         * Scripts/webkitpy/port/ios_unittest.py:
1414         (iosTest.test_32bit): Update test.
1415         (iosTest.test_64bit): Update test.
1416         * Scripts/webkitpy/port/server_process.py:
1417         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1418         (ServerProcess._set_file_nonblocking): Added to share common code.
1419         * Scripts/webkitpy/port/server_process_mock.py:
1420         (MockServerProcess.__init__): Added argument worker_number.
1421         * Scripts/webkitpy/port/simulator_process.py: Added.
1422         (SimulatorProcess): Added.
1423         (SimulatorProcess.Popen): Added.
1424         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1425         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1426         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1427         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1428         (SimulatorProcess._reset): Added. Unlink fifos.
1429         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1430         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1431         * Scripts/webkitpy/xcode/simulator.py:
1432         (Device.__init__): Accept host to run install/launch/terminate.
1433         (Device.install_app): Install app to target Device.
1434         (Device.launch_app): Launch app on target Device.
1435         (Device.terminate_app): Shutdown app on target Device.
1436         (Simulator._parse_devices): Pass host to Device.
1437
1438 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1439
1440         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1441         https://bugs.webkit.org/show_bug.cgi?id=167411
1442
1443         Reviewed by Michael Catanzaro.
1444
1445         Disable the ARM iwMMXt fast path for pixman, because it triggers
1446         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1447
1448         * gtk/jhbuild.modules:
1449
1450 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1451
1452         [GTK] Add API to handle the accelerated compositing policy
1453         https://bugs.webkit.org/show_bug.cgi?id=167509
1454
1455         Reviewed by Michael Catanzaro.
1456
1457         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1458         as a special case. Also add test cases to the get/set API.
1459
1460         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1461         (hardwareAccelerationPolicyToString):
1462         (stringToHardwareAccelerationPolicy):
1463         (cellRendererChanged):
1464         (browserSettingsDialogConstructed):
1465         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1466         (testWebKitSettings):
1467
1468 2017-01-29  Andy Estes  <aestes@apple.com>
1469
1470         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1471         https://bugs.webkit.org/show_bug.cgi?id=167563
1472         <rdar://problem/30253207>
1473
1474         Reviewed by Andreas Kling.
1475
1476         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1477         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1478         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1479         (runTest):
1480         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1481         (TEST):
1482
1483 2017-01-29  Dan Bernstein  <mitz@apple.com>
1484
1485         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1486         https://bugs.webkit.org/show_bug.cgi?id=167565
1487
1488         Reviewed by Sam Weinig.
1489
1490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1491         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1492         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1493         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1494         (TEST):
1495         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1496         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1497         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1498         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1499
1500 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1501
1502         Add Link Preload as an off-by-default experimental feature menu item.
1503         https://bugs.webkit.org/show_bug.cgi?id=167201
1504
1505         Reviewed by Ryosuke Niwa.
1506
1507         * DumpRenderTree/mac/DumpRenderTree.mm:
1508         (resetWebPreferencesToConsistentValues):
1509         * DumpRenderTree/win/DumpRenderTree.cpp:
1510         (resetWebPreferencesToConsistentValues):
1511
1512 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1513
1514         Add User Timing Experimental Feature
1515         https://bugs.webkit.org/show_bug.cgi?id=167542
1516         <rdar://problem/22746307>
1517
1518         Reviewed by Ryosuke Niwa.
1519
1520         * DumpRenderTree/mac/DumpRenderTree.mm:
1521         (enableExperimentalFeatures):
1522         (resetWebPreferencesToConsistentValues):
1523         * DumpRenderTree/win/DumpRenderTree.cpp:
1524         (enableExperimentalFeatures):
1525
1526 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1527
1528         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1529         https://bugs.webkit.org/show_bug.cgi?id=167519
1530
1531         Reviewed by Ryosuke Niwa.
1532
1533         * QueueStatusServer/templates/statusbubble.html:
1534         To measure the bubbleContainer's width, it must not be wrapping based
1535         on its parent container. So when measuring the width temporarily set
1536         the parent to a very large width so as to not artificially wrap us.
1537         Restore the parent's width after measuring.
1538
1539 2017-01-27  Andy Estes  <aestes@apple.com>
1540
1541         [iOS] Add a test for _WKNSFileManagerExtras
1542         https://bugs.webkit.org/show_bug.cgi?id=167478
1543
1544         Reviewed by Andreas Kling.
1545
1546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1547         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1548         (expectAttributes):
1549         (TEST):
1550
1551 2017-01-27  Keith Miller  <keith_miller@apple.com>
1552
1553         run-benchmarks should make sure it passes the test url to the right application
1554         https://bugs.webkit.org/show_bug.cgi?id=167533
1555
1556         Reviewed by Joseph Pecoraro.
1557
1558         This fixes an issue when trying to run-benchmark script with the
1559         system default browser set to STP. Previously, it would run
1560         the test in STP rather than the provided build. Now, it should run
1561         in the provided build.
1562
1563         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1564         (OSXSafariDriver.launch_url):
1565
1566 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1567
1568         [Cocoa] Prepare ComplexTextController for unit testing
1569         https://bugs.webkit.org/show_bug.cgi?id=167493
1570
1571         Reviewed by Simon Fraser.
1572
1573         Addressing post-review comments from Simon Fraser.
1574
1575         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1576         (TestWebKitAPI::TEST_F):
1577
1578 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1579
1580         [Cocoa] Prepare ComplexTextController for unit testing
1581         https://bugs.webkit.org/show_bug.cgi?id=167493
1582
1583         Reviewed by Dean Jackson.
1584
1585         Create four unit tests.
1586
1587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1588         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1589         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1590         (TestWebKitAPI::TEST_F):
1591
1592 2017-01-26  Chris Dumez  <cdumez@apple.com>
1593
1594         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1595         https://bugs.webkit.org/show_bug.cgi?id=167421
1596         <rdar://problem/30188490>
1597
1598         Reviewed by Darin Adler.
1599
1600         Add a new setting allowing layout tests to enable PageCache in a window
1601         that has an opener, for convenience.
1602
1603         * DumpRenderTree/mac/DumpRenderTree.mm:
1604         (resetWebPreferencesToConsistentValues):
1605         * DumpRenderTree/win/DumpRenderTree.cpp:
1606         (resetWebPreferencesToConsistentValues):
1607         * WebKitTestRunner/TestController.cpp:
1608         (WTR::TestController::resetPreferencesToConsistentValues):
1609
1610 2017-01-26  Keith Miller  <keith_miller@apple.com>
1611
1612         classInfo should take a VM so it is not materialized from the object on each call
1613         https://bugs.webkit.org/show_bug.cgi?id=167424
1614
1615         Rubber Stamped by Michael Saboff.
1616
1617         Previously, classInfo() would get the VM from the target's
1618         MarkedBlock.  Most callers already have a VM on hand, so it is
1619         wasteful to compute the VM from the marked block every time. This
1620         patch refactors some of the most common callers of classInfo(),
1621         jsDynamicCast and inherits to take a VM as well.
1622
1623         * DumpRenderTree/TestRunner.cpp:
1624         (setAudioResultCallback):
1625
1626 2017-01-26  Jer Noble  <jer.noble@apple.com>
1627
1628         Autoplay muted videos stop playback of any streaming app in the background
1629         https://bugs.webkit.org/show_bug.cgi?id=163993
1630         <rdar://problem/29020431>
1631
1632         Reviewed by Eric Carlson.
1633
1634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1635         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1636         (TestWebKitAPI::TEST):
1637         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1638
1639 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1640
1641         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1642         https://bugs.webkit.org/show_bug.cgi?id=167466
1643
1644         Unreviewed test gardening.
1645
1646         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1647         (TEST):
1648
1649 2017-01-26  Matt Rajca  <mrajca@apple.com>
1650
1651         Notify clients when the user plays media otherwise prevented from autoplaying
1652         https://bugs.webkit.org/show_bug.cgi?id=167390
1653
1654         Reviewed by Alex Christensen.
1655
1656         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1657         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1658         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1659         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1660         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1661         (TEST):
1662         * TestWebKitAPI/cocoa/TestWKWebView.h:
1663         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1664         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1665         (-[TestWKWebView waitForLoad]):
1666         (-[TestWKWebView mouseUpAtPoint:]):
1667         * WebKitTestRunner/TestController.cpp:
1668         (WTR::TestController::createOtherPage):
1669         (WTR::TestController::createWebViewWithOptions):
1670
1671 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1672
1673         Crash when setting custom scale factor.
1674         https://bugs.webkit.org/show_bug.cgi?id=167369
1675
1676         Reviewed by Sam Weinig.
1677
1678         Added API test.
1679
1680         * TestWebKitAPI/PlatformWin.cmake:
1681         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1682         (TestWebKitAPI::WebKitCreateInstance):
1683         (TestWebKitAPI::ScaleWebView::SetUp):
1684         (TestWebKitAPI::ScaleWebView::TearDown):
1685         (TestWebKitAPI::TEST_F):
1686
1687 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1688
1689         run-benchmark nests MotionMark results by the suite name twice
1690         https://bugs.webkit.org/show_bug.cgi?id=164948
1691
1692         Reviewed by Said Abou-Hallawa.
1693
1694         Use a single level MotionMark now that this is the name of the benchmark,
1695         and we no longer have tests that aren't part of the MotionMark suite.
1696
1697         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1698
1699 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1700
1701         Unreviewed, rolling out r211193.
1702
1703         This change broke internal builds.
1704
1705         Reverted changeset:
1706
1707         "Notify clients when the user plays media otherwise prevented
1708         from autoplaying"
1709         https://bugs.webkit.org/show_bug.cgi?id=167390
1710         http://trac.webkit.org/changeset/211193
1711
1712 2017-01-25  Matt Rajca  <mrajca@apple.com>
1713
1714         Notify clients when the user plays media otherwise prevented from autoplaying
1715         https://bugs.webkit.org/show_bug.cgi?id=167390
1716
1717         Reviewed by Alex Christensen.
1718
1719         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1720         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1721         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1722         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1723         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1724         (TEST):
1725         * TestWebKitAPI/cocoa/TestWKWebView.h:
1726         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1727         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1728         (-[TestWKWebView waitForLoad]):
1729         (-[TestWKWebView mouseUpAtPoint:]):
1730         * WebKitTestRunner/TestController.cpp:
1731         (WTR::TestController::createOtherPage):
1732         (WTR::TestController::createWebViewWithOptions):
1733
1734 2017-01-25  Matt Rajca  <mrajca@apple.com>
1735
1736         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1737         https://bugs.webkit.org/show_bug.cgi?id=167385
1738
1739         Reviewed by Alex Christensen.
1740
1741         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1742         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1743         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1744         (TEST): Allow inline (rather than full screen) media playback on iOS.
1745
1746 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1747
1748         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1749         https://bugs.webkit.org/show_bug.cgi?id=167414
1750
1751         Reviewed by Michael Catanzaro.
1752
1753         Add a test case to check ephemeral web views don't write favicons to the database.
1754
1755         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1756         (ephemeralViewLoadChanged):
1757         (testPrivateBrowsing):
1758         (testFaviconDatabase):
1759
1760 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1761
1762         [GTK] Add a private browsing mode to MiniBrowser
1763         https://bugs.webkit.org/show_bug.cgi?id=167413
1764
1765         Reviewed by Michael Catanzaro.
1766
1767         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1768         private windows, even on non-private instances.
1769
1770         * MiniBrowser/gtk/BrowserWindow.c:
1771         (webViewTitleChanged): Add [Private] to title window for private windows.
1772         (webViewCreate): Pass web context to browser_window_new.
1773         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1774         (browserWindowFinalize): Disconnect web context signal handlers.
1775         (browser_window_init): Add shortcut for opening private window.
1776         (browser_window_new): It now receives the context and connect to download-started here.
1777         (browser_window_get_web_context): Return the context.
1778         * MiniBrowser/gtk/BrowserWindow.h:
1779         * MiniBrowser/gtk/main.c:
1780         (createBrowserTab): Create the web view for the window web context.
1781         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1782         (aboutDataHandleRequest): Ditto.
1783         (aboutURISchemeRequestCallback): Ditto.
1784         (main): Create ephemeral web context if private command line option is used.
1785
1786 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1787
1788         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1789         https://bugs.webkit.org/show_bug.cgi?id=167409
1790
1791         Reviewed by Antti Koivisto.
1792
1793         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1794         as well as tests for the newly added matchingElementInFlatTree.
1795
1796         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1797         (TestWebKitAPI::runJavaScriptAlert):
1798         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1799         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1800         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1801
1802 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1803
1804         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1805         https://bugs.webkit.org/show_bug.cgi?id=167370
1806
1807         Reviewed by Michael Catanzaro.
1808
1809         Add several test cases of ephemeral web views.
1810
1811         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1812         (testWebViewAuthenticationStorage):
1813         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1814         (ephemeralViewloadChanged):
1815         (testCookieManagerEphemeral):
1816         (beforeAll):
1817         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1818         (testWebKitSettings):
1819         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1820         (testWebContextEphemeral):
1821         (ephemeralViewloadChanged):
1822         (testWebContextProxySettings):
1823         (beforeAll):
1824         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1825         (ephemeralViewloadChanged):
1826         (testWebViewEphemeral):
1827         (beforeAll):
1828         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1829         (ephemeralViewloadChanged):
1830         (testWebsiteDataEphemeral):
1831         (beforeAll):
1832
1833 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1834
1835         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1836         https://bugs.webkit.org/show_bug.cgi?id=167402
1837
1838         Reviewed by Ryosuke Niwa.
1839
1840         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1841         (TestWebKitAPI::TEST):
1842
1843 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1844
1845         Add simple line layout toggle to MiniBrowser
1846         https://bugs.webkit.org/show_bug.cgi?id=167405
1847
1848         Reviewed by Andreas Kling.
1849
1850         * MiniBrowser/mac/SettingsController.h:
1851         * MiniBrowser/mac/SettingsController.m:
1852         (-[SettingsController _populateMenu]):
1853         (-[SettingsController validateMenuItem:]):
1854         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1855         (-[SettingsController simpleLineLayoutEnabled]):
1856         * MiniBrowser/mac/WK1BrowserWindowController.m:
1857         (-[WK1BrowserWindowController didChangeSettings]):
1858         * MiniBrowser/mac/WK2BrowserWindowController.m:
1859         (-[WK2BrowserWindowController didChangeSettings]):
1860
1861 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1862
1863         WKR does not include my nick when commit-queue lands my patch
1864         https://bugs.webkit.org/show_bug.cgi?id=167388
1865
1866         Reviewed by Ryosuke Niwa.
1867
1868         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1869         (NewCommitBot._summarize_commit_log):
1870         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1871         Perform nickname insertion before grabbing "Patch by" details.
1872         This way we can include the nickname with the full name.
1873
1874 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1875
1876         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1877         https://bugs.webkit.org/show_bug.cgi?id=167394
1878
1879         Reviewed by Ryosuke Niwa.
1880
1881         * Scripts/webkitperl/FeatureList.pm:
1882         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1883
1884 2017-01-24  Youenn Fablet  <youenn@apple.com>
1885
1886         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1887         https://bugs.webkit.org/show_bug.cgi?id=167353
1888
1889         Reviewed by Alex Christensen.
1890
1891         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1892         (CMakeGenerator.initialize_targets):
1893
1894 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1895
1896         WKR should not confuse Miguel Gomez with Andres Gomez
1897         https://bugs.webkit.org/show_bug.cgi?id=167389
1898
1899         Reviewed by Lucas Forschler.
1900
1901         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1902         "mAndres Gomez". Fix this.
1903
1904         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1905         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1906         space on each side of the email address, so expect both spaces to be there before
1907         considering the email for replacement.
1908         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1909
1910 2017-01-24  Matt Rajca  <mrajca@apple.com>
1911
1912         Pass down website autoplay policies to media elements
1913         https://bugs.webkit.org/show_bug.cgi?id=167355
1914
1915         Reviewed by Alex Christensen.
1916
1917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1918         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1919         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1920         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1921         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1922         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1923         (TEST):
1924
1925 2017-01-24  Nan Wang  <n_wang@apple.com>
1926
1927         AX: Speak Selection does not work in an iframe
1928         https://bugs.webkit.org/show_bug.cgi?id=166794
1929         <rdar://problem/29913013>
1930
1931         Reviewed by Chris Fleizach.
1932
1933         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1934         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1935         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1936         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1937         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1938         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1939         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1940         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1941         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1942         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1943         (-[TestRunnerWKWebView dealloc]):
1944         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1945         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1946         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1947         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1948         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1949
1950 2017-01-24  Daniel Bates  <dabates@apple.com>
1951
1952         StringView.split() should use an iterator design pattern instead of allocating a Vector
1953         https://bugs.webkit.org/show_bug.cgi?id=163225
1954
1955         Reviewed by Darin Adler.
1956
1957         Add unit tests for StringView.split().
1958
1959         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1960         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1961         used in the StringView.split() unit tests.
1962         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1963         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1964         object to a Vector of String objects.
1965         (TestWebKitAPI::TEST): Added the following tests:
1966             - WTF.StringViewSplitEmptyAndNullStrings
1967             - WTF.StringViewSplitBasic
1968             - WTF.StringViewSplitWithConsecutiveSeparators
1969
1970 2017-01-23  Anders Carlsson  <andersca@apple.com>
1971
1972         The Score Esports crashes on launch
1973         https://bugs.webkit.org/show_bug.cgi?id=167338
1974         rdar://problem/29948645
1975
1976         Reviewed by Dan Bernstein.
1977
1978         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1979         (TestWebKitAPI::TEST):
1980         Add a test.
1981
1982 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1983
1984         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1985         https://bugs.webkit.org/show_bug.cgi?id=146589
1986
1987         Reviewed by Michael Catanzaro.
1988
1989         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1990         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1991
1992         * MiniBrowser/gtk/BrowserWindow.c:
1993         (webViewDecidePolicy):
1994         (newTabCallback):
1995         * MiniBrowser/gtk/main.c:
1996         (createBrowserTab):
1997         (aboutDataRequestFree):
1998         (aboutDataRequestNew):
1999         (aboutDataRequestForView):
2000         (websiteDataRemovedCallback):
2001         (websiteDataClearedCallback):
2002         (aboutDataScriptMessageReceivedCallback):
2003         (domainListFree):
2004         (aboutDataFillTable):
2005         (gotWebsiteDataCallback):
2006         (aboutDataHandleRequest):
2007         (aboutURISchemeRequestCallback):
2008         (main):
2009         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2010         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2011         (serverCallback):
2012         (beforeAll):
2013         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2014         (serverCallback):
2015         (WebsiteDataTest::WebsiteDataTest):
2016         (WebsiteDataTest::~WebsiteDataTest):
2017         (WebsiteDataTest::fetch):
2018         (WebsiteDataTest::remove):
2019         (WebsiteDataTest::clear):
2020         (testWebsiteDataConfiguration):
2021         (testWebsiteDataCache):
2022         (testWebsiteDataStorage):
2023         (testWebsiteDataDatabases):
2024         (testWebsiteDataAppcache):
2025         (beforeAll):
2026         (afterAll):
2027
2028 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2029
2030         Unreviewed, rolling out r211062.
2031         https://bugs.webkit.org/show_bug.cgi?id=167354
2032
2033         broke API tests (Requested by alexchristensen on #webkit).
2034
2035         Reverted changeset:
2036
2037         "Pass down website autoplay policies to media elements"
2038         https://bugs.webkit.org/show_bug.cgi?id=167132
2039         http://trac.webkit.org/changeset/211062
2040
2041 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2042
2043         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2044         https://bugs.webkit.org/show_bug.cgi?id=167330
2045
2046         Reviewed by Tim Horton.
2047
2048         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2049         (TestWebKitAPI::TEST_F):
2050
2051 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2052
2053         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2054         https://bugs.webkit.org/show_bug.cgi?id=167317
2055
2056         Reviewed by Sam Weinig.
2057
2058         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2059         (TestWebKitAPI::TEST_F):
2060
2061 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2062
2063         svn-create-patch should emit properties when files are moved or copied
2064         https://bugs.webkit.org/show_bug.cgi?id=167264
2065
2066         Reviewed by Daniel Bates.
2067
2068         * Scripts/svn-create-patch:
2069         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2070
2071 2017-01-23  Youenn Fablet  <youenn@apple.com>
2072
2073         [WebRTC] Filter libwebrtc link flags
2074         https://bugs.webkit.org/show_bug.cgi?id=167287
2075
2076         Reviewed by Alex Christensen.
2077
2078         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2079         (CMakeGenerator._compute_link_flags):
2080         (CMakeGenerator._compute_link_flags.keep_flag):
2081         (CMakeGenerator._generate_compile_target_options):
2082
2083 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2084
2085         [WebRTC] Make VP8 optional in libwebrtc
2086         https://bugs.webkit.org/show_bug.cgi?id=167257
2087
2088         Reviewed by Darin Adler.
2089
2090         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2091         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
2092
2093 2017-01-23  Jer Noble  <jer.noble@apple.com>
2094
2095         Video details does not apear and missing scrubber in Control Center
2096         https://bugs.webkit.org/show_bug.cgi?id=167233
2097
2098         Reviewed by Alex Christensen.
2099
2100         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
2101         NowPlayingControlTests for iOS.
2102
2103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2104         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2105         (-[NowPlayingTestWebView setWindowVisible:]):
2106         (TestWebKitAPI::TEST):
2107         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2108         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2109         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2110         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
2111         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
2112         (SOFT_LINK_CLASS):
2113         (-[TestMessageHandler addMessage:withHandler:]):
2114         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2115         (__simulated_forceClickAssociatedEventsMask):
2116         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2117         (-[TestWKWebViewHostWindow isKeyWindow]):
2118         (-[TestWKWebViewHostWindow makeKeyWindow]):
2119         (-[TestWKWebViewHostWindow resignKeyWindow]):
2120         (-[TestWKWebView initWithFrame:]):
2121         (-[TestWKWebView initWithFrame:configuration:]):
2122         (-[TestWKWebView _setUpTestWindow:]):
2123         (-[TestWKWebView performAfterReceivingMessage:action:]):
2124         (-[TestWKWebView loadTestPageNamed:]):
2125         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2126         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2127         (-[TestWKWebView waitForMessage:]):
2128         (-[TestWKWebView performAfterLoading:]):
2129         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2130         (-[TestWKWebView typeCharacter:]):
2131
2132 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2133
2134         Unreviewed. Bring back gtk-doc error messages after r209981.
2135
2136         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
2137         impossible to know what's wrong.
2138
2139         * gtk/gtkdoc.py:
2140         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
2141
2142 2017-01-20  Youenn Fablet  <youennf@gmail.com>
2143
2144         [WebRTC] Update build system to make G711 optional in libwebrtc
2145         https://bugs.webkit.org/show_bug.cgi?id=167256
2146
2147         Reviewed by Alex Christensen.
2148
2149         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2150         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2151
2152 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2153
2154         Cleanup RuntimeEnabledFeatures
2155         https://bugs.webkit.org/show_bug.cgi?id=167228
2156
2157         Reviewed by Simon Fraser.
2158
2159         * DumpRenderTree/mac/DumpRenderTree.mm:
2160         (enableExperimentalFeatures):
2161         (resetWebPreferencesToConsistentValues):
2162         (setWebPreferencesForTestOptions):
2163         (resetWebViewToConsistentStateBeforeTesting):
2164         * DumpRenderTree/win/DumpRenderTree.cpp:
2165         (enableExperimentalFeatures):
2166         (resetWebPreferencesToConsistentValues):
2167         More closely match WebKitTestRunner initialization of preferences
2168         for experimental features.
2169
2170 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2171
2172         Build Fix for Windows DumpRenderTree after r210976
2173         https://bugs.webkit.org/show_bug.cgi?id=167115
2174
2175         * DumpRenderTree/win/DumpRenderTree.cpp:
2176         (resetWebPreferencesToConsistentValues):
2177
2178 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2179
2180         Remove outdated ENABLE(CSP_NEXT) build flag
2181         https://bugs.webkit.org/show_bug.cgi?id=167252
2182
2183         Reviewed by Brent Fulgham.
2184
2185         * Scripts/webkitperl/FeatureList.pm:
2186         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2187
2188 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2189
2190         Build Fix for Windows DumpRenderTree after r210976
2191
2192         * DumpRenderTree/win/DumpRenderTree.cpp:
2193         (resetWebPreferencesToConsistentValues):
2194
2195 2017-01-20  Antoine Quint  <graouts@apple.com>
2196
2197         Web Animations should be off by default and enabled as an experimental feature
2198         https://bugs.webkit.org/show_bug.cgi?id=167115
2199         <rdar://problem/30048963>
2200
2201         Reviewed by Joseph Pecoraro.
2202
2203         Turn Web Animations on in DRT.
2204
2205         * DumpRenderTree/mac/DumpRenderTree.mm:
2206         (resetWebPreferencesToConsistentValues):
2207         * DumpRenderTree/win/DumpRenderTree.cpp:
2208         (resetWebPreferencesToConsistentValues):
2209
2210 2017-01-20  Youenn Fablet  <youenn@apple.com>
2211
2212         [WebRTC] Add libwebrtc build infrastructure
2213         https://bugs.webkit.org/show_bug.cgi?id=167207
2214
2215         Reviewed by Alex Christensen.
2216
2217         Adding a script doing the libwebrtc project json to CMake file conversion.
2218
2219         * Scripts/generate-libwebrtc-cmake: Added.
2220         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
2221         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
2222
2223 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2224
2225         Mini Browser: Show tooltip for Experimental Features
2226         https://bugs.webkit.org/show_bug.cgi?id=167225
2227
2228         Reviewed by Alex Christensen.
2229
2230         * MiniBrowser/mac/SettingsController.m:
2231         (-[SettingsController _populateMenu]):
2232         Include the full details string as a tooltip.
2233
2234 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
2235
2236         [Win] Test output results should not be written twice.
2237         https://bugs.webkit.org/show_bug.cgi?id=167197
2238
2239         Reviewed by Brent Fulgham.
2240
2241         Prevent test output from being written twice by returning early from
2242         the dump() function, if it already has been called.
2243         This patch also adds a missing newline to a test output line. 
2244         
2245         * DumpRenderTree/win/DumpRenderTree.cpp:
2246         (dump):
2247
2248 2017-01-20  Antoine Quint  <graouts@apple.com>
2249
2250         [Modern Media Controls] Turn modern media controls on by default
2251         https://bugs.webkit.org/show_bug.cgi?id=165668
2252
2253         Reviewed by Dean Jackson.
2254
2255         Enabled modern media controls by default in test runners.
2256
2257         * DumpRenderTree/TestOptions.h:
2258         * WebKitTestRunner/TestOptions.h:
2259
2260 2017-01-19  Chris Dumez  <cdumez@apple.com>
2261
2262         iterable<> should be enabled on WK1
2263         https://bugs.webkit.org/show_bug.cgi?id=167221
2264         <rdar://problem/30108531>
2265
2266         Reviewed by Youenn Fablet.
2267
2268         * DumpRenderTree/mac/DumpRenderTree.mm:
2269         (resetWebPreferencesToConsistentValues):
2270         * DumpRenderTree/win/DumpRenderTree.cpp:
2271         (resetWebPreferencesToConsistentValues):
2272         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2273         (WTR::InjectedBundle::beginTesting):
2274         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2275         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2276         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2277
2278 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2279
2280         Ensure status server logs go to log file
2281         https://bugs.webkit.org/show_bug.cgi?id=167210
2282
2283         Reviewed by Alexey Proskuryakov.
2284
2285         * Scripts/webkitpy/common/net/statusserver.py:
2286         (StatusServer.next_work_item): Change log level from debug to info in
2287         order to facilitate deubgging issues.
2288         (StatusServer.update_work_items): Same.
2289
2290 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2291
2292         Additional selection tests and interpolation fix
2293         https://bugs.webkit.org/show_bug.cgi?id=167171
2294
2295         Reviewed by Simon Fraser.
2296
2297         We weren't adding the final event when interpolating event streams.
2298
2299         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2300         (-[HIDEventGenerator interpolatedEvents:]):
2301
2302 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2303
2304         [Cocoa] Variation fonts are erroneously disabled on iOS
2305         https://bugs.webkit.org/show_bug.cgi?id=167172
2306
2307         Reviewed by Simon Fraser.
2308
2309         OpenSource builders don't seem to understand sdk=embedded*.
2310
2311         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2312
2313 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2314
2315         Unreviewed. Fix GTK+ unit tests failing since r210531.
2316
2317         Avoid using paths to files that don't actually exist.
2318
2319         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2320         (testWebKitConsoleMessageNetworkError):
2321         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2322         (testContextMenuDefaultMenu):
2323         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2324         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2325         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2326
2327 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2328
2329         [GTK] Provide API to set proxy settings
2330         https://bugs.webkit.org/show_bug.cgi?id=128674
2331
2332         Reviewed by Michael Catanzaro.
2333
2334         Add tests for new proxy settings API.
2335
2336         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2337         (serverCallback):
2338         (ProxyTest::ProxyTest):
2339         (ProxyTest::~ProxyTest):
2340         (ProxyTest::loadURIAndGetMainResourceData):
2341         (ProxyTest::proxyServerPortAsString):
2342         (testWebContextProxySettings):
2343         (beforeAll):
2344
2345 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2346
2347         Add back my old email address so old commits will still match it.
2348
2349         * Scripts/webkitpy/common/config/contributors.json:
2350
2351 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2352
2353         Remove my old email address from contributors.json and watchlist.
2354
2355         * Scripts/validate-committer-lists:
2356         (CommitterListFromGit): Change the mapping to the correct email.
2357         * Scripts/webkitpy/common/config/contributors.json:
2358         * Scripts/webkitpy/common/config/watchlist:
2359
2360 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2361
2362         Unreviewed, rolling out r210848.
2363
2364         This change introduced media-related LayoutTest failures and
2365         crashes on macOS.
2366
2367         Reverted changeset:
2368
2369         "[Modern Media Controls] Turn modern media controls on by
2370         default"
2371         https://bugs.webkit.org/show_bug.cgi?id=165668
2372         http://trac.webkit.org/changeset/210848
2373
2374 2017-01-18  Andreas Kling  <akling@apple.com>
2375
2376         Document::securityOrigin() should return a reference.
2377         <https://webkit.org/b/167124>
2378
2379         Reviewed by Sam Weinig.
2380
2381         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2382         (TestWebKitAPI::TEST_F):
2383
2384 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2385
2386         [Win] Clipboard tests are flaky.
2387         https://bugs.webkit.org/show_bug.cgi?id=167088
2388
2389         Reviewed by Brent Fulgham.
2390
2391         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2392         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2393
2394         * DumpRenderTree/win/DumpRenderTree.cpp:
2395         (main):
2396
2397 2017-01-18  Antoine Quint  <graouts@apple.com>
2398
2399         [Modern Media Controls] Turn modern media controls on by default
2400         https://bugs.webkit.org/show_bug.cgi?id=165668
2401
2402         Reviewed by Dean Jackson.
2403
2404         Enabled modern media controls by default in test runners. 
2405
2406         * DumpRenderTree/TestOptions.h:
2407         * WebKitTestRunner/TestOptions.h:
2408
2409 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2410
2411         Unreviewed, rolling out r210834
2412         https://bugs.webkit.org/show_bug.cgi?id=165668
2413
2414         It introduced dozens of test timeouts.
2415
2416         Reverted changeset:
2417         "[Modern Media Controls] Turn modern media controls on by default"
2418         https://bugs.webkit.org/show_bug.cgi?id=165668
2419         http://trac.webkit.org/changeset/210834
2420
2421 2017-01-17  Antoine Quint  <graouts@apple.com>
2422
2423         [Modern Media Controls] Turn modern media controls on by default
2424         https://bugs.webkit.org/show_bug.cgi?id=165668
2425
2426         Reviewed by Dean Jackson.
2427
2428         Enabled modern media controls by default in test runners. 
2429
2430         * DumpRenderTree/TestOptions.h:
2431         * WebKitTestRunner/TestOptions.h:
2432
2433 2017-01-17  Chris Dumez  <cdumez@apple.com>
2434
2435         Document title changed twice when setting document.title
2436         https://bugs.webkit.org/show_bug.cgi?id=167065
2437
2438         Reviewed by Darin Adler.
2439
2440         Add WebKit2GTK API test that was written by Michael Catanzaro.
2441
2442         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2443         (testWebViewTitleChange):
2444         (beforeAll):
2445
2446 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2447
2448         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2449         https://bugs.webkit.org/show_bug.cgi?id=116551
2450         <rdar://problem/13949830>
2451
2452         Reviewed by Alex Christensen.
2453
2454         * Scripts/webkitperl/FeatureList.pm:
2455         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2456         that is part of the existing WEB_TIMING feature.
2457
2458         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2459
2460 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2461
2462         'webkit-patch post' no longer works with moved/copied files
2463         https://bugs.webkit.org/show_bug.cgi?id=166914
2464         <rdar://problem/29979707>
2465
2466         Reviewed by Daniel Bates.
2467
2468         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2469         file outputs only the "Index:" line with an empty body.  This workaround
2470         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2471         public email list tracking this bug is below.
2472         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2473         
2474
2475         * Scripts/svn-create-patch:
2476         (generateDiff): Ignore an "Index:" line with an empty body.
2477
2478 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2479
2480         Remove the REQUEST_ANIMATION_FRAME flag
2481         https://bugs.webkit.org/show_bug.cgi?id=156980
2482         <rdar://problem/25906849>
2483
2484         Reviewed by Simon Fraser.
2485
2486         * Scripts/webkitperl/FeatureList.pm:
2487         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2488
2489 2017-01-15  Sam Weinig  <sam@webkit.org>
2490
2491         Add the ability to use numbers in makeString()
2492         https://bugs.webkit.org/show_bug.cgi?id=167087
2493
2494         Reviewed by Darin Adler.
2495
2496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2497         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2498         Add tests for StringConcatenate, focusing on new numeric additions.
2499
2500 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2501
2502         Unreviewed, remove stale comment.
2503
2504         This test was fixed by r163173.
2505
2506         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2507
2508 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2509
2510         Annotate large string tests with largeHeap
2511         https://bugs.webkit.org/show_bug.cgi?id=167054
2512
2513         Reviewed by Filip Pizlo.
2514
2515         * Scripts/run-javascriptcore-tests:
2516         * Scripts/run-jsc-stress-tests:
2517
2518 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2519
2520         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2521         https://bugs.webkit.org/show_bug.cgi?id=167043
2522
2523         Reviewed by Darin Adler.
2524
2525         * Scripts/webkitperl/FeatureList.pm:
2526
2527 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2528
2529         Remove ENABLE(DETAILS_ELEMENT) guards
2530         https://bugs.webkit.org/show_bug.cgi?id=167042
2531
2532         Reviewed by Alex Christensen.
2533
2534         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2535
2536 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2537
2538         26 MotionMark performance tests failing
2539         https://bugs.webkit.org/show_bug.cgi?id=166854
2540
2541         Reviewed by Ryosuke Niwa.
2542
2543         Unrelated change. This is the last place that we need to rename Animometer
2544         to MotionMark.
2545
2546         * Scripts/webkitpy/common/config/watchlist:
2547
2548 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2549
2550         run-jsc-benchmarks' echo should have -e option
2551         https://bugs.webkit.org/show_bug.cgi?id=167009
2552
2553         Reviewed by Sam Weinig.
2554
2555         echo requires `-e` option to use escape sequence.
2556         Without it, in some environment (in my Fedora 25), the escape sequence is not
2557         recognized and just dumped as `\c` etc.
2558
2559         * Scripts/run-jsc-benchmarks:
2560
2561 2017-01-12  Chris Dumez  <cdumez@apple.com>
2562
2563         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2564         https://bugs.webkit.org/show_bug.cgi?id=166995
2565
2566         Reviewed by Jer Noble.
2567
2568         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2569         as some people are having trouble building without it.
2570
2571         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2572
2573 2017-01-12  Sam Weinig  <sam@webkit.org>
2574
2575         Add the ability to filter the set of bindings tests you want to run
2576         https://bugs.webkit.org/show_bug.cgi?id=166977
2577
2578         Reviewed by Tim Horton.
2579
2580         Allows doing things like:
2581             run-bindings-tests TestObj* TestCEReactions*
2582         
2583         to run only those tests that match the patterns.
2584
2585         * Scripts/run-bindings-tests:
2586         (main):
2587         Switch to using optparse and pass the remaining args as the filters.
2588
2589         * Scripts/webkitpy/bindings/main.py:
2590         (BindingsTests.__init__):
2591         Store the pattens.
2592
2593         (BindingsTests.test_matches_patterns):
2594         Add helper predicate to determine if a test should be run. When no
2595         patterns are present, all tests should run.
2596
2597         (BindingsTests.run_tests):
2598         Filter tests using the passed in patterns.
2599
2600 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2601
2602         Followup fix after r210503.
2603         https://bugs.webkit.org/show_bug.cgi?id=166887
2604
2605         Reviewed by Alex Christensen.
2606
2607         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2608         duplicated file handle on Windows. This patch fixes the remaining call sites.
2609
2610         * DumpRenderTree/PixelDumpSupport.cpp:
2611         * DumpRenderTree/TestRunner.cpp:
2612         (TestRunner::waitToDumpWatchdogTimerFired):
2613         * DumpRenderTree/TestRunner.h:
2614         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2615         * DumpRenderTree/win/DumpRenderTree.cpp:
2616         * DumpRenderTree/win/DumpRenderTreeWin.h:
2617         * DumpRenderTree/win/TestRunnerWin.cpp:
2618         (TestRunner::setSpellCheckerLoggingEnabled):
2619
2620 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2621
2622         Add committer status for Megan
2623         https://bugs.webkit.org/show_bug.cgi?id=166954
2624
2625         Reviewed by Tim Horton.
2626
2627         Add committer status for Megan Gardner
2628
2629         * Scripts/webkitpy/common/config/contributors.json:
2630
2631 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2632
2633         Unreviewed test fix after r210599.
2634
2635         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2636         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2637
2638 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2639
2640         Unreviewed build fix after r210599.
2641
2642         Add missing files.
2643
2644         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2645         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2646
2647 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2648
2649         File scheme should not allow access of a resource on a different volume.
2650         https://bugs.webkit.org/show_bug.cgi?id=158552
2651         <rdar://problem/15307582>
2652
2653         Reviewed by Alex Christensen.
2654
2655         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2656         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2657         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2658
2659 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2660
2661         Unreviewed, rolling out r210571.
2662
2663         This change broke the 32-bit macOS build and caused LayoutTest
2664         failures.
2665
2666         Reverted changeset:
2667
2668         "File scheme should not allow access of a resource on a
2669         different volume."
2670         https://bugs.webkit.org/show_bug.cgi?id=158552
2671         http://trac.webkit.org/changeset/210571
2672
2673 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2674
2675         [GTK] install-dependencies script misses gdb
2676         https://bugs.webkit.org/show_bug.cgi?id=166917
2677
2678         Reviewed by Michael Catanzaro.
2679
2680         gdb is needed for generating the crash logs.
2681
2682         * gtk/install-dependencies:
2683
2684 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2685
2686         [GTK] No way for applications to set notification permissions without waiting for permission request
2687         https://bugs.webkit.org/show_bug.cgi?id=163366
2688
2689         Reviewed by Carlos Garcia Campos.
2690
2691         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2692         (testWebViewNotification):
2693         (setInitialNotificationPermissionsAllowedCallback):
2694         (setInitialNotificationPermissionsDisallowedCallback):
2695         (testWebViewNotificationInitialPermissionAllowed):
2696         (testWebViewNotificationInitialPermissionDisallowed):
2697         (beforeAll):
2698         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2699         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2700         (WebViewTest::WebViewTest):
2701         (WebViewTest::initializeWebView):
2702         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2703
2704 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2705
2706         MobileMiniBrowser tests don't work by default
2707         https://bugs.webkit.org/show_bug.cgi?id=166910
2708
2709         Reviewed by Alex Christensen.
2710
2711         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2712         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2713
2714 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2715
2716         File scheme should not allow access of a resource on a different volume.
2717         https://bugs.webkit.org/show_bug.cgi?id=158552
2718         <rdar://problem/15307582>
2719
2720         Reviewed by Alex Christensen.
2721
2722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2723         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2724         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2725
2726 2017-01-10  Mark Lam  <mark.lam@apple.com>
2727
2728         Reverting run-jsc-stress-tests' $buildType to use string values.
2729         https://bugs.webkit.org/show_bug.cgi?id=166912
2730
2731         Rubber stamped by Filip Pizlo.
2732
2733         This is so that we can test for it in the tests e.g.
2734         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2735
2736         * Scripts/run-jsc-stress-tests:
2737
2738 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2739
2740         Temporarily add back the file removed in r210463 to unbreak internal bots.
2741
2742         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2743
2744 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2745
2746         svn-apply failed to apply a patch (deleting file with svn property)
2747         https://bugs.webkit.org/show_bug.cgi?id=165953
2748
2749         Reviewed by Daniel Bates.
2750
2751         * Scripts/VCSUtils.pm:
2752         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2753         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2754
2755 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2756
2757         Update flakiness dashboard configuration.
2758         https://bugs.webkit.org/show_bug.cgi?id=166869
2759
2760         Reviewed by Alexey Proskuryakov.
2761
2762         * TestResultServer/static-dashboards/builders.jsonp:
2763         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2764
2765 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2766
2767         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2768         https://bugs.webkit.org/show_bug.cgi?id=165232
2769
2770         Unreviewed follow-up patch after r210539 and r210523.
2771
2772         Instead of using that environment variable, the argument
2773         --display-server=xorg should be passed now.
2774
2775         The GTK+ performance bot was the only bot using this, and is
2776         already passing --display-server=xorg after r210539.
2777
2778         * Scripts/webkitpy/port/gtk.py:
2779         (GtkPort._driver_class):
2780
2781 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2782
2783         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2784         https://bugs.webkit.org/show_bug.cgi?id=166872
2785
2786         Reviewed by Michael Catanzaro.
2787
2788         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2789         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2790         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2791         The step RunWebKitTests already has support for it.
2792
2793         * BuildSlaveSupport/build.webkit.org-config/config.json:
2794         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2795         (RunGtkAPITests.start):
2796         (RunAndUploadPerfTests.start):
2797         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2798
2799 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2800
2801         Unreviewed, rolling out r210531.
2802
2803         This change broke the 32-bit macOS build and caused LayoutTest
2804         failures.
2805
2806         Reverted changeset:
2807
2808         "File scheme should not allow access of a resource on a
2809         different volume."
2810         https://bugs.webkit.org/show_bug.cgi?id=158552
2811         http://trac.webkit.org/changeset/210531
2812
2813 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2814
2815         File scheme should not allow access of a resource on a different volume.
2816         https://bugs.webkit.org/show_bug.cgi?id=158552
2817         <rdar://problem/15307582>
2818
2819         Reviewed by Alex Christensen.
2820
2821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2822         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2823         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2824
2825 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2826
2827         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2828         https://bugs.webkit.org/show_bug.cgi?id=165232
2829
2830         Reviewed by Michael Catanzaro.
2831
2832         Add a new WaylandDriver to run the tests in the user current wayland session.
2833
2834         Also merge all the configuration options for selecting the display server inside one
2835         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2836
2837         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2838
2839         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2840         (TestRunner._create_driver):
2841         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2842         (parse_args):
2843         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2844         (PerfTestsRunner._parse_args):
2845         * Scripts/webkitpy/port/gtk.py:
2846         (GtkPort.__init__):
2847         (GtkPort._driver_class):
2848         (GtkPort._search_paths):
2849         * Scripts/webkitpy/port/waylanddriver.py: Added.
2850         (WaylandDriver):
2851         (WaylandDriver.check_driver):
2852         (WaylandDriver._setup_environ_for_test):
2853         (WaylandDriver._start):
2854
2855 2017-01-09  Andy Estes  <aestes@apple.com>
2856
2857         [QuickLook] Add a layout test for webkit.org/b/135651
2858         https://bugs.webkit.org/show_bug.cgi?id=166855
2859
2860         Reviewed by Andreas Kling.
2861
2862         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2863         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2864         errors with code WebKitErrorCannotShowURL.
2865         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2866         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2867         not specific to WebKit2 error codes.
2868
2869 2017-01-09  Antoine Quint  <graouts@apple.com>
2870
2871         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2872         https://bugs.webkit.org/show_bug.cgi?id=166837
2873
2874         Reviewed by Alex Christensen.
2875
2876         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2877         the provided value when trying to determine the path to the test file. Failing
2878         that, we use the computed URL or the raw path provided to cover all cases.
2879         
2880         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2881         by applying this patch and seeing the number test failures dramatically reduced
2882         with WK1 due to the option to turn modern media controls off for older media controls
2883         tests.
2884
2885         * DumpRenderTree/DumpRenderTree.h:
2886         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2887         (parseInputLine):
2888         * DumpRenderTree/TestOptions.h:
2889         * DumpRenderTree/TestOptions.mm:
2890         (TestOptions::TestOptions):
2891         * DumpRenderTree/mac/DumpRenderTree.mm:
2892         (runTest):
2893
2894 2017-01-09  Milan Crha  <mcrha@redhat.com>
2895
2896         prepare-ChangeLog: Correct help string for --style option
2897         https://bugs.webkit.org/show_bug.cgi?id=166725
2898
2899         Reviewed by Alexey Proskuryakov.
2900
2901         * Scripts/prepare-ChangeLog:
2902         (main):
2903
2904 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2905
2906         https://bugs.webkit.org/show_bug.cgi?id=166839
2907         Add php7 support for macOS.
2908         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2909
2910         Reviewed by Alexey Proskuryakov.
2911
2912         * Scripts/webkitpy/port/base.py:
2913         (Port._is_darwin_php_version_7):
2914         (Port._debian_php_version):
2915         (Port):
2916         (Port._darwin_php_version):
2917         (Port._apache_config_file_name_for_platform):
2918
2919 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2920
2921         [GTK] Should support key and code properties on keyboard events
2922         https://bugs.webkit.org/show_bug.cgi?id=166759
2923
2924         Reviewed by Carlos Garcia Campos.
2925
2926         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2927         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2928         on tests.
2929
2930 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2931
2932         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2933         https://bugs.webkit.org/show_bug.cgi?id=166760
2934
2935         Reviewed by Darin Adler.
2936
2937         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2938         We can work around that by duplicating and redirecting stdout.
2939
2940         * DumpRenderTree/PixelDumpSupport.cpp:
2941         (dumpWebViewAsPixelsAndCompareWithExpected):
2942         (printPNG):
2943         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2944         (logEventProc):
2945         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2946         (DRTDesktopNotificationPresenter::showDesktopNotification):
2947         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2948         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2949         * DumpRenderTree/win/DumpRenderTree.cpp:
2950         (dumpFrameScrollPosition):
2951         (dumpHistoryItem):
2952         (dumpBackForwardList):
2953         (dump):
2954         (runTest):
2955         (main):
2956         * DumpRenderTree/win/DumpRenderTreeWin.h:
2957         * DumpRenderTree/win/EditingDelegate.cpp:
2958         (EditingDelegate::shouldBeginEditingInDOMRange):
2959         (EditingDelegate::shouldEndEditingInDOMRange):
2960         (EditingDelegate::shouldInsertNode):
2961         (EditingDelegate::shouldInsertText):
2962         (EditingDelegate::shouldDeleteDOMRange):
2963         (EditingDelegate::shouldChangeSelectedDOMRange):
2964         (EditingDelegate::shouldApplyStyle):
2965         (EditingDelegate::shouldChangeTypingStyle):
2966         (EditingDelegate::doPlatformCommand):
2967         (EditingDelegate::webViewDidBeginEditing):
2968         (EditingDelegate::webViewDidChange):
2969         (EditingDelegate::webViewDidEndEditing):
2970         (EditingDelegate::webViewDidChangeTypingStyle):
2971         (EditingDelegate::webViewDidChangeSelection):
2972         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2973         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2974         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2975         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2976         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2977         (FrameLoadDelegate::didCommitLoadForFrame):
2978         (FrameLoadDelegate::didReceiveTitle):
2979         (FrameLoadDelegate::didFinishLoadForFrame):
2980         (FrameLoadDelegate::didFailLoadWithError):
2981         (FrameLoadDelegate::willPerformClientRedirectToURL):
2982         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2983         (FrameLoadDelegate::windowScriptObjectAvailable):
2984         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2985         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2986         (FrameLoadDelegate::didDisplayInsecureContent):
2987         (FrameLoadDelegate::didRunInsecureContent):
2988         (FrameLoadDelegate::webViewProgressFinishedNotification):
2989         * DumpRenderTree/win/HistoryDelegate.cpp:
2990         (HistoryDelegate::didNavigateWithNavigationData):
2991         (HistoryDelegate::didPerformClientRedirectFromURL):
2992         (HistoryDelegate::didPerformServerRedirectFromURL):
2993         (HistoryDelegate::updateHistoryTitle):
2994         (HistoryDelegate::populateVisitedLinksForWebView):
2995         * DumpRenderTree/win/PolicyDelegate.cpp:
2996         (PolicyDelegate::decidePolicyForNavigationAction):
2997         (PolicyDelegate::unableToImplementPolicyWithError):
2998         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2999         (ResourceLoadDelegate::willSendRequest):
3000         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3001         (ResourceLoadDelegate::didReceiveResponse):
3002         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3003         (ResourceLoadDelegate::didFailLoadingWithError):
3004         * DumpRenderTree/win/TestRunnerWin.cpp:
3005         (TestRunner::addDisallowedURL):
3006         (TestRunner::originsWithApplicationCache):
3007         (TestRunner::setStorageDatabaseIdleInterval):
3008         (TestRunner::closeIdleLocalStorageDatabases):
3009         (TestRunner::copyDecodedHostName):
3010         (TestRunner::copyEncodedHostName):
3011         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3012         (TestRunner::isGeolocationProviderActive):
3013         (TestRunner::pathToLocalResource):
3014         (TestRunner::setMockDeviceOrientation):
3015         (TestRunner::setMockGeolocationPosition):
3016         (TestRunner::setMockGeolocationPositionUnavailableError):
3017         (TestRunner::setSpatialNavigationEnabled):
3018         (TestRunner::setAutomaticLinkDetectionEnabled):
3019         (TestRunner::isCommandEnabled):
3020         (TestRunner::authenticateSession):
3021         (TestRunner::addChromeInputField):
3022         (TestRunner::removeChromeInputField):
3023         (TestRunner::focusWebView):
3024         (TestRunner::grantWebNotificationPermission):
3025         (TestRunner::denyWebNotificationPermission):
3026         (TestRunner::removeAllWebNotificationPermissions):
3027         (TestRunner::simulateWebNotificationClick):
3028         (TestRunner::imageCountInGeneralPasteboard):
3029         * DumpRenderTree/win/UIDelegate.cpp:
3030         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3031         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3032         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3033         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3034         (UIDelegate::webViewAddMessageToConsole):
3035         (UIDelegate::exceededDatabaseQuota):
3036         (UIDelegate::setStatusText):
3037         (UIDelegate::didPressMissingPluginButton):
3038
3039 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3040
3041         Add a setting to create editable MiniBrowser windows by default
3042         https://bugs.webkit.org/show_bug.cgi?id=166806
3043
3044         Reviewed by Beth Dakin.
3045
3046         * MiniBrowser/mac/AppDelegate.m:
3047         (-[BrowserAppDelegate createBrowserWindowController:]):
3048         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3049         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3050         * MiniBrowser/mac/SettingsController.h:
3051         * MiniBrowser/mac/SettingsController.m:
3052         (-[SettingsController _populateMenu]):
3053         (-[SettingsController validateMenuItem:]):
3054         (-[SettingsController toggleCreateEditorByDefault:]):
3055         (-[SettingsController createEditorByDefault]):
3056         Add a setting and update the key equivalents accordingly.
3057         Also make sure to make the right kind of window on launch.
3058
3059 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3060
3061         Fix the 32-bit build.
3062
3063         * MiniBrowser/mac/BrowserWindowController.h:
3064         * MiniBrowser/mac/BrowserWindowController.m:
3065
3066 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3067
3068         Fix the 32-bit build.
3069
3070         * MiniBrowser/mac/BrowserWindowController.m:
3071
3072 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3073
3074         Make it possible to drop HTML files on the MiniBrowser icon
3075         https://bugs.webkit.org/show_bug.cgi?id=166802
3076
3077         Reviewed by Simon Fraser.
3078
3079         * MiniBrowser/mac/AppDelegate.m:
3080         (-[BrowserAppDelegate application:openFile:]):
3081         * MiniBrowser/mac/Info.plist:
3082         If you're using an editable window, the usual trick of dropping on the
3083         window doesn't work anymore (it makes an <attachment> instead).
3084
3085 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3086
3087         MiniBrowser window gets smaller each time it is instantiated
3088         https://bugs.webkit.org/show_bug.cgi?id=166807
3089
3090         Reviewed by Andy Estes.
3091
3092         * MiniBrowser/mac/BrowserWindowController.m:
3093         (-[BrowserWindowController windowDidLoad]):
3094         * MiniBrowser/mac/BrowserWindow.xib:
3095         Turn on full-window content view support with IB, instead of waiting
3096         until after the views have been loaded. This seems to resolve the
3097         longstanding ever-shrinking-window problem.
3098
3099 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3100
3101         Add indent/outdent items to MiniBrowser's new format menu
3102         https://bugs.webkit.org/show_bug.cgi?id=166805
3103
3104         Reviewed by Dan Bernstein.
3105
3106         * MiniBrowser/mac/MainMenu.xib:
3107
3108 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3109
3110         Add a stock Format menu to MiniBrowser
3111         https://bugs.webkit.org/show_bug.cgi?id=166804
3112
3113         Reviewed by Andy Estes.
3114
3115         * MiniBrowser/mac/MainMenu.xib:
3116         Many of the features automatically work with editable web views.
3117         However, this seems to expose a bug where none of the font-related features
3118         (Cmd-B, for example) work until the first time the font panel is shown,
3119         per process, which will need to be investigated separately.
3120
3121 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3122
3123         Remove unused applicationWillTerminate methods from MiniBrowser
3124         https://bugs.webkit.org/show_bug.cgi?id=166803
3125
3126         Reviewed by Andy Estes.
3127
3128         * MiniBrowser/mac/AppDelegate.m:
3129         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
3130         * MiniBrowser/mac/BrowserWindowController.h:
3131         * MiniBrowser/mac/BrowserWindowController.m:
3132         (-[BrowserWindowController applicationTerminating]): Deleted.
3133         * MiniBrowser/mac/WK1BrowserWindowController.m:
3134         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
3135         * MiniBrowser/mac/WK2BrowserWindowController.m:
3136         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
3137
3138 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3139
3140         Add the ability to create empty contentEditable windows in MiniBrowser
3141         https://bugs.webkit.org/show_bug.cgi?id=166801
3142
3143         Reviewed by Wenson Hsieh.
3144
3145         * MiniBrowser/mac/AppDelegate.h:
3146         * MiniBrowser/mac/AppDelegate.m:
3147         (-[BrowserAppDelegate createBrowserWindowController:]):
3148         (-[BrowserAppDelegate newWindow:]):
3149         (-[BrowserAppDelegate newEditorWindow:]):
3150         (-[BrowserAppDelegate openDocument:]):
3151         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3152         * MiniBrowser/mac/BrowserWindowController.h:
3153         * MiniBrowser/mac/BrowserWindowController.m:
3154         (-[BrowserWindowController loadHTMLString:]):
3155         (-[BrowserWindowController toggleEditable:]):
3156         * MiniBrowser/mac/MainMenu.xib:
3157         * MiniBrowser/mac/WK1BrowserWindowController.m:
3158         (-[WK1BrowserWindowController awakeFromNib]):
3159         (-[WK1BrowserWindowController loadHTMLString:]):
3160         (-[WK1BrowserWindowController validateMenuItem:]):
3161         (-[WK1BrowserWindowController setEditable:]):
3162         (-[WK1BrowserWindowController updateTitle:]):
3163         * MiniBrowser/mac/WK2BrowserWindowController.m:
3164         (-[WK2BrowserWindowController awakeFromNib]):
3165         (-[WK2BrowserWindowController validateMenuItem:]):
3166         (-[WK2BrowserWindowController setEditable:]):
3167         (-[WK2BrowserWindowController updateTitle:]):
3168         (-[WK2BrowserWindowController loadHTMLString:]):
3169         Merge more functionality from WebEditingTester.
3170         Add two menu items for creating empty editable WebKit1/2 windows.
3171         Add a menu item to the Edit menu to toggle editability on any window.
3172
3173 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3174
3175         Implement find-in-page in MiniBrowser
3176         https://bugs.webkit.org/show_bug.cgi?id=166799
3177
3178         Reviewed by Andy Estes.
3179
3180         * MiniBrowser/mac/BrowserWindow.xib:
3181         * MiniBrowser/mac/BrowserWindowController.h:
3182         * MiniBrowser/mac/BrowserWindowController.m:
3183         (-[BrowserWindowController find:]): Deleted.
3184         * MiniBrowser/mac/MainMenu.xib:
3185         * MiniBrowser/mac/WK1BrowserWindowController.m:
3186         (-[WK1BrowserWindowController toggleShrinkToFit:]):
3187         (-[WK1BrowserWindowController find:]): Deleted.
3188         * MiniBrowser/mac/WK2BrowserWindowController.m:
3189         (-[WK2BrowserWindowController awakeFromNib]):
3190         (-[WK2BrowserWindowController dealloc]):
3191         (-[WK2BrowserWindowController validateMenuItem:]):
3192         (-[WK2BrowserWindowController performTextFinderAction:]):
3193         (-[WK2BrowserWindowController findBarView]):
3194         (-[WK2BrowserWindowController setFindBarView:]):
3195         (-[WK2BrowserWindowController isFindBarVisible]):
3196         (-[WK2BrowserWindowController setFindBarVisible:]):
3197         (-[WK2BrowserWindowController contentView]):
3198         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
3199         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
3200         (-[WK2BrowserWindowController find:]): Deleted.
3201         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
3202         protocol. At first glance, it's pretty broken, but vaguely works.
3203
3204 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3205
3206         Share the implementation of MiniBrowser view hiding functionality
3207         https://bugs.webkit.org/show_bug.cgi?id=166800
3208
3209         Reviewed by Andy Estes.
3210
3211         * MiniBrowser/mac/BrowserWindowController.m:
3212         (-[BrowserWindowController showHideWebView:]):
3213         (-[BrowserWindowController removeReinsertWebView:]):
3214         * MiniBrowser/mac/WK1BrowserWindowController.m:
3215         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
3216         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
3217         * MiniBrowser/mac/WK2BrowserWindowController.m:
3218         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
3219         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
3220         Move the implementation of these two things to the shared superclass,
3221         since they don't depend on WebKit-specific things.
3222         Also, there was no reason to retain the (WK)WebView while it was unparented,
3223         as the BrowserWindowController maintains a reference the entire time.
3224
3225 2017-01-06  Andy Estes  <aestes@apple.com>
3226
3227         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
3228         https://bugs.webkit.org/show_bug.cgi?id=166789
3229
3230         Reviewed by Alex Christensen.
3231
3232         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3233         * DumpRenderTree/PlatformMac.cmake:
3234         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
3235         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
3236         * DumpRenderTree/mac/DumpRenderTree.mm:
3237         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3238         createXMLStringFromWebArchiveData().
3239         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
3240         * WebKitTestRunner/Configurations/Base.xcconfig:
3241         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
3242         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3243         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3244         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3245         createXMLStringFromWebArchiveData().
3246         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
3247         * WebKitTestRunner/PlatformMac.cmake:
3248         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3249         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
3250
3251 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3252
3253         Minor cleanups to IndentOutdentCommand and related code
3254         https://bugs.webkit.org/show_bug.cgi?id=166791
3255
3256         Reviewed by Simon Fraser.
3257
3258         * WebEditingTester/EditingOperations.m:
3259         (editingOperations):
3260         Add the outdent operation to WebEditingTester.
3261
3262 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3263
3264         Create a plan and a patch files for MotionMark and delete the Animometer's ones
3265         https://bugs.webkit.org/show_bug.cgi?id=166785
3266
3267         Reviewed by Ryosuke Niwa.
3268
3269         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3270         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
3271
3272 2017-01-06  Antoine Quint  <graouts@apple.com>
3273
3274         Support webkit-test-runner key-value pairs in http tests
3275         https://bugs.webkit.org/show_bug.cgi?id=149812
3276
3277         Reviewed by Alex Christensen.
3278
3279         We pass the absolute path for a test through to WKTR so that we can parse
3280         tests that are running as URLs for webkit-test-runner options.
3281
3282         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3283         (parseInputLine):
3284
3285         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3286
3287         * Scripts/webkitpy/port/driver.py:
3288         (Driver._command_from_driver_input):
3289
3290         Pass the absolute path to the file through the CLI.
3291
3292         * WebKitTestRunner/TestController.cpp:
3293         (WTR::updateTestOptionsFromTestHeader):
3294         (WTR::TestController::testOptionsForTest):
3295         (WTR::parseInputLine):
3296         (WTR::TestController::runTest):
3297         * WebKitTestRunner/TestController.h:
3298
3299 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3300
3301         Warning about unconnectable outlets when opening a MiniBrowser window
3302         https://bugs.webkit.org/show_bug.cgi?id=166756
3303
3304         Reviewed by Dan Bernstein.
3305
3306         * MiniBrowser/mac/BrowserWindow.xib:
3307         When launching MiniBrowser, it says:
3308         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3309             (MBToolbarItem): missing setter or instance variable
3310         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3311             (NSButtonCell): missing setter or instance variable.
3312
3313         It looks like someone added the connection from the share button
3314         to the BrowserWindowController three times; only one of the connections
3315         is valid. Remove the other two.
3316
3317 2017-01-05  Keith Rollin  <krollin@apple.com>
3318
3319         Add WebCore::URL::protocolHostAndPort
3320         https://bugs.webkit.org/show_bug.cgi?id=166426
3321
3322         Reviewed by Alex Christensen.
3323
3324         Add test for protocolHostAndPort.
3325
3326         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3327         (TestWebKitAPI::TEST_F):
3328
3329 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3330
3331         [Win] Archive test result is failing.
3332         https://bugs.webkit.org/show_bug.cgi?id=166720
3333
3334         Reviewed by Alex Christensen.
3335
3336         Deleting the layout test result folder is sometimes failing
3337         on Windows. This is not a critical error.
3338
3339         * BuildSlaveSupport/test-result-archive:
3340         (archiveTestResults):
3341
3342 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3343
3344         [GTK] Minibrowser: Add printing support
3345         https://bugs.webkit.org/show_bug.cgi?id=165298
3346
3347         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3348         an error during the print, it's printed on the console.
3349
3350         Reviewed by Michael Catanzaro.
3351
3352         * MiniBrowser/gtk/BrowserWindow.c:
3353         (webKitPrintOperationFailedCallback):
3354         (printPage):
3355         (browser_window_init):
3356
3357 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3358
3359         [css-grid] Fix crash clamping grid lines
3360         https://bugs.webkit.org/show_bug.cgi?id=166637
3361
3362         Reviewed by Darin Adler.
3363
3364         Creates new unit test to verify that the maximum tracks limit
3365         is used in GridPosition too.
3366
3367         * TestWebKitAPI/PlatformEfl.cmake:
3368         * TestWebKitAPI/PlatformGTK.cmake:
3369         * TestWebKitAPI/PlatformWin.cmake:
3370         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3371         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3372         (TestWebKitAPI::TEST):
3373
3374 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3375
3376         Move editing history scripts to WebCore PrivateHeaders
3377         https://bugs.webkit.org/show_bug.cgi?id=166709
3378         <rdar://problem/29876612>
3379
3380         Reviewed by Dan Bernstein.
3381
3382         Update references to editing script files in WebCore that were moved.
3383
3384         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3385
3386 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3387
3388         Unreviewed, build fix after r210313 part 2
3389         https://bugs.webkit.org/show_bug.cgi?id=166676
3390
3391         Add 'U' suffix.
3392
3393         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3394         (TestWebKitAPI::TEST):
3395         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3396         (TestWebKitAPI::TEST):
3397
3398 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3399
3400         Limit thread name appropriately
3401         https://bugs.webkit.org/show_bug.cgi?id=166676
3402
3403         Reviewed by Sam Weinig.
3404
3405         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3406         (TestWebKitAPI::TEST):
3407         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3408         (TestWebKitAPI::TEST):
3409
3410 2017-01-04  Andy Estes  <aestes@apple.com>
3411
3412         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3413         https://bugs.webkit.org/show_bug.cgi?id=166696
3414
3415         Reviewed by Tim Horton.
3416
3417         * TestWebKitAPI/PlatformGTK.cmake:
3418         * TestWebKitAPI/PlatformWin.cmake:
3419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3420         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3421         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3422         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3423         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3424         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3425         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3426
3427 2017-01-03  Brian Burg  <bburg@apple.com>
3428
3429         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3430         https://bugs.webkit.org/show_bug.cgi?id=166003
3431         <rdar://problem/28718990>
3432
3433         Reviewed by Joseph Pecoraro.
3434
3435         Teach run-inspector-generator-tests to generate test output using the platform name
3436         derived from the directory that the test is in. For example, tests in the /generic/
3437         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3438
3439         * Scripts/webkitpy/inspector/main.py:
3440         (InspectorGeneratorTests.generate_from_json):
3441         (InspectorGeneratorTests.run_tests):
3442         (InspectorGeneratorTests.main):
3443
3444 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3445
3446         Unreviewed cmake buildfix after r210266.
3447
3448         * DumpRenderTree/PlatformMac.cmake:
3449
3450 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3451
3452         Provide a setting for clients to always prefer low-power WebGL
3453         https://bugs.webkit.org/show_bug.cgi?id=166675
3454         <rdar://problem/29834093>
3455
3456         Reviewed by Dan Bernstein.
3457
3458         * MiniBrowser/mac/Info.plist:
3459         Have MiniBrowser claim to be a modern app that supports
3460         automatic graphics switching. WebKit needs to support automatic
3461         graphics switching, so our test app might as well. Without this
3462         Info.plist parameter, this change has no effect, and bringing up
3463         a WebGL context still brings up the discrete GPU (also true of the
3464         existing web-exposed preferLowPowerToHighPerformance API).
3465
3466 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3467
3468         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3469         https://bugs.webkit.org/show_bug.cgi?id=166645
3470
3471         Reviewed by Carlos Garcia Campos.
3472
3473         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3474         (TestWebKitAPI::TEST):
3475
3476 2017-01-03  Andy Estes  <aestes@apple.com>
3477
3478         Place all the Cocoa WebCore API tests in the same directory
3479         https://bugs.webkit.org/show_bug.cgi?id=166673
3480
3481         Reviewed by Michael Catanzaro.
3482
3483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3484         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3485         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3486         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3487
3488 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3489
3490         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3491         https://bugs.webkit.org/show_bug.cgi?id=166450
3492         <rdar://problem/29447824>
3493
3494         Reviewed by Darin Adler.
3495
3496         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3497         * DumpRenderTree/TestRunner.cpp:
3498         (TestRunner::staticFunctions):
3499         * DumpRenderTree/mac/TestRunnerMac.mm:
3500         (setSpellCheckerLoggingEnabledCallback):
3501         * DumpRenderTree/win/TestRunnerWin.cpp:
3502         (setSpellCheckerLoggingEnabledCallback):
3503         * DumpRenderTree/mac/DumpRenderTree.mm:
3504         (resetWebViewToConsistentStateBeforeTesting):
3505         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3506         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3507         (stringForCorrectionResponse):
3508         (drt_NSSpellChecker_recordResponseToCorrection):
3509         (swizzleNSSpellCheckerMethodsIfNeeded):
3510         (setSpellCheckerLoggingEnabled):
3511         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3512         set to true, logs to stdout (which ends up in the test result) whenever
3513         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3514         is called, and then calls the original method. It is reset to false between tests.
3515
3516 2017-01-03  Sam Weinig  <sam@webkit.org>
3517
3518         Make WTF::Expected support Ref template parameters
3519         https://bugs.webkit.org/show_bug.cgi?id=166662
3520
3521         Reviewed by Alex Christensen.
3522
3523         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3524         (TestWebKitAPI::TEST):
3525         Add tests for using Ref with Expected.
3526
3527 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3528
3529         [GTK] Expose WebKitSecurityOrigin API
3530         https://bugs.webkit.org/show_bug.cgi?id=166632
3531
3532         Reviewed by Carlos Garcia Campos.
3533
3534         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3535         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3536         (testSecurityOriginBasicConstructor):
3537         (testSecurityOriginURIConstructor):
3538         (testSecurityOriginDefaultPort):
3539         (testSecurityOriginFileURI):
3540         (testSecurityOriginDataURI):
3541         (beforeAll):
3542         (afterAll):
3543
3544 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3545
3546         [GTK] HTTP auth layout tests are flaky
3547         https://bugs.webkit.org/show_bug.cgi?id=158919
3548
3549         Reviewed by Michael Catanzaro.
3550
3551         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3552         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3553         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3554         missing valac in the bots.
3555
3556 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3557
3558         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3559         https://bugs.webkit.org/show_bug.cgi?id=165797
3560
3561         Reviewed by Michael Catanzaro.
3562
3563         Move directory ruleset after all exclude rules of Source rulset.
3564
3565         * gtk/manifest.txt.in:
3566
3567 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3568
3569         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3570         https://bugs.webkit.org/show_bug.cgi?id=166636
3571
3572         Reviewed by Darin Adler.
3573
3574         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3575         (TestWebKitAPI::TEST):
3576
3577 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3578
3579         [GTK] WebCore/CSSParser unit test is not being built
3580         https://bugs.webkit.org/show_bug.cgi?id=166492
3581
3582         Reviewed by Michael Catanzaro.
3583
3584         This test was introduced in r175930, but we were not building
3585         it on GTK+ port since r176015.
3586         This patch marks the test to be built again on GTK+.
3587         JFTR, the test is passing right now.
3588
3589         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3590         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3591
3592 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3593
3594         AX: Expose block quote level to iOS API
3595         https://bugs.webkit.org/show_bug.cgi?id=166629
3596         <rdar://problem/29834793>
3597
3598         Reviewed by Darin Adler.
3599
3600         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3601         (AccessibilityUIElement::numberAttributeValue):
3602         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3603         (WTR::AccessibilityUIElement::numberAttributeValue):
3604
3605 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3606
3607         SecurityOrigin::create triplet constructor does not canonicalize port
3608         https://bugs.webkit.org/show_bug.cgi?id=166624
3609
3610         Reviewed by Daniel Bates.
3611
3612         * TestWebKitAPI/PlatformGTK.cmake:
3613         * TestWebKitAPI/PlatformWin.cmake:
3614         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3615         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3616         (TestWebKitAPI::SecurityOriginTest::SetUp):
3617         (TestWebKitAPI::TEST_F):
3618
3619 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3620
3621         [GTK] Improve user agent construction
3622         https://bugs.webkit.org/show_bug.cgi?id=142074
3623
3624         Reviewed by Carlos Garcia Campos.
3625
3626         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3627         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3628         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3629         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3630         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3631         (TestWebKitAPI::TEST):
3632
3633 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3634
3635         [GTK] Improve user agent construction
3636         https://bugs.webkit.org/show_bug.cgi?id=142074
3637
3638         Reviewed by Carlos Garcia Campos.
3639
3640         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3641         (TestWebKitAPI::TEST):
3642
3643 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3644
3645         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3646         https://bugs.webkit.org/show_bug.cgi?id=166472
3647         rdar://problem/29675551
3648
3649         Reviewed by Tim Horton.
3650
3651         These changes are necessary to allow the mouse to leave the WTR window while
3652         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3653         (which DRT does); we'd always go through mouseMoved, which hits an early return
3654         in WebViewImpl::mouseMoved() when the point is outside the view.
3655
3656         * WebKitTestRunner/mac/EventSenderProxy.mm:
3657         (WTR::EventSenderProxy::mouseMoveTo):
3658
3659 2016-12-23  Andy Estes  <aestes@apple.com>
3660
3661         [iOS] Fix some crashing webarchive tests
3662         https://bugs.webkit.org/show_bug.cgi?id=166470
3663
3664         Reviewed by Andreas Kling.
3665
3666         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3667         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3668         so this change uses that on both platforms.
3669
3670         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3671         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3672         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3673         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3674         * WebKitTestRunner/PlatformMac.cmake:
3675         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3676         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3677
3678 2016-12-22  Saam Barati  <sbarati@apple.com>
3679
3680         WebAssembly: Silence the output of the spec-tests
3681         https://bugs.webkit.org/show_bug.cgi?id=166417
3682
3683         Reviewed by Mark Lam.
3684
3685         * Scripts/run-jsc-stress-tests:
3686
3687 2016-12-22  Zhuo Li  <zachli@apple.com>
3688
3689         [Cocoa] SPI for setloadsImagesAutomatically.
3690         https://bugs.webkit.org/show_bug.cgi?id=166401.
3691
3692         Reviewed by Darin Adler.
3693
3694         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3695         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3696         _loadsImagesAutomatically returns YES.
3697
3698 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3699
3700         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3701         https://bugs.webkit.org/show_bug.cgi?id=161328
3702         <rdar://problem/28475977>
3703
3704         Reviewed by Darin Adler.
3705
3706         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3707         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3708         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3709         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3710         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3711         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3712         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3713         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3714         we finish running a test and before we load the next test.
3715
3716         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3717         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3718         previous test started zooming and then finished before zooming completed. Since this happens before the next
3719         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3720
3721         * WebKitTestRunner/ios/TestControllerIOS.mm:
3722         (WTR::TestController::platformResetStateToConsistentValues):
3723
3724 2016-12-22  Jer Noble  <jer.noble@apple.com>
3725
3726         Muted media element playback should not interrupt other audio playback
3727         https://bugs.webkit.org/show_bug.cgi?id=166347
3728
3729         Reviewed by Eric Carlson.
3730
3731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3732         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3733         (TestWebKitAPI::TEST):
3734         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3735
3736 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3737
3738         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3739         https://bugs.webkit.org/show_bug.cgi?id=166346
3740
3741         Reviewed by Carlos Garcia Campos.
3742
3743         Enable WebRTC by default to simplify testing.
3744
3745         * MiniBrowser/gtk/main.c:
3746         (main):
3747
3748 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3749
3750         REGRESSION: API test failure: WKWebView.LocalStorageClear
3751         https://bugs.webkit.org/show_bug.cgi?id=166032
3752         <rdar://problem/29758423>
3753
3754         Reviewed by Simon Fraser.
3755
3756         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3757         to ensure that the view is destroyed before the callback fires.
3758
3759         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3760         (TEST):
3761
3762 2016-12-21  Saam Barati  <sbarati@apple.com>
3763
3764         WebAssembly: Import spec tests
3765         https://bugs.webkit.org/show_bug.cgi?id=166395
3766
3767         Rubber stamped by Keith Miller.
3768
3769         * Scripts/run-jsc-stress-tests:
3770
3771 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3772
3773         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3774         https://bugs.webkit.org/show_bug.cgi?id=166033
3775         <rdar://problem/29758428>
3776
3777         Reviewed by Simon Fraser.
3778
3779         Add an @autoreleasepool around the code that allocates the WKWebView, 
3780         so that it can be destroyed by removing the last reference in _downloadDidStart.
3781
3782         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3783         (TEST):
3784
3785 2016-12-21  Daniel Bates  <dabates@apple.com>
3786
3787         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3788         https://bugs.webkit.org/show_bug.cgi?id=166356
3789
3790         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3791         as a means to allow a test to explicit allow an embedding client to open a new windows
3792         such that the default behavior is for the embedding client to forbid such an action.
3793         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3794         it is currently skipped on WebKit2 because questions were raised in the patch for
3795         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3796         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3797         this test.
3798
3799         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3800         (WTR::TestRunner::setCanOpenWindows):
3801
3802 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3803
3804         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3805         https://bugs.webkit.org/show_bug.cgi?id=166031
3806
3807         Reviewed by Tim Horton.
3808         
3809         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3810         to ensure that the view is destroyed before the callback fires.
3811
3812         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3813
3814 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3815
3816         Throw Exception when test doesn't clean up HID Events properly
3817         https://bugs.webkit.org/show_bug.cgi?id=166271
3818
3819         Reviewed by Simon Fraser.
3820
3821         Add in a check when UIScriptController is deleted to make sure that the HID event
3822         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3823         the program to crash without any good information. Crashes are race-y, and will still
3824         happen with malformed test, but the information will be much more helpful. 
3825
3826         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3827         (WTR::UIScriptController::checkForClean):
3828         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3829         (UIScriptContext::~UIScriptContext):
3830         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3831         (WTR::UIScriptController::checkForClean):
3832         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3833         * WebKitTestRunner/ios/HIDEventGenerator.h:
3834         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3835         (-[HIDEventGenerator checkHIDCallbacksClear]):
3836         * WebKitTestRunner/ios/TestControllerIOS.mm:
3837         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3838         (WTR::UIScriptController::checkForClean):
3839
3840 2016-12-20  Andy Estes  <aestes@apple.com>
3841
3842         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3843         https://bugs.webkit.org/show_bug.cgi?id=165992
3844
3845         Reviewed by Brady Eidson.
3846
3847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3848         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3849         (expectException):
3850         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3851         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3852         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3853         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3854         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3855         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3856         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3857         (TEST):
3858         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3859
3860 2016-12-20  Dean Jackson  <dino@apple.com>
3861
3862         Remove INDIE_UI
3863         https://bugs.webkit.org/show_bug.cgi?id=165881
3864         <rdar://problem/29672532>
3865
3866         Reviewed by Simon Fraser.
3867
3868         The Indie UI work has been discontinued.
3869
3870         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3871
3872 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3873
3874         [ES6] Enable ES6 Modules
3875         https://bugs.webkit.org/show_bug.cgi?id=165849
3876
3877         Reviewed by Geoffrey Garen.
3878
3879         * DumpRenderTree/mac/DumpRenderTree.mm:
3880         (resetWebPreferencesToConsistentValues):
3881         * DumpRenderTree/win/DumpRenderTree.cpp:
3882         (resetWebPreferencesToConsistentValues):
3883         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3884         (WTR::InjectedBundle::beginTesting):
3885         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3886         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3887         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3888
3889 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3890
3891         Repurpose bots and clean up dashboard.
3892         https://bugs.webkit.org/show_bug.cgi?id=166045
3893
3894         Reviewed by Lucas Forschler.
3895
3896         * BuildSlaveSupport/build.webkit.org-config/config.json:
3897         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3898         (BubbleQueueServer):
3899         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3900         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3901         (WebKitBuildbot):
3902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3903         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3904
3905 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3906
3907         [CMake] TestWebKitAPIBase links to itself
3908         https://bugs.webkit.org/show_bug.cgi?id=165985
3909
3910         Reviewed by Alex Christensen.
3911
3912         Fix CMake warning about a target linking to itself, which makes no sense.
3913
3914         * TestWebKitAPI/CMakeLists.txt:
3915
3916 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3917
3918         [GTK] GtkDoc build should be quieter
3919         https://bugs.webkit.org/show_bug.cgi?id=165994
3920
3921         Reviewed by Carlos Garcia Campos.
3922
3923         Make it not print by default.
3924
3925         * gtk/generate-gtkdoc:
3926         (get_generator_for_config):
3927         (generate_doc):
3928         * gtk/gtkdoc.py:
3929         (GTKDoc._run_command):
3930         (GTKDoc._copy_doc_files_to_output_dir):
3931
3932 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3933
3934         Expose a way for MiniBrowser to simulate header and footer banners
3935         https://bugs.webkit.org/show_bug.cgi?id=166005
3936
3937         Reviewed by Wenson Hsieh.
3938         
3939         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3940         banners. This only works in WebKit2.
3941         
3942         We need to reset these on each navigation, since newly created FrameViews
3943         don't re-fetch the header and footer height stored on Page.
3944         
3945         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3946         as well as fixing webViewWebContentProcessDidTerminate:
3947
3948         * MiniBrowser/mac/SettingsController.h:
3949         * MiniBrowser/mac/SettingsController.m:
3950         (-[SettingsController _populateMenu]):
3951         (-[SettingsController validateMenuItem:]):
3952         (-[SettingsController toggleReserveSpaceForBanners:]):
3953         (-[SettingsController isSpaceReservedForBanners]):
3954         * MiniBrowser/mac/WK2BrowserWindowController.m:
3955         (-[WK2BrowserWindowController didChangeSettings]):
3956         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3957         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3958         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3959         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3960
3961 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3962
3963         Fix iOS test results after r209967.
3964         
3965         Subtracting out the status bar height was erroneously happening for all tests,
3966         not just for flexible viewport tests.
3967         
3968         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3969
3970         * WebKitTestRunner/PlatformWebView.h:
3971         * WebKitTestRunner/TestController.cpp:
3972         (WTR::TestController::resetStateToConsistentValues):
3973         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3974         (WTR::PlatformWebView::resizeTo):
3975         (WTR::PlatformWebView::setWindowFrame):
3976         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3977         (WTR::PlatformWebView::resizeTo):
3978         (WTR::PlatformWebView::setWindowFrame):
3979         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3980         (WTR::PlatformWebView::resizeTo):
3981         (WTR::PlatformWebView::setWindowFrame):
3982         * WebKitTestRunner/ios/TestControllerIOS.mm:
3983         (WTR::TestController::platformConfigureViewForTest):
3984         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3985         (WTR::PlatformWebView::resizeTo):
3986         (WTR::PlatformWebView::setWindowFrame):
3987
3988 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3989
3990         [EFL] bump EFL version to 1.18.4
3991         https://bugs.webkit.org/show_bug.cgi?id=166004
3992
3993         Reviewed by Gyuyoung Kim.
3994
3995         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3996
3997 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3998
3999         Visual viewports: bottom fixed elements disappear behind the keyboard
4000         https://bugs.webkit.org/show_bug.cgi?id=165983
4001         <rdar://problem/29409852>
4002
4003         Reviewed by Simon Fraser.
4004
4005         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
4006         the keyboard when it is up.
4007
4008         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4009         (WTR::UIScriptController::inputViewBounds):
4010         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4011         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4012         (WTR::UIScriptController::inputViewBounds):
4013         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4014         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4015         (WTR::viewRectForWindowRect):
4016
4017         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
4018         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
4019         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
4020
4021         (WTR::PlatformWebView::PlatformWebView):
4022         (WTR::PlatformWebView::setWindowFrame):
4023         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4024         (WTR::UIScriptController::inputViewBounds):
4025
4026 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
4027
4028         Deleting a character converted from pinyin after an image causes a Safari crash
4029         https://bugs.webkit.org/show_bug.cgi?id=165839
4030         <rdar://problem/27951933>
4031
4032         Reviewed by Wenson Hsieh.
4033
4034         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
4035         while the proposed range contains an image. This should not cause a WebProcess to crash
4036         or send an invalid message to the UIProcess.
4037
4038         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4039         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
4040         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
4041         (TestWebKitAPI::didFinishLoadForFrame):
4042         (TestWebKitAPI::processDidCrash):
4043         (TestWebKitAPI::invalidMessageFunction):
4044         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
4045
4046 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
4047
4048         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
4049         https://bugs.webkit.org/show_bug.cgi?id=165767
4050         <rdar://problem/29602382>
4051
4052         Reviewed by Simon Fraser.
4053
4054         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
4055         WebKit2 ChangeLog for more details.
4056
4057         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4058         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4059         (WTR::UIScriptController::textSelectionCaretRect):
4060         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4061         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4062         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4063         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4064         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4065         (WTR::UIScriptController::textSelectionCaretRect):
4066         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4067         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4068         (-[TestRunnerWKWebView _setStableStateOverride:]):
4069
4070         Force the WKWebView to update its visible content rects when changing the stable state override.
4071
4072         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4073         (WTR::toNSDictionary):
4074         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4075         (WTR::UIScriptController::selectionRangeViewRects):
4076         (WTR::UIScriptController::textSelectionCaretRect):
4077         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4078         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
4079
4080 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
4081
4082         Arguments called in wrong order
4083         https://bugs.webkit.org/show_bug.cgi?id=165923
4084
4085         Reviewed by Simon Fraser.
4086
4087         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
4088         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
4089
4090         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
4091         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
4092         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
4093
4094 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
4095
4096         [EFL] Disable non-srcdir builds for failing libraries
4097         https://bugs.webkit.org/show_bug.cgi?id=165896
4098
4099         Reviewed by Gyuyoung Kim.
4100
4101         * efl/jhbuild.modules: Set non srcdir builds to no
4102
4103 2016-12-15  Daniel Bates  <dabates@apple.com>
4104
4105         check-style should not complain about code in icu directories
4106         https://bugs.webkit.org/show_bug.cgi?id=53929
4107
4108         Reviewed by Darin Adler.
4109
4110         Skip style checking of imported ICU headers to avoid a deluge of style issues
4111         as they do not conform to the WebKit Code Style guideline. We want to preserve
4112         the formatting of these headers so as to make it straightforward to merge
4113         changes to them, if necessary.
4114
4115         * Scripts/webkitpy/style/checker.py:
4116
4117 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
4118
4119         Move JSC testers from Yosemite to Sierra
4120         https://bugs.webkit.org/show_bug.cgi?id=165925
4121
4122         Reviewed by Lucas Forschler.
4123
4124         * BuildSlaveSupport/build.webkit.org-config/config.json:
4125         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4126         (WebKitBuildbot):
4127
4128 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
4129
4130         Add coordinate space to event streams and streamline tests
4131         https://bugs.webkit.org/show_bug.cgi?id=165119
4132
4133         Reviewed by Simon Fraser.
4134
4135         Update event streams to allow for both content and global coordinate space.
4136         Update example script to more accurately show all the available options.
4137
4138         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4139         * WebKitTestRunner/ios/HIDEventGenerator.h:
4140         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4141         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4142         (WTR::convertCoordinates):
4143         (WTR::UIScriptController::sendEventStream):
4144
4145 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
4146
4147         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
4148         https://bugs.webkit.org/show_bug.cgi?id=165855
4149
4150         Reviewed by Philippe Normand.
4151
4152         GStreamer's autogen.sh enables gtk-doc always so we end up building
4153         docs even if we disable them. Use the configure script instead, since
4154         we build from packages and these include it already.
4155
4156         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
4157         upstream gstreamer packages.
4158
4159 2016-12-15  Alex Christensen  <achristensen@webkit.org>
4160
4161         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
4162         https://bugs.webkit.org/show_bug.cgi?id=165885
4163         <rdar://problem/29476917>
4164
4165         Reviewed by Darin Adler.
4166
4167         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4168         (TestWebKitAPI::utf16String): Deleted.
4169         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
4170         (TestWebKitAPI::TEST_F):
4171         * TestWebKitAPI/WTFStringUtilities.h:
4172         (utf16String):
4173         Moved from URLParser to share with other tests.
4174
4175 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
4176
4177         iOS: An element with tabindex is not focusable unless there is no mouse event handler
4178         https://bugs.webkit.org/show_bug.cgi?id=165843
4179
4180         Reviewed by Antti Koivisto.
4181
4182         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
4183         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
4184         and DumpRenderTree's runUIScript would hit an assertion :(
4185
4186         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4187         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4188         (WTR::TestRunner::isWebKit2):
4189
4190 2016-12-14  Brady Eidson  <beidson@apple.com>
4191
4192         IndexedDB 2.0: Massively speedup IDBIndex.get().
4193         https://bugs.webkit.org/show_bug.cgi?id=165802
4194
4195         Reviewed by Alex Christensen.
4196
4197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4198         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
4199         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
4200         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
4201         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
4202
4203 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4204
4205         [GTK][EFL] Update the JHBuild version.
4206         https://bugs.webkit.org/show_bug.cgi?id=165838
4207
4208         Reviewed by Michael Catanzaro.
4209
4210         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
4211         usage of the JHBUILD_MIRROR feature with git repositories.
4212
4213 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4214
4215         [GTK] Yasm is needed for building the JHBuild after r208940
4216         https://bugs.webkit.org/show_bug.cgi?id=165837
4217
4218         Reviewed by Alejandro G. Castro.
4219
4220         * gtk/install-dependencies: Yasm is needed for building libvpx.
4221
4222 2016-12-14  Youenn Fablet  <youenn@apple.com>
4223
4224         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
4225         https://bugs.webkit.org/show_bug.cgi?id=161310
4226
4227         Reviewed by Ryosuke Niwa.
4228
4229         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
4230         When set, WTR and DRT output JS console log in the stderr and not the test output.
4231         This allows removing potentially flaky information while still being able to read it for investigation.
4232
4233         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
4234
4235         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
4236         This test should have this option when fetch API will start logging resource loader errors.
4237
4238         * DumpRenderTree/DumpRenderTree.h:
4239         (TestCommand::TestCommand): Deleted.
4240         * DumpRenderTree/DumpRenderTreeCommon.cpp:
4241         (parseInputLine):
4242         * DumpRenderTree/TestRunner.h:
4243         (TestRunner::setDumpJSConsoleLogInStdErr):
4244         (TestRunner::dumpJSConsoleLogInStdErr):
4245         * DumpRenderTree/mac/DumpRenderTree.mm:
4246         (runTest):
4247         * DumpRenderTree/mac/UIDelegate.mm:
4248         (-[UIDelegate webView:addMessageToConsole:withSource:]):
4249         * DumpRenderTree/win/DumpRenderTree.cpp:
4250         (runTest):
4251         * DumpRenderTree/win/UIDelegate.cpp:
4252         (UIDelegate::webViewAddMessageToConsole):
4253         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4254         (TestExpectationParser._tokenize_line):
4255         * Scripts/webkitpy/port/driver.py:
4256         (Driver._command_from_driver_input):
4257         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4258         (WTR::InjectedBundle::didReceiveMessageToPage):
4259         (WTR::InjectedBundle::dumpToStdErr):
4260         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4261         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
4262         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4263         (WTR::InjectedBundlePage::willAddMessageToConsole):
4264         * WebKitTestRunner/TestController.cpp:
4265         (WTR::parseInputLine):
4266         (WTR::TestController::runTest):
4267         (WTR::TestCommand::TestCommand): Deleted.
4268         * WebKitTestRunner/TestInvocation.cpp:
4269         (WTR::TestInvocation::invoke):
4270         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4271         * WebKitTestRunner/TestInvocation.h:
4272         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
4273
4274
4275 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
4276
4277         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
4278         https://bugs.webkit.org/show_bug.cgi?id=164022
4279
4280         Reviewed by Xabier Rodriguez-Calvar.
4281
4282         * Scripts/webkitperl/FeatureList.pm:
4283           Re-enable MEDIA_SOURCE for the GTK+ port.
4284
4285 2016-12-13  Alex Christensen  <achristensen@webkit.org>
4286
4287         Fix CMake build.
4288
4289         * DumpRenderTree/PlatformMac.cmake:
4290         Define NS_RETURNS_RETAINED as nothing for now.
4291
4292 2016-12-13  Jer Noble  <jer.noble@apple.com>
4293
4294         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
4295         https://bugs.webkit.org/show_bug.cgi?id=165697
4296
4297         Reviewed by Tim Horton.
4298
4299         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
4300         (TestWebKitAPI::TEST):
4301
4302 2016-12-13  Andy Estes  <aestes@apple.com>
4303
4304         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
4305         https://bugs.webkit.org/show_bug.cgi?id=165785
4306         <rdar://problem/26929398>
4307
4308         Reviewed by Darin Adler.
4309
4310         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: