[LFC][BFC] Do not ignore next sibling box while laying out BFC.
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2
3         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
4         https://bugs.webkit.org/show_bug.cgi?id=193954
5
6         Reviewed by Antti Koivisto.
7
8         * LayoutReloaded/misc/LFC-passing-tests.txt:
9
10 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
11
12         WebDriver: add support for running subtests
13         https://bugs.webkit.org/show_bug.cgi?id=193904
14
15         Reviewed by Michael Catanzaro.
16
17         pytest already supports it by passing test.py::subtest, so we can do the same.
18
19         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
20         (get_item_name): Made this global.
21         (CollectRecorder.__init__): Receive the parameter to ignore.
22         (CollectRecorder.pytest_collectreport): Collect also the subtests.
23         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
24         (collect): Add parameter to ignore.
25         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
26         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
27         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
28         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
29         (WebDriverTestRunnerSelenium.run): Ditto.
30         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
31         (WebDriverTestRunnerW3C.collect_tests): Ditto.
32         (WebDriverTestRunnerW3C.run): Ditto.
33
34 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
35
36         User agent string override for navigator.userAgent should be site specific quirks
37         https://bugs.webkit.org/show_bug.cgi?id=193950
38
39         Reviewed by Brent Fulgham.
40
41         Updated per the _WKWebsitePolicies rename.
42
43         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
44         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
45
46 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
47
48         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
49         https://bugs.webkit.org/show_bug.cgi?id=193941
50
51         Reviewed by Alex Christensen.
52
53         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
54         * TestWebKitAPI/Tests/WTF/Condition.cpp:
55         * TestWebKitAPI/Tests/WTF/Lock.cpp:
56         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
57         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
58         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
59         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
60         * TestWebKitAPI/Tests/WTF/Time.cpp:
61         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
62         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
63         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
64         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
65
66 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
67
68         Unreviewed, reorder my emails to fix autocomplete in bugzilla
69
70         * Scripts/webkitpy/common/config/contributors.json:
71
72 2019-01-28  Andy Estes  <aestes@apple.com>
73
74         [watchOS] Enable Parental Controls content filtering
75         https://bugs.webkit.org/show_bug.cgi?id=193939
76         <rdar://problem/46641912>
77
78         Reviewed by Ryosuke Niwa.
79
80         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
81
82 2019-01-28  David Kilzer  <ddkilzer@apple.com>
83
84         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
85         <https://webkit.org/b/193884>
86
87         Reviewed by Jiewen Tan.
88
89         * Scripts/webkitpy/style/checkers/cpp.py:
90         (check_language): Add LocalAuthentication to
91         `frameworks_with_soft_links`.
92
93 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
94
95         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
96         https://bugs.webkit.org/show_bug.cgi?id=193891
97
98         Reviewed by Ross Kirsling.
99
100         There were three problems in window sizes of WebView and the host window.
101         1. The sizes of pixel image output were incorrect.
102         2. The host window is going to appear after window.resize was invoked.
103         3. window.resize resized only the host window, not WebView.
104
105         This change solves them with a following approach.
106         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
107         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
108            as well as DumpRenderTree in order to match the client area and the window area.
109         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
110         d. PlatformWebView::setWindowFrame changes both window sizes.
111         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
112
113         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
114         (WTR::PlatformWebView::PlatformWebView): Create the host window
115         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
116         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
117         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
118
119 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
120
121         [ews-app] Add method to save Step data to database
122         https://bugs.webkit.org/show_bug.cgi?id=193890
123
124         Reviewed by Lucas Forschler.
125
126         * BuildSlaveSupport/ews-app/ews/models/step.py:
127         (Step.save_step): Method to save step data.
128         (Step.update_step): Method to update step data.
129         (Step.get_existing_step): Method to fetch existing step from database.
130         (Step.is_valid_result): Method to validate valid step result.
131
132 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
133
134         [ews-app] Add method to save Build data to database
135         https://bugs.webkit.org/show_bug.cgi?id=193735
136
137         Reviewed by Lucas Forschler.
138
139         * BuildSlaveSupport/ews-app/ews/models/build.py:
140         (Build.save_build): Method to save build information to database.
141         (Build.get_existing_build): Method to fetch existing build from database.
142         (Build.is_valid_result): Method to validate build result.
143         * BuildSlaveSupport/ews-app/ews/common/util.py:
144         (is_valid_int_id): Method to validate valid id.
145
146 2019-01-28  Chris Dumez  <cdumez@apple.com>
147
148         Regression(PSON) Crash under WebPageProxy::didStartProgress()
149         https://bugs.webkit.org/show_bug.cgi?id=193915
150         <rdar://problem/47560907>
151
152         Reviewed by Alex Christensen.
153
154         Add API test coverage.
155
156         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
157
158 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
159
160         [ews-app] Rename id variables
161         https://bugs.webkit.org/show_bug.cgi?id=193883
162
163         Reviewed by Lucas Forschler.
164
165         * BuildSlaveSupport/ews-app/ews/models/build.py:
166         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
167         * BuildSlaveSupport/ews-app/ews/models/step.py:
168         * BuildSlaveSupport/ews-app/ews/urls.py:
169         * BuildSlaveSupport/ews-app/ews/views/patch.py:
170         * BuildSlaveSupport/ews-app/ews/views/results.py:
171         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
172
173 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
174
175         [ews-app] Allow certain fields to be empty
176         https://bugs.webkit.org/show_bug.cgi?id=193892
177
178         Reviewed by Lucas Forschler.
179
180         * BuildSlaveSupport/ews-app/ews/models/build.py:
181         * BuildSlaveSupport/ews-app/ews/models/step.py:
182
183 2019-01-28  Rob Buis  <rbuis@igalia.com>
184
185         Update MIME type parser
186         https://bugs.webkit.org/show_bug.cgi?id=180526
187
188         Reviewed by Frédéric Wang.
189
190         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
191         (TestWebKitAPI::TEST):
192
193 2019-01-28  Zalan Bujtas  <zalan@apple.com>
194
195         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
196         https://bugs.webkit.org/show_bug.cgi?id=193896
197
198         Reviewed by Antti Koivisto.
199
200         * LayoutReloaded/misc/LFC-passing-tests.txt:
201
202 2018-12-15  Darin Adler  <darin@apple.com>
203
204         Replace many uses of String::format with more type-safe alternatives
205         https://bugs.webkit.org/show_bug.cgi?id=192742
206
207         Reviewed by Mark Lam.
208
209         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
210         (WTR::cacheTestRunnerCallback): Use makeString.
211         * WebKitTestRunner/TestController.cpp:
212         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
213         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
214
215 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
216
217         Use a load optimizer for some sites
218         https://bugs.webkit.org/show_bug.cgi?id=193881
219         <rdar://problem/46325455>
220
221         Reviewed by Brent Fulgham.
222
223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
224         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
225
226 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
227
228         AX: Introduce a static accessibility tree
229         https://bugs.webkit.org/show_bug.cgi?id=193348
230         <rdar://problem/47203295>
231
232         Reviewed by Ryosuke Niwa.
233
234         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
235
236 2019-01-26  Zalan Bujtas  <zalan@apple.com>
237
238         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
239         https://bugs.webkit.org/show_bug.cgi?id=193867
240
241         Reviewed by Antti Koivisto.
242
243         * LayoutReloaded/misc/LFC-passing-tests.txt:
244
245 2019-01-26  Zalan Bujtas  <zalan@apple.com>
246
247         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
248         https://bugs.webkit.org/show_bug.cgi?id=193865
249
250         Reviewed by Antti Koivisto.
251
252         * LayoutReloaded/misc/LFC-passing-tests.txt:
253
254 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
255
256         Need a mechanism to override navigator.userAgent
257         https://bugs.webkit.org/show_bug.cgi?id=193762
258         <rdar://problem/47504939>
259
260         Reviewed by Brent Fulgham.
261
262         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
263
264         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
265         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
266         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
267
268 2019-01-25  Dean Jackson  <dino@apple.com>
269
270         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
271         https://bugs.webkit.org/show_bug.cgi?id=193831
272         <rdar://problem/47399263>
273
274         Reviewed by Chris Dumez.
275
276         Two new tests that exercise cross-origin and same-origin System
277         Previews.
278
279         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
280
281 2019-01-25  Keith Rollin  <krollin@apple.com>
282
283         Update Xcode projects with "Check .xcfilelists" build phase
284         https://bugs.webkit.org/show_bug.cgi?id=193790
285         <rdar://problem/47201374>
286
287         Reviewed by Alex Christensen.
288
289         Support for XCBuild includes specifying inputs and outputs to various
290         Run Script build phases. These inputs and outputs are specified as
291         .xcfilelist files. Once created, these .xcfilelist files need to be
292         kept up-to-date. In order to check that they are up-to-date or not,
293         add an Xcode build step that invokes an external script that performs
294         the checking. If the .xcfilelists are found to be out-of-date, update
295         them, halt the build, and instruct the developer to restart the build
296         with up-to-date files.
297
298         At this time, the checking and regenerating is performed only if the
299         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
300         who want to use this facility can set this variable and test out the
301         checking/regenerating. Once it seems like there are no egregious
302         issues that upset a developer's workflow, we'll unconditionally enable
303         this facility.
304
305         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
306         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
307         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
308         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
309
310 2019-01-25  Keith Rollin  <krollin@apple.com>
311
312         Update Xcode projects with "Apply Configuration to XCFileLists" build target
313         https://bugs.webkit.org/show_bug.cgi?id=193781
314         <rdar://problem/47201153>
315
316         Reviewed by Alex Christensen.
317
318         Part of generating the .xcfilelists used as part of adopting XCBuild
319         includes running `make DerivedSources.make` from a standalone script.
320         It’s important for this invocation to have the same environment as
321         when the actual build invokes `make DerivedSources.make`. If the
322         environments are different, then the two invocations will provide
323         different results. In order to get the same environment in the
324         standalone script, have the script launch xcodebuild targeting the
325         "Apply Configuration to XCFileLists" build target, which will then
326         re-invoke our standalone script. The script is now running again, this
327         time in an environment with all workspace, project, target, xcconfig
328         and other environment variables established.
329
330         The "Apply Configuration to XCFileLists" build target accomplishes
331         this task via a small embedded shell script that consists only of:
332
333             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
334
335         The process that invokes "Apply Configuration to XCFileLists" first
336         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
337         evaluated and exports it into the shell environment. When xcodebuild
338         is invoked, it inherits the value of this variable and can `eval` the
339         contents of that variable. Our external standalone script can then set
340         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
341         of command-line parameters needed to restart itself in the appropriate
342         state.
343
344         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
345         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
346
347 2019-01-25  Alex Christensen  <achristensen@webkit.org>
348
349         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
350         https://bugs.webkit.org/show_bug.cgi?id=193802
351         <rdar://problem/46010580>
352
353         Reviewed by Andy Estes.
354
355         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
356         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
357         (TEST):
358
359 2019-01-25  Daniel Bates  <dabates@apple.com>
360
361         [iOS] uiController.keyDown() does not translate Control modified key
362         https://bugs.webkit.org/show_bug.cgi?id=192898
363
364         Reviewed by Wenson Hsieh.
365
366         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
367         key translation, as applicable. Among other cases, key translation occurs when performing
368         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
369         also makes the behavior of uiController.keyDown() more closely match the behavior of a
370         human pressing down and releasing key(s) using a hardware keyboard.
371
372         * WebKitTestRunner/ios/HIDEventGenerator.h:
373         * WebKitTestRunner/ios/HIDEventGenerator.mm:
374         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
375
376         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
377         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
378         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
379         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
380         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
381         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
382         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
383         (-[HIDEventGenerator longPress:completionBlock:]):
384         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
385         Update code for above renaming.
386
387         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
388         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
389
390         (-[HIDEventGenerator keyDown:]): Added.
391         (-[HIDEventGenerator keyUp:]): Added.
392         (-[HIDEventGenerator keyPress:completionBlock:]):
393         (-[HIDEventGenerator eventDispatchThreadEntry:]):
394         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
395         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
396         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
397         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
398         (WTR::parseModifier): Deleted.
399
400 2019-01-25  Keith Rollin  <krollin@apple.com>
401
402         Complete the implementation of generate-xcfilelists
403         https://bugs.webkit.org/show_bug.cgi?id=193782
404
405         Reviewed by Alex Christensen.
406
407         A preliminary version of generate-xcfilelists was added in r238008.
408         This patch updates that script in order to:
409
410         - Support checking of .xcfilelists
411         - Perform better execution of `make DerivedSources.make` by
412           relaunching generate-xcfilelists under xcodebuild
413         - Support incremental generation and checking of .xcfilelists
414         - Support supplementary .xcfilelists files from WebKitAdditions
415         - Support being wrapped by parallel version of generate-xcfilelists in
416           Internal that adds support for (re)generating WebKit projects in
417           that repo.
418         - Support builds that have been performed in WebKitBuild as well as
419           ~/Library/Developer/code/DerivedData
420         - Increase robustness and debugging facilities.
421
422         * Scripts/generate-xcfilelists:
423
424 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
425
426         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
427         https://bugs.webkit.org/show_bug.cgi?id=193297
428         <rdar://problem/47158841>
429
430         Unreviewed test case fix.
431
432         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
433         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
434
435         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
436         (TEST):
437
438 2019-01-25  Keith Rollin  <krollin@apple.com>
439
440         Update existing .xcfilelists
441         https://bugs.webkit.org/show_bug.cgi?id=193791
442         <rdar://problem/47201706>
443
444         Reviewed by Alex Christensen.
445
446         Many .xcfilelist files were added in r238824 in order to support
447         XCBuild. Update these with recent changes to the set of build files
448         and with the current generate-xcfilelist script.
449
450         * DumpRenderTree/DerivedSources-input.xcfilelist:
451         * DumpRenderTree/DerivedSources-output.xcfilelist:
452         * WebKitTestRunner/DerivedSources-input.xcfilelist:
453         * WebKitTestRunner/DerivedSources-output.xcfilelist:
454
455 2019-01-25  Keith Rollin  <krollin@apple.com>
456
457         Fix missing dependencies in extract-dependencies-from-makefile
458         https://bugs.webkit.org/show_bug.cgi?id=193783
459         <rdar://problem/47201571>
460
461         Reviewed by Alex Christensen.
462
463         The extract-dependencies-from-makefile script generates .xcfilelists
464         for XCBuild by invoking a makefile in --debug mode, parsing the
465         dependency information in the output, and extracting information
466         regarding targets and dependents. However, the way `make` emits this
467         dependency information is not rigorous, and so we need to determine
468         what lines to look for and parse by trial and error. This approach
469         didn't coriginally atch all the information we needed to collect, so
470         update the script to look for the additional lines we now know to look
471         for.
472
473         * Scripts/extract-dependencies-from-makefile:
474         (Parser):
475         (Parser.addTarget):
476         (Parser.addPrereq):
477         (Parser.doParse):
478
479 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
480
481         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
482         https://bugs.webkit.org/show_bug.cgi?id=193297
483         <rdar://problem/47158841>
484
485         Reviewed by Alex Christensen.
486
487         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
488             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
489         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
490         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
491         activating the message used to trigger the callback when it is set.
492
493 2019-01-25  Alex Christensen  <achristensen@webkit.org>
494
495         WKWebView.goBack should reload if there is a safe browsing warning
496         https://bugs.webkit.org/show_bug.cgi?id=193805
497         <rdar://problem/46908216>
498
499         Reviewed by Geoff Garen.
500
501         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
502         (+[Simple3LookupContext sharedLookupContext]):
503         (-[Simple3LookupContext lookUpURL:completionHandler:]):
504         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
505         (TEST):
506
507 2019-01-25  Chris Dumez  <cdumez@apple.com>
508
509         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
510         https://bugs.webkit.org/show_bug.cgi?id=193788
511         <rdar://problem/47531231>
512
513         Reviewed by Alex Christensen.
514
515         Add API test coverage.
516
517         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
518         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
519
520 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
521
522         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
523         https://bugs.webkit.org/show_bug.cgi?id=193771
524
525         Unreviewed infrastructure fix.
526
527         * Scripts/webkitpy/port/darwin.py:
528         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
529
530 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
531
532         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
533
534 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
535
536         Add contributors.json entries for Ling Ho and for a new bot watchers group.
537
538         * Scripts/webkitpy/common/config/contributors.json:
539
540 2019-01-25  Chris Dumez  <cdumez@apple.com>
541
542         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
543         https://bugs.webkit.org/show_bug.cgi?id=193779
544         <rdar://problem/46170903>
545
546         Reviewed by Antti Koivisto.
547
548         Add API test that quickly navigates forward to a previous process without waiting for it to
549         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
550         the process' previous page when reconnecting the it for the forward navigation.
551
552         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
553
554 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
555
556         Need a way for JavaScript (or bundle) code to participate in undo
557         https://bugs.webkit.org/show_bug.cgi?id=190009
558         <rdar://problem/44807048>
559
560         Reviewed by Ryosuke Niwa.
561
562         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
563         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
564
565         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
566         (WTR::UIScriptController::lastUndoLabel const):
567         (WTR::UIScriptController::firstRedoLabel const):
568         (WTR::UIScriptController::platformUndoManager const):
569         * DumpRenderTree/mac/UIScriptControllerMac.mm:
570         (WTR::UIScriptController::lastUndoLabel const):
571         (WTR::UIScriptController::firstRedoLabel const):
572         (WTR::UIScriptController::platformUndoManager const):
573         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
574         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
575         (WTR::UIScriptController::lastUndoLabel const):
576         (WTR::UIScriptController::firstRedoLabel const):
577         * TestRunnerShared/UIScriptContext/UIScriptController.h:
578         * WebKitTestRunner/UIScriptControllerCocoa.mm:
579         (WTR::UIScriptController::lastUndoLabel const):
580         (WTR::UIScriptController::firstRedoLabel const):
581         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
582         (WTR::UIScriptController::platformUndoManager const):
583         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
584         (WTR::UIScriptController::platformUndoManager const):
585
586 2019-01-25  Zalan Bujtas  <zalan@apple.com>
587
588         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
589         https://bugs.webkit.org/show_bug.cgi?id=193824
590
591         Reviewed by Antti Koivisto.
592
593         * LayoutReloaded/misc/LFC-passing-tests.txt:
594
595 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
596
597         Update macOS JSC bot configurations
598         https://bugs.webkit.org/show_bug.cgi?id=193739
599
600         Reviewed by Alexey Proskuryakov.
601
602         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
604         (BubbleQueueServer): Move JSC EWS to Mojave section.
605         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
606         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
607         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
608
609 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
610
611         [Win][WebKitTestRunner] Implement EventSenderProxy
612         https://bugs.webkit.org/show_bug.cgi?id=193755
613
614         Reviewed by Don Olmstead.
615
616         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
617         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
618         (WTR::EventSenderProxy::dispatchMessage):
619         (WTR::EventSenderProxy::EventSenderProxy):
620         (WTR::EventSenderProxy::mouseDown):
621         (WTR::EventSenderProxy::mouseUp):
622         (WTR::EventSenderProxy::mouseMoveTo):
623         (WTR::EventSenderProxy::mouseScrollBy):
624         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
625
626 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
627
628         Unreviewed fix for API test failure after r240437.
629
630         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
631
632         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
633
634 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
635
636         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
637         https://bugs.webkit.org/show_bug.cgi?id=193787
638         <rdar://problem/47497634>
639
640         Reviewed by Alexey Proskuryakov.
641
642         * Scripts/webkitdirs.pm:
643         (iosSimulatorApplicationsPath): Pick from available runtime directories.
644
645 2019-01-24  Truitt Savell  <tsavell@apple.com>
646
647         Unreviewed, rolling out r240446.
648
649         Casued 5 API failures
650
651         Reverted changeset:
652
653         "Activate the WebResourceLoadStatisticsStore in the
654         NetworkProcess and deactivate it in the UIProcess."
655         https://bugs.webkit.org/show_bug.cgi?id=193297
656         https://trac.webkit.org/changeset/240446
657
658 2019-01-24  Zalan Bujtas  <zalan@apple.com>
659
660         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
661         https://bugs.webkit.org/show_bug.cgi?id=193741
662         <rdar://problem/47135030>
663
664         Reviewed by Antti Koivisto and Simon Fraser.
665
666         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
667         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
668         (TestWebKitAPI::TEST):
669
670 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
671
672         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
673         https://bugs.webkit.org/show_bug.cgi?id=193297
674         <rdar://problem/47158841>
675
676         Reviewed by Alex Christensen.
677
678         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
679         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
680         activating the message used to trigger the callback when it is set.
681
682 2019-01-24  John Wilander  <wilander@apple.com>
683
684         Add Ad Click Attribution as an internal/experimental feature
685         https://bugs.webkit.org/show_bug.cgi?id=193685
686         <rdar://problem/47450399>
687
688         Reviewed by Brent Fulgham.
689
690         Added test option adClickAttributionEnabled.
691
692         * DumpRenderTree/TestOptions.cpp:
693         (TestOptions::TestOptions):
694         * DumpRenderTree/TestOptions.h:
695         * DumpRenderTree/mac/DumpRenderTree.mm:
696         (setWebPreferencesForTestOptions):
697
698 2019-01-24  Antti Koivisto  <antti@apple.com>
699
700         [PSON] Flash on back navigation on Mac
701         https://bugs.webkit.org/show_bug.cgi?id=193716
702         <rdar://problem/47148458>
703
704         Reviewed by Chris Dumez.
705
706         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
707
708         Closing of the previous page is delayed so waiting for didFinishNavigation is
709         not sufficient to guarantee we have received all the messages. Wait for them.
710
711 2019-01-24  Chris Dumez  <cdumez@apple.com>
712
713         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
714         https://bugs.webkit.org/show_bug.cgi?id=193761
715         <rdar://problem/47456405>
716
717         Reviewed by Alex Christensen.
718
719         Add API test coverage.
720
721         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
722
723 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
724
725         webkitpy: Missing PID in crashlog name should not be fatal
726         https://bugs.webkit.org/show_bug.cgi?id=193771
727
728         If we can't determine the PID of a crashlog, just ignore the crashlog instead
729         of raising an exception.
730
731         Reviewed by Lucas Forschler.
732
733         * Scripts/webkitpy/port/darwin.py:
734         (DarwinPort._merge_crash_logs):
735
736 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
737
738         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
739         https://bugs.webkit.org/show_bug.cgi?id=193746
740
741         Reviewed by Youenn Fablet.
742
743         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
744         so we'd best just not call it.
745
746         * Scripts/webkitpy/w3c/test_exporter.py:
747         (WebPlatformTestExporter.create_branch_with_patch):
748
749 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
750
751         Move FileSystem to WTF
752         https://bugs.webkit.org/show_bug.cgi?id=193602
753
754         Reviewed by Yusuke Suzuki.
755
756         * DumpRenderTree/win/DumpRenderTree.cpp:
757         * TestWebKitAPI/CMakeLists.txt:
758         * TestWebKitAPI/PlatformGTK.cmake:
759         * TestWebKitAPI/PlatformJSCOnly.cmake:
760         * TestWebKitAPI/PlatformPlayStation.cmake:
761         * TestWebKitAPI/PlatformWPE.cmake:
762         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
763         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
764         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
765         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
766         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
767         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
768         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
769         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
770         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
771         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
772
773 2019-01-24  Philippe Normand  <pnormand@igalia.com>
774
775         [WPE] Remove hard dependency on subprocess32 for the API tests
776
777         Rubber-stamped by Carlos Garcia Campos.
778
779         * glib/api_test_runner.py:
780         (TestRunner._run_test_qt): Lazily import subprocess32 and check
781         its presence only when running WPEQt tests.
782
783 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
784
785         [GLIB] Expose JavaScriptCore options in GLib public API
786         https://bugs.webkit.org/show_bug.cgi?id=188742
787
788         Reviewed by Michael Catanzaro.
789
790         Add a test for the new API.
791
792         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
793         (testsJSCOptions):
794         (main):
795
796 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
797
798         [GTK][WPE] Support JPEG 2000 images
799         https://bugs.webkit.org/show_bug.cgi?id=186272
800
801         Reviewed by Žan Doberšek.
802
803         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
804
805         * gtk/jhbuild.modules:
806         * wpe/jhbuild.modules:
807
808 2019-01-23  David Kilzer  <ddkilzer@apple.com>
809
810         check-webkit-style should warn when using soft-linking macros in a header
811         <https://webkit.org/b/193750>
812
813         Reviewed by Darin Adler.
814
815         * Scripts/webkitpy/style/checkers/cpp.py:
816         (check_language): Add softlink/header check by refactoring the
817         softlink/framework check.
818         (CppChecker): Enable softlink/header check by default.
819         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
820         (CppStyleTest.test_softlink_framework): Rename from
821         CppStyleTest.test_softlink() and change test framework name in
822         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
823         files. Set file_name for macros that only appear in headers.
824         (CppStyleTest.test_softlink_header): Add tests for using
825         soft-link macros in headers.
826
827 2019-01-23  Chris Dumez  <cdumez@apple.com>
828
829         Deprecate API to limit the maximum number of WebProcesses
830         https://bugs.webkit.org/show_bug.cgi?id=193725
831         <rdar://problem/47464879>
832
833         Reviewed by Geoff Garen.
834
835         Update existing API tests to stop using deprecated API.
836
837         * MiniBrowser/mac/AppDelegate.m:
838         (defaultConfiguration):
839         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
840         (TestWebKitAPI::TEST):
841         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
842         (TestWebKitAPI::TEST):
843         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
844         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
845         (TEST):
846         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
847         (TEST):
848
849 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
850
851         [ews-app] Rename ews model buildermappings to buildermapping
852         https://bugs.webkit.org/show_bug.cgi?id=193729
853
854         Reviewed by Lucas Forschler.
855
856         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
857         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
858         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
859
860 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
861
862         [ews-app] Rename ews model steps to step
863         https://bugs.webkit.org/show_bug.cgi?id=193697
864
865         Reviewed by Lucas Forschler.
866
867         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
868         (Step): Renamed Steps to Step.
869
870 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
871
872         Clean up IndexedDB files between tests
873         https://bugs.webkit.org/show_bug.cgi?id=192796
874         <rdar://problem/46824999>
875
876         Reviewed by Geoffrey Garen.
877
878         * DumpRenderTree/mac/DumpRenderTree.mm:
879         (runTest):
880         * WebKitTestRunner/TestController.cpp:
881         (WTR::TestController::resetStateToConsistentValues):
882         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
883         (WTR::RemoveAllIndexedDatabasesCallback):
884         (WTR::TestController::ClearIndexedDatabases):
885         * WebKitTestRunner/TestController.h:
886         * WebKitTestRunner/TestInvocation.cpp:
887         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
888
889 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
890
891         [ews-app] Rename ews model Builds to Build
892         https://bugs.webkit.org/show_bug.cgi?id=193695
893
894         Reviewed by Lucas Forschler.
895
896         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
897         (Build): Renamed Builds to Build.
898
899 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
900
901         webkitpy: Wait longer when launching WebKitTestRunner
902         https://bugs.webkit.org/show_bug.cgi?id=193734
903
904         Reviewed by Aakash Jain.
905
906         * Scripts/webkitpy/port/simulator_process.py:
907         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
908
909 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
910
911         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
912         https://bugs.webkit.org/show_bug.cgi?id=193182
913         <rdar://problem/47452154>
914
915         Reviewed by Tim Horton.
916
917         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
918         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
919         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
920
921         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
922         preventing later tests from recognizing gestures.
923
924         * WebKitTestRunner/ios/TestControllerIOS.mm:
925         (WTR::TestController::platformResetStateToConsistentValues):
926
927         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
928
929 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
930
931         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
932         https://bugs.webkit.org/show_bug.cgi?id=193722
933         <rdar://problem/47481475>
934
935         Reviewed by Lucas Forschler.
936
937         iPhone and iPad ports should both use the iOS config.
938
939         * Scripts/webkitpy/port/ios_simulator.py:
940         (IPhoneSimulatorPort.__init__):
941         (IPadSimulatorPort.__init__):
942
943 2019-01-23  Rob Buis  <rbuis@igalia.com>
944
945         Update MIME type parser
946         https://bugs.webkit.org/show_bug.cgi?id=180526
947
948         Reviewed by Frédéric Wang.
949
950         Add unit tests for both parse modes of ParsedContentType.
951
952         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
953         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
954         (TestWebKitAPI::TEST):
955
956 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
957
958         [ews-app] fetch loop should not stop on network issues
959         https://bugs.webkit.org/show_bug.cgi?id=193666
960
961         Reviewed by Lucas Forschler.
962
963         * BuildSlaveSupport/ews-app/ews/fetcher.py:
964         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
965
966 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
967
968         [iOS] Multiple WKWebViewAutofillTests are flaky failures
969         https://bugs.webkit.org/show_bug.cgi?id=189165
970         <rdar://problem/47433765>
971
972         Reviewed by Tim Horton.
973
974         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
975         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
976         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
977         process in sufficient to ensure that any previous action that blurred the focused element in the web process
978         would make its way to the UI process by the time the layer tree commit is finished.
979
980         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
981         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
982         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
983         will fail because it asks for -_autofillContext too early.
984
985         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
986         is handled in the UI process.
987
988         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
989
990         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
991         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
992         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
993         input session.
994
995         (-[AutofillTestView textInputHasAutofillContext]):
996
997         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
998
999         * TestWebKitAPI/cocoa/TestWKWebView.h:
1000         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1001         (nextInputSessionChangeCount):
1002
1003         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
1004         This includes changing the focused element from one to another.
1005
1006         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1007         (-[TestWKWebView didStartFormControlInteraction]):
1008         (-[TestWKWebView didEndFormControlInteraction]):
1009         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1010
1011         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
1012         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
1013         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
1014         that doesn't require an input session to one that doesn't.
1015
1016 2019-01-22  David Kilzer  <ddkilzer@apple.com>
1017
1018         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
1019         <https://webkit.org/b/193676>
1020
1021         Reviewed by Alexey Proskuryakov.
1022
1023         * Scripts/webkitpy/style/checkers/cpp.py:
1024         (check_member_initialization_list):
1025         - Don't report missing whitespace around colon if the colon at
1026           the start of the line is formatted correctly.
1027         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1028         (WebKitStyleTest.test_member_initialization_list):
1029         - Add a test for a missing permutation of existing tests.
1030         - Add a test this false-positive.
1031         - Add blank lines between subtests to make them easier to read.
1032
1033 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1034
1035         [build.webkit.org] Unit-test failure after r237113
1036         https://bugs.webkit.org/show_bug.cgi?id=193669
1037
1038         Reviewed by Michael Catanzaro.
1039
1040         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1041         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
1042         multiple or zero flags.
1043
1044 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
1045
1046         Cache bytecode to disk
1047         https://bugs.webkit.org/show_bug.cgi?id=192782
1048         <rdar://problem/46084932>
1049
1050         Reviewed by Keith Miller.
1051
1052         Add test helper to execute bytecode-cache tests: it executes each test
1053         twice, the first with JSC_diskCachePath set to a temporary directory
1054         and second with JSC_forceDiskCache=true (in addition to the cache path)
1055         to guarantee that only the disk cache is being used and no new
1056         UnlinkedCodeBlocks are being created.
1057
1058         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
1059         * Scripts/run-jsc-stress-tests:
1060
1061 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1062
1063         [css-logical] Implement flow-relative margin, padding and border shorthands
1064         https://bugs.webkit.org/show_bug.cgi?id=188697
1065
1066         Reviewed by Simon Fraser and Antti Koivisto.
1067
1068         * DumpRenderTree/TestOptions.cpp:
1069         (TestOptions::TestOptions):
1070         * DumpRenderTree/TestOptions.h:
1071         * DumpRenderTree/mac/DumpRenderTree.mm:
1072         (setWebPreferencesForTestOptions):
1073         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1074
1075         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1076         (JSONCSSPropertiesChecker.check_codegen_properties):
1077         Allow CSS property definitions to have a 'runtime-flag' parameter which
1078         disables the property when the specified runtime flag is disabled.
1079
1080 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1081
1082         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
1083         https://bugs.webkit.org/show_bug.cgi?id=193643
1084
1085         Reviewed by Michael Catanzaro.
1086
1087         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
1088         * wpe/jhbuild.modules: Ditto.
1089
1090 2019-01-21  Zalan Bujtas  <zalan@apple.com>
1091
1092         [LFC][Floats] Take float top position into account when computing containing block height.
1093         https://bugs.webkit.org/show_bug.cgi?id=193655
1094
1095         Reviewed by Antti Koivisto.
1096
1097         * LayoutReloaded/misc/LFC-passing-tests.txt:
1098
1099 2019-01-21  David Kilzer  <ddkilzer@apple.com>
1100
1101         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
1102         <https://webkit.org/b/193645>
1103         <rdar://problem/47421574>
1104
1105         Reviewed by Alex Christensen.
1106
1107         - Now checks for local soft-linking of all frameworks that have
1108           their own *SoftLinking.{cpp,h,mm} files.
1109         - Changes softlink/uikit warning to softlink/framework.
1110
1111         * Scripts/webkitpy/style/checkers/cpp.py:
1112         (check_language):
1113         (CppChecker):
1114         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1115         (CppStyleTest):
1116
1117 2019-01-20  Saam Barati  <sbarati@apple.com>
1118
1119         Rollout r240210: It broke tests on iOS
1120         https://bugs.webkit.org/show_bug.cgi?id=193640
1121
1122         Unreviewed.
1123
1124         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
1125         * Scripts/run-jsc-stress-tests:
1126
1127 2019-01-20  chris fleizach  <cfleizach@apple.com>
1128
1129         AX: Support returning relative frames for accessibility
1130         https://bugs.webkit.org/show_bug.cgi?id=193414
1131         <rdar://problem/47268501>
1132
1133         Reviewed by Zalan Bujtas.
1134
1135         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1136         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1137         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1138         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1139         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1140         (WTR::attributesOfElement):
1141         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1142
1143 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1144
1145         Unreviewed, add my new email address
1146
1147         * Scripts/webkitpy/common/config/contributors.json:
1148
1149 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1150
1151         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1152         https://bugs.webkit.org/show_bug.cgi?id=193617
1153
1154         Reviewed by Antti Koivisto.
1155
1156         * LayoutReloaded/misc/LFC-passing-tests.txt:
1157
1158 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1159
1160         Unreviewed, rolling out r240209.
1161
1162         Broke GTK/WPE injected bundle
1163
1164         Reverted changeset:
1165
1166         "AX: Support returning relative frames for accessibility"
1167         https://bugs.webkit.org/show_bug.cgi?id=193414
1168         https://trac.webkit.org/changeset/240209
1169
1170 2019-01-12  Dan Bernstein  <mitz@apple.com>
1171
1172         [Cocoa] Avoid importing directly from subumbrella frameworks
1173         https://bugs.webkit.org/show_bug.cgi?id=186016
1174         <rdar://problem/40591038>
1175
1176         Reviewed by Sam Weinig.
1177
1178         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1179           LaunchServices header.
1180         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1181           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1182         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1183           when using SDKs earlier than 10.13.
1184         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1185           and OTHER_CPLUSPLUSFLAGS.
1186         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1187           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1188         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1189           LaunchServices header.
1190
1191 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
1192
1193         Cache bytecode to disk
1194         https://bugs.webkit.org/show_bug.cgi?id=192782
1195         <rdar://problem/46084932>
1196
1197         Reviewed by Keith Miller.
1198
1199         Add test helper to execute bytecode-cache tests: it executes each test
1200         twice, the first with JSC_diskCachePath set to a temporary directory
1201         and second with JSC_forceDiskCache=true (in addition to the cache path)
1202         to guarantee that only the disk cache is being used and no new
1203         UnlinkedCodeBlocks are being created.
1204
1205         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
1206         * Scripts/run-jsc-stress-tests:
1207
1208 2019-01-20  chris fleizach  <cfleizach@apple.com>
1209
1210         AX: Support returning relative frames for accessibility
1211         https://bugs.webkit.org/show_bug.cgi?id=193414
1212         <rdar://problem/47268501>
1213
1214         Reviewed by Zalan Bujtas.
1215
1216         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1217         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1218         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1219         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1220         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1221         (WTR::attributesOfElement):
1222         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1223
1224 2019-01-20  Antoine Quint  <graouts@apple.com>
1225
1226         Add a POINTER_EVENTS feature flag
1227         https://bugs.webkit.org/show_bug.cgi?id=193577
1228         <rdar://problem/47408511>
1229
1230         Unreviewed. Also enable Pointer Events for iosmac.
1231
1232         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1233
1234 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1235
1236         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
1237         https://bugs.webkit.org/show_bug.cgi?id=193613
1238
1239         Reviewed by Antti Koivisto.
1240
1241         * LayoutReloaded/misc/LFC-passing-tests.txt:
1242
1243 2019-01-19  Antoine Quint  <graouts@apple.com>
1244
1245         Add a POINTER_EVENTS feature flag
1246         https://bugs.webkit.org/show_bug.cgi?id=193577
1247
1248         Reviewed by Dean Jackson.
1249
1250         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1251
1252 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
1253
1254         Disable the run-jsc-stress-test remote host key check [second round].
1255         https://bugs.webkit.org/show_bug.cgi?id=192988
1256
1257         Reviewed by Dewei Zhu.
1258
1259         * Scripts/run-jsc-stress-tests:
1260
1261 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1262
1263         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
1264         https://bugs.webkit.org/show_bug.cgi?id=193597
1265
1266         Reviewed by Lucas Forschler.
1267
1268         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1269
1270 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1271
1272         [build.webkit.org] api tests failures are incorrectly named as unit test failures
1273         https://bugs.webkit.org/show_bug.cgi?id=193595
1274
1275         Reviewed by Lucas Forschler.
1276
1277         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
1278         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
1279         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
1280
1281 2019-01-18  Chris Dumez  <cdumez@apple.com>
1282
1283         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
1284         https://bugs.webkit.org/show_bug.cgi?id=193588
1285         <rdar://problem/47131566>
1286
1287         Reviewed by Alex Christensen.
1288
1289         Add layout test coverage.
1290
1291         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1292
1293 2019-01-18  Jer Noble  <jer.noble@apple.com>
1294
1295         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1296         https://bugs.webkit.org/show_bug.cgi?id=189553
1297
1298         Reviewed by Tim Horton.
1299
1300         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1301
1302         * ContentExtensionTester/Configurations/Base.xcconfig:
1303         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1304         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1305         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1306         * ImageDiff/cg/Configurations/Base.xcconfig:
1307         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1308         * MiniBrowser/Configurations/Base.xcconfig:
1309         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1310         * MobileMiniBrowser/Configurations/Base.xcconfig:
1311         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1312         * Scripts/webkitpy/style/checker.py:
1313         (_all_categories):
1314         (FileType):
1315         (CheckerDispatcher._file_type):
1316         (CheckerDispatcher._create_checker):
1317         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1318         (SDKVariantChecker):
1319         (SDKVariantChecker.__init__):
1320         (SDKVariantChecker.check):
1321         * TestWebKitAPI/Configurations/Base.xcconfig:
1322         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1323         * WebEditingTester/Configurations/Base.xcconfig:
1324         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1325         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1326         * WebKitTestRunner/Configurations/Base.xcconfig:
1327         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1328         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1329         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1330
1331 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1332
1333         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1334         <https://webkit.org/b/193568>
1335         <rdar://problem/47381130>
1336
1337         Reviewed by Alex Christensen.
1338
1339         Make sure no one re-introduces UIKit soft-linking by adding a
1340         style rule.
1341
1342         * Scripts/webkitpy/style/checkers/cpp.py:
1343         (check_language): Add softlink/uikit check.
1344         (CppChecker): Enable softlink/uikit check.
1345         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1346         (CppStyleTest): Add test for softlink/uikit.
1347
1348 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1349
1350         [GTK] install-dependencies tool looks for libunistring-dev for dnf
1351         https://bugs.webkit.org/show_bug.cgi?id=193584
1352
1353         Change "-dev" to "-devel".
1354
1355         Reviewed by Michael Catanzaro.
1356
1357         * gtk/install-dependencies:
1358
1359 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1360
1361         webkitpy: Add iPhone and iPad ports
1362         https://bugs.webkit.org/show_bug.cgi?id=193537
1363         <rdar://problem/47353390>
1364
1365         Reviewed by Lucas Forschler.
1366
1367         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
1368         ports. Note that this separation is optional, the --ios-simulator command remains.
1369
1370         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1371         (RunTest.test_device_type_test_division): Drive-by fix.
1372         (RunTest.test_device_type_specific_listing): Ditto.
1373         (RunTest.test_ipad_test_division):
1374         (RunTest):
1375         (RunTest.test_ipad_listing):
1376         * Scripts/webkitpy/port/factory.py:
1377         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
1378         (PortFactory):
1379         * Scripts/webkitpy/port/ios_simulator.py:
1380         (IPhoneSimulatorPort):
1381         (IPadSimulatorPort):
1382
1383 2019-01-18  Chris Dumez  <cdumez@apple.com>
1384
1385         Regression(PSON) Scroll position is not always restored properly when navigating back
1386         https://bugs.webkit.org/show_bug.cgi?id=193578
1387         <rdar://problem/47386331>
1388
1389         Reviewed by Tim Horton.
1390
1391         Add API test coverage.
1392
1393         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1394
1395 2019-01-18  Youenn Fablet  <youenn@apple.com>
1396
1397         Add a new SPI to request for cache storage quota increase
1398         https://bugs.webkit.org/show_bug.cgi?id=193323
1399
1400         Reviewed by Alex Christensen.
1401
1402         Implement WebsiteDataStore quota delegate to handle quota requests.
1403         By default, do not update quota.
1404         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
1405
1406         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1407         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1408         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
1409         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1410         * WebKitTestRunner/TestController.cpp:
1411         (WTR::TestController::allowCacheStorageQuotaIncrease):
1412         * WebKitTestRunner/TestController.h:
1413         * WebKitTestRunner/TestInvocation.cpp:
1414         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1415         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1416         (-[CacheStorageQuotaManager init]):
1417         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1418         (WTR::initializeWebViewConfiguration):
1419         (WTR::TestController::cocoaResetStateToConsistentValues):
1420         (WTR::TestController::allowCacheStorageQuotaIncrease):
1421
1422 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1423
1424         [ews-build] Pass owner to the triggered builds
1425         https://bugs.webkit.org/show_bug.cgi?id=193574
1426
1427         Reviewed by Lucas Forschler.
1428
1429         * BuildSlaveSupport/ews-build/factories.py:
1430         (BuildFactory.propertiesToPassToTriggers):
1431
1432 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1433
1434         [ews-app] Send patch author as a build property
1435         https://bugs.webkit.org/show_bug.cgi?id=193560
1436
1437         Reviewed by Lucas Forschler.
1438
1439         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1440         (BugzillaPatchFetcher.fetch):
1441
1442 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1443
1444         webkitpy: Implement device type specific expected results (Follow-up fix)
1445         https://bugs.webkit.org/show_bug.cgi?id=192162
1446         <rdar://problem/46345449>
1447
1448         Unreviewed infrastructure fix.
1449
1450         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1451         (Manager.run): Don't boot a device if no tests are available to run on it.
1452
1453 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1454
1455         webkitpy: Implement device type specific expected results (Follow-up fix)
1456         https://bugs.webkit.org/show_bug.cgi?id=192162
1457         <rdar://problem/46345449>
1458
1459         Unreviewed infrastructure fix.
1460
1461         * Scripts/webkitpy/api_tests/manager.py:
1462         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1463
1464 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1465
1466         webkitpy: Implement device type specific expected results (Part 2)
1467         https://bugs.webkit.org/show_bug.cgi?id=192162
1468         <rdar://problem/46345449>
1469
1470         Rubber-stamped by Aakash Jain.
1471
1472         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1473         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1474         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1475
1476         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1477         (LayoutTestFinder.find_tests): Pass device_type through.
1478         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
1479         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
1480         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1481         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
1482         (Manager._collect_tests): Pass device type to test finder.
1483         (Manager._needs_web_platform_test):
1484         (Manager._prepare_lists): Index _expectations by device type.
1485         (Manager._test_input_for_file):
1486         (Manager._test_is_slow): Ditto.
1487         (Manager._test_should_dump_jsconsolelog_in_stderr):
1488         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
1489         (Manager._get_test_inputs):
1490         (Manager._update_worker_count):
1491         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
1492         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
1493         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
1494         the one which runs the test.
1495         (Manager._run_test_subset):
1496         (Manager._run_tests): Index _expectations by current_device_type.
1497         (Manager._print_expectation_line_for_test): Ditto.
1498         (Manager._print_expectations_for_subset): Ditto.
1499         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
1500         Unlike run, this function will behave the same regardless of what devices are available.
1501         (Manager._custom_device_for_test): Deleted.
1502         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1503         (ManagerTest.test_uses_custom_device): Deleted.
1504         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
1505         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1506         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1507         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1508         all of the expectations.
1509         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1510         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1511         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1512         (TestExpectations.__init__): Allow device_type to be passed through.
1513         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1514         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1515         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1516         (summarize_results):
1517         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1518         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1519         a test ran with, one must check all expectations to find the first non-skip expectation.
1520         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1521         (RunTest.test_device_type_test_division):
1522         (RunTest):
1523         (RunTest.test_device_type_specific_listing):
1524         * Scripts/webkitpy/port/base.py:
1525         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1526         (Port.supported_device_types): The result of this function will change based on what devices are available.
1527         * Scripts/webkitpy/port/device_port.py:
1528         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1529         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1530         can be used.
1531         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1532         any, or the DEFAULT_DEVICE_TYPES of the port.
1533         * Scripts/webkitpy/port/ios.py:
1534         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1535         * Scripts/webkitpy/port/ios_simulator.py:
1536         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1537         * Scripts/webkitpy/port/watch.py:
1538         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1539         * Scripts/webkitpy/port/watch_simulator.py:
1540         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1541         * Scripts/webkitpy/xcode/device_type.py:
1542         (DeviceType):
1543         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1544
1545 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1546
1547         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1548         https://bugs.webkit.org/show_bug.cgi?id=193575
1549
1550         Reviewed by Michael Catanzaro.
1551
1552         Allow the script to run without explicit port argument because
1553         it's specific to the WPE port anyway.
1554
1555         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1556         and simplify the rest of the code accordingly.
1557
1558 2019-01-18  Charlie Turner  <cturner@igalia.com>
1559
1560         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1561         https://bugs.webkit.org/show_bug.cgi?id=192229
1562
1563         Reviewed by Xabier Rodriguez-Calvar.
1564
1565         * MiniBrowser/wpe/main.cpp:
1566         (main): Enable encrypted-media by default.
1567
1568 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1569
1570         [Flatpak] Missing KeyboardInterrupt exception handler
1571         https://bugs.webkit.org/show_bug.cgi?id=193570
1572
1573         Reviewed by Michael Catanzaro.
1574
1575         * flatpak/flatpakutils.py:
1576         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1577
1578 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1579
1580         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1581         https://bugs.webkit.org/show_bug.cgi?id=193564
1582
1583         Reviewed by Antti Koivisto.
1584
1585         * LayoutReloaded/misc/LFC-passing-tests.txt:
1586
1587 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1588
1589         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1590         https://bugs.webkit.org/show_bug.cgi?id=193562
1591
1592         Reviewed by Antti Koivisto.
1593
1594         * LayoutReloaded/misc/LFC-passing-tests.txt:
1595
1596 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1597
1598         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1599         https://bugs.webkit.org/show_bug.cgi?id=193555
1600
1601         Reviewed by Antti Koivisto.
1602
1603         * LayoutReloaded/misc/LFC-passing-tests.txt:
1604
1605 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1606
1607         [WPE] Add Qt extension
1608         https://bugs.webkit.org/show_bug.cgi?id=191464
1609
1610         Reviewed by Carlos Garcia Campos.
1611
1612         MiniBrowser and API tests for the WPE Qt API. To run the
1613         MiniBrowser a new script is introduced. Example invocation:
1614
1615         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1616
1617         Also note-worthy is the introduction of the python2-subprocess32
1618         dependency to run the GLib API tests.
1619
1620         * MiniBrowser/wpe/CMakeLists.txt:
1621         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1622         * MiniBrowser/wpe/qt/main.cpp: Added.
1623         (main):
1624         * MiniBrowser/wpe/qt/main.qml: Added.
1625         * MiniBrowser/wpe/qt/qml.qrc: Added.
1626         * Scripts/run-gtk-tests:
1627         (GtkTestRunner.is_google_test):
1628         (GtkTestRunner):
1629         (GtkTestRunner.is_qt_test):
1630         * Scripts/run-qt-wpe-minibrowser: Added.
1631         * Scripts/run-wpe-tests:
1632         (WPETestRunner):
1633         (WPETestRunner.is_google_test):
1634         (WPETestRunner.is_qt_test):
1635         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1636         (TestLoad::main):
1637         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1638         (TestLoadHtml::main):
1639         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1640         (TestLoadRequest::main):
1641         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1642         (TestRunJavaScript::main):
1643         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1644         (waitForSignal):
1645         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1646         (LoadSpy::LoadSpy):
1647         (LoadSpy::~LoadSpy):
1648         (LoadSpy::onLoadingChanged):
1649         (LoadStartedCatcher::LoadStartedCatcher):
1650         (LoadStartedCatcher::~LoadStartedCatcher):
1651         (LoadStartedCatcher::onLoadingChanged):
1652         (waitForLoadSucceeded):
1653         (waitForLoadFailed):
1654         * TestWebKitAPI/glib/CMakeLists.txt:
1655         * flatpak/flatpakutils.py:
1656         (WebkitFlatpak.load_from_args):
1657         (WebkitFlatpak.__init__):
1658         (WebkitFlatpak.clean_args):
1659         (WebkitFlatpak.run_in_sandbox):
1660         * flatpak/org.webkit.CommonModules.yaml:
1661         * flatpak/org.webkit.WPE.yaml:
1662         * flatpak/org.webkit.WPEModules.yaml:
1663         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1664         * flatpak/org.webkit.WebKit.yaml:
1665         * glib/api_test_runner.py:
1666         (TestRunner._run_test_qt):
1667         (TestRunner.is_qt_test):
1668         (TestRunner._run_test):
1669
1670 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1671
1672         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1673         https://bugs.webkit.org/show_bug.cgi?id=193494
1674         <rdar://problem/46859627>
1675
1676         Reviewed by Simon Fraser and Tim Horton.
1677
1678         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1679         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1680
1681         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1682         (WTR::UIScriptController::contentOffsetX const):
1683         (WTR::UIScriptController::contentOffsetY const):
1684         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1685         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1686         (WTR::UIScriptController::contentOffsetX const):
1687         (WTR::UIScriptController::contentOffsetY const):
1688         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1689
1690         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1691
1692         * WebKitTestRunner/TestController.cpp:
1693         (WTR::updateTestOptionsFromTestHeader):
1694         * WebKitTestRunner/TestOptions.h:
1695         (WTR::TestOptions::hasSameInitializationOptions const):
1696         * WebKitTestRunner/ios/TestControllerIOS.mm:
1697         (WTR::TestController::platformResetStateToConsistentValues):
1698         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1699         (WTR::UIScriptController::contentOffsetX const):
1700         (WTR::UIScriptController::contentOffsetY const):
1701
1702 2019-01-17  Truitt Savell  <tsavell@apple.com>
1703
1704         Unreviewed, rolling out r240124.
1705
1706         This commit broke an internal build.
1707
1708         Reverted changeset:
1709
1710         "SDK_VARIANT build destinations should be separate from non-
1711         SDK_VARIANT builds"
1712         https://bugs.webkit.org/show_bug.cgi?id=189553
1713         https://trac.webkit.org/changeset/240124
1714
1715 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1716
1717         Fix string concatenation API test after r239920
1718         https://bugs.webkit.org/show_bug.cgi?id=193551
1719         <rdar://problem/47359304>
1720
1721         Reviewed by Youenn Fablet.
1722
1723         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1724         (TestWebKitAPI::TEST):
1725         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1726         in WebKit's build configuration like it apparently is on Linux.
1727
1728 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1729
1730         [ews-build] validate-patch should handle the case when bug_id is None
1731         https://bugs.webkit.org/show_bug.cgi?id=193547
1732
1733         Reviewed by Lucas Forschler.
1734
1735         * BuildSlaveSupport/ews-build/steps.py:
1736         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1737         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1738
1739 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1740
1741         [ews-build] Add patch author information in build
1742         https://bugs.webkit.org/show_bug.cgi?id=193465
1743
1744         Reviewed by Lucas Forschler.
1745
1746         * BuildSlaveSupport/ews-build/steps.py:
1747         (ValidatePatch._is_patch_obsolete):
1748
1749 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1750
1751         [ews-build] Pass bug_id to the triggered builds
1752         https://bugs.webkit.org/show_bug.cgi?id=193548
1753
1754         Reviewed by Lucas Forschler.
1755
1756         * BuildSlaveSupport/ews-build/factories.py:
1757         (BuildFactory.propertiesToPassToTriggers):
1758
1759 2019-01-17  Jer Noble  <jer.noble@apple.com>
1760
1761         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1762         https://bugs.webkit.org/show_bug.cgi?id=189553
1763
1764         Reviewed by Tim Horton.
1765
1766         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1767
1768         * ContentExtensionTester/Configurations/Base.xcconfig:
1769         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1770         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1771         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1772         * ImageDiff/cg/Configurations/Base.xcconfig:
1773         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1774         * MiniBrowser/Configurations/Base.xcconfig:
1775         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1776         * MobileMiniBrowser/Configurations/Base.xcconfig:
1777         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1778         * Scripts/webkitpy/style/checker.py:
1779         (_all_categories):
1780         (FileType):
1781         (CheckerDispatcher._file_type):
1782         (CheckerDispatcher._create_checker):
1783         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1784         (SDKVariantChecker):
1785         (SDKVariantChecker.__init__):
1786         (SDKVariantChecker.check):
1787         * TestWebKitAPI/Configurations/Base.xcconfig:
1788         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1789         * WebEditingTester/Configurations/Base.xcconfig:
1790         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1791         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1792         * WebKitTestRunner/Configurations/Base.xcconfig:
1793         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1794         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1795         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1796
1797 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1798
1799         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1800         https://bugs.webkit.org/show_bug.cgi?id=193534
1801
1802         Reviewed by Antti Koivisto.
1803
1804         * LayoutReloaded/misc/LFC-passing-tests.txt:
1805
1806 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1807
1808         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1809         https://bugs.webkit.org/show_bug.cgi?id=193528
1810
1811         Reviewed by Antti Koivisto.
1812
1813         * LayoutReloaded/misc/LFC-passing-tests.txt:
1814
1815 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1816
1817         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1818         https://bugs.webkit.org/show_bug.cgi?id=193520
1819
1820         Reviewed by Antti Koivisto.
1821
1822         * LayoutReloaded/misc/LFC-passing-tests.txt:
1823
1824 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1825
1826         [ews-build] unapply-patch step should not update source
1827         https://bugs.webkit.org/show_bug.cgi?id=193234
1828
1829         Reviewed by Lucas Forschler.
1830
1831         * BuildSlaveSupport/ews-build/steps.py:
1832         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1833         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1834
1835 2019-01-16  Youenn Fablet  <youenn@apple.com>
1836
1837         Add a new SPI for controlling getUserMedia
1838         https://bugs.webkit.org/show_bug.cgi?id=192793
1839
1840         Reviewed by Eric Carlson.
1841
1842         * MiniBrowser/mac/WK2BrowserWindowController.m:
1843         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1844         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1845         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1846         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1847         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1848         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1849         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1850         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1851         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1852         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1853         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1854         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1855         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1856         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1857
1858 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1859
1860         [LFC][BFC] Inflow non-replaced used width should not be negative.
1861         https://bugs.webkit.org/show_bug.cgi?id=193495
1862
1863         Reviewed by Antti Koivisto.
1864
1865         * LayoutReloaded/misc/LFC-passing-tests.txt:
1866
1867 2019-01-16  Chris Dumez  <cdumez@apple.com>
1868
1869         Regression(PSON) View becomes blank after click a cross-site download link
1870         https://bugs.webkit.org/show_bug.cgi?id=193361
1871         <rdar://problem/47099573>
1872
1873         Reviewed by Geoffrey Garen.
1874
1875         Add API test coverage.
1876
1877         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1878         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1879
1880 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1881
1882         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1883         https://bugs.webkit.org/show_bug.cgi?id=193470
1884
1885         Reviewed by Antti Koivisto.
1886
1887         * LayoutReloaded/misc/LFC-passing-tests.txt:
1888
1889 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1890
1891         [LFC] Adjust margin box verification.
1892         https://bugs.webkit.org/show_bug.cgi?id=193482
1893
1894         Reviewed by Antti Koivisto.
1895
1896         * LayoutReloaded/misc/LFC-passing-tests.txt:
1897
1898 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1899
1900         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1901         https://bugs.webkit.org/show_bug.cgi?id=193451
1902
1903         Reviewed by Geoffrey Garen.
1904
1905         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1906         (TEST):
1907         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1908         (runWebsiteDataStoreCustomPaths):
1909
1910 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1911
1912         webkitpy: Support boolean simctl isAvailable
1913         https://bugs.webkit.org/show_bug.cgi?id=193472
1914         <rdar://problem/47296150>
1915
1916         Reviewed by Ryosuke Niwa.
1917
1918         * Scripts/webkitpy/xcode/simulated_device.py:
1919         (SimulatedDeviceManager._create_runtimes):
1920         (SimulatedDeviceManager._create_device_with_runtime):
1921
1922 2019-01-15  Chris Dumez  <cdumez@apple.com>
1923
1924         Unreviewed, rolling out r239993, r239995, r239997, and
1925         r239999.
1926
1927         Caused assertions under
1928         ViewGestureController::disconnectFromProcess()
1929
1930         Reverted changesets:
1931
1932         "Regression(PSON) View becomes blank after click a cross-site
1933         download link"
1934         https://bugs.webkit.org/show_bug.cgi?id=193361
1935         https://trac.webkit.org/changeset/239993
1936
1937         "Unreviewed iOS build fix after r239993."
1938         https://trac.webkit.org/changeset/239995
1939
1940         "Fix iOS build after r239993"
1941         https://bugs.webkit.org/show_bug.cgi?id=193361
1942         https://trac.webkit.org/changeset/239997
1943
1944         "Unreviewed, revert part of r239997 as it is not needed to fix
1945         the build."
1946         https://trac.webkit.org/changeset/239999
1947
1948 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1949
1950         Cannot tab out of WKWebView on macOS
1951         https://bugs.webkit.org/show_bug.cgi?id=161448
1952         <rdar://problem/28100085>
1953
1954         Reviewed by Dean Jackson.
1955
1956         Add a test that tabbing into and out of WKWebView works correctly.
1957
1958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1959         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1960         (WebKit2_CommandBackForwardTest::SetUp):
1961         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1962         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1963         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1964         (-[FocusableView canBecomeKeyView]):
1965         (TEST):
1966         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1967         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1968         (-[OffscreenWindow initWithSize:]):
1969         (-[OffscreenWindow isKeyWindow]):
1970         (-[OffscreenWindow isVisible]):
1971         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1972         (TestWebKitAPI::PlatformWebView::initialize):
1973         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1974         (-[ActiveOffscreenWindow isVisible]): Deleted.
1975         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1976
1977 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1978
1979         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1980         https://bugs.webkit.org/show_bug.cgi?id=193459
1981
1982         Reviewed by Mark Lam.
1983
1984         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1985         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1986
1987 2019-01-15  Chris Dumez  <cdumez@apple.com>
1988
1989         Regression(PSON) View becomes blank after click a cross-site download link
1990         https://bugs.webkit.org/show_bug.cgi?id=193361
1991         <rdar://problem/47099573>
1992
1993         Reviewed by Geoff Garen.
1994
1995         Add API test coverage.
1996
1997         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1998         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1999
2000 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2001
2002         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
2003         https://bugs.webkit.org/show_bug.cgi?id=193448
2004
2005         Reviewed by Antti Koivisto.
2006
2007         * LayoutReloaded/misc/LFC-passing-tests.txt:
2008
2009 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2010
2011         webkitpy: Implement device type specific expected results (Part 1)
2012         https://bugs.webkit.org/show_bug.cgi?id=192162
2013
2014         Reviewed by Lucas Forschler.
2015
2016         Device type specific expected results covers two related ideas. The first (covered by this change)
2017         is where to search for -expected.* files. The second is which tests to run based on the
2018         TestExpectations.txt file.
2019
2020         After this change, the baseline search path will be determined by the type of device running a
2021         test. Device type will be passed into any function which picks a file based on the baseline search
2022         path.
2023
2024         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2025         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
2026         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2027         (Manager.run): Print baseline search path for each round of devices.
2028         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2029         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
2030         (SingleTestRunner._expected_driver_output): Ditto.
2031         (SingleTestRunner._driver_input): Ditto.
2032         * Scripts/webkitpy/layout_tests/views/printing.py:
2033         (Printer.print_config): Move printing of baseline search path to a separate function.
2034         (Printer.print_baseline_search_path): Moved from Printer.print_config.
2035         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2036         (Testprinter.test_print_config):
2037         (Testprinter.test_print_baseline_search_path):
2038         * Scripts/webkitpy/port/base.py:
2039         (Port.baseline_search_path): Pass device_type through.
2040         (Port._expected_baselines_for_suffixes): Ditto.
2041         (Port.expected_baselines): Ditto.
2042         (Port.expected_filename): Ditto.
2043         (Port.expected_checksum): Ditto.
2044         (Port.expected_image): Ditto.
2045         (Port.expected_audio): Ditto.
2046         (Port.expected_text): Ditto.
2047         (Port.reference_files): Ditto.
2048         (Port.tests): Ditto.
2049         (Port._expanded_paths): Ditto.
2050         (Port.skipped_layout_tests): Ditto.
2051         (Port.expectations_dict): Ditto.
2052         (Port._port_specific_expectations_files): Ditto.
2053         (Port.expectations_files): Ditto.
2054         (Port.test_search_path): Ditto.
2055         (Port._tests_for_other_platforms): Ditto.
2056         * Scripts/webkitpy/port/base_unittest.py:
2057         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
2058         (PortTest.test_nonexistant_expectations): Ditto.
2059         (test_ref_tests_platform_directory): Ditto.
2060         * Scripts/webkitpy/port/darwin.py:
2061         (DarwinPort._port_specific_expectations_files): Accept device_type.
2062         * Scripts/webkitpy/port/driver.py:
2063         (DriverProxy):
2064         (DriverProxy.host): Expose _target_host for device_type information.
2065         * Scripts/webkitpy/port/gtk.py:
2066         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
2067         * Scripts/webkitpy/port/ios.py:
2068         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2069         * Scripts/webkitpy/port/mac.py:
2070         (MacPort. default_baseline_search_path): Ditto.
2071         * Scripts/webkitpy/port/port_testcase.py:
2072         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
2073         * Scripts/webkitpy/port/test.py:
2074         * Scripts/webkitpy/port/watch.py:
2075         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2076         * Scripts/webkitpy/port/win.py:
2077         (WinPort.test_search_path): Accept, but do not use, device_type.
2078         * Scripts/webkitpy/port/wpe.py:
2079         (WPEPort._port_specific_expectations_files): Ditto.
2080         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2081         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
2082
2083 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2084
2085         [LFC] Use the containing block's padding box to position out-of-flow elements.
2086         https://bugs.webkit.org/show_bug.cgi?id=193431
2087
2088         Reviewed by Antti Koivisto.
2089
2090         * LayoutReloaded/misc/LFC-passing-tests.txt:
2091
2092 2019-01-14  Tim Horton  <timothy_horton@apple.com>
2093
2094         Move a test implementation file that got misplaced in the Xcode project
2095
2096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2097
2098 2019-01-14  Commit Queue  <commit-queue@webkit.org>
2099
2100         Unreviewed, rolling out r239901, r239909, r239910, r239912,
2101         r239913, and r239914.
2102         https://bugs.webkit.org/show_bug.cgi?id=193407
2103
2104         These revisions caused an internal failure (Requested by
2105         Truitt on #webkit).
2106
2107         Reverted changesets:
2108
2109         "[Cocoa] Avoid importing directly from subumbrella frameworks"
2110         https://bugs.webkit.org/show_bug.cgi?id=186016
2111         https://trac.webkit.org/changeset/239901
2112
2113         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
2114         https://trac.webkit.org/changeset/239909
2115
2116         "Tried to fix the build."
2117         https://trac.webkit.org/changeset/239910
2118
2119         "Fixed iOS builds after r239910."
2120         https://trac.webkit.org/changeset/239912
2121
2122         "More build fixing."
2123         https://trac.webkit.org/changeset/239913
2124
2125         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
2126         https://trac.webkit.org/changeset/239914
2127
2128 2019-01-14  Mark Lam  <mark.lam@apple.com>
2129
2130         Re-enable ability to build --cloop builds.
2131         https://bugs.webkit.org/show_bug.cgi?id=192955
2132         <rdar://problem/46882363>
2133
2134         Reviewed by Saam barati and Keith Miller.
2135
2136         The --cloop build option was being ignored this whole time since r236381.
2137         This patch makes it possible to build CLoop builds again.
2138
2139         * Scripts/build-jsc:
2140         * Scripts/webkitperl/FeatureList.pm:
2141         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2142
2143 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2144
2145         webkitpy: Expose device_type from host-like objects
2146         https://bugs.webkit.org/show_bug.cgi?id=193406
2147         <rdar://problem/47262305>
2148
2149         Reviewed by Lucas Forschler.
2150
2151         Devices should expose device_type. As a result, all host objects should
2152         provide a device_type property, even if they do not yet define a device_type.
2153
2154         * Scripts/webkitpy/common/system/systemhost.py:
2155         (SystemHost):
2156         (SystemHost.device_type):
2157         * Scripts/webkitpy/common/system/systemhost_mock.py:
2158         (MockSystemHost):
2159         (MockSystemHost.device_type):
2160         * Scripts/webkitpy/port/device.py:
2161         (Device):
2162         (Device.device_type):
2163         * Scripts/webkitpy/xcode/simulated_device.py:
2164         (SimulatedDeviceManager._find_exisiting_device_for_request):
2165         (SimulatedDeviceManager._disambiguate_device_type):
2166         (SimulatedDeviceManager._does_fulfill_request):
2167         (SimulatedDeviceManager.device_count_for_type):
2168         (SimulatedDeviceManager.initialize_devices):
2169         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2170         (test_available_devices):
2171         (test_swapping_devices):
2172
2173 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2174
2175         webkitpy: Support alternate simctl device list output (Follow-up fix)
2176         https://bugs.webkit.org/show_bug.cgi?id=193362
2177         <rdar://problem/47122965>
2178
2179         Rubber-stamped by Lucas Forschler.
2180
2181         * Scripts/webkitpy/xcode/simulated_device.py:
2182         (SimulatedDeviceManager.populate_available_devices):
2183
2184 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2185
2186         [iOS] Expose SPI to access the current sentence boundary and selection state
2187         https://bugs.webkit.org/show_bug.cgi?id=193398
2188         <rdar://problem/45893108>
2189
2190         Reviewed by Dean Jackson.
2191
2192         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
2193         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
2194         expected.
2195
2196         * TestWebKitAPI/EditingTestHarness.h:
2197         * TestWebKitAPI/EditingTestHarness.mm:
2198         (-[EditingTestHarness moveBackward]):
2199         (-[EditingTestHarness moveForward]):
2200         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
2201
2202         Add a couple of new helper methods on EditingTestHarness.
2203
2204         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2205         (-[SelectionChangeObserver initWithWebView:]):
2206         (-[SelectionChangeObserver webView]):
2207         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
2208         (-[SelectionChangeObserver currentSelectionAttributes]):
2209
2210 2019-01-14  Zalan Bujtas  <zalan@apple.com>
2211
2212         [LFC][BFC] Add basic box-sizing support.
2213         https://bugs.webkit.org/show_bug.cgi?id=193392
2214
2215         Reviewed by Antti Koivisto.
2216
2217         * LayoutReloaded/misc/LFC-passing-tests.txt:
2218
2219 2019-01-14  Charlie Turner  <cturner@igalia.com>
2220
2221         [WPE] API test gardening
2222         https://bugs.webkit.org/show_bug.cgi?id=193319
2223
2224         Reviewed by Michael Catanzaro.
2225
2226         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
2227         passing tests.
2228
2229 2019-01-14  Charlie Turner  <cturner@igalia.com>
2230
2231         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
2232         https://bugs.webkit.org/show_bug.cgi?id=192977
2233
2234         Reviewed by Carlos Garcia Campos.
2235
2236         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
2237         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2238         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
2239         (TestWebKitAPI::GStreamerTest::SetUp):
2240         (TestWebKitAPI::GStreamerTest::TearDown):
2241         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
2242         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
2243         (TestWebKitAPI::TEST_F):
2244
2245 2019-01-14  Charlie Turner  <cturner@igalia.com>
2246
2247         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
2248         https://bugs.webkit.org/show_bug.cgi?id=193332
2249
2250         Reviewed by Michael Catanzaro.
2251
2252         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
2253         defined as a char16_t, which changed in ICU 59, the
2254         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
2255         unsigned short. This test is relying on the behaviour that
2256         UChar=unsigned short, which doesn't hold across platforms and ICU
2257         library versions. The full fix would be a special syntax for
2258         literal characters so that these ambiguities do not arise. That
2259         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
2260         (TestWebKitAPI::TEST):
2261
2262 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2263
2264         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
2265
2266         * Scripts/make-dist:
2267         (Distcheck.configure):
2268
2269 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
2270
2271         [ews-build] Update macOS queue configurations
2272         https://bugs.webkit.org/show_bug.cgi?id=193365
2273         <rdar://problem/47221073>
2274
2275         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
2276
2277         * BuildSlaveSupport/ews-build/config.json:
2278
2279 2019-01-13  Zalan Bujtas  <zalan@apple.com>
2280
2281         [LFC] Adjust assert for statically positioned fixed elements
2282         https://bugs.webkit.org/show_bug.cgi?id=193385
2283
2284         Reviewed by Antti Koivisto.
2285
2286         * LayoutReloaded/misc/LFC-passing-tests.txt:
2287
2288 2019-01-13  Philippe Normand  <pnormand@igalia.com>
2289
2290         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
2291         https://bugs.webkit.org/show_bug.cgi?id=193387
2292
2293         Reviewed by Carlos Garcia Campos.
2294
2295         * MiniBrowser/wpe/main.cpp:
2296         (main):
2297
2298 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2299
2300         Have prefers-color-scheme: light always match on macOS versions before Mojave.
2301         https://bugs.webkit.org/show_bug.cgi?id=191655
2302         rdar://problem/46074680
2303
2304         Reviewed by Megan Gardner.
2305
2306         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
2307         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2308
2309 2019-01-12  Dan Bernstein  <mitz@apple.com>
2310
2311         [Cocoa] Avoid importing directly from subumbrella frameworks
2312         https://bugs.webkit.org/show_bug.cgi?id=186016
2313         <rdar://problem/40591038>
2314
2315         Reviewed by Sam Weinig.
2316
2317         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2318           LaunchServices header.
2319         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2320           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2321         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2322           when using SDKs earlier than 10.13.
2323         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2324           and OTHER_CPLUSPLUSFLAGS.
2325         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2326           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2327         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2328           LaunchServices header.
2329
2330 2019-01-11  John Wilander  <wilander@apple.com>
2331
2332         Compile out Web API Statistics Collection
2333         https://bugs.webkit.org/show_bug.cgi?id=193370
2334         <rdar://problem/45388584>
2335
2336         Reviewed by Brent Fulgham.
2337
2338         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2339             Defined ENABLE_WEB_API_STATISTICS, off by default.
2340
2341 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2342
2343         [WPE] Add gtk-doc
2344         https://bugs.webkit.org/show_bug.cgi?id=178900
2345
2346         Reviewed by Michael Catanzaro.
2347
2348         Add Tools/gtkdoc to manifest.txt.in files.
2349         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
2350
2351         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
2352         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
2353
2354 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2355
2356         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
2357         https://bugs.webkit.org/show_bug.cgi?id=193364
2358         <rdar://problem/47214117>
2359
2360         Reviewed by Tim Horton.
2361
2362         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
2363         precise, whereas dragging near the middle of the textarea does.
2364
2365         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2366         (TestWebKitAPI::TEST):
2367
2368 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2369
2370         webkitpy: Support alternate simctl device list output
2371         https://bugs.webkit.org/show_bug.cgi?id=193362
2372         <rdar://problem/47122965>
2373
2374         Reviewed by Lucas Forschler.
2375
2376         * Scripts/webkitpy/xcode/simulated_device.py:
2377         (SimulatedDeviceManager.populate_available_devices):
2378
2379 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
2380
2381         [ews-build] Update macOS queue configurations
2382         https://bugs.webkit.org/show_bug.cgi?id=193365
2383
2384         Reviewed by Lucas Forschler.
2385
2386         * BuildSlaveSupport/ews-build/config.json:
2387
2388 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2389
2390         webkitpy: Incorporate device type into baseline search path
2391         https://bugs.webkit.org/show_bug.cgi?id=193356
2392         <rdar://problem/47215515>
2393
2394         Reviewed by Lucas Forschler.
2395
2396         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
2397
2398         * Scripts/webkitpy/port/base.py:
2399         (Port.default_baseline_search_path): Allow device type to be passed in.
2400         * Scripts/webkitpy/port/gtk.py:
2401         (GtkPort.default_baseline_search_path): Ignore device type.
2402         * Scripts/webkitpy/port/ios.py:
2403         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
2404         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
2405         * Scripts/webkitpy/port/ios_device_unittest.py:
2406         (IOSDeviceTest):
2407         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2408         (IOSSimulatorTest):
2409         * Scripts/webkitpy/port/mac.py:
2410         (MacPort.default_baseline_search_path): Ignore device type.
2411         * Scripts/webkitpy/port/watch.py:
2412         (WatchPort.default_baseline_search_path): Ditto.
2413         * Scripts/webkitpy/port/win.py:
2414         (WinPort.default_baseline_search_path): Ditto.
2415         (WinCairoPort.default_baseline_search_path): Ditto.
2416         * Scripts/webkitpy/port/wpe.py:
2417         (WPEPort.default_baseline_search_path): Ditto.
2418
2419 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2420
2421         webkitpy: Print abbreviated baseline search path that includes only folders that exist
2422         https://bugs.webkit.org/show_bug.cgi?id=193352
2423         <rdar://problem/47210736>
2424
2425         Reviewed by Lucas Forschler.
2426
2427         * Scripts/webkitpy/layout_tests/views/printing.py:
2428         (Printer.print_config): Print list on only baseline search paths which exist. 
2429         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2430         (Testprinter.test_print_config):
2431
2432 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
2433
2434         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
2435         https://bugs.webkit.org/show_bug.cgi?id=193340
2436
2437         Reviewed by David Kilzer.
2438
2439         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2440         (WTR::InjectedBundle::didReceiveMessageToPage):
2441         Pull the strings out into a WKRetainPtr.
2442
2443         * WebKitTestRunner/WebNotificationProvider.cpp:
2444         (WTR::WebNotificationProvider::closeWebNotification):
2445         Adopt the created value into the WKRetainPtr.
2446
2447         * WebKitTestRunner/mac/TestControllerMac.mm:
2448         (WTR::generateWhitelist):
2449         Immediately adopt a created value to avoid potential mistakes.
2450
2451 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
2452
2453         Enable DFG on ARM/Linux again
2454         https://bugs.webkit.org/show_bug.cgi?id=192496
2455
2456         Reviewed by Yusuke Suzuki.
2457
2458         After changing the bytecode format DFG was disabled on all 32-bit
2459         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2460         on ARM by default.
2461
2462         * Scripts/run-jsc-stress-tests:
2463
2464 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2465
2466         Unreviewed, fix #ifdef in API test added in r239851.
2467         https://bugs.webkit.org/show_bug.cgi?id=193327
2468         rdar://problem/47093222
2469
2470         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2471
2472 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2473
2474         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2475         https://bugs.webkit.org/show_bug.cgi?id=193109
2476         <rdar://problem/44807048>
2477
2478         Reviewed by Ryosuke Niwa.
2479
2480         Introduce and respect a test option to enable the UndoManager API.
2481
2482         * WebKitTestRunner/TestController.cpp:
2483         (WTR::updateTestOptionsFromTestHeader):
2484         * WebKitTestRunner/TestOptions.h:
2485         (WTR::TestOptions::hasSameInitializationOptions const):
2486         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2487         (WTR::TestController::platformCreateWebView):
2488
2489 2019-01-11  Zalan Bujtas  <zalan@apple.com>
2490
2491         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
2492         https://bugs.webkit.org/show_bug.cgi?id=193346
2493
2494         Reviewed by Antti Koivisto.
2495
2496         * LayoutReloaded/misc/LFC-passing-tests.txt:
2497
2498 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2499
2500         Unreviewed, fix typo that breaks dashboard link.
2501
2502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2503         (WebKitBuildbot):
2504
2505 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2506
2507         Update macOS queue configurations
2508         https://bugs.webkit.org/show_bug.cgi?id=193329
2509
2510         Reviewed by Alexey Proskuryakov.
2511
2512         * BuildSlaveSupport/build.webkit.org-config/config.json:
2513         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2514         (BubbleQueueServer):
2515         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2516         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2517         (WebKitBuildbot):
2518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2519         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2520         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2521
2522 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2523
2524         MiniBrowser should be able to navigate to about:blank
2525         https://bugs.webkit.org/show_bug.cgi?id=193345
2526
2527         Reviewed by Simon Fraser.
2528
2529         * MiniBrowser/mac/BrowserWindowController.m:
2530         (-[BrowserWindowController addProtocolIfNecessary:]):
2531         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2532
2533         * MiniBrowser/mac/WK1BrowserWindowController.m:
2534         (-[WK1BrowserWindowController fetch:]):
2535         * MiniBrowser/mac/WK2BrowserWindowController.m:
2536         (-[WK2BrowserWindowController fetch:]):
2537         Clean up the code that uses this to match style.
2538
2539 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2540
2541         Remove MiniBrowser custom "Process Swap" menu item which does not work
2542         https://bugs.webkit.org/show_bug.cgi?id=193344
2543
2544         Reviewed by Simon Fraser.
2545
2546         There is a menu item under the Experimental menu that does work.
2547
2548         * MiniBrowser/mac/AppDelegate.m:
2549         (defaultConfiguration):
2550         * MiniBrowser/mac/SettingsController.h:
2551         * MiniBrowser/mac/SettingsController.m:
2552         (-[SettingsController _populateMenu]):
2553         (-[SettingsController validateMenuItem:]):
2554         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2555         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2556
2557 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2558
2559         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2560         https://bugs.webkit.org/show_bug.cgi?id=193327
2561         rdar://problem/47093222
2562
2563         Reviewed by Tim Horton.
2564
2565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2566         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2567         (TestWebKitAPI::didFinishNavigation):
2568         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2569         (TestWebKitAPI::TEST):
2570         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2571         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2572         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2573         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2574         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2575
2576 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2577
2578         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2579         https://bugs.webkit.org/show_bug.cgi?id=193338
2580         <rdar://problem/46664774>
2581
2582         Reviewed by David Kilzer.
2583
2584         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2585         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2586
2587 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2588
2589         Unreviewed, rolling out r239825.
2590         https://bugs.webkit.org/show_bug.cgi?id=193330
2591
2592         Broke tests on armv7/linux bots (Requested by guijemont on
2593         #webkit).
2594
2595         Reverted changeset:
2596
2597         "Enable DFG on ARM/Linux again"
2598         https://bugs.webkit.org/show_bug.cgi?id=192496
2599         https://trac.webkit.org/changeset/239825
2600
2601 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2602
2603         Disable the run-jsc-stress-test remote host key check.
2604         https://bugs.webkit.org/show_bug.cgi?id=192988
2605
2606         Reviewed by Alexey Proskuryakov.
2607
2608         * Scripts/run-jsc-stress-tests:
2609
2610 2019-01-10  John Wilander  <wilander@apple.com>
2611
2612         Override the session configuration for cookieAcceptPolicy
2613         https://bugs.webkit.org/show_bug.cgi?id=190925
2614         <rdar://problem/45497382>
2615
2616         Reviewed by Alexey Proskuryakov and Alex Christensen.
2617
2618         Test infrastructure for setting a first-party-only cookie policy.
2619
2620         * DumpRenderTree/TestRunner.cpp:
2621         (setOnlyAcceptFirstPartyCookiesCallback):
2622         (TestRunner::staticFunctions):
2623         * DumpRenderTree/TestRunner.h:
2624         * DumpRenderTree/mac/TestRunnerMac.mm:
2625         (TestRunner::setOnlyAcceptFirstPartyCookies):
2626         * DumpRenderTree/win/TestRunnerWin.cpp:
2627         (TestRunner::setOnlyAcceptFirstPartyCookies):
2628         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2629         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2630         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2631         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2632         * WebKitTestRunner/TestInvocation.cpp:
2633         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2634
2635 2019-01-09  Matt Rajca  <mrajca@apple.com>
2636
2637         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2638         https://bugs.webkit.org/show_bug.cgi?id=193301
2639
2640         Reviewed by Jer Noble.
2641         
2642         Added API tests.
2643
2644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2645         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2646         (TEST):
2647         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2648
2649 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2650
2651         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2652         https://bugs.webkit.org/show_bug.cgi?id=193310
2653
2654         Reviewed by Antti Koivisto.
2655
2656         * LayoutReloaded/misc/LFC-passing-tests.txt:
2657
2658 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2659
2660         Enable DFG on ARM/Linux again
2661         https://bugs.webkit.org/show_bug.cgi?id=192496
2662
2663         Reviewed by Yusuke Suzuki.
2664
2665         After changing the bytecode format DFG was disabled on all 32-bit
2666         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2667         on ARM by default.
2668
2669         * Scripts/run-jsc-stress-tests:
2670
2671 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2672
2673         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2674         https://bugs.webkit.org/show_bug.cgi?id=193271
2675
2676         Reviewed by Brent Fulgham.
2677
2678         BSTR is a special data structure created by SysAllocString, not a
2679         wchar_t null-terminated string.
2680
2681         * DumpRenderTree/win/TestRunnerWin.cpp:
2682         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2683         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2684         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2685         BSTR from wide string literals.
2686
2687 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2688
2689         Tweak wording for build/version_check style checker error
2690         https://bugs.webkit.org/show_bug.cgi?id=193256
2691
2692         Reviewed by Tim Horton.
2693
2694         * Scripts/webkitpy/style/checkers/cpp.py:
2695         (check_os_version_checks):
2696         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2697         (WebKitStyleTest.test_os_version_checks):
2698
2699 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2700
2701         [ews-build] Add link to bug along with bug title
2702         https://bugs.webkit.org/show_bug.cgi?id=193293
2703
2704         Reviewed by Lucas Forschler.
2705
2706         * BuildSlaveSupport/ews-build/steps.py:
2707         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2708         (ConfigureBuild.add_bug_id_url): Deleted.
2709         (ConfigureBuild.getBugURL): Deleted.
2710
2711 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2712
2713         [ews-build] Use https for ews-build server
2714         https://bugs.webkit.org/show_bug.cgi?id=193193
2715
2716         Reviewed by Lucas Forschler.
2717
2718         * BuildSlaveSupport/ews-build/steps.py:
2719
2720 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2721
2722         [ews-build] Parse and display number of style failures
2723         https://bugs.webkit.org/show_bug.cgi?id=193280
2724
2725         Reviewed by Lucas Forschler.
2726
2727         * BuildSlaveSupport/ews-build/steps.py:
2728         (CheckStyle): Use TestWithFailureCount as base class.
2729         (CheckStyle.countFailures): Count the number of style failures.
2730
2731 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2732
2733         [ews-build] use patch_id instead of ewspatchid
2734         https://bugs.webkit.org/show_bug.cgi?id=193235
2735
2736         Reviewed by Lucas Forschler.
2737
2738         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2739         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2740         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2741
2742 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2743
2744         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2745         https://bugs.webkit.org/show_bug.cgi?id=192625
2746
2747         Reviewed by Antti Koivisto.
2748
2749         * LayoutReloaded/misc/LFC-passing-tests.txt:
2750
2751 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2752
2753         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2754         https://bugs.webkit.org/show_bug.cgi?id=192841
2755
2756         Reviewed by Carlos Garcia Campos.
2757
2758         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2759         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2760         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2761
2762         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2763
2764         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2765         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2766         (WebKitWebEditorTest::testSelectionChanged):
2767         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2768         (WebKitFrameTest::testMainFrame):
2769         (WebKitFrameTest::testURI):
2770         (WebKitFrameTest::testJavaScriptContext):
2771         (WebKitFrameTest::testJavaScriptValues):
2772         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2773         (testWebViewAuthenticationRequest):
2774         (testWebViewAuthenticationLoadCancelled):
2775         (testWebViewAuthenticationFailure):
2776         (testWebViewAuthenticationStorage):
2777         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2778         (testWebViewAuthenticationProxy):
2779         (testWebViewAuthenticationProxyHTTPS):
2780         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2781         (testAutomationSessionRequestSession):
2782         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2783         (testBackForwardListNavigation):
2784         (testWebKitWebViewSessionState):
2785         (testWebKitWebViewSessionStateWithFormData):
2786         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2787         (ConsoleMessageTest::consoleMessageReceivedCallback):
2788         (testWebKitConsoleMessageConsoleAPI):
2789         (testWebKitConsoleMessageJavaScriptException):
2790         (testWebKitConsoleMessageNetworkError):
2791         (testWebKitConsoleMessageSecurityError):
2792         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2793         (testCookieManagerAcceptPolicy):
2794         (testCookieManagerCookiesChanged):
2795         (testCookieManagerPersistentStorage):
2796         (testCookieManagerPersistentStorageDeleteAll):
2797         (testCookieManagerEphemeral):
2798         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2799         (testWebKitDOMElementAutoFill):
2800         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2801         (downloadLocalFileSuccessfully):
2802         (createFileAtDestination):
2803         (testDownloadOverwriteDestinationDisallowed):
2804         (testDownloadLocalFileError):
2805         (testDownloadRemoteFile):
2806         (testDownloadRemoteFileError):
2807         (testWebViewDownloadURI):
2808         (testPolicyResponseDownload):
2809         (testPolicyResponseDownloadCancel):
2810         (testDownloadMIMEType):
2811         (contextMenuCallback):
2812         (testContextMenuDownloadActions):
2813         (testBlobDownload):
2814         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2815         (testWebKitWebEditorSelectionChanged):
2816         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2817         (testWebKitFrameMainFrame):
2818         (testWebKitFrameURI):
2819         (testWebKitFrameJavaScriptContext):
2820         (testWebKitFrameJavaScriptValues):
2821         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2822         (LoadStopTrackingTest::loadFailed):
2823         (testWebViewTitle):
2824         (testURIRequestHTTPHeaders):
2825         (testURIRequestHTTPMethod):
2826         (testURIResponseHTTPHeaders):
2827         (testRedirectToDataURI):
2828         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2829         (testProcessPerWebView):
2830         (testWebProcessLimit):
2831         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2832         (testWebViewResources):
2833         (testWebResourceLoading):
2834         (testWebResourceSuggestedFilename):
2835         (testWebResourceGetData):
2836         (testWebResourceGetDataError):
2837         (testWebViewResourcesHistoryCache):
2838         (testWebResourceSendRequest):
2839         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2840         (testSSL):
2841         (testInsecureContent):
2842         (testTLSErrorsPolicy):
2843         (testTLSErrorsRedirect):
2844         (testTLSErrorsHTTPAuth):
2845         (testLoadFailedWithTLSErrors):
2846         (testSubresourceLoadFailedWithTLSErrors):
2847         (httpsServerCallback):
2848         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2849         (testWebViewCreateNavigationData):
2850         (testWebViewJavaScriptDialogs):
2851         (testWebViewWindowProperties):
2852         (testWebViewMouseTarget):
2853         (testWebViewFileChooserRequest):
2854         (testWebViewColorChooserRequest):
2855         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2856         (testWebExtensionGetTitle):
2857         (testDocumentLoadedSignal):
2858         (testWebKitWebViewProcessCrashed):
2859         (testWebExtensionWindowObjectCleared):
2860         (testWebExtensionIsolatedWorld):
2861         (permissionRequestCallback):
2862         (didAssociateFormControlsCallback):
2863         (testWebExtensionFormControlsAssociated):
2864         (FormSubmissionTest::FormSubmissionTest):
2865         (FormSubmissionTest::testFormSubmissionResult):
2866         (testWebExtensionFormSubmissionSteps):
2867         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2868         (testNotInitialized):
2869         (testClearDatabase):
2870         (testPrivateBrowsing):
2871         (testGetFavicon):
2872         (testWebViewFavicon):
2873         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2874         (testFindControllerTextFound):
2875         (testFindControllerTextNotFound):
2876         (testFindControllerMatchCount):
2877         (testFindControllerMaxMatchCount):
2878         (testFindControllerNext):
2879         (testFindControllerPrevious):
2880         (testFindControllerCountedMatches):
2881         (testFindControllerOptions):
2882         (testFindControllerHide):
2883         (testFindControllerInstance):
2884         (testFindControllerGetters):
2885         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2886         (testNavigationPolicy):
2887         (testResponsePolicy):
2888         (testNewWindowPolicy):
2889         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2890         (testSecurityOriginBasicConstructor):
2891         (testSecurityOriginURIConstructor):
2892         (testSecurityOriginDefaultPort):
2893         (testSecurityOriginFileURI):
2894         (testOpaqueSecurityOrigin):
2895         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2896         (testWebKitSettings):
2897         (testWebKitSettingsNewWithSettings):
2898         (testWebKitSettingsUserAgent):
2899         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2900         (testWebViewNewWithUserContentManager):
2901         (isStyleSheetInjectedForURLAtPath):
2902         (isScriptInjectedForURLAtPath):
2903         (testUserContentManagerInjectedStyleSheet):
2904         (testUserContentManagerInjectedScript):
2905         (UserScriptMessageTest::scriptMessageReceived):
2906         (UserScriptMessageTest::waitUntilMessageReceived):
2907         (UserScriptMessageTest::runJavaScriptFinished):
2908         (testUserContentManagerScriptMessageReceived):
2909         (testUserContentManagerScriptMessageInWorldReceived):
2910         (testUserContentManagerScriptMessageFromDOMBindings):
2911         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2912         (testWebContextDefault):
2913         (testWebContextEphemeral):
2914         (testWebContextGetPlugins):
2915         (testWebContextURIScheme):
2916         (testWebContextSpellChecker):
2917         (testWebContextLanguages):
2918         (consoleMessageReceivedCallback):
2919         (testWebContextSecurityFileXHR):
2920         (ProxyTest::ProxyTest):
2921         (testWebContextProxySettings):
2922         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2923         (testWebViewWebContext):
2924         (testWebViewWebBackend):
2925         (testWebViewEphemeral):
2926         (testWebViewCustomCharset):
2927         (testWebViewSettings):
2928         (testWebViewRunJavaScript):
2929         (testWebViewCanShowMIMEType):
2930         (testWebViewSubmitForm):
2931         (testWebViewSave):
2932         (testWebViewPageVisibility):
2933         (testWebViewSnapshot):
2934         (testWebViewNotification):
2935         (testWebViewNotificationInitialPermissionAllowed):
2936         (testWebViewNotificationInitialPermissionDisallowed):
2937         (testWebViewIsPlayingAudio):
2938         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2939         (WebsiteDataTest::WebsiteDataTest):
2940         (WebsiteDataTest::remove):
2941         (WebsiteDataTest::clear):
2942         (testWebsiteDataConfiguration):
2943         (testWebsiteDataEphemeral):
2944         (testWebsiteDataCache):
2945         (testWebsiteDataStorage):
2946         (testWebsiteDataDatabases):
2947         (testWebsiteDataAppcache):
2948         (testWebsiteDataCookies):
2949         (testWebsiteDataDeviceIdHashSalt):
2950         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2951         (emitDocumentLoaded):
2952         (emitURIChanged):
2953         (sendRequestCallback):
2954         (contextMenuCallback):
2955         (consoleMessageSentCallback):
2956         (emitFormControlsAssociated):
2957         (formControlsAssociatedCallback):
2958         (emitFormSubmissionEvent):
2959         (willSubmitFormCallback):
2960         (windowObjectCleared):
2961         (methodCallCallback):
2962         (registerGResource):
2963         (webkit_web_extension_initialize_with_user_data):
2964         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2965         (checkLeaks):
2966         (WebProcessTest::create):
2967         (runTest):
2968         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2969         (AutocleanupsTest::testWebProcessAutocleanups):
2970         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2971         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2972         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2973         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2974         (WebKitDOMDOMWindowTest::testSignals):
2975         (WebKitDOMDOMWindowTest::testDispatchEvent):
2976         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2977         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2978         (WebKitDOMNodeFilterTest::testTreeWalker):
2979         (WebKitDOMNodeFilterTest::testNodeIterator):
2980         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2981         (WebKitDOMNodeTest::testHierarchyNavigation):
2982         (WebKitDOMNodeTest::testInsertion):
2983         (WebKitDOMNodeTest::testTagNamesNodeList):
2984         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2985         (WebKitDOMNodeTest::testDOMCache):
2986         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2987         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2988         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2989         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2990         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2991         (testUIProcessAutocleanups):
2992         (testWebProcessAutocleanups):
2993         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2994         (testContextMenuPopulateMenu):
2995         (testContextMenuDismissed):
2996         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2997         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2998         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2999         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
3000         (testWebKitDOMDOMWindowSignals):
3001         (testWebKitDOMDOMWindowDispatchEvent):
3002         (testWebKitDOMDOMWindowGetComputedStyle):
3003         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
3004         (testWebKitDOMNodeHierarchyNavigation):
3005         (testWebKitDOMNodeInsertion):
3006         (testWebKitDOMNodeTagNamesNodeList):
3007         (testWebKitDOMNodeTagNamesHTMLCollection):
3008         (testWebKitDOMObjectCache):
3009         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
3010         (testWebKitDOMNodeFilterTreeWalker):
3011         (testWebKitDOMNodeFilterNodeIterator):
3012         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
3013         (testWebKitDOMXPathNSResolverNative):
3014         (testWebKitDOMXPathNSResolverCustom):
3015         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
3016         (testInspectorDefault):
3017         (testInspectorManualAttachDetach):
3018         (testInspectorCustomContainerDestroyed):
3019         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
3020         (startTestServer):
3021         (testInspectorServerPageList):
3022         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
3023         (OptionMenuTest::showOptionMenuCallback):
3024         (OptionMenuTest::menuCloseCallback):
3025         (OptionMenuTest::close):
3026         (OptionMenuTest::activateItem):
3027         (OptionMenuTest::selectItem):
3028         (testOptionMenuSimple):
3029         (testOptionMenuGroups):
3030         (testOptionMenuActivate):
3031         (testOptionMenuSelect):
3032         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
3033         (testPrintOperationPrintSettings):
3034         (webViewPrintCallback):
3035         (testPrintOperationPrint):
3036         (testPrintCustomWidget):
3037         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3038         (checkAtspiAccessible):
3039         (testAtspiBasicHierarchy):
3040         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
3041         (testWebKitCheckVersion):
3042         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
3043         (testWebViewEditorCutCopyPasteNonEditable):
3044         (testWebViewEditorCutCopyPasteEditable):
3045         (testWebViewEditorSelectAllNonEditable):
3046         (testWebViewEditorSelectAllEditable):
3047         (loadContentsAndTryToCutSelection):
3048         (testWebViewEditorNonEditable):
3049         (testWebViewEditorEditable):
3050         (testWebViewEditorEditorStateTypingAttributes):
3051         (testWebViewEditorInsertImage):
3052         (testWebViewEditorCreateLink):
3053         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3054         (loadChangedCallback):
3055         (loadFailedCallback):
3056         (loadFailedWithTLSErrorsCallback):
3057         (LoadTrackingTest::LoadTrackingTest):
3058         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3059         (registerGResource):
3060         (removeNonEmptyDirectory):
3061         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3062         (Test::adoptView):
3063         (Test::~Test):
3064         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3065         (WebKitTestBus::getOrCreateConnection):
3066         (WebKitTestBus::createProxy):
3067         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
3068         (WebKitTestServer::getWebSocketURIForPath const):
3069         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3070         (WebViewTest::initializeWebView):
3071         (WebViewTest::loadURI):
3072         (WebViewTest::loadHtml):
3073         (WebViewTest::loadPlainText):
3074         (WebViewTest::loadBytes):
3075         (WebViewTest::loadRequest):
3076         (WebViewTest::loadAlternateHTML):
3077         (WebViewTest::goBack):
3078         (WebViewTest::goForward):
3079         (WebViewTest::goToBackForwardListItem):
3080         (resourceGetDataCallback):
3081         (WebViewTest::mainResourceData):
3082         (WebViewTest::javascriptResultToCString):
3083         (WebViewTest::javascriptResultToNumber):
3084         (WebViewTest::javascriptResultToBoolean):
3085         (WebViewTest::javascriptResultIsNull):
3086         (WebViewTest::javascriptResultIsUndefined):
3087         (onSnapshotReady):
3088         (WebViewTest::runWebProcessTest):
3089         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
3090         (WebViewTest::platformInitializeWebView):
3091         (WebViewTest::showInWindow):
3092         (WebViewTest::showInWindowAndWaitUntilMapped):
3093         (WebViewTest::mouseMoveTo):
3094         (WebViewTest::emitPopupMenuSignal):
3095         (WebViewTest::keyStroke):
3096         (WebViewTest::doMouseButtonEvent):
3097
3098 2019-01-09  Philippe Normand  <pnormand@igalia.com>
3099
3100         [WPE] API tests can't run in flatpak environment
3101         https://bugs.webkit.org/show_bug.cgi?id=193242
3102
3103         Reviewed by Michael Catanzaro.
3104
3105         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
3106         flatpakutils so that it knows which port it's dealing with.
3107         * glib/common.py: Remove build_dir globals so that subsequent
3108         calls actually take args into account.
3109         (library_build_path):
3110         (binary_build_path):
3111
3112 2019-01-08  Dean Jackson  <dino@apple.com>
3113
3114         Blob references for System Previews don't get a correct file extension
3115         https://bugs.webkit.org/show_bug.cgi?id=193268
3116         <rdar://problem/47133037>
3117
3118         Reviewed by Tim Horton.
3119
3120         New test that a Blob download of a USDZ file gets named correctly.
3121
3122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3123         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3124         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3125         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
3126         (TEST):
3127         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
3128
3129 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
3130
3131         [WebAuthN] Support U2F HID Authenticators on macOS
3132         https://bugs.webkit.org/show_bug.cgi?id=191535
3133         <rdar://problem/47102027>
3134
3135         Reviewed by Brent Fulgham.
3136
3137         This patch:
3138         1) adds support for U2F mocking mechanism;
3139         2) updates tests to reflect U2fCommandConstructor changes.
3140
3141         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3142         (TestWebKitAPI::TEST):
3143         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3144         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3145         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3146
3147 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3148
3149         [iOS] Dispatch a synthetic mousedown event prior to starting drags
3150         https://bugs.webkit.org/show_bug.cgi?id=193229
3151         <rdar://problem/46717097>
3152
3153         Reviewed by Tim Horton.
3154
3155         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
3156         prevents a drag from starting.
3157
3158         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3159         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
3160
3161         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
3162
3163 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
3164   
3165         Layout test will generate a perf metric file to results dir.
3166         https://bugs.webkit.org/show_bug.cgi?id=192030
3167         <rdar://problem/32779516>
3168
3169         Reviewed by Aakash Jain.
3170
3171         Layout test running time will be collected to a perf metric file.
3172         For now, instead of outputing running time of all tests (which is huge),
3173         we aggregate them by test directories which are at most two level deep. 
3174
3175         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3176         (Manager._end_test_run):
3177         (Manager._output_perf_metrics):
3178         (Manager._print_expectation_line_for_test):
3179         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3180         (add_test_perf_metric):
3181         (test_perf_metrics):
3182         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3183         (JSONGeneratorTest.test_test_timings_trie):
3184         (JSONGeneratorTest):
3185         (JSONGeneratorTest.test_test_perf_metrics):
3186         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3187         (RebaselineTest.test_reset_results):
3188         (RebaselineTest.test_missing_results):
3189         (RebaselineTest.test_new_baseline):
3190
3191 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
3192
3193         [WPE][GTK] Add php-json to install-dependencies
3194         https://bugs.webkit.org/show_bug.cgi?id=193233
3195
3196         Reviewed by Michael Catanzaro.
3197
3198         * gtk/install-dependencies:
3199         * wpe/install-dependencies:
3200
3201 2019-01-08  Chris Dumez  <cdumez@apple.com>
3202
3203         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
3204         https://bugs.webkit.org/show_bug.cgi?id=193224
3205         <rdar://problem/47097726>
3206
3207         Reviewed by Alex Christensen.
3208
3209         Add API test coverage.
3210
3211         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3212
3213 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3214
3215         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
3216         <https://webkit.org/b/193222>
3217         <rdar://problem/46862309>
3218
3219         Reviewed by Joseph Pecoraro.
3220
3221         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3222         (WTR::executeCallback): Fix camel case of variable name.
3223         (WTR::EventSendingController::callAfterScrollingCompletes): If
3224         WKBundlePageRegisterScrollOperationCompletionCallback() returns
3225         false, make sure to release the ScrollCompletionCallbackData
3226         object.  This fixes the leak.
3227
3228 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3229
3230         [Win] EWS: wincairo-ews cannot apply a patch with *.png
3231         https://bugs.webkit.org/show_bug.cgi?id=193044
3232
3233         Reviewed by Daniel Bates.
3234
3235         WinCairo EWS bots are using Windows Perl. Binary files should be
3236         opened as binary mode.
3237
3238         * Scripts/svn-apply:
3239         (handleGitBinaryChange): Use 'binmode' for binary file handles.
3240
3241 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
3242
3243         [CMake] Add ENABLE_CSS_TYPED_OM option
3244         https://bugs.webkit.org/show_bug.cgi?id=193216
3245
3246         Reviewed by Michael Catanzaro.
3247
3248         * Scripts/webkitperl/FeatureList.pm:
3249
3250 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3251
3252         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
3253         <https://webkit.org/b/193056>
3254
3255         Reviewed by Alex Christensen.
3256
3257         * Scripts/webkitpy/style/checker.py:
3258         - Ignore use of new runtime/retainptr check in
3259           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
3260           contains tests to ensure RetainPtr<NSObject *> is compatible
3261           with RetainPtr<NSObject>.
3262
3263         * Scripts/webkitpy/style/checkers/cpp.py:
3264         (check_language):
3265         (CppChecker):
3266         - Add checker for use of '*' in RetainPtr<> type.  A for loop
3267           was used instead of a single regex so that angle brackets
3268           could be matched up when checking the type contained within
3269           the RetainPtr<> type.
3270
3271         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3272         (CppStyleTest):
3273         - Add unit test for new runtime/retainptr check.
3274
3275         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
3276         * TestWebKitAPI/EditingTestHarness.h:
3277         - Remove '*' from RetainPtr<> type.
3278
3279         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3280         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
3281           regressed in r201938.
3282
3283         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3284         (TestWebKitAPI::TEST):
3285         - Update tests to match RetainPtr.mm tests (except for the
3286           `*SimilarNSType` tests since there is no CF equivalent of
3287           RetainPtr<NSString> and RetainPtr<NSString *>).
3288
3289         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3290         (TestWebKitAPI::TEST):
3291         - Update tests to:
3292           - Not conflict by name with equivalent CF tests in
3293             RetainPtr.cpp.
3294           - Add test cases for RetainPtr<NSObject>,
3295             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
3296           - Add `*SimilarNSType` tests for converting between
3297             RetainPtr<NSObject> and RetainPtr<NSObject *>.
3298           - Change `0` to `nil` as appropriate.
3299           - Re-alphabetize the tests by name.
3300           - Add Optional<RetainPtr<>> tests.
3301           - Add retainPtr() tests.
3302
3303         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3304         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3305         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
3306         (TEST):
3307         - Remove '*' from RetainPtr<> type.
3308
3309         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
3310         (TEST(WebKit, JITEnabled)):
3311         - Add missing WTFMove().  Apparently a temporary was being
3312           created before in the argument list due to mismatched
3313           RetainPtr<> types.
3314
3315         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3316         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
3317         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
3318         (TestWebKitAPI::TEST):
3319         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3320         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3321         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3322         (WTR::resourcesDirectoryURL):
3323         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3324         (WTR::InjectedBundle::platformInitialize):
3325         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3326         - Remove '*' from RetainPtr<> type.
3327
3328 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
3329
3330         A MediaTime timescale must never be zero
3331         https://bugs.webkit.org/show_bug.cgi?id=193156
3332         <rdar://problem/32504501>
3333
3334         Reviewed by Jer Noble.
3335
3336         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3337         (TestWebKitAPI::TEST): Add tests for zero timescale.
3338
3339 2019-01-07  Youenn Fablet  <youenn@apple.com>
3340
3341         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
3342         https://bugs.webkit.org/show_bug.cgi?id=193175
3343
3344         Reviewed by Chris Dumez.
3345
3346         Updated API test as we bumped the SW schema to version 4.
3347
3348         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3349         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
3350         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3351         (TEST):
3352
3353 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3354
3355         [Win][Clang] Fix compilation warnings of MiniBrowser
3356         https://bugs.webkit.org/show_bug.cgi?id=193029
3357
3358         Reviewed by Ross Kirsling.
3359
3360         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
3361         and m_URLBarFont. Reorder member variables to fix -Wreorder
3362         warning.
3363         * MiniBrowser/win/PageLoadTestClient.cpp:
3364         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
3365         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
3366         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
3367         m_currentURLIndex.
3368         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3369         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
3370         navigationClient with '{ }' to fix the missing field warning.
3371         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3372         (initDocStruct): Changed the argument type docname to const.
3373
3374 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
3375
3376         [WebAuthN] Import U2F command/response converters from Chromium
3377         https://bugs.webkit.org/show_bug.cgi?id=193150
3378         <rdar://problem/47054028>
3379
3380         Reviewed by Brent Fulgham.
3381
3382         Adds API tests.
3383
3384         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3385         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3386         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
3387         (TestWebKitAPI::getTestAuthenticatorDataBytes):
3388         (TestWebKitAPI::getTestAttestationObjectBytes):
3389         (TestWebKitAPI::getTestSignResponse):
3390         (TestWebKitAPI::getTestU2fRegisterResponse):
3391         (TestWebKitAPI::TEST):
3392         (TestWebKitAPI::convertToVector): Deleted.
3393         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3394         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
3395         (TestWebKitAPI::constructMakeCredentialRequest):
3396         (TestWebKitAPI::constructGetAssertionRequest):
3397         (TestWebKitAPI::TEST):
3398
3399 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
3400
3401         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
3402         https://bugs.webkit.org/show_bug.cgi?id=193136
3403
3404         Reviewed by Michael Catanzaro.
3405
3406         * gtk/install-dependencies:
3407         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
3408         they are needed by update-webkitgtk-libs.
3409
3410 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
3411
3412         Unreviewed follow-up fix to r239650
3413         https://bugs.webkit.org/show_bug.cgi?id=193140
3414         <rdar://problem/47063037>
3415
3416         Typecast patch_id to string.
3417
3418         * BuildSlaveSupport/ews-build/steps.py:
3419         (ValidatePatch._is_patch_obsolete):
3420
3421 2019-01-04  Daniel Bates  <dabates@apple.com>
3422
3423         [lldb-webkit]: Add support for pretty-printing raw bitmask types
3424         https://bugs.webkit.org/show_bug.cgi?id=193024
3425
3426         Reviewed by Jer Noble.
3427
3428         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
3429         for the bitmask type WebEventFlags as an example.
3430
3431         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
3432         that can be used to register summary and synthetic child formatters for a bitmask type.
3433         For example, consider the following enum and bitmask typedefs:
3434
3435         typedef enum {
3436             A = 1 << 0,
3437             B = 1 << 1,
3438             C = 1 << 2,
3439         } SpecialFlagValues;
3440         typedef unsigned SpecialFlags;
3441
3442         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
3443         __lldb_init_module():
3444
3445             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
3446                     1 << 0: "A",
3447                     1 << 1: "B",
3448                     1 << 2: "C",
3449             })
3450
3451         * lldb/lldb_webkit.py:
3452         (addSummaryAndSyntheticFormattersForRawBitmaskType):
3453         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
3454         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
3455         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
3456         A convenience function to dynamically creaste a synthetic formatter class and summary
3457         string function for the specified bitmask type and enumerator value to name map. This
3458         function register the dynamically created class and function with LLDB.
3459
3460         (__lldb_init_module):
3461         (FlagEnumerationProvider):
3462         (FlagEnumerationProvider._enumerator_value_to_name_map):
3463         (FlagEnumerationProvider._bitmask):
3464         (FlagEnumerationProvider._update):
3465         (FlagEnumerationProvider.has_children):
3466         (FlagEnumerationProvider.num_children):
3467         (FlagEnumerationProvider.get_child_index):
3468         (FlagEnumerationProvider.get_child_at_index):
3469         (FlagEnumerationProvider.update):
3470         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
3471
3472         (WTFOptionSetProvider):
3473         (WTFOptionSetProvider._enumerator_value_to_name_map):
3474         (WTFOptionSetProvider._bitmask):
3475         (WTFOptionSetProvider._update):
3476         Write in terms of the base class.
3477
3478         (RawBitmaskProviderBase):
3479         (RawBitmaskProviderBase._enumerator_value_to_name_map):
3480         (RawBitmaskProviderBase._bitmask):
3481         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
3482         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
3483         {
3484             1 << 0: "A",
3485             1 << 1: "B",
3486             1 << 2: "C",
3487         }
3488         It is not necessary to instantiate such a derived class directory. Instead use the convenience
3489         function addSummaryAndSyntheticFormattersForRawBitmaskType.
3490
3491         (WTFOptionSetProvider.has_children): Deleted.
3492         (WTFOptionSetProvider.num_children): Deleted.
3493         (WTFOptionSetProvider.get_child_index): Deleted.
3494         (WTFOptionSetProvider.get_child_at_index): Deleted.
3495         (WTFOptionSetProvider.update): Deleted.
3496
3497 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3498
3499         [ews-build] Add build step to validate the patch before processing it
3500         https://bugs.webkit.org/show_bug.cgi?id=193140
3501
3502         Reviewed by Lucas Forschler.
3503
3504         * BuildSlaveSupport/ews-build/factories.py:
3505         (Factory.__init__): Added ValidatePatch step.
3506         * BuildSlaveSupport/ews-build/steps.py:
3507         (ValidatePatch):
3508         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
3509         (ValidatePatch.get_patch_json): Get patch json data.
3510         (ValidatePatch.get_bug_json): Get bug json data.
3511         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
3512         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
3513         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
3514         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
3515         (ValidatePatch.skip_build): Skip the build.
3516         (ValidatePatch.start):
3517
3518 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3519
3520         Progress towards fixing Mac CMake build
3521         https://bugs.webkit.org/show_bug.cgi?id=193105
3522
3523         Reviewed by Don Olmstead.
3524
3525         * TestWebKitAPI/PlatformMac.cmake:
3526
3527 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3528
3529         Fix API test after r239631
3530         https://bugs.webkit.org/show_bug.cgi?id=193118
3531
3532         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3533         (TestWebKitAPI::TEST):
3534         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3535         Do the same thing via the API to fix the test.
3536
3537 2019-01-04  Jer Noble  <jer.noble@apple.com>
3538
3539         [WebKitLegacy] Media playback pauses on scroll
3540         https://bugs.webkit.org/show_bug.cgi?id=192829
3541
3542         Reviewed by Eric Carlson.
3543
3544         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3545         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3546         (TestWebKitAPI::TEST):
3547         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3548         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3549         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3550         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3551         (TestWebKitAPI::TEST):
3552
3553 2019-01-04  Chris Dumez  <cdumez@apple.com>
3554
3555         Add support for toggling device orientation API support per site
3556         https://bugs.webkit.org/show_bug.cgi?id=193143
3557         <rdar://problem/46605724>
3558
3559         Reviewed by Alex Christensen.
3560
3561         Add API test coverage.
3562
3563         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3564         (-[DataMappingSchemeHandler setTaskHandler:]):
3565         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3566         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3567         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3568         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3569
3570 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3571
3572         [ews-build] use svn-apply script to apply the patches
3573         https://bugs.webkit.org/show_bug.cgi?id=193138
3574
3575         Reviewed by Lucas Forschler.
3576
3577         * BuildSlaveSupport/ews-build/factories.py:
3578         (Factory.__init__): Add the ApplyPatch step.
3579         * BuildSlaveSupport/ews-build/steps.py:
3580         (CheckOutSource): Added step name.
3581         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3582         (ApplyPatch): Build step to apply patch using svn-apply script.
3583         (UnApplyPatchIfRequired):
3584         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3585
3586 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3587
3588         Deprecate WKContextCreate
3589         https://bugs.webkit.org/show_bug.cgi?id=193118
3590
3591         Reviewed by Brady Eidson.
3592
3593         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3594         (WebKitBrowserWindow::WebKitBrowserWindow):
3595         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3596         (TestWebKitAPI::TEST):
3597         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3598         (TestWebKitAPI::TEST):
3599         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3600         (TestWebKitAPI::TEST):
3601         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3602         (TestWebKitAPI::TEST):
3603         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3604         (TestWebKitAPI::TEST):
3605         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3606         (TestWebKitAPI::TEST):
3607         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3608         (TestWebKitAPI::TEST):
3609         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3610         (TestWebKitAPI::TEST):
3611         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3612         (TestWebKitAPI::TEST):
3613         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3614         (TestWebKitAPI::TEST):
3615         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3616         (TestWebKitAPI::TEST):
3617         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3618         (TestWebKitAPI::TEST):
3619         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3620         (TestWebKitAPI::TEST):
3621         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3622         (TestWebKitAPI::TEST):
3623         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3624         (TestWebKitAPI::TEST):
3625         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3626         (TestWebKitAPI::TEST):
3627         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3628         (TestWebKitAPI::TEST):
3629         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3630         (TestWebKitAPI::TEST):
3631         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3632         (TestWebKitAPI::loadAlternateHTMLString):
3633         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3634         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3635         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3636         (TestWebKitAPI::buildAndPerformTest):
3637         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3638         (TestWebKitAPI::TEST):
3639         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3640         (TestWebKitAPI::TEST):
3641         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3642         (TestWebKitAPI::TEST):
3643         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3644         (TestWebKitAPI::TEST):
3645         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3646         (TestWebKitAPI::TEST):
3647         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3648         (TestWebKitAPI::TEST):
3649         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3650         (TestWebKitAPI::TEST):
3651         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3652         (TestWebKitAPI::TEST):
3653         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3654         (TestWebKitAPI::TEST):
3655         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3656         (TestWebKitAPI::TEST):
3657         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3658         (TestWebKitAPI::TEST):
3659         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3660         (TestWebKitAPI::TEST):
3661         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3662         (TestWebKitAPI::TEST):
3663         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3664         (TestWebKitAPI::TEST):
3665         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3666         (TestWebKitAPI::TEST):
3667         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3668         (TestWebKitAPI::TEST):
3669         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3670         (TestWebKitAPI::TEST):
3671         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3672         (TestWebKitAPI::TEST):
3673         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3674         (TestWebKitAPI::TEST):
3675         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3676         (TestWebKitAPI::TEST):
3677         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3678         (TestWebKitAPI::TEST):
3679         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3680         (TestWebKitAPI::TEST):
3681         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3682         (TestWebKitAPI::TEST):
3683         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3684         (TestWebKitAPI::TEST):
3685         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3686         (TestWebKitAPI::TEST):
3687         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3688         (TestWebKitAPI::TEST):
3689         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3690         (WebKit2_CommandBackForwardTestWKView::SetUp):
3691         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3692         (TestWebKitAPI::TEST):
3693         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3694         (TestWebKitAPI::TEST):
3695         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3696         (TestWebKitAPI::TEST):
3697         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3698         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3699
3700 2019-01-03  Matt Rajca  <mrajca@apple.com>
3701
3702         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3703         https://bugs.webkit.org/show_bug.cgi?id=193128
3704         rdar://34554231
3705
3706         Reviewed by Jer Noble.
3707
3708         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3709         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3710         event along with a flag that indicates whether or not autoplay was actually prevented.
3711
3712         Tests: existing API tests were updated to reflect the new names. New API tests
3713         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3714
3715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3716         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3717         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3718         (TEST):
3719         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3720         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3721
3722 2019-01-04  Chris Dumez  <cdumez@apple.com>
3723
3724         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3725         https://bugs.webkit.org/show_bug.cgi?id=193120
3726
3727         Reviewed by Alex Christensen.
3728
3729         Add API test coverage.
3730
3731         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3732
3733 2019-01-04  Chris Dumez  <cdumez@apple.com>
3734
3735         Crash under WebProcessPool::addSuspendedPage()
3736         https://bugs.webkit.org/show_bug.cgi?id=193110
3737
3738         Reviewed by Youenn Fablet.
3739
3740         Add API test coverage.
3741
3742         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3743
3744 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3745
3746         [ews-build] Check patch relevance before applying the patch
3747         https://bugs.webkit.org/show_bug.cgi?id=193102
3748
3749         Reviewed by Lucas Forschler.
3750
3751         * BuildSlaveSupport/ews-build/factories.py:
3752         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3753
3754 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3755
3756         [ews-build] Check patch relevance step should print patch id
3757         https://bugs.webkit.org/show_bug.cgi?id=193137
3758
3759         Reviewed by Lucas Forschler.
3760
3761         * BuildSlaveSupport/ews-build/steps.py:
3762         (CheckPatchRelevance.start): Update the status to include patch id.
3763
3764 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3765
3766         webkitpy: Increase simulator teardown timeout
3767         https://bugs.webkit.org/show_bug.cgi?id=193141
3768         <rdar://problem/46174217>
3769
3770         Rubber-stamped by Aakash Jain.
3771
3772         * Scripts/webkitpy/xcode/simulated_device.py:
3773         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3774
3775 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3776
3777         test262-runner misbehaves when test file YAML has a trailing space
3778         https://bugs.webkit.org/show_bug.cgi?id=193053
3779
3780         Reviewed by Yusuke Suzuki.
3781
3782         * Scripts/test262/Runner.pm:
3783         (parseData):
3784         Accept trailing space when parsing a test file's YAML block.
3785
3786 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3787
3788         UserMedia test should use WKPageNavigationClient
3789         https://bugs.webkit.org/show_bug.cgi?id=192913
3790
3791         Reviewed by Youenn Fablet.
3792
3793         The test currently uses the deprecated WKPageLoaderClient. It should use
3794         WKPageNavigationClient instead, which provides the same callback under a similar name.
3795
3796         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3797         (TestWebKitAPI::TEST):
3798
3799 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3800
3801         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3802         https://bugs.webkit.org/show_bug.cgi?id=192944
3803
3804         Reviewed by Tim Horton.
3805
3806         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3807         (TestWebKitAPI::TEST):
3808
3809 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3810
3811         Add support for using the current text selection as the find string on iOS
3812         https://bugs.webkit.org/show_bug.cgi?id=193034
3813         <rdar://problem/45138739>
3814
3815         Reviewed by Tim Horton.
3816
3817         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3818         _setStringForFind) works as expected.
3819
3820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3821         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3822
3823 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3824
3825         [ews-build] Use git on OpenSource EWS bots
3826         https://bugs.webkit.org/show_bug.cgi?id=193092
3827
3828         Reviewed by Lucas Forschler.
3829
3830         * BuildSlaveSupport/ews-build/steps.py:
3831         (CheckOutSource): Use git instead of svn.
3832         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3833
3834 2019-01-02  Daniel Bates  <dabates@apple.com>
3835
3836         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3837         https://bugs.webkit.org/show_bug.cgi?id=193023
3838
3839         Reviewed by Simon Fraser.
3840
3841         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3842         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3843         enumerator values. We should just remove this code.
3844
3845         * lldb/lldb_webkit.py:
3846         (WTFOptionSetProvider.has_children):
3847         (WTFOptionSetProvider.num_children):
3848         (WTFOptionSetProvider.get_child_index):
3849         (WTFOptionSetProvider.get_child_at_index):
3850
3851 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3852
3853         .ycm_extra_conf.py should handle XXXInlines.h
3854         https://bugs.webkit.org/show_bug.cgi?id=193055
3855
3856         Reviewed by Carlos Garcia Campos.
3857
3858         compile_commands.json database only records flags and options for cpp source files.
3859         So, when we open headers, this database does not have any information for that.
3860         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3861         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3862         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3863         we attempt to find XXX.cpp and use the configuration if it exists.
3864
3865         * gtk/ycm_extra_conf.py:
3866         (getImplementationFilename):
3867         (FlagsForFile):
3868
3869 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3870
3871         Unreviewed. Support PHP 7.3 in Debian.
3872
3873         Add 7.3 to the list of php versions supported in Debian.
3874
3875         * Scripts/webkitpy/port/base.py:
3876         (Port._debian_php_version):
3877
3878 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3879
3880         Resurrect Mac CMake build
3881         https://bugs.webkit.org/show_bug.cgi?id=192658
3882
3883         Reviewed by Yusuke Suzuki.
3884
3885         * DumpRenderTree/PlatformMac.cmake:
3886         * MiniBrowser/mac/CMakeLists.txt:
3887         * TestWebKitAPI/PlatformMac.cmake:
3888
3889 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3890
3891         [Tools] Remove references to Bison and Flex
3892         https://bugs.webkit.org/show_bug.cgi?id=193033
3893
3894         Reviewed by Michael Catanzaro.
3895
3896         The Bison and Flex tools are not needed anymore since r209883.
3897
3898         * CygwinDownloader/cygwin-downloader.py:
3899         * EWSTools/ubuntu-ews-packages:
3900         * Scripts/filter-build-webkit:
3901         (shouldIgnoreLine):
3902         * gtk/install-dependencies:
3903         * wpe/install-dependencies:
3904
3905 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3906
3907         WebDriver: warn about non existing tests when parsing expectations
3908         https://bugs.webkit.org/show_bug.cgi?id=192979
3909
3910         Reviewed by Michael Catanzaro.
3911
3912         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3913         renamed.
3914
3915         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3916         (WebDriverTestRunner.__init__):
3917
3918 2018-12-21  Chris Dumez  <cdumez@apple.com>
3919
3920         navigator.userAgent in service workers does not reflect customUserAgent set by client
3921         https://bugs.webkit.org/show_bug.cgi?id=192951
3922
3923         Reviewed by Youenn Fablet.
3924
3925         Extend API test coverage.
3926
3927         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3928         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3929         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3930         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3931         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3932
3933 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3934
3935         [WebAuthN] userPresence should always be true
3936         https://bugs.webkit.org/show_bug.cgi?id=192835
3937         <rdar://problem/46538788>
3938
3939         Reviewed by Brent Fulgham.
3940
3941         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3942         (TestWebKitAPI::TEST):
3943
3944 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3945
3946         Add support to run-benchmark to use non-default copies of the browser apps
3947         https://bugs.webkit.org/show_bug.cgi?id=192905
3948         rdar://problem/46845840
3949
3950         Reviewed by Dewei Zhu.
3951         
3952         Add support for a --browser-path argument to run-benchmark, which allows you to use
3953         a custom app bundle for a given browser (only implemented for Safari at present).
3954
3955         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3956         (BenchmarkRunner.__init__):
3957         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3958         (BrowserDriver.__init__):
3959         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3960         (BrowserDriverFactory.create):
3961         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3962         (OSXBrowserDriver._launch_process):
3963         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3964         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3965         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3966         (OSXChromeCanaryDriver.launch_url):
3967         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3968         (OSXFirefoxNightlyDriver.launch_url):
3969         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3970         (OSXSafariDriver.__init__):
3971         (OSXSafariDriver.launch_url):
3972         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3973         (parse_args):
3974         (run_benchmark_plan):
3975         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3976         (WebServerBenchmarkRunner.__init__):
3977         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3978         (FakeBenchmarkRunner.__init__):
3979
3980 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3981
3982         [WebAuthN] Import an APDU coder from Chromium
3983         https://bugs.webkit.org/show_bug.cgi?id=192949
3984         <rdar://problem/46879933>
3985
3986         Reviewed by Brent Fulgham.
3987
3988         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3989         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3990         (TestWebKitAPI::TEST):
3991
3992 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3993
3994         Setting the file wrapper and content type of an attachment to a PDF should update its image
3995         https://bugs.webkit.org/show_bug.cgi?id=192984
3996         <rdar://problem/46798028>
3997
3998         Reviewed by Tim Horton.
3999
4000         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
4001         PDF data correctly updates the image element.
4002
4003         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4004
4005 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
4006
4007         Add JSCOnly to bot dashboard
4008         https://bugs.webkit.org/show_bug.cgi?id=192964
4009
4010         Reviewed by Alexey Proskuryakov.
4011
4012         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
4013         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
4014         useful if they were not so secret, so add them.
4015
4016         There appear to be no build-only bots, so the first column is blank. And of course there are
4017         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
4018         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
4019         and there's plenty of room in the final column for all the bots.
4020
4021         I had a hard time picking a logo to use, because the JavaScript language does not have an
4022         official logo. But I believe I've found one that will be satisfactory.
4023
4024         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
4025
4026         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
4027         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
4028         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4029         (BubbleQueueServer):
4030         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4031         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4032         (WebKitBuildbot):
4033         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4034         (table.queue-grid tr.platform.linux-jsconly img.logo):
4035
4036 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
4037
4038         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
4039         https://bugs.webkit.org/show_bug.cgi?id=192821
4040
4041         Reviewed by Chris Dumez.
4042
4043         * DumpRenderTree/mac/DumpRenderTree.mm:
4044         (createWebViewAndOffscreenWindow):
4045         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
4046
4047 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
4048
4049         [Win][Clang] Fix compilation warnings of DumpRenderTree
4050         https://bugs.webkit.org/show_bug.cgi?id=192924
4051
4052         Reviewed by Alex Christensen.
4053
4054         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
4055         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4056         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
4057         * DumpRenderTree/win/DumpRenderTree.cpp:
4058         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
4059         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
4060         object to the argument of setDefaultTextEncodingName instead of a
4061         const string literal.
4062         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
4063         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
4064         (setCacheFolder): Deleted.
4065         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
4066         * DumpRenderTree/win/EditingDelegate.cpp:
4067         (dump): Use %d for int.
4068         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
4069         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4070         (BSTRFromString): Deleted unused function.
4071         * DumpRenderTree/win/TestRunnerWin.cpp:
4072         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
4073         the arguemnt of setQuota instead of const string literal.
4074         * DumpRenderTree/win/WorkQueueItemWin.cpp:
4075         (jsStringRefToWString): Deleted unused function.
4076
4077 2018-12-20  Chris Dumez  <cdumez@apple.com>
4078
4079         Add API test coverage for customUserAgent client setting and service workers
4080         https://bugs.webkit.org/show_bug.cgi?id=192952
4081
4082         Reviewed by Alex Christensen.
4083
4084         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4085         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
4086         (-[SWSchemes webView:startURLSchemeTask:]):
4087         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4088         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
4089
4090 2018-12-20  Chris Dumez  <cdumez@apple.com>
4091
4092         Use Optional::hasValue() instead of Optional::has_value()
4093         https://bugs.webkit.org/show_bug.cgi?id=192948
4094
4095         Reviewed by Tim Horton.
4096
4097         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
4098         (TestWebKitAPI::TEST):
4099         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
4100         (TestWebKitAPI::TEST):
4101         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
4102         (TestWebKitAPI::TEST_F):
4103
4104 2018-12-20  Chris Dumez  <cdumez@apple.com>
4105
4106         Add style script rule to check for uses of std::optional<>
4107         https://bugs.webkit.org/show_bug.cgi?id=192931
4108
4109         Reviewed by Tim Horton.
4110
4111         * Scripts/webkitpy/style/checkers/cpp.py:
4112         (check_wtf_optional):
4113         (check_style):
4114
4115 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
4116
4117         [WebAuthN] Add a runtime flag for local authenticator
4118         https://bugs.webkit.org/show_bug.cgi?id=192792
4119         <rdar://problem/46798738>
4120
4121         Reviewed by Brent Fulgham.
4122
4123         * DumpRenderTree/TestOptions.cpp:
4124         (TestOptions::TestOptions):
4125         * DumpRenderTree/TestOptions.h:
4126         * DumpRenderTree/mac/DumpRenderTree.mm:
4127         (enableExperimentalFeatures):
4128         (setWebPreferencesForTestOptions):
4129         * WebKitTestRunner/TestController.cpp:
4130         (WTR::TestController::resetPreferencesToConsistentValues):
4131         (WTR::updateTestOptionsFromTestHeader):
4132         * WebKitTestRunner/TestOptions.h:
4133         (WTR::TestOptions::hasSameInitializationOptions const):
4134
4135 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
4136
4137         webkitpy: Autoinstall package URLs have changed
4138         https://bugs.webkit.org/show_bug.cgi?id=192909
4139         <rdar://problem/46860359>
4140
4141         Rubber-stamped by Alexey Proskuryakov.
4142
4143         PyPi urls have been moved around, we need to update our auto-installed packages.
4144
4145         We should check for Selenium before asking PyPi for the latest version.
4146
4147         * Scripts/webkitpy/thirdparty/__init__.py:
4148         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
4149         (AutoinstallImportHook._install_keyring): Ditto.
4150         (AutoinstallImportHook._install_pep8): Ditto.
4151         (AutoinstallImportHook._install_mozlog): Ditto.
4152         (AutoinstallImportHook._install_mozprocess): Ditto.
4153         (AutoinstallImportHook._install_pytest_timeout): Ditto.
4154         (AutoinstallImportHook._install_pytest): Ditto.
4155         (AutoinstallImportHook._install_pylint): Ditto.
4156         (AutoinstallImportHook._install_buildbot): Ditto.
4157         (AutoinstallImportHook._install_coverage): Ditto.
4158         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
4159         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
4160         for new Selenium if the installed version isn't sufficient.
4161         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
4162
4163 2018-12-20  Chris Dumez  <cdumez@apple.com>
4164
4165         Use Optional::valueOr() instead of Optional::value_or()
4166         https://bugs.webkit.org/show_bug.cgi?id=192933
4167
4168         Reviewed by Geoffrey Garen.
4169
4170         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
4171         (TestWebKitAPI::checkURL):
4172         (TestWebKitAPI::checkRelativeURL):
4173         (TestWebKitAPI::checkURLDifferences):
4174         (TestWebKitAPI::checkRelativeURLDifferences):
4175         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
4176         (TestWebKitAPI::checkURL):
4177
4178 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
4179
4180         Unreviewed, rolling out r239417.
4181
4182         Introduced two API test failures on macOS.
4183
4184         Reverted changeset:
4185
4186         "<rdar://problem/46194315> macOS: WebKit1 does not handle
4187         occlusion changes"
4188         https://bugs.webkit.org/show_bug.cgi?id=192821
4189         https://trac.webkit.org/changeset/239417
4190
4191 2018-12-20  Devin Rousso  <drousso@apple.com>
4192
4193         Web Inspector: UIString should take an optional key and description to aid localization
4194         https://bugs.webkit.org/show_bug.cgi?id=153962
4195         <rdar://problem/24542505>
4196
4197         Reviewed by Brian Burg.
4198
4199         * Scripts/extract-localizable-js-strings:
4200
4201 2018-12-20  Tim Horton  <timothy_horton@apple.com>
4202
4203         Unparented WKWebView can't retrieve main resource data for a main frame plugin
4204         https://bugs.webkit.org/show_bug.cgi?id=192923
4205         <rdar://problem/46859068>
4206
4207         Reviewed by Wenson Hsieh.
4208
4209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4210         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
4211         Add a test ensuring that both parented and unparented WKWebViews can
4212         retrieve main resource data when loading a PDF.
4213
4214 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
4215
4216         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
4217         https://bugs.webkit.org/show_bug.cgi?id=192852
4218
4219         Reviewed by Michael Catanzaro.
4220
4221         EmojiOne font was replaced by Noto Color Emoji.
4222
4223         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
4224         * gtk/jhbuild.modules:
4225         * wpe/jhbuild.modules:
4226
4227 2018-12-19  Chris Dumez  <cdumez@apple.com>
4228
4229         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
4230         https://bugs.webkit.org/show_bug.cgi?id=192728
4231         <rdar://problem/46746779>
4232
4233         Reviewed by Geoff Garen.
4234
4235         * DumpRenderTree/*:
4236         * MiniBrowser/*:
4237         * TestRunnerShared/*:
4238         * TestWebKitAPI/*:
4239         * WebGPUAPIStructure/*:
4240         * WebKitTestRunner/*:
4241
4242 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
4243
4244         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
4245         https://bugs.webkit.org/show_bug.cgi?id=192821
4246
4247         Reviewed by Chris Dumez.
4248
4249         * DumpRenderTree/mac/DumpRenderTree.mm:
4250         (createWebViewAndOffscreenWindow):
4251
4252 2018-12-19  Alex Christensen  <achristensen@webkit.org>
4253
4254         Navigations away from the SafeBrowsing interstitial show a flash of old content
4255         https://bugs.webkit.org/show_bug.cgi?id=192676
4256
4257         Reviewed by Chris Dumez.
4258
4259         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4260         (safeBrowsingView):
4261         (TEST):
4262         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
4263
4264 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
4265
4266         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
4267         https://bugs.webkit.org/show_bug.cgi?id=192855
4268
4269         Reviewed by Michael Catanzaro.
4270
4271         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4272         (WTR::TestController::notifyDone): Use the WPE implementation.
4273         (WTR::TestController::platformRunUntil): Use the WPE implementation.
4274         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
4275         (WTR::TestController::platformRunUntil): Honor the condition flag.
4276
4277 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
4278
4279         Allow clients to set the navigator platform
4280         https://bugs.webkit.org/show_bug.cgi?id=192735
4281
4282         Reviewed by Tim Horton.
4283
4284         Add a test for setting a custom navigator platform.
4285