Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirected...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-09  John Wilander  <wilander@apple.com>
2
3         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
4         https://bugs.webkit.org/show_bug.cgi?id=196558
5         <rdar://problem/47650245>
6
7         Reviewed by Youenn Fablet.
8
9         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
10         (TestWebKitAPI::TEST):
11             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
12
13 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
14
15         [CMake] Apple builds should use ICU_INCLUDE_DIRS
16         https://bugs.webkit.org/show_bug.cgi?id=196720
17
18         Reviewed by Konstantin Tokarev.
19
20         * TestWebKitAPI/PlatformMac.cmake:
21
22 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
23
24         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
25         https://bugs.webkit.org/show_bug.cgi?id=196694
26         <rdar://problem/48388734>
27
28         Rubber-stamped by Aakash Jain.
29
30         * Scripts/webkitpy/port/image_diff.py:
31         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
32         * Scripts/webkitpy/port/server_process.py:
33         (ServerProcess.has_available_stdout): Check if stdout has data in it.
34         (ServerProcess._wait_for_data_and_update_buffers_using_select):
35         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
36         * Scripts/webkitpy/port/server_process_mock.py:
37         (MockServerProcess.has_available_stdout):
38         * Scripts/webkitpy/port/server_process_unittest.py:
39         (TestServerProcess.serial_test_basic):
40
41 2019-04-09  Jer Noble  <jer.noble@apple.com>
42
43         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
44         https://bugs.webkit.org/show_bug.cgi?id=196097
45
46         Reviewed by Eric Carlson.
47
48         Drive-by bug fix: allow tests to play audio without a user gesture by default.
49
50         * DumpRenderTree/mac/DumpRenderTree.mm:
51         (resetWebPreferencesToConsistentValues):
52         * WebKitTestRunner/TestController.cpp:
53         (WTR::TestController::resetPreferencesToConsistentValues):
54
55 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
56
57         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
58         https://bugs.webkit.org/show_bug.cgi?id=196690
59
60         Reviewed by Michael Catanzaro.
61
62         * QueueStatusServer/config/queues.py:
63         * Scripts/webkitpy/common/config/ews.json:
64         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
65         (test_ews_name):
66
67 2019-04-09  Chris Dumez  <cdumez@apple.com>
68
69         Loads using loadHTMLString() cause flashing when process-swapping
70         https://bugs.webkit.org/show_bug.cgi?id=196714
71         <rdar://problem/49637354>
72
73         Reviewed by Antti Koivisto.
74
75         Add API test coverage.
76
77         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
78
79 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
80
81         Unreviewed. Fix ATK accessibility tests after r244059.
82
83         We are failing to load the injected bundle due to undefined symbol
84         AccessibilityUIElement::replaceTextInRange().
85
86         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
87         (WTR::AccessibilityUIElement::replaceTextInRange):
88
89 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
90
91         AX: Support API: accessibilityReplaceRange:withText
92         https://bugs.webkit.org/show_bug.cgi?id=196636
93
94         Unreviewed build fix for Windows port.
95
96         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
97         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
98
99 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
100
101         [CMake][WinCairo] Separate copied headers into different directories
102         https://bugs.webkit.org/show_bug.cgi?id=196655
103
104         Reviewed by Michael Catanzaro.
105
106         * DumpRenderTree/CMakeLists.txt:
107         * MiniBrowser/win/CMakeLists.txt:
108         * TestWebKitAPI/CMakeLists.txt:
109         * TestWebKitAPI/PlatformWin.cmake:
110
111 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
112
113         Log stack-trace for run-webkit-tests when interrupted
114         https://bugs.webkit.org/show_bug.cgi?id=176393
115         <rdar://problem/34262310>
116
117         Reviewed by Lucas Forschler.
118
119         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
120         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
121         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
122         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
123         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
124         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
125         (main): Set handlers to log stack trace on interruption.
126
127 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
128
129         AX: Support API: accessibilityReplaceRange:withText
130         https://bugs.webkit.org/show_bug.cgi?id=196636
131
132         Unreviewed build fix for Windows port.
133
134         * DumpRenderTree/AccessibilityUIElement.cpp:
135         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
136
137 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
138
139         [ews-build] Scripts using Buildbot API have CORS error
140         https://bugs.webkit.org/show_bug.cgi?id=196709
141
142         Reviewed by Alexey Proskuryakov.
143
144         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
145
146 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
147
148         AX: Support API: accessibilityReplaceRange:withText
149         https://bugs.webkit.org/show_bug.cgi?id=196636
150
151         Reviewed by Daniel Bates.
152
153         * DumpRenderTree/AccessibilityUIElement.cpp:
154         (replaceTextInRangeCallback):
155         (AccessibilityUIElement::replaceTextInRange):
156         (AccessibilityUIElement::getJSClass):
157         * DumpRenderTree/AccessibilityUIElement.h:
158         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
159         (AccessibilityUIElement::replaceTextInRange):
160         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
161         (AccessibilityUIElement::replaceTextInRange):
162         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
163         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
164         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
165         (WTR::AccessibilityUIElement::replaceTextInRange):
166         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
167         (WTR::AccessibilityUIElement::replaceTextInRange):
168
169 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
170
171         [iOS] Do not allow starting selection drags when selection views are not visible
172         https://bugs.webkit.org/show_bug.cgi?id=196686
173         <rdar://problem/49399192>
174
175         Reviewed by Tim Horton.
176
177         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
178         also add some new API tests to cover scenarios where the web view is not first responder.
179
180         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
181         (TestWebKitAPI::TEST):
182         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
183
184         Add a switch to optionally make the web view first responder when starting the simulated drag.
185
186         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
187         (-[DragAndDropSimulator initWithWebView:]):
188         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
189
190 2019-04-08  Justin Fan  <justin_fan@apple.com>
191
192         [Web GPU] Fix Web GPU experimental feature on iOS
193         https://bugs.webkit.org/show_bug.cgi?id=196632
194
195         Reviewed by Myles C. Maxfield.
196
197         Properly make Web GPU available on iOS 11+.
198
199         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
200
201 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
202
203         [ews-build] Do not upload archive when Compile Fails
204         https://bugs.webkit.org/show_bug.cgi?id=196674
205
206         Reviewed by Alexey Proskuryakov.
207
208         * BuildSlaveSupport/ews-build/factories.py:
209         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
210         * BuildSlaveSupport/ews-build/steps.py:
211         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
212         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
213         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
214
215 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
216
217         Enable DFG on MIPS
218         https://bugs.webkit.org/show_bug.cgi?id=196689
219
220         Reviewed by Žan Doberšek.
221
222         Since the bytecode change, we enabled the baseline JIT on mips in
223         r240432, but DFG is still missing. With this change, all tests are
224         passing on a ci20 board.
225
226         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
227
228 2019-04-08  Philippe Normand  <pnormand@igalia.com>
229
230         [Flatpak] Second run update-webkitwpe-flatpak fails
231         https://bugs.webkit.org/show_bug.cgi?id=192702
232
233         Reviewed by Carlos Garcia Campos.
234
235         * flatpak/flatpakutils.py:
236         (FlatpakObject.flatpak): Fix typo.
237         (FlatpakPackage.install): When installing, also update to the configured remote commit.
238         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
239
240 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
241
242         [GTK][WPE] outlook.live.com displays old-fashioned UI
243         https://bugs.webkit.org/show_bug.cgi?id=196642
244
245         Reviewed by Carlos Garcia Campos.
246
247         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
248         (TestWebKitAPI::TEST): New Mac platform quirk test.
249
250 2019-04-07  Commit Queue  <commit-queue@webkit.org>
251
252         Unreviewed, rolling out r243956.
253         https://bugs.webkit.org/show_bug.cgi?id=196688
254
255         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
256         by aakashjain on #webkit).
257
258         Reverted changeset:
259
260         "Clicking "Go Back" from a safe browsing warning from an
261         iframe should navigate the WKWebView back to the previous
262         page"
263         https://bugs.webkit.org/show_bug.cgi?id=196665
264         https://trac.webkit.org/changeset/243956
265
266 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
267
268         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
269         https://bugs.webkit.org/show_bug.cgi?id=196669
270
271         Reviewed by Geoffrey Garen.
272
273         Added three new unit tests for WeakHashSet.
274
275         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
276         (WTF_WeakPtr.WeakHashSetConstObjects):
277         (WTF_WeakPtr.WeakHashSetComputesEmpty):
278         (WTF_WeakPtr.WeakHashSetComputeSize):
279
280 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
281
282         Hide next and previous form control buttons when WKWebView is editable
283         https://bugs.webkit.org/show_bug.cgi?id=196672
284         <rdar://problem/35625321>
285
286         Reviewed by Tim Horton.
287
288         Add a new API test.
289
290         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
291         (-[TestWKWebView lastTrailingBarButtonGroup]):
292         (TestWebKitAPI::TEST):
293         * TestWebKitAPI/ios/UIKitSPI.h:
294
295 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
296
297         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
298         https://bugs.webkit.org/show_bug.cgi?id=196077
299         <rdar://problem/49108202>
300
301         Reviewed by Chris Dumez.
302
303         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
304         on new web view.
305
306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
307
308 2019-04-05  Saam Barati  <sbarati@apple.com>
309
310         Make compare-results understand MotionMark
311         https://bugs.webkit.org/show_bug.cgi?id=196666
312
313         Reviewed by Yusuke Suzuki.
314
315         * Scripts/compare-results:
316         (PLT5Results):
317         (detectMotionMark):
318         (detectMotionMark1_1):
319         (motionMarkResults):
320         (motionMark1_1Results):
321         (detectBenchmark):
322         (biggerIsBetter):
323         (main):
324
325 2019-04-05  Alex Christensen  <achristensen@webkit.org>
326
327         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
328         https://bugs.webkit.org/show_bug.cgi?id=196665
329         <rdar://45115669>
330
331         Reviewed by Geoff Garen.
332
333         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
334         (goBack):
335         (+[SimpleLookupContext sharedLookupContext]):
336         (-[SimpleLookupContext lookUpURL:completionHandler:]):
337         (TEST):
338         (+[Simple3LookupContext sharedLookupContext]): Deleted.
339         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
340
341 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
342
343         [ews-build] Add configuration and architecture for windows builders
344         https://bugs.webkit.org/show_bug.cgi?id=196660
345
346         Reviewed by Lucas Forschler.
347
348         * BuildSlaveSupport/ews-build/config.json:
349
350 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
351
352         webkitpy: Don't run subsequent rounds if interrupted
353         https://bugs.webkit.org/show_bug.cgi?id=196646
354
355         Reviewed by Aakash Jain.
356
357         * Scripts/webkitpy/layout_tests/controllers/manager.py:
358         (Manager.run): Bail out if interrupted.
359
360 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
361
362         Test sessionStorage in PSON private browsing mode
363         https://bugs.webkit.org/show_bug.cgi?id=196561
364
365         Reviewed by Alex Christensen.
366
367         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
368
369 2019-04-05  Commit Queue  <commit-queue@webkit.org>
370
371         Unreviewed, rolling out r243833.
372         https://bugs.webkit.org/show_bug.cgi?id=196645
373
374         This change breaks build of WPE and GTK ports (Requested by
375         annulen on #webkit).
376
377         Reverted changeset:
378
379         "[CMake][WTF] Mirror XCode header directories"
380         https://bugs.webkit.org/show_bug.cgi?id=191662
381         https://trac.webkit.org/changeset/243833
382
383 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
384
385         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
386         https://bugs.webkit.org/show_bug.cgi?id=196635
387
388         Reviewed by Antti Koivisto.
389         
390         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
391         for a test to enable async frame scrolling via:
392             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
393         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
394         
395         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
396
397         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
398         (WTR::InjectedBundle::beginTesting):
399         * WebKitTestRunner/TestController.cpp:
400         (WTR::TestController::resetPreferencesToConsistentValues):
401
402 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
403
404         Use a correct LC_RPATH when building with ASan
405         https://bugs.webkit.org/show_bug.cgi?id=196576
406
407         Reviewed by David Kilzer.
408
409         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
410         so that ../Frameworks is checked. This is simpler and more reliable than updating
411         each SPC service xcconfig.
412
413 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
414
415         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
416         https://bugs.webkit.org/show_bug.cgi?id=196629
417
418         Reviewed by Lucas Forschler.
419
420         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
421
422 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
423
424         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
425         https://bugs.webkit.org/show_bug.cgi?id=196618
426
427         Reviewed by Lucas Forschler.
428
429         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
430         (StatusBubble): Added QUEUE_TRIGGERS.
431         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
432         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
433         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
434         its parent(builder).
435
436 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
437
438         [ews-app] Status-bubble steps are sometimes displayed in reverse order
439         https://bugs.webkit.org/show_bug.cgi?id=196625
440
441         Reviewed by Lucas Forschler.
442
443         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
444         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
445
446 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
447
448         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
449         https://bugs.webkit.org/show_bug.cgi?id=196630
450
451         Reviewed by Wenson Hsieh.
452
453         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
454
455 2019-04-04  Youenn Fablet  <youenn@apple.com>
456
457         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
458         https://bugs.webkit.org/show_bug.cgi?id=196543
459
460         Reviewed by Alex Christensen.
461
462         * WebKitTestRunner/TestController.cpp:
463         (WTR::TestController::generatePageConfiguration):
464
465 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
466
467         [ews-app] Status bubble should not display skipped buildbot steps
468         https://bugs.webkit.org/show_bug.cgi?id=196584
469
470         Reviewed by Lucas Forschler.
471
472         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
473
474 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
475
476         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
477         https://bugs.webkit.org/show_bug.cgi?id=196620
478
479         Reviewed by Lucas Forschler.
480
481         * BuildSlaveSupport/ews-app/ews/config.py:
482
483 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
484
485         [Win] DumpRenderTreeWatchDog.py is not checked into source
486         https://bugs.webkit.org/show_bug.cgi?id=196567
487         <rdar://problem/49525901>
488
489         Reviewed by Lucas Forschler.
490
491         This script is used on Win EWS bots to terminate hanging DRT processes.
492
493         * EWSTools/dumprendertreewatchdog.py: Added.
494
495 2019-04-04  Chris Dumez  <cdumez@apple.com>
496
497         Unreviewed, roll out r243858 which made tests time out.
498
499         Disable new API tests on Windows instead.
500
501         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
502         (TestWebKitAPI::TEST):
503
504 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
505
506         [ATK] Cleanup WebPageAccessibilityObjectAtk
507         https://bugs.webkit.org/show_bug.cgi?id=196537
508
509         Reviewed by Michael Catanzaro.
510
511         Also consider files under atk directories as exceptions for GObject conventions.
512
513         * Scripts/webkitpy/style/checkers/cpp.py:
514         (check_identifier_name_in_declaration):
515
516 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
517
518         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
519         https://bugs.webkit.org/show_bug.cgi?id=196588
520         <rdar://problem/49365787>
521
522         Unreviewed build fix for Windows port.
523
524         error C3861: 'kill': identifier not found
525
526         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
527         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
528
529 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
530
531         [ews-build] Cancel build and similar operations should have authentication
532         https://bugs.webkit.org/show_bug.cgi?id=196520
533
534         Reviewed by Dewei Zhu.
535
536         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
537         environment variables.
538
539 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
540
541         [ews-build] Do not trigger queues which are not in production yet
542         https://bugs.webkit.org/show_bug.cgi?id=196581
543
544         Reviewed by Dewei Zhu.
545
546         * BuildSlaveSupport/ews-build/config.json:
547
548 2019-04-03  Chris Dumez  <cdumez@apple.com>
549
550         Unreviewed, fix typo in the name of API test added in r243848.
551
552         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
553         (TestWebKitAPI::TEST):
554
555 2019-04-03  Chris Dumez  <cdumez@apple.com>
556
557         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
558         https://bugs.webkit.org/show_bug.cgi?id=196588
559         <rdar://problem/49365787>
560
561         Reviewed by Ryosuke Niwa.
562
563         Add API test coverage.
564
565         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
566         (TestWebKitAPI::nullJavaScriptCallback):
567         (TestWebKitAPI::didCrashCheckFrames):
568         (TestWebKitAPI::TEST):
569
570 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
571
572         run-webkit-tests: Upload test results (new results database)
573         https://bugs.webkit.org/show_bug.cgi?id=196577
574         <rdar://problem/34841155>
575
576         Reviewed by Lucas Forschler.
577
578         * Scripts/webkitpy/layout_tests/controllers/manager.py:
579         (Manager.run): Upload results after each device shard, since the configuration will be
580         different for each device.
581         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
582         uploaded to a results database.
583         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
584         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
585
586 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
587
588         -apple-trailing-word is needed for browser detection
589         https://bugs.webkit.org/show_bug.cgi?id=196575
590
591         Unreviewed.
592
593         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
594
595 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
596
597         [CMake][WTF] Mirror XCode header directories
598         https://bugs.webkit.org/show_bug.cgi?id=191662
599
600         Reviewed by Konstantin Tokarev.
601
602         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
603         builds.
604
605         * CMakeLists.txt:
606         * DumpRenderTree/CMakeLists.txt:
607         * DumpRenderTree/PlatformWin.cmake:
608         * MiniBrowser/win/CMakeLists.txt:
609         * TestWebKitAPI/CMakeLists.txt:
610         * TestWebKitAPI/PlatformWin.cmake:
611         * WebKitTestRunner/PlatformGTK.cmake:
612         * WebKitTestRunner/PlatformWin.cmake:
613
614 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
615
616         [ews-app] Status bubble should not display certain infrastructure status messages
617         https://bugs.webkit.org/show_bug.cgi?id=196550
618
619         Reviewed by Lucas Forschler.
620
621         Do not display the steps which are un-needed for end-user. This information is still avaiable
622         if the user click on the bubble and look at the Buildbot build.
623         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
624         (StatusBubble._steps_messages):
625         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
626
627 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
628
629         [ews-build] Use https for sending data to ews-app
630         https://bugs.webkit.org/show_bug.cgi?id=196492
631
632         Reviewed by Lucas Forschler.
633
634         * BuildSlaveSupport/ews-build/events.py:
635
636 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
637
638         Remove support for -apple-trailing-word
639         https://bugs.webkit.org/show_bug.cgi?id=196525
640
641         Reviewed by Zalan Bujtas.
642
643         This CSS property is nonstandard and not used.
644
645         * Scripts/webkitperl/FeatureList.pm:
646         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
647
648 2019-04-03  Youenn Fablet  <youenn@apple.com>
649
650         Add a test for DOMCache on multiple browsing in case of private browsing
651         https://bugs.webkit.org/show_bug.cgi?id=196524
652
653         Reviewed by Alex Christensen.
654
655         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
656         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
657
658 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
659
660         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
661         https://bugs.webkit.org/show_bug.cgi?id=196540
662
663         Reviewed by Aakash Jain.
664
665         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
666
667 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
668
669         Add plumbing for a compatibility mode preference in WebKit
670         https://bugs.webkit.org/show_bug.cgi?id=196005
671
672         Reviewed by Tim Horton.
673
674         Add new API tests.
675
676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
677         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
678
679 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
680
681         [WPE][GTK] Update libsrtp dependency package for Debian
682         https://bugs.webkit.org/show_bug.cgi?id=196528
683
684         Reviewed by Frédéric Wang.
685
686         * gtk/install-dependencies:
687         * wpe/install-dependencies:
688
689 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
690
691         [WK2] Add support for Window's beforeprint / afterprint events
692         https://bugs.webkit.org/show_bug.cgi?id=196478
693         <rdar://problem/49535124>
694
695         Unreviewed build fix for MSVC.
696
697         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
698
699         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
700
701         * WebKitTestRunner/TestController.cpp:
702         (WTR::printFrame): Use int and float literals.
703
704 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
705
706         [ews-build] Reassign bots to queues
707
708         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
709
710 2019-04-02  Chris Dumez  <cdumez@apple.com>
711
712         [WK2] Add support for Window's beforeprint / afterprint events
713         https://bugs.webkit.org/show_bug.cgi?id=196478
714
715         Reviewed by Alex Christensen.
716
717         Add minimal implementation for printFrame in WebKitTestRunner.
718
719         * WebKitTestRunner/TestController.cpp:
720         (WTR::printFrame):
721         (WTR::TestController::createOtherPage):
722         (WTR::TestController::createWebViewWithOptions):
723
724 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
725
726         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
727         https://bugs.webkit.org/show_bug.cgi?id=196491
728
729         Reviewed by Lucas Forschler.
730
731         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
732
733 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
734
735         [ews-build] Configure buildbot try credentials in environment variables
736         https://bugs.webkit.org/show_bug.cgi?id=196501
737
738         Reviewed by Lucas Forschler.
739
740         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
741         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
742         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
743
744 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
745
746         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
747         https://bugs.webkit.org/show_bug.cgi?id=196496
748         <rdar://problem/49521634>
749
750         Reviewed by Chris Dumez.
751
752         Add new API tests (see WebKit ChangeLog for more detail).
753
754         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
755         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
756         (TEST):
757
758 2019-04-02  David Kilzer  <ddkilzer@apple.com>
759
760         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
761         <https://webkit.org/b/196499>
762
763         Reviewed by Alexey Proskuryakov.
764
765         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
766         ENABLE_ADDRESS_SANITIZER.
767
768 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
769
770         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
771         https://bugs.webkit.org/show_bug.cgi?id=182757
772
773         Reviewed by Don Olmstead.
774
775         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
776         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
777
778 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
779
780         run-api-tests: Upload test results
781         https://bugs.webkit.org/show_bug.cgi?id=196323
782         <rdar://problem/49356714>
783
784         Reviewed by Lucas Forschler.
785
786         * Scripts/webkitpy/api_tests/manager.py:
787         (Manager):
788         (Manager.run): Upload results to a results database.
789         * Scripts/webkitpy/api_tests/run_api_tests.py:
790         (parse_args): Add upload arguments.
791         * Scripts/webkitpy/port/base.py:
792         (Port):
793         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
794         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
795         with commits from any other associated repositories.
796         * Scripts/webkitpy/port/device.py:
797         (Device):
798         (Device.build_version): Access build_versoin of underlying platform device.
799         * Scripts/webkitpy/port/ios_simulator_unittest.py:
800         (IOSSimulatorTest):
801         (IOSSimulatorTest.test_configuration_for_upload):
802         * Scripts/webkitpy/port/device_port.py:
803         (DevicePort):
804         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
805         the same as the machine uploading results.
806         * Scripts/webkitpy/port/mac.py:
807         (MacPort):
808         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
809         * Scripts/webkitpy/port/mac_unittest.py:
810         (MacTest):
811         (MacTest.test_configuration_for_upload):
812         * Scripts/webkitpy/xcode/simulated_device.py:
813         (SimulatedDeviceManager._create_device_with_runtime):
814         (SimulatedDevice.__init__): Create simulated device with a build_version.
815         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
816         (test_existing_simulator):
817
818 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
819
820         Remove extra newline characters (Follow-up fix to r243707)
821
822         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
823
824 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
825
826         [ews-app] Use API_KEY to accept results data
827         https://bugs.webkit.org/show_bug.cgi?id=196461
828
829         Reviewed by Dewei Zhu.
830
831         * BuildSlaveSupport/ews-app/ews/views/results.py:
832         (Results.post): Validate EWS_API_KEY before accepting any data.
833         * BuildSlaveSupport/ews-build/events.py:
834         (Events.sendData): Send EWS_API_KEY if available along with event data.
835
836 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
837
838         Unable to copy and paste a PDF from Notes into Mail compose body
839         https://bugs.webkit.org/show_bug.cgi?id=196442
840         <rdar://problem/48573098>
841
842         Reviewed by Tim Horton.
843
844         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
845         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
846         to be specified on the item providers.
847
848         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
849         (TestWebKitAPI::mapItemForTesting):
850         (TestWebKitAPI::contactItemForTesting):
851
852 2019-04-01  Tim Horton  <timothy_horton@apple.com>
853
854         Make UIWKDocumentContext rects per-character instead of per-word
855         https://bugs.webkit.org/show_bug.cgi?id=196459
856
857         Reviewed by Wenson Hsieh.
858
859         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
860         (TEST):
861         Adjust test results due to switching to per-character rects.
862
863 2019-04-01  Chris Dumez  <cdumez@apple.com>
864
865         UIProcess crash when a prewarmed process is terminated
866         https://bugs.webkit.org/show_bug.cgi?id=196451
867         <rdar://problem/49245471>
868
869         Reviewed by Geoffrey Garen.
870
871         Add API test coverage.
872
873         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
874         (TEST):
875
876 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
877
878         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
879         https://bugs.webkit.org/show_bug.cgi?id=196449
880
881         Reviewed by Lucas Forschler.
882
883         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
884         (StatusBubble.get_os_details): Method to get OS and Xcode details.
885         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
886         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
887
888 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
889
890         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
891         https://bugs.webkit.org/show_bug.cgi?id=196444
892
893         Reviewed by Lucas Forschler.
894
895         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
896
897 2019-04-01  Alex Christensen  <achristensen@webkit.org>
898
899         Add SPI to canonicalize NSURLs with WTF::URL
900         https://bugs.webkit.org/show_bug.cgi?id=196415
901         <rdar://problem/44980271>
902
903         Reviewed by Darin Adler.
904
905         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
906         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
907         (TestWebKitAPI::TEST):
908
909 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
910
911         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
912         https://bugs.webkit.org/show_bug.cgi?id=196441
913
914         Reviewed by Carlos Garcia Campos.
915
916         Don't cache the wpe_view_backend object that might not exist yet at the
917         time of EventSenderProxy constructor invocation, but instead retrieve
918         that object whenever it's required for event dispatching. This should
919         avoid crashes in this constructor now that it's invoked before any
920         PlatformWindow has been set up (as changed in r243496).
921
922         * WebKitTestRunner/EventSenderProxy.h:
923         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
924         (WTR::viewBackend):
925         (WTR::EventSenderProxy::EventSenderProxy):
926         (WTR::EventSenderProxy::mouseDown):
927         (WTR::EventSenderProxy::mouseUp):
928         (WTR::EventSenderProxy::mouseMoveTo):
929         (WTR::EventSenderProxy::mouseScrollBy):
930         (WTR::EventSenderProxy::keyDown):
931         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
932
933 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
934
935         [Win][WebKit] MiniBrowser should support high DPI display
936         https://bugs.webkit.org/show_bug.cgi?id=196391
937
938         Reviewed by Alex Christensen.
939
940         * MiniBrowser/win/WebKitBrowserWindow.cpp:
941         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
942         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
943         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
944
945 2019-03-31  Sam Weinig  <weinig@apple.com>
946
947         Remove more i386 specific configurations
948         https://bugs.webkit.org/show_bug.cgi?id=196430
949
950         Reviewed by Alexey Proskuryakov.
951
952         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
953         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
954
955 2019-03-31  Andy Estes  <aestes@apple.com>
956
957         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
958         https://bugs.webkit.org/show_bug.cgi?id=196433
959         <rdar://problem/49293305>
960
961         Reviewed by Tim Horton.
962
963         Enhanced API test coverage to include all navigation response policy decisions in both
964         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
965
966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
967         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
968         (TestWebKitAPI::TEST):
969         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
970         (readFile):
971         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
972         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
973         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
974         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
975         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
976         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
977         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
978         (-[QuickLookDelegate _downloadDidStart:]):
979         (-[QuickLookDelegate _download:didReceiveResponse:]):
980         (-[QuickLookDelegate _download:didReceiveData:]):
981         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
982         (-[QuickLookDelegate _downloadDidFinish:]):
983         (-[QuickLookDelegate _download:didFailWithError:]):
984         (-[QuickLookDelegate _downloadDidCancel:]):
985         (-[QuickLookDelegate verifyDownload]):
986         (runTest):
987         (runTestDecideBeforeLoading):
988         (runTestDecideAfterLoading):
989         (TEST):
990         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
991         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
992         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
993         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
994         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
995         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
996         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
997         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
998         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
999         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1000         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1001         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1002         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1003         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1004
1005 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1006
1007         [CMake] add testdfg as target with build-jsc
1008         https://bugs.webkit.org/show_bug.cgi?id=196393
1009
1010         Reviewed by Saam Barati.
1011
1012         Added testdfg as one of the targets to build when
1013         using CMake.
1014
1015         * Scripts/build-jsc:
1016
1017 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1018
1019         Delete WebMetal implementation in favor of WebGPU
1020         https://bugs.webkit.org/show_bug.cgi?id=195418
1021
1022         Reviewed by Dean Jackson.
1023
1024         * DumpRenderTree/mac/DumpRenderTree.mm:
1025         (enableExperimentalFeatures):
1026         (resetWebPreferencesToConsistentValues):
1027         * Scripts/webkitperl/FeatureList.pm:
1028         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1029         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1030         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1031         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1032         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1033         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1034         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1035         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1036         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1037         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1038         (WTR::InjectedBundle::beginTesting):
1039         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1040         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1041         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1042
1043 2019-03-29  Chris Dumez  <cdumez@apple.com>
1044
1045         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1046         https://bugs.webkit.org/show_bug.cgi?id=196405
1047         <rdar://problem/49428130>
1048
1049         Reviewed by Wenson Hsieh.
1050
1051         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1052         the popover presentation methods to be no-ops. Use this in the new test added in
1053         r243523 so that we do not swizzle those methods for all tests. This is needed because
1054         those WatchOS tests rely on the popover getting presented and interactive.
1055
1056         * WebKitTestRunner/TestController.cpp:
1057         (WTR::updateTestOptionsFromTestHeader):
1058         * WebKitTestRunner/TestController.h:
1059         * WebKitTestRunner/TestOptions.h:
1060         (WTR::TestOptions::hasSameInitializationOptions const):
1061         * WebKitTestRunner/ios/TestControllerIOS.mm:
1062         (WTR::TestController::platformInitialize):
1063         (WTR::TestController::platformResetStateToConsistentValues):
1064
1065 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1066
1067         [Curl] Add Server Trust Evaluation Support.
1068         https://bugs.webkit.org/show_bug.cgi?id=191646
1069
1070         Reviewed by Fujii Hironori.
1071
1072         Implemented MiniBrowser UI for asking if user trusts the server.
1073
1074         * MiniBrowser/win/Common.cpp:
1075         (askServerTrustEvaluation):
1076         (replaceString):
1077         * MiniBrowser/win/Common.h:
1078         * MiniBrowser/win/MiniBrowserLib.rc:
1079         * MiniBrowser/win/MiniBrowserLibResource.h:
1080         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1081         (createPEMString):
1082         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1083         (WebKitBrowserWindow::canTrustServerCertificate):
1084         * MiniBrowser/win/WebKitBrowserWindow.h:
1085
1086 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1087
1088         Implement ResizeObserver.
1089         https://bugs.webkit.org/show_bug.cgi?id=157743
1090
1091         Reviewed by Simon Fraser.
1092
1093         Support resizeObserverEnabled webPreferences.
1094
1095         * DumpRenderTree/TestOptions.cpp:
1096         (TestOptions::TestOptions):
1097         * DumpRenderTree/TestOptions.h:
1098         * DumpRenderTree/mac/DumpRenderTree.mm:
1099         (setWebPreferencesForTestOptions):
1100         * DumpRenderTree/win/DumpRenderTree.cpp:
1101         (enableExperimentalFeatures):
1102         * Scripts/webkitperl/FeatureList.pm:
1103         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1104
1105 2019-03-28  John Wilander  <wilander@apple.com>
1106
1107         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1108         https://bugs.webkit.org/show_bug.cgi?id=196281
1109         <rdar://problem/48938748>
1110
1111         Reviewed by Alex Christensen.
1112
1113         This patch adds the function isStatisticsHasLocalStorage() to the
1114         TestRunner. With it, the page can query the WebsiteDataStore in the
1115         UI process to make sure that it sees LocalStorage.
1116
1117         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1118         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1119         (WTR::TestRunner::isStatisticsHasLocalStorage):
1120         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1121         * WebKitTestRunner/TestController.cpp:
1122         (WTR::TestController::isStatisticsHasLocalStorage):
1123         * WebKitTestRunner/TestController.h:
1124         * WebKitTestRunner/TestInvocation.cpp:
1125         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1126
1127 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1128
1129         API::Data::createWithoutCopying should do a null check before calling CFRelease
1130         https://bugs.webkit.org/show_bug.cgi?id=196276
1131         <rdar://problem/48059859>
1132
1133         Reviewed by Alex Christensen.
1134
1135         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1136
1137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1138         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1139         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1140         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1141         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1142         (TestWebKitAPI::TEST):
1143
1144 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1145
1146         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1147         https://bugs.webkit.org/show_bug.cgi?id=186276
1148
1149         Reviewed by Carlos Garcia Campos.
1150
1151         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1152         (webViewLoadChanged):
1153         (testWebResourceGetDataError):
1154         (testWebResourceGetDataEmpty):
1155         (beforeAll):
1156         (webViewloadChanged): Deleted.
1157
1158 2019-03-27  Andy Estes  <aestes@apple.com>
1159
1160         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1161         https://bugs.webkit.org/show_bug.cgi?id=196317
1162
1163         Reviewed by Dan Bernstein.
1164
1165         package-root copies built products into a staging directory using ditto(1), which does not
1166         follow symbolic links as it traverses a directory. Now that the files in
1167         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1168         itself, these become broken links when ditto'd into the staging directory.
1169
1170         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1171
1172         * Scripts/package-root:
1173
1174 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1175
1176         [ews-app] Update display text of Submit for ews analysis
1177         https://bugs.webkit.org/show_bug.cgi?id=196309
1178
1179         Reviewed by Dewei Zhu.
1180
1181         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1182
1183 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1184
1185         run-webkit-tests should check for leaks in WebKit processes
1186         <https://webkit.org/b/193772>
1187         <rdar://problem/46526680>
1188
1189         Reviewed by Ryosuke Niwa.
1190
1191         This works by doing the following:
1192         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1193           The list of child processes are returned one per line:
1194           process.name: pid
1195         - Run the "#LIST CHILD PROCESSES" command just before the
1196           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1197           processes on the ServerProcess object.
1198         - When the `--leaks` switch is handled, run check_for_leaks() on
1199           each child process after the main test harness.
1200
1201         * DumpRenderTree/mac/DumpRenderTree.mm:
1202         (handleControlCommand):
1203         - Use strncmp() instead of strcmp().
1204         - Add support for handling "#LIST CHILD PROCESSES" command.
1205
1206         * Scripts/webkitpy/port/base.py:
1207         (Port.check_for_leaks):
1208         * Scripts/webkitpy/port/darwin.py:
1209         (DarwinPort.check_for_leaks):
1210         - Rename redundant 'process_pid' argument to 'process_id'.
1211
1212         * Scripts/webkitpy/port/driver.py:
1213         (Driver.do_post_tests_work):
1214         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1215           longer the only command this sends to WebKitTestRunner.
1216         - If the `--leaks` switch is present, send the
1217           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1218           result using Port.set_webkit_processes().
1219         (Driver._parse_child_processes_output):
1220         - Add helper method to parse list of child process names and
1221           process IDs returned from WebKitTestRunner.
1222
1223         * Scripts/webkitpy/port/ios_device.py:
1224         (IOSDevicePort.check_for_leaks):
1225         - Rename redundant 'process_pid' argument to 'process_id'.
1226
1227         * Scripts/webkitpy/port/leakdetector.py:
1228         (LeakDetector._parse_leaks_output):
1229         - Return early if there is no leaks_output.
1230         (LeakDetector.check_for_leaks):
1231         - Rename redundant 'process_pid' argument to 'process_id'.
1232
1233         * Scripts/webkitpy/port/server_process.py:
1234         (ServerProcess.__init__):
1235         (ServerProcess.child_processes):
1236         (ServerProcess.set_child_processes):
1237         - Add instance variable to Port to store list of child process
1238           names and process IDs returned from WebKitTestRunner.
1239         (ServerProcess._start):
1240         - Clear self._child_processes.
1241         (ServerProcess.stop):
1242         - If self._child_processes is set, call
1243           self._port.check_for_leaks() for each child process.
1244
1245         * Scripts/webkitpy/port/server_process_unittest.py:
1246         (TrivialMockPort.check_for_leaks):
1247         - Rename redundant 'process_pid' argument to 'process_id'.
1248
1249         * Scripts/webkitpy/port/simulator_process.py:
1250         (SimulatorProcess.stop):
1251         - If self._child_processes is set, call
1252           self._port.check_for_leaks() for each child process.
1253
1254         * Scripts/webkitpy/port/watch_device.py:
1255         (WatchDevicePort.check_for_leaks):
1256         - Rename redundant 'process_pid' argument to 'process_id'.
1257
1258         * WebKitTestRunner/TestController.cpp:
1259         (WTR::TestController::dumpResponse):
1260         - Extract method from findAndDumpWorldLeaks() so that it may be
1261           reused by findAndDumpWebKitProcessIdentifiers().
1262         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1263         - Add method to output process name and process ID of both the
1264           WebContent and Networking processes.
1265         (WTR::TestController::findAndDumpWorldLeaks):
1266         - Fix missing newline in output when there were no abandoned
1267           documents.
1268         - Call dumpResponse() for extracted code.
1269         (WTR::TestController::handleControlCommand):
1270         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1271         - Use strncmp() instead of strcmp().
1272         - Call findAndDumpWebKitProcessIdentifiers() when
1273           "#LIST CHILD PROCESSES" command is sent.
1274         * WebKitTestRunner/TestController.h:
1275         (WTR::TestController::dumpResponse):
1276         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1277         - Declare methods.
1278
1279 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1280
1281         Unreviewed. Add GLib API test cases after r243434.
1282
1283         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1284         (testWebViewActiveURI):
1285         (serverCallback):
1286         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1287         (sendRequestCallback):
1288
1289 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1290
1291         Geolocation request not complete when watch request was started in a different web process
1292         https://bugs.webkit.org/show_bug.cgi?id=195996
1293
1294         Reviewed by Alex Christensen.
1295
1296         Add a test case.
1297
1298         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1299         (TestWebKitAPI::runJavaScriptAlert):
1300         (TestWebKitAPI::TEST):
1301
1302 2019-03-26  Keith Rollin  <krollin@apple.com>
1303
1304         Update the way generate-xcfilelists returns strings from functions
1305         https://bugs.webkit.org/show_bug.cgi?id=195975
1306         <rdar://problem/49040807>
1307
1308         Reviewed by Dean Jackson.
1309
1310         There are places where generate-xcfilelists executes assignments with
1311         statements like:
1312
1313             FOO=$(some_function)
1314
1315         where "some_function" return a string by echoing it. E.g.
1316
1317             some_function()
1318             {
1319                 echo "Hello, World"
1320             }
1321
1322         This is a common idiom, but it has a problem if "some_function" needs
1323         to call "exit" in an attempt to halt the entire script right then and
1324         there. Since "some_function" is called inside of $(), it's being
1325         executed in a sub-shell. Calling exit in that sub-shell simply exits
1326         that shell; it doesn't not exit the outer shell in which the main part
1327         of the script is still running. As such, the main script keeps
1328         executing when the intent was for the script to halt.
1329
1330         The solution to this is to use a different idiom for returning
1331         strings. The one we now is to pass in the name of the variable to
1332         receive the string result:
1333
1334             some_function()
1335             {
1336                 variable_name=$1
1337                 eval $variable_name ="Hello, World"
1338             }
1339
1340         The call site now looks like
1341
1342             some_function FOO
1343
1344         Because there's no invocation of a sub-shell, some_function can now
1345         call "exit" if it wants to, and the entire script will exit at that
1346         point.
1347
1348         * Scripts/generate-xcfilelists:
1349
1350 2019-03-26  Chris Dumez  <cdumez@apple.com>
1351
1352         Add basic layout test coverage for File Picker on iOS
1353         https://bugs.webkit.org/show_bug.cgi?id=196265
1354
1355         Reviewed by Wenson Hsieh.
1356
1357         Add layout test infrastructure to test the file picker on iOS.
1358
1359         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1360         (WTR::UIScriptController::dismissFilePicker):
1361         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1362         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1363         (WTR::UIScriptController::dismissFilePicker):
1364         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1365         * WebKitTestRunner/TestController.cpp:
1366         (WTR::TestController::createWebViewWithOptions):
1367         (WTR::updateTestOptionsFromTestHeader):
1368         * WebKitTestRunner/TestOptions.h:
1369         (WTR::TestOptions::hasSameInitializationOptions const):
1370         * WebKitTestRunner/ios/TestControllerIOS.mm:
1371         (overridePresentViewController):
1372         (WTR::TestController::platformInitialize):
1373         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1374         (WTR::UIScriptController::dismissFilePicker):
1375
1376 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1377
1378         Implement async paste method on UIWKInteractionViewProtocol
1379         https://bugs.webkit.org/show_bug.cgi?id=196267
1380         <rdar://problem/49236346>
1381
1382         Reviewed by Tim Horton.
1383
1384         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1385         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1386         are now a part of all iOS 12 internal SDKs.
1387
1388         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1389
1390         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1391         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1392
1393         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1394         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1395         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1396         * TestWebKitAPI/ios/UIKitSPI.h:
1397
1398 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1399
1400         [ews-build] Use PostgreSQL for ews.webkit.org database
1401         https://bugs.webkit.org/show_bug.cgi?id=196270
1402
1403         Reviewed by Lucas Forschler.
1404
1405         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1406
1407 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1408
1409         [ews] Reset simctl states on reboot
1410         https://bugs.webkit.org/show_bug.cgi?id=196260
1411
1412         Rubber-stamped by Aakash Jain.
1413
1414         * EWSTools/start-queue-mac.sh:
1415
1416 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1417
1418         [ews-build] Use PostgreSQL for ews-build database
1419         https://bugs.webkit.org/show_bug.cgi?id=196229
1420
1421         Reviewed by Lucas Forschler.
1422
1423         * BuildSlaveSupport/ews-build/master.cfg:
1424
1425 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1426
1427         [ews-build] Get master_hostname dynamically in master.cfg
1428         https://bugs.webkit.org/show_bug.cgi?id=196255
1429
1430         Reviewed by Lucas Forschler.
1431
1432         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1433         send events data in test mode.
1434
1435 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1436
1437         [ews-app] Set db_constraint to False for Foreign Keys
1438         https://bugs.webkit.org/show_bug.cgi?id=196252
1439
1440         Reviewed by Lucas Forschler.
1441
1442         * BuildSlaveSupport/ews-app/ews/models/build.py:
1443         * BuildSlaveSupport/ews-app/ews/models/step.py:
1444
1445 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1446
1447         [ews-build] is_test_mode_enabled should default to True
1448         https://bugs.webkit.org/show_bug.cgi?id=196248
1449
1450         Reviewed by Lucas Forschler.
1451
1452         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1453
1454 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1455
1456         [ews-app] Add webkitperl to ENABLED_QUEUES
1457         https://bugs.webkit.org/show_bug.cgi?id=196253
1458
1459         Reviewed by Lucas Forschler.
1460
1461         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1462
1463 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1464
1465         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1466         https://bugs.webkit.org/show_bug.cgi?id=196211
1467         rdar://problem/49110552
1468
1469         Reviewed by Tim Horton.
1470
1471         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1472         Make sure that EventSenderProxy always exists when running tests. We used to create
1473         it when resetting before the first test, which is a bit too late.
1474
1475         * WebKitTestRunner/TestController.h:
1476         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1477         (WTR::TestController::platformCreateWebView):
1478         (WTR::TestController::platformCreateOtherPage):
1479         (WTR::TestController::finishCreatingPlatformWebView):
1480         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1481         (WTR::PlatformWebView::PlatformWebView):
1482         Moved some code that made NSWindow use NSEvent during web view creation. We may
1483         need to move more if some other case us found, but this is enough for now.
1484
1485 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1486
1487         Unreviewed. Fix typo in GLib geolocation API after r243285.
1488
1489         gelocation -> geolocation.
1490
1491         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1492         (testGeolocationManagerWatchPosition):
1493
1494 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1495
1496         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1497         https://bugs.webkit.org/show_bug.cgi?id=196213
1498
1499         Reviewed by Geoff Garen.
1500
1501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1502         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1503         (credentialWithIdentityAndKeychainPath):
1504         (-[ChallengeDelegate webView:didFinishNavigation:]):
1505         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1506         (TestWebKitAPI::TEST):
1507
1508 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1509
1510         Expected shouldn't assume its contained types are copyable
1511         https://bugs.webkit.org/show_bug.cgi?id=195986
1512
1513         Reviewed by JF Bastien.
1514
1515         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1516         (TestWebKitAPI::NonCopyable::operator== const):
1517         (TestWebKitAPI::NonCopyable::operator!= const):
1518         (TestWebKitAPI::TEST):
1519
1520 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1521
1522         Remove some now-unnecessary dynamic class lookup
1523         https://bugs.webkit.org/show_bug.cgi?id=196237
1524
1525         Reviewed by Simon Fraser.
1526
1527         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1528         (makeRequest):
1529         (TEST):
1530
1531 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1532
1533         Unreviewed, rolling out r243450.
1534
1535         AppleWin and WinCairo port builds get broken.
1536
1537         Reverted changeset:
1538
1539         "Add test for fix of #196095"
1540         https://bugs.webkit.org/show_bug.cgi?id=196097
1541         https://trac.webkit.org/changeset/243450
1542
1543 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1544
1545         Unreviewed, rolling out r243465.
1546         https://bugs.webkit.org/show_bug.cgi?id=196226
1547
1548         the test doesn't build (Requested by thorton on #webkit).
1549
1550         Reverted changeset:
1551
1552         "Do not terminate the NetworkProcess if a third party
1553         application sends a NSCredential with a SecIdentityRef"
1554         https://bugs.webkit.org/show_bug.cgi?id=196213
1555         https://trac.webkit.org/changeset/243465
1556
1557 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1558
1559         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1560         https://bugs.webkit.org/show_bug.cgi?id=196213
1561
1562         Reviewed by Geoff Garen.
1563
1564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1565         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1566         (credentialWithIdentityAndKeychainPath):
1567         (-[ChallengeDelegate webView:didFinishNavigation:]):
1568         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1569         (TestWebKitAPI::TEST):
1570
1571 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1572
1573         [ews-build] Gracefully handle missing patch_id in events
1574         https://bugs.webkit.org/show_bug.cgi?id=196216
1575
1576         Reviewed by Lucas Forschler.
1577
1578         * BuildSlaveSupport/ews-build/events.py:
1579
1580 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1581
1582         [ews-build] use lz4 compression for improving buildbot performance
1583         https://bugs.webkit.org/show_bug.cgi?id=196155
1584
1585         Reviewed by Lucas Forschler.
1586
1587         * BuildSlaveSupport/ews-build/master.cfg:
1588
1589 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1590
1591         Pull some API testing helper methods out of TestWKWebView
1592         https://bugs.webkit.org/show_bug.cgi?id=196212
1593
1594         Reviewed by Tim Horton.
1595
1596         Refactor some more API testing utility methods, so that they can be used in
1597         tests that do not use TestWKWebView.
1598
1599         * TestWebKitAPI/cocoa/TestWKWebView.h:
1600         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1601         (-[WKWebView loadTestPageNamed:]):
1602         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1603         (-[WKWebView synchronouslyLoadHTMLString:]):
1604         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1605         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1606         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1607         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1608         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1609
1610 2019-03-25  Jer Noble  <jer.noble@apple.com>
1611
1612         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1613         https://bugs.webkit.org/show_bug.cgi?id=196097
1614
1615         Reviewed by Eric Carlson.
1616
1617         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1618
1619         * DumpRenderTree/mac/DumpRenderTree.mm:
1620         (resetWebPreferencesToConsistentValues):
1621         * WebKitTestRunner/TestController.cpp:
1622         (WTR::TestController::resetPreferencesToConsistentValues):
1623
1624 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1625
1626         Pull IPadUserInterfaceSwizzler out into a separate header file
1627         https://bugs.webkit.org/show_bug.cgi?id=196193
1628
1629         Reviewed by Anders Carlsson.
1630
1631         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1632         be used in other API tests.
1633
1634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1635         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1636         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1637         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1638         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1639         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1640         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1641
1642 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1643
1644         Remove NavigatorContentUtils in WebCore/Modules
1645         https://bugs.webkit.org/show_bug.cgi?id=196070
1646
1647         Reviewed by Alex Christensen.
1648
1649         NavigatorContentUtils was to support the custom scheme spec [1].
1650         However, in WebKit side, no port has supported the feature in
1651         WebKit layer after EFL port was removed. So there has been the
1652         only IDL implementation of the NavigatorContentUtils in WebCore.
1653         So we don't need to keep the implementation in WebCore anymore.
1654
1655         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1656
1657         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1658
1659 2019-03-24  Andy Estes  <aestes@apple.com>
1660
1661         [watchOS] Remove unused Proximity Networking code
1662         https://bugs.webkit.org/show_bug.cgi?id=196188
1663
1664         Reviewed by Tim Horton.
1665
1666         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1667         (TEST):
1668
1669 2019-03-23  Keith Miller  <keith_miller@apple.com>
1670
1671         Refactor clz/ctz and fix getLSBSet.
1672         https://bugs.webkit.org/show_bug.cgi?id=196162
1673
1674         Reviewed by Saam Barati.
1675
1676         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1677
1678         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1679         (TestWebKitAPI::TEST):
1680
1681 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1682
1683         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1684         https://bugs.webkit.org/show_bug.cgi?id=196143
1685
1686         Reviewed by Michael Catanzaro.
1687
1688         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1689         directories.
1690
1691         * Scripts/webkitpy/style/checkers/cpp.py:
1692         (check_identifier_name_in_declaration):
1693         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1694         (WebKitStyleTest.test_names):
1695
1696 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1697
1698         [Flatpak] Manifest expanding fails for qt WPE extension
1699         https://bugs.webkit.org/show_bug.cgi?id=196148
1700
1701         Reviewed by Alex Christensen.
1702
1703         * flatpak/flatpakutils.py:
1704         (expand_submodules_recurse): The last recurse manifest expand
1705         iteration might lead to a single module so take it into account
1706         and don't try to recurse further.
1707
1708 2019-03-22  Chris Dumez  <cdumez@apple.com>
1709
1710         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1711         https://bugs.webkit.org/show_bug.cgi?id=195348
1712         <rdar://problem/48622090>
1713
1714         Reviewed by Alex Christensen.
1715
1716         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1717         to NO when test.options().shouldIgnoreMetaViewport is false.
1718
1719         * WebKitTestRunner/ios/TestControllerIOS.mm:
1720         (WTR::TestController::platformConfigureViewForTest):
1721
1722 2019-03-22  Chris Dumez  <cdumez@apple.com>
1723
1724         Prewarmed processes should be usable with any website data store
1725         https://bugs.webkit.org/show_bug.cgi?id=196104
1726
1727         Reviewed by Alex Christensen.
1728
1729         Add API test coverage.
1730
1731         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1732         (runInitialWarmedProcessUsedTest):
1733         (TEST):
1734
1735 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1736
1737         Back out local changes to Alex's Subversion working directory
1738
1739         They were accidentally committed.
1740
1741         * Scripts/webkitpy/common/system/abstractexecutive.py:
1742         (AbstractExecutive.wait_newest):
1743         * Scripts/webkitpy/common/system/executive.py:
1744         (Executive.running_pids):
1745         * Scripts/webkitpy/common/system/executive_mock.py:
1746         (MockExecutive.running_pids):
1747         * Scripts/webkitpy/common/system/executive_unittest.py:
1748         (ExecutiveTest.serial_test_running_pids):
1749         * Scripts/webkitpy/port/darwin.py:
1750         (DarwinPort.check_for_leaks):
1751         * Scripts/webkitpy/port/leakdetector.py:
1752         (LeakDetector.check_for_leaks):
1753         - This was the hack attached to Bug 193772.
1754
1755         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1756         (+[WebKitTestRunnerEvent mouseLocation]):
1757         - This works around a crash on an internal build.
1758
1759 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1760
1761         Fix the build after r243354
1762         https://bugs.webkit.org/show_bug.cgi?id=196138
1763         <rdar://problem/49145951>
1764
1765         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1766         (TEST):
1767         * TestWebKitAPI/ios/UIKitSPI.h:
1768
1769 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1770
1771         Adopt UIWKDocumentContext
1772         https://bugs.webkit.org/show_bug.cgi?id=196040
1773         <rdar://problem/48642440>
1774
1775         Reviewed by Ryosuke Niwa.
1776
1777         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1778         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1779         (makeRequest):
1780         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1781         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1782         (applyStyle):
1783         (TEST):
1784         Add tests for UIWKDocumentContext.
1785
1786         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1787         (TEST):
1788         (recursiveFindWKContentView): Deleted.
1789         * TestWebKitAPI/cocoa/TestWKWebView.h:
1790         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1791         (recursiveFindWKContentView):
1792         (-[TestWKWebView wkContentView]):
1793         * TestWebKitAPI/ios/UIKitSPI.h:
1794         Share the WKContentView finding code between tests.
1795
1796 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1797
1798         [iOS WK2] Turn on async overflow scrolling by default
1799         https://bugs.webkit.org/show_bug.cgi?id=196011
1800         rdar://problem/48453859
1801
1802         Reviewed by Antti Koivisto.
1803         
1804         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1805         since so many basic layout tests have different results when compositing is triggered for
1806         overflow.
1807         
1808         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1809
1810         * WebKitTestRunner/TestController.cpp:
1811         (WTR::TestController::resetPreferencesToConsistentValues):
1812
1813 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1814
1815         [ews-build] Retry API test in case of failures
1816         https://bugs.webkit.org/show_bug.cgi?id=196004
1817
1818         Reviewed by Lucas Forschler.
1819
1820         * BuildSlaveSupport/ews-build/steps.py:
1821         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1822         (CompileWebKitToT.doStepIf): Ditto.
1823         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1824         (ReRunAPITests): Re-run API tests.
1825         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1826         (RunAPITestsWithoutPatch): Run API tests without patch.
1827         (RunAPITestsWithoutPatch.doStepIf):
1828         (RunAPITestsWithoutPatch.hideStepIf):
1829         (RunAPITestsWithoutPatch.evaluateCommand):
1830         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1831         (AnalyzeAPITestsResults.start):
1832         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1833         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1834         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1835         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1836
1837 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1838
1839         [ews-build] Update queues configurations
1840         https://bugs.webkit.org/show_bug.cgi?id=196074
1841
1842         Reviewed by Dewei Zhu.
1843
1844         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1845         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1846
1847 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1848
1849         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1850         https://bugs.webkit.org/show_bug.cgi?id=195680
1851         <rdar://problem/48903534>
1852
1853         Unreviewed infrastructure fix.
1854
1855         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1856         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1857
1858 2019-03-21  Andy Estes  <aestes@apple.com>
1859
1860         [iOS] Apple Pay should be available in documents with no user agent scripts
1861         https://bugs.webkit.org/show_bug.cgi?id=196061
1862         <rdar://problem/48649391>
1863
1864         Reviewed by Brady Eidson.
1865
1866         Added API tests and related infrastructure.
1867
1868         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1869         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1870         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1871         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1872         (TestWebKitAPI::TEST):
1873         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1874         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1875         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1876         * TestWebKitAPI/cocoa/TestProtocol.mm:
1877         (-[TestProtocol startLoading]):
1878         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1879         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1880         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1881         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1882
1883 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1884
1885         REGRESSSION (r243297): webkitpy tests broken
1886         https://bugs.webkit.org/show_bug.cgi?id=196108
1887
1888         Reviewed by Aakash Jain.
1889
1890         r243297 updated contributors.json, which broke a few unit tests.
1891
1892         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1893         (IRCCommandTest.test_whois):
1894         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1895
1896 2019-03-21  Chris Dumez  <cdumez@apple.com>
1897
1898         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1899         https://bugs.webkit.org/show_bug.cgi?id=196041
1900         <rdar://problem/49083230>
1901
1902         Reviewed by Alex Christensen.
1903
1904         Add API test coverage.
1905
1906         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1907         (TEST):
1908
1909 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1910
1911         Add SPI to inform applications of WKContentRuleList actions
1912         https://bugs.webkit.org/show_bug.cgi?id=195965
1913         <rdar://problem/42664365>
1914
1915         Reviewed by Geoff Garen.
1916
1917         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1918         (TestWebKitAPI::allActionsForResourceLoad):
1919         (TestWebKitAPI::testRequest):
1920         (TestWebKitAPI::TEST_F):
1921         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1922         (Notification::description):
1923         (Notification::operator== const):
1924         (toVector):
1925         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1926         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1927         (makeContentRuleList):
1928         (TEST):
1929         (makeWarnContentRuleList): Deleted.
1930
1931 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1932
1933         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1934         https://bugs.webkit.org/show_bug.cgi?id=196088
1935
1936         Reviewed by Brian Burg.
1937
1938         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1939         Support checks when only one platform is specified. Also deprecate macosx() and
1940         force the use of macos() instead.
1941
1942         * Scripts/webkitpy/style/checkers/cpp.py:
1943         (check_min_versions_of_wk_api_available):
1944         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1945         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1946
1947 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1948
1949         Update status inactive committers' status to 'contributor'.
1950
1951         * Scripts/webkitpy/common/config/contributors.json:
1952
1953 2019-03-21  Xan Lopez  <xan@igalia.com>
1954
1955         [JSC][x86] Drop support for x87 floating point
1956         https://bugs.webkit.org/show_bug.cgi?id=194853
1957
1958         Reviewed by Don Olmstead.
1959
1960         Force SSE2 on x86/32bit builds.
1961
1962         * Scripts/webkitdirs.pm:
1963         (generateBuildSystemFromCMakeProject):
1964
1965 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1966
1967         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1968         https://bugs.webkit.org/show_bug.cgi?id=196073
1969
1970         Reviewed by Michael Catanzaro.
1971
1972         Add test cases to check functions and constructors with no arguments but receiving user data.
1973
1974         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1975         (checkUserData):
1976         (testJSCFunction):
1977         (fooCreateWithUserData):
1978         (testJSCClass):
1979
1980 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1981
1982         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1983
1984         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1985
1986         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1987
1988 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1989
1990         [GTK][WPE] Add API to provide geolocation information
1991         https://bugs.webkit.org/show_bug.cgi?id=195940
1992
1993         Reviewed by Michael Catanzaro.
1994
1995         Add a new test to check the new API.
1996
1997         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1998         (testGeolocationManagerCurrentPosition):
1999         (testGeolocationManagerWatchPosition):
2000         (beforeAll):
2001         (afterAll):
2002         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2003         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2004         (beforeAll): Ditto.
2005         * TestWebKitAPI/glib/CMakeLists.txt:
2006
2007 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2008
2009         [GLib] Returning G_TYPE_OBJECT from a method does not work
2010         https://bugs.webkit.org/show_bug.cgi?id=195574
2011
2012         Reviewed by Michael Catanzaro.
2013
2014         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2015
2016         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2017         (getGFile):
2018         (getParent):
2019         (createGString):
2020         (getGString):
2021         (getGStringCopyWillRaise):
2022         (getGStringCopy):
2023         (getGStringStr):
2024         (getGStringLen):
2025         (freeGString):
2026         (testJSCClass):
2027
2028 2019-03-20  Saam Barati  <sbarati@apple.com>
2029
2030         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2031         https://bugs.webkit.org/show_bug.cgi?id=195721
2032
2033         Reviewed by Filip Pizlo.
2034
2035         * Scripts/run-javascriptcore-tests:
2036
2037 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2038
2039         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2040         https://bugs.webkit.org/show_bug.cgi?id=196049
2041
2042         Reviewed by Tim Horton.
2043
2044         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2045         overflow scrolling in general, so rename it.
2046
2047         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2048
2049 2019-03-20  Daniel Bates  <dabates@apple.com>
2050
2051         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2052         https://bugs.webkit.org/show_bug.cgi?id=196031
2053         <rdar://problem/49078172>
2054
2055         Reviewed by Tim Horton.
2056
2057         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2058         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2059         same code path used when the Done button is pressed to dismiss the <select> picker.
2060
2061         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2062         (TestWebKitAPI::TEST):
2063
2064 2019-03-20  Chris Dumez  <cdumez@apple.com>
2065
2066         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2067         https://bugs.webkit.org/show_bug.cgi?id=196029
2068         <rdar://problem/48954651>
2069
2070         Reviewed by Tim Horton.
2071
2072         Add API test coverage.
2073
2074         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2075
2076 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2077
2078         [ews-build] Improve failure summary string for ApplyPatch step
2079         https://bugs.webkit.org/show_bug.cgi?id=195995
2080
2081         Reviewed by Alexey Proskuryakov.
2082
2083         * BuildSlaveSupport/ews-build/steps.py:
2084         (ApplyPatch.getResultSummary): Override getResultSummary.
2085
2086 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2087
2088         AX: Implement support for new meter ARIA role
2089         https://bugs.webkit.org/show_bug.cgi?id=195966
2090
2091         Reviewed by Chris Fleizach.
2092
2093         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2094         to AXLevelIndicator.
2095
2096         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2097
2098 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2099
2100         [WebAuthN] Implement FIDO AppID extension
2101         https://bugs.webkit.org/show_bug.cgi?id=143491
2102         <rdar://problem/48298273>
2103
2104         Reviewed by Brent Fulgham.
2105
2106         Add a test that covers the new flag of convertToU2fSignCommand.
2107
2108         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2109         (TestWebKitAPI::TEST):
2110         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2111         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2112         (TestWebKitAPI::TEST):
2113
2114 2019-03-19  Keith Rollin  <krollin@apple.com>
2115
2116         Add support for more platforms to generate-xcfilelists
2117         https://bugs.webkit.org/show_bug.cgi?id=195977
2118
2119         Reviewed by Alexey Proskuryakov.
2120
2121         generate-xcfilelists incorrectly complains when involved with building
2122         WebKit for iphonesimulator:
2123
2124             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2125             …
2126             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2127
2128         Address this by teaching generate-xcfilelists about more platforms.
2129
2130         * Scripts/generate-xcfilelists:
2131
2132 2019-03-19  John Wilander  <wilander@apple.com>
2133
2134         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2135         https://bugs.webkit.org/show_bug.cgi?id=195923
2136         <rdar://problem/49001272>
2137
2138         Reviewed by Alex Christensen.
2139
2140         This patch does the following to the TestRunner:
2141         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2142         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2143         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2144
2145         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2146         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2147         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2148         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2149         * WebKitTestRunner/TestController.cpp:
2150         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2151         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2152         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2153         * WebKitTestRunner/TestController.h:
2154         * WebKitTestRunner/TestInvocation.cpp:
2155         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2156
2157 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2158
2159         [CMake] Support more clang and gcc sanitizers
2160         https://bugs.webkit.org/show_bug.cgi?id=195956
2161
2162         Reviewed by Michael Catanzaro.
2163
2164         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2165
2166 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2167
2168         [ews-build] Improve summary for PrintConfiguration step
2169         https://bugs.webkit.org/show_bug.cgi?id=195945
2170
2171         Reviewed by Lucas Forschler.
2172
2173         * BuildSlaveSupport/ews-build/steps.py:
2174         (PrintConfiguration.getResultSummary): Override getResultSummary.
2175
2176 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2177
2178         [ews-build] Improve summary for CheckOutSource step
2179         https://bugs.webkit.org/show_bug.cgi?id=195963
2180
2181         Reviewed by Lucas Forschler.
2182
2183         * BuildSlaveSupport/ews-build/steps.py:
2184         (CheckOutSource.getResultSummary):
2185
2186 2019-03-19  Daniel Bates  <dabates@apple.com>
2187
2188         [iOS] Focus not preserved when switching between tabs
2189         https://bugs.webkit.org/show_bug.cgi?id=195820
2190         <rdar://problem/43614450>
2191
2192         Reviewed by Brent Fulgham.
2193
2194         Add tests to ensure that we restore focus when resigning and becoming first responder.
2195
2196         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2197         (TestWebKitAPI::TEST):
2198
2199 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2200
2201         Make WTFLogChannelState and WTFLogLevel enum classes
2202         https://bugs.webkit.org/show_bug.cgi?id=195904
2203
2204         Reviewed by Eric Carlson.
2205
2206         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2207         (TestWebKitAPI::TEST_F):
2208
2209 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2210
2211         [GStreamer][EME] Backported mssdemux protection data crash fix
2212         https://bugs.webkit.org/show_bug.cgi?id=195918
2213
2214         Reviewed by Philippe Normand.
2215
2216         * gstreamer/jhbuild.modules:
2217         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2218
2219 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2220
2221         Unreviewed, rolling out r243132.
2222
2223         Broke GTK build
2224
2225         Reverted changeset:
2226
2227         "Make WTFLogChannelState and WTFLogLevel enum classes"
2228         https://bugs.webkit.org/show_bug.cgi?id=195904
2229         https://trac.webkit.org/changeset/243132
2230
2231 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2232
2233         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2234
2235         * Scripts/webkitdirs.pm:
2236         (builtDylibPathForName): Adjust the shared library name that's changed
2237         with the API version bump in r243073.
2238
2239 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2240
2241         Make WTFLogChannelState and WTFLogLevel enum classes
2242         https://bugs.webkit.org/show_bug.cgi?id=195904
2243
2244         Reviewed by Eric Carlson.
2245
2246         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2247         (TestWebKitAPI::TEST_F):
2248
2249 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2250
2251         Disable flaky test added in r2431100
2252         https://webkit.org/b/195785
2253
2254         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2255         (TestWebKitAPI::TEST):
2256         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2257
2258 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2259
2260         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2261         https://bugs.webkit.org/show_bug.cgi?id=195916
2262
2263         Reviewed by Tim Horton.
2264
2265         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2266         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2267
2268 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2269
2270         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2271
2272         * Scripts/webkitpy/common/config/contributors.json:
2273
2274 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2275
2276         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2277         https://bugs.webkit.org/show_bug.cgi?id=195785
2278
2279         Reviewed by Geoffrey Garen.
2280
2281         * TestWebKitAPI/TCPServer.cpp: Added.
2282         (TestWebKitAPI::TCPServer::TCPServer):
2283         (TestWebKitAPI::TCPServer::~TCPServer):
2284         (TestWebKitAPI::TCPServer::socketBindListen):
2285         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2286         * TestWebKitAPI/TCPServer.h: Added.
2287         (TestWebKitAPI::TCPServer::port const):
2288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2289         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2290         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2291         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2292         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2293         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2294         (TestWebKitAPI::respondSlowly):
2295         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2296         (TestWebKitAPI::downloadAtRate):
2297         (TestWebKitAPI::TEST):
2298
2299 2019-03-18  Saam Barati  <sbarati@apple.com>
2300
2301         Add a plan file for JetStream 2
2302         https://bugs.webkit.org/show_bug.cgi?id=190734
2303
2304         Reviewed by Mark Lam.
2305
2306         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2307
2308 2019-03-18  Chris Dumez  <cdumez@apple.com>
2309
2310         Delay WebProcess launch until a load is triggered in a Web view
2311         https://bugs.webkit.org/show_bug.cgi?id=195758
2312         <rdar://problem/48126013>
2313
2314         Reviewed by Geoff Garen.
2315
2316         Add API test coverage. Also update some existing API tests to not expect
2317         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2318
2319         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2320         (TestWebKitAPI::TEST):
2321         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2322         (TestWebKitAPI::TEST):
2323         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2324         (TEST):
2325         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2326         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2327         (TEST):
2328         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2329         (TEST):
2330         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2331
2332 2019-03-18  Xan Lopez  <xan@igalia.com>
2333
2334         [CMake] Prevent potential warning when determining $architecture
2335         https://bugs.webkit.org/show_bug.cgi?id=195891
2336
2337         Reviewed by Michael Catanzaro.
2338
2339         It's possible for generateBuildSystemForCMakeProject to be called
2340         before determineArchitecture() is ever called. This will make the
2341         first eq check with $architecture to be bogus (and print a
2342         warning). Change that to an eq check with architecture(), which
2343         implicitly calls determineArchitecture() if needed, and change all
2344         the other similar cases in the method in the same way to prevent
2345         future bugs like this one.
2346
2347         * Scripts/webkitdirs.pm:
2348         (generateBuildSystemFromCMakeProject):
2349
2350 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2351
2352         [WPE] Tarballs generated with “make dist” cannot build documentation
2353         https://bugs.webkit.org/show_bug.cgi?id=195885
2354
2355         Reviewed by Carlos Garcia Campos.
2356
2357         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2358
2359 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2360
2361         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2362         https://bugs.webkit.org/show_bug.cgi?id=195883
2363
2364         Reviewed by Carlos Garcia Campos.
2365
2366         * gtkdoc/gtkdoc.py:
2367         (GTKDoc._run_command): When commands fail to run, include the full command line for
2368         the program invocation and the output it has generated on the standard error stream.
2369
2370 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2371
2372         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2373         https://bugs.webkit.org/show_bug.cgi?id=195786
2374
2375         Reviewed by Philippe Normand.
2376
2377         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2378         * wpe/jhbuild.modules: Ditto.
2379
2380 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2381
2382         [ews-build] Don't run clean builds on EWS builders
2383         https://bugs.webkit.org/show_bug.cgi?id=195851
2384
2385         Reviewed by Geoffrey Garen.
2386
2387         * BuildSlaveSupport/ews-build/factories.py:
2388
2389 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2390
2391         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2392         https://bugs.webkit.org/show_bug.cgi?id=195849
2393
2394         Reviewed by Chris Dumez.
2395
2396         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2397
2398         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2399         (runWebsiteDataStoreCustomPaths):
2400
2401 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2402
2403         webkitpy: Upload test results
2404         https://bugs.webkit.org/show_bug.cgi?id=195755
2405         <rdar://problem/48896182>
2406
2407         Reviewed by Aakash Jain.
2408
2409         Establish a new format for uploading results that is not tied to layout tests, apply
2410         that format to webkitpy tests.
2411
2412         * Scripts/webkitpy/common/checkout/scm/git.py:
2413         (Git.native_branch): Return what branch the current checkout is on.
2414         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2415         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2416         * Scripts/webkitpy/common/checkout/scm/svn.py:
2417         (SVN.native_branch): Ditto.
2418         * Scripts/webkitpy/common/system/platforminfo.py:
2419         (PlatformInfo.build_version): Return a build version for Mac.
2420         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2421         (MockPlatformInfo.__init__):
2422         (MockPlatformInfo.build_version):
2423         * Scripts/webkitpy/results: Added.
2424         * Scripts/webkitpy/results/__init__.py: Added.
2425         * Scripts/webkitpy/results/options.py: Added.
2426         (upload_options): OptParse list for upload options.
2427         * Scripts/webkitpy/results/upload.py: Added.
2428         (Upload): Class which enforces the upload format expected by the results server.
2429         (Upload.Expectations):
2430         (Upload.create_configuration):
2431         (Upload.create_commit):
2432         (Upload.create_details):
2433         (Upload.create_run_stats):
2434         (Upload.create_test_result):
2435         (Upload.__init__):
2436         (Upload.Encoder): Encode Upload object as json.
2437         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2438         * Scripts/webkitpy/results/upload_unittest.py: Added.
2439         * Scripts/webkitpy/test/main.py:
2440         (Tester._parse_args): Add upload arguments.
2441         (Tester._run_tests): Allow results to be uploaded.
2442         * Scripts/webkitpy/test/runner.py:
2443         (Runner.__init__): Record which tests were run, rather than just counting them.
2444         (Runner.handle):
2445         * Scripts/webkitpy/test/runner_unittest.py:
2446         (RunnerTest.test_run):
2447         * Scripts/webkitpy/thirdparty/__init__.py:
2448         (AutoinstallImportHook.find_module): Add requests auto-install.
2449         (AutoinstallImportHook._install_requests):
2450         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2451         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2452
2453 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2454
2455         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2456         https://bugs.webkit.org/show_bug.cgi?id=195810
2457
2458         Reviewed by Tim Horton.
2459
2460         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2461         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2462         ending certain layout tests.
2463
2464         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2465         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2466         (-[TestRunnerWKWebView dealloc]):
2467         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2468
2469         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2470         helper method when destroying the web view, and when resetting state between tests.
2471
2472         * WebKitTestRunner/ios/TestControllerIOS.mm:
2473         (WTR::TestController::platformResetStateToConsistentValues):
2474
2475         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2476
2477 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2478
2479         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2480         https://bugs.webkit.org/show_bug.cgi?id=190350
2481         <rdar://problem/45089503>
2482
2483         Reviewed by Geoffrey Garen.
2484
2485         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2486         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2487         (TEST):
2488         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2489         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2490         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2491         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2492         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2493         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2494         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2495         (runTest):
2496         (createDirectories):
2497         (TEST):
2498         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2499         (TEST):
2500         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2501         (TEST):
2502
2503 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2504
2505         Add support to WebPage for getting the contents as an attributed string.
2506         https://bugs.webkit.org/show_bug.cgi?id=195636
2507         rdar://problem/45055697
2508
2509         Reviewed by Tim Horton.
2510
2511         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2512         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2513
2514 2019-03-15  Chris Dumez  <cdumez@apple.com>
2515
2516         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2517         https://bugs.webkit.org/show_bug.cgi?id=195747
2518
2519         Reviewed by Geoff Garen.
2520
2521         Add API test coverage.
2522
2523         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2524
2525 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2526
2527         Unreviewed, rolling out r242952.
2528
2529         Causing API failures on iOS Simulator
2530
2531         Reverted changeset:
2532
2533         "[PSON] Make sure the WebProcessCache is leverage when
2534         relaunching a process after termination"
2535         https://bugs.webkit.org/show_bug.cgi?id=195747
2536         https://trac.webkit.org/changeset/242952
2537
2538 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2539
2540         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2541         https://bugs.webkit.org/show_bug.cgi?id=195740
2542
2543         Reviewed by Ross Kirsling.
2544
2545         window.open doesn't work for WebKitBrowserWindow because it is not
2546         implemented yet.
2547
2548         1. Implemented createNewPage callback of WKPageUIClient.
2549         2. Changed MainWindow to take a BrowserWindow factory function
2550           instead of BrowserWindowType to be flexible to create
2551           BrowserWindow with extra settings.
2552         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2553           because it is not relevant with MainWindow anymore.
2554
2555         * MiniBrowser/win/Common.cpp:
2556         (parseCommandLine):
2557         * MiniBrowser/win/Common.h:
2558         (CommandLineOptions::CommandLineOptions):
2559         * MiniBrowser/win/MainWindow.cpp:
2560         (MainWindow::MainWindow):
2561         (MainWindow::create):
2562         (MainWindow::init):
2563         (MainWindow::WndProc):
2564         * MiniBrowser/win/MainWindow.h:
2565         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2566         (PrintWebUIDelegate::createWebViewWithRequest):
2567         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2568         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2569         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2570         (WebKitBrowserWindow::updateProxySettings):
2571         (WebKitBrowserWindow::createNewPage):
2572         * MiniBrowser/win/WebKitBrowserWindow.h:
2573         * MiniBrowser/win/WinMain.cpp:
2574         (wWinMain):
2575
2576 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2577
2578         Make it possible to test scrolling tree layer manipulation more easily
2579         https://bugs.webkit.org/show_bug.cgi?id=195780
2580
2581         Reviewed by Tim Horton.
2582         
2583         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2584         cuts off communication of scrolling tree scrolls back to the web process
2585         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2586         allows tests to trigger scrolls which run the scrolling tree layer positioning
2587         logic, but never get another commit from the web process that might mask
2588         scrolling tree bugs.
2589         
2590         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2591         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2592         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2593
2594         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2595         (WTR::UIScriptController::scrollUpdatesDisabled const):
2596         (WTR::UIScriptController::setScrollUpdatesDisabled):
2597         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2598         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2599         (WTR::UIScriptController::scrollUpdatesDisabled const):
2600         (WTR::UIScriptController::setScrollUpdatesDisabled):
2601         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2602         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2603         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2604         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2605         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2606         * WebKitTestRunner/ios/TestControllerIOS.mm:
2607         (WTR::TestController::platformResetStateToConsistentValues):
2608         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2609         (WTR::UIScriptController::scrollUpdatesDisabled const):
2610         (WTR::UIScriptController::setScrollUpdatesDisabled):
2611
2612 2019-03-14  Youenn Fablet  <youenn@apple.com>
2613
2614         Move IDB storage in private browsing mode to NetworkProcess
2615         https://bugs.webkit.org/show_bug.cgi?id=195602
2616
2617         Reviewed by Brady Eidson.
2618
2619         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2620         (TEST):
2621
2622 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2623
2624         [ews-build] Make descriptionDone messages more readable
2625         https://bugs.webkit.org/show_bug.cgi?id=195760
2626
2627         Reviewed by Lucas Forschler.
2628
2629         * BuildSlaveSupport/ews-build/steps.py:
2630         * BuildSlaveSupport/ews-build/steps_unittest.py:
2631
2632 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2633
2634         [ews-build] Generate status-bubble hover-over messages
2635         https://bugs.webkit.org/show_bug.cgi?id=195680
2636
2637         Reviewed by Lucas Forschler.
2638
2639         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2640         (StatusBubble):
2641         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2642         on hover-over.
2643         (StatusBubble._iso_time):
2644         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2645         hover-over message.
2646         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2647
2648 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2649
2650         [ews-app] Gracefully handle the case when state_string is None
2651         https://bugs.webkit.org/show_bug.cgi?id=195753
2652
2653         Reviewed by Lucas Forschler.
2654
2655         * BuildSlaveSupport/ews-app/ews/models/build.py:
2656         * BuildSlaveSupport/ews-app/ews/models/step.py:
2657
2658 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2659
2660         [ews-app] Status bubble display pending for currently running build step
2661         https://bugs.webkit.org/show_bug.cgi?id=195744
2662
2663         Reviewed by Lucas Forschler.
2664
2665         * BuildSlaveSupport/ews-build/events.py:
2666         (Events.stepStarted): If state_string is pending, replace it with step name.
2667
2668 2019-03-14  Chris Dumez  <cdumez@apple.com>
2669
2670         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2671         https://bugs.webkit.org/show_bug.cgi?id=195750
2672
2673         Reviewed by Geoffrey Garen.
2674
2675         Add API test coverage.
2676
2677         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2678         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2679         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2680         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2681
2682 2019-03-14  Chris Dumez  <cdumez@apple.com>
2683
2684         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2685         https://bugs.webkit.org/show_bug.cgi?id=195747
2686
2687         Reviewed by Geoff Garen.
2688
2689         Add API test coverage.
2690
2691         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2692
2693 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2694
2695         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2696         https://bugs.webkit.org/show_bug.cgi?id=195725
2697         <rdar://problem/48545062>
2698
2699         Reviewed by Tim Horton.
2700
2701         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2702         handler is nil.
2703
2704         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2705         (TestWebKitAPI::TEST):
2706
2707 2019-03-13  Sam Weinig  <sam@webkit.org>
2708
2709         Add utility function to allow easy reverse range-based iteration of a container
2710         https://bugs.webkit.org/show_bug.cgi?id=195542
2711
2712         Reviewed by Antti Koivisto.
2713
2714         * TestWebKitAPI/CMakeLists.txt:
2715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2716         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2717         (TestWebKitAPI::TEST):
2718         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2719
2720 2019-03-13  Chris Dumez  <cdumez@apple.com>
2721
2722         Use a ServiceWorker process per registrable domain
2723         https://bugs.webkit.org/show_bug.cgi?id=195649
2724
2725         Reviewed by Youenn Fablet.
2726
2727         Update API test coverage.
2728
2729         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2730
2731 2019-03-13  Chris Dumez  <cdumez@apple.com>
2732
2733         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2734         https://bugs.webkit.org/show_bug.cgi?id=195684
2735         <rdar://problem/48294714>
2736
2737         Reviewed by Antti Koivisto.
2738
2739         Add API test coverage.
2740
2741         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2742
2743 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2744
2745         [ews-app] Remove unused patch view
2746         https://bugs.webkit.org/show_bug.cgi?id=195669
2747
2748         Reviewed by Lucas Forschler.
2749
2750         * BuildSlaveSupport/ews-app/ews/urls.py:
2751         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2752
2753 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2754
2755         [ews-app] Use Buildbot result code variables
2756         https://bugs.webkit.org/show_bug.cgi?id=195668
2757
2758         Reviewed by Alexey Proskuryakov.
2759
2760         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2761         (Buildbot): Added Buildbot result code variables.
2762         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2763         (StatusBubble._build_bubble): Used Buildbot result code variables.
2764
2765 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2766
2767         [Flatpak] Expand submodule recursively
2768         https://bugs.webkit.org/show_bug.cgi?id=195672
2769
2770         Building WPE with flatpak was impossible without that as it was raising an exception.
2771         Also update wpebackend-fdo to match what is built in jhbuild
2772
2773         Reviewed by Philippe Normand.
2774
2775         * flatpak/flatpakutils.py:
2776         (expand_submodules_recurse):
2777         (expand_manifest):
2778         * flatpak/org.webkit.WPEModules.yaml:
2779
2780 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2781
2782         [ews-app] status bubble should be hidden for certain builds
2783         https://bugs.webkit.org/show_bug.cgi?id=194597
2784
2785         Reviewed by Dewei Zhu.
2786
2787         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2788         (StatusBubble._build_bubble):
2789         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2790         because the patch didn't have relevant changes.
2791         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2792         in production yet.
2793
2794 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2795
2796         [Win] Fix a slew of simple clang-cl warnings.
2797         https://bugs.webkit.org/show_bug.cgi?id=195652
2798
2799         Reviewed by Don Olmstead.
2800
2801         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2802         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2803
2804 2019-03-12  Justin Fan  <justin_fan@apple.com>
2805
2806         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2807         https://bugs.webkit.org/show_bug.cgi?id=195518
2808         <rdar://problem/46322356>
2809
2810         Reviewed by Myles C. Maxfield.
2811
2812         * DumpRenderTree/DerivedSources-input.xcfilelist:
2813         * DumpRenderTree/DerivedSources-output.xcfilelist:
2814
2815 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2816
2817         Unreviewed, rolling out r242825.
2818         https://bugs.webkit.org/show_bug.cgi?id=195648
2819
2820         "Broke webkitpy tests with my change to
2821         lldb_dump_class_layout.py" (Requested by rmorisset on
2822         #webkit).
2823
2824         Reverted changeset:
2825
2826         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2827         classes with suspicious padding"
2828         https://bugs.webkit.org/show_bug.cgi?id=195573
2829         https://trac.webkit.org/changeset/242825
2830
2831 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2832
2833         [ews-build] Show status bubbles while the patch is waiting in queue
2834         https://bugs.webkit.org/show_bug.cgi?id=195618
2835
2836         Reviewed by Lucas Forschler.
2837
2838         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2839         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2840         enabled in initial deployment.
2841         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2842         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2843         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2844         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2845         (StatusBubble._build_bubbles_for_patch):
2846
2847 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2848
2849         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2850         https://bugs.webkit.org/show_bug.cgi?id=195573
2851
2852         Reviewed by Simon Fraser.
2853
2854         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2855
2856         * Scripts/dump-class-layout:
2857         (main):
2858         * lldb/lldb_dump_class_layout.py:
2859         (ClassLayout.__init__):
2860         (ClassLayout._compute_padding_recursive):
2861         (LLDBDebuggerInstance.dump_layout_for_classname):
2862         (LLDBDebuggerInstance):
2863         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2864         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2865
2866 2019-03-12  Chris Dumez  <cdumez@apple.com>
2867
2868         Device Orientation access permission should be denied unless explicitly granted by the client
2869         https://bugs.webkit.org/show_bug.cgi?id=195625
2870
2871         Reviewed by Youenn Fablet.
2872
2873         add API test coverage.
2874
2875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2876         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2877         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2878         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2879         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2880         (runDeviceOrientationTest):
2881         (TEST):
2882         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2883         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2884
2885 2019-03-12  Jer Noble  <jer.noble@apple.com>
2886
2887         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2888         https://bugs.webkit.org/show_bug.cgi?id=195137
2889         <rdar://problem/48810307>
2890
2891         Reviewed by Eric Carlson.
2892
2893         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2894         (TestWebKitAPI::TEST):
2895
2896 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2897
2898         [ews-build] Change urls from uat to production
2899         https://bugs.webkit.org/show_bug.cgi?id=195566
2900
2901         Reviewed by Lucas Forschler.
2902
2903         * BuildSlaveSupport/ews-app/ews/config.py:
2904         * BuildSlaveSupport/ews-build/events.py:
2905         * BuildSlaveSupport/ews-build/steps.py:
2906
2907 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2908
2909         [ews-build] change max_builds for local-worker to 1
2910         https://bugs.webkit.org/show_bug.cgi?id=195568
2911
2912         Reviewed by Lucas Forschler.
2913
2914         * BuildSlaveSupport/ews-build/loadConfig.py:
2915
2916 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2917
2918         Fix the build
2919
2920         * TestRunnerShared/spi/PencilKitTestSPI.h:
2921         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2922
2923 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2924
2925         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2926         https://bugs.webkit.org/show_bug.cgi?id=194131
2927
2928         Reviewed by Michael Catanzaro.
2929
2930         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2931         (uriChanged):
2932         (testUnfinishedSubresourceLoad):
2933         (serverCallback):
2934         (beforeAll):
2935
2936 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2937
2938         WTF::Expected should use std::addressof instead of operator&
2939         https://bugs.webkit.org/show_bug.cgi?id=195604
2940
2941         Reviewed by Myles Maxfield.
2942
2943         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2944         (TestWebKitAPI::Unique::Unique):
2945         (TestWebKitAPI::Unique::operator&):
2946         (TestWebKitAPI::TEST):
2947
2948 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2949
2950         Add Optional to Forward.h.
2951         https://bugs.webkit.org/show_bug.cgi?id=195586
2952
2953         Reviewed by Darin Adler.
2954
2955         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2956         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2957         Remove unnecessary includes from headers.
2958
2959 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2960
2961         Add testing API to hit-test and scroll overflow scrollers
2962         https://bugs.webkit.org/show_bug.cgi?id=195278
2963
2964         Reviewed by Antti Koivisto.
2965         
2966         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2967         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2968         
2969         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2970
2971         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2972         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2973         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2974         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2975         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2976         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2977         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2978         (WTR::enclosingScrollViewIncludingSelf):
2979         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2980
2981 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2982
2983         API test WebKit.RequestTextInputContext fails on iOS
2984         https://bugs.webkit.org/show_bug.cgi?id=195585
2985
2986         Reviewed by Wenson Hsieh and Simon Fraser.
2987
2988         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2989         (applyStyle):
2990         (TEST):
2991         Add a viewport, so that the coordinates match up on iOS.
2992         Scroll by moving the UIScrollView's contentOffset.
2993
2994 2019-03-11  Chris Dumez  <cdumez@apple.com>
2995
2996         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2997         https://bugs.webkit.org/show_bug.cgi?id=195506
2998         <rdar://problem/48733477>
2999
3000         Reviewed by Alex Christensen.
3001
3002         Add API test coverage.
3003
3004         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3005
3006 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3007
3008         Adding myself to contributors.json
3009
3010         Unreviewed, addming myself to contributors.json .
3011
3012         * Scripts/webkitpy/common/config/contributors.json:
3013
3014 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3015
3016         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3017         https://bugs.webkit.org/show_bug.cgi?id=195511
3018         <rdar://problem/44873269>
3019
3020         Reviewed by Darin Adler.
3021
3022         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3023         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3024         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3025         (TEST_F):
3026
3027 2019-03-11  Chris Dumez  <cdumez@apple.com>
3028
3029         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3030         https://bugs.webkit.org/show_bug.cgi?id=195561
3031
3032         Reviewed by Youenn Fablet.
3033
3034         Make sure the JS in the test requests for permission to receive device orientation events.
3035
3036         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3037
3038 2019-03-11  Youenn Fablet  <youenn@apple.com>
3039
3040         Allow storage quota increase by default in WTR
3041         https://bugs.webkit.org/show_bug.cgi?id=195541
3042
3043         Reviewed by Geoffrey Garen.
3044
3045         Allow storage quota increase by default in WTR.
3046         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3047         Use this for tests that explicitly need cache increase.
3048
3049         Instead of increasing quota by 2, make sure the next request is
3050         granted by adding all given parameters.
3051
3052         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3053         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3054         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3055         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3056         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3057         * WebKitTestRunner/TestController.cpp:
3058         (WTR::TestController::setAllowStorageQuotaIncrease):
3059         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3060         * WebKitTestRunner/TestController.h:
3061         * WebKitTestRunner/TestInvocation.cpp:
3062         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3063         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3064         (WTR::TestController::cocoaResetStateToConsistentValues):
3065         (WTR::TestController::setAllowStorageQuotaIncrease):
3066         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3067         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3068         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3069
3070 2019-03-11  Xan Lopez  <xan@igalia.com>
3071
3072         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3073         https://bugs.webkit.org/show_bug.cgi?id=194147
3074
3075         Reviewed by Michael Saboff.
3076
3077         To make --32-bit work correctly on Linux/64bit we need to:
3078
3079         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3080         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3081         unfortunately CMake only allows us to do this during
3082         crosscompilation, which is overkill here.
3083         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3084         pkg-config detection module uses the x86 .pc files instead of the
3085         x86_64 ones.
3086         - Set the -m32 flags for the compiler.
3087
3088         * Scripts/webkitdirs.pm:
3089         (generateBuildSystemFromCMakeProject):
3090
3091 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3092
3093         Add MotionMark-1.1 plan file for run-benchmark script.
3094         https://bugs.webkit.org/show_bug.cgi?id=195481
3095
3096         Rubber-stamped by Darin Adler.
3097
3098         Run-benchmark script should support MontionMark-1.1.
3099
3100         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3101
3102 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3103
3104         [ews-app] Add support for submit-to-ews url
3105         https://bugs.webkit.org/show_bug.cgi?id=195477
3106
3107         Reviewed by Lucas Forschler.
3108
3109         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3110         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3111         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3112         * BuildSlaveSupport/ews-app/ews/urls.py:
3113         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3114
3115 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3116
3117         Unreviewed, rolling out r242688, r242643, r242624.
3118
3119         Caused multiple layout test failures and crashes on iOS and macOS.
3120
3121         Reverted changeset:
3122
3123         "requestAnimationFrame should execute before the next frame"
3124         https://bugs.webkit.org/show_bug.cgi?id=177484
3125         https://trac.webkit.org/changeset/242624/webkit
3126
3127         * Tracing/SystemTracePoints.plist:
3128
3129 2019-03-11  John Wilander  <wilander@apple.com>
3130
3131         Resource Load Statistics: Make it possible exclude localhost from classification
3132         https://bugs.webkit.org/show_bug.cgi?id=195474
3133         <rdar://problem/47520577>
3134
3135         Reviewed by Brent Fulgham.
3136
3137         This patch allows for localhost to be excluded from classification and
3138         treatment as a prevalent resource.
3139
3140         The WebKit Tools change adds a new function called
3141         testRunner.setStatisticsIsRunningTest() which can be used to control this
3142         behavior.
3143
3144         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3145         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3146         (WTR::TestRunner::setStatisticsIsRunningTest):
3147         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3148         * WebKitTestRunner/TestController.cpp:
3149         (WTR::TestController::setStatisticsIsRunningTest):
3150         * WebKitTestRunner/TestController.h:
3151         * WebKitTestRunner/TestInvocation.cpp:
3152         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3153
3154 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3155
3156         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3157         https://bugs.webkit.org/show_bug.cgi?id=195560
3158
3159         Reviewed by Lucas Forschler.
3160
3161         * BuildSlaveSupport/ews-build/master.cfg:
3162
3163 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3164
3165         Unreviewed, rolling out r242698.
3166
3167         API test crashes on bots.
3168
3169         Reverted changeset:
3170
3171         "Add a WKContentRuleList variant that uses copied memory
3172         instead of mmap'd shared memory for class A containerized
3173         apps"
3174         https://bugs.webkit.org/show_bug.cgi?id=195511
3175         https://trac.webkit.org/changeset/242698
3176
3177 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3178
3179         [WPE] Enable web process sandbox
3180         https://bugs.webkit.org/show_bug.cgi?id=195169
3181
3182         Reviewed by Daniel Bates.
3183
3184         * wpe/install-dependencies:
3185         * wpe/jhbuild.modules:
3186
3187 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3188
3189         [ews-app] Use port 17000 for worker communication
3190         https://bugs.webkit.org/show_bug.cgi?id=195558
3191
3192         Reviewed by Lucas Forschler.
3193
3194         * BuildSlaveSupport/ews-build/master.cfg:
3195
3196 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3197
3198         [ews-build] unit-tests fail when passwords.json is missing
3199         https://bugs.webkit.org/show_bug.cgi?id=195557
3200
3201         Reviewed by Lucas Forschler.
3202
3203         * BuildSlaveSupport/ews-build/loadConfig.py:
3204         (loadBuilderConfig):
3205         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3206         (ConfigDotJSONTest.test_configuration):
3207         * BuildSlaveSupport/ews-build/master.cfg:
3208
3209 2019-03-11  Truitt Savell  <tsavell@apple.com>
3210
3211         Unreviewed, rolling out r242702.
3212
3213         Broke High Sierra builders.
3214
3215         Reverted changeset:
3216
3217         "Add utility function to allow easy reverse range-based
3218         iteration of a container"
3219         https://bugs.webkit.org/show_bug.cgi?id=195542
3220         https://trac.webkit.org/changeset/242702
3221
3222 2019-03-11  Sam Weinig  <sam@webkit.org>
3223
3224         Add utility function to allow easy reverse range-based iteration of a container
3225         https://bugs.webkit.org/show_bug.cgi?id=195542
3226
3227         Reviewed by Antti Koivisto.
3228
3229         * TestWebKitAPI/CMakeLists.txt:
3230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3231         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3232         (TestWebKitAPI::TEST):
3233         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3234
3235 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3236
3237         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3238         https://bugs.webkit.org/show_bug.cgi?id=195511
3239         <rdar://problem/44873269>
3240
3241         Reviewed by Darin Adler.
3242
3243         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3244         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3245         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3246         (TEST_F):
3247
3248 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3249
3250         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3251         https://bugs.webkit.org/show_bug.cgi?id=195499
3252
3253         Reviewed by Darin Adler.
3254
3255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3256         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3257         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3258         (-[WKWebView synchronouslyFocusTextInputContext:]):
3259         (applyStyle):
3260         (applyIframe):
3261         (TEST):
3262         Add some tests for this SPI.
3263
3264 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3265
3266         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3267         https://bugs.webkit.org/show_bug.cgi?id=181151
3268
3269         Reviewed by Don Olmstead.
3270
3271         * TestWebKitAPI/CMakeLists.txt:
3272         * TestWebKitAPI/PlatformWin.cmake:
3273         Enable TestWTF RunLoop tests in all platforms.
3274
3275         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3276         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3277         (TestWebKitAPI::DerivedOneShotTimer::fired):
3278         (TestWebKitAPI::TEST):
3279         Only a few platforms support nested RunLoop.
3280
3281         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3282         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3283
3284 2019-03-10  David Quesada  <david_quesada@apple.com>
3285
3286         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3287         https://bugs.webkit.org/show_bug.cgi?id=152480
3288
3289         Reviewed by Chris Dumez.
3290
3291         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3292         there are no additional references to the process pool besides the one held by
3293         the download, waits for the download to finish (in the sense that the
3294         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3295         measure, also check that the process pool has been deallocated at the end of the
3296         test. The test wouldn't be meaningful if the process pool were still alive.
3297
3298         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3299         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3300         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3301             The download will be canceled because the delegate does not implement the
3302             method to decide the download's destination, so this is where we know the
3303             DownloadProxyMap is done with the DownloadProxy.
3304         (TEST):
3305
3306 2019-03-08  Chris Dumez  <cdumez@apple.com>
3307
3308         Add support for Device Orientation / Motion permission API
3309         https://bugs.webkit.org/show_bug.cgi?id=195329
3310         <rdar://problem/47645367>
3311
3312         Reviewed by Geoffrey Garen.
3313
3314         Add test infrastructure to help test the Device Orientation / Motion permission API.
3315
3316         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3317         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3318         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3319         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3320         * WebKitTestRunner/TestController.cpp:
3321         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3322         (WTR::TestController::createWebViewWithOptions):
3323         (WTR::TestController::resetStateToConsistentValues):
3324         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3325         * WebKitTestRunner/TestController.h:
3326         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3327         * WebKitTestRunner/TestInvocation.cpp:
3328         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3329
3330 2019-03-08  Saam barati  <sbarati@apple.com>
3331
3332         Add a compare-results script to compare benchmark results
3333         https://bugs.webkit.org/show_bug.cgi?id=195486
3334         <rdar://problem/48723397>
3335
3336         Reviewed by Geoffrey Garen.
3337
3338         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3339         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3340         to extend it to learn about our other benchmarks.
3341
3342         * Scripts/compare-results: Added.
3343         (readJSONFile):
3344         (detectJetStream2):
3345         (JetStream2Results):
3346         (detectSpeedometer2):
3347         (Speedometer2Results):
3348         (detectPLT5):
3349         (PLT5Results):
3350         (detectBenchmark):
3351         (biggerIsBetter):
3352         (ttest):
3353         (getOptions):
3354         (main):
3355
3356 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3357
3358         Ensure old tab state is cleared between iterations of run-benchmark
3359         https://bugs.webkit.org/show_bug.cgi?id=195393
3360         <rdar://problem/46885583>
3361
3362         Reviewed by Dewei Zhu.
3363
3364         a) ensure the default to restore state is not set
3365         b) terminate Safari correctly
3366         c) Set the system default to ignore Persistent State in Safari
3367
3368         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3369         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3370         (OSXBrowserDriver.prepare_env): 
3371         (OSXBrowserDriver.restore_env):
3372         (OSXBrowserDriver.close_browsers):
3373         (OSXBrowserDriver._terminate_processes):
3374         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3375         (OSXChromeDriver):
3376         (OSXChromeCanaryDriver):
3377         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3378         (OSXFirefoxDriver):
3379         (OSXFirefoxNightlyDriver):
3380         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3381         (OSXSafariDriver):
3382         (OSXSafariDriver.prepare_env):
3383
3384 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3385
3386         [GTK] Several InputMethodFilter tests are failing
3387         https://bugs.webkit.org/show_bug.cgi?id=195408
3388
3389         Reviewed by Carlos Garcia Campos.
3390
3391         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3392         Regressed in r241751.
3393         Hexadecimal values of keycodes are expressed now in upper letters.
3394         Composited characters should be cast to UTF8 strings.
3395
3396         (TestWebKitAPI::TEST):
3397
3398 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3399
3400         [GTK] Make Tools/gtkdoc python3 compatible
3401         https://bugs.webkit.org/show_bug.cgi?id=195359
3402
3403         Reviewed by Carlos Garcia Campos.
3404
3405         * gtkdoc/generate-gtkdoc:
3406         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3407         work with Python 2 and 3.
3408         (get_gtkdoc_module_paths):
3409         The iteritems() was removed in Python 3, so let's use items() that's
3410         available in Python 2 and 3.
3411         (get_generator_for_config):
3412         * gtkdoc/gtkdoc.py:
3413         (GTKDoc._run_command):
3414         The sys.stdout.write() is expecting str in Python 3 and not bytes
3415         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3416         for passing the bytes there.
3417
3418 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3419
3420         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3421         https://bugs.webkit.org/show_bug.cgi?id=195346
3422         <rdar://problem/48667048>
3423
3424         Unreviewed build fix for clang-cl.
3425
3426         * DumpRenderTree/win/DumpRenderTree.cpp:
3427         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3428
3429 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3430
3431         requestAnimationFrame should execute before the next frame
3432         https://bugs.webkit.org/show_bug.cgi?id=177484
3433
3434         Reviewed by Simon Fraser.
3435
3436         Add trace points for the page RenderingUpdate.
3437
3438         * Tracing/SystemTracePoints.plist:
3439
3440 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3441
3442         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3443         https://bugs.webkit.org/show_bug.cgi?id=195353
3444         <rdar://problem/48626394>
3445
3446         Reviewed by Simon Fraser.
3447
3448         * WebKitTestRunner/ios/TestControllerIOS.mm:
3449         (WTR::TestController::platformResetPreferencesToConsistentValues):
3450
3451 2019-03-07  John Wilander  <wilander@apple.com>
3452
3453         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3454         https://bugs.webkit.org/show_bug.cgi?id=195383
3455         <rdar://problem/48570136>
3456
3457         Reviewed by Brent Fulgham.
3458
3459         This patch adds test infrastructure to purge only script-accessible cookies,
3460         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3461
3462         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3463         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3464         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3465         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3466         * WebKitTestRunner/TestController.cpp:
3467         (WTR::TestController::statisticsDeleteCookiesForHost):
3468         * WebKitTestRunner/TestController.h:
3469         * WebKitTestRunner/TestInvocation.cpp:
3470         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3471
3472 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3473
3474         Unreviewed, rolling out r242354.
3475         https://bugs.webkit.org/show_bug.cgi?id=195402
3476
3477         breaks layout tests in all configurations (Requested by
3478         zdobersek on #webkit).
3479
3480         Reverted changeset:
3481
3482         "[WPE] Enable web process sandbox"
3483         https://bugs.webkit.org/show_bug.cgi?id=195169
3484         https://trac.webkit.org/changeset/242354
3485
3486 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3487
3488         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3489         https://bugs.webkit.org/show_bug.cgi?id=195346
3490
3491         Reviewed by Fujii Hironori.
3492
3493         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3494         (TestWebKitAPI::TEST):
3495         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3496
3497         * DumpRenderTree/win/DumpRenderTree.cpp:
3498         (findFontFallback):
3499         (addFontFallbackIfPresent):
3500         (removeFontFallbackIfPresent):
3501         (main):
3502         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3503         (TestWebKitAPI::Util::moduleDirectory):
3504         (TestWebKitAPI::Util::createInjectedBundlePath):
3505         Use wchar helpers as needed.
3506
3507 2019-03-06  Rob Buis  <rbuis@igalia.com>
3508
3509         Consider supporting the `referrerpolicy` attribute.
3510         https://bugs.webkit.org/show_bug.cgi?id=179053
3511
3512         Reviewed by Darin Adler.
3513
3514         Add a runtime flag for referrerpolicy attribute.
3515
3516         * DumpRenderTree/mac/DumpRenderTree.mm:
3517         (enableExperimentalFeatures):
3518
3519 2019-03-05  Daniel Bates  <dabates@apple.com>
3520
3521         Update expected API test result following r242379
3522         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3523
3524         Update expected x-coordinate of selection rect now that the left padding of
3525         a textarea is sized in ems (so dependent on the font size) just like the left
3526         padding of a text field.
3527
3528         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3529         (TestWebKitAPI::TEST):
3530
3531 2019-03-05  David Quesada  <david_quesada@apple.com>
3532
3533         [WK2] It should be possible to follow links with 'download' attributes
3534         https://bugs.webkit.org/show_bug.cgi?id=195145
3535         rdar://problem/48462642
3536
3537         Reviewed by Alex Christensen.
3538
3539         Add a unit test to verify that activating links with 'download' attributes now
3540         navigates to the linked resource, rather than starts downloading it. Add another
3541         to verify that it is still possible to explicitly download the link via the
3542         'Download' navigation action policy.
3543
3544         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3545         (-[DownloadAttributeTestDelegate init]):
3546         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3547         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3548         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3549         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3550         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3551         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3552         (TEST):
3553         * WebKitTestRunner/TestController.cpp:
3554         (WTR::TestController::decidePolicyForNavigationAction):
3555         * WebKitTestRunner/TestController.h:
3556
3557 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3558
3559         [Curl] Implement Cookie Accept Policy.
3560         https://bugs.webkit.org/show_bug.cgi?id=191645
3561
3562         Reviewed by Fujii Hironori.
3563
3564         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3565         (TestWebKitAPI::Curl::TEST_F):
3566
3567 2019-03-05  Youenn Fablet  <youenn@apple.com>
3568
3569         Rename requestCacheStorageSpace to requestStorageSpace
3570         https://bugs.webkit.org/show_bug.cgi?id=195282
3571
3572         Reviewed by Chris Dumez.
3573
3574         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3575         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3576         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3577
3578 2019-03-05  Brady Eidson  <beidson@apple.com>
3579
3580         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3581         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3582
3583         Reviewed by Tim Horton.
3584
3585         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3586         different directory into that same WKWebView should work.
3587
3588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3589         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3590
3591 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3592
3593         Add WeakHashSet
3594         https://bugs.webkit.org/show_bug.cgi?id=195152
3595
3596         Reviewed by Antti Koivisto.
3597
3598         Added tests for WeakHashSet.
3599
3600         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3601         (TestWebKitAPI::Base::Base): Moved.
3602         (TestWebKitAPI::Derived::foo): Moved.
3603         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3604         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3605         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3606         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3607
3608 2019-03-04  Chris Dumez  <cdumez@apple.com>
3609
3610         Do not share WebProcesses between private and regular sessions
3611         https://bugs.webkit.org/show_bug.cgi?id=195189
3612         <rdar://problem/48421064>
3613
3614         Reviewed by Alex Christensen.
3615
3616         Add API test coverage.
3617
3618         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3619         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3620
3621 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3622
3623         [WPE] Enable web process sandbox
3624         https://bugs.webkit.org/show_bug.cgi?id=195169
3625
3626         Reviewed by Daniel Bates.
3627
3628         * wpe/install-dependencies:
3629         * wpe/jhbuild.modules:
3630
3631 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3632
3633         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3634         https://bugs.webkit.org/show_bug.cgi?id=195206
3635
3636         Reviewed by Žan Doberšek.
3637
3638         Add a new test case.
3639
3640         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3641         (testJSCClass):
3642
3643 2019-03-04  Charlie Turner  <cturner@igalia.com>
3644
3645         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3646         https://bugs.webkit.org/show_bug.cgi?id=194898
3647
3648         Reviewed by Žan Doberšek.
3649
3650         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3651         a GCC extension that permits arithmetic on void* pointer. Inline
3652         the macro until this issue is fixed upstream.
3653
3654 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3655
3656         Rid the world of WK_API_ENABLED
3657         https://bugs.webkit.org/show_bug.cgi?id=195263
3658
3659         Reviewed by Dan Bernstein.
3660
3661         List of changed files elided because it's useless.
3662
3663 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3664
3665         Unreviewed follow-up to r242292.
3666
3667         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3668
3669         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3670         (TestWebKitAPI::testStrip): Renamed from strip.
3671         (TestWebKitAPI::TEST):
3672
3673 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3674
3675         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3676
3677         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3678         and bug #194272 for details.
3679
3680         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3681
3682 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3683
3684         Remove some more unused 32-bit code
3685         https://bugs.webkit.org/show_bug.cgi?id=195255
3686
3687         Reviewed by Darin Adler.
3688
3689         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3690         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3691         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3692         (NPP_New):
3693         (NPP_HandleEvent):
3694         (handleEventCarbon): Deleted.
3695
3696 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3697
3698         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3699
3700         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3701         (TestWebKitAPI::TEST):
3702
3703 2019-03-01  Darin Adler  <darin@apple.com>
3704
3705         Finish removing String::format
3706         https://bugs.webkit.org/show_bug.cgi?id=194893
3707
3708         Reviewed by Daniel Bates.
3709 '
3710         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3711
3712 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3713
3714         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3715         https://bugs.webkit.org/show_bug.cgi?id=195229
3716         <rdar://problem/48520362>
3717
3718         Reviewed by Chris Dumez.
3719
3720         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3721         (TEST):
3722
3723 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3724
3725         Add a system trace scope for event region building
3726         https://bugs.webkit.org/show_bug.cgi?id=195226
3727
3728         Reviewed by Jon Lee.
3729
3730         This trace scope measures the time spend converting element rects into Region objects,
3731         which can be large on some pages.
3732
3733         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3734
3735         * Tracing/SystemTracePoints.plist:
3736
3737 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3738
3739         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3740         https://bugs.webkit.org/show_bug.cgi?id=194612
3741
3742         Reviewed by Alex Christensen.
3743
3744         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3745         Just test the new string-processing function and don't touch the actual environment.
3746         (Test cases are all as before, but based on operator== instead of strcmp.)
3747
3748 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3749
3750         [ews-app] Update primary keys for handling multiple Buildbot instances
3751         https://bugs.webkit.org/show_bug.cgi?id=195120
3752
3753         Reviewed by Stephanie Lewis.
3754
3755         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3756         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3757         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3758
3759         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3760         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3761         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3762         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3763         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3764         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3765
3766 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3767
3768         [WinCairo] Enable service worker
3769         https://bugs.webkit.org/show_bug.cgi?id=188318
3770
3771         Reviewed by Youenn Fablet.
3772
3773         * DumpRenderTree/DumpRenderTreePrefix.h:
3774         * TestWebKitAPI/PlatformWin.cmake:
3775         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3776         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3777         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3778
3779 2019-03-01  Justin Fan  <justin_fan@apple.com>
3780
3781         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3782         https://bugs.webkit.org/show_bug.cgi?id=195191
3783
3784         Rubber-stamped by Dean Jackson.
3785
3786         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3787
3788         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3789
3790 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3791
3792         Unreviewed, fix lldb webkitpy tests
3793         https://bugs.webkit.org/show_bug.cgi?id=194375
3794
3795         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3796
3797         * lldb/lldb_webkit.py:
3798         (WTFStringImplProvider.is_8bit):
3799
3800 2019-02-28  David Quesada  <david_quesada@apple.com>
3801
3802         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3803         https://bugs.webkit.org/show_bug.cgi?id=195121
3804         rdar://problem/48450302
3805
3806         Reviewed by Alex Christensen.
3807
3808         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3809         configurations where the 'download' attribute is absent, blank, or populated
3810         with a filename, and where the anchor element is same-origin or cross-origin
3811         (meaning the 'download' attribute shouldn't be honored).
3812
3813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3814         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3815         (-[NavigationActionTestDelegate init]):
3816         (-[NavigationActionTestDelegate navigationAction]):
3817         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3818         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3819         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3820         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3821         (TEST):
3822
3823 2019-02-28  Antoine Quint  <graouts@apple.com>
3824
3825         Enable the Pointer Events runtime flag by default
3826         https://bugs.webkit.org/show_bug.cgi?id=195156
3827
3828         Reviewed by Dean Jackson.
3829
3830         * DumpRenderTree/mac/DumpRenderTree.mm:
3831         (enableExperimentalFeatures):
3832
3833 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3834
3835         Several PasteImage API tests are flaky
3836         https://bugs.webkit.org/show_bug.cgi?id=195160
3837
3838         Reviewed by Tim Horton.
3839
3840         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3841         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3842         listening for a "load" event after image load is already complete.
3843
3844         To address this, make these tests first register a "load" event handler, then run script to insert an image
3845         element into the document, and finally wait until the load event is observed before checking image size.
3846
3847         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3848
3849 2019-02-28  Chris Dumez  <cdumez@apple.com>
3850
3851         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3852         https://bugs.webkit.org/show_bug.cgi?id=195107
3853
3854         Reviewed by Alex Christensen.
3855
3856         Give some time for the zoom level to get restored.
3857
3858         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3859
3860 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3861
3862         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3863         https://bugs.webkit.org/show_bug.cgi?id=194958
3864
3865         Reviewed by Geoffrey Garen.
3866
3867         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3868         (TEST):
3869
3870 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3871
3872         [ews-app] Update method to save build to handle builder_display_name
3873         https://bugs.webkit.org/show_bug.cgi?id=195047
3874
3875         Reviewed by Dewei Zhu.
3876
3877         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3878         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3879
3880 2019-02-28  Justin Fan  <justin_fan@apple.com>
3881
3882         [Web GPU] Enable Web GPU only on 64-bit
3883         https://bugs.webkit.org/show_bug.cgi?id=195139
3884
3885         Because Metal is only supported on 64 bit apps.
3886
3887         Unreviewed build fix.
3888
3889         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3890
3891 2019-02-27  Youenn Fablet  <youenn@apple.com>
3892
3893         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3894         https://bugs.webkit.org/show_bug.cgi?id=194959
3895
3896         Reviewed by Chris Dumez.
3897
3898         Spin loop until getting the condition to remove flakiness.
3899
3900         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3901
3902 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3903
3904         [ews-build] Buildbot should include builder_display_name in the build events
3905         https://bugs.webkit.org/show_bug.cgi?id=195045
3906
3907         Reviewed by Dewei Zhu.
3908
3909         * BuildSlaveSupport/ews-build/events.py:
3910         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3911         buildername to builder_name to be consistent in naming style.
3912         (Events.buildFinished): Ditto.
3913
3914 2019-02-27  Chris Dumez  <cdumez@apple.com>
3915
3916         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3917         https://bugs.webkit.org/show_bug.cgi?id=194480
3918
3919         Reviewed by Brady Eidson.
3920
3921         Update existing API test to make it more likely to reproduce the issue.
3922
3923         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3924
3925 2019-02-27  Brady Eidson  <beidson@apple.com>
3926
3927         Universal links from Google search results pages don't open the app.
3928         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3929
3930         Reviewed by Geoffrey Garen.
3931
3932         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3933         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3934         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3935         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3936
3937 2019-02-27  Chris Dumez  <cdumez@apple.com>
3938
3939         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3940         https://bugs.webkit.org/show_bug.cgi?id=195102
3941
3942         Reviewed by Geoffrey Garen.
3943
3944         If the number of processes is not yet what we expect, wait a bit and check again to give
3945         processes some time to exit.
3946
3947         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3948
3949 2019-02-27  Chris Dumez  <cdumez@apple.com>
3950
3951         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3952         https://bugs.webkit.org/show_bug.cgi?id=194545
3953
3954         Reviewed by Brady Eidson.
3955
3956         Make sure the test navigates forward and then back only once. Previously, navigating
3957         back would trigger a navigation again in a timer.
3958
3959         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3960
3961 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3962
3963         High Sierra Debug JSC test queue should use faster hardware
3964         https://bugs.webkit.org/show_bug.cgi?id=194603
3965
3966         Rubber-stamped by Alexey Proskuryakov.
3967
3968         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3969
3970         * BuildSlaveSupport/build.webkit.org-config/config.json:
3971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3972         (BubbleQueueServer):
3973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3974         (WebKitBuildbot):
3975         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3976         * QueueStatusServer/config/queues.py:
3977         * Scripts/webkitpy/common/config/ews.json:
3978         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3979         (test_ews_name):
3980
3981 2019-02-27  John Wilander  <wilander@apple.com>
3982
3983         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3984         https://bugs.webkit.org/show_bug.cgi?id=195071
3985         <rdar://problem/48417690>
3986
3987         Reviewed by Alex Christensen and Brent Fulgham.
3988
3989         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3990         (TestWebKitAPI::createURL):
3991             Convenience function.
3992         (TestWebKitAPI::TEST):
3993             WebCore::AdClickAttribution now takes a URL when creating Source and
3994             Destination.
3995         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3996         (TestWebKitAPI::TEST):
3997             WebCore::AdClickAttribution now takes a URL when creating Source and
3998             Destination.
3999
4000 2019-02-27  Antoine Quint  <graouts@apple.com>
4001
4002         Support Pointer Events on macOS
4003         https://bugs.webkit.org/show_bug.cgi?id=195008
4004         <rdar://problem/47454419>
4005
4006         Reviewed by Dean Jackson.
4007
4008         * DumpRenderTree/mac/DumpRenderTree.mm:
4009         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4010         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4011
4012 2019-02-26  Mark Lam  <mark.lam@apple.com>
4013
4014         Remove remaining poisoning code.
4015         https://bugs.webkit.org/show_bug.cgi?id=194138
4016
4017         Reviewed by Saam Barati.
4018
4019         * TestWebKitAPI/CMakeLists.txt:
4020         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4021         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4022         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4023         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4024         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4025         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4026         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4027
4028 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4029
4030         Move ephemeral local storage from WebProcess to UIProcess
4031         https://bugs.webkit.org/show_bug.cgi?id=195074
4032         <rdar://problem/47937975>
4033
4034         Reviewed by Geoff Garen.
4035
4036         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4037
4038 2019-02-20  Jer Noble  <jer.noble@apple.com>
4039
4040         [Cocoa] Media elements will restart network buffering just before suspending
4041         https://bugs.webkit.org/show_bug.cgi?id=193691
4042
4043         Reviewed by Eric Carlson.
4044
4045         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4046         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4047         (TEST):
4048
4049 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4050
4051         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4052         https://bugs.webkit.org/show_bug.cgi?id=191652
4053
4054         Reviewed by Alex Christensen.
4055
4056         Fix WinCairo MiniBrowser behavior of authentication dialog.
4057
4058         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4059         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4060
4061 2019-02-26  Youenn Fablet  <youenn@apple.com>
4062
4063         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4064         https://bugs.webkit.org/show_bug.cgi?id=195028
4065         <rdar://problem/48243733>
4066
4067         Reviewed by Eric Carlson.
4068
4069         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4070
4071 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4072
4073         [WPE] Add API for webview background color configuration
4074         https://bugs.webkit.org/show_bug.cgi?id=192305
4075
4076         Reviewed by Michael Catanzaro.
4077
4078         * MiniBrowser/wpe/main.cpp:
4079         (main): Add a new option to configure the webview background
4080         color. Example: --bg-color=transparent.
4081         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4082         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4083         (beforeAll): Ditto.
4084
4085 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4086
4087         scalableNativeWebpageParameters() is not preserved on new page navigation.
4088         https://bugs.webkit.org/show_bug.cgi?id=194892
4089         <rdar://problem/47538280>
4090
4091         Reviewed by Wenson Hsieh.
4092         
4093         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4094
4095         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4096         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4097         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4098         (WTR::UIScriptController::allowsViewportShrinkToFit):
4099         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4100         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4101         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4102         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4103         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4104         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4105
4106 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4107
4108         [ews-app] Add model for handling multiple Buildbot instances
4109         https://bugs.webkit.org/show_bug.cgi?id=194863
4110
4111         Reviewed by Stephanie Lewis.
4112
4113         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4114
4115 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4116
4117         [ews-app] Remove BuilderMapping table
4118         https://bugs.webkit.org/show_bug.cgi?id=194961
4119
4120         Reviewed by Stephanie Lewis.
4121
4122         Store builder name directly in build table, instead of having a separate
4123         table for it.
4124
4125         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4126         * BuildSlaveSupport/ews-app/ews/models/build.py:
4127         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4128         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4129
4130 2019-02-25  John Wilander  <wilander@apple.com>
4131
4132         Introduce and adopt new class RegistrableDomain for eTLD+1
4133         https://bugs.webkit.org/show_bug.cgi?id=194791
4134         <rdar://problem/48179240>
4135
4136         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4137
4138         This patch adds an API test and replaces two instances of
4139         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4140
4141         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4142         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4143         (TestWebKitAPI::TEST):
4144             Changed two strings to make sure the registrable domains are still considered
4145             invalid and pass the test.
4146         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4147         (TestWebKitAPI::TEST):
4148         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4149         (WTR::InjectedBundle::didReceiveMessageToPage):
4150
4151 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4152
4153         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4154         https://bugs.webkit.org/show_bug.cgi?id=195001
4155
4156         Reviewed by Carlos Garcia Campos.
4157
4158         API version 1.0 always includes the functionality previously guarded with
4159         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4160         unconditionally.
4161
4162         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4163         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4164         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4165         (WebViewTest::showInWindow): Ditto.
4166         (WebViewTest::hideView): Ditto.
4167         * wpe/backends/HeadlessViewBackend.cpp:
4168         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4169         * wpe/backends/ViewBackend.cpp:
4170         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4171         * wpe/backends/WindowViewBackend.cpp:
4172         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4173         WPE_BACKEND_CHECK_VERSION().
4174         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4175
4176 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4177
4178         [Flatpak] Add support for flatpak > 1.1.2
4179         https://bugs.webkit.org/show_bug.cgi?id=194088
4180
4181         Flatpak 1.2 is now out so we need to support that
4182         version now.
4183
4184         Reviewed by Michael Catanzaro.
4185
4186         * flatpak/flatpakutils.py:
4187         (check_flatpak):
4188         (FlatpakPackages.__init__):
4189         (FlatpakPackages.__detect_packages):
4190         (FlatpakPackages.__detect_packages.in):
4191         (FlatpakRepos.update):
4192
4193 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4194
4195         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4196         https://bugs.webkit.org/show_bug.cgi?id=194998
4197
4198         Reviewed by Carlos Garcia Campos.
4199
4200         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4201         to a Git checkout and using the latest commit containing various fixes
4202         and improvements.
4203
4204 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4205
4206         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4207         https://bugs.webkit.org/show_bug.cgi?id=194981
4208
4209         Reviewed by Žan Doberšek.
4210
4211         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4212         (TestWebKitAPI::TEST):
4213
4214 2019-02-23  Keith Miller  <keith_miller@apple.com>
4215
4216         Add new mac target numbers
4217         https://bugs.webkit.org/show_bug.cgi?id=194955
4218
4219         Reviewed by Tim Horton.
4220
4221         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4222         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4223         * MiniBrowser/Configurations/Base.xcconfig:
4224         * TestWebKitAPI/Configurations/Base.xcconfig:
4225         * WebKitTestRunner/Configurations/Base.xcconfig:
4226
4227 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4228
4229         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4230         https://bugs.webkit.org/show_bug.cgi?id=194846
4231
4232         Reviewed by Don Olmstead.
4233
4234         Added _search_paths() and _port_specific_expectations_files() for
4235         WinCairoPort.
4236
4237         * Scripts/webkitpy/port/win.py:
4238         (WinCairoPort.default_baseline_search_path):
4239         (WinCairoPort):
4240         (WinCairoPort._port_specific_expectations_files):
4241         (WinCairoPort._search_paths):
4242
4243 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4244
4245         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4246         https://bugs.webkit.org/show_bug.cgi?id=194963
4247
4248         Reviewed by Dean Jackson.
4249
4250         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4251         Do a `contains` check instead of `equals`, because in debug builds we
4252         put the GraphicsLayer pointer in a prefix.
4253
4254 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4255
4256         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4257         https://bugs.webkit.org/show_bug.cgi?id=194873
4258         <rdar://problem/46701974>
4259
4260         Reviewed by Tim Horton.
4261
4262         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4263
4264         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4265         (WTR::UIScriptController::menuRect const):
4266         (WTR::UIScriptController::isShowingMenu const):
4267         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4268         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4269         (WTR::UIScriptController::menuRect const):
4270
4271         Add a function to query the bounds of the callout menu in content coordinates.
4272
4273         (WTR::UIScriptController::isShowingMenu const):
4274
4275         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4276
4277         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4278         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4279         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4280         (WTR::UIScriptController::rectForMenuAction const):
4281         (WTR::UIScriptController::menuRect const):
4282         (WTR::UIScriptController::isShowingMenu const):
4283         (WTR::findViewInHierarchyOfType): Deleted.
4284
4285 2019-02-22  Chris Dumez  <cdumez@apple.com>
4286
4287         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4288         https://bugs.webkit.org/show_bug.cgi?id=194954
4289         <rdar://problem/48127957>
4290
4291         Reviewed by Alex Christensen.
4292
4293         Add API test coverage.
4294
4295         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4296         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4297         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4298         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4299
4300 2019-02-22  Chris Dumez  <cdumez@apple.com>
4301
4302         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4303         https://bugs.webkit.org/show_bug.cgi?id=194924
4304         <rdar://problem/48216125>
4305
4306         Reviewed by Geoffrey Garen.
4307
4308         Add API test coverage.
4309
4310         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4311
4312 2019-02-22  Chris Dumez  <cdumez@apple.com>
4313
4314         Unreviewed, disable API test added in r241928 on iOS.
4315
4316         The cache is not enabled on devices with less than 3GB of RAM.
4317
4318         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4319
4320 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4321
4322         Hardcode Visual Viewports on everywhere except iOS WK1
4323         https://bugs.webkit.org/show_bug.cgi?id=194928
4324
4325         Reviewed by Zalan Bujtas.
4326
4327         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4328         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4329         set it to false. The setting has shipped for several years and there's no need to turn
4330         it off now.
4331
4332         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4333         Visual Viewports are not enabled.
4334         
4335         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4336         that only runs in WK2
4337
4338         * MiniBrowser/mac/SettingsController.h:
4339         * MiniBrowser/mac/SettingsController.m:
4340         (-[SettingsController init]):
4341         (-[SettingsController _populateMenu]):
4342         (-[SettingsController validateMenuItem:]):
4343         (-[SettingsController visualViewportEnabled]): Deleted.
4344         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4345         * MiniBrowser/mac/WK1BrowserWindowController.m:
4346         (-[WK1BrowserWindowController didChangeSettings]):
4347         * MiniBrowser/mac/WK2BrowserWindowController.m:
4348         (-[WK2BrowserWindowController didChangeSettings]):
4349
4350 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4351
4352         Discard cached processes when clearing website data store
4353         https://bugs.webkit.org/show_bug.cgi?id=194894
4354
4355         Reviewed by Chris Dumez.
4356
4357         Added a test case.
4358
4359         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4360         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4361
4362 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4363
4364         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4365         https://bugs.webkit.org/show_bug.cgi?id=194914
4366         <rdar://problem/47586889>
4367
4368         Reviewed by Geoffrey Garen.