[LFC] Shrink-to-fit-width should be constrained by min/max width
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2
3         [LFC] Shrink-to-fit-width should be constrained by min/max width
4         https://bugs.webkit.org/show_bug.cgi?id=194653
5
6         Reviewed by Antti Koivisto.
7
8         * LayoutReloaded/misc/LFC-passing-tests.txt:
9
10 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
11
12         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
13         https://bugs.webkit.org/show_bug.cgi?id=194641
14
15         Reviewed by Geoffrey Garen.
16
17         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
18         so that the test would fail without this fix.
19
20         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
21         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
22
23 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
24
25         [ews-app] Change log level for a log statement
26
27         Unreviewed minor fix.
28
29         * BuildSlaveSupport/ews-app/ews/models/patch.py:
30         (Patch.save_patch):
31
32 2019-02-13  Jer Noble  <jer.noble@apple.com>
33
34         [Cocoa] Media elements will restart network buffering just before suspending
35         https://bugs.webkit.org/show_bug.cgi?id=193691
36
37         Reviewed by Eric Carlson.
38
39         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
40         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
41         (TEST):
42
43 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
44
45         [ews-app] Fetch builder id to name mapping
46         https://bugs.webkit.org/show_bug.cgi?id=194355
47
48         Reviewed by Lucas Forschler.
49
50         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
51         (Buildbot.get_builder_id_to_name_mapping):
52         (Buildbot._get_display_name_from_builder_name):
53
54 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
55
56         Further restricting webarchive loads
57         https://bugs.webkit.org/show_bug.cgi?id=194567
58         <rdar://problem/47610130>
59
60         Reviewed by Youenn Fablet.
61
62         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
63         navigations on drop.
64
65         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
66         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
67         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
68         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
69         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
70         (TestWebKitAPI::TEST):
71         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
72         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
73         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
74         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
75         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
76         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
77         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
78
79 2019-02-13  John Wilander  <wilander@apple.com>
80
81         Store Ad Click Attribution requests in the network process
82         https://bugs.webkit.org/show_bug.cgi?id=194510
83         <rdar://problem/47650118>
84
85         Reviewed by Alex Christensen and Daniel Bates.
86
87         This patch adds two TestRunner functions:
88         - dumpAdClickAttribution()
89         - clearAdClickAttribution()
90
91         They call into the network process to dump and clear Ad Click
92         Attribution state, respectively.
93
94         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
95         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
96         (WTR::TestRunner::dumpAdClickAttribution):
97         (WTR::TestRunner::clearAdClickAttribution):
98         * WebKitTestRunner/InjectedBundle/TestRunner.h:
99         * WebKitTestRunner/TestController.cpp:
100         (WTR::TestController::resetStateToConsistentValues):
101         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
102         (WTR::adClickAttributionStringResultCallback):
103         (WTR::TestController::dumpAdClickAttribution):
104         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
105         (WTR::adClickAttributionVoidCallback):
106         (WTR::TestController::clearAdClickAttribution):
107         * WebKitTestRunner/TestController.h:
108         * WebKitTestRunner/TestInvocation.cpp:
109         (WTR::TestInvocation::dumpResults):
110         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
111         (WTR::TestInvocation::dumpAdClickAttribution):
112         * WebKitTestRunner/TestInvocation.h:
113
114 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
115
116         [ews-app] Generate status-bubble
117         https://bugs.webkit.org/show_bug.cgi?id=194572
118
119         Reviewed by Lucas Forschler.
120
121         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
122         (StatusBubble._build_bubble):
123         (StatusBubble._should_show_bubble_for):
124         (StatusBubble._build_bubbles_for_patch):
125
126 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
127
128         [ews-app] Add status bubble html template
129         https://bugs.webkit.org/show_bug.cgi?id=194571
130
131         Reviewed by Lucas Forschler.
132
133         * BuildSlaveSupport/ews-app/ews/templates: Added.
134         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
135
136 2019-02-12  Chris Dumez  <cdumez@apple.com>
137
138         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
139         https://bugs.webkit.org/show_bug.cgi?id=194568
140         <rdar://problem/47944490>
141
142         Reviewed by Ryosuke Niwa.
143
144         Add API test coverage.
145
146         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
147         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
148
149 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
150
151         webkitpy: Remove bug_dummy from parsed test expectations
152         https://bugs.webkit.org/show_bug.cgi?id=194562
153         <rdar://problem/47853999>
154
155         Reviewed by Lucas Forschler.
156
157         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
158         (TestExpectationParser):
159         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
160         skipped tests.
161         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
162
163 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
164
165         [ews-app] Add method to fetch patch
166         https://bugs.webkit.org/show_bug.cgi?id=194518
167
168         Reviewed by Lucas Forschler.
169
170         * BuildSlaveSupport/ews-app/ews/models/patch.py:
171         (Patch.get_patch):
172
173 2019-02-12  Zalan Bujtas  <zalan@apple.com>
174
175         [LFC] Expand tests coverage (60 new tests -> 860)
176
177         Unreviewed test gardening (run-singly, --child-processes=1).
178
179         * LayoutReloaded/misc/LFC-passing-tests.txt:
180
181 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
182
183         Allow pages to trigger programmatic paste from script on iOS
184         https://bugs.webkit.org/show_bug.cgi?id=194271
185         <rdar://problem/47808810>
186
187         Reviewed by Tim Horton.
188
189         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
190
191         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
192         (WTR::UIScriptController::platformSetDidShowMenuCallback):
193         (WTR::UIScriptController::platformSetDidHideMenuCallback):
194         (WTR::UIScriptController::rectForMenuAction const):
195
196         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
197         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
198         for when the menu is shown or hidden.
199
200         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
201         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
202         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
203         (WTR::UIScriptController::setDidShowMenuCallback):
204         (WTR::UIScriptController::didShowMenuCallback const):
205         (WTR::UIScriptController::setDidHideMenuCallback):
206         (WTR::UIScriptController::didHideMenuCallback const):
207         (WTR::UIScriptController::platformSetDidShowMenuCallback):
208         (WTR::UIScriptController::platformSetDidHideMenuCallback):
209         (WTR::UIScriptController::rectForMenuAction const):
210         * TestRunnerShared/UIScriptContext/UIScriptController.h:
211         * WebKitTestRunner/TestController.cpp:
212         (WTR::TestController::resetPreferencesToConsistentValues):
213         (WTR::updateTestOptionsFromTestHeader):
214         * WebKitTestRunner/TestOptions.h:
215
216         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
217         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
218
219         (WTR::TestOptions::hasSameInitializationOptions const):
220         * WebKitTestRunner/UIScriptControllerCocoa.mm:
221         (WTR::UIScriptController::calendarType const):
222         (WTR::UIScriptController::platformUndoManager const):
223         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
224         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
225         (-[TestRunnerWKWebView initWithFrame:configuration:]):
226         (-[TestRunnerWKWebView dealloc]):
227         (-[TestRunnerWKWebView _didShowMenu]):
228         (-[TestRunnerWKWebView _didHideMenu]):
229
230         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
231
232         * WebKitTestRunner/ios/TestControllerIOS.mm:
233         (WTR::handleMenuWillHideNotification):
234         (WTR::handleMenuDidHideNotification):
235         (WTR::TestController::platformInitialize):
236         (WTR::TestController::platformDestroy):
237         (WTR::TestController::platformResetStateToConsistentValues):
238
239         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
240         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
241
242         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
243         (WTR::forEachViewInHierarchy):
244         (WTR::findViewInHierarchyOfType):
245
246         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
247         functions that dig through a given view's hierarchy in search of a view of a given class.
248
249         (WTR::UIScriptController::selectionStartGrabberViewRect const):
250         (WTR::UIScriptController::selectionEndGrabberViewRect const):
251         (WTR::UIScriptController::selectionCaretViewRect const):
252         (WTR::UIScriptController::selectionRangeViewRects const):
253         (WTR::UIScriptController::platformSetDidShowMenuCallback):
254         (WTR::UIScriptController::platformSetDidHideMenuCallback):
255
256         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
257
258         (WTR::UIScriptController::rectForMenuAction const):
259
260         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
261         callout bar) whose label matches the given string.
262
263         (WTR::UIScriptController::platformContentView const):
264
265         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
266         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
267         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
268
269         (WTR::UIScriptController::platformUndoManager const): Deleted.
270         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
271         (WTR::UIScriptController::platformContentView const):
272         (WTR::UIScriptController::platformUndoManager const): Deleted.
273
274 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
275
276         webkitpy: No option to only show unexpected failures in results.html for iPad
277         https://bugs.webkit.org/show_bug.cgi?id=194554
278         <rdar://problem/47922442>
279
280         Rubber-stamped by Aakash Jain.
281
282         Just because a TestExpecations file does not exist for a specific platform does not mean that
283         TestExpecations are not being used, given that platforms inherit test expectations.
284
285         * Scripts/webkitpy/port/base.py:
286         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
287         * Scripts/webkitpy/port/base_unittest.py:
288         (PortTest.test_uses_test_expectations_file):
289
290 2019-02-12  Alex Christensen  <achristensen@webkit.org>
291
292         Remove setDefersLoading infrastructure from WebKit2
293         https://bugs.webkit.org/show_bug.cgi?id=194506
294
295         Reviewed by Brady Eidson.
296
297         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
298         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
299         (WTR::TestRunner::setDefersLoading): Deleted.
300         * WebKitTestRunner/InjectedBundle/TestRunner.h:
301
302 2019-02-12  Alex Christensen  <achristensen@webkit.org>
303
304         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
305         https://bugs.webkit.org/show_bug.cgi?id=194522
306         <rdar://problem/47789393>
307
308         Reviewed by Chris Dumez.
309
310         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
311         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
312         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
313         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
314
315 2019-02-12  Andy Estes  <aestes@apple.com>
316
317         [iOSMac] Enable Parental Controls Content Filtering
318         https://bugs.webkit.org/show_bug.cgi?id=194521
319         <rdar://39732376>
320
321         Reviewed by Tim Horton.
322
323         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
324
325 2019-02-12  Zalan Bujtas  <zalan@apple.com>
326
327         [LFC][IFC] Add intrinsic width support for float boxes.
328         https://bugs.webkit.org/show_bug.cgi?id=194528
329
330         Reviewed by Antti Koivisto.
331
332         Expand tests coverage (2 new tests -> 800).
333         (This is the correct test ordering --runs-singly --child-processes=1)
334
335         * LayoutReloaded/misc/LFC-passing-tests.txt:
336
337 2019-02-12  Rob Buis  <rbuis@igalia.com>
338
339         Implement serializing in MIME type parser
340         https://bugs.webkit.org/show_bug.cgi?id=193909
341
342         Reviewed by Darin Adler.
343
344         Add various tests involving upper case, non-ASCII, control/null characters,
345         various HTTP whitespace, single quotes and an unpaired surrogate.
346
347         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
348         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
349         (TestWebKitAPI::serializeIfValid):
350         (TestWebKitAPI::TEST):
351
352 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
353
354         [Cocoa] Ask platform for generic font family mappings
355         https://bugs.webkit.org/show_bug.cgi?id=187723
356         <rdar://problem/41892438>
357
358         Reviewed by Brent Fulgham.
359
360         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
361
362         * DumpRenderTree/mac/DumpRenderTree.mm:
363         (allowedFontFamilySet):
364         * WebKitTestRunner/mac/TestControllerMac.mm:
365         (WTR::allowedFontFamilySet):
366
367 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
368
369         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
370         https://bugs.webkit.org/show_bug.cgi?id=193622
371
372         Reviewed by Michael Catanzaro.
373
374         This adds support for loading content extension rule sets from the JSON files which
375         accompany the corresponding layout test, using the C API. The Cocoa specific parts
376         of WKTR for this could be removed, but that is left for a follow-up patch with
377         cleanups.
378
379         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
380         * WebKitTestRunner/TestController.cpp:
381         (WTR::testPath): Subtract one from the length when constructing the result std::string to
382         avoid having the null-terminator copied into the result.
383         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
384         part of the preparations to run a test.
385         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
386         (WTR::contentExtensionStoreCallback): Added.
387         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
388         used for content extensions test.
389         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
390         extensions and compiling the JSON rule set for tests involving content extensions.
391         (WTR::TestController::resetContentExtensions): Removes the content extension built for
392         testing and disables content extensions.
393         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
394         resetContentExtensions().
395         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
396         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
397         configureContentExtensionForTest(), and userContentController().
398
399 2019-02-11  Daniel Bates  <dabates@apple.com>
400
401         [iOS] Mouse/Touch/Pointer events are missing modifier keys
402         https://bugs.webkit.org/show_bug.cgi?id=191446
403         <rdar://problem/45929460>
404
405         Reviewed by Tim Horton.
406
407         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
408
409         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
410         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
411         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
412         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
413         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
414         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
415         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
416         * TestRunnerShared/UIScriptContext/UIScriptController.h:
417         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
418         (WTR::arrayLength):
419         (WTR::parseModifierArray):
420         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
421         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
422         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
423         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
424
425 2019-02-11  Commit Queue  <commit-queue@webkit.org>
426
427         Unreviewed, rolling out r241272 and r241276.
428         https://bugs.webkit.org/show_bug.cgi?id=194514
429
430         Broke the Apple Internal build and the fix requires human
431         intervention :( (Requested by dydz on #webkit).
432
433         Reverted changesets:
434
435         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
436         https://bugs.webkit.org/show_bug.cgi?id=191446
437         https://trac.webkit.org/changeset/241272
438
439         "Fix internal iOS build after r241272"
440         https://bugs.webkit.org/show_bug.cgi?id=191446
441         https://trac.webkit.org/changeset/241276
442
443 2019-02-11  Truitt Savell  <tsavell@apple.com>
444
445         Unreviewed, rolling out r241269.
446
447         Caused 5 layout tests crashes on Mac WK1
448
449         Reverted changeset:
450
451         "DumpRenderTree should report unknown options"
452         https://bugs.webkit.org/show_bug.cgi?id=191303
453         https://trac.webkit.org/changeset/241269
454
455 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
456
457         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
458         https://bugs.webkit.org/show_bug.cgi?id=194313
459
460         Reviewed by Tim Horton.
461
462         Add a helper to determine whether the web view is presenting modal UI.
463
464         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
465         (WTR::UIScriptController::isPresentingModally const):
466         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
467         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
468         (WTR::UIScriptController::isPresentingModally const):
469         * TestRunnerShared/UIScriptContext/UIScriptController.h:
470         * WebKitTestRunner/UIScriptControllerCocoa.mm:
471         (WTR::UIScriptController::calendarType const): Deleted.
472         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
473         (WTR::UIScriptController::isPresentingModally const):
474         (WTR::UIScriptController::calendarType const):
475         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
476         (WTR::UIScriptController::calendarType const):
477
478 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
479
480         GCHeapInspector: Show the retained sizes in more places
481         https://bugs.webkit.org/show_bug.cgi?id=194464
482
483         Reviewed by Simon Fraser.
484
485         * GCHeapInspector/gc-heap-inspector.html:
486         * GCHeapInspector/script/interface.js:
487         (HeapInspectorUtils.humanReadableSize):
488         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
489         (HeapInspectorUtils.spanForNode.span.span):
490         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
491         (HeapSnapshotInspector.prototype.buildRoots):
492
493 2019-02-11  Daniel Bates  <dabates@apple.com>
494
495         [iOS] Mouse/Touch/Pointer events are missing modifier keys
496         https://bugs.webkit.org/show_bug.cgi?id=191446
497         <rdar://problem/45929460>
498
499         Reviewed by Tim Horton.
500
501         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
502
503         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
504         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
505         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
506         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
507         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
508         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
509         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
510         * TestRunnerShared/UIScriptContext/UIScriptController.h:
511         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
512         (WTR::arrayLength):
513         (WTR::parseModifierArray):
514         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
515         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
516         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
517         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
518
519 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
520
521         DumpRenderTree should report unknown options
522         https://bugs.webkit.org/show_bug.cgi?id=191303
523
524         Reviewed by Frédéric Wang.
525
526         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
527         to report unknown options.
528         Added and assigned test options which are currently used in tests.
529
530         * DumpRenderTree/TestOptions.cpp:
531         (TestOptions::TestOptions):
532
533 2019-02-11  Truitt Savell  <tsavell@apple.com>
534
535         Unreviewed, rolling out r241229.
536
537         Revision broke internal builds for watchOS.
538
539         Reverted changeset:
540
541         "[Cocoa] Ask platform for generic font family mappings"
542         https://bugs.webkit.org/show_bug.cgi?id=187723
543         https://trac.webkit.org/changeset/241229
544
545 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
546
547         [WinCairo][MiniBrowser] Basic authentication always fails.
548         https://bugs.webkit.org/show_bug.cgi?id=194496
549
550         Reviewed by Don Olmstead.
551
552         * MiniBrowser/win/DialogHelper.h:
553         (Dialog::getText):
554
555 2019-02-11  Philippe Normand  <pnormand@igalia.com>
556
557         [GStreamer] GstMappedBuffer testsuite build fails
558         https://bugs.webkit.org/show_bug.cgi?id=194495
559
560         Reviewed by Carlos Garcia Campos.
561
562         Fix the build by explicitely adding the gstreamer1.0-audio include
563         directories to the include path.
564
565         * TestWebKitAPI/PlatformGTK.cmake:
566         * TestWebKitAPI/PlatformWPE.cmake:
567
568 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
569
570         [GTK][WPE] Add enable-javascript-markup setting
571         https://bugs.webkit.org/show_bug.cgi?id=193439
572
573         Reviewed by Michael Catanzaro.
574
575         Add test cases to check the new setting.
576
577         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
578         (testWebKitSettings):
579         (testWebKitSettingsJavaScriptMarkup):
580         (beforeAll):
581
582 2019-02-10  Darin Adler  <darin@apple.com>
583
584         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
585         https://bugs.webkit.org/show_bug.cgi?id=194485
586
587         Reviewed by Daniel Bates.
588
589         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
590
591 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
592
593         Add more tests for clampTo<>()
594         https://bugs.webkit.org/show_bug.cgi?id=194462
595
596         Reviewed by Geoffrey Garen.
597
598         Darin suggested to test the very last floating point number
599         at the boundaries when truncating to integer.
600         I added test for max/min and max-1/min-1.
601
602         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
603         (TestWebKitAPI::TEST):
604
605 2019-02-09  Darin Adler  <darin@apple.com>
606
607         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
608         https://bugs.webkit.org/show_bug.cgi?id=194021
609
610         Reviewed by Geoffrey Garen.
611
612         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
613         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
614         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
615
616 2019-02-09  Zalan Bujtas  <zalan@apple.com>
617
618         [LFC][IFC] Add intrinsic width support for basic inline containers
619         https://bugs.webkit.org/show_bug.cgi?id=194473
620
621         Reviewed by Antti Koivisto.
622
623         Expand tests coverage (11 new tests -> 798)
624
625         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
626
627 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
628
629         Fix MiniBrowser's entitlements
630         https://bugs.webkit.org/show_bug.cgi?id=192431
631
632         Reviewed by Joseph Pecoraro.
633
634         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
635         files, making it impossible to load any extension.
636
637         * MiniBrowser/MiniBrowser.entitlements:
638
639 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
640
641         [Cocoa] Ask platform for generic font family mappings
642         https://bugs.webkit.org/show_bug.cgi?id=187723
643         <rdar://problem/41892438>
644
645         Reviewed by Brent Fulgham.
646
647         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
648
649         * DumpRenderTree/mac/DumpRenderTree.mm:
650         (allowedFontFamilySet):
651         * WebKitTestRunner/mac/TestControllerMac.mm:
652         (WTR::allowedFontFamilySet):
653
654 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
655
656         [GTK] Implement back/forward touchpad gesture
657         https://bugs.webkit.org/show_bug.cgi?id=193919
658
659         Reviewed by Michael Catanzaro.
660
661         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
662         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
663
664 2019-02-08  Alex Christensen  <achristensen@webkit.org>
665
666         Add SPI to use networking daemon instead of XPC service
667         https://bugs.webkit.org/show_bug.cgi?id=194427
668
669         Reviewed by Geoffrey Garen
670
671         * MiniBrowser/MiniBrowser.entitlements:
672
673 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
674
675         [ews-build] Ensure that every builder in config.json has short name
676         https://bugs.webkit.org/show_bug.cgi?id=194461
677
678         Reviewed by Lucas Forschler.
679
680         * BuildSlaveSupport/ews-build/loadConfig.py:
681         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
682
683 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
684
685         [ews-build] Add short name to config.json
686         https://bugs.webkit.org/show_bug.cgi?id=194456
687
688         Reviewed by Lucas Forschler.
689
690         * BuildSlaveSupport/ews-build/config.json: Added short name.
691         * BuildSlaveSupport/ews-build/loadConfig.py:
692         (loadBuilderConfig): Set the short name as the builder description.
693
694 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
695
696         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
697         https://bugs.webkit.org/show_bug.cgi?id=194418
698
699         Reviewed by Lucas Forschler.
700
701         Do not include errors trying when finding crashlogs at the end of
702         a run-webkit-tests run since we don't process those errors.
703
704         * Scripts/webkitpy/port/darwin.py:
705         (DarwinPort._look_for_all_crash_logs_in_log_dir):
706         * Scripts/webkitpy/port/ios_device.py:
707         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
708         * Scripts/webkitpy/port/watch_device.py:
709         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
710
711 2019-02-08  Beth Dakin  <bdakin@apple.com>
712
713         Add afterScreenUpdates to WKSnapshotConfiguration
714         https://bugs.webkit.org/show_bug.cgi?id=194362
715         -and corresponding-
716         <rdar://problem/40655528> Please add an "after screen updates" property to 
717         WKSnapshotConfiguration (to solve blank snapshots)
718
719         Reviewed by Tim Horton.
720
721         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
722         (TEST):
723
724 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
725
726         clampTo(): do not convert the input to double when dealing with integers
727         https://bugs.webkit.org/show_bug.cgi?id=194263
728         <rdar://problem/47692312>
729
730         Reviewed by Darin Adler.
731
732         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
733         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
734         (TestWebKitAPI::testClampFloatingPointToInteger):
735         (TestWebKitAPI::testClampSameSignIntegers):
736         (TestWebKitAPI::testClampUnsignedToSigned):
737         (TestWebKitAPI::testClampSignedToUnsigned):
738
739 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
740
741         webkitpy: Respect --dedicated-simulators flag
742         https://bugs.webkit.org/show_bug.cgi?id=194416
743         <rdar://problem/47894722>
744
745         Reviewed by Lucas Forschler.
746
747         * Scripts/webkitpy/port/device_port.py:
748         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
749         available devices can be safely ignored.
750
751 2019-02-07  Keith Rollin  <krollin@apple.com>
752
753         Remove extra copy of 100x100-red.tga
754         https://bugs.webkit.org/show_bug.cgi?id=194371
755         <rdar://problem/47873465>
756
757         Reviewed by Said Abou-Hallawa.
758
759         In order to help it pass its tests, Bug 194190 added a second copy of
760         the file 100x100-red.tga. However, it turns out that this additional
761         file wasn't actually needed, and that that sole previous copy was
762         sufficient. At the same time, this second copy -- which was copied to
763         the same location in the build output as the first copy -- now caused
764         XCBuild to complain because there were two production rules for the
765         same output file. Address this by removing the newly-added extra copy.
766
767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
768         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
769
770 2019-02-07  Alex Christensen  <achristensen@webkit.org>
771
772         Deprecate WKBundlePageSetDefersLoading
773         https://bugs.webkit.org/show_bug.cgi?id=191394
774
775         Reviewed by Dean Jackson.
776
777         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
778         (WTR::TestRunner::setDefersLoading):
779
780 2019-02-07  Zalan Bujtas  <zalan@apple.com>
781
782         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
783         https://bugs.webkit.org/show_bug.cgi?id=194391
784
785         Reviewed by Antti Koivisto.
786
787         * LayoutReloaded/misc/LFC-passing-tests.txt:
788
789 2019-02-06  Keith Rollin  <krollin@apple.com>
790
791         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
792         https://bugs.webkit.org/show_bug.cgi?id=193975
793         <rdar://problem/47643306>
794
795         Reviewed by Tim Horton.
796
797         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
798         the Info.plist file into the bundle. This step is not necessary as the
799         implicit "bundle up all the build products into a framework" build
800         phase does this already. Having the Copy Bundle Resources phase do
801         this causes a conflict under XCBuild, which objects to two build
802         phases producing the same file (Info.plist). Address this by removing
803         Info.plist from the Copy Bundle Resources phase.
804
805         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
806
807 2019-02-06  Keith Rollin  <krollin@apple.com>
808
809         Really enable the automatic checking and regenerations of .xcfilelists during builds
810         https://bugs.webkit.org/show_bug.cgi?id=194357
811         <rdar://problem/47861231>
812
813         Reviewed by Chris Dumez.
814
815         Bug 194124 was supposed to enable the automatic checking and
816         regenerating of .xcfilelist files during the build. While related
817         changes were included in that patch, the change to actually enable the
818         operation somehow was omitted. This patch actually enables the
819         operation. The check-xcfilelist.sh scripts now check
820         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
821         from the checking.
822
823         * DumpRenderTree/Scripts/check-xcfilelists.sh:
824         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
825
826 2019-02-06  David Kilzer  <ddkilzer@apple.com>
827
828         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
829         <https://webkit.org/b/194286>
830         <rdar://problem/47815558>
831
832         Reviewed by Alexey Proskuryakov.
833
834         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
835         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
836         WKRetainPtr<> to avoid leaking the WKDataRef.
837
838 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
839
840         Unreviewed, fix a typo
841
842         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
843
844 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
845
846         [GTK][WPE] force libpsl build to use ICU in jhbuild
847         https://bugs.webkit.org/show_bug.cgi?id=194288
848
849         Reviewed by Carlos Garcia Campos.
850
851         * gtk/jhbuild.modules:
852         Require ICU for libpsl build in jhbuild, like done in WPE.
853
854 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
855
856         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
857         https://bugs.webkit.org/show_bug.cgi?id=194209
858
859         Reviewed by Carlos Garcia Campos.
860
861         Enhance TestCookieManager to ensure this doesn't happen again.
862
863         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
864         (testCookieManagerPersistentStorage):
865         (beforeAll):
866
867 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
868
869         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
870         https://bugs.webkit.org/show_bug.cgi?id=194324
871
872         Reviewed by Andy Estes.
873
874         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
875         part of the name is already implicit, since this is in testing code in TestOptions.
876
877         * WebKitTestRunner/TestController.cpp:
878         (WTR::TestController::generateContextConfiguration const):
879         (WTR::updateTestOptionsFromTestHeader):
880         * WebKitTestRunner/TestOptions.h:
881         (WTR::TestOptions::hasSameInitializationOptions const):
882
883 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
884
885         [ews-build] Allow * as platform for builders and workers
886         https://bugs.webkit.org/show_bug.cgi?id=188533
887
888         Reviewed by Lucas Forschler.
889
890         * BuildSlaveSupport/ews-build/loadConfig.py:
891         (checkWorkersAndBuildersForConsistency):
892
893 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
894
895         [ews-build] Add few bots to config.json
896         https://bugs.webkit.org/show_bug.cgi?id=194304
897
898         Reviewed by Lucas Forschler.
899
900         * BuildSlaveSupport/ews-build/config.json:
901
902 2019-02-05  Keith Rollin  <krollin@apple.com>
903
904         Enable the automatic checking and regenerations of .xcfilelists during builds
905         https://bugs.webkit.org/show_bug.cgi?id=194124
906         <rdar://problem/47721277>
907
908         Reviewed by Tim Horton.
909
910         Bug 193790 add a facility for checking -- during build time -- that
911         any needed .xcfilelist files are up-to-date and for updating them if
912         they are not. This facility was initially opt-in by setting
913         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
914         the process seemed robust. Its now time to enable this facility and
915         make it opt-out. If there is a need to disable this facility, set and
916         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
917         running `make` or `build-webkit`, or before running Xcode from the
918         command line.
919
920         Additionally, remove the step that generates a list of source files
921         going into the UnifiedSources build step. It's only necessarily to
922         specify Sources.txt and SourcesCocoa.txt as inputs.
923
924         * Scripts/generate-xcfilelists:
925
926 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
927
928         [GTK][WPE] force libpsl build to use ICU in jhbuild
929         https://bugs.webkit.org/show_bug.cgi?id=194288
930
931         Reviewed by Philippe Normand.
932
933         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
934         This can cause build failures if libidn is detected but libunistring is not available.
935
936         Make sure that ICU is used for runtime and builtin PSL data.
937
938         * gtk/jhbuild.modules:
939         * wpe/jhbuild.modules:
940
941 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
942
943         [ews-app] Modified timestamp should be updated on updating data
944         https://bugs.webkit.org/show_bug.cgi?id=194295
945
946         Reviewed by Lucas Forschler.
947
948         * BuildSlaveSupport/ews-app/ews/models/build.py:
949         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
950         * BuildSlaveSupport/ews-app/ews/models/step.py:
951
952 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
953
954         Unreviewed, rolling out r240742.
955
956         Causes crashes on iOS simulator.
957
958         Reverted changeset:
959
960         "[iOS] Keyups for non-modifier keys identified as "Dead" when
961         not focused in a content-editable element"
962         https://bugs.webkit.org/show_bug.cgi?id=192824
963         https://trac.webkit.org/changeset/240742
964
965 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
966
967         run-webkit-tests emits message "...running None" when running tests
968         https://bugs.webkit.org/show_bug.cgi?id=194133
969         <rdar://problem/47724738>
970
971         Reviewed by Lucas Forschler.
972
973         * Scripts/webkitpy/xcode/device_type.py:
974         (DeviceType.__str__): Use both version mapping tables and use just the variant
975         name if no version name is available.
976         * Scripts/webkitpy/xcode/device_type_unittest.py:
977         (DeviceTypeTest):
978         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
979         an associated named.
980
981 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
982
983         [WPE] require python3-setuptools for meson build in jhbuild
984         https://bugs.webkit.org/show_bug.cgi?id=194287
985
986         Reviewed by Philippe Normand.
987
988         python3-setuptools is needed to build meson in jhbuild.
989         It is already required by the GTK port.
990
991         * wpe/install-dependencies:
992
993 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
994
995         [ews-app] Add method to save BuilderMapping to database
996         https://bugs.webkit.org/show_bug.cgi?id=194264
997
998         Reviewed by Lucas Forschler.
999
1000         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1001         (BuilderMapping.__str__):
1002         (BuilderMapping):
1003         (BuilderMapping.save_mapping):
1004         (BuilderMapping.update_mapping):
1005         (BuilderMapping.get_existing_mapping):
1006         (BuilderMapping.is_valid_mapping):
1007
1008 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1009
1010         [ews-app] Add timestamp fields for BuilderMappings
1011         https://bugs.webkit.org/show_bug.cgi?id=194266
1012
1013         Reviewed by Lucas Forschler.
1014
1015         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1016         (BuilderMapping):
1017
1018 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1019
1020         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1021         https://bugs.webkit.org/show_bug.cgi?id=174816
1022
1023         Reviewed by Michael Catanzaro.
1024
1025         Add tests for webkit_uri_for_display().
1026
1027         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1028         (testURIForDisplayUnaffected):
1029         (testURIForDisplayAffected):
1030         (beforeAll):
1031         (afterAll):
1032         * TestWebKitAPI/glib/CMakeLists.txt:
1033
1034 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1035
1036         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1037         https://bugs.webkit.org/show_bug.cgi?id=194158
1038         <rdar://problem/47737268>
1039
1040         Rubber-stamped by Aakash Jain.
1041
1042         * Scripts/webkitpy/port/device_port.py:
1043         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1044
1045 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1046
1047         [CG] Enable setAdditionalSupportedImageTypes for WK1
1048         https://bugs.webkit.org/show_bug.cgi?id=194190
1049
1050         Reviewed by Tim Horton.
1051
1052         Add a test similar to the one under WebKit Cocoa but make it create a
1053         WebView instead of a WKWebView.
1054
1055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1056         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1057         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1058         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1059         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1060         (TestWebKitAPI::runTest):
1061         (TestWebKitAPI::TEST):
1062
1063 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1064
1065         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1066         https://bugs.webkit.org/show_bug.cgi?id=194168
1067
1068         Reviewed by Simon Fraser.
1069
1070         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1071
1072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1073         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1074         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1075         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1076         (TEST):
1077         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1078         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1079
1080 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1081
1082         REGRESSION (r237269): webkit-patch what-broke is broken 
1083         https://bugs.webkit.org/show_bug.cgi?id=193025
1084
1085         Reviewed by Aakash Jain.
1086
1087         * Scripts/webkitpy/common/host.py:
1088         (Host.buildbot):
1089         (Host.bugzilla): Renamed to 'buildbot'.
1090
1091 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1092
1093         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1094         https://bugs.webkit.org/show_bug.cgi?id=194207
1095
1096         Reviewed by Tim Horton.
1097
1098         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1099         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1100         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1101         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1102         start and delete forwards to remove the original attachment.
1103
1104         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1105         (TestWebKitAPI::TEST):
1106
1107 2019-02-04  Youenn Fablet  <youenn@apple.com>
1108
1109         Capture state should be managed consistently when doing process swapping
1110         https://bugs.webkit.org/show_bug.cgi?id=194122
1111         <rdar://problem/47609293>
1112
1113         Reviewed by Eric Carlson.
1114
1115         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1116         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1117         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1118         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1119         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1120         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1121         (WTR::TestRunner::isDoingMediaCapture const):
1122         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1123         * WebKitTestRunner/TestController.cpp:
1124         (WTR::TestController::isDoingMediaCapture const):
1125         * WebKitTestRunner/TestController.h:
1126         * WebKitTestRunner/TestInvocation.cpp:
1127         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1128         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1129         (WTR::TestController::isDoingMediaCapture const):
1130
1131 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1132
1133         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1134         https://bugs.webkit.org/show_bug.cgi?id=194142
1135
1136         Reviewed by Ross Kirsling.
1137
1138         There three 'separator' variables in TestController.cpp. Renamed
1139         it 'pathSeparator', and unified them.
1140
1141         * WebKitTestRunner/TestController.cpp:
1142         (WTR::TestController::generateContextConfiguration const):
1143         (WTR::createTestURL):
1144         (WTR::TestController::platformAdjustContext):
1145
1146 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1147
1148         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1149         https://bugs.webkit.org/show_bug.cgi?id=194198
1150
1151         Reviewed by Antti Koivisto.
1152
1153         No need to set the banner heights on navigation now, since Page stores them.
1154
1155         * MiniBrowser/mac/WK2BrowserWindowController.m:
1156         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1157
1158 2019-02-03  John Wilander  <wilander@apple.com>
1159
1160         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1161         https://bugs.webkit.org/show_bug.cgi?id=194104
1162         <rdar://problem/47649991>
1163
1164         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1165
1166         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1167         (TestWebKitAPI::TEST):
1168             Changed numeric types from unsigned short to uint32_t.
1169
1170 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1171
1172         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1173         <https://webkit.org/b/194178>
1174         <rdar://problem/47753473>
1175
1176         Reviewed by Alexey Proskuryakov.
1177
1178         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1179         (WTR::uninstallFakeHelvetica): Pass nullptr into
1180         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1181
1182 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1183
1184         [LFC] Initialize ICB's style with fixed width/height.
1185         https://bugs.webkit.org/show_bug.cgi?id=194188
1186
1187         Reviewed by Antti Koivisto.
1188
1189         * LayoutReloaded/misc/LFC-passing-tests.txt:
1190
1191 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1192
1193         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1194         https://bugs.webkit.org/show_bug.cgi?id=194185
1195
1196         Reviewed by Antti Koivisto.
1197
1198         * LayoutReloaded/misc/LFC-passing-tests.txt:
1199
1200 2018-12-16  Darin Adler  <darin@apple.com>
1201
1202         Convert additional String::format clients to alternative approaches
1203         https://bugs.webkit.org/show_bug.cgi?id=192746
1204
1205         Reviewed by Alexey Proskuryakov.
1206
1207         * WebKitTestRunner/TestController.cpp:
1208         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1209         as an intermediate in code that ultimately constructs a WTF::String.
1210         (WTR::userMediaOriginHash): Use makeString.
1211         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1212         (WTR::TestController::didPerformClientRedirect): Ditto.
1213         (WTR::TestController::didPerformServerRedirect): Ditto.
1214         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1215
1216 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1217
1218         [ews-build] Add unit test to verify builder keys
1219         https://bugs.webkit.org/show_bug.cgi?id=194152
1220
1221         Reviewed by Lucas Forschler.
1222
1223         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1224         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1225
1226 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1227
1228         [LFC] Expand tests coverage (12 new tests -> 787)
1229
1230         Unreviewed test gardening.
1231
1232         * LayoutReloaded/misc/LFC-passing-tests.txt:
1233
1234 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1235
1236         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1237         https://bugs.webkit.org/show_bug.cgi?id=194163
1238
1239         Reviewed by Simon Fraser.
1240
1241         775
1242
1243         * LayoutReloaded/misc/LFC-passing-tests.txt:
1244
1245 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1246
1247         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1248         https://bugs.webkit.org/show_bug.cgi?id=194140
1249         <rdar://problem/47728098>
1250
1251         Reviewed by Tim Horton.
1252
1253         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1254         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1255         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1256
1257         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1258         test to induce an IPC deadlock when presenting a modal alert during touch start.
1259
1260         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1261         * WebKitTestRunner/TestController.cpp:
1262         (WTR::runJavaScriptAlert):
1263
1264         Add a client callback function for running JavaScript alerts.
1265
1266         (WTR::TestController::createOtherPage):
1267         (WTR::TestController::generateContextConfiguration const):
1268
1269         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1270         the fix in this patch.
1271
1272         (WTR::TestController::createWebViewWithOptions):
1273
1274         Plumb TestOptions to generateContextConfiguration.
1275
1276         (WTR::TestController::resetPreferencesToConsistentValues):
1277         (WTR::TestController::resetStateToConsistentValues):
1278         (WTR::updateTestOptionsFromTestHeader):
1279         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1280         (WTR::TestController::handleJavaScriptAlert):
1281         * WebKitTestRunner/TestController.h:
1282         * WebKitTestRunner/TestInvocation.cpp:
1283         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1284         * WebKitTestRunner/TestOptions.h:
1285         (WTR::TestOptions::hasSameInitializationOptions const):
1286
1287 2019-02-01  Chris Dumez  <cdumez@apple.com>
1288
1289         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1290         https://bugs.webkit.org/show_bug.cgi?id=193740
1291         <rdar://problem/47527267>
1292
1293         Reviewed by Alex Christensen.
1294
1295         Add API test coverage.
1296
1297         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1298
1299 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1300
1301         [ews-app] Add display name field to BuilderMapping model
1302         https://bugs.webkit.org/show_bug.cgi?id=194153
1303
1304         Reviewed by Lucas Forschler.
1305
1306         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1307         (BuilderMapping):
1308
1309 2019-02-01  Youenn Fablet  <youenn@apple.com>
1310
1311         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1312         https://bugs.webkit.org/show_bug.cgi?id=194155
1313
1314         Reviewed by Eric Carlson.
1315
1316         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1317         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1318         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1319
1320 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1321
1322         [LFC] Adjust replaced element's intrinsic ratio
1323         https://bugs.webkit.org/show_bug.cgi?id=194154
1324
1325         Reviewed by Antti Koivisto.
1326
1327         761
1328
1329         * LayoutReloaded/misc/LFC-passing-tests.txt:
1330
1331 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1332
1333         [WPE] Show test results in minibrowser
1334         https://bugs.webkit.org/show_bug.cgi?id=194150
1335
1336         Reviewed by Žan Doberšek.
1337
1338         * Scripts/webkitpy/port/wpe.py:
1339         (WPEPort.show_results_html_file):
1340
1341 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1342
1343         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1344         https://bugs.webkit.org/show_bug.cgi?id=194151
1345
1346         Reviewed by Žan Doberšek.
1347
1348         ALT + <- go back
1349         ALT + -> go forward
1350
1351         * MiniBrowser/wpe/main.cpp:
1352         (main):
1353
1354 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1355
1356         [LFC] Set intrinsic size on Layout::Replaced
1357         https://bugs.webkit.org/show_bug.cgi?id=194139
1358
1359         Reviewed by Antti Koivisto.
1360
1361         744
1362
1363         * LayoutReloaded/misc/LFC-passing-tests.txt:
1364
1365 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1366
1367         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1368         https://bugs.webkit.org/show_bug.cgi?id=194146
1369
1370         Reviewed by Xabier Rodriguez-Calvar.
1371
1372         It allows to open relative paths.
1373
1374         * MiniBrowser/wpe/main.cpp:
1375         (main):
1376
1377 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1378
1379         Update flakiness dashboard configuration after recent queue changes
1380         https://bugs.webkit.org/show_bug.cgi?id=194127
1381
1382         Rubber-stamped by Aakash Jain.
1383
1384         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1385
1386         * TestResultServer/static-dashboards/builders.jsonp:
1387
1388 2019-01-31  Youenn Fablet  <youenn@apple.com>
1389
1390         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1391         https://bugs.webkit.org/show_bug.cgi?id=194106
1392         <rdar://problem/47676333>
1393
1394         Reviewed by Ryosuke Niwa.
1395
1396         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1397         (TestWebKitAPI::didFinishNavigation):
1398         (TestWebKitAPI::TEST):
1399         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1400
1401 2019-01-31  Chris Dumez  <cdumez@apple.com>
1402
1403         Page zoom level is lost after a process swap or a crash
1404         https://bugs.webkit.org/show_bug.cgi?id=194105
1405         <rdar://problem/47610781>
1406
1407         Reviewed by Alex Christensen.
1408
1409         Add API test coverage.
1410
1411         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1412         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1413
1414 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1415
1416         Revert r238819 which is unneeded and caused a performance regression.
1417         https://bugs.webkit.org/show_bug.cgi?id=192272
1418         <rdar://problem/46664625>
1419
1420         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1421         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1422         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1423
1424 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1425
1426         Formalize WebKitAdditions mechanism of LoadOptimizer
1427         https://bugs.webkit.org/show_bug.cgi?id=193886
1428         <rdar://problem/47696809>
1429
1430         Reviewed by Brent Fulgham.
1431
1432         * MiniBrowser/MiniBrowser.entitlements:
1433         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1434
1435 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1436
1437         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1438         https://bugs.webkit.org/show_bug.cgi?id=194090
1439
1440         Reviewed by Antti Koivisto.
1441
1442         * LayoutReloaded/misc/LFC-passing-tests.txt:
1443
1444 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1445
1446         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1447         https://bugs.webkit.org/show_bug.cgi?id=194074
1448
1449         Reviewed by Antti Koivisto.
1450
1451         * LayoutReloaded/misc/LFC-passing-tests.txt:
1452
1453 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1454
1455         [LFC][BFC] Add support for block level replaced box.
1456         https://bugs.webkit.org/show_bug.cgi?id=194071
1457
1458         Reviewed by Antti Koivisto.
1459
1460         * LayoutReloaded/misc/LFC-passing-tests.txt:
1461
1462 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1463
1464         Fix WebKitTestRunner's testPath with Windows full paths
1465         https://bugs.webkit.org/show_bug.cgi?id=194012
1466
1467         Reviewed by Alex Christensen.
1468
1469         updateTestOptionsFromTestHeader failed to open test files because
1470         testPath returned wrong file paths. It returned a path "/C:/..."
1471         if a URL "file:///C:/..." was given.
1472
1473         * WebKitTestRunner/TestController.cpp:
1474         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1475
1476 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1477
1478         [WPE] Bump font related dependencies to match the GTK+ port
1479         https://bugs.webkit.org/show_bug.cgi?id=194017
1480
1481         Reviewed by Žan Doberšek.
1482
1483         * wpe/jhbuild.modules:
1484         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1485         * wpe/patches/icudata-stdlibs.patch: Added.
1486
1487 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1488
1489         Enable swipe tests on iOS
1490         https://bugs.webkit.org/show_bug.cgi?id=194076
1491
1492         Reviewed by Geoffrey Garen.
1493
1494         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1495         it causes a debug assertion failure in runUIScript.
1496
1497         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1498         (WTR::UIScriptController::beginBackSwipe):
1499         (WTR::UIScriptController::completeBackSwipe):
1500
1501 2019-01-30  Keith Rollin  <krollin@apple.com>
1502
1503         Use correct printf format specifier
1504         https://bugs.webkit.org/show_bug.cgi?id=194062
1505         <rdar://problem/47686167>
1506
1507         Reviewed by Alexey Proskuryakov.
1508
1509         LayoutTestSpellChecker.mm is trying to format a variable of type
1510         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1511         actually an unsigned long long. Fix this by formatting with %llu.
1512
1513         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1514         (-[LayoutTestTextCheckingResult description]):
1515
1516 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1517
1518         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1519         https://bugs.webkit.org/show_bug.cgi?id=193979
1520
1521         Reviewed by Wenson Hsieh.
1522
1523         Fix the test for iOS. Make the test work with iOS UA string.
1524
1525         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1526
1527 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1528
1529         Replace High Sierra LLINT CLoop bot due to hardware failure
1530         https://bugs.webkit.org/show_bug.cgi?id=194066
1531
1532         Reviewed by Aakash Jain.
1533
1534         * BuildSlaveSupport/build.webkit.org-config/config.json:
1535
1536 2019-01-30  Keith Rollin  <krollin@apple.com>
1537
1538         [NSDragItem init] is unavailable
1539         https://bugs.webkit.org/show_bug.cgi?id=194059
1540         <rdar://problem/47685715>
1541
1542         Reviewed by Wenson Hsieh.
1543
1544         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1545         DumpRenderTree and TestWebKitAPI, which both try to create an
1546         NSDragItem in a manner that invokes this method. Address this by using
1547         -initWithPasteboardWriter instead.
1548
1549         Note that the parameter passed to initWithPasteboardWriter is likely
1550         incorrect. In both cases, the object passed does not conform to
1551         NSPasteboardWriting. However, with this fix, we're no worse off than
1552         before, and can now perform builds with newer compilers and SDKs until
1553         a real fix can be crafted. That work is tracked in
1554         https://bugs.webkit.org/show_bug.cgi?id=194060
1555
1556         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1557         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1558         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1559         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1560
1561 2019-01-30  Daniel Bates  <dabates@apple.com>
1562
1563         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1564         https://bugs.webkit.org/show_bug.cgi?id=192824
1565         <rdar://problem/47100332>
1566
1567         Reviewed by Wenson Hsieh.
1568
1569         Fix a bug where the wrong usage code was used for F13 thru F24.
1570
1571         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1572         (keyCodeForDOMFunctionKey):
1573
1574 2019-01-30  Chris Dumez  <cdumez@apple.com>
1575
1576         Regression(PSON) Load hang can occur on history navigation
1577         https://bugs.webkit.org/show_bug.cgi?id=194030
1578         <rdar://problem/47656939>
1579
1580         Reviewed by Antti Koivisto.
1581
1582         Add API test coverage.
1583
1584         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1585
1586 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1587
1588         [LFC] Expand tests coverage.
1589
1590         Unreviewed test gardening.
1591
1592         * LayoutReloaded/misc/LFC-passing-tests.txt:
1593
1594 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1595
1596         [Flatpak] Add openjpeg support
1597         https://bugs.webkit.org/show_bug.cgi?id=194019
1598
1599         Reviewed by Michael Catanzaro.
1600
1601         * flatpak/org.webkit.CommonModules.yaml:
1602
1603 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1604
1605         Unreviewed, rolling out r240708.
1606         https://bugs.webkit.org/show_bug.cgi?id=194022
1607
1608         It broke WPE build (Requested by KaL on #webkit).
1609
1610         Reverted changeset:
1611
1612         "[WPE] Bump font related dependencies to match the GTK+ port"
1613         https://bugs.webkit.org/show_bug.cgi?id=194017
1614         https://trac.webkit.org/changeset/240708
1615
1616 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1617
1618         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1619         https://bugs.webkit.org/show_bug.cgi?id=194001
1620
1621         Reviewed by Antti Koivisto.
1622
1623         * LayoutReloaded/misc/LFC-passing-tests.txt:
1624
1625 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1626
1627         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1628         https://bugs.webkit.org/show_bug.cgi?id=194020
1629
1630         Reviewed by Antti Koivisto.
1631
1632         * LayoutReloaded/misc/LFC-passing-tests.txt:
1633
1634 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1635
1636         AX: Support color well on iOS
1637         https://bugs.webkit.org/show_bug.cgi?id=194010
1638
1639         Reviewed by Joanmarie Diggs.
1640
1641         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1642         (WTR::AccessibilityUIElement::stringAttributeValue):
1643
1644 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1645
1646         [WPE] Bump font related dependencies to match the GTK+ port
1647         https://bugs.webkit.org/show_bug.cgi?id=194017
1648
1649         Reviewed by Žan Doberšek.
1650
1651         * wpe/jhbuild.modules:
1652         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1653         * wpe/patches/icudata-stdlibs.patch: Added.
1654
1655 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1656
1657         [Mac] Update window scale API usage
1658         https://bugs.webkit.org/show_bug.cgi?id=193991
1659         rdar://problem/47614795
1660
1661         Reviewed by Tim Horton.
1662
1663         * DumpRenderTree/mac/DumpRenderTree.mm:
1664         (changeWindowScaleIfNeeded):
1665         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1666         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1667         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1668
1669 2019-01-29  Chris Dumez  <cdumez@apple.com>
1670
1671         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1672         https://bugs.webkit.org/show_bug.cgi?id=193977
1673         <rdar://problem/47643716>
1674
1675         Reviewed by Geoff Garen.
1676
1677         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1678         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1679         to the previous provisional committing *before* we make the last load. 
1680
1681         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1682
1683 2019-01-29  Youenn Fablet  <youenn@apple.com>
1684
1685         Adopt new SPI to evaluate server certificate trust
1686         https://bugs.webkit.org/show_bug.cgi?id=193355
1687
1688         Reviewed by Alex Christensen.
1689
1690         Add infrastructure to handle HTTPS server trust evaluation testing.
1691
1692         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1693         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1694         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1695         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1696         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1697         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1698         * WebKitTestRunner/TestController.cpp:
1699         (WTR::TestController::resetPreferencesToConsistentValues):
1700         (WTR::TestController::didReceiveAuthenticationChallenge):
1701         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1702         * WebKitTestRunner/TestController.h:
1703         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1704         * WebKitTestRunner/TestInvocation.cpp:
1705         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1706         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1707         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1708
1709 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1710
1711         [ews-build] Add build step to print bot Configuration
1712         https://bugs.webkit.org/show_bug.cgi?id=193887
1713
1714         Reviewed by Lucas Forschler.
1715
1716         * BuildSlaveSupport/ews-build/steps.py:
1717         (PrintConfiguration): Build step to print configuration.
1718         * BuildSlaveSupport/ews-build/factories.py:
1719
1720 2019-01-29  Chris Dumez  <cdumez@apple.com>
1721
1722         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1723         https://bugs.webkit.org/show_bug.cgi?id=193967
1724         <rdar://problem/47635348>
1725
1726         Reviewed by Alex Christensen.
1727
1728         Add API test coverage.
1729
1730         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1731         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1732
1733 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1734
1735         [ews-app] Handle incoming results data
1736         https://bugs.webkit.org/show_bug.cgi?id=193973
1737
1738         Reviewed by Lucas Forschler.
1739
1740         * BuildSlaveSupport/ews-app/ews/views/results.py:
1741
1742 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1743
1744         [ews-app] Make the results url generic
1745         https://bugs.webkit.org/show_bug.cgi?id=193928
1746
1747         Reviewed by Lucas Forschler.
1748
1749         * BuildSlaveSupport/ews-app/ews/urls.py:
1750
1751 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1752
1753         [ews-build] Configure buildbot to send events to ews-app
1754         https://bugs.webkit.org/show_bug.cgi?id=193968
1755
1756         Reviewed by Lucas Forschler.
1757
1758         * BuildSlaveSupport/ews-build/events.py: Added.
1759         * BuildSlaveSupport/ews-build/master.cfg:
1760
1761 2019-01-29  Keith Rollin  <krollin@apple.com>
1762
1763         Add .xcfilelists to Run Script build phases
1764         https://bugs.webkit.org/show_bug.cgi?id=193792
1765         <rdar://problem/47201785>
1766
1767         Reviewed by Alex Christensen.
1768
1769         As part of supporting XCBuild, update the necessary Run Script build
1770         phases in their Xcode projects to refer to their associated
1771         .xcfilelist files.
1772
1773         Note that the addition of these files bumps the Xcode project version
1774         number to something that's Xcode 10 compatible. This change means that
1775         older versions of the Xcode IDE can't read these projects. Nor can it
1776         fully load workspaces that refer to these projects (the updated
1777         projects are shown as non-expandable placeholders). `xcodebuild` can
1778         still build these projects; it's just that the IDE can't open them.
1779
1780         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1781         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1782
1783 2019-01-29  John Wilander  <wilander@apple.com>
1784
1785         Add data abstraction and validation for Ad Click Attribution
1786         https://bugs.webkit.org/show_bug.cgi?id=193916
1787         <rdar://problem/47603481>
1788
1789         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1790
1791         Ad click attribution has two steps. First, the storage of an ad
1792         campaign ID for a click that takes the user to a destination
1793         site. Second, a conversion on the destination site that can be
1794         attributed to the ad click.
1795
1796         This patch adds a class that represents a request for ad click
1797         attribution. Validation makes sure that the bits of entropy
1798         reported through this mechanism is limited.
1799
1800         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1801         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1802         (TestWebKitAPI::TEST):
1803
1804 2019-01-29  Chris Dumez  <cdumez@apple.com>
1805
1806         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1807         https://bugs.webkit.org/show_bug.cgi?id=193932
1808         <rdar://problem/47598947>
1809
1810         Reviewed by Brady Eidson.
1811
1812         Add API test coverage.
1813
1814         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1815
1816 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1817
1818         Adding new passing LFC tests.
1819
1820         Unreviewed test gardening.
1821
1822         * LayoutReloaded/misc/LFC-passing-tests.txt:
1823
1824 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1825
1826         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1827         https://bugs.webkit.org/show_bug.cgi?id=193964
1828
1829         Reviewed by Antti Koivisto.
1830
1831         * LayoutReloaded/misc/LFC-passing-tests.txt:
1832
1833 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1834
1835         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1836         https://bugs.webkit.org/show_bug.cgi?id=193954
1837
1838         Reviewed by Antti Koivisto.
1839
1840         * LayoutReloaded/misc/LFC-passing-tests.txt:
1841
1842 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1843
1844         WebDriver: add support for running subtests
1845         https://bugs.webkit.org/show_bug.cgi?id=193904
1846
1847         Reviewed by Michael Catanzaro.
1848
1849         pytest already supports it by passing test.py::subtest, so we can do the same.
1850
1851         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1852         (get_item_name): Made this global.
1853         (CollectRecorder.__init__): Receive the parameter to ignore.
1854         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1855         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1856         (collect): Add parameter to ignore.
1857         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1858         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1859         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1860         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1861         (WebDriverTestRunnerSelenium.run): Ditto.
1862         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1863         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1864         (WebDriverTestRunnerW3C.run): Ditto.
1865
1866 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1867
1868         User agent string override for navigator.userAgent should be site specific quirks
1869         https://bugs.webkit.org/show_bug.cgi?id=193950
1870
1871         Reviewed by Brent Fulgham.
1872
1873         Updated per the _WKWebsitePolicies rename.
1874
1875         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1876         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1877
1878 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1879
1880         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1881         https://bugs.webkit.org/show_bug.cgi?id=193941
1882
1883         Reviewed by Alex Christensen.
1884
1885         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1886         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1887         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1888         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1889         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1890         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1891         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1892         * TestWebKitAPI/Tests/WTF/Time.cpp:
1893         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1894         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1895         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1896         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1897
1898 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1899
1900         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1901
1902         * Scripts/webkitpy/common/config/contributors.json:
1903
1904 2019-01-28  Andy Estes  <aestes@apple.com>
1905
1906         [watchOS] Enable Parental Controls content filtering
1907         https://bugs.webkit.org/show_bug.cgi?id=193939
1908         <rdar://problem/46641912>
1909
1910         Reviewed by Ryosuke Niwa.
1911
1912         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1913
1914 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1915
1916         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1917         <https://webkit.org/b/193884>
1918
1919         Reviewed by Jiewen Tan.
1920
1921         * Scripts/webkitpy/style/checkers/cpp.py:
1922         (check_language): Add LocalAuthentication to
1923         `frameworks_with_soft_links`.
1924
1925 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1926
1927         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1928         https://bugs.webkit.org/show_bug.cgi?id=193891
1929
1930         Reviewed by Ross Kirsling.
1931
1932         There were three problems in window sizes of WebView and the host window.
1933         1. The sizes of pixel image output were incorrect.
1934         2. The host window is going to appear after window.resize was invoked.
1935         3. window.resize resized only the host window, not WebView.
1936
1937         This change solves them with a following approach.
1938         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1939         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1940            as well as DumpRenderTree in order to match the client area and the window area.
1941         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1942         d. PlatformWebView::setWindowFrame changes both window sizes.
1943         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1944
1945         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1946         (WTR::PlatformWebView::PlatformWebView): Create the host window
1947         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1948         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1949         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1950
1951 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1952
1953         [ews-app] Add method to save Step data to database
1954         https://bugs.webkit.org/show_bug.cgi?id=193890
1955
1956         Reviewed by Lucas Forschler.
1957
1958         * BuildSlaveSupport/ews-app/ews/models/step.py:
1959         (Step.save_step): Method to save step data.
1960         (Step.update_step): Method to update step data.
1961         (Step.get_existing_step): Method to fetch existing step from database.
1962         (Step.is_valid_result): Method to validate valid step result.
1963
1964 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1965
1966         [ews-app] Add method to save Build data to database
1967         https://bugs.webkit.org/show_bug.cgi?id=193735
1968
1969         Reviewed by Lucas Forschler.
1970
1971         * BuildSlaveSupport/ews-app/ews/models/build.py:
1972         (Build.save_build): Method to save build information to database.
1973         (Build.get_existing_build): Method to fetch existing build from database.
1974         (Build.is_valid_result): Method to validate build result.
1975         * BuildSlaveSupport/ews-app/ews/common/util.py:
1976         (is_valid_int_id): Method to validate valid id.
1977
1978 2019-01-28  Chris Dumez  <cdumez@apple.com>
1979
1980         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1981         https://bugs.webkit.org/show_bug.cgi?id=193915
1982         <rdar://problem/47560907>
1983
1984         Reviewed by Alex Christensen.
1985
1986         Add API test coverage.
1987
1988         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1989
1990 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1991
1992         [ews-app] Rename id variables
1993         https://bugs.webkit.org/show_bug.cgi?id=193883
1994
1995         Reviewed by Lucas Forschler.
1996
1997         * BuildSlaveSupport/ews-app/ews/models/build.py:
1998         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1999         * BuildSlaveSupport/ews-app/ews/models/step.py:
2000         * BuildSlaveSupport/ews-app/ews/urls.py:
2001         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2002         * BuildSlaveSupport/ews-app/ews/views/results.py:
2003         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2004
2005 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2006
2007         [ews-app] Allow certain fields to be empty
2008         https://bugs.webkit.org/show_bug.cgi?id=193892
2009
2010         Reviewed by Lucas Forschler.
2011
2012         * BuildSlaveSupport/ews-app/ews/models/build.py:
2013         * BuildSlaveSupport/ews-app/ews/models/step.py:
2014
2015 2019-01-28  Rob Buis  <rbuis@igalia.com>
2016
2017         Update MIME type parser
2018         https://bugs.webkit.org/show_bug.cgi?id=180526
2019
2020         Reviewed by Frédéric Wang.
2021
2022         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2023         (TestWebKitAPI::TEST):
2024
2025 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2026
2027         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2028         https://bugs.webkit.org/show_bug.cgi?id=193896
2029
2030         Reviewed by Antti Koivisto.
2031
2032         * LayoutReloaded/misc/LFC-passing-tests.txt:
2033
2034 2018-12-15  Darin Adler  <darin@apple.com>
2035
2036         Replace many uses of String::format with more type-safe alternatives
2037         https://bugs.webkit.org/show_bug.cgi?id=192742
2038
2039         Reviewed by Mark Lam.
2040
2041         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2042         (WTR::cacheTestRunnerCallback): Use makeString.
2043         * WebKitTestRunner/TestController.cpp:
2044         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2045         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2046
2047 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2048
2049         Use a load optimizer for some sites
2050         https://bugs.webkit.org/show_bug.cgi?id=193881
2051         <rdar://problem/46325455>
2052
2053         Reviewed by Brent Fulgham.
2054
2055         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2056         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2057
2058 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2059
2060         AX: Introduce a static accessibility tree
2061         https://bugs.webkit.org/show_bug.cgi?id=193348
2062         <rdar://problem/47203295>
2063
2064         Reviewed by Ryosuke Niwa.
2065
2066         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2067
2068 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2069
2070         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2071         https://bugs.webkit.org/show_bug.cgi?id=193867
2072
2073         Reviewed by Antti Koivisto.
2074
2075         * LayoutReloaded/misc/LFC-passing-tests.txt:
2076
2077 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2078
2079         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2080         https://bugs.webkit.org/show_bug.cgi?id=193865
2081
2082         Reviewed by Antti Koivisto.
2083
2084         * LayoutReloaded/misc/LFC-passing-tests.txt:
2085
2086 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2087
2088         Need a mechanism to override navigator.userAgent
2089         https://bugs.webkit.org/show_bug.cgi?id=193762
2090         <rdar://problem/47504939>
2091
2092         Reviewed by Brent Fulgham.
2093
2094         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2095
2096         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2097         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2098         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2099
2100 2019-01-25  Dean Jackson  <dino@apple.com>
2101
2102         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2103         https://bugs.webkit.org/show_bug.cgi?id=193831
2104         <rdar://problem/47399263>
2105
2106         Reviewed by Chris Dumez.
2107
2108         Two new tests that exercise cross-origin and same-origin System
2109         Previews.
2110
2111         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2112
2113 2019-01-25  Keith Rollin  <krollin@apple.com>
2114
2115         Update Xcode projects with "Check .xcfilelists" build phase
2116         https://bugs.webkit.org/show_bug.cgi?id=193790
2117         <rdar://problem/47201374>
2118
2119         Reviewed by Alex Christensen.
2120
2121         Support for XCBuild includes specifying inputs and outputs to various
2122         Run Script build phases. These inputs and outputs are specified as
2123         .xcfilelist files. Once created, these .xcfilelist files need to be
2124         kept up-to-date. In order to check that they are up-to-date or not,
2125         add an Xcode build step that invokes an external script that performs
2126         the checking. If the .xcfilelists are found to be out-of-date, update
2127         them, halt the build, and instruct the developer to restart the build
2128         with up-to-date files.
2129
2130         At this time, the checking and regenerating is performed only if the
2131         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2132         who want to use this facility can set this variable and test out the
2133         checking/regenerating. Once it seems like there are no egregious
2134         issues that upset a developer's workflow, we'll unconditionally enable
2135         this facility.
2136
2137         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2138         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2139         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2140         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2141
2142 2019-01-25  Keith Rollin  <krollin@apple.com>
2143
2144         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2145         https://bugs.webkit.org/show_bug.cgi?id=193781
2146         <rdar://problem/47201153>
2147
2148         Reviewed by Alex Christensen.
2149
2150         Part of generating the .xcfilelists used as part of adopting XCBuild
2151         includes running `make DerivedSources.make` from a standalone script.
2152         It’s important for this invocation to have the same environment as
2153         when the actual build invokes `make DerivedSources.make`. If the
2154         environments are different, then the two invocations will provide
2155         different results. In order to get the same environment in the
2156         standalone script, have the script launch xcodebuild targeting the
2157         "Apply Configuration to XCFileLists" build target, which will then
2158         re-invoke our standalone script. The script is now running again, this
2159         time in an environment with all workspace, project, target, xcconfig
2160         and other environment variables established.
2161
2162         The "Apply Configuration to XCFileLists" build target accomplishes
2163         this task via a small embedded shell script that consists only of:
2164
2165             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2166
2167         The process that invokes "Apply Configuration to XCFileLists" first
2168         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2169         evaluated and exports it into the shell environment. When xcodebuild
2170         is invoked, it inherits the value of this variable and can `eval` the
2171         contents of that variable. Our external standalone script can then set
2172         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2173         of command-line parameters needed to restart itself in the appropriate
2174         state.
2175
2176         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2177         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2178
2179 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2180
2181         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2182         https://bugs.webkit.org/show_bug.cgi?id=193802
2183         <rdar://problem/46010580>
2184
2185         Reviewed by Andy Estes.
2186
2187         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2188         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2189         (TEST):
2190
2191 2019-01-25  Daniel Bates  <dabates@apple.com>
2192
2193         [iOS] uiController.keyDown() does not translate Control modified key
2194         https://bugs.webkit.org/show_bug.cgi?id=192898
2195
2196         Reviewed by Wenson Hsieh.
2197
2198         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2199         key translation, as applicable. Among other cases, key translation occurs when performing
2200         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2201         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2202         human pressing down and releasing key(s) using a hardware keyboard.
2203
2204         * WebKitTestRunner/ios/HIDEventGenerator.h:
2205         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2206         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2207
2208         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2209         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2210         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2211         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2212         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2213         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2214         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2215         (-[HIDEventGenerator longPress:completionBlock:]):
2216         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2217         Update code for above renaming.
2218
2219         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2220         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2221
2222         (-[HIDEventGenerator keyDown:]): Added.
2223         (-[HIDEventGenerator keyUp:]): Added.
2224         (-[HIDEventGenerator keyPress:completionBlock:]):
2225         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2226         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2227         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2228         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2229         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2230         (WTR::parseModifier): Deleted.
2231
2232 2019-01-25  Keith Rollin  <krollin@apple.com>
2233
2234         Complete the implementation of generate-xcfilelists
2235         https://bugs.webkit.org/show_bug.cgi?id=193782
2236
2237         Reviewed by Alex Christensen.
2238
2239         A preliminary version of generate-xcfilelists was added in r238008.
2240         This patch updates that script in order to:
2241
2242         - Support checking of .xcfilelists
2243         - Perform better execution of `make DerivedSources.make` by
2244           relaunching generate-xcfilelists under xcodebuild
2245         - Support incremental generation and checking of .xcfilelists
2246         - Support supplementary .xcfilelists files from WebKitAdditions
2247         - Support being wrapped by parallel version of generate-xcfilelists in
2248           Internal that adds support for (re)generating WebKit projects in
2249           that repo.
2250         - Support builds that have been performed in WebKitBuild as well as
2251           ~/Library/Developer/code/DerivedData
2252         - Increase robustness and debugging facilities.
2253
2254         * Scripts/generate-xcfilelists:
2255
2256 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2257
2258         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2259         https://bugs.webkit.org/show_bug.cgi?id=193297
2260         <rdar://problem/47158841>
2261
2262         Unreviewed test case fix.
2263
2264         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2265         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2266
2267         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2268         (TEST):
2269
2270 2019-01-25  Keith Rollin  <krollin@apple.com>
2271
2272         Update existing .xcfilelists
2273         https://bugs.webkit.org/show_bug.cgi?id=193791
2274         <rdar://problem/47201706>
2275
2276         Reviewed by Alex Christensen.
2277
2278         Many .xcfilelist files were added in r238824 in order to support
2279         XCBuild. Update these with recent changes to the set of build files
2280         and with the current generate-xcfilelist script.
2281
2282         * DumpRenderTree/DerivedSources-input.xcfilelist:
2283         * DumpRenderTree/DerivedSources-output.xcfilelist:
2284         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2285         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2286
2287 2019-01-25  Keith Rollin  <krollin@apple.com>
2288
2289         Fix missing dependencies in extract-dependencies-from-makefile
2290         https://bugs.webkit.org/show_bug.cgi?id=193783
2291         <rdar://problem/47201571>
2292
2293         Reviewed by Alex Christensen.
2294
2295         The extract-dependencies-from-makefile script generates .xcfilelists
2296         for XCBuild by invoking a makefile in --debug mode, parsing the
2297         dependency information in the output, and extracting information
2298         regarding targets and dependents. However, the way `make` emits this
2299         dependency information is not rigorous, and so we need to determine
2300         what lines to look for and parse by trial and error. This approach
2301         didn't coriginally atch all the information we needed to collect, so
2302         update the script to look for the additional lines we now know to look
2303         for.
2304
2305         * Scripts/extract-dependencies-from-makefile:
2306         (Parser):
2307         (Parser.addTarget):
2308         (Parser.addPrereq):
2309         (Parser.doParse):
2310
2311 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2312
2313         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2314         https://bugs.webkit.org/show_bug.cgi?id=193297
2315         <rdar://problem/47158841>
2316
2317         Reviewed by Alex Christensen.
2318
2319         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2320             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2321         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2322         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2323         activating the message used to trigger the callback when it is set.
2324
2325 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2326
2327         WKWebView.goBack should reload if there is a safe browsing warning
2328         https://bugs.webkit.org/show_bug.cgi?id=193805
2329         <rdar://problem/46908216>
2330
2331         Reviewed by Geoff Garen.
2332
2333         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2334         (+[Simple3LookupContext sharedLookupContext]):
2335         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2336         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2337         (TEST):
2338
2339 2019-01-25  Chris Dumez  <cdumez@apple.com>
2340
2341         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2342         https://bugs.webkit.org/show_bug.cgi?id=193788
2343         <rdar://problem/47531231>
2344
2345         Reviewed by Alex Christensen.
2346
2347         Add API test coverage.
2348
2349         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2350         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2351
2352 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2353
2354         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2355         https://bugs.webkit.org/show_bug.cgi?id=193771
2356
2357         Unreviewed infrastructure fix.
2358
2359         * Scripts/webkitpy/port/darwin.py:
2360         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2361
2362 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2363
2364         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2365
2366 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2367
2368         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2369
2370         * Scripts/webkitpy/common/config/contributors.json:
2371
2372 2019-01-25  Chris Dumez  <cdumez@apple.com>
2373
2374         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2375         https://bugs.webkit.org/show_bug.cgi?id=193779
2376         <rdar://problem/46170903>
2377
2378         Reviewed by Antti Koivisto.
2379
2380         Add API test that quickly navigates forward to a previous process without waiting for it to
2381         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2382         the process' previous page when reconnecting the it for the forward navigation.
2383
2384         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2385
2386 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2387
2388         Need a way for JavaScript (or bundle) code to participate in undo
2389         https://bugs.webkit.org/show_bug.cgi?id=190009
2390         <rdar://problem/44807048>
2391
2392         Reviewed by Ryosuke Niwa.
2393
2394         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2395         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2396
2397         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2398         (WTR::UIScriptController::lastUndoLabel const):
2399         (WTR::UIScriptController::firstRedoLabel const):
2400         (WTR::UIScriptController::platformUndoManager const):
2401         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2402         (WTR::UIScriptController::lastUndoLabel const):
2403         (WTR::UIScriptController::firstRedoLabel const):
2404         (WTR::UIScriptController::platformUndoManager const):
2405         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2406         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2407         (WTR::UIScriptController::lastUndoLabel const):
2408         (WTR::UIScriptController::firstRedoLabel const):
2409         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2410         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2411         (WTR::UIScriptController::lastUndoLabel const):
2412         (WTR::UIScriptController::firstRedoLabel const):
2413         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2414         (WTR::UIScriptController::platformUndoManager const):
2415         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2416         (WTR::UIScriptController::platformUndoManager const):
2417
2418 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2419
2420         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2421         https://bugs.webkit.org/show_bug.cgi?id=193824
2422
2423         Reviewed by Antti Koivisto.
2424
2425         * LayoutReloaded/misc/LFC-passing-tests.txt:
2426
2427 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2428
2429         Update macOS JSC bot configurations
2430         https://bugs.webkit.org/show_bug.cgi?id=193739
2431
2432         Reviewed by Alexey Proskuryakov.
2433
2434         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2436         (BubbleQueueServer): Move JSC EWS to Mojave section.
2437         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2438         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2439         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2440
2441 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2442
2443         [Win][WebKitTestRunner] Implement EventSenderProxy
2444         https://bugs.webkit.org/show_bug.cgi?id=193755
2445
2446         Reviewed by Don Olmstead.
2447
2448         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2449         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2450         (WTR::EventSenderProxy::dispatchMessage):
2451         (WTR::EventSenderProxy::EventSenderProxy):
2452         (WTR::EventSenderProxy::mouseDown):
2453         (WTR::EventSenderProxy::mouseUp):
2454         (WTR::EventSenderProxy::mouseMoveTo):
2455         (WTR::EventSenderProxy::mouseScrollBy):
2456         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2457
2458 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2459
2460         Unreviewed fix for API test failure after r240437.
2461
2462         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2463
2464         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2465
2466 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2467
2468         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2469         https://bugs.webkit.org/show_bug.cgi?id=193787
2470         <rdar://problem/47497634>
2471
2472         Reviewed by Alexey Proskuryakov.
2473
2474         * Scripts/webkitdirs.pm:
2475         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2476
2477 2019-01-24  Truitt Savell  <tsavell@apple.com>
2478
2479         Unreviewed, rolling out r240446.
2480
2481         Casued 5 API failures
2482
2483         Reverted changeset:
2484
2485         "Activate the WebResourceLoadStatisticsStore in the
2486         NetworkProcess and deactivate it in the UIProcess."
2487         https://bugs.webkit.org/show_bug.cgi?id=193297
2488         https://trac.webkit.org/changeset/240446
2489
2490 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2491
2492         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2493         https://bugs.webkit.org/show_bug.cgi?id=193741
2494         <rdar://problem/47135030>
2495
2496         Reviewed by Antti Koivisto and Simon Fraser.
2497
2498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2499         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2500         (TestWebKitAPI::TEST):
2501
2502 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2503
2504         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2505         https://bugs.webkit.org/show_bug.cgi?id=193297
2506         <rdar://problem/47158841>
2507
2508         Reviewed by Alex Christensen.
2509
2510         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2511         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2512         activating the message used to trigger the callback when it is set.
2513
2514 2019-01-24  John Wilander  <wilander@apple.com>
2515
2516         Add Ad Click Attribution as an internal/experimental feature
2517         https://bugs.webkit.org/show_bug.cgi?id=193685
2518         <rdar://problem/47450399>
2519
2520         Reviewed by Brent Fulgham.
2521
2522         Added test option adClickAttributionEnabled.
2523
2524         * DumpRenderTree/TestOptions.cpp:
2525         (TestOptions::TestOptions):
2526         * DumpRenderTree/TestOptions.h:
2527         * DumpRenderTree/mac/DumpRenderTree.mm:
2528         (setWebPreferencesForTestOptions):
2529
2530 2019-01-24  Antti Koivisto  <antti@apple.com>
2531
2532         [PSON] Flash on back navigation on Mac
2533         https://bugs.webkit.org/show_bug.cgi?id=193716
2534         <rdar://problem/47148458>
2535
2536         Reviewed by Chris Dumez.
2537
2538         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2539
2540         Closing of the previous page is delayed so waiting for didFinishNavigation is
2541         not sufficient to guarantee we have received all the messages. Wait for them.
2542
2543 2019-01-24  Chris Dumez  <cdumez@apple.com>
2544
2545         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2546         https://bugs.webkit.org/show_bug.cgi?id=193761
2547         <rdar://problem/47456405>
2548
2549         Reviewed by Alex Christensen.
2550
2551         Add API test coverage.
2552
2553         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2554
2555 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2556
2557         webkitpy: Missing PID in crashlog name should not be fatal
2558         https://bugs.webkit.org/show_bug.cgi?id=193771
2559
2560         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2561         of raising an exception.
2562
2563         Reviewed by Lucas Forschler.
2564
2565         * Scripts/webkitpy/port/darwin.py:
2566         (DarwinPort._merge_crash_logs):
2567
2568 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2569
2570         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2571         https://bugs.webkit.org/show_bug.cgi?id=193746
2572
2573         Reviewed by Youenn Fablet.
2574
2575         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2576         so we'd best just not call it.
2577
2578         * Scripts/webkitpy/w3c/test_exporter.py:
2579         (WebPlatformTestExporter.create_branch_with_patch):
2580
2581 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2582
2583         Move FileSystem to WTF
2584         https://bugs.webkit.org/show_bug.cgi?id=193602
2585
2586         Reviewed by Yusuke Suzuki.
2587
2588         * DumpRenderTree/win/DumpRenderTree.cpp:
2589         * TestWebKitAPI/CMakeLists.txt:
2590         * TestWebKitAPI/PlatformGTK.cmake:
2591         * TestWebKitAPI/PlatformJSCOnly.cmake:
2592         * TestWebKitAPI/PlatformPlayStation.cmake:
2593         * TestWebKitAPI/PlatformWPE.cmake:
2594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2595         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2596         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2597         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2598         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2599         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2600         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2601         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2602         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2603         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2604
2605 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2606
2607         [WPE] Remove hard dependency on subprocess32 for the API tests
2608
2609         Rubber-stamped by Carlos Garcia Campos.
2610
2611         * glib/api_test_runner.py:
2612         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2613         its presence only when running WPEQt tests.
2614
2615 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2616
2617         [GLIB] Expose JavaScriptCore options in GLib public API
2618         https://bugs.webkit.org/show_bug.cgi?id=188742
2619
2620         Reviewed by Michael Catanzaro.
2621
2622         Add a test for the new API.
2623
2624         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2625         (testsJSCOptions):
2626         (main):
2627
2628 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2629
2630         [GTK][WPE] Support JPEG 2000 images
2631         https://bugs.webkit.org/show_bug.cgi?id=186272
2632
2633         Reviewed by Žan Doberšek.
2634
2635         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2636
2637         * gtk/jhbuild.modules:
2638         * wpe/jhbuild.modules:
2639
2640 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2641
2642         check-webkit-style should warn when using soft-linking macros in a header
2643         <https://webkit.org/b/193750>
2644
2645         Reviewed by Darin Adler.
2646
2647         * Scripts/webkitpy/style/checkers/cpp.py:
2648         (check_language): Add softlink/header check by refactoring the
2649         softlink/framework check.
2650         (CppChecker): Enable softlink/header check by default.
2651         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2652         (CppStyleTest.test_softlink_framework): Rename from
2653         CppStyleTest.test_softlink() and change test framework name in
2654         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2655         files. Set file_name for macros that only appear in headers.
2656         (CppStyleTest.test_softlink_header): Add tests for using
2657         soft-link macros in headers.
2658
2659 2019-01-23  Chris Dumez  <cdumez@apple.com>
2660
2661         Deprecate API to limit the maximum number of WebProcesses
2662         https://bugs.webkit.org/show_bug.cgi?id=193725
2663         <rdar://problem/47464879>
2664
2665         Reviewed by Geoff Garen.
2666
2667         Update existing API tests to stop using deprecated API.
2668
2669         * MiniBrowser/mac/AppDelegate.m:
2670         (defaultConfiguration):
2671         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2672         (TestWebKitAPI::TEST):
2673         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2674         (TestWebKitAPI::TEST):
2675         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2676         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2677         (TEST):
2678         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2679         (TEST):
2680
2681 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2682
2683         [ews-app] Rename ews model buildermappings to buildermapping
2684         https://bugs.webkit.org/show_bug.cgi?id=193729
2685
2686         Reviewed by Lucas Forschler.
2687
2688         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2689         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2690         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2691
2692 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2693
2694         [ews-app] Rename ews model steps to step
2695         https://bugs.webkit.org/show_bug.cgi?id=193697
2696
2697         Reviewed by Lucas Forschler.
2698
2699         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2700         (Step): Renamed Steps to Step.
2701
2702 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2703
2704         Clean up IndexedDB files between tests
2705         https://bugs.webkit.org/show_bug.cgi?id=192796
2706         <rdar://problem/46824999>
2707
2708         Reviewed by Geoffrey Garen.
2709
2710         * DumpRenderTree/mac/DumpRenderTree.mm:
2711         (runTest):
2712         * WebKitTestRunner/TestController.cpp:
2713         (WTR::TestController::resetStateToConsistentValues):
2714         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2715         (WTR::RemoveAllIndexedDatabasesCallback):
2716         (WTR::TestController::ClearIndexedDatabases):
2717         * WebKitTestRunner/TestController.h:
2718         * WebKitTestRunner/TestInvocation.cpp:
2719         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2720
2721 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2722
2723         [ews-app] Rename ews model Builds to Build
2724         https://bugs.webkit.org/show_bug.cgi?id=193695
2725
2726         Reviewed by Lucas Forschler.
2727
2728         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2729         (Build): Renamed Builds to Build.
2730
2731 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2732
2733         webkitpy: Wait longer when launching WebKitTestRunner
2734         https://bugs.webkit.org/show_bug.cgi?id=193734
2735
2736         Reviewed by Aakash Jain.
2737
2738         * Scripts/webkitpy/port/simulator_process.py:
2739         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2740
2741 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2742
2743         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2744         https://bugs.webkit.org/show_bug.cgi?id=193182
2745         <rdar://problem/47452154>
2746
2747         Reviewed by Tim Horton.
2748
2749         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2750         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2751         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2752
2753         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2754         preventing later tests from recognizing gestures.
2755
2756         * WebKitTestRunner/ios/TestControllerIOS.mm:
2757         (WTR::TestController::platformResetStateToConsistentValues):
2758
2759         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2760
2761 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2762
2763         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2764         https://bugs.webkit.org/show_bug.cgi?id=193722
2765         <rdar://problem/47481475>
2766
2767         Reviewed by Lucas Forschler.
2768
2769         iPhone and iPad ports should both use the iOS config.
2770
2771         * Scripts/webkitpy/port/ios_simulator.py:
2772         (IPhoneSimulatorPort.__init__):
2773         (IPadSimulatorPort.__init__):
2774
2775 2019-01-23  Rob Buis  <rbuis@igalia.com>
2776
2777         Update MIME type parser
2778         https://bugs.webkit.org/show_bug.cgi?id=180526
2779
2780         Reviewed by Frédéric Wang.
2781
2782         Add unit tests for both parse modes of ParsedContentType.
2783
2784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2785         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2786         (TestWebKitAPI::TEST):
2787
2788 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2789
2790         [ews-app] fetch loop should not stop on network issues
2791         https://bugs.webkit.org/show_bug.cgi?id=193666
2792
2793         Reviewed by Lucas Forschler.
2794
2795         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2796         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2797
2798 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2799
2800         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2801         https://bugs.webkit.org/show_bug.cgi?id=189165
2802         <rdar://problem/47433765>
2803
2804         Reviewed by Tim Horton.
2805
2806         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2807         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2808         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2809         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2810         would make its way to the UI process by the time the layer tree commit is finished.
2811
2812         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2813         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2814         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2815         will fail because it asks for -_autofillContext too early.
2816
2817         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2818         is handled in the UI process.
2819
2820         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2821
2822         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2823         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2824         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2825         input session.
2826
2827         (-[AutofillTestView textInputHasAutofillContext]):
2828
2829         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2830
2831         * TestWebKitAPI/cocoa/TestWKWebView.h:
2832         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2833         (nextInputSessionChangeCount):
2834
2835         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2836         This includes changing the focused element from one to another.
2837
2838         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2839         (-[TestWKWebView didStartFormControlInteraction]):
2840         (-[TestWKWebView didEndFormControlInteraction]):
2841         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2842
2843         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2844         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2845         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2846         that doesn't require an input session to one that doesn't.
2847
2848 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2849
2850         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2851         <https://webkit.org/b/193676>
2852
2853         Reviewed by Alexey Proskuryakov.
2854
2855         * Scripts/webkitpy/style/checkers/cpp.py:
2856         (check_member_initialization_list):
2857         - Don't report missing whitespace around colon if the colon at
2858           the start of the line is formatted correctly.
2859         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2860         (WebKitStyleTest.test_member_initialization_list):
2861         - Add a test for a missing permutation of existing tests.
2862         - Add a test this false-positive.
2863         - Add blank lines between subtests to make them easier to read.
2864
2865 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2866
2867         [build.webkit.org] Unit-test failure after r237113
2868         https://bugs.webkit.org/show_bug.cgi?id=193669
2869
2870         Reviewed by Michael Catanzaro.
2871
2872         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2873         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2874         multiple or zero flags.
2875
2876 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2877
2878         Cache bytecode to disk
2879         https://bugs.webkit.org/show_bug.cgi?id=192782
2880         <rdar://problem/46084932>
2881
2882         Reviewed by Keith Miller.
2883
2884         Add test helper to execute bytecode-cache tests: it executes each test
2885         twice, the first with JSC_diskCachePath set to a temporary directory
2886         and second with JSC_forceDiskCache=true (in addition to the cache path)
2887         to guarantee that only the disk cache is being used and no new
2888         UnlinkedCodeBlocks are being created.
2889
2890         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2891         * Scripts/run-jsc-stress-tests:
2892
2893 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2894
2895         [css-logical] Implement flow-relative margin, padding and border shorthands
2896         https://bugs.webkit.org/show_bug.cgi?id=188697
2897
2898         Reviewed by Simon Fraser and Antti Koivisto.
2899
2900         * DumpRenderTree/TestOptions.cpp:
2901         (TestOptions::TestOptions):
2902         * DumpRenderTree/TestOptions.h:
2903         * DumpRenderTree/mac/DumpRenderTree.mm:
2904         (setWebPreferencesForTestOptions):
2905         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2906
2907         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2908         (JSONCSSPropertiesChecker.check_codegen_properties):
2909         Allow CSS property definitions to have a 'runtime-flag' parameter which
2910         disables the property when the specified runtime flag is disabled.
2911
2912 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2913
2914         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2915         https://bugs.webkit.org/show_bug.cgi?id=193643
2916
2917         Reviewed by Michael Catanzaro.
2918
2919         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2920         * wpe/jhbuild.modules: Ditto.
2921
2922 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2923
2924         [LFC][Floats] Take float top position into account when computing containing block height.
2925         https://bugs.webkit.org/show_bug.cgi?id=193655
2926
2927         Reviewed by Antti Koivisto.
2928
2929         * LayoutReloaded/misc/LFC-passing-tests.txt:
2930
2931 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2932
2933         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2934         <https://webkit.org/b/193645>
2935         <rdar://problem/47421574>
2936
2937         Reviewed by Alex Christensen.
2938
2939         - Now checks for local soft-linking of all frameworks that have
2940           their own *SoftLinking.{cpp,h,mm} files.
2941         - Changes softlink/uikit warning to softlink/framework.
2942
2943         * Scripts/webkitpy/style/checkers/cpp.py:
2944         (check_language):
2945         (CppChecker):
2946         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2947         (CppStyleTest):
2948
2949 2019-01-20  Saam Barati  <sbarati@apple.com>
2950
2951         Rollout r240210: It broke tests on iOS
2952         https://bugs.webkit.org/show_bug.cgi?id=193640
2953
2954         Unreviewed.
2955
2956         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2957         * Scripts/run-jsc-stress-tests:
2958
2959 2019-01-20  chris fleizach  <cfleizach@apple.com>
2960
2961         AX: Support returning relative frames for accessibility
2962         https://bugs.webkit.org/show_bug.cgi?id=193414
2963         <rdar://problem/47268501>
2964
2965         Reviewed by Zalan Bujtas.
2966
2967         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2968         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2969         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2970         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2971         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2972         (WTR::attributesOfElement):
2973         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2974
2975 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2976
2977         Unreviewed, add my new email address
2978
2979         * Scripts/webkitpy/common/config/contributors.json:
2980
2981 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2982
2983         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2984         https://bugs.webkit.org/show_bug.cgi?id=193617
2985
2986         Reviewed by Antti Koivisto.
2987
2988         * LayoutReloaded/misc/LFC-passing-tests.txt:
2989
2990 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2991
2992         Unreviewed, rolling out r240209.
2993
2994         Broke GTK/WPE injected bundle
2995
2996         Reverted changeset:
2997
2998         "AX: Support returning relative frames for accessibility"
2999         https://bugs.webkit.org/show_bug.cgi?id=193414
3000         https://trac.webkit.org/changeset/240209
3001
3002 2019-01-12  Dan Bernstein  <mitz@apple.com>
3003
3004         [Cocoa] Avoid importing directly from subumbrella frameworks
3005         https://bugs.webkit.org/show_bug.cgi?id=186016
3006         <rdar://problem/40591038>
3007
3008         Reviewed by Sam Weinig.
3009
3010         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3011           LaunchServices header.
3012         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3013           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3014         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3015           when using SDKs earlier than 10.13.
3016         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3017           and OTHER_CPLUSPLUSFLAGS.
3018         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3019           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3020         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3021           LaunchServices header.
3022
3023 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3024
3025         Cache bytecode to disk
3026         https://bugs.webkit.org/show_bug.cgi?id=192782
3027         <rdar://problem/46084932>
3028
3029         Reviewed by Keith Miller.
3030
3031         Add test helper to execute bytecode-cache tests: it executes each test
3032         twice, the first with JSC_diskCachePath set to a temporary directory
3033         and second with JSC_forceDiskCache=true (in addition to the cache path)
3034         to guarantee that only the disk cache is being used and no new
3035         UnlinkedCodeBlocks are being created.
3036
3037         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3038         * Scripts/run-jsc-stress-tests:
3039
3040 2019-01-20  chris fleizach  <cfleizach@apple.com>
3041
3042         AX: Support returning relative frames for accessibility
3043         https://bugs.webkit.org/show_bug.cgi?id=193414
3044         <rdar://problem/47268501>
3045
3046         Reviewed by Zalan Bujtas.
3047
3048         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3049         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3050         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3051         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3052         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3053         (WTR::attributesOfElement):
3054         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3055
3056 2019-01-20  Antoine Quint  <graouts@apple.com>
3057
3058         Add a POINTER_EVENTS feature flag
3059         https://bugs.webkit.org/show_bug.cgi?id=193577
3060         <rdar://problem/47408511>
3061
3062         Unreviewed. Also enable Pointer Events for iosmac.
3063
3064         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3065
3066 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3067
3068         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3069         https://bugs.webkit.org/show_bug.cgi?id=193613
3070
3071         Reviewed by Antti Koivisto.
3072
3073         * LayoutReloaded/misc/LFC-passing-tests.txt:
3074
3075 2019-01-19  Antoine Quint  <graouts@apple.com>
3076
3077         Add a POINTER_EVENTS feature flag
3078         https://bugs.webkit.org/show_bug.cgi?id=193577
3079
3080         Reviewed by Dean Jackson.
3081
3082         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3083
3084 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3085
3086         Disable the run-jsc-stress-test remote host key check [second round].
3087         https://bugs.webkit.org/show_bug.cgi?id=192988
3088
3089         Reviewed by Dewei Zhu.
3090
3091         * Scripts/run-jsc-stress-tests:
3092
3093 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3094
3095         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3096         https://bugs.webkit.org/show_bug.cgi?id=193597
3097
3098         Reviewed by Lucas Forschler.
3099
3100         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3101
3102 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3103
3104         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3105         https://bugs.webkit.org/show_bug.cgi?id=193595
3106
3107         Reviewed by Lucas Forschler.
3108
3109         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3110         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3111         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3112
3113 2019-01-18  Chris Dumez  <cdumez@apple.com>
3114
3115         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3116         https://bugs.webkit.org/show_bug.cgi?id=193588
3117         <rdar://problem/47131566>
3118
3119         Reviewed by Alex Christensen.
3120
3121         Add layout test coverage.
3122
3123         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3124
3125 2019-01-18  Jer Noble  <jer.noble@apple.com>
3126
3127         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3128         https://bugs.webkit.org/show_bug.cgi?id=189553
3129
3130         Reviewed by Tim Horton.
3131
3132         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3133
3134         * ContentExtensionTester/Configurations/Base.xcconfig:
3135         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3136         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3137         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3138         * ImageDiff/cg/Configurations/Base.xcconfig:
3139         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3140         * MiniBrowser/Configurations/Base.xcconfig:
3141         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3142         * MobileMiniBrowser/Configurations/Base.xcconfig:
3143         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3144         * Scripts/webkitpy/style/checker.py:
3145         (_all_categories):
3146         (FileType):
3147         (CheckerDispatcher._file_type):
3148         (CheckerDispatcher._create_checker):
3149         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3150         (SDKVariantChecker):
3151         (SDKVariantChecker.__init__):
3152         (SDKVariantChecker.check):
3153         * TestWebKitAPI/Configurations/Base.xcconfig:
3154         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3155         * WebEditingTester/Configurations/Base.xcconfig:
3156         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3157         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3158         * WebKitTestRunner/Configurations/Base.xcconfig:
3159         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3160         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3161         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3162
3163 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3164
3165         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3166         <https://webkit.org/b/193568>
3167         <rdar://problem/47381130>
3168
3169         Reviewed by Alex Christensen.
3170
3171         Make sure no one re-introduces UIKit soft-linking by adding a
3172         style rule.
3173
3174         * Scripts/webkitpy/style/checkers/cpp.py:
3175         (check_language): Add softlink/uikit check.
3176         (CppChecker): Enable softlink/uikit check.
3177         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3178         (CppStyleTest): Add test for softlink/uikit.
3179
3180 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3181
3182         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3183         https://bugs.webkit.org/show_bug.cgi?id=193584
3184
3185         Change "-dev" to "-devel".
3186
3187         Reviewed by Michael Catanzaro.
3188
3189         * gtk/install-dependencies:
3190
3191 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3192
3193         webkitpy: Add iPhone and iPad ports
3194         https://bugs.webkit.org/show_bug.cgi?id=193537
3195         <rdar://problem/47353390>
3196
3197         Reviewed by Lucas Forschler.
3198
3199         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3200         ports. Note that this separation is optional, the --ios-simulator command remains.
3201
3202         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3203         (RunTest.test_device_type_test_division): Drive-by fix.
3204         (RunTest.test_device_type_specific_listing): Ditto.
3205         (RunTest.test_ipad_test_division):
3206         (RunTest):
3207         (RunTest.test_ipad_listing):
3208         * Scripts/webkitpy/port/factory.py:
3209         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3210         (PortFactory):
3211         * Scripts/webkitpy/port/ios_simulator.py:
3212         (IPhoneSimulatorPort):
3213         (IPadSimulatorPort):
3214
3215 2019-01-18  Chris Dumez  <cdumez@apple.com>
3216
3217         Regression(PSON) Scroll position is not always restored properly when navigating back
3218         https://bugs.webkit.org/show_bug.cgi?id=193578
3219         <rdar://problem/47386331>
3220
3221         Reviewed by Tim Horton.
3222
3223         Add API test coverage.
3224
3225         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3226
3227 2019-01-18  Youenn Fablet  <youenn@apple.com>
3228
3229         Add a new SPI to request for cache storage quota increase
3230         https://bugs.webkit.org/show_bug.cgi?id=193323
3231
3232         Reviewed by Alex Christensen.
3233
3234         Implement WebsiteDataStore quota delegate to handle quota requests.
3235         By default, do not update quota.
3236         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3237
3238         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3239         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3240         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3241         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3242         * WebKitTestRunner/TestController.cpp:
3243         (WTR::TestController::allowCacheStorageQuotaIncrease):
3244         * WebKitTestRunner/TestController.h:
3245         * WebKitTestRunner/TestInvocation.cpp:
3246         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3247         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3248         (-[CacheStorageQuotaManager init]):
3249         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3250         (WTR::initializeWebViewConfiguration):
3251         (WTR::TestController::cocoaResetStateToConsistentValues):
3252         (WTR::TestController::allowCacheStorageQuotaIncrease):
3253
3254 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3255
3256         [ews-build] Pass owner to the triggered builds
3257         https://bugs.webkit.org/show_bug.cgi?id=193574
3258
3259         Reviewed by Lucas Forschler.
3260
3261         * BuildSlaveSupport/ews-build/factories.py:
3262         (BuildFactory.propertiesToPassToTriggers):
3263
3264 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3265
3266         [ews-app] Send patch author as a build property
3267         https://bugs.webkit.org/show_bug.cgi?id=193560
3268
3269         Reviewed by Lucas Forschler.
3270
3271         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3272         (BugzillaPatchFetcher.fetch):
3273
3274 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3275
3276         webkitpy: Implement device type specific expected results (Follow-up fix)
3277         https://bugs.webkit.org/show_bug.cgi?id=192162
3278         <rdar://problem/46345449>
3279
3280         Unreviewed infrastructure fix.
3281
3282         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3283         (Manager.run): Don't boot a device if no tests are available to run on it.
3284
3285 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3286
3287         webkitpy: Implement device type specific expected results (Follow-up fix)
3288         https://bugs.webkit.org/show_bug.cgi?id=192162
3289         <rdar://problem/46345449>
3290
3291         Unreviewed infrastructure fix.
3292
3293         * Scripts/webkitpy/api_tests/manager.py:
3294         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3295
3296 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3297
3298         webkitpy: Implement device type specific expected results (Part 2)
3299         https://bugs.webkit.org/show_bug.cgi?id=192162
3300         <rdar://problem/46345449>
3301
3302         Rubber-stamped by Aakash Jain.
3303
3304         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3305         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3306         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3307
3308         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3309         (LayoutTestFinder.find_tests): Pass device_type through.
3310         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3311         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3312         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3313         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3314         (Manager._collect_tests): Pass device type to test finder.
3315         (Manager._needs_web_platform_test):
3316         (Manager._prepare_lists): Index _expectations by device type.
3317         (Manager._test_input_for_file):
3318         (Manager._test_is_slow): Ditto.
3319         (Manager._test_should_dump_jsconsolelog_in_stderr):
3320         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3321         (Manager._get_test_inputs):
3322         (Manager._update_worker_count):
3323         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3324         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3325         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3326         the one which runs the test.
3327         (Manager._run_test_subset):
3328         (Manager._run_tests): Index _expectations by current_device_type.
3329         (Manager._print_expectation_line_for_test): Ditto.
3330         (Manager._print_expectations_for_subset): Ditto.
3331         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3332         Unlike run, this function will behave the same regardless of what devices are available.
3333         (Manager._custom_device_for_test): Deleted.
3334         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3335         (ManagerTest.test_uses_custom_device): Deleted.
3336         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3337         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3338         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3339         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3340         all of the expectations.
3341         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3342         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3343         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3344         (TestExpectations.__init__): Allow device_type to be passed through.
3345         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3346         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3347         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3348         (summarize_results):
3349         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3350         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3351         a test ran with, one must check all expectations to find the first non-skip expectation.
3352         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3353         (RunTest.test_device_type_test_division):
3354         (RunTest):
3355         (RunTest.test_device_type_specific_listing):
3356         * Scripts/webkitpy/port/base.py:
3357         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3358         (Port.supported_device_types): The result of this function will change based on what devices are available.
3359         * Scripts/webkitpy/port/device_port.py:
3360         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3361         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3362         can be used.
3363         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3364         any, or the DEFAULT_DEVICE_TYPES of the port.
3365         * Scripts/webkitpy/port/ios.py:
3366         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3367         * Scripts/webkitpy/port/ios_simulator.py:
3368         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3369         * Scripts/webkitpy/port/watch.py:
3370         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3371         * Scripts/webkitpy/port/watch_simulator.py:
3372         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3373         * Scripts/webkitpy/xcode/device_type.py:
3374         (DeviceType):
3375         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3376
3377 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3378
3379         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3380         https://bugs.webkit.org/show_bug.cgi?id=193575
3381
3382         Reviewed by Michael Catanzaro.
3383
3384         Allow the script to run without explicit port argument because
3385         it's specific to the WPE port anyway.
3386
3387         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3388         and simplify the rest of the code accordingly.
3389
3390 2019-01-18  Charlie Turner  <cturner@igalia.com>
3391
3392         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3393         https://bugs.webkit.org/show_bug.cgi?id=192229
3394
3395         Reviewed by Xabier Rodriguez-Calvar.
3396
3397         * MiniBrowser/wpe/main.cpp:
3398         (main): Enable encrypted-media by default.
3399
3400 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3401
3402         [Flatpak] Missing KeyboardInterrupt exception handler
3403         https://bugs.webkit.org/show_bug.cgi?id=193570
3404
3405         Reviewed by Michael Catanzaro.
3406
3407         * flatpak/flatpakutils.py:
3408         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3409
3410 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3411
3412         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3413         https://bugs.webkit.org/show_bug.cgi?id=193564
3414
3415         Reviewed by Antti Koivisto.
3416
3417         * LayoutReloaded/misc/LFC-passing-tests.txt:
3418
3419 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3420
3421         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3422         https://bugs.webkit.org/show_bug.cgi?id=193562
3423
3424         Reviewed by Antti Koivisto.
3425
3426         * LayoutReloaded/misc/LFC-passing-tests.txt:
3427
3428 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3429
3430         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3431         https://bugs.webkit.org/show_bug.cgi?id=193555
3432
3433         Reviewed by Antti Koivisto.
3434
3435         * LayoutReloaded/misc/LFC-passing-tests.txt:
3436
3437 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3438
3439         [WPE] Add Qt extension
3440         https://bugs.webkit.org/show_bug.cgi?id=191464
3441
3442         Reviewed by Carlos Garcia Campos.
3443
3444         MiniBrowser and API tests for the WPE Qt API. To run the
3445         MiniBrowser a new script is introduced. Example invocation:
3446
3447         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3448
3449         Also note-worthy is the introduction of the python2-subprocess32
3450         dependency to run the GLib API tests.
3451
3452         * MiniBrowser/wpe/CMakeLists.txt:
3453         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3454         * MiniBrowser/wpe/qt/main.cpp: Added.
3455         (main):
3456         * MiniBrowser/wpe/qt/main.qml: Added.
3457         * MiniBrowser/wpe/qt/qml.qrc: Added.
3458         * Scripts/run-gtk-tests:
3459         (GtkTestRunner.is_google_test):
3460         (GtkTestRunner):
3461         (GtkTestRunner.is_qt_test):
3462         * Scripts/run-qt-wpe-minibrowser: Added.
3463         * Scripts/run-wpe-tests:
3464         (WPETestRunner):
3465         (WPETestRunner.is_google_test):
3466         (WPETestRunner.is_qt_test):
3467         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3468         (TestLoad::main):
3469         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3470         (TestLoadHtml::main):
3471         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3472         (TestLoadRequest::main):
3473         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3474         (TestRunJavaScript::main):
3475         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3476         (waitForSignal):
3477         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3478         (LoadSpy::LoadSpy):
3479         (LoadSpy::~LoadSpy):
3480         (LoadSpy::onLoadingChanged):
3481         (LoadStartedCatcher::LoadStartedCatcher):
3482         (LoadStartedCatcher::~LoadStartedCatcher):
3483         (LoadStartedCatcher::onLoadingChanged):
3484         (waitForLoadSucceeded):
3485         (waitForLoadFailed):
3486         * TestWebKitAPI/glib/CMakeLists.txt:
3487         * flatpak/flatpakutils.py:
3488         (WebkitFlatpak.load_from_args):
3489         (WebkitFlatpak.__init__):
3490         (WebkitFlatpak.clean_args):
3491         (WebkitFlatpak.run_in_sandbox):
3492         * flatpak/org.webkit.CommonModules.yaml:
3493         * flatpak/org.webkit.WPE.yaml:
3494         * flatpak/org.webkit.WPEModules.yaml:
3495         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3496         * flatpak/org.webkit.WebKit.yaml:
3497         * glib/api_test_runner.py:
3498         (TestRunner._run_test_qt):
3499         (TestRunner.is_qt_test):
3500         (TestRunner._run_test):
3501
3502 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3503
3504         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3505         https://bugs.webkit.org/show_bug.cgi?id=193494
3506         <rdar://problem/46859627>
3507
3508         Reviewed by Simon Fraser and Tim Horton.
3509
3510         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3511         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3512
3513         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3514         (WTR::UIScriptController::contentOffsetX const):
3515         (WTR::UIScriptController::contentOffsetY const):
3516         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3517         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3518         (WTR::UIScriptController::contentOffsetX const):
3519         (WTR::UIScriptController::contentOffsetY const):
3520         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3521
3522         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3523
3524         * WebKitTestRunner/TestController.cpp:
3525         (WTR::updateTestOptionsFromTestHeader):
3526         * WebKitTestRunner/TestOptions.h:
3527         (WTR::TestOptions::hasSameInitializationOptions const):
3528         * WebKitTestRunner/ios/TestControllerIOS.mm:
3529         (WTR::TestController::platformResetStateToConsistentValues):
3530         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3531         (WTR::UIScriptController::contentOffsetX const):
3532         (WTR::UIScriptController::contentOffsetY const):
3533
3534 2019-01-17  Truitt Savell  <tsavell@apple.com>
3535
3536         Unreviewed, rolling out r240124.
3537
3538         This commit broke an internal build.
3539
3540         Reverted changeset:
3541
3542         "SDK_VARIANT build destinations should be separate from non-
3543         SDK_VARIANT builds"
3544         https://bugs.webkit.org/show_bug.cgi?id=189553
3545         https://trac.webkit.org/changeset/240124
3546
3547 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3548
3549         Fix string concatenation API test after r239920
3550         https://bugs.webkit.org/show_bug.cgi?id=193551
3551         <rdar://problem/47359304>
3552
3553         Reviewed by Youenn Fablet.
3554
3555         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3556         (TestWebKitAPI::TEST):
3557         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3558         in WebKit's build configuration like it apparently is on Linux.
3559
3560 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3561
3562         [ews-build] validate-patch should handle the case when bug_id is None
3563         https://bugs.webkit.org/show_bug.cgi?id=193547
3564
3565         Reviewed by Lucas Forschler.
3566
3567         * BuildSlaveSupport/ews-build/steps.py:
3568         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3569         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3570
3571 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3572
3573         [ews-build] Add patch author information in build
3574         https://bugs.webkit.org/show_bug.cgi?id=193465
3575
3576         Reviewed by Lucas Forschler.
3577
3578         * BuildSlaveSupport/ews-build/steps.py:
3579         (ValidatePatch._is_patch_obsolete):
3580
3581 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3582
3583         [ews-build] Pass bug_id to the triggered builds
3584         https://bugs.webkit.org/show_bug.cgi?id=193548
3585
3586         Reviewed by Lucas Forschler.
3587
3588         * BuildSlaveSupport/ews-build/factories.py:
3589         (BuildFactory.propertiesToPassToTriggers):
3590
3591 2019-01-17  Jer Noble  <jer.noble@apple.com>
3592
3593         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3594         https://bugs.webkit.org/show_bug.cgi?id=189553
3595
3596         Reviewed by Tim Horton.
3597
3598         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3599
3600         * ContentExtensionTester/Configurations/Base.xcconfig:
3601         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3602         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3603         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3604         * ImageDiff/cg/Configurations/Base.xcconfig:
3605         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3606         * MiniBrowser/Configurations/Base.xcconfig:
3607         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3608         * MobileMiniBrowser/Configurations/Base.xcconfig:
3609         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3610         * Scripts/webkitpy/style/checker.py:
3611         (_all_categories):
3612         (FileType):
3613         (CheckerDispatcher._file_type):
3614         (CheckerDispatcher._create_checker):
3615         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3616         (SDKVariantChecker):
3617         (SDKVariantChecker.__init__):
3618         (SDKVariantChecker.check):
3619         * TestWebKitAPI/Configurations/Base.xcconfig:
3620         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3621         * WebEditingTester/Configurations/Base.xcconfig:
3622         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3623         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3624         * WebKitTestRunner/Configurations/Base.xcconfig:
3625         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3626         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3627         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3628
3629 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3630
3631         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3632         https://bugs.webkit.org/show_bug.cgi?id=193534
3633
3634         Reviewed by Antti Koivisto.
3635
3636         * LayoutReloaded/misc/LFC-passing-tests.txt:
3637
3638 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3639
3640         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3641         https://bugs.webkit.org/show_bug.cgi?id=193528
3642
3643         Reviewed by Antti Koivisto.
3644
3645         * LayoutReloaded/misc/LFC-passing-tests.txt:
3646
3647 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3648
3649         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3650         https://bugs.webkit.org/show_bug.cgi?id=193520
3651
3652         Reviewed by Antti Koivisto.
3653
3654         * LayoutReloaded/misc/LFC-passing-tests.txt:
3655
3656 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3657
3658         [ews-build] unapply-patch step should not update source
3659         https://bugs.webkit.org/show_bug.cgi?id=193234
3660
3661         Reviewed by Lucas Forschler.
3662
3663         * BuildSlaveSupport/ews-build/steps.py:
3664         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3665         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3666
3667 2019-01-16  Youenn Fablet  <youenn@apple.com>
3668
3669         Add a new SPI for controlling getUserMedia
3670         https://bugs.webkit.org/show_bug.cgi?id=192793
3671
3672         Reviewed by Eric Carlson.
3673
3674         * MiniBrowser/mac/WK2BrowserWindowController.m:
3675         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3676         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3677         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3678         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3679         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3680         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3681         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3682         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3683         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3684         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3685         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3686         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3687         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3688         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3689
3690 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3691
3692         [LFC][BFC] Inflow non-replaced used width should not be negative.
3693         https://bugs.webkit.org/show_bug.cgi?id=193495
3694
3695         Reviewed by Antti Koivisto.
3696
3697         * LayoutReloaded/misc/LFC-passing-tests.txt:
3698
3699 2019-01-16  Chris Dumez  <cdumez@apple.com>
3700
3701         Regression(PSON) View becomes blank after click a cross-site download link
3702         https://bugs.webkit.org/show_bug.cgi?id=193361
3703         <rdar://problem/47099573>
3704
3705         Reviewed by Geoffrey Garen.
3706
3707         Add API test coverage.
3708
3709         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3710         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3711
3712 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3713
3714         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3715         https://bugs.webkit.org/show_bug.cgi?id=193470
3716
3717         Reviewed by Antti Koivisto.
3718
3719         * LayoutReloaded/misc/LFC-passing-tests.txt:
3720
3721 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3722
3723         [LFC] Adjust margin box verification.
3724         https://bugs.webkit.org/show_bug.cgi?id=193482
3725
3726         Reviewed by Antti Koivisto.
3727
3728         * LayoutReloaded/misc/LFC-passing-tests.txt:
3729
3730 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3731
3732         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3733         https://bugs.webkit.org/show_bug.cgi?id=193451
3734
3735         Reviewed by Geoffrey Garen.
3736
3737         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3738         (TEST):
3739         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3740         (runWebsiteDataStoreCustomPaths):
3741
3742 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3743
3744         webkitpy: Support boolean simctl isAvailable
3745         https://bugs.webkit.org/show_bug.cgi?id=193472
3746         <rdar://problem/47296150>
3747
3748         Reviewed by Ryosuke Niwa.
3749
3750         * Scripts/webkitpy/xcode/simulated_device.py:
3751         (SimulatedDeviceManager._create_runtimes):
3752         (SimulatedDeviceManager._create_device_with_runtime):
3753
3754 2019-01-15  Chris Dumez  <cdumez@apple.com>
3755
3756         Unreviewed, rolling out r239993, r239995, r239997, and
3757         r239999.
3758
3759         Caused assertions under
3760         ViewGestureController::disconnectFromProcess()
3761
3762         Reverted changesets:
3763
3764         "Regression(PSON) View becomes blank after click a cross-site
3765         download link"
3766         https://bugs.webkit.org/show_bug.cgi?id=193361
3767         https://trac.webkit.org/changeset/239993
3768
3769         "Unreviewed iOS build fix after r239993."
3770         https://trac.webkit.org/changeset/239995
3771
3772         "Fix iOS build after r239993"
3773         https://bugs.webkit.org/show_bug.cgi?id=193361
3774         https://trac.webkit.org/changeset/239997
3775
3776         "Unreviewed, revert part of r239997 as it is not needed to fix
3777         the build."
3778         https://trac.webkit.org/changeset/239999
3779
3780 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3781
3782         Cannot tab out of WKWebView on macOS
3783         https://bugs.webkit.org/show_bug.cgi?id=161448
3784         <rdar://problem/28100085>
3785
3786         Reviewed by Dean Jackson.
3787
3788         Add a test that tabbing into and out of WKWebView works correctly.
3789
3790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3791         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3792         (WebKit2_CommandBackForwardTest::SetUp):
3793         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3794         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3795         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3796         (-[FocusableView canBecomeKeyView]):
3797         (TEST):
3798         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3799         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3800         (-[OffscreenWindow initWithSize:]):
3801         (-[OffscreenWindow isKeyWindow]):
3802         (-[OffscreenWindow isVisible]):
3803         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3804         (TestWebKitAPI::PlatformWebView::initialize):
3805         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3806         (-[ActiveOffscreenWindow isVisible]): Deleted.
3807         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3808
3809 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3810
3811         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3812         https://bugs.webkit.org/show_bug.cgi?id=193459
3813
3814         Reviewed by Mark Lam.
3815
3816         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3817         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3818
3819 2019-01-15  Chris Dumez  <cdumez@apple.com>
3820
3821         Regression(PSON) View becomes blank after click a cross-site download link
3822         https://bugs.webkit.org/show_bug.cgi?id=193361
3823         <rdar://problem/47099573>
3824
3825         Reviewed by Geoff Garen.
3826
3827         Add API test coverage.
3828
3829         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3830         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3831
3832 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3833
3834         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3835         https://bugs.webkit.org/show_bug.cgi?id=193448
3836
3837         Reviewed by Antti Koivisto.
3838
3839         * LayoutReloaded/misc/LFC-passing-tests.txt:
3840
3841 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3842
3843         webkitpy: Implement device type specific expected results (Part 1)
3844         https://bugs.webkit.org/show_bug.cgi?id=192162
3845
3846         Reviewed by Lucas Forschler.
3847
3848         Device type specific expected results covers two related ideas. The first (covered by this change)
3849         is where to search for -expected.* files. The second is which tests to run based on the
3850         TestExpectations.txt file.
3851
3852         After this change, the baseline search path will be determined by the type of device running a
3853         test. Device type will be passed into any function which picks a file based on the baseline search
3854         path.
3855
3856         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3857         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3858         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3859         (Manager.run): Print baseline search path for each round of devices.
3860         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3861         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3862         (SingleTestRunner._expected_driver_output): Ditto.
3863         (SingleTestRunner._driver_input): Ditto.
3864         * Scripts/webkitpy/layout_tests/views/printing.py:
3865         (Printer.print_config): Move printing of baseline search path to a separate function.
3866         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3867         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3868         (Testprinter.test_print_config):
3869         (Testprinter.test_print_baseline_search_path):
3870         * Scripts/webkitpy/port/base.py:
3871         (Port.baseline_search_path): Pass device_type through.
3872         (Port._expected_baselines_for_suffixes): Ditto.
3873         (Port.expected_baselines): Ditto.
3874         (Port.expected_filename): Ditto.
3875         (Port.expected_checksum): Ditto.
3876         (Port.expected_image): Ditto.
3877         (Port.expected_audio): Ditto.
3878         (Port.expected_text): Ditto.
3879         (Port.reference_files): Ditto.
3880         (Port.tests): Ditto.
3881         (Port._expanded_paths): Ditto.
3882         (Port.skipped_layout_tests): Ditto.
3883         (Port.expectations_dict): Ditto.
3884         (Port._port_specific_expectations_files): Ditto.
3885         (Port.expectations_files): Ditto.
3886         (Port.test_search_path): Ditto.
3887         (Port._tests_for_other_platforms): Ditto.
3888         * Scripts/webkitpy/port/base_unittest.py:
3889         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3890         (PortTest.test_nonexistant_expectations): Ditto.
3891         (test_ref_tests_platform_directory): Ditto.
3892         * Scripts/webkitpy/port/darwin.py:
3893         (DarwinPort._port_specific_expectations_files): Accept device_type.
3894         * Scripts/webkitpy/port/driver.py:
3895         (DriverProxy):
3896         (DriverProxy.host): Expose _target_host for device_type information.
3897         * Scripts/webkitpy/port/gtk.py:
3898         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3899         * Scripts/webkitpy/port/ios.py:
3900         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3901         * Scripts/webkitpy/port/mac.py:
3902         (MacPort. default_baseline_search_path): Ditto.
3903         * Scripts/webkitpy/port/port_testcase.py:
3904         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3905         * Scripts/webkitpy/port/test.py:
3906         * Scripts/webkitpy/port/watch.py:
3907         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3908         * Scripts/webkitpy/port/win.py:
3909         (WinPort.test_search_path): Accept, but do not use, device_type.
3910         * Scripts/webkitpy/port/wpe.py:
3911         (WPEPort._port_specific_expectations_files): Ditto.
3912         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3913         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3914
3915 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3916
3917         [LFC] Use the containing block's padding box to position out-of-flow elements.
3918         https://bugs.webkit.org/show_bug.cgi?id=193431
3919
3920         Reviewed by Antti Koivisto.
3921
3922         * LayoutReloaded/misc/LFC-passing-tests.txt:
3923
3924 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3925
3926         Move a test implementation file that got misplaced in the Xcode project
3927
3928         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3929
3930 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3931
3932         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3933         r239913, and r239914.
3934         https://bugs.webkit.org/show_bug.cgi?id=193407
3935
3936         These revisions caused an internal failure (Requested by
3937         Truitt on #webkit).
3938
3939         Reverted changesets:
3940
3941         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3942         https://bugs.webkit.org/show_bug.cgi?id=186016
3943         https://trac.webkit.org/changeset/239901
3944
3945         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3946         https://trac.webkit.org/changeset/239909
3947
3948         "Tried to fix the build."
3949         https://trac.webkit.org/changeset/239910
3950
3951         "Fixed iOS builds after r239910."
3952         https://trac.webkit.org/changeset/239912
3953
3954         "More build fixing."
3955         https://trac.webkit.org/changeset/239913
3956
3957         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3958         https://trac.webkit.org/changeset/239914
3959
3960 2019-01-14  Mark Lam  <mark.lam@apple.com>
3961
3962         Re-enable ability to build --cloop builds.
3963         https://bugs.webkit.org/show_bug.cgi?id=192955
3964         <rdar://problem/46882363>
3965
3966         Reviewed by Saam barati and Keith Miller.
3967
3968         The --cloop build option was being ignored this whole time since r236381.
3969         This patch makes it possible to build CLoop builds again.
3970
3971         * Scripts/build-jsc:
3972         * Scripts/webkitperl/FeatureList.pm:
3973         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3974
3975 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3976
3977         webkitpy: Expose device_type from host-like objects
3978         https://bugs.webkit.org/show_bug.cgi?id=193406
3979         <rdar://problem/47262305>
3980
3981         Reviewed by Lucas Forschler.
3982
3983         Devices should expose device_type. As a result, all host objects should
3984         provide a device_type property, even if they do not yet define a device_type.
3985
3986         * Scripts/webkitpy/common/system/systemhost.py:
3987         (SystemHost):
3988         (SystemHost.device_type):
3989         * Scripts/webkitpy/common/system/systemhost_mock.py:
3990         (MockSystemHost):
3991         (MockSystemHost.device_type):
3992         * Scripts/webkitpy/port/device.py:
3993         (Device):
3994         (Device.device_type):
3995         * Scripts/webkitpy/xcode/simulated_device.py:
3996         (SimulatedDeviceManager._find_exisiting_device_for_request):
3997         (SimulatedDeviceManager._disambiguate_device_type):
3998         (SimulatedDeviceManager._does_fulfill_request):
3999         (SimulatedDeviceManager.device_count_for_type):
4000         (SimulatedDeviceManager.initialize_devices):
4001         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
4002         (test_available_devices):
4003         (test_swapping_devices):
4004
4005 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4006
4007         webkitpy: Support alternate simctl device list output (Follow-up fix)
4008         https://bugs.webkit.org/show_bug.cgi?id=193362
4009         <rdar://problem/47122965>
4010
4011         Rubber-stamped by Lucas Forschler.
4012
4013         * Scripts/webkitpy/xcode/simulated_device.py:
4014         (SimulatedDeviceManager.populate_available_devices):
4015
4016 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
4017
4018         [iOS] Expose SPI to access the current sentence boundary and selection state
4019         https://bugs.webkit.org/show_bug.cgi?id=193398
4020         <rdar://problem/45893108>
4021
4022         Reviewed by Dean Jackson.
4023
4024         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
4025         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
4026         expected.
4027
4028         * TestWebKitAPI/EditingTestHarness.h:
4029         * TestWebKitAPI/EditingTestHarness.mm:
4030         (-[EditingTestHarness moveBackward]):
4031         (-[EditingTestHarness moveForward]):
4032         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
4033
4034         Add a couple of new helper methods on EditingTestHarness.
4035
4036         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
4037         (-[SelectionChangeObserver initWithWebView:]):
4038         (-[SelectionChangeObserver webView]):
4039         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
4040         (-[SelectionChangeObserver currentSelectionAttributes]):
4041
4042 2019-01-14  Zalan Bujtas  <zalan@apple.com>
4043
4044         [LFC][BFC] Add basic box-sizing support.
4045         https://bugs.webkit.org/show_bug.cgi?id=193392
4046
4047         Reviewed by Antti Koivisto.
4048
4049         * LayoutReloaded/misc/LFC-passing-tests.txt:
4050
4051 2019-01-14  Charlie Turner  <cturner@igalia.com>
4052
4053         [WPE] API test gardening
4054         https://bugs.webkit.org/show_bug.cgi?id=193319
4055
4056         Reviewed by Michael Catanzaro.
4057
4058         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
4059         passing tests.
4060
4061 2019-01-14  Charlie Turner  <cturner@igalia.com>
4062
4063         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
4064         https://bugs.webkit.org/show_bug.cgi?id=192977
4065
4066         Reviewed by Carlos Garcia Campos.
4067
4068         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
4069         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
4070         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
4071         (TestWebKitAPI::GStreamerTest::SetUp):
4072         (TestWebKitAPI::GStreamerTest::TearDown):
4073         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
4074         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
4075         (TestWebKitAPI::TEST_F):
4076
4077 2019-01-14  Charlie Turner  <cturner@igalia.com>
4078
4079         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
4080         https://bugs.webkit.org/show_bug.cgi?id=193332
4081
4082         Reviewed by Michael Catanzaro.
4083
4084         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
4085         defined as a char16_t, which changed in ICU 59, the
4086         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
4087         unsigned short. This test is relying on the behaviour that
4088         UChar=unsigned short, which doesn't hold across platforms and ICU
4089         library versions. The full fix would be a special syntax for
4090         literal characters so that these ambiguities do not arise. That
4091         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
4092         (TestWebKitAPI::TEST):
4093
4094 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4095
4096         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
4097
4098         * Scripts/make-dist:
4099         (Distcheck.configure):
4100
4101 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
4102
4103         [ews-build] Update macOS queue configurations
4104         https://bugs.webkit.org/show_bug.cgi?id=193365
4105         <rdar://problem/47221073>
4106
4107         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
4108
4109         * BuildSlaveSupport/ews-build/config.json:
4110
4111 2019-01-13  Zalan Bujtas  <zalan@apple.com>
4112
4113         [LFC] Adjust assert for statically positioned fixed elements
4114         https://bugs.webkit.org/show_bug.cgi?id=193385
4115
4116         Reviewed by Antti Koivisto.
4117
4118         * LayoutReloaded/misc/LFC-passing-tests.txt:
4119
4120 2019-01-13  Philippe Normand  <pnormand@igalia.com>
4121
4122         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
4123         https://bugs.webkit.org/show_bug.cgi?id=193387
4124
4125         Reviewed by Carlos Garcia Campos.
4126
4127         * MiniBrowser/wpe/main.cpp:
4128         (main):
4129
4130 2019-01-12  Timothy Hatcher  <timothy@apple.com>
4131
4132         Have prefers-color-scheme: light always match on macOS versions before Mojave.
4133         https://bugs.webkit.org/show_bug.cgi?id=191655
4134         rdar://problem/46074680
4135
4136         Reviewed by Megan Gardner.
4137
4138         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
4139         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
4140
4141 2019-01-12  Dan Bernstein  <mitz@apple.com>
4142
4143         [Cocoa] Avoid importing directly from subumbrella frameworks
4144         https://bugs.webkit.org/show_bug.cgi?id=186016
4145         <rdar://problem/40591038>
4146
4147         Reviewed by Sam Weinig.
4148
4149         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4150           LaunchServices header.
4151         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4152           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4153         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4154           when using SDKs earlier than 10.13.
4155         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4156           and OTHER_CPLUSPLUSFLAGS.
4157         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4158           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4159         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4160           LaunchServices header.
4161
4162 2019-01-11  John Wilander  <wilander@apple.com>
4163
4164         Compile out Web API Statistics Collection
4165         https://bugs.webkit.org/show_bug.cgi?id=193370
4166         <rdar://problem/45388584>
4167
4168         Reviewed by Brent Fulgham.
4169
4170         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4171             Defined ENABLE_WEB_API_STATISTICS, off by default.
4172
4173 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4174
4175         [WPE] Add gtk-doc
4176         https://bugs.webkit.org/show_bug.cgi?id=178900
4177
4178         Reviewed by Michael Catanzaro.
4179
4180         Add Tools/gtkdoc to manifest.txt.in files.
4181         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
4182
4183         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
4184         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
4185
4186 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4187
4188         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
4189         https://bugs.webkit.org/show_bug.cgi?id=193364
4190         <rdar://problem/47214117>
4191
4192         Reviewed by Tim Horton.
4193
4194         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
4195         precise, whereas dragging near the middle of the textarea does.
4196
4197         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4198         (TestWebKitAPI::TEST):
4199
4200 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4201
4202         webkitpy: Support alternate simctl device list output
4203         https://bugs.webkit.org/show_bug.cgi?id=193362
4204         <rdar://problem/47122965>
4205
4206         Reviewed by Lucas Forschler.
4207
4208         * Scripts/webkitpy/xcode/simulated_device.py:
4209         (SimulatedDeviceManager.populate_available_devices):
4210
4211 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
4212
4213         [ews-build] Update macOS queue configurations
4214         https://bugs.webkit.org/show_bug.cgi?id=193365
4215
4216         Reviewed by Lucas Forschler.
4217
4218         * BuildSlaveSupport/ews-build/config.json:
4219
4220 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4221
4222         webkitpy: Incorporate device type into baseline search path
4223         https://bugs.webkit.org/show_bug.cgi?id=193356
4224         <rdar://problem/47215515>
4225
4226         Reviewed by Lucas Forschler.
4227
4228         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
4229
4230         * Scripts/webkitpy/port/base.py:
4231         (Port.default_baseline_search_path): Allow device type to be passed in.
4232         * Scripts/webkitpy/port/gtk.py:
4233         (GtkPort.default_baseline_search_path): Ignore device type.
4234         * Scripts/webkitpy/port/ios.py:
4235         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
4236         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
4237         * Scripts/webkitpy/port/ios_device_unittest.py:
4238         (IOSDeviceTest):
4239         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4240         (IOSSimulatorTest):
4241         * Scripts/webkitpy/port/mac.py:
4242         (MacPort.default_baseline_search_path): Ignore device type.
4243         * Scripts/webkitpy/port/watch.py:
4244         (WatchPort.default_baseline_search_path): Ditto.
4245         * Scripts/webkitpy/port/win.py:
4246         (WinPort.default_baseline_search_path): Ditto.
4247         (WinCairoPort.default_baseline_search_path): Ditto.
4248         * Scripts/webkitpy/port/wpe.py:
4249         (WPEPort.default_baseline_search_path): Ditto.
4250
4251 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4252
4253         webkitpy: Print abbreviated baseline search path that includes only folders that exist
4254         https://bugs.webkit.org/show_bug.cgi?id=193352
4255         <rdar://problem/47210736>
4256
4257         Reviewed by Lucas Forschler.
4258
4259         * Scripts/webkitpy/layout_tests/views/printing.py:
4260         (Printer.print_config): Print list on only baseline search paths which exist. 
4261         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4262         (Testprinter.test_print_config):
4263
4264 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
4265
4266         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
4267         https://bugs.webkit.org/show_bug.cgi?id=193340
4268
4269         Reviewed by David Kilzer.
4270
4271         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4272         (WTR::InjectedBundle::didReceiveMessageToPage):
4273         Pull the strings out into a WKRetainPtr.
4274
4275         * WebKitTestRunner/WebNotificationProvider.cpp:
4276         (WTR::WebNotificationProvider::closeWebNotification):
4277         Adopt the created value into the WKRetainPtr.
4278
4279         * WebKitTestRunner/mac/TestControllerMac.mm:
4280         (WTR::generateWhitelist):
4281         Immediately adopt a created value to avoid potential mistakes.
4282
4283 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
4284
4285         Enable DFG on ARM/Linux again
4286         https://bugs.webkit.org/show_bug.cgi?id=192496
4287
4288         Reviewed by Yusuke Suzuki.
4289
4290         After changing the bytecode format DFG was disabled on all 32-bit
4291         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4292         on ARM by default.
4293
4294         * Scripts/run-jsc-stress-tests:
4295
4296 2019-01-11  Timothy Hatcher  <timothy@apple.com>
4297
4298         Unreviewed, fix #ifdef in API test added in r239851.
4299         https://bugs.webkit.org/show_bug.cgi?id=193327
4300         rdar://problem/47093222
4301
4302         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
4303
4304 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4305
4306         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
4307         https://bugs.webkit.org/show_bug.cgi?id=193109
4308         <rdar://problem/44807048>
4309
4310         Reviewed by Ryosuke Niwa.
4311
4312         Introduce and respect a test option to enable the UndoManager API.
4313
4314         * WebKitTestRunner/TestController.cpp:
4315         (WTR::updateTestOptionsFromTestHeader):
4316         * WebKitTestRunner/TestOptions.h:
4317         (WTR::TestOptions::hasSameInitializationOptions const):
4318         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4319         (WTR::TestController::platformCreateWebView):
4320
4321 2019-01-11  Zalan Bujtas  <zalan@apple.com>
4322
4323         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
4324         https://bugs.webkit.org/show_bug.cgi?id=193346
4325
4326         Reviewed by Antti Koivisto.
4327
4328         * LayoutReloaded/misc/LFC-passing-tests.txt: