_overrideViewportWithArguments does not work when called before loading
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-06  Tim Horton  <timothy_horton@apple.com>
2
3         _overrideViewportWithArguments does not work when called before loading
4         https://bugs.webkit.org/show_bug.cgi?id=197638
5         <rdar://problem/50505111>
6
7         Reviewed by Wenson Hsieh.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
10         (TEST):
11
12 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
13
14         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
15         https://bugs.webkit.org/show_bug.cgi?id=197510
16
17         Reviewed by Alex Christensen.
18
19         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
20         (TestWebKitAPI::TEST):
21
22 2019-05-06  Keith Rollin  <krollin@apple.com>
23
24         Temporarily disable generate-xcfilelists
25         https://bugs.webkit.org/show_bug.cgi?id=197619
26         <rdar://problem/50507392>
27
28         Reviewed by Alex Christensen.
29
30         We need to perform a significant update to the generate-xcfilelist
31         scripts. This work involves coordinated work with another facility. If
32         the work does not occur in tandem, the build will be broken. To avoid
33         this, disable the invoking of the scripts during the transition. The
34         checking will be restored once the new scripts are in place.
35
36         * DumpRenderTree/Scripts/check-xcfilelists.sh:
37         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
38
39 2019-05-04  Alex Christensen  <achristensen@webkit.org>
40
41         Revert r244953 and r244954 because they broke internal builds.
42         https://bugs.webkit.org/show_bug.cgi?id=197534
43
44         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
45         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
46         * DumpRenderTree/mac/DumpRenderTree.mm:
47         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
48         * DumpRenderTree/mac/TestRunnerMac.mm:
49         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
50         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
51         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
52         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
53         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
54         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
55         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
56         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
57         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
58         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
59         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
60         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
61         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
62         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
63         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
64         * TestWebKitAPI/cocoa/TestWKWebView.mm:
65         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
66         * TestWebKitAPI/ios/UIKitSPI.h: Added.
67         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
68         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
69         * WebKitTestRunner/ios/HIDEventGenerator.h:
70         * WebKitTestRunner/ios/HIDEventGenerator.mm:
71         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
72         * WebKitTestRunner/ios/TestControllerIOS.mm:
73         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
74         * WebKitTestRunner/ios/mainIOS.mm:
75
76 2019-05-04  Alex Christensen  <achristensen@webkit.org>
77
78         Merge the three UIKitSPI.h files into a single one in PAL
79         https://bugs.webkit.org/show_bug.cgi?id=197534
80
81         Reviewed by Darin Adler.
82
83         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
84         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
85         * DumpRenderTree/mac/DumpRenderTree.mm:
86         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
87         * DumpRenderTree/mac/TestRunnerMac.mm:
88         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
89         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
90         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
91         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
92         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
93         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
94         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
95         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
96         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
97         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
98         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
99         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
100         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
101         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
102         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
103         * TestWebKitAPI/cocoa/TestWKWebView.mm:
104         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
105         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
106         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
107         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
108         * WebKitTestRunner/ios/HIDEventGenerator.h:
109         * WebKitTestRunner/ios/HIDEventGenerator.mm:
110         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
111         * WebKitTestRunner/ios/TestControllerIOS.mm:
112         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
113         * WebKitTestRunner/ios/mainIOS.mm:
114
115 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
116
117         Web Inspector: Provide UIString descriptions to improve localizations
118         https://bugs.webkit.org/show_bug.cgi?id=195132
119         <rdar://problem/48457817>
120
121         Reviewed by Devin Rousso.
122
123         Allow WI.UIString to take:
124         - WI.UIString(string, key, comment)
125         - WI.UIString(string, comment)
126         - WI.UIString(string)
127
128         * Scripts/extract-localizable-js-strings:
129
130 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
131
132         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
133         https://bugs.webkit.org/show_bug.cgi?id=197579
134
135         Reviewed by Tim Horton.
136
137         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
138         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
139         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
140         ensure that the the focused element has been blurred.
141
142         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
143
144 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
145
146         Add a tool to block spammer accounts
147         https://bugs.webkit.org/show_bug.cgi?id=197537
148
149         Reviewed by Darin Adler.
150
151         Usage: block-spammers email1 email2 ...
152
153         The tool finds and hides all bugs and comments from this account. Before any work
154         is done, these bugs and comments are displayed for confirmation.
155
156         * Scripts/block-spammers: Added.
157         (get_bugzilla_token):
158         (invalidate_bugzilla_token):
159         (get_user_info):
160         (get_user_info_self):
161         (can_use_this_tool):
162         (disable_user):
163         (get_bugs_created_by_user):
164         (get_bugs_commented_on_by_user):
165         (get_comments):
166         (hide_bug):
167         (hide_comments):
168         (ask_yes_no):
169         (sanitized_string):
170         (main):
171
172 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
173
174         run-apit-tests: Add --iterations and --repeat-each
175         https://bugs.webkit.org/show_bug.cgi?id=197563
176
177         Reviewed by Aakash Jain.
178
179         * Scripts/webkitpy/api_tests/manager.py:
180         (Manager.run): Add --iterations and --repeat-each/
181         * Scripts/webkitpy/api_tests/run_api_tests.py:
182         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
183
184 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
185
186         New EWS: Clicking on white bubble navigates to page with only bubbles
187         https://bugs.webkit.org/show_bug.cgi?id=197520
188
189         Reviewed by Lucas Forschler.
190
191         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
192
193 2019-05-03  Daniel Bates  <dabates@apple.com>
194
195         [lldb-webkit] Support adding pretty-printing for qualified types
196         https://bugs.webkit.org/show_bug.cgi?id=197518
197
198         Reviewed by Darin Adler.
199
200         Remove all "::"s from the name of the specified type when computing the name for the Python classes
201         that will provide summary and synthetic details as LLDB is not happy about registering such classes
202         when they contain :: in their name.
203
204         * lldb/lldb_webkit.py:
205         (addSummaryAndSyntheticFormattersForRawBitmaskType):
206
207 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
208
209         New EWS: patches on recently added queues listed as #1 for older bugs
210         https://bugs.webkit.org/show_bug.cgi?id=197496
211
212         Reviewed by Lucas Forschler.
213
214         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
215         (StatusBubble._build_bubble):
216         (StatusBubble._queue_position):
217
218 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
219
220         webkit-patch --no-review upload does not submit patch to New EWS
221         https://bugs.webkit.org/show_bug.cgi?id=197519
222         <rdar://problem/50424887>
223
224         Reviewed by Lucas Forschler.
225
226         * Scripts/webkitpy/tool/steps/submittoews.py:
227         (SubmitToEWS.run): Submit to both old and new EWS.
228         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
229         * Scripts/webkitpy/common/net/ewsserver.py: Added.
230         (EWSServer._server_url): Method to return server url.
231         (EWSServer._post_patch_to_ews): Method to post patch to ews.
232         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
233         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
234         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
235         * Scripts/webkitpy/common/net/statusserver_mock.py:
236         (MockStatusServer.submit_to_ews): Updated the log text.
237         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
238         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
239         * Scripts/webkitpy/tool/main.py:
240         (WebKitPatch.__init__): Initialize ews_server. 
241         * Scripts/webkitpy/tool/mocktool.py:
242         (MockTool.__init__): Ditto.
243
244 2019-05-03  Chris Dumez  <cdumez@apple.com>
245
246         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
247         https://bugs.webkit.org/show_bug.cgi?id=197574
248         <rdar://problem/50453181>
249
250         Reviewed by Tim Horton.
251
252         Add API test coverage.
253
254         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
255         (TEST):
256
257 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
258
259         [JSC] Generator CodeBlock generation should be idempotent
260         https://bugs.webkit.org/show_bug.cgi?id=197552
261
262         Reviewed by Keith Miller.
263
264         * Scripts/run-javascriptcore-tests:
265         (runJSCStressTests):
266         * Scripts/run-jsc-stress-tests:
267
268 2019-05-03  Commit Queue  <commit-queue@webkit.org>
269
270         Unreviewed, rolling out r244881.
271         https://bugs.webkit.org/show_bug.cgi?id=197559
272
273         Breaks compilation of jsconly on linux, breaking compilation
274         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
275         guijemont on #webkit).
276
277         Reverted changeset:
278
279         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
280         WEBKIT_COPY_FILES"
281         https://bugs.webkit.org/show_bug.cgi?id=197174
282         https://trac.webkit.org/changeset/244881
283
284 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
285
286         Unreviewed WPE build fix after r244898.
287
288         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
289         (WTR::TestController::abortModal): Add the missing (no-op) definition.
290
291 2019-05-02  Alex Christensen  <achristensen@webkit.org>
292
293         Mark U+01C0 as a homograph of U+006C
294         https://bugs.webkit.org/show_bug.cgi?id=197526
295         <rdar://problem/50301904>
296
297         Reviewed by Tim Horton.
298
299         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
300         (TestWebKitAPI::TEST):
301
302 2019-05-02  Chris Dumez  <cdumez@apple.com>
303
304         Add test coverage for <rdar://problem/49731231>
305         https://bugs.webkit.org/show_bug.cgi?id=196730
306         <rdar://problem/49731231>
307
308         Reviewed by Ryosuke Niwa.
309
310         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
311         to match DumpRenderTree.
312
313         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
314         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
315         (WTR::TestRunner::abortModal):
316         * WebKitTestRunner/InjectedBundle/TestRunner.h:
317         * WebKitTestRunner/TestController.cpp:
318         (WTR::TestController::runModal):
319         * WebKitTestRunner/TestController.h:
320         * WebKitTestRunner/TestInvocation.cpp:
321         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
322         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
323         (WTR::TestController::abortModal):
324         * WebKitTestRunner/ios/TestControllerIOS.mm:
325         (WTR::TestController::abortModal):
326         * WebKitTestRunner/mac/TestControllerMac.mm:
327         (WTR::TestController::abortModal):
328         * WebKitTestRunner/win/TestControllerWin.cpp:
329         (WTR::TestController::abortModal):
330
331 2019-05-02  Christopher Reid  <chris.reid@sony.com>
332
333         [CMake] Add support for LTO builds
334         https://bugs.webkit.org/show_bug.cgi?id=188986
335
336         Reviewed by Don Olmstead.
337
338         Add support to configure --lto-mode with cmake builds.
339
340         * Scripts/build-webkit:
341         * Scripts/webkitdirs.pm:
342         (generateBuildSystemFromCMakeProject):
343
344 2019-05-02  John Wilander  <wilander@apple.com>
345
346         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
347         https://bugs.webkit.org/show_bug.cgi?id=197521
348         <rdar://problem/49651503>
349
350         Reviewed by Brent Fulgham.
351
352         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
353         (TestWebKitAPI::TEST):
354            Added a test for host strings with leading dots since they are
355            often used for the domain attribute in cookies.
356
357 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
358
359         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
360         https://bugs.webkit.org/show_bug.cgi?id=197510
361
362         Reviewed by Alex Christensen.
363
364         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
365         (TestWebKitAPI::TEST):
366
367 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
368
369         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
370         https://bugs.webkit.org/show_bug.cgi?id=197174
371
372         Reviewed by Alex Christensen.
373
374         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
375
376         * TestWebKitAPI/PlatformGTK.cmake:
377         * TestWebKitAPI/PlatformWPE.cmake:
378
379 2019-05-02  Alex Christensen  <achristensen@webkit.org>
380
381         Build fix for internal branch.
382
383         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
384         RetainPtr.h was not explicitly included.
385
386 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
387
388         webkitpy: Ignore errors when shutting down an already shutdown simulator
389         <https://bugs.webkit.org/show_bug.cgi?id=197514>
390         <rdar://problem/50390247>
391
392         Reviewed by Lucas Forschler.
393
394         * Scripts/webkitpy/xcode/simulated_device.py:
395         (SimulatedDevice._shut_down):
396
397 2019-05-02  Frederic Wang  <fwang@igalia.com>
398
399         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
400         https://bugs.webkit.org/show_bug.cgi?id=196142
401
402         This patch introduces some experimental runtime flag to let users
403         disable MathML features that are removed from MathML Core [1]. For now,
404         these features are only disabled on GTK and WPE ports.
405
406         [1] https://mathml-refresh.github.io/mathml-core/
407
408         Reviewed by Rob Buis.
409
410         * DumpRenderTree/TestOptions.cpp:
411         (TestOptions::TestOptions):
412         * DumpRenderTree/TestOptions.h:
413         * DumpRenderTree/mac/DumpRenderTree.mm:
414         (setWebPreferencesForTestOptions):
415
416 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
417
418         TestWebKitAPI config.h should be aware of what suite is being built
419         https://bugs.webkit.org/show_bug.cgi?id=196583
420
421         Reviewed by Konstantin Tokarev.
422
423         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
424         benefit the macro defines BUILDING_* for the executable which allows the includes
425         of the config.h to be tailored to the test suite being built. Because of that the
426         dependencies of the Test* executable are specific to the test suite which may
427         speed up the build.
428
429         Some source files were including "PlatformUtilities.h" which includes WebKit headers
430         when "Utilities.h" is what was needed.
431
432         * TestWebKitAPI/CMakeLists.txt:
433         * TestWebKitAPI/PlatformGTK.cmake:
434         * TestWebKitAPI/PlatformJSCOnly.cmake:
435         * TestWebKitAPI/PlatformMac.cmake:
436         * TestWebKitAPI/PlatformPlayStation.cmake:
437         * TestWebKitAPI/PlatformUtilities.h:
438         * TestWebKitAPI/PlatformWPE.cmake:
439         * TestWebKitAPI/PlatformWin.cmake:
440         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
441         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
442         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
443         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
444         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
445         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
446         * TestWebKitAPI/config.h:
447
448 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
449
450         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
451         https://bugs.webkit.org/show_bug.cgi?id=181950
452         <rdar://problem/43357371>
453
454         Reviewed by Brent Fulgham.
455
456         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
457         (TestWebKitAPI::TEST_F):
458
459 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
460
461         Remove webkitpy and bindings EWS queues from dashboard
462         https://bugs.webkit.org/show_bug.cgi?id=197475
463
464         Reviewed by Alexey Proskuryakov.
465
466         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
467
468 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
469
470         Remove webkitpy and bindings test queues from old EWS
471         https://bugs.webkit.org/show_bug.cgi?id=197468
472
473         Reviewed by Alexey Proskuryakov.
474
475         * QueueStatusServer/config/queues.py:
476
477 2019-04-30  Tim Horton  <timothy_horton@apple.com>
478
479         Fix the WebKitTestRunner build
480         https://bugs.webkit.org/show_bug.cgi?id=197449
481         <rdar://problem/50334169>
482
483         Reviewed by Alexey Proskuryakov.
484
485         * WebKitTestRunner/mac/EventSenderProxy.mm:
486         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
487         (WTR::EventSenderProxy::mouseForceChanged):
488         Use some SPI instead of IPI.
489
490 2019-04-30  Chris Dumez  <cdumez@apple.com>
491
492         Regression(PSON) URL scheme handlers can no longer respond asynchronously
493         https://bugs.webkit.org/show_bug.cgi?id=197426
494         <rdar://problem/50256169>
495
496         Reviewed by Brady Eidson.
497
498         Add API test coverage.
499
500         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
501         (-[PSONScheme setShouldRespondAsynchronously:]):
502         (-[PSONScheme webView:startURLSchemeTask:]):
503         (-[PSONScheme webView:stopURLSchemeTask:]):
504
505 2019-04-30  Chris Dumez  <cdumez@apple.com>
506
507         Unreviewed, rolling out r244802.
508
509         Caused an API test failure
510
511         Reverted changeset:
512
513         "Regression(PSON) URL scheme handlers can no longer respond
514         asynchronously"
515         https://bugs.webkit.org/show_bug.cgi?id=197426
516         https://trac.webkit.org/changeset/244802
517
518 2019-04-30  Chris Dumez  <cdumez@apple.com>
519
520         Regression(PSON) URL scheme handlers can no longer respond asynchronously
521         https://bugs.webkit.org/show_bug.cgi?id=197426
522         <rdar://problem/50256169>
523
524         Reviewed by Brady Eidson.
525
526         Add API test coverage.
527
528         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
529         (-[PSONScheme setShouldRespondAsynchronously:]):
530         (-[PSONScheme webView:startURLSchemeTask:]):
531         (-[PSONScheme webView:stopURLSchemeTask:]):
532
533 2019-04-30  Chris Dumez  <cdumez@apple.com>
534
535         Only use a related page's process if that page has not been closed yet
536         https://bugs.webkit.org/show_bug.cgi?id=197393
537         <rdar://problem/50302423>
538
539         Reviewed by Tim Horton.
540
541         Add API test coverage.
542
543         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
544
545 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
546
547         [ews-build] Enable Bindings tests queue on new EWS
548         https://bugs.webkit.org/show_bug.cgi?id=197424
549
550         Reviewed by Lucas Forschler.
551
552         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
553         (StatusBubble):
554         * BuildSlaveSupport/ews-build/config.json:
555
556 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
557
558         [ews-build] Configure ews151 for running various tests
559         https://bugs.webkit.org/show_bug.cgi?id=197419
560
561         Reviewed by Lucas Forschler.
562
563         * BuildSlaveSupport/ews-build/config.json:
564
565 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
566
567         [ews-build] Parse and display bindings test failures
568         https://bugs.webkit.org/show_bug.cgi?id=197423
569
570         Reviewed by Lucas Forschler.
571
572         * BuildSlaveSupport/ews-build/steps.py:
573         (RunBindingsTests.__init__): Set timeout of 5 minutes.
574         (RunBindingsTests.start): Initialize log_observer for json output.
575         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
576         (RunBindingsTests._addToLog): Method to add message to log.
577         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
578
579 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
580
581         Unreviewed. Add myself as a committer.
582
583         * Scripts/webkitpy/common/config/contributors.json:
584
585 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
586
587         [ews-build] Enable webkitpy queue on new EWS
588         https://bugs.webkit.org/show_bug.cgi?id=197396
589
590         Reviewed by Lucas Forschler.
591
592         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
593         (StatusBubble):
594         * BuildSlaveSupport/ews-build/config.json:
595
596 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
597
598         [ews-build] Parse and display webkitpy failures
599         https://bugs.webkit.org/show_bug.cgi?id=197395
600
601         Reviewed by Lucas Forschler.
602
603         * BuildSlaveSupport/ews-build/steps.py:
604         (RunWebKitPyTests.start): Initialize log_observer for json output.
605         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
606         (RunWebKitPyTests._addToLog): Method to add message to log.
607         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
608
609 2019-04-29  Alex Christensen  <achristensen@webkit.org>
610
611         <rdar://problem/50299396> Fix internal High Sierra build
612         https://bugs.webkit.org/show_bug.cgi?id=197388
613
614         * DumpRenderTree/mac/Configurations/Base.xcconfig:
615         * MiniBrowser/Configurations/Base.xcconfig:
616         * MobileMiniBrowser/Configurations/Base.xcconfig:
617         * TestWebKitAPI/Configurations/Base.xcconfig:
618         * WebKitTestRunner/Configurations/Base.xcconfig:
619
620 2019-04-29  Youenn Fablet  <youenn@apple.com>
621
622         Remove spurious GVA printf logging
623         https://bugs.webkit.org/show_bug.cgi?id=197368
624         <rdar://problem/35975256>
625
626         Reviewed by Alexey Proskuryakov.
627
628         * Scripts/webkitpy/port/mac.py:
629         (MacPort.logging_patterns_to_strip):
630
631 2019-04-29  Youenn Fablet  <youenn@apple.com>
632
633         getDisplayMedia should be called on user gesture
634         https://bugs.webkit.org/show_bug.cgi?id=197356
635         <rdar://problem/50296074>
636
637         Reviewed by Eric Carlson.
638
639         Update test configuration to inject internals
640         so that we can use it to simulate a user click to call getDisplayMedia.
641
642         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
643         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
644         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
645
646 2019-04-26  Stephanie Lewis  <slewis@apple.com>
647
648         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
649         https://bugs.webkit.org/show_bug.cgi?id=197339
650
651         Reviewed by Dewei Zhu.
652
653         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
654         test run for setup steps that are too expensive to do every iteration.
655
656         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
657         (BenchmarkRunner._run_benchmark):
658         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
659         (BrowserDriver):
660         (BrowserDriver.prepare_initial_env):
661         (BrowserDriver.restore_env_after_all_testing):
662         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
663         (LinuxBrowserDriver.prepare_initial_env):
664         (LinuxBrowserDriver.restore_env_after_all_testing):
665         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
666         (OSXBrowserDriver.prepare_initial_env):
667         (OSXBrowserDriver.restore_env_after_all_testing):
668
669 2019-04-28  Andy Estes  <aestes@apple.com>
670
671         Fix the watchOS engineering build.
672
673         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
674         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
675
676 2019-04-27  Chris Dumez  <cdumez@apple.com>
677
678         [WKTR] Move test timeout handling to the UIProcess
679         https://bugs.webkit.org/show_bug.cgi?id=197333
680
681         Reviewed by Darin Adler.
682
683         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
684         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
685         every WebContent process in the case of swapping.
686
687         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
688         would lead to crashes when firing the timer.
689
690         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
691         (WTR::InjectedBundle::didReceiveMessageToPage):
692         (WTR::InjectedBundle::done):
693         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
694         (WTR::InjectedBundle::shouldDumpPixels const):
695         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
696         (WTR::TestRunner::TestRunner):
697         (WTR::TestRunner::waitUntilDone):
698         (WTR::TestRunner::setWaitUntilDone):
699         * WebKitTestRunner/InjectedBundle/TestRunner.h:
700         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
701         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
702         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
703         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
704         * WebKitTestRunner/TestInvocation.cpp:
705         (WTR::TestInvocation::TestInvocation):
706         (WTR::TestInvocation::createTestSettingsDictionary):
707         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
708         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
709         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
710         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
711         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
712         (WTR::TestInvocation::setWaitUntilDone):
713         (WTR::TestInvocation::done):
714         * WebKitTestRunner/TestInvocation.h:
715
716 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
717
718         [JSC] linkPolymorphicCall now does GC
719         https://bugs.webkit.org/show_bug.cgi?id=197306
720
721         Reviewed by Saam Barati.
722
723         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
724         To add this test, we add `runWithoutBaseOption`.
725
726         * Scripts/run-jsc-stress-tests:
727
728 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
729
730         Update inactive reviewers' status to 'contributor'.
731
732         Accidentally skipped one at first.
733
734         * Scripts/webkitpy/common/config/contributors.json:
735
736 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
737
738         Update inactive reviewers' status to 'contributor'.
739
740         * Scripts/webkitpy/common/config/contributors.json: The change.
741
742         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
743         * Scripts/webkitpy/common/checkout/checkout_mock.py:
744         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
745         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
746         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
747         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
748         * Scripts/webkitpy/tool/commands/queries_unittest.py:
749         * Scripts/webkitpy/tool/commands/upload_unittest.py:
750         Sadly, regression tests operate on a crazy mix of mock and live data for
751         contributors.json. It would be a substantial project to mock all code paths,
752         so changing the tests instead.
753
754 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
755
756         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
757         https://bugs.webkit.org/show_bug.cgi?id=197171
758         <rdar://problem/47454979>
759
760         Reviewed by Youenn Fablet.
761
762         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
763         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
764         (TestWebKitAPI::TEST):
765
766 2019-04-26  David Kilzer  <ddkilzer@apple.com>
767
768         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
769         <https://webkit.org/b/197314>
770         <rdar://problem/50245252>
771
772         Reviewed by Simon Fraser.
773
774         * WebKitTestRunner/UIScriptControllerCocoa.mm:
775         (WTR::UIScriptController::lastUndoLabel const):
776         (WTR::UIScriptController::firstRedoLabel const):
777         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
778
779         * WebKitTestRunner/ios/HIDEventGenerator.mm:
780         (-[HIDEventGenerator sendEventStream:completionBlock:]):
781         - Call -autorelease to fix leak of NSDictionary.
782
783         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
784         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
785         (WTR::UIScriptController::selectFormPopoverTitle const):
786         (WTR::UIScriptController::textContentType const):
787         (WTR::UIScriptController::formInputLabel const):
788         (WTR::UIScriptController::scrollingTreeAsText const):
789         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
790
791 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
792
793         webkitpy: Running a single test will always use the default device
794         https://bugs.webkit.org/show_bug.cgi?id=195472
795         <rdar://problem/48724825>
796
797         Reviewed by Lucas Forschler.
798
799         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
800         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
801         requested will be run regardless of what shard they are in.
802
803         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
804         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
805         * Scripts/webkitpy/layout_tests/controllers/manager.py:
806         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
807         on the default device type.
808         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
809         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
810         (RunTest.test_run_part): Ditto.
811
812 2019-04-26  Alex Christensen  <achristensen@webkit.org>
813
814         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
815         https://bugs.webkit.org/show_bug.cgi?id=197165
816
817         Reviewed by Youenn Fablet.
818
819         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
820
821 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
822
823         Replace iOS build queue hardware
824         https://bugs.webkit.org/show_bug.cgi?id=197312
825
826         Reviewed by Aakash Jain.
827
828         * BuildSlaveSupport/build.webkit.org-config/config.json:
829         Use newer hardware that supports macOS Mojave.
830
831 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
832
833         check-webkit-style complains the first block in while loop.
834         https://bugs.webkit.org/show_bug.cgi?id=197307
835
836         The style checker shouldn't complain about an open brace on
837         its own line if the last non-whitespace character on the previous
838         non-blank line is another open brace, because it's likely to
839         indicate the begining of a nested code block.
840
841         Reviewed by Alex Christensen.
842
843         * Scripts/webkitpy/style/checkers/cpp.py:
844         (check_braces):
845         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
846         (WebKitStyleTest.test_braces):
847
848 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
849
850         Stop IDB transactions to release locked database files when network process is ready to suspend
851         https://bugs.webkit.org/show_bug.cgi?id=196372
852         <rdar://problem/48930116>
853
854         Reviewed by Brady Eidson.
855
856         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
857         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
858         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
859         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
860         (runTestAndCheckResult):
861         (keepNetworkProcessActive):
862         (TEST):
863
864 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
865
866         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
867         https://bugs.webkit.org/show_bug.cgi?id=188357
868         <rdar://problem/42986633>
869
870         Reviewed by Dean Jackson.
871
872         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
873         tests would fall into low memory mode and have different behavior.
874         
875         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
876         to Internals, so it's shared by DRT and WTR.
877         
878         We no longer need the WK2 C SPI glue.
879
880         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
881         (WTR::InjectedBundlePage::prepare):
882
883 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
884
885         webkitpy: Including skipped tests in the final count
886         https://bugs.webkit.org/show_bug.cgi?id=197298
887         <rdar://problem/49705424>
888
889         Reviewed by Lucas Forschler.
890
891         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
892         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
893
894 2019-04-25  Timothy Hatcher  <timothy@apple.com>
895
896         Disable date and time inputs on iOSMac.
897         https://bugs.webkit.org/show_bug.cgi?id=197287
898         rdar://problem/46794376
899
900         Reviewed by Wenson Hsieh.
901
902         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
903
904 2019-04-25  Alex Christensen  <achristensen@webkit.org>
905
906         Fix test-webkitpy after r244653
907         https://bugs.webkit.org/show_bug.cgi?id=197131
908
909         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
910         Also use C++17.
911
912 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
913
914         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
915         https://bugs.webkit.org/show_bug.cgi?id=196991
916         <rdar://problem/45507423>
917
918         Reviewed by Alex Christensen.
919
920         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
921         (-[NavigationTestDelegate init]):
922         (-[NavigationTestDelegate waitForDidFinishNavigation]):
923         (-[NavigationTestDelegate webView:didFinishNavigation:]):
924         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
925         (TestWebKitAPI::TEST):
926         (TEST): Deleted.
927
928 2019-04-25  Alex Christensen  <achristensen@webkit.org>
929
930         Revert some code accidentally committed with r244653
931         https://bugs.webkit.org/show_bug.cgi?id=197131
932
933         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
934         (TestWebKitAPI::TEST):
935
936 2019-04-25  Alex Christensen  <achristensen@webkit.org>
937
938         Start using C++17
939         https://bugs.webkit.org/show_bug.cgi?id=197131
940
941         Reviewed by Darin Adler.
942
943         * DumpRenderTree/mac/Configurations/Base.xcconfig:
944         * MiniBrowser/Configurations/Base.xcconfig:
945         * MobileMiniBrowser/Configurations/Base.xcconfig:
946         * TestWebKitAPI/Configurations/Base.xcconfig:
947         * WebKitTestRunner/Configurations/Base.xcconfig:
948
949 2019-04-25  Commit Queue  <commit-queue@webkit.org>
950
951         Unreviewed, rolling out r244627.
952         https://bugs.webkit.org/show_bug.cgi?id=197282
953
954         Causing internal build failures (Requested by ShawnRoberts on
955         #webkit).
956
957         Reverted changeset:
958
959         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
960         https://bugs.webkit.org/show_bug.cgi?id=197171
961         https://trac.webkit.org/changeset/244627
962
963 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
964
965         [GTK] Hardcoded text color in input fields
966         https://bugs.webkit.org/show_bug.cgi?id=126907
967
968         Reviewed by Michael Catanzaro.
969
970         Add dark-mode command line option to MiniBrowser.
971
972         * MiniBrowser/gtk/main.c:
973         (main):
974
975 2019-04-24  Zalan Bujtas  <zalan@apple.com>
976
977         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
978         https://bugs.webkit.org/show_bug.cgi?id=196948
979         <rdar://problem/49927131>
980
981         Reviewed by Tim Horton.
982
983         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
984         (TEST):
985         The expected order of incoming events is
986         1. didInvalidateIntrinsicContentSize
987         2. didFirstLayout
988         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
989         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
990         (and remember, all we care about is ordering).
991
992 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
993
994         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
995         https://bugs.webkit.org/show_bug.cgi?id=197171
996         <rdar://problem/47454979>
997
998         Reviewed by Youenn Fablet.
999
1000         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1001         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1002         (TestWebKitAPI::TEST):
1003
1004 2019-04-24  Brady Eidson  <beidson@apple.com>
1005
1006         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
1007         https://bugs.webkit.org/show_bug.cgi?id=191362
1008
1009         Reviewed by Alex Christensen.
1010
1011         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
1012           from an XHR to a custom protocol.
1013
1014 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
1015
1016         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
1017         https://bugs.webkit.org/show_bug.cgi?id=197273
1018
1019         Reviewed by Dean Jackson.
1020
1021         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
1022         so that WebCoreTestSupport::resetInternalsObject() is always run.
1023
1024         * DumpRenderTree/mac/DumpRenderTree.mm:
1025         (resetWebViewToConsistentStateBeforeTesting):
1026         (runTest):
1027
1028 2019-04-24  John Wilander  <wilander@apple.com>
1029
1030         Age out unconverted Ad Click Attributions after one week.
1031         https://bugs.webkit.org/show_bug.cgi?id=197238
1032         <rdar://problem/50177349>
1033
1034         Reviewed by Chris Dumez.
1035
1036         This patch adds infrastructure to allow tests to expire all unconverted
1037         attributions early.
1038
1039         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1040         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1041         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
1042         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1043         * WebKitTestRunner/TestController.cpp:
1044         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
1045         * WebKitTestRunner/TestController.h:
1046         * WebKitTestRunner/TestInvocation.cpp:
1047         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1048
1049 2019-04-24  Chris Dumez  <cdumez@apple.com>
1050
1051         Fix flaky crashes in a couple of PSON API tests
1052         https://bugs.webkit.org/show_bug.cgi?id=197239
1053
1054         Reviewed by Tim Horton.
1055
1056         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
1057
1058         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1059
1060 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
1061
1062         Make it possible to control the renderTreeAsText output by setting options on testRunner
1063         https://bugs.webkit.org/show_bug.cgi?id=197133
1064
1065         Reviewed by Sam Weinig.
1066
1067         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
1068         that make sense in testing (those that don't dump unstable data like addresses), and plumb
1069         these flags through the various framework layers.
1070
1071         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
1072
1073         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
1074         and hand-code DumpRenderTree bindings.
1075
1076         Some cleanup of the TestRunners, using member initializers.
1077
1078         * DumpRenderTree/TestRunner.cpp:
1079         (TestRunner::TestRunner):
1080         (setRenderTreeDumpOptionsCallback):
1081         (TestRunner::staticFunctions):
1082         (TestRunner::setRenderTreeDumpOptions):
1083         * DumpRenderTree/TestRunner.h:
1084         (TestRunner::renderTreeDumpOptions const):
1085         * DumpRenderTree/mac/DumpRenderTree.mm:
1086         (dump):
1087         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1088         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1089         (WTR::InjectedBundlePage::dump):
1090         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1091         (WTR::TestRunner::TestRunner):
1092         (WTR::TestRunner::setRenderTreeDumpOptions):
1093         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1094         (WTR::TestRunner::renderTreeDumpOptions const):
1095
1096 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1097
1098         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
1099         https://bugs.webkit.org/show_bug.cgi?id=197078
1100         <rdar://problem/49564348>
1101
1102         Reviewed by Geoff Garen.
1103
1104         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1105         (TEST_F):
1106         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
1107         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
1108         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
1109
1110 2019-04-24  Alex Christensen  <achristensen@webkit.org>
1111
1112         Add unit test for r239322
1113         https://bugs.webkit.org/show_bug.cgi?id=197236
1114
1115         Reviewed by Chris Dumez.
1116
1117         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
1118         May as well add the test infrastructure which was needed before and will be needed in the future.
1119
1120         * TestWebKitAPI/TCPServer.cpp:
1121         (TestWebKitAPI::TCPServer::TCPServer):
1122         * TestWebKitAPI/TCPServer.h:
1123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1124         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1125         (TestWebKitAPI::TEST):
1126         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1127         (TestWebKitAPI::downloadAtRate):
1128         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1129         (TEST):
1130         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
1131         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1132         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1133         (TestWebKitAPI::TEST):
1134         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1135         (TEST):
1136
1137 2019-04-24  Chris Dumez  <cdumez@apple.com>
1138
1139         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
1140         https://bugs.webkit.org/show_bug.cgi?id=197214
1141         <rdar://problem/49237544>
1142
1143         Reviewed by Alex Christensen.
1144
1145         Extend API test coverage.
1146
1147         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1148         (TEST):
1149
1150 2019-04-24  Philippe Normand  <pnormand@igalia.com>
1151
1152         [Build][GStreamer] Update to 1.16.0
1153         https://bugs.webkit.org/show_bug.cgi?id=197157
1154
1155         Reviewed by Xabier Rodriguez-Calvar.
1156
1157         The upstreamed patches were removed and a new one was added for a
1158         regression detected in the scaletempo GStreamer element. The GNOME
1159         Flatpak was migrated to 3.32 and I switched a few modules to Meson
1160         on the way, as it is the preferred build system now in GStreamer
1161         1.16.
1162
1163         * flatpak/files/httpd-autogen.sh:
1164         * flatpak/flatpakutils.py:
1165         (FlatpakPackage.install):
1166         (WebkitFlatpak.run_in_sandbox):
1167         * flatpak/org.webkit.CommonModules.yaml:
1168         * flatpak/org.webkit.WebKit.yaml:
1169         * gstreamer/jhbuild.modules:
1170         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
1171         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
1172         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
1173         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
1174         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
1175         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
1176         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
1177         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
1178         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
1179         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
1180         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
1181         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
1182         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
1183         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
1184         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
1185         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
1186         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
1187         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
1188         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
1189         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
1190         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
1191         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
1192
1193 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1194
1195         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
1196         https://bugs.webkit.org/show_bug.cgi?id=197156
1197
1198         Reviewed by Michael Catanzaro.
1199
1200         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
1201         support was added.
1202
1203         * MiniBrowser/gtk/BrowserTab.c:
1204         (browser_tab_set_background_color): Set the passed in color as web view background color.
1205         * MiniBrowser/gtk/BrowserTab.h:
1206         * MiniBrowser/gtk/BrowserWindow.c:
1207         (browser_window_init): Initialize backgroundColor.
1208         (browser_window_append_view): Call browser_tab_set_background_color().
1209         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
1210         are added.
1211         * MiniBrowser/gtk/main.c:
1212         (main): Call browser_window_set_background_color() before creating the tabs.
1213
1214 2019-04-23  John Wilander  <wilander@apple.com>
1215
1216         Move Ad Click Attribution from internal feature to experimental feature
1217         https://bugs.webkit.org/show_bug.cgi?id=197218
1218         <rdar://problem/47651691>
1219
1220         Reviewed by Brent Fulgham.
1221
1222         * DumpRenderTree/TestOptions.cpp:
1223         (TestOptions::TestOptions):
1224
1225 2019-04-23  Andy Estes  <aestes@apple.com>
1226
1227         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
1228         https://bugs.webkit.org/show_bug.cgi?id=196749
1229         <rdar://problem/35773454>
1230
1231         Reviewed by Daniel Bates.
1232
1233         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
1234
1235         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1236         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
1237         (-[QuickLookDelegate webView:didFinishNavigation:]):
1238         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
1239         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1240         (runTest):
1241         (runTestDecideBeforeLoading):
1242         (runTestDecideAfterLoading):
1243         (TEST):
1244
1245 2019-04-23  John Wilander  <wilander@apple.com>
1246
1247         Remove Ad Click Attribution data when removing website data
1248         https://bugs.webkit.org/show_bug.cgi?id=197215
1249         <rdar://problem/47668988>
1250
1251         Reviewed by Chris Dumez.
1252
1253         This patch adds test infrastructure to delete Ad Click Attribution data
1254         through WebsiteDataStore::removeData().
1255
1256         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1257         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1258         (WTR::TestRunner::clearAdClickAttribution):
1259         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
1260         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1261         * WebKitTestRunner/TestController.cpp:
1262         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1263         * WebKitTestRunner/TestController.h:
1264         * WebKitTestRunner/TestInvocation.cpp:
1265         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1266
1267 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
1268
1269         webkitpy: Kill unresponsive worker processes
1270         https://bugs.webkit.org/show_bug.cgi?id=197205
1271         <rdar://problem/50104388>
1272
1273         Reviewed by Lucas Forschler.
1274
1275         * Scripts/webkitpy/common/message_pool.py:
1276         (_MessagePool.__init__): Add close timeout.
1277         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
1278
1279 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1280
1281         Add unit tests for WKWebView.serverTrust
1282         https://bugs.webkit.org/show_bug.cgi?id=197202
1283
1284         Reviewed by Youenn Fablet
1285
1286         * TestWebKitAPI/TCPServer.cpp:
1287         (TestWebKitAPI::deleter<BIO>::operator()):
1288         (TestWebKitAPI::deleter<SSL>::operator()):
1289         (TestWebKitAPI::deleter<X509>::operator()):
1290         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
1291         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
1292         (TestWebKitAPI::TCPServer::TCPServer):
1293         (TestWebKitAPI::TCPServer::listenForConnections):
1294         * TestWebKitAPI/TCPServer.h:
1295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1296         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1297         (TestWebKitAPI::TEST):
1298         (verifyCertificateAndPublicKey):
1299         (-[ServerTrustDelegate webView:didFinishNavigation:]):
1300         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1301         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1302         (TestWebKitAPI::downloadAtRate):
1303         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1304         (TEST):
1305         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1306         (TEST):
1307
1308 2019-04-23  Commit Queue  <commit-queue@webkit.org>
1309
1310         Unreviewed, rolling out r244556.
1311         https://bugs.webkit.org/show_bug.cgi?id=197212
1312
1313         Causing build failures on multiple builders (Requested by
1314         ShawnRoberts on #webkit).
1315
1316         Reverted changeset:
1317
1318         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
1319         https://bugs.webkit.org/show_bug.cgi?id=197171
1320         https://trac.webkit.org/changeset/244556
1321
1322 2019-04-23  Alex Christensen  <achristensen@webkit.org>
1323
1324         Fix iOS build.
1325         https://bugs.webkit.org/show_bug.cgi?id=195537
1326
1327         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1328         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1329         AdoptWK constructor is private now.  Use adoptWK instead.
1330
1331 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
1332
1333         Accessibility text search and selection API enhancements.
1334         https://bugs.webkit.org/show_bug.cgi?id=197095
1335         <rdar://problem/48181791>
1336
1337         Reviewed by Chris Fleizach.
1338
1339         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
1340
1341         * DumpRenderTree/AccessibilityTextMarker.h:
1342         * DumpRenderTree/AccessibilityUIElement.cpp:
1343         (searchTextWithCriteriaCallback):
1344         (AccessibilityUIElement::getJSClass):
1345         * DumpRenderTree/AccessibilityUIElement.h:
1346         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1347         (convertVectorToObjectArray):
1348         (convertNSArrayToVector):
1349         (searchTextParameterizedAttributeForCriteria):
1350         (AccessibilityUIElement::getLinkedUIElements):
1351         (AccessibilityUIElement::getDocumentLinks):
1352         (AccessibilityUIElement::getChildren):
1353         (AccessibilityUIElement::getChildrenWithRange):
1354         (AccessibilityUIElement::rowHeaders const):
1355         (AccessibilityUIElement::columnHeaders const):
1356         (AccessibilityUIElement::uiElementArrayAttributeValue const):
1357         (AccessibilityUIElement::searchTextWithCriteria):
1358         (AccessibilityUIElement::attributesOfColumnHeaders):
1359         (AccessibilityUIElement::attributesOfRowHeaders):
1360         (AccessibilityUIElement::attributesOfColumns):
1361         (AccessibilityUIElement::attributesOfRows):
1362         (AccessibilityUIElement::attributesOfVisibleCells):
1363         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1364         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1365         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1366         (WTR::convertVectorToObjectArray):
1367         (WTR::convertNSArrayToVector):
1368         (WTR::searchTextParameterizedAttributeForCriteria):
1369         (WTR::AccessibilityUIElement::getLinkedUIElements):
1370         (WTR::AccessibilityUIElement::getDocumentLinks):
1371         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1372         (WTR::AccessibilityUIElement::getChildren):
1373         (WTR::AccessibilityUIElement::getChildrenWithRange):
1374         (WTR::AccessibilityUIElement::rowHeaders const):
1375         (WTR::AccessibilityUIElement::columnHeaders const):
1376         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
1377         (WTR::AccessibilityUIElement::searchTextWithCriteria):
1378         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1379         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1380         (WTR::AccessibilityUIElement::attributesOfColumns):
1381         (WTR::AccessibilityUIElement::attributesOfRows):
1382         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1383         (WTR::convertElementsToObjectArray): Deleted.
1384
1385 2019-04-23  Guy Lewin  <guy@lewin.co.il>
1386
1387         Multiple File Input Icon Set Regardless of File List
1388         https://bugs.webkit.org/show_bug.cgi?id=195537
1389
1390         Reviewed by Alexey Proskuryakov.
1391
1392         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
1393         display string in iOS file inputs
1394
1395         * DumpRenderTree/TestRunner.cpp:
1396         (SetOpenPanelFilesMediaIconCallback):
1397         (TestRunner::staticFunctions):
1398         (TestRunner::setOpenPanelFilesMediaIcon):
1399         * DumpRenderTree/TestRunner.h:
1400         (TestRunner::openPanelFilesMediaIcon const):
1401         * DumpRenderTree/mac/UIDelegate.mm:
1402         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
1403         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1404         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1405         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
1406         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1407         * WebKitTestRunner/TestController.cpp:
1408         (WTR::runOpenPanel):
1409         (WTR::TestController::resetStateToConsistentValues):
1410         * WebKitTestRunner/TestController.h:
1411         (WTR::TestController::openPanelFileURLsMediaIcon const):
1412         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
1413         * WebKitTestRunner/TestInvocation.cpp:
1414         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1415
1416 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
1417
1418         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
1419         https://bugs.webkit.org/show_bug.cgi?id=197171
1420         <rdar://problem/47454979>
1421
1422         Reviewed by Youenn Fablet.
1423
1424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1425         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
1426         (TestWebKitAPI::TEST):
1427
1428 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1429
1430         [ews-build] Add unit tests for UnApplyPatchIfRequired
1431         https://bugs.webkit.org/show_bug.cgi?id=197197
1432
1433         Reviewed by Lucas Forschler.
1434
1435         * BuildSlaveSupport/ews-build/steps_unittest.py:
1436         (TestUnApplyPatchIfRequired):
1437         (TestUnApplyPatchIfRequired.test_success):
1438         (TestUnApplyPatchIfRequired.test_failure):
1439         (TestUnApplyPatchIfRequired.test_skip):
1440
1441 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1442
1443         [ews-build] Add unit tests for CleanWorkingDirectory
1444         https://bugs.webkit.org/show_bug.cgi?id=197195
1445
1446         Reviewed by Lucas Forschler.
1447
1448         * BuildSlaveSupport/ews-build/steps_unittest.py:
1449         (TestCleanWorkingDirectory):
1450         (TestCleanWorkingDirectory.test_success):
1451         (TestCleanWorkingDirectory.test_failure):
1452
1453 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1454
1455         [ews-build] Use explicit imports instead of wildcard imports
1456         https://bugs.webkit.org/show_bug.cgi?id=197194
1457
1458         Reviewed by Lucas Forschler.
1459
1460         * BuildSlaveSupport/ews-build/factories.py:
1461         * BuildSlaveSupport/ews-build/loadConfig.py:
1462         * BuildSlaveSupport/ews-build/steps_unittest.py:
1463
1464 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1465
1466         [ews-build] Add unit tests for DownloadBuiltProduct
1467         https://bugs.webkit.org/show_bug.cgi?id=197193
1468
1469         Reviewed by Lucas Forschler.
1470
1471         * BuildSlaveSupport/ews-build/steps_unittest.py:
1472         (TestDownloadBuiltProduct):
1473         (TestDownloadBuiltProduct.setUp):
1474         (TestDownloadBuiltProduct.tearDown):
1475         (TestDownloadBuiltProduct.test_success):
1476         (TestDownloadBuiltProduct.test_failure):
1477
1478 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1479
1480         [ews-app] Exception while loading status-bubble when no build step has started
1481         https://bugs.webkit.org/show_bug.cgi?id=196676
1482
1483         Reviewed by Lucas Forschler.
1484
1485         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1486         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1487
1488 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1489
1490         [PlayStation] Support running of JSC tests on remote playstation devices
1491         https://bugs.webkit.org/show_bug.cgi?id=197170
1492
1493         Reviewed by Ross Kirsling.
1494
1495         Script changes
1496
1497         * Scripts/run-javascriptcore-tests:
1498         (runJSCStressTests): Pass arguments for playstation to
1499         run-jsc-stress-tests
1500         * Scripts/run-jsc-stress-tests:
1501         Handle $hostOS=="playstation" for determineArchitecture, turning
1502         off $isFTLPlatform and runProfiler and defaulting test writer.
1503         * Scripts/webkitdirs.pm:
1504         (jscPath): PlayStation WebKit executables have .elf extension
1505         (executableProductDir): PlayStation builds on Windows hosts but
1506         uses bin directory rather than bin64/bin32 for executable output
1507         location.
1508         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1509
1510 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1511
1512         [CMake][Win] Use target oriented design for WebKit
1513         https://bugs.webkit.org/show_bug.cgi?id=197173
1514
1515         Reviewed by Alex Christensen.
1516
1517         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1518         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1519
1520 2019-04-23  Chris Dumez  <cdumez@apple.com>
1521
1522         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1523         https://bugs.webkit.org/show_bug.cgi?id=197097
1524         <rdar://problem/50048318>
1525
1526         Reviewed by Alex Christensen.
1527
1528         Add API test coverage.
1529
1530         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1531         (-[PSONScheme webView:startURLSchemeTask:]):
1532
1533 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1534
1535         [ATK] Implement AtkComponentIface scroll_to methods
1536         https://bugs.webkit.org/show_bug.cgi?id=196856
1537
1538         Reviewed by Michael Catanzaro.
1539
1540         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1541         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1542         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1543         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1544
1545 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1546
1547         [ews-build] Improve summary for UploadBuiltProduct step
1548         https://bugs.webkit.org/show_bug.cgi?id=197182
1549
1550         Reviewed by Lucas Forschler.
1551
1552         * BuildSlaveSupport/ews-build/steps.py:
1553         (UploadBuiltProduct): Added descriptionDone.
1554         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1555         * BuildSlaveSupport/ews-build/steps_unittest.py:
1556         (TestUploadBuiltProduct.test_success): Updated unit-test.
1557         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1558
1559 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1560
1561         [ews-build] Trigger queues only after uploading the archive
1562         https://bugs.webkit.org/show_bug.cgi?id=197180
1563
1564         Reviewed by Lucas Forschler.
1565
1566         * BuildSlaveSupport/ews-build/factories.py:
1567         (Factory.__init__):
1568         (BuildFactory.__init__): Remove trigger step from factories.
1569         (BuildFactory.propertiesToPassToTriggers): Deleted.
1570         * BuildSlaveSupport/ews-build/steps.py:
1571         (ConfigureBuild.__init__): Confiure triggers property.
1572         (Trigger): Step to trigger other queues.
1573         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1574         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1575
1576 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1577
1578         Deprecate WKContextCreateWithInjectedBundlePath
1579         https://bugs.webkit.org/show_bug.cgi?id=197169
1580
1581         Reviewed by Youenn Fablet.
1582
1583         * TestWebKitAPI/PlatformUtilities.cpp:
1584         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1585         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1586
1587 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1588
1589         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1590         https://bugs.webkit.org/show_bug.cgi?id=197093
1591         <rdar://problem/49708268>
1592
1593         Reviewed by Chris Dumez.
1594
1595         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1596         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1597         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1598         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1599         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1600
1601         * TestWebKitAPI/TCPServer.cpp:
1602         (TestWebKitAPI::TCPServer::TCPServer):
1603         (TestWebKitAPI::TCPServer::~TCPServer):
1604         (TestWebKitAPI::TCPServer::socketBindListen):
1605         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1606         * TestWebKitAPI/TCPServer.h:
1607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1608         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1609         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1610         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1611         (respondWithChallengeThenOK):
1612         (TestWebKitAPI::TEST):
1613         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1614         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1615         (TEST):
1616
1617 2019-04-22  Chris Dumez  <cdumez@apple.com>
1618
1619         Delayed WebProcessLaunch may break the _relatedWebView SPI
1620         https://bugs.webkit.org/show_bug.cgi?id=197160
1621
1622         Reviewed by Alex Christensen.
1623
1624         Add API test coverage.
1625
1626         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1627
1628 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1629
1630         Use curl to download packages for webkitpy autoinstaller
1631         https://bugs.webkit.org/show_bug.cgi?id=197164
1632
1633         Reviewed by Darin Adler.
1634
1635         * Scripts/webkitpy/common/system/autoinstall.py:
1636         (AutoInstaller._download): Use curl(1) to download packages necessary for
1637         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1638         errors which are not present when using curl(1).
1639
1640 2019-04-22  Chris Dumez  <cdumez@apple.com>
1641
1642         Unreviewed, rolling out r244502.
1643
1644         Caused crashes on the bots
1645
1646         Reverted changeset:
1647
1648         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1649         https://bugs.webkit.org/show_bug.cgi?id=197160
1650         https://trac.webkit.org/changeset/244502
1651
1652 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1653
1654         Unreviewed, rolling out r244437.
1655
1656         Still breaks internal tests.
1657
1658         Reverted changeset:
1659
1660         "InjectedBundle parameters often need initialization function
1661         called before unarchiving"
1662         https://bugs.webkit.org/show_bug.cgi?id=189709
1663         https://trac.webkit.org/changeset/244437
1664
1665 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1666
1667         [ews-build] Use singular verb in failure description in case of single api test failure
1668         https://bugs.webkit.org/show_bug.cgi?id=197013
1669
1670         Reviewed by Lucas Forschler.
1671
1672         * BuildSlaveSupport/ews-build/steps.py:
1673         (AnalyzeAPITestsResults.analyzeResults):
1674
1675 2019-04-22  Chris Dumez  <cdumez@apple.com>
1676
1677         Delayed WebProcessLaunch may break the _relatedWebView SPI
1678         https://bugs.webkit.org/show_bug.cgi?id=197160
1679
1680         Reviewed by Alex Christensen.
1681
1682         Add API test coverage.
1683
1684         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1685
1686 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1687
1688         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1689         https://bugs.webkit.org/show_bug.cgi?id=194630
1690
1691         Reviewed by Michael Catanzaro.
1692
1693         Return early from getAttributeSet() is passed in accessible is nullptr.
1694
1695         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1696
1697 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1698
1699         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1700         https://bugs.webkit.org/show_bug.cgi?id=197145
1701         <rdar://problem/50078170>
1702
1703         Reviewed by Darin Adler.
1704
1705         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1706         focus, or showing the font manager.
1707
1708         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1709         (TestWebKitAPI::TEST):
1710         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1711         (TEST):
1712         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1713         (TestWebKitAPI::TEST):
1714
1715 2019-04-21  Brian Burg  <bburg@apple.com>
1716
1717         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1718         https://bugs.webkit.org/show_bug.cgi?id=197125
1719         <rdar://problem/50061468>
1720
1721         Reviewed by Darin Adler.
1722
1723         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1724         using this class rather than making our own ./wpt serve invocation.
1725
1726         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1727         (WebDriverW3CWebServer):
1728         (WebDriverW3CWebServer.document_root): Expose this to clients.
1729         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1730
1731         (WebDriverW3CWebServer.__enter__):
1732         (WebDriverW3CWebServer.__exit__):
1733         Make it possible to use the web server with a 'with' statement.
1734
1735 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1736
1737         [CMake][Win] Use target oriented design for WebKitLegacy
1738         https://bugs.webkit.org/show_bug.cgi?id=197112
1739
1740         Reviewed by Konstantin Tokarev.
1741
1742         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1743
1744         * DumpRenderTree/CMakeLists.txt:
1745         * DumpRenderTree/PlatformWin.cmake:
1746         * DumpRenderTree/win/EventSender.cpp:
1747
1748 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1749
1750         Update text for old EWS submit button
1751         https://bugs.webkit.org/show_bug.cgi?id=197140
1752
1753         Reviewed by Alexey Proskuryakov.
1754
1755         * QueueStatusServer/templates/statusbubble.html:
1756
1757 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1758
1759         [ews-app] New EWS should poll bugzilla more frequently
1760         https://bugs.webkit.org/show_bug.cgi?id=197138
1761
1762         Reviewed by Alexey Proskuryakov.
1763
1764         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1765         (FetchLoop.__init__):
1766
1767 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1768
1769         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1770         https://bugs.webkit.org/show_bug.cgi?id=197139
1771
1772         Reviewed by Alexey Proskuryakov.
1773
1774         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1775         * QueueStatusServer/templates/statusbubble.html:
1776
1777 2019-04-20  Chris Dumez  <cdumez@apple.com>
1778
1779         Unreviewed, fix iOS build with recent SDKs.
1780
1781         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1782
1783 2019-04-19  Keith Miller  <keith_miller@apple.com>
1784
1785         Add script to merge run_benchmark jsons
1786         https://bugs.webkit.org/show_bug.cgi?id=197107
1787
1788         Reviewed by Michael Saboff.
1789
1790         The script basically recursively decends through all json objects until it gets
1791         to an array or JSON primitive and concats or takes the first value, respectively.
1792
1793         This patch also adds +x bits to the compare-results script so it
1794         can be run directly from the command line. I had to add a new line so that svn
1795         will accept the change... yay svn!
1796
1797         * Scripts/compare-results:
1798         * Scripts/merge-result-jsons: Added.
1799         (readJSONFile):
1800         (deepAppend):
1801         (mergeJSONs):
1802         (main):
1803
1804 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1805
1806         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1807         https://bugs.webkit.org/show_bug.cgi?id=197079
1808
1809         Reviewed by Darin Adler.
1810
1811         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1812
1813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1814         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1815
1816 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1817
1818         Unreviewed, rolling out r244434.
1819         https://bugs.webkit.org/show_bug.cgi?id=197089
1820
1821         caused 1 API test failure (Requested by zalan on #webkit).
1822
1823         Reverted changeset:
1824
1825         "Regression (r244291): Broken API Test
1826         AutoLayoutRenderingProgressRelativeOrdering"
1827         https://bugs.webkit.org/show_bug.cgi?id=196948
1828         https://trac.webkit.org/changeset/244434
1829
1830 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1831
1832         Add new compatibility mode API on WKNavigation
1833         https://bugs.webkit.org/show_bug.cgi?id=197069
1834         <rdar://problem/50025800>
1835
1836         Reviewed by Tim Horton.
1837
1838         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1839
1840         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1841         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1842         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1843
1844 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1845
1846         [CMake] Make WebCore headers copies
1847         https://bugs.webkit.org/show_bug.cgi?id=182512
1848         <rdar://problem/37510435>
1849
1850         Reviewed by Alex Christensen.
1851
1852         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1853         ports.
1854
1855         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1856         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1857
1858         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1859         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1860         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1861         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1862         * TestWebKitAPI/CMakeLists.txt:
1863         * TestWebKitAPI/PlatformWin.cmake:
1864         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1865         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1866         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1867
1868 2019-04-18  Jer Noble  <jer.noble@apple.com>
1869
1870         Add support for parsing FairPlayStreaming PSSH boxes.
1871         https://bugs.webkit.org/show_bug.cgi?id=197064
1872
1873         Reviewed by Eric Carlson.
1874
1875         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1876         (TestWebKitAPI::TEST):
1877
1878 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1879
1880         InjectedBundle parameters often need initialization function called before unarchiving
1881         https://bugs.webkit.org/show_bug.cgi?id=189709
1882         <rdar://problem/44573653>
1883
1884         Reviewed by Ryosuke Niwa.
1885
1886         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1887         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1888
1889 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1890
1891         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1892         https://bugs.webkit.org/show_bug.cgi?id=196948
1893         <rdar://problem/49927131>
1894
1895         Reviewed by Tim Horton.
1896
1897         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1898         (TEST): 
1899         The expected order of incoming events is
1900         1. didInvalidateIntrinsicContentSize
1901         2. didFirstLayout
1902         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1903         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1904         (and remember, all we care about is ordering).
1905
1906 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1907
1908         Unreviewed, rolling out r244299.
1909
1910         Breaks internal tests.
1911
1912         Reverted changeset:
1913
1914         "InjectedBundle parameters often need initialization function
1915         called before unarchiving"
1916         https://bugs.webkit.org/show_bug.cgi?id=189709
1917         https://trac.webkit.org/changeset/244299
1918
1919 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1920
1921         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1922         https://bugs.webkit.org/show_bug.cgi?id=197053
1923
1924         Reviewed by Saam Barati.
1925
1926         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1927         (TestWebKitAPI::TEST):
1928
1929 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1930
1931         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1932         https://bugs.webkit.org/show_bug.cgi?id=197028
1933         <rdar://problem/49985290>
1934
1935         Reviewed by Wenson Hsieh.
1936
1937         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1938         (TEST):
1939         Liberal application of waitForNextPresentationUpdate works around a race
1940         where if the page rapidly changes its viewport arguments (or an API client
1941         rapidly changes its viewport arguments), we'd get stuck thinking that the
1942         user had intentionally zoomed the page, and stop resetting the initial scale.
1943         This deserves a separate bug, but no need to keep the test failing while
1944         we think about it.
1945
1946 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1947
1948         REGRESSION (r241988): Switching tabs is slow
1949         https://bugs.webkit.org/show_bug.cgi?id=197037
1950         <rdar://problem/49951473>
1951
1952         Reviewed by Simon Fraser.
1953
1954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1955         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1956         (TEST):
1957         * TestWebKitAPI/cocoa/TestWKWebView.h:
1958         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1959         (-[TestWKWebView addToTestWindow]):
1960         Add a test that hangs without this fix.
1961
1962 2019-04-17  Truitt Savell  <tsavell@apple.com>
1963
1964         Unreviewed, rolling out r244400.
1965
1966         Caused testing to exit early with assertionon Debug WK2
1967
1968         Reverted changeset:
1969
1970         "UI↔Web deadlock when printing with a JavaScript alert
1971         visible"
1972         https://bugs.webkit.org/show_bug.cgi?id=196839
1973         https://trac.webkit.org/changeset/244400
1974
1975 2019-04-17  Brady Eidson  <beidson@apple.com>
1976
1977         Link clicks in PDFs shouldn't send referrer headers.
1978         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1979
1980         Reviewed by Tim Horton.
1981
1982         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1983         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1984         (putPDFBytesCallback):
1985         (emptyReleaseInfoCallback):
1986         (createPDFWithLinkToURL):
1987         (TEST):
1988
1989 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1990
1991         UI↔Web deadlock when printing with a JavaScript alert visible
1992         https://bugs.webkit.org/show_bug.cgi?id=196839
1993         <rdar://problem/49157642>
1994
1995         Reviewed by Andy Estes.
1996
1997         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1998         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1999         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2000         (TEST):
2001
2002 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2003
2004         WKRetainPtr's adoption constructor should be private
2005         https://bugs.webkit.org/show_bug.cgi?id=197019
2006
2007         Reviewed by Tim Horton.
2008
2009         * DumpRenderTree/mac/DumpRenderTree.mm:
2010         (dumpFramesAsText):
2011         * TestWebKitAPI/InjectedBundleController.cpp:
2012         (TestWebKitAPI::InjectedBundleController::initialize):
2013         * TestWebKitAPI/PlatformUtilities.cpp:
2014         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2015         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
2016         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2017         (TestWebKitAPI::Util::toWK):
2018         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2019         (TestWebKitAPI::TEST):
2020         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2021         (TestWebKitAPI::TEST):
2022         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2023         (TestWebKitAPI::TEST):
2024         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
2025         (TestWebKitAPI::TEST):
2026         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
2027         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2028         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
2029         (TestWebKitAPI::TEST):
2030         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
2031         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2032         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
2033         (TestWebKitAPI::TEST):
2034         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
2035         (TestWebKitAPI::TEST):
2036         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2037         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2038         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
2039         (TestWebKitAPI::TEST):
2040         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2041         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2042         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2043         (TestWebKitAPI::TEST):
2044         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2045         (TestWebKitAPI::TEST):
2046         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2047         (TestWebKitAPI::TEST):
2048         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2049         (TestWebKitAPI::TEST):
2050         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2051         (TestWebKitAPI::TEST):
2052         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2053         (TestWebKitAPI::TEST):
2054         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2055         (TestWebKitAPI::TEST):
2056         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
2057         (TestWebKitAPI::TEST):
2058         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2059         (TestWebKitAPI::TEST):
2060         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2061         (TestWebKitAPI::TEST):
2062         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2063         (TestWebKitAPI::TEST):
2064         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2065         (TestWebKitAPI::TEST):
2066         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2067         (TestWebKitAPI::TEST):
2068         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
2069         (TestWebKitAPI::TEST):
2070         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
2071         (TestWebKitAPI::TEST):
2072         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
2073         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2074         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
2075         (TestWebKitAPI::TEST):
2076         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
2077         (TestWebKitAPI::TEST):
2078         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
2079         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
2080         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
2081         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
2082         (TestWebKitAPI::TEST):
2083         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
2084         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
2085         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
2086         (TestWebKitAPI::TEST):
2087         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
2088         (TestWebKitAPI::TEST):
2089         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2090         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2091         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2092         (TestWebKitAPI::TEST):
2093         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2094         (TestWebKitAPI::loadAlternateHTMLString):
2095         (TestWebKitAPI::TEST):
2096         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
2097         (TestWebKitAPI::TEST):
2098         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2099         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2100         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2101         (TestWebKitAPI::buildAndPerformTest):
2102         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2103         (TestWebKitAPI::TEST):
2104         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
2105         (TestWebKitAPI::TEST):
2106         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
2107         (TestWebKitAPI::TEST):
2108         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2109         (TestWebKitAPI::TEST):
2110         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2111         (TestWebKitAPI::TEST):
2112         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2113         (TestWebKitAPI::TEST):
2114         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2115         (TestWebKitAPI::TEST):
2116         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2117         (TestWebKitAPI::TEST):
2118         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
2119         (TestWebKitAPI::TEST):
2120         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2121         (TestWebKitAPI::TEST):
2122         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2123         (TestWebKitAPI::TEST):
2124         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2125         (TestWebKitAPI::TEST):
2126         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2127         (TestWebKitAPI::TEST):
2128         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2129         (TestWebKitAPI::TEST):
2130         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2131         (TestWebKitAPI::TEST):
2132         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2133         (TestWebKitAPI::TEST):
2134         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2135         (TestWebKitAPI::TEST):
2136         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2137         (TestWebKitAPI::TEST):
2138         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2139         (TestWebKitAPI::TEST):
2140         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2141         (TestWebKitAPI::TEST):
2142         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
2143         (TestWebKitAPI::TEST):
2144         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
2145         (TestWebKitAPI::TEST):
2146         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2147         (TestWebKitAPI::TEST):
2148         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2149         (TestWebKitAPI::TEST):
2150         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2151         (TestWebKitAPI::TEST):
2152         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2153         (TestWebKitAPI::TEST):
2154         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2155         (TestWebKitAPI::TEST):
2156         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2157         (TestWebKitAPI::TEST):
2158         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2159         (TestWebKitAPI::TEST):
2160         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2161         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2162         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
2163         (TestWebKitAPI::TEST):
2164         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
2165         (TestWebKitAPI::TEST):
2166         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
2167         (TestWebKitAPI::TEST):
2168         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
2169         (TestWebKitAPI::TEST):
2170         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2171         (TestWebKitAPI::TEST):
2172         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2173         (TestWebKitAPI::TEST):
2174         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
2175         (TestWebKitAPI::TEST):
2176         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2177         (TestWebKitAPI::TEST):
2178         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2179         (TestWebKitAPI::TEST):
2180         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2181         (TestWebKitAPI::TEST):
2182         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
2183         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
2184         (TEST):
2185         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2186         (TEST):
2187         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2188         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2189         (TEST):
2190         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
2191         (TestWebKitAPI::TEST):
2192         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2193         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2194         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2195         (WTR::getMenuItemTitleCallback):
2196         (WTR::createMouseMessageBody):
2197         (WTR::EventSendingController::mouseDown):
2198         (WTR::EventSendingController::mouseUp):
2199         (WTR::EventSendingController::mouseMoveTo):
2200         (WTR::EventSendingController::mouseForceClick):
2201         (WTR::EventSendingController::startAndCancelMouseForceClick):
2202         (WTR::EventSendingController::mouseForceDown):
2203         (WTR::EventSendingController::mouseForceUp):
2204         (WTR::EventSendingController::mouseForceChanged):
2205         (WTR::EventSendingController::leapForward):
2206         (WTR::EventSendingController::scheduleAsynchronousClick):
2207         (WTR::createKeyDownMessageBody):
2208         (WTR::EventSendingController::keyDown):
2209         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2210         (WTR::EventSendingController::mouseScrollBy):
2211         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2212         (WTR::EventSendingController::continuousMouseScrollBy):
2213         (WTR::EventSendingController::addTouchPoint):
2214         (WTR::EventSendingController::updateTouchPoint):
2215         (WTR::EventSendingController::setTouchModifier):
2216         (WTR::EventSendingController::setTouchPointRadius):
2217         (WTR::EventSendingController::touchStart):
2218         (WTR::EventSendingController::touchMove):
2219         (WTR::EventSendingController::touchEnd):
2220         (WTR::EventSendingController::touchCancel):
2221         (WTR::EventSendingController::clearTouchPoints):
2222         (WTR::EventSendingController::releaseTouchPoint):
2223         (WTR::EventSendingController::cancelTouchPoint):
2224         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2225         (WTR::InjectedBundle::didCreatePage):
2226         (WTR::InjectedBundle::didReceiveMessage):
2227         (WTR::InjectedBundle::didReceiveMessageToPage):
2228         (WTR::InjectedBundle::booleanForKey):
2229         (WTR::InjectedBundle::done):
2230         (WTR::InjectedBundle::dumpToStdErr):
2231         (WTR::InjectedBundle::outputText):
2232         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2233         (WTR::InjectedBundle::postAddChromeInputField):
2234         (WTR::InjectedBundle::postRemoveChromeInputField):
2235         (WTR::InjectedBundle::postFocusWebView):
2236         (WTR::InjectedBundle::postSetBackingScaleFactor):
2237         (WTR::InjectedBundle::postSetWindowIsKey):
2238         (WTR::InjectedBundle::postSetViewSize):
2239         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2240         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2241         (WTR::InjectedBundle::setGeolocationPermission):
2242         (WTR::InjectedBundle::setMockGeolocationPosition):
2243         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2244         (WTR::InjectedBundle::isGeolocationProviderActive const):
2245         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
2246         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
2247         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
2248         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
2249         (WTR::InjectedBundle::setCustomPolicyDelegate):
2250         (WTR::InjectedBundle::setHidden):
2251         (WTR::InjectedBundle::setCacheModel):
2252         (WTR::InjectedBundle::shouldProcessWorkQueue const):
2253         (WTR::InjectedBundle::processWorkQueue):
2254         (WTR::InjectedBundle::queueBackNavigation):
2255         (WTR::InjectedBundle::queueForwardNavigation):
2256         (WTR::InjectedBundle::queueLoad):
2257         (WTR::InjectedBundle::queueLoadHTMLString):
2258         (WTR::InjectedBundle::queueReload):
2259         (WTR::InjectedBundle::queueLoadingScript):
2260         (WTR::InjectedBundle::queueNonLoadingScript):
2261         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2262         (WTR::frameToStr):
2263         (WTR::InjectedBundlePage::InjectedBundlePage):
2264         (WTR::dumpFrameDescriptionSuitableForTestResult):
2265         (WTR::dumpFrameScrollPosition):
2266         (WTR::dumpDescendantFrameScrollPositions):
2267         (WTR::dumpFrameText):
2268         (WTR::dumpDescendantFramesText):
2269         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2270         (WTR::TestRunner::shouldDumpPixels const):
2271         (WTR::TestRunner::setDumpPixels):
2272         (WTR::TestRunner::whatToDump const):
2273         (WTR::TestRunner::setWhatToDump):
2274         (WTR::TestRunner::setWaitUntilDone):
2275         (WTR::TestRunner::shouldWaitUntilDone const):
2276         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
2277         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
2278         (WTR::TestRunner::clearAllDatabases):
2279         (WTR::TestRunner::setIDBPerOriginQuota):
2280         (WTR::TestRunner::originsWithApplicationCache):
2281         (WTR::TestRunner::setCanOpenWindows):
2282         (WTR::TestRunner::setXSSAuditorEnabled):
2283         (WTR::TestRunner::setMediaDevicesEnabled):
2284         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
2285         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
2286         (WTR::TestRunner::setCustomUserAgent):
2287         (WTR::TestRunner::setWebAPIStatisticsEnabled):
2288         (WTR::TestRunner::setModernMediaControlsEnabled):
2289         (WTR::TestRunner::setWebGL2Enabled):
2290         (WTR::TestRunner::setWritableStreamAPIEnabled):
2291         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
2292         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
2293         (WTR::TestRunner::setAllowsAnySSLCertificate):
2294         (WTR::TestRunner::setPluginsEnabled):
2295         (WTR::TestRunner::setValueForUser):
2296         (WTR::TestRunner::setAudioResult):
2297         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
2298         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
2299         (WTR::TestRunner::setAlwaysAcceptCookies):
2300         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2301         (WTR::TestRunner::isDoingMediaCapture const):
2302         (WTR::TestRunner::queueLoad):
2303         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2304         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2305         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
2306         (WTR::TestRunner::setShouldLogDownloadCallbacks):
2307         (WTR::TestRunner::setAuthenticationUsername):
2308         (WTR::TestRunner::setAuthenticationPassword):
2309         (WTR::TestRunner::secureEventInputIsEnabled const):
2310         (WTR::TestRunner::setBlockAllPlugins):
2311         (WTR::TestRunner::setPluginSupportedMode):
2312         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
2313         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
2314         (WTR::TestRunner::setNavigationGesturesEnabled):
2315         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2316         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
2317         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2318         (WTR::TestRunner::terminateNetworkProcess):
2319         (WTR::TestRunner::terminateServiceWorkerProcess):
2320         (WTR::TestRunner::runUIScript):
2321         (WTR::TestRunner::setStatisticsDebugMode):
2322         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
2323         (WTR::TestRunner::setStatisticsLastSeen):
2324         (WTR::TestRunner::setStatisticsPrevalentResource):
2325         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
2326         (WTR::TestRunner::dumpResourceLoadStatistics):
2327         (WTR::TestRunner::isStatisticsPrevalentResource):
2328         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
2329         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
2330         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
2331         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
2332         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
2333         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
2334         (WTR::TestRunner::setStatisticsGrandfathered):
2335         (WTR::TestRunner::isStatisticsGrandfathered):
2336         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
2337         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
2338         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
2339         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
2340         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
2341         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
2342         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2343         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
2344         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
2345         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2346         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2347         (WTR::TestRunner::statisticsSubmitTelemetry):
2348         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2349         (WTR::TestRunner::setStatisticsIsRunningTest):
2350         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2351         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2352         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2353         (WTR::TestRunner::setStatisticsGrandfatheringTime):
2354         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2355         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2356         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
2357         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2358         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
2359         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2360         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
2361         (WTR::TestRunner::statisticsResetToConsistentState):
2362         (WTR::TestRunner::setStorageAccessAPIEnabled):
2363         (WTR::TestRunner::getAllStorageAccessEntries):
2364         (WTR::TestRunner::addMockMediaDevice):
2365         (WTR::TestRunner::clearMockMediaDevices):
2366         (WTR::TestRunner::removeMockMediaDevice):
2367         (WTR::TestRunner::resetMockMediaDevices):
2368         (WTR::TestRunner::connectMockGamepad):
2369         (WTR::TestRunner::disconnectMockGamepad):
2370         (WTR::TestRunner::setMockGamepadDetails):
2371         (WTR::TestRunner::setMockGamepadAxisValue):
2372         (WTR::TestRunner::setMockGamepadButtonValue):
2373         (WTR::TestRunner::removeAllSessionCredentials):
2374         (WTR::TestRunner::clearDOMCache):
2375         (WTR::TestRunner::clearDOMCaches):
2376         (WTR::TestRunner::hasDOMCache):
2377         (WTR::TestRunner::domCacheSize):
2378         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2379         (WTR::TestRunner::getApplicationManifestThen):
2380         (WTR::TestRunner::injectUserScript):
2381         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
2382         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2383         (WTR::TestRunner::addTestKeyToKeychain):
2384         (WTR::TestRunner::cleanUpKeychain):
2385         (WTR::TestRunner::keyExistsInKeychain):
2386         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2387         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2388         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2389         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2390         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2391         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2392         * WebKitTestRunner/TestController.cpp:
2393         (WTR::TestController::initialize):
2394         (WTR::parseStringTestHeaderValueAsRelativePath):
2395         (WTR::updateTestOptionsFromTestHeader):
2396         (WTR::TestController::runTest):
2397         (WTR::TestController::didReceiveLiveDocumentsList):
2398         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2399         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2400         (WTR::TestController::didFinishNavigation):
2401         (WTR::TestController::didReceiveAuthenticationChallenge):
2402         * WebKitTestRunner/TestInvocation.cpp:
2403         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2404         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2405         (WTR::TestInvocation::uiScriptDidComplete):
2406         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
2407         * WebKitTestRunner/WebNotificationProvider.cpp:
2408         (WTR::WebNotificationProvider::closeWebNotification):
2409         * WebKitTestRunner/WorkQueueManager.cpp:
2410         (WTR::ScriptItem::ScriptItem):
2411         (WTR::WorkQueueManager::queueLoad):
2412         (WTR::WorkQueueManager::queueLoadHTMLString):
2413
2414 2019-04-17  Alex Christensen  <achristensen@webkit.org>
2415
2416         Add a comment to make my test from r244139 less mysterious.
2417         https://bugs.webkit.org/show_bug.cgi?id=196744
2418
2419         As suggested by Darin Adler.
2420
2421         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2422         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2423
2424 2019-04-17  Chris Dumez  <cdumez@apple.com>
2425
2426         Remember device orientation permission for the duration of the browsing session
2427         https://bugs.webkit.org/show_bug.cgi?id=196992
2428         <rdar://problem/49946067>
2429
2430         Reviewed by Alex Christensen.
2431
2432         Add API test coverage.
2433
2434         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2435         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2436         (TEST):
2437
2438 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
2439
2440         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
2441         https://bugs.webkit.org/show_bug.cgi?id=196675
2442
2443         Reviewed by Lucas Forschler.
2444
2445         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
2446         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
2447
2448 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2449
2450         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
2451         https://bugs.webkit.org/show_bug.cgi?id=196919
2452         <rdar://problem/41630459>
2453
2454         Reviewed by Tim Horton.
2455
2456         Add iOS support for several new testing hooks. See below for more detail.
2457
2458         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2459         (WTR::UIScriptController::isDismissingMenu const):
2460
2461         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
2462         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
2463         by UIKit when dismissing the callout bar (i.e. UIMenuController).
2464
2465         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2466         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2467         (WTR::UIScriptController::isDismissingMenu const):
2468         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2469         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2470         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2471         (WTR::InjectedBundle::didReceiveMessageToPage):
2472         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2473         (WTR::TestRunner::setAllowedMenuActions):
2474
2475         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2476         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2477         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2478         against the name of the custom action.
2479
2480         (WTR::TestRunner::installCustomMenuAction):
2481
2482         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2483         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2484         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2485         triggered.
2486
2487         (WTR::TestRunner::performCustomMenuAction):
2488
2489         Invoked when the custom menu action is triggered.
2490
2491         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2492         * WebKitTestRunner/TestController.cpp:
2493         (WTR::TestController::installCustomMenuAction):
2494         (WTR::TestController::setAllowedMenuActions):
2495         * WebKitTestRunner/TestController.h:
2496         * WebKitTestRunner/TestInvocation.cpp:
2497         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2498         (WTR::TestInvocation::performCustomMenuAction):
2499
2500         Add plumbing to call back into the injected bundle when performing the custom action.
2501
2502         * WebKitTestRunner/TestInvocation.h:
2503         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2504         (WTR::TestController::installCustomMenuAction):
2505         (WTR::TestController::setAllowedMenuActions):
2506         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2507         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2508         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2509         (-[TestRunnerWKWebView becomeFirstResponder]):
2510         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2511
2512         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2513         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2514         in the Mail app on iOS.
2515
2516         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2517         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2518         (-[TestRunnerWKWebView resetCustomMenuAction]):
2519         (-[TestRunnerWKWebView performCustomAction:]):
2520         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2521         (-[TestRunnerWKWebView _willHideMenu]):
2522         (-[TestRunnerWKWebView _didHideMenu]):
2523         * WebKitTestRunner/ios/TestControllerIOS.mm:
2524         (WTR::TestController::platformResetStateToConsistentValues):
2525
2526         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2527         if specified.
2528
2529         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2530         (WTR::UIScriptController::isDismissingMenu const):
2531
2532 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2533
2534         Allow sharing from imageSheet on an image document
2535         https://bugs.webkit.org/show_bug.cgi?id=196891
2536         <rdar://problem/25377386>
2537
2538         Reviewed by Tim Horton.
2539
2540         Test to make sure that the correct imageURL is extracted from an image element.
2541
2542         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2543         (TestWebKitAPI::TEST):
2544
2545 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2546
2547         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2548         https://bugs.webkit.org/show_bug.cgi?id=196995
2549
2550         Reviewed by Brady Eidson.
2551
2552         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2553         (TEST):
2554
2555 2019-04-16  Chris Dumez  <cdumez@apple.com>
2556
2557         URL set by document.open() is not communicated to the UIProcess
2558         https://bugs.webkit.org/show_bug.cgi?id=196941
2559         <rdar://problem/49237544>
2560
2561         Reviewed by Geoff Garen.
2562
2563         Add API test coverage.
2564
2565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2566         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2567         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2568         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2569         (TEST):
2570
2571 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2572
2573         Unreviewed, rolling out r244321.
2574         https://bugs.webkit.org/show_bug.cgi?id=196968
2575
2576         Causing all WK2 Debug builds to exit early after Assertion
2577         failures. (Requested by ShawnRoberts on #webkit).
2578
2579         Reverted changeset:
2580
2581         "URL set by document.open() is not communicated to the
2582         UIProcess"
2583         https://bugs.webkit.org/show_bug.cgi?id=196941
2584         https://trac.webkit.org/changeset/244321
2585
2586 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2587
2588         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2589         https://bugs.webkit.org/show_bug.cgi?id=196948
2590
2591         Reviewed by Zalan Bujtas.
2592
2593         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2594         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2595
2596 2019-04-15  Chris Dumez  <cdumez@apple.com>
2597
2598         URL set by document.open() is not communicated to the UIProcess
2599         https://bugs.webkit.org/show_bug.cgi?id=196941
2600         <rdar://problem/49237544>
2601
2602         Reviewed by Geoffrey Garen.
2603
2604         Add API test coverage.
2605
2606         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2607         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2608         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2609         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2610         (TEST):
2611
2612 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2613
2614         Using Tools/Scripts/clean-webkit should not install requests
2615         https://bugs.webkit.org/show_bug.cgi?id=196940
2616
2617         Reviewed by Lucas Forschler.
2618
2619         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2620         existing, depending on the path autoinstalled is run through.
2621         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2622         needed.
2623         (Port.configuration_for_upload):
2624         (Port.commits_for_upload):
2625
2626 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2627
2628         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2629         https://bugs.webkit.org/show_bug.cgi?id=196773
2630
2631         Reviewed by Jer Noble.
2632
2633         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2634         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2635         (TEST):
2636
2637 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2638
2639         ews-build should clearly indicate flaky test failures
2640         https://bugs.webkit.org/show_bug.cgi?id=196947
2641
2642         Reviewed by Lucas Forschler.
2643
2644         * BuildSlaveSupport/ews-build/steps.py:
2645         (AnalyzeAPITestsResults.analyzeResults):
2646
2647 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2648
2649         InjectedBundle parameters often need initialization function called before unarchiving
2650         https://bugs.webkit.org/show_bug.cgi?id=189709
2651         <rdar://problem/44573653>
2652
2653         Reviewed by Ryosuke Niwa.
2654
2655         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2656         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2657
2658 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2659
2660         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2661         https://bugs.webkit.org/show_bug.cgi?id=196681
2662
2663         Reviewed by Darin Adler.
2664
2665         Added tests.
2666
2667         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2668         (WTF_HashSet.RemoveIf):
2669         (WTF_HashSet.RemoveIfShrinkToBestSize):
2670
2671 2019-04-15  John Wilander  <wilander@apple.com>
2672
2673         Send delayed Ad Click Attribution conversion requests to the click source
2674         https://bugs.webkit.org/show_bug.cgi?id=196838
2675         <rdar://problem/47650157>
2676
2677         Reviewed by Chris Dumez and Youenn Fablet.
2678
2679         This patch adds test infrastructure to override the default behavior in
2680         WebKit::NetworkAdClickAttribution.
2681
2682         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2683         (TestWebKitAPI::TEST):
2684         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2685         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2686         (WTR::TestRunner::dumpAdClickAttribution):
2687         (WTR::TestRunner::clearAdClickAttribution):
2688         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2689         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2690         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2691         * WebKitTestRunner/TestController.cpp:
2692         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2693         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2694         * WebKitTestRunner/TestController.h:
2695         * WebKitTestRunner/TestInvocation.cpp:
2696         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2697
2698 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2699
2700         [ews-app] status-bubble should display position in queue
2701         https://bugs.webkit.org/show_bug.cgi?id=196607
2702
2703         Reviewed by Lucas Forschler.
2704
2705         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2706         (StatusBubble._build_bubble):
2707         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2708
2709 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2710
2711         [ews-build] Do not run clean build by default on EWS builders
2712         https://bugs.webkit.org/show_bug.cgi?id=196897
2713
2714         Reviewed by Lucas Forschler.
2715
2716         * BuildSlaveSupport/ews-build/steps.py:
2717         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2718         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2719         untracked directories like WebKitBuild).
2720         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2721         untracked files/directories (like WebKitBuild).
2722
2723 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2724
2725         TestRunner::notifyDone() should be safely reentrant
2726         https://bugs.webkit.org/show_bug.cgi?id=196898
2727
2728         Reviewed by Darin Adler.
2729
2730         It is currently possible that TestRunner::notifyDone() will call itself, since
2731         notifyDone() will force a repaint, which can start executing JavaScript, which
2732         may call notifyDone() again. This can lead to test failures and flakiness.
2733         Fix this by setting the m_waitToDump flag before calling the dump() method.
2734
2735         * DumpRenderTree/mac/TestRunnerMac.mm:
2736         (TestRunner::notifyDone):
2737         (TestRunner::forceImmediateCompletion):
2738         * DumpRenderTree/win/TestRunnerWin.cpp:
2739         (TestRunner::notifyDone):
2740         (TestRunner::forceImmediateCompletion):
2741
2742 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2743
2744         [GTK][WPE] Add enable-media websetting
2745         https://bugs.webkit.org/show_bug.cgi?id=196863
2746
2747         Reviewed by Michael Catanzaro.
2748
2749         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2750         (testWebKitSettings): Add test for the enable-media web-setting.
2751
2752 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2753
2754         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2755         https://bugs.webkit.org/show_bug.cgi?id=196905
2756         <rdar://problem/49886096>
2757
2758         Reviewed by Tim Horton.
2759
2760         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2761         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2762         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2763         delay timer, we end up with this sequence of events in the problematic (failure) case:
2764
2765         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2766             ...IPC from UI to web process...
2767         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2768             ...IPC from web to UI process...
2769         (c) [UI]    Invoke completion handler for script #1
2770         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2771             ...IPC from UI to web process...
2772         (e) [Web]   Evaluate script #2 in the web process
2773         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2774
2775         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2776         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2777         #2 is run in step (e).
2778
2779         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2780         the UI process by waiting on a script message posted by the web process, after attachment updates are
2781         dispatched.
2782
2783         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2784         (TestWebKitAPI::TEST):
2785
2786 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2787
2788         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2789         https://bugs.webkit.org/show_bug.cgi?id=196909
2790
2791         Reviewed by Wenson Hsieh.
2792
2793         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2794         (TestWebKitAPI::TEST):
2795
2796 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2797
2798         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2799         https://bugs.webkit.org/show_bug.cgi?id=196880
2800
2801         Reviewed by Yusuke Suzuki.
2802
2803         Add a new function for bytecode cache tests that does not forceDiskCache
2804         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2805         test added in this patch, since the code is invalid and therefore won't be
2806         cached. It should also be useful for tests that evaluate dynamically
2807         generated code.
2808
2809         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2810         * Scripts/run-jsc-stress-tests:
2811
2812 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2813
2814         Update AudioSession route sharing policy
2815         https://bugs.webkit.org/show_bug.cgi?id=196776
2816         <rdar://problem/46501611>
2817
2818         Reviewed by Jer Noble.
2819
2820         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2821         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2822         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2823         (TestWebKitAPI::TEST):
2824
2825 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2826
2827         [iOS] Software keyboard is shown too frequently on some websites
2828         https://bugs.webkit.org/show_bug.cgi?id=195856
2829         <rdar://problem/49191395>
2830
2831         Reviewed by Darin Adler.
2832
2833         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2834
2835         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2836         (WTR::UIScriptController::setHardwareKeyboardAttached):
2837         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2838         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2839         (WTR::UIScriptController::setHardwareKeyboardAttached):
2840         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2841         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2842
2843         Additionally link against GraphicsServices in WebKitTestRunner.
2844
2845         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2846         (WTR::TestController::platformResetStateToConsistentValues):
2847         (WTR::UIScriptController::setHardwareKeyboardAttached):
2848
2849 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2850
2851         [GTK][WPE] Fix pacman install-dependencies packages
2852         https://bugs.webkit.org/show_bug.cgi?id=196817
2853
2854         Reviewed by Žan Doberšek.
2855         
2856         python3-setuptools is called python-setuptools
2857         ruby-highline is only available on AUR
2858         libv4l-devel is incorporated in v4l-utils
2859
2860         * gtk/install-dependencies:
2861         * wpe/install-dependencies:
2862
2863 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2864
2865         [GTK] REGRESSION(r243860): Many tests failing
2866         https://bugs.webkit.org/show_bug.cgi?id=196791
2867
2868         Reviewed by Joanmarie Diggs.
2869
2870         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2871         multiple documents and check that accessibility hierarchy is updated after a navigation.
2872
2873         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2874         (loadChangedCallback):
2875         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2876         (AccessibilityTest::AccessibilityTest):
2877         (AccessibilityTest::~AccessibilityTest):
2878         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2879         (AccessibilityTest::findTestServerApplication):
2880         (AccessibilityTest::findDocumentWeb):
2881         (AccessibilityTest::findRootObject):
2882         (AccessibilityTest::waitUntilChildrenRemoved):
2883         (AccessibilityTest::ensureProxy):
2884         (testAtspiBasicHierarchy):
2885         (beforeAll):
2886         (afterAll):
2887
2888 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2889
2890         [ews-build] Handle bug titles with unicode characters
2891         https://bugs.webkit.org/show_bug.cgi?id=196802
2892
2893         Reviewed by Dewei Zhu.
2894
2895         * BuildSlaveSupport/ews-build/steps.py:
2896         (ValidatePatch._is_bug_closed):
2897
2898 2019-04-11  Michael Saboff  <msaboff@apple.com>
2899
2900         Improve the Inline Cache Stats code
2901         https://bugs.webkit.org/show_bug.cgi?id=196836
2902
2903         Reviewed by Saam Barati.
2904
2905         Added a new script to consolidate and arrange the output of --useICStats option.
2906
2907         This script merges the output from every group into one large table and sorts it from most common to
2908         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2909         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2910         Put together, this is useful to see what property accesses are not getting cached.
2911
2912         * Scripts/ic-stats.py: Added.
2913         (ICStats):
2914         (ICStats.__init__):
2915         (ICStats.parse):
2916         (ICStats.dumpStats):
2917         (usage):
2918
2919 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2920
2921         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2922         https://bugs.webkit.org/show_bug.cgi?id=196809
2923         <rdar://49800762>
2924
2925         Reviewed by Brady Eidson.
2926
2927         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2928         (TEST):
2929
2930 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2931
2932         requestAnimationFrame should execute before the next frame
2933         https://bugs.webkit.org/show_bug.cgi?id=177484
2934
2935         Reviewed by Simon Fraser.
2936
2937         Add trace points for the page RenderingUpdate.
2938
2939         * Tracing/SystemTracePoints.plist:
2940
2941 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2942
2943         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2944         https://bugs.webkit.org/show_bug.cgi?id=196760
2945
2946         Reviewed by Don Olmstead.
2947
2948         vswhere.exe has been bundled since Visual Studio 2017 version
2949         15.2. We shouldn't download vswhere.exe.
2950
2951         * Scripts/build-jsc: Do not call update-vswhere.py.
2952         * Scripts/build-webkit: Ditto.
2953         * Scripts/update-vswhere.py: Removed.
2954         * Scripts/webkitdirs.pm:
2955         (requireModulesForVSWhere): Deleted.
2956         (pickCurrentVisualStudioInstallation): Deleted.
2957         (visualStudioInstallDirVSWhere): Return the latest installed VS
2958         installation path by using the bundled vswhere.exe.
2959         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2960         (visualStudioInstallDirFallback): Removed.
2961
2962 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2963
2964         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2965         https://bugs.webkit.org/show_bug.cgi?id=196780
2966
2967         Reviewed by Alexey Proskuryakov.
2968
2969         * BuildSlaveSupport/ews-build/steps.py:
2970         * BuildSlaveSupport/ews-build/steps_unittest.py:
2971
2972 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2973
2974         Add SPI WKNavigationResponse._downloadAttribute
2975         https://bugs.webkit.org/show_bug.cgi?id=196755
2976         <rdar://49587365>
2977
2978         Reviewed by Brady Eidson.
2979
2980         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2981         (-[NavigationResponseTestDelegate navigationResponse]):
2982         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2983         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2984         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2985         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2986         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2987         (readRequest):
2988         (writeResponse):
2989         (TEST):
2990
2991 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2992
2993         Add modern API for overriding the page's specified viewport configuration
2994         https://bugs.webkit.org/show_bug.cgi?id=167734
2995         <rdar://problem/30331795>
2996
2997         Reviewed by Simon Fraser.
2998
2999         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3000         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
3001
3002 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
3003
3004         Add support for incremental bytecode cache updates
3005         https://bugs.webkit.org/show_bug.cgi?id=195000
3006
3007         Reviewed by Filip Pizlo.
3008
3009         Exit when the initial run to generate bytecode fails.
3010
3011         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
3012
3013 2019-04-10  Alex Christensen  <achristensen@webkit.org>
3014
3015         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
3016         https://bugs.webkit.org/show_bug.cgi?id=196744
3017         <rdar://49415309>
3018
3019         Reviewed by Chris Dumez.
3020
3021         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
3022         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3023
3024 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3025
3026         Add a way to opt into modern compatibility mode in layout tests
3027         https://bugs.webkit.org/show_bug.cgi?id=196770
3028         <rdar://problem/49777550>
3029
3030         Reviewed by Antoine Quint.
3031
3032         Add a new test option to enable modern compatibility mode in layout tests.
3033
3034         * WebKitTestRunner/TestController.cpp:
3035         (WTR::updateTestOptionsFromTestHeader):
3036         * WebKitTestRunner/TestController.h:
3037         * WebKitTestRunner/TestOptions.h:
3038         (WTR::TestOptions::hasSameInitializationOptions const):
3039         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3040         (WTR::TestController::platformCreateWebView):
3041         (WTR::TestController::enableModernCompatibilityMode):
3042
3043 2019-04-10  Andy Estes  <aestes@apple.com>
3044
3045         Try to fix the 32-bit watchOS build.
3046
3047         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3048         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3049
3050 2019-04-10  Antoine Quint  <graouts@apple.com>
3051
3052         Enable Pointer Events on watchOS
3053         https://bugs.webkit.org/show_bug.cgi?id=196771
3054         <rdar://problem/49040909>
3055
3056         Reviewed by Dean Jackson.
3057
3058         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3059
3060 2019-04-10  Philippe Normand  <pnormand@igalia.com>
3061
3062         Unreviewed. Fix WPE accessibility tests after r244059.
3063
3064         We are failing to load the injected bundle due to undefined symbol
3065         AccessibilityUIElement::replaceTextInRange().
3066
3067         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3068         (WTR::AccessibilityUIElement::replaceTextInRange):
3069
3070 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
3071
3072         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
3073         https://bugs.webkit.org/show_bug.cgi?id=196727
3074
3075         Reviewed by Fujii Hironori.
3076
3077         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3078         (WebKitBrowserWindow::create):
3079
3080 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
3081
3082         [ews-build] Add unit tests for PrintConfiguration
3083         https://bugs.webkit.org/show_bug.cgi?id=196752
3084
3085         Reviewed by Dewei Zhu.
3086
3087         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3088
3089 2019-04-09  Keith Rollin  <krollin@apple.com>
3090
3091         Unreviewed build maintenance -- update .xcfilelists.
3092
3093         * DumpRenderTree/DerivedSources-input.xcfilelist:
3094         * DumpRenderTree/DerivedSources-output.xcfilelist:
3095
3096 2019-04-09  Zalan Bujtas  <zalan@apple.com>
3097
3098         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
3099         https://bugs.webkit.org/show_bug.cgi?id=196743
3100         <rdar://problem/43897551>
3101
3102         Reviewed by Tim Horton.
3103
3104         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
3105         (TEST):
3106
3107 2019-04-09  Youenn Fablet  <youenn@apple.com>
3108
3109         Close service worker database on network process suspension
3110         https://bugs.webkit.org/show_bug.cgi?id=196623
3111         <rdar://problem/48930869>
3112
3113         Reviewed by Alex Christensen.
3114
3115         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3116
3117 2019-04-09  Daniel Bates  <dabates@apple.com>
3118
3119         [iPad] Should open popover when the spacebar is pressed
3120         https://bugs.webkit.org/show_bug.cgi?id=196360
3121         <rdar://problem/49389129>
3122
3123         Reviewed by Brent Fulgham.
3124
3125         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
3126
3127         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3128         (WTR::UIScriptController::isShowingPopover const): Added.
3129         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3130         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3131         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3132         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3133         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3134         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
3135         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
3136         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
3137         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
3138         (WTR::UIScriptController::isShowingPopover const): Added.
3139         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3140         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3141         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3142         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3143         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3144         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
3145         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
3146         (-[TestRunnerWKWebView _willPresentPopover]): Added.
3147         (-[TestRunnerWKWebView _didDismissPopover]): Added.
3148         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3149         (WTR::UIScriptController::isShowingPopover const): Added.
3150         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
3151         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
3152
3153 2019-04-09  Alex Christensen  <achristensen@webkit.org>
3154
3155         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3156         https://bugs.webkit.org/show_bug.cgi?id=196665
3157         <rdar://45115669>
3158
3159         Reviewed by Geoff Garen.
3160
3161         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3162         (goBack):
3163         (+[SimpleLookupContext sharedLookupContext]):
3164         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3165         (TEST):
3166         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3167         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3168
3169 2019-04-09  John Wilander  <wilander@apple.com>
3170
3171         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
3172         https://bugs.webkit.org/show_bug.cgi?id=196558
3173         <rdar://problem/47650245>
3174
3175         Reviewed by Youenn Fablet.
3176
3177         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3178         (TestWebKitAPI::TEST):
3179             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
3180
3181 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
3182
3183         [CMake] Apple builds should use ICU_INCLUDE_DIRS
3184         https://bugs.webkit.org/show_bug.cgi?id=196720
3185
3186         Reviewed by Konstantin Tokarev.
3187
3188         * TestWebKitAPI/PlatformMac.cmake:
3189
3190 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
3191
3192         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
3193         https://bugs.webkit.org/show_bug.cgi?id=196694
3194         <rdar://problem/48388734>
3195
3196         Rubber-stamped by Aakash Jain.
3197
3198         * Scripts/webkitpy/port/image_diff.py:
3199         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
3200         * Scripts/webkitpy/port/server_process.py:
3201         (ServerProcess.has_available_stdout): Check if stdout has data in it.
3202         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3203         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
3204         * Scripts/webkitpy/port/server_process_mock.py:
3205         (MockServerProcess.has_available_stdout):
3206         * Scripts/webkitpy/port/server_process_unittest.py:
3207         (TestServerProcess.serial_test_basic):
3208
3209 2019-04-09  Jer Noble  <jer.noble@apple.com>
3210
3211         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3212         https://bugs.webkit.org/show_bug.cgi?id=196097
3213
3214         Reviewed by Eric Carlson.
3215
3216         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3217
3218         * DumpRenderTree/mac/DumpRenderTree.mm:
3219         (resetWebPreferencesToConsistentValues):
3220         * WebKitTestRunner/TestController.cpp:
3221         (WTR::TestController::resetPreferencesToConsistentValues):
3222
3223 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
3224
3225         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
3226         https://bugs.webkit.org/show_bug.cgi?id=196690
3227
3228         Reviewed by Michael Catanzaro.
3229
3230         * QueueStatusServer/config/queues.py:
3231         * Scripts/webkitpy/common/config/ews.json:
3232         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3233         (test_ews_name):
3234
3235 2019-04-09  Chris Dumez  <cdumez@apple.com>
3236
3237         Loads using loadHTMLString() cause flashing when process-swapping
3238         https://bugs.webkit.org/show_bug.cgi?id=196714
3239         <rdar://problem/49637354>
3240
3241         Reviewed by Antti Koivisto.
3242
3243         Add API test coverage.
3244
3245         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3246
3247 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3248
3249         Unreviewed. Fix ATK accessibility tests after r244059.
3250
3251         We are failing to load the injected bundle due to undefined symbol
3252         AccessibilityUIElement::replaceTextInRange().
3253
3254         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3255         (WTR::AccessibilityUIElement::replaceTextInRange):
3256
3257 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3258
3259         AX: Support API: accessibilityReplaceRange:withText
3260         https://bugs.webkit.org/show_bug.cgi?id=196636
3261
3262         Unreviewed build fix for Windows port.
3263
3264         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
3265         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
3266
3267 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
3268
3269         [CMake][WinCairo] Separate copied headers into different directories
3270         https://bugs.webkit.org/show_bug.cgi?id=196655
3271
3272         Reviewed by Michael Catanzaro.
3273
3274         * DumpRenderTree/CMakeLists.txt:
3275         * MiniBrowser/win/CMakeLists.txt:
3276         * TestWebKitAPI/CMakeLists.txt:
3277         * TestWebKitAPI/PlatformWin.cmake:
3278
3279 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
3280
3281         Log stack-trace for run-webkit-tests when interrupted
3282         https://bugs.webkit.org/show_bug.cgi?id=176393
3283         <rdar://problem/34262310>
3284
3285         Reviewed by Lucas Forschler.
3286
3287         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
3288         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
3289         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
3290         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
3291         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
3292         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3293         (main): Set handlers to log stack trace on interruption.
3294
3295 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
3296
3297         AX: Support API: accessibilityReplaceRange:withText
3298         https://bugs.webkit.org/show_bug.cgi?id=196636
3299
3300         Unreviewed build fix for Windows port.
3301
3302         * DumpRenderTree/AccessibilityUIElement.cpp:
3303         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
3304
3305 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3306
3307         [ews-build] Scripts using Buildbot API have CORS error
3308         https://bugs.webkit.org/show_bug.cgi?id=196709
3309
3310         Reviewed by Alexey Proskuryakov.
3311
3312         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
3313
3314 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
3315
3316         AX: Support API: accessibilityReplaceRange:withText
3317         https://bugs.webkit.org/show_bug.cgi?id=196636
3318
3319         Reviewed by Daniel Bates.
3320
3321         * DumpRenderTree/AccessibilityUIElement.cpp:
3322         (replaceTextInRangeCallback):
3323         (AccessibilityUIElement::replaceTextInRange):
3324         (AccessibilityUIElement::getJSClass):
3325         * DumpRenderTree/AccessibilityUIElement.h:
3326         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3327         (AccessibilityUIElement::replaceTextInRange):
3328         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3329         (AccessibilityUIElement::replaceTextInRange):
3330         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3331         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3332         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3333         (WTR::AccessibilityUIElement::replaceTextInRange):
3334         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3335         (WTR::AccessibilityUIElement::replaceTextInRange):
3336
3337 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3338
3339         [iOS] Do not allow starting selection drags when selection views are not visible
3340         https://bugs.webkit.org/show_bug.cgi?id=196686
3341         <rdar://problem/49399192>
3342
3343         Reviewed by Tim Horton.
3344
3345         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
3346         also add some new API tests to cover scenarios where the web view is not first responder.
3347
3348         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3349         (TestWebKitAPI::TEST):
3350         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3351
3352         Add a switch to optionally make the web view first responder when starting the simulated drag.
3353
3354         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3355         (-[DragAndDropSimulator initWithWebView:]):
3356         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
3357
3358 2019-04-08  Justin Fan  <justin_fan@apple.com>
3359
3360         [Web GPU] Fix Web GPU experimental feature on iOS
3361         https://bugs.webkit.org/show_bug.cgi?id=196632
3362
3363         Reviewed by Myles C. Maxfield.
3364
3365         Properly make Web GPU available on iOS 11+.
3366
3367         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3368
3369 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
3370
3371         [ews-build] Do not upload archive when Compile Fails
3372         https://bugs.webkit.org/show_bug.cgi?id=196674
3373
3374         Reviewed by Alexey Proskuryakov.
3375
3376         * BuildSlaveSupport/ews-build/factories.py:
3377         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
3378         * BuildSlaveSupport/ews-build/steps.py:
3379         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
3380         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
3381         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
3382
3383 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
3384
3385         Enable DFG on MIPS
3386         https://bugs.webkit.org/show_bug.cgi?id=196689
3387
3388         Reviewed by Žan Doberšek.
3389
3390         Since the bytecode change, we enabled the baseline JIT on mips in
3391         r240432, but DFG is still missing. With this change, all tests are
3392         passing on a ci20 board.
3393
3394         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
3395
3396 2019-04-08  Philippe Normand  <pnormand@igalia.com>
3397
3398         [Flatpak] Second run update-webkitwpe-flatpak fails
3399         https://bugs.webkit.org/show_bug.cgi?id=192702
3400
3401         Reviewed by Carlos Garcia Campos.
3402
3403         * flatpak/flatpakutils.py:
3404         (FlatpakObject.flatpak): Fix typo.
3405         (FlatpakPackage.install): When installing, also update to the configured remote commit.
3406         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
3407
3408 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
3409
3410         [GTK][WPE] outlook.live.com displays old-fashioned UI
3411         https://bugs.webkit.org/show_bug.cgi?id=196642
3412
3413         Reviewed by Carlos Garcia Campos.
3414
3415         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3416         (TestWebKitAPI::TEST): New Mac platform quirk test.
3417
3418 2019-04-07  Commit Queue  <commit-queue@webkit.org>
3419
3420         Unreviewed, rolling out r243956.
3421         https://bugs.webkit.org/show_bug.cgi?id=196688
3422
3423         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
3424         by aakashjain on #webkit).
3425
3426         Reverted changeset:
3427
3428         "Clicking "Go Back" from a safe browsing warning from an
3429         iframe should navigate the WKWebView back to the previous
3430         page"
3431         https://bugs.webkit.org/show_bug.cgi?id=196665
3432         https://trac.webkit.org/changeset/243956
3433
3434 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
3435
3436         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
3437         https://bugs.webkit.org/show_bug.cgi?id=196669
3438
3439         Reviewed by Geoffrey Garen.
3440
3441         Added three new unit tests for WeakHashSet.
3442
3443         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3444         (WTF_WeakPtr.WeakHashSetConstObjects):
3445         (WTF_WeakPtr.WeakHashSetComputesEmpty):
3446         (WTF_WeakPtr.WeakHashSetComputeSize):
3447
3448 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3449
3450         Hide next and previous form control buttons when WKWebView is editable
3451         https://bugs.webkit.org/show_bug.cgi?id=196672
3452         <rdar://problem/35625321>
3453
3454         Reviewed by Tim Horton.
3455
3456         Add a new API test.
3457
3458         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3459         (-[TestWKWebView lastTrailingBarButtonGroup]):
3460         (TestWebKitAPI::TEST):
3461         * TestWebKitAPI/ios/UIKitSPI.h:
3462
3463 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
3464
3465         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
3466         https://bugs.webkit.org/show_bug.cgi?id=196077
3467         <rdar://problem/49108202>
3468
3469         Reviewed by Chris Dumez.
3470
3471         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
3472         on new web view.
3473
3474         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3475
3476 2019-04-05  Saam Barati  <sbarati@apple.com>
3477
3478         Make compare-results understand MotionMark
3479         https://bugs.webkit.org/show_bug.cgi?id=196666
3480
3481         Reviewed by Yusuke Suzuki.
3482
3483         * Scripts/compare-results:
3484         (PLT5Results):
3485         (detectMotionMark):
3486         (detectMotionMark1_1):
3487         (motionMarkResults):
3488         (motionMark1_1Results):
3489         (detectBenchmark):
3490         (biggerIsBetter):
3491         (main):
3492
3493 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3494
3495         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3496         https://bugs.webkit.org/show_bug.cgi?id=196665
3497         <rdar://45115669>
3498
3499         Reviewed by Geoff Garen.
3500
3501         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3502         (goBack):
3503         (+[SimpleLookupContext sharedLookupContext]):
3504         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3505         (TEST):
3506         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3507         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3508
3509 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3510
3511         [ews-build] Add configuration and architecture for windows builders
3512         https://bugs.webkit.org/show_bug.cgi?id=196660
3513
3514         Reviewed by Lucas Forschler.
3515
3516         * BuildSlaveSupport/ews-build/config.json:
3517
3518 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3519
3520         webkitpy: Don't run subsequent rounds if interrupted
3521         https://bugs.webkit.org/show_bug.cgi?id=196646
3522
3523         Reviewed by Aakash Jain.
3524
3525         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3526         (Manager.run): Bail out if interrupted.
3527
3528 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3529
3530         Test sessionStorage in PSON private browsing mode
3531         https://bugs.webkit.org/show_bug.cgi?id=196561
3532
3533         Reviewed by Alex Christensen.
3534
3535         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3536
3537 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3538
3539         Unreviewed, rolling out r243833.
3540         https://bugs.webkit.org/show_bug.cgi?id=196645
3541
3542         This change breaks build of WPE and GTK ports (Requested by
3543         annulen on #webkit).
3544
3545         Reverted changeset:
3546
3547         "[CMake][WTF] Mirror XCode header directories"
3548         https://bugs.webkit.org/show_bug.cgi?id=191662
3549         https://trac.webkit.org/changeset/243833
3550
3551 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3552
3553         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3554         https://bugs.webkit.org/show_bug.cgi?id=196635
3555
3556         Reviewed by Antti Koivisto.
3557         
3558         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3559         for a test to enable async frame scrolling via:
3560             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3561         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3562         
3563         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3564
3565         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3566         (WTR::InjectedBundle::beginTesting):
3567         * WebKitTestRunner/TestController.cpp:
3568         (WTR::TestController::resetPreferencesToConsistentValues):
3569
3570 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3571
3572         Use a correct LC_RPATH when building with ASan
3573         https://bugs.webkit.org/show_bug.cgi?id=196576
3574
3575         Reviewed by David Kilzer.
3576
3577         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3578         so that ../Frameworks is checked. This is simpler and more reliable than updating
3579         each SPC service xcconfig.
3580
3581 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3582
3583         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3584         https://bugs.webkit.org/show_bug.cgi?id=196629
3585
3586         Reviewed by Lucas Forschler.
3587
3588         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3589
3590 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3591
3592         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3593         https://bugs.webkit.org/show_bug.cgi?id=196618
3594
3595         Reviewed by Lucas Forschler.
3596
3597         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3598         (StatusBubble): Added QUEUE_TRIGGERS.
3599         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3600         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3601         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3602         its parent(builder).
3603
3604 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3605
3606         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3607         https://bugs.webkit.org/show_bug.cgi?id=196625
3608
3609         Reviewed by Lucas Forschler.
3610
3611         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3612         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3613
3614 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3615
3616         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3617         https://bugs.webkit.org/show_bug.cgi?id=196630
3618
3619         Reviewed by Wenson Hsieh.
3620
3621         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3622
3623 2019-04-04  Youenn Fablet  <youenn@apple.com>
3624
3625         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3626         https://bugs.webkit.org/show_bug.cgi?id=196543
3627
3628         Reviewed by Alex Christensen.
3629
3630         * WebKitTestRunner/TestController.cpp:
3631         (WTR::TestController::generatePageConfiguration):
3632
3633 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3634
3635         [ews-app] Status bubble should not display skipped buildbot steps
3636         https://bugs.webkit.org/show_bug.cgi?id=196584
3637
3638         Reviewed by Lucas Forschler.
3639
3640         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3641
3642 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3643
3644         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3645         https://bugs.webkit.org/show_bug.cgi?id=196620
3646
3647         Reviewed by Lucas Forschler.
3648
3649         * BuildSlaveSupport/ews-app/ews/config.py:
3650
3651 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3652
3653         [Win] DumpRenderTreeWatchDog.py is not checked into source
3654         https://bugs.webkit.org/show_bug.cgi?id=196567
3655         <rdar://problem/49525901>
3656
3657         Reviewed by Lucas Forschler.
3658
3659         This script is used on Win EWS bots to terminate hanging DRT processes.
3660
3661         * EWSTools/dumprendertreewatchdog.py: Added.
3662
3663 2019-04-04  Chris Dumez  <cdumez@apple.com>
3664
3665         Unreviewed, roll out r243858 which made tests time out.
3666
3667         Disable new API tests on Windows instead.
3668
3669         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3670         (TestWebKitAPI::TEST):
3671
3672 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3673
3674         [ATK] Cleanup WebPageAccessibilityObjectAtk
3675         https://bugs.webkit.org/show_bug.cgi?id=196537
3676
3677         Reviewed by Michael Catanzaro.
3678
3679         Also consider files under atk directories as exceptions for GObject conventions.
3680
3681         * Scripts/webkitpy/style/checkers/cpp.py:
3682         (check_identifier_name_in_declaration):
3683
3684 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3685
3686         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3687         https://bugs.webkit.org/show_bug.cgi?id=196588
3688         <rdar://problem/49365787>
3689
3690         Unreviewed build fix for Windows port.
3691
3692         error C3861: 'kill': identifier not found
3693
3694         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3695         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3696
3697 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3698
3699         [ews-build] Cancel build and similar operations should have authentication
3700         https://bugs.webkit.org/show_bug.cgi?id=196520
3701
3702         Reviewed by Dewei Zhu.
3703
3704         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3705         environment variables.
3706
3707 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3708
3709         [ews-build] Do not trigger queues which are not in production yet
3710         https://bugs.webkit.org/show_bug.cgi?id=196581
3711
3712         Reviewed by Dewei Zhu.
3713
3714         * BuildSlaveSupport/ews-build/config.json:
3715
3716 2019-04-03  Chris Dumez  <cdumez@apple.com>
3717
3718         Unreviewed, fix typo in the name of API test added in r243848.
3719
3720         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3721         (TestWebKitAPI::TEST):
3722
3723 2019-04-03  Chris Dumez  <cdumez@apple.com>
3724
3725         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3726         https://bugs.webkit.org/show_bug.cgi?id=196588
3727         <rdar://problem/49365787>
3728
3729         Reviewed by Ryosuke Niwa.
3730
3731         Add API test coverage.
3732
3733         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3734         (TestWebKitAPI::nullJavaScriptCallback):
3735         (TestWebKitAPI::didCrashCheckFrames):
3736         (TestWebKitAPI::TEST):
3737
3738 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3739
3740         run-webkit-tests: Upload test results (new results database)
3741         https://bugs.webkit.org/show_bug.cgi?id=196577
3742         <rdar://problem/34841155>
3743
3744         Reviewed by Lucas Forschler.
3745
3746         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3747         (Manager.run): Upload results after each device shard, since the configuration will be
3748         different for each device.
3749         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3750         uploaded to a results database.
3751         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3752         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3753
3754 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3755
3756         -apple-trailing-word is needed for browser detection
3757         https://bugs.webkit.org/show_bug.cgi?id=196575
3758
3759         Unreviewed.
3760
3761         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3762
3763 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3764
3765         [CMake][WTF] Mirror XCode header directories
3766         https://bugs.webkit.org/show_bug.cgi?id=191662
3767
3768         Reviewed by Konstantin Tokarev.
3769
3770         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3771         builds.
3772
3773         * CMakeLists.txt:
3774         * DumpRenderTree/CMakeLists.txt:
3775         * DumpRenderTree/PlatformWin.cmake:
3776         * MiniBrowser/win/CMakeLists.txt:
3777         * TestWebKitAPI/CMakeLists.txt:
3778         * TestWebKitAPI/PlatformWin.cmake:
3779         * WebKitTestRunner/PlatformGTK.cmake:
3780         * WebKitTestRunner/PlatformWin.cmake:
3781
3782 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3783
3784         [ews-app] Status bubble should not display certain infrastructure status messages
3785         https://bugs.webkit.org/show_bug.cgi?id=196550
3786
3787         Reviewed by Lucas Forschler.
3788
3789         Do not display the steps which are un-needed for end-user. This information is still avaiable
3790         if the user click on the bubble and look at the Buildbot build.
3791         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3792         (StatusBubble._steps_messages):
3793         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3794
3795 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3796
3797         [ews-build] Use https for sending data to ews-app
3798         https://bugs.webkit.org/show_bug.cgi?id=196492
3799
3800         Reviewed by Lucas Forschler.
3801
3802         * BuildSlaveSupport/ews-build/events.py:
3803
3804 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3805
3806         Remove support for -apple-trailing-word
3807         https://bugs.webkit.org/show_bug.cgi?id=196525
3808
3809         Reviewed by Zalan Bujtas.
3810
3811         This CSS property is nonstandard and not used.
3812
3813         * Scripts/webkitperl/FeatureList.pm:
3814         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3815
3816 2019-04-03  Youenn Fablet  <youenn@apple.com>
3817
3818         Add a test for DOMCache on multiple browsing in case of private browsing
3819         https://bugs.webkit.org/show_bug.cgi?id=196524
3820
3821         Reviewed by Alex Christensen.
3822
3823         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3824         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3825
3826 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3827
3828         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3829         https://bugs.webkit.org/show_bug.cgi?id=196540
3830
3831         Reviewed by Aakash Jain.
3832
3833         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3834
3835 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3836
3837         Add plumbing for a compatibility mode preference in WebKit
3838         https://bugs.webkit.org/show_bug.cgi?id=196005
3839
3840         Reviewed by Tim Horton.
3841
3842         Add new API tests.
3843
3844         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3845         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3846
3847 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3848
3849         [WPE][GTK] Update libsrtp dependency package for Debian
3850         https://bugs.webkit.org/show_bug.cgi?id=196528
3851
3852         Reviewed by Frédéric Wang.
3853
3854         * gtk/install-dependencies:
3855         * wpe/install-dependencies:
3856
3857 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3858
3859         [WK2] Add support for Window's beforeprint / afterprint events
3860         https://bugs.webkit.org/show_bug.cgi?id=196478
3861         <rdar://problem/49535124>
3862
3863         Unreviewed build fix for MSVC.
3864
3865         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3866
3867         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3868
3869         * WebKitTestRunner/TestController.cpp:
3870         (WTR::printFrame): Use int and float literals.
3871
3872 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3873
3874         [ews-build] Reassign bots to queues
3875
3876         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3877
3878 2019-04-02  Chris Dumez  <cdumez@apple.com>
3879
3880         [WK2] Add support for Window's beforeprint / afterprint events
3881         https://bugs.webkit.org/show_bug.cgi?id=196478
3882
3883         Reviewed by Alex Christensen.
3884
3885         Add minimal implementation for printFrame in WebKitTestRunner.
3886
3887         * WebKitTestRunner/TestController.cpp:
3888         (WTR::printFrame):
3889         (WTR::TestController::createOtherPage):
3890         (WTR::TestController::createWebViewWithOptions):
3891
3892 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3893
3894         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3895         https://bugs.webkit.org/show_bug.cgi?id=196491
3896
3897         Reviewed by Lucas Forschler.
3898
3899         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3900
3901 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3902
3903         [ews-build] Configure buildbot try credentials in environment variables
3904         https://bugs.webkit.org/show_bug.cgi?id=196501
3905
3906         Reviewed by Lucas Forschler.
3907
3908         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3909         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3910         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3911
3912 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3913
3914         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3915         https://bugs.webkit.org/show_bug.cgi?id=196496
3916         <rdar://problem/49521634>
3917
3918         Reviewed by Chris Dumez.
3919
3920         Add new API tests (see WebKit ChangeLog for more detail).
3921
3922         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3923         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3924         (TEST):
3925
3926 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3927
3928         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3929         <https://webkit.org/b/196499>
3930
3931         Reviewed by Alexey Proskuryakov.
3932
3933         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3934         ENABLE_ADDRESS_SANITIZER.
3935
3936 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3937
3938         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3939         https://bugs.webkit.org/show_bug.cgi?id=182757
3940
3941         Reviewed by Don Olmstead.
3942
3943         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3944         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3945
3946 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3947
3948         run-api-tests: Upload test results
3949         https://bugs.webkit.org/show_bug.cgi?id=196323
3950         <rdar://problem/49356714>
3951
3952         Reviewed by Lucas Forschler.
3953
3954         * Scripts/webkitpy/api_tests/manager.py:
3955         (Manager):
3956         (Manager.run): Upload results to a results database.
3957         * Scripts/webkitpy/api_tests/run_api_tests.py:
3958         (parse_args): Add upload arguments.
3959         * Scripts/webkitpy/port/base.py:
3960         (Port):
3961         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3962         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3963         with commits from any other associated repositories.
3964         * Scripts/webkitpy/port/device.py:
3965         (Device):
3966         (Device.build_version): Access build_versoin of underlying platform device.
3967         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3968         (IOSSimulatorTest):
3969         (IOSSimulatorTest.test_configuration_for_upload):
3970         * Scripts/webkitpy/port/device_port.py:
3971         (DevicePort):
3972         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3973         the same as the machine uploading results.
3974         * Scripts/webkitpy/port/mac.py:
3975         (MacPort):
3976         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3977         * Scripts/webkitpy/port/mac_unittest.py:
3978         (MacTest):
3979         (MacTest.test_configuration_for_upload):
3980         * Scripts/webkitpy/xcode/simulated_device.py:
3981         (SimulatedDeviceManager._create_device_with_runtime):
3982         (SimulatedDevice.__init__): Create simulated device with a build_version.
3983         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3984         (test_existing_simulator):
3985
3986 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3987
3988         Remove extra newline characters (Follow-up fix to r243707)
3989
3990         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3991
3992 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3993
3994         [ews-app] Use API_KEY to accept results data
3995         https://bugs.webkit.org/show_bug.cgi?id=196461
3996
3997         Reviewed by Dewei Zhu.
3998
3999         * BuildSlaveSupport/ews-app/ews/views/results.py:
4000         (Results.post): Validate EWS_API_KEY before accepting any data.
4001         * BuildSlaveSupport/ews-build/events.py:
4002         (Events.sendData): Send EWS_API_KEY if available along with event data.
4003
4004 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
4005
4006         Unable to copy and paste a PDF from Notes into Mail compose body
4007         https://bugs.webkit.org/show_bug.cgi?id=196442
4008         <rdar://problem/48573098>
4009
4010         Reviewed by Tim Horton.
4011
4012         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
4013         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
4014         to be specified on the item providers.
4015
4016         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4017         (TestWebKitAPI::mapItemForTesting):
4018         (TestWebKitAPI::contactItemForTesting):
4019
4020 2019-04-01  Tim Horton  <timothy_horton@apple.com>
4021
4022         Make UIWKDocumentContext rects per-character instead of per-word
4023         https://bugs.webkit.org/show_bug.cgi?id=196459
4024
4025         Reviewed by Wenson Hsieh.
4026
4027         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4028         (TEST):
4029         Adjust test results due to switching to per-character rects.
4030
4031 2019-04-01  Chris Dumez  <cdumez@apple.com>
4032
4033         UIProcess crash when a prewarmed process is terminated
4034         https://bugs.webkit.org/show_bug.cgi?id=196451
4035         <rdar://problem/49245471>
4036
4037         Reviewed by Geoffrey Garen.
4038
4039         Add API test coverage.
4040
4041         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
4042         (TEST):
4043
4044 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4045
4046         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
4047         https://bugs.webkit.org/show_bug.cgi?id=196449
4048
4049         Reviewed by Lucas Forschler.
4050
4051         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4052         (StatusBubble.get_os_details): Method to get OS and Xcode details.
4053         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
4054         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
4055
4056 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
4057
4058         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
4059         https://bugs.webkit.org/show_bug.cgi?id=196444
4060
4061         Reviewed by Lucas Forschler.
4062
4063         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
4064
4065 2019-04-01  Alex Christensen  <achristensen@webkit.org>
4066
4067         Add SPI to canonicalize NSURLs with WTF::URL
4068         https://bugs.webkit.org/show_bug.cgi?id=196415
4069         <rdar://problem/44980271>
4070
4071         Reviewed by Darin Adler.
4072
4073         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4074         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
4075         (TestWebKitAPI::TEST):
4076
4077 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
4078
4079         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
4080         https://bugs.webkit.org/show_bug.cgi?id=196441
4081
4082         Reviewed by Carlos Garcia Campos.
4083
4084         Don't cache the wpe_view_backend object that might not exist yet at the
4085         time of EventSenderProxy constructor invocation, but instead retrieve
4086         that object whenever it's required for event dispatching. This should
4087         avoid crashes in this constructor now that it's invoked before any
4088         PlatformWindow has been set up (as changed in r243496).
4089
4090         * WebKitTestRunner/EventSenderProxy.h:
4091         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
4092         (WTR::viewBackend):
4093         (WTR::EventSenderProxy::EventSenderProxy):
4094         (WTR::EventSenderProxy::mouseDown):
4095         (WTR::EventSenderProxy::mouseUp):
4096         (WTR::EventSenderProxy::mouseMoveTo):
4097         (WTR::EventSenderProxy::mouseScrollBy):
4098         (WTR::EventSenderProxy::keyDown):
4099         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
4100
4101 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
4102
4103         [Win][WebKit] MiniBrowser should support high DPI display
4104         https://bugs.webkit.org/show_bug.cgi?id=196391
4105
4106         Reviewed by Alex Christensen.
4107
4108         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4109         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
4110         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
4111         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
4112
4113 2019-03-31  Sam Weinig  <weinig@apple.com>
4114
4115         Remove more i386 specific configurations
4116         https://bugs.webkit.org/show_bug.cgi?id=196430
4117
4118         Reviewed by Alexey Proskuryakov.
4119
4120         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4121         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
4122
4123 2019-03-31  Andy Estes  <aestes@apple.com>
4124
4125         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
4126         https://bugs.webkit.org/show_bug.cgi?id=196433
4127         <rdar://problem/49293305>
4128
4129         Reviewed by Tim Horton.
4130
4131         Enhanced API test coverage to include all navigation response policy decisions in both
4132         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
4133
4134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4135         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
4136         (TestWebKitAPI::TEST):
4137         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
4138         (readFile):
4139         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
4140         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
4141         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4142         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4143         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4144         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
4145         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
4146         (-[QuickLookDelegate _downloadDidStart:]):
4147         (-[QuickLookDelegate _download:didReceiveResponse:]):
4148         (-[QuickLookDelegate _download:didReceiveData:]):
4149         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4150         (-[QuickLookDelegate _downloadDidFinish:]):
4151         (-[QuickLookDelegate _download:didFailWithError:]):
4152         (-[QuickLookDelegate _downloadDidCancel:]):
4153         (-[QuickLookDelegate verifyDownload]):
4154         (runTest):
4155         (runTestDecideBeforeLoading):
4156         (runTestDecideAfterLoading):
4157         (TEST):
4158         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4159         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4160         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
4161         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
4162         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
4163         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
4164         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
4165         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
4166         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
4167         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
4168         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
4169         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
4170         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
4171         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
4172
4173 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
4174
4175         [CMake] add testdfg as target with build-jsc
4176         https://bugs.webkit.org/show_bug.cgi?id=196393
4177
4178         Reviewed by Saam Barati.
4179
4180         Added testdfg as one of the targets to build when
4181         using CMake.
4182
4183         * Scripts/build-jsc:
4184
4185 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
4186
4187         Delete WebMetal implementation in favor of WebGPU
4188         https://bugs.webkit.org/show_bug.cgi?id=195418
4189
4190         Reviewed by Dean Jackson.
4191
4192         * DumpRenderTree/mac/DumpRenderTree.mm:
4193         (enableExperimentalFeatures):
4194         (resetWebPreferencesToConsistentValues):
4195         * Scripts/webkitperl/FeatureList.pm:
4196         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4198         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
4199         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
4200         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
4201         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
4202         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
4203         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
4204         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
4205         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4206         (WTR::InjectedBundle::beginTesting):
4207         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4208         (WTR::TestRunner::setWebMetalEnabled): Deleted.
4209         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4210
4211 2019-03-29  Chris Dumez  <cdumez@apple.com>
4212
4213         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
4214         https://bugs.webkit.org/show_bug.cgi?id=196405
4215         <rdar://problem/49428130>
4216
4217         Reviewed by Wenson Hsieh.
4218
4219         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
4220         the popover presentation methods to be no-ops. Use this in the new test added in
4221         r243523 so that we do not swizzle those methods for all tests. This is needed because
4222         those WatchOS tests rely on the popover getting presented and interactive.
4223
4224         * WebKitTestRunner/TestController.cpp:
4225         (WTR::updateTestOptionsFromTestHeader):
4226         * WebKitTestRunner/TestController.h:
4227         * WebKitTestRunner/TestOptions.h:
4228         (WTR::TestOptions::hasSameInitializationOptions const):
4229         * WebKitTestRunner/ios/TestControllerIOS.mm:
4230         (WTR::TestController::platformInitialize):
4231         (WTR::TestController::platformResetStateToConsistentValues):
4232
4233 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
4234
4235         [Curl] Add Server Trust Evaluation Support.
4236         https://bugs.webkit.org/show_bug.cgi?id=191646
4237
4238         Reviewed by Fujii Hironori.
4239
4240         Implemented MiniBrowser UI for asking if user trusts the server.
4241
4242         * MiniBrowser/win/Common.cpp:
4243         (askServerTrustEvaluation):
4244         (replaceString):
4245         * MiniBrowser/win/Common.h:
4246         * MiniBrowser/win/MiniBrowserLib.rc:
4247         * MiniBrowser/win/MiniBrowserLibResource.h:
4248         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4249         (createPEMString):
4250         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4251         (WebKitBrowserWindow::canTrustServerCertificate):
4252         * MiniBrowser/win/WebKitBrowserWindow.h:
4253
4254 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
4255
4256         Implement ResizeObserver.
4257         https://bugs.webkit.org/show_bug.cgi?id=157743
4258
4259         Reviewed by Simon Fraser.
4260
4261         Support resizeObserverEnabled webPreferences.
4262
4263         * DumpRenderTree/TestOptions.cpp:
4264         (TestOptions::TestOptions):
4265         * DumpRenderTree/TestOptions.h:
4266         * DumpRenderTree/mac/DumpRenderTree.mm:
4267         (setWebPreferencesForTestOptions):
4268         * DumpRenderTree/win/DumpRenderTree.cpp:
4269         (enableExperimentalFeatures):
4270         * Scripts/webkitperl/FeatureList.pm:
4271         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4272
4273 2019-03-28  John Wilander  <wilander@apple.com>
4274
4275         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
4276         https://bugs.webkit.org/show_bug.cgi?id=196281
4277         <rdar://problem/48938748>
4278
4279         Reviewed by Alex Christensen.
4280
4281         This patch adds the function isStatisticsHasLocalStorage() to the
4282         TestRunner. With it, the page can query the WebsiteDataStore in the
4283         UI process to make sure that it sees LocalStorage.
4284
4285         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4286         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4287         (WTR::TestRunner::isStatisticsHasLocalStorage):
4288         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4289         * WebKitTestRunner/TestController.cpp:
4290         (WTR::TestController::isStatisticsHasLocalStorage):
4291         * WebKitTestRunner/TestController.h:
4292         * WebKitTestRunner/TestInvocation.cpp:
4293         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4294
4295 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
4296
4297         API::Data::createWithoutCopying should do a null check before calling CFRelease
4298         https://bugs.webkit.org/show_bug.cgi?id=196276
4299         <rdar://problem/48059859>
4300
4301         Reviewed by Alex Christensen.
4302
4303         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
4304
4305         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4306         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
4307         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
4308         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
4309         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
4310         (TestWebKitAPI::TEST):