* Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2
3         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
4
5 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
6
7         Add contributors.json entries for Ling Ho and for a new bot watchers group.
8
9         * Scripts/webkitpy/common/config/contributors.json:
10
11 2019-01-25  Chris Dumez  <cdumez@apple.com>
12
13         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
14         https://bugs.webkit.org/show_bug.cgi?id=193779
15         <rdar://problem/46170903>
16
17         Reviewed by Antti Koivisto.
18
19         Add API test that quickly navigates forward to a previous process without waiting for it to
20         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
21         the process' previous page when reconnecting the it for the forward navigation.
22
23         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
24
25 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
26
27         Need a way for JavaScript (or bundle) code to participate in undo
28         https://bugs.webkit.org/show_bug.cgi?id=190009
29         <rdar://problem/44807048>
30
31         Reviewed by Ryosuke Niwa.
32
33         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
34         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
35
36         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
37         (WTR::UIScriptController::lastUndoLabel const):
38         (WTR::UIScriptController::firstRedoLabel const):
39         (WTR::UIScriptController::platformUndoManager const):
40         * DumpRenderTree/mac/UIScriptControllerMac.mm:
41         (WTR::UIScriptController::lastUndoLabel const):
42         (WTR::UIScriptController::firstRedoLabel const):
43         (WTR::UIScriptController::platformUndoManager const):
44         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
45         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
46         (WTR::UIScriptController::lastUndoLabel const):
47         (WTR::UIScriptController::firstRedoLabel const):
48         * TestRunnerShared/UIScriptContext/UIScriptController.h:
49         * WebKitTestRunner/UIScriptControllerCocoa.mm:
50         (WTR::UIScriptController::lastUndoLabel const):
51         (WTR::UIScriptController::firstRedoLabel const):
52         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
53         (WTR::UIScriptController::platformUndoManager const):
54         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
55         (WTR::UIScriptController::platformUndoManager const):
56
57 2019-01-25  Zalan Bujtas  <zalan@apple.com>
58
59         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
60         https://bugs.webkit.org/show_bug.cgi?id=193824
61
62         Reviewed by Antti Koivisto.
63
64         * LayoutReloaded/misc/LFC-passing-tests.txt:
65
66 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
67
68         Update macOS JSC bot configurations
69         https://bugs.webkit.org/show_bug.cgi?id=193739
70
71         Reviewed by Alexey Proskuryakov.
72
73         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
74         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
75         (BubbleQueueServer): Move JSC EWS to Mojave section.
76         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
77         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
78         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
79
80 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
81
82         [Win][WebKitTestRunner] Implement EventSenderProxy
83         https://bugs.webkit.org/show_bug.cgi?id=193755
84
85         Reviewed by Don Olmstead.
86
87         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
88         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
89         (WTR::EventSenderProxy::dispatchMessage):
90         (WTR::EventSenderProxy::EventSenderProxy):
91         (WTR::EventSenderProxy::mouseDown):
92         (WTR::EventSenderProxy::mouseUp):
93         (WTR::EventSenderProxy::mouseMoveTo):
94         (WTR::EventSenderProxy::mouseScrollBy):
95         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
96
97 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
98
99         Unreviewed fix for API test failure after r240437.
100
101         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
102
103         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
104
105 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
106
107         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
108         https://bugs.webkit.org/show_bug.cgi?id=193787
109         <rdar://problem/47497634>
110
111         Reviewed by Alexey Proskuryakov.
112
113         * Scripts/webkitdirs.pm:
114         (iosSimulatorApplicationsPath): Pick from available runtime directories.
115
116 2019-01-24  Truitt Savell  <tsavell@apple.com>
117
118         Unreviewed, rolling out r240446.
119
120         Casued 5 API failures
121
122         Reverted changeset:
123
124         "Activate the WebResourceLoadStatisticsStore in the
125         NetworkProcess and deactivate it in the UIProcess."
126         https://bugs.webkit.org/show_bug.cgi?id=193297
127         https://trac.webkit.org/changeset/240446
128
129 2019-01-24  Zalan Bujtas  <zalan@apple.com>
130
131         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
132         https://bugs.webkit.org/show_bug.cgi?id=193741
133         <rdar://problem/47135030>
134
135         Reviewed by Antti Koivisto and Simon Fraser.
136
137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
138         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
139         (TestWebKitAPI::TEST):
140
141 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
142
143         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
144         https://bugs.webkit.org/show_bug.cgi?id=193297
145         <rdar://problem/47158841>
146
147         Reviewed by Alex Christensen.
148
149         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
150         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
151         activating the message used to trigger the callback when it is set.
152
153 2019-01-24  John Wilander  <wilander@apple.com>
154
155         Add Ad Click Attribution as an internal/experimental feature
156         https://bugs.webkit.org/show_bug.cgi?id=193685
157         <rdar://problem/47450399>
158
159         Reviewed by Brent Fulgham.
160
161         Added test option adClickAttributionEnabled.
162
163         * DumpRenderTree/TestOptions.cpp:
164         (TestOptions::TestOptions):
165         * DumpRenderTree/TestOptions.h:
166         * DumpRenderTree/mac/DumpRenderTree.mm:
167         (setWebPreferencesForTestOptions):
168
169 2019-01-24  Antti Koivisto  <antti@apple.com>
170
171         [PSON] Flash on back navigation on Mac
172         https://bugs.webkit.org/show_bug.cgi?id=193716
173         <rdar://problem/47148458>
174
175         Reviewed by Chris Dumez.
176
177         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
178
179         Closing of the previous page is delayed so waiting for didFinishNavigation is
180         not sufficient to guarantee we have received all the messages. Wait for them.
181
182 2019-01-24  Chris Dumez  <cdumez@apple.com>
183
184         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
185         https://bugs.webkit.org/show_bug.cgi?id=193761
186         <rdar://problem/47456405>
187
188         Reviewed by Alex Christensen.
189
190         Add API test coverage.
191
192         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
193
194 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
195
196         webkitpy: Missing PID in crashlog name should not be fatal
197         https://bugs.webkit.org/show_bug.cgi?id=193771
198
199         If we can't determine the PID of a crashlog, just ignore the crashlog instead
200         of raising an exception.
201
202         Reviewed by Lucas Forschler.
203
204         * Scripts/webkitpy/port/darwin.py:
205         (DarwinPort._merge_crash_logs):
206
207 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
208
209         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
210         https://bugs.webkit.org/show_bug.cgi?id=193746
211
212         Reviewed by Youenn Fablet.
213
214         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
215         so we'd best just not call it.
216
217         * Scripts/webkitpy/w3c/test_exporter.py:
218         (WebPlatformTestExporter.create_branch_with_patch):
219
220 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
221
222         Move FileSystem to WTF
223         https://bugs.webkit.org/show_bug.cgi?id=193602
224
225         Reviewed by Yusuke Suzuki.
226
227         * DumpRenderTree/win/DumpRenderTree.cpp:
228         * TestWebKitAPI/CMakeLists.txt:
229         * TestWebKitAPI/PlatformGTK.cmake:
230         * TestWebKitAPI/PlatformJSCOnly.cmake:
231         * TestWebKitAPI/PlatformPlayStation.cmake:
232         * TestWebKitAPI/PlatformWPE.cmake:
233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
234         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
235         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
236         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
237         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
238         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
239         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
240         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
241         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
242         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
243
244 2019-01-24  Philippe Normand  <pnormand@igalia.com>
245
246         [WPE] Remove hard dependency on subprocess32 for the API tests
247
248         Rubber-stamped by Carlos Garcia Campos.
249
250         * glib/api_test_runner.py:
251         (TestRunner._run_test_qt): Lazily import subprocess32 and check
252         its presence only when running WPEQt tests.
253
254 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
255
256         [GLIB] Expose JavaScriptCore options in GLib public API
257         https://bugs.webkit.org/show_bug.cgi?id=188742
258
259         Reviewed by Michael Catanzaro.
260
261         Add a test for the new API.
262
263         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
264         (testsJSCOptions):
265         (main):
266
267 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
268
269         [GTK][WPE] Support JPEG 2000 images
270         https://bugs.webkit.org/show_bug.cgi?id=186272
271
272         Reviewed by Žan Doberšek.
273
274         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
275
276         * gtk/jhbuild.modules:
277         * wpe/jhbuild.modules:
278
279 2019-01-23  David Kilzer  <ddkilzer@apple.com>
280
281         check-webkit-style should warn when using soft-linking macros in a header
282         <https://webkit.org/b/193750>
283
284         Reviewed by Darin Adler.
285
286         * Scripts/webkitpy/style/checkers/cpp.py:
287         (check_language): Add softlink/header check by refactoring the
288         softlink/framework check.
289         (CppChecker): Enable softlink/header check by default.
290         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
291         (CppStyleTest.test_softlink_framework): Rename from
292         CppStyleTest.test_softlink() and change test framework name in
293         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
294         files. Set file_name for macros that only appear in headers.
295         (CppStyleTest.test_softlink_header): Add tests for using
296         soft-link macros in headers.
297
298 2019-01-23  Chris Dumez  <cdumez@apple.com>
299
300         Deprecate API to limit the maximum number of WebProcesses
301         https://bugs.webkit.org/show_bug.cgi?id=193725
302         <rdar://problem/47464879>
303
304         Reviewed by Geoff Garen.
305
306         Update existing API tests to stop using deprecated API.
307
308         * MiniBrowser/mac/AppDelegate.m:
309         (defaultConfiguration):
310         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
311         (TestWebKitAPI::TEST):
312         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
313         (TestWebKitAPI::TEST):
314         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
315         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
316         (TEST):
317         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
318         (TEST):
319
320 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
321
322         [ews-app] Rename ews model buildermappings to buildermapping
323         https://bugs.webkit.org/show_bug.cgi?id=193729
324
325         Reviewed by Lucas Forschler.
326
327         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
328         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
329         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
330
331 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
332
333         [ews-app] Rename ews model steps to step
334         https://bugs.webkit.org/show_bug.cgi?id=193697
335
336         Reviewed by Lucas Forschler.
337
338         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
339         (Step): Renamed Steps to Step.
340
341 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
342
343         Clean up IndexedDB files between tests
344         https://bugs.webkit.org/show_bug.cgi?id=192796
345         <rdar://problem/46824999>
346
347         Reviewed by Geoffrey Garen.
348
349         * DumpRenderTree/mac/DumpRenderTree.mm:
350         (runTest):
351         * WebKitTestRunner/TestController.cpp:
352         (WTR::TestController::resetStateToConsistentValues):
353         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
354         (WTR::RemoveAllIndexedDatabasesCallback):
355         (WTR::TestController::ClearIndexedDatabases):
356         * WebKitTestRunner/TestController.h:
357         * WebKitTestRunner/TestInvocation.cpp:
358         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
359
360 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
361
362         [ews-app] Rename ews model Builds to Build
363         https://bugs.webkit.org/show_bug.cgi?id=193695
364
365         Reviewed by Lucas Forschler.
366
367         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
368         (Build): Renamed Builds to Build.
369
370 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
371
372         webkitpy: Wait longer when launching WebKitTestRunner
373         https://bugs.webkit.org/show_bug.cgi?id=193734
374
375         Reviewed by Aakash Jain.
376
377         * Scripts/webkitpy/port/simulator_process.py:
378         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
379
380 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
381
382         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
383         https://bugs.webkit.org/show_bug.cgi?id=193182
384         <rdar://problem/47452154>
385
386         Reviewed by Tim Horton.
387
388         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
389         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
390         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
391
392         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
393         preventing later tests from recognizing gestures.
394
395         * WebKitTestRunner/ios/TestControllerIOS.mm:
396         (WTR::TestController::platformResetStateToConsistentValues):
397
398         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
399
400 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
401
402         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
403         https://bugs.webkit.org/show_bug.cgi?id=193722
404         <rdar://problem/47481475>
405
406         Reviewed by Lucas Forschler.
407
408         iPhone and iPad ports should both use the iOS config.
409
410         * Scripts/webkitpy/port/ios_simulator.py:
411         (IPhoneSimulatorPort.__init__):
412         (IPadSimulatorPort.__init__):
413
414 2019-01-23  Rob Buis  <rbuis@igalia.com>
415
416         Update MIME type parser
417         https://bugs.webkit.org/show_bug.cgi?id=180526
418
419         Reviewed by Frédéric Wang.
420
421         Add unit tests for both parse modes of ParsedContentType.
422
423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
424         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
425         (TestWebKitAPI::TEST):
426
427 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
428
429         [ews-app] fetch loop should not stop on network issues
430         https://bugs.webkit.org/show_bug.cgi?id=193666
431
432         Reviewed by Lucas Forschler.
433
434         * BuildSlaveSupport/ews-app/ews/fetcher.py:
435         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
436
437 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
438
439         [iOS] Multiple WKWebViewAutofillTests are flaky failures
440         https://bugs.webkit.org/show_bug.cgi?id=189165
441         <rdar://problem/47433765>
442
443         Reviewed by Tim Horton.
444
445         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
446         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
447         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
448         process in sufficient to ensure that any previous action that blurred the focused element in the web process
449         would make its way to the UI process by the time the layer tree commit is finished.
450
451         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
452         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
453         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
454         will fail because it asks for -_autofillContext too early.
455
456         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
457         is handled in the UI process.
458
459         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
460
461         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
462         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
463         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
464         input session.
465
466         (-[AutofillTestView textInputHasAutofillContext]):
467
468         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
469
470         * TestWebKitAPI/cocoa/TestWKWebView.h:
471         * TestWebKitAPI/cocoa/TestWKWebView.mm:
472         (nextInputSessionChangeCount):
473
474         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
475         This includes changing the focused element from one to another.
476
477         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
478         (-[TestWKWebView didStartFormControlInteraction]):
479         (-[TestWKWebView didEndFormControlInteraction]):
480         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
481
482         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
483         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
484         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
485         that doesn't require an input session to one that doesn't.
486
487 2019-01-22  David Kilzer  <ddkilzer@apple.com>
488
489         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
490         <https://webkit.org/b/193676>
491
492         Reviewed by Alexey Proskuryakov.
493
494         * Scripts/webkitpy/style/checkers/cpp.py:
495         (check_member_initialization_list):
496         - Don't report missing whitespace around colon if the colon at
497           the start of the line is formatted correctly.
498         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
499         (WebKitStyleTest.test_member_initialization_list):
500         - Add a test for a missing permutation of existing tests.
501         - Add a test this false-positive.
502         - Add blank lines between subtests to make them easier to read.
503
504 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
505
506         [build.webkit.org] Unit-test failure after r237113
507         https://bugs.webkit.org/show_bug.cgi?id=193669
508
509         Reviewed by Michael Catanzaro.
510
511         * BuildSlaveSupport/build.webkit.org-config/factories.py:
512         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
513         multiple or zero flags.
514
515 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
516
517         Cache bytecode to disk
518         https://bugs.webkit.org/show_bug.cgi?id=192782
519         <rdar://problem/46084932>
520
521         Reviewed by Keith Miller.
522
523         Add test helper to execute bytecode-cache tests: it executes each test
524         twice, the first with JSC_diskCachePath set to a temporary directory
525         and second with JSC_forceDiskCache=true (in addition to the cache path)
526         to guarantee that only the disk cache is being used and no new
527         UnlinkedCodeBlocks are being created.
528
529         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
530         * Scripts/run-jsc-stress-tests:
531
532 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
533
534         [css-logical] Implement flow-relative margin, padding and border shorthands
535         https://bugs.webkit.org/show_bug.cgi?id=188697
536
537         Reviewed by Simon Fraser and Antti Koivisto.
538
539         * DumpRenderTree/TestOptions.cpp:
540         (TestOptions::TestOptions):
541         * DumpRenderTree/TestOptions.h:
542         * DumpRenderTree/mac/DumpRenderTree.mm:
543         (setWebPreferencesForTestOptions):
544         Allow tests to enable the CSSLogicalEnabled flag in WK1.
545
546         * Scripts/webkitpy/style/checkers/jsonchecker.py:
547         (JSONCSSPropertiesChecker.check_codegen_properties):
548         Allow CSS property definitions to have a 'runtime-flag' parameter which
549         disables the property when the specified runtime flag is disabled.
550
551 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
552
553         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
554         https://bugs.webkit.org/show_bug.cgi?id=193643
555
556         Reviewed by Michael Catanzaro.
557
558         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
559         * wpe/jhbuild.modules: Ditto.
560
561 2019-01-21  Zalan Bujtas  <zalan@apple.com>
562
563         [LFC][Floats] Take float top position into account when computing containing block height.
564         https://bugs.webkit.org/show_bug.cgi?id=193655
565
566         Reviewed by Antti Koivisto.
567
568         * LayoutReloaded/misc/LFC-passing-tests.txt:
569
570 2019-01-21  David Kilzer  <ddkilzer@apple.com>
571
572         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
573         <https://webkit.org/b/193645>
574         <rdar://problem/47421574>
575
576         Reviewed by Alex Christensen.
577
578         - Now checks for local soft-linking of all frameworks that have
579           their own *SoftLinking.{cpp,h,mm} files.
580         - Changes softlink/uikit warning to softlink/framework.
581
582         * Scripts/webkitpy/style/checkers/cpp.py:
583         (check_language):
584         (CppChecker):
585         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
586         (CppStyleTest):
587
588 2019-01-20  Saam Barati  <sbarati@apple.com>
589
590         Rollout r240210: It broke tests on iOS
591         https://bugs.webkit.org/show_bug.cgi?id=193640
592
593         Unreviewed.
594
595         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
596         * Scripts/run-jsc-stress-tests:
597
598 2019-01-20  chris fleizach  <cfleizach@apple.com>
599
600         AX: Support returning relative frames for accessibility
601         https://bugs.webkit.org/show_bug.cgi?id=193414
602         <rdar://problem/47268501>
603
604         Reviewed by Zalan Bujtas.
605
606         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
607         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
608         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
609         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
610         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
611         (WTR::attributesOfElement):
612         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
613
614 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
615
616         Unreviewed, add my new email address
617
618         * Scripts/webkitpy/common/config/contributors.json:
619
620 2019-01-19  Zalan Bujtas  <zalan@apple.com>
621
622         [LFC][BFC] <body>'s overflow property value is propagated to viewport
623         https://bugs.webkit.org/show_bug.cgi?id=193617
624
625         Reviewed by Antti Koivisto.
626
627         * LayoutReloaded/misc/LFC-passing-tests.txt:
628
629 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
630
631         Unreviewed, rolling out r240209.
632
633         Broke GTK/WPE injected bundle
634
635         Reverted changeset:
636
637         "AX: Support returning relative frames for accessibility"
638         https://bugs.webkit.org/show_bug.cgi?id=193414
639         https://trac.webkit.org/changeset/240209
640
641 2019-01-12  Dan Bernstein  <mitz@apple.com>
642
643         [Cocoa] Avoid importing directly from subumbrella frameworks
644         https://bugs.webkit.org/show_bug.cgi?id=186016
645         <rdar://problem/40591038>
646
647         Reviewed by Sam Weinig.
648
649         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
650           LaunchServices header.
651         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
652           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
653         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
654           when using SDKs earlier than 10.13.
655         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
656           and OTHER_CPLUSPLUSFLAGS.
657         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
658           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
659         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
660           LaunchServices header.
661
662 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
663
664         Cache bytecode to disk
665         https://bugs.webkit.org/show_bug.cgi?id=192782
666         <rdar://problem/46084932>
667
668         Reviewed by Keith Miller.
669
670         Add test helper to execute bytecode-cache tests: it executes each test
671         twice, the first with JSC_diskCachePath set to a temporary directory
672         and second with JSC_forceDiskCache=true (in addition to the cache path)
673         to guarantee that only the disk cache is being used and no new
674         UnlinkedCodeBlocks are being created.
675
676         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
677         * Scripts/run-jsc-stress-tests:
678
679 2019-01-20  chris fleizach  <cfleizach@apple.com>
680
681         AX: Support returning relative frames for accessibility
682         https://bugs.webkit.org/show_bug.cgi?id=193414
683         <rdar://problem/47268501>
684
685         Reviewed by Zalan Bujtas.
686
687         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
688         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
689         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
690         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
691         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
692         (WTR::attributesOfElement):
693         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
694
695 2019-01-20  Antoine Quint  <graouts@apple.com>
696
697         Add a POINTER_EVENTS feature flag
698         https://bugs.webkit.org/show_bug.cgi?id=193577
699         <rdar://problem/47408511>
700
701         Unreviewed. Also enable Pointer Events for iosmac.
702
703         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
704
705 2019-01-19  Zalan Bujtas  <zalan@apple.com>
706
707         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
708         https://bugs.webkit.org/show_bug.cgi?id=193613
709
710         Reviewed by Antti Koivisto.
711
712         * LayoutReloaded/misc/LFC-passing-tests.txt:
713
714 2019-01-19  Antoine Quint  <graouts@apple.com>
715
716         Add a POINTER_EVENTS feature flag
717         https://bugs.webkit.org/show_bug.cgi?id=193577
718
719         Reviewed by Dean Jackson.
720
721         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
722
723 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
724
725         Disable the run-jsc-stress-test remote host key check [second round].
726         https://bugs.webkit.org/show_bug.cgi?id=192988
727
728         Reviewed by Dewei Zhu.
729
730         * Scripts/run-jsc-stress-tests:
731
732 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
733
734         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
735         https://bugs.webkit.org/show_bug.cgi?id=193597
736
737         Reviewed by Lucas Forschler.
738
739         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
740
741 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
742
743         [build.webkit.org] api tests failures are incorrectly named as unit test failures
744         https://bugs.webkit.org/show_bug.cgi?id=193595
745
746         Reviewed by Lucas Forschler.
747
748         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
749         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
750         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
751
752 2019-01-18  Chris Dumez  <cdumez@apple.com>
753
754         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
755         https://bugs.webkit.org/show_bug.cgi?id=193588
756         <rdar://problem/47131566>
757
758         Reviewed by Alex Christensen.
759
760         Add layout test coverage.
761
762         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
763
764 2019-01-18  Jer Noble  <jer.noble@apple.com>
765
766         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
767         https://bugs.webkit.org/show_bug.cgi?id=189553
768
769         Reviewed by Tim Horton.
770
771         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
772
773         * ContentExtensionTester/Configurations/Base.xcconfig:
774         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
775         * DumpRenderTree/mac/Configurations/Base.xcconfig:
776         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
777         * ImageDiff/cg/Configurations/Base.xcconfig:
778         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
779         * MiniBrowser/Configurations/Base.xcconfig:
780         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
781         * MobileMiniBrowser/Configurations/Base.xcconfig:
782         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
783         * Scripts/webkitpy/style/checker.py:
784         (_all_categories):
785         (FileType):
786         (CheckerDispatcher._file_type):
787         (CheckerDispatcher._create_checker):
788         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
789         (SDKVariantChecker):
790         (SDKVariantChecker.__init__):
791         (SDKVariantChecker.check):
792         * TestWebKitAPI/Configurations/Base.xcconfig:
793         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
794         * WebEditingTester/Configurations/Base.xcconfig:
795         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
796         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
797         * WebKitTestRunner/Configurations/Base.xcconfig:
798         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
799         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
800         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
801
802 2019-01-18  David Kilzer  <ddkilzer@apple.com>
803
804         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
805         <https://webkit.org/b/193568>
806         <rdar://problem/47381130>
807
808         Reviewed by Alex Christensen.
809
810         Make sure no one re-introduces UIKit soft-linking by adding a
811         style rule.
812
813         * Scripts/webkitpy/style/checkers/cpp.py:
814         (check_language): Add softlink/uikit check.
815         (CppChecker): Enable softlink/uikit check.
816         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
817         (CppStyleTest): Add test for softlink/uikit.
818
819 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
820
821         [GTK] install-dependencies tool looks for libunistring-dev for dnf
822         https://bugs.webkit.org/show_bug.cgi?id=193584
823
824         Change "-dev" to "-devel".
825
826         Reviewed by Michael Catanzaro.
827
828         * gtk/install-dependencies:
829
830 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
831
832         webkitpy: Add iPhone and iPad ports
833         https://bugs.webkit.org/show_bug.cgi?id=193537
834         <rdar://problem/47353390>
835
836         Reviewed by Lucas Forschler.
837
838         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
839         ports. Note that this separation is optional, the --ios-simulator command remains.
840
841         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
842         (RunTest.test_device_type_test_division): Drive-by fix.
843         (RunTest.test_device_type_specific_listing): Ditto.
844         (RunTest.test_ipad_test_division):
845         (RunTest):
846         (RunTest.test_ipad_listing):
847         * Scripts/webkitpy/port/factory.py:
848         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
849         (PortFactory):
850         * Scripts/webkitpy/port/ios_simulator.py:
851         (IPhoneSimulatorPort):
852         (IPadSimulatorPort):
853
854 2019-01-18  Chris Dumez  <cdumez@apple.com>
855
856         Regression(PSON) Scroll position is not always restored properly when navigating back
857         https://bugs.webkit.org/show_bug.cgi?id=193578
858         <rdar://problem/47386331>
859
860         Reviewed by Tim Horton.
861
862         Add API test coverage.
863
864         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
865
866 2019-01-18  Youenn Fablet  <youenn@apple.com>
867
868         Add a new SPI to request for cache storage quota increase
869         https://bugs.webkit.org/show_bug.cgi?id=193323
870
871         Reviewed by Alex Christensen.
872
873         Implement WebsiteDataStore quota delegate to handle quota requests.
874         By default, do not update quota.
875         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
876
877         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
878         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
879         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
880         * WebKitTestRunner/InjectedBundle/TestRunner.h:
881         * WebKitTestRunner/TestController.cpp:
882         (WTR::TestController::allowCacheStorageQuotaIncrease):
883         * WebKitTestRunner/TestController.h:
884         * WebKitTestRunner/TestInvocation.cpp:
885         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
886         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
887         (-[CacheStorageQuotaManager init]):
888         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
889         (WTR::initializeWebViewConfiguration):
890         (WTR::TestController::cocoaResetStateToConsistentValues):
891         (WTR::TestController::allowCacheStorageQuotaIncrease):
892
893 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
894
895         [ews-build] Pass owner to the triggered builds
896         https://bugs.webkit.org/show_bug.cgi?id=193574
897
898         Reviewed by Lucas Forschler.
899
900         * BuildSlaveSupport/ews-build/factories.py:
901         (BuildFactory.propertiesToPassToTriggers):
902
903 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
904
905         [ews-app] Send patch author as a build property
906         https://bugs.webkit.org/show_bug.cgi?id=193560
907
908         Reviewed by Lucas Forschler.
909
910         * BuildSlaveSupport/ews-app/ews/fetcher.py:
911         (BugzillaPatchFetcher.fetch):
912
913 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
914
915         webkitpy: Implement device type specific expected results (Follow-up fix)
916         https://bugs.webkit.org/show_bug.cgi?id=192162
917         <rdar://problem/46345449>
918
919         Unreviewed infrastructure fix.
920
921         * Scripts/webkitpy/layout_tests/controllers/manager.py:
922         (Manager.run): Don't boot a device if no tests are available to run on it.
923
924 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
925
926         webkitpy: Implement device type specific expected results (Follow-up fix)
927         https://bugs.webkit.org/show_bug.cgi?id=192162
928         <rdar://problem/46345449>
929
930         Unreviewed infrastructure fix.
931
932         * Scripts/webkitpy/api_tests/manager.py:
933         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
934
935 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
936
937         webkitpy: Implement device type specific expected results (Part 2)
938         https://bugs.webkit.org/show_bug.cgi?id=192162
939         <rdar://problem/46345449>
940
941         Rubber-stamped by Aakash Jain.
942
943         This change uses device_type to select a different set of TestExpectation files based on the type of device running
944         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
945         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
946
947         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
948         (LayoutTestFinder.find_tests): Pass device_type through.
949         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
950         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
951         * Scripts/webkitpy/layout_tests/controllers/manager.py:
952         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
953         (Manager._collect_tests): Pass device type to test finder.
954         (Manager._needs_web_platform_test):
955         (Manager._prepare_lists): Index _expectations by device type.
956         (Manager._test_input_for_file):
957         (Manager._test_is_slow): Ditto.
958         (Manager._test_should_dump_jsconsolelog_in_stderr):
959         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
960         (Manager._get_test_inputs):
961         (Manager._update_worker_count):
962         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
963         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
964         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
965         the one which runs the test.
966         (Manager._run_test_subset):
967         (Manager._run_tests): Index _expectations by current_device_type.
968         (Manager._print_expectation_line_for_test): Ditto.
969         (Manager._print_expectations_for_subset): Ditto.
970         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
971         Unlike run, this function will behave the same regardless of what devices are available.
972         (Manager._custom_device_for_test): Deleted.
973         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
974         (ManagerTest.test_uses_custom_device): Deleted.
975         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
976         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
977         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
978         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
979         all of the expectations.
980         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
981         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
982         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
983         (TestExpectations.__init__): Allow device_type to be passed through.
984         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
985         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
986         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
987         (summarize_results):
988         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
989         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
990         a test ran with, one must check all expectations to find the first non-skip expectation.
991         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
992         (RunTest.test_device_type_test_division):
993         (RunTest):
994         (RunTest.test_device_type_specific_listing):
995         * Scripts/webkitpy/port/base.py:
996         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
997         (Port.supported_device_types): The result of this function will change based on what devices are available.
998         * Scripts/webkitpy/port/device_port.py:
999         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1000         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1001         can be used.
1002         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1003         any, or the DEFAULT_DEVICE_TYPES of the port.
1004         * Scripts/webkitpy/port/ios.py:
1005         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1006         * Scripts/webkitpy/port/ios_simulator.py:
1007         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1008         * Scripts/webkitpy/port/watch.py:
1009         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1010         * Scripts/webkitpy/port/watch_simulator.py:
1011         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1012         * Scripts/webkitpy/xcode/device_type.py:
1013         (DeviceType):
1014         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1015
1016 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1017
1018         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1019         https://bugs.webkit.org/show_bug.cgi?id=193575
1020
1021         Reviewed by Michael Catanzaro.
1022
1023         Allow the script to run without explicit port argument because
1024         it's specific to the WPE port anyway.
1025
1026         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1027         and simplify the rest of the code accordingly.
1028
1029 2019-01-18  Charlie Turner  <cturner@igalia.com>
1030
1031         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1032         https://bugs.webkit.org/show_bug.cgi?id=192229
1033
1034         Reviewed by Xabier Rodriguez-Calvar.
1035
1036         * MiniBrowser/wpe/main.cpp:
1037         (main): Enable encrypted-media by default.
1038
1039 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1040
1041         [Flatpak] Missing KeyboardInterrupt exception handler
1042         https://bugs.webkit.org/show_bug.cgi?id=193570
1043
1044         Reviewed by Michael Catanzaro.
1045
1046         * flatpak/flatpakutils.py:
1047         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1048
1049 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1050
1051         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1052         https://bugs.webkit.org/show_bug.cgi?id=193564
1053
1054         Reviewed by Antti Koivisto.
1055
1056         * LayoutReloaded/misc/LFC-passing-tests.txt:
1057
1058 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1059
1060         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1061         https://bugs.webkit.org/show_bug.cgi?id=193562
1062
1063         Reviewed by Antti Koivisto.
1064
1065         * LayoutReloaded/misc/LFC-passing-tests.txt:
1066
1067 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1068
1069         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1070         https://bugs.webkit.org/show_bug.cgi?id=193555
1071
1072         Reviewed by Antti Koivisto.
1073
1074         * LayoutReloaded/misc/LFC-passing-tests.txt:
1075
1076 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1077
1078         [WPE] Add Qt extension
1079         https://bugs.webkit.org/show_bug.cgi?id=191464
1080
1081         Reviewed by Carlos Garcia Campos.
1082
1083         MiniBrowser and API tests for the WPE Qt API. To run the
1084         MiniBrowser a new script is introduced. Example invocation:
1085
1086         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1087
1088         Also note-worthy is the introduction of the python2-subprocess32
1089         dependency to run the GLib API tests.
1090
1091         * MiniBrowser/wpe/CMakeLists.txt:
1092         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1093         * MiniBrowser/wpe/qt/main.cpp: Added.
1094         (main):
1095         * MiniBrowser/wpe/qt/main.qml: Added.
1096         * MiniBrowser/wpe/qt/qml.qrc: Added.
1097         * Scripts/run-gtk-tests:
1098         (GtkTestRunner.is_google_test):
1099         (GtkTestRunner):
1100         (GtkTestRunner.is_qt_test):
1101         * Scripts/run-qt-wpe-minibrowser: Added.
1102         * Scripts/run-wpe-tests:
1103         (WPETestRunner):
1104         (WPETestRunner.is_google_test):
1105         (WPETestRunner.is_qt_test):
1106         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1107         (TestLoad::main):
1108         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1109         (TestLoadHtml::main):
1110         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1111         (TestLoadRequest::main):
1112         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1113         (TestRunJavaScript::main):
1114         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1115         (waitForSignal):
1116         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1117         (LoadSpy::LoadSpy):
1118         (LoadSpy::~LoadSpy):
1119         (LoadSpy::onLoadingChanged):
1120         (LoadStartedCatcher::LoadStartedCatcher):
1121         (LoadStartedCatcher::~LoadStartedCatcher):
1122         (LoadStartedCatcher::onLoadingChanged):
1123         (waitForLoadSucceeded):
1124         (waitForLoadFailed):
1125         * TestWebKitAPI/glib/CMakeLists.txt:
1126         * flatpak/flatpakutils.py:
1127         (WebkitFlatpak.load_from_args):
1128         (WebkitFlatpak.__init__):
1129         (WebkitFlatpak.clean_args):
1130         (WebkitFlatpak.run_in_sandbox):
1131         * flatpak/org.webkit.CommonModules.yaml:
1132         * flatpak/org.webkit.WPE.yaml:
1133         * flatpak/org.webkit.WPEModules.yaml:
1134         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1135         * flatpak/org.webkit.WebKit.yaml:
1136         * glib/api_test_runner.py:
1137         (TestRunner._run_test_qt):
1138         (TestRunner.is_qt_test):
1139         (TestRunner._run_test):
1140
1141 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1142
1143         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1144         https://bugs.webkit.org/show_bug.cgi?id=193494
1145         <rdar://problem/46859627>
1146
1147         Reviewed by Simon Fraser and Tim Horton.
1148
1149         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1150         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1151
1152         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1153         (WTR::UIScriptController::contentOffsetX const):
1154         (WTR::UIScriptController::contentOffsetY const):
1155         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1156         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1157         (WTR::UIScriptController::contentOffsetX const):
1158         (WTR::UIScriptController::contentOffsetY const):
1159         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1160
1161         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1162
1163         * WebKitTestRunner/TestController.cpp:
1164         (WTR::updateTestOptionsFromTestHeader):
1165         * WebKitTestRunner/TestOptions.h:
1166         (WTR::TestOptions::hasSameInitializationOptions const):
1167         * WebKitTestRunner/ios/TestControllerIOS.mm:
1168         (WTR::TestController::platformResetStateToConsistentValues):
1169         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1170         (WTR::UIScriptController::contentOffsetX const):
1171         (WTR::UIScriptController::contentOffsetY const):
1172
1173 2019-01-17  Truitt Savell  <tsavell@apple.com>
1174
1175         Unreviewed, rolling out r240124.
1176
1177         This commit broke an internal build.
1178
1179         Reverted changeset:
1180
1181         "SDK_VARIANT build destinations should be separate from non-
1182         SDK_VARIANT builds"
1183         https://bugs.webkit.org/show_bug.cgi?id=189553
1184         https://trac.webkit.org/changeset/240124
1185
1186 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1187
1188         Fix string concatenation API test after r239920
1189         https://bugs.webkit.org/show_bug.cgi?id=193551
1190         <rdar://problem/47359304>
1191
1192         Reviewed by Youenn Fablet.
1193
1194         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1195         (TestWebKitAPI::TEST):
1196         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1197         in WebKit's build configuration like it apparently is on Linux.
1198
1199 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1200
1201         [ews-build] validate-patch should handle the case when bug_id is None
1202         https://bugs.webkit.org/show_bug.cgi?id=193547
1203
1204         Reviewed by Lucas Forschler.
1205
1206         * BuildSlaveSupport/ews-build/steps.py:
1207         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1208         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1209
1210 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1211
1212         [ews-build] Add patch author information in build
1213         https://bugs.webkit.org/show_bug.cgi?id=193465
1214
1215         Reviewed by Lucas Forschler.
1216
1217         * BuildSlaveSupport/ews-build/steps.py:
1218         (ValidatePatch._is_patch_obsolete):
1219
1220 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1221
1222         [ews-build] Pass bug_id to the triggered builds
1223         https://bugs.webkit.org/show_bug.cgi?id=193548
1224
1225         Reviewed by Lucas Forschler.
1226
1227         * BuildSlaveSupport/ews-build/factories.py:
1228         (BuildFactory.propertiesToPassToTriggers):
1229
1230 2019-01-17  Jer Noble  <jer.noble@apple.com>
1231
1232         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1233         https://bugs.webkit.org/show_bug.cgi?id=189553
1234
1235         Reviewed by Tim Horton.
1236
1237         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1238
1239         * ContentExtensionTester/Configurations/Base.xcconfig:
1240         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1241         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1242         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1243         * ImageDiff/cg/Configurations/Base.xcconfig:
1244         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1245         * MiniBrowser/Configurations/Base.xcconfig:
1246         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1247         * MobileMiniBrowser/Configurations/Base.xcconfig:
1248         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1249         * Scripts/webkitpy/style/checker.py:
1250         (_all_categories):
1251         (FileType):
1252         (CheckerDispatcher._file_type):
1253         (CheckerDispatcher._create_checker):
1254         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1255         (SDKVariantChecker):
1256         (SDKVariantChecker.__init__):
1257         (SDKVariantChecker.check):
1258         * TestWebKitAPI/Configurations/Base.xcconfig:
1259         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1260         * WebEditingTester/Configurations/Base.xcconfig:
1261         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1262         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1263         * WebKitTestRunner/Configurations/Base.xcconfig:
1264         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1265         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1266         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1267
1268 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1269
1270         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1271         https://bugs.webkit.org/show_bug.cgi?id=193534
1272
1273         Reviewed by Antti Koivisto.
1274
1275         * LayoutReloaded/misc/LFC-passing-tests.txt:
1276
1277 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1278
1279         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1280         https://bugs.webkit.org/show_bug.cgi?id=193528
1281
1282         Reviewed by Antti Koivisto.
1283
1284         * LayoutReloaded/misc/LFC-passing-tests.txt:
1285
1286 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1287
1288         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1289         https://bugs.webkit.org/show_bug.cgi?id=193520
1290
1291         Reviewed by Antti Koivisto.
1292
1293         * LayoutReloaded/misc/LFC-passing-tests.txt:
1294
1295 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1296
1297         [ews-build] unapply-patch step should not update source
1298         https://bugs.webkit.org/show_bug.cgi?id=193234
1299
1300         Reviewed by Lucas Forschler.
1301
1302         * BuildSlaveSupport/ews-build/steps.py:
1303         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1304         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1305
1306 2019-01-16  Youenn Fablet  <youenn@apple.com>
1307
1308         Add a new SPI for controlling getUserMedia
1309         https://bugs.webkit.org/show_bug.cgi?id=192793
1310
1311         Reviewed by Eric Carlson.
1312
1313         * MiniBrowser/mac/WK2BrowserWindowController.m:
1314         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1315         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1316         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1317         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1318         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1319         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1320         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1321         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1322         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1323         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1324         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1325         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1326         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1327         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1328
1329 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1330
1331         [LFC][BFC] Inflow non-replaced used width should not be negative.
1332         https://bugs.webkit.org/show_bug.cgi?id=193495
1333
1334         Reviewed by Antti Koivisto.
1335
1336         * LayoutReloaded/misc/LFC-passing-tests.txt:
1337
1338 2019-01-16  Chris Dumez  <cdumez@apple.com>
1339
1340         Regression(PSON) View becomes blank after click a cross-site download link
1341         https://bugs.webkit.org/show_bug.cgi?id=193361
1342         <rdar://problem/47099573>
1343
1344         Reviewed by Geoffrey Garen.
1345
1346         Add API test coverage.
1347
1348         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1349         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1350
1351 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1352
1353         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1354         https://bugs.webkit.org/show_bug.cgi?id=193470
1355
1356         Reviewed by Antti Koivisto.
1357
1358         * LayoutReloaded/misc/LFC-passing-tests.txt:
1359
1360 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1361
1362         [LFC] Adjust margin box verification.
1363         https://bugs.webkit.org/show_bug.cgi?id=193482
1364
1365         Reviewed by Antti Koivisto.
1366
1367         * LayoutReloaded/misc/LFC-passing-tests.txt:
1368
1369 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1370
1371         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1372         https://bugs.webkit.org/show_bug.cgi?id=193451
1373
1374         Reviewed by Geoffrey Garen.
1375
1376         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1377         (TEST):
1378         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1379         (runWebsiteDataStoreCustomPaths):
1380
1381 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1382
1383         webkitpy: Support boolean simctl isAvailable
1384         https://bugs.webkit.org/show_bug.cgi?id=193472
1385         <rdar://problem/47296150>
1386
1387         Reviewed by Ryosuke Niwa.
1388
1389         * Scripts/webkitpy/xcode/simulated_device.py:
1390         (SimulatedDeviceManager._create_runtimes):
1391         (SimulatedDeviceManager._create_device_with_runtime):
1392
1393 2019-01-15  Chris Dumez  <cdumez@apple.com>
1394
1395         Unreviewed, rolling out r239993, r239995, r239997, and
1396         r239999.
1397
1398         Caused assertions under
1399         ViewGestureController::disconnectFromProcess()
1400
1401         Reverted changesets:
1402
1403         "Regression(PSON) View becomes blank after click a cross-site
1404         download link"
1405         https://bugs.webkit.org/show_bug.cgi?id=193361
1406         https://trac.webkit.org/changeset/239993
1407
1408         "Unreviewed iOS build fix after r239993."
1409         https://trac.webkit.org/changeset/239995
1410
1411         "Fix iOS build after r239993"
1412         https://bugs.webkit.org/show_bug.cgi?id=193361
1413         https://trac.webkit.org/changeset/239997
1414
1415         "Unreviewed, revert part of r239997 as it is not needed to fix
1416         the build."
1417         https://trac.webkit.org/changeset/239999
1418
1419 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1420
1421         Cannot tab out of WKWebView on macOS
1422         https://bugs.webkit.org/show_bug.cgi?id=161448
1423         <rdar://problem/28100085>
1424
1425         Reviewed by Dean Jackson.
1426
1427         Add a test that tabbing into and out of WKWebView works correctly.
1428
1429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1430         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1431         (WebKit2_CommandBackForwardTest::SetUp):
1432         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1433         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1434         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1435         (-[FocusableView canBecomeKeyView]):
1436         (TEST):
1437         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1438         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1439         (-[OffscreenWindow initWithSize:]):
1440         (-[OffscreenWindow isKeyWindow]):
1441         (-[OffscreenWindow isVisible]):
1442         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1443         (TestWebKitAPI::PlatformWebView::initialize):
1444         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1445         (-[ActiveOffscreenWindow isVisible]): Deleted.
1446         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1447
1448 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1449
1450         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1451         https://bugs.webkit.org/show_bug.cgi?id=193459
1452
1453         Reviewed by Mark Lam.
1454
1455         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1456         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1457
1458 2019-01-15  Chris Dumez  <cdumez@apple.com>
1459
1460         Regression(PSON) View becomes blank after click a cross-site download link
1461         https://bugs.webkit.org/show_bug.cgi?id=193361
1462         <rdar://problem/47099573>
1463
1464         Reviewed by Geoff Garen.
1465
1466         Add API test coverage.
1467
1468         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1469         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1470
1471 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1472
1473         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1474         https://bugs.webkit.org/show_bug.cgi?id=193448
1475
1476         Reviewed by Antti Koivisto.
1477
1478         * LayoutReloaded/misc/LFC-passing-tests.txt:
1479
1480 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1481
1482         webkitpy: Implement device type specific expected results (Part 1)
1483         https://bugs.webkit.org/show_bug.cgi?id=192162
1484
1485         Reviewed by Lucas Forschler.
1486
1487         Device type specific expected results covers two related ideas. The first (covered by this change)
1488         is where to search for -expected.* files. The second is which tests to run based on the
1489         TestExpectations.txt file.
1490
1491         After this change, the baseline search path will be determined by the type of device running a
1492         test. Device type will be passed into any function which picks a file based on the baseline search
1493         path.
1494
1495         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1496         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1497         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1498         (Manager.run): Print baseline search path for each round of devices.
1499         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1500         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1501         (SingleTestRunner._expected_driver_output): Ditto.
1502         (SingleTestRunner._driver_input): Ditto.
1503         * Scripts/webkitpy/layout_tests/views/printing.py:
1504         (Printer.print_config): Move printing of baseline search path to a separate function.
1505         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1506         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1507         (Testprinter.test_print_config):
1508         (Testprinter.test_print_baseline_search_path):
1509         * Scripts/webkitpy/port/base.py:
1510         (Port.baseline_search_path): Pass device_type through.
1511         (Port._expected_baselines_for_suffixes): Ditto.
1512         (Port.expected_baselines): Ditto.
1513         (Port.expected_filename): Ditto.
1514         (Port.expected_checksum): Ditto.
1515         (Port.expected_image): Ditto.
1516         (Port.expected_audio): Ditto.
1517         (Port.expected_text): Ditto.
1518         (Port.reference_files): Ditto.
1519         (Port.tests): Ditto.
1520         (Port._expanded_paths): Ditto.
1521         (Port.skipped_layout_tests): Ditto.
1522         (Port.expectations_dict): Ditto.
1523         (Port._port_specific_expectations_files): Ditto.
1524         (Port.expectations_files): Ditto.
1525         (Port.test_search_path): Ditto.
1526         (Port._tests_for_other_platforms): Ditto.
1527         * Scripts/webkitpy/port/base_unittest.py:
1528         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1529         (PortTest.test_nonexistant_expectations): Ditto.
1530         (test_ref_tests_platform_directory): Ditto.
1531         * Scripts/webkitpy/port/darwin.py:
1532         (DarwinPort._port_specific_expectations_files): Accept device_type.
1533         * Scripts/webkitpy/port/driver.py:
1534         (DriverProxy):
1535         (DriverProxy.host): Expose _target_host for device_type information.
1536         * Scripts/webkitpy/port/gtk.py:
1537         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
1538         * Scripts/webkitpy/port/ios.py:
1539         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1540         * Scripts/webkitpy/port/mac.py:
1541         (MacPort. default_baseline_search_path): Ditto.
1542         * Scripts/webkitpy/port/port_testcase.py:
1543         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
1544         * Scripts/webkitpy/port/test.py:
1545         * Scripts/webkitpy/port/watch.py:
1546         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1547         * Scripts/webkitpy/port/win.py:
1548         (WinPort.test_search_path): Accept, but do not use, device_type.
1549         * Scripts/webkitpy/port/wpe.py:
1550         (WPEPort._port_specific_expectations_files): Ditto.
1551         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1552         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
1553
1554 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1555
1556         [LFC] Use the containing block's padding box to position out-of-flow elements.
1557         https://bugs.webkit.org/show_bug.cgi?id=193431
1558
1559         Reviewed by Antti Koivisto.
1560
1561         * LayoutReloaded/misc/LFC-passing-tests.txt:
1562
1563 2019-01-14  Tim Horton  <timothy_horton@apple.com>
1564
1565         Move a test implementation file that got misplaced in the Xcode project
1566
1567         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1568
1569 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1570
1571         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1572         r239913, and r239914.
1573         https://bugs.webkit.org/show_bug.cgi?id=193407
1574
1575         These revisions caused an internal failure (Requested by
1576         Truitt on #webkit).
1577
1578         Reverted changesets:
1579
1580         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1581         https://bugs.webkit.org/show_bug.cgi?id=186016
1582         https://trac.webkit.org/changeset/239901
1583
1584         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1585         https://trac.webkit.org/changeset/239909
1586
1587         "Tried to fix the build."
1588         https://trac.webkit.org/changeset/239910
1589
1590         "Fixed iOS builds after r239910."
1591         https://trac.webkit.org/changeset/239912
1592
1593         "More build fixing."
1594         https://trac.webkit.org/changeset/239913
1595
1596         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1597         https://trac.webkit.org/changeset/239914
1598
1599 2019-01-14  Mark Lam  <mark.lam@apple.com>
1600
1601         Re-enable ability to build --cloop builds.
1602         https://bugs.webkit.org/show_bug.cgi?id=192955
1603         <rdar://problem/46882363>
1604
1605         Reviewed by Saam barati and Keith Miller.
1606
1607         The --cloop build option was being ignored this whole time since r236381.
1608         This patch makes it possible to build CLoop builds again.
1609
1610         * Scripts/build-jsc:
1611         * Scripts/webkitperl/FeatureList.pm:
1612         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1613
1614 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1615
1616         webkitpy: Expose device_type from host-like objects
1617         https://bugs.webkit.org/show_bug.cgi?id=193406
1618         <rdar://problem/47262305>
1619
1620         Reviewed by Lucas Forschler.
1621
1622         Devices should expose device_type. As a result, all host objects should
1623         provide a device_type property, even if they do not yet define a device_type.
1624
1625         * Scripts/webkitpy/common/system/systemhost.py:
1626         (SystemHost):
1627         (SystemHost.device_type):
1628         * Scripts/webkitpy/common/system/systemhost_mock.py:
1629         (MockSystemHost):
1630         (MockSystemHost.device_type):
1631         * Scripts/webkitpy/port/device.py:
1632         (Device):
1633         (Device.device_type):
1634         * Scripts/webkitpy/xcode/simulated_device.py:
1635         (SimulatedDeviceManager._find_exisiting_device_for_request):
1636         (SimulatedDeviceManager._disambiguate_device_type):
1637         (SimulatedDeviceManager._does_fulfill_request):
1638         (SimulatedDeviceManager.device_count_for_type):
1639         (SimulatedDeviceManager.initialize_devices):
1640         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1641         (test_available_devices):
1642         (test_swapping_devices):
1643
1644 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1645
1646         webkitpy: Support alternate simctl device list output (Follow-up fix)
1647         https://bugs.webkit.org/show_bug.cgi?id=193362
1648         <rdar://problem/47122965>
1649
1650         Rubber-stamped by Lucas Forschler.
1651
1652         * Scripts/webkitpy/xcode/simulated_device.py:
1653         (SimulatedDeviceManager.populate_available_devices):
1654
1655 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1656
1657         [iOS] Expose SPI to access the current sentence boundary and selection state
1658         https://bugs.webkit.org/show_bug.cgi?id=193398
1659         <rdar://problem/45893108>
1660
1661         Reviewed by Dean Jackson.
1662
1663         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
1664         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
1665         expected.
1666
1667         * TestWebKitAPI/EditingTestHarness.h:
1668         * TestWebKitAPI/EditingTestHarness.mm:
1669         (-[EditingTestHarness moveBackward]):
1670         (-[EditingTestHarness moveForward]):
1671         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
1672
1673         Add a couple of new helper methods on EditingTestHarness.
1674
1675         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1676         (-[SelectionChangeObserver initWithWebView:]):
1677         (-[SelectionChangeObserver webView]):
1678         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
1679         (-[SelectionChangeObserver currentSelectionAttributes]):
1680
1681 2019-01-14  Zalan Bujtas  <zalan@apple.com>
1682
1683         [LFC][BFC] Add basic box-sizing support.
1684         https://bugs.webkit.org/show_bug.cgi?id=193392
1685
1686         Reviewed by Antti Koivisto.
1687
1688         * LayoutReloaded/misc/LFC-passing-tests.txt:
1689
1690 2019-01-14  Charlie Turner  <cturner@igalia.com>
1691
1692         [WPE] API test gardening
1693         https://bugs.webkit.org/show_bug.cgi?id=193319
1694
1695         Reviewed by Michael Catanzaro.
1696
1697         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
1698         passing tests.
1699
1700 2019-01-14  Charlie Turner  <cturner@igalia.com>
1701
1702         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
1703         https://bugs.webkit.org/show_bug.cgi?id=192977
1704
1705         Reviewed by Carlos Garcia Campos.
1706
1707         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
1708         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1709         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
1710         (TestWebKitAPI::GStreamerTest::SetUp):
1711         (TestWebKitAPI::GStreamerTest::TearDown):
1712         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
1713         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
1714         (TestWebKitAPI::TEST_F):
1715
1716 2019-01-14  Charlie Turner  <cturner@igalia.com>
1717
1718         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
1719         https://bugs.webkit.org/show_bug.cgi?id=193332
1720
1721         Reviewed by Michael Catanzaro.
1722
1723         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
1724         defined as a char16_t, which changed in ICU 59, the
1725         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
1726         unsigned short. This test is relying on the behaviour that
1727         UChar=unsigned short, which doesn't hold across platforms and ICU
1728         library versions. The full fix would be a special syntax for
1729         literal characters so that these ambiguities do not arise. That
1730         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
1731         (TestWebKitAPI::TEST):
1732
1733 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1734
1735         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
1736
1737         * Scripts/make-dist:
1738         (Distcheck.configure):
1739
1740 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
1741
1742         [ews-build] Update macOS queue configurations
1743         https://bugs.webkit.org/show_bug.cgi?id=193365
1744         <rdar://problem/47221073>
1745
1746         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
1747
1748         * BuildSlaveSupport/ews-build/config.json:
1749
1750 2019-01-13  Zalan Bujtas  <zalan@apple.com>
1751
1752         [LFC] Adjust assert for statically positioned fixed elements
1753         https://bugs.webkit.org/show_bug.cgi?id=193385
1754
1755         Reviewed by Antti Koivisto.
1756
1757         * LayoutReloaded/misc/LFC-passing-tests.txt:
1758
1759 2019-01-13  Philippe Normand  <pnormand@igalia.com>
1760
1761         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
1762         https://bugs.webkit.org/show_bug.cgi?id=193387
1763
1764         Reviewed by Carlos Garcia Campos.
1765
1766         * MiniBrowser/wpe/main.cpp:
1767         (main):
1768
1769 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1770
1771         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1772         https://bugs.webkit.org/show_bug.cgi?id=191655
1773         rdar://problem/46074680
1774
1775         Reviewed by Megan Gardner.
1776
1777         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1778         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1779
1780 2019-01-12  Dan Bernstein  <mitz@apple.com>
1781
1782         [Cocoa] Avoid importing directly from subumbrella frameworks
1783         https://bugs.webkit.org/show_bug.cgi?id=186016
1784         <rdar://problem/40591038>
1785
1786         Reviewed by Sam Weinig.
1787
1788         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1789           LaunchServices header.
1790         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1791           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1792         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1793           when using SDKs earlier than 10.13.
1794         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1795           and OTHER_CPLUSPLUSFLAGS.
1796         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1797           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1798         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1799           LaunchServices header.
1800
1801 2019-01-11  John Wilander  <wilander@apple.com>
1802
1803         Compile out Web API Statistics Collection
1804         https://bugs.webkit.org/show_bug.cgi?id=193370
1805         <rdar://problem/45388584>
1806
1807         Reviewed by Brent Fulgham.
1808
1809         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1810             Defined ENABLE_WEB_API_STATISTICS, off by default.
1811
1812 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1813
1814         [WPE] Add gtk-doc
1815         https://bugs.webkit.org/show_bug.cgi?id=178900
1816
1817         Reviewed by Michael Catanzaro.
1818
1819         Add Tools/gtkdoc to manifest.txt.in files.
1820         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1821
1822         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1823         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1824
1825 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1826
1827         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1828         https://bugs.webkit.org/show_bug.cgi?id=193364
1829         <rdar://problem/47214117>
1830
1831         Reviewed by Tim Horton.
1832
1833         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1834         precise, whereas dragging near the middle of the textarea does.
1835
1836         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1837         (TestWebKitAPI::TEST):
1838
1839 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1840
1841         webkitpy: Support alternate simctl device list output
1842         https://bugs.webkit.org/show_bug.cgi?id=193362
1843         <rdar://problem/47122965>
1844
1845         Reviewed by Lucas Forschler.
1846
1847         * Scripts/webkitpy/xcode/simulated_device.py:
1848         (SimulatedDeviceManager.populate_available_devices):
1849
1850 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1851
1852         [ews-build] Update macOS queue configurations
1853         https://bugs.webkit.org/show_bug.cgi?id=193365
1854
1855         Reviewed by Lucas Forschler.
1856
1857         * BuildSlaveSupport/ews-build/config.json:
1858
1859 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1860
1861         webkitpy: Incorporate device type into baseline search path
1862         https://bugs.webkit.org/show_bug.cgi?id=193356
1863         <rdar://problem/47215515>
1864
1865         Reviewed by Lucas Forschler.
1866
1867         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1868
1869         * Scripts/webkitpy/port/base.py:
1870         (Port.default_baseline_search_path): Allow device type to be passed in.
1871         * Scripts/webkitpy/port/gtk.py:
1872         (GtkPort.default_baseline_search_path): Ignore device type.
1873         * Scripts/webkitpy/port/ios.py:
1874         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1875         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1876         * Scripts/webkitpy/port/ios_device_unittest.py:
1877         (IOSDeviceTest):
1878         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1879         (IOSSimulatorTest):
1880         * Scripts/webkitpy/port/mac.py:
1881         (MacPort.default_baseline_search_path): Ignore device type.
1882         * Scripts/webkitpy/port/watch.py:
1883         (WatchPort.default_baseline_search_path): Ditto.
1884         * Scripts/webkitpy/port/win.py:
1885         (WinPort.default_baseline_search_path): Ditto.
1886         (WinCairoPort.default_baseline_search_path): Ditto.
1887         * Scripts/webkitpy/port/wpe.py:
1888         (WPEPort.default_baseline_search_path): Ditto.
1889
1890 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1891
1892         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1893         https://bugs.webkit.org/show_bug.cgi?id=193352
1894         <rdar://problem/47210736>
1895
1896         Reviewed by Lucas Forschler.
1897
1898         * Scripts/webkitpy/layout_tests/views/printing.py:
1899         (Printer.print_config): Print list on only baseline search paths which exist. 
1900         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1901         (Testprinter.test_print_config):
1902
1903 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1904
1905         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1906         https://bugs.webkit.org/show_bug.cgi?id=193340
1907
1908         Reviewed by David Kilzer.
1909
1910         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1911         (WTR::InjectedBundle::didReceiveMessageToPage):
1912         Pull the strings out into a WKRetainPtr.
1913
1914         * WebKitTestRunner/WebNotificationProvider.cpp:
1915         (WTR::WebNotificationProvider::closeWebNotification):
1916         Adopt the created value into the WKRetainPtr.
1917
1918         * WebKitTestRunner/mac/TestControllerMac.mm:
1919         (WTR::generateWhitelist):
1920         Immediately adopt a created value to avoid potential mistakes.
1921
1922 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
1923
1924         Enable DFG on ARM/Linux again
1925         https://bugs.webkit.org/show_bug.cgi?id=192496
1926
1927         Reviewed by Yusuke Suzuki.
1928
1929         After changing the bytecode format DFG was disabled on all 32-bit
1930         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1931         on ARM by default.
1932
1933         * Scripts/run-jsc-stress-tests:
1934
1935 2019-01-11  Timothy Hatcher  <timothy@apple.com>
1936
1937         Unreviewed, fix #ifdef in API test added in r239851.
1938         https://bugs.webkit.org/show_bug.cgi?id=193327
1939         rdar://problem/47093222
1940
1941         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1942
1943 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1944
1945         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
1946         https://bugs.webkit.org/show_bug.cgi?id=193109
1947         <rdar://problem/44807048>
1948
1949         Reviewed by Ryosuke Niwa.
1950
1951         Introduce and respect a test option to enable the UndoManager API.
1952
1953         * WebKitTestRunner/TestController.cpp:
1954         (WTR::updateTestOptionsFromTestHeader):
1955         * WebKitTestRunner/TestOptions.h:
1956         (WTR::TestOptions::hasSameInitializationOptions const):
1957         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1958         (WTR::TestController::platformCreateWebView):
1959
1960 2019-01-11  Zalan Bujtas  <zalan@apple.com>
1961
1962         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
1963         https://bugs.webkit.org/show_bug.cgi?id=193346
1964
1965         Reviewed by Antti Koivisto.
1966
1967         * LayoutReloaded/misc/LFC-passing-tests.txt:
1968
1969 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1970
1971         Unreviewed, fix typo that breaks dashboard link.
1972
1973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1974         (WebKitBuildbot):
1975
1976 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1977
1978         Update macOS queue configurations
1979         https://bugs.webkit.org/show_bug.cgi?id=193329
1980
1981         Reviewed by Alexey Proskuryakov.
1982
1983         * BuildSlaveSupport/build.webkit.org-config/config.json:
1984         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1985         (BubbleQueueServer):
1986         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1987         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1988         (WebKitBuildbot):
1989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1990         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
1991         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1992
1993 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1994
1995         MiniBrowser should be able to navigate to about:blank
1996         https://bugs.webkit.org/show_bug.cgi?id=193345
1997
1998         Reviewed by Simon Fraser.
1999
2000         * MiniBrowser/mac/BrowserWindowController.m:
2001         (-[BrowserWindowController addProtocolIfNecessary:]):
2002         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2003
2004         * MiniBrowser/mac/WK1BrowserWindowController.m:
2005         (-[WK1BrowserWindowController fetch:]):
2006         * MiniBrowser/mac/WK2BrowserWindowController.m:
2007         (-[WK2BrowserWindowController fetch:]):
2008         Clean up the code that uses this to match style.
2009
2010 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2011
2012         Remove MiniBrowser custom "Process Swap" menu item which does not work
2013         https://bugs.webkit.org/show_bug.cgi?id=193344
2014
2015         Reviewed by Simon Fraser.
2016
2017         There is a menu item under the Experimental menu that does work.
2018
2019         * MiniBrowser/mac/AppDelegate.m:
2020         (defaultConfiguration):
2021         * MiniBrowser/mac/SettingsController.h:
2022         * MiniBrowser/mac/SettingsController.m:
2023         (-[SettingsController _populateMenu]):
2024         (-[SettingsController validateMenuItem:]):
2025         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2026         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2027
2028 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2029
2030         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2031         https://bugs.webkit.org/show_bug.cgi?id=193327
2032         rdar://problem/47093222
2033
2034         Reviewed by Tim Horton.
2035
2036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2037         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2038         (TestWebKitAPI::didFinishNavigation):
2039         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2040         (TestWebKitAPI::TEST):
2041         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2042         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2043         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2044         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2045         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2046
2047 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2048
2049         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2050         https://bugs.webkit.org/show_bug.cgi?id=193338
2051         <rdar://problem/46664774>
2052
2053         Reviewed by David Kilzer.
2054
2055         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2056         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2057
2058 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2059
2060         Unreviewed, rolling out r239825.
2061         https://bugs.webkit.org/show_bug.cgi?id=193330
2062
2063         Broke tests on armv7/linux bots (Requested by guijemont on
2064         #webkit).
2065
2066         Reverted changeset:
2067
2068         "Enable DFG on ARM/Linux again"
2069         https://bugs.webkit.org/show_bug.cgi?id=192496
2070         https://trac.webkit.org/changeset/239825
2071
2072 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2073
2074         Disable the run-jsc-stress-test remote host key check.
2075         https://bugs.webkit.org/show_bug.cgi?id=192988
2076
2077         Reviewed by Alexey Proskuryakov.
2078
2079         * Scripts/run-jsc-stress-tests:
2080
2081 2019-01-10  John Wilander  <wilander@apple.com>
2082
2083         Override the session configuration for cookieAcceptPolicy
2084         https://bugs.webkit.org/show_bug.cgi?id=190925
2085         <rdar://problem/45497382>
2086
2087         Reviewed by Alexey Proskuryakov and Alex Christensen.
2088
2089         Test infrastructure for setting a first-party-only cookie policy.
2090
2091         * DumpRenderTree/TestRunner.cpp:
2092         (setOnlyAcceptFirstPartyCookiesCallback):
2093         (TestRunner::staticFunctions):
2094         * DumpRenderTree/TestRunner.h:
2095         * DumpRenderTree/mac/TestRunnerMac.mm:
2096         (TestRunner::setOnlyAcceptFirstPartyCookies):
2097         * DumpRenderTree/win/TestRunnerWin.cpp:
2098         (TestRunner::setOnlyAcceptFirstPartyCookies):
2099         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2100         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2101         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2102         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2103         * WebKitTestRunner/TestInvocation.cpp:
2104         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2105
2106 2019-01-09  Matt Rajca  <mrajca@apple.com>
2107
2108         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2109         https://bugs.webkit.org/show_bug.cgi?id=193301
2110
2111         Reviewed by Jer Noble.
2112         
2113         Added API tests.
2114
2115         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2116         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2117         (TEST):
2118         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2119
2120 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2121
2122         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2123         https://bugs.webkit.org/show_bug.cgi?id=193310
2124
2125         Reviewed by Antti Koivisto.
2126
2127         * LayoutReloaded/misc/LFC-passing-tests.txt:
2128
2129 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2130
2131         Enable DFG on ARM/Linux again
2132         https://bugs.webkit.org/show_bug.cgi?id=192496
2133
2134         Reviewed by Yusuke Suzuki.
2135
2136         After changing the bytecode format DFG was disabled on all 32-bit
2137         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2138         on ARM by default.
2139
2140         * Scripts/run-jsc-stress-tests:
2141
2142 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2143
2144         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2145         https://bugs.webkit.org/show_bug.cgi?id=193271
2146
2147         Reviewed by Brent Fulgham.
2148
2149         BSTR is a special data structure created by SysAllocString, not a
2150         wchar_t null-terminated string.
2151
2152         * DumpRenderTree/win/TestRunnerWin.cpp:
2153         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2154         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2155         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2156         BSTR from wide string literals.
2157
2158 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2159
2160         Tweak wording for build/version_check style checker error
2161         https://bugs.webkit.org/show_bug.cgi?id=193256
2162
2163         Reviewed by Tim Horton.
2164
2165         * Scripts/webkitpy/style/checkers/cpp.py:
2166         (check_os_version_checks):
2167         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2168         (WebKitStyleTest.test_os_version_checks):
2169
2170 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2171
2172         [ews-build] Add link to bug along with bug title
2173         https://bugs.webkit.org/show_bug.cgi?id=193293
2174
2175         Reviewed by Lucas Forschler.
2176
2177         * BuildSlaveSupport/ews-build/steps.py:
2178         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2179         (ConfigureBuild.add_bug_id_url): Deleted.
2180         (ConfigureBuild.getBugURL): Deleted.
2181
2182 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2183
2184         [ews-build] Use https for ews-build server
2185         https://bugs.webkit.org/show_bug.cgi?id=193193
2186
2187         Reviewed by Lucas Forschler.
2188
2189         * BuildSlaveSupport/ews-build/steps.py:
2190
2191 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2192
2193         [ews-build] Parse and display number of style failures
2194         https://bugs.webkit.org/show_bug.cgi?id=193280
2195
2196         Reviewed by Lucas Forschler.
2197
2198         * BuildSlaveSupport/ews-build/steps.py:
2199         (CheckStyle): Use TestWithFailureCount as base class.
2200         (CheckStyle.countFailures): Count the number of style failures.
2201
2202 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2203
2204         [ews-build] use patch_id instead of ewspatchid
2205         https://bugs.webkit.org/show_bug.cgi?id=193235
2206
2207         Reviewed by Lucas Forschler.
2208
2209         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2210         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2211         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2212
2213 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2214
2215         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2216         https://bugs.webkit.org/show_bug.cgi?id=192625
2217
2218         Reviewed by Antti Koivisto.
2219
2220         * LayoutReloaded/misc/LFC-passing-tests.txt:
2221
2222 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2223
2224         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2225         https://bugs.webkit.org/show_bug.cgi?id=192841
2226
2227         Reviewed by Carlos Garcia Campos.
2228
2229         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2230         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2231         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2232
2233         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2234
2235         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2236         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2237         (WebKitWebEditorTest::testSelectionChanged):
2238         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2239         (WebKitFrameTest::testMainFrame):
2240         (WebKitFrameTest::testURI):
2241         (WebKitFrameTest::testJavaScriptContext):
2242         (WebKitFrameTest::testJavaScriptValues):
2243         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2244         (testWebViewAuthenticationRequest):
2245         (testWebViewAuthenticationLoadCancelled):
2246         (testWebViewAuthenticationFailure):
2247         (testWebViewAuthenticationStorage):
2248         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2249         (testWebViewAuthenticationProxy):
2250         (testWebViewAuthenticationProxyHTTPS):
2251         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2252         (testAutomationSessionRequestSession):
2253         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2254         (testBackForwardListNavigation):
2255         (testWebKitWebViewSessionState):
2256         (testWebKitWebViewSessionStateWithFormData):
2257         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2258         (ConsoleMessageTest::consoleMessageReceivedCallback):
2259         (testWebKitConsoleMessageConsoleAPI):
2260         (testWebKitConsoleMessageJavaScriptException):
2261         (testWebKitConsoleMessageNetworkError):
2262         (testWebKitConsoleMessageSecurityError):
2263         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2264         (testCookieManagerAcceptPolicy):
2265         (testCookieManagerCookiesChanged):
2266         (testCookieManagerPersistentStorage):
2267         (testCookieManagerPersistentStorageDeleteAll):
2268         (testCookieManagerEphemeral):
2269         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2270         (testWebKitDOMElementAutoFill):
2271         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2272         (downloadLocalFileSuccessfully):
2273         (createFileAtDestination):
2274         (testDownloadOverwriteDestinationDisallowed):
2275         (testDownloadLocalFileError):
2276         (testDownloadRemoteFile):
2277         (testDownloadRemoteFileError):
2278         (testWebViewDownloadURI):
2279         (testPolicyResponseDownload):
2280         (testPolicyResponseDownloadCancel):
2281         (testDownloadMIMEType):
2282         (contextMenuCallback):
2283         (testContextMenuDownloadActions):
2284         (testBlobDownload):
2285         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2286         (testWebKitWebEditorSelectionChanged):
2287         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2288         (testWebKitFrameMainFrame):
2289         (testWebKitFrameURI):
2290         (testWebKitFrameJavaScriptContext):
2291         (testWebKitFrameJavaScriptValues):
2292         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2293         (LoadStopTrackingTest::loadFailed):
2294         (testWebViewTitle):
2295         (testURIRequestHTTPHeaders):
2296         (testURIRequestHTTPMethod):
2297         (testURIResponseHTTPHeaders):
2298         (testRedirectToDataURI):
2299         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2300         (testProcessPerWebView):
2301         (testWebProcessLimit):
2302         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2303         (testWebViewResources):
2304         (testWebResourceLoading):
2305         (testWebResourceSuggestedFilename):
2306         (testWebResourceGetData):
2307         (testWebResourceGetDataError):
2308         (testWebViewResourcesHistoryCache):
2309         (testWebResourceSendRequest):
2310         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2311         (testSSL):
2312         (testInsecureContent):
2313         (testTLSErrorsPolicy):
2314         (testTLSErrorsRedirect):
2315         (testTLSErrorsHTTPAuth):
2316         (testLoadFailedWithTLSErrors):
2317         (testSubresourceLoadFailedWithTLSErrors):
2318         (httpsServerCallback):
2319         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2320         (testWebViewCreateNavigationData):
2321         (testWebViewJavaScriptDialogs):
2322         (testWebViewWindowProperties):
2323         (testWebViewMouseTarget):
2324         (testWebViewFileChooserRequest):
2325         (testWebViewColorChooserRequest):
2326         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2327         (testWebExtensionGetTitle):
2328         (testDocumentLoadedSignal):
2329         (testWebKitWebViewProcessCrashed):
2330         (testWebExtensionWindowObjectCleared):
2331         (testWebExtensionIsolatedWorld):
2332         (permissionRequestCallback):
2333         (didAssociateFormControlsCallback):
2334         (testWebExtensionFormControlsAssociated):
2335         (FormSubmissionTest::FormSubmissionTest):
2336         (FormSubmissionTest::testFormSubmissionResult):
2337         (testWebExtensionFormSubmissionSteps):
2338         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2339         (testNotInitialized):
2340         (testClearDatabase):
2341         (testPrivateBrowsing):
2342         (testGetFavicon):
2343         (testWebViewFavicon):
2344         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2345         (testFindControllerTextFound):
2346         (testFindControllerTextNotFound):
2347         (testFindControllerMatchCount):
2348         (testFindControllerMaxMatchCount):
2349         (testFindControllerNext):
2350         (testFindControllerPrevious):
2351         (testFindControllerCountedMatches):
2352         (testFindControllerOptions):
2353         (testFindControllerHide):
2354         (testFindControllerInstance):
2355         (testFindControllerGetters):
2356         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2357         (testNavigationPolicy):
2358         (testResponsePolicy):
2359         (testNewWindowPolicy):
2360         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2361         (testSecurityOriginBasicConstructor):
2362         (testSecurityOriginURIConstructor):
2363         (testSecurityOriginDefaultPort):
2364         (testSecurityOriginFileURI):
2365         (testOpaqueSecurityOrigin):
2366         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2367         (testWebKitSettings):
2368         (testWebKitSettingsNewWithSettings):
2369         (testWebKitSettingsUserAgent):
2370         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2371         (testWebViewNewWithUserContentManager):
2372         (isStyleSheetInjectedForURLAtPath):
2373         (isScriptInjectedForURLAtPath):
2374         (testUserContentManagerInjectedStyleSheet):
2375         (testUserContentManagerInjectedScript):
2376         (UserScriptMessageTest::scriptMessageReceived):
2377         (UserScriptMessageTest::waitUntilMessageReceived):
2378         (UserScriptMessageTest::runJavaScriptFinished):
2379         (testUserContentManagerScriptMessageReceived):
2380         (testUserContentManagerScriptMessageInWorldReceived):
2381         (testUserContentManagerScriptMessageFromDOMBindings):
2382         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2383         (testWebContextDefault):
2384         (testWebContextEphemeral):
2385         (testWebContextGetPlugins):
2386         (testWebContextURIScheme):
2387         (testWebContextSpellChecker):
2388         (testWebContextLanguages):
2389         (consoleMessageReceivedCallback):
2390         (testWebContextSecurityFileXHR):
2391         (ProxyTest::ProxyTest):
2392         (testWebContextProxySettings):
2393         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2394         (testWebViewWebContext):
2395         (testWebViewWebBackend):
2396         (testWebViewEphemeral):
2397         (testWebViewCustomCharset):
2398         (testWebViewSettings):
2399         (testWebViewRunJavaScript):
2400         (testWebViewCanShowMIMEType):
2401         (testWebViewSubmitForm):
2402         (testWebViewSave):
2403         (testWebViewPageVisibility):
2404         (testWebViewSnapshot):
2405         (testWebViewNotification):
2406         (testWebViewNotificationInitialPermissionAllowed):
2407         (testWebViewNotificationInitialPermissionDisallowed):
2408         (testWebViewIsPlayingAudio):
2409         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2410         (WebsiteDataTest::WebsiteDataTest):
2411         (WebsiteDataTest::remove):
2412         (WebsiteDataTest::clear):
2413         (testWebsiteDataConfiguration):
2414         (testWebsiteDataEphemeral):
2415         (testWebsiteDataCache):
2416         (testWebsiteDataStorage):
2417         (testWebsiteDataDatabases):
2418         (testWebsiteDataAppcache):
2419         (testWebsiteDataCookies):
2420         (testWebsiteDataDeviceIdHashSalt):
2421         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2422         (emitDocumentLoaded):
2423         (emitURIChanged):
2424         (sendRequestCallback):
2425         (contextMenuCallback):
2426         (consoleMessageSentCallback):
2427         (emitFormControlsAssociated):
2428         (formControlsAssociatedCallback):
2429         (emitFormSubmissionEvent):
2430         (willSubmitFormCallback):
2431         (windowObjectCleared):
2432         (methodCallCallback):
2433         (registerGResource):
2434         (webkit_web_extension_initialize_with_user_data):
2435         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2436         (checkLeaks):
2437         (WebProcessTest::create):
2438         (runTest):
2439         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2440         (AutocleanupsTest::testWebProcessAutocleanups):
2441         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2442         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2443         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2444         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2445         (WebKitDOMDOMWindowTest::testSignals):
2446         (WebKitDOMDOMWindowTest::testDispatchEvent):
2447         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2448         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2449         (WebKitDOMNodeFilterTest::testTreeWalker):
2450         (WebKitDOMNodeFilterTest::testNodeIterator):
2451         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2452         (WebKitDOMNodeTest::testHierarchyNavigation):
2453         (WebKitDOMNodeTest::testInsertion):
2454         (WebKitDOMNodeTest::testTagNamesNodeList):
2455         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2456         (WebKitDOMNodeTest::testDOMCache):
2457         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2458         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2459         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2460         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2461         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2462         (testUIProcessAutocleanups):
2463         (testWebProcessAutocleanups):
2464         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2465         (testContextMenuPopulateMenu):
2466         (testContextMenuDismissed):
2467         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2468         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2469         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2470         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2471         (testWebKitDOMDOMWindowSignals):
2472         (testWebKitDOMDOMWindowDispatchEvent):
2473         (testWebKitDOMDOMWindowGetComputedStyle):
2474         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2475         (testWebKitDOMNodeHierarchyNavigation):
2476         (testWebKitDOMNodeInsertion):
2477         (testWebKitDOMNodeTagNamesNodeList):
2478         (testWebKitDOMNodeTagNamesHTMLCollection):
2479         (testWebKitDOMObjectCache):
2480         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2481         (testWebKitDOMNodeFilterTreeWalker):
2482         (testWebKitDOMNodeFilterNodeIterator):
2483         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2484         (testWebKitDOMXPathNSResolverNative):
2485         (testWebKitDOMXPathNSResolverCustom):
2486         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2487         (testInspectorDefault):
2488         (testInspectorManualAttachDetach):
2489         (testInspectorCustomContainerDestroyed):
2490         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2491         (startTestServer):
2492         (testInspectorServerPageList):
2493         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2494         (OptionMenuTest::showOptionMenuCallback):
2495         (OptionMenuTest::menuCloseCallback):
2496         (OptionMenuTest::close):
2497         (OptionMenuTest::activateItem):
2498         (OptionMenuTest::selectItem):
2499         (testOptionMenuSimple):
2500         (testOptionMenuGroups):
2501         (testOptionMenuActivate):
2502         (testOptionMenuSelect):
2503         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2504         (testPrintOperationPrintSettings):
2505         (webViewPrintCallback):
2506         (testPrintOperationPrint):
2507         (testPrintCustomWidget):
2508         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2509         (checkAtspiAccessible):
2510         (testAtspiBasicHierarchy):
2511         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2512         (testWebKitCheckVersion):
2513         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2514         (testWebViewEditorCutCopyPasteNonEditable):
2515         (testWebViewEditorCutCopyPasteEditable):
2516         (testWebViewEditorSelectAllNonEditable):
2517         (testWebViewEditorSelectAllEditable):
2518         (loadContentsAndTryToCutSelection):
2519         (testWebViewEditorNonEditable):
2520         (testWebViewEditorEditable):
2521         (testWebViewEditorEditorStateTypingAttributes):
2522         (testWebViewEditorInsertImage):
2523         (testWebViewEditorCreateLink):
2524         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2525         (loadChangedCallback):
2526         (loadFailedCallback):
2527         (loadFailedWithTLSErrorsCallback):
2528         (LoadTrackingTest::LoadTrackingTest):
2529         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2530         (registerGResource):
2531         (removeNonEmptyDirectory):
2532         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2533         (Test::adoptView):
2534         (Test::~Test):
2535         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2536         (WebKitTestBus::getOrCreateConnection):
2537         (WebKitTestBus::createProxy):
2538         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2539         (WebKitTestServer::getWebSocketURIForPath const):
2540         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2541         (WebViewTest::initializeWebView):
2542         (WebViewTest::loadURI):
2543         (WebViewTest::loadHtml):
2544         (WebViewTest::loadPlainText):
2545         (WebViewTest::loadBytes):
2546         (WebViewTest::loadRequest):
2547         (WebViewTest::loadAlternateHTML):
2548         (WebViewTest::goBack):
2549         (WebViewTest::goForward):
2550         (WebViewTest::goToBackForwardListItem):
2551         (resourceGetDataCallback):
2552         (WebViewTest::mainResourceData):
2553         (WebViewTest::javascriptResultToCString):
2554         (WebViewTest::javascriptResultToNumber):
2555         (WebViewTest::javascriptResultToBoolean):
2556         (WebViewTest::javascriptResultIsNull):
2557         (WebViewTest::javascriptResultIsUndefined):
2558         (onSnapshotReady):
2559         (WebViewTest::runWebProcessTest):
2560         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
2561         (WebViewTest::platformInitializeWebView):
2562         (WebViewTest::showInWindow):
2563         (WebViewTest::showInWindowAndWaitUntilMapped):
2564         (WebViewTest::mouseMoveTo):
2565         (WebViewTest::emitPopupMenuSignal):
2566         (WebViewTest::keyStroke):
2567         (WebViewTest::doMouseButtonEvent):
2568
2569 2019-01-09  Philippe Normand  <pnormand@igalia.com>
2570
2571         [WPE] API tests can't run in flatpak environment
2572         https://bugs.webkit.org/show_bug.cgi?id=193242
2573
2574         Reviewed by Michael Catanzaro.
2575
2576         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
2577         flatpakutils so that it knows which port it's dealing with.
2578         * glib/common.py: Remove build_dir globals so that subsequent
2579         calls actually take args into account.
2580         (library_build_path):
2581         (binary_build_path):
2582
2583 2019-01-08  Dean Jackson  <dino@apple.com>
2584
2585         Blob references for System Previews don't get a correct file extension
2586         https://bugs.webkit.org/show_bug.cgi?id=193268
2587         <rdar://problem/47133037>
2588
2589         Reviewed by Tim Horton.
2590
2591         New test that a Blob download of a USDZ file gets named correctly.
2592
2593         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2594         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2595         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2596         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
2597         (TEST):
2598         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
2599
2600 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
2601
2602         [WebAuthN] Support U2F HID Authenticators on macOS
2603         https://bugs.webkit.org/show_bug.cgi?id=191535
2604         <rdar://problem/47102027>
2605
2606         Reviewed by Brent Fulgham.
2607
2608         This patch:
2609         1) adds support for U2F mocking mechanism;
2610         2) updates tests to reflect U2fCommandConstructor changes.
2611
2612         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2613         (TestWebKitAPI::TEST):
2614         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2615         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2616         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2617
2618 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2619
2620         [iOS] Dispatch a synthetic mousedown event prior to starting drags
2621         https://bugs.webkit.org/show_bug.cgi?id=193229
2622         <rdar://problem/46717097>
2623
2624         Reviewed by Tim Horton.
2625
2626         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
2627         prevents a drag from starting.
2628
2629         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2630         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
2631
2632         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
2633
2634 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
2635   
2636         Layout test will generate a perf metric file to results dir.
2637         https://bugs.webkit.org/show_bug.cgi?id=192030
2638         <rdar://problem/32779516>
2639
2640         Reviewed by Aakash Jain.
2641
2642         Layout test running time will be collected to a perf metric file.
2643         For now, instead of outputing running time of all tests (which is huge),
2644         we aggregate them by test directories which are at most two level deep. 
2645
2646         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2647         (Manager._end_test_run):
2648         (Manager._output_perf_metrics):
2649         (Manager._print_expectation_line_for_test):
2650         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2651         (add_test_perf_metric):
2652         (test_perf_metrics):
2653         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2654         (JSONGeneratorTest.test_test_timings_trie):
2655         (JSONGeneratorTest):
2656         (JSONGeneratorTest.test_test_perf_metrics):
2657         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2658         (RebaselineTest.test_reset_results):
2659         (RebaselineTest.test_missing_results):
2660         (RebaselineTest.test_new_baseline):
2661
2662 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
2663
2664         [WPE][GTK] Add php-json to install-dependencies
2665         https://bugs.webkit.org/show_bug.cgi?id=193233
2666
2667         Reviewed by Michael Catanzaro.
2668
2669         * gtk/install-dependencies:
2670         * wpe/install-dependencies:
2671
2672 2019-01-08  Chris Dumez  <cdumez@apple.com>
2673
2674         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
2675         https://bugs.webkit.org/show_bug.cgi?id=193224
2676         <rdar://problem/47097726>
2677
2678         Reviewed by Alex Christensen.
2679
2680         Add API test coverage.
2681
2682         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2683
2684 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2685
2686         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
2687         <https://webkit.org/b/193222>
2688         <rdar://problem/46862309>
2689
2690         Reviewed by Joseph Pecoraro.
2691
2692         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2693         (WTR::executeCallback): Fix camel case of variable name.
2694         (WTR::EventSendingController::callAfterScrollingCompletes): If
2695         WKBundlePageRegisterScrollOperationCompletionCallback() returns
2696         false, make sure to release the ScrollCompletionCallbackData
2697         object.  This fixes the leak.
2698
2699 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2700
2701         [Win] EWS: wincairo-ews cannot apply a patch with *.png
2702         https://bugs.webkit.org/show_bug.cgi?id=193044
2703
2704         Reviewed by Daniel Bates.
2705
2706         WinCairo EWS bots are using Windows Perl. Binary files should be
2707         opened as binary mode.
2708
2709         * Scripts/svn-apply:
2710         (handleGitBinaryChange): Use 'binmode' for binary file handles.
2711
2712 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
2713
2714         [CMake] Add ENABLE_CSS_TYPED_OM option
2715         https://bugs.webkit.org/show_bug.cgi?id=193216
2716
2717         Reviewed by Michael Catanzaro.
2718
2719         * Scripts/webkitperl/FeatureList.pm:
2720
2721 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2722
2723         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
2724         <https://webkit.org/b/193056>
2725
2726         Reviewed by Alex Christensen.
2727
2728         * Scripts/webkitpy/style/checker.py:
2729         - Ignore use of new runtime/retainptr check in
2730           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
2731           contains tests to ensure RetainPtr<NSObject *> is compatible
2732           with RetainPtr<NSObject>.
2733
2734         * Scripts/webkitpy/style/checkers/cpp.py:
2735         (check_language):
2736         (CppChecker):
2737         - Add checker for use of '*' in RetainPtr<> type.  A for loop
2738           was used instead of a single regex so that angle brackets
2739           could be matched up when checking the type contained within
2740           the RetainPtr<> type.
2741
2742         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2743         (CppStyleTest):
2744         - Add unit test for new runtime/retainptr check.
2745
2746         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
2747         * TestWebKitAPI/EditingTestHarness.h:
2748         - Remove '*' from RetainPtr<> type.
2749
2750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2751         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
2752           regressed in r201938.
2753
2754         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2755         (TestWebKitAPI::TEST):
2756         - Update tests to match RetainPtr.mm tests (except for the
2757           `*SimilarNSType` tests since there is no CF equivalent of
2758           RetainPtr<NSString> and RetainPtr<NSString *>).
2759
2760         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2761         (TestWebKitAPI::TEST):
2762         - Update tests to:
2763           - Not conflict by name with equivalent CF tests in
2764             RetainPtr.cpp.
2765           - Add test cases for RetainPtr<NSObject>,
2766             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
2767           - Add `*SimilarNSType` tests for converting between
2768             RetainPtr<NSObject> and RetainPtr<NSObject *>.
2769           - Change `0` to `nil` as appropriate.
2770           - Re-alphabetize the tests by name.
2771           - Add Optional<RetainPtr<>> tests.
2772           - Add retainPtr() tests.
2773
2774         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2775         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2776         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
2777         (TEST):
2778         - Remove '*' from RetainPtr<> type.
2779
2780         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
2781         (TEST(WebKit, JITEnabled)):
2782         - Add missing WTFMove().  Apparently a temporary was being
2783           created before in the argument list due to mismatched
2784           RetainPtr<> types.
2785
2786         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2787         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2788         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2789         (TestWebKitAPI::TEST):
2790         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2791         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2792         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2793         (WTR::resourcesDirectoryURL):
2794         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2795         (WTR::InjectedBundle::platformInitialize):
2796         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2797         - Remove '*' from RetainPtr<> type.
2798
2799 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
2800
2801         A MediaTime timescale must never be zero
2802         https://bugs.webkit.org/show_bug.cgi?id=193156
2803         <rdar://problem/32504501>
2804
2805         Reviewed by Jer Noble.
2806
2807         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2808         (TestWebKitAPI::TEST): Add tests for zero timescale.
2809
2810 2019-01-07  Youenn Fablet  <youenn@apple.com>
2811
2812         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2813         https://bugs.webkit.org/show_bug.cgi?id=193175
2814
2815         Reviewed by Chris Dumez.
2816
2817         Updated API test as we bumped the SW schema to version 4.
2818
2819         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2820         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2821         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2822         (TEST):
2823
2824 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2825
2826         [Win][Clang] Fix compilation warnings of MiniBrowser
2827         https://bugs.webkit.org/show_bug.cgi?id=193029
2828
2829         Reviewed by Ross Kirsling.
2830
2831         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2832         and m_URLBarFont. Reorder member variables to fix -Wreorder
2833         warning.
2834         * MiniBrowser/win/PageLoadTestClient.cpp:
2835         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2836         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2837         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2838         m_currentURLIndex.
2839         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2840         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2841         navigationClient with '{ }' to fix the missing field warning.
2842         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2843         (initDocStruct): Changed the argument type docname to const.
2844
2845 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2846
2847         [WebAuthN] Import U2F command/response converters from Chromium
2848         https://bugs.webkit.org/show_bug.cgi?id=193150
2849         <rdar://problem/47054028>
2850
2851         Reviewed by Brent Fulgham.
2852
2853         Adds API tests.
2854
2855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2856         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2857         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2858         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2859         (TestWebKitAPI::getTestAttestationObjectBytes):
2860         (TestWebKitAPI::getTestSignResponse):
2861         (TestWebKitAPI::getTestU2fRegisterResponse):
2862         (TestWebKitAPI::TEST):
2863         (TestWebKitAPI::convertToVector): Deleted.
2864         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2865         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2866         (TestWebKitAPI::constructMakeCredentialRequest):
2867         (TestWebKitAPI::constructGetAssertionRequest):
2868         (TestWebKitAPI::TEST):
2869
2870 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2871
2872         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2873         https://bugs.webkit.org/show_bug.cgi?id=193136
2874
2875         Reviewed by Michael Catanzaro.
2876
2877         * gtk/install-dependencies:
2878         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2879         they are needed by update-webkitgtk-libs.
2880
2881 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2882
2883         Unreviewed follow-up fix to r239650
2884         https://bugs.webkit.org/show_bug.cgi?id=193140
2885         <rdar://problem/47063037>
2886
2887         Typecast patch_id to string.
2888
2889         * BuildSlaveSupport/ews-build/steps.py:
2890         (ValidatePatch._is_patch_obsolete):
2891
2892 2019-01-04  Daniel Bates  <dabates@apple.com>
2893
2894         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2895         https://bugs.webkit.org/show_bug.cgi?id=193024
2896
2897         Reviewed by Jer Noble.
2898
2899         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2900         for the bitmask type WebEventFlags as an example.
2901
2902         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2903         that can be used to register summary and synthetic child formatters for a bitmask type.
2904         For example, consider the following enum and bitmask typedefs:
2905
2906         typedef enum {
2907             A = 1 << 0,
2908             B = 1 << 1,
2909             C = 1 << 2,
2910         } SpecialFlagValues;
2911         typedef unsigned SpecialFlags;
2912
2913         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
2914         __lldb_init_module():
2915
2916             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
2917                     1 << 0: "A",
2918                     1 << 1: "B",
2919                     1 << 2: "C",
2920             })
2921
2922         * lldb/lldb_webkit.py:
2923         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2924         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
2925         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
2926         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
2927         A convenience function to dynamically creaste a synthetic formatter class and summary
2928         string function for the specified bitmask type and enumerator value to name map. This
2929         function register the dynamically created class and function with LLDB.
2930
2931         (__lldb_init_module):
2932         (FlagEnumerationProvider):
2933         (FlagEnumerationProvider._enumerator_value_to_name_map):
2934         (FlagEnumerationProvider._bitmask):
2935         (FlagEnumerationProvider._update):
2936         (FlagEnumerationProvider.has_children):
2937         (FlagEnumerationProvider.num_children):
2938         (FlagEnumerationProvider.get_child_index):
2939         (FlagEnumerationProvider.get_child_at_index):
2940         (FlagEnumerationProvider.update):
2941         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
2942
2943         (WTFOptionSetProvider):
2944         (WTFOptionSetProvider._enumerator_value_to_name_map):
2945         (WTFOptionSetProvider._bitmask):
2946         (WTFOptionSetProvider._update):
2947         Write in terms of the base class.
2948
2949         (RawBitmaskProviderBase):
2950         (RawBitmaskProviderBase._enumerator_value_to_name_map):
2951         (RawBitmaskProviderBase._bitmask):
2952         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
2953         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
2954         {
2955             1 << 0: "A",
2956             1 << 1: "B",
2957             1 << 2: "C",
2958         }
2959         It is not necessary to instantiate such a derived class directory. Instead use the convenience
2960         function addSummaryAndSyntheticFormattersForRawBitmaskType.
2961
2962         (WTFOptionSetProvider.has_children): Deleted.
2963         (WTFOptionSetProvider.num_children): Deleted.
2964         (WTFOptionSetProvider.get_child_index): Deleted.
2965         (WTFOptionSetProvider.get_child_at_index): Deleted.
2966         (WTFOptionSetProvider.update): Deleted.
2967
2968 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2969
2970         [ews-build] Add build step to validate the patch before processing it
2971         https://bugs.webkit.org/show_bug.cgi?id=193140
2972
2973         Reviewed by Lucas Forschler.
2974
2975         * BuildSlaveSupport/ews-build/factories.py:
2976         (Factory.__init__): Added ValidatePatch step.
2977         * BuildSlaveSupport/ews-build/steps.py:
2978         (ValidatePatch):
2979         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
2980         (ValidatePatch.get_patch_json): Get patch json data.
2981         (ValidatePatch.get_bug_json): Get bug json data.
2982         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
2983         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
2984         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
2985         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
2986         (ValidatePatch.skip_build): Skip the build.
2987         (ValidatePatch.start):
2988
2989 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2990
2991         Progress towards fixing Mac CMake build
2992         https://bugs.webkit.org/show_bug.cgi?id=193105
2993
2994         Reviewed by Don Olmstead.
2995
2996         * TestWebKitAPI/PlatformMac.cmake:
2997
2998 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2999
3000         Fix API test after r239631
3001         https://bugs.webkit.org/show_bug.cgi?id=193118
3002
3003         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3004         (TestWebKitAPI::TEST):
3005         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3006         Do the same thing via the API to fix the test.
3007
3008 2019-01-04  Jer Noble  <jer.noble@apple.com>
3009
3010         [WebKitLegacy] Media playback pauses on scroll
3011         https://bugs.webkit.org/show_bug.cgi?id=192829
3012
3013         Reviewed by Eric Carlson.
3014
3015         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3016         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3017         (TestWebKitAPI::TEST):
3018         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3019         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3020         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3021         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3022         (TestWebKitAPI::TEST):
3023
3024 2019-01-04  Chris Dumez  <cdumez@apple.com>
3025
3026         Add support for toggling device orientation API support per site
3027         https://bugs.webkit.org/show_bug.cgi?id=193143
3028         <rdar://problem/46605724>
3029
3030         Reviewed by Alex Christensen.
3031
3032         Add API test coverage.
3033
3034         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3035         (-[DataMappingSchemeHandler setTaskHandler:]):
3036         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3037         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3038         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3039         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3040
3041 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3042
3043         [ews-build] use svn-apply script to apply the patches
3044         https://bugs.webkit.org/show_bug.cgi?id=193138
3045
3046         Reviewed by Lucas Forschler.
3047
3048         * BuildSlaveSupport/ews-build/factories.py:
3049         (Factory.__init__): Add the ApplyPatch step.
3050         * BuildSlaveSupport/ews-build/steps.py:
3051         (CheckOutSource): Added step name.
3052         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3053         (ApplyPatch): Build step to apply patch using svn-apply script.
3054         (UnApplyPatchIfRequired):
3055         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3056
3057 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3058
3059         Deprecate WKContextCreate
3060         https://bugs.webkit.org/show_bug.cgi?id=193118
3061
3062         Reviewed by Brady Eidson.
3063
3064         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3065         (WebKitBrowserWindow::WebKitBrowserWindow):
3066         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3067         (TestWebKitAPI::TEST):
3068         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3069         (TestWebKitAPI::TEST):
3070         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3071         (TestWebKitAPI::TEST):
3072         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3073         (TestWebKitAPI::TEST):
3074         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3075         (TestWebKitAPI::TEST):
3076         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3077         (TestWebKitAPI::TEST):
3078         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3079         (TestWebKitAPI::TEST):
3080         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3081         (TestWebKitAPI::TEST):
3082         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3083         (TestWebKitAPI::TEST):
3084         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3085         (TestWebKitAPI::TEST):
3086         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3087         (TestWebKitAPI::TEST):
3088         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3089         (TestWebKitAPI::TEST):
3090         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3091         (TestWebKitAPI::TEST):
3092         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3093         (TestWebKitAPI::TEST):
3094         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3095         (TestWebKitAPI::TEST):
3096         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3097         (TestWebKitAPI::TEST):
3098         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3099         (TestWebKitAPI::TEST):
3100         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3101         (TestWebKitAPI::TEST):
3102         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3103         (TestWebKitAPI::loadAlternateHTMLString):
3104         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3105         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3106         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3107         (TestWebKitAPI::buildAndPerformTest):
3108         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3109         (TestWebKitAPI::TEST):
3110         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3111         (TestWebKitAPI::TEST):
3112         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3113         (TestWebKitAPI::TEST):
3114         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3115         (TestWebKitAPI::TEST):
3116         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3117         (TestWebKitAPI::TEST):
3118         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3119         (TestWebKitAPI::TEST):
3120         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3121         (TestWebKitAPI::TEST):
3122         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3123         (TestWebKitAPI::TEST):
3124         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3125         (TestWebKitAPI::TEST):
3126         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3127         (TestWebKitAPI::TEST):
3128         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3129         (TestWebKitAPI::TEST):
3130         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3131         (TestWebKitAPI::TEST):
3132         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3133         (TestWebKitAPI::TEST):
3134         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3135         (TestWebKitAPI::TEST):
3136         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3137         (TestWebKitAPI::TEST):
3138         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3139         (TestWebKitAPI::TEST):
3140         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3141         (TestWebKitAPI::TEST):
3142         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3143         (TestWebKitAPI::TEST):
3144         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3145         (TestWebKitAPI::TEST):
3146         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3147         (TestWebKitAPI::TEST):
3148         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3149         (TestWebKitAPI::TEST):
3150         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3151         (TestWebKitAPI::TEST):
3152         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3153         (TestWebKitAPI::TEST):
3154         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3155         (TestWebKitAPI::TEST):
3156         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3157         (TestWebKitAPI::TEST):
3158         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3159         (TestWebKitAPI::TEST):
3160         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3161         (WebKit2_CommandBackForwardTestWKView::SetUp):
3162         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3163         (TestWebKitAPI::TEST):
3164         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3165         (TestWebKitAPI::TEST):
3166         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3167         (TestWebKitAPI::TEST):
3168         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3169         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3170
3171 2019-01-03  Matt Rajca  <mrajca@apple.com>
3172
3173         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3174         https://bugs.webkit.org/show_bug.cgi?id=193128
3175         rdar://34554231
3176
3177         Reviewed by Jer Noble.
3178
3179         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3180         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3181         event along with a flag that indicates whether or not autoplay was actually prevented.
3182
3183         Tests: existing API tests were updated to reflect the new names. New API tests
3184         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3185
3186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3187         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3188         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3189         (TEST):
3190         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3191         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3192
3193 2019-01-04  Chris Dumez  <cdumez@apple.com>
3194
3195         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3196         https://bugs.webkit.org/show_bug.cgi?id=193120
3197
3198         Reviewed by Alex Christensen.
3199
3200         Add API test coverage.
3201
3202         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3203
3204 2019-01-04  Chris Dumez  <cdumez@apple.com>
3205
3206         Crash under WebProcessPool::addSuspendedPage()
3207         https://bugs.webkit.org/show_bug.cgi?id=193110
3208
3209         Reviewed by Youenn Fablet.
3210
3211         Add API test coverage.
3212
3213         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3214
3215 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3216
3217         [ews-build] Check patch relevance before applying the patch
3218         https://bugs.webkit.org/show_bug.cgi?id=193102
3219
3220         Reviewed by Lucas Forschler.
3221
3222         * BuildSlaveSupport/ews-build/factories.py:
3223         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3224
3225 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3226
3227         [ews-build] Check patch relevance step should print patch id
3228         https://bugs.webkit.org/show_bug.cgi?id=193137
3229
3230         Reviewed by Lucas Forschler.
3231
3232         * BuildSlaveSupport/ews-build/steps.py:
3233         (CheckPatchRelevance.start): Update the status to include patch id.
3234
3235 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3236
3237         webkitpy: Increase simulator teardown timeout
3238         https://bugs.webkit.org/show_bug.cgi?id=193141
3239         <rdar://problem/46174217>
3240
3241         Rubber-stamped by Aakash Jain.
3242
3243         * Scripts/webkitpy/xcode/simulated_device.py:
3244         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3245
3246 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3247
3248         test262-runner misbehaves when test file YAML has a trailing space
3249         https://bugs.webkit.org/show_bug.cgi?id=193053
3250
3251         Reviewed by Yusuke Suzuki.
3252
3253         * Scripts/test262/Runner.pm:
3254         (parseData):
3255         Accept trailing space when parsing a test file's YAML block.
3256
3257 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3258
3259         UserMedia test should use WKPageNavigationClient
3260         https://bugs.webkit.org/show_bug.cgi?id=192913
3261
3262         Reviewed by Youenn Fablet.
3263
3264         The test currently uses the deprecated WKPageLoaderClient. It should use
3265         WKPageNavigationClient instead, which provides the same callback under a similar name.
3266
3267         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3268         (TestWebKitAPI::TEST):
3269
3270 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3271
3272         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3273         https://bugs.webkit.org/show_bug.cgi?id=192944
3274
3275         Reviewed by Tim Horton.
3276
3277         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3278         (TestWebKitAPI::TEST):
3279
3280 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3281
3282         Add support for using the current text selection as the find string on iOS
3283         https://bugs.webkit.org/show_bug.cgi?id=193034
3284         <rdar://problem/45138739>
3285
3286         Reviewed by Tim Horton.
3287
3288         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3289         _setStringForFind) works as expected.
3290
3291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3292         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3293
3294 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3295
3296         [ews-build] Use git on OpenSource EWS bots
3297         https://bugs.webkit.org/show_bug.cgi?id=193092
3298
3299         Reviewed by Lucas Forschler.
3300
3301         * BuildSlaveSupport/ews-build/steps.py:
3302         (CheckOutSource): Use git instead of svn.
3303         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3304
3305 2019-01-02  Daniel Bates  <dabates@apple.com>
3306
3307         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3308         https://bugs.webkit.org/show_bug.cgi?id=193023
3309
3310         Reviewed by Simon Fraser.
3311
3312         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3313         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3314         enumerator values. We should just remove this code.
3315
3316         * lldb/lldb_webkit.py:
3317         (WTFOptionSetProvider.has_children):
3318         (WTFOptionSetProvider.num_children):
3319         (WTFOptionSetProvider.get_child_index):
3320         (WTFOptionSetProvider.get_child_at_index):
3321
3322 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3323
3324         .ycm_extra_conf.py should handle XXXInlines.h
3325         https://bugs.webkit.org/show_bug.cgi?id=193055
3326
3327         Reviewed by Carlos Garcia Campos.
3328
3329         compile_commands.json database only records flags and options for cpp source files.
3330         So, when we open headers, this database does not have any information for that.
3331         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3332         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3333         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3334         we attempt to find XXX.cpp and use the configuration if it exists.
3335
3336         * gtk/ycm_extra_conf.py:
3337         (getImplementationFilename):
3338         (FlagsForFile):
3339
3340 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3341
3342         Unreviewed. Support PHP 7.3 in Debian.
3343
3344         Add 7.3 to the list of php versions supported in Debian.
3345
3346         * Scripts/webkitpy/port/base.py:
3347         (Port._debian_php_version):
3348
3349 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3350
3351         Resurrect Mac CMake build
3352         https://bugs.webkit.org/show_bug.cgi?id=192658
3353
3354         Reviewed by Yusuke Suzuki.
3355
3356         * DumpRenderTree/PlatformMac.cmake:
3357         * MiniBrowser/mac/CMakeLists.txt:
3358         * TestWebKitAPI/PlatformMac.cmake:
3359
3360 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3361
3362         [Tools] Remove references to Bison and Flex
3363         https://bugs.webkit.org/show_bug.cgi?id=193033
3364
3365         Reviewed by Michael Catanzaro.
3366
3367         The Bison and Flex tools are not needed anymore since r209883.
3368
3369         * CygwinDownloader/cygwin-downloader.py:
3370         * EWSTools/ubuntu-ews-packages:
3371         * Scripts/filter-build-webkit:
3372         (shouldIgnoreLine):
3373         * gtk/install-dependencies:
3374         * wpe/install-dependencies:
3375
3376 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3377
3378         WebDriver: warn about non existing tests when parsing expectations
3379         https://bugs.webkit.org/show_bug.cgi?id=192979
3380
3381         Reviewed by Michael Catanzaro.
3382
3383         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3384         renamed.
3385
3386         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3387         (WebDriverTestRunner.__init__):
3388
3389 2018-12-21  Chris Dumez  <cdumez@apple.com>
3390
3391         navigator.userAgent in service workers does not reflect customUserAgent set by client
3392         https://bugs.webkit.org/show_bug.cgi?id=192951
3393
3394         Reviewed by Youenn Fablet.
3395
3396         Extend API test coverage.
3397
3398         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3399         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3400         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3401         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3402         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3403
3404 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3405
3406         [WebAuthN] userPresence should always be true
3407         https://bugs.webkit.org/show_bug.cgi?id=192835
3408         <rdar://problem/46538788>
3409
3410         Reviewed by Brent Fulgham.
3411
3412         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3413         (TestWebKitAPI::TEST):
3414
3415 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3416
3417         Add support to run-benchmark to use non-default copies of the browser apps
3418         https://bugs.webkit.org/show_bug.cgi?id=192905
3419         rdar://problem/46845840
3420
3421         Reviewed by Dewei Zhu.
3422         
3423         Add support for a --browser-path argument to run-benchmark, which allows you to use
3424         a custom app bundle for a given browser (only implemented for Safari at present).
3425
3426         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3427         (BenchmarkRunner.__init__):
3428         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3429         (BrowserDriver.__init__):
3430         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3431         (BrowserDriverFactory.create):
3432         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3433         (OSXBrowserDriver._launch_process):
3434         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3435         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3436         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3437         (OSXChromeCanaryDriver.launch_url):
3438         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3439         (OSXFirefoxNightlyDriver.launch_url):
3440         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3441         (OSXSafariDriver.__init__):
3442         (OSXSafariDriver.launch_url):
3443         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3444         (parse_args):
3445         (run_benchmark_plan):
3446         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3447         (WebServerBenchmarkRunner.__init__):
3448         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3449         (FakeBenchmarkRunner.__init__):
3450
3451 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3452
3453         [WebAuthN] Import an APDU coder from Chromium
3454         https://bugs.webkit.org/show_bug.cgi?id=192949
3455         <rdar://problem/46879933>
3456
3457         Reviewed by Brent Fulgham.
3458
3459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3460         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3461         (TestWebKitAPI::TEST):
3462
3463 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3464
3465         Setting the file wrapper and content type of an attachment to a PDF should update its image
3466         https://bugs.webkit.org/show_bug.cgi?id=192984
3467         <rdar://problem/46798028>
3468
3469         Reviewed by Tim Horton.
3470
3471         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
3472         PDF data correctly updates the image element.
3473
3474         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3475
3476 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3477
3478         Add JSCOnly to bot dashboard
3479         https://bugs.webkit.org/show_bug.cgi?id=192964
3480
3481         Reviewed by Alexey Proskuryakov.
3482
3483         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
3484         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
3485         useful if they were not so secret, so add them.
3486
3487         There appear to be no build-only bots, so the first column is blank. And of course there are
3488         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
3489         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
3490         and there's plenty of room in the final column for all the bots.
3491
3492         I had a hard time picking a logo to use, because the JavaScript language does not have an
3493         official logo. But I believe I've found one that will be satisfactory.
3494
3495         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
3496
3497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
3498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
3499         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3500         (BubbleQueueServer):
3501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3503         (WebKitBuildbot):
3504         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3505         (table.queue-grid tr.platform.linux-jsconly img.logo):
3506
3507 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3508
3509         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3510         https://bugs.webkit.org/show_bug.cgi?id=192821
3511
3512         Reviewed by Chris Dumez.
3513
3514         * DumpRenderTree/mac/DumpRenderTree.mm:
3515         (createWebViewAndOffscreenWindow):
3516         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3517
3518 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3519
3520         [Win][Clang] Fix compilation warnings of DumpRenderTree
3521         https://bugs.webkit.org/show_bug.cgi?id=192924
3522
3523         Reviewed by Alex Christensen.
3524
3525         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
3526         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3527         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
3528         * DumpRenderTree/win/DumpRenderTree.cpp:
3529         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
3530         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
3531         object to the argument of setDefaultTextEncodingName instead of a
3532         const string literal.
3533         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
3534         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
3535         (setCacheFolder): Deleted.
3536         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
3537         * DumpRenderTree/win/EditingDelegate.cpp:
3538         (dump): Use %d for int.
3539         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
3540         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3541         (BSTRFromString): Deleted unused function.
3542         * DumpRenderTree/win/TestRunnerWin.cpp:
3543         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
3544         the arguemnt of setQuota instead of const string literal.
3545         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3546         (jsStringRefToWString): Deleted unused function.
3547
3548 2018-12-20  Chris Dumez  <cdumez@apple.com>
3549
3550         Add API test coverage for customUserAgent client setting and service workers
3551         https://bugs.webkit.org/show_bug.cgi?id=192952
3552
3553         Reviewed by Alex Christensen.
3554
3555         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3556         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
3557         (-[SWSchemes webView:startURLSchemeTask:]):
3558         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3559         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3560
3561 2018-12-20  Chris Dumez  <cdumez@apple.com>
3562
3563         Use Optional::hasValue() instead of Optional::has_value()
3564         https://bugs.webkit.org/show_bug.cgi?id=192948
3565
3566         Reviewed by Tim Horton.
3567
3568         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
3569         (TestWebKitAPI::TEST):
3570         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
3571         (TestWebKitAPI::TEST):
3572         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3573         (TestWebKitAPI::TEST_F):
3574
3575 2018-12-20  Chris Dumez  <cdumez@apple.com>
3576
3577         Add style script rule to check for uses of std::optional<>
3578         https://bugs.webkit.org/show_bug.cgi?id=192931
3579
3580         Reviewed by Tim Horton.
3581
3582         * Scripts/webkitpy/style/checkers/cpp.py:
3583         (check_wtf_optional):
3584         (check_style):
3585
3586 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
3587
3588         [WebAuthN] Add a runtime flag for local authenticator
3589         https://bugs.webkit.org/show_bug.cgi?id=192792
3590         <rdar://problem/46798738>
3591
3592         Reviewed by Brent Fulgham.
3593
3594         * DumpRenderTree/TestOptions.cpp:
3595         (TestOptions::TestOptions):
3596         * DumpRenderTree/TestOptions.h:
3597         * DumpRenderTree/mac/DumpRenderTree.mm:
3598         (enableExperimentalFeatures):
3599         (setWebPreferencesForTestOptions):
3600         * WebKitTestRunner/TestController.cpp:
3601         (WTR::TestController::resetPreferencesToConsistentValues):
3602         (WTR::updateTestOptionsFromTestHeader):
3603         * WebKitTestRunner/TestOptions.h:
3604         (WTR::TestOptions::hasSameInitializationOptions const):
3605
3606 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
3607
3608         webkitpy: Autoinstall package URLs have changed
3609         https://bugs.webkit.org/show_bug.cgi?id=192909
3610         <rdar://problem/46860359>
3611
3612         Rubber-stamped by Alexey Proskuryakov.
3613
3614         PyPi urls have been moved around, we need to update our auto-installed packages.
3615
3616         We should check for Selenium before asking PyPi for the latest version.
3617
3618         * Scripts/webkitpy/thirdparty/__init__.py:
3619         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
3620         (AutoinstallImportHook._install_keyring): Ditto.
3621         (AutoinstallImportHook._install_pep8): Ditto.
3622         (AutoinstallImportHook._install_mozlog): Ditto.
3623         (AutoinstallImportHook._install_mozprocess): Ditto.
3624         (AutoinstallImportHook._install_pytest_timeout): Ditto.
3625         (AutoinstallImportHook._install_pytest): Ditto.
3626         (AutoinstallImportHook._install_pylint): Ditto.
3627         (AutoinstallImportHook._install_buildbot): Ditto.
3628         (AutoinstallImportHook._install_coverage): Ditto.
3629         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
3630         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
3631         for new Selenium if the installed version isn't sufficient.
3632         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
3633
3634 2018-12-20  Chris Dumez  <cdumez@apple.com>
3635
3636         Use Optional::valueOr() instead of Optional::value_or()
3637         https://bugs.webkit.org/show_bug.cgi?id=192933
3638
3639         Reviewed by Geoffrey Garen.
3640
3641         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3642         (TestWebKitAPI::checkURL):
3643         (TestWebKitAPI::checkRelativeURL):
3644         (TestWebKitAPI::checkURLDifferences):
3645         (TestWebKitAPI::checkRelativeURLDifferences):
3646         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3647         (TestWebKitAPI::checkURL):
3648
3649 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
3650
3651         Unreviewed, rolling out r239417.
3652
3653         Introduced two API test failures on macOS.
3654
3655         Reverted changeset:
3656
3657         "<rdar://problem/46194315> macOS: WebKit1 does not handle
3658         occlusion changes"
3659         https://bugs.webkit.org/show_bug.cgi?id=192821
3660         https://trac.webkit.org/changeset/239417
3661
3662 2018-12-20  Devin Rousso  <drousso@apple.com>
3663
3664         Web Inspector: UIString should take an optional key and description to aid localization
3665         https://bugs.webkit.org/show_bug.cgi?id=153962
3666         <rdar://problem/24542505>
3667
3668         Reviewed by Brian Burg.
3669
3670         * Scripts/extract-localizable-js-strings:
3671
3672 2018-12-20  Tim Horton  <timothy_horton@apple.com>
3673
3674         Unparented WKWebView can't retrieve main resource data for a main frame plugin
3675         https://bugs.webkit.org/show_bug.cgi?id=192923
3676         <rdar://problem/46859068>
3677
3678         Reviewed by Wenson Hsieh.
3679
3680         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3681         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
3682         Add a test ensuring that both parented and unparented WKWebViews can
3683         retrieve main resource data when loading a PDF.
3684
3685 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3686
3687         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
3688         https://bugs.webkit.org/show_bug.cgi?id=192852
3689
3690         Reviewed by Michael Catanzaro.
3691
3692         EmojiOne font was replaced by Noto Color Emoji.
3693
3694         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
3695         * gtk/jhbuild.modules:
3696         * wpe/jhbuild.modules:
3697
3698 2018-12-19  Chris Dumez  <cdumez@apple.com>
3699
3700         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
3701         https://bugs.webkit.org/show_bug.cgi?id=192728
3702         <rdar://problem/46746779>
3703
3704         Reviewed by Geoff Garen.
3705
3706         * DumpRenderTree/*:
3707         * MiniBrowser/*:
3708         * TestRunnerShared/*:
3709         * TestWebKitAPI/*:
3710         * WebGPUAPIStructure/*:
3711         * WebKitTestRunner/*:
3712
3713 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
3714
3715         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3716         https://bugs.webkit.org/show_bug.cgi?id=192821
3717
3718         Reviewed by Chris Dumez.
3719
3720         * DumpRenderTree/mac/DumpRenderTree.mm:
3721         (createWebViewAndOffscreenWindow):
3722
3723 2018-12-19  Alex Christensen  <achristensen@webkit.org>
3724
3725         Navigations away from the SafeBrowsing interstitial show a flash of old content
3726         https://bugs.webkit.org/show_bug.cgi?id=192676
3727
3728         Reviewed by Chris Dumez.
3729
3730         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3731         (safeBrowsingView):
3732         (TEST):
3733         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3734
3735 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
3736
3737         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
3738         https://bugs.webkit.org/show_bug.cgi?id=192855
3739
3740         Reviewed by Michael Catanzaro.
3741
3742         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3743         (WTR::TestController::notifyDone): Use the WPE implementation.
3744         (WTR::TestController::platformRunUntil): Use the WPE implementation.
3745         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3746         (WTR::TestController::platformRunUntil): Honor the condition flag.
3747
3748 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
3749
3750         Allow clients to set the navigator platform
3751         https://bugs.webkit.org/show_bug.cgi?id=192735
3752
3753         Reviewed by Tim Horton.
3754
3755         Add a test for setting a custom navigator platform.
3756
3757         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3758         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3759         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
3760
3761 2018-12-19  Truitt Savell  <tsavell@apple.com>
3762
3763         Unreviewed, rolling out r239358.
3764
3765         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
3766         crash on Debug bots
3767
3768         Reverted changeset:
3769
3770         "Clean up IndexedDB files between tests"
3771         https://bugs.webkit.org/show_bug.cgi?id=192796
3772         https://trac.webkit.org/changeset/239358
3773
3774 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3775
3776         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
3777         https://bugs.webkit.org/show_bug.cgi?id=192842
3778         <rdar://problem/46823586>
3779
3780         Reviewed by Tim Horton.
3781
3782         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
3783         item provider when dragging a rich text selection.
3784
3785         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3786
3787 2018-12-18  David Quesada  <david_quesada@apple.com>
3788
3789         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
3790         https://bugs.webkit.org/show_bug.cgi?id=192810
3791         <rdar://problem/46812536>
3792
3793         Reviewed by Alex Christensen.
3794
3795         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3796         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3797             After releasing our reference to the web view, wait until the next turn of the runloop
3798             before checking that the originatingWebView has been zeroed, since the web view might
3799             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
3800             testing general memory management of WKWebViews, only that _WKDownload does not retain
3801             its web view via the 'originatingWebView' property.
3802
3803 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3804
3805         Clean up IndexedDB files between tests
3806         https://bugs.webkit.org/show_bug.cgi?id=192796
3807
3808         Reviewed by Geoffrey Garen.
3809
3810         * DumpRenderTree/mac/DumpRenderTree.mm:
3811         (runTest):
3812         * WebKitTestRunner/TestController.cpp:
3813         (WTR::TestController::resetStateToConsistentValues):
3814         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3815         (WTR::RemoveAllIndexedDatabasesCallback):
3816         (WTR::TestController::ClearIndexedDatabases):
3817         * WebKitTestRunner/TestController.h:
3818
3819 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3820
3821         Fix API test introduced in r239339 on iOS.
3822         https://bugs.webkit.org/show_bug.cgi?id=192675
3823
3824         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3825         (TEST):
3826         The iOS implementation of the safe browsing warning is a little different.
3827         It does some element creation when it is added to the window so it knows how big it is.
3828         To test these elements, we need to simulate adding it to the window.
3829         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3830
3831 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3832
3833         webkitpy: Ignore device type for test when using --force
3834         https://bugs.webkit.org/show_bug.cgi?id=192786
3835         <rdar://problem/46794894>
3836
3837         Reviewed by Daniel Bates.
3838
3839         It is sometimes the case that a contributor will wish to run a test on a specific device,
3840         despite expectations which indicate a test should not be run on that device.
3841
3842         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3843         (parse_args):
3844         * Scripts/webkitpy/port/device_port.py:
3845         (DevicePort.default_child_processes): Strip device type information when using --force.
3846         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3847
3848 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3849
3850         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3851         https://bugs.webkit.org/show_bug.cgi?id=192675
3852
3853         Reviewed by Geoffrey Garen.
3854
3855         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3856         (goBack):
3857         (TEST):
3858         (visitUnsafeSite):
3859         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3860         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3861
3862 2018-12-18  Chris Dumez  <cdumez@apple.com>
3863
3864         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3865         https://bugs.webkit.org/show_bug.cgi?id=192772
3866
3867         Reviewed by Antti Koivisto.
3868
3869         Add API test coverage.
3870
3871         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3872
3873 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3874
3875         Unreviewed, JHBuild GTK build fix attempt
3876
3877         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3878         There's no ninja module either, it should be provided by the
3879         host system.
3880
3881 2018-12-17  Chris Dumez  <cdumez@apple.com>
3882
3883         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3884         https://bugs.webkit.org/show_bug.cgi?id=192789
3885         <rdar://problem/46755277>
3886
3887         Reviewed by Alex Christensen.
3888
3889         Add API test coverage.
3890
3891         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3892         (TEST):
3893
3894 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3895
3896         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3897         https://bugs.webkit.org/show_bug.cgi?id=192780
3898         rdar://problem/43394387
3899
3900         Reviewed by Tim Horton.
3901
3902         No need to set "AppleFontSmoothing" defaults for WK2.
3903
3904         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3905         (WTR::InjectedBundle::platformInitialize):
3906
3907 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
3908
3909         webkitpy: Handle case where stdout and stderr don't accept unicode
3910         https://bugs.webkit.org/show_bug.cgi?id=192775
3911         <rdar://problem/46497303>
3912
3913         Reviewed by Stephanie Lewis.
3914
3915         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3916         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
3917         characters with '?'.
3918         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3919         (RegularTest.test_stream_with_encoding):
3920
3921 2018-12-17  Daniel Bates  <dabates@apple.com>
3922
3923         Support concatenating StringView with other string types
3924         https://bugs.webkit.org/show_bug.cgi?id=177566
3925
3926         Reviewed by Darin Adler.
3927
3928         Add some tests to ensure we do not regress the number of allocations needed when performing
3929         string concatenation with string views.
3930
3931         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3932         (TestWebKitAPI::TEST):
3933
3934 2018-12-17  Commit Queue  <commit-queue@webkit.org>
3935
3936         Unreviewed, rolling out r239265 and r239274.
3937         https://bugs.webkit.org/show_bug.cgi?id=192765
3938
3939         unorm_normalize is deprecated, and broke an internal build
3940         (Requested by Truitt on #webkit).
3941
3942         Reverted changesets:
3943
3944         "[GTK][WPE] Need a function to convert internal URI to display
3945         ("pretty") URI"
3946         https://bugs.webkit.org/show_bug.cgi?id=174816
3947         https://trac.webkit.org/changeset/239265
3948
3949         "Fix the Apple Internal Mac build with a newer SDK"
3950         https://trac.webkit.org/changeset/239274
3951
3952 2018-12-17  Daniel Bates  <dabates@apple.com>
3953
3954         Implement UIScriptController::toggleCapsLock() for iOS
3955         https://bugs.webkit.org/show_bug.cgi?id=191815
3956
3957         Reviewed by Andy Estes.
3958
3959         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
3960
3961         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3962         * WebKitTestRunner/TestController.cpp:
3963         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
3964         before running a test. This ensures that the caps lock state does not persist between
3965         tests should a test enable caps lock and not disable it.
3966         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3967         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
3968         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3969         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
3970         create the event. Also substituted NSString* for const String& as the data type for the first
3971         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
3972         below.
3973         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
3974         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
3975
3976 2018-12-17  Daniel Bates  <dabates@apple.com>
3977
3978         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
3979         https://bugs.webkit.org/show_bug.cgi?id=192633
3980
3981         Reviewed by Wenson Hsieh.
3982
3983         Update code to use the modern initializer.
3984
3985         * DumpRenderTree/mac/EventSendingController.mm:
3986         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3987
3988 2018-12-17  Matt Lewis  <jlewis3@apple.com>
3989
3990         Unreviewed, rolling out r239254.
3991
3992         This broke the Windows 10 Debug build
3993
3994         Reverted changeset:
3995
3996         "Replace many uses of String::format with more type-safe
3997         alternatives"
3998         https://bugs.webkit.org/show_bug.cgi?id=192742
3999         https://trac.webkit.org/changeset/239254
4000
4001 2018-12-17  David Kilzer  <ddkilzer@apple.com>
4002
4003         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
4004         <https://webkit.org/b/192751>
4005         <rdar://problem/46771623>
4006
4007         Reviewed by Daniel Bates.
4008
4009         Change loop variables to const references to avoid unnecessary
4010         copies.
4011
4012         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
4013         (-[LocalPasteboard pasteboardItems]):
4014
4015 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
4016
4017         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
4018         https://bugs.webkit.org/show_bug.cgi?id=174816
4019
4020         Reviewed by Michael Catanzaro.
4021
4022         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
4023
4024         * TestWebKitAPI/CMakeLists.txt:
4025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4026         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
4027         (TestWebKitAPI::TEST):
4028         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
4029         (testURIForDisplayUnaffected):
4030         (testURIForDisplayAffected):
4031         (beforeAll):
4032         (afterAll):
4033         * TestWebKitAPI/glib/CMakeLists.txt:
4034
4035 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
4036
4037         [WPE] Add API to notify about frame displayed view backend callback
4038         https://bugs.webkit.org/show_bug.cgi?id=192224
4039
4040         Reviewed by Michael Catanzaro.
4041
4042         Add a test case to check the new API.
4043
4044         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4045         (testWebViewFrameDisplayed):
4046         (beforeAll):
4047         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
4048
4049 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
4050
4051         Unreviewed build fix after r239253
4052
4053         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
4054
4055 2018-12-15  Darin Adler  <darin@apple.com>
4056
4057         Use warning-ignoring macros more consistently and simply
4058         https://bugs.webkit.org/show_bug.cgi?id=192743
4059
4060         Reviewed by Mark Lam.
4061
4062         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4063         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
4064         * DumpRenderTree/mac/TextInputControllerMac.m:
4065         (-[TextInputController interpretKeyEvents:withSender:]): Use
4066         IGNORE_WARNINGS_BEGIN/END.
4067         * WebKitTestRunner/mac/EventSenderProxy.mm:
4068         (WTR::EventSenderProxy::mouseForceClick): Use
4069         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
4070         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
4071         (WTR::EventSenderProxy::mouseForceDown): Ditto.
4072         (WTR::EventSenderProxy::mouseForceUp): Ditto.
4073         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
4074
4075 2018-12-15  Darin Adler  <darin@apple.com>
4076
4077         Replace many uses of String::format with more type-safe alternatives
4078         https://bugs.webkit.org/show_bug.cgi?id=192742
4079
4080         Reviewed by Mark Lam.
4081
4082         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4083         (WTR::cacheTestRunnerCallback): Use makeString.
4084         * WebKitTestRunner/TestController.cpp:
4085         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
4086         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
4087
4088 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
4089
4090         [WPE][GTK] Add libpsl to JHBuild module sets
4091         https://bugs.webkit.org/show_bug.cgi?id=192740
4092
4093         Reviewed by Michael Catanzaro.
4094
4095         * gtk/jhbuild.modules: Add libpsl module.
4096         * wpe/jhbuild.modules: Ditto.
4097
4098 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
4099
4100         Add a style checker rule for Xcode version macros use
4101         https://bugs.webkit.org/show_bug.cgi?id=192703
4102
4103         Reviewed by Alex Christensen.
4104
4105         * Scripts/webkitpy/style/checkers/cpp.py:
4106         (check_os_version_checks):
4107         (process_line):
4108         (CppChecker):
4109         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4110         (WebKitStyleTest.test_os_version_checks):
4111
4112 2018-12-14  Chris Dumez  <cdumez@apple.com>
4113
4114         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
4115         https://bugs.webkit.org/show_bug.cgi?id=192704
4116
4117         Reviewed by Geoffrey Garen.
4118
4119         Extend existing API test to reproduce the problem.
4120
4121         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4122
4123 2018-12-14  Chris Dumez  <cdumez@apple.com>
4124
4125         [PSON] WebsitePolicies are lost on process-swap
4126         https://bugs.webkit.org/show_bug.cgi?id=192694
4127         <rdar://problem/46715748>
4128
4129         Reviewed by Brady Eidson.
4130
4131         Extend existing API test to reproduce the issue.
4132
4133         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4134
4135 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
4136
4137         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
4138         https://bugs.webkit.org/show_bug.cgi?id=192678
4139
4140         Reviewed by Carlos Garcia Campos.
4141
4142         Update our ancient versions of libsoup and glib-networking.
4143
4144         * gtk/install-dependencies:
4145         * gtk/jhbuild.modules:
4146         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
4147         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
4148         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
4149         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4150         * wpe/install-dependencies:
4151         * wpe/jhbuild.modules:
4152         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
4153
4154 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4155
4156         [WPE] Use new view state API from libwpe
4157         https://bugs.webkit.org/show_bug.cgi?id=191906
4158
4159         Reviewed by Žan Doberšek.
4160
4161         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4162         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
4163         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4164         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
4165         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
4166         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4167         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
4168         wpe_view_activity_state_focused state flags.
4169         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
4170         * wpe/backends/HeadlessViewBackend.cpp:
4171         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
4172         * wpe/backends/WindowViewBackend.cpp:
4173         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
4174         received in configure callback.
4175         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
4176
4177 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
4178
4179         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
4180         https://bugs.webkit.org/show_bug.cgi?id=192688
4181
4182         Reviewed by Ross Kirsling.
4183
4184         * win/DLLLauncher/DLLLauncherMain.cpp:
4185         (copyEnvironmentVariable): Moved.
4186         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
4187         (applePathFromRegistry): Ditto.
4188         (appleApplicationSupportDirectory): Ditto.
4189         (prependPath): Ditto.
4190
4191 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
4192
4193         Unreviewed. Changed my status to a reviewer.
4194
4195         * Scripts/webkitpy/common/config/contributors.json:
4196
4197 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4198
4199         [iOS] Support dropping contact card data (public.vcard) in editable content
4200         https://bugs.webkit.org/show_bug.cgi?id=192570
4201         <rdar://problem/35626913>
4202
4203         Reviewed by Tim Horton.
4204
4205         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4206
4207         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
4208         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
4209         additionally inserts a link).
4210
4211         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4212         (TestWebKitAPI::createMapItemForTesting):
4213         (TestWebKitAPI::createContactItemForTesting):
4214
4215         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
4216         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
4217         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
4218         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
4219         files.
4220
4221 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
4222
4223         Unreviewed -- update my status to "reviewer".
4224
4225         * Scripts/webkitpy/common/config/contributors.json:
4226
4227 2018-12-13  Youenn Fablet  <youenn@apple.com>
4228
4229         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
4230         https://bugs.webkit.org/show_bug.cgi?id=192657
4231
4232         Reviewed by Eric Carlson.
4233
4234         Add a test that loads a page registering ondevicechange,
4235         load another page in the same process, closes the first page.
4236         Ensure that the process does not crash in that case.
4237
4238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4239         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4240         (TestWebKitAPI::TEST):
4241         (TestWebKitAPI::didCrashCallback):
4242         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
4243
4244 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4245
4246         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
4247         https://bugs.webkit.org/show_bug.cgi?id=192643
4248
4249         Reviewed by Philippe Normand.
4250
4251         This problem happens with Arch Linux users which have libfdk-2.0.0
4252         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
4253
4254         The problem has already been solved upstream at
4255         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
4256
4257         Adding patches while this problem is not in a release yet.
4258
4259         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
4260         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
4261         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
4262
4263 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4264
4265         [FreeType] Add initial implementation of variation fonts
4266         https://bugs.webkit.org/show_bug.cgi?id=192151
4267
4268         Reviewed by Michael Catanzaro.
4269
4270         Add cairo patch to avoid crashes.
4271
4272         * gtk/jhbuild.modules:
4273         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
4274
4275 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
4276
4277         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
4278         https://bugs.webkit.org/show_bug.cgi?id=192618
4279
4280         Reviewed by Alex Christensen.
4281
4282         * DumpRenderTree/win/DRTDataObject.cpp:
4283         * DumpRenderTree/win/DRTDataObject.h:
4284         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
4285         * DumpRenderTree/win/DRTDropSource.h:
4286         * DumpRenderTree/win/EditingDelegate.h:
4287         * DumpRenderTree/win/PolicyDelegate.h:
4288         * DumpRenderTree/win/UIDelegate.h:
4289
4290 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
4291
4292         Make TextInputController.legacyAttributedString take DOM nodes and offsets
4293         https://bugs.webkit.org/show_bug.cgi?id=192653
4294
4295         Reviewed by Wenson Hsieh.
4296
4297         Updated TextInputController.legacyAttributedString to take DOM nodes and offs