Plug some leaks in TestController and UIScriptContext.
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-04  Andreas Kling  <akling@apple.com>
2
3         Plug some leaks in TestController and UIScriptContext.
4         <https://webkit.org/b/167839>
5
6         Reviewed by Alexey Proskuryakov.
7
8         Fix a couple of the leaks seen on the leaks bot.
9
10         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
11         (UIScriptContext::runUIScript):
12         * WebKitTestRunner/TestController.cpp:
13         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
14         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
15
16 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
17
18         WK1 mouse events are missing movementX and movementY for pointerlock.
19         https://bugs.webkit.org/show_bug.cgi?id=167775
20         rdar://problem/30343810
21
22         Reviewed by Alexey Proskuryakov.
23
24         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
25
26         * DumpRenderTree/mac/EventSendingController.mm:
27         (-[EventSendingController mouseMoveToX:Y:]):
28         * WebKitTestRunner/mac/EventSenderProxy.mm:
29         (WTR::EventSenderProxy::mouseMoveTo):
30
31 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
32
33         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
34         https://bugs.webkit.org/show_bug.cgi?id=167774
35
36         Reviewed by Tim Horton.
37
38         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
39         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
40         web process are async, so the callback fires after the web process gets the new state.
41
42         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
43         (WTR::UIScriptController::removeViewFromWindow):
44         (WTR::UIScriptController::addViewToWindow):
45         * DumpRenderTree/mac/DumpRenderTree.mm:
46         (createWebViewAndOffscreenWindow):
47         (resetWebViewToConsistentStateBeforeTesting):
48         * DumpRenderTree/mac/DumpRenderTreeMac.h:
49         * DumpRenderTree/mac/UIScriptControllerMac.mm:
50         (WTR::UIScriptController::removeViewFromWindow):
51         (WTR::UIScriptController::addViewToWindow):
52         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
53         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
54         (WTR::UIScriptController::removeViewFromWindow):
55         (WTR::UIScriptController::addViewToWindow):
56         * TestRunnerShared/UIScriptContext/UIScriptController.h:
57         * WebKitTestRunner/PlatformWebView.h:
58         * WebKitTestRunner/TestController.cpp:
59         (WTR::TestController::resetStateToConsistentValues):
60         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
61         (WTR::PlatformWebView::removeFromWindow):
62         (WTR::PlatformWebView::addToWindow):
63         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
64         (WTR::UIScriptController::removeViewFromWindow):
65         (WTR::UIScriptController::addViewToWindow):
66         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
67         (WTR::PlatformWebView::removeFromWindow):
68         (WTR::PlatformWebView::addToWindow):
69         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
70         (WTR::UIScriptController::removeViewFromWindow):
71         (WTR::UIScriptController::addViewToWindow):
72
73 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
74
75         Remove check for SkipSafariExecutableEntitlementChecks
76         https://bugs.webkit.org/show_bug.cgi?id=167762
77
78         Reviewed by Dan Bernstein.
79
80         Follow-up fix: don't break internal behavior.
81
82         * Scripts/webkitdirs.pm:
83         (safariPath):
84         (executableHasEntitlements): Deleted.
85         (safariPathFromSafariBundle): Deleted.
86         (installedSafariPath): Deleted.
87
88 2017-02-03  Daniel Bates  <dabates@apple.com>
89
90         [Mac][WK2] Add SPI to override the Content Security Policy of a page
91         https://bugs.webkit.org/show_bug.cgi?id=167810
92         <rdar://problem/30102568>
93
94         Reviewed by Anders Carlsson.
95
96         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
97
98         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
99         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
100         (TEST):
101         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
102         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
103         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
104         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
105
106 2017-02-02  Alex Christensen  <achristensen@webkit.org>
107
108         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
109         https://bugs.webkit.org/show_bug.cgi?id=167773
110         <rdar://problem/30221102>
111
112         Reviewed by Ryosuke Niwa.
113
114         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
115         (TestWebKitAPI::TEST_F):
116
117 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
118
119         Remove check for SkipSafariExecutableEntitlementChecks
120         https://bugs.webkit.org/show_bug.cgi?id=167762
121         rdar://problem/22480673
122
123         Reviewed by Dan Bernstein.
124
125         * Scripts/webkitdirs.pm:
126         (safariPathFromSafariBundle):
127         (skipSafariExecutableEntitlementChecks): Deleted.
128
129 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
130
131         Undefined subroutine in svn-create-patch
132         https://bugs.webkit.org/show_bug.cgi?id=167742
133
134         Unreviewed build-fix after r211543.
135
136         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
137
138 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
139
140         Unreviewed. Fix jhbuild dependencies build.
141
142         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
143         Patch updated.
144
145 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
146
147         [EME][GStreamer] Fixed decryptor selection
148         https://bugs.webkit.org/show_bug.cgi?id=167588
149
150         Reviewed by Žan Doberšek.
151
152         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
153
154         * gtk/jhbuild.modules: Added patches to gstreamer and
155         gst-plugins-good packages.
156         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
157         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
158
159 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
160
161         Make run-benchmark script supports 'config' key in test plan.
162         https://bugs.webkit.org/show_bug.cgi?id=167715
163
164         Reviewed by Ryosuke Niwa.
165
166         Add support for 'config' key in test paln.
167         'config' key is a dictionary that specifies environment configurations while test is running.
168         Specifies orientation to be portrait in MotionMark benchmark.
169
170         * Scripts/webkitpy/benchmark_runner/README.md:
171         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
172         (BenchmarkRunner.__init__):
173         (BenchmarkRunner._run_benchmark):
174         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
175         (BrowserDriver.prepare_env):
176         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
177         (LinuxBrowserDriver.prepare_env):
178         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
179         (OSXBrowserDriver.prepare_env):
180         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
181         (OSXSafariDriver.prepare_env):
182         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
183
184 2017-02-01  Daniel Bates  <dabates@apple.com>
185
186         REGRESSION (r210820): svn-create-patch does not emit property change only diff
187         https://bugs.webkit.org/show_bug.cgi?id=167169
188
189         Reviewed by David Kilzer.
190
191         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
192         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
193         header from the output of "svn diff" on a file that was copied or moved.
194
195         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
196         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
197         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
198         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
199         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
200         of a file with only a property change also does not contain any chunk range lines. Therefore
201         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
202         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
203         we should directly test for the presence of a leading SVN diff header with an empty body and
204         remove such lines from the diff.
205
206         * Scripts/VCSUtils.pm:
207         (fixSVNPatchForAdditionWithHistory): Added.
208         * Scripts/svn-create-patch:
209         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
210         we have a non empty patch for an added file with history (i.e. a copied or moved file).
211         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
212
213 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
214
215         [Mac] Update CARingBuffer class
216         https://bugs.webkit.org/show_bug.cgi?id=167656
217
218         Reviewed by Jer Noble.
219
220         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
221         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
222         (TestWebKitAPI::CARingBufferTest::SetUp):
223         (TestWebKitAPI::CARingBufferTest::setup):
224         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
225         (TestWebKitAPI::CARingBufferTest::description):
226         (TestWebKitAPI::CARingBufferTest::bufferList):
227         (TestWebKitAPI::CARingBufferTest::ringBuffer):
228         (TestWebKitAPI::CARingBufferTest::capacity):
229         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
230         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
231         (TestWebKitAPI::TEST_F):
232         (TestWebKitAPI::MixingTest::run):
233
234 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
235
236         [Mac] TestWebKitAPI includes system frameworks incorrectly
237         https://bugs.webkit.org/show_bug.cgi?id=167703
238         rdar://problem/30301498
239
240         Reviewed by Ryosuke Niwa.
241
242         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
243         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
244
245         Also, reduced the number of subframework search paths, looks like we only need one now.
246
247         * TestWebKitAPI/Configurations/Base.xcconfig:
248
249 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
250
251         Correct "filesHaveSameVolume" predicate
252         https://bugs.webkit.org/show_bug.cgi?id=167696
253         <rdar://problem/30298722>
254
255         Reviewed by David Kilzer.
256
257         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
258         percent-escaped path inputs.
259
260         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
261         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
262         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
263         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
264         (TestWebKitAPI::TEST_F):
265
266 2017-02-01  Tomas Popela  <tpopela@redhat.com>
267
268         Unreviewed. Fix coding style in MiniBrowser
269
270         * MiniBrowser/gtk/BrowserWindow.c:
271         (editingCommandCallback):
272         (insertImageCommandCallback):
273         (insertLinkCommandCallback):
274
275 2017-02-01  Tomas Popela  <tpopela@redhat.com>
276
277         [GTK] Add an API to add a custom tab into the print dialog
278         https://bugs.webkit.org/show_bug.cgi?id=151998
279
280         Reviewed by Carlos Garcia Campos.
281
282         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
283         that is testing a newly added API.
284
285         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
286         (testPrintCustomWidget):
287         (beforeAll):
288
289 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
290
291         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
292         https://bugs.webkit.org/show_bug.cgi?id=166529
293
294         Reviewed by Xabier Rodriguez-Calvar.
295
296         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
297         New patch version accepted in GStreamer upstream.
298
299 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
300
301         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
302         https://bugs.webkit.org/show_bug.cgi?id=167498
303
304         Reviewed by Carlos Garcia Campos.
305
306         Depending on the distro version you can need either libxfont1-dev
307         or libfont-dev to build with jhbuild.
308
309         * gtk/install-dependencies:
310
311 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
312
313         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
314         https://bugs.webkit.org/show_bug.cgi?id=167594
315
316         Unreviewed test gardening.
317
318         Disabling this test while we investigate the cause of a timeout on ios-simulator.
319
320         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
321         (TEST):
322
323 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
324
325         Move slow-running microbenchmarks out of JSTests/microbenchmarks
326         https://bugs.webkit.org/show_bug.cgi?id=167676
327
328         Reviewed by Saam Barati.
329
330         * Scripts/run-javascriptcore-tests:
331         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
332
333 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
334
335         Make Dump Render Tree not crash
336         https://bugs.webkit.org/show_bug.cgi?id=167667
337
338         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
339         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
340         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
341         This does not fix any tests, it just fixes the crash.
342         
343         Reviewed by Simon Fraser.
344
345         * DumpRenderTree/TestRunner.cpp:
346         (TestRunner::callUIScriptCallback):
347
348 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
349
350         Workaround for simctl install failing to report install failure
351         https://bugs.webkit.org/show_bug.cgi?id=167654
352
353         Reviewed by Daniel Bates.
354
355         simctl install will sometimes report success even though install has failed.
356         To workaround this bug, we attempt an app launch after install to ensure
357         install has succeeded.
358
359         * Scripts/webkitpy/xcode/simulator.py:
360         (Device.install_app): Attempt app launch after install, retry install if launch fails.
361         (Device.launch_app): Correct comment.
362
363 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
364
365         Unreviewed webkitpy fix after r211405.
366
367         * Scripts/webkitpy/xcode/simulator.py:
368         (Device.launch_app): Remove @staticmethod on _log_debug_error.
369
370 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
371
372         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
373
374         * gtk/manifest.txt.in:
375
376 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
377
378         AX: enable search predication for iOS
379         https://bugs.webkit.org/show_bug.cgi?id=167558
380         <rdar://problem/30251367>
381
382         Reviewed by Joanmarie Diggs.
383
384         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
385         (AccessibilityUIElement::uiElementForSearchPredicate):
386         * DumpRenderTree/mac/AccessibilityCommonMac.h:
387         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
388         (searchPredicateParameterizedAttributeForSearchCriteria):
389         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
390         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
391         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
392         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
393         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
394         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
395         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
396         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
397         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
398         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
399         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
400
401 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
402
403         Workaround for simctl launch bug
404         https://bugs.webkit.org/show_bug.cgi?id=167613
405
406         Reviewed by Daniel Bates.
407
408         simctl launch will sometimes fail because of a race condition when many
409         simulators are being run simultaneously. These failures will always have
410         an exit code of 1. This change attempts to launch an app multiple times
411         before reporting a failure to workaround this bug.
412
413         * Scripts/webkitpy/xcode/simulator.py:
414         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
415
416 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
417
418         Commit queue fails to look at real name aliases for the reviewer
419         https://bugs.webkit.org/show_bug.cgi?id=167422
420
421         Reviewed by Joseph Pecoraro.
422
423         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
424         (test_has_valid_reviewer): Added tests.
425
426         * Scripts/webkitpy/common/config/committers.py:
427         (CommitterList._name_to_contributor_map):
428         Made _name_to_contributor_map include alias names.
429
430         * Scripts/webkitpy/common/config/committers_unittest.py:
431         (CommittersTest.test_contributors_by_fuzzy_match):
432         Removed subtests that are now obsolete, as these matches are strict. It is not
433         obvious if distance based fuzzy matching for names is useful at all, but we can
434         look into that some other time.
435
436 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
437
438         QueueStatusServer should have an explicit timeout for _fetch_url
439         https://bugs.webkit.org/show_bug.cgi?id=167467
440
441         Reviewed by Alexey Proskuryakov.
442
443         * Scripts/webkitpy/common/net/statusserver.py:
444         (StatusServer._fetch_url): Add an explicit timeout of 300s.
445
446 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
447
448         Add support for Trac instances that host multiple projects.
449         https://bugs.webkit.org/show_bug.cgi?id=167524
450
451         Reviewed by Alexey Proskuryakov.
452
453         When multiple projects are hosted on a single Trac instance, the current
454         behavior will retrieve changesets from all tracked projects.
455         This patch teaches Trac.js to get project-specific changesets from Trac.
456         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
457         when querying the Trac timeline.
458
459         To tell Trac to be aware of multi-project instances we leverage the 
460         `options` parameter when creating a new instance: 
461
462             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
463
464         If this option is not provided, the original behaviour will prevail.
465         Additionally, add corresponding tests.
466
467         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
468         (Trac): Reason about new optional parameter 'projectIdentifier'.
469         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
470         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
471         replace default parameter `changeset=on` with `repo-projectname=on`.
472         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
474         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
476         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
477         Add the following tests:
478             test("revisionURL")
479             test("revisionURL with Trac Identifier")
480             test("_xmlTimelineURL")
481             test("_xmlTimelineURL with Trac Identifier")
482         (this.view._latestProductiveIteration): Fix missing ';'.
483
484 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
485
486         Correct spacing regression on inter-element complex path shaping on some fonts
487         https://bugs.webkit.org/show_bug.cgi?id=166013
488
489         Reviewed by Simon Fraser.
490
491         Unskip existing tests and make some new tests:
492         - Testing complex text with no origins
493         - Testing initial expansions
494         - Testing the sign of vertical advances
495
496         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
497         (TestWebKitAPI::TEST_F):
498
499 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
500
501         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
502         https://bugs.webkit.org/show_bug.cgi?id=167596
503
504         Reviewed by Daniel Bates.
505
506         We avoid needing a thin directory by invoking the zip program with
507         the list of directories from the build directory to be zipped,
508         and by using the zip feature to exclude files matching a pattern.
509
510         * BuildSlaveSupport/built-product-archive:
511         (copyBuildFiles):
512         (createZipFromList):
513         (archiveBuiltProduct):
514
515 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
516
517         Use simctl instead of LayoutTestRelay
518         https://bugs.webkit.org/show_bug.cgi?id=165927
519
520         Reviewed by Daniel Bates.
521
522         Part 1
523
524         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
525         simulators through simctl (iOS 10 and later), use this functionality instead.
526
527         * Scripts/webkitpy/port/base.py:
528         (Port.__init__): Added _test_runner_process_constructor.
529         * Scripts/webkitpy/port/darwin.py:
530         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
531         * Scripts/webkitpy/port/driver.py:
532         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
533         (IOSSimulatorDriver): Deleted.
534         * Scripts/webkitpy/port/driver_unittest.py:
535         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
536         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
537         (DriverTest.test_start_actually_starts): Ditto.
538         * Scripts/webkitpy/port/ios.py:
539         (IOSSimulatorPort): Remove relay_name.
540         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
541         (IOSSimulatorPort._create_simulators): Formatting change.
542         (IOSSimulatorPort.relay_path): Deleted.
543         (IOSSimulatorPort._check_relay): Deleted.
544         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
545         (IOSSimulatorPort._build_relay): Deleted.
546         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
547         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
548         * Scripts/webkitpy/port/ios_unittest.py:
549         (iosTest.test_32bit): Update test.
550         (iosTest.test_64bit): Update test.
551         * Scripts/webkitpy/port/server_process.py:
552         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
553         (ServerProcess._set_file_nonblocking): Added to share common code.
554         * Scripts/webkitpy/port/server_process_mock.py:
555         (MockServerProcess.__init__): Added argument worker_number.
556         * Scripts/webkitpy/port/simulator_process.py: Added.
557         (SimulatorProcess): Added.
558         (SimulatorProcess.Popen): Added.
559         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
560         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
561         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
562         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
563         (SimulatorProcess._reset): Added. Unlink fifos.
564         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
565         (SimulatorProcess._kill): Added. Shutdown app on simulator.
566         * Scripts/webkitpy/xcode/simulator.py:
567         (Device.__init__): Accept host to run install/launch/terminate.
568         (Device.install_app): Install app to target Device.
569         (Device.launch_app): Launch app on target Device.
570         (Device.terminate_app): Shutdown app on target Device.
571         (Simulator._parse_devices): Pass host to Device.
572
573 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
574
575         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
576         https://bugs.webkit.org/show_bug.cgi?id=167411
577
578         Reviewed by Michael Catanzaro.
579
580         Disable the ARM iwMMXt fast path for pixman, because it triggers
581         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
582
583         * gtk/jhbuild.modules:
584
585 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
586
587         [GTK] Add API to handle the accelerated compositing policy
588         https://bugs.webkit.org/show_bug.cgi?id=167509
589
590         Reviewed by Michael Catanzaro.
591
592         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
593         as a special case. Also add test cases to the get/set API.
594
595         * MiniBrowser/gtk/BrowserSettingsDialog.c:
596         (hardwareAccelerationPolicyToString):
597         (stringToHardwareAccelerationPolicy):
598         (cellRendererChanged):
599         (browserSettingsDialogConstructed):
600         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
601         (testWebKitSettings):
602
603 2017-01-29  Andy Estes  <aestes@apple.com>
604
605         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
606         https://bugs.webkit.org/show_bug.cgi?id=167563
607         <rdar://problem/30253207>
608
609         Reviewed by Andreas Kling.
610
611         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
612         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
613         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
614         (runTest):
615         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
616         (TEST):
617
618 2017-01-29  Dan Bernstein  <mitz@apple.com>
619
620         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
621         https://bugs.webkit.org/show_bug.cgi?id=167565
622
623         Reviewed by Sam Weinig.
624
625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
626         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
627         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
628         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
629         (TEST):
630         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
631         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
632         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
633         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
634
635 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
636
637         Add Link Preload as an off-by-default experimental feature menu item.
638         https://bugs.webkit.org/show_bug.cgi?id=167201
639
640         Reviewed by Ryosuke Niwa.
641
642         * DumpRenderTree/mac/DumpRenderTree.mm:
643         (resetWebPreferencesToConsistentValues):
644         * DumpRenderTree/win/DumpRenderTree.cpp:
645         (resetWebPreferencesToConsistentValues):
646
647 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
648
649         Add User Timing Experimental Feature
650         https://bugs.webkit.org/show_bug.cgi?id=167542
651         <rdar://problem/22746307>
652
653         Reviewed by Ryosuke Niwa.
654
655         * DumpRenderTree/mac/DumpRenderTree.mm:
656         (enableExperimentalFeatures):
657         (resetWebPreferencesToConsistentValues):
658         * DumpRenderTree/win/DumpRenderTree.cpp:
659         (enableExperimentalFeatures):
660
661 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
662
663         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
664         https://bugs.webkit.org/show_bug.cgi?id=167519
665
666         Reviewed by Ryosuke Niwa.
667
668         * QueueStatusServer/templates/statusbubble.html:
669         To measure the bubbleContainer's width, it must not be wrapping based
670         on its parent container. So when measuring the width temporarily set
671         the parent to a very large width so as to not artificially wrap us.
672         Restore the parent's width after measuring.
673
674 2017-01-27  Andy Estes  <aestes@apple.com>
675
676         [iOS] Add a test for _WKNSFileManagerExtras
677         https://bugs.webkit.org/show_bug.cgi?id=167478
678
679         Reviewed by Andreas Kling.
680
681         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
682         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
683         (expectAttributes):
684         (TEST):
685
686 2017-01-27  Keith Miller  <keith_miller@apple.com>
687
688         run-benchmarks should make sure it passes the test url to the right application
689         https://bugs.webkit.org/show_bug.cgi?id=167533
690
691         Reviewed by Joseph Pecoraro.
692
693         This fixes an issue when trying to run-benchmark script with the
694         system default browser set to STP. Previously, it would run
695         the test in STP rather than the provided build. Now, it should run
696         in the provided build.
697
698         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
699         (OSXSafariDriver.launch_url):
700
701 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
702
703         [Cocoa] Prepare ComplexTextController for unit testing
704         https://bugs.webkit.org/show_bug.cgi?id=167493
705
706         Reviewed by Simon Fraser.
707
708         Addressing post-review comments from Simon Fraser.
709
710         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
711         (TestWebKitAPI::TEST_F):
712
713 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
714
715         [Cocoa] Prepare ComplexTextController for unit testing
716         https://bugs.webkit.org/show_bug.cgi?id=167493
717
718         Reviewed by Dean Jackson.
719
720         Create four unit tests.
721
722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
723         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
724         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
725         (TestWebKitAPI::TEST_F):
726
727 2017-01-26  Chris Dumez  <cdumez@apple.com>
728
729         Crash when navigating back to a page in PacheCache when one of its frames has been removed
730         https://bugs.webkit.org/show_bug.cgi?id=167421
731         <rdar://problem/30188490>
732
733         Reviewed by Darin Adler.
734
735         Add a new setting allowing layout tests to enable PageCache in a window
736         that has an opener, for convenience.
737
738         * DumpRenderTree/mac/DumpRenderTree.mm:
739         (resetWebPreferencesToConsistentValues):
740         * DumpRenderTree/win/DumpRenderTree.cpp:
741         (resetWebPreferencesToConsistentValues):
742         * WebKitTestRunner/TestController.cpp:
743         (WTR::TestController::resetPreferencesToConsistentValues):
744
745 2017-01-26  Keith Miller  <keith_miller@apple.com>
746
747         classInfo should take a VM so it is not materialized from the object on each call
748         https://bugs.webkit.org/show_bug.cgi?id=167424
749
750         Rubber Stamped by Michael Saboff.
751
752         Previously, classInfo() would get the VM from the target's
753         MarkedBlock.  Most callers already have a VM on hand, so it is
754         wasteful to compute the VM from the marked block every time. This
755         patch refactors some of the most common callers of classInfo(),
756         jsDynamicCast and inherits to take a VM as well.
757
758         * DumpRenderTree/TestRunner.cpp:
759         (setAudioResultCallback):
760
761 2017-01-26  Jer Noble  <jer.noble@apple.com>
762
763         Autoplay muted videos stop playback of any streaming app in the background
764         https://bugs.webkit.org/show_bug.cgi?id=163993
765         <rdar://problem/29020431>
766
767         Reviewed by Eric Carlson.
768
769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
770         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
771         (TestWebKitAPI::TEST):
772         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
773
774 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
775
776         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
777         https://bugs.webkit.org/show_bug.cgi?id=167466
778
779         Unreviewed test gardening.
780
781         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
782         (TEST):
783
784 2017-01-26  Matt Rajca  <mrajca@apple.com>
785
786         Notify clients when the user plays media otherwise prevented from autoplaying
787         https://bugs.webkit.org/show_bug.cgi?id=167390
788
789         Reviewed by Alex Christensen.
790
791         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
792         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
793         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
794         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
795         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
796         (TEST):
797         * TestWebKitAPI/cocoa/TestWKWebView.h:
798         * TestWebKitAPI/cocoa/TestWKWebView.mm:
799         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
800         (-[TestWKWebView waitForLoad]):
801         (-[TestWKWebView mouseUpAtPoint:]):
802         * WebKitTestRunner/TestController.cpp:
803         (WTR::TestController::createOtherPage):
804         (WTR::TestController::createWebViewWithOptions):
805
806 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
807
808         Crash when setting custom scale factor.
809         https://bugs.webkit.org/show_bug.cgi?id=167369
810
811         Reviewed by Sam Weinig.
812
813         Added API test.
814
815         * TestWebKitAPI/PlatformWin.cmake:
816         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
817         (TestWebKitAPI::WebKitCreateInstance):
818         (TestWebKitAPI::ScaleWebView::SetUp):
819         (TestWebKitAPI::ScaleWebView::TearDown):
820         (TestWebKitAPI::TEST_F):
821
822 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
823
824         run-benchmark nests MotionMark results by the suite name twice
825         https://bugs.webkit.org/show_bug.cgi?id=164948
826
827         Reviewed by Said Abou-Hallawa.
828
829         Use a single level MotionMark now that this is the name of the benchmark,
830         and we no longer have tests that aren't part of the MotionMark suite.
831
832         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
833
834 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
835
836         Unreviewed, rolling out r211193.
837
838         This change broke internal builds.
839
840         Reverted changeset:
841
842         "Notify clients when the user plays media otherwise prevented
843         from autoplaying"
844         https://bugs.webkit.org/show_bug.cgi?id=167390
845         http://trac.webkit.org/changeset/211193
846
847 2017-01-25  Matt Rajca  <mrajca@apple.com>
848
849         Notify clients when the user plays media otherwise prevented from autoplaying
850         https://bugs.webkit.org/show_bug.cgi?id=167390
851
852         Reviewed by Alex Christensen.
853
854         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
855         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
856         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
857         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
858         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
859         (TEST):
860         * TestWebKitAPI/cocoa/TestWKWebView.h:
861         * TestWebKitAPI/cocoa/TestWKWebView.mm:
862         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
863         (-[TestWKWebView waitForLoad]):
864         (-[TestWKWebView mouseUpAtPoint:]):
865         * WebKitTestRunner/TestController.cpp:
866         (WTR::TestController::createOtherPage):
867         (WTR::TestController::createWebViewWithOptions):
868
869 2017-01-25  Matt Rajca  <mrajca@apple.com>
870
871         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
872         https://bugs.webkit.org/show_bug.cgi?id=167385
873
874         Reviewed by Alex Christensen.
875
876         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
877         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
878         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
879         (TEST): Allow inline (rather than full screen) media playback on iOS.
880
881 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
882
883         [GTK] Icon Database should be in private browsing mode for ephemeral web views
884         https://bugs.webkit.org/show_bug.cgi?id=167414
885
886         Reviewed by Michael Catanzaro.
887
888         Add a test case to check ephemeral web views don't write favicons to the database.
889
890         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
891         (ephemeralViewLoadChanged):
892         (testPrivateBrowsing):
893         (testFaviconDatabase):
894
895 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
896
897         [GTK] Add a private browsing mode to MiniBrowser
898         https://bugs.webkit.org/show_bug.cgi?id=167413
899
900         Reviewed by Michael Catanzaro.
901
902         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
903         private windows, even on non-private instances.
904
905         * MiniBrowser/gtk/BrowserWindow.c:
906         (webViewTitleChanged): Add [Private] to title window for private windows.
907         (webViewCreate): Pass web context to browser_window_new.
908         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
909         (browserWindowFinalize): Disconnect web context signal handlers.
910         (browser_window_init): Add shortcut for opening private window.
911         (browser_window_new): It now receives the context and connect to download-started here.
912         (browser_window_get_web_context): Return the context.
913         * MiniBrowser/gtk/BrowserWindow.h:
914         * MiniBrowser/gtk/main.c:
915         (createBrowserTab): Create the web view for the window web context.
916         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
917         (aboutDataHandleRequest): Ditto.
918         (aboutURISchemeRequestCallback): Ditto.
919         (main): Create ephemeral web context if private command line option is used.
920
921 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
922
923         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
924         https://bugs.webkit.org/show_bug.cgi?id=167409
925
926         Reviewed by Antti Koivisto.
927
928         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
929         as well as tests for the newly added matchingElementInFlatTree.
930
931         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
932         (TestWebKitAPI::runJavaScriptAlert):
933         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
934         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
935         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
936
937 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
938
939         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
940         https://bugs.webkit.org/show_bug.cgi?id=167370
941
942         Reviewed by Michael Catanzaro.
943
944         Add several test cases of ephemeral web views.
945
946         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
947         (testWebViewAuthenticationStorage):
948         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
949         (ephemeralViewloadChanged):
950         (testCookieManagerEphemeral):
951         (beforeAll):
952         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
953         (testWebKitSettings):
954         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
955         (testWebContextEphemeral):
956         (ephemeralViewloadChanged):
957         (testWebContextProxySettings):
958         (beforeAll):
959         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
960         (ephemeralViewloadChanged):
961         (testWebViewEphemeral):
962         (beforeAll):
963         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
964         (ephemeralViewloadChanged):
965         (testWebsiteDataEphemeral):
966         (beforeAll):
967
968 2017-01-24  Alex Christensen  <achristensen@webkit.org>
969
970         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
971         https://bugs.webkit.org/show_bug.cgi?id=167402
972
973         Reviewed by Ryosuke Niwa.
974
975         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
976         (TestWebKitAPI::TEST):
977
978 2017-01-24  Zalan Bujtas  <zalan@apple.com>
979
980         Add simple line layout toggle to MiniBrowser
981         https://bugs.webkit.org/show_bug.cgi?id=167405
982
983         Reviewed by Andreas Kling.
984
985         * MiniBrowser/mac/SettingsController.h:
986         * MiniBrowser/mac/SettingsController.m:
987         (-[SettingsController _populateMenu]):
988         (-[SettingsController validateMenuItem:]):
989         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
990         (-[SettingsController simpleLineLayoutEnabled]):
991         * MiniBrowser/mac/WK1BrowserWindowController.m:
992         (-[WK1BrowserWindowController didChangeSettings]):
993         * MiniBrowser/mac/WK2BrowserWindowController.m:
994         (-[WK2BrowserWindowController didChangeSettings]):
995
996 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
997
998         WKR does not include my nick when commit-queue lands my patch
999         https://bugs.webkit.org/show_bug.cgi?id=167388
1000
1001         Reviewed by Ryosuke Niwa.
1002
1003         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1004         (NewCommitBot._summarize_commit_log):
1005         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1006         Perform nickname insertion before grabbing "Patch by" details.
1007         This way we can include the nickname with the full name.
1008
1009 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1010
1011         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1012         https://bugs.webkit.org/show_bug.cgi?id=167394
1013
1014         Reviewed by Ryosuke Niwa.
1015
1016         * Scripts/webkitperl/FeatureList.pm:
1017         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1018
1019 2017-01-24  Youenn Fablet  <youenn@apple.com>
1020
1021         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1022         https://bugs.webkit.org/show_bug.cgi?id=167353
1023
1024         Reviewed by Alex Christensen.
1025
1026         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1027         (CMakeGenerator.initialize_targets):
1028
1029 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1030
1031         WKR should not confuse Miguel Gomez with Andres Gomez
1032         https://bugs.webkit.org/show_bug.cgi?id=167389
1033
1034         Reviewed by Lucas Forschler.
1035
1036         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1037         "mAndres Gomez". Fix this.
1038
1039         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1040         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1041         space on each side of the email address, so expect both spaces to be there before
1042         considering the email for replacement.
1043         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1044
1045 2017-01-24  Matt Rajca  <mrajca@apple.com>
1046
1047         Pass down website autoplay policies to media elements
1048         https://bugs.webkit.org/show_bug.cgi?id=167355
1049
1050         Reviewed by Alex Christensen.
1051
1052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1053         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1054         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1055         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1056         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1057         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1058         (TEST):
1059
1060 2017-01-24  Nan Wang  <n_wang@apple.com>
1061
1062         AX: Speak Selection does not work in an iframe
1063         https://bugs.webkit.org/show_bug.cgi?id=166794
1064         <rdar://problem/29913013>
1065
1066         Reviewed by Chris Fleizach.
1067
1068         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1069         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1070         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1071         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1072         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1073         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1074         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1075         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1076         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1077         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1078         (-[TestRunnerWKWebView dealloc]):
1079         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1080         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1081         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1082         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1083         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1084
1085 2017-01-24  Daniel Bates  <dabates@apple.com>
1086
1087         StringView.split() should use an iterator design pattern instead of allocating a Vector
1088         https://bugs.webkit.org/show_bug.cgi?id=163225
1089
1090         Reviewed by Darin Adler.
1091
1092         Add unit tests for StringView.split().
1093
1094         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1095         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1096         used in the StringView.split() unit tests.
1097         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1098         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1099         object to a Vector of String objects.
1100         (TestWebKitAPI::TEST): Added the following tests:
1101             - WTF.StringViewSplitEmptyAndNullStrings
1102             - WTF.StringViewSplitBasic
1103             - WTF.StringViewSplitWithConsecutiveSeparators
1104
1105 2017-01-23  Anders Carlsson  <andersca@apple.com>
1106
1107         The Score Esports crashes on launch
1108         https://bugs.webkit.org/show_bug.cgi?id=167338
1109         rdar://problem/29948645
1110
1111         Reviewed by Dan Bernstein.
1112
1113         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1114         (TestWebKitAPI::TEST):
1115         Add a test.
1116
1117 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1118
1119         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1120         https://bugs.webkit.org/show_bug.cgi?id=146589
1121
1122         Reviewed by Michael Catanzaro.
1123
1124         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1125         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1126
1127         * MiniBrowser/gtk/BrowserWindow.c:
1128         (webViewDecidePolicy):
1129         (newTabCallback):
1130         * MiniBrowser/gtk/main.c:
1131         (createBrowserTab):
1132         (aboutDataRequestFree):
1133         (aboutDataRequestNew):
1134         (aboutDataRequestForView):
1135         (websiteDataRemovedCallback):
1136         (websiteDataClearedCallback):
1137         (aboutDataScriptMessageReceivedCallback):
1138         (domainListFree):
1139         (aboutDataFillTable):
1140         (gotWebsiteDataCallback):
1141         (aboutDataHandleRequest):
1142         (aboutURISchemeRequestCallback):
1143         (main):
1144         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1145         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1146         (serverCallback):
1147         (beforeAll):
1148         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1149         (serverCallback):
1150         (WebsiteDataTest::WebsiteDataTest):
1151         (WebsiteDataTest::~WebsiteDataTest):
1152         (WebsiteDataTest::fetch):
1153         (WebsiteDataTest::remove):
1154         (WebsiteDataTest::clear):
1155         (testWebsiteDataConfiguration):
1156         (testWebsiteDataCache):
1157         (testWebsiteDataStorage):
1158         (testWebsiteDataDatabases):
1159         (testWebsiteDataAppcache):
1160         (beforeAll):
1161         (afterAll):
1162
1163 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1164
1165         Unreviewed, rolling out r211062.
1166         https://bugs.webkit.org/show_bug.cgi?id=167354
1167
1168         broke API tests (Requested by alexchristensen on #webkit).
1169
1170         Reverted changeset:
1171
1172         "Pass down website autoplay policies to media elements"
1173         https://bugs.webkit.org/show_bug.cgi?id=167132
1174         http://trac.webkit.org/changeset/211062
1175
1176 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1177
1178         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1179         https://bugs.webkit.org/show_bug.cgi?id=167330
1180
1181         Reviewed by Tim Horton.
1182
1183         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1184         (TestWebKitAPI::TEST_F):
1185
1186 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1187
1188         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1189         https://bugs.webkit.org/show_bug.cgi?id=167317
1190
1191         Reviewed by Sam Weinig.
1192
1193         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1194         (TestWebKitAPI::TEST_F):
1195
1196 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1197
1198         svn-create-patch should emit properties when files are moved or copied
1199         https://bugs.webkit.org/show_bug.cgi?id=167264
1200
1201         Reviewed by Daniel Bates.
1202
1203         * Scripts/svn-create-patch:
1204         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1205
1206 2017-01-23  Youenn Fablet  <youenn@apple.com>
1207
1208         [WebRTC] Filter libwebrtc link flags
1209         https://bugs.webkit.org/show_bug.cgi?id=167287
1210
1211         Reviewed by Alex Christensen.
1212
1213         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1214         (CMakeGenerator._compute_link_flags):
1215         (CMakeGenerator._compute_link_flags.keep_flag):
1216         (CMakeGenerator._generate_compile_target_options):
1217
1218 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1219
1220         [WebRTC] Make VP8 optional in libwebrtc
1221         https://bugs.webkit.org/show_bug.cgi?id=167257
1222
1223         Reviewed by Darin Adler.
1224
1225         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1226         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1227
1228 2017-01-23  Jer Noble  <jer.noble@apple.com>
1229
1230         Video details does not apear and missing scrubber in Control Center
1231         https://bugs.webkit.org/show_bug.cgi?id=167233
1232
1233         Reviewed by Alex Christensen.
1234
1235         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1236         NowPlayingControlTests for iOS.
1237
1238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1239         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1240         (-[NowPlayingTestWebView setWindowVisible:]):
1241         (TestWebKitAPI::TEST):
1242         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1243         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1244         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1245         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1246         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1247         (SOFT_LINK_CLASS):
1248         (-[TestMessageHandler addMessage:withHandler:]):
1249         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1250         (__simulated_forceClickAssociatedEventsMask):
1251         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1252         (-[TestWKWebViewHostWindow isKeyWindow]):
1253         (-[TestWKWebViewHostWindow makeKeyWindow]):
1254         (-[TestWKWebViewHostWindow resignKeyWindow]):
1255         (-[TestWKWebView initWithFrame:]):
1256         (-[TestWKWebView initWithFrame:configuration:]):
1257         (-[TestWKWebView _setUpTestWindow:]):
1258         (-[TestWKWebView performAfterReceivingMessage:action:]):
1259         (-[TestWKWebView loadTestPageNamed:]):
1260         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1261         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1262         (-[TestWKWebView waitForMessage:]):
1263         (-[TestWKWebView performAfterLoading:]):
1264         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1265         (-[TestWKWebView typeCharacter:]):
1266
1267 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1268
1269         Unreviewed. Bring back gtk-doc error messages after r209981.
1270
1271         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1272         impossible to know what's wrong.
1273
1274         * gtk/gtkdoc.py:
1275         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1276
1277 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1278
1279         [WebRTC] Update build system to make G711 optional in libwebrtc
1280         https://bugs.webkit.org/show_bug.cgi?id=167256
1281
1282         Reviewed by Alex Christensen.
1283
1284         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1285         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1286
1287 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1288
1289         Cleanup RuntimeEnabledFeatures
1290         https://bugs.webkit.org/show_bug.cgi?id=167228
1291
1292         Reviewed by Simon Fraser.
1293
1294         * DumpRenderTree/mac/DumpRenderTree.mm:
1295         (enableExperimentalFeatures):
1296         (resetWebPreferencesToConsistentValues):
1297         (setWebPreferencesForTestOptions):
1298         (resetWebViewToConsistentStateBeforeTesting):
1299         * DumpRenderTree/win/DumpRenderTree.cpp:
1300         (enableExperimentalFeatures):
1301         (resetWebPreferencesToConsistentValues):
1302         More closely match WebKitTestRunner initialization of preferences
1303         for experimental features.
1304
1305 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1306
1307         Build Fix for Windows DumpRenderTree after r210976
1308         https://bugs.webkit.org/show_bug.cgi?id=167115
1309
1310         * DumpRenderTree/win/DumpRenderTree.cpp:
1311         (resetWebPreferencesToConsistentValues):
1312
1313 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1314
1315         Remove outdated ENABLE(CSP_NEXT) build flag
1316         https://bugs.webkit.org/show_bug.cgi?id=167252
1317
1318         Reviewed by Brent Fulgham.
1319
1320         * Scripts/webkitperl/FeatureList.pm:
1321         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1322
1323 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1324
1325         Build Fix for Windows DumpRenderTree after r210976
1326
1327         * DumpRenderTree/win/DumpRenderTree.cpp:
1328         (resetWebPreferencesToConsistentValues):
1329
1330 2017-01-20  Antoine Quint  <graouts@apple.com>
1331
1332         Web Animations should be off by default and enabled as an experimental feature
1333         https://bugs.webkit.org/show_bug.cgi?id=167115
1334         <rdar://problem/30048963>
1335
1336         Reviewed by Joseph Pecoraro.
1337
1338         Turn Web Animations on in DRT.
1339
1340         * DumpRenderTree/mac/DumpRenderTree.mm:
1341         (resetWebPreferencesToConsistentValues):
1342         * DumpRenderTree/win/DumpRenderTree.cpp:
1343         (resetWebPreferencesToConsistentValues):
1344
1345 2017-01-20  Youenn Fablet  <youenn@apple.com>
1346
1347         [WebRTC] Add libwebrtc build infrastructure
1348         https://bugs.webkit.org/show_bug.cgi?id=167207
1349
1350         Reviewed by Alex Christensen.
1351
1352         Adding a script doing the libwebrtc project json to CMake file conversion.
1353
1354         * Scripts/generate-libwebrtc-cmake: Added.
1355         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
1356         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
1357
1358 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1359
1360         Mini Browser: Show tooltip for Experimental Features
1361         https://bugs.webkit.org/show_bug.cgi?id=167225
1362
1363         Reviewed by Alex Christensen.
1364
1365         * MiniBrowser/mac/SettingsController.m:
1366         (-[SettingsController _populateMenu]):
1367         Include the full details string as a tooltip.
1368
1369 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
1370
1371         [Win] Test output results should not be written twice.
1372         https://bugs.webkit.org/show_bug.cgi?id=167197
1373
1374         Reviewed by Brent Fulgham.
1375
1376         Prevent test output from being written twice by returning early from
1377         the dump() function, if it already has been called.
1378         This patch also adds a missing newline to a test output line. 
1379         
1380         * DumpRenderTree/win/DumpRenderTree.cpp:
1381         (dump):
1382
1383 2017-01-20  Antoine Quint  <graouts@apple.com>
1384
1385         [Modern Media Controls] Turn modern media controls on by default
1386         https://bugs.webkit.org/show_bug.cgi?id=165668
1387
1388         Reviewed by Dean Jackson.
1389
1390         Enabled modern media controls by default in test runners.
1391
1392         * DumpRenderTree/TestOptions.h:
1393         * WebKitTestRunner/TestOptions.h:
1394
1395 2017-01-19  Chris Dumez  <cdumez@apple.com>
1396
1397         iterable<> should be enabled on WK1
1398         https://bugs.webkit.org/show_bug.cgi?id=167221
1399         <rdar://problem/30108531>
1400
1401         Reviewed by Youenn Fablet.
1402
1403         * DumpRenderTree/mac/DumpRenderTree.mm:
1404         (resetWebPreferencesToConsistentValues):
1405         * DumpRenderTree/win/DumpRenderTree.cpp:
1406         (resetWebPreferencesToConsistentValues):
1407         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1408         (WTR::InjectedBundle::beginTesting):
1409         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1410         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
1411         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1412
1413 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
1414
1415         Ensure status server logs go to log file
1416         https://bugs.webkit.org/show_bug.cgi?id=167210
1417
1418         Reviewed by Alexey Proskuryakov.
1419
1420         * Scripts/webkitpy/common/net/statusserver.py:
1421         (StatusServer.next_work_item): Change log level from debug to info in
1422         order to facilitate deubgging issues.
1423         (StatusServer.update_work_items): Same.
1424
1425 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
1426
1427         Additional selection tests and interpolation fix
1428         https://bugs.webkit.org/show_bug.cgi?id=167171
1429
1430         Reviewed by Simon Fraser.
1431
1432         We weren't adding the final event when interpolating event streams.
1433
1434         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1435         (-[HIDEventGenerator interpolatedEvents:]):
1436
1437 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1438
1439         [Cocoa] Variation fonts are erroneously disabled on iOS
1440         https://bugs.webkit.org/show_bug.cgi?id=167172
1441
1442         Reviewed by Simon Fraser.
1443
1444         OpenSource builders don't seem to understand sdk=embedded*.
1445
1446         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1447
1448 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1449
1450         Unreviewed. Fix GTK+ unit tests failing since r210531.
1451
1452         Avoid using paths to files that don't actually exist.
1453
1454         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1455         (testWebKitConsoleMessageNetworkError):
1456         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1457         (testContextMenuDefaultMenu):
1458         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
1459         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
1460         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
1461
1462 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1463
1464         [GTK] Provide API to set proxy settings
1465         https://bugs.webkit.org/show_bug.cgi?id=128674
1466
1467         Reviewed by Michael Catanzaro.
1468
1469         Add tests for new proxy settings API.
1470
1471         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1472         (serverCallback):
1473         (ProxyTest::ProxyTest):
1474         (ProxyTest::~ProxyTest):
1475         (ProxyTest::loadURIAndGetMainResourceData):
1476         (ProxyTest::proxyServerPortAsString):
1477         (testWebContextProxySettings):
1478         (beforeAll):
1479
1480 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1481
1482         Add back my old email address so old commits will still match it.
1483
1484         * Scripts/webkitpy/common/config/contributors.json:
1485
1486 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1487
1488         Remove my old email address from contributors.json and watchlist.
1489
1490         * Scripts/validate-committer-lists:
1491         (CommitterListFromGit): Change the mapping to the correct email.
1492         * Scripts/webkitpy/common/config/contributors.json:
1493         * Scripts/webkitpy/common/config/watchlist:
1494
1495 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1496
1497         Unreviewed, rolling out r210848.
1498
1499         This change introduced media-related LayoutTest failures and
1500         crashes on macOS.
1501
1502         Reverted changeset:
1503
1504         "[Modern Media Controls] Turn modern media controls on by
1505         default"
1506         https://bugs.webkit.org/show_bug.cgi?id=165668
1507         http://trac.webkit.org/changeset/210848
1508
1509 2017-01-18  Andreas Kling  <akling@apple.com>
1510
1511         Document::securityOrigin() should return a reference.
1512         <https://webkit.org/b/167124>
1513
1514         Reviewed by Sam Weinig.
1515
1516         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1517         (TestWebKitAPI::TEST_F):
1518
1519 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
1520
1521         [Win] Clipboard tests are flaky.
1522         https://bugs.webkit.org/show_bug.cgi?id=167088
1523
1524         Reviewed by Brent Fulgham.
1525
1526         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
1527         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
1528
1529         * DumpRenderTree/win/DumpRenderTree.cpp:
1530         (main):
1531
1532 2017-01-18  Antoine Quint  <graouts@apple.com>
1533
1534         [Modern Media Controls] Turn modern media controls on by default
1535         https://bugs.webkit.org/show_bug.cgi?id=165668
1536
1537         Reviewed by Dean Jackson.
1538
1539         Enabled modern media controls by default in test runners. 
1540
1541         * DumpRenderTree/TestOptions.h:
1542         * WebKitTestRunner/TestOptions.h:
1543
1544 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1545
1546         Unreviewed, rolling out r210834
1547         https://bugs.webkit.org/show_bug.cgi?id=165668
1548
1549         It introduced dozens of test timeouts.
1550
1551         Reverted changeset:
1552         "[Modern Media Controls] Turn modern media controls on by default"
1553         https://bugs.webkit.org/show_bug.cgi?id=165668
1554         http://trac.webkit.org/changeset/210834
1555
1556 2017-01-17  Antoine Quint  <graouts@apple.com>
1557
1558         [Modern Media Controls] Turn modern media controls on by default
1559         https://bugs.webkit.org/show_bug.cgi?id=165668
1560
1561         Reviewed by Dean Jackson.
1562
1563         Enabled modern media controls by default in test runners. 
1564
1565         * DumpRenderTree/TestOptions.h:
1566         * WebKitTestRunner/TestOptions.h:
1567
1568 2017-01-17  Chris Dumez  <cdumez@apple.com>
1569
1570         Document title changed twice when setting document.title
1571         https://bugs.webkit.org/show_bug.cgi?id=167065
1572
1573         Reviewed by Darin Adler.
1574
1575         Add WebKit2GTK API test that was written by Michael Catanzaro.
1576
1577         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1578         (testWebViewTitleChange):
1579         (beforeAll):
1580
1581 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1582
1583         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1584         https://bugs.webkit.org/show_bug.cgi?id=116551
1585         <rdar://problem/13949830>
1586
1587         Reviewed by Alex Christensen.
1588
1589         * Scripts/webkitperl/FeatureList.pm:
1590         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
1591         that is part of the existing WEB_TIMING feature.
1592
1593         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1594
1595 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
1596
1597         'webkit-patch post' no longer works with moved/copied files
1598         https://bugs.webkit.org/show_bug.cgi?id=166914
1599         <rdar://problem/29979707>
1600
1601         Reviewed by Daniel Bates.
1602
1603         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
1604         file outputs only the "Index:" line with an empty body.  This workaround
1605         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
1606         public email list tracking this bug is below.
1607         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
1608         
1609
1610         * Scripts/svn-create-patch:
1611         (generateDiff): Ignore an "Index:" line with an empty body.
1612
1613 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1614
1615         Remove the REQUEST_ANIMATION_FRAME flag
1616         https://bugs.webkit.org/show_bug.cgi?id=156980
1617         <rdar://problem/25906849>
1618
1619         Reviewed by Simon Fraser.
1620
1621         * Scripts/webkitperl/FeatureList.pm:
1622         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1623
1624 2017-01-15  Sam Weinig  <sam@webkit.org>
1625
1626         Add the ability to use numbers in makeString()
1627         https://bugs.webkit.org/show_bug.cgi?id=167087
1628
1629         Reviewed by Darin Adler.
1630
1631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1632         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
1633         Add tests for StringConcatenate, focusing on new numeric additions.
1634
1635 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1636
1637         Unreviewed, remove stale comment.
1638
1639         This test was fixed by r163173.
1640
1641         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1642
1643 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1644
1645         Annotate large string tests with largeHeap
1646         https://bugs.webkit.org/show_bug.cgi?id=167054
1647
1648         Reviewed by Filip Pizlo.
1649
1650         * Scripts/run-javascriptcore-tests:
1651         * Scripts/run-jsc-stress-tests:
1652
1653 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
1654
1655         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
1656         https://bugs.webkit.org/show_bug.cgi?id=167043
1657
1658         Reviewed by Darin Adler.
1659
1660         * Scripts/webkitperl/FeatureList.pm:
1661
1662 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1663
1664         Remove ENABLE(DETAILS_ELEMENT) guards
1665         https://bugs.webkit.org/show_bug.cgi?id=167042
1666
1667         Reviewed by Alex Christensen.
1668
1669         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1670
1671 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
1672
1673         26 MotionMark performance tests failing
1674         https://bugs.webkit.org/show_bug.cgi?id=166854
1675
1676         Reviewed by Ryosuke Niwa.
1677
1678         Unrelated change. This is the last place that we need to rename Animometer
1679         to MotionMark.
1680
1681         * Scripts/webkitpy/common/config/watchlist:
1682
1683 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
1684
1685         run-jsc-benchmarks' echo should have -e option
1686         https://bugs.webkit.org/show_bug.cgi?id=167009
1687
1688         Reviewed by Sam Weinig.
1689
1690         echo requires `-e` option to use escape sequence.
1691         Without it, in some environment (in my Fedora 25), the escape sequence is not
1692         recognized and just dumped as `\c` etc.
1693
1694         * Scripts/run-jsc-benchmarks:
1695
1696 2017-01-12  Chris Dumez  <cdumez@apple.com>
1697
1698         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1699         https://bugs.webkit.org/show_bug.cgi?id=166995
1700
1701         Reviewed by Jer Noble.
1702
1703         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1704         as some people are having trouble building without it.
1705
1706         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1707
1708 2017-01-12  Sam Weinig  <sam@webkit.org>
1709
1710         Add the ability to filter the set of bindings tests you want to run
1711         https://bugs.webkit.org/show_bug.cgi?id=166977
1712
1713         Reviewed by Tim Horton.
1714
1715         Allows doing things like:
1716             run-bindings-tests TestObj* TestCEReactions*
1717         
1718         to run only those tests that match the patterns.
1719
1720         * Scripts/run-bindings-tests:
1721         (main):
1722         Switch to using optparse and pass the remaining args as the filters.
1723
1724         * Scripts/webkitpy/bindings/main.py:
1725         (BindingsTests.__init__):
1726         Store the pattens.
1727
1728         (BindingsTests.test_matches_patterns):
1729         Add helper predicate to determine if a test should be run. When no
1730         patterns are present, all tests should run.
1731
1732         (BindingsTests.run_tests):
1733         Filter tests using the passed in patterns.
1734
1735 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
1736
1737         Followup fix after r210503.
1738         https://bugs.webkit.org/show_bug.cgi?id=166887
1739
1740         Reviewed by Alex Christensen.
1741
1742         After <http://trac.webkit.org/changeset/210503>, test results are written to a
1743         duplicated file handle on Windows. This patch fixes the remaining call sites.
1744
1745         * DumpRenderTree/PixelDumpSupport.cpp:
1746         * DumpRenderTree/TestRunner.cpp:
1747         (TestRunner::waitToDumpWatchdogTimerFired):
1748         * DumpRenderTree/TestRunner.h:
1749         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1750         * DumpRenderTree/win/DumpRenderTree.cpp:
1751         * DumpRenderTree/win/DumpRenderTreeWin.h:
1752         * DumpRenderTree/win/TestRunnerWin.cpp:
1753         (TestRunner::setSpellCheckerLoggingEnabled):
1754
1755 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
1756
1757         Add committer status for Megan
1758         https://bugs.webkit.org/show_bug.cgi?id=166954
1759
1760         Reviewed by Tim Horton.
1761
1762         Add committer status for Megan Gardner
1763
1764         * Scripts/webkitpy/common/config/contributors.json:
1765
1766 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1767
1768         Unreviewed test fix after r210599.
1769
1770         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1771         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
1772
1773 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1774
1775         Unreviewed build fix after r210599.
1776
1777         Add missing files.
1778
1779         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1780         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1781
1782 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1783
1784         File scheme should not allow access of a resource on a different volume.
1785         https://bugs.webkit.org/show_bug.cgi?id=158552
1786         <rdar://problem/15307582>
1787
1788         Reviewed by Alex Christensen.
1789
1790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1791         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1792         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1793
1794 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1795
1796         Unreviewed, rolling out r210571.
1797
1798         This change broke the 32-bit macOS build and caused LayoutTest
1799         failures.
1800
1801         Reverted changeset:
1802
1803         "File scheme should not allow access of a resource on a
1804         different volume."
1805         https://bugs.webkit.org/show_bug.cgi?id=158552
1806         http://trac.webkit.org/changeset/210571
1807
1808 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1809
1810         [GTK] install-dependencies script misses gdb
1811         https://bugs.webkit.org/show_bug.cgi?id=166917
1812
1813         Reviewed by Michael Catanzaro.
1814
1815         gdb is needed for generating the crash logs.
1816
1817         * gtk/install-dependencies:
1818
1819 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1820
1821         [GTK] No way for applications to set notification permissions without waiting for permission request
1822         https://bugs.webkit.org/show_bug.cgi?id=163366
1823
1824         Reviewed by Carlos Garcia Campos.
1825
1826         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1827         (testWebViewNotification):
1828         (setInitialNotificationPermissionsAllowedCallback):
1829         (setInitialNotificationPermissionsDisallowedCallback):
1830         (testWebViewNotificationInitialPermissionAllowed):
1831         (testWebViewNotificationInitialPermissionDisallowed):
1832         (beforeAll):
1833         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1834         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1835         (WebViewTest::WebViewTest):
1836         (WebViewTest::initializeWebView):
1837         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1838
1839 2017-01-10  Tim Horton  <timothy_horton@apple.com>
1840
1841         MobileMiniBrowser tests don't work by default
1842         https://bugs.webkit.org/show_bug.cgi?id=166910
1843
1844         Reviewed by Alex Christensen.
1845
1846         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
1847         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
1848
1849 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
1850
1851         File scheme should not allow access of a resource on a different volume.
1852         https://bugs.webkit.org/show_bug.cgi?id=158552
1853         <rdar://problem/15307582>
1854
1855         Reviewed by Alex Christensen.
1856
1857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1858         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1859         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1860
1861 2017-01-10  Mark Lam  <mark.lam@apple.com>
1862
1863         Reverting run-jsc-stress-tests' $buildType to use string values.
1864         https://bugs.webkit.org/show_bug.cgi?id=166912
1865
1866         Rubber stamped by Filip Pizlo.
1867
1868         This is so that we can test for it in the tests e.g.
1869         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
1870
1871         * Scripts/run-jsc-stress-tests:
1872
1873 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1874
1875         Temporarily add back the file removed in r210463 to unbreak internal bots.
1876
1877         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
1878
1879 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
1880
1881         svn-apply failed to apply a patch (deleting file with svn property)
1882         https://bugs.webkit.org/show_bug.cgi?id=165953
1883
1884         Reviewed by Daniel Bates.
1885
1886         * Scripts/VCSUtils.pm:
1887         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
1888         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
1889
1890 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1891
1892         Update flakiness dashboard configuration.
1893         https://bugs.webkit.org/show_bug.cgi?id=166869
1894
1895         Reviewed by Alexey Proskuryakov.
1896
1897         * TestResultServer/static-dashboards/builders.jsonp:
1898         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1899
1900 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1901
1902         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
1903         https://bugs.webkit.org/show_bug.cgi?id=165232
1904
1905         Unreviewed follow-up patch after r210539 and r210523.
1906
1907         Instead of using that environment variable, the argument
1908         --display-server=xorg should be passed now.
1909
1910         The GTK+ performance bot was the only bot using this, and is
1911         already passing --display-server=xorg after r210539.
1912
1913         * Scripts/webkitpy/port/gtk.py:
1914         (GtkPort._driver_class):
1915
1916 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1917
1918         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
1919         https://bugs.webkit.org/show_bug.cgi?id=166872
1920
1921         Reviewed by Michael Catanzaro.
1922
1923         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
1924         Define the required "--display-server=driver" in the bot additionalArguments config entry.
1925         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
1926         The step RunWebKitTests already has support for it.
1927
1928         * BuildSlaveSupport/build.webkit.org-config/config.json:
1929         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1930         (RunGtkAPITests.start):
1931         (RunAndUploadPerfTests.start):
1932         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1933
1934 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
1935
1936         Unreviewed, rolling out r210531.
1937
1938         This change broke the 32-bit macOS build and caused LayoutTest
1939         failures.
1940
1941         Reverted changeset:
1942
1943         "File scheme should not allow access of a resource on a
1944         different volume."
1945         https://bugs.webkit.org/show_bug.cgi?id=158552
1946         http://trac.webkit.org/changeset/210531
1947
1948 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
1949
1950         File scheme should not allow access of a resource on a different volume.
1951         https://bugs.webkit.org/show_bug.cgi?id=158552
1952         <rdar://problem/15307582>
1953
1954         Reviewed by Alex Christensen.
1955
1956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1957         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1958         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1959
1960 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1961
1962         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
1963         https://bugs.webkit.org/show_bug.cgi?id=165232
1964
1965         Reviewed by Michael Catanzaro.
1966
1967         Add a new WaylandDriver to run the tests in the user current wayland session.
1968
1969         Also merge all the configuration options for selecting the display server inside one
1970         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
1971
1972         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
1973
1974         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
1975         (TestRunner._create_driver):
1976         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1977         (parse_args):
1978         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1979         (PerfTestsRunner._parse_args):
1980         * Scripts/webkitpy/port/gtk.py:
1981         (GtkPort.__init__):
1982         (GtkPort._driver_class):
1983         (GtkPort._search_paths):
1984         * Scripts/webkitpy/port/waylanddriver.py: Added.
1985         (WaylandDriver):
1986         (WaylandDriver.check_driver):
1987         (WaylandDriver._setup_environ_for_test):
1988         (WaylandDriver._start):
1989
1990 2017-01-09  Andy Estes  <aestes@apple.com>
1991
1992         [QuickLook] Add a layout test for webkit.org/b/135651
1993         https://bugs.webkit.org/show_bug.cgi?id=166855
1994
1995         Reviewed by Andreas Kling.
1996
1997         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1998         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
1999         errors with code WebKitErrorCannotShowURL.
2000         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2001         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2002         not specific to WebKit2 error codes.
2003
2004 2017-01-09  Antoine Quint  <graouts@apple.com>
2005
2006         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2007         https://bugs.webkit.org/show_bug.cgi?id=166837
2008
2009         Reviewed by Alex Christensen.
2010
2011         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2012         the provided value when trying to determine the path to the test file. Failing
2013         that, we use the computed URL or the raw path provided to cover all cases.
2014         
2015         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2016         by applying this patch and seeing the number test failures dramatically reduced
2017         with WK1 due to the option to turn modern media controls off for older media controls
2018         tests.
2019
2020         * DumpRenderTree/DumpRenderTree.h:
2021         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2022         (parseInputLine):
2023         * DumpRenderTree/TestOptions.h:
2024         * DumpRenderTree/TestOptions.mm:
2025         (TestOptions::TestOptions):
2026         * DumpRenderTree/mac/DumpRenderTree.mm:
2027         (runTest):
2028
2029 2017-01-09  Milan Crha  <mcrha@redhat.com>
2030
2031         prepare-ChangeLog: Correct help string for --style option
2032         https://bugs.webkit.org/show_bug.cgi?id=166725
2033
2034         Reviewed by Alexey Proskuryakov.
2035
2036         * Scripts/prepare-ChangeLog:
2037         (main):
2038
2039 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2040
2041         https://bugs.webkit.org/show_bug.cgi?id=166839
2042         Add php7 support for macOS.
2043         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2044
2045         Reviewed by Alexey Proskuryakov.
2046
2047         * Scripts/webkitpy/port/base.py:
2048         (Port._is_darwin_php_version_7):
2049         (Port._debian_php_version):
2050         (Port):
2051         (Port._darwin_php_version):
2052         (Port._apache_config_file_name_for_platform):
2053
2054 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2055
2056         [GTK] Should support key and code properties on keyboard events
2057         https://bugs.webkit.org/show_bug.cgi?id=166759
2058
2059         Reviewed by Carlos Garcia Campos.
2060
2061         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2062         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2063         on tests.
2064
2065 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2066
2067         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2068         https://bugs.webkit.org/show_bug.cgi?id=166760
2069
2070         Reviewed by Darin Adler.
2071
2072         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2073         We can work around that by duplicating and redirecting stdout.
2074
2075         * DumpRenderTree/PixelDumpSupport.cpp:
2076         (dumpWebViewAsPixelsAndCompareWithExpected):
2077         (printPNG):
2078         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2079         (logEventProc):
2080         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2081         (DRTDesktopNotificationPresenter::showDesktopNotification):
2082         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2083         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2084         * DumpRenderTree/win/DumpRenderTree.cpp:
2085         (dumpFrameScrollPosition):
2086         (dumpHistoryItem):
2087         (dumpBackForwardList):
2088         (dump):
2089         (runTest):
2090         (main):
2091         * DumpRenderTree/win/DumpRenderTreeWin.h:
2092         * DumpRenderTree/win/EditingDelegate.cpp:
2093         (EditingDelegate::shouldBeginEditingInDOMRange):
2094         (EditingDelegate::shouldEndEditingInDOMRange):
2095         (EditingDelegate::shouldInsertNode):
2096         (EditingDelegate::shouldInsertText):
2097         (EditingDelegate::shouldDeleteDOMRange):
2098         (EditingDelegate::shouldChangeSelectedDOMRange):
2099         (EditingDelegate::shouldApplyStyle):
2100         (EditingDelegate::shouldChangeTypingStyle):
2101         (EditingDelegate::doPlatformCommand):
2102         (EditingDelegate::webViewDidBeginEditing):
2103         (EditingDelegate::webViewDidChange):
2104         (EditingDelegate::webViewDidEndEditing):
2105         (EditingDelegate::webViewDidChangeTypingStyle):
2106         (EditingDelegate::webViewDidChangeSelection):
2107         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2108         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2109         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2110         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2111         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2112         (FrameLoadDelegate::didCommitLoadForFrame):
2113         (FrameLoadDelegate::didReceiveTitle):
2114         (FrameLoadDelegate::didFinishLoadForFrame):
2115         (FrameLoadDelegate::didFailLoadWithError):
2116         (FrameLoadDelegate::willPerformClientRedirectToURL):
2117         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2118         (FrameLoadDelegate::windowScriptObjectAvailable):
2119         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2120         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2121         (FrameLoadDelegate::didDisplayInsecureContent):
2122         (FrameLoadDelegate::didRunInsecureContent):
2123         (FrameLoadDelegate::webViewProgressFinishedNotification):
2124         * DumpRenderTree/win/HistoryDelegate.cpp:
2125         (HistoryDelegate::didNavigateWithNavigationData):
2126         (HistoryDelegate::didPerformClientRedirectFromURL):
2127         (HistoryDelegate::didPerformServerRedirectFromURL):
2128         (HistoryDelegate::updateHistoryTitle):
2129         (HistoryDelegate::populateVisitedLinksForWebView):
2130         * DumpRenderTree/win/PolicyDelegate.cpp:
2131         (PolicyDelegate::decidePolicyForNavigationAction):
2132         (PolicyDelegate::unableToImplementPolicyWithError):
2133         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2134         (ResourceLoadDelegate::willSendRequest):
2135         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2136         (ResourceLoadDelegate::didReceiveResponse):
2137         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2138         (ResourceLoadDelegate::didFailLoadingWithError):
2139         * DumpRenderTree/win/TestRunnerWin.cpp:
2140         (TestRunner::addDisallowedURL):
2141         (TestRunner::originsWithApplicationCache):
2142         (TestRunner::setStorageDatabaseIdleInterval):
2143         (TestRunner::closeIdleLocalStorageDatabases):
2144         (TestRunner::copyDecodedHostName):
2145         (TestRunner::copyEncodedHostName):
2146         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2147         (TestRunner::isGeolocationProviderActive):
2148         (TestRunner::pathToLocalResource):
2149         (TestRunner::setMockDeviceOrientation):
2150         (TestRunner::setMockGeolocationPosition):
2151         (TestRunner::setMockGeolocationPositionUnavailableError):
2152         (TestRunner::setSpatialNavigationEnabled):
2153         (TestRunner::setAutomaticLinkDetectionEnabled):
2154         (TestRunner::isCommandEnabled):
2155         (TestRunner::authenticateSession):
2156         (TestRunner::addChromeInputField):
2157         (TestRunner::removeChromeInputField):
2158         (TestRunner::focusWebView):
2159         (TestRunner::grantWebNotificationPermission):
2160         (TestRunner::denyWebNotificationPermission):
2161         (TestRunner::removeAllWebNotificationPermissions):
2162         (TestRunner::simulateWebNotificationClick):
2163         (TestRunner::imageCountInGeneralPasteboard):
2164         * DumpRenderTree/win/UIDelegate.cpp:
2165         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2166         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2167         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2168         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2169         (UIDelegate::webViewAddMessageToConsole):
2170         (UIDelegate::exceededDatabaseQuota):
2171         (UIDelegate::setStatusText):
2172         (UIDelegate::didPressMissingPluginButton):
2173
2174 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2175
2176         Add a setting to create editable MiniBrowser windows by default
2177         https://bugs.webkit.org/show_bug.cgi?id=166806
2178
2179         Reviewed by Beth Dakin.
2180
2181         * MiniBrowser/mac/AppDelegate.m:
2182         (-[BrowserAppDelegate createBrowserWindowController:]):
2183         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2184         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2185         * MiniBrowser/mac/SettingsController.h:
2186         * MiniBrowser/mac/SettingsController.m:
2187         (-[SettingsController _populateMenu]):
2188         (-[SettingsController validateMenuItem:]):
2189         (-[SettingsController toggleCreateEditorByDefault:]):
2190         (-[SettingsController createEditorByDefault]):
2191         Add a setting and update the key equivalents accordingly.
2192         Also make sure to make the right kind of window on launch.
2193
2194 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2195
2196         Fix the 32-bit build.
2197
2198         * MiniBrowser/mac/BrowserWindowController.h:
2199         * MiniBrowser/mac/BrowserWindowController.m:
2200
2201 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2202
2203         Fix the 32-bit build.
2204
2205         * MiniBrowser/mac/BrowserWindowController.m:
2206
2207 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2208
2209         Make it possible to drop HTML files on the MiniBrowser icon
2210         https://bugs.webkit.org/show_bug.cgi?id=166802
2211
2212         Reviewed by Simon Fraser.
2213
2214         * MiniBrowser/mac/AppDelegate.m:
2215         (-[BrowserAppDelegate application:openFile:]):
2216         * MiniBrowser/mac/Info.plist:
2217         If you're using an editable window, the usual trick of dropping on the
2218         window doesn't work anymore (it makes an <attachment> instead).
2219
2220 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2221
2222         MiniBrowser window gets smaller each time it is instantiated
2223         https://bugs.webkit.org/show_bug.cgi?id=166807
2224
2225         Reviewed by Andy Estes.
2226
2227         * MiniBrowser/mac/BrowserWindowController.m:
2228         (-[BrowserWindowController windowDidLoad]):
2229         * MiniBrowser/mac/BrowserWindow.xib:
2230         Turn on full-window content view support with IB, instead of waiting
2231         until after the views have been loaded. This seems to resolve the
2232         longstanding ever-shrinking-window problem.
2233
2234 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2235
2236         Add indent/outdent items to MiniBrowser's new format menu
2237         https://bugs.webkit.org/show_bug.cgi?id=166805
2238
2239         Reviewed by Dan Bernstein.
2240
2241         * MiniBrowser/mac/MainMenu.xib:
2242
2243 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2244
2245         Add a stock Format menu to MiniBrowser
2246         https://bugs.webkit.org/show_bug.cgi?id=166804
2247
2248         Reviewed by Andy Estes.
2249
2250         * MiniBrowser/mac/MainMenu.xib:
2251         Many of the features automatically work with editable web views.
2252         However, this seems to expose a bug where none of the font-related features
2253         (Cmd-B, for example) work until the first time the font panel is shown,
2254         per process, which will need to be investigated separately.
2255
2256 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2257
2258         Remove unused applicationWillTerminate methods from MiniBrowser
2259         https://bugs.webkit.org/show_bug.cgi?id=166803
2260
2261         Reviewed by Andy Estes.
2262
2263         * MiniBrowser/mac/AppDelegate.m:
2264         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2265         * MiniBrowser/mac/BrowserWindowController.h:
2266         * MiniBrowser/mac/BrowserWindowController.m:
2267         (-[BrowserWindowController applicationTerminating]): Deleted.
2268         * MiniBrowser/mac/WK1BrowserWindowController.m:
2269         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2270         * MiniBrowser/mac/WK2BrowserWindowController.m:
2271         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2272
2273 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2274
2275         Add the ability to create empty contentEditable windows in MiniBrowser
2276         https://bugs.webkit.org/show_bug.cgi?id=166801
2277
2278         Reviewed by Wenson Hsieh.
2279
2280         * MiniBrowser/mac/AppDelegate.h:
2281         * MiniBrowser/mac/AppDelegate.m:
2282         (-[BrowserAppDelegate createBrowserWindowController:]):
2283         (-[BrowserAppDelegate newWindow:]):
2284         (-[BrowserAppDelegate newEditorWindow:]):
2285         (-[BrowserAppDelegate openDocument:]):
2286         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2287         * MiniBrowser/mac/BrowserWindowController.h:
2288         * MiniBrowser/mac/BrowserWindowController.m:
2289         (-[BrowserWindowController loadHTMLString:]):
2290         (-[BrowserWindowController toggleEditable:]):
2291         * MiniBrowser/mac/MainMenu.xib:
2292         * MiniBrowser/mac/WK1BrowserWindowController.m:
2293         (-[WK1BrowserWindowController awakeFromNib]):
2294         (-[WK1BrowserWindowController loadHTMLString:]):
2295         (-[WK1BrowserWindowController validateMenuItem:]):
2296         (-[WK1BrowserWindowController setEditable:]):
2297         (-[WK1BrowserWindowController updateTitle:]):
2298         * MiniBrowser/mac/WK2BrowserWindowController.m:
2299         (-[WK2BrowserWindowController awakeFromNib]):
2300         (-[WK2BrowserWindowController validateMenuItem:]):
2301         (-[WK2BrowserWindowController setEditable:]):
2302         (-[WK2BrowserWindowController updateTitle:]):
2303         (-[WK2BrowserWindowController loadHTMLString:]):
2304         Merge more functionality from WebEditingTester.
2305         Add two menu items for creating empty editable WebKit1/2 windows.
2306         Add a menu item to the Edit menu to toggle editability on any window.
2307
2308 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2309
2310         Implement find-in-page in MiniBrowser
2311         https://bugs.webkit.org/show_bug.cgi?id=166799
2312
2313         Reviewed by Andy Estes.
2314
2315         * MiniBrowser/mac/BrowserWindow.xib:
2316         * MiniBrowser/mac/BrowserWindowController.h:
2317         * MiniBrowser/mac/BrowserWindowController.m:
2318         (-[BrowserWindowController find:]): Deleted.
2319         * MiniBrowser/mac/MainMenu.xib:
2320         * MiniBrowser/mac/WK1BrowserWindowController.m:
2321         (-[WK1BrowserWindowController toggleShrinkToFit:]):
2322         (-[WK1BrowserWindowController find:]): Deleted.
2323         * MiniBrowser/mac/WK2BrowserWindowController.m:
2324         (-[WK2BrowserWindowController awakeFromNib]):
2325         (-[WK2BrowserWindowController dealloc]):
2326         (-[WK2BrowserWindowController validateMenuItem:]):
2327         (-[WK2BrowserWindowController performTextFinderAction:]):
2328         (-[WK2BrowserWindowController findBarView]):
2329         (-[WK2BrowserWindowController setFindBarView:]):
2330         (-[WK2BrowserWindowController isFindBarVisible]):
2331         (-[WK2BrowserWindowController setFindBarVisible:]):
2332         (-[WK2BrowserWindowController contentView]):
2333         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
2334         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
2335         (-[WK2BrowserWindowController find:]): Deleted.
2336         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
2337         protocol. At first glance, it's pretty broken, but vaguely works.
2338
2339 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2340
2341         Share the implementation of MiniBrowser view hiding functionality
2342         https://bugs.webkit.org/show_bug.cgi?id=166800
2343
2344         Reviewed by Andy Estes.
2345
2346         * MiniBrowser/mac/BrowserWindowController.m:
2347         (-[BrowserWindowController showHideWebView:]):
2348         (-[BrowserWindowController removeReinsertWebView:]):
2349         * MiniBrowser/mac/WK1BrowserWindowController.m:
2350         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
2351         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
2352         * MiniBrowser/mac/WK2BrowserWindowController.m:
2353         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
2354         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
2355         Move the implementation of these two things to the shared superclass,
2356         since they don't depend on WebKit-specific things.
2357         Also, there was no reason to retain the (WK)WebView while it was unparented,
2358         as the BrowserWindowController maintains a reference the entire time.
2359
2360 2017-01-06  Andy Estes  <aestes@apple.com>
2361
2362         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
2363         https://bugs.webkit.org/show_bug.cgi?id=166789
2364
2365         Reviewed by Alex Christensen.
2366
2367         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2368         * DumpRenderTree/PlatformMac.cmake:
2369         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
2370         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
2371         * DumpRenderTree/mac/DumpRenderTree.mm:
2372         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2373         createXMLStringFromWebArchiveData().
2374         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
2375         * WebKitTestRunner/Configurations/Base.xcconfig:
2376         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
2377         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2378         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2379         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2380         createXMLStringFromWebArchiveData().
2381         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
2382         * WebKitTestRunner/PlatformMac.cmake:
2383         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2384         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
2385
2386 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2387
2388         Minor cleanups to IndentOutdentCommand and related code
2389         https://bugs.webkit.org/show_bug.cgi?id=166791
2390
2391         Reviewed by Simon Fraser.
2392
2393         * WebEditingTester/EditingOperations.m:
2394         (editingOperations):
2395         Add the outdent operation to WebEditingTester.
2396
2397 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
2398
2399         Create a plan and a patch files for MotionMark and delete the Animometer's ones
2400         https://bugs.webkit.org/show_bug.cgi?id=166785
2401
2402         Reviewed by Ryosuke Niwa.
2403
2404         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2405         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
2406
2407 2017-01-06  Antoine Quint  <graouts@apple.com>
2408
2409         Support webkit-test-runner key-value pairs in http tests
2410         https://bugs.webkit.org/show_bug.cgi?id=149812
2411
2412         Reviewed by Alex Christensen.
2413
2414         We pass the absolute path for a test through to WKTR so that we can parse
2415         tests that are running as URLs for webkit-test-runner options.
2416
2417         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2418         (parseInputLine):
2419
2420         Explicitly skip the --absolute-path option in DRT or else we'd crash.
2421
2422         * Scripts/webkitpy/port/driver.py:
2423         (Driver._command_from_driver_input):
2424
2425         Pass the absolute path to the file through the CLI.
2426
2427         * WebKitTestRunner/TestController.cpp:
2428         (WTR::updateTestOptionsFromTestHeader):
2429         (WTR::TestController::testOptionsForTest):
2430         (WTR::parseInputLine):
2431         (WTR::TestController::runTest):
2432         * WebKitTestRunner/TestController.h:
2433
2434 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2435
2436         Warning about unconnectable outlets when opening a MiniBrowser window
2437         https://bugs.webkit.org/show_bug.cgi?id=166756
2438
2439         Reviewed by Dan Bernstein.
2440
2441         * MiniBrowser/mac/BrowserWindow.xib:
2442         When launching MiniBrowser, it says:
2443         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
2444             (MBToolbarItem): missing setter or instance variable
2445         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
2446             (NSButtonCell): missing setter or instance variable.
2447
2448         It looks like someone added the connection from the share button
2449         to the BrowserWindowController three times; only one of the connections
2450         is valid. Remove the other two.
2451
2452 2017-01-05  Keith Rollin  <krollin@apple.com>
2453
2454         Add WebCore::URL::protocolHostAndPort
2455         https://bugs.webkit.org/show_bug.cgi?id=166426
2456
2457         Reviewed by Alex Christensen.
2458
2459         Add test for protocolHostAndPort.
2460
2461         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2462         (TestWebKitAPI::TEST_F):
2463
2464 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
2465
2466         [Win] Archive test result is failing.
2467         https://bugs.webkit.org/show_bug.cgi?id=166720
2468
2469         Reviewed by Alex Christensen.
2470
2471         Deleting the layout test result folder is sometimes failing
2472         on Windows. This is not a critical error.
2473
2474         * BuildSlaveSupport/test-result-archive:
2475         (archiveTestResults):
2476
2477 2017-01-04  Tomas Popela  <tpopela@redhat.com>
2478
2479         [GTK] Minibrowser: Add printing support
2480         https://bugs.webkit.org/show_bug.cgi?id=165298
2481
2482         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
2483         an error during the print, it's printed on the console.
2484
2485         Reviewed by Michael Catanzaro.
2486
2487         * MiniBrowser/gtk/BrowserWindow.c:
2488         (webKitPrintOperationFailedCallback):
2489         (printPage):
2490         (browser_window_init):
2491
2492 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
2493
2494         [css-grid] Fix crash clamping grid lines
2495         https://bugs.webkit.org/show_bug.cgi?id=166637
2496
2497         Reviewed by Darin Adler.
2498
2499         Creates new unit test to verify that the maximum tracks limit
2500         is used in GridPosition too.
2501
2502         * TestWebKitAPI/PlatformEfl.cmake:
2503         * TestWebKitAPI/PlatformGTK.cmake:
2504         * TestWebKitAPI/PlatformWin.cmake:
2505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2506         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
2507         (TestWebKitAPI::TEST):
2508
2509 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2510
2511         Move editing history scripts to WebCore PrivateHeaders
2512         https://bugs.webkit.org/show_bug.cgi?id=166709
2513         <rdar://problem/29876612>
2514
2515         Reviewed by Dan Bernstein.
2516
2517         Update references to editing script files in WebCore that were moved.
2518
2519         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
2520
2521 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2522
2523         Unreviewed, build fix after r210313 part 2
2524         https://bugs.webkit.org/show_bug.cgi?id=166676
2525
2526         Add 'U' suffix.
2527
2528         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2529         (TestWebKitAPI::TEST):
2530         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2531         (TestWebKitAPI::TEST):
2532
2533 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2534
2535         Limit thread name appropriately
2536         https://bugs.webkit.org/show_bug.cgi?id=166676
2537
2538         Reviewed by Sam Weinig.
2539
2540         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2541         (TestWebKitAPI::TEST):
2542         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2543         (TestWebKitAPI::TEST):
2544
2545 2017-01-04  Andy Estes  <aestes@apple.com>
2546
2547         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
2548         https://bugs.webkit.org/show_bug.cgi?id=166696
2549
2550         Reviewed by Tim Horton.
2551
2552         * TestWebKitAPI/PlatformGTK.cmake:
2553         * TestWebKitAPI/PlatformWin.cmake:
2554         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2555         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
2556         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
2557         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
2558         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
2559         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
2560         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
2561
2562 2017-01-03  Brian Burg  <bburg@apple.com>
2563
2564         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
2565         https://bugs.webkit.org/show_bug.cgi?id=166003
2566         <rdar://problem/28718990>
2567
2568         Reviewed by Joseph Pecoraro.
2569
2570         Teach run-inspector-generator-tests to generate test output using the platform name
2571         derived from the directory that the test is in. For example, tests in the /generic/
2572         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
2573
2574         * Scripts/webkitpy/inspector/main.py:
2575         (InspectorGeneratorTests.generate_from_json):
2576         (InspectorGeneratorTests.run_tests):
2577         (InspectorGeneratorTests.main):
2578
2579 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2580
2581         Unreviewed cmake buildfix after r210266.
2582
2583         * DumpRenderTree/PlatformMac.cmake:
2584
2585 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2586
2587         Provide a setting for clients to always prefer low-power WebGL
2588         https://bugs.webkit.org/show_bug.cgi?id=166675
2589         <rdar://problem/29834093>
2590
2591         Reviewed by Dan Bernstein.
2592
2593         * MiniBrowser/mac/Info.plist:
2594         Have MiniBrowser claim to be a modern app that supports
2595         automatic graphics switching. WebKit needs to support automatic
2596         graphics switching, so our test app might as well. Without this
2597         Info.plist parameter, this change has no effect, and bringing up
2598         a WebGL context still brings up the discrete GPU (also true of the
2599         existing web-exposed preferLowPowerToHighPerformance API).
2600
2601 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2602
2603         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
2604         https://bugs.webkit.org/show_bug.cgi?id=166645
2605
2606         Reviewed by Carlos Garcia Campos.
2607
2608         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2609         (TestWebKitAPI::TEST):
2610
2611 2017-01-03  Andy Estes  <aestes@apple.com>
2612
2613         Place all the Cocoa WebCore API tests in the same directory
2614         https://bugs.webkit.org/show_bug.cgi?id=166673
2615
2616         Reviewed by Michael Catanzaro.
2617
2618         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2619         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
2620         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
2621         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
2622
2623 2017-01-03  Tim Horton  <timothy_horton@apple.com>
2624
2625         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2626         https://bugs.webkit.org/show_bug.cgi?id=166450
2627         <rdar://problem/29447824>
2628
2629         Reviewed by Darin Adler.
2630
2631         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2632         * DumpRenderTree/TestRunner.cpp:
2633         (TestRunner::staticFunctions):
2634         * DumpRenderTree/mac/TestRunnerMac.mm:
2635         (setSpellCheckerLoggingEnabledCallback):
2636         * DumpRenderTree/win/TestRunnerWin.cpp:
2637         (setSpellCheckerLoggingEnabledCallback):
2638         * DumpRenderTree/mac/DumpRenderTree.mm:
2639         (resetWebViewToConsistentStateBeforeTesting):
2640         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
2641         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
2642         (stringForCorrectionResponse):
2643         (drt_NSSpellChecker_recordResponseToCorrection):
2644         (swizzleNSSpellCheckerMethodsIfNeeded):
2645         (setSpellCheckerLoggingEnabled):
2646         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
2647         set to true, logs to stdout (which ends up in the test result) whenever
2648         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2649         is called, and then calls the original method. It is reset to false between tests.
2650
2651 2017-01-03  Sam Weinig  <sam@webkit.org>
2652
2653         Make WTF::Expected support Ref template parameters
2654         https://bugs.webkit.org/show_bug.cgi?id=166662
2655
2656         Reviewed by Alex Christensen.
2657
2658         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2659         (TestWebKitAPI::TEST):
2660         Add tests for using Ref with Expected.
2661
2662 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2663
2664         [GTK] Expose WebKitSecurityOrigin API
2665         https://bugs.webkit.org/show_bug.cgi?id=166632
2666
2667         Reviewed by Carlos Garcia Campos.
2668
2669         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2670         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
2671         (testSecurityOriginBasicConstructor):
2672         (testSecurityOriginURIConstructor):
2673         (testSecurityOriginDefaultPort):
2674         (testSecurityOriginFileURI):
2675         (testSecurityOriginDataURI):
2676         (beforeAll):
2677         (afterAll):
2678
2679 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2680
2681         [GTK] HTTP auth layout tests are flaky
2682         https://bugs.webkit.org/show_bug.cgi?id=158919
2683
2684         Reviewed by Michael Catanzaro.
2685
2686         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
2687         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
2688         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
2689         missing valac in the bots.
2690
2691 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2692
2693         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
2694         https://bugs.webkit.org/show_bug.cgi?id=165797
2695
2696         Reviewed by Michael Catanzaro.
2697
2698         Move directory ruleset after all exclude rules of Source rulset.
2699
2700         * gtk/manifest.txt.in:
2701
2702 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2703
2704         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
2705         https://bugs.webkit.org/show_bug.cgi?id=166636
2706
2707         Reviewed by Darin Adler.
2708
2709         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2710         (TestWebKitAPI::TEST):
2711
2712 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
2713
2714         [GTK] WebCore/CSSParser unit test is not being built
2715         https://bugs.webkit.org/show_bug.cgi?id=166492
2716
2717         Reviewed by Michael Catanzaro.
2718
2719         This test was introduced in r175930, but we were not building
2720         it on GTK+ port since r176015.
2721         This patch marks the test to be built again on GTK+.
2722         JFTR, the test is passing right now.
2723
2724         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
2725         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
2726
2727 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
2728
2729         AX: Expose block quote level to iOS API
2730         https://bugs.webkit.org/show_bug.cgi?id=166629
2731         <rdar://problem/29834793>
2732
2733         Reviewed by Darin Adler.
2734
2735         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2736         (AccessibilityUIElement::numberAttributeValue):
2737         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2738         (WTR::AccessibilityUIElement::numberAttributeValue):
2739
2740 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2741
2742         SecurityOrigin::create triplet constructor does not canonicalize port
2743         https://bugs.webkit.org/show_bug.cgi?id=166624
2744
2745         Reviewed by Daniel Bates.
2746
2747         * TestWebKitAPI/PlatformGTK.cmake:
2748         * TestWebKitAPI/PlatformWin.cmake:
2749         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2750         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
2751         (TestWebKitAPI::SecurityOriginTest::SetUp):
2752         (TestWebKitAPI::TEST_F):
2753
2754 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2755
2756         [GTK] Improve user agent construction
2757         https://bugs.webkit.org/show_bug.cgi?id=142074
2758
2759         Reviewed by Carlos Garcia Campos.
2760
2761         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2762         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2763         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2764         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
2765         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2766         (TestWebKitAPI::TEST):
2767
2768 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2769
2770         [GTK] Improve user agent construction
2771         https://bugs.webkit.org/show_bug.cgi?id=142074
2772
2773         Reviewed by Carlos Garcia Campos.
2774
2775         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2776         (TestWebKitAPI::TEST):
2777
2778 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
2779
2780         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
2781         https://bugs.webkit.org/show_bug.cgi?id=166472
2782         rdar://problem/29675551
2783
2784         Reviewed by Tim Horton.
2785
2786         These changes are necessary to allow the mouse to leave the WTR window while
2787         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
2788         (which DRT does); we'd always go through mouseMoved, which hits an early return
2789         in WebViewImpl::mouseMoved() when the point is outside the view.
2790
2791         * WebKitTestRunner/mac/EventSenderProxy.mm:
2792         (WTR::EventSenderProxy::mouseMoveTo):
2793
2794 2016-12-23  Andy Estes  <aestes@apple.com>
2795
2796         [iOS] Fix some crashing webarchive tests
2797         https://bugs.webkit.org/show_bug.cgi?id=166470
2798
2799         Reviewed by Andreas Kling.
2800
2801         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
2802         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
2803         so this change uses that on both platforms.
2804
2805         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
2806         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
2807         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
2808         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
2809         * WebKitTestRunner/PlatformMac.cmake:
2810         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2811         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
2812
2813 2016-12-22  Saam Barati  <sbarati@apple.com>
2814
2815         WebAssembly: Silence the output of the spec-tests
2816         https://bugs.webkit.org/show_bug.cgi?id=166417
2817
2818         Reviewed by Mark Lam.
2819
2820         * Scripts/run-jsc-stress-tests:
2821
2822 2016-12-22  Zhuo Li  <zachli@apple.com>
2823
2824         [Cocoa] SPI for setloadsImagesAutomatically.
2825         https://bugs.webkit.org/show_bug.cgi?id=166401.
2826
2827         Reviewed by Darin Adler.
2828
2829         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2830         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
2831         _loadsImagesAutomatically returns YES.
2832
2833 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2834
2835         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
2836         https://bugs.webkit.org/show_bug.cgi?id=161328
2837         <rdar://problem/28475977>
2838
2839         Reviewed by Darin Adler.
2840
2841         Running a test that scales the viewport and listens to a didEndZooming callback (such as
2842         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
2843         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
2844         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
2845         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
2846         load, should prevent this from happening, but from reading documentation and code inspection, this is not
2847         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
2848         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
2849         we finish running a test and before we load the next test.
2850
2851         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
2852         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
2853         previous test started zooming and then finished before zooming completed. Since this happens before the next
2854         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
2855
2856         * WebKitTestRunner/ios/TestControllerIOS.mm:
2857         (WTR::TestController::platformResetStateToConsistentValues):
2858
2859 2016-12-22  Jer Noble  <jer.noble@apple.com>
2860
2861         Muted media element playback should not interrupt other audio playback
2862         https://bugs.webkit.org/show_bug.cgi?id=166347
2863
2864         Reviewed by Eric Carlson.
2865
2866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2867         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2868         (TestWebKitAPI::TEST):
2869         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
2870
2871 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
2872
2873         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
2874         https://bugs.webkit.org/show_bug.cgi?id=166346
2875
2876         Reviewed by Carlos Garcia Campos.
2877
2878         Enable WebRTC by default to simplify testing.
2879
2880         * MiniBrowser/gtk/main.c:
2881         (main):
2882
2883 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2884
2885         REGRESSION: API test failure: WKWebView.LocalStorageClear
2886         https://bugs.webkit.org/show_bug.cgi?id=166032
2887         <rdar://problem/29758423>
2888
2889         Reviewed by Simon Fraser.
2890
2891         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2892         to ensure that the view is destroyed before the callback fires.
2893
2894         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2895         (TEST):
2896
2897 2016-12-21  Saam Barati  <sbarati@apple.com>
2898
2899         WebAssembly: Import spec tests
2900         https://bugs.webkit.org/show_bug.cgi?id=166395
2901
2902         Rubber stamped by Keith Miller.
2903
2904         * Scripts/run-jsc-stress-tests:
2905
2906 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2907
2908         REGRESSION: API test failure: _WKDownload.OriginatingWebView
2909         https://bugs.webkit.org/show_bug.cgi?id=166033
2910         <rdar://problem/29758428>
2911
2912         Reviewed by Simon Fraser.
2913
2914         Add an @autoreleasepool around the code that allocates the WKWebView, 
2915         so that it can be destroyed by removing the last reference in _downloadDidStart.
2916
2917         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2918         (TEST):
2919
2920 2016-12-21  Daniel Bates  <dabates@apple.com>
2921
2922         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
2923         https://bugs.webkit.org/show_bug.cgi?id=166356
2924
2925         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
2926         as a means to allow a test to explicit allow an embedding client to open a new windows
2927         such that the default behavior is for the embedding client to forbid such an action.
2928         The test plugins/get-url-with-blank-target.html assumes this default behavior though
2929         it is currently skipped on WebKit2 because questions were raised in the patch for
2930         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
2931         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
2932         this test.
2933
2934         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2935         (WTR::TestRunner::setCanOpenWindows):
2936
2937 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
2938
2939         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
2940         https://bugs.webkit.org/show_bug.cgi?id=166031
2941
2942         Reviewed by Tim Horton.
2943         
2944         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2945         to ensure that the view is destroyed before the callback fires.
2946
2947         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
2948
2949 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
2950
2951         Throw Exception when test doesn't clean up HID Events properly
2952         https://bugs.webkit.org/show_bug.cgi?id=166271
2953
2954         Reviewed by Simon Fraser.
2955
2956         Add in a check when UIScriptController is deleted to make sure that the HID event
2957         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
2958         the program to crash without any good information. Crashes are race-y, and will still
2959         happen with malformed test, but the information will be much more helpful. 
2960
2961         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2962         (WTR::UIScriptController::checkForClean):
2963         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2964         (UIScriptContext::~UIScriptContext):
2965         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2966         (WTR::UIScriptController::checkForClean):
2967         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2968         * WebKitTestRunner/ios/HIDEventGenerator.h:
2969         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2970         (-[HIDEventGenerator checkHIDCallbacksClear]):
2971         * WebKitTestRunner/ios/TestControllerIOS.mm:
2972         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2973         (WTR::UIScriptController::checkForClean):
2974
2975 2016-12-20  Andy Estes  <aestes@apple.com>
2976
2977         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
2978         https://bugs.webkit.org/show_bug.cgi?id=165992
2979
2980         Reviewed by Brady Eidson.
2981
2982         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2983         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
2984         (expectException):
2985         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2986         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2987         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2988         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2989         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2990         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
2991         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
2992         (TEST):
2993         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
2994
2995 2016-12-20  Dean Jackson  <dino@apple.com>
2996
2997         Remove INDIE_UI
2998         https://bugs.webkit.org/show_bug.cgi?id=165881
2999         <rdar://problem/29672532>
3000
3001         Reviewed by Simon Fraser.
3002
3003         The Indie UI work has been discontinued.
3004
3005         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3006
3007 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3008
3009         [ES6] Enable ES6 Modules
3010         https://bugs.webkit.org/show_bug.cgi?id=165849
3011
3012         Reviewed by Geoffrey Garen.
3013
3014         * DumpRenderTree/mac/DumpRenderTree.mm:
3015         (resetWebPreferencesToConsistentValues):
3016         * DumpRenderTree/win/DumpRenderTree.cpp:
3017         (resetWebPreferencesToConsistentValues):
3018         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3019         (WTR::InjectedBundle::beginTesting):
3020         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3021         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3022         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3023
3024 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3025
3026         Repurpose bots and clean up dashboard.
3027         https://bugs.webkit.org/show_bug.cgi?id=166045
3028
3029         Reviewed by Lucas Forschler.
3030
3031         * BuildSlaveSupport/build.webkit.org-config/config.json:
3032         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3033         (BubbleQueueServer):
3034         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3036         (WebKitBuildbot):
3037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3038         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3039
3040 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3041
3042         [CMake] TestWebKitAPIBase links to itself
3043         https://bugs.webkit.org/show_bug.cgi?id=165985
3044
3045         Reviewed by Alex Christensen.
3046
3047         Fix CMake warning about a target linking to itself, which makes no sense.
3048
3049         * TestWebKitAPI/CMakeLists.txt:
3050
3051 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3052
3053         [GTK] GtkDoc build should be quieter
3054         https://bugs.webkit.org/show_bug.cgi?id=165994
3055
3056         Reviewed by Carlos Garcia Campos.
3057
3058         Make it not print by default.
3059
3060         * gtk/generate-gtkdoc:
3061         (get_generator_for_config):
3062         (generate_doc):
3063         * gtk/gtkdoc.py:
3064         (GTKDoc._run_command):
3065         (GTKDoc._copy_doc_files_to_output_dir):
3066
3067 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3068
3069         Expose a way for MiniBrowser to simulate header and footer banners
3070         https://bugs.webkit.org/show_bug.cgi?id=166005
3071
3072         Reviewed by Wenson Hsieh.
3073         
3074         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3075         banners. This only works in WebKit2.
3076         
3077         We need to reset these on each navigation, since newly created FrameViews
3078         don't re-fetch the header and footer height stored on Page.
3079         
3080         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3081         as well as fixing webViewWebContentProcessDidTerminate:
3082
3083         * MiniBrowser/mac/SettingsController.h:
3084         * MiniBrowser/mac/SettingsController.m:
3085         (-[SettingsController _populateMenu]):
3086         (-[SettingsController validateMenuItem:]):
3087         (-[SettingsController toggleReserveSpaceForBanners:]):
3088         (-[SettingsController isSpaceReservedForBanners]):
3089         * MiniBrowser/mac/WK2BrowserWindowController.m:
3090         (-[WK2BrowserWindowController didChangeSettings]):
3091         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3092         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3093         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3094         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3095
3096 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3097
3098         Fix iOS test results after r209967.
3099         
3100         Subtracting out the status bar height was erroneously happening for all tests,
3101         not just for flexible viewport tests.
3102         
3103         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3104
3105         * WebKitTestRunner/PlatformWebView.h:
3106         * WebKitTestRunner/TestController.cpp:
3107         (WTR::TestController::resetStateToConsistentValues):
3108         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3109         (WTR::PlatformWebView::resizeTo):
3110         (WTR::PlatformWebView::setWindowFrame):
3111         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3112         (WTR::PlatformWebView::resizeTo):
3113         (WTR::PlatformWebView::setWindowFrame):
3114         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3115         (WTR::PlatformWebView::resizeTo):
3116         (WTR::PlatformWebView::setWindowFrame):
3117         * WebKitTestRunner/ios/TestControllerIOS.mm:
3118         (WTR::TestController::platformConfigureViewForTest):
3119         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3120         (WTR::PlatformWebView::resizeTo):
3121         (WTR::PlatformWebView::setWindowFrame):
3122
3123 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3124
3125         [EFL] bump EFL version to 1.18.4
3126         https://bugs.webkit.org/show_bug.cgi?id=166004
3127
3128         Reviewed by Gyuyoung Kim.
3129
3130         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3131
3132 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3133
3134         Visual viewports: bottom fixed elements disappear behind the keyboard
3135         https://bugs.webkit.org/show_bug.cgi?id=165983
3136         <rdar://problem/29409852>
3137
3138         Reviewed by Simon Fraser.
3139
3140         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3141         the keyboard when it is up.
3142
3143         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3144         (WTR::UIScriptController::inputViewBounds):
3145         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3146         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3147         (WTR::UIScriptController::inputViewBounds):
3148         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3149         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3150         (WTR::viewRectForWindowRect):
3151
3152         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3153         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3154         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3155
3156         (WTR::PlatformWebView::PlatformWebView):
3157         (WTR::PlatformWebView::setWindowFrame):
3158         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3159         (WTR::UIScriptController::inputViewBounds):
3160
3161 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3162
3163         Deleting a character converted from pinyin after an image causes a Safari crash
3164         https://bugs.webkit.org/show_bug.cgi?id=165839
3165         <rdar://problem/27951933>
3166
3167         Reviewed by Wenson Hsieh.
3168
3169         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
3170         while the proposed range contains an image. This should not cause a WebProcess to crash
3171         or send an invalid message to the UIProcess.
3172
3173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3174         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
3175         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
3176         (TestWebKitAPI::didFinishLoadForFrame):
3177         (TestWebKitAPI::processDidCrash):
3178         (TestWebKitAPI::invalidMessageFunction):
3179         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
3180
3181 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3182
3183         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3184         https://bugs.webkit.org/show_bug.cgi?id=165767
3185         <rdar://problem/29602382>
3186
3187         Reviewed by Simon Fraser.
3188
3189         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3190         WebKit2 ChangeLog for more details.
3191
3192         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3193         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3194         (WTR::UIScriptController::textSelectionCaretRect):
3195         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3196         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3197         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3198         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3199         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3200         (WTR::UIScriptController::textSelectionCaretRect):
3201         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3202         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3203         (-[TestRunnerWKWebView _setStableStateOverride:]):
3204
3205         Force the WKWebView to update its visible content rects when changing the stable state override.
3206
3207         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3208         (WTR::toNSDictionary):
3209         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3210         (WTR::UIScriptController::selectionRangeViewRects):
3211         (WTR::UIScriptController::textSelectionCaretRect):
3212         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3213         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3214
3215 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3216
3217         Arguments called in wrong order
3218         https://bugs.webkit.org/show_bug.cgi?id=165923
3219
3220         Reviewed by Simon Fraser.
3221
3222         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3223         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3224
3225         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3226         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3227         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3228
3229 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3230
3231         [EFL] Disable non-srcdir builds for failing libraries
3232         https://bugs.webkit.org/show_bug.cgi?id=165896
3233
3234         Reviewed by Gyuyoung Kim.
3235
3236         * efl/jhbuild.modules: Set non srcdir builds to no
3237
3238 2016-12-15  Daniel Bates  <dabates@apple.com>
3239
3240         check-style should not complain about code in icu directories
3241         https://bugs.webkit.org/show_bug.cgi?id=53929
3242
3243         Reviewed by Darin Adler.
3244
3245         Skip style checking of imported ICU headers to avoid a deluge of style issues
3246         as they do not conform to the WebKit Code Style guideline. We want to preserve
3247         the formatting of these headers so as to make it straightforward to merge
3248         changes to them, if necessary.
3249
3250         * Scripts/webkitpy/style/checker.py:
3251
3252 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3253
3254         Move JSC testers from Yosemite to Sierra
3255         https://bugs.webkit.org/show_bug.cgi?id=165925
3256
3257         Reviewed by Lucas Forschler.
3258
3259         * BuildSlaveSupport/build.webkit.org-config/config.json:
3260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3261         (WebKitBuildbot):
3262
3263 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3264
3265         Add coordinate space to event streams and streamline tests
3266         https://bugs.webkit.org/show_bug.cgi?id=165119
3267
3268         Reviewed by Simon Fraser.
3269
3270         Update event streams to allow for both content and global coordinate space.
3271         Update example script to more accurately show all the available options.
3272
3273         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3274         * WebKitTestRunner/ios/HIDEventGenerator.h:
3275         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3276         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3277         (WTR::convertCoordinates):
3278         (WTR::UIScriptController::sendEventStream):
3279
3280 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
3281
3282         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
3283         https://bugs.webkit.org/show_bug.cgi?id=165855
3284
3285         Reviewed by Philippe Normand.
3286
3287         GStreamer's autogen.sh enables gtk-doc always so we end up building
3288         docs even if we disable them. Use the configure script instead, since
3289         we build from packages and these include it already.
3290
3291         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
3292         upstream gstreamer packages.
3293
3294 2016-12-15  Alex Christensen  <achristensen@webkit.org>
3295
3296         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
3297         https://bugs.webkit.org/show_bug.cgi?id=165885
3298         <rdar://problem/29476917>
3299
3300         Reviewed by Darin Adler.
3301
3302         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3303         (TestWebKitAPI::utf16String): Deleted.
3304         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3305         (TestWebKitAPI::TEST_F):
3306         * TestWebKitAPI/WTFStringUtilities.h:
3307         (utf16String):
3308         Moved from URLParser to share with other tests.
3309
3310 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3311
3312         iOS: An element with tabindex is not focusable unless there is no mouse event handler
3313         https://bugs.webkit.org/show_bug.cgi?id=165843
3314
3315         Reviewed by Antti Koivisto.
3316
3317         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
3318         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
3319         and DumpRenderTree's runUIScript would hit an assertion :(
3320
3321         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3322         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3323         (WTR::TestRunner::isWebKit2):
3324
3325 2016-12-14  Brady Eidson  <beidson@apple.com>
3326
3327         IndexedDB 2.0: Massively speedup IDBIndex.get().
3328         https://bugs.webkit.org/show_bug.cgi?id=165802
3329
3330         Reviewed by Alex Christensen.
3331
3332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3333         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
3334         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
3335         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
3336         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
3337
3338 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3339
3340         [GTK][EFL] Update the JHBuild version.
3341         https://bugs.webkit.org/show_bug.cgi?id=165838
3342
3343         Reviewed by Michael Catanzaro.
3344
3345         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
3346         usage of the JHBUILD_MIRROR feature with git repositories.
3347
3348 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3349
3350         [GTK] Yasm is needed for building the JHBuild after r208940
3351         https://bugs.webkit.org/show_bug.cgi?id=165837
3352
3353         Reviewed by Alejandro G. Castro.
3354
3355         * gtk/install-dependencies: Yasm is needed for building libvpx.
3356
3357 2016-12-14  Youenn Fablet  <youenn@apple.com>
3358
3359         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
3360         https://bugs.webkit.org/show_bug.cgi?id=161310
3361
3362         Reviewed by Ryosuke Niwa.
3363
3364         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
3365         When set, WTR and DRT output JS console log in the stderr and not the test output.
3366         This allows removing potentially flaky information while still being able to read it for investigation.
3367
3368         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
3369
3370         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
3371         This test should have this option when fetch API will start logging resource loader errors.
3372
3373         * DumpRenderTree/DumpRenderTree.h:
3374         (TestCommand::TestCommand): Deleted.
3375         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3376         (parseInputLine):
3377         * DumpRenderTree/TestRunner.h:
3378         (TestRunner::setDumpJSConsoleLogInStdErr):
3379         (TestRunner::dumpJSConsoleLogInStdErr):
3380         * DumpRenderTree/mac/DumpRenderTree.mm:
3381         (runTest):
3382         * DumpRenderTree/mac/UIDelegate.mm:
3383         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3384         * DumpRenderTree/win/DumpRenderTree.cpp:
3385         (runTest):
3386         * DumpRenderTree/win/UIDelegate.cpp:
3387         (UIDelegate::webViewAddMessageToConsole):
3388         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3389         (TestExpectationParser._tokenize_line):
3390         * Scripts/webkitpy/port/driver.py:
3391         (Driver._command_from_driver_input):
3392         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3393         (WTR::InjectedBundle::didReceiveMessageToPage):
3394         (WTR::InjectedBundle::dumpToStdErr):
3395         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3396         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
3397         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3398         (WTR::InjectedBundlePage::willAddMessageToConsole):
3399         * WebKitTestRunner/TestController.cpp:
3400         (WTR::parseInputLine):
3401         (WTR::TestController::runTest):
3402         (WTR::TestCommand::TestCommand): Deleted.
3403         * WebKitTestRunner/TestInvocation.cpp:
3404         (WTR::TestInvocation::invoke):
3405         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3406         * WebKitTestRunner/TestInvocation.h:
3407         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
3408
3409
3410 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
3411
3412         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
3413         https://bugs.webkit.org/show_bug.cgi?id=164022
3414
3415         Reviewed by Xabier Rodriguez-Calvar.
3416
3417         * Scripts/webkitperl/FeatureList.pm:
3418           Re-enable MEDIA_SOURCE for the GTK+ port.
3419
3420 2016-12-13  Alex Christensen  <achristensen@webkit.org>
3421
3422         Fix CMake build.
3423
3424         * DumpRenderTree/PlatformMac.cmake:
3425         Define NS_RETURNS_RETAINED as nothing for now.
3426
3427 2016-12-13  Jer Noble  <jer.noble@apple.com>
3428
3429         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
3430         https://bugs.webkit.org/show_bug.cgi?id=165697
3431
3432         Reviewed by Tim Horton.
3433
3434         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3435         (TestWebKitAPI::TEST):
3436
3437 2016-12-13  Andy Estes  <aestes@apple.com>
3438
3439         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
3440         https://bugs.webkit.org/show_bug.cgi?id=165785
3441         <rdar://problem/26929398>
3442
3443         Reviewed by Darin Adler.
3444
3445         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3446         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
3447         expectations for the text, range, and action.
3448         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
3449         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
3450         plain-text string to the pasteboard, executed a paste action, and verified that the selected
3451         text in the web view did not change.
3452         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
3453         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
3454         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
3455         parameter.
3456         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
3457         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
3458         and returned the value of _editingDelegateShouldInsertText.
3459         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
3460         -shouldInsertText:replacingRange:givenAction:.
3461
3462 2016-12-13  Chris Dumez  <cdumez@apple.com>
3463
3464         Unreviewed, rolling out r209544.
3465
3466         Looks like r209489 did not cause the performance regression
3467         after all
3468
3469         Reverted changeset:
3470
3471         "Unreviewed, rolling out r209489."
3472         https://bugs.webkit.org/show_bug.cgi?id=165550
3473         http://trac.webkit.org/changeset/209544
3474
3475 2016-12-12  Sam Weinig  <sam@webkit.org>
3476
3477         [WebIDL] Remove use of Dictionary in ApplePaySession
3478         https://bugs.webkit.org/show_bug.cgi?id=165787
3479
3480         Reviewed by Anders Carlsson.
3481
3482         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3483         (WTR::initializeWebViewConfiguration):
3484         (WTR::TestController::platformCreateWebView):
3485         Enable ApplePay for the tests (where supported).
3486
3487 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
3488
3489         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3490         https://bugs.webkit.org/show_bug.cgi?id=165251
3491
3492         Reviewed by Youenn Fablet.
3493
3494         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
3495         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
3496         the preferences have been set.
3497
3498 2016-12-08  Antti Koivisto  <antti@apple.com>
3499
3500         Enable network cache speculative revalidation in MiniBrowser
3501         https://bugs.webkit.org/show_bug.cgi?id=165616
3502
3503         Reviewed by Darin Adler.
3504
3505         Match Safari. Also add a menu item to disable it.
3506
3507         * MiniBrowser/mac/AppDelegate.m:
3508         (defaultConfiguration):
3509         * MiniBrowser/mac/SettingsController.h:
3510         * MiniBrowser/mac/SettingsController.m:
3511         (-[SettingsController _populateMenu]):
3512         (-[SettingsController validateMenuItem:]):
3513         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
3514         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
3515
3516 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
3517
3518         ChangeLogs become readonly after resolving a conflict
3519         https://bugs.webkit.org/show_bug.cgi?id=165440
3520         rdar://problem/29491002
3521
3522         Reviewed by Darin Adler.
3523
3524         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
3525         moving the file.
3526
3527 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
3528
3529         Re-enable collectContinuously since it doesn't crash anymore
3530
3531         Rubber stamped by Michael Saboff.
3532
3533         * Scripts/run-jsc-stress-tests:
3534
3535 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
3536
3537         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
3538         https://bugs.webkit.org/show_bug.cgi?id=165686
3539
3540         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
3541         so that right config.h comes first in include path.
3542
3543 2016-12-11  Dave Hyatt  <hyatt@apple.com>
3544
3545         [CSS Parser] Make sure content extensions initialize AtomicString
3546         https://bugs.webkit.org/show_bug.cgi?id=165737
3547
3548         Reviewed by Darin Adler.
3549
3550         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3551         (TestWebKitAPI::makeBackend):
3552
3553 2016-12-08  Dave Hyatt  <hyatt@apple.com>
3554
3555         [CSS Parser] Remove the old CSS Parser
3556         https://bugs.webkit.org/show_bug.cgi?id=165645
3557
3558         Reviewed by Daniel Bates.
3559
3560         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
3561         (TestWebKitAPI::TEST):
3562
3563 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
3564
3565         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
3566         https://bugs.webkit.org/show_bug.cgi?id=165686
3567
3568         Reviewed by Michael Catanzaro.
3569
3570         This change reduces duplication of include path lists between modules,
3571         and reduces future need for fixes like r209605 (broken build because of
3572         WebCore header suddenly becoming used in WebKit2).
3573
3574         * DumpRenderTree/CMakeLists.txt:
3575         * DumpRenderTree/PlatformMac.cmake:
3576         * ImageDiff/CMakeLists.txt:
3577         * MiniBrowser/gtk/CMakeLists.txt:
3578         * MiniBrowser/mac/CMakeLists.txt:
3579         * MiniBrowser/win/CMakeLists.txt:
3580         * TestWebKitAPI/CMakeLists.txt:
3581         * TestWebKitAPI/PlatformEfl.cmake:
3582         * TestWebKitAPI/PlatformJSCOnly.cmake:
3583         * TestWebKitAPI/PlatformMac.cmake:
3584         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3585         * WebKitTestRunner/CMakeLists.txt:
3586         * WebKitTestRunner/PlatformGTK.cmake:
3587         * WebKitTestRunner/PlatformMac.cmake:
3588
3589 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
3590
3591         Unreviewed buildfix after r209630.
3592
3593         * Scripts/build-jsc: Remove building the non-existing testWASM.
3594
3595 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
3596
3597         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3598         https://bugs.webkit.org/show_bug.cgi?id=165251
3599
3600         Reviewed by Dean Jackson.
3601
3602         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
3603
3604         * DumpRenderTree/mac/DumpRenderTree.mm:
3605         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
3606
3607         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3608         (WTR::InjectedBundle::beginTesting): Ditto.
3609
3610         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3611         (WTR::TestRunner::setMediaStreamEnabled): New.
3612         (WTR::TestRunner::setPeerConnectionEnabled): New.
3613         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3614
3615 2016-12-09  Brady Eidson  <beidson@apple.com> 
3616  
3617         Re-landing:
3618         Add _WKIconLoadingDelegate SPI. 
3619         https://bugs.webkit.org/show_bug.cgi?id=164894 
3620  
3621         Reviewed by Alex Christensen. 
3622         
3623         Add MiniBrowser support for this new SPI, configurable with a setting. 
3624  
3625         * MiniBrowser/mac/SettingsController.h: 
3626         * MiniBrowser/mac/SettingsController.m: 
3627         (-[SettingsController _populateMenu]): 
3628         (-[SettingsController validateMenuItem:]): 
3629         (-[SettingsController loadsAllSiteIcons]): 
3630         (-[SettingsController toggleLoadsAllSiteIcons:]): 
3631         * MiniBrowser/mac/WK2BrowserWindowController.m: 
3632         (-[WK2BrowserWindowController awakeFromNib]): 
3633         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
3634
3635 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3636
3637         Fix the 32-bit build.
3638
3639         Unreviewed build fix.
3640
3641         * MiniBrowser/mac/SettingsController.h:
3642
3643 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3644
3645         Fedora also needs a PHP7 config file alternative
3646         https://bugs.webkit.org/show_bug.cgi?id=165606
3647
3648         Reviewed by Michael Catanzaro.
3649
3650         * Scripts/webkitpy/port/base.py:
3651         (Port._is_fedora_php_version_7): check for the php7 library.
3652         (Port._fedora_php_version): get the appropriate filename for Fedora.
3653         (Port._apache_config_file_name_for_platform):
3654
3655 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3656
3657         Complete the revert of r208865.
3658         https://bugs.webkit.org/show_bug.cgi?id=164894
3659
3660         Unreviewed build fix.
3661
3662         * MiniBrowser/mac/SettingsController.h:
3663         * MiniBrowser/mac/SettingsController.m:
3664         (-[SettingsController _populateMenu]):
3665         (-[SettingsController validateMenuItem:]):
3666         (-[SettingsController loadsAllSiteIcons]): Deleted.
3667         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
3668         * MiniBrowser/mac/WK2BrowserWindowController.m:
3669         (-[WK2BrowserWindowController awakeFromNib]):
3670         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
3671
3672 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3673
3674         [GTK] Force GDK backend to x11 when running with XvfbDriver
3675         https://bugs.webkit.org/show_bug.cgi?id=165612
3676
3677         Reviewed by Michael Catanzaro.
3678
3679         When the developer is running a Wayland session, GDK may get confused
3680         and try to use its Wayland backend (which is higher priority) instead.
3681         This ensures it will use the appropriate backend when running under
3682         Xvfb.
3683
3684         * Scripts/webkitpy/port/gtk.py:
3685         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
3686         force GDK_BACKEND to x11.
3687
3688 2016-12-08  Keith Miller  <keith_miller@apple.com>
3689
3690         Add 64-bit signed LEB decode method
3691         https://bugs.webkit.org/show_bug.cgi?id=165630
3692
3693         Reviewed by Ryosuke Niwa.
3694
3695         Add tests for LEB int64 and uint64 decode since I guess
3696         I forgot to add tests before.
3697
3698         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
3699         (TestWebKitAPI::testUInt32LEBDecode):
3700         (TestWebKitAPI::TEST):
3701         (TestWebKitAPI::testUInt64LEBDecode):
3702         (TestWebKitAPI::testInt32LEBDecode):
3703         (TestWebKitAPI::testInt64LEBDecode):
3704         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
3705
3706 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3707
3708         Make it easy to enable --force-collectContinuously
3709         https://bugs.webkit.org/show_bug.cgi?id=165638
3710
3711         Reviewed by Keith Miller.
3712
3713         * Scripts/run-javascriptcore-tests:
3714         (runJSCStressTests):
3715
3716 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3717
3718         Disable the collectContinuously mode until I investigate failures.
3719
3720         Rubber stamped by Keith Miller.
3721         
3722         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
3723         while I investigate.
3724
3725         * Scripts/run-jsc-stress-tests:
3726
3727 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3728
3729         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
3730         https://bugs.webkit.org/show_bug.cgi?id=165621
3731
3732         Reviewed by Dan Bernstein.
3733
3734         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3735         (TestWebKitAPI::TEST_F):
3736
3737 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
3738
3739         Concurrent GC should be stable enough to land enabled
3740         https://bugs.webkit.org/show_bug.cgi?id=164990
3741
3742         Reviewed by Geoffrey Garen.
3743         
3744         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
3745         
3746         It's clear that this works just fine in release, but I'm still trying to figure out if it's
3747         safe for debug. It might be too slow for debug.
3748
3749         * Scripts/run-jsc-stress-tests:
3750
3751 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3752
3753         Add SPI for sending WebsiteSettings to WebProcess during navigation
3754         https://bugs.webkit.org/show_bug.cgi?id=165517
3755         <rdar://29341068>
3756
3757         Reviewed by Anders Carlsson.
3758
3759         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3760         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
3761         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
3762         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3763         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3764         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3765         (TEST):
3766
3767 2016-12-08  Chris Dumez  <cdumez@apple.com>
3768
3769         Unreviewed, rolling out r209489.
3770
3771         Likely caused large regressions on JetStream, Sunspider and
3772         Speedometer
3773
3774         Reverted changeset:
3775
3776         "Add system trace points for JavaScript VM entry/exit"
3777         https://bugs.webkit.org/show_bug.cgi?id=165550
3778         http://trac.webkit.org/changeset/209489
3779
3780 2016-12-08  Keith Miller  <keith_miller@apple.com>
3781
3782         Move LEB tests to API tests
3783         https://bugs.webkit.org/show_bug.cgi?id=165586
3784
3785         Reviewed by Saam Barati.
3786
3787         Move the tests from testWasm.cpp and make them functions
3788         rather than macros.
3789
3790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3791         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
3792         (TestWebKitAPI::testUnsignedLEBDecode):
3793         (TestWebKitAPI::TEST):
3794         (TestWebKitAPI::testInt32LEBDecode):
3795
3796 2016-12-08  Chris Dumez  <cdumez@apple.com>
3797
3798         Support running the layout tests offline
3799         https://bugs.webkit.org/show_bug.cgi?id=165534
3800
3801         Reviewed by Ryosuke Niwa.
3802
3803         * Scripts/webkitpy/common/system/autoinstall.py:
3804         (AutoInstaller._download_to_stream):
3805         getcode() returns None for file URLs so handle this.
3806
3807         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3808         (WebPlatformTestServer._install_modules):
3809         Deal with local path in the json file and resolve them into file URLs
3810         before using AutoInstall.
3811
3812 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3813
3814         Fix CMake build.
3815
3816         * DumpRenderTree/PlatformMac.cmake:
3817         Remove CheckedMalloc.cpp after r209516.
3818
3819 2016-12-07  Mark Lam  <mark.lam@apple.com>
3820
3821         DumpRenderTree should stop using CheckedMalloc.
3822         https://bugs.webkit.org/show_bug.cgi?id=165563
3823         <rdar://problem/28945820>
3824
3825         Reviewed by Geoffrey Garen.
3826
3827         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
3828            in CheckedMalloc.
3829         2. bmalloc does not honor the settings of CheckedMalloc.
3830
3831         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
3832         malloc.  As a result, DRT exhibits different behavior from the normal way we run
3833         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
3834         with WKTR.
3835
3836         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3837         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
3838         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
3839         * DumpRenderTree/mac/DumpRenderTree.mm:
3840         (prepareConsistentTestingEnvironment):
3841
3842 2016-12-07  Dean Jackson  <dino@apple.com>
3843
3844         Remove runtime toggle for pointer-lock
3845         https://bugs.webkit.org/show_bug.cgi?id=165577
3846         <rdar://problems/29566996>
3847
3848         Reviewed by Jon Lee.
3849
3850         Remove any runtime calls to check if pointer-lock is enabled. It's
3851         either compiled in or out.
3852
3853         * DumpRenderTree/mac/DumpRenderTree.mm:
3854         (resetWebPreferencesToConsistentValues):
3855         * WebKitTestRunner/TestController.cpp:
3856         (WTR::TestController::resetPreferencesToConsistentValues):
3857
3858 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
3859
3860         [MediaStream][Mac] Revoke sandbox extensions when capture ends
3861         https://bugs.webkit.org/show_bug.cgi?id=165476
3862
3863         Reviewed by Brady Eidson.
3864         
3865         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
3866         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
3867         is reset and recreated when a web page exits and is reloaded.
3868
3869         * TestWebKitAPI/PlatformGTK.cmake:
3870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3871         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
3872         (TestWebKitAPI::checkUserMediaPermissionCallback):
3873         (TestWebKitAPI::TEST):
3874         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
3875
3876 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
3877
3878         One esc to exit fullscreen and pointer lock
3879         https://bugs.webkit.org/show_bug.cgi?id=165416
3880         rdar://problem/29430711
3881
3882         Reviewed by Jer Noble.
3883
3884         Implement WKPageUIClientV8 for pointer lock support.
3885         Add "escape" key support in EventSenderProxy.
3886
3887         * WebKitTestRunner/TestController.cpp:
3888         (WTR::requestPointerLock):
3889         (WTR::TestController::createOtherPage):
3890         (WTR::TestController::createWebViewWithOptions):
3891         * WebKitTestRunner/mac/EventSenderProxy.mm:
3892         (WTR::EventSenderProxy::keyDown):
3893
3894 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3895
3896         Add system trace points for JavaScript VM entry/exit
3897         https://bugs.webkit.org/show_bug.cgi?id=165550
3898
3899         Reviewed by Tim Horton.
3900
3901         Add trace points for entry/exit into/out of the JS VM.
3902
3903         * Tracing/SystemTracePoints.plist:
3904
3905 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
3906
3907         [GTK] Cannot build GTK+ with CUPS 2.* versions
3908         https://bugs.webkit.org/show_bug.cgi?id=163591
3909
3910         Reviewed by Michael Catanzaro.
3911
3912         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
3913         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
3914         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
3915         old gtk+ since it requires not only bumping up glib accordingly and its consequence
3916         causes many printing test failures. So, I propose to fix the configuration issue by
3917         applying the change to the configure file directly. By doing this, we don't need to
3918         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
3919
3920         * gtk/jhbuild.modules:
3921         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
3922
3923 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3924
3925         Fix use of enum in a WK2 C SPI header.
3926         rdar://problem/28725583
3927
3928         Followup to correctly prefix the enum values.
3929
3930         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3931         (WTR::InjectedBundlePage::prepare):
3932
3933 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3934
3935         Fix use of enum in a WK2 C SPI header.
3936         rdar://problem/28725583
3937
3938         Reviewed by Dan Bernstein.
3939
3940         Use correct enum style for a C SPI header and fix the callers.
3941
3942         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3943         (WTR::InjectedBundlePage::prepare):
3944
3945 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3946
3947         Add a new project for recording and playing back editing commands in editable web content
3948         https://bugs.webkit.org/show_bug.cgi?id=165114
3949         <rdar://problem/29408135>
3950
3951         Reviewed by Beth Dakin.
3952
3953         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
3954         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
3955         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
3956         then be dragged into the playback test harness.
3957
3958         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
3959         steps:
3960
3961         1. Load the capture harness and perform test-specific editing on the web view.
3962         2. Let originalState be a dump of the DOM at this point in time.
3963         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
3964         4. Rewind all editing to the beginning.
3965         5. Playback all editing to the end.
3966         6. Dump the state of the DOM. This should be identical to originalState.
3967
3968         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
3969         * EditingHistory/EditingHistory/Info.plist: Added.
3970         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
3971         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
3972         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
3973         * EditingHistory/EditingHistory/TestRunner.h: Added.
3974         * EditingHistory/EditingHistory/TestRunner.m: Added.
3975         (injectedMessageEventHandlerScript):
3976         (-[TestRunner init]):
3977         (-[TestRunner deleteBackwards:]):
3978         (-[TestRunner typeString:]):
3979         (-[TestRunner bodyElementSubtree]):
3980         (-[TestRunner bodyTextContent]):
3981         (-[TestRunner editingHistoryJSON]):
3982         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
3983         (-[TestRunner numberOfUpdates]):
3984         (-[TestRunner jumpToUpdateIndex:]):
3985         (-[TestRunner expectEvents:afterPerforming:]):
3986         (-[TestRunner loadCaptureTestHarness]):
3987         (-[TestRunner setTextObfuscationEnabled:]):
3988         (-[TestRunner isDoneWaitingForPendingEvents]):
3989         (-[TestRunner userContentController:didReceiveScriptMessage:]):
3990
3991         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
3992         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
3993
3994         * EditingHistory/EditingHistory/TestUtil.h: Added.
3995         * EditingHistory/EditingHistory/TestUtil.m: Added.
3996         (waitUntilWithTimeout):
3997         (waitUntil):
3998
3999         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
4000
4001         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
4002         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
4003         (-[WKWebView loadPageFromBundleNamed:]):
4004         (-[WKWebView typeCharacter:]):
4005         (-[WKWebView keyPressWithCharacters:keyCode:]):
4006         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
4007
4008         Provides utilities for simulating interaction in a web view.
4009
4010         * EditingHistory/EditingHistory/main.m: Added.
4011         (main):
4012         * EditingHistory/EditingHistoryTests/Info.plist: Added.
4013         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
4014         (-[RewindAndPlaybackTests setUp]):
4015         (-[RewindAndPlaybackTests tearDown]):
4016         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
4017         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
4018         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
4019         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
4020         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
4021
4022 2016-12-07  Philippe Normand  <pnormand@igalia.com>
4023
4024         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
4025         https://bugs.webkit.org/show_bug.cgi?id=165525
4026
4027         Reviewed by Carlos Garcia Campos.
4028
4029         * gtk/jhbuild.modules: gst-plugins-good should depend on the
4030         libvpx package built within jhbuild.
4031
4032 2016-12-07  Philippe Normand  <pnormand@igalia.com>
4033
4034         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
4035         https://bugs.webkit.org/show_bug.cgi?id=165520
4036
4037         Reviewed by Carlos Garcia Campos.
4038
4039         * gtk/jhbuild.modules: Added missing dependency on openh264 in
4040         gst-plugins-bad, along with 2 upstream patches fixing the build
4041         against OpenSSL 1.1.0.
4042         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
4043         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
4044
4045 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
4046
4047         Correct SDKROOT values in xcconfig files
4048         https://bugs.webkit.org/show_bug.cgi?id=165487
4049         rdar://problem/29539209
4050
4051         Reviewed by Dan Bernstein.
4052
4053         Fix suggested by Dan Bernstein.
4054
4055         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
4056         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4057         * MiniBrowser/Configurations/DebugRelease.xcconfig:
4058         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
4059         * WebEditingTester/Configurations/DebugRelease.xcconfig:
4060         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4061
4062 2016-12-06  Daniel Bates  <dabates@apple.com>
4063
4064         WebKitTestRunner: Plugins are disabled in new windows
4065         https://bugs.webkit.org/show_bug.cgi?id=165410
4066
4067         Reviewed by Alex Christensen.
4068
4069         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
4070         a new window and loads a plugin will fail. We should enable plugins in all windows by
4071         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
4072
4073         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
4074         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
4075         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
4076
4077         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4078         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
4079         WKBundleSetPluginsEnabled().
4080         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4081         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
4082         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
4083
4084 2016-12-05  Dean Jackson  <dino@apple.com>
4085
4086         pointer lock needs to be feature detectable
4087         https://bugs.webkit.org/show_bug.cgi?id=165426
4088         <rdar://problem/29486715>
4089
4090         Reviewed by Antoine Quint.
4091
4092         Expose the comment line to turn on/off pointer lock.
4093
4094         * DumpRenderTree/TestOptions.h:
4095         * DumpRenderTree/TestOptions.mm:
4096         (TestOptions::TestOptions):
4097         * DumpRenderTree/mac/DumpRenderTree.mm:
4098         (resetWebPreferencesToConsistentValues):
4099         * WebKitTestRunner/TestController.cpp:
4100         (WTR::TestController::resetPreferencesToConsistentValues):
4101         (WTR::updateTestOptionsFromTestHeader):
4102         * WebKitTestRunner/TestOptions.h:
4103         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4104         (WTR::PlatformWebView::viewSupportsOptions):
4105         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4106         (WTR::PlatformWebView::viewSupportsOptions):
4107
4108 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
4109
4110         Make it possible to use an existing simulator instance for one-off testing
4111         https://bugs.webkit.org/show_bug.cgi?id=164568
4112         <rdar://problem/29189133>
4113
4114         Reviewed by Daniel Bates.
4115
4116         With this patch, if a simulator is currently running on the machine and
4117         '--dedicated-simulators' is not passed into the application, only one simulator
4118         instance will be used, and this instance will be the existing instance.
4119         If no simulator is running or '--dedicated-simulators' is passed to the script,
4120         previous behavior will be used.
4121
4122         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4123         (parse_args):
4124         * Scripts/webkitpy/port/ios.py:
4125         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
4126         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
4127         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
4128         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
4129         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
4130         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
4131         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
4132         * Scripts/webkitpy/xcode/simulator.py:
4133         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
4134         (Simulator.current_device): Get currently running device.
4135
4136 2016-12-05  Dan Bernstein  <mitz@apple.com>
4137
4138         Disable a crashing test on iOS.
4139
4140         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4141
4142 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4143
4144         Fix a build break on EFL since r209303.
4145
4146         Unreviewed build fix.
4147
4148         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
4149
4150 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
4151
4152         Refactor SymbolImpl layout
4153         https://bugs.webkit.org/show_bug.cgi?id=165247
4154
4155         Reviewed by Darin Adler.
4156
4157         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4158         (TestWebKitAPI::TEST):
4159
4160 2016-12-03  Dan Bernstein  <mitz@apple.com>
4161
4162         Fixed the build after r209307.
4163
4164         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4165         (TEST):
4166
4167 2016-12-03  Dan Bernstein  <mitz@apple.com>
4168
4169         [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
4170         https://bugs.webkit.org/show_bug.cgi?id=165276
4171         <rdar://problem/29467040>
4172
4173         Reviewed by Darin Adler.
4174
4175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4176         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
4177         (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
4178         (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
4179         (TEST):
4180         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
4181         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4182         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
4183         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
4184         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
4185         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
4186
4187 2016-12-02  Andy Estes  <aestes@apple.com>
4188
4189         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
4190         https://bugs.webkit.org/show_bug.cgi?id=164492
4191
4192         Reviewed by Dan Bernstein.
4193
4194         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
4195         com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
4196         * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
4197         org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
4198         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
4199         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
4200         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
4201         PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
4202         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4203         org.webkit.$(PRODUCT_NAME:rfc1034identifier).
4204         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4205         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4206         * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
4207         com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4208         * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
4209         org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4210         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
4211         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
4212         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4213         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
4214         com.apple.$(PRODUCT_NAME:rfc1034identifier).
4215         * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
4216         com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
4217         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
4218         value ${PRODUCT_BUNDLE_IDENTIFIER}.
4219         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
4220         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
4221         com.apple.WebKitTestRunner.InjectedBundle.
4222         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
4223         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
4224         * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
4225         com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
4226         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
4227         CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
4228         ${PRODUCT_BUNDLE_IDENTIFIER}.
4229
4230 2016-12-02  Brady Eidson  <beidson@apple.com>
4231
4232         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
4233         https://bugs.webkit.org/show_bug.cgi?id=165330
4234
4235         Reviewed by Alex Christensen.
4236
4237         The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
4238
4239         Problem is that doesn't reliably destroy the view.
4240         We should explicitly kill the process instead.
4241
4242         Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
4243         e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
4244
4245         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
4246         (TEST):
4247
4248 2016-12-02  Commit Queue  <commit-queue@webkit.org>
4249
4250         Unreviewed, rolling out r209136.
4251         https://bugs.webkit.org/show_bug.cgi?id=165337
4252
4253         broke 36 webkitpy tests (Requested by mcatanzaro on #webkit).
4254
4255         Reverted changeset:
4256
4257         "Make it possible to use an existing simulator instance for
4258         one-off testing"
4259         https://bugs.webkit.org/show_bug.cgi?id=164568
4260         http://trac.webkit.org/changeset/209136
4261
4262 2016-12-02  Chris Dumez  <cdumez@apple.com>
4263
4264         [Mac][WK1] Implement new HTML interactive form validation user interface
4265         https://bugs.webkit.org/show_bug.cgi?id=164483
4266
4267         Reviewed by Simon Fraser.
4268
4269         Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble")
4270         on Mac DRT as this is needed by the HTML form validation layout tests.
4271
4272         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4273         (WTR::UIScriptController::contentsOfUserInterfaceItem):
4274
4275 2016-12-02  Brady Eidson  <beidson@apple.com>
4276
4277         IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout.
4278         https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001
4279
4280         Reviewed by Alexey Proskuryakov.
4281
4282         These tests had "run-loop races."
4283         
4284         The test spins the runloop waiting for one message.
4285         Two messages might come in from the WebProcess in short succession, and both be delivered to the
4286         UIProcess in the same spin of the runloop.
4287
4288         Therefore by the time the test stops spinning the runloop, notified that a message was received,
4289         the first message has been overwritten by the second.
4290
4291         These tests are fixed by queueing the incoming messages instead of just storing one.
4292
4293         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
4294         (-[IndexedDBMPMessageHandler userContentController:didReceiveScriptMessage:]):
4295         (getNextMessage):
4296         (TEST):
4297
4298</