Infinite UI process hang under ensurePositionInformationIsUpToDate
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-10  Tim Horton  <timothy_horton@apple.com>
2
3         Infinite UI process hang under ensurePositionInformationIsUpToDate
4         https://bugs.webkit.org/show_bug.cgi?id=168154
5         <rdar://problem/30428673>
6
7         Reviewed by Simon Fraser.
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
11         (recursiveFindHighlightLongPressRecognizer):
12         (TEST):
13         Add a somewhat nasty test that does an async interaction information update, but
14         kills the Web process before it arrives, and then does a sync interaction
15         information update, which will wait for the oustanding async interaction
16         information update if we still think it's coming. Before the patch, this
17         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
18
19 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
20
21         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
22         https://bugs.webkit.org/show_bug.cgi?id=168127
23         rdar://problem/30467120
24
25         Reviewed by Tim Horton.
26
27         Reparent the web view before we try to fetch it via:
28             [[[window contentView] subviews] objectAtIndex:0];
29         which would throw an exception if the test unparented it.
30
31         * DumpRenderTree/mac/DumpRenderTree.mm:
32         (resetWebViewToConsistentStateBeforeTesting):
33         (runTest):
34
35 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
36
37         [Resource Timing] Enable Resource Timing by default in Tests
38         https://bugs.webkit.org/show_bug.cgi?id=168145
39
40         Reviewed by Ryosuke Niwa.
41
42         * DumpRenderTree/mac/DumpRenderTree.mm:
43         (resetWebPreferencesToConsistentValues):
44         * DumpRenderTree/win/DumpRenderTree.cpp:
45         (resetWebPreferencesToConsistentValues):
46         * WebKitTestRunner/TestController.cpp:
47         (WTR::TestController::resetPreferencesToConsistentValues):
48
49 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
50
51         Removing LayoutTestRelay
52         https://bugs.webkit.org/show_bug.cgi?id=165927
53
54         Reviewed by Daniel Bates.
55         Part 2
56
57         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
58         simulators through simctl (iOS 10 and later), use this functionality instead.
59
60         * BuildSlaveSupport/built-product-archive:
61         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
62         Added a FIXME that we will need to implement similar archiving machinery once we build
63         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
64         * BuildSlaveSupport/kill-old-processes:
65         (main): Remove LayoutTestRelay from list of processes.
66         * LayoutTestRelay: Removed LayoutTestRelay.
67         * Makefile:
68         * Scripts/build-layouttestrelay: Removed.
69         * Scripts/build-webkit: Removed LayoutTestRelay references.
70
71 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
72
73         [WebCrypto] Add WebCryptoAPI to watchlist
74         https://bugs.webkit.org/show_bug.cgi?id=168138
75
76         Reviewed by Youenn Fablet.
77
78         * Scripts/webkitpy/common/config/watchlist:
79
80 2017-02-10  Brady Eidson  <beidson@apple.com>
81
82         Replace all WebKit Library Version checks in WK2 with SDK version checks.
83         https://bugs.webkit.org/show_bug.cgi?id=168124
84
85         Reviewed by Geoffrey Garen.
86
87         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
88         
89         * MiniBrowser/mac/main.m:
90         (main):
91         * MobileMiniBrowser/MobileMiniBrowser/main.m:
92         (main):
93         * TestWebKitAPI/ios/mainIOS.mm:
94         (main):
95         * TestWebKitAPI/mac/mainMac.mm:
96         (main):
97         * WebKitTestRunner/ios/mainIOS.mm:
98         (main):
99         * WebKitTestRunner/mac/main.mm:
100         (setDefaultsToConsistentValuesForTesting):
101
102 2017-02-10  Alex Christensen  <achristensen@webkit.org>
103
104         Fix El Capitan build.
105
106         * Scripts/build-webkit:
107         Don't build libwebrtc anywhere for now.
108
109 2017-02-10  Andy Estes  <aestes@apple.com>
110
111         Move two MiniBrowserBundle settings out of the .pbxproj
112         https://bugs.webkit.org/show_bug.cgi?id=168106
113
114         Reviewed by Tim Horton.
115
116         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
117         the project file. This removes the project file override.
118
119         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
120
121         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
122         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
123
124 2017-02-10  Alex Christensen  <achristensen@webkit.org>
125
126         Fix 32-and-64-bit build on El Capitan.
127
128         * Scripts/build-webkit:
129         Somebody's building with something like this:
130         build-webkit ARCHS="i386 x86_64"
131         We want this to also not build libwebrtc for now.
132
133 2017-02-10  Alex Christensen  <achristensen@webkit.org>
134
135         Fix 32-bit build on El Capitan.
136
137         * Scripts/build-webkit:
138         The bot uses ARCHS=i386 instead of --32-bit.
139         This is a hack, but it should fix the bot until I can do a better fix in the morning.
140
141 2017-02-10  Alex Christensen  <achristensen@webkit.org>
142
143         Fix 32-bit build on El Capitan.
144
145         * Scripts/build-webkit:
146         Don't build i386 libwebrtc.
147
148 2017-02-09  Alex Christensen  <achristensen@webkit.org>
149
150         Unreviewed, rolling out r212040.
151
152         Broke build.  I'm not surprised
153
154         Reverted changeset:
155
156         "[WebRTC][Mac] Activate libwebrtc"
157         https://bugs.webkit.org/show_bug.cgi?id=167293
158         http://trac.webkit.org/changeset/212040
159
160 2017-02-09  Alex Christensen  <achristensen@webkit.org>
161
162         Build libwebrtc on bots without using it yet
163         https://bugs.webkit.org/show_bug.cgi?id=168062
164
165         Reviewed by Brent Fulgham.
166
167         * Scripts/build-webkit:
168
169 2017-02-09  Alex Christensen  <achristensen@webkit.org>
170
171         Don't build libwebrtc.
172
173         * Scripts/build-webkit:
174         Not ready yet.  It broke El Capitan and iOS.
175
176 2017-02-09  Alex Christensen  <achristensen@webkit.org>
177
178         Build libwebrtc on bots without using it yet
179         https://bugs.webkit.org/show_bug.cgi?id=168062
180
181         Reviewed by Brent Fulgham.
182
183         * Scripts/build-webkit:
184
185 2017-02-09  Alex Christensen  <achristensen@webkit.org>
186
187         Rename isAppleMacWebKit to isAppleCocoaWebKit
188         https://bugs.webkit.org/show_bug.cgi?id=168075
189
190         Reviewed by Geoffrey Garen.
191
192         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
193
194         * Scripts/build-api-tests:
195         * Scripts/build-dumprendertree:
196         * Scripts/build-jsc:
197         (buildMyProject):
198         * Scripts/build-layouttestrelay:
199         * Scripts/build-webkit:
200         * Scripts/build-webkittestrunner:
201         * Scripts/run-api-tests:
202         (isSupportedPlatform):
203         (runTest):
204         (listAllTests):
205         (prepareEnvironmentForRunningTestTool):
206         * Scripts/run-content-extension-tester:
207         * Scripts/run-javascriptcore-tests:
208         * Scripts/run-minibrowser:
209         * Scripts/show-pretty-diff:
210         * Scripts/webkitdirs.pm:
211         (determineBaseProductDir):
212         (determineArchitecture):
213         (determinePassedArchitecture):
214         (safariPath):
215         (builtDylibPathForName):
216         (checkFrameworks):
217         (isAppleWebKit):
218         (isAppleCocoaWebKit):
219         (determineNmPath):
220         (launcherName):
221         (wrapperPrefixIfNeeded):
222         (isCMakeBuild):
223         (mobileSafariBundle):
224         (debugSafari):
225         (runSafari):
226         (runMiniBrowser):
227         (debugMiniBrowser):
228         (runWebKitTestRunner):
229         (debugWebKitTestRunner):
230         (isAppleMacWebKit): Deleted.
231         * Scripts/webkitperl/FeatureList.pm:
232
233 2017-02-09  Alex Christensen  <achristensen@webkit.org>
234
235         Revert r211991
236         https://bugs.webkit.org/show_bug.cgi?id=168062
237
238         * Scripts/build-webkit:
239         Not quite ready yet.
240
241 2017-02-09  Alex Christensen  <achristensen@webkit.org>
242
243         Build libwebrtc on bots without using it yet
244         https://bugs.webkit.org/show_bug.cgi?id=168062
245
246         Reviewed by Brent Fulgham.
247
248         * Scripts/build-webkit:
249         Build libwebrtc on Mac when we build ANGLE.
250
251 2017-02-09  Youenn Fablet  <youenn@apple.com>
252
253         Improve W3C importer command line options
254         https://bugs.webkit.org/show_bug.cgi?id=167448
255
256         Reviewed by Ryosuke Niwa.
257
258         Making the list of test paths to import the main arguments of the script.
259         Allow passing the source directory to import as a -s option.
260         Adding a warning when given test paths are skipped by default in ImportExpectations.
261
262         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
263         Link conversion rules do not change when imported tests are downloaded by the script.
264
265         * Scripts/webkitpy/w3c/test_importer.py:
266         (main):
267         (parse_args):
268         (TestImporter.__init__):
269         (TestImporter.do_import):
270         (TestImporter):
271         (TestImporter.check_imported_expectations):
272
273 2017-02-08  Chris Dumez  <cdumez@apple.com>
274
275         Update web-platform-tests resources
276         https://bugs.webkit.org/show_bug.cgi?id=168026
277
278         Reviewed by Youenn Fablet.
279
280         Stop copying testharness.js from resources/ to web-platform-tests/resources.
281
282         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
283         (WebPlatformTestServer._copy_webkit_test_files):
284
285 2017-02-08  Andy Estes  <aestes@apple.com>
286
287         Custom protocols should not continue loading after a network process crash
288         https://bugs.webkit.org/show_bug.cgi?id=168028
289         <rdar://problem/27607520>
290
291         Reviewed by Brady Eidson.
292
293         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
294         (processGroup):
295         (-[CloseWhileStartingProtocol startLoading]):
296         (-[CloseWhileStartingProtocol stopLoading]):
297         (TestWebKitAPI::runTest):
298         (TestWebKitAPI::TEST):
299
300 2017-02-08  Dan Bernstein  <mitz@apple.com>
301
302         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
303         https://bugs.webkit.org/show_bug.cgi?id=168031
304
305         Reviewed by Tim Horton.
306
307         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
308         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
309         (TEST):
310         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
311         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
312
313 2017-02-08  Chris Dumez  <cdumez@apple.com>
314
315         Use smaller tiles in windows that are not active to facilitate App Napping
316         https://bugs.webkit.org/show_bug.cgi?id=167997
317         <rdar://problem/30358835>
318
319         Reviewed by Simon Fraser.
320
321         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
322         (WTR::PlatformWebView::setWindowIsKey):
323         Actually update windowIsKey state of NSWindow so the WebView
324         properly updates its activity state.
325
326 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
327
328         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
329         https://bugs.webkit.org/show_bug.cgi?id=167942
330         <rdar://problem/30315079>
331
332         Reviewed by Tim Horton.
333
334         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
335         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
336         contenteditable in these cases.
337
338         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
339         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
340         performDragOperation:) directly.
341
342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
343         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
344         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
345         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
346         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
347         (-[DragSource draggingSourceOperationMaskForLocal:]):
348         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
349         (-[DragInfo lastMousePosition]):
350         (-[DragInfo setLastMousePosition:]):
351         (-[DragInfo draggingDestinationWindow]):
352         (-[DragInfo draggingSourceOperationMask]):
353         (-[DragInfo draggingLocation]):
354         (-[DragInfo draggedImageLocation]):
355         (-[DragInfo draggedImage]):
356         (-[DragInfo draggingPasteboard]):
357         (-[DragInfo draggingSource]):
358         (-[DragInfo draggingSequenceNumber]):
359         (-[DragInfo slideDraggedImageTo:]):
360         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
361         (-[DragInfo draggingFormation]):
362         (-[DragInfo setDraggingFormation:]):
363         (-[DragInfo animatesToDestination]):
364         (-[DragInfo setAnimatesToDestination:]):
365         (-[DragInfo numberOfValidItemsForDrop]):
366         (-[DragInfo setNumberOfValidItemsForDrop:]):
367         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
368         (-[DragInfo springLoadingHighlight]):
369         (-[DragInfo resetSpringLoading]):
370         (TestWebKitAPI::getTestImage):
371         (TestWebKitAPI::webViewAfterPerformingDragOperation):
372         (TestWebKitAPI::TEST):
373         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
374
375 2017-02-08  Jer Noble  <jer.noble@apple.com>
376
377         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
378         https://bugs.webkit.org/show_bug.cgi?id=168007
379
380         Reviewed by Alex Christensen.
381
382         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
383         (didFinishLoadForFrame):
384         (TestWebKitAPI::TEST):
385
386 2017-02-08  Commit Queue  <commit-queue@webkit.org>
387
388         Unreviewed, rolling out r211873.
389         https://bugs.webkit.org/show_bug.cgi?id=168001
390
391         It's in jhbuild for consistent layout tests (Requested by
392         mcatanzaro on #webkit).
393
394         Reverted changeset:
395
396         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
397         https://bugs.webkit.org/show_bug.cgi?id=167993
398         http://trac.webkit.org/changeset/211873
399
400 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
401
402         [GTK] Add icu packages to Tools/gtk/install-dependencies
403         https://bugs.webkit.org/show_bug.cgi?id=167993
404
405         Reviewed by Michael Catanzaro.
406
407         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
408         depending in the GNU/Linux distribution)
409
410 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
411
412         Update flakiness dashboard configuration.
413         https://bugs.webkit.org/show_bug.cgi?id=167957
414
415         Reviewed by Alexey Proskuryakov.
416
417         * TestResultServer/static-dashboards/builders.jsonp:
418
419 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
420
421         Replace a bot that has an incorrect configuration.
422         https://bugs.webkit.org/show_bug.cgi?id=167747
423
424         Rubber-stamped by Alexey Proskuryakov.
425
426         * BuildSlaveSupport/build.webkit.org-config/config.json:
427
428 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
429
430         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
431         https://bugs.webkit.org/show_bug.cgi?id=167927
432
433         Reviewed by Brent Fulgham.
434
435         Enable ComplexTextController API tests on the Win and GTK ports.
436
437         * TestWebKitAPI/PlatformGTK.cmake:
438         * TestWebKitAPI/PlatformWin.cmake:
439
440 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
441
442         File index appended to previous file in svn-create-patch with SVN 1.9
443         https://bugs.webkit.org/show_bug.cgi?id=167903
444         <rdar://problem/30387395>
445
446         Reviewed by Daniel Bates.
447
448         * Scripts/VCSUtils.pm:
449         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
450         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
451         trailing newline character from the expected result before comparing it to the actual result.
452
453 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
454
455         [webkitdirs] remove unused host_processor variable in determineArchitecture()
456         https://bugs.webkit.org/show_bug.cgi?id=167936
457
458         Reviewed by Michael Catanzaro.
459
460         * Scripts/webkitdirs.pm:
461         (determineArchitecture):
462         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
463         since r195083.
464
465 2017-02-07  Youenn Fablet  <youenn@apple.com>
466
467         Use a JSON file to define which WPT files/folders to import
468         https://bugs.webkit.org/show_bug.cgi?id=167923
469
470         Reviewed by Alex Christensen.
471
472         * Scripts/webkitpy/w3c/test_downloader.py:
473         (TestDownloader.__init__):
474         (TestDownloader._init_paths_from_expectations):
475         * Scripts/webkitpy/w3c/test_importer.py:
476         (parse_args):
477         * Scripts/webkitpy/w3c/test_importer_unittest.py:
478
479 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
480
481         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
482         https://bugs.webkit.org/show_bug.cgi?id=167916
483
484         Reviewed by Carlos Garcia Campos.
485
486         URL of mesa-11.0.6.tar.xz has been moved.
487
488         * gtk/jhbuild.modules: Fix the module path.
489
490 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
491
492         Static Analyzer: Address some leaks in MiniBrowser
493         https://bugs.webkit.org/show_bug.cgi?id=167897
494
495         Reviewed by Alexey Proskuryakov.
496
497         * MiniBrowser/mac/BrowserWindowController.m:
498         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
499         * MiniBrowser/mac/ExtensionManagerWindowController.m:
500         (-[ExtensionManagerWindowController add:]):
501         (-[ExtensionManagerWindowController remove:]):
502         * MiniBrowser/mac/SettingsController.m:
503         (-[SettingsController _populateMenu]):
504         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
505         Address obvious leaks caught by the static analyzer.
506
507 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
508
509         Migrate ComplexTextController to use platform-independent types
510         https://bugs.webkit.org/show_bug.cgi?id=167833
511
512         Reviewed by Brent Fulgham.
513
514         Migrate tests away from platform-dependent types.
515
516         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
517         (TestWebKitAPI::TEST_F):
518
519 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
520
521         Correct File Path Handling in SecurityOrigin and FileSystem
522         https://bugs.webkit.org/show_bug.cgi?id=167894
523         <rdar://problem/30380080>
524
525         Reviewed by Alexey Proskuryakov.
526
527         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
528         and perform same-volume checks using filesystem-compatible paths.        
529         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
530         filesystem paths, and perform validation of same-volume checks.
531         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
532         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
533         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
534         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
535
536 2017-02-06  Jer Noble  <jer.noble@apple.com>
537
538         Playback stalls when a SourceBuffer append causes frame eviction
539         https://bugs.webkit.org/show_bug.cgi?id=167834
540
541         Reviewed by Eric Carlson.
542
543         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
544         for the WTF::MediaTime class.
545
546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
547         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
548         (TestWebKitAPI::TEST):
549         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
550         (WTF::operator<<):
551         (TestWebKitAPI::TestSample::create):
552         (TestWebKitAPI::TestSample::TestSample):
553         (TestWebKitAPI::TEST_F):
554
555 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
556
557         Change capitalization in platform name after r211735.
558
559         Unreviewed dashboard fix.
560
561         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
562         (WebKitBuildbot):
563
564 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
565
566         Move the Leaks bot to Sierra
567         https://bugs.webkit.org/show_bug.cgi?id=167886
568
569         Reviewed by Daniel Bates.
570
571         * BuildSlaveSupport/build.webkit.org-config/config.json:
572         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
573         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
574         (LeaksViewer._displayURLPrompt):
575         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
576         (WebKitBuildbot):
577
578 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
579
580         Prevent app crash on launch during simctl install workaround
581         https://bugs.webkit.org/show_bug.cgi?id=167685
582
583         Reviewed by Daniel Bates.
584
585         * Scripts/webkitpy/port/simulator_process.py:
586         (SimulatorProcess.__init__): Pass environment to install.
587         * Scripts/webkitpy/xcode/simulator.py:
588         (Device.install_app): Accept environment, pass environment to launch.
589
590 2017-02-06  Alex Christensen  <achristensen@webkit.org>
591
592         Rebase API tests after r211638
593         https://bugs.webkit.org/show_bug.cgi?id=167779
594
595         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
596         (TestWebKitAPI::TEST_F):
597         URLs with non-special schemes and characters like % in the host now fail to parse,
598         more like their special counterparts and according to spec.
599
600 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
601
602         Unreviewed trivial fix after r211697.
603         https://bugs.webkit.org/show_bug.cgi?id=167863
604
605         * Scripts/run-javascriptcore-tests:
606         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
607
608 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
609
610         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
611         https://bugs.webkit.org/show_bug.cgi?id=167850
612
613         Reviewed by Tim Horton.
614
615         * DumpRenderTree/TestRunner.cpp:
616         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
617
618 2017-02-04  Andreas Kling  <akling@apple.com>
619
620         Plug some leaks in TestController and UIScriptContext.
621         <https://webkit.org/b/167839>
622
623         Reviewed by Alexey Proskuryakov.
624
625         Fix a couple of the leaks seen on the leaks bot.
626
627         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
628         (UIScriptContext::runUIScript):
629         * WebKitTestRunner/TestController.cpp:
630         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
631         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
632
633 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
634
635         WK1 mouse events are missing movementX and movementY for pointerlock.
636         https://bugs.webkit.org/show_bug.cgi?id=167775
637         rdar://problem/30343810
638
639         Reviewed by Alexey Proskuryakov.
640
641         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
642
643         * DumpRenderTree/mac/EventSendingController.mm:
644         (-[EventSendingController mouseMoveToX:Y:]):
645         * WebKitTestRunner/mac/EventSenderProxy.mm:
646         (WTR::EventSenderProxy::mouseMoveTo):
647
648 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
649
650         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
651         https://bugs.webkit.org/show_bug.cgi?id=167774
652
653         Reviewed by Tim Horton.
654
655         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
656         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
657         web process are async, so the callback fires after the web process gets the new state.
658
659         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
660         (WTR::UIScriptController::removeViewFromWindow):
661         (WTR::UIScriptController::addViewToWindow):
662         * DumpRenderTree/mac/DumpRenderTree.mm:
663         (createWebViewAndOffscreenWindow):
664         (resetWebViewToConsistentStateBeforeTesting):
665         * DumpRenderTree/mac/DumpRenderTreeMac.h:
666         * DumpRenderTree/mac/UIScriptControllerMac.mm:
667         (WTR::UIScriptController::removeViewFromWindow):
668         (WTR::UIScriptController::addViewToWindow):
669         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
670         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
671         (WTR::UIScriptController::removeViewFromWindow):
672         (WTR::UIScriptController::addViewToWindow):
673         * TestRunnerShared/UIScriptContext/UIScriptController.h:
674         * WebKitTestRunner/PlatformWebView.h:
675         * WebKitTestRunner/TestController.cpp:
676         (WTR::TestController::resetStateToConsistentValues):
677         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
678         (WTR::PlatformWebView::removeFromWindow):
679         (WTR::PlatformWebView::addToWindow):
680         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
681         (WTR::UIScriptController::removeViewFromWindow):
682         (WTR::UIScriptController::addViewToWindow):
683         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
684         (WTR::PlatformWebView::removeFromWindow):
685         (WTR::PlatformWebView::addToWindow):
686         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
687         (WTR::UIScriptController::removeViewFromWindow):
688         (WTR::UIScriptController::addViewToWindow):
689
690 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
691
692         Remove check for SkipSafariExecutableEntitlementChecks
693         https://bugs.webkit.org/show_bug.cgi?id=167762
694
695         Reviewed by Dan Bernstein.
696
697         Follow-up fix: don't break internal behavior.
698
699         * Scripts/webkitdirs.pm:
700         (safariPath):
701         (executableHasEntitlements): Deleted.
702         (safariPathFromSafariBundle): Deleted.
703         (installedSafariPath): Deleted.
704
705 2017-02-03  Daniel Bates  <dabates@apple.com>
706
707         [Mac][WK2] Add SPI to override the Content Security Policy of a page
708         https://bugs.webkit.org/show_bug.cgi?id=167810
709         <rdar://problem/30102568>
710
711         Reviewed by Anders Carlsson.
712
713         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
714
715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
716         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
717         (TEST):
718         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
719         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
720         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
721         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
722
723 2017-02-02  Alex Christensen  <achristensen@webkit.org>
724
725         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
726         https://bugs.webkit.org/show_bug.cgi?id=167773
727         <rdar://problem/30221102>
728
729         Reviewed by Ryosuke Niwa.
730
731         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
732         (TestWebKitAPI::TEST_F):
733
734 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
735
736         Remove check for SkipSafariExecutableEntitlementChecks
737         https://bugs.webkit.org/show_bug.cgi?id=167762
738         rdar://problem/22480673
739
740         Reviewed by Dan Bernstein.
741
742         * Scripts/webkitdirs.pm:
743         (safariPathFromSafariBundle):
744         (skipSafariExecutableEntitlementChecks): Deleted.
745
746 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
747
748         Undefined subroutine in svn-create-patch
749         https://bugs.webkit.org/show_bug.cgi?id=167742
750
751         Unreviewed build-fix after r211543.
752
753         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
754
755 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
756
757         Unreviewed. Fix jhbuild dependencies build.
758
759         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
760         Patch updated.
761
762 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
763
764         [EME][GStreamer] Fixed decryptor selection
765         https://bugs.webkit.org/show_bug.cgi?id=167588
766
767         Reviewed by Žan Doberšek.
768
769         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
770
771         * gtk/jhbuild.modules: Added patches to gstreamer and
772         gst-plugins-good packages.
773         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
774         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
775
776 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
777
778         Make run-benchmark script supports 'config' key in test plan.
779         https://bugs.webkit.org/show_bug.cgi?id=167715
780
781         Reviewed by Ryosuke Niwa.
782
783         Add support for 'config' key in test paln.
784         'config' key is a dictionary that specifies environment configurations while test is running.
785         Specifies orientation to be portrait in MotionMark benchmark.
786
787         * Scripts/webkitpy/benchmark_runner/README.md:
788         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
789         (BenchmarkRunner.__init__):
790         (BenchmarkRunner._run_benchmark):
791         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
792         (BrowserDriver.prepare_env):
793         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
794         (LinuxBrowserDriver.prepare_env):
795         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
796         (OSXBrowserDriver.prepare_env):
797         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
798         (OSXSafariDriver.prepare_env):
799         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
800
801 2017-02-01  Daniel Bates  <dabates@apple.com>
802
803         REGRESSION (r210820): svn-create-patch does not emit property change only diff
804         https://bugs.webkit.org/show_bug.cgi?id=167169
805
806         Reviewed by David Kilzer.
807
808         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
809         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
810         header from the output of "svn diff" on a file that was copied or moved.
811
812         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
813         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
814         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
815         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
816         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
817         of a file with only a property change also does not contain any chunk range lines. Therefore
818         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
819         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
820         we should directly test for the presence of a leading SVN diff header with an empty body and
821         remove such lines from the diff.
822
823         * Scripts/VCSUtils.pm:
824         (fixSVNPatchForAdditionWithHistory): Added.
825         * Scripts/svn-create-patch:
826         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
827         we have a non empty patch for an added file with history (i.e. a copied or moved file).
828         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
829
830 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
831
832         [Mac] Update CARingBuffer class
833         https://bugs.webkit.org/show_bug.cgi?id=167656
834
835         Reviewed by Jer Noble.
836
837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
838         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
839         (TestWebKitAPI::CARingBufferTest::SetUp):
840         (TestWebKitAPI::CARingBufferTest::setup):
841         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
842         (TestWebKitAPI::CARingBufferTest::description):
843         (TestWebKitAPI::CARingBufferTest::bufferList):
844         (TestWebKitAPI::CARingBufferTest::ringBuffer):
845         (TestWebKitAPI::CARingBufferTest::capacity):
846         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
847         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
848         (TestWebKitAPI::TEST_F):
849         (TestWebKitAPI::MixingTest::run):
850
851 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
852
853         [Mac] TestWebKitAPI includes system frameworks incorrectly
854         https://bugs.webkit.org/show_bug.cgi?id=167703
855         rdar://problem/30301498
856
857         Reviewed by Ryosuke Niwa.
858
859         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
860         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
861
862         Also, reduced the number of subframework search paths, looks like we only need one now.
863
864         * TestWebKitAPI/Configurations/Base.xcconfig:
865
866 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
867
868         Correct "filesHaveSameVolume" predicate
869         https://bugs.webkit.org/show_bug.cgi?id=167696
870         <rdar://problem/30298722>
871
872         Reviewed by David Kilzer.
873
874         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
875         percent-escaped path inputs.
876
877         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
878         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
879         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
880         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
881         (TestWebKitAPI::TEST_F):
882
883 2017-02-01  Tomas Popela  <tpopela@redhat.com>
884
885         Unreviewed. Fix coding style in MiniBrowser
886
887         * MiniBrowser/gtk/BrowserWindow.c:
888         (editingCommandCallback):
889         (insertImageCommandCallback):
890         (insertLinkCommandCallback):
891
892 2017-02-01  Tomas Popela  <tpopela@redhat.com>
893
894         [GTK] Add an API to add a custom tab into the print dialog
895         https://bugs.webkit.org/show_bug.cgi?id=151998
896
897         Reviewed by Carlos Garcia Campos.
898
899         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
900         that is testing a newly added API.
901
902         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
903         (testPrintCustomWidget):
904         (beforeAll):
905
906 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
907
908         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
909         https://bugs.webkit.org/show_bug.cgi?id=166529
910
911         Reviewed by Xabier Rodriguez-Calvar.
912
913         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
914         New patch version accepted in GStreamer upstream.
915
916 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
917
918         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
919         https://bugs.webkit.org/show_bug.cgi?id=167498
920
921         Reviewed by Carlos Garcia Campos.
922
923         Depending on the distro version you can need either libxfont1-dev
924         or libfont-dev to build with jhbuild.
925
926         * gtk/install-dependencies:
927
928 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
929
930         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
931         https://bugs.webkit.org/show_bug.cgi?id=167594
932
933         Unreviewed test gardening.
934
935         Disabling this test while we investigate the cause of a timeout on ios-simulator.
936
937         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
938         (TEST):
939
940 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
941
942         Move slow-running microbenchmarks out of JSTests/microbenchmarks
943         https://bugs.webkit.org/show_bug.cgi?id=167676
944
945         Reviewed by Saam Barati.
946
947         * Scripts/run-javascriptcore-tests:
948         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
949
950 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
951
952         Make Dump Render Tree not crash
953         https://bugs.webkit.org/show_bug.cgi?id=167667
954
955         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
956         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
957         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
958         This does not fix any tests, it just fixes the crash.
959         
960         Reviewed by Simon Fraser.
961
962         * DumpRenderTree/TestRunner.cpp:
963         (TestRunner::callUIScriptCallback):
964
965 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
966
967         Workaround for simctl install failing to report install failure
968         https://bugs.webkit.org/show_bug.cgi?id=167654
969
970         Reviewed by Daniel Bates.
971
972         simctl install will sometimes report success even though install has failed.
973         To workaround this bug, we attempt an app launch after install to ensure
974         install has succeeded.
975
976         * Scripts/webkitpy/xcode/simulator.py:
977         (Device.install_app): Attempt app launch after install, retry install if launch fails.
978         (Device.launch_app): Correct comment.
979
980 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
981
982         Unreviewed webkitpy fix after r211405.
983
984         * Scripts/webkitpy/xcode/simulator.py:
985         (Device.launch_app): Remove @staticmethod on _log_debug_error.
986
987 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
988
989         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
990
991         * gtk/manifest.txt.in:
992
993 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
994
995         AX: enable search predication for iOS
996         https://bugs.webkit.org/show_bug.cgi?id=167558
997         <rdar://problem/30251367>
998
999         Reviewed by Joanmarie Diggs.
1000
1001         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1002         (AccessibilityUIElement::uiElementForSearchPredicate):
1003         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1004         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1005         (searchPredicateParameterizedAttributeForSearchCriteria):
1006         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1007         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1008         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1009         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1010         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1011         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1012         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1013         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1014         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1015         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1016         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1017
1018 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1019
1020         Workaround for simctl launch bug
1021         https://bugs.webkit.org/show_bug.cgi?id=167613
1022
1023         Reviewed by Daniel Bates.
1024
1025         simctl launch will sometimes fail because of a race condition when many
1026         simulators are being run simultaneously. These failures will always have
1027         an exit code of 1. This change attempts to launch an app multiple times
1028         before reporting a failure to workaround this bug.
1029
1030         * Scripts/webkitpy/xcode/simulator.py:
1031         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1032
1033 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1034
1035         Commit queue fails to look at real name aliases for the reviewer
1036         https://bugs.webkit.org/show_bug.cgi?id=167422
1037
1038         Reviewed by Joseph Pecoraro.
1039
1040         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1041         (test_has_valid_reviewer): Added tests.
1042
1043         * Scripts/webkitpy/common/config/committers.py:
1044         (CommitterList._name_to_contributor_map):
1045         Made _name_to_contributor_map include alias names.
1046
1047         * Scripts/webkitpy/common/config/committers_unittest.py:
1048         (CommittersTest.test_contributors_by_fuzzy_match):
1049         Removed subtests that are now obsolete, as these matches are strict. It is not
1050         obvious if distance based fuzzy matching for names is useful at all, but we can
1051         look into that some other time.
1052
1053 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1054
1055         QueueStatusServer should have an explicit timeout for _fetch_url
1056         https://bugs.webkit.org/show_bug.cgi?id=167467
1057
1058         Reviewed by Alexey Proskuryakov.
1059
1060         * Scripts/webkitpy/common/net/statusserver.py:
1061         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1062
1063 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1064
1065         Add support for Trac instances that host multiple projects.
1066         https://bugs.webkit.org/show_bug.cgi?id=167524
1067
1068         Reviewed by Alexey Proskuryakov.
1069
1070         When multiple projects are hosted on a single Trac instance, the current
1071         behavior will retrieve changesets from all tracked projects.
1072         This patch teaches Trac.js to get project-specific changesets from Trac.
1073         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1074         when querying the Trac timeline.
1075
1076         To tell Trac to be aware of multi-project instances we leverage the 
1077         `options` parameter when creating a new instance: 
1078
1079             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1080
1081         If this option is not provided, the original behaviour will prevail.
1082         Additionally, add corresponding tests.
1083
1084         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1085         (Trac): Reason about new optional parameter 'projectIdentifier'.
1086         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1087         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1088         replace default parameter `changeset=on` with `repo-projectname=on`.
1089         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1090         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1091         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1092         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1093         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1094         Add the following tests:
1095             test("revisionURL")
1096             test("revisionURL with Trac Identifier")
1097             test("_xmlTimelineURL")
1098             test("_xmlTimelineURL with Trac Identifier")
1099         (this.view._latestProductiveIteration): Fix missing ';'.
1100
1101 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1102
1103         Correct spacing regression on inter-element complex path shaping on some fonts
1104         https://bugs.webkit.org/show_bug.cgi?id=166013
1105
1106         Reviewed by Simon Fraser.
1107
1108         Unskip existing tests and make some new tests:
1109         - Testing complex text with no origins
1110         - Testing initial expansions
1111         - Testing the sign of vertical advances
1112
1113         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1114         (TestWebKitAPI::TEST_F):
1115
1116 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1117
1118         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1119         https://bugs.webkit.org/show_bug.cgi?id=167596
1120
1121         Reviewed by Daniel Bates.
1122
1123         We avoid needing a thin directory by invoking the zip program with
1124         the list of directories from the build directory to be zipped,
1125         and by using the zip feature to exclude files matching a pattern.
1126
1127         * BuildSlaveSupport/built-product-archive:
1128         (copyBuildFiles):
1129         (createZipFromList):
1130         (archiveBuiltProduct):
1131
1132 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1133
1134         Use simctl instead of LayoutTestRelay
1135         https://bugs.webkit.org/show_bug.cgi?id=165927
1136
1137         Reviewed by Daniel Bates.
1138
1139         Part 1
1140
1141         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1142         simulators through simctl (iOS 10 and later), use this functionality instead.
1143
1144         * Scripts/webkitpy/port/base.py:
1145         (Port.__init__): Added _test_runner_process_constructor.
1146         * Scripts/webkitpy/port/darwin.py:
1147         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1148         * Scripts/webkitpy/port/driver.py:
1149         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1150         (IOSSimulatorDriver): Deleted.
1151         * Scripts/webkitpy/port/driver_unittest.py:
1152         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1153         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1154         (DriverTest.test_start_actually_starts): Ditto.
1155         * Scripts/webkitpy/port/ios.py:
1156         (IOSSimulatorPort): Remove relay_name.
1157         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1158         (IOSSimulatorPort._create_simulators): Formatting change.
1159         (IOSSimulatorPort.relay_path): Deleted.
1160         (IOSSimulatorPort._check_relay): Deleted.
1161         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1162         (IOSSimulatorPort._build_relay): Deleted.
1163         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1164         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1165         * Scripts/webkitpy/port/ios_unittest.py:
1166         (iosTest.test_32bit): Update test.
1167         (iosTest.test_64bit): Update test.
1168         * Scripts/webkitpy/port/server_process.py:
1169         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1170         (ServerProcess._set_file_nonblocking): Added to share common code.
1171         * Scripts/webkitpy/port/server_process_mock.py:
1172         (MockServerProcess.__init__): Added argument worker_number.
1173         * Scripts/webkitpy/port/simulator_process.py: Added.
1174         (SimulatorProcess): Added.
1175         (SimulatorProcess.Popen): Added.
1176         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1177         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1178         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1179         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1180         (SimulatorProcess._reset): Added. Unlink fifos.
1181         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1182         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1183         * Scripts/webkitpy/xcode/simulator.py:
1184         (Device.__init__): Accept host to run install/launch/terminate.
1185         (Device.install_app): Install app to target Device.
1186         (Device.launch_app): Launch app on target Device.
1187         (Device.terminate_app): Shutdown app on target Device.
1188         (Simulator._parse_devices): Pass host to Device.
1189
1190 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1191
1192         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1193         https://bugs.webkit.org/show_bug.cgi?id=167411
1194
1195         Reviewed by Michael Catanzaro.
1196
1197         Disable the ARM iwMMXt fast path for pixman, because it triggers
1198         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1199
1200         * gtk/jhbuild.modules:
1201
1202 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1203
1204         [GTK] Add API to handle the accelerated compositing policy
1205         https://bugs.webkit.org/show_bug.cgi?id=167509
1206
1207         Reviewed by Michael Catanzaro.
1208
1209         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1210         as a special case. Also add test cases to the get/set API.
1211
1212         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1213         (hardwareAccelerationPolicyToString):
1214         (stringToHardwareAccelerationPolicy):
1215         (cellRendererChanged):
1216         (browserSettingsDialogConstructed):
1217         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1218         (testWebKitSettings):
1219
1220 2017-01-29  Andy Estes  <aestes@apple.com>
1221
1222         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1223         https://bugs.webkit.org/show_bug.cgi?id=167563
1224         <rdar://problem/30253207>
1225
1226         Reviewed by Andreas Kling.
1227
1228         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1229         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1230         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1231         (runTest):
1232         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1233         (TEST):
1234
1235 2017-01-29  Dan Bernstein  <mitz@apple.com>
1236
1237         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1238         https://bugs.webkit.org/show_bug.cgi?id=167565
1239
1240         Reviewed by Sam Weinig.
1241
1242         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1243         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1244         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1245         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1246         (TEST):
1247         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1248         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1249         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1250         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1251
1252 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1253
1254         Add Link Preload as an off-by-default experimental feature menu item.
1255         https://bugs.webkit.org/show_bug.cgi?id=167201
1256
1257         Reviewed by Ryosuke Niwa.
1258
1259         * DumpRenderTree/mac/DumpRenderTree.mm:
1260         (resetWebPreferencesToConsistentValues):
1261         * DumpRenderTree/win/DumpRenderTree.cpp:
1262         (resetWebPreferencesToConsistentValues):
1263
1264 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1265
1266         Add User Timing Experimental Feature
1267         https://bugs.webkit.org/show_bug.cgi?id=167542
1268         <rdar://problem/22746307>
1269
1270         Reviewed by Ryosuke Niwa.
1271
1272         * DumpRenderTree/mac/DumpRenderTree.mm:
1273         (enableExperimentalFeatures):
1274         (resetWebPreferencesToConsistentValues):
1275         * DumpRenderTree/win/DumpRenderTree.cpp:
1276         (enableExperimentalFeatures):
1277
1278 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1279
1280         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1281         https://bugs.webkit.org/show_bug.cgi?id=167519
1282
1283         Reviewed by Ryosuke Niwa.
1284
1285         * QueueStatusServer/templates/statusbubble.html:
1286         To measure the bubbleContainer's width, it must not be wrapping based
1287         on its parent container. So when measuring the width temporarily set
1288         the parent to a very large width so as to not artificially wrap us.
1289         Restore the parent's width after measuring.
1290
1291 2017-01-27  Andy Estes  <aestes@apple.com>
1292
1293         [iOS] Add a test for _WKNSFileManagerExtras
1294         https://bugs.webkit.org/show_bug.cgi?id=167478
1295
1296         Reviewed by Andreas Kling.
1297
1298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1299         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1300         (expectAttributes):
1301         (TEST):
1302
1303 2017-01-27  Keith Miller  <keith_miller@apple.com>
1304
1305         run-benchmarks should make sure it passes the test url to the right application
1306         https://bugs.webkit.org/show_bug.cgi?id=167533
1307
1308         Reviewed by Joseph Pecoraro.
1309
1310         This fixes an issue when trying to run-benchmark script with the
1311         system default browser set to STP. Previously, it would run
1312         the test in STP rather than the provided build. Now, it should run
1313         in the provided build.
1314
1315         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1316         (OSXSafariDriver.launch_url):
1317
1318 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1319
1320         [Cocoa] Prepare ComplexTextController for unit testing
1321         https://bugs.webkit.org/show_bug.cgi?id=167493
1322
1323         Reviewed by Simon Fraser.
1324
1325         Addressing post-review comments from Simon Fraser.
1326
1327         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1328         (TestWebKitAPI::TEST_F):
1329
1330 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1331
1332         [Cocoa] Prepare ComplexTextController for unit testing
1333         https://bugs.webkit.org/show_bug.cgi?id=167493
1334
1335         Reviewed by Dean Jackson.
1336
1337         Create four unit tests.
1338
1339         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1340         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1341         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1342         (TestWebKitAPI::TEST_F):
1343
1344 2017-01-26  Chris Dumez  <cdumez@apple.com>
1345
1346         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1347         https://bugs.webkit.org/show_bug.cgi?id=167421
1348         <rdar://problem/30188490>
1349
1350         Reviewed by Darin Adler.
1351
1352         Add a new setting allowing layout tests to enable PageCache in a window
1353         that has an opener, for convenience.
1354
1355         * DumpRenderTree/mac/DumpRenderTree.mm:
1356         (resetWebPreferencesToConsistentValues):
1357         * DumpRenderTree/win/DumpRenderTree.cpp:
1358         (resetWebPreferencesToConsistentValues):
1359         * WebKitTestRunner/TestController.cpp:
1360         (WTR::TestController::resetPreferencesToConsistentValues):
1361
1362 2017-01-26  Keith Miller  <keith_miller@apple.com>
1363
1364         classInfo should take a VM so it is not materialized from the object on each call
1365         https://bugs.webkit.org/show_bug.cgi?id=167424
1366
1367         Rubber Stamped by Michael Saboff.
1368
1369         Previously, classInfo() would get the VM from the target's
1370         MarkedBlock.  Most callers already have a VM on hand, so it is
1371         wasteful to compute the VM from the marked block every time. This
1372         patch refactors some of the most common callers of classInfo(),
1373         jsDynamicCast and inherits to take a VM as well.
1374
1375         * DumpRenderTree/TestRunner.cpp:
1376         (setAudioResultCallback):
1377
1378 2017-01-26  Jer Noble  <jer.noble@apple.com>
1379
1380         Autoplay muted videos stop playback of any streaming app in the background
1381         https://bugs.webkit.org/show_bug.cgi?id=163993
1382         <rdar://problem/29020431>
1383
1384         Reviewed by Eric Carlson.
1385
1386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1387         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1388         (TestWebKitAPI::TEST):
1389         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1390
1391 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1392
1393         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1394         https://bugs.webkit.org/show_bug.cgi?id=167466
1395
1396         Unreviewed test gardening.
1397
1398         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1399         (TEST):
1400
1401 2017-01-26  Matt Rajca  <mrajca@apple.com>
1402
1403         Notify clients when the user plays media otherwise prevented from autoplaying
1404         https://bugs.webkit.org/show_bug.cgi?id=167390
1405
1406         Reviewed by Alex Christensen.
1407
1408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1409         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1410         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1411         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1412         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1413         (TEST):
1414         * TestWebKitAPI/cocoa/TestWKWebView.h:
1415         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1416         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1417         (-[TestWKWebView waitForLoad]):
1418         (-[TestWKWebView mouseUpAtPoint:]):
1419         * WebKitTestRunner/TestController.cpp:
1420         (WTR::TestController::createOtherPage):
1421         (WTR::TestController::createWebViewWithOptions):
1422
1423 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1424
1425         Crash when setting custom scale factor.
1426         https://bugs.webkit.org/show_bug.cgi?id=167369
1427
1428         Reviewed by Sam Weinig.
1429
1430         Added API test.
1431
1432         * TestWebKitAPI/PlatformWin.cmake:
1433         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1434         (TestWebKitAPI::WebKitCreateInstance):
1435         (TestWebKitAPI::ScaleWebView::SetUp):
1436         (TestWebKitAPI::ScaleWebView::TearDown):
1437         (TestWebKitAPI::TEST_F):
1438
1439 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1440
1441         run-benchmark nests MotionMark results by the suite name twice
1442         https://bugs.webkit.org/show_bug.cgi?id=164948
1443
1444         Reviewed by Said Abou-Hallawa.
1445
1446         Use a single level MotionMark now that this is the name of the benchmark,
1447         and we no longer have tests that aren't part of the MotionMark suite.
1448
1449         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1450
1451 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1452
1453         Unreviewed, rolling out r211193.
1454
1455         This change broke internal builds.
1456
1457         Reverted changeset:
1458
1459         "Notify clients when the user plays media otherwise prevented
1460         from autoplaying"
1461         https://bugs.webkit.org/show_bug.cgi?id=167390
1462         http://trac.webkit.org/changeset/211193
1463
1464 2017-01-25  Matt Rajca  <mrajca@apple.com>
1465
1466         Notify clients when the user plays media otherwise prevented from autoplaying
1467         https://bugs.webkit.org/show_bug.cgi?id=167390
1468
1469         Reviewed by Alex Christensen.
1470
1471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1472         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1473         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1474         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1475         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1476         (TEST):
1477         * TestWebKitAPI/cocoa/TestWKWebView.h:
1478         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1479         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1480         (-[TestWKWebView waitForLoad]):
1481         (-[TestWKWebView mouseUpAtPoint:]):
1482         * WebKitTestRunner/TestController.cpp:
1483         (WTR::TestController::createOtherPage):
1484         (WTR::TestController::createWebViewWithOptions):
1485
1486 2017-01-25  Matt Rajca  <mrajca@apple.com>
1487
1488         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1489         https://bugs.webkit.org/show_bug.cgi?id=167385
1490
1491         Reviewed by Alex Christensen.
1492
1493         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1494         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1495         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1496         (TEST): Allow inline (rather than full screen) media playback on iOS.
1497
1498 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1499
1500         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1501         https://bugs.webkit.org/show_bug.cgi?id=167414
1502
1503         Reviewed by Michael Catanzaro.
1504
1505         Add a test case to check ephemeral web views don't write favicons to the database.
1506
1507         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1508         (ephemeralViewLoadChanged):
1509         (testPrivateBrowsing):
1510         (testFaviconDatabase):
1511
1512 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1513
1514         [GTK] Add a private browsing mode to MiniBrowser
1515         https://bugs.webkit.org/show_bug.cgi?id=167413
1516
1517         Reviewed by Michael Catanzaro.
1518
1519         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1520         private windows, even on non-private instances.
1521
1522         * MiniBrowser/gtk/BrowserWindow.c:
1523         (webViewTitleChanged): Add [Private] to title window for private windows.
1524         (webViewCreate): Pass web context to browser_window_new.
1525         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1526         (browserWindowFinalize): Disconnect web context signal handlers.
1527         (browser_window_init): Add shortcut for opening private window.
1528         (browser_window_new): It now receives the context and connect to download-started here.
1529         (browser_window_get_web_context): Return the context.
1530         * MiniBrowser/gtk/BrowserWindow.h:
1531         * MiniBrowser/gtk/main.c:
1532         (createBrowserTab): Create the web view for the window web context.
1533         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1534         (aboutDataHandleRequest): Ditto.
1535         (aboutURISchemeRequestCallback): Ditto.
1536         (main): Create ephemeral web context if private command line option is used.
1537
1538 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1539
1540         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1541         https://bugs.webkit.org/show_bug.cgi?id=167409
1542
1543         Reviewed by Antti Koivisto.
1544
1545         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1546         as well as tests for the newly added matchingElementInFlatTree.
1547
1548         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1549         (TestWebKitAPI::runJavaScriptAlert):
1550         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1551         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1552         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1553
1554 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1555
1556         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1557         https://bugs.webkit.org/show_bug.cgi?id=167370
1558
1559         Reviewed by Michael Catanzaro.
1560
1561         Add several test cases of ephemeral web views.
1562
1563         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1564         (testWebViewAuthenticationStorage):
1565         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1566         (ephemeralViewloadChanged):
1567         (testCookieManagerEphemeral):
1568         (beforeAll):
1569         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1570         (testWebKitSettings):
1571         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1572         (testWebContextEphemeral):
1573         (ephemeralViewloadChanged):
1574         (testWebContextProxySettings):
1575         (beforeAll):
1576         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1577         (ephemeralViewloadChanged):
1578         (testWebViewEphemeral):
1579         (beforeAll):
1580         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1581         (ephemeralViewloadChanged):
1582         (testWebsiteDataEphemeral):
1583         (beforeAll):
1584
1585 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1586
1587         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1588         https://bugs.webkit.org/show_bug.cgi?id=167402
1589
1590         Reviewed by Ryosuke Niwa.
1591
1592         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1593         (TestWebKitAPI::TEST):
1594
1595 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1596
1597         Add simple line layout toggle to MiniBrowser
1598         https://bugs.webkit.org/show_bug.cgi?id=167405
1599
1600         Reviewed by Andreas Kling.
1601
1602         * MiniBrowser/mac/SettingsController.h:
1603         * MiniBrowser/mac/SettingsController.m:
1604         (-[SettingsController _populateMenu]):
1605         (-[SettingsController validateMenuItem:]):
1606         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1607         (-[SettingsController simpleLineLayoutEnabled]):
1608         * MiniBrowser/mac/WK1BrowserWindowController.m:
1609         (-[WK1BrowserWindowController didChangeSettings]):
1610         * MiniBrowser/mac/WK2BrowserWindowController.m:
1611         (-[WK2BrowserWindowController didChangeSettings]):
1612
1613 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1614
1615         WKR does not include my nick when commit-queue lands my patch
1616         https://bugs.webkit.org/show_bug.cgi?id=167388
1617
1618         Reviewed by Ryosuke Niwa.
1619
1620         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1621         (NewCommitBot._summarize_commit_log):
1622         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1623         Perform nickname insertion before grabbing "Patch by" details.
1624         This way we can include the nickname with the full name.
1625
1626 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1627
1628         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1629         https://bugs.webkit.org/show_bug.cgi?id=167394
1630
1631         Reviewed by Ryosuke Niwa.
1632
1633         * Scripts/webkitperl/FeatureList.pm:
1634         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1635
1636 2017-01-24  Youenn Fablet  <youenn@apple.com>
1637
1638         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1639         https://bugs.webkit.org/show_bug.cgi?id=167353
1640
1641         Reviewed by Alex Christensen.
1642
1643         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1644         (CMakeGenerator.initialize_targets):
1645
1646 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1647
1648         WKR should not confuse Miguel Gomez with Andres Gomez
1649         https://bugs.webkit.org/show_bug.cgi?id=167389
1650
1651         Reviewed by Lucas Forschler.
1652
1653         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1654         "mAndres Gomez". Fix this.
1655
1656         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1657         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1658         space on each side of the email address, so expect both spaces to be there before
1659         considering the email for replacement.
1660         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1661
1662 2017-01-24  Matt Rajca  <mrajca@apple.com>
1663
1664         Pass down website autoplay policies to media elements
1665         https://bugs.webkit.org/show_bug.cgi?id=167355
1666
1667         Reviewed by Alex Christensen.
1668
1669         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1670         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1671         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1672         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1673         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1674         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1675         (TEST):
1676
1677 2017-01-24  Nan Wang  <n_wang@apple.com>
1678
1679         AX: Speak Selection does not work in an iframe
1680         https://bugs.webkit.org/show_bug.cgi?id=166794
1681         <rdar://problem/29913013>
1682
1683         Reviewed by Chris Fleizach.
1684
1685         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1686         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1687         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1688         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1689         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1690         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1691         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1692         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1693         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1694         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1695         (-[TestRunnerWKWebView dealloc]):
1696         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1697         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1698         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1699         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1700         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1701
1702 2017-01-24  Daniel Bates  <dabates@apple.com>
1703
1704         StringView.split() should use an iterator design pattern instead of allocating a Vector
1705         https://bugs.webkit.org/show_bug.cgi?id=163225
1706
1707         Reviewed by Darin Adler.
1708
1709         Add unit tests for StringView.split().
1710
1711         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1712         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1713         used in the StringView.split() unit tests.
1714         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1715         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1716         object to a Vector of String objects.
1717         (TestWebKitAPI::TEST): Added the following tests:
1718             - WTF.StringViewSplitEmptyAndNullStrings
1719             - WTF.StringViewSplitBasic
1720             - WTF.StringViewSplitWithConsecutiveSeparators
1721
1722 2017-01-23  Anders Carlsson  <andersca@apple.com>
1723
1724         The Score Esports crashes on launch
1725         https://bugs.webkit.org/show_bug.cgi?id=167338
1726         rdar://problem/29948645
1727
1728         Reviewed by Dan Bernstein.
1729
1730         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1731         (TestWebKitAPI::TEST):
1732         Add a test.
1733
1734 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1735
1736         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1737         https://bugs.webkit.org/show_bug.cgi?id=146589
1738
1739         Reviewed by Michael Catanzaro.
1740
1741         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1742         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1743
1744         * MiniBrowser/gtk/BrowserWindow.c:
1745         (webViewDecidePolicy):
1746         (newTabCallback):
1747         * MiniBrowser/gtk/main.c:
1748         (createBrowserTab):
1749         (aboutDataRequestFree):
1750         (aboutDataRequestNew):
1751         (aboutDataRequestForView):
1752         (websiteDataRemovedCallback):
1753         (websiteDataClearedCallback):
1754         (aboutDataScriptMessageReceivedCallback):
1755         (domainListFree):
1756         (aboutDataFillTable):
1757         (gotWebsiteDataCallback):
1758         (aboutDataHandleRequest):
1759         (aboutURISchemeRequestCallback):
1760         (main):
1761         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1762         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1763         (serverCallback):
1764         (beforeAll):
1765         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1766         (serverCallback):
1767         (WebsiteDataTest::WebsiteDataTest):
1768         (WebsiteDataTest::~WebsiteDataTest):
1769         (WebsiteDataTest::fetch):
1770         (WebsiteDataTest::remove):
1771         (WebsiteDataTest::clear):
1772         (testWebsiteDataConfiguration):
1773         (testWebsiteDataCache):
1774         (testWebsiteDataStorage):
1775         (testWebsiteDataDatabases):
1776         (testWebsiteDataAppcache):
1777         (beforeAll):
1778         (afterAll):
1779
1780 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1781
1782         Unreviewed, rolling out r211062.
1783         https://bugs.webkit.org/show_bug.cgi?id=167354
1784
1785         broke API tests (Requested by alexchristensen on #webkit).
1786
1787         Reverted changeset:
1788
1789         "Pass down website autoplay policies to media elements"
1790         https://bugs.webkit.org/show_bug.cgi?id=167132
1791         http://trac.webkit.org/changeset/211062
1792
1793 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1794
1795         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1796         https://bugs.webkit.org/show_bug.cgi?id=167330
1797
1798         Reviewed by Tim Horton.
1799
1800         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1801         (TestWebKitAPI::TEST_F):
1802
1803 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1804
1805         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1806         https://bugs.webkit.org/show_bug.cgi?id=167317
1807
1808         Reviewed by Sam Weinig.
1809
1810         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1811         (TestWebKitAPI::TEST_F):
1812
1813 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1814
1815         svn-create-patch should emit properties when files are moved or copied
1816         https://bugs.webkit.org/show_bug.cgi?id=167264
1817
1818         Reviewed by Daniel Bates.
1819
1820         * Scripts/svn-create-patch:
1821         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1822
1823 2017-01-23  Youenn Fablet  <youenn@apple.com>
1824
1825         [WebRTC] Filter libwebrtc link flags
1826         https://bugs.webkit.org/show_bug.cgi?id=167287
1827
1828         Reviewed by Alex Christensen.
1829
1830         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1831         (CMakeGenerator._compute_link_flags):
1832         (CMakeGenerator._compute_link_flags.keep_flag):
1833         (CMakeGenerator._generate_compile_target_options):
1834
1835 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1836
1837         [WebRTC] Make VP8 optional in libwebrtc
1838         https://bugs.webkit.org/show_bug.cgi?id=167257
1839
1840         Reviewed by Darin Adler.
1841
1842         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1843         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1844
1845 2017-01-23  Jer Noble  <jer.noble@apple.com>
1846
1847         Video details does not apear and missing scrubber in Control Center
1848         https://bugs.webkit.org/show_bug.cgi?id=167233
1849
1850         Reviewed by Alex Christensen.
1851
1852         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1853         NowPlayingControlTests for iOS.
1854
1855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1856         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1857         (-[NowPlayingTestWebView setWindowVisible:]):
1858         (TestWebKitAPI::TEST):
1859         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1860         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1861         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1862         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1863         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1864         (SOFT_LINK_CLASS):
1865         (-[TestMessageHandler addMessage:withHandler:]):
1866         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1867         (__simulated_forceClickAssociatedEventsMask):
1868         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1869         (-[TestWKWebViewHostWindow isKeyWindow]):
1870         (-[TestWKWebViewHostWindow makeKeyWindow]):
1871         (-[TestWKWebViewHostWindow resignKeyWindow]):
1872         (-[TestWKWebView initWithFrame:]):
1873         (-[TestWKWebView initWithFrame:configuration:]):
1874         (-[TestWKWebView _setUpTestWindow:]):
1875         (-[TestWKWebView performAfterReceivingMessage:action:]):
1876         (-[TestWKWebView loadTestPageNamed:]):
1877         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1878         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1879         (-[TestWKWebView waitForMessage:]):
1880         (-[TestWKWebView performAfterLoading:]):
1881         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1882         (-[TestWKWebView typeCharacter:]):
1883
1884 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1885
1886         Unreviewed. Bring back gtk-doc error messages after r209981.
1887
1888         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1889         impossible to know what's wrong.
1890
1891         * gtk/gtkdoc.py:
1892         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1893
1894 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1895
1896         [WebRTC] Update build system to make G711 optional in libwebrtc
1897         https://bugs.webkit.org/show_bug.cgi?id=167256
1898
1899         Reviewed by Alex Christensen.
1900
1901         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1902         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1903
1904 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1905
1906         Cleanup RuntimeEnabledFeatures
1907         https://bugs.webkit.org/show_bug.cgi?id=167228
1908
1909         Reviewed by Simon Fraser.
1910
1911         * DumpRenderTree/mac/DumpRenderTree.mm:
1912         (enableExperimentalFeatures):
1913         (resetWebPreferencesToConsistentValues):
1914         (setWebPreferencesForTestOptions):
1915         (resetWebViewToConsistentStateBeforeTesting):
1916         * DumpRenderTree/win/DumpRenderTree.cpp:
1917         (enableExperimentalFeatures):
1918         (resetWebPreferencesToConsistentValues):
1919         More closely match WebKitTestRunner initialization of preferences
1920         for experimental features.
1921
1922 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1923
1924         Build Fix for Windows DumpRenderTree after r210976
1925         https://bugs.webkit.org/show_bug.cgi?id=167115
1926
1927         * DumpRenderTree/win/DumpRenderTree.cpp:
1928         (resetWebPreferencesToConsistentValues):
1929
1930 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1931
1932         Remove outdated ENABLE(CSP_NEXT) build flag
1933         https://bugs.webkit.org/show_bug.cgi?id=167252
1934
1935         Reviewed by Brent Fulgham.
1936
1937         * Scripts/webkitperl/FeatureList.pm:
1938         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1939
1940 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1941
1942         Build Fix for Windows DumpRenderTree after r210976
1943
1944         * DumpRenderTree/win/DumpRenderTree.cpp:
1945         (resetWebPreferencesToConsistentValues):
1946
1947 2017-01-20  Antoine Quint  <graouts@apple.com>
1948
1949         Web Animations should be off by default and enabled as an experimental feature
1950         https://bugs.webkit.org/show_bug.cgi?id=167115
1951         <rdar://problem/30048963>
1952
1953         Reviewed by Joseph Pecoraro.
1954
1955         Turn Web Animations on in DRT.
1956
1957         * DumpRenderTree/mac/DumpRenderTree.mm:
1958         (resetWebPreferencesToConsistentValues):
1959         * DumpRenderTree/win/DumpRenderTree.cpp:
1960         (resetWebPreferencesToConsistentValues):
1961
1962 2017-01-20  Youenn Fablet  <youenn@apple.com>
1963
1964         [WebRTC] Add libwebrtc build infrastructure
1965         https://bugs.webkit.org/show_bug.cgi?id=167207
1966
1967         Reviewed by Alex Christensen.
1968
1969         Adding a script doing the libwebrtc project json to CMake file conversion.
1970
1971         * Scripts/generate-libwebrtc-cmake: Added.
1972         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
1973         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
1974
1975 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1976
1977         Mini Browser: Show tooltip for Experimental Features
1978         https://bugs.webkit.org/show_bug.cgi?id=167225
1979
1980         Reviewed by Alex Christensen.
1981
1982         * MiniBrowser/mac/SettingsController.m:
1983         (-[SettingsController _populateMenu]):
1984         Include the full details string as a tooltip.
1985
1986 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
1987
1988         [Win] Test output results should not be written twice.
1989         https://bugs.webkit.org/show_bug.cgi?id=167197
1990
1991         Reviewed by Brent Fulgham.
1992
1993         Prevent test output from being written twice by returning early from
1994         the dump() function, if it already has been called.
1995         This patch also adds a missing newline to a test output line. 
1996         
1997         * DumpRenderTree/win/DumpRenderTree.cpp:
1998         (dump):
1999
2000 2017-01-20  Antoine Quint  <graouts@apple.com>
2001
2002         [Modern Media Controls] Turn modern media controls on by default
2003         https://bugs.webkit.org/show_bug.cgi?id=165668
2004
2005         Reviewed by Dean Jackson.
2006
2007         Enabled modern media controls by default in test runners.
2008
2009         * DumpRenderTree/TestOptions.h:
2010         * WebKitTestRunner/TestOptions.h:
2011
2012 2017-01-19  Chris Dumez  <cdumez@apple.com>
2013
2014         iterable<> should be enabled on WK1
2015         https://bugs.webkit.org/show_bug.cgi?id=167221
2016         <rdar://problem/30108531>
2017
2018         Reviewed by Youenn Fablet.
2019
2020         * DumpRenderTree/mac/DumpRenderTree.mm:
2021         (resetWebPreferencesToConsistentValues):
2022         * DumpRenderTree/win/DumpRenderTree.cpp:
2023         (resetWebPreferencesToConsistentValues):
2024         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2025         (WTR::InjectedBundle::beginTesting):
2026         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2027         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2028         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2029
2030 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2031
2032         Ensure status server logs go to log file
2033         https://bugs.webkit.org/show_bug.cgi?id=167210
2034
2035         Reviewed by Alexey Proskuryakov.
2036
2037         * Scripts/webkitpy/common/net/statusserver.py:
2038         (StatusServer.next_work_item): Change log level from debug to info in
2039         order to facilitate deubgging issues.
2040         (StatusServer.update_work_items): Same.
2041
2042 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2043
2044         Additional selection tests and interpolation fix
2045         https://bugs.webkit.org/show_bug.cgi?id=167171
2046
2047         Reviewed by Simon Fraser.
2048
2049         We weren't adding the final event when interpolating event streams.
2050
2051         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2052         (-[HIDEventGenerator interpolatedEvents:]):
2053
2054 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2055
2056         [Cocoa] Variation fonts are erroneously disabled on iOS
2057         https://bugs.webkit.org/show_bug.cgi?id=167172
2058
2059         Reviewed by Simon Fraser.
2060
2061         OpenSource builders don't seem to understand sdk=embedded*.
2062
2063         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2064
2065 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2066
2067         Unreviewed. Fix GTK+ unit tests failing since r210531.
2068
2069         Avoid using paths to files that don't actually exist.
2070
2071         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2072         (testWebKitConsoleMessageNetworkError):
2073         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2074         (testContextMenuDefaultMenu):
2075         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2076         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2077         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2078
2079 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2080
2081         [GTK] Provide API to set proxy settings
2082         https://bugs.webkit.org/show_bug.cgi?id=128674
2083
2084         Reviewed by Michael Catanzaro.
2085
2086         Add tests for new proxy settings API.
2087
2088         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2089         (serverCallback):
2090         (ProxyTest::ProxyTest):
2091         (ProxyTest::~ProxyTest):
2092         (ProxyTest::loadURIAndGetMainResourceData):
2093         (ProxyTest::proxyServerPortAsString):
2094         (testWebContextProxySettings):
2095         (beforeAll):
2096
2097 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2098
2099         Add back my old email address so old commits will still match it.
2100
2101         * Scripts/webkitpy/common/config/contributors.json:
2102
2103 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2104
2105         Remove my old email address from contributors.json and watchlist.
2106
2107         * Scripts/validate-committer-lists:
2108         (CommitterListFromGit): Change the mapping to the correct email.
2109         * Scripts/webkitpy/common/config/contributors.json:
2110         * Scripts/webkitpy/common/config/watchlist:
2111
2112 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2113
2114         Unreviewed, rolling out r210848.
2115
2116         This change introduced media-related LayoutTest failures and
2117         crashes on macOS.
2118
2119         Reverted changeset:
2120
2121         "[Modern Media Controls] Turn modern media controls on by
2122         default"
2123         https://bugs.webkit.org/show_bug.cgi?id=165668
2124         http://trac.webkit.org/changeset/210848
2125
2126 2017-01-18  Andreas Kling  <akling@apple.com>
2127
2128         Document::securityOrigin() should return a reference.
2129         <https://webkit.org/b/167124>
2130
2131         Reviewed by Sam Weinig.
2132
2133         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2134         (TestWebKitAPI::TEST_F):
2135
2136 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2137
2138         [Win] Clipboard tests are flaky.
2139         https://bugs.webkit.org/show_bug.cgi?id=167088
2140
2141         Reviewed by Brent Fulgham.
2142
2143         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2144         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2145
2146         * DumpRenderTree/win/DumpRenderTree.cpp:
2147         (main):
2148
2149 2017-01-18  Antoine Quint  <graouts@apple.com>
2150
2151         [Modern Media Controls] Turn modern media controls on by default
2152         https://bugs.webkit.org/show_bug.cgi?id=165668
2153
2154         Reviewed by Dean Jackson.
2155
2156         Enabled modern media controls by default in test runners. 
2157
2158         * DumpRenderTree/TestOptions.h:
2159         * WebKitTestRunner/TestOptions.h:
2160
2161 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2162
2163         Unreviewed, rolling out r210834
2164         https://bugs.webkit.org/show_bug.cgi?id=165668
2165
2166         It introduced dozens of test timeouts.
2167
2168         Reverted changeset:
2169         "[Modern Media Controls] Turn modern media controls on by default"
2170         https://bugs.webkit.org/show_bug.cgi?id=165668
2171         http://trac.webkit.org/changeset/210834
2172
2173 2017-01-17  Antoine Quint  <graouts@apple.com>
2174
2175         [Modern Media Controls] Turn modern media controls on by default
2176         https://bugs.webkit.org/show_bug.cgi?id=165668
2177
2178         Reviewed by Dean Jackson.
2179
2180         Enabled modern media controls by default in test runners. 
2181
2182         * DumpRenderTree/TestOptions.h:
2183         * WebKitTestRunner/TestOptions.h:
2184
2185 2017-01-17  Chris Dumez  <cdumez@apple.com>
2186
2187         Document title changed twice when setting document.title
2188         https://bugs.webkit.org/show_bug.cgi?id=167065
2189
2190         Reviewed by Darin Adler.
2191
2192         Add WebKit2GTK API test that was written by Michael Catanzaro.
2193
2194         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2195         (testWebViewTitleChange):
2196         (beforeAll):
2197
2198 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2199
2200         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2201         https://bugs.webkit.org/show_bug.cgi?id=116551
2202         <rdar://problem/13949830>
2203
2204         Reviewed by Alex Christensen.
2205
2206         * Scripts/webkitperl/FeatureList.pm:
2207         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2208         that is part of the existing WEB_TIMING feature.
2209
2210         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2211
2212 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2213
2214         'webkit-patch post' no longer works with moved/copied files
2215         https://bugs.webkit.org/show_bug.cgi?id=166914
2216         <rdar://problem/29979707>
2217
2218         Reviewed by Daniel Bates.
2219
2220         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2221         file outputs only the "Index:" line with an empty body.  This workaround
2222         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2223         public email list tracking this bug is below.
2224         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2225         
2226
2227         * Scripts/svn-create-patch:
2228         (generateDiff): Ignore an "Index:" line with an empty body.
2229
2230 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2231
2232         Remove the REQUEST_ANIMATION_FRAME flag
2233         https://bugs.webkit.org/show_bug.cgi?id=156980
2234         <rdar://problem/25906849>
2235
2236         Reviewed by Simon Fraser.
2237
2238         * Scripts/webkitperl/FeatureList.pm:
2239         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2240
2241 2017-01-15  Sam Weinig  <sam@webkit.org>
2242
2243         Add the ability to use numbers in makeString()
2244         https://bugs.webkit.org/show_bug.cgi?id=167087
2245
2246         Reviewed by Darin Adler.
2247
2248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2249         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2250         Add tests for StringConcatenate, focusing on new numeric additions.
2251
2252 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2253
2254         Unreviewed, remove stale comment.
2255
2256         This test was fixed by r163173.
2257
2258         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2259
2260 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2261
2262         Annotate large string tests with largeHeap
2263         https://bugs.webkit.org/show_bug.cgi?id=167054
2264
2265         Reviewed by Filip Pizlo.
2266
2267         * Scripts/run-javascriptcore-tests:
2268         * Scripts/run-jsc-stress-tests:
2269
2270 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2271
2272         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2273         https://bugs.webkit.org/show_bug.cgi?id=167043
2274
2275         Reviewed by Darin Adler.
2276
2277         * Scripts/webkitperl/FeatureList.pm:
2278
2279 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2280
2281         Remove ENABLE(DETAILS_ELEMENT) guards
2282         https://bugs.webkit.org/show_bug.cgi?id=167042
2283
2284         Reviewed by Alex Christensen.
2285
2286         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2287
2288 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2289
2290         26 MotionMark performance tests failing
2291         https://bugs.webkit.org/show_bug.cgi?id=166854
2292
2293         Reviewed by Ryosuke Niwa.
2294
2295         Unrelated change. This is the last place that we need to rename Animometer
2296         to MotionMark.
2297
2298         * Scripts/webkitpy/common/config/watchlist:
2299
2300 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2301
2302         run-jsc-benchmarks' echo should have -e option
2303         https://bugs.webkit.org/show_bug.cgi?id=167009
2304
2305         Reviewed by Sam Weinig.
2306
2307         echo requires `-e` option to use escape sequence.
2308         Without it, in some environment (in my Fedora 25), the escape sequence is not
2309         recognized and just dumped as `\c` etc.
2310
2311         * Scripts/run-jsc-benchmarks:
2312
2313 2017-01-12  Chris Dumez  <cdumez@apple.com>
2314
2315         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2316         https://bugs.webkit.org/show_bug.cgi?id=166995
2317
2318         Reviewed by Jer Noble.
2319
2320         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2321         as some people are having trouble building without it.
2322
2323         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2324
2325 2017-01-12  Sam Weinig  <sam@webkit.org>
2326
2327         Add the ability to filter the set of bindings tests you want to run
2328         https://bugs.webkit.org/show_bug.cgi?id=166977
2329
2330         Reviewed by Tim Horton.
2331
2332         Allows doing things like:
2333             run-bindings-tests TestObj* TestCEReactions*
2334         
2335         to run only those tests that match the patterns.
2336
2337         * Scripts/run-bindings-tests:
2338         (main):
2339         Switch to using optparse and pass the remaining args as the filters.
2340
2341         * Scripts/webkitpy/bindings/main.py:
2342         (BindingsTests.__init__):
2343         Store the pattens.
2344
2345         (BindingsTests.test_matches_patterns):
2346         Add helper predicate to determine if a test should be run. When no
2347         patterns are present, all tests should run.
2348
2349         (BindingsTests.run_tests):
2350         Filter tests using the passed in patterns.
2351
2352 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2353
2354         Followup fix after r210503.
2355         https://bugs.webkit.org/show_bug.cgi?id=166887
2356
2357         Reviewed by Alex Christensen.
2358
2359         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2360         duplicated file handle on Windows. This patch fixes the remaining call sites.
2361
2362         * DumpRenderTree/PixelDumpSupport.cpp:
2363         * DumpRenderTree/TestRunner.cpp:
2364         (TestRunner::waitToDumpWatchdogTimerFired):
2365         * DumpRenderTree/TestRunner.h:
2366         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2367         * DumpRenderTree/win/DumpRenderTree.cpp:
2368         * DumpRenderTree/win/DumpRenderTreeWin.h:
2369         * DumpRenderTree/win/TestRunnerWin.cpp:
2370         (TestRunner::setSpellCheckerLoggingEnabled):
2371
2372 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2373
2374         Add committer status for Megan
2375         https://bugs.webkit.org/show_bug.cgi?id=166954
2376
2377         Reviewed by Tim Horton.
2378
2379         Add committer status for Megan Gardner
2380
2381         * Scripts/webkitpy/common/config/contributors.json:
2382
2383 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2384
2385         Unreviewed test fix after r210599.
2386
2387         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2388         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2389
2390 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2391
2392         Unreviewed build fix after r210599.
2393
2394         Add missing files.
2395
2396         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2397         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2398
2399 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2400
2401         File scheme should not allow access of a resource on a different volume.
2402         https://bugs.webkit.org/show_bug.cgi?id=158552
2403         <rdar://problem/15307582>
2404
2405         Reviewed by Alex Christensen.
2406
2407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2408         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2409         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2410
2411 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2412
2413         Unreviewed, rolling out r210571.
2414
2415         This change broke the 32-bit macOS build and caused LayoutTest
2416         failures.
2417
2418         Reverted changeset:
2419
2420         "File scheme should not allow access of a resource on a
2421         different volume."
2422         https://bugs.webkit.org/show_bug.cgi?id=158552
2423         http://trac.webkit.org/changeset/210571
2424
2425 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2426
2427         [GTK] install-dependencies script misses gdb
2428         https://bugs.webkit.org/show_bug.cgi?id=166917
2429
2430         Reviewed by Michael Catanzaro.
2431
2432         gdb is needed for generating the crash logs.
2433
2434         * gtk/install-dependencies:
2435
2436 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2437
2438         [GTK] No way for applications to set notification permissions without waiting for permission request
2439         https://bugs.webkit.org/show_bug.cgi?id=163366
2440
2441         Reviewed by Carlos Garcia Campos.
2442
2443         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2444         (testWebViewNotification):
2445         (setInitialNotificationPermissionsAllowedCallback):
2446         (setInitialNotificationPermissionsDisallowedCallback):
2447         (testWebViewNotificationInitialPermissionAllowed):
2448         (testWebViewNotificationInitialPermissionDisallowed):
2449         (beforeAll):
2450         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2451         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2452         (WebViewTest::WebViewTest):
2453         (WebViewTest::initializeWebView):
2454         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2455
2456 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2457
2458         MobileMiniBrowser tests don't work by default
2459         https://bugs.webkit.org/show_bug.cgi?id=166910
2460
2461         Reviewed by Alex Christensen.
2462
2463         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2464         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2465
2466 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2467
2468         File scheme should not allow access of a resource on a different volume.
2469         https://bugs.webkit.org/show_bug.cgi?id=158552
2470         <rdar://problem/15307582>
2471
2472         Reviewed by Alex Christensen.
2473
2474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2475         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2476         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2477
2478 2017-01-10  Mark Lam  <mark.lam@apple.com>
2479
2480         Reverting run-jsc-stress-tests' $buildType to use string values.
2481         https://bugs.webkit.org/show_bug.cgi?id=166912
2482
2483         Rubber stamped by Filip Pizlo.
2484
2485         This is so that we can test for it in the tests e.g.
2486         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2487
2488         * Scripts/run-jsc-stress-tests:
2489
2490 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2491
2492         Temporarily add back the file removed in r210463 to unbreak internal bots.
2493
2494         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2495
2496 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2497
2498         svn-apply failed to apply a patch (deleting file with svn property)
2499         https://bugs.webkit.org/show_bug.cgi?id=165953
2500
2501         Reviewed by Daniel Bates.
2502
2503         * Scripts/VCSUtils.pm:
2504         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2505         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2506
2507 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2508
2509         Update flakiness dashboard configuration.
2510         https://bugs.webkit.org/show_bug.cgi?id=166869
2511
2512         Reviewed by Alexey Proskuryakov.
2513
2514         * TestResultServer/static-dashboards/builders.jsonp:
2515         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2516
2517 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2518
2519         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2520         https://bugs.webkit.org/show_bug.cgi?id=165232
2521
2522         Unreviewed follow-up patch after r210539 and r210523.
2523
2524         Instead of using that environment variable, the argument
2525         --display-server=xorg should be passed now.
2526
2527         The GTK+ performance bot was the only bot using this, and is
2528         already passing --display-server=xorg after r210539.
2529
2530         * Scripts/webkitpy/port/gtk.py:
2531         (GtkPort._driver_class):
2532
2533 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2534
2535         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2536         https://bugs.webkit.org/show_bug.cgi?id=166872
2537
2538         Reviewed by Michael Catanzaro.
2539
2540         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2541         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2542         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2543         The step RunWebKitTests already has support for it.
2544
2545         * BuildSlaveSupport/build.webkit.org-config/config.json:
2546         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2547         (RunGtkAPITests.start):
2548         (RunAndUploadPerfTests.start):
2549         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2550
2551 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2552
2553         Unreviewed, rolling out r210531.
2554
2555         This change broke the 32-bit macOS build and caused LayoutTest
2556         failures.
2557
2558         Reverted changeset:
2559
2560         "File scheme should not allow access of a resource on a
2561         different volume."
2562         https://bugs.webkit.org/show_bug.cgi?id=158552
2563         http://trac.webkit.org/changeset/210531
2564
2565 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2566
2567         File scheme should not allow access of a resource on a different volume.
2568         https://bugs.webkit.org/show_bug.cgi?id=158552
2569         <rdar://problem/15307582>
2570
2571         Reviewed by Alex Christensen.
2572
2573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2574         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2575         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2576
2577 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2578
2579         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2580         https://bugs.webkit.org/show_bug.cgi?id=165232
2581
2582         Reviewed by Michael Catanzaro.
2583
2584         Add a new WaylandDriver to run the tests in the user current wayland session.
2585
2586         Also merge all the configuration options for selecting the display server inside one
2587         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2588
2589         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2590
2591         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2592         (TestRunner._create_driver):
2593         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2594         (parse_args):
2595         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2596         (PerfTestsRunner._parse_args):
2597         * Scripts/webkitpy/port/gtk.py:
2598         (GtkPort.__init__):
2599         (GtkPort._driver_class):
2600         (GtkPort._search_paths):
2601         * Scripts/webkitpy/port/waylanddriver.py: Added.
2602         (WaylandDriver):
2603         (WaylandDriver.check_driver):
2604         (WaylandDriver._setup_environ_for_test):
2605         (WaylandDriver._start):
2606
2607 2017-01-09  Andy Estes  <aestes@apple.com>
2608
2609         [QuickLook] Add a layout test for webkit.org/b/135651
2610         https://bugs.webkit.org/show_bug.cgi?id=166855
2611
2612         Reviewed by Andreas Kling.
2613
2614         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2615         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2616         errors with code WebKitErrorCannotShowURL.
2617         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2618         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2619         not specific to WebKit2 error codes.
2620
2621 2017-01-09  Antoine Quint  <graouts@apple.com>
2622
2623         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2624         https://bugs.webkit.org/show_bug.cgi?id=166837
2625
2626         Reviewed by Alex Christensen.
2627
2628         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2629         the provided value when trying to determine the path to the test file. Failing
2630         that, we use the computed URL or the raw path provided to cover all cases.
2631         
2632         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2633         by applying this patch and seeing the number test failures dramatically reduced
2634         with WK1 due to the option to turn modern media controls off for older media controls
2635         tests.
2636
2637         * DumpRenderTree/DumpRenderTree.h:
2638         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2639         (parseInputLine):
2640         * DumpRenderTree/TestOptions.h:
2641         * DumpRenderTree/TestOptions.mm:
2642         (TestOptions::TestOptions):
2643         * DumpRenderTree/mac/DumpRenderTree.mm:
2644         (runTest):
2645
2646 2017-01-09  Milan Crha  <mcrha@redhat.com>
2647
2648         prepare-ChangeLog: Correct help string for --style option
2649         https://bugs.webkit.org/show_bug.cgi?id=166725
2650
2651         Reviewed by Alexey Proskuryakov.
2652
2653         * Scripts/prepare-ChangeLog:
2654         (main):
2655
2656 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2657
2658         https://bugs.webkit.org/show_bug.cgi?id=166839
2659         Add php7 support for macOS.
2660         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2661
2662         Reviewed by Alexey Proskuryakov.
2663
2664         * Scripts/webkitpy/port/base.py:
2665         (Port._is_darwin_php_version_7):
2666         (Port._debian_php_version):
2667         (Port):
2668         (Port._darwin_php_version):
2669         (Port._apache_config_file_name_for_platform):
2670
2671 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2672
2673         [GTK] Should support key and code properties on keyboard events
2674         https://bugs.webkit.org/show_bug.cgi?id=166759
2675
2676         Reviewed by Carlos Garcia Campos.
2677
2678         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2679         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2680         on tests.
2681
2682 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2683
2684         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2685         https://bugs.webkit.org/show_bug.cgi?id=166760
2686
2687         Reviewed by Darin Adler.
2688
2689         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2690         We can work around that by duplicating and redirecting stdout.
2691
2692         * DumpRenderTree/PixelDumpSupport.cpp:
2693         (dumpWebViewAsPixelsAndCompareWithExpected):
2694         (printPNG):
2695         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2696         (logEventProc):
2697         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2698         (DRTDesktopNotificationPresenter::showDesktopNotification):
2699         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2700         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2701         * DumpRenderTree/win/DumpRenderTree.cpp:
2702         (dumpFrameScrollPosition):
2703         (dumpHistoryItem):
2704         (dumpBackForwardList):
2705         (dump):
2706         (runTest):
2707         (main):
2708         * DumpRenderTree/win/DumpRenderTreeWin.h:
2709         * DumpRenderTree/win/EditingDelegate.cpp:
2710         (EditingDelegate::shouldBeginEditingInDOMRange):
2711         (EditingDelegate::shouldEndEditingInDOMRange):
2712         (EditingDelegate::shouldInsertNode):
2713         (EditingDelegate::shouldInsertText):
2714         (EditingDelegate::shouldDeleteDOMRange):
2715         (EditingDelegate::shouldChangeSelectedDOMRange):
2716         (EditingDelegate::shouldApplyStyle):
2717         (EditingDelegate::shouldChangeTypingStyle):
2718         (EditingDelegate::doPlatformCommand):
2719         (EditingDelegate::webViewDidBeginEditing):
2720         (EditingDelegate::webViewDidChange):
2721         (EditingDelegate::webViewDidEndEditing):
2722         (EditingDelegate::webViewDidChangeTypingStyle):
2723         (EditingDelegate::webViewDidChangeSelection):
2724         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2725         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2726         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2727         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2728         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2729         (FrameLoadDelegate::didCommitLoadForFrame):
2730         (FrameLoadDelegate::didReceiveTitle):
2731         (FrameLoadDelegate::didFinishLoadForFrame):
2732         (FrameLoadDelegate::didFailLoadWithError):
2733         (FrameLoadDelegate::willPerformClientRedirectToURL):
2734         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2735         (FrameLoadDelegate::windowScriptObjectAvailable):
2736         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2737         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2738         (FrameLoadDelegate::didDisplayInsecureContent):
2739         (FrameLoadDelegate::didRunInsecureContent):
2740         (FrameLoadDelegate::webViewProgressFinishedNotification):
2741         * DumpRenderTree/win/HistoryDelegate.cpp:
2742         (HistoryDelegate::didNavigateWithNavigationData):
2743         (HistoryDelegate::didPerformClientRedirectFromURL):
2744         (HistoryDelegate::didPerformServerRedirectFromURL):
2745         (HistoryDelegate::updateHistoryTitle):
2746         (HistoryDelegate::populateVisitedLinksForWebView):
2747         * DumpRenderTree/win/PolicyDelegate.cpp:
2748         (PolicyDelegate::decidePolicyForNavigationAction):
2749         (PolicyDelegate::unableToImplementPolicyWithError):
2750         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2751         (ResourceLoadDelegate::willSendRequest):
2752         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2753         (ResourceLoadDelegate::didReceiveResponse):
2754         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2755         (ResourceLoadDelegate::didFailLoadingWithError):
2756         * DumpRenderTree/win/TestRunnerWin.cpp:
2757         (TestRunner::addDisallowedURL):
2758         (TestRunner::originsWithApplicationCache):
2759         (TestRunner::setStorageDatabaseIdleInterval):
2760         (TestRunner::closeIdleLocalStorageDatabases):
2761         (TestRunner::copyDecodedHostName):
2762         (TestRunner::copyEncodedHostName):
2763         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2764         (TestRunner::isGeolocationProviderActive):
2765         (TestRunner::pathToLocalResource):
2766         (TestRunner::setMockDeviceOrientation):
2767         (TestRunner::setMockGeolocationPosition):
2768         (TestRunner::setMockGeolocationPositionUnavailableError):
2769         (TestRunner::setSpatialNavigationEnabled):
2770         (TestRunner::setAutomaticLinkDetectionEnabled):
2771         (TestRunner::isCommandEnabled):
2772         (TestRunner::authenticateSession):
2773         (TestRunner::addChromeInputField):
2774         (TestRunner::removeChromeInputField):
2775         (TestRunner::focusWebView):
2776         (TestRunner::grantWebNotificationPermission):
2777         (TestRunner::denyWebNotificationPermission):
2778         (TestRunner::removeAllWebNotificationPermissions):
2779         (TestRunner::simulateWebNotificationClick):
2780         (TestRunner::imageCountInGeneralPasteboard):
2781         * DumpRenderTree/win/UIDelegate.cpp:
2782         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2783         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2784         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2785         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2786         (UIDelegate::webViewAddMessageToConsole):
2787         (UIDelegate::exceededDatabaseQuota):
2788         (UIDelegate::setStatusText):
2789         (UIDelegate::didPressMissingPluginButton):
2790
2791 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2792
2793         Add a setting to create editable MiniBrowser windows by default
2794         https://bugs.webkit.org/show_bug.cgi?id=166806
2795
2796         Reviewed by Beth Dakin.
2797
2798         * MiniBrowser/mac/AppDelegate.m:
2799         (-[BrowserAppDelegate createBrowserWindowController:]):
2800         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2801         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2802         * MiniBrowser/mac/SettingsController.h:
2803         * MiniBrowser/mac/SettingsController.m:
2804         (-[SettingsController _populateMenu]):
2805         (-[SettingsController validateMenuItem:]):
2806         (-[SettingsController toggleCreateEditorByDefault:]):
2807         (-[SettingsController createEditorByDefault]):
2808         Add a setting and update the key equivalents accordingly.
2809         Also make sure to make the right kind of window on launch.
2810
2811 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2812
2813         Fix the 32-bit build.
2814
2815         * MiniBrowser/mac/BrowserWindowController.h:
2816         * MiniBrowser/mac/BrowserWindowController.m:
2817
2818 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2819
2820         Fix the 32-bit build.
2821
2822         * MiniBrowser/mac/BrowserWindowController.m:
2823
2824 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2825
2826         Make it possible to drop HTML files on the MiniBrowser icon
2827         https://bugs.webkit.org/show_bug.cgi?id=166802
2828
2829         Reviewed by Simon Fraser.
2830
2831         * MiniBrowser/mac/AppDelegate.m:
2832         (-[BrowserAppDelegate application:openFile:]):
2833         * MiniBrowser/mac/Info.plist:
2834         If you're using an editable window, the usual trick of dropping on the
2835         window doesn't work anymore (it makes an <attachment> instead).
2836
2837 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2838
2839         MiniBrowser window gets smaller each time it is instantiated
2840         https://bugs.webkit.org/show_bug.cgi?id=166807
2841
2842         Reviewed by Andy Estes.
2843
2844         * MiniBrowser/mac/BrowserWindowController.m:
2845         (-[BrowserWindowController windowDidLoad]):
2846         * MiniBrowser/mac/BrowserWindow.xib:
2847         Turn on full-window content view support with IB, instead of waiting
2848         until after the views have been loaded. This seems to resolve the
2849         longstanding ever-shrinking-window problem.
2850
2851 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2852
2853         Add indent/outdent items to MiniBrowser's new format menu
2854         https://bugs.webkit.org/show_bug.cgi?id=166805
2855
2856         Reviewed by Dan Bernstein.
2857
2858         * MiniBrowser/mac/MainMenu.xib:
2859
2860 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2861
2862         Add a stock Format menu to MiniBrowser
2863         https://bugs.webkit.org/show_bug.cgi?id=166804
2864
2865         Reviewed by Andy Estes.
2866
2867         * MiniBrowser/mac/MainMenu.xib:
2868         Many of the features automatically work with editable web views.
2869         However, this seems to expose a bug where none of the font-related features
2870         (Cmd-B, for example) work until the first time the font panel is shown,
2871         per process, which will need to be investigated separately.
2872
2873 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2874
2875         Remove unused applicationWillTerminate methods from MiniBrowser
2876         https://bugs.webkit.org/show_bug.cgi?id=166803
2877
2878         Reviewed by Andy Estes.
2879
2880         * MiniBrowser/mac/AppDelegate.m:
2881         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2882         * MiniBrowser/mac/BrowserWindowController.h:
2883         * MiniBrowser/mac/BrowserWindowController.m:
2884         (-[BrowserWindowController applicationTerminating]): Deleted.
2885         * MiniBrowser/mac/WK1BrowserWindowController.m:
2886         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2887         * MiniBrowser/mac/WK2BrowserWindowController.m:
2888         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2889
2890 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2891
2892         Add the ability to create empty contentEditable windows in MiniBrowser
2893         https://bugs.webkit.org/show_bug.cgi?id=166801
2894
2895         Reviewed by Wenson Hsieh.
2896
2897         * MiniBrowser/mac/AppDelegate.h:
2898         * MiniBrowser/mac/AppDelegate.m:
2899         (-[BrowserAppDelegate createBrowserWindowController:]):
2900         (-[BrowserAppDelegate newWindow:]):
2901         (-[BrowserAppDelegate newEditorWindow:]):
2902         (-[BrowserAppDelegate openDocument:]):
2903         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2904         * MiniBrowser/mac/BrowserWindowController.h:
2905         * MiniBrowser/mac/BrowserWindowController.m:
2906         (-[BrowserWindowController loadHTMLString:]):
2907         (-[BrowserWindowController toggleEditable:]):
2908         * MiniBrowser/mac/MainMenu.xib:
2909         * MiniBrowser/mac/WK1BrowserWindowController.m:
2910         (-[WK1BrowserWindowController awakeFromNib]):
2911         (-[WK1BrowserWindowController loadHTMLString:]):
2912         (-[WK1BrowserWindowController validateMenuItem:]):
2913         (-[WK1BrowserWindowController setEditable:]):
2914         (-[WK1BrowserWindowController updateTitle:]):
2915         * MiniBrowser/mac/WK2BrowserWindowController.m:
2916         (-[WK2BrowserWindowController awakeFromNib]):
2917         (-[WK2BrowserWindowController validateMenuItem:]):
2918         (-[WK2BrowserWindowController setEditable:]):
2919         (-[WK2BrowserWindowController updateTitle:]):
2920         (-[WK2BrowserWindowController loadHTMLString:]):
2921         Merge more functionality from WebEditingTester.
2922         Add two menu items for creating empty editable WebKit1/2 windows.
2923         Add a menu item to the Edit menu to toggle editability on any window.
2924
2925 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2926
2927         Implement find-in-page in MiniBrowser
2928         https://bugs.webkit.org/show_bug.cgi?id=166799
2929
2930         Reviewed by Andy Estes.
2931
2932         * MiniBrowser/mac/BrowserWindow.xib:
2933         * MiniBrowser/mac/BrowserWindowController.h:
2934         * MiniBrowser/mac/BrowserWindowController.m:
2935         (-[BrowserWindowController find:]): Deleted.
2936         * MiniBrowser/mac/MainMenu.xib:
2937         * MiniBrowser/mac/WK1BrowserWindowController.m:
2938         (-[WK1BrowserWindowController toggleShrinkToFit:]):
2939         (-[WK1BrowserWindowController find:]): Deleted.
2940         * MiniBrowser/mac/WK2BrowserWindowController.m:
2941         (-[WK2BrowserWindowController awakeFromNib]):
2942         (-[WK2BrowserWindowController dealloc]):
2943         (-[WK2BrowserWindowController validateMenuItem:]):
2944         (-[WK2BrowserWindowController performTextFinderAction:]):
2945         (-[WK2BrowserWindowController findBarView]):
2946         (-[WK2BrowserWindowController setFindBarView:]):
2947         (-[WK2BrowserWindowController isFindBarVisible]):
2948         (-[WK2BrowserWindowController setFindBarVisible:]):
2949         (-[WK2BrowserWindowController contentView]):
2950         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
2951         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
2952         (-[WK2BrowserWindowController find:]): Deleted.
2953         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
2954         protocol. At first glance, it's pretty broken, but vaguely works.
2955
2956 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2957
2958         Share the implementation of MiniBrowser view hiding functionality
2959         https://bugs.webkit.org/show_bug.cgi?id=166800
2960
2961         Reviewed by Andy Estes.
2962
2963         * MiniBrowser/mac/BrowserWindowController.m:
2964         (-[BrowserWindowController showHideWebView:]):
2965         (-[BrowserWindowController removeReinsertWebView:]):
2966         * MiniBrowser/mac/WK1BrowserWindowController.m:
2967         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
2968         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
2969         * MiniBrowser/mac/WK2BrowserWindowController.m:
2970         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
2971         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
2972         Move the implementation of these two things to the shared superclass,
2973         since they don't depend on WebKit-specific things.
2974         Also, there was no reason to retain the (WK)WebView while it was unparented,
2975         as the BrowserWindowController maintains a reference the entire time.
2976
2977 2017-01-06  Andy Estes  <aestes@apple.com>
2978
2979         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
2980         https://bugs.webkit.org/show_bug.cgi?id=166789
2981
2982         Reviewed by Alex Christensen.
2983
2984         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2985         * DumpRenderTree/PlatformMac.cmake:
2986         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
2987         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
2988         * DumpRenderTree/mac/DumpRenderTree.mm:
2989         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2990         createXMLStringFromWebArchiveData().
2991         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
2992         * WebKitTestRunner/Configurations/Base.xcconfig:
2993         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
2994         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2995         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2996         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2997         createXMLStringFromWebArchiveData().
2998         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
2999         * WebKitTestRunner/PlatformMac.cmake:
3000         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3001         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
3002
3003 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3004
3005         Minor cleanups to IndentOutdentCommand and related code
3006         https://bugs.webkit.org/show_bug.cgi?id=166791
3007
3008         Reviewed by Simon Fraser.
3009
3010         * WebEditingTester/EditingOperations.m:
3011         (editingOperations):
3012         Add the outdent operation to WebEditingTester.
3013
3014 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3015
3016         Create a plan and a patch files for MotionMark and delete the Animometer's ones
3017         https://bugs.webkit.org/show_bug.cgi?id=166785
3018
3019         Reviewed by Ryosuke Niwa.
3020
3021         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3022         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
3023
3024 2017-01-06  Antoine Quint  <graouts@apple.com>
3025
3026         Support webkit-test-runner key-value pairs in http tests
3027         https://bugs.webkit.org/show_bug.cgi?id=149812
3028
3029         Reviewed by Alex Christensen.
3030
3031         We pass the absolute path for a test through to WKTR so that we can parse
3032         tests that are running as URLs for webkit-test-runner options.
3033
3034         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3035         (parseInputLine):
3036
3037         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3038
3039         * Scripts/webkitpy/port/driver.py:
3040         (Driver._command_from_driver_input):
3041
3042         Pass the absolute path to the file through the CLI.
3043
3044         * WebKitTestRunner/TestController.cpp:
3045         (WTR::updateTestOptionsFromTestHeader):
3046         (WTR::TestController::testOptionsForTest):
3047         (WTR::parseInputLine):
3048         (WTR::TestController::runTest):
3049         * WebKitTestRunner/TestController.h:
3050
3051 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3052
3053         Warning about unconnectable outlets when opening a MiniBrowser window
3054         https://bugs.webkit.org/show_bug.cgi?id=166756
3055
3056         Reviewed by Dan Bernstein.
3057
3058         * MiniBrowser/mac/BrowserWindow.xib:
3059         When launching MiniBrowser, it says:
3060         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3061             (MBToolbarItem): missing setter or instance variable
3062         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3063             (NSButtonCell): missing setter or instance variable.
3064
3065         It looks like someone added the connection from the share button
3066         to the BrowserWindowController three times; only one of the connections
3067         is valid. Remove the other two.
3068
3069 2017-01-05  Keith Rollin  <krollin@apple.com>
3070
3071         Add WebCore::URL::protocolHostAndPort
3072         https://bugs.webkit.org/show_bug.cgi?id=166426
3073
3074         Reviewed by Alex Christensen.
3075
3076         Add test for protocolHostAndPort.
3077
3078         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3079         (TestWebKitAPI::TEST_F):
3080
3081 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3082
3083         [Win] Archive test result is failing.
3084         https://bugs.webkit.org/show_bug.cgi?id=166720
3085
3086         Reviewed by Alex Christensen.
3087
3088         Deleting the layout test result folder is sometimes failing
3089         on Windows. This is not a critical error.
3090
3091         * BuildSlaveSupport/test-result-archive:
3092         (archiveTestResults):
3093
3094 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3095
3096         [GTK] Minibrowser: Add printing support
3097         https://bugs.webkit.org/show_bug.cgi?id=165298
3098
3099         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3100         an error during the print, it's printed on the console.
3101
3102         Reviewed by Michael Catanzaro.
3103
3104         * MiniBrowser/gtk/BrowserWindow.c:
3105         (webKitPrintOperationFailedCallback):
3106         (printPage):
3107         (browser_window_init):
3108
3109 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3110
3111         [css-grid] Fix crash clamping grid lines
3112         https://bugs.webkit.org/show_bug.cgi?id=166637
3113
3114         Reviewed by Darin Adler.
3115
3116         Creates new unit test to verify that the maximum tracks limit
3117         is used in GridPosition too.
3118
3119         * TestWebKitAPI/PlatformEfl.cmake:
3120         * TestWebKitAPI/PlatformGTK.cmake:
3121         * TestWebKitAPI/PlatformWin.cmake:
3122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3123         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3124         (TestWebKitAPI::TEST):
3125
3126 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3127
3128         Move editing history scripts to WebCore PrivateHeaders
3129         https://bugs.webkit.org/show_bug.cgi?id=166709
3130         <rdar://problem/29876612>
3131
3132         Reviewed by Dan Bernstein.
3133
3134         Update references to editing script files in WebCore that were moved.
3135
3136         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3137
3138 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3139
3140         Unreviewed, build fix after r210313 part 2
3141         https://bugs.webkit.org/show_bug.cgi?id=166676
3142
3143         Add 'U' suffix.
3144
3145         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3146         (TestWebKitAPI::TEST):
3147         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3148         (TestWebKitAPI::TEST):
3149
3150 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3151
3152         Limit thread name appropriately
3153         https://bugs.webkit.org/show_bug.cgi?id=166676
3154
3155         Reviewed by Sam Weinig.
3156
3157         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3158         (TestWebKitAPI::TEST):
3159         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3160         (TestWebKitAPI::TEST):
3161
3162 2017-01-04  Andy Estes  <aestes@apple.com>
3163
3164         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3165         https://bugs.webkit.org/show_bug.cgi?id=166696
3166
3167         Reviewed by Tim Horton.
3168
3169         * TestWebKitAPI/PlatformGTK.cmake:
3170         * TestWebKitAPI/PlatformWin.cmake:
3171         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3172         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3173         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3174         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3175         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3176         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3177         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3178
3179 2017-01-03  Brian Burg  <bburg@apple.com>
3180
3181         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3182         https://bugs.webkit.org/show_bug.cgi?id=166003
3183         <rdar://problem/28718990>
3184
3185         Reviewed by Joseph Pecoraro.
3186
3187         Teach run-inspector-generator-tests to generate test output using the platform name
3188         derived from the directory that the test is in. For example, tests in the /generic/
3189         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3190
3191         * Scripts/webkitpy/inspector/main.py:
3192         (InspectorGeneratorTests.generate_from_json):
3193         (InspectorGeneratorTests.run_tests):
3194         (InspectorGeneratorTests.main):
3195
3196 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3197
3198         Unreviewed cmake buildfix after r210266.
3199
3200         * DumpRenderTree/PlatformMac.cmake:
3201
3202 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3203
3204         Provide a setting for clients to always prefer low-power WebGL
3205         https://bugs.webkit.org/show_bug.cgi?id=166675
3206         <rdar://problem/29834093>
3207
3208         Reviewed by Dan Bernstein.
3209
3210         * MiniBrowser/mac/Info.plist:
3211         Have MiniBrowser claim to be a modern app that supports
3212         automatic graphics switching. WebKit needs to support automatic
3213         graphics switching, so our test app might as well. Without this
3214         Info.plist parameter, this change has no effect, and bringing up
3215         a WebGL context still brings up the discrete GPU (also true of the
3216         existing web-exposed preferLowPowerToHighPerformance API).
3217
3218 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3219
3220         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3221         https://bugs.webkit.org/show_bug.cgi?id=166645
3222
3223         Reviewed by Carlos Garcia Campos.
3224
3225         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3226         (TestWebKitAPI::TEST):
3227
3228 2017-01-03  Andy Estes  <aestes@apple.com>
3229
3230         Place all the Cocoa WebCore API tests in the same directory
3231         https://bugs.webkit.org/show_bug.cgi?id=166673
3232
3233         Reviewed by Michael Catanzaro.
3234
3235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3236         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3237         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3238         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3239
3240 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3241
3242         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3243         https://bugs.webkit.org/show_bug.cgi?id=166450
3244         <rdar://problem/29447824>
3245
3246         Reviewed by Darin Adler.
3247
3248         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3249         * DumpRenderTree/TestRunner.cpp:
3250         (TestRunner::staticFunctions):
3251         * DumpRenderTree/mac/TestRunnerMac.mm:
3252         (setSpellCheckerLoggingEnabledCallback):
3253         * DumpRenderTree/win/TestRunnerWin.cpp:
3254         (setSpellCheckerLoggingEnabledCallback):
3255         * DumpRenderTree/mac/DumpRenderTree.mm:
3256         (resetWebViewToConsistentStateBeforeTesting):
3257         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3258         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3259         (stringForCorrectionResponse):
3260         (drt_NSSpellChecker_recordResponseToCorrection):
3261         (swizzleNSSpellCheckerMethodsIfNeeded):
3262         (setSpellCheckerLoggingEnabled):
3263         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3264         set to true, logs to stdout (which ends up in the test result) whenever
3265         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3266         is called, and then calls the original method. It is reset to false between tests.
3267
3268 2017-01-03  Sam Weinig  <sam@webkit.org>
3269
3270         Make WTF::Expected support Ref template parameters
3271         https://bugs.webkit.org/show_bug.cgi?id=166662
3272
3273         Reviewed by Alex Christensen.
3274
3275         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3276         (TestWebKitAPI::TEST):
3277         Add tests for using Ref with Expected.
3278
3279 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3280
3281         [GTK] Expose WebKitSecurityOrigin API
3282         https://bugs.webkit.org/show_bug.cgi?id=166632
3283
3284         Reviewed by Carlos Garcia Campos.
3285
3286         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3287         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3288         (testSecurityOriginBasicConstructor):
3289         (testSecurityOriginURIConstructor):
3290         (testSecurityOriginDefaultPort):
3291         (testSecurityOriginFileURI):
3292         (testSecurityOriginDataURI):
3293         (beforeAll):
3294         (afterAll):
3295
3296 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3297
3298         [GTK] HTTP auth layout tests are flaky
3299         https://bugs.webkit.org/show_bug.cgi?id=158919
3300
3301         Reviewed by Michael Catanzaro.
3302
3303         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3304         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3305         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3306         missing valac in the bots.
3307
3308 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3309
3310         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3311         https://bugs.webkit.org/show_bug.cgi?id=165797
3312
3313         Reviewed by Michael Catanzaro.
3314
3315         Move directory ruleset after all exclude rules of Source rulset.
3316
3317         * gtk/manifest.txt.in:
3318
3319 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3320
3321         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3322         https://bugs.webkit.org/show_bug.cgi?id=166636
3323
3324         Reviewed by Darin Adler.
3325
3326         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3327         (TestWebKitAPI::TEST):
3328
3329 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3330
3331         [GTK] WebCore/CSSParser unit test is not being built
3332         https://bugs.webkit.org/show_bug.cgi?id=166492
3333
3334         Reviewed by Michael Catanzaro.
3335
3336         This test was introduced in r175930, but we were not building
3337         it on GTK+ port since r176015.
3338         This patch marks the test to be built again on GTK+.
3339         JFTR, the test is passing right now.
3340
3341         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3342         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3343
3344 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3345
3346         AX: Expose block quote level to iOS API
3347         https://bugs.webkit.org/show_bug.cgi?id=166629
3348         <rdar://problem/29834793>
3349
3350         Reviewed by Darin Adler.
3351
3352         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3353         (AccessibilityUIElement::numberAttributeValue):
3354         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3355         (WTR::AccessibilityUIElement::numberAttributeValue):
3356
3357 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3358
3359         SecurityOrigin::create triplet constructor does not canonicalize port
3360         https://bugs.webkit.org/show_bug.cgi?id=166624
3361
3362         Reviewed by Daniel Bates.
3363
3364         * TestWebKitAPI/PlatformGTK.cmake:
3365         * TestWebKitAPI/PlatformWin.cmake:
3366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3367         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3368         (TestWebKitAPI::SecurityOriginTest::SetUp):
3369         (TestWebKitAPI::TEST_F):
3370
3371 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3372
3373         [GTK] Improve user agent construction
3374         https://bugs.webkit.org/show_bug.cgi?id=142074
3375
3376         Reviewed by Carlos Garcia Campos.
3377
3378         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3379         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3380         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3381         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3382         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3383         (TestWebKitAPI::TEST):
3384
3385 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3386
3387         [GTK] Improve user agent construction
3388         https://bugs.webkit.org/show_bug.cgi?id=142074
3389
3390         Reviewed by Carlos Garcia Campos.
3391
3392         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3393         (TestWebKitAPI::TEST):
3394
3395 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3396
3397         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3398         https://bugs.webkit.org/show_bug.cgi?id=166472
3399         rdar://problem/29675551
3400
3401         Reviewed by Tim Horton.
3402
3403         These changes are necessary to allow the mouse to leave the WTR window while
3404         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3405         (which DRT does); we'd always go through mouseMoved, which hits an early return
3406         in WebViewImpl::mouseMoved() when the point is outside the view.
3407
3408         * WebKitTestRunner/mac/EventSenderProxy.mm:
3409         (WTR::EventSenderProxy::mouseMoveTo):
3410
3411 2016-12-23  Andy Estes  <aestes@apple.com>
3412
3413         [iOS] Fix some crashing webarchive tests
3414         https://bugs.webkit.org/show_bug.cgi?id=166470
3415
3416         Reviewed by Andreas Kling.
3417
3418         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3419         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3420         so this change uses that on both platforms.
3421
3422         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3423         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3424         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3425         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3426         * WebKitTestRunner/PlatformMac.cmake:
3427         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3428         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3429
3430 2016-12-22  Saam Barati  <sbarati@apple.com>
3431
3432         WebAssembly: Silence the output of the spec-tests
3433         https://bugs.webkit.org/show_bug.cgi?id=166417
3434
3435         Reviewed by Mark Lam.
3436
3437         * Scripts/run-jsc-stress-tests:
3438
3439 2016-12-22  Zhuo Li  <zachli@apple.com>
3440
3441         [Cocoa] SPI for setloadsImagesAutomatically.
3442         https://bugs.webkit.org/show_bug.cgi?id=166401.
3443
3444         Reviewed by Darin Adler.
3445
3446         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3447         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3448         _loadsImagesAutomatically returns YES.
3449
3450 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3451
3452         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3453         https://bugs.webkit.org/show_bug.cgi?id=161328
3454         <rdar://problem/28475977>
3455
3456         Reviewed by Darin Adler.
3457
3458         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3459         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3460         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3461         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3462         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3463         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3464         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3465         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3466         we finish running a test and before we load the next test.
3467
3468         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3469         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3470         previous test started zooming and then finished before zooming completed. Since this happens before the next
3471         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3472
3473         * WebKitTestRunner/ios/TestControllerIOS.mm:
3474         (WTR::TestController::platformResetStateToConsistentValues):
3475
3476 2016-12-22  Jer Noble  <jer.noble@apple.com>
3477
3478         Muted media element playback should not interrupt other audio playback
3479         https://bugs.webkit.org/show_bug.cgi?id=166347
3480
3481         Reviewed by Eric Carlson.
3482
3483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3484         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3485         (TestWebKitAPI::TEST):
3486         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3487
3488 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3489
3490         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3491         https://bugs.webkit.org/show_bug.cgi?id=166346
3492
3493         Reviewed by Carlos Garcia Campos.
3494
3495         Enable WebRTC by default to simplify testing.
3496
3497         * MiniBrowser/gtk/main.c:
3498         (main):
3499
3500 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3501
3502         REGRESSION: API test failure: WKWebView.LocalStorageClear
3503         https://bugs.webkit.org/show_bug.cgi?id=166032
3504         <rdar://problem/29758423>
3505
3506         Reviewed by Simon Fraser.
3507
3508         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3509         to ensure that the view is destroyed before the callback fires.
3510
3511         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3512         (TEST):
3513
3514 2016-12-21  Saam Barati  <sbarati@apple.com>
3515
3516         WebAssembly: Import spec tests
3517         https://bugs.webkit.org/show_bug.cgi?id=166395
3518
3519         Rubber stamped by Keith Miller.
3520
3521         * Scripts/run-jsc-stress-tests:
3522
3523 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3524
3525         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3526         https://bugs.webkit.org/show_bug.cgi?id=166033
3527         <rdar://problem/29758428>
3528
3529         Reviewed by Simon Fraser.
3530
3531         Add an @autoreleasepool around the code that allocates the WKWebView, 
3532         so that it can be destroyed by removing the last reference in _downloadDidStart.
3533
3534         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3535         (TEST):
3536
3537 2016-12-21  Daniel Bates  <dabates@apple.com>
3538
3539         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3540         https://bugs.webkit.org/show_bug.cgi?id=166356
3541
3542         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3543         as a means to allow a test to explicit allow an embedding client to open a new windows
3544         such that the default behavior is for the embedding client to forbid such an action.
3545         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3546         it is currently skipped on WebKit2 because questions were raised in the patch for
3547         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3548         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3549         this test.
3550
3551         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3552         (WTR::TestRunner::setCanOpenWindows):
3553
3554 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3555
3556         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3557         https://bugs.webkit.org/show_bug.cgi?id=166031
3558
3559         Reviewed by Tim Horton.
3560         
3561         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3562         to ensure that the view is destroyed before the callback fires.
3563
3564         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3565
3566 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3567
3568         Throw Exception when test doesn't clean up HID Events properly
3569         https://bugs.webkit.org/show_bug.cgi?id=166271
3570
3571         Reviewed by Simon Fraser.
3572
3573         Add in a check when UIScriptController is deleted to make sure that the HID event
3574         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3575         the program to crash without any good information. Crashes are race-y, and will still
3576         happen with malformed test, but the information will be much more helpful. 
3577
3578         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3579         (WTR::UIScriptController::checkForClean):
3580         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3581         (UIScriptContext::~UIScriptContext):
3582         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3583         (WTR::UIScriptController::checkForClean):
3584         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3585         * WebKitTestRunner/ios/HIDEventGenerator.h:
3586         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3587         (-[HIDEventGenerator checkHIDCallbacksClear]):
3588         * WebKitTestRunner/ios/TestControllerIOS.mm:
3589         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3590         (WTR::UIScriptController::checkForClean):
3591
3592 2016-12-20  Andy Estes  <aestes@apple.com>
3593
3594         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3595         https://bugs.webkit.org/show_bug.cgi?id=165992
3596
3597         Reviewed by Brady Eidson.
3598
3599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3600         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3601         (expectException):
3602         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3603         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3604         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3605         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3606         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3607         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3608         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3609         (TEST):
3610         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3611
3612 2016-12-20  Dean Jackson  <dino@apple.com>
3613
3614         Remove INDIE_UI
3615         https://bugs.webkit.org/show_bug.cgi?id=165881
3616         <rdar://problem/29672532>
3617
3618         Reviewed by Simon Fraser.
3619
3620         The Indie UI work has been discontinued.
3621
3622         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3623
3624 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3625
3626         [ES6] Enable ES6 Modules
3627         https://bugs.webkit.org/show_bug.cgi?id=165849
3628
3629         Reviewed by Geoffrey Garen.
3630
3631         * DumpRenderTree/mac/DumpRenderTree.mm:
3632         (resetWebPreferencesToConsistentValues):
3633         * DumpRenderTree/win/DumpRenderTree.cpp:
3634         (resetWebPreferencesToConsistentValues):
3635         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3636         (WTR::InjectedBundle::beginTesting):
3637         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3638         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3639         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3640
3641 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3642
3643         Repurpose bots and clean up dashboard.
3644         https://bugs.webkit.org/show_bug.cgi?id=166045
3645
3646         Reviewed by Lucas Forschler.
3647
3648         * BuildSlaveSupport/build.webkit.org-config/config.json:
3649         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3650         (BubbleQueueServer):
3651         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3653         (WebKitBuildbot):
3654         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3655         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3656
3657 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3658
3659         [CMake] TestWebKitAPIBase links to itself
3660         https://bugs.webkit.org/show_bug.cgi?id=165985
3661
3662         Reviewed by Alex Christensen.
3663
3664         Fix CMake warning about a target linking to itself, which makes no sense.
3665
3666         * TestWebKitAPI/CMakeLists.txt:
3667
3668 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3669
3670         [GTK] GtkDoc build should be quieter
3671         https://bugs.webkit.org/show_bug.cgi?id=165994
3672
3673         Reviewed by Carlos Garcia Campos.
3674
3675         Make it not print by default.
3676
3677         * gtk/generate-gtkdoc:
3678         (get_generator_for_config):
3679         (generate_doc):
3680         * gtk/gtkdoc.py:
3681         (GTKDoc._run_command):
3682         (GTKDoc._copy_doc_files_to_output_dir):
3683
3684 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3685
3686         Expose a way for MiniBrowser to simulate header and footer banners
3687         https://bugs.webkit.org/show_bug.cgi?id=166005
3688
3689         Reviewed by Wenson Hsieh.
3690         
3691         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3692         banners. This only works in WebKit2.
3693         
3694         We need to reset these on each navigation, since newly created FrameViews
3695         don't re-fetch the header and footer height stored on Page.
3696         
3697         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3698         as well as fixing webViewWebContentProcessDidTerminate:
3699
3700         * MiniBrowser/mac/SettingsController.h:
3701         * MiniBrowser/mac/SettingsController.m:
3702         (-[SettingsController _populateMenu]):
3703         (-[SettingsController validateMenuItem:]):
3704         (-[SettingsController toggleReserveSpaceForBanners:]):
3705         (-[SettingsController isSpaceReservedForBanners]):
3706         * MiniBrowser/mac/WK2BrowserWindowController.m:
3707         (-[WK2BrowserWindowController didChangeSettings]):
3708         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3709         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3710         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3711         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3712
3713 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3714
3715         Fix iOS test results after r209967.
3716         
3717         Subtracting out the status bar height was erroneously happening for all tests,
3718         not just for flexible viewport tests.
3719         
3720         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3721
3722         * WebKitTestRunner/PlatformWebView.h:
3723         * WebKitTestRunner/TestController.cpp:
3724         (WTR::TestController::resetStateToConsistentValues):
3725         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3726         (WTR::PlatformWebView::resizeTo):
3727         (WTR::PlatformWebView::setWindowFrame):
3728         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3729         (WTR::PlatformWebView::resizeTo):
3730         (WTR::PlatformWebView::setWindowFrame):
3731         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3732         (WTR::PlatformWebView::resizeTo):
3733         (WTR::PlatformWebView::setWindowFrame):
3734         * WebKitTestRunner/ios/TestControllerIOS.mm:
3735         (WTR::TestController::platformConfigureViewForTest):
3736         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3737         (WTR::PlatformWebView::resizeTo):
3738         (WTR::PlatformWebView::setWindowFrame):
3739
3740 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3741
3742         [EFL] bump EFL version to 1.18.4
3743         https://bugs.webkit.org/show_bug.cgi?id=166004
3744
3745         Reviewed by Gyuyoung Kim.
3746
3747         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3748
3749 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3750
3751         Visual viewports: bottom fixed elements disappear behind the keyboard
3752         https://bugs.webkit.org/show_bug.cgi?id=165983
3753         <rdar://problem/29409852>
3754
3755         Reviewed by Simon Fraser.
3756
3757         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3758         the keyboard when it is up.
3759
3760         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3761         (WTR::UIScriptController::inputViewBounds):
3762         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3763         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3764         (WTR::UIScriptController::inputViewBounds):
3765         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3766         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3767         (WTR::viewRectForWindowRect):
3768
3769         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3770         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3771         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3772
3773         (WTR::PlatformWebView::PlatformWebView):
3774         (WTR::PlatformWebView::setWindowFrame):
3775         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3776         (WTR::UIScriptController::inputViewBounds):
3777
3778 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3779
3780         Deleting a character converted from pinyin after an image causes a Safari crash
3781         https://bugs.webkit.org/show_bug.cgi?id=165839
3782         <rdar://problem/27951933>
3783
3784         Reviewed by Wenson Hsieh.
3785
3786         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
3787         while the proposed range contains an image. This should not cause a WebProcess to crash
3788         or send an invalid message to the UIProcess.
3789
3790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3791         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
3792         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
3793         (TestWebKitAPI::didFinishLoadForFrame):
3794         (TestWebKitAPI::processDidCrash):
3795         (TestWebKitAPI::invalidMessageFunction):
3796         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
3797
3798 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3799
3800         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3801         https://bugs.webkit.org/show_bug.cgi?id=165767
3802         <rdar://problem/29602382>
3803
3804         Reviewed by Simon Fraser.
3805
3806         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3807         WebKit2 ChangeLog for more details.
3808
3809         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3810         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3811         (WTR::UIScriptController::textSelectionCaretRect):
3812         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3813         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3814         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3815         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3816         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3817         (WTR::UIScriptController::textSelectionCaretRect):
3818         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3819         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3820         (-[TestRunnerWKWebView _setStableStateOverride:]):
3821
3822         Force the WKWebView to update its visible content rects when changing the stable state override.
3823
3824         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3825         (WTR::toNSDictionary):
3826         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3827         (WTR::UIScriptController::selectionRangeViewRects):
3828         (WTR::UIScriptController::textSelectionCaretRect):
3829         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3830         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3831
3832 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3833
3834         Arguments called in wrong order
3835         https://bugs.webkit.org/show_bug.cgi?id=165923
3836
3837         Reviewed by Simon Fraser.
3838
3839         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3840         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3841
3842         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3843         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3844         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3845
3846 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3847
3848         [EFL] Disable non-srcdir builds for failing libraries
3849         https://bugs.webkit.org/show_bug.cgi?id=165896
3850
3851         Reviewed by Gyuyoung Kim.
3852
3853         * efl/jhbuild.modules: Set non srcdir builds to no
3854
3855 2016-12-15  Daniel Bates  <dabates@apple.com>
3856
3857         check-style should not complain about code in icu directories
3858         https://bugs.webkit.org/show_bug.cgi?id=53929
3859
3860         Reviewed by Darin Adler.
3861
3862         Skip style checking of imported ICU headers to avoid a deluge of style issues
3863         as they do not conform to the WebKit Code Style guideline. We want to preserve
3864         the formatting of these headers so as to make it straightforward to merge
3865         changes to them, if necessary.
3866
3867         * Scripts/webkitpy/style/checker.py:
3868
3869 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3870
3871         Move JSC testers from Yosemite to Sierra
3872         https://bugs.webkit.org/show_bug.cgi?id=165925
3873
3874         Reviewed by Lucas Forschler.
3875
3876         * BuildSlaveSupport/build.webkit.org-config/config.json:
3877         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3878         (WebKitBuildbot):
3879
3880 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3881
3882         Add coordinate space to event streams and streamline tests
3883         https://bugs.webkit.org/show_bug.cgi?id=165119
3884
3885         Reviewed by Simon Fraser.
3886
3887         Update event streams to allow for both content and global coordinate space.
3888         Update example script to more accurately show all the available options.
3889
3890         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3891         * WebKitTestRunner/ios/HIDEventGenerator.h:
3892         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3893         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3894         (WTR::convertCoordinates):
3895         (WTR::UIScriptController::sendEventStream):
3896
3897 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
3898
3899         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
3900         https://bugs.webkit.org/show_bug.cgi?id=165855
3901
3902         Reviewed by Philippe Normand.
3903
3904         GStreamer's autogen.sh enables gtk-doc always so we end up building
3905         docs even if we disable them. Use the configure script instead, since
3906         we build from packages and these include it already.
3907
3908         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
3909         upstream gstreamer packages.
3910
3911 2016-12-15  Alex Christensen  <achristensen@webkit.org>
3912
3913         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
3914         https://bugs.webkit.org/show_bug.cgi?id=165885
3915         <rdar://problem/29476917>
3916
3917         Reviewed by Darin Adler.
3918
3919         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3920         (TestWebKitAPI::utf16String): Deleted.
3921         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3922         (TestWebKitAPI::TEST_F):
3923         * TestWebKitAPI/WTFStringUtilities.h:
3924         (utf16String):
3925         Moved from URLParser to share with other tests.
3926
3927 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3928
3929         iOS: An element with tabindex is not focusable unless there is no mouse event handler
3930         https://bugs.webkit.org/show_bug.cgi?id=165843
3931
3932         Reviewed by Antti Koivisto.
3933
3934         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
3935         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
3936         and DumpRenderTree's runUIScript would hit an assertion :(
3937
3938         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3939         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3940         (WTR::TestRunner::isWebKit2):
3941
3942 2016-12-14  Brady Eidson  <beidson@apple.com>
3943
3944         IndexedDB 2.0: Massively speedup IDBIndex.get().
3945         https://bugs.webkit.org/show_bug.cgi?id=165802
3946
3947         Reviewed by Alex Christensen.
3948
3949         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3950         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
3951         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
3952         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
3953         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
3954
3955 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3956
3957         [GTK][EFL] Update the JHBuild version.
3958         https://bugs.webkit.org/show_bug.cgi?id=165838
3959
3960         Reviewed by Michael Catanzaro.
3961
3962         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
3963         usage of the JHBUILD_MIRROR feature with git repositories.
3964
3965 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3966
3967         [GTK] Yasm is needed for building the JHBuild after r208940
3968         https://bugs.webkit.org/show_bug.cgi?id=165837
3969
3970         Reviewed by Alejandro G. Castro.
3971
3972         * gtk/install-dependencies: Yasm is needed for building libvpx.
3973
3974 2016-12-14  Youenn Fablet  <youenn@apple.com>
3975
3976         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
3977         https://bugs.webkit.org/show_bug.cgi?id=161310
3978
3979         Reviewed by Ryosuke Niwa.
3980
3981         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
3982         When set, WTR and DRT output JS console log in the stderr and not the test output.
3983         This allows removing potentially flaky information while still being able to read it for investigation.
3984
3985         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
3986
3987         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
3988         This test should have this option when fetch API will start logging resource loader errors.
3989
3990         * DumpRenderTree/DumpRenderTree.h:
3991         (TestCommand::TestCommand): Deleted.
3992         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3993         (parseInputLine):
3994         * DumpRenderTree/TestRunner.h:
3995         (TestRunner::setDumpJSConsoleLogInStdErr):
3996         (TestRunner::dumpJSConsoleLogInStdErr):
3997         * DumpRenderTree/mac/DumpRenderTree.mm:
3998         (runTest):
3999         * DumpRenderTree/mac/UIDelegate.mm:
4000         (-[UIDelegate webView:addMessageToConsole:withSource:]):
4001         * DumpRenderTree/win/DumpRenderTree.cpp:
4002         (runTest):
4003         * DumpRenderTree/win/UIDelegate.cpp:
4004         (UIDelegate::webViewAddMessageToConsole):
4005         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4006         (TestExpectationParser._tokenize_line):
4007         * Scripts/webkitpy/port/driver.py:
4008         (Driver._command_from_driver_input):
4009         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4010         (WTR::InjectedBundle::didReceiveMessageToPage):
4011         (WTR::InjectedBundle::dumpToStdErr):
4012         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4013         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
4014         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4015         (WTR::InjectedBundlePage::willAddMessageToConsole):
4016         * WebKitTestRunner/TestController.cpp:
4017         (WTR::parseInputLine):
4018         (WTR::TestController::runTest):
4019         (WTR::TestCommand::TestCommand): Deleted.
4020         * WebKitTestRunner/TestInvocation.cpp:
4021         (WTR::TestInvocation::invoke):
4022         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4023         * WebKitTestRunner/TestInvocation.h:
4024         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
4025
4026
4027 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
4028
4029         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
4030         https://bugs.webkit.org/show_bug.cgi?id=164022
4031
4032         Reviewed by Xabier Rodriguez-Calvar.
4033
4034         * Scripts/webkitperl/FeatureList.pm:
4035           Re-enable MEDIA_SOURCE for the GTK+ port.
4036
4037 2016-12-13  Alex Christensen  <achristensen@webkit.org>
4038
4039         Fix CMake build.
4040
4041         * DumpRenderTree/PlatformMac.cmake:
4042         Define NS_RETURNS_RETAINED as nothing for now.
4043
4044 2016-12-13  Jer Noble  <jer.noble@apple.com>
4045
4046         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
4047         https://bugs.webkit.org/show_bug.cgi?id=165697
4048
4049         Reviewed by Tim Horton.
4050
4051         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
4052         (TestWebKitAPI::TEST):
4053
4054 2016-12-13  Andy Estes  <aestes@apple.com>
4055
4056         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
4057         https://bugs.webkit.org/show_bug.cgi?id=165785
4058         <rdar://problem/26929398>
4059
4060         Reviewed by Darin Adler.
4061
4062         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4063         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
4064         expectations for the text, range, and action.
4065         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
4066         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
4067         plain-text string to the pasteboard, executed a paste action, and verified that the selected
4068         text in the web view did not change.
4069         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
4070         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
4071         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
4072         parameter.
4073         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
4074         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
4075         and returned the value of _editingDelegateShouldInsertText.
4076         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
4077         -shouldInsertText:replacingRange:givenAction:.
4078
4079 2016-12-13  Chris Dumez  <cdumez@apple.com>
4080
4081         Unreviewed, rolling out r209544.
4082
4083         Looks like r209489 did not cause the performance regression
4084         after all
4085
4086         Reverted changeset:
4087
4088         "Unreviewed, rolling out r209489."
4089         https://bugs.webkit.org/show_bug.cgi?id=165550
4090         http://trac.webkit.org/changeset/209544
4091
4092 2016-12-12  Sam Weinig  <sam@webkit.org>
4093
4094         [WebIDL] Remove use of Dictionary in ApplePaySession
4095         https://bugs.webkit.org/show_bug.cgi?id=165787
4096
4097         Reviewed by Anders Carlsson.
4098
4099         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4100         (WTR::initializeWebViewConfiguration):
4101         (WTR::TestController::platformCreateWebView):
4102         Enable ApplePay for the tests (where supported).
4103
4104 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
4105
4106         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
4107         https://bugs.webkit.org/show_bug.cgi?id=165251
4108
4109         Reviewed by Youenn Fablet.
4110
4111         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
4112         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
4113         the preferences have been set.
4114
4115 2016-12-08  Antti Koivisto  <antti@apple.com>
4116
4117         Enable network cache speculative revalidation in MiniBrowser
4118         https://bugs.webkit.org/show_bug.cgi?id=165616
4119
4120         Reviewed by Darin Adler.
4121
4122         Match Safari. Also add a menu item to disable it.
4123
4124         * MiniBrowser/mac/AppDelegate.m:
4125         (defaultConfiguration):
4126         * MiniBrowser/mac/SettingsController.h:
4127         * MiniBrowser/mac/SettingsController.m:
4128         (-[SettingsController _populateMenu]):
4129         (-[SettingsController validateMenuItem:]):
4130         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
4131         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
4132
4133 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
4134
4135         ChangeLogs become readonly after resolving a conflict
4136         https://bugs.webkit.org/show_bug.cgi?id=165440
4137         rdar://problem/29491002
4138
4139         Reviewed by Darin Adler.
4140
4141         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
4142         moving the file.
4143
4144 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
4145
4146         Re-enable collectContinuously since it doesn't crash anymore
4147
4148         Rubber stamped by Michael Saboff.
4149
4150         * Scripts/run-jsc-stress-tests:
4151
4152 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
4153
4154         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
4155         https://bugs.webkit.org/show_bug.cgi?id=165686
4156
4157         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
4158         so that right config.h comes first in include path.
4159
4160 2016-12-11  Dave Hyatt  <hyatt@apple.com>
4161
4162         [CSS Parser] Make sure content extensions initialize AtomicString
4163         https://bugs.webkit.org/show_bug.cgi?id=165737
4164
4165         Reviewed by Darin Adler.
4166
4167         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4168         (TestWebKitAPI::makeBackend):
4169
4170 2016-12-08  Dave Hyatt  <hyatt@apple.com>
4171
4172         [CSS Parser] Remove the old CSS Parser
4173         https://bugs.webkit.org/show_bug.cgi?id=165645
4174
4175         Reviewed by Daniel Bates.
4176
4177         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
4178         (TestWebKitAPI::TEST):
4179
4180 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
4181
4182         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
4183         https://bugs.webkit.org/show_bug.cgi?id=165686
4184
4185         Reviewed by Michael Catanzaro.
4186
4187         This change reduces duplication of include path lists between modules,
4188         and reduces future need for fixes like r209605 (broken build because of
4189         WebCore header suddenly becoming used in WebKit2).
4190
4191         * DumpRenderTree/CMakeLists.txt:
4192         * DumpRenderTree/PlatformMac.cmake:
4193         * ImageDiff/CMakeLists.txt:
4194         * MiniBrowser/gtk/CMakeLists.txt:
4195         * MiniBrowser/mac/CMakeLists.txt:
4196         * MiniBrowser/win/CMakeLists.txt:
4197         * TestWebKitAPI/CMakeLists.txt:
4198         * TestWebKitAPI/PlatformEfl.cmake:
4199         * TestWebKitAPI/PlatformJSCOnly.cmake:
4200         * TestWebKitAPI/PlatformMac.cmake:
4201         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
4202         * WebKitTestRunner/CMakeLists.txt:
4203         * WebKitTestRunner/PlatformGTK.cmake:
4204         * WebKitTestRunner/PlatformMac.cmake:
4205
4206 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
4207
4208         Unreviewed buildfix after r209630.
4209
4210         * Scripts/build-jsc: Remove building the non-existing testWASM.
4211
4212 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
4213
4214         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
4215         https://bugs.webkit.org/show_bug.cgi?id=165251
4216
4217         Reviewed by Dean Jackson.
4218
4219         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
4220
4221         * DumpRenderTree/mac/DumpRenderTree.mm:
4222         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
4223
4224         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4225         (WTR::InjectedBundle::beginTesting): Ditto.
4226
4227         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4228         (WTR::TestRunner::setMediaStreamEnabled): New.
4229         (WTR::TestRunner::setPeerConnectionEnabled): New.
4230         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4231
4232 2016-12-09  Brady Eidson  <beidson@apple.com> 
4233  
4234         Re-landing:
4235         Add _WKIconLoadingDelegate SPI. 
4236         https://bugs.webkit.org/show_bug.cgi?id=164894 
4237  
4238         Reviewed by Alex Christensen. 
4239         
4240         Add MiniBrowser support for this new SPI, configurable with a setting. 
4241  
4242         * MiniBrowser/mac/SettingsController.h: 
4243         * MiniBrowser/mac/SettingsController.m: 
4244         (-[SettingsController _populateMenu]): 
4245         (-[SettingsController validateMenuItem:]): 
4246         (-[SettingsController loadsAllSiteIcons]): 
4247         (-[SettingsController toggleLoadsAllSiteIcons:]): 
4248         * MiniBrowser/mac/WK2BrowserWindowController.m: 
4249         (-[WK2BrowserWindowController awakeFromNib]): 
4250         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
4251
4252 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
4253
4254         Fix the 32-bit build.
4255
4256         Unreviewed build fix.
4257
4258         * MiniBrowser/mac/SettingsController.h:
4259
4260 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4261
4262         Fedora also needs a PHP7 config file alternative
4263         https://bugs.webkit.org/show_bug.cgi?id=165606
4264
4265         Reviewed by Michael Catanzaro.
4266
4267         * Scripts/webkitpy/port/base.py:
4268         (Port._is_fedora_php_version_7): check for the php7 library.
4269         (Port._fedora_php_version): get the appropriate filename for Fedora.
4270         (Port._apache_config_file_name_for_platform):
4271
4272 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
4273
4274         Complete the revert of r208865.
4275         https://bugs.webkit.org/show_bug.cgi?id=164894
4276
4277         Unreviewed build fix.
4278
4279         * MiniBrowser/mac/SettingsController.h:
4280         * MiniBrowser/mac/SettingsController.m:
4281         (-[SettingsController _populateMenu]):
4282         (-[SettingsController validateMenuItem:]):
4283         (-[SettingsController loadsAllSiteIcons]): Deleted.
4284         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
4285         * MiniBrowser/mac/WK2BrowserWindowController.m:
4286         (-[WK2BrowserWindowController awakeFromNib]):
4287         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
4288
4289 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4290
4291         [GTK] Force GDK backend to x11 when running with XvfbDriver
4292         https://bugs.webkit.org/show_bug.cgi?id=165612
4293
4294         Reviewed by Michael Catanzaro.
4295
4296         When the developer is running a Wayland session, GDK may get confused
4297         and try to use its Wayland backend (which is higher priority) instead.
4298         This ensures it will use the appropriate backend when running under
4299         Xvfb.
4300
4301         * Scripts/webkitpy/port/gtk.py:
4302         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
4303         force GDK_BACKEND to x11.
4304
4305 2016-12-08  Keith Miller  <keith_miller@apple.com>
4306
4307         Add 64-bit signed LEB decode method
4308         https://bugs.webkit.org/show_bug.cgi?id=165630
4309
4310         Reviewed by Ryosuke Niwa.
4311
4312         Add tests for LEB int64 and uint64 decode since I guess
4313         I forgot to add tests before.
4314
4315         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
4316         (TestWebKitAPI::testUInt32LEBDecode):
4317         (TestWebKitAPI::TEST):
4318         (TestWebKitAPI::testUInt64LEBDecode):
4319         (TestWebKitAPI::testInt32LEBDecode):
4320         (TestWebKitAPI::testInt64LEBDecode):
4321         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
4322
4323 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
4324
4325         Make it easy to enable --force-collectContinuously