Try to fix Production builds.
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
2
3         Try to fix Production builds.
4         
5         PRODUCTION_FRAMEWORKS_DIR was undefined here.
6
7         * DumpRenderTree/mac/Configurations/Base.xcconfig:
8
9 2016-08-24  Dan Bernstein  <mitz@apple.com>
10
11         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
12         https://bugs.webkit.org/show_bug.cgi?id=161152
13
14         Reviewed by Anders Carlsson.
15
16         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
17         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
18         (TestWebKitAPI::didFinishLoadForFrame):
19         (TestWebKitAPI::TEST):
20
21 2016-08-24  Nan Wang  <n_wang@apple.com>
22
23         AX: Add test for line text marker range on iOS
24         https://bugs.webkit.org/show_bug.cgi?id=161108
25         <rdar://problem/27976405>
26
27         Reviewed by Chris Fleizach.
28
29         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
30         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
31         (AccessibilityUIElement::textMarkerRangeForElement):
32         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
33         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
34         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
35
36 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
37
38         [Win] Warning fixes.
39         https://bugs.webkit.org/show_bug.cgi?id=161079
40
41         Reviewed by Brent Fulgham.
42
43         * MiniBrowser/win/WebDownloadDelegate.cpp:
44         * MiniBrowser/win/WinMain.cpp:
45         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
46         (TestWebKitAPI::TEST):
47
48 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
49
50         Fix Windows DRT build.
51
52         * DumpRenderTree/win/TestRunnerWin.cpp:
53         (TestRunner::mainFrameJSContext):
54
55 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
56
57         Try to fix Windows build.
58         
59         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
60         so that perl finds CodeGeneratorDumpRenderTree.pm.
61
62         * DumpRenderTree/CMakeLists.txt:
63
64 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
65
66         Hook up UIScriptController in DumpRenderTree
67         https://bugs.webkit.org/show_bug.cgi?id=161064
68
69         Reviewed by Sam Weinig.
70
71         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
72         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
73         in fast/harness which test this.
74
75         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
76
77         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
78         WK2-isms. Fix the makefiles to refer to the new location.
79
80         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
81         by ID and firing them once they are complete.
82
83         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
84         * DumpRenderTree/CMakeLists.txt:
85         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
86         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
87         * DumpRenderTree/TestRunner.cpp:
88         (runUIScriptCallback):
89         (TestRunner::staticFunctions):
90         (TestRunner::cacheTestRunnerCallback):
91         (TestRunner::callTestRunnerCallback):
92         (TestRunner::clearTestRunnerCallbacks):
93         (nextUIScriptCallbackID):
94         (TestRunner::runUIScript):
95         (TestRunner::callUIScriptCallback):
96         (TestRunner::uiScriptDidComplete):
97         (TestRunner::cleanup):
98         * DumpRenderTree/TestRunner.h:
99         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
100         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
101         * DumpRenderTree/mac/DumpRenderTree.mm:
102         (runTest):
103         * DumpRenderTree/mac/TestRunnerMac.mm:
104         (TestRunner::mainFrameJSContext):
105         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
106         (WTR::UIScriptController::doAsyncTask):
107         * DumpRenderTree/win/DumpRenderTree.cpp:
108         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
109         (WTR::JSWrappable::~JSWrappable):
110         (WTR::JSValueMakeStringOrNull):
111         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
112         (WTR::JSWrapper::wrap):
113         (WTR::JSWrapper::unwrap):
114         (WTR::unwrapObject):
115         (WTR::JSWrapper::initialize):
116         (WTR::JSWrapper::finalize):
117         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
118         (WTR::toJS):
119         (WTR::setProperty):
120         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
121         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
122         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
123         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
124         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
125         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
126         * WebKitTestRunner/CMakeLists.txt:
127         * WebKitTestRunner/DerivedSources.make:
128         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
129         (WTR::JSWrappable::~JSWrappable): Deleted.
130         (WTR::JSValueMakeStringOrNull): Deleted.
131         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
132         (WTR::JSWrapper::wrap): Deleted.
133         (WTR::JSWrapper::unwrap): Deleted.
134         (WTR::unwrapObject): Deleted.
135         (WTR::JSWrapper::initialize): Deleted.
136         (WTR::JSWrapper::finalize): Deleted.
137         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
138         (WTR::toJS): Deleted.
139         (WTR::setProperty): Deleted.
140         * WebKitTestRunner/TestInvocation.cpp:
141         (WTR::TestInvocation::runUISideScript):
142         (WTR::TestInvocation::uiScriptDidComplete):
143         * WebKitTestRunner/TestInvocation.h:
144         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
145         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
146         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
147         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
148         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
149         * WebKitTestRunner/config.h:
150         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
151         (WTR::UIScriptController::contentVisibleRect):
152
153 2016-08-23  Saam Barati  <sbarati@apple.com>
154
155         JSC should have a "microbenchmarks" directory instead of "regress" directory
156         https://bugs.webkit.org/show_bug.cgi?id=161096
157
158         Rubber stamped by Mark Lam.
159
160         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
161         directory and removes all the related html and txt files. I did this because
162         that directory was only there for microbenchmarks, and not for "regression"
163         tests. I also changed the various scripts to point to it.
164
165         * Scripts/run-javascriptcore-tests:
166         (runJSCStressTests):
167         * Scripts/run-jsc-benchmarks:
168
169 2016-08-23  Alex Christensen  <achristensen@webkit.org>
170
171         Fix EFL build.
172
173         * TestWebKitAPI/CMakeLists.txt:
174         Include new directory.
175
176 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
177
178         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
179         https://bugs.webkit.org/show_bug.cgi?id=160125
180
181         Reviewed by Geoffrey Garen.
182
183         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
184         * Scripts/run-jsc-stress-tests: New test flag!
185
186 2016-08-23  Brady Eidson  <beidson@apple.com>
187
188         WK2 Gamepad layout test support.
189         https://bugs.webkit.org/show_bug.cgi?id=134671
190
191         Reviewed by Alex Christensen.
192         
193         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
194         feed back into the UIGamepadProvider.
195         
196         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
197         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
198
199         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
200         
201         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
202         (WTR::TestRunner::setMockGamepadDetails):
203         (WTR::TestRunner::setMockGamepadAxisValue):
204         (WTR::TestRunner::setMockGamepadButtonValue):
205         
206         * WebKitTestRunner/PlatformWebView.h:
207         
208         * WebKitTestRunner/TestController.cpp:
209         (WTR::TestController::initialize):
210         
211         * WebKitTestRunner/TestInvocation.cpp:
212         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
213         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
214         
215         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
216         
217         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
218         (-[WebKitTestRunnerWindow initWithFrame:]):
219         (-[WebKitTestRunnerWindow dealloc]):
220         (WTR::PlatformWebView::keyWindow):
221         
222         * WebKitTestRunner/ios/TestControllerIOS.mm:
223         (WTR::wtr_NSApplication_keyWindow):
224         (WTR::TestController::platformInitialize):
225         
226         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
227         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
228         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
229         (-[WebKitTestRunnerWindow dealloc]):
230         (WTR::PlatformWebView::keyWindow):
231         
232         * WebKitTestRunner/mac/TestControllerMac.mm:
233         (WTR::wtr_NSApplication_keyWindow):
234         (WTR::TestController::platformInitialize):
235         * WebKitTestRunner/mac/main.mm:
236
237 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
238
239         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
240         https://bugs.webkit.org/show_bug.cgi?id=161047
241         rdar://problem/27434307
242
243         Reviewed by Lucas Forschler.
244
245         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
246
247 2016-08-23  Chris Dumez  <cdumez@apple.com>
248
249         Unreviewed, rolling out r204243.
250
251         Caused some layout test failures
252
253         Reverted changeset:
254
255         "Write API test to cover crash fix in r204135"
256         https://bugs.webkit.org/show_bug.cgi?id=160587
257         http://trac.webkit.org/changeset/204243
258
259 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
260
261         Order feature option list in FeatureList.pm
262         https://bugs.webkit.org/show_bug.cgi?id=161074
263
264         Reviewed by Michael Catanzaro.
265
266         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
267
268         * Scripts/webkitperl/FeatureList.pm:
269
270 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
271
272         Stop python icon bouncing in the dock while running browser benchmarks.
273         https://bugs.webkit.org/show_bug.cgi?id=161066
274
275         Reviewed by Ryosuke Niwa.
276
277         Bouncing python icon may impact browser benchmark results.
278         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
279         (OSXBrowserDriver.prepare_env):
280         (OSXBrowserDriver.restore_env):
281
282 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
283
284         <select> menu on iPad causes shifting of hit-testing areas
285         https://bugs.webkit.org/show_bug.cgi?id=150079
286
287         Reviewed by Tim Horton.
288
289         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
290         so when it changes we have to update visible rects. We were doing this on focus, but failing
291         to do it on blur.
292
293         Added the ability to test by:
294         1. Making it possible to initiate an animated scroll in the UI process
295         2. Adding callbacks for starting and ending interaction with a form control. Sadly
296         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
297         have no way currently to know when the dimming view behind the popover animates out,
298         so for now the test keeps trying to tap a button.
299
300         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
301         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
302         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
303         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
304         (WTR::UIScriptController::didStartFormControlInteractionCallback):
305         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
306         (WTR::UIScriptController::didEndFormControlInteractionCallback):
307         (WTR::UIScriptController::scrollToOffset):
308         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
309         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
310         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
311         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
312         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
313         (-[TestRunnerWKWebView dealloc]):
314         (-[TestRunnerWKWebView didStartFormControlInteraction]):
315         (-[TestRunnerWKWebView didEndFormControlInteraction]):
316         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
317         (WTR::contentOffsetBoundedInValidRange):
318         (WTR::UIScriptController::scrollToOffset):
319         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
320         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
321
322 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
323
324         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
325         https://bugs.webkit.org/show_bug.cgi?id=160927
326
327         Reviewed by Daniel Bates.
328
329         * Scripts/process-linux-coredump: Removed.
330         * Scripts/webkitpy/port/efl.py:
331         (EflPort._get_crash_log):
332         * Scripts/webkitpy/port/gtk.py:
333         (GtkPort._get_crash_log):
334         * Scripts/webkitpy/port/linux_get_crash_log.py:
335         (GDBCrashLogGenerator.__init__):
336         (GDBCrashLogGenerator.generate_crash_log):
337         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
338         (GDBCrashLogGeneratorTest.test_generate_crash_log):
339
340 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
341
342         check-webkit-style does not work with Lambda functions in C++
343         https://bugs.webkit.org/show_bug.cgi?id=160910
344
345         Reviewed by Darin Adler.
346
347         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
348
349         * Scripts/webkitpy/style/checkers/cpp.py:
350         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
351         (check_for_non_standard_constructs): Added lambda function check.
352         (check_spacing_for_function_call): Added lambda function check.
353         (check_braces): Added lambda function check.
354         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
355         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
356
357 2016-08-21  Alex Christensen  <achristensen@webkit.org>
358
359         URLParser should parse IPv4 addresses
360         https://bugs.webkit.org/show_bug.cgi?id=161023
361
362         Reviewed by Darin Adler.
363
364         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
365         (TestWebKitAPI::TEST_F):
366         (TestWebKitAPI::checkURLDifferences):
367         We are already getting differences between the old URL::parse and the new URLParser.
368         (TestWebKitAPI::shouldFail):
369
370 2016-08-21  Daniel Bates  <dabates@apple.com>
371
372         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
373         https://bugs.webkit.org/show_bug.cgi?id=148437
374
375         Reviewed by Dan Bernstein.
376
377         * Scripts/prepare-ChangeLog:
378         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
379         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
380         assumes that its line ranges were from a unified diff without any context lines.
381         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
382         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
383         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
384         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
385         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
386         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
387         to /dev/null for the duration of the function call.
388
389 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
390
391         [EFL] Remove unnecessary a patch to mute ecore warnings
392         https://bugs.webkit.org/show_bug.cgi?id=160997
393
394         Reviewed by Darin Adler.
395
396         There is no warning messages during the layout test and perf test
397         after bumping efl version from 1.17 to 1.18. Remove it.
398
399         * efl/patches/ecore_remove_warnings.patch: Removed.
400
401 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
402
403         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
404         https://bugs.webkit.org/show_bug.cgi?id=160985
405
406         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
407         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
408         with that.
409
410         * Scripts/webkitpy/layout_tests/views/printing.py:
411         (Printer.print_config):
412         * Scripts/webkitpy/port/base.py:
413         (Port.driver_cmd_line_for_logging):
414         (Port.driver_cmd_line): Deleted.
415         * Scripts/webkitpy/port/driver.py:
416         (IOSSimulatorDriver.cmd_line):
417         * Scripts/webkitpy/port/ios.py:
418         (IOSSimulatorPort.__init__):
419         (IOSSimulatorPort.driver_cmd_line_for_logging):
420         (IOSSimulatorPort._create_simulators):
421         (IOSSimulatorPort.setup_test_run):
422         (IOSSimulatorPort._quit_ios_simulator):
423         (IOSSimulatorPort.clean_up_test_run):
424         (IOSSimulatorPort._create_device):
425         (IOSSimulatorPort):
426         (IOSSimulatorPort._remove_device):
427         (IOSSimulatorPort._testing_device):
428         (IOSSimulatorPort.device_id_for_worker_number):
429         (IOSSimulatorPort._set_device_class): Deleted.
430         (IOSSimulatorPort.testing_device): Deleted.
431         * Scripts/webkitpy/port/port_testcase.py:
432         (PortTestCase.test_driver_cmd_line):
433         * Scripts/webkitpy/xcode/simulator.py:
434         (Device.shutdown):
435         (Device):
436         (Device.delete):
437         (Device.reset):
438         (Simulator):
439         (Simulator.create_device):
440         (Simulator.remove_device):
441         (Simulator.device_number):
442         (Simulator.device_state_description):
443         (Simulator.wait_until_device_is_in_state):
444
445 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
446
447         Unreviewed, rolling out r204659.
448
449         This change appears to have caused ios-simulator LayoutTests
450         to fail when shutting down the simulator
451
452         Reverted changeset:
453
454         "REGRESSION (r204477): Running LayoutTests on ios-simulator
455         became ~15 minutes slower"
456         https://bugs.webkit.org/show_bug.cgi?id=160985
457         http://trac.webkit.org/changeset/204659
458
459 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
460
461         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
462         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
463
464 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
465
466         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
467         https://bugs.webkit.org/show_bug.cgi?id=160985
468
469         Reviewed by Alexey Proskuryakov.
470         
471         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
472         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
473         must not be @memoized, because their return value depends on the value of simulator_device_type().
474         
475         Fix by adding some global state in simulator.py that tracks the created devices 
476         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
477         and delete them in clean_up_test_run().
478         
479         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
480         that killing the Simulator apps isn't enough.
481         
482         Simulator tracks the devices in a global dictionary, since state needs to persist
483         across different instances of IOSSimulatorPort.
484         
485         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
486         any setup. Rather than implicitly creating a device here (which the old code did),
487         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
488         and set flag to say that device_id_for_worker_number() doesn't need to return a real
489         device id.
490
491         * Scripts/webkitpy/layout_tests/views/printing.py:
492         (print_options):
493         (Printer.print_config):
494         * Scripts/webkitpy/port/base.py:
495         (Port.driver_cmd_line_for_logging):
496         (Port.driver_cmd_line): Deleted.
497         * Scripts/webkitpy/port/driver.py:
498         (IOSSimulatorDriver.cmd_line):
499         * Scripts/webkitpy/port/ios.py:
500         (IOSSimulatorPort.__init__):
501         (IOSSimulatorPort.driver_cmd_line_for_logging):
502         (IOSSimulatorPort._create_simulators):
503         (IOSSimulatorPort.setup_test_run):
504         (IOSSimulatorPort.clean_up_test_run):
505         (IOSSimulatorPort._create_device):
506         (IOSSimulatorPort):
507         (IOSSimulatorPort._remove_device):
508         (IOSSimulatorPort._testing_device):
509         (IOSSimulatorPort.device_id_for_worker_number):
510         (IOSSimulatorPort._set_device_class): Deleted.
511         (IOSSimulatorPort.testing_device): Deleted.
512         * Scripts/webkitpy/port/port_testcase.py:
513         (PortTestCase.test_driver_cmd_line):
514         * Scripts/webkitpy/xcode/simulator.py:
515         (Device.shutdown):
516         (Device.delete):
517         (Device.reset):
518         (Simulator.create_device):
519         (Simulator.remove_device):
520         (Simulator.device_number):
521         (Simulator.device_state_description):
522         (Simulator.wait_until_device_is_in_state):
523
524 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
525
526         Adopt SimServiceContext in LayoutTestRelay
527         https://bugs.webkit.org/show_bug.cgi?id=161000
528         <rdar://problem/25765594>
529
530         Reviewed by Daniel Bates.
531
532         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
533         * LayoutTestRelay/LayoutTestRelay/main.m:
534
535 2016-08-19  Lucas Forschler  <lforschler@apple.com>
536
537         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
538
539         Reviewed by Kocsen Chung.
540
541         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
542         (WebKitBuildbot):
543
544 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
545
546         Partial revert of r203811 - this key is not needed.
547
548         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
549
550 2016-08-19  Daniel Bates  <dabates@apple.com>
551
552         Another attempt to fix the iOS 9.3 build
553
554         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
555
556         * DumpRenderTree/mac/Configurations/Base.xcconfig:
557         * WebKitTestRunner/Configurations/Base.xcconfig:
558
559 2016-08-19  Lucas Forschler  <lforschler@apple.com>
560
561         Remove Yosemite Leaks bot from config.json
562         
563         Reviewed by Alexey Proskuryakov.
564
565         * BuildSlaveSupport/build.webkit.org-config/config.json:
566
567 2016-08-18  Dan Bernstein  <mitz@apple.com>
568
569         [Cocoa] API::Number needs to be wrapped by an NSNumber
570         https://bugs.webkit.org/show_bug.cgi?id=160977
571         <rdar://problem/27877735>
572
573         Reviewed by Anders Carlsson.
574
575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
576         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
577         (TestWebKitAPI::TEST):
578
579 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
580
581         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
582         https://bugs.webkit.org/show_bug.cgi?id=160895
583
584         Reviewed by Dean Jackson.
585
586         Link to the existing CoreText framework.
587
588         * DumpRenderTree/PlatformWin.cmake:
589         * TestWebKitAPI/PlatformWin.cmake:
590
591 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
592
593         [Win] Remove old libraries from build inputs
594         https://bugs.webkit.org/show_bug.cgi?id=160949
595
596         Reviewed by Dean Jackson.
597
598         Modify the download script to remove the old 'icuuc.lib' and
599         'icuin.lib' files for Windows builds.
600
601         * Scripts/update-webkit-auxiliary-libs:
602
603 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
604
605         Extra logging for crash reason
606         https://bugs.webkit.org/show_bug.cgi?id=160943
607
608         Reviewed by Alexey Proskuryakov.
609
610         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
611
612         * Scripts/webkitpy/port/server_process.py:
613         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
614         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
615         (ServerProcess.has_crashed): Ditto.
616
617 2016-08-17  Dan Bernstein  <mitz@apple.com>
618
619         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
620         https://bugs.webkit.org/show_bug.cgi?id=160938
621         <rdar://problem/27876652>
622
623         Reviewed by Anders Carlsson.
624
625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
626         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
627         (TestWebKitAPI::TEST):
628
629 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
630
631         AX: Support abbreviations in iOS
632         https://bugs.webkit.org/show_bug.cgi?id=160907
633
634         Reviewed by Joanmarie Diggs.
635
636         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
637         (AccessibilityUIElement::stringAttributeValue):
638         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
639         (WTR::AccessibilityUIElement::stringAttributeValue):
640
641 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
642
643         [EFL] Bump efl version from 1.17 to 1.18
644         https://bugs.webkit.org/show_bug.cgi?id=160899
645
646         Reviewed by Antonio Gomes.
647
648         To use efl-1.18, EFL port needs to update install dependencies as well.
649
650         * efl/install-dependencies:
651         * efl/jhbuild.modules:
652
653 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
654
655         [Win] Add tests for linked fonts.
656         https://bugs.webkit.org/show_bug.cgi?id=160898
657
658         Reviewed by Brent Fulgham.
659
660         Add tests for https://trac.webkit.org/changeset/204502.
661
662         * TestWebKitAPI/PlatformWin.cmake:
663         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
664         (TestWebKitAPI::TEST):
665
666 2016-08-16  Daniel Bates  <dabates@apple.com>
667
668         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
669         https://bugs.webkit.org/show_bug.cgi?id=160924
670
671         Reviewed by Stephanie Lewis.
672
673         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
674         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
675         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
676         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
677         object that mocks out the file system and SCM operations.
678
679         * Scripts/VCSUtils.pm:
680         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
681         * Scripts/prepare-ChangeLog:
682         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
683         abstracting the logic to query the file system and SCM into functions on a delegate object that
684         we pass to it.
685         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
686         (diffHeaderFormat): Deleted.
687
688 2016-08-16  Alex Christensen  <achristensen@webkit.org>
689
690         URLParser should parse URLs without credentials
691         https://bugs.webkit.org/show_bug.cgi?id=160913
692
693         Reviewed by Brady Eidson.
694
695         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
696         (TestWebKitAPI::s):
697         (TestWebKitAPI::checkURL):
698         (TestWebKitAPI::TEST_F):
699
700 2016-08-16  Anders Carlsson  <andersca@apple.com>
701
702         Add WTF::ScopeExit
703         https://bugs.webkit.org/show_bug.cgi?id=160908
704
705         Reviewed by Geoffrey Garen.
706
707         * TestWebKitAPI/CMakeLists.txt:
708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
709         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
710         (TestWebKitAPI::TEST):
711
712 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
713
714         EWS logs file are rotated too quickly
715         https://bugs.webkit.org/show_bug.cgi?id=160724
716
717         Reviewed by Daniel Bates.
718
719         Currently we are rotating the log file after 10 iterations of queue. If the queue
720         doesn't have any pending patches, these iterations result in very small amount of 
721         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
722         This results in a lot of log files in a day. This patch ensures that we rotate the
723         log file when its file size is greater than or equal to 100 KB.
724
725         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
726
727 2016-08-16  Daniel Bates  <dabates@apple.com>
728
729         WKSI static library should be named by major iOS revision, not individual updates
730         https://bugs.webkit.org/show_bug.cgi?id=160727
731         <rdar://problem/22274848>
732
733         Reviewed by Alexey Proskuryakov.
734
735         * DumpRenderTree/mac/Configurations/Base.xcconfig:
736         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
737         * Scripts/copy-webkitlibraries-to-product-directory:
738         * WebKitTestRunner/Configurations/Base.xcconfig:
739         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
740
741 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
742
743         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
744         https://bugs.webkit.org/show_bug.cgi?id=160909
745
746         Reviewed by Enrica Casucci.
747         
748         Add functions to UIScriptController to dismiss the form accessory view for iOS,
749         and to programmatically pick a row from a <select> picker.
750
751         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
752         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
753         (WTR::UIScriptController::dismissFormAccessoryView):
754         (WTR::UIScriptController::selectFormAccessoryPickerRow):
755         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
756         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
757         (WTR::UIScriptController::dismissFormAccessoryView):
758         (WTR::UIScriptController::selectFormAccessoryPickerRow):
759
760 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
761
762         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
763         https://bugs.webkit.org/show_bug.cgi?id=160878
764
765         Reviewed by Tim Horton.
766         
767         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
768         now that we have the ability to run tests in the iPad simulator.
769
770         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
771         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
772         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
773         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
774         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
775         * WebKitTestRunner/ios/TestControllerIOS.mm:
776         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
777         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
778         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
779         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
780
781 2016-08-15  Anders Carlsson  <andersca@apple.com>
782
783         Add an address-of operator to RetainPtr
784         https://bugs.webkit.org/show_bug.cgi?id=160879
785
786         Reviewed by Tim Horton.
787
788         Test HashMap and HashSet with an object whose operator& is deleted.
789
790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
791         Sort the Xcode project.
792
793         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
794         (DeletedAddressOfOperator::DeletedAddressOfOperator):
795         (DeletedAddressOfOperator::value):
796         (DeletedAddressOfOperator::operator==):
797         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
798         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
799         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
800         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
801         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
802         (TestWebKitAPI::TEST):
803         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
804         (TestWebKitAPI::TEST):
805
806 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
807
808         False crashes in fast/text/emoji-gender-* tests
809         https://bugs.webkit.org/show_bug.cgi?id=160779
810
811         Reviewed by Alexey Proskuryakov.
812
813         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
814
815         * Scripts/webkitpy/port/driver.py:
816         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
817         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
818         * Scripts/webkitpy/port/server_process.py:
819         (ServerProcess.write): Allow caller to disable crash flag on exception.
820
821 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
822
823         webkitpy error in TestRunResults.merge()
824         https://bugs.webkit.org/show_bug.cgi?id=160882
825
826         Reviewed by Daniel Bates.
827         
828         The argument to TestRunResults.merge() can be None if there are no device-specifc
829         initial results or retry results in Manager.run(), so just return early in that case.
830
831         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
832         (TestRunResults.merge):
833
834 2016-08-15  Sam Weinig  <sam@webkit.org>
835
836         Speed up compile times by not including wtf/Variant.h so much
837         https://bugs.webkit.org/show_bug.cgi?id=160847
838
839         Reviewed by Alex Christensen and Saam Barati.
840
841         * TestWebKitAPI/Tests/WTF/Variant.cpp:
842         (TestWebKitAPI::TEST):
843         Explicitly use std::experimental::variant.
844
845 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
846
847         Allow a port to run tests with a custom device setup
848         https://bugs.webkit.org/show_bug.cgi?id=160833
849
850         Reviewed by Daniel Bates.
851
852         These changes allow the IOSSimulator port to run tests in iPad mode.
853
854         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
855         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
856         a custom device will be collected into a set, and run in that device's environment after
857         the other tests have run.
858
859         * Scripts/webkitpy/layout_tests/controllers/manager.py:
860         (Manager._custom_device_for_test): If the test contains a directory matching a
861         custom device suffix, return that custom device.
862         (Manager._set_up_run): Push the custom device class, if any, into options so
863         that the Worker can get to it.
864         (Manager.run): Go through the list of tests, and break it down into device-generic
865         tests, and tests for each device class. _run_test_subset is then called for
866         each collection of tests, and the results merged.
867         (Manager._run_test_subset): Some lines unwrapped.
868         (Manager._end_test_run):
869         (Manager._run_tests):
870         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
871         (SingleTestRunner.__init__): Unwrapped a line.
872         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
873         (TestRunResults.merge): Add this function to merge TestRunResults
874         * Scripts/webkitpy/layout_tests/views/printing.py:
875         (Printer.print_workers_and_shards): Print the custom device, if any.
876         * Scripts/webkitpy/port/base.py:
877         (Port): Base port has empty array of custom devices.
878         (Port.setup_test_run): Add device_class argument.
879         * Scripts/webkitpy/port/driver.py:
880         (DriverInput.__repr__):
881         (Driver.check_driver.implementation):
882         * Scripts/webkitpy/port/efl.py:
883         (EflPort.setup_test_run):
884         * Scripts/webkitpy/port/gtk.py:
885         (GtkPort.setup_test_run):
886         * Scripts/webkitpy/port/ios.py:
887         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
888         (IOSSimulatorPort.__init__):
889         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
890         based on the custom device class.
891         (IOSSimulatorPort._set_device_class):
892         (IOSSimulatorPort._create_simulators): Factor some code into this function.
893         (IOSSimulatorPort.setup_test_run):
894         (IOSSimulatorPort.testing_device):
895         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
896         seemed wrong for this function. That was moved to setup_test_run().
897         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
898         but this happened too early, before we knew which kind of devices to create. Devices
899         are now created in setup_test_run().
900         * Scripts/webkitpy/port/win.py:
901         (WinPort.setup_test_run):
902
903 2016-08-15  Daniel Bates  <dabates@apple.com>
904
905         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
906         private frameworks and libraries
907         https://bugs.webkit.org/show_bug.cgi?id=155931
908         <rdar://problem/25807989>
909
910         Reviewed by Dan Bernstein.
911
912         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
913         where X is the major version of the active iOS SDK.
914
915         * DumpRenderTree/mac/Configurations/Base.xcconfig:
916         * WebKitTestRunner/Configurations/Base.xcconfig:
917
918 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
919
920         Add a setting and preferences to enable visual viewport mode
921         https://bugs.webkit.org/show_bug.cgi?id=160843
922
923         Reviewed by Sam Weinig.
924         
925         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
926
927         * MiniBrowser/mac/SettingsController.h:
928         * MiniBrowser/mac/SettingsController.m:
929         (-[SettingsController _populateMenu]):
930         (-[SettingsController validateMenuItem:]):
931         (-[SettingsController visualViewportEnabled]):
932         (-[SettingsController toggleVisualViewportEnabled:]):
933         * MiniBrowser/mac/WK1BrowserWindowController.m:
934         (-[WK1BrowserWindowController didChangeSettings]):
935         * MiniBrowser/mac/WK2BrowserWindowController.m:
936         (-[WK2BrowserWindowController didChangeSettings]):
937
938 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
939
940         Allow using make-dist with non-GTK ports
941         https://bugs.webkit.org/show_bug.cgi?id=160842
942
943         Reviewed by Michael Catanzaro.
944
945         This patch adds support for setting base name of tarball and argument
946         passed to cmake's -DPORT= via command line arguments.
947
948         * gtk/make-dist.py:
949         (Distcheck.configure):
950         (Distcheck.check):
951         (get_tarball_root_and_output_filename_from_arguments):
952
953 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
954
955         [GTK] Install script lacks gstreamer related dependencies
956         https://bugs.webkit.org/show_bug.cgi?id=160814
957
958         Reviewed by Carlos Garcia Campos.
959
960         * gtk/install-dependencies: Fedora case had already listed this dependencies,
961         but both Arch and Debian/Ubuntu were missing them.
962
963 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
964
965         make-dist.py should not allow unknown rules in manifest
966         https://bugs.webkit.org/show_bug.cgi?id=160841
967
968         Reviewed by Carlos Garcia Campos.
969
970         * gtk/make-dist.py:
971         (Manifest.process_line):
972
973 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
974
975         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
976         https://bugs.webkit.org/show_bug.cgi?id=160809
977
978         Reviewed by Carlos Garcia Campos.
979
980         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
981         case, and use it also for the new package names of libpng and libgeoclue.
982         * gtk/install-dependencies: Ditto.
983
984 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
985
986         Skip to check directories existence in build-webkit
987         https://bugs.webkit.org/show_bug.cgi?id=160691
988
989         Reviewed by Alex Christensen.
990
991         CMake checks if directories are there itself. So CMake ports
992         don't need to check it in the build-webkit script.
993
994         * Scripts/build-webkit:
995         * Scripts/webkitdirs.pm:
996         (determineSourceDir):
997         (isCMakeBuild):
998
999 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1000
1001         Make URLParser work with URLs missing URL parts
1002         https://bugs.webkit.org/show_bug.cgi?id=160824
1003
1004         Reviewed by Brady Eidson.
1005
1006         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1007         (TestWebKitAPI::s):
1008         (TestWebKitAPI::checkURL):
1009         (TestWebKitAPI::TEST_F):
1010         (TestWebKitAPI::eq): Deleted.
1011
1012 2016-08-12  John Wilander  <wilander@apple.com>
1013
1014         Add HashCountedSet API tests to TestWTFLibrary target
1015         https://bugs.webkit.org/show_bug.cgi?id=160815
1016
1017         Reviewed by Alex Christensen.
1018
1019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1020             Added HashCountedSet.cpp and sorted the file reference section
1021             according to UNIX sort.
1022
1023 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
1024
1025         run-benchmark should run JetStream 1.1 instead of 1.0.1
1026         https://bugs.webkit.org/show_bug.cgi?id=160816
1027
1028         Reviewed by Filip Pizlo.
1029
1030         Use the latest JetStream 1.1 in run-benchmark.
1031
1032         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1033         (BenchmarkBuilder.__exit__):
1034         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
1035         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
1036         change to JetStream directory.
1037
1038 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1039
1040         Initial URLParser implementation
1041         https://bugs.webkit.org/show_bug.cgi?id=160811
1042
1043         Reviewed by Brady Eidson.
1044
1045         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1046         (TestWebKitAPI::eq):
1047         (TestWebKitAPI::checkURL):
1048         (TestWebKitAPI::TEST_F):
1049
1050 2016-08-12  Brady Eidson  <beidson@apple.com>
1051
1052         Fix the 32-bit Mac build after:
1053         Add WK2 ExperimentalFeature support to MiniBrowser
1054         https://bugs.webkit.org/show_bug.cgi?id=160788
1055
1056         Unreviewed.
1057
1058         Sprinkle "#if WK_API_ENABLED"s liberally.
1059         
1060         * MiniBrowser/mac/AppDelegate.m:
1061         (defaultConfiguration):
1062         * MiniBrowser/mac/SettingsController.m:
1063         (-[SettingsController _populateMenu]):
1064         (-[SettingsController validateMenuItem:]):
1065
1066 2016-08-12  Philippe Normand  <pnormand@igalia.com>
1067
1068         [GStreamer][OWR] Video rendering fixes
1069         https://bugs.webkit.org/show_bug.cgi?id=160764
1070
1071         Reviewed by Xabier Rodriguez-Calvar.
1072
1073         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
1074
1075 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
1076
1077         Add missing return statement in convertFast function added in r204376.
1078
1079         Unreviewed.
1080
1081         * Scripts/webkitpy/common/system/path.py:
1082         (_CygPath.convertFast):
1083
1084 2016-08-11  Brady Eidson  <beidson@apple.com>
1085
1086         Add WK2 ExperimentalFeature support to MiniBrowser.
1087         https://bugs.webkit.org/show_bug.cgi?id=160788
1088
1089         Reviewed by Alex Christensen.
1090
1091         * MiniBrowser/mac/AppDelegate.h:
1092         * MiniBrowser/mac/AppDelegate.m:
1093         (defaultConfiguration):
1094         (defaultPreferences):
1095         
1096         * MiniBrowser/mac/SettingsController.m:
1097         (-[SettingsController _populateMenu]):
1098         (-[SettingsController validateMenuItem:]):
1099         (-[SettingsController toggleExperimentalFeature:]):
1100
1101 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1102
1103         Keep EWS logs for longer
1104         https://bugs.webkit.org/show_bug.cgi?id=160776
1105
1106         Reviewed by Daniel Bates.
1107
1108         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
1109
1110 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
1111
1112         iOS DRT/WTR project cleanup
1113         https://bugs.webkit.org/show_bug.cgi?id=160778
1114
1115         Reviewed by Tim Horton.
1116
1117         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
1118
1119         Remove AppDelegate.* which were unused.
1120
1121         Exclude ios/Launch.storyboard on more platforms.
1122
1123         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1124         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1125         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1126         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1127         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
1128         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
1129         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
1130
1131 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1132
1133         Fix Yosemite bots' cookie accept policies after r204365.
1134         https://bugs.webkit.org/show_bug.cgi?id=160758
1135
1136         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1137         (TEST):
1138         This makes the test fully clean up after itself.
1139
1140 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1141
1142         Fix Yosemite bots' cookie accept policies after r204365.
1143         https://bugs.webkit.org/show_bug.cgi?id=160758
1144
1145         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1146         (TEST):
1147         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
1148         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
1149         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
1150         causing any problems because there are no other API tests that do anything with cookies.
1151         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
1152         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
1153         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
1154
1155 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1156
1157         EWS should check if the patch is still valid before executing every major step
1158         https://bugs.webkit.org/show_bug.cgi?id=160739
1159         rdar://problem/27768813
1160
1161         Reviewed by Alexey Proskuryakov.
1162
1163         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1164         (CommitQueueTask.run): validate method is now executed in base class.
1165         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1166         (EarlyWarningSystemTask.run): validate method is now executed in base class.
1167         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1168         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
1169         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1170         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
1171         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
1172         * Scripts/webkitpy/tool/commands/perfalizer.py:
1173         (PerfalizerTask.validate): Added.
1174         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1175         (test_manual_reject_during_processing): Updated test case.
1176
1177 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1178
1179         Add URLParser stub
1180         https://bugs.webkit.org/show_bug.cgi?id=160770
1181
1182         Reviewed by Sam Weinig.
1183
1184         * TestWebKitAPI/PlatformGTK.cmake:
1185         * TestWebKitAPI/PlatformWin.cmake:
1186         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1187         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
1188         (TestWebKitAPI::TEST_F):
1189
1190 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1191
1192         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
1193         https://bugs.webkit.org/show_bug.cgi?id=160761
1194
1195         Reviewed by Tim Horton.
1196
1197         Give iOS DRT a Launch storyboard.
1198
1199         Have it use a UIViewController so future forms testing works correctly.
1200
1201         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
1202         can run in iPad mode.
1203
1204         Remove empty InfoPlist.strings files.
1205
1206         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1207         * DumpRenderTree/ios/Info.plist:
1208         * DumpRenderTree/ios/Launch.storyboard: Added.
1209         * DumpRenderTree/mac/DumpRenderTree.mm:
1210         (createWebViewAndOffscreenWindow):
1211         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1212         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
1213         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1214         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
1215
1216 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
1217
1218         [Win] Unable to reliably run tests in parallel
1219         https://bugs.webkit.org/show_bug.cgi?id=140914
1220
1221         Reviewed by Brent Fulgham.
1222
1223         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1224         processes. We can use string replacement to convert the Cygwin path to a Windows path
1225         instead.
1226
1227         * Scripts/webkitpy/common/system/path.py:
1228         (cygpathFast):
1229         * Scripts/webkitpy/port/driver.py:
1230         (Driver._command_from_driver_input):
1231
1232 2016-08-10  Alex Christensen  <achristensen@webkit.org>
1233
1234         Fix crash when changing cookie accept policy after r204327
1235         https://bugs.webkit.org/show_bug.cgi?id=160758
1236
1237         Reviewed by Simon Fraser.
1238
1239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1240         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
1241         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
1242         (TEST):
1243         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
1244
1245 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1246
1247         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
1248         https://bugs.webkit.org/show_bug.cgi?id=160757
1249
1250         Reviewed by Tim Horton.
1251
1252         When programmatically creating the test UIWindow, make a root UIViewController and parent
1253         the WKWebView in its view. This makes the app more like a normal UIKit application.
1254         
1255         Move the WKWebView down 20px to avoid the status bar.
1256         
1257         Give the UIWindow a gray background so it's obvious where the window and view positioned.
1258
1259         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
1260         
1261         Remove duplicate references to Launch.storyboard.
1262
1263         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1264         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
1265         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
1266         (-[AppDelegate applicationWillResignActive:]): Deleted.
1267         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
1268         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
1269         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
1270         (-[AppDelegate applicationWillTerminate:]): Deleted.
1271         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1272         (WTR::viewRectForWindowRect):
1273         (WTR::PlatformWebView::PlatformWebView):
1274         (WTR::PlatformWebView::setWindowFrame):
1275
1276 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1277
1278         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
1279         https://bugs.webkit.org/show_bug.cgi?id=160748
1280
1281         Reviewed by Tim Horton.
1282         
1283         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
1284         opens the door for tests using other device sizes.
1285
1286         * WebKitTestRunner/ios/TestControllerIOS.mm:
1287         (WTR::TestController::platformConfigureViewForTest):
1288
1289 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1290
1291         Sort the feature flags in the FEATURE_DEFINES lines
1292         https://bugs.webkit.org/show_bug.cgi?id=160742
1293
1294         Reviewed by Anders Carlsson.
1295         
1296         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1297
1298 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
1299
1300         Logging and other minor improvements to iOS webkitpy
1301         https://bugs.webkit.org/show_bug.cgi?id=160722
1302
1303         Reviewed by Dan Bates.
1304
1305         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
1306         to make it easier to debug launching issues.
1307
1308         Have reset_preferences() reset the device, rather than just nuking the data
1309         directory (which broke some versions of the simulator).
1310
1311         Make the Simulator.app launch in the background with open -g.
1312
1313         Wait for the simulator device to be in a known state in some more places.
1314
1315         * Scripts/webkitpy/port/ios.py:
1316         (IOSSimulatorPort.setup_test_run):
1317         (IOSSimulatorPort._quit_ios_simulator):
1318         (IOSSimulatorPort.clean_up_test_run):
1319         (IOSSimulatorPort.setup_environ_for_server):
1320         (IOSSimulatorPort.reset_preferences):
1321         * Scripts/webkitpy/xcode/simulator.py:
1322         (Device.create):
1323         (Device.delete):
1324         (Device):
1325         (Device.reset):
1326         (Simulator.wait_until_device_is_booted):
1327         (Simulator.wait_until_device_is_in_state):
1328         (Simulator):
1329         (Simulator.delete_device):
1330         (Simulator.reset_device):
1331         (Simulator.lookup_or_create_device):
1332
1333 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1334
1335         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
1336         https://bugs.webkit.org/show_bug.cgi?id=160697
1337
1338         Reviewed by Antonio Gomes.
1339
1340         * Scripts/webkitpy/port/base.py:
1341         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
1342         list of environment variables to copy.
1343
1344 2016-08-09  George Ruan  <gruan@apple.com>
1345
1346         Implement functionality of media capture on iOS
1347         https://bugs.webkit.org/show_bug.cgi?id=158945
1348         <rdar://problem/26893343>
1349
1350         Reviewed by Tim Horton.
1351
1352         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
1353         Capture feature on iOS.
1354
1355 2016-08-09  Saam Barati  <sbarati@apple.com>
1356
1357         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
1358         https://bugs.webkit.org/show_bug.cgi?id=160671
1359         <rdar://problem/27756112>
1360
1361         Reviewed by Mark Lam.
1362
1363         * Scripts/run-jsc-stress-tests:
1364
1365 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
1366
1367         Make directory reading code in iOSSimulatorDevices() more strict
1368         https://bugs.webkit.org/show_bug.cgi?id=160702
1369
1370         Reviewed by Tim Horton.
1371
1372         * Scripts/webkitdirs.pm:
1373         (iOSSimulatorDevices):
1374
1375 2016-08-06  Sam Weinig  <sam@webkit.org>
1376
1377         Replace NodeOrString with std::variant<RefPtr<Node>, String>
1378         https://bugs.webkit.org/show_bug.cgi?id=160638
1379
1380         Reviewed by Anders Carlsson.
1381
1382         * TestWebKitAPI/CMakeLists.txt:
1383         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1384         Add additional tests for the initial state of std::variant and using
1385         makeVisitor for visiting.
1386
1387 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
1388
1389         EWS logging should ensure the logging to file is stopped on queue termination
1390         https://bugs.webkit.org/show_bug.cgi?id=160698
1391         rdar://problem/24464570
1392
1393         Reviewed by Daniel Bates.
1394
1395         * Scripts/webkitpy/tool/bot/queueengine.py:
1396         (QueueEngine._stopping): Stop logging to file on queue termination.
1397         (QueueEngine._begin_logging): Configure the Python logger to log to file.
1398         * Scripts/webkitpy/common/system/logutils.py:
1399         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1400         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1401         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1402         * Scripts/webkitpy/tool/commands/queues.py:
1403         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1404         (AbstractQueue.queue_log_path): Same.
1405         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1406         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1407         which moved to QueueEngine now.
1408         (PatchProcessingQueue.__init__): Same.
1409         (CommitQueue.__init__): Same.
1410         (AbstractReviewQueue.__init__): Same.
1411         (StyleQueue.__init__): Same.
1412         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1413         (TestCommitQueue): Removed host parameter.
1414         (TestCommitQueue.__init__): Same.
1415         (AbstractPatchQueueTest.test_next_patch): Same.
1416         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1417         (test_commit_queue_failure): Same.
1418         (mock_run_webkit_patch):
1419         (MockCommitQueueTask.results_from_patch_test_run): Same.
1420         (test_rollout_lands): Same.
1421         (test_non_valid_patch): Same.
1422         (test_auto_retry): Same.
1423         (test_style_queue_with_watch_list_exception): Same.
1424         (TestQueue.__init__): Deleted.
1425         (TestReviewQueue.__init__): Deleted.
1426         (TestFeederQueue.__init__): Deleted.
1427
1428 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
1429
1430         webkit-gtk tarball fails to build due to missing files
1431         https://bugs.webkit.org/show_bug.cgi?id=160684
1432
1433         Reviewed by Alex Christensen.
1434
1435         * gtk/manifest.txt.in: Added back spi directories.
1436
1437 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1438
1439         [GTK] Build the jhbuild with -O2 optimization level by default
1440         https://bugs.webkit.org/show_bug.cgi?id=160544
1441
1442         Reviewed by Michael Catanzaro.
1443
1444         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1445         which don't increases the required disk space significatively and
1446         provides better debug information than no passing it.
1447
1448 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
1449
1450         Allow more --cmakeargs option in build-jsc and build-webkit
1451         https://bugs.webkit.org/show_bug.cgi?id=160340
1452
1453         Reviewed by Michael Catanzaro.
1454
1455         * Scripts/build-jsc:
1456         * Scripts/build-webkit:
1457
1458 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1459
1460         Do not check if WebKitLibraries folder exists on EFL and GTK
1461         https://bugs.webkit.org/show_bug.cgi?id=160659
1462
1463         Reviewed by Csaba Osztrogonác.
1464
1465         Though WebKitLibraries is only needed by mac and win ports,
1466         EFL and GTK ports have checked whether it exists.
1467
1468         * Scripts/build-webkit:
1469
1470 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
1471
1472         Some EWS console logs doesn't go to log file
1473         https://bugs.webkit.org/show_bug.cgi?id=160585
1474         rdar://problem/24464570
1475
1476         Reviewed by Daniel Bates.
1477
1478         * Scripts/webkitpy/common/system/logutils.py:
1479         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
1480         any possible overwriting.
1481         * Scripts/webkitpy/common/system/filesystem.py:
1482         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
1483         * Scripts/webkitpy/common/system/filesystem_mock.py:
1484         (MockFileSystem.open_text_file_for_writing): Same.
1485         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1486         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
1487         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
1488         * Scripts/webkitpy/tool/commands/queues.py:
1489         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
1490         This will ensure that all the sub-modules inside webkitpy will log to file.
1491
1492 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
1493
1494         Have the iOS platform interit from the Apple platform in webkitpy
1495         https://bugs.webkit.org/show_bug.cgi?id=160672
1496
1497         Reviewed by Dan Bates.
1498         
1499         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
1500         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
1501         ApplePort.
1502         
1503         Since WinPort also inherits from ApplePort, it needs to stub out some things
1504         that are unavailable on Windows (leaks, sampling).
1505         
1506         Some SnowLeopard-related code and the associated test were removed.
1507
1508         * Scripts/webkitpy/port/apple.py:
1509         (ApplePort.__init__):
1510         (ApplePort):
1511         (ApplePort._make_leak_detector):
1512         (ApplePort.default_timeout_ms):
1513         (ApplePort.supports_per_test_timeout):
1514         (ApplePort.should_retry_crashes):
1515         (ApplePort._generate_all_test_configurations):
1516         (ApplePort.check_for_leaks):
1517         (ApplePort.print_leaks_summary):
1518         (ApplePort._path_to_webcore_library):
1519         (ApplePort.show_results_html_file):
1520         (ApplePort._merge_crash_logs):
1521         (ApplePort._look_for_all_crash_logs_in_log_dir):
1522         (ApplePort._get_crash_log):
1523         (ApplePort.look_for_new_crash_logs):
1524         (ApplePort.sample_process):
1525         (ApplePort.sample_file_path):
1526         (ApplePort.look_for_new_samples):
1527         (ApplePort._path_to_helper):
1528         (ApplePort.determine_full_port_name): Deleted.
1529         * Scripts/webkitpy/port/ios.py:
1530         (IOSSimulatorPort):
1531         (IOSSimulatorPort.__init__):
1532         (IOSSimulatorPort.default_timeout_ms): Deleted.
1533         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1534         (IOSSimulatorPort.should_retry_crashes): Deleted.
1535         (IOSSimulatorPort.check_for_leaks): Deleted.
1536         (IOSSimulatorPort.print_leaks_summary): Deleted.
1537         (IOSSimulatorPort._path_to_webcore_library): Deleted.
1538         (IOSSimulatorPort.show_results_html_file): Deleted.
1539         (IOSSimulatorPort.sample_file_path): Deleted.
1540         (IOSSimulatorPort._merge_crash_logs): Deleted.
1541         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1542         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1543         (IOSSimulatorPort.look_for_new_samples): Deleted.
1544         (IOSSimulatorPort.sample_process): Deleted.
1545         (IOSSimulatorPort._path_to_helper): Deleted.
1546         (IOSSimulatorPort.make_command): Deleted.
1547         * Scripts/webkitpy/port/mac.py:
1548         (MacPort.__init__):
1549         (MacPort.make_command):
1550         (MacPort._build_java_test_support):
1551         (MacPort): Deleted.
1552         (MacPort.default_timeout_ms): Deleted.
1553         (MacPort.supports_per_test_timeout): Deleted.
1554         (MacPort.should_retry_crashes): Deleted.
1555         (MacPort.default_child_processes): Deleted.
1556         (MacPort.check_for_leaks): Deleted.
1557         (MacPort.print_leaks_summary): Deleted.
1558         (MacPort._path_to_webcore_library): Deleted.
1559         (MacPort.show_results_html_file): Deleted.
1560         (MacPort.sample_file_path): Deleted.
1561         (MacPort._merge_crash_logs): Deleted.
1562         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1563         (MacPort.look_for_new_crash_logs): Deleted.
1564         (MacPort.look_for_new_samples): Deleted.
1565         (MacPort.sample_process): Deleted.
1566         (MacPort._path_to_helper): Deleted.
1567         * Scripts/webkitpy/port/mac_unittest.py:
1568         (MacTest.test_default_child_processes): Deleted.
1569         * Scripts/webkitpy/port/win.py:
1570         (WinPort.look_for_new_samples):
1571         (WinPort):
1572         (WinPort.sample_process):
1573         (WinPort._make_leak_detector):
1574         (WinPort.check_for_leaks):
1575         (WinPort.print_leaks_summary):
1576         (WinPort._path_to_webcore_library):
1577
1578 2016-08-08  Matt Baker  <mattbaker@apple.com>
1579
1580         Unreviewed: moved myself to the reviewers list.
1581
1582         * Scripts/webkitpy/common/config/contributors.json:
1583
1584 2016-08-08  Chris Dumez  <cdumez@apple.com>
1585
1586         Update API tests in mac/SetDocumentURI.mm after r204247
1587         https://bugs.webkit.org/show_bug.cgi?id=160660
1588
1589         Reviewed by Alex Christensen.
1590
1591         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1592         (TestWebKitAPI::TEST):
1593
1594 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
1595
1596         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1597         https://bugs.webkit.org/show_bug.cgi?id=159827
1598
1599         Reviewed by Daniel Bates.
1600
1601         This change was spurred by a process hang which occurred between tests and did
1602         not produce a meaningful crashlog.
1603
1604         * Scripts/webkitpy/port/driver.py:
1605         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1606
1607          * Scripts/webkitpy/port/ios.py:
1608         (IOSSimulatorPort):
1609         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1610         * Scripts/webkitpy/port/mac.py:
1611         (MacPort):
1612         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1613
1614         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1615         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1616
1617         * WebKitTestRunner/TestController.h:
1618         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1619         * WebKitTestRunner/TestInvocation.cpp:
1620         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1621
1622 2016-08-07  Dan Bernstein  <mitz@apple.com>
1623
1624         [Cocoa] Reply block leaks if the remote object doesn’t call it
1625         https://bugs.webkit.org/show_bug.cgi?id=160642
1626
1627         Reviewed by Sam Weinig.
1628
1629         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1630         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1631         (TEST): Added a test case that checks that the reply block is released even when it’s not
1632           called.
1633         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1634         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1635           calling the completion handler.
1636
1637 2016-08-07  Chris Dumez  <cdumez@apple.com>
1638
1639         Write API test to cover crash fix in r204135
1640         https://bugs.webkit.org/show_bug.cgi?id=160587
1641
1642         Reviewed by Darin Adler.
1643
1644         Add API test to cover crash fix in r204135. This reproduces the crash
1645         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1646         callback.
1647
1648         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1649         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1650         (TEST):
1651
1652 2016-08-06  Chris Dumez  <cdumez@apple.com>
1653
1654         Unreviewed, rolling out r204226.
1655
1656         Broke some API tests
1657
1658         Reverted changeset:
1659
1660         "Write API test to cover crash fix in r204135"
1661         https://bugs.webkit.org/show_bug.cgi?id=160587
1662         http://trac.webkit.org/changeset/204226
1663
1664 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1665
1666         EWS Style Queue fails to process patches which fails validation
1667         https://bugs.webkit.org/show_bug.cgi?id=160632
1668
1669         Reviewed by Alexey Proskuryakov.
1670
1671         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1672         (StyleQueueTask.validate): Add more information about validation failure.
1673         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1674         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1675         (test_non_valid_patch): Add a unit test to test the above code path.
1676
1677 2016-08-06  Sam Weinig  <sam@webkit.org>
1678
1679         WTF needs a variant implementation
1680         https://bugs.webkit.org/show_bug.cgi?id=160618
1681
1682         Reviewed by Darin Adler.
1683
1684         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1685         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1686         Add tests for the variant implementation.
1687
1688 2016-08-06  Chris Dumez  <cdumez@apple.com>
1689
1690         Write API test to cover crash fix in r204135
1691         https://bugs.webkit.org/show_bug.cgi?id=160587
1692
1693         Reviewed by Darin Adler.
1694
1695         Add API test to cover crash fix in r204135. This reproduces the crash
1696         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1697         callback.
1698
1699         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1700         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1701         (TEST):
1702
1703 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1704
1705         run-api-tests should use a headed simulator
1706         https://bugs.webkit.org/show_bug.cgi?id=160611
1707
1708         Reviewed by Sam Weinig.
1709
1710         CADisplayLink doesn't work in a headless simulator, but is
1711         vital for the proper functioning of WebKit2 painting on iOS.
1712         So, we should not use a headless simulator.
1713
1714         * Scripts/run-api-tests:
1715         Launch a simulator app, don't just boot the simulator.
1716
1717         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1718         Re-enable a test that works now.
1719
1720 2016-08-05  Dan Bernstein  <mitz@apple.com>
1721
1722         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1723         https://bugs.webkit.org/show_bug.cgi?id=160589
1724
1725         Reviewed by Tim Horton.
1726
1727         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1728         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1729           blocks, which wasn’t caught because the test wasn’t run correctly.
1730         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1731         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1732           added a test that sends over an NSRange.
1733         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1734         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1735           handler with the range‘s location and length.
1736
1737 2016-08-05  Enrica Casucci  <enrica@apple.com>
1738
1739         Fixing tests failing after r204175.
1740
1741         Unreviewed.
1742
1743         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1744
1745 2016-08-05  Enrica Casucci  <enrica@apple.com>
1746
1747         Build fix after 204053.
1748
1749         Unreviewed.
1750
1751         * TestWebKitAPI/Configurations/Base.xcconfig:
1752         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1753         (-[MockContentFilterEnabler initWithCoder:]):
1754         (-[MockContentFilterEnabler dealloc]):
1755
1756 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1757
1758         Print test name in "Last character read from DRT..." error message.
1759         https://bugs.webkit.org/show_bug.cgi?id=160559
1760
1761         Reviewed by Michael Catanzaro.
1762
1763         * Scripts/webkitpy/port/driver.py:
1764         (Driver.run_test):
1765         (Driver._read_first_block):
1766         (Driver._read_optional_image_block):
1767         (Driver._read_block):
1768         * Scripts/webkitpy/port/driver_unittest.py:
1769         (DriverTest.test_read_block):
1770         (DriverTest.test_read_binary_block):
1771         (DriverTest.test_read_base64_block):
1772
1773 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1774
1775         Unreviewed, rolling out r204123.
1776         https://bugs.webkit.org/show_bug.cgi?id=160597
1777
1778         Caused layout test timeouts on Windows. (Requested by perarne
1779         on #webkit).
1780
1781         Reverted changeset:
1782
1783         "[Win] Unable to reliably run tests in parallel"
1784         https://bugs.webkit.org/show_bug.cgi?id=140914
1785         http://trac.webkit.org/changeset/204123
1786
1787 2016-08-04  Saam Barati  <sbarati@apple.com>
1788
1789         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1790         https://bugs.webkit.org/show_bug.cgi?id=151241
1791
1792         Reviewed by Benjamin Poulain.
1793
1794         * Scripts/run-jsc-stress-tests:
1795
1796 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1797
1798         UI improvements to Flakiness Dashboard.
1799         https://bugs.webkit.org/show_bug.cgi?id=153295
1800
1801         Reviewed by Alexey Proskuryakov.
1802
1803         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1804         (td.options-container): Center text in most fields.
1805         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1806         (createBugHTML): Text/Grammar updates.
1807         (tableHeaders): Ditto.
1808         (htmlForSingleTestRow): Ditto.
1809         (headerForTestTableHtml): Ditto.
1810         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1811         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1812
1813 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1814
1815         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1816         https://bugs.webkit.org/show_bug.cgi?id=160518
1817
1818         Reviewed by Michael Catanzaro.
1819
1820         * Scripts/webkitpy/thirdparty/__init__.py:
1821         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1822         * gtk/install-dependencies:
1823
1824 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1825
1826         Optimize bot watcher's dashboard a little
1827         https://bugs.webkit.org/show_bug.cgi?id=160515
1828         rdar://problem/26096900
1829
1830         Reviewed by Lucas Forschler.
1831
1832         Made re-sorting after loading an iteration more efficient.
1833
1834         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1835         (BuildbotIteration.prototype._updateWithData):
1836         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1837         (BuildbotQueue.prototype.updateIterationPosition):
1838
1839 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1840
1841         [Win] Unable to reliably run tests in parallel
1842         https://bugs.webkit.org/show_bug.cgi?id=140914
1843
1844         Reviewed by Brent Fulgham.
1845
1846         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1847         processes. We can use string replacement to convert the Cygwin path to a Windows path
1848         instead.
1849  
1850         * Scripts/webkitpy/common/system/path.py:
1851         (cygpathFast):
1852         * Scripts/webkitpy/port/driver.py:
1853         (Driver._command_from_driver_input):
1854
1855 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1856
1857         Document instructions for increasing process and file limits
1858         https://bugs.webkit.org/show_bug.cgi?id=160528
1859         rdar://problem/24777576
1860
1861         Reviewed by Alexey Proskuryakov.
1862
1863         * Scripts/webkitpy/port/ios.py:
1864         (IOSSimulatorPort.default_child_processes):
1865
1866 2016-08-03  Anders Carlsson  <andersca@apple.com>
1867
1868         Remove the Objective-C bindings generator
1869         https://bugs.webkit.org/show_bug.cgi?id=160526
1870
1871         Reviewed by Sam Weinig.
1872
1873         * Scripts/run-bindings-tests:
1874         Update test.
1875
1876 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1877
1878         Revise a TestWebKitAPI comment to mention the actual underlying problem
1879
1880         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1881         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1882
1883 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1884
1885         Benchmark test content-animation timeouts always
1886         https://bugs.webkit.org/show_bug.cgi?id=160057
1887
1888         Reviewed by Simon Fraser.
1889
1890         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1891         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1892         (start):
1893
1894 2016-08-02  Nan Wang  <n_wang@apple.com>
1895
1896         AX: Simulated touch events are not working on iOS
1897         https://bugs.webkit.org/show_bug.cgi?id=160395
1898         <rdar://problem/27633597>
1899
1900         Reviewed by Chris Fleizach.
1901
1902         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1903         (WTR::AccessibilityUIElement::press):
1904         (WTR::AccessibilityUIElement::setSelectedChild):
1905
1906 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1907
1908         run-javascriptcore-tests should accept multiple --extra-tests
1909         https://bugs.webkit.org/show_bug.cgi?id=160486
1910
1911         Reviewed by Saam Barati.
1912         
1913         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1914         test suites. This does it by using GetOpt::Long's array support.
1915
1916         * Scripts/run-javascriptcore-tests:
1917         (runJSCStressTests):
1918
1919 2016-08-02  Enrica Casucci  <enrica@apple.com>
1920
1921         Allow building with content filtering disabled.
1922         https://bugs.webkit.org/show_bug.cgi?id=160454
1923
1924         Reviewed by Simon Fraser.
1925
1926         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1927
1928 2016-08-02  Brady Eidson  <beidson@apple.com>
1929
1930         Removing IndexedDB WebsiteData can fail for some users.
1931         https://bugs.webkit.org/show_bug.cgi?id=160463
1932
1933         Reviewed by Alex Christensen.
1934
1935         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1936
1937 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1938
1939         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1940         https://bugs.webkit.org/show_bug.cgi?id=160437
1941         <rdar://problem/27578272>
1942
1943         Reviewed by Brady Eidson.
1944
1945         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1946         (-[DownloadDelegate _download:didReceiveResponse:]):
1947         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1948         (runTest):
1949         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1950
1951 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1952
1953         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1954         https://bugs.webkit.org/show_bug.cgi?id=160414
1955
1956         Reviewed by Michael Catanzaro.
1957
1958         * Scripts/webkitpy/port/linux_get_crash_log.py:
1959         (GDBCrashLogGenerator._wait_for_corefile):
1960
1961 2016-08-01  Youenn Fablet  <youenn@apple.com>
1962
1963         Make wpt server generate its certificates in layout test results folder
1964         https://bugs.webkit.org/show_bug.cgi?id=160422
1965
1966         Reviewed by Chris Dumez.
1967
1968         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1969         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1970
1971 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1972
1973         Function Call on NULL Object
1974         https://bugs.webkit.org/show_bug.cgi?id=160325
1975
1976         Reviewed by Darin Adler.
1977
1978         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1979         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1980         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1981
1982 2016-08-01  Keith Miller  <keith_miller@apple.com>
1983
1984         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1985         https://bugs.webkit.org/show_bug.cgi?id=160372
1986
1987         Rubber stamped by Geoffrey Garen.
1988
1989         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1990         a new top level directory, JSTests. Having the tests in the Source directory
1991         was both confusing an inconvenient for people that just want to checkout the
1992         source code of WebKit. Since there is no other obvious place to put all the
1993         JavaScript tests a new top level directory seemed the most sensible.
1994
1995         * Scripts/import-test262-tests:
1996         * Scripts/run-javascriptcore-tests:
1997         * Scripts/update-javascriptcore-test-res:
1998
1999 2016-07-31  Nan Wang  <n_wang@apple.com>
2000
2001         AX: Add a check for touch event listener on iOS accessibility object
2002         https://bugs.webkit.org/show_bug.cgi?id=160388
2003
2004         Reviewed by Chris Fleizach.
2005
2006         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2007         (AccessibilityUIElement::boolAttributeValue):
2008         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2009         (WTR::AccessibilityUIElement::boolAttributeValue):
2010
2011 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
2012
2013         Unreviewed: add myself to the reviewers list.
2014
2015         * Scripts/webkitpy/common/config/contributors.json:
2016
2017 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
2018
2019         Undo r203939, and copy over a rule that clips the logos.
2020
2021         Sierra wasn't the only logo without transparency.
2022
2023         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2024         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2025         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2026
2027 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
2028
2029         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
2030         https://bugs.webkit.org/show_bug.cgi?id=160377
2031
2032         Reviewed by Brian Weinstein.
2033
2034         Update assets to remove the white background and use a transparent background instead.
2035
2036         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2037         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2038
2039 2016-07-29  David Kilzer  <ddkilzer@apple.com>
2040
2041         Ignore most check-webkit-style checks for ANGLE project
2042         <https://webkit.org/b/160333>
2043
2044         Reviewed by Daniel Bates.
2045
2046         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
2047         - No tabs.
2048         - No spaces at the end of lines.
2049         - No carriage returns (DOS line endings).
2050
2051 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2052
2053         Media controls are not displayed for some autoplaying videos at certain browser dimensions
2054         https://bugs.webkit.org/show_bug.cgi?id=160360
2055         <rdar://problem/27179484>
2056
2057         Reviewed by Myles C. Maxfield.
2058
2059         Adds two tests verifying that videos may be considered main content as long as they
2060         are large enough and cover a majority of the mainframe's viewport.
2061
2062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2063         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2064         (TestWebKitAPI::TEST):
2065         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
2066         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
2067
2068 2016-07-29  Mark Lam  <mark.lam@apple.com>
2069
2070         Gardening: removed unused variable.
2071
2072         Not reviewed.
2073
2074         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2075         (TestWebKitAPI::TEST):
2076
2077 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2078
2079         Add TestWebKitAPI support for interacting with media controls
2080         https://bugs.webkit.org/show_bug.cgi?id=160342
2081         <rdar://problem/27610246>
2082
2083         Reviewed by Beth Dakin.
2084
2085         Adds support for testing interaction with some media controls, as well as a basic test
2086         verifying that media control teardown after interaction does not result in a crash.
2087
2088         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2089         (-[WKWebView mouseDownAtPoint:]):
2090         (-[WKWebView performAfterLoading:]):
2091         (TestWebKitAPI::TEST):
2092
2093 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
2094
2095         Crash Log Clobbering on Unbound Crashes
2096         https://bugs.webkit.org/show_bug.cgi?id=160198
2097         <rdar://problem/27472618>
2098
2099         Reviewed by Alexey Proskuryakov.
2100
2101         * Scripts/webkitpy/common/system/crashlogs.py:
2102         (CrashLogs): Fix header order.
2103         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2104         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
2105
2106 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2107
2108         Update for contributors.json
2109         https://bugs.webkit.org/show_bug.cgi?id=160294
2110
2111         * Scripts/webkitpy/common/config/contributors.json:
2112
2113 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
2114
2115         Remove deprecated SPI for video inline / fullscreen controls
2116         https://bugs.webkit.org/show_bug.cgi?id=160318
2117
2118         Reviewed by Tim Horton.
2119
2120         * DumpRenderTree/mac/DumpRenderTree.mm:
2121         (setDefaultsToConsistentValuesForTesting): Deleted.
2122         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2123         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2124         * WebKitTestRunner/TestController.cpp:
2125         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2126         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2127         (WTR::initializeWebViewConfiguration): Deleted.
2128
2129 2016-07-28  Daniel Bates  <dabates@apple.com>
2130
2131         [iOS] TestWebKitAPI bundle targets are not code signed
2132         https://bugs.webkit.org/show_bug.cgi?id=160328
2133         <rdar://problem/27409246>
2134
2135         Reviewed by Andy Estes.
2136
2137         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
2138         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
2139         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
2140
2141         * TestWebKitAPI/Configurations/Base.xcconfig:
2142
2143 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2144
2145         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
2146
2147         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2148         (animatedResizeWebView):
2149         (TEST):
2150         This test times out only when run in the WebKit Testing simulator environment,
2151         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
2152
2153 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2154
2155         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
2156         https://bugs.webkit.org/show_bug.cgi?id=160289
2157         <rdar://problem/27553464>
2158
2159         Reviewed by Simon Fraser.
2160
2161         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2163         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
2164         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
2165         (-[AnimatedResizeWebView _endAnimatedResize]):
2166         (animatedResizeWebView):
2167         (TEST):
2168         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
2169         Add two tests that ensure that hidden-content and animated resizes
2170         don't cause unnecessary synchronous waits. Only the hidden-content
2171         one fails before my patch, but it seemed reasonable to add both anyway.
2172
2173 2016-07-28  David Kilzer  <ddkilzer@apple.com>
2174
2175         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
2176         <https://webkit.org/b/83342>
2177
2178         Reviewed by Ryosuke Niwa.
2179
2180         * Scripts/webkitpy/common/checkout/scm/git.py:
2181         (Git.revisions_changing_file): Remove code to raise an exception
2182         when the file doesn't exist.  If a file was moved or renamed,
2183         then this caused the script to terminate, which was very
2184         frustrating when you wanted a list of reviewers.
2185         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2186         (SCMTest._shared_test_revisions_changing_file): Update test
2187         expectation to return an empty list of revisions.
2188         (test_create_patch_is_full_patch): Drive-by fix when running all
2189         webkitpy tests (including scm tests).
2190         * Scripts/webkitpy/common/checkout/scm/svn.py:
2191         (SVN.revisions_changing_file): Catch ScriptError exceptions and
2192         return an empty array of revisions if this occurs.
2193
2194 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
2195
2196         EWS error message "Error: * did not process patch" should include explanation
2197         https://bugs.webkit.org/show_bug.cgi?id=159903
2198         <rdar://problem/27410788>
2199
2200         Reviewed by Alexey Proskuryakov.
2201
2202         * QueueStatusServer/handlers/statusbubble.py:
2203         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
2204         is not processed.
2205         * QueueStatusServer/handlers/processingtimesjson.py:
2206         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
2207         of the code.
2208         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2209         (CommitQueueTask.validate): Add more information about validation failure.
2210         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2211         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2212         (EarlyWarningSystemTask.validate): Add more information about validation failure.
2213         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
2214         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2215         (PatchIsNotValid.__init__): Add the failure_message argument.
2216         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2217         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
2218         failure details.
2219         * Scripts/webkitpy/tool/commands/queues.py:
2220         (CommitQueue.process_work_item): Same.
2221         (StyleQueue.review_patch): Same.
2222         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2223         (test_non_valid_patch): Updated test-cases messages to match the above changes.
2224
2225 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
2226
2227         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
2228         https://bugs.webkit.org/show_bug.cgi?id=160262
2229
2230         Reviewed by Daniel Bates.
2231
2232         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2233         (-[LTRelayController installApp]):
2234
2235 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
2236
2237         Disable WebCoreNSURLSessionTest API tests on ios-simulator
2238         https://bugs.webkit.org/show_bug.cgi?id=160225
2239
2240         Reviewed by Alexey Proskuryakov.
2241
2242         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2243
2244 2016-07-27  Miguel Gomez  <magomez@igalia.com>
2245
2246         [GTK] Fix some video/canvas tests that should be passing
2247         https://bugs.webkit.org/show_bug.cgi?id=160023
2248
2249         Reviewed by Carlos Garcia Campos.
2250
2251         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
2252         EFL or GTK platforms.
2253
2254         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2255         (WTR::TestController::platformConfigureViewForTest):
2256         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2257         (WTR::TestController::platformConfigureViewForTest):
2258
2259 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2260
2261         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
2262         https://bugs.webkit.org/show_bug.cgi?id=160247
2263
2264         Reviewed by Michael Catanzaro.
2265
2266         * BuildSlaveSupport/built-product-archive:
2267         (createZip):
2268         (dirContainsdwo):
2269         (archiveBuiltProduct):
2270
2271 2016-07-26  Alex Christensen  <achristensen@webkit.org>
2272
2273         Fix tests after r203743.
2274         https://bugs.webkit.org/show_bug.cgi?id=156947
2275
2276         * WebKitTestRunner/TestController.cpp:
2277         (WTR::TestController::resetStateToConsistentValues):
2278         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
2279
2280 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2281
2282         [iPhone] Playing a video on tudou.com plays only sound, no video
2283         https://bugs.webkit.org/show_bug.cgi?id=160178
2284         <rdar://problem/27535468>
2285
2286         Reviewed by Dan Bernstein.
2287
2288         * DumpRenderTree/mac/DumpRenderTree.mm:
2289         (setDefaultsToConsistentValuesForTesting):
2290         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2291         (RequiresUserActionForPlaybackTest::SetUp):
2292         * WebKitTestRunner/TestController.cpp:
2293         (WTR::TestController::resetPreferencesToConsistentValues):
2294         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2295         (WTR::initializeWebViewConfiguration):
2296
2297 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2298
2299         Allow LOG macros to be used outside the namespace, and other logging cleanup
2300         https://bugs.webkit.org/show_bug.cgi?id=160216
2301
2302         Reviewed by Anders Carlsson.
2303         
2304         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
2305
2306         * DumpRenderTree/TestRunner.cpp:
2307         * DumpRenderTree/mac/DumpRenderTree.mm:
2308         (resetWebViewToConsistentStateBeforeTesting):
2309
2310 2016-07-26  David Kilzer <ddkilzer@apple.com>
2311
2312         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
2313         https://bugs.webkit.org/show_bug.cgi?id=156947
2314         <rdar://problem/23325160>
2315
2316         Reviewed by Alex Christensen.
2317
2318         * DumpRenderTree/TestRunner.cpp:
2319         (TestRunner::TestRunner):
2320         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
2321         * DumpRenderTree/TestRunner.h:
2322         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2323         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2324         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2325         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2326         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2327         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2328         (WTR::TestRunner::queueNonLoadingScript):
2329         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2330         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2331         * WebKitTestRunner/TestController.cpp:
2332         (WTR::TestController::didReceiveAuthenticationChallenge):
2333         * WebKitTestRunner/TestController.h:
2334         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2335         * WebKitTestRunner/TestInvocation.cpp:
2336         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2337         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
2338
2339 2016-07-26  David Kilzer  <ddkilzer@apple.com>
2340
2341         check-for-exit-time-destructors should be usable outside Xcode
2342         <https://webkit.org/b/160195>
2343
2344         Reviewed by Darin Adler.
2345
2346         * Scripts/check-for-exit-time-destructors: Update to parse
2347         -h|--help switch, or to take one argument to a binary to check
2348         for exit time destructors on the command-line.  The clang
2349         compiler will find these at compile-time with the
2350         -Wexit-time-destructors switch, but this script will check for
2351         them after-the-fact.
2352
2353 2016-07-26  Lucas Forschler  <lforschler@apple.com>
2354
2355         Test svn.webkit.org functionality after maintenance.
2356
2357 2016-07-25  Brady Eidson  <beidson@apple.com>
2358
2359         Modern IDB: Make sure IndexedDB works from file:// url documents by default
2360         https://bugs.webkit.org/show_bug.cgi?id=153783
2361
2362         Reviewed by Alex Christensen.
2363
2364         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
2365         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
2366         
2367         As of https://trac.webkit.org/changeset/203695 this is no longer required.
2368         
2369         Change the relevant API tests to make sure this continues to be no longer required.
2370
2371         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2372         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2373         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2374         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2375         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2376         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2377
2378 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2379
2380         Media controls should not be displayed for a video until it starts playing
2381         https://bugs.webkit.org/show_bug.cgi?id=160092
2382         <rdar://problem/26986673>
2383
2384         Reviewed by Beth Dakin.
2385
2386         Verify that multiple videos do or don't show the media controller depending on whether videos
2387         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
2388         passing because we were always showing media controls for large videos with audio, even if they
2389         had not played back yet. This change ensures that large videos with audio show media controls
2390         only after they begin to play back, and not by virtue of being large enough for main content.
2391
2392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2393         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2394         (TestWebKitAPI::TEST):
2395         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2396         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
2397         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
2398
2399 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2400
2401         Media controls on apple.com don't disappear when movie finishes playing
2402         https://bugs.webkit.org/show_bug.cgi?id=160068
2403         <rdar://problem/26668526>
2404
2405         Reviewed by Darin Adler.
2406
2407         Adds new API tests. Please see WebCore ChangeLog for more details.
2408
2409         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2410         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2411         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2412         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2413         (TestWebKitAPI::TEST):
2414         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2415         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2416         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2417         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2418         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2419
2420 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2421
2422         Unreviewed, fix test-webkitpy after r203674.
2423
2424         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2425         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2426
2427 2016-07-24  Philippe Normand  <pnormand@igalia.com>
2428
2429         Unreviewed, forgot to commit this file in r203674.
2430
2431         * Scripts/process-linux-coredump: Added.
2432         (main):
2433
2434 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2435
2436         Improve GDB backtrace generation for GTK/EFL
2437         https://bugs.webkit.org/show_bug.cgi?id=128928
2438
2439         Reviewed by Carlos Garcia Campos.
2440
2441         The PID of the crashed process is now correctly supplied to the
2442         crash log reporter. The kernel core_pattern needs to be updated
2443         after this change to something like:
2444
2445         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2446
2447         * Scripts/process-linux-coredump: Added.
2448         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2449         * Scripts/webkitpy/port/efl.py:
2450         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2451         * Scripts/webkitpy/port/gtk.py:
2452         (GtkPort._get_crash_log): Ditto.
2453         * Scripts/webkitpy/port/linux_get_crash_log.py:
2454         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
2455         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
2456         (GDBCrashLogGenerator): Deleted.
2457         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2458         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2459         * WebKitTestRunner/TestController.cpp:
2460         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2461         (WTR::TestController::databaseProcessDidCrash): Ditto.
2462         (WTR::TestController::processDidCrash): Ditto.
2463
2464 2016-07-23  Youenn Fablet  <youenn@apple.com>
2465
2466         WPT stash server should be kept running when launching wpt server
2467         https://bugs.webkit.org/show_bug.cgi?id=160052
2468
2469         Reviewed by Sam Weinig.
2470
2471         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2472         (main): waiting to read stdin while stash server is started.
2473
2474 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2475
2476         Media controls should be displayed for media in media documents
2477         https://bugs.webkit.org/show_bug.cgi?id=160104
2478         <rdar://problem/27438936>
2479
2480         Reviewed by Myles C. Maxfield.
2481
2482         Verifies that even a small video with audio in a media document gets media controls.
2483
2484         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2485         (TestWebKitAPI::TEST):
2486
2487 2016-07-22  Michael Saboff  <msaboff@apple.com>
2488
2489         REGRESSION(203616): no FTL testing was inadvertently removed
2490         https://bugs.webkit.org/show_bug.cgi?id=160100
2491
2492         Rubber-stamped by Filip Pizlo.
2493
2494         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
2495         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
2496         logic for the runLayout and runNoisy variants to match the run test logic,
2497         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
2498         enabled platforms.
2499
2500         * Scripts/run-jsc-stress-tests:
2501
2502 2016-07-22  Brady Eidson  <beidson@apple.com>
2503
2504         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
2505         https://bugs.webkit.org/show_bug.cgi?id=160089
2506
2507         Reviewed by Darin Adler.
2508
2509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2510         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
2511         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
2512
2513 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
2514
2515         [GTK] Improved exclusion patterns in make-dist.py manifest.
2516         https://bugs.webkit.org/show_bug.cgi?id=160094
2517
2518         Reviewed by Michael Catanzaro.
2519
2520         * gtk/manifest.txt.in:
2521         Exclude Platform*.cmake files for more ports.
2522         Removed obsolete .gyp and .pro.user patterns.
2523         Exclude 'Configurations' and 'spi' directories.
2524         Exclude CMakeLists.txt.user (Qt Creator IDE).
2525
2526 2016-07-22  Michael Saboff  <msaboff@apple.com>
2527
2528         Don't run FTL related JSC stress tests on non-FTL platforms
2529         https://bugs.webkit.org/show_bug.cgi?id=160033
2530
2531         Reviewed by Mark Lam.
2532
2533         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2534         Refactored several of the runXXX test methods to always runXXXDefault and made those
2535         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
2536         doesn't cause a problem.
2537
2538         * Scripts/run-jsc-stress-tests:
2539
2540 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
2541
2542         IWebView::mainFrame crashes if called after IWebView::close
2543         https://bugs.webkit.org/show_bug.cgi?id=32868
2544
2545         Reviewed by Brent Fulgham.
2546
2547         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2548         (TestWebKitAPI::TEST_F): Added test.
2549
2550 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2551
2552         [GTK] Enable threaded compositor by default
2553         https://bugs.webkit.org/show_bug.cgi?id=160079
2554
2555         Reviewed by Žan Doberšek.
2556
2557         * Scripts/webkitperl/FeatureList.pm:
2558
2559 2016-07-22  Youenn Fablet  <youenn@apple.com>
2560
2561         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2562         https://bugs.webkit.org/show_bug.cgi?id=159921
2563
2564         Reviewed by Brian Burg.
2565
2566         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2567
2568         * Scripts/webkitpy/codegen/main.py:
2569         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2570         (BuiltinsGeneratorTests):
2571         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2572         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2573         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2574         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2575
2576 2016-07-21  Dan Bernstein  <mitz@apple.com>
2577
2578         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2579         https://bugs.webkit.org/show_bug.cgi?id=160072
2580
2581         Reviewed by Andy Estes.
2582
2583         * Scripts/webkitdirs.pm:
2584         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2585           for old Xcode versions.
2586         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2587           to readXcodeUserDefault.
2588         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2589           debugger.
2590         (determineDebugger): Ditto.
2591         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2592           7.0.
2593         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2594           switches.
2595         (execMacWebKitAppForDebugging): Removed support for GDB.
2596
2597 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2598
2599         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2600         https://bugs.webkit.org/show_bug.cgi?id=160066
2601
2602         Reviewed by Dean Jackson.
2603
2604         * DumpRenderTree/mac/DumpRenderTree.mm:
2605         (setDefaultsToConsistentValuesForTesting): Deleted.
2606         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2607         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2608         * WebKitTestRunner/TestController.cpp:
2609         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2610         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2611         (WTR::initializeWebViewConfiguration): Deleted.
2612
2613 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2614
2615         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2616         https://bugs.webkit.org/show_bug.cgi?id=159980
2617         rdar://problem/27450825
2618
2619         Reviewed by Dan Bernstein.
2620
2621         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2622         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2623         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2624         when our delegate has hit -dealloc.
2625         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2626         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2627         will not be messaged.
2628
2629 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2630
2631         Follow-up patch to r203520
2632         https://bugs.webkit.org/show_bug.cgi?id=159967
2633         <rdar://problem/26964090>
2634
2635         Unreviewed.
2636
2637         * DumpRenderTree/mac/DumpRenderTree.mm:
2638         (setDefaultsToConsistentValuesForTesting):
2639         * WebKitTestRunner/TestController.cpp:
2640         (WTR::TestController::resetPreferencesToConsistentValues):
2641
2642 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2643
2644         [iPhone] Playing a video on tudou.com plays only sound, no video
2645         https://bugs.webkit.org/show_bug.cgi?id=159967
2646         <rdar://problem/26964090>
2647
2648         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2649
2650         Migrate tests to use new SPI.
2651
2652         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2653         (RequiresUserActionForPlaybackTest::SetUp):
2654         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2655         (WTR::initializeWebViewConfiguration):
2656
2657 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2658
2659         Clarify testing mode names in run-jsc-stress-tests
2660         https://bugs.webkit.org/show_bug.cgi?id=160021
2661
2662         Reviewed by Mark Lam.
2663
2664         Default should mean really default, not default with disabled FTL, renamed
2665         - runMozillaTestDefault to runMozillaTestNoFTL
2666         - runMozillaTestDefaultFTL to runMozillaTestDefault
2667         - runDefault to runNoFTL
2668         - runDefaultFTL to runDefault
2669         - runLayoutTestDefault to runLayoutTestNoFTL
2670         - runLayoutTestDefaultFTL to runLayoutTestDefault
2671         - runNoisyTestDefault to runNoisyTestNoFTL
2672         - runNoisyTestDefaultFTL to runNoisyTestDefault
2673
2674         * Scripts/run-jsc-stress-tests:
2675
2676 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2677
2678         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2679         https://bugs.webkit.org/show_bug.cgi?id=159986
2680
2681         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2682         to 0.
2683
2684         Reviewed by Dan Bernstein.
2685
2686         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2687         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2688         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2689         (TEST):
2690
2691 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2692
2693         [GTK] Web view background colors don't work in accelerated compositing mode
2694         https://bugs.webkit.org/show_bug.cgi?id=159455
2695
2696         Reviewed by Michael Catanzaro.
2697
2698         Set always RGBA visual to the view widget when setting a background color.
2699
2700         * MiniBrowser/gtk/BrowserWindow.c:
2701         (browser_window_set_background_color):
2702
2703 2016-07-20  Youenn Fablet  <youenn@apple.com>
2704
2705         Bots should run built-ins generator tests
2706         https://bugs.webkit.org/show_bug.cgi?id=159971
2707
2708         Reviewed by Alexey Proskuryakov.
2709
2710         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2711         (RunBuiltinsTests): New step to run built-in generator tests.
2712         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2713         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2714         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2715
2716 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2717
2718         Revert temporary fix r203417
2719         https://bugs.webkit.org/show_bug.cgi?id=160001
2720
2721         Reviewed by Alexey Proskuryakov.
2722
2723         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2724
2725 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2726
2727         REGRESSION(r148588): ews classes might get garbage collected
2728         https://bugs.webkit.org/show_bug.cgi?id=159990
2729
2730         Reviewed by Ryosuke Niwa.
2731
2732         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2733         in a variable so that they do not get garbage collected.
2734
2735 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2736
2737         Add API test for layout constraints after exit fullscreen
2738         https://bugs.webkit.org/show_bug.cgi?id=159900
2739
2740         Reviewed by Jon Lee.
2741
2742         Added Fullscreen.LaytoutConstraints API test. 
2743         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2744
2745         This test compares layout constraints on the web view before and after fullscreen to make sure 
2746         they are preserved.
2747
2748         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2749         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2750         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2751         (TestWebKitAPI::TEST):
2752
2753 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2754
2755         Disable two failing API tests.
2756
2757         Unreviewed test gardening.
2758
2759         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2760         (TestWebKitAPI::TEST):
2761
2762 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2763
2764         Unreviewed iOS build fix.
2765
2766         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2767
2768 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2769
2770         Media controls don't appear when pausing a small autoplaying video
2771         https://bugs.webkit.org/show_bug.cgi?id=159972
2772         <rdar://problem/27180657>
2773
2774         Reviewed by Beth Dakin.
2775
2776         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2777         for simulating basic user interaction in VideoControlsManager.
2778
2779         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2780         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2781         (-[WKWebView mouseDownAtPoint:]):
2782         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2783         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2784         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2785         (TestWebKitAPI::TEST):
2786         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2787
2788 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2789
2790         [Win] MathML fonts are not found.
2791         https://bugs.webkit.org/show_bug.cgi?id=159920
2792
2793         Reviewed by Alex Christensen.
2794
2795         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2796         for a specific registry key value.
2797
2798         * Scripts/webkitdirs.pm:
2799         (fontExists):
2800
2801 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2802
2803         Improve prepare-ChangeLog for @media blocks
2804         https://bugs.webkit.org/show_bug.cgi?id=159907
2805
2806         Reviewed by Timothy Hatcher.
2807
2808         * Scripts/prepare-ChangeLog:
2809         (get_selector_line_ranges_for_css):
2810         Get a range for @media blocks just like a selector.
2811             Start Line = line with '{'
2812             End line = line with '}'
2813             Name = "@media ..."
2814
2815         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2816         Improved error messages for unbalanced portions.
2817
2818         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2819         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2820         (.media-query::before):
2821         (@media only screen and (max-width: 980px)):
2822         (.media-query a):
2823         (@media (-webkit-min-device-pixel-ratio: 2)):
2824         (.both a):
2825         (.both b):
2826         (.media-query b):
2827         (.media-query::after):
2828
2829 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2830
2831         Fix expectedFailErrorHandler in run-jsc-stress-tests
2832         https://bugs.webkit.org/show_bug.cgi?id=159811
2833
2834         Reviewed by Yusuke Suzuki.
2835
2836         * Scripts/run-jsc-stress-tests:
2837
2838 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2839
2840         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2841
2842         * TestWebKitAPI/PlatformMac.cmake:
2843
2844 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2845
2846         The default testing mode should not involve disabling the FTL JIT
2847         https://bugs.webkit.org/show_bug.cgi?id=159929
2848
2849         Rubber stamped by Mark Lam and Saam Barati.
2850         
2851         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2852         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2853         FTL was not the default. You had to enable it with an option.
2854         
2855         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2856         all of the major ports. This has become a serious pain. For example, it's useful to be able
2857         to say that a test should only run in the default config that is representative of what a
2858         normal user would see if they ran JSC. Clearly, this would be a config that does not
2859         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2860         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2861         
2862         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2863         try to fix it, because:
2864         
2865         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2866           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2867           doesn't do anything. The code is not really structured to allow this.
2868         
2869         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2870           disabled in testing. On the other hand there are already build bots that do FTL tests
2871           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2872           preserving this broken feature, we should create something that (a) acknowledges the fact
2873           that the FTL is the default on those platforms that support it and (b) avoids running
2874           no-ftl tests on precisely those platforms that don't have FTL.
2875         
2876         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2877           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2878           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2879           pretending that the FTL JIT is not the default just because some bots used that as an
2880           optimization.
2881         
2882         This change allows me to speed up some debug tests and paint some bots green.
2883
2884         * Scripts/run-javascriptcore-tests:
2885         (runJSCStressTests):
2886         * Scripts/run-jsc-stress-tests:
2887
2888 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2889
2890         Fix API test after r203426.
2891         https://bugs.webkit.org/show_bug.cgi?id=159949
2892
2893         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2894         (TEST):
2895         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2896         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2897
2898 2016-07-19  Andy Estes  <aestes@apple.com>
2899
2900         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2901         https://bugs.webkit.org/show_bug.cgi?id=159956
2902
2903         Reviewed by Dan Bernstein.
2904
2905         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2906         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2907         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2908         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2909
2910 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2911
2912         Add regression test for r203392
2913         https://bugs.webkit.org/show_bug.cgi?id=159949
2914
2915         Reviewed by Brady Eidson.
2916
2917         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2918         (fileSize):
2919         (swizzledBundleIdentifierWebBookmarksD):
2920         (defaultApplicationCacheDirectory):
2921         (TEST):
2922         (swizzledBundleIdentifierMobileSafari): Deleted.
2923         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2924         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2925         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2926
2927 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2928
2929         Add regression test for r203392
2930         https://bugs.webkit.org/show_bug.cgi?id=159949
2931
2932         Reviewed by Brady Eidson.
2933
2934         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2935         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2936         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2937         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2938         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2939         (TEST):
2940         (fileSize):
2941         (swizzledBundleIdentifierMobileSafari):
2942         (swizzledBundleIdentifierWebBookmarksD):
2943         (defaultApplicationCacheDirectory):
2944         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2945         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2946         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2947         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2948
2949 2016-07-19  Keith Miller  <keith_miller@apple.com>
2950
2951         Test262 should have a file with the revision and url
2952         https://bugs.webkit.org/show_bug.cgi?id=159937
2953
2954         Reviewed by Mark Lam.
2955
2956         The import script should update the information from
2957         the path to the test262 repository it gets.
2958
2959         * Scripts/import-test262-tests:
2960
2961 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2962
2963         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2964         To be deleted once the root cause is found and addressed.
2965
2966         * EWSTools/start-queue-mac.sh:
2967
2968 2016-07-19  Frederic Wang  <fwang@igalia.com>
2969
2970         [win] Fixup the register name for STIX Math and Latin Modern Math
2971
2972         Unreviewed follow-up of r203406
2973
2974         * Scripts/webkitdirs.pm:
2975         (checkInstalledTools):
2976
2977 2016-07-19  Frederic Wang  <fwang@igalia.com>
2978
2979         [win] Update the list of MathML fonts
2980         https://bugs.webkit.org/show_bug.cgi?id=156838
2981
2982         The set of recommended math fonts is now described at
2983         https://trac.webkit.org/wiki/MathML/Fonts
2984         We update the Perl script to use the latest list of fonts.
2985
2986         Reviewed by Brent Fulgham.
2987
2988         * Scripts/webkitdirs.pm:
2989         (checkInstalledTools):
2990
2991 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2992
2993         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2994         https://bugs.webkit.org/show_bug.cgi?id=159342
2995
2996         Reviewed by Darin Adler.
2997
2998         Implement required functions in event sender.
2999
3000         * DumpRenderTree/PlatformWin.cmake:
3001         * DumpRenderTree/win/EventSender.cpp:
3002         (monitorWheelEvents): Added.
3003         (callAfterScrollingCompletes): Added.
3004
3005 2016-07-19  Youenn Fablet  <youenn@apple.com>
3006
3007         Add new aliases to http test server
3008         https://bugs.webkit.org/show_bug.cgi?id=159878
3009
3010         Reviewed by Darin Adler.
3011
3012         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
3013         Adding explicitly these links to perl script.
3014         Extracting default alias in an aliases.json file.
3015         Reading that file from python scripts to initialize aliases from that file.
3016
3017         Python script changes covered by unit tests and changed layout test.
3018
3019         * Scripts/webkitperl/httpd.pm:
3020         (getDefaultConfigForTestDirectory): Adding 3 new aliases
3021         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
3022         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3023         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3024         Adding -c directives for each alias.
3025         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3026         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
3027         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3028         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3029         Adding alias directive for each alias.
3030         (Lighttpd._prepare_config):
3031         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3032         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
3033         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
3034         layout tests directory.
3035         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3036         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
3037         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
3038
3039 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
3040
3041         EWS console logs doesn't go to log file
3042         https://bugs.webkit.org/show_bug.cgi?id=159539
3043         <rdar://problem/24464570>
3044
3045         Reviewed by David Kilzer.
3046
3047         * Scripts/webkitpy/common/system/logutils.py:
3048         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
3049         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
3050         to filesystem. It also supports passing MockFilesystem.
3051         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
3052         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
3053         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3054         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
3055         (_test_ews): Same.
3056         * Scripts/webkitpy/tool/commands/queues.py:
3057         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
3058         (AbstractQueue._log_directory): Using filesystem object instead of os.
3059         (AbstractQueue.queue_log_path): Same.
3060         (AbstractQueue.__init__): Passed host parameter.
3061         (PatchProcessingQueue.__init__): Same.
3062         (CommitQueue.__init__): Same.
3063         (AbstractReviewQueue.__init__): Same.
3064         (StyleQueue.__init__): Same.
3065         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3066         (TestCommitQueue): Passed MockHost() as host.
3067         (TestCommitQueue.__init__): Same.
3068         (TestQueue.__init__): Same.
3069         (TestReviewQueue.__init__): Same.
3070         (TestFeederQueue.__init__): Same.
3071         (AbstractPatchQueueTest.test_next_patch): Same.
3072         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
3073         (test_commit_queue_failure): Same.
3074         (MockCommitQueueTask.results_from_patch_test_run): Same.
3075         (test_rollout_lands): Same.
3076         (test_non_valid_patch): Same.
3077         (test_auto_retry): Same.
3078         (test_style_queue_with_watch_list_exception): Same.
3079
3080 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
3081
3082         WTF::Lock should be fair eventually
3083         https://bugs.webkit.org/show_bug.cgi?id=159384
3084
3085         Reviewed by Geoffrey Garen.
3086
3087         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3088
3089 2016-07-17  Sam Weinig  <sam@webkit.org>
3090
3091         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3092         <rdar://problem/26554137>
3093         https://bugs.webkit.org/show_bug.cgi?id=159856
3094
3095         Reviewed by Dan Bernstein.
3096
3097         * MiniBrowser/mac/WK2BrowserWindowController.m:
3098         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3099         Add basic window.open implementation.
3100
3101         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
3102         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
3103         to open a single non-web URL, all others are dropped.
3104
3105         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3106         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
3107         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
3108         Add API for the new SPI.
3109
3110 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
3111
3112         [JSC] Enable test262 module tests
3113         https://bugs.webkit.org/show_bug.cgi?id=159854
3114
3115         Reviewed by Saam Barati.
3116
3117         Use --module-file instead.
3118
3119         * Scripts/run-jsc-stress-tests:
3120
3121 2016-07-16  Chris Dumez  <cdumez@apple.com>
3122
3123         Unreviewed, rolling out r203318.
3124
3125         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
3126         SunSpider)
3127
3128         Reverted changeset:
3129
3130         "[JSC] Change some parameters based on a random search"
3131         https://bugs.webkit.org/show_bug.cgi?id=158514
3132         http://trac.webkit.org/changeset/203318
3133
3134 2016-07-16  Chris Dumez  <cdumez@apple.com>
3135
3136         Add move constructor / assignment operator to ListHashSet
3137         https://bugs.webkit.org/show_bug.cgi?id=159837
3138
3139         Reviewed by Darin Adler.
3140
3141         Add API tests.
3142
3143         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3144         (TestWebKitAPI::TEST):
3145
3146 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
3147
3148         [JSC] Change some parameters based on a random search
3149         https://bugs.webkit.org/show_bug.cgi?id=158514
3150
3151         Reviewed by Saam Barati.
3152
3153         * Scripts/run-jsc-stress-tests:
3154
3155 2016-07-15  Jon Davis  <jond@apple.com>
3156
3157         Changed the start page URL for WebKit Nightly builds.
3158         https://bugs.webkit.org/show_bug.cgi?id=159816
3159
3160         Reviewed by Timothy Hatcher.
3161
3162         * WebKitLauncher/start.html:
3163
3164 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
3165
3166         Uninitialized variable in DIBPixelData can cause a dangerous memory write
3167         https://bugs.webkit.org/show_bug.cgi?id=159414
3168
3169         Reviewed by Brent Fulgham.
3170
3171         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
3172         when the HDC parameter is invalid.
3173
3174         * TestWebKitAPI/PlatformWin.cmake:
3175         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
3176         (TestWebKitAPI::TEST):
3177
3178 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3179
3180         [GTK] Add basic tabs support to MiniBrowser
3181         https://bugs.webkit.org/show_bug.cgi?id=159803
3182
3183         Reviewed by Sergio Villar Senin.
3184
3185         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
3186         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
3187
3188         * MiniBrowser/gtk/BrowserTab.c: Added.
3189         (titleChanged):
3190         (isLoadingChanged):
3191         (decidePolicy):
3192         (removeChildIfInfoBar):
3193         (loadChanged):
3194         (createInfoBarQuestionMessage):
3195         (tlsErrorsDialogResponse):
3196         (loadFailedWithTLSerrors):
3197         (permissionRequestDialogResponse):
3198         (decidePermissionRequest):
3199         (colorChooserRGBAChanged):
3200         (popoverColorClosed):
3201         (colorChooserRequestFinished):
3202         (runColorChooserCallback):
3203         (inspectorOpenedInWindow):
3204         (inspectorClosed):
3205         (browserTabSetProperty):
3206         (browserTabFinalize):
3207         (browser_tab_init):
3208         (browserTabConstructed):
3209         (browser_tab_class_init):
3210         (getInternalURI):
3211         (browser_tab_new):
3212         (browser_tab_get_web_view):
3213         (browser_tab_load_uri):
3214         (browser_tab_get_title_widget):
3215         (browser_tab_set_status_text):
3216         (browser_tab_toggle_inspector):
3217         (browser_tab_start_search):
3218         (browser_tab_stop_search):
3219         (browser_tab_add_accelerators):
3220         (fullScreenMessageTimeoutCallback):
3221         (browser_tab_enter_fullscreen):
3222         (browser_tab_leave_fullscreen):
3223         * MiniBrowser/gtk/BrowserTab.h: Added.
3224         * MiniBrowser/gtk/BrowserWindow.c:
3225         (getExternalURI):
3226         (browserWindowSetStatusText):
3227         (reloadOrStopCallback):
3228         (goBackCallback):
3229         (goForwardCallback):
3230         (settingsCallback):
3231         (webViewURIChanged):
3232         (browserWindowHistoryItemActivated):
3233         (browserWindowUpdateNavigationActions):
3234         (webViewCreate):
3235         (webViewEnterFullScreen):
3236         (webViewLeaveFullScreen):
3237         (webViewDecidePolicy):
3238         (browserWindowCanZoomIn):
3239         (browserWindowCanZoomOut):
3240         (browserWindowZoomIn):
3241         (browserWindowZoomOut):
3242         (scrollEventCallback):
3243         (faviconChanged):
3244         (webViewIsLoadingChanged):
3245         (defaultZoomCallback):
3246         (searchCallback):
3247         (newTabCallback):
3248         (toggleWebInspector):
3249         (reloadPage):
3250         (reloadPageIgnoringCache):
3251         (stopPageLoad):
3252         (loadHomePage):
3253         (editingCommandCallback):
3254         (insertImageCommandCallback):
3255         (insertLinkCommandCallback):
3256         (browserWindowSetupEditorToolbar):
3257         (browserWindowSwitchTab):
3258         (browserWindowTabAddedOrRemoved):
3259         (browser_window_init):
3260         (browserWindowConstructed):
3261         (browserWindowSaveSession):
3262         (browserWindowDeleteEvent):
3263         (browser_window_new):
3264         (browser_window_append_view):
3265         (browser_window_load_uri):
3266         (browser_window_load_session):
3267         (browser_window_set_background_color):
3268         (resetStatusText): Deleted.
3269         (activateUriEntryCallback): Deleted.
3270         (webViewTitleChanged): Deleted.
3271         (resetEntryProgress): Deleted.
3272         (browserWindowCreateBackForwardMenu): Deleted.
3273         (webViewReadyToShow): Deleted.
3274         (webViewLoadFailed): Deleted.
3275         (webViewMouseTargetChanged): Deleted.
3276         (browserWindowUpdateZoomActions): Deleted.
3277         (webViewZoomLevelChanged): Deleted.
3278         (updateUriEntryIcon): Deleted.
3279         (zoomInCallback): Deleted.
3280         (zoomOutCallback): Deleted.
3281         (toggleFullScreen): Deleted.
3282         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
3283         (browserWindowFinalize): Deleted.
3284         (browser_window_class_init): Deleted.
3285         * MiniBrowser/gtk/BrowserWindow.h:
3286         * MiniBrowser/gtk/CMakeLists.txt:
3287         * MiniBrowser/gtk/main.c:
3288         (createBrowserTab):
3289         (aboutURISchemeRequestCallback):
3290         (main):
3291         (parseBackgroundColor): Deleted.
3292
3293 2016-07-14  Alex Christensen  <achristensen@webkit.org>
3294
3295         Allow RefPtrs of const RefCounted types
3296         https://bugs.webkit.org/show_bug.cgi?id=158269
3297
3298         Reviewed by Anders Carlsson.
3299
3300         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3301         (TestWebKitAPI::TEST):
3302         (TestWebKitAPI::ConstRefCounted::create):
3303         (TestWebKitAPI::returnConstRefCountedRef):
3304         (TestWebKitAPI::returnRefCountedRef):
3305
3306 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3307
3308         Test WTF.StringViewIterators is crashing since r203119
3309         https://bugs.webkit.org/show_bug.cgi?id=159710
3310
3311         Reviewed by Darin Adler.
3312
3313         There are two problems in the test case added in r203119. First is that it's testing
3314         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
3315         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
3316         const reference to the string view member of the deleted CodePoints object.
3317
3318         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3319         (TestWebKitAPI::TEST):
3320
3321 2016-07-13  Daniel Bates  <dabates@apple.com>
3322
3323         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
3324         https://bugs.webkit.org/show_bug.cgi?id=159738
3325         <rdar://problem/27304649>
3326
3327         Reviewed by Dan Bernstein.
3328
3329         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
3330         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
3331         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
3332         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
3333
3334         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3335         * WebKitTestRunner/ios/TestControllerIOS.mm:
3336         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
3337         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
3338
3339 2016-07-13  Beth Dakin  <bdakin@apple.com>
3340
3341         Attempted build fix.
3342
3343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3344
3345 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
3346
3347         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
3348         https://bugs.webkit.org/show_bug.cgi?id=159686
3349
3350         Reviewed by Chris Dumez.
3351
3352         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
3353
3354         * WebKitTestRunner/TestController.cpp:
3355         (WTR::runOpenPanel):
3356         (WTR::TestController::createOtherPage):
3357         (WTR::TestController::createWebViewWithOptions):
3358
3359 2016-07-13  Beth Dakin  <bdakin@apple.com>
3360
3361         Add more candidate tests
3362         https://bugs.webkit.org/show_bug.cgi?id=159730
3363
3364         Reviewed by Tim Horton.
3365
3366         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
3367         two new tests to that file.
3368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3369         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
3370         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
3371         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
3372         (TestWebKitAPI::TEST):
3373         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
3374
3375 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
3376
3377         AX: [ATK] spinbutton-crash.html fails
3378         https://bugs.webkit.org/show_bug.cgi?id=159723
3379
3380         Reviewed by Chris Fleizach.
3381
3382         Implement support for AXDecrementButton and AXIncrementButton in
3383         ATK's AccessibilityUIElement::uiElementAttributeValue().
3384
3385         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3386         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3387
3388 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3389
3390         [EFL] [GTK] Enable back crypto subtle on development builds.
3391         https://bugs.webkit.org/show_bug.cgi?id=159260
3392
3393         Reviewed by Carlos Garcia Campos.
3394
3395         * Scripts/webkitperl/FeatureList.pm:
3396
3397 2016-07-12  Mark Lam  <mark.lam@apple.com>
3398
3399         We should use different stack limits for stack checks from JS and host code.
3400         https://bugs.webkit.org/show_bug.cgi?id=159442
3401         <rdar://problem/26889188>
3402
3403         Reviewed by Geoffrey Garen.
3404
3405         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
3406         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
3407         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
3408         order to keep the js/regress-139548.html test happy with this patch.
3409
3410         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
3411         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
3412
3413         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3414         (-[LTRelayController _environmentVariables]):
3415         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3416         (main):
3417
3418 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
3419
3420         platformUserPreferredLanguages on Mac should not try to put the region into the language
3421         https://bugs.webkit.org/show_bug.cgi?id=159693
3422
3423         Rubber stamped by Alexey Proskuryakov.
3424         
3425         Revert the test change in r200105.
3426
3427         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
3428         (TestWebKitAPI::languageForSystemLanguage):
3429
3430 2016-07-12  Chris Dumez  <cdumez@apple.com>
3431
3432         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
3433         https://bugs.webkit.org/show_bug.cgi?id=159663
3434         <rdar://problem/18995873>
3435
3436         Reviewed by Benjamin Poulain.
3437
3438         Add API test coverage.
3439
3440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3441         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
3442         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
3443         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
3444         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
3445         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
3446         (TEST):
3447
3448 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
3449
3450         Relax ordering requirements on StringView::CodePoints iterator
3451         https://bugs.webkit.org/show_bug.cgi?id=159609
3452
3453         Reviewed by Darin Adler.
3454
3455         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3456         (TestWebKitAPI::TEST):
3457
3458 2016-07-12  Youenn Fablet  <youenn@apple.com>
3459
3460         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
3461         https://bugs.webkit.org/show_bug.cgi?id=159564
3462
3463         Reviewed by Brian Burg.
3464
3465         * Scripts/webkitpy/codegen/main.py:
3466         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
3467
3468 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3469
3470         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
3471         https://bugs.webkit.org/show_bug.cgi?id=159671
3472
3473         Reviewed by Csaba Osztrogonác.
3474
3475         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
3476         https://bugs.webkit.org/show_bug.cgi?id=89235
3477
3478         So this guard can be removed in build scripts.
3479
3480         * Scripts/webkitperl/FeatureList.pm:
3481         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3482
3483 2016-07-11  Jason Marcell  <jmarcell@apple.com>
3484
3485         SVN.create_patch should find svn-create-patch relative to the WebKit root.
3486         https://bugs.webkit.org/show_bug.cgi?id=159652
3487
3488         Reviewed by Daniel Bates.
3489
3490         * Scripts/webkitpy/common/checkout/scm/svn.py:
3491         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
3492
3493 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
3494
3495         Implement grapheme cluster iterator on StringView
3496         https://bugs.webkit.org/show_bug.cgi?id=159598
3497
3498         Reviewed by Anders Carlsson.
3499
3500         This is in preparation for honoring the second argument to FontFaceSet.load().
3501
3502         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3503         (TestWebKitAPI::compareLoopIterations):
3504         (TestWebKitAPI::TEST):
3505
3506 2016-07-11  Nan Wang  <n_wang@apple.com>
3507
3508         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
3509         https://bugs.webkit.org/show_bug.cgi?id=158364
3510
3511         Reviewed by Anders Carlsson.
3512
3513         Added a function in TestRunner so that we can toggle the ignoring viewport
3514         scale limits setting. Also added a test option for that in order to change the 
3515         configuration of the webview in test.
3516
3517         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3518         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3519         (WTR::TestRunner::setNavigationGesturesEnabled):
3520         (WTR::TestRunner::setIgnoresViewportScaleLimits):
3521         (WTR::nextUIScriptCallbackID):
3522         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3523         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3524         * WebKitTestRunner/TestController.cpp:
3525         (WTR::TestController::resetStateToConsistentValues):
3526         (WTR::updateTestOptionsFromTestHeader):
3527         (WTR::TestController::setNavigationGesturesEnabled):
3528         (WTR::TestController::setIgnoresViewportScaleLimits):
3529         (WTR::TestController::platformWillRunTest):
3530         * WebKitTestRunner/TestController.h:
3531         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3532         * WebKitTestRunner/TestInvocation.cpp:
3533         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3534         * WebKitTestRunner/TestOptions.h:
3535         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3536         (WTR::TestController::platformCreateWebView):
3537
3538 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
3539
3540         [GTK] install-dependencies should not install packages built by jhbuild.
3541         https://bugs.webkit.org/show_bug.cgi?id=159628
3542
3543         Reviewed by Michael Catanzaro.
3544
3545         * gtk/install-dependencies:
3546         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
3547
3548 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
3549
3550         System proxy settings not used when building deps with jhbuild
3551         https://bugs.webkit.org/show_bug.cgi?id=159567
3552
3553         Reviewed by Michael Catanzaro.
3554
3555         This adds the gsettings-desktop-schemas-devel build dep to enable
3556         the libgiognomeproxy.so gio module in glib-networking, which uses
3557         GSettings on org.gnome.system.proxy.
3558         This is needed to query system proxy settings for Gnome desktops.
3559
3560         dconf can be manually added to jhbuild to build the
3561         libdconfsettings.so gio module for GSettings, so that
3562         libgiognomeproxy.so can access system settings.
3563           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
3564
3565         As an alternative to dconf settings, this commit also adds the
3566         libproxy-devel build dep to enable the libgiolibproxy.so module in
3567         glib-networking (suggested by Fujii Hironori).
3568
3569         It is useful to read proxy settings from environment variables.
3570         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
3571         environment variable to force using the envvar module in libproxy.
3572
3573         * gtk/install-dependencies:
3574
3575 2016-07-11  Mark Lam  <mark.lam@apple.com>
3576
3577         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
3578         https://bugs.webkit.org/show_bug.cgi?id=159524
3579
3580         Reviewed by Michael Saboff.
3581
3582         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
3583         Also fixed up some tests to behave better to work with this new limit.  This
3584         should make stack overflow tests complete sooner.
3585
3586         * Scripts/run-jsc-stress-tests:
3587         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3588         (main):
3589
3590 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3591
3592         [GTK] Whitespace fixes in install-dependencies script
3593
3594         Unreviewed.
3595
3596         * gtk/install-dependencies:
3597
3598 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3599
3600         [GTK] Install missing Fedora dependencies
3601
3602         Unreviewed.
3603
3604         * gtk/install-dependencies:
3605
3606 2016-07-09  Dan Bernstein  <mitz@apple.com>
3607
3608         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
3609         https://bugs.webkit.org/show_bug.cgi?id=159600
3610
3611         Reviewed by Daniel Bates.
3612
3613         * Scripts/git-add-reviewer:
3614         Added the -s|--rubber-stamp option.
3615         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
3616           new option.
3617
3618 2016-07-08  Andy Estes  <aestes@apple.com>
3619
3620         [Content Filtering] Load blocked pages more like other error pages are loaded
3621         https://bugs.webkit.org/show_bug.cgi?id=159485
3622         <rdar://problem/26014076>
3623
3624         Reviewed by Brady Eidson.
3625
3626         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3627         to a content filtering provisional navigation failure is ignored in preference of
3628         ContentFilter's own error page.
3629
3630         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3632         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3633         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3634         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3635         (loadAlternateTest):
3636         (TEST):
3637         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3638         (-[MockContentFilterEnabler initWithCoder:]):
3639         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3640         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3641         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3642         (TestWebKitAPI::loadAlternateTest):
3643         (TestWebKitAPI::TEST):
3644
3645 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3646
3647         Unreviewed, rolling out r202944.
3648         https://bugs.webkit.org/show_bug.cgi?id=159570
3649
3650         caused some tests to crash under GuardMalloc (Requested by
3651         estes on #webkit).
3652
3653         Reverted changeset:
3654
3655         "[Content Filtering] Load blocked pages more like other error
3656         pages are loaded"
3657         https://bugs.webkit.org/show_bug.cgi?id=159485
3658         http://trac.webkit.org/changeset/202944
3659
3660 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
3661
3662         Remove mrobinson from the MathML watchlist
3663         https://bugs.webkit.org/show_bug.cgi?id=159559
3664
3665         Reviewed by Philippe Normand.
3666
3667         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
3668
3669 2016-07-08  Brady Eidson  <beidson@apple.com>
3670
3671         Clearing LocalStorage doesn't also delete -wal and -shm files.
3672         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
3673
3674         Reviewed by Brent Fulgham.
3675         Also helpfully picked over by Andy "Never Forgets" Estes.
3676
3677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3678         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
3679         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
3680
3681 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
3682
3683         Removed Qt leftovers from Tools.
3684         https://bugs.webkit.org/show_bug.cgi?id=159557
3685
3686         Reviewed by Csaba Osztrogonác.
3687
3688         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3689         Removed 'qt' platform config.
3690         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3691         Deleted non-functional e-mail address.
3692
3693 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3694
3695         Unreviewed, rolling out r202967.
3696         https://bugs.webkit.org/show_bug.cgi?id=159556
3697
3698         This patch caused crashes in https tests on Windows (Requested
3699         by perarne on #webkit).
3700
3701         Reverted changeset:
3702
3703         "[Win] The test http/tests/security/contentSecurityPolicy
3704         /upgrade-insecure-requests/basic-upgrade.https.html is
3705         failing."
3706         https://bugs.webkit.org/show_bug.cgi?id=159510
3707         http://trac.webkit.org/changeset/202967
3708
3709 2016-07-08  Youenn Fablet  <youenn@apple.com>
3710
3711         Generate WebCore builtin wrapper files
3712         https://bugs.webkit.org/show_bug.cgi?id=159461
3713
3714         Reviewed by Brian Burg.
3715
3716         * Scripts/webkitpy/codegen/main.py:
3717         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3718         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3719
3720 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3721
3722         [EFL] Fix build when media-stream is enabled.
3723         https://bugs.webkit.org/show_bug.cgi?id=159206
3724
3725         Bump up the openwebrtc to find the correct package.
3726
3727         Reviewed by Gyuyoung Kim.
3728
3729         * efl/jhbuild.modules:
3730         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3731
3732 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3733
3734         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3735         https://bugs.webkit.org/show_bug.cgi?id=159510
3736
3737         Reviewed by Brent Fulgham.
3738
3739         Allow any https certificate when running tests.
3740
3741         * DumpRenderTree/win/DumpRenderTree.cpp:
3742         (runTest):
3743
3744 2016-07-07  Beth Dakin  <bdakin@apple.com>
3745
3746         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3747         https://bugs.webkit.org/show_bug.cgi?id=159532
3748         -and corresponding-
3749         rdar://problem/27177179
3750
3751         Reviewed by Tim Horton.
3752
3753         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3754         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3755
3756 2016-07-07  Andy Estes  <aestes@apple.com>
3757
3758         [Content Filtering] Load blocked pages more like other error pages are loaded
3759         https://bugs.webkit.org/show_bug.cgi?id=159485
3760         <rdar://problem/26014076>
3761
3762         Reviewed by Brady Eidson.
3763
3764         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3765         to a content filtering provisional navigation failure is ignored in preference of
3766         ContentFilter's own error page.
3767
3768         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3770         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3771         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3772         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3773         (loadAlternateTest):
3774         (TEST):
3775         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3776         (-[MockContentFilterEnabler initWithCoder:]):
3777         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3778         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3779         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3780         (TestWebKitAPI::loadAlternateTest):
3781         (TestWebKitAPI::TEST):
3782
3783 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3784
3785         Unreviewed: add myself to the reviewers list.
3786
3787         * Scripts/webkitpy/common/config/contributors.json:
3788
3789 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3790
3791         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3792         https://bugs.webkit.org/show_bug.cgi?id=159509
3793
3794         Reviewed by Alex Christensen.
3795
3796         We should always insert the url in the url map when identifierForInitialRequest
3797         is called. Otherwise we can end up with identifiers not having an entry in the
3798         url map when urls are written to the test output file. 
3799
3800         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3801         (ResourceLoadDelegate::identifierForInitialRequest):
3802
3803 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3804
3805         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3806         https://bugs.webkit.org/show_bug.cgi?id=159498
3807         <rdar://problem/26719903>
3808
3809         Reviewed by Sam Weinig.
3810
3811         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3812         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3813         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3814         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3815         (expectLinkCount):
3816         (TEST):
3817         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3818         when deciding what to linkify.
3819
3820 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3821
3822         Build fix - work around rdar://problem/27196668.
3823
3824         * LayoutTestRelay/Configurations/Base.xcconfig:
3825
3826 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3827
3828         Enhance Windows DRT implementation to support platform scroll wheel events.
3829         https://bugs.webkit.org/show_bug.cgi?id=36002
3830
3831         Reviewed by Brent Fulgham.
3832
3833         Implement function continuousMouseScrollBy in Windows event sender.
3834
3835         * DumpRenderTree/win/EventSender.cpp:
3836         (mouseScrollBy):
3837         (continuousMouseScrollBy):
3838
3839 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3840
3841         [Sierra] Rebaseline tests to use un-mocked system font metrics
3842         https://bugs.webkit.org/show_bug.cgi?id=159311
3843         <rdar://problem/24138411>
3844
3845         Reviewed in person by Alexey Proskuryakov.
3846
3847         Stop mocking the system font on Sierra.
3848
3849         * DumpRenderTree/mac/DumpRenderTree.mm:
3850         (setDefaultsToConsistentValuesForTesting):
3851         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3852         (WTR::InjectedBundle::platformInitialize):
3853
3854 2016-07-05  Brady Eidson  <beidson@apple.com>
3855
3856         Database process crashes deleting a corrupt SQLite database file (null deref).
3857         https://bugs.webkit.org/show_bug.cgi?id=155506.
3858
3859         Reviewed by Alex Christensen.
3860
3861         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3862         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3863         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3864         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3865         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3866         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3867
3868 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3869
3870         run-webkit-tests should print more complete baseline search paths
3871         https://bugs.webkit.org/show_bug.cgi?id=159354
3872
3873         Reviewed by Daniel Bates.
3874
3875         run-webkit-tests used to only print directory names in baseline search paths.
3876         This was ok in basic usage, but quickly got confusing when using
3877         --additional-platform-directory flags.
3878
3879         * Scripts/webkitpy/layout_tests/views/printing.py:
3880         (Printer.print_config):
3881         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3882         (Testprinter.test_print_config):
3883         (Testprinter.test_print_one_line_summary):
3884
3885 2016-07-04  Brady Eidson  <beidson@apple.com>
3886
3887         WebProcesses don't handle DatabaseProcess going away uncleanly..
3888         https://bugs.webkit.org/show_bug.cgi?id=159371
3889
3890         Reviewed by Alex Christensen.
3891
3892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3893         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3894         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3895         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3896         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3897
3898 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3899
3900         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3901         https://bugs.webkit.org/show_bug.cgi?id=158141
3902
3903         Rubber-stamped by Michael Catanzaro.
3904
3905         Instead of checking for an specific Ubuntu version, query the apt
3906         database to see which version of PHP is available.
3907
3908         * efl/install-dependencies:
3909         * gtk/install-dependencies:
3910
3911 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3912
3913         webkit-patch failure-reason always raises TypeError
3914         https://bugs.webkit.org/show_bug.cgi?id=159394
3915
3916         Reviewed by Benjamin Poulain.
3917
3918         In r170637 (Bug 133067), the first and second arguments of
3919         pluralize were swapped.
3920
3921         * Scripts/webkitpy/tool/commands/queries.py:
3922         (FailureReason._builder_to_explain): Swap the first and second
3923         arguments of pluralize.
3924
3925 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3926
3927         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3928         https://bugs.webkit.org/show_bug.cgi?id=152486
3929
3930         Reviewed by Daniel Bates.
3931
3932         Add launch of web-platform-tests server by run-webkit-httpd.
3933         Add two options to disable starting httpd and web-platform-tests servers.
3934
3935         * Scripts/run-webkit-httpd:
3936         (parse_args):
3937         (main):
3938
3939 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3940
3941         REGRESSION(r189668): Notification tests are flakey
3942         https://bugs.webkit.org/show_bug.cgi?id=159375
3943         <rdar://problem/22760990>
3944
3945         Reviewed by Alexey Proskuryakov.
3946
3947         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3948         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3949         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3950         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3951
3952         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3953         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3954         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3955         global notification ID mapping, causing the wrong notification to be investigated.
3956
3957         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3958         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3959         notification is created or destroyed. However, because this object is implemented outside WebKit,
3960         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3961         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3962         WebNotificationProvider can properly map between the different IDs.
3963
3964         * WebKitTestRunner/TestController.cpp:
3965         (WTR::TestController::runTestingServerLoop):
3966         (WTR::TestController::simulateWebNotificationClick):
3967         * WebKitTestRunner/WebNotificationProvider.cpp:
3968         (WTR::WebNotificationProvider::showWebNotification):
3969         (WTR::removeGlobalIDFromIDMap):
3970         (WTR::WebNotificationProvider::closeWebNotification):
3971         (WTR::WebNotificationProvider::removeNotificationManager):
3972         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3973         (WTR::WebNotificationProvider::reset):
3974         * WebKitTestRunner/WebNotificationProvider.h:
3975
3976 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3977
3978         Simplify LayoutTestRelay
3979         https://bugs.webkit.org/show_bug.cgi?id=159353
3980
3981         Reviewed by Daniel Bates.
3982
3983         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3984         by name and runtime makes no sense.
3985         2. Removed code to create devices, webkitpy always does this in advance.
3986         3. Don't create copies of testing apps - we can install the same one into
3987         each simulator, now that we don't run multiple tester processes in a single simulator.
3988         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3989         5. Removed code that kept testing apps alive in the background.
3990         6. Slightly updated coding style in functions that I touched.
3991
3992         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3993         Updated for what we acually use at this point.
3994
3995         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3996         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3997         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3998         (-[LTRelayController ipcIdentifier]):
3999         (-[LTRelayController processName]):
4000         (-[LTRelayController didReceiveStdoutData:]):
4001         (-[LTRelayController didCrashWithMessage:]):
4002         (-[LTRelayController installApp]):
4003         (-[LTRelayController _environmentVariables]):
4004         (-[LTRelayController launchApp]):
4005         (-[LTRelayController start]):
4006         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
4007         (-[LTRelayController uniqueAppPath]): Deleted.
4008         (-[LTRelayController uniqueAppURL]): Deleted.
4009         (-[LTRelayController uniqueAppIdentifier]): Deleted.
4010         (-[LTRelayController createUniqueApp]): Deleted.
4011         * LayoutTestRelay/LayoutTestRelay/main.m:
4012         (usage):
4013         (getRequiredStringArgument):
4014         (main):
4015         (getTestingSimDevice): Deleted.
4016         * Scripts/webkitpy/port/driver.py:
4017         (IOSSimulatorDriver.cmd_line):
4018         * WebKitTestRunner/ios/TestControllerIOS.mm:
4019         (WTR::TestController::platformInitialize):
4020         * WebKitTestRunner/ios/mainIOS.mm:
4021         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
4022         * DumpRenderTree/mac/DumpRenderTree.mm:
4023         (dumpRenderTree):
4024         (-[DumpRenderTree applicationDidEnterBackground:]):
4025
4026 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
4027
4028         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
4029         https://bugs.webkit.org/show_bug.cgi?id=159344
4030
4031         Reviewed by Alex Christensen.
4032
4033         * DumpRenderTree/CMakeLists.txt:
4034
4035 2016-07-01  Youenn Fablet  <youennf@gmail.com>
4036
4037         Add a runtime flag for DOM iterators
4038         https://bugs.webkit.org/show_bug.cgi?id=159300
4039
4040         Reviewed by Alex Christensen.
4041
4042         * DumpRenderTree/mac/DumpRenderTree.mm:
4043         (resetWebPreferencesToConsistentValues):
4044         * DumpRenderTree/win/DumpRenderTree.cpp:
4045         (resetWebPreferencesToConsistentValues):
4046         * Scripts/webkitperl/FeatureList.pm:
4047         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4048         (WTR::InjectedBundle::beginTesting):
4049         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4050         (WTR::TestRunner::setDOMIteratorEnabled):
4051         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4052
4053 2016-06-30  Tina Liu  <iting_liu@apple.com>
4054
4055         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
4056         https://bugs.webkit.org/show_bug.cgi?id=159326
4057
4058         Reviewed by Brady Eidson.
4059
4060         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4061         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
4062         (TestWebKitAPI::didFinishLoadForFrame):
4063         (TestWebKitAPI::didChangeBackForwardListForPage):
4064         (TestWebKitAPI::setPageLoaderClient):
4065         Set the page loader client and register for didFinishLoadForFrame and
4066         didChangeBackForwardList callbacks.
4067         (TestWebKitAPI::createSessionStateData):
4068         Load a webpage ("simple.html") and return the session state for this page.
4069         (TestWebKitAPI::TEST):
4070         Restore the page session state with that of "simple.html" without navigation.
4071         Verify that the committed URL is NULL since there's no navigation involved.
4072         Verify that the current item in the back forward list, which should be what
4073         we restored from the session state, has the expected URL.
4074
4075 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
4076
4077         Generators violate bytecode liveness validation
4078         https://bugs.webkit.org/show_bug.cgi?id=159279
4079
4080         Reviewed by Yusuke Suzuki.
4081         
4082         Add Basic to our test harness.
4083
4084         * Scripts/run-javascriptcore-tests:
4085         (runJSCStressTests):
4086
4087 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
4088
4089         [Win][Debug] Assertion fails in TestWTF.
4090         https://bugs.webkit.org/show_bug.cgi?id=159299
4091
4092         Reviewed by Alex Christensen.
4093
4094         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
4095         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
4096         the assertion failure. Since the variable is actually used, there is no need to use the
4097         UNUSED_PARAM macro.
4098
4099         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
4100         (TestWebKitAPI::TEST):
4101
4102 2016-06-30  Youenn Fablet  <youennf@gmail.com>
4103
4104         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
4105         https://bugs.webkit.org/show_bug.cgi?id=159166
4106         <rdar://problem/27051759>
4107
4108         Reviewed by Alexey Proskuryakov.
4109
4110         Setting the certificate directory to the copied config.json.
4111
4112         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
4113         (WebPlatformTestServer._copy_webkit_test_files):
4114
4115 2016-06-29  Mark Lam  <mark.lam@apple.com>
4116
4117         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
4118         https://bugs.webkit.org/show_bug.cgi?id=159274
4119
4120         Reviewed by Keith Miller.
4121
4122         * DumpRenderTree/mac/DumpRenderTree.mm:
4123         (DumpRenderTreeMain):
4124
4125 2016-06-29  Alex Christensen  <achristensen@webkit.org>
4126
4127         WKWebView should ask WKNavigationDelegate about bad ssl certificates
4128         https://bugs.webkit.org/show_bug.cgi?id=159176
4129
4130         Reviewed by Sam Weinig.
4131
4132         * MiniBrowser/mac/WK2BrowserWindowController.m:
4133         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
4134         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
4135         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
4136
4137 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4138
4139         [GTK] Add missing install dependency after r202619
4140         https://bugs.webkit.org/show_bug.cgi?id=156716
4141
4142         Unreviewed.
4143
4144         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
4145
4146 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4147
4148         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
4149         https://bugs.webkit.org/show_bug.cgi?id=156716
4150
4151         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
4152
4153         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
4154         (parse_args):
4155         * Scripts/webkitpy/port/gtk.py:
4156         (GtkPort.__init__):
4157         (GtkPort._driver_class):
4158         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
4159         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
4160         platform directory for storing the wayland specific layout test results and expectations for ${port}.
4161         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
4162         test expectations file on the GTK port when running the tests with the --wayland command line switch.
4163         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
4164         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
4165         (WestonDriver.check_driver):
4166         (WestonDriver.__init__):
4167         (WestonDriver._start):
4168         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
4169         (WestonXvfbDriverDisplayTest):
4170         (WestonXvfbDriverDisplayTest.__init__):
4171         (WestonXvfbDriverDisplayTest._xvfb_run):
4172         (WestonDriverTest.make_driver):
4173         (WestonDriverTest.test_start):
4174         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
4175         or to satisfy the pkg-config check of the new added modules in JHBuild.
4176         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
4177         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
4178         provided by the system are already new enough.
4179         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
4180         It was the only way to get the software EGL rasterizer working without depending on user drivers.
4181         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
4182         feature to avoid building libdrm when the one provided by the system is new enough.
4183         * gtk/jhbuildrc:
4184         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
4185         Xorg had no support for searching the DRI drivers on a custom path at runtime.
4186         This patch implements support for that reusing the same variable that we use with Mesa to set the
4187         custom path for the DRI drivers path.
4188
4189 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
4190
4191         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
4192         https://bugs.webkit.org/show_bug.cgi?id=159256
4193
4194         Reviewed by Philippe Normand.
4195
4196         We need the last fixes in the repository to make the scream queue
4197         work with apprtc.
4198
4199         * gtk/jhbuild.modules:
4200
4201 2016-06-28  Commit Queue  <commit-queue@webkit.org>
4202
4203         Unreviewed, rolling out r202580.
4204         https://bugs.webkit.org/show_bug.cgi?id=159245
4205
4206         Caused all WKTR tests to fail on GuardMalloc and Production
4207         only for unknown reasons, investigating offline. (Requested by
4208         brrian on #webkit).
4209
4210         Reverted changeset:
4211
4212         "RunLoop::Timer should use constructor templates instead of
4213         class templates"
4214         https://bugs.webkit.org/show_bug.cgi?id=159153
4215         http://trac.webkit.org/changeset/202580
4216
4217 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
4218
4219         Use a regex to check if a test step is for JavaScriptCore
4220         https://bugs.webkit.org/show_bug.cgi?id=159224
4221
4222         Reviewed by Geoffrey Garen.
4223
4224         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
4225         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
4226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4227         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
4228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
4229         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
4230
4231 2016-06-28  Michael Saboff  <msaboff@apple.com>
4232
4233         btjs no longer accepts optional frame count argument
4234         https://bugs.webkit.org/show_bug.cgi?id=159235
4235
4236         Reviewed by Saam Barati.
4237
4238         Fix the detection of optional backtrace-depth parameter to use the length
4239         of the command.
4240
4241         * lldb/lldb_webkit.py:
4242         (btjs):
4243
4244 2016-06-28  Jon Lee  <jonlee@apple.com>
4245
4246         Update animometer.plan
4247
4248         Rubber-stamped by Said Abou-Hallawa.
4249
4250         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
4251
4252 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
4253
4254         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
4255
4256         * Scripts/run-javascriptcore-tests:
4257         (runJSCStressTests):
4258
4259 2016-06-28  Brian Burg  <bburg@apple.com>
4260
4261         RunLoop::Timer should use constructor templates instead of class templates
4262         https://bugs.webkit.org/show_bug.cgi?id=159153
4263
4264         Reviewed by Alex Christensen.
4265
4266         Remove the RunLoop::Timer class template argument, and pass its constructor
4267         a reference to `this` instead of a pointer to `this`.
4268