WKNavigationResponse._downloadAttribute should be nil when no download attribute...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2
3         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
4         https://bugs.webkit.org/show_bug.cgi?id=196809
5         <rdar://49800762>
6
7         Reviewed by Brady Eidson.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
10         (TEST):
11
12 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
13
14         requestAnimationFrame should execute before the next frame
15         https://bugs.webkit.org/show_bug.cgi?id=177484
16
17         Reviewed by Simon Fraser.
18
19         Add trace points for the page RenderingUpdate.
20
21         * Tracing/SystemTracePoints.plist:
22
23 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
24
25         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
26         https://bugs.webkit.org/show_bug.cgi?id=196760
27
28         Reviewed by Don Olmstead.
29
30         vswhere.exe has been bundled since Visual Studio 2017 version
31         15.2. We shouldn't download vswhere.exe.
32
33         * Scripts/build-jsc: Do not call update-vswhere.py.
34         * Scripts/build-webkit: Ditto.
35         * Scripts/update-vswhere.py: Removed.
36         * Scripts/webkitdirs.pm:
37         (requireModulesForVSWhere): Deleted.
38         (pickCurrentVisualStudioInstallation): Deleted.
39         (visualStudioInstallDirVSWhere): Return the latest installed VS
40         installation path by using the bundled vswhere.exe.
41         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
42         (visualStudioInstallDirFallback): Removed.
43
44 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
45
46         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
47         https://bugs.webkit.org/show_bug.cgi?id=196780
48
49         Reviewed by Alexey Proskuryakov.
50
51         * BuildSlaveSupport/ews-build/steps.py:
52         * BuildSlaveSupport/ews-build/steps_unittest.py:
53
54 2019-04-10  Alex Christensen  <achristensen@webkit.org>
55
56         Add SPI WKNavigationResponse._downloadAttribute
57         https://bugs.webkit.org/show_bug.cgi?id=196755
58         <rdar://49587365>
59
60         Reviewed by Brady Eidson.
61
62         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
63         (-[NavigationResponseTestDelegate navigationResponse]):
64         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
65         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
66         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
67         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
68         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
69         (readRequest):
70         (writeResponse):
71         (TEST):
72
73 2019-04-10  Tim Horton  <timothy_horton@apple.com>
74
75         Add modern API for overriding the page's specified viewport configuration
76         https://bugs.webkit.org/show_bug.cgi?id=167734
77         <rdar://problem/30331795>
78
79         Reviewed by Simon Fraser.
80
81         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
82         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
83
84 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
85
86         Add support for incremental bytecode cache updates
87         https://bugs.webkit.org/show_bug.cgi?id=195000
88
89         Reviewed by Filip Pizlo.
90
91         Exit when the initial run to generate bytecode fails.
92
93         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
94
95 2019-04-10  Alex Christensen  <achristensen@webkit.org>
96
97         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
98         https://bugs.webkit.org/show_bug.cgi?id=196744
99         <rdar://49415309>
100
101         Reviewed by Chris Dumez.
102
103         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
104         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
105
106 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
107
108         Add a way to opt into modern compatibility mode in layout tests
109         https://bugs.webkit.org/show_bug.cgi?id=196770
110         <rdar://problem/49777550>
111
112         Reviewed by Antoine Quint.
113
114         Add a new test option to enable modern compatibility mode in layout tests.
115
116         * WebKitTestRunner/TestController.cpp:
117         (WTR::updateTestOptionsFromTestHeader):
118         * WebKitTestRunner/TestController.h:
119         * WebKitTestRunner/TestOptions.h:
120         (WTR::TestOptions::hasSameInitializationOptions const):
121         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
122         (WTR::TestController::platformCreateWebView):
123         (WTR::TestController::enableModernCompatibilityMode):
124
125 2019-04-10  Andy Estes  <aestes@apple.com>
126
127         Try to fix the 32-bit watchOS build.
128
129         * TestWebKitAPI/cocoa/TestWKWebView.mm:
130         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
131
132 2019-04-10  Antoine Quint  <graouts@apple.com>
133
134         Enable Pointer Events on watchOS
135         https://bugs.webkit.org/show_bug.cgi?id=196771
136         <rdar://problem/49040909>
137
138         Reviewed by Dean Jackson.
139
140         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
141
142 2019-04-10  Philippe Normand  <pnormand@igalia.com>
143
144         Unreviewed. Fix WPE accessibility tests after r244059.
145
146         We are failing to load the injected bundle due to undefined symbol
147         AccessibilityUIElement::replaceTextInRange().
148
149         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
150         (WTR::AccessibilityUIElement::replaceTextInRange):
151
152 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
153
154         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
155         https://bugs.webkit.org/show_bug.cgi?id=196727
156
157         Reviewed by Fujii Hironori.
158
159         * MiniBrowser/win/WebKitBrowserWindow.cpp:
160         (WebKitBrowserWindow::create):
161
162 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
163
164         [ews-build] Add unit tests for PrintConfiguration
165         https://bugs.webkit.org/show_bug.cgi?id=196752
166
167         Reviewed by Dewei Zhu.
168
169         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
170
171 2019-04-09  Keith Rollin  <krollin@apple.com>
172
173         Unreviewed build maintenance -- update .xcfilelists.
174
175         * DumpRenderTree/DerivedSources-input.xcfilelist:
176         * DumpRenderTree/DerivedSources-output.xcfilelist:
177
178 2019-04-09  Zalan Bujtas  <zalan@apple.com>
179
180         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
181         https://bugs.webkit.org/show_bug.cgi?id=196743
182         <rdar://problem/43897551>
183
184         Reviewed by Tim Horton.
185
186         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
187         (TEST):
188
189 2019-04-09  Youenn Fablet  <youenn@apple.com>
190
191         Close service worker database on network process suspension
192         https://bugs.webkit.org/show_bug.cgi?id=196623
193         <rdar://problem/48930869>
194
195         Reviewed by Alex Christensen.
196
197         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
198
199 2019-04-09  Daniel Bates  <dabates@apple.com>
200
201         [iPad] Should open popover when the spacebar is pressed
202         https://bugs.webkit.org/show_bug.cgi?id=196360
203         <rdar://problem/49389129>
204
205         Reviewed by Brent Fulgham.
206
207         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
208
209         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
210         (WTR::UIScriptController::isShowingPopover const): Added.
211         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
212         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
213         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
214         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
215         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
216         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
217         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
218         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
219         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
220         (WTR::UIScriptController::isShowingPopover const): Added.
221         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
222         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
223         * TestRunnerShared/UIScriptContext/UIScriptController.h:
224         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
225         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
226         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
227         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
228         (-[TestRunnerWKWebView _willPresentPopover]): Added.
229         (-[TestRunnerWKWebView _didDismissPopover]): Added.
230         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
231         (WTR::UIScriptController::isShowingPopover const): Added.
232         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
233         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
234
235 2019-04-09  Alex Christensen  <achristensen@webkit.org>
236
237         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
238         https://bugs.webkit.org/show_bug.cgi?id=196665
239         <rdar://45115669>
240
241         Reviewed by Geoff Garen.
242
243         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
244         (goBack):
245         (+[SimpleLookupContext sharedLookupContext]):
246         (-[SimpleLookupContext lookUpURL:completionHandler:]):
247         (TEST):
248         (+[Simple3LookupContext sharedLookupContext]): Deleted.
249         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
250
251 2019-04-09  John Wilander  <wilander@apple.com>
252
253         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
254         https://bugs.webkit.org/show_bug.cgi?id=196558
255         <rdar://problem/47650245>
256
257         Reviewed by Youenn Fablet.
258
259         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
260         (TestWebKitAPI::TEST):
261             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
262
263 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
264
265         [CMake] Apple builds should use ICU_INCLUDE_DIRS
266         https://bugs.webkit.org/show_bug.cgi?id=196720
267
268         Reviewed by Konstantin Tokarev.
269
270         * TestWebKitAPI/PlatformMac.cmake:
271
272 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
273
274         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
275         https://bugs.webkit.org/show_bug.cgi?id=196694
276         <rdar://problem/48388734>
277
278         Rubber-stamped by Aakash Jain.
279
280         * Scripts/webkitpy/port/image_diff.py:
281         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
282         * Scripts/webkitpy/port/server_process.py:
283         (ServerProcess.has_available_stdout): Check if stdout has data in it.
284         (ServerProcess._wait_for_data_and_update_buffers_using_select):
285         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
286         * Scripts/webkitpy/port/server_process_mock.py:
287         (MockServerProcess.has_available_stdout):
288         * Scripts/webkitpy/port/server_process_unittest.py:
289         (TestServerProcess.serial_test_basic):
290
291 2019-04-09  Jer Noble  <jer.noble@apple.com>
292
293         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
294         https://bugs.webkit.org/show_bug.cgi?id=196097
295
296         Reviewed by Eric Carlson.
297
298         Drive-by bug fix: allow tests to play audio without a user gesture by default.
299
300         * DumpRenderTree/mac/DumpRenderTree.mm:
301         (resetWebPreferencesToConsistentValues):
302         * WebKitTestRunner/TestController.cpp:
303         (WTR::TestController::resetPreferencesToConsistentValues):
304
305 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
306
307         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
308         https://bugs.webkit.org/show_bug.cgi?id=196690
309
310         Reviewed by Michael Catanzaro.
311
312         * QueueStatusServer/config/queues.py:
313         * Scripts/webkitpy/common/config/ews.json:
314         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
315         (test_ews_name):
316
317 2019-04-09  Chris Dumez  <cdumez@apple.com>
318
319         Loads using loadHTMLString() cause flashing when process-swapping
320         https://bugs.webkit.org/show_bug.cgi?id=196714
321         <rdar://problem/49637354>
322
323         Reviewed by Antti Koivisto.
324
325         Add API test coverage.
326
327         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
328
329 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
330
331         Unreviewed. Fix ATK accessibility tests after r244059.
332
333         We are failing to load the injected bundle due to undefined symbol
334         AccessibilityUIElement::replaceTextInRange().
335
336         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
337         (WTR::AccessibilityUIElement::replaceTextInRange):
338
339 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
340
341         AX: Support API: accessibilityReplaceRange:withText
342         https://bugs.webkit.org/show_bug.cgi?id=196636
343
344         Unreviewed build fix for Windows port.
345
346         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
347         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
348
349 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
350
351         [CMake][WinCairo] Separate copied headers into different directories
352         https://bugs.webkit.org/show_bug.cgi?id=196655
353
354         Reviewed by Michael Catanzaro.
355
356         * DumpRenderTree/CMakeLists.txt:
357         * MiniBrowser/win/CMakeLists.txt:
358         * TestWebKitAPI/CMakeLists.txt:
359         * TestWebKitAPI/PlatformWin.cmake:
360
361 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
362
363         Log stack-trace for run-webkit-tests when interrupted
364         https://bugs.webkit.org/show_bug.cgi?id=176393
365         <rdar://problem/34262310>
366
367         Reviewed by Lucas Forschler.
368
369         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
370         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
371         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
372         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
373         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
374         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
375         (main): Set handlers to log stack trace on interruption.
376
377 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
378
379         AX: Support API: accessibilityReplaceRange:withText
380         https://bugs.webkit.org/show_bug.cgi?id=196636
381
382         Unreviewed build fix for Windows port.
383
384         * DumpRenderTree/AccessibilityUIElement.cpp:
385         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
386
387 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
388
389         [ews-build] Scripts using Buildbot API have CORS error
390         https://bugs.webkit.org/show_bug.cgi?id=196709
391
392         Reviewed by Alexey Proskuryakov.
393
394         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
395
396 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
397
398         AX: Support API: accessibilityReplaceRange:withText
399         https://bugs.webkit.org/show_bug.cgi?id=196636
400
401         Reviewed by Daniel Bates.
402
403         * DumpRenderTree/AccessibilityUIElement.cpp:
404         (replaceTextInRangeCallback):
405         (AccessibilityUIElement::replaceTextInRange):
406         (AccessibilityUIElement::getJSClass):
407         * DumpRenderTree/AccessibilityUIElement.h:
408         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
409         (AccessibilityUIElement::replaceTextInRange):
410         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
411         (AccessibilityUIElement::replaceTextInRange):
412         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
413         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
414         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
415         (WTR::AccessibilityUIElement::replaceTextInRange):
416         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
417         (WTR::AccessibilityUIElement::replaceTextInRange):
418
419 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
420
421         [iOS] Do not allow starting selection drags when selection views are not visible
422         https://bugs.webkit.org/show_bug.cgi?id=196686
423         <rdar://problem/49399192>
424
425         Reviewed by Tim Horton.
426
427         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
428         also add some new API tests to cover scenarios where the web view is not first responder.
429
430         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
431         (TestWebKitAPI::TEST):
432         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
433
434         Add a switch to optionally make the web view first responder when starting the simulated drag.
435
436         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
437         (-[DragAndDropSimulator initWithWebView:]):
438         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
439
440 2019-04-08  Justin Fan  <justin_fan@apple.com>
441
442         [Web GPU] Fix Web GPU experimental feature on iOS
443         https://bugs.webkit.org/show_bug.cgi?id=196632
444
445         Reviewed by Myles C. Maxfield.
446
447         Properly make Web GPU available on iOS 11+.
448
449         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
450
451 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
452
453         [ews-build] Do not upload archive when Compile Fails
454         https://bugs.webkit.org/show_bug.cgi?id=196674
455
456         Reviewed by Alexey Proskuryakov.
457
458         * BuildSlaveSupport/ews-build/factories.py:
459         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
460         * BuildSlaveSupport/ews-build/steps.py:
461         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
462         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
463         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
464
465 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
466
467         Enable DFG on MIPS
468         https://bugs.webkit.org/show_bug.cgi?id=196689
469
470         Reviewed by Žan Doberšek.
471
472         Since the bytecode change, we enabled the baseline JIT on mips in
473         r240432, but DFG is still missing. With this change, all tests are
474         passing on a ci20 board.
475
476         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
477
478 2019-04-08  Philippe Normand  <pnormand@igalia.com>
479
480         [Flatpak] Second run update-webkitwpe-flatpak fails
481         https://bugs.webkit.org/show_bug.cgi?id=192702
482
483         Reviewed by Carlos Garcia Campos.
484
485         * flatpak/flatpakutils.py:
486         (FlatpakObject.flatpak): Fix typo.
487         (FlatpakPackage.install): When installing, also update to the configured remote commit.
488         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
489
490 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
491
492         [GTK][WPE] outlook.live.com displays old-fashioned UI
493         https://bugs.webkit.org/show_bug.cgi?id=196642
494
495         Reviewed by Carlos Garcia Campos.
496
497         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
498         (TestWebKitAPI::TEST): New Mac platform quirk test.
499
500 2019-04-07  Commit Queue  <commit-queue@webkit.org>
501
502         Unreviewed, rolling out r243956.
503         https://bugs.webkit.org/show_bug.cgi?id=196688
504
505         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
506         by aakashjain on #webkit).
507
508         Reverted changeset:
509
510         "Clicking "Go Back" from a safe browsing warning from an
511         iframe should navigate the WKWebView back to the previous
512         page"
513         https://bugs.webkit.org/show_bug.cgi?id=196665
514         https://trac.webkit.org/changeset/243956
515
516 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
517
518         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
519         https://bugs.webkit.org/show_bug.cgi?id=196669
520
521         Reviewed by Geoffrey Garen.
522
523         Added three new unit tests for WeakHashSet.
524
525         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
526         (WTF_WeakPtr.WeakHashSetConstObjects):
527         (WTF_WeakPtr.WeakHashSetComputesEmpty):
528         (WTF_WeakPtr.WeakHashSetComputeSize):
529
530 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
531
532         Hide next and previous form control buttons when WKWebView is editable
533         https://bugs.webkit.org/show_bug.cgi?id=196672
534         <rdar://problem/35625321>
535
536         Reviewed by Tim Horton.
537
538         Add a new API test.
539
540         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
541         (-[TestWKWebView lastTrailingBarButtonGroup]):
542         (TestWebKitAPI::TEST):
543         * TestWebKitAPI/ios/UIKitSPI.h:
544
545 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
546
547         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
548         https://bugs.webkit.org/show_bug.cgi?id=196077
549         <rdar://problem/49108202>
550
551         Reviewed by Chris Dumez.
552
553         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
554         on new web view.
555
556         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
557
558 2019-04-05  Saam Barati  <sbarati@apple.com>
559
560         Make compare-results understand MotionMark
561         https://bugs.webkit.org/show_bug.cgi?id=196666
562
563         Reviewed by Yusuke Suzuki.
564
565         * Scripts/compare-results:
566         (PLT5Results):
567         (detectMotionMark):
568         (detectMotionMark1_1):
569         (motionMarkResults):
570         (motionMark1_1Results):
571         (detectBenchmark):
572         (biggerIsBetter):
573         (main):
574
575 2019-04-05  Alex Christensen  <achristensen@webkit.org>
576
577         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
578         https://bugs.webkit.org/show_bug.cgi?id=196665
579         <rdar://45115669>
580
581         Reviewed by Geoff Garen.
582
583         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
584         (goBack):
585         (+[SimpleLookupContext sharedLookupContext]):
586         (-[SimpleLookupContext lookUpURL:completionHandler:]):
587         (TEST):
588         (+[Simple3LookupContext sharedLookupContext]): Deleted.
589         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
590
591 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
592
593         [ews-build] Add configuration and architecture for windows builders
594         https://bugs.webkit.org/show_bug.cgi?id=196660
595
596         Reviewed by Lucas Forschler.
597
598         * BuildSlaveSupport/ews-build/config.json:
599
600 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
601
602         webkitpy: Don't run subsequent rounds if interrupted
603         https://bugs.webkit.org/show_bug.cgi?id=196646
604
605         Reviewed by Aakash Jain.
606
607         * Scripts/webkitpy/layout_tests/controllers/manager.py:
608         (Manager.run): Bail out if interrupted.
609
610 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
611
612         Test sessionStorage in PSON private browsing mode
613         https://bugs.webkit.org/show_bug.cgi?id=196561
614
615         Reviewed by Alex Christensen.
616
617         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
618
619 2019-04-05  Commit Queue  <commit-queue@webkit.org>
620
621         Unreviewed, rolling out r243833.
622         https://bugs.webkit.org/show_bug.cgi?id=196645
623
624         This change breaks build of WPE and GTK ports (Requested by
625         annulen on #webkit).
626
627         Reverted changeset:
628
629         "[CMake][WTF] Mirror XCode header directories"
630         https://bugs.webkit.org/show_bug.cgi?id=191662
631         https://trac.webkit.org/changeset/243833
632
633 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
634
635         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
636         https://bugs.webkit.org/show_bug.cgi?id=196635
637
638         Reviewed by Antti Koivisto.
639         
640         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
641         for a test to enable async frame scrolling via:
642             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
643         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
644         
645         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
646
647         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
648         (WTR::InjectedBundle::beginTesting):
649         * WebKitTestRunner/TestController.cpp:
650         (WTR::TestController::resetPreferencesToConsistentValues):
651
652 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
653
654         Use a correct LC_RPATH when building with ASan
655         https://bugs.webkit.org/show_bug.cgi?id=196576
656
657         Reviewed by David Kilzer.
658
659         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
660         so that ../Frameworks is checked. This is simpler and more reliable than updating
661         each SPC service xcconfig.
662
663 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
664
665         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
666         https://bugs.webkit.org/show_bug.cgi?id=196629
667
668         Reviewed by Lucas Forschler.
669
670         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
671
672 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
673
674         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
675         https://bugs.webkit.org/show_bug.cgi?id=196618
676
677         Reviewed by Lucas Forschler.
678
679         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
680         (StatusBubble): Added QUEUE_TRIGGERS.
681         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
682         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
683         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
684         its parent(builder).
685
686 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
687
688         [ews-app] Status-bubble steps are sometimes displayed in reverse order
689         https://bugs.webkit.org/show_bug.cgi?id=196625
690
691         Reviewed by Lucas Forschler.
692
693         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
694         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
695
696 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
697
698         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
699         https://bugs.webkit.org/show_bug.cgi?id=196630
700
701         Reviewed by Wenson Hsieh.
702
703         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
704
705 2019-04-04  Youenn Fablet  <youenn@apple.com>
706
707         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
708         https://bugs.webkit.org/show_bug.cgi?id=196543
709
710         Reviewed by Alex Christensen.
711
712         * WebKitTestRunner/TestController.cpp:
713         (WTR::TestController::generatePageConfiguration):
714
715 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
716
717         [ews-app] Status bubble should not display skipped buildbot steps
718         https://bugs.webkit.org/show_bug.cgi?id=196584
719
720         Reviewed by Lucas Forschler.
721
722         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
723
724 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
725
726         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
727         https://bugs.webkit.org/show_bug.cgi?id=196620
728
729         Reviewed by Lucas Forschler.
730
731         * BuildSlaveSupport/ews-app/ews/config.py:
732
733 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
734
735         [Win] DumpRenderTreeWatchDog.py is not checked into source
736         https://bugs.webkit.org/show_bug.cgi?id=196567
737         <rdar://problem/49525901>
738
739         Reviewed by Lucas Forschler.
740
741         This script is used on Win EWS bots to terminate hanging DRT processes.
742
743         * EWSTools/dumprendertreewatchdog.py: Added.
744
745 2019-04-04  Chris Dumez  <cdumez@apple.com>
746
747         Unreviewed, roll out r243858 which made tests time out.
748
749         Disable new API tests on Windows instead.
750
751         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
752         (TestWebKitAPI::TEST):
753
754 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
755
756         [ATK] Cleanup WebPageAccessibilityObjectAtk
757         https://bugs.webkit.org/show_bug.cgi?id=196537
758
759         Reviewed by Michael Catanzaro.
760
761         Also consider files under atk directories as exceptions for GObject conventions.
762
763         * Scripts/webkitpy/style/checkers/cpp.py:
764         (check_identifier_name_in_declaration):
765
766 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
767
768         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
769         https://bugs.webkit.org/show_bug.cgi?id=196588
770         <rdar://problem/49365787>
771
772         Unreviewed build fix for Windows port.
773
774         error C3861: 'kill': identifier not found
775
776         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
777         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
778
779 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
780
781         [ews-build] Cancel build and similar operations should have authentication
782         https://bugs.webkit.org/show_bug.cgi?id=196520
783
784         Reviewed by Dewei Zhu.
785
786         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
787         environment variables.
788
789 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
790
791         [ews-build] Do not trigger queues which are not in production yet
792         https://bugs.webkit.org/show_bug.cgi?id=196581
793
794         Reviewed by Dewei Zhu.
795
796         * BuildSlaveSupport/ews-build/config.json:
797
798 2019-04-03  Chris Dumez  <cdumez@apple.com>
799
800         Unreviewed, fix typo in the name of API test added in r243848.
801
802         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
803         (TestWebKitAPI::TEST):
804
805 2019-04-03  Chris Dumez  <cdumez@apple.com>
806
807         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
808         https://bugs.webkit.org/show_bug.cgi?id=196588
809         <rdar://problem/49365787>
810
811         Reviewed by Ryosuke Niwa.
812
813         Add API test coverage.
814
815         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
816         (TestWebKitAPI::nullJavaScriptCallback):
817         (TestWebKitAPI::didCrashCheckFrames):
818         (TestWebKitAPI::TEST):
819
820 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
821
822         run-webkit-tests: Upload test results (new results database)
823         https://bugs.webkit.org/show_bug.cgi?id=196577
824         <rdar://problem/34841155>
825
826         Reviewed by Lucas Forschler.
827
828         * Scripts/webkitpy/layout_tests/controllers/manager.py:
829         (Manager.run): Upload results after each device shard, since the configuration will be
830         different for each device.
831         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
832         uploaded to a results database.
833         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
834         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
835
836 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
837
838         -apple-trailing-word is needed for browser detection
839         https://bugs.webkit.org/show_bug.cgi?id=196575
840
841         Unreviewed.
842
843         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
844
845 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
846
847         [CMake][WTF] Mirror XCode header directories
848         https://bugs.webkit.org/show_bug.cgi?id=191662
849
850         Reviewed by Konstantin Tokarev.
851
852         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
853         builds.
854
855         * CMakeLists.txt:
856         * DumpRenderTree/CMakeLists.txt:
857         * DumpRenderTree/PlatformWin.cmake:
858         * MiniBrowser/win/CMakeLists.txt:
859         * TestWebKitAPI/CMakeLists.txt:
860         * TestWebKitAPI/PlatformWin.cmake:
861         * WebKitTestRunner/PlatformGTK.cmake:
862         * WebKitTestRunner/PlatformWin.cmake:
863
864 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
865
866         [ews-app] Status bubble should not display certain infrastructure status messages
867         https://bugs.webkit.org/show_bug.cgi?id=196550
868
869         Reviewed by Lucas Forschler.
870
871         Do not display the steps which are un-needed for end-user. This information is still avaiable
872         if the user click on the bubble and look at the Buildbot build.
873         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
874         (StatusBubble._steps_messages):
875         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
876
877 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
878
879         [ews-build] Use https for sending data to ews-app
880         https://bugs.webkit.org/show_bug.cgi?id=196492
881
882         Reviewed by Lucas Forschler.
883
884         * BuildSlaveSupport/ews-build/events.py:
885
886 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
887
888         Remove support for -apple-trailing-word
889         https://bugs.webkit.org/show_bug.cgi?id=196525
890
891         Reviewed by Zalan Bujtas.
892
893         This CSS property is nonstandard and not used.
894
895         * Scripts/webkitperl/FeatureList.pm:
896         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
897
898 2019-04-03  Youenn Fablet  <youenn@apple.com>
899
900         Add a test for DOMCache on multiple browsing in case of private browsing
901         https://bugs.webkit.org/show_bug.cgi?id=196524
902
903         Reviewed by Alex Christensen.
904
905         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
906         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
907
908 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
909
910         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
911         https://bugs.webkit.org/show_bug.cgi?id=196540
912
913         Reviewed by Aakash Jain.
914
915         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
916
917 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
918
919         Add plumbing for a compatibility mode preference in WebKit
920         https://bugs.webkit.org/show_bug.cgi?id=196005
921
922         Reviewed by Tim Horton.
923
924         Add new API tests.
925
926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
927         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
928
929 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
930
931         [WPE][GTK] Update libsrtp dependency package for Debian
932         https://bugs.webkit.org/show_bug.cgi?id=196528
933
934         Reviewed by Frédéric Wang.
935
936         * gtk/install-dependencies:
937         * wpe/install-dependencies:
938
939 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
940
941         [WK2] Add support for Window's beforeprint / afterprint events
942         https://bugs.webkit.org/show_bug.cgi?id=196478
943         <rdar://problem/49535124>
944
945         Unreviewed build fix for MSVC.
946
947         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
948
949         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
950
951         * WebKitTestRunner/TestController.cpp:
952         (WTR::printFrame): Use int and float literals.
953
954 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
955
956         [ews-build] Reassign bots to queues
957
958         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
959
960 2019-04-02  Chris Dumez  <cdumez@apple.com>
961
962         [WK2] Add support for Window's beforeprint / afterprint events
963         https://bugs.webkit.org/show_bug.cgi?id=196478
964
965         Reviewed by Alex Christensen.
966
967         Add minimal implementation for printFrame in WebKitTestRunner.
968
969         * WebKitTestRunner/TestController.cpp:
970         (WTR::printFrame):
971         (WTR::TestController::createOtherPage):
972         (WTR::TestController::createWebViewWithOptions):
973
974 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
975
976         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
977         https://bugs.webkit.org/show_bug.cgi?id=196491
978
979         Reviewed by Lucas Forschler.
980
981         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
982
983 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
984
985         [ews-build] Configure buildbot try credentials in environment variables
986         https://bugs.webkit.org/show_bug.cgi?id=196501
987
988         Reviewed by Lucas Forschler.
989
990         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
991         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
992         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
993
994 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
995
996         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
997         https://bugs.webkit.org/show_bug.cgi?id=196496
998         <rdar://problem/49521634>
999
1000         Reviewed by Chris Dumez.
1001
1002         Add new API tests (see WebKit ChangeLog for more detail).
1003
1004         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1005         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1006         (TEST):
1007
1008 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1009
1010         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1011         <https://webkit.org/b/196499>
1012
1013         Reviewed by Alexey Proskuryakov.
1014
1015         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1016         ENABLE_ADDRESS_SANITIZER.
1017
1018 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1019
1020         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1021         https://bugs.webkit.org/show_bug.cgi?id=182757
1022
1023         Reviewed by Don Olmstead.
1024
1025         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1026         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1027
1028 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1029
1030         run-api-tests: Upload test results
1031         https://bugs.webkit.org/show_bug.cgi?id=196323
1032         <rdar://problem/49356714>
1033
1034         Reviewed by Lucas Forschler.
1035
1036         * Scripts/webkitpy/api_tests/manager.py:
1037         (Manager):
1038         (Manager.run): Upload results to a results database.
1039         * Scripts/webkitpy/api_tests/run_api_tests.py:
1040         (parse_args): Add upload arguments.
1041         * Scripts/webkitpy/port/base.py:
1042         (Port):
1043         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1044         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1045         with commits from any other associated repositories.
1046         * Scripts/webkitpy/port/device.py:
1047         (Device):
1048         (Device.build_version): Access build_versoin of underlying platform device.
1049         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1050         (IOSSimulatorTest):
1051         (IOSSimulatorTest.test_configuration_for_upload):
1052         * Scripts/webkitpy/port/device_port.py:
1053         (DevicePort):
1054         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1055         the same as the machine uploading results.
1056         * Scripts/webkitpy/port/mac.py:
1057         (MacPort):
1058         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1059         * Scripts/webkitpy/port/mac_unittest.py:
1060         (MacTest):
1061         (MacTest.test_configuration_for_upload):
1062         * Scripts/webkitpy/xcode/simulated_device.py:
1063         (SimulatedDeviceManager._create_device_with_runtime):
1064         (SimulatedDevice.__init__): Create simulated device with a build_version.
1065         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1066         (test_existing_simulator):
1067
1068 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1069
1070         Remove extra newline characters (Follow-up fix to r243707)
1071
1072         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1073
1074 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1075
1076         [ews-app] Use API_KEY to accept results data
1077         https://bugs.webkit.org/show_bug.cgi?id=196461
1078
1079         Reviewed by Dewei Zhu.
1080
1081         * BuildSlaveSupport/ews-app/ews/views/results.py:
1082         (Results.post): Validate EWS_API_KEY before accepting any data.
1083         * BuildSlaveSupport/ews-build/events.py:
1084         (Events.sendData): Send EWS_API_KEY if available along with event data.
1085
1086 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1087
1088         Unable to copy and paste a PDF from Notes into Mail compose body
1089         https://bugs.webkit.org/show_bug.cgi?id=196442
1090         <rdar://problem/48573098>
1091
1092         Reviewed by Tim Horton.
1093
1094         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1095         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1096         to be specified on the item providers.
1097
1098         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1099         (TestWebKitAPI::mapItemForTesting):
1100         (TestWebKitAPI::contactItemForTesting):
1101
1102 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1103
1104         Make UIWKDocumentContext rects per-character instead of per-word
1105         https://bugs.webkit.org/show_bug.cgi?id=196459
1106
1107         Reviewed by Wenson Hsieh.
1108
1109         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1110         (TEST):
1111         Adjust test results due to switching to per-character rects.
1112
1113 2019-04-01  Chris Dumez  <cdumez@apple.com>
1114
1115         UIProcess crash when a prewarmed process is terminated
1116         https://bugs.webkit.org/show_bug.cgi?id=196451
1117         <rdar://problem/49245471>
1118
1119         Reviewed by Geoffrey Garen.
1120
1121         Add API test coverage.
1122
1123         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1124         (TEST):
1125
1126 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1127
1128         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1129         https://bugs.webkit.org/show_bug.cgi?id=196449
1130
1131         Reviewed by Lucas Forschler.
1132
1133         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1134         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1135         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1136         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1137
1138 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1139
1140         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1141         https://bugs.webkit.org/show_bug.cgi?id=196444
1142
1143         Reviewed by Lucas Forschler.
1144
1145         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1146
1147 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1148
1149         Add SPI to canonicalize NSURLs with WTF::URL
1150         https://bugs.webkit.org/show_bug.cgi?id=196415
1151         <rdar://problem/44980271>
1152
1153         Reviewed by Darin Adler.
1154
1155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1156         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1157         (TestWebKitAPI::TEST):
1158
1159 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1160
1161         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1162         https://bugs.webkit.org/show_bug.cgi?id=196441
1163
1164         Reviewed by Carlos Garcia Campos.
1165
1166         Don't cache the wpe_view_backend object that might not exist yet at the
1167         time of EventSenderProxy constructor invocation, but instead retrieve
1168         that object whenever it's required for event dispatching. This should
1169         avoid crashes in this constructor now that it's invoked before any
1170         PlatformWindow has been set up (as changed in r243496).
1171
1172         * WebKitTestRunner/EventSenderProxy.h:
1173         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1174         (WTR::viewBackend):
1175         (WTR::EventSenderProxy::EventSenderProxy):
1176         (WTR::EventSenderProxy::mouseDown):
1177         (WTR::EventSenderProxy::mouseUp):
1178         (WTR::EventSenderProxy::mouseMoveTo):
1179         (WTR::EventSenderProxy::mouseScrollBy):
1180         (WTR::EventSenderProxy::keyDown):
1181         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1182
1183 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1184
1185         [Win][WebKit] MiniBrowser should support high DPI display
1186         https://bugs.webkit.org/show_bug.cgi?id=196391
1187
1188         Reviewed by Alex Christensen.
1189
1190         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1191         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1192         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1193         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1194
1195 2019-03-31  Sam Weinig  <weinig@apple.com>
1196
1197         Remove more i386 specific configurations
1198         https://bugs.webkit.org/show_bug.cgi?id=196430
1199
1200         Reviewed by Alexey Proskuryakov.
1201
1202         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1203         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1204
1205 2019-03-31  Andy Estes  <aestes@apple.com>
1206
1207         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1208         https://bugs.webkit.org/show_bug.cgi?id=196433
1209         <rdar://problem/49293305>
1210
1211         Reviewed by Tim Horton.
1212
1213         Enhanced API test coverage to include all navigation response policy decisions in both
1214         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1215
1216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1217         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1218         (TestWebKitAPI::TEST):
1219         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1220         (readFile):
1221         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1222         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1223         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1224         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1225         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1226         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1227         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1228         (-[QuickLookDelegate _downloadDidStart:]):
1229         (-[QuickLookDelegate _download:didReceiveResponse:]):
1230         (-[QuickLookDelegate _download:didReceiveData:]):
1231         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1232         (-[QuickLookDelegate _downloadDidFinish:]):
1233         (-[QuickLookDelegate _download:didFailWithError:]):
1234         (-[QuickLookDelegate _downloadDidCancel:]):
1235         (-[QuickLookDelegate verifyDownload]):
1236         (runTest):
1237         (runTestDecideBeforeLoading):
1238         (runTestDecideAfterLoading):
1239         (TEST):
1240         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1241         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1242         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1243         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1244         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1245         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1246         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1247         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1248         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1249         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1250         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1251         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1252         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1253         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1254
1255 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1256
1257         [CMake] add testdfg as target with build-jsc
1258         https://bugs.webkit.org/show_bug.cgi?id=196393
1259
1260         Reviewed by Saam Barati.
1261
1262         Added testdfg as one of the targets to build when
1263         using CMake.
1264
1265         * Scripts/build-jsc:
1266
1267 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1268
1269         Delete WebMetal implementation in favor of WebGPU
1270         https://bugs.webkit.org/show_bug.cgi?id=195418
1271
1272         Reviewed by Dean Jackson.
1273
1274         * DumpRenderTree/mac/DumpRenderTree.mm:
1275         (enableExperimentalFeatures):
1276         (resetWebPreferencesToConsistentValues):
1277         * Scripts/webkitperl/FeatureList.pm:
1278         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1279         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1280         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1281         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1282         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1283         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1284         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1285         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1286         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1287         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1288         (WTR::InjectedBundle::beginTesting):
1289         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1290         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1291         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1292
1293 2019-03-29  Chris Dumez  <cdumez@apple.com>
1294
1295         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1296         https://bugs.webkit.org/show_bug.cgi?id=196405
1297         <rdar://problem/49428130>
1298
1299         Reviewed by Wenson Hsieh.
1300
1301         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1302         the popover presentation methods to be no-ops. Use this in the new test added in
1303         r243523 so that we do not swizzle those methods for all tests. This is needed because
1304         those WatchOS tests rely on the popover getting presented and interactive.
1305
1306         * WebKitTestRunner/TestController.cpp:
1307         (WTR::updateTestOptionsFromTestHeader):
1308         * WebKitTestRunner/TestController.h:
1309         * WebKitTestRunner/TestOptions.h:
1310         (WTR::TestOptions::hasSameInitializationOptions const):
1311         * WebKitTestRunner/ios/TestControllerIOS.mm:
1312         (WTR::TestController::platformInitialize):
1313         (WTR::TestController::platformResetStateToConsistentValues):
1314
1315 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1316
1317         [Curl] Add Server Trust Evaluation Support.
1318         https://bugs.webkit.org/show_bug.cgi?id=191646
1319
1320         Reviewed by Fujii Hironori.
1321
1322         Implemented MiniBrowser UI for asking if user trusts the server.
1323
1324         * MiniBrowser/win/Common.cpp:
1325         (askServerTrustEvaluation):
1326         (replaceString):
1327         * MiniBrowser/win/Common.h:
1328         * MiniBrowser/win/MiniBrowserLib.rc:
1329         * MiniBrowser/win/MiniBrowserLibResource.h:
1330         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1331         (createPEMString):
1332         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1333         (WebKitBrowserWindow::canTrustServerCertificate):
1334         * MiniBrowser/win/WebKitBrowserWindow.h:
1335
1336 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1337
1338         Implement ResizeObserver.
1339         https://bugs.webkit.org/show_bug.cgi?id=157743
1340
1341         Reviewed by Simon Fraser.
1342
1343         Support resizeObserverEnabled webPreferences.
1344
1345         * DumpRenderTree/TestOptions.cpp:
1346         (TestOptions::TestOptions):
1347         * DumpRenderTree/TestOptions.h:
1348         * DumpRenderTree/mac/DumpRenderTree.mm:
1349         (setWebPreferencesForTestOptions):
1350         * DumpRenderTree/win/DumpRenderTree.cpp:
1351         (enableExperimentalFeatures):
1352         * Scripts/webkitperl/FeatureList.pm:
1353         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1354
1355 2019-03-28  John Wilander  <wilander@apple.com>
1356
1357         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1358         https://bugs.webkit.org/show_bug.cgi?id=196281
1359         <rdar://problem/48938748>
1360
1361         Reviewed by Alex Christensen.
1362
1363         This patch adds the function isStatisticsHasLocalStorage() to the
1364         TestRunner. With it, the page can query the WebsiteDataStore in the
1365         UI process to make sure that it sees LocalStorage.
1366
1367         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1368         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1369         (WTR::TestRunner::isStatisticsHasLocalStorage):
1370         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1371         * WebKitTestRunner/TestController.cpp:
1372         (WTR::TestController::isStatisticsHasLocalStorage):
1373         * WebKitTestRunner/TestController.h:
1374         * WebKitTestRunner/TestInvocation.cpp:
1375         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1376
1377 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1378
1379         API::Data::createWithoutCopying should do a null check before calling CFRelease
1380         https://bugs.webkit.org/show_bug.cgi?id=196276
1381         <rdar://problem/48059859>
1382
1383         Reviewed by Alex Christensen.
1384
1385         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1386
1387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1388         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1389         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1390         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1391         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1392         (TestWebKitAPI::TEST):
1393
1394 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1395
1396         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1397         https://bugs.webkit.org/show_bug.cgi?id=186276
1398
1399         Reviewed by Carlos Garcia Campos.
1400
1401         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1402         (webViewLoadChanged):
1403         (testWebResourceGetDataError):
1404         (testWebResourceGetDataEmpty):
1405         (beforeAll):
1406         (webViewloadChanged): Deleted.
1407
1408 2019-03-27  Andy Estes  <aestes@apple.com>
1409
1410         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1411         https://bugs.webkit.org/show_bug.cgi?id=196317
1412
1413         Reviewed by Dan Bernstein.
1414
1415         package-root copies built products into a staging directory using ditto(1), which does not
1416         follow symbolic links as it traverses a directory. Now that the files in
1417         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1418         itself, these become broken links when ditto'd into the staging directory.
1419
1420         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1421
1422         * Scripts/package-root:
1423
1424 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1425
1426         [ews-app] Update display text of Submit for ews analysis
1427         https://bugs.webkit.org/show_bug.cgi?id=196309
1428
1429         Reviewed by Dewei Zhu.
1430
1431         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1432
1433 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1434
1435         run-webkit-tests should check for leaks in WebKit processes
1436         <https://webkit.org/b/193772>
1437         <rdar://problem/46526680>
1438
1439         Reviewed by Ryosuke Niwa.
1440
1441         This works by doing the following:
1442         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1443           The list of child processes are returned one per line:
1444           process.name: pid
1445         - Run the "#LIST CHILD PROCESSES" command just before the
1446           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1447           processes on the ServerProcess object.
1448         - When the `--leaks` switch is handled, run check_for_leaks() on
1449           each child process after the main test harness.
1450
1451         * DumpRenderTree/mac/DumpRenderTree.mm:
1452         (handleControlCommand):
1453         - Use strncmp() instead of strcmp().
1454         - Add support for handling "#LIST CHILD PROCESSES" command.
1455
1456         * Scripts/webkitpy/port/base.py:
1457         (Port.check_for_leaks):
1458         * Scripts/webkitpy/port/darwin.py:
1459         (DarwinPort.check_for_leaks):
1460         - Rename redundant 'process_pid' argument to 'process_id'.
1461
1462         * Scripts/webkitpy/port/driver.py:
1463         (Driver.do_post_tests_work):
1464         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1465           longer the only command this sends to WebKitTestRunner.
1466         - If the `--leaks` switch is present, send the
1467           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1468           result using Port.set_webkit_processes().
1469         (Driver._parse_child_processes_output):
1470         - Add helper method to parse list of child process names and
1471           process IDs returned from WebKitTestRunner.
1472
1473         * Scripts/webkitpy/port/ios_device.py:
1474         (IOSDevicePort.check_for_leaks):
1475         - Rename redundant 'process_pid' argument to 'process_id'.
1476
1477         * Scripts/webkitpy/port/leakdetector.py:
1478         (LeakDetector._parse_leaks_output):
1479         - Return early if there is no leaks_output.
1480         (LeakDetector.check_for_leaks):
1481         - Rename redundant 'process_pid' argument to 'process_id'.
1482
1483         * Scripts/webkitpy/port/server_process.py:
1484         (ServerProcess.__init__):
1485         (ServerProcess.child_processes):
1486         (ServerProcess.set_child_processes):
1487         - Add instance variable to Port to store list of child process
1488           names and process IDs returned from WebKitTestRunner.
1489         (ServerProcess._start):
1490         - Clear self._child_processes.
1491         (ServerProcess.stop):
1492         - If self._child_processes is set, call
1493           self._port.check_for_leaks() for each child process.
1494
1495         * Scripts/webkitpy/port/server_process_unittest.py:
1496         (TrivialMockPort.check_for_leaks):
1497         - Rename redundant 'process_pid' argument to 'process_id'.
1498
1499         * Scripts/webkitpy/port/simulator_process.py:
1500         (SimulatorProcess.stop):
1501         - If self._child_processes is set, call
1502           self._port.check_for_leaks() for each child process.
1503
1504         * Scripts/webkitpy/port/watch_device.py:
1505         (WatchDevicePort.check_for_leaks):
1506         - Rename redundant 'process_pid' argument to 'process_id'.
1507
1508         * WebKitTestRunner/TestController.cpp:
1509         (WTR::TestController::dumpResponse):
1510         - Extract method from findAndDumpWorldLeaks() so that it may be
1511           reused by findAndDumpWebKitProcessIdentifiers().
1512         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1513         - Add method to output process name and process ID of both the
1514           WebContent and Networking processes.
1515         (WTR::TestController::findAndDumpWorldLeaks):
1516         - Fix missing newline in output when there were no abandoned
1517           documents.
1518         - Call dumpResponse() for extracted code.
1519         (WTR::TestController::handleControlCommand):
1520         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1521         - Use strncmp() instead of strcmp().
1522         - Call findAndDumpWebKitProcessIdentifiers() when
1523           "#LIST CHILD PROCESSES" command is sent.
1524         * WebKitTestRunner/TestController.h:
1525         (WTR::TestController::dumpResponse):
1526         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1527         - Declare methods.
1528
1529 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1530
1531         Unreviewed. Add GLib API test cases after r243434.
1532
1533         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1534         (testWebViewActiveURI):
1535         (serverCallback):
1536         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1537         (sendRequestCallback):
1538
1539 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1540
1541         Geolocation request not complete when watch request was started in a different web process
1542         https://bugs.webkit.org/show_bug.cgi?id=195996
1543
1544         Reviewed by Alex Christensen.
1545
1546         Add a test case.
1547
1548         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1549         (TestWebKitAPI::runJavaScriptAlert):
1550         (TestWebKitAPI::TEST):
1551
1552 2019-03-26  Keith Rollin  <krollin@apple.com>
1553
1554         Update the way generate-xcfilelists returns strings from functions
1555         https://bugs.webkit.org/show_bug.cgi?id=195975
1556         <rdar://problem/49040807>
1557
1558         Reviewed by Dean Jackson.
1559
1560         There are places where generate-xcfilelists executes assignments with
1561         statements like:
1562
1563             FOO=$(some_function)
1564
1565         where "some_function" return a string by echoing it. E.g.
1566
1567             some_function()
1568             {
1569                 echo "Hello, World"
1570             }
1571
1572         This is a common idiom, but it has a problem if "some_function" needs
1573         to call "exit" in an attempt to halt the entire script right then and
1574         there. Since "some_function" is called inside of $(), it's being
1575         executed in a sub-shell. Calling exit in that sub-shell simply exits
1576         that shell; it doesn't not exit the outer shell in which the main part
1577         of the script is still running. As such, the main script keeps
1578         executing when the intent was for the script to halt.
1579
1580         The solution to this is to use a different idiom for returning
1581         strings. The one we now is to pass in the name of the variable to
1582         receive the string result:
1583
1584             some_function()
1585             {
1586                 variable_name=$1
1587                 eval $variable_name ="Hello, World"
1588             }
1589
1590         The call site now looks like
1591
1592             some_function FOO
1593
1594         Because there's no invocation of a sub-shell, some_function can now
1595         call "exit" if it wants to, and the entire script will exit at that
1596         point.
1597
1598         * Scripts/generate-xcfilelists:
1599
1600 2019-03-26  Chris Dumez  <cdumez@apple.com>
1601
1602         Add basic layout test coverage for File Picker on iOS
1603         https://bugs.webkit.org/show_bug.cgi?id=196265
1604
1605         Reviewed by Wenson Hsieh.
1606
1607         Add layout test infrastructure to test the file picker on iOS.
1608
1609         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1610         (WTR::UIScriptController::dismissFilePicker):
1611         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1612         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1613         (WTR::UIScriptController::dismissFilePicker):
1614         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1615         * WebKitTestRunner/TestController.cpp:
1616         (WTR::TestController::createWebViewWithOptions):
1617         (WTR::updateTestOptionsFromTestHeader):
1618         * WebKitTestRunner/TestOptions.h:
1619         (WTR::TestOptions::hasSameInitializationOptions const):
1620         * WebKitTestRunner/ios/TestControllerIOS.mm:
1621         (overridePresentViewController):
1622         (WTR::TestController::platformInitialize):
1623         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1624         (WTR::UIScriptController::dismissFilePicker):
1625
1626 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1627
1628         Implement async paste method on UIWKInteractionViewProtocol
1629         https://bugs.webkit.org/show_bug.cgi?id=196267
1630         <rdar://problem/49236346>
1631
1632         Reviewed by Tim Horton.
1633
1634         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1635         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1636         are now a part of all iOS 12 internal SDKs.
1637
1638         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1639
1640         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1641         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1642
1643         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1644         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1645         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1646         * TestWebKitAPI/ios/UIKitSPI.h:
1647
1648 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1649
1650         [ews-build] Use PostgreSQL for ews.webkit.org database
1651         https://bugs.webkit.org/show_bug.cgi?id=196270
1652
1653         Reviewed by Lucas Forschler.
1654
1655         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1656
1657 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1658
1659         [ews] Reset simctl states on reboot
1660         https://bugs.webkit.org/show_bug.cgi?id=196260
1661
1662         Rubber-stamped by Aakash Jain.
1663
1664         * EWSTools/start-queue-mac.sh:
1665
1666 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1667
1668         [ews-build] Use PostgreSQL for ews-build database
1669         https://bugs.webkit.org/show_bug.cgi?id=196229
1670
1671         Reviewed by Lucas Forschler.
1672
1673         * BuildSlaveSupport/ews-build/master.cfg:
1674
1675 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1676
1677         [ews-build] Get master_hostname dynamically in master.cfg
1678         https://bugs.webkit.org/show_bug.cgi?id=196255
1679
1680         Reviewed by Lucas Forschler.
1681
1682         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1683         send events data in test mode.
1684
1685 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1686
1687         [ews-app] Set db_constraint to False for Foreign Keys
1688         https://bugs.webkit.org/show_bug.cgi?id=196252
1689
1690         Reviewed by Lucas Forschler.
1691
1692         * BuildSlaveSupport/ews-app/ews/models/build.py:
1693         * BuildSlaveSupport/ews-app/ews/models/step.py:
1694
1695 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1696
1697         [ews-build] is_test_mode_enabled should default to True
1698         https://bugs.webkit.org/show_bug.cgi?id=196248
1699
1700         Reviewed by Lucas Forschler.
1701
1702         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1703
1704 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1705
1706         [ews-app] Add webkitperl to ENABLED_QUEUES
1707         https://bugs.webkit.org/show_bug.cgi?id=196253
1708
1709         Reviewed by Lucas Forschler.
1710
1711         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1712
1713 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1714
1715         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1716         https://bugs.webkit.org/show_bug.cgi?id=196211
1717         rdar://problem/49110552
1718
1719         Reviewed by Tim Horton.
1720
1721         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1722         Make sure that EventSenderProxy always exists when running tests. We used to create
1723         it when resetting before the first test, which is a bit too late.
1724
1725         * WebKitTestRunner/TestController.h:
1726         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1727         (WTR::TestController::platformCreateWebView):
1728         (WTR::TestController::platformCreateOtherPage):
1729         (WTR::TestController::finishCreatingPlatformWebView):
1730         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1731         (WTR::PlatformWebView::PlatformWebView):
1732         Moved some code that made NSWindow use NSEvent during web view creation. We may
1733         need to move more if some other case us found, but this is enough for now.
1734
1735 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1736
1737         Unreviewed. Fix typo in GLib geolocation API after r243285.
1738
1739         gelocation -> geolocation.
1740
1741         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1742         (testGeolocationManagerWatchPosition):
1743
1744 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1745
1746         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1747         https://bugs.webkit.org/show_bug.cgi?id=196213
1748
1749         Reviewed by Geoff Garen.
1750
1751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1752         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1753         (credentialWithIdentityAndKeychainPath):
1754         (-[ChallengeDelegate webView:didFinishNavigation:]):
1755         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1756         (TestWebKitAPI::TEST):
1757
1758 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1759
1760         Expected shouldn't assume its contained types are copyable
1761         https://bugs.webkit.org/show_bug.cgi?id=195986
1762
1763         Reviewed by JF Bastien.
1764
1765         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1766         (TestWebKitAPI::NonCopyable::operator== const):
1767         (TestWebKitAPI::NonCopyable::operator!= const):
1768         (TestWebKitAPI::TEST):
1769
1770 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1771
1772         Remove some now-unnecessary dynamic class lookup
1773         https://bugs.webkit.org/show_bug.cgi?id=196237
1774
1775         Reviewed by Simon Fraser.
1776
1777         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1778         (makeRequest):
1779         (TEST):
1780
1781 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1782
1783         Unreviewed, rolling out r243450.
1784
1785         AppleWin and WinCairo port builds get broken.
1786
1787         Reverted changeset:
1788
1789         "Add test for fix of #196095"
1790         https://bugs.webkit.org/show_bug.cgi?id=196097
1791         https://trac.webkit.org/changeset/243450
1792
1793 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1794
1795         Unreviewed, rolling out r243465.
1796         https://bugs.webkit.org/show_bug.cgi?id=196226
1797
1798         the test doesn't build (Requested by thorton on #webkit).
1799
1800         Reverted changeset:
1801
1802         "Do not terminate the NetworkProcess if a third party
1803         application sends a NSCredential with a SecIdentityRef"
1804         https://bugs.webkit.org/show_bug.cgi?id=196213
1805         https://trac.webkit.org/changeset/243465
1806
1807 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1808
1809         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1810         https://bugs.webkit.org/show_bug.cgi?id=196213
1811
1812         Reviewed by Geoff Garen.
1813
1814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1815         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1816         (credentialWithIdentityAndKeychainPath):
1817         (-[ChallengeDelegate webView:didFinishNavigation:]):
1818         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1819         (TestWebKitAPI::TEST):
1820
1821 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1822
1823         [ews-build] Gracefully handle missing patch_id in events
1824         https://bugs.webkit.org/show_bug.cgi?id=196216
1825
1826         Reviewed by Lucas Forschler.
1827
1828         * BuildSlaveSupport/ews-build/events.py:
1829
1830 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1831
1832         [ews-build] use lz4 compression for improving buildbot performance
1833         https://bugs.webkit.org/show_bug.cgi?id=196155
1834
1835         Reviewed by Lucas Forschler.
1836
1837         * BuildSlaveSupport/ews-build/master.cfg:
1838
1839 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1840
1841         Pull some API testing helper methods out of TestWKWebView
1842         https://bugs.webkit.org/show_bug.cgi?id=196212
1843
1844         Reviewed by Tim Horton.
1845
1846         Refactor some more API testing utility methods, so that they can be used in
1847         tests that do not use TestWKWebView.
1848
1849         * TestWebKitAPI/cocoa/TestWKWebView.h:
1850         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1851         (-[WKWebView loadTestPageNamed:]):
1852         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1853         (-[WKWebView synchronouslyLoadHTMLString:]):
1854         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1855         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1856         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1857         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1858         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1859
1860 2019-03-25  Jer Noble  <jer.noble@apple.com>
1861
1862         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1863         https://bugs.webkit.org/show_bug.cgi?id=196097
1864
1865         Reviewed by Eric Carlson.
1866
1867         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1868
1869         * DumpRenderTree/mac/DumpRenderTree.mm:
1870         (resetWebPreferencesToConsistentValues):
1871         * WebKitTestRunner/TestController.cpp:
1872         (WTR::TestController::resetPreferencesToConsistentValues):
1873
1874 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1875
1876         Pull IPadUserInterfaceSwizzler out into a separate header file
1877         https://bugs.webkit.org/show_bug.cgi?id=196193
1878
1879         Reviewed by Anders Carlsson.
1880
1881         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1882         be used in other API tests.
1883
1884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1885         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1886         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1887         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1888         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1889         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1890         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1891
1892 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1893
1894         Remove NavigatorContentUtils in WebCore/Modules
1895         https://bugs.webkit.org/show_bug.cgi?id=196070
1896
1897         Reviewed by Alex Christensen.
1898
1899         NavigatorContentUtils was to support the custom scheme spec [1].
1900         However, in WebKit side, no port has supported the feature in
1901         WebKit layer after EFL port was removed. So there has been the
1902         only IDL implementation of the NavigatorContentUtils in WebCore.
1903         So we don't need to keep the implementation in WebCore anymore.
1904
1905         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1906
1907         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1908
1909 2019-03-24  Andy Estes  <aestes@apple.com>
1910
1911         [watchOS] Remove unused Proximity Networking code
1912         https://bugs.webkit.org/show_bug.cgi?id=196188
1913
1914         Reviewed by Tim Horton.
1915
1916         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1917         (TEST):
1918
1919 2019-03-23  Keith Miller  <keith_miller@apple.com>
1920
1921         Refactor clz/ctz and fix getLSBSet.
1922         https://bugs.webkit.org/show_bug.cgi?id=196162
1923
1924         Reviewed by Saam Barati.
1925
1926         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1927
1928         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1929         (TestWebKitAPI::TEST):
1930
1931 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1932
1933         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1934         https://bugs.webkit.org/show_bug.cgi?id=196143
1935
1936         Reviewed by Michael Catanzaro.
1937
1938         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1939         directories.
1940
1941         * Scripts/webkitpy/style/checkers/cpp.py:
1942         (check_identifier_name_in_declaration):
1943         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1944         (WebKitStyleTest.test_names):
1945
1946 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1947
1948         [Flatpak] Manifest expanding fails for qt WPE extension
1949         https://bugs.webkit.org/show_bug.cgi?id=196148
1950
1951         Reviewed by Alex Christensen.
1952
1953         * flatpak/flatpakutils.py:
1954         (expand_submodules_recurse): The last recurse manifest expand
1955         iteration might lead to a single module so take it into account
1956         and don't try to recurse further.
1957
1958 2019-03-22  Chris Dumez  <cdumez@apple.com>
1959
1960         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1961         https://bugs.webkit.org/show_bug.cgi?id=195348
1962         <rdar://problem/48622090>
1963
1964         Reviewed by Alex Christensen.
1965
1966         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1967         to NO when test.options().shouldIgnoreMetaViewport is false.
1968
1969         * WebKitTestRunner/ios/TestControllerIOS.mm:
1970         (WTR::TestController::platformConfigureViewForTest):
1971
1972 2019-03-22  Chris Dumez  <cdumez@apple.com>
1973
1974         Prewarmed processes should be usable with any website data store
1975         https://bugs.webkit.org/show_bug.cgi?id=196104
1976
1977         Reviewed by Alex Christensen.
1978
1979         Add API test coverage.
1980
1981         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1982         (runInitialWarmedProcessUsedTest):
1983         (TEST):
1984
1985 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1986
1987         Back out local changes to Alex's Subversion working directory
1988
1989         They were accidentally committed.
1990
1991         * Scripts/webkitpy/common/system/abstractexecutive.py:
1992         (AbstractExecutive.wait_newest):
1993         * Scripts/webkitpy/common/system/executive.py:
1994         (Executive.running_pids):
1995         * Scripts/webkitpy/common/system/executive_mock.py:
1996         (MockExecutive.running_pids):
1997         * Scripts/webkitpy/common/system/executive_unittest.py:
1998         (ExecutiveTest.serial_test_running_pids):
1999         * Scripts/webkitpy/port/darwin.py:
2000         (DarwinPort.check_for_leaks):
2001         * Scripts/webkitpy/port/leakdetector.py:
2002         (LeakDetector.check_for_leaks):
2003         - This was the hack attached to Bug 193772.
2004
2005         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2006         (+[WebKitTestRunnerEvent mouseLocation]):
2007         - This works around a crash on an internal build.
2008
2009 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2010
2011         Fix the build after r243354
2012         https://bugs.webkit.org/show_bug.cgi?id=196138
2013         <rdar://problem/49145951>
2014
2015         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2016         (TEST):
2017         * TestWebKitAPI/ios/UIKitSPI.h:
2018
2019 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2020
2021         Adopt UIWKDocumentContext
2022         https://bugs.webkit.org/show_bug.cgi?id=196040
2023         <rdar://problem/48642440>
2024
2025         Reviewed by Ryosuke Niwa.
2026
2027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2028         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2029         (makeRequest):
2030         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2031         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2032         (applyStyle):
2033         (TEST):
2034         Add tests for UIWKDocumentContext.
2035
2036         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2037         (TEST):
2038         (recursiveFindWKContentView): Deleted.
2039         * TestWebKitAPI/cocoa/TestWKWebView.h:
2040         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2041         (recursiveFindWKContentView):
2042         (-[TestWKWebView wkContentView]):
2043         * TestWebKitAPI/ios/UIKitSPI.h:
2044         Share the WKContentView finding code between tests.
2045
2046 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2047
2048         [iOS WK2] Turn on async overflow scrolling by default
2049         https://bugs.webkit.org/show_bug.cgi?id=196011
2050         rdar://problem/48453859
2051
2052         Reviewed by Antti Koivisto.
2053         
2054         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2055         since so many basic layout tests have different results when compositing is triggered for
2056         overflow.
2057         
2058         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2059
2060         * WebKitTestRunner/TestController.cpp:
2061         (WTR::TestController::resetPreferencesToConsistentValues):
2062
2063 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2064
2065         [ews-build] Retry API test in case of failures
2066         https://bugs.webkit.org/show_bug.cgi?id=196004
2067
2068         Reviewed by Lucas Forschler.
2069
2070         * BuildSlaveSupport/ews-build/steps.py:
2071         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2072         (CompileWebKitToT.doStepIf): Ditto.
2073         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2074         (ReRunAPITests): Re-run API tests.
2075         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2076         (RunAPITestsWithoutPatch): Run API tests without patch.
2077         (RunAPITestsWithoutPatch.doStepIf):
2078         (RunAPITestsWithoutPatch.hideStepIf):
2079         (RunAPITestsWithoutPatch.evaluateCommand):
2080         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2081         (AnalyzeAPITestsResults.start):
2082         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2083         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2084         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2085         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2086
2087 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2088
2089         [ews-build] Update queues configurations
2090         https://bugs.webkit.org/show_bug.cgi?id=196074
2091
2092         Reviewed by Dewei Zhu.
2093
2094         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2095         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2096
2097 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2098
2099         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2100         https://bugs.webkit.org/show_bug.cgi?id=195680
2101         <rdar://problem/48903534>
2102
2103         Unreviewed infrastructure fix.
2104
2105         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2106         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2107
2108 2019-03-21  Andy Estes  <aestes@apple.com>
2109
2110         [iOS] Apple Pay should be available in documents with no user agent scripts
2111         https://bugs.webkit.org/show_bug.cgi?id=196061
2112         <rdar://problem/48649391>
2113
2114         Reviewed by Brady Eidson.
2115
2116         Added API tests and related infrastructure.
2117
2118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2119         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2120         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2121         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2122         (TestWebKitAPI::TEST):
2123         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2124         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2125         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2126         * TestWebKitAPI/cocoa/TestProtocol.mm:
2127         (-[TestProtocol startLoading]):
2128         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2129         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2130         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2131         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2132
2133 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2134
2135         REGRESSSION (r243297): webkitpy tests broken
2136         https://bugs.webkit.org/show_bug.cgi?id=196108
2137
2138         Reviewed by Aakash Jain.
2139
2140         r243297 updated contributors.json, which broke a few unit tests.
2141
2142         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2143         (IRCCommandTest.test_whois):
2144         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2145
2146 2019-03-21  Chris Dumez  <cdumez@apple.com>
2147
2148         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2149         https://bugs.webkit.org/show_bug.cgi?id=196041
2150         <rdar://problem/49083230>
2151
2152         Reviewed by Alex Christensen.
2153
2154         Add API test coverage.
2155
2156         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2157         (TEST):
2158
2159 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2160
2161         Add SPI to inform applications of WKContentRuleList actions
2162         https://bugs.webkit.org/show_bug.cgi?id=195965
2163         <rdar://problem/42664365>
2164
2165         Reviewed by Geoff Garen.
2166
2167         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2168         (TestWebKitAPI::allActionsForResourceLoad):
2169         (TestWebKitAPI::testRequest):
2170         (TestWebKitAPI::TEST_F):
2171         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2172         (Notification::description):
2173         (Notification::operator== const):
2174         (toVector):
2175         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2176         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2177         (makeContentRuleList):
2178         (TEST):
2179         (makeWarnContentRuleList): Deleted.
2180
2181 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2182
2183         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2184         https://bugs.webkit.org/show_bug.cgi?id=196088
2185
2186         Reviewed by Brian Burg.
2187
2188         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2189         Support checks when only one platform is specified. Also deprecate macosx() and
2190         force the use of macos() instead.
2191
2192         * Scripts/webkitpy/style/checkers/cpp.py:
2193         (check_min_versions_of_wk_api_available):
2194         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2195         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2196
2197 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2198
2199         Update status inactive committers' status to 'contributor'.
2200
2201         * Scripts/webkitpy/common/config/contributors.json:
2202
2203 2019-03-21  Xan Lopez  <xan@igalia.com>
2204
2205         [JSC][x86] Drop support for x87 floating point
2206         https://bugs.webkit.org/show_bug.cgi?id=194853
2207
2208         Reviewed by Don Olmstead.
2209
2210         Force SSE2 on x86/32bit builds.
2211
2212         * Scripts/webkitdirs.pm:
2213         (generateBuildSystemFromCMakeProject):
2214
2215 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2216
2217         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2218         https://bugs.webkit.org/show_bug.cgi?id=196073
2219
2220         Reviewed by Michael Catanzaro.
2221
2222         Add test cases to check functions and constructors with no arguments but receiving user data.
2223
2224         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2225         (checkUserData):
2226         (testJSCFunction):
2227         (fooCreateWithUserData):
2228         (testJSCClass):
2229
2230 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2231
2232         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2233
2234         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2235
2236         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2237
2238 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2239
2240         [GTK][WPE] Add API to provide geolocation information
2241         https://bugs.webkit.org/show_bug.cgi?id=195940
2242
2243         Reviewed by Michael Catanzaro.
2244
2245         Add a new test to check the new API.
2246
2247         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2248         (testGeolocationManagerCurrentPosition):
2249         (testGeolocationManagerWatchPosition):
2250         (beforeAll):
2251         (afterAll):
2252         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2253         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2254         (beforeAll): Ditto.
2255         * TestWebKitAPI/glib/CMakeLists.txt:
2256
2257 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2258
2259         [GLib] Returning G_TYPE_OBJECT from a method does not work
2260         https://bugs.webkit.org/show_bug.cgi?id=195574
2261
2262         Reviewed by Michael Catanzaro.
2263
2264         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2265
2266         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2267         (getGFile):
2268         (getParent):
2269         (createGString):
2270         (getGString):
2271         (getGStringCopyWillRaise):
2272         (getGStringCopy):
2273         (getGStringStr):
2274         (getGStringLen):
2275         (freeGString):
2276         (testJSCClass):
2277
2278 2019-03-20  Saam Barati  <sbarati@apple.com>
2279
2280         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2281         https://bugs.webkit.org/show_bug.cgi?id=195721
2282
2283         Reviewed by Filip Pizlo.
2284
2285         * Scripts/run-javascriptcore-tests:
2286
2287 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2288
2289         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2290         https://bugs.webkit.org/show_bug.cgi?id=196049
2291
2292         Reviewed by Tim Horton.
2293
2294         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2295         overflow scrolling in general, so rename it.
2296
2297         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2298
2299 2019-03-20  Daniel Bates  <dabates@apple.com>
2300
2301         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2302         https://bugs.webkit.org/show_bug.cgi?id=196031
2303         <rdar://problem/49078172>
2304
2305         Reviewed by Tim Horton.
2306
2307         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2308         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2309         same code path used when the Done button is pressed to dismiss the <select> picker.
2310
2311         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2312         (TestWebKitAPI::TEST):
2313
2314 2019-03-20  Chris Dumez  <cdumez@apple.com>
2315
2316         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2317         https://bugs.webkit.org/show_bug.cgi?id=196029
2318         <rdar://problem/48954651>
2319
2320         Reviewed by Tim Horton.
2321
2322         Add API test coverage.
2323
2324         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2325
2326 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2327
2328         [ews-build] Improve failure summary string for ApplyPatch step
2329         https://bugs.webkit.org/show_bug.cgi?id=195995
2330
2331         Reviewed by Alexey Proskuryakov.
2332
2333         * BuildSlaveSupport/ews-build/steps.py:
2334         (ApplyPatch.getResultSummary): Override getResultSummary.
2335
2336 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2337
2338         AX: Implement support for new meter ARIA role
2339         https://bugs.webkit.org/show_bug.cgi?id=195966
2340
2341         Reviewed by Chris Fleizach.
2342
2343         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2344         to AXLevelIndicator.
2345
2346         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2347
2348 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2349
2350         [WebAuthN] Implement FIDO AppID extension
2351         https://bugs.webkit.org/show_bug.cgi?id=143491
2352         <rdar://problem/48298273>
2353
2354         Reviewed by Brent Fulgham.
2355
2356         Add a test that covers the new flag of convertToU2fSignCommand.
2357
2358         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2359         (TestWebKitAPI::TEST):
2360         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2361         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2362         (TestWebKitAPI::TEST):
2363
2364 2019-03-19  Keith Rollin  <krollin@apple.com>
2365
2366         Add support for more platforms to generate-xcfilelists
2367         https://bugs.webkit.org/show_bug.cgi?id=195977
2368
2369         Reviewed by Alexey Proskuryakov.
2370
2371         generate-xcfilelists incorrectly complains when involved with building
2372         WebKit for iphonesimulator:
2373
2374             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2375             …
2376             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2377
2378         Address this by teaching generate-xcfilelists about more platforms.
2379
2380         * Scripts/generate-xcfilelists:
2381
2382 2019-03-19  John Wilander  <wilander@apple.com>
2383
2384         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2385         https://bugs.webkit.org/show_bug.cgi?id=195923
2386         <rdar://problem/49001272>
2387
2388         Reviewed by Alex Christensen.
2389
2390         This patch does the following to the TestRunner:
2391         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2392         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2393         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2394
2395         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2396         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2397         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2398         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2399         * WebKitTestRunner/TestController.cpp:
2400         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2401         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2402         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2403         * WebKitTestRunner/TestController.h:
2404         * WebKitTestRunner/TestInvocation.cpp:
2405         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2406
2407 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2408
2409         [CMake] Support more clang and gcc sanitizers
2410         https://bugs.webkit.org/show_bug.cgi?id=195956
2411
2412         Reviewed by Michael Catanzaro.
2413
2414         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2415
2416 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2417
2418         [ews-build] Improve summary for PrintConfiguration step
2419         https://bugs.webkit.org/show_bug.cgi?id=195945
2420
2421         Reviewed by Lucas Forschler.
2422
2423         * BuildSlaveSupport/ews-build/steps.py:
2424         (PrintConfiguration.getResultSummary): Override getResultSummary.
2425
2426 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2427
2428         [ews-build] Improve summary for CheckOutSource step
2429         https://bugs.webkit.org/show_bug.cgi?id=195963
2430
2431         Reviewed by Lucas Forschler.
2432
2433         * BuildSlaveSupport/ews-build/steps.py:
2434         (CheckOutSource.getResultSummary):
2435
2436 2019-03-19  Daniel Bates  <dabates@apple.com>
2437
2438         [iOS] Focus not preserved when switching between tabs
2439         https://bugs.webkit.org/show_bug.cgi?id=195820
2440         <rdar://problem/43614450>
2441
2442         Reviewed by Brent Fulgham.
2443
2444         Add tests to ensure that we restore focus when resigning and becoming first responder.
2445
2446         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2447         (TestWebKitAPI::TEST):
2448
2449 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2450
2451         Make WTFLogChannelState and WTFLogLevel enum classes
2452         https://bugs.webkit.org/show_bug.cgi?id=195904
2453
2454         Reviewed by Eric Carlson.
2455
2456         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2457         (TestWebKitAPI::TEST_F):
2458
2459 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2460
2461         [GStreamer][EME] Backported mssdemux protection data crash fix
2462         https://bugs.webkit.org/show_bug.cgi?id=195918
2463
2464         Reviewed by Philippe Normand.
2465
2466         * gstreamer/jhbuild.modules:
2467         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2468
2469 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2470
2471         Unreviewed, rolling out r243132.
2472
2473         Broke GTK build
2474
2475         Reverted changeset:
2476
2477         "Make WTFLogChannelState and WTFLogLevel enum classes"
2478         https://bugs.webkit.org/show_bug.cgi?id=195904
2479         https://trac.webkit.org/changeset/243132
2480
2481 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2482
2483         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2484
2485         * Scripts/webkitdirs.pm:
2486         (builtDylibPathForName): Adjust the shared library name that's changed
2487         with the API version bump in r243073.
2488
2489 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2490
2491         Make WTFLogChannelState and WTFLogLevel enum classes
2492         https://bugs.webkit.org/show_bug.cgi?id=195904
2493
2494         Reviewed by Eric Carlson.
2495
2496         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2497         (TestWebKitAPI::TEST_F):
2498
2499 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2500
2501         Disable flaky test added in r2431100
2502         https://webkit.org/b/195785
2503
2504         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2505         (TestWebKitAPI::TEST):
2506         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2507
2508 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2509
2510         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2511         https://bugs.webkit.org/show_bug.cgi?id=195916
2512
2513         Reviewed by Tim Horton.
2514
2515         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2516         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2517
2518 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2519
2520         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2521
2522         * Scripts/webkitpy/common/config/contributors.json:
2523
2524 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2525
2526         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2527         https://bugs.webkit.org/show_bug.cgi?id=195785
2528
2529         Reviewed by Geoffrey Garen.
2530
2531         * TestWebKitAPI/TCPServer.cpp: Added.
2532         (TestWebKitAPI::TCPServer::TCPServer):
2533         (TestWebKitAPI::TCPServer::~TCPServer):
2534         (TestWebKitAPI::TCPServer::socketBindListen):
2535         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2536         * TestWebKitAPI/TCPServer.h: Added.
2537         (TestWebKitAPI::TCPServer::port const):
2538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2539         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2540         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2541         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2542         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2543         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2544         (TestWebKitAPI::respondSlowly):
2545         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2546         (TestWebKitAPI::downloadAtRate):
2547         (TestWebKitAPI::TEST):
2548
2549 2019-03-18  Saam Barati  <sbarati@apple.com>
2550
2551         Add a plan file for JetStream 2
2552         https://bugs.webkit.org/show_bug.cgi?id=190734
2553
2554         Reviewed by Mark Lam.
2555
2556         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2557
2558 2019-03-18  Chris Dumez  <cdumez@apple.com>
2559
2560         Delay WebProcess launch until a load is triggered in a Web view
2561         https://bugs.webkit.org/show_bug.cgi?id=195758
2562         <rdar://problem/48126013>
2563
2564         Reviewed by Geoff Garen.
2565
2566         Add API test coverage. Also update some existing API tests to not expect
2567         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2568
2569         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2570         (TestWebKitAPI::TEST):
2571         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2572         (TestWebKitAPI::TEST):
2573         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2574         (TEST):
2575         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2576         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2577         (TEST):
2578         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2579         (TEST):
2580         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2581
2582 2019-03-18  Xan Lopez  <xan@igalia.com>
2583
2584         [CMake] Prevent potential warning when determining $architecture
2585         https://bugs.webkit.org/show_bug.cgi?id=195891
2586
2587         Reviewed by Michael Catanzaro.
2588
2589         It's possible for generateBuildSystemForCMakeProject to be called
2590         before determineArchitecture() is ever called. This will make the
2591         first eq check with $architecture to be bogus (and print a
2592         warning). Change that to an eq check with architecture(), which
2593         implicitly calls determineArchitecture() if needed, and change all
2594         the other similar cases in the method in the same way to prevent
2595         future bugs like this one.
2596
2597         * Scripts/webkitdirs.pm:
2598         (generateBuildSystemFromCMakeProject):
2599
2600 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2601
2602         [WPE] Tarballs generated with “make dist” cannot build documentation
2603         https://bugs.webkit.org/show_bug.cgi?id=195885
2604
2605         Reviewed by Carlos Garcia Campos.
2606
2607         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2608
2609 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2610
2611         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2612         https://bugs.webkit.org/show_bug.cgi?id=195883
2613
2614         Reviewed by Carlos Garcia Campos.
2615
2616         * gtkdoc/gtkdoc.py:
2617         (GTKDoc._run_command): When commands fail to run, include the full command line for
2618         the program invocation and the output it has generated on the standard error stream.
2619
2620 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2621
2622         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2623         https://bugs.webkit.org/show_bug.cgi?id=195786
2624
2625         Reviewed by Philippe Normand.
2626
2627         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2628         * wpe/jhbuild.modules: Ditto.
2629
2630 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2631
2632         [ews-build] Don't run clean builds on EWS builders
2633         https://bugs.webkit.org/show_bug.cgi?id=195851
2634
2635         Reviewed by Geoffrey Garen.
2636
2637         * BuildSlaveSupport/ews-build/factories.py:
2638
2639 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2640
2641         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2642         https://bugs.webkit.org/show_bug.cgi?id=195849
2643
2644         Reviewed by Chris Dumez.
2645
2646         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2647
2648         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2649         (runWebsiteDataStoreCustomPaths):
2650
2651 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2652
2653         webkitpy: Upload test results
2654         https://bugs.webkit.org/show_bug.cgi?id=195755
2655         <rdar://problem/48896182>
2656
2657         Reviewed by Aakash Jain.
2658
2659         Establish a new format for uploading results that is not tied to layout tests, apply
2660         that format to webkitpy tests.
2661
2662         * Scripts/webkitpy/common/checkout/scm/git.py:
2663         (Git.native_branch): Return what branch the current checkout is on.
2664         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2665         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2666         * Scripts/webkitpy/common/checkout/scm/svn.py:
2667         (SVN.native_branch): Ditto.
2668         * Scripts/webkitpy/common/system/platforminfo.py:
2669         (PlatformInfo.build_version): Return a build version for Mac.
2670         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2671         (MockPlatformInfo.__init__):
2672         (MockPlatformInfo.build_version):
2673         * Scripts/webkitpy/results: Added.
2674         * Scripts/webkitpy/results/__init__.py: Added.
2675         * Scripts/webkitpy/results/options.py: Added.
2676         (upload_options): OptParse list for upload options.
2677         * Scripts/webkitpy/results/upload.py: Added.
2678         (Upload): Class which enforces the upload format expected by the results server.
2679         (Upload.Expectations):
2680         (Upload.create_configuration):
2681         (Upload.create_commit):
2682         (Upload.create_details):
2683         (Upload.create_run_stats):
2684         (Upload.create_test_result):
2685         (Upload.__init__):
2686         (Upload.Encoder): Encode Upload object as json.
2687         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2688         * Scripts/webkitpy/results/upload_unittest.py: Added.
2689         * Scripts/webkitpy/test/main.py:
2690         (Tester._parse_args): Add upload arguments.
2691         (Tester._run_tests): Allow results to be uploaded.
2692         * Scripts/webkitpy/test/runner.py:
2693         (Runner.__init__): Record which tests were run, rather than just counting them.
2694         (Runner.handle):
2695         * Scripts/webkitpy/test/runner_unittest.py:
2696         (RunnerTest.test_run):
2697         * Scripts/webkitpy/thirdparty/__init__.py:
2698         (AutoinstallImportHook.find_module): Add requests auto-install.
2699         (AutoinstallImportHook._install_requests):
2700         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2701         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2702
2703 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2704
2705         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2706         https://bugs.webkit.org/show_bug.cgi?id=195810
2707
2708         Reviewed by Tim Horton.
2709
2710         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2711         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2712         ending certain layout tests.
2713
2714         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2715         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2716         (-[TestRunnerWKWebView dealloc]):
2717         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2718
2719         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2720         helper method when destroying the web view, and when resetting state between tests.
2721
2722         * WebKitTestRunner/ios/TestControllerIOS.mm:
2723         (WTR::TestController::platformResetStateToConsistentValues):
2724
2725         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2726
2727 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2728
2729         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2730         https://bugs.webkit.org/show_bug.cgi?id=190350
2731         <rdar://problem/45089503>
2732
2733         Reviewed by Geoffrey Garen.
2734
2735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2736         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2737         (TEST):
2738         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2739         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2740         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2741         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2742         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2743         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2744         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2745         (runTest):
2746         (createDirectories):
2747         (TEST):
2748         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2749         (TEST):
2750         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2751         (TEST):
2752
2753 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2754
2755         Add support to WebPage for getting the contents as an attributed string.
2756         https://bugs.webkit.org/show_bug.cgi?id=195636
2757         rdar://problem/45055697
2758
2759         Reviewed by Tim Horton.
2760
2761         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2762         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2763
2764 2019-03-15  Chris Dumez  <cdumez@apple.com>
2765
2766         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2767         https://bugs.webkit.org/show_bug.cgi?id=195747
2768
2769         Reviewed by Geoff Garen.
2770
2771         Add API test coverage.
2772
2773         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2774
2775 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2776
2777         Unreviewed, rolling out r242952.
2778
2779         Causing API failures on iOS Simulator
2780
2781         Reverted changeset:
2782
2783         "[PSON] Make sure the WebProcessCache is leverage when
2784         relaunching a process after termination"
2785         https://bugs.webkit.org/show_bug.cgi?id=195747
2786         https://trac.webkit.org/changeset/242952
2787
2788 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2789
2790         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2791         https://bugs.webkit.org/show_bug.cgi?id=195740
2792
2793         Reviewed by Ross Kirsling.
2794
2795         window.open doesn't work for WebKitBrowserWindow because it is not
2796         implemented yet.
2797
2798         1. Implemented createNewPage callback of WKPageUIClient.
2799         2. Changed MainWindow to take a BrowserWindow factory function
2800           instead of BrowserWindowType to be flexible to create
2801           BrowserWindow with extra settings.
2802         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2803           because it is not relevant with MainWindow anymore.
2804
2805         * MiniBrowser/win/Common.cpp:
2806         (parseCommandLine):
2807         * MiniBrowser/win/Common.h:
2808         (CommandLineOptions::CommandLineOptions):
2809         * MiniBrowser/win/MainWindow.cpp:
2810         (MainWindow::MainWindow):
2811         (MainWindow::create):
2812         (MainWindow::init):
2813         (MainWindow::WndProc):
2814         * MiniBrowser/win/MainWindow.h:
2815         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2816         (PrintWebUIDelegate::createWebViewWithRequest):
2817         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2818         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2819         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2820         (WebKitBrowserWindow::updateProxySettings):
2821         (WebKitBrowserWindow::createNewPage):
2822         * MiniBrowser/win/WebKitBrowserWindow.h:
2823         * MiniBrowser/win/WinMain.cpp:
2824         (wWinMain):
2825
2826 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2827
2828         Make it possible to test scrolling tree layer manipulation more easily
2829         https://bugs.webkit.org/show_bug.cgi?id=195780
2830
2831         Reviewed by Tim Horton.
2832         
2833         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2834         cuts off communication of scrolling tree scrolls back to the web process
2835         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2836         allows tests to trigger scrolls which run the scrolling tree layer positioning
2837         logic, but never get another commit from the web process that might mask
2838         scrolling tree bugs.
2839         
2840         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2841         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2842         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2843
2844         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2845         (WTR::UIScriptController::scrollUpdatesDisabled const):
2846         (WTR::UIScriptController::setScrollUpdatesDisabled):
2847         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2848         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2849         (WTR::UIScriptController::scrollUpdatesDisabled const):
2850         (WTR::UIScriptController::setScrollUpdatesDisabled):
2851         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2852         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2853         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2854         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2855         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2856         * WebKitTestRunner/ios/TestControllerIOS.mm:
2857         (WTR::TestController::platformResetStateToConsistentValues):
2858         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2859         (WTR::UIScriptController::scrollUpdatesDisabled const):
2860         (WTR::UIScriptController::setScrollUpdatesDisabled):
2861
2862 2019-03-14  Youenn Fablet  <youenn@apple.com>
2863
2864         Move IDB storage in private browsing mode to NetworkProcess
2865         https://bugs.webkit.org/show_bug.cgi?id=195602
2866
2867         Reviewed by Brady Eidson.
2868
2869         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2870         (TEST):
2871
2872 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2873
2874         [ews-build] Make descriptionDone messages more readable
2875         https://bugs.webkit.org/show_bug.cgi?id=195760
2876
2877         Reviewed by Lucas Forschler.
2878
2879         * BuildSlaveSupport/ews-build/steps.py:
2880         * BuildSlaveSupport/ews-build/steps_unittest.py:
2881
2882 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2883
2884         [ews-build] Generate status-bubble hover-over messages
2885         https://bugs.webkit.org/show_bug.cgi?id=195680
2886
2887         Reviewed by Lucas Forschler.
2888
2889         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2890         (StatusBubble):
2891         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2892         on hover-over.
2893         (StatusBubble._iso_time):
2894         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2895         hover-over message.
2896         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2897
2898 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2899
2900         [ews-app] Gracefully handle the case when state_string is None
2901         https://bugs.webkit.org/show_bug.cgi?id=195753
2902
2903         Reviewed by Lucas Forschler.
2904
2905         * BuildSlaveSupport/ews-app/ews/models/build.py:
2906         * BuildSlaveSupport/ews-app/ews/models/step.py:
2907
2908 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2909
2910         [ews-app] Status bubble display pending for currently running build step
2911         https://bugs.webkit.org/show_bug.cgi?id=195744
2912
2913         Reviewed by Lucas Forschler.
2914
2915         * BuildSlaveSupport/ews-build/events.py:
2916         (Events.stepStarted): If state_string is pending, replace it with step name.
2917
2918 2019-03-14  Chris Dumez  <cdumez@apple.com>
2919
2920         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2921         https://bugs.webkit.org/show_bug.cgi?id=195750
2922
2923         Reviewed by Geoffrey Garen.
2924
2925         Add API test coverage.
2926
2927         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2928         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2929         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2930         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2931
2932 2019-03-14  Chris Dumez  <cdumez@apple.com>
2933
2934         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2935         https://bugs.webkit.org/show_bug.cgi?id=195747
2936
2937         Reviewed by Geoff Garen.
2938
2939         Add API test coverage.
2940
2941         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2942
2943 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2944
2945         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2946         https://bugs.webkit.org/show_bug.cgi?id=195725
2947         <rdar://problem/48545062>
2948
2949         Reviewed by Tim Horton.
2950
2951         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2952         handler is nil.
2953
2954         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2955         (TestWebKitAPI::TEST):
2956
2957 2019-03-13  Sam Weinig  <sam@webkit.org>
2958
2959         Add utility function to allow easy reverse range-based iteration of a container
2960         https://bugs.webkit.org/show_bug.cgi?id=195542
2961
2962         Reviewed by Antti Koivisto.
2963
2964         * TestWebKitAPI/CMakeLists.txt:
2965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2966         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2967         (TestWebKitAPI::TEST):
2968         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2969
2970 2019-03-13  Chris Dumez  <cdumez@apple.com>
2971
2972         Use a ServiceWorker process per registrable domain
2973         https://bugs.webkit.org/show_bug.cgi?id=195649
2974
2975         Reviewed by Youenn Fablet.
2976
2977         Update API test coverage.
2978
2979         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2980
2981 2019-03-13  Chris Dumez  <cdumez@apple.com>
2982
2983         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2984         https://bugs.webkit.org/show_bug.cgi?id=195684
2985         <rdar://problem/48294714>
2986
2987         Reviewed by Antti Koivisto.
2988
2989         Add API test coverage.
2990
2991         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2992
2993 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2994
2995         [ews-app] Remove unused patch view
2996         https://bugs.webkit.org/show_bug.cgi?id=195669
2997
2998         Reviewed by Lucas Forschler.
2999
3000         * BuildSlaveSupport/ews-app/ews/urls.py:
3001         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3002
3003 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3004
3005         [ews-app] Use Buildbot result code variables
3006         https://bugs.webkit.org/show_bug.cgi?id=195668
3007
3008         Reviewed by Alexey Proskuryakov.
3009
3010         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3011         (Buildbot): Added Buildbot result code variables.
3012         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3013         (StatusBubble._build_bubble): Used Buildbot result code variables.
3014
3015 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3016
3017         [Flatpak] Expand submodule recursively
3018         https://bugs.webkit.org/show_bug.cgi?id=195672
3019
3020         Building WPE with flatpak was impossible without that as it was raising an exception.
3021         Also update wpebackend-fdo to match what is built in jhbuild
3022
3023         Reviewed by Philippe Normand.
3024
3025         * flatpak/flatpakutils.py:
3026         (expand_submodules_recurse):
3027         (expand_manifest):
3028         * flatpak/org.webkit.WPEModules.yaml:
3029
3030 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3031
3032         [ews-app] status bubble should be hidden for certain builds
3033         https://bugs.webkit.org/show_bug.cgi?id=194597
3034
3035         Reviewed by Dewei Zhu.
3036
3037         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3038         (StatusBubble._build_bubble):
3039         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3040         because the patch didn't have relevant changes.
3041         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3042         in production yet.
3043
3044 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3045
3046         [Win] Fix a slew of simple clang-cl warnings.
3047         https://bugs.webkit.org/show_bug.cgi?id=195652
3048
3049         Reviewed by Don Olmstead.
3050
3051         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3052         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3053
3054 2019-03-12  Justin Fan  <justin_fan@apple.com>
3055
3056         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3057         https://bugs.webkit.org/show_bug.cgi?id=195518
3058         <rdar://problem/46322356>
3059
3060         Reviewed by Myles C. Maxfield.
3061
3062         * DumpRenderTree/DerivedSources-input.xcfilelist:
3063         * DumpRenderTree/DerivedSources-output.xcfilelist:
3064
3065 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3066
3067         Unreviewed, rolling out r242825.
3068         https://bugs.webkit.org/show_bug.cgi?id=195648
3069
3070         "Broke webkitpy tests with my change to
3071         lldb_dump_class_layout.py" (Requested by rmorisset on
3072         #webkit).
3073
3074         Reverted changeset:
3075
3076         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3077         classes with suspicious padding"
3078         https://bugs.webkit.org/show_bug.cgi?id=195573
3079         https://trac.webkit.org/changeset/242825
3080
3081 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3082
3083         [ews-build] Show status bubbles while the patch is waiting in queue
3084         https://bugs.webkit.org/show_bug.cgi?id=195618
3085
3086         Reviewed by Lucas Forschler.
3087
3088         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3089         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3090         enabled in initial deployment.
3091         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3092         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3093         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3094         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3095         (StatusBubble._build_bubbles_for_patch):
3096
3097 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3098
3099         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3100         https://bugs.webkit.org/show_bug.cgi?id=195573
3101
3102         Reviewed by Simon Fraser.
3103
3104         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3105
3106         * Scripts/dump-class-layout:
3107         (main):
3108         * lldb/lldb_dump_class_layout.py:
3109         (ClassLayout.__init__):
3110         (ClassLayout._compute_padding_recursive):
3111         (LLDBDebuggerInstance.dump_layout_for_classname):
3112         (LLDBDebuggerInstance):
3113         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3114         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3115
3116 2019-03-12  Chris Dumez  <cdumez@apple.com>
3117
3118         Device Orientation access permission should be denied unless explicitly granted by the client
3119         https://bugs.webkit.org/show_bug.cgi?id=195625
3120
3121         Reviewed by Youenn Fablet.
3122
3123         add API test coverage.
3124
3125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3126         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3127         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3128         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3129         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3130         (runDeviceOrientationTest):
3131         (TEST):
3132         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3133         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3134
3135 2019-03-12  Jer Noble  <jer.noble@apple.com>
3136
3137         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3138         https://bugs.webkit.org/show_bug.cgi?id=195137
3139         <rdar://problem/48810307>
3140
3141         Reviewed by Eric Carlson.
3142
3143         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3144         (TestWebKitAPI::TEST):
3145
3146 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3147
3148         [ews-build] Change urls from uat to production
3149         https://bugs.webkit.org/show_bug.cgi?id=195566
3150
3151         Reviewed by Lucas Forschler.
3152
3153         * BuildSlaveSupport/ews-app/ews/config.py:
3154         * BuildSlaveSupport/ews-build/events.py:
3155         * BuildSlaveSupport/ews-build/steps.py:
3156
3157 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3158
3159         [ews-build] change max_builds for local-worker to 1
3160         https://bugs.webkit.org/show_bug.cgi?id=195568
3161
3162         Reviewed by Lucas Forschler.
3163
3164         * BuildSlaveSupport/ews-build/loadConfig.py:
3165
3166 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3167
3168         Fix the build
3169
3170         * TestRunnerShared/spi/PencilKitTestSPI.h:
3171         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3172
3173 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3174
3175         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3176         https://bugs.webkit.org/show_bug.cgi?id=194131
3177
3178         Reviewed by Michael Catanzaro.
3179
3180         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3181         (uriChanged):
3182         (testUnfinishedSubresourceLoad):
3183         (serverCallback):
3184         (beforeAll):
3185
3186 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3187
3188         WTF::Expected should use std::addressof instead of operator&
3189         https://bugs.webkit.org/show_bug.cgi?id=195604
3190
3191         Reviewed by Myles Maxfield.
3192
3193         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3194         (TestWebKitAPI::Unique::Unique):
3195         (TestWebKitAPI::Unique::operator&):
3196         (TestWebKitAPI::TEST):
3197
3198 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3199
3200         Add Optional to Forward.h.
3201         https://bugs.webkit.org/show_bug.cgi?id=195586
3202
3203         Reviewed by Darin Adler.
3204
3205         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3206         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3207         Remove unnecessary includes from headers.
3208
3209 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3210
3211         Add testing API to hit-test and scroll overflow scrollers
3212         https://bugs.webkit.org/show_bug.cgi?id=195278
3213
3214         Reviewed by Antti Koivisto.
3215         
3216         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3217         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3218         
3219         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3220
3221         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3222         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3223         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3224         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3225         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3226         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3227         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3228         (WTR::enclosingScrollViewIncludingSelf):
3229         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3230
3231 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3232
3233         API test WebKit.RequestTextInputContext fails on iOS
3234         https://bugs.webkit.org/show_bug.cgi?id=195585
3235
3236         Reviewed by Wenson Hsieh and Simon Fraser.
3237
3238         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3239         (applyStyle):
3240         (TEST):
3241         Add a viewport, so that the coordinates match up on iOS.
3242         Scroll by moving the UIScrollView's contentOffset.
3243
3244 2019-03-11  Chris Dumez  <cdumez@apple.com>
3245
3246         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3247         https://bugs.webkit.org/show_bug.cgi?id=195506
3248         <rdar://problem/48733477>
3249
3250         Reviewed by Alex Christensen.
3251
3252         Add API test coverage.
3253
3254         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3255
3256 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3257
3258         Adding myself to contributors.json
3259
3260         Unreviewed, addming myself to contributors.json .
3261
3262         * Scripts/webkitpy/common/config/contributors.json:
3263
3264 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3265
3266         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3267         https://bugs.webkit.org/show_bug.cgi?id=195511
3268         <rdar://problem/44873269>
3269
3270         Reviewed by Darin Adler.
3271
3272         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3273         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3274         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3275         (TEST_F):
3276
3277 2019-03-11  Chris Dumez  <cdumez@apple.com>
3278
3279         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3280         https://bugs.webkit.org/show_bug.cgi?id=195561
3281
3282         Reviewed by Youenn Fablet.
3283
3284         Make sure the JS in the test requests for permission to receive device orientation events.
3285
3286         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3287
3288 2019-03-11  Youenn Fablet  <youenn@apple.com>
3289
3290         Allow storage quota increase by default in WTR
3291         https://bugs.webkit.org/show_bug.cgi?id=195541
3292
3293         Reviewed by Geoffrey Garen.
3294
3295         Allow storage quota increase by default in WTR.
3296         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3297         Use this for tests that explicitly need cache increase.
3298
3299         Instead of increasing quota by 2, make sure the next request is
3300         granted by adding all given parameters.
3301
3302         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3303         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3304         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3305         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3306         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3307         * WebKitTestRunner/TestController.cpp:
3308         (WTR::TestController::setAllowStorageQuotaIncrease):
3309         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3310         * WebKitTestRunner/TestController.h:
3311         * WebKitTestRunner/TestInvocation.cpp:
3312         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3313         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3314         (WTR::TestController::cocoaResetStateToConsistentValues):
3315         (WTR::TestController::setAllowStorageQuotaIncrease):
3316         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3317         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3318         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3319
3320 2019-03-11  Xan Lopez  <xan@igalia.com>
3321
3322         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3323         https://bugs.webkit.org/show_bug.cgi?id=194147
3324
3325         Reviewed by Michael Saboff.
3326
3327         To make --32-bit work correctly on Linux/64bit we need to:
3328
3329         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3330         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3331         unfortunately CMake only allows us to do this during
3332         crosscompilation, which is overkill here.
3333         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3334         pkg-config detection module uses the x86 .pc files instead of the
3335         x86_64 ones.
3336         - Set the -m32 flags for the compiler.
3337
3338         * Scripts/webkitdirs.pm:
3339         (generateBuildSystemFromCMakeProject):
3340
3341 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3342
3343         Add MotionMark-1.1 plan file for run-benchmark script.
3344         https://bugs.webkit.org/show_bug.cgi?id=195481
3345
3346         Rubber-stamped by Darin Adler.
3347
3348         Run-benchmark script should support MontionMark-1.1.
3349
3350         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3351
3352 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3353
3354         [ews-app] Add support for submit-to-ews url
3355         https://bugs.webkit.org/show_bug.cgi?id=195477
3356
3357         Reviewed by Lucas Forschler.
3358
3359         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3360         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3361         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3362         * BuildSlaveSupport/ews-app/ews/urls.py:
3363         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3364
3365 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3366
3367         Unreviewed, rolling out r242688, r242643, r242624.
3368
3369         Caused multiple layout test failures and crashes on iOS and macOS.
3370
3371         Reverted changeset:
3372
3373         "requestAnimationFrame should execute before the next frame"
3374         https://bugs.webkit.org/show_bug.cgi?id=177484
3375         https://trac.webkit.org/changeset/242624/webkit
3376
3377         * Tracing/SystemTracePoints.plist:
3378
3379 2019-03-11  John Wilander  <wilander@apple.com>
3380
3381         Resource Load Statistics: Make it possible exclude localhost from classification
3382         https://bugs.webkit.org/show_bug.cgi?id=195474
3383         <rdar://problem/47520577>
3384
3385         Reviewed by Brent Fulgham.
3386
3387         This patch allows for localhost to be excluded from classification and
3388         treatment as a prevalent resource.
3389
3390         The WebKit Tools change adds a new function called
3391         testRunner.setStatisticsIsRunningTest() which can be used to control this
3392         behavior.
3393
3394         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3395         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3396         (WTR::TestRunner::setStatisticsIsRunningTest):
3397         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3398         * WebKitTestRunner/TestController.cpp:
3399         (WTR::TestController::setStatisticsIsRunningTest):
3400         * WebKitTestRunner/TestController.h:
3401         * WebKitTestRunner/TestInvocation.cpp:
3402         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3403
3404 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3405
3406         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3407         https://bugs.webkit.org/show_bug.cgi?id=195560
3408
3409         Reviewed by Lucas Forschler.
3410
3411         * BuildSlaveSupport/ews-build/master.cfg:
3412
3413 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3414
3415         Unreviewed, rolling out r242698.
3416
3417         API test crashes on bots.
3418
3419         Reverted changeset:
3420
3421         "Add a WKContentRuleList variant that uses copied memory
3422         instead of mmap'd shared memory for class A containerized
3423         apps"
3424         https://bugs.webkit.org/show_bug.cgi?id=195511
3425         https://trac.webkit.org/changeset/242698
3426
3427 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3428
3429         [WPE] Enable web process sandbox
3430         https://bugs.webkit.org/show_bug.cgi?id=195169
3431
3432         Reviewed by Daniel Bates.
3433
3434         * wpe/install-dependencies:
3435         * wpe/jhbuild.modules:
3436
3437 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3438
3439         [ews-app] Use port 17000 for worker communication
3440         https://bugs.webkit.org/show_bug.cgi?id=195558
3441
3442         Reviewed by Lucas Forschler.
3443
3444         * BuildSlaveSupport/ews-build/master.cfg:
3445
3446 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3447
3448         [ews-build] unit-tests fail when passwords.json is missing
3449         https://bugs.webkit.org/show_bug.cgi?id=195557
3450
3451         Reviewed by Lucas Forschler.
3452
3453         * BuildSlaveSupport/ews-build/loadConfig.py:
3454         (loadBuilderConfig):
3455         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3456         (ConfigDotJSONTest.test_configuration):
3457         * BuildSlaveSupport/ews-build/master.cfg:
3458
3459 2019-03-11  Truitt Savell  <tsavell@apple.com>
3460
3461         Unreviewed, rolling out r242702.
3462
3463         Broke High Sierra builders.
3464
3465         Reverted changeset:
3466
3467         "Add utility function to allow easy reverse range-based
3468         iteration of a container"
3469         https://bugs.webkit.org/show_bug.cgi?id=195542
3470         https://trac.webkit.org/changeset/242702
3471
3472 2019-03-11  Sam Weinig  <sam@webkit.org>
3473
3474         Add utility function to allow easy reverse range-based iteration of a container
3475         https://bugs.webkit.org/show_bug.cgi?id=195542
3476
3477         Reviewed by Antti Koivisto.
3478
3479         * TestWebKitAPI/CMakeLists.txt:
3480         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3481         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3482         (TestWebKitAPI::TEST):
3483         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3484
3485 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3486
3487         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3488         https://bugs.webkit.org/show_bug.cgi?id=195511
3489         <rdar://problem/44873269>
3490
3491         Reviewed by Darin Adler.
3492
3493         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3494         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3495         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3496         (TEST_F):
3497
3498 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3499
3500         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3501         https://bugs.webkit.org/show_bug.cgi?id=195499
3502
3503         Reviewed by Darin Adler.
3504
3505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3506         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3507         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3508         (-[WKWebView synchronouslyFocusTextInputContext:]):
3509         (applyStyle):
3510         (applyIframe):
3511         (TEST):
3512         Add some tests for this SPI.
3513
3514 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3515
3516         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3517         https://bugs.webkit.org/show_bug.cgi?id=181151
3518
3519         Reviewed by Don Olmstead.
3520
3521         * TestWebKitAPI/CMakeLists.txt:
3522         * TestWebKitAPI/PlatformWin.cmake:
3523         Enable TestWTF RunLoop tests in all platforms.
3524
3525         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3526         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3527         (TestWebKitAPI::DerivedOneShotTimer::fired):
3528         (TestWebKitAPI::TEST):
3529         Only a few platforms support nested RunLoop.
3530
3531         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3532         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3533
3534 2019-03-10  David Quesada  <david_quesada@apple.com>
3535
3536         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3537         https://bugs.webkit.org/show_bug.cgi?id=152480
3538
3539         Reviewed by Chris Dumez.
3540
3541         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3542         there are no additional references to the process pool besides the one held by
3543         the download, waits for the download to finish (in the sense that the
3544         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3545         measure, also check that the process pool has been deallocated at the end of the
3546         test. The test wouldn't be meaningful if the process pool were still alive.
3547
3548         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3549         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3550         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3551             The download will be canceled because the delegate does not implement the
3552             method to decide the download's destination, so this is where we know the
3553             DownloadProxyMap is done with the DownloadProxy.
3554         (TEST):
3555
3556 2019-03-08  Chris Dumez  <cdumez@apple.com>
3557
3558         Add support for Device Orientation / Motion permission API
3559         https://bugs.webkit.org/show_bug.cgi?id=195329
3560         <rdar://problem/47645367>
3561
3562         Reviewed by Geoffrey Garen.
3563
3564         Add test infrastructure to help test the Device Orientation / Motion permission API.
3565
3566         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3567         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3568         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3569         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3570         * WebKitTestRunner/TestController.cpp:
3571         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3572         (WTR::TestController::createWebViewWithOptions):
3573         (WTR::TestController::resetStateToConsistentValues):
3574         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3575         * WebKitTestRunner/TestController.h:
3576         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3577         * WebKitTestRunner/TestInvocation.cpp:
3578         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3579
3580 2019-03-08  Saam barati  <sbarati@apple.com>
3581
3582         Add a compare-results script to compare benchmark results
3583         https://bugs.webkit.org/show_bug.cgi?id=195486
3584         <rdar://problem/48723397>
3585
3586         Reviewed by Geoffrey Garen.
3587
3588         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3589         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3590         to extend it to learn about our other benchmarks.
3591
3592         * Scripts/compare-results: Added.
3593         (readJSONFile):
3594         (detectJetStream2):
3595         (JetStream2Results):
3596         (detectSpeedometer2):
3597         (Speedometer2Results):
3598         (detectPLT5):
3599         (PLT5Results):
3600         (detectBenchmark):
3601         (biggerIsBetter):
3602         (ttest):
3603         (getOptions):
3604         (main):
3605
3606 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3607
3608         Ensure old tab state is cleared between iterations of run-benchmark
3609         https://bugs.webkit.org/show_bug.cgi?id=195393
3610         <rdar://problem/46885583>
3611
3612         Reviewed by Dewei Zhu.
3613
3614         a) ensure the default to restore state is not set
3615         b) terminate Safari correctly
3616         c) Set the system default to ignore Persistent State in Safari
3617
3618         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3619         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3620         (OSXBrowserDriver.prepare_env): 
3621         (OSXBrowserDriver.restore_env):
3622         (OSXBrowserDriver.close_browsers):
3623         (OSXBrowserDriver._terminate_processes):
3624         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3625         (OSXChromeDriver):
3626         (OSXChromeCanaryDriver):
3627         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3628         (OSXFirefoxDriver):
3629         (OSXFirefoxNightlyDriver):
3630         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3631         (OSXSafariDriver):
3632         (OSXSafariDriver.prepare_env):
3633
3634 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3635
3636         [GTK] Several InputMethodFilter tests are failing
3637         https://bugs.webkit.org/show_bug.cgi?id=195408
3638
3639         Reviewed by Carlos Garcia Campos.
3640
3641         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3642         Regressed in r241751.
3643         Hexadecimal values of keycodes are expressed now in upper letters.
3644         Composited characters should be cast to UTF8 strings.
3645
3646         (TestWebKitAPI::TEST):
3647
3648 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3649
3650         [GTK] Make Tools/gtkdoc python3 compatible
3651         https://bugs.webkit.org/show_bug.cgi?id=195359
3652
3653         Reviewed by Carlos Garcia Campos.
3654
3655         * gtkdoc/generate-gtkdoc:
3656         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3657         work with Python 2 and 3.
3658         (get_gtkdoc_module_paths):
3659         The iteritems() was removed in Python 3, so let's use items() that's
3660         available in Python 2 and 3.
3661         (get_generator_for_config):
3662         * gtkdoc/gtkdoc.py:
3663         (GTKDoc._run_command):
3664         The sys.stdout.write() is expecting str in Python 3 and not bytes
3665         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3666         for passing the bytes there.
3667
3668 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3669
3670         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3671         https://bugs.webkit.org/show_bug.cgi?id=195346
3672         <rdar://problem/48667048>
3673
3674         Unreviewed build fix for clang-cl.
3675
3676         * DumpRenderTree/win/DumpRenderTree.cpp:
3677         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3678
3679 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3680
3681         requestAnimationFrame should execute before the next frame
3682         https://bugs.webkit.org/show_bug.cgi?id=177484
3683
3684         Reviewed by Simon Fraser.
3685
3686         Add trace points for the page RenderingUpdate.
3687
3688         * Tracing/SystemTracePoints.plist:
3689
3690 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3691
3692         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3693         https://bugs.webkit.org/show_bug.cgi?id=195353
3694         <rdar://problem/48626394>
3695
3696         Reviewed by Simon Fraser.
3697
3698         * WebKitTestRunner/ios/TestControllerIOS.mm:
3699         (WTR::TestController::platformResetPreferencesToConsistentValues):
3700
3701 2019-03-07  John Wilander  <wilander@apple.com>
3702
3703         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3704         https://bugs.webkit.org/show_bug.cgi?id=195383
3705         <rdar://problem/48570136>
3706
3707         Reviewed by Brent Fulgham.
3708
3709         This patch adds test infrastructure to purge only script-accessible cookies,
3710         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3711
3712         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3713         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3714         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3715         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3716         * WebKitTestRunner/TestController.cpp:
3717         (WTR::TestController::statisticsDeleteCookiesForHost):
3718         * WebKitTestRunner/TestController.h:
3719         * WebKitTestRunner/TestInvocation.cpp:
3720         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3721
3722 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3723
3724         Unreviewed, rolling out r242354.
3725         https://bugs.webkit.org/show_bug.cgi?id=195402
3726
3727         breaks layout tests in all configurations (Requested by
3728         zdobersek on #webkit).
3729
3730         Reverted changeset:
3731
3732         "[WPE] Enable web process sandbox"
3733         https://bugs.webkit.org/show_bug.cgi?id=195169
3734         https://trac.webkit.org/changeset/242354
3735
3736 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3737
3738         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3739         https://bugs.webkit.org/show_bug.cgi?id=195346
3740
3741         Reviewed by Fujii Hironori.
3742
3743         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3744         (TestWebKitAPI::TEST):
3745         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3746
3747         * DumpRenderTree/win/DumpRenderTree.cpp:
3748         (findFontFallback):
3749         (addFontFallbackIfPresent):
3750         (removeFontFallbackIfPresent):
3751         (main):
3752         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3753         (TestWebKitAPI::Util::moduleDirectory):
3754         (TestWebKitAPI::Util::createInjectedBundlePath):
3755         Use wchar helpers as needed.
3756
3757 2019-03-06  Rob Buis  <rbuis@igalia.com>
3758
3759         Consider supporting the `referrerpolicy` attribute.
3760         https://bugs.webkit.org/show_bug.cgi?id=179053
3761
3762         Reviewed by Darin Adler.
3763
3764         Add a runtime flag for referrerpolicy attribute.
3765
3766         * DumpRenderTree/mac/DumpRenderTree.mm:
3767         (enableExperimentalFeatures):
3768
3769 2019-03-05  Daniel Bates  <dabates@apple.com>
3770
3771         Update expected API test result following r242379
3772         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3773
3774         Update expected x-coordinate of selection rect now that the left padding of
3775         a textarea is sized in ems (so dependent on the font size) just like the left
3776         padding of a text field.
3777
3778         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3779         (TestWebKitAPI::TEST):
3780
3781 2019-03-05  David Quesada  <david_quesada@apple.com>
3782
3783         [WK2] It should be possible to follow links with 'download' attributes
3784         https://bugs.webkit.org/show_bug.cgi?id=195145
3785         rdar://problem/48462642
3786
3787         Reviewed by Alex Christensen.
3788
3789         Add a unit test to verify that activating links with 'download' attributes now
3790         navigates to the linked resource, rather than starts downloading it. Add another
3791         to verify that it is still possible to explicitly download the link via the
3792         'Download' navigation action policy.
3793
3794         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3795         (-[DownloadAttributeTestDelegate init]):
3796         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3797         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3798         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3799         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3800         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3801         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3802         (TEST):
3803         * WebKitTestRunner/TestController.cpp:
3804         (WTR::TestController::decidePolicyForNavigationAction):
3805         * WebKitTestRunner/TestController.h:
3806
3807 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3808
3809         [Curl] Implement Cookie Accept Policy.
3810         https://bugs.webkit.org/show_bug.cgi?id=191645
3811
3812         Reviewed by Fujii Hironori.
3813
3814         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3815         (TestWebKitAPI::Curl::TEST_F):
3816
3817 2019-03-05  Youenn Fablet  <youenn@apple.com>
3818
3819         Rename requestCacheStorageSpace to requestStorageSpace
3820         https://bugs.webkit.org/show_bug.cgi?id=195282
3821
3822         Reviewed by Chris Dumez.
3823
3824         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3825         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3826         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3827
3828 2019-03-05  Brady Eidson  <beidson@apple.com>
3829
3830         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3831         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3832
3833         Reviewed by Tim Horton.
3834
3835         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3836         different directory into that same WKWebView should work.
3837
3838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3839         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3840
3841 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3842
3843         Add WeakHashSet
3844         https://bugs.webkit.org/show_bug.cgi?id=195152
3845
3846         Reviewed by Antti Koivisto.
3847
3848         Added tests for WeakHashSet.
3849
3850         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3851         (TestWebKitAPI::Base::Base): Moved.
3852         (TestWebKitAPI::Derived::foo): Moved.
3853         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3854         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3855         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3856         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3857
3858 2019-03-04  Chris Dumez  <cdumez@apple.com>
3859
3860         Do not share WebProcesses between private and regular sessions
3861         https://bugs.webkit.org/show_bug.cgi?id=195189
3862         <rdar://problem/48421064>
3863
3864         Reviewed by Alex Christensen.
3865
3866         Add API test coverage.
3867
3868         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3869         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3870
3871 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3872
3873         [WPE] Enable web process sandbox
3874         https://bugs.webkit.org/show_bug.cgi?id=195169
3875
3876         Reviewed by Daniel Bates.
3877
3878         * wpe/install-dependencies:
3879         * wpe/jhbuild.modules:
3880
3881 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3882
3883         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3884         https://bugs.webkit.org/show_bug.cgi?id=195206
3885
3886         Reviewed by Žan Doberšek.
3887
3888         Add a new test case.
3889
3890         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3891         (testJSCClass):
3892
3893 2019-03-04  Charlie Turner  <cturner@igalia.com>
3894
3895         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3896         https://bugs.webkit.org/show_bug.cgi?id=194898
3897
3898         Reviewed by Žan Doberšek.
3899
3900         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3901         a GCC extension that permits arithmetic on void* pointer. Inline
3902         the macro until this issue is fixed upstream.
3903
3904 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3905
3906         Rid the world of WK_API_ENABLED
3907         https://bugs.webkit.org/show_bug.cgi?id=195263
3908
3909         Reviewed by Dan Bernstein.
3910
3911         List of changed files elided because it's useless.
3912
3913 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3914
3915         Unreviewed follow-up to r242292.
3916
3917         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3918
3919         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3920         (TestWebKitAPI::testStrip): Renamed from strip.
3921         (TestWebKitAPI::TEST):
3922
3923 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3924
3925         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3926
3927         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3928         and bug #194272 for details.
3929
3930         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3931
3932 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3933
3934         Remove some more unused 32-bit code
3935         https://bugs.webkit.org/show_bug.cgi?id=195255
3936
3937         Reviewed by Darin Adler.
3938
3939         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3940         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3941         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3942         (NPP_New):
3943         (NPP_HandleEvent):
3944         (handleEventCarbon): Deleted.
3945
3946 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3947
3948         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3949
3950         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3951         (TestWebKitAPI::TEST):
3952
3953 2019-03-01  Darin Adler  <darin@apple.com>
3954
3955         Finish removing String::format
3956         https://bugs.webkit.org/show_bug.cgi?id=194893
3957
3958         Reviewed by Daniel Bates.
3959 '
3960         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3961
3962 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3963
3964         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3965         https://bugs.webkit.org/show_bug.cgi?id=195229
3966         <rdar://problem/48520362>
3967
3968         Reviewed by Chris Dumez.
3969
3970         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3971         (TEST):
3972
3973 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3974
3975         Add a system trace scope for event region building
3976         https://bugs.webkit.org/show_bug.cgi?id=195226
3977
3978         Reviewed by Jon Lee.
3979
3980         This trace scope measures the time spend converting element rects into Region objects,
3981         which can be large on some pages.
3982
3983         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3984
3985         * Tracing/SystemTracePoints.plist:
3986
3987 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3988
3989         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3990         https://bugs.webkit.org/show_bug.cgi?id=194612
3991
3992         Reviewed by Alex Christensen.
3993
3994         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3995         Just test the new string-processing function and don't touch the actual environment.
3996         (Test cases are all as before, but based on operator== instead of strcmp.)
3997
3998 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3999
4000         [ews-app] Update primary keys for handling multiple Buildbot instances
4001         https://bugs.webkit.org/show_bug.cgi?id=195120
4002
4003         Reviewed by Stephanie Lewis.
4004
4005         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4006         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4007         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4008
4009         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4010         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4011         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4012         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4013         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4014         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4015
4016 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4017
4018         [WinCairo] Enable service worker
4019         https://bugs.webkit.org/show_bug.cgi?id=188318
4020
4021         Reviewed by Youenn Fablet.
4022
4023         * DumpRenderTree/DumpRenderTreePrefix.h:
4024         * TestWebKitAPI/PlatformWin.cmake:
4025         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4026         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4027         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4028
4029 2019-03-01  Justin Fan  <justin_fan@apple.com>
4030
4031         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4032         https://bugs.webkit.org/show_bug.cgi?id=195191
4033
4034         Rubber-stamped by Dean Jackson.
4035
4036         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4037
4038         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4039
4040 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4041
4042         Unreviewed, fix lldb webkitpy tests
4043         https://bugs.webkit.org/show_bug.cgi?id=194375
4044
4045         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4046
4047         * lldb/lldb_webkit.py:
4048         (WTFStringImplProvider.is_8bit):
4049
4050 2019-02-28  David Quesada  <david_quesada@apple.com>
4051
4052         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4053         https://bugs.webkit.org/show_bug.cgi?id=195121
4054         rdar://problem/48450302
4055
4056         Reviewed by Alex Christensen.
4057
4058         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4059         configurations where the 'download' attribute is absent, blank, or populated
4060         with a filename, and where the anchor element is same-origin or cross-origin
4061         (meaning the 'download' attribute shouldn't be honored).
4062
4063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4064         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4065         (-[NavigationActionTestDelegate init]):
4066         (-[NavigationActionTestDelegate navigationAction]):
4067         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4068         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4069         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4070         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4071         (TEST):
4072
4073 2019-02-28  Antoine Quint  <graouts@apple.com>
4074
4075         Enable the Pointer Events runtime flag by default
4076         https://bugs.webkit.org/show_bug.cgi?id=195156
4077
4078         Reviewed by Dean Jackson.
4079
4080         * DumpRenderTree/mac/DumpRenderTree.mm:
4081         (enableExperimentalFeatures):
4082
4083 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4084
4085         Several PasteImage API tests are flaky
4086         https://bugs.webkit.org/show_bug.cgi?id=195160
4087
4088         Reviewed by Tim Horton.
4089
4090         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4091         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4092         listening for a "load" event after image load is already complete.
4093
4094         To address this, make these tests first register a "load" event handler, then run script to insert an image
4095         element into the document, and finally wait until the load event is observed before checking image size.
4096
4097         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4098
4099 2019-02-28  Chris Dumez  <cdumez@apple.com>
4100
4101         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4102         https://bugs.webkit.org/show_bug.cgi?id=195107
4103
4104         Reviewed by Alex Christensen.
4105
4106         Give some time for the zoom level to get restored.
4107
4108         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4109
4110 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4111
4112         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4113         https://bugs.webkit.org/show_bug.cgi?id=194958
4114
4115         Reviewed by Geoffrey Garen.
4116
4117         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4118         (TEST):
4119
4120 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4121
4122         [ews-app] Update method to save build to handle builder_display_name
4123         https://bugs.webkit.org/show_bug.cgi?id=195047
4124
4125         Reviewed by Dewei Zhu.
4126
4127         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4128         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4129
4130 2019-02-28  Justin Fan  <justin_fan@apple.com>
4131
4132         [Web GPU] Enable Web GPU only on 64-bit
4133         https://bugs.webkit.org/show_bug.cgi?id=195139
4134
4135         Because Metal is only supported on 64 bit apps.
4136
4137         Unreviewed build fix.
4138
4139         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4140
4141 2019-02-27  Youenn Fablet  <youenn@apple.com>
4142
4143         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4144         https://bugs.webkit.org/show_bug.cgi?id=194959
4145
4146         Reviewed by Chris Dumez.
4147
4148         Spin loop until getting the condition to remove flakiness.
4149
4150         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4151
4152 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4153
4154         [ews-build] Buildbot should include builder_display_name in the build events
4155         https://bugs.webkit.org/show_bug.cgi?id=195045
4156
4157         Reviewed by Dewei Zhu.
4158
4159         * BuildSlaveSupport/ews-build/events.py:
4160         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4161         buildername to builder_name to be consistent in naming style.
4162         (Events.buildFinished): Ditto.
4163
4164 2019-02-27  Chris Dumez  <cdumez@apple.com>
4165
4166         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4167         https://bugs.webkit.org/show_bug.cgi?id=194480
4168
4169         Reviewed by Brady Eidson.
4170
4171         Update existing API test to make it more likely to reproduce the issue.
4172
4173         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4174
4175 2019-02-27  Brady Eidson  <beidson@apple.com>
4176
4177         Universal links from Google search results pages don't open the app.
4178         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4179
4180         Reviewed by Geoffrey Garen.
4181
4182         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4183         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4184         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4185         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4186
4187 2019-02-27  Chris Dumez  <cdumez@apple.com>
4188
4189         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4190         https://bugs.webkit.org/show_bug.cgi?id=195102
4191
4192         Reviewed by Geoffrey Garen.
4193
4194         If the number of processes is not yet what we expect, wait a bit and check again to give
4195         processes some time to exit.
4196
4197         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4198
4199 2019-02-27  Chris Dumez  <cdumez@apple.com>
4200
4201         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4202         https://bugs.webkit.org/show_bug.cgi?id=194545
4203
4204         Reviewed by Brady Eidson.
4205
4206         Make sure the test navigates forward and then back only once. Previously, navigating
4207         back would trigger a navigation again in a timer.
4208
4209         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4210
4211 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4212
4213         High Sierra Debug JSC test queue should use faster hardware
4214         https://bugs.webkit.org/show_bug.cgi?id=194603
4215
4216         Rubber-stamped by Alexey Proskuryakov.
4217
4218         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4219
4220         * BuildSlaveSupport/build.webkit.org-config/config.json:
4221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4222         (BubbleQueueServer):
4223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4224         (WebKitBuildbot):
4225         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4226         * QueueStatusServer/config/queues.py:
4227         * Scripts/webkitpy/common/config/ews.json:
4228         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4229         (test_ews_name):
4230
4231 2019-02-27  John Wilander  <wilander@apple.com>
4232
4233         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4234         https://bugs.webkit.org/show_bug.cgi?id=195071
4235         <rdar://problem/48417690>
4236
4237         Reviewed by Alex Christensen and Brent Fulgham.
4238
4239         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4240         (TestWebKitAPI::createURL):
4241             Convenience function.
4242         (TestWebKitAPI::TEST):
4243             WebCore::AdClickAttribution now takes a URL when creating Source and
4244             Destination.
4245         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4246         (TestWebKitAPI::TEST):
4247             WebCore::AdClickAttribution now takes a URL when creating Source and
4248             Destination.
4249
4250 2019-02-27  Antoine Quint  <graouts@apple.com>
4251
4252         Support Pointer Events on macOS
4253         https://bugs.webkit.org/show_bug.cgi?id=195008
4254         <rdar://problem/47454419>
4255
4256         Reviewed by Dean Jackson.
4257
4258         * DumpRenderTree/mac/DumpRenderTree.mm:
4259         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4260         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4261
4262 2019-02-26  Mark Lam  <mark.lam@apple.com>
4263
4264         Remove remaining poisoning code.
4265         https://bugs.webkit.org/show_bug.cgi?id=194138
4266
4267         Reviewed by Saam Barati.
4268
4269         * TestWebKitAPI/CMakeLists.txt:
4270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4271         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4272         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4273         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4274         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4275         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4276         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4277
4278 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4279
4280         Move ephemeral local storage from WebProcess to UIProcess
4281         https://bugs.webkit.org/show_bug.cgi?id=195074
4282         <rdar://problem/47937975>
4283
4284         Reviewed by Geoff Garen.
4285
4286         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4287
4288 2019-02-20  Jer Noble  <jer.noble@apple.com>
4289
4290         [Cocoa] Media elements will restart network buffering just before suspending
4291         https://bugs.webkit.org/show_bug.cgi?id=193691
4292
4293         Reviewed by Eric Carlson.
4294
4295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4296         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4297         (TEST):
4298
4299 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4300
4301         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4302         https://bugs.webkit.org/show_bug.cgi?id=191652
4303
4304         Reviewed by Alex Christensen.
4305
4306         Fix WinCairo MiniBrowser behavior of authentication dialog.
4307
4308         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4309         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4310
4311 2019-02-26  Youenn Fablet  <youenn@apple.com>
4312
4313         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4314         https://bugs.webkit.org/show_bug.cgi?id=195028
4315         <rdar://problem/48243733>
4316
4317         Reviewed by Eric Carlson.
4318
4319         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4320
4321 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4322
4323         [WPE] Add API for webview background color configuration
4324         https://bugs.webkit.org/show_bug.cgi?id=192305
4325
4326         Reviewed by Michael Catanzaro.
4327
4328         * MiniBrowser/wpe/main.cpp:
4329         (main): Add a new option to configure the webview background
4330         color. Example: --bg-color=transparent.
4331         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4332         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4333         (beforeAll): Ditto.
4334
4335 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4336
4337         scalableNativeWebpageParameters() is not preserved on new page navigation.
4338         https://bugs.webkit.org/show_bug.cgi?id=194892
4339         <rdar://problem/47538280>
4340
4341         Reviewed by Wenson Hsieh.
4342         
4343         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4344
4345         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4346         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4347         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4348         (WTR::UIScriptController::allowsViewportShrinkToFit):
4349         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4350         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4351         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4352         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4353         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4354         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4355
4356 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4357
4358         [ews-app] Add model for handling multiple Buildbot instances
4359         https://bugs.webkit.org/show_bug.cgi?id=194863
4360
4361         Reviewed by Stephanie Lewis.
4362
4363         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4364
4365 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4366
4367         [ews-app] Remove BuilderMapping table
4368         https://bugs.webkit.org/show_bug.cgi?id=194961
4369
4370         Reviewed by Stephanie Lewis.
4371
4372         Store builder name directly in build table, instead of having a separate