[Win] run-api-tests is failing.
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-25  Per Arne Vollan  <pvollan@apple.com>
2
3         [Win] run-api-tests is failing.
4         https://bugs.webkit.org/show_bug.cgi?id=161140
5
6         Reviewed by Brent Fulgham.
7
8         Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
9
10         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
11         (TestWebKitAPI::TEST):
12
13 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
14
15         [Win] run-api-tests is failing.
16         https://bugs.webkit.org/show_bug.cgi?id=161140
17
18         Reviewed by Brent Fulgham.
19
20         The number of times the move constructor is called is different on Windows in this test. This seems
21         to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
22
23         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
24         (TestWebKitAPI::TEST):
25
26 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
27
28         Fix iOS DRT build.
29
30         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
31         (WTR::UIScriptController::zoomToScale):
32
33 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
34
35         [iOS DRT] Hook up uiController.zoomToScale() for DRT
36         https://bugs.webkit.org/show_bug.cgi?id=161173
37
38         Reviewed by Tim Horton.
39         
40         Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
41         UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
42         
43         UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
44         the WebThread!), but queue up the callback first.
45
46         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
47         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
48         (-[DumpRenderTreeWebScrollView initWithFrame:]):
49         (-[DumpRenderTreeWebScrollView dealloc]):
50         (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
51         (-[DumpRenderTreeWebScrollView completedZoomToScale]):
52         (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
53         (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
54         (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
55         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
56         (WTR::UIScriptController::zoomToScale):
57         * DumpRenderTree/mac/DumpRenderTree.mm:
58         (createWebViewAndOffscreenWindow):
59         * TestRunnerShared/UIScriptContext/UIScriptController.h:
60         (WTR::UIScriptController::context):
61
62 2016-08-24  Ryan Haddad  <ryanhaddad@apple.com>
63
64         Attempt to fix Windows build after r204918.
65
66         Unreviewed build fix.
67
68         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
69         (ResourceLoadDelegate::willSendRequest):
70
71 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
72
73         [iOS DRT] Get basic viewport tests working in DRT
74         https://bugs.webkit.org/show_bug.cgi?id=161160
75
76         Reviewed by Tim Horton.
77         
78         Hook up enough of UIScriptController in iOS DRT to be able to read viewport
79         scale, and get the contentVisibleRect.
80         
81         Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
82         requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
83         
84         One test has different results between DRT and WTR, but DRT behavior seems to differ
85         from UIWebView here, so just give it a WK1-specific result.
86
87         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
88         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
89         (-[DumpRenderTreeBrowserView documentVisibleRect]):
90         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
91         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
92         (WTR::UIScriptController::zoomScale):
93         (WTR::UIScriptController::minimumZoomScale):
94         (WTR::UIScriptController::maximumZoomScale):
95         (WTR::UIScriptController::contentVisibleRect):
96         * DumpRenderTree/mac/DumpRenderTree.mm:
97         (createWebViewAndOffscreenWindow):
98         * DumpRenderTree/mac/DumpRenderTreeMac.h:
99
100 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
101
102         Minor project rearrangement.
103
104         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
105
106 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
107
108         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
109         https://bugs.webkit.org/show_bug.cgi?id=161124
110
111         Reviewed by Daniel Bates.
112         
113         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
114         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
115         
116         Remove some unnecessary zero initializations of static variables.
117         
118         Change _setVisibleSize to use the window size, which should not be a behavior change
119         because this it just used for text autosizing, which is disabled by default,
120         and only the width is consulted.
121
122         * DumpRenderTree/mac/DumpRenderTree.mm:
123         (adjustWebDocumentForFlexibleViewport):
124         (adjustWebDocumentForStandardViewport):
125         (createWebViewAndOffscreenWindow):
126
127 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
128
129         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
130         https://bugs.webkit.org/show_bug.cgi?id=42777
131
132         Reviewed by Darin Adler.
133
134         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
135
136         * DumpRenderTree/TestRunner.cpp:
137         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
138         * DumpRenderTree/TestRunner.h:
139         (TestRunner::deferMainResourceDataLoad): Ditto.
140         (TestRunner::setDeferMainResourceDataLoad): Ditto.
141         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
142
143 2016-08-23  Anders Carlsson  <andersca@apple.com>
144
145         Add enum traits and use them in the IPC::Decoder
146         https://bugs.webkit.org/show_bug.cgi?id=161103
147
148         Reviewed by Sam Weinig.
149
150         Add API test.
151
152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
153         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
154         (TestWebKitAPI::TEST):
155
156 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
157
158         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
159
160         * DumpRenderTree/TestRunner.cpp:
161         * DumpRenderTree/mac/DumpRenderTree.mm:
162         (DumpRenderTreeMain):
163         * Scripts/run-jsc-stress-tests:
164         * TestWebKitAPI/Tests/WTF/Vector.cpp:
165         (TestWebKitAPI::TEST):
166
167 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
168
169         Try to fix Production builds.
170         
171         PRODUCTION_FRAMEWORKS_DIR was undefined here.
172
173         * DumpRenderTree/mac/Configurations/Base.xcconfig:
174
175 2016-08-24  Dan Bernstein  <mitz@apple.com>
176
177         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
178         https://bugs.webkit.org/show_bug.cgi?id=161152
179
180         Reviewed by Anders Carlsson.
181
182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
183         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
184         (TestWebKitAPI::didFinishLoadForFrame):
185         (TestWebKitAPI::TEST):
186
187 2016-08-24  Nan Wang  <n_wang@apple.com>
188
189         AX: Add test for line text marker range on iOS
190         https://bugs.webkit.org/show_bug.cgi?id=161108
191         <rdar://problem/27976405>
192
193         Reviewed by Chris Fleizach.
194
195         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
196         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
197         (AccessibilityUIElement::textMarkerRangeForElement):
198         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
199         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
200         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
201
202 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
203
204         [Win] Warning fixes.
205         https://bugs.webkit.org/show_bug.cgi?id=161079
206
207         Reviewed by Brent Fulgham.
208
209         * MiniBrowser/win/WebDownloadDelegate.cpp:
210         * MiniBrowser/win/WinMain.cpp:
211         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
212         (TestWebKitAPI::TEST):
213
214 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
215
216         Fix Windows DRT build.
217
218         * DumpRenderTree/win/TestRunnerWin.cpp:
219         (TestRunner::mainFrameJSContext):
220
221 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
222
223         Try to fix Windows build.
224         
225         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
226         so that perl finds CodeGeneratorDumpRenderTree.pm.
227
228         * DumpRenderTree/CMakeLists.txt:
229
230 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
231
232         Hook up UIScriptController in DumpRenderTree
233         https://bugs.webkit.org/show_bug.cgi?id=161064
234
235         Reviewed by Sam Weinig.
236
237         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
238         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
239         in fast/harness which test this.
240
241         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
242
243         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
244         WK2-isms. Fix the makefiles to refer to the new location.
245
246         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
247         by ID and firing them once they are complete.
248
249         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
250         * DumpRenderTree/CMakeLists.txt:
251         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
252         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
253         * DumpRenderTree/TestRunner.cpp:
254         (runUIScriptCallback):
255         (TestRunner::staticFunctions):
256         (TestRunner::cacheTestRunnerCallback):
257         (TestRunner::callTestRunnerCallback):
258         (TestRunner::clearTestRunnerCallbacks):
259         (nextUIScriptCallbackID):
260         (TestRunner::runUIScript):
261         (TestRunner::callUIScriptCallback):
262         (TestRunner::uiScriptDidComplete):
263         (TestRunner::cleanup):
264         * DumpRenderTree/TestRunner.h:
265         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
266         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
267         * DumpRenderTree/mac/DumpRenderTree.mm:
268         (runTest):
269         * DumpRenderTree/mac/TestRunnerMac.mm:
270         (TestRunner::mainFrameJSContext):
271         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
272         (WTR::UIScriptController::doAsyncTask):
273         * DumpRenderTree/win/DumpRenderTree.cpp:
274         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
275         (WTR::JSWrappable::~JSWrappable):
276         (WTR::JSValueMakeStringOrNull):
277         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
278         (WTR::JSWrapper::wrap):
279         (WTR::JSWrapper::unwrap):
280         (WTR::unwrapObject):
281         (WTR::JSWrapper::initialize):
282         (WTR::JSWrapper::finalize):
283         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
284         (WTR::toJS):
285         (WTR::setProperty):
286         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
287         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
288         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
289         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
290         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
291         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
292         * WebKitTestRunner/CMakeLists.txt:
293         * WebKitTestRunner/DerivedSources.make:
294         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
295         (WTR::JSWrappable::~JSWrappable): Deleted.
296         (WTR::JSValueMakeStringOrNull): Deleted.
297         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
298         (WTR::JSWrapper::wrap): Deleted.
299         (WTR::JSWrapper::unwrap): Deleted.
300         (WTR::unwrapObject): Deleted.
301         (WTR::JSWrapper::initialize): Deleted.
302         (WTR::JSWrapper::finalize): Deleted.
303         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
304         (WTR::toJS): Deleted.
305         (WTR::setProperty): Deleted.
306         * WebKitTestRunner/TestInvocation.cpp:
307         (WTR::TestInvocation::runUISideScript):
308         (WTR::TestInvocation::uiScriptDidComplete):
309         * WebKitTestRunner/TestInvocation.h:
310         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
311         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
312         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
313         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
314         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
315         * WebKitTestRunner/config.h:
316         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
317         (WTR::UIScriptController::contentVisibleRect):
318
319 2016-08-23  Saam Barati  <sbarati@apple.com>
320
321         JSC should have a "microbenchmarks" directory instead of "regress" directory
322         https://bugs.webkit.org/show_bug.cgi?id=161096
323
324         Rubber stamped by Mark Lam.
325
326         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
327         directory and removes all the related html and txt files. I did this because
328         that directory was only there for microbenchmarks, and not for "regression"
329         tests. I also changed the various scripts to point to it.
330
331         * Scripts/run-javascriptcore-tests:
332         (runJSCStressTests):
333         * Scripts/run-jsc-benchmarks:
334
335 2016-08-23  Alex Christensen  <achristensen@webkit.org>
336
337         Fix EFL build.
338
339         * TestWebKitAPI/CMakeLists.txt:
340         Include new directory.
341
342 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
343
344         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
345         https://bugs.webkit.org/show_bug.cgi?id=160125
346
347         Reviewed by Geoffrey Garen.
348
349         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
350         * Scripts/run-jsc-stress-tests: New test flag!
351
352 2016-08-23  Brady Eidson  <beidson@apple.com>
353
354         WK2 Gamepad layout test support.
355         https://bugs.webkit.org/show_bug.cgi?id=134671
356
357         Reviewed by Alex Christensen.
358         
359         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
360         feed back into the UIGamepadProvider.
361         
362         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
363         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
364
365         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
366         
367         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
368         (WTR::TestRunner::setMockGamepadDetails):
369         (WTR::TestRunner::setMockGamepadAxisValue):
370         (WTR::TestRunner::setMockGamepadButtonValue):
371         
372         * WebKitTestRunner/PlatformWebView.h:
373         
374         * WebKitTestRunner/TestController.cpp:
375         (WTR::TestController::initialize):
376         
377         * WebKitTestRunner/TestInvocation.cpp:
378         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
379         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
380         
381         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
382         
383         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
384         (-[WebKitTestRunnerWindow initWithFrame:]):
385         (-[WebKitTestRunnerWindow dealloc]):
386         (WTR::PlatformWebView::keyWindow):
387         
388         * WebKitTestRunner/ios/TestControllerIOS.mm:
389         (WTR::wtr_NSApplication_keyWindow):
390         (WTR::TestController::platformInitialize):
391         
392         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
393         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
394         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
395         (-[WebKitTestRunnerWindow dealloc]):
396         (WTR::PlatformWebView::keyWindow):
397         
398         * WebKitTestRunner/mac/TestControllerMac.mm:
399         (WTR::wtr_NSApplication_keyWindow):
400         (WTR::TestController::platformInitialize):
401         * WebKitTestRunner/mac/main.mm:
402
403 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
404
405         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
406         https://bugs.webkit.org/show_bug.cgi?id=161047
407         rdar://problem/27434307
408
409         Reviewed by Lucas Forschler.
410
411         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
412
413 2016-08-23  Chris Dumez  <cdumez@apple.com>
414
415         Unreviewed, rolling out r204243.
416
417         Caused some layout test failures
418
419         Reverted changeset:
420
421         "Write API test to cover crash fix in r204135"
422         https://bugs.webkit.org/show_bug.cgi?id=160587
423         http://trac.webkit.org/changeset/204243
424
425 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
426
427         Order feature option list in FeatureList.pm
428         https://bugs.webkit.org/show_bug.cgi?id=161074
429
430         Reviewed by Michael Catanzaro.
431
432         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
433
434         * Scripts/webkitperl/FeatureList.pm:
435
436 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
437
438         Stop python icon bouncing in the dock while running browser benchmarks.
439         https://bugs.webkit.org/show_bug.cgi?id=161066
440
441         Reviewed by Ryosuke Niwa.
442
443         Bouncing python icon may impact browser benchmark results.
444         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
445         (OSXBrowserDriver.prepare_env):
446         (OSXBrowserDriver.restore_env):
447
448 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
449
450         <select> menu on iPad causes shifting of hit-testing areas
451         https://bugs.webkit.org/show_bug.cgi?id=150079
452
453         Reviewed by Tim Horton.
454
455         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
456         so when it changes we have to update visible rects. We were doing this on focus, but failing
457         to do it on blur.
458
459         Added the ability to test by:
460         1. Making it possible to initiate an animated scroll in the UI process
461         2. Adding callbacks for starting and ending interaction with a form control. Sadly
462         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
463         have no way currently to know when the dimming view behind the popover animates out,
464         so for now the test keeps trying to tap a button.
465
466         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
467         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
468         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
469         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
470         (WTR::UIScriptController::didStartFormControlInteractionCallback):
471         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
472         (WTR::UIScriptController::didEndFormControlInteractionCallback):
473         (WTR::UIScriptController::scrollToOffset):
474         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
475         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
476         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
477         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
478         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
479         (-[TestRunnerWKWebView dealloc]):
480         (-[TestRunnerWKWebView didStartFormControlInteraction]):
481         (-[TestRunnerWKWebView didEndFormControlInteraction]):
482         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
483         (WTR::contentOffsetBoundedInValidRange):
484         (WTR::UIScriptController::scrollToOffset):
485         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
486         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
487
488 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
489
490         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
491         https://bugs.webkit.org/show_bug.cgi?id=160927
492
493         Reviewed by Daniel Bates.
494
495         * Scripts/process-linux-coredump: Removed.
496         * Scripts/webkitpy/port/efl.py:
497         (EflPort._get_crash_log):
498         * Scripts/webkitpy/port/gtk.py:
499         (GtkPort._get_crash_log):
500         * Scripts/webkitpy/port/linux_get_crash_log.py:
501         (GDBCrashLogGenerator.__init__):
502         (GDBCrashLogGenerator.generate_crash_log):
503         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
504         (GDBCrashLogGeneratorTest.test_generate_crash_log):
505
506 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
507
508         check-webkit-style does not work with Lambda functions in C++
509         https://bugs.webkit.org/show_bug.cgi?id=160910
510
511         Reviewed by Darin Adler.
512
513         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
514
515         * Scripts/webkitpy/style/checkers/cpp.py:
516         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
517         (check_for_non_standard_constructs): Added lambda function check.
518         (check_spacing_for_function_call): Added lambda function check.
519         (check_braces): Added lambda function check.
520         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
521         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
522
523 2016-08-21  Alex Christensen  <achristensen@webkit.org>
524
525         URLParser should parse IPv4 addresses
526         https://bugs.webkit.org/show_bug.cgi?id=161023
527
528         Reviewed by Darin Adler.
529
530         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
531         (TestWebKitAPI::TEST_F):
532         (TestWebKitAPI::checkURLDifferences):
533         We are already getting differences between the old URL::parse and the new URLParser.
534         (TestWebKitAPI::shouldFail):
535
536 2016-08-21  Daniel Bates  <dabates@apple.com>
537
538         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
539         https://bugs.webkit.org/show_bug.cgi?id=148437
540
541         Reviewed by Dan Bernstein.
542
543         * Scripts/prepare-ChangeLog:
544         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
545         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
546         assumes that its line ranges were from a unified diff without any context lines.
547         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
548         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
549         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
550         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
551         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
552         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
553         to /dev/null for the duration of the function call.
554
555 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
556
557         [EFL] Remove unnecessary a patch to mute ecore warnings
558         https://bugs.webkit.org/show_bug.cgi?id=160997
559
560         Reviewed by Darin Adler.
561
562         There is no warning messages during the layout test and perf test
563         after bumping efl version from 1.17 to 1.18. Remove it.
564
565         * efl/patches/ecore_remove_warnings.patch: Removed.
566
567 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
568
569         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
570         https://bugs.webkit.org/show_bug.cgi?id=160985
571
572         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
573         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
574         with that.
575
576         * Scripts/webkitpy/layout_tests/views/printing.py:
577         (Printer.print_config):
578         * Scripts/webkitpy/port/base.py:
579         (Port.driver_cmd_line_for_logging):
580         (Port.driver_cmd_line): Deleted.
581         * Scripts/webkitpy/port/driver.py:
582         (IOSSimulatorDriver.cmd_line):
583         * Scripts/webkitpy/port/ios.py:
584         (IOSSimulatorPort.__init__):
585         (IOSSimulatorPort.driver_cmd_line_for_logging):
586         (IOSSimulatorPort._create_simulators):
587         (IOSSimulatorPort.setup_test_run):
588         (IOSSimulatorPort._quit_ios_simulator):
589         (IOSSimulatorPort.clean_up_test_run):
590         (IOSSimulatorPort._create_device):
591         (IOSSimulatorPort):
592         (IOSSimulatorPort._remove_device):
593         (IOSSimulatorPort._testing_device):
594         (IOSSimulatorPort.device_id_for_worker_number):
595         (IOSSimulatorPort._set_device_class): Deleted.
596         (IOSSimulatorPort.testing_device): Deleted.
597         * Scripts/webkitpy/port/port_testcase.py:
598         (PortTestCase.test_driver_cmd_line):
599         * Scripts/webkitpy/xcode/simulator.py:
600         (Device.shutdown):
601         (Device):
602         (Device.delete):
603         (Device.reset):
604         (Simulator):
605         (Simulator.create_device):
606         (Simulator.remove_device):
607         (Simulator.device_number):
608         (Simulator.device_state_description):
609         (Simulator.wait_until_device_is_in_state):
610
611 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
612
613         Unreviewed, rolling out r204659.
614
615         This change appears to have caused ios-simulator LayoutTests
616         to fail when shutting down the simulator
617
618         Reverted changeset:
619
620         "REGRESSION (r204477): Running LayoutTests on ios-simulator
621         became ~15 minutes slower"
622         https://bugs.webkit.org/show_bug.cgi?id=160985
623         http://trac.webkit.org/changeset/204659
624
625 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
626
627         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
628         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
629
630 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
631
632         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
633         https://bugs.webkit.org/show_bug.cgi?id=160985
634
635         Reviewed by Alexey Proskuryakov.
636         
637         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
638         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
639         must not be @memoized, because their return value depends on the value of simulator_device_type().
640         
641         Fix by adding some global state in simulator.py that tracks the created devices 
642         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
643         and delete them in clean_up_test_run().
644         
645         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
646         that killing the Simulator apps isn't enough.
647         
648         Simulator tracks the devices in a global dictionary, since state needs to persist
649         across different instances of IOSSimulatorPort.
650         
651         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
652         any setup. Rather than implicitly creating a device here (which the old code did),
653         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
654         and set flag to say that device_id_for_worker_number() doesn't need to return a real
655         device id.
656
657         * Scripts/webkitpy/layout_tests/views/printing.py:
658         (print_options):
659         (Printer.print_config):
660         * Scripts/webkitpy/port/base.py:
661         (Port.driver_cmd_line_for_logging):
662         (Port.driver_cmd_line): Deleted.
663         * Scripts/webkitpy/port/driver.py:
664         (IOSSimulatorDriver.cmd_line):
665         * Scripts/webkitpy/port/ios.py:
666         (IOSSimulatorPort.__init__):
667         (IOSSimulatorPort.driver_cmd_line_for_logging):
668         (IOSSimulatorPort._create_simulators):
669         (IOSSimulatorPort.setup_test_run):
670         (IOSSimulatorPort.clean_up_test_run):
671         (IOSSimulatorPort._create_device):
672         (IOSSimulatorPort):
673         (IOSSimulatorPort._remove_device):
674         (IOSSimulatorPort._testing_device):
675         (IOSSimulatorPort.device_id_for_worker_number):
676         (IOSSimulatorPort._set_device_class): Deleted.
677         (IOSSimulatorPort.testing_device): Deleted.
678         * Scripts/webkitpy/port/port_testcase.py:
679         (PortTestCase.test_driver_cmd_line):
680         * Scripts/webkitpy/xcode/simulator.py:
681         (Device.shutdown):
682         (Device.delete):
683         (Device.reset):
684         (Simulator.create_device):
685         (Simulator.remove_device):
686         (Simulator.device_number):
687         (Simulator.device_state_description):
688         (Simulator.wait_until_device_is_in_state):
689
690 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
691
692         Adopt SimServiceContext in LayoutTestRelay
693         https://bugs.webkit.org/show_bug.cgi?id=161000
694         <rdar://problem/25765594>
695
696         Reviewed by Daniel Bates.
697
698         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
699         * LayoutTestRelay/LayoutTestRelay/main.m:
700
701 2016-08-19  Lucas Forschler  <lforschler@apple.com>
702
703         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
704
705         Reviewed by Kocsen Chung.
706
707         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
708         (WebKitBuildbot):
709
710 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
711
712         Partial revert of r203811 - this key is not needed.
713
714         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
715
716 2016-08-19  Daniel Bates  <dabates@apple.com>
717
718         Another attempt to fix the iOS 9.3 build
719
720         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
721
722         * DumpRenderTree/mac/Configurations/Base.xcconfig:
723         * WebKitTestRunner/Configurations/Base.xcconfig:
724
725 2016-08-19  Lucas Forschler  <lforschler@apple.com>
726
727         Remove Yosemite Leaks bot from config.json
728         
729         Reviewed by Alexey Proskuryakov.
730
731         * BuildSlaveSupport/build.webkit.org-config/config.json:
732
733 2016-08-18  Dan Bernstein  <mitz@apple.com>
734
735         [Cocoa] API::Number needs to be wrapped by an NSNumber
736         https://bugs.webkit.org/show_bug.cgi?id=160977
737         <rdar://problem/27877735>
738
739         Reviewed by Anders Carlsson.
740
741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
742         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
743         (TestWebKitAPI::TEST):
744
745 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
746
747         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
748         https://bugs.webkit.org/show_bug.cgi?id=160895
749
750         Reviewed by Dean Jackson.
751
752         Link to the existing CoreText framework.
753
754         * DumpRenderTree/PlatformWin.cmake:
755         * TestWebKitAPI/PlatformWin.cmake:
756
757 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
758
759         [Win] Remove old libraries from build inputs
760         https://bugs.webkit.org/show_bug.cgi?id=160949
761
762         Reviewed by Dean Jackson.
763
764         Modify the download script to remove the old 'icuuc.lib' and
765         'icuin.lib' files for Windows builds.
766
767         * Scripts/update-webkit-auxiliary-libs:
768
769 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
770
771         Extra logging for crash reason
772         https://bugs.webkit.org/show_bug.cgi?id=160943
773
774         Reviewed by Alexey Proskuryakov.
775
776         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
777
778         * Scripts/webkitpy/port/server_process.py:
779         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
780         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
781         (ServerProcess.has_crashed): Ditto.
782
783 2016-08-17  Dan Bernstein  <mitz@apple.com>
784
785         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
786         https://bugs.webkit.org/show_bug.cgi?id=160938
787         <rdar://problem/27876652>
788
789         Reviewed by Anders Carlsson.
790
791         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
792         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
793         (TestWebKitAPI::TEST):
794
795 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
796
797         AX: Support abbreviations in iOS
798         https://bugs.webkit.org/show_bug.cgi?id=160907
799
800         Reviewed by Joanmarie Diggs.
801
802         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
803         (AccessibilityUIElement::stringAttributeValue):
804         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
805         (WTR::AccessibilityUIElement::stringAttributeValue):
806
807 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
808
809         [EFL] Bump efl version from 1.17 to 1.18
810         https://bugs.webkit.org/show_bug.cgi?id=160899
811
812         Reviewed by Antonio Gomes.
813
814         To use efl-1.18, EFL port needs to update install dependencies as well.
815
816         * efl/install-dependencies:
817         * efl/jhbuild.modules:
818
819 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
820
821         [Win] Add tests for linked fonts.
822         https://bugs.webkit.org/show_bug.cgi?id=160898
823
824         Reviewed by Brent Fulgham.
825
826         Add tests for https://trac.webkit.org/changeset/204502.
827
828         * TestWebKitAPI/PlatformWin.cmake:
829         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
830         (TestWebKitAPI::TEST):
831
832 2016-08-16  Daniel Bates  <dabates@apple.com>
833
834         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
835         https://bugs.webkit.org/show_bug.cgi?id=160924
836
837         Reviewed by Stephanie Lewis.
838
839         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
840         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
841         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
842         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
843         object that mocks out the file system and SCM operations.
844
845         * Scripts/VCSUtils.pm:
846         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
847         * Scripts/prepare-ChangeLog:
848         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
849         abstracting the logic to query the file system and SCM into functions on a delegate object that
850         we pass to it.
851         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
852         (diffHeaderFormat): Deleted.
853
854 2016-08-16  Alex Christensen  <achristensen@webkit.org>
855
856         URLParser should parse URLs without credentials
857         https://bugs.webkit.org/show_bug.cgi?id=160913
858
859         Reviewed by Brady Eidson.
860
861         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
862         (TestWebKitAPI::s):
863         (TestWebKitAPI::checkURL):
864         (TestWebKitAPI::TEST_F):
865
866 2016-08-16  Anders Carlsson  <andersca@apple.com>
867
868         Add WTF::ScopeExit
869         https://bugs.webkit.org/show_bug.cgi?id=160908
870
871         Reviewed by Geoffrey Garen.
872
873         * TestWebKitAPI/CMakeLists.txt:
874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
875         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
876         (TestWebKitAPI::TEST):
877
878 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
879
880         EWS logs file are rotated too quickly
881         https://bugs.webkit.org/show_bug.cgi?id=160724
882
883         Reviewed by Daniel Bates.
884
885         Currently we are rotating the log file after 10 iterations of queue. If the queue
886         doesn't have any pending patches, these iterations result in very small amount of 
887         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
888         This results in a lot of log files in a day. This patch ensures that we rotate the
889         log file when its file size is greater than or equal to 100 KB.
890
891         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
892
893 2016-08-16  Daniel Bates  <dabates@apple.com>
894
895         WKSI static library should be named by major iOS revision, not individual updates
896         https://bugs.webkit.org/show_bug.cgi?id=160727
897         <rdar://problem/22274848>
898
899         Reviewed by Alexey Proskuryakov.
900
901         * DumpRenderTree/mac/Configurations/Base.xcconfig:
902         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
903         * Scripts/copy-webkitlibraries-to-product-directory:
904         * WebKitTestRunner/Configurations/Base.xcconfig:
905         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
906
907 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
908
909         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
910         https://bugs.webkit.org/show_bug.cgi?id=160909
911
912         Reviewed by Enrica Casucci.
913         
914         Add functions to UIScriptController to dismiss the form accessory view for iOS,
915         and to programmatically pick a row from a <select> picker.
916
917         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
918         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
919         (WTR::UIScriptController::dismissFormAccessoryView):
920         (WTR::UIScriptController::selectFormAccessoryPickerRow):
921         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
922         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
923         (WTR::UIScriptController::dismissFormAccessoryView):
924         (WTR::UIScriptController::selectFormAccessoryPickerRow):
925
926 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
927
928         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
929         https://bugs.webkit.org/show_bug.cgi?id=160878
930
931         Reviewed by Tim Horton.
932         
933         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
934         now that we have the ability to run tests in the iPad simulator.
935
936         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
937         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
938         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
939         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
940         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
941         * WebKitTestRunner/ios/TestControllerIOS.mm:
942         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
943         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
944         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
945         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
946
947 2016-08-15  Anders Carlsson  <andersca@apple.com>
948
949         Add an address-of operator to RetainPtr
950         https://bugs.webkit.org/show_bug.cgi?id=160879
951
952         Reviewed by Tim Horton.
953
954         Test HashMap and HashSet with an object whose operator& is deleted.
955
956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
957         Sort the Xcode project.
958
959         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
960         (DeletedAddressOfOperator::DeletedAddressOfOperator):
961         (DeletedAddressOfOperator::value):
962         (DeletedAddressOfOperator::operator==):
963         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
964         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
965         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
966         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
967         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
968         (TestWebKitAPI::TEST):
969         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
970         (TestWebKitAPI::TEST):
971
972 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
973
974         False crashes in fast/text/emoji-gender-* tests
975         https://bugs.webkit.org/show_bug.cgi?id=160779
976
977         Reviewed by Alexey Proskuryakov.
978
979         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
980
981         * Scripts/webkitpy/port/driver.py:
982         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
983         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
984         * Scripts/webkitpy/port/server_process.py:
985         (ServerProcess.write): Allow caller to disable crash flag on exception.
986
987 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
988
989         webkitpy error in TestRunResults.merge()
990         https://bugs.webkit.org/show_bug.cgi?id=160882
991
992         Reviewed by Daniel Bates.
993         
994         The argument to TestRunResults.merge() can be None if there are no device-specifc
995         initial results or retry results in Manager.run(), so just return early in that case.
996
997         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
998         (TestRunResults.merge):
999
1000 2016-08-15  Sam Weinig  <sam@webkit.org>
1001
1002         Speed up compile times by not including wtf/Variant.h so much
1003         https://bugs.webkit.org/show_bug.cgi?id=160847
1004
1005         Reviewed by Alex Christensen and Saam Barati.
1006
1007         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1008         (TestWebKitAPI::TEST):
1009         Explicitly use std::experimental::variant.
1010
1011 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1012
1013         Allow a port to run tests with a custom device setup
1014         https://bugs.webkit.org/show_bug.cgi?id=160833
1015
1016         Reviewed by Daniel Bates.
1017
1018         These changes allow the IOSSimulator port to run tests in iPad mode.
1019
1020         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
1021         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
1022         a custom device will be collected into a set, and run in that device's environment after
1023         the other tests have run.
1024
1025         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1026         (Manager._custom_device_for_test): If the test contains a directory matching a
1027         custom device suffix, return that custom device.
1028         (Manager._set_up_run): Push the custom device class, if any, into options so
1029         that the Worker can get to it.
1030         (Manager.run): Go through the list of tests, and break it down into device-generic
1031         tests, and tests for each device class. _run_test_subset is then called for
1032         each collection of tests, and the results merged.
1033         (Manager._run_test_subset): Some lines unwrapped.
1034         (Manager._end_test_run):
1035         (Manager._run_tests):
1036         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1037         (SingleTestRunner.__init__): Unwrapped a line.
1038         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1039         (TestRunResults.merge): Add this function to merge TestRunResults
1040         * Scripts/webkitpy/layout_tests/views/printing.py:
1041         (Printer.print_workers_and_shards): Print the custom device, if any.
1042         * Scripts/webkitpy/port/base.py:
1043         (Port): Base port has empty array of custom devices.
1044         (Port.setup_test_run): Add device_class argument.
1045         * Scripts/webkitpy/port/driver.py:
1046         (DriverInput.__repr__):
1047         (Driver.check_driver.implementation):
1048         * Scripts/webkitpy/port/efl.py:
1049         (EflPort.setup_test_run):
1050         * Scripts/webkitpy/port/gtk.py:
1051         (GtkPort.setup_test_run):
1052         * Scripts/webkitpy/port/ios.py:
1053         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
1054         (IOSSimulatorPort.__init__):
1055         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
1056         based on the custom device class.
1057         (IOSSimulatorPort._set_device_class):
1058         (IOSSimulatorPort._create_simulators): Factor some code into this function.
1059         (IOSSimulatorPort.setup_test_run):
1060         (IOSSimulatorPort.testing_device):
1061         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
1062         seemed wrong for this function. That was moved to setup_test_run().
1063         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
1064         but this happened too early, before we knew which kind of devices to create. Devices
1065         are now created in setup_test_run().
1066         * Scripts/webkitpy/port/win.py:
1067         (WinPort.setup_test_run):
1068
1069 2016-08-15  Daniel Bates  <dabates@apple.com>
1070
1071         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
1072         private frameworks and libraries
1073         https://bugs.webkit.org/show_bug.cgi?id=155931
1074         <rdar://problem/25807989>
1075
1076         Reviewed by Dan Bernstein.
1077
1078         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
1079         where X is the major version of the active iOS SDK.
1080
1081         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1082         * WebKitTestRunner/Configurations/Base.xcconfig:
1083
1084 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1085
1086         Add a setting and preferences to enable visual viewport mode
1087         https://bugs.webkit.org/show_bug.cgi?id=160843
1088
1089         Reviewed by Sam Weinig.
1090         
1091         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
1092
1093         * MiniBrowser/mac/SettingsController.h:
1094         * MiniBrowser/mac/SettingsController.m:
1095         (-[SettingsController _populateMenu]):
1096         (-[SettingsController validateMenuItem:]):
1097         (-[SettingsController visualViewportEnabled]):
1098         (-[SettingsController toggleVisualViewportEnabled:]):
1099         * MiniBrowser/mac/WK1BrowserWindowController.m:
1100         (-[WK1BrowserWindowController didChangeSettings]):
1101         * MiniBrowser/mac/WK2BrowserWindowController.m:
1102         (-[WK2BrowserWindowController didChangeSettings]):
1103
1104 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
1105
1106         Allow using make-dist with non-GTK ports
1107         https://bugs.webkit.org/show_bug.cgi?id=160842
1108
1109         Reviewed by Michael Catanzaro.
1110
1111         This patch adds support for setting base name of tarball and argument
1112         passed to cmake's -DPORT= via command line arguments.
1113
1114         * gtk/make-dist.py:
1115         (Distcheck.configure):
1116         (Distcheck.check):
1117         (get_tarball_root_and_output_filename_from_arguments):
1118
1119 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1120
1121         [GTK] Install script lacks gstreamer related dependencies
1122         https://bugs.webkit.org/show_bug.cgi?id=160814
1123
1124         Reviewed by Carlos Garcia Campos.
1125
1126         * gtk/install-dependencies: Fedora case had already listed this dependencies,
1127         but both Arch and Debian/Ubuntu were missing them.
1128
1129 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
1130
1131         make-dist.py should not allow unknown rules in manifest
1132         https://bugs.webkit.org/show_bug.cgi?id=160841
1133
1134         Reviewed by Carlos Garcia Campos.
1135
1136         * gtk/make-dist.py:
1137         (Manifest.process_line):
1138
1139 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1140
1141         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
1142         https://bugs.webkit.org/show_bug.cgi?id=160809
1143
1144         Reviewed by Carlos Garcia Campos.
1145
1146         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
1147         case, and use it also for the new package names of libpng and libgeoclue.
1148         * gtk/install-dependencies: Ditto.
1149
1150 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1151
1152         Skip to check directories existence in build-webkit
1153         https://bugs.webkit.org/show_bug.cgi?id=160691
1154
1155         Reviewed by Alex Christensen.
1156
1157         CMake checks if directories are there itself. So CMake ports
1158         don't need to check it in the build-webkit script.
1159
1160         * Scripts/build-webkit:
1161         * Scripts/webkitdirs.pm:
1162         (determineSourceDir):
1163         (isCMakeBuild):
1164
1165 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1166
1167         Make URLParser work with URLs missing URL parts
1168         https://bugs.webkit.org/show_bug.cgi?id=160824
1169
1170         Reviewed by Brady Eidson.
1171
1172         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1173         (TestWebKitAPI::s):
1174         (TestWebKitAPI::checkURL):
1175         (TestWebKitAPI::TEST_F):
1176         (TestWebKitAPI::eq): Deleted.
1177
1178 2016-08-12  John Wilander  <wilander@apple.com>
1179
1180         Add HashCountedSet API tests to TestWTFLibrary target
1181         https://bugs.webkit.org/show_bug.cgi?id=160815
1182
1183         Reviewed by Alex Christensen.
1184
1185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1186             Added HashCountedSet.cpp and sorted the file reference section
1187             according to UNIX sort.
1188
1189 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
1190
1191         run-benchmark should run JetStream 1.1 instead of 1.0.1
1192         https://bugs.webkit.org/show_bug.cgi?id=160816
1193
1194         Reviewed by Filip Pizlo.
1195
1196         Use the latest JetStream 1.1 in run-benchmark.
1197
1198         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1199         (BenchmarkBuilder.__exit__):
1200         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
1201         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
1202         change to JetStream directory.
1203
1204 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1205
1206         Initial URLParser implementation
1207         https://bugs.webkit.org/show_bug.cgi?id=160811
1208
1209         Reviewed by Brady Eidson.
1210
1211         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1212         (TestWebKitAPI::eq):
1213         (TestWebKitAPI::checkURL):
1214         (TestWebKitAPI::TEST_F):
1215
1216 2016-08-12  Brady Eidson  <beidson@apple.com>
1217
1218         Fix the 32-bit Mac build after:
1219         Add WK2 ExperimentalFeature support to MiniBrowser
1220         https://bugs.webkit.org/show_bug.cgi?id=160788
1221
1222         Unreviewed.
1223
1224         Sprinkle "#if WK_API_ENABLED"s liberally.
1225         
1226         * MiniBrowser/mac/AppDelegate.m:
1227         (defaultConfiguration):
1228         * MiniBrowser/mac/SettingsController.m:
1229         (-[SettingsController _populateMenu]):
1230         (-[SettingsController validateMenuItem:]):
1231
1232 2016-08-12  Philippe Normand  <pnormand@igalia.com>
1233
1234         [GStreamer][OWR] Video rendering fixes
1235         https://bugs.webkit.org/show_bug.cgi?id=160764
1236
1237         Reviewed by Xabier Rodriguez-Calvar.
1238
1239         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
1240
1241 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
1242
1243         Add missing return statement in convertFast function added in r204376.
1244
1245         Unreviewed.
1246
1247         * Scripts/webkitpy/common/system/path.py:
1248         (_CygPath.convertFast):
1249
1250 2016-08-11  Brady Eidson  <beidson@apple.com>
1251
1252         Add WK2 ExperimentalFeature support to MiniBrowser.
1253         https://bugs.webkit.org/show_bug.cgi?id=160788
1254
1255         Reviewed by Alex Christensen.
1256
1257         * MiniBrowser/mac/AppDelegate.h:
1258         * MiniBrowser/mac/AppDelegate.m:
1259         (defaultConfiguration):
1260         (defaultPreferences):
1261         
1262         * MiniBrowser/mac/SettingsController.m:
1263         (-[SettingsController _populateMenu]):
1264         (-[SettingsController validateMenuItem:]):
1265         (-[SettingsController toggleExperimentalFeature:]):
1266
1267 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1268
1269         Keep EWS logs for longer
1270         https://bugs.webkit.org/show_bug.cgi?id=160776
1271
1272         Reviewed by Daniel Bates.
1273
1274         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
1275
1276 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
1277
1278         iOS DRT/WTR project cleanup
1279         https://bugs.webkit.org/show_bug.cgi?id=160778
1280
1281         Reviewed by Tim Horton.
1282
1283         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
1284
1285         Remove AppDelegate.* which were unused.
1286
1287         Exclude ios/Launch.storyboard on more platforms.
1288
1289         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1290         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1291         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1292         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1293         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
1294         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
1295         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
1296
1297 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1298
1299         Fix Yosemite bots' cookie accept policies after r204365.
1300         https://bugs.webkit.org/show_bug.cgi?id=160758
1301
1302         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1303         (TEST):
1304         This makes the test fully clean up after itself.
1305
1306 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1307
1308         Fix Yosemite bots' cookie accept policies after r204365.
1309         https://bugs.webkit.org/show_bug.cgi?id=160758
1310
1311         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1312         (TEST):
1313         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
1314         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
1315         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
1316         causing any problems because there are no other API tests that do anything with cookies.
1317         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
1318         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
1319         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
1320
1321 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1322
1323         EWS should check if the patch is still valid before executing every major step
1324         https://bugs.webkit.org/show_bug.cgi?id=160739
1325         rdar://problem/27768813
1326
1327         Reviewed by Alexey Proskuryakov.
1328
1329         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1330         (CommitQueueTask.run): validate method is now executed in base class.
1331         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1332         (EarlyWarningSystemTask.run): validate method is now executed in base class.
1333         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1334         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
1335         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1336         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
1337         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
1338         * Scripts/webkitpy/tool/commands/perfalizer.py:
1339         (PerfalizerTask.validate): Added.
1340         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1341         (test_manual_reject_during_processing): Updated test case.
1342
1343 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1344
1345         Add URLParser stub
1346         https://bugs.webkit.org/show_bug.cgi?id=160770
1347
1348         Reviewed by Sam Weinig.
1349
1350         * TestWebKitAPI/PlatformGTK.cmake:
1351         * TestWebKitAPI/PlatformWin.cmake:
1352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1353         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
1354         (TestWebKitAPI::TEST_F):
1355
1356 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1357
1358         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
1359         https://bugs.webkit.org/show_bug.cgi?id=160761
1360
1361         Reviewed by Tim Horton.
1362
1363         Give iOS DRT a Launch storyboard.
1364
1365         Have it use a UIViewController so future forms testing works correctly.
1366
1367         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
1368         can run in iPad mode.
1369
1370         Remove empty InfoPlist.strings files.
1371
1372         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1373         * DumpRenderTree/ios/Info.plist:
1374         * DumpRenderTree/ios/Launch.storyboard: Added.
1375         * DumpRenderTree/mac/DumpRenderTree.mm:
1376         (createWebViewAndOffscreenWindow):
1377         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1378         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
1379         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1380         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
1381
1382 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
1383
1384         [Win] Unable to reliably run tests in parallel
1385         https://bugs.webkit.org/show_bug.cgi?id=140914
1386
1387         Reviewed by Brent Fulgham.
1388
1389         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1390         processes. We can use string replacement to convert the Cygwin path to a Windows path
1391         instead.
1392
1393         * Scripts/webkitpy/common/system/path.py:
1394         (cygpathFast):
1395         * Scripts/webkitpy/port/driver.py:
1396         (Driver._command_from_driver_input):
1397
1398 2016-08-10  Alex Christensen  <achristensen@webkit.org>
1399
1400         Fix crash when changing cookie accept policy after r204327
1401         https://bugs.webkit.org/show_bug.cgi?id=160758
1402
1403         Reviewed by Simon Fraser.
1404
1405         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1406         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
1407         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
1408         (TEST):
1409         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
1410
1411 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1412
1413         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
1414         https://bugs.webkit.org/show_bug.cgi?id=160757
1415
1416         Reviewed by Tim Horton.
1417
1418         When programmatically creating the test UIWindow, make a root UIViewController and parent
1419         the WKWebView in its view. This makes the app more like a normal UIKit application.
1420         
1421         Move the WKWebView down 20px to avoid the status bar.
1422         
1423         Give the UIWindow a gray background so it's obvious where the window and view positioned.
1424
1425         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
1426         
1427         Remove duplicate references to Launch.storyboard.
1428
1429         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1430         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
1431         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
1432         (-[AppDelegate applicationWillResignActive:]): Deleted.
1433         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
1434         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
1435         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
1436         (-[AppDelegate applicationWillTerminate:]): Deleted.
1437         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1438         (WTR::viewRectForWindowRect):
1439         (WTR::PlatformWebView::PlatformWebView):
1440         (WTR::PlatformWebView::setWindowFrame):
1441
1442 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1443
1444         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
1445         https://bugs.webkit.org/show_bug.cgi?id=160748
1446
1447         Reviewed by Tim Horton.
1448         
1449         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
1450         opens the door for tests using other device sizes.
1451
1452         * WebKitTestRunner/ios/TestControllerIOS.mm:
1453         (WTR::TestController::platformConfigureViewForTest):
1454
1455 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1456
1457         Sort the feature flags in the FEATURE_DEFINES lines
1458         https://bugs.webkit.org/show_bug.cgi?id=160742
1459
1460         Reviewed by Anders Carlsson.
1461         
1462         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1463
1464 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
1465
1466         Logging and other minor improvements to iOS webkitpy
1467         https://bugs.webkit.org/show_bug.cgi?id=160722
1468
1469         Reviewed by Dan Bates.
1470
1471         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
1472         to make it easier to debug launching issues.
1473
1474         Have reset_preferences() reset the device, rather than just nuking the data
1475         directory (which broke some versions of the simulator).
1476
1477         Make the Simulator.app launch in the background with open -g.
1478
1479         Wait for the simulator device to be in a known state in some more places.
1480
1481         * Scripts/webkitpy/port/ios.py:
1482         (IOSSimulatorPort.setup_test_run):
1483         (IOSSimulatorPort._quit_ios_simulator):
1484         (IOSSimulatorPort.clean_up_test_run):
1485         (IOSSimulatorPort.setup_environ_for_server):
1486         (IOSSimulatorPort.reset_preferences):
1487         * Scripts/webkitpy/xcode/simulator.py:
1488         (Device.create):
1489         (Device.delete):
1490         (Device):
1491         (Device.reset):
1492         (Simulator.wait_until_device_is_booted):
1493         (Simulator.wait_until_device_is_in_state):
1494         (Simulator):
1495         (Simulator.delete_device):
1496         (Simulator.reset_device):
1497         (Simulator.lookup_or_create_device):
1498
1499 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1500
1501         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
1502         https://bugs.webkit.org/show_bug.cgi?id=160697
1503
1504         Reviewed by Antonio Gomes.
1505
1506         * Scripts/webkitpy/port/base.py:
1507         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
1508         list of environment variables to copy.
1509
1510 2016-08-09  George Ruan  <gruan@apple.com>
1511
1512         Implement functionality of media capture on iOS
1513         https://bugs.webkit.org/show_bug.cgi?id=158945
1514         <rdar://problem/26893343>
1515
1516         Reviewed by Tim Horton.
1517
1518         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
1519         Capture feature on iOS.
1520
1521 2016-08-09  Saam Barati  <sbarati@apple.com>
1522
1523         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
1524         https://bugs.webkit.org/show_bug.cgi?id=160671
1525         <rdar://problem/27756112>
1526
1527         Reviewed by Mark Lam.
1528
1529         * Scripts/run-jsc-stress-tests:
1530
1531 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
1532
1533         Make directory reading code in iOSSimulatorDevices() more strict
1534         https://bugs.webkit.org/show_bug.cgi?id=160702
1535
1536         Reviewed by Tim Horton.
1537
1538         * Scripts/webkitdirs.pm:
1539         (iOSSimulatorDevices):
1540
1541 2016-08-06  Sam Weinig  <sam@webkit.org>
1542
1543         Replace NodeOrString with std::variant<RefPtr<Node>, String>
1544         https://bugs.webkit.org/show_bug.cgi?id=160638
1545
1546         Reviewed by Anders Carlsson.
1547
1548         * TestWebKitAPI/CMakeLists.txt:
1549         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1550         Add additional tests for the initial state of std::variant and using
1551         makeVisitor for visiting.
1552
1553 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
1554
1555         EWS logging should ensure the logging to file is stopped on queue termination
1556         https://bugs.webkit.org/show_bug.cgi?id=160698
1557         rdar://problem/24464570
1558
1559         Reviewed by Daniel Bates.
1560
1561         * Scripts/webkitpy/tool/bot/queueengine.py:
1562         (QueueEngine._stopping): Stop logging to file on queue termination.
1563         (QueueEngine._begin_logging): Configure the Python logger to log to file.
1564         * Scripts/webkitpy/common/system/logutils.py:
1565         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1566         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1567         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1568         * Scripts/webkitpy/tool/commands/queues.py:
1569         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1570         (AbstractQueue.queue_log_path): Same.
1571         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1572         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1573         which moved to QueueEngine now.
1574         (PatchProcessingQueue.__init__): Same.
1575         (CommitQueue.__init__): Same.
1576         (AbstractReviewQueue.__init__): Same.
1577         (StyleQueue.__init__): Same.
1578         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1579         (TestCommitQueue): Removed host parameter.
1580         (TestCommitQueue.__init__): Same.
1581         (AbstractPatchQueueTest.test_next_patch): Same.
1582         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1583         (test_commit_queue_failure): Same.
1584         (mock_run_webkit_patch):
1585         (MockCommitQueueTask.results_from_patch_test_run): Same.
1586         (test_rollout_lands): Same.
1587         (test_non_valid_patch): Same.
1588         (test_auto_retry): Same.
1589         (test_style_queue_with_watch_list_exception): Same.
1590         (TestQueue.__init__): Deleted.
1591         (TestReviewQueue.__init__): Deleted.
1592         (TestFeederQueue.__init__): Deleted.
1593
1594 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
1595
1596         webkit-gtk tarball fails to build due to missing files
1597         https://bugs.webkit.org/show_bug.cgi?id=160684
1598
1599         Reviewed by Alex Christensen.
1600
1601         * gtk/manifest.txt.in: Added back spi directories.
1602
1603 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1604
1605         [GTK] Build the jhbuild with -O2 optimization level by default
1606         https://bugs.webkit.org/show_bug.cgi?id=160544
1607
1608         Reviewed by Michael Catanzaro.
1609
1610         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1611         which don't increases the required disk space significatively and
1612         provides better debug information than no passing it.
1613
1614 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
1615
1616         Allow more --cmakeargs option in build-jsc and build-webkit
1617         https://bugs.webkit.org/show_bug.cgi?id=160340
1618
1619         Reviewed by Michael Catanzaro.
1620
1621         * Scripts/build-jsc:
1622         * Scripts/build-webkit:
1623
1624 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1625
1626         Do not check if WebKitLibraries folder exists on EFL and GTK
1627         https://bugs.webkit.org/show_bug.cgi?id=160659
1628
1629         Reviewed by Csaba Osztrogonác.
1630
1631         Though WebKitLibraries is only needed by mac and win ports,
1632         EFL and GTK ports have checked whether it exists.
1633
1634         * Scripts/build-webkit:
1635
1636 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
1637
1638         Some EWS console logs doesn't go to log file
1639         https://bugs.webkit.org/show_bug.cgi?id=160585
1640         rdar://problem/24464570
1641
1642         Reviewed by Daniel Bates.
1643
1644         * Scripts/webkitpy/common/system/logutils.py:
1645         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
1646         any possible overwriting.
1647         * Scripts/webkitpy/common/system/filesystem.py:
1648         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
1649         * Scripts/webkitpy/common/system/filesystem_mock.py:
1650         (MockFileSystem.open_text_file_for_writing): Same.
1651         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1652         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
1653         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
1654         * Scripts/webkitpy/tool/commands/queues.py:
1655         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
1656         This will ensure that all the sub-modules inside webkitpy will log to file.
1657
1658 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
1659
1660         Have the iOS platform interit from the Apple platform in webkitpy
1661         https://bugs.webkit.org/show_bug.cgi?id=160672
1662
1663         Reviewed by Dan Bates.
1664         
1665         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
1666         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
1667         ApplePort.
1668         
1669         Since WinPort also inherits from ApplePort, it needs to stub out some things
1670         that are unavailable on Windows (leaks, sampling).
1671         
1672         Some SnowLeopard-related code and the associated test were removed.
1673
1674         * Scripts/webkitpy/port/apple.py:
1675         (ApplePort.__init__):
1676         (ApplePort):
1677         (ApplePort._make_leak_detector):
1678         (ApplePort.default_timeout_ms):
1679         (ApplePort.supports_per_test_timeout):
1680         (ApplePort.should_retry_crashes):
1681         (ApplePort._generate_all_test_configurations):
1682         (ApplePort.check_for_leaks):
1683         (ApplePort.print_leaks_summary):
1684         (ApplePort._path_to_webcore_library):
1685         (ApplePort.show_results_html_file):
1686         (ApplePort._merge_crash_logs):
1687         (ApplePort._look_for_all_crash_logs_in_log_dir):
1688         (ApplePort._get_crash_log):
1689         (ApplePort.look_for_new_crash_logs):
1690         (ApplePort.sample_process):
1691         (ApplePort.sample_file_path):
1692         (ApplePort.look_for_new_samples):
1693         (ApplePort._path_to_helper):
1694         (ApplePort.determine_full_port_name): Deleted.
1695         * Scripts/webkitpy/port/ios.py:
1696         (IOSSimulatorPort):
1697         (IOSSimulatorPort.__init__):
1698         (IOSSimulatorPort.default_timeout_ms): Deleted.
1699         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
1700         (IOSSimulatorPort.should_retry_crashes): Deleted.
1701         (IOSSimulatorPort.check_for_leaks): Deleted.
1702         (IOSSimulatorPort.print_leaks_summary): Deleted.
1703         (IOSSimulatorPort._path_to_webcore_library): Deleted.
1704         (IOSSimulatorPort.show_results_html_file): Deleted.
1705         (IOSSimulatorPort.sample_file_path): Deleted.
1706         (IOSSimulatorPort._merge_crash_logs): Deleted.
1707         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
1708         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
1709         (IOSSimulatorPort.look_for_new_samples): Deleted.
1710         (IOSSimulatorPort.sample_process): Deleted.
1711         (IOSSimulatorPort._path_to_helper): Deleted.
1712         (IOSSimulatorPort.make_command): Deleted.
1713         * Scripts/webkitpy/port/mac.py:
1714         (MacPort.__init__):
1715         (MacPort.make_command):
1716         (MacPort._build_java_test_support):
1717         (MacPort): Deleted.
1718         (MacPort.default_timeout_ms): Deleted.
1719         (MacPort.supports_per_test_timeout): Deleted.
1720         (MacPort.should_retry_crashes): Deleted.
1721         (MacPort.default_child_processes): Deleted.
1722         (MacPort.check_for_leaks): Deleted.
1723         (MacPort.print_leaks_summary): Deleted.
1724         (MacPort._path_to_webcore_library): Deleted.
1725         (MacPort.show_results_html_file): Deleted.
1726         (MacPort.sample_file_path): Deleted.
1727         (MacPort._merge_crash_logs): Deleted.
1728         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
1729         (MacPort.look_for_new_crash_logs): Deleted.
1730         (MacPort.look_for_new_samples): Deleted.
1731         (MacPort.sample_process): Deleted.
1732         (MacPort._path_to_helper): Deleted.
1733         * Scripts/webkitpy/port/mac_unittest.py:
1734         (MacTest.test_default_child_processes): Deleted.
1735         * Scripts/webkitpy/port/win.py:
1736         (WinPort.look_for_new_samples):
1737         (WinPort):
1738         (WinPort.sample_process):
1739         (WinPort._make_leak_detector):
1740         (WinPort.check_for_leaks):
1741         (WinPort.print_leaks_summary):
1742         (WinPort._path_to_webcore_library):
1743
1744 2016-08-08  Matt Baker  <mattbaker@apple.com>
1745
1746         Unreviewed: moved myself to the reviewers list.
1747
1748         * Scripts/webkitpy/common/config/contributors.json:
1749
1750 2016-08-08  Chris Dumez  <cdumez@apple.com>
1751
1752         Update API tests in mac/SetDocumentURI.mm after r204247
1753         https://bugs.webkit.org/show_bug.cgi?id=160660
1754
1755         Reviewed by Alex Christensen.
1756
1757         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
1758         (TestWebKitAPI::TEST):
1759
1760 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
1761
1762         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
1763         https://bugs.webkit.org/show_bug.cgi?id=159827
1764
1765         Reviewed by Daniel Bates.
1766
1767         This change was spurred by a process hang which occurred between tests and did
1768         not produce a meaningful crashlog.
1769
1770         * Scripts/webkitpy/port/driver.py:
1771         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1772
1773          * Scripts/webkitpy/port/ios.py:
1774         (IOSSimulatorPort):
1775         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1776         * Scripts/webkitpy/port/mac.py:
1777         (MacPort):
1778         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1779
1780         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1781         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1782
1783         * WebKitTestRunner/TestController.h:
1784         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1785         * WebKitTestRunner/TestInvocation.cpp:
1786         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1787
1788 2016-08-07  Dan Bernstein  <mitz@apple.com>
1789
1790         [Cocoa] Reply block leaks if the remote object doesn’t call it
1791         https://bugs.webkit.org/show_bug.cgi?id=160642
1792
1793         Reviewed by Sam Weinig.
1794
1795         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1796         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1797         (TEST): Added a test case that checks that the reply block is released even when it’s not
1798           called.
1799         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1800         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1801           calling the completion handler.
1802
1803 2016-08-07  Chris Dumez  <cdumez@apple.com>
1804
1805         Write API test to cover crash fix in r204135
1806         https://bugs.webkit.org/show_bug.cgi?id=160587
1807
1808         Reviewed by Darin Adler.
1809
1810         Add API test to cover crash fix in r204135. This reproduces the crash
1811         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1812         callback.
1813
1814         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1815         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1816         (TEST):
1817
1818 2016-08-06  Chris Dumez  <cdumez@apple.com>
1819
1820         Unreviewed, rolling out r204226.
1821
1822         Broke some API tests
1823
1824         Reverted changeset:
1825
1826         "Write API test to cover crash fix in r204135"
1827         https://bugs.webkit.org/show_bug.cgi?id=160587
1828         http://trac.webkit.org/changeset/204226
1829
1830 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1831
1832         EWS Style Queue fails to process patches which fails validation
1833         https://bugs.webkit.org/show_bug.cgi?id=160632
1834
1835         Reviewed by Alexey Proskuryakov.
1836
1837         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1838         (StyleQueueTask.validate): Add more information about validation failure.
1839         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1840         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1841         (test_non_valid_patch): Add a unit test to test the above code path.
1842
1843 2016-08-06  Sam Weinig  <sam@webkit.org>
1844
1845         WTF needs a variant implementation
1846         https://bugs.webkit.org/show_bug.cgi?id=160618
1847
1848         Reviewed by Darin Adler.
1849
1850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1851         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1852         Add tests for the variant implementation.
1853
1854 2016-08-06  Chris Dumez  <cdumez@apple.com>
1855
1856         Write API test to cover crash fix in r204135
1857         https://bugs.webkit.org/show_bug.cgi?id=160587
1858
1859         Reviewed by Darin Adler.
1860
1861         Add API test to cover crash fix in r204135. This reproduces the crash
1862         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1863         callback.
1864
1865         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1866         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1867         (TEST):
1868
1869 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1870
1871         run-api-tests should use a headed simulator
1872         https://bugs.webkit.org/show_bug.cgi?id=160611
1873
1874         Reviewed by Sam Weinig.
1875
1876         CADisplayLink doesn't work in a headless simulator, but is
1877         vital for the proper functioning of WebKit2 painting on iOS.
1878         So, we should not use a headless simulator.
1879
1880         * Scripts/run-api-tests:
1881         Launch a simulator app, don't just boot the simulator.
1882
1883         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1884         Re-enable a test that works now.
1885
1886 2016-08-05  Dan Bernstein  <mitz@apple.com>
1887
1888         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1889         https://bugs.webkit.org/show_bug.cgi?id=160589
1890
1891         Reviewed by Tim Horton.
1892
1893         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1894         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1895           blocks, which wasn’t caught because the test wasn’t run correctly.
1896         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1897         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1898           added a test that sends over an NSRange.
1899         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1900         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1901           handler with the range‘s location and length.
1902
1903 2016-08-05  Enrica Casucci  <enrica@apple.com>
1904
1905         Fixing tests failing after r204175.
1906
1907         Unreviewed.
1908
1909         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1910
1911 2016-08-05  Enrica Casucci  <enrica@apple.com>
1912
1913         Build fix after 204053.
1914
1915         Unreviewed.
1916
1917         * TestWebKitAPI/Configurations/Base.xcconfig:
1918         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1919         (-[MockContentFilterEnabler initWithCoder:]):
1920         (-[MockContentFilterEnabler dealloc]):
1921
1922 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1923
1924         Print test name in "Last character read from DRT..." error message.
1925         https://bugs.webkit.org/show_bug.cgi?id=160559
1926
1927         Reviewed by Michael Catanzaro.
1928
1929         * Scripts/webkitpy/port/driver.py:
1930         (Driver.run_test):
1931         (Driver._read_first_block):
1932         (Driver._read_optional_image_block):
1933         (Driver._read_block):
1934         * Scripts/webkitpy/port/driver_unittest.py:
1935         (DriverTest.test_read_block):
1936         (DriverTest.test_read_binary_block):
1937         (DriverTest.test_read_base64_block):
1938
1939 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1940
1941         Unreviewed, rolling out r204123.
1942         https://bugs.webkit.org/show_bug.cgi?id=160597
1943
1944         Caused layout test timeouts on Windows. (Requested by perarne
1945         on #webkit).
1946
1947         Reverted changeset:
1948
1949         "[Win] Unable to reliably run tests in parallel"
1950         https://bugs.webkit.org/show_bug.cgi?id=140914
1951         http://trac.webkit.org/changeset/204123
1952
1953 2016-08-04  Saam Barati  <sbarati@apple.com>
1954
1955         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1956         https://bugs.webkit.org/show_bug.cgi?id=151241
1957
1958         Reviewed by Benjamin Poulain.
1959
1960         * Scripts/run-jsc-stress-tests:
1961
1962 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1963
1964         UI improvements to Flakiness Dashboard.
1965         https://bugs.webkit.org/show_bug.cgi?id=153295
1966
1967         Reviewed by Alexey Proskuryakov.
1968
1969         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1970         (td.options-container): Center text in most fields.
1971         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1972         (createBugHTML): Text/Grammar updates.
1973         (tableHeaders): Ditto.
1974         (htmlForSingleTestRow): Ditto.
1975         (headerForTestTableHtml): Ditto.
1976         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1977         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1978
1979 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1980
1981         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1982         https://bugs.webkit.org/show_bug.cgi?id=160518
1983
1984         Reviewed by Michael Catanzaro.
1985
1986         * Scripts/webkitpy/thirdparty/__init__.py:
1987         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1988         * gtk/install-dependencies:
1989
1990 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1991
1992         Optimize bot watcher's dashboard a little
1993         https://bugs.webkit.org/show_bug.cgi?id=160515
1994         rdar://problem/26096900
1995
1996         Reviewed by Lucas Forschler.
1997
1998         Made re-sorting after loading an iteration more efficient.
1999
2000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2001         (BuildbotIteration.prototype._updateWithData):
2002         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2003         (BuildbotQueue.prototype.updateIterationPosition):
2004
2005 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
2006
2007         [Win] Unable to reliably run tests in parallel
2008         https://bugs.webkit.org/show_bug.cgi?id=140914
2009
2010         Reviewed by Brent Fulgham.
2011
2012         The cygpath utility function can fail badly when running with multiple DumpRenderTree
2013         processes. We can use string replacement to convert the Cygwin path to a Windows path
2014         instead.
2015  
2016         * Scripts/webkitpy/common/system/path.py:
2017         (cygpathFast):
2018         * Scripts/webkitpy/port/driver.py:
2019         (Driver._command_from_driver_input):
2020
2021 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
2022
2023         Document instructions for increasing process and file limits
2024         https://bugs.webkit.org/show_bug.cgi?id=160528
2025         rdar://problem/24777576
2026
2027         Reviewed by Alexey Proskuryakov.
2028
2029         * Scripts/webkitpy/port/ios.py:
2030         (IOSSimulatorPort.default_child_processes):
2031
2032 2016-08-03  Anders Carlsson  <andersca@apple.com>
2033
2034         Remove the Objective-C bindings generator
2035         https://bugs.webkit.org/show_bug.cgi?id=160526
2036
2037         Reviewed by Sam Weinig.
2038
2039         * Scripts/run-bindings-tests:
2040         Update test.
2041
2042 2016-08-03  Tim Horton  <timothy_horton@apple.com>
2043
2044         Revise a TestWebKitAPI comment to mention the actual underlying problem
2045
2046         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2047         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
2048
2049 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2050
2051         Benchmark test content-animation timeouts always
2052         https://bugs.webkit.org/show_bug.cgi?id=160057
2053
2054         Reviewed by Simon Fraser.
2055
2056         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
2057         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2058         (start):
2059
2060 2016-08-02  Nan Wang  <n_wang@apple.com>
2061
2062         AX: Simulated touch events are not working on iOS
2063         https://bugs.webkit.org/show_bug.cgi?id=160395
2064         <rdar://problem/27633597>
2065
2066         Reviewed by Chris Fleizach.
2067
2068         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2069         (WTR::AccessibilityUIElement::press):
2070         (WTR::AccessibilityUIElement::setSelectedChild):
2071
2072 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
2073
2074         run-javascriptcore-tests should accept multiple --extra-tests
2075         https://bugs.webkit.org/show_bug.cgi?id=160486
2076
2077         Reviewed by Saam Barati.
2078         
2079         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
2080         test suites. This does it by using GetOpt::Long's array support.
2081
2082         * Scripts/run-javascriptcore-tests:
2083         (runJSCStressTests):
2084
2085 2016-08-02  Enrica Casucci  <enrica@apple.com>
2086
2087         Allow building with content filtering disabled.
2088         https://bugs.webkit.org/show_bug.cgi?id=160454
2089
2090         Reviewed by Simon Fraser.
2091
2092         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2093
2094 2016-08-02  Brady Eidson  <beidson@apple.com>
2095
2096         Removing IndexedDB WebsiteData can fail for some users.
2097         https://bugs.webkit.org/show_bug.cgi?id=160463
2098
2099         Reviewed by Alex Christensen.
2100
2101         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2102
2103 2016-08-01  Alex Christensen  <achristensen@webkit.org>
2104
2105         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
2106         https://bugs.webkit.org/show_bug.cgi?id=160437
2107         <rdar://problem/27578272>
2108
2109         Reviewed by Brady Eidson.
2110
2111         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2112         (-[DownloadDelegate _download:didReceiveResponse:]):
2113         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2114         (runTest):
2115         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
2116
2117 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2118
2119         [Tools] The GDB backtrace report tool don't checks the gdb return code.
2120         https://bugs.webkit.org/show_bug.cgi?id=160414
2121
2122         Reviewed by Michael Catanzaro.
2123
2124         * Scripts/webkitpy/port/linux_get_crash_log.py:
2125         (GDBCrashLogGenerator._wait_for_corefile):
2126
2127 2016-08-01  Youenn Fablet  <youenn@apple.com>
2128
2129         Make wpt server generate its certificates in layout test results folder
2130         https://bugs.webkit.org/show_bug.cgi?id=160422
2131
2132         Reviewed by Chris Dumez.
2133
2134         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2135         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
2136
2137 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
2138
2139         Function Call on NULL Object
2140         https://bugs.webkit.org/show_bug.cgi?id=160325
2141
2142         Reviewed by Darin Adler.
2143
2144         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2145         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
2146         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
2147
2148 2016-08-01  Keith Miller  <keith_miller@apple.com>
2149
2150         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
2151         https://bugs.webkit.org/show_bug.cgi?id=160372
2152
2153         Rubber stamped by Geoffrey Garen.
2154
2155         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
2156         a new top level directory, JSTests. Having the tests in the Source directory
2157         was both confusing an inconvenient for people that just want to checkout the
2158         source code of WebKit. Since there is no other obvious place to put all the
2159         JavaScript tests a new top level directory seemed the most sensible.
2160
2161         * Scripts/import-test262-tests:
2162         * Scripts/run-javascriptcore-tests:
2163         * Scripts/update-javascriptcore-test-res:
2164
2165 2016-07-31  Nan Wang  <n_wang@apple.com>
2166
2167         AX: Add a check for touch event listener on iOS accessibility object
2168         https://bugs.webkit.org/show_bug.cgi?id=160388
2169
2170         Reviewed by Chris Fleizach.
2171
2172         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2173         (AccessibilityUIElement::boolAttributeValue):
2174         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2175         (WTR::AccessibilityUIElement::boolAttributeValue):
2176
2177 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
2178
2179         Unreviewed: add myself to the reviewers list.
2180
2181         * Scripts/webkitpy/common/config/contributors.json:
2182
2183 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
2184
2185         Undo r203939, and copy over a rule that clips the logos.
2186
2187         Sierra wasn't the only logo without transparency.
2188
2189         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2192
2193 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
2194
2195         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
2196         https://bugs.webkit.org/show_bug.cgi?id=160377
2197
2198         Reviewed by Brian Weinstein.
2199
2200         Update assets to remove the white background and use a transparent background instead.
2201
2202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2204
2205 2016-07-29  David Kilzer  <ddkilzer@apple.com>
2206
2207         Ignore most check-webkit-style checks for ANGLE project
2208         <https://webkit.org/b/160333>
2209
2210         Reviewed by Daniel Bates.
2211
2212         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
2213         - No tabs.
2214         - No spaces at the end of lines.
2215         - No carriage returns (DOS line endings).
2216
2217 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2218
2219         Media controls are not displayed for some autoplaying videos at certain browser dimensions
2220         https://bugs.webkit.org/show_bug.cgi?id=160360
2221         <rdar://problem/27179484>
2222
2223         Reviewed by Myles C. Maxfield.
2224
2225         Adds two tests verifying that videos may be considered main content as long as they
2226         are large enough and cover a majority of the mainframe's viewport.
2227
2228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2229         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2230         (TestWebKitAPI::TEST):
2231         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
2232         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
2233
2234 2016-07-29  Mark Lam  <mark.lam@apple.com>
2235
2236         Gardening: removed unused variable.
2237
2238         Not reviewed.
2239
2240         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2241         (TestWebKitAPI::TEST):
2242
2243 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2244
2245         Add TestWebKitAPI support for interacting with media controls
2246         https://bugs.webkit.org/show_bug.cgi?id=160342
2247         <rdar://problem/27610246>
2248
2249         Reviewed by Beth Dakin.
2250
2251         Adds support for testing interaction with some media controls, as well as a basic test
2252         verifying that media control teardown after interaction does not result in a crash.
2253
2254         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2255         (-[WKWebView mouseDownAtPoint:]):
2256         (-[WKWebView performAfterLoading:]):
2257         (TestWebKitAPI::TEST):
2258
2259 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
2260
2261         Crash Log Clobbering on Unbound Crashes
2262         https://bugs.webkit.org/show_bug.cgi?id=160198
2263         <rdar://problem/27472618>
2264
2265         Reviewed by Alexey Proskuryakov.
2266
2267         * Scripts/webkitpy/common/system/crashlogs.py:
2268         (CrashLogs): Fix header order.
2269         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2270         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
2271
2272 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2273
2274         Update for contributors.json
2275         https://bugs.webkit.org/show_bug.cgi?id=160294
2276
2277         * Scripts/webkitpy/common/config/contributors.json:
2278
2279 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
2280
2281         Remove deprecated SPI for video inline / fullscreen controls
2282         https://bugs.webkit.org/show_bug.cgi?id=160318
2283
2284         Reviewed by Tim Horton.
2285
2286         * DumpRenderTree/mac/DumpRenderTree.mm:
2287         (setDefaultsToConsistentValuesForTesting): Deleted.
2288         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2289         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2290         * WebKitTestRunner/TestController.cpp:
2291         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2292         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2293         (WTR::initializeWebViewConfiguration): Deleted.
2294
2295 2016-07-28  Daniel Bates  <dabates@apple.com>
2296
2297         [iOS] TestWebKitAPI bundle targets are not code signed
2298         https://bugs.webkit.org/show_bug.cgi?id=160328
2299         <rdar://problem/27409246>
2300
2301         Reviewed by Andy Estes.
2302
2303         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
2304         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
2305         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
2306
2307         * TestWebKitAPI/Configurations/Base.xcconfig:
2308
2309 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2310
2311         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
2312
2313         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2314         (animatedResizeWebView):
2315         (TEST):
2316         This test times out only when run in the WebKit Testing simulator environment,
2317         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
2318
2319 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2320
2321         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
2322         https://bugs.webkit.org/show_bug.cgi?id=160289
2323         <rdar://problem/27553464>
2324
2325         Reviewed by Simon Fraser.
2326
2327         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2329         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
2330         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
2331         (-[AnimatedResizeWebView _endAnimatedResize]):
2332         (animatedResizeWebView):
2333         (TEST):
2334         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
2335         Add two tests that ensure that hidden-content and animated resizes
2336         don't cause unnecessary synchronous waits. Only the hidden-content
2337         one fails before my patch, but it seemed reasonable to add both anyway.
2338
2339 2016-07-28  David Kilzer  <ddkilzer@apple.com>
2340
2341         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
2342         <https://webkit.org/b/83342>
2343
2344         Reviewed by Ryosuke Niwa.
2345
2346         * Scripts/webkitpy/common/checkout/scm/git.py:
2347         (Git.revisions_changing_file): Remove code to raise an exception
2348         when the file doesn't exist.  If a file was moved or renamed,
2349         then this caused the script to terminate, which was very
2350         frustrating when you wanted a list of reviewers.
2351         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2352         (SCMTest._shared_test_revisions_changing_file): Update test
2353         expectation to return an empty list of revisions.
2354         (test_create_patch_is_full_patch): Drive-by fix when running all
2355         webkitpy tests (including scm tests).
2356         * Scripts/webkitpy/common/checkout/scm/svn.py:
2357         (SVN.revisions_changing_file): Catch ScriptError exceptions and
2358         return an empty array of revisions if this occurs.
2359
2360 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
2361
2362         EWS error message "Error: * did not process patch" should include explanation
2363         https://bugs.webkit.org/show_bug.cgi?id=159903
2364         <rdar://problem/27410788>
2365
2366         Reviewed by Alexey Proskuryakov.
2367
2368         * QueueStatusServer/handlers/statusbubble.py:
2369         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
2370         is not processed.
2371         * QueueStatusServer/handlers/processingtimesjson.py:
2372         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
2373         of the code.
2374         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2375         (CommitQueueTask.validate): Add more information about validation failure.
2376         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2377         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2378         (EarlyWarningSystemTask.validate): Add more information about validation failure.
2379         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
2380         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2381         (PatchIsNotValid.__init__): Add the failure_message argument.
2382         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2383         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
2384         failure details.
2385         * Scripts/webkitpy/tool/commands/queues.py:
2386         (CommitQueue.process_work_item): Same.
2387         (StyleQueue.review_patch): Same.
2388         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2389         (test_non_valid_patch): Updated test-cases messages to match the above changes.
2390
2391 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
2392
2393         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
2394         https://bugs.webkit.org/show_bug.cgi?id=160262
2395
2396         Reviewed by Daniel Bates.
2397
2398         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2399         (-[LTRelayController installApp]):
2400
2401 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
2402
2403         Disable WebCoreNSURLSessionTest API tests on ios-simulator
2404         https://bugs.webkit.org/show_bug.cgi?id=160225
2405
2406         Reviewed by Alexey Proskuryakov.
2407
2408         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2409
2410 2016-07-27  Miguel Gomez  <magomez@igalia.com>
2411
2412         [GTK] Fix some video/canvas tests that should be passing
2413         https://bugs.webkit.org/show_bug.cgi?id=160023
2414
2415         Reviewed by Carlos Garcia Campos.
2416
2417         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
2418         EFL or GTK platforms.
2419
2420         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2421         (WTR::TestController::platformConfigureViewForTest):
2422         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2423         (WTR::TestController::platformConfigureViewForTest):
2424
2425 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2426
2427         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
2428         https://bugs.webkit.org/show_bug.cgi?id=160247
2429
2430         Reviewed by Michael Catanzaro.
2431
2432         * BuildSlaveSupport/built-product-archive:
2433         (createZip):
2434         (dirContainsdwo):
2435         (archiveBuiltProduct):
2436
2437 2016-07-26  Alex Christensen  <achristensen@webkit.org>
2438
2439         Fix tests after r203743.
2440         https://bugs.webkit.org/show_bug.cgi?id=156947
2441
2442         * WebKitTestRunner/TestController.cpp:
2443         (WTR::TestController::resetStateToConsistentValues):
2444         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
2445
2446 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2447
2448         [iPhone] Playing a video on tudou.com plays only sound, no video
2449         https://bugs.webkit.org/show_bug.cgi?id=160178
2450         <rdar://problem/27535468>
2451
2452         Reviewed by Dan Bernstein.
2453
2454         * DumpRenderTree/mac/DumpRenderTree.mm:
2455         (setDefaultsToConsistentValuesForTesting):
2456         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2457         (RequiresUserActionForPlaybackTest::SetUp):
2458         * WebKitTestRunner/TestController.cpp:
2459         (WTR::TestController::resetPreferencesToConsistentValues):
2460         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2461         (WTR::initializeWebViewConfiguration):
2462
2463 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2464
2465         Allow LOG macros to be used outside the namespace, and other logging cleanup
2466         https://bugs.webkit.org/show_bug.cgi?id=160216
2467
2468         Reviewed by Anders Carlsson.
2469         
2470         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
2471
2472         * DumpRenderTree/TestRunner.cpp:
2473         * DumpRenderTree/mac/DumpRenderTree.mm:
2474         (resetWebViewToConsistentStateBeforeTesting):
2475
2476 2016-07-26  David Kilzer <ddkilzer@apple.com>
2477
2478         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
2479         https://bugs.webkit.org/show_bug.cgi?id=156947
2480         <rdar://problem/23325160>
2481
2482         Reviewed by Alex Christensen.
2483
2484         * DumpRenderTree/TestRunner.cpp:
2485         (TestRunner::TestRunner):
2486         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
2487         * DumpRenderTree/TestRunner.h:
2488         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2489         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2490         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2491         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2492         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2493         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2494         (WTR::TestRunner::queueNonLoadingScript):
2495         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2496         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2497         * WebKitTestRunner/TestController.cpp:
2498         (WTR::TestController::didReceiveAuthenticationChallenge):
2499         * WebKitTestRunner/TestController.h:
2500         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2501         * WebKitTestRunner/TestInvocation.cpp:
2502         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2503         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
2504
2505 2016-07-26  David Kilzer  <ddkilzer@apple.com>
2506
2507         check-for-exit-time-destructors should be usable outside Xcode
2508         <https://webkit.org/b/160195>
2509
2510         Reviewed by Darin Adler.
2511
2512         * Scripts/check-for-exit-time-destructors: Update to parse
2513         -h|--help switch, or to take one argument to a binary to check
2514         for exit time destructors on the command-line.  The clang
2515         compiler will find these at compile-time with the
2516         -Wexit-time-destructors switch, but this script will check for
2517         them after-the-fact.
2518
2519 2016-07-26  Lucas Forschler  <lforschler@apple.com>
2520
2521         Test svn.webkit.org functionality after maintenance.
2522
2523 2016-07-25  Brady Eidson  <beidson@apple.com>
2524
2525         Modern IDB: Make sure IndexedDB works from file:// url documents by default
2526         https://bugs.webkit.org/show_bug.cgi?id=153783
2527
2528         Reviewed by Alex Christensen.
2529
2530         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
2531         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
2532         
2533         As of https://trac.webkit.org/changeset/203695 this is no longer required.
2534         
2535         Change the relevant API tests to make sure this continues to be no longer required.
2536
2537         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2538         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2539         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2540         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2541         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2542         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2543
2544 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2545
2546         Media controls should not be displayed for a video until it starts playing
2547         https://bugs.webkit.org/show_bug.cgi?id=160092
2548         <rdar://problem/26986673>
2549
2550         Reviewed by Beth Dakin.
2551
2552         Verify that multiple videos do or don't show the media controller depending on whether videos
2553         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
2554         passing because we were always showing media controls for large videos with audio, even if they
2555         had not played back yet. This change ensures that large videos with audio show media controls
2556         only after they begin to play back, and not by virtue of being large enough for main content.
2557
2558         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2559         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2560         (TestWebKitAPI::TEST):
2561         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2562         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
2563         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
2564
2565 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2566
2567         Media controls on apple.com don't disappear when movie finishes playing
2568         https://bugs.webkit.org/show_bug.cgi?id=160068
2569         <rdar://problem/26668526>
2570
2571         Reviewed by Darin Adler.
2572
2573         Adds new API tests. Please see WebCore ChangeLog for more details.
2574
2575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2576         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2577         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2578         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2579         (TestWebKitAPI::TEST):
2580         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2581         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2582         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2583         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2584         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2585
2586 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2587
2588         Unreviewed, fix test-webkitpy after r203674.
2589
2590         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2591         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2592
2593 2016-07-24  Philippe Normand  <pnormand@igalia.com>
2594
2595         Unreviewed, forgot to commit this file in r203674.
2596
2597         * Scripts/process-linux-coredump: Added.
2598         (main):
2599
2600 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2601
2602         Improve GDB backtrace generation for GTK/EFL
2603         https://bugs.webkit.org/show_bug.cgi?id=128928
2604
2605         Reviewed by Carlos Garcia Campos.
2606
2607         The PID of the crashed process is now correctly supplied to the
2608         crash log reporter. The kernel core_pattern needs to be updated
2609         after this change to something like:
2610
2611         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2612
2613         * Scripts/process-linux-coredump: Added.
2614         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2615         * Scripts/webkitpy/port/efl.py:
2616         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2617         * Scripts/webkitpy/port/gtk.py:
2618         (GtkPort._get_crash_log): Ditto.
2619         * Scripts/webkitpy/port/linux_get_crash_log.py:
2620         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
2621         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
2622         (GDBCrashLogGenerator): Deleted.
2623         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2624         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2625         * WebKitTestRunner/TestController.cpp:
2626         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2627         (WTR::TestController::databaseProcessDidCrash): Ditto.
2628         (WTR::TestController::processDidCrash): Ditto.
2629
2630 2016-07-23  Youenn Fablet  <youenn@apple.com>
2631
2632         WPT stash server should be kept running when launching wpt server
2633         https://bugs.webkit.org/show_bug.cgi?id=160052
2634
2635         Reviewed by Sam Weinig.
2636
2637         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2638         (main): waiting to read stdin while stash server is started.
2639
2640 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2641
2642         Media controls should be displayed for media in media documents
2643         https://bugs.webkit.org/show_bug.cgi?id=160104
2644         <rdar://problem/27438936>
2645
2646         Reviewed by Myles C. Maxfield.
2647
2648         Verifies that even a small video with audio in a media document gets media controls.
2649
2650         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2651         (TestWebKitAPI::TEST):
2652
2653 2016-07-22  Michael Saboff  <msaboff@apple.com>
2654
2655         REGRESSION(203616): no FTL testing was inadvertently removed
2656         https://bugs.webkit.org/show_bug.cgi?id=160100
2657
2658         Rubber-stamped by Filip Pizlo.
2659
2660         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
2661         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
2662         logic for the runLayout and runNoisy variants to match the run test logic,
2663         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
2664         enabled platforms.
2665
2666         * Scripts/run-jsc-stress-tests:
2667
2668 2016-07-22  Brady Eidson  <beidson@apple.com>
2669
2670         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
2671         https://bugs.webkit.org/show_bug.cgi?id=160089
2672
2673         Reviewed by Darin Adler.
2674
2675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2676         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
2677         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
2678
2679 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
2680
2681         [GTK] Improved exclusion patterns in make-dist.py manifest.
2682         https://bugs.webkit.org/show_bug.cgi?id=160094
2683
2684         Reviewed by Michael Catanzaro.
2685
2686         * gtk/manifest.txt.in:
2687         Exclude Platform*.cmake files for more ports.
2688         Removed obsolete .gyp and .pro.user patterns.
2689         Exclude 'Configurations' and 'spi' directories.
2690         Exclude CMakeLists.txt.user (Qt Creator IDE).
2691
2692 2016-07-22  Michael Saboff  <msaboff@apple.com>
2693
2694         Don't run FTL related JSC stress tests on non-FTL platforms
2695         https://bugs.webkit.org/show_bug.cgi?id=160033
2696
2697         Reviewed by Mark Lam.
2698
2699         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
2700         Refactored several of the runXXX test methods to always runXXXDefault and made those
2701         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
2702         doesn't cause a problem.
2703
2704         * Scripts/run-jsc-stress-tests:
2705
2706 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
2707
2708         IWebView::mainFrame crashes if called after IWebView::close
2709         https://bugs.webkit.org/show_bug.cgi?id=32868
2710
2711         Reviewed by Brent Fulgham.
2712
2713         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2714         (TestWebKitAPI::TEST_F): Added test.
2715
2716 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2717
2718         [GTK] Enable threaded compositor by default
2719         https://bugs.webkit.org/show_bug.cgi?id=160079
2720
2721         Reviewed by Žan Doberšek.
2722
2723         * Scripts/webkitperl/FeatureList.pm:
2724
2725 2016-07-22  Youenn Fablet  <youenn@apple.com>
2726
2727         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
2728         https://bugs.webkit.org/show_bug.cgi?id=159921
2729
2730         Reviewed by Brian Burg.
2731
2732         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
2733
2734         * Scripts/webkitpy/codegen/main.py:
2735         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
2736         (BuiltinsGeneratorTests):
2737         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
2738         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
2739         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
2740         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
2741
2742 2016-07-21  Dan Bernstein  <mitz@apple.com>
2743
2744         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
2745         https://bugs.webkit.org/show_bug.cgi?id=160072
2746
2747         Reviewed by Andy Estes.
2748
2749         * Scripts/webkitdirs.pm:
2750         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
2751           for old Xcode versions.
2752         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
2753           to readXcodeUserDefault.
2754         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
2755           debugger.
2756         (determineDebugger): Ditto.
2757         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
2758           7.0.
2759         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
2760           switches.
2761         (execMacWebKitAppForDebugging): Removed support for GDB.
2762
2763 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2764
2765         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
2766         https://bugs.webkit.org/show_bug.cgi?id=160066
2767
2768         Reviewed by Dean Jackson.
2769
2770         * DumpRenderTree/mac/DumpRenderTree.mm:
2771         (setDefaultsToConsistentValuesForTesting): Deleted.
2772         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2773         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2774         * WebKitTestRunner/TestController.cpp:
2775         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2776         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2777         (WTR::initializeWebViewConfiguration): Deleted.
2778
2779 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2780
2781         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2782         https://bugs.webkit.org/show_bug.cgi?id=159980
2783         rdar://problem/27450825
2784
2785         Reviewed by Dan Bernstein.
2786
2787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2788         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2789         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2790         when our delegate has hit -dealloc.
2791         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2792         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2793         will not be messaged.
2794
2795 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2796
2797         Follow-up patch to r203520
2798         https://bugs.webkit.org/show_bug.cgi?id=159967
2799         <rdar://problem/26964090>
2800
2801         Unreviewed.
2802
2803         * DumpRenderTree/mac/DumpRenderTree.mm:
2804         (setDefaultsToConsistentValuesForTesting):
2805         * WebKitTestRunner/TestController.cpp:
2806         (WTR::TestController::resetPreferencesToConsistentValues):
2807
2808 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2809
2810         [iPhone] Playing a video on tudou.com plays only sound, no video
2811         https://bugs.webkit.org/show_bug.cgi?id=159967
2812         <rdar://problem/26964090>
2813
2814         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2815
2816         Migrate tests to use new SPI.
2817
2818         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2819         (RequiresUserActionForPlaybackTest::SetUp):
2820         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2821         (WTR::initializeWebViewConfiguration):
2822
2823 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2824
2825         Clarify testing mode names in run-jsc-stress-tests
2826         https://bugs.webkit.org/show_bug.cgi?id=160021
2827
2828         Reviewed by Mark Lam.
2829
2830         Default should mean really default, not default with disabled FTL, renamed
2831         - runMozillaTestDefault to runMozillaTestNoFTL
2832         - runMozillaTestDefaultFTL to runMozillaTestDefault
2833         - runDefault to runNoFTL
2834         - runDefaultFTL to runDefault
2835         - runLayoutTestDefault to runLayoutTestNoFTL
2836         - runLayoutTestDefaultFTL to runLayoutTestDefault
2837         - runNoisyTestDefault to runNoisyTestNoFTL
2838         - runNoisyTestDefaultFTL to runNoisyTestDefault
2839
2840         * Scripts/run-jsc-stress-tests:
2841
2842 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2843
2844         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2845         https://bugs.webkit.org/show_bug.cgi?id=159986
2846
2847         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2848         to 0.
2849
2850         Reviewed by Dan Bernstein.
2851
2852         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2853         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2854         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2855         (TEST):
2856
2857 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2858
2859         [GTK] Web view background colors don't work in accelerated compositing mode
2860         https://bugs.webkit.org/show_bug.cgi?id=159455
2861
2862         Reviewed by Michael Catanzaro.
2863
2864         Set always RGBA visual to the view widget when setting a background color.
2865
2866         * MiniBrowser/gtk/BrowserWindow.c:
2867         (browser_window_set_background_color):
2868
2869 2016-07-20  Youenn Fablet  <youenn@apple.com>
2870
2871         Bots should run built-ins generator tests
2872         https://bugs.webkit.org/show_bug.cgi?id=159971
2873
2874         Reviewed by Alexey Proskuryakov.
2875
2876         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2877         (RunBuiltinsTests): New step to run built-in generator tests.
2878         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2879         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2880         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2881
2882 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2883
2884         Revert temporary fix r203417
2885         https://bugs.webkit.org/show_bug.cgi?id=160001
2886
2887         Reviewed by Alexey Proskuryakov.
2888
2889         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2890
2891 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2892
2893         REGRESSION(r148588): ews classes might get garbage collected
2894         https://bugs.webkit.org/show_bug.cgi?id=159990
2895
2896         Reviewed by Ryosuke Niwa.
2897
2898         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2899         in a variable so that they do not get garbage collected.
2900
2901 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2902
2903         Add API test for layout constraints after exit fullscreen
2904         https://bugs.webkit.org/show_bug.cgi?id=159900
2905
2906         Reviewed by Jon Lee.
2907
2908         Added Fullscreen.LaytoutConstraints API test. 
2909         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2910
2911         This test compares layout constraints on the web view before and after fullscreen to make sure 
2912         they are preserved.
2913
2914         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2915         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2916         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2917         (TestWebKitAPI::TEST):
2918
2919 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2920
2921         Disable two failing API tests.
2922
2923         Unreviewed test gardening.
2924
2925         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2926         (TestWebKitAPI::TEST):
2927
2928 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2929
2930         Unreviewed iOS build fix.
2931
2932         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2933
2934 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2935
2936         Media controls don't appear when pausing a small autoplaying video
2937         https://bugs.webkit.org/show_bug.cgi?id=159972
2938         <rdar://problem/27180657>
2939
2940         Reviewed by Beth Dakin.
2941
2942         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2943         for simulating basic user interaction in VideoControlsManager.
2944
2945         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2946         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2947         (-[WKWebView mouseDownAtPoint:]):
2948         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2949         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2950         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2951         (TestWebKitAPI::TEST):
2952         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2953
2954 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2955
2956         [Win] MathML fonts are not found.
2957         https://bugs.webkit.org/show_bug.cgi?id=159920
2958
2959         Reviewed by Alex Christensen.
2960
2961         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2962         for a specific registry key value.
2963
2964         * Scripts/webkitdirs.pm:
2965         (fontExists):
2966
2967 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2968
2969         Improve prepare-ChangeLog for @media blocks
2970         https://bugs.webkit.org/show_bug.cgi?id=159907
2971
2972         Reviewed by Timothy Hatcher.
2973
2974         * Scripts/prepare-ChangeLog:
2975         (get_selector_line_ranges_for_css):
2976         Get a range for @media blocks just like a selector.
2977             Start Line = line with '{'
2978             End line = line with '}'
2979             Name = "@media ..."
2980
2981         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2982         Improved error messages for unbalanced portions.
2983
2984         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2985         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2986         (.media-query::before):
2987         (@media only screen and (max-width: 980px)):
2988         (.media-query a):
2989         (@media (-webkit-min-device-pixel-ratio: 2)):
2990         (.both a):
2991         (.both b):
2992         (.media-query b):
2993         (.media-query::after):
2994
2995 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2996
2997         Fix expectedFailErrorHandler in run-jsc-stress-tests
2998         https://bugs.webkit.org/show_bug.cgi?id=159811
2999
3000         Reviewed by Yusuke Suzuki.
3001
3002         * Scripts/run-jsc-stress-tests:
3003
3004 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
3005
3006         Unreviewed Mac cmake buildfix after r203426. Just for fun.
3007
3008         * TestWebKitAPI/PlatformMac.cmake:
3009
3010 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
3011
3012         The default testing mode should not involve disabling the FTL JIT
3013         https://bugs.webkit.org/show_bug.cgi?id=159929
3014
3015         Rubber stamped by Mark Lam and Saam Barati.
3016         
3017         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
3018         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
3019         FTL was not the default. You had to enable it with an option.
3020         
3021         For some reason we have kept this arrangement even though the FTL JIT is now the default on
3022         all of the major ports. This has become a serious pain. For example, it's useful to be able
3023         to say that a test should only run in the default config that is representative of what a
3024         normal user would see if they ran JSC. Clearly, this would be a config that does not
3025         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
3026         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
3027         
3028         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
3029         try to fix it, because:
3030         
3031         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
3032           have the FTL enabled never run any tests that explicitly disable the FTL, since that
3033           doesn't do anything. The code is not really structured to allow this.
3034         
3035         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
3036           disabled in testing. On the other hand there are already build bots that do FTL tests
3037           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
3038           preserving this broken feature, we should create something that (a) acknowledges the fact
3039           that the FTL is the default on those platforms that support it and (b) avoids running
3040           no-ftl tests on precisely those platforms that don't have FTL.
3041         
3042         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
3043           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
3044           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
3045           pretending that the FTL JIT is not the default just because some bots used that as an
3046           optimization.
3047         
3048         This change allows me to speed up some debug tests and paint some bots green.
3049
3050         * Scripts/run-javascriptcore-tests:
3051         (runJSCStressTests):
3052         * Scripts/run-jsc-stress-tests:
3053
3054 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3055
3056         Fix API test after r203426.
3057         https://bugs.webkit.org/show_bug.cgi?id=159949
3058
3059         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3060         (TEST):
3061         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
3062         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
3063
3064 2016-07-19  Andy Estes  <aestes@apple.com>
3065
3066         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
3067         https://bugs.webkit.org/show_bug.cgi?id=159956
3068
3069         Reviewed by Dan Bernstein.
3070
3071         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
3072         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3073         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
3074         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
3075
3076 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3077
3078         Add regression test for r203392
3079         https://bugs.webkit.org/show_bug.cgi?id=159949
3080
3081         Reviewed by Brady Eidson.
3082
3083         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3084         (fileSize):
3085         (swizzledBundleIdentifierWebBookmarksD):
3086         (defaultApplicationCacheDirectory):
3087         (TEST):
3088         (swizzledBundleIdentifierMobileSafari): Deleted.
3089         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
3090         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
3091         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
3092
3093 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3094
3095         Add regression test for r203392
3096         https://bugs.webkit.org/show_bug.cgi?id=159949
3097
3098         Reviewed by Brady Eidson.
3099
3100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3101         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
3102         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
3103         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
3104         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3105         (TEST):
3106         (fileSize):
3107         (swizzledBundleIdentifierMobileSafari):
3108         (swizzledBundleIdentifierWebBookmarksD):
3109         (defaultApplicationCacheDirectory):
3110         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
3111         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
3112         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
3113         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
3114
3115 2016-07-19  Keith Miller  <keith_miller@apple.com>
3116
3117         Test262 should have a file with the revision and url
3118         https://bugs.webkit.org/show_bug.cgi?id=159937
3119
3120         Reviewed by Mark Lam.
3121
3122         The import script should update the information from
3123         the path to the test262 repository it gets.
3124
3125         * Scripts/import-test262-tests:
3126
3127 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
3128
3129         Temporary workaround for iOS EWS failing after the fix for bug 159539.
3130         To be deleted once the root cause is found and addressed.
3131
3132         * EWSTools/start-queue-mac.sh:
3133
3134 2016-07-19  Frederic Wang  <fwang@igalia.com>
3135
3136         [win] Fixup the register name for STIX Math and Latin Modern Math
3137
3138         Unreviewed follow-up of r203406
3139
3140         * Scripts/webkitdirs.pm:
3141         (checkInstalledTools):
3142
3143 2016-07-19  Frederic Wang  <fwang@igalia.com>
3144
3145         [win] Update the list of MathML fonts
3146         https://bugs.webkit.org/show_bug.cgi?id=156838
3147
3148         The set of recommended math fonts is now described at
3149         https://trac.webkit.org/wiki/MathML/Fonts
3150         We update the Perl script to use the latest list of fonts.
3151
3152         Reviewed by Brent Fulgham.
3153
3154         * Scripts/webkitdirs.pm:
3155         (checkInstalledTools):
3156
3157 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
3158
3159         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
3160         https://bugs.webkit.org/show_bug.cgi?id=159342
3161
3162         Reviewed by Darin Adler.
3163
3164         Implement required functions in event sender.
3165
3166         * DumpRenderTree/PlatformWin.cmake:
3167         * DumpRenderTree/win/EventSender.cpp:
3168         (monitorWheelEvents): Added.
3169         (callAfterScrollingCompletes): Added.
3170
3171 2016-07-19  Youenn Fablet  <youenn@apple.com>
3172
3173         Add new aliases to http test server
3174         https://bugs.webkit.org/show_bug.cgi?id=159878
3175
3176         Reviewed by Darin Adler.
3177
3178         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
3179         Adding explicitly these links to perl script.
3180         Extracting default alias in an aliases.json file.
3181         Reading that file from python scripts to initialize aliases from that file.
3182
3183         Python script changes covered by unit tests and changed layout test.
3184
3185         * Scripts/webkitperl/httpd.pm:
3186         (getDefaultConfigForTestDirectory): Adding 3 new aliases
3187         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
3188         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3189         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3190         Adding -c directives for each alias.
3191         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3192         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
3193         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3194         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3195         Adding alias directive for each alias.
3196         (Lighttpd._prepare_config):
3197         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3198         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
3199         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
3200         layout tests directory.
3201         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3202         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
3203         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
3204
3205 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
3206
3207         EWS console logs doesn't go to log file
3208         https://bugs.webkit.org/show_bug.cgi?id=159539
3209         <rdar://problem/24464570>
3210
3211         Reviewed by David Kilzer.
3212
3213         * Scripts/webkitpy/common/system/logutils.py:
3214         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
3215         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
3216         to filesystem. It also supports passing MockFilesystem.
3217         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
3218         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
3219         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3220         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
3221         (_test_ews): Same.
3222         * Scripts/webkitpy/tool/commands/queues.py:
3223         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
3224         (AbstractQueue._log_directory): Using filesystem object instead of os.
3225         (AbstractQueue.queue_log_path): Same.
3226         (AbstractQueue.__init__): Passed host parameter.
3227         (PatchProcessingQueue.__init__): Same.
3228         (CommitQueue.__init__): Same.
3229         (AbstractReviewQueue.__init__): Same.
3230         (StyleQueue.__init__): Same.
3231         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3232         (TestCommitQueue): Passed MockHost() as host.
3233         (TestCommitQueue.__init__): Same.
3234         (TestQueue.__init__): Same.
3235         (TestReviewQueue.__init__): Same.
3236         (TestFeederQueue.__init__): Same.
3237         (AbstractPatchQueueTest.test_next_patch): Same.
3238         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
3239         (test_commit_queue_failure): Same.
3240         (MockCommitQueueTask.results_from_patch_test_run): Same.
3241         (test_rollout_lands): Same.
3242         (test_non_valid_patch): Same.
3243         (test_auto_retry): Same.
3244         (test_style_queue_with_watch_list_exception): Same.
3245
3246 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
3247
3248         WTF::Lock should be fair eventually
3249         https://bugs.webkit.org/show_bug.cgi?id=159384
3250
3251         Reviewed by Geoffrey Garen.
3252
3253         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3254
3255 2016-07-17  Sam Weinig  <sam@webkit.org>
3256
3257         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3258         <rdar://problem/26554137>
3259         https://bugs.webkit.org/show_bug.cgi?id=159856
3260
3261         Reviewed by Dan Bernstein.
3262
3263         * MiniBrowser/mac/WK2BrowserWindowController.m:
3264         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3265         Add basic window.open implementation.
3266
3267         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
3268         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
3269         to open a single non-web URL, all others are dropped.
3270
3271         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3272         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
3273         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
3274         Add API for the new SPI.
3275
3276 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
3277
3278         [JSC] Enable test262 module tests
3279         https://bugs.webkit.org/show_bug.cgi?id=159854
3280
3281         Reviewed by Saam Barati.
3282
3283         Use --module-file instead.
3284
3285         * Scripts/run-jsc-stress-tests:
3286
3287 2016-07-16  Chris Dumez  <cdumez@apple.com>
3288
3289         Unreviewed, rolling out r203318.
3290
3291         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
3292         SunSpider)
3293
3294         Reverted changeset:
3295
3296         "[JSC] Change some parameters based on a random search"
3297         https://bugs.webkit.org/show_bug.cgi?id=158514
3298         http://trac.webkit.org/changeset/203318
3299
3300 2016-07-16  Chris Dumez  <cdumez@apple.com>
3301
3302         Add move constructor / assignment operator to ListHashSet
3303         https://bugs.webkit.org/show_bug.cgi?id=159837
3304
3305         Reviewed by Darin Adler.
3306
3307         Add API tests.
3308
3309         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3310         (TestWebKitAPI::TEST):
3311
3312 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
3313
3314         [JSC] Change some parameters based on a random search
3315         https://bugs.webkit.org/show_bug.cgi?id=158514
3316
3317         Reviewed by Saam Barati.
3318
3319         * Scripts/run-jsc-stress-tests:
3320
3321 2016-07-15  Jon Davis  <jond@apple.com>
3322
3323         Changed the start page URL for WebKit Nightly builds.
3324         https://bugs.webkit.org/show_bug.cgi?id=159816
3325
3326         Reviewed by Timothy Hatcher.
3327
3328         * WebKitLauncher/start.html:
3329
3330 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
3331
3332         Uninitialized variable in DIBPixelData can cause a dangerous memory write
3333         https://bugs.webkit.org/show_bug.cgi?id=159414
3334
3335         Reviewed by Brent Fulgham.
3336
3337         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
3338         when the HDC parameter is invalid.
3339
3340         * TestWebKitAPI/PlatformWin.cmake:
3341         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
3342         (TestWebKitAPI::TEST):
3343
3344 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3345
3346         [GTK] Add basic tabs support to MiniBrowser
3347         https://bugs.webkit.org/show_bug.cgi?id=159803
3348
3349         Reviewed by Sergio Villar Senin.
3350
3351         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
3352         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
3353
3354         * MiniBrowser/gtk/BrowserTab.c: Added.
3355         (titleChanged):
3356         (isLoadingChanged):
3357         (decidePolicy):
3358         (removeChildIfInfoBar):
3359         (loadChanged):
3360         (createInfoBarQuestionMessage):
3361         (tlsErrorsDialogResponse):
3362         (loadFailedWithTLSerrors):
3363         (permissionRequestDialogResponse):
3364         (decidePermissionRequest):
3365         (colorChooserRGBAChanged):
3366         (popoverColorClosed):
3367         (colorChooserRequestFinished):
3368         (runColorChooserCallback):
3369         (inspectorOpenedInWindow):
3370         (inspectorClosed):
3371         (browserTabSetProperty):
3372         (browserTabFinalize):
3373         (browser_tab_init):
3374         (browserTabConstructed):
3375         (browser_tab_class_init):
3376         (getInternalURI):
3377         (browser_tab_new):
3378         (browser_tab_get_web_view):
3379         (browser_tab_load_uri):
3380         (browser_tab_get_title_widget):
3381         (browser_tab_set_status_text):
3382         (browser_tab_toggle_inspector):
3383         (browser_tab_start_search):
3384         (browser_tab_stop_search):
3385         (browser_tab_add_accelerators):
3386         (fullScreenMessageTimeoutCallback):
3387         (browser_tab_enter_fullscreen):
3388         (browser_tab_leave_fullscreen):
3389         * MiniBrowser/gtk/BrowserTab.h: Added.
3390         * MiniBrowser/gtk/BrowserWindow.c:
3391         (getExternalURI):
3392         (browserWindowSetStatusText):
3393         (reloadOrStopCallback):
3394         (goBackCallback):
3395         (goForwardCallback):
3396         (settingsCallback):
3397         (webViewURIChanged):
3398         (browserWindowHistoryItemActivated):
3399         (browserWindowUpdateNavigationActions):
3400         (webViewCreate):
3401         (webViewEnterFullScreen):
3402         (webViewLeaveFullScreen):
3403         (webViewDecidePolicy):
3404         (browserWindowCanZoomIn):
3405         (browserWindowCanZoomOut):
3406         (browserWindowZoomIn):
3407         (browserWindowZoomOut):
3408         (scrollEventCallback):
3409         (faviconChanged):
3410         (webViewIsLoadingChanged):
3411         (defaultZoomCallback):
3412         (searchCallback):
3413         (newTabCallback):
3414         (toggleWebInspector):
3415         (reloadPage):
3416         (reloadPageIgnoringCache):
3417         (stopPageLoad):
3418         (loadHomePage):
3419         (editingCommandCallback):
3420         (insertImageCommandCallback):
3421         (insertLinkCommandCallback):
3422         (browserWindowSetupEditorToolbar):
3423         (browserWindowSwitchTab):
3424         (browserWindowTabAddedOrRemoved):
3425         (browser_window_init):
3426         (browserWindowConstructed):
3427         (browserWindowSaveSession):
3428         (browserWindowDeleteEvent):
3429         (browser_window_new):
3430         (browser_window_append_view):
3431         (browser_window_load_uri):
3432         (browser_window_load_session):
3433         (browser_window_set_background_color):
3434         (resetStatusText): Deleted.
3435         (activateUriEntryCallback): Deleted.
3436         (webViewTitleChanged): Deleted.
3437         (resetEntryProgress): Deleted.
3438         (browserWindowCreateBackForwardMenu): Deleted.
3439         (webViewReadyToShow): Deleted.
3440         (webViewLoadFailed): Deleted.
3441         (webViewMouseTargetChanged): Deleted.
3442         (browserWindowUpdateZoomActions): Deleted.
3443         (webViewZoomLevelChanged): Deleted.
3444         (updateUriEntryIcon): Deleted.
3445         (zoomInCallback): Deleted.
3446         (zoomOutCallback): Deleted.
3447         (toggleFullScreen): Deleted.
3448         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
3449         (browserWindowFinalize): Deleted.
3450         (browser_window_class_init): Deleted.
3451         * MiniBrowser/gtk/BrowserWindow.h:
3452         * MiniBrowser/gtk/CMakeLists.txt:
3453         * MiniBrowser/gtk/main.c:
3454         (createBrowserTab):
3455         (aboutURISchemeRequestCallback):
3456         (main):
3457         (parseBackgroundColor): Deleted.
3458
3459 2016-07-14  Alex Christensen  <achristensen@webkit.org>
3460
3461         Allow RefPtrs of const RefCounted types
3462         https://bugs.webkit.org/show_bug.cgi?id=158269
3463
3464         Reviewed by Anders Carlsson.
3465
3466         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3467         (TestWebKitAPI::TEST):
3468         (TestWebKitAPI::ConstRefCounted::create):
3469         (TestWebKitAPI::returnConstRefCountedRef):
3470         (TestWebKitAPI::returnRefCountedRef):
3471
3472 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3473
3474         Test WTF.StringViewIterators is crashing since r203119
3475         https://bugs.webkit.org/show_bug.cgi?id=159710
3476
3477         Reviewed by Darin Adler.
3478
3479         There are two problems in the test case added in r203119. First is that it's testing
3480         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
3481         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
3482         const reference to the string view member of the deleted CodePoints object.
3483
3484         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3485         (TestWebKitAPI::TEST):
3486
3487 2016-07-13  Daniel Bates  <dabates@apple.com>
3488
3489         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
3490         https://bugs.webkit.org/show_bug.cgi?id=159738
3491         <rdar://problem/27304649>
3492
3493         Reviewed by Dan Bernstein.
3494
3495         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
3496         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
3497         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
3498         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
3499
3500         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3501         * WebKitTestRunner/ios/TestControllerIOS.mm:
3502         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
3503         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
3504
3505 2016-07-13  Beth Dakin  <bdakin@apple.com>
3506
3507         Attempted build fix.
3508
3509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3510
3511 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
3512
3513         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
3514         https://bugs.webkit.org/show_bug.cgi?id=159686
3515
3516         Reviewed by Chris Dumez.
3517
3518         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
3519
3520         * WebKitTestRunner/TestController.cpp:
3521         (WTR::runOpenPanel):
3522         (WTR::TestController::createOtherPage):
3523         (WTR::TestController::createWebViewWithOptions):
3524
3525 2016-07-13  Beth Dakin  <bdakin@apple.com>
3526
3527         Add more candidate tests
3528         https://bugs.webkit.org/show_bug.cgi?id=159730
3529
3530         Reviewed by Tim Horton.
3531
3532         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
3533         two new tests to that file.
3534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3535         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
3536         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
3537         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
3538         (TestWebKitAPI::TEST):
3539         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
3540
3541 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
3542
3543         AX: [ATK] spinbutton-crash.html fails
3544         https://bugs.webkit.org/show_bug.cgi?id=159723
3545
3546         Reviewed by Chris Fleizach.
3547
3548         Implement support for AXDecrementButton and AXIncrementButton in
3549         ATK's AccessibilityUIElement::uiElementAttributeValue().
3550
3551         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3552         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3553
3554 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3555
3556         [EFL] [GTK] Enable back crypto subtle on development builds.
3557         https://bugs.webkit.org/show_bug.cgi?id=159260
3558
3559         Reviewed by Carlos Garcia Campos.
3560
3561         * Scripts/webkitperl/FeatureList.pm:
3562
3563 2016-07-12  Mark Lam  <mark.lam@apple.com>
3564
3565         We should use different stack limits for stack checks from JS and host code.
3566         https://bugs.webkit.org/show_bug.cgi?id=159442
3567         <rdar://problem/26889188>
3568
3569         Reviewed by Geoffrey Garen.
3570
3571         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
3572         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
3573         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
3574         order to keep the js/regress-139548.html test happy with this patch.
3575
3576         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
3577         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
3578
3579         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3580         (-[LTRelayController _environmentVariables]):
3581         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3582         (main):
3583
3584 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
3585
3586         platformUserPreferredLanguages on Mac should not try to put the region into the language
3587         https://bugs.webkit.org/show_bug.cgi?id=159693
3588
3589         Rubber stamped by Alexey Proskuryakov.
3590         
3591         Revert the test change in r200105.
3592
3593         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
3594         (TestWebKitAPI::languageForSystemLanguage):
3595
3596 2016-07-12  Chris Dumez  <cdumez@apple.com>
3597
3598         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
3599         https://bugs.webkit.org/show_bug.cgi?id=159663
3600         <rdar://problem/18995873>
3601
3602         Reviewed by Benjamin Poulain.
3603
3604         Add API test coverage.
3605
3606         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3607         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
3608         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
3609         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
3610         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
3611         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
3612         (TEST):
3613
3614 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
3615
3616         Relax ordering requirements on StringView::CodePoints iterator
3617         https://bugs.webkit.org/show_bug.cgi?id=159609
3618
3619         Reviewed by Darin Adler.
3620
3621         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3622         (TestWebKitAPI::TEST):
3623
3624 2016-07-12  Youenn Fablet  <youenn@apple.com>
3625
3626         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
3627         https://bugs.webkit.org/show_bug.cgi?id=159564
3628
3629         Reviewed by Brian Burg.
3630
3631         * Scripts/webkitpy/codegen/main.py:
3632         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
3633
3634 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3635
3636         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
3637         https://bugs.webkit.org/show_bug.cgi?id=159671
3638
3639         Reviewed by Csaba Osztrogonác.
3640
3641         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
3642         https://bugs.webkit.org/show_bug.cgi?id=89235
3643
3644         So this guard can be removed in build scripts.
3645
3646         * Scripts/webkitperl/FeatureList.pm:
3647         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3648
3649 2016-07-11  Jason Marcell  <jmarcell@apple.com>
3650
3651         SVN.create_patch should find svn-create-patch relative to the WebKit root.
3652         https://bugs.webkit.org/show_bug.cgi?id=159652
3653
3654         Reviewed by Daniel Bates.
3655
3656         * Scripts/webkitpy/common/checkout/scm/svn.py:
3657         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
3658
3659 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
3660
3661         Implement grapheme cluster iterator on StringView
3662         https://bugs.webkit.org/show_bug.cgi?id=159598
3663
3664         Reviewed by Anders Carlsson.
3665
3666         This is in preparation for honoring the second argument to FontFaceSet.load().
3667
3668         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3669         (TestWebKitAPI::compareLoopIterations):
3670         (TestWebKitAPI::TEST):
3671
3672 2016-07-11  Nan Wang  <n_wang@apple.com>
3673
3674         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
3675         https://bugs.webkit.org/show_bug.cgi?id=158364
3676
3677         Reviewed by Anders Carlsson.
3678
3679         Added a function in TestRunner so that we can toggle the ignoring viewport
3680         scale limits setting. Also added a test option for that in order to change the 
3681         configuration of the webview in test.
3682
3683         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3684         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3685         (WTR::TestRunner::setNavigationGesturesEnabled):
3686         (WTR::TestRunner::setIgnoresViewportScaleLimits):
3687         (WTR::nextUIScriptCallbackID):
3688         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3689         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3690         * WebKitTestRunner/TestController.cpp:
3691         (WTR::TestController::resetStateToConsistentValues):
3692         (WTR::updateTestOptionsFromTestHeader):
3693         (WTR::TestController::setNavigationGesturesEnabled):
3694         (WTR::TestController::setIgnoresViewportScaleLimits):
3695         (WTR::TestController::platformWillRunTest):
3696         * WebKitTestRunner/TestController.h:
3697         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3698         * WebKitTestRunner/TestInvocation.cpp:
3699         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3700         * WebKitTestRunner/TestOptions.h:
3701         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3702         (WTR::TestController::platformCreateWebView):
3703
3704 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
3705
3706         [GTK] install-dependencies should not install packages built by jhbuild.
3707         https://bugs.webkit.org/show_bug.cgi?id=159628
3708
3709         Reviewed by Michael Catanzaro.
3710
3711         * gtk/install-dependencies:
3712         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
3713
3714 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
3715
3716         System proxy settings not used when building deps with jhbuild
3717         https://bugs.webkit.org/show_bug.cgi?id=159567
3718
3719         Reviewed by Michael Catanzaro.
3720
3721         This adds the gsettings-desktop-schemas-devel build dep to enable
3722         the libgiognomeproxy.so gio module in glib-networking, which uses
3723         GSettings on org.gnome.system.proxy.
3724         This is needed to query system proxy settings for Gnome desktops.
3725
3726         dconf can be manually added to jhbuild to build the
3727         libdconfsettings.so gio module for GSettings, so that
3728         libgiognomeproxy.so can access system settings.
3729           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
3730
3731         As an alternative to dconf settings, this commit also adds the
3732         libproxy-devel build dep to enable the libgiolibproxy.so module in
3733         glib-networking (suggested by Fujii Hironori).
3734
3735         It is useful to read proxy settings from environment variables.
3736         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
3737         environment variable to force using the envvar module in libproxy.
3738
3739         * gtk/install-dependencies:
3740
3741 2016-07-11  Mark Lam  <mark.lam@apple.com>
3742
3743         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
3744         https://bugs.webkit.org/show_bug.cgi?id=159524
3745
3746         Reviewed by Michael Saboff.
3747
3748         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
3749         Also fixed up some tests to behave better to work with this new limit.  This
3750         should make stack overflow tests complete sooner.
3751
3752         * Scripts/run-jsc-stress-tests:
3753         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3754         (main):
3755
3756 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3757
3758         [GTK] Whitespace fixes in install-dependencies script
3759
3760         Unreviewed.
3761
3762         * gtk/install-dependencies:
3763
3764 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3765
3766         [GTK] Install missing Fedora dependencies
3767
3768         Unreviewed.
3769
3770         * gtk/install-dependencies:
3771
3772 2016-07-09  Dan Bernstein  <mitz@apple.com>
3773
3774         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
3775         https://bugs.webkit.org/show_bug.cgi?id=159600
3776
3777         Reviewed by Daniel Bates.
3778
3779         * Scripts/git-add-reviewer:
3780         Added the -s|--rubber-stamp option.
3781         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
3782           new option.
3783
3784 2016-07-08  Andy Estes  <aestes@apple.com>
3785
3786         [Content Filtering] Load blocked pages more like other error pages are loaded
3787         https://bugs.webkit.org/show_bug.cgi?id=159485
3788         <rdar://problem/26014076>
3789
3790         Reviewed by Brady Eidson.
3791
3792         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3793         to a content filtering provisional navigation failure is ignored in preference of
3794         ContentFilter's own error page.
3795
3796         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3797         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3798         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3799         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3800         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3801         (loadAlternateTest):
3802         (TEST):
3803         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3804         (-[MockContentFilterEnabler initWithCoder:]):
3805         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3806         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3807         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3808         (TestWebKitAPI::loadAlternateTest):
3809         (TestWebKitAPI::TEST):
3810
3811 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3812
3813         Unreviewed, rolling out r202944.
3814         https://bugs.webkit.org/show_bug.cgi?id=159570
3815
3816         caused some tests to crash under GuardMalloc (Requested by
3817         estes on #webkit).
3818
3819         Reverted changeset:
3820
3821         "[Content Filtering] Load blocked pages more like other error
3822         pages are loaded"
3823         https://bugs.webkit.org/show_bug.cgi?id=159485
3824         http://trac.webkit.org/changeset/202944
3825
3826 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
3827
3828         Remove mrobinson from the MathML watchlist
3829         https://bugs.webkit.org/show_bug.cgi?id=159559
3830
3831         Reviewed by Philippe Normand.
3832
3833         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
3834
3835 2016-07-08  Brady Eidson  <beidson@apple.com>
3836
3837         Clearing LocalStorage doesn't also delete -wal and -shm files.
3838         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
3839
3840         Reviewed by Brent Fulgham.
3841         Also helpfully picked over by Andy "Never Forgets" Estes.
3842
3843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3844         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
3845         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
3846
3847 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
3848
3849         Removed Qt leftovers from Tools.
3850         https://bugs.webkit.org/show_bug.cgi?id=159557
3851
3852         Reviewed by Csaba Osztrogonác.
3853
3854         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3855         Removed 'qt' platform config.
3856         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3857         Deleted non-functional e-mail address.
3858
3859 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3860
3861         Unreviewed, rolling out r202967.
3862         https://bugs.webkit.org/show_bug.cgi?id=159556
3863
3864         This patch caused crashes in https tests on Windows (Requested
3865         by perarne on #webkit).
3866
3867         Reverted changeset:
3868
3869         "[Win] The test http/tests/security/contentSecurityPolicy
3870         /upgrade-insecure-requests/basic-upgrade.https.html is
3871         failing."
3872         https://bugs.webkit.org/show_bug.cgi?id=159510
3873         http://trac.webkit.org/changeset/202967
3874
3875 2016-07-08  Youenn Fablet  <youenn@apple.com>
3876
3877         Generate WebCore builtin wrapper files
3878         https://bugs.webkit.org/show_bug.cgi?id=159461
3879
3880         Reviewed by Brian Burg.
3881
3882         * Scripts/webkitpy/codegen/main.py:
3883         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3884         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3885
3886 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3887
3888         [EFL] Fix build when media-stream is enabled.
3889         https://bugs.webkit.org/show_bug.cgi?id=159206
3890
3891         Bump up the openwebrtc to find the correct package.
3892
3893         Reviewed by Gyuyoung Kim.
3894
3895         * efl/jhbuild.modules:
3896         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3897
3898 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3899
3900         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3901         https://bugs.webkit.org/show_bug.cgi?id=159510
3902
3903         Reviewed by Brent Fulgham.
3904
3905         Allow any https certificate when running tests.
3906
3907         * DumpRenderTree/win/DumpRenderTree.cpp:
3908         (runTest):
3909
3910 2016-07-07  Beth Dakin  <bdakin@apple.com>
3911
3912         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3913         https://bugs.webkit.org/show_bug.cgi?id=159532
3914         -and corresponding-
3915         rdar://problem/27177179
3916
3917         Reviewed by Tim Horton.
3918
3919         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3920         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3921
3922 2016-07-07  Andy Estes  <aestes@apple.com>
3923
3924         [Content Filtering] Load blocked pages more like other error pages are loaded
3925         https://bugs.webkit.org/show_bug.cgi?id=159485
3926         <rdar://problem/26014076>
3927
3928         Reviewed by Brady Eidson.
3929
3930         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3931         to a content filtering provisional navigation failure is ignored in preference of
3932         ContentFilter's own error page.
3933
3934         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3936         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3937         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3938         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3939         (loadAlternateTest):
3940         (TEST):
3941         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3942         (-[MockContentFilterEnabler initWithCoder:]):
3943         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3944         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3945         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3946         (TestWebKitAPI::loadAlternateTest):
3947         (TestWebKitAPI::TEST):
3948
3949 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3950
3951         Unreviewed: add myself to the reviewers list.
3952
3953         * Scripts/webkitpy/common/config/contributors.json:
3954
3955 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3956
3957         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3958         https://bugs.webkit.org/show_bug.cgi?id=159509
3959
3960         Reviewed by Alex Christensen.
3961
3962         We should always insert the url in the url map when identifierForInitialRequest
3963         is called. Otherwise we can end up with identifiers not having an entry in the
3964         url map when urls are written to the test output file. 
3965
3966         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3967         (ResourceLoadDelegate::identifierForInitialRequest):
3968
3969 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3970
3971         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3972         https://bugs.webkit.org/show_bug.cgi?id=159498
3973         <rdar://problem/26719903>
3974
3975         Reviewed by Sam Weinig.
3976
3977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3978         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3979         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3980         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3981         (expectLinkCount):
3982         (TEST):
3983         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3984         when deciding what to linkify.
3985
3986 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3987
3988         Build fix - work around rdar://problem/27196668.
3989
3990         * LayoutTestRelay/Configurations/Base.xcconfig:
3991
3992 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3993
3994         Enhance Windows DRT implementation to support platform scroll wheel events.
3995         https://bugs.webkit.org/show_bug.cgi?id=36002
3996
3997         Reviewed by Brent Fulgham.
3998
3999         Implement function continuousMouseScrollBy in Windows event sender.
4000
4001         * DumpRenderTree/win/EventSender.cpp:
4002         (mouseScrollBy):
4003         (continuousMouseScrollBy):
4004
4005 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
4006
4007         [Sierra] Rebaseline tests to use un-mocked system font metrics
4008         https://bugs.webkit.org/show_bug.cgi?id=159311
4009         <rdar://problem/24138411>
4010
4011         Reviewed in person by Alexey Proskuryakov.
4012
4013         Stop mocking the system font on Sierra.
4014
4015         * DumpRenderTree/mac/DumpRenderTree.mm:
4016         (setDefaultsToConsistentValuesForTesting):
4017         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4018         (WTR::InjectedBundle::platformInitialize):
4019
4020 2016-07-05  Brady Eidson  <beidson@apple.com>
4021
4022         Database process crashes deleting a corrupt SQLite database file (null deref).
4023         https://bugs.webkit.org/show_bug.cgi?id=155506.
4024
4025         Reviewed by Alex Christensen.
4026
4027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4028         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
4029         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
4030         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
4031         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
4032         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
4033
4034 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
4035
4036         run-webkit-tests should print more complete baseline search paths
4037         https://bugs.webkit.org/show_bug.cgi?id=159354
4038
4039         Reviewed by Daniel Bates.
4040
4041         run-webkit-tests used to only print directory names in baseline search paths.
4042         This was ok in basic usage, but quickly got confusing when using
4043         --additional-platform-directory flags.
4044
4045         * Scripts/webkitpy/layout_tests/views/printing.py:
4046         (Printer.print_config):
4047         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4048         (Testprinter.test_print_config):
4049         (Testprinter.test_print_one_line_summary):
4050
4051 2016-07-04  Brady Eidson  <beidson@apple.com>
4052
4053         WebProcesses don't handle DatabaseProcess going away uncleanly..
4054         https://bugs.webkit.org/show_bug.cgi?id=159371
4055
4056         Reviewed by Alex Christensen.
4057
4058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4059         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
4060         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
4061         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
4062         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
4063
4064 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4065
4066         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
4067         https://bugs.webkit.org/show_bug.cgi?id=158141
4068
4069         Rubber-stamped by Michael Catanzaro.
4070
4071         Instead of checking for an specific Ubuntu version, query the apt
4072         database to see which version of PHP is available.
4073
4074         * efl/install-dependencies:
4075         * gtk/install-dependencies:
4076
4077 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
4078
4079         webkit-patch failure-reason always raises TypeError
4080         https://bugs.webkit.org/show_bug.cgi?id=159394
4081
4082         Reviewed by Benjamin Poulain.
4083
4084         In r170637 (Bug 133067), the first and second arguments of
4085         pluralize were swapped.
4086
4087         * Scripts/webkitpy/tool/commands/queries.py:
4088         (FailureReason._builder_to_explain): Swap the first and second
4089         arguments of pluralize.
4090
4091 2016-07-02  Youenn Fablet  <youennf@gmail.com>
4092
4093         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
4094         https://bugs.webkit.org/show_bug.cgi?id=152486
4095
4096         Reviewed by Daniel Bates.
4097
4098         Add launch of web-platform-tests server by run-webkit-httpd.
4099         Add two options to disable starting httpd and web-platform-tests servers.
4100
4101         * Scripts/run-webkit-httpd:
4102         (parse_args):
4103         (main):
4104
4105 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
4106
4107         REGRESSION(r189668): Notification tests are flakey
4108         https://bugs.webkit.org/show_bug.cgi?id=159375
4109         <rdar://problem/22760990>
4110
4111         Reviewed by Alexey Proskuryakov.
4112
4113         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
4114         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
4115         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
4116         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
4117
4118         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
4119         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
4120         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
4121         global notification ID mapping, causing the wrong notification to be investigated.
4122
4123         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
4124         manually perform this same mapping. Luckily, this object already receives callbacks every time a
4125         notification is created or destroyed. However, because this object is implemented outside WebKit,
4126         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
4127         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
4128         WebNotificationProvider can properly map between the different IDs.
4129
4130         * WebKitTestRunner/TestController.cpp:
4131         (WTR::TestController::runTestingServerLoop):
4132         (WTR::TestController::simulateWebNotificationClick):
4133         * WebKitTestRunner/WebNotificationProvider.cpp:
4134         (WTR::WebNotificationProvider::showWebNotification):
4135         (WTR::removeGlobalIDFromIDMap):
4136         (WTR::WebNotificationProvider::closeWebNotification):
4137         (WTR::WebNotificationProvider::removeNotificationManager):
4138         (WTR::WebNotificationProvider::simulateWebNotificationClick):
4139         (WTR::WebNotificationProvider::reset):
4140         * WebKitTestRunner/WebNotificationProvider.h:
4141
4142 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
4143
4144         Simplify LayoutTestRelay
4145         https://bugs.webkit.org/show_bug.cgi?id=159353
4146
4147         Reviewed by Daniel Bates.
4148
4149         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
4150         by name and runtime makes no sense.
4151         2. Removed code to create devices, webkitpy always does this in advance.
4152         3. Don't create copies of testing apps - we can install the same one into
4153         each simulator, now that we don't run multiple tester processes in a single simulator.
4154         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
4155         5. Removed code that kept testing apps alive in the background.
4156         6. Slightly updated coding style in functions that I touched.
4157
4158         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
4159         Updated for what we acually use at this point.
4160
4161         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
4162         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
4163         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
4164         (-[LTRelayController ipcIdentifier]):
4165         (-[LTRelayController processName]):
4166         (-[LTRelayController didReceiveStdoutData:]):
4167         (-[LTRelayController didCrashWithMessage:]):
4168         (-[LTRelayController installApp]):
4169         (-[LTRelayController _environmentVariables]):
4170         (-[LTRelayController launchApp]):
4171         (-[LTRelayController start]):
4172         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
4173         (-[LTRelayController uniqueAppPath]): Deleted.
4174         (-[LTRelayController uniqueAppURL]): Deleted.
4175         (-[LTRelayController uniqueAppIdentifier]): Deleted.
4176         (-[LTRelayController createUniqueApp]): Deleted.
4177         * LayoutTestRelay/LayoutTestRelay/main.m:
4178         (usage):
4179         (getRequiredStringArgument):
4180         (main):
4181         (getTestingSimDevice): Deleted.
4182         * Scripts/webkitpy/port/driver.py:
4183         (IOSSimulatorDriver.cmd_line):
4184         * WebKitTestRunner/ios/TestControllerIOS.mm:
4185         (WTR::TestController::platformInitialize):
4186         * WebKitTestRunner/ios/mainIOS.mm:
4187         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
4188         * DumpRenderTree/mac/DumpRenderTree.mm:
4189         (dumpRenderTree):
4190         (-[DumpRenderTree applicationDidEnterBackground:]):
4191
4192 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
4193
4194         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
4195         https://bugs.webkit.org/show_bug.cgi?id=159344
4196
4197         Reviewed by Alex Christensen.
4198
4199         * DumpRenderTree/CMakeLists.txt:
4200
4201 2016-07-01  Youenn Fablet  <youennf@gmail.com>
4202
4203         Add a runtime flag for DOM iterators
4204         https://bugs.webkit.org/show_bug.cgi?id=159300
4205
4206         Reviewed by Alex Christensen.
4207
4208         * DumpRenderTree/mac/DumpRenderTree.mm:
4209         (resetWebPreferencesToConsistentValues):
4210         * DumpRenderTree/win/DumpRenderTree.cpp:
4211         (resetWebPreferencesToConsistentValues):
4212         * Scripts/webkitperl/FeatureList.pm:
4213         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4214         (WTR::InjectedBundle::beginTesting):
4215         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4216         (WTR::TestRunner::setDOMIteratorEnabled):
4217         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4218
4219 2016-06-30  Tina Liu  <iting_liu@apple.com>
4220
4221         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
4222         https://bugs.webkit.org/show_bug.cgi?id=159326
4223
4224         Reviewed by Brady Eidson.
4225
4226         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4227         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
4228         (TestWebKitAPI::didFinishLoadForFrame):
4229         (TestWebKitAPI::didChangeBackForwardListForPage):
4230         (TestWebKitAPI::setPageLoaderClient):
4231         Set the page loader client and register for didFinishLoadForFrame and
4232         didChangeBackForwardList callbacks.
4233         (TestWebKitAPI::createSessionStateData):
4234         Load a webpage ("simple.html") and return the session state for this page.
4235         (TestWebKitAPI::TEST):
4236         Restore the page session state with that of "simple.html" without navigation.
4237         Verify that the committed URL is NULL since there's no navigation involved.
4238         Verify that the current item in the back forward list, which should be what
4239         we restored from the session state, has the expected URL.
4240
4241 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
4242
4243         Generators violate bytecode liveness validation
4244         https://bugs.webkit.org/show_bug.cgi?id=159279
4245
4246         Reviewed by Yusuke Suzuki.
4247         
4248         Add Basic to our test harness.
4249
4250         * Scripts/run-javascriptcore-tests:
4251         (runJSCStressTests):
4252
4253 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
4254
4255         [Win][Debug] Assertion fails in TestWTF.
4256         https://bugs.webkit.org/show_bug.cgi?id=159299
4257
4258         Reviewed by Alex Christensen.
4259
4260         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
4261         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
4262         the assertion failure. Since the variable is actually used, there is no need to use the
4263         UNUSED_PARAM macro.
4264
4265         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
4266         (TestWebKitAPI::TEST):
4267
4268 2016-06-30  Youenn Fablet  <youennf@gmail.com>
4269
4270         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
4271         https://bugs.webkit.org/show_bug.cgi?id=159166
4272         <rdar://problem/27051759>
4273
4274         Reviewed by Alexey Pr