Re-enable WinEWS test and decrease iterations before clean build back to 10.
[WebKit-https.git] / Tools / ChangeLog
1 2013-03-06  Roger Fong  <roger_fong@apple.com>
2
3         Re-enable WinEWS test and decrease iterations before clean build back to 10.
4
5         * EWSTools/start-queue-win.sh:
6         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
7         (WinEWS):
8
9 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
10
11         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
12         https://bugs.webkit.org/show_bug.cgi?id=82866
13
14         Reviewed by Martin Robinson.
15
16         * Scripts/run-gtk-tests:
17         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
18         it is passing now.
19
20 2013-03-06  Julie Parent  <jparent@chromium.org>
21
22         Dashboard cleanup: remove dashboard time logging.
23         https://bugs.webkit.org/show_bug.cgi?id=111608
24
25         Reviewed by Dirk Pranke.
26
27         Remove logTime.  It was never accurate, and the dev tools
28         have better ways to measure this if anyone cares to look
29         into dashboard perf.
30         
31         * TestResultServer/static-dashboards/dashboard_base.js:
32         * TestResultServer/static-dashboards/flakiness_dashboard.js:
33         (processTestRunsForBuilder):
34         (appendHTML):
35
36 2013-03-06  Tony Chang  <tony@chromium.org>
37
38         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
39         https://bugs.webkit.org/show_bug.cgi?id=111509
40
41         Reviewed by Dirk Pranke.
42
43         Add DumpRenderTree.pak to DumpRenderTree.app again.
44
45         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
46
47 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
48
49         [chromium] introduce WebUserGestureIndicator
50         https://bugs.webkit.org/show_bug.cgi?id=111531
51
52         Reviewed by Adam Barth.
53
54         * DumpRenderTree/chromium/WebViewHost.cpp:
55         (WebViewHost::createView):
56
57 2013-03-06  Alan Cutter  <alancutter@chromium.org>
58
59         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
60         https://bugs.webkit.org/show_bug.cgi?id=73482
61
62         Reviewed by Ryosuke Niwa.
63
64         Added input checking to the UpdateChromiumDEPS step.
65         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
66
67         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
68         (RollChromiumDEPS):
69         (RollChromiumDEPS._parse_args):
70         (RollChromiumDEPS.execute):
71         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
72         (IRCCommandTest.test_roll_chromium_deps):
73         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
74         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
75         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
76         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
77         (UpdateChromiumDEPS._fetch_last_known_good_revision):
78         (UpdateChromiumDEPS):
79         (UpdateChromiumDEPS._parse_revision_number):
80         (UpdateChromiumDEPS._validate_revisions):
81         (UpdateChromiumDEPS.run):
82         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
83         (UpdateChromiumDEPSTest):
84         (UpdateChromiumDEPSTest.test_parse_revision_number):
85         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
86         (RollChromiumDEPS):
87         (PostChromiumDEPSRoll):
88
89 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
90
91         [Qt][MiniBrowser] Touch mocking broken for chained getures
92         https://bugs.webkit.org/show_bug.cgi?id=111430
93
94         Reviewed by Jocelyn Turcotte.
95
96         Make it possible again to use touch mocking to test gesture chains
97         like pan->pinch->pan->pinch without lifting the primary "finger".
98         For this to work we need to track the pressed mouse buttons and
99         only synthesize touch release events when the ctrl key is released
100         if no mouse button is pressed. Else the pressed mouse button(s)
101         should result in a stationary touch point in a touch update event.
102         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
103         to check for the state of the ctrl key modifier instead of getting
104         it from the mouse events.
105
106         * MiniBrowser/qt/MiniBrowserApplication.cpp:
107         (MiniBrowserApplication::MiniBrowserApplication):
108         (MiniBrowserApplication::notify):
109
110 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
111
112         [chromium] don't use custom freetype on linux asan for now
113         https://bugs.webkit.org/show_bug.cgi?id=111516
114
115         Unreviewed, build fix.
116
117         Turns out the custom lib is getting picked up by other binaries
118         on our bot, which is bad.
119
120         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
121
122 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
123
124         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
125         https://bugs.webkit.org/show_bug.cgi?id=111509
126
127         Unreviewed, build fix.
128
129         Actually comment out the flag :(.
130
131         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
132
133 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
134
135         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
136         https://bugs.webkit.org/show_bug.cgi?id=111509
137
138         Unreviewed, build fix.
139
140         r144863 appears to have broken the xcode build; I'm temporarily
141         trying this instead, and if this doesn't work, I'll revert the
142         other changes.
143
144         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
145
146 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
147
148         [chromium] build a DumpRenderTree.pak even on windows
149         https://bugs.webkit.org/show_bug.cgi?id=111504
150
151         Reviewed by Tony Chang.
152
153         The Chromium Aura build uses the default theme to draw
154         controls, and that theme requires the ui ResourceBundle
155         to be initialized. On every other platform, we build
156         a DumpRenderTree.pak that works for this, but on Windows we
157         still compile the resources directly into DRT. As a first step,
158         let's build the pak file. I will then need to land a patch
159         in Chromium to actually load it. Then I can go back and move
160         the resources over to just use the .pak file and no longer need
161         the .rc's.
162
163         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
164
165 2013-03-05  Julie Parent  <jparent@chromium.org>
166         Dashboard cleanup: move string utilities into their own namespace.
167         
168         https://bugs.webkit.org/show_bug.cgi?id=111485
169
170         Reviewed by Ojan Vafai.
171         
172         One of many pieces to clean up dashboard_base.
173         
174         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
175
176         * TestResultServer/static-dashboards/aggregate_results.html:
177         * TestResultServer/static-dashboards/dashboard_base.js:
178         (isTreeMap):
179         (isFlakinessDashboard):
180         * TestResultServer/static-dashboards/flakiness_dashboard.html:
181         * TestResultServer/static-dashboards/flakiness_dashboard.js:
182         (determineWKPlatform):
183         (chromiumPlatform):
184         (platformAndBuildType):
185         (substringList):
186         (individualTestsForSubstringList):
187         (filterBugs):
188         (populateExpectationsData):
189         (processMissingTestsWithExpectations):
190         (processMissingAndExtraExpectations):
191         (htmlForSingleTestRow):
192         (.dummyNode.onload):
193         (expectationsTitle):
194         * TestResultServer/static-dashboards/run-embedded-unittests.html:
195         * TestResultServer/static-dashboards/run-unittests.html:
196         * TestResultServer/static-dashboards/string.js: Added.
197         * TestResultServer/static-dashboards/timeline_explorer.html:
198         * TestResultServer/static-dashboards/treemap.html:
199
200 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
201
202         [EFL] Build break with latest EFL libraries
203         https://bugs.webkit.org/show_bug.cgi?id=111028
204
205         Reviewed by Dirk Pranke.
206
207         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
208         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
209         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
210
211 2013-03-05  Roger Fong  <roger_fong@apple.com>
212
213         Increase number of WinEWS iterations to 20.
214         Don't reboot after each iteration set.
215         Make EWS bots just build temporarily so that the queue catches up again.
216
217         * EWSTools/start-queue-win.sh:
218         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
219         (WinEWS):
220
221 2013-03-04  James Robinson  <jamesr@chromium.org>
222
223         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
224         https://bugs.webkit.org/show_bug.cgi?id=111386
225
226         Reviewed by Adrienne Walker.
227
228         * DumpRenderTree/chromium/TestShell.cpp:
229         (TestShell::initialize):
230
231 2013-03-05  Min Qin  <qinmin@chromium.org>
232
233         Copy dictionary to the external storage before running layout test on android
234         https://bugs.webkit.org/show_bug.cgi?id=111480
235
236         Reviewed by Adam Barth.
237
238         TestWebKitPlatformSupport now needs to read an external dictionary file.
239         This file does not exist on the device. We need to copy it before running layout tests.
240
241         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
242         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
243         (ChromiumAndroidDriver._push_platform_resources):
244
245 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
246
247         [chromium] DRT crashes in an Aura/Win build
248         https://bugs.webkit.org/show_bug.cgi?id=111394
249
250         Reviewed by Tony Chang.
251
252         When building (and running) with use_aura=1, we assume that
253         we're using the default theme engine, but DRT creates the
254         DRTWin theme engine and overwrites the default, leading to crashes
255         in basically every test from the mismatch.
256
257         This fix gets us down to at least "lots of crashes" :).
258
259         * DumpRenderTree/chromium/TestShellWin.cpp:
260         (platformInit):
261
262 2013-03-05  Eric Seidel  <eric@webkit.org>
263
264         Add html-parser-threaded perf test now that the threaded parser is enabled by default
265         https://bugs.webkit.org/show_bug.cgi?id=111200
266
267         Reviewed by Ryosuke Niwa.
268
269         Had to teach run-perf-tests to ignore one more warning.
270
271         * Scripts/webkitpy/performance_tests/perftest.py:
272         (PerfTest):
273
274 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
275
276         Update list of builders for test results server
277         https://bugs.webkit.org/show_bug.cgi?id=111166
278
279         Reviewed by Ojan Vafai.
280
281         * TestResultServer/static-dashboards/builders.jsonp:
282
283 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
284
285         [GTK] Move basic dependency installation to a script
286         https://bugs.webkit.org/show_bug.cgi?id=110692
287
288         Reviewed by Gustavo Noronha Silva.
289
290         * gtk/install-dependencies: Added. A Script which installs all dependencies
291         necessary for building for Debian-based distributions and Fedora.
292
293 2013-03-05  James Robinson  <jamesr@chromium.org>
294
295         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
296         https://bugs.webkit.org/show_bug.cgi?id=111440
297
298         Reviewed by Adrienne Walker.
299
300         Remove unnecessary WebCompositorSupport::shutdown call
301
302         * DumpRenderTree/chromium/DumpRenderTree.cpp:
303         (main):
304
305 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
306
307         Unreviewed build fix.
308
309         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
310
311 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
312
313         [Qt][MiniBrowser] Improve the update of touch indicators
314         https://bugs.webkit.org/show_bug.cgi?id=111429
315
316         Reviewed by Jocelyn Turcotte.
317
318         MiniBrowserApplication::sendTouchEvent sends an empty list
319         to BrowserWindow::updateVisualMockTouchPoints if the control
320         button is released, in which case the touch indicators should
321         be hidden so that we never end up with a leftover indicator
322         sticking on the screen.
323         This patch also simplifies the lookup of the indicator items by
324         replacing the findChild search in the item tree with a QHash
325         that stores the touch ID's and the pointers to the corresponding
326         indicator items.
327
328         * MiniBrowser/qt/BrowserWindow.cpp:
329         (BrowserWindow::updateVisualMockTouchPoints):
330         * MiniBrowser/qt/BrowserWindow.h:
331         (BrowserWindow):
332
333 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
334
335         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
336         https://bugs.webkit.org/show_bug.cgi?id=81042
337
338         Reviewed by Enrica Casucci.
339
340         Add setAsynchronousSpellCheckingEnabled implementation for
341         WebKitTestRunner to have the possibility to test asynchronous
342         spell checking implementation from bug 109577.
343
344         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
345         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
346         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
347         * WebKitTestRunner/InjectedBundle/TestRunner.h:
348         * WebKitTestRunner/TestController.cpp:
349         (WTR::TestController::resetStateToConsistentValues):
350
351 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
352
353         MediaStream API: Add the getStreamById method on RTCPeerConnection
354         https://bugs.webkit.org/show_bug.cgi?id=111311
355
356         Reviewed by Adam Barth.
357
358         Changing mocks to be more realistic.
359
360         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
361         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
362         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
363         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
364         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
365
366 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
367
368         Add content shell bots to garden-o-matic for general failurse
369         https://bugs.webkit.org/show_bug.cgi?id=111168
370
371         Reviewed by Adam Barth.
372
373         All but the WebKit (Content Shell) Android bot is stable enough. While
374         they're not green yet, there must not be any non-layout test failures on
375         them.
376
377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
378         (.):
379
380 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
381
382         [chromium] remove deprecated WebTestRunner::setFocus API
383         https://bugs.webkit.org/show_bug.cgi?id=111354
384
385         Reviewed by James Robinson.
386
387         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
388         (WebTestDelegate):
389
390 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
391
392         Run the bindings generation tests on EWS and CQ bots
393         https://bugs.webkit.org/show_bug.cgi?id=111358
394
395         Reviewed by Adam Barth.
396
397         The tests are super fast and not flaky.
398
399         * Scripts/webkitpy/common/config/ports.py:
400         (DeprecatedPort.run_bindings_tests_command):
401         * Scripts/webkitpy/common/config/ports_mock.py:
402         (MockPort.run_webkit_tests_command):
403         (MockPort):
404         (MockPort.run_bindings_tests_command):
405         * Scripts/webkitpy/tool/commands/download_unittest.py:
406         * Scripts/webkitpy/tool/steps/runtests.py:
407         (RunTests.run):
408         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
409         (RunTestsTest.test_webkit_run_unit_tests):
410         * Scripts/webkitpy/tool/steps/steps_unittest.py:
411
412 2013-03-04  Eric Seidel  <eric@webkit.org>
413
414         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
415         https://bugs.webkit.org/show_bug.cgi?id=111384
416
417         Reviewed by Ryosuke Niwa.
418
419         Sometimes I want to know why various LayoutTests are slow
420         without having to convert them into PerformanceTests in order
421         to use our fancy profiling.  The Driver already knows how to
422         do the right thing, we just need to expose the options to the user.
423
424         Handling of these options is already unittested in the perftests_unittest.
425
426         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
427         (parse_args):
428
429 2013-03-04  Alan Cutter  <alancutter@chromium.org>
430
431         check-webkit-style says "Have to enable auto props in the subversion config file"
432         https://bugs.webkit.org/show_bug.cgi?id=107724
433
434         Reviewed by Tony Chang.
435
436         Added a standard svn config file for WebKit developers to use.
437         Updated the style and commit queue bot build scripts to load this file.
438
439         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
440         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
441         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
442         * svn-config: Added.
443
444 2013-03-04  James Robinson  <jamesr@chromium.org>
445
446         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
447         https://bugs.webkit.org/show_bug.cgi?id=111285
448
449         Reviewed by Adrienne Walker.
450
451         This removes the need for WebCompositorSupport::initialize and exposes
452         slightly fewer entry points across the repository boundary.
453
454         * DumpRenderTree/chromium/TestShell.cpp:
455         (TestShell::initialize):
456         * DumpRenderTree/chromium/TestShell.h:
457         (TestShell::webCompositorThread):
458         (TestShell):
459         * DumpRenderTree/chromium/WebViewHost.cpp:
460         (WebViewHost::initializeLayerTreeView):
461
462 2013-03-04  Roger Fong  <roger_fong@apple.com>
463
464         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
465
466         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
467
468 2013-03-04  David Kilzer  <ddkilzer@apple.com>
469
470         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
471
472             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
473                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
474                                         ^         ~~~~~~~~~~~~~~~~~~~~~
475             1 error generated.
476
477         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
478         AccessibilityCommonMac.h.
479
480 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
481
482         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
483         https://bugs.webkit.org/show_bug.cgi?id=109828
484
485         Reviewed by Kenneth Rohde Christiansen.
486
487         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
488         callbacks.
489
490         * TestWebKitAPI/CMakeLists.txt:
491
492             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
493             considered.
494
495         * TestWebKitAPI/PlatformEfl.cmake:
496         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
497         (TestWebKitAPI):
498         (TestWebKitAPI::didFinishLoadForFrame):
499         (TestWebKitAPI::setPageLoaderClient):
500         (TestWebKitAPI::webProcessCrashed):
501         (TestWebKitAPI::webProcessDidRelaunch):
502         (TestWebKitAPI::setViewClient):
503         (TestWebKitAPI::TEST):
504
505 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
506
507         AX: Upstream iOS Accessibility DumpRenderTree changes
508         https://bugs.webkit.org/show_bug.cgi?id=111220
509
510         Reviewed by David Kilzer.
511
512         Upstream the iOS changes for accessibility in DumpRenderTree.
513
514         * DumpRenderTree/AccessibilityUIElement.cpp:
515         (headerElementAtIndexCallback):
516         (linkedElementCallback):
517         (elementsForRangeCallback):
518         (increaseTextSelectionCallback):
519         (decreaseTextSelectionCallback):
520         (assistiveTechnologySimulatedFocusCallback):
521         (stringForSelectionCallback):
522         (getIPhoneLabelCallback):
523         (getIPhoneHintCallback):
524         (getIPhoneValueCallback):
525         (getIPhoneIdentifierCallback):
526         (getIPhoneTraitsCallback):
527         (getIPhoneIsElementCallback):
528         (getIPhoneElementTextPositionCallback):
529         (getIPhoneElementTextLengthCallback):
530         (AccessibilityUIElement::getJSClass):
531         * DumpRenderTree/AccessibilityUIElement.h:
532         (AccessibilityUIElement):
533         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
534         * DumpRenderTree/ios: Added.
535         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
536         (AccessibilityController::AccessibilityController):
537         (AccessibilityController::~AccessibilityController):
538         (AccessibilityController::elementAtPoint):
539         (AccessibilityController::focusedElement):
540         (AccessibilityController::rootElement):
541         (findAccessibleObjectById):
542         (AccessibilityController::accessibleElementById):
543         (AccessibilityController::setLogFocusEvents):
544         (AccessibilityController::setLogScrollingStartEvents):
545         (AccessibilityController::setLogValueChangeEvents):
546         (AccessibilityController::setLogAccessibilityEvents):
547         (AccessibilityController::addNotificationListener):
548         (AccessibilityController::removeNotificationListener):
549         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
550         (AccessibilityUIElement::AccessibilityUIElement):
551         (AccessibilityUIElement::~AccessibilityUIElement):
552         (concatenateAttributeAndValue):
553         (AccessibilityUIElement::iphoneLabel):
554         (AccessibilityUIElement::iphoneHint):
555         (AccessibilityUIElement::iphoneValue):
556         (AccessibilityUIElement::iphoneIdentifier):
557         (AccessibilityUIElement::iphoneTraits):
558         (AccessibilityUIElement::iphoneIsElement):
559         (AccessibilityUIElement::iphoneElementTextPosition):
560         (AccessibilityUIElement::iphoneElementTextLength):
561         (AccessibilityUIElement::url):
562         (AccessibilityUIElement::x):
563         (AccessibilityUIElement::y):
564         (AccessibilityUIElement::width):
565         (AccessibilityUIElement::height):
566         (AccessibilityUIElement::clickPointX):
567         (AccessibilityUIElement::clickPointY):
568         (AccessibilityUIElement::getChildren):
569         (AccessibilityUIElement::getChildrenWithRange):
570         (AccessibilityUIElement::childrenCount):
571         (AccessibilityUIElement::elementAtPoint):
572         (AccessibilityUIElement::indexOfChild):
573         (AccessibilityUIElement::getChildAtIndex):
574         (AccessibilityUIElement::headerElementAtIndex):
575         (AccessibilityUIElement::linkedElement):
576         (AccessibilityUIElement::linkedUIElementAtIndex):
577         (AccessibilityUIElement::ariaOwnsElementAtIndex):
578         (AccessibilityUIElement::ariaFlowToElementAtIndex):
579         (AccessibilityUIElement::disclosedRowAtIndex):
580         (AccessibilityUIElement::selectedRowAtIndex):
581         (AccessibilityUIElement::rowAtIndex):
582         (AccessibilityUIElement::titleUIElement):
583         (AccessibilityUIElement::parentElement):
584         (AccessibilityUIElement::disclosedByRow):
585         (AccessibilityUIElement::increaseTextSelection):
586         (AccessibilityUIElement::decreaseTextSelection):
587         (AccessibilityUIElement::stringForSelection):
588         (AccessibilityUIElement::stringForRange):
589         (AccessibilityUIElement::attributedStringForRange):
590         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
591         (AccessibilityUIElement::elementsForRange):
592         (AccessibilityUIElement::getLinkedUIElements):
593         (AccessibilityUIElement::getDocumentLinks):
594         (AccessibilityUIElement::attributesOfLinkedUIElements):
595         (AccessibilityUIElement::attributesOfDocumentLinks):
596         (AccessibilityUIElement::attributesOfChildren):
597         (AccessibilityUIElement::allAttributes):
598         (AccessibilityUIElement::stringAttributeValue):
599         (AccessibilityUIElement::isPressActionSupported):
600         (AccessibilityUIElement::isIncrementActionSupported):
601         (AccessibilityUIElement::isDecrementActionSupported):
602         (AccessibilityUIElement::boolAttributeValue):
603         (AccessibilityUIElement::isAttributeSettable):
604         (AccessibilityUIElement::isAttributeSupported):
605         (AccessibilityUIElement::parameterizedAttributeNames):
606         (AccessibilityUIElement::role):
607         (AccessibilityUIElement::subrole):
608         (AccessibilityUIElement::roleDescription):
609         (AccessibilityUIElement::title):
610         (AccessibilityUIElement::description):
611         (AccessibilityUIElement::orientation):
612         (AccessibilityUIElement::stringValue):
613         (AccessibilityUIElement::language):
614         (AccessibilityUIElement::helpText):
615         (AccessibilityUIElement::intValue):
616         (AccessibilityUIElement::minValue):
617         (AccessibilityUIElement::maxValue):
618         (AccessibilityUIElement::valueDescription):
619         (AccessibilityUIElement::insertionPointLineNumber):
620         (AccessibilityUIElement::isEnabled):
621         (AccessibilityUIElement::isRequired):
622         (AccessibilityUIElement::isFocused):
623         (AccessibilityUIElement::isSelected):
624         (AccessibilityUIElement::isExpanded):
625         (AccessibilityUIElement::isChecked):
626         (AccessibilityUIElement::hierarchicalLevel):
627         (AccessibilityUIElement::ariaIsGrabbed):
628         (AccessibilityUIElement::ariaDropEffects):
629         (AccessibilityUIElement::lineForIndex):
630         (AccessibilityUIElement::boundsForRange):
631         (AccessibilityUIElement::attributesOfColumnHeaders):
632         (AccessibilityUIElement::attributesOfRowHeaders):
633         (AccessibilityUIElement::attributesOfColumns):
634         (AccessibilityUIElement::attributesOfRows):
635         (AccessibilityUIElement::attributesOfVisibleCells):
636         (AccessibilityUIElement::attributesOfHeader):
637         (AccessibilityUIElement::rowCount):
638         (AccessibilityUIElement::columnCount):
639         (AccessibilityUIElement::indexInTable):
640         (AccessibilityUIElement::rowIndexRange):
641         (AccessibilityUIElement::columnIndexRange):
642         (AccessibilityUIElement::cellForColumnAndRow):
643         (AccessibilityUIElement::selectedTextRange):
644         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
645         (AccessibilityUIElement::setSelectedTextRange):
646         (AccessibilityUIElement::increment):
647         (AccessibilityUIElement::decrement):
648         (AccessibilityUIElement::showMenu):
649         (AccessibilityUIElement::press):
650         (AccessibilityUIElement::accessibilityValue):
651         (AccessibilityUIElement::documentEncoding):
652         (AccessibilityUIElement::documentURI):
653         (_accessibilityNotificationCallback):
654         (AccessibilityUIElement::addNotificationListener):
655         (AccessibilityUIElement::removeNotificationListener):
656         (AccessibilityUIElement::isFocusable):
657         (AccessibilityUIElement::isSelectable):
658         (AccessibilityUIElement::isMultiSelectable):
659         (AccessibilityUIElement::isSelectedOptionActive):
660         (AccessibilityUIElement::isVisible):
661         (AccessibilityUIElement::isOffScreen):
662         (AccessibilityUIElement::isCollapsed):
663         (AccessibilityUIElement::isIgnored):
664         (AccessibilityUIElement::hasPopup):
665         (AccessibilityUIElement::takeFocus):
666         (AccessibilityUIElement::takeSelection):
667         (AccessibilityUIElement::addSelection):
668         (AccessibilityUIElement::removeSelection):
669         (AccessibilityUIElement::uiElementForSearchPredicate):
670         (AccessibilityUIElement::numberAttributeValue):
671
672 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
673
674         [chromium] pass all focus handling methods through the WebTestDelegate
675         https://bugs.webkit.org/show_bug.cgi?id=111328
676
677         Reviewed by Nico Weber.
678
679         In content_shell, the focus handling is asynchronous. To allow for
680         switching the focus synchronously between WebViews, we need to intercept
681         didFocus and didBlur and forward it to the WebTestDelegate.
682
683         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
684         (WebTestDelegate):
685         (WebTestRunner::WebTestDelegate::setFocus):
686         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
687         (WebTestRunner::WebTestProxy::didFocus):
688         (WebTestRunner::WebTestProxy::didBlur):
689         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
690         (WebTestRunner::TestRunner::setWindowIsKey):
691         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
692         (WebTestRunner::WebTestProxyBase::didFocus):
693         (WebTestRunner):
694         (WebTestRunner::WebTestProxyBase::didBlur):
695         * DumpRenderTree/chromium/WebViewHost.cpp:
696         (WebViewHost::didFocus):
697         (WebViewHost::didBlur):
698         (WebViewHost::setFocus):
699         * DumpRenderTree/chromium/WebViewHost.h:
700         (WebViewHost):
701
702 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
703
704         [GTK] No need to manually add system paths to jhbuildrc
705         https://bugs.webkit.org/show_bug.cgi?id=110850
706
707         Reviewed by Gustavo Noronha Silva.
708
709         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
710         already takes care of.
711
712 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
713
714         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
715         https://bugs.webkit.org/show_bug.cgi?id=111284
716
717         Disabling the failing two tests on Android.
718
719         Reviewed by Jochen Eisinger.
720
721         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
722         (TestWebKitAPI):
723         (TestWebKitAPI::TEST):
724
725 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
726
727         Add build flag for FontLoader
728         https://bugs.webkit.org/show_bug.cgi?id=111289
729
730         Reviewed by Benjamin Poulain.
731
732         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
733
734         * Scripts/webkitperl/FeatureList.pm:
735         * qmake/mkspecs/features/features.pri:
736
737 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
738
739         [Mac] Get rid of a useless method from DOMHTMLInputElement
740         https://bugs.webkit.org/show_bug.cgi?id=111279
741
742         Reviewed by Sam Weinig.
743
744         * DumpRenderTree/mac/TestRunnerMac.mm:
745         (TestRunner::setValueForUser):
746         The method _setValueForUser: was added for testing. This feature is already
747         exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
748         in real use cases. Get rid of the method created for testing, use the real thing
749         instead.
750
751 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
752
753         Some perf. tests have variances that differ greatly between runs
754         https://bugs.webkit.org/show_bug.cgi?id=97510
755
756         Reviewed by Benjamin Poulain.
757
758         Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
759         environment on test results (we run each instance after one another, not in parallel).
760
761         We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
762         iterations as it was done previously in single process. These values are hard-coded in perftest.py
763         and runner.js but they are to be configurable in the future.
764
765         Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
766         metric now reports an array of the length 4 with each element containing an array of 5 iteration
767         values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
768
769         Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
770         and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
771         as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
772
773         * Scripts/webkitpy/performance_tests/perftest.py:
774         (PerfTestMetric.append_group): Renamed from append.
775         (PerfTestMetric.grouped_iteration_values): Added.
776         (PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
777
778         (PerfTest.__init__): Takes the number of processes (drivers) to run tests with.
779         This parameter is only used by SingleProcessPerfTest.
780
781         (PerfTest.run): Repeat tests using different driver processes.
782         (PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
783         since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
784         We instead use _ensure_metrics to obtain the matched metrics and store the data there.
785         (PerfTest._ensure_metrics): Added.
786
787         (SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
788         instances of DumpRenderTree/WebKitTestRunner takes too long.
789         (SingleProcessPerfTest.__init__):
790
791         (ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
792
793         (PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
794
795         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
796         _run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
797         the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
798
799         (TestPerfTestMetric.test_append): Updated per name and added some test cases for
800         grouped_iteration_values.
801
802         (TestPerfTest._assert_results_are_correct):
803
804         (TestSingleProcessPerfTest): Added.
805         (TestSingleProcessPerfTest.test_use_only_one_process):
806         (TestSingleProcessPerfTest.test_use_only_one_process.run_single):
807
808         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
809         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
810
811         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
812         sample standard deviations since we're now running tests 4 times.
813         (MainTest._test_run_with_json_output.mock_upload_json):
814         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
815
816 2013-03-03  Alexandre Elias  <aelias@chromium.org>
817
818         [chromium] Remove WebLayerTreeView::setViewportSize call
819         https://bugs.webkit.org/show_bug.cgi?id=110727
820
821         Reviewed by James Robinson.
822
823         After https://codereview.chromium.org/12328080 lands,
824         setViewportSize is called from the Chromium side. The multiplication
825         by deviceScaleFactor here was prone to off-by-one errors.
826         The layoutSize() function was only used here so delete it as well.
827
828         DumpRenderTree WebViewHost must now call this method as well.
829
830         * DumpRenderTree/chromium/WebViewHost.cpp:
831         (WebViewHost::initializeLayerTreeView):
832         (WebViewHost::setWindowRect):
833         (WebViewHost::setDeviceScaleFactor):
834         (WebViewHost::updateViewportSize):
835         * DumpRenderTree/chromium/WebViewHost.h:
836         (WebViewHost):
837
838 2013-02-27  Darin Adler  <darin@apple.com>
839
840         StringHasher functions require alignment that call sites do not all guarantee
841         https://bugs.webkit.org/show_bug.cgi?id=110171
842
843         Reviewed by Benjamin Poulain.
844
845         * TestWebKitAPI/CMakeLists.txt:
846         * TestWebKitAPI/GNUmakefile.am:
847         * TestWebKitAPI/TestWebKitAPI.gypi:
848         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
849         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
851         * TestWebKitAPI/Tests/WTF/WTF.pro:
852         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
853         Added the StringHasher.cpp file.
854
855         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
856         for the functions in the StringHasher class.
857
858 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
859
860         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
861         https://bugs.webkit.org/show_bug.cgi?id=109772
862
863         Reviewed by Andreas Kling.
864
865         * DumpRenderTree/TestRunner.cpp:
866         (TestRunner::staticFunctions):
867         * DumpRenderTree/TestRunner.h:
868         (TestRunner):
869         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
870         * DumpRenderTree/efl/TestRunnerEfl.cpp:
871         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
872         * DumpRenderTree/mac/TestRunnerMac.mm:
873         * DumpRenderTree/qt/TestRunnerQt.cpp:
874         * DumpRenderTree/qt/TestRunnerQt.h:
875         (TestRunner):
876         * DumpRenderTree/win/TestRunnerWin.cpp:
877         * DumpRenderTree/wx/TestRunnerWx.cpp:
878         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
879         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
880         * WebKitTestRunner/InjectedBundle/TestRunner.h:
881         (TestRunner):
882
883 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
884
885         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
886         https://bugs.webkit.org/show_bug.cgi?id=110943
887
888         Reviewed by Yury Semikhatsky.
889
890         Unfortunately in many cases raw pointer may point to an object that has been deleted.
891         There is no working solution to solve this problem in general.
892         It could be solved only on case by case basis.
893
894         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
895         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
896         (TestWebKitAPI::TEST):
897
898 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
899
900         Move markerTextForListItem from TestRunner to Internals
901         https://bugs.webkit.org/show_bug.cgi?id=110939
902
903         Reviewed by Benjamin Poulain.
904
905         * DumpRenderTree/TestRunner.cpp:
906         (TestRunner::staticFunctions):
907         * DumpRenderTree/TestRunner.h:
908         (TestRunner):
909         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
910         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
911         (WebTestRunner::TestRunner::TestRunner):
912         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
913         (TestRunner):
914         * DumpRenderTree/efl/TestRunnerEfl.cpp:
915         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
916         * DumpRenderTree/mac/TestRunnerMac.mm:
917         * DumpRenderTree/qt/TestRunnerQt.cpp:
918         * DumpRenderTree/qt/TestRunnerQt.h:
919         (TestRunnerQt):
920         * DumpRenderTree/win/TestRunnerWin.cpp:
921         * DumpRenderTree/wx/TestRunnerWx.cpp:
922         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
923         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
924         * WebKitTestRunner/InjectedBundle/TestRunner.h:
925         (TestRunner):
926
927 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
928
929         Don't use legacy test names when returning results from PerfTest.run
930         https://bugs.webkit.org/show_bug.cgi?id=111148
931
932         Reviewed by Dirk Pranke.
933
934         * Scripts/webkitpy/performance_tests/perftest.py:
935         (PerfTestMetric.name): Renamed from metric.
936         (PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
937         (PerfTest.run): Use metric name instead of the legacy name to store iteration values.
938         (ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
939
940         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
941         (TestPerfTestMetric.test_init_set_time_metric):
942         (TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
943         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
944         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
945
946         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
947         (PerfTestsRunner.__init__):
948         (PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
949         to obtain the trac URL instead of hard coding it.
950         (PerfTestsRunner._run_tests_set):
951
952 2013-03-01  Roger Fong  <roger_fong@apple.com>
953
954         Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
955         https://bugs.webkit.org/show_bug.cgi?id=111202
956
957         This is useful for running VCExpress builds from command line because there is
958         no unified solution output, only per project build logs.
959         The project will be run as the last project in the solution.
960
961         * win/AssembleBuildLogs: Added.
962         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
963         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
964         * win/AssembleBuildLogs/AssembleLogs.cmd: Added.
965         * win/AssembleBuildLogs/README: Added.
966
967 2013-03-01  Roger Fong  <roger_fong@apple.com>
968
969         Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
970
971         * EWSTools/start-queue-win.sh:
972
973 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
974
975         Don't return statistics in PerfTest.run
976         https://bugs.webkit.org/show_bug.cgi?id=111145
977
978         Reviewed by Dirk Pranke.
979
980         Simply return a list of values obtained in each iteration from PerfTest.run.
981         Also simplify various methods as needed.
982
983         * Scripts/webkitpy/performance_tests/perftest.py:
984         (PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
985         as needed from PerfTestsRunner._generate_results_dict.
986
987         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
988         that we don't have to worry about the backward compatibility here.
989
990         (PerfTestMetric.iteration_values): Added.
991         (PerfTestMetric.unit): Added.
992         (PerfTestMetric.metric_to_unit):
993         (PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
994
995         (PerfTest.run):
996         (PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
997
998         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
999         (TestPerfTestMetric.test_init_set_missing_unit):
1000         (TestPerfTestMetric.test_init_set_time_metric): Added.
1001         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
1002         (TestPerfTestMetric.test_append):
1003         (TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
1004         test cases and it's not critical to keep math right as they're not used in output JSON anymore.
1005         (TestPerfTest._assert_results_are_correct):
1006         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1007         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1008
1009         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1010         (PerfTestsRunner._generate_results_dict):
1011
1012         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1013         (EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
1014         (SomeParserTestData): Ditto.
1015         (MemoryTestData): Ditto.
1016
1017 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1018
1019         [Qt] Enable LINK_PREFETCH
1020         https://bugs.webkit.org/show_bug.cgi?id=111158
1021
1022         Reviewed by Simon Hausmann.
1023
1024         * qmake/mkspecs/features/features.pri:
1025
1026 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1027
1028         [Qt] Update features.pri with new features
1029         https://bugs.webkit.org/show_bug.cgi?id=111157
1030
1031         Reviewed by Jocelyn Turcotte.
1032
1033         * qmake/mkspecs/features/features.pri:
1034
1035 2013-03-01  Jochen Eisinger  <jochen@chromium.org>
1036
1037         [chromium] put WebTestProxy::scheduleComposite back in place
1038         https://bugs.webkit.org/show_bug.cgi?id=111146
1039
1040         Reviewed by Nico Weber.
1041
1042         The call was removed in http://trac.webkit.org/changeset/144398 because
1043         DRT doesn't need it. However, content shell depends on this call.
1044
1045         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1046         (WebTestRunner::WebTestProxy::scheduleComposite):
1047
1048 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1049
1050         Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
1051         https://bugs.webkit.org/show_bug.cgi?id=111142
1052
1053         Reviewed by Adam Barth.
1054
1055         Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
1056
1057         Also removed _print_status since it's never used anywhere.
1058
1059         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1060         (PerfTestsRunner.run):
1061         (PerfTestsRunner._run_tests_set):
1062         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1063         (MainTest.run_test):
1064         (MainTest.test_run_test_set):
1065         (MainTest.test_run_test_set_kills_drt_per_run):
1066         (MainTest.test_run_test_set_for_parser_tests):
1067
1068 2013-02-28  Kiran Muppala  <cmuppala@apple.com>
1069
1070         Disable window occlusion detection for WebKitTestRunner Web View on Mac
1071         https://bugs.webkit.org/show_bug.cgi?id=111116
1072
1073         Reviewed by Simon Fraser.
1074
1075         Window occlusion notifications were causing WebKitTestRunner's Web View
1076         to be detected as occluded and causing a few JavaScript timer layout
1077         tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
1078         by initializing the page visibility to "visible" after creating the view.
1079         But a better solution is to disable window occlusion detection, so that
1080         not only the page but also the view is treated as visible.
1081
1082         * WebKitTestRunner/TestController.cpp:
1083         (WTR::TestController::createWebViewWithOptions): Remove call to
1084         setVisibilityState, since it is no longer necessary.
1085         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1086         (WTR::PlatformWebView::PlatformWebView): Disable window occlusion
1087         detection for the created WKView.
1088
1089 2013-02-28  Li Yin  <li.yin@intel.com>
1090
1091         [chromium] Events can't be triggered on MediaStreamTrack
1092         https://bugs.webkit.org/show_bug.cgi?id=110930
1093
1094         Reviewed by Kentaro Hara.
1095
1096         Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
1097
1098         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
1099         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
1100
1101 2013-02-27  James Robinson  <jamesr@chromium.org>
1102
1103         [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
1104         https://bugs.webkit.org/show_bug.cgi?id=111017
1105
1106         Reviewed by Adam Barth.
1107
1108         This decouples DumpRenderTree from WebLayerTreeViewClient.
1109
1110         * DumpRenderTree/chromium/WebViewHost.cpp:
1111         (WebViewHostDRTLayerTreeViewClient):
1112         (WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
1113         (WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
1114         (WebViewHostDRTLayerTreeViewClient::Layout):
1115         (WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
1116         (WebViewHost::initializeLayerTreeView):
1117         * DumpRenderTree/chromium/WebViewHost.h:
1118         (webkit_support):
1119         (WebViewHost):
1120
1121 2013-02-28  Ryuan Choi  <ryuan.choi@samsung.com>
1122
1123         Unreviewed, add my secondary email address to the list.
1124
1125         * Scripts/webkitpy/common/config/committers.py:
1126
1127 2013-02-28  Philip Rogers  <pdr@google.com>
1128
1129         Add Philip Rogers as a reviewer.
1130
1131         Unreviewed update of committers.py.
1132
1133         * Scripts/webkitpy/common/config/committers.py:
1134
1135 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1136
1137         Merge more methods on PerfTest
1138         https://bugs.webkit.org/show_bug.cgi?id=111030
1139
1140         Reviewed by Dirk Pranke.
1141
1142         Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
1143         and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
1144
1145         This makes the control flow a lot more comprehensible.
1146
1147         * Scripts/webkitpy/performance_tests/perftest.py:
1148         (PerfTest._run_with_driver):
1149         (PerfTest._should_ignore_line):
1150         (PerfTest._filter_output):
1151
1152         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1153         (TestPerfTest._assert_results_are_correct):
1154         (test_ignored_stderr_lines):
1155
1156 2013-02-28  Robert Hogan  <robert@webkit.org>
1157
1158         Update my IRC nick
1159
1160         Unreviewed.
1161
1162         * Scripts/webkitpy/common/config/committers.py:
1163
1164 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1165
1166         [Qt] Enable thin archives before parsing the project files
1167
1168         Rubber-stamped by Simon Hausmann.
1169
1170         The targetSubDir() function can be called before default_post.prf has been
1171         parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
1172         which is parsed before the main project file.
1173         This issue was revealed by r144299 and fixes the clean build.
1174
1175         * qmake/mkspecs/features/default_post.prf:
1176         * qmake/mkspecs/features/default_pre.prf:
1177
1178 2013-02-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1179
1180         [Qt] Enable CANVAS_PATH flag
1181         https://bugs.webkit.org/show_bug.cgi?id=108508
1182
1183         Reviewed by Simon Hausmann.
1184
1185         Also enable CANVAS_PATH flag for Qt.
1186
1187         * qmake/mkspecs/features/features.pri:
1188
1189 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1190
1191         [Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
1192
1193         Rubber-stamped by Csaba Osztrogonác.
1194
1195         Besides suppressing a warning about the non-existing function this
1196         fixes the build if there is a subdirectory (eg. debug-and-release).
1197
1198         * TestWebKitAPI/InjectedBundle.pri:
1199         * TestWebKitAPI/TestWebKitAPI.pri:
1200
1201 2013-02-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1202
1203         [EFL][WTR] WTR cannot load injected bundle
1204         https://bugs.webkit.org/show_bug.cgi?id=111063
1205
1206         Reviewed by Csaba Osztrogonác.
1207
1208         WTR was not able to load injected bundle because of undefined 
1209         symbols for AccessibilityUIElement::scrollToMakeVisible(). 
1210         Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
1211         solves the problem.
1212
1213         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1214         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1215
1216 2013-02-28  Alberto Garcia  <albgarcia@rim.com>
1217
1218         [BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
1219         https://bugs.webkit.org/show_bug.cgi?id=110464
1220
1221         Reviewed by Rob Buis.
1222
1223         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1224
1225 2013-02-28  Xan Lopez  <xlopez@rim.com>
1226
1227         [BlackBerry] DumpRenderTreeSupport: update the set position methods
1228         https://bugs.webkit.org/show_bug.cgi?id=110578
1229
1230         Reviewed by Rob Buis.
1231
1232         TestRunner::setMockGeolocationPosition() changed in r130416:
1233         http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
1234
1235         DumpRenderTreeSupport::setMockGeolocationError() was renamed to
1236         setMockGeolocationPositionUnavailableError() in r129444:
1237         http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
1238
1239         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1240         (TestRunner::setMockGeolocationPosition):
1241         (TestRunner::setMockGeolocationPositionUnavailableError):
1242
1243 2013-02-28  Xan Lopez  <xlopez@rim.com>
1244
1245         [BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
1246         https://bugs.webkit.org/show_bug.cgi?id=110465
1247
1248         Reviewed by Rob Buis.
1249
1250         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1251         (LoadItem::invoke):
1252
1253 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1254
1255         PerfTestRunner doesn't need _needs_http and _has_http_lock
1256         https://bugs.webkit.org/show_bug.cgi?id=111037
1257
1258         Reviewed by Adam Barth.
1259
1260         Delete these variables in favor of using a local variable.
1261
1262         Member variables are like global variables. They introduce implicit dependencies
1263         between member functions.
1264
1265         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1266         (PerfTestsRunner.__init__):
1267         (PerfTestsRunner._start_http_servers):
1268         (PerfTestsRunner):
1269         (PerfTestsRunner._stop_http_servers):
1270         (PerfTestsRunner.run):
1271
1272 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1273
1274         Unreviewed, rolling out r144224.
1275         http://trac.webkit.org/changeset/144224
1276         https://bugs.webkit.org/show_bug.cgi?id=111045
1277
1278         Caused plugins/pass-different-npp-struct.html to time out
1279         (Requested by abarth on #webkit).
1280
1281         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1282         (PassDifferentNPPStruct::NPP_SetWindow):
1283         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1284         (NPP_SetWindow):
1285
1286 2013-02-27  Adam Barth  <abarth@webkit.org>
1287
1288         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
1289         https://bugs.webkit.org/show_bug.cgi?id=110907
1290
1291         Reviewed by Eric Seidel.
1292
1293         This patch changes --enable-threaded-html-parser into
1294         --disable-threaded-html-parser and thereby enables the threaded HTML
1295         parser by default for the Chromium port.
1296
1297         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1298         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1299         (WebTestRunner::WebPreferences::reset):
1300         * DumpRenderTree/chromium/TestShell.cpp:
1301         (TestShell::TestShell):
1302
1303 2013-02-27  Kiran Muppala  <cmuppala@apple.com>
1304
1305         Initialize page visibility after creating WebKitTestRunner WebView on Mac
1306         https://bugs.webkit.org/show_bug.cgi?id=111025
1307
1308         Reviewed by Simon Fraser.
1309
1310         Set page visibility to "visible" after creating WebView to override
1311         visibility state inferred from window occlusion notifications on Mac.
1312
1313         * WebKitTestRunner/TestController.cpp:
1314         (WTR::TestController::createWebViewWithOptions): Add call to
1315         setVisibilityState.
1316
1317 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1318
1319         Merge PageLoadingPerfTest into ReplayPerfTest
1320         https://bugs.webkit.org/show_bug.cgi?id=111027
1321
1322         Reviewed by Dirk Pranke.
1323
1324         Merged two classes.
1325
1326         We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
1327         part of ReplayPerfTest.
1328
1329         * Scripts/webkitpy/performance_tests/perftest.py:
1330         (ReplayPerfTest): Moved _FORCE_GC_FILE here.
1331         (ReplayPerfTest.__init__):
1332         (ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
1333         (ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
1334         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1335         (TestReplayPerfTest):
1336         (TestReplayPerfTest.test_run_single.run_test):
1337         (TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
1338         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
1339         TestPageLoadingPerfTest.test_run.
1340         (TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
1341         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
1342         TestPageLoadingPerfTest.test_run_with_memory_output
1343         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
1344         (TestReplayPerfTest.test_prepare_calls_run_single):
1345
1346 2013-02-27  Eric Seidel  <eric@webkit.org>
1347
1348         Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
1349         https://bugs.webkit.org/show_bug.cgi?id=111021
1350
1351         Reviewed by Dirk Pranke.
1352
1353         The underlying code (which is shared with run-webkit-tests)
1354         already knew how to support this option, it just wasn't exposed
1355         via the run-perf-tests front-end.  This patch fixes that.
1356
1357         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1358         (PerfTestsRunner._parse_args):
1359
1360 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1361
1362         Stop uploading results to webkit-perf.appspot.com
1363         https://bugs.webkit.org/show_bug.cgi?id=110954
1364
1365         Reviewed by Benjamin Poulain.
1366
1367         Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
1368
1369         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1370         (RunAndUploadPerfTests):
1371
1372 2013-02-27  James Simonsen  <simonjam@chromium.org>
1373
1374         [chromium] Lower priority of preloaded images
1375         https://bugs.webkit.org/show_bug.cgi?id=110527
1376
1377         Plumb the didChangePriority signal into DRT so it can be tested.
1378
1379         Reviewed by Nate Chapin.
1380
1381         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1382         (WebKit):
1383         (WebTestRunner::WebTestProxy::didChangeResourcePriority):
1384         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1385         (WebTestRunner::TestRunner::TestRunner):
1386         (WebTestRunner::TestRunner::reset):
1387         (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
1388         (WebTestRunner):
1389         (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
1390         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1391         (TestRunner):
1392         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1393         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
1394         (WebTestRunner::WebTestProxyBase::willSendRequest):
1395         (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
1396         (WebTestRunner):
1397
1398 2013-02-27  Chris Fleizach  <cfleizach@apple.com>
1399
1400         AX: Mac platform should support ability to scroll an element into visible
1401         https://bugs.webkit.org/show_bug.cgi?id=109860
1402
1403         Reviewed by Beth Dakin.
1404
1405         * DumpRenderTree/AccessibilityUIElement.cpp:
1406         (scrollToMakeVisibleCallback):
1407         (AccessibilityUIElement::getJSClass):
1408         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1409         (AccessibilityUIElement::scrollToMakeVisible):
1410         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1411         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1412         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1413         (AccessibilityUIElement):
1414         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1415         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1416         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1417         (WTR):
1418
1419 2013-02-27  John Bauman  <jbauman@chromium.org>
1420
1421         Plugin in iframe may not display
1422         https://bugs.webkit.org/show_bug.cgi?id=109879
1423
1424         Reviewed by Simon Fraser.
1425
1426         LogNPPSetWindow will be used with other ports as well.
1427
1428         * DumpRenderTree/DumpRenderTree.gypi:
1429         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1430
1431 2013-02-27  Jochen Eisinger  <jochen@chromium.org>
1432
1433         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
1434         https://bugs.webkit.org/show_bug.cgi?id=110973
1435
1436         Reviewed by Adam Barth.
1437
1438         There is nothing that ensures that the log messages from the plugin
1439         come in before the layout test finished loading.
1440
1441         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1442         (PassDifferentNPPStruct::NPP_SetWindow):
1443         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1444         (NPP_SetWindow):
1445
1446 2013-02-27  Glenn Adams  <glenn@skynav.com>
1447
1448         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
1449         https://bugs.webkit.org/show_bug.cgi?id=110944
1450
1451         Reviewed by Dean Jackson.
1452
1453         * Scripts/webkitperl/FeatureList.pm:
1454         * qmake/mkspecs/features/features.pri:
1455
1456 2013-02-27  Yong Li  <yong.li.webkit@outlook.com>
1457
1458         Unreviewed. Remove myself from watchlist.
1459
1460         * Scripts/webkitpy/common/config/watchlist:
1461
1462 2013-02-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1463
1464         Switch QtWebKit to GStreamer 1.0.
1465         https://bugs.webkit.org/show_bug.cgi?id=106669.
1466
1467         Original patch by Sebastian Dröge.
1468         Reviewed by Csaba Osztrogonác.
1469
1470         Build with GStreamer 1.0 if available, but support GStreamer 0.10 
1471         temporarily to make upgrading easy and the patch suitable for Qt5.
1472
1473         * qmake/mkspecs/features/features.prf:
1474
1475 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
1476
1477         Unreviewed. Added myself to committers.py
1478
1479         * Scripts/webkitpy/common/config/committers.py:
1480
1481 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1482
1483         Unreviewed, rolling out r144192.
1484         http://trac.webkit.org/changeset/144192
1485         https://bugs.webkit.org/show_bug.cgi?id=110984
1486
1487         Stored svn password on wrong computer (Requested by kkristof
1488         on #webkit).
1489
1490         * Scripts/webkitpy/common/config/committers.py:
1491
1492 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
1493
1494         Unreviewed. Added myself to committers.py
1495
1496         * Scripts/webkitpy/common/config/committers.py:
1497
1498 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1499
1500         Build fix after r144155. The report page is located at /api/report, not /api/test/report.
1501
1502         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1503         (PerfTestsRunner._upload_json):
1504
1505 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1506
1507         Stop uploading results to webkit-perf.appspot.com
1508         https://bugs.webkit.org/show_bug.cgi?id=110954
1509
1510         Reviewed by Benjamin Poulain.
1511
1512         When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
1513         Also, always use the new JSON format. Removed the code to generate the old format.
1514
1515         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1516         (PerfTestsRunner._generate_and_show_results):
1517         (PerfTestsRunner._generate_results_dict):
1518         (PerfTestsRunner._merge_slave_config_json):
1519         (PerfTestsRunner._generate_output_files):
1520
1521 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1522
1523         Unreviewed, rolling out r144136, r144143, and r144147.
1524         http://trac.webkit.org/changeset/144136
1525         http://trac.webkit.org/changeset/144143
1526         http://trac.webkit.org/changeset/144147
1527         https://bugs.webkit.org/show_bug.cgi?id=110950
1528
1529         Caused some timeouts and flaky crashes (Requested by abarth on
1530         #webkit).
1531
1532         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1533         (main):
1534         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1535         (WebTestRunner::WebPreferences::reset):
1536         * DumpRenderTree/chromium/TestShell.cpp:
1537         (TestShell::TestShell):
1538
1539 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1540
1541         Use perf.webkit.org JSON format in results page
1542         https://bugs.webkit.org/show_bug.cgi?id=110842
1543
1544         Reviewed by Benjamin Poulain.
1545
1546         Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
1547
1548         A whole bunch of integration tests have been updated to use the new JSON format.
1549
1550         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1551         (PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
1552         and legacy_output_json_path respectively.
1553         (PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
1554         (PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
1555         JSON file and the results page out of perf_webkit_output instead of legacy_output.
1556
1557         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1558         (MainTest.test_run_memory_test):
1559         (MainTest._test_run_with_json_output.mock_upload_json):
1560         (MainTest):
1561         (MainTest.test_run_with_json_output):
1562         (MainTest.test_run_with_description):
1563         (MainTest.test_run_generates_json_by_default):
1564         (MainTest.test_run_merges_output_by_default):
1565         (MainTest.test_run_respects_reset_results):
1566         (MainTest.test_run_generates_and_show_results_page):
1567         (MainTest.test_run_with_slave_config_json):
1568         (MainTest.test_run_with_multiple_repositories):
1569         (MainTest.test_run_with_upload_json):
1570         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1571
1572 2013-02-26  Adam Barth  <abarth@webkit.org>
1573
1574         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
1575         https://bugs.webkit.org/show_bug.cgi?id=110907
1576
1577         Reviewed by Eric Seidel.
1578
1579         This patch changes --enable-threaded-html-parser into
1580         --disable-threaded-html-parser and thereby enables the threaded HTML
1581         parser by default for the Chromium port.
1582
1583         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1584         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1585         (WebTestRunner::WebPreferences::reset):
1586         * DumpRenderTree/chromium/TestShell.cpp:
1587         (TestShell::TestShell):
1588
1589 2013-02-26  Dirk Pranke  <dpranke@chromium.org>
1590
1591         [chromium] Re-enable the fixed version of freetype on linux
1592         https://bugs.webkit.org/show_bug.cgi?id=110542
1593
1594         Reviewed by Tony Chang.
1595
1596         Re-land the change in r143794 to switch to building with a fixed
1597         version of FreeType for just DumpRenderTree. This allows us to share
1598         one version of pixel baselines for both Lucid and Precise, and run the
1599         layout tests in a stock Precise install (instead of a Lucid chroot).
1600         Going forward, this approach isolates us from os-level changes to the
1601         version of FreeType. Note that Chromium itself still uses the system
1602         FreeType and is unaffected by this change.
1603         
1604         This setting can still be turned off (at compile/gyp-time) by
1605         manually setting use_custom_freetype=0.
1606
1607         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1608
1609 2013-02-26  Nico Weber  <thakis@chromium.org>
1610
1611         [chromium] content shell drt: Enable WebKit::setLayoutTestMode()
1612         https://bugs.webkit.org/show_bug.cgi?id=110890
1613
1614         Reviewed by Jochen Eisinger.
1615
1616         Several functions in webkit check that bit to change rendering
1617         in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
1618         disables font smoothing in this mode. TestShell and DRT both set
1619         this flag, so content shell drt should set it too.
1620
1621         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1622         (WebTestRunner::TestInterfaces::TestInterfaces):
1623
1624 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
1625
1626         new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
1627         https://bugs.webkit.org/show_bug.cgi?id=110884
1628
1629         Reviewed by Csaba Osztrogonác.
1630
1631         Adding the missing spaces before ':' in the unit test.
1632
1633         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1634
1635 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
1636
1637         new-commit-bot: Some IRC clients doesn't linkify rollout messages
1638         https://bugs.webkit.org/show_bug.cgi?id=110861
1639
1640         Reviewed by Ryosuke Niwa.
1641
1642         Adding the space before ':' in order to fix the links shown for the rollout message.
1643
1644         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1645         (NewCommitBot._summarize_commit_log):
1646
1647 2013-02-26  Joone Hur  <joone.hur@intel.com>
1648
1649         [GTK] Add Clutter to jhbuild
1650         https://bugs.webkit.org/show_bug.cgi?id=110245
1651
1652         Reviewed by Martin Robinson.
1653
1654         Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
1655         This allows to build WebKitGtk+ with clutter as an acceleration backend
1656         within the jhbuild environment. 
1657
1658         * gtk/jhbuild-optional.modules:
1659
1660 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1661
1662         Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
1663
1664         * Scripts/webkitpy/common/checkout/scm/svn.py:
1665         (SVN.value_from_svn_info):
1666
1667 2013-02-25  Alan Cutter  <alancutter@chromium.org>
1668
1669         GCE EWS bots failing intermittently on HTTP 502 error while updating their status
1670         https://bugs.webkit.org/show_bug.cgi?id=110845
1671
1672         Unreviewed EWS bot fix.
1673
1674         Switch the Queue Status Server address the EWS bots use to a more direct URL that
1675         doesn't seem to be having problems from GCE like queues.webkit.org.
1676
1677         * Scripts/webkitpy/common/net/statusserver.py:
1678         (StatusServer):
1679
1680 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
1681
1682         Forgot to delete a no-longer-needed unit test after r143980.
1683
1684         Unreviewed, build fix.
1685
1686         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1687         (ChromiumWinTest.test_path_to_image_diff):
1688
1689 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1690
1691         Build fix. run-perf-tests was reporting with revision numbers ending with \r.
1692         Don't include \r at the end of svn info lines on Windows.
1693
1694         This is similar to r143839.
1695
1696         * Scripts/webkitpy/common/checkout/scm/svn.py:
1697         (SVN.value_from_svn_info):
1698
1699 2013-02-25  James Simonsen  <simonjam@chromium.org>
1700
1701         [Resource Timing] Update test suite so it can be exported to the W3C
1702         https://bugs.webkit.org/show_bug.cgi?id=107343
1703
1704         Reviewed by Tony Gentilcore.
1705
1706         * Scripts/export-w3c-performance-wg-tests: Clean up output.
1707         * Scripts/import-w3c-performance-wg-tests:
1708
1709 2013-02-25  Anders Carlsson  <andersca@apple.com>
1710
1711         Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
1712         https://bugs.webkit.org/show_bug.cgi?id=110821
1713         <rdar://problem/13265303>
1714
1715         Reviewed by Beth Dakin.
1716
1717         Update for WebKit2 changes.
1718
1719         * MiniBrowser/mac/WK2BrowserWindowController.m:
1720         (-[WK2BrowserWindowController awakeFromNib]):
1721         * WebKitTestRunner/TestController.cpp:
1722         (WTR::TestController::createOtherPage):
1723         (WTR::TestController::createWebViewWithOptions):
1724         (WTR::TestController::unavailablePluginButtonClicked):
1725         * WebKitTestRunner/TestController.h:
1726         (TestController):
1727
1728 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
1729
1730         Optionally partition cache to prevent using cache for tracking
1731         https://bugs.webkit.org/show_bug.cgi?id=110269
1732
1733         Reviewed by Maciej Stachowiak.
1734
1735         Add test suite for public suffix functions on Mac.
1736
1737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1738         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
1739         (TestWebKitAPI):
1740         (TestWebKitAPI::TEST_F):
1741
1742 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
1743
1744         nrwt: reenable multiple http shards on chromium win
1745         https://bugs.webkit.org/show_bug.cgi?id=110814
1746
1747         Reviewed by Tony Chang.
1748
1749         The underlying bug in DumpRenderTree that was causing us to look for a
1750         pac file and timeout under load was fixed a while ago.
1751
1752         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1753         (ChromiumWinPort.relative_test_filename):
1754
1755 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
1756
1757         Make ninja the default w/ build-webkit --chromium on windows.
1758         https://bugs.webkit.org/show_bug.cgi?id=110731
1759
1760         Unreviewed - TBR'ing thakis :).
1761
1762         * Scripts/update-webkit-chromium:
1763
1764 2013-02-25  Anders Carlsson  <andersca@apple.com>
1765
1766         Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
1767         https://bugs.webkit.org/show_bug.cgi?id=110793
1768         <rdar://problem/13265303>
1769
1770         Reviewed by Sam Weinig.
1771
1772         Update for WebKit2 API changes.
1773
1774         * MiniBrowser/mac/WK2BrowserWindowController.m:
1775         (-[WK2BrowserWindowController awakeFromNib]):
1776         * WebKitTestRunner/TestController.cpp:
1777         (WTR::TestController::createWebViewWithOptions):
1778
1779 2013-02-25  Nico Weber  <thakis@chromium.org>
1780
1781         Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
1782         https://bugs.webkit.org/show_bug.cgi?id=110775
1783
1784         Unreviewed, basically a rebaseline.
1785
1786         * Scripts/webkitpy/common/config/watchlist:
1787
1788 2013-02-25  Nico Weber  <thakis@chromium.org>
1789
1790         [chromium] Try to get the webkit builder to use msvs again
1791         https://bugs.webkit.org/show_bug.cgi?id=110771
1792
1793         Reviewed by Eric Seidel.
1794
1795         The msvs gyp generator apparently doesn't write the sln file on every
1796         run, so check the vcxproj file instead.
1797
1798         * Scripts/webkitdirs.pm:
1799         (determineIsChromiumNinja):
1800
1801 2013-02-25  Nico Weber  <thakis@chromium.org>
1802
1803         [chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
1804         https://bugs.webkit.org/show_bug.cgi?id=110767
1805
1806         Reviewed by Eric Seidel.
1807
1808         The tester runs gyp, which generates out/Release/build.ninja. The bot
1809         scripts use existence (and timestamp) of that file to decide if the
1810         current build is supposed to be ninja or xcodebuild. The file exists,
1811         so the snapshot is extracted to out/Release. The snapshot doesn't
1812         contain build.ninja however due to
1813         http://trac.webkit.org/changeset/140375 , so after extracting the
1814         snapshot the scripts think that this is an xcodebuild build. So remove
1815         the part of that revision that removed ninja files from the archive,
1816         and the bots should be happy again.
1817
1818         * BuildSlaveSupport/built-product-archive:
1819         (archiveBuiltProduct):
1820
1821 2013-02-25  Nico Weber  <thakis@chromium.org>
1822
1823         Fix tests after r143910
1824         https://bugs.webkit.org/show_bug.cgi?id=110757
1825
1826         Reviewed by Andreas Kling.
1827
1828         While here, also add a test for the bug r143910 fixed.
1829
1830         * Scripts/webkitpy/common/system/executive_unittest.py:
1831         (ScriptErrorTest.test_message_with_output):
1832         (ScriptErrorTest):
1833         (ScriptErrorTest.test_message_with_tuple):
1834
1835 2013-02-25  Nico Weber  <thakis@chromium.org>
1836
1837         [chromium] Apparently built-product-archive is written in Python, not Perl :-/
1838         https://bugs.webkit.org/show_bug.cgi?id=110755
1839
1840         Reviewed by Jochen Eisinger.
1841
1842         * BuildSlaveSupport/built-product-archive:
1843         (archiveBuiltProduct):
1844         (extractBuiltProduct):
1845
1846 2013-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1847
1848         Unreviewed, rolling out r143895.
1849         http://trac.webkit.org/changeset/143895
1850         https://bugs.webkit.org/show_bug.cgi?id=110758
1851
1852         broke a bunch of tests (Requested by thakis__ on #webkit).
1853
1854         * Scripts/update-webkit-chromium:
1855
1856 2013-02-25  Andreas Kling  <akling@apple.com>
1857
1858         Unreviewed, fix simple mistake in r143903.
1859         <http://webkit.org/b/110746>
1860
1861         Reviewed by Andreas Kling.
1862
1863         Pass git revision, not svn revision, to git shell command.
1864
1865         * Scripts/webkitpy/common/checkout/scm/git.py:
1866         (Git.timestamp_of_latest_commit):
1867
1868 2013-02-25  Nico Weber  <thakis@chromium.org>
1869
1870         [chromium] Let built-product-archive log which directory it's archiving from and extracting to
1871         https://bugs.webkit.org/show_bug.cgi?id=110748
1872
1873         Reviewed by Jochen Eisinger.
1874
1875         One of the mac testers runs DRT from out/ but WebKitUnitTests from
1876         xcodebuild. I'm trying to understand what's going on.
1877
1878         * BuildSlaveSupport/built-product-archive:
1879         (archiveBuiltProduct):
1880         (extractBuiltProduct):
1881
1882 2013-02-23  Ilya Tikhonovsky  <loislo@chromium.org>
1883
1884         Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
1885         https://bugs.webkit.org/show_bug.cgi?id=110599
1886
1887         Reviewed by Yury Semikhatsky.
1888
1889         Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
1890         that were given us via MemoryInstrumentation calls.
1891         So I extended client api with registerString method that pushes the strings
1892         down to the serializer.
1893
1894         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1895         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
1896         (TestWebKitAPI::Helper::Helper):
1897         (Helper):
1898         (TestWebKitAPI::Helper::addNode):
1899         (TestWebKitAPI::TEST):
1900
1901 2013-02-25  Nico Weber  <thakis@chromium.org>
1902
1903         Make ScriptError not crash when args is a tuple
1904         https://bugs.webkit.org/show_bug.cgi?id=110747
1905
1906         Reviewed by Jochen Eisinger.
1907
1908         I'm trying to understand the error on
1909         http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
1910         better. I'll likely have to revert the ninja switch on windows, but
1911         having error reporting code that doesn't itself crash sounds like a
1912         good thing to have anyways.
1913
1914         The problem is that '%s' % (1, 2) errors out, and args is sometimes a
1915         tuple not a list.
1916
1917         * Scripts/run-chromium-webkit-unit-tests:
1918         * Scripts/webkitpy/common/system/executive.py:
1919         (ScriptError.__init__):
1920
1921 2013-02-25  Laszlo Gombos  <l.gombos@samsung.com>
1922
1923         [EFL] Align feature defaults
1924         https://bugs.webkit.org/show_bug.cgi?id=110715
1925
1926         Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
1927         OptionsEfl.cmake.
1928
1929         Reviewed by Gyuyoung Kim.
1930
1931         * Scripts/webkitperl/FeatureList.pm:
1932
1933 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
1934
1935         run-perf-tests reports wrong commit time
1936         https://bugs.webkit.org/show_bug.cgi?id=110746
1937
1938         Reviewed by Andreas Kling.
1939
1940         The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
1941         of when the subdirectory was last modified.
1942
1943         Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
1944         insufficient since running "svn log -r <revision>" on a partial checkout only returns
1945         an empty result if the revision didn't modify the subdirectory.
1946
1947         For git, there is no partial checkout, so we just need to pass in "-r" option to keep
1948         the interface compatible with svn.
1949
1950         * Scripts/webkitpy/common/checkout/scm/git.py:
1951         (Git.timestamp_of_latest_commit):
1952         * Scripts/webkitpy/common/checkout/scm/scm.py:
1953         (SCM.timestamp_of_latest_commit):
1954         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1955         (MockSCM.timestamp_of_latest_commit):
1956         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1957         (test_timestamp_of_latest_commit):
1958         * Scripts/webkitpy/common/checkout/scm/svn.py:
1959         (SVN.timestamp_of_latest_commit):
1960         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1961         (PerfTestsRunner._generate_results_dict):
1962
1963 2013-02-25  Jochen Eisinger  <jochen@chromium.org>
1964
1965         [chromium] move WebRuntimeFeatures configuration to TestRunner library
1966         https://bugs.webkit.org/show_bug.cgi?id=110712
1967
1968         Reviewed by Nico Weber.
1969
1970         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1971         (WebTestRunner::TestInterfaces::TestInterfaces):
1972         * DumpRenderTree/chromium/TestShell.cpp:
1973         (TestShell::TestShell):
1974
1975 2013-02-25  Nico Weber  <thakis@chromium.org>
1976
1977         Make ninja the default build system for build-webkit --chromium on windows
1978         https://bugs.webkit.org/show_bug.cgi?id=110731
1979
1980         Reviewed by Jochen Eisinger.
1981
1982         With http://crbug.com/169945 fixed, this should now work.
1983
1984         * Scripts/update-webkit-chromium:
1985
1986 2013-02-24  Gustavo Noronha Silva  <gns@gnome.org>
1987
1988         [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
1989         https://bugs.webkit.org/show_bug.cgi?id=110702
1990
1991         Reviewed by Martin Robinson.
1992
1993         * GtkLauncher/main.c: include autotoolsconfig.h.
1994         * Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
1995         the include ordering check, since it uses autotoolsconfig.h which needs to
1996         come first.
1997
1998 2013-02-24  Hajime Morrita  <morrita@google.com>
1999
2000         [Custom Elements] Implement bare-bone document.register()
2001         https://bugs.webkit.org/show_bug.cgi?id=100229
2002
2003         Reviewed by Adam Barth.
2004
2005         Added enableCustomDOMElements flag.
2006
2007         * DumpRenderTree/chromium/TestShell.cpp:
2008         (TestShell::TestShell):
2009
2010 2013-02-23  Mark Pilgrim  <pilgrim@chromium.org>
2011
2012         [Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
2013         https://bugs.webkit.org/show_bug.cgi?id=110606
2014
2015         Reviewed by Adam Barth.
2016
2017         Part of a larger refactoring series; see tracking bug 82948.
2018
2019         * DumpRenderTree/DumpRenderTree.gypi:
2020         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2021         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
2022         (WebKitSupportTestEnvironment::mockPlatform):
2023         (WebKitSupportTestEnvironment):
2024         * DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
2025         (MockPlatform::create):
2026         (MockPlatform::MockPlatform):
2027         (MockPlatform::~MockPlatform):
2028         (MockPlatform::setInterfaces):
2029         (MockPlatform::cryptographicallyRandomValues):
2030         (MockPlatform::createMediaStreamCenter):
2031         (MockPlatform::createRTCPeerConnectionHandler):
2032         * DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
2033         (MockPlatform):
2034         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
2035         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
2036         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2037         (WebTestDelegate):
2038         * DumpRenderTree/chromium/TestShell.cpp:
2039         (TestShell::initialize):
2040         * DumpRenderTree/chromium/TestShell.h:
2041         (TestShell):
2042
2043 2013-02-23  Ryosuke Niwa  <rniwa@webkit.org>
2044
2045         Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
2046
2047         * Scripts/webkitpy/common/checkout/scm/svn.py:
2048         (SVN.timestamp_of_latest_commit):
2049
2050 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
2051
2052         Move setAutofilled from TestRunner to WebCore
2053         https://bugs.webkit.org/show_bug.cgi?id=110521
2054
2055         Reviewed by Benjamin Poulain.
2056
2057         * DumpRenderTree/TestRunner.cpp:
2058         (TestRunner::staticFunctions):
2059         * DumpRenderTree/TestRunner.h:
2060         (TestRunner):
2061         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2062         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2063         (WebTestRunner::TestRunner::TestRunner):
2064         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2065         (TestRunner):
2066         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2067         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2068         * DumpRenderTree/mac/TestRunnerMac.mm:
2069         * DumpRenderTree/qt/TestRunnerQt.cpp:
2070         * DumpRenderTree/qt/TestRunnerQt.h:
2071         (TestRunnerQt):
2072         * DumpRenderTree/win/TestRunnerWin.cpp:
2073         * DumpRenderTree/wx/TestRunnerWx.cpp:
2074
2075 2013-02-22  Ryosuke Niwa  <rniwa@webkit.org>
2076
2077         Upload results to perf.webkit.org in addition to the one specified by --test-results-server
2078         https://bugs.webkit.org/show_bug.cgi?id=108577
2079
2080         Reviewed by Dirk Pranke.
2081
2082         Upload results to perf.webkit.org using new JSON format as well as the host specified by
2083         --test-results-server. The new format is needed to provide extra information perf.webkit.org
2084         need such as the subversion commit time and test URLs. This is a temporarily measure until
2085         we complete the transition and the old JSON format and the code to upload results to
2086         webkit-perf.appspot.com can be deleted.
2087
2088         This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
2089         in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
2090         so that the app can sort performance test results based on the timestamp of the last commit.
2091
2092         It also changes the repository names returned by port objects to be properly capitalized
2093         human readable names such as WebKit instead of lowercased names such as webkit since these names
2094         are displayed on perf.webkit.org for humans. Several users of this feature has been updated
2095         to explicitly lowercase the names.
2096
2097
2098         * Scripts/webkitpy/common/checkout/scm/git.py:
2099         (Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
2100         git's timestamp granularity is seconds so we're losing some information compared to using a regular
2101         subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
2102         UTC so we're going to manually fiddle with timezone.
2103
2104         * Scripts/webkitpy/common/checkout/scm/scm.py:
2105         (SCM.timestamp_of_latest_commit): Added.
2106
2107         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2108         (MockSCM.timestamp_of_latest_commit): Added.
2109
2110         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2111         (test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.
2112
2113         * Scripts/webkitpy/common/checkout/scm/svn.py:
2114         (SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
2115         the timestamp which is always in UTC.
2116
2117         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2118         (JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
2119         'chromium' needs to be substituted by 'chrome' for historical reasons.
2120
2121         * Scripts/webkitpy/layout_tests/port/base.py:
2122         (Port.repository_paths): Return WebKit instead of webkit as noted above.
2123
2124         * Scripts/webkitpy/layout_tests/port/chromium.py:
2125         (ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.
2126
2127         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2128         (PerfTestsRunner.__init__): Store the current time in UTC as well as in local time.
2129         (PerfTestsRunner._collect_tests):
2130
2131         (PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
2132         and upload them appropriately.
2133
2134         (PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
2135         in revisions_for_perf_webkit and construct an output for perf.webkit.org.
2136
2137         (PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.
2138
2139         (PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
2140         and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
2141         e.g. "processor" would be renamed to "builderProcessor".
2142
2143         (PerfTestsRunner._generate_output_files):
2144
2145         (PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
2146         on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
2147         to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
2148         webkit-perf.appspot.com which spits out a plaintext response.
2149
2150         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2151         (MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
2152         (MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
2153         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.
2154
2155         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2156         (MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
2157         cases to parse JSON responses.
2158         (MainTest.test_upload_json.MockFileUploader): Refactored.
2159         (MainTest.test_upload_json.MockFileUploader.reset): Added.
2160         (MainTest.test_upload_json.MockFileUploader.__init__):
2161         (MainTest.test_upload_json.MockFileUploader.upload_single_text_file):
2162
2163 2013-02-22  Roger Fong  <roger_fong@apple.com>
2164
2165         Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.
2166
2167         * BuildSlaveSupport/build.webkit.org-config/config.json:
2168
2169 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2170
2171         Unreviewed, rolling out r143794.
2172         http://trac.webkit.org/changeset/143794
2173         https://bugs.webkit.org/show_bug.cgi?id=110542
2174
2175         debug linux builds broken?
2176
2177         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2178
2179 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2180
2181         [chromium] enable the fixed version of freetype on linux
2182         https://bugs.webkit.org/show_bug.cgi?id=110542
2183
2184         Reviewed by Tony Chang.
2185
2186         Switch to building with a fixed version of FreeType for
2187         just DumpRenderTree. This allows us to share one version
2188         of pixel baselines for both Lucid and Precise, and run
2189         the layout tests in a stock Precise install (instead of a Lucid
2190         chroot). Going forward, this approach isolates us from os-level
2191         changes to the version of FreeType. Note that Chromium itself
2192         still uses the system FreeType and is unaffected by this change.
2193         
2194         This setting can still be turned off (at compile/gyp-time) by
2195         manually setting use_custom_freetype=0.
2196
2197         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2198
2199 2013-02-22  Anders Carlsson  <andersca@apple.com>
2200
2201         Move pluginLoadPolicy to the page loader client
2202         https://bugs.webkit.org/show_bug.cgi?id=110635
2203
2204         Reviewed by Sam Weinig.
2205
2206         * MiniBrowser/mac/WK2BrowserWindowController.m:
2207         (-[WK2BrowserWindowController awakeFromNib]):
2208         * WebKitTestRunner/TestController.cpp:
2209         (WTR::TestController::createOtherPage):
2210         (WTR::TestController::createWebViewWithOptions):
2211
2212 2013-02-22  Kenneth Russell  <kbr@google.com>
2213
2214         Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.
2215
2216         * Scripts/webkitpy/common/config/committers.py:
2217
2218 2013-02-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2219
2220         [WTR] Do not dump information about empty subframes.
2221         https://bugs.webkit.org/show_bug.cgi?id=110585
2222
2223         Reviewed by Simon Fraser.
2224
2225         Follow DumpRenderTree more closely by skipping empty frames
2226         (frames which have no document). We are not really interested in
2227         showing anything about them.
2228
2229         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2230         (WTR::dumpDescendantFramesText): Do not print subframe names when they
2231         have no associated Document.
2232
2233 2013-02-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2234
2235         [EFL][DRT] Do not dump empty frames.
2236         https://bugs.webkit.org/show_bug.cgi?id=110474
2237
2238         Reviewed by Kenneth Rohde Christiansen.
2239
2240         Follow the original Mac implementation more closely by skipping
2241         empty frames (frames which have no document). We are not really
2242         interested in showing anything about them.
2243
2244         * DumpRenderTree/efl/DumpRenderTree.cpp:
2245         (dumpFramesAsText):
2246
2247 2013-02-21  Dirk Pranke  <dpranke@chromium.org>
2248
2249         [chromium] support the lucid version of freetype on precise in DRT
2250         https://bugs.webkit.org/show_bug.cgi?id=107338
2251
2252         Reviewed by Tony Chang.
2253
2254         Modify the DRT build so that we can optionally link against
2255         a fixed version of Freetype2. This allows us to share pixel test
2256         results across multiple versions of Ubuntu without having to
2257         worry about differences in font rendering.
2258
2259         At the moment this feature is off by default. Eventually it will
2260         be on by default on linux.
2261
2262         Note that this only affects DRT; the regular Chromium binary
2263         (and, for now, content_shell) will still use the system version
2264         of Freetype.
2265
2266         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2267
2268 2013-02-21  Rouslan Solomakhin  <rouslan@chromium.org>
2269
2270         [Chromium] Remove the word "cheher" from the list of misspelled words
2271         https://bugs.webkit.org/show_bug.cgi?id=110447
2272
2273         Reviewed by Tony Chang.
2274
2275         Other platforms do not mark "cheher" as a misspelled word in layout tests.
2276         This change is to bring Chromium platform in line with the rest of the
2277         platforms.
2278
2279         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
2280         (WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
2281         (WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
2282         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.
2283
2284 2013-02-21  Jochen Eisinger  <jochen@chromium.org>
2285
2286         [chromium] document WebTestDelegate and WebTestRunner interfaces
2287         https://bugs.webkit.org/show_bug.cgi?id=110472
2288
2289         Reviewed by Adam Barth.
2290
2291         Also remove the default implementation of the remaining WebTestDelegate
2292         methods now that all embedders provide this interface.
2293
2294         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2295         (WebTestDelegate):
2296         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2297         (WebTestRunner):
2298
2299 2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
2300
2301         Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
2302         https://bugs.webkit.org/show_bug.cgi?id=106059
2303
2304         Reviewed by Geoffrey Garen.
2305
2306         Added new tests for the WebKit API portion of the JSC Objective-C API.
2307
2308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2309         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
2310         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
2311         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.
2312         (-[MyConsole log:]):
2313         (-[MyConsole printHelloWorld]):
2314         (-[MyConsole add:to:]):
2315         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
2316         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
2317         (TestWebKitAPI):
2318         (TestWebKitAPI::TEST):
2319
2320 2013-02-21  Stephen Chenney  <schenney@chromium.org>
2321
2322         Unreviewed, add myself as a reviewer
2323
2324         * Scripts/webkitpy/common/config/committers.py:
2325
2326 2013-02-21  Jer Noble  <jer.noble@apple.com>
2327
2328         Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.
2329
2330         * Scripts/webkitpy/common/config/committers.py:
2331         * Scripts/webkitpy/common/config/watchlist:
2332
2333 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
2334
2335         gtk/DumpRenderTree.cpp is missing <locale.h> include
2336         https://bugs.webkit.org/show_bug.cgi?id=109386
2337
2338         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build
2339         by include locale.h when we use setlocale.
2340
2341 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
2342
2343         [GTK] Move feature overriding to the configure phase
2344         https://bugs.webkit.org/show_bug.cgi?id=110293
2345
2346         Reviewed by Gustavo Noronha Silva.
2347
2348         * Scripts/webkitdirs.pm:
2349         (runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
2350         WebKitFeatureOverrides.txt to better match the other filenames used in
2351         the new feature processing.
2352         * gtk/generate-feature-defines-files: Added. A script which takes as an argument
2353         the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
2354         and writes WebKitFeatures.txt and WebKitFeatures.h.
2355         * gtk/override-feature-defines: Removed.
2356
2357 2013-02-21  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
2358
2359         [Qt] Remove obsolete DEPENDPATH assignment
2360
2361         Reviewed by Simon Hausmann
2362
2363         qmake now adds CONFIG+=depend_includepath by default, making manual
2364         DEPENDPATH setup unnecessary.
2365
2366         * qmake/mkspecs/features/default_post.prf:
2367
2368 2013-02-20  Vivek Galatage  <vivekg@webkit.org>
2369
2370         Unreviewed. Changing primary email id.
2371
2372         * Scripts/webkitpy/common/config/committers.py:
2373
2374 2013-02-14  James Robinson  <jamesr@chromium.org>
2375
2376         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
2377         https://bugs.webkit.org/show_bug.cgi?id=109634
2378
2379         Reviewed by Adrienne Walker.
2380
2381         * DumpRenderTree/chromium/WebViewHost.cpp:
2382         (WebViewHost::createOutputSurface):
2383         (WebViewHost::initializeLayerTreeView):
2384
2385 2013-02-20  Martin Robinson  <mrobinson@igalia.com>
2386
2387         [GTK] Re-enable 3D CSS transforms when using build-webkit
2388         https://bugs.webkit.org/show_bug.cgi?id=110402
2389
2390         Reviewed by Xan Lopez.
2391
2392         * Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
2393         when building WebKitGTK+.
2394
2395 2013-02-20  Roger Fong  <roger_fong@apple.com>
2396
2397         Get VS2010 Solution B&I ready.
2398         <rdar://problem/1322988>
2399
2400         Rubberstamped by Timothy Horton.        
2401         
2402         Add Production configurations.
2403         
2404         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2405         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2406         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Added.
2407         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
2408         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Added.
2409         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
2410         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2411         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2412         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Added.
2413         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
2414         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Added.
2415         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
2416         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2417         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Added.
2418         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
2419         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2420         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Added.
2421         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
2422         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2423         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2424         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Added.
2425         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
2426         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Added.
2427         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
2428         * win/record-memory/record-memory.vcxproj:
2429         * win/record-memory/record-memoryProduction.props: Added.
2430         * win/record-memory/record-memoryRelease.props:
2431
2432 2013-02-20  Dirk Schulze  <krit@webkit.org>
2433
2434         Enable CANVAS_PATH flag
2435         https://bugs.webkit.org/show_bug.cgi?id=108508
2436
2437         Reviewed by Simon Fraser.
2438
2439         Enable CANVAS_PATH flag on trunk.
2440
2441         * Scripts/webkitperl/FeatureList.pm:
2442
2443 2013-02-20  Tony Chang  <tony@chromium.org>
2444
2445         Parse author names with commas in ChangeLogs
2446         https://bugs.webkit.org/show_bug.cgi?id=110356
2447
2448         Reviewed by Dirk Pranke.
2449
2450         Paweł's name has a comma in it, which was confusing the ChangeLog parser.
2451
2452         * Scripts/webkitpy/common/checkout/changelog.py:
2453         (ChangeLogEntry): Move name splitting regexp into a constant.
2454         (ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
2455         (ChangeLogEntry._split_reviewer_names): Rename to be more specific.
2456         (ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
2457         (ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
2458         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2459         (test_parse_authors): Test case with Paweł's name.
2460
2461 2013-02-15  Dirk Schulze  <krit@webkit.org>
2462
2463         [Chromium] Add runtime flag for CanvasPath
2464         https://bugs.webkit.org/show_bug.cgi?id=109997
2465
2466         Reviewed by Adam Barth.
2467
2468         Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
2469         the constructor for Path on DOMWindow would never be activatable, since the script
2470         is running after creating the DOMWindow object.
2471
2472         * DumpRenderTree/chromium/TestShell.cpp:
2473         (TestShell::TestShell):
2474
2475 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
2476
2477         [chromium] use a WebTestProxyBase pointer to identify the window we need the history for
2478         https://bugs.webkit.org/show_bug.cgi?id=110346
2479
2480         Reviewed by Adam Barth.
2481
2482         Using an index is very brittle, as the TestRunner API does not define
2483         any ordering of windows.
2484
2485         Also, make TestRunner::shouldDumpBackForwardList() so content shell can
2486         trigger the capturing in the browser process before generating the
2487         text dump.
2488
2489         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2490         (WebTestRunner):
2491         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
2492         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2493         (WebTestRunner):
2494         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2495         (TestRunner):
2496         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2497         (WebTestRunner::WebTestProxyBase::captureTree):
2498         * DumpRenderTree/chromium/WebViewHost.cpp:
2499         (WebViewHost::captureHistoryForWindow):
2500         * DumpRenderTree/chromium/WebViewHost.h:
2501         (WebViewHost):
2502
2503 2013-02-19  Rouslan Solomakhin  <rouslan@chromium.org>
2504
2505         [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
2506         https://bugs.webkit.org/show_bug.cgi?id=109220
2507
2508         Reviewed by Tony Chang.
2509
2510         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
2511         (WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
2512         (WebTestRunner):
2513         (WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
2514         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.
2515         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
2516         (MockSpellCheck):
2517         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
2518         (WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.
2519
2520 2013-02-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2521
2522         [Gtk] HTML5 Media controls require a design refresh
2523         https://bugs.webkit.org/show_bug.cgi?id=83869
2524
2525         Reviewed by Philippe Normand.
2526
2527         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2528         (initializeGtkFontSettings): Added gnome as default icon theme for
2529         the DRT.
2530         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2531         (WTR::initializeGtkSettings): Added gnome as default icon theme for
2532         the WTR.
2533         * gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external
2534         dependency.
2535
2536 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
2537
2538         [chromium] move most of the remaining mocks to TestRunner library
2539         https://bugs.webkit.org/show_bug.cgi?id=110217
2540
2541         Reviewed by Nico Weber.
2542
2543         While most of the functionality provided by these mocks is also
2544         available in the content module, there is no straight forward way to
2545         inject the mock results required for layout tests.
2546
2547         * DumpRenderTree/DumpRenderTree.gypi:
2548         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2549         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2550         (WebKit):
2551         (WebTestRunner):
2552         (WebTestRunner::WebTestProxy::geolocationClient):
2553         (WebTestRunner::WebTestProxy::speechInputController):
2554         (WebTestRunner::WebTestProxy::speechRecognizer):
2555         (WebTestRunner::WebTestProxy::deviceOrientationClient):
2556         (WebTestRunner::WebTestProxy::requestPointerLock):
2557         (WebTestRunner::WebTestProxy::requestPointerUnlock):
2558         (WebTestRunner::WebTestProxy::isPointerLocked):
2559         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
2560         (WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
2561         (WebTestRunner):
2562         (WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
2563         (WebTestRunner::MockWebSpeechInputController::setDelegate):
2564         (WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
2565         (WebTestRunner::MockWebSpeechInputController::setDumpRect):
2566         (WebTestRunner::MockWebSpeechInputController::clearResults):
2567         (WebTestRunner::MockWebSpeechInputController::startRecognition):
2568         (WebTestRunner::MockWebSpeechInputController::cancelRecognition):
2569         (WebTestRunner::MockWebSpeechInputController::stopRecording):
2570         (WebTestRunner::MockWebSpeechInputController::speechTaskFired):
2571         (WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
2572         (WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
2573         (WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
2574         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
2575         (WebKit):
2576         (WebTestRunner):
2577         (MockWebSpeechInputController):
2578         (WebTestRunner::MockWebSpeechInputController::taskList):
2579         (SpeechTask):
2580         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
2581         (WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
2582         (WebTestRunner):
2583         (WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
2584         (WebTestRunner::MockWebSpeechRecognizer::setDelegate):
2585         (WebTestRunner::MockWebSpeechRecognizer::start):
2586         (WebTestRunner::MockWebSpeechRecognizer::stop):
2587         (WebTestRunner::MockWebSpeechRecognizer::abort):
2588         (WebTestRunner::MockWebSpeechRecognizer::addMockResult):
2589         (WebTestRunner::MockWebSpeechRecognizer::setError):
2590         (WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
2591         (WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
2592         (WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
2593         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
2594         (WebKit):
2595         (WebTestRunner):
2596         (MockWebSpeechRecognizer):
2597         (WebTestRunner::MockWebSpeechRecognizer::wasAborted):
2598         (WebTestRunner::MockWebSpeechRecognizer::client):
2599         (WebTestRunner::MockWebSpeechRecognizer::handle):
2600         (WebTestRunner::MockWebSpeechRecognizer::taskList):
2601         (Task):
2602         (WebTestRunner::MockWebSpeechRecognizer::Task::Task):
2603         (WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
2604         (StepTask):
2605         (WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
2606         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2607         (WebTestRunner::TestInterfaces::TestInterfaces):
2608         (WebTestRunner::TestInterfaces::windowOpened):
2609         (WebTestRunner):
2610         (WebTestRunner::TestInterfaces::windowClosed):
2611         (WebTestRunner::TestInterfaces::windowList):
2612         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2613         (TestInterfaces):
2614         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2615         (WebTestRunner::TestRunner::TestRunner):
2616         (WebTestRunner::TestRunner::reset):
2617         (WebTestRunner::TestRunner::requestPointerLock):
2618         (WebTestRunner):
2619         (WebTestRunner::TestRunner::requestPointerUnlock):
2620         (WebTestRunner::TestRunner::isPointerLocked):
2621         (WebTestRunner::TestRunner::didAcquirePointerLockInternal):
2622         (WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
2623         (WebTestRunner::TestRunner::didLosePointerLockInternal):
2624         (WebTestRunner::TestRunner::windowCount):
2625         (WebTestRunner::TestRunner::setMockDeviceOrientation):
2626         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
2627         (WebTestRunner::TestRunner::setGeolocationPermission):
2628         (WebTestRunner::TestRunner::setMockGeolocationPosition):
2629         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
2630         (WebTestRunner::TestRunner::addMockSpeechInputResult):
2631         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
2632         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
2633         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
2634         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
2635         (WebTestRunner::TestRunner::didAcquirePointerLock):
2636         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
2637         (WebTestRunner::TestRunner::didLosePointerLock):
2638         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
2639         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
2640         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2641         (WebTestRunner):
2642         (TestRunner):
2643         (HostMethodTask):
2644         (WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
2645         (WebTestRunner::TestRunner::HostMethodTask::runIfValid):
2646         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2647         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
2648         (WebTestRunner::WebTestProxyBase::setInterfaces):
2649         (WebTestRunner::WebTestProxyBase::setDelegate):
2650         (WebTestRunner::WebTestProxyBase::reset):
2651         (WebTestRunner::WebTestProxyBase::captureTree):
2652         (WebTestRunner::WebTestProxyBase::geolocationClientMock):
2653         (WebTestRunner):
2654         (WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
2655         (WebTestRunner::WebTestProxyBase::speechInputControllerMock):
2656         (WebTestRunner::WebTestProxyBase::speechRecognizerMock):
2657         (WebTestRunner::WebTestProxyBase::geolocationClient):
2658         (WebTestRunner::WebTestProxyBase::speechInputController):
2659         (WebTestRunner::WebTestProxyBase::speechRecognizer):
2660         (WebTestRunner::WebTestProxyBase::deviceOrientationClient):
2661         (WebTestRunner::WebTestProxyBase::requestPointerLock):
2662         (WebTestRunner::WebTestProxyBase::requestPointerUnlock):
2663         (WebTestRunner::WebTestProxyBase::isPointerLocked):
2664         * DumpRenderTree/chromium/WebViewHost.cpp:
2665         (WebViewHost::reset):
2666         * DumpRenderTree/chromium/WebViewHost.h:
2667         (WebKit):
2668         (WebViewHost):
2669
2670 2013-02-20  Andras Becsi  <andras.becsi@digia.com>
2671
2672         [Qt] Make debug builds possible on 32bit Linux
2673         https://bugs.webkit.org/show_bug.cgi?id=110231
2674
2675         Reviewed by Tor Arne Vestbø.
2676
2677         Use the stabs format for debug builds to make the object files
2678         a bit smaller so that they can be linked on a 32bit system.
2679
2680         * qmake/mkspecs/features/unix/default_post.prf:
2681
2682 2013-02-20  Takashi Toyoshima  <toyoshim@chromium.org>
2683
2684         Unreviewed. Add myself to watch lists.
2685
2686         * Scripts/webkitpy/common/config/committers.py:
2687         * Scripts/webkitpy/common/config/watchlist:
2688
2689 2013-02-19  Joshua Bell  <jsbell@chromium.org>
2690
2691         Remove warning from run-bindings-tests
2692         https://bugs.webkit.org/show_bug.cgi?id=110285
2693
2694         Reviewed by Kentaro Hara.
2695
2696         Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
2697         "Unknown option: idlattributesfile". That option was removed from
2698         bindings/scripts/preprocess-idls.pl but was still being passed by
2699         the test script. Remove it.
2700
2701         * Scripts/webkitpy/bindings/main.py:
2702         (BindingsTests.generate_supplemental_dependency): Remove unused arg.
2703
2704 2013-02-19  Elliott Sprehn  <esprehn@chromium.org>
2705
2706         Unreviewed. Add myself to watch lists.
2707
2708         * Scripts/webkitpy/common/config/committers.py:
2709         * Scripts/webkitpy/common/config/watchlist:
2710
2711 2013-02-19  Hans Muller  <hmuller@adobe.com>
2712
2713         Unreviewed, corrected primary email.
2714
2715         * Scripts/webkitpy/common/config/committers.py:
2716
2717 2013-02-19  Hans Muller  <hmuller@adobe.com>
2718
2719         Unreviewed. Adding myself as a committer.
2720
2721         * Scripts/webkitpy/common/config/committers.py:
2722
2723 2013-02-19  Pravin D  <pravind@webkit.org>
2724
2725         Unreviewed, changing primary email.
2726
2727         * Scripts/webkitpy/common/config/committers.py:
2728
2729 2013-02-19  Alan Cutter  <alancutter@chromium.org>
2730
2731         REGRESSION: Sheriffbot is failing to process rollout requests
2732         https://bugs.webkit.org/show_bug.cgi?id=106945
2733
2734         Reviewed by Adam Barth.
2735
2736         Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
2737         This resolves problems when Sheriffbot attempts to perform a rollout request.
2738
2739         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2740         * EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
2741         * EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
2742
2743 2013-02-19  Claudio Saavedra  <csaavedra@igalia.com>
2744
2745         Unreviewed build fix.
2746
2747         * efl/jhbuild.modules:
2748         * gtk/jhbuild.modules:
2749
2750         Bump harfbuzz module to 0.9.7. See related bug 110145.
2751
2752 2013-02-19  Simon Hausmann  <simon.hausmann@digia.com>
2753
2754         [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
2755         https://bugs.webkit.org/show_bug.cgi?id=110215
2756
2757         Reviewed by Tor Arne Vestbø.
2758
2759         Check that gperf, python, ruby, perl, bison and flex are in the PATH before
2760         continuing the build. Otherwise skip with an error message explaining which
2761         programs are missing from the build.
2762
2763         * qmake/mkspecs/features/configure.prf:
2764         * qmake/mkspecs/features/functions.prf:
2765
2766 2013-02-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2767
2768         Unreviewed, rolling out r143319.
2769         http://trac.webkit.org/changeset/143319
2770         https://bugs.webkit.org/show_bug.cgi?id=110214
2771
2772         Causes build issues on win32 (Requested by carewolf on
2773         #webkit).
2774
2775         * qmake/mkspecs/features/features.pri:
2776
2777 2013-02-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2778
2779         [Qt] Enable MathML
2780         https://bugs.webkit.org/show_bug.cgi?id=110205
2781
2782         Reviewed by Simon Hausmann.
2783
2784         * qmake/mkspecs/features/features.pri:
2785
2786 2013-02-17  Andrei Bucur  <abucur@adobe.com>
2787
2788         Unreviewed. Adding myself as a committer.
2789
2790         * Scripts/webkitpy/common/config/committers.py:
2791
2792 2013-02-19  Hajime Morrita  <morrita@google.com>
2793
2794         Unreviewed, updated spelling of my name.
2795
2796         * Scripts/webkitpy/common/config/committers.py:
2797
2798 2013-02-18  Ilya Tikhonovsky  <loislo@chromium.org>
2799
2800         Unreviewed. Adjust expectations.
2801
2802         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
2803         (TestWebKitAPI::TEST):
2804
2805 2013-02-18  Zan Dobersek  <zdobersek@igalia.com>
2806
2807         Unreviewed GTK gardening.
2808
2809         * Scripts/run-gtk-tests:
2810         (TestRunner): Skipped the ReloadPageAfterCrash unit test as it is flakily timing out.
2811
2812 2013-02-18  Adenilson Cavalcanti  <cavalcantii@gmail.com>
2813
2814         [Qt][WK2] Remove duped test name and append new test in project file
2815         https://bugs.webkit.org/show_bug.cgi?id=110117
2816
2817         A new WK2 API test has landed recently (ResizeWindowAfterCrash), this patch will
2818         add this test into the runnable test suite and remove a duped test in project file.
2819
2820         Reviewed by Jocelyn Turcotte.
2821
2822         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
2823
2824 2013-02-18  Jochen Eisinger  <jochen@chromium.org>
2825
2826         [chromium] remove log spew from dumpAllBackForwardLists
2827         https://bugs.webkit.org/show_bug.cgi?id=110108
2828
2829         Reviewed by Nico Weber.
2830
2831         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2832
2833 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2834
2835         [EFL][WK2] Disable failing API tests
2836         https://bugs.webkit.org/show_bug.cgi?id=110081
2837
2838         Reviewed by Kenneth Rohde Christiansen.
2839
2840         Disable DOMWindowExtensionBasic WK2 test on EFL port as it times out.
2841
2842         * TestWebKitAPI/PlatformEfl.cmake:
2843
2844 2013-02-18  Simon Hausmann  <simon.hausmann@digia.com>
2845
2846         [Qt] Disable the build if certain configure checks fail
2847         https://bugs.webkit.org/show_bug.cgi?id=110094
2848
2849         Reviewed by Tor Arne Vestbø.
2850
2851         Allow for the build to be skipped (clear out SUBDIRS) if certain
2852         configure conditions aren't met.
2853
2854         * qmake/mkspecs/features/configure.prf:
2855
2856 2013-02-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2857
2858         [Qt][WK2] Support WK2 API tests
2859         https://bugs.webkit.org/show_bug.cgi?id=109843
2860
2861         Reviewed by Jocelyn Turcotte.
2862
2863         * TestWebKitAPI/DerivedSources.pri: Added.
2864         * TestWebKitAPI/InjectedBundle.pri: Added.
2865         * TestWebKitAPI/PlatformWebView.h:
2866         * TestWebKitAPI/TestWebKitAPI.pri:
2867         * TestWebKitAPI/TestWebKitAPI.pro:
2868         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Added.
2869         * TestWebKitAPI/Tests/WTF/WTF.pro:
2870         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Added.
2871         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp:
2872         (TestWebKitAPI::Util::sleep):
2873         (TestWebKitAPI::Util::createInjectedBundlePath):
2874         (TestWebKitAPI::Util::createURLForResource):
2875         (TestWebKitAPI::Util::isKeyDown):
2876         (Util):
2877         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Added.
2878         (TestWebKitAPI):
2879         (WrapperWindow):
2880         (TestWebKitAPI::WrapperWindow::WrapperWindow):
2881         (TestWebKitAPI::WrapperWindow::handleStatusChanged):
2882         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2883         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2884         (TestWebKitAPI::PlatformWebView::resizeTo):
2885         (TestWebKitAPI::PlatformWebView::page):
2886         (TestWebKitAPI::PlatformWebView::focus):
2887         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2888         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2889         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2890         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2891         * TestWebKitAPI/qt/main.cpp:
2892         (addQtWebProcessToPath):
2893         (main):
2894
2895 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2896
2897         [EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API
2898         https://bugs.webkit.org/show_bug.cgi?id=108598
2899
2900         Reviewed by Kenneth Rohde Christiansen.
2901
2902         Update EFL's MiniBrowser to make use of new Ewk_Favicon API.
2903
2904         * MiniBrowser/efl/main.c:
2905         (update_view_favicon):
2906         (on_view_favicon_changed):
2907         (window_create):
2908
2909 2013-02-18  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2910
2911         Unreviewed. Add myself as a committer.
2912
2913         * Scripts/webkitpy/common/config/committers.py:
2914
2915 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
2916
2917         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
2918         https://bugs.webkit.org/show_bug.cgi?id=109554
2919
2920         In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
2921         can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
2922
2923         Drive by fix: I introduced a client interface for the HeapGraphSerializer.
2924         It helps me to do the tests for the serializer.
2925
2926         Reviewed by Yury Semikhatsky.
2927
2928         It is covered by newly added tests in TestWebKitAPI.
2929
2930         * TestWebKitAPI/TestWebKitAPI.gypi:
2931         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
2932         (TestWebKitAPI):
2933         (HeapGraphReceiver):
2934         (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
2935         (TestWebKitAPI::HeapGraphReceiver::printGraph):
2936         (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
2937         (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
2938         (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
2939         (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
2940         (TestWebKitAPI::HeapGraphReceiver::serializer):
2941         (TestWebKitAPI::HeapGraphReceiver::chunkPart):
2942         (TestWebKitAPI::HeapGraphReceiver::dumpPart):
2943         (TestWebKitAPI::HeapGraphReceiver::stringValue):
2944         (TestWebKitAPI::HeapGraphReceiver::intValue):
2945         (TestWebKitAPI::HeapGraphReceiver::nodeToString):
2946         (TestWebKitAPI::HeapGraphReceiver::edgeToString):
2947         (TestWebKitAPI::HeapGraphReceiver::printNode):
2948         (Helper):
2949         (TestWebKitAPI::Helper::Helper):
2950         (TestWebKitAPI::Helper::addNode):
2951         (TestWebKitAPI::Helper::addEdge):
2952         (TestWebKitAPI::Helper::done):
2953         (Object):
2954         (TestWebKitAPI::Helper::Object::Object):
2955         (TestWebKitAPI::TEST):
2956         (Owner):
2957         (TestWebKitAPI::Owner::Owner):
2958         (TestWebKitAPI::Owner::reportMemoryUsage):
2959
2960 2013-02-18  Ryosuke Niwa  <rniwa@webkit.org>
2961
2962         WKR build fix. Always use ascii since irclib/ircbot doesn't support unicode.
2963
2964         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2965         (NewCommitBot.next_work_item):
2966
2967 2013-02-17  Kangil Han  <kangil.han@samsung.com>
2968
2969         Unreviewed. Add myself as a committer.
2970
2971         * Scripts/webkitpy/common/config/committers.py:
2972
2973 2013-02-17  Alan Cutter  <alancutter@chromium.org>
2974
2975         GCE EWS bots are all offline
2976         https://bugs.webkit.org/show_bug.cgi?id=110069
2977
2978         Reviewed by Eric Seidel.
2979
2980         Updated GCE EWS build scripts to use the gcel-10-04-v20130104 image instead of the obsoleted ubuntu-10-04-v20120621.
2981         This changed the ephemeral disk path to /dev/sdb and required /etc/hosts to be chmodded to 644.
2982
2983         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2984         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2985         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
2986         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2987         * EWSTools/build-vm.sh:
2988         * EWSTools/start-queue.sh:
2989
2990 2013-02-18  Eugene Klyuchnikov  <eustas@chromium.org>
2991
2992         Unreviewed, add myself to commiters.py.
2993
2994         * Scripts/webkitpy/common/config/committers.py:
2995
2996 2013-02-17  Dongwoo Joshua Im  <dw.im@samsung.com>
2997
2998         Unreviewed. Add myself as a committer.
2999
3000         * Scripts/webkitpy/common/config/committers.py:
3001
3002 2013-02-17  Roger Fong  <roger_fong@apple.com>
3003
3004         Unreviewed. Fix typo in script.
3005
3006         * EWSTools/start-queue-win.sh:
3007
3008 2013-02-15  Roger Fong  <roger_fong@apple.com>
3009
3010         Pass in bot name as parameter to start-queue-win script.
3011         https://bugs.webkit.org/show_bug.cgi?id=109998.
3012
3013         Reviewed by Darin Adler.
3014
3015         * EWSTools/start-queue-win.sh:
3016
3017 2013-02-18  Byungwoo Lee  <bw80.lee@samsung.com>
3018
3019         Unreviewed. Add myself as a committer.
3020
3021         * Scripts/webkitpy/common/config/committers.py:
3022
3023 2013-02-17  Ryosuke Niwa  <rniwa@webkit.org>
3024
3025         Rename new-commit-bot to WKR to disambiguate it from commit-queue.
3026
3027         Rubber-stamped by Andreas Kling.
3028
3029         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3030         (NewCommitBot.begin_work_queue):
3031
3032 2013-02-16  Glenn Adams  <glenn@skynav.com>
3033
3034         Unreviewed. Add myself as a committer.
3035
3036         * Scripts/webkitpy/common/config/committers.py:
3037
3038 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
3039
3040         new-commit-bot should report the full name of committer and reviewer instead of just nicks
3041         https://bugs.webkit.org/show_bug.cgi?id=110040
3042
3043         Reviewed by Darin Adler.
3044
3045         Have it report names like "Ryosuke Niwa (rniwa)" instead of just "rniwa".
3046
3047         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3048         (NewCommitBot):
3049         (NewCommitBot._summarize_commit_log):
3050         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3051
3052 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
3053
3054         We need a CIA replacement
3055         https://bugs.webkit.org/show_bug.cgi?id=110008
3056
3057         Reviewed by Andreas Kling.
3058
3059         Added new-commit-bot.
3060
3061         * Scripts/webkitpy/tool/bot/queueengine.py:
3062         (QueueEngine.__init__):
3063         (QueueEngine): Made the sleep tiem configurable.
3064         (QueueEngine._sleep_message):
3065         (QueueEngine._sleep):
3066         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3067         (QueueEngineTest.test_sleep_message):
3068         * Scripts/webkitpy/tool/commands/__init__.py:
3069         * Scripts/webkitpy/tool/commands/newcommitbot.py: Added.
3070         (PingPong): Added. Implements the ping pong protocol.
3071         (NewCommitBot):
3072         (NewCommitBot.begin_work_queue):
3073         (NewCommitBot.work_item_log_path):
3074         (NewCommitBot.next_work_item): Update SVN revision and report any new commits made since
3075         the last time we checked the head SVN revision.
3076         (NewCommitBot.process_work_item):
3077         (NewCommitBot._update_checkout): svn up.
3078         (NewCommitBot._new_svn_revisions): Returns a range of new revisions.
3079         (NewCommitBot._summarize_commit_log): Summarize a commit log to be posted on IRC.
3080         (NewCommitBot.handle_unexpected_error):
3081         (NewCommitBot.handle_script_error):
3082         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Added.
3083         (NewCommitBotTest.test_summarize_commit_log_basic): Tests for summarizing non-rollout commits.
3084         (NewCommitBotTest.test_summarize_commit_log_rollout): Tests for summarizing rollouts.
3085         * Scripts/webkitpy/tool/commands/queues.py:
3086         (AbstractQueue.execute):
3087         * Scripts/webkitpy/tool/commands/queuestest.py:
3088         (MockQueueEngine.__init__):
3089         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3090         (SheriffBotTest.test_command_aliases):
3091         * Scripts/webkitpy/tool/main.py:
3092         (WebKitPatch):
3093
3094 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
3095
3096         [chromium] initialize all variables of TestRunner classes
3097         https://bugs.webkit.org/show_bug.cgi?id=110013
3098
3099         Reviewed by Adam Barth.
3100
3101         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3102         (WebTestRunner::TestInterfaces::TestInterfaces):
3103         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3104         (WebTestRunner::TestRunner::TestRunner):
3105
3106 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
3107
3108         [chromium] destroy the TestPlugin when the destroy() method is invoked.
3109         https://bugs.webkit.org/show_bug.cgi?id=110012
3110
3111         Reviewed by Adam Barth.
3112
3113         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3114         (WebTestRunner::TestPlugin::destroy):
3115
3116 2013-02-15  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3117
3118         [WK2] Write a test to simulate crashed WebProcess followed by Window resize
3119         https://bugs.webkit.org/show_bug.cgi?id=109842
3120
3121         Reviewed by Benjamin Poulain.
3122
3123         This new test will kill WebProcess, followed by next resizing the Window. It helps to
3124         identify if the port is testing for WebPageProxy data members state (e.g. DrawingArea, Frames)
3125         before making calls into them.
3126
3127         * TestWebKitAPI/GNUmakefile.am:
3128         * TestWebKitAPI/PlatformEfl.cmake:
3129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3130         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Added.
3131         (TestWebKitAPI):
3132         (TestWebKitAPI::didFinishLoad):
3133         (TestWebKitAPI::didCrash):
3134         (TestWebKitAPI::TEST):
3135
3136 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3137
3138         Add CString operators for comparison with const char*
3139         https://bugs.webkit.org/show_bug.cgi?id=109947
3140
3141         Reviewed by Darin Adler.
3142
3143         Add tests for WTF::CString's comparison operators.
3144
3145         * TestWebKitAPI/Tests/WTF/CString.cpp:
3146         (TEST):
3147
3148 2013-02-15  Zan Dobersek  <zdobersek@igalia.com>
3149
3150         webkit-patch suggest-reviewers should limit itself to 5 reviewers
3151         https://bugs.webkit.org/show_bug.cgi?id=107528
3152
3153         Reviewed by Eric Seidel.
3154
3155         * Scripts/webkitpy/common/checkout/checkout.py:
3156         (Checkout.suggested_reviewers): Iterate through the sorted commit info list,
3157         scraping reviewers from the commit information and in the end producing a list
3158         of reviewers that's sorted from the most to least recent activity of any reviewer
3159         that has reviewed or authored patches for the changed files.
3160         * Scripts/webkitpy/tool/commands/queries.py:
3161         (SuggestReviewers): Use the SuggestReviewers step instead of reimplementing much of
3162         the same logic.
3163         (SuggestReviewers._prepare_state): Force the reviewer suggestion because the option
3164         defaults to False.
3165         * Scripts/webkitpy/tool/steps/suggestreviewers.py:
3166         (SuggestReviewers.run): Only list the first five suggested reviewers, now printed out
3167         on a single line.  Only ask for CC-ing the suggested reviewers to the bug if the
3168         bug ID is located in the command's state.
3169
3170 2013-02-15  Pablo Flouret  <pablof@motorola.com>
3171
3172         Unreviewed. Add myself as a committer.
3173
3174         * Scripts/webkitpy/common/config/committers.py:
3175
3176 2013-02-15  Roger Fong  <roger_fong@apple.com>
3177
3178         Get Win EWS startup script checked into tree so we can make changes to all the EWS bots more easily.
3179
3180         * EWSTools/start-queue-win.sh: Added.
3181
3182 2013-02-15  Andreas Kling  <akling@apple.com>
3183
3184         Unbreak webkit-patch -- can't have both Committer and Contributor entry with same e-mail address.
3185
3186         * Scripts/webkitpy/common/config/committers.py:
3187
3188 2013-02-15  Joanmarie Diggs  <jdiggs@igalia.com>
3189
3190         Unreviewed. Add myself as a committer.
3191
3192         * Scripts/webkitpy/common/config/committers.py:
3193
3194 2013-02-15  Ryosuke Niwa  <rniwa@webkit.org>
3195
3196         NRWT: ML Debug Test bot is timing out after cleaning up ports
3197         https://bugs.webkit.org/show_bug.cgi?id=109912
3198
3199         Reviewed by Simon Fraser.
3200
3201         Added more debug messgaes to diagnose the issue.
3202
3203         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3204         (Manager.run):
3205
3206 2013-02-15  Claudio Saavedra  <csaavedra@igalia.com>
3207
3208         Unreviewed. Add myself as a committer.
3209
3210         * Scripts/webkitpy/common/config/committers.py:
3211
3212 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3213
3214         Unreviewed. Update Yi Shen, Antonio Gomes and Laszlo Gombos'
3215         emails on their behalf.
3216
3217         * Scripts/webkitpy/common/config/committers.py:
3218
3219 2013-02-15  Andrey Lushnikov  <lushnikov@chromium.org>
3220
3221         Web Inspector: implement smart braces functionality
3222         https://bugs.webkit.org/show_bug.cgi?id=109200
3223
3224         Reviewed by Pavel Feldman.
3225
3226         Fix eventSender.keyDown implementation to correctly process opening
3227         round brace symbol.
3228
3229         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3230         (WebTestRunner):
3231         (WebTestRunner::EventSender::keyDown):
3232
3233 2013-02-15  Jochen Eisinger  <jochen@chromium.org>
3234
3235         Speculative build fix for chromium-win.
3236
3237         Unreviewed build fix.
3238
3239         Add declarations of the copy constructor and assignment operator to
3240         WebTestProxyBase, so VS doesn't try to generate them.
3241
3242         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3243
3244 2013-02-15  Simon Hausmann  <simon.hausmann@digia.com>
3245
3246         [Qt] Port GCController to JSC C API
3247         https://bugs.webkit.org/show_bug.cgi?id=109690
3248
3249         Reviewed by Benjamin Poulain.
3250
3251         Rename TestRunner to TestRunnerQt to avoid conflict when
3252         including TestRunner.h in the future.
3253
3254         Replaced QObject based GCController implementation with JSC C API
3255         based one.
3256
3257         * DumpRenderTree/qt/DumpRenderTree.pro:
3258         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3259         (WebCore::DumpRenderTree::DumpRenderTree):
3260         (WebCore::DumpRenderTree::open):
3261         (WebCore::DumpRenderTree::initJSObjects):
3262         (WebCore::methodNameStringForFailedTest):
3263         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3264         (WebCore::DumpRenderTree::testRunner):
3265         (DumpRenderTree):
3266         * DumpRenderTree/qt/GCControllerQt.cpp:
3267         (GCController::getJSObjectCount):
3268         * DumpRenderTree/qt/GCControllerQt.h: Removed.
3269         * DumpRenderTree/qt/TestRunnerQt.cpp:
3270         (TestRunnerQt::TestRunnerQt):
3271         (TestRunnerQt::reset):
3272         (TestRunnerQt::dumpNotifications):
3273         (TestRunnerQt::processWork):
3274         (TestRunnerQt::maybeDump):
3275         (TestRunnerQt::dumpAsText):
3276         (TestRunnerQt::waitUntilDone):
3277         (TestRunnerQt::setViewModeMediaFeature):
3278         (TestRunnerQt::webHistoryItemCount):
3279         (TestRunnerQt::keepWebHistory):
3280         (TestRunnerQt::notifyDone):
3281         (TestRunnerQt::windowCount):
3282         (TestRunnerQt::grantWebNotificationPermission):
3283         (TestRunnerQt::ignoreLegacyWebNotificationPermissionRequests):
3284         (TestRunnerQt::denyWebNotificationPermission):
3285         (TestRunnerQt::removeAllWebNotificationPermissions):
3286         (TestRunnerQt::simulateWebNotificationClick):
3287         (TestRunnerQt::simulateLegacyWebNotificationClick):
3288         (TestRunnerQt::display):
3289         (TestRunnerQt::displayInvalidatedRegion):
3290         (TestRunnerQt::clearBackForwardList):
3291         (TestRunnerQt::pathToLocalResource):
3292         (TestRunnerQt::dumpEditingCallbacks):
3293         (TestRunnerQt::dumpFrameLoadCallbacks):
3294         (TestRunnerQt::dumpProgressFinishedCallback):
3295         (TestRunnerQt::dumpUserGestureInFrameLoadCallbacks):
3296         (TestRunnerQt::dumpResourceLoadCallbacks):
3297         (TestRunnerQt::dumpResourceResponseMIMETypes):
3298         (TestRunnerQt::dumpWillCacheResponse):
3299         (TestRunnerQt::dumpHistoryCallbacks):
3300         (TestRunnerQt::setWillSendRequestReturnsNullOnRedirect):
3301         (TestRunnerQt::setWillSendRequestReturnsNull):
3302         (TestRunnerQt::setWillSendRequestClearHeader):
3303         (TestRunnerQt::setDeferMainResourceDataLoad):
3304         (TestRunnerQt::queueBackNavigation):
3305         (TestRunnerQt::queueForwardNavigation):
3306         (TestRunnerQt::queueLoad):
3307         (TestRunnerQt::queueLoadHTMLString):
3308         (TestRunnerQt::queueReload):
3309         (TestRunnerQt::queueLoadingScript):
3310         (TestRunnerQt::queueNonLoadingScript):
3311         (TestRunnerQt::provisionalLoad):
3312         (TestRunnerQt::timerEvent):
3313         (TestRunnerQt::encodeHostName):
3314         (TestRunnerQt::decodeHostName):
3315         (TestRunnerQt::closeWebInspector):
3316         (TestRunnerQt::setDeveloperExtrasEnabled):
3317         (TestRunnerQt::setAsynchronousSpellCheckingEnabled):
3318         (TestRunnerQt::showWebInspector):
3319         (TestRunnerQt::evaluateInWebInspector):
3320         (TestRunnerQt::goBack):
3321         (TestRunnerQt::setDefersLoading):
3322         (TestRunnerQt::setAllowUniversalAccessFromFileURLs):
3323         (TestRunnerQt::setAllowFileAccessFromFileURLs):
3324         (TestRunnerQt::setAppCacheMaximumSize):
3325         (TestRunnerQt::setAutofilled):
3326         (TestRunnerQt::setValueForUser):
3327         (TestRunnerQt::setFixedContentsSize):
3328         (TestRunnerQt::setPrivateBrowsingEnabled):
3329         (TestRunnerQt::setSpatialNavigationEnabled):
3330         (TestRunnerQt::setPopupBlockingEnabled):
3331         (TestRunnerQt::setPluginsEnabled):
3332         (TestRunnerQt::setPOSIXLocale):
3333         (TestRunnerQt::setWindowIsKey):
3334         (TestRunnerQt::setMainFrameIsFirstResponder):
3335         (TestRunnerQt::setJavaScriptCanAccessClipboard):
3336         (TestRunnerQt::setXSSAuditorEnabled):
3337         (TestRunnerQt::dispatchPendingLoadRequests):
3338         (TestRunnerQt::clearAllApplicationCaches):
3339         (TestRunnerQt::clearApplicationCacheForOrigin):
3340         (TestRunnerQt::localStorageDiskUsageForOrigin):
3341         (TestRunnerQt::setApplicationCacheOriginQuota):
3342         (TestRunnerQt::applicationCacheDiskUsageForOrigin):
3343         (TestRunnerQt::originsWithApplicationCache):
3344         (TestRunnerQt::setCacheModel):
3345         (TestRunnerQt::setDatabaseQuota):
3346         (TestRunnerQt::clearAllDatabases):
3347         (TestRunnerQt::addOriginAccessWhitelistEntry):
3348         (TestRunnerQt::removeOriginAccessWhitelistEntry):
3349         (TestRunnerQt::setCustomPolicyDelegate):
3350         (TestRunnerQt::waitForPolicyDelegate):
3351         (TestRunnerQt::overridePreference):
3352         (TestRunnerQt::setUserStyleSheetLocation):
3353         (TestRunnerQt::setCaretBrowsingEnabled):
3354         (TestRunnerQt::setAuthorAndUserStylesEnabled):
3355         (TestRunnerQt::setUserStyleSheetEnabled):
3356         (TestRunnerQt::setDomainRelaxationForbiddenForURLScheme):
3357         (TestRunnerQt::callShouldCloseOnWebView):
3358         (TestRunnerQt::setScrollbarPolicy):
3359         (TestRunnerQt::setSmartInsertDeleteEnabled):
3360         (TestRunnerQt::setSelectTrailingWhitespaceEnabled):
3361         (TestRunnerQt::execCommand):
3362         (TestRunnerQt::isCommandEnabled):
3363         (TestRunnerQt::findString):
3364         (TestRunnerQt::markerTextForListItem):
3365         (TestRunnerQt::computedStyleIncludingVisitedInfo):
3366         (TestRunnerQt::elementDoesAutoCompleteForElementWithId):
3367         (TestRunnerQt::authenticateSession):
3368         (TestRunnerQt::setIconDatabaseEnabled):
3369         (TestRunnerQt::setMockDeviceOrientation):
3370         (TestRunnerQt::setGeolocationPermission):
3371         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
3372         (TestRunnerQt::setGeolocationPermissionCommon):
3373         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
3374         (TestRunnerQt::setMockGeolocationPosition):
3375         (TestRunnerQt::addMockSpeechInputResult):
3376         (TestRunnerQt::setMockSpeechInputDumpRect):
3377         (TestRunnerQt::startSpeechInput):
3378         (TestRunnerQt::evaluateScriptInIsolatedWorldAndReturnValue):
3379         (TestRunnerQt::evaluateScriptInIsolatedWorld):
3380         (TestRunnerQt::addUserStyleSheet):
3381         (TestRunnerQt::removeAllVisitedLinks):
3382         (TestRunnerQt::addURLToRedirect):
3383         (TestRunnerQt::originsWithLocalStorage):
3384         (TestRunnerQt::deleteAllLocalStorage):
3385         (TestRunnerQt::deleteLocalStorageForOrigin):
3386         (TestRunnerQt::observeStorageTrackerNotifications):
3387         (TestRunnerQt::syncLocalStorage):
3388         (TestRunnerQt::resetPageVisibility):
3389         (TestRunnerQt::setPageVisibility):
3390         (TestRunnerQt::setAutomaticLinkDetectionEnabled):
3391         (TestRunnerQt::setTextDirection):
3392         (TestRunnerQt::setAlwaysAcceptCookies):
3393         (TestRunnerQt::setAlwaysBlockCookies):
3394         (TestRunnerQt::setAudioData):
3395         * DumpRenderTree/qt/TestRunnerQt.h:
3396         (TestRunnerQt):
3397
3398 2013-02-14  Karen Grunberg  <kareng@chromium.org>
3399
3400         adding myself as a committer
3401
3402         * Scripts/webkitpy/common/config/committers.py:
3403
3404 2013-02-14  Glenn Adams  <glenn@skynav.com>
3405
3406         new-run-webkit-tests needs a shared TestExpectations between all WebKit ports
3407         https://bugs.webkit.org/show_bug.cgi?id=37565
3408
3409         Introduce generic TestExpectations file that applies as a fallback for all ports, the location of which
3410         is LayoutTests/TestExpectations.
3411
3412         Reviewed by Dirk Pranke.
3413
3414         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3415         (FakePort.path_to_generic_test_expectations_file):
3416         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3417         (TestExpectations.__init__):
3418         * Scripts/webkitpy/layout_tests/port/base.py:
3419         (Port.path_to_generic_test_expectations_file):
3420         (Port):
3421         (Port._port_specific_expectations_files):
3422         (Port.expectations_files):
3423         * Scripts/webkitpy/layout_tests/port/chromium.py:
3424         (ChromiumPort._port_specific_expectations_files):
3425         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3426         (ChromiumAndroidPort._port_specific_expectations_files):
3427         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
3428         (ChromiumPortTestCase.test_expectations_files):
3429         * Scripts/webkitpy/layout_tests/port/efl.py:
3430         (EflPort._port_specific_expectations_files):
3431         * Scripts/webkitpy/layout_tests/port/gtk.py:
3432         (GtkPort._port_specific_expectations_files):
3433         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3434         (GtkPortTest.test_expectations_files):
3435         * Scripts/webkitpy/layout_tests/port/mac.py:
3436         (MacPort._port_specific_expectations_files):
3437         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3438         (PortTestCase.test_expectations_ordering):
3439         (test_expectations_files):
3440         * Scripts/webkitpy/layout_tests/port/qt.py:
3441         (QtPort._port_specific_expectations_files):
3442         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3443         (QtPortTest.test_expectations_files):
3444         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3445         (WinPortTest.test_expectations_files):
3446         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3447         (PrintExpectationsTest.test_paths):
3448         * Scripts/webkitpy/tool/commands/rebaseline.py:
3449         (RebaselineTest._update_expectations_file):
3450
3451 2013-02-14  Jochen Eisinger  <jochen@chromium.org>
3452
3453         [chromium] move pixel generation logic to TestRunner library
3454         https://bugs.webkit.org/show_bug.cgi?id=109686
3455
3456         Reviewed by Stephen White.
3457
3458         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3459         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3460         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3461         (WebTestRunner):
3462         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3463         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3464         (WebTestRunner):
3465         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3466         (WebTestRunner::TestInterfaces::~TestInterfaces):
3467         (WebTestRunner::TestInterfaces::setWebView):
3468         (WebTestRunner::TestInterfaces::proxy):
3469         (WebTestRunner):
3470         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3471         (WebTestRunner):
3472         (TestInterfaces):
3473         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3474         (WebTestRunner::TestRunner::setWebView):
3475         (WebTestRunner):
3476         (WebTestRunner::TestRunner::setBackingScaleFactor):
3477         (WebTestRunner::TestRunner::display):
3478         (WebTestRunner::TestRunner::displayInvalidatedRegion):
3479         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3480         (WebTestRunner):
3481         (TestRunner):
3482         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3483         (WebTestRunner::WebTestInterfaces::setWebView):
3484         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3485         (WebTestRunner::WebTestProxyBase::reset):
3486         (WebTestRunner::WebTestProxyBase::capturePixels):
3487         (WebTestRunner):
3488         (WebTestRunner::WebTestProxyBase::paintRect):
3489         (WebTestRunner::WebTestProxyBase::paintInvalidatedRegion):
3490         (WebTestRunner::WebTestProxyBase::paintPagesWithBoundaries):
3491         (WebTestRunner::WebTestProxyBase::canvas):
3492         (WebTestRunner::WebTestProxyBase::displayRepaintMask):
3493         (WebTestRunner::WebTestProxyBase::display):
3494         (WebTestRunner::WebTestProxyBase::displayInvalidatedRegion):
3495         (WebTestRunner::WebTestProxyBase::discardBackingStore):
3496         (WebTestRunner::WebTestProxyBase::setWindowRect):
3497         (WebTestRunner::WebTestProxyBase::userMediaClient):
3498         * DumpRenderTree/chromium/TestShell.cpp:
3499         (TestShell::createMainWindow):
3500         (TestShell::~TestShell):
3501         (TestShell::showDevTools):
3502         (TestShell::closeDevTools):
3503         (TestShell::dump):
3504         * DumpRenderTree/chromium/WebViewHost.cpp:
3505         (WebViewHost::setWindowRect):
3506         (WebViewHost::setDeviceScaleFactor):
3507         (WebViewHost::reset):
3508         * DumpRenderTree/chromium/WebViewHost.h:
3509         (WebViewHost):
3510
3511 2013-02-14  Tony Chang  <tony@chromium.org>
3512
3513         Unreviewed, set svn:eol-style native for .sln, .vcproj, and .vsprops files.
3514         https://bugs.webkit.org/show_bug.cgi?id=96934
3515
3516         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3517         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3518         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added property svn:eol-style.
3519         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added property svn:eol-style.
3520         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added property svn:eol-style.
3521         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3522         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added property svn:eol-style.
3523         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added property svn:eol-style.
3524         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3525         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added property svn:eol-style.
3526         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added property svn:eol-style.
3527         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added property svn:eol-style.
3528         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3529         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added property svn:eol-style.
3530         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added property svn:eol-style.
3531         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3532         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added property svn:eol-style.
3533         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3534         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added property svn:eol-style.
3535         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added property svn:eol-style.
3536         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added property svn:eol-style.
3537         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3538         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added property svn:eol-style.
3539         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added property svn:eol-style.
3540         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3541         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added property svn:eol-style.
3542         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added property svn:eol-style.
3543         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added property svn:eol-style.
3544         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added property svn:eol-style.
3545         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added property svn:eol-style.
3546         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added property svn:eol-style.
3547         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3548         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added property svn:eol-style.
3549         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
3550         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added property svn:eol-style.
3551         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added property svn:eol-style.
3552         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added property svn:eol-style.
3553         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3554         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added property svn:eol-style.
3555         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added property svn:eol-style.
3556         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3557         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added property svn:eol-style.
3558         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added property svn:eol-style.
3559         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added property svn:eol-style.
3560         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
3561         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added property svn:eol-style.
3562         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added property svn:eol-style.
3563         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
3564
3565 2013-02-14  Tony Chang  <tony@chromium.org>
3566
3567         Unreviewed, set svn:eol-style CRLF for .sln files.
3568
3569         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3570         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3571         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3572         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
3573
3574 2013-02-14  Zan Dobersek  <zdobersek@igalia.com>
3575
3576         [GTK] Errors when building WebKit2 with Clang
3577         https://bugs.webkit.org/show_bug.cgi?id=109603
3578
3579         Reviewed by Alexey Proskuryakov.
3580
3581         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3582         (WTR::PlatformWebView::resizeTo): Cast the width and height parameters to the integer
3583         type when constructing the GtkAllocation.
3584
3585         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3586         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3587         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3588         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
3589
3590 2013-02-14  Roger Fong  <roger_fong@apple.com>
3591
3592         Add eol-style=native to solution files. Add a new solution file.
3593
3594         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added property svn:eol-style.
3595         * TestWebKitAPI/TestWebKitAPI.vcxproj: Added property svn:eol-style. Modified property svn:ignore.
3596         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Added.
3597
3598 2013-02-14  Mario Sanchez Prada  <mario.prada@samsung.com>
3599
3600         [GTK] Missing call to g_object_ref while retrieving accessible table cells
3601         https://bugs.webkit.org/show_bug.cgi?id=106903
3602
3603         Reviewed by Martin Robinson.
3604
3605         Both DRT and WKTR need to call g_object_unref() now that an extra
3606         reference is added in the implementation of atk_table_ref_at().
3607
3608         * DumpRenderTree/atk/AccessibilityUIElementGtk.cpp:
3609         (AccessibilityUIElement::cellForColumnAndRow): Call g_object_unref
3610         before returning the new instance of AccessibilityUIElement.
3611         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3612         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
3613
3614 2013-02-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3615
3616         Unreviewed, rolling out r142841.
3617         http://trac.webkit.org/changeset/142841
3618         https://bugs.webkit.org/show_bug.cgi?id=109791
3619
3620         Caused webkit_unit_tests to crash on chromium bots. (Requested
3621         by atwilson_ on #webkit).
3622
3623         * DumpRenderTree/chromium/WebViewHost.cpp:
3624         (WebViewHost::createOutputSurface):
3625         (WebViewHost::initializeLayerTreeView):
3626
3627 2013-02-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3628
3629         [EFL][jhbuild] Silence GSettings-related warning.
3630         https://bugs.webkit.org/show_bug.cgi?id=109749
3631
3632         Reviewed by Martin Robinson.
3633
3634         Apply the same change done to the GTK+ port in r109127; this
3635         silences the warnings printed by glib about the memory GSettings
3636         backend being used.
3637
3638         Not only does this make the bots (as well as manual runs of, say,
3639         WebKitTestRunner) much more silent, but it also removes an stderr
3640         line (which run-perf-tests considers as a failure).
3641
3642         * Scripts/webkitpy/layout_tests/port/efl.py:
3643         (EflPort.setup_environ_for_server): Explicitly set the
3644         GSETTINGS_BACKEND environment variable to "memory".
3645
3646 2013-02-14  Jochen Eisinger  <jochen@chromium.org>
3647
3648         [chromium] move mock notification presenter to TestRunner library
3649         https://bugs.webkit.org/show_bug.cgi?id=109706
3650
3651         Reviewed by Adam Barth.
3652
3653         * DumpRenderTree/DumpRenderTree.gypi:
3654         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3655         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3656         (WebKit):
3657         (WebTestRunner::WebTestProxy::notificationPresenter):
3658         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.cpp.
3659         (WebTestRunner::NotificationPresenter::NotificationPresenter):
3660         (WebTestRunner):
3661         (WebTestRunner::NotificationPresenter::~NotificationPresenter):
3662         (WebTestRunner::NotificationPresenter::grantPermission):
3663         (WebTestRunner::NotificationPresenter::simulateClick):
3664         (WebTestRunner::NotificationPresenter::show):
3665         (WebTestRunner::NotificationPresenter::cancel):
3666         (WebTestRunner::NotificationPresenter::objectDestroyed):
3667         (WebTestRunner::NotificationPresenter::checkPermission):
3668         (WebTestRunner::NotificationPresenter::requestPermission):
3669         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.h.
3670         (WebTestRunner):
3671         (NotificationPresenter):
3672         (WebTestRunner::NotificationPresenter::setDelegate):
3673         (WebTestRunner::NotificationPresenter::reset):
3674         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3675         (WebTestRunner::TestRunner::TestRunner):
3676         (WebTestRunner::TestRunner::setDelegate):
3677         (WebTestRunner::TestRunner::reset):
3678         (WebTestRunner::TestRunner::notificationPresenter):
3679         (WebTestRunner):
3680         (WebTestRunner::TestRunner::grantWebNotificationPermission):
3681         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
3682         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3683         (WebKit):
3684         (WebTestRunner):
3685         (TestRunner):
3686         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3687         (WebTestRunner::WebTestProxyBase::notificationPresenter):
3688         (WebTestRunner):
3689         * DumpRenderTree/chromium/TestShell.cpp:
3690         (TestShell::initialize):
3691         (TestShell::resetTestController):
3692         * DumpRenderTree/chromium/TestShell.h:
3693         (WebKit):
3694         (TestShell):
3695         * DumpRenderTree/chromium/WebViewHost.cpp:
3696         * DumpRenderTree/chromium/WebViewHost.h:
3697
3698 2013-02-13  Roger Fong  <roger_fong@apple.com>
3699
3700         Unreviewed. Add separate DumpRenderTree VS2010 solution file.
3701
3702         * DumpRenderTree/DumpRenderTree.vcxproj: Added property svn:ignore.
3703         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added.
3704
3705 2013-02-12  James Robinson  <jamesr@chromium.org>
3706
3707         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
3708         https://bugs.webkit.org/show_bug.cgi?id=109634
3709
3710         Reviewed by Adrienne Walker.
3711
3712         * DumpRenderTree/chromium/WebViewHost.cpp:
3713         (WebViewHost::createOutputSurface):
3714         (WebViewHost::initializeLayerTreeView):
3715
3716 2013-02-13  David Farler  <dfarler@apple.com>
3717
3718         TestWebKitAPI fails to build for iphonesimulator: 'CFNetwork/CFNetworkDefs.h' file not found
3719         https://bugs.webkit.org/show_bug.cgi?id=109766
3720
3721         Reviewed by David Kilzer.
3722
3723         * TestWebKitAPI/Configurations/Base.xcconfig:
3724         - Don't search Mac OS X header search paths when building on iOS
3725
3726 2013-02-13  Zan Dobersek  <zdobersek@igalia.com>
3727
3728         The 'global isinf/isnan' compiler quirk required when using clang with libstdc++
3729         https://bugs.webkit.org/show_bug.cgi?id=109325
3730
3731         Reviewed by Anders Carlsson.
3732
3733         Prefix calls to the isinf and isnan methods with std::, declaring we want to use the
3734         two methods as they're provided by the C++ standard library being used.
3735
3736         * DumpRenderTree/TestRunner.cpp:
3737         (setAppCacheMaximumSizeCallback):
3738         (setApplicationCacheOriginQuotaCallback):
3739         (setDatabaseQuotaCallback):
3740
3741 2013-02-13  Alan Cutter  <alancutter@chromium.org>
3742
3743         cr-linux debug should use clang and maybe be a components build
3744         https://bugs.webkit.org/show_bug.cgi?id=108512
3745
3746         Reviewed by Adam Barth.
3747
3748         Modified GCE cr-linux-debug-ews bot build scripts to configure clang over gcc for build performance.
3749         Build bots will update clang with each bot cycle.
3750         Updated GCE image paths to suit gcutil 1.6.1.
3751
3752         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3753         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3754         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
3755         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3756         * EWSTools/configure-clang-linux.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
3757         * EWSTools/start-queue.sh:
3758
3759 2013-02-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3760
3761         Unreviewed, rolling out r142747.
3762         http://trac.webkit.org/changeset/142747
3763         https://bugs.webkit.org/show_bug.cgi?id=109746
3764
3765         broke component build (Requested by alecf_gardening on
3766         #webkit).
3767
3768         * TestWebKitAPI/TestWebKitAPI.gypi:
3769         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
3770
3771 2013-02-13  Jochen Eisinger  <jochen@chromium.org>
3772
3773         [chromium] fix TestRunner build with enable_webrtc=0
3774         https://bugs.webkit.org/show_bug.cgi?id=109700
3775
3776         Reviewed by Tony Chang.
3777
3778         We can't use ENABLE() macros in the TestRunner library, however,
3779         ENABLE_WEBRTC is defined by build/common.gypi, so we can use it.
3780
3781         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp:
3782         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
3783         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp:
3784         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp:
3785         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3786         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3787         (WebTestRunner):
3788         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3789         (WebTestRunner::WebTestProxyBase::userMediaClient):
3790         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
3791
3792 2013-02-12  Roger Fong  <roger_fong@apple.com>
3793
3794         TestWebKitAPI and record-memory projects and property sheets for VS2010.
3795         https://bugs.webkit.org/show_bug.cgi?id=107034
3796
3797         Reviewed by Brent Fulgham.
3798
3799         * TestWebKitAPI/TestWebKitAPI.vcxproj: Added.
3800         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Added.
3801         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Added.
3802         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd.
3803         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd.
3804         * win/record-memory: Added.
3805         * win/record-memory/main.cpp: Copied from Tools/record-memory-win/main.cpp.
3806         * win/record-memory/record-memory.vcxproj: Added.
3807         * win/record-memory/record-memory.vcxproj.filters: Added.
3808         * win/record-memory/record-memoryCommon.props: Added.
3809         * win/record-memory/record-memoryDebug.props: Added.
3810         * win/record-memory/record-memoryRelease.props: Added.
3811
3812 2013-02-13  Tommy Widenflycht  <tommyw@google.com>
3813
3814         MediaStream API: Use the source id when creating new tracks
3815         https://bugs.webkit.org/show_bug.cgi?id=109688
3816
3817         Reviewed by Adam Barth.
3818
3819         Switching mock to new API.
3820
3821         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
3822         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
3823
3824 2013-02-13  Brent Fulgham  <bfulgham@webkit.org>
3825
3826         [Windows] Unreviewed VS2010 fix to add $(ConfigurationBuildDir)/private
3827         to include paths, to match VS2005 build behavior.
3828
3829         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
3830         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
3831         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
3832         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
3833         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
3834
3835 2013-02-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3836
3837         Unreviewed, rolling out r142736.
3838         http://trac.webkit.org/changeset/142736
3839         https://bugs.webkit.org/show_bug.cgi?id=109716
3840
3841         Broke ABI, nightly builds crash on launch (Requested by ap on
3842         #webkit).
3843
3844         * MiniBrowser/mac/WK2BrowserWindowController.m:
3845         (-[WK2BrowserWindowController awakeFromNib]):
3846         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3847         (WTR::InjectedBundlePage::InjectedBundlePage):
3848         * WebKitTestRunner/TestController.cpp:
3849         (WTR::TestController::createWebViewWithOptions):
3850
3851 2013-02-13  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3852
3853         [WK2][EFL][WTR] Regression(r141836): WTR crashes on exit
3854         https://bugs.webkit.org/show_bug.cgi?id=109456
3855
3856         Reviewed by Anders Carlsson.
3857
3858         WebView instance must not live longer than EwkView, as EwkView owns
3859         objects that page proxy refers to, doing otherwise leads to a crash.
3860
3861         Test controller has own ptr containing WebView. Invoking of ewk_shutdown()
3862         leads to evas objects deletion. So, the problem was that test controller was
3863         deleted after ewk_shutdown() had been called in main() function causing
3864         crashes on WTR exit.
3865
3866         The patch introduces a scope for test controller so that it is deleted first.
3867
3868         * WebKitTestRunner/efl/main.cpp:
3869         (main):
3870
3871 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
3872
3873         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
3874         https://bugs.webkit.org/show_bug.cgi?id=109554
3875
3876         In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
3877         can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
3878
3879         Drive by fix: I introduced a client interface for the HeapGraphSerializer.
3880         It helps me to do the tests for the serializer.
3881
3882         Reviewed by Yury Semikhatsky.
3883
3884         It is covered by newly added tests in TestWebKitAPI.
3885
3886         * TestWebKitAPI/TestWebKitAPI.gypi:
3887         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
3888         (TestWebKitAPI):
3889         (HeapGraphReceiver):
3890         (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
3891         (TestWebKitAPI::HeapGraphReceiver::printGraph):
3892         (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
3893         (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
3894         (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
3895         (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
3896         (TestWebKitAPI::HeapGraphReceiver::serializer):
3897         (TestWebKitAPI::HeapGraphReceiver::chunkPart):
3898         (TestWebKitAPI::HeapGraphReceiver::dumpPart):
3899         (TestWebKitAPI::HeapGraphReceiver::stringValue):
3900         (TestWebKitAPI::HeapGraphReceiver::intValue):
3901         (TestWebKitAPI::HeapGraphReceiver::nodeToString):
3902         (TestWebKitAPI::HeapGraphReceiver::edgeToString):
3903         (TestWebKitAPI::HeapGraphReceiver::printNode):
3904         (Helper):
3905         (TestWebKitAPI::Helper::Helper):
3906         (TestWebKitAPI::Helper::addNode):
3907         (TestWebKitAPI::Helper::addEdge):
3908         (TestWebKitAPI::Helper::done):
3909         (Object):
3910         (TestWebKitAPI::Helper::Object::Object):
3911         (TestWebKitAPI::TEST):
3912         (Owner):
3913         (TestWebKitAPI::Owner::Owner):
3914         (TestWebKitAPI::Owner::reportMemoryUsage):
3915
3916 2013-02-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3917
3918         [WK2] Remove web intents callbacks
3919         https://bugs.webkit.org/show_bug.cgi?id=109654
3920
3921         Reviewed by Benjamin Poulain.
3922
3923         Web intents was removed by r142549.
3924
3925         * MiniBrowser/mac/WK2BrowserWindowController.m:
3926         (-[WK2BrowserWindowController awakeFromNib]):
3927         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3928         (WTR::InjectedBundlePage::InjectedBundlePage):
3929         * WebKitTestRunner/TestController.cpp:
3930         (WTR::TestController::createWebViewWithOptions):
3931
3932 2013-02-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3933
3934         [WK2] Page reloading will crash UIProcess after WebProcess was killed
3935         https://bugs.webkit.org/show_bug.cgi?id=109305
3936
3937         Reviewed by Benjamin Poulain.
3938
3939         Adding a new test to simulate the case of WebProcess crash followed by a trying
3940         to load a new page.
3941
3942         * TestWebKitAPI/GNUmakefile.am:
3943         * TestWebKitAPI/PlatformEfl.cmake:
3944         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3945         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Added.
3946         (TestWebKitAPI):
3947         (TestWebKitAPI::didFinishLoad):
3948         (TestWebKitAPI::TEST):
3949
3950 2013-02-11  Brent Fulgham  <bfulgham@webkit.org>
3951
3952         Update WebKitDirs.pm for new Windows paths
3953         https://bugs.webkit.org/show_bug.cgi?id=107714
3954
3955         Reviewed by Daniel Bates.
3956
3957         * Scripts/webkitdirs.pm: For each existing Windows environment
3958         variable, also include creation of the 'new' variables. The
3959         'old' variables will be removed in a future update.
3960         (windowsSourceSourceDir): New helper routine to return the
3961         actual 'Source' folder of the WebKit source tree.
3962
3963 2013-02-12  Alec Flett  <alecflett@chromium.org>
3964
3965         Fix signedness in WebTestProxy
3966         https://bugs.webkit.org/show_bug.cgi?id=109623
3967
3968         Reviewed by Adam Barth.
3969
3970         Fix signedness problem, using size_t instead of int.
3971
3972         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3973
3974 2013-02-12  Raymond Toy  <rtoy@google.com>
3975
3976         Add alias
3977         https://bugs.webkit.org/show_bug.cgi?id=109621
3978
3979         No review needed.
3980
3981         * Scripts/webkitpy/common/config/committers.py:
3982
3983 2013-02-12  Jochen Eisinger  <jochen@chromium.org>
3984
3985         [chromium] move text dump generation to TestRunner library
3986         https://bugs.webkit.org/show_bug.cgi?id=109575
3987
3988         Reviewed by Adam Barth.
3989
3990         * DumpRenderTree/DumpRenderTree.gypi:
3991         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3992         (WebKit):
3993         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
3994         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3995         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3996         (WebTestRunner):
3997         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.h.
3998         (WebTestRunner::normalizeLayoutTestURL):
3999         (WebTestRunner):
4000         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h:
4001         (WebTestRunner):
4002         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4003         (WebTestRunner::TestRunner::checkResponseMimeType):
4004         (WebTestRunner):
4005         (WebTestRunner::TestRunner::shouldDumpAsText):
4006         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
4007         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4008         (TestRunner):
4009         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
4010         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4011         (WebTestRunner::WebTestProxyBase::captureTree):
4012         (WebTestRunner):
4013         * DumpRenderTree/chromium/TestShell.cpp:
4014         (TestShell::dump):
4015         (TestShell::captureHistoryForWindow):
4016         * DumpRenderTree/chromium/TestShell.h:
4017         (TestShell):
4018         * DumpRenderTree/chromium/WebViewHost.cpp:
4019         (WebViewHost::captureHistoryForWindow):
4020         * DumpRenderTree/chromium/WebViewHost.h:
4021
4022 2013-02-12  Jessie Berlin  <jberlin@apple.com>
4023
4024         Rollout r142618, it broke all the Mac builds.
4025
4026         * TestWebKitAPI/TestWebKitAPI.gypi:
4027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4028         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
4029         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4030
4031 2013-02-12  Yury Semikhatsky  <yurys@chromium.org>
4032
4033         Unreviewed. Fix Chromium compilation after r142618.
4034
4035         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
4036         (TestWebKitAPI::HeapGraphReceiver::printNode):
4037
4038 2013-02-12  Martin Robinson  <mrobinson@igalia.com>
4039
4040         [GTK] Add an optional moduleset with hard to get packages (including libsecret)
4041         https://bugs.webkit.org/show_bug.cgi?id=109195
4042
4043         Reviewed by Philippe Normand.
4044
4045         Add an optional moduleset that includes libsecret. This moduleset will
4046         be used to install some annoyingly hard to obtain dependencies on older
4047         distributions.
4048
4049         * gtk/jhbuild-optional.modules: Added.
4050         * gtk/jhbuild.modules: Add a reference to the new moduleset file.
4051
4052 2013-02-12  Ilya Tikhonovsky  <loislo@chromium.org>
4053
4054         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
4055         https://bugs.webkit.org/show_bug.cgi?id=109554
4056
4057         In some cases leaves have no pointer. As example when we report a leaf via addPrivateBuffer.
4058         This patch has new set of tests for HeapGraphSerializer.
4059
4060         Reviewed by Yury Semikhatsky.
4061
4062         * TestWebKitAPI/TestWebKitAPI.gypi:
4063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4064         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
4065         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4066
4067 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
4068
4069         Unreviewed followup to r142606, the EFL port also enables the CSS image-set
4070         feature so the new configuration option's default value should reflect that.
4071
4072         * Scripts/webkitperl/FeatureList.pm:
4073
4074 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
4075
4076         [GTK] Enable CSS Variables feature in development builds
4077         https://bugs.webkit.org/show_bug.cgi?id=109474
4078
4079         Reviewed by Martin Robinson.
4080
4081         * Scripts/webkitperl/FeatureList.pm: Enable the feature on development
4082         builds of the GTK port.
4083
4084 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
4085
4086         [GTK] Enable CSS image-set support in development builds
4087         https://bugs.webkit.org/show_bug.cgi?id=109475
4088
4089         Reviewed by Martin Robinson.
4090
4091         * Scripts/webkitperl/FeatureList.pm: Add the configuration option for the feature.
4092         Note that the Mac port also enables the feature but does so in Platform.h as the feature
4093         is also enabled for the iOS port which can't at the moment be detected via webkitperl.
4094
4095 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
4096
4097         [GTK] Enable DOM4 events constructors in development builds
4098         https://bugs.webkit.org/show_bug.cgi?id=109471
4099
4100         Reviewed by Martin Robinson.
4101
4102         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the GTK port as well.
4103
4104 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
4105
4106         Remove unnecessary variables from FeatureList.pm
4107         https://bugs.webkit.org/show_bug.cgi?id=109558
4108
4109         Reviewed by Daniel Bates.
4110
4111         A small cleanup, removing unused variables for which the related configuration
4112         options were already removed.
4113
4114         * Scripts/webkitperl/FeatureList.pm:
4115
4116 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
4117
4118         Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
4119         https://bugs.webkit.org/show_bug.cgi?id=109481
4120
4121         Reviewed by Daniel Bates.
4122
4123         The ENABLE_XHR_RESPONSE_BLOB feature define was removed from the code
4124         back in r120574. There are still occurrences of it in various build systems
4125         which should all be removed as they are useless.
4126
4127         * Scripts/webkitperl/FeatureList.pm:
4128
4129 2013-02-12  Jochen Eisinger  <jochen@chromium.org>
4130
4131         [chromium] move webrtc mocks to testrunner library
4132         https://bugs.webkit.org/show_bug.cgi?id=109041
4133
4134         Reviewed by Adam Barth.
4135
4136         * DumpRenderTree/DumpRenderTree.gypi:
4137         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4138         (WebKitSupportTestEnvironment):
4139         (WebKitSupportTestEnvironment::mockPlatform):
4140         (main):
4141         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
4142         (MockWebKitPlatformSupport::setInterfaces):
4143         (MockWebKitPlatformSupport::createMediaStreamCenter):
4144         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
4145         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
4146         (WebTestRunner):
4147         (MockWebKitPlatformSupport):
4148         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
4149         (WebKit):
4150         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4151         (WebKit):
4152         (WebTestRunner):
4153         (WebTestRunner::WebTestProxy::showContextMenu):
4154         (WebTestRunner::WebTestProxy::userMediaClient):
4155         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.cpp.
4156         (WebTestRunner::MockConstraints::verifyConstraints):
4157         (WebTestRunner):
4158         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.h.
4159         (WebKit):
4160         (WebTestRunner):
4161         (MockConstraints):
4162         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp.
4163         (WebTestRunner):
4164         (WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
4165         (WebTestRunner::MockWebMediaStreamCenter::queryMediaStreamSources):
4166         (WebTestRunner::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
4167         (WebTestRunner::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
4168         (WebTestRunner::MockWebMediaStreamCenter::didAddMediaStreamTrack):
4169         (WebTestRunner::MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
4170         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
4171         (MockWebAudioDestinationConsumer):
4172         (WebTestRunner::MockWebAudioDestinationConsumer::~MockWebAudioDestinationConsumer):
4173         (WebTestRunner::MockWebMediaStreamCenter::didCreateMediaStream):
4174         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.h.
4175         (WebKit):
4176         (WebTestRunner):
4177         (MockWebMediaStreamCenter):
4178         (WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
4179         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.cpp.
4180         (WebTestRunner):
4181         (DTMFSenderToneTask):
4182         (WebTestRunner::DTMFSenderToneTask::DTMFSenderToneTask):
4183         (WebTestRunner::MockWebRTCDTMFSenderHandler::MockWebRTCDTMFSenderHandler):
4184         (WebTestRunner::MockWebRTCDTMFSenderHandler::setClient):
4185         (WebTestRunner::MockWebRTCDTMFSenderHandler::currentToneBuffer):
4186         (WebTestRunner::MockWebRTCDTMFSenderHandler::canInsertDTMF):
4187         (WebTestRunner::MockWebRTCDTMFSenderHandler::insertDTMF):
4188         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.h.
4189         (WebTestRunner):
4190         (MockWebRTCDTMFSenderHandler):
4191         (WebTestRunner::MockWebRTCDTMFSenderHandler::taskList):
4192         (WebTestRunner::MockWebRTCDTMFSenderHandler::clearToneBuffer):
4193         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.cpp.
4194         (WebTestRunner):
4195         (DataChannelReadyStateTask):
4196         (WebTestRunner::DataChannelReadyStateTask::DataChannelReadyStateTask):
4197         (WebTestRunner::MockWebRTCDataChannelHandler::MockWebRTCDataChannelHandler):
4198         (WebTestRunner::MockWebRTCDataChannelHandler::setClient):
4199         (WebTestRunner::MockWebRTCDataChannelHandler::bufferedAmount):
4200         (WebTestRunner::MockWebRTCDataChannelHandler::sendStringData):
4201         (WebTestRunner::MockWebRTCDataChannelHandler::sendRawData):
4202         (WebTestRunner::MockWebRTCDataChannelHandler::close):
4203         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.h.
4204         (WebTestRunner):
4205         (MockWebRTCDataChannelHandler):
4206         (WebTestRunner::MockWebRTCDataChannelHandler::taskList):
4207         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp.
4208         (WebTestRunner):
4209         (RTCSessionDescriptionRequestSuccededTask):
4210         (WebTestRunner::RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
4211         (RTCSessionDescriptionRequestFailedTask):
4212         (WebTestRunner::RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
4213         (RTCStatsRequestSucceededTask):
4214         (WebTestRunner::RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
4215         (RTCVoidRequestTask):
4216         (WebTestRunner::RTCVoidRequestTask::RTCVoidRequestTask):
4217         (RTCPeerConnectionStateTask):
4218         (WebTestRunner::RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
4219         (RemoteDataChannelTask):
4220         (WebTestRunner::RemoteDataChannelTask::RemoteDataChannelTask):
4221         (WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
4222         (WebTestRunner::MockWebRTCPeerConnectionHandler::initialize):
4223         (WebTestRunner::MockWebRTCPeerConnectionHandler::createOffer):
4224         (WebTestRunner::MockWebRTCPeerConnectionHandler::createAnswer):
4225         (WebTestRunner::MockWebRTCPeerConnectionHandler::setLocalDescription):
4226         (WebTestRunner::MockWebRTCPeerConnectionHandler::setRemoteDescription):
4227         (WebTestRunner::MockWebRTCPeerConnectionHandler::localDescription):
4228         (WebTestRunner::MockWebRTCPeerConnectionHandler::remoteDescription):
4229         (WebTestRunner::MockWebRTCPeerConnectionHandler::updateICE):
4230         (WebTestRunner::MockWebRTCPeerConnectionHandler::addICECandidate):
4231         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
4232         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
4233         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
4234         (WebTestRunner::MockWebRTCPeerConnectionHandler::createDataChannel):
4235         (WebTestRunner::MockWebRTCPeerConnectionHandler::createDTMFSender):
4236         (WebTestRunner::MockWebRTCPeerConnectionHandler::stop):
4237         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.
4238         (WebKit):
4239         (WebTestRunner):
4240         (MockWebRTCPeerConnectionHandler):
4241         (WebTestRunner::MockWebRTCPeerConnectionHandler::taskList):
4242         (WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
4243         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4244         (WebTestRunner::TestInterfaces::TestInterfaces):
4245         (WebTestRunner::TestInterfaces::setDelegate):
4246         (WebTestRunner::TestInterfaces::delegate):
4247         (WebTestRunner):
4248         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
4249         (TestInterfaces):
4250         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
4251         (WebTestRunner::WebTestInterfaces::createMediaStreamCenter):
4252         (WebTestRunner):
4253         (WebTestRunner::WebTestInterfaces::createWebRTCPeerConnectionHandler):
4254         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4255         (WebTestRunner::WebTestProxyBase::userMediaClient):
4256         (WebTestRunner):
4257         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp.
4258         (WebTestRunner):
4259         (UserMediaRequestTask):
4260         (WebTestRunner::UserMediaRequestTask::UserMediaRequestTask):
4261         (MockExtraData):
4262         (WebTestRunner::WebUserMediaClientMock::WebUserMediaClientMock):
4263         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
4264         (WebTestRunner::WebUserMediaClientMock::cancelUserMediaRequest):
4265         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h.
4266         (WebTestRunner):
4267         (WebUserMediaClientMock):
4268         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
4269         (WebTestRunner::WebUserMediaClientMock::taskList):
4270         * DumpRenderTree/chromium/TestShell.cpp:
4271         (TestShell::initialize):
4272         * DumpRenderTree/chromium/TestShell.h:
4273         (TestShell):
4274  &n