Unreviewed, rolling out r241229.
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-11  Truitt Savell  <tsavell@apple.com>
2
3         Unreviewed, rolling out r241229.
4
5         Revision broke internal builds for watchOS.
6
7         Reverted changeset:
8
9         "[Cocoa] Ask platform for generic font family mappings"
10         https://bugs.webkit.org/show_bug.cgi?id=187723
11         https://trac.webkit.org/changeset/241229
12
13 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
14
15         [WinCairo][MiniBrowser] Basic authentication always fails.
16         https://bugs.webkit.org/show_bug.cgi?id=194496
17
18         Reviewed by Don Olmstead.
19
20         * MiniBrowser/win/DialogHelper.h:
21         (Dialog::getText):
22
23 2019-02-11  Philippe Normand  <pnormand@igalia.com>
24
25         [GStreamer] GstMappedBuffer testsuite build fails
26         https://bugs.webkit.org/show_bug.cgi?id=194495
27
28         Reviewed by Carlos Garcia Campos.
29
30         Fix the build by explicitely adding the gstreamer1.0-audio include
31         directories to the include path.
32
33         * TestWebKitAPI/PlatformGTK.cmake:
34         * TestWebKitAPI/PlatformWPE.cmake:
35
36 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
37
38         [GTK][WPE] Add enable-javascript-markup setting
39         https://bugs.webkit.org/show_bug.cgi?id=193439
40
41         Reviewed by Michael Catanzaro.
42
43         Add test cases to check the new setting.
44
45         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
46         (testWebKitSettings):
47         (testWebKitSettingsJavaScriptMarkup):
48         (beforeAll):
49
50 2019-02-10  Darin Adler  <darin@apple.com>
51
52         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
53         https://bugs.webkit.org/show_bug.cgi?id=194485
54
55         Reviewed by Daniel Bates.
56
57         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
58
59 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
60
61         Add more tests for clampTo<>()
62         https://bugs.webkit.org/show_bug.cgi?id=194462
63
64         Reviewed by Geoffrey Garen.
65
66         Darin suggested to test the very last floating point number
67         at the boundaries when truncating to integer.
68         I added test for max/min and max-1/min-1.
69
70         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
71         (TestWebKitAPI::TEST):
72
73 2019-02-09  Darin Adler  <darin@apple.com>
74
75         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
76         https://bugs.webkit.org/show_bug.cgi?id=194021
77
78         Reviewed by Geoffrey Garen.
79
80         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
81         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
82         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
83
84 2019-02-09  Zalan Bujtas  <zalan@apple.com>
85
86         [LFC][IFC] Add intrinsic width support for basic inline containers
87         https://bugs.webkit.org/show_bug.cgi?id=194473
88
89         Reviewed by Antti Koivisto.
90
91         Expand tests coverage (11 new tests -> 798)
92
93         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
94
95 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
96
97         Fix MiniBrowser's entitlements
98         https://bugs.webkit.org/show_bug.cgi?id=192431
99
100         Reviewed by Joseph Pecoraro.
101
102         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
103         files, making it impossible to load any extension.
104
105         * MiniBrowser/MiniBrowser.entitlements:
106
107 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
108
109         [Cocoa] Ask platform for generic font family mappings
110         https://bugs.webkit.org/show_bug.cgi?id=187723
111         <rdar://problem/41892438>
112
113         Reviewed by Brent Fulgham.
114
115         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
116
117         * DumpRenderTree/mac/DumpRenderTree.mm:
118         (allowedFontFamilySet):
119         * WebKitTestRunner/mac/TestControllerMac.mm:
120         (WTR::allowedFontFamilySet):
121
122 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
123
124         [GTK] Implement back/forward touchpad gesture
125         https://bugs.webkit.org/show_bug.cgi?id=193919
126
127         Reviewed by Michael Catanzaro.
128
129         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
130         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
131
132 2019-02-08  Alex Christensen  <achristensen@webkit.org>
133
134         Add SPI to use networking daemon instead of XPC service
135         https://bugs.webkit.org/show_bug.cgi?id=194427
136
137         Reviewed by Geoffrey Garen
138
139         * MiniBrowser/MiniBrowser.entitlements:
140
141 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
142
143         [ews-build] Ensure that every builder in config.json has short name
144         https://bugs.webkit.org/show_bug.cgi?id=194461
145
146         Reviewed by Lucas Forschler.
147
148         * BuildSlaveSupport/ews-build/loadConfig.py:
149         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
150
151 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
152
153         [ews-build] Add short name to config.json
154         https://bugs.webkit.org/show_bug.cgi?id=194456
155
156         Reviewed by Lucas Forschler.
157
158         * BuildSlaveSupport/ews-build/config.json: Added short name.
159         * BuildSlaveSupport/ews-build/loadConfig.py:
160         (loadBuilderConfig): Set the short name as the builder description.
161
162 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
163
164         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
165         https://bugs.webkit.org/show_bug.cgi?id=194418
166
167         Reviewed by Lucas Forschler.
168
169         Do not include errors trying when finding crashlogs at the end of
170         a run-webkit-tests run since we don't process those errors.
171
172         * Scripts/webkitpy/port/darwin.py:
173         (DarwinPort._look_for_all_crash_logs_in_log_dir):
174         * Scripts/webkitpy/port/ios_device.py:
175         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
176         * Scripts/webkitpy/port/watch_device.py:
177         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
178
179 2019-02-08  Beth Dakin  <bdakin@apple.com>
180
181         Add afterScreenUpdates to WKSnapshotConfiguration
182         https://bugs.webkit.org/show_bug.cgi?id=194362
183         -and corresponding-
184         <rdar://problem/40655528> Please add an "after screen updates" property to 
185         WKSnapshotConfiguration (to solve blank snapshots)
186
187         Reviewed by Tim Horton.
188
189         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
190         (TEST):
191
192 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
193
194         clampTo(): do not convert the input to double when dealing with integers
195         https://bugs.webkit.org/show_bug.cgi?id=194263
196         <rdar://problem/47692312>
197
198         Reviewed by Darin Adler.
199
200         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
201         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
202         (TestWebKitAPI::testClampFloatingPointToInteger):
203         (TestWebKitAPI::testClampSameSignIntegers):
204         (TestWebKitAPI::testClampUnsignedToSigned):
205         (TestWebKitAPI::testClampSignedToUnsigned):
206
207 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
208
209         webkitpy: Respect --dedicated-simulators flag
210         https://bugs.webkit.org/show_bug.cgi?id=194416
211         <rdar://problem/47894722>
212
213         Reviewed by Lucas Forschler.
214
215         * Scripts/webkitpy/port/device_port.py:
216         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
217         available devices can be safely ignored.
218
219 2019-02-07  Keith Rollin  <krollin@apple.com>
220
221         Remove extra copy of 100x100-red.tga
222         https://bugs.webkit.org/show_bug.cgi?id=194371
223         <rdar://problem/47873465>
224
225         Reviewed by Said Abou-Hallawa.
226
227         In order to help it pass its tests, Bug 194190 added a second copy of
228         the file 100x100-red.tga. However, it turns out that this additional
229         file wasn't actually needed, and that that sole previous copy was
230         sufficient. At the same time, this second copy -- which was copied to
231         the same location in the build output as the first copy -- now caused
232         XCBuild to complain because there were two production rules for the
233         same output file. Address this by removing the newly-added extra copy.
234
235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
236         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
237
238 2019-02-07  Alex Christensen  <achristensen@webkit.org>
239
240         Deprecate WKBundlePageSetDefersLoading
241         https://bugs.webkit.org/show_bug.cgi?id=191394
242
243         Reviewed by Dean Jackson.
244
245         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
246         (WTR::TestRunner::setDefersLoading):
247
248 2019-02-07  Zalan Bujtas  <zalan@apple.com>
249
250         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
251         https://bugs.webkit.org/show_bug.cgi?id=194391
252
253         Reviewed by Antti Koivisto.
254
255         * LayoutReloaded/misc/LFC-passing-tests.txt:
256
257 2019-02-06  Keith Rollin  <krollin@apple.com>
258
259         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
260         https://bugs.webkit.org/show_bug.cgi?id=193975
261         <rdar://problem/47643306>
262
263         Reviewed by Tim Horton.
264
265         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
266         the Info.plist file into the bundle. This step is not necessary as the
267         implicit "bundle up all the build products into a framework" build
268         phase does this already. Having the Copy Bundle Resources phase do
269         this causes a conflict under XCBuild, which objects to two build
270         phases producing the same file (Info.plist). Address this by removing
271         Info.plist from the Copy Bundle Resources phase.
272
273         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
274
275 2019-02-06  Keith Rollin  <krollin@apple.com>
276
277         Really enable the automatic checking and regenerations of .xcfilelists during builds
278         https://bugs.webkit.org/show_bug.cgi?id=194357
279         <rdar://problem/47861231>
280
281         Reviewed by Chris Dumez.
282
283         Bug 194124 was supposed to enable the automatic checking and
284         regenerating of .xcfilelist files during the build. While related
285         changes were included in that patch, the change to actually enable the
286         operation somehow was omitted. This patch actually enables the
287         operation. The check-xcfilelist.sh scripts now check
288         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
289         from the checking.
290
291         * DumpRenderTree/Scripts/check-xcfilelists.sh:
292         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
293
294 2019-02-06  David Kilzer  <ddkilzer@apple.com>
295
296         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
297         <https://webkit.org/b/194286>
298         <rdar://problem/47815558>
299
300         Reviewed by Alexey Proskuryakov.
301
302         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
303         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
304         WKRetainPtr<> to avoid leaking the WKDataRef.
305
306 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
307
308         Unreviewed, fix a typo
309
310         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
311
312 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
313
314         [GTK][WPE] force libpsl build to use ICU in jhbuild
315         https://bugs.webkit.org/show_bug.cgi?id=194288
316
317         Reviewed by Carlos Garcia Campos.
318
319         * gtk/jhbuild.modules:
320         Require ICU for libpsl build in jhbuild, like done in WPE.
321
322 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
323
324         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
325         https://bugs.webkit.org/show_bug.cgi?id=194209
326
327         Reviewed by Carlos Garcia Campos.
328
329         Enhance TestCookieManager to ensure this doesn't happen again.
330
331         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
332         (testCookieManagerPersistentStorage):
333         (beforeAll):
334
335 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
336
337         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
338         https://bugs.webkit.org/show_bug.cgi?id=194324
339
340         Reviewed by Andy Estes.
341
342         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
343         part of the name is already implicit, since this is in testing code in TestOptions.
344
345         * WebKitTestRunner/TestController.cpp:
346         (WTR::TestController::generateContextConfiguration const):
347         (WTR::updateTestOptionsFromTestHeader):
348         * WebKitTestRunner/TestOptions.h:
349         (WTR::TestOptions::hasSameInitializationOptions const):
350
351 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
352
353         [ews-build] Allow * as platform for builders and workers
354         https://bugs.webkit.org/show_bug.cgi?id=188533
355
356         Reviewed by Lucas Forschler.
357
358         * BuildSlaveSupport/ews-build/loadConfig.py:
359         (checkWorkersAndBuildersForConsistency):
360
361 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
362
363         [ews-build] Add few bots to config.json
364         https://bugs.webkit.org/show_bug.cgi?id=194304
365
366         Reviewed by Lucas Forschler.
367
368         * BuildSlaveSupport/ews-build/config.json:
369
370 2019-02-05  Keith Rollin  <krollin@apple.com>
371
372         Enable the automatic checking and regenerations of .xcfilelists during builds
373         https://bugs.webkit.org/show_bug.cgi?id=194124
374         <rdar://problem/47721277>
375
376         Reviewed by Tim Horton.
377
378         Bug 193790 add a facility for checking -- during build time -- that
379         any needed .xcfilelist files are up-to-date and for updating them if
380         they are not. This facility was initially opt-in by setting
381         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
382         the process seemed robust. Its now time to enable this facility and
383         make it opt-out. If there is a need to disable this facility, set and
384         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
385         running `make` or `build-webkit`, or before running Xcode from the
386         command line.
387
388         Additionally, remove the step that generates a list of source files
389         going into the UnifiedSources build step. It's only necessarily to
390         specify Sources.txt and SourcesCocoa.txt as inputs.
391
392         * Scripts/generate-xcfilelists:
393
394 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
395
396         [GTK][WPE] force libpsl build to use ICU in jhbuild
397         https://bugs.webkit.org/show_bug.cgi?id=194288
398
399         Reviewed by Philippe Normand.
400
401         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
402         This can cause build failures if libidn is detected but libunistring is not available.
403
404         Make sure that ICU is used for runtime and builtin PSL data.
405
406         * gtk/jhbuild.modules:
407         * wpe/jhbuild.modules:
408
409 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
410
411         [ews-app] Modified timestamp should be updated on updating data
412         https://bugs.webkit.org/show_bug.cgi?id=194295
413
414         Reviewed by Lucas Forschler.
415
416         * BuildSlaveSupport/ews-app/ews/models/build.py:
417         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
418         * BuildSlaveSupport/ews-app/ews/models/step.py:
419
420 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
421
422         Unreviewed, rolling out r240742.
423
424         Causes crashes on iOS simulator.
425
426         Reverted changeset:
427
428         "[iOS] Keyups for non-modifier keys identified as "Dead" when
429         not focused in a content-editable element"
430         https://bugs.webkit.org/show_bug.cgi?id=192824
431         https://trac.webkit.org/changeset/240742
432
433 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
434
435         run-webkit-tests emits message "...running None" when running tests
436         https://bugs.webkit.org/show_bug.cgi?id=194133
437         <rdar://problem/47724738>
438
439         Reviewed by Lucas Forschler.
440
441         * Scripts/webkitpy/xcode/device_type.py:
442         (DeviceType.__str__): Use both version mapping tables and use just the variant
443         name if no version name is available.
444         * Scripts/webkitpy/xcode/device_type_unittest.py:
445         (DeviceTypeTest):
446         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
447         an associated named.
448
449 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
450
451         [WPE] require python3-setuptools for meson build in jhbuild
452         https://bugs.webkit.org/show_bug.cgi?id=194287
453
454         Reviewed by Philippe Normand.
455
456         python3-setuptools is needed to build meson in jhbuild.
457         It is already required by the GTK port.
458
459         * wpe/install-dependencies:
460
461 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
462
463         [ews-app] Add method to save BuilderMapping to database
464         https://bugs.webkit.org/show_bug.cgi?id=194264
465
466         Reviewed by Lucas Forschler.
467
468         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
469         (BuilderMapping.__str__):
470         (BuilderMapping):
471         (BuilderMapping.save_mapping):
472         (BuilderMapping.update_mapping):
473         (BuilderMapping.get_existing_mapping):
474         (BuilderMapping.is_valid_mapping):
475
476 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
477
478         [ews-app] Add timestamp fields for BuilderMappings
479         https://bugs.webkit.org/show_bug.cgi?id=194266
480
481         Reviewed by Lucas Forschler.
482
483         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
484         (BuilderMapping):
485
486 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
487
488         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
489         https://bugs.webkit.org/show_bug.cgi?id=174816
490
491         Reviewed by Michael Catanzaro.
492
493         Add tests for webkit_uri_for_display().
494
495         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
496         (testURIForDisplayUnaffected):
497         (testURIForDisplayAffected):
498         (beforeAll):
499         (afterAll):
500         * TestWebKitAPI/glib/CMakeLists.txt:
501
502 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
503
504         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
505         https://bugs.webkit.org/show_bug.cgi?id=194158
506         <rdar://problem/47737268>
507
508         Rubber-stamped by Aakash Jain.
509
510         * Scripts/webkitpy/port/device_port.py:
511         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
512
513 2019-02-04  Said Abou-Hallawa  <said@apple.com>
514
515         [CG] Enable setAdditionalSupportedImageTypes for WK1
516         https://bugs.webkit.org/show_bug.cgi?id=194190
517
518         Reviewed by Tim Horton.
519
520         Add a test similar to the one under WebKit Cocoa but make it create a
521         WebView instead of a WKWebView.
522
523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
524         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
525         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
526         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
527         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
528         (TestWebKitAPI::runTest):
529         (TestWebKitAPI::TEST):
530
531 2019-02-04  Zalan Bujtas  <zalan@apple.com>
532
533         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
534         https://bugs.webkit.org/show_bug.cgi?id=194168
535
536         Reviewed by Simon Fraser.
537
538         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
539
540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
541         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
542         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
543         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
544         (TEST):
545         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
546         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
547
548 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
549
550         REGRESSION (r237269): webkit-patch what-broke is broken 
551         https://bugs.webkit.org/show_bug.cgi?id=193025
552
553         Reviewed by Aakash Jain.
554
555         * Scripts/webkitpy/common/host.py:
556         (Host.buildbot):
557         (Host.bugzilla): Renamed to 'buildbot'.
558
559 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
560
561         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
562         https://bugs.webkit.org/show_bug.cgi?id=194207
563
564         Reviewed by Tim Horton.
565
566         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
567         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
568         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
569         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
570         start and delete forwards to remove the original attachment.
571
572         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
573         (TestWebKitAPI::TEST):
574
575 2019-02-04  Youenn Fablet  <youenn@apple.com>
576
577         Capture state should be managed consistently when doing process swapping
578         https://bugs.webkit.org/show_bug.cgi?id=194122
579         <rdar://problem/47609293>
580
581         Reviewed by Eric Carlson.
582
583         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
584         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
585         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
586         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
587         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
588         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
589         (WTR::TestRunner::isDoingMediaCapture const):
590         * WebKitTestRunner/InjectedBundle/TestRunner.h:
591         * WebKitTestRunner/TestController.cpp:
592         (WTR::TestController::isDoingMediaCapture const):
593         * WebKitTestRunner/TestController.h:
594         * WebKitTestRunner/TestInvocation.cpp:
595         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
596         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
597         (WTR::TestController::isDoingMediaCapture const):
598
599 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
600
601         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
602         https://bugs.webkit.org/show_bug.cgi?id=194142
603
604         Reviewed by Ross Kirsling.
605
606         There three 'separator' variables in TestController.cpp. Renamed
607         it 'pathSeparator', and unified them.
608
609         * WebKitTestRunner/TestController.cpp:
610         (WTR::TestController::generateContextConfiguration const):
611         (WTR::createTestURL):
612         (WTR::TestController::platformAdjustContext):
613
614 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
615
616         Make setNeedsLayout on the root more explicitly about triggering its side-effects
617         https://bugs.webkit.org/show_bug.cgi?id=194198
618
619         Reviewed by Antti Koivisto.
620
621         No need to set the banner heights on navigation now, since Page stores them.
622
623         * MiniBrowser/mac/WK2BrowserWindowController.m:
624         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
625
626 2019-02-03  John Wilander  <wilander@apple.com>
627
628         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
629         https://bugs.webkit.org/show_bug.cgi?id=194104
630         <rdar://problem/47649991>
631
632         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
633
634         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
635         (TestWebKitAPI::TEST):
636             Changed numeric types from unsigned short to uint32_t.
637
638 2019-02-02  David Kilzer  <ddkilzer@apple.com>
639
640         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
641         <https://webkit.org/b/194178>
642         <rdar://problem/47753473>
643
644         Reviewed by Alexey Proskuryakov.
645
646         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
647         (WTR::uninstallFakeHelvetica): Pass nullptr into
648         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
649
650 2019-02-02  Zalan Bujtas  <zalan@apple.com>
651
652         [LFC] Initialize ICB's style with fixed width/height.
653         https://bugs.webkit.org/show_bug.cgi?id=194188
654
655         Reviewed by Antti Koivisto.
656
657         * LayoutReloaded/misc/LFC-passing-tests.txt:
658
659 2019-02-02  Zalan Bujtas  <zalan@apple.com>
660
661         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
662         https://bugs.webkit.org/show_bug.cgi?id=194185
663
664         Reviewed by Antti Koivisto.
665
666         * LayoutReloaded/misc/LFC-passing-tests.txt:
667
668 2018-12-16  Darin Adler  <darin@apple.com>
669
670         Convert additional String::format clients to alternative approaches
671         https://bugs.webkit.org/show_bug.cgi?id=192746
672
673         Reviewed by Alexey Proskuryakov.
674
675         * WebKitTestRunner/TestController.cpp:
676         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
677         as an intermediate in code that ultimately constructs a WTF::String.
678         (WTR::userMediaOriginHash): Use makeString.
679         (WTR::TestController::didNavigateWithNavigationData): More of the same.
680         (WTR::TestController::didPerformClientRedirect): Ditto.
681         (WTR::TestController::didPerformServerRedirect): Ditto.
682         (WTR::TestController::didUpdateHistoryTitle): Ditto.
683
684 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
685
686         [ews-build] Add unit test to verify builder keys
687         https://bugs.webkit.org/show_bug.cgi?id=194152
688
689         Reviewed by Lucas Forschler.
690
691         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
692         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
693
694 2019-02-01  Zalan Bujtas  <zalan@apple.com>
695
696         [LFC] Expand tests coverage (12 new tests -> 787)
697
698         Unreviewed test gardening.
699
700         * LayoutReloaded/misc/LFC-passing-tests.txt:
701
702 2019-02-01  Zalan Bujtas  <zalan@apple.com>
703
704         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
705         https://bugs.webkit.org/show_bug.cgi?id=194163
706
707         Reviewed by Simon Fraser.
708
709         775
710
711         * LayoutReloaded/misc/LFC-passing-tests.txt:
712
713 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
714
715         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
716         https://bugs.webkit.org/show_bug.cgi?id=194140
717         <rdar://problem/47728098>
718
719         Reviewed by Tim Horton.
720
721         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
722         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
723         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
724
725         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
726         test to induce an IPC deadlock when presenting a modal alert during touch start.
727
728         * WebKitTestRunner/InjectedBundle/TestRunner.h:
729         * WebKitTestRunner/TestController.cpp:
730         (WTR::runJavaScriptAlert):
731
732         Add a client callback function for running JavaScript alerts.
733
734         (WTR::TestController::createOtherPage):
735         (WTR::TestController::generateContextConfiguration const):
736
737         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
738         the fix in this patch.
739
740         (WTR::TestController::createWebViewWithOptions):
741
742         Plumb TestOptions to generateContextConfiguration.
743
744         (WTR::TestController::resetPreferencesToConsistentValues):
745         (WTR::TestController::resetStateToConsistentValues):
746         (WTR::updateTestOptionsFromTestHeader):
747         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
748         (WTR::TestController::handleJavaScriptAlert):
749         * WebKitTestRunner/TestController.h:
750         * WebKitTestRunner/TestInvocation.cpp:
751         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
752         * WebKitTestRunner/TestOptions.h:
753         (WTR::TestOptions::hasSameInitializationOptions const):
754
755 2019-02-01  Chris Dumez  <cdumez@apple.com>
756
757         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
758         https://bugs.webkit.org/show_bug.cgi?id=193740
759         <rdar://problem/47527267>
760
761         Reviewed by Alex Christensen.
762
763         Add API test coverage.
764
765         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
766
767 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
768
769         [ews-app] Add display name field to BuilderMapping model
770         https://bugs.webkit.org/show_bug.cgi?id=194153
771
772         Reviewed by Lucas Forschler.
773
774         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
775         (BuilderMapping):
776
777 2019-02-01  Youenn Fablet  <youenn@apple.com>
778
779         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
780         https://bugs.webkit.org/show_bug.cgi?id=194155
781
782         Reviewed by Eric Carlson.
783
784         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
785         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
786         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
787
788 2019-02-01  Zalan Bujtas  <zalan@apple.com>
789
790         [LFC] Adjust replaced element's intrinsic ratio
791         https://bugs.webkit.org/show_bug.cgi?id=194154
792
793         Reviewed by Antti Koivisto.
794
795         761
796
797         * LayoutReloaded/misc/LFC-passing-tests.txt:
798
799 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
800
801         [WPE] Show test results in minibrowser
802         https://bugs.webkit.org/show_bug.cgi?id=194150
803
804         Reviewed by Žan Doberšek.
805
806         * Scripts/webkitpy/port/wpe.py:
807         (WPEPort.show_results_html_file):
808
809 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
810
811         [WPE] MiniBrowser: add ky bindings for back/forward navigation
812         https://bugs.webkit.org/show_bug.cgi?id=194151
813
814         Reviewed by Žan Doberšek.
815
816         ALT + <- go back
817         ALT + -> go forward
818
819         * MiniBrowser/wpe/main.cpp:
820         (main):
821
822 2019-02-01  Zalan Bujtas  <zalan@apple.com>
823
824         [LFC] Set intrinsic size on Layout::Replaced
825         https://bugs.webkit.org/show_bug.cgi?id=194139
826
827         Reviewed by Antti Koivisto.
828
829         744
830
831         * LayoutReloaded/misc/LFC-passing-tests.txt:
832
833 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
834
835         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
836         https://bugs.webkit.org/show_bug.cgi?id=194146
837
838         Reviewed by Xabier Rodriguez-Calvar.
839
840         It allows to open relative paths.
841
842         * MiniBrowser/wpe/main.cpp:
843         (main):
844
845 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
846
847         Update flakiness dashboard configuration after recent queue changes
848         https://bugs.webkit.org/show_bug.cgi?id=194127
849
850         Rubber-stamped by Aakash Jain.
851
852         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
853
854         * TestResultServer/static-dashboards/builders.jsonp:
855
856 2019-01-31  Youenn Fablet  <youenn@apple.com>
857
858         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
859         https://bugs.webkit.org/show_bug.cgi?id=194106
860         <rdar://problem/47676333>
861
862         Reviewed by Ryosuke Niwa.
863
864         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
865         (TestWebKitAPI::didFinishNavigation):
866         (TestWebKitAPI::TEST):
867         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
868
869 2019-01-31  Chris Dumez  <cdumez@apple.com>
870
871         Page zoom level is lost after a process swap or a crash
872         https://bugs.webkit.org/show_bug.cgi?id=194105
873         <rdar://problem/47610781>
874
875         Reviewed by Alex Christensen.
876
877         Add API test coverage.
878
879         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
880         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
881
882 2019-01-31  Alex Christensen  <achristensen@webkit.org>
883
884         Revert r238819 which is unneeded and caused a performance regression.
885         https://bugs.webkit.org/show_bug.cgi?id=192272
886         <rdar://problem/46664625>
887
888         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
889         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
890         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
891
892 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
893
894         Formalize WebKitAdditions mechanism of LoadOptimizer
895         https://bugs.webkit.org/show_bug.cgi?id=193886
896         <rdar://problem/47696809>
897
898         Reviewed by Brent Fulgham.
899
900         * MiniBrowser/MiniBrowser.entitlements:
901         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
902
903 2019-01-31  Zalan Bujtas  <zalan@apple.com>
904
905         [LFC] Margin before/after/start/end initial value is 0 and not auto.
906         https://bugs.webkit.org/show_bug.cgi?id=194090
907
908         Reviewed by Antti Koivisto.
909
910         * LayoutReloaded/misc/LFC-passing-tests.txt:
911
912 2019-01-31  Zalan Bujtas  <zalan@apple.com>
913
914         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
915         https://bugs.webkit.org/show_bug.cgi?id=194074
916
917         Reviewed by Antti Koivisto.
918
919         * LayoutReloaded/misc/LFC-passing-tests.txt:
920
921 2019-01-31  Zalan Bujtas  <zalan@apple.com>
922
923         [LFC][BFC] Add support for block level replaced box.
924         https://bugs.webkit.org/show_bug.cgi?id=194071
925
926         Reviewed by Antti Koivisto.
927
928         * LayoutReloaded/misc/LFC-passing-tests.txt:
929
930 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
931
932         Fix WebKitTestRunner's testPath with Windows full paths
933         https://bugs.webkit.org/show_bug.cgi?id=194012
934
935         Reviewed by Alex Christensen.
936
937         updateTestOptionsFromTestHeader failed to open test files because
938         testPath returned wrong file paths. It returned a path "/C:/..."
939         if a URL "file:///C:/..." was given.
940
941         * WebKitTestRunner/TestController.cpp:
942         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
943
944 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
945
946         [WPE] Bump font related dependencies to match the GTK+ port
947         https://bugs.webkit.org/show_bug.cgi?id=194017
948
949         Reviewed by Žan Doberšek.
950
951         * wpe/jhbuild.modules:
952         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
953         * wpe/patches/icudata-stdlibs.patch: Added.
954
955 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
956
957         Enable swipe tests on iOS
958         https://bugs.webkit.org/show_bug.cgi?id=194076
959
960         Reviewed by Geoffrey Garen.
961
962         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
963         it causes a debug assertion failure in runUIScript.
964
965         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
966         (WTR::UIScriptController::beginBackSwipe):
967         (WTR::UIScriptController::completeBackSwipe):
968
969 2019-01-30  Keith Rollin  <krollin@apple.com>
970
971         Use correct printf format specifier
972         https://bugs.webkit.org/show_bug.cgi?id=194062
973         <rdar://problem/47686167>
974
975         Reviewed by Alexey Proskuryakov.
976
977         LayoutTestSpellChecker.mm is trying to format a variable of type
978         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
979         actually an unsigned long long. Fix this by formatting with %llu.
980
981         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
982         (-[LayoutTestTextCheckingResult description]):
983
984 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
985
986         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
987         https://bugs.webkit.org/show_bug.cgi?id=193979
988
989         Reviewed by Wenson Hsieh.
990
991         Fix the test for iOS. Make the test work with iOS UA string.
992
993         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
994
995 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
996
997         Replace High Sierra LLINT CLoop bot due to hardware failure
998         https://bugs.webkit.org/show_bug.cgi?id=194066
999
1000         Reviewed by Aakash Jain.
1001
1002         * BuildSlaveSupport/build.webkit.org-config/config.json:
1003
1004 2019-01-30  Keith Rollin  <krollin@apple.com>
1005
1006         [NSDragItem init] is unavailable
1007         https://bugs.webkit.org/show_bug.cgi?id=194059
1008         <rdar://problem/47685715>
1009
1010         Reviewed by Wenson Hsieh.
1011
1012         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1013         DumpRenderTree and TestWebKitAPI, which both try to create an
1014         NSDragItem in a manner that invokes this method. Address this by using
1015         -initWithPasteboardWriter instead.
1016
1017         Note that the parameter passed to initWithPasteboardWriter is likely
1018         incorrect. In both cases, the object passed does not conform to
1019         NSPasteboardWriting. However, with this fix, we're no worse off than
1020         before, and can now perform builds with newer compilers and SDKs until
1021         a real fix can be crafted. That work is tracked in
1022         https://bugs.webkit.org/show_bug.cgi?id=194060
1023
1024         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1025         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1026         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1027         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1028
1029 2019-01-30  Daniel Bates  <dabates@apple.com>
1030
1031         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1032         https://bugs.webkit.org/show_bug.cgi?id=192824
1033         <rdar://problem/47100332>
1034
1035         Reviewed by Wenson Hsieh.
1036
1037         Fix a bug where the wrong usage code was used for F13 thru F24.
1038
1039         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1040         (keyCodeForDOMFunctionKey):
1041
1042 2019-01-30  Chris Dumez  <cdumez@apple.com>
1043
1044         Regression(PSON) Load hang can occur on history navigation
1045         https://bugs.webkit.org/show_bug.cgi?id=194030
1046         <rdar://problem/47656939>
1047
1048         Reviewed by Antti Koivisto.
1049
1050         Add API test coverage.
1051
1052         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1053
1054 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1055
1056         [LFC] Expand tests coverage.
1057
1058         Unreviewed test gardening.
1059
1060         * LayoutReloaded/misc/LFC-passing-tests.txt:
1061
1062 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1063
1064         [Flatpak] Add openjpeg support
1065         https://bugs.webkit.org/show_bug.cgi?id=194019
1066
1067         Reviewed by Michael Catanzaro.
1068
1069         * flatpak/org.webkit.CommonModules.yaml:
1070
1071 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1072
1073         Unreviewed, rolling out r240708.
1074         https://bugs.webkit.org/show_bug.cgi?id=194022
1075
1076         It broke WPE build (Requested by KaL on #webkit).
1077
1078         Reverted changeset:
1079
1080         "[WPE] Bump font related dependencies to match the GTK+ port"
1081         https://bugs.webkit.org/show_bug.cgi?id=194017
1082         https://trac.webkit.org/changeset/240708
1083
1084 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1085
1086         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1087         https://bugs.webkit.org/show_bug.cgi?id=194001
1088
1089         Reviewed by Antti Koivisto.
1090
1091         * LayoutReloaded/misc/LFC-passing-tests.txt:
1092
1093 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1094
1095         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1096         https://bugs.webkit.org/show_bug.cgi?id=194020
1097
1098         Reviewed by Antti Koivisto.
1099
1100         * LayoutReloaded/misc/LFC-passing-tests.txt:
1101
1102 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1103
1104         AX: Support color well on iOS
1105         https://bugs.webkit.org/show_bug.cgi?id=194010
1106
1107         Reviewed by Joanmarie Diggs.
1108
1109         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1110         (WTR::AccessibilityUIElement::stringAttributeValue):
1111
1112 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1113
1114         [WPE] Bump font related dependencies to match the GTK+ port
1115         https://bugs.webkit.org/show_bug.cgi?id=194017
1116
1117         Reviewed by Žan Doberšek.
1118
1119         * wpe/jhbuild.modules:
1120         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1121         * wpe/patches/icudata-stdlibs.patch: Added.
1122
1123 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1124
1125         [Mac] Update window scale API usage
1126         https://bugs.webkit.org/show_bug.cgi?id=193991
1127         rdar://problem/47614795
1128
1129         Reviewed by Tim Horton.
1130
1131         * DumpRenderTree/mac/DumpRenderTree.mm:
1132         (changeWindowScaleIfNeeded):
1133         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1134         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1135         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1136
1137 2019-01-29  Chris Dumez  <cdumez@apple.com>
1138
1139         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1140         https://bugs.webkit.org/show_bug.cgi?id=193977
1141         <rdar://problem/47643716>
1142
1143         Reviewed by Geoff Garen.
1144
1145         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1146         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1147         to the previous provisional committing *before* we make the last load. 
1148
1149         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1150
1151 2019-01-29  Youenn Fablet  <youenn@apple.com>
1152
1153         Adopt new SPI to evaluate server certificate trust
1154         https://bugs.webkit.org/show_bug.cgi?id=193355
1155
1156         Reviewed by Alex Christensen.
1157
1158         Add infrastructure to handle HTTPS server trust evaluation testing.
1159
1160         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1161         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1162         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1163         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1164         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1165         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1166         * WebKitTestRunner/TestController.cpp:
1167         (WTR::TestController::resetPreferencesToConsistentValues):
1168         (WTR::TestController::didReceiveAuthenticationChallenge):
1169         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1170         * WebKitTestRunner/TestController.h:
1171         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1172         * WebKitTestRunner/TestInvocation.cpp:
1173         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1174         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1175         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1176
1177 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1178
1179         [ews-build] Add build step to print bot Configuration
1180         https://bugs.webkit.org/show_bug.cgi?id=193887
1181
1182         Reviewed by Lucas Forschler.
1183
1184         * BuildSlaveSupport/ews-build/steps.py:
1185         (PrintConfiguration): Build step to print configuration.
1186         * BuildSlaveSupport/ews-build/factories.py:
1187
1188 2019-01-29  Chris Dumez  <cdumez@apple.com>
1189
1190         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1191         https://bugs.webkit.org/show_bug.cgi?id=193967
1192         <rdar://problem/47635348>
1193
1194         Reviewed by Alex Christensen.
1195
1196         Add API test coverage.
1197
1198         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1199         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1200
1201 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1202
1203         [ews-app] Handle incoming results data
1204         https://bugs.webkit.org/show_bug.cgi?id=193973
1205
1206         Reviewed by Lucas Forschler.
1207
1208         * BuildSlaveSupport/ews-app/ews/views/results.py:
1209
1210 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1211
1212         [ews-app] Make the results url generic
1213         https://bugs.webkit.org/show_bug.cgi?id=193928
1214
1215         Reviewed by Lucas Forschler.
1216
1217         * BuildSlaveSupport/ews-app/ews/urls.py:
1218
1219 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1220
1221         [ews-build] Configure buildbot to send events to ews-app
1222         https://bugs.webkit.org/show_bug.cgi?id=193968
1223
1224         Reviewed by Lucas Forschler.
1225
1226         * BuildSlaveSupport/ews-build/events.py: Added.
1227         * BuildSlaveSupport/ews-build/master.cfg:
1228
1229 2019-01-29  Keith Rollin  <krollin@apple.com>
1230
1231         Add .xcfilelists to Run Script build phases
1232         https://bugs.webkit.org/show_bug.cgi?id=193792
1233         <rdar://problem/47201785>
1234
1235         Reviewed by Alex Christensen.
1236
1237         As part of supporting XCBuild, update the necessary Run Script build
1238         phases in their Xcode projects to refer to their associated
1239         .xcfilelist files.
1240
1241         Note that the addition of these files bumps the Xcode project version
1242         number to something that's Xcode 10 compatible. This change means that
1243         older versions of the Xcode IDE can't read these projects. Nor can it
1244         fully load workspaces that refer to these projects (the updated
1245         projects are shown as non-expandable placeholders). `xcodebuild` can
1246         still build these projects; it's just that the IDE can't open them.
1247
1248         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1249         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1250
1251 2019-01-29  John Wilander  <wilander@apple.com>
1252
1253         Add data abstraction and validation for Ad Click Attribution
1254         https://bugs.webkit.org/show_bug.cgi?id=193916
1255         <rdar://problem/47603481>
1256
1257         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1258
1259         Ad click attribution has two steps. First, the storage of an ad
1260         campaign ID for a click that takes the user to a destination
1261         site. Second, a conversion on the destination site that can be
1262         attributed to the ad click.
1263
1264         This patch adds a class that represents a request for ad click
1265         attribution. Validation makes sure that the bits of entropy
1266         reported through this mechanism is limited.
1267
1268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1269         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1270         (TestWebKitAPI::TEST):
1271
1272 2019-01-29  Chris Dumez  <cdumez@apple.com>
1273
1274         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1275         https://bugs.webkit.org/show_bug.cgi?id=193932
1276         <rdar://problem/47598947>
1277
1278         Reviewed by Brady Eidson.
1279
1280         Add API test coverage.
1281
1282         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1283
1284 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1285
1286         Adding new passing LFC tests.
1287
1288         Unreviewed test gardening.
1289
1290         * LayoutReloaded/misc/LFC-passing-tests.txt:
1291
1292 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1293
1294         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1295         https://bugs.webkit.org/show_bug.cgi?id=193964
1296
1297         Reviewed by Antti Koivisto.
1298
1299         * LayoutReloaded/misc/LFC-passing-tests.txt:
1300
1301 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1302
1303         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1304         https://bugs.webkit.org/show_bug.cgi?id=193954
1305
1306         Reviewed by Antti Koivisto.
1307
1308         * LayoutReloaded/misc/LFC-passing-tests.txt:
1309
1310 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1311
1312         WebDriver: add support for running subtests
1313         https://bugs.webkit.org/show_bug.cgi?id=193904
1314
1315         Reviewed by Michael Catanzaro.
1316
1317         pytest already supports it by passing test.py::subtest, so we can do the same.
1318
1319         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1320         (get_item_name): Made this global.
1321         (CollectRecorder.__init__): Receive the parameter to ignore.
1322         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1323         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1324         (collect): Add parameter to ignore.
1325         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1326         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1327         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1328         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1329         (WebDriverTestRunnerSelenium.run): Ditto.
1330         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1331         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1332         (WebDriverTestRunnerW3C.run): Ditto.
1333
1334 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1335
1336         User agent string override for navigator.userAgent should be site specific quirks
1337         https://bugs.webkit.org/show_bug.cgi?id=193950
1338
1339         Reviewed by Brent Fulgham.
1340
1341         Updated per the _WKWebsitePolicies rename.
1342
1343         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1344         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1345
1346 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1347
1348         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1349         https://bugs.webkit.org/show_bug.cgi?id=193941
1350
1351         Reviewed by Alex Christensen.
1352
1353         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1354         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1355         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1356         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1357         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1358         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1359         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1360         * TestWebKitAPI/Tests/WTF/Time.cpp:
1361         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1362         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1363         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1364         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1365
1366 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1367
1368         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1369
1370         * Scripts/webkitpy/common/config/contributors.json:
1371
1372 2019-01-28  Andy Estes  <aestes@apple.com>
1373
1374         [watchOS] Enable Parental Controls content filtering
1375         https://bugs.webkit.org/show_bug.cgi?id=193939
1376         <rdar://problem/46641912>
1377
1378         Reviewed by Ryosuke Niwa.
1379
1380         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1381
1382 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1383
1384         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1385         <https://webkit.org/b/193884>
1386
1387         Reviewed by Jiewen Tan.
1388
1389         * Scripts/webkitpy/style/checkers/cpp.py:
1390         (check_language): Add LocalAuthentication to
1391         `frameworks_with_soft_links`.
1392
1393 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1394
1395         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1396         https://bugs.webkit.org/show_bug.cgi?id=193891
1397
1398         Reviewed by Ross Kirsling.
1399
1400         There were three problems in window sizes of WebView and the host window.
1401         1. The sizes of pixel image output were incorrect.
1402         2. The host window is going to appear after window.resize was invoked.
1403         3. window.resize resized only the host window, not WebView.
1404
1405         This change solves them with a following approach.
1406         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1407         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1408            as well as DumpRenderTree in order to match the client area and the window area.
1409         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1410         d. PlatformWebView::setWindowFrame changes both window sizes.
1411         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1412
1413         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1414         (WTR::PlatformWebView::PlatformWebView): Create the host window
1415         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1416         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1417         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1418
1419 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1420
1421         [ews-app] Add method to save Step data to database
1422         https://bugs.webkit.org/show_bug.cgi?id=193890
1423
1424         Reviewed by Lucas Forschler.
1425
1426         * BuildSlaveSupport/ews-app/ews/models/step.py:
1427         (Step.save_step): Method to save step data.
1428         (Step.update_step): Method to update step data.
1429         (Step.get_existing_step): Method to fetch existing step from database.
1430         (Step.is_valid_result): Method to validate valid step result.
1431
1432 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1433
1434         [ews-app] Add method to save Build data to database
1435         https://bugs.webkit.org/show_bug.cgi?id=193735
1436
1437         Reviewed by Lucas Forschler.
1438
1439         * BuildSlaveSupport/ews-app/ews/models/build.py:
1440         (Build.save_build): Method to save build information to database.
1441         (Build.get_existing_build): Method to fetch existing build from database.
1442         (Build.is_valid_result): Method to validate build result.
1443         * BuildSlaveSupport/ews-app/ews/common/util.py:
1444         (is_valid_int_id): Method to validate valid id.
1445
1446 2019-01-28  Chris Dumez  <cdumez@apple.com>
1447
1448         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1449         https://bugs.webkit.org/show_bug.cgi?id=193915
1450         <rdar://problem/47560907>
1451
1452         Reviewed by Alex Christensen.
1453
1454         Add API test coverage.
1455
1456         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1457
1458 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1459
1460         [ews-app] Rename id variables
1461         https://bugs.webkit.org/show_bug.cgi?id=193883
1462
1463         Reviewed by Lucas Forschler.
1464
1465         * BuildSlaveSupport/ews-app/ews/models/build.py:
1466         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1467         * BuildSlaveSupport/ews-app/ews/models/step.py:
1468         * BuildSlaveSupport/ews-app/ews/urls.py:
1469         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1470         * BuildSlaveSupport/ews-app/ews/views/results.py:
1471         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1472
1473 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1474
1475         [ews-app] Allow certain fields to be empty
1476         https://bugs.webkit.org/show_bug.cgi?id=193892
1477
1478         Reviewed by Lucas Forschler.
1479
1480         * BuildSlaveSupport/ews-app/ews/models/build.py:
1481         * BuildSlaveSupport/ews-app/ews/models/step.py:
1482
1483 2019-01-28  Rob Buis  <rbuis@igalia.com>
1484
1485         Update MIME type parser
1486         https://bugs.webkit.org/show_bug.cgi?id=180526
1487
1488         Reviewed by Frédéric Wang.
1489
1490         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1491         (TestWebKitAPI::TEST):
1492
1493 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1494
1495         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1496         https://bugs.webkit.org/show_bug.cgi?id=193896
1497
1498         Reviewed by Antti Koivisto.
1499
1500         * LayoutReloaded/misc/LFC-passing-tests.txt:
1501
1502 2018-12-15  Darin Adler  <darin@apple.com>
1503
1504         Replace many uses of String::format with more type-safe alternatives
1505         https://bugs.webkit.org/show_bug.cgi?id=192742
1506
1507         Reviewed by Mark Lam.
1508
1509         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1510         (WTR::cacheTestRunnerCallback): Use makeString.
1511         * WebKitTestRunner/TestController.cpp:
1512         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1513         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1514
1515 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1516
1517         Use a load optimizer for some sites
1518         https://bugs.webkit.org/show_bug.cgi?id=193881
1519         <rdar://problem/46325455>
1520
1521         Reviewed by Brent Fulgham.
1522
1523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1524         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1525
1526 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1527
1528         AX: Introduce a static accessibility tree
1529         https://bugs.webkit.org/show_bug.cgi?id=193348
1530         <rdar://problem/47203295>
1531
1532         Reviewed by Ryosuke Niwa.
1533
1534         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1535
1536 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1537
1538         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1539         https://bugs.webkit.org/show_bug.cgi?id=193867
1540
1541         Reviewed by Antti Koivisto.
1542
1543         * LayoutReloaded/misc/LFC-passing-tests.txt:
1544
1545 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1546
1547         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1548         https://bugs.webkit.org/show_bug.cgi?id=193865
1549
1550         Reviewed by Antti Koivisto.
1551
1552         * LayoutReloaded/misc/LFC-passing-tests.txt:
1553
1554 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1555
1556         Need a mechanism to override navigator.userAgent
1557         https://bugs.webkit.org/show_bug.cgi?id=193762
1558         <rdar://problem/47504939>
1559
1560         Reviewed by Brent Fulgham.
1561
1562         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1563
1564         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1565         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1566         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1567
1568 2019-01-25  Dean Jackson  <dino@apple.com>
1569
1570         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1571         https://bugs.webkit.org/show_bug.cgi?id=193831
1572         <rdar://problem/47399263>
1573
1574         Reviewed by Chris Dumez.
1575
1576         Two new tests that exercise cross-origin and same-origin System
1577         Previews.
1578
1579         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1580
1581 2019-01-25  Keith Rollin  <krollin@apple.com>
1582
1583         Update Xcode projects with "Check .xcfilelists" build phase
1584         https://bugs.webkit.org/show_bug.cgi?id=193790
1585         <rdar://problem/47201374>
1586
1587         Reviewed by Alex Christensen.
1588
1589         Support for XCBuild includes specifying inputs and outputs to various
1590         Run Script build phases. These inputs and outputs are specified as
1591         .xcfilelist files. Once created, these .xcfilelist files need to be
1592         kept up-to-date. In order to check that they are up-to-date or not,
1593         add an Xcode build step that invokes an external script that performs
1594         the checking. If the .xcfilelists are found to be out-of-date, update
1595         them, halt the build, and instruct the developer to restart the build
1596         with up-to-date files.
1597
1598         At this time, the checking and regenerating is performed only if the
1599         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1600         who want to use this facility can set this variable and test out the
1601         checking/regenerating. Once it seems like there are no egregious
1602         issues that upset a developer's workflow, we'll unconditionally enable
1603         this facility.
1604
1605         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1606         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1607         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1608         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1609
1610 2019-01-25  Keith Rollin  <krollin@apple.com>
1611
1612         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1613         https://bugs.webkit.org/show_bug.cgi?id=193781
1614         <rdar://problem/47201153>
1615
1616         Reviewed by Alex Christensen.
1617
1618         Part of generating the .xcfilelists used as part of adopting XCBuild
1619         includes running `make DerivedSources.make` from a standalone script.
1620         It’s important for this invocation to have the same environment as
1621         when the actual build invokes `make DerivedSources.make`. If the
1622         environments are different, then the two invocations will provide
1623         different results. In order to get the same environment in the
1624         standalone script, have the script launch xcodebuild targeting the
1625         "Apply Configuration to XCFileLists" build target, which will then
1626         re-invoke our standalone script. The script is now running again, this
1627         time in an environment with all workspace, project, target, xcconfig
1628         and other environment variables established.
1629
1630         The "Apply Configuration to XCFileLists" build target accomplishes
1631         this task via a small embedded shell script that consists only of:
1632
1633             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1634
1635         The process that invokes "Apply Configuration to XCFileLists" first
1636         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1637         evaluated and exports it into the shell environment. When xcodebuild
1638         is invoked, it inherits the value of this variable and can `eval` the
1639         contents of that variable. Our external standalone script can then set
1640         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1641         of command-line parameters needed to restart itself in the appropriate
1642         state.
1643
1644         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1645         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1646
1647 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1648
1649         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1650         https://bugs.webkit.org/show_bug.cgi?id=193802
1651         <rdar://problem/46010580>
1652
1653         Reviewed by Andy Estes.
1654
1655         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1656         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1657         (TEST):
1658
1659 2019-01-25  Daniel Bates  <dabates@apple.com>
1660
1661         [iOS] uiController.keyDown() does not translate Control modified key
1662         https://bugs.webkit.org/show_bug.cgi?id=192898
1663
1664         Reviewed by Wenson Hsieh.
1665
1666         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1667         key translation, as applicable. Among other cases, key translation occurs when performing
1668         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1669         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1670         human pressing down and releasing key(s) using a hardware keyboard.
1671
1672         * WebKitTestRunner/ios/HIDEventGenerator.h:
1673         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1674         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1675
1676         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1677         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1678         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1679         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1680         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1681         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1682         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1683         (-[HIDEventGenerator longPress:completionBlock:]):
1684         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1685         Update code for above renaming.
1686
1687         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1688         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1689
1690         (-[HIDEventGenerator keyDown:]): Added.
1691         (-[HIDEventGenerator keyUp:]): Added.
1692         (-[HIDEventGenerator keyPress:completionBlock:]):
1693         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1694         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1695         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1696         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1697         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1698         (WTR::parseModifier): Deleted.
1699
1700 2019-01-25  Keith Rollin  <krollin@apple.com>
1701
1702         Complete the implementation of generate-xcfilelists
1703         https://bugs.webkit.org/show_bug.cgi?id=193782
1704
1705         Reviewed by Alex Christensen.
1706
1707         A preliminary version of generate-xcfilelists was added in r238008.
1708         This patch updates that script in order to:
1709
1710         - Support checking of .xcfilelists
1711         - Perform better execution of `make DerivedSources.make` by
1712           relaunching generate-xcfilelists under xcodebuild
1713         - Support incremental generation and checking of .xcfilelists
1714         - Support supplementary .xcfilelists files from WebKitAdditions
1715         - Support being wrapped by parallel version of generate-xcfilelists in
1716           Internal that adds support for (re)generating WebKit projects in
1717           that repo.
1718         - Support builds that have been performed in WebKitBuild as well as
1719           ~/Library/Developer/code/DerivedData
1720         - Increase robustness and debugging facilities.
1721
1722         * Scripts/generate-xcfilelists:
1723
1724 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1725
1726         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1727         https://bugs.webkit.org/show_bug.cgi?id=193297
1728         <rdar://problem/47158841>
1729
1730         Unreviewed test case fix.
1731
1732         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1733         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1734
1735         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1736         (TEST):
1737
1738 2019-01-25  Keith Rollin  <krollin@apple.com>
1739
1740         Update existing .xcfilelists
1741         https://bugs.webkit.org/show_bug.cgi?id=193791
1742         <rdar://problem/47201706>
1743
1744         Reviewed by Alex Christensen.
1745
1746         Many .xcfilelist files were added in r238824 in order to support
1747         XCBuild. Update these with recent changes to the set of build files
1748         and with the current generate-xcfilelist script.
1749
1750         * DumpRenderTree/DerivedSources-input.xcfilelist:
1751         * DumpRenderTree/DerivedSources-output.xcfilelist:
1752         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1753         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1754
1755 2019-01-25  Keith Rollin  <krollin@apple.com>
1756
1757         Fix missing dependencies in extract-dependencies-from-makefile
1758         https://bugs.webkit.org/show_bug.cgi?id=193783
1759         <rdar://problem/47201571>
1760
1761         Reviewed by Alex Christensen.
1762
1763         The extract-dependencies-from-makefile script generates .xcfilelists
1764         for XCBuild by invoking a makefile in --debug mode, parsing the
1765         dependency information in the output, and extracting information
1766         regarding targets and dependents. However, the way `make` emits this
1767         dependency information is not rigorous, and so we need to determine
1768         what lines to look for and parse by trial and error. This approach
1769         didn't coriginally atch all the information we needed to collect, so
1770         update the script to look for the additional lines we now know to look
1771         for.
1772
1773         * Scripts/extract-dependencies-from-makefile:
1774         (Parser):
1775         (Parser.addTarget):
1776         (Parser.addPrereq):
1777         (Parser.doParse):
1778
1779 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1780
1781         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1782         https://bugs.webkit.org/show_bug.cgi?id=193297
1783         <rdar://problem/47158841>
1784
1785         Reviewed by Alex Christensen.
1786
1787         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1788             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1789         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1790         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1791         activating the message used to trigger the callback when it is set.
1792
1793 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1794
1795         WKWebView.goBack should reload if there is a safe browsing warning
1796         https://bugs.webkit.org/show_bug.cgi?id=193805
1797         <rdar://problem/46908216>
1798
1799         Reviewed by Geoff Garen.
1800
1801         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1802         (+[Simple3LookupContext sharedLookupContext]):
1803         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1804         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1805         (TEST):
1806
1807 2019-01-25  Chris Dumez  <cdumez@apple.com>
1808
1809         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1810         https://bugs.webkit.org/show_bug.cgi?id=193788
1811         <rdar://problem/47531231>
1812
1813         Reviewed by Alex Christensen.
1814
1815         Add API test coverage.
1816
1817         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1818         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1819
1820 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1821
1822         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1823         https://bugs.webkit.org/show_bug.cgi?id=193771
1824
1825         Unreviewed infrastructure fix.
1826
1827         * Scripts/webkitpy/port/darwin.py:
1828         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1829
1830 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1831
1832         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1833
1834 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1835
1836         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1837
1838         * Scripts/webkitpy/common/config/contributors.json:
1839
1840 2019-01-25  Chris Dumez  <cdumez@apple.com>
1841
1842         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1843         https://bugs.webkit.org/show_bug.cgi?id=193779
1844         <rdar://problem/46170903>
1845
1846         Reviewed by Antti Koivisto.
1847
1848         Add API test that quickly navigates forward to a previous process without waiting for it to
1849         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1850         the process' previous page when reconnecting the it for the forward navigation.
1851
1852         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1853
1854 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1855
1856         Need a way for JavaScript (or bundle) code to participate in undo
1857         https://bugs.webkit.org/show_bug.cgi?id=190009
1858         <rdar://problem/44807048>
1859
1860         Reviewed by Ryosuke Niwa.
1861
1862         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1863         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1864
1865         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1866         (WTR::UIScriptController::lastUndoLabel const):
1867         (WTR::UIScriptController::firstRedoLabel const):
1868         (WTR::UIScriptController::platformUndoManager const):
1869         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1870         (WTR::UIScriptController::lastUndoLabel const):
1871         (WTR::UIScriptController::firstRedoLabel const):
1872         (WTR::UIScriptController::platformUndoManager const):
1873         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1874         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1875         (WTR::UIScriptController::lastUndoLabel const):
1876         (WTR::UIScriptController::firstRedoLabel const):
1877         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1878         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1879         (WTR::UIScriptController::lastUndoLabel const):
1880         (WTR::UIScriptController::firstRedoLabel const):
1881         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1882         (WTR::UIScriptController::platformUndoManager const):
1883         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1884         (WTR::UIScriptController::platformUndoManager const):
1885
1886 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1887
1888         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1889         https://bugs.webkit.org/show_bug.cgi?id=193824
1890
1891         Reviewed by Antti Koivisto.
1892
1893         * LayoutReloaded/misc/LFC-passing-tests.txt:
1894
1895 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1896
1897         Update macOS JSC bot configurations
1898         https://bugs.webkit.org/show_bug.cgi?id=193739
1899
1900         Reviewed by Alexey Proskuryakov.
1901
1902         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1903         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1904         (BubbleQueueServer): Move JSC EWS to Mojave section.
1905         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1906         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1907         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1908
1909 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1910
1911         [Win][WebKitTestRunner] Implement EventSenderProxy
1912         https://bugs.webkit.org/show_bug.cgi?id=193755
1913
1914         Reviewed by Don Olmstead.
1915
1916         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1917         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1918         (WTR::EventSenderProxy::dispatchMessage):
1919         (WTR::EventSenderProxy::EventSenderProxy):
1920         (WTR::EventSenderProxy::mouseDown):
1921         (WTR::EventSenderProxy::mouseUp):
1922         (WTR::EventSenderProxy::mouseMoveTo):
1923         (WTR::EventSenderProxy::mouseScrollBy):
1924         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1925
1926 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1927
1928         Unreviewed fix for API test failure after r240437.
1929
1930         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1931
1932         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1933
1934 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1935
1936         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1937         https://bugs.webkit.org/show_bug.cgi?id=193787
1938         <rdar://problem/47497634>
1939
1940         Reviewed by Alexey Proskuryakov.
1941
1942         * Scripts/webkitdirs.pm:
1943         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1944
1945 2019-01-24  Truitt Savell  <tsavell@apple.com>
1946
1947         Unreviewed, rolling out r240446.
1948
1949         Casued 5 API failures
1950
1951         Reverted changeset:
1952
1953         "Activate the WebResourceLoadStatisticsStore in the
1954         NetworkProcess and deactivate it in the UIProcess."
1955         https://bugs.webkit.org/show_bug.cgi?id=193297
1956         https://trac.webkit.org/changeset/240446
1957
1958 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1959
1960         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1961         https://bugs.webkit.org/show_bug.cgi?id=193741
1962         <rdar://problem/47135030>
1963
1964         Reviewed by Antti Koivisto and Simon Fraser.
1965
1966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1967         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1968         (TestWebKitAPI::TEST):
1969
1970 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1971
1972         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1973         https://bugs.webkit.org/show_bug.cgi?id=193297
1974         <rdar://problem/47158841>
1975
1976         Reviewed by Alex Christensen.
1977
1978         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1979         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1980         activating the message used to trigger the callback when it is set.
1981
1982 2019-01-24  John Wilander  <wilander@apple.com>
1983
1984         Add Ad Click Attribution as an internal/experimental feature
1985         https://bugs.webkit.org/show_bug.cgi?id=193685
1986         <rdar://problem/47450399>
1987
1988         Reviewed by Brent Fulgham.
1989
1990         Added test option adClickAttributionEnabled.
1991
1992         * DumpRenderTree/TestOptions.cpp:
1993         (TestOptions::TestOptions):
1994         * DumpRenderTree/TestOptions.h:
1995         * DumpRenderTree/mac/DumpRenderTree.mm:
1996         (setWebPreferencesForTestOptions):
1997
1998 2019-01-24  Antti Koivisto  <antti@apple.com>
1999
2000         [PSON] Flash on back navigation on Mac
2001         https://bugs.webkit.org/show_bug.cgi?id=193716
2002         <rdar://problem/47148458>
2003
2004         Reviewed by Chris Dumez.
2005
2006         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2007
2008         Closing of the previous page is delayed so waiting for didFinishNavigation is
2009         not sufficient to guarantee we have received all the messages. Wait for them.
2010
2011 2019-01-24  Chris Dumez  <cdumez@apple.com>
2012
2013         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2014         https://bugs.webkit.org/show_bug.cgi?id=193761
2015         <rdar://problem/47456405>
2016
2017         Reviewed by Alex Christensen.
2018
2019         Add API test coverage.
2020
2021         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2022
2023 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2024
2025         webkitpy: Missing PID in crashlog name should not be fatal
2026         https://bugs.webkit.org/show_bug.cgi?id=193771
2027
2028         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2029         of raising an exception.
2030
2031         Reviewed by Lucas Forschler.
2032
2033         * Scripts/webkitpy/port/darwin.py:
2034         (DarwinPort._merge_crash_logs):
2035
2036 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2037
2038         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2039         https://bugs.webkit.org/show_bug.cgi?id=193746
2040
2041         Reviewed by Youenn Fablet.
2042
2043         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2044         so we'd best just not call it.
2045
2046         * Scripts/webkitpy/w3c/test_exporter.py:
2047         (WebPlatformTestExporter.create_branch_with_patch):
2048
2049 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2050
2051         Move FileSystem to WTF
2052         https://bugs.webkit.org/show_bug.cgi?id=193602
2053
2054         Reviewed by Yusuke Suzuki.
2055
2056         * DumpRenderTree/win/DumpRenderTree.cpp:
2057         * TestWebKitAPI/CMakeLists.txt:
2058         * TestWebKitAPI/PlatformGTK.cmake:
2059         * TestWebKitAPI/PlatformJSCOnly.cmake:
2060         * TestWebKitAPI/PlatformPlayStation.cmake:
2061         * TestWebKitAPI/PlatformWPE.cmake:
2062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2063         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2064         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2065         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2066         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2067         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2068         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2069         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2070         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2071         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2072
2073 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2074
2075         [WPE] Remove hard dependency on subprocess32 for the API tests
2076
2077         Rubber-stamped by Carlos Garcia Campos.
2078
2079         * glib/api_test_runner.py:
2080         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2081         its presence only when running WPEQt tests.
2082
2083 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2084
2085         [GLIB] Expose JavaScriptCore options in GLib public API
2086         https://bugs.webkit.org/show_bug.cgi?id=188742
2087
2088         Reviewed by Michael Catanzaro.
2089
2090         Add a test for the new API.
2091
2092         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2093         (testsJSCOptions):
2094         (main):
2095
2096 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2097
2098         [GTK][WPE] Support JPEG 2000 images
2099         https://bugs.webkit.org/show_bug.cgi?id=186272
2100
2101         Reviewed by Žan Doberšek.
2102
2103         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2104
2105         * gtk/jhbuild.modules:
2106         * wpe/jhbuild.modules:
2107
2108 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2109
2110         check-webkit-style should warn when using soft-linking macros in a header
2111         <https://webkit.org/b/193750>
2112
2113         Reviewed by Darin Adler.
2114
2115         * Scripts/webkitpy/style/checkers/cpp.py:
2116         (check_language): Add softlink/header check by refactoring the
2117         softlink/framework check.
2118         (CppChecker): Enable softlink/header check by default.
2119         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2120         (CppStyleTest.test_softlink_framework): Rename from
2121         CppStyleTest.test_softlink() and change test framework name in
2122         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2123         files. Set file_name for macros that only appear in headers.
2124         (CppStyleTest.test_softlink_header): Add tests for using
2125         soft-link macros in headers.
2126
2127 2019-01-23  Chris Dumez  <cdumez@apple.com>
2128
2129         Deprecate API to limit the maximum number of WebProcesses
2130         https://bugs.webkit.org/show_bug.cgi?id=193725
2131         <rdar://problem/47464879>
2132
2133         Reviewed by Geoff Garen.
2134
2135         Update existing API tests to stop using deprecated API.
2136
2137         * MiniBrowser/mac/AppDelegate.m:
2138         (defaultConfiguration):
2139         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2140         (TestWebKitAPI::TEST):
2141         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2142         (TestWebKitAPI::TEST):
2143         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2144         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2145         (TEST):
2146         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2147         (TEST):
2148
2149 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2150
2151         [ews-app] Rename ews model buildermappings to buildermapping
2152         https://bugs.webkit.org/show_bug.cgi?id=193729
2153
2154         Reviewed by Lucas Forschler.
2155
2156         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2157         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2158         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2159
2160 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2161
2162         [ews-app] Rename ews model steps to step
2163         https://bugs.webkit.org/show_bug.cgi?id=193697
2164
2165         Reviewed by Lucas Forschler.
2166
2167         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2168         (Step): Renamed Steps to Step.
2169
2170 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2171
2172         Clean up IndexedDB files between tests
2173         https://bugs.webkit.org/show_bug.cgi?id=192796
2174         <rdar://problem/46824999>
2175
2176         Reviewed by Geoffrey Garen.
2177
2178         * DumpRenderTree/mac/DumpRenderTree.mm:
2179         (runTest):
2180         * WebKitTestRunner/TestController.cpp:
2181         (WTR::TestController::resetStateToConsistentValues):
2182         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2183         (WTR::RemoveAllIndexedDatabasesCallback):
2184         (WTR::TestController::ClearIndexedDatabases):
2185         * WebKitTestRunner/TestController.h:
2186         * WebKitTestRunner/TestInvocation.cpp:
2187         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2188
2189 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2190
2191         [ews-app] Rename ews model Builds to Build
2192         https://bugs.webkit.org/show_bug.cgi?id=193695
2193
2194         Reviewed by Lucas Forschler.
2195
2196         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2197         (Build): Renamed Builds to Build.
2198
2199 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2200
2201         webkitpy: Wait longer when launching WebKitTestRunner
2202         https://bugs.webkit.org/show_bug.cgi?id=193734
2203
2204         Reviewed by Aakash Jain.
2205
2206         * Scripts/webkitpy/port/simulator_process.py:
2207         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2208
2209 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2210
2211         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2212         https://bugs.webkit.org/show_bug.cgi?id=193182
2213         <rdar://problem/47452154>
2214
2215         Reviewed by Tim Horton.
2216
2217         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2218         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2219         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2220
2221         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2222         preventing later tests from recognizing gestures.
2223
2224         * WebKitTestRunner/ios/TestControllerIOS.mm:
2225         (WTR::TestController::platformResetStateToConsistentValues):
2226
2227         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2228
2229 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2230
2231         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2232         https://bugs.webkit.org/show_bug.cgi?id=193722
2233         <rdar://problem/47481475>
2234
2235         Reviewed by Lucas Forschler.
2236
2237         iPhone and iPad ports should both use the iOS config.
2238
2239         * Scripts/webkitpy/port/ios_simulator.py:
2240         (IPhoneSimulatorPort.__init__):
2241         (IPadSimulatorPort.__init__):
2242
2243 2019-01-23  Rob Buis  <rbuis@igalia.com>
2244
2245         Update MIME type parser
2246         https://bugs.webkit.org/show_bug.cgi?id=180526
2247
2248         Reviewed by Frédéric Wang.
2249
2250         Add unit tests for both parse modes of ParsedContentType.
2251
2252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2253         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2254         (TestWebKitAPI::TEST):
2255
2256 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2257
2258         [ews-app] fetch loop should not stop on network issues
2259         https://bugs.webkit.org/show_bug.cgi?id=193666
2260
2261         Reviewed by Lucas Forschler.
2262
2263         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2264         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2265
2266 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2267
2268         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2269         https://bugs.webkit.org/show_bug.cgi?id=189165
2270         <rdar://problem/47433765>
2271
2272         Reviewed by Tim Horton.
2273
2274         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2275         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2276         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2277         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2278         would make its way to the UI process by the time the layer tree commit is finished.
2279
2280         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2281         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2282         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2283         will fail because it asks for -_autofillContext too early.
2284
2285         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2286         is handled in the UI process.
2287
2288         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2289
2290         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2291         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2292         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2293         input session.
2294
2295         (-[AutofillTestView textInputHasAutofillContext]):
2296
2297         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2298
2299         * TestWebKitAPI/cocoa/TestWKWebView.h:
2300         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2301         (nextInputSessionChangeCount):
2302
2303         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2304         This includes changing the focused element from one to another.
2305
2306         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2307         (-[TestWKWebView didStartFormControlInteraction]):
2308         (-[TestWKWebView didEndFormControlInteraction]):
2309         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2310
2311         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2312         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2313         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2314         that doesn't require an input session to one that doesn't.
2315
2316 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2317
2318         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2319         <https://webkit.org/b/193676>
2320
2321         Reviewed by Alexey Proskuryakov.
2322
2323         * Scripts/webkitpy/style/checkers/cpp.py:
2324         (check_member_initialization_list):
2325         - Don't report missing whitespace around colon if the colon at
2326           the start of the line is formatted correctly.
2327         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2328         (WebKitStyleTest.test_member_initialization_list):
2329         - Add a test for a missing permutation of existing tests.
2330         - Add a test this false-positive.
2331         - Add blank lines between subtests to make them easier to read.
2332
2333 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2334
2335         [build.webkit.org] Unit-test failure after r237113
2336         https://bugs.webkit.org/show_bug.cgi?id=193669
2337
2338         Reviewed by Michael Catanzaro.
2339
2340         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2341         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2342         multiple or zero flags.
2343
2344 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2345
2346         Cache bytecode to disk
2347         https://bugs.webkit.org/show_bug.cgi?id=192782
2348         <rdar://problem/46084932>
2349
2350         Reviewed by Keith Miller.
2351
2352         Add test helper to execute bytecode-cache tests: it executes each test
2353         twice, the first with JSC_diskCachePath set to a temporary directory
2354         and second with JSC_forceDiskCache=true (in addition to the cache path)
2355         to guarantee that only the disk cache is being used and no new
2356         UnlinkedCodeBlocks are being created.
2357
2358         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2359         * Scripts/run-jsc-stress-tests:
2360
2361 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2362
2363         [css-logical] Implement flow-relative margin, padding and border shorthands
2364         https://bugs.webkit.org/show_bug.cgi?id=188697
2365
2366         Reviewed by Simon Fraser and Antti Koivisto.
2367
2368         * DumpRenderTree/TestOptions.cpp:
2369         (TestOptions::TestOptions):
2370         * DumpRenderTree/TestOptions.h:
2371         * DumpRenderTree/mac/DumpRenderTree.mm:
2372         (setWebPreferencesForTestOptions):
2373         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2374
2375         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2376         (JSONCSSPropertiesChecker.check_codegen_properties):
2377         Allow CSS property definitions to have a 'runtime-flag' parameter which
2378         disables the property when the specified runtime flag is disabled.
2379
2380 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2381
2382         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2383         https://bugs.webkit.org/show_bug.cgi?id=193643
2384
2385         Reviewed by Michael Catanzaro.
2386
2387         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2388         * wpe/jhbuild.modules: Ditto.
2389
2390 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2391
2392         [LFC][Floats] Take float top position into account when computing containing block height.
2393         https://bugs.webkit.org/show_bug.cgi?id=193655
2394
2395         Reviewed by Antti Koivisto.
2396
2397         * LayoutReloaded/misc/LFC-passing-tests.txt:
2398
2399 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2400
2401         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2402         <https://webkit.org/b/193645>
2403         <rdar://problem/47421574>
2404
2405         Reviewed by Alex Christensen.
2406
2407         - Now checks for local soft-linking of all frameworks that have
2408           their own *SoftLinking.{cpp,h,mm} files.
2409         - Changes softlink/uikit warning to softlink/framework.
2410
2411         * Scripts/webkitpy/style/checkers/cpp.py:
2412         (check_language):
2413         (CppChecker):
2414         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2415         (CppStyleTest):
2416
2417 2019-01-20  Saam Barati  <sbarati@apple.com>
2418
2419         Rollout r240210: It broke tests on iOS
2420         https://bugs.webkit.org/show_bug.cgi?id=193640
2421
2422         Unreviewed.
2423
2424         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2425         * Scripts/run-jsc-stress-tests:
2426
2427 2019-01-20  chris fleizach  <cfleizach@apple.com>
2428
2429         AX: Support returning relative frames for accessibility
2430         https://bugs.webkit.org/show_bug.cgi?id=193414
2431         <rdar://problem/47268501>
2432
2433         Reviewed by Zalan Bujtas.
2434
2435         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2436         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2437         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2438         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2439         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2440         (WTR::attributesOfElement):
2441         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2442
2443 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2444
2445         Unreviewed, add my new email address
2446
2447         * Scripts/webkitpy/common/config/contributors.json:
2448
2449 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2450
2451         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2452         https://bugs.webkit.org/show_bug.cgi?id=193617
2453
2454         Reviewed by Antti Koivisto.
2455
2456         * LayoutReloaded/misc/LFC-passing-tests.txt:
2457
2458 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2459
2460         Unreviewed, rolling out r240209.
2461
2462         Broke GTK/WPE injected bundle
2463
2464         Reverted changeset:
2465
2466         "AX: Support returning relative frames for accessibility"
2467         https://bugs.webkit.org/show_bug.cgi?id=193414
2468         https://trac.webkit.org/changeset/240209
2469
2470 2019-01-12  Dan Bernstein  <mitz@apple.com>
2471
2472         [Cocoa] Avoid importing directly from subumbrella frameworks
2473         https://bugs.webkit.org/show_bug.cgi?id=186016
2474         <rdar://problem/40591038>
2475
2476         Reviewed by Sam Weinig.
2477
2478         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2479           LaunchServices header.
2480         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2481           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2482         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2483           when using SDKs earlier than 10.13.
2484         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2485           and OTHER_CPLUSPLUSFLAGS.
2486         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2487           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2488         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2489           LaunchServices header.
2490
2491 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2492
2493         Cache bytecode to disk
2494         https://bugs.webkit.org/show_bug.cgi?id=192782
2495         <rdar://problem/46084932>
2496
2497         Reviewed by Keith Miller.
2498
2499         Add test helper to execute bytecode-cache tests: it executes each test
2500         twice, the first with JSC_diskCachePath set to a temporary directory
2501         and second with JSC_forceDiskCache=true (in addition to the cache path)
2502         to guarantee that only the disk cache is being used and no new
2503         UnlinkedCodeBlocks are being created.
2504
2505         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2506         * Scripts/run-jsc-stress-tests:
2507
2508 2019-01-20  chris fleizach  <cfleizach@apple.com>
2509
2510         AX: Support returning relative frames for accessibility
2511         https://bugs.webkit.org/show_bug.cgi?id=193414
2512         <rdar://problem/47268501>
2513
2514         Reviewed by Zalan Bujtas.
2515
2516         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2517         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2518         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2519         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2520         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2521         (WTR::attributesOfElement):
2522         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2523
2524 2019-01-20  Antoine Quint  <graouts@apple.com>
2525
2526         Add a POINTER_EVENTS feature flag
2527         https://bugs.webkit.org/show_bug.cgi?id=193577
2528         <rdar://problem/47408511>
2529
2530         Unreviewed. Also enable Pointer Events for iosmac.
2531
2532         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2533
2534 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2535
2536         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2537         https://bugs.webkit.org/show_bug.cgi?id=193613
2538
2539         Reviewed by Antti Koivisto.
2540
2541         * LayoutReloaded/misc/LFC-passing-tests.txt:
2542
2543 2019-01-19  Antoine Quint  <graouts@apple.com>
2544
2545         Add a POINTER_EVENTS feature flag
2546         https://bugs.webkit.org/show_bug.cgi?id=193577
2547
2548         Reviewed by Dean Jackson.
2549
2550         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2551
2552 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2553
2554         Disable the run-jsc-stress-test remote host key check [second round].
2555         https://bugs.webkit.org/show_bug.cgi?id=192988
2556
2557         Reviewed by Dewei Zhu.
2558
2559         * Scripts/run-jsc-stress-tests:
2560
2561 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2562
2563         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2564         https://bugs.webkit.org/show_bug.cgi?id=193597
2565
2566         Reviewed by Lucas Forschler.
2567
2568         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2569
2570 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2571
2572         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2573         https://bugs.webkit.org/show_bug.cgi?id=193595
2574
2575         Reviewed by Lucas Forschler.
2576
2577         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2578         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2579         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2580
2581 2019-01-18  Chris Dumez  <cdumez@apple.com>
2582
2583         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2584         https://bugs.webkit.org/show_bug.cgi?id=193588
2585         <rdar://problem/47131566>
2586
2587         Reviewed by Alex Christensen.
2588
2589         Add layout test coverage.
2590
2591         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2592
2593 2019-01-18  Jer Noble  <jer.noble@apple.com>
2594
2595         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2596         https://bugs.webkit.org/show_bug.cgi?id=189553
2597
2598         Reviewed by Tim Horton.
2599
2600         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2601
2602         * ContentExtensionTester/Configurations/Base.xcconfig:
2603         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2604         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2605         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2606         * ImageDiff/cg/Configurations/Base.xcconfig:
2607         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2608         * MiniBrowser/Configurations/Base.xcconfig:
2609         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2610         * MobileMiniBrowser/Configurations/Base.xcconfig:
2611         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2612         * Scripts/webkitpy/style/checker.py:
2613         (_all_categories):
2614         (FileType):
2615         (CheckerDispatcher._file_type):
2616         (CheckerDispatcher._create_checker):
2617         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2618         (SDKVariantChecker):
2619         (SDKVariantChecker.__init__):
2620         (SDKVariantChecker.check):
2621         * TestWebKitAPI/Configurations/Base.xcconfig:
2622         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2623         * WebEditingTester/Configurations/Base.xcconfig:
2624         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2625         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2626         * WebKitTestRunner/Configurations/Base.xcconfig:
2627         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2628         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2629         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2630
2631 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2632
2633         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2634         <https://webkit.org/b/193568>
2635         <rdar://problem/47381130>
2636
2637         Reviewed by Alex Christensen.
2638
2639         Make sure no one re-introduces UIKit soft-linking by adding a
2640         style rule.
2641
2642         * Scripts/webkitpy/style/checkers/cpp.py:
2643         (check_language): Add softlink/uikit check.
2644         (CppChecker): Enable softlink/uikit check.
2645         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2646         (CppStyleTest): Add test for softlink/uikit.
2647
2648 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2649
2650         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2651         https://bugs.webkit.org/show_bug.cgi?id=193584
2652
2653         Change "-dev" to "-devel".
2654
2655         Reviewed by Michael Catanzaro.
2656
2657         * gtk/install-dependencies:
2658
2659 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2660
2661         webkitpy: Add iPhone and iPad ports
2662         https://bugs.webkit.org/show_bug.cgi?id=193537
2663         <rdar://problem/47353390>
2664
2665         Reviewed by Lucas Forschler.
2666
2667         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2668         ports. Note that this separation is optional, the --ios-simulator command remains.
2669
2670         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2671         (RunTest.test_device_type_test_division): Drive-by fix.
2672         (RunTest.test_device_type_specific_listing): Ditto.
2673         (RunTest.test_ipad_test_division):
2674         (RunTest):
2675         (RunTest.test_ipad_listing):
2676         * Scripts/webkitpy/port/factory.py:
2677         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2678         (PortFactory):
2679         * Scripts/webkitpy/port/ios_simulator.py:
2680         (IPhoneSimulatorPort):
2681         (IPadSimulatorPort):
2682
2683 2019-01-18  Chris Dumez  <cdumez@apple.com>
2684
2685         Regression(PSON) Scroll position is not always restored properly when navigating back
2686         https://bugs.webkit.org/show_bug.cgi?id=193578
2687         <rdar://problem/47386331>
2688
2689         Reviewed by Tim Horton.
2690
2691         Add API test coverage.
2692
2693         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2694
2695 2019-01-18  Youenn Fablet  <youenn@apple.com>
2696
2697         Add a new SPI to request for cache storage quota increase
2698         https://bugs.webkit.org/show_bug.cgi?id=193323
2699
2700         Reviewed by Alex Christensen.
2701
2702         Implement WebsiteDataStore quota delegate to handle quota requests.
2703         By default, do not update quota.
2704         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2705
2706         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2707         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2708         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2709         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2710         * WebKitTestRunner/TestController.cpp:
2711         (WTR::TestController::allowCacheStorageQuotaIncrease):
2712         * WebKitTestRunner/TestController.h:
2713         * WebKitTestRunner/TestInvocation.cpp:
2714         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2715         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2716         (-[CacheStorageQuotaManager init]):
2717         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2718         (WTR::initializeWebViewConfiguration):
2719         (WTR::TestController::cocoaResetStateToConsistentValues):
2720         (WTR::TestController::allowCacheStorageQuotaIncrease):
2721
2722 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2723
2724         [ews-build] Pass owner to the triggered builds
2725         https://bugs.webkit.org/show_bug.cgi?id=193574
2726
2727         Reviewed by Lucas Forschler.
2728
2729         * BuildSlaveSupport/ews-build/factories.py:
2730         (BuildFactory.propertiesToPassToTriggers):
2731
2732 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2733
2734         [ews-app] Send patch author as a build property
2735         https://bugs.webkit.org/show_bug.cgi?id=193560
2736
2737         Reviewed by Lucas Forschler.
2738
2739         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2740         (BugzillaPatchFetcher.fetch):
2741
2742 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2743
2744         webkitpy: Implement device type specific expected results (Follow-up fix)
2745         https://bugs.webkit.org/show_bug.cgi?id=192162
2746         <rdar://problem/46345449>
2747
2748         Unreviewed infrastructure fix.
2749
2750         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2751         (Manager.run): Don't boot a device if no tests are available to run on it.
2752
2753 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2754
2755         webkitpy: Implement device type specific expected results (Follow-up fix)
2756         https://bugs.webkit.org/show_bug.cgi?id=192162
2757         <rdar://problem/46345449>
2758
2759         Unreviewed infrastructure fix.
2760
2761         * Scripts/webkitpy/api_tests/manager.py:
2762         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2763
2764 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2765
2766         webkitpy: Implement device type specific expected results (Part 2)
2767         https://bugs.webkit.org/show_bug.cgi?id=192162
2768         <rdar://problem/46345449>
2769
2770         Rubber-stamped by Aakash Jain.
2771
2772         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2773         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2774         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2775
2776         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2777         (LayoutTestFinder.find_tests): Pass device_type through.
2778         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2779         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2780         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2781         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2782         (Manager._collect_tests): Pass device type to test finder.
2783         (Manager._needs_web_platform_test):
2784         (Manager._prepare_lists): Index _expectations by device type.
2785         (Manager._test_input_for_file):
2786         (Manager._test_is_slow): Ditto.
2787         (Manager._test_should_dump_jsconsolelog_in_stderr):
2788         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2789         (Manager._get_test_inputs):
2790         (Manager._update_worker_count):
2791         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2792         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2793         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2794         the one which runs the test.
2795         (Manager._run_test_subset):
2796         (Manager._run_tests): Index _expectations by current_device_type.
2797         (Manager._print_expectation_line_for_test): Ditto.
2798         (Manager._print_expectations_for_subset): Ditto.
2799         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2800         Unlike run, this function will behave the same regardless of what devices are available.
2801         (Manager._custom_device_for_test): Deleted.
2802         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2803         (ManagerTest.test_uses_custom_device): Deleted.
2804         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2805         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2806         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2807         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2808         all of the expectations.
2809         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2810         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2811         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2812         (TestExpectations.__init__): Allow device_type to be passed through.
2813         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2814         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2815         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2816         (summarize_results):
2817         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2818         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2819         a test ran with, one must check all expectations to find the first non-skip expectation.
2820         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2821         (RunTest.test_device_type_test_division):
2822         (RunTest):
2823         (RunTest.test_device_type_specific_listing):
2824         * Scripts/webkitpy/port/base.py:
2825         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2826         (Port.supported_device_types): The result of this function will change based on what devices are available.
2827         * Scripts/webkitpy/port/device_port.py:
2828         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2829         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2830         can be used.
2831         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2832         any, or the DEFAULT_DEVICE_TYPES of the port.
2833         * Scripts/webkitpy/port/ios.py:
2834         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2835         * Scripts/webkitpy/port/ios_simulator.py:
2836         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2837         * Scripts/webkitpy/port/watch.py:
2838         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2839         * Scripts/webkitpy/port/watch_simulator.py:
2840         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2841         * Scripts/webkitpy/xcode/device_type.py:
2842         (DeviceType):
2843         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2844
2845 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2846
2847         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2848         https://bugs.webkit.org/show_bug.cgi?id=193575
2849
2850         Reviewed by Michael Catanzaro.
2851
2852         Allow the script to run without explicit port argument because
2853         it's specific to the WPE port anyway.
2854
2855         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2856         and simplify the rest of the code accordingly.
2857
2858 2019-01-18  Charlie Turner  <cturner@igalia.com>
2859
2860         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2861         https://bugs.webkit.org/show_bug.cgi?id=192229
2862
2863         Reviewed by Xabier Rodriguez-Calvar.
2864
2865         * MiniBrowser/wpe/main.cpp:
2866         (main): Enable encrypted-media by default.
2867
2868 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2869
2870         [Flatpak] Missing KeyboardInterrupt exception handler
2871         https://bugs.webkit.org/show_bug.cgi?id=193570
2872
2873         Reviewed by Michael Catanzaro.
2874
2875         * flatpak/flatpakutils.py:
2876         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2877
2878 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2879
2880         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2881         https://bugs.webkit.org/show_bug.cgi?id=193564
2882
2883         Reviewed by Antti Koivisto.
2884
2885         * LayoutReloaded/misc/LFC-passing-tests.txt:
2886
2887 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2888
2889         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2890         https://bugs.webkit.org/show_bug.cgi?id=193562
2891
2892         Reviewed by Antti Koivisto.
2893
2894         * LayoutReloaded/misc/LFC-passing-tests.txt:
2895
2896 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2897
2898         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2899         https://bugs.webkit.org/show_bug.cgi?id=193555
2900
2901         Reviewed by Antti Koivisto.
2902
2903         * LayoutReloaded/misc/LFC-passing-tests.txt:
2904
2905 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2906
2907         [WPE] Add Qt extension
2908         https://bugs.webkit.org/show_bug.cgi?id=191464
2909
2910         Reviewed by Carlos Garcia Campos.
2911
2912         MiniBrowser and API tests for the WPE Qt API. To run the
2913         MiniBrowser a new script is introduced. Example invocation:
2914
2915         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2916
2917         Also note-worthy is the introduction of the python2-subprocess32
2918         dependency to run the GLib API tests.
2919
2920         * MiniBrowser/wpe/CMakeLists.txt:
2921         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2922         * MiniBrowser/wpe/qt/main.cpp: Added.
2923         (main):
2924         * MiniBrowser/wpe/qt/main.qml: Added.
2925         * MiniBrowser/wpe/qt/qml.qrc: Added.
2926         * Scripts/run-gtk-tests:
2927         (GtkTestRunner.is_google_test):
2928         (GtkTestRunner):
2929         (GtkTestRunner.is_qt_test):
2930         * Scripts/run-qt-wpe-minibrowser: Added.
2931         * Scripts/run-wpe-tests:
2932         (WPETestRunner):
2933         (WPETestRunner.is_google_test):
2934         (WPETestRunner.is_qt_test):
2935         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2936         (TestLoad::main):
2937         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2938         (TestLoadHtml::main):
2939         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2940         (TestLoadRequest::main):
2941         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2942         (TestRunJavaScript::main):
2943         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2944         (waitForSignal):
2945         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2946         (LoadSpy::LoadSpy):
2947         (LoadSpy::~LoadSpy):
2948         (LoadSpy::onLoadingChanged):
2949         (LoadStartedCatcher::LoadStartedCatcher):
2950         (LoadStartedCatcher::~LoadStartedCatcher):
2951         (LoadStartedCatcher::onLoadingChanged):
2952         (waitForLoadSucceeded):
2953         (waitForLoadFailed):
2954         * TestWebKitAPI/glib/CMakeLists.txt:
2955         * flatpak/flatpakutils.py:
2956         (WebkitFlatpak.load_from_args):
2957         (WebkitFlatpak.__init__):
2958         (WebkitFlatpak.clean_args):
2959         (WebkitFlatpak.run_in_sandbox):
2960         * flatpak/org.webkit.CommonModules.yaml:
2961         * flatpak/org.webkit.WPE.yaml:
2962         * flatpak/org.webkit.WPEModules.yaml:
2963         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2964         * flatpak/org.webkit.WebKit.yaml:
2965         * glib/api_test_runner.py:
2966         (TestRunner._run_test_qt):
2967         (TestRunner.is_qt_test):
2968         (TestRunner._run_test):
2969
2970 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2971
2972         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2973         https://bugs.webkit.org/show_bug.cgi?id=193494
2974         <rdar://problem/46859627>
2975
2976         Reviewed by Simon Fraser and Tim Horton.
2977
2978         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2979         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2980
2981         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2982         (WTR::UIScriptController::contentOffsetX const):
2983         (WTR::UIScriptController::contentOffsetY const):
2984         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2985         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2986         (WTR::UIScriptController::contentOffsetX const):
2987         (WTR::UIScriptController::contentOffsetY const):
2988         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2989
2990         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2991
2992         * WebKitTestRunner/TestController.cpp:
2993         (WTR::updateTestOptionsFromTestHeader):
2994         * WebKitTestRunner/TestOptions.h:
2995         (WTR::TestOptions::hasSameInitializationOptions const):
2996         * WebKitTestRunner/ios/TestControllerIOS.mm:
2997         (WTR::TestController::platformResetStateToConsistentValues):
2998         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2999         (WTR::UIScriptController::contentOffsetX const):
3000         (WTR::UIScriptController::contentOffsetY const):
3001
3002 2019-01-17  Truitt Savell  <tsavell@apple.com>
3003
3004         Unreviewed, rolling out r240124.
3005
3006         This commit broke an internal build.
3007
3008         Reverted changeset:
3009
3010         "SDK_VARIANT build destinations should be separate from non-
3011         SDK_VARIANT builds"
3012         https://bugs.webkit.org/show_bug.cgi?id=189553
3013         https://trac.webkit.org/changeset/240124
3014
3015 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3016
3017         Fix string concatenation API test after r239920
3018         https://bugs.webkit.org/show_bug.cgi?id=193551
3019         <rdar://problem/47359304>
3020
3021         Reviewed by Youenn Fablet.
3022
3023         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3024         (TestWebKitAPI::TEST):
3025         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3026         in WebKit's build configuration like it apparently is on Linux.
3027
3028 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3029
3030         [ews-build] validate-patch should handle the case when bug_id is None
3031         https://bugs.webkit.org/show_bug.cgi?id=193547
3032
3033         Reviewed by Lucas Forschler.
3034
3035         * BuildSlaveSupport/ews-build/steps.py:
3036         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3037         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3038
3039 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3040
3041         [ews-build] Add patch author information in build
3042         https://bugs.webkit.org/show_bug.cgi?id=193465
3043
3044         Reviewed by Lucas Forschler.
3045
3046         * BuildSlaveSupport/ews-build/steps.py:
3047         (ValidatePatch._is_patch_obsolete):
3048
3049 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3050
3051         [ews-build] Pass bug_id to the triggered builds
3052         https://bugs.webkit.org/show_bug.cgi?id=193548
3053
3054         Reviewed by Lucas Forschler.
3055
3056         * BuildSlaveSupport/ews-build/factories.py:
3057         (BuildFactory.propertiesToPassToTriggers):
3058
3059 2019-01-17  Jer Noble  <jer.noble@apple.com>
3060
3061         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3062         https://bugs.webkit.org/show_bug.cgi?id=189553
3063
3064         Reviewed by Tim Horton.
3065
3066         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3067
3068         * ContentExtensionTester/Configurations/Base.xcconfig:
3069         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3070         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3071         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3072         * ImageDiff/cg/Configurations/Base.xcconfig:
3073         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3074         * MiniBrowser/Configurations/Base.xcconfig:
3075         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3076         * MobileMiniBrowser/Configurations/Base.xcconfig:
3077         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3078         * Scripts/webkitpy/style/checker.py:
3079         (_all_categories):
3080         (FileType):
3081         (CheckerDispatcher._file_type):
3082         (CheckerDispatcher._create_checker):
3083         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3084         (SDKVariantChecker):
3085         (SDKVariantChecker.__init__):
3086         (SDKVariantChecker.check):
3087         * TestWebKitAPI/Configurations/Base.xcconfig:
3088         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3089         * WebEditingTester/Configurations/Base.xcconfig:
3090         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3091         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3092         * WebKitTestRunner/Configurations/Base.xcconfig:
3093         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3094         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3095         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3096
3097 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3098
3099         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3100         https://bugs.webkit.org/show_bug.cgi?id=193534
3101
3102         Reviewed by Antti Koivisto.
3103
3104         * LayoutReloaded/misc/LFC-passing-tests.txt:
3105
3106 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3107
3108         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3109         https://bugs.webkit.org/show_bug.cgi?id=193528
3110
3111         Reviewed by Antti Koivisto.
3112
3113         * LayoutReloaded/misc/LFC-passing-tests.txt:
3114
3115 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3116
3117         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3118         https://bugs.webkit.org/show_bug.cgi?id=193520
3119
3120         Reviewed by Antti Koivisto.
3121
3122         * LayoutReloaded/misc/LFC-passing-tests.txt:
3123
3124 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3125
3126         [ews-build] unapply-patch step should not update source
3127         https://bugs.webkit.org/show_bug.cgi?id=193234
3128
3129         Reviewed by Lucas Forschler.
3130
3131         * BuildSlaveSupport/ews-build/steps.py:
3132         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3133         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3134
3135 2019-01-16  Youenn Fablet  <youenn@apple.com>
3136
3137         Add a new SPI for controlling getUserMedia
3138         https://bugs.webkit.org/show_bug.cgi?id=192793
3139
3140         Reviewed by Eric Carlson.
3141
3142         * MiniBrowser/mac/WK2BrowserWindowController.m:
3143         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3144         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3145         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3146         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3147         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3148         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3149         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3150         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3151         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3152         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3153         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3154         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3155         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3156         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3157
3158 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3159
3160         [LFC][BFC] Inflow non-replaced used width should not be negative.
3161         https://bugs.webkit.org/show_bug.cgi?id=193495
3162
3163         Reviewed by Antti Koivisto.
3164
3165         * LayoutReloaded/misc/LFC-passing-tests.txt:
3166
3167 2019-01-16  Chris Dumez  <cdumez@apple.com>
3168
3169         Regression(PSON) View becomes blank after click a cross-site download link
3170         https://bugs.webkit.org/show_bug.cgi?id=193361
3171         <rdar://problem/47099573>
3172
3173         Reviewed by Geoffrey Garen.
3174
3175         Add API test coverage.
3176
3177         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3178         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3179
3180 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3181
3182         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3183         https://bugs.webkit.org/show_bug.cgi?id=193470
3184
3185         Reviewed by Antti Koivisto.
3186
3187         * LayoutReloaded/misc/LFC-passing-tests.txt:
3188
3189 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3190
3191         [LFC] Adjust margin box verification.
3192         https://bugs.webkit.org/show_bug.cgi?id=193482
3193
3194         Reviewed by Antti Koivisto.
3195
3196         * LayoutReloaded/misc/LFC-passing-tests.txt:
3197
3198 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3199
3200         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3201         https://bugs.webkit.org/show_bug.cgi?id=193451
3202
3203         Reviewed by Geoffrey Garen.
3204
3205         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3206         (TEST):
3207         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3208         (runWebsiteDataStoreCustomPaths):
3209
3210 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3211
3212         webkitpy: Support boolean simctl isAvailable
3213         https://bugs.webkit.org/show_bug.cgi?id=193472
3214         <rdar://problem/47296150>
3215
3216         Reviewed by Ryosuke Niwa.
3217
3218         * Scripts/webkitpy/xcode/simulated_device.py:
3219         (SimulatedDeviceManager._create_runtimes):
3220         (SimulatedDeviceManager._create_device_with_runtime):
3221
3222 2019-01-15  Chris Dumez  <cdumez@apple.com>
3223
3224         Unreviewed, rolling out r239993, r239995, r239997, and
3225         r239999.
3226
3227         Caused assertions under
3228         ViewGestureController::disconnectFromProcess()
3229
3230         Reverted changesets:
3231
3232         "Regression(PSON) View becomes blank after click a cross-site
3233         download link"
3234         https://bugs.webkit.org/show_bug.cgi?id=193361
3235         https://trac.webkit.org/changeset/239993
3236
3237         "Unreviewed iOS build fix after r239993."
3238         https://trac.webkit.org/changeset/239995
3239
3240         "Fix iOS build after r239993"
3241         https://bugs.webkit.org/show_bug.cgi?id=193361
3242         https://trac.webkit.org/changeset/239997
3243
3244         "Unreviewed, revert part of r239997 as it is not needed to fix
3245         the build."
3246         https://trac.webkit.org/changeset/239999
3247
3248 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3249
3250         Cannot tab out of WKWebView on macOS
3251         https://bugs.webkit.org/show_bug.cgi?id=161448
3252         <rdar://problem/28100085>
3253
3254         Reviewed by Dean Jackson.
3255
3256         Add a test that tabbing into and out of WKWebView works correctly.
3257
3258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3259         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3260         (WebKit2_CommandBackForwardTest::SetUp):
3261         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3262         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3263         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3264         (-[FocusableView canBecomeKeyView]):
3265         (TEST):
3266         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3267         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3268         (-[OffscreenWindow initWithSize:]):
3269         (-[OffscreenWindow isKeyWindow]):
3270         (-[OffscreenWindow isVisible]):
3271         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3272         (TestWebKitAPI::PlatformWebView::initialize):
3273         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3274         (-[ActiveOffscreenWindow isVisible]): Deleted.
3275         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3276
3277 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3278
3279         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3280         https://bugs.webkit.org/show_bug.cgi?id=193459
3281
3282         Reviewed by Mark Lam.
3283
3284         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3285         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3286
3287 2019-01-15  Chris Dumez  <cdumez@apple.com>
3288
3289         Regression(PSON) View becomes blank after click a cross-site download link
3290         https://bugs.webkit.org/show_bug.cgi?id=193361
3291         <rdar://problem/47099573>
3292
3293         Reviewed by Geoff Garen.
3294
3295         Add API test coverage.
3296
3297         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3298         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3299
3300 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3301
3302         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3303         https://bugs.webkit.org/show_bug.cgi?id=193448
3304
3305         Reviewed by Antti Koivisto.
3306
3307         * LayoutReloaded/misc/LFC-passing-tests.txt:
3308
3309 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3310
3311         webkitpy: Implement device type specific expected results (Part 1)
3312         https://bugs.webkit.org/show_bug.cgi?id=192162
3313
3314         Reviewed by Lucas Forschler.
3315
3316         Device type specific expected results covers two related ideas. The first (covered by this change)
3317         is where to search for -expected.* files. The second is which tests to run based on the
3318         TestExpectations.txt file.
3319
3320         After this change, the baseline search path will be determined by the type of device running a
3321         test. Device type will be passed into any function which picks a file based on the baseline search
3322         path.
3323
3324         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3325         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3326         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3327         (Manager.run): Print baseline search path for each round of devices.
3328         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3329         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3330         (SingleTestRunner._expected_driver_output): Ditto.
3331         (SingleTestRunner._driver_input): Ditto.
3332         * Scripts/webkitpy/layout_tests/views/printing.py:
3333         (Printer.print_config): Move printing of baseline search path to a separate function.
3334         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3335         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3336         (Testprinter.test_print_config):
3337         (Testprinter.test_print_baseline_search_path):
3338         * Scripts/webkitpy/port/base.py:
3339         (Port.baseline_search_path): Pass device_type through.
3340         (Port._expected_baselines_for_suffixes): Ditto.
3341         (Port.expected_baselines): Ditto.
3342         (Port.expected_filename): Ditto.
3343         (Port.expected_checksum): Ditto.
3344         (Port.expected_image): Ditto.
3345         (Port.expected_audio): Ditto.
3346         (Port.expected_text): Ditto.
3347         (Port.reference_files): Ditto.
3348         (Port.tests): Ditto.
3349         (Port._expanded_paths): Ditto.
3350         (Port.skipped_layout_tests): Ditto.
3351         (Port.expectations_dict): Ditto.
3352         (Port._port_specific_expectations_files): Ditto.
3353         (Port.expectations_files): Ditto.
3354         (Port.test_search_path): Ditto.
3355         (Port._tests_for_other_platforms): Ditto.
3356         * Scripts/webkitpy/port/base_unittest.py:
3357         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3358         (PortTest.test_nonexistant_expectations): Ditto.
3359         (test_ref_tests_platform_directory): Ditto.
3360         * Scripts/webkitpy/port/darwin.py:
3361         (DarwinPort._port_specific_expectations_files): Accept device_type.
3362         * Scripts/webkitpy/port/driver.py:
3363         (DriverProxy):
3364         (DriverProxy.host): Expose _target_host for device_type information.
3365         * Scripts/webkitpy/port/gtk.py:
3366         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3367         * Scripts/webkitpy/port/ios.py:
3368         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3369         * Scripts/webkitpy/port/mac.py:
3370         (MacPort. default_baseline_search_path): Ditto.
3371         * Scripts/webkitpy/port/port_testcase.py:
3372         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3373         * Scripts/webkitpy/port/test.py:
3374         * Scripts/webkitpy/port/watch.py:
3375         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3376         * Scripts/webkitpy/port/win.py:
3377         (WinPort.test_search_path): Accept, but do not use, device_type.
3378         * Scripts/webkitpy/port/wpe.py:
3379         (WPEPort._port_specific_expectations_files): Ditto.
3380         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3381         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3382
3383 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3384
3385         [LFC] Use the containing block's padding box to position out-of-flow elements.
3386         https://bugs.webkit.org/show_bug.cgi?id=193431
3387
3388         Reviewed by Antti Koivisto.
3389
3390         * LayoutReloaded/misc/LFC-passing-tests.txt:
3391
3392 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3393
3394         Move a test implementation file that got misplaced in the Xcode project
3395
3396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3397
3398 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3399
3400         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3401         r239913, and r239914.
3402         https://bugs.webkit.org/show_bug.cgi?id=193407
3403
3404         These revisions caused an internal failure (Requested by
3405         Truitt on #webkit).
3406
3407         Reverted changesets:
3408
3409         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3410         https://bugs.webkit.org/show_bug.cgi?id=186016
3411         https://trac.webkit.org/changeset/239901
3412
3413         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3414         https://trac.webkit.org/changeset/239909
3415
3416         "Tried to fix the build."
3417         https://trac.webkit.org/changeset/239910
3418
3419         "Fixed iOS builds after r239910."
3420         https://trac.webkit.org/changeset/239912
3421
3422         "More build fixing."
3423         https://trac.webkit.org/changeset/239913
3424
3425         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3426         https://trac.webkit.org/changeset/239914
3427
3428 2019-01-14  Mark Lam  <mark.lam@apple.com>
3429
3430         Re-enable ability to build --cloop builds.
3431         https://bugs.webkit.org/show_bug.cgi?id=192955
3432         <rdar://problem/46882363>
3433
3434         Reviewed by Saam barati and Keith Miller.
3435
3436         The --cloop build option was being ignored this whole time since r236381.
3437         This patch makes it possible to build CLoop builds again.
3438
3439         * Scripts/build-jsc:
3440         * Scripts/webkitperl/FeatureList.pm:
3441         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3442
3443 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3444
3445         webkitpy: Expose device_type from host-like objects
3446         https://bugs.webkit.org/show_bug.cgi?id=193406
3447         <rdar://problem/47262305>
3448
3449         Reviewed by Lucas Forschler.
3450
3451         Devices should expose device_type. As a result, all host objects should
3452         provide a device_type property, even if they do not yet define a device_type.
3453
3454         * Scripts/webkitpy/common/system/systemhost.py:
3455         (SystemHost):
3456         (SystemHost.device_type):
3457         * Scripts/webkitpy/common/system/systemhost_mock.py:
3458         (MockSystemHost):
3459         (MockSystemHost.device_type):
3460         * Scripts/webkitpy/port/device.py:
3461         (Device):
3462         (Device.device_type):
3463         * Scripts/webkitpy/xcode/simulated_device.py:
3464         (SimulatedDeviceManager._find_exisiting_device_for_request):
3465         (SimulatedDeviceManager._disambiguate_device_type):
3466         (SimulatedDeviceManager._does_fulfill_request):
3467         (SimulatedDeviceManager.device_count_for_type):
3468         (SimulatedDeviceManager.initialize_devices):
3469         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3470         (test_available_devices):
3471         (test_swapping_devices):
3472
3473 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3474
3475         webkitpy: Support alternate simctl device list output (Follow-up fix)
3476         https://bugs.webkit.org/show_bug.cgi?id=193362
3477         <rdar://problem/47122965>
3478
3479         Rubber-stamped by Lucas Forschler.
3480
3481         * Scripts/webkitpy/xcode/simulated_device.py:
3482         (SimulatedDeviceManager.populate_available_devices):
3483
3484 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3485
3486         [iOS] Expose SPI to access the current sentence boundary and selection state
3487         https://bugs.webkit.org/show_bug.cgi?id=193398
3488         <rdar://problem/45893108>
3489
3490         Reviewed by Dean Jackson.
3491
3492         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3493         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3494         expected.
3495
3496         * TestWebKitAPI/EditingTestHarness.h:
3497         * TestWebKitAPI/EditingTestHarness.mm:
3498         (-[EditingTestHarness moveBackward]):
3499         (-[EditingTestHarness moveForward]):
3500         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3501
3502         Add a couple of new helper methods on EditingTestHarness.
3503
3504         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3505         (-[SelectionChangeObserver initWithWebView:]):
3506         (-[SelectionChangeObserver webView]):
3507         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3508         (-[SelectionChangeObserver currentSelectionAttributes]):
3509
3510 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3511
3512         [LFC][BFC] Add basic box-sizing support.
3513         https://bugs.webkit.org/show_bug.cgi?id=193392
3514
3515         Reviewed by Antti Koivisto.
3516
3517         * LayoutReloaded/misc/LFC-passing-tests.txt:
3518
3519 2019-01-14  Charlie Turner  <cturner@igalia.com>
3520
3521         [WPE] API test gardening
3522         https://bugs.webkit.org/show_bug.cgi?id=193319
3523
3524         Reviewed by Michael Catanzaro.
3525
3526         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3527         passing tests.
3528
3529 2019-01-14  Charlie Turner  <cturner@igalia.com>
3530
3531         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3532         https://bugs.webkit.org/show_bug.cgi?id=192977
3533
3534         Reviewed by Carlos Garcia Campos.
3535
3536         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3537         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3538         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3539         (TestWebKitAPI::GStreamerTest::SetUp):
3540         (TestWebKitAPI::GStreamerTest::TearDown):
3541         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3542         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3543         (TestWebKitAPI::TEST_F):
3544
3545 2019-01-14  Charlie Turner  <cturner@igalia.com>
3546
3547         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3548         https://bugs.webkit.org/show_bug.cgi?id=193332
3549
3550         Reviewed by Michael Catanzaro.
3551
3552         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3553         defined as a char16_t, which changed in ICU 59, the
3554         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3555         unsigned short. This test is relying on the behaviour that
3556         UChar=unsigned short, which doesn't hold across platforms and ICU
3557         library versions. The full fix would be a special syntax for
3558         literal characters so that these ambiguities do not arise. That
3559         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3560         (TestWebKitAPI::TEST):
3561
3562 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3563
3564         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3565
3566         * Scripts/make-dist:
3567         (Distcheck.configure):
3568
3569 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3570
3571         [ews-build] Update macOS queue configurations
3572         https://bugs.webkit.org/show_bug.cgi?id=193365
3573         <rdar://problem/47221073>
3574
3575         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3576
3577         * BuildSlaveSupport/ews-build/config.json:
3578
3579 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3580
3581         [LFC] Adjust assert for statically positioned fixed elements
3582         https://bugs.webkit.org/show_bug.cgi?id=193385
3583
3584         Reviewed by Antti Koivisto.
3585
3586         * LayoutReloaded/misc/LFC-passing-tests.txt:
3587
3588 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3589
3590         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3591         https://bugs.webkit.org/show_bug.cgi?id=193387
3592
3593         Reviewed by Carlos Garcia Campos.
3594
3595         * MiniBrowser/wpe/main.cpp:
3596         (main):
3597
3598 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3599
3600         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3601         https://bugs.webkit.org/show_bug.cgi?id=191655
3602         rdar://problem/46074680
3603
3604         Reviewed by Megan Gardner.
3605
3606         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3607         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3608
3609 2019-01-12  Dan Bernstein  <mitz@apple.com>
3610
3611         [Cocoa] Avoid importing directly from subumbrella frameworks
3612         https://bugs.webkit.org/show_bug.cgi?id=186016
3613         <rdar://problem/40591038>
3614
3615         Reviewed by Sam Weinig.
3616
3617         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3618           LaunchServices header.
3619         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3620           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3621         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3622           when using SDKs earlier than 10.13.
3623         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3624           and OTHER_CPLUSPLUSFLAGS.
3625         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3626           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3627         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3628           LaunchServices header.
3629
3630 2019-01-11  John Wilander  <wilander@apple.com>
3631
3632         Compile out Web API Statistics Collection
3633         https://bugs.webkit.org/show_bug.cgi?id=193370
3634         <rdar://problem/45388584>
3635
3636         Reviewed by Brent Fulgham.
3637
3638         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3639             Defined ENABLE_WEB_API_STATISTICS, off by default.
3640
3641 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3642
3643         [WPE] Add gtk-doc
3644         https://bugs.webkit.org/show_bug.cgi?id=178900
3645
3646         Reviewed by Michael Catanzaro.
3647
3648         Add Tools/gtkdoc to manifest.txt.in files.
3649         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3650
3651         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3652         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3653
3654 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3655
3656         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3657         https://bugs.webkit.org/show_bug.cgi?id=193364
3658         <rdar://problem/47214117>
3659
3660         Reviewed by Tim Horton.
3661
3662         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3663         precise, whereas dragging near the middle of the textarea does.
3664
3665         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3666         (TestWebKitAPI::TEST):
3667
3668 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3669
3670         webkitpy: Support alternate simctl device list output
3671         https://bugs.webkit.org/show_bug.cgi?id=193362
3672         <rdar://problem/47122965>
3673
3674         Reviewed by Lucas Forschler.
3675
3676         * Scripts/webkitpy/xcode/simulated_device.py:
3677         (SimulatedDeviceManager.populate_available_devices):
3678
3679 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3680
3681         [ews-build] Update macOS queue configurations
3682         https://bugs.webkit.org/show_bug.cgi?id=193365
3683
3684         Reviewed by Lucas Forschler.
3685
3686         * BuildSlaveSupport/ews-build/config.json:
3687
3688 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3689
3690         webkitpy: Incorporate device type into baseline search path
3691         https://bugs.webkit.org/show_bug.cgi?id=193356
3692         <rdar://problem/47215515>
3693
3694         Reviewed by Lucas Forschler.
3695
3696         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3697
3698         * Scripts/webkitpy/port/base.py:
3699         (Port.default_baseline_search_path): Allow device type to be passed in.
3700         * Scripts/webkitpy/port/gtk.py:
3701         (GtkPort.default_baseline_search_path): Ignore device type.
3702         * Scripts/webkitpy/port/ios.py:
3703         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3704         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3705         * Scripts/webkitpy/port/ios_device_unittest.py:
3706         (IOSDeviceTest):
3707         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3708         (IOSSimulatorTest):
3709         * Scripts/webkitpy/port/mac.py:
3710         (MacPort.default_baseline_search_path): Ignore device type.
3711         * Scripts/webkitpy/port/watch.py:
3712         (WatchPort.default_baseline_search_path): Ditto.
3713         * Scripts/webkitpy/port/win.py:
3714         (WinPort.default_baseline_search_path): Ditto.
3715         (WinCairoPort.default_baseline_search_path): Ditto.
3716         * Scripts/webkitpy/port/wpe.py:
3717         (WPEPort.default_baseline_search_path): Ditto.
3718
3719 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3720
3721         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3722         https://bugs.webkit.org/show_bug.cgi?id=193352
3723         <rdar://problem/47210736>
3724
3725         Reviewed by Lucas Forschler.
3726
3727         * Scripts/webkitpy/layout_tests/views/printing.py:
3728         (Printer.print_config): Print list on only baseline search paths which exist. 
3729         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3730         (Testprinter.test_print_config):
3731
3732 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3733
3734         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3735         https://bugs.webkit.org/show_bug.cgi?id=193340
3736
3737         Reviewed by David Kilzer.
3738
3739         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3740         (WTR::InjectedBundle::didReceiveMessageToPage):
3741         Pull the strings out into a WKRetainPtr.
3742
3743         * WebKitTestRunner/WebNotificationProvider.cpp:
3744         (WTR::WebNotificationProvider::closeWebNotification):
3745         Adopt the created value into the WKRetainPtr.
3746
3747         * WebKitTestRunner/mac/TestControllerMac.mm:
3748         (WTR::generateWhitelist):
3749         Immediately adopt a created value to avoid potential mistakes.
3750
3751 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3752
3753         Enable DFG on ARM/Linux again
3754         https://bugs.webkit.org/show_bug.cgi?id=192496
3755
3756         Reviewed by Yusuke Suzuki.
3757
3758         After changing the bytecode format DFG was disabled on all 32-bit
3759         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3760         on ARM by default.
3761
3762         * Scripts/run-jsc-stress-tests:
3763
3764 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3765
3766         Unreviewed, fix #ifdef in API test added in r239851.
3767         https://bugs.webkit.org/show_bug.cgi?id=193327
3768         rdar://problem/47093222
3769
3770         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3771
3772 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3773
3774         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3775         https://bugs.webkit.org/show_bug.cgi?id=193109
3776         <rdar://problem/44807048>
3777
3778         Reviewed by Ryosuke Niwa.
3779
3780         Introduce and respect a test option to enable the UndoManager API.
3781
3782         * WebKitTestRunner/TestController.cpp:
3783         (WTR::updateTestOptionsFromTestHeader):
3784         * WebKitTestRunner/TestOptions.h:
3785         (WTR::TestOptions::hasSameInitializationOptions const):
3786         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3787         (WTR::TestController::platformCreateWebView):
3788
3789 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3790
3791         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3792         https://bugs.webkit.org/show_bug.cgi?id=193346
3793
3794         Reviewed by Antti Koivisto.
3795
3796         * LayoutReloaded/misc/LFC-passing-tests.txt:
3797
3798 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3799
3800         Unreviewed, fix typo that breaks dashboard link.
3801
3802         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3803         (WebKitBuildbot):
3804
3805 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3806
3807         Update macOS queue configurations
3808         https://bugs.webkit.org/show_bug.cgi?id=193329
3809
3810         Reviewed by Alexey Proskuryakov.
3811
3812         * BuildSlaveSupport/build.webkit.org-config/config.json:
3813         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3814         (BubbleQueueServer):
3815         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3817         (WebKitBuildbot):
3818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3819         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3820         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3821
3822 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3823
3824         MiniBrowser should be able to navigate to about:blank
3825         https://bugs.webkit.org/show_bug.cgi?id=193345
3826
3827         Reviewed by Simon Fraser.
3828
3829         * MiniBrowser/mac/BrowserWindowController.m:
3830         (-[BrowserWindowController addProtocolIfNecessary:]):
3831         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3832
3833         * MiniBrowser/mac/WK1BrowserWindowController.m:
3834         (-[WK1BrowserWindowController fetch:]):
3835         * MiniBrowser/mac/WK2BrowserWindowController.m:
3836         (-[WK2BrowserWindowController fetch:]):
3837         Clean up the code that uses this to match style.
3838
3839 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3840
3841         Remove MiniBrowser custom "Process Swap" menu item which does not work
3842         https://bugs.webkit.org/show_bug.cgi?id=193344
3843
3844         Reviewed by Simon Fraser.
3845
3846         There is a menu item under the Experimental menu that does work.
3847
3848         * MiniBrowser/mac/AppDelegate.m:
3849         (defaultConfiguration):
3850         * MiniBrowser/mac/SettingsController.h:
3851         * MiniBrowser/mac/SettingsController.m:
3852         (-[SettingsController _populateMenu]):
3853         (-[SettingsController validateMenuItem:]):
3854         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3855         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3856
3857 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3858
3859         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3860         https://bugs.webkit.org/show_bug.cgi?id=193327
3861         rdar://problem/47093222
3862
3863         Reviewed by Tim Horton.
3864
3865         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3866         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3867         (TestWebKitAPI::didFinishNavigation):
3868         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3869         (TestWebKitAPI::TEST):
3870         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3871         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3872         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3873         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3874         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3875
3876 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3877
3878         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3879         https://bugs.webkit.org/show_bug.cgi?id=193338
3880         <rdar://problem/46664774>
3881
3882         Reviewed by David Kilzer.
3883
3884         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3885         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3886
3887 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3888
3889         Unreviewed, rolling out r239825.
3890         https://bugs.webkit.org/show_bug.cgi?id=193330
3891
3892         Broke tests on armv7/linux bots (Requested by guijemont on
3893         #webkit).
3894
3895         Reverted changeset:
3896
3897         "Enable DFG on ARM/Linux again"
3898         https://bugs.webkit.org/show_bug.cgi?id=192496
3899         https://trac.webkit.org/changeset/239825
3900
3901 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3902
3903         Disable the run-jsc-stress-test remote host key check.
3904         https://bugs.webkit.org/show_bug.cgi?id=192988
3905
3906         Reviewed by Alexey Proskuryakov.
3907
3908         * Scripts/run-jsc-stress-tests:
3909
3910 2019-01-10  John Wilander  <wilander@apple.com>
3911
3912         Override the session configuration for cookieAcceptPolicy
3913         https://bugs.webkit.org/show_bug.cgi?id=190925
3914         <rdar://problem/45497382>
3915
3916         Reviewed by Alexey Proskuryakov and Alex Christensen.
3917
3918         Test infrastructure for setting a first-party-only cookie policy.
3919
3920         * DumpRenderTree/TestRunner.cpp:
3921         (setOnlyAcceptFirstPartyCookiesCallback):
3922         (TestRunner::staticFunctions):
3923         * DumpRenderTree/TestRunner.h:
3924         * DumpRenderTree/mac/TestRunnerMac.mm:
3925         (TestRunner::setOnlyAcceptFirstPartyCookies):
3926         * DumpRenderTree/win/TestRunnerWin.cpp:
3927         (TestRunner::setOnlyAcceptFirstPartyCookies):
3928         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3929         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3930         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3931         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3932         * WebKitTestRunner/TestInvocation.cpp:
3933         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3934
3935 2019-01-09  Matt Rajca  <mrajca@apple.com>
3936
3937         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3938         https://bugs.webkit.org/show_bug.cgi?id=193301
3939
3940         Reviewed by Jer Noble.
3941         
3942         Added API tests.
3943
3944         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3945         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3946         (TEST):
3947         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3948
3949 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3950
3951         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3952         https://bugs.webkit.org/show_bug.cgi?id=193310
3953
3954         Reviewed by Antti Koivisto.
3955
3956         * LayoutReloaded/misc/LFC-passing-tests.txt:
3957
3958 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3959
3960         Enable DFG on ARM/Linux again
3961         https://bugs.webkit.org/show_bug.cgi?id=192496
3962
3963         Reviewed by Yusuke Suzuki.
3964
3965         After changing the bytecode format DFG was disabled on all 32-bit
3966         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3967         on ARM by default.
3968
3969         * Scripts/run-jsc-stress-tests:
3970
3971 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3972
3973         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3974         https://bugs.webkit.org/show_bug.cgi?id=193271
3975
3976         Reviewed by Brent Fulgham.
3977
3978         BSTR is a special data structure created by SysAllocString, not a
3979         wchar_t null-terminated string.
3980
3981         * DumpRenderTree/win/TestRunnerWin.cpp:
3982         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3983         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3984         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3985         BSTR from wide string literals.
3986
3987 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3988
3989         Tweak wording for build/version_check style checker error
3990         https://bugs.webkit.org/show_bug.cgi?id=193256
3991
3992         Reviewed by Tim Horton.
3993
3994         * Scripts/webkitpy/style/checkers/cpp.py:
3995         (check_os_version_checks):
3996         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3997         (WebKitStyleTest.test_os_version_checks):
3998
3999 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4000
4001         [ews-build] Add link to bug along with bug title
4002         https://bugs.webkit.org/show_bug.cgi?id=193293
4003
4004         Reviewed by Lucas Forschler.
4005
4006         * BuildSlaveSupport/ews-build/steps.py:
4007         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
4008         (ConfigureBuild.add_bug_id_url): Deleted.
4009         (ConfigureBuild.getBugURL): Deleted.
4010
4011 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4012
4013         [ews-build] Use https for ews-build server
4014         https://bugs.webkit.org/show_bug.cgi?id=193193
4015
4016         Reviewed by Lucas Forschler.
4017
4018         * BuildSlaveSupport/ews-build/steps.py:
4019
4020 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4021
4022         [ews-build] Parse and display number of style failures
4023         https://bugs.webkit.org/show_bug.cgi?id=193280
4024
4025         Reviewed by Lucas Forschler.
4026
4027         * BuildSlaveSupport/ews-build/steps.py:
4028         (CheckStyle): Use TestWithFailureCount as base class.
4029         (CheckStyle.countFailures): Count the number of style failures.
4030
4031 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
4032
4033         [ews-build] use patch_id instead of ewspatchid
4034         https://bugs.webkit.org/show_bug.cgi?id=193235
4035
4036         Reviewed by Lucas Forschler.
4037
4038         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
4039         * BuildSlaveSupport/ews-build/steps.py: Ditto.
4040         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
4041
4042 2019-01-09  Zalan Bujtas  <zalan@apple.com>
4043
4044         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
4045         https://bugs.webkit.org/show_bug.cgi?id=192625
4046
4047         Reviewed by Antti Koivisto.
4048
4049         * LayoutReloaded/misc/LFC-passing-tests.txt:
4050
4051 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
4052
4053         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
4054         https://bugs.webkit.org/show_bug.cgi?id=192841
4055
4056         Reviewed by Carlos Garcia Campos.
4057
4058         There are separate g_assert_*() macros for use in tests, which we use inconsistently
4059         currently. Use them always. We'll get nicer error messages now when tests fail, and the
4060         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
4061
4062         Note that the documentation of g_assert() says that it is not to be used when writing tests.
4063
4064         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4065         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
4066         (WebKitWebEditorTest::testSelectionChanged):
4067         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
4068         (WebKitFrameTest::testMainFrame):
4069         (WebKitFrameTest::testURI):
4070         (WebKitFrameTest::testJavaScriptContext):
4071         (WebKitFrameTest::testJavaScriptValues):
4072         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
4073         (testWebViewAuthenticationRequest):
4074         (testWebViewAuthenticationLoadCancelled):
4075         (testWebViewAuthenticationFailure):
4076         (testWebViewAuthenticationStorage):
4077         (ProxyAuthenticationTest::ProxyAuthenticationTest):
4078         (testWebViewAuthenticationProxy):
4079         (testWebViewAuthenticationProxyHTTPS):
4080         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4081         (testAutomationSessionRequestSession):
4082         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
4083         (testBackForwardListNavigation):
4084         (testWebKitWebViewSessionState):
4085         (testWebKitWebViewSessionStateWithFormData):
4086         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
4087         (ConsoleMessageTest::consoleMessageReceivedCallback):
4088         (testWebKitConsoleMessageConsoleAPI):
4089         (testWebKitConsoleMessageJavaScriptException):
4090         (testWebKitConsoleMessageNetworkError):
4091         (testWebKitConsoleMessageSecurityError):
4092         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4093         (testCookieManagerAcceptPolicy):
4094         (testCookieManagerCookiesChanged):
4095         (testCookieManagerPersistentStorage):
4096         (testCookieManagerPersistentStorageDeleteAll):
4097         (testCookieManagerEphemeral):
4098         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
4099         (testWebKitDOMElementAutoFill):
4100         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
4101         (downloadLocalFileSuccessfully):
4102         (createFileAtDestination):
4103         (testDownloadOverwriteDestinationDisallowed):
4104         (testDownloadLocalFileError):
4105         (testDownloadRemoteFile):
4106         (testDownloadRemoteFileError):
4107         (testWebViewDownloadURI):
4108         (testPolicyResponseDownload):
4109         (testPolicyResponseDownloadCancel):
4110         (testDownloadMIMEType):
4111         (contextMenuCallback):
4112         (testContextMenuDownloadActions):
4113         (testBlobDownload):
4114         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
4115         (testWebKitWebEditorSelectionChanged):
4116         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
4117         (testWebKitFrameMainFrame):
4118         (testWebKitFrameURI):
4119         (testWebKitFrameJavaScriptContext):
4120         (testWebKitFrameJavaScriptValues):
4121         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4122         (LoadStopTrackingTest::loadFailed):
4123         (testWebViewTitle):
4124         (testURIRequestHTTPHeaders):
4125         (testURIRequestHTTPMethod):
4126         (testURIResponseHTTPHeaders):
4127         (testRedirectToDataURI):
4128         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
4129         (testProcessPerWebView):
4130         (testWebProcessLimit):
4131         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
4132         (testWebViewResources):
4133         (testWebResourceLoading):
4134         (testWebResourceSuggestedFilename):
4135         (testWebResourceGetData):
4136         (testWebResourceGetDataError):
4137         (testWebViewResourcesHistoryCache):
4138         (testWebResourceSendRequest):
4139         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
4140         (testSSL):
4141         (testInsecureContent):
4142         (testTLSErrorsPolicy):
4143         (testTLSErrorsRedirect):
4144         (testTLSErrorsHTTPAuth):
4145         (testLoadFailedWithTLSErrors):
4146         (testSubresourceLoadFailedWithTLSErrors):
4147         (httpsServerCallback):
4148         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
4149         (testWebViewCreateNavigationData):
4150         (testWebViewJavaScriptDialogs):
4151         (testWebViewWindowProperties):
4152         (testWebViewMouseTarget):
4153         (testWebViewFileChooserRequest):
4154         (testWebViewColorChooserRequest):
4155         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
4156         (testWebExtensionGetTitle):
4157         (testDocumentLoadedSignal):
4158         (testWebKitWebViewProcessCrashed):
4159         (testWebExtensionWindowObjectCleared):
4160         (testWebExtensionIsolatedWorld):
4161         (permissionRequestCallback):
4162         (didAssociateFormControlsCallback):
4163         (testWebExtensionFormControlsAssociated):
4164         (FormSubmissionTest::FormSubmissionTest):
4165         (FormSubmissionTest::testFormSubmissionResult):
4166         (testWebExtensionFormSubmissionSteps):
4167         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
4168         (testNotInitialized):
4169         (testClearDatabase):
4170         (testPrivateBrowsing):
4171         (testGetFavicon):
4172         (testWebViewFavicon):
4173         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
4174         (testFindControllerTextFound):
4175         (testFindControllerTextNotFound):
4176         (testFindControllerMatchCount):
4177         (testFindControllerMaxMatchCount):
4178         (testFindControllerNext):
4179         (testFindControllerPrevious):
4180         (testFindControllerCountedMatches):
4181         (testFindControllerOptions):
4182         (testFindControllerHide):
4183         (testFindControllerInstance):
4184         (testFindControllerGetters):
4185         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
4186         (testNavigationPolicy):
4187         (testResponsePolicy):
4188         (testNewWindowPolicy):
4189         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
4190         (testSecurityOriginBasicConstructor):
4191         (testSecurityOriginURIConstructor):
4192         (testSecurityOriginDefaultPort):
4193         (testSecurityOriginFileURI):
4194         (testOpaqueSecurityOrigin):
4195         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
4196         (testWebKitSettings):
4197         (testWebKitSettingsNewWithSettings):
4198         (testWebKitSettingsUserAgent):
4199         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4200         (testWebViewNewWithUserContentManager):
4201         (isStyleSheetInjectedForURLAtPath):
4202         (isScriptInjectedForURLAtPath):
4203         (testUserContentManagerInjectedStyleSheet):
4204         (testUserContentManagerInjectedScript):
4205         (UserScriptMessageTest::scriptMessageReceived):
4206         (UserScriptMessageTest::waitUntilMessageReceived):
4207         (UserScriptMessageTest::runJavaScriptFinished):
4208         (testUserContentManagerScriptMessageReceived):
4209         (testUserContentManagerScriptMessageInWorldReceived):
4210         (testUserContentManagerScriptMessageFromDOMBindings):
4211         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
4212         (testWebContextDefault):
4213         (testWebContextEphemeral):
4214         (testWebContextGetPlugins):
4215         (testWebContextURIScheme):
4216         (testWebContextSpellChecker):
4217         (testWebContextLanguages):
4218         (consoleMessageReceivedCallback):
4219         (testWebContextSecurityFileXHR):
4220         (ProxyTest::ProxyTest):
4221         (testWebContextProxySettings):
4222         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4223         (testWebViewWebContext):
4224         (testWebViewWebBackend):
4225         (testWebViewEphemeral):
4226         (testWebViewCustomCharset):
4227         (testWebViewSettings):
4228         (testWebViewRunJavaScript):
4229         (testWebViewCanShowMIMEType):
4230         (testWebViewSubmitForm):
4231         (testWebViewSave):
4232         (testWebViewPageVisibility):
4233         (testWebViewSnapshot):
4234         (testWebViewNotification):
4235         (testWebViewNotificationInitialPermissionAllowed):
4236         (testWebViewNotificationInitialPermissionDisallowed):
4237         (testWebViewIsPlayingAudio):
4238         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
4239         (WebsiteDataTest::WebsiteDataTest):
4240         (WebsiteDataTest::remove):
4241         (WebsiteDataTest::clear):
4242         (testWebsiteDataConfiguration):
4243         (testWebsiteDataEphemeral):
4244         (testWebsiteDataCache):
4245         (testWebsiteDataStorage):
4246         (testWebsiteDataDatabases):
4247         (testWebsiteDataAppcache):
4248         (testWebsiteDataCookies):
4249         (testWebsiteDataDeviceIdHashSalt):
4250         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
4251         (emitDocumentLoaded):
4252         (emitURIChanged):
4253         (sendRequestCallback):
4254         (contextMenuCallback):
4255         (consoleMessageSentCallback):
4256         (emitFormControlsAssociated):
4257         (formControlsAssociatedCallback):
4258         (emitFormSubmissionEvent):
4259         (willSubmitFormCallback):
4260         (windowObjectCleared):
4261         (methodCallCallback):
4262         (registerGResource):
4263         (webkit_web_extension_initialize_with_user_data):
4264         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
4265         (checkLeaks):
4266         (WebProcessTest::create):
4267         (runTest):
4268         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
4269         (AutocleanupsTest::testWebProcessAutocleanups):
4270         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
4271         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
4272         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
4273         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
4274         (WebKitDOMDOMWindowTest::testSignals):
4275         (WebKitDOMDOMWindowTest::testDispatchEvent):
4276         (WebKitDOMDOMWindowTest::testGetComputedStyle):
4277         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
4278         (WebKitDOMNodeFilterTest::testTreeWalker):
4279         (WebKitDOMNodeFilterTest::testNodeIterator):
4280         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
4281         (WebKitDOMNodeTest::testHierarchyNavigation):
4282         (WebKitDOMNodeTest::testInsertion):
4283         (WebKitDOMNodeTest::testTagNamesNodeList):
4284         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
4285         (WebKitDOMNodeTest::testDOMCache):
4286         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
4287         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
4288         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
4289         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
4290         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
4291         (testUIProcessAutocleanups):
4292         (testWebProcessAutocleanups):
4293         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
4294         (testContextMenuPopulateMenu):
4295         (testContextMenuDismissed):
4296         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
4297         (testWebKitDOMClientRectDivBoundingClientRectPosition):
4298         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
4299         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
4300         (testWebKitDOMDOMWindowSignals):
4301         (testWebKitDOMDOMWindowDispatchEvent):
4302         (testWebKitDOMDOMWindowGetComputedStyle):
4303         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
4304         (testWebKitDOMNodeHierarchyNavigation):
4305         (testWebKitDOMNodeInsertion):
4306         (testWebKitDOMNodeTagNamesNodeList):
4307         (testWebKitDOMNodeTagNamesHTMLCollection):
4308         (testWebKitDOMObjectCache):
4309         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
4310         (testWebKitDOMNodeFilterTreeWalker):
4311         (testWebKitDOMNodeFilterNodeIterator):
4312         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
4313         (testWebKitDOMXPathNSResolverNative):
4314         (testWebKitDOMXPathNSResolverCustom):
4315         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
4316         (testInspectorDefault):
4317         (testInspectorManualAttachDetach):
4318         (testInspectorCustomContainerDestroyed):
4319         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
4320         (startTestServer):
4321         (testInspectorServerPageList):
4322         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
4323         (OptionMenuTest::showOptionMenuCallback):
4324         (OptionMenuTest::menuCloseCallback):
4325         (OptionMenuTest::close):
4326         (OptionMenuTest::activateItem):
4327         (OptionMenuTest::selectItem):
4328         (testOptionMenuSimple):
4329         (testOptionMenuGroups):
4330         (testOptionMenuActivate):
4331         (testOptionMenuSelect):
4332         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
4333         (testPrintOperationPrintSettings):
4334         (webViewPrintCallback):