REGRESSION (r241988): Switching tabs is slow
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-17  Tim Horton  <timothy_horton@apple.com>
2
3         REGRESSION (r241988): Switching tabs is slow
4         https://bugs.webkit.org/show_bug.cgi?id=197037
5         <rdar://problem/49951473>
6
7         Reviewed by Simon Fraser.
8
9         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
10         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
11         (TEST):
12         * TestWebKitAPI/cocoa/TestWKWebView.h:
13         * TestWebKitAPI/cocoa/TestWKWebView.mm:
14         (-[TestWKWebView addToTestWindow]):
15         Add a test that hangs without this fix.
16
17 2019-04-17  Truitt Savell  <tsavell@apple.com>
18
19         Unreviewed, rolling out r244400.
20
21         Caused testing to exit early with assertionon Debug WK2
22
23         Reverted changeset:
24
25         "UI↔Web deadlock when printing with a JavaScript alert
26         visible"
27         https://bugs.webkit.org/show_bug.cgi?id=196839
28         https://trac.webkit.org/changeset/244400
29
30 2019-04-17  Brady Eidson  <beidson@apple.com>
31
32         Link clicks in PDFs shouldn't send referrer headers.
33         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
34
35         Reviewed by Tim Horton.
36
37         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
38         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
39         (putPDFBytesCallback):
40         (emptyReleaseInfoCallback):
41         (createPDFWithLinkToURL):
42         (TEST):
43
44 2019-04-17  Tim Horton  <timothy_horton@apple.com>
45
46         UI↔Web deadlock when printing with a JavaScript alert visible
47         https://bugs.webkit.org/show_bug.cgi?id=196839
48         <rdar://problem/49157642>
49
50         Reviewed by Andy Estes.
51
52         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
53         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
54         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
55         (TEST):
56
57 2019-04-17  Alex Christensen  <achristensen@webkit.org>
58
59         WKRetainPtr's adoption constructor should be private
60         https://bugs.webkit.org/show_bug.cgi?id=197019
61
62         Reviewed by Tim Horton.
63
64         * DumpRenderTree/mac/DumpRenderTree.mm:
65         (dumpFramesAsText):
66         * TestWebKitAPI/InjectedBundleController.cpp:
67         (TestWebKitAPI::InjectedBundleController::initialize):
68         * TestWebKitAPI/PlatformUtilities.cpp:
69         (TestWebKitAPI::Util::createContextWithInjectedBundle):
70         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
71         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
72         (TestWebKitAPI::Util::toWK):
73         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
74         (TestWebKitAPI::TEST):
75         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
76         (TestWebKitAPI::TEST):
77         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
78         (TestWebKitAPI::TEST):
79         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
80         (TestWebKitAPI::TEST):
81         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
82         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
83         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
84         (TestWebKitAPI::TEST):
85         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
86         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
87         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
88         (TestWebKitAPI::TEST):
89         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
90         (TestWebKitAPI::TEST):
91         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
92         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
93         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
94         (TestWebKitAPI::TEST):
95         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
96         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
97         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
98         (TestWebKitAPI::TEST):
99         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
100         (TestWebKitAPI::TEST):
101         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
102         (TestWebKitAPI::TEST):
103         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
104         (TestWebKitAPI::TEST):
105         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
106         (TestWebKitAPI::TEST):
107         * TestWebKitAPI/Tests/WebKit/Find.cpp:
108         (TestWebKitAPI::TEST):
109         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
110         (TestWebKitAPI::TEST):
111         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
112         (TestWebKitAPI::TEST):
113         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
114         (TestWebKitAPI::TEST):
115         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
116         (TestWebKitAPI::TEST):
117         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
118         (TestWebKitAPI::TEST):
119         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
120         (TestWebKitAPI::TEST):
121         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
122         (TestWebKitAPI::TEST):
123         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
124         (TestWebKitAPI::TEST):
125         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
126         (TestWebKitAPI::TEST):
127         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
128         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
129         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
130         (TestWebKitAPI::TEST):
131         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
132         (TestWebKitAPI::TEST):
133         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
134         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
135         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
136         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
137         (TestWebKitAPI::TEST):
138         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
139         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
140         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
141         (TestWebKitAPI::TEST):
142         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
143         (TestWebKitAPI::TEST):
144         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
145         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
146         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
147         (TestWebKitAPI::TEST):
148         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
149         (TestWebKitAPI::loadAlternateHTMLString):
150         (TestWebKitAPI::TEST):
151         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
152         (TestWebKitAPI::TEST):
153         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
154         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
155         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
156         (TestWebKitAPI::buildAndPerformTest):
157         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
158         (TestWebKitAPI::TEST):
159         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
160         (TestWebKitAPI::TEST):
161         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
162         (TestWebKitAPI::TEST):
163         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
164         (TestWebKitAPI::TEST):
165         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
166         (TestWebKitAPI::TEST):
167         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
168         (TestWebKitAPI::TEST):
169         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
170         (TestWebKitAPI::TEST):
171         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
172         (TestWebKitAPI::TEST):
173         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
174         (TestWebKitAPI::TEST):
175         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
176         (TestWebKitAPI::TEST):
177         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
178         (TestWebKitAPI::TEST):
179         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
180         (TestWebKitAPI::TEST):
181         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
182         (TestWebKitAPI::TEST):
183         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
184         (TestWebKitAPI::TEST):
185         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
186         (TestWebKitAPI::TEST):
187         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
188         (TestWebKitAPI::TEST):
189         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
190         (TestWebKitAPI::TEST):
191         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
192         (TestWebKitAPI::TEST):
193         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
194         (TestWebKitAPI::TEST):
195         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
196         (TestWebKitAPI::TEST):
197         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
198         (TestWebKitAPI::TEST):
199         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
200         (TestWebKitAPI::TEST):
201         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
202         (TestWebKitAPI::TEST):
203         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
204         (TestWebKitAPI::TEST):
205         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
206         (TestWebKitAPI::TEST):
207         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
208         (TestWebKitAPI::TEST):
209         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
210         (TestWebKitAPI::TEST):
211         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
212         (TestWebKitAPI::TEST):
213         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
214         (TestWebKitAPI::TEST):
215         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
216         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
217         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
218         (TestWebKitAPI::TEST):
219         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
220         (TestWebKitAPI::TEST):
221         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
222         (TestWebKitAPI::TEST):
223         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
224         (TestWebKitAPI::TEST):
225         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
226         (TestWebKitAPI::TEST):
227         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
228         (TestWebKitAPI::TEST):
229         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
230         (TestWebKitAPI::TEST):
231         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
232         (TestWebKitAPI::TEST):
233         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
234         (TestWebKitAPI::TEST):
235         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
236         (TestWebKitAPI::TEST):
237         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
238         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
239         (TEST):
240         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
241         (TEST):
242         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
243         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
244         (TEST):
245         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
246         (TestWebKitAPI::TEST):
247         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
248         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
249         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
250         (WTR::getMenuItemTitleCallback):
251         (WTR::createMouseMessageBody):
252         (WTR::EventSendingController::mouseDown):
253         (WTR::EventSendingController::mouseUp):
254         (WTR::EventSendingController::mouseMoveTo):
255         (WTR::EventSendingController::mouseForceClick):
256         (WTR::EventSendingController::startAndCancelMouseForceClick):
257         (WTR::EventSendingController::mouseForceDown):
258         (WTR::EventSendingController::mouseForceUp):
259         (WTR::EventSendingController::mouseForceChanged):
260         (WTR::EventSendingController::leapForward):
261         (WTR::EventSendingController::scheduleAsynchronousClick):
262         (WTR::createKeyDownMessageBody):
263         (WTR::EventSendingController::keyDown):
264         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
265         (WTR::EventSendingController::mouseScrollBy):
266         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
267         (WTR::EventSendingController::continuousMouseScrollBy):
268         (WTR::EventSendingController::addTouchPoint):
269         (WTR::EventSendingController::updateTouchPoint):
270         (WTR::EventSendingController::setTouchModifier):
271         (WTR::EventSendingController::setTouchPointRadius):
272         (WTR::EventSendingController::touchStart):
273         (WTR::EventSendingController::touchMove):
274         (WTR::EventSendingController::touchEnd):
275         (WTR::EventSendingController::touchCancel):
276         (WTR::EventSendingController::clearTouchPoints):
277         (WTR::EventSendingController::releaseTouchPoint):
278         (WTR::EventSendingController::cancelTouchPoint):
279         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
280         (WTR::InjectedBundle::didCreatePage):
281         (WTR::InjectedBundle::didReceiveMessage):
282         (WTR::InjectedBundle::didReceiveMessageToPage):
283         (WTR::InjectedBundle::booleanForKey):
284         (WTR::InjectedBundle::done):
285         (WTR::InjectedBundle::dumpToStdErr):
286         (WTR::InjectedBundle::outputText):
287         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
288         (WTR::InjectedBundle::postAddChromeInputField):
289         (WTR::InjectedBundle::postRemoveChromeInputField):
290         (WTR::InjectedBundle::postFocusWebView):
291         (WTR::InjectedBundle::postSetBackingScaleFactor):
292         (WTR::InjectedBundle::postSetWindowIsKey):
293         (WTR::InjectedBundle::postSetViewSize):
294         (WTR::InjectedBundle::postSimulateWebNotificationClick):
295         (WTR::InjectedBundle::postSetAddsVisitedLinks):
296         (WTR::InjectedBundle::setGeolocationPermission):
297         (WTR::InjectedBundle::setMockGeolocationPosition):
298         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
299         (WTR::InjectedBundle::isGeolocationProviderActive const):
300         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
301         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
302         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
303         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
304         (WTR::InjectedBundle::setCustomPolicyDelegate):
305         (WTR::InjectedBundle::setHidden):
306         (WTR::InjectedBundle::setCacheModel):
307         (WTR::InjectedBundle::shouldProcessWorkQueue const):
308         (WTR::InjectedBundle::processWorkQueue):
309         (WTR::InjectedBundle::queueBackNavigation):
310         (WTR::InjectedBundle::queueForwardNavigation):
311         (WTR::InjectedBundle::queueLoad):
312         (WTR::InjectedBundle::queueLoadHTMLString):
313         (WTR::InjectedBundle::queueReload):
314         (WTR::InjectedBundle::queueLoadingScript):
315         (WTR::InjectedBundle::queueNonLoadingScript):
316         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
317         (WTR::frameToStr):
318         (WTR::InjectedBundlePage::InjectedBundlePage):
319         (WTR::dumpFrameDescriptionSuitableForTestResult):
320         (WTR::dumpFrameScrollPosition):
321         (WTR::dumpDescendantFrameScrollPositions):
322         (WTR::dumpFrameText):
323         (WTR::dumpDescendantFramesText):
324         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
325         (WTR::TestRunner::shouldDumpPixels const):
326         (WTR::TestRunner::setDumpPixels):
327         (WTR::TestRunner::whatToDump const):
328         (WTR::TestRunner::setWhatToDump):
329         (WTR::TestRunner::setWaitUntilDone):
330         (WTR::TestRunner::shouldWaitUntilDone const):
331         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
332         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
333         (WTR::TestRunner::clearAllDatabases):
334         (WTR::TestRunner::setIDBPerOriginQuota):
335         (WTR::TestRunner::originsWithApplicationCache):
336         (WTR::TestRunner::setCanOpenWindows):
337         (WTR::TestRunner::setXSSAuditorEnabled):
338         (WTR::TestRunner::setMediaDevicesEnabled):
339         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
340         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
341         (WTR::TestRunner::setCustomUserAgent):
342         (WTR::TestRunner::setWebAPIStatisticsEnabled):
343         (WTR::TestRunner::setModernMediaControlsEnabled):
344         (WTR::TestRunner::setWebGL2Enabled):
345         (WTR::TestRunner::setWritableStreamAPIEnabled):
346         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
347         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
348         (WTR::TestRunner::setAllowsAnySSLCertificate):
349         (WTR::TestRunner::setPluginsEnabled):
350         (WTR::TestRunner::setValueForUser):
351         (WTR::TestRunner::setAudioResult):
352         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
353         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
354         (WTR::TestRunner::setAlwaysAcceptCookies):
355         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
356         (WTR::TestRunner::isDoingMediaCapture const):
357         (WTR::TestRunner::queueLoad):
358         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
359         (WTR::TestRunner::setHandlesAuthenticationChallenges):
360         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
361         (WTR::TestRunner::setShouldLogDownloadCallbacks):
362         (WTR::TestRunner::setAuthenticationUsername):
363         (WTR::TestRunner::setAuthenticationPassword):
364         (WTR::TestRunner::secureEventInputIsEnabled const):
365         (WTR::TestRunner::setBlockAllPlugins):
366         (WTR::TestRunner::setPluginSupportedMode):
367         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
368         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
369         (WTR::TestRunner::setNavigationGesturesEnabled):
370         (WTR::TestRunner::setIgnoresViewportScaleLimits):
371         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
372         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
373         (WTR::TestRunner::terminateNetworkProcess):
374         (WTR::TestRunner::terminateServiceWorkerProcess):
375         (WTR::TestRunner::runUIScript):
376         (WTR::TestRunner::setStatisticsDebugMode):
377         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
378         (WTR::TestRunner::setStatisticsLastSeen):
379         (WTR::TestRunner::setStatisticsPrevalentResource):
380         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
381         (WTR::TestRunner::dumpResourceLoadStatistics):
382         (WTR::TestRunner::isStatisticsPrevalentResource):
383         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
384         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
385         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
386         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
387         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
388         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
389         (WTR::TestRunner::setStatisticsGrandfathered):
390         (WTR::TestRunner::isStatisticsGrandfathered):
391         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
392         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
393         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
394         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
395         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
396         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
397         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
398         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
399         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
400         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
401         (WTR::TestRunner::statisticsUpdateCookieBlocking):
402         (WTR::TestRunner::statisticsSubmitTelemetry):
403         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
404         (WTR::TestRunner::setStatisticsIsRunningTest):
405         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
406         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
407         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
408         (WTR::TestRunner::setStatisticsGrandfatheringTime):
409         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
410         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
411         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
412         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
413         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
414         (WTR::TestRunner::statisticsDeleteCookiesForHost):
415         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
416         (WTR::TestRunner::statisticsResetToConsistentState):
417         (WTR::TestRunner::setStorageAccessAPIEnabled):
418         (WTR::TestRunner::getAllStorageAccessEntries):
419         (WTR::TestRunner::addMockMediaDevice):
420         (WTR::TestRunner::clearMockMediaDevices):
421         (WTR::TestRunner::removeMockMediaDevice):
422         (WTR::TestRunner::resetMockMediaDevices):
423         (WTR::TestRunner::connectMockGamepad):
424         (WTR::TestRunner::disconnectMockGamepad):
425         (WTR::TestRunner::setMockGamepadDetails):
426         (WTR::TestRunner::setMockGamepadAxisValue):
427         (WTR::TestRunner::setMockGamepadButtonValue):
428         (WTR::TestRunner::removeAllSessionCredentials):
429         (WTR::TestRunner::clearDOMCache):
430         (WTR::TestRunner::clearDOMCaches):
431         (WTR::TestRunner::hasDOMCache):
432         (WTR::TestRunner::domCacheSize):
433         (WTR::TestRunner::setAllowStorageQuotaIncrease):
434         (WTR::TestRunner::getApplicationManifestThen):
435         (WTR::TestRunner::injectUserScript):
436         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
437         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
438         (WTR::TestRunner::addTestKeyToKeychain):
439         (WTR::TestRunner::cleanUpKeychain):
440         (WTR::TestRunner::keyExistsInKeychain):
441         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
442         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
443         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
444         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
445         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
446         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
447         * WebKitTestRunner/TestController.cpp:
448         (WTR::TestController::initialize):
449         (WTR::parseStringTestHeaderValueAsRelativePath):
450         (WTR::updateTestOptionsFromTestHeader):
451         (WTR::TestController::runTest):
452         (WTR::TestController::didReceiveLiveDocumentsList):
453         (WTR::TestController::didReceiveMessageFromInjectedBundle):
454         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
455         (WTR::TestController::didFinishNavigation):
456         (WTR::TestController::didReceiveAuthenticationChallenge):
457         * WebKitTestRunner/TestInvocation.cpp:
458         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
459         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
460         (WTR::TestInvocation::uiScriptDidComplete):
461         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
462         * WebKitTestRunner/WebNotificationProvider.cpp:
463         (WTR::WebNotificationProvider::closeWebNotification):
464         * WebKitTestRunner/WorkQueueManager.cpp:
465         (WTR::ScriptItem::ScriptItem):
466         (WTR::WorkQueueManager::queueLoad):
467         (WTR::WorkQueueManager::queueLoadHTMLString):
468
469 2019-04-17  Alex Christensen  <achristensen@webkit.org>
470
471         Add a comment to make my test from r244139 less mysterious.
472         https://bugs.webkit.org/show_bug.cgi?id=196744
473
474         As suggested by Darin Adler.
475
476         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
477         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
478
479 2019-04-17  Chris Dumez  <cdumez@apple.com>
480
481         Remember device orientation permission for the duration of the browsing session
482         https://bugs.webkit.org/show_bug.cgi?id=196992
483         <rdar://problem/49946067>
484
485         Reviewed by Alex Christensen.
486
487         Add API test coverage.
488
489         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
490         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
491         (TEST):
492
493 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
494
495         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
496         https://bugs.webkit.org/show_bug.cgi?id=196675
497
498         Reviewed by Lucas Forschler.
499
500         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
501         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
502
503 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
504
505         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
506         https://bugs.webkit.org/show_bug.cgi?id=196919
507         <rdar://problem/41630459>
508
509         Reviewed by Tim Horton.
510
511         Add iOS support for several new testing hooks. See below for more detail.
512
513         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
514         (WTR::UIScriptController::isDismissingMenu const):
515
516         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
517         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
518         by UIKit when dismissing the callout bar (i.e. UIMenuController).
519
520         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
521         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
522         (WTR::UIScriptController::isDismissingMenu const):
523         * TestRunnerShared/UIScriptContext/UIScriptController.h:
524         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
525         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
526         (WTR::InjectedBundle::didReceiveMessageToPage):
527         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
528         (WTR::TestRunner::setAllowedMenuActions):
529
530         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
531         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
532         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
533         against the name of the custom action.
534
535         (WTR::TestRunner::installCustomMenuAction):
536
537         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
538         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
539         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
540         triggered.
541
542         (WTR::TestRunner::performCustomMenuAction):
543
544         Invoked when the custom menu action is triggered.
545
546         * WebKitTestRunner/InjectedBundle/TestRunner.h:
547         * WebKitTestRunner/TestController.cpp:
548         (WTR::TestController::installCustomMenuAction):
549         (WTR::TestController::setAllowedMenuActions):
550         * WebKitTestRunner/TestController.h:
551         * WebKitTestRunner/TestInvocation.cpp:
552         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
553         (WTR::TestInvocation::performCustomMenuAction):
554
555         Add plumbing to call back into the injected bundle when performing the custom action.
556
557         * WebKitTestRunner/TestInvocation.h:
558         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
559         (WTR::TestController::installCustomMenuAction):
560         (WTR::TestController::setAllowedMenuActions):
561         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
562         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
563         (-[TestRunnerWKWebView initWithFrame:configuration:]):
564         (-[TestRunnerWKWebView becomeFirstResponder]):
565         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
566
567         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
568         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
569         in the Mail app on iOS.
570
571         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
572         (-[TestRunnerWKWebView setAllowedMenuActions:]):
573         (-[TestRunnerWKWebView resetCustomMenuAction]):
574         (-[TestRunnerWKWebView performCustomAction:]):
575         (-[TestRunnerWKWebView canPerformAction:withSender:]):
576         (-[TestRunnerWKWebView _willHideMenu]):
577         (-[TestRunnerWKWebView _didHideMenu]):
578         * WebKitTestRunner/ios/TestControllerIOS.mm:
579         (WTR::TestController::platformResetStateToConsistentValues):
580
581         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
582         if specified.
583
584         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
585         (WTR::UIScriptController::isDismissingMenu const):
586
587 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
588
589         Allow sharing from imageSheet on an image document
590         https://bugs.webkit.org/show_bug.cgi?id=196891
591         <rdar://problem/25377386>
592
593         Reviewed by Tim Horton.
594
595         Test to make sure that the correct imageURL is extracted from an image element.
596
597         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
598         (TestWebKitAPI::TEST):
599
600 2019-04-16  Alex Christensen  <achristensen@webkit.org>
601
602         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
603         https://bugs.webkit.org/show_bug.cgi?id=196995
604
605         Reviewed by Brady Eidson.
606
607         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
608         (TEST):
609
610 2019-04-16  Chris Dumez  <cdumez@apple.com>
611
612         URL set by document.open() is not communicated to the UIProcess
613         https://bugs.webkit.org/show_bug.cgi?id=196941
614         <rdar://problem/49237544>
615
616         Reviewed by Geoff Garen.
617
618         Add API test coverage.
619
620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
621         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
622         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
623         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
624         (TEST):
625
626 2019-04-16  Commit Queue  <commit-queue@webkit.org>
627
628         Unreviewed, rolling out r244321.
629         https://bugs.webkit.org/show_bug.cgi?id=196968
630
631         Causing all WK2 Debug builds to exit early after Assertion
632         failures. (Requested by ShawnRoberts on #webkit).
633
634         Reverted changeset:
635
636         "URL set by document.open() is not communicated to the
637         UIProcess"
638         https://bugs.webkit.org/show_bug.cgi?id=196941
639         https://trac.webkit.org/changeset/244321
640
641 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
642
643         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
644         https://bugs.webkit.org/show_bug.cgi?id=196948
645
646         Reviewed by Zalan Bujtas.
647
648         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
649         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
650
651 2019-04-15  Chris Dumez  <cdumez@apple.com>
652
653         URL set by document.open() is not communicated to the UIProcess
654         https://bugs.webkit.org/show_bug.cgi?id=196941
655         <rdar://problem/49237544>
656
657         Reviewed by Geoffrey Garen.
658
659         Add API test coverage.
660
661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
662         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
663         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
664         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
665         (TEST):
666
667 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
668
669         Using Tools/Scripts/clean-webkit should not install requests
670         https://bugs.webkit.org/show_bug.cgi?id=196940
671
672         Reviewed by Lucas Forschler.
673
674         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
675         existing, depending on the path autoinstalled is run through.
676         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
677         needed.
678         (Port.configuration_for_upload):
679         (Port.commits_for_upload):
680
681 2019-04-15  Alex Christensen  <achristensen@webkit.org>
682
683         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
684         https://bugs.webkit.org/show_bug.cgi?id=196773
685
686         Reviewed by Jer Noble.
687
688         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
689         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
690         (TEST):
691
692 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
693
694         ews-build should clearly indicate flaky test failures
695         https://bugs.webkit.org/show_bug.cgi?id=196947
696
697         Reviewed by Lucas Forschler.
698
699         * BuildSlaveSupport/ews-build/steps.py:
700         (AnalyzeAPITestsResults.analyzeResults):
701
702 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
703
704         InjectedBundle parameters often need initialization function called before unarchiving
705         https://bugs.webkit.org/show_bug.cgi?id=189709
706         <rdar://problem/44573653>
707
708         Reviewed by Ryosuke Niwa.
709
710         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
711         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
712
713 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
714
715         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
716         https://bugs.webkit.org/show_bug.cgi?id=196681
717
718         Reviewed by Darin Adler.
719
720         Added tests.
721
722         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
723         (WTF_HashSet.RemoveIf):
724         (WTF_HashSet.RemoveIfShrinkToBestSize):
725
726 2019-04-15  John Wilander  <wilander@apple.com>
727
728         Send delayed Ad Click Attribution conversion requests to the click source
729         https://bugs.webkit.org/show_bug.cgi?id=196838
730         <rdar://problem/47650157>
731
732         Reviewed by Chris Dumez and Youenn Fablet.
733
734         This patch adds test infrastructure to override the default behavior in
735         WebKit::NetworkAdClickAttribution.
736
737         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
738         (TestWebKitAPI::TEST):
739         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
740         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
741         (WTR::TestRunner::dumpAdClickAttribution):
742         (WTR::TestRunner::clearAdClickAttribution):
743         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
744         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
745         * WebKitTestRunner/InjectedBundle/TestRunner.h:
746         * WebKitTestRunner/TestController.cpp:
747         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
748         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
749         * WebKitTestRunner/TestController.h:
750         * WebKitTestRunner/TestInvocation.cpp:
751         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
752
753 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
754
755         [ews-app] status-bubble should display position in queue
756         https://bugs.webkit.org/show_bug.cgi?id=196607
757
758         Reviewed by Lucas Forschler.
759
760         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
761         (StatusBubble._build_bubble):
762         (StatusBubble._queue_position): Method to calculate patch's position in queue.
763
764 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
765
766         [ews-build] Do not run clean build by default on EWS builders
767         https://bugs.webkit.org/show_bug.cgi?id=196897
768
769         Reviewed by Lucas Forschler.
770
771         * BuildSlaveSupport/ews-build/steps.py:
772         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
773         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
774         untracked directories like WebKitBuild).
775         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
776         untracked files/directories (like WebKitBuild).
777
778 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
779
780         TestRunner::notifyDone() should be safely reentrant
781         https://bugs.webkit.org/show_bug.cgi?id=196898
782
783         Reviewed by Darin Adler.
784
785         It is currently possible that TestRunner::notifyDone() will call itself, since
786         notifyDone() will force a repaint, which can start executing JavaScript, which
787         may call notifyDone() again. This can lead to test failures and flakiness.
788         Fix this by setting the m_waitToDump flag before calling the dump() method.
789
790         * DumpRenderTree/mac/TestRunnerMac.mm:
791         (TestRunner::notifyDone):
792         (TestRunner::forceImmediateCompletion):
793         * DumpRenderTree/win/TestRunnerWin.cpp:
794         (TestRunner::notifyDone):
795         (TestRunner::forceImmediateCompletion):
796
797 2019-04-15  Philippe Normand  <pnormand@igalia.com>
798
799         [GTK][WPE] Add enable-media websetting
800         https://bugs.webkit.org/show_bug.cgi?id=196863
801
802         Reviewed by Michael Catanzaro.
803
804         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
805         (testWebKitSettings): Add test for the enable-media web-setting.
806
807 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
808
809         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
810         https://bugs.webkit.org/show_bug.cgi?id=196905
811         <rdar://problem/49886096>
812
813         Reviewed by Tim Horton.
814
815         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
816         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
817         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
818         delay timer, we end up with this sequence of events in the problematic (failure) case:
819
820         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
821             ...IPC from UI to web process...
822         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
823             ...IPC from web to UI process...
824         (c) [UI]    Invoke completion handler for script #1
825         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
826             ...IPC from UI to web process...
827         (e) [Web]   Evaluate script #2 in the web process
828         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
829
830         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
831         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
832         #2 is run in step (e).
833
834         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
835         the UI process by waiting on a script message posted by the web process, after attachment updates are
836         dispatched.
837
838         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
839         (TestWebKitAPI::TEST):
840
841 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
842
843         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
844         https://bugs.webkit.org/show_bug.cgi?id=196909
845
846         Reviewed by Wenson Hsieh.
847
848         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
849         (TestWebKitAPI::TEST):
850
851 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
852
853         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
854         https://bugs.webkit.org/show_bug.cgi?id=196880
855
856         Reviewed by Yusuke Suzuki.
857
858         Add a new function for bytecode cache tests that does not forceDiskCache
859         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
860         test added in this patch, since the code is invalid and therefore won't be
861         cached. It should also be useful for tests that evaluate dynamically
862         generated code.
863
864         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
865         * Scripts/run-jsc-stress-tests:
866
867 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
868
869         Update AudioSession route sharing policy
870         https://bugs.webkit.org/show_bug.cgi?id=196776
871         <rdar://problem/46501611>
872
873         Reviewed by Jer Noble.
874
875         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
876         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
877         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
878         (TestWebKitAPI::TEST):
879
880 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
881
882         [iOS] Software keyboard is shown too frequently on some websites
883         https://bugs.webkit.org/show_bug.cgi?id=195856
884         <rdar://problem/49191395>
885
886         Reviewed by Darin Adler.
887
888         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
889
890         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
891         (WTR::UIScriptController::setHardwareKeyboardAttached):
892         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
893         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
894         (WTR::UIScriptController::setHardwareKeyboardAttached):
895         * TestRunnerShared/UIScriptContext/UIScriptController.h:
896         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
897
898         Additionally link against GraphicsServices in WebKitTestRunner.
899
900         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
901         (WTR::TestController::platformResetStateToConsistentValues):
902         (WTR::UIScriptController::setHardwareKeyboardAttached):
903
904 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
905
906         [GTK][WPE] Fix pacman install-dependencies packages
907         https://bugs.webkit.org/show_bug.cgi?id=196817
908
909         Reviewed by Žan Doberšek.
910         
911         python3-setuptools is called python-setuptools
912         ruby-highline is only available on AUR
913         libv4l-devel is incorporated in v4l-utils
914
915         * gtk/install-dependencies:
916         * wpe/install-dependencies:
917
918 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
919
920         [GTK] REGRESSION(r243860): Many tests failing
921         https://bugs.webkit.org/show_bug.cgi?id=196791
922
923         Reviewed by Joanmarie Diggs.
924
925         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
926         multiple documents and check that accessibility hierarchy is updated after a navigation.
927
928         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
929         (loadChangedCallback):
930         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
931         (AccessibilityTest::AccessibilityTest):
932         (AccessibilityTest::~AccessibilityTest):
933         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
934         (AccessibilityTest::findTestServerApplication):
935         (AccessibilityTest::findDocumentWeb):
936         (AccessibilityTest::findRootObject):
937         (AccessibilityTest::waitUntilChildrenRemoved):
938         (AccessibilityTest::ensureProxy):
939         (testAtspiBasicHierarchy):
940         (beforeAll):
941         (afterAll):
942
943 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
944
945         [ews-build] Handle bug titles with unicode characters
946         https://bugs.webkit.org/show_bug.cgi?id=196802
947
948         Reviewed by Dewei Zhu.
949
950         * BuildSlaveSupport/ews-build/steps.py:
951         (ValidatePatch._is_bug_closed):
952
953 2019-04-11  Michael Saboff  <msaboff@apple.com>
954
955         Improve the Inline Cache Stats code
956         https://bugs.webkit.org/show_bug.cgi?id=196836
957
958         Reviewed by Saam Barati.
959
960         Added a new script to consolidate and arrange the output of --useICStats option.
961
962         This script merges the output from every group into one large table and sorts it from most common to
963         least common.  It also counts the slow path GetById and PutById variants and then calculates the
964         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
965         Put together, this is useful to see what property accesses are not getting cached.
966
967         * Scripts/ic-stats.py: Added.
968         (ICStats):
969         (ICStats.__init__):
970         (ICStats.parse):
971         (ICStats.dumpStats):
972         (usage):
973
974 2019-04-10  Alex Christensen  <achristensen@webkit.org>
975
976         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
977         https://bugs.webkit.org/show_bug.cgi?id=196809
978         <rdar://49800762>
979
980         Reviewed by Brady Eidson.
981
982         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
983         (TEST):
984
985 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
986
987         requestAnimationFrame should execute before the next frame
988         https://bugs.webkit.org/show_bug.cgi?id=177484
989
990         Reviewed by Simon Fraser.
991
992         Add trace points for the page RenderingUpdate.
993
994         * Tracing/SystemTracePoints.plist:
995
996 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
997
998         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
999         https://bugs.webkit.org/show_bug.cgi?id=196760
1000
1001         Reviewed by Don Olmstead.
1002
1003         vswhere.exe has been bundled since Visual Studio 2017 version
1004         15.2. We shouldn't download vswhere.exe.
1005
1006         * Scripts/build-jsc: Do not call update-vswhere.py.
1007         * Scripts/build-webkit: Ditto.
1008         * Scripts/update-vswhere.py: Removed.
1009         * Scripts/webkitdirs.pm:
1010         (requireModulesForVSWhere): Deleted.
1011         (pickCurrentVisualStudioInstallation): Deleted.
1012         (visualStudioInstallDirVSWhere): Return the latest installed VS
1013         installation path by using the bundled vswhere.exe.
1014         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1015         (visualStudioInstallDirFallback): Removed.
1016
1017 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1018
1019         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1020         https://bugs.webkit.org/show_bug.cgi?id=196780
1021
1022         Reviewed by Alexey Proskuryakov.
1023
1024         * BuildSlaveSupport/ews-build/steps.py:
1025         * BuildSlaveSupport/ews-build/steps_unittest.py:
1026
1027 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1028
1029         Add SPI WKNavigationResponse._downloadAttribute
1030         https://bugs.webkit.org/show_bug.cgi?id=196755
1031         <rdar://49587365>
1032
1033         Reviewed by Brady Eidson.
1034
1035         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1036         (-[NavigationResponseTestDelegate navigationResponse]):
1037         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1038         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1039         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1040         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1041         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1042         (readRequest):
1043         (writeResponse):
1044         (TEST):
1045
1046 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1047
1048         Add modern API for overriding the page's specified viewport configuration
1049         https://bugs.webkit.org/show_bug.cgi?id=167734
1050         <rdar://problem/30331795>
1051
1052         Reviewed by Simon Fraser.
1053
1054         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1055         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1056
1057 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1058
1059         Add support for incremental bytecode cache updates
1060         https://bugs.webkit.org/show_bug.cgi?id=195000
1061
1062         Reviewed by Filip Pizlo.
1063
1064         Exit when the initial run to generate bytecode fails.
1065
1066         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1067
1068 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1069
1070         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1071         https://bugs.webkit.org/show_bug.cgi?id=196744
1072         <rdar://49415309>
1073
1074         Reviewed by Chris Dumez.
1075
1076         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1077         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1078
1079 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1080
1081         Add a way to opt into modern compatibility mode in layout tests
1082         https://bugs.webkit.org/show_bug.cgi?id=196770
1083         <rdar://problem/49777550>
1084
1085         Reviewed by Antoine Quint.
1086
1087         Add a new test option to enable modern compatibility mode in layout tests.
1088
1089         * WebKitTestRunner/TestController.cpp:
1090         (WTR::updateTestOptionsFromTestHeader):
1091         * WebKitTestRunner/TestController.h:
1092         * WebKitTestRunner/TestOptions.h:
1093         (WTR::TestOptions::hasSameInitializationOptions const):
1094         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1095         (WTR::TestController::platformCreateWebView):
1096         (WTR::TestController::enableModernCompatibilityMode):
1097
1098 2019-04-10  Andy Estes  <aestes@apple.com>
1099
1100         Try to fix the 32-bit watchOS build.
1101
1102         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1103         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1104
1105 2019-04-10  Antoine Quint  <graouts@apple.com>
1106
1107         Enable Pointer Events on watchOS
1108         https://bugs.webkit.org/show_bug.cgi?id=196771
1109         <rdar://problem/49040909>
1110
1111         Reviewed by Dean Jackson.
1112
1113         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1114
1115 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1116
1117         Unreviewed. Fix WPE accessibility tests after r244059.
1118
1119         We are failing to load the injected bundle due to undefined symbol
1120         AccessibilityUIElement::replaceTextInRange().
1121
1122         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1123         (WTR::AccessibilityUIElement::replaceTextInRange):
1124
1125 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1126
1127         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1128         https://bugs.webkit.org/show_bug.cgi?id=196727
1129
1130         Reviewed by Fujii Hironori.
1131
1132         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1133         (WebKitBrowserWindow::create):
1134
1135 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1136
1137         [ews-build] Add unit tests for PrintConfiguration
1138         https://bugs.webkit.org/show_bug.cgi?id=196752
1139
1140         Reviewed by Dewei Zhu.
1141
1142         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1143
1144 2019-04-09  Keith Rollin  <krollin@apple.com>
1145
1146         Unreviewed build maintenance -- update .xcfilelists.
1147
1148         * DumpRenderTree/DerivedSources-input.xcfilelist:
1149         * DumpRenderTree/DerivedSources-output.xcfilelist:
1150
1151 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1152
1153         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1154         https://bugs.webkit.org/show_bug.cgi?id=196743
1155         <rdar://problem/43897551>
1156
1157         Reviewed by Tim Horton.
1158
1159         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1160         (TEST):
1161
1162 2019-04-09  Youenn Fablet  <youenn@apple.com>
1163
1164         Close service worker database on network process suspension
1165         https://bugs.webkit.org/show_bug.cgi?id=196623
1166         <rdar://problem/48930869>
1167
1168         Reviewed by Alex Christensen.
1169
1170         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1171
1172 2019-04-09  Daniel Bates  <dabates@apple.com>
1173
1174         [iPad] Should open popover when the spacebar is pressed
1175         https://bugs.webkit.org/show_bug.cgi?id=196360
1176         <rdar://problem/49389129>
1177
1178         Reviewed by Brent Fulgham.
1179
1180         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1181
1182         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1183         (WTR::UIScriptController::isShowingPopover const): Added.
1184         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1185         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1186         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1187         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1188         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1189         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1190         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1191         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1192         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1193         (WTR::UIScriptController::isShowingPopover const): Added.
1194         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1195         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1196         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1197         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1198         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1199         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1200         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1201         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1202         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1203         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1204         (WTR::UIScriptController::isShowingPopover const): Added.
1205         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1206         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1207
1208 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1209
1210         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1211         https://bugs.webkit.org/show_bug.cgi?id=196665
1212         <rdar://45115669>
1213
1214         Reviewed by Geoff Garen.
1215
1216         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1217         (goBack):
1218         (+[SimpleLookupContext sharedLookupContext]):
1219         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1220         (TEST):
1221         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1222         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1223
1224 2019-04-09  John Wilander  <wilander@apple.com>
1225
1226         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1227         https://bugs.webkit.org/show_bug.cgi?id=196558
1228         <rdar://problem/47650245>
1229
1230         Reviewed by Youenn Fablet.
1231
1232         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1233         (TestWebKitAPI::TEST):
1234             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1235
1236 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1237
1238         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1239         https://bugs.webkit.org/show_bug.cgi?id=196720
1240
1241         Reviewed by Konstantin Tokarev.
1242
1243         * TestWebKitAPI/PlatformMac.cmake:
1244
1245 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1246
1247         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1248         https://bugs.webkit.org/show_bug.cgi?id=196694
1249         <rdar://problem/48388734>
1250
1251         Rubber-stamped by Aakash Jain.
1252
1253         * Scripts/webkitpy/port/image_diff.py:
1254         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1255         * Scripts/webkitpy/port/server_process.py:
1256         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1257         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1258         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1259         * Scripts/webkitpy/port/server_process_mock.py:
1260         (MockServerProcess.has_available_stdout):
1261         * Scripts/webkitpy/port/server_process_unittest.py:
1262         (TestServerProcess.serial_test_basic):
1263
1264 2019-04-09  Jer Noble  <jer.noble@apple.com>
1265
1266         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1267         https://bugs.webkit.org/show_bug.cgi?id=196097
1268
1269         Reviewed by Eric Carlson.
1270
1271         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1272
1273         * DumpRenderTree/mac/DumpRenderTree.mm:
1274         (resetWebPreferencesToConsistentValues):
1275         * WebKitTestRunner/TestController.cpp:
1276         (WTR::TestController::resetPreferencesToConsistentValues):
1277
1278 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1279
1280         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1281         https://bugs.webkit.org/show_bug.cgi?id=196690
1282
1283         Reviewed by Michael Catanzaro.
1284
1285         * QueueStatusServer/config/queues.py:
1286         * Scripts/webkitpy/common/config/ews.json:
1287         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1288         (test_ews_name):
1289
1290 2019-04-09  Chris Dumez  <cdumez@apple.com>
1291
1292         Loads using loadHTMLString() cause flashing when process-swapping
1293         https://bugs.webkit.org/show_bug.cgi?id=196714
1294         <rdar://problem/49637354>
1295
1296         Reviewed by Antti Koivisto.
1297
1298         Add API test coverage.
1299
1300         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1301
1302 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1303
1304         Unreviewed. Fix ATK accessibility tests after r244059.
1305
1306         We are failing to load the injected bundle due to undefined symbol
1307         AccessibilityUIElement::replaceTextInRange().
1308
1309         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1310         (WTR::AccessibilityUIElement::replaceTextInRange):
1311
1312 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1313
1314         AX: Support API: accessibilityReplaceRange:withText
1315         https://bugs.webkit.org/show_bug.cgi?id=196636
1316
1317         Unreviewed build fix for Windows port.
1318
1319         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1320         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1321
1322 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1323
1324         [CMake][WinCairo] Separate copied headers into different directories
1325         https://bugs.webkit.org/show_bug.cgi?id=196655
1326
1327         Reviewed by Michael Catanzaro.
1328
1329         * DumpRenderTree/CMakeLists.txt:
1330         * MiniBrowser/win/CMakeLists.txt:
1331         * TestWebKitAPI/CMakeLists.txt:
1332         * TestWebKitAPI/PlatformWin.cmake:
1333
1334 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1335
1336         Log stack-trace for run-webkit-tests when interrupted
1337         https://bugs.webkit.org/show_bug.cgi?id=176393
1338         <rdar://problem/34262310>
1339
1340         Reviewed by Lucas Forschler.
1341
1342         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1343         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1344         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1345         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1346         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1347         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1348         (main): Set handlers to log stack trace on interruption.
1349
1350 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1351
1352         AX: Support API: accessibilityReplaceRange:withText
1353         https://bugs.webkit.org/show_bug.cgi?id=196636
1354
1355         Unreviewed build fix for Windows port.
1356
1357         * DumpRenderTree/AccessibilityUIElement.cpp:
1358         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1359
1360 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1361
1362         [ews-build] Scripts using Buildbot API have CORS error
1363         https://bugs.webkit.org/show_bug.cgi?id=196709
1364
1365         Reviewed by Alexey Proskuryakov.
1366
1367         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1368
1369 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1370
1371         AX: Support API: accessibilityReplaceRange:withText
1372         https://bugs.webkit.org/show_bug.cgi?id=196636
1373
1374         Reviewed by Daniel Bates.
1375
1376         * DumpRenderTree/AccessibilityUIElement.cpp:
1377         (replaceTextInRangeCallback):
1378         (AccessibilityUIElement::replaceTextInRange):
1379         (AccessibilityUIElement::getJSClass):
1380         * DumpRenderTree/AccessibilityUIElement.h:
1381         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1382         (AccessibilityUIElement::replaceTextInRange):
1383         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1384         (AccessibilityUIElement::replaceTextInRange):
1385         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1386         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1387         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1388         (WTR::AccessibilityUIElement::replaceTextInRange):
1389         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1390         (WTR::AccessibilityUIElement::replaceTextInRange):
1391
1392 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1393
1394         [iOS] Do not allow starting selection drags when selection views are not visible
1395         https://bugs.webkit.org/show_bug.cgi?id=196686
1396         <rdar://problem/49399192>
1397
1398         Reviewed by Tim Horton.
1399
1400         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1401         also add some new API tests to cover scenarios where the web view is not first responder.
1402
1403         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1404         (TestWebKitAPI::TEST):
1405         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1406
1407         Add a switch to optionally make the web view first responder when starting the simulated drag.
1408
1409         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1410         (-[DragAndDropSimulator initWithWebView:]):
1411         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1412
1413 2019-04-08  Justin Fan  <justin_fan@apple.com>
1414
1415         [Web GPU] Fix Web GPU experimental feature on iOS
1416         https://bugs.webkit.org/show_bug.cgi?id=196632
1417
1418         Reviewed by Myles C. Maxfield.
1419
1420         Properly make Web GPU available on iOS 11+.
1421
1422         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1423
1424 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1425
1426         [ews-build] Do not upload archive when Compile Fails
1427         https://bugs.webkit.org/show_bug.cgi?id=196674
1428
1429         Reviewed by Alexey Proskuryakov.
1430
1431         * BuildSlaveSupport/ews-build/factories.py:
1432         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1433         * BuildSlaveSupport/ews-build/steps.py:
1434         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1435         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1436         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1437
1438 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1439
1440         Enable DFG on MIPS
1441         https://bugs.webkit.org/show_bug.cgi?id=196689
1442
1443         Reviewed by Žan Doberšek.
1444
1445         Since the bytecode change, we enabled the baseline JIT on mips in
1446         r240432, but DFG is still missing. With this change, all tests are
1447         passing on a ci20 board.
1448
1449         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1450
1451 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1452
1453         [Flatpak] Second run update-webkitwpe-flatpak fails
1454         https://bugs.webkit.org/show_bug.cgi?id=192702
1455
1456         Reviewed by Carlos Garcia Campos.
1457
1458         * flatpak/flatpakutils.py:
1459         (FlatpakObject.flatpak): Fix typo.
1460         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1461         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1462
1463 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1464
1465         [GTK][WPE] outlook.live.com displays old-fashioned UI
1466         https://bugs.webkit.org/show_bug.cgi?id=196642
1467
1468         Reviewed by Carlos Garcia Campos.
1469
1470         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1471         (TestWebKitAPI::TEST): New Mac platform quirk test.
1472
1473 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1474
1475         Unreviewed, rolling out r243956.
1476         https://bugs.webkit.org/show_bug.cgi?id=196688
1477
1478         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1479         by aakashjain on #webkit).
1480
1481         Reverted changeset:
1482
1483         "Clicking "Go Back" from a safe browsing warning from an
1484         iframe should navigate the WKWebView back to the previous
1485         page"
1486         https://bugs.webkit.org/show_bug.cgi?id=196665
1487         https://trac.webkit.org/changeset/243956
1488
1489 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1490
1491         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1492         https://bugs.webkit.org/show_bug.cgi?id=196669
1493
1494         Reviewed by Geoffrey Garen.
1495
1496         Added three new unit tests for WeakHashSet.
1497
1498         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1499         (WTF_WeakPtr.WeakHashSetConstObjects):
1500         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1501         (WTF_WeakPtr.WeakHashSetComputeSize):
1502
1503 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1504
1505         Hide next and previous form control buttons when WKWebView is editable
1506         https://bugs.webkit.org/show_bug.cgi?id=196672
1507         <rdar://problem/35625321>
1508
1509         Reviewed by Tim Horton.
1510
1511         Add a new API test.
1512
1513         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1514         (-[TestWKWebView lastTrailingBarButtonGroup]):
1515         (TestWebKitAPI::TEST):
1516         * TestWebKitAPI/ios/UIKitSPI.h:
1517
1518 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1519
1520         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1521         https://bugs.webkit.org/show_bug.cgi?id=196077
1522         <rdar://problem/49108202>
1523
1524         Reviewed by Chris Dumez.
1525
1526         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1527         on new web view.
1528
1529         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1530
1531 2019-04-05  Saam Barati  <sbarati@apple.com>
1532
1533         Make compare-results understand MotionMark
1534         https://bugs.webkit.org/show_bug.cgi?id=196666
1535
1536         Reviewed by Yusuke Suzuki.
1537
1538         * Scripts/compare-results:
1539         (PLT5Results):
1540         (detectMotionMark):
1541         (detectMotionMark1_1):
1542         (motionMarkResults):
1543         (motionMark1_1Results):
1544         (detectBenchmark):
1545         (biggerIsBetter):
1546         (main):
1547
1548 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1549
1550         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1551         https://bugs.webkit.org/show_bug.cgi?id=196665
1552         <rdar://45115669>
1553
1554         Reviewed by Geoff Garen.
1555
1556         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1557         (goBack):
1558         (+[SimpleLookupContext sharedLookupContext]):
1559         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1560         (TEST):
1561         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1562         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1563
1564 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1565
1566         [ews-build] Add configuration and architecture for windows builders
1567         https://bugs.webkit.org/show_bug.cgi?id=196660
1568
1569         Reviewed by Lucas Forschler.
1570
1571         * BuildSlaveSupport/ews-build/config.json:
1572
1573 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1574
1575         webkitpy: Don't run subsequent rounds if interrupted
1576         https://bugs.webkit.org/show_bug.cgi?id=196646
1577
1578         Reviewed by Aakash Jain.
1579
1580         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1581         (Manager.run): Bail out if interrupted.
1582
1583 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1584
1585         Test sessionStorage in PSON private browsing mode
1586         https://bugs.webkit.org/show_bug.cgi?id=196561
1587
1588         Reviewed by Alex Christensen.
1589
1590         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1591
1592 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1593
1594         Unreviewed, rolling out r243833.
1595         https://bugs.webkit.org/show_bug.cgi?id=196645
1596
1597         This change breaks build of WPE and GTK ports (Requested by
1598         annulen on #webkit).
1599
1600         Reverted changeset:
1601
1602         "[CMake][WTF] Mirror XCode header directories"
1603         https://bugs.webkit.org/show_bug.cgi?id=191662
1604         https://trac.webkit.org/changeset/243833
1605
1606 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1607
1608         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1609         https://bugs.webkit.org/show_bug.cgi?id=196635
1610
1611         Reviewed by Antti Koivisto.
1612         
1613         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1614         for a test to enable async frame scrolling via:
1615             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1616         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1617         
1618         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1619
1620         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1621         (WTR::InjectedBundle::beginTesting):
1622         * WebKitTestRunner/TestController.cpp:
1623         (WTR::TestController::resetPreferencesToConsistentValues):
1624
1625 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1626
1627         Use a correct LC_RPATH when building with ASan
1628         https://bugs.webkit.org/show_bug.cgi?id=196576
1629
1630         Reviewed by David Kilzer.
1631
1632         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1633         so that ../Frameworks is checked. This is simpler and more reliable than updating
1634         each SPC service xcconfig.
1635
1636 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1637
1638         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1639         https://bugs.webkit.org/show_bug.cgi?id=196629
1640
1641         Reviewed by Lucas Forschler.
1642
1643         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1644
1645 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1646
1647         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1648         https://bugs.webkit.org/show_bug.cgi?id=196618
1649
1650         Reviewed by Lucas Forschler.
1651
1652         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1653         (StatusBubble): Added QUEUE_TRIGGERS.
1654         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1655         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1656         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1657         its parent(builder).
1658
1659 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1660
1661         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1662         https://bugs.webkit.org/show_bug.cgi?id=196625
1663
1664         Reviewed by Lucas Forschler.
1665
1666         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1667         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1668
1669 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1670
1671         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1672         https://bugs.webkit.org/show_bug.cgi?id=196630
1673
1674         Reviewed by Wenson Hsieh.
1675
1676         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1677
1678 2019-04-04  Youenn Fablet  <youenn@apple.com>
1679
1680         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1681         https://bugs.webkit.org/show_bug.cgi?id=196543
1682
1683         Reviewed by Alex Christensen.
1684
1685         * WebKitTestRunner/TestController.cpp:
1686         (WTR::TestController::generatePageConfiguration):
1687
1688 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1689
1690         [ews-app] Status bubble should not display skipped buildbot steps
1691         https://bugs.webkit.org/show_bug.cgi?id=196584
1692
1693         Reviewed by Lucas Forschler.
1694
1695         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1696
1697 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1698
1699         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1700         https://bugs.webkit.org/show_bug.cgi?id=196620
1701
1702         Reviewed by Lucas Forschler.
1703
1704         * BuildSlaveSupport/ews-app/ews/config.py:
1705
1706 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1707
1708         [Win] DumpRenderTreeWatchDog.py is not checked into source
1709         https://bugs.webkit.org/show_bug.cgi?id=196567
1710         <rdar://problem/49525901>
1711
1712         Reviewed by Lucas Forschler.
1713
1714         This script is used on Win EWS bots to terminate hanging DRT processes.
1715
1716         * EWSTools/dumprendertreewatchdog.py: Added.
1717
1718 2019-04-04  Chris Dumez  <cdumez@apple.com>
1719
1720         Unreviewed, roll out r243858 which made tests time out.
1721
1722         Disable new API tests on Windows instead.
1723
1724         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1725         (TestWebKitAPI::TEST):
1726
1727 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1728
1729         [ATK] Cleanup WebPageAccessibilityObjectAtk
1730         https://bugs.webkit.org/show_bug.cgi?id=196537
1731
1732         Reviewed by Michael Catanzaro.
1733
1734         Also consider files under atk directories as exceptions for GObject conventions.
1735
1736         * Scripts/webkitpy/style/checkers/cpp.py:
1737         (check_identifier_name_in_declaration):
1738
1739 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1740
1741         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1742         https://bugs.webkit.org/show_bug.cgi?id=196588
1743         <rdar://problem/49365787>
1744
1745         Unreviewed build fix for Windows port.
1746
1747         error C3861: 'kill': identifier not found
1748
1749         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1750         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1751
1752 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1753
1754         [ews-build] Cancel build and similar operations should have authentication
1755         https://bugs.webkit.org/show_bug.cgi?id=196520
1756
1757         Reviewed by Dewei Zhu.
1758
1759         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1760         environment variables.
1761
1762 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1763
1764         [ews-build] Do not trigger queues which are not in production yet
1765         https://bugs.webkit.org/show_bug.cgi?id=196581
1766
1767         Reviewed by Dewei Zhu.
1768
1769         * BuildSlaveSupport/ews-build/config.json:
1770
1771 2019-04-03  Chris Dumez  <cdumez@apple.com>
1772
1773         Unreviewed, fix typo in the name of API test added in r243848.
1774
1775         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1776         (TestWebKitAPI::TEST):
1777
1778 2019-04-03  Chris Dumez  <cdumez@apple.com>
1779
1780         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1781         https://bugs.webkit.org/show_bug.cgi?id=196588
1782         <rdar://problem/49365787>
1783
1784         Reviewed by Ryosuke Niwa.
1785
1786         Add API test coverage.
1787
1788         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1789         (TestWebKitAPI::nullJavaScriptCallback):
1790         (TestWebKitAPI::didCrashCheckFrames):
1791         (TestWebKitAPI::TEST):
1792
1793 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1794
1795         run-webkit-tests: Upload test results (new results database)
1796         https://bugs.webkit.org/show_bug.cgi?id=196577
1797         <rdar://problem/34841155>
1798
1799         Reviewed by Lucas Forschler.
1800
1801         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1802         (Manager.run): Upload results after each device shard, since the configuration will be
1803         different for each device.
1804         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1805         uploaded to a results database.
1806         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1807         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1808
1809 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1810
1811         -apple-trailing-word is needed for browser detection
1812         https://bugs.webkit.org/show_bug.cgi?id=196575
1813
1814         Unreviewed.
1815
1816         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1817
1818 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1819
1820         [CMake][WTF] Mirror XCode header directories
1821         https://bugs.webkit.org/show_bug.cgi?id=191662
1822
1823         Reviewed by Konstantin Tokarev.
1824
1825         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1826         builds.
1827
1828         * CMakeLists.txt:
1829         * DumpRenderTree/CMakeLists.txt:
1830         * DumpRenderTree/PlatformWin.cmake:
1831         * MiniBrowser/win/CMakeLists.txt:
1832         * TestWebKitAPI/CMakeLists.txt:
1833         * TestWebKitAPI/PlatformWin.cmake:
1834         * WebKitTestRunner/PlatformGTK.cmake:
1835         * WebKitTestRunner/PlatformWin.cmake:
1836
1837 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1838
1839         [ews-app] Status bubble should not display certain infrastructure status messages
1840         https://bugs.webkit.org/show_bug.cgi?id=196550
1841
1842         Reviewed by Lucas Forschler.
1843
1844         Do not display the steps which are un-needed for end-user. This information is still avaiable
1845         if the user click on the bubble and look at the Buildbot build.
1846         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1847         (StatusBubble._steps_messages):
1848         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1849
1850 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1851
1852         [ews-build] Use https for sending data to ews-app
1853         https://bugs.webkit.org/show_bug.cgi?id=196492
1854
1855         Reviewed by Lucas Forschler.
1856
1857         * BuildSlaveSupport/ews-build/events.py:
1858
1859 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1860
1861         Remove support for -apple-trailing-word
1862         https://bugs.webkit.org/show_bug.cgi?id=196525
1863
1864         Reviewed by Zalan Bujtas.
1865
1866         This CSS property is nonstandard and not used.
1867
1868         * Scripts/webkitperl/FeatureList.pm:
1869         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1870
1871 2019-04-03  Youenn Fablet  <youenn@apple.com>
1872
1873         Add a test for DOMCache on multiple browsing in case of private browsing
1874         https://bugs.webkit.org/show_bug.cgi?id=196524
1875
1876         Reviewed by Alex Christensen.
1877
1878         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1879         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1880
1881 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1882
1883         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1884         https://bugs.webkit.org/show_bug.cgi?id=196540
1885
1886         Reviewed by Aakash Jain.
1887
1888         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1889
1890 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1891
1892         Add plumbing for a compatibility mode preference in WebKit
1893         https://bugs.webkit.org/show_bug.cgi?id=196005
1894
1895         Reviewed by Tim Horton.
1896
1897         Add new API tests.
1898
1899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1900         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1901
1902 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1903
1904         [WPE][GTK] Update libsrtp dependency package for Debian
1905         https://bugs.webkit.org/show_bug.cgi?id=196528
1906
1907         Reviewed by Frédéric Wang.
1908
1909         * gtk/install-dependencies:
1910         * wpe/install-dependencies:
1911
1912 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1913
1914         [WK2] Add support for Window's beforeprint / afterprint events
1915         https://bugs.webkit.org/show_bug.cgi?id=196478
1916         <rdar://problem/49535124>
1917
1918         Unreviewed build fix for MSVC.
1919
1920         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1921
1922         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1923
1924         * WebKitTestRunner/TestController.cpp:
1925         (WTR::printFrame): Use int and float literals.
1926
1927 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1928
1929         [ews-build] Reassign bots to queues
1930
1931         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1932
1933 2019-04-02  Chris Dumez  <cdumez@apple.com>
1934
1935         [WK2] Add support for Window's beforeprint / afterprint events
1936         https://bugs.webkit.org/show_bug.cgi?id=196478
1937
1938         Reviewed by Alex Christensen.
1939
1940         Add minimal implementation for printFrame in WebKitTestRunner.
1941
1942         * WebKitTestRunner/TestController.cpp:
1943         (WTR::printFrame):
1944         (WTR::TestController::createOtherPage):
1945         (WTR::TestController::createWebViewWithOptions):
1946
1947 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1948
1949         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1950         https://bugs.webkit.org/show_bug.cgi?id=196491
1951
1952         Reviewed by Lucas Forschler.
1953
1954         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1955
1956 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1957
1958         [ews-build] Configure buildbot try credentials in environment variables
1959         https://bugs.webkit.org/show_bug.cgi?id=196501
1960
1961         Reviewed by Lucas Forschler.
1962
1963         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1964         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1965         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1966
1967 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1968
1969         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1970         https://bugs.webkit.org/show_bug.cgi?id=196496
1971         <rdar://problem/49521634>
1972
1973         Reviewed by Chris Dumez.
1974
1975         Add new API tests (see WebKit ChangeLog for more detail).
1976
1977         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1978         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1979         (TEST):
1980
1981 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1982
1983         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1984         <https://webkit.org/b/196499>
1985
1986         Reviewed by Alexey Proskuryakov.
1987
1988         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1989         ENABLE_ADDRESS_SANITIZER.
1990
1991 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1992
1993         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1994         https://bugs.webkit.org/show_bug.cgi?id=182757
1995
1996         Reviewed by Don Olmstead.
1997
1998         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1999         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2000
2001 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2002
2003         run-api-tests: Upload test results
2004         https://bugs.webkit.org/show_bug.cgi?id=196323
2005         <rdar://problem/49356714>
2006
2007         Reviewed by Lucas Forschler.
2008
2009         * Scripts/webkitpy/api_tests/manager.py:
2010         (Manager):
2011         (Manager.run): Upload results to a results database.
2012         * Scripts/webkitpy/api_tests/run_api_tests.py:
2013         (parse_args): Add upload arguments.
2014         * Scripts/webkitpy/port/base.py:
2015         (Port):
2016         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2017         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2018         with commits from any other associated repositories.
2019         * Scripts/webkitpy/port/device.py:
2020         (Device):
2021         (Device.build_version): Access build_versoin of underlying platform device.
2022         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2023         (IOSSimulatorTest):
2024         (IOSSimulatorTest.test_configuration_for_upload):
2025         * Scripts/webkitpy/port/device_port.py:
2026         (DevicePort):
2027         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2028         the same as the machine uploading results.
2029         * Scripts/webkitpy/port/mac.py:
2030         (MacPort):
2031         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2032         * Scripts/webkitpy/port/mac_unittest.py:
2033         (MacTest):
2034         (MacTest.test_configuration_for_upload):
2035         * Scripts/webkitpy/xcode/simulated_device.py:
2036         (SimulatedDeviceManager._create_device_with_runtime):
2037         (SimulatedDevice.__init__): Create simulated device with a build_version.
2038         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2039         (test_existing_simulator):
2040
2041 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2042
2043         Remove extra newline characters (Follow-up fix to r243707)
2044
2045         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2046
2047 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2048
2049         [ews-app] Use API_KEY to accept results data
2050         https://bugs.webkit.org/show_bug.cgi?id=196461
2051
2052         Reviewed by Dewei Zhu.
2053
2054         * BuildSlaveSupport/ews-app/ews/views/results.py:
2055         (Results.post): Validate EWS_API_KEY before accepting any data.
2056         * BuildSlaveSupport/ews-build/events.py:
2057         (Events.sendData): Send EWS_API_KEY if available along with event data.
2058
2059 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2060
2061         Unable to copy and paste a PDF from Notes into Mail compose body
2062         https://bugs.webkit.org/show_bug.cgi?id=196442
2063         <rdar://problem/48573098>
2064
2065         Reviewed by Tim Horton.
2066
2067         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2068         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2069         to be specified on the item providers.
2070
2071         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2072         (TestWebKitAPI::mapItemForTesting):
2073         (TestWebKitAPI::contactItemForTesting):
2074
2075 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2076
2077         Make UIWKDocumentContext rects per-character instead of per-word
2078         https://bugs.webkit.org/show_bug.cgi?id=196459
2079
2080         Reviewed by Wenson Hsieh.
2081
2082         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2083         (TEST):
2084         Adjust test results due to switching to per-character rects.
2085
2086 2019-04-01  Chris Dumez  <cdumez@apple.com>
2087
2088         UIProcess crash when a prewarmed process is terminated
2089         https://bugs.webkit.org/show_bug.cgi?id=196451
2090         <rdar://problem/49245471>
2091
2092         Reviewed by Geoffrey Garen.
2093
2094         Add API test coverage.
2095
2096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2097         (TEST):
2098
2099 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2100
2101         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2102         https://bugs.webkit.org/show_bug.cgi?id=196449
2103
2104         Reviewed by Lucas Forschler.
2105
2106         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2107         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2108         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2109         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2110
2111 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2112
2113         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2114         https://bugs.webkit.org/show_bug.cgi?id=196444
2115
2116         Reviewed by Lucas Forschler.
2117
2118         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2119
2120 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2121
2122         Add SPI to canonicalize NSURLs with WTF::URL
2123         https://bugs.webkit.org/show_bug.cgi?id=196415
2124         <rdar://problem/44980271>
2125
2126         Reviewed by Darin Adler.
2127
2128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2129         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2130         (TestWebKitAPI::TEST):
2131
2132 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2133
2134         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2135         https://bugs.webkit.org/show_bug.cgi?id=196441
2136
2137         Reviewed by Carlos Garcia Campos.
2138
2139         Don't cache the wpe_view_backend object that might not exist yet at the
2140         time of EventSenderProxy constructor invocation, but instead retrieve
2141         that object whenever it's required for event dispatching. This should
2142         avoid crashes in this constructor now that it's invoked before any
2143         PlatformWindow has been set up (as changed in r243496).
2144
2145         * WebKitTestRunner/EventSenderProxy.h:
2146         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2147         (WTR::viewBackend):
2148         (WTR::EventSenderProxy::EventSenderProxy):
2149         (WTR::EventSenderProxy::mouseDown):
2150         (WTR::EventSenderProxy::mouseUp):
2151         (WTR::EventSenderProxy::mouseMoveTo):
2152         (WTR::EventSenderProxy::mouseScrollBy):
2153         (WTR::EventSenderProxy::keyDown):
2154         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2155
2156 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2157
2158         [Win][WebKit] MiniBrowser should support high DPI display
2159         https://bugs.webkit.org/show_bug.cgi?id=196391
2160
2161         Reviewed by Alex Christensen.
2162
2163         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2164         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2165         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2166         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2167
2168 2019-03-31  Sam Weinig  <weinig@apple.com>
2169
2170         Remove more i386 specific configurations
2171         https://bugs.webkit.org/show_bug.cgi?id=196430
2172
2173         Reviewed by Alexey Proskuryakov.
2174
2175         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2176         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2177
2178 2019-03-31  Andy Estes  <aestes@apple.com>
2179
2180         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2181         https://bugs.webkit.org/show_bug.cgi?id=196433
2182         <rdar://problem/49293305>
2183
2184         Reviewed by Tim Horton.
2185
2186         Enhanced API test coverage to include all navigation response policy decisions in both
2187         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2188
2189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2190         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2191         (TestWebKitAPI::TEST):
2192         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2193         (readFile):
2194         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2195         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2196         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2197         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2198         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2199         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2200         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2201         (-[QuickLookDelegate _downloadDidStart:]):
2202         (-[QuickLookDelegate _download:didReceiveResponse:]):
2203         (-[QuickLookDelegate _download:didReceiveData:]):
2204         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2205         (-[QuickLookDelegate _downloadDidFinish:]):
2206         (-[QuickLookDelegate _download:didFailWithError:]):
2207         (-[QuickLookDelegate _downloadDidCancel:]):
2208         (-[QuickLookDelegate verifyDownload]):
2209         (runTest):
2210         (runTestDecideBeforeLoading):
2211         (runTestDecideAfterLoading):
2212         (TEST):
2213         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2214         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2215         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2216         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2217         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2218         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2219         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2220         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2221         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2222         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2223         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2224         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2225         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2226         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2227
2228 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2229
2230         [CMake] add testdfg as target with build-jsc
2231         https://bugs.webkit.org/show_bug.cgi?id=196393
2232
2233         Reviewed by Saam Barati.
2234
2235         Added testdfg as one of the targets to build when
2236         using CMake.
2237
2238         * Scripts/build-jsc:
2239
2240 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2241
2242         Delete WebMetal implementation in favor of WebGPU
2243         https://bugs.webkit.org/show_bug.cgi?id=195418
2244
2245         Reviewed by Dean Jackson.
2246
2247         * DumpRenderTree/mac/DumpRenderTree.mm:
2248         (enableExperimentalFeatures):
2249         (resetWebPreferencesToConsistentValues):
2250         * Scripts/webkitperl/FeatureList.pm:
2251         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2252         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2253         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2254         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2255         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2256         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2257         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2258         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2259         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2260         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2261         (WTR::InjectedBundle::beginTesting):
2262         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2263         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2264         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2265
2266 2019-03-29  Chris Dumez  <cdumez@apple.com>
2267
2268         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2269         https://bugs.webkit.org/show_bug.cgi?id=196405
2270         <rdar://problem/49428130>
2271
2272         Reviewed by Wenson Hsieh.
2273
2274         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2275         the popover presentation methods to be no-ops. Use this in the new test added in
2276         r243523 so that we do not swizzle those methods for all tests. This is needed because
2277         those WatchOS tests rely on the popover getting presented and interactive.
2278
2279         * WebKitTestRunner/TestController.cpp:
2280         (WTR::updateTestOptionsFromTestHeader):
2281         * WebKitTestRunner/TestController.h:
2282         * WebKitTestRunner/TestOptions.h:
2283         (WTR::TestOptions::hasSameInitializationOptions const):
2284         * WebKitTestRunner/ios/TestControllerIOS.mm:
2285         (WTR::TestController::platformInitialize):
2286         (WTR::TestController::platformResetStateToConsistentValues):
2287
2288 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2289
2290         [Curl] Add Server Trust Evaluation Support.
2291         https://bugs.webkit.org/show_bug.cgi?id=191646
2292
2293         Reviewed by Fujii Hironori.
2294
2295         Implemented MiniBrowser UI for asking if user trusts the server.
2296
2297         * MiniBrowser/win/Common.cpp:
2298         (askServerTrustEvaluation):
2299         (replaceString):
2300         * MiniBrowser/win/Common.h:
2301         * MiniBrowser/win/MiniBrowserLib.rc:
2302         * MiniBrowser/win/MiniBrowserLibResource.h:
2303         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2304         (createPEMString):
2305         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2306         (WebKitBrowserWindow::canTrustServerCertificate):
2307         * MiniBrowser/win/WebKitBrowserWindow.h:
2308
2309 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2310
2311         Implement ResizeObserver.
2312         https://bugs.webkit.org/show_bug.cgi?id=157743
2313
2314         Reviewed by Simon Fraser.
2315
2316         Support resizeObserverEnabled webPreferences.
2317
2318         * DumpRenderTree/TestOptions.cpp:
2319         (TestOptions::TestOptions):
2320         * DumpRenderTree/TestOptions.h:
2321         * DumpRenderTree/mac/DumpRenderTree.mm:
2322         (setWebPreferencesForTestOptions):
2323         * DumpRenderTree/win/DumpRenderTree.cpp:
2324         (enableExperimentalFeatures):
2325         * Scripts/webkitperl/FeatureList.pm:
2326         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2327
2328 2019-03-28  John Wilander  <wilander@apple.com>
2329
2330         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2331         https://bugs.webkit.org/show_bug.cgi?id=196281
2332         <rdar://problem/48938748>
2333
2334         Reviewed by Alex Christensen.
2335
2336         This patch adds the function isStatisticsHasLocalStorage() to the
2337         TestRunner. With it, the page can query the WebsiteDataStore in the
2338         UI process to make sure that it sees LocalStorage.
2339
2340         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2341         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2342         (WTR::TestRunner::isStatisticsHasLocalStorage):
2343         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2344         * WebKitTestRunner/TestController.cpp:
2345         (WTR::TestController::isStatisticsHasLocalStorage):
2346         * WebKitTestRunner/TestController.h:
2347         * WebKitTestRunner/TestInvocation.cpp:
2348         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2349
2350 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2351
2352         API::Data::createWithoutCopying should do a null check before calling CFRelease
2353         https://bugs.webkit.org/show_bug.cgi?id=196276
2354         <rdar://problem/48059859>
2355
2356         Reviewed by Alex Christensen.
2357
2358         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2359
2360         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2361         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2362         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2363         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2364         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2365         (TestWebKitAPI::TEST):
2366
2367 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2368
2369         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2370         https://bugs.webkit.org/show_bug.cgi?id=186276
2371
2372         Reviewed by Carlos Garcia Campos.
2373
2374         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2375         (webViewLoadChanged):
2376         (testWebResourceGetDataError):
2377         (testWebResourceGetDataEmpty):
2378         (beforeAll):
2379         (webViewloadChanged): Deleted.
2380
2381 2019-03-27  Andy Estes  <aestes@apple.com>
2382
2383         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2384         https://bugs.webkit.org/show_bug.cgi?id=196317
2385
2386         Reviewed by Dan Bernstein.
2387
2388         package-root copies built products into a staging directory using ditto(1), which does not
2389         follow symbolic links as it traverses a directory. Now that the files in
2390         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2391         itself, these become broken links when ditto'd into the staging directory.
2392
2393         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2394
2395         * Scripts/package-root:
2396
2397 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2398
2399         [ews-app] Update display text of Submit for ews analysis
2400         https://bugs.webkit.org/show_bug.cgi?id=196309
2401
2402         Reviewed by Dewei Zhu.
2403
2404         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2405
2406 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2407
2408         run-webkit-tests should check for leaks in WebKit processes
2409         <https://webkit.org/b/193772>
2410         <rdar://problem/46526680>
2411
2412         Reviewed by Ryosuke Niwa.
2413
2414         This works by doing the following:
2415         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2416           The list of child processes are returned one per line:
2417           process.name: pid
2418         - Run the "#LIST CHILD PROCESSES" command just before the
2419           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2420           processes on the ServerProcess object.
2421         - When the `--leaks` switch is handled, run check_for_leaks() on
2422           each child process after the main test harness.
2423
2424         * DumpRenderTree/mac/DumpRenderTree.mm:
2425         (handleControlCommand):
2426         - Use strncmp() instead of strcmp().
2427         - Add support for handling "#LIST CHILD PROCESSES" command.
2428
2429         * Scripts/webkitpy/port/base.py:
2430         (Port.check_for_leaks):
2431         * Scripts/webkitpy/port/darwin.py:
2432         (DarwinPort.check_for_leaks):
2433         - Rename redundant 'process_pid' argument to 'process_id'.
2434
2435         * Scripts/webkitpy/port/driver.py:
2436         (Driver.do_post_tests_work):
2437         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2438           longer the only command this sends to WebKitTestRunner.
2439         - If the `--leaks` switch is present, send the
2440           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2441           result using Port.set_webkit_processes().
2442         (Driver._parse_child_processes_output):
2443         - Add helper method to parse list of child process names and
2444           process IDs returned from WebKitTestRunner.
2445
2446         * Scripts/webkitpy/port/ios_device.py:
2447         (IOSDevicePort.check_for_leaks):
2448         - Rename redundant 'process_pid' argument to 'process_id'.
2449
2450         * Scripts/webkitpy/port/leakdetector.py:
2451         (LeakDetector._parse_leaks_output):
2452         - Return early if there is no leaks_output.
2453         (LeakDetector.check_for_leaks):
2454         - Rename redundant 'process_pid' argument to 'process_id'.
2455
2456         * Scripts/webkitpy/port/server_process.py:
2457         (ServerProcess.__init__):
2458         (ServerProcess.child_processes):
2459         (ServerProcess.set_child_processes):
2460         - Add instance variable to Port to store list of child process
2461           names and process IDs returned from WebKitTestRunner.
2462         (ServerProcess._start):
2463         - Clear self._child_processes.
2464         (ServerProcess.stop):
2465         - If self._child_processes is set, call
2466           self._port.check_for_leaks() for each child process.
2467
2468         * Scripts/webkitpy/port/server_process_unittest.py:
2469         (TrivialMockPort.check_for_leaks):
2470         - Rename redundant 'process_pid' argument to 'process_id'.
2471
2472         * Scripts/webkitpy/port/simulator_process.py:
2473         (SimulatorProcess.stop):
2474         - If self._child_processes is set, call
2475           self._port.check_for_leaks() for each child process.
2476
2477         * Scripts/webkitpy/port/watch_device.py:
2478         (WatchDevicePort.check_for_leaks):
2479         - Rename redundant 'process_pid' argument to 'process_id'.
2480
2481         * WebKitTestRunner/TestController.cpp:
2482         (WTR::TestController::dumpResponse):
2483         - Extract method from findAndDumpWorldLeaks() so that it may be
2484           reused by findAndDumpWebKitProcessIdentifiers().
2485         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2486         - Add method to output process name and process ID of both the
2487           WebContent and Networking processes.
2488         (WTR::TestController::findAndDumpWorldLeaks):
2489         - Fix missing newline in output when there were no abandoned
2490           documents.
2491         - Call dumpResponse() for extracted code.
2492         (WTR::TestController::handleControlCommand):
2493         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2494         - Use strncmp() instead of strcmp().
2495         - Call findAndDumpWebKitProcessIdentifiers() when
2496           "#LIST CHILD PROCESSES" command is sent.
2497         * WebKitTestRunner/TestController.h:
2498         (WTR::TestController::dumpResponse):
2499         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2500         - Declare methods.
2501
2502 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2503
2504         Unreviewed. Add GLib API test cases after r243434.
2505
2506         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2507         (testWebViewActiveURI):
2508         (serverCallback):
2509         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2510         (sendRequestCallback):
2511
2512 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2513
2514         Geolocation request not complete when watch request was started in a different web process
2515         https://bugs.webkit.org/show_bug.cgi?id=195996
2516
2517         Reviewed by Alex Christensen.
2518
2519         Add a test case.
2520
2521         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2522         (TestWebKitAPI::runJavaScriptAlert):
2523         (TestWebKitAPI::TEST):
2524
2525 2019-03-26  Keith Rollin  <krollin@apple.com>
2526
2527         Update the way generate-xcfilelists returns strings from functions
2528         https://bugs.webkit.org/show_bug.cgi?id=195975
2529         <rdar://problem/49040807>
2530
2531         Reviewed by Dean Jackson.
2532
2533         There are places where generate-xcfilelists executes assignments with
2534         statements like:
2535
2536             FOO=$(some_function)
2537
2538         where "some_function" return a string by echoing it. E.g.
2539
2540             some_function()
2541             {
2542                 echo "Hello, World"
2543             }
2544
2545         This is a common idiom, but it has a problem if "some_function" needs
2546         to call "exit" in an attempt to halt the entire script right then and
2547         there. Since "some_function" is called inside of $(), it's being
2548         executed in a sub-shell. Calling exit in that sub-shell simply exits
2549         that shell; it doesn't not exit the outer shell in which the main part
2550         of the script is still running. As such, the main script keeps
2551         executing when the intent was for the script to halt.
2552
2553         The solution to this is to use a different idiom for returning
2554         strings. The one we now is to pass in the name of the variable to
2555         receive the string result:
2556
2557             some_function()
2558             {
2559                 variable_name=$1
2560                 eval $variable_name ="Hello, World"
2561             }
2562
2563         The call site now looks like
2564
2565             some_function FOO
2566
2567         Because there's no invocation of a sub-shell, some_function can now
2568         call "exit" if it wants to, and the entire script will exit at that
2569         point.
2570
2571         * Scripts/generate-xcfilelists:
2572
2573 2019-03-26  Chris Dumez  <cdumez@apple.com>
2574
2575         Add basic layout test coverage for File Picker on iOS
2576         https://bugs.webkit.org/show_bug.cgi?id=196265
2577
2578         Reviewed by Wenson Hsieh.
2579
2580         Add layout test infrastructure to test the file picker on iOS.
2581
2582         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2583         (WTR::UIScriptController::dismissFilePicker):
2584         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2585         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2586         (WTR::UIScriptController::dismissFilePicker):
2587         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2588         * WebKitTestRunner/TestController.cpp:
2589         (WTR::TestController::createWebViewWithOptions):
2590         (WTR::updateTestOptionsFromTestHeader):
2591         * WebKitTestRunner/TestOptions.h:
2592         (WTR::TestOptions::hasSameInitializationOptions const):
2593         * WebKitTestRunner/ios/TestControllerIOS.mm:
2594         (overridePresentViewController):
2595         (WTR::TestController::platformInitialize):
2596         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2597         (WTR::UIScriptController::dismissFilePicker):
2598
2599 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2600
2601         Implement async paste method on UIWKInteractionViewProtocol
2602         https://bugs.webkit.org/show_bug.cgi?id=196267
2603         <rdar://problem/49236346>
2604
2605         Reviewed by Tim Horton.
2606
2607         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2608         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2609         are now a part of all iOS 12 internal SDKs.
2610
2611         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2612
2613         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2614         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2615
2616         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2617         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2618         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2619         * TestWebKitAPI/ios/UIKitSPI.h:
2620
2621 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2622
2623         [ews-build] Use PostgreSQL for ews.webkit.org database
2624         https://bugs.webkit.org/show_bug.cgi?id=196270
2625
2626         Reviewed by Lucas Forschler.
2627
2628         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2629
2630 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2631
2632         [ews] Reset simctl states on reboot
2633         https://bugs.webkit.org/show_bug.cgi?id=196260
2634
2635         Rubber-stamped by Aakash Jain.
2636
2637         * EWSTools/start-queue-mac.sh:
2638
2639 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2640
2641         [ews-build] Use PostgreSQL for ews-build database
2642         https://bugs.webkit.org/show_bug.cgi?id=196229
2643
2644         Reviewed by Lucas Forschler.
2645
2646         * BuildSlaveSupport/ews-build/master.cfg:
2647
2648 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2649
2650         [ews-build] Get master_hostname dynamically in master.cfg
2651         https://bugs.webkit.org/show_bug.cgi?id=196255
2652
2653         Reviewed by Lucas Forschler.
2654
2655         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2656         send events data in test mode.
2657
2658 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2659
2660         [ews-app] Set db_constraint to False for Foreign Keys
2661         https://bugs.webkit.org/show_bug.cgi?id=196252
2662
2663         Reviewed by Lucas Forschler.
2664
2665         * BuildSlaveSupport/ews-app/ews/models/build.py:
2666         * BuildSlaveSupport/ews-app/ews/models/step.py:
2667
2668 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2669
2670         [ews-build] is_test_mode_enabled should default to True
2671         https://bugs.webkit.org/show_bug.cgi?id=196248
2672
2673         Reviewed by Lucas Forschler.
2674
2675         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2676
2677 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2678
2679         [ews-app] Add webkitperl to ENABLED_QUEUES
2680         https://bugs.webkit.org/show_bug.cgi?id=196253
2681
2682         Reviewed by Lucas Forschler.
2683
2684         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2685
2686 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2687
2688         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2689         https://bugs.webkit.org/show_bug.cgi?id=196211
2690         rdar://problem/49110552
2691
2692         Reviewed by Tim Horton.
2693
2694         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2695         Make sure that EventSenderProxy always exists when running tests. We used to create
2696         it when resetting before the first test, which is a bit too late.
2697
2698         * WebKitTestRunner/TestController.h:
2699         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2700         (WTR::TestController::platformCreateWebView):
2701         (WTR::TestController::platformCreateOtherPage):
2702         (WTR::TestController::finishCreatingPlatformWebView):
2703         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2704         (WTR::PlatformWebView::PlatformWebView):
2705         Moved some code that made NSWindow use NSEvent during web view creation. We may
2706         need to move more if some other case us found, but this is enough for now.
2707
2708 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2709
2710         Unreviewed. Fix typo in GLib geolocation API after r243285.
2711
2712         gelocation -> geolocation.
2713
2714         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2715         (testGeolocationManagerWatchPosition):
2716
2717 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2718
2719         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2720         https://bugs.webkit.org/show_bug.cgi?id=196213
2721
2722         Reviewed by Geoff Garen.
2723
2724         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2725         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2726         (credentialWithIdentityAndKeychainPath):
2727         (-[ChallengeDelegate webView:didFinishNavigation:]):
2728         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2729         (TestWebKitAPI::TEST):
2730
2731 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2732
2733         Expected shouldn't assume its contained types are copyable
2734         https://bugs.webkit.org/show_bug.cgi?id=195986
2735
2736         Reviewed by JF Bastien.
2737
2738         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2739         (TestWebKitAPI::NonCopyable::operator== const):
2740         (TestWebKitAPI::NonCopyable::operator!= const):
2741         (TestWebKitAPI::TEST):
2742
2743 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2744
2745         Remove some now-unnecessary dynamic class lookup
2746         https://bugs.webkit.org/show_bug.cgi?id=196237
2747
2748         Reviewed by Simon Fraser.
2749
2750         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2751         (makeRequest):
2752         (TEST):
2753
2754 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2755
2756         Unreviewed, rolling out r243450.
2757
2758         AppleWin and WinCairo port builds get broken.
2759
2760         Reverted changeset:
2761
2762         "Add test for fix of #196095"
2763         https://bugs.webkit.org/show_bug.cgi?id=196097
2764         https://trac.webkit.org/changeset/243450
2765
2766 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2767
2768         Unreviewed, rolling out r243465.
2769         https://bugs.webkit.org/show_bug.cgi?id=196226
2770
2771         the test doesn't build (Requested by thorton on #webkit).
2772
2773         Reverted changeset:
2774
2775         "Do not terminate the NetworkProcess if a third party
2776         application sends a NSCredential with a SecIdentityRef"
2777         https://bugs.webkit.org/show_bug.cgi?id=196213
2778         https://trac.webkit.org/changeset/243465
2779
2780 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2781
2782         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2783         https://bugs.webkit.org/show_bug.cgi?id=196213
2784
2785         Reviewed by Geoff Garen.
2786
2787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2788         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2789         (credentialWithIdentityAndKeychainPath):
2790         (-[ChallengeDelegate webView:didFinishNavigation:]):
2791         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2792         (TestWebKitAPI::TEST):
2793
2794 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2795
2796         [ews-build] Gracefully handle missing patch_id in events
2797         https://bugs.webkit.org/show_bug.cgi?id=196216
2798
2799         Reviewed by Lucas Forschler.
2800
2801         * BuildSlaveSupport/ews-build/events.py:
2802
2803 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2804
2805         [ews-build] use lz4 compression for improving buildbot performance
2806         https://bugs.webkit.org/show_bug.cgi?id=196155
2807
2808         Reviewed by Lucas Forschler.
2809
2810         * BuildSlaveSupport/ews-build/master.cfg:
2811
2812 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2813
2814         Pull some API testing helper methods out of TestWKWebView
2815         https://bugs.webkit.org/show_bug.cgi?id=196212
2816
2817         Reviewed by Tim Horton.
2818
2819         Refactor some more API testing utility methods, so that they can be used in
2820         tests that do not use TestWKWebView.
2821
2822         * TestWebKitAPI/cocoa/TestWKWebView.h:
2823         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2824         (-[WKWebView loadTestPageNamed:]):
2825         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2826         (-[WKWebView synchronouslyLoadHTMLString:]):
2827         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2828         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2829         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2830         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2831         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2832
2833 2019-03-25  Jer Noble  <jer.noble@apple.com>
2834
2835         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2836         https://bugs.webkit.org/show_bug.cgi?id=196097
2837
2838         Reviewed by Eric Carlson.
2839
2840         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2841
2842         * DumpRenderTree/mac/DumpRenderTree.mm:
2843         (resetWebPreferencesToConsistentValues):
2844         * WebKitTestRunner/TestController.cpp:
2845         (WTR::TestController::resetPreferencesToConsistentValues):
2846
2847 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2848
2849         Pull IPadUserInterfaceSwizzler out into a separate header file
2850         https://bugs.webkit.org/show_bug.cgi?id=196193
2851
2852         Reviewed by Anders Carlsson.
2853
2854         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2855         be used in other API tests.
2856
2857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2858         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2859         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2860         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2861         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2862         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2863         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2864
2865 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2866
2867         Remove NavigatorContentUtils in WebCore/Modules
2868         https://bugs.webkit.org/show_bug.cgi?id=196070
2869
2870         Reviewed by Alex Christensen.
2871
2872         NavigatorContentUtils was to support the custom scheme spec [1].
2873         However, in WebKit side, no port has supported the feature in
2874         WebKit layer after EFL port was removed. So there has been the
2875         only IDL implementation of the NavigatorContentUtils in WebCore.
2876         So we don't need to keep the implementation in WebCore anymore.
2877
2878         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2879
2880         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2881
2882 2019-03-24  Andy Estes  <aestes@apple.com>
2883
2884         [watchOS] Remove unused Proximity Networking code
2885         https://bugs.webkit.org/show_bug.cgi?id=196188
2886
2887         Reviewed by Tim Horton.
2888
2889         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2890         (TEST):
2891
2892 2019-03-23  Keith Miller  <keith_miller@apple.com>
2893
2894         Refactor clz/ctz and fix getLSBSet.
2895         https://bugs.webkit.org/show_bug.cgi?id=196162
2896
2897         Reviewed by Saam Barati.
2898
2899         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2900
2901         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2902         (TestWebKitAPI::TEST):
2903
2904 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2905
2906         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2907         https://bugs.webkit.org/show_bug.cgi?id=196143
2908
2909         Reviewed by Michael Catanzaro.
2910
2911         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2912         directories.
2913
2914         * Scripts/webkitpy/style/checkers/cpp.py:
2915         (check_identifier_name_in_declaration):
2916         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2917         (WebKitStyleTest.test_names):
2918
2919 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2920
2921         [Flatpak] Manifest expanding fails for qt WPE extension
2922         https://bugs.webkit.org/show_bug.cgi?id=196148
2923
2924         Reviewed by Alex Christensen.
2925
2926         * flatpak/flatpakutils.py:
2927         (expand_submodules_recurse): The last recurse manifest expand
2928         iteration might lead to a single module so take it into account
2929         and don't try to recurse further.
2930
2931 2019-03-22  Chris Dumez  <cdumez@apple.com>
2932
2933         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2934         https://bugs.webkit.org/show_bug.cgi?id=195348
2935         <rdar://problem/48622090>
2936
2937         Reviewed by Alex Christensen.
2938
2939         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2940         to NO when test.options().shouldIgnoreMetaViewport is false.
2941
2942         * WebKitTestRunner/ios/TestControllerIOS.mm:
2943         (WTR::TestController::platformConfigureViewForTest):
2944
2945 2019-03-22  Chris Dumez  <cdumez@apple.com>
2946
2947         Prewarmed processes should be usable with any website data store
2948         https://bugs.webkit.org/show_bug.cgi?id=196104
2949
2950         Reviewed by Alex Christensen.
2951
2952         Add API test coverage.
2953
2954         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2955         (runInitialWarmedProcessUsedTest):
2956         (TEST):
2957
2958 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2959
2960         Back out local changes to Alex's Subversion working directory
2961
2962         They were accidentally committed.
2963
2964         * Scripts/webkitpy/common/system/abstractexecutive.py:
2965         (AbstractExecutive.wait_newest):
2966         * Scripts/webkitpy/common/system/executive.py:
2967         (Executive.running_pids):
2968         * Scripts/webkitpy/common/system/executive_mock.py:
2969         (MockExecutive.running_pids):
2970         * Scripts/webkitpy/common/system/executive_unittest.py:
2971         (ExecutiveTest.serial_test_running_pids):
2972         * Scripts/webkitpy/port/darwin.py:
2973         (DarwinPort.check_for_leaks):
2974         * Scripts/webkitpy/port/leakdetector.py:
2975         (LeakDetector.check_for_leaks):
2976         - This was the hack attached to Bug 193772.
2977
2978         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2979         (+[WebKitTestRunnerEvent mouseLocation]):
2980         - This works around a crash on an internal build.
2981
2982 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2983
2984         Fix the build after r243354
2985         https://bugs.webkit.org/show_bug.cgi?id=196138
2986         <rdar://problem/49145951>
2987
2988         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2989         (TEST):
2990         * TestWebKitAPI/ios/UIKitSPI.h:
2991
2992 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2993
2994         Adopt UIWKDocumentContext
2995         https://bugs.webkit.org/show_bug.cgi?id=196040
2996         <rdar://problem/48642440>
2997
2998         Reviewed by Ryosuke Niwa.
2999
3000         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3001         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3002         (makeRequest):
3003         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3004         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3005         (applyStyle):
3006         (TEST):
3007         Add tests for UIWKDocumentContext.
3008
3009         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3010         (TEST):
3011         (recursiveFindWKContentView): Deleted.
3012         * TestWebKitAPI/cocoa/TestWKWebView.h:
3013         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3014         (recursiveFindWKContentView):
3015         (-[TestWKWebView wkContentView]):
3016         * TestWebKitAPI/ios/UIKitSPI.h:
3017         Share the WKContentView finding code between tests.
3018
3019 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3020
3021         [iOS WK2] Turn on async overflow scrolling by default
3022         https://bugs.webkit.org/show_bug.cgi?id=196011
3023         rdar://problem/48453859
3024
3025         Reviewed by Antti Koivisto.
3026         
3027         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3028         since so many basic layout tests have different results when compositing is triggered for
3029         overflow.
3030         
3031         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3032
3033         * WebKitTestRunner/TestController.cpp:
3034         (WTR::TestController::resetPreferencesToConsistentValues):
3035
3036 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3037
3038         [ews-build] Retry API test in case of failures
3039         https://bugs.webkit.org/show_bug.cgi?id=196004
3040
3041         Reviewed by Lucas Forschler.
3042
3043         * BuildSlaveSupport/ews-build/steps.py:
3044         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3045         (CompileWebKitToT.doStepIf): Ditto.
3046         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3047         (ReRunAPITests): Re-run API tests.
3048         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3049         (RunAPITestsWithoutPatch): Run API tests without patch.
3050         (RunAPITestsWithoutPatch.doStepIf):
3051         (RunAPITestsWithoutPatch.hideStepIf):
3052         (RunAPITestsWithoutPatch.evaluateCommand):
3053         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3054         (AnalyzeAPITestsResults.start):
3055         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3056         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3057         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3058         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3059
3060 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3061
3062         [ews-build] Update queues configurations
3063         https://bugs.webkit.org/show_bug.cgi?id=196074
3064
3065         Reviewed by Dewei Zhu.
3066
3067         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3068         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3069
3070 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3071
3072         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3073         https://bugs.webkit.org/show_bug.cgi?id=195680
3074         <rdar://problem/48903534>
3075
3076         Unreviewed infrastructure fix.
3077
3078         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3079         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3080
3081 2019-03-21  Andy Estes  <aestes@apple.com>
3082
3083         [iOS] Apple Pay should be available in documents with no user agent scripts
3084         https://bugs.webkit.org/show_bug.cgi?id=196061
3085         <rdar://problem/48649391>
3086
3087         Reviewed by Brady Eidson.
3088
3089         Added API tests and related infrastructure.
3090
3091         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3092         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3093         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3094         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3095         (TestWebKitAPI::TEST):
3096         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3097         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3098         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3099         * TestWebKitAPI/cocoa/TestProtocol.mm:
3100         (-[TestProtocol startLoading]):
3101         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3102         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3103         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3104         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3105
3106 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3107
3108         REGRESSSION (r243297): webkitpy tests broken
3109         https://bugs.webkit.org/show_bug.cgi?id=196108
3110
3111         Reviewed by Aakash Jain.
3112
3113         r243297 updated contributors.json, which broke a few unit tests.
3114
3115         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3116         (IRCCommandTest.test_whois):
3117         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3118
3119 2019-03-21  Chris Dumez  <cdumez@apple.com>
3120
3121         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3122         https://bugs.webkit.org/show_bug.cgi?id=196041
3123         <rdar://problem/49083230>
3124
3125         Reviewed by Alex Christensen.
3126
3127         Add API test coverage.
3128
3129         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3130         (TEST):
3131
3132 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3133
3134         Add SPI to inform applications of WKContentRuleList actions
3135         https://bugs.webkit.org/show_bug.cgi?id=195965
3136         <rdar://problem/42664365>
3137
3138         Reviewed by Geoff Garen.
3139
3140         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3141         (TestWebKitAPI::allActionsForResourceLoad):
3142         (TestWebKitAPI::testRequest):
3143         (TestWebKitAPI::TEST_F):
3144         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3145         (Notification::description):
3146         (Notification::operator== const):
3147         (toVector):
3148         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3149         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3150         (makeContentRuleList):
3151         (TEST):
3152         (makeWarnContentRuleList): Deleted.
3153
3154 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3155
3156         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3157         https://bugs.webkit.org/show_bug.cgi?id=196088
3158
3159         Reviewed by Brian Burg.
3160
3161         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3162         Support checks when only one platform is specified. Also deprecate macosx() and
3163         force the use of macos() instead.
3164
3165         * Scripts/webkitpy/style/checkers/cpp.py:
3166         (check_min_versions_of_wk_api_available):
3167         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3168         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3169
3170 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3171
3172         Update status inactive committers' status to 'contributor'.
3173
3174         * Scripts/webkitpy/common/config/contributors.json:
3175
3176 2019-03-21  Xan Lopez  <xan@igalia.com>
3177
3178         [JSC][x86] Drop support for x87 floating point
3179         https://bugs.webkit.org/show_bug.cgi?id=194853
3180
3181         Reviewed by Don Olmstead.
3182
3183         Force SSE2 on x86/32bit builds.
3184
3185         * Scripts/webkitdirs.pm:
3186         (generateBuildSystemFromCMakeProject):
3187
3188 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3189
3190         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3191         https://bugs.webkit.org/show_bug.cgi?id=196073
3192
3193         Reviewed by Michael Catanzaro.
3194
3195         Add test cases to check functions and constructors with no arguments but receiving user data.
3196
3197         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3198         (checkUserData):
3199         (testJSCFunction):
3200         (fooCreateWithUserData):
3201         (testJSCClass):
3202
3203 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3204
3205         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3206
3207         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3208
3209         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3210
3211 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3212
3213         [GTK][WPE] Add API to provide geolocation information
3214         https://bugs.webkit.org/show_bug.cgi?id=195940
3215
3216         Reviewed by Michael Catanzaro.
3217
3218         Add a new test to check the new API.
3219
3220         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3221         (testGeolocationManagerCurrentPosition):
3222         (testGeolocationManagerWatchPosition):
3223         (beforeAll):
3224         (afterAll):
3225         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3226         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3227         (beforeAll): Ditto.
3228         * TestWebKitAPI/glib/CMakeLists.txt:
3229
3230 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3231
3232         [GLib] Returning G_TYPE_OBJECT from a method does not work
3233         https://bugs.webkit.org/show_bug.cgi?id=195574
3234
3235         Reviewed by Michael Catanzaro.
3236
3237         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3238
3239         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3240         (getGFile):
3241         (getParent):
3242         (createGString):
3243         (getGString):
3244         (getGStringCopyWillRaise):
3245         (getGStringCopy):
3246         (getGStringStr):
3247         (getGStringLen):
3248         (freeGString):
3249         (testJSCClass):
3250
3251 2019-03-20  Saam Barati  <sbarati@apple.com>
3252
3253         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3254         https://bugs.webkit.org/show_bug.cgi?id=195721
3255
3256         Reviewed by Filip Pizlo.
3257
3258         * Scripts/run-javascriptcore-tests:
3259
3260 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3261
3262         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3263         https://bugs.webkit.org/show_bug.cgi?id=196049
3264
3265         Reviewed by Tim Horton.
3266
3267         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3268         overflow scrolling in general, so rename it.
3269
3270         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3271
3272 2019-03-20  Daniel Bates  <dabates@apple.com>
3273
3274         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3275         https://bugs.webkit.org/show_bug.cgi?id=196031
3276         <rdar://problem/49078172>
3277
3278         Reviewed by Tim Horton.
3279
3280         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3281         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3282         same code path used when the Done button is pressed to dismiss the <select> picker.
3283
3284         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3285         (TestWebKitAPI::TEST):
3286
3287 2019-03-20  Chris Dumez  <cdumez@apple.com>
3288
3289         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3290         https://bugs.webkit.org/show_bug.cgi?id=196029
3291         <rdar://problem/48954651>
3292
3293         Reviewed by Tim Horton.
3294
3295         Add API test coverage.
3296
3297         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3298
3299 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3300
3301         [ews-build] Improve failure summary string for ApplyPatch step
3302         https://bugs.webkit.org/show_bug.cgi?id=195995
3303
3304         Reviewed by Alexey Proskuryakov.
3305
3306         * BuildSlaveSupport/ews-build/steps.py:
3307         (ApplyPatch.getResultSummary): Override getResultSummary.
3308
3309 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3310
3311         AX: Implement support for new meter ARIA role
3312         https://bugs.webkit.org/show_bug.cgi?id=195966
3313
3314         Reviewed by Chris Fleizach.
3315
3316         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3317         to AXLevelIndicator.
3318
3319         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3320
3321 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3322
3323         [WebAuthN] Implement FIDO AppID extension
3324         https://bugs.webkit.org/show_bug.cgi?id=143491
3325         <rdar://problem/48298273>
3326
3327         Reviewed by Brent Fulgham.
3328
3329         Add a test that covers the new flag of convertToU2fSignCommand.
3330
3331         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3332         (TestWebKitAPI::TEST):
3333         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3334         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3335         (TestWebKitAPI::TEST):
3336
3337 2019-03-19  Keith Rollin  <krollin@apple.com>
3338
3339         Add support for more platforms to generate-xcfilelists
3340         https://bugs.webkit.org/show_bug.cgi?id=195977
3341
3342         Reviewed by Alexey Proskuryakov.
3343
3344         generate-xcfilelists incorrectly complains when involved with building
3345         WebKit for iphonesimulator:
3346
3347             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3348             …
3349             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3350
3351         Address this by teaching generate-xcfilelists about more platforms.
3352
3353         * Scripts/generate-xcfilelists:
3354
3355 2019-03-19  John Wilander  <wilander@apple.com>
3356
3357         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3358         https://bugs.webkit.org/show_bug.cgi?id=195923
3359         <rdar://problem/49001272>
3360
3361         Reviewed by Alex Christensen.
3362
3363         This patch does the following to the TestRunner:
3364         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3365         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3366         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3367
3368         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3369         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3370         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3371         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3372         * WebKitTestRunner/TestController.cpp:
3373         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3374         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3375         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3376         * WebKitTestRunner/TestController.h:
3377         * WebKitTestRunner/TestInvocation.cpp:
3378         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3379
3380 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3381
3382         [CMake] Support more clang and gcc sanitizers
3383         https://bugs.webkit.org/show_bug.cgi?id=195956
3384
3385         Reviewed by Michael Catanzaro.
3386
3387         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3388
3389 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3390
3391         [ews-build] Improve summary for PrintConfiguration step
3392         https://bugs.webkit.org/show_bug.cgi?id=195945
3393
3394         Reviewed by Lucas Forschler.
3395
3396         * BuildSlaveSupport/ews-build/steps.py:
3397         (PrintConfiguration.getResultSummary): Override getResultSummary.
3398
3399 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3400
3401         [ews-build] Improve summary for CheckOutSource step
3402         https://bugs.webkit.org/show_bug.cgi?id=195963
3403
3404         Reviewed by Lucas Forschler.
3405
3406         * BuildSlaveSupport/ews-build/steps.py:
3407         (CheckOutSource.getResultSummary):
3408
3409 2019-03-19  Daniel Bates  <dabates@apple.com>
3410
3411         [iOS] Focus not preserved when switching between tabs
3412         https://bugs.webkit.org/show_bug.cgi?id=195820
3413         <rdar://problem/43614450>
3414
3415         Reviewed by Brent Fulgham.
3416
3417         Add tests to ensure that we restore focus when resigning and becoming first responder.
3418
3419         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3420         (TestWebKitAPI::TEST):
3421
3422 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3423
3424         Make WTFLogChannelState and WTFLogLevel enum classes
3425         https://bugs.webkit.org/show_bug.cgi?id=195904
3426
3427         Reviewed by Eric Carlson.
3428
3429         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3430         (TestWebKitAPI::TEST_F):
3431
3432 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3433
3434         [GStreamer][EME] Backported mssdemux protection data crash fix
3435         https://bugs.webkit.org/show_bug.cgi?id=195918
3436
3437         Reviewed by Philippe Normand.
3438
3439         * gstreamer/jhbuild.modules:
3440         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3441
3442 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3443
3444         Unreviewed, rolling out r243132.
3445
3446         Broke GTK build
3447
3448         Reverted changeset:
3449
3450         "Make WTFLogChannelState and WTFLogLevel enum classes"
3451         https://bugs.webkit.org/show_bug.cgi?id=195904
3452         https://trac.webkit.org/changeset/243132
3453
3454 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3455
3456         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3457
3458         * Scripts/webkitdirs.pm:
3459         (builtDylibPathForName): Adjust the shared library name that's changed
3460         with the API version bump in r243073.
3461
3462 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3463
3464         Make WTFLogChannelState and WTFLogLevel enum classes
3465         https://bugs.webkit.org/show_bug.cgi?id=195904
3466
3467         Reviewed by Eric Carlson.
3468
3469         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3470         (TestWebKitAPI::TEST_F):
3471
3472 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3473
3474         Disable flaky test added in r2431100
3475         https://webkit.org/b/195785
3476
3477         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3478         (TestWebKitAPI::TEST):
3479         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3480
3481 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3482
3483         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3484         https://bugs.webkit.org/show_bug.cgi?id=195916
3485
3486         Reviewed by Tim Horton.
3487
3488         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3489         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3490
3491 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3492
3493         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3494
3495         * Scripts/webkitpy/common/config/contributors.json:
3496
3497 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3498
3499         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3500         https://bugs.webkit.org/show_bug.cgi?id=195785
3501
3502         Reviewed by Geoffrey Garen.
3503
3504         * TestWebKitAPI/TCPServer.cpp: Added.
3505         (TestWebKitAPI::TCPServer::TCPServer):
3506         (TestWebKitAPI::TCPServer::~TCPServer):
3507         (TestWebKitAPI::TCPServer::socketBindListen):
3508         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3509         * TestWebKitAPI/TCPServer.h: Added.
3510         (TestWebKitAPI::TCPServer::port const):
3511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3512         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3513         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3514         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3515         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3516         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3517         (TestWebKitAPI::respondSlowly):
3518         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3519         (TestWebKitAPI::downloadAtRate):
3520         (TestWebKitAPI::TEST):
3521
3522 2019-03-18  Saam Barati  <sbarati@apple.com>
3523
3524         Add a plan file for JetStream 2
3525         https://bugs.webkit.org/show_bug.cgi?id=190734
3526
3527         Reviewed by Mark Lam.
3528
3529         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3530
3531 2019-03-18  Chris Dumez  <cdumez@apple.com>
3532
3533         Delay WebProcess launch until a load is triggered in a Web view
3534         https://bugs.webkit.org/show_bug.cgi?id=195758
3535         <rdar://problem/48126013>
3536
3537         Reviewed by Geoff Garen.
3538
3539         Add API test coverage. Also update some existing API tests to not expect
3540         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3541
3542         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3543         (TestWebKitAPI::TEST):
3544         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3545         (TestWebKitAPI::TEST):
3546         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3547         (TEST):
3548         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3549         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3550         (TEST):
3551         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3552         (TEST):
3553         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3554
3555 2019-03-18  Xan Lopez  <xan@igalia.com>
3556
3557         [CMake] Prevent potential warning when determining $architecture
3558         https://bugs.webkit.org/show_bug.cgi?id=195891
3559
3560         Reviewed by Michael Catanzaro.
3561
3562         It's possible for generateBuildSystemForCMakeProject to be called
3563         before determineArchitecture() is ever called. This will make the
3564         first eq check with $architecture to be bogus (and print a
3565         warning). Change that to an eq check with architecture(), which
3566         implicitly calls determineArchitecture() if needed, and change all
3567         the other similar cases in the method in the same way to prevent
3568         future bugs like this one.
3569
3570         * Scripts/webkitdirs.pm:
3571         (generateBuildSystemFromCMakeProject):
3572
3573 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3574
3575         [WPE] Tarballs generated with “make dist” cannot build documentation
3576         https://bugs.webkit.org/show_bug.cgi?id=195885
3577
3578         Reviewed by Carlos Garcia Campos.
3579
3580         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3581
3582 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3583
3584         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3585         https://bugs.webkit.org/show_bug.cgi?id=195883
3586
3587         Reviewed by Carlos Garcia Campos.
3588
3589         * gtkdoc/gtkdoc.py:
3590         (GTKDoc._run_command): When commands fail to run, include the full command line for
3591         the program invocation and the output it has generated on the standard error stream.
3592
3593 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3594
3595         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3596         https://bugs.webkit.org/show_bug.cgi?id=195786
3597
3598         Reviewed by Philippe Normand.
3599
3600         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3601         * wpe/jhbuild.modules: Ditto.
3602
3603 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3604
3605         [ews-build] Don't run clean builds on EWS builders
3606         https://bugs.webkit.org/show_bug.cgi?id=195851
3607
3608         Reviewed by Geoffrey Garen.
3609
3610         * BuildSlaveSupport/ews-build/factories.py:
3611
3612 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3613
3614         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3615         https://bugs.webkit.org/show_bug.cgi?id=195849
3616
3617         Reviewed by Chris Dumez.
3618
3619         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3620
3621         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3622         (runWebsiteDataStoreCustomPaths):
3623
3624 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3625
3626         webkitpy: Upload test results
3627         https://bugs.webkit.org/show_bug.cgi?id=195755
3628         <rdar://problem/48896182>
3629
3630         Reviewed by Aakash Jain.
3631
3632         Establish a new format for uploading results that is not tied to layout tests, apply
3633         that format to webkitpy tests.
3634
3635         * Scripts/webkitpy/common/checkout/scm/git.py:
3636         (Git.native_branch): Return what branch the current checkout is on.
3637         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3638         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3639         * Scripts/webkitpy/common/checkout/scm/svn.py:
3640         (SVN.native_branch): Ditto.
3641         * Scripts/webkitpy/common/system/platforminfo.py:
3642         (PlatformInfo.build_version): Return a build version for Mac.
3643         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3644         (MockPlatformInfo.__init__):
3645         (MockPlatformInfo.build_version):
3646         * Scripts/webkitpy/results: Added.
3647         * Scripts/webkitpy/results/__init__.py: Added.
3648         * Scripts/webkitpy/results/options.py: Added.
3649         (upload_options): OptParse list for upload options.
3650         * Scripts/webkitpy/results/upload.py: Added.
3651         (Upload): Class which enforces the upload format expected by the results server.
3652         (Upload.Expectations):
3653         (Upload.create_configuration):
3654         (Upload.create_commit):
3655         (Upload.create_details):
3656         (Upload.create_run_stats):
3657         (Upload.create_test_result):
3658         (Upload.__init__):
3659         (Upload.Encoder): Encode Upload object as json.
3660         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3661         * Scripts/webkitpy/results/upload_unittest.py: Added.
3662         * Scripts/webkitpy/test/main.py:
3663         (Tester._parse_args): Add upload arguments.
3664         (Tester._run_tests): Allow results to be uploaded.
3665         * Scripts/webkitpy/test/runner.py:
3666         (Runner.__init__): Record which tests were run, rather than just counting them.
3667         (Runner.handle):
3668         * Scripts/webkitpy/test/runner_unittest.py:
3669         (RunnerTest.test_run):
3670         * Scripts/webkitpy/thirdparty/__init__.py:
3671         (AutoinstallImportHook.find_module): Add requests auto-install.
3672         (AutoinstallImportHook._install_requests):
3673         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3674         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3675
3676 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3677
3678         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3679         https://bugs.webkit.org/show_bug.cgi?id=195810
3680
3681         Reviewed by Tim Horton.
3682
3683         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3684         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3685         ending certain layout tests.
3686
3687         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3688         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3689         (-[TestRunnerWKWebView dealloc]):
3690         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3691
3692         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3693         helper method when destroying the web view, and when resetting state between tests.
3694
3695         * WebKitTestRunner/ios/TestControllerIOS.mm:
3696         (WTR::TestController::platformResetStateToConsistentValues):
3697
3698         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3699
3700 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3701
3702         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3703         https://bugs.webkit.org/show_bug.cgi?id=190350
3704         <rdar://problem/45089503>
3705
3706         Reviewed by Geoffrey Garen.
3707
3708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3709         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3710         (TEST):
3711         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3712         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3713         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3714         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3715         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3716         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3717         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3718         (runTest):
3719         (createDirectories):
3720         (TEST):
3721         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3722         (TEST):
3723         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3724         (TEST):
3725
3726 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3727
3728         Add support to WebPage for getting the contents as an attributed string.
3729         https://bugs.webkit.org/show_bug.cgi?id=195636
3730         rdar://problem/45055697
3731
3732         Reviewed by Tim Horton.
3733
3734         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3735         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3736
3737 2019-03-15  Chris Dumez  <cdumez@apple.com>
3738
3739         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3740         https://bugs.webkit.org/show_bug.cgi?id=195747
3741
3742         Reviewed by Geoff Garen.
3743
3744         Add API test coverage.
3745
3746         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3747
3748 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3749
3750         Unreviewed, rolling out r242952.
3751
3752         Causing API failures on iOS Simulator
3753
3754         Reverted changeset:
3755
3756         "[PSON] Make sure the WebProcessCache is leverage when
3757         relaunching a process after termination"
3758         https://bugs.webkit.org/show_bug.cgi?id=195747
3759         https://trac.webkit.org/changeset/242952
3760
3761 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3762
3763         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3764         https://bugs.webkit.org/show_bug.cgi?id=195740
3765
3766         Reviewed by Ross Kirsling.
3767
3768         window.open doesn't work for WebKitBrowserWindow because it is not
3769         implemented yet.
3770
3771         1. Implemented createNewPage callback of WKPageUIClient.
3772         2. Changed MainWindow to take a BrowserWindow factory function
3773           instead of BrowserWindowType to be flexible to create
3774           BrowserWindow with extra settings.
3775         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3776           because it is not relevant with MainWindow anymore.
3777
3778         * MiniBrowser/win/Common.cpp:
3779         (parseCommandLine):
3780         * MiniBrowser/win/Common.h:
3781         (CommandLineOptions::CommandLineOptions):
3782         * MiniBrowser/win/MainWindow.cpp:
3783         (MainWindow::MainWindow):
3784         (MainWindow::create):
3785         (MainWindow::init):
3786         (MainWindow::WndProc):
3787         * MiniBrowser/win/MainWindow.h:
3788         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3789         (PrintWebUIDelegate::createWebViewWithRequest):
3790         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3791         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3792         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3793         (WebKitBrowserWindow::updateProxySettings):
3794         (WebKitBrowserWindow::createNewPage):
3795         * MiniBrowser/win/WebKitBrowserWindow.h:
3796         * MiniBrowser/win/WinMain.cpp:
3797         (wWinMain):
3798
3799 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3800
3801         Make it possible to test scrolling tree layer manipulation more easily
3802         https://bugs.webkit.org/show_bug.cgi?id=195780
3803
3804         Reviewed by Tim Horton.
3805         
3806         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3807         cuts off communication of scrolling tree scrolls back to the web process
3808         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3809         allows tests to trigger scrolls which run the scrolling tree layer positioning
3810         logic, but never get another commit from the web process that might mask
3811         scrolling tree bugs.
3812         
3813         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3814         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3815         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3816
3817         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3818         (WTR::UIScriptController::scrollUpdatesDisabled const):
3819         (WTR::UIScriptController::setScrollUpdatesDisabled):
3820         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3821         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3822         (WTR::UIScriptController::scrollUpdatesDisabled const):
3823         (WTR::UIScriptController::setScrollUpdatesDisabled):
3824         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3825         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3826         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3827         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3828         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3829         * WebKitTestRunner/ios/TestControllerIOS.mm:
3830         (WTR::TestController::platformResetStateToConsistentValues):
3831         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3832         (WTR::UIScriptController::scrollUpdatesDisabled const):
3833         (WTR::UIScriptController::setScrollUpdatesDisabled):
3834
3835 2019-03-14  Youenn Fablet  <youenn@apple.com>
3836
3837         Move IDB storage in private browsing mode to NetworkProcess
3838         https://bugs.webkit.org/show_bug.cgi?id=195602
3839
3840         Reviewed by Brady Eidson.
3841
3842         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3843         (TEST):
3844
3845 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3846
3847         [ews-build] Make descriptionDone messages more readable
3848         https://bugs.webkit.org/show_bug.cgi?id=195760
3849
3850         Reviewed by Lucas Forschler.
3851
3852         * BuildSlaveSupport/ews-build/steps.py:
3853         * BuildSlaveSupport/ews-build/steps_unittest.py:
3854
3855 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3856
3857         [ews-build] Generate status-bubble hover-over messages
3858         https://bugs.webkit.org/show_bug.cgi?id=195680
3859
3860         Reviewed by Lucas Forschler.
3861
3862         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3863         (StatusBubble):
3864         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3865         on hover-over.
3866         (StatusBubble._iso_time):
3867         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3868         hover-over message.
3869         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3870
3871 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3872
3873         [ews-app] Gracefully handle the case when state_string is None
3874         https://bugs.webkit.org/show_bug.cgi?id=195753
3875
3876         Reviewed by Lucas Forschler.
3877
3878         * BuildSlaveSupport/ews-app/ews/models/build.py:
3879         * BuildSlaveSupport/ews-app/ews/models/step.py:
3880
3881 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3882
3883         [ews-app] Status bubble display pending for currently running build step
3884         https://bugs.webkit.org/show_bug.cgi?id=195744
3885
3886         Reviewed by Lucas Forschler.
3887
3888         * BuildSlaveSupport/ews-build/events.py:
3889         (Events.stepStarted): If state_string is pending, replace it with step name.
3890
3891 2019-03-14  Chris Dumez  <cdumez@apple.com>
3892
3893         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3894         https://bugs.webkit.org/show_bug.cgi?id=195750
3895
3896         Reviewed by Geoffrey Garen.
3897
3898         Add API test coverage.
3899
3900         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3901         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3902         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3903         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3904
3905 2019-03-14  Chris Dumez  <cdumez@apple.com>
3906
3907         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3908         https://bugs.webkit.org/show_bug.cgi?id=195747
3909
3910         Reviewed by Geoff Garen.
3911
3912         Add API test coverage.
3913
3914         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3915
3916 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3917
3918         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3919         https://bugs.webkit.org/show_bug.cgi?id=195725
3920         <rdar://problem/48545062>
3921
3922         Reviewed by Tim Horton.
3923
3924         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3925         handler is nil.
3926
3927         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3928         (TestWebKitAPI::TEST):
3929
3930 2019-03-13  Sam Weinig  <sam@webkit.org>
3931
3932         Add utility function to allow easy reverse range-based iteration of a container
3933         https://bugs.webkit.org/show_bug.cgi?id=195542
3934
3935         Reviewed by Antti Koivisto.
3936
3937         * TestWebKitAPI/CMakeLists.txt:
3938         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3939         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3940         (TestWebKitAPI::TEST):
3941         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3942
3943 2019-03-13  Chris Dumez  <cdumez@apple.com>
3944
3945         Use a ServiceWorker process per registrable domain
3946         https://bugs.webkit.org/show_bug.cgi?id=195649
3947
3948         Reviewed by Youenn Fablet.
3949
3950         Update API test coverage.
3951
3952         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3953
3954 2019-03-13  Chris Dumez  <cdumez@apple.com>
3955
3956         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3957         https://bugs.webkit.org/show_bug.cgi?id=195684
3958         <rdar://problem/48294714>
3959
3960         Reviewed by Antti Koivisto.
3961
3962         Add API test coverage.
3963
3964         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3965
3966 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3967
3968         [ews-app] Remove unused patch view
3969         https://bugs.webkit.org/show_bug.cgi?id=195669
3970
3971         Reviewed by Lucas Forschler.
3972
3973         * BuildSlaveSupport/ews-app/ews/urls.py:
3974         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3975
3976 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3977
3978         [ews-app] Use Buildbot result code variables
3979         https://bugs.webkit.org/show_bug.cgi?id=195668
3980
3981         Reviewed by Alexey Proskuryakov.
3982
3983         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3984         (Buildbot): Added Buildbot result code variables.
3985         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3986         (StatusBubble._build_bubble): Used Buildbot result code variables.
3987
3988 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3989
3990         [Flatpak] Expand submodule recursively
3991         https://bugs.webkit.org/show_bug.cgi?id=195672
3992
3993         Building WPE with flatpak was impossible without that as it was raising an exception.
3994         Also update wpebackend-fdo to match what is built in jhbuild
3995
3996         Reviewed by Philippe Normand.
3997
3998         * flatpak/flatpakutils.py:
3999         (expand_submodules_recurse):
4000         (expand_manifest):
4001         * flatpak/org.webkit.WPEModules.yaml:
4002
4003 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4004
4005         [ews-app] status bubble should be hidden for certain builds
4006         https://bugs.webkit.org/show_bug.cgi?id=194597
4007
4008         Reviewed by Dewei Zhu.
4009
4010         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4011         (StatusBubble._build_bubble):
4012         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
4013         because the patch didn't have relevant changes.
4014         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
4015         in production yet.
4016
4017 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4018
4019         [Win] Fix a slew of simple clang-cl warnings.
4020         https://bugs.webkit.org/show_bug.cgi?id=195652
4021
4022         Reviewed by Don Olmstead.
4023
4024         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4025         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
4026
4027 2019-03-12  Justin Fan  <justin_fan@apple.com>
4028
4029         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4030         https://bugs.webkit.org/show_bug.cgi?id=195518
4031         <rdar://problem/46322356>
4032
4033         Reviewed by Myles C. Maxfield.
4034
4035         * DumpRenderTree/DerivedSources-input.xcfilelist:
4036         * DumpRenderTree/DerivedSources-output.xcfilelist:
4037
4038 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4039
4040         Unreviewed, rolling out r242825.
4041         https://bugs.webkit.org/show_bug.cgi?id=195648
4042
4043         "Broke webkitpy tests with my change to
4044         lldb_dump_class_layout.py" (Requested by rmorisset on
4045         #webkit).
4046
4047         Reverted changeset:
4048
4049         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4050         classes with suspicious padding"
4051         https://bugs.webkit.org/show_bug.cgi?id=195573
4052         https://trac.webkit.org/changeset/242825
4053
4054 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4055
4056         [ews-build] Show status bubbles while the patch is waiting in queue
4057         https://bugs.webkit.org/show_bug.cgi?id=195618
4058
4059         Reviewed by Lucas Forschler.
4060
4061         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4062         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4063         enabled in initial deployment.
4064         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4065         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4066         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4067         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4068         (StatusBubble._build_bubbles_for_patch):
4069
4070 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4071
4072         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
4073         https://bugs.webkit.org/show_bug.cgi?id=195573
4074
4075         Reviewed by Simon Fraser.
4076
4077         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
4078
4079         * Scripts/dump-class-layout:
4080         (main):
4081         * lldb/lldb_dump_class_layout.py:
4082         (ClassLayout.__init__):
4083         (ClassLayout._compute_padding_recursive):
4084         (LLDBDebuggerInstance.dump_layout_for_classname):
4085         (LLDBDebuggerInstance):
4086         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
4087         (LLDBDebuggerInstance.layout_for_classname): Deleted.
4088
4089 2019-03-12  Chris Dumez  <cdumez@apple.com>
4090
4091         Device Orientation access permission should be denied unless explicitly granted by the client
4092         https://bugs.webkit.org/show_bug.cgi?id=195625
4093
4094         Reviewed by Youenn Fablet.
4095
4096         add API test coverage.
4097
4098         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4099         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
4100         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
4101         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
4102         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4103         (runDeviceOrientationTest):
4104         (TEST):
4105         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4106         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4107
4108 2019-03-12  Jer Noble  <jer.noble@apple.com>
4109
4110         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
4111         https://bugs.webkit.org/show_bug.cgi?id=195137
4112         <rdar://problem/48810307>
4113
4114         Reviewed by Eric Carlson.
4115
4116         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
4117         (TestWebKitAPI::TEST):
4118
4119 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4120
4121         [ews-build] Change urls from uat to production
4122         https://bugs.webkit.org/show_bug.cgi?id=195566
4123
4124         Reviewed by Lucas Forschler.
4125
4126         * BuildSlaveSupport/ews-app/ews/config.py:
4127         * BuildSlaveSupport/ews-build/events.py:
4128         * BuildSlaveSupport/ews-build/steps.py:
4129
4130 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4131
4132         [ews-build] change max_builds for local-worker to 1
4133         https://bugs.webkit.org/show_bug.cgi?id=195568
4134
4135         Reviewed by Lucas Forschler.
4136
4137         * BuildSlaveSupport/ews-build/loadConfig.py:
4138
4139 2019-03-12  Tim Horton  <timothy_horton@apple.com>
4140
4141         Fix the build
4142
4143         * TestRunnerShared/spi/PencilKitTestSPI.h:
4144         * TestWebKitAPI/ios/PencilKitTestSPI.h:
4145
4146 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4147
4148         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
4149         https://bugs.webkit.org/show_bug.cgi?id=194131
4150
4151         Reviewed by Michael Catanzaro.
4152
4153         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4154         (uriChanged):
4155         (testUnfinishedSubresourceLoad):
4156         (serverCallback):
4157         (beforeAll):
4158
4159 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4160
4161         WTF::Expected should use std::addressof instead of operator&
4162         https://bugs.webkit.org/show_bug.cgi?id=195604
4163
4164         Reviewed by Myles Maxfield.
4165
4166         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4167         (TestWebKitAPI::Unique::Unique):
4168         (TestWebKitAPI::Unique::operator&):
4169         (TestWebKitAPI::TEST):
4170
4171 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
4172
4173         Add Optional to Forward.h.
4174         https://bugs.webkit.org/show_bug.cgi?id=195586
4175
4176         Reviewed by Darin Adler.
4177
4178         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
4179         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
4180         Remove unnecessary includes from headers.
4181
4182 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
4183
4184         Add testing API to hit-test and scroll overflow scrollers
4185         https://bugs.webkit.org/show_bug.cgi?id=195278
4186
4187         Reviewed by Antti Koivisto.
4188         
4189         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
4190         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
4191         
4192         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
4193
4194         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4195         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4196         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4197         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4198         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4199         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4200         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4201         (WTR::enclosingScrollViewIncludingSelf):
4202         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4203
4204 2019-03-11  Tim Horton  <timothy_horton@apple.com>
4205
4206         API test WebKit.RequestTextInputContext fails on iOS
4207         https://bugs.webkit.org/show_bug.cgi?id=195585
4208
4209         Reviewed by Wenson Hsieh and Simon Fraser.
4210
4211         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4212         (applyStyle):
4213         (TEST):
4214         Add a viewport, so that the coordinates match up on iOS.
4215         Scroll by moving the UIScrollView's contentOffset.
4216
4217 2019-03-11  Chris Dumez  <cdumez@apple.com>
4218
4219         Assert in WebPageProxy::suspendCurrentPageIfPossible()
4220         https://bugs.webkit.org/show_bug.cgi?id=195506
4221         <rdar://problem/48733477>
4222
4223         Reviewed by Alex Christensen.
4224
4225         Add API test coverage.
4226
4227         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4228
4229 2019-03-11  Shawn Roberts  <sroberts@apple.com>
4230
4231         Adding myself to contributors.json
4232
4233         Unreviewed, addming myself to contributors.json .
4234
4235         * Scripts/webkitpy/common/config/contributors.json:
4236
4237 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4238
4239         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
4240         https://bugs.webkit.org/show_bug.cgi?id=195511
4241         <rdar://problem/44873269>
4242
4243         Reviewed by Darin Adler.
4244
4245         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
4246         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
4247         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
4248         (TEST_F):
4249
4250 2019-03-11  Chris Dumez  <cdumez@apple.com>
4251
4252         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
4253         https://bugs.webkit.org/show_bug.cgi?id=195561
4254
4255         Reviewed by Youenn Fablet.
4256
4257         Make sure the JS in the test requests for permission to receive device orientation events.
4258
4259         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4260
4261 2019-03-11  Youenn Fablet  <youenn@apple.com>
4262
4263         Allow storage quota increase by default in WTR
4264         https://bugs.webkit.org/show_bug.cgi?id=195541
4265
4266         Reviewed by Geoffrey Garen.
4267
4268         Allow storage quota increase by default in WTR.
4269         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
4270         Use this for tests that explicitly need cache increase.
4271
4272         Instead of increasing quota by 2, make sure the next request is
4273         granted by adding all given parameters.
4274
4275         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4276         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4277         (WTR::TestRunner::setAllowStorageQuotaIncrease):
4278         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
4279         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4280         * WebKitTestRunner/TestController.cpp:
4281         (WTR::TestController::setAllowStorageQuotaIncrease):
4282         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
4283         * WebKitTestRunner/TestController.h:
4284         * WebKitTestRunner/TestInvocation.cpp:
4285         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4286         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4287         (WTR::TestController::cocoaResetStateToConsistentValues):
4288         (WTR::TestController::setAllowStorageQuotaIncrease):
4289         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
4290         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
4291         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
4292
4293 2019-03-11  Xan Lopez  <xan@igalia.com>
4294
4295         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
4296         https://bugs.webkit.org/show_bug.cgi?id=194147
4297
4298         Reviewed by Michael Saboff.
4299
4300         To make --32-bit work correctly on Linux/64bit we need to:
4301
4302         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
4303         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
4304         unfortunately CMake only allows us to do this during
4305         crosscompilation, which is overkill here.
4306         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
4307         pkg-config detection module uses the x86 .pc files instead of the
4308         x86_64 ones.
4309         - Set the -m32 flags for the compiler.
4310
4311         * Scripts/webkitdirs.pm:
4312         (generateBuildSystemFromCMakeProject):
4313
4314 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
4315
4316         Add MotionMark-1.1 plan file for run-benchmark script.
4317         https://bugs.webkit.org/show_bug.cgi?id=195481
4318
4319         Rubber-stamped by Darin Adler.
4320