[Qt] Fix incremental builds with all-in-one-files and gccdepends
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-19  Simon Hausmann  <simon.hausmann@digia.com>
2
3         [Qt] Fix incremental builds with all-in-one-files and gccdepends
4
5         Reviewed by Tor Arne Vestbø.
6
7         Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
8         are not only created for header files but also for .cpp files. AllInOne.cpp files
9         include other .cpp files, and when those are removed we need those dummy rules to
10         avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
11
12         * qmake/config.tests/gccdepends/empty.cpp:
13         (main):
14         * qmake/config.tests/gccdepends/gccdepends.pro:
15         * qmake/mkspecs/features/default_pre.prf:
16
17 2012-09-19  Rick Byers  <rbyers@chromium.org>
18
19         Do touch adjustment on GestureTapDown
20         https://bugs.webkit.org/show_bug.cgi?id=96677
21
22         Reviewed by Antonio Gomes.
23
24         Allow radius to be set for GestureTapDown events.
25         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
26         (EventSender::gestureEvent):
27
28 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
29
30         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
31         https://bugs.webkit.org/show_bug.cgi?id=97100
32
33         Reviewed by Gyuyoung Kim.
34
35         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
36         preference, in order to match WebKitTestRunner functionality.
37
38         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
39         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
40         * DumpRenderTree/efl/TestRunnerEfl.cpp:
41         (TestRunner::overridePreference):
42
43 2012-09-18  Kangil Han  <kangil.han@samsung.com>
44
45         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
46         https://bugs.webkit.org/show_bug.cgi?id=96181
47
48         Reviewed by Daniel Bates.
49
50         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
51
52         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
53         (new):
54         (_parseLicenseBlock):
55         (_parseLicenseBlockFromFile):
56         (_defaultLicenseBlock):
57         (_licenseBlock):
58         (_generateHeaderFile):
59         (_generateImplementationFile):
60
61 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
62
63         Title string should be changed when document.title is set to ''.
64         https://bugs.webkit.org/show_bug.cgi?id=96793
65
66         Reviewed by Kenneth Rohde Christiansen.
67
68         Change dump format of dumpTitleChanges more understandable.
69         Uses single quotation marks for the title string.
70
71         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
72         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
73         * DumpRenderTree/chromium/WebViewHost.cpp:
74         (WebViewHost::didReceiveTitle):
75         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
76         (DumpRenderTreeChrome::onFrameTitleChanged):
77         * DumpRenderTree/gtk/DumpRenderTree.cpp:
78         (webViewTitleChanged):
79         * DumpRenderTree/mac/FrameLoadDelegate.mm:
80         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
81         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
82         (WebCore::DumpRenderTree::titleChanged):
83         * DumpRenderTree/win/FrameLoadDelegate.cpp:
84         (FrameLoadDelegate::didReceiveTitle):
85         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
86         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
87         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
88         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
89
90 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
91
92         EWS shouldn't sleep if there are new patches in its queue
93         https://bugs.webkit.org/show_bug.cgi?id=83038
94
95         Reviewed by Eric Seidel.
96
97         EWS tries to process a security patch. Of course it can't, because the EWS isn't
98         the member of the security group. But the problem is that after it can't process
99         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
100         and push the security patch to the end of the queue.
101         Now it stays in the loop until it finds a patch or the queue gets empty.
102
103         * Scripts/webkitpy/tool/commands/queues.py:
104         (AbstractPatchQueue._next_patch):
105         * Scripts/webkitpy/tool/commands/queues_unittest.py:
106         (AbstractPatchQueueTest.test_next_patch):
107
108 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
109
110         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
111         https://bugs.webkit.org/show_bug.cgi?id=97014
112
113         Reviewed by Kenneth Rohde Christiansen.
114
115         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
116         be used for literals rather than WTF::StringBuilder::append().
117
118         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
119         (WTR::InjectedBundle::booleanForKey):
120
121 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
122
123         Update my e-mail address.
124
125         * Scripts/webkitpy/common/config/committers.py:
126
127 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
128
129         Update my e-mail address.
130
131         Unreviewed.
132
133         * Scripts/webkitpy/common/config/committers.py:
134
135 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
136
137         [Qt] qt_webkit.pri should not be listed in Tools.pro
138
139         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
140
141         Since r128751 the module pri file is auto-generated
142         but it was still listed in OTHER_FILES.
143
144         * Tools.pro: Remove unneeded line.
145
146 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
147
148         [Qt] Fix build with some versions of the gold linker
149
150         Reviewed by Tor Arne Vestbø.
151
152         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
153         Instead run a compile/link test first to see if it works.
154
155         * qmake/config.tests/gnuld/gnuld.pro: Added.
156         * qmake/config.tests/gnuld/main.cpp: Added.
157         (main):
158         * qmake/mkspecs/features/unix/default_post.prf:
159
160 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
161
162         [Qt] Remove forced use of gold.
163
164         Reviewed by Tor Arne Vestbø.
165
166         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
167         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
168         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
169
170         * qmake/mkspecs/features/unix/default_post.prf:
171
172 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
173
174         [Qt] Prospective Qt/Windows cross-compiling fix
175
176         Reviewed by Tor Arne Vestbø.
177
178         The win32 scope is not set when cross-compiling from Linux to Windows.
179
180         * qmake/mkspecs/features/functions.prf:
181
182 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
183
184         [EFL] Remove background view on EWebLauncher and MiniBrowser
185         https://bugs.webkit.org/show_bug.cgi?id=96905
186
187         Reviewed by Gyuyoung Kim.
188
189         The size of webview was changed after adding url bar.
190         And the background view is not necessary anymore, since it was used for debugging back in the day.
191
192         * EWebLauncher/main.c:
193         (_ELauncher):
194         (on_ecore_evas_resize):
195         (browserCreate):
196         * MiniBrowser/efl/main.c:
197         (_MiniBrowser):
198         (on_ecore_evas_resize):
199         (browserCreate):
200
201 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
202
203         [GTK] run-webkit-tests unable to find TestExpectations for WK2
204         https://bugs.webkit.org/show_bug.cgi?id=96998
205
206         Reviewed by Philippe Normand.
207
208         We should look for TestExpectations files in all the locations where
209         we currently look for Skipped files. This will allow
210         run-webkit-tests to look for TestExpectations files in
211         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
212
213         * Scripts/webkitpy/layout_tests/port/gtk.py:
214         (GtkPort.expectations_files):
215
216 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
217
218         [Qt] Fix build without the QtQuick module
219
220         Reviewed by Simon Hausmann.
221
222         * qmake/mkspecs/features/features.prf:
223
224 2012-09-18  Stephanie Lewis  <slewis@apple.com>
225
226         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
227
228         Unreviewed.
229
230         * DumpRenderTree/mac/DumpRenderTree.mm:
231         (poseAsClass):
232
233 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
234
235         Unreviewed update of email addresses for Berlin QtWebKit office.
236
237         * Scripts/webkitpy/common/config/committers.py:
238
239 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
240
241         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
242         https://bugs.webkit.org/show_bug.cgi?id=96899
243
244         Reviewed by Martin Robinson.
245
246         When overriding the 'WebKitDisplayImageKey' preference, use the
247         'auto-load-images' property of WebKitWebSettings as the property which
248         should be updated with the corresponding preference value.
249
250         * DumpRenderTree/gtk/DumpRenderTree.cpp:
251         (resetDefaultsToConsistentValues):
252         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
253         (TestRunner::overridePreference):
254
255 2012-09-17  Pratik Solanki  <psolanki@apple.com>
256
257         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
258         https://bugs.webkit.org/show_bug.cgi?id=96973
259
260         Reviewed by Dan Bernstein.
261
262         * DumpRenderTree/mac/Configurations/Base.xcconfig:
263         * WebKitTestRunner/Configurations/Base.xcconfig:
264         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
265
266 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
267
268         nrwt: remove "unexpected EOF" warnings
269         https://bugs.webkit.org/show_bug.cgi?id=96970
270
271         Reviewed by Ojan Vafai.
272
273         After debugging this a bit, it looks like there aren't any cases
274         that I can reproduce where a read() of zero indicates something
275         actually wrong; either it is a prelude to a crash, or a false
276         negative. So, I'm removing these warnings and adding a comment.
277
278         * Scripts/webkitpy/layout_tests/port/server_process.py:
279         (ServerProcess._wait_for_data_and_update_buffers_using_select):
280
281 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
282
283         [chromium] ASAN bot is crashing at the end of the run
284         https://bugs.webkit.org/show_bug.cgi?id=96967
285
286         Reviewed by Abhishek Arya.
287
288         The ASAN bot is crashing attempting to decode some output into
289         UTF-8; there's no reason to do this, so let's not do this and
290         see if something else is going on as well.
291
292         * Scripts/webkitpy/layout_tests/port/chromium.py:
293         (ChromiumPort._get_crash_log):
294
295 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
296
297         nrwt: --results-directory isn't getting printed properly
298         https://bugs.webkit.org/show_bug.cgi?id=96965
299
300         Reviewed by Ojan Vafai.
301
302         options.results_directory isn't actually initialized with the
303         default values until after we call print_config(), so this
304         changes things to print the value directly.
305
306         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
307         (run):
308         * Scripts/webkitpy/layout_tests/views/printing.py:
309         (Printer.print_config):
310         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
311         (Testprinter.test_print_config):
312
313 2012-09-17  Rob Buis  <rbuis@rim.com>
314
315         [BlackBerry] Enable VIDEO_TRACK
316         https://bugs.webkit.org/show_bug.cgi?id=96949
317
318         Reviewed by Antonio Gomes.
319
320         * Scripts/webkitperl/FeatureList.pm:
321
322 2012-09-17  Rick Byers  <rbyers@chromium.org>
323
324         Add handling of new GestureTapCancel in DRT
325
326         https://bugs.webkit.org/show_bug.cgi?id=96183
327
328         Reviewed by Antonio Gomes.
329
330         * DumpRenderTree/chromium/TestWebPlugin.cpp:
331         (TestWebPlugin::handleInputEvent):
332         * DumpRenderTree/chromium/EventSender.cpp:
333         (EventSender::gestureTapCancel):
334
335 2012-09-17  Philip Rogers  <pdr@google.com>
336
337         Teach style checker about preprocessor directive indentation rules
338         https://bugs.webkit.org/show_bug.cgi?id=96874
339
340         Reviewed by Adam Barth.
341
342         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
343         This is not explicit in our style guide but is generally followed in our code.
344         Searching for violations in our codebase shows these are rarely indented:
345             #include - indented in 6 files
346             #ifdef - indented in 0 files
347             #ifndef - indented in 1 file
348             #define - indented in 11 files
349             #if - indented in 7 files
350
351         * Scripts/webkitpy/style/checkers/cpp.py:
352         (check_directive_indentation):
353
354             This is the simple test where we look for spaces followed by a #.
355
356         (check_style):
357         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
358
359             A few tests needed to be modified because they had unintentionally indented
360             preprocessor directives.
361
362         (CppStyleTest.test_build_class.Foo):
363         (CppStyleTest.test_build_class):
364         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
365         (WebKitStyleTest.test_line_breaking):
366         (WebKitStyleTest.test_directive_indentation):
367
368 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
369
370         [Qt] Auto-generate the module pri file for QtWebKit
371
372         Reviewed by Simon Hausmann.
373
374         * qmake/qt_webkit.pri: Removed.
375
376 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
377
378         nrwt: --additional-platform-dir is broken on chromium ports
379         https://bugs.webkit.org/show_bug.cgi?id=96840
380
381         Reviewed by Ojan Vafai.
382
383         Looks like I broke this when cleaning things up as part of
384         adding ML support. Fixing and adding a test.
385
386         * Scripts/webkitpy/layout_tests/port/chromium.py:
387         (ChromiumPort.default_baseline_search_path):
388         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
389         (ChromiumAndroidPort.default_baseline_search_path):
390         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
391         (ChromiumLinuxPort.default_baseline_search_path):
392         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
393         (ChromiumMacPort.__init__):
394         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
395         (ChromiumWinPort.setup_environ_for_server):
396         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
397         (test_check_build):
398         (test_additional_platform_directory):
399
400 2012-09-13  Stephanie Lewis  <slewis@apple.com>
401
402         mac-future ignores previous platform TestExpectations.
403         https://bugs.webkit.org/show_bug.cgi?id=96718.
404
405         Reviewed by Dirk Pranke.
406
407         TestExpectations match an expectation's configuraton against a list of configurations that are 
408         valid for that port.  That list does not contain mac-future so none of the expectations can be
409         applied.
410
411         * Scripts/webkitpy/layout_tests/port/apple.py:
412         (ApplePort._generate_all_test_configurations):
413
414 2012-09-14  Adam Barth  <abarth@webkit.org>
415
416         Remove webkitPostMessage
417         https://bugs.webkit.org/show_bug.cgi?id=96577
418
419         Reviewed by Ojan Vafai.
420
421         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
422
423         * Scripts/webkitperl/FeatureList.pm:
424         * qmake/mkspecs/features/features.pri:
425
426 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
427
428         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
429         https://bugs.webkit.org/show_bug.cgi?id=96817
430
431         Reviewed by Kenneth Rohde Christiansen.
432
433         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
434         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
435         got overlooked when adding logging elsewhere.
436
437 2012-09-14  Peter Beverloo  <peter@chromium.org>
438
439         [Chromium] Build fix for DumpRenderTree following r128628
440         https://bugs.webkit.org/show_bug.cgi?id=96808
441
442         Reviewed by Tony Chang.
443
444         When building DumpRenderTree from the Chromium project, a compile error
445         shows up because including the header ForwardIOStreamsAndroid.h cannot
446         be located. TestWebKitAPI does this correctly.
447
448         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
449
450 2012-09-14  Dana Jansens  <danakj@chromium.org>
451
452         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
453         https://bugs.webkit.org/show_bug.cgi?id=96805
454
455         Reviewed by Dirk Pranke.
456
457         * Scripts/webkitpy/common/config/committers.py:
458         * Scripts/webkitpy/common/config/watchlist:
459
460 2012-09-14  Peter Beverloo  <peter@chromium.org>
461
462         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
463         https://bugs.webkit.org/show_bug.cgi?id=96687
464
465         Reviewed by Tony Chang.
466
467         Android's DumpRenderTree currently supports these arguments, implemented
468         as part of TestShellAndroid:
469         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
470
471         They're used by the layout test runner to get the STDOUT and STDERR while
472         a layout test run is in process, which is a safer alternative to parsing
473         all the logcat output manually. The implementation can be seen here:
474         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
475
476         This patch generalizes parsing of and applying the effects of these arguments
477         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
478         After this patch, this will make it possible to pull out the output-reading
479         code from Android's layout test port and generalize it so it can be re-used
480         in the new test-runner for the other two test suites.
481
482         This has no effect when compiling and running these tests as part of Chromium
483         code, which has a much more advanced test-runner that does parse complete log
484         output, but also directly depends on code licensed under Apache 2.
485
486         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
487         * DumpRenderTree/chromium/TestShellAndroid.cpp:
488         (platformInit):
489         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
490
491 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
492
493         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
494         https://bugs.webkit.org/show_bug.cgi?id=96656
495
496         Reviewed by Adam Barth.
497
498         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
499         macros in 1 line.
500
501         * Scripts/webkitpy/style/checkers/cpp.py:
502         (check_style.definitions):
503         (check_style): Add rule.
504         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
505         (WebKitStyleTest.test_line_breaking): Add unittest.
506
507 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
508
509         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
510         https://bugs.webkit.org/show_bug.cgi?id=57570
511
512         Reviewed by Kenneth Rohde Christiansen.
513
514         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
515         and dump the information expected by the test cases.
516
517         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
518         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
519         (WTR::InjectedBundle::beginTesting): Explicitly set the default
520         database quota.
521         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
522         (WTR::securityOriginToStr): New convenience function to convert
523         a security origin to the string expected in test results.
524         (WTR):
525         (WTR::InjectedBundlePage::InjectedBundlePage):
526         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
527         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
528         refactoring to share code with didExceedDatabaseQuota.
529         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
530         (InjectedBundlePage):
531         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
532         (WTR::TestRunner::TestRunner):
533         * WebKitTestRunner/InjectedBundle/TestRunner.h:
534         (WTR::TestRunner::dumpDatabaseCallbacks):
535         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
536         (TestRunner):
537
538 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
539
540         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
541
542         Rubber-stamped by Simon Hausmann.
543
544         * qmake/mkspecs/features/default_post.prf:
545
546 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
547
548         [Qt] Remove old cruft from the qmake build system
549
550         Rubber-stamped by Simon Hausmann.
551
552         * DumpRenderTree/qt/DumpRenderTree.pro:
553         * qmake/mkspecs/features/default_post.prf:
554
555 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
556
557         [Qt] Enable force_static_libs_as_shared for development
558
559         Not enabled for buildbots or production-builds (part of Qt5)
560
561         Reviewed by Simon Hausmann.
562
563         * qmake/mkspecs/features/default_post.prf:
564
565 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
566
567         [Qt] Make force_static_libs_as_shared work on Mac OS
568
569         We had to move a few LIBS += around that were in the wrong place,
570         and not caught when everything was just linked into the final
571         QtWebKit library.
572
573         Reviewed by Simon Hausmann.
574
575         * qmake/mkspecs/features/default_post.prf:
576         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
577
578 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
579
580         [Qt] Fix build of WTR on Windows
581
582         Reviewed by Tor Arne Vestbø.
583
584         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
585         With qmake's unix makefile generator as well as with the MingW generator,
586         the directory where the pro file lives (WTR/) is automatically added to
587         the include search path, but not so with MSVC. Instead of relying on qmake's
588         implicit feature here, add WTR/ explicitly to the include search path.
589
590         * WebKitTestRunner/Target.pri:
591
592 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
593
594         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
595         https://bugs.webkit.org/show_bug.cgi?id=42691
596
597         Reviewed by Kenneth Rohde Christiansen.
598
599         Add implementation for testrunner.setStopProvisionalFrameLoads()
600         in WebKitTestRunner.
601
602         Original patch by Alexey Proskuryakov.
603
604         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
605         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
606         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
607         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
608         (WTR::TestRunner::TestRunner):
609         * WebKitTestRunner/InjectedBundle/TestRunner.h:
610         (TestRunner):
611         (WTR::TestRunner::setStopProvisionalFrameLoads):
612         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
613
614 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
615
616         [Qt] Fix handling of debug/release/debug_and_release/build_all
617
618         We now pick up the defaults from Qt, in default_pre (CONFIG already
619         contains the appropriate values for debug and release). We then let
620         the command line arguments to qmake, or the project files themselves,
621         override the configuration, and finally we sanitize the configuration
622         in default_post.
623
624         Reviewed by Simon Hausmann.
625
626         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
627         * Scripts/webkitdirs.pm:
628         (buildQMakeProjects):
629         * qmake/mkspecs/features/default_post.prf:
630         * qmake/mkspecs/features/default_pre.prf:
631         * qmake/mkspecs/features/mac/default_pre.prf:
632
633 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
634
635         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
636         https://bugs.webkit.org/show_bug.cgi?id=42687
637
638         Reviewed by Kenneth Rohde Christiansen.
639
640         Implement testRunner.setTabKeyCyclesThroughElements for
641         WebKitTestRunner.
642
643         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
644         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
645         (WTR::InjectedBundle::beginTesting):
646         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
647         (WTR::TestRunner::setTabKeyCyclesThroughElements):
648         (WTR):
649         * WebKitTestRunner/InjectedBundle/TestRunner.h:
650         (TestRunner):
651
652 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
653
654         EventSendingController::keyDown does not support non-array modifier arguments
655         https://bugs.webkit.org/show_bug.cgi?id=96727
656
657         Reviewed by Kenneth Rohde Christiansen.
658
659         Add support for handling a string as modifier argument to
660         EventSendingController::keyDown.
661
662         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
663         (WTR::parseModifierArray):
664
665 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
666
667         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
668         https://bugs.webkit.org/show_bug.cgi?id=42546
669
670         Reviewed by Kenneth Rohde Christiansen.
671
672         Exported TestRunner::setCustomPolicyDelegate() method.
673         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
674
675         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
676         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
677         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
678
679 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
680
681         [GTK] Clear application cache between tests in DumpRenderTree
682         https://bugs.webkit.org/show_bug.cgi?id=96543
683
684         Reviewed by Philippe Normand.
685
686         Call the new DumpRenderTreeSupportGtk method to clear application cache
687         after each test in DumpRenderTree.
688
689         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
690         as well. It's now being set in XvfbDriver._start so that each driver is assigned
691         a cache directory that's constructed out of the driver's name and its worker
692         number. These directories are located in the layout tests results directory.
693         At least on the builders this ensures a driver-specific empty cache directory
694         with each test run.
695
696         * DumpRenderTree/gtk/DumpRenderTree.cpp:
697         (runTest):
698         * Scripts/webkitpy/layout_tests/port/gtk.py:
699         (GtkPort.setup_environ_for_server):
700         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
701         (XvfbDriver._start):
702
703 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
704
705         [Qt] Fix linking on Windows
706
707         Reviewed by Tor Arne Vestbø.
708
709         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
710         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
711         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
712         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
713
714         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
715         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
716         after the module. Therefore QT did never contain webkit anymore and we always passed
717         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
718
719         This patch introduces a creating_module configuration that is used to
720         scope the qt/pkgconfig sanitization.
721
722         * qmake/mkspecs/features/default_post.prf:
723
724 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
725
726         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
727         https://bugs.webkit.org/show_bug.cgi?id=96740
728
729         Reviewed by Kenneth Rohde Christiansen.
730
731         Dump information expected by the test cases about the following
732         frame load callbacks:
733         "didDisplayInsecureContentForFrame"
734         "didRunInsecureContentForFrame"
735         "didDetectXSSForFrame"
736
737         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
738         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
739         as expected by test results by calling pathSuitableForTestResult() instead
740         of printing raw URL.
741         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
742         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
743         (WTR::InjectedBundlePage::didDetectXSSForFrame):
744
745 2012-09-14  Peter Beverloo  <peter@chromium.org>
746
747         The runtime/unsigned category should be valid in the cpp style-checker.
748         https://bugs.webkit.org/show_bug.cgi?id=96748
749
750         Reviewed by Csaba Osztrogonác.
751
752         This is causing the webkitpy tests to fail because it's not listed in the
753         category array. Furthermore, change an "int" to "long" because it's
754         throwing a double error in one of the earlier asserts.
755
756         * Scripts/webkitpy/style/checkers/cpp.py:
757         (CppChecker):
758         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
759         (WebKitStyleTest.test_names):
760
761 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
762
763         Evas_Object* is a ref'ed structure, so tread it as such
764         https://bugs.webkit.org/show_bug.cgi?id=96659
765
766         Reviewed by Adam Barth.
767
768         Replace OwnPtr<Evas_Object> with RefPtr.
769
770         * DumpRenderTree/efl/ImageDiff.cpp:
771         (calculateDifference):
772         (printImageDifferences):
773         (readImageFromStdin):
774         (main):
775
776 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
777
778         Unreviewed, rolling out r128507.
779         http://trac.webkit.org/changeset/128507
780         https://bugs.webkit.org/show_bug.cgi?id=96659
781
782         Revert. r128507 makes too many crashes in EFL layout test bots.
783
784         * DumpRenderTree/efl/ImageDiff.cpp:
785         (calculateDifference):
786         (printImageDifferences):
787         (readImageFromStdin):
788         (main):
789
790 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
791
792         Make compile with both OS(WINCE) and PLATFORM(QT) support
793         https://bugs.webkit.org/show_bug.cgi?id=95536
794
795         Reviewed by Simon Hausmann.
796
797         Fix wince support in qmake files
798
799         * Tools.pro:
800         * qmake/mkspecs/features/configure.prf:
801         * qmake/mkspecs/features/default_post.prf:
802         * qmake/mkspecs/features/features.prf:
803         * qmake/mkspecs/features/functions.prf:
804
805 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
806
807         [WK2] Add color picker API support for WebKit2
808         https://bugs.webkit.org/show_bug.cgi?id=95058
809
810         Reviewed by Gyuyoung Kim.
811
812         Initialization code for color picker callbacks in UI client.
813
814         * MiniBrowser/mac/BrowserWindowController.m:
815         (-[BrowserWindowController awakeFromNib]):
816         * MiniBrowser/win/BrowserView.cpp:
817         (BrowserView::create):
818         * WebKitTestRunner/TestController.cpp:
819         (WTR::TestController::createOtherPage):
820         (WTR::TestController::initialize):
821
822 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
823
824         Upgrade yutak to reviewer
825         https://bugs.webkit.org/show_bug.cgi?id=96721
826
827         Reviewed by Kent Tamura.
828
829         * Scripts/webkitpy/common/config/committers.py:
830
831 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
832
833         Make the style checker report usage of "unsigned int"
834         https://bugs.webkit.org/show_bug.cgi?id=96693
835
836         Reviewed by Dirk Pranke.
837
838         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
839
840         * Scripts/webkitpy/style/checkers/cpp.py:
841         (check_language):
842
843 2012-09-13  Philip Rogers  <pdr@google.com>
844
845         Add gender-neutral form of webkit-patch land-cowboy
846         https://bugs.webkit.org/show_bug.cgi?id=96709
847
848         Reviewed by Adam Barth.
849
850         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
851
852         * Scripts/webkitpy/tool/commands/download.py:
853         (LandCowhand):
854
855 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
856
857         [EFL] Remove some parameters in browserCreate()
858         https://bugs.webkit.org/show_bug.cgi?id=96499
859
860         Reviewed by Kenneth Rohde Christiansen.
861
862         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
863         And I have moved some parameters into User_Arguments.
864
865         * EWebLauncher/main.c:
866         (_User_Arguments):
867         (_ELauncher):
868         (on_key_down):
869         (browserCreate):
870         (findThemePath):
871         (parseUserArguments):
872         (main):
873
874 2012-09-13  Mark Lam  <mark.lam@apple.com>
875
876         Unreviewed. Adding myself to the committers list.
877
878         * Scripts/webkitpy/common/config/committers.py:
879
880 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
881
882         run-perf-tests output cryptic error when the config file is missing.
883         https://bugs.webkit.org/show_bug.cgi?id=96453
884
885         Reviewed by Tony Chang.
886
887         Add a special error message when a configuration file is missing.
888
889         Also update the help message of --source-json-path to signify the fact it specifies
890         the configuration file on performance tests bots.
891
892         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
893         (PerfTestsRunner._parse_args):
894         (PerfTestsRunner._generate_and_show_results):
895         (PerfTestsRunner._merge_slave_config_json):
896         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
897         (_test_run_with_json_output): Make upload to fail by default and assert the result
898         in the function so that we can return logs instead.
899         (_test_run_with_json_output.mock_upload_json):
900         (test_run_with_json_output):
901         (test_run_with_description):
902         (test_run_respects_no_results):
903         (test_run_with_slave_config_json):
904         (test_run_with_bad_slave_config_json):
905         (test_run_with_multiple_repositories):
906
907 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
908
909         Evas_Object* is a ref'ed structure, so tread it as such
910         https://bugs.webkit.org/show_bug.cgi?id=96659
911
912         Reviewed by Adam Barth.
913
914         Replace OwnPtr<Evas_Object> with RefPtr.
915
916         * DumpRenderTree/efl/ImageDiff.cpp:
917         (calculateDifference):
918         (printImageDifferences):
919         (readImageFromStdin):
920         (main):
921
922 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
923
924         One more unreviewed trivial fix after r128399.
925
926         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
927
928 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
929
930         Unreviewed trivial fix after r128399.
931
932         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
933         (getLatestSVNRevision):
934         (waitForSVNRevision):
935
936 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
937
938         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
939         https://bugs.webkit.org/show_bug.cgi?id=96366
940
941         Reviewed by Anders Carlsson.
942
943         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
944         by calling shouldClose() on the FrameLoader.
945
946         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
947         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
948         (WTR::TestRunner::callShouldCloseOnWebView):
949         (WTR):
950         * WebKitTestRunner/InjectedBundle/TestRunner.h:
951         (TestRunner):
952
953 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
954
955         Unreviewed, rolling out r128453.
956         http://trac.webkit.org/changeset/128453
957         https://bugs.webkit.org/show_bug.cgi?id=96681
958
959         Having tests use the same appcache directory leads to timeouts
960         (Requested by zdobersek on #webkit).
961
962         * DumpRenderTree/gtk/DumpRenderTree.cpp:
963         (runTest):
964         * Scripts/webkitpy/layout_tests/port/gtk.py:
965         (GtkPort.setup_environ_for_server):
966
967 2012-09-13  James Robinson  <jamesr@chromium.org>
968
969         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
970         https://bugs.webkit.org/show_bug.cgi?id=96678
971
972         Reviewed by Dirk Pranke.
973
974         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
975         (.):
976
977 2012-09-13  Rob Buis  <rbuis@rim.com>
978
979         Unreviewed changes to watchlist.
980
981         - Add myself to BlackBerry bugs
982
983         * Scripts/webkitpy/common/config/watchlist:
984
985 2012-09-13  Stephen Chenney  <schenney@chromium.org>
986
987         Add an SVG entry to the watchlist
988
989         Unreviewed config change.
990
991         * Scripts/webkitpy/common/config/watchlist:
992         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
993         - Added myself and pdr as watchers
994
995 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
996
997         [Qt] Make WebKit2 work on Windows with Qt 5
998         https://bugs.webkit.org/show_bug.cgi?id=76776
999
1000         Reviewed by Tor Arne Vestbø.
1001
1002         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
1003         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
1004         that for the GL TextureMapper (it's only built when that feature is set).
1005
1006         * qmake/mkspecs/features/configure.prf:
1007
1008 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1009
1010         [Qt] Ensure that QT is finalized before loading qt_module.prf
1011
1012         As qt_module.prf does dependency tracking based on the content of the
1013         QT variable. The intermediate WebKit modules modify the variable in
1014         their .pri files, so we have to ensure we've loaded all the modules
1015         before loading qt_module.
1016
1017         Reviewed by Tor Arne Vestbø.
1018         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
1019
1020         * qmake/mkspecs/features/default_post.prf:
1021         * qmake/mkspecs/features/webkit_modules.prf: Added.
1022
1023 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1024
1025         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
1026         https://bugs.webkit.org/show_bug.cgi?id=96633
1027
1028         Reviewed by Csaba Osztrogonác.
1029
1030         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
1031         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
1032         It's the usual problem and the usual solution is to rename one of the conflicting files.
1033         This patch chooses to rename DRT instead of WTR and MBR.
1034
1035         Fixed include order at the same time to match style guide.
1036
1037         * DumpRenderTree/qt/DumpRenderTree.pro:
1038         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
1039         (messageHandler):
1040         (isOption):
1041         (takeOptionValue):
1042         (printUsage):
1043         (main):
1044
1045 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1046
1047         The Script run-launcher should support -2 in combination with --efl
1048         https://bugs.webkit.org/show_bug.cgi?id=96639
1049
1050         Reviewed by Simon Hausmann.
1051
1052         Support running the MiniBrowser then supplied -2 as argument.
1053
1054         * Scripts/run-launcher:
1055
1056 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1057
1058         Unreviewed, add my Intel email address to the list.
1059
1060         * Scripts/webkitpy/common/config/committers.py:
1061
1062 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1063
1064         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
1065
1066         Reviewed by Ossy.
1067
1068         * qmake/mkspecs/features/default_post.prf:
1069
1070 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1071
1072         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
1073         https://bugs.webkit.org/show_bug.cgi?id=82294
1074
1075         Reviewed by Gyuyoung Kim.
1076
1077         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
1078
1079         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1080         (TestRunner::layerTreeAsText):
1081
1082 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1083
1084         [GTK] Clear application cache between tests in DumpRenderTree
1085         https://bugs.webkit.org/show_bug.cgi?id=96543
1086
1087         Reviewed by Philippe Normand.
1088
1089         Call the new DumpRenderTreeSupportGtk method to clear application cache
1090         after each test.
1091
1092         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1093         as well. Currently it points to a subdirectory in the layout tests results
1094         directory. At least on the builders this ensures an empty cache directory
1095         with each test run.
1096
1097         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1098         (runTest):
1099         * Scripts/webkitpy/layout_tests/port/gtk.py:
1100         (GtkPort.setup_environ_for_server):
1101
1102 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1103
1104         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
1105
1106         Unless it's actually a dependency of the public QtWebKit API.
1107
1108         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
1109         files with their _PRIVATE equivivalent, but that's likely to break when
1110         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
1111         clean up the variables in default_post.
1112
1113         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
1114         longer needed, as it was a workaround for the intermediate libraries ending
1115         up in the prl file. And, since CONFIG -= staticlib was there to support
1116         the explicitlib option, we can remove that too (as well as the exception
1117         for gprof, since it would be empty). If gprof needs tweaks to always link
1118         statically they should go in gprof.prf.
1119
1120         Reviewed by Simon Hausmann.
1121
1122         * qmake/mkspecs/features/default_post.prf:
1123         * qmake/mkspecs/features/functions.prf:
1124
1125 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
1126
1127         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
1128         https://bugs.webkit.org/show_bug.cgi?id=96632
1129
1130         Reviewed by Carlos Garcia Campos.
1131
1132         Fix this by using atk_object_get_n_accessible_children instead of
1133         calling getChildren() from childCount.
1134
1135         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
1136         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
1137         loop by using atk_object_get_n_accessible_children().
1138
1139 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1140
1141         [Qt][Win] Enable USE(3D_GRAPHICS)
1142         https://bugs.webkit.org/show_bug.cgi?id=90879
1143
1144         Reviewed by Kenneth Rohde Christiansen.
1145
1146         Enable it on Windows as well as on QNX (bug fixed).
1147
1148         * qmake/mkspecs/features/features.prf:
1149
1150 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1151
1152         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
1153         https://bugs.webkit.org/show_bug.cgi?id=96359
1154
1155         Reviewed by Tor Arne Vestbø.
1156
1157         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
1158         lexer. The only viable alternative I could find on Windows that provides
1159         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
1160         so let's use that one instead.
1161
1162         * Scripts/webkitdirs.pm:
1163         (checkRequiredSystemConfig):
1164         * qmake/mkspecs/features/default_pre.prf:
1165
1166 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1167
1168         [Qt] Add configuration for production builds
1169         https://bugs.webkit.org/show_bug.cgi?id=96607
1170
1171         Reviewed by Kenneth Rohde Christiansen.
1172
1173         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
1174         and enable all-in-one-files optimizations.
1175
1176         * qmake/mkspecs/features/production_build.prf: Added.
1177
1178 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1179
1180         [Qt] GStreamer detection does not work when cross-compiling
1181         https://bugs.webkit.org/show_bug.cgi?id=96608
1182
1183         Reviewed by Kenneth Rohde Christiansen.
1184
1185         When cross-compiling it is not safe to just use system(pkg-config),
1186         because there is a high probability that it will find packages in the
1187         host system instead of in the target one. Instead use qmake's new
1188         packagesExist() function that takes care of this delicate aspect of
1189         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
1190         PKG_CONFIG_LIBDIR accordingly.
1191
1192         * qmake/mkspecs/features/features.prf:
1193
1194 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
1195
1196         [WK2][WTR] More efficient string handling in InjectedBundlePage
1197         https://bugs.webkit.org/show_bug.cgi?id=96609
1198
1199         Reviewed by Kenneth Rohde Christiansen.
1200
1201         Update StringBuilder usage in InjectedBundlePage to follow
1202         the latest recommandations for efficient string handling:
1203         http://trac.webkit.org/wiki/EfficientStrings
1204
1205         This involves using appendLiteral() or appendNumber()
1206         instead of append() whenever possible.
1207
1208         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1209         (WTR::dumpPath):
1210         (WTR::rangeToStr):
1211         (WTR::styleDecToStr):
1212         (WTR::frameToStr):
1213         (WTR::dumpResourceURL):
1214         (WTR):
1215         (WTR::dumpFrameDescriptionSuitableForTestResult):
1216         (WTR::dumpRequestDescriptionSuitableForTestResult):
1217         (WTR::dumpResponseDescriptionSuitableForTestResult):
1218         (WTR::dumpErrorDescriptionSuitableForTestResult):
1219         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1220         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1221         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1222         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1223         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1224         (WTR::InjectedBundlePage::didFinishProgress):
1225         (WTR::dumpFrameScrollPosition):
1226         (WTR::dumpFrameText):
1227         (WTR::dumpDescendantFramesText):
1228         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1229         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1230         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1231         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1232         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1233         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1234         (WTR::InjectedBundlePage::willSendRequestForFrame):
1235         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1236         (WTR::InjectedBundlePage::didFinishLoadForResource):
1237         (WTR::InjectedBundlePage::didFailLoadForResource):
1238         (WTR::InjectedBundlePage::shouldCacheResponse):
1239         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1240         (WTR::InjectedBundlePage::willAddMessageToConsole):
1241         (WTR::InjectedBundlePage::willSetStatusbarText):
1242         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1243         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1244         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1245         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1246         (WTR::InjectedBundlePage::shouldBeginEditing):
1247         (WTR::InjectedBundlePage::shouldEndEditing):
1248         (WTR::InjectedBundlePage::shouldInsertNode):
1249         (WTR::InjectedBundlePage::shouldInsertText):
1250         (WTR::InjectedBundlePage::shouldDeleteRange):
1251         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1252         (WTR::InjectedBundlePage::shouldApplyStyle):
1253         (WTR::InjectedBundlePage::didBeginEditing):
1254         (WTR::InjectedBundlePage::didEndEditing):
1255         (WTR::InjectedBundlePage::didChange):
1256         (WTR::InjectedBundlePage::didChangeSelection):
1257         (WTR::InjectedBundlePage::supportsFullScreen):
1258         (WTR::InjectedBundlePage::enterFullScreenForElement):
1259         (WTR::InjectedBundlePage::exitFullScreenForElement):
1260         (WTR::InjectedBundlePage::beganEnterFullScreen):
1261         (WTR::InjectedBundlePage::beganExitFullScreen):
1262         (WTR::InjectedBundlePage::closeFullScreen):
1263         (WTR::dumpBackForwardListItem):
1264         (WTR::InjectedBundlePage::dumpBackForwardList):
1265
1266 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1267
1268         [Qt][WK2] Memory leaks in Qt's TestRunner
1269         https://bugs.webkit.org/show_bug.cgi?id=96603
1270
1271         Reviewed by Csaba Osztrogonác.
1272
1273         Fix memory leaks in Qt's TestRunner code by adopting WKString
1274         created with WKStringCreateWithUTF8CString().
1275
1276         * WebKitTestRunner/qt/TestControllerQt.cpp:
1277         (WTR::TestController::initializeInjectedBundlePath):
1278         (WTR::TestController::initializeTestPluginDirectory):
1279
1280 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1281
1282         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
1283         https://bugs.webkit.org/show_bug.cgi?id=96506
1284
1285         Reviewed by Dirk Pranke.
1286
1287         Lower the timeout value to 6 seconds for release configuration and 12 seconds
1288         for debug configuration. These are the same values the Chromium port uses.
1289
1290         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
1291         the layout tests under WebKit2 generally) requires more attention and gardening
1292         than what the current effort produces.
1293
1294         The unit test is updated as well to test these changes.
1295
1296         * Scripts/webkitpy/layout_tests/port/gtk.py:
1297         (GtkPort.default_timeout_ms):
1298         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1299         (GtkPortTest.test_default_timeout_ms):
1300         (GtkPortTest.assertLinesEqual):
1301
1302 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
1303
1304         Add SVN mirror handling feature to build.webkit.org
1305         https://bugs.webkit.org/show_bug.cgi?id=85887
1306
1307         Reviewed by Dirk Pranke.
1308
1309         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
1310         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1311         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
1312         (ConfigureBuild.start):
1313         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
1314         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
1315         (Factory.__init__):
1316         (BuildFactory.__init__):
1317         (TestFactory.__init__):
1318         (BuildAndTestFactory.__init__):
1319         (BuildAndPerfTestFactory.__init__):
1320         (BuildAndPerfTestWebKit2Factory.__init__):
1321         (DownloadAndPerfTestFactory.__init__):
1322         (DownloadAndPerfTestWebKit2Factory.__init__):
1323         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
1324         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1325         (SVNMirrorTest):
1326         (SVNMirrorTest.setUp): Load config.json once at startup.
1327         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
1328         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
1329         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
1330         (getLatestSVNRevision): Get the latest SVN revison from the given server.
1331         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
1332                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
1333
1334 2012-09-12  Kangil Han  <kangil.han@samsung.com>
1335
1336         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
1337         https://bugs.webkit.org/show_bug.cgi?id=81606
1338
1339         Reviewed by Tim Horton.
1340
1341         6 seconds is harsh for some jquery test cases.
1342         Therefore, adjust the value to match DumpRenderTree.
1343
1344         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1345         (WTR):
1346
1347 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
1348
1349         [EFL] Support download attribute feature
1350         https://bugs.webkit.org/show_bug.cgi?id=96462
1351
1352         Reviewed by Gyuyoung Kim.
1353
1354         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
1355         and add "download,request" callback to the DumpRenderTree for EFL.
1356
1357         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1358         (DumpRenderTreeChrome::createView):
1359         (DumpRenderTreeChrome::onDownloadRequest):
1360         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1361         (DumpRenderTreeChrome):
1362         * Scripts/webkitperl/FeatureList.pm:
1363
1364 2012-09-12  Stephanie Lewis  <slewis@apple.com>
1365
1366         Reduce parallism on the wk2 testers.
1367         https://bugs.webkit.org/show_bug.cgi?id=95906
1368
1369         Reviewed by Dirk Pranke.
1370
1371         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
1372         resource contention.  Reducing the number of processes alleviates the issue.  
1373
1374         Starting by reducing 25%.
1375
1376         * Scripts/webkitpy/layout_tests/port/mac.py:
1377         (MacPort.default_child_processes):
1378
1379 2012-09-12  Brady Eidson  <beidson@apple.com>
1380
1381         Assert in NetscapePlugin::destroy() with async plugin init
1382         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
1383
1384         Reviewed by Anders Carlsson.
1385
1386         Expose NPN_Invoke to plug-in tests:
1387         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1388         (PluginTest::NPN_Invoke):
1389         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1390         (PluginTest):
1391
1392         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
1393         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
1394         (InvokeDestroysPluginWithinNPP_New):
1395         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
1396         (InvokeDestroysPluginWithinNPP_New::NPP_New):
1397         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1398
1399 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1400
1401         refactor TestExpectations tokenization slightly in preparation for the new syntax
1402         https://bugs.webkit.org/show_bug.cgi?id=96564
1403
1404         Reviewed by Ojan Vafai.
1405
1406         This change changes how we will tokenize/lex the
1407         TestExpectations files, in preparation for supporting both the
1408         old syntax and the new one. This change by itself should be a
1409         no-op.
1410
1411         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1412         (TestExpectationParser._tokenize_line):
1413         (TestExpectationParser):
1414         (TestExpectationParser._tokenize_line_using_old_format):
1415         (TestExpectationParser._tokenize_line_using_new_format):
1416
1417 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1418
1419         remove unused testexpectations editing code from webkitpy, garden-o-matic
1420         https://bugs.webkit.org/show_bug.cgi?id=96562
1421
1422         Reviewed by Adam Barth.
1423
1424         This code was prototyped but never fully realized. Removing
1425         until it reanimates :).
1426
1427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1429         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
1430         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
1431         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1432         (BuildCoverageExtrapolator.extrapolate_test_configurations):
1433         (GardeningHTTPRequestHandler._run_webkit_patch):
1434         (GardeningHTTPRequestHandler.ping):
1435         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1436         (BuildCoverageExtrapolatorTest.test_extrapolate):
1437         (GardeningServerTest.test_rebaseline_new_port):
1438
1439 2012-09-12  Lucas Forschler  <lforschler@apple.com>
1440
1441         Remove unused bot, apple-xserve-1.
1442         https://bugs.webkit.org/show_bug.cgi?id=96570
1443         
1444         Reviewed by Stephanie Lewis.
1445
1446         * BuildSlaveSupport/build.webkit.org-config/config.json:
1447
1448 2012-09-12  Xan Lopez  <xlopez@igalia.com>
1449
1450         [GTK] We attempt to rebase documentation even if it's not present
1451         https://bugs.webkit.org/show_bug.cgi?id=96553
1452
1453         Reviewed by Martin Robinson.
1454
1455         Do not make the documentation rebase step fatal. This allows make
1456         install to succeed when there's no documentation generated.
1457
1458         * gtk/generate-gtkdoc:
1459
1460 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1461
1462         Respect WEBKITOUTPUTDIR when running EFL tests
1463         https://bugs.webkit.org/show_bug.cgi?id=96528
1464
1465         Reviewed by Dirk Pranke.
1466
1467         Expose user set WEBKITOUTPUTDIR to the web process.
1468
1469         * Scripts/webkitpy/layout_tests/port/driver.py:
1470         (Driver._start): Add WEBKITOUTPUTDIR to the environment
1471         of the web process and its potential jhbuild wrapper.
1472
1473 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1474
1475         webkitdirs: fix uname version handling for cygwin
1476         https://bugs.webkit.org/show_bug.cgi?id=96436
1477
1478         Reviewed by Jon Honeycutt.
1479
1480         Newer versions of cygwin embed an additional version string
1481         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
1482         Update the code to handle that.
1483
1484         * Scripts/webkitdirs.pm:
1485         (setupAppleWinEnv):
1486
1487 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1488
1489         Regression(r128338): Broke Windows build
1490         https://bugs.webkit.org/show_bug.cgi?id=96537
1491
1492         Unreviewed build fix.
1493
1494         Fix Apple-Win build by allocating array dynamically
1495         since its size is not constant.
1496
1497         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1498         (WTR::stringArrayToJS):
1499
1500 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
1501
1502         [chromium] Add a virtual test suite for fast/hidpi
1503         https://bugs.webkit.org/show_bug.cgi?id=90192
1504
1505         Reviewed by Dirk Pranke.
1506
1507         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
1508         on the hardware accelerated path as the software path.
1509
1510         * DumpRenderTree/chromium/WebPreferences.cpp:
1511         (WebPreferences::applyTo):
1512         * Scripts/webkitpy/layout_tests/port/chromium.py:
1513         (ChromiumPort.virtual_test_suites):
1514
1515 2012-09-12  Adam Klein  <adamk@chromium.org>
1516
1517         [chromium] Add content_browsertests to the flakiness dashboard
1518         https://bugs.webkit.org/show_bug.cgi?id=96535
1519
1520         Reviewed by Ojan Vafai.
1521
1522         * TestResultServer/static-dashboards/dashboard_base.js:
1523
1524 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1525
1526         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
1527         https://bugs.webkit.org/show_bug.cgi?id=96496
1528
1529         Reviewed by Kenneth Rohde Christiansen.
1530
1531         Add implementation for originsWithApplicationCache to
1532         WebKitTestRunner.
1533
1534         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1535         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1536         (WTR::stringArrayToJS):
1537         (WTR):
1538         (WTR::TestRunner::originsWithApplicationCache):
1539         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1540         (TestRunner):
1541
1542 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1543
1544         Fix Qt/Windows build with Python3
1545         https://bugs.webkit.org/show_bug.cgi?id=96473
1546
1547         Reviewed by Csaba Osztrogonác.
1548
1549         In Python 3 print is a real function, so we must use parentheses around
1550         the function parameters. This is backwards compatible with Python 2.
1551
1552         * Scripts/generate-win32-export-forwards:
1553
1554 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1555
1556         Unreviewed trivial build fix for Qt/Windows after bug #96358.
1557
1558         As pointed out by Kevin, we should inject the "set PATH=..." statement
1559         to add the GnuWin32 directory only if that directory actually exists.
1560
1561         * qmake/mkspecs/features/default_post.prf:
1562
1563 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1564
1565         [EFL] [WK2] Memory leaks in TestControllerEfl
1566         https://bugs.webkit.org/show_bug.cgi?id=96525
1567
1568         Reviewed by Kenneth Rohde Christiansen.
1569
1570         Fix memory leaks in EFL's TestRunner code by adopting an allocation
1571         of WKString created with WKStringCreateWithUTF8CString().
1572
1573         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1574         (WTR::TestController::initializeInjectedBundlePath):
1575         (WTR::TestController::initializeTestPluginDirectory):
1576
1577 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1578
1579         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1580         https://bugs.webkit.org/show_bug.cgi?id=96374
1581
1582         Reviewed by Kenneth Rohde Christiansen.
1583
1584         Implement support for dumpApplicationCacheDelegateCallbacks
1585         and disallowIncreaseForApplicationCacheQuota in
1586         WebKitTestRunner and properly dump the information
1587         expected by the tests.
1588
1589         If the application cache quota is reached for a given
1590         security origin, WebKitTestRunner will reset the quota
1591         to its default value, unless intructed not to via
1592         disallowIncreaseForApplicationCacheQuota().
1593
1594         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1595         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1596         (WTR::InjectedBundlePage::InjectedBundlePage):
1597         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1598         (WTR):
1599         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1600         (InjectedBundlePage):
1601         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1602         (WTR::TestRunner::TestRunner):
1603         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1604         (WTR):
1605         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1606         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1607         (TestRunner):
1608         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1609         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1610
1611 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1612
1613         [chromium] remove deprecated and unused sets import from chromium_android driver
1614         https://bugs.webkit.org/show_bug.cgi?id=96485
1615
1616         Reviewed by Dirk Pranke.
1617
1618         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1619
1620 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
1621
1622         Flakiness dashboard doesn't recognize new Chromium Android test builder
1623         https://bugs.webkit.org/show_bug.cgi?id=96523
1624
1625         Reviewed by Ojan Vafai.
1626
1627         Properly return 'ANDROID' as the Chromium platform for Android builders.
1628
1629         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1630         (chromiumPlatform):
1631         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1632         (test):
1633
1634 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1635
1636         [Qt] Build on Windows requires bison/flex in PATH
1637         https://bugs.webkit.org/show_bug.cgi?id=96358
1638
1639         Reviewed by Tor Arne Vestbø.
1640
1641         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
1642         and Linux that is rarely a problem given how easily available the tools are. On Windows however
1643         a separate installation of various GNU tools is required as the operating system doesn't come with
1644         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
1645         the gnuwin32 directory of the qt5.git top-level repository.
1646
1647         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
1648
1649         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
1650         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
1651         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
1652         updated with the new tool.
1653
1654         * Scripts/webkitdirs.pm:
1655         (checkRequiredSystemConfig):
1656         * qmake/mkspecs/features/default_post.prf:
1657
1658 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1659
1660         [Qt] Update build-jsc after r128174
1661
1662         Reviewed by Ossy.
1663
1664         * Scripts/build-jsc:
1665
1666 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1667
1668         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
1669
1670         By hard-coding the names of the targets we defined we ended up just
1671         redefining the previous target when using addStrictSubdirOrderBetween
1672         more than once in a single project file.
1673
1674         We now embed the two base targets into the target names.
1675
1676         Reviewed by Simon Hausmann.
1677
1678         * qmake/mkspecs/features/functions.prf:
1679
1680 2012-09-12  Philippe Liard  <pliard@google.com>
1681
1682         Depend on {base,net} GYP targets rather than {base,net}_java.
1683         https://bugs.webkit.org/show_bug.cgi?id=95690
1684
1685         Reviewed by Adam Barth.
1686
1687         {base,net}_java became 'private' targets on the Chromium side that
1688         clients should not depend on (see
1689         https://chromiumcodereview.appspot.com/10913083/).
1690         This removes a bunch of trailing white spaces additionally in
1691         TestWebkitAPI.gyp (which includes non-trailing white space changes).
1692
1693         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1694         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1695
1696 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1697
1698         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
1699         https://bugs.webkit.org/show_bug.cgi?id=96494
1700
1701         Reviewed by Tor Arne Vestbø.
1702
1703         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
1704         plugin process feature if we don't have NPAPI.
1705
1706         * qmake/mkspecs/features/features.prf:
1707
1708 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1709
1710         Unreviewed, rolling out r128280.
1711         http://trac.webkit.org/changeset/128280
1712         https://bugs.webkit.org/show_bug.cgi?id=96498
1713
1714         it broke compilation on windows debug bot (Requested by loislo
1715         on #webkit).
1716
1717         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1718         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1719         (WTR::InjectedBundlePage::InjectedBundlePage):
1720         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1721         (InjectedBundlePage):
1722         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1723         (WTR::TestRunner::TestRunner):
1724         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1725         (TestRunner):
1726
1727 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1728
1729         [Qt] Make it possible to build with "make release" and "make debug" on Windows
1730         https://bugs.webkit.org/show_bug.cgi?id=96488
1731
1732         Reviewed by Tor Arne Vestbø.
1733
1734         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
1735         because there are no such targets. We want the generated sources to be independent from release
1736         or debug build configurations, so it is sufficient to provide fake debug and release targets that
1737         redirect to the same general-purpose target (first) of creating the derived sources.
1738
1739         * qmake/mkspecs/features/default_post.prf:
1740
1741 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1742
1743         [EFL] Make DumpRenderTree smarter at finding the fonts
1744         http://webkit.org/b/96281
1745
1746         Reviewed by Gyuyoung Kim.
1747
1748         Respect WEBKITOUTPUTDIR and expand the font dir from it.
1749         Use CString consistently.
1750
1751         * DumpRenderTree/efl/FontManagement.cpp:
1752         (buildPath):
1753         (getCoreFontFiles):
1754         (addFontDirectory):
1755         (addFontFiles):
1756         (getCustomBuildDir):
1757         (getPlatformFontsPath):
1758         (addFontsToEnvironment):
1759
1760 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1761
1762         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1763         https://bugs.webkit.org/show_bug.cgi?id=96374
1764
1765         Reviewed by Kenneth Rohde Christiansen.
1766
1767         Implement support for dumpApplicationCacheDelegateCallbacks
1768         and disallowIncreaseForApplicationCacheQuota in
1769         WebKitTestRunner and properly dump the information
1770         expected by the tests.
1771
1772         If the application cache quota is reached for a given
1773         security origin, WebKitTestRunner will reset the quota
1774         to its default value, unless intructed not to via
1775         disallowIncreaseForApplicationCacheQuota().
1776
1777         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1778         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1779         (WTR::InjectedBundlePage::InjectedBundlePage):
1780         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1781         (WTR):
1782         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1783         (InjectedBundlePage):
1784         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1785         (WTR::TestRunner::TestRunner):
1786         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1787         (WTR):
1788         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1789         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1790         (TestRunner):
1791         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1792         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1793
1794 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1795
1796         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
1797         https://bugs.webkit.org/show_bug.cgi?id=96388
1798
1799         Reviewed by Kenneth Rohde Christiansen.
1800
1801         Exported TestRunner.workerThreadCount as readonly attribute.
1802
1803         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1804         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
1805         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
1806         (WTR):
1807         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
1808         (TestRunner):
1809
1810 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1811
1812         [chromium] Consume a user gesture when creating a new view.
1813         https://bugs.webkit.org/show_bug.cgi?id=96373
1814
1815         Reviewed by Adam Barth.
1816
1817         * DumpRenderTree/chromium/WebViewHost.cpp:
1818         (WebViewHost::createView):
1819
1820 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1821
1822         [WK2][WTR] Some of TestRunner special options are not reset before testing
1823         https://bugs.webkit.org/show_bug.cgi?id=96384
1824
1825         Reviewed by Kenneth Rohde Christiansen.
1826
1827         Now values of the following special options are reset:
1828         void setAcceptsEditing(in boolean value);
1829         void setCloseRemainingWindowsWhenComplete(in boolean value);
1830         void setXSSAuditorEnabled(in boolean value);
1831         void setAllowFileAccessFromFileURLs(in boolean value);
1832         void setPluginsEnabled(in boolean value);
1833         void setPopupBlockingEnabled(in boolean value);
1834
1835         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1836         (WTR::InjectedBundle::beginTesting):
1837
1838 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
1839
1840         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
1841         https://bugs.webkit.org/show_bug.cgi?id=96273
1842
1843         Reviewed by Gyuyoung Kim.
1844
1845         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
1846         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
1847
1848         * WebKitTestRunner/CMakeLists.txt:
1849
1850 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
1851
1852         [chromium] rename webkit_resources
1853         https://bugs.webkit.org/show_bug.cgi?id=95874
1854
1855         Reviewed by James Robinson.
1856
1857         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1858
1859 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
1860
1861         [chromium] don't include content shell builders in the garden-o-matic view
1862         https://bugs.webkit.org/show_bug.cgi?id=96418
1863
1864         Reviewed by James Robinson.
1865
1866         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1867
1868 2012-09-11  Adam Klein  <adamk@chromium.org>
1869
1870         Garden-o-matic should ignore a wider variety of warnings in buildbot json
1871         https://bugs.webkit.org/show_bug.cgi?id=96411
1872
1873         Reviewed by Adam Barth.
1874
1875         Previously only the exact string "warning" was treated as a warning
1876         result. This patch treats any string with "warning" as a substring
1877         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
1878
1879         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1880         (.):
1881         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1882
1883 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
1884
1885         Restore original value of mock scrollbars enabled in InternalSettings
1886         https://bugs.webkit.org/show_bug.cgi?id=87680
1887
1888         Reviewed by Adam Barth.
1889
1890         Added backup support for mock scrollbars state in
1891         InternalSettings::Backup, and removed support for these
1892         from Qt's DumpRenderTree.
1893
1894         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1895         (WebCore::WebPage::resetSettings):
1896         * DumpRenderTree/qt/TestRunnerQt.cpp:
1897         (TestRunner::setFrameFlatteningEnabled):
1898         * DumpRenderTree/qt/TestRunnerQt.h:
1899         (TestRunner):
1900
1901 2012-09-11  Dan Bernstein  <mitz@apple.com>
1902
1903         Fixed a bug where kill-old-processes failed to kill clang++.
1904
1905         Rubber-stamped by Alexey Proskuryakov.
1906
1907         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
1908         where it is passed as a regular expression to killall.
1909
1910 2012-09-11  Philippe Liard  <pliard@google.com>
1911
1912         Make sure that md5sum is not setup on non-Chromium Android platforms.
1913         https://bugs.webkit.org/show_bug.cgi?id=96393
1914
1915         Reviewed by Adam Barth.
1916
1917         Previously md5sum was setup in ChromiumAndroidDriver's constructor
1918         which is also invoked on non-Chromium Android platforms. The following patch
1919         moves this logic to _startup_test() which is guaranteed to be invoked
1920         only on Android.
1921
1922         This also updates the prompt unit test in chromium_android_unittest.py.
1923
1924         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1925         (ChromiumAndroidDriver.__init__):
1926         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1927         (ChromiumAndroidDriver._setup_test):
1928
1929 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
1930
1931         [EFL] Rewrite the EFL-related Find modules
1932         https://bugs.webkit.org/show_bug.cgi?id=95237
1933
1934         Reviewed by Kenneth Rohde Christiansen.
1935
1936         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
1937         property and include all the Enlightenment Foundation Libraries
1938         required by the target.
1939         * EWebLauncher/CMakeLists.txt: Ditto.
1940         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1941         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
1942         now that they are not added implicitly.
1943         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
1944         property.
1945         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
1946         property and include all the Enlightenment Foundation Libraries
1947         required by the target.
1948
1949 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
1950
1951         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
1952         https://bugs.webkit.org/show_bug.cgi?id=96379
1953
1954         Reviewed by Kenneth Rohde Christiansen.
1955
1956         Add implementation for setApplicationCacheOriginQuota
1957         to WebKitTestRunner.
1958
1959         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1960         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1961         (WTR::TestRunner::setApplicationCacheOriginQuota):
1962         (WTR):
1963         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1964         (TestRunner):
1965
1966 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
1967
1968         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
1969         https://bugs.webkit.org/show_bug.cgi?id=91988
1970
1971         Reviewed by Kenneth Rohde Christiansen.
1972
1973         Regular key events generated by Qt for the tab key fill both
1974         keyCode and keyText, so we should do the same for our fake events.
1975
1976         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1977         (WTR::EventSenderProxy::keyDown):
1978
1979 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1980
1981         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
1982         https://bugs.webkit.org/show_bug.cgi?id=96269
1983
1984         Reviewed by Kenneth Rohde Christiansen.
1985
1986         Exported missing testRunner.setSpatialNavigationEnabled() method.
1987
1988         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1989         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1990         (WTR::InjectedBundle::beginTesting):
1991         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1992         (WTR::TestRunner::setSpatialNavigationEnabled):
1993         (WTR):
1994         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1995         (TestRunner):
1996
1997 2012-09-11  Philippe Liard  <pliard@chromium.org>
1998
1999         Support LayoutTests on non-rooted devices for Chromium Android.
2000         https://bugs.webkit.org/show_bug.cgi?id=95346
2001
2002         Reviewed by Dirk Pranke.
2003
2004         We were requiring root permissions to sync resource files with the
2005         device by comparing host and device files' timestamp after we
2006         synchronized the device and host clocks.
2007         We now rely on md5sum provided by Chromium to handle data files
2008         synchronization.
2009
2010         * Scripts/webkitpy/layout_tests/port/chromium.py:
2011         (ChromiumPort._check_driver_build_up_to_date):
2012         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2013         (ChromiumAndroidDriver.__init__):
2014         (ChromiumAndroidDriver._setup_test):
2015         (ChromiumAndroidDriver._push_executable):
2016         (ChromiumAndroidDriver._push_test_resources):
2017         (ChromiumAndroidDriver._read_prompt):
2018
2019 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2020
2021         [Qt] Fix output paths on Windows
2022
2023         Reviewed by Tor Arne Vestbø.
2024
2025         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
2026         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
2027         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
2028         incorrect here and instead for the calculation we should use forward slashes.
2029
2030         * qmake/mkspecs/features/default_pre.prf:
2031
2032 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2033
2034         [Qt] Fix passing of defines from the build system
2035
2036         We explicitly have to pass -DENABLE_FOO=0 for every single feature
2037         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
2038         will add it's own defaults if the features are not defined.
2039
2040         At some point we might want to run a configure-test to inspect what
2041         Platform.h will do, so we can sync up the build system's view of
2042         the feature-defines with the compile-time situation.
2043
2044         Reviewed by Simon Hausmann.
2045
2046         * qmake/mkspecs/features/functions.prf:
2047
2048 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2049
2050         [Qt] Fix --qt option to build-webkit
2051
2052         Reviewed by Ossy.
2053
2054         * Scripts/webkitdirs.pm:
2055         (buildQMakeProjects):
2056
2057 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2058
2059         [Qt] Add a configure step to the Qt build system
2060
2061         This allows building the Qt port using just 'qmake WebKit.pro'. Using
2062         the build-webkit script is still supported, and will add slightly more
2063         logic to the build, such as detecting the need for clean or incremental
2064         builds.
2065
2066         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
2067         all things related to configuring the build, such as use/have/enable flags,
2068         and these are translated to defines in default_post. Project files should
2069         no longer check contains(DEFINES,...) to detect features, but use the new
2070         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
2071         options have been translated into WEBKIT_CONFIG options as well, and can
2072         be checked using build?().
2073
2074         Reviewed by Simon Hausmann.
2075
2076         * DumpRenderTree/qt/DumpRenderTree.pro:
2077         * MiniBrowser/qt/MiniBrowser.pro:
2078         * QtTestBrowser/QtTestBrowser.pro:
2079         * Scripts/build-webkit:
2080         * Scripts/webkitdirs.pm:
2081         (qtFeatureDefaults):
2082         (buildQMakeProjects):
2083         * Tools.pro:
2084         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2085         * WebKitTestRunner/InjectedBundle/Target.pri:
2086         * WebKitTestRunner/Target.pri:
2087         * qmake/.qmake.cache: Added.
2088         * qmake/configure.pri: Removed.
2089         * qmake/configure.pro: Removed.
2090         * qmake/dump-features: Added.
2091         * qmake/mkspecs/features/configure.prf: Added.
2092         * qmake/mkspecs/features/default_post.prf:
2093         * qmake/mkspecs/features/default_pre.prf:
2094         * qmake/mkspecs/features/features.prf:
2095         * qmake/mkspecs/features/features.pri:
2096         * qmake/mkspecs/features/functions.prf:
2097         * qmake/mkspecs/features/gprof.prf:
2098         * qmake/mkspecs/features/mac/default_pre.prf:
2099         * qmake/mkspecs/features/win32/default_pre.prf:
2100
2101 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2102
2103         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
2104         https://bugs.webkit.org/show_bug.cgi?id=96372
2105
2106         Reviewed by Kenneth Rohde Christiansen.
2107
2108         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
2109
2110         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2111         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2112         (WTR::TestRunner::clearApplicationCacheForOrigin):
2113         (WTR):
2114         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2115         (TestRunner):
2116
2117 2012-09-11  Peter Beverloo  <peter@chromium.org>
2118
2119         Don't ignore .pak files when making an archive for Android
2120         https://bugs.webkit.org/show_bug.cgi?id=96375
2121
2122         Reviewed by Jochen Eisinger.
2123
2124         The .pak files do need to be pushed to the device, which is currently
2125         preventing the layout test runner from correctly pushing all files.
2126
2127         * BuildSlaveSupport/built-product-archive:
2128         (archiveBuiltProduct):
2129
2130 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2131
2132         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
2133         https://bugs.webkit.org/show_bug.cgi?id=96256
2134
2135         Reviewed by Kenneth Rohde Christiansen.
2136
2137         Exported TestRunner::setMinimumTimerInterval() method.
2138
2139         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2140         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2141         (WTR::InjectedBundle::beginTesting):
2142         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2143         (WTR::TestRunner::setMinimumTimerInterval):
2144         (WTR):
2145         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2146         (TestRunner):
2147
2148 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
2149
2150         MediaStream API: add RTCPeerConnection::onnegotiationneeded
2151         https://bugs.webkit.org/show_bug.cgi?id=96097
2152
2153         Reviewed by Adam Barth.
2154
2155         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2156         (MockWebRTCPeerConnectionHandler::addStream):
2157         (MockWebRTCPeerConnectionHandler::removeStream):
2158
2159 2012-09-11  Peter Beverloo  <peter@chromium.org>
2160
2161         Recognize the "--chromium-android" argument in run-webkit-tests
2162         https://bugs.webkit.org/show_bug.cgi?id=96369
2163
2164         Reviewed by Jochen Eisinger.
2165
2166         Chromium for the Android platform cannot determine the platform based on
2167         the host itself, so we'll use the --chromium-android argument as the build
2168         master passes to run-webkit-tests. Make sure the layout test runner
2169         can pick the right port when doing so.
2170
2171         * Scripts/run-webkit-tests:
2172         * Scripts/webkitpy/layout_tests/port/factory.py:
2173         (port_options):
2174
2175 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2176
2177         [QT] Fix build with newer qmake from Qt 5
2178
2179         Rubber-stamped by Tor Arne Vestbø.
2180
2181         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
2182         it with the use of QT_HOST_DATA/mkspecs.
2183         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
2184
2185         * Scripts/webkitdirs.pm:
2186         (builtDylibPathForName):
2187         (qtMakeCommand):
2188
2189 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2190
2191         [Qt] Remove Qt 4 syncqt, no longer needed
2192
2193         Reviewed by Simon Hausmann.
2194
2195         * qmake/syncqt-4.8: Removed.
2196
2197 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
2198
2199         [Qt][WK2] Fix the build with recent Qt5
2200         https://bugs.webkit.org/show_bug.cgi?id=96283
2201
2202         Reviewed by Simon Hausmann.
2203
2204         We should not use deprecated Qt API because doing that results
2205         in build failure since all the deprecated API was disabled
2206         in qtbase (https://codereview.qt-project.org/#change,24890).
2207
2208         * DumpRenderTree/qt/main.cpp:
2209         (main):
2210         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2211         (MiniBrowserApplication::notify):
2212         * MiniBrowser/qt/raw/View.cpp:
2213         (View::exposeEvent):
2214         (main):
2215
2216 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2217
2218         WTR needs an implementation of applicationCacheDiskUsageForOrigin
2219         https://bugs.webkit.org/show_bug.cgi?id=87188
2220
2221         Reviewed by Kenneth Rohde Christiansen.
2222
2223         Add implementation for applicationCacheDiskUsageForOrigin()
2224         in WebKitTestRunner.
2225
2226         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2227         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2228         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2229         (WTR):
2230         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2231         (TestRunner):
2232
2233 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
2234
2235         Properly expose <legend> elements to ATs
2236         https://bugs.webkit.org/show_bug.cgi?id=84137
2237
2238         Reviewed by Chris Fleizach.
2239
2240         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
2241         the expected platform role, ATK_ROLE_LABEL. Also established the needed
2242         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
2243
2244         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2245         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
2246
2247 2012-09-10  Jer Noble  <jer.noble@apple.com>
2248
2249         Unreviewed; rolling out r128081.
2250         http://trac.webkit.org/changeset/128081
2251         https://bugs.webkit.org/show_bug.cgi?id=96134
2252
2253         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
2254
2255         * DumpRenderTree/TestRunner.cpp:
2256         (TestRunner::TestRunner):
2257         (TestRunner::staticFunctions):
2258         * DumpRenderTree/TestRunner.h:
2259         (TestRunner):
2260         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2261         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2262         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2263         (WTR::InjectedBundlePage::InjectedBundlePage):
2264         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2265         (InjectedBundlePage):
2266         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2267         (WTR::TestRunner::TestRunner):
2268         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2269         (TestRunner):
2270
2271 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2272
2273         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
2274         https://bugs.webkit.org/show_bug.cgi?id=96205
2275
2276         Reviewed by Tony Chang.
2277
2278         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
2279         internally, which means that it would support only 1 TestExpectations file per port. This
2280         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
2281         and efl-wk1 -> efl).
2282
2283         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
2284         instead so that all the ports TestExpectations are recognized. The ports are also
2285         constructed twice, with "webkit_test_runner" option set to True and False so that we
2286         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
2287
2288         * Scripts/webkitpy/style/checkers/test_expectations.py:
2289         (TestExpectationsChecker._determine_port_from_expectations_path):
2290         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
2291         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2292
2293 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
2294
2295         [WTR] Generated source files should include config.h
2296         https://bugs.webkit.org/show_bug.cgi?id=96254
2297
2298         Reviewed by Benjamin Poulain.
2299
2300         Current coding style has encouraged to include config.h at the first position,
2301         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
2302         this rule.
2303         Therefore, this patch added it.
2304
2305         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2306         (_generateImplementationFile):
2307
2308 2012-09-10  Rick Byers  <rbyers@chromium.org>
2309
2310         Add handling of new GestureTapCancel in DRT
2311         
2312         https://bugs.webkit.org/show_bug.cgi?id=96183
2313
2314         Reviewed by Adam Barth.
2315
2316         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2317         (TestWebPlugin::handleInputEvent):
2318
2319 2012-09-10  Brady Eidson  <beidson@apple.com>
2320
2321         Javascript in foreground tabs should not wait synchronously for plug-ins to load
2322         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
2323
2324         Reviewed by Geoff Garen.
2325
2326         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
2327
2328         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
2329         (PluginObject):
2330         (SlowNPPNew::PluginObject::PluginObject):
2331         (SlowNPPNew::PluginObject::~PluginObject):
2332         (SlowNPPNew::PluginObject::hasProperty):
2333         (SlowNPPNew::PluginObject::getProperty):
2334         (SlowNPPNew::NPP_GetValue):
2335         (SlowNPPNew):
2336
2337 2012-09-10  Tim Horton  <timothy_horton@apple.com>
2338
2339         WKTR often reports an unresponsive WebProcess on Mac bots
2340         https://bugs.webkit.org/show_bug.cgi?id=95906
2341
2342         Reviewed by Dan Bernstein.
2343
2344         Attempt to work around resource contention issues by increasing the NRWT
2345         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
2346
2347         * Scripts/webkitpy/layout_tests/port/base.py:
2348         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
2349         * WebKitTestRunner/TestController.cpp:
2350         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
2351
2352 2012-09-07  Jer Noble  <jer.noble@apple.com>
2353
2354         <audio> and <video> should send Do Not Track when appropriate
2355         https://bugs.webkit.org/show_bug.cgi?id=96134
2356
2357         Reviewed by Eric Carlson.
2358
2359         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
2360         WTR. Add FrameLoaderClient client methods for retrieving that value.
2361
2362         * DumpRenderTree/TestRunner.cpp:
2363         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
2364         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
2365         * DumpRenderTree/TestRunner.h:
2366         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
2367         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2368         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2369         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
2370             Pass the question on to the TestRunner.
2371         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2372         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2373         (WTR::InjectedBundlePage::InjectedBundlePage):
2374             Add the setShouldSendDoNotTrackHTTPHeader client function.
2375         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
2376             Pass the question on to the TestRunner.
2377         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2378         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2379         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2380         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2381         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
2382
2383 2012-09-10  Ojan Vafai  <ojan@chromium.org>
2384
2385         Make EFL bots work on the flakiness dashboard
2386         https://bugs.webkit.org/show_bug.cgi?id=96164
2387
2388         Reviewed by Tony Chang.
2389
2390         Also, update outdated unittests that had started failing.
2391
2392         * TestResultServer/static-dashboards/builders.js:
2393         (isWebkitTestRunner):
2394         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2395         (nonChromiumPlatform):
2396         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2397         (test):
2398
2399 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
2400
2401         [chromium] MediaStream API: Remove the Descriptor postfix
2402         https://bugs.webkit.org/show_bug.cgi?id=96268
2403
2404         Reviewed by Adam Barth.
2405
2406         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
2407         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
2408
2409         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2410         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2411         (MockWebRTCPeerConnectionHandler::createOffer):
2412         (MockWebRTCPeerConnectionHandler::createAnswer):
2413         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2414         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2415         (MockWebRTCPeerConnectionHandler::localDescription):
2416         (MockWebRTCPeerConnectionHandler::remoteDescription):
2417         (MockWebRTCPeerConnectionHandler::addICECandidate):
2418         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2419         (MockWebRTCPeerConnectionHandler):
2420
2421 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
2422
2423         [Gtk] failure to build jhbuild dependencies with cups 1.6
2424         https://bugs.webkit.org/show_bug.cgi?id=95991
2425
2426         Reviewed by Gustavo Noronha Silva.
2427
2428         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
2429         building with cups >= 1.6 [GNOME #670373].
2430
2431         * gtk/jhbuild.modules:
2432
2433 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2434
2435         [EFL][DRT] Encoding issue in printed console messages
2436         https://bugs.webkit.org/show_bug.cgi?id=96263
2437
2438         Reviewed by Kenneth Rohde Christiansen.
2439
2440         Correctly handle CONSOLE messages that contain non-ascii
2441         characters in EFL's DRT. We need to use String::fromUTF8()
2442         to construct a WTF::String from a raw string.
2443
2444         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2445         (onConsoleMessage):
2446
2447 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2448
2449         [WK2][WTR] User style sheet location should be reset before each test
2450         https://bugs.webkit.org/show_bug.cgi?id=96262
2451
2452         Reviewed by Kenneth Rohde Christiansen.
2453
2454         User style sheet location is reset before each test now.
2455
2456         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2457         (WTR::InjectedBundle::beginTesting):
2458
2459 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
2460
2461         Fix build of WTR with Qt on Windows
2462         https://bugs.webkit.org/show_bug.cgi?id=96249
2463
2464         Reviewed by Kenneth Rohde Christiansen.
2465
2466         Windows loves to define min and max as macros, which beautifully
2467         clashes in many places where min and max are used as variable or method
2468         names. It can be convinced not to do this when min and max are already
2469         define as macros (expanding to themselves). We have this kind of
2470         workaround in config.h files all over WebKit and as it turns out when
2471         building WTR with Qt on Windows we do end up with such a clash. Therefore
2472         we need the same workaround.
2473
2474         * WebKitTestRunner/config.h:
2475
2476 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2477
2478         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
2479         https://bugs.webkit.org/show_bug.cgi?id=95936
2480
2481         Reviewed by Kenneth Rohde Christiansen.
2482
2483         Enable interactive form validation setting in WebKitTestRunner as
2484         we are currently doing in DumpRenderTree. This is needed for some
2485         tests to pass.
2486
2487         * WebKitTestRunner/TestController.cpp:
2488         (WTR::TestController::resetStateToConsistentValues):
2489
2490 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
2491
2492         Clean up the code in XvfbDriver
2493         https://bugs.webkit.org/show_bug.cgi?id=96202
2494
2495         Reviewed by Philippe Normand.
2496
2497         Changes:
2498         - Remove unneeded imports,
2499         - assign the _lock_file member variable when the display number is determined,
2500         - no need for parentheses around a single string format argument,
2501         - use FileSystem.exists method when checking if lock file is present as it
2502         makes the intention much more clearer.
2503
2504         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2505         (XvfbDriver._start):
2506         (XvfbDriver.stop):
2507
2508 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
2509
2510         Make the String initialization on the function side of String::number()
2511         https://bugs.webkit.org/show_bug.cgi?id=95940
2512
2513         Reviewed by Benjamin Poulain.
2514
2515         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2516         (testBoundaries):
2517         (testNumbers):
2518
2519 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
2520
2521         [WK2] expose element rect for color input type
2522         https://bugs.webkit.org/show_bug.cgi?id=91664
2523
2524         Reviewed by Simon Hausmann.
2525
2526         Update the QML logic in MiniBrowser to take advantage of this.
2527         The picker size is now hardcoded and we try to place it below the
2528         input element if possible.
2529
2530         * MiniBrowser/qt/qml/ColorChooser.qml:
2531
2532 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
2533
2534         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
2535         https://bugs.webkit.org/show_bug.cgi?id=95329
2536
2537         Reviewed by Kenneth Rohde Christiansen.
2538
2539         Explicitely disable TabToLinks setting in WebKitTestRunner.
2540         Tests override the "WebKitTabToLinksPreferenceKey" preference
2541         to enable it.
2542
2543         * WebKitTestRunner/TestController.cpp:
2544         (WTR::TestController::resetStateToConsistentValues):
2545
2546 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
2547
2548         webkit.py gdb pretty printer can't print CString
2549         https://bugs.webkit.org/show_bug.cgi?id=96068
2550
2551         Reviewed by Tony Chang.
2552
2553         Update WTFCStringPrinter to follow r126191.
2554
2555         * gdb/webkit.py:
2556         (WTFCStringPrinter.to_string):
2557
2558 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
2559
2560         Rename the ustring() accessor to string()
2561         https://bugs.webkit.org/show_bug.cgi?id=95919
2562
2563         Reviewed by Geoffrey Garen.
2564
2565         Update EFL's DRT.
2566
2567         Fix some string conversion that have been made useless
2568         with recent changes.
2569
2570         * DumpRenderTree/efl/EventSender.cpp:
2571         (keyPadNameFromJSValue):
2572         (keyNameFromJSValue):
2573         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2574         (TestRunner::queueLoad):
2575         (TestRunner::addOriginAccessWhitelistEntry):
2576         (TestRunner::removeOriginAccessWhitelistEntry):
2577         (TestRunner::setUserStyleSheetLocation):
2578         (TestRunner::setValueForUser):
2579         (TestRunner::elementDoesAutoCompleteForElementWithId):
2580         (TestRunner::execCommand):
2581         (TestRunner::findString):
2582         (TestRunner::isCommandEnabled):
2583         (TestRunner::clearApplicationCacheForOrigin):
2584         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2585         (TestRunner::pauseAnimationAtTimeOnElementWithId):
2586         (TestRunner::pauseTransitionAtTimeOnElementWithId):
2587         (toInt):
2588         (TestRunner::overridePreference):
2589         (TestRunner::addUserScript):
2590         (TestRunner::addUserStyleSheet):
2591         (TestRunner::evaluateInWebInspector):
2592         (TestRunner::evaluateScriptInIsolatedWorld):
2593         (TestRunner::setTextDirection):
2594         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2595         (LoadItem::invoke):
2596         (LoadHTMLStringItem::invoke):
2597         (ScriptItem::invoke):
2598
2599 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
2600
2601         Extend third-party storage blocking API to optionally allow blocking all storage
2602         https://bugs.webkit.org/show_bug.cgi?id=95915
2603
2604         Reviewed by Brady Eidson.
2605
2606         Modified API test to use new revised API.
2607
2608         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2609         (TestWebKitAPI::TEST):
2610
2611 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2612
2613         AX: WebCore accessibility roles should be cross-platform
2614         https://bugs.webkit.org/show_bug.cgi?id=94870
2615
2616         Reviewed by Chris Fleizach.
2617
2618         Add debug strings to Chromium for new accessibility roles.
2619
2620         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2621         (roleToString):
2622
2623 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2624
2625         AX: Chromium needs access to canvasHasFallbackContent
2626         https://bugs.webkit.org/show_bug.cgi?id=96124
2627
2628         Reviewed by Chris Fleizach.
2629
2630         Distinguish between canvas roles with and without fallback
2631         content on Chromium.
2632
2633         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2634         (getRole):
2635
2636 2012-09-07  Ojan Vafai  <ojan@chromium.org>
2637
2638         Handle non-existant TestExpectations files gracefully
2639         https://bugs.webkit.org/show_bug.cgi?id=96149
2640
2641         Reviewed by Eric Seidel.
2642
2643         Even when we get rid of Skipped files, we shouldn't have each port
2644         require a TestExpectations file for each platform if it doesn't
2645         need one.
2646
2647         * Scripts/webkitpy/layout_tests/port/base.py:
2648         (Port.expectations_dict):
2649         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2650         (PortTest.test_nonexistant_expectations):
2651
2652 2012-09-07  Tony Chang  <tony@chromium.org>
2653
2654         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
2655         https://bugs.webkit.org/show_bug.cgi?id=96136
2656
2657         Reviewed by Ojan Vafai.
2658
2659         When we renamed the file to TestExpectations, it was no longer considered a text file so
2660         it was no longer being checked. Since then, test_expectations_overrides() has been removed
2661         from the port object, so I've removed that from the check. I'm not sure what it was
2662         supposed to do.
2663
2664         * Scripts/webkitpy/style/checker.py:
2665         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
2666         * Scripts/webkitpy/style/checkers/test_expectations.py:
2667         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
2668         (TestExpectationsChecker.check): Remove overrides param.
2669         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2670         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
2671
2672 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2673
2674         [EFL] Use same default minimum logical font size in DRT and WTR
2675         https://bugs.webkit.org/show_bug.cgi?id=96116
2676
2677         Reviewed by Martin Robinson.
2678
2679         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2680         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
2681         logical font size to 9 to match the value used in WTR.
2682         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2683         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
2684         logical font size to 9 (default value in WK2)
2685
2686 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
2687
2688         MediaStream API: add RTCPeerConnection::createAnswer
2689         https://bugs.webkit.org/show_bug.cgi?id=96092
2690
2691         Reviewed by Adam Barth.
2692
2693         Expanding and enhancing MockWebRTCPeerConnectionHandler.
2694
2695         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2696         (MockWebRTCPeerConnectionHandler::createOffer):
2697         (MockWebRTCPeerConnectionHandler::createAnswer):
2698         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2699         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2700         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2701         (MockWebRTCPeerConnectionHandler):
2702
2703 2012-09-07  Dean Jackson  <dino@apple.com>
2704
2705         Unreviewed changes to watchlist.
2706
2707         - Add new WebGL and Filters definitions
2708         - Add myself to OpenGL bugs
2709
2710         * Scripts/webkitpy/common/config/watchlist:
2711
2712 2012-09-07  Peter Beverloo  <peter@chromium.org>
2713
2714         Actually trigger the Android Tester
2715         https://bugs.webkit.org/show_bug.cgi?id=96118
2716
2717         Reviewed by Adam Barth.
2718
2719         * BuildSlaveSupport/build.webkit.org-config/config.json:
2720
2721 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
2722
2723         New time input needs accessibility
2724         https://bugs.webkit.org/show_bug.cgi?id=96032
2725
2726         Reviewed by Chris Fleizach.
2727
2728         Add support for valueDescription for testing.
2729
2730         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2731         (getValueDescription):
2732         (AccessibilityUIElement::AccessibilityUIElement):
2733         (AccessibilityUIElement::valueDescriptionGetterCallback):
2734         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2735         (AccessibilityUIElement):
2736
2737 2012-09-07  Peter Beverloo  <peter@chromium.org>
2738
2739         Add the google-android-tests build slave to the master's config
2740         https://bugs.webkit.org/show_bug.cgi?id=96113
2741
2742         Reviewed by Csaba Osztrogonác.
2743
2744         * BuildSlaveSupport/build.webkit.org-config/config.json:
2745
2746 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2747
2748         [WK2] [EFL] Set theme for WebKit2 API test runner
2749         https://bugs.webkit.org/show_bug.cgi?id=96100
2750
2751         Reviewed by Kenneth Rohde Christiansen.
2752
2753         Set the theme generated by the build for the WebKit2 API test runner.
2754
2755         * TestWebKitAPI/PlatformEfl.cmake:
2756         * TestWebKitAPI/efl/PlatformWebView.cpp:
2757         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2758
2759 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2760
2761         Unreviewed. Add Gábor Ballabás as contributor.
2762
2763         * Scripts/webkitpy/common/config/committers.py:
2764
2765 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
2766
2767         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
2768         https://bugs.webkit.org/show_bug.cgi?id=96078
2769
2770         Reviewed by Tor Arne Vestbø.
2771
2772         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
2773
2774         * qmake/mkspecs/features/default_pre.prf:
2775
2776 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2777
2778         [EFL] Add TestExpectations file for efl-wk1
2779         https://bugs.webkit.org/show_bug.cgi?id=96019
2780
2781         Reviewed by Gyuyoung Kim.
2782
2783         Update TestExpectations cascading for EFL port
2784         so that we use efl-wk1 -> efl search paths
2785         for WebKit1 EFL.
2786
2787         * Scripts/webkitpy/layout_tests/port/efl.py:
2788         (EflPort._search_paths):
2789
2790 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
2791
2792         [NRWT] XvfbDriver should stop the Xvfb more aggressively
2793         https://bugs.webkit.org/show_bug.cgi?id=95097
2794
2795         Reviewed by Dirk Pranke.
2796
2797         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
2798         terminating the process does not always work as expected, leading to timeouts
2799         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
2800         as it's not removed by the killed Xvfb process.
2801
2802         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
2803         is tested in different circumstances - whether pixel tests are enabled or not,
2804         with an arbitrary worker number or with an Xorg process already running on the system.
2805         The stopping of the driver is tested by checking that the Xvfb process is truly killed
2806         and then set to None.
2807
2808         * BuildSlaveSupport/kill-old-processes:
2809         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
2810         is left running, potentially clogging up a display at a certain position.
2811         * Scripts/webkitpy/common/system/executive_mock.py:
2812         (MockExecutive.__init__):
2813         The _running_pids is now a dictionary with process names as keys and pids
2814         as values.
2815         (MockExecutive.check_running_pid):
2816         Check whether the passed-in pid is in the _running_pids dictionary's values.
2817         (MockExecutive):
2818         (MockExecutive.running_pids):
2819         This method returns the list of all the process pids of which the name passes
2820         through the process_name_filter.
2821         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2822         Use the Executive object of the port's host to check for running pids and open
2823         new subprocesses or kill them throughout the class.
2824         (XvfbDriver._start):
2825         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
2826         start the server process after it's created.
2827         (XvfbDriver.stop):
2828         Now kills the Xvfb process instead of terminating it and waiting for it to close.
2829         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
2830         (XvfbDriverTest):
2831         (XvfbDriverTest.make_driver):
2832         (XvfbDriverTest.assertDriverStartSuccessful):
2833         (XvfbDriverTest.test_start_no_pixel_tests):
2834         (XvfbDriverTest.test_start_pixel_tests):
2835         (XvfbDriverTest.test_start_arbitrary_worker_number):
2836         (XvfbDriverTest.test_start_existing_xorg_process):
2837         (XvfbDriverTest.test_stop):
2838         (XvfbDriverTest.test_stop.FakeXvfbProcess):
2839
2840 2012-09-06  Peter Beverloo  <peter@chromium.org>
2841
2842         Introduce the Chromium Android Release (Tests) bot
2843         https://bugs.webkit.org/show_bug.cgi?id=95980
2844
2845         Reviewed by Adam Barth.
2846
2847         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
2848         which will be running layout tests on actual Android devices. Right now,
2849         four Galaxy Nexus phones are attached.
2850
2851         * BuildSlaveSupport/build.webkit.org-config/config.json:
2852
2853 2012-09-06  James Robinson  <jamesr@chromium.org>
2854
2855         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
2856         https://bugs.webkit.org/show_bug.cgi?id=96007
2857
2858         Reviewed by Adrienne Walker.
2859
2860         Fixes initialization / settings code to use WebCompositorSupport.
2861
2862         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2863         (main):
2864         * DumpRenderTree/chromium/TestShell.cpp:
2865         (TestShell::initialize):
2866         (TestShell::setPerTilePaintingEnabled):
2867
2868 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2869
2870         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
2871         https://bugs.webkit.org/show_bug.cgi?id=95995
2872
2873         Reviewed by Kenneth Rohde Christiansen.
2874
2875         Provide proper implementation for PlatformWebView::windowFrame()
2876         in EFL's WebKitTestRunner.
2877
2878         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2879         (WTR::PlatformWebView::windowFrame):
2880
2881 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
2882
2883         Fix WTF.Lrint on 32-bit platforms
2884         https://bugs.webkit.org/show_bug.cgi?id=96003
2885
2886         Reviewed by Benjamin Poulain.
2887
2888         Fixed failing WTF.Lrint test on 32-bit platforms.
2889
2890         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2891         (TestWebKitAPI::TEST):
2892
2893 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
2894
2895         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
2896         https://bugs.webkit.org/show_bug.cgi?id=95839
2897
2898         Reviewed by Adam Barth.
2899
2900         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
2901         up the task definitions a bit. There was no need to have them in the header file.
2902
2903         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2904         (RTCSessionDescriptionRequestSuccededTask):
2905         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2906         (RTCSessionDescriptionRequestFailedTask):
2907         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2908         (RTCVoidRequestTask):
2909         (RTCVoidRequestTask::RTCVoidRequestTask):
2910         (MockWebRTCPeerConnectionHandler::createOffer):
2911         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2912         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2913         (MockWebRTCPeerConnectionHandler::localDescription):
2914         (MockWebRTCPeerConnectionHandler::remoteDescription):
2915         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2916         (MockWebRTCPeerConnectionHandler):
2917
2918 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2919
2920         [Qt] Fix build on Mac OS X 10.6
2921         https://bugs.webkit.org/show_bug.cgi?id=95200
2922
2923         Reviewed by Tor Arne Vestbø.
2924
2925         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
2926         10.7 and newer.
2927
2928         * qmake/mkspecs/features/features.prf:
2929
2930 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2931
2932         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
2933         https://bugs.webkit.org/show_bug.cgi?id=95973
2934
2935         Reviewed by Kenneth Rohde Christiansen.
2936
2937         Correctly map "addSelectionKey" to "Control" modifier
2938         in WKTR's EventSender on other OSes than Mac OS X,
2939         instead of mapping it to the "Meta" modifier.
2940
2941         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2942         (WTR::parseModifier):
2943
2944 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
2945
2946         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
2947         https://bugs.webkit.org/show_bug.cgi?id=95710
2948
2949         Reviewed by Dirk Pranke.
2950
2951         The stdout / stderr output can be None so make sure
2952         we won't raise an exception in this case.
2953
2954         * Scripts/webkitpy/layout_tests/port/driver.py:
2955         (Driver.run_test):
2956
2957 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
2958
2959         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
2960         https://bugs.webkit.org/show_bug.cgi?id=95849
2961
2962         Reviewed by Kenneth Rohde Christiansen.
2963
2964         Sanitize URLs passed by the user as program
2965         argument or typed in the URL bar in order to
2966         be more tolerant.
2967
2968         * EWebLauncher/CMakeLists.txt:
2969         * EWebLauncher/main.c:
2970         (main):
2971         * EWebLauncher/url_bar.c:
2972         (_url_bar_url_get_with_protocol):
2973         (on_urlbar_key_down):
2974         * EWebLauncher/url_utils.c: Added.
2975         (has_scheme):
2976         (url_from_user_input): Add utility function to construct a
2977         URL from user input.
2978         * EWebLauncher/url_utils.h: Added.
2979         * MiniBrowser/efl/CMakeLists.txt:
2980         * MiniBrowser/efl/main.c:
2981         (main):
2982
2983 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2984
2985         [Qt] Various small Windows / MSVC build fixes
2986         https://bugs.webkit.org/show_bug.cgi?id=95934
2987
2988         Reviewed by Kenneth Rohde Christiansen.
2989
2990         setFocus takes a boolean as argument: Don't try to implicitly convert
2991         an enum to a boolean, MSVC doesn't like that. The intent here is to
2992         enable focus, so just pass true.
2993
2994         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2995         (WTR::PlatformWebView::focus):
2996
2997 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
2998
2999         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
3000         https://bugs.webkit.org/show_bug.cgi?id=95965
3001
3002         Reviewed by Tor Arne Vestbø.
3003
3004         Add ANGLE as a static library module to the Qt WebKit build system.
3005
3006         * qmake/mkspecs/features/default_post.prf:
3007         * qmake/mkspecs/modules/angle.prf: Added.
3008
3009 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
3010
3011         [WK2] Make [Qt]ViewportHandler cross platform
3012         https://bugs.webkit.org/show_bug.cgi?id=91257
3013
3014         Reviewed by Kenneth Rohde Christiansen.
3015
3016         Remove initial scale from viewport info item since it is
3017         set to -1 after applied thus it does not hold any valuable
3018         information.
3019
3020         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3021
3022 2012-09-05  Tony Chang  <tony@chromium.org>
3023
3024         [chromium] Remove dependency on webkit_user_agent
3025         https://bugs.webkit.org/show_bug.cgi?id=95886
3026
3027         Reviewed by Adam Barth.
3028
3029         The code isn't used by DumpRenderTree.
3030
3031         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3032
3033 2012-09-05  Rick Byers  <rbyers@chromium.org>
3034
3035         Update chromium DumpRenderTree for new WebGestureEvent fields
3036         https://bugs.webkit.org/show_bug.cgi?id=95573
3037
3038         Reviewed by James Robinson.
3039
3040         Update EventSender to write gesture details into the appropriate
3041         type-specific WebGestureEvent fields.
3042         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3043         (EventSender::gestureEvent):
3044         (EventSender::gestureFlingStart):
3045
3046 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
3047
3048         NRWT lies about the number of tests that it's skipping when used with --repeat-each
3049         https://bugs.webkit.org/show_bug.cgi?id=95789
3050
3051         Reviewed by Ojan Vafai.
3052
3053         Fix miscalculation in log message.
3054
3055         * Scripts/webkitpy/layout_tests/views/printing.py:
3056         (Printer.print_found):
3057
3058 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
3059
3060         Unreviewed, rolling out r127612, r127660, and r127664.
3061         http://trac.webkit.org/changeset/127612
3062         http://trac.webkit.org/changeset/127660
3063         http://trac.webkit.org/changeset/127664
3064         https://bugs.webkit.org/show_bug.cgi?id=95920
3065
3066         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3067         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3068         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3069         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3070         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3071         (MockWebRTCPeerConnectionHandler::createOffer):
3072         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3073         (MockWebRTCPeerConnectionHandler):
3074         (SuccessCallbackTask):
3075         (FailureCallbackTask):
3076
3077 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3078
3079         Ignore-metrics includes scroll offsets.
3080         https://bugs.webkit.org/show_bug.cgi?id=95845
3081
3082         Reviewed by Dirk Pranke.
3083
3084         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
3085
3086         * Scripts/old-run-webkit-tests:
3087         (stripMetrics):
3088         * Scripts/webkitpy/layout_tests/port/driver.py:
3089         (DriverOutput):
3090
3091 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
3092
3093         Unreviewed test fix.
3094
3095         Including a plugin source file into the build that was added in r127595.
3096
3097         * GNUmakefile.am:
3098
3099 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
3100
3101         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3102         https://bugs.webkit.org/show_bug.cgi?id=95839
3103
3104         Reviewed by Adam Barth.
3105
3106         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3107         up the task definitions a bit. There was no need to have them in the header file.
3108
3109         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3110         (RTCSessionDescriptionRequestSuccededTask):
3111         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3112         (RTCSessionDescriptionRequestFailedTask):
3113         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3114         (RTCVoidRequestTask):
3115         (RTCVoidRequestTask::RTCVoidRequestTask):
3116         (MockWebRTCPeerConnectionHandler::createOffer):
3117         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3118         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3119         (MockWebRTCPeerConnectionHandler::localDescription):
3120         (MockWebRTCPeerConnectionHandler::remoteDescription):
3121         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3122         (MockWebRTCPeerConnectionHandler):
3123
3124 2012-09-05  Kangil Han  <kangil.han@samsung.com>
3125
3126         [EFL] Remove '+=' usage in String
3127         https://bugs.webkit.org/show_bug.cgi?id=95808
3128
3129         Reviewed by Benjamin Poulain.
3130
3131         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
3132
3133         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3134         (descriptionSuitableForTestResult):
3135
3136 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3137
3138         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
3139         https://bugs.webkit.org/show_bug.cgi?id=95842
3140
3141         Reviewed by Kenneth Rohde Christiansen.
3142
3143         Provide proper implementation for TestRunner::pathToLocalResource()
3144         in EFL WKTR, identical to the one for DumpRenderTree.
3145
3146         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
3147         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
3148         are found my WebKitTestRunner.
3149
3150         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3151         (WTR::TestRunner::pathToLocalResource):
3152
3153 2012-09-05  Brady Eidson  <beidson@apple.com>
3154
3155         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
3156         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
3157
3158         Reviewed by Andy Estes.
3159
3160         Add a plug-in that always fails to initialize:
3161         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
3162         (NPPNewFails):
3163         (NPPNewFails::NPPNewFails):
3164         (NPPNewFails::NPP_New):
3165
3166         Add it to all the project files:
3167         * DumpRenderTree/DumpRenderTree.gypi:
3168         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3169         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3170         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3171         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3172
3173 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3174
3175         [Qt] Fix makefile race condition between derived sources and target
3176
3177         r121966 removed too much of the old qmake logic, including the rule
3178         that ensured that qmake_all would not trigger dual runs of qmake --
3179         one of the derived sources -qmake-all rule, and one for making the
3180         derived sources.
3181
3182         We now follow a similar pattern as before, by introducing a custom
3183         target that explicitly depends on the derived sources' qmake-all before
3184         doing a manual run of make. That ensures a single qmake run for the derived
3185         sources.
3186
3187         https://bugs.webkit.org/show_bug.cgi?id=93847
3188
3189         Reviewed by Csaba Osztrogonác.
3190
3191         * qmake/mkspecs/features/functions.prf:
3192
3193 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3194
3195         WKTR doesn't implement dumpWillCacheResponse()
3196         https://bugs.webkit.org/show_bug.cgi?id=94607
3197
3198         Reviewed by Kenneth Rohde Christiansen.
3199
3200         Define shouldCacheResponse() callback in resource
3201         load client and provide implementation for
3202         dumpWillCacheResponse() in WebKitTestRunner.
3203
3204         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3205         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3206         (WTR::InjectedBundlePage::InjectedBundlePage):
3207         (WTR::InjectedBundlePage::shouldCacheResponse):
3208         (WTR):
3209         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3210         (InjectedBundlePage):
3211         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3212         (WTR::TestRunner::TestRunner):
3213         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3214         (WTR::TestRunner::dumpWillCacheResponse):
3215         (WTR::TestRunner::shouldDumpWillCacheResponse):
3216         (TestRunner):
3217
3218 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3219
3220         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
3221         https://bugs.webkit.org/show_bug.cgi?id=92735
3222
3223         Reviewed by Hajime Morita.
3224
3225         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
3226
3227         * DumpRenderTree/TestRunner.cpp:
3228         (TestRunner::staticFunctions):
3229         * DumpRenderTree/TestRunner.h:
3230         (TestRunner):
3231         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3232         (TestRunner::addUserStyleSheet):
3233         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3234         (DRTTestRunner::DRTTestRunner):
3235         (DRTTestRunner::hasCustomPageSizeStyle):
3236         * DumpRenderTree/chromium/DRTTestRunner.h:
3237         (DRTTestRunner):
3238         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3239         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3240         * DumpRenderTree/mac/TestRunnerMac.mm:
3241         * DumpRenderTree/qt/TestRunnerQt.cpp:
3242         (TestRunner::evaluateScriptInIsolatedWorld):
3243         * DumpRenderTree/qt/TestRunnerQt.h:
3244         (TestRunner):
3245         * DumpRenderTree/win/TestRunnerWin.cpp:
3246         * DumpRenderTree/wx/TestRunnerWx.cpp:
3247         (TestRunner::abortModal):
3248         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3249         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3250         (WTR):
3251         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3252         (TestRunner):
3253
3254 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
3255
3256         [Qt] Automate the use of AllInOne files in the Qt build
3257         https://bugs.webkit.org/show_bug.cgi?id=95837
3258
3259         Reviewed by Tor Arne Vestbø.
3260
3261         New feature file that implements the all-in-one file automation by
3262         adding the requested all-in-one files to SOURCES and removing the files
3263         it includes from SOURCES.
3264
3265         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
3266
3267 2012-09-04  Tim Horton  <timothy_horton@apple.com>
3268
3269         Have NRWT log more output when crash logs are missing
3270         https://bugs.webkit.org/show_bug.cgi?id=95814
3271
3272         Reviewed by Dan Bernstein.
3273
3274         Log the stderr and stdout of the test, in order to provide slightly more
3275         context when the WebProcess times out while running tests.
3276
3277         * Scripts/webkitpy/layout_tests/port/driver.py:
3278         (Driver.run_test):
3279
3280 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3281
3282         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
3283         https://bugs.webkit.org/show_bug.cgi?id=95770
3284
3285         Reviewed by Adam Barth.
3286
3287         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3288         (ChromiumAndroidDriver.__init__):
3289         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
3290         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
3291         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
3292         (ChromiumAndroidDriver._push_executable):
3293         (ChromiumAndroidDriver._push_fonts):
3294         (ChromiumAndroidDriver._push_test_resources):
3295         (ChromiumAndroidDriver._run_adb_command):
3296         (ChromiumAndroidDriver._get_last_stacktrace):
3297         (ChromiumAndroidDriver._get_crash_log):
3298         (ChromiumAndroidDriver._start):
3299         (ChromiumAndroidDriver._start_once):
3300         (ChromiumAndroidDriver._start_once.deadlock_detector):
3301         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3302         (ChromiumAndroidDriverTest.test_get_crash_log):
3303
3304 2012-09-04  Satish Sampath  <satish@chromium.org>
3305
3306         Run git commands within the checkout directory
3307         https://bugs.webkit.org/show_bug.cgi?id=95742
3308
3309         Reviewed by Eric Seidel.
3310
3311         git commands run from scm/git.py are sometimes run with cwd set to the
3312         checkout_root and other times with whatever directory was the default cwd.
3313         Instead all these should run with the checkout root set as the cwd
3314         (except where we explicitly need a different path)
3315
3316         * Scripts/webkitpy/common/checkout/scm/git.py:
3317         (Git._run_git):
3318         (Git.find_checkout_root):
3319         (Git.discard_local_commits):
3320         (Git.local_commits):
3321         (Git.working_directory_is_clean):
3322         (Git.clean_working_directory):
3323         (Git.add_list):
3324         (Git.delete_list):
3325         (Git.exists):
3326         (Git._current_branch):
3327         (Git._changes_files_for_commit):
3328         (Git.revisions_changing_file):
3329         (Git.svn_revision):
3330         (Git._run_git_svn_find_rev):
3331         (Git.contents_at_revision):
3332         (Git.diff_for_file):
3333         (Git.show_head):
3334         (Git.committer_email_for_revision):
3335         (Git.apply_reverse_diff):
3336         (Git.revert_files):
3337         (Git.commit_with_message):
3338         (Git._commit_on_branch):
3339         (Git.svn_commit_log):
3340         (Git.last_svn_commit_log):
3341         (Git.svn_blame):
3342         (Git._branch_ref_exists):
3343         (Git.delete_branch):
3344         (Git.remote_merge_base):
3345         (Git.commit_locally_with_message):
3346         (Git.push_local_commits_to_server):
3347         (Git.commit_ids_from_commitish_arguments):
3348         (Git.commit_message_for_local_commit):
3349         (Git.files_changed_summary_for_commit):
3350
3351 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3352
3353         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
3354         https://bugs.webkit.org/show_bug.cgi?id=95734
3355
3356         Reviewed by Adam Barth.
3357
3358         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3359         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3360         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3361         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3362         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3363         (MockWebRTCPeerConnectionHandler::createOffer):
3364         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3365         (MockWebRTCPeerConnectionHandler):
3366         (MockWebRTCPeerConnectionHandler::taskList):
3367         (SuccessCallbackTask):
3368         (FailureCallbackTask):
3369
3370 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3371
3372         [Chromium-Android] Output time and thread info in crash log
3373         https://bugs.webkit.org/show_bug.cgi?id=95768
3374
3375         Reviewed by Adam Barth.
3376
3377         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3378         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
3379
3380 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3381
3382         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
3383         https://bugs.webkit.org/show_bug.cgi?id=95721
3384
3385         Reviewed by Adam Barth.
3386
3387         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3388         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
3389         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
3390         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
3391         (MockWebMediaStreamCenter):
3392
3393 2012-09-04  Tony Chang  <tony@chromium.org>
3394
3395         Elide test names when running new-run-webkit-tests
3396         https://bugs.webkit.org/show_bug.cgi?id=95626
3397
3398         Reviewed by Dirk Pranke.
3399
3400         When the test name exceeds the number of terminal columns, it leaves
3401         text on the screen. Avoid this by eliding the test name when running
3402         tests. This is similar to what ninja does when compiling.
3403
3404         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3405         (MeteredStream):
3406         (MeteredStream.number_of_columns): Helper method to get number of
3407         terminal columns. Won't work on Win32 python, but meh.
3408         * Scripts/webkitpy/layout_tests/views/printing.py:
3409         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
3410         because stderr appears to be ascii only.
3411         (Printer.print_started_test): Route through _test_status_line.
3412         (Printer.print_finished_test): Route through _test_status_line.
3413         (Printer._print_test_trace): Route through _test_status_line.
3414         (Printer._print_baseline): Route through _test_status_line.
3415         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3416         (test_test_status_line): Test for _test_status_line.
3417
3418 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
3419
3420         [GTK] Print API missing documentation when generating gtkdoc
3421         https://bugs.webkit.org/show_bug.cgi?id=95703
3422
3423         Reviewed by Carlos Garcia Campos.
3424
3425         Print out API missing documentation when generating gtkdoc. This makes it
3426         easier to fix documentation errors.
3427
3428         * gtk/generate-gtkdoc:
3429         (print_missing_api): Added.
3430         (generate_doc): Inline the rebase step, since it now reports an error
3431         when you try to rebase without generating documentation first.
3432         * gtk/gtkdoc.py:
3433         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
3434         generating documentation first to enable a small cleanup at the caller.
3435         (GTKDoc.api_missing_documentation): Added.
3436
3437 2012-09-04  Vincent Scheib  <scheib@chromium.org>
3438
3439         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
3440         https://bugs.webkit.org/show_bug.cgi?id=95628
3441
3442         Reviewed by James Robinson.
3443
3444         Future tests need the ability to respond asynchronously that
3445         pointer lock requests have been accepted or rejected. This patch
3446         adds the following:
3447             testRunner.setPointerLockWillRespondAsynchronously();
3448             testRunner.didAcquirePointerLock();
3449             testRunner.didNotAcquirePointerLock();
3450
3451         Tested in existing test:
3452             pointerlockchange-pointerlockerror-events.html
3453
3454         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3455         (DRTTestRunner::DRTTestRunner):
3456         (DRTTestRunner::didAcquirePointerLock):
3457         (DRTTestRunner::didNotAcquirePointerLock):
3458         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
3459         * DumpRenderTree/chromium/DRTTestRunner.h:
3460         (DRTTestRunner):
3461         * DumpRenderTree/chromium/WebViewHost.cpp:
3462         (WebViewHost::requestPointerLock):
3463         (WebViewHost::didAcquirePointerLock):
3464         (WebViewHost::didNotAcquirePointerLock):
3465         * DumpRenderTree/chromium/WebViewHost.h:
3466         (WebViewHost):
3467         (WebViewHost::setPointerLockWillRespondAsynchronously):
3468
3469 2012-09-04  Ojan Vafai  <ojan@chromium.org>
3470
3471         Move content shell bots to their own builder group
3472         https://bugs.webkit.org/show_bug.cgi?id=95765
3473
3474         Reviewed by Adam Barth.
3475
3476         In their current state of instability, they add too much noise. Once they get more stable,
3477         we can add them back to the regular group or just have them replace the other bots.
3478
3479         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
3480
3481         * TestResultServer/static-dashboards/builders.js:
3482         (isWebkitTestRunner):
3483         (isChromiumContentShellTestRunner):
3484         (isChromiumWebkitTipOfTreeTestRunner):
3485         (loadBuildersList):
3486
3487 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
3488
3489         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
3490         https://bugs.webkit.org/show_bug.cgi?id=95689
3491
3492         Reviewed by Kenneth Rohde Christiansen.
3493
3494         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
3495         So, there are bugs that key events are always generated in url bar although
3496         the user clicked the web view.
3497
3498         This patch recovers the focus of the web view when left button is pressed and
3499         adds for MiniBrowser to toggle the focus when middle button is pressed
3500         like EWebLauncher already did.
3501
3502         * EWebLauncher/main.c:
3503         (on_mouse_down):
3504         * MiniBrowser/efl/main.c:
3505         (on_mouse_down):
3506         (browserCreate):
3507
3508 2012-09-03  Tao Bai  <michaelbai@chromium.org>
3509
3510         Added ANDROID_GDBSERVER definition for Ant
3511         https://bugs.webkit.org/show_bug.cgi?id=95265
3512
3513         Reviewed by Adam Barth.
3514
3515         ANDROID_GDBSERVER will replace ANDROID_TOOLCHAIN, because the ANDROID_TOOLCHAIN
3516         is only used for finding the gdbserver.
3517
3518         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3519         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3520
3521 2012-09-03  Tommy Widenflycht  <tommyw@google.com>
3522
3523         MediaStream API: Add Ice-related functionality to RTCPeerConnection
3524         https://bugs.webkit.org/show_bug.cgi?id=95565
3525
3526         Reviewed by Adam Barth.
3527
3528         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3529         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3530         (MockWebRTCPeerConnectionHandler::updateICE):
3531         (MockWebRTCPeerConnectionHandler::addICECandidate):
3532         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3533         (MockWebRTCPeerConnectionHandler):
3534
3535 2012-09-03  Christophe Dumez  <christophe.dumez@intel.com>
3536
3537         [EFL] Fix resizing issues related to URL bar in Minibrowser / EWebLauncher
3538         https://bugs.webkit.org/show_bug.cgi?id=95670
3539
3540         Reviewed by Kenneth Rohde Christiansen.
3541
3542         Fix layout issues related to the URL bar in Minibrowser
3543         and EWebLauncher when the window is resized.
3544
3545         The URL bar was not resized accordingly and the Web
3546         page was moved behing the URL bar, hiding part of it.
3547
3548         * EWebLauncher/main.c:
3549         (on_ecore_evas_resize):
3550         (closeWindow):
3551         * EWebLauncher/url_bar.c:
3552         (url_bar_width_set):
3553         (url_bar_add):
3554         * EWebLauncher/url_bar.h:
3555         * MiniBrowser/efl/main.c:
3556         (on_ecore_evas_resize):
3557         (main):
3558
3559 2012-09-01  Xianzhu Wang  <wangxianzhu@chromium.org>
3560
3561         [Chromium-Android] Remove hard-coded skipped directories in chromium_android.py
3562         https://bugs.webkit.org/show_bug.cgi?id=95605
3563
3564         Reviewed by Dirk Pranke.
3565
3566         Now skipping rules are put in LayoutTests/platform/chromium-android/TestExpectations.
3567
3568         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3569         (ChromiumAndroidPort.check_sys_deps):
3570         (ChromiumAndroidPort.expectations_files):
3571         (ChromiumAndroidPort.clean_up_test_run):
3572
3573 2012-09-01  Joanmarie Diggs  <jdiggs@igalia.com>
3574
3575         [Gtk] Incorrect/unexpected characters in the text of certain accessibles
3576         https://bugs.webkit.org/show_bug.cgi?id=95180
3577
3578         Reviewed by Chris Fleizach.
3579
3580         The bug that was fixed stood in the way of fully implementing stringValue().
3581         Testing that the bug is fixed requires stringValue() to be fully implemented
3582         and object replacement characters to be printable.
3583
3584         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3585         (replaceCharactersForResults): New method which turns object replacement
3586         characters into "<obj>" so that the characters can be properly shown in
3587         Layout Test results. Also turns "\n" into "<\\n>" so that printing the
3588         accessible text of a single object in the accessible tree doesn't mess up
3589         the readibility of the results.
3590         (AccessibilityUIElement::stringValue): Remove the code that immediately
3591         returned upon encountering an object of ATK_ROLE_PANEL and call the new
3592         replaceCharactersForResults() prior to returning the accessible string
3593         value.
3594
3595 2012-09-01  Tommy Widenflycht  <tommyw@google.com>
3596
3597         MediaStream API: Add MediaStream management to RTCPeerConnection
3598         https://bugs.webkit.org/show_bug.cgi?id=95543
3599
3600         Reviewed by Adam Barth.
3601
3602         Extending MockWebRTCPeerConnectionHandler to handle addStream/removeStream.
3603
3604         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3605         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3606         (MockWebRTCPeerConnectionHandler::addStream):
3607         (MockWebRTCPeerConnectionHandler::removeStream):
3608         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3609         (MockWebRTCPeerConnectionHandler):
3610
3611 2012-08-31  Tony Chang  <tony@chromium.org>
3612
3613         Remove ENABLE_CSS3_FLEXBOX compile time flag
3614         https://bugs.webkit.org/show_bug.cgi?id=95382
3615
3616         Reviewed by Ojan Vafai.
3617
3618         Everyone is already enabling this by default and the spec has stablized.
3619
3620         * Scripts/webkitperl/FeatureList.pm:
3621         * qmake/mkspecs/features/features.pri:
3622
3623 2012-08-31  Pratik Solanki  <psolanki@apple.com>
3624
3625         objc_msgSend and IMP should be cast appropriately before using
3626         https://bugs.webkit.org/show_bug.cgi?id=95242
3627
3628         Reviewed by Benjamin Poulain.
3629
3630         Fix for older compilers. Pass id as the return type to the template
3631         instead of relying on default type.
3632
3633         * DumpRenderTree/mac/DumpRenderTree.mm:
3634         (drt_NSFontManager_availableFontFamilies):
3635         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3636         (WTR::wtr_NSFontManager_availableFontFamilies):
3637
3638 2012-08-31  Zan Dobersek  <zandobersek@gmail.com>
3639
3640         nrwt: use scm instead of calling svn directly to get the revision in json results generator
3641         https://bugs.webkit.org/show_bug.cgi?id=89616
3642
3643         Reviewed by Eric Seidel.
3644
3645         Add the new 'executive' optional function argument to the SCM.in_working_directory
3646         class method. This way we get to reuse an Executive instance which is necessary in testing
3647         when we're operating with a mock version of the object.
3648
3649         In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
3650         the SCMDetector with the generator's FileSystem and Executive instances.
3651
3652         * Scripts/webkitpy/common/checkout/scm/detection.py:
3653         (SCMDetector.detect_scm_system):
3654         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3655         (SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
3656         Executive output and test it against expected output.
3657         * Scripts/webkitpy/common/checkout/scm/git.py:
3658         (Git.in_working_directory):
3659         * Scripts/webkitpy/common/checkout/scm/scm.py:
3660         (SCM.in_working_directory):
3661         * Scripts/webkitpy/common/checkout/scm/svn.py:
3662         (SVN.in_working_directory):
3663         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3664         (JSONResultsGeneratorBase.__init__):
3665         (JSONResultsGeneratorBase._get_svn_revision):
3666
3667 2012-08-31  Jon Lee  <jonlee@apple.com>
3668
3669         [Tests] Add basic tests to http/tests/notifications
3670         https://bugs.webkit.org/show_bug.cgi?id=95493
3671         <rdar://problem/12209303>
3672
3673         Reviewed by Alexey Proskuryakov.
3674
3675         Add permission request support for WTR.
3676
3677         * WebKitTestRunner/TestController.cpp:
3678         (WTR::TestController::initialize):
3679         (WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
3680         * WebKitTestRunner/TestController.h:
3681         (TestController):
3682
3683 2012-08-31  Jon Lee  <jonlee@apple.com>
3684
3685         [DRT] Make simulating a web click on a notification a queued task
3686         https://bugs.webkit.org/show_bug.cgi?id=95546
3687         <rdar://problem/12214170>
3688
3689         Reviewed by Alexey Proskuryakov.
3690
3691         Making the web click happen asynchronously better mimics user interaction with the platform.
3692
3693         * DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
3694         (TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
3695         not set.
3696         * DumpRenderTree/mac/DumpRenderTree.mm:
3697         (dump): Assert that the flag is not set.
3698         * DumpRenderTree/mac/TestRunnerMac.mm:
3699         (TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
3700         notification. In the case where the block gets executed after the flag has been unset, we avoid
3701         performing the click.
3702
3703 2012-08-31  Balazs Kelemen  <kbalazs@webkit.org>
3704
3705         [Qt] ImageDiff output is not in the expected form if image dimensions differ
3706         https://bugs.webkit.org/show_bug.cgi?id=95575
3707
3708         Reviewed by Csaba Osztrogonác.
3709
3710         Output 100% difference in the case of differing image dimensions so
3711         the test harness knows that we won't produce any output further.
3712         This matches the behavior of other ports.
3713
3714         * DumpRenderTree/qt/ImageDiff.cpp:
3715         (main):
3716
3717 2012-08-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3718
3719         Unreviewed, rolling out r127261.
3720         http://trac.webkit.org/changeset/127261
3721         https://bugs.webkit.org/show_bug.cgi?id=95572
3722
3723         This patch depends on other build fixes (see blockers of bug
3724         95466) which should land first (Requested by milian on
3725         #webkit).
3726
3727         * qmake/mkspecs/features/features.prf:
3728
3729 2012-08-31  Milian Wolff  <milian.wolff@kdab.com>
3730
3731         [Qt] Support WebKit2/QML on QNX
3732         https://bugs.webkit.org/show_bug.cgi?id=95466
3733
3734         Reviewed by Noam Rosenthal.
3735
3736         Enable USE(3D_GRAPHICS) on QNX again, paired with the other bug fixes
3737         this should finally work now.
3738
3739         * qmake/mkspecs/features/features.prf:
3740
3741 2012-08-30  Xianzhu Wang  <wangxianzhu@chromium.org>
3742
3743         [Chromium-Android] Skip compositing/webgl and platform/chromium/virtual/threaded/compositing/webgl tests
3744         https://bugs.webkit.org/show_bug.cgi?id=95400
3745
3746         Reviewed by Dirk Pranke.
3747
3748         WebGL is not enabled and should be skipped on Android (http://crbug.com/135877).
3749
3750         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3751         (ChromiumAndroidPort.skipped_layout_tests):
3752
3753 2012-08-30  Gustavo Noronha Silva  <gns@gnome.org>
3754
3755         [GTK] Tries to run empty string when calling generate-gtkdoc when not using jhbuild
3756         https://bugs.webkit.org/show_bug.cgi?id=95499
3757
3758         Unreviewed. One more fix to avoid trying to run the empty string.
3759
3760         * Scripts/webkitdirs.pm:
3761         (buildAutotoolsProject):
3762
3763 2012-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3764
3765         Unreviewed, rolling out r127171.
3766         http://trac.webkit.org/changeset/127171
3767         https://bugs.webkit.org/show_bug.cgi?id=95505
3768
3769         testRunner does not need dumpWebNotificationCallbacks().
3770         (Requested by jonlee on #webkit).
3771
3772         * DumpRenderTree/TestRunner.cpp:
3773         (TestRunner::TestRunner):
3774         (TestRunner::staticFunctions):
3775         * DumpRenderTree/TestRunner.h:
3776         (TestRunner):
3777         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3778         (-[MockWebNotificationProvider webView:didShowNotification:]):
3779         (-[MockWebNotificationProvider webView:didClickNotification:]):
3780         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3781         * DumpRenderTree/mac/UIDelegate.mm:
3782         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3783
3784 2012-08-30  Pratik Solanki  <psolanki@apple.com>
3785
3786         objc_msgSend and IMP should be cast appropriately before using
3787         https://bugs.webkit.org/show_bug.cgi?id=95242
3788
3789         Reviewed by Benjamin Poulain.
3790
3791         Use wtfObjcMsgSend and wtfCallIMP templates which do appropriate casts
3792         to a function pointer with right types when calling objc_msgSend and an
3793         IMP method directly.
3794
3795         * DumpRenderTree/mac/DumpRenderTree.mm:
3796         (drt_NSFontManager_availableFontFamilies):
3797         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3798         (WTR::wtr_NSFontManager_availableFontFamilies):
3799
3800 2012-08-30  Benjamin Poulain  <bpoulain@apple.com>
3801
3802         Replace JSC::UString by WTF::String
3803         https://bugs.webkit.org/show_bug.cgi?id=95271
3804
3805         Reviewed by Geoffrey Garen.
3806
3807         Get rid of UString.
3808
3809         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3810         * gdb/webkit.py:
3811         (WTFStringPrinter.to_string):
3812         (JSCIdentifierPrinter.to_string):
3813         (JSCJSStringPrinter.to_string):
3814         (add_pretty_printers):
3815
3816 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3817
3818         nrwt should have TestExpectations everywhere we have Skipped files for apple ports
3819         https://bugs.webkit.org/show_bug.cgi?id=95495
3820
3821         Reviewed by Ojan Vafai.
3822
3823         This is a follow-on to bug 95370 that adds in support for
3824         platform/wk2/TestExpectations and
3825         platform/{mac,win}-$version/TestExpectations.
3826
3827         * Scripts/webkitpy/layout_tests/port/apple.py:
3828         (ApplePort.expectations_files):
3829         * Scripts/webkitpy/layout_tests/port/base.py:
3830         (Port._skipped_file_search_paths):
3831         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3832         (MacTest.test_expectations_files):
3833         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3834         (MockDRTPortTest.make_port):
3835         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3836         (WinPortTest.test_expectations_files):
3837
3838 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3839
3840         executive.run_in_parallel() hangs if given nothing to do
3841         https://bugs.webkit.org/show_bug.cgi?id=95387
3842
3843         Reviewed by Ojan Vafai.
3844
3845         Check to make sure that Executive.run_in_parallel() requires
3846         a non-empty list of commands to execute; passing an empty list
3847         seems surely like a programming error.
3848
3849         * Scripts/webkitpy/common/system/executive.py:
3850         (Executive.run_in_parallel):
3851         * Scripts/webkitpy/common/system/executive_unittest.py:
3852         (ExecutiveTest.test_run_in_parallel_assert_nonempty):
3853
3854 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3855
3856         decide what (and how) we should set the tolerance for ref test pixel compares and test for that
3857         https://bugs.webkit.org/show_bug.cgi?id=94746
3858
3859         Reviewed by Ojan Vafai.
3860
3861         Add an assertion to diff_image() to check that we are passing
3862         tolerance=0 explicitly when diffing ref test results.
3863
3864         * Scripts/webkitpy/layout_tests/port/test.py:
3865         (TestPort.diff_image):
3866
3867 2012-08-30  Dirk Pranke  <dpranke@chromium.org>
3868
3869         NRWT should look in mac-wk2 for a TestExpecations file
3870         https://bugs.webkit.org/show_bug.cgi?id=95370
3871
3872         Reviewed by Ojan Vafai.
3873
3874         Adds support for mac-wk2 and win-wk2 to expectations_files()
3875         for the apple mac and apple win ports.
3876         
3877         * Scripts/webkitpy/layout_tests/port/apple.py:
3878         (ApplePort.expectations_files):
3879         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3880         (MacTest.test_expectations_files):
3881         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3882         (WinTest.test_expectations_files):
3883         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3884         (PortTestCase.test_expectations_files):
3885
3886 2012-08-30  Jon Lee  <jonlee@apple.com>
3887
3888         [Mac] Add testRunner.dumpWebNotificationCallbacks() to DRT
3889         https://bugs.webkit.org/show_bug.cgi?id=95232
3890         <rdar://problem/12190776>
3891
3892         Reviewed by Alexey Proskuryakov.
3893
3894         Add additional output when running test, if testRunner.dumpWebNotificationCallbacks() is called.
3895
3896         * DumpRenderTree/TestRunner.cpp:
3897         (TestRunner::TestRunner):
3898         (dumpWebNotificationCallbacksCallback):
3899         (TestRunner::staticFunctions):
3900         * DumpRenderTree/TestRunner.h:
3901         (TestRunner):
3902         (TestRunner::dumpWebNotificationCallbacks):
3903         (TestRunner::setDumpWebNotificationCallbacks):
3904         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3905         (-[WebNotification _drt_descriptionSuitableForTestResult]):
3906         (-[MockWebNotificationProvider webView:didShowNotification:]):
3907         (-[MockWebNotificationProvider webView:didClickNotification:]):
3908         (-[MockWebNotificationProvider webView:didCloseNotifications:]):
3909         * DumpRenderTree/mac/UIDelegate.mm:
3910         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]):
3911
3912 2012-08-30  Tommy Widenflycht  <tommyw@google.com>
3913
3914         MediaStream API: Introduce MediaConstraints
3915         https://bugs.webkit.org/show_bug.cgi?id=95198
3916
3917         Reviewed by Adam Barth.
3918
3919         Extending the MockWebRTCPeerConnectionHandler with MediaConstraints functionality.
3920
3921         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3922         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
3923         (isSupportedConstraint):
3924         (isValidConstraint):
3925         (MockWebRTCPeerConnectionHandler::initialize):
3926         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3927         (MockWebRTCPeerConnectionHandler):
3928
3929 2012-08-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3930
3931         [WK2][WTR] Add didReceiveServerRedirectForProvisionalLoadForFrame dumping
3932         https://bugs.webkit.org/show_bug.cgi?id=95454
3933
3934         Reviewed by Kenneth Rohde Christiansen.
3935
3936         Added didReceiveServerRedirectForProvisionalLoadForFrame dumping to WTR.
3937
3938         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3939         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3940
3941 2012-08-30  Leo Yang  <leoyang@rim.com>
3942
3943         Update my email address.
3944
3945         Not reviewed.
3946
3947         * Scripts/webkitpy/common/config/committers.py:
3948
3949 2012-08-30  Jochen Eisinger  <jochen@chromium.org>
3950
3951         [NRWT] Add support for recognizing arbitrary process names in crash lines
3952         https://bugs.webkit.org/show_bug.cgi?id=95435
3953
3954         Reviewed by Adam Barth.
3955
3956         When running layout tests in the chromium port using the content shell,
3957         we want to be able to report sub-process crashes as well.
3958
3959         * Scripts/webkitpy/layout_tests/port/driver.py:
3960         (Driver._check_for_driver_crash):
3961         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3962         (DriverTest.test_check_for_driver_crash):
3963
3964 2012-08-29  Zan Dobersek  <zandobersek@gmail.com>
3965
3966         Random test-webkitpy failures on the buildbot
3967         https://bugs.webkit.org/show_bug.cgi?id=95096
3968
3969         Reviewed by Dirk Pranke.
3970
3971         Suppress occasional errors when running test-webkitpy on GTK builders
3972         by running these tests serially. The 64-bit Release builder is especially
3973         prone to these as it can run up to 24 tests in parallel.
3974
3975         Despite the tests not being run in parallel, the testing only lasts a handful
3976         of seconds more, so this is a worthy trade-off to avoid unnecessary
3977         false-alarm redness on the GTK builders.
3978
3979         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3980         (RunPythonTests.start):
3981
3982 2012-08-29  Benjamin Poulain  <bpoulain@apple.com>
3983
3984         REGRESSION(r126780): Crash using StringImpl::is8Bit before checking if there is an impl
3985         https://bugs.webkit.org/show_bug.cgi?id=95380
3986
3987         Reviewed by Michael Saboff.
3988
3989         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3990         Add very basic tests for String::ascii(). This covers the case of null strings that caused
3991         the crash.
3992
3993 2012-08-29  Dominic Mazzoni  <dmazzoni@google.com>
3994
3995         AX: Canvas should have a distinct role
3996         https://bugs.webkit.org/show_bug.cgi?id=95248
3997
3998         Reviewed by Chris Fleizach.
3999
4000         Add support for canvas accessibility role.
4001
4002         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
4003         (roleToString):
4004
4005 2012-08-29  José Dapena Paz  <jdapena@igalia.com>
4006
4007         [Gtk] Process Gtk 3.4 smooth scroll events properly
4008         https://bugs.webkit.org/show_bug.cgi?id=88070
4009
4010         Added continousMouseScrollBy support in WebKitTestRunner, and added
4011         implementation for gtk, and stub for Qt, mac and EFL.
4012
4013         Added layout tests support for smooth scroll in Gtk 3.4, and use smooth
4014         scroll for emulating multi-tick mouseScrollBy events.
4015
4016         Reviewed by Martin Robinson.
4017
4018         * DumpRenderTree/gtk/EventSender.cpp:
4019         (mouseScrollByCallback):
4020         (continuousMouseScrollByCallback):
4021         * WebKitTestRunner/EventSenderProxy.h:
4022         (EventSenderProxy):
4023         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
4024         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4025         (WTR::EventSendingController::mouseScrollBy):
4026         (WTR):
4027         (WTR::EventSendingController::continuousMouseScrollBy):
4028         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
4029         (EventSendingController):
4030         * WebKitTestRunner/TestController.cpp:
4031         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
4032         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
4033         (WTR):
4034         (WTR::EventSenderProxy::mouseScrollBy):
4035         (WTR::EventSenderProxy::continuousMouseScrollBy):
4036         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
4037         (WTR):
4038         (WTR::EventSenderProxy::continuousMouseScrollBy):
4039         * WebKitTestRunner/mac/EventSenderProxy.mm:
4040         (WTR::EventSenderProxy::continuousScrollBy):
4041         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
4042         (WTR::EventSenderProxy::continuousMouseScrollBy):
4043         (WTR):
4044
4045 2012-08-29  Alex Sakhartchouk  <alexst@chromium.org>
4046
4047         [chromium] Support high DIP pixel tests with DumpRenderTree
4048         https://bugs.webkit.org/show_bug.cgi?id=94935
4049
4050         Reviewed by James Robinson.
4051
4052         Adding device scale factor into the drt image dumping code
4053
4054         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4055         (DRTTestRunner::reset):
4056         (DRTTestRunner::setBackingScaleFactor):
4057         * DumpRenderTree/chromium/WebViewHost.cpp:
4058         (WebViewHost::setDeviceScaleFactor):
4059         (WebViewHost::paintInvalidatedRegion):
4060         (WebViewHost::canvas):
4061         * DumpRenderTree/chromium/WebViewHost.h:
4062         (WebViewHost):
4063
4064 2012-08-29  Kevin Funk  <kevin.funk@kdab.com>
4065
4066         Fix check-webkit-style (and probably others) when WebKit is in a git submodule
4067         https://bugs.webkit.org/show_bug.cgi?id=95177
4068
4069         Reviewed by Dirk Pranke.
4070
4071         Find the real checkout root by using 'git rev-parse --show-toplevel' instead of '--git-dir'
4072
4073         * Scripts/webkitpy/common/checkout/scm/git.py:
4074
4075 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
4076
4077         webkit-patch rebaseline-expectations wrongly touches other platforms' TestExpectations
4078         https://bugs.webkit.org/show_bug.cgi?id=95222
4079
4080         Reviewed by Adam Barth.
4081
4082         The code we had to remove REBASELINE lines from the
4083         TestExpectations files did not handle multiple files (in a
4084         cascade) correctly; we weren't limiting lines to a particular
4085         file correctly in without_rebaseline_modifier(). This patch
4086         fixes that and corrects the tests (which weren't correct and
4087         didn't cover things very well).
4088
4089         Note also that the webkit-patch rebaseline-commands are still
4090         using the include_overrides=False option in a couple places;
4091         this is never correct or needed at this point. This patch fixes
4092         the usage for webkit-patch rebaseline-expectations, but I still
4093         need to fix rebaseline-test-internal, which I will do in a
4094         separate patch (see bug 95268).
4095
4096         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4097         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
4098         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4099         (RebaseliningTest.assertRemove):
4100         (RebaseliningTest.test_remove):
4101         * Scripts/webkitpy/tool/commands/rebaseline.py:
4102         (RebaselineExpectations._update_expectations_files):
4103
4104 2012-08-29  Dirk Pranke  <dpranke@chromium.org>
4105
4106         webkit-patch rebaseline-expectations hangs
4107         https://bugs.webkit.org/show_bug.cgi?id=95243
4108
4109         Reviewed by Tony Chang.
4110
4111         Don't try to run no commands in parallel; report an error
4112         instead that we didn't find any tests to rebaseline.
4113
4114         Filed bug 95387 as well to make sure run_in_parallel() doesn't hang forever.
4115
4116         * Scripts/webkitpy/tool/commands/rebaseline.py:
4117         (RebaselineExpectations.execute):
4118         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4119         (_assert_command):
4120         (test_rebaseline_expectations_noop):
4121
4122 2012-08-29  Brady Eidson  <beidson@apple.com>
4123
4124         REGRESSION: Not sending NPP_SetWindow is causing Flash to not throttle itself
4125         <rdar://problem/12133021> and https://bugs.webkit.org/show_bug.cgi?id=95274
4126
4127         Reviewed by Sam Weinig.
4128
4129         Add a test plug-in that calls back into the page with info on the NPWindow passed
4130         in to NPP_SetWindow.
4131
4132         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4133         * DumpRenderTree/TestNetscapePlugIn/Tests/LogNPPSetWindow.cpp: Added.
4134         (LogNPPSetWindow):
4135         (LogNPPSetWindow::LogNPPSetWindow):
4136         (LogNPPSetWindow::NPP_SetWindow):
4137
4138 2012-08-29  Jon Lee  <jonlee@apple.com>
4139
4140         [Mac] Basic DRT support for web notifications
4141         https://bugs.webkit.org/show_bug.cgi?id=79492
4142         <rdar://problem/10357639>
4143
4144         Reviewed by Alexey Proskuryakov.
4145
4146         This patch implements the stubs for web notification support on DRT. Assume that when
4147         Notification.requestPermission() is called, the user always chooses to allow it. This can be easily
4148         overridden in layout tests with testRunner.denyWebNotificationPermission() when needed.
4149
4150         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add MockWebNotificationProvider.
4151         * DumpRenderTree/mac/DumpRenderTree.mm:
4152         (createWebViewAndOffscreenWindow): Set MockWebNotificationProvider singleton as the provider for the
4153         web view.
4154         (resetWebViewToConsistentStateBeforeTesting): Make sure to reset the provider's state between each test.
4155
4156         * DumpRenderTree/mac/TestRunnerMac.mm:
4157         (TestRunner::grantWebNotificationPermission): Set permission to granted for specified origin.
4158         (TestRunner::denyWebNotificationPermission): Set permission to denied for specified origin.
4159         (TestRunner::removeAllWebNotificationPermissions):
4160         (TestRunner::simulateWebNotificationClick): Retrieve the notification ID from the JS notification object, and
4161         simulate the click. This is similar to how WTR performs the click.
4162         * DumpRenderTree/mac/UIDelegate.mm:
4163         (-[UIDelegate webView:decidePolicyForNotificationRequestFromOrigin:listener:]): Assume when asked, the
4164         user allows web notifications.
4165
4166         * DumpRenderTree/mac/MockWebNotificationProvider.h: Added. Maintains a list of registered web views, known permissions,
4167         a map of notification IDs to WebNotification instances, and a map of the WebViews from which the notifications were dispatched.
4168         * DumpRenderTree/mac/MockWebNotificationProvider.mm: Added.
4169         (+[MockWebNotificationProvider shared]): The provider is a singleton.
4170         (-[MockWebNotificationProvider init]): Instantiate the permissions map.
4171         (-[MockWebNotificationProvider registerWebView:]):
4172         (-[MockWebNotificationProvider unregisterWebView:]):
4173         (-[MockWebNotificationProvider showNotification:fromWebView:]): Add the notification to the maps. Tell the web view that the
4174         notification did show.
4175         (-[MockWebNotificationProvider cancelNotification:]): Tell the web view the notification did close.
4176         (-[MockWebNotificationProvider notificationDestroyed:]): Remove the notification from the maps. Here we don't make a callback.
4177         (-[MockWebNotificationProvider clearNotifications:]): Remove the specified notifications from the maps. Here we don't make a callback.
4178         (-[MockWebNotificationProvider webView:didShowNotification:]): Delegate callback. Dispatch the show event.
4179         (-[MockWebNotificationProvider webView:didClickNotification:]): Delegate callback. Dispatch the click event.
4180         (-[MockWebNotificationProvider webView:didCloseNotifications:]): Delegate callback. Dispatch the close event.
4181         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Tell the web view we clicked the notification.
4182         (-[MockWebNotificationProvider policyForOrigin:]): Look in the permission dictionary.
4183         (-[MockWebNotificationProvider setWebNotificationOrigin:permission:]): Set the permission for the origin in the dictionary.
4184         (-[MockWebNotificationProvider removeAllWebNotificationPermissions]): Clear the permission map.
4185         (-[MockWebNotificationProvider reset]): Remove all mappings and permissions.
4186
4187 2012-08-29  Rob Buis  <rbuis@rim.com>
4188
4189         [BlackBerry] Adjust wtf include header style
4190         https://bugs.webkit.org/show_bug.cgi?id=95368
4191
4192         Reviewed by Yong Li.
4193
4194         Switch to #include <wtf/...> like the other ports.
4195
4196         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4197         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
4198         * DumpRenderTree/blackberry/PNGImageEncoder.h:
4199         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
4200         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
4201         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
4202
4203 2012-08-29  Roger Fong  <roger_fong@apple.com>
4204
4205         Update cygwin-downloader.zip to match modified downloader script.
4206         https://bugs.webkit.org/show_bug.cgi?id=76936
4207
4208         Rubber Stamped by Jon Honeycutt.
4209
4210         cygwin-downloader.py was modified in http://trac.webkit.org/changeset/126948.
4211         Updating zip to reflect changes.
4212
4213         * CygwinDownloader/cygwin-downloader.zip:
4214
4215 2012-08-29  Dominik Röttsches  <dominik.rottsches@intel.com>
4216
4217         Stylechecker warns about comparison to zero when comparing to 0.5
4218         https://bugs.webkit.org/show_bug.cgi?id=94913
4219
4220         Reviewed by Dirk Pranke.
4221
4222         According to the python documentation, \W is the character group with all
4223         non-alphanumeric characters, equivalent to [^a-zA-Z0-9_], which is equal to
4224         to [^\w]. We need to exclude the dot "." as well, so that floating point
4225         values do not trigger this warning. Adding a unit test that shows the problem.
4226
4227         * Scripts/webkitpy/style/checkers/cpp.py:
4228         (check_for_comparisons_to_zero): Modifying the regex to not get triggered by comparing to floats.
4229         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4230         (WebKitStyleTest.test_null_false_zero): Unit test exposing this issue.
4231
4232 2012-08-29  Jon Lee  <jonlee@apple.com>
4233
4234         WTR build fixes.
4235
4236         * WebKitTestRunner/CMakeLists.txt:
4237         * WebKitTestRunner/GNUmakefile.am:
4238         * WebKitTestRunner/Target.pri:
4239         * WebKitTestRunner/WebNotificationProvider.cpp:
4240         (WTR::WebNotificationProvider::showWebNotification): Make ML happier.
4241         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
4242
4243 2012-08-29  Jon Lee  <jonlee@apple.com>
4244
4245         [WK2] Basic WTR support for web notifications
4246         https://bugs.webkit.org/show_bug.cgi?id=95154
4247         <rdar://problem/12184492>
4248
4249         Reviewed by Alexey Proskuryakov.
4250
4251         Implement WTR support, without platform event output (bug 95233).
4252
4253         Legacy APIs will not be supported, since many of the tests are skipped
4254         on ports that do test notifications, and the issue with using file:// as the origin means a lot of the permissions
4255         tests won't work. Bugs 81048 and 81697 will track migrating the existing tests to use the new testRunner API, and move
4256         the tests to http/tests/notifications.
4257
4258         Permissions will be handled only in the injected bundle. This allows tests to set permission synchronously, and not
4259         require a chain of setTimeout()'s when writing a notification test. Clicking a notification, however, should
4260         be invoked from the UIProcess.
4261
4262         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4263         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4264         (WTR::InjectedBundle::didReceiveMessage): When told to "Reset", clear out all of the permissions.
4265         (WTR::InjectedBundle::postSimulateWebNotificationClick): Tell the bundle client to simulate a click based on the
4266         notification's internal ID.
4267         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4268         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4269         (WTR::TestRunner::grantWebNotificationPermission): Manually set the permission using WKBundle SPI.
4270         (WTR::TestRunner::denyWebNotificationPermission): Manually set the permission using WKBundle SPI.
4271         (WTR::TestRunner::removeAllWebNotificationPermissions):
4272         (WTR::TestRunner::simulateWebNotificationClick): Post a message through the injected bundle.
4273         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4274
4275         Because supporting web notifications goes beyond a couple functions, move all of the logic into a WebNotificationProvider
4276         class.
4277         * WebKitTestRunner/TestInvocation.cpp:
4278         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): When the injected bundle sends a message to simulate a click,
4279         TestInvocation forwards that request to the TestController.
4280         * WebKitTestRunner/TestController.cpp:
4281         (WTR::TestController::initialize): Set the provider.
4282         (WTR::TestController::resetStateToConsistentValues): Tell the provider to reset.
4283         (WTR::TestController::simulateWebNotificationClick): Tell the provider to simulate a user clicking on a platform notification.
4284         * WebKitTestRunner/TestController.h: Holds an instance to the provider.
4285
4286         The provider maintains a pointer to one notification manager (presumably the web process associated with WTR), and a set
4287         of notification IDs that have been "shown" by the platform. This allows us to simulate a click on a notification.
4288         * WebKitTestRunner/WebNotificationProvider.h: Added.
4289         * WebKitTestRunner/WebNotificationProvider.cpp: Added.
4290         (WTR::WebNotificationProvider::showWebNotification): Adds the notification to set of shown notifications. Notifies provider that
4291         the notification got shown.
4292         (WTR::WebNotificationProvider::closeWebNotification): Removes the notification from the set. Notifies provider that the notification
4293         got closed.
4294         (WTR::WebNotificationProvider::addNotificationManager): Maintains one manager, which is fine for testing purposes.
4295         (WTR::WebNotificationProvider::removeNotificationManager): Maintains one manager.
4296         (WTR::WebNotificationProvider::notificationPermissions): When the web process starts, it maintains an initial set of known
4297         permissions. For testing purposes, we always want this set to be empty.
4298         (WTR::WebNotificationProvider::simulateWebNotificationClick): Notifies provider that the notification got "clicked".
4299         (WTR::WebNotificationProvider::reset): To reset the state, we pretend that we closed all of the platform notifications.
4300
4301         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add WebNotificationProvider.
4302
4303 2012-08-29  Kamil Blank  <k.blank@samsung.com>
4304
4305         [EFL] Add setting API for allow universal/file access from file URLs.
4306         https://bugs.webkit.org/show_bug.cgi?id=83121
4307
4308         Reviewed by Eric Seidel.
4309
4310         Implementation of setAllowUniversalAccessFromFileURLs and setAllowFileAccessFromFileURLs.
4311
4312         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4313         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):