Update inactive reviewers' status to 'contributor'.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
2
3         Update inactive reviewers' status to 'contributor'.
4
5         Accidentally skipped one at first.
6
7         * Scripts/webkitpy/common/config/contributors.json:
8
9 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
10
11         Update inactive reviewers' status to 'contributor'.
12
13         * Scripts/webkitpy/common/config/contributors.json: The change.
14
15         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
16         * Scripts/webkitpy/common/checkout/checkout_mock.py:
17         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
18         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
19         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
20         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
21         * Scripts/webkitpy/tool/commands/queries_unittest.py:
22         * Scripts/webkitpy/tool/commands/upload_unittest.py:
23         Sadly, regression tests operate on a crazy mix of mock and live data for
24         contributors.json. It would be a substantial project to mock all code paths,
25         so changing the tests instead.
26
27 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
28
29         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
30         https://bugs.webkit.org/show_bug.cgi?id=197171
31         <rdar://problem/47454979>
32
33         Reviewed by Youenn Fablet.
34
35         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
36         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
37         (TestWebKitAPI::TEST):
38
39 2019-04-26  David Kilzer  <ddkilzer@apple.com>
40
41         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
42         <https://webkit.org/b/197314>
43         <rdar://problem/50245252>
44
45         Reviewed by Simon Fraser.
46
47         * WebKitTestRunner/UIScriptControllerCocoa.mm:
48         (WTR::UIScriptController::lastUndoLabel const):
49         (WTR::UIScriptController::firstRedoLabel const):
50         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
51
52         * WebKitTestRunner/ios/HIDEventGenerator.mm:
53         (-[HIDEventGenerator sendEventStream:completionBlock:]):
54         - Call -autorelease to fix leak of NSDictionary.
55
56         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
57         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
58         (WTR::UIScriptController::selectFormPopoverTitle const):
59         (WTR::UIScriptController::textContentType const):
60         (WTR::UIScriptController::formInputLabel const):
61         (WTR::UIScriptController::scrollingTreeAsText const):
62         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
63
64 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
65
66         webkitpy: Running a single test will always use the default device
67         https://bugs.webkit.org/show_bug.cgi?id=195472
68         <rdar://problem/48724825>
69
70         Reviewed by Lucas Forschler.
71
72         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
73         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
74         requested will be run regardless of what shard they are in.
75
76         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
77         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
78         * Scripts/webkitpy/layout_tests/controllers/manager.py:
79         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
80         on the default device type.
81         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
82         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
83         (RunTest.test_run_part): Ditto.
84
85 2019-04-26  Alex Christensen  <achristensen@webkit.org>
86
87         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
88         https://bugs.webkit.org/show_bug.cgi?id=197165
89
90         Reviewed by Youenn Fablet.
91
92         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
93
94 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
95
96         Replace iOS build queue hardware
97         https://bugs.webkit.org/show_bug.cgi?id=197312
98
99         Reviewed by Aakash Jain.
100
101         * BuildSlaveSupport/build.webkit.org-config/config.json:
102         Use newer hardware that supports macOS Mojave.
103
104 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
105
106         check-webkit-style complains the first block in while loop.
107         https://bugs.webkit.org/show_bug.cgi?id=197307
108
109         The style checker shouldn't complain about an open brace on
110         its own line if the last non-whitespace character on the previous
111         non-blank line is another open brace, because it's likely to
112         indicate the begining of a nested code block.
113
114         Reviewed by Alex Christensen.
115
116         * Scripts/webkitpy/style/checkers/cpp.py:
117         (check_braces):
118         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
119         (WebKitStyleTest.test_braces):
120
121 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
122
123         Stop IDB transactions to release locked database files when network process is ready to suspend
124         https://bugs.webkit.org/show_bug.cgi?id=196372
125         <rdar://problem/48930116>
126
127         Reviewed by Brady Eidson.
128
129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
130         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
131         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
132         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
133         (runTestAndCheckResult):
134         (keepNetworkProcessActive):
135         (TEST):
136
137 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
138
139         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
140         https://bugs.webkit.org/show_bug.cgi?id=188357
141         <rdar://problem/42986633>
142
143         Reviewed by Dean Jackson.
144
145         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
146         tests would fall into low memory mode and have different behavior.
147         
148         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
149         to Internals, so it's shared by DRT and WTR.
150         
151         We no longer need the WK2 C SPI glue.
152
153         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
154         (WTR::InjectedBundlePage::prepare):
155
156 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
157
158         webkitpy: Including skipped tests in the final count
159         https://bugs.webkit.org/show_bug.cgi?id=197298
160         <rdar://problem/49705424>
161
162         Reviewed by Lucas Forschler.
163
164         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
165         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
166
167 2019-04-25  Timothy Hatcher  <timothy@apple.com>
168
169         Disable date and time inputs on iOSMac.
170         https://bugs.webkit.org/show_bug.cgi?id=197287
171         rdar://problem/46794376
172
173         Reviewed by Wenson Hsieh.
174
175         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
176
177 2019-04-25  Alex Christensen  <achristensen@webkit.org>
178
179         Fix test-webkitpy after r244653
180         https://bugs.webkit.org/show_bug.cgi?id=197131
181
182         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
183         Also use C++17.
184
185 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
186
187         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
188         https://bugs.webkit.org/show_bug.cgi?id=196991
189         <rdar://problem/45507423>
190
191         Reviewed by Alex Christensen.
192
193         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
194         (-[NavigationTestDelegate init]):
195         (-[NavigationTestDelegate waitForDidFinishNavigation]):
196         (-[NavigationTestDelegate webView:didFinishNavigation:]):
197         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
198         (TestWebKitAPI::TEST):
199         (TEST): Deleted.
200
201 2019-04-25  Alex Christensen  <achristensen@webkit.org>
202
203         Revert some code accidentally committed with r244653
204         https://bugs.webkit.org/show_bug.cgi?id=197131
205
206         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
207         (TestWebKitAPI::TEST):
208
209 2019-04-25  Alex Christensen  <achristensen@webkit.org>
210
211         Start using C++17
212         https://bugs.webkit.org/show_bug.cgi?id=197131
213
214         Reviewed by Darin Adler.
215
216         * DumpRenderTree/mac/Configurations/Base.xcconfig:
217         * MiniBrowser/Configurations/Base.xcconfig:
218         * MobileMiniBrowser/Configurations/Base.xcconfig:
219         * TestWebKitAPI/Configurations/Base.xcconfig:
220         * WebKitTestRunner/Configurations/Base.xcconfig:
221
222 2019-04-25  Commit Queue  <commit-queue@webkit.org>
223
224         Unreviewed, rolling out r244627.
225         https://bugs.webkit.org/show_bug.cgi?id=197282
226
227         Causing internal build failures (Requested by ShawnRoberts on
228         #webkit).
229
230         Reverted changeset:
231
232         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
233         https://bugs.webkit.org/show_bug.cgi?id=197171
234         https://trac.webkit.org/changeset/244627
235
236 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
237
238         [GTK] Hardcoded text color in input fields
239         https://bugs.webkit.org/show_bug.cgi?id=126907
240
241         Reviewed by Michael Catanzaro.
242
243         Add dark-mode command line option to MiniBrowser.
244
245         * MiniBrowser/gtk/main.c:
246         (main):
247
248 2019-04-24  Zalan Bujtas  <zalan@apple.com>
249
250         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
251         https://bugs.webkit.org/show_bug.cgi?id=196948
252         <rdar://problem/49927131>
253
254         Reviewed by Tim Horton.
255
256         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
257         (TEST):
258         The expected order of incoming events is
259         1. didInvalidateIntrinsicContentSize
260         2. didFirstLayout
261         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
262         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
263         (and remember, all we care about is ordering).
264
265 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
266
267         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
268         https://bugs.webkit.org/show_bug.cgi?id=197171
269         <rdar://problem/47454979>
270
271         Reviewed by Youenn Fablet.
272
273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
274         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
275         (TestWebKitAPI::TEST):
276
277 2019-04-24  Brady Eidson  <beidson@apple.com>
278
279         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
280         https://bugs.webkit.org/show_bug.cgi?id=191362
281
282         Reviewed by Alex Christensen.
283
284         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
285           from an XHR to a custom protocol.
286
287 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
288
289         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
290         https://bugs.webkit.org/show_bug.cgi?id=197273
291
292         Reviewed by Dean Jackson.
293
294         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
295         so that WebCoreTestSupport::resetInternalsObject() is always run.
296
297         * DumpRenderTree/mac/DumpRenderTree.mm:
298         (resetWebViewToConsistentStateBeforeTesting):
299         (runTest):
300
301 2019-04-24  John Wilander  <wilander@apple.com>
302
303         Age out unconverted Ad Click Attributions after one week.
304         https://bugs.webkit.org/show_bug.cgi?id=197238
305         <rdar://problem/50177349>
306
307         Reviewed by Chris Dumez.
308
309         This patch adds infrastructure to allow tests to expire all unconverted
310         attributions early.
311
312         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
313         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
314         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
315         * WebKitTestRunner/InjectedBundle/TestRunner.h:
316         * WebKitTestRunner/TestController.cpp:
317         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
318         * WebKitTestRunner/TestController.h:
319         * WebKitTestRunner/TestInvocation.cpp:
320         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
321
322 2019-04-24  Chris Dumez  <cdumez@apple.com>
323
324         Fix flaky crashes in a couple of PSON API tests
325         https://bugs.webkit.org/show_bug.cgi?id=197239
326
327         Reviewed by Tim Horton.
328
329         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
330
331         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
332
333 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
334
335         Make it possible to control the renderTreeAsText output by setting options on testRunner
336         https://bugs.webkit.org/show_bug.cgi?id=197133
337
338         Reviewed by Sam Weinig.
339
340         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
341         that make sense in testing (those that don't dump unstable data like addresses), and plumb
342         these flags through the various framework layers.
343
344         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
345
346         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
347         and hand-code DumpRenderTree bindings.
348
349         Some cleanup of the TestRunners, using member initializers.
350
351         * DumpRenderTree/TestRunner.cpp:
352         (TestRunner::TestRunner):
353         (setRenderTreeDumpOptionsCallback):
354         (TestRunner::staticFunctions):
355         (TestRunner::setRenderTreeDumpOptions):
356         * DumpRenderTree/TestRunner.h:
357         (TestRunner::renderTreeDumpOptions const):
358         * DumpRenderTree/mac/DumpRenderTree.mm:
359         (dump):
360         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
361         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
362         (WTR::InjectedBundlePage::dump):
363         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
364         (WTR::TestRunner::TestRunner):
365         (WTR::TestRunner::setRenderTreeDumpOptions):
366         * WebKitTestRunner/InjectedBundle/TestRunner.h:
367         (WTR::TestRunner::renderTreeDumpOptions const):
368
369 2019-04-24  Alex Christensen  <achristensen@webkit.org>
370
371         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
372         https://bugs.webkit.org/show_bug.cgi?id=197078
373         <rdar://problem/49564348>
374
375         Reviewed by Geoff Garen.
376
377         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
378         (TEST_F):
379         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
380         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
381         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
382
383 2019-04-24  Alex Christensen  <achristensen@webkit.org>
384
385         Add unit test for r239322
386         https://bugs.webkit.org/show_bug.cgi?id=197236
387
388         Reviewed by Chris Dumez.
389
390         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
391         May as well add the test infrastructure which was needed before and will be needed in the future.
392
393         * TestWebKitAPI/TCPServer.cpp:
394         (TestWebKitAPI::TCPServer::TCPServer):
395         * TestWebKitAPI/TCPServer.h:
396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
397         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
398         (TestWebKitAPI::TEST):
399         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
400         (TestWebKitAPI::downloadAtRate):
401         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
402         (TEST):
403         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
404         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
405         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
406         (TestWebKitAPI::TEST):
407         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
408         (TEST):
409
410 2019-04-24  Chris Dumez  <cdumez@apple.com>
411
412         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
413         https://bugs.webkit.org/show_bug.cgi?id=197214
414         <rdar://problem/49237544>
415
416         Reviewed by Alex Christensen.
417
418         Extend API test coverage.
419
420         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
421         (TEST):
422
423 2019-04-24  Philippe Normand  <pnormand@igalia.com>
424
425         [Build][GStreamer] Update to 1.16.0
426         https://bugs.webkit.org/show_bug.cgi?id=197157
427
428         Reviewed by Xabier Rodriguez-Calvar.
429
430         The upstreamed patches were removed and a new one was added for a
431         regression detected in the scaletempo GStreamer element. The GNOME
432         Flatpak was migrated to 3.32 and I switched a few modules to Meson
433         on the way, as it is the preferred build system now in GStreamer
434         1.16.
435
436         * flatpak/files/httpd-autogen.sh:
437         * flatpak/flatpakutils.py:
438         (FlatpakPackage.install):
439         (WebkitFlatpak.run_in_sandbox):
440         * flatpak/org.webkit.CommonModules.yaml:
441         * flatpak/org.webkit.WebKit.yaml:
442         * gstreamer/jhbuild.modules:
443         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
444         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
445         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
446         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
447         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
448         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
449         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
450         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
451         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
452         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
453         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
454         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
455         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
456         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
457         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
458         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
459         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
460         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
461         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
462         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
463         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
464         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
465
466 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
467
468         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
469         https://bugs.webkit.org/show_bug.cgi?id=197156
470
471         Reviewed by Michael Catanzaro.
472
473         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
474         support was added.
475
476         * MiniBrowser/gtk/BrowserTab.c:
477         (browser_tab_set_background_color): Set the passed in color as web view background color.
478         * MiniBrowser/gtk/BrowserTab.h:
479         * MiniBrowser/gtk/BrowserWindow.c:
480         (browser_window_init): Initialize backgroundColor.
481         (browser_window_append_view): Call browser_tab_set_background_color().
482         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
483         are added.
484         * MiniBrowser/gtk/main.c:
485         (main): Call browser_window_set_background_color() before creating the tabs.
486
487 2019-04-23  John Wilander  <wilander@apple.com>
488
489         Move Ad Click Attribution from internal feature to experimental feature
490         https://bugs.webkit.org/show_bug.cgi?id=197218
491         <rdar://problem/47651691>
492
493         Reviewed by Brent Fulgham.
494
495         * DumpRenderTree/TestOptions.cpp:
496         (TestOptions::TestOptions):
497
498 2019-04-23  Andy Estes  <aestes@apple.com>
499
500         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
501         https://bugs.webkit.org/show_bug.cgi?id=196749
502         <rdar://problem/35773454>
503
504         Reviewed by Daniel Bates.
505
506         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
507
508         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
509         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
510         (-[QuickLookDelegate webView:didFinishNavigation:]):
511         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
512         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
513         (runTest):
514         (runTestDecideBeforeLoading):
515         (runTestDecideAfterLoading):
516         (TEST):
517
518 2019-04-23  John Wilander  <wilander@apple.com>
519
520         Remove Ad Click Attribution data when removing website data
521         https://bugs.webkit.org/show_bug.cgi?id=197215
522         <rdar://problem/47668988>
523
524         Reviewed by Chris Dumez.
525
526         This patch adds test infrastructure to delete Ad Click Attribution data
527         through WebsiteDataStore::removeData().
528
529         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
530         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
531         (WTR::TestRunner::clearAdClickAttribution):
532         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
533         * WebKitTestRunner/InjectedBundle/TestRunner.h:
534         * WebKitTestRunner/TestController.cpp:
535         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
536         * WebKitTestRunner/TestController.h:
537         * WebKitTestRunner/TestInvocation.cpp:
538         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
539
540 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
541
542         webkitpy: Kill unresponsive worker processes
543         https://bugs.webkit.org/show_bug.cgi?id=197205
544         <rdar://problem/50104388>
545
546         Reviewed by Lucas Forschler.
547
548         * Scripts/webkitpy/common/message_pool.py:
549         (_MessagePool.__init__): Add close timeout.
550         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
551
552 2019-04-23  Alex Christensen  <achristensen@webkit.org>
553
554         Add unit tests for WKWebView.serverTrust
555         https://bugs.webkit.org/show_bug.cgi?id=197202
556
557         Reviewed by Youenn Fablet
558
559         * TestWebKitAPI/TCPServer.cpp:
560         (TestWebKitAPI::deleter<BIO>::operator()):
561         (TestWebKitAPI::deleter<SSL>::operator()):
562         (TestWebKitAPI::deleter<X509>::operator()):
563         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
564         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
565         (TestWebKitAPI::TCPServer::TCPServer):
566         (TestWebKitAPI::TCPServer::listenForConnections):
567         * TestWebKitAPI/TCPServer.h:
568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
569         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
570         (TestWebKitAPI::TEST):
571         (verifyCertificateAndPublicKey):
572         (-[ServerTrustDelegate webView:didFinishNavigation:]):
573         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
574         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
575         (TestWebKitAPI::downloadAtRate):
576         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
577         (TEST):
578         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
579         (TEST):
580
581 2019-04-23  Commit Queue  <commit-queue@webkit.org>
582
583         Unreviewed, rolling out r244556.
584         https://bugs.webkit.org/show_bug.cgi?id=197212
585
586         Causing build failures on multiple builders (Requested by
587         ShawnRoberts on #webkit).
588
589         Reverted changeset:
590
591         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
592         https://bugs.webkit.org/show_bug.cgi?id=197171
593         https://trac.webkit.org/changeset/244556
594
595 2019-04-23  Alex Christensen  <achristensen@webkit.org>
596
597         Fix iOS build.
598         https://bugs.webkit.org/show_bug.cgi?id=195537
599
600         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
601         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
602         AdoptWK constructor is private now.  Use adoptWK instead.
603
604 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
605
606         Accessibility text search and selection API enhancements.
607         https://bugs.webkit.org/show_bug.cgi?id=197095
608         <rdar://problem/48181791>
609
610         Reviewed by Chris Fleizach.
611
612         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
613
614         * DumpRenderTree/AccessibilityTextMarker.h:
615         * DumpRenderTree/AccessibilityUIElement.cpp:
616         (searchTextWithCriteriaCallback):
617         (AccessibilityUIElement::getJSClass):
618         * DumpRenderTree/AccessibilityUIElement.h:
619         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
620         (convertVectorToObjectArray):
621         (convertNSArrayToVector):
622         (searchTextParameterizedAttributeForCriteria):
623         (AccessibilityUIElement::getLinkedUIElements):
624         (AccessibilityUIElement::getDocumentLinks):
625         (AccessibilityUIElement::getChildren):
626         (AccessibilityUIElement::getChildrenWithRange):
627         (AccessibilityUIElement::rowHeaders const):
628         (AccessibilityUIElement::columnHeaders const):
629         (AccessibilityUIElement::uiElementArrayAttributeValue const):
630         (AccessibilityUIElement::searchTextWithCriteria):
631         (AccessibilityUIElement::attributesOfColumnHeaders):
632         (AccessibilityUIElement::attributesOfRowHeaders):
633         (AccessibilityUIElement::attributesOfColumns):
634         (AccessibilityUIElement::attributesOfRows):
635         (AccessibilityUIElement::attributesOfVisibleCells):
636         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
637         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
638         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
639         (WTR::convertVectorToObjectArray):
640         (WTR::convertNSArrayToVector):
641         (WTR::searchTextParameterizedAttributeForCriteria):
642         (WTR::AccessibilityUIElement::getLinkedUIElements):
643         (WTR::AccessibilityUIElement::getDocumentLinks):
644         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
645         (WTR::AccessibilityUIElement::getChildren):
646         (WTR::AccessibilityUIElement::getChildrenWithRange):
647         (WTR::AccessibilityUIElement::rowHeaders const):
648         (WTR::AccessibilityUIElement::columnHeaders const):
649         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
650         (WTR::AccessibilityUIElement::searchTextWithCriteria):
651         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
652         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
653         (WTR::AccessibilityUIElement::attributesOfColumns):
654         (WTR::AccessibilityUIElement::attributesOfRows):
655         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
656         (WTR::convertElementsToObjectArray): Deleted.
657
658 2019-04-23  Guy Lewin  <guy@lewin.co.il>
659
660         Multiple File Input Icon Set Regardless of File List
661         https://bugs.webkit.org/show_bug.cgi?id=195537
662
663         Reviewed by Alexey Proskuryakov.
664
665         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
666         display string in iOS file inputs
667
668         * DumpRenderTree/TestRunner.cpp:
669         (SetOpenPanelFilesMediaIconCallback):
670         (TestRunner::staticFunctions):
671         (TestRunner::setOpenPanelFilesMediaIcon):
672         * DumpRenderTree/TestRunner.h:
673         (TestRunner::openPanelFilesMediaIcon const):
674         * DumpRenderTree/mac/UIDelegate.mm:
675         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
676         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
677         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
678         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
679         * WebKitTestRunner/InjectedBundle/TestRunner.h:
680         * WebKitTestRunner/TestController.cpp:
681         (WTR::runOpenPanel):
682         (WTR::TestController::resetStateToConsistentValues):
683         * WebKitTestRunner/TestController.h:
684         (WTR::TestController::openPanelFileURLsMediaIcon const):
685         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
686         * WebKitTestRunner/TestInvocation.cpp:
687         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
688
689 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
690
691         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
692         https://bugs.webkit.org/show_bug.cgi?id=197171
693         <rdar://problem/47454979>
694
695         Reviewed by Youenn Fablet.
696
697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
698         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
699         (TestWebKitAPI::TEST):
700
701 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
702
703         [ews-build] Add unit tests for UnApplyPatchIfRequired
704         https://bugs.webkit.org/show_bug.cgi?id=197197
705
706         Reviewed by Lucas Forschler.
707
708         * BuildSlaveSupport/ews-build/steps_unittest.py:
709         (TestUnApplyPatchIfRequired):
710         (TestUnApplyPatchIfRequired.test_success):
711         (TestUnApplyPatchIfRequired.test_failure):
712         (TestUnApplyPatchIfRequired.test_skip):
713
714 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
715
716         [ews-build] Add unit tests for CleanWorkingDirectory
717         https://bugs.webkit.org/show_bug.cgi?id=197195
718
719         Reviewed by Lucas Forschler.
720
721         * BuildSlaveSupport/ews-build/steps_unittest.py:
722         (TestCleanWorkingDirectory):
723         (TestCleanWorkingDirectory.test_success):
724         (TestCleanWorkingDirectory.test_failure):
725
726 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
727
728         [ews-build] Use explicit imports instead of wildcard imports
729         https://bugs.webkit.org/show_bug.cgi?id=197194
730
731         Reviewed by Lucas Forschler.
732
733         * BuildSlaveSupport/ews-build/factories.py:
734         * BuildSlaveSupport/ews-build/loadConfig.py:
735         * BuildSlaveSupport/ews-build/steps_unittest.py:
736
737 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
738
739         [ews-build] Add unit tests for DownloadBuiltProduct
740         https://bugs.webkit.org/show_bug.cgi?id=197193
741
742         Reviewed by Lucas Forschler.
743
744         * BuildSlaveSupport/ews-build/steps_unittest.py:
745         (TestDownloadBuiltProduct):
746         (TestDownloadBuiltProduct.setUp):
747         (TestDownloadBuiltProduct.tearDown):
748         (TestDownloadBuiltProduct.test_success):
749         (TestDownloadBuiltProduct.test_failure):
750
751 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
752
753         [ews-app] Exception while loading status-bubble when no build step has started
754         https://bugs.webkit.org/show_bug.cgi?id=196676
755
756         Reviewed by Lucas Forschler.
757
758         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
759         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
760
761 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
762
763         [PlayStation] Support running of JSC tests on remote playstation devices
764         https://bugs.webkit.org/show_bug.cgi?id=197170
765
766         Reviewed by Ross Kirsling.
767
768         Script changes
769
770         * Scripts/run-javascriptcore-tests:
771         (runJSCStressTests): Pass arguments for playstation to
772         run-jsc-stress-tests
773         * Scripts/run-jsc-stress-tests:
774         Handle $hostOS=="playstation" for determineArchitecture, turning
775         off $isFTLPlatform and runProfiler and defaulting test writer.
776         * Scripts/webkitdirs.pm:
777         (jscPath): PlayStation WebKit executables have .elf extension
778         (executableProductDir): PlayStation builds on Windows hosts but
779         uses bin directory rather than bin64/bin32 for executable output
780         location.
781         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
782
783 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
784
785         [CMake][Win] Use target oriented design for WebKit
786         https://bugs.webkit.org/show_bug.cgi?id=197173
787
788         Reviewed by Alex Christensen.
789
790         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
791         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
792
793 2019-04-23  Chris Dumez  <cdumez@apple.com>
794
795         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
796         https://bugs.webkit.org/show_bug.cgi?id=197097
797         <rdar://problem/50048318>
798
799         Reviewed by Alex Christensen.
800
801         Add API test coverage.
802
803         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
804         (-[PSONScheme webView:startURLSchemeTask:]):
805
806 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
807
808         [ATK] Implement AtkComponentIface scroll_to methods
809         https://bugs.webkit.org/show_bug.cgi?id=196856
810
811         Reviewed by Michael Catanzaro.
812
813         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
814         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
815         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
816         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
817
818 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
819
820         [ews-build] Improve summary for UploadBuiltProduct step
821         https://bugs.webkit.org/show_bug.cgi?id=197182
822
823         Reviewed by Lucas Forschler.
824
825         * BuildSlaveSupport/ews-build/steps.py:
826         (UploadBuiltProduct): Added descriptionDone.
827         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
828         * BuildSlaveSupport/ews-build/steps_unittest.py:
829         (TestUploadBuiltProduct.test_success): Updated unit-test.
830         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
831
832 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
833
834         [ews-build] Trigger queues only after uploading the archive
835         https://bugs.webkit.org/show_bug.cgi?id=197180
836
837         Reviewed by Lucas Forschler.
838
839         * BuildSlaveSupport/ews-build/factories.py:
840         (Factory.__init__):
841         (BuildFactory.__init__): Remove trigger step from factories.
842         (BuildFactory.propertiesToPassToTriggers): Deleted.
843         * BuildSlaveSupport/ews-build/steps.py:
844         (ConfigureBuild.__init__): Confiure triggers property.
845         (Trigger): Step to trigger other queues.
846         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
847         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
848
849 2019-04-22  Alex Christensen  <achristensen@webkit.org>
850
851         Deprecate WKContextCreateWithInjectedBundlePath
852         https://bugs.webkit.org/show_bug.cgi?id=197169
853
854         Reviewed by Youenn Fablet.
855
856         * TestWebKitAPI/PlatformUtilities.cpp:
857         (TestWebKitAPI::Util::createContextWithInjectedBundle):
858         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
859
860 2019-04-22  Alex Christensen  <achristensen@webkit.org>
861
862         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
863         https://bugs.webkit.org/show_bug.cgi?id=197093
864         <rdar://problem/49708268>
865
866         Reviewed by Chris Dumez.
867
868         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
869         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
870         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
871         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
872         and one for loads without credentials, so there are two TCP connections to the same server in this test.
873
874         * TestWebKitAPI/TCPServer.cpp:
875         (TestWebKitAPI::TCPServer::TCPServer):
876         (TestWebKitAPI::TCPServer::~TCPServer):
877         (TestWebKitAPI::TCPServer::socketBindListen):
878         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
879         * TestWebKitAPI/TCPServer.h:
880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
881         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
882         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
883         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
884         (respondWithChallengeThenOK):
885         (TestWebKitAPI::TEST):
886         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
887         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
888         (TEST):
889
890 2019-04-22  Chris Dumez  <cdumez@apple.com>
891
892         Delayed WebProcessLaunch may break the _relatedWebView SPI
893         https://bugs.webkit.org/show_bug.cgi?id=197160
894
895         Reviewed by Alex Christensen.
896
897         Add API test coverage.
898
899         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
900
901 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
902
903         Use curl to download packages for webkitpy autoinstaller
904         https://bugs.webkit.org/show_bug.cgi?id=197164
905
906         Reviewed by Darin Adler.
907
908         * Scripts/webkitpy/common/system/autoinstall.py:
909         (AutoInstaller._download): Use curl(1) to download packages necessary for
910         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
911         errors which are not present when using curl(1).
912
913 2019-04-22  Chris Dumez  <cdumez@apple.com>
914
915         Unreviewed, rolling out r244502.
916
917         Caused crashes on the bots
918
919         Reverted changeset:
920
921         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
922         https://bugs.webkit.org/show_bug.cgi?id=197160
923         https://trac.webkit.org/changeset/244502
924
925 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
926
927         Unreviewed, rolling out r244437.
928
929         Still breaks internal tests.
930
931         Reverted changeset:
932
933         "InjectedBundle parameters often need initialization function
934         called before unarchiving"
935         https://bugs.webkit.org/show_bug.cgi?id=189709
936         https://trac.webkit.org/changeset/244437
937
938 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
939
940         [ews-build] Use singular verb in failure description in case of single api test failure
941         https://bugs.webkit.org/show_bug.cgi?id=197013
942
943         Reviewed by Lucas Forschler.
944
945         * BuildSlaveSupport/ews-build/steps.py:
946         (AnalyzeAPITestsResults.analyzeResults):
947
948 2019-04-22  Chris Dumez  <cdumez@apple.com>
949
950         Delayed WebProcessLaunch may break the _relatedWebView SPI
951         https://bugs.webkit.org/show_bug.cgi?id=197160
952
953         Reviewed by Alex Christensen.
954
955         Add API test coverage.
956
957         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
958
959 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
960
961         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
962         https://bugs.webkit.org/show_bug.cgi?id=194630
963
964         Reviewed by Michael Catanzaro.
965
966         Return early from getAttributeSet() is passed in accessible is nullptr.
967
968         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
969
970 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
971
972         Defer EditorState updates until the next layer tree flush in a few additional circumstances
973         https://bugs.webkit.org/show_bug.cgi?id=197145
974         <rdar://problem/50078170>
975
976         Reviewed by Darin Adler.
977
978         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
979         focus, or showing the font manager.
980
981         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
982         (TestWebKitAPI::TEST):
983         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
984         (TEST):
985         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
986         (TestWebKitAPI::TEST):
987
988 2019-04-21  Brian Burg  <bburg@apple.com>
989
990         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
991         https://bugs.webkit.org/show_bug.cgi?id=197125
992         <rdar://problem/50061468>
993
994         Reviewed by Darin Adler.
995
996         Sometimes I want to run wptserve independently of tests. Make it easier to script that
997         using this class rather than making our own ./wpt serve invocation.
998
999         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1000         (WebDriverW3CWebServer):
1001         (WebDriverW3CWebServer.document_root): Expose this to clients.
1002         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1003
1004         (WebDriverW3CWebServer.__enter__):
1005         (WebDriverW3CWebServer.__exit__):
1006         Make it possible to use the web server with a 'with' statement.
1007
1008 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1009
1010         [CMake][Win] Use target oriented design for WebKitLegacy
1011         https://bugs.webkit.org/show_bug.cgi?id=197112
1012
1013         Reviewed by Konstantin Tokarev.
1014
1015         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1016
1017         * DumpRenderTree/CMakeLists.txt:
1018         * DumpRenderTree/PlatformWin.cmake:
1019         * DumpRenderTree/win/EventSender.cpp:
1020
1021 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1022
1023         Update text for old EWS submit button
1024         https://bugs.webkit.org/show_bug.cgi?id=197140
1025
1026         Reviewed by Alexey Proskuryakov.
1027
1028         * QueueStatusServer/templates/statusbubble.html:
1029
1030 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1031
1032         [ews-app] New EWS should poll bugzilla more frequently
1033         https://bugs.webkit.org/show_bug.cgi?id=197138
1034
1035         Reviewed by Alexey Proskuryakov.
1036
1037         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1038         (FetchLoop.__init__):
1039
1040 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1041
1042         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1043         https://bugs.webkit.org/show_bug.cgi?id=197139
1044
1045         Reviewed by Alexey Proskuryakov.
1046
1047         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1048         * QueueStatusServer/templates/statusbubble.html:
1049
1050 2019-04-20  Chris Dumez  <cdumez@apple.com>
1051
1052         Unreviewed, fix iOS build with recent SDKs.
1053
1054         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1055
1056 2019-04-19  Keith Miller  <keith_miller@apple.com>
1057
1058         Add script to merge run_benchmark jsons
1059         https://bugs.webkit.org/show_bug.cgi?id=197107
1060
1061         Reviewed by Michael Saboff.
1062
1063         The script basically recursively decends through all json objects until it gets
1064         to an array or JSON primitive and concats or takes the first value, respectively.
1065
1066         This patch also adds +x bits to the compare-results script so it
1067         can be run directly from the command line. I had to add a new line so that svn
1068         will accept the change... yay svn!
1069
1070         * Scripts/compare-results:
1071         * Scripts/merge-result-jsons: Added.
1072         (readJSONFile):
1073         (deepAppend):
1074         (mergeJSONs):
1075         (main):
1076
1077 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1078
1079         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1080         https://bugs.webkit.org/show_bug.cgi?id=197079
1081
1082         Reviewed by Darin Adler.
1083
1084         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1085
1086         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1087         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1088
1089 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1090
1091         Unreviewed, rolling out r244434.
1092         https://bugs.webkit.org/show_bug.cgi?id=197089
1093
1094         caused 1 API test failure (Requested by zalan on #webkit).
1095
1096         Reverted changeset:
1097
1098         "Regression (r244291): Broken API Test
1099         AutoLayoutRenderingProgressRelativeOrdering"
1100         https://bugs.webkit.org/show_bug.cgi?id=196948
1101         https://trac.webkit.org/changeset/244434
1102
1103 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1104
1105         Add new compatibility mode API on WKNavigation
1106         https://bugs.webkit.org/show_bug.cgi?id=197069
1107         <rdar://problem/50025800>
1108
1109         Reviewed by Tim Horton.
1110
1111         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1112
1113         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1114         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1115         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1116
1117 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1118
1119         [CMake] Make WebCore headers copies
1120         https://bugs.webkit.org/show_bug.cgi?id=182512
1121         <rdar://problem/37510435>
1122
1123         Reviewed by Alex Christensen.
1124
1125         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1126         ports.
1127
1128         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1129         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1130
1131         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1132         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1133         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1134         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1135         * TestWebKitAPI/CMakeLists.txt:
1136         * TestWebKitAPI/PlatformWin.cmake:
1137         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1138         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1139         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1140
1141 2019-04-18  Jer Noble  <jer.noble@apple.com>
1142
1143         Add support for parsing FairPlayStreaming PSSH boxes.
1144         https://bugs.webkit.org/show_bug.cgi?id=197064
1145
1146         Reviewed by Eric Carlson.
1147
1148         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1149         (TestWebKitAPI::TEST):
1150
1151 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1152
1153         InjectedBundle parameters often need initialization function called before unarchiving
1154         https://bugs.webkit.org/show_bug.cgi?id=189709
1155         <rdar://problem/44573653>
1156
1157         Reviewed by Ryosuke Niwa.
1158
1159         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1160         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1161
1162 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1163
1164         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1165         https://bugs.webkit.org/show_bug.cgi?id=196948
1166         <rdar://problem/49927131>
1167
1168         Reviewed by Tim Horton.
1169
1170         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1171         (TEST): 
1172         The expected order of incoming events is
1173         1. didInvalidateIntrinsicContentSize
1174         2. didFirstLayout
1175         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1176         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1177         (and remember, all we care about is ordering).
1178
1179 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1180
1181         Unreviewed, rolling out r244299.
1182
1183         Breaks internal tests.
1184
1185         Reverted changeset:
1186
1187         "InjectedBundle parameters often need initialization function
1188         called before unarchiving"
1189         https://bugs.webkit.org/show_bug.cgi?id=189709
1190         https://trac.webkit.org/changeset/244299
1191
1192 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1193
1194         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1195         https://bugs.webkit.org/show_bug.cgi?id=197053
1196
1197         Reviewed by Saam Barati.
1198
1199         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1200         (TestWebKitAPI::TEST):
1201
1202 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1203
1204         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1205         https://bugs.webkit.org/show_bug.cgi?id=197028
1206         <rdar://problem/49985290>
1207
1208         Reviewed by Wenson Hsieh.
1209
1210         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1211         (TEST):
1212         Liberal application of waitForNextPresentationUpdate works around a race
1213         where if the page rapidly changes its viewport arguments (or an API client
1214         rapidly changes its viewport arguments), we'd get stuck thinking that the
1215         user had intentionally zoomed the page, and stop resetting the initial scale.
1216         This deserves a separate bug, but no need to keep the test failing while
1217         we think about it.
1218
1219 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1220
1221         REGRESSION (r241988): Switching tabs is slow
1222         https://bugs.webkit.org/show_bug.cgi?id=197037
1223         <rdar://problem/49951473>
1224
1225         Reviewed by Simon Fraser.
1226
1227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1228         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1229         (TEST):
1230         * TestWebKitAPI/cocoa/TestWKWebView.h:
1231         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1232         (-[TestWKWebView addToTestWindow]):
1233         Add a test that hangs without this fix.
1234
1235 2019-04-17  Truitt Savell  <tsavell@apple.com>
1236
1237         Unreviewed, rolling out r244400.
1238
1239         Caused testing to exit early with assertionon Debug WK2
1240
1241         Reverted changeset:
1242
1243         "UI↔Web deadlock when printing with a JavaScript alert
1244         visible"
1245         https://bugs.webkit.org/show_bug.cgi?id=196839
1246         https://trac.webkit.org/changeset/244400
1247
1248 2019-04-17  Brady Eidson  <beidson@apple.com>
1249
1250         Link clicks in PDFs shouldn't send referrer headers.
1251         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1252
1253         Reviewed by Tim Horton.
1254
1255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1256         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1257         (putPDFBytesCallback):
1258         (emptyReleaseInfoCallback):
1259         (createPDFWithLinkToURL):
1260         (TEST):
1261
1262 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1263
1264         UI↔Web deadlock when printing with a JavaScript alert visible
1265         https://bugs.webkit.org/show_bug.cgi?id=196839
1266         <rdar://problem/49157642>
1267
1268         Reviewed by Andy Estes.
1269
1270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1271         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1272         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1273         (TEST):
1274
1275 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1276
1277         WKRetainPtr's adoption constructor should be private
1278         https://bugs.webkit.org/show_bug.cgi?id=197019
1279
1280         Reviewed by Tim Horton.
1281
1282         * DumpRenderTree/mac/DumpRenderTree.mm:
1283         (dumpFramesAsText):
1284         * TestWebKitAPI/InjectedBundleController.cpp:
1285         (TestWebKitAPI::InjectedBundleController::initialize):
1286         * TestWebKitAPI/PlatformUtilities.cpp:
1287         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1288         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1289         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1290         (TestWebKitAPI::Util::toWK):
1291         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1292         (TestWebKitAPI::TEST):
1293         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1294         (TestWebKitAPI::TEST):
1295         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1296         (TestWebKitAPI::TEST):
1297         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1298         (TestWebKitAPI::TEST):
1299         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1300         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1301         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1302         (TestWebKitAPI::TEST):
1303         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1304         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1305         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1306         (TestWebKitAPI::TEST):
1307         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1308         (TestWebKitAPI::TEST):
1309         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1310         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1311         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1312         (TestWebKitAPI::TEST):
1313         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1314         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1315         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1316         (TestWebKitAPI::TEST):
1317         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1318         (TestWebKitAPI::TEST):
1319         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1320         (TestWebKitAPI::TEST):
1321         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1322         (TestWebKitAPI::TEST):
1323         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1324         (TestWebKitAPI::TEST):
1325         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1326         (TestWebKitAPI::TEST):
1327         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1328         (TestWebKitAPI::TEST):
1329         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1330         (TestWebKitAPI::TEST):
1331         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1332         (TestWebKitAPI::TEST):
1333         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1334         (TestWebKitAPI::TEST):
1335         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1336         (TestWebKitAPI::TEST):
1337         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1338         (TestWebKitAPI::TEST):
1339         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1340         (TestWebKitAPI::TEST):
1341         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1342         (TestWebKitAPI::TEST):
1343         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1344         (TestWebKitAPI::TEST):
1345         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1346         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1347         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1348         (TestWebKitAPI::TEST):
1349         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1350         (TestWebKitAPI::TEST):
1351         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1352         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1353         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1354         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1355         (TestWebKitAPI::TEST):
1356         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1357         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1358         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1359         (TestWebKitAPI::TEST):
1360         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1361         (TestWebKitAPI::TEST):
1362         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1363         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1364         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1365         (TestWebKitAPI::TEST):
1366         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1367         (TestWebKitAPI::loadAlternateHTMLString):
1368         (TestWebKitAPI::TEST):
1369         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1370         (TestWebKitAPI::TEST):
1371         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1372         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1373         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1374         (TestWebKitAPI::buildAndPerformTest):
1375         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1376         (TestWebKitAPI::TEST):
1377         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1378         (TestWebKitAPI::TEST):
1379         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1380         (TestWebKitAPI::TEST):
1381         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1382         (TestWebKitAPI::TEST):
1383         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1384         (TestWebKitAPI::TEST):
1385         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1386         (TestWebKitAPI::TEST):
1387         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1388         (TestWebKitAPI::TEST):
1389         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1390         (TestWebKitAPI::TEST):
1391         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1392         (TestWebKitAPI::TEST):
1393         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1394         (TestWebKitAPI::TEST):
1395         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1396         (TestWebKitAPI::TEST):
1397         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1398         (TestWebKitAPI::TEST):
1399         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1400         (TestWebKitAPI::TEST):
1401         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1402         (TestWebKitAPI::TEST):
1403         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1404         (TestWebKitAPI::TEST):
1405         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1406         (TestWebKitAPI::TEST):
1407         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1408         (TestWebKitAPI::TEST):
1409         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1410         (TestWebKitAPI::TEST):
1411         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1412         (TestWebKitAPI::TEST):
1413         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1414         (TestWebKitAPI::TEST):
1415         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1416         (TestWebKitAPI::TEST):
1417         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1418         (TestWebKitAPI::TEST):
1419         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1420         (TestWebKitAPI::TEST):
1421         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1422         (TestWebKitAPI::TEST):
1423         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1424         (TestWebKitAPI::TEST):
1425         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1426         (TestWebKitAPI::TEST):
1427         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1428         (TestWebKitAPI::TEST):
1429         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1430         (TestWebKitAPI::TEST):
1431         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1432         (TestWebKitAPI::TEST):
1433         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1434         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1435         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1436         (TestWebKitAPI::TEST):
1437         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1438         (TestWebKitAPI::TEST):
1439         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1440         (TestWebKitAPI::TEST):
1441         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1442         (TestWebKitAPI::TEST):
1443         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1444         (TestWebKitAPI::TEST):
1445         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1446         (TestWebKitAPI::TEST):
1447         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1448         (TestWebKitAPI::TEST):
1449         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1450         (TestWebKitAPI::TEST):
1451         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1452         (TestWebKitAPI::TEST):
1453         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1454         (TestWebKitAPI::TEST):
1455         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1456         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1457         (TEST):
1458         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1459         (TEST):
1460         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1461         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1462         (TEST):
1463         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1464         (TestWebKitAPI::TEST):
1465         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1466         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1467         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1468         (WTR::getMenuItemTitleCallback):
1469         (WTR::createMouseMessageBody):
1470         (WTR::EventSendingController::mouseDown):
1471         (WTR::EventSendingController::mouseUp):
1472         (WTR::EventSendingController::mouseMoveTo):
1473         (WTR::EventSendingController::mouseForceClick):
1474         (WTR::EventSendingController::startAndCancelMouseForceClick):
1475         (WTR::EventSendingController::mouseForceDown):
1476         (WTR::EventSendingController::mouseForceUp):
1477         (WTR::EventSendingController::mouseForceChanged):
1478         (WTR::EventSendingController::leapForward):
1479         (WTR::EventSendingController::scheduleAsynchronousClick):
1480         (WTR::createKeyDownMessageBody):
1481         (WTR::EventSendingController::keyDown):
1482         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1483         (WTR::EventSendingController::mouseScrollBy):
1484         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1485         (WTR::EventSendingController::continuousMouseScrollBy):
1486         (WTR::EventSendingController::addTouchPoint):
1487         (WTR::EventSendingController::updateTouchPoint):
1488         (WTR::EventSendingController::setTouchModifier):
1489         (WTR::EventSendingController::setTouchPointRadius):
1490         (WTR::EventSendingController::touchStart):
1491         (WTR::EventSendingController::touchMove):
1492         (WTR::EventSendingController::touchEnd):
1493         (WTR::EventSendingController::touchCancel):
1494         (WTR::EventSendingController::clearTouchPoints):
1495         (WTR::EventSendingController::releaseTouchPoint):
1496         (WTR::EventSendingController::cancelTouchPoint):
1497         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1498         (WTR::InjectedBundle::didCreatePage):
1499         (WTR::InjectedBundle::didReceiveMessage):
1500         (WTR::InjectedBundle::didReceiveMessageToPage):
1501         (WTR::InjectedBundle::booleanForKey):
1502         (WTR::InjectedBundle::done):
1503         (WTR::InjectedBundle::dumpToStdErr):
1504         (WTR::InjectedBundle::outputText):
1505         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1506         (WTR::InjectedBundle::postAddChromeInputField):
1507         (WTR::InjectedBundle::postRemoveChromeInputField):
1508         (WTR::InjectedBundle::postFocusWebView):
1509         (WTR::InjectedBundle::postSetBackingScaleFactor):
1510         (WTR::InjectedBundle::postSetWindowIsKey):
1511         (WTR::InjectedBundle::postSetViewSize):
1512         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1513         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1514         (WTR::InjectedBundle::setGeolocationPermission):
1515         (WTR::InjectedBundle::setMockGeolocationPosition):
1516         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1517         (WTR::InjectedBundle::isGeolocationProviderActive const):
1518         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1519         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1520         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1521         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1522         (WTR::InjectedBundle::setCustomPolicyDelegate):
1523         (WTR::InjectedBundle::setHidden):
1524         (WTR::InjectedBundle::setCacheModel):
1525         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1526         (WTR::InjectedBundle::processWorkQueue):
1527         (WTR::InjectedBundle::queueBackNavigation):
1528         (WTR::InjectedBundle::queueForwardNavigation):
1529         (WTR::InjectedBundle::queueLoad):
1530         (WTR::InjectedBundle::queueLoadHTMLString):
1531         (WTR::InjectedBundle::queueReload):
1532         (WTR::InjectedBundle::queueLoadingScript):
1533         (WTR::InjectedBundle::queueNonLoadingScript):
1534         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1535         (WTR::frameToStr):
1536         (WTR::InjectedBundlePage::InjectedBundlePage):
1537         (WTR::dumpFrameDescriptionSuitableForTestResult):
1538         (WTR::dumpFrameScrollPosition):
1539         (WTR::dumpDescendantFrameScrollPositions):
1540         (WTR::dumpFrameText):
1541         (WTR::dumpDescendantFramesText):
1542         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1543         (WTR::TestRunner::shouldDumpPixels const):
1544         (WTR::TestRunner::setDumpPixels):
1545         (WTR::TestRunner::whatToDump const):
1546         (WTR::TestRunner::setWhatToDump):
1547         (WTR::TestRunner::setWaitUntilDone):
1548         (WTR::TestRunner::shouldWaitUntilDone const):
1549         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1550         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1551         (WTR::TestRunner::clearAllDatabases):
1552         (WTR::TestRunner::setIDBPerOriginQuota):
1553         (WTR::TestRunner::originsWithApplicationCache):
1554         (WTR::TestRunner::setCanOpenWindows):
1555         (WTR::TestRunner::setXSSAuditorEnabled):
1556         (WTR::TestRunner::setMediaDevicesEnabled):
1557         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1558         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1559         (WTR::TestRunner::setCustomUserAgent):
1560         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1561         (WTR::TestRunner::setModernMediaControlsEnabled):
1562         (WTR::TestRunner::setWebGL2Enabled):
1563         (WTR::TestRunner::setWritableStreamAPIEnabled):
1564         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1565         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1566         (WTR::TestRunner::setAllowsAnySSLCertificate):
1567         (WTR::TestRunner::setPluginsEnabled):
1568         (WTR::TestRunner::setValueForUser):
1569         (WTR::TestRunner::setAudioResult):
1570         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1571         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1572         (WTR::TestRunner::setAlwaysAcceptCookies):
1573         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1574         (WTR::TestRunner::isDoingMediaCapture const):
1575         (WTR::TestRunner::queueLoad):
1576         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1577         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1578         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1579         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1580         (WTR::TestRunner::setAuthenticationUsername):
1581         (WTR::TestRunner::setAuthenticationPassword):
1582         (WTR::TestRunner::secureEventInputIsEnabled const):
1583         (WTR::TestRunner::setBlockAllPlugins):
1584         (WTR::TestRunner::setPluginSupportedMode):
1585         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1586         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1587         (WTR::TestRunner::setNavigationGesturesEnabled):
1588         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1589         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1590         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1591         (WTR::TestRunner::terminateNetworkProcess):
1592         (WTR::TestRunner::terminateServiceWorkerProcess):
1593         (WTR::TestRunner::runUIScript):
1594         (WTR::TestRunner::setStatisticsDebugMode):
1595         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1596         (WTR::TestRunner::setStatisticsLastSeen):
1597         (WTR::TestRunner::setStatisticsPrevalentResource):
1598         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1599         (WTR::TestRunner::dumpResourceLoadStatistics):
1600         (WTR::TestRunner::isStatisticsPrevalentResource):
1601         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1602         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1603         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1604         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1605         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1606         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1607         (WTR::TestRunner::setStatisticsGrandfathered):
1608         (WTR::TestRunner::isStatisticsGrandfathered):
1609         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1610         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1611         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1612         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1613         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1614         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1615         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1616         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1617         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1618         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1619         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1620         (WTR::TestRunner::statisticsSubmitTelemetry):
1621         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1622         (WTR::TestRunner::setStatisticsIsRunningTest):
1623         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1624         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1625         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1626         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1627         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1628         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1629         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1630         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1631         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1632         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1633         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1634         (WTR::TestRunner::statisticsResetToConsistentState):
1635         (WTR::TestRunner::setStorageAccessAPIEnabled):
1636         (WTR::TestRunner::getAllStorageAccessEntries):
1637         (WTR::TestRunner::addMockMediaDevice):
1638         (WTR::TestRunner::clearMockMediaDevices):
1639         (WTR::TestRunner::removeMockMediaDevice):
1640         (WTR::TestRunner::resetMockMediaDevices):
1641         (WTR::TestRunner::connectMockGamepad):
1642         (WTR::TestRunner::disconnectMockGamepad):
1643         (WTR::TestRunner::setMockGamepadDetails):
1644         (WTR::TestRunner::setMockGamepadAxisValue):
1645         (WTR::TestRunner::setMockGamepadButtonValue):
1646         (WTR::TestRunner::removeAllSessionCredentials):
1647         (WTR::TestRunner::clearDOMCache):
1648         (WTR::TestRunner::clearDOMCaches):
1649         (WTR::TestRunner::hasDOMCache):
1650         (WTR::TestRunner::domCacheSize):
1651         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1652         (WTR::TestRunner::getApplicationManifestThen):
1653         (WTR::TestRunner::injectUserScript):
1654         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1655         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1656         (WTR::TestRunner::addTestKeyToKeychain):
1657         (WTR::TestRunner::cleanUpKeychain):
1658         (WTR::TestRunner::keyExistsInKeychain):
1659         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1660         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1661         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1662         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1663         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1664         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1665         * WebKitTestRunner/TestController.cpp:
1666         (WTR::TestController::initialize):
1667         (WTR::parseStringTestHeaderValueAsRelativePath):
1668         (WTR::updateTestOptionsFromTestHeader):
1669         (WTR::TestController::runTest):
1670         (WTR::TestController::didReceiveLiveDocumentsList):
1671         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1672         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1673         (WTR::TestController::didFinishNavigation):
1674         (WTR::TestController::didReceiveAuthenticationChallenge):
1675         * WebKitTestRunner/TestInvocation.cpp:
1676         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1677         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1678         (WTR::TestInvocation::uiScriptDidComplete):
1679         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1680         * WebKitTestRunner/WebNotificationProvider.cpp:
1681         (WTR::WebNotificationProvider::closeWebNotification):
1682         * WebKitTestRunner/WorkQueueManager.cpp:
1683         (WTR::ScriptItem::ScriptItem):
1684         (WTR::WorkQueueManager::queueLoad):
1685         (WTR::WorkQueueManager::queueLoadHTMLString):
1686
1687 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1688
1689         Add a comment to make my test from r244139 less mysterious.
1690         https://bugs.webkit.org/show_bug.cgi?id=196744
1691
1692         As suggested by Darin Adler.
1693
1694         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1695         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1696
1697 2019-04-17  Chris Dumez  <cdumez@apple.com>
1698
1699         Remember device orientation permission for the duration of the browsing session
1700         https://bugs.webkit.org/show_bug.cgi?id=196992
1701         <rdar://problem/49946067>
1702
1703         Reviewed by Alex Christensen.
1704
1705         Add API test coverage.
1706
1707         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1708         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1709         (TEST):
1710
1711 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1712
1713         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1714         https://bugs.webkit.org/show_bug.cgi?id=196675
1715
1716         Reviewed by Lucas Forschler.
1717
1718         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1719         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1720
1721 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1722
1723         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1724         https://bugs.webkit.org/show_bug.cgi?id=196919
1725         <rdar://problem/41630459>
1726
1727         Reviewed by Tim Horton.
1728
1729         Add iOS support for several new testing hooks. See below for more detail.
1730
1731         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1732         (WTR::UIScriptController::isDismissingMenu const):
1733
1734         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1735         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1736         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1737
1738         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1739         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1740         (WTR::UIScriptController::isDismissingMenu const):
1741         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1742         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1743         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1744         (WTR::InjectedBundle::didReceiveMessageToPage):
1745         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1746         (WTR::TestRunner::setAllowedMenuActions):
1747
1748         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
1749         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
1750         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
1751         against the name of the custom action.
1752
1753         (WTR::TestRunner::installCustomMenuAction):
1754
1755         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
1756         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
1757         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
1758         triggered.
1759
1760         (WTR::TestRunner::performCustomMenuAction):
1761
1762         Invoked when the custom menu action is triggered.
1763
1764         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1765         * WebKitTestRunner/TestController.cpp:
1766         (WTR::TestController::installCustomMenuAction):
1767         (WTR::TestController::setAllowedMenuActions):
1768         * WebKitTestRunner/TestController.h:
1769         * WebKitTestRunner/TestInvocation.cpp:
1770         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1771         (WTR::TestInvocation::performCustomMenuAction):
1772
1773         Add plumbing to call back into the injected bundle when performing the custom action.
1774
1775         * WebKitTestRunner/TestInvocation.h:
1776         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1777         (WTR::TestController::installCustomMenuAction):
1778         (WTR::TestController::setAllowedMenuActions):
1779         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1780         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1781         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1782         (-[TestRunnerWKWebView becomeFirstResponder]):
1783         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
1784
1785         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
1786         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
1787         in the Mail app on iOS.
1788
1789         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
1790         (-[TestRunnerWKWebView setAllowedMenuActions:]):
1791         (-[TestRunnerWKWebView resetCustomMenuAction]):
1792         (-[TestRunnerWKWebView performCustomAction:]):
1793         (-[TestRunnerWKWebView canPerformAction:withSender:]):
1794         (-[TestRunnerWKWebView _willHideMenu]):
1795         (-[TestRunnerWKWebView _didHideMenu]):
1796         * WebKitTestRunner/ios/TestControllerIOS.mm:
1797         (WTR::TestController::platformResetStateToConsistentValues):
1798
1799         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
1800         if specified.
1801
1802         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1803         (WTR::UIScriptController::isDismissingMenu const):
1804
1805 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
1806
1807         Allow sharing from imageSheet on an image document
1808         https://bugs.webkit.org/show_bug.cgi?id=196891
1809         <rdar://problem/25377386>
1810
1811         Reviewed by Tim Horton.
1812
1813         Test to make sure that the correct imageURL is extracted from an image element.
1814
1815         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1816         (TestWebKitAPI::TEST):
1817
1818 2019-04-16  Alex Christensen  <achristensen@webkit.org>
1819
1820         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
1821         https://bugs.webkit.org/show_bug.cgi?id=196995
1822
1823         Reviewed by Brady Eidson.
1824
1825         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1826         (TEST):
1827
1828 2019-04-16  Chris Dumez  <cdumez@apple.com>
1829
1830         URL set by document.open() is not communicated to the UIProcess
1831         https://bugs.webkit.org/show_bug.cgi?id=196941
1832         <rdar://problem/49237544>
1833
1834         Reviewed by Geoff Garen.
1835
1836         Add API test coverage.
1837
1838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1839         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1840         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1841         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1842         (TEST):
1843
1844 2019-04-16  Commit Queue  <commit-queue@webkit.org>
1845
1846         Unreviewed, rolling out r244321.
1847         https://bugs.webkit.org/show_bug.cgi?id=196968
1848
1849         Causing all WK2 Debug builds to exit early after Assertion
1850         failures. (Requested by ShawnRoberts on #webkit).
1851
1852         Reverted changeset:
1853
1854         "URL set by document.open() is not communicated to the
1855         UIProcess"
1856         https://bugs.webkit.org/show_bug.cgi?id=196941
1857         https://trac.webkit.org/changeset/244321
1858
1859 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1860
1861         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1862         https://bugs.webkit.org/show_bug.cgi?id=196948
1863
1864         Reviewed by Zalan Bujtas.
1865
1866         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1867         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
1868
1869 2019-04-15  Chris Dumez  <cdumez@apple.com>
1870
1871         URL set by document.open() is not communicated to the UIProcess
1872         https://bugs.webkit.org/show_bug.cgi?id=196941
1873         <rdar://problem/49237544>
1874
1875         Reviewed by Geoffrey Garen.
1876
1877         Add API test coverage.
1878
1879         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1880         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1881         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1882         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1883         (TEST):
1884
1885 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
1886
1887         Using Tools/Scripts/clean-webkit should not install requests
1888         https://bugs.webkit.org/show_bug.cgi?id=196940
1889
1890         Reviewed by Lucas Forschler.
1891
1892         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
1893         existing, depending on the path autoinstalled is run through.
1894         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
1895         needed.
1896         (Port.configuration_for_upload):
1897         (Port.commits_for_upload):
1898
1899 2019-04-15  Alex Christensen  <achristensen@webkit.org>
1900
1901         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
1902         https://bugs.webkit.org/show_bug.cgi?id=196773
1903
1904         Reviewed by Jer Noble.
1905
1906         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1907         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
1908         (TEST):
1909
1910 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1911
1912         ews-build should clearly indicate flaky test failures
1913         https://bugs.webkit.org/show_bug.cgi?id=196947
1914
1915         Reviewed by Lucas Forschler.
1916
1917         * BuildSlaveSupport/ews-build/steps.py:
1918         (AnalyzeAPITestsResults.analyzeResults):
1919
1920 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
1921
1922         InjectedBundle parameters often need initialization function called before unarchiving
1923         https://bugs.webkit.org/show_bug.cgi?id=189709
1924         <rdar://problem/44573653>
1925
1926         Reviewed by Ryosuke Niwa.
1927
1928         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1929         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1930
1931 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1932
1933         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
1934         https://bugs.webkit.org/show_bug.cgi?id=196681
1935
1936         Reviewed by Darin Adler.
1937
1938         Added tests.
1939
1940         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1941         (WTF_HashSet.RemoveIf):
1942         (WTF_HashSet.RemoveIfShrinkToBestSize):
1943
1944 2019-04-15  John Wilander  <wilander@apple.com>
1945
1946         Send delayed Ad Click Attribution conversion requests to the click source
1947         https://bugs.webkit.org/show_bug.cgi?id=196838
1948         <rdar://problem/47650157>
1949
1950         Reviewed by Chris Dumez and Youenn Fablet.
1951
1952         This patch adds test infrastructure to override the default behavior in
1953         WebKit::NetworkAdClickAttribution.
1954
1955         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1956         (TestWebKitAPI::TEST):
1957         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1958         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1959         (WTR::TestRunner::dumpAdClickAttribution):
1960         (WTR::TestRunner::clearAdClickAttribution):
1961         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1962         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1963         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1964         * WebKitTestRunner/TestController.cpp:
1965         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1966         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1967         * WebKitTestRunner/TestController.h:
1968         * WebKitTestRunner/TestInvocation.cpp:
1969         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1970
1971 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1972
1973         [ews-app] status-bubble should display position in queue
1974         https://bugs.webkit.org/show_bug.cgi?id=196607
1975
1976         Reviewed by Lucas Forschler.
1977
1978         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1979         (StatusBubble._build_bubble):
1980         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1981
1982 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1983
1984         [ews-build] Do not run clean build by default on EWS builders
1985         https://bugs.webkit.org/show_bug.cgi?id=196897
1986
1987         Reviewed by Lucas Forschler.
1988
1989         * BuildSlaveSupport/ews-build/steps.py:
1990         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1991         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1992         untracked directories like WebKitBuild).
1993         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1994         untracked files/directories (like WebKitBuild).
1995
1996 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1997
1998         TestRunner::notifyDone() should be safely reentrant
1999         https://bugs.webkit.org/show_bug.cgi?id=196898
2000
2001         Reviewed by Darin Adler.
2002
2003         It is currently possible that TestRunner::notifyDone() will call itself, since
2004         notifyDone() will force a repaint, which can start executing JavaScript, which
2005         may call notifyDone() again. This can lead to test failures and flakiness.
2006         Fix this by setting the m_waitToDump flag before calling the dump() method.
2007
2008         * DumpRenderTree/mac/TestRunnerMac.mm:
2009         (TestRunner::notifyDone):
2010         (TestRunner::forceImmediateCompletion):
2011         * DumpRenderTree/win/TestRunnerWin.cpp:
2012         (TestRunner::notifyDone):
2013         (TestRunner::forceImmediateCompletion):
2014
2015 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2016
2017         [GTK][WPE] Add enable-media websetting
2018         https://bugs.webkit.org/show_bug.cgi?id=196863
2019
2020         Reviewed by Michael Catanzaro.
2021
2022         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2023         (testWebKitSettings): Add test for the enable-media web-setting.
2024
2025 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2026
2027         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2028         https://bugs.webkit.org/show_bug.cgi?id=196905
2029         <rdar://problem/49886096>
2030
2031         Reviewed by Tim Horton.
2032
2033         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2034         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2035         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2036         delay timer, we end up with this sequence of events in the problematic (failure) case:
2037
2038         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2039             ...IPC from UI to web process...
2040         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2041             ...IPC from web to UI process...
2042         (c) [UI]    Invoke completion handler for script #1
2043         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2044             ...IPC from UI to web process...
2045         (e) [Web]   Evaluate script #2 in the web process
2046         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2047
2048         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2049         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2050         #2 is run in step (e).
2051
2052         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2053         the UI process by waiting on a script message posted by the web process, after attachment updates are
2054         dispatched.
2055
2056         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2057         (TestWebKitAPI::TEST):
2058
2059 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2060
2061         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2062         https://bugs.webkit.org/show_bug.cgi?id=196909
2063
2064         Reviewed by Wenson Hsieh.
2065
2066         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2067         (TestWebKitAPI::TEST):
2068
2069 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2070
2071         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2072         https://bugs.webkit.org/show_bug.cgi?id=196880
2073
2074         Reviewed by Yusuke Suzuki.
2075
2076         Add a new function for bytecode cache tests that does not forceDiskCache
2077         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2078         test added in this patch, since the code is invalid and therefore won't be
2079         cached. It should also be useful for tests that evaluate dynamically
2080         generated code.
2081
2082         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2083         * Scripts/run-jsc-stress-tests:
2084
2085 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2086
2087         Update AudioSession route sharing policy
2088         https://bugs.webkit.org/show_bug.cgi?id=196776
2089         <rdar://problem/46501611>
2090
2091         Reviewed by Jer Noble.
2092
2093         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2094         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2095         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2096         (TestWebKitAPI::TEST):
2097
2098 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2099
2100         [iOS] Software keyboard is shown too frequently on some websites
2101         https://bugs.webkit.org/show_bug.cgi?id=195856
2102         <rdar://problem/49191395>
2103
2104         Reviewed by Darin Adler.
2105
2106         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2107
2108         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2109         (WTR::UIScriptController::setHardwareKeyboardAttached):
2110         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2111         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2112         (WTR::UIScriptController::setHardwareKeyboardAttached):
2113         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2114         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2115
2116         Additionally link against GraphicsServices in WebKitTestRunner.
2117
2118         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2119         (WTR::TestController::platformResetStateToConsistentValues):
2120         (WTR::UIScriptController::setHardwareKeyboardAttached):
2121
2122 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2123
2124         [GTK][WPE] Fix pacman install-dependencies packages
2125         https://bugs.webkit.org/show_bug.cgi?id=196817
2126
2127         Reviewed by Žan Doberšek.
2128         
2129         python3-setuptools is called python-setuptools
2130         ruby-highline is only available on AUR
2131         libv4l-devel is incorporated in v4l-utils
2132
2133         * gtk/install-dependencies:
2134         * wpe/install-dependencies:
2135
2136 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2137
2138         [GTK] REGRESSION(r243860): Many tests failing
2139         https://bugs.webkit.org/show_bug.cgi?id=196791
2140
2141         Reviewed by Joanmarie Diggs.
2142
2143         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2144         multiple documents and check that accessibility hierarchy is updated after a navigation.
2145
2146         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2147         (loadChangedCallback):
2148         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2149         (AccessibilityTest::AccessibilityTest):
2150         (AccessibilityTest::~AccessibilityTest):
2151         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2152         (AccessibilityTest::findTestServerApplication):
2153         (AccessibilityTest::findDocumentWeb):
2154         (AccessibilityTest::findRootObject):
2155         (AccessibilityTest::waitUntilChildrenRemoved):
2156         (AccessibilityTest::ensureProxy):
2157         (testAtspiBasicHierarchy):
2158         (beforeAll):
2159         (afterAll):
2160
2161 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2162
2163         [ews-build] Handle bug titles with unicode characters
2164         https://bugs.webkit.org/show_bug.cgi?id=196802
2165
2166         Reviewed by Dewei Zhu.
2167
2168         * BuildSlaveSupport/ews-build/steps.py:
2169         (ValidatePatch._is_bug_closed):
2170
2171 2019-04-11  Michael Saboff  <msaboff@apple.com>
2172
2173         Improve the Inline Cache Stats code
2174         https://bugs.webkit.org/show_bug.cgi?id=196836
2175
2176         Reviewed by Saam Barati.
2177
2178         Added a new script to consolidate and arrange the output of --useICStats option.
2179
2180         This script merges the output from every group into one large table and sorts it from most common to
2181         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2182         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2183         Put together, this is useful to see what property accesses are not getting cached.
2184
2185         * Scripts/ic-stats.py: Added.
2186         (ICStats):
2187         (ICStats.__init__):
2188         (ICStats.parse):
2189         (ICStats.dumpStats):
2190         (usage):
2191
2192 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2193
2194         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2195         https://bugs.webkit.org/show_bug.cgi?id=196809
2196         <rdar://49800762>
2197
2198         Reviewed by Brady Eidson.
2199
2200         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2201         (TEST):
2202
2203 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2204
2205         requestAnimationFrame should execute before the next frame
2206         https://bugs.webkit.org/show_bug.cgi?id=177484
2207
2208         Reviewed by Simon Fraser.
2209
2210         Add trace points for the page RenderingUpdate.
2211
2212         * Tracing/SystemTracePoints.plist:
2213
2214 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2215
2216         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2217         https://bugs.webkit.org/show_bug.cgi?id=196760
2218
2219         Reviewed by Don Olmstead.
2220
2221         vswhere.exe has been bundled since Visual Studio 2017 version
2222         15.2. We shouldn't download vswhere.exe.
2223
2224         * Scripts/build-jsc: Do not call update-vswhere.py.
2225         * Scripts/build-webkit: Ditto.
2226         * Scripts/update-vswhere.py: Removed.
2227         * Scripts/webkitdirs.pm:
2228         (requireModulesForVSWhere): Deleted.
2229         (pickCurrentVisualStudioInstallation): Deleted.
2230         (visualStudioInstallDirVSWhere): Return the latest installed VS
2231         installation path by using the bundled vswhere.exe.
2232         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2233         (visualStudioInstallDirFallback): Removed.
2234
2235 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2236
2237         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2238         https://bugs.webkit.org/show_bug.cgi?id=196780
2239
2240         Reviewed by Alexey Proskuryakov.
2241
2242         * BuildSlaveSupport/ews-build/steps.py:
2243         * BuildSlaveSupport/ews-build/steps_unittest.py:
2244
2245 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2246
2247         Add SPI WKNavigationResponse._downloadAttribute
2248         https://bugs.webkit.org/show_bug.cgi?id=196755
2249         <rdar://49587365>
2250
2251         Reviewed by Brady Eidson.
2252
2253         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2254         (-[NavigationResponseTestDelegate navigationResponse]):
2255         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2256         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2257         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2258         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2259         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2260         (readRequest):
2261         (writeResponse):
2262         (TEST):
2263
2264 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2265
2266         Add modern API for overriding the page's specified viewport configuration
2267         https://bugs.webkit.org/show_bug.cgi?id=167734
2268         <rdar://problem/30331795>
2269
2270         Reviewed by Simon Fraser.
2271
2272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2273         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2274
2275 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2276
2277         Add support for incremental bytecode cache updates
2278         https://bugs.webkit.org/show_bug.cgi?id=195000
2279
2280         Reviewed by Filip Pizlo.
2281
2282         Exit when the initial run to generate bytecode fails.
2283
2284         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2285
2286 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2287
2288         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2289         https://bugs.webkit.org/show_bug.cgi?id=196744
2290         <rdar://49415309>
2291
2292         Reviewed by Chris Dumez.
2293
2294         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2295         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2296
2297 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2298
2299         Add a way to opt into modern compatibility mode in layout tests
2300         https://bugs.webkit.org/show_bug.cgi?id=196770
2301         <rdar://problem/49777550>
2302
2303         Reviewed by Antoine Quint.
2304
2305         Add a new test option to enable modern compatibility mode in layout tests.
2306
2307         * WebKitTestRunner/TestController.cpp:
2308         (WTR::updateTestOptionsFromTestHeader):
2309         * WebKitTestRunner/TestController.h:
2310         * WebKitTestRunner/TestOptions.h:
2311         (WTR::TestOptions::hasSameInitializationOptions const):
2312         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2313         (WTR::TestController::platformCreateWebView):
2314         (WTR::TestController::enableModernCompatibilityMode):
2315
2316 2019-04-10  Andy Estes  <aestes@apple.com>
2317
2318         Try to fix the 32-bit watchOS build.
2319
2320         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2321         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2322
2323 2019-04-10  Antoine Quint  <graouts@apple.com>
2324
2325         Enable Pointer Events on watchOS
2326         https://bugs.webkit.org/show_bug.cgi?id=196771
2327         <rdar://problem/49040909>
2328
2329         Reviewed by Dean Jackson.
2330
2331         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2332
2333 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2334
2335         Unreviewed. Fix WPE accessibility tests after r244059.
2336
2337         We are failing to load the injected bundle due to undefined symbol
2338         AccessibilityUIElement::replaceTextInRange().
2339
2340         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2341         (WTR::AccessibilityUIElement::replaceTextInRange):
2342
2343 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2344
2345         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2346         https://bugs.webkit.org/show_bug.cgi?id=196727
2347
2348         Reviewed by Fujii Hironori.
2349
2350         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2351         (WebKitBrowserWindow::create):
2352
2353 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2354
2355         [ews-build] Add unit tests for PrintConfiguration
2356         https://bugs.webkit.org/show_bug.cgi?id=196752
2357
2358         Reviewed by Dewei Zhu.
2359
2360         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2361
2362 2019-04-09  Keith Rollin  <krollin@apple.com>
2363
2364         Unreviewed build maintenance -- update .xcfilelists.
2365
2366         * DumpRenderTree/DerivedSources-input.xcfilelist:
2367         * DumpRenderTree/DerivedSources-output.xcfilelist:
2368
2369 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2370
2371         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2372         https://bugs.webkit.org/show_bug.cgi?id=196743
2373         <rdar://problem/43897551>
2374
2375         Reviewed by Tim Horton.
2376
2377         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2378         (TEST):
2379
2380 2019-04-09  Youenn Fablet  <youenn@apple.com>
2381
2382         Close service worker database on network process suspension
2383         https://bugs.webkit.org/show_bug.cgi?id=196623
2384         <rdar://problem/48930869>
2385
2386         Reviewed by Alex Christensen.
2387
2388         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2389
2390 2019-04-09  Daniel Bates  <dabates@apple.com>
2391
2392         [iPad] Should open popover when the spacebar is pressed
2393         https://bugs.webkit.org/show_bug.cgi?id=196360
2394         <rdar://problem/49389129>
2395
2396         Reviewed by Brent Fulgham.
2397
2398         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2399
2400         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2401         (WTR::UIScriptController::isShowingPopover const): Added.
2402         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2403         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2404         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2405         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2406         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2407         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2408         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2409         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2410         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2411         (WTR::UIScriptController::isShowingPopover const): Added.
2412         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2413         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2414         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2415         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2416         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2417         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2418         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2419         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2420         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2421         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2422         (WTR::UIScriptController::isShowingPopover const): Added.
2423         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2424         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2425
2426 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2427
2428         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2429         https://bugs.webkit.org/show_bug.cgi?id=196665
2430         <rdar://45115669>
2431
2432         Reviewed by Geoff Garen.
2433
2434         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2435         (goBack):
2436         (+[SimpleLookupContext sharedLookupContext]):
2437         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2438         (TEST):
2439         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2440         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2441
2442 2019-04-09  John Wilander  <wilander@apple.com>
2443
2444         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2445         https://bugs.webkit.org/show_bug.cgi?id=196558
2446         <rdar://problem/47650245>
2447
2448         Reviewed by Youenn Fablet.
2449
2450         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2451         (TestWebKitAPI::TEST):
2452             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2453
2454 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2455
2456         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2457         https://bugs.webkit.org/show_bug.cgi?id=196720
2458
2459         Reviewed by Konstantin Tokarev.
2460
2461         * TestWebKitAPI/PlatformMac.cmake:
2462
2463 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2464
2465         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2466         https://bugs.webkit.org/show_bug.cgi?id=196694
2467         <rdar://problem/48388734>
2468
2469         Rubber-stamped by Aakash Jain.
2470
2471         * Scripts/webkitpy/port/image_diff.py:
2472         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2473         * Scripts/webkitpy/port/server_process.py:
2474         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2475         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2476         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2477         * Scripts/webkitpy/port/server_process_mock.py:
2478         (MockServerProcess.has_available_stdout):
2479         * Scripts/webkitpy/port/server_process_unittest.py:
2480         (TestServerProcess.serial_test_basic):
2481
2482 2019-04-09  Jer Noble  <jer.noble@apple.com>
2483
2484         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2485         https://bugs.webkit.org/show_bug.cgi?id=196097
2486
2487         Reviewed by Eric Carlson.
2488
2489         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2490
2491         * DumpRenderTree/mac/DumpRenderTree.mm:
2492         (resetWebPreferencesToConsistentValues):
2493         * WebKitTestRunner/TestController.cpp:
2494         (WTR::TestController::resetPreferencesToConsistentValues):
2495
2496 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2497
2498         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2499         https://bugs.webkit.org/show_bug.cgi?id=196690
2500
2501         Reviewed by Michael Catanzaro.
2502
2503         * QueueStatusServer/config/queues.py:
2504         * Scripts/webkitpy/common/config/ews.json:
2505         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2506         (test_ews_name):
2507
2508 2019-04-09  Chris Dumez  <cdumez@apple.com>
2509
2510         Loads using loadHTMLString() cause flashing when process-swapping
2511         https://bugs.webkit.org/show_bug.cgi?id=196714
2512         <rdar://problem/49637354>
2513
2514         Reviewed by Antti Koivisto.
2515
2516         Add API test coverage.
2517
2518         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2519
2520 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2521
2522         Unreviewed. Fix ATK accessibility tests after r244059.
2523
2524         We are failing to load the injected bundle due to undefined symbol
2525         AccessibilityUIElement::replaceTextInRange().
2526
2527         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2528         (WTR::AccessibilityUIElement::replaceTextInRange):
2529
2530 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2531
2532         AX: Support API: accessibilityReplaceRange:withText
2533         https://bugs.webkit.org/show_bug.cgi?id=196636
2534
2535         Unreviewed build fix for Windows port.
2536
2537         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2538         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2539
2540 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2541
2542         [CMake][WinCairo] Separate copied headers into different directories
2543         https://bugs.webkit.org/show_bug.cgi?id=196655
2544
2545         Reviewed by Michael Catanzaro.
2546
2547         * DumpRenderTree/CMakeLists.txt:
2548         * MiniBrowser/win/CMakeLists.txt:
2549         * TestWebKitAPI/CMakeLists.txt:
2550         * TestWebKitAPI/PlatformWin.cmake:
2551
2552 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2553
2554         Log stack-trace for run-webkit-tests when interrupted
2555         https://bugs.webkit.org/show_bug.cgi?id=176393
2556         <rdar://problem/34262310>
2557
2558         Reviewed by Lucas Forschler.
2559
2560         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2561         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2562         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2563         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2564         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2565         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2566         (main): Set handlers to log stack trace on interruption.
2567
2568 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2569
2570         AX: Support API: accessibilityReplaceRange:withText
2571         https://bugs.webkit.org/show_bug.cgi?id=196636
2572
2573         Unreviewed build fix for Windows port.
2574
2575         * DumpRenderTree/AccessibilityUIElement.cpp:
2576         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2577
2578 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2579
2580         [ews-build] Scripts using Buildbot API have CORS error
2581         https://bugs.webkit.org/show_bug.cgi?id=196709
2582
2583         Reviewed by Alexey Proskuryakov.
2584
2585         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2586
2587 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2588
2589         AX: Support API: accessibilityReplaceRange:withText
2590         https://bugs.webkit.org/show_bug.cgi?id=196636
2591
2592         Reviewed by Daniel Bates.
2593
2594         * DumpRenderTree/AccessibilityUIElement.cpp:
2595         (replaceTextInRangeCallback):
2596         (AccessibilityUIElement::replaceTextInRange):
2597         (AccessibilityUIElement::getJSClass):
2598         * DumpRenderTree/AccessibilityUIElement.h:
2599         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2600         (AccessibilityUIElement::replaceTextInRange):
2601         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2602         (AccessibilityUIElement::replaceTextInRange):
2603         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2604         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2605         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2606         (WTR::AccessibilityUIElement::replaceTextInRange):
2607         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2608         (WTR::AccessibilityUIElement::replaceTextInRange):
2609
2610 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2611
2612         [iOS] Do not allow starting selection drags when selection views are not visible
2613         https://bugs.webkit.org/show_bug.cgi?id=196686
2614         <rdar://problem/49399192>
2615
2616         Reviewed by Tim Horton.
2617
2618         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2619         also add some new API tests to cover scenarios where the web view is not first responder.
2620
2621         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2622         (TestWebKitAPI::TEST):
2623         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2624
2625         Add a switch to optionally make the web view first responder when starting the simulated drag.
2626
2627         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2628         (-[DragAndDropSimulator initWithWebView:]):
2629         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2630
2631 2019-04-08  Justin Fan  <justin_fan@apple.com>
2632
2633         [Web GPU] Fix Web GPU experimental feature on iOS
2634         https://bugs.webkit.org/show_bug.cgi?id=196632
2635
2636         Reviewed by Myles C. Maxfield.
2637
2638         Properly make Web GPU available on iOS 11+.
2639
2640         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2641
2642 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2643
2644         [ews-build] Do not upload archive when Compile Fails
2645         https://bugs.webkit.org/show_bug.cgi?id=196674
2646
2647         Reviewed by Alexey Proskuryakov.
2648
2649         * BuildSlaveSupport/ews-build/factories.py:
2650         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2651         * BuildSlaveSupport/ews-build/steps.py:
2652         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2653         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2654         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2655
2656 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2657
2658         Enable DFG on MIPS
2659         https://bugs.webkit.org/show_bug.cgi?id=196689
2660
2661         Reviewed by Žan Doberšek.
2662
2663         Since the bytecode change, we enabled the baseline JIT on mips in
2664         r240432, but DFG is still missing. With this change, all tests are
2665         passing on a ci20 board.
2666
2667         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2668
2669 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2670
2671         [Flatpak] Second run update-webkitwpe-flatpak fails
2672         https://bugs.webkit.org/show_bug.cgi?id=192702
2673
2674         Reviewed by Carlos Garcia Campos.
2675
2676         * flatpak/flatpakutils.py:
2677         (FlatpakObject.flatpak): Fix typo.
2678         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2679         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2680
2681 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2682
2683         [GTK][WPE] outlook.live.com displays old-fashioned UI
2684         https://bugs.webkit.org/show_bug.cgi?id=196642
2685
2686         Reviewed by Carlos Garcia Campos.
2687
2688         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2689         (TestWebKitAPI::TEST): New Mac platform quirk test.
2690
2691 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2692
2693         Unreviewed, rolling out r243956.
2694         https://bugs.webkit.org/show_bug.cgi?id=196688
2695
2696         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2697         by aakashjain on #webkit).
2698
2699         Reverted changeset:
2700
2701         "Clicking "Go Back" from a safe browsing warning from an
2702         iframe should navigate the WKWebView back to the previous
2703         page"
2704         https://bugs.webkit.org/show_bug.cgi?id=196665
2705         https://trac.webkit.org/changeset/243956
2706
2707 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2708
2709         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2710         https://bugs.webkit.org/show_bug.cgi?id=196669
2711
2712         Reviewed by Geoffrey Garen.
2713
2714         Added three new unit tests for WeakHashSet.
2715
2716         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2717         (WTF_WeakPtr.WeakHashSetConstObjects):
2718         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2719         (WTF_WeakPtr.WeakHashSetComputeSize):
2720
2721 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2722
2723         Hide next and previous form control buttons when WKWebView is editable
2724         https://bugs.webkit.org/show_bug.cgi?id=196672
2725         <rdar://problem/35625321>
2726
2727         Reviewed by Tim Horton.
2728
2729         Add a new API test.
2730
2731         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2732         (-[TestWKWebView lastTrailingBarButtonGroup]):
2733         (TestWebKitAPI::TEST):
2734         * TestWebKitAPI/ios/UIKitSPI.h:
2735
2736 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2737
2738         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2739         https://bugs.webkit.org/show_bug.cgi?id=196077
2740         <rdar://problem/49108202>
2741
2742         Reviewed by Chris Dumez.
2743
2744         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2745         on new web view.
2746
2747         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2748
2749 2019-04-05  Saam Barati  <sbarati@apple.com>
2750
2751         Make compare-results understand MotionMark
2752         https://bugs.webkit.org/show_bug.cgi?id=196666
2753
2754         Reviewed by Yusuke Suzuki.
2755
2756         * Scripts/compare-results:
2757         (PLT5Results):
2758         (detectMotionMark):
2759         (detectMotionMark1_1):
2760         (motionMarkResults):
2761         (motionMark1_1Results):
2762         (detectBenchmark):
2763         (biggerIsBetter):
2764         (main):
2765
2766 2019-04-05  Alex Christensen  <achristensen@webkit.org>
2767
2768         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2769         https://bugs.webkit.org/show_bug.cgi?id=196665
2770         <rdar://45115669>
2771
2772         Reviewed by Geoff Garen.
2773
2774         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2775         (goBack):
2776         (+[SimpleLookupContext sharedLookupContext]):
2777         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2778         (TEST):
2779         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2780         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2781
2782 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
2783
2784         [ews-build] Add configuration and architecture for windows builders
2785         https://bugs.webkit.org/show_bug.cgi?id=196660
2786
2787         Reviewed by Lucas Forschler.
2788
2789         * BuildSlaveSupport/ews-build/config.json:
2790
2791 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
2792
2793         webkitpy: Don't run subsequent rounds if interrupted
2794         https://bugs.webkit.org/show_bug.cgi?id=196646
2795
2796         Reviewed by Aakash Jain.
2797
2798         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2799         (Manager.run): Bail out if interrupted.
2800
2801 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
2802
2803         Test sessionStorage in PSON private browsing mode
2804         https://bugs.webkit.org/show_bug.cgi?id=196561
2805
2806         Reviewed by Alex Christensen.
2807
2808         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2809
2810 2019-04-05  Commit Queue  <commit-queue@webkit.org>
2811
2812         Unreviewed, rolling out r243833.
2813         https://bugs.webkit.org/show_bug.cgi?id=196645
2814
2815         This change breaks build of WPE and GTK ports (Requested by
2816         annulen on #webkit).
2817
2818         Reverted changeset:
2819
2820         "[CMake][WTF] Mirror XCode header directories"
2821         https://bugs.webkit.org/show_bug.cgi?id=191662
2822         https://trac.webkit.org/changeset/243833
2823
2824 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
2825
2826         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
2827         https://bugs.webkit.org/show_bug.cgi?id=196635
2828
2829         Reviewed by Antti Koivisto.
2830         
2831         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
2832         for a test to enable async frame scrolling via:
2833             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
2834         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
2835         
2836         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
2837
2838         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2839         (WTR::InjectedBundle::beginTesting):
2840         * WebKitTestRunner/TestController.cpp:
2841         (WTR::TestController::resetPreferencesToConsistentValues):
2842
2843 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
2844
2845         Use a correct LC_RPATH when building with ASan
2846         https://bugs.webkit.org/show_bug.cgi?id=196576
2847
2848         Reviewed by David Kilzer.
2849
2850         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
2851         so that ../Frameworks is checked. This is simpler and more reliable than updating
2852         each SPC service xcconfig.
2853
2854 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2855
2856         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
2857         https://bugs.webkit.org/show_bug.cgi?id=196629
2858
2859         Reviewed by Lucas Forschler.
2860
2861         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2862
2863 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2864
2865         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
2866         https://bugs.webkit.org/show_bug.cgi?id=196618
2867
2868         Reviewed by Lucas Forschler.
2869
2870         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2871         (StatusBubble): Added QUEUE_TRIGGERS.
2872         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
2873         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
2874         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
2875         its parent(builder).
2876
2877 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2878
2879         [ews-app] Status-bubble steps are sometimes displayed in reverse order
2880         https://bugs.webkit.org/show_bug.cgi?id=196625
2881
2882         Reviewed by Lucas Forschler.
2883
2884         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2885         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
2886
2887 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2888
2889         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
2890         https://bugs.webkit.org/show_bug.cgi?id=196630
2891
2892         Reviewed by Wenson Hsieh.
2893
2894         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2895
2896 2019-04-04  Youenn Fablet  <youenn@apple.com>
2897
2898         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
2899         https://bugs.webkit.org/show_bug.cgi?id=196543
2900
2901         Reviewed by Alex Christensen.
2902
2903         * WebKitTestRunner/TestController.cpp:
2904         (WTR::TestController::generatePageConfiguration):
2905
2906 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2907
2908         [ews-app] Status bubble should not display skipped buildbot steps
2909         https://bugs.webkit.org/show_bug.cgi?id=196584
2910
2911         Reviewed by Lucas Forschler.
2912
2913         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2914
2915 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2916
2917         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
2918         https://bugs.webkit.org/show_bug.cgi?id=196620
2919
2920         Reviewed by Lucas Forschler.
2921
2922         * BuildSlaveSupport/ews-app/ews/config.py:
2923
2924 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2925
2926         [Win] DumpRenderTreeWatchDog.py is not checked into source
2927         https://bugs.webkit.org/show_bug.cgi?id=196567
2928         <rdar://problem/49525901>
2929
2930         Reviewed by Lucas Forschler.
2931
2932         This script is used on Win EWS bots to terminate hanging DRT processes.
2933
2934         * EWSTools/dumprendertreewatchdog.py: Added.
2935
2936 2019-04-04  Chris Dumez  <cdumez@apple.com>
2937
2938         Unreviewed, roll out r243858 which made tests time out.
2939
2940         Disable new API tests on Windows instead.
2941
2942         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2943         (TestWebKitAPI::TEST):
2944
2945 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2946
2947         [ATK] Cleanup WebPageAccessibilityObjectAtk
2948         https://bugs.webkit.org/show_bug.cgi?id=196537
2949
2950         Reviewed by Michael Catanzaro.
2951
2952         Also consider files under atk directories as exceptions for GObject conventions.
2953
2954         * Scripts/webkitpy/style/checkers/cpp.py:
2955         (check_identifier_name_in_declaration):
2956
2957 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2958
2959         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2960         https://bugs.webkit.org/show_bug.cgi?id=196588
2961         <rdar://problem/49365787>
2962
2963         Unreviewed build fix for Windows port.
2964
2965         error C3861: 'kill': identifier not found
2966
2967         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2968         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2969
2970 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2971
2972         [ews-build] Cancel build and similar operations should have authentication
2973         https://bugs.webkit.org/show_bug.cgi?id=196520
2974
2975         Reviewed by Dewei Zhu.
2976
2977         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2978         environment variables.
2979
2980 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2981
2982         [ews-build] Do not trigger queues which are not in production yet
2983         https://bugs.webkit.org/show_bug.cgi?id=196581
2984
2985         Reviewed by Dewei Zhu.
2986
2987         * BuildSlaveSupport/ews-build/config.json:
2988
2989 2019-04-03  Chris Dumez  <cdumez@apple.com>
2990
2991         Unreviewed, fix typo in the name of API test added in r243848.
2992
2993         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2994         (TestWebKitAPI::TEST):
2995
2996 2019-04-03  Chris Dumez  <cdumez@apple.com>
2997
2998         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2999         https://bugs.webkit.org/show_bug.cgi?id=196588
3000         <rdar://problem/49365787>
3001
3002         Reviewed by Ryosuke Niwa.
3003
3004         Add API test coverage.
3005
3006         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3007         (TestWebKitAPI::nullJavaScriptCallback):
3008         (TestWebKitAPI::didCrashCheckFrames):
3009         (TestWebKitAPI::TEST):
3010
3011 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3012
3013         run-webkit-tests: Upload test results (new results database)
3014         https://bugs.webkit.org/show_bug.cgi?id=196577
3015         <rdar://problem/34841155>
3016
3017         Reviewed by Lucas Forschler.
3018
3019         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3020         (Manager.run): Upload results after each device shard, since the configuration will be
3021         different for each device.
3022         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3023         uploaded to a results database.
3024         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3025         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3026
3027 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3028
3029         -apple-trailing-word is needed for browser detection
3030         https://bugs.webkit.org/show_bug.cgi?id=196575
3031
3032         Unreviewed.
3033
3034         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3035
3036 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3037
3038         [CMake][WTF] Mirror XCode header directories
3039         https://bugs.webkit.org/show_bug.cgi?id=191662
3040
3041         Reviewed by Konstantin Tokarev.
3042
3043         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3044         builds.
3045
3046         * CMakeLists.txt:
3047         * DumpRenderTree/CMakeLists.txt:
3048         * DumpRenderTree/PlatformWin.cmake:
3049         * MiniBrowser/win/CMakeLists.txt:
3050         * TestWebKitAPI/CMakeLists.txt:
3051         * TestWebKitAPI/PlatformWin.cmake:
3052         * WebKitTestRunner/PlatformGTK.cmake:
3053         * WebKitTestRunner/PlatformWin.cmake:
3054
3055 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3056
3057         [ews-app] Status bubble should not display certain infrastructure status messages
3058         https://bugs.webkit.org/show_bug.cgi?id=196550
3059
3060         Reviewed by Lucas Forschler.
3061
3062         Do not display the steps which are un-needed for end-user. This information is still avaiable
3063         if the user click on the bubble and look at the Buildbot build.
3064         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3065         (StatusBubble._steps_messages):
3066         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3067
3068 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3069
3070         [ews-build] Use https for sending data to ews-app
3071         https://bugs.webkit.org/show_bug.cgi?id=196492
3072
3073         Reviewed by Lucas Forschler.
3074
3075         * BuildSlaveSupport/ews-build/events.py:
3076
3077 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3078
3079         Remove support for -apple-trailing-word
3080         https://bugs.webkit.org/show_bug.cgi?id=196525
3081
3082         Reviewed by Zalan Bujtas.
3083
3084         This CSS property is nonstandard and not used.
3085
3086         * Scripts/webkitperl/FeatureList.pm:
3087         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3088
3089 2019-04-03  Youenn Fablet  <youenn@apple.com>
3090
3091         Add a test for DOMCache on multiple browsing in case of private browsing
3092         https://bugs.webkit.org/show_bug.cgi?id=196524
3093
3094         Reviewed by Alex Christensen.
3095
3096         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3097         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3098
3099 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3100
3101         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3102         https://bugs.webkit.org/show_bug.cgi?id=196540
3103
3104         Reviewed by Aakash Jain.
3105
3106         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3107
3108 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3109
3110         Add plumbing for a compatibility mode preference in WebKit
3111         https://bugs.webkit.org/show_bug.cgi?id=196005
3112
3113         Reviewed by Tim Horton.
3114
3115         Add new API tests.
3116
3117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3118         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3119
3120 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3121
3122         [WPE][GTK] Update libsrtp dependency package for Debian
3123         https://bugs.webkit.org/show_bug.cgi?id=196528
3124
3125         Reviewed by Frédéric Wang.
3126
3127         * gtk/install-dependencies:
3128         * wpe/install-dependencies:
3129
3130 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3131
3132         [WK2] Add support for Window's beforeprint / afterprint events
3133         https://bugs.webkit.org/show_bug.cgi?id=196478
3134         <rdar://problem/49535124>
3135
3136         Unreviewed build fix for MSVC.
3137
3138         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3139
3140         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3141
3142         * WebKitTestRunner/TestController.cpp:
3143         (WTR::printFrame): Use int and float literals.
3144
3145 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3146
3147         [ews-build] Reassign bots to queues
3148
3149         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3150
3151 2019-04-02  Chris Dumez  <cdumez@apple.com>
3152
3153         [WK2] Add support for Window's beforeprint / afterprint events
3154         https://bugs.webkit.org/show_bug.cgi?id=196478
3155
3156         Reviewed by Alex Christensen.
3157
3158         Add minimal implementation for printFrame in WebKitTestRunner.
3159
3160         * WebKitTestRunner/TestController.cpp:
3161         (WTR::printFrame):
3162         (WTR::TestController::createOtherPage):
3163         (WTR::TestController::createWebViewWithOptions):
3164
3165 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3166
3167         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3168         https://bugs.webkit.org/show_bug.cgi?id=196491
3169
3170         Reviewed by Lucas Forschler.
3171
3172         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3173
3174 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3175
3176         [ews-build] Configure buildbot try credentials in environment variables
3177         https://bugs.webkit.org/show_bug.cgi?id=196501
3178
3179         Reviewed by Lucas Forschler.
3180
3181         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3182         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3183         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3184
3185 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3186
3187         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3188         https://bugs.webkit.org/show_bug.cgi?id=196496
3189         <rdar://problem/49521634>
3190
3191         Reviewed by Chris Dumez.
3192
3193         Add new API tests (see WebKit ChangeLog for more detail).
3194
3195         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3196         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3197         (TEST):
3198
3199 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3200
3201         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3202         <https://webkit.org/b/196499>
3203
3204         Reviewed by Alexey Proskuryakov.
3205
3206         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3207         ENABLE_ADDRESS_SANITIZER.
3208
3209 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3210
3211         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3212         https://bugs.webkit.org/show_bug.cgi?id=182757
3213
3214         Reviewed by Don Olmstead.
3215
3216         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3217         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3218
3219 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3220
3221         run-api-tests: Upload test results
3222         https://bugs.webkit.org/show_bug.cgi?id=196323
3223         <rdar://problem/49356714>
3224
3225         Reviewed by Lucas Forschler.
3226
3227         * Scripts/webkitpy/api_tests/manager.py:
3228         (Manager):
3229         (Manager.run): Upload results to a results database.
3230         * Scripts/webkitpy/api_tests/run_api_tests.py:
3231         (parse_args): Add upload arguments.
3232         * Scripts/webkitpy/port/base.py:
3233         (Port):
3234         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3235         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3236         with commits from any other associated repositories.
3237         * Scripts/webkitpy/port/device.py:
3238         (Device):
3239         (Device.build_version): Access build_versoin of underlying platform device.
3240         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3241         (IOSSimulatorTest):
3242         (IOSSimulatorTest.test_configuration_for_upload):
3243         * Scripts/webkitpy/port/device_port.py:
3244         (DevicePort):
3245         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3246         the same as the machine uploading results.
3247         * Scripts/webkitpy/port/mac.py:
3248         (MacPort):
3249         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3250         * Scripts/webkitpy/port/mac_unittest.py:
3251         (MacTest):
3252         (MacTest.test_configuration_for_upload):
3253         * Scripts/webkitpy/xcode/simulated_device.py:
3254         (SimulatedDeviceManager._create_device_with_runtime):
3255         (SimulatedDevice.__init__): Create simulated device with a build_version.
3256         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3257         (test_existing_simulator):
3258
3259 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3260
3261         Remove extra newline characters (Follow-up fix to r243707)
3262
3263         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3264
3265 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3266
3267         [ews-app] Use API_KEY to accept results data
3268         https://bugs.webkit.org/show_bug.cgi?id=196461
3269
3270         Reviewed by Dewei Zhu.
3271
3272         * BuildSlaveSupport/ews-app/ews/views/results.py:
3273         (Results.post): Validate EWS_API_KEY before accepting any data.
3274         * BuildSlaveSupport/ews-build/events.py:
3275         (Events.sendData): Send EWS_API_KEY if available along with event data.
3276
3277 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3278
3279         Unable to copy and paste a PDF from Notes into Mail compose body
3280         https://bugs.webkit.org/show_bug.cgi?id=196442
3281         <rdar://problem/48573098>
3282
3283         Reviewed by Tim Horton.
3284
3285         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3286         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3287         to be specified on the item providers.
3288
3289         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3290         (TestWebKitAPI::mapItemForTesting):
3291         (TestWebKitAPI::contactItemForTesting):
3292
3293 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3294
3295         Make UIWKDocumentContext rects per-character instead of per-word
3296         https://bugs.webkit.org/show_bug.cgi?id=196459
3297
3298         Reviewed by Wenson Hsieh.
3299
3300         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3301         (TEST):
3302         Adjust test results due to switching to per-character rects.
3303
3304 2019-04-01  Chris Dumez  <cdumez@apple.com>
3305
3306         UIProcess crash when a prewarmed process is terminated
3307         https://bugs.webkit.org/show_bug.cgi?id=196451
3308         <rdar://problem/49245471>
3309
3310         Reviewed by Geoffrey Garen.
3311
3312         Add API test coverage.
3313
3314         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3315         (TEST):
3316
3317 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3318
3319         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3320         https://bugs.webkit.org/show_bug.cgi?id=196449
3321
3322         Reviewed by Lucas Forschler.
3323
3324         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3325         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3326         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3327         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3328
3329 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3330
3331         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3332         https://bugs.webkit.org/show_bug.cgi?id=196444
3333
3334         Reviewed by Lucas Forschler.
3335
3336         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3337
3338 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3339
3340         Add SPI to canonicalize NSURLs with WTF::URL
3341         https://bugs.webkit.org/show_bug.cgi?id=196415
3342         <rdar://problem/44980271>
3343
3344         Reviewed by Darin Adler.
3345
3346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3347         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3348         (TestWebKitAPI::TEST):
3349
3350 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3351
3352         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3353         https://bugs.webkit.org/show_bug.cgi?id=196441
3354
3355         Reviewed by Carlos Garcia Campos.
3356
3357         Don't cache the wpe_view_backend object that might not exist yet at the
3358         time of EventSenderProxy constructor invocation, but instead retrieve
3359         that object whenever it's required for event dispatching. This should
3360         avoid crashes in this constructor now that it's invoked before any
3361         PlatformWindow has been set up (as changed in r243496).
3362
3363         * WebKitTestRunner/EventSenderProxy.h:
3364         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3365         (WTR::viewBackend):
3366         (WTR::EventSenderProxy::EventSenderProxy):
3367         (WTR::EventSenderProxy::mouseDown):
3368         (WTR::EventSenderProxy::mouseUp):
3369         (WTR::EventSenderProxy::mouseMoveTo):
3370         (WTR::EventSenderProxy::mouseScrollBy):
3371         (WTR::EventSenderProxy::keyDown):
3372         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3373
3374 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3375
3376         [Win][WebKit] MiniBrowser should support high DPI display
3377         https://bugs.webkit.org/show_bug.cgi?id=196391
3378
3379         Reviewed by Alex Christensen.
3380
3381         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3382         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3383         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3384         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3385
3386 2019-03-31  Sam Weinig  <weinig@apple.com>
3387
3388         Remove more i386 specific configurations
3389         https://bugs.webkit.org/show_bug.cgi?id=196430
3390
3391         Reviewed by Alexey Proskuryakov.
3392
3393         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3394         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3395
3396 2019-03-31  Andy Estes  <aestes@apple.com>
3397
3398         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3399         https://bugs.webkit.org/show_bug.cgi?id=196433
3400         <rdar://problem/49293305>
3401
3402         Reviewed by Tim Horton.
3403
3404         Enhanced API test coverage to include all navigation response policy decisions in both
3405         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3406
3407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3408         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3409         (TestWebKitAPI::TEST):
3410         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3411         (readFile):
3412         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3413         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3414         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3415         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3416         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3417         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3418         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3419         (-[QuickLookDelegate _downloadDidStart:]):
3420         (-[QuickLookDelegate _download:didReceiveResponse:]):
3421         (-[QuickLookDelegate _download:didReceiveData:]):
3422         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3423         (-[QuickLookDelegate _downloadDidFinish:]):
3424         (-[QuickLookDelegate _download:didFailWithError:]):
3425         (-[QuickLookDelegate _downloadDidCancel:]):
3426         (-[QuickLookDelegate verifyDownload]):
3427         (runTest):
3428         (runTestDecideBeforeLoading):
3429         (runTestDecideAfterLoading):
3430         (TEST):
3431         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3432         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3433         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3434         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3435         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3436         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3437         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3438         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3439         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3440         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3441         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3442         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3443         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3444         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3445
3446 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3447
3448         [CMake] add testdfg as target with build-jsc
3449         https://bugs.webkit.org/show_bug.cgi?id=196393
3450
3451         Reviewed by Saam Barati.
3452
3453         Added testdfg as one of the targets to build when
3454         using CMake.
3455
3456         * Scripts/build-jsc:
3457
3458 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3459
3460         Delete WebMetal implementation in favor of WebGPU
3461         https://bugs.webkit.org/show_bug.cgi?id=195418
3462
3463         Reviewed by Dean Jackson.
3464
3465         * DumpRenderTree/mac/DumpRenderTree.mm:
3466         (enableExperimentalFeatures):
3467         (resetWebPreferencesToConsistentValues):
3468         * Scripts/webkitperl/FeatureList.pm:
3469         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3471         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3472         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3473         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3474         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3475         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3476         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3477         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3478         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3479         (WTR::InjectedBundle::beginTesting):
3480         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3481         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3482         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3483
3484 2019-03-29  Chris Dumez  <cdumez@apple.com>
3485
3486         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3487         https://bugs.webkit.org/show_bug.cgi?id=196405
3488         <rdar://problem/49428130>
3489
3490         Reviewed by Wenson Hsieh.
3491
3492         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3493         the popover presentation methods to be no-ops. Use this in the new test added in
3494         r243523 so that we do not swizzle those methods for all tests. This is needed because
3495         those WatchOS tests rely on the popover getting presented and interactive.
3496
3497         * WebKitTestRunner/TestController.cpp:
3498         (WTR::updateTestOptionsFromTestHeader):
3499         * WebKitTestRunner/TestController.h:
3500         * WebKitTestRunner/TestOptions.h:
3501         (WTR::TestOptions::hasSameInitializationOptions const):
3502         * WebKitTestRunner/ios/TestControllerIOS.mm:
3503         (WTR::TestController::platformInitialize):
3504         (WTR::TestController::platformResetStateToConsistentValues):
3505
3506 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3507
3508         [Curl] Add Server Trust Evaluation Support.
3509         https://bugs.webkit.org/show_bug.cgi?id=191646
3510
3511         Reviewed by Fujii Hironori.
3512
3513         Implemented MiniBrowser UI for asking if user trusts the server.
3514
3515         * MiniBrowser/win/Common.cpp:
3516         (askServerTrustEvaluation):
3517         (replaceString):
3518         * MiniBrowser/win/Common.h:
3519         * MiniBrowser/win/MiniBrowserLib.rc:
3520         * MiniBrowser/win/MiniBrowserLibResource.h:
3521         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3522         (createPEMString):
3523         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3524         (WebKitBrowserWindow::canTrustServerCertificate):
3525         * MiniBrowser/win/WebKitBrowserWindow.h:
3526
3527 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3528
3529         Implement ResizeObserver.
3530         https://bugs.webkit.org/show_bug.cgi?id=157743
3531
3532         Reviewed by Simon Fraser.
3533
3534         Support resizeObserverEnabled webPreferences.
3535
3536         * DumpRenderTree/TestOptions.cpp:
3537         (TestOptions::TestOptions):
3538         * DumpRenderTree/TestOptions.h:
3539         * DumpRenderTree/mac/DumpRenderTree.mm:
3540         (setWebPreferencesForTestOptions):
3541         * DumpRenderTree/win/DumpRenderTree.cpp:
3542         (enableExperimentalFeatures):
3543         * Scripts/webkitperl/FeatureList.pm:
3544         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3545
3546 2019-03-28  John Wilander  <wilander@apple.com>
3547
3548         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3549         https://bugs.webkit.org/show_bug.cgi?id=196281
3550         <rdar://problem/48938748>
3551
3552         Reviewed by Alex Christensen.
3553
3554         This patch adds the function isStatisticsHasLocalStorage() to the
3555         TestRunner. With it, the page can query the WebsiteDataStore in the
3556         UI process to make sure that it sees LocalStorage.
3557
3558         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3559         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3560         (WTR::TestRunner::isStatisticsHasLocalStorage):
3561         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3562         * WebKitTestRunner/TestController.cpp:
3563         (WTR::TestController::isStatisticsHasLocalStorage):
3564         * WebKitTestRunner/TestController.h:
3565         * WebKitTestRunner/TestInvocation.cpp:
3566         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3567
3568 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3569
3570         API::Data::createWithoutCopying should do a null check before calling CFRelease
3571         https://bugs.webkit.org/show_bug.cgi?id=196276
3572         <rdar://problem/48059859>
3573
3574         Reviewed by Alex Christensen.
3575
3576         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3577
3578         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3579         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3580         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3581         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3582         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3583         (TestWebKitAPI::TEST):
3584
3585 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3586
3587         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3588         https://bugs.webkit.org/show_bug.cgi?id=186276
3589
3590         Reviewed by Carlos Garcia Campos.
3591
3592         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3593         (webViewLoadChanged):
3594         (testWebResourceGetDataError):
3595         (testWebResourceGetDataEmpty):
3596         (beforeAll):
3597         (webViewloadChanged): Deleted.
3598
3599 2019-03-27  Andy Estes  <aestes@apple.com>
3600
3601         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3602         https://bugs.webkit.org/show_bug.cgi?id=196317
3603
3604         Reviewed by Dan Bernstein.
3605
3606         package-root copies built products into a staging directory using ditto(1), which does not
3607         follow symbolic links as it traverses a directory. Now that the files in
3608         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3609         itself, these become broken links when ditto'd into the staging directory.
3610
3611         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3612
3613         * Scripts/package-root:
3614
3615 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3616
3617         [ews-app] Update display text of Submit for ews analysis
3618         https://bugs.webkit.org/show_bug.cgi?id=196309
3619
3620         Reviewed by Dewei Zhu.
3621
3622         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3623
3624 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3625
3626         run-webkit-tests should check for leaks in WebKit processes
3627         <https://webkit.org/b/193772>
3628         <rdar://problem/46526680>
3629
3630         Reviewed by Ryosuke Niwa.
3631
3632         This works by doing the following:
3633         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3634           The list of child processes are returned one per line:
3635           process.name: pid
3636         - Run the "#LIST CHILD PROCESSES" command just before the
3637           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3638           processes on the ServerProcess object.
3639         - When the `--leaks` switch is handled, run check_for_leaks() on
3640           each child process after the main test harness.
3641
3642         * DumpRenderTree/mac/DumpRenderTree.mm:
3643         (handleControlCommand):
3644         - Use strncmp() instead of strcmp().
3645         - Add support for handling "#LIST CHILD PROCESSES" command.
3646
3647         * Scripts/webkitpy/port/base.py:
3648         (Port.check_for_leaks):
3649         * Scripts/webkitpy/port/darwin.py:
3650         (DarwinPort.check_for_leaks):
3651         - Rename redundant 'process_pid' argument to 'process_id'.
3652
3653         * Scripts/webkitpy/port/driver.py:
3654         (Driver.do_post_tests_work):
3655         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3656           longer the only command this sends to WebKitTestRunner.
3657         - If the `--leaks` switch is present, send the
3658           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3659           result using Port.set_webkit_processes().
3660         (Driver._parse_child_processes_output):
3661         - Add helper method to parse list of child process names and
3662           process IDs returned from WebKitTestRunner.
3663
3664         * Scripts/webkitpy/port/ios_device.py:
3665         (IOSDevicePort.check_for_leaks):
3666         - Rename redundant 'process_pid' argument to 'process_id'.
3667
3668         * Scripts/webkitpy/port/leakdetector.py:
3669         (LeakDetector._parse_leaks_output):
3670         - Return early if there is no leaks_output.
3671         (LeakDetector.check_for_leaks):
3672         - Rename redundant 'process_pid' argument to 'process_id'.
3673
3674         * Scripts/webkitpy/port/server_process.py:
3675         (ServerProcess.__init__):
3676         (ServerProcess.child_processes):
3677         (ServerProcess.set_child_processes):
3678         - Add instance variable to Port to store list of child process
3679           names and process IDs returned from WebKitTestRunner.
3680         (ServerProcess._start):
3681         - Clear self._child_processes.
3682         (ServerProcess.stop):
3683         - If self._child_processes is set, call
3684           self._port.check_for_leaks() for each child process.
3685
3686         * Scripts/webkitpy/port/server_process_unittest.py:
3687         (TrivialMockPort.check_for_leaks):
3688         - Rename redundant 'process_pid' argument to 'process_id'.
3689
3690         * Scripts/webkitpy/port/simulator_process.py:
3691         (SimulatorProcess.stop):
3692         - If self._child_processes is set, call
3693           self._port.check_for_leaks() for each child process.
3694
3695         * Scripts/webkitpy/port/watch_device.py:
3696         (WatchDevicePort.check_for_leaks):
3697         - Rename redundant 'process_pid' argument to 'process_id'.
3698
3699         * WebKitTestRunner/TestController.cpp:
3700         (WTR::TestController::dumpResponse):
3701         - Extract method from findAndDumpWorldLeaks() so that it may be
3702           reused by findAndDumpWebKitProcessIdentifiers().
3703         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3704         - Add method to output process name and process ID of both the
3705           WebContent and Networking processes.
3706         (WTR::TestController::findAndDumpWorldLeaks):
3707         - Fix missing newline in output when there were no abandoned
3708           documents.
3709         - Call dumpResponse() for extracted code.
3710         (WTR::TestController::handleControlCommand):
3711         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3712         - Use strncmp() instead of strcmp().
3713         - Call findAndDumpWebKitProcessIdentifiers() when
3714           "#LIST CHILD PROCESSES" command is sent.
3715         * WebKitTestRunner/TestController.h:
3716         (WTR::TestController::dumpResponse):
3717         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3718         - Declare methods.
3719
3720 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3721
3722         Unreviewed. Add GLib API test cases after r243434.
3723
3724         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3725         (testWebViewActiveURI):
3726         (serverCallback):
3727         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3728         (sendRequestCallback):
3729
3730 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3731
3732         Geolocation request not complete when watch request was started in a different web process
3733         https://bugs.webkit.org/show_bug.cgi?id=195996
3734
3735         Reviewed by Alex Christensen.
3736
3737         Add a test case.
3738
3739         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3740         (TestWebKitAPI::runJavaScriptAlert):
3741         (TestWebKitAPI::TEST):
3742
3743 2019-03-26  Keith Rollin  <krollin@apple.com>
3744
3745         Update the way generate-xcfilelists returns strings from functions
3746         https://bugs.webkit.org/show_bug.cgi?id=195975
3747         <rdar://problem/49040807>
3748
3749         Reviewed by Dean Jackson.
3750
3751         There are places where generate-xcfilelists executes assignments with
3752         statements like:
3753
3754             FOO=$(some_function)
3755
3756         where "some_function" return a string by echoing it. E.g.
3757
3758             some_function()
3759             {
3760                 echo "Hello, World"
3761             }
3762
3763         This is a common idiom, but it has a problem if "some_function" needs
3764         to call "exit" in an attempt to halt the entire script right then and
3765         there. Since "some_function" is called inside of $(), it's being
3766         executed in a sub-shell. Calling exit in that sub-shell simply exits
3767         that shell; it doesn't not exit the outer shell in which the main part
3768         of the script is still running. As such, the main script keeps
3769         executing when the intent was for the script to halt.
3770
3771         The solution to this is to use a different idiom for returning
3772         strings. The one we now is to pass in the name of the variable to
3773         receive the string result:
3774
3775             some_function()
3776             {
3777                 variable_name=$1
3778                 eval $variable_name ="Hello, World"
3779             }
3780
3781         The call site now looks like
3782
3783             some_function FOO
3784
3785         Because there's no invocation of a sub-shell, some_function can now
3786         call "exit" if it wants to, and the entire script will exit at that
3787         point.
3788
3789         * Scripts/generate-xcfilelists:
3790
3791 2019-03-26  Chris Dumez  <cdumez@apple.com>
3792
3793         Add basic layout test coverage for File Picker on iOS
3794         https://bugs.webkit.org/show_bug.cgi?id=196265
3795
3796         Reviewed by Wenson Hsieh.
3797
3798         Add layout test infrastructure to test the file picker on iOS.
3799
3800         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3801         (WTR::UIScriptController::dismissFilePicker):
3802         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3803         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3804         (WTR::UIScriptController::dismissFilePicker):
3805         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3806         * WebKitTestRunner/TestController.cpp:
3807         (WTR::TestController::createWebViewWithOptions):
3808         (WTR::updateTestOptionsFromTestHeader):
3809         * WebKitTestRunner/TestOptions.h:
3810         (WTR::TestOptions::hasSameInitializationOptions const):
3811         * WebKitTestRunner/ios/TestControllerIOS.mm:
3812         (overridePresentViewController):
3813         (WTR::TestController::platformInitialize):
3814         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3815         (WTR::UIScriptController::dismissFilePicker):
3816
3817 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3818
3819         Implement async paste method on UIWKInteractionViewProtocol
3820         https://bugs.webkit.org/show_bug.cgi?id=196267
3821         <rdar://problem/49236346>
3822
3823         Reviewed by Tim Horton.
3824
3825         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
3826         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
3827         are now a part of all iOS 12 internal SDKs.
3828
3829         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3830
3831         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
3832         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
3833
3834         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3835         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3836         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
3837         * TestWebKitAPI/ios/UIKitSPI.h:
3838
3839 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3840
3841         [ews-build] Use PostgreSQL for ews.webkit.org database
3842         https://bugs.webkit.org/show_bug.cgi?id=196270
3843
3844         Reviewed by Lucas Forschler.
3845
3846         * BuildSlaveSupport/ews-app/ews-app/settings.py:
3847
3848 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
3849
3850         [ews] Reset simctl states on reboot
3851         https://bugs.webkit.org/show_bug.cgi?id=196260
3852
3853         Rubber-stamped by Aakash Jain.
3854
3855         * EWSTools/start-queue-mac.sh:
3856
3857 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3858
3859         [ews-build] Use PostgreSQL for ews-build database
3860         https://bugs.webkit.org/show_bug.cgi?id=196229
3861
3862         Reviewed by Lucas Forschler.
3863
3864         * BuildSlaveSupport/ews-build/master.cfg:
3865
3866 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3867
3868         [ews-build] Get master_hostname dynamically in master.cfg
3869         https://bugs.webkit.org/show_bug.cgi?id=196255
3870
3871         Reviewed by Lucas Forschler.
3872
3873         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
3874         send events data in test mode.
3875
3876 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3877
3878         [ews-app] Set db_constraint to False for Foreign Keys
3879         https://bugs.webkit.org/show_bug.cgi?id=196252
3880
3881         Reviewed by Lucas Forschler.
3882
3883         * BuildSlaveSupport/ews-app/ews/models/build.py:
3884         * BuildSlaveSupport/ews-app/ews/models/step.py:
3885
3886 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3887
3888         [ews-build] is_test_mode_enabled should default to True
3889         https://bugs.webkit.org/show_bug.cgi?id=196248
3890
3891         Reviewed by Lucas Forschler.
3892
3893         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
3894
3895 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3896
3897         [ews-app] Add webkitperl to ENABLED_QUEUES
3898         https://bugs.webkit.org/show_bug.cgi?id=196253
3899
3900         Reviewed by Lucas Forschler.
3901
3902         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3903
3904 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
3905
3906         Address NSWindow sometimes using WebKitTestRunnerEvent too early
3907         https://bugs.webkit.org/show_bug.cgi?id=196211
3908         rdar://problem/49110552
3909
3910         Reviewed by Tim Horton.
3911
3912         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
3913         Make sure that EventSenderProxy always exists when running tests. We used to create
3914         it when resetting before the first test, which is a bit too late.
3915
3916         * WebKitTestRunner/TestController.h:
3917         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3918         (WTR::TestController::platformCreateWebView):
3919         (WTR::TestController::platformCreateOtherPage):
3920         (WTR::TestController::finishCreatingPlatformWebView):
3921         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3922         (WTR::PlatformWebView::PlatformWebView):
3923         Moved some code that made NSWindow use NSEvent during web view creation. We may
3924         need to move more if some other case us found, but this is enough for now.
3925
3926 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3927
3928         Unreviewed. Fix typo in GLib geolocation API after r243285.
3929
3930         gelocation -> geolocation.
3931
3932         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
3933         (testGeolocationManagerWatchPosition):
3934
3935 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3936
3937         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3938         https://bugs.webkit.org/show_bug.cgi?id=196213
3939
3940         Reviewed by Geoff Garen.
3941
3942         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3943         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3944         (credentialWithIdentityAndKeychainPath):
3945         (-[ChallengeDelegate webView:didFinishNavigation:]):
3946         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3947         (TestWebKitAPI::TEST):
3948
3949 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3950
3951         Expected shouldn't assume its contained types are copyable
3952         https://bugs.webkit.org/show_bug.cgi?id=195986
3953
3954         Reviewed by JF Bastien.
3955
3956         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3957         (TestWebKitAPI::NonCopyable::operator== const):
3958         (TestWebKitAPI::NonCopyable::operator!= const):
3959         (TestWebKitAPI::TEST):
3960
3961 2019-03-25  Tim Horton  <timothy_horton@apple.com>
3962
3963         Remove some now-unnecessary dynamic class lookup
3964         https://bugs.webkit.org/show_bug.cgi?id=196237
3965
3966         Reviewed by Simon Fraser.
3967
3968         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3969         (makeRequest):
3970         (TEST):
3971
3972 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3973
3974         Unreviewed, rolling out r243450.
3975
3976         AppleWin and WinCairo port builds get broken.
3977
3978         Reverted changeset:
3979
3980         "Add test for fix of #196095"
3981         https://bugs.webkit.org/show_bug.cgi?id=196097
3982         https://trac.webkit.org/changeset/243450
3983
3984 2019-03-25  Commit Queue  <commit-queue@webkit.org>
3985
3986         Unreviewed, rolling out r243465.
3987         https://bugs.webkit.org/show_bug.cgi?id=196226
3988
3989         the test doesn't build (Requested by thorton on #webkit).
3990
3991         Reverted changeset:
3992
3993         "Do not terminate the NetworkProcess if a third party
3994         application sends a NSCredential with a SecIdentityRef"
3995         https://bugs.webkit.org/show_bug.cgi?id=196213
3996         https://trac.webkit.org/changeset/243465
3997
3998 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3999
4000         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4001         https://bugs.webkit.org/show_bug.cgi?id=196213
4002
4003         Reviewed by Geoff Garen.
4004
4005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4006         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4007         (credentialWithIdentityAndKeychainPath):
4008         (-[ChallengeDelegate webView:didFinishNavigation:]):
4009         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4010         (TestWebKitAPI::TEST):
4011
4012 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4013
4014         [ews-build] Gracefully handle missing patch_id in events
4015         https://bugs.webkit.org/show_bug.cgi?id=196216
4016
4017         Reviewed by Lucas Forschler.
4018
4019         * BuildSlaveSupport/ews-build/events.py:
4020
4021 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4022
4023         [ews-build] use lz4 compression for improving buildbot performance
4024         https://bugs.webkit.org/show_bug.cgi?id=196155
4025
4026         Reviewed by Lucas Forschler.
4027
4028         * BuildSlaveSupport/ews-build/master.cfg:
4029
4030 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4031
4032         Pull some API testing helper methods out of TestWKWebView
4033         https://bugs.webkit.org/show_bug.cgi?id=196212
4034
4035         Reviewed by Tim Horton.
4036
4037         Refactor some more API testing utility methods, so that they can be used in
4038         tests that do not use TestWKWebView.
4039
4040         * TestWebKitAPI/cocoa/TestWKWebView.h:
4041         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4042         (-[WKWebView loadTestPageNamed:]):
4043         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
4044         (-[WKWebView synchronouslyLoadHTMLString:]):
4045         (-[WKWebView synchronouslyLoadTestPageNamed:]):
4046         (-[TestWKWebView loadTestPageNamed:]): Deleted.
4047         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
4048         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
4049         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
4050
4051 2019-03-25  Jer Noble  <jer.noble@apple.com>
4052
4053         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
4054         https://bugs.webkit.org/show_bug.cgi?id=196097
4055
4056         Reviewed by Eric Carlson.
4057
4058         Drive-by bug fix: allow tests to play audio without a user gesture by default.
4059
4060         * DumpRenderTree/mac/DumpRenderTree.mm:
4061         (resetWebPreferencesToConsistentValues):
4062         * WebKitTestRunner/TestController.cpp:
4063         (WTR::TestController::resetPreferencesToConsistentValues):
4064
4065 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4066
4067         Pull IPadUserInterfaceSwizzler out into a separate header file
4068         https://bugs.webkit.org/show_bug.cgi?id=196193
4069
4070         Reviewed by Anders Carlsson.
4071
4072         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
4073         be used in other API tests.
4074
4075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4076         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
4077         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
4078         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
4079         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
4080         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
4081         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
4082
4083 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4084
4085         Remove NavigatorContentUtils in WebCore/Modules
4086         https://bugs.webkit.org/show_bug.cgi?id=196070
4087
4088         Reviewed by Alex Christensen.
4089
4090         NavigatorContentUtils was to support the custom scheme spec [1].
4091         However, in WebKit side, no port has supported the feature in
4092         WebKit layer after EFL port was removed. So there has been the
4093         only IDL implementation of the NavigatorContentUtils in WebCore.
4094         So we don't need to keep the implementation in WebCore anymore.
4095
4096         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
4097
4098         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4099
4100 2019-03-24  Andy Estes  <aestes@apple.com>
4101
4102         [watchOS] Remove unused Proximity Networking code
4103         https://bugs.webkit.org/show_bug.cgi?id=196188
4104
4105         Reviewed by Tim Horton.
4106
4107         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
4108         (TEST):
4109
4110 2019-03-23  Keith Miller  <keith_miller@apple.com>
4111
4112         Refactor clz/ctz and fix getLSBSet.
4113         https://bugs.webkit.org/show_bug.cgi?id=196162
4114
4115         Reviewed by Saam Barati.
4116
4117         Add tests for clz, ctz, getLSBSet, and getMSBSet.
4118
4119         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
4120         (TestWebKitAPI::TEST):
4121
4122 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
4123
4124         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
4125         https://bugs.webkit.org/show_bug.cgi?id=196143
4126
4127         Reviewed by Michael Catanzaro.
4128
4129         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
4130         directories.
4131
4132         * Scripts/webkitpy/style/checkers/cpp.py:
4133         (check_identifier_name_in_declaration):
4134         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4135         (WebKitStyleTest.test_names):
4136
4137 2019-03-22  Philippe Normand  <pnormand@igalia.com>
4138
4139         [Flatpak] Manifest expanding fails for qt WPE extension
4140         https://bugs.webkit.org/show_bug.cgi?id=196148
4141
4142         Reviewed by Alex Christensen.
4143
4144         * flatpak/flatpakutils.py:
4145         (expand_submodules_recurse): The last recurse manifest expand
4146         iteration might lead to a single module so take it into account
4147         and don't try to recurse further.
4148
4149 2019-03-22  Chris Dumez  <cdumez@apple.com>
4150
4151         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
4152         https://bugs.webkit.org/show_bug.cgi?id=195348
4153         <rdar://problem/48622090>
4154
4155         Reviewed by Alex Christensen.
4156
4157         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
4158         to NO when test.options().shouldIgnoreMetaViewport is false.
4159
4160         * WebKitTestRunner/ios/TestControllerIOS.mm:
4161         (WTR::TestController::platformConfigureViewForTest):
4162
4163 2019-03-22  Chris Dumez  <cdumez@apple.com>
4164
4165         Prewarmed processes should be usable with any website data store
4166         https://bugs.webkit.org/show_bug.cgi?id=196104
4167
4168         Reviewed by Alex Christensen.
4169
4170         Add API test coverage.
4171
4172         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
4173         (runInitialWarmedProcessUsedTest):
4174         (TEST):
4175
4176 2019-03-22  David Kilzer  <ddkilzer@apple.com>
4177
4178         Back out local changes to Alex's Subversion working directory
4179
4180         They were accidentally committed.
4181
4182         * Scripts/webkitpy/common/system/abstractexecutive.py:
4183         (AbstractExecutive.wait_newest):
4184         * Scripts/webkitpy/common/system/executive.py:
4185         (Executive.running_pids):
4186         * Scripts/webkitpy/common/system/executive_mock.py:
4187         (MockExecutive.running_pids):
4188         * Scripts/webkitpy/common/system/executive_unittest.py:
4189         (ExecutiveTest.serial_test_running_pids):
4190         * Scripts/webkitpy/port/darwin.py:
4191         (DarwinPort.check_for_leaks):
4192         * Scripts/webkitpy/port/leakdetector.py:
4193         (LeakDetector.check_for_leaks):
4194         - This was the hack attached to Bug 193772.
4195
4196         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
4197         (+[WebKitTestRunnerEvent mouseLocation]):
4198         - This works around a crash on an internal build.
4199
4200 2019-03-22  Tim Horton  <timothy_horton@apple.com>
4201
4202         Fix the build after r243354
4203         https://bugs.webkit.org/show_bug.cgi?id=196138
4204         <rdar://problem/49145951>
4205
4206         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4207         (TEST):
4208         * TestWebKitAPI/ios/UIKitSPI.h:
4209
4210 2019-03-21  Tim Horton  <timothy_horton@apple.com>
4211
4212         Adopt UIWKDocumentContext
4213         https://bugs.webkit.org/show_bug.cgi?id=196040
4214         <rdar://problem/48642440>
4215
4216         Reviewed by Ryosuke Niwa.
4217
4218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4219         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
4220         (makeRequest):
4221         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
4222         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
4223         (applyStyle):
4224         (TEST):
4225         Add tests for UIWKDocumentContext.
4226
4227         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
4228         (TEST):
4229         (recursiveFindWKContentView): Deleted.
4230         * TestWebKitAPI/cocoa/TestWKWebView.h:
4231         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4232         (recursiveFindWKContentView):
4233         (-[TestWKWebView wkContentView]):
4234         * TestWebKitAPI/ios/UIKitSPI.h:
4235         Share the WKContentView finding code between tests.
4236
4237 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
4238
4239         [iOS WK2] Turn on async overflow scrolling by default
4240         https://bugs.webkit.org/show_bug.cgi?id=196011
4241         rdar://problem/48453859
4242
4243         Reviewed by Antti Koivisto.
4244         
4245         Explicitly turn off the async overflow scrolling internal feature for tests by default,
4246         since so many basic layout tests have different results when compositing is triggered for
4247         overflow.
4248         
4249         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
4250
4251         * WebKitTestRunner/TestController.cpp:
4252         (WTR::TestController::resetPreferencesToConsistentValues):
4253
4254 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
4255
4256         [ews-build] Retry API test in case of failures
4257         https://bugs.webkit.org/show_bug.cgi?id=196004
4258
4259         Reviewed by Lucas Forschler.
4260
4261         * BuildSlaveSupport/ews-build/steps.py:
4262         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
4263         (CompileWebKitToT.doStepIf): Ditto.
4264         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
4265         (ReRunAPITests): Re-run API tests.
4266         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
4267         (RunAPITestsWithoutPatch): Run API tests without patch.
4268         (RunAPITestsWithoutPatch.doStepIf):
4269         (RunAPITestsWithoutPatch.hideStepIf):
4270         (RunAPITestsWithoutPatch.evaluateCommand):
4271         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
4272         (AnalyzeAPITestsResults.start):
4273         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
4274         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
4275         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
4276         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
4277
4278 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
4279
4280         [ews-build] Update queues configurations
4281         https://bugs.webkit.org/show_bug.cgi?id=196074
4282
4283         Reviewed by Dewei Zhu.
4284
4285         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
4286         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
4287
4288 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
4289
4290         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
4291         https://bugs.webkit.org/show_bug.cgi?id=195680
4292         <rdar://problem/48903534>
4293
4294         Unreviewed infrastructure fix.
4295
4296         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4297         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
4298
4299 2019-03-21  Andy Estes  <aestes@apple.com>
4300
4301         [iOS] Apple Pay should be available in documents with no user agent scripts
4302         https://bugs.webkit.org/show_bug.cgi?id=196061
4303         <rdar://problem/48649391>