[ews-build] Configure ews151 for running various tests
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Configure ews151 for running various tests
4         https://bugs.webkit.org/show_bug.cgi?id=197419
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-build/config.json:
9
10 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
11
12         [ews-build] Parse and display bindings test failures
13         https://bugs.webkit.org/show_bug.cgi?id=197423
14
15         Reviewed by Lucas Forschler.
16
17         * BuildSlaveSupport/ews-build/steps.py:
18         (RunBindingsTests.__init__): Set timeout of 5 minutes.
19         (RunBindingsTests.start): Initialize log_observer for json output.
20         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
21         (RunBindingsTests._addToLog): Method to add message to log.
22         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
23
24 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
25
26         Unreviewed. Add myself as a committer.
27
28         * Scripts/webkitpy/common/config/contributors.json:
29
30 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
31
32         [ews-build] Enable webkitpy queue on new EWS
33         https://bugs.webkit.org/show_bug.cgi?id=197396
34
35         Reviewed by Lucas Forschler.
36
37         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
38         (StatusBubble):
39         * BuildSlaveSupport/ews-build/config.json:
40
41 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
42
43         [ews-build] Parse and display webkitpy failures
44         https://bugs.webkit.org/show_bug.cgi?id=197395
45
46         Reviewed by Lucas Forschler.
47
48         * BuildSlaveSupport/ews-build/steps.py:
49         (RunWebKitPyTests.start): Initialize log_observer for json output.
50         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
51         (RunWebKitPyTests._addToLog): Method to add message to log.
52         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
53
54 2019-04-29  Alex Christensen  <achristensen@webkit.org>
55
56         <rdar://problem/50299396> Fix internal High Sierra build
57         https://bugs.webkit.org/show_bug.cgi?id=197388
58
59         * DumpRenderTree/mac/Configurations/Base.xcconfig:
60         * MiniBrowser/Configurations/Base.xcconfig:
61         * MobileMiniBrowser/Configurations/Base.xcconfig:
62         * TestWebKitAPI/Configurations/Base.xcconfig:
63         * WebKitTestRunner/Configurations/Base.xcconfig:
64
65 2019-04-29  Youenn Fablet  <youenn@apple.com>
66
67         Remove spurious GVA printf logging
68         https://bugs.webkit.org/show_bug.cgi?id=197368
69         <rdar://problem/35975256>
70
71         Reviewed by Alexey Proskuryakov.
72
73         * Scripts/webkitpy/port/mac.py:
74         (MacPort.logging_patterns_to_strip):
75
76 2019-04-29  Youenn Fablet  <youenn@apple.com>
77
78         getDisplayMedia should be called on user gesture
79         https://bugs.webkit.org/show_bug.cgi?id=197356
80         <rdar://problem/50296074>
81
82         Reviewed by Eric Carlson.
83
84         Update test configuration to inject internals
85         so that we can use it to simulate a user click to call getDisplayMedia.
86
87         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
88         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
89         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
90
91 2019-04-26  Stephanie Lewis  <slewis@apple.com>
92
93         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
94         https://bugs.webkit.org/show_bug.cgi?id=197339
95
96         Reviewed by Dewei Zhu.
97
98         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
99         test run for setup steps that are too expensive to do every iteration.
100
101         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
102         (BenchmarkRunner._run_benchmark):
103         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
104         (BrowserDriver):
105         (BrowserDriver.prepare_initial_env):
106         (BrowserDriver.restore_env_after_all_testing):
107         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
108         (LinuxBrowserDriver.prepare_initial_env):
109         (LinuxBrowserDriver.restore_env_after_all_testing):
110         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
111         (OSXBrowserDriver.prepare_initial_env):
112         (OSXBrowserDriver.restore_env_after_all_testing):
113
114 2019-04-28  Andy Estes  <aestes@apple.com>
115
116         Fix the watchOS engineering build.
117
118         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
119         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
120
121 2019-04-27  Chris Dumez  <cdumez@apple.com>
122
123         [WKTR] Move test timeout handling to the UIProcess
124         https://bugs.webkit.org/show_bug.cgi?id=197333
125
126         Reviewed by Darin Adler.
127
128         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
129         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
130         every WebContent process in the case of swapping.
131
132         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
133         would lead to crashes when firing the timer.
134
135         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
136         (WTR::InjectedBundle::didReceiveMessageToPage):
137         (WTR::InjectedBundle::done):
138         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
139         (WTR::InjectedBundle::shouldDumpPixels const):
140         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
141         (WTR::TestRunner::TestRunner):
142         (WTR::TestRunner::waitUntilDone):
143         (WTR::TestRunner::setWaitUntilDone):
144         * WebKitTestRunner/InjectedBundle/TestRunner.h:
145         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
146         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
147         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
148         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
149         * WebKitTestRunner/TestInvocation.cpp:
150         (WTR::TestInvocation::TestInvocation):
151         (WTR::TestInvocation::createTestSettingsDictionary):
152         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
153         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
154         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
155         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
156         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
157         (WTR::TestInvocation::setWaitUntilDone):
158         (WTR::TestInvocation::done):
159         * WebKitTestRunner/TestInvocation.h:
160
161 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
162
163         [JSC] linkPolymorphicCall now does GC
164         https://bugs.webkit.org/show_bug.cgi?id=197306
165
166         Reviewed by Saam Barati.
167
168         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
169         To add this test, we add `runWithoutBaseOption`.
170
171         * Scripts/run-jsc-stress-tests:
172
173 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
174
175         Update inactive reviewers' status to 'contributor'.
176
177         Accidentally skipped one at first.
178
179         * Scripts/webkitpy/common/config/contributors.json:
180
181 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
182
183         Update inactive reviewers' status to 'contributor'.
184
185         * Scripts/webkitpy/common/config/contributors.json: The change.
186
187         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
188         * Scripts/webkitpy/common/checkout/checkout_mock.py:
189         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
190         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
191         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
192         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
193         * Scripts/webkitpy/tool/commands/queries_unittest.py:
194         * Scripts/webkitpy/tool/commands/upload_unittest.py:
195         Sadly, regression tests operate on a crazy mix of mock and live data for
196         contributors.json. It would be a substantial project to mock all code paths,
197         so changing the tests instead.
198
199 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
200
201         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
202         https://bugs.webkit.org/show_bug.cgi?id=197171
203         <rdar://problem/47454979>
204
205         Reviewed by Youenn Fablet.
206
207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
208         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
209         (TestWebKitAPI::TEST):
210
211 2019-04-26  David Kilzer  <ddkilzer@apple.com>
212
213         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
214         <https://webkit.org/b/197314>
215         <rdar://problem/50245252>
216
217         Reviewed by Simon Fraser.
218
219         * WebKitTestRunner/UIScriptControllerCocoa.mm:
220         (WTR::UIScriptController::lastUndoLabel const):
221         (WTR::UIScriptController::firstRedoLabel const):
222         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
223
224         * WebKitTestRunner/ios/HIDEventGenerator.mm:
225         (-[HIDEventGenerator sendEventStream:completionBlock:]):
226         - Call -autorelease to fix leak of NSDictionary.
227
228         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
229         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
230         (WTR::UIScriptController::selectFormPopoverTitle const):
231         (WTR::UIScriptController::textContentType const):
232         (WTR::UIScriptController::formInputLabel const):
233         (WTR::UIScriptController::scrollingTreeAsText const):
234         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
235
236 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
237
238         webkitpy: Running a single test will always use the default device
239         https://bugs.webkit.org/show_bug.cgi?id=195472
240         <rdar://problem/48724825>
241
242         Reviewed by Lucas Forschler.
243
244         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
245         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
246         requested will be run regardless of what shard they are in.
247
248         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
249         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
250         * Scripts/webkitpy/layout_tests/controllers/manager.py:
251         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
252         on the default device type.
253         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
254         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
255         (RunTest.test_run_part): Ditto.
256
257 2019-04-26  Alex Christensen  <achristensen@webkit.org>
258
259         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
260         https://bugs.webkit.org/show_bug.cgi?id=197165
261
262         Reviewed by Youenn Fablet.
263
264         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
265
266 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
267
268         Replace iOS build queue hardware
269         https://bugs.webkit.org/show_bug.cgi?id=197312
270
271         Reviewed by Aakash Jain.
272
273         * BuildSlaveSupport/build.webkit.org-config/config.json:
274         Use newer hardware that supports macOS Mojave.
275
276 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
277
278         check-webkit-style complains the first block in while loop.
279         https://bugs.webkit.org/show_bug.cgi?id=197307
280
281         The style checker shouldn't complain about an open brace on
282         its own line if the last non-whitespace character on the previous
283         non-blank line is another open brace, because it's likely to
284         indicate the begining of a nested code block.
285
286         Reviewed by Alex Christensen.
287
288         * Scripts/webkitpy/style/checkers/cpp.py:
289         (check_braces):
290         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
291         (WebKitStyleTest.test_braces):
292
293 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
294
295         Stop IDB transactions to release locked database files when network process is ready to suspend
296         https://bugs.webkit.org/show_bug.cgi?id=196372
297         <rdar://problem/48930116>
298
299         Reviewed by Brady Eidson.
300
301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
302         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
303         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
304         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
305         (runTestAndCheckResult):
306         (keepNetworkProcessActive):
307         (TEST):
308
309 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
310
311         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
312         https://bugs.webkit.org/show_bug.cgi?id=188357
313         <rdar://problem/42986633>
314
315         Reviewed by Dean Jackson.
316
317         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
318         tests would fall into low memory mode and have different behavior.
319         
320         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
321         to Internals, so it's shared by DRT and WTR.
322         
323         We no longer need the WK2 C SPI glue.
324
325         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
326         (WTR::InjectedBundlePage::prepare):
327
328 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
329
330         webkitpy: Including skipped tests in the final count
331         https://bugs.webkit.org/show_bug.cgi?id=197298
332         <rdar://problem/49705424>
333
334         Reviewed by Lucas Forschler.
335
336         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
337         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
338
339 2019-04-25  Timothy Hatcher  <timothy@apple.com>
340
341         Disable date and time inputs on iOSMac.
342         https://bugs.webkit.org/show_bug.cgi?id=197287
343         rdar://problem/46794376
344
345         Reviewed by Wenson Hsieh.
346
347         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
348
349 2019-04-25  Alex Christensen  <achristensen@webkit.org>
350
351         Fix test-webkitpy after r244653
352         https://bugs.webkit.org/show_bug.cgi?id=197131
353
354         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
355         Also use C++17.
356
357 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
358
359         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
360         https://bugs.webkit.org/show_bug.cgi?id=196991
361         <rdar://problem/45507423>
362
363         Reviewed by Alex Christensen.
364
365         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
366         (-[NavigationTestDelegate init]):
367         (-[NavigationTestDelegate waitForDidFinishNavigation]):
368         (-[NavigationTestDelegate webView:didFinishNavigation:]):
369         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
370         (TestWebKitAPI::TEST):
371         (TEST): Deleted.
372
373 2019-04-25  Alex Christensen  <achristensen@webkit.org>
374
375         Revert some code accidentally committed with r244653
376         https://bugs.webkit.org/show_bug.cgi?id=197131
377
378         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
379         (TestWebKitAPI::TEST):
380
381 2019-04-25  Alex Christensen  <achristensen@webkit.org>
382
383         Start using C++17
384         https://bugs.webkit.org/show_bug.cgi?id=197131
385
386         Reviewed by Darin Adler.
387
388         * DumpRenderTree/mac/Configurations/Base.xcconfig:
389         * MiniBrowser/Configurations/Base.xcconfig:
390         * MobileMiniBrowser/Configurations/Base.xcconfig:
391         * TestWebKitAPI/Configurations/Base.xcconfig:
392         * WebKitTestRunner/Configurations/Base.xcconfig:
393
394 2019-04-25  Commit Queue  <commit-queue@webkit.org>
395
396         Unreviewed, rolling out r244627.
397         https://bugs.webkit.org/show_bug.cgi?id=197282
398
399         Causing internal build failures (Requested by ShawnRoberts on
400         #webkit).
401
402         Reverted changeset:
403
404         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
405         https://bugs.webkit.org/show_bug.cgi?id=197171
406         https://trac.webkit.org/changeset/244627
407
408 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
409
410         [GTK] Hardcoded text color in input fields
411         https://bugs.webkit.org/show_bug.cgi?id=126907
412
413         Reviewed by Michael Catanzaro.
414
415         Add dark-mode command line option to MiniBrowser.
416
417         * MiniBrowser/gtk/main.c:
418         (main):
419
420 2019-04-24  Zalan Bujtas  <zalan@apple.com>
421
422         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
423         https://bugs.webkit.org/show_bug.cgi?id=196948
424         <rdar://problem/49927131>
425
426         Reviewed by Tim Horton.
427
428         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
429         (TEST):
430         The expected order of incoming events is
431         1. didInvalidateIntrinsicContentSize
432         2. didFirstLayout
433         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
434         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
435         (and remember, all we care about is ordering).
436
437 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
438
439         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
440         https://bugs.webkit.org/show_bug.cgi?id=197171
441         <rdar://problem/47454979>
442
443         Reviewed by Youenn Fablet.
444
445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
446         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
447         (TestWebKitAPI::TEST):
448
449 2019-04-24  Brady Eidson  <beidson@apple.com>
450
451         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
452         https://bugs.webkit.org/show_bug.cgi?id=191362
453
454         Reviewed by Alex Christensen.
455
456         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
457           from an XHR to a custom protocol.
458
459 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
460
461         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
462         https://bugs.webkit.org/show_bug.cgi?id=197273
463
464         Reviewed by Dean Jackson.
465
466         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
467         so that WebCoreTestSupport::resetInternalsObject() is always run.
468
469         * DumpRenderTree/mac/DumpRenderTree.mm:
470         (resetWebViewToConsistentStateBeforeTesting):
471         (runTest):
472
473 2019-04-24  John Wilander  <wilander@apple.com>
474
475         Age out unconverted Ad Click Attributions after one week.
476         https://bugs.webkit.org/show_bug.cgi?id=197238
477         <rdar://problem/50177349>
478
479         Reviewed by Chris Dumez.
480
481         This patch adds infrastructure to allow tests to expire all unconverted
482         attributions early.
483
484         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
485         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
486         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
487         * WebKitTestRunner/InjectedBundle/TestRunner.h:
488         * WebKitTestRunner/TestController.cpp:
489         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
490         * WebKitTestRunner/TestController.h:
491         * WebKitTestRunner/TestInvocation.cpp:
492         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
493
494 2019-04-24  Chris Dumez  <cdumez@apple.com>
495
496         Fix flaky crashes in a couple of PSON API tests
497         https://bugs.webkit.org/show_bug.cgi?id=197239
498
499         Reviewed by Tim Horton.
500
501         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
502
503         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
504
505 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
506
507         Make it possible to control the renderTreeAsText output by setting options on testRunner
508         https://bugs.webkit.org/show_bug.cgi?id=197133
509
510         Reviewed by Sam Weinig.
511
512         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
513         that make sense in testing (those that don't dump unstable data like addresses), and plumb
514         these flags through the various framework layers.
515
516         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
517
518         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
519         and hand-code DumpRenderTree bindings.
520
521         Some cleanup of the TestRunners, using member initializers.
522
523         * DumpRenderTree/TestRunner.cpp:
524         (TestRunner::TestRunner):
525         (setRenderTreeDumpOptionsCallback):
526         (TestRunner::staticFunctions):
527         (TestRunner::setRenderTreeDumpOptions):
528         * DumpRenderTree/TestRunner.h:
529         (TestRunner::renderTreeDumpOptions const):
530         * DumpRenderTree/mac/DumpRenderTree.mm:
531         (dump):
532         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
533         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
534         (WTR::InjectedBundlePage::dump):
535         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
536         (WTR::TestRunner::TestRunner):
537         (WTR::TestRunner::setRenderTreeDumpOptions):
538         * WebKitTestRunner/InjectedBundle/TestRunner.h:
539         (WTR::TestRunner::renderTreeDumpOptions const):
540
541 2019-04-24  Alex Christensen  <achristensen@webkit.org>
542
543         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
544         https://bugs.webkit.org/show_bug.cgi?id=197078
545         <rdar://problem/49564348>
546
547         Reviewed by Geoff Garen.
548
549         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
550         (TEST_F):
551         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
552         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
553         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
554
555 2019-04-24  Alex Christensen  <achristensen@webkit.org>
556
557         Add unit test for r239322
558         https://bugs.webkit.org/show_bug.cgi?id=197236
559
560         Reviewed by Chris Dumez.
561
562         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
563         May as well add the test infrastructure which was needed before and will be needed in the future.
564
565         * TestWebKitAPI/TCPServer.cpp:
566         (TestWebKitAPI::TCPServer::TCPServer):
567         * TestWebKitAPI/TCPServer.h:
568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
569         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
570         (TestWebKitAPI::TEST):
571         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
572         (TestWebKitAPI::downloadAtRate):
573         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
574         (TEST):
575         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
576         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
577         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
578         (TestWebKitAPI::TEST):
579         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
580         (TEST):
581
582 2019-04-24  Chris Dumez  <cdumez@apple.com>
583
584         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
585         https://bugs.webkit.org/show_bug.cgi?id=197214
586         <rdar://problem/49237544>
587
588         Reviewed by Alex Christensen.
589
590         Extend API test coverage.
591
592         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
593         (TEST):
594
595 2019-04-24  Philippe Normand  <pnormand@igalia.com>
596
597         [Build][GStreamer] Update to 1.16.0
598         https://bugs.webkit.org/show_bug.cgi?id=197157
599
600         Reviewed by Xabier Rodriguez-Calvar.
601
602         The upstreamed patches were removed and a new one was added for a
603         regression detected in the scaletempo GStreamer element. The GNOME
604         Flatpak was migrated to 3.32 and I switched a few modules to Meson
605         on the way, as it is the preferred build system now in GStreamer
606         1.16.
607
608         * flatpak/files/httpd-autogen.sh:
609         * flatpak/flatpakutils.py:
610         (FlatpakPackage.install):
611         (WebkitFlatpak.run_in_sandbox):
612         * flatpak/org.webkit.CommonModules.yaml:
613         * flatpak/org.webkit.WebKit.yaml:
614         * gstreamer/jhbuild.modules:
615         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
616         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
617         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
618         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
619         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
620         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
621         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
622         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
623         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
624         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
625         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
626         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
627         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
628         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
629         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
630         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
631         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
632         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
633         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
634         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
635         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
636         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
637
638 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
639
640         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
641         https://bugs.webkit.org/show_bug.cgi?id=197156
642
643         Reviewed by Michael Catanzaro.
644
645         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
646         support was added.
647
648         * MiniBrowser/gtk/BrowserTab.c:
649         (browser_tab_set_background_color): Set the passed in color as web view background color.
650         * MiniBrowser/gtk/BrowserTab.h:
651         * MiniBrowser/gtk/BrowserWindow.c:
652         (browser_window_init): Initialize backgroundColor.
653         (browser_window_append_view): Call browser_tab_set_background_color().
654         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
655         are added.
656         * MiniBrowser/gtk/main.c:
657         (main): Call browser_window_set_background_color() before creating the tabs.
658
659 2019-04-23  John Wilander  <wilander@apple.com>
660
661         Move Ad Click Attribution from internal feature to experimental feature
662         https://bugs.webkit.org/show_bug.cgi?id=197218
663         <rdar://problem/47651691>
664
665         Reviewed by Brent Fulgham.
666
667         * DumpRenderTree/TestOptions.cpp:
668         (TestOptions::TestOptions):
669
670 2019-04-23  Andy Estes  <aestes@apple.com>
671
672         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
673         https://bugs.webkit.org/show_bug.cgi?id=196749
674         <rdar://problem/35773454>
675
676         Reviewed by Daniel Bates.
677
678         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
679
680         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
681         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
682         (-[QuickLookDelegate webView:didFinishNavigation:]):
683         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
684         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
685         (runTest):
686         (runTestDecideBeforeLoading):
687         (runTestDecideAfterLoading):
688         (TEST):
689
690 2019-04-23  John Wilander  <wilander@apple.com>
691
692         Remove Ad Click Attribution data when removing website data
693         https://bugs.webkit.org/show_bug.cgi?id=197215
694         <rdar://problem/47668988>
695
696         Reviewed by Chris Dumez.
697
698         This patch adds test infrastructure to delete Ad Click Attribution data
699         through WebsiteDataStore::removeData().
700
701         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
702         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
703         (WTR::TestRunner::clearAdClickAttribution):
704         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
705         * WebKitTestRunner/InjectedBundle/TestRunner.h:
706         * WebKitTestRunner/TestController.cpp:
707         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
708         * WebKitTestRunner/TestController.h:
709         * WebKitTestRunner/TestInvocation.cpp:
710         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
711
712 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
713
714         webkitpy: Kill unresponsive worker processes
715         https://bugs.webkit.org/show_bug.cgi?id=197205
716         <rdar://problem/50104388>
717
718         Reviewed by Lucas Forschler.
719
720         * Scripts/webkitpy/common/message_pool.py:
721         (_MessagePool.__init__): Add close timeout.
722         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
723
724 2019-04-23  Alex Christensen  <achristensen@webkit.org>
725
726         Add unit tests for WKWebView.serverTrust
727         https://bugs.webkit.org/show_bug.cgi?id=197202
728
729         Reviewed by Youenn Fablet
730
731         * TestWebKitAPI/TCPServer.cpp:
732         (TestWebKitAPI::deleter<BIO>::operator()):
733         (TestWebKitAPI::deleter<SSL>::operator()):
734         (TestWebKitAPI::deleter<X509>::operator()):
735         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
736         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
737         (TestWebKitAPI::TCPServer::TCPServer):
738         (TestWebKitAPI::TCPServer::listenForConnections):
739         * TestWebKitAPI/TCPServer.h:
740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
741         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
742         (TestWebKitAPI::TEST):
743         (verifyCertificateAndPublicKey):
744         (-[ServerTrustDelegate webView:didFinishNavigation:]):
745         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
746         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
747         (TestWebKitAPI::downloadAtRate):
748         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
749         (TEST):
750         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
751         (TEST):
752
753 2019-04-23  Commit Queue  <commit-queue@webkit.org>
754
755         Unreviewed, rolling out r244556.
756         https://bugs.webkit.org/show_bug.cgi?id=197212
757
758         Causing build failures on multiple builders (Requested by
759         ShawnRoberts on #webkit).
760
761         Reverted changeset:
762
763         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
764         https://bugs.webkit.org/show_bug.cgi?id=197171
765         https://trac.webkit.org/changeset/244556
766
767 2019-04-23  Alex Christensen  <achristensen@webkit.org>
768
769         Fix iOS build.
770         https://bugs.webkit.org/show_bug.cgi?id=195537
771
772         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
773         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
774         AdoptWK constructor is private now.  Use adoptWK instead.
775
776 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
777
778         Accessibility text search and selection API enhancements.
779         https://bugs.webkit.org/show_bug.cgi?id=197095
780         <rdar://problem/48181791>
781
782         Reviewed by Chris Fleizach.
783
784         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
785
786         * DumpRenderTree/AccessibilityTextMarker.h:
787         * DumpRenderTree/AccessibilityUIElement.cpp:
788         (searchTextWithCriteriaCallback):
789         (AccessibilityUIElement::getJSClass):
790         * DumpRenderTree/AccessibilityUIElement.h:
791         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
792         (convertVectorToObjectArray):
793         (convertNSArrayToVector):
794         (searchTextParameterizedAttributeForCriteria):
795         (AccessibilityUIElement::getLinkedUIElements):
796         (AccessibilityUIElement::getDocumentLinks):
797         (AccessibilityUIElement::getChildren):
798         (AccessibilityUIElement::getChildrenWithRange):
799         (AccessibilityUIElement::rowHeaders const):
800         (AccessibilityUIElement::columnHeaders const):
801         (AccessibilityUIElement::uiElementArrayAttributeValue const):
802         (AccessibilityUIElement::searchTextWithCriteria):
803         (AccessibilityUIElement::attributesOfColumnHeaders):
804         (AccessibilityUIElement::attributesOfRowHeaders):
805         (AccessibilityUIElement::attributesOfColumns):
806         (AccessibilityUIElement::attributesOfRows):
807         (AccessibilityUIElement::attributesOfVisibleCells):
808         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
809         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
810         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
811         (WTR::convertVectorToObjectArray):
812         (WTR::convertNSArrayToVector):
813         (WTR::searchTextParameterizedAttributeForCriteria):
814         (WTR::AccessibilityUIElement::getLinkedUIElements):
815         (WTR::AccessibilityUIElement::getDocumentLinks):
816         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
817         (WTR::AccessibilityUIElement::getChildren):
818         (WTR::AccessibilityUIElement::getChildrenWithRange):
819         (WTR::AccessibilityUIElement::rowHeaders const):
820         (WTR::AccessibilityUIElement::columnHeaders const):
821         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
822         (WTR::AccessibilityUIElement::searchTextWithCriteria):
823         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
824         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
825         (WTR::AccessibilityUIElement::attributesOfColumns):
826         (WTR::AccessibilityUIElement::attributesOfRows):
827         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
828         (WTR::convertElementsToObjectArray): Deleted.
829
830 2019-04-23  Guy Lewin  <guy@lewin.co.il>
831
832         Multiple File Input Icon Set Regardless of File List
833         https://bugs.webkit.org/show_bug.cgi?id=195537
834
835         Reviewed by Alexey Proskuryakov.
836
837         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
838         display string in iOS file inputs
839
840         * DumpRenderTree/TestRunner.cpp:
841         (SetOpenPanelFilesMediaIconCallback):
842         (TestRunner::staticFunctions):
843         (TestRunner::setOpenPanelFilesMediaIcon):
844         * DumpRenderTree/TestRunner.h:
845         (TestRunner::openPanelFilesMediaIcon const):
846         * DumpRenderTree/mac/UIDelegate.mm:
847         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
848         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
849         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
850         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
851         * WebKitTestRunner/InjectedBundle/TestRunner.h:
852         * WebKitTestRunner/TestController.cpp:
853         (WTR::runOpenPanel):
854         (WTR::TestController::resetStateToConsistentValues):
855         * WebKitTestRunner/TestController.h:
856         (WTR::TestController::openPanelFileURLsMediaIcon const):
857         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
858         * WebKitTestRunner/TestInvocation.cpp:
859         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
860
861 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
862
863         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
864         https://bugs.webkit.org/show_bug.cgi?id=197171
865         <rdar://problem/47454979>
866
867         Reviewed by Youenn Fablet.
868
869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
870         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
871         (TestWebKitAPI::TEST):
872
873 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
874
875         [ews-build] Add unit tests for UnApplyPatchIfRequired
876         https://bugs.webkit.org/show_bug.cgi?id=197197
877
878         Reviewed by Lucas Forschler.
879
880         * BuildSlaveSupport/ews-build/steps_unittest.py:
881         (TestUnApplyPatchIfRequired):
882         (TestUnApplyPatchIfRequired.test_success):
883         (TestUnApplyPatchIfRequired.test_failure):
884         (TestUnApplyPatchIfRequired.test_skip):
885
886 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
887
888         [ews-build] Add unit tests for CleanWorkingDirectory
889         https://bugs.webkit.org/show_bug.cgi?id=197195
890
891         Reviewed by Lucas Forschler.
892
893         * BuildSlaveSupport/ews-build/steps_unittest.py:
894         (TestCleanWorkingDirectory):
895         (TestCleanWorkingDirectory.test_success):
896         (TestCleanWorkingDirectory.test_failure):
897
898 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
899
900         [ews-build] Use explicit imports instead of wildcard imports
901         https://bugs.webkit.org/show_bug.cgi?id=197194
902
903         Reviewed by Lucas Forschler.
904
905         * BuildSlaveSupport/ews-build/factories.py:
906         * BuildSlaveSupport/ews-build/loadConfig.py:
907         * BuildSlaveSupport/ews-build/steps_unittest.py:
908
909 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
910
911         [ews-build] Add unit tests for DownloadBuiltProduct
912         https://bugs.webkit.org/show_bug.cgi?id=197193
913
914         Reviewed by Lucas Forschler.
915
916         * BuildSlaveSupport/ews-build/steps_unittest.py:
917         (TestDownloadBuiltProduct):
918         (TestDownloadBuiltProduct.setUp):
919         (TestDownloadBuiltProduct.tearDown):
920         (TestDownloadBuiltProduct.test_success):
921         (TestDownloadBuiltProduct.test_failure):
922
923 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
924
925         [ews-app] Exception while loading status-bubble when no build step has started
926         https://bugs.webkit.org/show_bug.cgi?id=196676
927
928         Reviewed by Lucas Forschler.
929
930         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
931         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
932
933 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
934
935         [PlayStation] Support running of JSC tests on remote playstation devices
936         https://bugs.webkit.org/show_bug.cgi?id=197170
937
938         Reviewed by Ross Kirsling.
939
940         Script changes
941
942         * Scripts/run-javascriptcore-tests:
943         (runJSCStressTests): Pass arguments for playstation to
944         run-jsc-stress-tests
945         * Scripts/run-jsc-stress-tests:
946         Handle $hostOS=="playstation" for determineArchitecture, turning
947         off $isFTLPlatform and runProfiler and defaulting test writer.
948         * Scripts/webkitdirs.pm:
949         (jscPath): PlayStation WebKit executables have .elf extension
950         (executableProductDir): PlayStation builds on Windows hosts but
951         uses bin directory rather than bin64/bin32 for executable output
952         location.
953         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
954
955 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
956
957         [CMake][Win] Use target oriented design for WebKit
958         https://bugs.webkit.org/show_bug.cgi?id=197173
959
960         Reviewed by Alex Christensen.
961
962         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
963         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
964
965 2019-04-23  Chris Dumez  <cdumez@apple.com>
966
967         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
968         https://bugs.webkit.org/show_bug.cgi?id=197097
969         <rdar://problem/50048318>
970
971         Reviewed by Alex Christensen.
972
973         Add API test coverage.
974
975         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
976         (-[PSONScheme webView:startURLSchemeTask:]):
977
978 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
979
980         [ATK] Implement AtkComponentIface scroll_to methods
981         https://bugs.webkit.org/show_bug.cgi?id=196856
982
983         Reviewed by Michael Catanzaro.
984
985         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
986         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
987         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
988         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
989
990 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
991
992         [ews-build] Improve summary for UploadBuiltProduct step
993         https://bugs.webkit.org/show_bug.cgi?id=197182
994
995         Reviewed by Lucas Forschler.
996
997         * BuildSlaveSupport/ews-build/steps.py:
998         (UploadBuiltProduct): Added descriptionDone.
999         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1000         * BuildSlaveSupport/ews-build/steps_unittest.py:
1001         (TestUploadBuiltProduct.test_success): Updated unit-test.
1002         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1003
1004 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1005
1006         [ews-build] Trigger queues only after uploading the archive
1007         https://bugs.webkit.org/show_bug.cgi?id=197180
1008
1009         Reviewed by Lucas Forschler.
1010
1011         * BuildSlaveSupport/ews-build/factories.py:
1012         (Factory.__init__):
1013         (BuildFactory.__init__): Remove trigger step from factories.
1014         (BuildFactory.propertiesToPassToTriggers): Deleted.
1015         * BuildSlaveSupport/ews-build/steps.py:
1016         (ConfigureBuild.__init__): Confiure triggers property.
1017         (Trigger): Step to trigger other queues.
1018         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1019         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1020
1021 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1022
1023         Deprecate WKContextCreateWithInjectedBundlePath
1024         https://bugs.webkit.org/show_bug.cgi?id=197169
1025
1026         Reviewed by Youenn Fablet.
1027
1028         * TestWebKitAPI/PlatformUtilities.cpp:
1029         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1030         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1031
1032 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1033
1034         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1035         https://bugs.webkit.org/show_bug.cgi?id=197093
1036         <rdar://problem/49708268>
1037
1038         Reviewed by Chris Dumez.
1039
1040         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1041         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1042         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1043         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1044         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1045
1046         * TestWebKitAPI/TCPServer.cpp:
1047         (TestWebKitAPI::TCPServer::TCPServer):
1048         (TestWebKitAPI::TCPServer::~TCPServer):
1049         (TestWebKitAPI::TCPServer::socketBindListen):
1050         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1051         * TestWebKitAPI/TCPServer.h:
1052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1053         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1054         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1055         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1056         (respondWithChallengeThenOK):
1057         (TestWebKitAPI::TEST):
1058         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1059         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1060         (TEST):
1061
1062 2019-04-22  Chris Dumez  <cdumez@apple.com>
1063
1064         Delayed WebProcessLaunch may break the _relatedWebView SPI
1065         https://bugs.webkit.org/show_bug.cgi?id=197160
1066
1067         Reviewed by Alex Christensen.
1068
1069         Add API test coverage.
1070
1071         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1072
1073 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1074
1075         Use curl to download packages for webkitpy autoinstaller
1076         https://bugs.webkit.org/show_bug.cgi?id=197164
1077
1078         Reviewed by Darin Adler.
1079
1080         * Scripts/webkitpy/common/system/autoinstall.py:
1081         (AutoInstaller._download): Use curl(1) to download packages necessary for
1082         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1083         errors which are not present when using curl(1).
1084
1085 2019-04-22  Chris Dumez  <cdumez@apple.com>
1086
1087         Unreviewed, rolling out r244502.
1088
1089         Caused crashes on the bots
1090
1091         Reverted changeset:
1092
1093         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1094         https://bugs.webkit.org/show_bug.cgi?id=197160
1095         https://trac.webkit.org/changeset/244502
1096
1097 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1098
1099         Unreviewed, rolling out r244437.
1100
1101         Still breaks internal tests.
1102
1103         Reverted changeset:
1104
1105         "InjectedBundle parameters often need initialization function
1106         called before unarchiving"
1107         https://bugs.webkit.org/show_bug.cgi?id=189709
1108         https://trac.webkit.org/changeset/244437
1109
1110 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1111
1112         [ews-build] Use singular verb in failure description in case of single api test failure
1113         https://bugs.webkit.org/show_bug.cgi?id=197013
1114
1115         Reviewed by Lucas Forschler.
1116
1117         * BuildSlaveSupport/ews-build/steps.py:
1118         (AnalyzeAPITestsResults.analyzeResults):
1119
1120 2019-04-22  Chris Dumez  <cdumez@apple.com>
1121
1122         Delayed WebProcessLaunch may break the _relatedWebView SPI
1123         https://bugs.webkit.org/show_bug.cgi?id=197160
1124
1125         Reviewed by Alex Christensen.
1126
1127         Add API test coverage.
1128
1129         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1130
1131 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1132
1133         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1134         https://bugs.webkit.org/show_bug.cgi?id=194630
1135
1136         Reviewed by Michael Catanzaro.
1137
1138         Return early from getAttributeSet() is passed in accessible is nullptr.
1139
1140         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1141
1142 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1143
1144         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1145         https://bugs.webkit.org/show_bug.cgi?id=197145
1146         <rdar://problem/50078170>
1147
1148         Reviewed by Darin Adler.
1149
1150         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1151         focus, or showing the font manager.
1152
1153         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1154         (TestWebKitAPI::TEST):
1155         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1156         (TEST):
1157         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1158         (TestWebKitAPI::TEST):
1159
1160 2019-04-21  Brian Burg  <bburg@apple.com>
1161
1162         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1163         https://bugs.webkit.org/show_bug.cgi?id=197125
1164         <rdar://problem/50061468>
1165
1166         Reviewed by Darin Adler.
1167
1168         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1169         using this class rather than making our own ./wpt serve invocation.
1170
1171         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1172         (WebDriverW3CWebServer):
1173         (WebDriverW3CWebServer.document_root): Expose this to clients.
1174         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1175
1176         (WebDriverW3CWebServer.__enter__):
1177         (WebDriverW3CWebServer.__exit__):
1178         Make it possible to use the web server with a 'with' statement.
1179
1180 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1181
1182         [CMake][Win] Use target oriented design for WebKitLegacy
1183         https://bugs.webkit.org/show_bug.cgi?id=197112
1184
1185         Reviewed by Konstantin Tokarev.
1186
1187         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1188
1189         * DumpRenderTree/CMakeLists.txt:
1190         * DumpRenderTree/PlatformWin.cmake:
1191         * DumpRenderTree/win/EventSender.cpp:
1192
1193 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1194
1195         Update text for old EWS submit button
1196         https://bugs.webkit.org/show_bug.cgi?id=197140
1197
1198         Reviewed by Alexey Proskuryakov.
1199
1200         * QueueStatusServer/templates/statusbubble.html:
1201
1202 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1203
1204         [ews-app] New EWS should poll bugzilla more frequently
1205         https://bugs.webkit.org/show_bug.cgi?id=197138
1206
1207         Reviewed by Alexey Proskuryakov.
1208
1209         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1210         (FetchLoop.__init__):
1211
1212 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1213
1214         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1215         https://bugs.webkit.org/show_bug.cgi?id=197139
1216
1217         Reviewed by Alexey Proskuryakov.
1218
1219         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1220         * QueueStatusServer/templates/statusbubble.html:
1221
1222 2019-04-20  Chris Dumez  <cdumez@apple.com>
1223
1224         Unreviewed, fix iOS build with recent SDKs.
1225
1226         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1227
1228 2019-04-19  Keith Miller  <keith_miller@apple.com>
1229
1230         Add script to merge run_benchmark jsons
1231         https://bugs.webkit.org/show_bug.cgi?id=197107
1232
1233         Reviewed by Michael Saboff.
1234
1235         The script basically recursively decends through all json objects until it gets
1236         to an array or JSON primitive and concats or takes the first value, respectively.
1237
1238         This patch also adds +x bits to the compare-results script so it
1239         can be run directly from the command line. I had to add a new line so that svn
1240         will accept the change... yay svn!
1241
1242         * Scripts/compare-results:
1243         * Scripts/merge-result-jsons: Added.
1244         (readJSONFile):
1245         (deepAppend):
1246         (mergeJSONs):
1247         (main):
1248
1249 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1250
1251         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1252         https://bugs.webkit.org/show_bug.cgi?id=197079
1253
1254         Reviewed by Darin Adler.
1255
1256         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1257
1258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1259         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1260
1261 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1262
1263         Unreviewed, rolling out r244434.
1264         https://bugs.webkit.org/show_bug.cgi?id=197089
1265
1266         caused 1 API test failure (Requested by zalan on #webkit).
1267
1268         Reverted changeset:
1269
1270         "Regression (r244291): Broken API Test
1271         AutoLayoutRenderingProgressRelativeOrdering"
1272         https://bugs.webkit.org/show_bug.cgi?id=196948
1273         https://trac.webkit.org/changeset/244434
1274
1275 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1276
1277         Add new compatibility mode API on WKNavigation
1278         https://bugs.webkit.org/show_bug.cgi?id=197069
1279         <rdar://problem/50025800>
1280
1281         Reviewed by Tim Horton.
1282
1283         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1284
1285         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1286         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1287         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1288
1289 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1290
1291         [CMake] Make WebCore headers copies
1292         https://bugs.webkit.org/show_bug.cgi?id=182512
1293         <rdar://problem/37510435>
1294
1295         Reviewed by Alex Christensen.
1296
1297         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1298         ports.
1299
1300         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1301         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1302
1303         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1304         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1305         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1306         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1307         * TestWebKitAPI/CMakeLists.txt:
1308         * TestWebKitAPI/PlatformWin.cmake:
1309         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1310         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1311         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1312
1313 2019-04-18  Jer Noble  <jer.noble@apple.com>
1314
1315         Add support for parsing FairPlayStreaming PSSH boxes.
1316         https://bugs.webkit.org/show_bug.cgi?id=197064
1317
1318         Reviewed by Eric Carlson.
1319
1320         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1321         (TestWebKitAPI::TEST):
1322
1323 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1324
1325         InjectedBundle parameters often need initialization function called before unarchiving
1326         https://bugs.webkit.org/show_bug.cgi?id=189709
1327         <rdar://problem/44573653>
1328
1329         Reviewed by Ryosuke Niwa.
1330
1331         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1332         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1333
1334 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1335
1336         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1337         https://bugs.webkit.org/show_bug.cgi?id=196948
1338         <rdar://problem/49927131>
1339
1340         Reviewed by Tim Horton.
1341
1342         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1343         (TEST): 
1344         The expected order of incoming events is
1345         1. didInvalidateIntrinsicContentSize
1346         2. didFirstLayout
1347         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1348         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1349         (and remember, all we care about is ordering).
1350
1351 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1352
1353         Unreviewed, rolling out r244299.
1354
1355         Breaks internal tests.
1356
1357         Reverted changeset:
1358
1359         "InjectedBundle parameters often need initialization function
1360         called before unarchiving"
1361         https://bugs.webkit.org/show_bug.cgi?id=189709
1362         https://trac.webkit.org/changeset/244299
1363
1364 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1365
1366         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1367         https://bugs.webkit.org/show_bug.cgi?id=197053
1368
1369         Reviewed by Saam Barati.
1370
1371         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1372         (TestWebKitAPI::TEST):
1373
1374 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1375
1376         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1377         https://bugs.webkit.org/show_bug.cgi?id=197028
1378         <rdar://problem/49985290>
1379
1380         Reviewed by Wenson Hsieh.
1381
1382         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1383         (TEST):
1384         Liberal application of waitForNextPresentationUpdate works around a race
1385         where if the page rapidly changes its viewport arguments (or an API client
1386         rapidly changes its viewport arguments), we'd get stuck thinking that the
1387         user had intentionally zoomed the page, and stop resetting the initial scale.
1388         This deserves a separate bug, but no need to keep the test failing while
1389         we think about it.
1390
1391 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1392
1393         REGRESSION (r241988): Switching tabs is slow
1394         https://bugs.webkit.org/show_bug.cgi?id=197037
1395         <rdar://problem/49951473>
1396
1397         Reviewed by Simon Fraser.
1398
1399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1400         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1401         (TEST):
1402         * TestWebKitAPI/cocoa/TestWKWebView.h:
1403         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1404         (-[TestWKWebView addToTestWindow]):
1405         Add a test that hangs without this fix.
1406
1407 2019-04-17  Truitt Savell  <tsavell@apple.com>
1408
1409         Unreviewed, rolling out r244400.
1410
1411         Caused testing to exit early with assertionon Debug WK2
1412
1413         Reverted changeset:
1414
1415         "UI↔Web deadlock when printing with a JavaScript alert
1416         visible"
1417         https://bugs.webkit.org/show_bug.cgi?id=196839
1418         https://trac.webkit.org/changeset/244400
1419
1420 2019-04-17  Brady Eidson  <beidson@apple.com>
1421
1422         Link clicks in PDFs shouldn't send referrer headers.
1423         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1424
1425         Reviewed by Tim Horton.
1426
1427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1428         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1429         (putPDFBytesCallback):
1430         (emptyReleaseInfoCallback):
1431         (createPDFWithLinkToURL):
1432         (TEST):
1433
1434 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1435
1436         UI↔Web deadlock when printing with a JavaScript alert visible
1437         https://bugs.webkit.org/show_bug.cgi?id=196839
1438         <rdar://problem/49157642>
1439
1440         Reviewed by Andy Estes.
1441
1442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1443         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1444         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1445         (TEST):
1446
1447 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1448
1449         WKRetainPtr's adoption constructor should be private
1450         https://bugs.webkit.org/show_bug.cgi?id=197019
1451
1452         Reviewed by Tim Horton.
1453
1454         * DumpRenderTree/mac/DumpRenderTree.mm:
1455         (dumpFramesAsText):
1456         * TestWebKitAPI/InjectedBundleController.cpp:
1457         (TestWebKitAPI::InjectedBundleController::initialize):
1458         * TestWebKitAPI/PlatformUtilities.cpp:
1459         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1460         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1461         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1462         (TestWebKitAPI::Util::toWK):
1463         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1464         (TestWebKitAPI::TEST):
1465         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1466         (TestWebKitAPI::TEST):
1467         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1468         (TestWebKitAPI::TEST):
1469         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1470         (TestWebKitAPI::TEST):
1471         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1472         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1473         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1474         (TestWebKitAPI::TEST):
1475         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1476         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1477         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1478         (TestWebKitAPI::TEST):
1479         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1480         (TestWebKitAPI::TEST):
1481         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1482         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1483         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1484         (TestWebKitAPI::TEST):
1485         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1486         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1487         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1488         (TestWebKitAPI::TEST):
1489         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1490         (TestWebKitAPI::TEST):
1491         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1492         (TestWebKitAPI::TEST):
1493         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1494         (TestWebKitAPI::TEST):
1495         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1496         (TestWebKitAPI::TEST):
1497         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1498         (TestWebKitAPI::TEST):
1499         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1500         (TestWebKitAPI::TEST):
1501         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1502         (TestWebKitAPI::TEST):
1503         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1504         (TestWebKitAPI::TEST):
1505         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1506         (TestWebKitAPI::TEST):
1507         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1508         (TestWebKitAPI::TEST):
1509         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1510         (TestWebKitAPI::TEST):
1511         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1512         (TestWebKitAPI::TEST):
1513         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1514         (TestWebKitAPI::TEST):
1515         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1516         (TestWebKitAPI::TEST):
1517         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1518         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1519         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1520         (TestWebKitAPI::TEST):
1521         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1522         (TestWebKitAPI::TEST):
1523         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1524         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1525         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1526         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1527         (TestWebKitAPI::TEST):
1528         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1529         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1530         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1531         (TestWebKitAPI::TEST):
1532         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1533         (TestWebKitAPI::TEST):
1534         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1535         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1536         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1537         (TestWebKitAPI::TEST):
1538         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1539         (TestWebKitAPI::loadAlternateHTMLString):
1540         (TestWebKitAPI::TEST):
1541         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1542         (TestWebKitAPI::TEST):
1543         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1544         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1545         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1546         (TestWebKitAPI::buildAndPerformTest):
1547         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1548         (TestWebKitAPI::TEST):
1549         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1550         (TestWebKitAPI::TEST):
1551         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1552         (TestWebKitAPI::TEST):
1553         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1554         (TestWebKitAPI::TEST):
1555         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1556         (TestWebKitAPI::TEST):
1557         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1558         (TestWebKitAPI::TEST):
1559         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1560         (TestWebKitAPI::TEST):
1561         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1562         (TestWebKitAPI::TEST):
1563         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1564         (TestWebKitAPI::TEST):
1565         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1566         (TestWebKitAPI::TEST):
1567         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1568         (TestWebKitAPI::TEST):
1569         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1570         (TestWebKitAPI::TEST):
1571         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1572         (TestWebKitAPI::TEST):
1573         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1574         (TestWebKitAPI::TEST):
1575         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1576         (TestWebKitAPI::TEST):
1577         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1578         (TestWebKitAPI::TEST):
1579         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1580         (TestWebKitAPI::TEST):
1581         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1582         (TestWebKitAPI::TEST):
1583         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1584         (TestWebKitAPI::TEST):
1585         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1586         (TestWebKitAPI::TEST):
1587         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1588         (TestWebKitAPI::TEST):
1589         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1590         (TestWebKitAPI::TEST):
1591         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1592         (TestWebKitAPI::TEST):
1593         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1594         (TestWebKitAPI::TEST):
1595         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1596         (TestWebKitAPI::TEST):
1597         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1598         (TestWebKitAPI::TEST):
1599         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1600         (TestWebKitAPI::TEST):
1601         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1602         (TestWebKitAPI::TEST):
1603         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1604         (TestWebKitAPI::TEST):
1605         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1606         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1607         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1608         (TestWebKitAPI::TEST):
1609         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1610         (TestWebKitAPI::TEST):
1611         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1612         (TestWebKitAPI::TEST):
1613         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1614         (TestWebKitAPI::TEST):
1615         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1616         (TestWebKitAPI::TEST):
1617         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1618         (TestWebKitAPI::TEST):
1619         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1620         (TestWebKitAPI::TEST):
1621         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1622         (TestWebKitAPI::TEST):
1623         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1624         (TestWebKitAPI::TEST):
1625         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1626         (TestWebKitAPI::TEST):
1627         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1628         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1629         (TEST):
1630         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1631         (TEST):
1632         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1633         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1634         (TEST):
1635         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1636         (TestWebKitAPI::TEST):
1637         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1638         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1639         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1640         (WTR::getMenuItemTitleCallback):
1641         (WTR::createMouseMessageBody):
1642         (WTR::EventSendingController::mouseDown):
1643         (WTR::EventSendingController::mouseUp):
1644         (WTR::EventSendingController::mouseMoveTo):
1645         (WTR::EventSendingController::mouseForceClick):
1646         (WTR::EventSendingController::startAndCancelMouseForceClick):
1647         (WTR::EventSendingController::mouseForceDown):
1648         (WTR::EventSendingController::mouseForceUp):
1649         (WTR::EventSendingController::mouseForceChanged):
1650         (WTR::EventSendingController::leapForward):
1651         (WTR::EventSendingController::scheduleAsynchronousClick):
1652         (WTR::createKeyDownMessageBody):
1653         (WTR::EventSendingController::keyDown):
1654         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1655         (WTR::EventSendingController::mouseScrollBy):
1656         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1657         (WTR::EventSendingController::continuousMouseScrollBy):
1658         (WTR::EventSendingController::addTouchPoint):
1659         (WTR::EventSendingController::updateTouchPoint):
1660         (WTR::EventSendingController::setTouchModifier):
1661         (WTR::EventSendingController::setTouchPointRadius):
1662         (WTR::EventSendingController::touchStart):
1663         (WTR::EventSendingController::touchMove):
1664         (WTR::EventSendingController::touchEnd):
1665         (WTR::EventSendingController::touchCancel):
1666         (WTR::EventSendingController::clearTouchPoints):
1667         (WTR::EventSendingController::releaseTouchPoint):
1668         (WTR::EventSendingController::cancelTouchPoint):
1669         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1670         (WTR::InjectedBundle::didCreatePage):
1671         (WTR::InjectedBundle::didReceiveMessage):
1672         (WTR::InjectedBundle::didReceiveMessageToPage):
1673         (WTR::InjectedBundle::booleanForKey):
1674         (WTR::InjectedBundle::done):
1675         (WTR::InjectedBundle::dumpToStdErr):
1676         (WTR::InjectedBundle::outputText):
1677         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1678         (WTR::InjectedBundle::postAddChromeInputField):
1679         (WTR::InjectedBundle::postRemoveChromeInputField):
1680         (WTR::InjectedBundle::postFocusWebView):
1681         (WTR::InjectedBundle::postSetBackingScaleFactor):
1682         (WTR::InjectedBundle::postSetWindowIsKey):
1683         (WTR::InjectedBundle::postSetViewSize):
1684         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1685         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1686         (WTR::InjectedBundle::setGeolocationPermission):
1687         (WTR::InjectedBundle::setMockGeolocationPosition):
1688         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1689         (WTR::InjectedBundle::isGeolocationProviderActive const):
1690         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1691         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1692         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1693         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1694         (WTR::InjectedBundle::setCustomPolicyDelegate):
1695         (WTR::InjectedBundle::setHidden):
1696         (WTR::InjectedBundle::setCacheModel):
1697         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1698         (WTR::InjectedBundle::processWorkQueue):
1699         (WTR::InjectedBundle::queueBackNavigation):
1700         (WTR::InjectedBundle::queueForwardNavigation):
1701         (WTR::InjectedBundle::queueLoad):
1702         (WTR::InjectedBundle::queueLoadHTMLString):
1703         (WTR::InjectedBundle::queueReload):
1704         (WTR::InjectedBundle::queueLoadingScript):
1705         (WTR::InjectedBundle::queueNonLoadingScript):
1706         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1707         (WTR::frameToStr):
1708         (WTR::InjectedBundlePage::InjectedBundlePage):
1709         (WTR::dumpFrameDescriptionSuitableForTestResult):
1710         (WTR::dumpFrameScrollPosition):
1711         (WTR::dumpDescendantFrameScrollPositions):
1712         (WTR::dumpFrameText):
1713         (WTR::dumpDescendantFramesText):
1714         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1715         (WTR::TestRunner::shouldDumpPixels const):
1716         (WTR::TestRunner::setDumpPixels):
1717         (WTR::TestRunner::whatToDump const):
1718         (WTR::TestRunner::setWhatToDump):
1719         (WTR::TestRunner::setWaitUntilDone):
1720         (WTR::TestRunner::shouldWaitUntilDone const):
1721         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1722         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1723         (WTR::TestRunner::clearAllDatabases):
1724         (WTR::TestRunner::setIDBPerOriginQuota):
1725         (WTR::TestRunner::originsWithApplicationCache):
1726         (WTR::TestRunner::setCanOpenWindows):
1727         (WTR::TestRunner::setXSSAuditorEnabled):
1728         (WTR::TestRunner::setMediaDevicesEnabled):
1729         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1730         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1731         (WTR::TestRunner::setCustomUserAgent):
1732         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1733         (WTR::TestRunner::setModernMediaControlsEnabled):
1734         (WTR::TestRunner::setWebGL2Enabled):
1735         (WTR::TestRunner::setWritableStreamAPIEnabled):
1736         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1737         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1738         (WTR::TestRunner::setAllowsAnySSLCertificate):
1739         (WTR::TestRunner::setPluginsEnabled):
1740         (WTR::TestRunner::setValueForUser):
1741         (WTR::TestRunner::setAudioResult):
1742         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1743         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1744         (WTR::TestRunner::setAlwaysAcceptCookies):
1745         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1746         (WTR::TestRunner::isDoingMediaCapture const):
1747         (WTR::TestRunner::queueLoad):
1748         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1749         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1750         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1751         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1752         (WTR::TestRunner::setAuthenticationUsername):
1753         (WTR::TestRunner::setAuthenticationPassword):
1754         (WTR::TestRunner::secureEventInputIsEnabled const):
1755         (WTR::TestRunner::setBlockAllPlugins):
1756         (WTR::TestRunner::setPluginSupportedMode):
1757         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1758         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1759         (WTR::TestRunner::setNavigationGesturesEnabled):
1760         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1761         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1762         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1763         (WTR::TestRunner::terminateNetworkProcess):
1764         (WTR::TestRunner::terminateServiceWorkerProcess):
1765         (WTR::TestRunner::runUIScript):
1766         (WTR::TestRunner::setStatisticsDebugMode):
1767         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1768         (WTR::TestRunner::setStatisticsLastSeen):
1769         (WTR::TestRunner::setStatisticsPrevalentResource):
1770         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1771         (WTR::TestRunner::dumpResourceLoadStatistics):
1772         (WTR::TestRunner::isStatisticsPrevalentResource):
1773         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1774         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1775         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1776         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1777         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1778         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1779         (WTR::TestRunner::setStatisticsGrandfathered):
1780         (WTR::TestRunner::isStatisticsGrandfathered):
1781         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1782         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1783         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1784         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1785         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1786         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1787         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1788         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1789         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1790         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1791         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1792         (WTR::TestRunner::statisticsSubmitTelemetry):
1793         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1794         (WTR::TestRunner::setStatisticsIsRunningTest):
1795         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1796         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1797         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1798         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1799         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1800         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1801         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1802         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1803         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1804         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1805         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1806         (WTR::TestRunner::statisticsResetToConsistentState):
1807         (WTR::TestRunner::setStorageAccessAPIEnabled):
1808         (WTR::TestRunner::getAllStorageAccessEntries):
1809         (WTR::TestRunner::addMockMediaDevice):
1810         (WTR::TestRunner::clearMockMediaDevices):
1811         (WTR::TestRunner::removeMockMediaDevice):
1812         (WTR::TestRunner::resetMockMediaDevices):
1813         (WTR::TestRunner::connectMockGamepad):
1814         (WTR::TestRunner::disconnectMockGamepad):
1815         (WTR::TestRunner::setMockGamepadDetails):
1816         (WTR::TestRunner::setMockGamepadAxisValue):
1817         (WTR::TestRunner::setMockGamepadButtonValue):
1818         (WTR::TestRunner::removeAllSessionCredentials):
1819         (WTR::TestRunner::clearDOMCache):
1820         (WTR::TestRunner::clearDOMCaches):
1821         (WTR::TestRunner::hasDOMCache):
1822         (WTR::TestRunner::domCacheSize):
1823         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1824         (WTR::TestRunner::getApplicationManifestThen):
1825         (WTR::TestRunner::injectUserScript):
1826         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1827         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1828         (WTR::TestRunner::addTestKeyToKeychain):
1829         (WTR::TestRunner::cleanUpKeychain):
1830         (WTR::TestRunner::keyExistsInKeychain):
1831         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1832         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1833         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1834         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1835         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1836         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1837         * WebKitTestRunner/TestController.cpp:
1838         (WTR::TestController::initialize):
1839         (WTR::parseStringTestHeaderValueAsRelativePath):
1840         (WTR::updateTestOptionsFromTestHeader):
1841         (WTR::TestController::runTest):
1842         (WTR::TestController::didReceiveLiveDocumentsList):
1843         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1844         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1845         (WTR::TestController::didFinishNavigation):
1846         (WTR::TestController::didReceiveAuthenticationChallenge):
1847         * WebKitTestRunner/TestInvocation.cpp:
1848         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1849         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1850         (WTR::TestInvocation::uiScriptDidComplete):
1851         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1852         * WebKitTestRunner/WebNotificationProvider.cpp:
1853         (WTR::WebNotificationProvider::closeWebNotification):
1854         * WebKitTestRunner/WorkQueueManager.cpp:
1855         (WTR::ScriptItem::ScriptItem):
1856         (WTR::WorkQueueManager::queueLoad):
1857         (WTR::WorkQueueManager::queueLoadHTMLString):
1858
1859 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1860
1861         Add a comment to make my test from r244139 less mysterious.
1862         https://bugs.webkit.org/show_bug.cgi?id=196744
1863
1864         As suggested by Darin Adler.
1865
1866         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1867         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1868
1869 2019-04-17  Chris Dumez  <cdumez@apple.com>
1870
1871         Remember device orientation permission for the duration of the browsing session
1872         https://bugs.webkit.org/show_bug.cgi?id=196992
1873         <rdar://problem/49946067>
1874
1875         Reviewed by Alex Christensen.
1876
1877         Add API test coverage.
1878
1879         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1880         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1881         (TEST):
1882
1883 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1884
1885         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1886         https://bugs.webkit.org/show_bug.cgi?id=196675
1887
1888         Reviewed by Lucas Forschler.
1889
1890         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1891         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1892
1893 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1894
1895         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1896         https://bugs.webkit.org/show_bug.cgi?id=196919
1897         <rdar://problem/41630459>
1898
1899         Reviewed by Tim Horton.
1900
1901         Add iOS support for several new testing hooks. See below for more detail.
1902
1903         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1904         (WTR::UIScriptController::isDismissingMenu const):
1905
1906         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1907         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1908         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1909
1910         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1911         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1912         (WTR::UIScriptController::isDismissingMenu const):
1913         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1914         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1915         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1916         (WTR::InjectedBundle::didReceiveMessageToPage):
1917         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1918         (WTR::TestRunner::setAllowedMenuActions):
1919
1920         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
1921         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
1922         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
1923         against the name of the custom action.
1924
1925         (WTR::TestRunner::installCustomMenuAction):
1926
1927         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
1928         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
1929         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
1930         triggered.
1931
1932         (WTR::TestRunner::performCustomMenuAction):
1933
1934         Invoked when the custom menu action is triggered.
1935
1936         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1937         * WebKitTestRunner/TestController.cpp:
1938         (WTR::TestController::installCustomMenuAction):
1939         (WTR::TestController::setAllowedMenuActions):
1940         * WebKitTestRunner/TestController.h:
1941         * WebKitTestRunner/TestInvocation.cpp:
1942         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1943         (WTR::TestInvocation::performCustomMenuAction):
1944
1945         Add plumbing to call back into the injected bundle when performing the custom action.
1946
1947         * WebKitTestRunner/TestInvocation.h:
1948         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1949         (WTR::TestController::installCustomMenuAction):
1950         (WTR::TestController::setAllowedMenuActions):
1951         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1952         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1953         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1954         (-[TestRunnerWKWebView becomeFirstResponder]):
1955         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
1956
1957         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
1958         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
1959         in the Mail app on iOS.
1960
1961         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
1962         (-[TestRunnerWKWebView setAllowedMenuActions:]):
1963         (-[TestRunnerWKWebView resetCustomMenuAction]):
1964         (-[TestRunnerWKWebView performCustomAction:]):
1965         (-[TestRunnerWKWebView canPerformAction:withSender:]):
1966         (-[TestRunnerWKWebView _willHideMenu]):
1967         (-[TestRunnerWKWebView _didHideMenu]):
1968         * WebKitTestRunner/ios/TestControllerIOS.mm:
1969         (WTR::TestController::platformResetStateToConsistentValues):
1970
1971         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
1972         if specified.
1973
1974         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1975         (WTR::UIScriptController::isDismissingMenu const):
1976
1977 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
1978
1979         Allow sharing from imageSheet on an image document
1980         https://bugs.webkit.org/show_bug.cgi?id=196891
1981         <rdar://problem/25377386>
1982
1983         Reviewed by Tim Horton.
1984
1985         Test to make sure that the correct imageURL is extracted from an image element.
1986
1987         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1988         (TestWebKitAPI::TEST):
1989
1990 2019-04-16  Alex Christensen  <achristensen@webkit.org>
1991
1992         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
1993         https://bugs.webkit.org/show_bug.cgi?id=196995
1994
1995         Reviewed by Brady Eidson.
1996
1997         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1998         (TEST):
1999
2000 2019-04-16  Chris Dumez  <cdumez@apple.com>
2001
2002         URL set by document.open() is not communicated to the UIProcess
2003         https://bugs.webkit.org/show_bug.cgi?id=196941
2004         <rdar://problem/49237544>
2005
2006         Reviewed by Geoff Garen.
2007
2008         Add API test coverage.
2009
2010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2011         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2012         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2013         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2014         (TEST):
2015
2016 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2017
2018         Unreviewed, rolling out r244321.
2019         https://bugs.webkit.org/show_bug.cgi?id=196968
2020
2021         Causing all WK2 Debug builds to exit early after Assertion
2022         failures. (Requested by ShawnRoberts on #webkit).
2023
2024         Reverted changeset:
2025
2026         "URL set by document.open() is not communicated to the
2027         UIProcess"
2028         https://bugs.webkit.org/show_bug.cgi?id=196941
2029         https://trac.webkit.org/changeset/244321
2030
2031 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2032
2033         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2034         https://bugs.webkit.org/show_bug.cgi?id=196948
2035
2036         Reviewed by Zalan Bujtas.
2037
2038         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2039         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2040
2041 2019-04-15  Chris Dumez  <cdumez@apple.com>
2042
2043         URL set by document.open() is not communicated to the UIProcess
2044         https://bugs.webkit.org/show_bug.cgi?id=196941
2045         <rdar://problem/49237544>
2046
2047         Reviewed by Geoffrey Garen.
2048
2049         Add API test coverage.
2050
2051         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2052         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2053         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2054         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2055         (TEST):
2056
2057 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2058
2059         Using Tools/Scripts/clean-webkit should not install requests
2060         https://bugs.webkit.org/show_bug.cgi?id=196940
2061
2062         Reviewed by Lucas Forschler.
2063
2064         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2065         existing, depending on the path autoinstalled is run through.
2066         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2067         needed.
2068         (Port.configuration_for_upload):
2069         (Port.commits_for_upload):
2070
2071 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2072
2073         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2074         https://bugs.webkit.org/show_bug.cgi?id=196773
2075
2076         Reviewed by Jer Noble.
2077
2078         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2079         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2080         (TEST):
2081
2082 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2083
2084         ews-build should clearly indicate flaky test failures
2085         https://bugs.webkit.org/show_bug.cgi?id=196947
2086
2087         Reviewed by Lucas Forschler.
2088
2089         * BuildSlaveSupport/ews-build/steps.py:
2090         (AnalyzeAPITestsResults.analyzeResults):
2091
2092 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2093
2094         InjectedBundle parameters often need initialization function called before unarchiving
2095         https://bugs.webkit.org/show_bug.cgi?id=189709
2096         <rdar://problem/44573653>
2097
2098         Reviewed by Ryosuke Niwa.
2099
2100         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2101         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2102
2103 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2104
2105         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2106         https://bugs.webkit.org/show_bug.cgi?id=196681
2107
2108         Reviewed by Darin Adler.
2109
2110         Added tests.
2111
2112         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2113         (WTF_HashSet.RemoveIf):
2114         (WTF_HashSet.RemoveIfShrinkToBestSize):
2115
2116 2019-04-15  John Wilander  <wilander@apple.com>
2117
2118         Send delayed Ad Click Attribution conversion requests to the click source
2119         https://bugs.webkit.org/show_bug.cgi?id=196838
2120         <rdar://problem/47650157>
2121
2122         Reviewed by Chris Dumez and Youenn Fablet.
2123
2124         This patch adds test infrastructure to override the default behavior in
2125         WebKit::NetworkAdClickAttribution.
2126
2127         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2128         (TestWebKitAPI::TEST):
2129         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2130         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2131         (WTR::TestRunner::dumpAdClickAttribution):
2132         (WTR::TestRunner::clearAdClickAttribution):
2133         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2134         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2135         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2136         * WebKitTestRunner/TestController.cpp:
2137         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2138         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2139         * WebKitTestRunner/TestController.h:
2140         * WebKitTestRunner/TestInvocation.cpp:
2141         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2142
2143 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2144
2145         [ews-app] status-bubble should display position in queue
2146         https://bugs.webkit.org/show_bug.cgi?id=196607
2147
2148         Reviewed by Lucas Forschler.
2149
2150         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2151         (StatusBubble._build_bubble):
2152         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2153
2154 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2155
2156         [ews-build] Do not run clean build by default on EWS builders
2157         https://bugs.webkit.org/show_bug.cgi?id=196897
2158
2159         Reviewed by Lucas Forschler.
2160
2161         * BuildSlaveSupport/ews-build/steps.py:
2162         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2163         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2164         untracked directories like WebKitBuild).
2165         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2166         untracked files/directories (like WebKitBuild).
2167
2168 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2169
2170         TestRunner::notifyDone() should be safely reentrant
2171         https://bugs.webkit.org/show_bug.cgi?id=196898
2172
2173         Reviewed by Darin Adler.
2174
2175         It is currently possible that TestRunner::notifyDone() will call itself, since
2176         notifyDone() will force a repaint, which can start executing JavaScript, which
2177         may call notifyDone() again. This can lead to test failures and flakiness.
2178         Fix this by setting the m_waitToDump flag before calling the dump() method.
2179
2180         * DumpRenderTree/mac/TestRunnerMac.mm:
2181         (TestRunner::notifyDone):
2182         (TestRunner::forceImmediateCompletion):
2183         * DumpRenderTree/win/TestRunnerWin.cpp:
2184         (TestRunner::notifyDone):
2185         (TestRunner::forceImmediateCompletion):
2186
2187 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2188
2189         [GTK][WPE] Add enable-media websetting
2190         https://bugs.webkit.org/show_bug.cgi?id=196863
2191
2192         Reviewed by Michael Catanzaro.
2193
2194         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2195         (testWebKitSettings): Add test for the enable-media web-setting.
2196
2197 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2198
2199         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2200         https://bugs.webkit.org/show_bug.cgi?id=196905
2201         <rdar://problem/49886096>
2202
2203         Reviewed by Tim Horton.
2204
2205         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2206         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2207         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2208         delay timer, we end up with this sequence of events in the problematic (failure) case:
2209
2210         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2211             ...IPC from UI to web process...
2212         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2213             ...IPC from web to UI process...
2214         (c) [UI]    Invoke completion handler for script #1
2215         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2216             ...IPC from UI to web process...
2217         (e) [Web]   Evaluate script #2 in the web process
2218         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2219
2220         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2221         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2222         #2 is run in step (e).
2223
2224         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2225         the UI process by waiting on a script message posted by the web process, after attachment updates are
2226         dispatched.
2227
2228         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2229         (TestWebKitAPI::TEST):
2230
2231 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2232
2233         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2234         https://bugs.webkit.org/show_bug.cgi?id=196909
2235
2236         Reviewed by Wenson Hsieh.
2237
2238         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2239         (TestWebKitAPI::TEST):
2240
2241 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2242
2243         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2244         https://bugs.webkit.org/show_bug.cgi?id=196880
2245
2246         Reviewed by Yusuke Suzuki.
2247
2248         Add a new function for bytecode cache tests that does not forceDiskCache
2249         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2250         test added in this patch, since the code is invalid and therefore won't be
2251         cached. It should also be useful for tests that evaluate dynamically
2252         generated code.
2253
2254         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2255         * Scripts/run-jsc-stress-tests:
2256
2257 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2258
2259         Update AudioSession route sharing policy
2260         https://bugs.webkit.org/show_bug.cgi?id=196776
2261         <rdar://problem/46501611>
2262
2263         Reviewed by Jer Noble.
2264
2265         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2266         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2267         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2268         (TestWebKitAPI::TEST):
2269
2270 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2271
2272         [iOS] Software keyboard is shown too frequently on some websites
2273         https://bugs.webkit.org/show_bug.cgi?id=195856
2274         <rdar://problem/49191395>
2275
2276         Reviewed by Darin Adler.
2277
2278         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2279
2280         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2281         (WTR::UIScriptController::setHardwareKeyboardAttached):
2282         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2283         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2284         (WTR::UIScriptController::setHardwareKeyboardAttached):
2285         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2286         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2287
2288         Additionally link against GraphicsServices in WebKitTestRunner.
2289
2290         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2291         (WTR::TestController::platformResetStateToConsistentValues):
2292         (WTR::UIScriptController::setHardwareKeyboardAttached):
2293
2294 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2295
2296         [GTK][WPE] Fix pacman install-dependencies packages
2297         https://bugs.webkit.org/show_bug.cgi?id=196817
2298
2299         Reviewed by Žan Doberšek.
2300         
2301         python3-setuptools is called python-setuptools
2302         ruby-highline is only available on AUR
2303         libv4l-devel is incorporated in v4l-utils
2304
2305         * gtk/install-dependencies:
2306         * wpe/install-dependencies:
2307
2308 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2309
2310         [GTK] REGRESSION(r243860): Many tests failing
2311         https://bugs.webkit.org/show_bug.cgi?id=196791
2312
2313         Reviewed by Joanmarie Diggs.
2314
2315         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2316         multiple documents and check that accessibility hierarchy is updated after a navigation.
2317
2318         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2319         (loadChangedCallback):
2320         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2321         (AccessibilityTest::AccessibilityTest):
2322         (AccessibilityTest::~AccessibilityTest):
2323         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2324         (AccessibilityTest::findTestServerApplication):
2325         (AccessibilityTest::findDocumentWeb):
2326         (AccessibilityTest::findRootObject):
2327         (AccessibilityTest::waitUntilChildrenRemoved):
2328         (AccessibilityTest::ensureProxy):
2329         (testAtspiBasicHierarchy):
2330         (beforeAll):
2331         (afterAll):
2332
2333 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2334
2335         [ews-build] Handle bug titles with unicode characters
2336         https://bugs.webkit.org/show_bug.cgi?id=196802
2337
2338         Reviewed by Dewei Zhu.
2339
2340         * BuildSlaveSupport/ews-build/steps.py:
2341         (ValidatePatch._is_bug_closed):
2342
2343 2019-04-11  Michael Saboff  <msaboff@apple.com>
2344
2345         Improve the Inline Cache Stats code
2346         https://bugs.webkit.org/show_bug.cgi?id=196836
2347
2348         Reviewed by Saam Barati.
2349
2350         Added a new script to consolidate and arrange the output of --useICStats option.
2351
2352         This script merges the output from every group into one large table and sorts it from most common to
2353         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2354         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2355         Put together, this is useful to see what property accesses are not getting cached.
2356
2357         * Scripts/ic-stats.py: Added.
2358         (ICStats):
2359         (ICStats.__init__):
2360         (ICStats.parse):
2361         (ICStats.dumpStats):
2362         (usage):
2363
2364 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2365
2366         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2367         https://bugs.webkit.org/show_bug.cgi?id=196809
2368         <rdar://49800762>
2369
2370         Reviewed by Brady Eidson.
2371
2372         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2373         (TEST):
2374
2375 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2376
2377         requestAnimationFrame should execute before the next frame
2378         https://bugs.webkit.org/show_bug.cgi?id=177484
2379
2380         Reviewed by Simon Fraser.
2381
2382         Add trace points for the page RenderingUpdate.
2383
2384         * Tracing/SystemTracePoints.plist:
2385
2386 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2387
2388         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2389         https://bugs.webkit.org/show_bug.cgi?id=196760
2390
2391         Reviewed by Don Olmstead.
2392
2393         vswhere.exe has been bundled since Visual Studio 2017 version
2394         15.2. We shouldn't download vswhere.exe.
2395
2396         * Scripts/build-jsc: Do not call update-vswhere.py.
2397         * Scripts/build-webkit: Ditto.
2398         * Scripts/update-vswhere.py: Removed.
2399         * Scripts/webkitdirs.pm:
2400         (requireModulesForVSWhere): Deleted.
2401         (pickCurrentVisualStudioInstallation): Deleted.
2402         (visualStudioInstallDirVSWhere): Return the latest installed VS
2403         installation path by using the bundled vswhere.exe.
2404         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2405         (visualStudioInstallDirFallback): Removed.
2406
2407 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2408
2409         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2410         https://bugs.webkit.org/show_bug.cgi?id=196780
2411
2412         Reviewed by Alexey Proskuryakov.
2413
2414         * BuildSlaveSupport/ews-build/steps.py:
2415         * BuildSlaveSupport/ews-build/steps_unittest.py:
2416
2417 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2418
2419         Add SPI WKNavigationResponse._downloadAttribute
2420         https://bugs.webkit.org/show_bug.cgi?id=196755
2421         <rdar://49587365>
2422
2423         Reviewed by Brady Eidson.
2424
2425         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2426         (-[NavigationResponseTestDelegate navigationResponse]):
2427         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2428         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2429         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2430         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2431         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2432         (readRequest):
2433         (writeResponse):
2434         (TEST):
2435
2436 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2437
2438         Add modern API for overriding the page's specified viewport configuration
2439         https://bugs.webkit.org/show_bug.cgi?id=167734
2440         <rdar://problem/30331795>
2441
2442         Reviewed by Simon Fraser.
2443
2444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2445         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2446
2447 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2448
2449         Add support for incremental bytecode cache updates
2450         https://bugs.webkit.org/show_bug.cgi?id=195000
2451
2452         Reviewed by Filip Pizlo.
2453
2454         Exit when the initial run to generate bytecode fails.
2455
2456         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2457
2458 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2459
2460         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2461         https://bugs.webkit.org/show_bug.cgi?id=196744
2462         <rdar://49415309>
2463
2464         Reviewed by Chris Dumez.
2465
2466         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2467         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2468
2469 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2470
2471         Add a way to opt into modern compatibility mode in layout tests
2472         https://bugs.webkit.org/show_bug.cgi?id=196770
2473         <rdar://problem/49777550>
2474
2475         Reviewed by Antoine Quint.
2476
2477         Add a new test option to enable modern compatibility mode in layout tests.
2478
2479         * WebKitTestRunner/TestController.cpp:
2480         (WTR::updateTestOptionsFromTestHeader):
2481         * WebKitTestRunner/TestController.h:
2482         * WebKitTestRunner/TestOptions.h:
2483         (WTR::TestOptions::hasSameInitializationOptions const):
2484         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2485         (WTR::TestController::platformCreateWebView):
2486         (WTR::TestController::enableModernCompatibilityMode):
2487
2488 2019-04-10  Andy Estes  <aestes@apple.com>
2489
2490         Try to fix the 32-bit watchOS build.
2491
2492         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2493         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2494
2495 2019-04-10  Antoine Quint  <graouts@apple.com>
2496
2497         Enable Pointer Events on watchOS
2498         https://bugs.webkit.org/show_bug.cgi?id=196771
2499         <rdar://problem/49040909>
2500
2501         Reviewed by Dean Jackson.
2502
2503         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2504
2505 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2506
2507         Unreviewed. Fix WPE accessibility tests after r244059.
2508
2509         We are failing to load the injected bundle due to undefined symbol
2510         AccessibilityUIElement::replaceTextInRange().
2511
2512         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2513         (WTR::AccessibilityUIElement::replaceTextInRange):
2514
2515 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2516
2517         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2518         https://bugs.webkit.org/show_bug.cgi?id=196727
2519
2520         Reviewed by Fujii Hironori.
2521
2522         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2523         (WebKitBrowserWindow::create):
2524
2525 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2526
2527         [ews-build] Add unit tests for PrintConfiguration
2528         https://bugs.webkit.org/show_bug.cgi?id=196752
2529
2530         Reviewed by Dewei Zhu.
2531
2532         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2533
2534 2019-04-09  Keith Rollin  <krollin@apple.com>
2535
2536         Unreviewed build maintenance -- update .xcfilelists.
2537
2538         * DumpRenderTree/DerivedSources-input.xcfilelist:
2539         * DumpRenderTree/DerivedSources-output.xcfilelist:
2540
2541 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2542
2543         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2544         https://bugs.webkit.org/show_bug.cgi?id=196743
2545         <rdar://problem/43897551>
2546
2547         Reviewed by Tim Horton.
2548
2549         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2550         (TEST):
2551
2552 2019-04-09  Youenn Fablet  <youenn@apple.com>
2553
2554         Close service worker database on network process suspension
2555         https://bugs.webkit.org/show_bug.cgi?id=196623
2556         <rdar://problem/48930869>
2557
2558         Reviewed by Alex Christensen.
2559
2560         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2561
2562 2019-04-09  Daniel Bates  <dabates@apple.com>
2563
2564         [iPad] Should open popover when the spacebar is pressed
2565         https://bugs.webkit.org/show_bug.cgi?id=196360
2566         <rdar://problem/49389129>
2567
2568         Reviewed by Brent Fulgham.
2569
2570         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2571
2572         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2573         (WTR::UIScriptController::isShowingPopover const): Added.
2574         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2575         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2576         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2577         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2578         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2579         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2580         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2581         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2582         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2583         (WTR::UIScriptController::isShowingPopover const): Added.
2584         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2585         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2586         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2587         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2588         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2589         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2590         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2591         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2592         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2593         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2594         (WTR::UIScriptController::isShowingPopover const): Added.
2595         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2596         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2597
2598 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2599
2600         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2601         https://bugs.webkit.org/show_bug.cgi?id=196665
2602         <rdar://45115669>
2603
2604         Reviewed by Geoff Garen.
2605
2606         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2607         (goBack):
2608         (+[SimpleLookupContext sharedLookupContext]):
2609         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2610         (TEST):
2611         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2612         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2613
2614 2019-04-09  John Wilander  <wilander@apple.com>
2615
2616         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2617         https://bugs.webkit.org/show_bug.cgi?id=196558
2618         <rdar://problem/47650245>
2619
2620         Reviewed by Youenn Fablet.
2621
2622         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2623         (TestWebKitAPI::TEST):
2624             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2625
2626 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2627
2628         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2629         https://bugs.webkit.org/show_bug.cgi?id=196720
2630
2631         Reviewed by Konstantin Tokarev.
2632
2633         * TestWebKitAPI/PlatformMac.cmake:
2634
2635 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2636
2637         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2638         https://bugs.webkit.org/show_bug.cgi?id=196694
2639         <rdar://problem/48388734>
2640
2641         Rubber-stamped by Aakash Jain.
2642
2643         * Scripts/webkitpy/port/image_diff.py:
2644         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2645         * Scripts/webkitpy/port/server_process.py:
2646         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2647         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2648         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2649         * Scripts/webkitpy/port/server_process_mock.py:
2650         (MockServerProcess.has_available_stdout):
2651         * Scripts/webkitpy/port/server_process_unittest.py:
2652         (TestServerProcess.serial_test_basic):
2653
2654 2019-04-09  Jer Noble  <jer.noble@apple.com>
2655
2656         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2657         https://bugs.webkit.org/show_bug.cgi?id=196097
2658
2659         Reviewed by Eric Carlson.
2660
2661         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2662
2663         * DumpRenderTree/mac/DumpRenderTree.mm:
2664         (resetWebPreferencesToConsistentValues):
2665         * WebKitTestRunner/TestController.cpp:
2666         (WTR::TestController::resetPreferencesToConsistentValues):
2667
2668 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2669
2670         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2671         https://bugs.webkit.org/show_bug.cgi?id=196690
2672
2673         Reviewed by Michael Catanzaro.
2674
2675         * QueueStatusServer/config/queues.py:
2676         * Scripts/webkitpy/common/config/ews.json:
2677         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2678         (test_ews_name):
2679
2680 2019-04-09  Chris Dumez  <cdumez@apple.com>
2681
2682         Loads using loadHTMLString() cause flashing when process-swapping
2683         https://bugs.webkit.org/show_bug.cgi?id=196714
2684         <rdar://problem/49637354>
2685
2686         Reviewed by Antti Koivisto.
2687
2688         Add API test coverage.
2689
2690         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2691
2692 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2693
2694         Unreviewed. Fix ATK accessibility tests after r244059.
2695
2696         We are failing to load the injected bundle due to undefined symbol
2697         AccessibilityUIElement::replaceTextInRange().
2698
2699         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2700         (WTR::AccessibilityUIElement::replaceTextInRange):
2701
2702 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2703
2704         AX: Support API: accessibilityReplaceRange:withText
2705         https://bugs.webkit.org/show_bug.cgi?id=196636
2706
2707         Unreviewed build fix for Windows port.
2708
2709         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2710         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2711
2712 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2713
2714         [CMake][WinCairo] Separate copied headers into different directories
2715         https://bugs.webkit.org/show_bug.cgi?id=196655
2716
2717         Reviewed by Michael Catanzaro.
2718
2719         * DumpRenderTree/CMakeLists.txt:
2720         * MiniBrowser/win/CMakeLists.txt:
2721         * TestWebKitAPI/CMakeLists.txt:
2722         * TestWebKitAPI/PlatformWin.cmake:
2723
2724 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2725
2726         Log stack-trace for run-webkit-tests when interrupted
2727         https://bugs.webkit.org/show_bug.cgi?id=176393
2728         <rdar://problem/34262310>
2729
2730         Reviewed by Lucas Forschler.
2731
2732         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2733         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2734         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2735         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2736         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2737         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2738         (main): Set handlers to log stack trace on interruption.
2739
2740 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2741
2742         AX: Support API: accessibilityReplaceRange:withText
2743         https://bugs.webkit.org/show_bug.cgi?id=196636
2744
2745         Unreviewed build fix for Windows port.
2746
2747         * DumpRenderTree/AccessibilityUIElement.cpp:
2748         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2749
2750 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2751
2752         [ews-build] Scripts using Buildbot API have CORS error
2753         https://bugs.webkit.org/show_bug.cgi?id=196709
2754
2755         Reviewed by Alexey Proskuryakov.
2756
2757         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2758
2759 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2760
2761         AX: Support API: accessibilityReplaceRange:withText
2762         https://bugs.webkit.org/show_bug.cgi?id=196636
2763
2764         Reviewed by Daniel Bates.
2765
2766         * DumpRenderTree/AccessibilityUIElement.cpp:
2767         (replaceTextInRangeCallback):
2768         (AccessibilityUIElement::replaceTextInRange):
2769         (AccessibilityUIElement::getJSClass):
2770         * DumpRenderTree/AccessibilityUIElement.h:
2771         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2772         (AccessibilityUIElement::replaceTextInRange):
2773         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2774         (AccessibilityUIElement::replaceTextInRange):
2775         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2776         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2777         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2778         (WTR::AccessibilityUIElement::replaceTextInRange):
2779         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2780         (WTR::AccessibilityUIElement::replaceTextInRange):
2781
2782 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2783
2784         [iOS] Do not allow starting selection drags when selection views are not visible
2785         https://bugs.webkit.org/show_bug.cgi?id=196686
2786         <rdar://problem/49399192>
2787
2788         Reviewed by Tim Horton.
2789
2790         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2791         also add some new API tests to cover scenarios where the web view is not first responder.
2792
2793         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2794         (TestWebKitAPI::TEST):
2795         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2796
2797         Add a switch to optionally make the web view first responder when starting the simulated drag.
2798
2799         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2800         (-[DragAndDropSimulator initWithWebView:]):
2801         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2802
2803 2019-04-08  Justin Fan  <justin_fan@apple.com>
2804
2805         [Web GPU] Fix Web GPU experimental feature on iOS
2806         https://bugs.webkit.org/show_bug.cgi?id=196632
2807
2808         Reviewed by Myles C. Maxfield.
2809
2810         Properly make Web GPU available on iOS 11+.
2811
2812         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2813
2814 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2815
2816         [ews-build] Do not upload archive when Compile Fails
2817         https://bugs.webkit.org/show_bug.cgi?id=196674
2818
2819         Reviewed by Alexey Proskuryakov.
2820
2821         * BuildSlaveSupport/ews-build/factories.py:
2822         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2823         * BuildSlaveSupport/ews-build/steps.py:
2824         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2825         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2826         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2827
2828 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2829
2830         Enable DFG on MIPS
2831         https://bugs.webkit.org/show_bug.cgi?id=196689
2832
2833         Reviewed by Žan Doberšek.
2834
2835         Since the bytecode change, we enabled the baseline JIT on mips in
2836         r240432, but DFG is still missing. With this change, all tests are
2837         passing on a ci20 board.
2838
2839         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2840
2841 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2842
2843         [Flatpak] Second run update-webkitwpe-flatpak fails
2844         https://bugs.webkit.org/show_bug.cgi?id=192702
2845
2846         Reviewed by Carlos Garcia Campos.
2847
2848         * flatpak/flatpakutils.py:
2849         (FlatpakObject.flatpak): Fix typo.
2850         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2851         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2852
2853 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2854
2855         [GTK][WPE] outlook.live.com displays old-fashioned UI
2856         https://bugs.webkit.org/show_bug.cgi?id=196642
2857
2858         Reviewed by Carlos Garcia Campos.
2859
2860         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2861         (TestWebKitAPI::TEST): New Mac platform quirk test.
2862
2863 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2864
2865         Unreviewed, rolling out r243956.
2866         https://bugs.webkit.org/show_bug.cgi?id=196688
2867
2868         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2869         by aakashjain on #webkit).
2870
2871         Reverted changeset:
2872
2873         "Clicking "Go Back" from a safe browsing warning from an
2874         iframe should navigate the WKWebView back to the previous
2875         page"
2876         https://bugs.webkit.org/show_bug.cgi?id=196665
2877         https://trac.webkit.org/changeset/243956
2878
2879 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2880
2881         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2882         https://bugs.webkit.org/show_bug.cgi?id=196669
2883
2884         Reviewed by Geoffrey Garen.
2885
2886         Added three new unit tests for WeakHashSet.
2887
2888         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2889         (WTF_WeakPtr.WeakHashSetConstObjects):
2890         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2891         (WTF_WeakPtr.WeakHashSetComputeSize):
2892
2893 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2894
2895         Hide next and previous form control buttons when WKWebView is editable
2896         https://bugs.webkit.org/show_bug.cgi?id=196672
2897         <rdar://problem/35625321>
2898
2899         Reviewed by Tim Horton.
2900
2901         Add a new API test.
2902
2903         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2904         (-[TestWKWebView lastTrailingBarButtonGroup]):
2905         (TestWebKitAPI::TEST):
2906         * TestWebKitAPI/ios/UIKitSPI.h:
2907
2908 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2909
2910         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2911         https://bugs.webkit.org/show_bug.cgi?id=196077
2912         <rdar://problem/49108202>
2913
2914         Reviewed by Chris Dumez.
2915
2916         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2917         on new web view.
2918
2919         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2920
2921 2019-04-05  Saam Barati  <sbarati@apple.com>
2922
2923         Make compare-results understand MotionMark
2924         https://bugs.webkit.org/show_bug.cgi?id=196666
2925
2926         Reviewed by Yusuke Suzuki.
2927
2928         * Scripts/compare-results:
2929         (PLT5Results):
2930         (detectMotionMark):
2931         (detectMotionMark1_1):
2932         (motionMarkResults):
2933         (motionMark1_1Results):
2934         (detectBenchmark):
2935         (biggerIsBetter):
2936         (main):
2937
2938 2019-04-05  Alex Christensen  <achristensen@webkit.org>
2939
2940         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2941         https://bugs.webkit.org/show_bug.cgi?id=196665
2942         <rdar://45115669>
2943
2944         Reviewed by Geoff Garen.
2945
2946         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2947         (goBack):
2948         (+[SimpleLookupContext sharedLookupContext]):
2949         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2950         (TEST):
2951         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2952         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2953
2954 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
2955
2956         [ews-build] Add configuration and architecture for windows builders
2957         https://bugs.webkit.org/show_bug.cgi?id=196660
2958
2959         Reviewed by Lucas Forschler.
2960
2961         * BuildSlaveSupport/ews-build/config.json:
2962
2963 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
2964
2965         webkitpy: Don't run subsequent rounds if interrupted
2966         https://bugs.webkit.org/show_bug.cgi?id=196646
2967
2968         Reviewed by Aakash Jain.
2969
2970         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2971         (Manager.run): Bail out if interrupted.
2972
2973 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
2974
2975         Test sessionStorage in PSON private browsing mode
2976         https://bugs.webkit.org/show_bug.cgi?id=196561
2977
2978         Reviewed by Alex Christensen.
2979
2980         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2981
2982 2019-04-05  Commit Queue  <commit-queue@webkit.org>
2983
2984         Unreviewed, rolling out r243833.
2985         https://bugs.webkit.org/show_bug.cgi?id=196645
2986
2987         This change breaks build of WPE and GTK ports (Requested by
2988         annulen on #webkit).
2989
2990         Reverted changeset:
2991
2992         "[CMake][WTF] Mirror XCode header directories"
2993         https://bugs.webkit.org/show_bug.cgi?id=191662
2994         https://trac.webkit.org/changeset/243833
2995
2996 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
2997
2998         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
2999         https://bugs.webkit.org/show_bug.cgi?id=196635
3000
3001         Reviewed by Antti Koivisto.
3002         
3003         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3004         for a test to enable async frame scrolling via:
3005             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3006         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3007         
3008         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3009
3010         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3011         (WTR::InjectedBundle::beginTesting):
3012         * WebKitTestRunner/TestController.cpp:
3013         (WTR::TestController::resetPreferencesToConsistentValues):
3014
3015 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3016
3017         Use a correct LC_RPATH when building with ASan
3018         https://bugs.webkit.org/show_bug.cgi?id=196576
3019
3020         Reviewed by David Kilzer.
3021
3022         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3023         so that ../Frameworks is checked. This is simpler and more reliable than updating
3024         each SPC service xcconfig.
3025
3026 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3027
3028         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3029         https://bugs.webkit.org/show_bug.cgi?id=196629
3030
3031         Reviewed by Lucas Forschler.
3032
3033         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3034
3035 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3036
3037         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3038         https://bugs.webkit.org/show_bug.cgi?id=196618
3039
3040         Reviewed by Lucas Forschler.
3041
3042         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3043         (StatusBubble): Added QUEUE_TRIGGERS.
3044         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3045         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3046         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3047         its parent(builder).
3048
3049 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3050
3051         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3052         https://bugs.webkit.org/show_bug.cgi?id=196625
3053
3054         Reviewed by Lucas Forschler.
3055
3056         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3057         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3058
3059 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3060
3061         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3062         https://bugs.webkit.org/show_bug.cgi?id=196630
3063
3064         Reviewed by Wenson Hsieh.
3065
3066         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3067
3068 2019-04-04  Youenn Fablet  <youenn@apple.com>
3069
3070         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3071         https://bugs.webkit.org/show_bug.cgi?id=196543
3072
3073         Reviewed by Alex Christensen.
3074
3075         * WebKitTestRunner/TestController.cpp:
3076         (WTR::TestController::generatePageConfiguration):
3077
3078 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3079
3080         [ews-app] Status bubble should not display skipped buildbot steps
3081         https://bugs.webkit.org/show_bug.cgi?id=196584
3082
3083         Reviewed by Lucas Forschler.
3084
3085         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3086
3087 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3088
3089         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3090         https://bugs.webkit.org/show_bug.cgi?id=196620
3091
3092         Reviewed by Lucas Forschler.
3093
3094         * BuildSlaveSupport/ews-app/ews/config.py:
3095
3096 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3097
3098         [Win] DumpRenderTreeWatchDog.py is not checked into source
3099         https://bugs.webkit.org/show_bug.cgi?id=196567
3100         <rdar://problem/49525901>
3101
3102         Reviewed by Lucas Forschler.
3103
3104         This script is used on Win EWS bots to terminate hanging DRT processes.
3105
3106         * EWSTools/dumprendertreewatchdog.py: Added.
3107
3108 2019-04-04  Chris Dumez  <cdumez@apple.com>
3109
3110         Unreviewed, roll out r243858 which made tests time out.
3111
3112         Disable new API tests on Windows instead.
3113
3114         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3115         (TestWebKitAPI::TEST):
3116
3117 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3118
3119         [ATK] Cleanup WebPageAccessibilityObjectAtk
3120         https://bugs.webkit.org/show_bug.cgi?id=196537
3121
3122         Reviewed by Michael Catanzaro.
3123
3124         Also consider files under atk directories as exceptions for GObject conventions.
3125
3126         * Scripts/webkitpy/style/checkers/cpp.py:
3127         (check_identifier_name_in_declaration):
3128
3129 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3130
3131         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3132         https://bugs.webkit.org/show_bug.cgi?id=196588
3133         <rdar://problem/49365787>
3134
3135         Unreviewed build fix for Windows port.
3136
3137         error C3861: 'kill': identifier not found
3138
3139         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3140         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3141
3142 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3143
3144         [ews-build] Cancel build and similar operations should have authentication
3145         https://bugs.webkit.org/show_bug.cgi?id=196520
3146
3147         Reviewed by Dewei Zhu.
3148
3149         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3150         environment variables.
3151
3152 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3153
3154         [ews-build] Do not trigger queues which are not in production yet
3155         https://bugs.webkit.org/show_bug.cgi?id=196581
3156
3157         Reviewed by Dewei Zhu.
3158
3159         * BuildSlaveSupport/ews-build/config.json:
3160
3161 2019-04-03  Chris Dumez  <cdumez@apple.com>
3162
3163         Unreviewed, fix typo in the name of API test added in r243848.
3164
3165         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3166         (TestWebKitAPI::TEST):
3167
3168 2019-04-03  Chris Dumez  <cdumez@apple.com>
3169
3170         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3171         https://bugs.webkit.org/show_bug.cgi?id=196588
3172         <rdar://problem/49365787>
3173
3174         Reviewed by Ryosuke Niwa.
3175
3176         Add API test coverage.
3177
3178         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3179         (TestWebKitAPI::nullJavaScriptCallback):
3180         (TestWebKitAPI::didCrashCheckFrames):
3181         (TestWebKitAPI::TEST):
3182
3183 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3184
3185         run-webkit-tests: Upload test results (new results database)
3186         https://bugs.webkit.org/show_bug.cgi?id=196577
3187         <rdar://problem/34841155>
3188
3189         Reviewed by Lucas Forschler.
3190
3191         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3192         (Manager.run): Upload results after each device shard, since the configuration will be
3193         different for each device.
3194         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3195         uploaded to a results database.
3196         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3197         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3198
3199 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3200
3201         -apple-trailing-word is needed for browser detection
3202         https://bugs.webkit.org/show_bug.cgi?id=196575
3203
3204         Unreviewed.
3205
3206         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3207
3208 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3209
3210         [CMake][WTF] Mirror XCode header directories
3211         https://bugs.webkit.org/show_bug.cgi?id=191662
3212
3213         Reviewed by Konstantin Tokarev.
3214
3215         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3216         builds.
3217
3218         * CMakeLists.txt:
3219         * DumpRenderTree/CMakeLists.txt:
3220         * DumpRenderTree/PlatformWin.cmake:
3221         * MiniBrowser/win/CMakeLists.txt:
3222         * TestWebKitAPI/CMakeLists.txt:
3223         * TestWebKitAPI/PlatformWin.cmake:
3224         * WebKitTestRunner/PlatformGTK.cmake:
3225         * WebKitTestRunner/PlatformWin.cmake:
3226
3227 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3228
3229         [ews-app] Status bubble should not display certain infrastructure status messages
3230         https://bugs.webkit.org/show_bug.cgi?id=196550
3231
3232         Reviewed by Lucas Forschler.
3233
3234         Do not display the steps which are un-needed for end-user. This information is still avaiable
3235         if the user click on the bubble and look at the Buildbot build.
3236         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3237         (StatusBubble._steps_messages):
3238         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3239
3240 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3241
3242         [ews-build] Use https for sending data to ews-app
3243         https://bugs.webkit.org/show_bug.cgi?id=196492
3244
3245         Reviewed by Lucas Forschler.
3246
3247         * BuildSlaveSupport/ews-build/events.py:
3248
3249 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3250
3251         Remove support for -apple-trailing-word
3252         https://bugs.webkit.org/show_bug.cgi?id=196525
3253
3254         Reviewed by Zalan Bujtas.
3255
3256         This CSS property is nonstandard and not used.
3257
3258         * Scripts/webkitperl/FeatureList.pm:
3259         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3260
3261 2019-04-03  Youenn Fablet  <youenn@apple.com>
3262
3263         Add a test for DOMCache on multiple browsing in case of private browsing
3264         https://bugs.webkit.org/show_bug.cgi?id=196524
3265
3266         Reviewed by Alex Christensen.
3267
3268         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3269         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3270
3271 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3272
3273         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3274         https://bugs.webkit.org/show_bug.cgi?id=196540
3275
3276         Reviewed by Aakash Jain.
3277
3278         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3279
3280 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3281
3282         Add plumbing for a compatibility mode preference in WebKit
3283         https://bugs.webkit.org/show_bug.cgi?id=196005
3284
3285         Reviewed by Tim Horton.
3286
3287         Add new API tests.
3288
3289         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3290         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3291
3292 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3293
3294         [WPE][GTK] Update libsrtp dependency package for Debian
3295         https://bugs.webkit.org/show_bug.cgi?id=196528
3296
3297         Reviewed by Frédéric Wang.
3298
3299         * gtk/install-dependencies:
3300         * wpe/install-dependencies:
3301
3302 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3303
3304         [WK2] Add support for Window's beforeprint / afterprint events
3305         https://bugs.webkit.org/show_bug.cgi?id=196478
3306         <rdar://problem/49535124>
3307
3308         Unreviewed build fix for MSVC.
3309
3310         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3311
3312         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3313
3314         * WebKitTestRunner/TestController.cpp:
3315         (WTR::printFrame): Use int and float literals.
3316
3317 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3318
3319         [ews-build] Reassign bots to queues
3320
3321         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3322
3323 2019-04-02  Chris Dumez  <cdumez@apple.com>
3324
3325         [WK2] Add support for Window's beforeprint / afterprint events
3326         https://bugs.webkit.org/show_bug.cgi?id=196478
3327
3328         Reviewed by Alex Christensen.
3329
3330         Add minimal implementation for printFrame in WebKitTestRunner.
3331
3332         * WebKitTestRunner/TestController.cpp:
3333         (WTR::printFrame):
3334         (WTR::TestController::createOtherPage):
3335         (WTR::TestController::createWebViewWithOptions):
3336
3337 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3338
3339         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3340         https://bugs.webkit.org/show_bug.cgi?id=196491
3341
3342         Reviewed by Lucas Forschler.
3343
3344         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3345
3346 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3347
3348         [ews-build] Configure buildbot try credentials in environment variables
3349         https://bugs.webkit.org/show_bug.cgi?id=196501
3350
3351         Reviewed by Lucas Forschler.
3352
3353         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3354         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3355         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3356
3357 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3358
3359         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3360         https://bugs.webkit.org/show_bug.cgi?id=196496
3361         <rdar://problem/49521634>
3362
3363         Reviewed by Chris Dumez.
3364
3365         Add new API tests (see WebKit ChangeLog for more detail).
3366
3367         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3368         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3369         (TEST):
3370
3371 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3372
3373         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3374         <https://webkit.org/b/196499>
3375
3376         Reviewed by Alexey Proskuryakov.
3377
3378         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3379         ENABLE_ADDRESS_SANITIZER.
3380
3381 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3382
3383         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3384         https://bugs.webkit.org/show_bug.cgi?id=182757
3385
3386         Reviewed by Don Olmstead.
3387
3388         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3389         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3390
3391 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3392
3393         run-api-tests: Upload test results
3394         https://bugs.webkit.org/show_bug.cgi?id=196323
3395         <rdar://problem/49356714>
3396
3397         Reviewed by Lucas Forschler.
3398
3399         * Scripts/webkitpy/api_tests/manager.py:
3400         (Manager):
3401         (Manager.run): Upload results to a results database.
3402         * Scripts/webkitpy/api_tests/run_api_tests.py:
3403         (parse_args): Add upload arguments.
3404         * Scripts/webkitpy/port/base.py:
3405         (Port):
3406         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3407         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3408         with commits from any other associated repositories.
3409         * Scripts/webkitpy/port/device.py:
3410         (Device):
3411         (Device.build_version): Access build_versoin of underlying platform device.
3412         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3413         (IOSSimulatorTest):
3414         (IOSSimulatorTest.test_configuration_for_upload):
3415         * Scripts/webkitpy/port/device_port.py:
3416         (DevicePort):
3417         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3418         the same as the machine uploading results.
3419         * Scripts/webkitpy/port/mac.py:
3420         (MacPort):
3421         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3422         * Scripts/webkitpy/port/mac_unittest.py:
3423         (MacTest):
3424         (MacTest.test_configuration_for_upload):
3425         * Scripts/webkitpy/xcode/simulated_device.py:
3426         (SimulatedDeviceManager._create_device_with_runtime):
3427         (SimulatedDevice.__init__): Create simulated device with a build_version.
3428         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3429         (test_existing_simulator):
3430
3431 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3432
3433         Remove extra newline characters (Follow-up fix to r243707)
3434
3435         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3436
3437 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3438
3439         [ews-app] Use API_KEY to accept results data
3440         https://bugs.webkit.org/show_bug.cgi?id=196461
3441
3442         Reviewed by Dewei Zhu.
3443
3444         * BuildSlaveSupport/ews-app/ews/views/results.py:
3445         (Results.post): Validate EWS_API_KEY before accepting any data.
3446         * BuildSlaveSupport/ews-build/events.py:
3447         (Events.sendData): Send EWS_API_KEY if available along with event data.
3448
3449 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3450
3451         Unable to copy and paste a PDF from Notes into Mail compose body
3452         https://bugs.webkit.org/show_bug.cgi?id=196442
3453         <rdar://problem/48573098>
3454
3455         Reviewed by Tim Horton.
3456
3457         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3458         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3459         to be specified on the item providers.
3460
3461         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3462         (TestWebKitAPI::mapItemForTesting):
3463         (TestWebKitAPI::contactItemForTesting):
3464
3465 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3466
3467         Make UIWKDocumentContext rects per-character instead of per-word
3468         https://bugs.webkit.org/show_bug.cgi?id=196459
3469
3470         Reviewed by Wenson Hsieh.
3471
3472         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3473         (TEST):
3474         Adjust test results due to switching to per-character rects.
3475
3476 2019-04-01  Chris Dumez  <cdumez@apple.com>
3477
3478         UIProcess crash when a prewarmed process is terminated
3479         https://bugs.webkit.org/show_bug.cgi?id=196451
3480         <rdar://problem/49245471>
3481
3482         Reviewed by Geoffrey Garen.
3483
3484         Add API test coverage.
3485
3486         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3487         (TEST):
3488
3489 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3490
3491         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3492         https://bugs.webkit.org/show_bug.cgi?id=196449
3493
3494         Reviewed by Lucas Forschler.
3495
3496         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3497         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3498         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3499         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3500
3501 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3502
3503         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3504         https://bugs.webkit.org/show_bug.cgi?id=196444
3505
3506         Reviewed by Lucas Forschler.
3507
3508         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3509
3510 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3511
3512         Add SPI to canonicalize NSURLs with WTF::URL
3513         https://bugs.webkit.org/show_bug.cgi?id=196415
3514         <rdar://problem/44980271>
3515
3516         Reviewed by Darin Adler.
3517
3518         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3519         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3520         (TestWebKitAPI::TEST):
3521
3522 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3523
3524         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3525         https://bugs.webkit.org/show_bug.cgi?id=196441
3526
3527         Reviewed by Carlos Garcia Campos.
3528
3529         Don't cache the wpe_view_backend object that might not exist yet at the
3530         time of EventSenderProxy constructor invocation, but instead retrieve
3531         that object whenever it's required for event dispatching. This should
3532         avoid crashes in this constructor now that it's invoked before any
3533         PlatformWindow has been set up (as changed in r243496).
3534
3535         * WebKitTestRunner/EventSenderProxy.h:
3536         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3537         (WTR::viewBackend):
3538         (WTR::EventSenderProxy::EventSenderProxy):
3539         (WTR::EventSenderProxy::mouseDown):
3540         (WTR::EventSenderProxy::mouseUp):
3541         (WTR::EventSenderProxy::mouseMoveTo):
3542         (WTR::EventSenderProxy::mouseScrollBy):
3543         (WTR::EventSenderProxy::keyDown):
3544         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3545
3546 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3547
3548         [Win][WebKit] MiniBrowser should support high DPI display
3549         https://bugs.webkit.org/show_bug.cgi?id=196391
3550
3551         Reviewed by Alex Christensen.
3552
3553         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3554         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3555         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3556         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3557
3558 2019-03-31  Sam Weinig  <weinig@apple.com>
3559
3560         Remove more i386 specific configurations
3561         https://bugs.webkit.org/show_bug.cgi?id=196430
3562
3563         Reviewed by Alexey Proskuryakov.
3564
3565         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3566         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3567
3568 2019-03-31  Andy Estes  <aestes@apple.com>
3569
3570         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3571         https://bugs.webkit.org/show_bug.cgi?id=196433
3572         <rdar://problem/49293305>
3573
3574         Reviewed by Tim Horton.
3575
3576         Enhanced API test coverage to include all navigation response policy decisions in both
3577         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3578
3579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3580         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3581         (TestWebKitAPI::TEST):
3582         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3583         (readFile):
3584         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3585         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3586         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3587         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3588         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3589         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3590         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3591         (-[QuickLookDelegate _downloadDidStart:]):
3592         (-[QuickLookDelegate _download:didReceiveResponse:]):
3593         (-[QuickLookDelegate _download:didReceiveData:]):
3594         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3595         (-[QuickLookDelegate _downloadDidFinish:]):
3596         (-[QuickLookDelegate _download:didFailWithError:]):
3597         (-[QuickLookDelegate _downloadDidCancel:]):
3598         (-[QuickLookDelegate verifyDownload]):
3599         (runTest):
3600         (runTestDecideBeforeLoading):
3601         (runTestDecideAfterLoading):
3602         (TEST):
3603         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3604         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3605         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3606         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3607         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3608         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3609         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3610         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3611         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3612         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3613         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3614         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3615         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3616         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3617
3618 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3619
3620         [CMake] add testdfg as target with build-jsc
3621         https://bugs.webkit.org/show_bug.cgi?id=196393
3622
3623         Reviewed by Saam Barati.
3624
3625         Added testdfg as one of the targets to build when
3626         using CMake.
3627
3628         * Scripts/build-jsc:
3629
3630 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3631
3632         Delete WebMetal implementation in favor of WebGPU
3633         https://bugs.webkit.org/show_bug.cgi?id=195418
3634
3635         Reviewed by Dean Jackson.
3636
3637         * DumpRenderTree/mac/DumpRenderTree.mm:
3638         (enableExperimentalFeatures):
3639         (resetWebPreferencesToConsistentValues):
3640         * Scripts/webkitperl/FeatureList.pm:
3641         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3643         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3644         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3645         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3646         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3647         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3648         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3649         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3650         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3651         (WTR::InjectedBundle::beginTesting):
3652         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3653         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3654         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3655
3656 2019-03-29  Chris Dumez  <cdumez@apple.com>
3657
3658         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3659         https://bugs.webkit.org/show_bug.cgi?id=196405
3660         <rdar://problem/49428130>
3661
3662         Reviewed by Wenson Hsieh.
3663
3664         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3665         the popover presentation methods to be no-ops. Use this in the new test added in
3666         r243523 so that we do not swizzle those methods for all tests. This is needed because
3667         those WatchOS tests rely on the popover getting presented and interactive.
3668
3669         * WebKitTestRunner/TestController.cpp:
3670         (WTR::updateTestOptionsFromTestHeader):
3671         * WebKitTestRunner/TestController.h:
3672         * WebKitTestRunner/TestOptions.h:
3673         (WTR::TestOptions::hasSameInitializationOptions const):
3674         * WebKitTestRunner/ios/TestControllerIOS.mm:
3675         (WTR::TestController::platformInitialize):
3676         (WTR::TestController::platformResetStateToConsistentValues):
3677
3678 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3679
3680         [Curl] Add Server Trust Evaluation Support.
3681         https://bugs.webkit.org/show_bug.cgi?id=191646
3682
3683         Reviewed by Fujii Hironori.
3684
3685         Implemented MiniBrowser UI for asking if user trusts the server.
3686
3687         * MiniBrowser/win/Common.cpp:
3688         (askServerTrustEvaluation):
3689         (replaceString):
3690         * MiniBrowser/win/Common.h:
3691         * MiniBrowser/win/MiniBrowserLib.rc:
3692         * MiniBrowser/win/MiniBrowserLibResource.h:
3693         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3694         (createPEMString):
3695         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3696         (WebKitBrowserWindow::canTrustServerCertificate):
3697         * MiniBrowser/win/WebKitBrowserWindow.h:
3698
3699 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3700
3701         Implement ResizeObserver.
3702         https://bugs.webkit.org/show_bug.cgi?id=157743
3703
3704         Reviewed by Simon Fraser.
3705
3706         Support resizeObserverEnabled webPreferences.
3707
3708         * DumpRenderTree/TestOptions.cpp:
3709         (TestOptions::TestOptions):
3710         * DumpRenderTree/TestOptions.h:
3711         * DumpRenderTree/mac/DumpRenderTree.mm:
3712         (setWebPreferencesForTestOptions):
3713         * DumpRenderTree/win/DumpRenderTree.cpp:
3714         (enableExperimentalFeatures):
3715         * Scripts/webkitperl/FeatureList.pm:
3716         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3717
3718 2019-03-28  John Wilander  <wilander@apple.com>
3719
3720         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3721         https://bugs.webkit.org/show_bug.cgi?id=196281
3722         <rdar://problem/48938748>
3723
3724         Reviewed by Alex Christensen.
3725
3726         This patch adds the function isStatisticsHasLocalStorage() to the
3727         TestRunner. With it, the page can query the WebsiteDataStore in the
3728         UI process to make sure that it sees LocalStorage.
3729
3730         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3731         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3732         (WTR::TestRunner::isStatisticsHasLocalStorage):
3733         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3734         * WebKitTestRunner/TestController.cpp:
3735         (WTR::TestController::isStatisticsHasLocalStorage):
3736         * WebKitTestRunner/TestController.h:
3737         * WebKitTestRunner/TestInvocation.cpp:
3738         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3739
3740 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3741
3742         API::Data::createWithoutCopying should do a null check before calling CFRelease
3743         https://bugs.webkit.org/show_bug.cgi?id=196276
3744         <rdar://problem/48059859>
3745
3746         Reviewed by Alex Christensen.
3747
3748         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3749
3750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3751         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3752         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3753         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3754         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3755         (TestWebKitAPI::TEST):
3756
3757 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3758
3759         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3760         https://bugs.webkit.org/show_bug.cgi?id=186276
3761
3762         Reviewed by Carlos Garcia Campos.
3763
3764         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3765         (webViewLoadChanged):
3766         (testWebResourceGetDataError):
3767         (testWebResourceGetDataEmpty):
3768         (beforeAll):
3769         (webViewloadChanged): Deleted.
3770
3771 2019-03-27  Andy Estes  <aestes@apple.com>
3772
3773         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3774         https://bugs.webkit.org/show_bug.cgi?id=196317
3775
3776         Reviewed by Dan Bernstein.
3777
3778         package-root copies built products into a staging directory using ditto(1), which does not
3779         follow symbolic links as it traverses a directory. Now that the files in
3780         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3781         itself, these become broken links when ditto'd into the staging directory.
3782
3783         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3784
3785         * Scripts/package-root:
3786
3787 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3788
3789         [ews-app] Update display text of Submit for ews analysis
3790         https://bugs.webkit.org/show_bug.cgi?id=196309
3791
3792         Reviewed by Dewei Zhu.
3793
3794         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3795
3796 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3797
3798         run-webkit-tests should check for leaks in WebKit processes
3799         <https://webkit.org/b/193772>
3800         <rdar://problem/46526680>
3801
3802         Reviewed by Ryosuke Niwa.
3803
3804         This works by doing the following:
3805         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3806           The list of child processes are returned one per line:
3807           process.name: pid
3808         - Run the "#LIST CHILD PROCESSES" command just before the
3809           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3810           processes on the ServerProcess object.
3811         - When the `--leaks` switch is handled, run check_for_leaks() on
3812           each child process after the main test harness.
3813
3814         * DumpRenderTree/mac/DumpRenderTree.mm:
3815         (handleControlCommand):
3816         - Use strncmp() instead of strcmp().
3817         - Add support for handling "#LIST CHILD PROCESSES" command.
3818
3819         * Scripts/webkitpy/port/base.py:
3820         (Port.check_for_leaks):
3821         * Scripts/webkitpy/port/darwin.py:
3822         (DarwinPort.check_for_leaks):
3823         - Rename redundant 'process_pid' argument to 'process_id'.
3824
3825         * Scripts/webkitpy/port/driver.py:
3826         (Driver.do_post_tests_work):
3827         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3828           longer the only command this sends to WebKitTestRunner.
3829         - If the `--leaks` switch is present, send the
3830           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3831           result using Port.set_webkit_processes().
3832         (Driver._parse_child_processes_output):
3833         - Add helper method to parse list of child process names and
3834           process IDs returned from WebKitTestRunner.
3835
3836         * Scripts/webkitpy/port/ios_device.py:
3837         (IOSDevicePort.check_for_leaks):
3838         - Rename redundant 'process_pid' argument to 'process_id'.
3839
3840         * Scripts/webkitpy/port/leakdetector.py:
3841         (LeakDetector._parse_leaks_output):
3842         - Return early if there is no leaks_output.
3843         (LeakDetector.check_for_leaks):
3844         - Rename redundant 'process_pid' argument to 'process_id'.
3845
3846         * Scripts/webkitpy/port/server_process.py:
3847         (ServerProcess.__init__):
3848         (ServerProcess.child_processes):
3849         (ServerProcess.set_child_processes):
3850         - Add instance variable to Port to store list of child process
3851           names and process IDs returned from WebKitTestRunner.
3852         (ServerProcess._start):
3853         - Clear self._child_processes.
3854         (ServerProcess.stop):
3855         - If self._child_processes is set, call
3856           self._port.check_for_leaks() for each child process.
3857
3858         * Scripts/webkitpy/port/server_process_unittest.py:
3859         (TrivialMockPort.check_for_leaks):
3860         - Rename redundant 'process_pid' argument to 'process_id'.
3861
3862         * Scripts/webkitpy/port/simulator_process.py:
3863         (SimulatorProcess.stop):
3864         - If self._child_processes is set, call
3865           self._port.check_for_leaks() for each child process.
3866
3867         * Scripts/webkitpy/port/watch_device.py:
3868         (WatchDevicePort.check_for_leaks):
3869         - Rename redundant 'process_pid' argument to 'process_id'.
3870
3871         * WebKitTestRunner/TestController.cpp:
3872         (WTR::TestController::dumpResponse):
3873         - Extract method from findAndDumpWorldLeaks() so that it may be
3874           reused by findAndDumpWebKitProcessIdentifiers().
3875         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3876         - Add method to output process name and process ID of both the
3877           WebContent and Networking processes.
3878         (WTR::TestController::findAndDumpWorldLeaks):
3879         - Fix missing newline in output when there were no abandoned
3880           documents.
3881         - Call dumpResponse() for extracted code.
3882         (WTR::TestController::handleControlCommand):
3883         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3884         - Use strncmp() instead of strcmp().
3885         - Call findAndDumpWebKitProcessIdentifiers() when
3886           "#LIST CHILD PROCESSES" command is sent.
3887         * WebKitTestRunner/TestController.h:
3888         (WTR::TestController::dumpResponse):
3889         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3890         - Declare methods.
3891
3892 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3893
3894         Unreviewed. Add GLib API test cases after r243434.
3895
3896         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3897         (testWebViewActiveURI):
3898         (serverCallback):
3899         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3900         (sendRequestCallback):
3901
3902 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3903
3904         Geolocation request not complete when watch request was started in a different web process
3905         https://bugs.webkit.org/show_bug.cgi?id=195996
3906
3907         Reviewed by Alex Christensen.
3908
3909         Add a test case.
3910
3911         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3912         (TestWebKitAPI::runJavaScriptAlert):
3913         (TestWebKitAPI::TEST):
3914
3915 2019-03-26  Keith Rollin  <krollin@apple.com>
3916
3917         Update the way generate-xcfilelists returns strings from functions
3918         https://bugs.webkit.org/show_bug.cgi?id=195975
3919         <rdar://problem/49040807>
3920
3921         Reviewed by Dean Jackson.
3922
3923         There are places where generate-xcfilelists executes assignments with
3924         statements like:
3925
3926             FOO=$(some_function)
3927
3928         where "some_function" return a string by echoing it. E.g.
3929
3930             some_function()
3931             {
3932                 echo "Hello, World"
3933             }
3934
3935         This is a common idiom, but it has a problem if "some_function" needs
3936         to call "exit" in an attempt to halt the entire script right then and
3937         there. Since "some_function" is called inside of $(), it's being
3938         executed in a sub-shell. Calling exit in that sub-shell simply exits
3939         that shell; it doesn't not exit the outer shell in which the main part
3940         of the script is still running. As such, the main script keeps
3941         executing when the intent was for the script to halt.
3942
3943         The solution to this is to use a different idiom for returning
3944         strings. The one we now is to pass in the name of the variable to
3945         receive the string result:
3946
3947             some_function()
3948             {
3949                 variable_name=$1
3950                 eval $variable_name ="Hello, World"
3951             }
3952
3953         The call site now looks like
3954
3955             some_function FOO
3956
3957         Because there's no invocation of a sub-shell, some_function can now
3958         call "exit" if it wants to, and the entire script will exit at that
3959         point.
3960
3961         * Scripts/generate-xcfilelists:
3962
3963 2019-03-26  Chris Dumez  <cdumez@apple.com>
3964
3965         Add basic layout test coverage for File Picker on iOS
3966         https://bugs.webkit.org/show_bug.cgi?id=196265
3967
3968         Reviewed by Wenson Hsieh.
3969
3970         Add layout test infrastructure to test the file picker on iOS.
3971
3972         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3973         (WTR::UIScriptController::dismissFilePicker):
3974         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3975         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3976         (WTR::UIScriptController::dismissFilePicker):
3977         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3978         * WebKitTestRunner/TestController.cpp:
3979         (WTR::TestController::createWebViewWithOptions):
3980         (WTR::updateTestOptionsFromTestHeader):
3981         * WebKitTestRunner/TestOptions.h:
3982         (WTR::TestOptions::hasSameInitializationOptions const):
3983         * WebKitTestRunner/ios/TestControllerIOS.mm:
3984         (overridePresentViewController):
3985         (WTR::TestController::platformInitialize):
3986         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3987         (WTR::UIScriptController::dismissFilePicker):
3988
3989 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3990
3991         Implement async paste method on UIWKInteractionViewProtocol
3992         https://bugs.webkit.org/show_bug.cgi?id=196267
3993         <rdar://problem/49236346>
3994
3995         Reviewed by Tim Horton.
3996
3997         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
3998         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
3999         are now a part of all iOS 12 internal SDKs.
4000
4001         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
4002
4003         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
4004         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
4005
4006         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
4007         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4008         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
4009         * TestWebKitAPI/ios/UIKitSPI.h:
4010
4011 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4012
4013         [ews-build] Use PostgreSQL for ews.webkit.org database
4014         https://bugs.webkit.org/show_bug.cgi?id=196270
4015
4016         Reviewed by Lucas Forschler.
4017
4018         * BuildSlaveSupport/ews-app/ews-app/settings.py:
4019
4020 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
4021
4022         [ews] Reset simctl states on reboot
4023         https://bugs.webkit.org/show_bug.cgi?id=196260
4024
4025         Rubber-stamped by Aakash Jain.
4026
4027         * EWSTools/start-queue-mac.sh:
4028
4029 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4030
4031         [ews-build] Use PostgreSQL for ews-build database
4032         https://bugs.webkit.org/show_bug.cgi?id=196229
4033
4034         Reviewed by Lucas Forschler.
4035
4036         * BuildSlaveSupport/ews-build/master.cfg:
4037
4038 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4039
4040         [ews-build] Get master_hostname dynamically in master.cfg
4041         https://bugs.webkit.org/show_bug.cgi?id=196255
4042
4043         Reviewed by Lucas Forschler.
4044
4045         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
4046         send events data in test mode.
4047
4048 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4049
4050         [ews-app] Set db_constraint to False for Foreign Keys
4051         https://bugs.webkit.org/show_bug.cgi?id=196252
4052
4053         Reviewed by Lucas Forschler.
4054
4055         * BuildSlaveSupport/ews-app/ews/models/build.py:
4056         * BuildSlaveSupport/ews-app/ews/models/step.py:
4057
4058 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4059
4060         [ews-build] is_test_mode_enabled should default to True
4061         https://bugs.webkit.org/show_bug.cgi?id=196248
4062
4063         Reviewed by Lucas Forschler.
4064
4065         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
4066
4067 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4068
4069         [ews-app] Add webkitperl to ENABLED_QUEUES
4070         https://bugs.webkit.org/show_bug.cgi?id=196253
4071
4072         Reviewed by Lucas Forschler.
4073
4074         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4075
4076 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
4077
4078         Address NSWindow sometimes using WebKitTestRunnerEvent too early
4079         https://bugs.webkit.org/show_bug.cgi?id=196211
4080         rdar://problem/49110552
4081
4082         Reviewed by Tim Horton.
4083
4084         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
4085         Make sure that EventSenderProxy always exists when running tests. We used to create
4086         it when resetting before the first test, which is a bit too late.
4087
4088         * WebKitTestRunner/TestController.h:
4089         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4090         (WTR::TestController::platformCreateWebView):
4091         (WTR::TestController::platformCreateOtherPage):
4092         (WTR::TestController::finishCreatingPlatformWebView):
4093         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4094         (WTR::PlatformWebView::PlatformWebView):
4095         Moved some code that made NSWindow use NSEvent during web view creation. We may
4096         need to move more if some other case us found, but this is enough for now.
4097
4098 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
4099
4100         Unreviewed. Fix typo in GLib geolocation API after r243285.
4101
4102         gelocation -> geolocation.
4103
4104         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
4105         (testGeolocationManagerWatchPosition):
4106
4107 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4108
4109         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4110         https://bugs.webkit.org/show_bug.cgi?id=196213
4111
4112         Reviewed by Geoff Garen.
4113
4114         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4115         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4116         (credentialWithIdentityAndKeychainPath):
4117         (-[ChallengeDelegate webView:didFinishNavigation:]):
4118         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4119         (TestWebKitAPI::TEST):
4120
4121 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4122
4123         Expected shouldn't assume its contained types are copyable
4124         https://bugs.webkit.org/show_bug.cgi?id=195986
4125
4126         Reviewed by JF Bastien.
4127
4128         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4129         (TestWebKitAPI::NonCopyable::operator== const):
4130         (TestWebKitAPI::NonCopyable::operator!= const):
4131         (TestWebKitAPI::TEST):
4132
4133 2019-03-25  Tim Horton  <timothy_horton@apple.com>
4134
4135         Remove some now-unnecessary dynamic class lookup
4136         https://bugs.webkit.org/show_bug.cgi?id=196237
4137
4138         Reviewed by Simon Fraser.
4139
4140         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4141         (makeRequest):
4142         (TEST):
4143
4144 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
4145
4146         Unreviewed, rolling out r243450.
4147
4148         AppleWin and WinCairo port builds get broken.
4149
4150         Reverted changeset:
4151
4152         "Add test for fix of #196095"
4153         https://bugs.webkit.org/show_bug.cgi?id=196097
4154         https://trac.webkit.org/changeset/243450
4155
4156 2019-03-25  Commit Queue  <commit-queue@webkit.org>
4157
4158         Unreviewed, rolling out r243465.
4159         https://bugs.webkit.org/show_bug.cgi?id=196226
4160
4161         the test doesn't build (Requested by thorton on #webkit).
4162
4163         Reverted changeset:
4164
4165         "Do not terminate the NetworkProcess if a third party
4166         application sends a NSCredential with a SecIdentityRef"
4167         https://bugs.webkit.org/show_bug.cgi?id=196213
4168         https://trac.webkit.org/changeset/243465
4169
4170 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4171
4172         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4173         https://bugs.webkit.org/show_bug.cgi?id=196213
4174
4175         Reviewed by Geoff Garen.
4176
4177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4178         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4179         (credentialWithIdentityAndKeychainPath):
4180         (-[ChallengeDelegate webView:didFinishNavigation:]):
4181         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4182         (TestWebKitAPI::TEST):
4183
4184 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4185
4186         [ews-build] Gracefully handle missing patch_id in events
4187         https://bugs.webkit.org/show_bug.cgi?id=196216
4188
4189         Reviewed by Lucas Forschler.
4190
4191         * BuildSlaveSupport/ews-build/events.py:
4192
4193 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4194
4195         [ews-build] use lz4 compression for improving buildbot performance
4196         https://bugs.webkit.org/show_bug.cgi?id=196155
4197
4198         Reviewed by Lucas Forschler.
4199
4200         * BuildSlaveSupport/ews-build/master.cfg:
4201
4202 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4203
4204         Pull some API testing helper methods out of TestWKWebView
4205         https://bugs.webkit.org/show_bug.cgi?id=196212
4206
4207         Reviewed by Tim Horton.
4208
4209         Refactor some more API testing utility methods, so that they can be used in
4210         tests that do not use TestWKWebView.
4211
4212         * TestWebKitAPI/cocoa/TestWKWebView.h:
4213         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4214         (-[WKWebView loadTestPageNamed:]):
4215         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
4216         (-[WKWebView synchronouslyLoadHTMLString:]):
4217         (-[WKWebView synchronouslyLoadTestPageNamed:]):
4218         (-[TestWKWebView loadTestPageNamed:]): Deleted.
4219         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
4220         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
4221         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
4222
4223 2019-03-25  Jer Noble  <jer.noble@apple.com>
4224
4225         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
4226         https://bugs.webkit.org/show_bug.cgi?id=196097
4227
4228         Reviewed by Eric Carlson.
4229
4230         Drive-by bug fix: allow tests to play audio without a user gesture by default.
4231
4232         * DumpRenderTree/mac/DumpRenderTree.mm:
4233         (resetWebPreferencesToConsistentValues):
4234         * WebKitTestRunner/TestController.cpp:
4235         (WTR::TestController::resetPreferencesToConsistentValues):
4236
4237 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4238
4239         Pull IPadUserInterfaceSwizzler out into a separate header file
4240         https://bugs.webkit.org/show_bug.cgi?id=196193
4241
4242         Reviewed by Anders Carlsson.
4243
4244         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
4245         be used in other API tests.
4246
4247         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4248         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
4249         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
4250         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
4251         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
4252         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
4253         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
4254
4255 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4256
4257         Remove NavigatorContentUtils in WebCore/Modules
4258         https://bugs.webkit.org/show_bug.cgi?id=196070
4259
4260         Reviewed by Alex Christensen.
4261
4262         NavigatorContentUtils was to support the custom scheme spec [1].
4263         However, in WebKit side, no port has supported the feature in
4264         WebKit layer after EFL port was removed. So there has been the
4265         only IDL implementation of the NavigatorContentUtils in WebCore.
4266         So we don't need to keep the implementation in WebCore anymore.
4267
4268         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
4269
4270         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4271
4272 2019-03-24  Andy Estes  <aestes@apple.com>
4273
4274         [watchOS] Remove unused Proximity Networking code
4275         https://bugs.webkit.org/show_bug.cgi?id=196188
4276
4277         Reviewed by Tim Horton.
4278
4279         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
4280         (TEST):
4281
4282 2019-03-23  Keith Miller  <keith_miller@apple.com>
4283
4284         Refactor clz/ctz and fix getLSBSet.
4285         https://bugs.webkit.org/show_bug.cgi?id=196162
4286
4287         Reviewed by Saam Barati.
4288
4289         Add tests for clz, ctz, getLSBSet, and getMSBSet.
4290
4291         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
4292         (TestWebKitAPI::TEST):
4293
4294 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
4295
4296         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
4297         https://bugs.webkit.org/show_bug.cgi?id=196143
4298
4299         Reviewed by Michael Catanzaro.
4300
4301         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
4302         directories.
4303
4304         * Scripts/webkitpy/style/ch