Fix roll-chromium-deps and hi.
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Fix roll-chromium-deps and hi.
4
5         * Scripts/webkitpy/tool/bot/irc_command.py:
6         (Hi.execute):
7         (RollChromiumDEPS.execute):
8
9 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
10
11         Remove webkitpy code to roll Chromium DEPS
12         https://bugs.webkit.org/show_bug.cgi?id=114415
13
14         Reviewed by Benjamin Poulain.
15
16         Removed the code to roll Chromium DEPS in WebKit.
17
18         * Scripts/webkitpy/common/checkout/checkout.py:
19         (Checkout.bug_id_for_this_commit):
20         * Scripts/webkitpy/common/checkout/checkout_mock.py:
21         (MockCheckout.commit_message_for_this_commit):
22         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
23         (CheckoutTest.test_suggested_reviewers):
24         * Scripts/webkitpy/common/checkout/deps.py: Removed.
25         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
26         * Scripts/webkitpy/tool/bot/irc_command.py:
27         (RollChromiumDEPS): Teach webkitbot a sense of humor.
28         (RollChromiumDEPS.execute):
29         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
30         (IRCCommandTest.test_create_bug):
31         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
32         (IRCBotTest.test_revert):
33         * Scripts/webkitpy/tool/bot/sheriff.py:
34         (Sheriff.post_rollout_patch):
35         * Scripts/webkitpy/tool/commands/__init__.py:
36         * Scripts/webkitpy/tool/commands/roll.py: Removed.
37         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
38         * Scripts/webkitpy/tool/steps/__init__.py:
39         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
40         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
41         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
42
43 2013-04-11  Glenn Adams  <glenn@skynav.com>
44
45         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
46         https://bugs.webkit.org/show_bug.cgi?id=114386
47
48         Reviewed by Benjamin Poulain.
49
50         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
51         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
52         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
53         by default and to return exit code 1 if a file/dir had already been added.
54
55         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
56         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
57         * Scripts/webkitpy/common/checkout/scm/svn.py:
58         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
59
60 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
61
62         Unreviewed.
63
64         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
65
66 2013-04-10  Glenn Adams  <glenn@skynav.com>
67
68         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
69         https://bugs.webkit.org/show_bug.cgi?id=114410
70
71         Reviewed by Ryosuke Niwa.
72
73         * Scripts/webkitpy/common/checkout/scm/git.py:
74         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
75         * Scripts/webkitpy/common/checkout/scm/scm.py:
76         (SCM.add): Remove optional return_exit_code argument.
77         (SCM.add_list): Remove optional return_exit_code argument.
78         * Scripts/webkitpy/common/checkout/scm/svn.py:
79         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
80
81 2013-04-10  Eric Seidel  <eric@webkit.org>
82
83         Remove myself from the watchlists, I'm getting too much bug mail. :)
84
85         * Scripts/webkitpy/common/config/watchlist:
86
87 2013-04-10  Commit Queue  <rniwa@webkit.org>
88
89         Unreviewed, rolling out r148158.
90         http://trac.webkit.org/changeset/148158
91         https://bugs.webkit.org/show_bug.cgi?id=114405
92
93         We need to migrate status data (Requested by rniwa on
94         #webkit).
95
96         * Scripts/webkitpy/common/net/statusserver.py:
97         (StatusServer):
98
99 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
100
101         Mass remove all the empty directories
102
103         Rubberstamped by Ryosuke Niwa.
104
105         * BuildSlaveSupport/gtk/crashmon/log: Removed.
106         * BuildSlaveSupport/gtk/xvfb/log: Removed.
107         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
108         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
109         * MiniBrowser/gtk/WebBundle: Removed.
110         * MiniBrowser/win: Removed.
111         * QtTestPlatformPlugin/mac: Removed.
112         * Scripts/webkitpy/tool/bot/testdata: Removed.
113         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
114         * efl/ImageDiff: Removed.
115         * iExploder/htdocs: Removed.
116         * iExploder/iexploder-1.7.2/output: Removed.
117         * iExploder/tools: Removed.
118         * qmake/config.tests/libexecdir: Removed.
119         * qmake/config.tests/libjpeg: Removed.
120         * qmake/config.tests/libpng: Removed.
121
122 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
123
124         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
125         https://bugs.webkit.org/show_bug.cgi?id=114397
126
127         Reviewed by Benjamin Poulain.
128
129         * Scripts/webkitpy/common/net/statusserver.py:
130         (StatusServer):
131
132 2013-04-10  Adam Barth  <abarth@webkit.org>
133
134         Remove abarth from watchlists
135         https://bugs.webkit.org/show_bug.cgi?id=114390
136
137         Reviewed by Ryosuke Niwa.
138
139         I'm trying to cut down on the amount of bugmail I get so that I'll have
140         more of a chance to notice a piece of bugmail directed at me.
141
142         * Scripts/webkitpy/common/config/watchlist:
143
144 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
145
146         webkit-test-results.appspot.com loads the dashboard for Chromium by default
147         https://bugs.webkit.org/show_bug.cgi?id=114381
148
149         Reviewed by Benjamin Poulain.
150
151         Changed the defaults.
152
153         * TestResultServer/static-dashboards/builders.js:
154         * TestResultServer/static-dashboards/dashboard_base.js:
155         (currentBuilderGroupCategory):
156
157 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
158
159         Remove Chromium EWS bots from the queue status server
160         https://bugs.webkit.org/show_bug.cgi?id=113988
161
162         Reviewed by Benjamin Poulain.
163
164         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
165
166         * QueueStatusServer/app.yaml:
167         * QueueStatusServer/config/queues.py:
168         * QueueStatusServer/model/queues.py:
169         (Queue.short_name):
170         (Queue.display_name):
171         * QueueStatusServer/model/queues_unittest.py:
172         (QueueTest.test_short_name):
173         (QueueTest.test_display_name):
174         (QueueTest.test_name_with_underscores):
175         * QueueStatusServer/templates/activebots.html:
176
177 2013-04-10  Ojan Vafai  <ojan@chromium.org>
178
179         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
180         https://bugs.webkit.org/show_bug.cgi?id=114370
181
182         Reviewed by Ryosuke Niwa.
183
184         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
185         Unfortunately, there's no way to test this until this is committed and there is
186         a master restart.
187
188         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
189         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
190         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
194         * TestResultServer/generate_builders_json.py:
195         * TestResultServer/static-dashboards/dashboard_base.js:
196         * TestResultServer/static-dashboards/loader.js:
197
198 2013-04-10  Glenn Adams  <glenn@skynav.com>
199
200         [Qt] Fix regression to test-webkitpy.
201         https://bugs.webkit.org/show_bug.cgi?id=114368
202
203         Reviewed by Ryosuke Niwa.
204
205         * Scripts/webkitpy/layout_tests/port/factory.py:
206         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
207         (PortFactory.get): Remove obsolete chromium port related code.
208         * Scripts/webkitpy/layout_tests/port/mac.py:
209         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
210
211 2013-04-10  Anders Carlsson  <andersca@apple.com>
212
213         Remove unneeded headers from FrameLoader.h
214         https://bugs.webkit.org/show_bug.cgi?id=114223
215
216         Reviewed by Geoffrey Garen.
217
218         Add back headers implicitly included by other headers.
219
220         * WebKitTestRunner/WorkQueueManager.cpp:
221
222 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
223
224         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
225         https://bugs.webkit.org/show_bug.cgi?id=114365
226
227         Reviewed by Martin Robinson.
228
229         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
230         The patch addresses crashes in the tally_event_reply method. It is already committed into the
231         at-spi2-atk source tree and will be available with the next stable release, after which the
232         patch should be removed and the dependency version bumped.
233
234         * gtk/jhbuild.modules:
235         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
236
237 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
238
239         [WinCairo] Unreviewed build fix. Correct DropBox download link.
240
241         * Scripts/update-webkit-wincairo-libs: Revise download URL to
242         match change in DropBox server behavior.
243
244 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
245
246         Removed an annoying message from svn-create-patch
247         https://bugs.webkit.org/show_bug.cgi?id=114332
248
249         Reviewed by Alexey Proskuryakov.
250
251         I see this message basically every time I write a patch, so it must not
252         be true.
253
254         * Scripts/svn-create-patch:
255         (generateDiff):
256
257 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
258
259         [GTK] Add support for Page Visibility
260         https://bugs.webkit.org/show_bug.cgi?id=97324
261
262         Reviewed by Sam Weinig.
263
264         Implemented test runner API for page visibility layout tests.
265
266         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
267         (TestRunner::resetPageVisibility):
268         (TestRunner::setPageVisibility):
269         * Scripts/webkitperl/FeatureList.pm:
270
271 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
272
273         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
274         https://bugs.webkit.org/show_bug.cgi?id=114342
275
276         Reviewed by Gyuyoung Kim.
277
278         Commit 148033 only added an implementation for the Mac port, which made
279         other ports fail most tests since loading the injected bundle failed
280         with a missing symbol.
281
282         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
283         (WTR::AccessibilityUIElement::pathDescription):
284
285 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
286
287         [EFL] Add spell checking option to MiniBrowser
288         https://bugs.webkit.org/show_bug.cgi?id=114282
289
290         Reviewed by Ryosuke Niwa.
291
292         Spell checking is enabled by adding a flag (t/text-checking)
293         with launching MiniBrowser.
294
295         * MiniBrowser/efl/main.c:
296         (window_create):
297         (elm_main):
298
299 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
300
301         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
302         https://bugs.webkit.org/show_bug.cgi?id=113281
303
304         Reviewed by Darin Adler.
305
306         * Scripts/run-gtk-tests:
307         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
308
309 2013-04-09  Glenn Adams  <glenn@skynav.com>
310
311         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
312
313         Unreviewed.
314
315         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
316         (RunTest.test_build_check):
317
318 2013-04-09  Glenn Adams  <glenn@skynav.com>
319
320         [webkitpy] Remove chromium ports.
321         https://bugs.webkit.org/show_bug.cgi?id=114326
322
323         Reviewed by Dirk Pranke.
324
325         As a side effect, also:
326
327         - remove chromium builders from webkitpy.layout_tests.port.builders
328         - remove chromium builders from rebaseline
329         - rewrite chromium dependent tests in rebaseline_unittest
330         - remove chromium platform from garden-o-matic
331         - select apple platform as default platform in garden-o-matic
332         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
333
334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
336         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
337         (BaselineOptimizerTest.test_move_baselines):
338         (BaselineOptimizerTest.test_efl):
339         (BaselineOptimizerTest.test_no_add_mac_future):
340         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
341         (BaselineOptimizerTest.test_common_directory_includes_root):
342         (BaselineOptimizerTest.test_complex_shadowing):
343         (BaselineOptimizerTest.test_virtual_ports_filtered):
344         * Scripts/webkitpy/layout_tests/port/builders.py:
345         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
346         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
347         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
348         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
349         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
350         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
351         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
352         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
353         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
354         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
355         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
356         * Scripts/webkitpy/layout_tests/port/factory.py:
357         (platform_options):
358         (PortFactory):
359         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
360         (FactoryTest.test_qt):
361         (FactoryTest.test_get_from_builder_name):
362         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
363         (RunTest.test_build_check):
364         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
365         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
366         * Scripts/webkitpy/tool/commands/rebaseline.py:
367         (Rebaseline._builders_to_pull_from):
368         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
369         (_BaseTestCase):
370         (_BaseTestCase.setUp):
371         (TestRebaselineTest.setUp):
372         (TestRebaselineTest.test_baseline_directory):
373         (test_rebaseline_updates_expectations_file):
374         (test_rebaseline_does_not_include_overrides):
375         (test_rebaseline_test):
376         (test_rebaseline_test_and_print_scm_changes):
377         (test_rebaseline_and_copy_test):
378         (test_rebaseline_and_copy_test_no_existing_result):
379         (test_rebaseline_and_copy_test_with_lion_result):
380         (test_rebaseline_and_copy_no_overwrite_test):
381         (TestRebaselineExpectations.test_rebaseline_expectations):
382
383 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
384
385         newcommitbot (WKR) requires a subversion checkout
386         https://bugs.webkit.org/show_bug.cgi?id=114309
387
388         Reviewed by Benjamin Poulain.
389
390         Directly talk to the subversion server instead of relying on a local checkout.
391         This allows us to run WKR off of a git clone.
392
393         * Scripts/webkitpy/tool/commands/newcommitbot.py:
394         (NewCommitBot.next_work_item):
395         (NewCommitBot.process_work_item):
396
397 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
398
399         webkitbot refers to sheriffbot in help
400         https://bugs.webkit.org/show_bug.cgi?id=114307
401
402         Reviewed by Benjamin Poulain.
403
404         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
405
406         * Scripts/webkitpy/tool/bot/irc_command.py:
407         (Help):
408         (Help.execute):
409         (RollChromiumDEPS.execute):
410         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
411         (IRCBotTest.test_help):
412         * Scripts/webkitpy/tool/bot/sheriff.py:
413         (Sheriff.name):
414
415 2013-04-06  Roger Fong  <roger_fong@apple.com>
416
417         Kill old processes between runs on WinEWS bots.
418         Temporarily disable tests to let bots catch up again.
419
420         * EWSTools/start-queue-win.sh:
421         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
422         (WinEWS):
423
424 2013-04-09  Glenn Adams  <glenn@skynav.com>
425
426         [webkitpy] Remove chromium deprecated port support.
427         https://bugs.webkit.org/show_bug.cgi?id=114228
428
429         Reviewed by Ryosuke Niwa.
430
431         * Scripts/webkitpy/common/config/ports.py:
432         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
433         (ChromiumPort): Removed.
434         (ChromiumAndroidPort): Removed.
435         (ChromiumXVFBPort): Removed.
436         * Scripts/webkitpy/common/config/ports_unittest.py:
437         (DeprecatedPortTest.test_chromium_port): Removed.
438         (DeprecatedPortTest.test_chromium_android_port): Removed.
439         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
440         * Scripts/webkitpy/tool/steps/update_unittest.py:
441         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
442         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
443
444 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
445
446         AX: The bounding paths should be made available through accessibility
447         https://bugs.webkit.org/show_bug.cgi?id=113817
448
449         Reviewed by David Kilzer.
450
451         Add a pathDescription property for testing so that it's possible
452         to verify that a path is being returned correctly.
453
454         * DumpRenderTree/AccessibilityUIElement.cpp:
455         (getPathDescriptionCallback):
456         (AccessibilityUIElement::pathDescription):
457         (AccessibilityUIElement::getJSClass):
458         * DumpRenderTree/AccessibilityUIElement.h:
459         (AccessibilityUIElement):
460         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
461         (_CGPathEnumerationIteration):
462         (AccessibilityUIElement::pathDescription):
463         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
464         (AccessibilityUIElement::pathDescription):
465         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
466         (WTR::AccessibilityUIElement::pathDescription):
467         (WTR):
468         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
469         (AccessibilityUIElement):
470         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
471         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
472         (WTR::AccessibilityUIElement::pathDescription):
473         (WTR):
474
475 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
476
477         [EFL] Declare TEST_THEME_DIR in a single place.
478         https://bugs.webkit.org/show_bug.cgi?id=114285
479
480         Reviewed by Anders Carlsson.
481
482         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
483
484         * DumpRenderTree/efl/CMakeLists.txt:
485         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
486         (DumpRenderTreeChrome::createView):
487         (DumpRenderTreeChrome::createInspectorView):
488         (DumpRenderTreeChrome::initialize):
489         (DumpRenderTreeChrome::onDownloadRequest):
490         * EWebLauncher/CMakeLists.txt:
491         * EWebLauncher/main.c:
492         (findThemePath):
493         * EWebLauncher/url_bar.c:
494         (url_bar_add):
495         * MiniBrowser/efl/CMakeLists.txt:
496         * MiniBrowser/efl/main.c:
497         (window_create):
498         * TestWebKitAPI/PlatformEfl.cmake:
499         * TestWebKitAPI/efl/PlatformWebView.cpp:
500         (TestWebKitAPI::PlatformWebView::PlatformWebView):
501         * WebKitTestRunner/PlatformEfl.cmake:
502         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
503         (WTR::PlatformWebView::PlatformWebView):
504
505 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
506
507         [GTK][AC] upversion of clutter and its dependecy
508         https://bugs.webkit.org/show_bug.cgi?id=114016
509
510         Reviewed by Gustavo Noronha Silva.
511
512         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
513
514         * gtk/jhbuild-optional.modules:
515
516 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
517
518         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
519         https://bugs.webkit.org/show_bug.cgi?id=89875
520
521         Reviewed by Maciej Stachowiak.
522
523         Add unit tests to verify if the handling of the open, openat, creat syscall
524         is being done right. We check if the Read/Write/ReadAndWrite permissions
525         are respected, if the canonical path is being resolved and if
526         the permissions are falling back to the topmost parent directory with a
527         policy set when the directory being opened has no policy.
528
529         We also test if any attempt of blocking SIGSYS is silently ignored.
530         SIGSYS cannot be blocked because in it's handler is where we hook
531         syscalls to the broker process.
532
533         Also added libseccomp to EFL's jhbuild to make the life of developers
534         willing to help easier.
535
536         * Scripts/webkitperl/FeatureList.pm:
537         * TestWebKitAPI/PlatformEfl.cmake:
538         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
539         (TestWebKitAPI):
540         (SeccompEnvironment):
541         (TestWebKitAPI::SeccompEnvironment::SetUp):
542         (TestWebKitAPI::SeccompEnvironment::TearDown):
543         (TestWebKitAPI::dummyHandler):
544         (TestWebKitAPI::TEST):
545         (TestWebKitAPI::stressTest):
546         * efl/jhbuild.modules:
547         * qmake/mkspecs/features/features.pri:
548
549 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
550
551         REGRESSION: Autocorrection doesn't work in DumpRenderTree
552         https://bugs.webkit.org/show_bug.cgi?id=113846
553
554         Reviewed by Alexey Proskuryakov.
555
556         The problem was that we were replacing NSSpellCheck's dictionary with our own
557         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
558
559         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
560         and "would" respectively in DumpRenderTree.
561
562         * DumpRenderTree/mac/DumpRenderTree.mm:
563         (resetDefaultsToConsistentValues):
564
565 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
566
567         Remove the gyp files for Tools
568         https://bugs.webkit.org/show_bug.cgi?id=114248
569
570         Reviewed by Ryosuke Niwa.
571
572         * DumpRenderTree/DumpRenderTree.gyp: Removed.
573         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
574         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
575         * DumpRenderTree/DumpRenderTree.gypi: Removed.
576         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
577         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
578         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
579         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
580
581 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
582
583         WKR (new-commit-bot) is too slow
584         https://bugs.webkit.org/show_bug.cgi?id=110087
585
586         Reviewed by Geoffrey Garen.
587
588         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
589         Just run "svn log -r <revision>" instead to cut down the delay.
590
591         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
592
593         * Scripts/webkitpy/tool/commands/newcommitbot.py:
594         (NewCommitBot):
595         (NewCommitBot.next_work_item):
596         (NewCommitBot._is_empty_log):
597         (NewCommitBot._update_checkout):
598
599 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
600
601         Build fix. Can't remove appendCustomBuildFlags.
602
603         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
604         (appendCustomBuildFlags):
605
606 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
607
608         Remove Chromium builders from build.webkit.org
609         https://bugs.webkit.org/show_bug.cgi?id=113990
610
611         Reviewed by Benjamin Poulain.
612
613         Removed.
614
615         * BuildSlaveSupport/build.webkit.org-config/config.json:
616         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
617         (InstallGtkDependencies):
618         (RunUnitTests.start):
619         (RunWebKit2Tests.start):
620         (Factory.__init__):
621         (unitTestsSupported):
622         (TestFactory.__init__):
623         (BuildAndTestFactory.__init__):
624         (BuildAndPerfTestFactory.__init__):
625         (BuildAndPerfTestWebKit2Factory.__init__):
626         (DownloadAndPerfTestFactory.__init__):
627         (loadBuilderConfig):
628         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
629
630 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
631
632         Remove HTML Notification
633         https://bugs.webkit.org/show_bug.cgi?id=114231
634
635         Reviewed by Ryosuke Niwa.
636
637         * qmake/mkspecs/features/features.pri:
638
639 2013-04-08  Glenn Adams  <glenn@skynav.com>
640
641         Remove chromium EWS support, and fix broken test.
642         https://bugs.webkit.org/show_bug.cgi?id=114221
643
644         Reviewed by Ryosuke Niwa.
645
646         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
647         (AbstractChromiumEWS): Removed.
648         (ChromiumLinuxEWS): Removed.
649         (ChromiumLinuxDebugEWS): Removed.
650         (ChromiumWindowsEWS): Removed.
651         (ChromiumAndroidEWS): Removed.
652         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
653         (EarlyWarningSystemTest): Fix misspelled class name.
654         (test_ewses): Fix entry point name to ensure test is run.
655
656 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
657
658         [WIN] Remove WebKit2 source code
659         https://bugs.webkit.org/show_bug.cgi?id=114096
660
661         Reviewed by Anders Carlsson.
662
663         Remove the windows specific parts of the MiniBrowser.
664
665         * MiniBrowser/MiniBrowser.vcproj: Removed.
666         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
667         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
668         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
669         * MiniBrowser/win/BrowserView.cpp: Removed.
670         * MiniBrowser/win/BrowserView.h: Removed.
671         * MiniBrowser/win/BrowserWindow.cpp: Removed.
672         * MiniBrowser/win/BrowserWindow.h: Removed.
673         * MiniBrowser/win/MiniBrowser.cpp: Removed.
674         * MiniBrowser/win/MiniBrowser.h: Removed.
675         * MiniBrowser/win/MiniBrowser.rc: Removed.
676         * MiniBrowser/win/main.cpp: Removed.
677         * MiniBrowser/win/resource.h: Removed.
678         * MiniBrowser/win/stdafx.cpp: Removed.
679         * MiniBrowser/win/stdafx.h: Removed.
680
681 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
682
683         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
684
685         * Scripts/webkitpy/common/config/irc.py:
686
687 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
688
689         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
690         https://bugs.webkit.org/show_bug.cgi?id=113139
691
692         Reviewed by Anders Carlsson.
693
694         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
695         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
696         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
697         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
698         (ToStringAndValueOfObject):
699         (ToStringAndValueOfObject::ToStringAndValueOfObject):
700         (ScriptableObject):
701         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
702         (ToStringAndValueOfObject::ScriptableObject::invoke):
703         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
704         (ToStringAndValueOfObject::NPP_GetValue):
705         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
706         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
707         * GNUmakefile.am:
708
709 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
710
711         [GTK] Bump gnome-themes-standard to 3.6.0
712         https://bugs.webkit.org/show_bug.cgi?id=114155
713
714         Reviewed by Martin Robinson.
715
716         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
717         dependency of gnome-themes-standard accordingly.
718
719 2013-04-08  David Levin  <levin@chromium.org>
720
721         Remove my watchlist entries.
722         https://bugs.webkit.org/show_bug.cgi?id=114180
723
724         Reviewed by Adam Barth.
725
726         * Scripts/webkitpy/common/config/committers.py:
727         * Scripts/webkitpy/common/config/watchlist:
728
729 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
730
731         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
732         https://bugs.webkit.org/show_bug.cgi?id=114161
733
734         Reviewed by Gyuyoung Kim.
735
736         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
737         as it is crashing due to Bug 111074.
738
739         * TestWebKitAPI/PlatformEfl.cmake:
740
741 2013-04-07  David Kilzer  <ddkilzer@apple.com>
742
743         Remove the rest of SVG_DOM_OBJC_BINDINGS
744         <http://webkit.org/b/114112>
745
746         Reviewed by Geoffrey Garen.
747
748         * Scripts/webkitperl/FeatureList.pm:
749         - Remove --svg-dom-objc-bindings switch.
750         * qmake/mkspecs/features/features.pri:
751         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
752
753 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
754
755         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
756         https://bugs.webkit.org/show_bug.cgi?id=114089
757
758         Reviewed by Chris Fleizach.
759
760         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
761         * DumpRenderTree/AccessibilityController.cpp:
762         * DumpRenderTree/AccessibilityUIElement.cpp:
763         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
764         (DumpRenderTreeChrome::DumpRenderTreeChrome):
765         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
766         (DumpRenderTreeChrome):
767
768 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
769
770         Build fix after r147857, remove remaining USE(JSC) guards.
771
772         Unreviewed.
773
774         * DumpRenderTree/config.h:
775         * TestWebKitAPI/config.h:
776         * WebKitTestRunner/config.h:
777
778 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
779
780         Rename sheriffbot to webkitbot
781         https://bugs.webkit.org/show_bug.cgi?id=114109
782
783         Reviewed by Benjamin Poulain.
784
785         Renamed since sheriffbot will be used in Blink.
786
787         * Scripts/webkitpy/tool/commands/sheriffbot.py:
788         (SheriffBot):
789         (SheriffBot.begin_work_queue):
790
791 2013-04-06  Oliver Hunt  <oliver@apple.com>
792
793         Unify the many and varied stack trace mechanisms, and make the result sane.
794         https://bugs.webkit.org/show_bug.cgi?id=114072
795
796         Reviewed by Filip Pizlo.
797
798         The commandline jsc executable no longer requires arguments, so
799         I've made run-jsc work without them.
800
801         * Scripts/run-jsc:
802
803 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
804
805         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
806         https://bugs.webkit.org/show_bug.cgi?id=114086
807
808         Reviewed by Tim Horton.
809
810         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
811
812 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
813
814         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
815         https://bugs.webkit.org/show_bug.cgi?id=114083
816
817         Reviewed by Ryosuke Niwa.
818
819         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
820         in TestWebKitAPI and WebKitTestRunner.
821
822         * TestWebKitAPI/config.h:
823         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
824         (TestWebKitAPI::InjectedBundleController::platformInitialize):
825         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
826         (WTR::InjectedBundle::platformInitialize):
827
828 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
829
830         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
831         https://bugs.webkit.org/show_bug.cgi?id=114094
832
833         Reviewed by Anders Carlsson.
834
835         * Scripts/run-jsc:
836
837 2013-04-05  Ojan Vafai  <ojan@chromium.org>
838
839         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
840         https://bugs.webkit.org/show_bug.cgi?id=114080
841
842         Reviewed by Ryosuke Niwa.
843
844         This way, the WebKit and Blink dashboard code can change as appropriate without
845         needing to consider the other project's needs. This still doesn't update the
846         buildbots to upload to the new location, or the dashboard code to pull the
847         results.json files from the new location, but it at least allows for changing the
848         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
849
850         * TestResultServer/app.yaml:
851
852 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
853
854         Re-enable testing on the commit queue
855         https://bugs.webkit.org/show_bug.cgi?id=114078
856
857         Reviewed by Darin Adler.
858
859         Re-enabled the feature and the associated tests.
860
861         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
862         (CommitQueueTask.run):
863         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
864         (CommitQueueTaskTest._run_through_task):
865         * Scripts/webkitpy/tool/commands/queues_unittest.py:
866         (CommitQueueTest._mock_test_result):
867
868 2013-04-05  Oliver Hunt  <oliver@apple.com>
869
870         Unify the many and varied stack trace mechanisms, and make the result sane.
871         https://bugs.webkit.org/show_bug.cgi?id=114072
872
873         Reviewed by Filip Pizlo.
874
875         The commandline jsc executable no longer requires arguments, so
876         I've made run-jsc work without them.
877
878         * Scripts/run-jsc:
879
880 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
881
882         AX: Make SVG Group containers accessible elements
883         https://bugs.webkit.org/show_bug.cgi?id=113939
884
885         Reviewed by Simon Fraser.
886
887         Implement axController.elementAtPoint for iOS.
888         Implement a correct version of clickPoint for iOS.
889
890         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
891         (AccessibilityController::elementAtPoint):
892         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
893         (AccessibilityUIElement::clickPointX):
894         (AccessibilityUIElement::clickPointY):
895
896 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
897
898         Unreviewed, rolling out r147773 and r147774.
899         http://trac.webkit.org/changeset/147773
900         http://trac.webkit.org/changeset/147774
901         https://bugs.webkit.org/show_bug.cgi?id=114056
902
903         Causing some exceptions on AppEngine I don't understand
904         (Requested by rniwa on #webkit).
905
906         * QueueStatusServer/config/queues.py:
907         * QueueStatusServer/model/queues.py:
908         (Queue.short_name):
909         (Queue.display_name):
910         * QueueStatusServer/model/queues_unittest.py:
911         (QueueTest.test_short_name):
912         (QueueTest.test_display_name):
913         (QueueTest.test_name_with_underscores):
914
915 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
916
917         Fixed run-bindings-tests by removing V8
918         https://bugs.webkit.org/show_bug.cgi?id=114053
919
920         Reviewed by Benjamin Poulain.
921
922         * Scripts/run-bindings-tests:
923         (main):
924
925 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
926
927         Build fix.
928
929         * QueueStatusServer/model/queues.py:
930         (Queue.short_name):
931         (Queue.display_name):
932
933 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
934
935         Remove Chromium EWS bots from the queue status server
936         https://bugs.webkit.org/show_bug.cgi?id=113988
937
938         Reviewed by Benjamin Poulain.
939
940         Removed Chromium EWS bots.
941
942         * QueueStatusServer/config/queues.py:
943         * QueueStatusServer/model/queues.py:
944         (Queue.short_name):
945         (Queue.display_name):
946         * QueueStatusServer/model/queues_unittest.py:
947         (QueueTest.test_short_name):
948         (QueueTest.test_display_name):
949         (QueueTest.test_name_with_underscores):
950
951 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
952
953         [EFL] Enable indexed database
954         https://bugs.webkit.org/show_bug.cgi?id=107248
955
956         Reviewed by Alexis Menard.
957
958         * Scripts/webkitperl/FeatureList.pm:
959
960 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
961
962         Remove vestiges of Chromium bits from watchlists.
963         https://bugs.webkit.org/show_bug.cgi?id=114047
964
965         Reviewed by Ryosuke Niwa.
966
967         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
968
969 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
970
971         Add James Craig to the contributors list.
972
973         * Scripts/webkitpy/common/config/committers.py:
974
975 2013-04-04  Kent Tamura  <tkent@chromium.org>
976
977         Remove ChromiumPublicApi pattern, and cc/message rules for it.
978
979         * Scripts/webkitpy/common/config/watchlist:
980
981 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
982
983         Temporarily disable the Python unittests broken by the commit queue not running layout tests
984         https://bugs.webkit.org/show_bug.cgi?id=113997
985
986         Reviewed by Ryosuke Niwa.
987
988         Disable the tests until Ryosuke gets the time and hardware to have
989         a testing commit-queue.
990
991         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
992         (CommitQueueTaskTest):
993         * Scripts/webkitpy/tool/commands/queues_unittest.py:
994         (CommitQueueTest):
995
996 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
997
998         Remove Chromium builders from build.webkit.org
999         https://bugs.webkit.org/show_bug.cgi?id=113990
1000
1001         Reviewed by Benjamin Poulain.
1002
1003         Land the part to disable triggering of Chromium builders first so that we may start
1004         deleting more Chromium code that breaks the update step.
1005
1006         * BuildSlaveSupport/build.webkit.org-config/config.json:
1007
1008 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1009
1010         Remove Chromium's DumpRenderTree
1011         https://bugs.webkit.org/show_bug.cgi?id=113989
1012
1013         Reviewed by Kent Tamura.
1014
1015         On second thought, let's not go to Camelot. It is a silly place.
1016
1017         * DumpRenderTree/mac/DumpRenderTree.mm:
1018         (resetDefaultsToConsistentValues):
1019
1020 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1021
1022         Nixed the defunct chromium folder from DumpRenderTree
1023         https://bugs.webkit.org/show_bug.cgi?id=113993
1024
1025         Reviewed by Ryosuke Niwa.
1026
1027         * DumpRenderTree/chromium: Removed.
1028         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1029         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1030         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1031         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1032         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1033         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1034         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1035         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1036         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1037         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1038         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1039         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1040         * DumpRenderTree/chromium/Task.cpp: Removed.
1041         * DumpRenderTree/chromium/Task.h: Removed.
1042         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1043         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1044         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1045         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1046         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1047         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1048         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1049         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1050         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1051         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1052         * DumpRenderTree/chromium/TestRunner: Removed.
1053         * DumpRenderTree/chromium/TestRunner/public: Removed.
1054         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1055         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1056         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1057         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1058         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1059         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1060         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1061         * DumpRenderTree/chromium/TestRunner/src: Removed.
1062         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1063         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1064         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1065         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1066         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1067         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1068         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1069         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1070         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1071         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1072         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1073         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1074         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1075         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1076         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1077         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1078         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1079         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1080         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1081         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1082         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1083         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1084         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1085         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1086         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1087         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1088         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1089         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1090         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1091         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1092         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1093         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1094         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1095         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1096         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1097         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1098         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1099         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1100         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1101         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1102         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1103         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1104         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1105         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1106         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1107         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1108         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1109         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1110         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1111         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1112         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1113         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1114         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1115         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1116         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1117         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1118         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1119         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1120         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1121         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1122         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1123         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1124         * DumpRenderTree/chromium/TestShell.h: Removed.
1125         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1126         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1127         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1128         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1129         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1130         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1131         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1132         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1133         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1134         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1135         * DumpRenderTree/chromium/config.h: Removed.
1136         * DumpRenderTree/chromium/fonts.conf: Removed.
1137
1138 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1139
1140         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1141
1142         Rubber stamped by Benjamin Poulain.
1143
1144         * RebaselineQueueServer: Removed.
1145         * RebaselineQueueServer/app.yaml: Removed.
1146         * RebaselineQueueServer/handlers: Removed.
1147         * RebaselineQueueServer/handlers/__init__.py: Removed.
1148         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1149         * RebaselineQueueServer/handlers/pages.py: Removed.
1150         * RebaselineQueueServer/index.yaml: Removed.
1151         * RebaselineQueueServer/main.py: Removed.
1152         * RebaselineQueueServer/model: Removed.
1153         * RebaselineQueueServer/model/__init__.py: Removed.
1154         * RebaselineQueueServer/model/queueentry.py: Removed.
1155         * RebaselineQueueServer/static: Removed.
1156         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1157         * RebaselineQueueServer/static/styles.css: Removed.
1158         * RebaselineQueueServer/templates: Removed.
1159         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1160         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1161         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1162         * RebaselineQueueServer/templates/home.html: Removed.
1163
1164 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1165
1166         Fix setup-commit-queue and temporarily disable testing on commit-queue
1167         https://bugs.webkit.org/show_bug.cgi?id=113979
1168
1169         Reviewed by Benjamin Poulain.
1170
1171         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1172         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1173
1174         * EWSTools/setup-commit-queue.sh:
1175         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1176         (CommitQueueTask.run):
1177
1178 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1179
1180         temporarily make flakiness dashboard work again webkit.org bots
1181         https://bugs.webkit.org/show_bug.cgi?id=113972
1182
1183         Reviewed by Ojan Vafai.
1184
1185         This patch disables the chromium.org layout test bots TestExpectations
1186         parsing temporarily until we can work out the right way to split into
1187         two instances for webkit.org and chromium.org and figure out which
1188         code to delete where :).
1189
1190         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1191
1192 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1193
1194         Fix webkitpy tests after r147678.
1195
1196         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1197         (CommitQueueTest.test_commit_queue):
1198         (test_manual_reject_during_processing):
1199
1200 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1201
1202         The commit queue should use Mac MountainLion port
1203         https://bugs.webkit.org/show_bug.cgi?id=113971
1204
1205         Reviewed by Lucas Forschler.
1206
1207         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1208         * Scripts/webkitpy/tool/commands/queues.py:
1209         (CommitQueue):
1210
1211 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1212
1213         turn off running tests on chromium linux EWS bots
1214         https://bugs.webkit.org/show_bug.cgi?id=113959
1215
1216         Reviewed by Geoffrey Garen.
1217
1218         Now that the Chromium port is no longer being maintained
1219         there's little point in running the tests. Soon we should
1220         just shut this bot off altogether.
1221
1222         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1223         (ChromiumLinuxEWS):
1224
1225 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1226
1227         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1228
1229         * Scripts/webkitpy/common/config/watchlist:
1230
1231 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1232
1233         Indentation fix to get webkit-patch working again after r147625
1234
1235         Unreviewed.
1236
1237         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1238         (MacEWS):
1239         (MacWK2EWS):
1240
1241 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1242
1243         Turn tests back on for Mac WK1/WK2 EWS.
1244         
1245         Unreviewed.
1246         
1247         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1248         (MacEWS):
1249         (MacWK2EWS):
1250
1251 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1252
1253         [GTK][WK2] MiniBrowser custom URI scheme support
1254         https://bugs.webkit.org/show_bug.cgi?id=112419
1255
1256         Reviewed by Carlos Garcia Campos.
1257
1258         Add support for about URIs in MiniBrowser. An example about page is show
1259         with URI "about:minibrowser", the rest of the cases it will show a
1260         proper message explaining that the about page didn't exist.
1261
1262         Internally it uses "minibrowser-about" prefix instead of "about", but
1263         from the user point of view it works with "about" prefix.
1264
1265         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1266         (getInternalURI): Method to convert URIs from "about" prefix to
1267         "minibrowser-about".
1268         (getExternalURI): Opposite method.
1269         (webViewURIChanged): Use "about" prefix to show the URI to users.
1270         (webViewEnterFullScreen): Ditto.
1271         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1272         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1273         (aboutURISchemeRequestCallback): Callback to manage about calls.
1274         (main): Register the URI scheme to manage about URIs.
1275
1276 2013-04-03  Roger Fong  <roger_fong@apple.com>
1277
1278         Re-enable WinEWS tests.
1279
1280         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1281         (WinEWS):
1282
1283 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1284
1285         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1286         https://bugs.webkit.org/show_bug.cgi?id=113883
1287
1288         Reviewed by Martin Robinson.
1289
1290         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1291         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1292         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1293
1294 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1295
1296         [GTK] Include Pango in jhbuild-optional.modules
1297         https://bugs.webkit.org/show_bug.cgi?id=113878
1298
1299         Reviewed by Martin Robinson.
1300
1301         Since r147547 Pango 1.32.0 is required. Including the module in the
1302         JHBuild optional moduleset.
1303
1304         * gtk/jhbuild-optional.modules: Add Pango module.
1305
1306 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1307
1308         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1309         https://bugs.webkit.org/show_bug.cgi?id=113864
1310
1311         Moving setDefersLoading from TestRunnerQt to TestRunner
1312         requires access to the non-Qt TestRunner.
1313         As long as we instantiate both TestRunner and TestRunnerQt,
1314         we need a separate getter for the non-Qt TestRunner instance.
1315
1316         Reviewed by Simon Hausmann.
1317
1318         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1319         (WebPage::resetSettings):
1320         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1321         (DumpRenderTree::jscTestRunner):
1322         * DumpRenderTree/qt/TestRunnerQt.cpp:
1323         (TestRunner::setDefersLoading):
1324             Moving setDefersLoading from TestRunnerQt
1325             to TestRunner.
1326         * DumpRenderTree/qt/TestRunnerQt.h:
1327         (TestRunnerQt):
1328
1329 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1330
1331         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1332         https://bugs.webkit.org/show_bug.cgi?id=104779
1333
1334         Reviewed by Carlos Garcia Campos.
1335
1336         * Scripts/run-gtk-tests:
1337         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1338         passing in current trunk.
1339
1340 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1341
1342         Fix HAVE(QTTESTSUPPORT) logic
1343
1344         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1345         resulting in HAVE(QTTESTSUPPORT) never being true.
1346         Move that logic down in sanitizeFeatures.
1347
1348         Rubber-stamped by Tor Arne Vestbø.
1349
1350         * qmake/mkspecs/features/features.prf:
1351
1352 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1353
1354         [GTK] Bump required versions of some dependencies
1355         https://bugs.webkit.org/show_bug.cgi?id=113282
1356
1357         Reviewed by Martin Robinson.
1358
1359         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1360
1361 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1362
1363         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1364         https://bugs.webkit.org/show_bug.cgi?id=113809
1365
1366         Reviewed by Philippe Normand.
1367
1368         Newer Linux kernels have removed some deprecated macros from v4l2
1369         headers, causing gst-plugins-good's build to break. We don't need it
1370         right now, so just disable it.
1371
1372         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1373
1374 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1375
1376         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1377         https://bugs.webkit.org/show_bug.cgi?id=113535
1378
1379         Reviewed by Simon Hausmann.
1380
1381         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1382
1383         * qmake/mkspecs/features/features.prf:
1384
1385 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1386
1387         [Qt] Move logic of simple forwarding functions to TestRunner.
1388         https://bugs.webkit.org/show_bug.cgi?id=113863
1389
1390         Reviewed by Simon Hausmann.
1391
1392         * DumpRenderTree/qt/TestRunnerQt.cpp:
1393         (TestRunner::setTextDirection):
1394         (TestRunner::goBack):
1395         (TestRunner::evaluateScriptInIsolatedWorld):
1396         (TestRunner::addUserStyleSheet):
1397         * DumpRenderTree/qt/TestRunnerQt.h:
1398         (TestRunnerQt):
1399
1400 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1401
1402         [Qt] Disable media support using QuickTime if deployment target != SDK
1403
1404         We link to a single libWebKitSystemInterface static lib, so unless the
1405         deployment target matches the SDK let's not pretend like we'll be able
1406         to run on anything lower than the SDK version.
1407
1408         Reviewed by Simon Hausmann.
1409
1410         * qmake/mkspecs/features/features.prf:
1411
1412 2013-04-02  James Craig  <james@cookiecrook.com>
1413
1414         AXRoleDescripton for DL is "list"; should be "description list"
1415         https://bugs.webkit.org/show_bug.cgi?id=111665
1416
1417         Reviewed by Chris Fleizach.
1418
1419         Defining the role and description strings.
1420
1421         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1422
1423 2013-04-02  Roger Fong  <roger_fong@apple.com>
1424
1425         Unreviewed. Disable running tests on Win EWS queue.
1426
1427         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1428         (WinEWS):
1429
1430 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1431
1432         Disable running tests on the MAC WK2 EWS queue.
1433         
1434         Unreviewed.
1435         
1436         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1437         (MacWK2EWS):
1438
1439 2013-04-02  Julie Parent  <jparent@chromium.org>
1440
1441         Dashboard refactor: Move dashboard specific history related features to History.
1442         https://bugs.webkit.org/show_bug.cgi?id=113717
1443
1444         Reviewed by Ojan Vafai.
1445         
1446         Each dashboard now creates its own History object, with a custom
1447         configuration. This changes from just overriding global functions
1448         to passing in callbacks for generatePage, handleValidHashParameter,
1449         and handleQueryParameterChange. Same with passing in defaultStateValues
1450         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1451         variables.
1452         
1453         All functions related to these features are now (mostly) private
1454         function on History. 
1455         
1456         Loader no longer needs a loadingComplete callback, since it can just
1457         initialize the history object itself.
1458
1459         * TestResultServer/static-dashboards/aggregate_results.js:
1460         (handleValidHashParameter):
1461         * TestResultServer/static-dashboards/dashboard_base.js:
1462         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1463         (generatePage):
1464         (.switch.return):
1465         (handleQueryParameterChange):
1466         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1467         (resetGlobals):
1468         * TestResultServer/static-dashboards/history.js:
1469         (.):
1470         * TestResultServer/static-dashboards/loader.js:
1471         (.):
1472         * TestResultServer/static-dashboards/loader_unittests.js:
1473         * TestResultServer/static-dashboards/timeline_explorer.js:
1474         (generatePage):
1475         (initCurrentBuilderTestResults):
1476         * TestResultServer/static-dashboards/treemap.js:
1477         (generatePage):
1478         (.switch.return):
1479         (handleQueryParameterChange):
1480
1481 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1482
1483         Unreviewed, rolling out r147401.
1484         http://trac.webkit.org/changeset/147401
1485         https://bugs.webkit.org/show_bug.cgi?id=113767
1486
1487         The patch makes it extremely hard to set up the dependencies
1488         properly on the GTK builders (Requested by zdobersek on
1489         #webkit).
1490
1491         * gtk/jhbuild.modules:
1492
1493 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1494
1495         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1496         https://bugs.webkit.org/show_bug.cgi?id=113382
1497
1498         Reviewed by Gyuyoung Kim.
1499
1500         Do not show the empty tooltip box if the text is null.
1501
1502         * MiniBrowser/efl/main.c:
1503         (popup_menu_populate):
1504
1505 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1506
1507         [GTK] Bump required versions of some dependencies
1508         https://bugs.webkit.org/show_bug.cgi?id=113282
1509
1510         Reviewed by Martin Robinson.
1511
1512         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1513
1514 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1515
1516         Unreviewed, rolling out r147319.
1517         http://trac.webkit.org/changeset/147319
1518         https://bugs.webkit.org/show_bug.cgi?id=113707
1519
1520         The unit test is still failing on the buildbot (Requested by
1521         zdobersek on #webkit).
1522
1523         * Scripts/run-gtk-tests:
1524         (TestRunner):
1525
1526 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1527
1528         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1529         https://bugs.webkit.org/show_bug.cgi?id=104779
1530
1531         Reviewed by Carlos Garcia Campos.
1532
1533         * Scripts/run-gtk-tests:
1534         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1535         passing in current trunk.
1536
1537 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1538
1539         Unreviewed, rolling out r147289.
1540         http://trac.webkit.org/changeset/147289
1541         https://bugs.webkit.org/show_bug.cgi?id=113678
1542
1543         broke Win7 (dbg) build (Requested by shinyak|gardener on
1544         #webkit).
1545
1546         * DumpRenderTree/DumpRenderTree.gypi:
1547         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1548         (WebTestRunner):
1549         (WebUserMediaClientMock):
1550         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1551         (WebTestRunner::WebUserMediaClientMock::taskList):
1552         * Scripts/webkitpy/style/checkers/cpp.py:
1553         (check_function_definition):
1554
1555 2013-03-31  Adam Barth  <abarth@webkit.org>
1556
1557         configure-svn-config.sh fails
1558         https://codereview.chromium.org/13392007/
1559
1560         Reviewed by Eric Seidel.
1561
1562         This script was trying to use "svn checkout" to dowload a file from
1563         svn.webkit.org, but "svn checkout" only works with directories.
1564         Instead, we should use "svn export".
1565
1566         * EWSTools/configure-svn-config.sh:
1567
1568 2013-03-31  Wei Jia  <wjia@chromium.org>
1569
1570         Allow WebUserMediaClientMock to be used by client
1571         https://bugs.webkit.org/show_bug.cgi?id=113633
1572
1573         Reviewed by Adam Barth.
1574
1575         Export WebUserMediaClientMock.
1576         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1577
1578         * DumpRenderTree/DumpRenderTree.gypi:
1579         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1580         (WebUserMediaClientMock):
1581         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1582         * Scripts/webkitpy/style/checkers/cpp.py:
1583         (check_function_definition):
1584
1585 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1586
1587         Expose FeatureObserver data to WebKit clients
1588         https://bugs.webkit.org/show_bug.cgi?id=113613
1589
1590         Reviewed by Sam Weinig.
1591
1592         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1593         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1594
1595 2013-03-29  Greg Hughes  <ghughes@apple.com>
1596
1597         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1598         https://bugs.webkit.org/show_bug.cgi?id=112276
1599
1600         Reviewed by Chris Fleizach.
1601
1602         Added support to test accessibility search predicates with multiple keys.  
1603
1604         * DumpRenderTree/AccessibilityUIElement.cpp:
1605         (uiElementForSearchPredicateCallback):
1606         * DumpRenderTree/AccessibilityUIElement.h:
1607         (AccessibilityUIElement):
1608         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1609         (AccessibilityUIElement::uiElementForSearchPredicate):
1610         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1611         (AccessibilityUIElement::uiElementForSearchPredicate):
1612         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1613         (AccessibilityUIElement::uiElementForSearchPredicate):
1614         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1615         (AccessibilityUIElement::uiElementForSearchPredicate):
1616         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1617         (AccessibilityUIElement::uiElementForSearchPredicate):
1618         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1619         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1620         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1621         (AccessibilityUIElement):
1622         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1623         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1624         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1625         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1626         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1627
1628 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1629
1630         Fix a typo in r147147 to fix Mac EWS.
1631
1632         * Scripts/webkitpy/tool/commands/queues.py:
1633         (PatchProcessingQueue._new_port_name_from_old):
1634
1635 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1636
1637         [EFL] Build break with latest EFL libraries after r146265
1638         https://bugs.webkit.org/show_bug.cgi?id=113558
1639
1640         Unreviewed build fix.
1641
1642         * TestWebKitAPI/PlatformWebView.h:
1643         * WebKitTestRunner/PlatformWebView.h:
1644
1645 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1646
1647         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1648
1649         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1650         in libgcrypt build.
1651
1652 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1653
1654         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1655
1656         Unreviewed.
1657
1658         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1659         (MacEWS):
1660
1661 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1662
1663         Use the right OS name on Mac EWS instead of mac-future.
1664
1665         Rubber-stamped by Dirk Pranke.
1666
1667         * Scripts/webkitpy/tool/commands/queues.py:
1668         (PatchProcessingQueue._new_port_name_from_old):
1669         (PatchProcessingQueue.begin_work_queue):
1670         (PatchProcessingQueue._upload_results_archive_for_patch):
1671
1672 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1673
1674         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1675         https://bugs.webkit.org/show_bug.cgi?id=112546
1676
1677         Reviewed by Martin Robinson.
1678
1679         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1680         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1681
1682 2013-03-28  Ming Xie  <mxie@blackberry.com>
1683
1684         [BlackBerry] Committer Email Updates
1685         https://bugs.webkit.org/show_bug.cgi?id=113435
1686
1687         Reviewed by Rob Buis.
1688
1689         Add the @blackberry.com email address for all our BlackBerry
1690         WebKit committers. This is the first step for our email address
1691         migration.
1692
1693         * Scripts/webkitpy/common/config/committers.py:
1694
1695 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1696
1697         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1698         https://bugs.webkit.org/show_bug.cgi?id=113508
1699
1700         Reviewed by Martin Robinson.
1701
1702         Prevent the GStreamer plugin scanner to load system-wide
1703         plugins. Only the ones built in JHBuild should be loaded and used
1704         at runtime.
1705
1706         * efl/jhbuildrc:
1707         * gtk/jhbuildrc:
1708
1709 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1710
1711         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1712         https://bugs.webkit.org/show_bug.cgi?id=113386
1713
1714         Reviewed by Carlos Garcia Campos.
1715
1716         * Scripts/webkitdirs.pm:
1717         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1718         version to 3.0. Reflect this change so the builtDylibPathForName
1719         function doesn't fail to report the library as found.
1720
1721 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1722
1723         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1724         https://bugs.webkit.org/show_bug.cgi?id=113484
1725
1726         Unreviewed build fix.
1727
1728         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1729
1730         * TestWebKitAPI/CMakeLists.txt:
1731         * WebKitTestRunner/CMakeLists.txt:
1732
1733 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1734
1735         Revision for the internal jhbuild is too old
1736         https://bugs.webkit.org/show_bug.cgi?id=113324
1737
1738         Reviewed by Martin Robinson.
1739
1740         Update the minimum required version to a point where jhbuild won't
1741         fail installing packages when trying to remove a symlink to a directory.
1742
1743         * jhbuild/jhbuild-wrapper: Updated revision.
1744
1745 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1746
1747         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1748         https://bugs.webkit.org/show_bug.cgi?id=113203
1749
1750         Reviewed by Philippe Normand.
1751
1752         We build our libsoup without GNOME support. gst-plugins-good does separate
1753         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1754         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1755         build failures as the headers of those diverge. We do not use souphttpsrc, so
1756         disable it when building gst-plugins-good.
1757
1758         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1759
1760 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1761
1762         Build fix after r146852. Please another reference to the Lion leaks builder.
1763
1764         * BuildSlaveSupport/build.webkit.org-config/config.json:
1765
1766 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1767
1768         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1769         https://bugs.webkit.org/show_bug.cgi?id=113421
1770
1771         Reviewed by Dirk Pranke.
1772
1773         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1774         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1775         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1776         in the GTK-specific TestExpectations files.
1777
1778         To avoid this only enable the warnings only when not using WKTR.
1779
1780         * Scripts/webkitpy/layout_tests/port/gtk.py:
1781         (GtkPort.warn_if_bug_missing_in_test_expectations):
1782
1783 2013-03-27  Antti Koivisto  <antti@apple.com>
1784
1785         Fix Zalan's email.
1786
1787         * Scripts/webkitpy/common/config/committers.py:
1788
1789 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1790
1791         master.cfg cleanup
1792         https://bugs.webkit.org/show_bug.cgi?id=113195
1793
1794         Reviewed by Ryosuke Niwa.
1795
1796         * BuildSlaveSupport/build.webkit.org-config/config.json:
1797         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1798
1799 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1800
1801         master.cfg fine-tuning for Qt Mountain Lion Release bot
1802         https://bugs.webkit.org/show_bug.cgi?id=113191
1803
1804         Reviewed by Ryosuke Niwa.
1805
1806         * BuildSlaveSupport/build.webkit.org-config/config.json:
1807           - Rename the slave due to its location change.
1808           - Update the platform of the slave.
1809         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1810         (RunQtAPITests): Enable running WK2 API tests on Qt.
1811         (RunQtAPITests.start):
1812         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1813         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1814
1815 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1816
1817         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1818         https://bugs.webkit.org/show_bug.cgi?id=113403
1819
1820         Reviewed by Kenneth Rohde Christiansen.
1821
1822         As of Evas 1.7.5, when Wayland is detected on the system, support for
1823         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1824         The code, however, seems to depend on a few other flags which must be
1825         explicitly enabled.
1826
1827         If those additional GL-related options are passed, we end up
1828         having issues on the WebKit side, so disable Wayland support for
1829         now.
1830
1831         * efl/jhbuild.modules:
1832
1833 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1834
1835         Unreviewed, rolling out r146864.
1836         http://trac.webkit.org/changeset/146864
1837         https://bugs.webkit.org/show_bug.cgi?id=113391
1838
1839         causes crashes on Wk2 EFL release bot (Requested by drott on
1840         #webkit).
1841
1842         * Scripts/webkitperl/FeatureList.pm:
1843
1844 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1845
1846         [jhbuild] Correctly specify an alternate number of make jobs.
1847         https://bugs.webkit.org/show_bug.cgi?id=113396
1848
1849         Reviewed by Philippe Normand.
1850
1851         So far, we were using the `MAKEFLAGS' environment variable to pass the
1852         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1853         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1854
1855         We now behave more closely to the rest of the WebKit tools by first
1856         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1857         not set, just letting jhbuild itself figure out how many jobs to use.
1858
1859         * efl/jhbuildrc:
1860         * gtk/jhbuildrc:
1861
1862 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1863
1864         [Qt] Remove Qt specific WorkQueueItem definitions.
1865         https://bugs.webkit.org/show_bug.cgi?id=112891
1866
1867         This patch is preparation work for removing
1868         WorkQueue related code from TestRunnerQt and
1869         replacing it with generic TestRunner code.
1870
1871         Reviewed by Benjamin Poulain.
1872
1873         * DumpRenderTree/qt/TestRunnerQt.cpp:
1874         (TestRunnerQt::queueBackNavigation):
1875         (TestRunnerQt::queueForwardNavigation):
1876         (TestRunnerQt::queueLoadHTMLString):
1877         (TestRunnerQt::queueReload):
1878         (TestRunnerQt::queueLoadingScript):
1879         (TestRunnerQt::queueNonLoadingScript):
1880         (TestRunner::queueLoad):
1881         * DumpRenderTree/qt/TestRunnerQt.h:
1882         (TestRunnerQt):
1883         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1884         (LoadItem::invoke):
1885         (LoadHTMLStringItem::invoke):
1886         (LoadAlternateHTMLStringItem::invoke):
1887         (ReloadItem::invoke):
1888         (ScriptItem::invoke):
1889         (BackForwardItem::invoke):
1890         * DumpRenderTree/qt/WorkQueueItemQt.h:
1891         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1892         (LoadAlternateHTMLStringItem):
1893
1894 2013-03-26  Julie Parent  <jparent@chromium.org>
1895
1896         Flakiness dashboard: simplify logic around which tests to show.
1897         https://bugs.webkit.org/show_bug.cgi?id=113250
1898
1899         Reviewed by Ojan Vafai.
1900         
1901         The different filters for showing results are only used for layout
1902         tests, otherwise, we show everything.
1903         
1904         Change the defaults to false (what layout tests used), and only
1905         look at the values when viewing layout tests.
1906
1907         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1908         (htmlForTestsWithExpectationsButNoFailures):
1909         (shouldHideTest):
1910
1911 2013-03-26  Isaac Levy  <ilevy@google.com>
1912
1913         Update bots on test-results.appspot
1914         https://bugs.webkit.org/show_bug.cgi?id=113333
1915
1916         Reviewed by Ojan Vafai.
1917
1918         * TestResultServer/static-dashboards/builders.jsonp:
1919
1920 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1921
1922         Unreviewed GTK gardening.
1923
1924         * Scripts/run-gtk-tests:
1925         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1926
1927 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1928
1929         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1930         https://bugs.webkit.org/show_bug.cgi?id=113287
1931
1932         Reviewed by Jocelyn Turcotte.
1933
1934         * Scripts/run-qtwebkit-tests:
1935         (Options.__init__):
1936
1937 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1938
1939         [EFL] Enable IndexedDB by default
1940         https://bugs.webkit.org/show_bug.cgi?id=107248
1941
1942         Reviewed by Laszlo Gombos.
1943
1944         * Scripts/webkitperl/FeatureList.pm:
1945         Enable IndexedDB by default on EFL.
1946
1947 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1948
1949         Sheriffbot should explain rollout failures in a human readable form.
1950         https://bugs.webkit.org/show_bug.cgi?id=107092
1951
1952         Reviewed by Ryosuke Niwa.
1953
1954         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1955
1956         * Scripts/webkitpy/tool/bot/irc_command.py:
1957         (Rollout._check_diff_failure):
1958         (Rollout.execute):
1959         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1960         (IRCCommandTest.test_rollout):
1961
1962 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1963
1964         Unreviewed GTK gardening.
1965
1966         * Scripts/run-gtk-tests:
1967         (TestRunner): Skipping a failing unit test after r146518.
1968
1969 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1970
1971         Remove Lion leaks builder
1972         https://bugs.webkit.org/show_bug.cgi?id=113252
1973
1974         Reviewed by Andreas Kling.
1975
1976         Removed.
1977
1978         * BuildSlaveSupport/build.webkit.org-config/config.json:
1979
1980 2013-03-25  Kent Tamura  <tkent@chromium.org>
1981
1982         Rename ENABLE_INPUT_TYPE_DATETIME
1983         https://bugs.webkit.org/show_bug.cgi?id=113254
1984
1985         Reviewed by Kentaro Hara.
1986
1987         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1988         Actually I'd like to remove the code, but we shouldn't remove it yet
1989         because we shipped products with it on some platforms.
1990
1991         * Scripts/webkitperl/FeatureList.pm:
1992         * qmake/mkspecs/features/features.pri:
1993
1994 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1995
1996         Remove one more line that was intended to be removed in r146657.
1997
1998         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1999         (summarize_results):
2000
2001 2013-03-25  Roger Fong  <roger_fong@apple.com>
2002
2003         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2004         Re-enable WinEWS tests.
2005
2006         * Scripts/webkitpy/common/config/ports.py:
2007         (WinPort.run_bindings_tests_command):
2008         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2009         (WinEWS):
2010
2011 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2012
2013         Unreviewed, rolling out r146793.
2014         http://trac.webkit.org/changeset/146793
2015         https://bugs.webkit.org/show_bug.cgi?id=113248
2016
2017         Fix did not work (Requested by rfong on #webkit).
2018
2019         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2020         (WinEWS):
2021
2022 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2023
2024         REGRESSION(r146657): Test failures reported incorrectly
2025         https://bugs.webkit.org/show_bug.cgi?id=113223
2026
2027         Reviewed by Dirk Pranke.
2028
2029         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2030
2031         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2032         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2033
2034         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2035         (Manager.run):
2036
2037         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2038         (RunDetails.__init__):
2039         (summarize_results): Remove the line I intended to remove in r146657.
2040
2041         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2042         (logging_run): Return details instead of the exit code.
2043         (run_and_capture): Ditto.
2044
2045         (RunTest.test_full_results_html):
2046         (RunTest.test_hung_thread):
2047         (RunTest.test_no_tests_found):
2048         (RunTest.test_no_tests_found_2):
2049         (RunTest.test_repeat_each_iterations_num_tests):
2050         (RunTest.test_run_singly_actually_runs_tests):
2051         (RunTest.test_test_list):
2052         (RunTest.test_missing_and_unexpected_results):
2053         (RunTest.test_pixel_test_directories):
2054         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2055         (RunTest.test_crash_with_stderr):
2056         (RunTest.test_no_image_failure_with_image_diff):
2057         (RunTest.test_crash_log):
2058         (RunTest.test_exit_after_n_failures_upload):
2059         (RunTest.test_results_directory_absolute):
2060         (RunTest.test_results_directory_relative):
2061         (RunTest.test_retrying_and_flaky_tests):
2062         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2063         (RunTest.test_retrying_uses_retries_directory):
2064         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2065         (RunTest.test_output_diffs):
2066         (EndToEndTest.test_reftest_with_two_notrefs):
2067         (RebaselineTest.test_reset_results):
2068         (RebaselineTest.test_missing_results):
2069         (RebaselineTest.test_new_baseline):
2070
2071         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2072         (BuildBotPrinter.print_results):
2073         (BuildBotPrinter.print_unexpected_results):
2074         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2075         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2076
2077 2013-03-25  Julie Parent  <jparent@chromium.org>
2078
2079         Dashboard refactor: Move cross dashboard history related code into history.js.
2080         https://bugs.webkit.org/show_bug.cgi?id=113104
2081
2082         Reviewed by Ojan Vafai.
2083
2084         All functions relating to cross dashboard behavior move from being
2085         globals to methods on the history.History object. Names stay the same,
2086         except many are made private, ones that should have been constants now
2087         are, and the long standing TODO to change "currentState" to 
2088         dashboardSpecificState is done.
2089         
2090         We now create a global history object in dashboard_base, as an 
2091         intermediate measure.  Once the dashboard specific code is
2092         added to history, each DB will need to create its own, and this
2093         global will be eliminated.
2094         
2095         * TestResultServer/static-dashboards/aggregate_results.js:
2096         (handleValidHashParameter):
2097         (htmlForBuilder):
2098         (rawValuesHTML):
2099         * TestResultServer/static-dashboards/dashboard_base.js:
2100         (parseDashboardSpecificParameters):
2101         (defaultValue):
2102         (currentBuilderGroupCategory):
2103         (currentBuilderGroupName):
2104         (handleLocationChange):
2105         (expectationsMap):
2106         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2107         (generatePage):
2108         (.switch.return):
2109         (platformAndBuildType):
2110         (individualTests):
2111         (substringList):
2112         (processMissingAndExtraExpectations):
2113         (pathToFailureLog):
2114         (showPopupForBuild):
2115         (htmlForTestsWithExpectationsButNoFailures):
2116         (shouldHideTest):
2117         (isCrossBuilderView):
2118         (tableHeaders):
2119         (htmlForSingleTestRow):
2120         (htmlForTableColumnHeader):
2121         (generatePageForExpectationsUpdate):
2122         (handleUpdate):
2123         (nextUpdate):
2124         (setUpdateIndex):
2125         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2126         (.appendExpectationsItem):
2127         (loadExpectations):
2128         (.dummyNode.onload):
2129         (loadExpectationsLayoutTests):
2130         (appendExpectations):
2131         (htmlForNavBar):
2132         (checkBoxToToggleState):
2133         (linkHTMLToToggleState):
2134         (generatePageForBuilder):
2135         (isInvalidKeyForCrossBuilderView):
2136         (handleQueryParameterChange):
2137         (showLegend):
2138         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2139         (resetGlobals):
2140         (test):
2141         * TestResultServer/static-dashboards/history.js:
2142         (.):
2143         * TestResultServer/static-dashboards/history_unittests.js:
2144         * TestResultServer/static-dashboards/loader.js:
2145         (.):
2146         * TestResultServer/static-dashboards/loader_unittests.js:
2147         * TestResultServer/static-dashboards/timeline_explorer.js:
2148         (generatePage):
2149         (initCurrentBuilderTestResults):
2150         (selectBuild):
2151         (showResultsDelta):
2152         * TestResultServer/static-dashboards/treemap.js:
2153         (generatePage):
2154         (.switch.return):
2155         (handleFocus):
2156         * TestResultServer/static-dashboards/ui.js:
2157
2158 2013-03-25  Roger Fong  <roger_fong@apple.com>
2159
2160         Unreviewed. Enable WinEWS tests again.
2161
2162         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2163         (WinEWS):
2164
2165 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2166
2167         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2168         https://bugs.webkit.org/show_bug.cgi?id=112166
2169
2170         HarfBuzz 0.9.14 merged my patch for icu detection without
2171         pkg-config files, as needed by for example Ubuntu 12.04.
2172         This obsoletes our local workaround. Removed it for GTK and EFL.
2173
2174         Reviewed by Martin Robinson.
2175
2176         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2177         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2178         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2179         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2180
2181 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2182
2183         Unreviewed.  Move self from contributor to committer list.
2184
2185         * Scripts/webkitpy/common/config/committers.py:
2186
2187 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2188
2189         EWS should use a human readable port name when uploading layout test archives
2190         https://bugs.webkit.org/show_bug.cgi?id=113099
2191
2192         Reviewed by Dirk Pranke.
2193
2194         Use new port's object's name() method to report human readable port names.
2195         This will also help us resolving the bug to apply layout test results posted by EWS.
2196
2197         * Scripts/webkitpy/tool/bot/botinfo.py:
2198         (BotInfo.__init__): Take port's name.
2199         (BotInfo.summary_text):
2200
2201         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2202         (BotInfoTest.test_summary_text):
2203
2204         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2205         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2206
2207         * Scripts/webkitpy/tool/commands/queues.py:
2208         (PatchProcessingQueue.__init__): Initialize self._port.
2209         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2210         and use that for the attachment filename and the comment posted.
2211
2212         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2213         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2214         "mac-snowleopard" as expected for TestPort.
2215
2216 2013-03-22  Roger Fong  <roger_fong@apple.com>
2217
2218         Unreviewed. Turn off EWS test on Win again.
2219         The battle continues.
2220
2221         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2222         (WinEWS):
2223
2224 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2225
2226         NRWT: Enable pixel tests when retrying tests
2227         https://bugs.webkit.org/show_bug.cgi?id=112898
2228
2229         Reviewed by Dirk Pranke.
2230
2231         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2232         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2233         if we've forced pixel tests in the retry.
2234         (Manager._run_tests):
2235         (Manager._clean_up_run): Fixed the capitalizations.
2236         (Manager._force_pixel_tests_if_needed): Added.
2237
2238         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2239         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2240         'image_diff_percent' if it doesn't already exist.
2241
2242         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2243         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2244         treat this as a regular regression instead of a flakiness.
2245
2246         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2247         run had image diffs.
2248
2249         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2250         (summarized_results):
2251
2252         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2253         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2254         Also removed some dead code.
2255
2256         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2257         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2258         is set and pixel_tests_enabled is set to false.
2259         (EndToEndTest.test_reftest_with_two_notrefs):
2260
2261 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2262
2263         Make it possible to run layout tests on Retina MBP
2264         https://bugs.webkit.org/show_bug.cgi?id=93673
2265
2266         Reviewed by Ryosuke Niwa.
2267
2268         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2269         windows on 2x machines still run at 1x.
2270
2271         * DumpRenderTree/mac/DumpRenderTree.mm:
2272         (createWebViewAndOffscreenWindow):
2273         Reset the window resolution to 1x on creation.
2274         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2275         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2276         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2277         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2278         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2279         (WTR::PlatformWebView::PlatformWebView):
2280         Add NSWindow details, reset the window resolution to 1x on creation.
2281
2282 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2283
2284         Leak bots shouldn't build
2285         https://bugs.webkit.org/show_bug.cgi?id=112774
2286
2287         Reviewed by Simon Fraser.
2288
2289         Since leak bots use regular debug builds, there is no need to build on these bots.
2290         Simply downloading builds will dramatically improve the cycle time of these bots.
2291
2292         * BuildSlaveSupport/build.webkit.org-config/config.json:
2293         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2294         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2295         TestFactory instead of BuildAndTestFactory.
2296
2297 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2298
2299         [Qt] Fix the TestWebKitAPI build
2300         https://bugs.webkit.org/show_bug.cgi?id=113044
2301
2302         Reviewed by Tor Arne Vestbø.
2303
2304         The generate-forwarding-headers script would only be run
2305         after the targets in InjectedBundle.pri since the second
2306         addStrictSubdirOrderBetween call in
2307         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2308         the derived_sources -> injected_bundle order in SUBDIRS.
2309
2310         Fix it by only moving the dependent target at the end of
2311         SUBDIRS, don't touch its dependency.
2312
2313         * qmake/mkspecs/features/functions.prf:
2314
2315 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2316
2317         [EFL][WK2] View is not focused when fullscreen mode toggled
2318         https://bugs.webkit.org/show_bug.cgi?id=113009
2319
2320         Reviewed by Laszlo Gombos.
2321
2322         Set focus on view when fullscreen mode enabled/disabled
2323         by FullScreen API.
2324
2325         * MiniBrowser/efl/main.c:
2326         (on_fullscreen_accept):
2327         (on_fullscreen_deny):
2328
2329 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2330
2331         nrwt is no longer saving retry results in the retries/ subdirectory
2332         https://bugs.webkit.org/show_bug.cgi?id=112995
2333
2334         Reviewed by Ojan Vafai.
2335
2336         I think this has been broken a long time, unfortunately. This
2337         patch should fix that.
2338
2339         In order to do so, I had to pass the directory to use from
2340         the Worker object through the SingleTestWriter to the
2341         TestResultWriter. While I was plumbing that through, I rationalized
2342         the order of the parameter arguments a bit ...
2343
2344         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2345         (Worker._run_single_test):
2346         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2347         (run_single_test):
2348         (SingleTestRunner.__init__):
2349         (SingleTestRunner._run_compare_test):
2350         (SingleTestRunner._run_rebaseline):
2351         (SingleTestRunner._run_reftest):
2352         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2353         (write_test_result):
2354         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2355         (TestResultWriterTest.test_reftest_diff_image):
2356         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2357         (RunTest.test_retrying_uses_retries_directory):
2358
2359 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2360
2361         JSC profiler should have an at-a-glance report of the success of DFG optimization
2362         https://bugs.webkit.org/show_bug.cgi?id=112988
2363
2364         Reviewed by Geoffrey Garen.
2365
2366         * Scripts/display-profiler-output:
2367
2368 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2369
2370         [chromium] Linux ASAN WebKit canary is running out of memory
2371         https://bugs.webkit.org/show_bug.cgi?id=112978
2372
2373         Reviewed by Tony Chang.
2374
2375         Running the AddressSanitizer on a crash takes a lot of
2376         memory, so we should serialize access to it to avoid running
2377         out of memory on a machine.
2378
2379         * Scripts/webkitpy/layout_tests/port/chromium.py:
2380         (ChromiumPort._get_crash_log):
2381         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2382         (HttpLock.__init__):
2383         (HttpLock.wait_for_httpd_lock):
2384
2385 2013-03-21  Min Qin  <qinmin@chromium.org>
2386
2387         Cleanup android media layout test code
2388         https://bugs.webkit.org/show_bug.cgi?id=112944
2389
2390         Reviewed by Adam Barth.
2391
2392         Chromium change: https://codereview.chromium.org/12892010/
2393         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2394         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2395         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2396         Instead, we should switch to use content shell for layout tests.
2397
2398         * DumpRenderTree/chromium/TestShell.cpp:
2399         (TestShell::resetTestController):
2400
2401 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2402
2403         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2404         https://bugs.webkit.org/show_bug.cgi?id=112953
2405
2406         Reviewed by Tony Chang.
2407
2408         When I created the DumpRenderTree_resources target in r144863 I
2409         forgot to declare the needed dependencies on the other resource
2410         targets. Due to a quirk of ordering, this appears to have been fine
2411         w/ ninja but not w/ Xcode (which is still being used on the chromium
2412         mac valgrind bots). Declaring the dependencies fixes the build
2413         failures.
2414
2415         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2416
2417 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2418
2419         [WinCairo] Correct assert in Empty BitmapImage Test.
2420         https://bugs.webkit.org/show_bug.cgi?id=112934
2421
2422         Reviewed by Tim Horton.
2423
2424         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2425         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2426         to avoid ref counting assertion when leaving test scope.
2427
2428 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2429
2430         [GTK] generate-feature-defines-files is incompatible with Python3
2431         https://bugs.webkit.org/show_bug.cgi?id=112956
2432
2433         Reviewed by Martin Robinson.
2434
2435         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2436         method on the dictionary objects when iterating through said dictionaries.
2437
2438         * gtk/generate-feature-defines-files:
2439         (write_feature_defines_header):
2440         (write_flattened_feature_defines_file):
2441
2442 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2443
2444         kill-old-processes spits out error messages on Mac
2445         https://bugs.webkit.org/show_bug.cgi?id=112878
2446
2447         Reviewed by Jessie Berlin.
2448
2449         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2450         included in the list of options grep --help shows.
2451
2452         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2453
2454         * BuildSlaveSupport/kill-old-processes:
2455         (main):
2456
2457 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2458
2459         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2460         https://bugs.webkit.org/show_bug.cgi?id=112597
2461
2462         Reviewed by Xan Lopez.
2463
2464         These were introduced for the Chromium port in r105295. We need
2465         dummy implementations in order to compile the BlackBerry port.
2466
2467         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2468         (AccessibilityUIElement::scrollToMakeVisible):
2469         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2470         (AccessibilityUIElement::scrollToGlobalPoint):
2471
2472 2013-03-21  Roger Fong  <roger_fong@apple.com>
2473
2474         Re-enable WinEWS tests following r146376.
2475
2476         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2477         (WinEWS):
2478
2479 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2480
2481         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2482
2483         * Scripts/webkitpy/common/config/committers.py:
2484
2485 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2486
2487         [GTK] Missing atk in install-dependencies script
2488         https://bugs.webkit.org/show_bug.cgi?id=112272
2489
2490         Reviewed by Gustavo Noronha Silva.
2491
2492         * gtk/install-dependencies: Add missing atk dependency.
2493
2494 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2495
2496         [GTK] Missing backslash in install-dependencies script
2497         https://bugs.webkit.org/show_bug.cgi?id=112907
2498
2499         Reviewed by Philippe Normand.
2500
2501         * gtk/install-dependencies: Add missing backslash to dependencies
2502         list.
2503
2504 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2505
2506         EWS bots have stopped uploading results to bugzilla
2507         https://bugs.webkit.org/show_bug.cgi?id=101091
2508
2509         Reviewed by Adam Barth.
2510
2511         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2512         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2513         this relative file path resoled to a file inside a non-existent directory for "zip".
2514
2515         Fixed the bug by resolving both test results directory and zip archive paths in
2516         LayoutTestResultsReader.archive.
2517
2518         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2519         in the future.
2520
2521         * Scripts/webkitpy/common/system/filesystem_mock.py:
2522         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2523
2524         * Scripts/webkitpy/common/system/workspace.py:
2525         (Workspace.create_zip): Log the source path when "zip" failed.
2526
2527         * Scripts/webkitpy/common/system/workspace_mock.py:
2528         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2529
2530         * Scripts/webkitpy/common/system/workspace_unittest.py:
2531         (WorkspaceTest.test_create_zip_exception): Test that.
2532
2533         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2534         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2535         This is the actual bug fix.
2536
2537         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2538         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2539
2540 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2541
2542         [chromium] move WebThemeEngine implementations to TestRunner library
2543         https://bugs.webkit.org/show_bug.cgi?id=112751
2544
2545         Reviewed by Adam Barth.
2546
2547         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2548         * DumpRenderTree/DumpRenderTree.gypi:
2549         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2550         (WebKit):
2551         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2552         (WebTestRunner::TestInterfaces::themeEngine):
2553         (WebTestRunner):
2554         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2555         (WebKit):
2556         (TestInterfaces):
2557         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2558         (WebTestRunner::WebTestInterfaces::themeEngine):
2559         (WebTestRunner):
2560         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2561         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2562         (WebTestRunner):
2563         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2564         (WebTestRunner::WebTestThemeControlWin::box):
2565         (WebTestRunner::WebTestThemeControlWin::line):
2566         (WebTestRunner::WebTestThemeControlWin::triangle):
2567         (WebTestRunner::WebTestThemeControlWin::roundRect):
2568         (WebTestRunner::WebTestThemeControlWin::oval):
2569         (WebTestRunner::WebTestThemeControlWin::circle):
2570         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2571         (WebTestRunner::WebTestThemeControlWin::markState):
2572         (WebTestRunner::WebTestThemeControlWin::draw):
2573         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2574         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2575         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2576         (WebTestRunner):
2577         (WebTestThemeControlWin):
2578         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2579         (WebTestRunner):
2580         (WebTestThemeEngineMac):
2581         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2582         (+[FakeActiveWindow alwaysActiveWindow]):
2583         (+[FakeActiveWindow alwaysInactiveWindow]):
2584         (-[FakeActiveWindow initWithActiveControls:]):
2585         (-[FakeActiveWindow _hasActiveControls]):
2586         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2587         (WebTestRunner):
2588         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2589         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2590         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2591         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2592         (WebTestRunner):
2593         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2594         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2595         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2596         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2597         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2598         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2599         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2600         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2601         (WebTestRunner::WebTestThemeEngineWin::getSize):
2602         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2603         (WebTestRunner):
2604         (WebTestThemeEngineWin):
2605         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2606         * DumpRenderTree/chromium/TestShell.cpp:
2607         (TestShell::initialize):
2608         * DumpRenderTree/chromium/TestShell.h:
2609         (WebKit):
2610         * DumpRenderTree/chromium/TestShellMac.mm:
2611         (platformInit):
2612         * DumpRenderTree/chromium/TestShellWin.cpp:
2613         (platformInit):
2614         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2615
2616 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2617
2618         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2619
2620         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2621         New property sheet that does not link against CoreFoundation and
2622         CFNetwork.
2623         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2624         Use new TestWebKitAPICommonWinCairo property sheet.
2625         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2626         Ditto.
2627
2628 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2629
2630         [WinCairo] Unreviewed build fix for VS2010.
2631
2632         Had to add WinCairo-specific property sheets to deal with some
2633         library and path differences with the main Apple port.
2634
2635         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2636         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2637         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2638         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2639         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2640         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2641
2642 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2643
2644         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2645         https://bugs.webkit.org/show_bug.cgi?id=112849
2646
2647         Reviewed by Sam Weinig.
2648
2649         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2650         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2651         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2652
2653 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2654
2655         [WinCairo] Build WebKit Tools under VS2010
2656         https://bugs.webkit.org/show_bug.cgi?id=112821
2657
2658         Reviewed by Tim Horton.
2659
2660         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2661         Add WinCairo-specific build target.
2662         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2663         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2664         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2665         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2666         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2667         Add WinCairo-specific build target.
2668         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2669         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2670         Add WinCairo-specific build target.
2671         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2672         WinCairo-specific build target.
2673         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2674         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2675         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2676         specific build target.
2677         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2678         WinCairo-specific build target.
2679         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2680         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2681         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2682
2683 2013-03-20  Roger Fong  <roger_fong@apple.com>
2684
2685         API test gardening AppleWin port.
2686
2687         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2688
2689         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2690         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2691
2692 2013-03-20  Roger Fong  <roger_fong@apple.com>
2693
2694         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2695
2696         * EWSTools/start-queue-win.sh:
2697
2698 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2699
2700         Unreviewed, add myself to committers.py.
2701
2702 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2703
2704         Unreviewed. Adding another email for me.
2705
2706         * Scripts/webkitpy/common/config/committers.py:
2707
2708 2013-03-20  Justin Novosad  <junov@google.com>
2709
2710         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2711         https://bugs.webkit.org/show_bug.cgi?id=112605
2712
2713         Reviewed by James Robinson.
2714
2715         Deleting all the code that was used for propagating and supporting
2716         the Chromium setting for disabling deferred 2d canvas rendering.
2717
2718         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2719         (main):
2720         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2721         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2722         (WebTestRunner::WebPreferences::reset):
2723         (WebTestRunner::WebPreferences::applyTo):
2724         * DumpRenderTree/chromium/TestShell.cpp:
2725         (TestShell::TestShell):
2726         (TestShell::resetWebSettings):
2727         (TestShell::runFileTest):
2728         * DumpRenderTree/chromium/TestShell.h:
2729         (TestShell):
2730
2731 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2732
2733         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2734         https://bugs.webkit.org/show_bug.cgi?id=112699.
2735
2736         Reviewed by Adam Barth.
2737
2738         * Scripts/webkitpy/layout_tests/port/qt.py:
2739         (QtPort._search_paths):
2740         (QtPort._port_specific_expectations_files):
2741         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2742         (QtPortTest):
2743         (QtPortTest._assert_search_path):
2744         (QtPortTest._assert_expectations_files):
2745
2746 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2747
2748         [Qt] Enable kerning by default
2749         https://bugs.webkit.org/show_bug.cgi?id=112704
2750
2751         Reviewed by Jocelyn Turcotte.
2752
2753         Disable kerning by default, since some reference test expectations
2754         expect kerning to be default off.
2755
2756         * DumpRenderTree/qt/TestRunnerQt.cpp:
2757         (TestRunnerQt::reset):
2758         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2759         (WTR::activateFonts):
2760
2761 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2762
2763         [Qt] Remove empty function stubs from TestRunnerQt.
2764         https://bugs.webkit.org/show_bug.cgi?id=112799
2765
2766         We are reducing the code in TestRunnerQt step by step,
2767         in order to finally replace all of it with the generic
2768         TestRunner implementation.
2769         This patch removes several simple function stubs that
2770         currently do not implement any actual functionality.
2771
2772         Reviewed by Kenneth Rohde Christiansen.
2773
2774         * DumpRenderTree/qt/TestRunnerQt.cpp:
2775         * DumpRenderTree/qt/TestRunnerQt.h:
2776         (TestRunnerQt):
2777
2778 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2779
2780         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2781         https://bugs.webkit.org/show_bug.cgi?id=112687
2782
2783         Reviewed by Kenneth Rohde Christiansen.
2784
2785         Hide the SearchBar by default on window creation.
2786
2787         * MiniBrowser/efl/main.c:
2788         (window_create):
2789
2790 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2791
2792         Unreviewed, rolling out r146304.
2793         http://trac.webkit.org/changeset/146304
2794         https://bugs.webkit.org/show_bug.cgi?id=112788
2795
2796         to many expectations to update (Requested by antonm on
2797         #webkit).
2798
2799         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2800         * DumpRenderTree/DumpRenderTree.gypi:
2801         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2802         (WebKit):
2803         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2804         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2805         (TestInterfaces):
2806         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2807         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2808         * DumpRenderTree/chromium/TestShell.cpp:
2809         (TestShell::initialize):
2810         * DumpRenderTree/chromium/TestShell.h:
2811         (WebKit):
2812         * DumpRenderTree/chromium/TestShellMac.mm:
2813         (platformInit):
2814         * DumpRenderTree/chromium/TestShellWin.cpp:
2815         (platformInit):
2816         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2817         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2818         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2819         (WebThemeControlDRTWin::box):
2820         (WebThemeControlDRTWin::line):
2821         (WebThemeControlDRTWin::triangle):
2822         (WebThemeControlDRTWin::roundRect):
2823         (WebThemeControlDRTWin::oval):
2824         (WebThemeControlDRTWin::circle):
2825         (WebThemeControlDRTWin::nestedBoxes):
2826         (WebThemeControlDRTWin::markState):
2827         (WebThemeControlDRTWin::draw):
2828         (WebThemeControlDRTWin::drawTextField):
2829         (WebThemeControlDRTWin::drawProgressBar):
2830         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2831         (WebThemeControlDRTWin):
2832         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2833         (WebThemeEngineDRTMac):
2834         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2835         (+[FakeActiveWindow alwaysActiveWindow]):
2836         (+[FakeActiveWindow alwaysInactiveWindow]):
2837         (-[FakeActiveWindow initWithActiveControls:]):
2838         (-[FakeActiveWindow _hasActiveControls]):
2839         (WebThemeEngineDRTMac::paintScrollbarThumb):
2840         (stateToHIEnableState):
2841         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2842         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2843         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2844         (webRectToSkIRect):
2845         (drawControl):
2846         (drawTextField):
2847         (drawProgressBar):
2848         (WebThemeEngineDRTWin::paintButton):
2849         (WebThemeEngineDRTWin::paintMenuList):
2850         (WebThemeEngineDRTWin::paintScrollbarArrow):
2851         (WebThemeEngineDRTWin::paintScrollbarThumb):
2852         (WebThemeEngineDRTWin::paintScrollbarTrack):
2853         (WebThemeEngineDRTWin::paintSpinButton):
2854         (WebThemeEngineDRTWin::paintTextField):
2855         (WebThemeEngineDRTWin::paintTrackbar):
2856         (WebThemeEngineDRTWin::paintProgressBar):
2857         (WebThemeEngineDRTWin::getSize):
2858         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2859         (WebThemeEngineDRTWin):
2860         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2861
2862 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2863
2864         [Qt] Support -webkit-font-smoothing
2865         https://bugs.webkit.org/show_bug.cgi?id=106009
2866
2867         Reviewed by Jocelyn Turcotte.
2868
2869         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2870
2871         * DumpRenderTree/qt/TestRunnerQt.cpp:
2872         (TestRunnerQt::reset):
2873
2874 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2875
2876         [GTK] accessibility/aria-scrollbar-role.html is failing
2877         https://bugs.webkit.org/show_bug.cgi?id=98358
2878
2879         Reviewed by Martin Robinson.
2880
2881         Adds support for checking accessibility object's orientation.
2882         Orientation is checked by retrieving proper state of accessibility object.
2883
2884         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2885         (checkElementState):
2886         (AccessibilityUIElement::orientation):
2887         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2888         (WTR::AccessibilityUIElement::orientation):
2889
2890 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2891
2892         [chromium] move WebThemeEngine implementations to TestRunner library
2893         https://bugs.webkit.org/show_bug.cgi?id=112751
2894
2895         Reviewed by Adam Barth.
2896
2897         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2898         * DumpRenderTree/DumpRenderTree.gypi:
2899         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2900         (WebKit):
2901         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2902         (WebTestRunner::TestInterfaces::themeEngine):
2903         (WebTestRunner):
2904         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2905         (WebKit):
2906         (TestInterfaces):
2907         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2908         (WebTestRunner::WebTestInterfaces::themeEngine):
2909         (WebTestRunner):
2910         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2911         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2912         (WebTestRunner):
2913         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2914         (WebTestRunner::WebTestThemeControlWin::box):
2915         (WebTestRunner::WebTestThemeControlWin::line):
2916         (WebTestRunner::WebTestThemeControlWin::triangle):
2917         (WebTestRunner::WebTestThemeControlWin::roundRect):
2918         (WebTestRunner::WebTestThemeControlWin::oval):
2919         (WebTestRunner::WebTestThemeControlWin::circle):
2920         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2921         (WebTestRunner::WebTestThemeControlWin::markState):
2922         (WebTestRunner::WebTestThemeControlWin::draw):
2923         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2924         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2925         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2926         (WebTestRunner):
2927         (WebTestThemeControlWin):
2928         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2929         (WebTestRunner):
2930         (WebTestThemeEngineMac):
2931         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2932         (+[FakeActiveWindow alwaysActiveWindow]):
2933         (+[FakeActiveWindow alwaysInactiveWindow]):
2934         (-[FakeActiveWindow initWithActiveControls:]):
2935         (-[FakeActiveWindow _hasActiveControls]):
2936         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2937         (WebTestRunner):
2938         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2939         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2940         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2941         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2942         (WebTestRunner):
2943         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2944         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2945         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2946         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2947         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2948         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2949         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2950         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2951         (WebTestRunner::WebTestThemeEngineWin::getSize):
2952         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2953         (WebTestRunner):
2954         (WebTestThemeEngineWin):
2955         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2956         * DumpRenderTree/chromium/TestShell.cpp:
2957         (TestShell::initialize):
2958         * DumpRenderTree/chromium/TestShell.h:
2959         (WebKit):
2960         * DumpRenderTree/chromium/TestShellMac.mm:
2961         (platformInit):
2962         * DumpRenderTree/chromium/TestShellWin.cpp:
2963         (platformInit):
2964         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2965
2966 2013-03-19  Tony Chang  <tony@chromium.org>
2967
2968         Move testRunner.setTouchDragDropEnabled to internals.settings
2969         https://bugs.webkit.org/show_bug.cgi?id=112739
2970
2971         Reviewed by Adam Barth.
2972
2973         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2974         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2975         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2976         (TestRunner): Remove unnecessary code.
2977         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2978         (WebTestRunner::WebPreferences::reset):
2979         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2980
2981 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2982
2983         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2984         https://bugs.webkit.org/show_bug.cgi?id=112754
2985
2986         Reviewed by Darin Fisher.
2987
2988         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2989         now that it's always defined.
2990
2991         * DumpRenderTree/chromium/WebViewHost.cpp:
2992         * DumpRenderTree/chromium/WebViewHost.h:
2993         (WebViewHost):
2994
2995 2013-03-19  Kenneth Russell  <kbr@google.com>
2996
2997         Unreviewed, rolling out r146290.
2998         http://trac.webkit.org/changeset/146290
2999         https://bugs.webkit.org/show_bug.cgi?id=112751
3000
3001         Broke Chromium Mac build.
3002
3003         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3004         * DumpRenderTree/DumpRenderTree.gypi:
3005         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3006         (WebKit):
3007         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3008         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3009         (TestInterfaces):
3010         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3011         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3012         * DumpRenderTree/chromium/TestShell.cpp:
3013         (TestShell::initialize):
3014         * DumpRenderTree/chromium/TestShell.h:
3015         (WebKit):
3016         * DumpRenderTree/chromium/TestShellMac.mm:
3017         (platformInit):
3018         * DumpRenderTree/chromium/TestShellWin.cpp:
3019         (platformInit):
3020         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3021         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3022         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3023         (WebThemeControlDRTWin::box):
3024         (WebThemeControlDRTWin::line):
3025         (WebThemeControlDRTWin::triangle):
3026         (WebThemeControlDRTWin::roundRect):
3027         (WebThemeControlDRTWin::oval):
3028         (WebThemeControlDRTWin::circle):
3029         (WebThemeControlDRTWin::nestedBoxes):
3030         (WebThemeControlDRTWin::markState):
3031         (WebThemeControlDRTWin::draw):
3032         (WebThemeControlDRTWin::drawTextField):
3033         (WebThemeControlDRTWin::drawProgressBar):
3034         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3035         (WebThemeControlDRTWin):
3036         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3037         (WebThemeEngineDRTMac):
3038         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3039         (+[FakeActiveWindow alwaysActiveWindow]):
3040         (+[FakeActiveWindow alwaysInactiveWindow]):
3041         (-[FakeActiveWindow initWithActiveControls:]):
3042         (-[FakeActiveWindow _hasActiveControls]):
3043         (WebThemeEngineDRTMac::paintScrollbarThumb):
3044         (stateToHIEnableState):
3045         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3046         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3047         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3048         (webRectToSkIRect):
3049         (drawControl):
3050         (drawTextField):
3051         (drawProgressBar):
3052         (WebThemeEngineDRTWin::paintButton):
3053         (WebThemeEngineDRTWin::paintMenuList):
3054         (WebThemeEngineDRTWin::paintScrollbarArrow):
3055         (WebThemeEngineDRTWin::paintScrollbarThumb):
3056         (WebThemeEngineDRTWin::paintScrollbarTrack):
3057         (WebThemeEngineDRTWin::paintSpinButton):
3058         (WebThemeEngineDRTWin::paintTextField):
3059         (WebThemeEngineDRTWin::paintTrackbar):
3060         (WebThemeEngineDRTWin::paintProgressBar):
3061         (WebThemeEngineDRTWin::getSize):
3062         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3063         (WebThemeEngineDRTWin):
3064         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3065
3066 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3067
3068         [EFL] canvas-fallback-content.html is failing
3069         https://bugs.webkit.org/show_bug.cgi?id=111998
3070
3071         Reviewed by Chris Fleizach.
3072
3073         Adds support for getting platform name.
3074
3075         * DumpRenderTree/TestRunner.cpp:
3076         (TestRunner::staticValues):
3077         * DumpRenderTree/TestRunner.h:
3078         (TestRunner):
3079         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3080         (TestRunner::platformName):
3081
3082 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3083
3084         [chromium] move WebThemeEngine implementations to TestRunner library
3085         https://bugs.webkit.org/show_bug.cgi?id=112751
3086
3087         Reviewed by Adam Barth.
3088
3089         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3090         * DumpRenderTree/DumpRenderTree.gypi:
3091         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3092         (WebKit):
3093         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3094         (WebTestRunner::TestInterfaces::themeEngine):
3095         (WebTestRunner):
3096         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3097         (WebKit):
3098         (TestInterfaces):
3099         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3100         (WebTestRunner::WebTestInterfaces::themeEngine):
3101         (WebTestRunner):
3102         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3103         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3104         (WebTestRunner):
3105         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3106         (WebTestRunner::WebTestThemeControlWin::box):
3107         (WebTestRunner::WebTestThemeControlWin::line):
3108         (WebTestRunner::WebTestThemeControlWin::triangle):
3109         (WebTestRunner::WebTestThemeControlWin::roundRect):
3110         (WebTestRunner::WebTestThemeControlWin::oval):
3111         (WebTestRunner::WebTestThemeControlWin::circle):
3112         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3113         (WebTestRunner::WebTestThemeControlWin::markState):
3114         (WebTestRunner::WebTestThemeControlWin::draw):
3115         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3116         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3117         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3118         (WebTestRunner):
3119         (WebTestThemeControlWin):
3120         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3121         (WebTestRunner):
3122         (WebTestThemeEngineMac):
3123         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3124         (+[FakeActiveWindow alwaysActiveWindow]):
3125         (+[FakeActiveWindow alwaysInactiveWindow]):
3126         (-[FakeActiveWindow initWithActiveControls:]):
3127         (-[FakeActiveWindow _hasActiveControls]):
3128         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3129         (WebTestRunner):
3130         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3131         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3132         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3133         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3134         (WebTestRunner):
3135         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3136         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3137         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3138         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3139         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3140         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3141         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3142         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3143         (WebTestRunner::WebTestThemeEngineWin::getSize):
3144         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3145         (WebTestRunner):
3146         (WebTestThemeEngineWin):
3147         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3148         * DumpRenderTree/chromium/TestShell.cpp:
3149         (TestShell::initialize):
3150         * DumpRenderTree/chromium/TestShell.h:
3151         (WebKit):
3152         * DumpRenderTree/chromium/TestShellMac.mm:
3153         (platformInit):
3154         * DumpRenderTree/chromium/TestShellWin.cpp:
3155         (platformInit):
3156         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3157
3158 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3159
3160         [EFL][WK2] Separate WebView further from EwkView
3161         https://bugs.webkit.org/show_bug.cgi?id=111591
3162
3163         Reviewed by Caio Marcelo de Oliveira Filho.
3164
3165         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3166         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3167         since we can afford it having EWKViewGetWKView() private API to access WKView.
3168
3169         * TestWebKitAPI/PlatformWebView.h:
3170         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3171         (TestWebKitAPI::TEST):
3172         * TestWebKitAPI/efl/PlatformWebView.cpp:
3173         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3174         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3175         (TestWebKitAPI::PlatformWebView::resizeTo):
3176         (TestWebKitAPI::PlatformWebView::page):
3177         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3178         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3179         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3180         * WebKitTestRunner/PlatformWebView.h:
3181         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3182         (WTR::EventSenderProxy::dispatchEvent):
3183         (WTR::EventSenderProxy::keyDown):
3184         (WTR::EventSenderProxy::sendTouchEvent):
3185         (WTR::EventSenderProxy::setTouchModifier):
3186         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3187         (WTR::PlatformWebView::PlatformWebView):
3188         (WTR::PlatformWebView::~PlatformWebView):
3189         (WTR::PlatformWebView::resizeTo):
3190         (WTR::PlatformWebView::page):
3191         (WTR::PlatformWebView::focus):
3192         (WTR::PlatformWebView::windowSnapshotImage):
3193
3194 2013-03-19  Roger Fong  <roger_fong@apple.com>
3195
3196         Changes to VS2010 project files should only trigger builds on Windows bots.
3197         https://bugs.webkit.org/show_bug.cgi?id=112731
3198
3199         Reviewed by Timothy Horton.
3200
3201         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3202         (_should_file_trigger_build):
3203
3204 2013-03-19  Roger Fong  <roger_fong@apple.com>
3205
3206         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3207
3208         * Scripts/webkitpy/tool/steps/runtests.py:
3209         (RunTests.run):
3210         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3211         (RunTestsTest.test_webkit_run_unit_tests):
3212
3213 2013-03-19  Julie Parent  <jparent@chromium.org>
3214
3215         Dashboards: Introduce history namespace and unit tests.
3216         https://bugs.webkit.org/show_bug.cgi?id=112645
3217
3218         Reviewed by Ojan Vafai.
3219         
3220         Laying the framework for introducing the new history object and
3221         namespace.  This moves only static functions into the history
3222         namespace, and moves corresponding unit tests into seperate
3223         unit test file.
3224
3225         * TestResultServer/static-dashboards/aggregate_results.html:
3226         * TestResultServer/static-dashboards/dashboard_base.js:
3227         (parseCrossDashboardParameters):
3228         (parseDashboardSpecificParameters):
3229         (parseParameters):
3230         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3231         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3232         (.switch.return):
3233         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3234         * TestResultServer/static-dashboards/history.js: Added.
3235         * TestResultServer/static-dashboards/history_unittests.js: Added.
3236         * TestResultServer/static-dashboards/loader.js:
3237         (.):
3238         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3239         * TestResultServer/static-dashboards/run-unittests.html:
3240         * TestResultServer/static-dashboards/timeline_explorer.html:
3241         * TestResultServer/static-dashboards/timeline_explorer.js:
3242         * TestResultServer/static-dashboards/treemap.html:
3243         * TestResultServer/static-dashboards/treemap.js:
3244         (.switch.return):
3245         * TestResultServer/static-dashboards/ui.js:
3246
3247 2013-03-19  Daniel Bates  <dbates@webkit.org>
3248
3249         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3250         https://bugs.webkit.org/show_bug.cgi?id=112732
3251
3252         Reviewed by Eric Seidel.
3253
3254         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3255         of an existing file cannot be applied.
3256
3257         In particular, svn-{apply, unapply} compensate for differences in line endings
3258         by converting the line endings in a diff to match the line endings in the target
3259         file. The diff(1) command precedes the last line of a diff that adds a newline
3260         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3261         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3262         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3263         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3264         the newline characters in this special character sequence to match the line endings
3265         in the target file.
3266
3267         * Scripts/VCSUtils.pm:
3268         (parseDiff):
3269         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3270         Added tests:
3271             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3272             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3273             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3274             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3275         (escapeNewLineCharacters): Added.
3276         (toMacLineEndings): Added.
3277
3278 2013-03-19  James Robinson  <jamesr@chromium.org>
3279
3280         [chromium] Remove compositor settings that don't go through WebKit
3281         https://bugs.webkit.org/show_bug.cgi?id=112718
3282
3283         Reviewed by Adam Barth.
3284
3285         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3286         (main):
3287         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3288         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3289         (WebTestRunner::WebPreferences::reset):
3290         (WebTestRunner::WebPreferences::applyTo):
3291         * DumpRenderTree/chromium/TestShell.cpp:
3292         (TestShell::TestShell):
3293         (TestShell::resetWebSettings):
3294         * DumpRenderTree/chromium/TestShell.h:
3295         (TestShell):
3296
3297 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3298
3299         Unreviewed, rolling out r146101.
3300         https://bugs.webkit.org/show_bug.cgi?id=111884
3301
3302         re-enable custom freetype on asan; this needs to be on
3303         now that the bot is running lucid.
3304
3305         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3306
3307 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3308
3309         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3310         https://bugs.webkit.org/show_bug.cgi?id=112365
3311
3312         Reviewed by Benjamin Poulain.
3313
3314         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3315         harcoding it in wtf/Platform.h
3316
3317         * Scripts/webkitperl/FeatureList.pm:
3318
3319 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3320
3321         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3322         https://bugs.webkit.org/show_bug.cgi?id=94782
3323
3324         Based on patch by Csaba Osztrogonác.
3325         Reviewed by Jocelyn Turcotte.
3326
3327         The diff image is generated with bright red indicating errors, but letting the base image
3328         shine through so the context of the error-pixel can be identified.
3329
3330         * DumpRenderTree/qt/ImageDiff.cpp:
3331         (main):
3332
3333 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3334
3335         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3336
3337         Rubber-stamped by Csaba Osztrogonác.
3338
3339         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3340         since the latter might not cover the former.
3341
3342         * QtTestBrowser/launcherwindow.cpp:
3343         (LauncherWindow::print):
3344
3345 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3346
3347         Style tweeks to default.css.
3348         
3349         Rubber-stamped by David Kilzer.
3350         
3351         Give visited links a different color to other links, so you can
3352         see which builds you've viewed.
3353         
3354         Make the <small> text less tiny.
3355
3356         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3357         (small):
3358         (a:link,a:visited,a:active):
3359         (a:visited):
3360
3361 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3362
3363         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3364         https://bugs.webkit.org/show_bug.cgi?id=112494
3365
3366         Reviewed by Dirk Pranke.
3367
3368         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3369         Also merged two pairs of methods to cleanup the code.
3370
3371         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3372         (PerfTestsRunner.run): Merged _upload_and_show_results.
3373         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3374
3375 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3376
3377         [chromium] build xdisplaycheck when building DRT
3378         https://bugs.webkit.org/show_bug.cgi?id=112636
3379
3380         Reviewed by Tony Chang.
3381
3382         It appears that we need xdisplaycheck to be built in order for
3383         Xvfb to be started correctly on the bots, and DRT was missing
3384         a dependency on it. This may be the cause of the ASAN bot not
3385         starting up properly (it only builds DRT).
3386
3387         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3388
3389 2013-03-18  David Levin  <levin@chromium.org>
3390
3391         Implement icon change notification dump for Chromium's test shell.
3392         https://bugs.webkit.org/show_bug.cgi?id=112614
3393
3394         This was previously implemented for some other platforms in r58111
3395         and r116547.
3396
3397         In r122806, fast/dom/icon-url-property.html stopped using it, but
3398         it is useful for tests, so I plan to re-add it to that test again.
3399
3400         Reviewed by Jochen Eisinger.
3401
3402         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3403         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3404          icon change notifications from WebKit may be logged in test output.
3405         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3406         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3407         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3408         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3409         (WebTestRunner):
3410         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3411         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3412         (TestRunner):
3413         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3414         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3415         (WebTestRunner):
3416         * DumpRenderTree/chromium/WebViewHost.cpp:
3417         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3418         * DumpRenderTree/chromium/WebViewHost.h:
3419         (WebViewHost):
3420
3421 2013-03-18  Julie Parent  <jparent@chromium.org>
3422
3423         Cleanup: Move js for treemap and aggregate_results into own js files.
3424         https://bugs.webkit.org/show_bug.cgi?id=112618
3425
3426         Reviewed by Dirk Pranke.
3427         
3428         No functional changes, just moving the code into separate js file
3429         rather than inlined in the html, so we can test it, make it more
3430         modular, etc.  Other dashboard types are already done this way.
3431
3432         * TestResultServer/static-dashboards/aggregate_results.html:
3433         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3434         (generatePage):
3435         (handleValidHashParameter):
3436         (htmlForBuilder):
3437         (rawValuesHTML):
3438         (chartHTML):
3439         (filteredValues):
3440         (chart):
3441         (htmlForRevisionRows):
3442         (wrapHTMLInTable):
3443         (htmlForSummaryTable):
3444         (valuesPerExpectation):
3445         (htmlForTestType):
3446         (htmlForTableRow):
3447         (extendedEncode):
3448         * TestResultServer/static-dashboards/treemap.html:
3449         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3450         (humanReadableTime):
3451         (convertToWebTreemapFormat):
3452         (reverseSortByAverage):
3453         (generatePage):
3454         (focusPath):
3455         (.switch.return):
3456         (handleQueryParameterChange):
3457         (extractName):
3458         (fullName):
3459         (handleFocus.):
3460         (handleFocus):
3461
3462 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3463
3464         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3465         https://bugs.webkit.org/show_bug.cgi?id=112622
3466
3467         Reviewed by Dirk Pranke.
3468
3469         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3470         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3471
3472 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3473
3474         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3475         https://bugs.webkit.org/show_bug.cgi?id=112619
3476
3477         Reviewed by Dirk Pranke.
3478
3479         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3480         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3481
3482         * Scripts/webkitpy/layout_tests/port/gtk.py:
3483         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3484         Port._webkit_baseline_path method.
3485         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3486         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3487         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3488         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3489         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3490         that are expected based on the builder name.
3491
3492 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3493
3494         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3495         https://bugs.webkit.org/show_bug.cgi?id=112571
3496
3497         Reviewed by Adam Barth.
3498
3499         Update function declarations for new WebFileSystemType enum. (All
3500         changes are behind an #ifdef so we can sync required changes in embedders.)
3501
3502         * DumpRenderTree/chromium/WebViewHost.cpp:
3503         (WebViewHost::openFileSystem):
3504         (WebViewHost::deleteFileSystem):
3505         * DumpRenderTree/chromium/WebViewHost.h:
3506         (WebViewHost):
3507
3508 2013-03-18  Julie Parent  <jparent@chromium.org>
3509
3510         Cleanup: Move timeline_exporer js out of html file into js.
3511         https://bugs.webkit.org/show_bug.cgi?id=112188
3512
3513         Reviewed by Dirk Pranke.
3514         
3515         Moves the javascript out of the html file and into a new js file.
3516         This follows the format of flakiness_dashboard.{html|js}.
3517         
3518         Also moves code from dashboard_base that is used only by this one
3519         dashboard, and makes it private to the dashboard.
3520
3521         * TestResultServer/static-dashboards/dashboard_base.js:
3522         * TestResultServer/static-dashboards/timeline_explorer.html:
3523         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3524         (generatePage):
3525         (initCurrentBuilderTestResults):
3526         (shouldShowWebKitRevisionsOnly):
3527         (updateTimelineForBuilder.):
3528         (updateTimelineForBuilder):
3529         (selectBuild):
3530         (updateBuildIndicator):
3531         (.addRow):
3532         (.addNumberRow):
3533         (.inspectorNode.getElementsByTagName.0.onclick):
3534         (.inspectorNode.getElementsByTagName.1.onclick):
3535         (.inspectorNode.getElementsByTagName.2.onclick):
3536         (updateBuildInspector):
3537         (showResultsDelta):
3538         (decompressResults.addFlakyDelta):
3539         (decompressResults):
3540
3541 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3542
3543         Unreviewed, rolling out r145272.
3544         http://trac.webkit.org/changeset/145272
3545         https://bugs.webkit.org/show_bug.cgi?id=111884
3546
3547         Turns out the ASAN build is still broken; possibly there's
3548         something still setting LD_LIBRARY_PATH, or possibly there's
3549         something else wrong. In the meantime, we need it to work again.
3550
3551         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3552
3553 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3554
3555         delete-stale-build-files is too aggressive
3556         https://bugs.webkit.org/show_bug.cgi?id=112595
3557
3558         Reviewed by Tim Horton.
3559
3560         It appears that whitelisting file extensions to keep is not a good idea.
3561         Blacklist files to delete instead, and only delete .o files for now.
3562         We can add more file extensions as needed.
3563
3564         * BuildSlaveSupport/delete-stale-build-files:
3565
3566 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3567
3568         Disable accessibility notifications after each test
3569         https://bugs.webkit.org/show_bug.cgi?id=112579
3570
3571         Reviewed by Tim Horton.
3572         
3573         In WebKitTestRunner, if any tests triggered accessibility notifications,
3574         the global notification handler would thereafter be active, and fire
3575         notifications for all subsequent tests.
3576         
3577         Fix by implementing AccessibilityController::resetToConsistentState() for
3578         Mac, and using it to clear the global notification handler.
3579
3580         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3581         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3582         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3583         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3584         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3585         (e.g. because of -autorelease).
3586         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3587         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3588         if there is one.
3589         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3590         Add -stopObserving
3591         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3592         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3593         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3594         center.
3595
3596 2013-03-18  Dana Jansens  <danakj@chromium.org>
3597
3598         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3599         https://bugs.webkit.org/show_bug.cgi?id=112392
3600
3601         Reviewed by James Robinson.
3602
3603         Removes the command line flag option from DRT.
3604
3605         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3606         (main):
3607
3608 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3609
3610         [GTK] plugins/plugin-clip-subframe.html is failing
3611         https://bugs.webkit.org/show_bug.cgi?id=112570
3612
3613         Reviewed by Martin Robinson.
3614
3615         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3616
3617 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3618
3619         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3620         https://bugs.webkit.org/show_bug.cgi?id=112442
3621
3622         Reviewed by Gustavo Noronha Silva.
3623
3624         * GtkLauncher/main.c:
3625         (reloadCb):
3626         (createToolbar):
3627         (createWindow):
3628
3629 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3630
3631         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3632         https://bugs.webkit.org/show_bug.cgi?id=112205
3633
3634         Disable this API test until Geoff can fix it.
3635
3636         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3637         (TestWebKitAPI::TEST):
3638
3639 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3640
3641         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3642         https://bugs.webkit.org/show_bug.cgi?id=112478
3643
3644         Reviewed by Tony Chang.
3645
3646         There is nothing that ensures that the log messages from the plugin
3647         come in before the layout test finished loading.
3648
3649         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3650         (PassDifferentNPPStruct::NPP_SetWindow):
3651         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3652         (NPP_SetWindow):
3653
3654 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3655
3656         Have the mac port support per_test_timeout in webkitpy
3657         https://bugs.webkit.org/show_bug.cgi?id=112466
3658
3659         Reviewed by Dirk Pranke.
3660         
3661         Both WTR and DRT handle --timeout arguments, so we can
3662         have the scripts pass the timeout values down to the tools.
3663
3664         * Scripts/webkitpy/layout_tests/port/mac.py:
3665         (MacPort.supports_per_test_timeout):
3666
3667 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3668
3669         Remove setAsynchronousSpellCheckingEnabled from test runners
3670         https://bugs.webkit.org/show_bug.cgi?id=112362
3671
3672         Reviewed by Tony Chang.
3673
3674         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3675         in internals.settings, so all ports can share it.
3676
3677         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3678         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3679         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3680         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3681         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3682         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3683         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3684         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3685         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3686         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3687         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3688         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3689
3690 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3691
3692         Fix the stupid unit tests.
3693
3694         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3695         (test_sample_process):
3696
3697 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3698
3699         Collect samples for unresponsive web processes
3700         https://bugs.webkit.org/show_bug.cgi?id=112409
3701
3702         Reviewed by Tim Horton.
3703         
3704         When we detect that a subprocess was unresponsive, run the 'sample'
3705         tool on that process, for the Mac port.
3706         
3707         The sample will be linked to from the results.html page, next
3708         to the crash log link.
3709
3710         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3711         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3712         look for samples on disk.
3713         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3714         (TestResultWriter):
3715         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3716         -sample.txt files, and have it copy their contents to a new file
3717         next to the test that spawned them (as we do for crash logs).
3718         * Scripts/webkitpy/layout_tests/port/base.py:
3719         (Port.look_for_new_samples): Base class does nothing for sampling.
3720         * Scripts/webkitpy/layout_tests/port/driver.py:
3721         (Driver._check_for_driver_crash): Kick off a sample if we detected
3722         that the subprocess was unresponsive.
3723         * Scripts/webkitpy/layout_tests/port/mac.py:
3724         (MacPort.sample_file_path): Utility to generate the file path
3725         to the generated sample files at the top level of layout-test-results.
3726         (MacPort.look_for_new_crash_logs): Fix typo
3727         (MacPort.look_for_new_samples): New function to find sample files.
3728         (MacPort.sample_process): Use the utility function to get the file path.
3729
3730 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3731
3732         [Qt] Remove simple getters and setters from TestRunnerQt
3733         https://bugs.webkit.org/show_bug.cgi?id=112343
3734
3735         Reviewed by Benjamin Poulain.
3736
3737         The removed functions and boolean members
3738         are being replaced by the implementations in the
3739         generic TestRunner.h.
3740
3741         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3742         (DumpRenderTree::dumpFrameScrollPosition):
3743         (DumpRenderTree::dumpFramesAsText):
3744         (DumpRenderTree::dump):
3745         (DumpRenderTree::titleChanged):
3746         (DumpRenderTree::dumpDatabaseQuota):
3747         (DumpRenderTree::dumpApplicationCacheQuota):
3748         (DumpRenderTree::statusBarMessage):
3749         (DumpRenderTree::createWindow):
3750         * DumpRenderTree/qt/TestRunnerQt.cpp:
3751         (TestRunnerQt::reset):
3752         * DumpRenderTree/qt/TestRunnerQt.h:
3753         (TestRunnerQt):
3754
3755 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3756
3757         Update the link on build.webkit.org to refer to perf.webkit.org
3758         https://bugs.webkit.org/show_bug.cgi?id=112416
3759
3760         Reviewed by Philip Rogers.
3761
3762         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3763
3764         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3765
3766 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3767
3768         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3769         https://bugs.webkit.org/show_bug.cgi?id=112394
3770
3771         Reviewed by Philippe Normand.
3772
3773         * GtkLauncher/main.c:
3774         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3775
3776 2013-03-14  Andreas Kling  <akling@apple.com>
3777
3778         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3779         <http://webkit.org/b/111815>
3780         <rdar://problem/13380145>
3781
3782         Reviewed by Anders Carlsson.
3783
3784         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3785         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3786         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3787
3788         * WebKitTestRunner/PlatformWebView.h:
3789         (PlatformWebView):
3790         * WebKitTestRunner/TestController.cpp:
3791         (WTR::TestController::createOtherPage):
3792         (WTR::TestController::createWebViewWithOptions):
3793         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3794         (WTR::PlatformWebView::didInitializeClients):
3795
3796 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3797
3798         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3799         https://bugs.webkit.org/show_bug.cgi?id=112122
3800
3801         Reviewed by Kenneth Rohde Christiansen.
3802
3803         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3804
3805         * MiniBrowser/efl/main.c:
3806         (_Browser_Window):
3807         (search_box_show):
3808         (search_box_hide):
3809         (on_key_down):
3810         (on_url_changed):
3811         (on_search_field_aborted):
3812         (on_search_field_activated):
3813         (on_search_field_clicked):
3814         (on_search_backward_button_clicked):
3815         (on_search_forward_button_clicked):
3816         (window_create):
3817
3818 2013-03-14  Julie Parent  <jparent@chromium.org>
3819
3820         Cleanup: Remove g_resourceLoader.
3821         https://bugs.webkit.org/show_bug.cgi?id=112305
3822
3823         Reviewed by Dirk Pranke.
3824         
3825         Removing another global.
3826         
3827         Now, each dashboard creates its own loader, rather than having
3828         a general global one.
3829         
3830         Remove usage of g_resourceLoader.isLoadingComplete from 
3831         handleLocationChange by ensuring that handleLocationChange is
3832         never called before the loader is done.  It was called in two
3833         places before: 1 was from the callback when the loader is done,
3834         so that was obviously true, and the other was from onhashchange,
3835         where it would just return rather than running.  Instead, lets
3836         only register the onhashchange handler once the loader is
3837         setup, so the check is no longer necessary.
3838         
3839         Remove isLoadingComplete since it is now unused.
3840         
3841         Callback for loader is now initializeHistory, rather than just
3842         handleLocationChange which will set up the hashchange handler now.
3843         This will all eventually be moving to a new History object.
3844
3845         * TestResultServer/static-dashboards/aggregate_results.html:
3846         * TestResultServer/static-dashboards/dashboard_base.js:
3847         (handleLocationChange):
3848         (intializeHistory):
3849         (decompressResults):
3850         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3851         (generatePage):
3852         * TestResultServer/static-dashboards/loader.js:
3853         (.):
3854         * TestResultServer/static-dashboards/loader_unittests.js:
3855         * TestResultServer/static-dashboards/timeline_explorer.html:
3856         * TestResultServer/static-dashboards/treemap.html:
3857
3858 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3859
3860         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3861         https://bugs.webkit.org/show_bug.cgi?id=109404
3862
3863         Reviewed by Tony Chang.
3864
3865         Removes all the code related to smartInsertDeleteEnabled and
3866         selectTrailingWhitespaceEnabled settings as they will be managed from
3867         internals from now on.
3868
3869         * DumpRenderTree/TestRunner.cpp:
3870         (TestRunner::staticFunctions):
3871         * DumpRenderTree/TestRunner.h:
3872         (TestRunner):
3873         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3874         (WebKit):
3875         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3876         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3877         (DumpRenderTree):
3878         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3879         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3880         (WebTestRunner::WebTestProxy::didStopLoading):
3881         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3882         (WebTestRunner::TestRunner::TestRunner):
3883         (WebTestRunner::TestRunner::reset):
3884         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3885         (TestRunner):
3886         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3887         (WebTestRunner::WebPreferences::applyTo): Set default values for
3888         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3889         Chromium DRT default values are different from Chromium browser.
3890         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3891         * DumpRenderTree/chromium/WebViewHost.cpp:
3892         * DumpRenderTree/chromium/WebViewHost.h:
3893         (WebViewHost):
3894         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3895         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3896         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3897         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3898         (resetDefaultsToConsistentValues):
3899         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3900         * DumpRenderTree/mac/DumpRenderTree.mm:
3901         (resetWebViewToConsistentStateBeforeTesting):
3902         * DumpRenderTree/mac/TestRunnerMac.mm:
3903         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3904         (WebCore::WebPage::resetSettings):
3905         * DumpRenderTree/qt/TestRunnerQt.cpp:
3906         * DumpRenderTree/qt/TestRunnerQt.h:
3907         (TestRunnerQt):
3908         * DumpRenderTree/win/DumpRenderTree.cpp:
3909         (resetWebViewToConsistentStateBeforeTesting):
3910         * DumpRenderTree/win/TestRunnerWin.cpp:
3911         * DumpRenderTree/wx/TestRunnerWx.cpp:
3912
3913 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3914
3915         [Qt] Disable DRT on Windows
3916
3917         Reviewed by Jocelyn Turcotte.
3918
3919         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
3920
3921         * qmake/mkspecs/features/configure.prf:
3922
3923 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3924
3925         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
3926         https://bugs.webkit.org/show_bug.cgi?id=110728
3927
3928         Reviewed by Gyuyoung Kim.
3929
3930         Use the page group to create the view object.
3931
3932         * MiniBrowser/efl/main.c:
3933         (window_create):
3934
3935 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
3936
3937         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
3938
3939         Reviewed by Tor Arne Vestbø.
3940
3941         The mock versions of these web facing features should be instantiated when
3942         running in DumpRenderTree only. In order for them to work, no extra Qt modules
3943         such as QtLocation are actually needed.
3944
3945         This patch decouples enabling device orientation/motion and geolocation from
3946         the underlying Qt modules and makes them available in developer builds
3947         (!production_build) and backed by mock backends when running in drt.
3948
3949         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
3950         developers the web facing features are always enabled (although requests will
3951         time out) and the mock backends are enabled inside DRT, allowing for the layout
3952         tests to run with less dependencies.
3953
3954         In addition this also enables the mock device motion client, which was
3955         previously never instantiated.
3956
3957         * qmake/mkspecs/features/features.prf:
3958
3959 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3960
3961         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
3962         https://bugs.webkit.org/show_bug.cgi?id=112340
3963
3964         Reviewed by Simon Hausmann.
3965
3966         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3967         (DumpRenderTree::dump):
3968             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
3969         (DumpRenderTree::dumpApplicationCacheQuota):
3970         * DumpRenderTree/qt/TestRunnerQt.cpp:
3971         (TestRunnerQt::reset):
3972         * DumpRenderTree/qt/TestRunnerQt.h:
3973         (TestRunnerQt):
3974
3975 2013-03-14  Zeno Albisser  <zeno@webkit.org>
3976
3977         [Qt] Port DRT to use TestRunner::dumpAsText()
3978         https://bugs.webkit.org/show_bug.cgi?id=112260
3979
3980         Reviewed by Benjamin Poulain.
3981
3982         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3983         (WebCore::DumpRenderTree::open):
3984         (WebCore::methodNameStringForFailedTest):
3985             Change parameter from type TestRunnerQt* to TestRunner*.
3986         (WebCore::DumpRenderTree::dump):
3987             TestRunnerQt::shouldDumpPixels() always returned true in our case.
3988             Instead we should rely on TestRunner::generatePixelResults().
3989         * DumpRenderTree/qt/TestRunnerQt.cpp:
3990         (TestRunnerQt::reset):
3991         * DumpRenderTree/qt/TestRunnerQt.h:
3992         (TestRunnerQt):
3993
3994 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
3995
3996         Implement FontLoader interface
3997         https://bugs.webkit.org/show_bug.cgi?id=98395
3998
3999         Reviewed by Eric Seidel.
4000
4001         Enable FontLoadEvents runtime flag for TestShell.
4002
4003         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4004         (WebTestRunner::TestInterfaces::TestInterfaces):
4005
4006 2013-03-13  Julie Parent  <jparent@chromium.org>
4007
4008         CLeanup: remove unnecessary call to parseParameters.
4009         https://bugs.webkit.org/show_bug.cgi?id=112309
4010
4011         Reviewed by Ojan Vafai.
4012         
4013         We call parseCrossDashboardParameters when the dashboard initially
4014         loads to set the state required for loadBuildersList, and then we
4015         call it again once we are fully done with loading, so there is no
4016         reason to call it in the middle of the loading process here.
4017
4018         * TestResultServer/static-dashboards/loader.js:
4019         (.):
4020
4021 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
4022
4023         Unreviewed. Now I'm a reviewer :)
4024
4025         * Scripts/webkitpy/common/config/committers.py:
4026
4027 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
4028
4029         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
4030         https://bugs.webkit.org/show_bug.cgi?id=112277
4031
4032         Reviewed by Adam Barth.
4033
4034         * Scripts/webkitperl/FeatureList.pm:
4035         * qmake/mkspecs/features/features.pri:
4036
4037 2013-03-13  Adam Barth  <abarth@webkit.org>
4038
4039         run-perf-tests should support content_shell
4040         https://bugs.webkit.org/show_bug.cgi?id=112291
4041
4042         Reviewed by Eric Seidel.
4043
4044         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4045         (PerfTestsRunner._parse_args):
4046
4047 2013-03-13  Oliver Hunt  <oliver@apple.com>
4048
4049         Simplify Checked<> multiplication
4050         https://bugs.webkit.org/show_bug.cgi?id=112286
4051
4052         Reviewed by James Robinson.
4053
4054         Add tests for multiplication by zero and max to ensure we don't
4055         mess them up should we ever make changes to Checked<> in future.
4056
4057         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4058         (TestWebKitAPI):
4059
4060 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4061
4062         [Qt] Unreviewed prospective Windows build fix
4063
4064         Do the usual thing, include the moc generated code in the .cpp file instead
4065         of compiling it standalone, to ensure that config.h is included, too, and
4066         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
4067
4068         * DumpRenderTree/qt/EventSenderQt.cpp:
4069
4070 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4071
4072         [Qt] Port TestRunner::findString to shared interface
4073         https://bugs.webkit.org/show_bug.cgi?id=112147
4074
4075         Reviewed by Jocelyn Turcotte.
4076
4077         This patch also removes DumpRenderTree and some other helper classes from
4078         the WebCore namespace, to which they do not really belong.
4079
4080         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4081         (main):
4082         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4083         (DumpRenderTree::DumpRenderTree):
4084         (DumpRenderTree::~DumpRenderTree):
4085         (DumpRenderTree::instance):
4086         (DumpRenderTree::setShouldTimeout):
4087         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4088         (DumpRenderTree):
4089         * DumpRenderTree/qt/EventSenderQt.cpp:
4090         (EventSender::contextClick):
4091         (EventSender::sendEvent):
4092         (EventSender::postEvent):
4093         * DumpRenderTree/qt/EventSenderQt.h:
4094         (EventSender::isGraphicsBased):
4095         * DumpRenderTree/qt/TestRunnerQt.cpp:
4096         (TestRunnerQt::TestRunnerQt):
4097         (TestRunner::findString):
4098         (TestRunnerQt::setMockDeviceOrientation):
4099         (TestRunnerQt::setGeolocationPermission):
4100         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
4101         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
4102         (TestRunnerQt::setMockGeolocationPosition):
4103         * DumpRenderTree/qt/TestRunnerQt.h:
4104         (TestRunnerQt):
4105
4106 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
4107
4108         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
4109         https://bugs.webkit.org/show_bug.cgi?id=112129
4110
4111         Reviewed by Adam Barth.
4112
4113         Following Chromium
4114         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
4115         this is being renamed to better explain what it does.
4116
4117         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4118
4119 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4120
4121         [Qt] Unreviewed trivial typo fix
4122
4123         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
4124         TextRunner.h. Thanks Zeno :)
4125
4126 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
4127
4128         [Qt] Prepare DRT for transition to shared TestRunner interface
4129         https://bugs.webkit.org/show_bug.cgi?id=112144
4130
4131         Reviewed by Benjamin Poulain.
4132
4133         Prepare Qt's DRT for a transition from the QObject based TestRunner to
4134         the JSC C API based one.
4135
4136         This is impplemented by instantiating the QObject based testRunner in
4137         the global object, then instantiating the JSC C based TestRunner
4138         separately and placing it "behind" the QObject based testRunner through
4139         injection of the individual functions through proxies. (prototype
4140         chaining doesn't work due to the this object and Function.prototype.bind
4141         doesn't work due to the native function)
4142
4143         This allows for porting over method by method by removing the method
4144         from the QObject TestRunnerQt and implementing it in the JSC C based
4145         TestRunner.
4146
4147         In order for this to link and run dummy implementations of all the
4148         necessary TestRunner functions are provided.
4149
4150         * DumpRenderTree/qt/DumpRenderTree.pro:
4151         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4152         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4153         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4154         (WebCore::DumpRenderTree::initJSObjects):
4155         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4156         (DumpRenderTree):
4157         * DumpRenderTree/qt/TestRunnerQt.cpp:
4158         (TestRunner::~TestRunner):
4159         (TestRunner::addDisallowedURL):
4160         (TestRunner::queueLoad):
4161         (TestRunner::removeAllVisitedLinks):
4162         (TestRunner::setAcceptsEditing):
4163         (TestRunner::simulateLegacyWebNotificationClick):
4164         (TestRunner::setWindowIsKey):
4165         (TestRunner::setAlwaysAcceptCookies):
4166         (TestRunner::addOriginAccessWhitelistEntry):
4167         (TestRunner::setWebViewEditable):
4168         (TestRunner::clearAllApplicationCaches):
4169         (TestRunner::setTextDirection):
4170         (TestRunner::notifyDone):
4171         (TestRunner::numberOfPendingGeolocationPermissionRequests):
4172         (TestRunner::overridePreference):
4173         (TestRunner::pathToLocalResource):
4174         (TestRunner::removeAllWebNotificationPermissions):
4175         (TestRunner::simulateWebNotificationClick):
4176         (TestRunner::closeIdleLocalStorageDatabases):
4177         (TestRunner::focusWebView):
4178         (TestRunner::setBackingScaleFactor):
4179         (TestRunner::removeChromeInputField):
4180         (TestRunner::addChromeInputField):
4181         (TestRunner::originsWithLocalStorage):
4182         (TestRunner::deleteAllLocalStorage):
4183         (TestRunner::deleteLocalStorageForOrigin):
4184         (TestRunner::observeStorageTrackerNotifications):
4185         (TestRunner::syncLocalStorage):
4186         (TestRunner::windowCount):
4187         (TestRunner::setWaitToDump):
4188         (TestRunner::waitForPolicyDelegate):
4189         (TestRunner::webHistoryItemCount):
4190         (TestRunner::showWebInspector):
4191         (TestRunner::closeWebInspector):
4192         (TestRunner::evaluateInWebInspector):
4193         (TestRunner::setSerializeHTTPLoads):
4194         (TestRunner::apiTestNewWindowDataLoadBaseURL):
4195         (TestRunner::setCustomPolicyDelegate):
4196         (TestRunner::setDatabaseQuota):
4197         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
4198         (TestRunner::resetPageVisibility):
4199         (TestRunner::keepWebHistory):
4200         (TestRunner::goBack):
4201         (TestRunner::originsWithApplicationCache):
4202         (TestRunner::applicationCacheDiskUsageForOrigin):
4203         (TestRunner::display):
4204         (TestRunner::dispatchPendingLoadRequests):
4205         (TestRunner::clearPersistentUserStyleSheet):
4206         (TestRunner::callShouldCloseOnWebView):
4207         (TestRunner::copyDecodedHostName):
4208         (TestRunner::clearBackForwardList):
4209         (TestRunner::clearAllDatabases):
4210         (TestRunner::clearApplicationCacheForOrigin):
4211         (TestRunner::apiTestGoToCurrentBackForwardItem):
4212         (TestRunner::authenticateSession):
4213         (TestRunner::abortModal):
4214         (TestRunner::setStorageDatabaseIdleInterval):
4215         (TestRunner::setAsynchronousSpellCheckingEnabled):
4216         (TestRunner::setXSSAuditorEnabled):
4217         (TestRunner::setSpatialNavigationEnabled):
4218         (TestRunner::setScrollbarPolicy):
4219         (TestRunner::setJavaScriptCanAccessClipboard):
4220         (TestRunner::setAutomaticLinkDetectionEnabled):
4221         (TestRunner::setUserStyleSheetEnabled):
4222         (TestRunner::setUserStyleSheetLocation):
4223         (TestRunner::setUseDashboardCompatibilityMode):
4224         (TestRunner::setTabKeyCyclesThroughElements):
4225         (TestRunner::setSmartInsertDeleteEnabled):
4226         (TestRunner::setSelectTrailingWhitespaceEnabled):
4227         (TestRunner::setPrivateBrowsingEnabled):
4228         (TestRunner::setPluginsEnabled):
4229         (TestRunner::setPopupBlockingEnabled):
4230         (TestRunner::setMockSpeechInputDumpRect):
4231         (TestRunner::setPersistentUserStyleSheetLocation):
4232         (TestRunner::setMockGeolocationPosition):
4233         (TestRunner::setMockGeolocationPositionUnavailableError):
4234         (TestRunner::setMockDeviceOrientation):
4235         (TestRunner::setMainFrameIsFirstResponder):
4236         (TestRunner::setIconDatabaseEnabled):
4237         (TestRunner::setGeolocationPermission):
4238         (TestRunner::setDefersLoading):
4239         (TestRunner::setCacheModel):
4240         (TestRunner::setAuthorAndUserStylesEnabled):
4241         (TestRunner::setAllowFileAccessFromFileURLs):
4242         (TestRunner::setAppCacheMaximumSize):
4243         (TestRunner::setAllowUniversalAccessFromFileURLs):
4244         (TestRunner::setApplicationCacheOriginQuota):
4245         (TestRunner::denyWebNotificationPermission):
4246         (TestRunner::grantWebNotificationPermission):
4247         (TestRunner::setValueForUser):
4248         (TestRunner::setViewModeMediaFeature):
4249         (TestRunner::setPageVisibility):
4250         (TestRunner::addMockSpeechInputResult):
4251         (TestRunner::removeOriginAccessWhitelistEntry):
4252         (TestRunner::addUserScript):
4253         (TestRunner::isCommandEnabled):
4254         (TestRunner::evaluateScriptInIsolatedWorld):
4255         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
4256         (TestRunner::copyEncodedHostName):
4257         (TestRunner::addUserStyleSheet):
4258         (TestRunner::findString):
4259         (TestRunner::execCommand):
4260         (TestRunner::localStorageDiskUsageForOrigin):
4261
4262 2013-03-12  Julie Parent  <jparent@chromium.org>
4263
4264         Cleanup: Move flatten-trie to loader.
4265         https://bugs.webkit.org/show_bug.cgi?id=112196
4266
4267         Reviewed by Dirk Pranke.
4268
4269         flatten-trie is used only by the loader, so move it there and make it
4270         private, rather than global in dashbaord_base. Moved the corresponding
4271         unit test from flakiness_dashboard_unittests to loader_unittests.
4272         
4273         * TestResultServer/static-dashboards/dashboard_base.js:
4274         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4275         * TestResultServer/static-dashboards/loader.js:
4276         (.):
4277         * TestResultServer/static-dashboards/loader_unittests.js:
4278
4279 2013-03-12  Oliver Hunt  <oliver@apple.com>
4280
4281         Unbreak api tests
4282
4283         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4284         (TestWebKitAPI):
4285
4286 2013-03-12  Tim Horton  <timothy_horton@apple.com>
4287