webkit-patch land-safely should set cq? if the patch author is not in committers.py
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2
3         webkit-patch land-safely should set cq? if the patch author is not in committers.py
4         https://bugs.webkit.org/show_bug.cgi?id=88689
5
6         Reviewed by Dirk Pranke.
7
8         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
9         in committers.py or the contributor cannot commit. If anything, the contributor can still
10         set cq+ on thier patches manually so I don't think this will be an issue for people who
11         don't list their Bugzille email on committers.py.
12
13         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
14         (Bugzilla._commit_queue_flag):
15         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
16         (test_commit_queue_flag):
17         (test_commit_queue_flag.assert_commit_queue_flag):
18
19 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
20
21         remove obsolete NewRunWebKitTests buildbot master factory classes
22         https://bugs.webkit.org/show_bug.cgi?id=88693
23
24         Reviewed by Ryosuke Niwa.
25
26         I believe these aren't used any more ...
27
28         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
29         (RunWebKitTests.getText2):
30         (BuildAndTestLeaksFactory):
31
32 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
33
34         [Chromium-Android] Build DumpRenderTree with Android SDK
35         https://bugs.webkit.org/show_bug.cgi?id=88598
36
37         Change WebKit side of DRT related code according to some recent changes at chromium side.
38
39         Reviewed by Adam Barth.
40
41         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
42         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
43         (ChromiumAndroidPort.__init__):
44         (ChromiumAndroidPort._path_to_driver):
45
46 2012-06-08  Wei James  <james.wei@intel.com>
47
48         Add app_abi option for DumpRenderTree_apk
49         https://bugs.webkit.org/show_bug.cgi?id=88626
50
51         Reviewed by Adam Barth.
52
53         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
54
55 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
56
57         [GTK] Add API to get the library version to WebKit2 GTK+
58         https://bugs.webkit.org/show_bug.cgi?id=88426
59
60         Reviewed by Martin Robinson.
61
62         * gtk/generate-gtkdoc:
63         (get_webkit2_options): Add built sources to the list of files, but
64         ignore enum types and marshallers.
65
66 2012-06-07  Vincent Scheib  <scheib@chromium.org>
67
68         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
69         https://bugs.webkit.org/show_bug.cgi?id=88604
70
71         Reviewed by Kent Tamura.
72
73         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
74         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
75
76         * DumpRenderTree/chromium/WebViewHost.cpp:
77         (WebViewHost::requestPointerUnlock):
78
79 2012-06-08  Hans Wennborg  <hans@chromium.org>
80
81         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
82         https://bugs.webkit.org/show_bug.cgi?id=87976
83
84         Reviewed by Kent Tamura.
85
86         Provide a mock implementation of WebSpeechRecognizer for
87         DumpRenderTree. This will allow better testing of the API via layout
88         tests.
89
90         * DumpRenderTree/DumpRenderTree.gypi:
91         * DumpRenderTree/chromium/LayoutTestController.cpp:
92         (LayoutTestController::LayoutTestController):
93         (LayoutTestController::addMockSpeechRecognitionResult):
94         * DumpRenderTree/chromium/LayoutTestController.h:
95         (LayoutTestController):
96         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
97         (MockWebSpeechRecognizer::create):
98         (MockWebSpeechRecognizer::start):
99         (MockWebSpeechRecognizer::stop):
100         (MockWebSpeechRecognizer::abort):
101         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
102         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
103         (MockWebSpeechRecognizer::ResultTask::runIfValid):
104         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
105         (WebKit):
106         (MockWebSpeechRecognizer):
107         (MockWebSpeechRecognizer::addMockResult):
108         (MockWebSpeechRecognizer::taskList):
109         (ClientCallTask):
110         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
111         (ResultTask):
112         (MockWebSpeechRecognizer::ResultTask::ResultTask):
113         (NoMatchTask):
114         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
115         * DumpRenderTree/chromium/WebViewHost.cpp:
116         (WebViewHost::speechRecognizer):
117         * DumpRenderTree/chromium/WebViewHost.h:
118         (WebViewHost):
119         (WebViewHost::mockSpeechRecognizer):
120
121 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
122
123         check-webkit-style needs to be taught about <public/Foo.h>
124         https://bugs.webkit.org/show_bug.cgi?id=88524
125
126         Reviewed by David Levin.
127
128         * Scripts/webkitpy/style/checkers/cpp.py:
129         (_classify_include):
130         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
131         (OrderOfIncludesTest.test_public_primary_header):
132         (OrderOfIncludesTest.test_classify_include):
133
134 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
135
136         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
137         https://bugs.webkit.org/show_bug.cgi?id=67255
138
139         Reviewed by Dirk Pranke.
140
141         Implement pathToLocalResource to redirect file:///tmp URL's to
142         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
143         LayoutTests sub-directory of the WebKit source tree.
144
145         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
146         (LayoutTestController::pathToLocalResource):
147
148 2012-06-07  Tony Payne  <tpayne@chromium.org>
149
150         [chromium] Allow LayoutTests under new git workflow
151         https://bugs.webkit.org/show_bug.cgi?id=88575
152
153         On Windows, chromium indirects through git.bat. Adds the same hack that
154         is currently used for discovering svn.bat to support the new git
155         workflow.
156
157         Reviewed by Dirk Pranke.
158
159         * Scripts/webkitpy/common/checkout/scm/git.py:
160         (Git): Replaces all hard-coded references to 'git' with the class
161         variable executable_name.
162         (Git._check_git_architecture):
163         (Git.in_working_directory):
164         (Git.find_checkout_root):
165         (Git.read_git_config):
166         (Git.discard_local_commits):
167         (Git.local_commits):
168         (Git.working_directory_is_clean):
169         (Git.clean_working_directory):
170         (Git.status_command):
171         (Git.add_list):
172         (Git.delete_list):
173         (Git.exists):
174         (Git._current_branch):
175         (Git.changed_files):
176         (Git._changes_files_for_commit):
177         (Git.revisions_changing_file):
178         (Git.conflicted_files):
179         (Git.svn_revision):
180         (Git.create_patch):
181         (Git._run_git_svn_find_rev):
182         (Git.contents_at_revision):
183         (Git.diff_for_file):
184         (Git.show_head):
185         (Git.committer_email_for_revision):
186         (Git.apply_reverse_diff):
187         (Git.revert_files):
188         (Git.commit_with_message):
189         (Git._commit_on_branch):
190         (Git.svn_commit_log):
191         (Git.last_svn_commit_log):
192         (Git.svn_blame):
193         (Git._branch_ref_exists):
194         (Git.delete_branch):
195         (Git.remote_merge_base):
196         (Git.commit_locally_with_message):
197         (Git.push_local_commits_to_server):
198         (Git.commit_ids_from_commitish_arguments):
199         (Git.commit_message_for_local_commit):
200         (Git.files_changed_summary_for_commit):
201         * Scripts/webkitpy/common/host.py:
202         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
203         that duplicates the logic in the existing 'svn.bat' hack.
204
205 2012-06-07  Ojan Vafai  <ojan@chromium.org>
206
207         Style build architectures like build versions for non-layout test failures
208         https://bugs.webkit.org/show_bug.cgi?id=88590
209
210         Reviewed by Tony Chang.
211
212         Since we show the list of failing tests after the architecture, we want the
213         buildtype and architecture to be grouped together visually.
214
215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
216         (.effects a.failing-builder>span.architecture):
217
218 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
219
220         [Chromium] Remove header dependency of ImageDiff to WTF
221         https://bugs.webkit.org/show_bug.cgi?id=88422
222
223         Reviewed by Ryosuke Niwa.
224
225         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
226         * DumpRenderTree/chromium/ImageDiff.cpp:
227         (untestedCompareImages):
228
229 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
230
231         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
232         https://bugs.webkit.org/show_bug.cgi?id=88491
233
234         Reviewed by Dirk Pranke.
235
236         DRT should enable WebAudio when WebAudio feature is enabled,
237         so that the WebAudio feature could be tested by the Layouttest.
238
239         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
240         (LayoutTestController::overridePreference):
241
242 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
243
244         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
245         https://bugs.webkit.org/show_bug.cgi?id=88581
246
247         Reviewed by Ojan Vafai.
248
249         webkit-paptch rebaseline-expectations was ignoring what the
250         expected results for a test were and pulling down all the result
251         files from a bot. This could lead to us pulling down old,
252         incorrect .txt or .png files. With this patch we will now only
253         pull down expectations of the appropriate file types (so an
254         IMAGE failure will only pull the png and not the txt file).
255
256         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
257         (has_pixel_failures):
258         (suffixes_for_expectations):
259         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
260         (FunctionsTest.test_suffixes_for_expectations):
261         * Scripts/webkitpy/tool/commands/rebaseline.py:
262         (AbstractRebaseliningCommand.__init__):
263         (RebaselineExpectations._is_supported_port):
264         (RebaselineExpectations._update_expectations_file):
265         (RebaselineExpectations._tests_to_rebaseline):
266         (RebaselineExpectations._rebaseline_port):
267         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
268         (test_overrides_are_included_correctly):
269
270 2012-06-07  Ojan Vafai  <ojan@chromium.org>
271
272         Fix recent null pointer error regression in the flakiness dashboard
273         https://bugs.webkit.org/show_bug.cgi?id=88573
274
275         Reviewed by Dirk Pranke.
276
277         * TestResultServer/static-dashboards/builders.js:
278         (requestBuilderList):
279         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
280
281 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
282
283         Add Konrad Piascik to committers.py
284         https://bugs.webkit.org/show_bug.cgi?id=88560
285
286         Unreviewed.
287
288         * Scripts/webkitpy/common/config/committers.py:
289
290 2012-06-07  Tony Chang  <tony@chromium.org>
291
292         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
293         https://bugs.webkit.org/show_bug.cgi?id=77368
294
295         Reviewed by Ojan Vafai.
296
297         It doesn't look like we ever get a rect with width or height of 0.
298         I ran css1, css2.1, fast/forms, and tables without any crashes.
299
300         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
301         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
302
303 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
304
305         run-webkit-tests --lint-test-files gives an error when run on linux
306         https://bugs.webkit.org/show_bug.cgi?id=88551
307
308         Reviewed by Ojan Vafai.
309
310         We weren't mapping the expectations properly for the
311         google-chrome ports.
312
313         * Scripts/webkitpy/layout_tests/port/base.py:
314         (Port.path_to_test_expectations_file):
315         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
316         (TestGoogleChromePort.test_path_to_expectations):
317
318 2012-06-07  Daniel Erat  <derat@chromium.org>
319
320         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
321         https://bugs.webkit.org/show_bug.cgi?id=88263
322
323         Reviewed by Tony Chang.
324
325         * DumpRenderTree/chromium/LayoutTestController.cpp:
326         (LayoutTestController::LayoutTestController):
327         (LayoutTestController::reset):
328         (LayoutTestController::setTextSubpixelPositioning):
329         * DumpRenderTree/chromium/LayoutTestController.h:
330         (LayoutTestController):
331         * DumpRenderTree/chromium/fonts.conf:
332
333 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
334
335         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
336         https://bugs.webkit.org/show_bug.cgi?id=88060
337
338         Reviewed by Martin Robinson.
339
340         Spin the main loop before acquiring the pixel content. This ensures things
341         like late size allocations are finished before calling gtk_widget_draw,
342         avoiding assertions and subsequent empty pixel results.
343
344         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
345         (createBitmapContextFromWebView):
346
347 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
348
349         [Qt] Improve the visual of the viewport info box
350         https://bugs.webkit.org/show_bug.cgi?id=88410
351
352         Reviewed by Tor Arne Vestbø.
353
354         Improve the visual and make it possible to see the content more easy.
355
356         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
357
358 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
359
360         [EFL][WK2] Compile webkit1 and webkit2 by default.
361         https://bugs.webkit.org/show_bug.cgi?id=85041
362
363         Reviewed by Chang Shu.
364
365         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
366         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
367
368         * Scripts/build-webkit:
369
370 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
371
372         Unreviewed, rolling out r119662.
373         http://trac.webkit.org/changeset/119662
374         https://bugs.webkit.org/show_bug.cgi?id=88487
375
376         Broke builds (Requested by rniwa on #webkit).
377
378         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
379         * DumpRenderTree/chromium/ImageDiff.cpp:
380         (untestedCompareImages):
381
382 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
383
384         [Chromium] Remove header dependency of ImageDiff to WTF
385         https://bugs.webkit.org/show_bug.cgi?id=88422
386
387         Reviewed by Adam Barth.
388
389         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
390         * DumpRenderTree/chromium/ImageDiff.cpp:
391         (untestedCompareImages):
392
393 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
394
395         [WebKit] DeviceOrientation cleanup
396         https://bugs.webkit.org/show_bug.cgi?id=88406
397
398         Reviewed by Kent Tamura.
399
400         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
401
402         * DumpRenderTree/chromium/LayoutTestController.cpp:
403         (LayoutTestController::setMockDeviceOrientation):
404
405 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
406
407         webkitpy: add support for an ordered dict of test expectations
408         https://bugs.webkit.org/show_bug.cgi?id=87802
409
410         Reviewed by Ojan Vafai.
411
412         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
413         support a cascaded list of test expectations files. An easy way
414         to think of this is as an ordered dictionary of name -> contents
415         for files, where the name is usually a path on disk (I say
416         usually because we want to support other kinds of expectations
417         like the compile-time skips for unsupported features in
418         webkit.py, and we want to continue to support "in-memory" test
419         expectations that don't require a filesystem).
420
421         Conveniently there is an OrderedDict implementation in Python
422         2.7+ and it is available as a backport, so the first step in
423         adding this support is to use that implementation. Subsequent
424         patches will update the test_expectations.py module (and other
425         callers) to access the dict directly.
426
427         This patch just changes the base internal implementation and
428         provides wrappers for compatibility. The derived ports
429         (WebKitPort, TestPort, etc.) still need to be updated.
430
431         * Scripts/webkitpy/layout_tests/port/base.py:
432         (Port._expectations_dict):
433         (Port.test_expectations):
434         (Port):
435         (Port._expectations_overrides_dict):
436         (Port.test_expectations_overrides):
437         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
438         (PortTestCase.test_expectations_ordering):
439         (PortTestCase):
440         (PortTestCase.test_expectations_overrides_ordering):
441         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
442         (OrderedDict):
443         (OrderedDict.__init__):
444         (OrderedDict.clear):
445         (OrderedDict.__setitem__):
446         (OrderedDict.__delitem__):
447         (OrderedDict.__iter__):
448         (OrderedDict.__reversed__):
449         (OrderedDict.popitem):
450         (OrderedDict.__reduce__):
451         (OrderedDict.__repr__):
452         (OrderedDict.copy):
453         (OrderedDict.fromkeys):
454
455 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
456
457         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
458
459         * gtk/run-api-tests:
460         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
461
462 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
463
464         nrwt should look in 'out' for binaries on chromium win to support ninja
465         https://bugs.webkit.org/show_bug.cgi?id=88273
466
467         Reviewed by Tony Chang.
468
469         This patch standardizes the search algorithm the chromium ports
470         use to figure out which driver to run. We will look in a
471         chromium location before a webkit location (e.g., in
472         Source/WebKit/chromium/out before out/) and we will look in the
473         "legacy" directory (xcodebuild) before the directory ninja uses
474         (out).
475
476         Unfortunately due to the way the test code is set up testing the
477         properly requires some duplication of test code. I will fix that
478         in a followup patch.
479
480         * Scripts/webkitpy/layout_tests/port/chromium.py:
481         (ChromiumPort):
482         (ChromiumPort._static_build_path):
483         (ChromiumPort._build_path):
484         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
485         (ChromiumLinuxPort):
486         (ChromiumLinuxPort._determine_driver_path_statically):
487         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
488         (ChromiumLinuxPortTest.test_build_path):
489         (ChromiumLinuxPortTest):
490         (ChromiumLinuxPortTest.test_driver_name_option):
491         (ChromiumLinuxPortTest.path_to_image_diff):
492         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
493         (ChromiumMacPort):
494         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
495         (ChromiumMacPortTest.test_build_path):
496         (ChromiumMacPortTest):
497         (ChromiumMacPortTest.test_driver_name_option):
498         (ChromiumMacPortTest.path_to_image_diff):
499         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
500         (ChromiumPortTest.test_overrides_and_builder_names):
501         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
502         (ChromiumWinPort):
503         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
504         (ChromiumWinTest.test_build_path):
505         (ChromiumWinTest.test_operating_system):
506         (ChromiumWinTest):
507         (ChromiumWinTest.test_driver_name_option):
508         (ChromiumWinPortTest.path_to_image_diff):
509         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
510         (PortTestCase.assert_build_path):
511
512 2012-06-06  Jessie Berlin  <jberlin@apple.com>
513
514         Remove very red Windows WebKit2 testers
515         https://bugs.webkit.org/show_bug.cgi?id=88452
516
517         Reviewed by Steve Falkenburg.
518
519         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
520         need to focus on getting the WK1 testers green.
521
522         * BuildSlaveSupport/build.webkit.org-config/config.json:
523
524 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
525
526         get rebaselining tools to kinda work with the skia overrides file
527         https://bugs.webkit.org/show_bug.cgi?id=88456
528
529         Reviewed by Ryosuke Niwa.
530
531         Update rebaseline-expectations so that we read in the overrides
532         when looking for tests to rebaseline, but don't read in the
533         overrides when we are writing the expectations file back out.
534         This prevents the overrides from getting written into the main
535         file. This is kind of a hack but will have to do until we
536         support multiple expectations files properly.
537
538         * Scripts/webkitpy/tool/commands/rebaseline.py:
539         (RebaselineExpectations._expectations):
540         (RebaselineExpectations._update_expectations_file):
541         (RebaselineExpectations._tests_to_rebaseline):
542         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
543         (test_overrides_are_included_correctly):
544
545 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
546
547         webkitpy: two manager_worker_broker_unittest tests are broken
548         https://bugs.webkit.org/show_bug.cgi?id=88445
549
550         Reviewed by Ojan Vafai.
551
552         These tests were never updated when we removed the
553         --worker-model argument, and we were passing 'inline' instead of
554         1 (for the number of workers) :(. As a result we were creating
555         multiprocessing queues unnecessarily and that was failing on cygwin.
556
557         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
558         (InterfaceTest.test_managerconnection_is_abstract):
559         (InterfaceTest.test_workerconnection_is_abstract):
560
561 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
562
563         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
564         https://bugs.webkit.org/show_bug.cgi?id=87406
565
566         Reviewed by Dirk Pranke.
567
568         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
569         (TestExpectations.__init__):
570         * Scripts/webkitpy/tool/commands/rebaseline.py:
571         (RebaselineTest._update_expectations_file):
572         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
573         (test_rebaseline_does_not_include_overrides):
574
575 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
576
577         webkitpy: perf tests unit tests fail on chromium win
578         https://bugs.webkit.org/show_bug.cgi?id=88279
579
580         Reviewed by Ryosuke Niwa.
581
582         I'm seeing weird failures running the unit tests in my win32
583         checkout, and we don't really expect webpagereplay to work on
584         win32 anyway, so I'm skipping the import of that module for now
585         and adding a warning.
586
587         * Scripts/run-perf-tests:
588         * Scripts/webkitpy/performance_tests/perftest.py:
589
590 2012-06-06  Yong Li <yoli@rim.com>
591
592         Unreviewed. Update my email address in committers.py.
593
594         * Scripts/webkitpy/common/config/committers.py:
595
596 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
597
598         Add Robert Kroeger  to commiters.py
599         https://bugs.webkit.org/show_bug.cgi?id=88415
600
601         Unreviewed.
602
603         * Scripts/webkitpy/common/config/committers.py:
604
605 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
606
607         [EFL][DRT] http/tests/globalhistory testcases do not pass
608         https://bugs.webkit.org/show_bug.cgi?id=82579
609
610         Reviewed by Csaba Osztrogonác.
611
612         DRT has provided callbacks for ewk_view "global history delegate" signals.
613
614         * DumpRenderTree/efl/DumpRenderTree.cpp:
615         (isGlobalHistoryTest): Aux function to ident global history testcase.
616         (createLayoutTestController):
617         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
618         (DumpRenderTreeChrome::createView):
619         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
620         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
621         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
622         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
623         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
624         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
625         (DumpRenderTreeChrome):
626
627 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
628
629         [Qt] run-qtwebkit-tests hangs with -j1
630         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
631         This could happen due to an uncancelled timer after results were returned. This timer was
632         started only if --timeout was set.
633         https://bugs.webkit.org/show_bug.cgi?id=85475
634
635         Reviewed by Csaba Osztrogonác.
636
637         * Scripts/run-qtwebkit-tests:
638         (run_test):
639
640 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
641
642         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
643         https://bugs.webkit.org/show_bug.cgi?id=88327
644
645         Reviewed by Kenneth Rohde Christiansen.
646
647         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
648         * MiniBrowser/qt/icons/contents_width.png: Added.
649         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
650         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
651
652 2012-06-05  Jon Lee  <jonlee@apple.com>
653
654         Buildbot fix.
655
656         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
657         in the function. Store in a local variable.
658         (loadBuilderConfig):
659
660 2012-06-05  Jon Lee  <jonlee@apple.com>
661
662         Buildbot fix.
663
664         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
665         (loadBuilderConfig):
666
667 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
668
669         webkitpy: clean up win-specific path handling and tests
670         https://bugs.webkit.org/show_bug.cgi?id=88281
671
672         Reviewed by Adam Barth.
673
674         There was a bunch of inconsistent logic for handling path
675         conversions for win32 and cygwin paths due to us sometimes
676         looking at sys.platform and sometimes using mock hosts. This
677         patch cleans everything up so that we are required to pass
678         PlatformInfo objects to the path module and stop trying to do
679         different things when running on cygwin or win32 hosts (except
680         in the path_unittest module itself).
681
682         This may slightly reduce test coverage for the win32 code paths
683         but will be a lot easier to follow and maintain.
684
685         * Scripts/webkitpy/common/system/path.py:
686         (abspath_to_uri):
687         (_convert_path):
688         * Scripts/webkitpy/common/system/path_unittest.py:
689         (AbspathTest.platforminfo):
690         (AbspathTest.test_abspath_to_uri_cygwin):
691         (AbspathTest.test_abspath_to_uri_unixy):
692         (AbspathTest.test_abspath_to_uri_win):
693         (AbspathTest.test_abspath_to_uri_escaping_unixy):
694         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
695         (AbspathTest.test_stop_cygpath_subprocess):
696         * Scripts/webkitpy/common/system/platforminfo.py:
697         (PlatformInfo.__init__):
698         (PlatformInfo.is_cygwin):
699         * Scripts/webkitpy/common/system/platforminfo_mock.py:
700         (MockPlatformInfo.is_cygwin):
701         * Scripts/webkitpy/layout_tests/port/base.py:
702         (Port.to.show_results_html_file):
703         * Scripts/webkitpy/layout_tests/port/driver.py:
704         (Driver.test_to_uri):
705         (Driver.uri_to_test):
706         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
707         (DriverTest.test_test_to_uri):
708         (DriverTest.test_uri_to_test):
709         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
710         (MockDRTPortTest.make_port):
711         (MockDRTTest.input_line):
712         (MockChromiumDRTTest.test_pixeltest__fails):
713         * Scripts/webkitpy/layout_tests/port/test.py:
714         * Scripts/webkitpy/layout_tests/port/win.py:
715         (WinPort.show_results_html_file):
716         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
717         (MainTest.test_unexpected_failures):
718         (MainTest.test_results_directory_absolute):
719         (MainTest.test_results_directory_default):
720         (MainTest.test_results_directory_relative):
721
722 2012-06-05  Jon Lee  <jonlee@apple.com>
723
724         Workaround buildbot bug when merging build requests.
725         https://bugs.webkit.org/show_bug.cgi?id=88158
726
727         Reviewed by Mark Rowe.
728
729         For expediency, we still want testers to pick the latest build to test, but to ensure
730         that the builders are reporting the correct revision number, we should let the building bots
731         run as they normally would. That is, the builder picks the oldest revision, and merges
732         subsequent requests. Because merged requests get appended to the list of changes for a given
733         build, the last change in that list is also the latest change. When we used pickLatestBuild
734         for the builders, this was not the case (it would always report the penultimate change).
735
736         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
737
738         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
739         for all Apple builders.
740         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
741         the latest build to run.
742         (loadBuilderConfig):
743
744 2012-06-05  Jessie Berlin  <jberlin@apple.com>
745
746         [Win] DumpRenderTree should call resetInternalsObject
747         https://bugs.webkit.org/show_bug.cgi?id=88346
748
749         Reviewed by Simon Fraser.
750
751         Invoke it on Windows in the same place it is invoked on Mac.
752
753         * DumpRenderTree/win/DumpRenderTree.cpp:
754         (resetWebViewToConsistentStateBeforeTesting):
755
756 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
757
758         [GTK] Fix two more memory leaks in DRT
759         https://bugs.webkit.org/show_bug.cgi?id=88255
760
761         Reviewed by Martin Robinson.
762
763         Fixed memory leaks in GTK's DRT code.
764
765         * DumpRenderTree/gtk/DumpRenderTree.cpp:
766         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
767         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
768         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
769         (createBitmapContextFromWebView): Free the cairo surface.
770
771 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
772
773         [Qt] Building when a top directory is named Source
774         https://bugs.webkit.org/show_bug.cgi?id=77727
775
776         Reviewed by Tor Arne Vestbø.
777
778         Change regex to only replace the last instance of OUT_PWD.
779
780         * qmake/mkspecs/features/default_pre.prf:
781
782 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
783
784         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
785         https://bugs.webkit.org/show_bug.cgi?id=73176
786
787         Reviewed by Adam Barth.
788
789         Two more APIs are added in Custom Scheme Handler specification.
790         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
791         One is 'isProtocolHandlerRegistered' to query whether the specific URL
792         is registered or not.
793         The other is 'unregisterProtocolHandler' to remove the registered URL.
794
795         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
796
797 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
798
799         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
800         https://bugs.webkit.org/show_bug.cgi?id=83879
801
802         Reviewed by Carlos Garcia Campos.
803
804         Make minibrowser connect to the new 'permission requests' signal
805         to allow users handle the Geolocation permission requests.
806
807         * MiniBrowser/gtk/BrowserWindow.c:
808         (geolocationRequestDialogCallback): Callback for the dialog asking
809         the user for allowing or not geolocation permission requests.
810         (webViewDecidePermissionRequest): Launch a dialog to ask the user
811         whether to allow or deny geolocation permission requests.
812         (browserWindowConstructed): Connect to 'permission-request' signal.
813
814 2012-06-04  Chase Phillips  <cmp@google.com>
815
816         Make a builder group support+expect multiple loads.
817         https://bugs.webkit.org/show_bug.cgi?id=88260
818
819         Change BuilderGroup to allow expecting multiple
820         loads.  This allows merging results for a given set
821         of builders into one group.
822
823         Add a test that verifies that the group count
824         increments correctly based on successful and failed
825         list loads.
826
827         Reviewed by Ojan Vafai.
828
829         * TestResultServer/static-dashboards/builders.js:
830         (BuilderGroup):
831         (BuilderGroup.prototype.setbuilder):
832         (BuilderGroup.prototype.append):
833         (BuilderGroup.prototype.loaded):
834         (requestBuilderList.xhr.onload):
835         (requestBuilderList.xhr.onerror):
836         (onErrorLoadingBuilderList):
837         (loadBuildersList):
838         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
839         (test):
840         * TestResultServer/static-dashboards/run-unittests.html:
841
842 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
843
844         Python test fix attempt for Chromium Windows.
845
846         * Scripts/webkitpy/layout_tests/port/driver.py:
847         (Driver.uri_to_test):
848
849 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
850
851         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
852         https://bugs.webkit.org/show_bug.cgi?id=88243
853
854         Reviewed by Adam Barth.
855
856         * qmake/mkspecs/features/features.prf:
857
858 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
859
860         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
861         https://bugs.webkit.org/show_bug.cgi?id=88280
862
863         Unreviewed, build fix.
864
865         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
866         (TestServerProcess.test_basic):
867
868 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
869
870         test-webkitpy is hanging under cygwin
871         https://bugs.webkit.org/show_bug.cgi?id=88269
872
873         Reviewed by Ryosuke Niwa.
874
875         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
876         so we need to skip any tests that use it.
877
878         * Scripts/webkitpy/common/system/executive.py:
879         (Executive.run_in_parallel):
880         * Scripts/webkitpy/common/system/executive_unittest.py:
881         (ExecutiveTest.test_run_in_parallel):
882
883 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
884
885         test-webkitpy is failing on win32 after r115054
886         https://bugs.webkit.org/show_bug.cgi?id=88264
887
888         Reviewed by Ryosuke Niwa.
889
890         The failing http_server test was improperly suppressed (the
891         tuple was missing a comma, and so wasn't a tuple at all, just a
892         string) and so we were skipping *all* tests on win32. The right
893         way to skip a single test is to disable it inside the test
894         itself.
895
896         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
897         (TestHttpServer.test_start_cmd):
898         * Scripts/webkitpy/test/test_finder.py:
899         (TestFinder._default_names):
900         * Scripts/webkitpy/test/main.py:
901         (Tester.run): Add error message if we don't find any tests to run.
902         * Scripts/webkitpy/test/main_unittest.py:
903             
904
905 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
906
907         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
908         https://bugs.webkit.org/show_bug.cgi?id=88215
909
910         Reviewed by Martin Robinson.
911
912         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
913         for newly allocated strings.
914
915         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
916         (attributeSetToString):
917         (AccessibilityUIElement::allAttributes):
918
919 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
920
921         [GTK] Memory leaks in DumpRenderTree.cpp
922         https://bugs.webkit.org/show_bug.cgi?id=88213
923
924         Reviewed by Martin Robinson.
925
926         Fixed memory leaks in DumpRenderTree.
927
928         * DumpRenderTree/gtk/DumpRenderTree.cpp:
929         (appendString): Accepts const gchar* as the second argument.
930         (dumpFramesAsText): Free the string returned by g_strdup_printf().
931         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
932
933 2012-06-04  David Dorwin  <ddorwin@chromium.org>
934
935         Enable Chromium media player to instantiate a plugin
936         https://bugs.webkit.org/show_bug.cgi?id=87399
937
938         Reviewed by Kent Tamura.
939
940         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
941
942         * DumpRenderTree/chromium/WebViewHost.cpp:
943         (WebViewHost::createPopupMenu):
944
945 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
946
947         [GTK][WK2] Implement geolocation provider for the GTK port
948         https://bugs.webkit.org/show_bug.cgi?id=83877
949
950         Reviewed by Carlos Garcia Campos.
951
952         * gtk/generate-gtkdoc:
953         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
954
955 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
956
957         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
958         https://bugs.webkit.org/show_bug.cgi?id=87668
959
960         Reviewed by Ryosuke Niwa.
961
962         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
963         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
964         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
965
966         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
967         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
968
969 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
970
971         [EFL] Refactor ewk_view_context_paint code.
972         https://bugs.webkit.org/show_bug.cgi?id=85588
973
974         Reviewed by Hajime Morita.
975
976         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
977
978 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
979
980         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
981         https://bugs.webkit.org/show_bug.cgi?id=87869
982
983         Reviewed by Andreas Kling.
984
985         Replace %lld by PRId64 macro to print an int64_t value and silent a
986         compilation warning on 64-Bit.
987
988         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
989         (onExceededApplicationCacheQuota):
990
991 2012-06-03  Varun Jain  <varunjain@google.com>
992
993         [chromium] Add new gesture type (two finger tap) that triggers context menu.
994         https://bugs.webkit.org/show_bug.cgi?id=88173
995
996         Reviewed by Adam Barth.
997
998         * DumpRenderTree/chromium/EventSender.cpp:
999         (EventSender::EventSender):
1000         (EventSender::gestureTwoFingerTap):
1001         (EventSender::gestureEvent):
1002         * DumpRenderTree/chromium/EventSender.h:
1003         (EventSender):
1004
1005 2012-06-02  Zeno Albisser  <zeno@webkit.org>
1006
1007         Fix and enable WebGL for WebKit2 on Qt.
1008         https://bugs.webkit.org/show_bug.cgi?id=86214
1009
1010         Enable WebGL by default for Qt MiniBrowser.
1011
1012         Reviewed by Noam Rosenthal.
1013
1014         * MiniBrowser/qt/qml/BrowserWindow.qml:
1015
1016 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
1017
1018         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
1019         https://bugs.webkit.org/show_bug.cgi?id=88164
1020
1021         Reviewed by Kentaro Hara.
1022
1023         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
1024         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
1025
1026         * Scripts/VCSUtils.pm:
1027         (adjustPathForRecentRenamings):
1028         (fixChangeLogPatch):
1029
1030 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1031
1032         Rename test_expectations.txt to TestExpectations
1033         https://bugs.webkit.org/show_bug.cgi?id=86690
1034
1035         Reviewed by Dirk Pranke.
1036
1037         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
1038         We can the code to read test_expectations.txt once we've successfully transitioned.
1039
1040         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1041         (TestExpectationParser._check_path_does_not_exist):
1042         (TestExpectationParser._tokenize):
1043         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
1044         * Scripts/webkitpy/layout_tests/port/base.py:
1045         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
1046         test_expectations.txt if one exists and the path to TestExpectations otherwise.
1047         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1048         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
1049         virtual.
1050         * Scripts/webkitpy/layout_tests/port/chromium.py:
1051         (ChromiumPort.path_from_chromium_base):
1052         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1053         (ChromiumAndroidPort.test_expectations):
1054         * Scripts/webkitpy/layout_tests/port/test.py:
1055         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
1056         (TestPort.__init__):
1057         * Scripts/webkitpy/layout_tests/port/webkit.py:
1058         (WebKitPort.baseline_search_path):
1059         (WebKitPort.test_expectations):
1060         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
1061         tests to base as a follow up.
1062         (WebKitPortTest.test_path_to_test_expectations_file):
1063         (test_test_expectations):
1064         (test_legacy_test_expectations):
1065         * Scripts/webkitpy/style/checker.py:
1066         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
1067         with one for TestExpectations.
1068         * Scripts/webkitpy/style/checkers/test_expectations.py:
1069         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
1070         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1071         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
1072         test_expectations.txt.
1073         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1074         (TestExpectationsTestCase.assert_lines_lint):
1075         * Scripts/webkitpy/tool/commands/queries.py:
1076         (PrintExpectations.__init__):
1077         * Scripts/webkitpy/tool/commands/rebaseline.py:
1078         (RebaselineExpectations):
1079         * Scripts/webkitpy/tool/steps/commit.py:
1080         (Commit._check_test_expectations):
1081         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1082         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
1083         (CommitTest.test_check_test_expectations): For TestExpectations.
1084         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
1085         * TestResultServer/static-dashboards/dashboard_base.js:
1086         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
1087         Error only when neither exists.
1088         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1089         (processMissingAndExtraExpectations):
1090         (htmlForTestsWithExpectationsButNoFailures):
1091         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1092
1093 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
1094
1095         Remove dependency from ImageDiff to WTF
1096         https://bugs.webkit.org/show_bug.cgi?id=88147
1097
1098         Reviewed by Adam Barth.
1099
1100         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1101
1102 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1103
1104         NRWT seems to leak (more?) temp dirs
1105         https://bugs.webkit.org/show_bug.cgi?id=88126
1106
1107         Re-land r119297 with chromium fix (weren't calling the
1108         super() method if not in --test-shell mode in start().
1109         Add unit tests to chromium_unittest as well to check.
1110
1111         * Scripts/webkitpy/layout_tests/port/chromium.py:
1112         (ChromiumDriver.start):
1113         * Scripts/webkitpy/layout_tests/port/webkit.py:
1114         (WebKitDriver.__del__):
1115         (WebKitDriver._start):
1116         (WebKitDriver.run_test):
1117         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1118         (WebKitDriverTest.test_check_for_driver_crash):
1119         (WebKitDriverTest.test_stop_cleans_up_properly):
1120         (WebKitDriverTest):
1121         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1122         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1123         (ChromiumDriverTest.test_stop_cleans_up_properly):
1124         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
1125
1126 2012-06-01  Tim Horton  <timothy_horton@apple.com>
1127
1128         Lots of "failed download-built-product" on Apple bots
1129         https://bugs.webkit.org/show_bug.cgi?id=88158
1130
1131         Reviewed by Jessie Berlin.
1132         
1133         Disable mergeRequests on all Apple builders. This is a speculative fix.
1134
1135         * BuildSlaveSupport/build.webkit.org-config/config.json:
1136
1137 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1138
1139         Unreviewed, rolling out r119297.
1140         http://trac.webkit.org/changeset/119297
1141         https://bugs.webkit.org/show_bug.cgi?id=88156
1142
1143         May have broken Chromium bots (Requested by rniwa on #webkit).
1144
1145         * Scripts/webkitpy/layout_tests/port/webkit.py:
1146         (WebKitDriver.__del__):
1147         (WebKitDriver.run_test):
1148         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1149         (WebKitDriverTest.test_check_for_driver_crash):
1150         (WebKitDriverTest.test_stop_cleans_up_properly):
1151
1152 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1153
1154         nrwt seems to leak tmpdirs
1155         https://bugs.webkit.org/show_bug.cgi?id=88126
1156
1157         Reviewed by Ojan Vafai.
1158
1159         Fix leak possibly introduced in r118979 - we now will
1160         make sure we clean up any stale temp directories during the
1161         start routine and attempt to clean up again in __del__. It
1162         turns out that asserting in __del__ logs a message but is
1163         caught by the runtime, so it's mostly useless.
1164
1165         * Scripts/webkitpy/layout_tests/port/webkit.py:
1166         (WebKitDriver.__del__):
1167         (WebKitDriver._start):
1168         (WebKitDriver.run_test):
1169         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1170         (WebKitDriverTest.test_check_for_driver_crash):
1171         (WebKitDriverTest.test_stop_cleans_up_properly):
1172         (WebKitDriverTest):
1173         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1174
1175 2012-06-01  Michael Saboff  <msaboff@apple.com>
1176
1177         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
1178         https://bugs.webkit.org/show_bug.cgi?id=88109
1179
1180         Reviewed by Geoffrey Garen.
1181
1182         Additional test case.
1183
1184         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1185         (TestWebKitAPI::TEST):
1186
1187 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
1188
1189         [Qt] Use -Werror only in developer builds
1190
1191         Rubber-stamped by Tor Arne Vestbø.
1192
1193         In production builds -Werror with custom toolchains and wierd system
1194         headers, -Werror is of no use and just creates confusion. So use it
1195         only if Qt is configured with -developer-build.
1196
1197         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
1198         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
1199         only if qt_developer_build is set.
1200
1201 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
1202
1203         [watchlist] Add myself to loader and v8 bindings changes
1204         https://bugs.webkit.org/show_bug.cgi?id=88112
1205
1206         Reviewed by Adam Barth.
1207
1208         * Scripts/webkitpy/common/config/watchlist:
1209
1210 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
1211
1212         Adding Jacky Jiang to committers.py
1213         https://bugs.webkit.org/show_bug.cgi?id=88122
1214
1215         Reviewed by Rob Buis.
1216
1217         Adding myself to committers.py as a Committer.
1218
1219         * Scripts/webkitpy/common/config/committers.py:
1220
1221 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1222
1223         Fix Windows build.
1224
1225         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1226
1227 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1228
1229         Windows WK2 MouseMoveAfterCrash API test failing
1230         https://bugs.webkit.org/show_bug.cgi?id=69982
1231
1232         Disable the test on Windows to get the bots greener.
1233
1234         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1235         (TestWebKitAPI::TEST):
1236
1237 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1238
1239         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
1240         https://bugs.webkit.org/show_bug.cgi?id=86866
1241
1242         Reviewed by Adam Barth.
1243
1244         Catch new "intent,service,register" signal on the frame and print out
1245         information about the Web Intent service in EFL's DumpRenderTree.
1246
1247         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1248         (DumpRenderTreeChrome::createView):
1249         (DumpRenderTreeChrome::onFrameCreated):
1250         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
1251         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1252         (DumpRenderTreeChrome):
1253
1254 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
1255
1256         The ChangeLog parser cannot handle reviewers with initials in their name
1257         https://bugs.webkit.org/show_bug.cgi?id=87864
1258
1259         Reviewed by Ryosuke Niwa.
1260
1261         Add support in the ChangeLog parser for reviewer names that have
1262         initials in them.
1263
1264         * Scripts/webkitpy/common/checkout/changelog.py:
1265         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
1266         in the replacement string. This allows for matching the word characters before a
1267         period, without totally throwing them away.
1268         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
1269         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1270         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
1271
1272 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1273
1274         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
1275         https://bugs.webkit.org/show_bug.cgi?id=86865
1276
1277         Reviewed by Adam Barth.
1278
1279         Add deliverWebIntent method to LayoutTestController and provide
1280         implementation for EFL port.
1281
1282         * DumpRenderTree/LayoutTestController.cpp:
1283         (deliverWebIntentCallback):
1284         (LayoutTestController::staticFunctions):
1285         * DumpRenderTree/LayoutTestController.h:
1286         (LayoutTestController):
1287         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1288         (LayoutTestController::deliverWebIntent):
1289         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1290         (LayoutTestController::deliverWebIntent):
1291         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1292         (LayoutTestController::deliverWebIntent):
1293         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1294         (LayoutTestController::deliverWebIntent):
1295         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1296         (LayoutTestController::deliverWebIntent):
1297         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1298         (LayoutTestController::deliverWebIntent):
1299
1300 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1301
1302         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
1303
1304         Reviewed by Simon Hausmann.
1305
1306         * Tools.pro:
1307
1308 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1309
1310         Add public page loading performance tests using web-page-replay
1311         https://bugs.webkit.org/show_bug.cgi?id=84008
1312
1313         Reviewed by Dirk Pranke.
1314
1315         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
1316         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
1317         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
1318
1319         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
1320         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
1321         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
1322         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
1323
1324         * Scripts/webkitpy/layout_tests/port/driver.py:
1325         (Driver.is_external_http_test): Added.
1326         * Scripts/webkitpy/layout_tests/port/webkit.py:
1327         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
1328         * Scripts/webkitpy/performance_tests/perftest.py:
1329         (PerfTest.__init__): Takes port.
1330         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
1331         (PerfTest):
1332         (PerfTest.run): Calls run_single.
1333         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
1334         (ChromiumStylePerfTest.__init__):
1335         (PageLoadingPerfTest.__init__):
1336         (PageLoadingPerfTest.run):
1337         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
1338         (ReplayServer.__init__):
1339         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
1340         but it caused a dead lock on some web pages.
1341         (ReplayServer.stop):
1342         (ReplayServer.__del__):
1343         (ReplayPerfTest):
1344         (ReplayPerfTest.__init__):
1345         (ReplayPerfTest._start_replay_server):
1346         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
1347         The subsequent runs of the same test will just use test.wpr.
1348         (ReplayPerfTest.run_single):
1349         (PerfTestFactory):
1350         (PerfTestFactory.create_perf_test):
1351         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1352         (MainTest.test_parse_output):
1353         (MainTest.test_parse_output_with_failing_line):
1354         (TestPageLoadingPerfTest.test_run):
1355         (TestPageLoadingPerfTest.test_run_with_bad_output):
1356         (TestReplayPerfTest):
1357         (TestReplayPerfTest.ReplayTestPort):
1358         (TestReplayPerfTest.ReplayTestPort.__init__):
1359         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
1360         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
1361         (TestReplayPerfTest.ReplayTestPort._driver_class):
1362         (TestReplayPerfTest.MockReplayServer):
1363         (TestReplayPerfTest.MockReplayServer.__init__):
1364         (TestReplayPerfTest.MockReplayServer.stop):
1365         (TestReplayPerfTest._add_file):
1366         (TestReplayPerfTest._setup_test):
1367         (TestReplayPerfTest.test_run_single):
1368         (TestReplayPerfTest.test_run_single.run_test):
1369         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
1370         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
1371         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
1372         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
1373         (TestReplayPerfTest.test_prepare):
1374         (TestReplayPerfTest.test_prepare.run_test):
1375         (TestReplayPerfTest.test_prepare_calls_run_single):
1376         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
1377         (TestPerfTestFactory.test_regular_test):
1378         (TestPerfTestFactory.test_inspector_test):
1379         (TestPerfTestFactory.test_page_loading_test):
1380         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1381         (PerfTestsRunner):
1382         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
1383         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
1384         (PerfTestsRunner._collect_tests._is_test_file):
1385         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
1386         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1387         (create_runner):
1388         (run_test):
1389         (_tests_for_runner):
1390         (test_run_test_set):
1391         (test_run_test_set_kills_drt_per_run):
1392         (test_run_test_pause_before_testing):
1393         (test_run_test_set_for_parser_tests):
1394         (test_run_test_set_with_json_output):
1395         (test_run_test_set_with_json_source):
1396         (test_run_test_set_with_multiple_repositories):
1397         (test_run_with_upload_json):
1398         (test_upload_json):
1399         (test_upload_json.MockFileUploader.upload_single_text_file):
1400         (_add_file):
1401         (test_collect_tests):
1402         (test_collect_tests_with_multile_files):
1403         (test_collect_tests_with_multile_files.add_file):
1404         (test_collect_tests_with_skipped_list):
1405         (test_collect_tests_with_page_load_svg):
1406         (test_collect_tests_should_ignore_replay_tests_by_default):
1407         (test_collect_tests_with_replay_tests):
1408         (test_parse_args):
1409         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
1410         (AutoinstallImportHook.find_module):
1411         (AutoinstallImportHook._install_webpagereplay):
1412
1413 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
1414
1415         Support building the Android port of chromium with Ninja
1416         https://bugs.webkit.org/show_bug.cgi?id=87545
1417
1418         Reviewed by Adam Barth.
1419
1420         Ensures that shared libraries are looked up in a generator-agnostic
1421         way and that output is placed in the correct directory.
1422
1423         Depends on http://codereview.chromium.org/10386188/
1424
1425         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1426
1427 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
1428
1429         [Chromium] Chromium DRT should be able to load external resources
1430         https://bugs.webkit.org/show_bug.cgi?id=87893
1431
1432         Reviewed by Dirk Pranke.
1433
1434         Allow external resources to be loaded when the main frame's URL is also an external resource.
1435         This change is analogous to r118231 for Mac port.
1436
1437         * DumpRenderTree/chromium/WebViewHost.cpp:
1438         (blockRequest):
1439         (isLocalhost):
1440         (hostIsUsedBySomeTestsToGenerateError):
1441         (WebViewHost::willSendRequest):
1442
1443 2012-05-31  Anders Carlsson  <andersca@apple.com>
1444
1445         Build fixes.
1446
1447         Disable the C++11 extensions warning.
1448
1449         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1450         * TestWebKitAPI/Configurations/Base.xcconfig:
1451         * WebKitTestRunner/Configurations/Base.xcconfig:
1452
1453 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
1454
1455         [WK2] window.internals settings are not reset between tests
1456         https://bugs.webkit.org/show_bug.cgi?id=87783
1457
1458         Reviewed by Mihai Parparita.
1459
1460         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1461         (WTR::InjectedBundle::done): Call resetAfterTest().
1462
1463         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1464         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
1465         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
1466         This needs to be done after a tets, because the code assumes that there is an object
1467         with this name in global scope.
1468
1469         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1470
1471 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1472
1473         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
1474         https://bugs.webkit.org/show_bug.cgi?id=85006
1475
1476         Reviewed by Tor Arne Vestbø.
1477
1478         Added navigation_policy_decision implementation for DumpRenderTreeView.
1479         Added LayoutTestController::setCustomPolicyDelegate implementation.
1480         Modified LayoutTestController::waitForPolicyDelegate.
1481
1482         * DumpRenderTree/efl/DumpRenderTree.cpp:
1483         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1484         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1485         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1486         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1487         (navigationTypeToString): aux function
1488         (onNavigationPolicyDecision): navigation_policy_decision implementation
1489         (drtViewAdd):
1490         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1491         (LayoutTestController::setCustomPolicyDelegate):
1492         (LayoutTestController::waitForPolicyDelegate):
1493
1494 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1495
1496         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
1497         https://bugs.webkit.org/show_bug.cgi?id=86195
1498
1499         Reviewed by Gustavo Noronha Silva.
1500
1501         Implement clearApplicationCacheForOrigin in EFL
1502         LayoutTestController.
1503
1504         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1505         (LayoutTestController::clearApplicationCacheForOrigin):
1506
1507 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1508
1509         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
1510         https://bugs.webkit.org/show_bug.cgi?id=87955
1511
1512         Reviewed by Simon Hausmann.
1513
1514         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1515         * DumpRenderTree/qt/EventSenderQt.cpp:
1516         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1517         * DumpRenderTree/qt/main.cpp:
1518         * QtTestBrowser/cookiejar.cpp:
1519         * QtTestBrowser/launcherwindow.cpp:
1520         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1521         * qmake/mkspecs/features/default_post.prf:
1522
1523 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
1524
1525         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
1526
1527         Rubber-stamped by Kenneth Rohde Christiansen.
1528
1529         * qmake/config.tests/libpng/libpng.pro:
1530
1531 2012-05-30  Peter Beverloo  <peter@chromium.org>
1532
1533         [Chromium] Automatically install 64-bit linker for Android
1534         https://bugs.webkit.org/show_bug.cgi?id=79780
1535
1536         Reviewed by Adam Barth.
1537
1538         Change the update-webkit-chromium script to check whether the 64-bit
1539         linker needs to be installed as part of the update process. The actual
1540         code for doing these checks and "installing" it has been added to the
1541         webkitdirs.pm script.
1542
1543         The linker itself is part of the third_party/aosp repository, which
1544         will be pulled in through the DEPS change.
1545
1546         * Scripts/update-webkit-chromium:
1547         * Scripts/webkitdirs.pm:
1548         (chromiumInstall64BitAndroidLinkerIfNeeded):
1549         (chromiumReplaceAndroidLinkerIfNeeded):
1550
1551 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1552
1553         https://bugs.webkit.org/show_bug.cgi?id=87803
1554         Layout tests often fail trying to stat nonexistent logs 
1555
1556         Reviewed by Dirk Pranke.
1557
1558         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
1559         try/catch block around accessing the logs as a precaution.
1560
1561         * Scripts/webkitpy/common/system/crashlogs.py:
1562         (CrashLogs._find_newest_log_darwin):
1563
1564 2012-05-30  Gavin Peters  <gavinp@chromium.org>
1565
1566         Add a LayoutTest for prerender remove after stop.
1567         https://bugs.webkit.org/show_bug.cgi?id=87860
1568
1569         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
1570         can be tested by LayoutTests now.
1571
1572         Reviewed by Adam Barth.
1573
1574         * DumpRenderTree/DumpRenderTree.gypi:
1575         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
1576         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
1577         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
1578         (MockWebPrerenderingSupport::add):
1579         (MockWebPrerenderingSupport::cancel):
1580         (MockWebPrerenderingSupport::abandon):
1581         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
1582         (MockWebPrerenderingSupport):
1583         * DumpRenderTree/chromium/TestShell.cpp:
1584         (TestShell::initialize):
1585         * DumpRenderTree/chromium/TestShell.h:
1586         (TestShell):
1587         * DumpRenderTree/chromium/WebViewHost.cpp:
1588         (WebViewHost::willAddPrerender):
1589         (WebViewHost::setWebWidget):
1590         * DumpRenderTree/chromium/WebViewHost.h:
1591         (WebViewHost):
1592
1593 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1594
1595         https://bugs.webkit.org/show_bug.cgi?id=87717
1596         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
1597
1598         Reviewed by Dirk Pranke.
1599
1600         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
1601         If there isn't a crash log found for the process add a message saying
1602         the process was unresponsive.
1603
1604         * Scripts/webkitpy/layout_tests/port/webkit.py:
1605         (WebKitDriver.__init__):
1606         (WebKitDriver._check_for_driver_crash):
1607         (WebKitDriver.run_test):
1608         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1609         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
1610         (WebKitDriverTest):
1611         (WebKitDriverTest.test_check_for_driver_crash):
1612         * WebKitTestRunner/TestController.cpp:
1613         (WTR):
1614         (WTR::TestController::runTest):
1615
1616 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1617
1618         https://bugs.webkit.org/show_bug.cgi?id=87714
1619         Mac crash logs can take a really long time to be written out.
1620
1621         Reviewed by Dirk Pranke.
1622
1623         Make a second pass looking for crash logs after the tests have completed running.
1624
1625         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1626         (use_trac_links_in_results_html):
1627         (Manager.run):
1628         * Scripts/webkitpy/layout_tests/port/base.py:
1629         (Port.repository_paths):
1630         (Port.look_for_new_crash_logs):
1631         * Scripts/webkitpy/layout_tests/port/mac.py:
1632         (MacPort.look_for_new_crash_logs):
1633         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1634         (test_get_crash_log):
1635         (test_look_for_new_crash_logs):
1636         (test_look_for_new_crash_logs.fake_time_cb):
1637
1638 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1639
1640         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
1641
1642         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1643         (LayoutWebViewEventHandler::OnAlertEvent):
1644         (LayoutWebViewEventHandler::OnConfirmEvent):
1645         (LayoutWebViewEventHandler):
1646         (LayoutWebViewEventHandler::OnPromptEvent):
1647         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1648         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
1649
1650 2012-05-30  Ojan Vafai  <ojan@chromium.org>
1651
1652         Only give lint errors for -expected.png png files that lack a checksum
1653         https://bugs.webkit.org/show_bug.cgi?id=87875
1654
1655         Reviewed by Tony Chang.
1656
1657         We have other pngs in the tree, e.g. for the inspector, that legitimately
1658         lack a checksum.
1659
1660         * Scripts/webkitpy/style/checkers/png.py:
1661         (PNGChecker.check):
1662         * Scripts/webkitpy/style/checkers/png_unittest.py:
1663         (PNGCheckerTest.test_check):
1664
1665 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
1666
1667         nrwt: seems to leak temp dirs
1668         https://bugs.webkit.org/show_bug.cgi?id=87795
1669
1670         Reviewed by Ojan Vafai.
1671
1672         There appears to be a bug where the chromium bots are creating
1673         temporary directories and not cleaning them up that started
1674         after the switch to WebKitDriver. It's possible that __del__
1675         wasn't getting called in a timely manner (or at all), and it's
1676         generally bad style to rely on __del__ being called, so this
1677         code changes things so that we create a temp dir in
1678         driver.start() and remove it in driver.stop(). We could be
1679         paranoid and leave the __del__ code in, but there doesn't seem
1680         to be much advantage to it. If there are bugs that result in
1681         drivers being started but not stopped, we have other problems.
1682
1683         * Scripts/webkitpy/common/system/filesystem_mock.py:
1684         (MockFileSystem.__init__):
1685         (MockFileSystem._mktemp):
1686         (MockFileSystem.mkdtemp):
1687         * Scripts/webkitpy/layout_tests/port/webkit.py:
1688         (WebKitDriver.__init__):
1689         (WebKitDriver._start):
1690         (WebKitDriver.stop):
1691         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1692         (WebKitDriverTest.test_check_for_driver_crash):
1693         (WebKitDriverTest):
1694         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
1695         (WebKitDriverTest.test_stop_cleans_up_properly):
1696
1697 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1698
1699         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
1700         https://bugs.webkit.org/show_bug.cgi?id=86841
1701
1702         Reviewed by Adam Barth.
1703
1704         Print the number of MessagePorts for each new intent in EFL's DRT.
1705         This output is expected by several Web Intents test cases.
1706
1707         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1708         (DumpRenderTreeChrome::onFrameIntentNew):
1709
1710 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1711
1712         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
1713
1714         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1715
1716 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1717
1718         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
1719         https://bugs.webkit.org/show_bug.cgi?id=87829
1720
1721         Reviewed by Adam Barth.
1722
1723         EFL's LayoutTestController now makes uses of the new helper method in
1724         DumpRenderTreeSupportEfl in order to send the intent response. This is
1725         now needed because the Ewk_Intent_Request postResult / postFailure
1726         methods were made private.
1727
1728         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1729         (LayoutTestController::sendWebIntentResponse):
1730
1731 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
1732
1733         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
1734         https://bugs.webkit.org/show_bug.cgi?id=86296
1735
1736         Reviewed by Tony Chang.
1737
1738         * DumpRenderTree/win/DRTDataObject.cpp: Added.
1739         (cfHDropFormat):
1740         (cfFileNameWFormat):
1741         (cfUrlWFormat):
1742         (WCEnumFormatEtc):
1743         (WCEnumFormatEtc::WCEnumFormatEtc):
1744         (WCEnumFormatEtc::QueryInterface):
1745         (WCEnumFormatEtc::AddRef):
1746         (WCEnumFormatEtc::Release):
1747         (WCEnumFormatEtc::Next):
1748         (WCEnumFormatEtc::Skip):
1749         (WCEnumFormatEtc::Reset):
1750         (WCEnumFormatEtc::Clone):
1751         (DRTDataObject::createInstance):
1752         (DRTDataObject::DRTDataObject):
1753         (DRTDataObject::~DRTDataObject):
1754         (DRTDataObject::QueryInterface):
1755         (DRTDataObject::AddRef):
1756         (DRTDataObject::Release):
1757         (DRTDataObject::GetData):
1758         (DRTDataObject::GetDataHere):
1759         (DRTDataObject::QueryGetData):
1760         (DRTDataObject::GetCanonicalFormatEtc):
1761         (DRTDataObject::SetData):
1762         (DRTDataObject::CopyMedium):
1763         (DRTDataObject::EnumFormatEtc):
1764         (DRTDataObject::DAdvise):
1765         (DRTDataObject::DUnadvise):
1766         (DRTDataObject::EnumDAdvise):
1767         (DRTDataObject::clearData):
1768         * DumpRenderTree/win/DRTDataObject.h: Added.
1769         (DRTDataObject):
1770         * DumpRenderTree/win/DRTDropSource.cpp: Added.
1771         (DRTDropSource::DRTDropSource):
1772         (DRTDropSource::~DRTDropSource):
1773         (DRTDropSource::QueryInterface):
1774         (DRTDropSource::AddRef):
1775         (DRTDropSource::Release):
1776         (DRTDropSource::createInstance):
1777         (DRTDropSource::QueryContinueDrag):
1778         (DRTDropSource::GiveFeedback):
1779         * DumpRenderTree/win/DRTDropSource.h: Added.
1780         (DRTDropSource):
1781         * DumpRenderTree/win/DumpRenderTree.vcproj:
1782         * DumpRenderTree/win/EventSender.cpp:
1783         (beginDragWithFilesCallback):
1784
1785 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
1786
1787         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
1788         https://bugs.webkit.org/show_bug.cgi?id=58593
1789
1790         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
1791         to WebKitTestRunner's LayoutTestController. The flag is modified via the
1792         public C API of the WebProcess.
1793
1794         Reviewed by Darin Adler.
1795
1796         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1797         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1798         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
1799         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
1800         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1801
1802 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1803
1804         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
1805         https://bugs.webkit.org/show_bug.cgi?id=87848
1806
1807         Reviewed by Csaba Osztrogonác.
1808
1809         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
1810         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
1811         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
1812
1813         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1814         (DumpRenderTreeChrome::extraViews):
1815         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1816         (DumpRenderTreeChrome):
1817
1818 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1819
1820         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
1821         https://bugs.webkit.org/show_bug.cgi?id=87833
1822
1823         Reviewed by Tor Arne Vestbø.
1824
1825         Print "postProgressFinishedNotification" message if frame load finished 
1826         to unskip http/tests/loading/progress-finished-callback.html.
1827
1828         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1829         (DumpRenderTreeChrome::onFrameLoadFinished):
1830
1831 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
1832
1833         [EFL][WK2] Fix WebKit2-EFL build
1834         https://bugs.webkit.org/show_bug.cgi?id=83693
1835
1836         Reviewed by Carlos Garcia Campos.
1837
1838         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
1839
1840 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
1841
1842         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
1843         (They only used to check for Skipped in platform/qt-5.0-wk1)
1844         https://bugs.webkit.org/show_bug.cgi?id=87376
1845
1846         Reviewed by Csaba Osztrogonác.
1847
1848         * Scripts/old-run-webkit-tests:
1849         (buildPlatformResultHierarchy):
1850         * Scripts/webkitpy/layout_tests/port/qt.py:
1851         (QtPort.baseline_search_path):
1852
1853 2012-05-29  Ojan Vafai  <ojan@chromium.org>
1854
1855         Add a linter error for pngs that lack an embedded checksum
1856         https://bugs.webkit.org/show_bug.cgi?id=87793
1857
1858         Reviewed by Dirk Pranke.
1859
1860         * Scripts/read-checksum-from-png:
1861         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
1862         (read_checksum):
1863         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
1864         (ReadChecksumFromPngTest):
1865         (ReadChecksumFromPngTest.test_read_checksum):
1866         * Scripts/webkitpy/layout_tests/port/base.py:
1867         * Scripts/webkitpy/style/checkers/png.py:
1868         (PNGChecker.check):
1869         * Scripts/webkitpy/style/checkers/png_unittest.py:
1870         (PNGCheckerTest.test_check):
1871
1872 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1873
1874         https://bugs.webkit.org/show_bug.cgi?id=87720
1875         WebProcess is often killed due to being unresponsive on the bots
1876
1877         Reviewed by Alexey Proskuryakov.
1878
1879         Blind attempt to improve flakiness on the bots by reducing the number
1880         of crashes due to an unresponsive process.  This helped on my personal machine
1881         under stress conditions.  I don't have enough cores to hit the problem
1882         under normal conditions.
1883
1884         * WebKitTestRunner/TestController.cpp:
1885         (WTR):
1886
1887 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1888
1889         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
1890         https://bugs.webkit.org/show_bug.cgi?id=87779
1891
1892         Reviewed by Eric Seidel.
1893
1894         Update output to match the names in scm.py as per
1895         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
1896
1897         * Scripts/webkitpy/tool/commands/rebaseline.py:
1898         (RebaselineTest.execute):
1899         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1900         (test_rebaseline_test_and_print_scm_changes):
1901         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1902         (GardeningServerTest.test_rebaselineall):
1903
1904 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1905
1906         https://bugs.webkit.org/show_bug.cgi?id=87711
1907
1908         Reviewed by Jessie Berlin.
1909
1910         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
1911         are better maintained.
1912
1913         * BuildSlaveSupport/build.webkit.org-config/config.json:
1914
1915 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1916
1917         webkit-patch optimize-baselines should add/delete files in batches from the vcs
1918         https://bugs.webkit.org/show_bug.cgi?id=87538
1919
1920         Reviewed by Ojan Vafai.
1921
1922         Invoking git and svn on one file at a time is kinda slow. We
1923         should batch the add and rm operations together.
1924
1925         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1926         (BaselineOptimizer._move_baselines):
1927
1928 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1929
1930         garden-o-matic should rebaseline baselines in parallel
1931         https://bugs.webkit.org/show_bug.cgi?id=87451
1932
1933         Reviewed by Ojan Vafai.
1934                                                                                
1935         This modifies garden-o-matic so that we will fetch all                  
1936         of the baselines in parallel from the bots, and then                    
1937         optimize the baselines serially (since that should be fairly            
1938         quick and we get into trouble if we optimize in parallel due            
1939         to concurrent access to the source control system).                     
1940
1941         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
1942         so that the files that need to be modified in the SCM are returned to 
1943         garden-o-matic rather than actually added or removed. This is done so that
1944         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
1945         concurrently). In order to safely return the files (as a JSON dict) I
1946         needed to shift all of the logging in rebaseline-test to use the logging
1947         module (and hence log to stderr).
1948
1949         I also had to stub out a line in chromium.py that would get confused if
1950         the skia overrides file didn't exist in a mock checkout.
1951
1952         * Scripts/webkitpy/common/system/executive.py:
1953         (Executive.popen):
1954         (Executive):
1955         (Executive.run_in_parallel):
1956         (_run_command_thunk):
1957         * Scripts/webkitpy/common/system/executive_mock.py:
1958         (MockExecutive.run_in_parallel):
1959         * Scripts/webkitpy/common/system/executive_unittest.py:
1960         (ExecutiveTest.test_run_in_parallel):
1961         * Scripts/webkitpy/layout_tests/port/chromium.py:
1962         (ChromiumPort._expectations_file_contents):
1963         * Scripts/webkitpy/tool/commands/rebaseline.py:
1964         (AbstractRebaseliningCommand.__init__):
1965         (RebaselineTest.__init__):
1966         (RebaselineTest._copy_existing_baseline):
1967         (RebaselineTest._save_baseline):
1968         (RebaselineTest):
1969         (RebaselineTest._add_to_scm):
1970         (RebaselineTest._rebaseline_test):
1971         (RebaselineTest.execute):
1972         (RebaselineExpectations._rebaseline_port):
1973         (RebaselineExpectations.execute):
1974         (Rebaseline._builder_to_pull_from):
1975         (Rebaseline.execute):
1976         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1977         (test_rebaseline_updates_expectations_file):
1978         (test_rebaseline_test):
1979         (test_rebaseline_test_and_print_scm_changes):
1980         (test_rebaseline_and_copy_test):
1981         (test_rebaseline_and_copy_test_no_existing_result):
1982         (test_rebaseline_and_copy_test_with_lion_result):
1983         (test_rebaseline_and_copy_no_overwrite_test):
1984         (test_rebaseline_expectations):
1985         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1986         (GardeningHTTPRequestHandler._rebaseline_commands):
1987         (GardeningHTTPRequestHandler):
1988         (GardeningHTTPRequestHandler._files_to_add):
1989         (GardeningHTTPRequestHandler._optimize_baselines):
1990         (GardeningHTTPRequestHandler.rebaselineall):
1991         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1992         (GardeningServerTest._post_to_path):
1993         (GardeningServerTest.test_rebaselineall):
1994         (GardeningServerTest.test_rebaselineall.run_command):
1995
1996 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
1997
1998         Fix the type of dispatch_time() offset
1999
2000         Rubber-stamped by Joseph Pecoraro.
2001
2002         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
2003
2004         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2005         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2006
2007 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
2008
2009         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
2010
2011         [BlackBerry] OpenGL content is not rendered on simulator
2012         https://bugs.webkit.org/show_bug.cgi?id=87721
2013
2014         Reviewed by George Staikos.
2015
2016         Fixed by enabling GLES2 support in simulator builds.
2017
2018         To experiment with building without OpenGL support, you can set the
2019         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
2020
2021         PR #150695
2022
2023         * Scripts/webkitdirs.pm:
2024         (blackberryCMakeArguments):
2025
2026 2012-05-29  David Barr  <davidbarr@chromium.org>
2027
2028         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
2029         https://bugs.webkit.org/show_bug.cgi?id=87685
2030
2031         Reviewed by Eric Seidel.
2032
2033         Add a configuration option for CSS image-resolution support, disabling it by default.
2034
2035         * Scripts/webkitperl/FeatureList.pm:
2036         * qmake/mkspecs/features/features.pri:
2037
2038 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2039
2040         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
2041
2042         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
2043             valid for C++/ObjC++ but not for C [enabled by default]"
2044
2045         Reviewed by Simon Hausmann.
2046
2047         * qmake/mkspecs/features/unix/default_post.prf:
2048
2049 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2050
2051         [Qt] Sync up favicon-implementation with WebView url changes in r118158
2052
2053         https://bugs.webkit.org/show_bug.cgi?id=87133
2054
2055         We now base64-encode the page url in the image-provider url, so that any
2056         normalization done by QUrl will not mess up the page-url. The logic of
2057         creating and parsing the provider-url has been moved into the image
2058         provider, to keep it in one place.
2059
2060         We were also releasing icons (even ones we hadn't retained), which we can't
2061         do since we don't know when the icon url is no longer in use.
2062
2063         Reviewed-by Simon Hausmann.
2064
2065         * MiniBrowser/qt/icons/favicon.png:
2066         * MiniBrowser/qt/qml/BrowserWindow.qml:
2067
2068 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2069
2070         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
2071         https://bugs.webkit.org/show_bug.cgi?id=87654
2072
2073         Reviewed by Csaba Osztrogonác.
2074
2075         Event sender provides strings for all the key events.
2076         Also KeyEventInfo constructor parameters order was changed to simplify the case when
2077         a key event has empty string.
2078
2079         * DumpRenderTree/efl/EventSender.cpp:
2080         (KeyEventInfo::KeyEventInfo):
2081         (keyPadNameFromJSValue):
2082         (keyNameFromJSValue):
2083
2084 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2085
2086         [Qt] Cancel potential url-edit when going back/forward
2087
2088         Reviewed by Kenneth Rohde Christiansen.
2089
2090         * MiniBrowser/qt/qml/BrowserWindow.qml:
2091
2092 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
2093
2094         [EFL] Compilation warning in DumpRenderTreeView.cpp
2095         https://bugs.webkit.org/show_bug.cgi?id=87636
2096
2097         Reviewed by Filip Pizlo.
2098
2099         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
2100         specifier in printf. Also fix the return type for
2101         onExceededApplicationCacheQuota callback.
2102
2103         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2104         (onExceededApplicationCacheQuota):
2105
2106 2012-05-29  Hironori Bono  <hbono@chromium.org>
2107
2108         Adding Hironori Bono to committers.py.
2109         https://bugs.webkit.org/show_bug.cgi?id=87697
2110
2111         * Scripts/webkitpy/common/config/committers.py:
2112
2113 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
2114
2115         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
2116         https://bugs.webkit.org/show_bug.cgi?id=80135
2117
2118         Reviewed by Rob Buis.
2119
2120         Implemented interface function didReceiveAuthenticationChallenge in class
2121         DumpRenderTree.
2122
2123         Resubmit the patch reverted by r115104 after the digest infinite loop
2124         issue for BlackBerry porting get identified and fixed.
2125
2126         Internally reviewed by Joe Mason <jmason@rim.com>
2127
2128         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2129         (drtCredentialDescription):
2130         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
2131         (WebKit):
2132         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2133         (WebCore):
2134         (DumpRenderTree):
2135
2136 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2137
2138         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
2139         https://bugs.webkit.org/show_bug.cgi?id=42328
2140
2141         Reviewed by Eric Seidel.
2142
2143         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
2144         move to windows.internals.settings.
2145
2146         * DumpRenderTree/LayoutTestController.cpp:
2147         (LayoutTestController::staticFunctions):
2148         * DumpRenderTree/LayoutTestController.h:
2149         (LayoutTestController):
2150         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2151         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2152         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2153         (DRTDevToolsAgent):
2154         * DumpRenderTree/chromium/LayoutTestController.cpp:
2155         (LayoutTestController::LayoutTestController):
2156         * DumpRenderTree/chromium/LayoutTestController.h:
2157         (LayoutTestController):
2158         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2159         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2160         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2161         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2162         * DumpRenderTree/mac/DumpRenderTree.mm:
2163         (resetWebViewToConsistentStateBeforeTesting):
2164         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2165         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2166         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2167         (LayoutTestController):
2168         * DumpRenderTree/win/DumpRenderTree.cpp:
2169         (resetWebViewToConsistentStateBeforeTesting):
2170         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2171         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2172         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2173         (LayoutTestController):
2174
2175 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2176
2177         Move allowRoundingHacks to Internals interface
2178         https://bugs.webkit.org/show_bug.cgi?id=87328
2179
2180         Reviewed by Hajime Morita.
2181
2182         Remove allowRoundingHacks functions, because it is able to work in the
2183         cross-port way through the Internals interface.
2184
2185         * DumpRenderTree/LayoutTestController.cpp:
2186         (LayoutTestController::staticFunctions):
2187         * DumpRenderTree/LayoutTestController.h:
2188         (LayoutTestController):
2189         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2190         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2191         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2192         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2193         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2194         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2195
2196 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
2197
2198         Fix mac build with older XCode by defining NSEC_PER_MSEC.
2199         https://bugs.webkit.org/show_bug.cgi?id=87616
2200
2201         Reviewed by Hajime Morita.
2202
2203         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
2204         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
2205         Patch just adds a #ifndef / #define check.
2206
2207         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2208         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2209
2210 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2211
2212         [EFL] Enable blob support for the EFL port
2213         https://bugs.webkit.org/show_bug.cgi?id=85363
2214
2215         Reviewed by Hajime Morita.
2216
2217         Enable Blob support by default for the EFL port.
2218
2219         * Scripts/webkitperl/FeatureList.pm:
2220
2221 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
2222
2223         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
2224         https://bugs.webkit.org/show_bug.cgi?id=87582
2225
2226         Reviewed by Darin Adler.
2227
2228         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
2229         possible to test pages in a similar way as they are loaded in Browsers.
2230
2231         * DumpRenderTree/LayoutTestController.cpp:
2232         (LayoutTestController::LayoutTestController):
2233         (setUseDeferredFrameLoadingCallback):
2234         (LayoutTestController::staticFunctions):
2235         * DumpRenderTree/LayoutTestController.h:
2236         (LayoutTestController::useDeferredFrameLoading):
2237         (LayoutTestController::setUseDeferredFrameLoading):
2238         (LayoutTestController):
2239         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2240         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2241
2242 2012-05-27  David Barton  <dbarton@mathscribe.com>
2243
2244         [watchlist] Improve MathML rule
2245         https://bugs.webkit.org/show_bug.cgi?id=87592
2246
2247         Reviewed by Adam Barth.
2248
2249         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
2250         but if this changed the rule would be slow. We protect against this, clarify the rule,
2251         and make it more similar to existing rules.
2252
2253         * Scripts/webkitpy/common/config/watchlist:
2254
2255 2012-05-27  David Barton  <dbarton@mathscribe.com>
2256
2257         [watchlist] Add myself & a rule for MathML
2258         https://bugs.webkit.org/show_bug.cgi?id=87586
2259
2260         Reviewed by Adam Barth.
2261
2262         * Scripts/webkitpy/common/config/watchlist:
2263
2264 2012-05-26  David Kilzer  <ddkilzer@apple.com>
2265
2266         Use xcrun to find path to nm for Mac port
2267         <http://webkit.org/b/87588>
2268
2269         Reviewed by Dan Bernstein.
2270
2271         * Scripts/webkitpy/layout_tests/port/mac.py:
2272         (MacPort.nm_command): Add. Tries to find a path for the nm
2273         command using xcrun.  Falls back to returning 'nm'.
2274         * Scripts/webkitpy/layout_tests/port/webkit.py:
2275         (WebKitPort.nm_command): Add. Returns 'nm'.
2276         (WebKitPort._webcore_symbols_string): Call self.nm_command().
2277
2278 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
2279
2280         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
2281
2282         Reviewed by Eric Seidel.
2283
2284         * DumpRenderTree/win/DumpRenderTree.vcproj:
2285         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2286         (FrameLoadDelegate::FrameLoadDelegate):
2287         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2288         * DumpRenderTree/win/FrameLoadDelegate.h:
2289         (FrameLoadDelegate):
2290         * DumpRenderTree/win/TextInputController.cpp: Added.
2291         (setMarkedTextCallback):
2292         (hasMarkedTextCallback):
2293         (unmarkTextCallback):
2294         (markedRangeCallback):
2295         (insertTextCallback):
2296         (firstRectForCharacterRangeCallback):
2297         (selectedRangeCallback):
2298         (TextInputController::makeWindowObject):
2299         (TextInputController::getJSClass):
2300         (TextInputController::staticValues):
2301         (TextInputController::staticFunctions):
2302         * DumpRenderTree/win/TextInputController.h: Added.
2303         (TextInputController):
2304         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
2305         (TextInputController::setMarkedText):
2306         (TextInputController::hasMarkedText):
2307         (TextInputController::unmarkText):
2308         (TextInputController::markedRange):
2309         (TextInputController::insertText):
2310         (TextInputController::firstRectForCharacterRange):
2311         (TextInputController::selectedRange):
2312
2313 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
2314
2315         webkitpy: change scm.add(), scm.delete() to accept multiple paths
2316         https://bugs.webkit.org/show_bug.cgi?id=87528
2317
2318         Reviewed by Ojan Vafai.
2319
2320         launching git or svn for individual files can be slow; this
2321         change will hand multiple paths at once to git and svn so they
2322         can be added in a batch.
2323
2324         * Scripts/webkitpy/common/checkout/scm/git.py:
2325         (Git.add_list):
2326         (Git.delete_list):
2327         * Scripts/webkitpy/common/checkout/scm/scm.py:
2328         (SCM.add):
2329         (SCM):
2330         (SCM.add_list):
2331         (SCM.delete):
2332         (SCM.delete_list):
2333         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2334         (MockSCM.add):
2335         (MockSCM):
2336         (MockSCM.add_list):
2337         (MockSCM.delete):
2338         (MockSCM.delete_list):
2339         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2340         (_shared_test_exists):
2341         (_shared_test_added_files):
2342         (_test_delete_list):
2343         * Scripts/webkitpy/common/checkout/scm/svn.py:
2344         (SVN.add_list):
2345         (SVN.delete_list):
2346
2347 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2348
2349         [NRWT] Add unit testing for perf tests on locked shards
2350         https://bugs.webkit.org/show_bug.cgi?id=87489
2351
2352         Reviewed by Dirk Pranke.
2353
2354         Adding utests that makes sure that perf tests are running in locked
2355         shards and by passing --no-http won't break NRWT (r118421).
2356
2357         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2358         (ShardingTests):
2359         (ShardingTests.test_shard_by_dir):
2360         (ShardingTests.test_shard_every_file):
2361         (ShardingTests.test_shard_in_two):
2362         (ShardingTests.test_multiple_locked_shards):
2363         (LockCheckingManager):
2364         (LockCheckingManager.__init__):
2365         (LockCheckingManager.handle_finished_list):
2366         (ManagerTest.test_http_locking):
2367         (ManagerTest):
2368         (ManagerTest.test_perf_locking):
2369         * Scripts/webkitpy/layout_tests/port/test.py:
2370
2371 2012-05-25  Jessie Berlin  <jberlin@apple.com>
2372
2373         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
2374         https://bugs.webkit.org/show_bug.cgi?id=87511
2375
2376         Reviewed by Alexey Proskuryakov.
2377
2378         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
2379
2380         * DumpRenderTree/win/EventSender.cpp:
2381         (keyDownCallback):
2382
2383 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
2384
2385         Adding Ken Buchanan to committers.py
2386         https://bugs.webkit.org/show_bug.cgi?id=87443
2387
2388         Unreviewed.
2389
2390         Adding self to committers.py as a Committer.
2391
2392         * Scripts/webkitpy/common/config/committers.py:
2393
2394 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2395
2396         [Qt] Buildfix for newer Qt5
2397         https://bugs.webkit.org/show_bug.cgi?id=87257
2398
2399         Reviewed by Simon Hausmann.
2400
2401         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
2402
2403 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2404
2405         [Qt] Unreviewed fix after r118484.
2406
2407         Enable CSS_EXCLUSIONS and CSS_REGIONS.
2408         They were enabled uncoditinally before r118484.
2409
2410         * qmake/mkspecs/features/features.pri:
2411
2412 2012-05-24  Tim Horton  <timothy_horton@apple.com>
2413
2414         Add feature defines for web-facing parts of CSS Regions and Exclusions
2415         https://bugs.webkit.org/show_bug.cgi?id=87442
2416         <rdar://problem/10887709>
2417
2418         Reviewed by Dan Bernstein.
2419
2420         * Scripts/webkitperl/FeatureList.pm:
2421
2422 2012-05-24  Hironori Bono  <hbono@chromium.org>
2423
2424         Enable grammar checking on Chromium when we paste text (Take 2)
2425         https://bugs.webkit.org/show_bug.cgi?id=74393
2426
2427         Reviewed by Ryosuke Niwa.
2428
2429         This change enables grammar checking on Chromium and implements a mock grammar
2430         checker to fix a failing test.
2431
2432         * DumpRenderTree/DumpRenderTree.gypi:
2433         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2434         (MockGrammarCheck::checkGrammarOfString):
2435         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2436         (WebKit):
2437         (MockGrammarCheck):
2438         * DumpRenderTree/chromium/WebViewHost.cpp:
2439         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2440
2441 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2442
2443         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
2444         https://bugs.webkit.org/show_bug.cgi?id=86842
2445
2446         Reviewed by Antonio Gomes.
2447
2448         Add support for overriding the application cache support preference
2449         through EFL's LayoutTestController.
2450
2451         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2452         (LayoutTestController::overridePreference):
2453
2454 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2455
2456         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
2457         https://bugs.webkit.org/show_bug.cgi?id=85209
2458
2459         Reviewed by Antonio Gomes.
2460
2461         Set developer extras setting called twice on the test startup. Hence, removing
2462         an unnecessary extra call which set wrong value. 
2463
2464         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2465         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2466
2467 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2468
2469         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2470         https://bugs.webkit.org/show_bug.cgi?id=86916
2471
2472         Reviewed by Adam Barth.
2473
2474         Note that if release and debug are failing differently, debug
2475         will be ignored ...
2476
2477         Note: also change the use of a fake port name from
2478         "mock-port-name" to "test-mac-leopard" to make it more friendly
2479         to the port factory ("mock" actually is a real port).
2480
2481         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2482         (GardeningHTTPRequestHandler._builders_to_fetch_from):
2483         (GardeningHTTPRequestHandler.rebaselineall):
2484         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2485         (GardeningServerTest.test_rebaselineall):
2486         (GardeningServerTest.test_rebaseline_new_port):
2487
2488 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2489
2490         nrwt: fix baseline search path for official chrome builders
2491         https://bugs.webkit.org/show_bug.cgi?id=87432
2492
2493         Reviewed by Tony Chang.
2494
2495         The official chrome builders need to use the win7 and SL
2496         baseline paths, not the XP and Leopard paths. Linux is correct.
2497
2498         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2499         (GoogleChromeMacPort.determine_full_port_name):
2500         (GoogleChromeWinPort.determine_full_port_name):
2501         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2502         (TestGoogleChromePort._verify_baseline_search_path_startswith):
2503         (TestGoogleChromePort.test_get_google_chrome_port):
2504
2505 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2506
2507         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
2508         https://bugs.webkit.org/show_bug.cgi?id=86800
2509
2510         Reviewed by Dirk Pranke.
2511
2512         Don't launch a HTTP server with lock based only on the existence of
2513         locked shards since we now run perf on locked shards too.
2514
2515         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2516         (Manager._run_tests):
2517
2518 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
2519
2520         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2521         https://bugs.webkit.org/show_bug.cgi?id=87128
2522
2523         Reviewed by Dirk Pranke.
2524
2525         * Scripts/webkitpy/layout_tests/port/base.py:
2526         (Port.driver_name):
2527         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2528         (ChromiumLinuxPort._path_to_driver):
2529         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2530         (ChromiumPortTest.test_driver_name_option):
2531         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2532         (ChromiumWinPort._path_to_driver):
2533         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2534         (parse_args):
2535
2536 2012-05-24  John Mellor  <johnme@chromium.org>
2537
2538         Font Boosting: Add compile flag and runtime setting
2539         https://bugs.webkit.org/show_bug.cgi?id=87394
2540
2541         Reviewed by Adam Barth.
2542
2543         Add ENABLE_FONT_BOOSTING.
2544
2545         * Scripts/webkitperl/FeatureList.pm:
2546         * qmake/mkspecs/features/features.pri:
2547
2548 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2549
2550         [EFL] [DRT] keyboard-related tests do not pass
2551         https://bugs.webkit.org/show_bug.cgi?id=85369
2552
2553         Reviewed by Gustavo Noronha Silva.
2554
2555         Add SHIFT modifier for capital letters as VK_ 
2556         codes do not distinguish between lows and caps and also to be consistent
2557         with other ports which send caps as lowercase letters with the shift key down.
2558
2559         * DumpRenderTree/efl/EventSender.cpp:
2560         (keyNameFromJSValue): 
2561
2562 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
2563
2564         [WK2] Let the client give local files universal access on a case by case basis
2565         https://bugs.webkit.org/show_bug.cgi?id=87174
2566         <rdar://problem/11024330>
2567
2568         Reviewed by Maciej Stachowiak.
2569
2570         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
2571         Added initialization of a new structure member to prevent build failure.
2572
2573 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
2574
2575         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
2576         https://bugs.webkit.org/show_bug.cgi?id=87203
2577
2578         Reviewed by Andreas Kling.
2579
2580         Add the required changes to make
2581         fast/events/keydown-leftright-keys.html pass after r118001.
2582
2583         * DumpRenderTree/efl/EventSender.cpp:
2584         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
2585         into the proper X11 keysym definitions.
2586
2587 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2588
2589         Unreviewed, rolling out r118352.
2590         http://trac.webkit.org/changeset/118352
2591         https://bugs.webkit.org/show_bug.cgi?id=87390
2592
2593         Caused 6 editing/spelling tests crash/fail on chromium in
2594         debug. (Requested by vsevik on #webkit).
2595
2596         * DumpRenderTree/DumpRenderTree.gypi:
2597         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
2598         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
2599         * DumpRenderTree/chromium/WebViewHost.cpp:
2600         (WebViewHost::finishLastTextCheck):
2601
2602 2012-05-24  Peter Beverloo  <peter@chromium.org>
2603
2604         Add John Mellor as a contributor
2605         https://bugs.webkit.org/show_bug.cgi?id=87389
2606
2607         Reviewed by Kenneth Rohde Christiansen.
2608
2609         John will be working on Font Boosting and is very involved with various
2610         web-facing subjects of Chrome for Android, such as viewport.
2611
2612         * Scripts/webkitpy/common/config/committers.py:
2613
2614 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2615
2616         [EFL][DRT] LayoutTestController's setCacheModel() implementation
2617         https://bugs.webkit.org/show_bug.cgi?id=86840
2618
2619         Reviewed by Csaba Osztrogonác.
2620
2621         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2622         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
2623         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2624         (LayoutTestController::setCacheModel): Implementation added.
2625
2626 2012-05-24  Hironori Bono  <hbono@chromium.org>
2627
2628         Enable grammar checking on Chromium when we paste text.
2629         https://bugs.webkit.org/show_bug.cgi?id=74393
2630
2631         Reviewed by Hajime Morita.
2632
2633         This change enables grammar checking on Chromium and implements a mock grammar
2634         checker to fix a failing test.
2635
2636         * DumpRenderTree/DumpRenderTree.gypi:
2637         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2638         (MockGrammarCheck::checkGrammarOfString):
2639         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2640         (WebKit):
2641         (MockGrammarCheck):
2642         * DumpRenderTree/chromium/WebViewHost.cpp:
2643         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2644
2645 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
2646
2647         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
2648
2649         * qmake/mkspecs/features/features.pri:
2650
2651 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2652
2653         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
2654         https://bugs.webkit.org/show_bug.cgi?id=86867
2655
2656         Reviewed by Adam Barth.
2657
2658         Add implementation for sendWebIntentResponse() in EFL's
2659         LayoutTestController and add empty implementation for other ports.
2660
2661         * DumpRenderTree/LayoutTestController.cpp:
2662         (sendWebIntentResponseCallback):
2663         (LayoutTestController::staticFunctions):
2664         * DumpRenderTree/LayoutTestController.h:
2665         (LayoutTestController):
2666         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2667         (LayoutTestController::sendWebIntentResponse):
2668         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2669         (DumpRenderTreeChrome::currentIntentRequest):
2670         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2671         (DumpRenderTreeChrome::onFrameIntentNew):
2672         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2673         (DumpRenderTreeChrome):
2674         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2675         (LayoutTestController::sendWebIntentResponse):
2676         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2677         (LayoutTestController::sendWebIntentResponse):
2678         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2679         (LayoutTestController::sendWebIntentResponse):
2680         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2681         (LayoutTestController::sendWebIntentResponse):
2682         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2683         (LayoutTestController::sendWebIntentResponse):
2684
2685 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2686
2687         [EFL] The EFL port has no support for title directionality
2688         https://bugs.webkit.org/show_bug.cgi?id=86462
2689
2690         Reviewed by Gustavo Noronha Silva.
2691
2692         Update "title,changed" signal handlers in DRT and EWebLauncher to
2693         reflect the change from const char* to Ewk_Text_With_Direction* type
2694         for the title.
2695
2696         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2697         (DumpRenderTreeChrome::onTitleChanged):
2698         * EWebLauncher/main.c:
2699         (title_set):
2700         (on_title_changed):
2701         (on_key_down):
2702
2703 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2704
2705         Change EFL debug build name with more detail one
2706         https://bugs.webkit.org/show_bug.cgi?id=87254
2707
2708         Reviewed by Ryosuke Niwa.
2709
2710         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
2711         In addition, remove efl-linux-debug triggerable since nobody uses it.
2712
2713         * BuildSlaveSupport/build.webkit.org-config/config.json:
2714
2715 2012-05-23  Kangil Han  <kangil.han@samsung.com>
2716
2717         [EFL][DRT] Fix WebCore library path and rebaseline result
2718         https://bugs.webkit.org/show_bug.cgi?id=86355
2719
2720         Reviewed by Dirk Pranke.
2721
2722         Currently EFL DRT uses wrong WebCore library path when running DRT.
2723         Therefore, this patch adjusted the path correctly.
2724
2725         * Scripts/webkitpy/layout_tests/port/efl.py:
2726         (EflPort._path_to_webcore_library):
2727
2728 2012-05-23  Ojan Vafai  <ojan@chromium.org>
2729
2730         add back the ability to disable flexbox
2731         https://bugs.webkit.org/show_bug.cgi?id=87147
2732
2733         Reviewed by Tony Chang.
2734
2735         * Scripts/webkitperl/FeatureList.pm:
2736
2737 2012-05-23  Tony Chang  <tony@chromium.org>
2738
2739         Remove the Chromium Grid Layout bot from the waterfall
2740         https://bugs.webkit.org/show_bug.cgi?id=87311
2741
2742         Reviewed by Ryosuke Niwa.
2743
2744         I removed the compiler define in r117613, so we don't need a separate
2745         bot to compile/test this code.
2746
2747         * BuildSlaveSupport/build.webkit.org-config/config.json:
2748
2749 2012-05-23  Ian Vollick  <vollick@chromium.org>
2750
2751         Add vollick to list of contributors.
2752         https://bugs.webkit.org/show_bug.cgi?id=87305
2753
2754         Reviewed by Adam Barth.
2755
2756         * Scripts/webkitpy/common/config/committers.py:
2757
2758 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2759
2760         [Chromium-Android] Fix chromium_android_unittest
2761         https://bugs.webkit.org/show_bug.cgi?id=87196
2762
2763         Reviewed by Tony Chang.
2764
2765         Update unit tests after ChromiumAndroidPort supported apk based
2766         DumpRenderTree.
2767
2768         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2769         (ChromiumAndroidPortTest):
2770         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
2771         (ChromiumAndroidPortTest.test_get_last_stacktrace):
2772         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
2773         (ChromiumAndroidDriverTest):
2774         (ChromiumAndroidDriverTest.setUp):
2775         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
2776         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
2777
2778 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2779
2780         [watchlist] Add myself and create a watch rule to catch Attribute related patches
2781         https://bugs.webkit.org/show_bug.cgi?id=87303
2782
2783         Reviewed by Alexis Menard.
2784
2785         * Scripts/webkitpy/common/config/watchlist:
2786
2787 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
2788
2789         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2790         https://bugs.webkit.org/show_bug.cgi?id=86916
2791
2792         Reviewed by Adam Barth.
2793
2794         This change pushes all of the logic for rebaselining a cluster
2795         of failures (a list of tests failing a list of suffixes on a
2796         list of bots) onto the server, so there is a single call from
2797         the web page; we will then be able to optimize the performance
2798         of the rebaselining better.
2799
2800         Also remove the 'optimizebaseline' entry point on garden-o-matic
2801         (and the client-side call) since we don't need it any more.
2802
2803         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2804         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2805         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2806         (GardeningHTTPRequestHandler.rebaselineall):
2807         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2808
2809 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
2810
2811         Mac DRT should be able to load external URLs for replay performance tests
2812         https://bugs.webkit.org/show_bug.cgi?id=86191
2813
2814         Reviewed by Alexey Proskuryakov.
2815
2816         Let external URL requests go through if the test file is not a local file or hosted at localhost.
2817         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
2818         "DumpRenderTree http://localhost:8000/".
2819
2820         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2821         (isLocalhost):
2822         (hostIsUsedBySomeTestsToGenerateError):
2823         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2824
2825 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
2826
2827         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
2828         debug symbols for easier debugging.
2829         https://bugs.webkit.org/show_bug.cgi?id=87151
2830
2831         Reviewed by Kevin Ollivier.
2832
2833         * waf/build/settings.py:
2834         (common_configure):
2835
2836 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2837
2838         Unreviewed. Move myself to reviewers.
2839
2840         * Scripts/webkitpy/common/config/committers.py:
2841
2842 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
2843
2844         [EFL] Implements the registerProtocolHandler method and option.
2845         https://bugs.webkit.org/show_bug.cgi?id=73638
2846
2847         Reviewed by Andreas Kling.
2848
2849         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
2850
2851 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
2852
2853         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
2854         https://bugs.webkit.org/show_bug.cgi?id=87221
2855
2856         Reviewed by Martin Robinson.
2857
2858         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
2859         rightShift key names into proper GDK key symbols.
2860
2861         * DumpRenderTree/gtk/EventSender.cpp:
2862         (createKeyPressEvent):
2863
2864 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2865
2866         [Qt] Make the web view's url property follow the active url
2867
2868         https://bugs.webkit.org/show_bug.cgi?id=77554
2869
2870         Update  the location bar in the minibrowser to behave
2871         a bit more like normal browsers in terms of when the url will change
2872         and how active focus is handled.
2873
2874         Reviewed by Simon Hausmann.
2875
2876         * MiniBrowser/qt/qml/BrowserWindow.qml:
2877
2878 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2879
2880         [Qt] Remove references to $$QT_SOURCE_TREE
2881
2882         With a modularized Qt, it's ambigious. What we really want is qtbase,
2883         which qtcore is a proxy for (we assume it will always live in qtbase).
2884
2885         Reviewed by Tor Arne Vestbø.
2886
2887         * DumpRenderTree/qt/DumpRenderTree.pro:
2888
2889 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2890
2891         [Qt] Fix qmake conditional for c++-11 compat warnings
2892
2893         Reviewed by Tor Arne Vestbø.
2894
2895         * qmake/mkspecs/features/unix/default_post.prf:
2896
2897 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2898
2899         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
2900         https://bugs.webkit.org/show_bug.cgi?id=85956
2901
2902         Reviewed by Gustavo Noronha Silva.
2903
2904         Catch new "load,provisional,failed" signal and print
2905         didFailProvisionalLoadWithError messages when LayoutTestController's
2906         dumpFrameLoadCallbacks() returns true. Also make sure the
2907         didFailLoadWithError message is not printed in case of provisional
2908         load failure.
2909
2910         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2911         (DumpRenderTreeChrome::createView):
2912         (DumpRenderTreeChrome::onFrameCreated):
2913         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
2914         (DumpRenderTreeChrome::onFrameLoadError):
2915         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2916         (DumpRenderTreeChrome):
2917
2918 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2919
2920         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
2921         https://bugs.webkit.org/show_bug.cgi?id=86366
2922
2923         Reviewed by Antonio Gomes.
2924
2925         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
2926
2927         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2928         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2929
2930 2012-05-22  Darin Adler  <darin@apple.com>
2931
2932         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
2933         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
2934
2935 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2936
2937         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
2938         https://bugs.webkit.org/show_bug.cgi?id=86922
2939
2940         Because we have new platformInit() in TestShellAndroid.cpp, and
2941         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
2942         is split into TestShellPosix.cpp and TestShellX11.cpp.
2943
2944         Reviewed by Kent Tamura.
2945
2946         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2947         * DumpRenderTree/DumpRenderTree.gypi:
2948         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
2949         (platformInit):
2950         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
2951         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
2952         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
2953         (AlarmHandler):
2954         (TestShell::waitTestFinished):
2955         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
2956         (openStartupDialog): from TestShellGtk.cpp
2957         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
2958         (setupFontconfig):
2959         (platformInit):
2960
2961 2012-05-22  Kangil Han  <kangil.han@samsung.com>
2962
2963         [EFL][DRT] Implement touch event
2964         https://bugs.webkit.org/show_bug.cgi?id=86720
2965
2966         Reviewed by Hajime Morita.
2967
2968         Currently EFL DRT doesn't support touch event.
2969         Therefore, this patch enabled it and implemented some eventSender function callbacks.
2970
2971         * DumpRenderTree/efl/EventSender.cpp:
2972         (TouchEventInfo::TouchEventInfo):
2973         (TouchEventInfo):
2974         (touchPointList):
2975         (sendTouchEvent):
2976         (addTouchPointCallback):
2977         (touchStartCallback):
2978         (updateTouchPointCallback):
2979         (touchMoveCallback):
2980         (cancelTouchPointCallback):
2981         (touchCancelCallback):
2982         (releaseTouchPointCallback):
2983         (touchEndCallback):
2984         (clearTouchPointsCallback):
2985         (setTouchModifierCallback):
2986         * Scripts/webkitperl/FeatureList.pm:
2987
2988 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2989
2990         [Chromium-Android] Fix chromium_android_unittest
2991         https://bugs.webkit.org/show_bug.cgi?id=87196
2992
2993         Not reviewed.
2994         Temporarily disable chromium_android_unittest.
2995
2996         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2997         (ChromiumAndroidPortTest):
2998         (ChromiumAndroidDriverTest):
2999
3000 2012-05-22  Jessie Berlin  <jberlin@apple.com>
3001
3002         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
3003         https://bugs.webkit.org/show_bug.cgi?id=64313
3004
3005         Reviewed by Jon Honeycutt.
3006
3007         Add it.
3008
3009         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3010         Make sure to generate the binding.
3011
3012         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3013         (WTR::LayoutTestController::setDefersLoading):
3014         Call WKBundlePageSetDefersLoading.
3015         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3016
3017 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3018
3019         [Chromium-Android] Run DumpRenderTree as an apk (python part)
3020         https://bugs.webkit.org/show_bug.cgi?id=86923
3021
3022         chromium_android.py is modified to support running DumpRenderTree as
3023         an apk, so that we can run the tests (e.g. video) requiring features
3024         implemented in Java on Android.
3025
3026         Reviewed by Adam Barth.
3027
3028         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3029         (ChromiumAndroidPort.__init__):
3030         (ChromiumAndroidPort.default_child_processes):
3031         (ChromiumAndroidPort.check_wdiff):
3032         (ChromiumAndroidPort.check_build):
3033         (ChromiumAndroidPort.start_helper):
3034         (ChromiumAndroidPort.skipped_layout_tests):
3035         (ChromiumAndroidPort):
3036         (ChromiumAndroidPort._path_to_driver):
3037         (ChromiumAndroidPort._get_crash_log):
3038         (ChromiumAndroidPort._push_executable):
3039         (ChromiumAndroidPort._run_adb_command):
3040         (ChromiumAndroidPort._get_last_stacktrace):
3041         (ChromiumAndroidPort._get_logcat):
3042         (ChromiumAndroidPort._setup_performance):
3043         (ChromiumAndroidDriver):
3044         (ChromiumAndroidDriver.__init__):
3045         (ChromiumAndroidDriver._command_wrapper):
3046         (ChromiumAndroidDriver.cmd_line):
3047         (ChromiumAndroidDriver._file_exists_on_device):
3048         (ChromiumAndroidDriver._deadlock_detector):
3049         (ChromiumAndroidDriver._start):
3050         (ChromiumAndroidDriver.run_test):
3051         (ChromiumAndroidDriver.stop):
3052         (ChromiumAndroidDriver._write_command_and_read_line):
3053         (ChromiumAndroidDriver._output_image):
3054         (ChromiumAndroidDriver._get_stderr):
3055
3056 2012-05-22  Joshua Bell  <jsbell@chromium.org>
3057
3058         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
3059
3060         Unreviewed gardening.
3061
3062         * Scripts/webkitpy/layout_tests/port/base.py:
3063         (Port.driver_name):
3064         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3065         (ChromiumLinuxPort._path_to_driver):
3066         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3067         (ChromiumPortTest.test_overrides_and_builder_names):
3068         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3069         (ChromiumWinPort._path_to_driver):
3070         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3071         (parse_args):
3072
3073 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3074
3075         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
3076         https://bugs.webkit.org/show_bug.cgi?id=87176
3077
3078         Reviewed by Tony Chang.
3079
3080         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3081         * DumpRenderTree/DumpRenderTree.gypi:
3082
3083 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
3084
3085         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
3086         https://bugs.webkit.org/show_bug.cgi?id=87128
3087
3088         Reviewed by Dirk Pranke.
3089
3090         * Scripts/webkitpy/layout_tests/port/base.py:
3091         (Port.driver_name):
3092         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3093         (ChromiumLinuxPort._path_to_driver):
3094         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3095         (ChromiumPortTest.test_driver_name_option):
3096         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3097         (ChromiumWinPort._path_to_driver):
3098         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3099         (parse_args):
3100
3101 2012-05-22  Jessie Berlin  <jberlin@apple.com>
3102
3103         WTR fix after r118001.
3104
3105         Rubber-stamped by Alexey Proskuryakov.
3106
3107         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
3108
3109         * WebKitTestRunner/mac/EventSenderProxy.mm:
3110         (WTR::EventSenderProxy::keyDown):
3111
3112 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
3113
3114         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
3115         https://bugs.webkit.org/show_bug.cgi?id=86684
3116
3117         Reviewed by Darin Fisher.
3118
3119         * DumpRenderTree/chromium/LayoutTestController.cpp:
3120         (LayoutTestController::numberOfPages):
3121         * DumpRenderTree/chromium/WebViewHost.cpp:
3122         (WebViewHost::printPage):
3123
3124 == Rolled over to ChangeLog-2012-05-22 ==