Make compare-results understand MotionMark
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-05  Saam Barati  <sbarati@apple.com>
2
3         Make compare-results understand MotionMark
4         https://bugs.webkit.org/show_bug.cgi?id=196666
5
6         Reviewed by Yusuke Suzuki.
7
8         * Scripts/compare-results:
9         (PLT5Results):
10         (detectMotionMark):
11         (detectMotionMark1_1):
12         (motionMarkResults):
13         (motionMark1_1Results):
14         (detectBenchmark):
15         (biggerIsBetter):
16         (main):
17
18 2019-04-05  Alex Christensen  <achristensen@webkit.org>
19
20         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
21         https://bugs.webkit.org/show_bug.cgi?id=196665
22         <rdar://45115669>
23
24         Reviewed by Geoff Garen.
25
26         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
27         (goBack):
28         (+[SimpleLookupContext sharedLookupContext]):
29         (-[SimpleLookupContext lookUpURL:completionHandler:]):
30         (TEST):
31         (+[Simple3LookupContext sharedLookupContext]): Deleted.
32         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
33
34 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
35
36         [ews-build] Add configuration and architecture for windows builders
37         https://bugs.webkit.org/show_bug.cgi?id=196660
38
39         Reviewed by Lucas Forschler.
40
41         * BuildSlaveSupport/ews-build/config.json:
42
43 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
44
45         webkitpy: Don't run subsequent rounds if interrupted
46         https://bugs.webkit.org/show_bug.cgi?id=196646
47
48         Reviewed by Aakash Jain.
49
50         * Scripts/webkitpy/layout_tests/controllers/manager.py:
51         (Manager.run): Bail out if interrupted.
52
53 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
54
55         Test sessionStorage in PSON private browsing mode
56         https://bugs.webkit.org/show_bug.cgi?id=196561
57
58         Reviewed by Alex Christensen.
59
60         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
61
62 2019-04-05  Commit Queue  <commit-queue@webkit.org>
63
64         Unreviewed, rolling out r243833.
65         https://bugs.webkit.org/show_bug.cgi?id=196645
66
67         This change breaks build of WPE and GTK ports (Requested by
68         annulen on #webkit).
69
70         Reverted changeset:
71
72         "[CMake][WTF] Mirror XCode header directories"
73         https://bugs.webkit.org/show_bug.cgi?id=191662
74         https://trac.webkit.org/changeset/243833
75
76 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
77
78         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
79         https://bugs.webkit.org/show_bug.cgi?id=196635
80
81         Reviewed by Antti Koivisto.
82         
83         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
84         for a test to enable async frame scrolling via:
85             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
86         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
87         
88         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
89
90         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
91         (WTR::InjectedBundle::beginTesting):
92         * WebKitTestRunner/TestController.cpp:
93         (WTR::TestController::resetPreferencesToConsistentValues):
94
95 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
96
97         Use a correct LC_RPATH when building with ASan
98         https://bugs.webkit.org/show_bug.cgi?id=196576
99
100         Reviewed by David Kilzer.
101
102         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
103         so that ../Frameworks is checked. This is simpler and more reliable than updating
104         each SPC service xcconfig.
105
106 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
107
108         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
109         https://bugs.webkit.org/show_bug.cgi?id=196629
110
111         Reviewed by Lucas Forschler.
112
113         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
114
115 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
116
117         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
118         https://bugs.webkit.org/show_bug.cgi?id=196618
119
120         Reviewed by Lucas Forschler.
121
122         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
123         (StatusBubble): Added QUEUE_TRIGGERS.
124         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
125         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
126         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
127         its parent(builder).
128
129 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
130
131         [ews-app] Status-bubble steps are sometimes displayed in reverse order
132         https://bugs.webkit.org/show_bug.cgi?id=196625
133
134         Reviewed by Lucas Forschler.
135
136         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
137         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
138
139 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
140
141         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
142         https://bugs.webkit.org/show_bug.cgi?id=196630
143
144         Reviewed by Wenson Hsieh.
145
146         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
147
148 2019-04-04  Youenn Fablet  <youenn@apple.com>
149
150         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
151         https://bugs.webkit.org/show_bug.cgi?id=196543
152
153         Reviewed by Alex Christensen.
154
155         * WebKitTestRunner/TestController.cpp:
156         (WTR::TestController::generatePageConfiguration):
157
158 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
159
160         [ews-app] Status bubble should not display skipped buildbot steps
161         https://bugs.webkit.org/show_bug.cgi?id=196584
162
163         Reviewed by Lucas Forschler.
164
165         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
166
167 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
168
169         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
170         https://bugs.webkit.org/show_bug.cgi?id=196620
171
172         Reviewed by Lucas Forschler.
173
174         * BuildSlaveSupport/ews-app/ews/config.py:
175
176 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
177
178         [Win] DumpRenderTreeWatchDog.py is not checked into source
179         https://bugs.webkit.org/show_bug.cgi?id=196567
180         <rdar://problem/49525901>
181
182         Reviewed by Lucas Forschler.
183
184         This script is used on Win EWS bots to terminate hanging DRT processes.
185
186         * EWSTools/dumprendertreewatchdog.py: Added.
187
188 2019-04-04  Chris Dumez  <cdumez@apple.com>
189
190         Unreviewed, roll out r243858 which made tests time out.
191
192         Disable new API tests on Windows instead.
193
194         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
195         (TestWebKitAPI::TEST):
196
197 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
198
199         [ATK] Cleanup WebPageAccessibilityObjectAtk
200         https://bugs.webkit.org/show_bug.cgi?id=196537
201
202         Reviewed by Michael Catanzaro.
203
204         Also consider files under atk directories as exceptions for GObject conventions.
205
206         * Scripts/webkitpy/style/checkers/cpp.py:
207         (check_identifier_name_in_declaration):
208
209 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
210
211         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
212         https://bugs.webkit.org/show_bug.cgi?id=196588
213         <rdar://problem/49365787>
214
215         Unreviewed build fix for Windows port.
216
217         error C3861: 'kill': identifier not found
218
219         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
220         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
221
222 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
223
224         [ews-build] Cancel build and similar operations should have authentication
225         https://bugs.webkit.org/show_bug.cgi?id=196520
226
227         Reviewed by Dewei Zhu.
228
229         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
230         environment variables.
231
232 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
233
234         [ews-build] Do not trigger queues which are not in production yet
235         https://bugs.webkit.org/show_bug.cgi?id=196581
236
237         Reviewed by Dewei Zhu.
238
239         * BuildSlaveSupport/ews-build/config.json:
240
241 2019-04-03  Chris Dumez  <cdumez@apple.com>
242
243         Unreviewed, fix typo in the name of API test added in r243848.
244
245         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
246         (TestWebKitAPI::TEST):
247
248 2019-04-03  Chris Dumez  <cdumez@apple.com>
249
250         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
251         https://bugs.webkit.org/show_bug.cgi?id=196588
252         <rdar://problem/49365787>
253
254         Reviewed by Ryosuke Niwa.
255
256         Add API test coverage.
257
258         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
259         (TestWebKitAPI::nullJavaScriptCallback):
260         (TestWebKitAPI::didCrashCheckFrames):
261         (TestWebKitAPI::TEST):
262
263 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
264
265         run-webkit-tests: Upload test results (new results database)
266         https://bugs.webkit.org/show_bug.cgi?id=196577
267         <rdar://problem/34841155>
268
269         Reviewed by Lucas Forschler.
270
271         * Scripts/webkitpy/layout_tests/controllers/manager.py:
272         (Manager.run): Upload results after each device shard, since the configuration will be
273         different for each device.
274         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
275         uploaded to a results database.
276         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
277         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
278
279 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
280
281         -apple-trailing-word is needed for browser detection
282         https://bugs.webkit.org/show_bug.cgi?id=196575
283
284         Unreviewed.
285
286         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
287
288 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
289
290         [CMake][WTF] Mirror XCode header directories
291         https://bugs.webkit.org/show_bug.cgi?id=191662
292
293         Reviewed by Konstantin Tokarev.
294
295         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
296         builds.
297
298         * CMakeLists.txt:
299         * DumpRenderTree/CMakeLists.txt:
300         * DumpRenderTree/PlatformWin.cmake:
301         * MiniBrowser/win/CMakeLists.txt:
302         * TestWebKitAPI/CMakeLists.txt:
303         * TestWebKitAPI/PlatformWin.cmake:
304         * WebKitTestRunner/PlatformGTK.cmake:
305         * WebKitTestRunner/PlatformWin.cmake:
306
307 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
308
309         [ews-app] Status bubble should not display certain infrastructure status messages
310         https://bugs.webkit.org/show_bug.cgi?id=196550
311
312         Reviewed by Lucas Forschler.
313
314         Do not display the steps which are un-needed for end-user. This information is still avaiable
315         if the user click on the bubble and look at the Buildbot build.
316         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
317         (StatusBubble._steps_messages):
318         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
319
320 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
321
322         [ews-build] Use https for sending data to ews-app
323         https://bugs.webkit.org/show_bug.cgi?id=196492
324
325         Reviewed by Lucas Forschler.
326
327         * BuildSlaveSupport/ews-build/events.py:
328
329 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
330
331         Remove support for -apple-trailing-word
332         https://bugs.webkit.org/show_bug.cgi?id=196525
333
334         Reviewed by Zalan Bujtas.
335
336         This CSS property is nonstandard and not used.
337
338         * Scripts/webkitperl/FeatureList.pm:
339         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
340
341 2019-04-03  Youenn Fablet  <youenn@apple.com>
342
343         Add a test for DOMCache on multiple browsing in case of private browsing
344         https://bugs.webkit.org/show_bug.cgi?id=196524
345
346         Reviewed by Alex Christensen.
347
348         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
349         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
350
351 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
352
353         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
354         https://bugs.webkit.org/show_bug.cgi?id=196540
355
356         Reviewed by Aakash Jain.
357
358         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
359
360 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
361
362         Add plumbing for a compatibility mode preference in WebKit
363         https://bugs.webkit.org/show_bug.cgi?id=196005
364
365         Reviewed by Tim Horton.
366
367         Add new API tests.
368
369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
370         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
371
372 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
373
374         [WPE][GTK] Update libsrtp dependency package for Debian
375         https://bugs.webkit.org/show_bug.cgi?id=196528
376
377         Reviewed by Frédéric Wang.
378
379         * gtk/install-dependencies:
380         * wpe/install-dependencies:
381
382 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
383
384         [WK2] Add support for Window's beforeprint / afterprint events
385         https://bugs.webkit.org/show_bug.cgi?id=196478
386         <rdar://problem/49535124>
387
388         Unreviewed build fix for MSVC.
389
390         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
391
392         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
393
394         * WebKitTestRunner/TestController.cpp:
395         (WTR::printFrame): Use int and float literals.
396
397 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
398
399         [ews-build] Reassign bots to queues
400
401         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
402
403 2019-04-02  Chris Dumez  <cdumez@apple.com>
404
405         [WK2] Add support for Window's beforeprint / afterprint events
406         https://bugs.webkit.org/show_bug.cgi?id=196478
407
408         Reviewed by Alex Christensen.
409
410         Add minimal implementation for printFrame in WebKitTestRunner.
411
412         * WebKitTestRunner/TestController.cpp:
413         (WTR::printFrame):
414         (WTR::TestController::createOtherPage):
415         (WTR::TestController::createWebViewWithOptions):
416
417 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
418
419         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
420         https://bugs.webkit.org/show_bug.cgi?id=196491
421
422         Reviewed by Lucas Forschler.
423
424         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
425
426 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
427
428         [ews-build] Configure buildbot try credentials in environment variables
429         https://bugs.webkit.org/show_bug.cgi?id=196501
430
431         Reviewed by Lucas Forschler.
432
433         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
434         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
435         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
436
437 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
438
439         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
440         https://bugs.webkit.org/show_bug.cgi?id=196496
441         <rdar://problem/49521634>
442
443         Reviewed by Chris Dumez.
444
445         Add new API tests (see WebKit ChangeLog for more detail).
446
447         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
448         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
449         (TEST):
450
451 2019-04-02  David Kilzer  <ddkilzer@apple.com>
452
453         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
454         <https://webkit.org/b/196499>
455
456         Reviewed by Alexey Proskuryakov.
457
458         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
459         ENABLE_ADDRESS_SANITIZER.
460
461 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
462
463         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
464         https://bugs.webkit.org/show_bug.cgi?id=182757
465
466         Reviewed by Don Olmstead.
467
468         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
469         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
470
471 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
472
473         run-api-tests: Upload test results
474         https://bugs.webkit.org/show_bug.cgi?id=196323
475         <rdar://problem/49356714>
476
477         Reviewed by Lucas Forschler.
478
479         * Scripts/webkitpy/api_tests/manager.py:
480         (Manager):
481         (Manager.run): Upload results to a results database.
482         * Scripts/webkitpy/api_tests/run_api_tests.py:
483         (parse_args): Add upload arguments.
484         * Scripts/webkitpy/port/base.py:
485         (Port):
486         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
487         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
488         with commits from any other associated repositories.
489         * Scripts/webkitpy/port/device.py:
490         (Device):
491         (Device.build_version): Access build_versoin of underlying platform device.
492         * Scripts/webkitpy/port/ios_simulator_unittest.py:
493         (IOSSimulatorTest):
494         (IOSSimulatorTest.test_configuration_for_upload):
495         * Scripts/webkitpy/port/device_port.py:
496         (DevicePort):
497         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
498         the same as the machine uploading results.
499         * Scripts/webkitpy/port/mac.py:
500         (MacPort):
501         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
502         * Scripts/webkitpy/port/mac_unittest.py:
503         (MacTest):
504         (MacTest.test_configuration_for_upload):
505         * Scripts/webkitpy/xcode/simulated_device.py:
506         (SimulatedDeviceManager._create_device_with_runtime):
507         (SimulatedDevice.__init__): Create simulated device with a build_version.
508         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
509         (test_existing_simulator):
510
511 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
512
513         Remove extra newline characters (Follow-up fix to r243707)
514
515         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
516
517 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
518
519         [ews-app] Use API_KEY to accept results data
520         https://bugs.webkit.org/show_bug.cgi?id=196461
521
522         Reviewed by Dewei Zhu.
523
524         * BuildSlaveSupport/ews-app/ews/views/results.py:
525         (Results.post): Validate EWS_API_KEY before accepting any data.
526         * BuildSlaveSupport/ews-build/events.py:
527         (Events.sendData): Send EWS_API_KEY if available along with event data.
528
529 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
530
531         Unable to copy and paste a PDF from Notes into Mail compose body
532         https://bugs.webkit.org/show_bug.cgi?id=196442
533         <rdar://problem/48573098>
534
535         Reviewed by Tim Horton.
536
537         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
538         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
539         to be specified on the item providers.
540
541         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
542         (TestWebKitAPI::mapItemForTesting):
543         (TestWebKitAPI::contactItemForTesting):
544
545 2019-04-01  Tim Horton  <timothy_horton@apple.com>
546
547         Make UIWKDocumentContext rects per-character instead of per-word
548         https://bugs.webkit.org/show_bug.cgi?id=196459
549
550         Reviewed by Wenson Hsieh.
551
552         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
553         (TEST):
554         Adjust test results due to switching to per-character rects.
555
556 2019-04-01  Chris Dumez  <cdumez@apple.com>
557
558         UIProcess crash when a prewarmed process is terminated
559         https://bugs.webkit.org/show_bug.cgi?id=196451
560         <rdar://problem/49245471>
561
562         Reviewed by Geoffrey Garen.
563
564         Add API test coverage.
565
566         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
567         (TEST):
568
569 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
570
571         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
572         https://bugs.webkit.org/show_bug.cgi?id=196449
573
574         Reviewed by Lucas Forschler.
575
576         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
577         (StatusBubble.get_os_details): Method to get OS and Xcode details.
578         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
579         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
580
581 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
582
583         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
584         https://bugs.webkit.org/show_bug.cgi?id=196444
585
586         Reviewed by Lucas Forschler.
587
588         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
589
590 2019-04-01  Alex Christensen  <achristensen@webkit.org>
591
592         Add SPI to canonicalize NSURLs with WTF::URL
593         https://bugs.webkit.org/show_bug.cgi?id=196415
594         <rdar://problem/44980271>
595
596         Reviewed by Darin Adler.
597
598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
599         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
600         (TestWebKitAPI::TEST):
601
602 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
603
604         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
605         https://bugs.webkit.org/show_bug.cgi?id=196441
606
607         Reviewed by Carlos Garcia Campos.
608
609         Don't cache the wpe_view_backend object that might not exist yet at the
610         time of EventSenderProxy constructor invocation, but instead retrieve
611         that object whenever it's required for event dispatching. This should
612         avoid crashes in this constructor now that it's invoked before any
613         PlatformWindow has been set up (as changed in r243496).
614
615         * WebKitTestRunner/EventSenderProxy.h:
616         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
617         (WTR::viewBackend):
618         (WTR::EventSenderProxy::EventSenderProxy):
619         (WTR::EventSenderProxy::mouseDown):
620         (WTR::EventSenderProxy::mouseUp):
621         (WTR::EventSenderProxy::mouseMoveTo):
622         (WTR::EventSenderProxy::mouseScrollBy):
623         (WTR::EventSenderProxy::keyDown):
624         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
625
626 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
627
628         [Win][WebKit] MiniBrowser should support high DPI display
629         https://bugs.webkit.org/show_bug.cgi?id=196391
630
631         Reviewed by Alex Christensen.
632
633         * MiniBrowser/win/WebKitBrowserWindow.cpp:
634         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
635         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
636         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
637
638 2019-03-31  Sam Weinig  <weinig@apple.com>
639
640         Remove more i386 specific configurations
641         https://bugs.webkit.org/show_bug.cgi?id=196430
642
643         Reviewed by Alexey Proskuryakov.
644
645         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
646         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
647
648 2019-03-31  Andy Estes  <aestes@apple.com>
649
650         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
651         https://bugs.webkit.org/show_bug.cgi?id=196433
652         <rdar://problem/49293305>
653
654         Reviewed by Tim Horton.
655
656         Enhanced API test coverage to include all navigation response policy decisions in both
657         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
658
659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
660         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
661         (TestWebKitAPI::TEST):
662         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
663         (readFile):
664         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
665         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
666         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
667         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
668         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
669         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
670         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
671         (-[QuickLookDelegate _downloadDidStart:]):
672         (-[QuickLookDelegate _download:didReceiveResponse:]):
673         (-[QuickLookDelegate _download:didReceiveData:]):
674         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
675         (-[QuickLookDelegate _downloadDidFinish:]):
676         (-[QuickLookDelegate _download:didFailWithError:]):
677         (-[QuickLookDelegate _downloadDidCancel:]):
678         (-[QuickLookDelegate verifyDownload]):
679         (runTest):
680         (runTestDecideBeforeLoading):
681         (runTestDecideAfterLoading):
682         (TEST):
683         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
684         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
685         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
686         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
687         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
688         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
689         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
690         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
691         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
692         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
693         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
694         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
695         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
696         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
697
698 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
699
700         [CMake] add testdfg as target with build-jsc
701         https://bugs.webkit.org/show_bug.cgi?id=196393
702
703         Reviewed by Saam Barati.
704
705         Added testdfg as one of the targets to build when
706         using CMake.
707
708         * Scripts/build-jsc:
709
710 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
711
712         Delete WebMetal implementation in favor of WebGPU
713         https://bugs.webkit.org/show_bug.cgi?id=195418
714
715         Reviewed by Dean Jackson.
716
717         * DumpRenderTree/mac/DumpRenderTree.mm:
718         (enableExperimentalFeatures):
719         (resetWebPreferencesToConsistentValues):
720         * Scripts/webkitperl/FeatureList.pm:
721         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
723         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
724         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
725         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
726         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
727         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
728         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
729         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
730         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
731         (WTR::InjectedBundle::beginTesting):
732         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
733         (WTR::TestRunner::setWebMetalEnabled): Deleted.
734         * WebKitTestRunner/InjectedBundle/TestRunner.h:
735
736 2019-03-29  Chris Dumez  <cdumez@apple.com>
737
738         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
739         https://bugs.webkit.org/show_bug.cgi?id=196405
740         <rdar://problem/49428130>
741
742         Reviewed by Wenson Hsieh.
743
744         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
745         the popover presentation methods to be no-ops. Use this in the new test added in
746         r243523 so that we do not swizzle those methods for all tests. This is needed because
747         those WatchOS tests rely on the popover getting presented and interactive.
748
749         * WebKitTestRunner/TestController.cpp:
750         (WTR::updateTestOptionsFromTestHeader):
751         * WebKitTestRunner/TestController.h:
752         * WebKitTestRunner/TestOptions.h:
753         (WTR::TestOptions::hasSameInitializationOptions const):
754         * WebKitTestRunner/ios/TestControllerIOS.mm:
755         (WTR::TestController::platformInitialize):
756         (WTR::TestController::platformResetStateToConsistentValues):
757
758 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
759
760         [Curl] Add Server Trust Evaluation Support.
761         https://bugs.webkit.org/show_bug.cgi?id=191646
762
763         Reviewed by Fujii Hironori.
764
765         Implemented MiniBrowser UI for asking if user trusts the server.
766
767         * MiniBrowser/win/Common.cpp:
768         (askServerTrustEvaluation):
769         (replaceString):
770         * MiniBrowser/win/Common.h:
771         * MiniBrowser/win/MiniBrowserLib.rc:
772         * MiniBrowser/win/MiniBrowserLibResource.h:
773         * MiniBrowser/win/WebKitBrowserWindow.cpp:
774         (createPEMString):
775         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
776         (WebKitBrowserWindow::canTrustServerCertificate):
777         * MiniBrowser/win/WebKitBrowserWindow.h:
778
779 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
780
781         Implement ResizeObserver.
782         https://bugs.webkit.org/show_bug.cgi?id=157743
783
784         Reviewed by Simon Fraser.
785
786         Support resizeObserverEnabled webPreferences.
787
788         * DumpRenderTree/TestOptions.cpp:
789         (TestOptions::TestOptions):
790         * DumpRenderTree/TestOptions.h:
791         * DumpRenderTree/mac/DumpRenderTree.mm:
792         (setWebPreferencesForTestOptions):
793         * DumpRenderTree/win/DumpRenderTree.cpp:
794         (enableExperimentalFeatures):
795         * Scripts/webkitperl/FeatureList.pm:
796         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
797
798 2019-03-28  John Wilander  <wilander@apple.com>
799
800         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
801         https://bugs.webkit.org/show_bug.cgi?id=196281
802         <rdar://problem/48938748>
803
804         Reviewed by Alex Christensen.
805
806         This patch adds the function isStatisticsHasLocalStorage() to the
807         TestRunner. With it, the page can query the WebsiteDataStore in the
808         UI process to make sure that it sees LocalStorage.
809
810         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
811         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
812         (WTR::TestRunner::isStatisticsHasLocalStorage):
813         * WebKitTestRunner/InjectedBundle/TestRunner.h:
814         * WebKitTestRunner/TestController.cpp:
815         (WTR::TestController::isStatisticsHasLocalStorage):
816         * WebKitTestRunner/TestController.h:
817         * WebKitTestRunner/TestInvocation.cpp:
818         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
819
820 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
821
822         API::Data::createWithoutCopying should do a null check before calling CFRelease
823         https://bugs.webkit.org/show_bug.cgi?id=196276
824         <rdar://problem/48059859>
825
826         Reviewed by Alex Christensen.
827
828         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
829
830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
831         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
832         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
833         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
834         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
835         (TestWebKitAPI::TEST):
836
837 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
838
839         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
840         https://bugs.webkit.org/show_bug.cgi?id=186276
841
842         Reviewed by Carlos Garcia Campos.
843
844         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
845         (webViewLoadChanged):
846         (testWebResourceGetDataError):
847         (testWebResourceGetDataEmpty):
848         (beforeAll):
849         (webViewloadChanged): Deleted.
850
851 2019-03-27  Andy Estes  <aestes@apple.com>
852
853         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
854         https://bugs.webkit.org/show_bug.cgi?id=196317
855
856         Reviewed by Dan Bernstein.
857
858         package-root copies built products into a staging directory using ditto(1), which does not
859         follow symbolic links as it traverses a directory. Now that the files in
860         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
861         itself, these become broken links when ditto'd into the staging directory.
862
863         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
864
865         * Scripts/package-root:
866
867 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
868
869         [ews-app] Update display text of Submit for ews analysis
870         https://bugs.webkit.org/show_bug.cgi?id=196309
871
872         Reviewed by Dewei Zhu.
873
874         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
875
876 2019-03-27  David Kilzer  <ddkilzer@apple.com>
877
878         run-webkit-tests should check for leaks in WebKit processes
879         <https://webkit.org/b/193772>
880         <rdar://problem/46526680>
881
882         Reviewed by Ryosuke Niwa.
883
884         This works by doing the following:
885         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
886           The list of child processes are returned one per line:
887           process.name: pid
888         - Run the "#LIST CHILD PROCESSES" command just before the
889           "#CHECK FOR WORLD LEAKS" command, and store the list of child
890           processes on the ServerProcess object.
891         - When the `--leaks` switch is handled, run check_for_leaks() on
892           each child process after the main test harness.
893
894         * DumpRenderTree/mac/DumpRenderTree.mm:
895         (handleControlCommand):
896         - Use strncmp() instead of strcmp().
897         - Add support for handling "#LIST CHILD PROCESSES" command.
898
899         * Scripts/webkitpy/port/base.py:
900         (Port.check_for_leaks):
901         * Scripts/webkitpy/port/darwin.py:
902         (DarwinPort.check_for_leaks):
903         - Rename redundant 'process_pid' argument to 'process_id'.
904
905         * Scripts/webkitpy/port/driver.py:
906         (Driver.do_post_tests_work):
907         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
908           longer the only command this sends to WebKitTestRunner.
909         - If the `--leaks` switch is present, send the
910           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
911           result using Port.set_webkit_processes().
912         (Driver._parse_child_processes_output):
913         - Add helper method to parse list of child process names and
914           process IDs returned from WebKitTestRunner.
915
916         * Scripts/webkitpy/port/ios_device.py:
917         (IOSDevicePort.check_for_leaks):
918         - Rename redundant 'process_pid' argument to 'process_id'.
919
920         * Scripts/webkitpy/port/leakdetector.py:
921         (LeakDetector._parse_leaks_output):
922         - Return early if there is no leaks_output.
923         (LeakDetector.check_for_leaks):
924         - Rename redundant 'process_pid' argument to 'process_id'.
925
926         * Scripts/webkitpy/port/server_process.py:
927         (ServerProcess.__init__):
928         (ServerProcess.child_processes):
929         (ServerProcess.set_child_processes):
930         - Add instance variable to Port to store list of child process
931           names and process IDs returned from WebKitTestRunner.
932         (ServerProcess._start):
933         - Clear self._child_processes.
934         (ServerProcess.stop):
935         - If self._child_processes is set, call
936           self._port.check_for_leaks() for each child process.
937
938         * Scripts/webkitpy/port/server_process_unittest.py:
939         (TrivialMockPort.check_for_leaks):
940         - Rename redundant 'process_pid' argument to 'process_id'.
941
942         * Scripts/webkitpy/port/simulator_process.py:
943         (SimulatorProcess.stop):
944         - If self._child_processes is set, call
945           self._port.check_for_leaks() for each child process.
946
947         * Scripts/webkitpy/port/watch_device.py:
948         (WatchDevicePort.check_for_leaks):
949         - Rename redundant 'process_pid' argument to 'process_id'.
950
951         * WebKitTestRunner/TestController.cpp:
952         (WTR::TestController::dumpResponse):
953         - Extract method from findAndDumpWorldLeaks() so that it may be
954           reused by findAndDumpWebKitProcessIdentifiers().
955         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
956         - Add method to output process name and process ID of both the
957           WebContent and Networking processes.
958         (WTR::TestController::findAndDumpWorldLeaks):
959         - Fix missing newline in output when there were no abandoned
960           documents.
961         - Call dumpResponse() for extracted code.
962         (WTR::TestController::handleControlCommand):
963         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
964         - Use strncmp() instead of strcmp().
965         - Call findAndDumpWebKitProcessIdentifiers() when
966           "#LIST CHILD PROCESSES" command is sent.
967         * WebKitTestRunner/TestController.h:
968         (WTR::TestController::dumpResponse):
969         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
970         - Declare methods.
971
972 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
973
974         Unreviewed. Add GLib API test cases after r243434.
975
976         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
977         (testWebViewActiveURI):
978         (serverCallback):
979         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
980         (sendRequestCallback):
981
982 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
983
984         Geolocation request not complete when watch request was started in a different web process
985         https://bugs.webkit.org/show_bug.cgi?id=195996
986
987         Reviewed by Alex Christensen.
988
989         Add a test case.
990
991         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
992         (TestWebKitAPI::runJavaScriptAlert):
993         (TestWebKitAPI::TEST):
994
995 2019-03-26  Keith Rollin  <krollin@apple.com>
996
997         Update the way generate-xcfilelists returns strings from functions
998         https://bugs.webkit.org/show_bug.cgi?id=195975
999         <rdar://problem/49040807>
1000
1001         Reviewed by Dean Jackson.
1002
1003         There are places where generate-xcfilelists executes assignments with
1004         statements like:
1005
1006             FOO=$(some_function)
1007
1008         where "some_function" return a string by echoing it. E.g.
1009
1010             some_function()
1011             {
1012                 echo "Hello, World"
1013             }
1014
1015         This is a common idiom, but it has a problem if "some_function" needs
1016         to call "exit" in an attempt to halt the entire script right then and
1017         there. Since "some_function" is called inside of $(), it's being
1018         executed in a sub-shell. Calling exit in that sub-shell simply exits
1019         that shell; it doesn't not exit the outer shell in which the main part
1020         of the script is still running. As such, the main script keeps
1021         executing when the intent was for the script to halt.
1022
1023         The solution to this is to use a different idiom for returning
1024         strings. The one we now is to pass in the name of the variable to
1025         receive the string result:
1026
1027             some_function()
1028             {
1029                 variable_name=$1
1030                 eval $variable_name ="Hello, World"
1031             }
1032
1033         The call site now looks like
1034
1035             some_function FOO
1036
1037         Because there's no invocation of a sub-shell, some_function can now
1038         call "exit" if it wants to, and the entire script will exit at that
1039         point.
1040
1041         * Scripts/generate-xcfilelists:
1042
1043 2019-03-26  Chris Dumez  <cdumez@apple.com>
1044
1045         Add basic layout test coverage for File Picker on iOS
1046         https://bugs.webkit.org/show_bug.cgi?id=196265
1047
1048         Reviewed by Wenson Hsieh.
1049
1050         Add layout test infrastructure to test the file picker on iOS.
1051
1052         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1053         (WTR::UIScriptController::dismissFilePicker):
1054         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1055         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1056         (WTR::UIScriptController::dismissFilePicker):
1057         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1058         * WebKitTestRunner/TestController.cpp:
1059         (WTR::TestController::createWebViewWithOptions):
1060         (WTR::updateTestOptionsFromTestHeader):
1061         * WebKitTestRunner/TestOptions.h:
1062         (WTR::TestOptions::hasSameInitializationOptions const):
1063         * WebKitTestRunner/ios/TestControllerIOS.mm:
1064         (overridePresentViewController):
1065         (WTR::TestController::platformInitialize):
1066         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1067         (WTR::UIScriptController::dismissFilePicker):
1068
1069 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1070
1071         Implement async paste method on UIWKInteractionViewProtocol
1072         https://bugs.webkit.org/show_bug.cgi?id=196267
1073         <rdar://problem/49236346>
1074
1075         Reviewed by Tim Horton.
1076
1077         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1078         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1079         are now a part of all iOS 12 internal SDKs.
1080
1081         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1082
1083         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1084         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1085
1086         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1087         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1088         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1089         * TestWebKitAPI/ios/UIKitSPI.h:
1090
1091 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1092
1093         [ews-build] Use PostgreSQL for ews.webkit.org database
1094         https://bugs.webkit.org/show_bug.cgi?id=196270
1095
1096         Reviewed by Lucas Forschler.
1097
1098         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1099
1100 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1101
1102         [ews] Reset simctl states on reboot
1103         https://bugs.webkit.org/show_bug.cgi?id=196260
1104
1105         Rubber-stamped by Aakash Jain.
1106
1107         * EWSTools/start-queue-mac.sh:
1108
1109 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1110
1111         [ews-build] Use PostgreSQL for ews-build database
1112         https://bugs.webkit.org/show_bug.cgi?id=196229
1113
1114         Reviewed by Lucas Forschler.
1115
1116         * BuildSlaveSupport/ews-build/master.cfg:
1117
1118 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1119
1120         [ews-build] Get master_hostname dynamically in master.cfg
1121         https://bugs.webkit.org/show_bug.cgi?id=196255
1122
1123         Reviewed by Lucas Forschler.
1124
1125         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1126         send events data in test mode.
1127
1128 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1129
1130         [ews-app] Set db_constraint to False for Foreign Keys
1131         https://bugs.webkit.org/show_bug.cgi?id=196252
1132
1133         Reviewed by Lucas Forschler.
1134
1135         * BuildSlaveSupport/ews-app/ews/models/build.py:
1136         * BuildSlaveSupport/ews-app/ews/models/step.py:
1137
1138 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1139
1140         [ews-build] is_test_mode_enabled should default to True
1141         https://bugs.webkit.org/show_bug.cgi?id=196248
1142
1143         Reviewed by Lucas Forschler.
1144
1145         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1146
1147 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1148
1149         [ews-app] Add webkitperl to ENABLED_QUEUES
1150         https://bugs.webkit.org/show_bug.cgi?id=196253
1151
1152         Reviewed by Lucas Forschler.
1153
1154         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1155
1156 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1157
1158         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1159         https://bugs.webkit.org/show_bug.cgi?id=196211
1160         rdar://problem/49110552
1161
1162         Reviewed by Tim Horton.
1163
1164         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1165         Make sure that EventSenderProxy always exists when running tests. We used to create
1166         it when resetting before the first test, which is a bit too late.
1167
1168         * WebKitTestRunner/TestController.h:
1169         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1170         (WTR::TestController::platformCreateWebView):
1171         (WTR::TestController::platformCreateOtherPage):
1172         (WTR::TestController::finishCreatingPlatformWebView):
1173         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1174         (WTR::PlatformWebView::PlatformWebView):
1175         Moved some code that made NSWindow use NSEvent during web view creation. We may
1176         need to move more if some other case us found, but this is enough for now.
1177
1178 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1179
1180         Unreviewed. Fix typo in GLib geolocation API after r243285.
1181
1182         gelocation -> geolocation.
1183
1184         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1185         (testGeolocationManagerWatchPosition):
1186
1187 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1188
1189         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1190         https://bugs.webkit.org/show_bug.cgi?id=196213
1191
1192         Reviewed by Geoff Garen.
1193
1194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1195         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1196         (credentialWithIdentityAndKeychainPath):
1197         (-[ChallengeDelegate webView:didFinishNavigation:]):
1198         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1199         (TestWebKitAPI::TEST):
1200
1201 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1202
1203         Expected shouldn't assume its contained types are copyable
1204         https://bugs.webkit.org/show_bug.cgi?id=195986
1205
1206         Reviewed by JF Bastien.
1207
1208         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1209         (TestWebKitAPI::NonCopyable::operator== const):
1210         (TestWebKitAPI::NonCopyable::operator!= const):
1211         (TestWebKitAPI::TEST):
1212
1213 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1214
1215         Remove some now-unnecessary dynamic class lookup
1216         https://bugs.webkit.org/show_bug.cgi?id=196237
1217
1218         Reviewed by Simon Fraser.
1219
1220         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1221         (makeRequest):
1222         (TEST):
1223
1224 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1225
1226         Unreviewed, rolling out r243450.
1227
1228         AppleWin and WinCairo port builds get broken.
1229
1230         Reverted changeset:
1231
1232         "Add test for fix of #196095"
1233         https://bugs.webkit.org/show_bug.cgi?id=196097
1234         https://trac.webkit.org/changeset/243450
1235
1236 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1237
1238         Unreviewed, rolling out r243465.
1239         https://bugs.webkit.org/show_bug.cgi?id=196226
1240
1241         the test doesn't build (Requested by thorton on #webkit).
1242
1243         Reverted changeset:
1244
1245         "Do not terminate the NetworkProcess if a third party
1246         application sends a NSCredential with a SecIdentityRef"
1247         https://bugs.webkit.org/show_bug.cgi?id=196213
1248         https://trac.webkit.org/changeset/243465
1249
1250 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1251
1252         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1253         https://bugs.webkit.org/show_bug.cgi?id=196213
1254
1255         Reviewed by Geoff Garen.
1256
1257         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1258         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1259         (credentialWithIdentityAndKeychainPath):
1260         (-[ChallengeDelegate webView:didFinishNavigation:]):
1261         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1262         (TestWebKitAPI::TEST):
1263
1264 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1265
1266         [ews-build] Gracefully handle missing patch_id in events
1267         https://bugs.webkit.org/show_bug.cgi?id=196216
1268
1269         Reviewed by Lucas Forschler.
1270
1271         * BuildSlaveSupport/ews-build/events.py:
1272
1273 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1274
1275         [ews-build] use lz4 compression for improving buildbot performance
1276         https://bugs.webkit.org/show_bug.cgi?id=196155
1277
1278         Reviewed by Lucas Forschler.
1279
1280         * BuildSlaveSupport/ews-build/master.cfg:
1281
1282 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1283
1284         Pull some API testing helper methods out of TestWKWebView
1285         https://bugs.webkit.org/show_bug.cgi?id=196212
1286
1287         Reviewed by Tim Horton.
1288
1289         Refactor some more API testing utility methods, so that they can be used in
1290         tests that do not use TestWKWebView.
1291
1292         * TestWebKitAPI/cocoa/TestWKWebView.h:
1293         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1294         (-[WKWebView loadTestPageNamed:]):
1295         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1296         (-[WKWebView synchronouslyLoadHTMLString:]):
1297         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1298         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1299         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1300         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1301         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1302
1303 2019-03-25  Jer Noble  <jer.noble@apple.com>
1304
1305         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1306         https://bugs.webkit.org/show_bug.cgi?id=196097
1307
1308         Reviewed by Eric Carlson.
1309
1310         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1311
1312         * DumpRenderTree/mac/DumpRenderTree.mm:
1313         (resetWebPreferencesToConsistentValues):
1314         * WebKitTestRunner/TestController.cpp:
1315         (WTR::TestController::resetPreferencesToConsistentValues):
1316
1317 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1318
1319         Pull IPadUserInterfaceSwizzler out into a separate header file
1320         https://bugs.webkit.org/show_bug.cgi?id=196193
1321
1322         Reviewed by Anders Carlsson.
1323
1324         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1325         be used in other API tests.
1326
1327         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1328         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1329         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1330         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1331         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1332         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1333         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1334
1335 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1336
1337         Remove NavigatorContentUtils in WebCore/Modules
1338         https://bugs.webkit.org/show_bug.cgi?id=196070
1339
1340         Reviewed by Alex Christensen.
1341
1342         NavigatorContentUtils was to support the custom scheme spec [1].
1343         However, in WebKit side, no port has supported the feature in
1344         WebKit layer after EFL port was removed. So there has been the
1345         only IDL implementation of the NavigatorContentUtils in WebCore.
1346         So we don't need to keep the implementation in WebCore anymore.
1347
1348         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1349
1350         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1351
1352 2019-03-24  Andy Estes  <aestes@apple.com>
1353
1354         [watchOS] Remove unused Proximity Networking code
1355         https://bugs.webkit.org/show_bug.cgi?id=196188
1356
1357         Reviewed by Tim Horton.
1358
1359         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1360         (TEST):
1361
1362 2019-03-23  Keith Miller  <keith_miller@apple.com>
1363
1364         Refactor clz/ctz and fix getLSBSet.
1365         https://bugs.webkit.org/show_bug.cgi?id=196162
1366
1367         Reviewed by Saam Barati.
1368
1369         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1370
1371         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1372         (TestWebKitAPI::TEST):
1373
1374 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1375
1376         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1377         https://bugs.webkit.org/show_bug.cgi?id=196143
1378
1379         Reviewed by Michael Catanzaro.
1380
1381         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1382         directories.
1383
1384         * Scripts/webkitpy/style/checkers/cpp.py:
1385         (check_identifier_name_in_declaration):
1386         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1387         (WebKitStyleTest.test_names):
1388
1389 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1390
1391         [Flatpak] Manifest expanding fails for qt WPE extension
1392         https://bugs.webkit.org/show_bug.cgi?id=196148
1393
1394         Reviewed by Alex Christensen.
1395
1396         * flatpak/flatpakutils.py:
1397         (expand_submodules_recurse): The last recurse manifest expand
1398         iteration might lead to a single module so take it into account
1399         and don't try to recurse further.
1400
1401 2019-03-22  Chris Dumez  <cdumez@apple.com>
1402
1403         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1404         https://bugs.webkit.org/show_bug.cgi?id=195348
1405         <rdar://problem/48622090>
1406
1407         Reviewed by Alex Christensen.
1408
1409         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1410         to NO when test.options().shouldIgnoreMetaViewport is false.
1411
1412         * WebKitTestRunner/ios/TestControllerIOS.mm:
1413         (WTR::TestController::platformConfigureViewForTest):
1414
1415 2019-03-22  Chris Dumez  <cdumez@apple.com>
1416
1417         Prewarmed processes should be usable with any website data store
1418         https://bugs.webkit.org/show_bug.cgi?id=196104
1419
1420         Reviewed by Alex Christensen.
1421
1422         Add API test coverage.
1423
1424         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1425         (runInitialWarmedProcessUsedTest):
1426         (TEST):
1427
1428 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1429
1430         Back out local changes to Alex's Subversion working directory
1431
1432         They were accidentally committed.
1433
1434         * Scripts/webkitpy/common/system/abstractexecutive.py:
1435         (AbstractExecutive.wait_newest):
1436         * Scripts/webkitpy/common/system/executive.py:
1437         (Executive.running_pids):
1438         * Scripts/webkitpy/common/system/executive_mock.py:
1439         (MockExecutive.running_pids):
1440         * Scripts/webkitpy/common/system/executive_unittest.py:
1441         (ExecutiveTest.serial_test_running_pids):
1442         * Scripts/webkitpy/port/darwin.py:
1443         (DarwinPort.check_for_leaks):
1444         * Scripts/webkitpy/port/leakdetector.py:
1445         (LeakDetector.check_for_leaks):
1446         - This was the hack attached to Bug 193772.
1447
1448         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1449         (+[WebKitTestRunnerEvent mouseLocation]):
1450         - This works around a crash on an internal build.
1451
1452 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1453
1454         Fix the build after r243354
1455         https://bugs.webkit.org/show_bug.cgi?id=196138
1456         <rdar://problem/49145951>
1457
1458         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1459         (TEST):
1460         * TestWebKitAPI/ios/UIKitSPI.h:
1461
1462 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1463
1464         Adopt UIWKDocumentContext
1465         https://bugs.webkit.org/show_bug.cgi?id=196040
1466         <rdar://problem/48642440>
1467
1468         Reviewed by Ryosuke Niwa.
1469
1470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1471         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1472         (makeRequest):
1473         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1474         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1475         (applyStyle):
1476         (TEST):
1477         Add tests for UIWKDocumentContext.
1478
1479         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1480         (TEST):
1481         (recursiveFindWKContentView): Deleted.
1482         * TestWebKitAPI/cocoa/TestWKWebView.h:
1483         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1484         (recursiveFindWKContentView):
1485         (-[TestWKWebView wkContentView]):
1486         * TestWebKitAPI/ios/UIKitSPI.h:
1487         Share the WKContentView finding code between tests.
1488
1489 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1490
1491         [iOS WK2] Turn on async overflow scrolling by default
1492         https://bugs.webkit.org/show_bug.cgi?id=196011
1493         rdar://problem/48453859
1494
1495         Reviewed by Antti Koivisto.
1496         
1497         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1498         since so many basic layout tests have different results when compositing is triggered for
1499         overflow.
1500         
1501         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1502
1503         * WebKitTestRunner/TestController.cpp:
1504         (WTR::TestController::resetPreferencesToConsistentValues):
1505
1506 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1507
1508         [ews-build] Retry API test in case of failures
1509         https://bugs.webkit.org/show_bug.cgi?id=196004
1510
1511         Reviewed by Lucas Forschler.
1512
1513         * BuildSlaveSupport/ews-build/steps.py:
1514         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1515         (CompileWebKitToT.doStepIf): Ditto.
1516         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1517         (ReRunAPITests): Re-run API tests.
1518         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1519         (RunAPITestsWithoutPatch): Run API tests without patch.
1520         (RunAPITestsWithoutPatch.doStepIf):
1521         (RunAPITestsWithoutPatch.hideStepIf):
1522         (RunAPITestsWithoutPatch.evaluateCommand):
1523         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1524         (AnalyzeAPITestsResults.start):
1525         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1526         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1527         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1528         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1529
1530 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1531
1532         [ews-build] Update queues configurations
1533         https://bugs.webkit.org/show_bug.cgi?id=196074
1534
1535         Reviewed by Dewei Zhu.
1536
1537         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1538         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1539
1540 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1541
1542         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1543         https://bugs.webkit.org/show_bug.cgi?id=195680
1544         <rdar://problem/48903534>
1545
1546         Unreviewed infrastructure fix.
1547
1548         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1549         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1550
1551 2019-03-21  Andy Estes  <aestes@apple.com>
1552
1553         [iOS] Apple Pay should be available in documents with no user agent scripts
1554         https://bugs.webkit.org/show_bug.cgi?id=196061
1555         <rdar://problem/48649391>
1556
1557         Reviewed by Brady Eidson.
1558
1559         Added API tests and related infrastructure.
1560
1561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1562         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1563         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1564         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1565         (TestWebKitAPI::TEST):
1566         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1567         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1568         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1569         * TestWebKitAPI/cocoa/TestProtocol.mm:
1570         (-[TestProtocol startLoading]):
1571         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1572         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1573         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1574         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1575
1576 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1577
1578         REGRESSSION (r243297): webkitpy tests broken
1579         https://bugs.webkit.org/show_bug.cgi?id=196108
1580
1581         Reviewed by Aakash Jain.
1582
1583         r243297 updated contributors.json, which broke a few unit tests.
1584
1585         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1586         (IRCCommandTest.test_whois):
1587         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1588
1589 2019-03-21  Chris Dumez  <cdumez@apple.com>
1590
1591         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1592         https://bugs.webkit.org/show_bug.cgi?id=196041
1593         <rdar://problem/49083230>
1594
1595         Reviewed by Alex Christensen.
1596
1597         Add API test coverage.
1598
1599         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1600         (TEST):
1601
1602 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1603
1604         Add SPI to inform applications of WKContentRuleList actions
1605         https://bugs.webkit.org/show_bug.cgi?id=195965
1606         <rdar://problem/42664365>
1607
1608         Reviewed by Geoff Garen.
1609
1610         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1611         (TestWebKitAPI::allActionsForResourceLoad):
1612         (TestWebKitAPI::testRequest):
1613         (TestWebKitAPI::TEST_F):
1614         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1615         (Notification::description):
1616         (Notification::operator== const):
1617         (toVector):
1618         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1619         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1620         (makeContentRuleList):
1621         (TEST):
1622         (makeWarnContentRuleList): Deleted.
1623
1624 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1625
1626         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1627         https://bugs.webkit.org/show_bug.cgi?id=196088
1628
1629         Reviewed by Brian Burg.
1630
1631         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1632         Support checks when only one platform is specified. Also deprecate macosx() and
1633         force the use of macos() instead.
1634
1635         * Scripts/webkitpy/style/checkers/cpp.py:
1636         (check_min_versions_of_wk_api_available):
1637         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1638         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1639
1640 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1641
1642         Update status inactive committers' status to 'contributor'.
1643
1644         * Scripts/webkitpy/common/config/contributors.json:
1645
1646 2019-03-21  Xan Lopez  <xan@igalia.com>
1647
1648         [JSC][x86] Drop support for x87 floating point
1649         https://bugs.webkit.org/show_bug.cgi?id=194853
1650
1651         Reviewed by Don Olmstead.
1652
1653         Force SSE2 on x86/32bit builds.
1654
1655         * Scripts/webkitdirs.pm:
1656         (generateBuildSystemFromCMakeProject):
1657
1658 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1659
1660         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1661         https://bugs.webkit.org/show_bug.cgi?id=196073
1662
1663         Reviewed by Michael Catanzaro.
1664
1665         Add test cases to check functions and constructors with no arguments but receiving user data.
1666
1667         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1668         (checkUserData):
1669         (testJSCFunction):
1670         (fooCreateWithUserData):
1671         (testJSCClass):
1672
1673 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1674
1675         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1676
1677         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1678
1679         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1680
1681 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1682
1683         [GTK][WPE] Add API to provide geolocation information
1684         https://bugs.webkit.org/show_bug.cgi?id=195940
1685
1686         Reviewed by Michael Catanzaro.
1687
1688         Add a new test to check the new API.
1689
1690         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1691         (testGeolocationManagerCurrentPosition):
1692         (testGeolocationManagerWatchPosition):
1693         (beforeAll):
1694         (afterAll):
1695         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1696         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1697         (beforeAll): Ditto.
1698         * TestWebKitAPI/glib/CMakeLists.txt:
1699
1700 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1701
1702         [GLib] Returning G_TYPE_OBJECT from a method does not work
1703         https://bugs.webkit.org/show_bug.cgi?id=195574
1704
1705         Reviewed by Michael Catanzaro.
1706
1707         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1708
1709         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1710         (getGFile):
1711         (getParent):
1712         (createGString):
1713         (getGString):
1714         (getGStringCopyWillRaise):
1715         (getGStringCopy):
1716         (getGStringStr):
1717         (getGStringLen):
1718         (freeGString):
1719         (testJSCClass):
1720
1721 2019-03-20  Saam Barati  <sbarati@apple.com>
1722
1723         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1724         https://bugs.webkit.org/show_bug.cgi?id=195721
1725
1726         Reviewed by Filip Pizlo.
1727
1728         * Scripts/run-javascriptcore-tests:
1729
1730 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1731
1732         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1733         https://bugs.webkit.org/show_bug.cgi?id=196049
1734
1735         Reviewed by Tim Horton.
1736
1737         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1738         overflow scrolling in general, so rename it.
1739
1740         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1741
1742 2019-03-20  Daniel Bates  <dabates@apple.com>
1743
1744         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1745         https://bugs.webkit.org/show_bug.cgi?id=196031
1746         <rdar://problem/49078172>
1747
1748         Reviewed by Tim Horton.
1749
1750         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1751         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1752         same code path used when the Done button is pressed to dismiss the <select> picker.
1753
1754         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1755         (TestWebKitAPI::TEST):
1756
1757 2019-03-20  Chris Dumez  <cdumez@apple.com>
1758
1759         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1760         https://bugs.webkit.org/show_bug.cgi?id=196029
1761         <rdar://problem/48954651>
1762
1763         Reviewed by Tim Horton.
1764
1765         Add API test coverage.
1766
1767         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1768
1769 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1770
1771         [ews-build] Improve failure summary string for ApplyPatch step
1772         https://bugs.webkit.org/show_bug.cgi?id=195995
1773
1774         Reviewed by Alexey Proskuryakov.
1775
1776         * BuildSlaveSupport/ews-build/steps.py:
1777         (ApplyPatch.getResultSummary): Override getResultSummary.
1778
1779 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1780
1781         AX: Implement support for new meter ARIA role
1782         https://bugs.webkit.org/show_bug.cgi?id=195966
1783
1784         Reviewed by Chris Fleizach.
1785
1786         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1787         to AXLevelIndicator.
1788
1789         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1790
1791 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1792
1793         [WebAuthN] Implement FIDO AppID extension
1794         https://bugs.webkit.org/show_bug.cgi?id=143491
1795         <rdar://problem/48298273>
1796
1797         Reviewed by Brent Fulgham.
1798
1799         Add a test that covers the new flag of convertToU2fSignCommand.
1800
1801         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1802         (TestWebKitAPI::TEST):
1803         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1804         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1805         (TestWebKitAPI::TEST):
1806
1807 2019-03-19  Keith Rollin  <krollin@apple.com>
1808
1809         Add support for more platforms to generate-xcfilelists
1810         https://bugs.webkit.org/show_bug.cgi?id=195977
1811
1812         Reviewed by Alexey Proskuryakov.
1813
1814         generate-xcfilelists incorrectly complains when involved with building
1815         WebKit for iphonesimulator:
1816
1817             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1818             …
1819             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1820
1821         Address this by teaching generate-xcfilelists about more platforms.
1822
1823         * Scripts/generate-xcfilelists:
1824
1825 2019-03-19  John Wilander  <wilander@apple.com>
1826
1827         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1828         https://bugs.webkit.org/show_bug.cgi?id=195923
1829         <rdar://problem/49001272>
1830
1831         Reviewed by Alex Christensen.
1832
1833         This patch does the following to the TestRunner:
1834         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1835         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1836         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1837
1838         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1839         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1840         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1841         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1842         * WebKitTestRunner/TestController.cpp:
1843         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1844         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1845         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1846         * WebKitTestRunner/TestController.h:
1847         * WebKitTestRunner/TestInvocation.cpp:
1848         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1849
1850 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1851
1852         [CMake] Support more clang and gcc sanitizers
1853         https://bugs.webkit.org/show_bug.cgi?id=195956
1854
1855         Reviewed by Michael Catanzaro.
1856
1857         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1858
1859 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1860
1861         [ews-build] Improve summary for PrintConfiguration step
1862         https://bugs.webkit.org/show_bug.cgi?id=195945
1863
1864         Reviewed by Lucas Forschler.
1865
1866         * BuildSlaveSupport/ews-build/steps.py:
1867         (PrintConfiguration.getResultSummary): Override getResultSummary.
1868
1869 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1870
1871         [ews-build] Improve summary for CheckOutSource step
1872         https://bugs.webkit.org/show_bug.cgi?id=195963
1873
1874         Reviewed by Lucas Forschler.
1875
1876         * BuildSlaveSupport/ews-build/steps.py:
1877         (CheckOutSource.getResultSummary):
1878
1879 2019-03-19  Daniel Bates  <dabates@apple.com>
1880
1881         [iOS] Focus not preserved when switching between tabs
1882         https://bugs.webkit.org/show_bug.cgi?id=195820
1883         <rdar://problem/43614450>
1884
1885         Reviewed by Brent Fulgham.
1886
1887         Add tests to ensure that we restore focus when resigning and becoming first responder.
1888
1889         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1890         (TestWebKitAPI::TEST):
1891
1892 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1893
1894         Make WTFLogChannelState and WTFLogLevel enum classes
1895         https://bugs.webkit.org/show_bug.cgi?id=195904
1896
1897         Reviewed by Eric Carlson.
1898
1899         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1900         (TestWebKitAPI::TEST_F):
1901
1902 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1903
1904         [GStreamer][EME] Backported mssdemux protection data crash fix
1905         https://bugs.webkit.org/show_bug.cgi?id=195918
1906
1907         Reviewed by Philippe Normand.
1908
1909         * gstreamer/jhbuild.modules:
1910         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1911
1912 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1913
1914         Unreviewed, rolling out r243132.
1915
1916         Broke GTK build
1917
1918         Reverted changeset:
1919
1920         "Make WTFLogChannelState and WTFLogLevel enum classes"
1921         https://bugs.webkit.org/show_bug.cgi?id=195904
1922         https://trac.webkit.org/changeset/243132
1923
1924 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1925
1926         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1927
1928         * Scripts/webkitdirs.pm:
1929         (builtDylibPathForName): Adjust the shared library name that's changed
1930         with the API version bump in r243073.
1931
1932 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1933
1934         Make WTFLogChannelState and WTFLogLevel enum classes
1935         https://bugs.webkit.org/show_bug.cgi?id=195904
1936
1937         Reviewed by Eric Carlson.
1938
1939         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1940         (TestWebKitAPI::TEST_F):
1941
1942 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1943
1944         Disable flaky test added in r2431100
1945         https://webkit.org/b/195785
1946
1947         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1948         (TestWebKitAPI::TEST):
1949         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1950
1951 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1952
1953         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1954         https://bugs.webkit.org/show_bug.cgi?id=195916
1955
1956         Reviewed by Tim Horton.
1957
1958         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1959         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1960
1961 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1962
1963         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1964
1965         * Scripts/webkitpy/common/config/contributors.json:
1966
1967 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1968
1969         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1970         https://bugs.webkit.org/show_bug.cgi?id=195785
1971
1972         Reviewed by Geoffrey Garen.
1973
1974         * TestWebKitAPI/TCPServer.cpp: Added.
1975         (TestWebKitAPI::TCPServer::TCPServer):
1976         (TestWebKitAPI::TCPServer::~TCPServer):
1977         (TestWebKitAPI::TCPServer::socketBindListen):
1978         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1979         * TestWebKitAPI/TCPServer.h: Added.
1980         (TestWebKitAPI::TCPServer::port const):
1981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1982         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1983         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1984         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1985         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1986         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1987         (TestWebKitAPI::respondSlowly):
1988         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1989         (TestWebKitAPI::downloadAtRate):
1990         (TestWebKitAPI::TEST):
1991
1992 2019-03-18  Saam Barati  <sbarati@apple.com>
1993
1994         Add a plan file for JetStream 2
1995         https://bugs.webkit.org/show_bug.cgi?id=190734
1996
1997         Reviewed by Mark Lam.
1998
1999         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2000
2001 2019-03-18  Chris Dumez  <cdumez@apple.com>
2002
2003         Delay WebProcess launch until a load is triggered in a Web view
2004         https://bugs.webkit.org/show_bug.cgi?id=195758
2005         <rdar://problem/48126013>
2006
2007         Reviewed by Geoff Garen.
2008
2009         Add API test coverage. Also update some existing API tests to not expect
2010         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2011
2012         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2013         (TestWebKitAPI::TEST):
2014         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2015         (TestWebKitAPI::TEST):
2016         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2017         (TEST):
2018         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2019         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2020         (TEST):
2021         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2022         (TEST):
2023         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2024
2025 2019-03-18  Xan Lopez  <xan@igalia.com>
2026
2027         [CMake] Prevent potential warning when determining $architecture
2028         https://bugs.webkit.org/show_bug.cgi?id=195891
2029
2030         Reviewed by Michael Catanzaro.
2031
2032         It's possible for generateBuildSystemForCMakeProject to be called
2033         before determineArchitecture() is ever called. This will make the
2034         first eq check with $architecture to be bogus (and print a
2035         warning). Change that to an eq check with architecture(), which
2036         implicitly calls determineArchitecture() if needed, and change all
2037         the other similar cases in the method in the same way to prevent
2038         future bugs like this one.
2039
2040         * Scripts/webkitdirs.pm:
2041         (generateBuildSystemFromCMakeProject):
2042
2043 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2044
2045         [WPE] Tarballs generated with “make dist” cannot build documentation
2046         https://bugs.webkit.org/show_bug.cgi?id=195885
2047
2048         Reviewed by Carlos Garcia Campos.
2049
2050         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2051
2052 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2053
2054         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2055         https://bugs.webkit.org/show_bug.cgi?id=195883
2056
2057         Reviewed by Carlos Garcia Campos.
2058
2059         * gtkdoc/gtkdoc.py:
2060         (GTKDoc._run_command): When commands fail to run, include the full command line for
2061         the program invocation and the output it has generated on the standard error stream.
2062
2063 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2064
2065         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2066         https://bugs.webkit.org/show_bug.cgi?id=195786
2067
2068         Reviewed by Philippe Normand.
2069
2070         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2071         * wpe/jhbuild.modules: Ditto.
2072
2073 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2074
2075         [ews-build] Don't run clean builds on EWS builders
2076         https://bugs.webkit.org/show_bug.cgi?id=195851
2077
2078         Reviewed by Geoffrey Garen.
2079
2080         * BuildSlaveSupport/ews-build/factories.py:
2081
2082 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2083
2084         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2085         https://bugs.webkit.org/show_bug.cgi?id=195849
2086
2087         Reviewed by Chris Dumez.
2088
2089         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2090
2091         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2092         (runWebsiteDataStoreCustomPaths):
2093
2094 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2095
2096         webkitpy: Upload test results
2097         https://bugs.webkit.org/show_bug.cgi?id=195755
2098         <rdar://problem/48896182>
2099
2100         Reviewed by Aakash Jain.
2101
2102         Establish a new format for uploading results that is not tied to layout tests, apply
2103         that format to webkitpy tests.
2104
2105         * Scripts/webkitpy/common/checkout/scm/git.py:
2106         (Git.native_branch): Return what branch the current checkout is on.
2107         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2108         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2109         * Scripts/webkitpy/common/checkout/scm/svn.py:
2110         (SVN.native_branch): Ditto.
2111         * Scripts/webkitpy/common/system/platforminfo.py:
2112         (PlatformInfo.build_version): Return a build version for Mac.
2113         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2114         (MockPlatformInfo.__init__):
2115         (MockPlatformInfo.build_version):
2116         * Scripts/webkitpy/results: Added.
2117         * Scripts/webkitpy/results/__init__.py: Added.
2118         * Scripts/webkitpy/results/options.py: Added.
2119         (upload_options): OptParse list for upload options.
2120         * Scripts/webkitpy/results/upload.py: Added.
2121         (Upload): Class which enforces the upload format expected by the results server.
2122         (Upload.Expectations):
2123         (Upload.create_configuration):
2124         (Upload.create_commit):
2125         (Upload.create_details):
2126         (Upload.create_run_stats):
2127         (Upload.create_test_result):
2128         (Upload.__init__):
2129         (Upload.Encoder): Encode Upload object as json.
2130         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2131         * Scripts/webkitpy/results/upload_unittest.py: Added.
2132         * Scripts/webkitpy/test/main.py:
2133         (Tester._parse_args): Add upload arguments.
2134         (Tester._run_tests): Allow results to be uploaded.
2135         * Scripts/webkitpy/test/runner.py:
2136         (Runner.__init__): Record which tests were run, rather than just counting them.
2137         (Runner.handle):
2138         * Scripts/webkitpy/test/runner_unittest.py:
2139         (RunnerTest.test_run):
2140         * Scripts/webkitpy/thirdparty/__init__.py:
2141         (AutoinstallImportHook.find_module): Add requests auto-install.
2142         (AutoinstallImportHook._install_requests):
2143         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2144         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2145
2146 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2147
2148         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2149         https://bugs.webkit.org/show_bug.cgi?id=195810
2150
2151         Reviewed by Tim Horton.
2152
2153         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2154         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2155         ending certain layout tests.
2156
2157         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2158         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2159         (-[TestRunnerWKWebView dealloc]):
2160         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2161
2162         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2163         helper method when destroying the web view, and when resetting state between tests.
2164
2165         * WebKitTestRunner/ios/TestControllerIOS.mm:
2166         (WTR::TestController::platformResetStateToConsistentValues):
2167
2168         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2169
2170 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2171
2172         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2173         https://bugs.webkit.org/show_bug.cgi?id=190350
2174         <rdar://problem/45089503>
2175
2176         Reviewed by Geoffrey Garen.
2177
2178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2179         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2180         (TEST):
2181         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2182         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2183         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2184         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2185         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2186         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2187         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2188         (runTest):
2189         (createDirectories):
2190         (TEST):
2191         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2192         (TEST):
2193         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2194         (TEST):
2195
2196 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2197
2198         Add support to WebPage for getting the contents as an attributed string.
2199         https://bugs.webkit.org/show_bug.cgi?id=195636
2200         rdar://problem/45055697
2201
2202         Reviewed by Tim Horton.
2203
2204         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2205         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2206
2207 2019-03-15  Chris Dumez  <cdumez@apple.com>
2208
2209         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2210         https://bugs.webkit.org/show_bug.cgi?id=195747
2211
2212         Reviewed by Geoff Garen.
2213
2214         Add API test coverage.
2215
2216         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2217
2218 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2219
2220         Unreviewed, rolling out r242952.
2221
2222         Causing API failures on iOS Simulator
2223
2224         Reverted changeset:
2225
2226         "[PSON] Make sure the WebProcessCache is leverage when
2227         relaunching a process after termination"
2228         https://bugs.webkit.org/show_bug.cgi?id=195747
2229         https://trac.webkit.org/changeset/242952
2230
2231 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2232
2233         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2234         https://bugs.webkit.org/show_bug.cgi?id=195740
2235
2236         Reviewed by Ross Kirsling.
2237
2238         window.open doesn't work for WebKitBrowserWindow because it is not
2239         implemented yet.
2240
2241         1. Implemented createNewPage callback of WKPageUIClient.
2242         2. Changed MainWindow to take a BrowserWindow factory function
2243           instead of BrowserWindowType to be flexible to create
2244           BrowserWindow with extra settings.
2245         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2246           because it is not relevant with MainWindow anymore.
2247
2248         * MiniBrowser/win/Common.cpp:
2249         (parseCommandLine):
2250         * MiniBrowser/win/Common.h:
2251         (CommandLineOptions::CommandLineOptions):
2252         * MiniBrowser/win/MainWindow.cpp:
2253         (MainWindow::MainWindow):
2254         (MainWindow::create):
2255         (MainWindow::init):
2256         (MainWindow::WndProc):
2257         * MiniBrowser/win/MainWindow.h:
2258         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2259         (PrintWebUIDelegate::createWebViewWithRequest):
2260         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2261         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2262         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2263         (WebKitBrowserWindow::updateProxySettings):
2264         (WebKitBrowserWindow::createNewPage):
2265         * MiniBrowser/win/WebKitBrowserWindow.h:
2266         * MiniBrowser/win/WinMain.cpp:
2267         (wWinMain):
2268
2269 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2270
2271         Make it possible to test scrolling tree layer manipulation more easily
2272         https://bugs.webkit.org/show_bug.cgi?id=195780
2273
2274         Reviewed by Tim Horton.
2275         
2276         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2277         cuts off communication of scrolling tree scrolls back to the web process
2278         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2279         allows tests to trigger scrolls which run the scrolling tree layer positioning
2280         logic, but never get another commit from the web process that might mask
2281         scrolling tree bugs.
2282         
2283         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2284         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2285         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2286
2287         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2288         (WTR::UIScriptController::scrollUpdatesDisabled const):
2289         (WTR::UIScriptController::setScrollUpdatesDisabled):
2290         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2291         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2292         (WTR::UIScriptController::scrollUpdatesDisabled const):
2293         (WTR::UIScriptController::setScrollUpdatesDisabled):
2294         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2295         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2296         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2297         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2298         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2299         * WebKitTestRunner/ios/TestControllerIOS.mm:
2300         (WTR::TestController::platformResetStateToConsistentValues):
2301         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2302         (WTR::UIScriptController::scrollUpdatesDisabled const):
2303         (WTR::UIScriptController::setScrollUpdatesDisabled):
2304
2305 2019-03-14  Youenn Fablet  <youenn@apple.com>
2306
2307         Move IDB storage in private browsing mode to NetworkProcess
2308         https://bugs.webkit.org/show_bug.cgi?id=195602
2309
2310         Reviewed by Brady Eidson.
2311
2312         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2313         (TEST):
2314
2315 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2316
2317         [ews-build] Make descriptionDone messages more readable
2318         https://bugs.webkit.org/show_bug.cgi?id=195760
2319
2320         Reviewed by Lucas Forschler.
2321
2322         * BuildSlaveSupport/ews-build/steps.py:
2323         * BuildSlaveSupport/ews-build/steps_unittest.py:
2324
2325 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2326
2327         [ews-build] Generate status-bubble hover-over messages
2328         https://bugs.webkit.org/show_bug.cgi?id=195680
2329
2330         Reviewed by Lucas Forschler.
2331
2332         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2333         (StatusBubble):
2334         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2335         on hover-over.
2336         (StatusBubble._iso_time):
2337         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2338         hover-over message.
2339         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2340
2341 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2342
2343         [ews-app] Gracefully handle the case when state_string is None
2344         https://bugs.webkit.org/show_bug.cgi?id=195753
2345
2346         Reviewed by Lucas Forschler.
2347
2348         * BuildSlaveSupport/ews-app/ews/models/build.py:
2349         * BuildSlaveSupport/ews-app/ews/models/step.py:
2350
2351 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2352
2353         [ews-app] Status bubble display pending for currently running build step
2354         https://bugs.webkit.org/show_bug.cgi?id=195744
2355
2356         Reviewed by Lucas Forschler.
2357
2358         * BuildSlaveSupport/ews-build/events.py:
2359         (Events.stepStarted): If state_string is pending, replace it with step name.
2360
2361 2019-03-14  Chris Dumez  <cdumez@apple.com>
2362
2363         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2364         https://bugs.webkit.org/show_bug.cgi?id=195750
2365
2366         Reviewed by Geoffrey Garen.
2367
2368         Add API test coverage.
2369
2370         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2371         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2372         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2373         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2374
2375 2019-03-14  Chris Dumez  <cdumez@apple.com>
2376
2377         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2378         https://bugs.webkit.org/show_bug.cgi?id=195747
2379
2380         Reviewed by Geoff Garen.
2381
2382         Add API test coverage.
2383
2384         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2385
2386 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2387
2388         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2389         https://bugs.webkit.org/show_bug.cgi?id=195725
2390         <rdar://problem/48545062>
2391
2392         Reviewed by Tim Horton.
2393
2394         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2395         handler is nil.
2396
2397         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2398         (TestWebKitAPI::TEST):
2399
2400 2019-03-13  Sam Weinig  <sam@webkit.org>
2401
2402         Add utility function to allow easy reverse range-based iteration of a container
2403         https://bugs.webkit.org/show_bug.cgi?id=195542
2404
2405         Reviewed by Antti Koivisto.
2406
2407         * TestWebKitAPI/CMakeLists.txt:
2408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2409         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2410         (TestWebKitAPI::TEST):
2411         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2412
2413 2019-03-13  Chris Dumez  <cdumez@apple.com>
2414
2415         Use a ServiceWorker process per registrable domain
2416         https://bugs.webkit.org/show_bug.cgi?id=195649
2417
2418         Reviewed by Youenn Fablet.
2419
2420         Update API test coverage.
2421
2422         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2423
2424 2019-03-13  Chris Dumez  <cdumez@apple.com>
2425
2426         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2427         https://bugs.webkit.org/show_bug.cgi?id=195684
2428         <rdar://problem/48294714>
2429
2430         Reviewed by Antti Koivisto.
2431
2432         Add API test coverage.
2433
2434         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2435
2436 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2437
2438         [ews-app] Remove unused patch view
2439         https://bugs.webkit.org/show_bug.cgi?id=195669
2440
2441         Reviewed by Lucas Forschler.
2442
2443         * BuildSlaveSupport/ews-app/ews/urls.py:
2444         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2445
2446 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2447
2448         [ews-app] Use Buildbot result code variables
2449         https://bugs.webkit.org/show_bug.cgi?id=195668
2450
2451         Reviewed by Alexey Proskuryakov.
2452
2453         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2454         (Buildbot): Added Buildbot result code variables.
2455         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2456         (StatusBubble._build_bubble): Used Buildbot result code variables.
2457
2458 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2459
2460         [Flatpak] Expand submodule recursively
2461         https://bugs.webkit.org/show_bug.cgi?id=195672
2462
2463         Building WPE with flatpak was impossible without that as it was raising an exception.
2464         Also update wpebackend-fdo to match what is built in jhbuild
2465
2466         Reviewed by Philippe Normand.
2467
2468         * flatpak/flatpakutils.py:
2469         (expand_submodules_recurse):
2470         (expand_manifest):
2471         * flatpak/org.webkit.WPEModules.yaml:
2472
2473 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2474
2475         [ews-app] status bubble should be hidden for certain builds
2476         https://bugs.webkit.org/show_bug.cgi?id=194597
2477
2478         Reviewed by Dewei Zhu.
2479
2480         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2481         (StatusBubble._build_bubble):
2482         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2483         because the patch didn't have relevant changes.
2484         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2485         in production yet.
2486
2487 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2488
2489         [Win] Fix a slew of simple clang-cl warnings.
2490         https://bugs.webkit.org/show_bug.cgi?id=195652
2491
2492         Reviewed by Don Olmstead.
2493
2494         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2495         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2496
2497 2019-03-12  Justin Fan  <justin_fan@apple.com>
2498
2499         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2500         https://bugs.webkit.org/show_bug.cgi?id=195518
2501         <rdar://problem/46322356>
2502
2503         Reviewed by Myles C. Maxfield.
2504
2505         * DumpRenderTree/DerivedSources-input.xcfilelist:
2506         * DumpRenderTree/DerivedSources-output.xcfilelist:
2507
2508 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2509
2510         Unreviewed, rolling out r242825.
2511         https://bugs.webkit.org/show_bug.cgi?id=195648
2512
2513         "Broke webkitpy tests with my change to
2514         lldb_dump_class_layout.py" (Requested by rmorisset on
2515         #webkit).
2516
2517         Reverted changeset:
2518
2519         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2520         classes with suspicious padding"
2521         https://bugs.webkit.org/show_bug.cgi?id=195573
2522         https://trac.webkit.org/changeset/242825
2523
2524 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2525
2526         [ews-build] Show status bubbles while the patch is waiting in queue
2527         https://bugs.webkit.org/show_bug.cgi?id=195618
2528
2529         Reviewed by Lucas Forschler.
2530
2531         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2532         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2533         enabled in initial deployment.
2534         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2535         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2536         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2537         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2538         (StatusBubble._build_bubbles_for_patch):
2539
2540 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2541
2542         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2543         https://bugs.webkit.org/show_bug.cgi?id=195573
2544
2545         Reviewed by Simon Fraser.
2546
2547         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2548
2549         * Scripts/dump-class-layout:
2550         (main):
2551         * lldb/lldb_dump_class_layout.py:
2552         (ClassLayout.__init__):
2553         (ClassLayout._compute_padding_recursive):
2554         (LLDBDebuggerInstance.dump_layout_for_classname):
2555         (LLDBDebuggerInstance):
2556         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2557         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2558
2559 2019-03-12  Chris Dumez  <cdumez@apple.com>
2560
2561         Device Orientation access permission should be denied unless explicitly granted by the client
2562         https://bugs.webkit.org/show_bug.cgi?id=195625
2563
2564         Reviewed by Youenn Fablet.
2565
2566         add API test coverage.
2567
2568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2569         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2570         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2571         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2572         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2573         (runDeviceOrientationTest):
2574         (TEST):
2575         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2576         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2577
2578 2019-03-12  Jer Noble  <jer.noble@apple.com>
2579
2580         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2581         https://bugs.webkit.org/show_bug.cgi?id=195137
2582         <rdar://problem/48810307>
2583
2584         Reviewed by Eric Carlson.
2585
2586         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2587         (TestWebKitAPI::TEST):
2588
2589 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2590
2591         [ews-build] Change urls from uat to production
2592         https://bugs.webkit.org/show_bug.cgi?id=195566
2593
2594         Reviewed by Lucas Forschler.
2595
2596         * BuildSlaveSupport/ews-app/ews/config.py:
2597         * BuildSlaveSupport/ews-build/events.py:
2598         * BuildSlaveSupport/ews-build/steps.py:
2599
2600 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2601
2602         [ews-build] change max_builds for local-worker to 1
2603         https://bugs.webkit.org/show_bug.cgi?id=195568
2604
2605         Reviewed by Lucas Forschler.
2606
2607         * BuildSlaveSupport/ews-build/loadConfig.py:
2608
2609 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2610
2611         Fix the build
2612
2613         * TestRunnerShared/spi/PencilKitTestSPI.h:
2614         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2615
2616 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2617
2618         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2619         https://bugs.webkit.org/show_bug.cgi?id=194131
2620
2621         Reviewed by Michael Catanzaro.
2622
2623         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2624         (uriChanged):
2625         (testUnfinishedSubresourceLoad):
2626         (serverCallback):
2627         (beforeAll):
2628
2629 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2630
2631         WTF::Expected should use std::addressof instead of operator&
2632         https://bugs.webkit.org/show_bug.cgi?id=195604
2633
2634         Reviewed by Myles Maxfield.
2635
2636         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2637         (TestWebKitAPI::Unique::Unique):
2638         (TestWebKitAPI::Unique::operator&):
2639         (TestWebKitAPI::TEST):
2640
2641 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2642
2643         Add Optional to Forward.h.
2644         https://bugs.webkit.org/show_bug.cgi?id=195586
2645
2646         Reviewed by Darin Adler.
2647
2648         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2649         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2650         Remove unnecessary includes from headers.
2651
2652 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2653
2654         Add testing API to hit-test and scroll overflow scrollers
2655         https://bugs.webkit.org/show_bug.cgi?id=195278
2656
2657         Reviewed by Antti Koivisto.
2658         
2659         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2660         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2661         
2662         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2663
2664         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2665         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2666         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2667         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2668         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2669         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2670         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2671         (WTR::enclosingScrollViewIncludingSelf):
2672         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2673
2674 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2675
2676         API test WebKit.RequestTextInputContext fails on iOS
2677         https://bugs.webkit.org/show_bug.cgi?id=195585
2678
2679         Reviewed by Wenson Hsieh and Simon Fraser.
2680
2681         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2682         (applyStyle):
2683         (TEST):
2684         Add a viewport, so that the coordinates match up on iOS.
2685         Scroll by moving the UIScrollView's contentOffset.
2686
2687 2019-03-11  Chris Dumez  <cdumez@apple.com>
2688
2689         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2690         https://bugs.webkit.org/show_bug.cgi?id=195506
2691         <rdar://problem/48733477>
2692
2693         Reviewed by Alex Christensen.
2694
2695         Add API test coverage.
2696
2697         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2698
2699 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2700
2701         Adding myself to contributors.json
2702
2703         Unreviewed, addming myself to contributors.json .
2704
2705         * Scripts/webkitpy/common/config/contributors.json:
2706
2707 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2708
2709         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2710         https://bugs.webkit.org/show_bug.cgi?id=195511
2711         <rdar://problem/44873269>
2712
2713         Reviewed by Darin Adler.
2714
2715         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2716         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2717         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2718         (TEST_F):
2719
2720 2019-03-11  Chris Dumez  <cdumez@apple.com>
2721
2722         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2723         https://bugs.webkit.org/show_bug.cgi?id=195561
2724
2725         Reviewed by Youenn Fablet.
2726
2727         Make sure the JS in the test requests for permission to receive device orientation events.
2728
2729         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2730
2731 2019-03-11  Youenn Fablet  <youenn@apple.com>
2732
2733         Allow storage quota increase by default in WTR
2734         https://bugs.webkit.org/show_bug.cgi?id=195541
2735
2736         Reviewed by Geoffrey Garen.
2737
2738         Allow storage quota increase by default in WTR.
2739         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2740         Use this for tests that explicitly need cache increase.
2741
2742         Instead of increasing quota by 2, make sure the next request is
2743         granted by adding all given parameters.
2744
2745         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2746         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2747         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2748         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2749         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2750         * WebKitTestRunner/TestController.cpp:
2751         (WTR::TestController::setAllowStorageQuotaIncrease):
2752         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2753         * WebKitTestRunner/TestController.h:
2754         * WebKitTestRunner/TestInvocation.cpp:
2755         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2756         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2757         (WTR::TestController::cocoaResetStateToConsistentValues):
2758         (WTR::TestController::setAllowStorageQuotaIncrease):
2759         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2760         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2761         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2762
2763 2019-03-11  Xan Lopez  <xan@igalia.com>
2764
2765         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2766         https://bugs.webkit.org/show_bug.cgi?id=194147
2767
2768         Reviewed by Michael Saboff.
2769
2770         To make --32-bit work correctly on Linux/64bit we need to:
2771
2772         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2773         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2774         unfortunately CMake only allows us to do this during
2775         crosscompilation, which is overkill here.
2776         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2777         pkg-config detection module uses the x86 .pc files instead of the
2778         x86_64 ones.
2779         - Set the -m32 flags for the compiler.
2780
2781         * Scripts/webkitdirs.pm:
2782         (generateBuildSystemFromCMakeProject):
2783
2784 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2785
2786         Add MotionMark-1.1 plan file for run-benchmark script.
2787         https://bugs.webkit.org/show_bug.cgi?id=195481
2788
2789         Rubber-stamped by Darin Adler.
2790
2791         Run-benchmark script should support MontionMark-1.1.
2792
2793         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2794
2795 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2796
2797         [ews-app] Add support for submit-to-ews url
2798         https://bugs.webkit.org/show_bug.cgi?id=195477
2799
2800         Reviewed by Lucas Forschler.
2801
2802         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2803         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2804         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2805         * BuildSlaveSupport/ews-app/ews/urls.py:
2806         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2807
2808 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2809
2810         Unreviewed, rolling out r242688, r242643, r242624.
2811
2812         Caused multiple layout test failures and crashes on iOS and macOS.
2813
2814         Reverted changeset:
2815
2816         "requestAnimationFrame should execute before the next frame"
2817         https://bugs.webkit.org/show_bug.cgi?id=177484
2818         https://trac.webkit.org/changeset/242624/webkit
2819
2820         * Tracing/SystemTracePoints.plist:
2821
2822 2019-03-11  John Wilander  <wilander@apple.com>
2823
2824         Resource Load Statistics: Make it possible exclude localhost from classification
2825         https://bugs.webkit.org/show_bug.cgi?id=195474
2826         <rdar://problem/47520577>
2827
2828         Reviewed by Brent Fulgham.
2829
2830         This patch allows for localhost to be excluded from classification and
2831         treatment as a prevalent resource.
2832
2833         The WebKit Tools change adds a new function called
2834         testRunner.setStatisticsIsRunningTest() which can be used to control this
2835         behavior.
2836
2837         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2838         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2839         (WTR::TestRunner::setStatisticsIsRunningTest):
2840         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2841         * WebKitTestRunner/TestController.cpp:
2842         (WTR::TestController::setStatisticsIsRunningTest):
2843         * WebKitTestRunner/TestController.h:
2844         * WebKitTestRunner/TestInvocation.cpp:
2845         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2846
2847 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2848
2849         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2850         https://bugs.webkit.org/show_bug.cgi?id=195560
2851
2852         Reviewed by Lucas Forschler.
2853
2854         * BuildSlaveSupport/ews-build/master.cfg:
2855
2856 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2857
2858         Unreviewed, rolling out r242698.
2859
2860         API test crashes on bots.
2861
2862         Reverted changeset:
2863
2864         "Add a WKContentRuleList variant that uses copied memory
2865         instead of mmap'd shared memory for class A containerized
2866         apps"
2867         https://bugs.webkit.org/show_bug.cgi?id=195511
2868         https://trac.webkit.org/changeset/242698
2869
2870 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2871
2872         [WPE] Enable web process sandbox
2873         https://bugs.webkit.org/show_bug.cgi?id=195169
2874
2875         Reviewed by Daniel Bates.
2876
2877         * wpe/install-dependencies:
2878         * wpe/jhbuild.modules:
2879
2880 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2881
2882         [ews-app] Use port 17000 for worker communication
2883         https://bugs.webkit.org/show_bug.cgi?id=195558
2884
2885         Reviewed by Lucas Forschler.
2886
2887         * BuildSlaveSupport/ews-build/master.cfg:
2888
2889 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2890
2891         [ews-build] unit-tests fail when passwords.json is missing
2892         https://bugs.webkit.org/show_bug.cgi?id=195557
2893
2894         Reviewed by Lucas Forschler.
2895
2896         * BuildSlaveSupport/ews-build/loadConfig.py:
2897         (loadBuilderConfig):
2898         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2899         (ConfigDotJSONTest.test_configuration):
2900         * BuildSlaveSupport/ews-build/master.cfg:
2901
2902 2019-03-11  Truitt Savell  <tsavell@apple.com>
2903
2904         Unreviewed, rolling out r242702.
2905
2906         Broke High Sierra builders.
2907
2908         Reverted changeset:
2909
2910         "Add utility function to allow easy reverse range-based
2911         iteration of a container"
2912         https://bugs.webkit.org/show_bug.cgi?id=195542
2913         https://trac.webkit.org/changeset/242702
2914
2915 2019-03-11  Sam Weinig  <sam@webkit.org>
2916
2917         Add utility function to allow easy reverse range-based iteration of a container
2918         https://bugs.webkit.org/show_bug.cgi?id=195542
2919
2920         Reviewed by Antti Koivisto.
2921
2922         * TestWebKitAPI/CMakeLists.txt:
2923         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2924         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2925         (TestWebKitAPI::TEST):
2926         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2927
2928 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2929
2930         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2931         https://bugs.webkit.org/show_bug.cgi?id=195511
2932         <rdar://problem/44873269>
2933
2934         Reviewed by Darin Adler.
2935
2936         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2937         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2938         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2939         (TEST_F):
2940
2941 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2942
2943         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2944         https://bugs.webkit.org/show_bug.cgi?id=195499
2945
2946         Reviewed by Darin Adler.
2947
2948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2949         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2950         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2951         (-[WKWebView synchronouslyFocusTextInputContext:]):
2952         (applyStyle):
2953         (applyIframe):
2954         (TEST):
2955         Add some tests for this SPI.
2956
2957 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2958
2959         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2960         https://bugs.webkit.org/show_bug.cgi?id=181151
2961
2962         Reviewed by Don Olmstead.
2963
2964         * TestWebKitAPI/CMakeLists.txt:
2965         * TestWebKitAPI/PlatformWin.cmake:
2966         Enable TestWTF RunLoop tests in all platforms.
2967
2968         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2969         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2970         (TestWebKitAPI::DerivedOneShotTimer::fired):
2971         (TestWebKitAPI::TEST):
2972         Only a few platforms support nested RunLoop.
2973
2974         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2975         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2976
2977 2019-03-10  David Quesada  <david_quesada@apple.com>
2978
2979         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2980         https://bugs.webkit.org/show_bug.cgi?id=152480
2981
2982         Reviewed by Chris Dumez.
2983
2984         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2985         there are no additional references to the process pool besides the one held by
2986         the download, waits for the download to finish (in the sense that the
2987         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2988         measure, also check that the process pool has been deallocated at the end of the
2989         test. The test wouldn't be meaningful if the process pool were still alive.
2990
2991         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2992         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2993         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2994             The download will be canceled because the delegate does not implement the
2995             method to decide the download's destination, so this is where we know the
2996             DownloadProxyMap is done with the DownloadProxy.
2997         (TEST):
2998
2999 2019-03-08  Chris Dumez  <cdumez@apple.com>
3000
3001         Add support for Device Orientation / Motion permission API
3002         https://bugs.webkit.org/show_bug.cgi?id=195329
3003         <rdar://problem/47645367>
3004
3005         Reviewed by Geoffrey Garen.
3006
3007         Add test infrastructure to help test the Device Orientation / Motion permission API.
3008
3009         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3010         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3011         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3012         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3013         * WebKitTestRunner/TestController.cpp:
3014         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3015         (WTR::TestController::createWebViewWithOptions):
3016         (WTR::TestController::resetStateToConsistentValues):
3017         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3018         * WebKitTestRunner/TestController.h:
3019         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3020         * WebKitTestRunner/TestInvocation.cpp:
3021         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3022
3023 2019-03-08  Saam barati  <sbarati@apple.com>
3024
3025         Add a compare-results script to compare benchmark results
3026         https://bugs.webkit.org/show_bug.cgi?id=195486
3027         <rdar://problem/48723397>
3028
3029         Reviewed by Geoffrey Garen.
3030
3031         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3032         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3033         to extend it to learn about our other benchmarks.
3034
3035         * Scripts/compare-results: Added.
3036         (readJSONFile):
3037         (detectJetStream2):
3038         (JetStream2Results):
3039         (detectSpeedometer2):
3040         (Speedometer2Results):
3041         (detectPLT5):
3042         (PLT5Results):
3043         (detectBenchmark):
3044         (biggerIsBetter):
3045         (ttest):
3046         (getOptions):
3047         (main):
3048
3049 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3050
3051         Ensure old tab state is cleared between iterations of run-benchmark
3052         https://bugs.webkit.org/show_bug.cgi?id=195393
3053         <rdar://problem/46885583>
3054
3055         Reviewed by Dewei Zhu.
3056
3057         a) ensure the default to restore state is not set
3058         b) terminate Safari correctly
3059         c) Set the system default to ignore Persistent State in Safari
3060
3061         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3062         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3063         (OSXBrowserDriver.prepare_env): 
3064         (OSXBrowserDriver.restore_env):
3065         (OSXBrowserDriver.close_browsers):
3066         (OSXBrowserDriver._terminate_processes):
3067         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3068         (OSXChromeDriver):
3069         (OSXChromeCanaryDriver):
3070         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3071         (OSXFirefoxDriver):
3072         (OSXFirefoxNightlyDriver):
3073         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3074         (OSXSafariDriver):
3075         (OSXSafariDriver.prepare_env):
3076
3077 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3078
3079         [GTK] Several InputMethodFilter tests are failing
3080         https://bugs.webkit.org/show_bug.cgi?id=195408
3081
3082         Reviewed by Carlos Garcia Campos.
3083
3084         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3085         Regressed in r241751.
3086         Hexadecimal values of keycodes are expressed now in upper letters.
3087         Composited characters should be cast to UTF8 strings.
3088
3089         (TestWebKitAPI::TEST):
3090
3091 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3092
3093         [GTK] Make Tools/gtkdoc python3 compatible
3094         https://bugs.webkit.org/show_bug.cgi?id=195359
3095
3096         Reviewed by Carlos Garcia Campos.
3097
3098         * gtkdoc/generate-gtkdoc:
3099         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3100         work with Python 2 and 3.
3101         (get_gtkdoc_module_paths):
3102         The iteritems() was removed in Python 3, so let's use items() that's
3103         available in Python 2 and 3.
3104         (get_generator_for_config):
3105         * gtkdoc/gtkdoc.py:
3106         (GTKDoc._run_command):
3107         The sys.stdout.write() is expecting str in Python 3 and not bytes
3108         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3109         for passing the bytes there.
3110
3111 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3112
3113         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3114         https://bugs.webkit.org/show_bug.cgi?id=195346
3115         <rdar://problem/48667048>
3116
3117         Unreviewed build fix for clang-cl.
3118
3119         * DumpRenderTree/win/DumpRenderTree.cpp:
3120         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3121
3122 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3123
3124         requestAnimationFrame should execute before the next frame
3125         https://bugs.webkit.org/show_bug.cgi?id=177484
3126
3127         Reviewed by Simon Fraser.
3128
3129         Add trace points for the page RenderingUpdate.
3130
3131         * Tracing/SystemTracePoints.plist:
3132
3133 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3134
3135         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3136         https://bugs.webkit.org/show_bug.cgi?id=195353
3137         <rdar://problem/48626394>
3138
3139         Reviewed by Simon Fraser.
3140
3141         * WebKitTestRunner/ios/TestControllerIOS.mm:
3142         (WTR::TestController::platformResetPreferencesToConsistentValues):
3143
3144 2019-03-07  John Wilander  <wilander@apple.com>
3145
3146         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3147         https://bugs.webkit.org/show_bug.cgi?id=195383
3148         <rdar://problem/48570136>
3149
3150         Reviewed by Brent Fulgham.
3151
3152         This patch adds test infrastructure to purge only script-accessible cookies,
3153         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3154
3155         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3156         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3157         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3158         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3159         * WebKitTestRunner/TestController.cpp:
3160         (WTR::TestController::statisticsDeleteCookiesForHost):
3161         * WebKitTestRunner/TestController.h:
3162         * WebKitTestRunner/TestInvocation.cpp:
3163         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3164
3165 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3166
3167         Unreviewed, rolling out r242354.
3168         https://bugs.webkit.org/show_bug.cgi?id=195402
3169
3170         breaks layout tests in all configurations (Requested by
3171         zdobersek on #webkit).
3172
3173         Reverted changeset:
3174
3175         "[WPE] Enable web process sandbox"
3176         https://bugs.webkit.org/show_bug.cgi?id=195169
3177         https://trac.webkit.org/changeset/242354
3178
3179 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3180
3181         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3182         https://bugs.webkit.org/show_bug.cgi?id=195346
3183
3184         Reviewed by Fujii Hironori.
3185
3186         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3187         (TestWebKitAPI::TEST):
3188         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3189
3190         * DumpRenderTree/win/DumpRenderTree.cpp:
3191         (findFontFallback):
3192         (addFontFallbackIfPresent):
3193         (removeFontFallbackIfPresent):
3194         (main):
3195         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3196         (TestWebKitAPI::Util::moduleDirectory):
3197         (TestWebKitAPI::Util::createInjectedBundlePath):
3198         Use wchar helpers as needed.
3199
3200 2019-03-06  Rob Buis  <rbuis@igalia.com>
3201
3202         Consider supporting the `referrerpolicy` attribute.
3203         https://bugs.webkit.org/show_bug.cgi?id=179053
3204
3205         Reviewed by Darin Adler.
3206
3207         Add a runtime flag for referrerpolicy attribute.
3208
3209         * DumpRenderTree/mac/DumpRenderTree.mm:
3210         (enableExperimentalFeatures):
3211
3212 2019-03-05  Daniel Bates  <dabates@apple.com>
3213
3214         Update expected API test result following r242379
3215         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3216
3217         Update expected x-coordinate of selection rect now that the left padding of
3218         a textarea is sized in ems (so dependent on the font size) just like the left
3219         padding of a text field.
3220
3221         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3222         (TestWebKitAPI::TEST):
3223
3224 2019-03-05  David Quesada  <david_quesada@apple.com>
3225
3226         [WK2] It should be possible to follow links with 'download' attributes
3227         https://bugs.webkit.org/show_bug.cgi?id=195145
3228         rdar://problem/48462642
3229
3230         Reviewed by Alex Christensen.
3231
3232         Add a unit test to verify that activating links with 'download' attributes now
3233         navigates to the linked resource, rather than starts downloading it. Add another
3234         to verify that it is still possible to explicitly download the link via the
3235         'Download' navigation action policy.
3236
3237         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3238         (-[DownloadAttributeTestDelegate init]):
3239         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3240         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3241         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3242         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3243         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3244         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3245         (TEST):
3246         * WebKitTestRunner/TestController.cpp:
3247         (WTR::TestController::decidePolicyForNavigationAction):
3248         * WebKitTestRunner/TestController.h:
3249
3250 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3251
3252         [Curl] Implement Cookie Accept Policy.
3253         https://bugs.webkit.org/show_bug.cgi?id=191645
3254
3255         Reviewed by Fujii Hironori.
3256
3257         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3258         (TestWebKitAPI::Curl::TEST_F):
3259
3260 2019-03-05  Youenn Fablet  <youenn@apple.com>
3261
3262         Rename requestCacheStorageSpace to requestStorageSpace
3263         https://bugs.webkit.org/show_bug.cgi?id=195282
3264
3265         Reviewed by Chris Dumez.
3266
3267         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3268         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3269         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3270
3271 2019-03-05  Brady Eidson  <beidson@apple.com>
3272
3273         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3274         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3275
3276         Reviewed by Tim Horton.
3277
3278         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3279         different directory into that same WKWebView should work.
3280
3281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3282         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3283
3284 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3285
3286         Add WeakHashSet
3287         https://bugs.webkit.org/show_bug.cgi?id=195152
3288
3289         Reviewed by Antti Koivisto.
3290
3291         Added tests for WeakHashSet.
3292
3293         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3294         (TestWebKitAPI::Base::Base): Moved.
3295         (TestWebKitAPI::Derived::foo): Moved.
3296         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3297         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3298         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3299         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3300
3301 2019-03-04  Chris Dumez  <cdumez@apple.com>
3302
3303         Do not share WebProcesses between private and regular sessions
3304         https://bugs.webkit.org/show_bug.cgi?id=195189
3305         <rdar://problem/48421064>
3306
3307         Reviewed by Alex Christensen.
3308
3309         Add API test coverage.
3310
3311         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3312         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3313
3314 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3315
3316         [WPE] Enable web process sandbox
3317         https://bugs.webkit.org/show_bug.cgi?id=195169
3318
3319         Reviewed by Daniel Bates.
3320
3321         * wpe/install-dependencies:
3322         * wpe/jhbuild.modules:
3323
3324 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3325
3326         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3327         https://bugs.webkit.org/show_bug.cgi?id=195206
3328
3329         Reviewed by Žan Doberšek.
3330
3331         Add a new test case.
3332
3333         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3334         (testJSCClass):
3335
3336 2019-03-04  Charlie Turner  <cturner@igalia.com>
3337
3338         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3339         https://bugs.webkit.org/show_bug.cgi?id=194898
3340
3341         Reviewed by Žan Doberšek.
3342
3343         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3344         a GCC extension that permits arithmetic on void* pointer. Inline
3345         the macro until this issue is fixed upstream.
3346
3347 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3348
3349         Rid the world of WK_API_ENABLED
3350         https://bugs.webkit.org/show_bug.cgi?id=195263
3351
3352         Reviewed by Dan Bernstein.
3353
3354         List of changed files elided because it's useless.
3355
3356 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3357
3358         Unreviewed follow-up to r242292.
3359
3360         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3361
3362         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3363         (TestWebKitAPI::testStrip): Renamed from strip.
3364         (TestWebKitAPI::TEST):
3365
3366 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3367
3368         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3369
3370         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3371         and bug #194272 for details.
3372
3373         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3374
3375 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3376
3377         Remove some more unused 32-bit code
3378         https://bugs.webkit.org/show_bug.cgi?id=195255
3379
3380         Reviewed by Darin Adler.
3381
3382         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3383         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3384         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3385         (NPP_New):
3386         (NPP_HandleEvent):
3387         (handleEventCarbon): Deleted.
3388
3389 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3390
3391         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3392
3393         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3394         (TestWebKitAPI::TEST):
3395
3396 2019-03-01  Darin Adler  <darin@apple.com>
3397
3398         Finish removing String::format
3399         https://bugs.webkit.org/show_bug.cgi?id=194893
3400
3401         Reviewed by Daniel Bates.
3402 '
3403         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3404
3405 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3406
3407         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3408         https://bugs.webkit.org/show_bug.cgi?id=195229
3409         <rdar://problem/48520362>
3410
3411         Reviewed by Chris Dumez.
3412
3413         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3414         (TEST):
3415
3416 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3417
3418         Add a system trace scope for event region building
3419         https://bugs.webkit.org/show_bug.cgi?id=195226
3420
3421         Reviewed by Jon Lee.
3422
3423         This trace scope measures the time spend converting element rects into Region objects,
3424         which can be large on some pages.
3425
3426         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3427
3428         * Tracing/SystemTracePoints.plist:
3429
3430 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3431
3432         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3433         https://bugs.webkit.org/show_bug.cgi?id=194612
3434
3435         Reviewed by Alex Christensen.
3436
3437         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3438         Just test the new string-processing function and don't touch the actual environment.
3439         (Test cases are all as before, but based on operator== instead of strcmp.)
3440
3441 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3442
3443         [ews-app] Update primary keys for handling multiple Buildbot instances
3444         https://bugs.webkit.org/show_bug.cgi?id=195120
3445
3446         Reviewed by Stephanie Lewis.
3447
3448         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3449         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3450         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3451
3452         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3453         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3454         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3455         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3456         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3457         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3458
3459 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3460
3461         [WinCairo] Enable service worker
3462         https://bugs.webkit.org/show_bug.cgi?id=188318
3463
3464         Reviewed by Youenn Fablet.
3465
3466         * DumpRenderTree/DumpRenderTreePrefix.h:
3467         * TestWebKitAPI/PlatformWin.cmake:
3468         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3469         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3470         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3471
3472 2019-03-01  Justin Fan  <justin_fan@apple.com>
3473
3474         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3475         https://bugs.webkit.org/show_bug.cgi?id=195191
3476
3477         Rubber-stamped by Dean Jackson.
3478
3479         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3480
3481         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3482
3483 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3484
3485         Unreviewed, fix lldb webkitpy tests
3486         https://bugs.webkit.org/show_bug.cgi?id=194375
3487
3488         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3489
3490         * lldb/lldb_webkit.py:
3491         (WTFStringImplProvider.is_8bit):
3492
3493 2019-02-28  David Quesada  <david_quesada@apple.com>
3494
3495         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3496         https://bugs.webkit.org/show_bug.cgi?id=195121
3497         rdar://problem/48450302
3498
3499         Reviewed by Alex Christensen.
3500
3501         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3502         configurations where the 'download' attribute is absent, blank, or populated
3503         with a filename, and where the anchor element is same-origin or cross-origin
3504         (meaning the 'download' attribute shouldn't be honored).
3505
3506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3507         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3508         (-[NavigationActionTestDelegate init]):
3509         (-[NavigationActionTestDelegate navigationAction]):
3510         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3511         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3512         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3513         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3514         (TEST):
3515
3516 2019-02-28  Antoine Quint  <graouts@apple.com>
3517
3518         Enable the Pointer Events runtime flag by default
3519         https://bugs.webkit.org/show_bug.cgi?id=195156
3520
3521         Reviewed by Dean Jackson.
3522
3523         * DumpRenderTree/mac/DumpRenderTree.mm:
3524         (enableExperimentalFeatures):
3525
3526 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3527
3528         Several PasteImage API tests are flaky
3529         https://bugs.webkit.org/show_bug.cgi?id=195160
3530
3531         Reviewed by Tim Horton.
3532
3533         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3534         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3535         listening for a "load" event after image load is already complete.
3536
3537         To address this, make these tests first register a "load" event handler, then run script to insert an image
3538         element into the document, and finally wait until the load event is observed before checking image size.
3539
3540         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3541
3542 2019-02-28  Chris Dumez  <cdumez@apple.com>
3543
3544         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3545         https://bugs.webkit.org/show_bug.cgi?id=195107
3546
3547         Reviewed by Alex Christensen.
3548
3549         Give some time for the zoom level to get restored.
3550
3551         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3552
3553 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3554
3555         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3556         https://bugs.webkit.org/show_bug.cgi?id=194958
3557
3558         Reviewed by Geoffrey Garen.
3559
3560         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3561         (TEST):
3562
3563 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3564
3565         [ews-app] Update method to save build to handle builder_display_name
3566         https://bugs.webkit.org/show_bug.cgi?id=195047
3567
3568         Reviewed by Dewei Zhu.
3569
3570         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3571         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3572
3573 2019-02-28  Justin Fan  <justin_fan@apple.com>
3574
3575         [Web GPU] Enable Web GPU only on 64-bit
3576         https://bugs.webkit.org/show_bug.cgi?id=195139
3577
3578         Because Metal is only supported on 64 bit apps.
3579
3580         Unreviewed build fix.
3581
3582         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3583
3584 2019-02-27  Youenn Fablet  <youenn@apple.com>
3585
3586         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3587         https://bugs.webkit.org/show_bug.cgi?id=194959
3588
3589         Reviewed by Chris Dumez.
3590
3591         Spin loop until getting the condition to remove flakiness.
3592
3593         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3594
3595 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3596
3597         [ews-build] Buildbot should include builder_display_name in the build events
3598         https://bugs.webkit.org/show_bug.cgi?id=195045
3599
3600         Reviewed by Dewei Zhu.
3601
3602         * BuildSlaveSupport/ews-build/events.py:
3603         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3604         buildername to builder_name to be consistent in naming style.
3605         (Events.buildFinished): Ditto.
3606
3607 2019-02-27  Chris Dumez  <cdumez@apple.com>
3608
3609         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3610         https://bugs.webkit.org/show_bug.cgi?id=194480
3611
3612         Reviewed by Brady Eidson.
3613
3614         Update existing API test to make it more likely to reproduce the issue.
3615
3616         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3617
3618 2019-02-27  Brady Eidson  <beidson@apple.com>
3619
3620         Universal links from Google search results pages don't open the app.
3621         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3622
3623         Reviewed by Geoffrey Garen.
3624
3625         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3626         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3627         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3628         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3629
3630 2019-02-27  Chris Dumez  <cdumez@apple.com>
3631
3632         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3633         https://bugs.webkit.org/show_bug.cgi?id=195102
3634
3635         Reviewed by Geoffrey Garen.
3636
3637         If the number of processes is not yet what we expect, wait a bit and check again to give
3638         processes some time to exit.
3639
3640         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3641
3642 2019-02-27  Chris Dumez  <cdumez@apple.com>
3643
3644         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3645         https://bugs.webkit.org/show_bug.cgi?id=194545
3646
3647         Reviewed by Brady Eidson.
3648
3649         Make sure the test navigates forward and then back only once. Previously, navigating
3650         back would trigger a navigation again in a timer.
3651
3652         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3653
3654 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3655
3656         High Sierra Debug JSC test queue should use faster hardware
3657         https://bugs.webkit.org/show_bug.cgi?id=194603
3658
3659         Rubber-stamped by Alexey Proskuryakov.
3660
3661         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3662
3663         * BuildSlaveSupport/build.webkit.org-config/config.json:
3664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3665         (BubbleQueueServer):
3666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3667         (WebKitBuildbot):
3668         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3669         * QueueStatusServer/config/queues.py:
3670         * Scripts/webkitpy/common/config/ews.json:
3671         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3672         (test_ews_name):
3673
3674 2019-02-27  John Wilander  <wilander@apple.com>
3675
3676         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3677         https://bugs.webkit.org/show_bug.cgi?id=195071
3678         <rdar://problem/48417690>
3679
3680         Reviewed by Alex Christensen and Brent Fulgham.
3681
3682         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3683         (TestWebKitAPI::createURL):
3684             Convenience function.
3685         (TestWebKitAPI::TEST):
3686             WebCore::AdClickAttribution now takes a URL when creating Source and
3687             Destination.
3688         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3689         (TestWebKitAPI::TEST):
3690             WebCore::AdClickAttribution now takes a URL when creating Source and
3691             Destination.
3692
3693 2019-02-27  Antoine Quint  <graouts@apple.com>
3694
3695         Support Pointer Events on macOS
3696         https://bugs.webkit.org/show_bug.cgi?id=195008
3697         <rdar://problem/47454419>
3698
3699         Reviewed by Dean Jackson.
3700
3701         * DumpRenderTree/mac/DumpRenderTree.mm:
3702         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3703         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3704
3705 2019-02-26  Mark Lam  <mark.lam@apple.com>
3706
3707         Remove remaining poisoning code.
3708         https://bugs.webkit.org/show_bug.cgi?id=194138
3709
3710         Reviewed by Saam Barati.
3711
3712         * TestWebKitAPI/CMakeLists.txt:
3713         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3714         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3715         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3716         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3717         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3718         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3719         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3720
3721 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3722
3723         Move ephemeral local storage from WebProcess to UIProcess
3724         https://bugs.webkit.org/show_bug.cgi?id=195074
3725         <rdar://problem/47937975>
3726
3727         Reviewed by Geoff Garen.
3728
3729         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3730
3731 2019-02-20  Jer Noble  <jer.noble@apple.com>
3732
3733         [Cocoa] Media elements will restart network buffering just before suspending
3734         https://bugs.webkit.org/show_bug.cgi?id=193691
3735
3736         Reviewed by Eric Carlson.
3737
3738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3739         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3740         (TEST):
3741
3742 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3743
3744         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3745         https://bugs.webkit.org/show_bug.cgi?id=191652
3746
3747         Reviewed by Alex Christensen.
3748
3749         Fix WinCairo MiniBrowser behavior of authentication dialog.
3750
3751         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3752         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3753
3754 2019-02-26  Youenn Fablet  <youenn@apple.com>
3755
3756         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3757         https://bugs.webkit.org/show_bug.cgi?id=195028
3758         <rdar://problem/48243733>
3759
3760         Reviewed by Eric Carlson.
3761
3762         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3763
3764 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3765
3766         [WPE] Add API for webview background color configuration
3767         https://bugs.webkit.org/show_bug.cgi?id=192305
3768
3769         Reviewed by Michael Catanzaro.
3770
3771         * MiniBrowser/wpe/main.cpp:
3772         (main): Add a new option to configure the webview background
3773         color. Example: --bg-color=transparent.
3774         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3775         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3776         (beforeAll): Ditto.
3777
3778 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3779
3780         scalableNativeWebpageParameters() is not preserved on new page navigation.
3781         https://bugs.webkit.org/show_bug.cgi?id=194892
3782         <rdar://problem/47538280>
3783
3784         Reviewed by Wenson Hsieh.
3785         
3786         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3787
3788         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3789         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3790         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3791         (WTR::UIScriptController::allowsViewportShrinkToFit):
3792         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3793         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3794         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3795         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3796         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3797         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3798
3799 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3800
3801         [ews-app] Add model for handling multiple Buildbot instances
3802         https://bugs.webkit.org/show_bug.cgi?id=194863
3803
3804         Reviewed by Stephanie Lewis.
3805
3806         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3807
3808 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3809
3810         [ews-app] Remove BuilderMapping table
3811         https://bugs.webkit.org/show_bug.cgi?id=194961
3812
3813         Reviewed by Stephanie Lewis.
3814
3815         Store builder name directly in build table, instead of having a separate
3816         table for it.
3817
3818         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3819         * BuildSlaveSupport/ews-app/ews/models/build.py:
3820         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3821         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3822
3823 2019-02-25  John Wilander  <wilander@apple.com>
3824
3825         Introduce and adopt new class RegistrableDomain for eTLD+1
3826         https://bugs.webkit.org/show_bug.cgi?id=194791
3827         <rdar://problem/48179240>
3828
3829         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3830
3831         This patch adds an API test and replaces two instances of
3832         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3833
3834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3835         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3836         (TestWebKitAPI::TEST):
3837             Changed two strings to make sure the registrable domains are still considered
3838             invalid and pass the test.
3839         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3840         (TestWebKitAPI::TEST):
3841         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3842         (WTR::InjectedBundle::didReceiveMessageToPage):
3843
3844 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3845
3846         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3847         https://bugs.webkit.org/show_bug.cgi?id=195001
3848
3849         Reviewed by Carlos Garcia Campos.
3850
3851         API version 1.0 always includes the functionality previously guarded with
3852         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3853         unconditionally.
3854
3855         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3856         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3857         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3858         (WebViewTest::showInWindow): Ditto.
3859         (WebViewTest::hideView): Ditto.
3860         * wpe/backends/HeadlessViewBackend.cpp:
3861         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3862         * wpe/backends/ViewBackend.cpp:
3863         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3864         * wpe/backends/WindowViewBackend.cpp:
3865         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3866         WPE_BACKEND_CHECK_VERSION().
3867         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3868
3869 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3870
3871         [Flatpak] Add support for flatpak > 1.1.2
3872         https://bugs.webkit.org/show_bug.cgi?id=194088
3873
3874         Flatpak 1.2 is now out so we need to support that
3875         version now.
3876
3877         Reviewed by Michael Catanzaro.
3878
3879         * flatpak/flatpakutils.py:
3880         (check_flatpak):
3881         (FlatpakPackages.__init__):
3882         (FlatpakPackages.__detect_packages):
3883         (FlatpakPackages.__detect_packages.in):
3884         (FlatpakRepos.update):
3885
3886 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3887
3888         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3889         https://bugs.webkit.org/show_bug.cgi?id=194998
3890
3891         Reviewed by Carlos Garcia Campos.
3892
3893         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3894         to a Git checkout and using the latest commit containing various fixes
3895         and improvements.
3896
3897 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3898
3899         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3900         https://bugs.webkit.org/show_bug.cgi?id=194981
3901
3902         Reviewed by Žan Doberšek.
3903
3904         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3905         (TestWebKitAPI::TEST):
3906
3907 2019-02-23  Keith Miller  <keith_miller@apple.com>
3908
3909         Add new mac target numbers
3910         https://bugs.webkit.org/show_bug.cgi?id=194955
3911
3912         Reviewed by Tim Horton.
3913
3914         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3915         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3916         * MiniBrowser/Configurations/Base.xcconfig:
3917         * TestWebKitAPI/Configurations/Base.xcconfig:
3918         * WebKitTestRunner/Configurations/Base.xcconfig:
3919
3920 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3921
3922         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3923         https://bugs.webkit.org/show_bug.cgi?id=194846
3924
3925         Reviewed by Don Olmstead.
3926
3927         Added _search_paths() and _port_specific_expectations_files() for
3928         WinCairoPort.
3929
3930         * Scripts/webkitpy/port/win.py:
3931         (WinCairoPort.default_baseline_search_path):
3932         (WinCairoPort):
3933         (WinCairoPort._port_specific_expectations_files):
3934         (WinCairoPort._search_paths):
3935
3936 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3937
3938         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3939         https://bugs.webkit.org/show_bug.cgi?id=194963
3940
3941         Reviewed by Dean Jackson.
3942
3943         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3944         Do a `contains` check instead of `equals`, because in debug builds we
3945         put the GraphicsLayer pointer in a prefix.
3946
3947 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3948
3949         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3950         https://bugs.webkit.org/show_bug.cgi?id=194873
3951         <rdar://problem/46701974>
3952
3953         Reviewed by Tim Horton.
3954
3955         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3956
3957         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3958         (WTR::UIScriptController::menuRect const):
3959         (WTR::UIScriptController::isShowingMenu const):
3960         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3961         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3962         (WTR::UIScriptController::menuRect const):
3963
3964         Add a function to query the bounds of the callout menu in content coordinates.
3965
3966         (WTR::UIScriptController::isShowingMenu const):
3967
3968         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3969
3970         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3971         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3972         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3973         (WTR::UIScriptController::rectForMenuAction const):
3974         (WTR::UIScriptController::menuRect const):
3975         (WTR::UIScriptController::isShowingMenu const):
3976         (WTR::findViewInHierarchyOfType): Deleted.
3977
3978 2019-02-22  Chris Dumez  <cdumez@apple.com>
3979
3980         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3981         https://bugs.webkit.org/show_bug.cgi?id=194954
3982         <rdar://problem/48127957>
3983
3984         Reviewed by Alex Christensen.
3985
3986         Add API test coverage.
3987
3988         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3989         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3990         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3991         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3992
3993 2019-02-22  Chris Dumez  <cdumez@apple.com>
3994
3995         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3996         https://bugs.webkit.org/show_bug.cgi?id=194924
3997         <rdar://problem/48216125>
3998
3999         Reviewed by Geoffrey Garen.
4000
4001         Add API test coverage.
4002
4003         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4004
4005 2019-02-22  Chris Dumez  <cdumez@apple.com>
4006
4007         Unreviewed, disable API test added in r241928 on iOS.
4008
4009         The cache is not enabled on devices with less than 3GB of RAM.
4010
4011         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4012
4013 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4014
4015         Hardcode Visual Viewports on everywhere except iOS WK1
4016         https://bugs.webkit.org/show_bug.cgi?id=194928
4017
4018         Reviewed by Zalan Bujtas.
4019
4020         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4021         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4022         set it to false. The setting has shipped for several years and there's no need to turn
4023         it off now.
4024
4025         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4026         Visual Viewports are not enabled.
4027         
4028         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4029         that only runs in WK2
4030
4031         * MiniBrowser/mac/SettingsController.h:
4032         * MiniBrowser/mac/SettingsController.m:
4033         (-[SettingsController init]):
4034         (-[SettingsController _populateMenu]):
4035         (-[SettingsController validateMenuItem:]):
4036         (-[SettingsController visualViewportEnabled]): Deleted.
4037         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4038         * MiniBrowser/mac/WK1BrowserWindowController.m:
4039         (-[WK1BrowserWindowController didChangeSettings]):
4040         * MiniBrowser/mac/WK2BrowserWindowController.m:
4041         (-[WK2BrowserWindowController didChangeSettings]):
4042
4043 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4044
4045         Discard cached processes when clearing website data store
4046         https://bugs.webkit.org/show_bug.cgi?id=194894
4047
4048         Reviewed by Chris Dumez.
4049
4050         Added a test case.
4051
4052         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4053         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4054
4055 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4056
4057         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4058         https://bugs.webkit.org/show_bug.cgi?id=194914
4059         <rdar://problem/47586889>
4060
4061         Reviewed by Geoffrey Garen.
4062
4063         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4064         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4065         (TEST):
4066         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4067
4068 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4069
4070         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4071         <https://webkit.org/b/194761>
4072
4073         Reviewed by Myles Maxfield.
4074
4075         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4076         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4077         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4078         to use ARC-compliant cast.
4079         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4080         ARC-compliant cast.
4081         (WTR::installFakeHelvetica): Log `error` to console if
4082         CTFontManagerRegisterFontsForURL() fails, but only on supported
4083         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4084         Call CFRelease() on `error` to fix the leak.  Update to use
4085         ARC-compliant cast.
4086         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4087         cast.
4088
4089 2019-02-21  Chris Dumez  <cdumez@apple.com>
4090
4091         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4092         https://bugs.webkit.org/show_bug.cgi?id=194481
4093
4094         Reviewed by Alex Christensen.
4095
4096         Give the processes a chance to shutdown and wait until we reached the expected number
4097         of processes.
4098
4099         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4100
4101 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4102
4103         Fix the macOS build
4104
4105         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4106
4107 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4108
4109         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4110
4111         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4112         I am a backwards.
4113
4114 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4115
4116         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4117
4118         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4119         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4120         We could force on UI-side compositing, but I feel like the test might be more
4121         valuable exercising the normal path on each platform (though the original
4122         bug was also UI-side specific). Though we can't validate that the overlay
4123         layer was installed successfully, there are layout tests that do that.
4124
4125 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4126
4127         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4128         https://bugs.webkit.org/show_bug.cgi?id=194845
4129         <rdar://problem/47944579>
4130
4131         Reviewed by Antti Koivisto.
4132
4133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4134         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4135
4136 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4137
4138         [LFC][Floats] Add support for placing formatting roots in-between floats.
4139         https://bugs.webkit.org/show_bug.cgi?id=194902
4140
4141         Reviewed by Antti Koivisto.
4142
4143         * LayoutReloaded/misc/LFC-passing-tests.txt:
4144
4145 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4146
4147         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4148         https://bugs.webkit.org/show_bug.cgi?id=194901
4149
4150         Unreviewed build fix.
4151
4152         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4153         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4154         WPEBackend-fdo-0.1 as library name.
4155
4156 2019-02-21  Rob Buis  <rbuis@igalia.com>
4157
4158         Update MIME type parser
4159         https://bugs.webkit.org/show_bug.cgi?id=180526
4160
4161         Reviewed by Darin Adler.
4162
4163         Add tests involving leading and trailing whitespace, non-token
4164         characters and quoted strings.
4165
4166         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4167         (TestWebKitAPI::TEST):
4168
4169 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4170
4171         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4172         https://bugs.webkit.org/show_bug.cgi?id=194884
4173
4174         Reviewed by Michael Catanzaro.
4175
4176         * PlatformWin.cmake:
4177
4178 2019-02-20  Chris Dumez  <cdumez@apple.com>
4179
4180         Add API test for <rdar://problem/47471222>
4181         https://bugs.webkit.org/show_bug.cgi?id=194847
4182
4183         Reviewed by Alex Christensen.
4184
4185         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4186
4187 2019-02-20  Chris Dumez  <cdumez@apple.com>
4188
4189         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4190         https://bugs.webkit.org/show_bug.cgi?id=194872
4191         <rdar://problem/47924500>
4192
4193         Reviewed by Alex Christensen.
4194
4195         Add API test coverage.
4196
4197         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4198
4199 2019-02-20  Jer Noble  <jer.noble@apple.com>
4200
4201         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4202         https://bugs.webkit.org/show_bug.cgi?id=191332
4203
4204         Reviewed by Dean Jackson.
4205
4206         * Scripts/git-is-in-range: Added.
4207
4208 2019-02-20  Andy Estes  <aestes@apple.com>
4209
4210         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4211         https://bugs.webkit.org/show_bug.cgi?id=194869
4212
4213         Rubber-stamped by Jer Noble.
4214
4215         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4216         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4217         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4218         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4220         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4221
4222 2019-02-20  Chris Dumez  <cdumez@apple.com>
4223
4224         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4225         https://bugs.webkit.org/show_bug.cgi?id=194857
4226         <rdar://problem/47759323>
4227
4228         Reviewed by Alex Christensen.
4229
4230         Add API test coverage.
4231
4232         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4233
4234 2019-02-20  Chris Dumez  <cdumez@apple.com>
4235
4236         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4237         https://bugs.webkit.org/show_bug.cgi?id=194829
4238         <rdar://problem/47889906>
4239
4240         Reviewed by Alexey Proskuryakov.
4241
4242         Every time the TestOptions were changing we were creating both a new Web view and
4243         a new WKContext, which would start a new Network process. In most cases, we only
4244         need to contruct a new Web view and we do can keep reusing the same WKContext.
4245         This patch implements this optimization and thus avoids spinning a lot of new
4246         Network processes while running the layout tests.
4247
4248         * WebKitTestRunner/TestController.cpp:
4249         (WTR::TestController::generateContextConfiguration const):
4250         (WTR::TestController::generatePageConfiguration):
4251         (WTR::TestController::createWebViewWithOptions):
4252         (WTR::TestController::resetPreferencesToConsistentValues):
4253         (WTR::updateTestOptionsFromTestHeader):
4254         * WebKitTestRunner/TestController.h:
4255         * WebKitTestRunner/TestOptions.h:
4256         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4257         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4258         (WTR::TestOptions::hasSameInitializationOptions const):
4259         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4260         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4261         (WTR::TestController::platformAddTestOptions const):
4262
4263 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4264
4265         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4266         https://bugs.webkit.org/show_bug.cgi?id=167941
4267
4268         Reviewed by Carlos Garcia Campos.
4269
4270         * MiniBrowser/gtk/main.c:
4271         (filterSavedCallback): Added.
4272         (main): Support loading a JSON rule set file for content filtering.
4273         * MiniBrowser/wpe/main.cpp:
4274         (filterSavedCallback): Added.
4275         (main): Support loading a JSON rule set file for content filtering.
4276         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4277         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4278         (WTF::derefGPtr): Ditto.
4279         (testEmptyStore):
4280         (testSaveInvalidFilter):
4281         (testSaveLoadFilter):
4282         (testSavedFilterIdentifierMatch):
4283         (testRemoveFilter):
4284         (testSaveMultipleFilters):
4285         (testSaveFilterFromFile):
4286         (testFilterPersistence):
4287         (beforeAll):
4288         (afterAll):
4289         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4290         (removeOldInjectedContentAndResetLists): Also reset content filters.
4291         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4292         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4293         the element affected by the style sheet.
4294         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4295         and returns it to be used by tests.
4296         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4297         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4298         (serverCallback): Add support for serving a CSS style sheet for testing.
4299         (beforeAll): Add call to testUserContentManagerContentFilter().
4300         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4301
4302 2019-02-19  Keith Rollin  <krollin@apple.com>
4303
4304         Add timing information to build output
4305         https://bugs.webkit.org/show_bug.cgi?id=194839
4306         <rdar://problem/48219609>
4307
4308         Reviewed by Alexey Proskuryakov.
4309
4310         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4311         emit each project's build time to its output. E.g.,
4312
4313             ** BUILD SUCCEEDED ** [0.132 sec]
4314
4315         * Scripts/webkitdirs.pm:
4316         (XcodeOptions):
4317
4318 2019-02-19  Truitt Savell  <tsavell@apple.com>
4319
4320         Unreviewed, rolling out r241784.
4321
4322         Broke all OpenSource builds.
4323
4324         Reverted changeset:
4325
4326         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4327         instances view"
4328         https://bugs.webkit.org/show_bug.cgi?id=172848
4329         https://trac.webkit.org/changeset/241784
4330
4331 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4332
4333         [LFC][Floats] Remove redundant intersecting logic
4334         https://bugs.webkit.org/show_bug.cgi?id=194804
4335
4336         Reviewed by Antti Koivisto.
4337
4338         * LayoutReloaded/misc/LFC-passing-tests.txt:
4339
4340 2019-02-19  Dean Jackson  <dino@apple.com>
4341
4342         Clean-up output from generate-xcfilelists so it can be filtered
4343         https://bugs.webkit.org/show_bug.cgi?id=194795
4344
4345         Reviewed by Joseph Pecoraro (and Keith Rollin).
4346
4347         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4348         make a slight tweak to filter-build-webkit so such lines are marked
4349         as plain.
4350
4351         * Scripts/filter-build-webkit:
4352         * Scripts/generate-xcfilelists:
4353
4354 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4355
4356         pytest is not correctly auto-installed
4357         https://bugs.webkit.org/show_bug.cgi?id=194707
4358
4359         Reviewed by Carlos Garcia Campos.
4360
4361         * Scripts/webkitpy/thirdparty/__init__.py:
4362         (AutoinstallImportHook._install_pytest):
4363
4364 2019-02-18  Chris Dumez  <cdumez@apple.com>
4365
4366         REGRESSION (PSON): Can't access optumbank.com from myuhc.com