Add support for parsing FairPlayStreaming PSSH boxes.
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-18  Jer Noble  <jer.noble@apple.com>
2
3         Add support for parsing FairPlayStreaming PSSH boxes.
4         https://bugs.webkit.org/show_bug.cgi?id=197064
5
6         Reviewed by Eric Carlson.
7
8         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
9         (TestWebKitAPI::TEST):
10
11 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
12
13         InjectedBundle parameters often need initialization function called before unarchiving
14         https://bugs.webkit.org/show_bug.cgi?id=189709
15         <rdar://problem/44573653>
16
17         Reviewed by Ryosuke Niwa.
18
19         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
20         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
21
22 2019-04-18  Zalan Bujtas  <zalan@apple.com>
23
24         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
25         https://bugs.webkit.org/show_bug.cgi?id=196948
26         <rdar://problem/49927131>
27
28         Reviewed by Tim Horton.
29
30         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
31         (TEST): 
32         The expected order of incoming events is
33         1. didInvalidateIntrinsicContentSize
34         2. didFirstLayout
35         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
36         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
37         (and remember, all we care about is ordering).
38
39 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
40
41         Unreviewed, rolling out r244299.
42
43         Breaks internal tests.
44
45         Reverted changeset:
46
47         "InjectedBundle parameters often need initialization function
48         called before unarchiving"
49         https://bugs.webkit.org/show_bug.cgi?id=189709
50         https://trac.webkit.org/changeset/244299
51
52 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
53
54         [WTF] StringBuilder should set correct m_is8Bit flag when merging
55         https://bugs.webkit.org/show_bug.cgi?id=197053
56
57         Reviewed by Saam Barati.
58
59         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
60         (TestWebKitAPI::TEST):
61
62 2019-04-17  Tim Horton  <timothy_horton@apple.com>
63
64         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
65         https://bugs.webkit.org/show_bug.cgi?id=197028
66         <rdar://problem/49985290>
67
68         Reviewed by Wenson Hsieh.
69
70         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
71         (TEST):
72         Liberal application of waitForNextPresentationUpdate works around a race
73         where if the page rapidly changes its viewport arguments (or an API client
74         rapidly changes its viewport arguments), we'd get stuck thinking that the
75         user had intentionally zoomed the page, and stop resetting the initial scale.
76         This deserves a separate bug, but no need to keep the test failing while
77         we think about it.
78
79 2019-04-17  Tim Horton  <timothy_horton@apple.com>
80
81         REGRESSION (r241988): Switching tabs is slow
82         https://bugs.webkit.org/show_bug.cgi?id=197037
83         <rdar://problem/49951473>
84
85         Reviewed by Simon Fraser.
86
87         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
88         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
89         (TEST):
90         * TestWebKitAPI/cocoa/TestWKWebView.h:
91         * TestWebKitAPI/cocoa/TestWKWebView.mm:
92         (-[TestWKWebView addToTestWindow]):
93         Add a test that hangs without this fix.
94
95 2019-04-17  Truitt Savell  <tsavell@apple.com>
96
97         Unreviewed, rolling out r244400.
98
99         Caused testing to exit early with assertionon Debug WK2
100
101         Reverted changeset:
102
103         "UI↔Web deadlock when printing with a JavaScript alert
104         visible"
105         https://bugs.webkit.org/show_bug.cgi?id=196839
106         https://trac.webkit.org/changeset/244400
107
108 2019-04-17  Brady Eidson  <beidson@apple.com>
109
110         Link clicks in PDFs shouldn't send referrer headers.
111         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
112
113         Reviewed by Tim Horton.
114
115         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
116         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
117         (putPDFBytesCallback):
118         (emptyReleaseInfoCallback):
119         (createPDFWithLinkToURL):
120         (TEST):
121
122 2019-04-17  Tim Horton  <timothy_horton@apple.com>
123
124         UI↔Web deadlock when printing with a JavaScript alert visible
125         https://bugs.webkit.org/show_bug.cgi?id=196839
126         <rdar://problem/49157642>
127
128         Reviewed by Andy Estes.
129
130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
131         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
132         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
133         (TEST):
134
135 2019-04-17  Alex Christensen  <achristensen@webkit.org>
136
137         WKRetainPtr's adoption constructor should be private
138         https://bugs.webkit.org/show_bug.cgi?id=197019
139
140         Reviewed by Tim Horton.
141
142         * DumpRenderTree/mac/DumpRenderTree.mm:
143         (dumpFramesAsText):
144         * TestWebKitAPI/InjectedBundleController.cpp:
145         (TestWebKitAPI::InjectedBundleController::initialize):
146         * TestWebKitAPI/PlatformUtilities.cpp:
147         (TestWebKitAPI::Util::createContextWithInjectedBundle):
148         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
149         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
150         (TestWebKitAPI::Util::toWK):
151         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
152         (TestWebKitAPI::TEST):
153         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
154         (TestWebKitAPI::TEST):
155         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
156         (TestWebKitAPI::TEST):
157         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
158         (TestWebKitAPI::TEST):
159         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
160         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
161         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
162         (TestWebKitAPI::TEST):
163         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
164         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
165         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
166         (TestWebKitAPI::TEST):
167         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
168         (TestWebKitAPI::TEST):
169         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
170         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
171         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
172         (TestWebKitAPI::TEST):
173         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
174         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
175         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
176         (TestWebKitAPI::TEST):
177         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
178         (TestWebKitAPI::TEST):
179         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
180         (TestWebKitAPI::TEST):
181         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
182         (TestWebKitAPI::TEST):
183         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
184         (TestWebKitAPI::TEST):
185         * TestWebKitAPI/Tests/WebKit/Find.cpp:
186         (TestWebKitAPI::TEST):
187         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
188         (TestWebKitAPI::TEST):
189         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
190         (TestWebKitAPI::TEST):
191         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
192         (TestWebKitAPI::TEST):
193         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
194         (TestWebKitAPI::TEST):
195         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
196         (TestWebKitAPI::TEST):
197         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
198         (TestWebKitAPI::TEST):
199         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
200         (TestWebKitAPI::TEST):
201         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
202         (TestWebKitAPI::TEST):
203         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
204         (TestWebKitAPI::TEST):
205         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
206         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
207         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
208         (TestWebKitAPI::TEST):
209         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
210         (TestWebKitAPI::TEST):
211         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
212         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
213         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
214         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
215         (TestWebKitAPI::TEST):
216         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
217         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
218         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
219         (TestWebKitAPI::TEST):
220         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
221         (TestWebKitAPI::TEST):
222         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
223         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
224         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
225         (TestWebKitAPI::TEST):
226         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
227         (TestWebKitAPI::loadAlternateHTMLString):
228         (TestWebKitAPI::TEST):
229         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
230         (TestWebKitAPI::TEST):
231         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
232         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
233         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
234         (TestWebKitAPI::buildAndPerformTest):
235         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
236         (TestWebKitAPI::TEST):
237         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
238         (TestWebKitAPI::TEST):
239         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
240         (TestWebKitAPI::TEST):
241         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
242         (TestWebKitAPI::TEST):
243         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
244         (TestWebKitAPI::TEST):
245         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
246         (TestWebKitAPI::TEST):
247         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
248         (TestWebKitAPI::TEST):
249         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
250         (TestWebKitAPI::TEST):
251         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
252         (TestWebKitAPI::TEST):
253         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
254         (TestWebKitAPI::TEST):
255         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
256         (TestWebKitAPI::TEST):
257         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
258         (TestWebKitAPI::TEST):
259         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
260         (TestWebKitAPI::TEST):
261         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
262         (TestWebKitAPI::TEST):
263         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
264         (TestWebKitAPI::TEST):
265         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
266         (TestWebKitAPI::TEST):
267         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
268         (TestWebKitAPI::TEST):
269         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
270         (TestWebKitAPI::TEST):
271         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
272         (TestWebKitAPI::TEST):
273         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
274         (TestWebKitAPI::TEST):
275         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
276         (TestWebKitAPI::TEST):
277         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
278         (TestWebKitAPI::TEST):
279         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
280         (TestWebKitAPI::TEST):
281         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
282         (TestWebKitAPI::TEST):
283         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
284         (TestWebKitAPI::TEST):
285         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
286         (TestWebKitAPI::TEST):
287         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
288         (TestWebKitAPI::TEST):
289         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
290         (TestWebKitAPI::TEST):
291         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
292         (TestWebKitAPI::TEST):
293         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
294         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
295         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
296         (TestWebKitAPI::TEST):
297         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
298         (TestWebKitAPI::TEST):
299         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
300         (TestWebKitAPI::TEST):
301         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
302         (TestWebKitAPI::TEST):
303         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
304         (TestWebKitAPI::TEST):
305         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
306         (TestWebKitAPI::TEST):
307         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
308         (TestWebKitAPI::TEST):
309         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
310         (TestWebKitAPI::TEST):
311         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
312         (TestWebKitAPI::TEST):
313         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
314         (TestWebKitAPI::TEST):
315         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
316         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
317         (TEST):
318         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
319         (TEST):
320         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
321         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
322         (TEST):
323         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
324         (TestWebKitAPI::TEST):
325         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
326         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
327         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
328         (WTR::getMenuItemTitleCallback):
329         (WTR::createMouseMessageBody):
330         (WTR::EventSendingController::mouseDown):
331         (WTR::EventSendingController::mouseUp):
332         (WTR::EventSendingController::mouseMoveTo):
333         (WTR::EventSendingController::mouseForceClick):
334         (WTR::EventSendingController::startAndCancelMouseForceClick):
335         (WTR::EventSendingController::mouseForceDown):
336         (WTR::EventSendingController::mouseForceUp):
337         (WTR::EventSendingController::mouseForceChanged):
338         (WTR::EventSendingController::leapForward):
339         (WTR::EventSendingController::scheduleAsynchronousClick):
340         (WTR::createKeyDownMessageBody):
341         (WTR::EventSendingController::keyDown):
342         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
343         (WTR::EventSendingController::mouseScrollBy):
344         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
345         (WTR::EventSendingController::continuousMouseScrollBy):
346         (WTR::EventSendingController::addTouchPoint):
347         (WTR::EventSendingController::updateTouchPoint):
348         (WTR::EventSendingController::setTouchModifier):
349         (WTR::EventSendingController::setTouchPointRadius):
350         (WTR::EventSendingController::touchStart):
351         (WTR::EventSendingController::touchMove):
352         (WTR::EventSendingController::touchEnd):
353         (WTR::EventSendingController::touchCancel):
354         (WTR::EventSendingController::clearTouchPoints):
355         (WTR::EventSendingController::releaseTouchPoint):
356         (WTR::EventSendingController::cancelTouchPoint):
357         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
358         (WTR::InjectedBundle::didCreatePage):
359         (WTR::InjectedBundle::didReceiveMessage):
360         (WTR::InjectedBundle::didReceiveMessageToPage):
361         (WTR::InjectedBundle::booleanForKey):
362         (WTR::InjectedBundle::done):
363         (WTR::InjectedBundle::dumpToStdErr):
364         (WTR::InjectedBundle::outputText):
365         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
366         (WTR::InjectedBundle::postAddChromeInputField):
367         (WTR::InjectedBundle::postRemoveChromeInputField):
368         (WTR::InjectedBundle::postFocusWebView):
369         (WTR::InjectedBundle::postSetBackingScaleFactor):
370         (WTR::InjectedBundle::postSetWindowIsKey):
371         (WTR::InjectedBundle::postSetViewSize):
372         (WTR::InjectedBundle::postSimulateWebNotificationClick):
373         (WTR::InjectedBundle::postSetAddsVisitedLinks):
374         (WTR::InjectedBundle::setGeolocationPermission):
375         (WTR::InjectedBundle::setMockGeolocationPosition):
376         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
377         (WTR::InjectedBundle::isGeolocationProviderActive const):
378         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
379         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
380         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
381         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
382         (WTR::InjectedBundle::setCustomPolicyDelegate):
383         (WTR::InjectedBundle::setHidden):
384         (WTR::InjectedBundle::setCacheModel):
385         (WTR::InjectedBundle::shouldProcessWorkQueue const):
386         (WTR::InjectedBundle::processWorkQueue):
387         (WTR::InjectedBundle::queueBackNavigation):
388         (WTR::InjectedBundle::queueForwardNavigation):
389         (WTR::InjectedBundle::queueLoad):
390         (WTR::InjectedBundle::queueLoadHTMLString):
391         (WTR::InjectedBundle::queueReload):
392         (WTR::InjectedBundle::queueLoadingScript):
393         (WTR::InjectedBundle::queueNonLoadingScript):
394         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
395         (WTR::frameToStr):
396         (WTR::InjectedBundlePage::InjectedBundlePage):
397         (WTR::dumpFrameDescriptionSuitableForTestResult):
398         (WTR::dumpFrameScrollPosition):
399         (WTR::dumpDescendantFrameScrollPositions):
400         (WTR::dumpFrameText):
401         (WTR::dumpDescendantFramesText):
402         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
403         (WTR::TestRunner::shouldDumpPixels const):
404         (WTR::TestRunner::setDumpPixels):
405         (WTR::TestRunner::whatToDump const):
406         (WTR::TestRunner::setWhatToDump):
407         (WTR::TestRunner::setWaitUntilDone):
408         (WTR::TestRunner::shouldWaitUntilDone const):
409         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
410         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
411         (WTR::TestRunner::clearAllDatabases):
412         (WTR::TestRunner::setIDBPerOriginQuota):
413         (WTR::TestRunner::originsWithApplicationCache):
414         (WTR::TestRunner::setCanOpenWindows):
415         (WTR::TestRunner::setXSSAuditorEnabled):
416         (WTR::TestRunner::setMediaDevicesEnabled):
417         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
418         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
419         (WTR::TestRunner::setCustomUserAgent):
420         (WTR::TestRunner::setWebAPIStatisticsEnabled):
421         (WTR::TestRunner::setModernMediaControlsEnabled):
422         (WTR::TestRunner::setWebGL2Enabled):
423         (WTR::TestRunner::setWritableStreamAPIEnabled):
424         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
425         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
426         (WTR::TestRunner::setAllowsAnySSLCertificate):
427         (WTR::TestRunner::setPluginsEnabled):
428         (WTR::TestRunner::setValueForUser):
429         (WTR::TestRunner::setAudioResult):
430         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
431         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
432         (WTR::TestRunner::setAlwaysAcceptCookies):
433         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
434         (WTR::TestRunner::isDoingMediaCapture const):
435         (WTR::TestRunner::queueLoad):
436         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
437         (WTR::TestRunner::setHandlesAuthenticationChallenges):
438         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
439         (WTR::TestRunner::setShouldLogDownloadCallbacks):
440         (WTR::TestRunner::setAuthenticationUsername):
441         (WTR::TestRunner::setAuthenticationPassword):
442         (WTR::TestRunner::secureEventInputIsEnabled const):
443         (WTR::TestRunner::setBlockAllPlugins):
444         (WTR::TestRunner::setPluginSupportedMode):
445         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
446         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
447         (WTR::TestRunner::setNavigationGesturesEnabled):
448         (WTR::TestRunner::setIgnoresViewportScaleLimits):
449         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
450         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
451         (WTR::TestRunner::terminateNetworkProcess):
452         (WTR::TestRunner::terminateServiceWorkerProcess):
453         (WTR::TestRunner::runUIScript):
454         (WTR::TestRunner::setStatisticsDebugMode):
455         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
456         (WTR::TestRunner::setStatisticsLastSeen):
457         (WTR::TestRunner::setStatisticsPrevalentResource):
458         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
459         (WTR::TestRunner::dumpResourceLoadStatistics):
460         (WTR::TestRunner::isStatisticsPrevalentResource):
461         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
462         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
463         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
464         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
465         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
466         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
467         (WTR::TestRunner::setStatisticsGrandfathered):
468         (WTR::TestRunner::isStatisticsGrandfathered):
469         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
470         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
471         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
472         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
473         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
474         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
475         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
476         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
477         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
478         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
479         (WTR::TestRunner::statisticsUpdateCookieBlocking):
480         (WTR::TestRunner::statisticsSubmitTelemetry):
481         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
482         (WTR::TestRunner::setStatisticsIsRunningTest):
483         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
484         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
485         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
486         (WTR::TestRunner::setStatisticsGrandfatheringTime):
487         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
488         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
489         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
490         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
491         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
492         (WTR::TestRunner::statisticsDeleteCookiesForHost):
493         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
494         (WTR::TestRunner::statisticsResetToConsistentState):
495         (WTR::TestRunner::setStorageAccessAPIEnabled):
496         (WTR::TestRunner::getAllStorageAccessEntries):
497         (WTR::TestRunner::addMockMediaDevice):
498         (WTR::TestRunner::clearMockMediaDevices):
499         (WTR::TestRunner::removeMockMediaDevice):
500         (WTR::TestRunner::resetMockMediaDevices):
501         (WTR::TestRunner::connectMockGamepad):
502         (WTR::TestRunner::disconnectMockGamepad):
503         (WTR::TestRunner::setMockGamepadDetails):
504         (WTR::TestRunner::setMockGamepadAxisValue):
505         (WTR::TestRunner::setMockGamepadButtonValue):
506         (WTR::TestRunner::removeAllSessionCredentials):
507         (WTR::TestRunner::clearDOMCache):
508         (WTR::TestRunner::clearDOMCaches):
509         (WTR::TestRunner::hasDOMCache):
510         (WTR::TestRunner::domCacheSize):
511         (WTR::TestRunner::setAllowStorageQuotaIncrease):
512         (WTR::TestRunner::getApplicationManifestThen):
513         (WTR::TestRunner::injectUserScript):
514         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
515         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
516         (WTR::TestRunner::addTestKeyToKeychain):
517         (WTR::TestRunner::cleanUpKeychain):
518         (WTR::TestRunner::keyExistsInKeychain):
519         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
520         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
521         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
522         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
523         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
524         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
525         * WebKitTestRunner/TestController.cpp:
526         (WTR::TestController::initialize):
527         (WTR::parseStringTestHeaderValueAsRelativePath):
528         (WTR::updateTestOptionsFromTestHeader):
529         (WTR::TestController::runTest):
530         (WTR::TestController::didReceiveLiveDocumentsList):
531         (WTR::TestController::didReceiveMessageFromInjectedBundle):
532         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
533         (WTR::TestController::didFinishNavigation):
534         (WTR::TestController::didReceiveAuthenticationChallenge):
535         * WebKitTestRunner/TestInvocation.cpp:
536         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
537         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
538         (WTR::TestInvocation::uiScriptDidComplete):
539         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
540         * WebKitTestRunner/WebNotificationProvider.cpp:
541         (WTR::WebNotificationProvider::closeWebNotification):
542         * WebKitTestRunner/WorkQueueManager.cpp:
543         (WTR::ScriptItem::ScriptItem):
544         (WTR::WorkQueueManager::queueLoad):
545         (WTR::WorkQueueManager::queueLoadHTMLString):
546
547 2019-04-17  Alex Christensen  <achristensen@webkit.org>
548
549         Add a comment to make my test from r244139 less mysterious.
550         https://bugs.webkit.org/show_bug.cgi?id=196744
551
552         As suggested by Darin Adler.
553
554         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
555         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
556
557 2019-04-17  Chris Dumez  <cdumez@apple.com>
558
559         Remember device orientation permission for the duration of the browsing session
560         https://bugs.webkit.org/show_bug.cgi?id=196992
561         <rdar://problem/49946067>
562
563         Reviewed by Alex Christensen.
564
565         Add API test coverage.
566
567         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
568         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
569         (TEST):
570
571 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
572
573         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
574         https://bugs.webkit.org/show_bug.cgi?id=196675
575
576         Reviewed by Lucas Forschler.
577
578         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
579         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
580
581 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
582
583         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
584         https://bugs.webkit.org/show_bug.cgi?id=196919
585         <rdar://problem/41630459>
586
587         Reviewed by Tim Horton.
588
589         Add iOS support for several new testing hooks. See below for more detail.
590
591         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
592         (WTR::UIScriptController::isDismissingMenu const):
593
594         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
595         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
596         by UIKit when dismissing the callout bar (i.e. UIMenuController).
597
598         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
599         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
600         (WTR::UIScriptController::isDismissingMenu const):
601         * TestRunnerShared/UIScriptContext/UIScriptController.h:
602         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
603         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
604         (WTR::InjectedBundle::didReceiveMessageToPage):
605         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
606         (WTR::TestRunner::setAllowedMenuActions):
607
608         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
609         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
610         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
611         against the name of the custom action.
612
613         (WTR::TestRunner::installCustomMenuAction):
614
615         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
616         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
617         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
618         triggered.
619
620         (WTR::TestRunner::performCustomMenuAction):
621
622         Invoked when the custom menu action is triggered.
623
624         * WebKitTestRunner/InjectedBundle/TestRunner.h:
625         * WebKitTestRunner/TestController.cpp:
626         (WTR::TestController::installCustomMenuAction):
627         (WTR::TestController::setAllowedMenuActions):
628         * WebKitTestRunner/TestController.h:
629         * WebKitTestRunner/TestInvocation.cpp:
630         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
631         (WTR::TestInvocation::performCustomMenuAction):
632
633         Add plumbing to call back into the injected bundle when performing the custom action.
634
635         * WebKitTestRunner/TestInvocation.h:
636         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
637         (WTR::TestController::installCustomMenuAction):
638         (WTR::TestController::setAllowedMenuActions):
639         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
640         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
641         (-[TestRunnerWKWebView initWithFrame:configuration:]):
642         (-[TestRunnerWKWebView becomeFirstResponder]):
643         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
644
645         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
646         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
647         in the Mail app on iOS.
648
649         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
650         (-[TestRunnerWKWebView setAllowedMenuActions:]):
651         (-[TestRunnerWKWebView resetCustomMenuAction]):
652         (-[TestRunnerWKWebView performCustomAction:]):
653         (-[TestRunnerWKWebView canPerformAction:withSender:]):
654         (-[TestRunnerWKWebView _willHideMenu]):
655         (-[TestRunnerWKWebView _didHideMenu]):
656         * WebKitTestRunner/ios/TestControllerIOS.mm:
657         (WTR::TestController::platformResetStateToConsistentValues):
658
659         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
660         if specified.
661
662         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
663         (WTR::UIScriptController::isDismissingMenu const):
664
665 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
666
667         Allow sharing from imageSheet on an image document
668         https://bugs.webkit.org/show_bug.cgi?id=196891
669         <rdar://problem/25377386>
670
671         Reviewed by Tim Horton.
672
673         Test to make sure that the correct imageURL is extracted from an image element.
674
675         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
676         (TestWebKitAPI::TEST):
677
678 2019-04-16  Alex Christensen  <achristensen@webkit.org>
679
680         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
681         https://bugs.webkit.org/show_bug.cgi?id=196995
682
683         Reviewed by Brady Eidson.
684
685         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
686         (TEST):
687
688 2019-04-16  Chris Dumez  <cdumez@apple.com>
689
690         URL set by document.open() is not communicated to the UIProcess
691         https://bugs.webkit.org/show_bug.cgi?id=196941
692         <rdar://problem/49237544>
693
694         Reviewed by Geoff Garen.
695
696         Add API test coverage.
697
698         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
699         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
700         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
701         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
702         (TEST):
703
704 2019-04-16  Commit Queue  <commit-queue@webkit.org>
705
706         Unreviewed, rolling out r244321.
707         https://bugs.webkit.org/show_bug.cgi?id=196968
708
709         Causing all WK2 Debug builds to exit early after Assertion
710         failures. (Requested by ShawnRoberts on #webkit).
711
712         Reverted changeset:
713
714         "URL set by document.open() is not communicated to the
715         UIProcess"
716         https://bugs.webkit.org/show_bug.cgi?id=196941
717         https://trac.webkit.org/changeset/244321
718
719 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
720
721         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
722         https://bugs.webkit.org/show_bug.cgi?id=196948
723
724         Reviewed by Zalan Bujtas.
725
726         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
727         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
728
729 2019-04-15  Chris Dumez  <cdumez@apple.com>
730
731         URL set by document.open() is not communicated to the UIProcess
732         https://bugs.webkit.org/show_bug.cgi?id=196941
733         <rdar://problem/49237544>
734
735         Reviewed by Geoffrey Garen.
736
737         Add API test coverage.
738
739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
740         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
741         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
742         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
743         (TEST):
744
745 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
746
747         Using Tools/Scripts/clean-webkit should not install requests
748         https://bugs.webkit.org/show_bug.cgi?id=196940
749
750         Reviewed by Lucas Forschler.
751
752         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
753         existing, depending on the path autoinstalled is run through.
754         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
755         needed.
756         (Port.configuration_for_upload):
757         (Port.commits_for_upload):
758
759 2019-04-15  Alex Christensen  <achristensen@webkit.org>
760
761         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
762         https://bugs.webkit.org/show_bug.cgi?id=196773
763
764         Reviewed by Jer Noble.
765
766         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
767         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
768         (TEST):
769
770 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
771
772         ews-build should clearly indicate flaky test failures
773         https://bugs.webkit.org/show_bug.cgi?id=196947
774
775         Reviewed by Lucas Forschler.
776
777         * BuildSlaveSupport/ews-build/steps.py:
778         (AnalyzeAPITestsResults.analyzeResults):
779
780 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
781
782         InjectedBundle parameters often need initialization function called before unarchiving
783         https://bugs.webkit.org/show_bug.cgi?id=189709
784         <rdar://problem/44573653>
785
786         Reviewed by Ryosuke Niwa.
787
788         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
789         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
790
791 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
792
793         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
794         https://bugs.webkit.org/show_bug.cgi?id=196681
795
796         Reviewed by Darin Adler.
797
798         Added tests.
799
800         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
801         (WTF_HashSet.RemoveIf):
802         (WTF_HashSet.RemoveIfShrinkToBestSize):
803
804 2019-04-15  John Wilander  <wilander@apple.com>
805
806         Send delayed Ad Click Attribution conversion requests to the click source
807         https://bugs.webkit.org/show_bug.cgi?id=196838
808         <rdar://problem/47650157>
809
810         Reviewed by Chris Dumez and Youenn Fablet.
811
812         This patch adds test infrastructure to override the default behavior in
813         WebKit::NetworkAdClickAttribution.
814
815         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
816         (TestWebKitAPI::TEST):
817         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
818         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
819         (WTR::TestRunner::dumpAdClickAttribution):
820         (WTR::TestRunner::clearAdClickAttribution):
821         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
822         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
823         * WebKitTestRunner/InjectedBundle/TestRunner.h:
824         * WebKitTestRunner/TestController.cpp:
825         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
826         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
827         * WebKitTestRunner/TestController.h:
828         * WebKitTestRunner/TestInvocation.cpp:
829         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
830
831 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
832
833         [ews-app] status-bubble should display position in queue
834         https://bugs.webkit.org/show_bug.cgi?id=196607
835
836         Reviewed by Lucas Forschler.
837
838         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
839         (StatusBubble._build_bubble):
840         (StatusBubble._queue_position): Method to calculate patch's position in queue.
841
842 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
843
844         [ews-build] Do not run clean build by default on EWS builders
845         https://bugs.webkit.org/show_bug.cgi?id=196897
846
847         Reviewed by Lucas Forschler.
848
849         * BuildSlaveSupport/ews-build/steps.py:
850         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
851         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
852         untracked directories like WebKitBuild).
853         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
854         untracked files/directories (like WebKitBuild).
855
856 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
857
858         TestRunner::notifyDone() should be safely reentrant
859         https://bugs.webkit.org/show_bug.cgi?id=196898
860
861         Reviewed by Darin Adler.
862
863         It is currently possible that TestRunner::notifyDone() will call itself, since
864         notifyDone() will force a repaint, which can start executing JavaScript, which
865         may call notifyDone() again. This can lead to test failures and flakiness.
866         Fix this by setting the m_waitToDump flag before calling the dump() method.
867
868         * DumpRenderTree/mac/TestRunnerMac.mm:
869         (TestRunner::notifyDone):
870         (TestRunner::forceImmediateCompletion):
871         * DumpRenderTree/win/TestRunnerWin.cpp:
872         (TestRunner::notifyDone):
873         (TestRunner::forceImmediateCompletion):
874
875 2019-04-15  Philippe Normand  <pnormand@igalia.com>
876
877         [GTK][WPE] Add enable-media websetting
878         https://bugs.webkit.org/show_bug.cgi?id=196863
879
880         Reviewed by Michael Catanzaro.
881
882         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
883         (testWebKitSettings): Add test for the enable-media web-setting.
884
885 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
886
887         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
888         https://bugs.webkit.org/show_bug.cgi?id=196905
889         <rdar://problem/49886096>
890
891         Reviewed by Tim Horton.
892
893         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
894         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
895         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
896         delay timer, we end up with this sequence of events in the problematic (failure) case:
897
898         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
899             ...IPC from UI to web process...
900         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
901             ...IPC from web to UI process...
902         (c) [UI]    Invoke completion handler for script #1
903         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
904             ...IPC from UI to web process...
905         (e) [Web]   Evaluate script #2 in the web process
906         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
907
908         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
909         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
910         #2 is run in step (e).
911
912         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
913         the UI process by waiting on a script message posted by the web process, after attachment updates are
914         dispatched.
915
916         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
917         (TestWebKitAPI::TEST):
918
919 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
920
921         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
922         https://bugs.webkit.org/show_bug.cgi?id=196909
923
924         Reviewed by Wenson Hsieh.
925
926         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
927         (TestWebKitAPI::TEST):
928
929 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
930
931         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
932         https://bugs.webkit.org/show_bug.cgi?id=196880
933
934         Reviewed by Yusuke Suzuki.
935
936         Add a new function for bytecode cache tests that does not forceDiskCache
937         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
938         test added in this patch, since the code is invalid and therefore won't be
939         cached. It should also be useful for tests that evaluate dynamically
940         generated code.
941
942         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
943         * Scripts/run-jsc-stress-tests:
944
945 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
946
947         Update AudioSession route sharing policy
948         https://bugs.webkit.org/show_bug.cgi?id=196776
949         <rdar://problem/46501611>
950
951         Reviewed by Jer Noble.
952
953         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
954         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
955         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
956         (TestWebKitAPI::TEST):
957
958 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
959
960         [iOS] Software keyboard is shown too frequently on some websites
961         https://bugs.webkit.org/show_bug.cgi?id=195856
962         <rdar://problem/49191395>
963
964         Reviewed by Darin Adler.
965
966         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
967
968         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
969         (WTR::UIScriptController::setHardwareKeyboardAttached):
970         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
971         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
972         (WTR::UIScriptController::setHardwareKeyboardAttached):
973         * TestRunnerShared/UIScriptContext/UIScriptController.h:
974         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
975
976         Additionally link against GraphicsServices in WebKitTestRunner.
977
978         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
979         (WTR::TestController::platformResetStateToConsistentValues):
980         (WTR::UIScriptController::setHardwareKeyboardAttached):
981
982 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
983
984         [GTK][WPE] Fix pacman install-dependencies packages
985         https://bugs.webkit.org/show_bug.cgi?id=196817
986
987         Reviewed by Žan Doberšek.
988         
989         python3-setuptools is called python-setuptools
990         ruby-highline is only available on AUR
991         libv4l-devel is incorporated in v4l-utils
992
993         * gtk/install-dependencies:
994         * wpe/install-dependencies:
995
996 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
997
998         [GTK] REGRESSION(r243860): Many tests failing
999         https://bugs.webkit.org/show_bug.cgi?id=196791
1000
1001         Reviewed by Joanmarie Diggs.
1002
1003         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1004         multiple documents and check that accessibility hierarchy is updated after a navigation.
1005
1006         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1007         (loadChangedCallback):
1008         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1009         (AccessibilityTest::AccessibilityTest):
1010         (AccessibilityTest::~AccessibilityTest):
1011         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1012         (AccessibilityTest::findTestServerApplication):
1013         (AccessibilityTest::findDocumentWeb):
1014         (AccessibilityTest::findRootObject):
1015         (AccessibilityTest::waitUntilChildrenRemoved):
1016         (AccessibilityTest::ensureProxy):
1017         (testAtspiBasicHierarchy):
1018         (beforeAll):
1019         (afterAll):
1020
1021 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1022
1023         [ews-build] Handle bug titles with unicode characters
1024         https://bugs.webkit.org/show_bug.cgi?id=196802
1025
1026         Reviewed by Dewei Zhu.
1027
1028         * BuildSlaveSupport/ews-build/steps.py:
1029         (ValidatePatch._is_bug_closed):
1030
1031 2019-04-11  Michael Saboff  <msaboff@apple.com>
1032
1033         Improve the Inline Cache Stats code
1034         https://bugs.webkit.org/show_bug.cgi?id=196836
1035
1036         Reviewed by Saam Barati.
1037
1038         Added a new script to consolidate and arrange the output of --useICStats option.
1039
1040         This script merges the output from every group into one large table and sorts it from most common to
1041         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1042         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1043         Put together, this is useful to see what property accesses are not getting cached.
1044
1045         * Scripts/ic-stats.py: Added.
1046         (ICStats):
1047         (ICStats.__init__):
1048         (ICStats.parse):
1049         (ICStats.dumpStats):
1050         (usage):
1051
1052 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1053
1054         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1055         https://bugs.webkit.org/show_bug.cgi?id=196809
1056         <rdar://49800762>
1057
1058         Reviewed by Brady Eidson.
1059
1060         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1061         (TEST):
1062
1063 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1064
1065         requestAnimationFrame should execute before the next frame
1066         https://bugs.webkit.org/show_bug.cgi?id=177484
1067
1068         Reviewed by Simon Fraser.
1069
1070         Add trace points for the page RenderingUpdate.
1071
1072         * Tracing/SystemTracePoints.plist:
1073
1074 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1075
1076         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1077         https://bugs.webkit.org/show_bug.cgi?id=196760
1078
1079         Reviewed by Don Olmstead.
1080
1081         vswhere.exe has been bundled since Visual Studio 2017 version
1082         15.2. We shouldn't download vswhere.exe.
1083
1084         * Scripts/build-jsc: Do not call update-vswhere.py.
1085         * Scripts/build-webkit: Ditto.
1086         * Scripts/update-vswhere.py: Removed.
1087         * Scripts/webkitdirs.pm:
1088         (requireModulesForVSWhere): Deleted.
1089         (pickCurrentVisualStudioInstallation): Deleted.
1090         (visualStudioInstallDirVSWhere): Return the latest installed VS
1091         installation path by using the bundled vswhere.exe.
1092         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1093         (visualStudioInstallDirFallback): Removed.
1094
1095 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1096
1097         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1098         https://bugs.webkit.org/show_bug.cgi?id=196780
1099
1100         Reviewed by Alexey Proskuryakov.
1101
1102         * BuildSlaveSupport/ews-build/steps.py:
1103         * BuildSlaveSupport/ews-build/steps_unittest.py:
1104
1105 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1106
1107         Add SPI WKNavigationResponse._downloadAttribute
1108         https://bugs.webkit.org/show_bug.cgi?id=196755
1109         <rdar://49587365>
1110
1111         Reviewed by Brady Eidson.
1112
1113         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1114         (-[NavigationResponseTestDelegate navigationResponse]):
1115         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1116         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1117         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1118         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1119         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1120         (readRequest):
1121         (writeResponse):
1122         (TEST):
1123
1124 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1125
1126         Add modern API for overriding the page's specified viewport configuration
1127         https://bugs.webkit.org/show_bug.cgi?id=167734
1128         <rdar://problem/30331795>
1129
1130         Reviewed by Simon Fraser.
1131
1132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1133         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1134
1135 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1136
1137         Add support for incremental bytecode cache updates
1138         https://bugs.webkit.org/show_bug.cgi?id=195000
1139
1140         Reviewed by Filip Pizlo.
1141
1142         Exit when the initial run to generate bytecode fails.
1143
1144         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1145
1146 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1147
1148         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1149         https://bugs.webkit.org/show_bug.cgi?id=196744
1150         <rdar://49415309>
1151
1152         Reviewed by Chris Dumez.
1153
1154         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1155         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1156
1157 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1158
1159         Add a way to opt into modern compatibility mode in layout tests
1160         https://bugs.webkit.org/show_bug.cgi?id=196770
1161         <rdar://problem/49777550>
1162
1163         Reviewed by Antoine Quint.
1164
1165         Add a new test option to enable modern compatibility mode in layout tests.
1166
1167         * WebKitTestRunner/TestController.cpp:
1168         (WTR::updateTestOptionsFromTestHeader):
1169         * WebKitTestRunner/TestController.h:
1170         * WebKitTestRunner/TestOptions.h:
1171         (WTR::TestOptions::hasSameInitializationOptions const):
1172         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1173         (WTR::TestController::platformCreateWebView):
1174         (WTR::TestController::enableModernCompatibilityMode):
1175
1176 2019-04-10  Andy Estes  <aestes@apple.com>
1177
1178         Try to fix the 32-bit watchOS build.
1179
1180         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1181         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1182
1183 2019-04-10  Antoine Quint  <graouts@apple.com>
1184
1185         Enable Pointer Events on watchOS
1186         https://bugs.webkit.org/show_bug.cgi?id=196771
1187         <rdar://problem/49040909>
1188
1189         Reviewed by Dean Jackson.
1190
1191         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1192
1193 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1194
1195         Unreviewed. Fix WPE accessibility tests after r244059.
1196
1197         We are failing to load the injected bundle due to undefined symbol
1198         AccessibilityUIElement::replaceTextInRange().
1199
1200         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1201         (WTR::AccessibilityUIElement::replaceTextInRange):
1202
1203 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1204
1205         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1206         https://bugs.webkit.org/show_bug.cgi?id=196727
1207
1208         Reviewed by Fujii Hironori.
1209
1210         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1211         (WebKitBrowserWindow::create):
1212
1213 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1214
1215         [ews-build] Add unit tests for PrintConfiguration
1216         https://bugs.webkit.org/show_bug.cgi?id=196752
1217
1218         Reviewed by Dewei Zhu.
1219
1220         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1221
1222 2019-04-09  Keith Rollin  <krollin@apple.com>
1223
1224         Unreviewed build maintenance -- update .xcfilelists.
1225
1226         * DumpRenderTree/DerivedSources-input.xcfilelist:
1227         * DumpRenderTree/DerivedSources-output.xcfilelist:
1228
1229 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1230
1231         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1232         https://bugs.webkit.org/show_bug.cgi?id=196743
1233         <rdar://problem/43897551>
1234
1235         Reviewed by Tim Horton.
1236
1237         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1238         (TEST):
1239
1240 2019-04-09  Youenn Fablet  <youenn@apple.com>
1241
1242         Close service worker database on network process suspension
1243         https://bugs.webkit.org/show_bug.cgi?id=196623
1244         <rdar://problem/48930869>
1245
1246         Reviewed by Alex Christensen.
1247
1248         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1249
1250 2019-04-09  Daniel Bates  <dabates@apple.com>
1251
1252         [iPad] Should open popover when the spacebar is pressed
1253         https://bugs.webkit.org/show_bug.cgi?id=196360
1254         <rdar://problem/49389129>
1255
1256         Reviewed by Brent Fulgham.
1257
1258         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1259
1260         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1261         (WTR::UIScriptController::isShowingPopover const): Added.
1262         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1263         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1264         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1265         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1266         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1267         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1268         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1269         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1270         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1271         (WTR::UIScriptController::isShowingPopover const): Added.
1272         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1273         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1274         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1275         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1276         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1277         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1278         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1279         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1280         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1281         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1282         (WTR::UIScriptController::isShowingPopover const): Added.
1283         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1284         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1285
1286 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1287
1288         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1289         https://bugs.webkit.org/show_bug.cgi?id=196665
1290         <rdar://45115669>
1291
1292         Reviewed by Geoff Garen.
1293
1294         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1295         (goBack):
1296         (+[SimpleLookupContext sharedLookupContext]):
1297         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1298         (TEST):
1299         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1300         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1301
1302 2019-04-09  John Wilander  <wilander@apple.com>
1303
1304         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1305         https://bugs.webkit.org/show_bug.cgi?id=196558
1306         <rdar://problem/47650245>
1307
1308         Reviewed by Youenn Fablet.
1309
1310         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1311         (TestWebKitAPI::TEST):
1312             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1313
1314 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1315
1316         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1317         https://bugs.webkit.org/show_bug.cgi?id=196720
1318
1319         Reviewed by Konstantin Tokarev.
1320
1321         * TestWebKitAPI/PlatformMac.cmake:
1322
1323 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1324
1325         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1326         https://bugs.webkit.org/show_bug.cgi?id=196694
1327         <rdar://problem/48388734>
1328
1329         Rubber-stamped by Aakash Jain.
1330
1331         * Scripts/webkitpy/port/image_diff.py:
1332         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1333         * Scripts/webkitpy/port/server_process.py:
1334         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1335         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1336         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1337         * Scripts/webkitpy/port/server_process_mock.py:
1338         (MockServerProcess.has_available_stdout):
1339         * Scripts/webkitpy/port/server_process_unittest.py:
1340         (TestServerProcess.serial_test_basic):
1341
1342 2019-04-09  Jer Noble  <jer.noble@apple.com>
1343
1344         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1345         https://bugs.webkit.org/show_bug.cgi?id=196097
1346
1347         Reviewed by Eric Carlson.
1348
1349         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1350
1351         * DumpRenderTree/mac/DumpRenderTree.mm:
1352         (resetWebPreferencesToConsistentValues):
1353         * WebKitTestRunner/TestController.cpp:
1354         (WTR::TestController::resetPreferencesToConsistentValues):
1355
1356 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1357
1358         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1359         https://bugs.webkit.org/show_bug.cgi?id=196690
1360
1361         Reviewed by Michael Catanzaro.
1362
1363         * QueueStatusServer/config/queues.py:
1364         * Scripts/webkitpy/common/config/ews.json:
1365         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1366         (test_ews_name):
1367
1368 2019-04-09  Chris Dumez  <cdumez@apple.com>
1369
1370         Loads using loadHTMLString() cause flashing when process-swapping
1371         https://bugs.webkit.org/show_bug.cgi?id=196714
1372         <rdar://problem/49637354>
1373
1374         Reviewed by Antti Koivisto.
1375
1376         Add API test coverage.
1377
1378         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1379
1380 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1381
1382         Unreviewed. Fix ATK accessibility tests after r244059.
1383
1384         We are failing to load the injected bundle due to undefined symbol
1385         AccessibilityUIElement::replaceTextInRange().
1386
1387         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1388         (WTR::AccessibilityUIElement::replaceTextInRange):
1389
1390 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1391
1392         AX: Support API: accessibilityReplaceRange:withText
1393         https://bugs.webkit.org/show_bug.cgi?id=196636
1394
1395         Unreviewed build fix for Windows port.
1396
1397         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1398         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1399
1400 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1401
1402         [CMake][WinCairo] Separate copied headers into different directories
1403         https://bugs.webkit.org/show_bug.cgi?id=196655
1404
1405         Reviewed by Michael Catanzaro.
1406
1407         * DumpRenderTree/CMakeLists.txt:
1408         * MiniBrowser/win/CMakeLists.txt:
1409         * TestWebKitAPI/CMakeLists.txt:
1410         * TestWebKitAPI/PlatformWin.cmake:
1411
1412 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1413
1414         Log stack-trace for run-webkit-tests when interrupted
1415         https://bugs.webkit.org/show_bug.cgi?id=176393
1416         <rdar://problem/34262310>
1417
1418         Reviewed by Lucas Forschler.
1419
1420         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1421         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1422         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1423         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1424         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1425         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1426         (main): Set handlers to log stack trace on interruption.
1427
1428 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1429
1430         AX: Support API: accessibilityReplaceRange:withText
1431         https://bugs.webkit.org/show_bug.cgi?id=196636
1432
1433         Unreviewed build fix for Windows port.
1434
1435         * DumpRenderTree/AccessibilityUIElement.cpp:
1436         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1437
1438 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1439
1440         [ews-build] Scripts using Buildbot API have CORS error
1441         https://bugs.webkit.org/show_bug.cgi?id=196709
1442
1443         Reviewed by Alexey Proskuryakov.
1444
1445         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1446
1447 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1448
1449         AX: Support API: accessibilityReplaceRange:withText
1450         https://bugs.webkit.org/show_bug.cgi?id=196636
1451
1452         Reviewed by Daniel Bates.
1453
1454         * DumpRenderTree/AccessibilityUIElement.cpp:
1455         (replaceTextInRangeCallback):
1456         (AccessibilityUIElement::replaceTextInRange):
1457         (AccessibilityUIElement::getJSClass):
1458         * DumpRenderTree/AccessibilityUIElement.h:
1459         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1460         (AccessibilityUIElement::replaceTextInRange):
1461         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1462         (AccessibilityUIElement::replaceTextInRange):
1463         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1464         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1465         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1466         (WTR::AccessibilityUIElement::replaceTextInRange):
1467         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1468         (WTR::AccessibilityUIElement::replaceTextInRange):
1469
1470 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1471
1472         [iOS] Do not allow starting selection drags when selection views are not visible
1473         https://bugs.webkit.org/show_bug.cgi?id=196686
1474         <rdar://problem/49399192>
1475
1476         Reviewed by Tim Horton.
1477
1478         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1479         also add some new API tests to cover scenarios where the web view is not first responder.
1480
1481         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1482         (TestWebKitAPI::TEST):
1483         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1484
1485         Add a switch to optionally make the web view first responder when starting the simulated drag.
1486
1487         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1488         (-[DragAndDropSimulator initWithWebView:]):
1489         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1490
1491 2019-04-08  Justin Fan  <justin_fan@apple.com>
1492
1493         [Web GPU] Fix Web GPU experimental feature on iOS
1494         https://bugs.webkit.org/show_bug.cgi?id=196632
1495
1496         Reviewed by Myles C. Maxfield.
1497
1498         Properly make Web GPU available on iOS 11+.
1499
1500         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1501
1502 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1503
1504         [ews-build] Do not upload archive when Compile Fails
1505         https://bugs.webkit.org/show_bug.cgi?id=196674
1506
1507         Reviewed by Alexey Proskuryakov.
1508
1509         * BuildSlaveSupport/ews-build/factories.py:
1510         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1511         * BuildSlaveSupport/ews-build/steps.py:
1512         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1513         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1514         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1515
1516 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1517
1518         Enable DFG on MIPS
1519         https://bugs.webkit.org/show_bug.cgi?id=196689
1520
1521         Reviewed by Žan Doberšek.
1522
1523         Since the bytecode change, we enabled the baseline JIT on mips in
1524         r240432, but DFG is still missing. With this change, all tests are
1525         passing on a ci20 board.
1526
1527         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1528
1529 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1530
1531         [Flatpak] Second run update-webkitwpe-flatpak fails
1532         https://bugs.webkit.org/show_bug.cgi?id=192702
1533
1534         Reviewed by Carlos Garcia Campos.
1535
1536         * flatpak/flatpakutils.py:
1537         (FlatpakObject.flatpak): Fix typo.
1538         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1539         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1540
1541 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1542
1543         [GTK][WPE] outlook.live.com displays old-fashioned UI
1544         https://bugs.webkit.org/show_bug.cgi?id=196642
1545
1546         Reviewed by Carlos Garcia Campos.
1547
1548         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1549         (TestWebKitAPI::TEST): New Mac platform quirk test.
1550
1551 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1552
1553         Unreviewed, rolling out r243956.
1554         https://bugs.webkit.org/show_bug.cgi?id=196688
1555
1556         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1557         by aakashjain on #webkit).
1558
1559         Reverted changeset:
1560
1561         "Clicking "Go Back" from a safe browsing warning from an
1562         iframe should navigate the WKWebView back to the previous
1563         page"
1564         https://bugs.webkit.org/show_bug.cgi?id=196665
1565         https://trac.webkit.org/changeset/243956
1566
1567 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1568
1569         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1570         https://bugs.webkit.org/show_bug.cgi?id=196669
1571
1572         Reviewed by Geoffrey Garen.
1573
1574         Added three new unit tests for WeakHashSet.
1575
1576         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1577         (WTF_WeakPtr.WeakHashSetConstObjects):
1578         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1579         (WTF_WeakPtr.WeakHashSetComputeSize):
1580
1581 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1582
1583         Hide next and previous form control buttons when WKWebView is editable
1584         https://bugs.webkit.org/show_bug.cgi?id=196672
1585         <rdar://problem/35625321>
1586
1587         Reviewed by Tim Horton.
1588
1589         Add a new API test.
1590
1591         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1592         (-[TestWKWebView lastTrailingBarButtonGroup]):
1593         (TestWebKitAPI::TEST):
1594         * TestWebKitAPI/ios/UIKitSPI.h:
1595
1596 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1597
1598         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1599         https://bugs.webkit.org/show_bug.cgi?id=196077
1600         <rdar://problem/49108202>
1601
1602         Reviewed by Chris Dumez.
1603
1604         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1605         on new web view.
1606
1607         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1608
1609 2019-04-05  Saam Barati  <sbarati@apple.com>
1610
1611         Make compare-results understand MotionMark
1612         https://bugs.webkit.org/show_bug.cgi?id=196666
1613
1614         Reviewed by Yusuke Suzuki.
1615
1616         * Scripts/compare-results:
1617         (PLT5Results):
1618         (detectMotionMark):
1619         (detectMotionMark1_1):
1620         (motionMarkResults):
1621         (motionMark1_1Results):
1622         (detectBenchmark):
1623         (biggerIsBetter):
1624         (main):
1625
1626 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1627
1628         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1629         https://bugs.webkit.org/show_bug.cgi?id=196665
1630         <rdar://45115669>
1631
1632         Reviewed by Geoff Garen.
1633
1634         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1635         (goBack):
1636         (+[SimpleLookupContext sharedLookupContext]):
1637         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1638         (TEST):
1639         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1640         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1641
1642 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1643
1644         [ews-build] Add configuration and architecture for windows builders
1645         https://bugs.webkit.org/show_bug.cgi?id=196660
1646
1647         Reviewed by Lucas Forschler.
1648
1649         * BuildSlaveSupport/ews-build/config.json:
1650
1651 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1652
1653         webkitpy: Don't run subsequent rounds if interrupted
1654         https://bugs.webkit.org/show_bug.cgi?id=196646
1655
1656         Reviewed by Aakash Jain.
1657
1658         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1659         (Manager.run): Bail out if interrupted.
1660
1661 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1662
1663         Test sessionStorage in PSON private browsing mode
1664         https://bugs.webkit.org/show_bug.cgi?id=196561
1665
1666         Reviewed by Alex Christensen.
1667
1668         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1669
1670 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1671
1672         Unreviewed, rolling out r243833.
1673         https://bugs.webkit.org/show_bug.cgi?id=196645
1674
1675         This change breaks build of WPE and GTK ports (Requested by
1676         annulen on #webkit).
1677
1678         Reverted changeset:
1679
1680         "[CMake][WTF] Mirror XCode header directories"
1681         https://bugs.webkit.org/show_bug.cgi?id=191662
1682         https://trac.webkit.org/changeset/243833
1683
1684 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1685
1686         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1687         https://bugs.webkit.org/show_bug.cgi?id=196635
1688
1689         Reviewed by Antti Koivisto.
1690         
1691         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1692         for a test to enable async frame scrolling via:
1693             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1694         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1695         
1696         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1697
1698         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1699         (WTR::InjectedBundle::beginTesting):
1700         * WebKitTestRunner/TestController.cpp:
1701         (WTR::TestController::resetPreferencesToConsistentValues):
1702
1703 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1704
1705         Use a correct LC_RPATH when building with ASan
1706         https://bugs.webkit.org/show_bug.cgi?id=196576
1707
1708         Reviewed by David Kilzer.
1709
1710         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1711         so that ../Frameworks is checked. This is simpler and more reliable than updating
1712         each SPC service xcconfig.
1713
1714 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1715
1716         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1717         https://bugs.webkit.org/show_bug.cgi?id=196629
1718
1719         Reviewed by Lucas Forschler.
1720
1721         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1722
1723 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1724
1725         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1726         https://bugs.webkit.org/show_bug.cgi?id=196618
1727
1728         Reviewed by Lucas Forschler.
1729
1730         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1731         (StatusBubble): Added QUEUE_TRIGGERS.
1732         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1733         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1734         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1735         its parent(builder).
1736
1737 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1738
1739         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1740         https://bugs.webkit.org/show_bug.cgi?id=196625
1741
1742         Reviewed by Lucas Forschler.
1743
1744         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1745         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1746
1747 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1748
1749         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1750         https://bugs.webkit.org/show_bug.cgi?id=196630
1751
1752         Reviewed by Wenson Hsieh.
1753
1754         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1755
1756 2019-04-04  Youenn Fablet  <youenn@apple.com>
1757
1758         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1759         https://bugs.webkit.org/show_bug.cgi?id=196543
1760
1761         Reviewed by Alex Christensen.
1762
1763         * WebKitTestRunner/TestController.cpp:
1764         (WTR::TestController::generatePageConfiguration):
1765
1766 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1767
1768         [ews-app] Status bubble should not display skipped buildbot steps
1769         https://bugs.webkit.org/show_bug.cgi?id=196584
1770
1771         Reviewed by Lucas Forschler.
1772
1773         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1774
1775 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1776
1777         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1778         https://bugs.webkit.org/show_bug.cgi?id=196620
1779
1780         Reviewed by Lucas Forschler.
1781
1782         * BuildSlaveSupport/ews-app/ews/config.py:
1783
1784 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1785
1786         [Win] DumpRenderTreeWatchDog.py is not checked into source
1787         https://bugs.webkit.org/show_bug.cgi?id=196567
1788         <rdar://problem/49525901>
1789
1790         Reviewed by Lucas Forschler.
1791
1792         This script is used on Win EWS bots to terminate hanging DRT processes.
1793
1794         * EWSTools/dumprendertreewatchdog.py: Added.
1795
1796 2019-04-04  Chris Dumez  <cdumez@apple.com>
1797
1798         Unreviewed, roll out r243858 which made tests time out.
1799
1800         Disable new API tests on Windows instead.
1801
1802         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1803         (TestWebKitAPI::TEST):
1804
1805 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1806
1807         [ATK] Cleanup WebPageAccessibilityObjectAtk
1808         https://bugs.webkit.org/show_bug.cgi?id=196537
1809
1810         Reviewed by Michael Catanzaro.
1811
1812         Also consider files under atk directories as exceptions for GObject conventions.
1813
1814         * Scripts/webkitpy/style/checkers/cpp.py:
1815         (check_identifier_name_in_declaration):
1816
1817 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1818
1819         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1820         https://bugs.webkit.org/show_bug.cgi?id=196588
1821         <rdar://problem/49365787>
1822
1823         Unreviewed build fix for Windows port.
1824
1825         error C3861: 'kill': identifier not found
1826
1827         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1828         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1829
1830 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1831
1832         [ews-build] Cancel build and similar operations should have authentication
1833         https://bugs.webkit.org/show_bug.cgi?id=196520
1834
1835         Reviewed by Dewei Zhu.
1836
1837         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1838         environment variables.
1839
1840 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1841
1842         [ews-build] Do not trigger queues which are not in production yet
1843         https://bugs.webkit.org/show_bug.cgi?id=196581
1844
1845         Reviewed by Dewei Zhu.
1846
1847         * BuildSlaveSupport/ews-build/config.json:
1848
1849 2019-04-03  Chris Dumez  <cdumez@apple.com>
1850
1851         Unreviewed, fix typo in the name of API test added in r243848.
1852
1853         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1854         (TestWebKitAPI::TEST):
1855
1856 2019-04-03  Chris Dumez  <cdumez@apple.com>
1857
1858         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1859         https://bugs.webkit.org/show_bug.cgi?id=196588
1860         <rdar://problem/49365787>
1861
1862         Reviewed by Ryosuke Niwa.
1863
1864         Add API test coverage.
1865
1866         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1867         (TestWebKitAPI::nullJavaScriptCallback):
1868         (TestWebKitAPI::didCrashCheckFrames):
1869         (TestWebKitAPI::TEST):
1870
1871 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1872
1873         run-webkit-tests: Upload test results (new results database)
1874         https://bugs.webkit.org/show_bug.cgi?id=196577
1875         <rdar://problem/34841155>
1876
1877         Reviewed by Lucas Forschler.
1878
1879         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1880         (Manager.run): Upload results after each device shard, since the configuration will be
1881         different for each device.
1882         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1883         uploaded to a results database.
1884         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1885         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1886
1887 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1888
1889         -apple-trailing-word is needed for browser detection
1890         https://bugs.webkit.org/show_bug.cgi?id=196575
1891
1892         Unreviewed.
1893
1894         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1895
1896 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1897
1898         [CMake][WTF] Mirror XCode header directories
1899         https://bugs.webkit.org/show_bug.cgi?id=191662
1900
1901         Reviewed by Konstantin Tokarev.
1902
1903         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1904         builds.
1905
1906         * CMakeLists.txt:
1907         * DumpRenderTree/CMakeLists.txt:
1908         * DumpRenderTree/PlatformWin.cmake:
1909         * MiniBrowser/win/CMakeLists.txt:
1910         * TestWebKitAPI/CMakeLists.txt:
1911         * TestWebKitAPI/PlatformWin.cmake:
1912         * WebKitTestRunner/PlatformGTK.cmake:
1913         * WebKitTestRunner/PlatformWin.cmake:
1914
1915 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1916
1917         [ews-app] Status bubble should not display certain infrastructure status messages
1918         https://bugs.webkit.org/show_bug.cgi?id=196550
1919
1920         Reviewed by Lucas Forschler.
1921
1922         Do not display the steps which are un-needed for end-user. This information is still avaiable
1923         if the user click on the bubble and look at the Buildbot build.
1924         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1925         (StatusBubble._steps_messages):
1926         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1927
1928 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1929
1930         [ews-build] Use https for sending data to ews-app
1931         https://bugs.webkit.org/show_bug.cgi?id=196492
1932
1933         Reviewed by Lucas Forschler.
1934
1935         * BuildSlaveSupport/ews-build/events.py:
1936
1937 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1938
1939         Remove support for -apple-trailing-word
1940         https://bugs.webkit.org/show_bug.cgi?id=196525
1941
1942         Reviewed by Zalan Bujtas.
1943
1944         This CSS property is nonstandard and not used.
1945
1946         * Scripts/webkitperl/FeatureList.pm:
1947         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1948
1949 2019-04-03  Youenn Fablet  <youenn@apple.com>
1950
1951         Add a test for DOMCache on multiple browsing in case of private browsing
1952         https://bugs.webkit.org/show_bug.cgi?id=196524
1953
1954         Reviewed by Alex Christensen.
1955
1956         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1957         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1958
1959 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1960
1961         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1962         https://bugs.webkit.org/show_bug.cgi?id=196540
1963
1964         Reviewed by Aakash Jain.
1965
1966         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1967
1968 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1969
1970         Add plumbing for a compatibility mode preference in WebKit
1971         https://bugs.webkit.org/show_bug.cgi?id=196005
1972
1973         Reviewed by Tim Horton.
1974
1975         Add new API tests.
1976
1977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1978         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1979
1980 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1981
1982         [WPE][GTK] Update libsrtp dependency package for Debian
1983         https://bugs.webkit.org/show_bug.cgi?id=196528
1984
1985         Reviewed by Frédéric Wang.
1986
1987         * gtk/install-dependencies:
1988         * wpe/install-dependencies:
1989
1990 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1991
1992         [WK2] Add support for Window's beforeprint / afterprint events
1993         https://bugs.webkit.org/show_bug.cgi?id=196478
1994         <rdar://problem/49535124>
1995
1996         Unreviewed build fix for MSVC.
1997
1998         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1999
2000         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2001
2002         * WebKitTestRunner/TestController.cpp:
2003         (WTR::printFrame): Use int and float literals.
2004
2005 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2006
2007         [ews-build] Reassign bots to queues
2008
2009         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2010
2011 2019-04-02  Chris Dumez  <cdumez@apple.com>
2012
2013         [WK2] Add support for Window's beforeprint / afterprint events
2014         https://bugs.webkit.org/show_bug.cgi?id=196478
2015
2016         Reviewed by Alex Christensen.
2017
2018         Add minimal implementation for printFrame in WebKitTestRunner.
2019
2020         * WebKitTestRunner/TestController.cpp:
2021         (WTR::printFrame):
2022         (WTR::TestController::createOtherPage):
2023         (WTR::TestController::createWebViewWithOptions):
2024
2025 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2026
2027         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2028         https://bugs.webkit.org/show_bug.cgi?id=196491
2029
2030         Reviewed by Lucas Forschler.
2031
2032         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2033
2034 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2035
2036         [ews-build] Configure buildbot try credentials in environment variables
2037         https://bugs.webkit.org/show_bug.cgi?id=196501
2038
2039         Reviewed by Lucas Forschler.
2040
2041         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2042         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2043         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2044
2045 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2046
2047         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2048         https://bugs.webkit.org/show_bug.cgi?id=196496
2049         <rdar://problem/49521634>
2050
2051         Reviewed by Chris Dumez.
2052
2053         Add new API tests (see WebKit ChangeLog for more detail).
2054
2055         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2056         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2057         (TEST):
2058
2059 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2060
2061         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2062         <https://webkit.org/b/196499>
2063
2064         Reviewed by Alexey Proskuryakov.
2065
2066         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2067         ENABLE_ADDRESS_SANITIZER.
2068
2069 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2070
2071         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2072         https://bugs.webkit.org/show_bug.cgi?id=182757
2073
2074         Reviewed by Don Olmstead.
2075
2076         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2077         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2078
2079 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2080
2081         run-api-tests: Upload test results
2082         https://bugs.webkit.org/show_bug.cgi?id=196323
2083         <rdar://problem/49356714>
2084
2085         Reviewed by Lucas Forschler.
2086
2087         * Scripts/webkitpy/api_tests/manager.py:
2088         (Manager):
2089         (Manager.run): Upload results to a results database.
2090         * Scripts/webkitpy/api_tests/run_api_tests.py:
2091         (parse_args): Add upload arguments.
2092         * Scripts/webkitpy/port/base.py:
2093         (Port):
2094         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2095         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2096         with commits from any other associated repositories.
2097         * Scripts/webkitpy/port/device.py:
2098         (Device):
2099         (Device.build_version): Access build_versoin of underlying platform device.
2100         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2101         (IOSSimulatorTest):
2102         (IOSSimulatorTest.test_configuration_for_upload):
2103         * Scripts/webkitpy/port/device_port.py:
2104         (DevicePort):
2105         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2106         the same as the machine uploading results.
2107         * Scripts/webkitpy/port/mac.py:
2108         (MacPort):
2109         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2110         * Scripts/webkitpy/port/mac_unittest.py:
2111         (MacTest):
2112         (MacTest.test_configuration_for_upload):
2113         * Scripts/webkitpy/xcode/simulated_device.py:
2114         (SimulatedDeviceManager._create_device_with_runtime):
2115         (SimulatedDevice.__init__): Create simulated device with a build_version.
2116         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2117         (test_existing_simulator):
2118
2119 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2120
2121         Remove extra newline characters (Follow-up fix to r243707)
2122
2123         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2124
2125 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2126
2127         [ews-app] Use API_KEY to accept results data
2128         https://bugs.webkit.org/show_bug.cgi?id=196461
2129
2130         Reviewed by Dewei Zhu.
2131
2132         * BuildSlaveSupport/ews-app/ews/views/results.py:
2133         (Results.post): Validate EWS_API_KEY before accepting any data.
2134         * BuildSlaveSupport/ews-build/events.py:
2135         (Events.sendData): Send EWS_API_KEY if available along with event data.
2136
2137 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2138
2139         Unable to copy and paste a PDF from Notes into Mail compose body
2140         https://bugs.webkit.org/show_bug.cgi?id=196442
2141         <rdar://problem/48573098>
2142
2143         Reviewed by Tim Horton.
2144
2145         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2146         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2147         to be specified on the item providers.
2148
2149         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2150         (TestWebKitAPI::mapItemForTesting):
2151         (TestWebKitAPI::contactItemForTesting):
2152
2153 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2154
2155         Make UIWKDocumentContext rects per-character instead of per-word
2156         https://bugs.webkit.org/show_bug.cgi?id=196459
2157
2158         Reviewed by Wenson Hsieh.
2159
2160         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2161         (TEST):
2162         Adjust test results due to switching to per-character rects.
2163
2164 2019-04-01  Chris Dumez  <cdumez@apple.com>
2165
2166         UIProcess crash when a prewarmed process is terminated
2167         https://bugs.webkit.org/show_bug.cgi?id=196451
2168         <rdar://problem/49245471>
2169
2170         Reviewed by Geoffrey Garen.
2171
2172         Add API test coverage.
2173
2174         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2175         (TEST):
2176
2177 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2178
2179         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2180         https://bugs.webkit.org/show_bug.cgi?id=196449
2181
2182         Reviewed by Lucas Forschler.
2183
2184         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2185         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2186         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2187         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2188
2189 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2190
2191         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2192         https://bugs.webkit.org/show_bug.cgi?id=196444
2193
2194         Reviewed by Lucas Forschler.
2195
2196         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2197
2198 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2199
2200         Add SPI to canonicalize NSURLs with WTF::URL
2201         https://bugs.webkit.org/show_bug.cgi?id=196415
2202         <rdar://problem/44980271>
2203
2204         Reviewed by Darin Adler.
2205
2206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2207         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2208         (TestWebKitAPI::TEST):
2209
2210 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2211
2212         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2213         https://bugs.webkit.org/show_bug.cgi?id=196441
2214
2215         Reviewed by Carlos Garcia Campos.
2216
2217         Don't cache the wpe_view_backend object that might not exist yet at the
2218         time of EventSenderProxy constructor invocation, but instead retrieve
2219         that object whenever it's required for event dispatching. This should
2220         avoid crashes in this constructor now that it's invoked before any
2221         PlatformWindow has been set up (as changed in r243496).
2222
2223         * WebKitTestRunner/EventSenderProxy.h:
2224         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2225         (WTR::viewBackend):
2226         (WTR::EventSenderProxy::EventSenderProxy):
2227         (WTR::EventSenderProxy::mouseDown):
2228         (WTR::EventSenderProxy::mouseUp):
2229         (WTR::EventSenderProxy::mouseMoveTo):
2230         (WTR::EventSenderProxy::mouseScrollBy):
2231         (WTR::EventSenderProxy::keyDown):
2232         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2233
2234 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2235
2236         [Win][WebKit] MiniBrowser should support high DPI display
2237         https://bugs.webkit.org/show_bug.cgi?id=196391
2238
2239         Reviewed by Alex Christensen.
2240
2241         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2242         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2243         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2244         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2245
2246 2019-03-31  Sam Weinig  <weinig@apple.com>
2247
2248         Remove more i386 specific configurations
2249         https://bugs.webkit.org/show_bug.cgi?id=196430
2250
2251         Reviewed by Alexey Proskuryakov.
2252
2253         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2254         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2255
2256 2019-03-31  Andy Estes  <aestes@apple.com>
2257
2258         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2259         https://bugs.webkit.org/show_bug.cgi?id=196433
2260         <rdar://problem/49293305>
2261
2262         Reviewed by Tim Horton.
2263
2264         Enhanced API test coverage to include all navigation response policy decisions in both
2265         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2266
2267         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2268         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2269         (TestWebKitAPI::TEST):
2270         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2271         (readFile):
2272         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2273         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2274         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2275         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2276         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2277         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2278         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2279         (-[QuickLookDelegate _downloadDidStart:]):
2280         (-[QuickLookDelegate _download:didReceiveResponse:]):
2281         (-[QuickLookDelegate _download:didReceiveData:]):
2282         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2283         (-[QuickLookDelegate _downloadDidFinish:]):
2284         (-[QuickLookDelegate _download:didFailWithError:]):
2285         (-[QuickLookDelegate _downloadDidCancel:]):
2286         (-[QuickLookDelegate verifyDownload]):
2287         (runTest):
2288         (runTestDecideBeforeLoading):
2289         (runTestDecideAfterLoading):
2290         (TEST):
2291         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2292         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2293         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2294         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2295         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2296         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2297         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2298         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2299         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2300         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2301         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2302         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2303         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2304         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2305
2306 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2307
2308         [CMake] add testdfg as target with build-jsc
2309         https://bugs.webkit.org/show_bug.cgi?id=196393
2310
2311         Reviewed by Saam Barati.
2312
2313         Added testdfg as one of the targets to build when
2314         using CMake.
2315
2316         * Scripts/build-jsc:
2317
2318 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2319
2320         Delete WebMetal implementation in favor of WebGPU
2321         https://bugs.webkit.org/show_bug.cgi?id=195418
2322
2323         Reviewed by Dean Jackson.
2324
2325         * DumpRenderTree/mac/DumpRenderTree.mm:
2326         (enableExperimentalFeatures):
2327         (resetWebPreferencesToConsistentValues):
2328         * Scripts/webkitperl/FeatureList.pm:
2329         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2331         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2332         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2333         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2334         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2335         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2336         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2337         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2338         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2339         (WTR::InjectedBundle::beginTesting):
2340         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2341         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2342         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2343
2344 2019-03-29  Chris Dumez  <cdumez@apple.com>
2345
2346         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2347         https://bugs.webkit.org/show_bug.cgi?id=196405
2348         <rdar://problem/49428130>
2349
2350         Reviewed by Wenson Hsieh.
2351
2352         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2353         the popover presentation methods to be no-ops. Use this in the new test added in
2354         r243523 so that we do not swizzle those methods for all tests. This is needed because
2355         those WatchOS tests rely on the popover getting presented and interactive.
2356
2357         * WebKitTestRunner/TestController.cpp:
2358         (WTR::updateTestOptionsFromTestHeader):
2359         * WebKitTestRunner/TestController.h:
2360         * WebKitTestRunner/TestOptions.h:
2361         (WTR::TestOptions::hasSameInitializationOptions const):
2362         * WebKitTestRunner/ios/TestControllerIOS.mm:
2363         (WTR::TestController::platformInitialize):
2364         (WTR::TestController::platformResetStateToConsistentValues):
2365
2366 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2367
2368         [Curl] Add Server Trust Evaluation Support.
2369         https://bugs.webkit.org/show_bug.cgi?id=191646
2370
2371         Reviewed by Fujii Hironori.
2372
2373         Implemented MiniBrowser UI for asking if user trusts the server.
2374
2375         * MiniBrowser/win/Common.cpp:
2376         (askServerTrustEvaluation):
2377         (replaceString):
2378         * MiniBrowser/win/Common.h:
2379         * MiniBrowser/win/MiniBrowserLib.rc:
2380         * MiniBrowser/win/MiniBrowserLibResource.h:
2381         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2382         (createPEMString):
2383         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2384         (WebKitBrowserWindow::canTrustServerCertificate):
2385         * MiniBrowser/win/WebKitBrowserWindow.h:
2386
2387 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2388
2389         Implement ResizeObserver.
2390         https://bugs.webkit.org/show_bug.cgi?id=157743
2391
2392         Reviewed by Simon Fraser.
2393
2394         Support resizeObserverEnabled webPreferences.
2395
2396         * DumpRenderTree/TestOptions.cpp:
2397         (TestOptions::TestOptions):
2398         * DumpRenderTree/TestOptions.h:
2399         * DumpRenderTree/mac/DumpRenderTree.mm:
2400         (setWebPreferencesForTestOptions):
2401         * DumpRenderTree/win/DumpRenderTree.cpp:
2402         (enableExperimentalFeatures):
2403         * Scripts/webkitperl/FeatureList.pm:
2404         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2405
2406 2019-03-28  John Wilander  <wilander@apple.com>
2407
2408         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2409         https://bugs.webkit.org/show_bug.cgi?id=196281
2410         <rdar://problem/48938748>
2411
2412         Reviewed by Alex Christensen.
2413
2414         This patch adds the function isStatisticsHasLocalStorage() to the
2415         TestRunner. With it, the page can query the WebsiteDataStore in the
2416         UI process to make sure that it sees LocalStorage.
2417
2418         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2419         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2420         (WTR::TestRunner::isStatisticsHasLocalStorage):
2421         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2422         * WebKitTestRunner/TestController.cpp:
2423         (WTR::TestController::isStatisticsHasLocalStorage):
2424         * WebKitTestRunner/TestController.h:
2425         * WebKitTestRunner/TestInvocation.cpp:
2426         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2427
2428 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2429
2430         API::Data::createWithoutCopying should do a null check before calling CFRelease
2431         https://bugs.webkit.org/show_bug.cgi?id=196276
2432         <rdar://problem/48059859>
2433
2434         Reviewed by Alex Christensen.
2435
2436         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2437
2438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2439         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2440         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2441         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2442         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2443         (TestWebKitAPI::TEST):
2444
2445 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2446
2447         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2448         https://bugs.webkit.org/show_bug.cgi?id=186276
2449
2450         Reviewed by Carlos Garcia Campos.
2451
2452         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2453         (webViewLoadChanged):
2454         (testWebResourceGetDataError):
2455         (testWebResourceGetDataEmpty):
2456         (beforeAll):
2457         (webViewloadChanged): Deleted.
2458
2459 2019-03-27  Andy Estes  <aestes@apple.com>
2460
2461         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2462         https://bugs.webkit.org/show_bug.cgi?id=196317
2463
2464         Reviewed by Dan Bernstein.
2465
2466         package-root copies built products into a staging directory using ditto(1), which does not
2467         follow symbolic links as it traverses a directory. Now that the files in
2468         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2469         itself, these become broken links when ditto'd into the staging directory.
2470
2471         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2472
2473         * Scripts/package-root:
2474
2475 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2476
2477         [ews-app] Update display text of Submit for ews analysis
2478         https://bugs.webkit.org/show_bug.cgi?id=196309
2479
2480         Reviewed by Dewei Zhu.
2481
2482         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2483
2484 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2485
2486         run-webkit-tests should check for leaks in WebKit processes
2487         <https://webkit.org/b/193772>
2488         <rdar://problem/46526680>
2489
2490         Reviewed by Ryosuke Niwa.
2491
2492         This works by doing the following:
2493         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2494           The list of child processes are returned one per line:
2495           process.name: pid
2496         - Run the "#LIST CHILD PROCESSES" command just before the
2497           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2498           processes on the ServerProcess object.
2499         - When the `--leaks` switch is handled, run check_for_leaks() on
2500           each child process after the main test harness.
2501
2502         * DumpRenderTree/mac/DumpRenderTree.mm:
2503         (handleControlCommand):
2504         - Use strncmp() instead of strcmp().
2505         - Add support for handling "#LIST CHILD PROCESSES" command.
2506
2507         * Scripts/webkitpy/port/base.py:
2508         (Port.check_for_leaks):
2509         * Scripts/webkitpy/port/darwin.py:
2510         (DarwinPort.check_for_leaks):
2511         - Rename redundant 'process_pid' argument to 'process_id'.
2512
2513         * Scripts/webkitpy/port/driver.py:
2514         (Driver.do_post_tests_work):
2515         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2516           longer the only command this sends to WebKitTestRunner.
2517         - If the `--leaks` switch is present, send the
2518           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2519           result using Port.set_webkit_processes().
2520         (Driver._parse_child_processes_output):
2521         - Add helper method to parse list of child process names and
2522           process IDs returned from WebKitTestRunner.
2523
2524         * Scripts/webkitpy/port/ios_device.py:
2525         (IOSDevicePort.check_for_leaks):
2526         - Rename redundant 'process_pid' argument to 'process_id'.
2527
2528         * Scripts/webkitpy/port/leakdetector.py:
2529         (LeakDetector._parse_leaks_output):
2530         - Return early if there is no leaks_output.
2531         (LeakDetector.check_for_leaks):
2532         - Rename redundant 'process_pid' argument to 'process_id'.
2533
2534         * Scripts/webkitpy/port/server_process.py:
2535         (ServerProcess.__init__):
2536         (ServerProcess.child_processes):
2537         (ServerProcess.set_child_processes):
2538         - Add instance variable to Port to store list of child process
2539           names and process IDs returned from WebKitTestRunner.
2540         (ServerProcess._start):
2541         - Clear self._child_processes.
2542         (ServerProcess.stop):
2543         - If self._child_processes is set, call
2544           self._port.check_for_leaks() for each child process.
2545
2546         * Scripts/webkitpy/port/server_process_unittest.py:
2547         (TrivialMockPort.check_for_leaks):
2548         - Rename redundant 'process_pid' argument to 'process_id'.
2549
2550         * Scripts/webkitpy/port/simulator_process.py:
2551         (SimulatorProcess.stop):
2552         - If self._child_processes is set, call
2553           self._port.check_for_leaks() for each child process.
2554
2555         * Scripts/webkitpy/port/watch_device.py:
2556         (WatchDevicePort.check_for_leaks):
2557         - Rename redundant 'process_pid' argument to 'process_id'.
2558
2559         * WebKitTestRunner/TestController.cpp:
2560         (WTR::TestController::dumpResponse):
2561         - Extract method from findAndDumpWorldLeaks() so that it may be
2562           reused by findAndDumpWebKitProcessIdentifiers().
2563         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2564         - Add method to output process name and process ID of both the
2565           WebContent and Networking processes.
2566         (WTR::TestController::findAndDumpWorldLeaks):
2567         - Fix missing newline in output when there were no abandoned
2568           documents.
2569         - Call dumpResponse() for extracted code.
2570         (WTR::TestController::handleControlCommand):
2571         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2572         - Use strncmp() instead of strcmp().
2573         - Call findAndDumpWebKitProcessIdentifiers() when
2574           "#LIST CHILD PROCESSES" command is sent.
2575         * WebKitTestRunner/TestController.h:
2576         (WTR::TestController::dumpResponse):
2577         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2578         - Declare methods.
2579
2580 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2581
2582         Unreviewed. Add GLib API test cases after r243434.
2583
2584         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2585         (testWebViewActiveURI):
2586         (serverCallback):
2587         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2588         (sendRequestCallback):
2589
2590 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2591
2592         Geolocation request not complete when watch request was started in a different web process
2593         https://bugs.webkit.org/show_bug.cgi?id=195996
2594
2595         Reviewed by Alex Christensen.
2596
2597         Add a test case.
2598
2599         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2600         (TestWebKitAPI::runJavaScriptAlert):
2601         (TestWebKitAPI::TEST):
2602
2603 2019-03-26  Keith Rollin  <krollin@apple.com>
2604
2605         Update the way generate-xcfilelists returns strings from functions
2606         https://bugs.webkit.org/show_bug.cgi?id=195975
2607         <rdar://problem/49040807>
2608
2609         Reviewed by Dean Jackson.
2610
2611         There are places where generate-xcfilelists executes assignments with
2612         statements like:
2613
2614             FOO=$(some_function)
2615
2616         where "some_function" return a string by echoing it. E.g.
2617
2618             some_function()
2619             {
2620                 echo "Hello, World"
2621             }
2622
2623         This is a common idiom, but it has a problem if "some_function" needs
2624         to call "exit" in an attempt to halt the entire script right then and
2625         there. Since "some_function" is called inside of $(), it's being
2626         executed in a sub-shell. Calling exit in that sub-shell simply exits
2627         that shell; it doesn't not exit the outer shell in which the main part
2628         of the script is still running. As such, the main script keeps
2629         executing when the intent was for the script to halt.
2630
2631         The solution to this is to use a different idiom for returning
2632         strings. The one we now is to pass in the name of the variable to
2633         receive the string result:
2634
2635             some_function()
2636             {
2637                 variable_name=$1
2638                 eval $variable_name ="Hello, World"
2639             }
2640
2641         The call site now looks like
2642
2643             some_function FOO
2644
2645         Because there's no invocation of a sub-shell, some_function can now
2646         call "exit" if it wants to, and the entire script will exit at that
2647         point.
2648
2649         * Scripts/generate-xcfilelists:
2650
2651 2019-03-26  Chris Dumez  <cdumez@apple.com>
2652
2653         Add basic layout test coverage for File Picker on iOS
2654         https://bugs.webkit.org/show_bug.cgi?id=196265
2655
2656         Reviewed by Wenson Hsieh.
2657
2658         Add layout test infrastructure to test the file picker on iOS.
2659
2660         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2661         (WTR::UIScriptController::dismissFilePicker):
2662         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2663         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2664         (WTR::UIScriptController::dismissFilePicker):
2665         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2666         * WebKitTestRunner/TestController.cpp:
2667         (WTR::TestController::createWebViewWithOptions):
2668         (WTR::updateTestOptionsFromTestHeader):
2669         * WebKitTestRunner/TestOptions.h:
2670         (WTR::TestOptions::hasSameInitializationOptions const):
2671         * WebKitTestRunner/ios/TestControllerIOS.mm:
2672         (overridePresentViewController):
2673         (WTR::TestController::platformInitialize):
2674         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2675         (WTR::UIScriptController::dismissFilePicker):
2676
2677 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2678
2679         Implement async paste method on UIWKInteractionViewProtocol
2680         https://bugs.webkit.org/show_bug.cgi?id=196267
2681         <rdar://problem/49236346>
2682
2683         Reviewed by Tim Horton.
2684
2685         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2686         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2687         are now a part of all iOS 12 internal SDKs.
2688
2689         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2690
2691         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2692         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2693
2694         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2695         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2696         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2697         * TestWebKitAPI/ios/UIKitSPI.h:
2698
2699 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2700
2701         [ews-build] Use PostgreSQL for ews.webkit.org database
2702         https://bugs.webkit.org/show_bug.cgi?id=196270
2703
2704         Reviewed by Lucas Forschler.
2705
2706         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2707
2708 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2709
2710         [ews] Reset simctl states on reboot
2711         https://bugs.webkit.org/show_bug.cgi?id=196260
2712
2713         Rubber-stamped by Aakash Jain.
2714
2715         * EWSTools/start-queue-mac.sh:
2716
2717 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2718
2719         [ews-build] Use PostgreSQL for ews-build database
2720         https://bugs.webkit.org/show_bug.cgi?id=196229
2721
2722         Reviewed by Lucas Forschler.
2723
2724         * BuildSlaveSupport/ews-build/master.cfg:
2725
2726 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2727
2728         [ews-build] Get master_hostname dynamically in master.cfg
2729         https://bugs.webkit.org/show_bug.cgi?id=196255
2730
2731         Reviewed by Lucas Forschler.
2732
2733         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2734         send events data in test mode.
2735
2736 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2737
2738         [ews-app] Set db_constraint to False for Foreign Keys
2739         https://bugs.webkit.org/show_bug.cgi?id=196252
2740
2741         Reviewed by Lucas Forschler.
2742
2743         * BuildSlaveSupport/ews-app/ews/models/build.py:
2744         * BuildSlaveSupport/ews-app/ews/models/step.py:
2745
2746 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2747
2748         [ews-build] is_test_mode_enabled should default to True
2749         https://bugs.webkit.org/show_bug.cgi?id=196248
2750
2751         Reviewed by Lucas Forschler.
2752
2753         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2754
2755 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2756
2757         [ews-app] Add webkitperl to ENABLED_QUEUES
2758         https://bugs.webkit.org/show_bug.cgi?id=196253
2759
2760         Reviewed by Lucas Forschler.
2761
2762         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2763
2764 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2765
2766         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2767         https://bugs.webkit.org/show_bug.cgi?id=196211
2768         rdar://problem/49110552
2769
2770         Reviewed by Tim Horton.
2771
2772         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2773         Make sure that EventSenderProxy always exists when running tests. We used to create
2774         it when resetting before the first test, which is a bit too late.
2775
2776         * WebKitTestRunner/TestController.h:
2777         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2778         (WTR::TestController::platformCreateWebView):
2779         (WTR::TestController::platformCreateOtherPage):
2780         (WTR::TestController::finishCreatingPlatformWebView):
2781         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2782         (WTR::PlatformWebView::PlatformWebView):
2783         Moved some code that made NSWindow use NSEvent during web view creation. We may
2784         need to move more if some other case us found, but this is enough for now.
2785
2786 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2787
2788         Unreviewed. Fix typo in GLib geolocation API after r243285.
2789
2790         gelocation -> geolocation.
2791
2792         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2793         (testGeolocationManagerWatchPosition):
2794
2795 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2796
2797         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2798         https://bugs.webkit.org/show_bug.cgi?id=196213
2799
2800         Reviewed by Geoff Garen.
2801
2802         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2803         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2804         (credentialWithIdentityAndKeychainPath):
2805         (-[ChallengeDelegate webView:didFinishNavigation:]):
2806         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2807         (TestWebKitAPI::TEST):
2808
2809 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2810
2811         Expected shouldn't assume its contained types are copyable
2812         https://bugs.webkit.org/show_bug.cgi?id=195986
2813
2814         Reviewed by JF Bastien.
2815
2816         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2817         (TestWebKitAPI::NonCopyable::operator== const):
2818         (TestWebKitAPI::NonCopyable::operator!= const):
2819         (TestWebKitAPI::TEST):
2820
2821 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2822
2823         Remove some now-unnecessary dynamic class lookup
2824         https://bugs.webkit.org/show_bug.cgi?id=196237
2825
2826         Reviewed by Simon Fraser.
2827
2828         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2829         (makeRequest):
2830         (TEST):
2831
2832 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2833
2834         Unreviewed, rolling out r243450.
2835
2836         AppleWin and WinCairo port builds get broken.
2837
2838         Reverted changeset:
2839
2840         "Add test for fix of #196095"
2841         https://bugs.webkit.org/show_bug.cgi?id=196097
2842         https://trac.webkit.org/changeset/243450
2843
2844 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2845
2846         Unreviewed, rolling out r243465.
2847         https://bugs.webkit.org/show_bug.cgi?id=196226
2848
2849         the test doesn't build (Requested by thorton on #webkit).
2850
2851         Reverted changeset:
2852
2853         "Do not terminate the NetworkProcess if a third party
2854         application sends a NSCredential with a SecIdentityRef"
2855         https://bugs.webkit.org/show_bug.cgi?id=196213
2856         https://trac.webkit.org/changeset/243465
2857
2858 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2859
2860         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2861         https://bugs.webkit.org/show_bug.cgi?id=196213
2862
2863         Reviewed by Geoff Garen.
2864
2865         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2866         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2867         (credentialWithIdentityAndKeychainPath):
2868         (-[ChallengeDelegate webView:didFinishNavigation:]):
2869         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2870         (TestWebKitAPI::TEST):
2871
2872 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2873
2874         [ews-build] Gracefully handle missing patch_id in events
2875         https://bugs.webkit.org/show_bug.cgi?id=196216
2876
2877         Reviewed by Lucas Forschler.
2878
2879         * BuildSlaveSupport/ews-build/events.py:
2880
2881 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2882
2883         [ews-build] use lz4 compression for improving buildbot performance
2884         https://bugs.webkit.org/show_bug.cgi?id=196155
2885
2886         Reviewed by Lucas Forschler.
2887
2888         * BuildSlaveSupport/ews-build/master.cfg:
2889
2890 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2891
2892         Pull some API testing helper methods out of TestWKWebView
2893         https://bugs.webkit.org/show_bug.cgi?id=196212
2894
2895         Reviewed by Tim Horton.
2896
2897         Refactor some more API testing utility methods, so that they can be used in
2898         tests that do not use TestWKWebView.
2899
2900         * TestWebKitAPI/cocoa/TestWKWebView.h:
2901         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2902         (-[WKWebView loadTestPageNamed:]):
2903         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2904         (-[WKWebView synchronouslyLoadHTMLString:]):
2905         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2906         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2907         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2908         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2909         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2910
2911 2019-03-25  Jer Noble  <jer.noble@apple.com>
2912
2913         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2914         https://bugs.webkit.org/show_bug.cgi?id=196097
2915
2916         Reviewed by Eric Carlson.
2917
2918         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2919
2920         * DumpRenderTree/mac/DumpRenderTree.mm:
2921         (resetWebPreferencesToConsistentValues):
2922         * WebKitTestRunner/TestController.cpp:
2923         (WTR::TestController::resetPreferencesToConsistentValues):
2924
2925 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2926
2927         Pull IPadUserInterfaceSwizzler out into a separate header file
2928         https://bugs.webkit.org/show_bug.cgi?id=196193
2929
2930         Reviewed by Anders Carlsson.
2931
2932         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2933         be used in other API tests.
2934
2935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2936         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2937         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2938         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2939         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2940         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2941         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2942
2943 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2944
2945         Remove NavigatorContentUtils in WebCore/Modules
2946         https://bugs.webkit.org/show_bug.cgi?id=196070
2947
2948         Reviewed by Alex Christensen.
2949
2950         NavigatorContentUtils was to support the custom scheme spec [1].
2951         However, in WebKit side, no port has supported the feature in
2952         WebKit layer after EFL port was removed. So there has been the
2953         only IDL implementation of the NavigatorContentUtils in WebCore.
2954         So we don't need to keep the implementation in WebCore anymore.
2955
2956         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2957
2958         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2959
2960 2019-03-24  Andy Estes  <aestes@apple.com>
2961
2962         [watchOS] Remove unused Proximity Networking code
2963         https://bugs.webkit.org/show_bug.cgi?id=196188
2964
2965         Reviewed by Tim Horton.
2966
2967         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2968         (TEST):
2969
2970 2019-03-23  Keith Miller  <keith_miller@apple.com>
2971
2972         Refactor clz/ctz and fix getLSBSet.
2973         https://bugs.webkit.org/show_bug.cgi?id=196162
2974
2975         Reviewed by Saam Barati.
2976
2977         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2978
2979         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2980         (TestWebKitAPI::TEST):
2981
2982 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2983
2984         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2985         https://bugs.webkit.org/show_bug.cgi?id=196143
2986
2987         Reviewed by Michael Catanzaro.
2988
2989         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2990         directories.
2991
2992         * Scripts/webkitpy/style/checkers/cpp.py:
2993         (check_identifier_name_in_declaration):
2994         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2995         (WebKitStyleTest.test_names):
2996
2997 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2998
2999         [Flatpak] Manifest expanding fails for qt WPE extension
3000         https://bugs.webkit.org/show_bug.cgi?id=196148
3001
3002         Reviewed by Alex Christensen.
3003
3004         * flatpak/flatpakutils.py:
3005         (expand_submodules_recurse): The last recurse manifest expand
3006         iteration might lead to a single module so take it into account
3007         and don't try to recurse further.
3008
3009 2019-03-22  Chris Dumez  <cdumez@apple.com>
3010
3011         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3012         https://bugs.webkit.org/show_bug.cgi?id=195348
3013         <rdar://problem/48622090>
3014
3015         Reviewed by Alex Christensen.
3016
3017         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3018         to NO when test.options().shouldIgnoreMetaViewport is false.
3019
3020         * WebKitTestRunner/ios/TestControllerIOS.mm:
3021         (WTR::TestController::platformConfigureViewForTest):
3022
3023 2019-03-22  Chris Dumez  <cdumez@apple.com>
3024
3025         Prewarmed processes should be usable with any website data store
3026         https://bugs.webkit.org/show_bug.cgi?id=196104
3027
3028         Reviewed by Alex Christensen.
3029
3030         Add API test coverage.
3031
3032         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3033         (runInitialWarmedProcessUsedTest):
3034         (TEST):
3035
3036 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3037
3038         Back out local changes to Alex's Subversion working directory
3039
3040         They were accidentally committed.
3041
3042         * Scripts/webkitpy/common/system/abstractexecutive.py:
3043         (AbstractExecutive.wait_newest):
3044         * Scripts/webkitpy/common/system/executive.py:
3045         (Executive.running_pids):
3046         * Scripts/webkitpy/common/system/executive_mock.py:
3047         (MockExecutive.running_pids):
3048         * Scripts/webkitpy/common/system/executive_unittest.py:
3049         (ExecutiveTest.serial_test_running_pids):
3050         * Scripts/webkitpy/port/darwin.py:
3051         (DarwinPort.check_for_leaks):
3052         * Scripts/webkitpy/port/leakdetector.py:
3053         (LeakDetector.check_for_leaks):
3054         - This was the hack attached to Bug 193772.
3055
3056         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3057         (+[WebKitTestRunnerEvent mouseLocation]):
3058         - This works around a crash on an internal build.
3059
3060 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3061
3062         Fix the build after r243354
3063         https://bugs.webkit.org/show_bug.cgi?id=196138
3064         <rdar://problem/49145951>
3065
3066         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3067         (TEST):
3068         * TestWebKitAPI/ios/UIKitSPI.h:
3069
3070 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3071
3072         Adopt UIWKDocumentContext
3073         https://bugs.webkit.org/show_bug.cgi?id=196040
3074         <rdar://problem/48642440>
3075
3076         Reviewed by Ryosuke Niwa.
3077
3078         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3079         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3080         (makeRequest):
3081         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3082         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3083         (applyStyle):
3084         (TEST):
3085         Add tests for UIWKDocumentContext.
3086
3087         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3088         (TEST):
3089         (recursiveFindWKContentView): Deleted.
3090         * TestWebKitAPI/cocoa/TestWKWebView.h:
3091         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3092         (recursiveFindWKContentView):
3093         (-[TestWKWebView wkContentView]):
3094         * TestWebKitAPI/ios/UIKitSPI.h:
3095         Share the WKContentView finding code between tests.
3096
3097 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3098
3099         [iOS WK2] Turn on async overflow scrolling by default
3100         https://bugs.webkit.org/show_bug.cgi?id=196011
3101         rdar://problem/48453859
3102
3103         Reviewed by Antti Koivisto.
3104         
3105         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3106         since so many basic layout tests have different results when compositing is triggered for
3107         overflow.
3108         
3109         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3110
3111         * WebKitTestRunner/TestController.cpp:
3112         (WTR::TestController::resetPreferencesToConsistentValues):
3113
3114 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3115
3116         [ews-build] Retry API test in case of failures
3117         https://bugs.webkit.org/show_bug.cgi?id=196004
3118
3119         Reviewed by Lucas Forschler.
3120
3121         * BuildSlaveSupport/ews-build/steps.py:
3122         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3123         (CompileWebKitToT.doStepIf): Ditto.
3124         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3125         (ReRunAPITests): Re-run API tests.
3126         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3127         (RunAPITestsWithoutPatch): Run API tests without patch.
3128         (RunAPITestsWithoutPatch.doStepIf):
3129         (RunAPITestsWithoutPatch.hideStepIf):
3130         (RunAPITestsWithoutPatch.evaluateCommand):
3131         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3132         (AnalyzeAPITestsResults.start):
3133         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3134         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3135         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3136         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3137
3138 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3139
3140         [ews-build] Update queues configurations
3141         https://bugs.webkit.org/show_bug.cgi?id=196074
3142
3143         Reviewed by Dewei Zhu.
3144
3145         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3146         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3147
3148 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3149
3150         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3151         https://bugs.webkit.org/show_bug.cgi?id=195680
3152         <rdar://problem/48903534>
3153
3154         Unreviewed infrastructure fix.
3155
3156         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3157         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3158
3159 2019-03-21  Andy Estes  <aestes@apple.com>
3160
3161         [iOS] Apple Pay should be available in documents with no user agent scripts
3162         https://bugs.webkit.org/show_bug.cgi?id=196061
3163         <rdar://problem/48649391>
3164
3165         Reviewed by Brady Eidson.
3166
3167         Added API tests and related infrastructure.
3168
3169         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3170         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3171         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3172         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3173         (TestWebKitAPI::TEST):
3174         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3175         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3176         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3177         * TestWebKitAPI/cocoa/TestProtocol.mm:
3178         (-[TestProtocol startLoading]):
3179         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3180         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3181         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3182         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3183
3184 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3185
3186         REGRESSSION (r243297): webkitpy tests broken
3187         https://bugs.webkit.org/show_bug.cgi?id=196108
3188
3189         Reviewed by Aakash Jain.
3190
3191         r243297 updated contributors.json, which broke a few unit tests.
3192
3193         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3194         (IRCCommandTest.test_whois):
3195         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3196
3197 2019-03-21  Chris Dumez  <cdumez@apple.com>
3198
3199         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3200         https://bugs.webkit.org/show_bug.cgi?id=196041
3201         <rdar://problem/49083230>
3202
3203         Reviewed by Alex Christensen.
3204
3205         Add API test coverage.
3206
3207         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3208         (TEST):
3209
3210 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3211
3212         Add SPI to inform applications of WKContentRuleList actions
3213         https://bugs.webkit.org/show_bug.cgi?id=195965
3214         <rdar://problem/42664365>
3215
3216         Reviewed by Geoff Garen.
3217
3218         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3219         (TestWebKitAPI::allActionsForResourceLoad):
3220         (TestWebKitAPI::testRequest):
3221         (TestWebKitAPI::TEST_F):
3222         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3223         (Notification::description):
3224         (Notification::operator== const):
3225         (toVector):
3226         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3227         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3228         (makeContentRuleList):
3229         (TEST):
3230         (makeWarnContentRuleList): Deleted.
3231
3232 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3233
3234         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3235         https://bugs.webkit.org/show_bug.cgi?id=196088
3236
3237         Reviewed by Brian Burg.
3238
3239         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3240         Support checks when only one platform is specified. Also deprecate macosx() and
3241         force the use of macos() instead.
3242
3243         * Scripts/webkitpy/style/checkers/cpp.py:
3244         (check_min_versions_of_wk_api_available):
3245         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3246         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3247
3248 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3249
3250         Update status inactive committers' status to 'contributor'.
3251
3252         * Scripts/webkitpy/common/config/contributors.json:
3253
3254 2019-03-21  Xan Lopez  <xan@igalia.com>
3255
3256         [JSC][x86] Drop support for x87 floating point
3257         https://bugs.webkit.org/show_bug.cgi?id=194853
3258
3259         Reviewed by Don Olmstead.
3260
3261         Force SSE2 on x86/32bit builds.
3262
3263         * Scripts/webkitdirs.pm:
3264         (generateBuildSystemFromCMakeProject):
3265
3266 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3267
3268         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3269         https://bugs.webkit.org/show_bug.cgi?id=196073
3270
3271         Reviewed by Michael Catanzaro.
3272
3273         Add test cases to check functions and constructors with no arguments but receiving user data.
3274
3275         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3276         (checkUserData):
3277         (testJSCFunction):
3278         (fooCreateWithUserData):
3279         (testJSCClass):
3280
3281 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3282
3283         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3284
3285         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3286
3287         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3288
3289 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3290
3291         [GTK][WPE] Add API to provide geolocation information
3292         https://bugs.webkit.org/show_bug.cgi?id=195940
3293
3294         Reviewed by Michael Catanzaro.
3295
3296         Add a new test to check the new API.
3297
3298         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3299         (testGeolocationManagerCurrentPosition):
3300         (testGeolocationManagerWatchPosition):
3301         (beforeAll):
3302         (afterAll):
3303         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3304         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3305         (beforeAll): Ditto.
3306         * TestWebKitAPI/glib/CMakeLists.txt:
3307
3308 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3309
3310         [GLib] Returning G_TYPE_OBJECT from a method does not work
3311         https://bugs.webkit.org/show_bug.cgi?id=195574
3312
3313         Reviewed by Michael Catanzaro.
3314
3315         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3316
3317         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3318         (getGFile):
3319         (getParent):
3320         (createGString):
3321         (getGString):
3322         (getGStringCopyWillRaise):
3323         (getGStringCopy):
3324         (getGStringStr):
3325         (getGStringLen):
3326         (freeGString):
3327         (testJSCClass):
3328
3329 2019-03-20  Saam Barati  <sbarati@apple.com>
3330
3331         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3332         https://bugs.webkit.org/show_bug.cgi?id=195721
3333
3334         Reviewed by Filip Pizlo.
3335
3336         * Scripts/run-javascriptcore-tests:
3337
3338 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3339
3340         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3341         https://bugs.webkit.org/show_bug.cgi?id=196049
3342
3343         Reviewed by Tim Horton.
3344
3345         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3346         overflow scrolling in general, so rename it.
3347
3348         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3349
3350 2019-03-20  Daniel Bates  <dabates@apple.com>
3351
3352         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3353         https://bugs.webkit.org/show_bug.cgi?id=196031
3354         <rdar://problem/49078172>
3355
3356         Reviewed by Tim Horton.
3357
3358         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3359         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3360         same code path used when the Done button is pressed to dismiss the <select> picker.
3361
3362         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3363         (TestWebKitAPI::TEST):
3364
3365 2019-03-20  Chris Dumez  <cdumez@apple.com>
3366
3367         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3368         https://bugs.webkit.org/show_bug.cgi?id=196029
3369         <rdar://problem/48954651>
3370
3371         Reviewed by Tim Horton.
3372
3373         Add API test coverage.
3374
3375         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3376
3377 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3378
3379         [ews-build] Improve failure summary string for ApplyPatch step
3380         https://bugs.webkit.org/show_bug.cgi?id=195995
3381
3382         Reviewed by Alexey Proskuryakov.
3383
3384         * BuildSlaveSupport/ews-build/steps.py:
3385         (ApplyPatch.getResultSummary): Override getResultSummary.
3386
3387 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3388
3389         AX: Implement support for new meter ARIA role
3390         https://bugs.webkit.org/show_bug.cgi?id=195966
3391
3392         Reviewed by Chris Fleizach.
3393
3394         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3395         to AXLevelIndicator.
3396
3397         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3398
3399 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3400
3401         [WebAuthN] Implement FIDO AppID extension
3402         https://bugs.webkit.org/show_bug.cgi?id=143491
3403         <rdar://problem/48298273>
3404
3405         Reviewed by Brent Fulgham.
3406
3407         Add a test that covers the new flag of convertToU2fSignCommand.
3408
3409         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3410         (TestWebKitAPI::TEST):
3411         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3412         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3413         (TestWebKitAPI::TEST):
3414
3415 2019-03-19  Keith Rollin  <krollin@apple.com>
3416
3417         Add support for more platforms to generate-xcfilelists
3418         https://bugs.webkit.org/show_bug.cgi?id=195977
3419
3420         Reviewed by Alexey Proskuryakov.
3421
3422         generate-xcfilelists incorrectly complains when involved with building
3423         WebKit for iphonesimulator:
3424
3425             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3426             …
3427             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3428
3429         Address this by teaching generate-xcfilelists about more platforms.
3430
3431         * Scripts/generate-xcfilelists:
3432
3433 2019-03-19  John Wilander  <wilander@apple.com>
3434
3435         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3436         https://bugs.webkit.org/show_bug.cgi?id=195923
3437         <rdar://problem/49001272>
3438
3439         Reviewed by Alex Christensen.
3440
3441         This patch does the following to the TestRunner:
3442         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3443         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3444         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3445
3446         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3447         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3448         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3449         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3450         * WebKitTestRunner/TestController.cpp:
3451         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3452         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3453         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3454         * WebKitTestRunner/TestController.h:
3455         * WebKitTestRunner/TestInvocation.cpp:
3456         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3457
3458 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3459
3460         [CMake] Support more clang and gcc sanitizers
3461         https://bugs.webkit.org/show_bug.cgi?id=195956
3462
3463         Reviewed by Michael Catanzaro.
3464
3465         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3466
3467 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3468
3469         [ews-build] Improve summary for PrintConfiguration step
3470         https://bugs.webkit.org/show_bug.cgi?id=195945
3471
3472         Reviewed by Lucas Forschler.
3473
3474         * BuildSlaveSupport/ews-build/steps.py:
3475         (PrintConfiguration.getResultSummary): Override getResultSummary.
3476
3477 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3478
3479         [ews-build] Improve summary for CheckOutSource step
3480         https://bugs.webkit.org/show_bug.cgi?id=195963
3481
3482         Reviewed by Lucas Forschler.
3483
3484         * BuildSlaveSupport/ews-build/steps.py:
3485         (CheckOutSource.getResultSummary):
3486
3487 2019-03-19  Daniel Bates  <dabates@apple.com>
3488
3489         [iOS] Focus not preserved when switching between tabs
3490         https://bugs.webkit.org/show_bug.cgi?id=195820
3491         <rdar://problem/43614450>
3492
3493         Reviewed by Brent Fulgham.
3494
3495         Add tests to ensure that we restore focus when resigning and becoming first responder.
3496
3497         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3498         (TestWebKitAPI::TEST):
3499
3500 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3501
3502         Make WTFLogChannelState and WTFLogLevel enum classes
3503         https://bugs.webkit.org/show_bug.cgi?id=195904
3504
3505         Reviewed by Eric Carlson.
3506
3507         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3508         (TestWebKitAPI::TEST_F):
3509
3510 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3511
3512         [GStreamer][EME] Backported mssdemux protection data crash fix
3513         https://bugs.webkit.org/show_bug.cgi?id=195918
3514
3515         Reviewed by Philippe Normand.
3516
3517         * gstreamer/jhbuild.modules:
3518         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3519
3520 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3521
3522         Unreviewed, rolling out r243132.
3523
3524         Broke GTK build
3525
3526         Reverted changeset:
3527
3528         "Make WTFLogChannelState and WTFLogLevel enum classes"
3529         https://bugs.webkit.org/show_bug.cgi?id=195904
3530         https://trac.webkit.org/changeset/243132
3531
3532 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3533
3534         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3535
3536         * Scripts/webkitdirs.pm:
3537         (builtDylibPathForName): Adjust the shared library name that's changed
3538         with the API version bump in r243073.
3539
3540 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3541
3542         Make WTFLogChannelState and WTFLogLevel enum classes
3543         https://bugs.webkit.org/show_bug.cgi?id=195904
3544
3545         Reviewed by Eric Carlson.
3546
3547         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3548         (TestWebKitAPI::TEST_F):
3549
3550 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3551
3552         Disable flaky test added in r2431100
3553         https://webkit.org/b/195785
3554
3555         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3556         (TestWebKitAPI::TEST):
3557         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3558
3559 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3560
3561         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3562         https://bugs.webkit.org/show_bug.cgi?id=195916
3563
3564         Reviewed by Tim Horton.
3565
3566         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3567         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3568
3569 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3570
3571         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3572
3573         * Scripts/webkitpy/common/config/contributors.json:
3574
3575 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3576
3577         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3578         https://bugs.webkit.org/show_bug.cgi?id=195785
3579
3580         Reviewed by Geoffrey Garen.
3581
3582         * TestWebKitAPI/TCPServer.cpp: Added.
3583         (TestWebKitAPI::TCPServer::TCPServer):
3584         (TestWebKitAPI::TCPServer::~TCPServer):
3585         (TestWebKitAPI::TCPServer::socketBindListen):
3586         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3587         * TestWebKitAPI/TCPServer.h: Added.
3588         (TestWebKitAPI::TCPServer::port const):
3589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3590         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3591         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3592         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3593         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3594         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3595         (TestWebKitAPI::respondSlowly):
3596         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3597         (TestWebKitAPI::downloadAtRate):
3598         (TestWebKitAPI::TEST):
3599
3600 2019-03-18  Saam Barati  <sbarati@apple.com>
3601
3602         Add a plan file for JetStream 2
3603         https://bugs.webkit.org/show_bug.cgi?id=190734
3604
3605         Reviewed by Mark Lam.
3606
3607         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3608
3609 2019-03-18  Chris Dumez  <cdumez@apple.com>
3610
3611         Delay WebProcess launch until a load is triggered in a Web view
3612         https://bugs.webkit.org/show_bug.cgi?id=195758
3613         <rdar://problem/48126013>
3614
3615         Reviewed by Geoff Garen.
3616
3617         Add API test coverage. Also update some existing API tests to not expect
3618         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3619
3620         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3621         (TestWebKitAPI::TEST):
3622         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3623         (TestWebKitAPI::TEST):
3624         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3625         (TEST):
3626         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3627         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3628         (TEST):
3629         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3630         (TEST):
3631         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3632
3633 2019-03-18  Xan Lopez  <xan@igalia.com>
3634
3635         [CMake] Prevent potential warning when determining $architecture
3636         https://bugs.webkit.org/show_bug.cgi?id=195891
3637
3638         Reviewed by Michael Catanzaro.
3639
3640         It's possible for generateBuildSystemForCMakeProject to be called
3641         before determineArchitecture() is ever called. This will make the
3642         first eq check with $architecture to be bogus (and print a
3643         warning). Change that to an eq check with architecture(), which
3644         implicitly calls determineArchitecture() if needed, and change all
3645         the other similar cases in the method in the same way to prevent
3646         future bugs like this one.
3647
3648         * Scripts/webkitdirs.pm:
3649         (generateBuildSystemFromCMakeProject):
3650
3651 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3652
3653         [WPE] Tarballs generated with “make dist” cannot build documentation
3654         https://bugs.webkit.org/show_bug.cgi?id=195885
3655
3656         Reviewed by Carlos Garcia Campos.
3657
3658         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3659
3660 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3661
3662         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3663         https://bugs.webkit.org/show_bug.cgi?id=195883
3664
3665         Reviewed by Carlos Garcia Campos.
3666
3667         * gtkdoc/gtkdoc.py:
3668         (GTKDoc._run_command): When commands fail to run, include the full command line for
3669         the program invocation and the output it has generated on the standard error stream.
3670
3671 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3672
3673         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3674         https://bugs.webkit.org/show_bug.cgi?id=195786
3675
3676         Reviewed by Philippe Normand.
3677
3678         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3679         * wpe/jhbuild.modules: Ditto.
3680
3681 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3682
3683         [ews-build] Don't run clean builds on EWS builders
3684         https://bugs.webkit.org/show_bug.cgi?id=195851
3685
3686         Reviewed by Geoffrey Garen.
3687
3688         * BuildSlaveSupport/ews-build/factories.py:
3689
3690 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3691
3692         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3693         https://bugs.webkit.org/show_bug.cgi?id=195849
3694
3695         Reviewed by Chris Dumez.
3696
3697         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3698
3699         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3700         (runWebsiteDataStoreCustomPaths):
3701
3702 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3703
3704         webkitpy: Upload test results
3705         https://bugs.webkit.org/show_bug.cgi?id=195755
3706         <rdar://problem/48896182>
3707
3708         Reviewed by Aakash Jain.
3709
3710         Establish a new format for uploading results that is not tied to layout tests, apply
3711         that format to webkitpy tests.
3712
3713         * Scripts/webkitpy/common/checkout/scm/git.py:
3714         (Git.native_branch): Return what branch the current checkout is on.
3715         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3716         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3717         * Scripts/webkitpy/common/checkout/scm/svn.py:
3718         (SVN.native_branch): Ditto.
3719         * Scripts/webkitpy/common/system/platforminfo.py:
3720         (PlatformInfo.build_version): Return a build version for Mac.
3721         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3722         (MockPlatformInfo.__init__):
3723         (MockPlatformInfo.build_version):
3724         * Scripts/webkitpy/results: Added.
3725         * Scripts/webkitpy/results/__init__.py: Added.
3726         * Scripts/webkitpy/results/options.py: Added.
3727         (upload_options): OptParse list for upload options.
3728         * Scripts/webkitpy/results/upload.py: Added.
3729         (Upload): Class which enforces the upload format expected by the results server.
3730         (Upload.Expectations):
3731         (Upload.create_configuration):
3732         (Upload.create_commit):
3733         (Upload.create_details):
3734         (Upload.create_run_stats):
3735         (Upload.create_test_result):
3736         (Upload.__init__):
3737         (Upload.Encoder): Encode Upload object as json.
3738         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3739         * Scripts/webkitpy/results/upload_unittest.py: Added.
3740         * Scripts/webkitpy/test/main.py:
3741         (Tester._parse_args): Add upload arguments.
3742         (Tester._run_tests): Allow results to be uploaded.
3743         * Scripts/webkitpy/test/runner.py:
3744         (Runner.__init__): Record which tests were run, rather than just counting them.
3745         (Runner.handle):
3746         * Scripts/webkitpy/test/runner_unittest.py:
3747         (RunnerTest.test_run):
3748         * Scripts/webkitpy/thirdparty/__init__.py:
3749         (AutoinstallImportHook.find_module): Add requests auto-install.
3750         (AutoinstallImportHook._install_requests):
3751         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3752         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3753
3754 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3755
3756         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3757         https://bugs.webkit.org/show_bug.cgi?id=195810
3758
3759         Reviewed by Tim Horton.
3760
3761         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3762         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3763         ending certain layout tests.
3764
3765         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3766         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3767         (-[TestRunnerWKWebView dealloc]):
3768         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3769
3770         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3771         helper method when destroying the web view, and when resetting state between tests.
3772
3773         * WebKitTestRunner/ios/TestControllerIOS.mm:
3774         (WTR::TestController::platformResetStateToConsistentValues):
3775
3776         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3777
3778 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3779
3780         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3781         https://bugs.webkit.org/show_bug.cgi?id=190350
3782         <rdar://problem/45089503>
3783
3784         Reviewed by Geoffrey Garen.
3785
3786         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3787         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3788         (TEST):
3789         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3790         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3791         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3792         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3793         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3794         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3795         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3796         (runTest):
3797         (createDirectories):
3798         (TEST):
3799         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3800         (TEST):
3801         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3802         (TEST):
3803
3804 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3805
3806         Add support to WebPage for getting the contents as an attributed string.
3807         https://bugs.webkit.org/show_bug.cgi?id=195636
3808         rdar://problem/45055697
3809
3810         Reviewed by Tim Horton.
3811
3812         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3813         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3814
3815 2019-03-15  Chris Dumez  <cdumez@apple.com>
3816
3817         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3818         https://bugs.webkit.org/show_bug.cgi?id=195747
3819
3820         Reviewed by Geoff Garen.
3821
3822         Add API test coverage.
3823
3824         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3825
3826 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3827
3828         Unreviewed, rolling out r242952.
3829
3830         Causing API failures on iOS Simulator
3831
3832         Reverted changeset:
3833
3834         "[PSON] Make sure the WebProcessCache is leverage when
3835         relaunching a process after termination"
3836         https://bugs.webkit.org/show_bug.cgi?id=195747
3837         https://trac.webkit.org/changeset/242952
3838
3839 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3840
3841         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3842         https://bugs.webkit.org/show_bug.cgi?id=195740
3843
3844         Reviewed by Ross Kirsling.
3845
3846         window.open doesn't work for WebKitBrowserWindow because it is not
3847         implemented yet.
3848
3849         1. Implemented createNewPage callback of WKPageUIClient.
3850         2. Changed MainWindow to take a BrowserWindow factory function
3851           instead of BrowserWindowType to be flexible to create
3852           BrowserWindow with extra settings.
3853         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3854           because it is not relevant with MainWindow anymore.
3855
3856         * MiniBrowser/win/Common.cpp:
3857         (parseCommandLine):
3858         * MiniBrowser/win/Common.h:
3859         (CommandLineOptions::CommandLineOptions):
3860         * MiniBrowser/win/MainWindow.cpp:
3861         (MainWindow::MainWindow):
3862         (MainWindow::create):
3863         (MainWindow::init):
3864         (MainWindow::WndProc):
3865         * MiniBrowser/win/MainWindow.h:
3866         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3867         (PrintWebUIDelegate::createWebViewWithRequest):
3868         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3869         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3870         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3871         (WebKitBrowserWindow::updateProxySettings):
3872         (WebKitBrowserWindow::createNewPage):
3873         * MiniBrowser/win/WebKitBrowserWindow.h:
3874         * MiniBrowser/win/WinMain.cpp:
3875         (wWinMain):
3876
3877 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3878
3879         Make it possible to test scrolling tree layer manipulation more easily
3880         https://bugs.webkit.org/show_bug.cgi?id=195780
3881
3882         Reviewed by Tim Horton.
3883         
3884         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3885         cuts off communication of scrolling tree scrolls back to the web process
3886         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3887         allows tests to trigger scrolls which run the scrolling tree layer positioning
3888         logic, but never get another commit from the web process that might mask
3889         scrolling tree bugs.
3890         
3891         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3892         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3893         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3894
3895         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3896         (WTR::UIScriptController::scrollUpdatesDisabled const):
3897         (WTR::UIScriptController::setScrollUpdatesDisabled):
3898         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3899         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3900         (WTR::UIScriptController::scrollUpdatesDisabled const):
3901         (WTR::UIScriptController::setScrollUpdatesDisabled):
3902         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3903         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3904         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3905         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3906         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3907         * WebKitTestRunner/ios/TestControllerIOS.mm:
3908         (WTR::TestController::platformResetStateToConsistentValues):
3909         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3910         (WTR::UIScriptController::scrollUpdatesDisabled const):
3911         (WTR::UIScriptController::setScrollUpdatesDisabled):
3912
3913 2019-03-14  Youenn Fablet  <youenn@apple.com>
3914
3915         Move IDB storage in private browsing mode to NetworkProcess
3916         https://bugs.webkit.org/show_bug.cgi?id=195602
3917
3918         Reviewed by Brady Eidson.
3919
3920         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3921         (TEST):
3922
3923 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3924
3925         [ews-build] Make descriptionDone messages more readable
3926         https://bugs.webkit.org/show_bug.cgi?id=195760
3927
3928         Reviewed by Lucas Forschler.
3929
3930         * BuildSlaveSupport/ews-build/steps.py:
3931         * BuildSlaveSupport/ews-build/steps_unittest.py:
3932
3933 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3934
3935         [ews-build] Generate status-bubble hover-over messages
3936         https://bugs.webkit.org/show_bug.cgi?id=195680
3937
3938         Reviewed by Lucas Forschler.
3939
3940         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3941         (StatusBubble):
3942         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3943         on hover-over.
3944         (StatusBubble._iso_time):
3945         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3946         hover-over message.
3947         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3948
3949 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3950
3951         [ews-app] Gracefully handle the case when state_string is None
3952         https://bugs.webkit.org/show_bug.cgi?id=195753
3953
3954         Reviewed by Lucas Forschler.
3955
3956         * BuildSlaveSupport/ews-app/ews/models/build.py:
3957         * BuildSlaveSupport/ews-app/ews/models/step.py:
3958
3959 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3960
3961         [ews-app] Status bubble display pending for currently running build step
3962         https://bugs.webkit.org/show_bug.cgi?id=195744
3963
3964         Reviewed by Lucas Forschler.
3965
3966         * BuildSlaveSupport/ews-build/events.py:
3967         (Events.stepStarted): If state_string is pending, replace it with step name.
3968
3969 2019-03-14  Chris Dumez  <cdumez@apple.com>
3970
3971         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3972         https://bugs.webkit.org/show_bug.cgi?id=195750
3973
3974         Reviewed by Geoffrey Garen.
3975
3976         Add API test coverage.
3977
3978         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3979         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3980         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3981         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3982
3983 2019-03-14  Chris Dumez  <cdumez@apple.com>
3984
3985         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3986         https://bugs.webkit.org/show_bug.cgi?id=195747
3987
3988         Reviewed by Geoff Garen.
3989
3990         Add API test coverage.
3991
3992         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3993
3994 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3995
3996         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3997         https://bugs.webkit.org/show_bug.cgi?id=195725
3998         <rdar://problem/48545062>
3999
4000         Reviewed by Tim Horton.
4001
4002         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
4003         handler is nil.
4004
4005         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4006         (TestWebKitAPI::TEST):
4007
4008 2019-03-13  Sam Weinig  <sam@webkit.org>
4009
4010         Add utility function to allow easy reverse range-based iteration of a container
4011         https://bugs.webkit.org/show_bug.cgi?id=195542
4012
4013         Reviewed by Antti Koivisto.
4014
4015         * TestWebKitAPI/CMakeLists.txt:
4016         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4017         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
4018         (TestWebKitAPI::TEST):
4019         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
4020
4021 2019-03-13  Chris Dumez  <cdumez@apple.com>
4022
4023         Use a ServiceWorker process per registrable domain
4024         https://bugs.webkit.org/show_bug.cgi?id=195649
4025
4026         Reviewed by Youenn Fablet.
4027
4028         Update API test coverage.
4029
4030         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4031
4032 2019-03-13  Chris Dumez  <cdumez@apple.com>
4033
4034         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
4035         https://bugs.webkit.org/show_bug.cgi?id=195684
4036         <rdar://problem/48294714>
4037
4038         Reviewed by Antti Koivisto.
4039
4040         Add API test coverage.
4041
4042         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4043
4044 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4045
4046         [ews-app] Remove unused patch view
4047         https://bugs.webkit.org/show_bug.cgi?id=195669
4048
4049         Reviewed by Lucas Forschler.
4050
4051         * BuildSlaveSupport/ews-app/ews/urls.py:
4052         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
4053
4054 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4055
4056         [ews-app] Use Buildbot result code variables
4057         https://bugs.webkit.org/show_bug.cgi?id=195668
4058
4059         Reviewed by Alexey Proskuryakov.
4060
4061         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4062         (Buildbot): Added Buildbot result code variables.
4063         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4064         (StatusBubble._build_bubble): Used Buildbot result code variables.
4065
4066 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
4067
4068         [Flatpak] Expand submodule recursively
4069         https://bugs.webkit.org/show_bug.cgi?id=195672
4070
4071         Building WPE with flatpak was impossible without that as it was raising an exception.
4072         Also update wpebackend-fdo to match what is built in jhbuild
4073
4074         Reviewed by Philippe Normand.
4075
4076         * flatpak/flatpakutils.py:
4077         (expand_submodules_recurse):
4078         (expand_manifest):
4079         * flatpak/org.webkit.WPEModules.yaml:
4080
4081 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4082
4083         [ews-app] status bubble should be hidden for certain builds
4084         https://bugs.webkit.org/show_bug.cgi?id=194597
4085
4086         Reviewed by Dewei Zhu.
4087
4088         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4089         (StatusBubble._build_bubble):
4090         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
4091         because the patch didn't have relevant changes.
4092         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
4093         in production yet.
4094
4095 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4096
4097         [Win] Fix a slew of simple clang-cl warnings.
4098         https://bugs.webkit.org/show_bug.cgi?id=195652
4099
4100         Reviewed by Don Olmstead.
4101
4102         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4103         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
4104
4105 2019-03-12  Justin Fan  <justin_fan@apple.com>
4106
4107         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4108         https://bugs.webkit.org/show_bug.cgi?id=195518
4109         <rdar://problem/46322356>
4110
4111         Reviewed by Myles C. Maxfield.
4112
4113         * DumpRenderTree/DerivedSources-input.xcfilelist:
4114         * DumpRenderTree/DerivedSources-output.xcfilelist:
4115
4116 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4117
4118         Unreviewed, rolling out r242825.
4119         https://bugs.webkit.org/show_bug.cgi?id=195648
4120
4121         "Broke webkitpy tests with my change to
4122         lldb_dump_class_layout.py" (Requested by rmorisset on
4123         #webkit).
4124
4125         Reverted changeset:
4126
4127         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4128         classes with suspicious padding"
4129         https://bugs.webkit.org/show_bug.cgi?id=195573
4130         https://trac.webkit.org/changeset/242825
4131
4132 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4133
4134         [ews-build] Show status bubbles while the patch is waiting in queue
4135         https://bugs.webkit.org/show_bug.cgi?id=195618
4136
4137         Reviewed by Lucas Forschler.
4138
4139         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4140         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4141         enabled in initial deployment.
4142         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4143         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4144         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4145         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4146         (StatusBubble._build_bubbles_for_patch):
4147
4148 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4149
4150         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
4151         https://bugs.webkit.org/show_bug.cgi?id=195573
4152
4153         Reviewed by Simon Fraser.
4154
4155         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
4156
4157         * Scripts/dump-class-layout:
4158         (main):
4159         * lldb/lldb_dump_class_layout.py:
4160         (ClassLayout.__init__):
4161         (ClassLayout._compute_padding_recursive):
4162         (LLDBDebuggerInstance.dump_layout_for_classname):
4163         (LLDBDebuggerInstance):
4164         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
4165         (LLDBDebuggerInstance.layout_for_classname): Deleted.
4166
4167 2019-03-12  Chris Dumez  <cdumez@apple.com>
4168
4169         Device Orientation access permission should be denied unless explicitly granted by the client
4170         https://bugs.webkit.org/show_bug.cgi?id=195625
4171
4172         Reviewed by Youenn Fablet.
4173
4174         add API test coverage.
4175
4176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4177         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
4178         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
4179         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
4180         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4181         (runDeviceOrientationTest):
4182         (TEST):
4183         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4184         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4185
4186 2019-03-12  Jer Noble  <jer.noble@apple.com>
4187
4188         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
4189         https://bugs.webkit.org/show_bug.cgi?id=195137
4190         <rdar://problem/48810307>
4191
4192         Reviewed by Eric Carlson.
4193
4194         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
4195         (TestWebKitAPI::TEST):
4196
4197 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4198
4199         [ews-build] Change urls from uat to production
4200         https://bugs.webkit.org/show_bug.cgi?id=195566
4201
4202         Reviewed by Lucas Forschler.
4203
4204         * BuildSlaveSupport/ews-app/ews/config.py:
4205         * BuildSlaveSupport/ews-build/events.py:
4206         * BuildSlaveSupport/ews-build/steps.py:
4207
4208 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4209
4210         [ews-build] change max_builds for local-worker to 1
4211         https://bugs.webkit.org/show_bug.cgi?id=195568
4212
4213         Reviewed by Lucas Forschler.
4214
4215         * BuildSlaveSupport/ews-build/loadConfig.py:
4216
4217 2019-03-12  Tim Horton  <timothy_horton@apple.com>
4218
4219         Fix the build
4220
4221         * TestRunnerShared/spi/PencilKitTestSPI.h:
4222         * TestWebKitAPI/ios/PencilKitTestSPI.h:
4223
4224 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
4225
4226         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
4227         https://bugs.webkit.org/show_bug.cgi?id=194131
4228
4229         Reviewed by Michael Catanzaro.
4230
4231         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
4232         (uriChanged):
4233         (testUnfinishedSubresourceLoad):
4234         (serverCallback):
4235         (beforeAll):
4236
4237 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4238
4239         WTF::Expected should use std::addressof instead of operator&
4240         https://bugs.webkit.org/show_bug.cgi?id=195604
4241
4242         Reviewed by Myles Maxfield.
4243
4244         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4245         (TestWebKitAPI::Unique::Unique):
4246         (TestWebKitAPI::Unique::operator&):
4247         (TestWebKitAPI::TEST):
4248
4249 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
4250
4251         Add Optional to Forward.h.
4252         https://bugs.webkit.org/show_bug.cgi?id=195586
4253
4254         Reviewed by Darin Adler.
4255
4256         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
4257         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
4258         Remove unnecessary includes from headers.
4259
4260 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
4261
4262         Add testing API to hit-test and scroll overflow scrollers
4263         https://bugs.webkit.org/show_bug.cgi?id=195278
4264
4265         Reviewed by Antti Koivisto.
4266         
4267         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
4268         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
4269         
4270         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
4271
4272         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4273         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4274         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4275         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4276         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4277         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4278         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4279         (WTR::enclosingScrollViewIncludingSelf):
4280         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
4281
4282 2019-03-11  Tim Horton  <timothy_horton@apple.com>
4283
4284         API test WebKit.RequestTextInputContext fails on iOS
4285         https://bugs.webkit.org/show_bug.cgi?id=195585
4286
4287         Reviewed by Wenson Hsieh and Simon Fraser.
4288
4289         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
4290         (applyStyle):
4291         (TEST):
4292         Add a viewport, so that the coordinates match up on iOS.
4293         Scroll by moving the UIScrollView's contentOffset.
4294
4295 2019-03-11  Chris Dumez  <cdumez@apple.com>
4296
4297         Assert in WebPageProxy::suspendCurrentPageIfPossible()
4298         https://bugs.webkit.org/show_bug.cgi?id=195506
4299         <rdar://problem/48733477>
4300
4301         Reviewed by Alex Christensen.
4302
4303         Add API test coverage.
4304
4305         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4306
4307 2019-03-11  Shawn Roberts  <sroberts@apple.com>
4308
4309         Adding myself to contributors.json
4310
4311         Unreviewed, addming myself to contributors.json .
4312
4313         * Scripts/webkitpy/common/config/contributors.json:
4314
4315 2019-03-11  Alex Christensen  <achristensen@webkit.org>
4316
4317         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
4318         https://bugs.webkit.org/show_bug.cgi?id=195511
4319         <rdar://problem/44873269>
4320
4321         Reviewed by Darin Adler.
4322
4323         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm: