Extra logging for crash reason
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
2
3         Extra logging for crash reason
4         https://bugs.webkit.org/show_bug.cgi?id=160943
5
6         Reviewed by Alexey Proskuryakov.
7
8         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
9
10         * Scripts/webkitpy/port/server_process.py:
11         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
12         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
13         (ServerProcess.has_crashed): Ditto.
14
15 2016-08-17  Dan Bernstein  <mitz@apple.com>
16
17         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
18         https://bugs.webkit.org/show_bug.cgi?id=160938
19         <rdar://problem/27876652>
20
21         Reviewed by Anders Carlsson.
22
23         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
25         (TestWebKitAPI::TEST):
26
27 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
28
29         AX: Support abbreviations in iOS
30         https://bugs.webkit.org/show_bug.cgi?id=160907
31
32         Reviewed by Joanmarie Diggs.
33
34         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
35         (AccessibilityUIElement::stringAttributeValue):
36         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
37         (WTR::AccessibilityUIElement::stringAttributeValue):
38
39 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
40
41         [EFL] Bump efl version from 1.17 to 1.18
42         https://bugs.webkit.org/show_bug.cgi?id=160899
43
44         Reviewed by Antonio Gomes.
45
46         To use efl-1.18, EFL port needs to update install dependencies as well.
47
48         * efl/install-dependencies:
49         * efl/jhbuild.modules:
50
51 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
52
53         [Win] Add tests for linked fonts.
54         https://bugs.webkit.org/show_bug.cgi?id=160898
55
56         Reviewed by Brent Fulgham.
57
58         Add tests for https://trac.webkit.org/changeset/204502.
59
60         * TestWebKitAPI/PlatformWin.cmake:
61         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
62         (TestWebKitAPI::TEST):
63
64 2016-08-16  Daniel Bates  <dabates@apple.com>
65
66         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
67         https://bugs.webkit.org/show_bug.cgi?id=160924
68
69         Reviewed by Stephanie Lewis.
70
71         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
72         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
73         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
74         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
75         object that mocks out the file system and SCM operations.
76
77         * Scripts/VCSUtils.pm:
78         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
79         * Scripts/prepare-ChangeLog:
80         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
81         abstracting the logic to query the file system and SCM into functions on a delegate object that
82         we pass to it.
83         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
84         (diffHeaderFormat): Deleted.
85
86 2016-08-16  Alex Christensen  <achristensen@webkit.org>
87
88         URLParser should parse URLs without credentials
89         https://bugs.webkit.org/show_bug.cgi?id=160913
90
91         Reviewed by Brady Eidson.
92
93         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
94         (TestWebKitAPI::s):
95         (TestWebKitAPI::checkURL):
96         (TestWebKitAPI::TEST_F):
97
98 2016-08-16  Anders Carlsson  <andersca@apple.com>
99
100         Add WTF::ScopeExit
101         https://bugs.webkit.org/show_bug.cgi?id=160908
102
103         Reviewed by Geoffrey Garen.
104
105         * TestWebKitAPI/CMakeLists.txt:
106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
107         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
108         (TestWebKitAPI::TEST):
109
110 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
111
112         EWS logs file are rotated too quickly
113         https://bugs.webkit.org/show_bug.cgi?id=160724
114
115         Reviewed by Daniel Bates.
116
117         Currently we are rotating the log file after 10 iterations of queue. If the queue
118         doesn't have any pending patches, these iterations result in very small amount of 
119         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
120         This results in a lot of log files in a day. This patch ensures that we rotate the
121         log file when its file size is greater than or equal to 100 KB.
122
123         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
124
125 2016-08-16  Daniel Bates  <dabates@apple.com>
126
127         WKSI static library should be named by major iOS revision, not individual updates
128         https://bugs.webkit.org/show_bug.cgi?id=160727
129         <rdar://problem/22274848>
130
131         Reviewed by Alexey Proskuryakov.
132
133         * DumpRenderTree/mac/Configurations/Base.xcconfig:
134         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
135         * Scripts/copy-webkitlibraries-to-product-directory:
136         * WebKitTestRunner/Configurations/Base.xcconfig:
137         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
138
139 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
140
141         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
142         https://bugs.webkit.org/show_bug.cgi?id=160909
143
144         Reviewed by Enrica Casucci.
145         
146         Add functions to UIScriptController to dismiss the form accessory view for iOS,
147         and to programmatically pick a row from a <select> picker.
148
149         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
150         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
151         (WTR::UIScriptController::dismissFormAccessoryView):
152         (WTR::UIScriptController::selectFormAccessoryPickerRow):
153         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
154         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
155         (WTR::UIScriptController::dismissFormAccessoryView):
156         (WTR::UIScriptController::selectFormAccessoryPickerRow):
157
158 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
159
160         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
161         https://bugs.webkit.org/show_bug.cgi?id=160878
162
163         Reviewed by Tim Horton.
164         
165         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
166         now that we have the ability to run tests in the iPad simulator.
167
168         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
169         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
170         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
171         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
172         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
173         * WebKitTestRunner/ios/TestControllerIOS.mm:
174         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
175         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
176         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
177         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
178
179 2016-08-15  Anders Carlsson  <andersca@apple.com>
180
181         Add an address-of operator to RetainPtr
182         https://bugs.webkit.org/show_bug.cgi?id=160879
183
184         Reviewed by Tim Horton.
185
186         Test HashMap and HashSet with an object whose operator& is deleted.
187
188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
189         Sort the Xcode project.
190
191         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
192         (DeletedAddressOfOperator::DeletedAddressOfOperator):
193         (DeletedAddressOfOperator::value):
194         (DeletedAddressOfOperator::operator==):
195         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
196         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
197         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
198         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
199         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
200         (TestWebKitAPI::TEST):
201         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
202         (TestWebKitAPI::TEST):
203
204 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
205
206         False crashes in fast/text/emoji-gender-* tests
207         https://bugs.webkit.org/show_bug.cgi?id=160779
208
209         Reviewed by Alexey Proskuryakov.
210
211         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
212
213         * Scripts/webkitpy/port/driver.py:
214         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
215         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
216         * Scripts/webkitpy/port/server_process.py:
217         (ServerProcess.write): Allow caller to disable crash flag on exception.
218
219 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
220
221         webkitpy error in TestRunResults.merge()
222         https://bugs.webkit.org/show_bug.cgi?id=160882
223
224         Reviewed by Daniel Bates.
225         
226         The argument to TestRunResults.merge() can be None if there are no device-specifc
227         initial results or retry results in Manager.run(), so just return early in that case.
228
229         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
230         (TestRunResults.merge):
231
232 2016-08-15  Sam Weinig  <sam@webkit.org>
233
234         Speed up compile times by not including wtf/Variant.h so much
235         https://bugs.webkit.org/show_bug.cgi?id=160847
236
237         Reviewed by Alex Christensen and Saam Barati.
238
239         * TestWebKitAPI/Tests/WTF/Variant.cpp:
240         (TestWebKitAPI::TEST):
241         Explicitly use std::experimental::variant.
242
243 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
244
245         Allow a port to run tests with a custom device setup
246         https://bugs.webkit.org/show_bug.cgi?id=160833
247
248         Reviewed by Daniel Bates.
249
250         These changes allow the IOSSimulator port to run tests in iPad mode.
251
252         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
253         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
254         a custom device will be collected into a set, and run in that device's environment after
255         the other tests have run.
256
257         * Scripts/webkitpy/layout_tests/controllers/manager.py:
258         (Manager._custom_device_for_test): If the test contains a directory matching a
259         custom device suffix, return that custom device.
260         (Manager._set_up_run): Push the custom device class, if any, into options so
261         that the Worker can get to it.
262         (Manager.run): Go through the list of tests, and break it down into device-generic
263         tests, and tests for each device class. _run_test_subset is then called for
264         each collection of tests, and the results merged.
265         (Manager._run_test_subset): Some lines unwrapped.
266         (Manager._end_test_run):
267         (Manager._run_tests):
268         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
269         (SingleTestRunner.__init__): Unwrapped a line.
270         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
271         (TestRunResults.merge): Add this function to merge TestRunResults
272         * Scripts/webkitpy/layout_tests/views/printing.py:
273         (Printer.print_workers_and_shards): Print the custom device, if any.
274         * Scripts/webkitpy/port/base.py:
275         (Port): Base port has empty array of custom devices.
276         (Port.setup_test_run): Add device_class argument.
277         * Scripts/webkitpy/port/driver.py:
278         (DriverInput.__repr__):
279         (Driver.check_driver.implementation):
280         * Scripts/webkitpy/port/efl.py:
281         (EflPort.setup_test_run):
282         * Scripts/webkitpy/port/gtk.py:
283         (GtkPort.setup_test_run):
284         * Scripts/webkitpy/port/ios.py:
285         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
286         (IOSSimulatorPort.__init__):
287         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
288         based on the custom device class.
289         (IOSSimulatorPort._set_device_class):
290         (IOSSimulatorPort._create_simulators): Factor some code into this function.
291         (IOSSimulatorPort.setup_test_run):
292         (IOSSimulatorPort.testing_device):
293         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
294         seemed wrong for this function. That was moved to setup_test_run().
295         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
296         but this happened too early, before we knew which kind of devices to create. Devices
297         are now created in setup_test_run().
298         * Scripts/webkitpy/port/win.py:
299         (WinPort.setup_test_run):
300
301 2016-08-15  Daniel Bates  <dabates@apple.com>
302
303         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
304         private frameworks and libraries
305         https://bugs.webkit.org/show_bug.cgi?id=155931
306         <rdar://problem/25807989>
307
308         Reviewed by Dan Bernstein.
309
310         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
311         where X is the major version of the active iOS SDK.
312
313         * DumpRenderTree/mac/Configurations/Base.xcconfig:
314         * WebKitTestRunner/Configurations/Base.xcconfig:
315
316 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
317
318         Add a setting and preferences to enable visual viewport mode
319         https://bugs.webkit.org/show_bug.cgi?id=160843
320
321         Reviewed by Sam Weinig.
322         
323         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
324
325         * MiniBrowser/mac/SettingsController.h:
326         * MiniBrowser/mac/SettingsController.m:
327         (-[SettingsController _populateMenu]):
328         (-[SettingsController validateMenuItem:]):
329         (-[SettingsController visualViewportEnabled]):
330         (-[SettingsController toggleVisualViewportEnabled:]):
331         * MiniBrowser/mac/WK1BrowserWindowController.m:
332         (-[WK1BrowserWindowController didChangeSettings]):
333         * MiniBrowser/mac/WK2BrowserWindowController.m:
334         (-[WK2BrowserWindowController didChangeSettings]):
335
336 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
337
338         Allow using make-dist with non-GTK ports
339         https://bugs.webkit.org/show_bug.cgi?id=160842
340
341         Reviewed by Michael Catanzaro.
342
343         This patch adds support for setting base name of tarball and argument
344         passed to cmake's -DPORT= via command line arguments.
345
346         * gtk/make-dist.py:
347         (Distcheck.configure):
348         (Distcheck.check):
349         (get_tarball_root_and_output_filename_from_arguments):
350
351 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
352
353         [GTK] Install script lacks gstreamer related dependencies
354         https://bugs.webkit.org/show_bug.cgi?id=160814
355
356         Reviewed by Carlos Garcia Campos.
357
358         * gtk/install-dependencies: Fedora case had already listed this dependencies,
359         but both Arch and Debian/Ubuntu were missing them.
360
361 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
362
363         make-dist.py should not allow unknown rules in manifest
364         https://bugs.webkit.org/show_bug.cgi?id=160841
365
366         Reviewed by Carlos Garcia Campos.
367
368         * gtk/make-dist.py:
369         (Manifest.process_line):
370
371 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
372
373         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
374         https://bugs.webkit.org/show_bug.cgi?id=160809
375
376         Reviewed by Carlos Garcia Campos.
377
378         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
379         case, and use it also for the new package names of libpng and libgeoclue.
380         * gtk/install-dependencies: Ditto.
381
382 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
383
384         Skip to check directories existence in build-webkit
385         https://bugs.webkit.org/show_bug.cgi?id=160691
386
387         Reviewed by Alex Christensen.
388
389         CMake checks if directories are there itself. So CMake ports
390         don't need to check it in the build-webkit script.
391
392         * Scripts/build-webkit:
393         * Scripts/webkitdirs.pm:
394         (determineSourceDir):
395         (isCMakeBuild):
396
397 2016-08-12  Alex Christensen  <achristensen@webkit.org>
398
399         Make URLParser work with URLs missing URL parts
400         https://bugs.webkit.org/show_bug.cgi?id=160824
401
402         Reviewed by Brady Eidson.
403
404         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
405         (TestWebKitAPI::s):
406         (TestWebKitAPI::checkURL):
407         (TestWebKitAPI::TEST_F):
408         (TestWebKitAPI::eq): Deleted.
409
410 2016-08-12  John Wilander  <wilander@apple.com>
411
412         Add HashCountedSet API tests to TestWTFLibrary target
413         https://bugs.webkit.org/show_bug.cgi?id=160815
414
415         Reviewed by Alex Christensen.
416
417         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
418             Added HashCountedSet.cpp and sorted the file reference section
419             according to UNIX sort.
420
421 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
422
423         run-benchmark should run JetStream 1.1 instead of 1.0.1
424         https://bugs.webkit.org/show_bug.cgi?id=160816
425
426         Reviewed by Filip Pizlo.
427
428         Use the latest JetStream 1.1 in run-benchmark.
429
430         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
431         (BenchmarkBuilder.__exit__):
432         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
433         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
434         change to JetStream directory.
435
436 2016-08-12  Alex Christensen  <achristensen@webkit.org>
437
438         Initial URLParser implementation
439         https://bugs.webkit.org/show_bug.cgi?id=160811
440
441         Reviewed by Brady Eidson.
442
443         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
444         (TestWebKitAPI::eq):
445         (TestWebKitAPI::checkURL):
446         (TestWebKitAPI::TEST_F):
447
448 2016-08-12  Brady Eidson  <beidson@apple.com>
449
450         Fix the 32-bit Mac build after:
451         Add WK2 ExperimentalFeature support to MiniBrowser
452         https://bugs.webkit.org/show_bug.cgi?id=160788
453
454         Unreviewed.
455
456         Sprinkle "#if WK_API_ENABLED"s liberally.
457         
458         * MiniBrowser/mac/AppDelegate.m:
459         (defaultConfiguration):
460         * MiniBrowser/mac/SettingsController.m:
461         (-[SettingsController _populateMenu]):
462         (-[SettingsController validateMenuItem:]):
463
464 2016-08-12  Philippe Normand  <pnormand@igalia.com>
465
466         [GStreamer][OWR] Video rendering fixes
467         https://bugs.webkit.org/show_bug.cgi?id=160764
468
469         Reviewed by Xabier Rodriguez-Calvar.
470
471         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
472
473 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
474
475         Add missing return statement in convertFast function added in r204376.
476
477         Unreviewed.
478
479         * Scripts/webkitpy/common/system/path.py:
480         (_CygPath.convertFast):
481
482 2016-08-11  Brady Eidson  <beidson@apple.com>
483
484         Add WK2 ExperimentalFeature support to MiniBrowser.
485         https://bugs.webkit.org/show_bug.cgi?id=160788
486
487         Reviewed by Alex Christensen.
488
489         * MiniBrowser/mac/AppDelegate.h:
490         * MiniBrowser/mac/AppDelegate.m:
491         (defaultConfiguration):
492         (defaultPreferences):
493         
494         * MiniBrowser/mac/SettingsController.m:
495         (-[SettingsController _populateMenu]):
496         (-[SettingsController validateMenuItem:]):
497         (-[SettingsController toggleExperimentalFeature:]):
498
499 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
500
501         Keep EWS logs for longer
502         https://bugs.webkit.org/show_bug.cgi?id=160776
503
504         Reviewed by Daniel Bates.
505
506         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
507
508 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
509
510         iOS DRT/WTR project cleanup
511         https://bugs.webkit.org/show_bug.cgi?id=160778
512
513         Reviewed by Tim Horton.
514
515         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
516
517         Remove AppDelegate.* which were unused.
518
519         Exclude ios/Launch.storyboard on more platforms.
520
521         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
522         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
523         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
524         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
525         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
526         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
527         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
528
529 2016-08-11  Alex Christensen  <achristensen@webkit.org>
530
531         Fix Yosemite bots' cookie accept policies after r204365.
532         https://bugs.webkit.org/show_bug.cgi?id=160758
533
534         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
535         (TEST):
536         This makes the test fully clean up after itself.
537
538 2016-08-11  Alex Christensen  <achristensen@webkit.org>
539
540         Fix Yosemite bots' cookie accept policies after r204365.
541         https://bugs.webkit.org/show_bug.cgi?id=160758
542
543         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
544         (TEST):
545         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
546         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
547         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
548         causing any problems because there are no other API tests that do anything with cookies.
549         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
550         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
551         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
552
553 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
554
555         EWS should check if the patch is still valid before executing every major step
556         https://bugs.webkit.org/show_bug.cgi?id=160739
557         rdar://problem/27768813
558
559         Reviewed by Alexey Proskuryakov.
560
561         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
562         (CommitQueueTask.run): validate method is now executed in base class.
563         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
564         (EarlyWarningSystemTask.run): validate method is now executed in base class.
565         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
566         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
567         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
568         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
569         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
570         * Scripts/webkitpy/tool/commands/perfalizer.py:
571         (PerfalizerTask.validate): Added.
572         * Scripts/webkitpy/tool/commands/queues_unittest.py:
573         (test_manual_reject_during_processing): Updated test case.
574
575 2016-08-11  Alex Christensen  <achristensen@webkit.org>
576
577         Add URLParser stub
578         https://bugs.webkit.org/show_bug.cgi?id=160770
579
580         Reviewed by Sam Weinig.
581
582         * TestWebKitAPI/PlatformGTK.cmake:
583         * TestWebKitAPI/PlatformWin.cmake:
584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
585         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
586         (TestWebKitAPI::TEST_F):
587
588 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
589
590         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
591         https://bugs.webkit.org/show_bug.cgi?id=160761
592
593         Reviewed by Tim Horton.
594
595         Give iOS DRT a Launch storyboard.
596
597         Have it use a UIViewController so future forms testing works correctly.
598
599         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
600         can run in iPad mode.
601
602         Remove empty InfoPlist.strings files.
603
604         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
605         * DumpRenderTree/ios/Info.plist:
606         * DumpRenderTree/ios/Launch.storyboard: Added.
607         * DumpRenderTree/mac/DumpRenderTree.mm:
608         (createWebViewAndOffscreenWindow):
609         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
610         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
611         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
612         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
613
614 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
615
616         [Win] Unable to reliably run tests in parallel
617         https://bugs.webkit.org/show_bug.cgi?id=140914
618
619         Reviewed by Brent Fulgham.
620
621         The cygpath utility function can fail badly when running with multiple DumpRenderTree
622         processes. We can use string replacement to convert the Cygwin path to a Windows path
623         instead.
624
625         * Scripts/webkitpy/common/system/path.py:
626         (cygpathFast):
627         * Scripts/webkitpy/port/driver.py:
628         (Driver._command_from_driver_input):
629
630 2016-08-10  Alex Christensen  <achristensen@webkit.org>
631
632         Fix crash when changing cookie accept policy after r204327
633         https://bugs.webkit.org/show_bug.cgi?id=160758
634
635         Reviewed by Simon Fraser.
636
637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
638         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
639         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
640         (TEST):
641         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
642
643 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
644
645         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
646         https://bugs.webkit.org/show_bug.cgi?id=160757
647
648         Reviewed by Tim Horton.
649
650         When programmatically creating the test UIWindow, make a root UIViewController and parent
651         the WKWebView in its view. This makes the app more like a normal UIKit application.
652         
653         Move the WKWebView down 20px to avoid the status bar.
654         
655         Give the UIWindow a gray background so it's obvious where the window and view positioned.
656
657         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
658         
659         Remove duplicate references to Launch.storyboard.
660
661         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
662         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
663         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
664         (-[AppDelegate applicationWillResignActive:]): Deleted.
665         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
666         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
667         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
668         (-[AppDelegate applicationWillTerminate:]): Deleted.
669         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
670         (WTR::viewRectForWindowRect):
671         (WTR::PlatformWebView::PlatformWebView):
672         (WTR::PlatformWebView::setWindowFrame):
673
674 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
675
676         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
677         https://bugs.webkit.org/show_bug.cgi?id=160748
678
679         Reviewed by Tim Horton.
680         
681         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
682         opens the door for tests using other device sizes.
683
684         * WebKitTestRunner/ios/TestControllerIOS.mm:
685         (WTR::TestController::platformConfigureViewForTest):
686
687 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
688
689         Sort the feature flags in the FEATURE_DEFINES lines
690         https://bugs.webkit.org/show_bug.cgi?id=160742
691
692         Reviewed by Anders Carlsson.
693         
694         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
695
696 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
697
698         Logging and other minor improvements to iOS webkitpy
699         https://bugs.webkit.org/show_bug.cgi?id=160722
700
701         Reviewed by Dan Bates.
702
703         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
704         to make it easier to debug launching issues.
705
706         Have reset_preferences() reset the device, rather than just nuking the data
707         directory (which broke some versions of the simulator).
708
709         Make the Simulator.app launch in the background with open -g.
710
711         Wait for the simulator device to be in a known state in some more places.
712
713         * Scripts/webkitpy/port/ios.py:
714         (IOSSimulatorPort.setup_test_run):
715         (IOSSimulatorPort._quit_ios_simulator):
716         (IOSSimulatorPort.clean_up_test_run):
717         (IOSSimulatorPort.setup_environ_for_server):
718         (IOSSimulatorPort.reset_preferences):
719         * Scripts/webkitpy/xcode/simulator.py:
720         (Device.create):
721         (Device.delete):
722         (Device):
723         (Device.reset):
724         (Simulator.wait_until_device_is_booted):
725         (Simulator.wait_until_device_is_in_state):
726         (Simulator):
727         (Simulator.delete_device):
728         (Simulator.reset_device):
729         (Simulator.lookup_or_create_device):
730
731 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
732
733         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
734         https://bugs.webkit.org/show_bug.cgi?id=160697
735
736         Reviewed by Antonio Gomes.
737
738         * Scripts/webkitpy/port/base.py:
739         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
740         list of environment variables to copy.
741
742 2016-08-09  George Ruan  <gruan@apple.com>
743
744         Implement functionality of media capture on iOS
745         https://bugs.webkit.org/show_bug.cgi?id=158945
746         <rdar://problem/26893343>
747
748         Reviewed by Tim Horton.
749
750         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
751         Capture feature on iOS.
752
753 2016-08-09  Saam Barati  <sbarati@apple.com>
754
755         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
756         https://bugs.webkit.org/show_bug.cgi?id=160671
757         <rdar://problem/27756112>
758
759         Reviewed by Mark Lam.
760
761         * Scripts/run-jsc-stress-tests:
762
763 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
764
765         Make directory reading code in iOSSimulatorDevices() more strict
766         https://bugs.webkit.org/show_bug.cgi?id=160702
767
768         Reviewed by Tim Horton.
769
770         * Scripts/webkitdirs.pm:
771         (iOSSimulatorDevices):
772
773 2016-08-06  Sam Weinig  <sam@webkit.org>
774
775         Replace NodeOrString with std::variant<RefPtr<Node>, String>
776         https://bugs.webkit.org/show_bug.cgi?id=160638
777
778         Reviewed by Anders Carlsson.
779
780         * TestWebKitAPI/CMakeLists.txt:
781         * TestWebKitAPI/Tests/WTF/Variant.cpp:
782         Add additional tests for the initial state of std::variant and using
783         makeVisitor for visiting.
784
785 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
786
787         EWS logging should ensure the logging to file is stopped on queue termination
788         https://bugs.webkit.org/show_bug.cgi?id=160698
789         rdar://problem/24464570
790
791         Reviewed by Daniel Bates.
792
793         * Scripts/webkitpy/tool/bot/queueengine.py:
794         (QueueEngine._stopping): Stop logging to file on queue termination.
795         (QueueEngine._begin_logging): Configure the Python logger to log to file.
796         * Scripts/webkitpy/common/system/logutils.py:
797         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
798         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
799         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
800         * Scripts/webkitpy/tool/commands/queues.py:
801         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
802         (AbstractQueue.queue_log_path): Same.
803         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
804         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
805         which moved to QueueEngine now.
806         (PatchProcessingQueue.__init__): Same.
807         (CommitQueue.__init__): Same.
808         (AbstractReviewQueue.__init__): Same.
809         (StyleQueue.__init__): Same.
810         * Scripts/webkitpy/tool/commands/queues_unittest.py:
811         (TestCommitQueue): Removed host parameter.
812         (TestCommitQueue.__init__): Same.
813         (AbstractPatchQueueTest.test_next_patch): Same.
814         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
815         (test_commit_queue_failure): Same.
816         (mock_run_webkit_patch):
817         (MockCommitQueueTask.results_from_patch_test_run): Same.
818         (test_rollout_lands): Same.
819         (test_non_valid_patch): Same.
820         (test_auto_retry): Same.
821         (test_style_queue_with_watch_list_exception): Same.
822         (TestQueue.__init__): Deleted.
823         (TestReviewQueue.__init__): Deleted.
824         (TestFeederQueue.__init__): Deleted.
825
826 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
827
828         webkit-gtk tarball fails to build due to missing files
829         https://bugs.webkit.org/show_bug.cgi?id=160684
830
831         Reviewed by Alex Christensen.
832
833         * gtk/manifest.txt.in: Added back spi directories.
834
835 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
836
837         [GTK] Build the jhbuild with -O2 optimization level by default
838         https://bugs.webkit.org/show_bug.cgi?id=160544
839
840         Reviewed by Michael Catanzaro.
841
842         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
843         which don't increases the required disk space significatively and
844         provides better debug information than no passing it.
845
846 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
847
848         Allow more --cmakeargs option in build-jsc and build-webkit
849         https://bugs.webkit.org/show_bug.cgi?id=160340
850
851         Reviewed by Michael Catanzaro.
852
853         * Scripts/build-jsc:
854         * Scripts/build-webkit:
855
856 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
857
858         Do not check if WebKitLibraries folder exists on EFL and GTK
859         https://bugs.webkit.org/show_bug.cgi?id=160659
860
861         Reviewed by Csaba Osztrogonác.
862
863         Though WebKitLibraries is only needed by mac and win ports,
864         EFL and GTK ports have checked whether it exists.
865
866         * Scripts/build-webkit:
867
868 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
869
870         Some EWS console logs doesn't go to log file
871         https://bugs.webkit.org/show_bug.cgi?id=160585
872         rdar://problem/24464570
873
874         Reviewed by Daniel Bates.
875
876         * Scripts/webkitpy/common/system/logutils.py:
877         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
878         any possible overwriting.
879         * Scripts/webkitpy/common/system/filesystem.py:
880         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
881         * Scripts/webkitpy/common/system/filesystem_mock.py:
882         (MockFileSystem.open_text_file_for_writing): Same.
883         * Scripts/webkitpy/common/system/filesystem_unittest.py:
884         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
885         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
886         * Scripts/webkitpy/tool/commands/queues.py:
887         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
888         This will ensure that all the sub-modules inside webkitpy will log to file.
889
890 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
891
892         Have the iOS platform interit from the Apple platform in webkitpy
893         https://bugs.webkit.org/show_bug.cgi?id=160672
894
895         Reviewed by Dan Bates.
896         
897         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
898         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
899         ApplePort.
900         
901         Since WinPort also inherits from ApplePort, it needs to stub out some things
902         that are unavailable on Windows (leaks, sampling).
903         
904         Some SnowLeopard-related code and the associated test were removed.
905
906         * Scripts/webkitpy/port/apple.py:
907         (ApplePort.__init__):
908         (ApplePort):
909         (ApplePort._make_leak_detector):
910         (ApplePort.default_timeout_ms):
911         (ApplePort.supports_per_test_timeout):
912         (ApplePort.should_retry_crashes):
913         (ApplePort._generate_all_test_configurations):
914         (ApplePort.check_for_leaks):
915         (ApplePort.print_leaks_summary):
916         (ApplePort._path_to_webcore_library):
917         (ApplePort.show_results_html_file):
918         (ApplePort._merge_crash_logs):
919         (ApplePort._look_for_all_crash_logs_in_log_dir):
920         (ApplePort._get_crash_log):
921         (ApplePort.look_for_new_crash_logs):
922         (ApplePort.sample_process):
923         (ApplePort.sample_file_path):
924         (ApplePort.look_for_new_samples):
925         (ApplePort._path_to_helper):
926         (ApplePort.determine_full_port_name): Deleted.
927         * Scripts/webkitpy/port/ios.py:
928         (IOSSimulatorPort):
929         (IOSSimulatorPort.__init__):
930         (IOSSimulatorPort.default_timeout_ms): Deleted.
931         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
932         (IOSSimulatorPort.should_retry_crashes): Deleted.
933         (IOSSimulatorPort.check_for_leaks): Deleted.
934         (IOSSimulatorPort.print_leaks_summary): Deleted.
935         (IOSSimulatorPort._path_to_webcore_library): Deleted.
936         (IOSSimulatorPort.show_results_html_file): Deleted.
937         (IOSSimulatorPort.sample_file_path): Deleted.
938         (IOSSimulatorPort._merge_crash_logs): Deleted.
939         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
940         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
941         (IOSSimulatorPort.look_for_new_samples): Deleted.
942         (IOSSimulatorPort.sample_process): Deleted.
943         (IOSSimulatorPort._path_to_helper): Deleted.
944         (IOSSimulatorPort.make_command): Deleted.
945         * Scripts/webkitpy/port/mac.py:
946         (MacPort.__init__):
947         (MacPort.make_command):
948         (MacPort._build_java_test_support):
949         (MacPort): Deleted.
950         (MacPort.default_timeout_ms): Deleted.
951         (MacPort.supports_per_test_timeout): Deleted.
952         (MacPort.should_retry_crashes): Deleted.
953         (MacPort.default_child_processes): Deleted.
954         (MacPort.check_for_leaks): Deleted.
955         (MacPort.print_leaks_summary): Deleted.
956         (MacPort._path_to_webcore_library): Deleted.
957         (MacPort.show_results_html_file): Deleted.
958         (MacPort.sample_file_path): Deleted.
959         (MacPort._merge_crash_logs): Deleted.
960         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
961         (MacPort.look_for_new_crash_logs): Deleted.
962         (MacPort.look_for_new_samples): Deleted.
963         (MacPort.sample_process): Deleted.
964         (MacPort._path_to_helper): Deleted.
965         * Scripts/webkitpy/port/mac_unittest.py:
966         (MacTest.test_default_child_processes): Deleted.
967         * Scripts/webkitpy/port/win.py:
968         (WinPort.look_for_new_samples):
969         (WinPort):
970         (WinPort.sample_process):
971         (WinPort._make_leak_detector):
972         (WinPort.check_for_leaks):
973         (WinPort.print_leaks_summary):
974         (WinPort._path_to_webcore_library):
975
976 2016-08-08  Matt Baker  <mattbaker@apple.com>
977
978         Unreviewed: moved myself to the reviewers list.
979
980         * Scripts/webkitpy/common/config/contributors.json:
981
982 2016-08-08  Chris Dumez  <cdumez@apple.com>
983
984         Update API tests in mac/SetDocumentURI.mm after r204247
985         https://bugs.webkit.org/show_bug.cgi?id=160660
986
987         Reviewed by Alex Christensen.
988
989         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
990         (TestWebKitAPI::TEST):
991
992 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
993
994         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
995         https://bugs.webkit.org/show_bug.cgi?id=159827
996
997         Reviewed by Daniel Bates.
998
999         This change was spurred by a process hang which occurred between tests and did
1000         not produce a meaningful crashlog.
1001
1002         * Scripts/webkitpy/port/driver.py:
1003         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
1004
1005          * Scripts/webkitpy/port/ios.py:
1006         (IOSSimulatorPort):
1007         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
1008         * Scripts/webkitpy/port/mac.py:
1009         (MacPort):
1010         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
1011
1012         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
1013         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
1014
1015         * WebKitTestRunner/TestController.h:
1016         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
1017         * WebKitTestRunner/TestInvocation.cpp:
1018         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
1019
1020 2016-08-07  Dan Bernstein  <mitz@apple.com>
1021
1022         [Cocoa] Reply block leaks if the remote object doesn’t call it
1023         https://bugs.webkit.org/show_bug.cgi?id=160642
1024
1025         Reviewed by Sam Weinig.
1026
1027         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
1028         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1029         (TEST): Added a test case that checks that the reply block is released even when it’s not
1030           called.
1031         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1032         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
1033           calling the completion handler.
1034
1035 2016-08-07  Chris Dumez  <cdumez@apple.com>
1036
1037         Write API test to cover crash fix in r204135
1038         https://bugs.webkit.org/show_bug.cgi?id=160587
1039
1040         Reviewed by Darin Adler.
1041
1042         Add API test to cover crash fix in r204135. This reproduces the crash
1043         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1044         callback.
1045
1046         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1047         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1048         (TEST):
1049
1050 2016-08-06  Chris Dumez  <cdumez@apple.com>
1051
1052         Unreviewed, rolling out r204226.
1053
1054         Broke some API tests
1055
1056         Reverted changeset:
1057
1058         "Write API test to cover crash fix in r204135"
1059         https://bugs.webkit.org/show_bug.cgi?id=160587
1060         http://trac.webkit.org/changeset/204226
1061
1062 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
1063
1064         EWS Style Queue fails to process patches which fails validation
1065         https://bugs.webkit.org/show_bug.cgi?id=160632
1066
1067         Reviewed by Alexey Proskuryakov.
1068
1069         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1070         (StyleQueueTask.validate): Add more information about validation failure.
1071         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1072         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1073         (test_non_valid_patch): Add a unit test to test the above code path.
1074
1075 2016-08-06  Sam Weinig  <sam@webkit.org>
1076
1077         WTF needs a variant implementation
1078         https://bugs.webkit.org/show_bug.cgi?id=160618
1079
1080         Reviewed by Darin Adler.
1081
1082         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1083         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
1084         Add tests for the variant implementation.
1085
1086 2016-08-06  Chris Dumez  <cdumez@apple.com>
1087
1088         Write API test to cover crash fix in r204135
1089         https://bugs.webkit.org/show_bug.cgi?id=160587
1090
1091         Reviewed by Darin Adler.
1092
1093         Add API test to cover crash fix in r204135. This reproduces the crash
1094         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
1095         callback.
1096
1097         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1098         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
1099         (TEST):
1100
1101 2016-08-05  Tim Horton  <timothy_horton@apple.com>
1102
1103         run-api-tests should use a headed simulator
1104         https://bugs.webkit.org/show_bug.cgi?id=160611
1105
1106         Reviewed by Sam Weinig.
1107
1108         CADisplayLink doesn't work in a headless simulator, but is
1109         vital for the proper functioning of WebKit2 painting on iOS.
1110         So, we should not use a headless simulator.
1111
1112         * Scripts/run-api-tests:
1113         Launch a simulator app, don't just boot the simulator.
1114
1115         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1116         Re-enable a test that works now.
1117
1118 2016-08-05  Dan Bernstein  <mitz@apple.com>
1119
1120         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
1121         https://bugs.webkit.org/show_bug.cgi?id=160589
1122
1123         Reviewed by Tim Horton.
1124
1125         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1126         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
1127           blocks, which wasn’t caught because the test wasn’t run correctly.
1128         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1129         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
1130           added a test that sends over an NSRange.
1131         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1132         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
1133           handler with the range‘s location and length.
1134
1135 2016-08-05  Enrica Casucci  <enrica@apple.com>
1136
1137         Fixing tests failing after r204175.
1138
1139         Unreviewed.
1140
1141         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
1142
1143 2016-08-05  Enrica Casucci  <enrica@apple.com>
1144
1145         Build fix after 204053.
1146
1147         Unreviewed.
1148
1149         * TestWebKitAPI/Configurations/Base.xcconfig:
1150         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1151         (-[MockContentFilterEnabler initWithCoder:]):
1152         (-[MockContentFilterEnabler dealloc]):
1153
1154 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
1155
1156         Print test name in "Last character read from DRT..." error message.
1157         https://bugs.webkit.org/show_bug.cgi?id=160559
1158
1159         Reviewed by Michael Catanzaro.
1160
1161         * Scripts/webkitpy/port/driver.py:
1162         (Driver.run_test):
1163         (Driver._read_first_block):
1164         (Driver._read_optional_image_block):
1165         (Driver._read_block):
1166         * Scripts/webkitpy/port/driver_unittest.py:
1167         (DriverTest.test_read_block):
1168         (DriverTest.test_read_binary_block):
1169         (DriverTest.test_read_base64_block):
1170
1171 2016-08-05  Commit Queue  <commit-queue@webkit.org>
1172
1173         Unreviewed, rolling out r204123.
1174         https://bugs.webkit.org/show_bug.cgi?id=160597
1175
1176         Caused layout test timeouts on Windows. (Requested by perarne
1177         on #webkit).
1178
1179         Reverted changeset:
1180
1181         "[Win] Unable to reliably run tests in parallel"
1182         https://bugs.webkit.org/show_bug.cgi?id=140914
1183         http://trac.webkit.org/changeset/204123
1184
1185 2016-08-04  Saam Barati  <sbarati@apple.com>
1186
1187         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
1188         https://bugs.webkit.org/show_bug.cgi?id=151241
1189
1190         Reviewed by Benjamin Poulain.
1191
1192         * Scripts/run-jsc-stress-tests:
1193
1194 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
1195
1196         UI improvements to Flakiness Dashboard.
1197         https://bugs.webkit.org/show_bug.cgi?id=153295
1198
1199         Reviewed by Alexey Proskuryakov.
1200
1201         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1202         (td.options-container): Center text in most fields.
1203         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1204         (createBugHTML): Text/Grammar updates.
1205         (tableHeaders): Ditto.
1206         (htmlForSingleTestRow): Ditto.
1207         (headerForTestTableHtml): Ditto.
1208         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
1209         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
1210
1211 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1212
1213         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
1214         https://bugs.webkit.org/show_bug.cgi?id=160518
1215
1216         Reviewed by Michael Catanzaro.
1217
1218         * Scripts/webkitpy/thirdparty/__init__.py:
1219         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
1220         * gtk/install-dependencies:
1221
1222 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
1223
1224         Optimize bot watcher's dashboard a little
1225         https://bugs.webkit.org/show_bug.cgi?id=160515
1226         rdar://problem/26096900
1227
1228         Reviewed by Lucas Forschler.
1229
1230         Made re-sorting after loading an iteration more efficient.
1231
1232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1233         (BuildbotIteration.prototype._updateWithData):
1234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1235         (BuildbotQueue.prototype.updateIterationPosition):
1236
1237 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
1238
1239         [Win] Unable to reliably run tests in parallel
1240         https://bugs.webkit.org/show_bug.cgi?id=140914
1241
1242         Reviewed by Brent Fulgham.
1243
1244         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1245         processes. We can use string replacement to convert the Cygwin path to a Windows path
1246         instead.
1247  
1248         * Scripts/webkitpy/common/system/path.py:
1249         (cygpathFast):
1250         * Scripts/webkitpy/port/driver.py:
1251         (Driver._command_from_driver_input):
1252
1253 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
1254
1255         Document instructions for increasing process and file limits
1256         https://bugs.webkit.org/show_bug.cgi?id=160528
1257         rdar://problem/24777576
1258
1259         Reviewed by Alexey Proskuryakov.
1260
1261         * Scripts/webkitpy/port/ios.py:
1262         (IOSSimulatorPort.default_child_processes):
1263
1264 2016-08-03  Anders Carlsson  <andersca@apple.com>
1265
1266         Remove the Objective-C bindings generator
1267         https://bugs.webkit.org/show_bug.cgi?id=160526
1268
1269         Reviewed by Sam Weinig.
1270
1271         * Scripts/run-bindings-tests:
1272         Update test.
1273
1274 2016-08-03  Tim Horton  <timothy_horton@apple.com>
1275
1276         Revise a TestWebKitAPI comment to mention the actual underlying problem
1277
1278         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1279         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
1280
1281 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1282
1283         Benchmark test content-animation timeouts always
1284         https://bugs.webkit.org/show_bug.cgi?id=160057
1285
1286         Reviewed by Simon Fraser.
1287
1288         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
1289         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1290         (start):
1291
1292 2016-08-02  Nan Wang  <n_wang@apple.com>
1293
1294         AX: Simulated touch events are not working on iOS
1295         https://bugs.webkit.org/show_bug.cgi?id=160395
1296         <rdar://problem/27633597>
1297
1298         Reviewed by Chris Fleizach.
1299
1300         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1301         (WTR::AccessibilityUIElement::press):
1302         (WTR::AccessibilityUIElement::setSelectedChild):
1303
1304 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
1305
1306         run-javascriptcore-tests should accept multiple --extra-tests
1307         https://bugs.webkit.org/show_bug.cgi?id=160486
1308
1309         Reviewed by Saam Barati.
1310         
1311         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
1312         test suites. This does it by using GetOpt::Long's array support.
1313
1314         * Scripts/run-javascriptcore-tests:
1315         (runJSCStressTests):
1316
1317 2016-08-02  Enrica Casucci  <enrica@apple.com>
1318
1319         Allow building with content filtering disabled.
1320         https://bugs.webkit.org/show_bug.cgi?id=160454
1321
1322         Reviewed by Simon Fraser.
1323
1324         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1325
1326 2016-08-02  Brady Eidson  <beidson@apple.com>
1327
1328         Removing IndexedDB WebsiteData can fail for some users.
1329         https://bugs.webkit.org/show_bug.cgi?id=160463
1330
1331         Reviewed by Alex Christensen.
1332
1333         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1334
1335 2016-08-01  Alex Christensen  <achristensen@webkit.org>
1336
1337         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
1338         https://bugs.webkit.org/show_bug.cgi?id=160437
1339         <rdar://problem/27578272>
1340
1341         Reviewed by Brady Eidson.
1342
1343         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1344         (-[DownloadDelegate _download:didReceiveResponse:]):
1345         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1346         (runTest):
1347         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
1348
1349 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1350
1351         [Tools] The GDB backtrace report tool don't checks the gdb return code.
1352         https://bugs.webkit.org/show_bug.cgi?id=160414
1353
1354         Reviewed by Michael Catanzaro.
1355
1356         * Scripts/webkitpy/port/linux_get_crash_log.py:
1357         (GDBCrashLogGenerator._wait_for_corefile):
1358
1359 2016-08-01  Youenn Fablet  <youenn@apple.com>
1360
1361         Make wpt server generate its certificates in layout test results folder
1362         https://bugs.webkit.org/show_bug.cgi?id=160422
1363
1364         Reviewed by Chris Dumez.
1365
1366         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1367         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
1368
1369 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
1370
1371         Function Call on NULL Object
1372         https://bugs.webkit.org/show_bug.cgi?id=160325
1373
1374         Reviewed by Darin Adler.
1375
1376         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1377         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
1378         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
1379
1380 2016-08-01  Keith Miller  <keith_miller@apple.com>
1381
1382         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
1383         https://bugs.webkit.org/show_bug.cgi?id=160372
1384
1385         Rubber stamped by Geoffrey Garen.
1386
1387         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
1388         a new top level directory, JSTests. Having the tests in the Source directory
1389         was both confusing an inconvenient for people that just want to checkout the
1390         source code of WebKit. Since there is no other obvious place to put all the
1391         JavaScript tests a new top level directory seemed the most sensible.
1392
1393         * Scripts/import-test262-tests:
1394         * Scripts/run-javascriptcore-tests:
1395         * Scripts/update-javascriptcore-test-res:
1396
1397 2016-07-31  Nan Wang  <n_wang@apple.com>
1398
1399         AX: Add a check for touch event listener on iOS accessibility object
1400         https://bugs.webkit.org/show_bug.cgi?id=160388
1401
1402         Reviewed by Chris Fleizach.
1403
1404         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1405         (AccessibilityUIElement::boolAttributeValue):
1406         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1407         (WTR::AccessibilityUIElement::boolAttributeValue):
1408
1409 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
1410
1411         Unreviewed: add myself to the reviewers list.
1412
1413         * Scripts/webkitpy/common/config/contributors.json:
1414
1415 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
1416
1417         Undo r203939, and copy over a rule that clips the logos.
1418
1419         Sierra wasn't the only logo without transparency.
1420
1421         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1424
1425 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
1426
1427         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
1428         https://bugs.webkit.org/show_bug.cgi?id=160377
1429
1430         Reviewed by Brian Weinstein.
1431
1432         Update assets to remove the white background and use a transparent background instead.
1433
1434         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
1435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
1436
1437 2016-07-29  David Kilzer  <ddkilzer@apple.com>
1438
1439         Ignore most check-webkit-style checks for ANGLE project
1440         <https://webkit.org/b/160333>
1441
1442         Reviewed by Daniel Bates.
1443
1444         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
1445         - No tabs.
1446         - No spaces at the end of lines.
1447         - No carriage returns (DOS line endings).
1448
1449 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1450
1451         Media controls are not displayed for some autoplaying videos at certain browser dimensions
1452         https://bugs.webkit.org/show_bug.cgi?id=160360
1453         <rdar://problem/27179484>
1454
1455         Reviewed by Myles C. Maxfield.
1456
1457         Adds two tests verifying that videos may be considered main content as long as they
1458         are large enough and cover a majority of the mainframe's viewport.
1459
1460         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1461         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1462         (TestWebKitAPI::TEST):
1463         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
1464         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
1465
1466 2016-07-29  Mark Lam  <mark.lam@apple.com>
1467
1468         Gardening: removed unused variable.
1469
1470         Not reviewed.
1471
1472         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1473         (TestWebKitAPI::TEST):
1474
1475 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1476
1477         Add TestWebKitAPI support for interacting with media controls
1478         https://bugs.webkit.org/show_bug.cgi?id=160342
1479         <rdar://problem/27610246>
1480
1481         Reviewed by Beth Dakin.
1482
1483         Adds support for testing interaction with some media controls, as well as a basic test
1484         verifying that media control teardown after interaction does not result in a crash.
1485
1486         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1487         (-[WKWebView mouseDownAtPoint:]):
1488         (-[WKWebView performAfterLoading:]):
1489         (TestWebKitAPI::TEST):
1490
1491 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
1492
1493         Crash Log Clobbering on Unbound Crashes
1494         https://bugs.webkit.org/show_bug.cgi?id=160198
1495         <rdar://problem/27472618>
1496
1497         Reviewed by Alexey Proskuryakov.
1498
1499         * Scripts/webkitpy/common/system/crashlogs.py:
1500         (CrashLogs): Fix header order.
1501         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1502         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
1503
1504 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1505
1506         Update for contributors.json
1507         https://bugs.webkit.org/show_bug.cgi?id=160294
1508
1509         * Scripts/webkitpy/common/config/contributors.json:
1510
1511 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
1512
1513         Remove deprecated SPI for video inline / fullscreen controls
1514         https://bugs.webkit.org/show_bug.cgi?id=160318
1515
1516         Reviewed by Tim Horton.
1517
1518         * DumpRenderTree/mac/DumpRenderTree.mm:
1519         (setDefaultsToConsistentValuesForTesting): Deleted.
1520         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1521         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1522         * WebKitTestRunner/TestController.cpp:
1523         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1524         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1525         (WTR::initializeWebViewConfiguration): Deleted.
1526
1527 2016-07-28  Daniel Bates  <dabates@apple.com>
1528
1529         [iOS] TestWebKitAPI bundle targets are not code signed
1530         https://bugs.webkit.org/show_bug.cgi?id=160328
1531         <rdar://problem/27409246>
1532
1533         Reviewed by Andy Estes.
1534
1535         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
1536         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1537         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1538
1539         * TestWebKitAPI/Configurations/Base.xcconfig:
1540
1541 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1542
1543         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1544
1545         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1546         (animatedResizeWebView):
1547         (TEST):
1548         This test times out only when run in the WebKit Testing simulator environment,
1549         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1550
1551 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1552
1553         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1554         https://bugs.webkit.org/show_bug.cgi?id=160289
1555         <rdar://problem/27553464>
1556
1557         Reviewed by Simon Fraser.
1558
1559         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1560         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1561         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1562         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1563         (-[AnimatedResizeWebView _endAnimatedResize]):
1564         (animatedResizeWebView):
1565         (TEST):
1566         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1567         Add two tests that ensure that hidden-content and animated resizes
1568         don't cause unnecessary synchronous waits. Only the hidden-content
1569         one fails before my patch, but it seemed reasonable to add both anyway.
1570
1571 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1572
1573         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1574         <https://webkit.org/b/83342>
1575
1576         Reviewed by Ryosuke Niwa.
1577
1578         * Scripts/webkitpy/common/checkout/scm/git.py:
1579         (Git.revisions_changing_file): Remove code to raise an exception
1580         when the file doesn't exist.  If a file was moved or renamed,
1581         then this caused the script to terminate, which was very
1582         frustrating when you wanted a list of reviewers.
1583         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1584         (SCMTest._shared_test_revisions_changing_file): Update test
1585         expectation to return an empty list of revisions.
1586         (test_create_patch_is_full_patch): Drive-by fix when running all
1587         webkitpy tests (including scm tests).
1588         * Scripts/webkitpy/common/checkout/scm/svn.py:
1589         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1590         return an empty array of revisions if this occurs.
1591
1592 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1593
1594         EWS error message "Error: * did not process patch" should include explanation
1595         https://bugs.webkit.org/show_bug.cgi?id=159903
1596         <rdar://problem/27410788>
1597
1598         Reviewed by Alexey Proskuryakov.
1599
1600         * QueueStatusServer/handlers/statusbubble.py:
1601         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1602         is not processed.
1603         * QueueStatusServer/handlers/processingtimesjson.py:
1604         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1605         of the code.
1606         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1607         (CommitQueueTask.validate): Add more information about validation failure.
1608         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1609         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1610         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1611         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1612         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1613         (PatchIsNotValid.__init__): Add the failure_message argument.
1614         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1615         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1616         failure details.
1617         * Scripts/webkitpy/tool/commands/queues.py:
1618         (CommitQueue.process_work_item): Same.
1619         (StyleQueue.review_patch): Same.
1620         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1621         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1622
1623 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1624
1625         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1626         https://bugs.webkit.org/show_bug.cgi?id=160262
1627
1628         Reviewed by Daniel Bates.
1629
1630         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1631         (-[LTRelayController installApp]):
1632
1633 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1634
1635         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1636         https://bugs.webkit.org/show_bug.cgi?id=160225
1637
1638         Reviewed by Alexey Proskuryakov.
1639
1640         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1641
1642 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1643
1644         [GTK] Fix some video/canvas tests that should be passing
1645         https://bugs.webkit.org/show_bug.cgi?id=160023
1646
1647         Reviewed by Carlos Garcia Campos.
1648
1649         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1650         EFL or GTK platforms.
1651
1652         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1653         (WTR::TestController::platformConfigureViewForTest):
1654         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1655         (WTR::TestController::platformConfigureViewForTest):
1656
1657 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1658
1659         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1660         https://bugs.webkit.org/show_bug.cgi?id=160247
1661
1662         Reviewed by Michael Catanzaro.
1663
1664         * BuildSlaveSupport/built-product-archive:
1665         (createZip):
1666         (dirContainsdwo):
1667         (archiveBuiltProduct):
1668
1669 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1670
1671         Fix tests after r203743.
1672         https://bugs.webkit.org/show_bug.cgi?id=156947
1673
1674         * WebKitTestRunner/TestController.cpp:
1675         (WTR::TestController::resetStateToConsistentValues):
1676         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1677
1678 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1679
1680         [iPhone] Playing a video on tudou.com plays only sound, no video
1681         https://bugs.webkit.org/show_bug.cgi?id=160178
1682         <rdar://problem/27535468>
1683
1684         Reviewed by Dan Bernstein.
1685
1686         * DumpRenderTree/mac/DumpRenderTree.mm:
1687         (setDefaultsToConsistentValuesForTesting):
1688         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1689         (RequiresUserActionForPlaybackTest::SetUp):
1690         * WebKitTestRunner/TestController.cpp:
1691         (WTR::TestController::resetPreferencesToConsistentValues):
1692         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1693         (WTR::initializeWebViewConfiguration):
1694
1695 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1696
1697         Allow LOG macros to be used outside the namespace, and other logging cleanup
1698         https://bugs.webkit.org/show_bug.cgi?id=160216
1699
1700         Reviewed by Anders Carlsson.
1701         
1702         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1703
1704         * DumpRenderTree/TestRunner.cpp:
1705         * DumpRenderTree/mac/DumpRenderTree.mm:
1706         (resetWebViewToConsistentStateBeforeTesting):
1707
1708 2016-07-26  David Kilzer <ddkilzer@apple.com>
1709
1710         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1711         https://bugs.webkit.org/show_bug.cgi?id=156947
1712         <rdar://problem/23325160>
1713
1714         Reviewed by Alex Christensen.
1715
1716         * DumpRenderTree/TestRunner.cpp:
1717         (TestRunner::TestRunner):
1718         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1719         * DumpRenderTree/TestRunner.h:
1720         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1721         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1722         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1723         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1724         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1725         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1726         (WTR::TestRunner::queueNonLoadingScript):
1727         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1728         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1729         * WebKitTestRunner/TestController.cpp:
1730         (WTR::TestController::didReceiveAuthenticationChallenge):
1731         * WebKitTestRunner/TestController.h:
1732         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1733         * WebKitTestRunner/TestInvocation.cpp:
1734         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1735         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1736
1737 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1738
1739         check-for-exit-time-destructors should be usable outside Xcode
1740         <https://webkit.org/b/160195>
1741
1742         Reviewed by Darin Adler.
1743
1744         * Scripts/check-for-exit-time-destructors: Update to parse
1745         -h|--help switch, or to take one argument to a binary to check
1746         for exit time destructors on the command-line.  The clang
1747         compiler will find these at compile-time with the
1748         -Wexit-time-destructors switch, but this script will check for
1749         them after-the-fact.
1750
1751 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1752
1753         Test svn.webkit.org functionality after maintenance.
1754
1755 2016-07-25  Brady Eidson  <beidson@apple.com>
1756
1757         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1758         https://bugs.webkit.org/show_bug.cgi?id=153783
1759
1760         Reviewed by Alex Christensen.
1761
1762         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1763         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1764         
1765         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1766         
1767         Change the relevant API tests to make sure this continues to be no longer required.
1768
1769         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1770         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1771         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1772         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1773         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1774         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1775
1776 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1777
1778         Media controls should not be displayed for a video until it starts playing
1779         https://bugs.webkit.org/show_bug.cgi?id=160092
1780         <rdar://problem/26986673>
1781
1782         Reviewed by Beth Dakin.
1783
1784         Verify that multiple videos do or don't show the media controller depending on whether videos
1785         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1786         passing because we were always showing media controls for large videos with audio, even if they
1787         had not played back yet. This change ensures that large videos with audio show media controls
1788         only after they begin to play back, and not by virtue of being large enough for main content.
1789
1790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1791         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1792         (TestWebKitAPI::TEST):
1793         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1794         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1795         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1796
1797 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1798
1799         Media controls on apple.com don't disappear when movie finishes playing
1800         https://bugs.webkit.org/show_bug.cgi?id=160068
1801         <rdar://problem/26668526>
1802
1803         Reviewed by Darin Adler.
1804
1805         Adds new API tests. Please see WebCore ChangeLog for more details.
1806
1807         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1808         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1809         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1810         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1811         (TestWebKitAPI::TEST):
1812         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1813         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1814         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1815         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1816         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1817
1818 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1819
1820         Unreviewed, fix test-webkitpy after r203674.
1821
1822         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1823         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1824
1825 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1826
1827         Unreviewed, forgot to commit this file in r203674.
1828
1829         * Scripts/process-linux-coredump: Added.
1830         (main):
1831
1832 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1833
1834         Improve GDB backtrace generation for GTK/EFL
1835         https://bugs.webkit.org/show_bug.cgi?id=128928
1836
1837         Reviewed by Carlos Garcia Campos.
1838
1839         The PID of the crashed process is now correctly supplied to the
1840         crash log reporter. The kernel core_pattern needs to be updated
1841         after this change to something like:
1842
1843         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1844
1845         * Scripts/process-linux-coredump: Added.
1846         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1847         * Scripts/webkitpy/port/efl.py:
1848         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1849         * Scripts/webkitpy/port/gtk.py:
1850         (GtkPort._get_crash_log): Ditto.
1851         * Scripts/webkitpy/port/linux_get_crash_log.py:
1852         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1853         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1854         (GDBCrashLogGenerator): Deleted.
1855         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1856         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1857         * WebKitTestRunner/TestController.cpp:
1858         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1859         (WTR::TestController::databaseProcessDidCrash): Ditto.
1860         (WTR::TestController::processDidCrash): Ditto.
1861
1862 2016-07-23  Youenn Fablet  <youenn@apple.com>
1863
1864         WPT stash server should be kept running when launching wpt server
1865         https://bugs.webkit.org/show_bug.cgi?id=160052
1866
1867         Reviewed by Sam Weinig.
1868
1869         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1870         (main): waiting to read stdin while stash server is started.
1871
1872 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1873
1874         Media controls should be displayed for media in media documents
1875         https://bugs.webkit.org/show_bug.cgi?id=160104
1876         <rdar://problem/27438936>
1877
1878         Reviewed by Myles C. Maxfield.
1879
1880         Verifies that even a small video with audio in a media document gets media controls.
1881
1882         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1883         (TestWebKitAPI::TEST):
1884
1885 2016-07-22  Michael Saboff  <msaboff@apple.com>
1886
1887         REGRESSION(203616): no FTL testing was inadvertently removed
1888         https://bugs.webkit.org/show_bug.cgi?id=160100
1889
1890         Rubber-stamped by Filip Pizlo.
1891
1892         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1893         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1894         logic for the runLayout and runNoisy variants to match the run test logic,
1895         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1896         enabled platforms.
1897
1898         * Scripts/run-jsc-stress-tests:
1899
1900 2016-07-22  Brady Eidson  <beidson@apple.com>
1901
1902         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1903         https://bugs.webkit.org/show_bug.cgi?id=160089
1904
1905         Reviewed by Darin Adler.
1906
1907         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1908         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1909         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1910
1911 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1912
1913         [GTK] Improved exclusion patterns in make-dist.py manifest.
1914         https://bugs.webkit.org/show_bug.cgi?id=160094
1915
1916         Reviewed by Michael Catanzaro.
1917
1918         * gtk/manifest.txt.in:
1919         Exclude Platform*.cmake files for more ports.
1920         Removed obsolete .gyp and .pro.user patterns.
1921         Exclude 'Configurations' and 'spi' directories.
1922         Exclude CMakeLists.txt.user (Qt Creator IDE).
1923
1924 2016-07-22  Michael Saboff  <msaboff@apple.com>
1925
1926         Don't run FTL related JSC stress tests on non-FTL platforms
1927         https://bugs.webkit.org/show_bug.cgi?id=160033
1928
1929         Reviewed by Mark Lam.
1930
1931         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1932         Refactored several of the runXXX test methods to always runXXXDefault and made those
1933         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
1934         doesn't cause a problem.
1935
1936         * Scripts/run-jsc-stress-tests:
1937
1938 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
1939
1940         IWebView::mainFrame crashes if called after IWebView::close
1941         https://bugs.webkit.org/show_bug.cgi?id=32868
1942
1943         Reviewed by Brent Fulgham.
1944
1945         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1946         (TestWebKitAPI::TEST_F): Added test.
1947
1948 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1949
1950         [GTK] Enable threaded compositor by default
1951         https://bugs.webkit.org/show_bug.cgi?id=160079
1952
1953         Reviewed by Žan Doberšek.
1954
1955         * Scripts/webkitperl/FeatureList.pm:
1956
1957 2016-07-22  Youenn Fablet  <youenn@apple.com>
1958
1959         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
1960         https://bugs.webkit.org/show_bug.cgi?id=159921
1961
1962         Reviewed by Brian Burg.
1963
1964         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
1965
1966         * Scripts/webkitpy/codegen/main.py:
1967         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
1968         (BuiltinsGeneratorTests):
1969         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
1970         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
1971         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
1972         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
1973
1974 2016-07-21  Dan Bernstein  <mitz@apple.com>
1975
1976         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
1977         https://bugs.webkit.org/show_bug.cgi?id=160072
1978
1979         Reviewed by Andy Estes.
1980
1981         * Scripts/webkitdirs.pm:
1982         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
1983           for old Xcode versions.
1984         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
1985           to readXcodeUserDefault.
1986         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
1987           debugger.
1988         (determineDebugger): Ditto.
1989         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
1990           7.0.
1991         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
1992           switches.
1993         (execMacWebKitAppForDebugging): Removed support for GDB.
1994
1995 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1996
1997         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
1998         https://bugs.webkit.org/show_bug.cgi?id=160066
1999
2000         Reviewed by Dean Jackson.
2001
2002         * DumpRenderTree/mac/DumpRenderTree.mm:
2003         (setDefaultsToConsistentValuesForTesting): Deleted.
2004         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2005         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2006         * WebKitTestRunner/TestController.cpp:
2007         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2008         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2009         (WTR::initializeWebViewConfiguration): Deleted.
2010
2011 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
2012
2013         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
2014         https://bugs.webkit.org/show_bug.cgi?id=159980
2015         rdar://problem/27450825
2016
2017         Reviewed by Dan Bernstein.
2018
2019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2020         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
2021         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
2022         when our delegate has hit -dealloc.
2023         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
2024         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
2025         will not be messaged.
2026
2027 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2028
2029         Follow-up patch to r203520
2030         https://bugs.webkit.org/show_bug.cgi?id=159967
2031         <rdar://problem/26964090>
2032
2033         Unreviewed.
2034
2035         * DumpRenderTree/mac/DumpRenderTree.mm:
2036         (setDefaultsToConsistentValuesForTesting):
2037         * WebKitTestRunner/TestController.cpp:
2038         (WTR::TestController::resetPreferencesToConsistentValues):
2039
2040 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
2041
2042         [iPhone] Playing a video on tudou.com plays only sound, no video
2043         https://bugs.webkit.org/show_bug.cgi?id=159967
2044         <rdar://problem/26964090>
2045
2046         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
2047
2048         Migrate tests to use new SPI.
2049
2050         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2051         (RequiresUserActionForPlaybackTest::SetUp):
2052         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2053         (WTR::initializeWebViewConfiguration):
2054
2055 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
2056
2057         Clarify testing mode names in run-jsc-stress-tests
2058         https://bugs.webkit.org/show_bug.cgi?id=160021
2059
2060         Reviewed by Mark Lam.
2061
2062         Default should mean really default, not default with disabled FTL, renamed
2063         - runMozillaTestDefault to runMozillaTestNoFTL
2064         - runMozillaTestDefaultFTL to runMozillaTestDefault
2065         - runDefault to runNoFTL
2066         - runDefaultFTL to runDefault
2067         - runLayoutTestDefault to runLayoutTestNoFTL
2068         - runLayoutTestDefaultFTL to runLayoutTestDefault
2069         - runNoisyTestDefault to runNoisyTestNoFTL
2070         - runNoisyTestDefaultFTL to runNoisyTestDefault
2071
2072         * Scripts/run-jsc-stress-tests:
2073
2074 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
2075
2076         WebBackForwardList's currentIndex could get out of bounds when filtering items.
2077         https://bugs.webkit.org/show_bug.cgi?id=159986
2078
2079         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
2080         to 0.
2081
2082         Reviewed by Dan Bernstein.
2083
2084         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2085         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
2086         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
2087         (TEST):
2088
2089 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2090
2091         [GTK] Web view background colors don't work in accelerated compositing mode
2092         https://bugs.webkit.org/show_bug.cgi?id=159455
2093
2094         Reviewed by Michael Catanzaro.
2095
2096         Set always RGBA visual to the view widget when setting a background color.
2097
2098         * MiniBrowser/gtk/BrowserWindow.c:
2099         (browser_window_set_background_color):
2100
2101 2016-07-20  Youenn Fablet  <youenn@apple.com>
2102
2103         Bots should run built-ins generator tests
2104         https://bugs.webkit.org/show_bug.cgi?id=159971
2105
2106         Reviewed by Alexey Proskuryakov.
2107
2108         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2109         (RunBuiltinsTests): New step to run built-in generator tests.
2110         (TestFactory.__init__): Adding an additional step for bultin generator tests.
2111         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
2112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
2113
2114 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2115
2116         Revert temporary fix r203417
2117         https://bugs.webkit.org/show_bug.cgi?id=160001
2118
2119         Reviewed by Alexey Proskuryakov.
2120
2121         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
2122
2123 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
2124
2125         REGRESSION(r148588): ews classes might get garbage collected
2126         https://bugs.webkit.org/show_bug.cgi?id=159990
2127
2128         Reviewed by Ryosuke Niwa.
2129
2130         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
2131         in a variable so that they do not get garbage collected.
2132
2133 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
2134
2135         Add API test for layout constraints after exit fullscreen
2136         https://bugs.webkit.org/show_bug.cgi?id=159900
2137
2138         Reviewed by Jon Lee.
2139
2140         Added Fullscreen.LaytoutConstraints API test. 
2141         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
2142
2143         This test compares layout constraints on the web view before and after fullscreen to make sure 
2144         they are preserved.
2145
2146         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
2147         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
2148         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
2149         (TestWebKitAPI::TEST):
2150
2151 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
2152
2153         Disable two failing API tests.
2154
2155         Unreviewed test gardening.
2156
2157         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
2158         (TestWebKitAPI::TEST):
2159
2160 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2161
2162         Unreviewed iOS build fix.
2163
2164         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
2165
2166 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2167
2168         Media controls don't appear when pausing a small autoplaying video
2169         https://bugs.webkit.org/show_bug.cgi?id=159972
2170         <rdar://problem/27180657>
2171
2172         Reviewed by Beth Dakin.
2173
2174         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
2175         for simulating basic user interaction in VideoControlsManager.
2176
2177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2178         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2179         (-[WKWebView mouseDownAtPoint:]):
2180         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2181         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
2182         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
2183         (TestWebKitAPI::TEST):
2184         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
2185
2186 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
2187
2188         [Win] MathML fonts are not found.
2189         https://bugs.webkit.org/show_bug.cgi?id=159920
2190
2191         Reviewed by Alex Christensen.
2192
2193         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
2194         for a specific registry key value.
2195
2196         * Scripts/webkitdirs.pm:
2197         (fontExists):
2198
2199 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
2200
2201         Improve prepare-ChangeLog for @media blocks
2202         https://bugs.webkit.org/show_bug.cgi?id=159907
2203
2204         Reviewed by Timothy Hatcher.
2205
2206         * Scripts/prepare-ChangeLog:
2207         (get_selector_line_ranges_for_css):
2208         Get a range for @media blocks just like a selector.
2209             Start Line = line with '{'
2210             End line = line with '}'
2211             Name = "@media ..."
2212
2213         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
2214         Improved error messages for unbalanced portions.
2215
2216         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
2217         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
2218         (.media-query::before):
2219         (@media only screen and (max-width: 980px)):
2220         (.media-query a):
2221         (@media (-webkit-min-device-pixel-ratio: 2)):
2222         (.both a):
2223         (.both b):
2224         (.media-query b):
2225         (.media-query::after):
2226
2227 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2228
2229         Fix expectedFailErrorHandler in run-jsc-stress-tests
2230         https://bugs.webkit.org/show_bug.cgi?id=159811
2231
2232         Reviewed by Yusuke Suzuki.
2233
2234         * Scripts/run-jsc-stress-tests:
2235
2236 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
2237
2238         Unreviewed Mac cmake buildfix after r203426. Just for fun.
2239
2240         * TestWebKitAPI/PlatformMac.cmake:
2241
2242 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
2243
2244         The default testing mode should not involve disabling the FTL JIT
2245         https://bugs.webkit.org/show_bug.cgi?id=159929
2246
2247         Rubber stamped by Mark Lam and Saam Barati.
2248         
2249         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
2250         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
2251         FTL was not the default. You had to enable it with an option.
2252         
2253         For some reason we have kept this arrangement even though the FTL JIT is now the default on
2254         all of the major ports. This has become a serious pain. For example, it's useful to be able
2255         to say that a test should only run in the default config that is representative of what a
2256         normal user would see if they ran JSC. Clearly, this would be a config that does not
2257         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
2258         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
2259         
2260         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
2261         try to fix it, because:
2262         
2263         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
2264           have the FTL enabled never run any tests that explicitly disable the FTL, since that
2265           doesn't do anything. The code is not really structured to allow this.
2266         
2267         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
2268           disabled in testing. On the other hand there are already build bots that do FTL tests
2269           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
2270           preserving this broken feature, we should create something that (a) acknowledges the fact
2271           that the FTL is the default on those platforms that support it and (b) avoids running
2272           no-ftl tests on precisely those platforms that don't have FTL.
2273         
2274         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
2275           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
2276           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
2277           pretending that the FTL JIT is not the default just because some bots used that as an
2278           optimization.
2279         
2280         This change allows me to speed up some debug tests and paint some bots green.
2281
2282         * Scripts/run-javascriptcore-tests:
2283         (runJSCStressTests):
2284         * Scripts/run-jsc-stress-tests:
2285
2286 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2287
2288         Fix API test after r203426.
2289         https://bugs.webkit.org/show_bug.cgi?id=159949
2290
2291         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2292         (TEST):
2293         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
2294         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
2295
2296 2016-07-19  Andy Estes  <aestes@apple.com>
2297
2298         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
2299         https://bugs.webkit.org/show_bug.cgi?id=159956
2300
2301         Reviewed by Dan Bernstein.
2302
2303         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
2304         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2305         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
2306         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
2307
2308 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2309
2310         Add regression test for r203392
2311         https://bugs.webkit.org/show_bug.cgi?id=159949
2312
2313         Reviewed by Brady Eidson.
2314
2315         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2316         (fileSize):
2317         (swizzledBundleIdentifierWebBookmarksD):
2318         (defaultApplicationCacheDirectory):
2319         (TEST):
2320         (swizzledBundleIdentifierMobileSafari): Deleted.
2321         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
2322         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
2323         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
2324
2325 2016-07-19  Alex Christensen  <achristensen@webkit.org>
2326
2327         Add regression test for r203392
2328         https://bugs.webkit.org/show_bug.cgi?id=159949
2329
2330         Reviewed by Brady Eidson.
2331
2332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2333         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
2334         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
2335         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
2336         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2337         (TEST):
2338         (fileSize):
2339         (swizzledBundleIdentifierMobileSafari):
2340         (swizzledBundleIdentifierWebBookmarksD):
2341         (defaultApplicationCacheDirectory):
2342         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
2343         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
2344         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
2345         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
2346
2347 2016-07-19  Keith Miller  <keith_miller@apple.com>
2348
2349         Test262 should have a file with the revision and url
2350         https://bugs.webkit.org/show_bug.cgi?id=159937
2351
2352         Reviewed by Mark Lam.
2353
2354         The import script should update the information from
2355         the path to the test262 repository it gets.
2356
2357         * Scripts/import-test262-tests:
2358
2359 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2360
2361         Temporary workaround for iOS EWS failing after the fix for bug 159539.
2362         To be deleted once the root cause is found and addressed.
2363
2364         * EWSTools/start-queue-mac.sh:
2365
2366 2016-07-19  Frederic Wang  <fwang@igalia.com>
2367
2368         [win] Fixup the register name for STIX Math and Latin Modern Math
2369
2370         Unreviewed follow-up of r203406
2371
2372         * Scripts/webkitdirs.pm:
2373         (checkInstalledTools):
2374
2375 2016-07-19  Frederic Wang  <fwang@igalia.com>
2376
2377         [win] Update the list of MathML fonts
2378         https://bugs.webkit.org/show_bug.cgi?id=156838
2379
2380         The set of recommended math fonts is now described at
2381         https://trac.webkit.org/wiki/MathML/Fonts
2382         We update the Perl script to use the latest list of fonts.
2383
2384         Reviewed by Brent Fulgham.
2385
2386         * Scripts/webkitdirs.pm:
2387         (checkInstalledTools):
2388
2389 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
2390
2391         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
2392         https://bugs.webkit.org/show_bug.cgi?id=159342
2393
2394         Reviewed by Darin Adler.
2395
2396         Implement required functions in event sender.
2397
2398         * DumpRenderTree/PlatformWin.cmake:
2399         * DumpRenderTree/win/EventSender.cpp:
2400         (monitorWheelEvents): Added.
2401         (callAfterScrollingCompletes): Added.
2402
2403 2016-07-19  Youenn Fablet  <youenn@apple.com>
2404
2405         Add new aliases to http test server
2406         https://bugs.webkit.org/show_bug.cgi?id=159878
2407
2408         Reviewed by Darin Adler.
2409
2410         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
2411         Adding explicitly these links to perl script.
2412         Extracting default alias in an aliases.json file.
2413         Reading that file from python scripts to initialize aliases from that file.
2414
2415         Python script changes covered by unit tests and changed layout test.
2416
2417         * Scripts/webkitperl/httpd.pm:
2418         (getDefaultConfigForTestDirectory): Adding 3 new aliases
2419         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
2420         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2421         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2422         Adding -c directives for each alias.
2423         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2424         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
2425         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2426         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
2427         Adding alias directive for each alias.
2428         (Lighttpd._prepare_config):
2429         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2430         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
2431         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
2432         layout tests directory.
2433         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2434         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
2435         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
2436
2437 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
2438
2439         EWS console logs doesn't go to log file
2440         https://bugs.webkit.org/show_bug.cgi?id=159539
2441         <rdar://problem/24464570>
2442
2443         Reviewed by David Kilzer.
2444
2445         * Scripts/webkitpy/common/system/logutils.py:
2446         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
2447         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
2448         to filesystem. It also supports passing MockFilesystem.
2449         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
2450         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
2451         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2452         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
2453         (_test_ews): Same.
2454         * Scripts/webkitpy/tool/commands/queues.py:
2455         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
2456         (AbstractQueue._log_directory): Using filesystem object instead of os.
2457         (AbstractQueue.queue_log_path): Same.
2458         (AbstractQueue.__init__): Passed host parameter.
2459         (PatchProcessingQueue.__init__): Same.
2460         (CommitQueue.__init__): Same.
2461         (AbstractReviewQueue.__init__): Same.
2462         (StyleQueue.__init__): Same.
2463         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2464         (TestCommitQueue): Passed MockHost() as host.
2465         (TestCommitQueue.__init__): Same.
2466         (TestQueue.__init__): Same.
2467         (TestReviewQueue.__init__): Same.
2468         (TestFeederQueue.__init__): Same.
2469         (AbstractPatchQueueTest.test_next_patch): Same.
2470         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
2471         (test_commit_queue_failure): Same.
2472         (MockCommitQueueTask.results_from_patch_test_run): Same.
2473         (test_rollout_lands): Same.
2474         (test_non_valid_patch): Same.
2475         (test_auto_retry): Same.
2476         (test_style_queue_with_watch_list_exception): Same.
2477
2478 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
2479
2480         WTF::Lock should be fair eventually
2481         https://bugs.webkit.org/show_bug.cgi?id=159384
2482
2483         Reviewed by Geoffrey Garen.
2484
2485         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2486
2487 2016-07-17  Sam Weinig  <sam@webkit.org>
2488
2489         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
2490         <rdar://problem/26554137>
2491         https://bugs.webkit.org/show_bug.cgi?id=159856
2492
2493         Reviewed by Dan Bernstein.
2494
2495         * MiniBrowser/mac/WK2BrowserWindowController.m:
2496         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2497         Add basic window.open implementation.
2498
2499         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
2500         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
2501         to open a single non-web URL, all others are dropped.
2502
2503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2504         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
2505         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
2506         Add API for the new SPI.
2507
2508 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2509
2510         [JSC] Enable test262 module tests
2511         https://bugs.webkit.org/show_bug.cgi?id=159854
2512
2513         Reviewed by Saam Barati.
2514
2515         Use --module-file instead.
2516
2517         * Scripts/run-jsc-stress-tests:
2518
2519 2016-07-16  Chris Dumez  <cdumez@apple.com>
2520
2521         Unreviewed, rolling out r203318.
2522
2523         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
2524         SunSpider)
2525
2526         Reverted changeset:
2527
2528         "[JSC] Change some parameters based on a random search"
2529         https://bugs.webkit.org/show_bug.cgi?id=158514
2530         http://trac.webkit.org/changeset/203318
2531
2532 2016-07-16  Chris Dumez  <cdumez@apple.com>
2533
2534         Add move constructor / assignment operator to ListHashSet
2535         https://bugs.webkit.org/show_bug.cgi?id=159837
2536
2537         Reviewed by Darin Adler.
2538
2539         Add API tests.
2540
2541         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2542         (TestWebKitAPI::TEST):
2543
2544 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2545
2546         [JSC] Change some parameters based on a random search
2547         https://bugs.webkit.org/show_bug.cgi?id=158514
2548
2549         Reviewed by Saam Barati.
2550
2551         * Scripts/run-jsc-stress-tests:
2552
2553 2016-07-15  Jon Davis  <jond@apple.com>
2554
2555         Changed the start page URL for WebKit Nightly builds.
2556         https://bugs.webkit.org/show_bug.cgi?id=159816
2557
2558         Reviewed by Timothy Hatcher.
2559
2560         * WebKitLauncher/start.html:
2561
2562 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2563
2564         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2565         https://bugs.webkit.org/show_bug.cgi?id=159414
2566
2567         Reviewed by Brent Fulgham.
2568
2569         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2570         when the HDC parameter is invalid.
2571
2572         * TestWebKitAPI/PlatformWin.cmake:
2573         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2574         (TestWebKitAPI::TEST):
2575
2576 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2577
2578         [GTK] Add basic tabs support to MiniBrowser
2579         https://bugs.webkit.org/show_bug.cgi?id=159803
2580
2581         Reviewed by Sergio Villar Senin.
2582
2583         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2584         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2585
2586         * MiniBrowser/gtk/BrowserTab.c: Added.
2587         (titleChanged):
2588         (isLoadingChanged):
2589         (decidePolicy):
2590         (removeChildIfInfoBar):
2591         (loadChanged):
2592         (createInfoBarQuestionMessage):
2593         (tlsErrorsDialogResponse):
2594         (loadFailedWithTLSerrors):
2595         (permissionRequestDialogResponse):
2596         (decidePermissionRequest):
2597         (colorChooserRGBAChanged):
2598         (popoverColorClosed):
2599         (colorChooserRequestFinished):
2600         (runColorChooserCallback):
2601         (inspectorOpenedInWindow):
2602         (inspectorClosed):
2603         (browserTabSetProperty):
2604         (browserTabFinalize):
2605         (browser_tab_init):
2606         (browserTabConstructed):
2607         (browser_tab_class_init):
2608         (getInternalURI):
2609         (browser_tab_new):
2610         (browser_tab_get_web_view):
2611         (browser_tab_load_uri):
2612         (browser_tab_get_title_widget):
2613         (browser_tab_set_status_text):
2614         (browser_tab_toggle_inspector):
2615         (browser_tab_start_search):
2616         (browser_tab_stop_search):
2617         (browser_tab_add_accelerators):
2618         (fullScreenMessageTimeoutCallback):
2619         (browser_tab_enter_fullscreen):
2620         (browser_tab_leave_fullscreen):
2621         * MiniBrowser/gtk/BrowserTab.h: Added.
2622         * MiniBrowser/gtk/BrowserWindow.c:
2623         (getExternalURI):
2624         (browserWindowSetStatusText):
2625         (reloadOrStopCallback):
2626         (goBackCallback):
2627         (goForwardCallback):
2628         (settingsCallback):
2629         (webViewURIChanged):
2630         (browserWindowHistoryItemActivated):
2631         (browserWindowUpdateNavigationActions):
2632         (webViewCreate):
2633         (webViewEnterFullScreen):
2634         (webViewLeaveFullScreen):
2635         (webViewDecidePolicy):
2636         (browserWindowCanZoomIn):
2637         (browserWindowCanZoomOut):
2638         (browserWindowZoomIn):
2639         (browserWindowZoomOut):
2640         (scrollEventCallback):
2641         (faviconChanged):
2642         (webViewIsLoadingChanged):
2643         (defaultZoomCallback):
2644         (searchCallback):
2645         (newTabCallback):
2646         (toggleWebInspector):
2647         (reloadPage):
2648         (reloadPageIgnoringCache):
2649         (stopPageLoad):
2650         (loadHomePage):
2651         (editingCommandCallback):
2652         (insertImageCommandCallback):
2653         (insertLinkCommandCallback):
2654         (browserWindowSetupEditorToolbar):
2655         (browserWindowSwitchTab):
2656         (browserWindowTabAddedOrRemoved):
2657         (browser_window_init):
2658         (browserWindowConstructed):
2659         (browserWindowSaveSession):
2660         (browserWindowDeleteEvent):
2661         (browser_window_new):
2662         (browser_window_append_view):
2663         (browser_window_load_uri):
2664         (browser_window_load_session):
2665         (browser_window_set_background_color):
2666         (resetStatusText): Deleted.
2667         (activateUriEntryCallback): Deleted.
2668         (webViewTitleChanged): Deleted.
2669         (resetEntryProgress): Deleted.
2670         (browserWindowCreateBackForwardMenu): Deleted.
2671         (webViewReadyToShow): Deleted.
2672         (webViewLoadFailed): Deleted.
2673         (webViewMouseTargetChanged): Deleted.
2674         (browserWindowUpdateZoomActions): Deleted.
2675         (webViewZoomLevelChanged): Deleted.
2676         (updateUriEntryIcon): Deleted.
2677         (zoomInCallback): Deleted.
2678         (zoomOutCallback): Deleted.
2679         (toggleFullScreen): Deleted.
2680         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2681         (browserWindowFinalize): Deleted.
2682         (browser_window_class_init): Deleted.
2683         * MiniBrowser/gtk/BrowserWindow.h:
2684         * MiniBrowser/gtk/CMakeLists.txt:
2685         * MiniBrowser/gtk/main.c:
2686         (createBrowserTab):
2687         (aboutURISchemeRequestCallback):
2688         (main):
2689         (parseBackgroundColor): Deleted.
2690
2691 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2692
2693         Allow RefPtrs of const RefCounted types
2694         https://bugs.webkit.org/show_bug.cgi?id=158269
2695
2696         Reviewed by Anders Carlsson.
2697
2698         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2699         (TestWebKitAPI::TEST):
2700         (TestWebKitAPI::ConstRefCounted::create):
2701         (TestWebKitAPI::returnConstRefCountedRef):
2702         (TestWebKitAPI::returnRefCountedRef):
2703
2704 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2705
2706         Test WTF.StringViewIterators is crashing since r203119
2707         https://bugs.webkit.org/show_bug.cgi?id=159710
2708
2709         Reviewed by Darin Adler.
2710
2711         There are two problems in the test case added in r203119. First is that it's testing
2712         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2713         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2714         const reference to the string view member of the deleted CodePoints object.
2715
2716         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2717         (TestWebKitAPI::TEST):
2718
2719 2016-07-13  Daniel Bates  <dabates@apple.com>
2720
2721         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2722         https://bugs.webkit.org/show_bug.cgi?id=159738
2723         <rdar://problem/27304649>
2724
2725         Reviewed by Dan Bernstein.
2726
2727         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2728         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2729         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2730         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2731
2732         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2733         * WebKitTestRunner/ios/TestControllerIOS.mm:
2734         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2735         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2736
2737 2016-07-13  Beth Dakin  <bdakin@apple.com>
2738
2739         Attempted build fix.
2740
2741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2742
2743 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2744
2745         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2746         https://bugs.webkit.org/show_bug.cgi?id=159686
2747
2748         Reviewed by Chris Dumez.
2749
2750         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2751
2752         * WebKitTestRunner/TestController.cpp:
2753         (WTR::runOpenPanel):
2754         (WTR::TestController::createOtherPage):
2755         (WTR::TestController::createWebViewWithOptions):
2756
2757 2016-07-13  Beth Dakin  <bdakin@apple.com>
2758
2759         Add more candidate tests
2760         https://bugs.webkit.org/show_bug.cgi?id=159730
2761
2762         Reviewed by Tim Horton.
2763
2764         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2765         two new tests to that file.
2766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2767         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2768         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2769         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2770         (TestWebKitAPI::TEST):
2771         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2772
2773 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2774
2775         AX: [ATK] spinbutton-crash.html fails
2776         https://bugs.webkit.org/show_bug.cgi?id=159723
2777
2778         Reviewed by Chris Fleizach.
2779
2780         Implement support for AXDecrementButton and AXIncrementButton in
2781         ATK's AccessibilityUIElement::uiElementAttributeValue().
2782
2783         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2784         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2785
2786 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2787
2788         [EFL] [GTK] Enable back crypto subtle on development builds.
2789         https://bugs.webkit.org/show_bug.cgi?id=159260
2790
2791         Reviewed by Carlos Garcia Campos.
2792
2793         * Scripts/webkitperl/FeatureList.pm:
2794
2795 2016-07-12  Mark Lam  <mark.lam@apple.com>
2796
2797         We should use different stack limits for stack checks from JS and host code.
2798         https://bugs.webkit.org/show_bug.cgi?id=159442
2799         <rdar://problem/26889188>
2800
2801         Reviewed by Geoffrey Garen.
2802
2803         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2804         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2805         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2806         order to keep the js/regress-139548.html test happy with this patch.
2807
2808         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2809         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2810
2811         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2812         (-[LTRelayController _environmentVariables]):
2813         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2814         (main):
2815
2816 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2817
2818         platformUserPreferredLanguages on Mac should not try to put the region into the language
2819         https://bugs.webkit.org/show_bug.cgi?id=159693
2820
2821         Rubber stamped by Alexey Proskuryakov.
2822         
2823         Revert the test change in r200105.
2824
2825         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2826         (TestWebKitAPI::languageForSystemLanguage):
2827
2828 2016-07-12  Chris Dumez  <cdumez@apple.com>
2829
2830         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2831         https://bugs.webkit.org/show_bug.cgi?id=159663
2832         <rdar://problem/18995873>
2833
2834         Reviewed by Benjamin Poulain.
2835
2836         Add API test coverage.
2837
2838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2839         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2840         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2841         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2842         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2843         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2844         (TEST):
2845
2846 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2847
2848         Relax ordering requirements on StringView::CodePoints iterator
2849         https://bugs.webkit.org/show_bug.cgi?id=159609
2850
2851         Reviewed by Darin Adler.
2852
2853         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2854         (TestWebKitAPI::TEST):
2855
2856 2016-07-12  Youenn Fablet  <youenn@apple.com>
2857
2858         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2859         https://bugs.webkit.org/show_bug.cgi?id=159564
2860
2861         Reviewed by Brian Burg.
2862
2863         * Scripts/webkitpy/codegen/main.py:
2864         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2865
2866 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2867
2868         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2869         https://bugs.webkit.org/show_bug.cgi?id=159671
2870
2871         Reviewed by Csaba Osztrogonác.
2872
2873         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2874         https://bugs.webkit.org/show_bug.cgi?id=89235
2875
2876         So this guard can be removed in build scripts.
2877
2878         * Scripts/webkitperl/FeatureList.pm:
2879         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2880
2881 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2882
2883         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2884         https://bugs.webkit.org/show_bug.cgi?id=159652
2885
2886         Reviewed by Daniel Bates.
2887
2888         * Scripts/webkitpy/common/checkout/scm/svn.py:
2889         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2890
2891 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2892
2893         Implement grapheme cluster iterator on StringView
2894         https://bugs.webkit.org/show_bug.cgi?id=159598
2895
2896         Reviewed by Anders Carlsson.
2897
2898         This is in preparation for honoring the second argument to FontFaceSet.load().
2899
2900         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2901         (TestWebKitAPI::compareLoopIterations):
2902         (TestWebKitAPI::TEST):
2903
2904 2016-07-11  Nan Wang  <n_wang@apple.com>
2905
2906         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2907         https://bugs.webkit.org/show_bug.cgi?id=158364
2908
2909         Reviewed by Anders Carlsson.
2910
2911         Added a function in TestRunner so that we can toggle the ignoring viewport
2912         scale limits setting. Also added a test option for that in order to change the 
2913         configuration of the webview in test.
2914
2915         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2916         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2917         (WTR::TestRunner::setNavigationGesturesEnabled):
2918         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2919         (WTR::nextUIScriptCallbackID):
2920         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2921         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2922         * WebKitTestRunner/TestController.cpp:
2923         (WTR::TestController::resetStateToConsistentValues):
2924         (WTR::updateTestOptionsFromTestHeader):
2925         (WTR::TestController::setNavigationGesturesEnabled):
2926         (WTR::TestController::setIgnoresViewportScaleLimits):
2927         (WTR::TestController::platformWillRunTest):
2928         * WebKitTestRunner/TestController.h:
2929         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2930         * WebKitTestRunner/TestInvocation.cpp:
2931         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2932         * WebKitTestRunner/TestOptions.h:
2933         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2934         (WTR::TestController::platformCreateWebView):
2935
2936 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
2937
2938         [GTK] install-dependencies should not install packages built by jhbuild.
2939         https://bugs.webkit.org/show_bug.cgi?id=159628
2940
2941         Reviewed by Michael Catanzaro.
2942
2943         * gtk/install-dependencies:
2944         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
2945
2946 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
2947
2948         System proxy settings not used when building deps with jhbuild
2949         https://bugs.webkit.org/show_bug.cgi?id=159567
2950
2951         Reviewed by Michael Catanzaro.
2952
2953         This adds the gsettings-desktop-schemas-devel build dep to enable
2954         the libgiognomeproxy.so gio module in glib-networking, which uses
2955         GSettings on org.gnome.system.proxy.
2956         This is needed to query system proxy settings for Gnome desktops.
2957
2958         dconf can be manually added to jhbuild to build the
2959         libdconfsettings.so gio module for GSettings, so that
2960         libgiognomeproxy.so can access system settings.
2961           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
2962
2963         As an alternative to dconf settings, this commit also adds the
2964         libproxy-devel build dep to enable the libgiolibproxy.so module in
2965         glib-networking (suggested by Fujii Hironori).
2966
2967         It is useful to read proxy settings from environment variables.
2968         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
2969         environment variable to force using the envvar module in libproxy.
2970
2971         * gtk/install-dependencies:
2972
2973 2016-07-11  Mark Lam  <mark.lam@apple.com>
2974
2975         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
2976         https://bugs.webkit.org/show_bug.cgi?id=159524
2977
2978         Reviewed by Michael Saboff.
2979
2980         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
2981         Also fixed up some tests to behave better to work with this new limit.  This
2982         should make stack overflow tests complete sooner.
2983
2984         * Scripts/run-jsc-stress-tests:
2985         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2986         (main):
2987
2988 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2989
2990         [GTK] Whitespace fixes in install-dependencies script
2991
2992         Unreviewed.
2993
2994         * gtk/install-dependencies:
2995
2996 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2997
2998         [GTK] Install missing Fedora dependencies
2999
3000         Unreviewed.
3001
3002         * gtk/install-dependencies:
3003
3004 2016-07-09  Dan Bernstein  <mitz@apple.com>
3005
3006         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
3007         https://bugs.webkit.org/show_bug.cgi?id=159600
3008
3009         Reviewed by Daniel Bates.
3010
3011         * Scripts/git-add-reviewer:
3012         Added the -s|--rubber-stamp option.
3013         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
3014           new option.
3015
3016 2016-07-08  Andy Estes  <aestes@apple.com>
3017
3018         [Content Filtering] Load blocked pages more like other error pages are loaded
3019         https://bugs.webkit.org/show_bug.cgi?id=159485
3020         <rdar://problem/26014076>
3021
3022         Reviewed by Brady Eidson.
3023
3024         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3025         to a content filtering provisional navigation failure is ignored in preference of
3026         ContentFilter's own error page.
3027
3028         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3029         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3030         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3031         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3032         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3033         (loadAlternateTest):
3034         (TEST):
3035         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3036         (-[MockContentFilterEnabler initWithCoder:]):
3037         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3038         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3039         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3040         (TestWebKitAPI::loadAlternateTest):
3041         (TestWebKitAPI::TEST):
3042
3043 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3044
3045         Unreviewed, rolling out r202944.
3046         https://bugs.webkit.org/show_bug.cgi?id=159570
3047
3048         caused some tests to crash under GuardMalloc (Requested by
3049         estes on #webkit).
3050
3051         Reverted changeset:
3052
3053         "[Content Filtering] Load blocked pages more like other error
3054         pages are loaded"
3055         https://bugs.webkit.org/show_bug.cgi?id=159485
3056         http://trac.webkit.org/changeset/202944
3057
3058 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
3059
3060         Remove mrobinson from the MathML watchlist
3061         https://bugs.webkit.org/show_bug.cgi?id=159559
3062
3063         Reviewed by Philippe Normand.
3064
3065         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
3066
3067 2016-07-08  Brady Eidson  <beidson@apple.com>
3068
3069         Clearing LocalStorage doesn't also delete -wal and -shm files.
3070         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
3071
3072         Reviewed by Brent Fulgham.
3073         Also helpfully picked over by Andy "Never Forgets" Estes.
3074
3075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3076         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
3077         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
3078
3079 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
3080
3081         Removed Qt leftovers from Tools.
3082         https://bugs.webkit.org/show_bug.cgi?id=159557
3083
3084         Reviewed by Csaba Osztrogonác.
3085
3086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3087         Removed 'qt' platform config.
3088         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3089         Deleted non-functional e-mail address.
3090
3091 2016-07-08  Commit Queue  <commit-queue@webkit.org>
3092
3093         Unreviewed, rolling out r202967.
3094         https://bugs.webkit.org/show_bug.cgi?id=159556
3095
3096         This patch caused crashes in https tests on Windows (Requested
3097         by perarne on #webkit).
3098
3099         Reverted changeset:
3100
3101         "[Win] The test http/tests/security/contentSecurityPolicy
3102         /upgrade-insecure-requests/basic-upgrade.https.html is
3103         failing."
3104         https://bugs.webkit.org/show_bug.cgi?id=159510
3105         http://trac.webkit.org/changeset/202967
3106
3107 2016-07-08  Youenn Fablet  <youenn@apple.com>
3108
3109         Generate WebCore builtin wrapper files
3110         https://bugs.webkit.org/show_bug.cgi?id=159461
3111
3112         Reviewed by Brian Burg.
3113
3114         * Scripts/webkitpy/codegen/main.py:
3115         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
3116         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
3117
3118 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
3119
3120         [EFL] Fix build when media-stream is enabled.
3121         https://bugs.webkit.org/show_bug.cgi?id=159206
3122
3123         Bump up the openwebrtc to find the correct package.
3124
3125         Reviewed by Gyuyoung Kim.
3126
3127         * efl/jhbuild.modules:
3128         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
3129
3130 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3131
3132         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
3133         https://bugs.webkit.org/show_bug.cgi?id=159510
3134
3135         Reviewed by Brent Fulgham.
3136
3137         Allow any https certificate when running tests.
3138
3139         * DumpRenderTree/win/DumpRenderTree.cpp:
3140         (runTest):
3141
3142 2016-07-07  Beth Dakin  <bdakin@apple.com>
3143
3144         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
3145         https://bugs.webkit.org/show_bug.cgi?id=159532
3146         -and corresponding-
3147         rdar://problem/27177179
3148
3149         Reviewed by Tim Horton.
3150
3151         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
3152         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
3153
3154 2016-07-07  Andy Estes  <aestes@apple.com>
3155
3156         [Content Filtering] Load blocked pages more like other error pages are loaded
3157         https://bugs.webkit.org/show_bug.cgi?id=159485
3158         <rdar://problem/26014076>
3159
3160         Reviewed by Brady Eidson.
3161
3162         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
3163         to a content filtering provisional navigation failure is ignored in preference of
3164         ContentFilter's own error page.
3165
3166         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3168         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3169         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3170         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
3171         (loadAlternateTest):
3172         (TEST):
3173         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3174         (-[MockContentFilterEnabler initWithCoder:]):
3175         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
3176         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3177         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
3178         (TestWebKitAPI::loadAlternateTest):
3179         (TestWebKitAPI::TEST):
3180
3181 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3182
3183         Unreviewed: add myself to the reviewers list.
3184
3185         * Scripts/webkitpy/common/config/contributors.json:
3186
3187 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
3188
3189         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
3190         https://bugs.webkit.org/show_bug.cgi?id=159509
3191
3192         Reviewed by Alex Christensen.
3193
3194         We should always insert the url in the url map when identifierForInitialRequest
3195         is called. Otherwise we can end up with identifiers not having an entry in the
3196         url map when urls are written to the test output file. 
3197
3198         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3199         (ResourceLoadDelegate::identifierForInitialRequest):
3200
3201 2016-07-06  Tim Horton  <timothy_horton@apple.com>
3202
3203         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
3204         https://bugs.webkit.org/show_bug.cgi?id=159498
3205         <rdar://problem/26719903>
3206
3207         Reviewed by Sam Weinig.
3208
3209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3210         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
3211         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
3212         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
3213         (expectLinkCount):
3214         (TEST):
3215         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
3216         when deciding what to linkify.
3217
3218 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
3219
3220         Build fix - work around rdar://problem/27196668.
3221
3222         * LayoutTestRelay/Configurations/Base.xcconfig:
3223
3224 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
3225
3226         Enhance Windows DRT implementation to support platform scroll wheel events.
3227         https://bugs.webkit.org/show_bug.cgi?id=36002
3228
3229         Reviewed by Brent Fulgham.
3230
3231         Implement function continuousMouseScrollBy in Windows event sender.
3232
3233         * DumpRenderTree/win/EventSender.cpp:
3234         (mouseScrollBy):
3235         (continuousMouseScrollBy):
3236
3237 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
3238
3239         [Sierra] Rebaseline tests to use un-mocked system font metrics
3240         https://bugs.webkit.org/show_bug.cgi?id=159311
3241         <rdar://problem/24138411>
3242
3243         Reviewed in person by Alexey Proskuryakov.
3244
3245         Stop mocking the system font on Sierra.
3246
3247         * DumpRenderTree/mac/DumpRenderTree.mm:
3248         (setDefaultsToConsistentValuesForTesting):
3249         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3250         (WTR::InjectedBundle::platformInitialize):
3251
3252 2016-07-05  Brady Eidson  <beidson@apple.com>
3253
3254         Database process crashes deleting a corrupt SQLite database file (null deref).
3255         https://bugs.webkit.org/show_bug.cgi?id=155506.
3256
3257         Reviewed by Alex Christensen.
3258
3259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3260         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
3261         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
3262         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
3263         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
3264         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
3265
3266 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
3267
3268         run-webkit-tests should print more complete baseline search paths
3269         https://bugs.webkit.org/show_bug.cgi?id=159354
3270
3271         Reviewed by Daniel Bates.
3272
3273         run-webkit-tests used to only print directory names in baseline search paths.
3274         This was ok in basic usage, but quickly got confusing when using
3275         --additional-platform-directory flags.
3276
3277         * Scripts/webkitpy/layout_tests/views/printing.py:
3278         (Printer.print_config):
3279         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3280         (Testprinter.test_print_config):
3281         (Testprinter.test_print_one_line_summary):
3282
3283 2016-07-04  Brady Eidson  <beidson@apple.com>
3284
3285         WebProcesses don't handle DatabaseProcess going away uncleanly..
3286         https://bugs.webkit.org/show_bug.cgi?id=159371
3287
3288         Reviewed by Alex Christensen.
3289
3290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3291         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
3292         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
3293         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
3294         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3295
3296 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3297
3298         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
3299         https://bugs.webkit.org/show_bug.cgi?id=158141
3300
3301         Rubber-stamped by Michael Catanzaro.
3302
3303         Instead of checking for an specific Ubuntu version, query the apt
3304         database to see which version of PHP is available.
3305
3306         * efl/install-dependencies:
3307         * gtk/install-dependencies:
3308
3309 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
3310
3311         webkit-patch failure-reason always raises TypeError
3312         https://bugs.webkit.org/show_bug.cgi?id=159394
3313
3314         Reviewed by Benjamin Poulain.
3315
3316         In r170637 (Bug 133067), the first and second arguments of
3317         pluralize were swapped.
3318
3319         * Scripts/webkitpy/tool/commands/queries.py:
3320         (FailureReason._builder_to_explain): Swap the first and second
3321         arguments of pluralize.
3322
3323 2016-07-02  Youenn Fablet  <youennf@gmail.com>
3324
3325         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
3326         https://bugs.webkit.org/show_bug.cgi?id=152486
3327
3328         Reviewed by Daniel Bates.
3329
3330         Add launch of web-platform-tests server by run-webkit-httpd.
3331         Add two options to disable starting httpd and web-platform-tests servers.
3332
3333         * Scripts/run-webkit-httpd:
3334         (parse_args):
3335         (main):
3336
3337 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
3338
3339         REGRESSION(r189668): Notification tests are flakey
3340         https://bugs.webkit.org/show_bug.cgi?id=159375
3341         <rdar://problem/22760990>
3342
3343         Reviewed by Alexey Proskuryakov.
3344
3345         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
3346         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
3347         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
3348         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
3349
3350         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
3351         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
3352         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
3353         global notification ID mapping, causing the wrong notification to be investigated.
3354
3355         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
3356         manually perform this same mapping. Luckily, this object already receives callbacks every time a
3357         notification is created or destroyed. However, because this object is implemented outside WebKit,
3358         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
3359         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
3360         WebNotificationProvider can properly map between the different IDs.
3361
3362         * WebKitTestRunner/TestController.cpp:
3363         (WTR::TestController::runTestingServerLoop):
3364         (WTR::TestController::simulateWebNotificationClick):
3365         * WebKitTestRunner/WebNotificationProvider.cpp:
3366         (WTR::WebNotificationProvider::showWebNotification):
3367         (WTR::removeGlobalIDFromIDMap):
3368         (WTR::WebNotificationProvider::closeWebNotification):
3369         (WTR::WebNotificationProvider::removeNotificationManager):
3370         (WTR::WebNotificationProvider::simulateWebNotificationClick):
3371         (WTR::WebNotificationProvider::reset):
3372         * WebKitTestRunner/WebNotificationProvider.h:
3373
3374 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
3375
3376         Simplify LayoutTestRelay
3377         https://bugs.webkit.org/show_bug.cgi?id=159353
3378
3379         Reviewed by Daniel Bates.
3380
3381         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
3382         by name and runtime makes no sense.
3383         2. Removed code to create devices, webkitpy always does this in advance.
3384         3. Don't create copies of testing apps - we can install the same one into
3385         each simulator, now that we don't run multiple tester processes in a single simulator.
3386         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
3387         5. Removed code that kept testing apps alive in the background.
3388         6. Slightly updated coding style in functions that I touched.
3389
3390         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3391         Updated for what we acually use at this point.
3392
3393         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3394         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3395         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
3396         (-[LTRelayController ipcIdentifier]):
3397         (-[LTRelayController processName]):
3398         (-[LTRelayController didReceiveStdoutData:]):
3399         (-[LTRelayController didCrashWithMessage:]):
3400         (-[LTRelayController installApp]):
3401         (-[LTRelayController _environmentVariables]):
3402         (-[LTRelayController launchApp]):
3403         (-[LTRelayController start]):
3404         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
3405         (-[LTRelayController uniqueAppPath]): Deleted.
3406         (-[LTRelayController uniqueAppURL]): Deleted.
3407         (-[LTRelayController uniqueAppIdentifier]): Deleted.
3408         (-[LTRelayController createUniqueApp]): Deleted.
3409         * LayoutTestRelay/LayoutTestRelay/main.m:
3410         (usage):
3411         (getRequiredStringArgument):
3412         (main):
3413         (getTestingSimDevice): Deleted.
3414         * Scripts/webkitpy/port/driver.py:
3415         (IOSSimulatorDriver.cmd_line):
3416         * WebKitTestRunner/ios/TestControllerIOS.mm:
3417         (WTR::TestController::platformInitialize):
3418         * WebKitTestRunner/ios/mainIOS.mm:
3419         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
3420         * DumpRenderTree/mac/DumpRenderTree.mm:
3421         (dumpRenderTree):
3422         (-[DumpRenderTree applicationDidEnterBackground:]):
3423
3424 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
3425
3426         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
3427         https://bugs.webkit.org/show_bug.cgi?id=159344
3428
3429         Reviewed by Alex Christensen.
3430
3431         * DumpRenderTree/CMakeLists.txt:
3432
3433 2016-07-01  Youenn Fablet  <youennf@gmail.com>
3434
3435         Add a runtime flag for DOM iterators
3436         https://bugs.webkit.org/show_bug.cgi?id=159300
3437
3438         Reviewed by Alex Christensen.
3439
3440         * DumpRenderTree/mac/DumpRenderTree.mm:
3441         (resetWebPreferencesToConsistentValues):
3442         * DumpRenderTree/win/DumpRenderTree.cpp:
3443         (resetWebPreferencesToConsistentValues):
3444         * Scripts/webkitperl/FeatureList.pm:
3445         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3446         (WTR::InjectedBundle::beginTesting):
3447         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3448         (WTR::TestRunner::setDOMIteratorEnabled):
3449         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3450
3451 2016-06-30  Tina Liu  <iting_liu@apple.com>
3452
3453         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
3454         https://bugs.webkit.org/show_bug.cgi?id=159326
3455
3456         Reviewed by Brady Eidson.
3457
3458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3459         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
3460         (TestWebKitAPI::didFinishLoadForFrame):
3461         (TestWebKitAPI::didChangeBackForwardListForPage):
3462         (TestWebKitAPI::setPageLoaderClient):
3463         Set the page loader client and register for didFinishLoadForFrame and
3464         didChangeBackForwardList callbacks.
3465         (TestWebKitAPI::createSessionStateData):
3466         Load a webpage ("simple.html") and return the session state for this page.
3467         (TestWebKitAPI::TEST):
3468         Restore the page session state with that of "simple.html" without navigation.
3469         Verify that the committed URL is NULL since there's no navigation involved.
3470         Verify that the current item in the back forward list, which should be what
3471         we restored from the session state, has the expected URL.
3472
3473 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
3474
3475         Generators violate bytecode liveness validation
3476         https://bugs.webkit.org/show_bug.cgi?id=159279
3477
3478         Reviewed by Yusuke Suzuki.
3479         
3480         Add Basic to our test harness.
3481
3482         * Scripts/run-javascriptcore-tests:
3483         (runJSCStressTests):
3484
3485 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
3486
3487         [Win][Debug] Assertion fails in TestWTF.
3488         https://bugs.webkit.org/show_bug.cgi?id=159299
3489
3490         Reviewed by Alex Christensen.
3491
3492         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
3493         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
3494         the assertion failure. Since the variable is actually used, there is no need to use the
3495         UNUSED_PARAM macro.
3496
3497         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3498         (TestWebKitAPI::TEST):
3499
3500 2016-06-30  Youenn Fablet  <youennf@gmail.com>
3501
3502         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
3503         https://bugs.webkit.org/show_bug.cgi?id=159166
3504         <rdar://problem/27051759>
3505
3506         Reviewed by Alexey Proskuryakov.
3507
3508         Setting the certificate directory to the copied config.json.
3509
3510         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3511         (WebPlatformTestServer._copy_webkit_test_files):
3512
3513 2016-06-29  Mark Lam  <mark.lam@apple.com>
3514
3515         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
3516         https://bugs.webkit.org/show_bug.cgi?id=159274
3517
3518         Reviewed by Keith Miller.
3519
3520         * DumpRenderTree/mac/DumpRenderTree.mm:
3521         (DumpRenderTreeMain):
3522
3523 2016-06-29  Alex Christensen  <achristensen@webkit.org>
3524
3525         WKWebView should ask WKNavigationDelegate about bad ssl certificates
3526         https://bugs.webkit.org/show_bug.cgi?id=159176
3527
3528         Reviewed by Sam Weinig.
3529
3530         * MiniBrowser/mac/WK2BrowserWindowController.m:
3531         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
3532         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
3533         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
3534
3535 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3536
3537         [GTK] Add missing install dependency after r202619
3538         https://bugs.webkit.org/show_bug.cgi?id=156716
3539
3540         Unreviewed.
3541
3542         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3543
3544 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3545
3546         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3547         https://bugs.webkit.org/show_bug.cgi?id=156716
3548
3549         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3550
3551         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3552         (parse_args):
3553         * Scripts/webkitpy/port/gtk.py:
3554         (GtkPort.__init__):
3555         (GtkPort._driver_class):
3556         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3557         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3558         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3559         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3560         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3561         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3562         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3563         (WestonDriver.check_driver):
3564         (WestonDriver.__init__):
3565         (WestonDriver._start):
3566         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3567         (WestonXvfbDriverDisplayTest):
3568         (WestonXvfbDriverDisplayTest.__init__):
3569         (WestonXvfbDriverDisplayTest._xvfb_run):
3570         (WestonDriverTest.make_driver):
3571         (WestonDriverTest.test_start):
3572         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3573         or to satisfy the pkg-config check of the new added modules in JHBuild.
3574         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3575         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3576         provided by the system are already new enough.
3577         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3578         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3579         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3580         feature to avoid building libdrm when the one provided by the system is new enough.
3581         * gtk/jhbuildrc:
3582         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3583         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3584         This patch implements support for that reusing the same variable that we use with Mesa to set the
3585         custom path for the DRI drivers path.
3586
3587 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3588
3589         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3590         https://bugs.webkit.org/show_bug.cgi?id=159256
3591
3592         Reviewed by Philippe Normand.
3593
3594         We need the last fixes in the repository to make the scream queue
3595         work with apprtc.
3596
3597         * gtk/jhbuild.modules:
3598
3599 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3600
3601         Unreviewed, rolling out r202580.
3602         https://bugs.webkit.org/show_bug.cgi?id=159245
3603
3604         Caused all WKTR tests to fail on GuardMalloc and Production
3605         only for unknown reasons, investigating offline. (Requested by
3606         brrian on #webkit).
3607
3608         Reverted changeset:
3609
3610         "RunLoop::Timer should use constructor templates instead of
3611         class templates"
3612         https://bugs.webkit.org/show_bug.cgi?id=159153
3613         http://trac.webkit.org/changeset/202580
3614
3615 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3616
3617         Use a regex to check if a test step is for JavaScriptCore
3618         https://bugs.webkit.org/show_bug.cgi?id=159224
3619
3620         Reviewed by Geoffrey Garen.
3621
3622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3623         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3625         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3626         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3627         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3628
3629 2016-06-28  Michael Saboff  <msaboff@apple.com>
3630
3631         btjs no longer accepts optional frame count argument
3632         https://bugs.webkit.org/show_bug.cgi?id=159235
3633
3634         Reviewed by Saam Barati.
3635
3636         Fix the detection of optional backtrace-depth parameter to use the length
3637         of the command.
3638
3639         * lldb/lldb_webkit.py:
3640         (btjs):
3641
3642 2016-06-28  Jon Lee  <jonlee@apple.com>
3643
3644         Update animometer.plan
3645
3646         Rubber-stamped by Said Abou-Hallawa.
3647
3648         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3649
3650 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3651
3652         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3653
3654         * Scripts/run-javascriptcore-tests:
3655         (runJSCStressTests):
3656
3657 2016-06-28  Brian Burg  <bburg@apple.com>
3658
3659         RunLoop::Timer should use constructor templates instead of class templates
3660         https://bugs.webkit.org/show_bug.cgi?id=159153
3661
3662         Reviewed by Alex Christensen.
3663
3664         Remove the RunLoop::Timer class template argument, and pass its constructor
3665         a reference to `this` instead of a pointer to `this`.
3666
3667         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3668         (WTR::TestRunner::TestRunner):
3669         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3670         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3671         (TestWebKitAPI::TEST):
3672
3673 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3674
3675         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3676         https://bugs.webkit.org/show_bug.cgi?id=159199
3677
3678         Reviewed by Alexey Proskuryakov.
3679
3680         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3681
3682         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3683         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3684         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3685         an input element getting automatically focused on Mac.
3686
3687 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3688
3689         [Win] Custom elements tests are failing.
3690         https://bugs.webkit.org/show_bug.cgi?id=159139
3691
3692         Reviewed by Alex Christensen.
3693
3694         Enable custom element API when running tests.
3695
3696         * DumpRenderTree/win/DumpRenderTree.cpp:
3697         (resetWebPreferencesToConsistentValues):
3698
3699 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3700
3701         Test commit. Please ignore.
3702         
3703 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3704
3705         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3706         https://bugs.webkit.org/show_bug.cgi?id=155073
3707
3708         Reviewed by Daniel Bates.
3709
3710         * Scripts/webkitperl/FeatureList.pm:
3711
3712 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3713
3714         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3715         https://bugs.webkit.org/show_bug.cgi?id=159077
3716
3717         Reviewed by Tim Horton.
3718
3719         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3720
3721         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3722         which is necessary for UI-side compositing.
3723
3724         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3725         seems to happen for some tests that call window.resizeTo().
3726
3727         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3728         (WTR::InjectedBundlePage::dump): Deleted.
3729         * WebKitTestRunner/TestInvocation.cpp:
3730         (WTR::TestInvocation::dumpResults):
3731         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3732         (WTR::createCGContextFromImage):
3733         (WTR::computeMD5HashStringForContext):
3734         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3735         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3736         (WTR::PlatformWebView::windowSnapshotImage):
3737
3738 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3739
3740         [EFL] Support to build on Debian linux
3741         https://bugs.webkit.org/show_bug.cgi?id=159123
3742
3743         Reviewed by Antonio Gomes.
3744
3745         * efl/install-dependencies: Install libgnutls28-dev.
3746
3747 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3748
3749         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3750         https://bugs.webkit.org/show_bug.cgi?id=159071
3751
3752         Reviewed by Brady Eidson.
3753
3754         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3755         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3756         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3757         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3758         (WTR::TestRunner::setAuthenticationUsername):
3759         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3760         * WebKitTestRunner/TestController.cpp:
3761         (WTR::TestController::TestController):
3762         (WTR::TestController::resetStateToConsistentValues):
3763         (WTR::TestController::didFinishNavigation):
3764         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3765         (WTR::TestController::didReceiveAuthenticationChallenge):
3766         (WTR::TestController::didCommitNavigation):
3767         * WebKitTestRunner/TestController.h:
3768         (WTR::TestController::setBlockAllPlugins):
3769         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3770         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3771         (WTR::TestController::isCurrentInvocation):
3772         * WebKitTestRunner/TestInvocation.cpp:
3773         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3774         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3775
3776 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3777
3778         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3779         https://bugs.webkit.org/show_bug.cgi?id=159129
3780
3781         Reviewed by Alex Christensen.
3782
3783         Implement the function mouseScrollBy in the Windows event sender.
3784
3785         * DumpRenderTree/win/EventSender.cpp:
3786         (mouseScrollBy):
3787         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3788
3789 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3790
3791         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3792         https://bugs.webkit.org/show_bug.cgi?id=159104
3793
3794         Reviewed by Dan Bernstein.
3795         
3796         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3797         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3798
3799         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3800         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3801         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3802
3803 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
3804
3805         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3806         https://bugs.webkit.org/show_bug.cgi?id=159086
3807
3808         Reviewed by Alex Christensen.
3809
3810         Implement required wheel event function in event sender.
3811  
3812         * DumpRenderTree/win/EventSender.cpp:
3813         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3814
3815 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
3816
3817         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3818         https://bugs.webkit.org/show_bug.cgi?id=159104
3819
3820         Reviewed by Mark Lam.
3821         
3822         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3823         WK.
3824
3825         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3826
3827 2016-06-24  David Kilzer  <ddkilzer@apple.com>
3828
3829         parser_unittests.pl should not hardcode list of tests
3830         <https://webkit.org/b/159074>
3831
3832         Reviewed by Daniel Bates.
3833
3834         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3835         Update to read the list of tests from the 'resources' directory,
3836         and instead map file extensions to subroutine names.  Switch to
3837         use File::Basename::fileparse() to get basename and file
3838         extension for each test.
3839         (readTestFiles): Added.  Reads files from the directory passed
3840         in and ignores: hidden files, anything that isn't a plain file,
3841         and expected test results files.
3842
3843 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3844
3845         Fix Windows build.
3846
3847         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3848         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3849
3850 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3851
3852         [EFL] Change download path of libxslt
3853
3854         Unreviewed EFL build fix.
3855
3856         In Korea current download path can't be accessed. Change it.
3857
3858         * efl/jhbuild.modules:
3859
3860 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3861
3862         https://bugs.webkit.org/show_bug.cgi?id=159077
3863
3864         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3865         snapshot the final state of the test in release builds. 
3866
3867         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3868         (WTR::InjectedBundlePage::dump):
3869
3870 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3871
3872         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3873
3874         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3875         (createBitmapContextFromWebView):
3876         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3877         (WTR::PlatformWebView::windowSnapshotImage):
3878
3879 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3880
3881         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3882         https://bugs.webkit.org/show_bug.cgi?id=159077
3883
3884         Reviewed by Tim Horton.
3885
3886         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3887         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3888         thus enabling testing of more things.
3889
3890         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3891         (createBitmapContext): Moved to this file to share it.
3892         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3893         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3894         (createBitmapContextFromWebView):
3895         (BitmapContext::createFromUIImage): Deleted.
3896         (BitmapContext::pixelData): Deleted.
3897         (BitmapContext::BitmapContext): Deleted.
3898         (computeMD5HashStringForBitmapContext): Deleted.
3899         (dumpBitmap): Deleted.
3900         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3901         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3902         (createPagedBitmapContext):
3903         (createBitmapContext): Deleted.
3904         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3905         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3906         (WTR::InjectedBundlePage::dump): Deleted.
3907         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3908         (WTR::PlatformWebView::windowSnapshotImage):
3909
3910 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3911
3912         [jhbuild] Added libxslt module.
3913         https://bugs.webkit.org/show_bug.cgi?id=159034
3914
3915         Unreviewed, followup for r202373.
3916
3917         * efl/install-dependencies: Removed libxslt 
3918         * gtk/install-dependencies: Ditto.
3919
3920 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3921
3922         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
3923         https://bugs.webkit.org/show_bug.cgi?id=159050
3924
3925         Reviewed by Antonio Gomes.
3926
3927         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
3928
3929         * efl/jhbuild.modules:
3930         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3931         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3932
3933 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3934
3935         [jhbuild] Added libxslt module.
3936         https://bugs.webkit.org/show_bug.cgi?id=159034
3937
3938         Reviewed by Michael Catanzaro.
3939
3940         * efl/jhbuild.modules:
3941         * gtk/jhbuild.modules:
3942
3943 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3944
3945         [Win] Use Windows api function to find top level parent.
3946         https://bugs.webkit.org/show_bug.cgi?id=159021
3947
3948         Reviewed by Brent Fulgham.
3949
3950         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
3951  
3952         * DumpRenderTree/win/UIDelegate.cpp:
3953         (UIDelegate::runModal):
3954         (findTopLevelParent): Deleted.
3955         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3956         (PrintWebUIDelegate::runModal):
3957         (findTopLevelParent): Deleted.
3958
3959 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3960
3961         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
3962         https://bugs.webkit.org/show_bug.cgi?id=158934
3963
3964         Reviewed by Brent Fulgham.
3965
3966         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
3967
3968         * DumpRenderTree/win/TestRunnerWin.cpp:
3969         (TestRunner::clearAllDatabases):
3970
3971 2016-06-22  Saam Barati  <sbarati@apple.com>
3972
3973         run-javascriptcore-tests should have some environment variables for commonly used settings
3974         https://bugs.webkit.org/show_bug.cgi?id=159047
3975
3976         Reviewed by Keith Miller.
3977
3978         This patch adds three environment variables that run-javascriptcore-tests
3979         consults:
3980         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
3981           determines if we should run the api tests or not.
3982         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
3983           determines if we will perform a build or not before running the tests.
3984           to set the default should-build setting.
3985         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
3986           a yaml file. If set, we will run the extra tests it refers to.
3987
3988         All the values in these environment variables will be overridden if an
3989         option is explicitly passed in. For example, the following will run
3990         the api tests:
3991         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
3992
3993         * Scripts/run-javascriptcore-tests:
3994
3995 2016-06-22  Saam barati  <sbarati@apple.com>
3996
3997         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
3998         https://bugs.webkit.org/show_bug.cgi?id=159037
3999         <rdar://problem/26935349>
4000
4001         Reviewed by Benjamin Poulain.
4002
4003         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
4004
4005         * Scripts/run-jsc-stress-tests:
4006
4007 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
4008
4009         Fix style issues in webkitpy
4010         https://bugs.webkit.org/show_bug.cgi?id=159019
4011
4012         Reviewed by Daniel Bates.
4013
4014         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
4015         There is no functionality change.
4016         Only affected file names retained below for brevity.
4017
4018         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
4019         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
4020         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
4021         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
4022         * Scripts/webkitpy/benchmark_runner/utils.py:
4023         * Scripts/webkitpy/common/checkout/changelog.py:
4024         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4025         * Scripts/webkitpy/common/checkout/checkout.py:
4026         * Scripts/webkitpy/common/checkout/checkout_mock.py:
4027         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
4028         * Scripts/webkitpy/common/checkout/commitinfo.py:
4029         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
4030         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
4031         * Scripts/webkitpy/common/checkout/scm/scm.py:
4032         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4033         * Scripts/webkitpy/common/config/committers_unittest.py:
4034         * Scripts/webkitpy/common/config/irc.py:
4035         * Scripts/webkitpy/common/config/ports.py:
4036         * Scripts/webkitpy/common/config/ports_unittest.py:
4037         * Scripts/webkitpy/common/config/urls.py:
4038         * Scripts/webkitpy/common/host_mock.py:
4039         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4040         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4041         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4042         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
4043         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4044         * Scripts/webkitpy/common/net/credentials_unittest.py:
4045         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
4046         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
4047         * Scripts/webkitpy/common/net/statusserver.py:
4048         * Scripts/webkitpy/common/system/autoinstall.py:
4049         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
4050         * Scripts/webkitpy/common/system/executive.py:
4051         * Scripts/webkitpy/common/system/executive_mock.py:
4052         * Scripts/webkitpy/common/system/executive_unittest.py:
4053         * Scripts/webkitpy/common/system/filesystem_mock.py:
4054         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4055         * Scripts/webkitpy/common/system/logutils_unittest.py:
4056         * Scripts/webkitpy/common/system/path.py:
4057         * Scripts/webkitpy/common/system/path_unittest.py:
4058         * Scripts/webkitpy/common/system/platforminfo.py:
4059         * Scripts/webkitpy/common/system/user.py:
4060         * Scripts/webkitpy/common/system/user_unittest.py:
4061         * Scripts/webkitpy/common/system/workspace_unittest.py:
4062         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
4063         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
4064         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
4065         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4066         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4067         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4068         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
4069         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
4070         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4071         * Scripts/webkitpy/layout_tests/models/test_failures.py:
4072         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
4073         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4074         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
4075         * Scripts/webkitpy/layout_tests/views/printing.py:
4076         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4077         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
4078         * Scripts/webkitpy/port/base_unittest.py:
4079         * Scripts/webkitpy/port/driver.py:
4080         * Scripts/webkitpy/port/driver_unittest.py:
4081         * Scripts/webkitpy/port/factory.py:
4082         * Scripts/webkitpy/port/gtk.py:
4083         * Scripts/webkitpy/port/server_process_unittest.py:
4084         * Scripts/webkitpy/port/test.py:
4085         * Scripts/webkitpy/port/win.py:
4086         * Scripts/webkitpy/style/checker.py:
4087         * Scripts/webkitpy/style/checkers/common_unittest.py:
4088         * Scripts/webkitpy/style/checkers/cpp.py:
4089         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4090         * Scripts/webkitpy/style/checkers/js.py:
4091         * Scripts/webkitpy/style/checkers/jsonchecker.py:
4092         * Scripts/webkitpy/style/checkers/png.py:
4093         * Scripts/webkitpy/style/checkers/text.py:
4094         * Scripts/webkitpy/style/checkers/text_unittest.py:
4095         * Scripts/webkitpy/style/error_handlers.py:
4096         * Scripts/webkitpy/style/filter.py:
4097         * Scripts/webkitpy/style/filter_unittest.py:
4098         * Scripts/webkitpy/style/optparser.py:
4099         * Scripts/webkitpy/style/optparser_unittest.py:
4100         * Scripts/webkitpy/test/main.py:
4101         * Scripts/webkitpy/w3c/test_converter.py:
4102         * Scripts/webkitpy/w3c/test_converter_unittest.py:
4103         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4104         * Scripts/webkitpy/xcode/simulator.py:
4105
4106 2016-06-22  Brady Eidson  <beidson@apple.com>
4107
4108         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
4109         https://bugs.webkit.org/show_bug.cgi?id=158894
4110
4111         Reviewed by Alex Christensen.
4112
4113         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4114         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
4115         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
4116         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
4117
4118 2016-06-22  Jon Lee  <jonlee@apple.com>
4119
4120         Update animometer.plan
4121         https://bugs.webkit.org/show_bug.cgi?id=159012
4122
4123         Reviewed by Ryosuke Niwa.
4124
4125         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
4126
4127 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4128
4129         W3C test importer should generate files to ignore by WebKit SCM
4130         https://bugs.webkit.org/show_bug.cgi?id=142743
4131
4132         Reviewed by Darin Adler.
4133
4134         TestDownloader generates the .gitignore file according submodules git repository information.
4135         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
4136
4137         * Scripts/webkitpy/w3c/test_downloader.py:
4138         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
4139         * Scripts/webkitpy/w3c/test_importer.py:
4140         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
4141         (TestImporter):
4142         (TestImporter.write_init_py): Writing not empty __init__.py files.
4143         (TestImporter.import_tests): Using  of write_init_py. 
4144         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4145         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
4146         (TestImporterTest):
4147         (TestImporterTest.test_initpy_generation): Added __init__.py test.
4148
4149 2016-06-21  Sam Weinig  <sam@webkit.org>
4150
4151         WKWebView with no WKNavigationDelegate does not follow universal links
4152         <rdar://problem/24374110>
4153         https://bugs.webkit.org/show_bug.cgi?id=158997
4154
4155         Reviewed by Dan Bernstein.
4156
4157         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4158         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
4159         Add a new test that shows that we have a default navigation delegate by swizzling
4160         -[NSWorkspace openURL:]. This will only be called if there is a default client.
4161
4162 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4163
4164         [Win] Implement modal dialog support in MiniBrowser.
4165         https://bugs.webkit.org/show_bug.cgi?id=158976
4166
4167         Reviewed by Brent Fulgham.
4168
4169         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4170         (PrintWebUIDelegate::createWebViewWithRequest):
4171         (getHandleFromWebView):
4172         (PrintWebUIDelegate::webViewClose):
4173         (PrintWebUIDelegate::setFrame):
4174         (PrintWebUIDelegate::webViewFrame):
4175         (PrintWebUIDelegate::canRunModal):
4176         (findTopLevelParent):
4177         (PrintWebUIDelegate::runModal):
4178         (PrintWebUIDelegate::createModalDialog):
4179         * MiniBrowser/win/PrintWebUIDelegate.h:
4180         (PrintWebUIDelegate::webViewClose):
4181         (PrintWebUIDelegate::setFrame):
4182         (PrintWebUIDelegate::webViewFrame):
4183         (PrintWebUIDelegate::canRunModal):
4184         (PrintWebUIDelegate::runModal):
4185
4186 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4187
4188         window.showModalDialog doesn't work in DumpRenderTree on Windows
4189         https://bugs.webkit.org/show_bug.cgi?id=53675
4190
4191         Reviewed by Brent Fulgham.
4192
4193         Implement modal dialog support in DumpRenderTree.
4194
4195         * DumpRenderTree/win/UIDelegate.cpp:
4196         (UIDelegate::canRunModal):
4197         (getHandleFromWebView):
4198         (UIDelegate::createModalDialog):
4199         (findTopLevelParent):
4200         (UIDelegate::runModal):
4201         (UIDelegate::webViewClose):
4202         * DumpRenderTree/win/UIDelegate.h:
4203
4204 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
4205
4206         Fix formatting issues reported by check-webkit-style
4207         https://bugs.webkit.org/show_bug.cgi?id=159008
4208
4209         Reviewed by Alexey Proskuryakov.
4210
4211         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
4212         There is no functionality change.
4213
4214         * Scripts/webkitpy/tool/bot/irc_command.py:
4215         (Restart.execute):
4216         (Rollout):
4217         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
4218         (IRCBotTest.test_exception_during_command):
4219         (IRCBotTest.test_exception_during_command.CommandWithException):
4220         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
4221         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
4222         (test_missing_unit_test_results_path):
4223         (test_layout_test_results):
4224         * Scripts/webkitpy/tool/bot/queueengine.py:
4225         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
4226         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
4227         (AbstractSequencedCommand):
4228         (AbstractSequencedCommand.__init__):
4229         * Scripts/webkitpy/tool/commands/download.py:
4230         (Land):
4231         * Scripts/webkitpy/tool/commands/openbugs.py:
4232         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
4233         (OpenBugsTest):
4234         * Scripts/webkitpy/tool/commands/queries.py:
4235         (PatchesToCommitQueue):
4236         (PatchesToCommitQueue.__init__):
4237         (PatchesToCommitQueue._needs_commit_queue):
4238         * Scripts/webkitpy/tool/commands/queries_unittest.py:
4239         (PrintExpectationsTest.test_platform):
4240         (PrintBaselinesTest):
4241         (PrintBaselinesTest.setUp):
4242         * Scripts/webkitpy/tool/commands/queues.py:
4243         (AbstractQueue):
4244         (AbstractQueue.__init__):
4245         (AbstractQueue.execute):
4246         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4247         (test_auto_retry):
4248         * Scripts/webkitpy/tool/commands/rebaseline.py:
4249         (AbstractParallelRebaselineCommand._files_to_add):
4250         (AbstractParallelRebaselineCommand):
4251         (AbstractParallelRebaselineCommand._rebaseline):
4252         * Scripts/webkitpy/tool/commands/setupgitclone.py:
4253         (SetupGitClone):
4254         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4255         * Scripts/webkitpy/tool/commands/stepsequence.py:
4256         * Scripts/webkitpy/tool/commands/upload.py:
4257         (PostCommits._comment_text_for_commit):
4258         (PostCommits):
4259         (PostCommits.execute):
4260         (MarkBugFixed):
4261         (MarkBugFixed.__init__):
4262         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4263         (UploadCommandsTest):
4264         (UploadCommandsTest.test_commit_message_for_current_diff):
4265         * Scripts/webkitpy/tool/grammar_unittest.py:
4266         (GrammarTest):
4267         (GrammarTest.test_join_with_separators):
4268         * Scripts/webkitpy/tool/multicommandtool.py:
4269         (HelpCommand.__init__):
4270         (HelpCommand):
4271         (HelpCommand._help_epilog):
4272         (HelpCommand._remove_help_options):
4273         (MultiCommandTool):
4274         (MultiCommandTool.__init__):