Updates to Resource Load Statistics: Get the right website data store and introduce...
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-10  John Wilander  <wilander@apple.com>
2
3         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
4         https://bugs.webkit.org/show_bug.cgi?id=167474
5         <rdar://problem/24681808>
6         <rdar://problem/24703286>
7         <rdar://problem/30290270>
8
9         This patch adds test infrastructure to allow testing 
10         of the various rules in place for data records removal.
11
12         Reviewed by Andy Estes.
13
14         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
15         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
16         (WTR::InjectedBundle::didReceiveMessageToPage):
17             Callback mechanism to tell pages that a website data store
18             scan has happened.
19         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
20         (WTR::TestRunner::setStatisticsPrevalentResource):
21         (WTR::TestRunner::isStatisticsPrevalentResource):
22         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
23         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
24         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
25         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
26         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
27         (WTR::TestRunner::statisticsFireDataModificationHandler):
28         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
29         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
30         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
31         (WTR::TestRunner::statisticsResetToConsistentState):
32         * WebKitTestRunner/InjectedBundle/TestRunner.h:
33         * WebKitTestRunner/TestController.cpp:
34         (WTR::TestController::setStatisticsPrevalentResource):
35         (WTR::TestController::isStatisticsPrevalentResource):
36         (WTR::TestController::setStatisticsHasHadUserInteraction):
37         (WTR::TestController::isStatisticsHasHadUserInteraction):
38         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
39         (WTR::TestController::statisticsFireDataModificationHandler):
40         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
41         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
42         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
43         (WTR::TestController::statisticsResetToConsistentState):
44         * WebKitTestRunner/TestController.h:
45             These are all configuration and test functions.
46         * WebKitTestRunner/TestInvocation.cpp:
47         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
48
49 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
50
51         REGRESSION(r182916) run-perf-tests never timeouts
52         https://bugs.webkit.org/show_bug.cgi?id=167626
53
54         Reviewed by Ryosuke Niwa.
55
56         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
57         was beeing ignored because the driver was created with no_timeout=True
58         unconditionally.
59         This adds a new parameter --no-timeout (disabled by default), that
60         allows to use the driver with the expected timeout values.
61         It also passes --no-timeout to DRT/WTR to ensure that timeouts
62         are always controlled by the Python Driver.
63
64         * Scripts/webkitpy/performance_tests/perftest.py:
65         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
66         (PerfTest.run): Disabling timeout should be done when the Driver is created.
67         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
68         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
69         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
70         (_run_tests_set): Pass the no-timeout parameter.
71         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
72         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
73         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
74         (MainTest.test_parse_args): Test that the argument no-timeout.
75
76 2017-02-10  Daniel Bates  <dabates@apple.com>
77
78         Detach frame from document when entering page cache
79         https://bugs.webkit.org/show_bug.cgi?id=166774
80         <rdar://problem/29904368>
81
82         Reviewed by Chris Dumez.
83
84         * DumpRenderTree/mac/DumpRenderTree.mm:
85         (resetWebPreferencesToConsistentValues):
86         * DumpRenderTree/win/DumpRenderTree.cpp:
87         (resetWebPreferencesToConsistentValues):
88         * WebKitTestRunner/TestController.cpp:
89         (WTR::TestController::resetPreferencesToConsistentValues):
90
91 2017-02-10  Tim Horton  <timothy_horton@apple.com>
92
93         Infinite UI process hang under ensurePositionInformationIsUpToDate
94         https://bugs.webkit.org/show_bug.cgi?id=168154
95         <rdar://problem/30428673>
96
97         Reviewed by Simon Fraser.
98
99         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
100         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
101         (recursiveFindHighlightLongPressRecognizer):
102         (TEST):
103         Add a somewhat nasty test that does an async interaction information update, but
104         kills the Web process before it arrives, and then does a sync interaction
105         information update, which will wait for the oustanding async interaction
106         information update if we still think it's coming. Before the patch, this
107         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
108
109 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
110
111         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
112         https://bugs.webkit.org/show_bug.cgi?id=168127
113         rdar://problem/30467120
114
115         Reviewed by Tim Horton.
116
117         Reparent the web view before we try to fetch it via:
118             [[[window contentView] subviews] objectAtIndex:0];
119         which would throw an exception if the test unparented it.
120
121         * DumpRenderTree/mac/DumpRenderTree.mm:
122         (resetWebViewToConsistentStateBeforeTesting):
123         (runTest):
124
125 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
126
127         [Resource Timing] Enable Resource Timing by default in Tests
128         https://bugs.webkit.org/show_bug.cgi?id=168145
129
130         Reviewed by Ryosuke Niwa.
131
132         * DumpRenderTree/mac/DumpRenderTree.mm:
133         (resetWebPreferencesToConsistentValues):
134         * DumpRenderTree/win/DumpRenderTree.cpp:
135         (resetWebPreferencesToConsistentValues):
136         * WebKitTestRunner/TestController.cpp:
137         (WTR::TestController::resetPreferencesToConsistentValues):
138
139 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
140
141         Removing LayoutTestRelay
142         https://bugs.webkit.org/show_bug.cgi?id=165927
143
144         Reviewed by Daniel Bates.
145         Part 2
146
147         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
148         simulators through simctl (iOS 10 and later), use this functionality instead.
149
150         * BuildSlaveSupport/built-product-archive:
151         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
152         Added a FIXME that we will need to implement similar archiving machinery once we build
153         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
154         * BuildSlaveSupport/kill-old-processes:
155         (main): Remove LayoutTestRelay from list of processes.
156         * LayoutTestRelay: Removed LayoutTestRelay.
157         * Makefile:
158         * Scripts/build-layouttestrelay: Removed.
159         * Scripts/build-webkit: Removed LayoutTestRelay references.
160
161 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
162
163         [WebCrypto] Add WebCryptoAPI to watchlist
164         https://bugs.webkit.org/show_bug.cgi?id=168138
165
166         Reviewed by Youenn Fablet.
167
168         * Scripts/webkitpy/common/config/watchlist:
169
170 2017-02-10  Brady Eidson  <beidson@apple.com>
171
172         Replace all WebKit Library Version checks in WK2 with SDK version checks.
173         https://bugs.webkit.org/show_bug.cgi?id=168124
174
175         Reviewed by Geoffrey Garen.
176
177         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
178         
179         * MiniBrowser/mac/main.m:
180         (main):
181         * MobileMiniBrowser/MobileMiniBrowser/main.m:
182         (main):
183         * TestWebKitAPI/ios/mainIOS.mm:
184         (main):
185         * TestWebKitAPI/mac/mainMac.mm:
186         (main):
187         * WebKitTestRunner/ios/mainIOS.mm:
188         (main):
189         * WebKitTestRunner/mac/main.mm:
190         (setDefaultsToConsistentValuesForTesting):
191
192 2017-02-10  Alex Christensen  <achristensen@webkit.org>
193
194         Fix El Capitan build.
195
196         * Scripts/build-webkit:
197         Don't build libwebrtc anywhere for now.
198
199 2017-02-10  Andy Estes  <aestes@apple.com>
200
201         Move two MiniBrowserBundle settings out of the .pbxproj
202         https://bugs.webkit.org/show_bug.cgi?id=168106
203
204         Reviewed by Tim Horton.
205
206         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
207         the project file. This removes the project file override.
208
209         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
210
211         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
212         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
213
214 2017-02-10  Alex Christensen  <achristensen@webkit.org>
215
216         Fix 32-and-64-bit build on El Capitan.
217
218         * Scripts/build-webkit:
219         Somebody's building with something like this:
220         build-webkit ARCHS="i386 x86_64"
221         We want this to also not build libwebrtc for now.
222
223 2017-02-10  Alex Christensen  <achristensen@webkit.org>
224
225         Fix 32-bit build on El Capitan.
226
227         * Scripts/build-webkit:
228         The bot uses ARCHS=i386 instead of --32-bit.
229         This is a hack, but it should fix the bot until I can do a better fix in the morning.
230
231 2017-02-10  Alex Christensen  <achristensen@webkit.org>
232
233         Fix 32-bit build on El Capitan.
234
235         * Scripts/build-webkit:
236         Don't build i386 libwebrtc.
237
238 2017-02-09  Alex Christensen  <achristensen@webkit.org>
239
240         Unreviewed, rolling out r212040.
241
242         Broke build.  I'm not surprised
243
244         Reverted changeset:
245
246         "[WebRTC][Mac] Activate libwebrtc"
247         https://bugs.webkit.org/show_bug.cgi?id=167293
248         http://trac.webkit.org/changeset/212040
249
250 2017-02-09  Alex Christensen  <achristensen@webkit.org>
251
252         Build libwebrtc on bots without using it yet
253         https://bugs.webkit.org/show_bug.cgi?id=168062
254
255         Reviewed by Brent Fulgham.
256
257         * Scripts/build-webkit:
258
259 2017-02-09  Alex Christensen  <achristensen@webkit.org>
260
261         Don't build libwebrtc.
262
263         * Scripts/build-webkit:
264         Not ready yet.  It broke El Capitan and iOS.
265
266 2017-02-09  Alex Christensen  <achristensen@webkit.org>
267
268         Build libwebrtc on bots without using it yet
269         https://bugs.webkit.org/show_bug.cgi?id=168062
270
271         Reviewed by Brent Fulgham.
272
273         * Scripts/build-webkit:
274
275 2017-02-09  Alex Christensen  <achristensen@webkit.org>
276
277         Rename isAppleMacWebKit to isAppleCocoaWebKit
278         https://bugs.webkit.org/show_bug.cgi?id=168075
279
280         Reviewed by Geoffrey Garen.
281
282         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
283
284         * Scripts/build-api-tests:
285         * Scripts/build-dumprendertree:
286         * Scripts/build-jsc:
287         (buildMyProject):
288         * Scripts/build-layouttestrelay:
289         * Scripts/build-webkit:
290         * Scripts/build-webkittestrunner:
291         * Scripts/run-api-tests:
292         (isSupportedPlatform):
293         (runTest):
294         (listAllTests):
295         (prepareEnvironmentForRunningTestTool):
296         * Scripts/run-content-extension-tester:
297         * Scripts/run-javascriptcore-tests:
298         * Scripts/run-minibrowser:
299         * Scripts/show-pretty-diff:
300         * Scripts/webkitdirs.pm:
301         (determineBaseProductDir):
302         (determineArchitecture):
303         (determinePassedArchitecture):
304         (safariPath):
305         (builtDylibPathForName):
306         (checkFrameworks):
307         (isAppleWebKit):
308         (isAppleCocoaWebKit):
309         (determineNmPath):
310         (launcherName):
311         (wrapperPrefixIfNeeded):
312         (isCMakeBuild):
313         (mobileSafariBundle):
314         (debugSafari):
315         (runSafari):
316         (runMiniBrowser):
317         (debugMiniBrowser):
318         (runWebKitTestRunner):
319         (debugWebKitTestRunner):
320         (isAppleMacWebKit): Deleted.
321         * Scripts/webkitperl/FeatureList.pm:
322
323 2017-02-09  Alex Christensen  <achristensen@webkit.org>
324
325         Revert r211991
326         https://bugs.webkit.org/show_bug.cgi?id=168062
327
328         * Scripts/build-webkit:
329         Not quite ready yet.
330
331 2017-02-09  Alex Christensen  <achristensen@webkit.org>
332
333         Build libwebrtc on bots without using it yet
334         https://bugs.webkit.org/show_bug.cgi?id=168062
335
336         Reviewed by Brent Fulgham.
337
338         * Scripts/build-webkit:
339         Build libwebrtc on Mac when we build ANGLE.
340
341 2017-02-09  Youenn Fablet  <youenn@apple.com>
342
343         Improve W3C importer command line options
344         https://bugs.webkit.org/show_bug.cgi?id=167448
345
346         Reviewed by Ryosuke Niwa.
347
348         Making the list of test paths to import the main arguments of the script.
349         Allow passing the source directory to import as a -s option.
350         Adding a warning when given test paths are skipped by default in ImportExpectations.
351
352         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
353         Link conversion rules do not change when imported tests are downloaded by the script.
354
355         * Scripts/webkitpy/w3c/test_importer.py:
356         (main):
357         (parse_args):
358         (TestImporter.__init__):
359         (TestImporter.do_import):
360         (TestImporter):
361         (TestImporter.check_imported_expectations):
362
363 2017-02-08  Chris Dumez  <cdumez@apple.com>
364
365         Update web-platform-tests resources
366         https://bugs.webkit.org/show_bug.cgi?id=168026
367
368         Reviewed by Youenn Fablet.
369
370         Stop copying testharness.js from resources/ to web-platform-tests/resources.
371
372         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
373         (WebPlatformTestServer._copy_webkit_test_files):
374
375 2017-02-08  Andy Estes  <aestes@apple.com>
376
377         Custom protocols should not continue loading after a network process crash
378         https://bugs.webkit.org/show_bug.cgi?id=168028
379         <rdar://problem/27607520>
380
381         Reviewed by Brady Eidson.
382
383         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
384         (processGroup):
385         (-[CloseWhileStartingProtocol startLoading]):
386         (-[CloseWhileStartingProtocol stopLoading]):
387         (TestWebKitAPI::runTest):
388         (TestWebKitAPI::TEST):
389
390 2017-02-08  Dan Bernstein  <mitz@apple.com>
391
392         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
393         https://bugs.webkit.org/show_bug.cgi?id=168031
394
395         Reviewed by Tim Horton.
396
397         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
398         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
399         (TEST):
400         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
401         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
402
403 2017-02-08  Chris Dumez  <cdumez@apple.com>
404
405         Use smaller tiles in windows that are not active to facilitate App Napping
406         https://bugs.webkit.org/show_bug.cgi?id=167997
407         <rdar://problem/30358835>
408
409         Reviewed by Simon Fraser.
410
411         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
412         (WTR::PlatformWebView::setWindowIsKey):
413         Actually update windowIsKey state of NSWindow so the WebView
414         properly updates its activity state.
415
416 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
417
418         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
419         https://bugs.webkit.org/show_bug.cgi?id=167942
420         <rdar://problem/30315079>
421
422         Reviewed by Tim Horton.
423
424         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
425         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
426         contenteditable in these cases.
427
428         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
429         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
430         performDragOperation:) directly.
431
432         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
433         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
434         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
435         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
436         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
437         (-[DragSource draggingSourceOperationMaskForLocal:]):
438         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
439         (-[DragInfo lastMousePosition]):
440         (-[DragInfo setLastMousePosition:]):
441         (-[DragInfo draggingDestinationWindow]):
442         (-[DragInfo draggingSourceOperationMask]):
443         (-[DragInfo draggingLocation]):
444         (-[DragInfo draggedImageLocation]):
445         (-[DragInfo draggedImage]):
446         (-[DragInfo draggingPasteboard]):
447         (-[DragInfo draggingSource]):
448         (-[DragInfo draggingSequenceNumber]):
449         (-[DragInfo slideDraggedImageTo:]):
450         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
451         (-[DragInfo draggingFormation]):
452         (-[DragInfo setDraggingFormation:]):
453         (-[DragInfo animatesToDestination]):
454         (-[DragInfo setAnimatesToDestination:]):
455         (-[DragInfo numberOfValidItemsForDrop]):
456         (-[DragInfo setNumberOfValidItemsForDrop:]):
457         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
458         (-[DragInfo springLoadingHighlight]):
459         (-[DragInfo resetSpringLoading]):
460         (TestWebKitAPI::getTestImage):
461         (TestWebKitAPI::webViewAfterPerformingDragOperation):
462         (TestWebKitAPI::TEST):
463         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
464
465 2017-02-08  Jer Noble  <jer.noble@apple.com>
466
467         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
468         https://bugs.webkit.org/show_bug.cgi?id=168007
469
470         Reviewed by Alex Christensen.
471
472         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
473         (didFinishLoadForFrame):
474         (TestWebKitAPI::TEST):
475
476 2017-02-08  Commit Queue  <commit-queue@webkit.org>
477
478         Unreviewed, rolling out r211873.
479         https://bugs.webkit.org/show_bug.cgi?id=168001
480
481         It's in jhbuild for consistent layout tests (Requested by
482         mcatanzaro on #webkit).
483
484         Reverted changeset:
485
486         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
487         https://bugs.webkit.org/show_bug.cgi?id=167993
488         http://trac.webkit.org/changeset/211873
489
490 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
491
492         [GTK] Add icu packages to Tools/gtk/install-dependencies
493         https://bugs.webkit.org/show_bug.cgi?id=167993
494
495         Reviewed by Michael Catanzaro.
496
497         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
498         depending in the GNU/Linux distribution)
499
500 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
501
502         Update flakiness dashboard configuration.
503         https://bugs.webkit.org/show_bug.cgi?id=167957
504
505         Reviewed by Alexey Proskuryakov.
506
507         * TestResultServer/static-dashboards/builders.jsonp:
508
509 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
510
511         Replace a bot that has an incorrect configuration.
512         https://bugs.webkit.org/show_bug.cgi?id=167747
513
514         Rubber-stamped by Alexey Proskuryakov.
515
516         * BuildSlaveSupport/build.webkit.org-config/config.json:
517
518 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
519
520         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
521         https://bugs.webkit.org/show_bug.cgi?id=167927
522
523         Reviewed by Brent Fulgham.
524
525         Enable ComplexTextController API tests on the Win and GTK ports.
526
527         * TestWebKitAPI/PlatformGTK.cmake:
528         * TestWebKitAPI/PlatformWin.cmake:
529
530 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
531
532         File index appended to previous file in svn-create-patch with SVN 1.9
533         https://bugs.webkit.org/show_bug.cgi?id=167903
534         <rdar://problem/30387395>
535
536         Reviewed by Daniel Bates.
537
538         * Scripts/VCSUtils.pm:
539         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
540         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
541         trailing newline character from the expected result before comparing it to the actual result.
542
543 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
544
545         [webkitdirs] remove unused host_processor variable in determineArchitecture()
546         https://bugs.webkit.org/show_bug.cgi?id=167936
547
548         Reviewed by Michael Catanzaro.
549
550         * Scripts/webkitdirs.pm:
551         (determineArchitecture):
552         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
553         since r195083.
554
555 2017-02-07  Youenn Fablet  <youenn@apple.com>
556
557         Use a JSON file to define which WPT files/folders to import
558         https://bugs.webkit.org/show_bug.cgi?id=167923
559
560         Reviewed by Alex Christensen.
561
562         * Scripts/webkitpy/w3c/test_downloader.py:
563         (TestDownloader.__init__):
564         (TestDownloader._init_paths_from_expectations):
565         * Scripts/webkitpy/w3c/test_importer.py:
566         (parse_args):
567         * Scripts/webkitpy/w3c/test_importer_unittest.py:
568
569 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
570
571         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
572         https://bugs.webkit.org/show_bug.cgi?id=167916
573
574         Reviewed by Carlos Garcia Campos.
575
576         URL of mesa-11.0.6.tar.xz has been moved.
577
578         * gtk/jhbuild.modules: Fix the module path.
579
580 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
581
582         Static Analyzer: Address some leaks in MiniBrowser
583         https://bugs.webkit.org/show_bug.cgi?id=167897
584
585         Reviewed by Alexey Proskuryakov.
586
587         * MiniBrowser/mac/BrowserWindowController.m:
588         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
589         * MiniBrowser/mac/ExtensionManagerWindowController.m:
590         (-[ExtensionManagerWindowController add:]):
591         (-[ExtensionManagerWindowController remove:]):
592         * MiniBrowser/mac/SettingsController.m:
593         (-[SettingsController _populateMenu]):
594         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
595         Address obvious leaks caught by the static analyzer.
596
597 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
598
599         Migrate ComplexTextController to use platform-independent types
600         https://bugs.webkit.org/show_bug.cgi?id=167833
601
602         Reviewed by Brent Fulgham.
603
604         Migrate tests away from platform-dependent types.
605
606         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
607         (TestWebKitAPI::TEST_F):
608
609 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
610
611         Correct File Path Handling in SecurityOrigin and FileSystem
612         https://bugs.webkit.org/show_bug.cgi?id=167894
613         <rdar://problem/30380080>
614
615         Reviewed by Alexey Proskuryakov.
616
617         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
618         and perform same-volume checks using filesystem-compatible paths.        
619         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
620         filesystem paths, and perform validation of same-volume checks.
621         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
622         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
623         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
624         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
625
626 2017-02-06  Jer Noble  <jer.noble@apple.com>
627
628         Playback stalls when a SourceBuffer append causes frame eviction
629         https://bugs.webkit.org/show_bug.cgi?id=167834
630
631         Reviewed by Eric Carlson.
632
633         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
634         for the WTF::MediaTime class.
635
636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
637         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
638         (TestWebKitAPI::TEST):
639         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
640         (WTF::operator<<):
641         (TestWebKitAPI::TestSample::create):
642         (TestWebKitAPI::TestSample::TestSample):
643         (TestWebKitAPI::TEST_F):
644
645 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
646
647         Change capitalization in platform name after r211735.
648
649         Unreviewed dashboard fix.
650
651         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
652         (WebKitBuildbot):
653
654 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
655
656         Move the Leaks bot to Sierra
657         https://bugs.webkit.org/show_bug.cgi?id=167886
658
659         Reviewed by Daniel Bates.
660
661         * BuildSlaveSupport/build.webkit.org-config/config.json:
662         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
663         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
664         (LeaksViewer._displayURLPrompt):
665         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
666         (WebKitBuildbot):
667
668 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
669
670         Prevent app crash on launch during simctl install workaround
671         https://bugs.webkit.org/show_bug.cgi?id=167685
672
673         Reviewed by Daniel Bates.
674
675         * Scripts/webkitpy/port/simulator_process.py:
676         (SimulatorProcess.__init__): Pass environment to install.
677         * Scripts/webkitpy/xcode/simulator.py:
678         (Device.install_app): Accept environment, pass environment to launch.
679
680 2017-02-06  Alex Christensen  <achristensen@webkit.org>
681
682         Rebase API tests after r211638
683         https://bugs.webkit.org/show_bug.cgi?id=167779
684
685         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
686         (TestWebKitAPI::TEST_F):
687         URLs with non-special schemes and characters like % in the host now fail to parse,
688         more like their special counterparts and according to spec.
689
690 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
691
692         Unreviewed trivial fix after r211697.
693         https://bugs.webkit.org/show_bug.cgi?id=167863
694
695         * Scripts/run-javascriptcore-tests:
696         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
697
698 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
699
700         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
701         https://bugs.webkit.org/show_bug.cgi?id=167850
702
703         Reviewed by Tim Horton.
704
705         * DumpRenderTree/TestRunner.cpp:
706         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
707
708 2017-02-04  Andreas Kling  <akling@apple.com>
709
710         Plug some leaks in TestController and UIScriptContext.
711         <https://webkit.org/b/167839>
712
713         Reviewed by Alexey Proskuryakov.
714
715         Fix a couple of the leaks seen on the leaks bot.
716
717         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
718         (UIScriptContext::runUIScript):
719         * WebKitTestRunner/TestController.cpp:
720         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
721         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
722
723 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
724
725         WK1 mouse events are missing movementX and movementY for pointerlock.
726         https://bugs.webkit.org/show_bug.cgi?id=167775
727         rdar://problem/30343810
728
729         Reviewed by Alexey Proskuryakov.
730
731         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
732
733         * DumpRenderTree/mac/EventSendingController.mm:
734         (-[EventSendingController mouseMoveToX:Y:]):
735         * WebKitTestRunner/mac/EventSenderProxy.mm:
736         (WTR::EventSenderProxy::mouseMoveTo):
737
738 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
739
740         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
741         https://bugs.webkit.org/show_bug.cgi?id=167774
742
743         Reviewed by Tim Horton.
744
745         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
746         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
747         web process are async, so the callback fires after the web process gets the new state.
748
749         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
750         (WTR::UIScriptController::removeViewFromWindow):
751         (WTR::UIScriptController::addViewToWindow):
752         * DumpRenderTree/mac/DumpRenderTree.mm:
753         (createWebViewAndOffscreenWindow):
754         (resetWebViewToConsistentStateBeforeTesting):
755         * DumpRenderTree/mac/DumpRenderTreeMac.h:
756         * DumpRenderTree/mac/UIScriptControllerMac.mm:
757         (WTR::UIScriptController::removeViewFromWindow):
758         (WTR::UIScriptController::addViewToWindow):
759         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
760         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
761         (WTR::UIScriptController::removeViewFromWindow):
762         (WTR::UIScriptController::addViewToWindow):
763         * TestRunnerShared/UIScriptContext/UIScriptController.h:
764         * WebKitTestRunner/PlatformWebView.h:
765         * WebKitTestRunner/TestController.cpp:
766         (WTR::TestController::resetStateToConsistentValues):
767         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
768         (WTR::PlatformWebView::removeFromWindow):
769         (WTR::PlatformWebView::addToWindow):
770         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
771         (WTR::UIScriptController::removeViewFromWindow):
772         (WTR::UIScriptController::addViewToWindow):
773         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
774         (WTR::PlatformWebView::removeFromWindow):
775         (WTR::PlatformWebView::addToWindow):
776         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
777         (WTR::UIScriptController::removeViewFromWindow):
778         (WTR::UIScriptController::addViewToWindow):
779
780 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
781
782         Remove check for SkipSafariExecutableEntitlementChecks
783         https://bugs.webkit.org/show_bug.cgi?id=167762
784
785         Reviewed by Dan Bernstein.
786
787         Follow-up fix: don't break internal behavior.
788
789         * Scripts/webkitdirs.pm:
790         (safariPath):
791         (executableHasEntitlements): Deleted.
792         (safariPathFromSafariBundle): Deleted.
793         (installedSafariPath): Deleted.
794
795 2017-02-03  Daniel Bates  <dabates@apple.com>
796
797         [Mac][WK2] Add SPI to override the Content Security Policy of a page
798         https://bugs.webkit.org/show_bug.cgi?id=167810
799         <rdar://problem/30102568>
800
801         Reviewed by Anders Carlsson.
802
803         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
804
805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
806         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
807         (TEST):
808         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
809         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
810         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
811         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
812
813 2017-02-02  Alex Christensen  <achristensen@webkit.org>
814
815         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
816         https://bugs.webkit.org/show_bug.cgi?id=167773
817         <rdar://problem/30221102>
818
819         Reviewed by Ryosuke Niwa.
820
821         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
822         (TestWebKitAPI::TEST_F):
823
824 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
825
826         Remove check for SkipSafariExecutableEntitlementChecks
827         https://bugs.webkit.org/show_bug.cgi?id=167762
828         rdar://problem/22480673
829
830         Reviewed by Dan Bernstein.
831
832         * Scripts/webkitdirs.pm:
833         (safariPathFromSafariBundle):
834         (skipSafariExecutableEntitlementChecks): Deleted.
835
836 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
837
838         Undefined subroutine in svn-create-patch
839         https://bugs.webkit.org/show_bug.cgi?id=167742
840
841         Unreviewed build-fix after r211543.
842
843         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
844
845 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
846
847         Unreviewed. Fix jhbuild dependencies build.
848
849         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
850         Patch updated.
851
852 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
853
854         [EME][GStreamer] Fixed decryptor selection
855         https://bugs.webkit.org/show_bug.cgi?id=167588
856
857         Reviewed by Žan Doberšek.
858
859         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
860
861         * gtk/jhbuild.modules: Added patches to gstreamer and
862         gst-plugins-good packages.
863         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
864         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
865
866 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
867
868         Make run-benchmark script supports 'config' key in test plan.
869         https://bugs.webkit.org/show_bug.cgi?id=167715
870
871         Reviewed by Ryosuke Niwa.
872
873         Add support for 'config' key in test paln.
874         'config' key is a dictionary that specifies environment configurations while test is running.
875         Specifies orientation to be portrait in MotionMark benchmark.
876
877         * Scripts/webkitpy/benchmark_runner/README.md:
878         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
879         (BenchmarkRunner.__init__):
880         (BenchmarkRunner._run_benchmark):
881         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
882         (BrowserDriver.prepare_env):
883         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
884         (LinuxBrowserDriver.prepare_env):
885         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
886         (OSXBrowserDriver.prepare_env):
887         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
888         (OSXSafariDriver.prepare_env):
889         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
890
891 2017-02-01  Daniel Bates  <dabates@apple.com>
892
893         REGRESSION (r210820): svn-create-patch does not emit property change only diff
894         https://bugs.webkit.org/show_bug.cgi?id=167169
895
896         Reviewed by David Kilzer.
897
898         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
899         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
900         header from the output of "svn diff" on a file that was copied or moved.
901
902         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
903         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
904         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
905         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
906         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
907         of a file with only a property change also does not contain any chunk range lines. Therefore
908         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
909         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
910         we should directly test for the presence of a leading SVN diff header with an empty body and
911         remove such lines from the diff.
912
913         * Scripts/VCSUtils.pm:
914         (fixSVNPatchForAdditionWithHistory): Added.
915         * Scripts/svn-create-patch:
916         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
917         we have a non empty patch for an added file with history (i.e. a copied or moved file).
918         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
919
920 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
921
922         [Mac] Update CARingBuffer class
923         https://bugs.webkit.org/show_bug.cgi?id=167656
924
925         Reviewed by Jer Noble.
926
927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
928         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
929         (TestWebKitAPI::CARingBufferTest::SetUp):
930         (TestWebKitAPI::CARingBufferTest::setup):
931         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
932         (TestWebKitAPI::CARingBufferTest::description):
933         (TestWebKitAPI::CARingBufferTest::bufferList):
934         (TestWebKitAPI::CARingBufferTest::ringBuffer):
935         (TestWebKitAPI::CARingBufferTest::capacity):
936         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
937         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
938         (TestWebKitAPI::TEST_F):
939         (TestWebKitAPI::MixingTest::run):
940
941 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
942
943         [Mac] TestWebKitAPI includes system frameworks incorrectly
944         https://bugs.webkit.org/show_bug.cgi?id=167703
945         rdar://problem/30301498
946
947         Reviewed by Ryosuke Niwa.
948
949         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
950         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
951
952         Also, reduced the number of subframework search paths, looks like we only need one now.
953
954         * TestWebKitAPI/Configurations/Base.xcconfig:
955
956 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
957
958         Correct "filesHaveSameVolume" predicate
959         https://bugs.webkit.org/show_bug.cgi?id=167696
960         <rdar://problem/30298722>
961
962         Reviewed by David Kilzer.
963
964         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
965         percent-escaped path inputs.
966
967         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
968         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
969         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
970         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
971         (TestWebKitAPI::TEST_F):
972
973 2017-02-01  Tomas Popela  <tpopela@redhat.com>
974
975         Unreviewed. Fix coding style in MiniBrowser
976
977         * MiniBrowser/gtk/BrowserWindow.c:
978         (editingCommandCallback):
979         (insertImageCommandCallback):
980         (insertLinkCommandCallback):
981
982 2017-02-01  Tomas Popela  <tpopela@redhat.com>
983
984         [GTK] Add an API to add a custom tab into the print dialog
985         https://bugs.webkit.org/show_bug.cgi?id=151998
986
987         Reviewed by Carlos Garcia Campos.
988
989         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
990         that is testing a newly added API.
991
992         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
993         (testPrintCustomWidget):
994         (beforeAll):
995
996 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
997
998         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
999         https://bugs.webkit.org/show_bug.cgi?id=166529
1000
1001         Reviewed by Xabier Rodriguez-Calvar.
1002
1003         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1004         New patch version accepted in GStreamer upstream.
1005
1006 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1007
1008         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1009         https://bugs.webkit.org/show_bug.cgi?id=167498
1010
1011         Reviewed by Carlos Garcia Campos.
1012
1013         Depending on the distro version you can need either libxfont1-dev
1014         or libfont-dev to build with jhbuild.
1015
1016         * gtk/install-dependencies:
1017
1018 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1019
1020         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1021         https://bugs.webkit.org/show_bug.cgi?id=167594
1022
1023         Unreviewed test gardening.
1024
1025         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1026
1027         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1028         (TEST):
1029
1030 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1031
1032         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1033         https://bugs.webkit.org/show_bug.cgi?id=167676
1034
1035         Reviewed by Saam Barati.
1036
1037         * Scripts/run-javascriptcore-tests:
1038         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1039
1040 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1041
1042         Make Dump Render Tree not crash
1043         https://bugs.webkit.org/show_bug.cgi?id=167667
1044
1045         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1046         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1047         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1048         This does not fix any tests, it just fixes the crash.
1049         
1050         Reviewed by Simon Fraser.
1051
1052         * DumpRenderTree/TestRunner.cpp:
1053         (TestRunner::callUIScriptCallback):
1054
1055 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1056
1057         Workaround for simctl install failing to report install failure
1058         https://bugs.webkit.org/show_bug.cgi?id=167654
1059
1060         Reviewed by Daniel Bates.
1061
1062         simctl install will sometimes report success even though install has failed.
1063         To workaround this bug, we attempt an app launch after install to ensure
1064         install has succeeded.
1065
1066         * Scripts/webkitpy/xcode/simulator.py:
1067         (Device.install_app): Attempt app launch after install, retry install if launch fails.
1068         (Device.launch_app): Correct comment.
1069
1070 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1071
1072         Unreviewed webkitpy fix after r211405.
1073
1074         * Scripts/webkitpy/xcode/simulator.py:
1075         (Device.launch_app): Remove @staticmethod on _log_debug_error.
1076
1077 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1078
1079         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
1080
1081         * gtk/manifest.txt.in:
1082
1083 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
1084
1085         AX: enable search predication for iOS
1086         https://bugs.webkit.org/show_bug.cgi?id=167558
1087         <rdar://problem/30251367>
1088
1089         Reviewed by Joanmarie Diggs.
1090
1091         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1092         (AccessibilityUIElement::uiElementForSearchPredicate):
1093         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1094         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1095         (searchPredicateParameterizedAttributeForSearchCriteria):
1096         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1097         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1098         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1099         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1100         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1101         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1102         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1103         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1104         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1105         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1106         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1107
1108 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1109
1110         Workaround for simctl launch bug
1111         https://bugs.webkit.org/show_bug.cgi?id=167613
1112
1113         Reviewed by Daniel Bates.
1114
1115         simctl launch will sometimes fail because of a race condition when many
1116         simulators are being run simultaneously. These failures will always have
1117         an exit code of 1. This change attempts to launch an app multiple times
1118         before reporting a failure to workaround this bug.
1119
1120         * Scripts/webkitpy/xcode/simulator.py:
1121         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1122
1123 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1124
1125         Commit queue fails to look at real name aliases for the reviewer
1126         https://bugs.webkit.org/show_bug.cgi?id=167422
1127
1128         Reviewed by Joseph Pecoraro.
1129
1130         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1131         (test_has_valid_reviewer): Added tests.
1132
1133         * Scripts/webkitpy/common/config/committers.py:
1134         (CommitterList._name_to_contributor_map):
1135         Made _name_to_contributor_map include alias names.
1136
1137         * Scripts/webkitpy/common/config/committers_unittest.py:
1138         (CommittersTest.test_contributors_by_fuzzy_match):
1139         Removed subtests that are now obsolete, as these matches are strict. It is not
1140         obvious if distance based fuzzy matching for names is useful at all, but we can
1141         look into that some other time.
1142
1143 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1144
1145         QueueStatusServer should have an explicit timeout for _fetch_url
1146         https://bugs.webkit.org/show_bug.cgi?id=167467
1147
1148         Reviewed by Alexey Proskuryakov.
1149
1150         * Scripts/webkitpy/common/net/statusserver.py:
1151         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1152
1153 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1154
1155         Add support for Trac instances that host multiple projects.
1156         https://bugs.webkit.org/show_bug.cgi?id=167524
1157
1158         Reviewed by Alexey Proskuryakov.
1159
1160         When multiple projects are hosted on a single Trac instance, the current
1161         behavior will retrieve changesets from all tracked projects.
1162         This patch teaches Trac.js to get project-specific changesets from Trac.
1163         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1164         when querying the Trac timeline.
1165
1166         To tell Trac to be aware of multi-project instances we leverage the 
1167         `options` parameter when creating a new instance: 
1168
1169             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1170
1171         If this option is not provided, the original behaviour will prevail.
1172         Additionally, add corresponding tests.
1173
1174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1175         (Trac): Reason about new optional parameter 'projectIdentifier'.
1176         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1177         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1178         replace default parameter `changeset=on` with `repo-projectname=on`.
1179         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1181         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1182         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1183         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1184         Add the following tests:
1185             test("revisionURL")
1186             test("revisionURL with Trac Identifier")
1187             test("_xmlTimelineURL")
1188             test("_xmlTimelineURL with Trac Identifier")
1189         (this.view._latestProductiveIteration): Fix missing ';'.
1190
1191 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1192
1193         Correct spacing regression on inter-element complex path shaping on some fonts
1194         https://bugs.webkit.org/show_bug.cgi?id=166013
1195
1196         Reviewed by Simon Fraser.
1197
1198         Unskip existing tests and make some new tests:
1199         - Testing complex text with no origins
1200         - Testing initial expansions
1201         - Testing the sign of vertical advances
1202
1203         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1204         (TestWebKitAPI::TEST_F):
1205
1206 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1207
1208         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1209         https://bugs.webkit.org/show_bug.cgi?id=167596
1210
1211         Reviewed by Daniel Bates.
1212
1213         We avoid needing a thin directory by invoking the zip program with
1214         the list of directories from the build directory to be zipped,
1215         and by using the zip feature to exclude files matching a pattern.
1216
1217         * BuildSlaveSupport/built-product-archive:
1218         (copyBuildFiles):
1219         (createZipFromList):
1220         (archiveBuiltProduct):
1221
1222 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1223
1224         Use simctl instead of LayoutTestRelay
1225         https://bugs.webkit.org/show_bug.cgi?id=165927
1226
1227         Reviewed by Daniel Bates.
1228
1229         Part 1
1230
1231         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1232         simulators through simctl (iOS 10 and later), use this functionality instead.
1233
1234         * Scripts/webkitpy/port/base.py:
1235         (Port.__init__): Added _test_runner_process_constructor.
1236         * Scripts/webkitpy/port/darwin.py:
1237         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1238         * Scripts/webkitpy/port/driver.py:
1239         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1240         (IOSSimulatorDriver): Deleted.
1241         * Scripts/webkitpy/port/driver_unittest.py:
1242         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1243         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1244         (DriverTest.test_start_actually_starts): Ditto.
1245         * Scripts/webkitpy/port/ios.py:
1246         (IOSSimulatorPort): Remove relay_name.
1247         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1248         (IOSSimulatorPort._create_simulators): Formatting change.
1249         (IOSSimulatorPort.relay_path): Deleted.
1250         (IOSSimulatorPort._check_relay): Deleted.
1251         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1252         (IOSSimulatorPort._build_relay): Deleted.
1253         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
1254         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
1255         * Scripts/webkitpy/port/ios_unittest.py:
1256         (iosTest.test_32bit): Update test.
1257         (iosTest.test_64bit): Update test.
1258         * Scripts/webkitpy/port/server_process.py:
1259         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
1260         (ServerProcess._set_file_nonblocking): Added to share common code.
1261         * Scripts/webkitpy/port/server_process_mock.py:
1262         (MockServerProcess.__init__): Added argument worker_number.
1263         * Scripts/webkitpy/port/simulator_process.py: Added.
1264         (SimulatorProcess): Added.
1265         (SimulatorProcess.Popen): Added.
1266         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
1267         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
1268         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
1269         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
1270         (SimulatorProcess._reset): Added. Unlink fifos.
1271         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
1272         (SimulatorProcess._kill): Added. Shutdown app on simulator.
1273         * Scripts/webkitpy/xcode/simulator.py:
1274         (Device.__init__): Accept host to run install/launch/terminate.
1275         (Device.install_app): Install app to target Device.
1276         (Device.launch_app): Launch app on target Device.
1277         (Device.terminate_app): Shutdown app on target Device.
1278         (Simulator._parse_devices): Pass host to Device.
1279
1280 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1281
1282         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
1283         https://bugs.webkit.org/show_bug.cgi?id=167411
1284
1285         Reviewed by Michael Catanzaro.
1286
1287         Disable the ARM iwMMXt fast path for pixman, because it triggers
1288         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
1289
1290         * gtk/jhbuild.modules:
1291
1292 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1293
1294         [GTK] Add API to handle the accelerated compositing policy
1295         https://bugs.webkit.org/show_bug.cgi?id=167509
1296
1297         Reviewed by Michael Catanzaro.
1298
1299         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
1300         as a special case. Also add test cases to the get/set API.
1301
1302         * MiniBrowser/gtk/BrowserSettingsDialog.c:
1303         (hardwareAccelerationPolicyToString):
1304         (stringToHardwareAccelerationPolicy):
1305         (cellRendererChanged):
1306         (browserSettingsDialogConstructed):
1307         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1308         (testWebKitSettings):
1309
1310 2017-01-29  Andy Estes  <aestes@apple.com>
1311
1312         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
1313         https://bugs.webkit.org/show_bug.cgi?id=167563
1314         <rdar://problem/30253207>
1315
1316         Reviewed by Andreas Kling.
1317
1318         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1319         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1320         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1321         (runTest):
1322         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1323         (TEST):
1324
1325 2017-01-29  Dan Bernstein  <mitz@apple.com>
1326
1327         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
1328         https://bugs.webkit.org/show_bug.cgi?id=167565
1329
1330         Reviewed by Sam Weinig.
1331
1332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1333         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
1334         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
1335         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
1336         (TEST):
1337         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
1338         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1339         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1340         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
1341
1342 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
1343
1344         Add Link Preload as an off-by-default experimental feature menu item.
1345         https://bugs.webkit.org/show_bug.cgi?id=167201
1346
1347         Reviewed by Ryosuke Niwa.
1348
1349         * DumpRenderTree/mac/DumpRenderTree.mm:
1350         (resetWebPreferencesToConsistentValues):
1351         * DumpRenderTree/win/DumpRenderTree.cpp:
1352         (resetWebPreferencesToConsistentValues):
1353
1354 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1355
1356         Add User Timing Experimental Feature
1357         https://bugs.webkit.org/show_bug.cgi?id=167542
1358         <rdar://problem/22746307>
1359
1360         Reviewed by Ryosuke Niwa.
1361
1362         * DumpRenderTree/mac/DumpRenderTree.mm:
1363         (enableExperimentalFeatures):
1364         (resetWebPreferencesToConsistentValues):
1365         * DumpRenderTree/win/DumpRenderTree.cpp:
1366         (enableExperimentalFeatures):
1367
1368 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1369
1370         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
1371         https://bugs.webkit.org/show_bug.cgi?id=167519
1372
1373         Reviewed by Ryosuke Niwa.
1374
1375         * QueueStatusServer/templates/statusbubble.html:
1376         To measure the bubbleContainer's width, it must not be wrapping based
1377         on its parent container. So when measuring the width temporarily set
1378         the parent to a very large width so as to not artificially wrap us.
1379         Restore the parent's width after measuring.
1380
1381 2017-01-27  Andy Estes  <aestes@apple.com>
1382
1383         [iOS] Add a test for _WKNSFileManagerExtras
1384         https://bugs.webkit.org/show_bug.cgi?id=167478
1385
1386         Reviewed by Andreas Kling.
1387
1388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1389         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
1390         (expectAttributes):
1391         (TEST):
1392
1393 2017-01-27  Keith Miller  <keith_miller@apple.com>
1394
1395         run-benchmarks should make sure it passes the test url to the right application
1396         https://bugs.webkit.org/show_bug.cgi?id=167533
1397
1398         Reviewed by Joseph Pecoraro.
1399
1400         This fixes an issue when trying to run-benchmark script with the
1401         system default browser set to STP. Previously, it would run
1402         the test in STP rather than the provided build. Now, it should run
1403         in the provided build.
1404
1405         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1406         (OSXSafariDriver.launch_url):
1407
1408 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1409
1410         [Cocoa] Prepare ComplexTextController for unit testing
1411         https://bugs.webkit.org/show_bug.cgi?id=167493
1412
1413         Reviewed by Simon Fraser.
1414
1415         Addressing post-review comments from Simon Fraser.
1416
1417         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1418         (TestWebKitAPI::TEST_F):
1419
1420 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
1421
1422         [Cocoa] Prepare ComplexTextController for unit testing
1423         https://bugs.webkit.org/show_bug.cgi?id=167493
1424
1425         Reviewed by Dean Jackson.
1426
1427         Create four unit tests.
1428
1429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1430         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
1431         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
1432         (TestWebKitAPI::TEST_F):
1433
1434 2017-01-26  Chris Dumez  <cdumez@apple.com>
1435
1436         Crash when navigating back to a page in PacheCache when one of its frames has been removed
1437         https://bugs.webkit.org/show_bug.cgi?id=167421
1438         <rdar://problem/30188490>
1439
1440         Reviewed by Darin Adler.
1441
1442         Add a new setting allowing layout tests to enable PageCache in a window
1443         that has an opener, for convenience.
1444
1445         * DumpRenderTree/mac/DumpRenderTree.mm:
1446         (resetWebPreferencesToConsistentValues):
1447         * DumpRenderTree/win/DumpRenderTree.cpp:
1448         (resetWebPreferencesToConsistentValues):
1449         * WebKitTestRunner/TestController.cpp:
1450         (WTR::TestController::resetPreferencesToConsistentValues):
1451
1452 2017-01-26  Keith Miller  <keith_miller@apple.com>
1453
1454         classInfo should take a VM so it is not materialized from the object on each call
1455         https://bugs.webkit.org/show_bug.cgi?id=167424
1456
1457         Rubber Stamped by Michael Saboff.
1458
1459         Previously, classInfo() would get the VM from the target's
1460         MarkedBlock.  Most callers already have a VM on hand, so it is
1461         wasteful to compute the VM from the marked block every time. This
1462         patch refactors some of the most common callers of classInfo(),
1463         jsDynamicCast and inherits to take a VM as well.
1464
1465         * DumpRenderTree/TestRunner.cpp:
1466         (setAudioResultCallback):
1467
1468 2017-01-26  Jer Noble  <jer.noble@apple.com>
1469
1470         Autoplay muted videos stop playback of any streaming app in the background
1471         https://bugs.webkit.org/show_bug.cgi?id=163993
1472         <rdar://problem/29020431>
1473
1474         Reviewed by Eric Carlson.
1475
1476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1477         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1478         (TestWebKitAPI::TEST):
1479         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
1480
1481 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
1482
1483         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
1484         https://bugs.webkit.org/show_bug.cgi?id=167466
1485
1486         Unreviewed test gardening.
1487
1488         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1489         (TEST):
1490
1491 2017-01-26  Matt Rajca  <mrajca@apple.com>
1492
1493         Notify clients when the user plays media otherwise prevented from autoplaying
1494         https://bugs.webkit.org/show_bug.cgi?id=167390
1495
1496         Reviewed by Alex Christensen.
1497
1498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1499         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1500         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1501         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1502         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1503         (TEST):
1504         * TestWebKitAPI/cocoa/TestWKWebView.h:
1505         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1506         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1507         (-[TestWKWebView waitForLoad]):
1508         (-[TestWKWebView mouseUpAtPoint:]):
1509         * WebKitTestRunner/TestController.cpp:
1510         (WTR::TestController::createOtherPage):
1511         (WTR::TestController::createWebViewWithOptions):
1512
1513 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
1514
1515         Crash when setting custom scale factor.
1516         https://bugs.webkit.org/show_bug.cgi?id=167369
1517
1518         Reviewed by Sam Weinig.
1519
1520         Added API test.
1521
1522         * TestWebKitAPI/PlatformWin.cmake:
1523         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1524         (TestWebKitAPI::WebKitCreateInstance):
1525         (TestWebKitAPI::ScaleWebView::SetUp):
1526         (TestWebKitAPI::ScaleWebView::TearDown):
1527         (TestWebKitAPI::TEST_F):
1528
1529 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1530
1531         run-benchmark nests MotionMark results by the suite name twice
1532         https://bugs.webkit.org/show_bug.cgi?id=164948
1533
1534         Reviewed by Said Abou-Hallawa.
1535
1536         Use a single level MotionMark now that this is the name of the benchmark,
1537         and we no longer have tests that aren't part of the MotionMark suite.
1538
1539         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1540
1541 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1542
1543         Unreviewed, rolling out r211193.
1544
1545         This change broke internal builds.
1546
1547         Reverted changeset:
1548
1549         "Notify clients when the user plays media otherwise prevented
1550         from autoplaying"
1551         https://bugs.webkit.org/show_bug.cgi?id=167390
1552         http://trac.webkit.org/changeset/211193
1553
1554 2017-01-25  Matt Rajca  <mrajca@apple.com>
1555
1556         Notify clients when the user plays media otherwise prevented from autoplaying
1557         https://bugs.webkit.org/show_bug.cgi?id=167390
1558
1559         Reviewed by Alex Christensen.
1560
1561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1562         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1563         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1564         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1565         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1566         (TEST):
1567         * TestWebKitAPI/cocoa/TestWKWebView.h:
1568         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1569         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1570         (-[TestWKWebView waitForLoad]):
1571         (-[TestWKWebView mouseUpAtPoint:]):
1572         * WebKitTestRunner/TestController.cpp:
1573         (WTR::TestController::createOtherPage):
1574         (WTR::TestController::createWebViewWithOptions):
1575
1576 2017-01-25  Matt Rajca  <mrajca@apple.com>
1577
1578         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1579         https://bugs.webkit.org/show_bug.cgi?id=167385
1580
1581         Reviewed by Alex Christensen.
1582
1583         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1584         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1585         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1586         (TEST): Allow inline (rather than full screen) media playback on iOS.
1587
1588 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1589
1590         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1591         https://bugs.webkit.org/show_bug.cgi?id=167414
1592
1593         Reviewed by Michael Catanzaro.
1594
1595         Add a test case to check ephemeral web views don't write favicons to the database.
1596
1597         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1598         (ephemeralViewLoadChanged):
1599         (testPrivateBrowsing):
1600         (testFaviconDatabase):
1601
1602 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1603
1604         [GTK] Add a private browsing mode to MiniBrowser
1605         https://bugs.webkit.org/show_bug.cgi?id=167413
1606
1607         Reviewed by Michael Catanzaro.
1608
1609         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1610         private windows, even on non-private instances.
1611
1612         * MiniBrowser/gtk/BrowserWindow.c:
1613         (webViewTitleChanged): Add [Private] to title window for private windows.
1614         (webViewCreate): Pass web context to browser_window_new.
1615         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1616         (browserWindowFinalize): Disconnect web context signal handlers.
1617         (browser_window_init): Add shortcut for opening private window.
1618         (browser_window_new): It now receives the context and connect to download-started here.
1619         (browser_window_get_web_context): Return the context.
1620         * MiniBrowser/gtk/BrowserWindow.h:
1621         * MiniBrowser/gtk/main.c:
1622         (createBrowserTab): Create the web view for the window web context.
1623         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1624         (aboutDataHandleRequest): Ditto.
1625         (aboutURISchemeRequestCallback): Ditto.
1626         (main): Create ephemeral web context if private command line option is used.
1627
1628 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1629
1630         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1631         https://bugs.webkit.org/show_bug.cgi?id=167409
1632
1633         Reviewed by Antti Koivisto.
1634
1635         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1636         as well as tests for the newly added matchingElementInFlatTree.
1637
1638         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1639         (TestWebKitAPI::runJavaScriptAlert):
1640         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1641         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1642         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1643
1644 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1645
1646         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1647         https://bugs.webkit.org/show_bug.cgi?id=167370
1648
1649         Reviewed by Michael Catanzaro.
1650
1651         Add several test cases of ephemeral web views.
1652
1653         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1654         (testWebViewAuthenticationStorage):
1655         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1656         (ephemeralViewloadChanged):
1657         (testCookieManagerEphemeral):
1658         (beforeAll):
1659         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1660         (testWebKitSettings):
1661         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1662         (testWebContextEphemeral):
1663         (ephemeralViewloadChanged):
1664         (testWebContextProxySettings):
1665         (beforeAll):
1666         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1667         (ephemeralViewloadChanged):
1668         (testWebViewEphemeral):
1669         (beforeAll):
1670         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1671         (ephemeralViewloadChanged):
1672         (testWebsiteDataEphemeral):
1673         (beforeAll):
1674
1675 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1676
1677         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1678         https://bugs.webkit.org/show_bug.cgi?id=167402
1679
1680         Reviewed by Ryosuke Niwa.
1681
1682         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1683         (TestWebKitAPI::TEST):
1684
1685 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1686
1687         Add simple line layout toggle to MiniBrowser
1688         https://bugs.webkit.org/show_bug.cgi?id=167405
1689
1690         Reviewed by Andreas Kling.
1691
1692         * MiniBrowser/mac/SettingsController.h:
1693         * MiniBrowser/mac/SettingsController.m:
1694         (-[SettingsController _populateMenu]):
1695         (-[SettingsController validateMenuItem:]):
1696         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1697         (-[SettingsController simpleLineLayoutEnabled]):
1698         * MiniBrowser/mac/WK1BrowserWindowController.m:
1699         (-[WK1BrowserWindowController didChangeSettings]):
1700         * MiniBrowser/mac/WK2BrowserWindowController.m:
1701         (-[WK2BrowserWindowController didChangeSettings]):
1702
1703 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1704
1705         WKR does not include my nick when commit-queue lands my patch
1706         https://bugs.webkit.org/show_bug.cgi?id=167388
1707
1708         Reviewed by Ryosuke Niwa.
1709
1710         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1711         (NewCommitBot._summarize_commit_log):
1712         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1713         Perform nickname insertion before grabbing "Patch by" details.
1714         This way we can include the nickname with the full name.
1715
1716 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1717
1718         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1719         https://bugs.webkit.org/show_bug.cgi?id=167394
1720
1721         Reviewed by Ryosuke Niwa.
1722
1723         * Scripts/webkitperl/FeatureList.pm:
1724         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1725
1726 2017-01-24  Youenn Fablet  <youenn@apple.com>
1727
1728         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1729         https://bugs.webkit.org/show_bug.cgi?id=167353
1730
1731         Reviewed by Alex Christensen.
1732
1733         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1734         (CMakeGenerator.initialize_targets):
1735
1736 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1737
1738         WKR should not confuse Miguel Gomez with Andres Gomez
1739         https://bugs.webkit.org/show_bug.cgi?id=167389
1740
1741         Reviewed by Lucas Forschler.
1742
1743         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1744         "mAndres Gomez". Fix this.
1745
1746         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1747         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1748         space on each side of the email address, so expect both spaces to be there before
1749         considering the email for replacement.
1750         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1751
1752 2017-01-24  Matt Rajca  <mrajca@apple.com>
1753
1754         Pass down website autoplay policies to media elements
1755         https://bugs.webkit.org/show_bug.cgi?id=167355
1756
1757         Reviewed by Alex Christensen.
1758
1759         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1760         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1761         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1762         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1763         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1764         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1765         (TEST):
1766
1767 2017-01-24  Nan Wang  <n_wang@apple.com>
1768
1769         AX: Speak Selection does not work in an iframe
1770         https://bugs.webkit.org/show_bug.cgi?id=166794
1771         <rdar://problem/29913013>
1772
1773         Reviewed by Chris Fleizach.
1774
1775         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1776         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1777         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1778         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1779         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1780         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1781         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1782         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1783         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1784         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1785         (-[TestRunnerWKWebView dealloc]):
1786         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1787         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1788         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1789         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1790         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1791
1792 2017-01-24  Daniel Bates  <dabates@apple.com>
1793
1794         StringView.split() should use an iterator design pattern instead of allocating a Vector
1795         https://bugs.webkit.org/show_bug.cgi?id=163225
1796
1797         Reviewed by Darin Adler.
1798
1799         Add unit tests for StringView.split().
1800
1801         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1802         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1803         used in the StringView.split() unit tests.
1804         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1805         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1806         object to a Vector of String objects.
1807         (TestWebKitAPI::TEST): Added the following tests:
1808             - WTF.StringViewSplitEmptyAndNullStrings
1809             - WTF.StringViewSplitBasic
1810             - WTF.StringViewSplitWithConsecutiveSeparators
1811
1812 2017-01-23  Anders Carlsson  <andersca@apple.com>
1813
1814         The Score Esports crashes on launch
1815         https://bugs.webkit.org/show_bug.cgi?id=167338
1816         rdar://problem/29948645
1817
1818         Reviewed by Dan Bernstein.
1819
1820         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1821         (TestWebKitAPI::TEST):
1822         Add a test.
1823
1824 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1825
1826         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1827         https://bugs.webkit.org/show_bug.cgi?id=146589
1828
1829         Reviewed by Michael Catanzaro.
1830
1831         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1832         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1833
1834         * MiniBrowser/gtk/BrowserWindow.c:
1835         (webViewDecidePolicy):
1836         (newTabCallback):
1837         * MiniBrowser/gtk/main.c:
1838         (createBrowserTab):
1839         (aboutDataRequestFree):
1840         (aboutDataRequestNew):
1841         (aboutDataRequestForView):
1842         (websiteDataRemovedCallback):
1843         (websiteDataClearedCallback):
1844         (aboutDataScriptMessageReceivedCallback):
1845         (domainListFree):
1846         (aboutDataFillTable):
1847         (gotWebsiteDataCallback):
1848         (aboutDataHandleRequest):
1849         (aboutURISchemeRequestCallback):
1850         (main):
1851         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1852         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1853         (serverCallback):
1854         (beforeAll):
1855         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1856         (serverCallback):
1857         (WebsiteDataTest::WebsiteDataTest):
1858         (WebsiteDataTest::~WebsiteDataTest):
1859         (WebsiteDataTest::fetch):
1860         (WebsiteDataTest::remove):
1861         (WebsiteDataTest::clear):
1862         (testWebsiteDataConfiguration):
1863         (testWebsiteDataCache):
1864         (testWebsiteDataStorage):
1865         (testWebsiteDataDatabases):
1866         (testWebsiteDataAppcache):
1867         (beforeAll):
1868         (afterAll):
1869
1870 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1871
1872         Unreviewed, rolling out r211062.
1873         https://bugs.webkit.org/show_bug.cgi?id=167354
1874
1875         broke API tests (Requested by alexchristensen on #webkit).
1876
1877         Reverted changeset:
1878
1879         "Pass down website autoplay policies to media elements"
1880         https://bugs.webkit.org/show_bug.cgi?id=167132
1881         http://trac.webkit.org/changeset/211062
1882
1883 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1884
1885         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1886         https://bugs.webkit.org/show_bug.cgi?id=167330
1887
1888         Reviewed by Tim Horton.
1889
1890         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1891         (TestWebKitAPI::TEST_F):
1892
1893 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1894
1895         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1896         https://bugs.webkit.org/show_bug.cgi?id=167317
1897
1898         Reviewed by Sam Weinig.
1899
1900         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1901         (TestWebKitAPI::TEST_F):
1902
1903 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1904
1905         svn-create-patch should emit properties when files are moved or copied
1906         https://bugs.webkit.org/show_bug.cgi?id=167264
1907
1908         Reviewed by Daniel Bates.
1909
1910         * Scripts/svn-create-patch:
1911         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1912
1913 2017-01-23  Youenn Fablet  <youenn@apple.com>
1914
1915         [WebRTC] Filter libwebrtc link flags
1916         https://bugs.webkit.org/show_bug.cgi?id=167287
1917
1918         Reviewed by Alex Christensen.
1919
1920         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1921         (CMakeGenerator._compute_link_flags):
1922         (CMakeGenerator._compute_link_flags.keep_flag):
1923         (CMakeGenerator._generate_compile_target_options):
1924
1925 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1926
1927         [WebRTC] Make VP8 optional in libwebrtc
1928         https://bugs.webkit.org/show_bug.cgi?id=167257
1929
1930         Reviewed by Darin Adler.
1931
1932         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1933         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1934
1935 2017-01-23  Jer Noble  <jer.noble@apple.com>
1936
1937         Video details does not apear and missing scrubber in Control Center
1938         https://bugs.webkit.org/show_bug.cgi?id=167233
1939
1940         Reviewed by Alex Christensen.
1941
1942         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1943         NowPlayingControlTests for iOS.
1944
1945         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1946         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1947         (-[NowPlayingTestWebView setWindowVisible:]):
1948         (TestWebKitAPI::TEST):
1949         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1950         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1951         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1952         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1953         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1954         (SOFT_LINK_CLASS):
1955         (-[TestMessageHandler addMessage:withHandler:]):
1956         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1957         (__simulated_forceClickAssociatedEventsMask):
1958         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1959         (-[TestWKWebViewHostWindow isKeyWindow]):
1960         (-[TestWKWebViewHostWindow makeKeyWindow]):
1961         (-[TestWKWebViewHostWindow resignKeyWindow]):
1962         (-[TestWKWebView initWithFrame:]):
1963         (-[TestWKWebView initWithFrame:configuration:]):
1964         (-[TestWKWebView _setUpTestWindow:]):
1965         (-[TestWKWebView performAfterReceivingMessage:action:]):
1966         (-[TestWKWebView loadTestPageNamed:]):
1967         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1968         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1969         (-[TestWKWebView waitForMessage:]):
1970         (-[TestWKWebView performAfterLoading:]):
1971         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1972         (-[TestWKWebView typeCharacter:]):
1973
1974 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1975
1976         Unreviewed. Bring back gtk-doc error messages after r209981.
1977
1978         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1979         impossible to know what's wrong.
1980
1981         * gtk/gtkdoc.py:
1982         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1983
1984 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1985
1986         [WebRTC] Update build system to make G711 optional in libwebrtc
1987         https://bugs.webkit.org/show_bug.cgi?id=167256
1988
1989         Reviewed by Alex Christensen.
1990
1991         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1992         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1993
1994 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1995
1996         Cleanup RuntimeEnabledFeatures
1997         https://bugs.webkit.org/show_bug.cgi?id=167228
1998
1999         Reviewed by Simon Fraser.
2000
2001         * DumpRenderTree/mac/DumpRenderTree.mm:
2002         (enableExperimentalFeatures):
2003         (resetWebPreferencesToConsistentValues):
2004         (setWebPreferencesForTestOptions):
2005         (resetWebViewToConsistentStateBeforeTesting):
2006         * DumpRenderTree/win/DumpRenderTree.cpp:
2007         (enableExperimentalFeatures):
2008         (resetWebPreferencesToConsistentValues):
2009         More closely match WebKitTestRunner initialization of preferences
2010         for experimental features.
2011
2012 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2013
2014         Build Fix for Windows DumpRenderTree after r210976
2015         https://bugs.webkit.org/show_bug.cgi?id=167115
2016
2017         * DumpRenderTree/win/DumpRenderTree.cpp:
2018         (resetWebPreferencesToConsistentValues):
2019
2020 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2021
2022         Remove outdated ENABLE(CSP_NEXT) build flag
2023         https://bugs.webkit.org/show_bug.cgi?id=167252
2024
2025         Reviewed by Brent Fulgham.
2026
2027         * Scripts/webkitperl/FeatureList.pm:
2028         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2029
2030 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2031
2032         Build Fix for Windows DumpRenderTree after r210976
2033
2034         * DumpRenderTree/win/DumpRenderTree.cpp:
2035         (resetWebPreferencesToConsistentValues):
2036
2037 2017-01-20  Antoine Quint  <graouts@apple.com>
2038
2039         Web Animations should be off by default and enabled as an experimental feature
2040         https://bugs.webkit.org/show_bug.cgi?id=167115
2041         <rdar://problem/30048963>
2042
2043         Reviewed by Joseph Pecoraro.
2044
2045         Turn Web Animations on in DRT.
2046
2047         * DumpRenderTree/mac/DumpRenderTree.mm:
2048         (resetWebPreferencesToConsistentValues):
2049         * DumpRenderTree/win/DumpRenderTree.cpp:
2050         (resetWebPreferencesToConsistentValues):
2051
2052 2017-01-20  Youenn Fablet  <youenn@apple.com>
2053
2054         [WebRTC] Add libwebrtc build infrastructure
2055         https://bugs.webkit.org/show_bug.cgi?id=167207
2056
2057         Reviewed by Alex Christensen.
2058
2059         Adding a script doing the libwebrtc project json to CMake file conversion.
2060
2061         * Scripts/generate-libwebrtc-cmake: Added.
2062         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
2063         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
2064
2065 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2066
2067         Mini Browser: Show tooltip for Experimental Features
2068         https://bugs.webkit.org/show_bug.cgi?id=167225
2069
2070         Reviewed by Alex Christensen.
2071
2072         * MiniBrowser/mac/SettingsController.m:
2073         (-[SettingsController _populateMenu]):
2074         Include the full details string as a tooltip.
2075
2076 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
2077
2078         [Win] Test output results should not be written twice.
2079         https://bugs.webkit.org/show_bug.cgi?id=167197
2080
2081         Reviewed by Brent Fulgham.
2082
2083         Prevent test output from being written twice by returning early from
2084         the dump() function, if it already has been called.
2085         This patch also adds a missing newline to a test output line. 
2086         
2087         * DumpRenderTree/win/DumpRenderTree.cpp:
2088         (dump):
2089
2090 2017-01-20  Antoine Quint  <graouts@apple.com>
2091
2092         [Modern Media Controls] Turn modern media controls on by default
2093         https://bugs.webkit.org/show_bug.cgi?id=165668
2094
2095         Reviewed by Dean Jackson.
2096
2097         Enabled modern media controls by default in test runners.
2098
2099         * DumpRenderTree/TestOptions.h:
2100         * WebKitTestRunner/TestOptions.h:
2101
2102 2017-01-19  Chris Dumez  <cdumez@apple.com>
2103
2104         iterable<> should be enabled on WK1
2105         https://bugs.webkit.org/show_bug.cgi?id=167221
2106         <rdar://problem/30108531>
2107
2108         Reviewed by Youenn Fablet.
2109
2110         * DumpRenderTree/mac/DumpRenderTree.mm:
2111         (resetWebPreferencesToConsistentValues):
2112         * DumpRenderTree/win/DumpRenderTree.cpp:
2113         (resetWebPreferencesToConsistentValues):
2114         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2115         (WTR::InjectedBundle::beginTesting):
2116         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2117         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2118         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2119
2120 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2121
2122         Ensure status server logs go to log file
2123         https://bugs.webkit.org/show_bug.cgi?id=167210
2124
2125         Reviewed by Alexey Proskuryakov.
2126
2127         * Scripts/webkitpy/common/net/statusserver.py:
2128         (StatusServer.next_work_item): Change log level from debug to info in
2129         order to facilitate deubgging issues.
2130         (StatusServer.update_work_items): Same.
2131
2132 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2133
2134         Additional selection tests and interpolation fix
2135         https://bugs.webkit.org/show_bug.cgi?id=167171
2136
2137         Reviewed by Simon Fraser.
2138
2139         We weren't adding the final event when interpolating event streams.
2140
2141         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2142         (-[HIDEventGenerator interpolatedEvents:]):
2143
2144 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2145
2146         [Cocoa] Variation fonts are erroneously disabled on iOS
2147         https://bugs.webkit.org/show_bug.cgi?id=167172
2148
2149         Reviewed by Simon Fraser.
2150
2151         OpenSource builders don't seem to understand sdk=embedded*.
2152
2153         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2154
2155 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2156
2157         Unreviewed. Fix GTK+ unit tests failing since r210531.
2158
2159         Avoid using paths to files that don't actually exist.
2160
2161         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2162         (testWebKitConsoleMessageNetworkError):
2163         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2164         (testContextMenuDefaultMenu):
2165         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2166         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2167         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2168
2169 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2170
2171         [GTK] Provide API to set proxy settings
2172         https://bugs.webkit.org/show_bug.cgi?id=128674
2173
2174         Reviewed by Michael Catanzaro.
2175
2176         Add tests for new proxy settings API.
2177
2178         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2179         (serverCallback):
2180         (ProxyTest::ProxyTest):
2181         (ProxyTest::~ProxyTest):
2182         (ProxyTest::loadURIAndGetMainResourceData):
2183         (ProxyTest::proxyServerPortAsString):
2184         (testWebContextProxySettings):
2185         (beforeAll):
2186
2187 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2188
2189         Add back my old email address so old commits will still match it.
2190
2191         * Scripts/webkitpy/common/config/contributors.json:
2192
2193 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2194
2195         Remove my old email address from contributors.json and watchlist.
2196
2197         * Scripts/validate-committer-lists:
2198         (CommitterListFromGit): Change the mapping to the correct email.
2199         * Scripts/webkitpy/common/config/contributors.json:
2200         * Scripts/webkitpy/common/config/watchlist:
2201
2202 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2203
2204         Unreviewed, rolling out r210848.
2205
2206         This change introduced media-related LayoutTest failures and
2207         crashes on macOS.
2208
2209         Reverted changeset:
2210
2211         "[Modern Media Controls] Turn modern media controls on by
2212         default"
2213         https://bugs.webkit.org/show_bug.cgi?id=165668
2214         http://trac.webkit.org/changeset/210848
2215
2216 2017-01-18  Andreas Kling  <akling@apple.com>
2217
2218         Document::securityOrigin() should return a reference.
2219         <https://webkit.org/b/167124>
2220
2221         Reviewed by Sam Weinig.
2222
2223         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2224         (TestWebKitAPI::TEST_F):
2225
2226 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2227
2228         [Win] Clipboard tests are flaky.
2229         https://bugs.webkit.org/show_bug.cgi?id=167088
2230
2231         Reviewed by Brent Fulgham.
2232
2233         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2234         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2235
2236         * DumpRenderTree/win/DumpRenderTree.cpp:
2237         (main):
2238
2239 2017-01-18  Antoine Quint  <graouts@apple.com>
2240
2241         [Modern Media Controls] Turn modern media controls on by default
2242         https://bugs.webkit.org/show_bug.cgi?id=165668
2243
2244         Reviewed by Dean Jackson.
2245
2246         Enabled modern media controls by default in test runners. 
2247
2248         * DumpRenderTree/TestOptions.h:
2249         * WebKitTestRunner/TestOptions.h:
2250
2251 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2252
2253         Unreviewed, rolling out r210834
2254         https://bugs.webkit.org/show_bug.cgi?id=165668
2255
2256         It introduced dozens of test timeouts.
2257
2258         Reverted changeset:
2259         "[Modern Media Controls] Turn modern media controls on by default"
2260         https://bugs.webkit.org/show_bug.cgi?id=165668
2261         http://trac.webkit.org/changeset/210834
2262
2263 2017-01-17  Antoine Quint  <graouts@apple.com>
2264
2265         [Modern Media Controls] Turn modern media controls on by default
2266         https://bugs.webkit.org/show_bug.cgi?id=165668
2267
2268         Reviewed by Dean Jackson.
2269
2270         Enabled modern media controls by default in test runners. 
2271
2272         * DumpRenderTree/TestOptions.h:
2273         * WebKitTestRunner/TestOptions.h:
2274
2275 2017-01-17  Chris Dumez  <cdumez@apple.com>
2276
2277         Document title changed twice when setting document.title
2278         https://bugs.webkit.org/show_bug.cgi?id=167065
2279
2280         Reviewed by Darin Adler.
2281
2282         Add WebKit2GTK API test that was written by Michael Catanzaro.
2283
2284         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2285         (testWebViewTitleChange):
2286         (beforeAll):
2287
2288 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
2289
2290         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
2291         https://bugs.webkit.org/show_bug.cgi?id=116551
2292         <rdar://problem/13949830>
2293
2294         Reviewed by Alex Christensen.
2295
2296         * Scripts/webkitperl/FeatureList.pm:
2297         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
2298         that is part of the existing WEB_TIMING feature.
2299
2300         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2301
2302 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
2303
2304         'webkit-patch post' no longer works with moved/copied files
2305         https://bugs.webkit.org/show_bug.cgi?id=166914
2306         <rdar://problem/29979707>
2307
2308         Reviewed by Daniel Bates.
2309
2310         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
2311         file outputs only the "Index:" line with an empty body.  This workaround
2312         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
2313         public email list tracking this bug is below.
2314         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
2315         
2316
2317         * Scripts/svn-create-patch:
2318         (generateDiff): Ignore an "Index:" line with an empty body.
2319
2320 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
2321
2322         Remove the REQUEST_ANIMATION_FRAME flag
2323         https://bugs.webkit.org/show_bug.cgi?id=156980
2324         <rdar://problem/25906849>
2325
2326         Reviewed by Simon Fraser.
2327
2328         * Scripts/webkitperl/FeatureList.pm:
2329         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2330
2331 2017-01-15  Sam Weinig  <sam@webkit.org>
2332
2333         Add the ability to use numbers in makeString()
2334         https://bugs.webkit.org/show_bug.cgi?id=167087
2335
2336         Reviewed by Darin Adler.
2337
2338         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2339         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
2340         Add tests for StringConcatenate, focusing on new numeric additions.
2341
2342 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2343
2344         Unreviewed, remove stale comment.
2345
2346         This test was fixed by r163173.
2347
2348         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2349
2350 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2351
2352         Annotate large string tests with largeHeap
2353         https://bugs.webkit.org/show_bug.cgi?id=167054
2354
2355         Reviewed by Filip Pizlo.
2356
2357         * Scripts/run-javascriptcore-tests:
2358         * Scripts/run-jsc-stress-tests:
2359
2360 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
2361
2362         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
2363         https://bugs.webkit.org/show_bug.cgi?id=167043
2364
2365         Reviewed by Darin Adler.
2366
2367         * Scripts/webkitperl/FeatureList.pm:
2368
2369 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
2370
2371         Remove ENABLE(DETAILS_ELEMENT) guards
2372         https://bugs.webkit.org/show_bug.cgi?id=167042
2373
2374         Reviewed by Alex Christensen.
2375
2376         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2377
2378 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
2379
2380         26 MotionMark performance tests failing
2381         https://bugs.webkit.org/show_bug.cgi?id=166854
2382
2383         Reviewed by Ryosuke Niwa.
2384
2385         Unrelated change. This is the last place that we need to rename Animometer
2386         to MotionMark.
2387
2388         * Scripts/webkitpy/common/config/watchlist:
2389
2390 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
2391
2392         run-jsc-benchmarks' echo should have -e option
2393         https://bugs.webkit.org/show_bug.cgi?id=167009
2394
2395         Reviewed by Sam Weinig.
2396
2397         echo requires `-e` option to use escape sequence.
2398         Without it, in some environment (in my Fedora 25), the escape sequence is not
2399         recognized and just dumped as `\c` etc.
2400
2401         * Scripts/run-jsc-benchmarks:
2402
2403 2017-01-12  Chris Dumez  <cdumez@apple.com>
2404
2405         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2406         https://bugs.webkit.org/show_bug.cgi?id=166995
2407
2408         Reviewed by Jer Noble.
2409
2410         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
2411         as some people are having trouble building without it.
2412
2413         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2414
2415 2017-01-12  Sam Weinig  <sam@webkit.org>
2416
2417         Add the ability to filter the set of bindings tests you want to run
2418         https://bugs.webkit.org/show_bug.cgi?id=166977
2419
2420         Reviewed by Tim Horton.
2421
2422         Allows doing things like:
2423             run-bindings-tests TestObj* TestCEReactions*
2424         
2425         to run only those tests that match the patterns.
2426
2427         * Scripts/run-bindings-tests:
2428         (main):
2429         Switch to using optparse and pass the remaining args as the filters.
2430
2431         * Scripts/webkitpy/bindings/main.py:
2432         (BindingsTests.__init__):
2433         Store the pattens.
2434
2435         (BindingsTests.test_matches_patterns):
2436         Add helper predicate to determine if a test should be run. When no
2437         patterns are present, all tests should run.
2438
2439         (BindingsTests.run_tests):
2440         Filter tests using the passed in patterns.
2441
2442 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
2443
2444         Followup fix after r210503.
2445         https://bugs.webkit.org/show_bug.cgi?id=166887
2446
2447         Reviewed by Alex Christensen.
2448
2449         After <http://trac.webkit.org/changeset/210503>, test results are written to a
2450         duplicated file handle on Windows. This patch fixes the remaining call sites.
2451
2452         * DumpRenderTree/PixelDumpSupport.cpp:
2453         * DumpRenderTree/TestRunner.cpp:
2454         (TestRunner::waitToDumpWatchdogTimerFired):
2455         * DumpRenderTree/TestRunner.h:
2456         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2457         * DumpRenderTree/win/DumpRenderTree.cpp:
2458         * DumpRenderTree/win/DumpRenderTreeWin.h:
2459         * DumpRenderTree/win/TestRunnerWin.cpp:
2460         (TestRunner::setSpellCheckerLoggingEnabled):
2461
2462 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
2463
2464         Add committer status for Megan
2465         https://bugs.webkit.org/show_bug.cgi?id=166954
2466
2467         Reviewed by Tim Horton.
2468
2469         Add committer status for Megan Gardner
2470
2471         * Scripts/webkitpy/common/config/contributors.json:
2472
2473 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2474
2475         Unreviewed test fix after r210599.
2476
2477         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2478         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
2479
2480 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2481
2482         Unreviewed build fix after r210599.
2483
2484         Add missing files.
2485
2486         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2487         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2488
2489 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
2490
2491         File scheme should not allow access of a resource on a different volume.
2492         https://bugs.webkit.org/show_bug.cgi?id=158552
2493         <rdar://problem/15307582>
2494
2495         Reviewed by Alex Christensen.
2496
2497         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2498         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2499         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2500
2501 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2502
2503         Unreviewed, rolling out r210571.
2504
2505         This change broke the 32-bit macOS build and caused LayoutTest
2506         failures.
2507
2508         Reverted changeset:
2509
2510         "File scheme should not allow access of a resource on a
2511         different volume."
2512         https://bugs.webkit.org/show_bug.cgi?id=158552
2513         http://trac.webkit.org/changeset/210571
2514
2515 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2516
2517         [GTK] install-dependencies script misses gdb
2518         https://bugs.webkit.org/show_bug.cgi?id=166917
2519
2520         Reviewed by Michael Catanzaro.
2521
2522         gdb is needed for generating the crash logs.
2523
2524         * gtk/install-dependencies:
2525
2526 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2527
2528         [GTK] No way for applications to set notification permissions without waiting for permission request
2529         https://bugs.webkit.org/show_bug.cgi?id=163366
2530
2531         Reviewed by Carlos Garcia Campos.
2532
2533         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2534         (testWebViewNotification):
2535         (setInitialNotificationPermissionsAllowedCallback):
2536         (setInitialNotificationPermissionsDisallowedCallback):
2537         (testWebViewNotificationInitialPermissionAllowed):
2538         (testWebViewNotificationInitialPermissionDisallowed):
2539         (beforeAll):
2540         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2541         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2542         (WebViewTest::WebViewTest):
2543         (WebViewTest::initializeWebView):
2544         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2545
2546 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2547
2548         MobileMiniBrowser tests don't work by default
2549         https://bugs.webkit.org/show_bug.cgi?id=166910
2550
2551         Reviewed by Alex Christensen.
2552
2553         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2554         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2555
2556 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2557
2558         File scheme should not allow access of a resource on a different volume.
2559         https://bugs.webkit.org/show_bug.cgi?id=158552
2560         <rdar://problem/15307582>
2561
2562         Reviewed by Alex Christensen.
2563
2564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2565         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2566         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2567
2568 2017-01-10  Mark Lam  <mark.lam@apple.com>
2569
2570         Reverting run-jsc-stress-tests' $buildType to use string values.
2571         https://bugs.webkit.org/show_bug.cgi?id=166912
2572
2573         Rubber stamped by Filip Pizlo.
2574
2575         This is so that we can test for it in the tests e.g.
2576         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2577
2578         * Scripts/run-jsc-stress-tests:
2579
2580 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2581
2582         Temporarily add back the file removed in r210463 to unbreak internal bots.
2583
2584         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2585
2586 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2587
2588         svn-apply failed to apply a patch (deleting file with svn property)
2589         https://bugs.webkit.org/show_bug.cgi?id=165953
2590
2591         Reviewed by Daniel Bates.
2592
2593         * Scripts/VCSUtils.pm:
2594         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2595         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2596
2597 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2598
2599         Update flakiness dashboard configuration.
2600         https://bugs.webkit.org/show_bug.cgi?id=166869
2601
2602         Reviewed by Alexey Proskuryakov.
2603
2604         * TestResultServer/static-dashboards/builders.jsonp:
2605         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2606
2607 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2608
2609         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2610         https://bugs.webkit.org/show_bug.cgi?id=165232
2611
2612         Unreviewed follow-up patch after r210539 and r210523.
2613
2614         Instead of using that environment variable, the argument
2615         --display-server=xorg should be passed now.
2616
2617         The GTK+ performance bot was the only bot using this, and is
2618         already passing --display-server=xorg after r210539.
2619
2620         * Scripts/webkitpy/port/gtk.py:
2621         (GtkPort._driver_class):
2622
2623 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2624
2625         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2626         https://bugs.webkit.org/show_bug.cgi?id=166872
2627
2628         Reviewed by Michael Catanzaro.
2629
2630         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2631         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2632         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2633         The step RunWebKitTests already has support for it.
2634
2635         * BuildSlaveSupport/build.webkit.org-config/config.json:
2636         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2637         (RunGtkAPITests.start):
2638         (RunAndUploadPerfTests.start):
2639         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2640
2641 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2642
2643         Unreviewed, rolling out r210531.
2644
2645         This change broke the 32-bit macOS build and caused LayoutTest
2646         failures.
2647
2648         Reverted changeset:
2649
2650         "File scheme should not allow access of a resource on a
2651         different volume."
2652         https://bugs.webkit.org/show_bug.cgi?id=158552
2653         http://trac.webkit.org/changeset/210531
2654
2655 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2656
2657         File scheme should not allow access of a resource on a different volume.
2658         https://bugs.webkit.org/show_bug.cgi?id=158552
2659         <rdar://problem/15307582>
2660
2661         Reviewed by Alex Christensen.
2662
2663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2664         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2665         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2666
2667 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2668
2669         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2670         https://bugs.webkit.org/show_bug.cgi?id=165232
2671
2672         Reviewed by Michael Catanzaro.
2673
2674         Add a new WaylandDriver to run the tests in the user current wayland session.
2675
2676         Also merge all the configuration options for selecting the display server inside one
2677         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2678
2679         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2680
2681         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2682         (TestRunner._create_driver):
2683         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2684         (parse_args):
2685         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2686         (PerfTestsRunner._parse_args):
2687         * Scripts/webkitpy/port/gtk.py:
2688         (GtkPort.__init__):
2689         (GtkPort._driver_class):
2690         (GtkPort._search_paths):
2691         * Scripts/webkitpy/port/waylanddriver.py: Added.
2692         (WaylandDriver):
2693         (WaylandDriver.check_driver):
2694         (WaylandDriver._setup_environ_for_test):
2695         (WaylandDriver._start):
2696
2697 2017-01-09  Andy Estes  <aestes@apple.com>
2698
2699         [QuickLook] Add a layout test for webkit.org/b/135651
2700         https://bugs.webkit.org/show_bug.cgi?id=166855
2701
2702         Reviewed by Andreas Kling.
2703
2704         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2705         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2706         errors with code WebKitErrorCannotShowURL.
2707         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2708         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2709         not specific to WebKit2 error codes.
2710
2711 2017-01-09  Antoine Quint  <graouts@apple.com>
2712
2713         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2714         https://bugs.webkit.org/show_bug.cgi?id=166837
2715
2716         Reviewed by Alex Christensen.
2717
2718         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2719         the provided value when trying to determine the path to the test file. Failing
2720         that, we use the computed URL or the raw path provided to cover all cases.
2721         
2722         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2723         by applying this patch and seeing the number test failures dramatically reduced
2724         with WK1 due to the option to turn modern media controls off for older media controls
2725         tests.
2726
2727         * DumpRenderTree/DumpRenderTree.h:
2728         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2729         (parseInputLine):
2730         * DumpRenderTree/TestOptions.h:
2731         * DumpRenderTree/TestOptions.mm:
2732         (TestOptions::TestOptions):
2733         * DumpRenderTree/mac/DumpRenderTree.mm:
2734         (runTest):
2735
2736 2017-01-09  Milan Crha  <mcrha@redhat.com>
2737
2738         prepare-ChangeLog: Correct help string for --style option
2739         https://bugs.webkit.org/show_bug.cgi?id=166725
2740
2741         Reviewed by Alexey Proskuryakov.
2742
2743         * Scripts/prepare-ChangeLog:
2744         (main):
2745
2746 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2747
2748         https://bugs.webkit.org/show_bug.cgi?id=166839
2749         Add php7 support for macOS.
2750         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2751
2752         Reviewed by Alexey Proskuryakov.
2753
2754         * Scripts/webkitpy/port/base.py:
2755         (Port._is_darwin_php_version_7):
2756         (Port._debian_php_version):
2757         (Port):
2758         (Port._darwin_php_version):
2759         (Port._apache_config_file_name_for_platform):
2760
2761 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2762
2763         [GTK] Should support key and code properties on keyboard events
2764         https://bugs.webkit.org/show_bug.cgi?id=166759
2765
2766         Reviewed by Carlos Garcia Campos.
2767
2768         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2769         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2770         on tests.
2771
2772 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2773
2774         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2775         https://bugs.webkit.org/show_bug.cgi?id=166760
2776
2777         Reviewed by Darin Adler.
2778
2779         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2780         We can work around that by duplicating and redirecting stdout.
2781
2782         * DumpRenderTree/PixelDumpSupport.cpp:
2783         (dumpWebViewAsPixelsAndCompareWithExpected):
2784         (printPNG):
2785         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2786         (logEventProc):
2787         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2788         (DRTDesktopNotificationPresenter::showDesktopNotification):
2789         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2790         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2791         * DumpRenderTree/win/DumpRenderTree.cpp:
2792         (dumpFrameScrollPosition):
2793         (dumpHistoryItem):
2794         (dumpBackForwardList):
2795         (dump):
2796         (runTest):
2797         (main):
2798         * DumpRenderTree/win/DumpRenderTreeWin.h:
2799         * DumpRenderTree/win/EditingDelegate.cpp:
2800         (EditingDelegate::shouldBeginEditingInDOMRange):
2801         (EditingDelegate::shouldEndEditingInDOMRange):
2802         (EditingDelegate::shouldInsertNode):
2803         (EditingDelegate::shouldInsertText):
2804         (EditingDelegate::shouldDeleteDOMRange):
2805         (EditingDelegate::shouldChangeSelectedDOMRange):
2806         (EditingDelegate::shouldApplyStyle):
2807         (EditingDelegate::shouldChangeTypingStyle):
2808         (EditingDelegate::doPlatformCommand):
2809         (EditingDelegate::webViewDidBeginEditing):
2810         (EditingDelegate::webViewDidChange):
2811         (EditingDelegate::webViewDidEndEditing):
2812         (EditingDelegate::webViewDidChangeTypingStyle):
2813         (EditingDelegate::webViewDidChangeSelection):
2814         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2815         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2816         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2817         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2818         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2819         (FrameLoadDelegate::didCommitLoadForFrame):
2820         (FrameLoadDelegate::didReceiveTitle):
2821         (FrameLoadDelegate::didFinishLoadForFrame):
2822         (FrameLoadDelegate::didFailLoadWithError):
2823         (FrameLoadDelegate::willPerformClientRedirectToURL):
2824         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2825         (FrameLoadDelegate::windowScriptObjectAvailable):
2826         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2827         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2828         (FrameLoadDelegate::didDisplayInsecureContent):
2829         (FrameLoadDelegate::didRunInsecureContent):
2830         (FrameLoadDelegate::webViewProgressFinishedNotification):
2831         * DumpRenderTree/win/HistoryDelegate.cpp:
2832         (HistoryDelegate::didNavigateWithNavigationData):
2833         (HistoryDelegate::didPerformClientRedirectFromURL):
2834         (HistoryDelegate::didPerformServerRedirectFromURL):
2835         (HistoryDelegate::updateHistoryTitle):
2836         (HistoryDelegate::populateVisitedLinksForWebView):
2837         * DumpRenderTree/win/PolicyDelegate.cpp:
2838         (PolicyDelegate::decidePolicyForNavigationAction):
2839         (PolicyDelegate::unableToImplementPolicyWithError):
2840         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2841         (ResourceLoadDelegate::willSendRequest):
2842         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2843         (ResourceLoadDelegate::didReceiveResponse):
2844         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2845         (ResourceLoadDelegate::didFailLoadingWithError):
2846         * DumpRenderTree/win/TestRunnerWin.cpp:
2847         (TestRunner::addDisallowedURL):
2848         (TestRunner::originsWithApplicationCache):
2849         (TestRunner::setStorageDatabaseIdleInterval):
2850         (TestRunner::closeIdleLocalStorageDatabases):
2851         (TestRunner::copyDecodedHostName):
2852         (TestRunner::copyEncodedHostName):
2853         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2854         (TestRunner::isGeolocationProviderActive):
2855         (TestRunner::pathToLocalResource):
2856         (TestRunner::setMockDeviceOrientation):
2857         (TestRunner::setMockGeolocationPosition):
2858         (TestRunner::setMockGeolocationPositionUnavailableError):
2859         (TestRunner::setSpatialNavigationEnabled):
2860         (TestRunner::setAutomaticLinkDetectionEnabled):
2861         (TestRunner::isCommandEnabled):
2862         (TestRunner::authenticateSession):
2863         (TestRunner::addChromeInputField):
2864         (TestRunner::removeChromeInputField):
2865         (TestRunner::focusWebView):
2866         (TestRunner::grantWebNotificationPermission):
2867         (TestRunner::denyWebNotificationPermission):
2868         (TestRunner::removeAllWebNotificationPermissions):
2869         (TestRunner::simulateWebNotificationClick):
2870         (TestRunner::imageCountInGeneralPasteboard):
2871         * DumpRenderTree/win/UIDelegate.cpp:
2872         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2873         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2874         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2875         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2876         (UIDelegate::webViewAddMessageToConsole):
2877         (UIDelegate::exceededDatabaseQuota):
2878         (UIDelegate::setStatusText):
2879         (UIDelegate::didPressMissingPluginButton):
2880
2881 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2882
2883         Add a setting to create editable MiniBrowser windows by default
2884         https://bugs.webkit.org/show_bug.cgi?id=166806
2885
2886         Reviewed by Beth Dakin.
2887
2888         * MiniBrowser/mac/AppDelegate.m:
2889         (-[BrowserAppDelegate createBrowserWindowController:]):
2890         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2891         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2892         * MiniBrowser/mac/SettingsController.h:
2893         * MiniBrowser/mac/SettingsController.m:
2894         (-[SettingsController _populateMenu]):
2895         (-[SettingsController validateMenuItem:]):
2896         (-[SettingsController toggleCreateEditorByDefault:]):
2897         (-[SettingsController createEditorByDefault]):
2898         Add a setting and update the key equivalents accordingly.
2899         Also make sure to make the right kind of window on launch.
2900
2901 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2902
2903         Fix the 32-bit build.
2904
2905         * MiniBrowser/mac/BrowserWindowController.h:
2906         * MiniBrowser/mac/BrowserWindowController.m:
2907
2908 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2909
2910         Fix the 32-bit build.
2911
2912         * MiniBrowser/mac/BrowserWindowController.m:
2913
2914 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2915
2916         Make it possible to drop HTML files on the MiniBrowser icon
2917         https://bugs.webkit.org/show_bug.cgi?id=166802
2918
2919         Reviewed by Simon Fraser.
2920
2921         * MiniBrowser/mac/AppDelegate.m:
2922         (-[BrowserAppDelegate application:openFile:]):
2923         * MiniBrowser/mac/Info.plist:
2924         If you're using an editable window, the usual trick of dropping on the
2925         window doesn't work anymore (it makes an <attachment> instead).
2926
2927 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2928
2929         MiniBrowser window gets smaller each time it is instantiated
2930         https://bugs.webkit.org/show_bug.cgi?id=166807
2931
2932         Reviewed by Andy Estes.
2933
2934         * MiniBrowser/mac/BrowserWindowController.m:
2935         (-[BrowserWindowController windowDidLoad]):
2936         * MiniBrowser/mac/BrowserWindow.xib:
2937         Turn on full-window content view support with IB, instead of waiting
2938         until after the views have been loaded. This seems to resolve the
2939         longstanding ever-shrinking-window problem.
2940
2941 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2942
2943         Add indent/outdent items to MiniBrowser's new format menu
2944         https://bugs.webkit.org/show_bug.cgi?id=166805
2945
2946         Reviewed by Dan Bernstein.
2947
2948         * MiniBrowser/mac/MainMenu.xib:
2949
2950 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2951
2952         Add a stock Format menu to MiniBrowser
2953         https://bugs.webkit.org/show_bug.cgi?id=166804
2954
2955         Reviewed by Andy Estes.
2956
2957         * MiniBrowser/mac/MainMenu.xib:
2958         Many of the features automatically work with editable web views.
2959         However, this seems to expose a bug where none of the font-related features
2960         (Cmd-B, for example) work until the first time the font panel is shown,
2961         per process, which will need to be investigated separately.
2962
2963 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2964
2965         Remove unused applicationWillTerminate methods from MiniBrowser
2966         https://bugs.webkit.org/show_bug.cgi?id=166803
2967
2968         Reviewed by Andy Estes.
2969
2970         * MiniBrowser/mac/AppDelegate.m:
2971         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2972         * MiniBrowser/mac/BrowserWindowController.h:
2973         * MiniBrowser/mac/BrowserWindowController.m:
2974         (-[BrowserWindowController applicationTerminating]): Deleted.
2975         * MiniBrowser/mac/WK1BrowserWindowController.m:
2976         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2977         * MiniBrowser/mac/WK2BrowserWindowController.m:
2978         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2979
2980 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2981
2982         Add the ability to create empty contentEditable windows in MiniBrowser
2983         https://bugs.webkit.org/show_bug.cgi?id=166801
2984
2985         Reviewed by Wenson Hsieh.
2986
2987         * MiniBrowser/mac/AppDelegate.h:
2988         * MiniBrowser/mac/AppDelegate.m:
2989         (-[BrowserAppDelegate createBrowserWindowController:]):
2990         (-[BrowserAppDelegate newWindow:]):
2991         (-[BrowserAppDelegate newEditorWindow:]):
2992         (-[BrowserAppDelegate openDocument:]):
2993         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2994         * MiniBrowser/mac/BrowserWindowController.h:
2995         * MiniBrowser/mac/BrowserWindowController.m:
2996         (-[BrowserWindowController loadHTMLString:]):
2997         (-[BrowserWindowController toggleEditable:]):
2998         * MiniBrowser/mac/MainMenu.xib:
2999         * MiniBrowser/mac/WK1BrowserWindowController.m:
3000         (-[WK1BrowserWindowController awakeFromNib]):
3001         (-[WK1BrowserWindowController loadHTMLString:]):
3002         (-[WK1BrowserWindowController validateMenuItem:]):
3003         (-[WK1BrowserWindowController setEditable:]):
3004         (-[WK1BrowserWindowController updateTitle:]):
3005         * MiniBrowser/mac/WK2BrowserWindowController.m:
3006         (-[WK2BrowserWindowController awakeFromNib]):
3007         (-[WK2BrowserWindowController validateMenuItem:]):
3008         (-[WK2BrowserWindowController setEditable:]):
3009         (-[WK2BrowserWindowController updateTitle:]):
3010         (-[WK2BrowserWindowController loadHTMLString:]):
3011         Merge more functionality from WebEditingTester.
3012         Add two menu items for creating empty editable WebKit1/2 windows.
3013         Add a menu item to the Edit menu to toggle editability on any window.
3014
3015 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3016
3017         Implement find-in-page in MiniBrowser
3018         https://bugs.webkit.org/show_bug.cgi?id=166799
3019
3020         Reviewed by Andy Estes.
3021
3022         * MiniBrowser/mac/BrowserWindow.xib:
3023         * MiniBrowser/mac/BrowserWindowController.h:
3024         * MiniBrowser/mac/BrowserWindowController.m:
3025         (-[BrowserWindowController find:]): Deleted.
3026         * MiniBrowser/mac/MainMenu.xib:
3027         * MiniBrowser/mac/WK1BrowserWindowController.m:
3028         (-[WK1BrowserWindowController toggleShrinkToFit:]):
3029         (-[WK1BrowserWindowController find:]): Deleted.
3030         * MiniBrowser/mac/WK2BrowserWindowController.m:
3031         (-[WK2BrowserWindowController awakeFromNib]):
3032         (-[WK2BrowserWindowController dealloc]):
3033         (-[WK2BrowserWindowController validateMenuItem:]):
3034         (-[WK2BrowserWindowController performTextFinderAction:]):
3035         (-[WK2BrowserWindowController findBarView]):
3036         (-[WK2BrowserWindowController setFindBarView:]):
3037         (-[WK2BrowserWindowController isFindBarVisible]):
3038         (-[WK2BrowserWindowController setFindBarVisible:]):
3039         (-[WK2BrowserWindowController contentView]):
3040         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
3041         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
3042         (-[WK2BrowserWindowController find:]): Deleted.
3043         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
3044         protocol. At first glance, it's pretty broken, but vaguely works.
3045
3046 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3047
3048         Share the implementation of MiniBrowser view hiding functionality
3049         https://bugs.webkit.org/show_bug.cgi?id=166800
3050
3051         Reviewed by Andy Estes.
3052
3053         * MiniBrowser/mac/BrowserWindowController.m:
3054         (-[BrowserWindowController showHideWebView:]):
3055         (-[BrowserWindowController removeReinsertWebView:]):
3056         * MiniBrowser/mac/WK1BrowserWindowController.m:
3057         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
3058         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
3059         * MiniBrowser/mac/WK2BrowserWindowController.m:
3060         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
3061         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
3062         Move the implementation of these two things to the shared superclass,
3063         since they don't depend on WebKit-specific things.
3064         Also, there was no reason to retain the (WK)WebView while it was unparented,
3065         as the BrowserWindowController maintains a reference the entire time.
3066
3067 2017-01-06  Andy Estes  <aestes@apple.com>
3068
3069         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
3070         https://bugs.webkit.org/show_bug.cgi?id=166789
3071
3072         Reviewed by Alex Christensen.
3073
3074         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3075         * DumpRenderTree/PlatformMac.cmake:
3076         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
3077         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
3078         * DumpRenderTree/mac/DumpRenderTree.mm:
3079         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3080         createXMLStringFromWebArchiveData().
3081         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
3082         * WebKitTestRunner/Configurations/Base.xcconfig:
3083         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
3084         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3085         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3086         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3087         createXMLStringFromWebArchiveData().
3088         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
3089         * WebKitTestRunner/PlatformMac.cmake:
3090         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3091         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
3092
3093 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3094
3095         Minor cleanups to IndentOutdentCommand and related code
3096         https://bugs.webkit.org/show_bug.cgi?id=166791
3097
3098         Reviewed by Simon Fraser.
3099
3100         * WebEditingTester/EditingOperations.m:
3101         (editingOperations):
3102         Add the outdent operation to WebEditingTester.
3103
3104 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3105
3106         Create a plan and a patch files for MotionMark and delete the Animometer's ones
3107         https://bugs.webkit.org/show_bug.cgi?id=166785
3108
3109         Reviewed by Ryosuke Niwa.
3110
3111         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3112         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
3113
3114 2017-01-06  Antoine Quint  <graouts@apple.com>
3115
3116         Support webkit-test-runner key-value pairs in http tests
3117         https://bugs.webkit.org/show_bug.cgi?id=149812
3118
3119         Reviewed by Alex Christensen.
3120
3121         We pass the absolute path for a test through to WKTR so that we can parse
3122         tests that are running as URLs for webkit-test-runner options.
3123
3124         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3125         (parseInputLine):
3126
3127         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3128
3129         * Scripts/webkitpy/port/driver.py:
3130         (Driver._command_from_driver_input):
3131
3132         Pass the absolute path to the file through the CLI.
3133
3134         * WebKitTestRunner/TestController.cpp:
3135         (WTR::updateTestOptionsFromTestHeader):
3136         (WTR::TestController::testOptionsForTest):
3137         (WTR::parseInputLine):
3138         (WTR::TestController::runTest):
3139         * WebKitTestRunner/TestController.h:
3140
3141 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3142
3143         Warning about unconnectable outlets when opening a MiniBrowser window
3144         https://bugs.webkit.org/show_bug.cgi?id=166756
3145
3146         Reviewed by Dan Bernstein.
3147
3148         * MiniBrowser/mac/BrowserWindow.xib:
3149         When launching MiniBrowser, it says:
3150         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3151             (MBToolbarItem): missing setter or instance variable
3152         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3153             (NSButtonCell): missing setter or instance variable.
3154
3155         It looks like someone added the connection from the share button
3156         to the BrowserWindowController three times; only one of the connections
3157         is valid. Remove the other two.
3158
3159 2017-01-05  Keith Rollin  <krollin@apple.com>
3160
3161         Add WebCore::URL::protocolHostAndPort
3162         https://bugs.webkit.org/show_bug.cgi?id=166426
3163
3164         Reviewed by Alex Christensen.
3165
3166         Add test for protocolHostAndPort.
3167
3168         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3169         (TestWebKitAPI::TEST_F):
3170
3171 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3172
3173         [Win] Archive test result is failing.
3174         https://bugs.webkit.org/show_bug.cgi?id=166720
3175
3176         Reviewed by Alex Christensen.
3177
3178         Deleting the layout test result folder is sometimes failing
3179         on Windows. This is not a critical error.
3180
3181         * BuildSlaveSupport/test-result-archive:
3182         (archiveTestResults):
3183
3184 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3185
3186         [GTK] Minibrowser: Add printing support
3187         https://bugs.webkit.org/show_bug.cgi?id=165298
3188
3189         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3190         an error during the print, it's printed on the console.
3191
3192         Reviewed by Michael Catanzaro.
3193
3194         * MiniBrowser/gtk/BrowserWindow.c:
3195         (webKitPrintOperationFailedCallback):
3196         (printPage):
3197         (browser_window_init):
3198
3199 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3200
3201         [css-grid] Fix crash clamping grid lines
3202         https://bugs.webkit.org/show_bug.cgi?id=166637
3203
3204         Reviewed by Darin Adler.
3205
3206         Creates new unit test to verify that the maximum tracks limit
3207         is used in GridPosition too.
3208
3209         * TestWebKitAPI/PlatformEfl.cmake:
3210         * TestWebKitAPI/PlatformGTK.cmake:
3211         * TestWebKitAPI/PlatformWin.cmake:
3212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3213         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3214         (TestWebKitAPI::TEST):
3215
3216 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3217
3218         Move editing history scripts to WebCore PrivateHeaders
3219         https://bugs.webkit.org/show_bug.cgi?id=166709
3220         <rdar://problem/29876612>
3221
3222         Reviewed by Dan Bernstein.
3223
3224         Update references to editing script files in WebCore that were moved.
3225
3226         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3227
3228 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3229
3230         Unreviewed, build fix after r210313 part 2
3231         https://bugs.webkit.org/show_bug.cgi?id=166676
3232
3233         Add 'U' suffix.
3234
3235         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3236         (TestWebKitAPI::TEST):
3237         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3238         (TestWebKitAPI::TEST):
3239
3240 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3241
3242         Limit thread name appropriately
3243         https://bugs.webkit.org/show_bug.cgi?id=166676
3244
3245         Reviewed by Sam Weinig.
3246
3247         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3248         (TestWebKitAPI::TEST):
3249         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3250         (TestWebKitAPI::TEST):
3251
3252 2017-01-04  Andy Estes  <aestes@apple.com>
3253
3254         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
3255         https://bugs.webkit.org/show_bug.cgi?id=166696
3256
3257         Reviewed by Tim Horton.
3258
3259         * TestWebKitAPI/PlatformGTK.cmake:
3260         * TestWebKitAPI/PlatformWin.cmake:
3261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3262         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
3263         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
3264         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
3265         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
3266         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
3267         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
3268
3269 2017-01-03  Brian Burg  <bburg@apple.com>
3270
3271         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
3272         https://bugs.webkit.org/show_bug.cgi?id=166003
3273         <rdar://problem/28718990>
3274
3275         Reviewed by Joseph Pecoraro.
3276
3277         Teach run-inspector-generator-tests to generate test output using the platform name
3278         derived from the directory that the test is in. For example, tests in the /generic/
3279         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
3280
3281         * Scripts/webkitpy/inspector/main.py:
3282         (InspectorGeneratorTests.generate_from_json):
3283         (InspectorGeneratorTests.run_tests):
3284         (InspectorGeneratorTests.main):
3285
3286 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3287
3288         Unreviewed cmake buildfix after r210266.
3289
3290         * DumpRenderTree/PlatformMac.cmake:
3291
3292 2017-01-04  Tim Horton  <timothy_horton@apple.com>
3293
3294         Provide a setting for clients to always prefer low-power WebGL
3295         https://bugs.webkit.org/show_bug.cgi?id=166675
3296         <rdar://problem/29834093>
3297
3298         Reviewed by Dan Bernstein.
3299
3300         * MiniBrowser/mac/Info.plist:
3301         Have MiniBrowser claim to be a modern app that supports
3302         automatic graphics switching. WebKit needs to support automatic
3303         graphics switching, so our test app might as well. Without this
3304         Info.plist parameter, this change has no effect, and bringing up
3305         a WebGL context still brings up the discrete GPU (also true of the
3306         existing web-exposed preferLowPowerToHighPerformance API).
3307
3308 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3309
3310         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
3311         https://bugs.webkit.org/show_bug.cgi?id=166645
3312
3313         Reviewed by Carlos Garcia Campos.
3314
3315         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3316         (TestWebKitAPI::TEST):
3317
3318 2017-01-03  Andy Estes  <aestes@apple.com>
3319
3320         Place all the Cocoa WebCore API tests in the same directory
3321         https://bugs.webkit.org/show_bug.cgi?id=166673
3322
3323         Reviewed by Michael Catanzaro.
3324
3325         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3326         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
3327         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
3328         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
3329
3330 2017-01-03  Tim Horton  <timothy_horton@apple.com>
3331
3332         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
3333         https://bugs.webkit.org/show_bug.cgi?id=166450
3334         <rdar://problem/29447824>
3335
3336         Reviewed by Darin Adler.
3337
3338         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3339         * DumpRenderTree/TestRunner.cpp:
3340         (TestRunner::staticFunctions):
3341         * DumpRenderTree/mac/TestRunnerMac.mm:
3342         (setSpellCheckerLoggingEnabledCallback):
3343         * DumpRenderTree/win/TestRunnerWin.cpp:
3344         (setSpellCheckerLoggingEnabledCallback):
3345         * DumpRenderTree/mac/DumpRenderTree.mm:
3346         (resetWebViewToConsistentStateBeforeTesting):
3347         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
3348         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
3349         (stringForCorrectionResponse):
3350         (drt_NSSpellChecker_recordResponseToCorrection):
3351         (swizzleNSSpellCheckerMethodsIfNeeded):
3352         (setSpellCheckerLoggingEnabled):
3353         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
3354         set to true, logs to stdout (which ends up in the test result) whenever
3355         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
3356         is called, and then calls the original method. It is reset to false between tests.
3357
3358 2017-01-03  Sam Weinig  <sam@webkit.org>
3359
3360         Make WTF::Expected support Ref template parameters
3361         https://bugs.webkit.org/show_bug.cgi?id=166662
3362
3363         Reviewed by Alex Christensen.
3364
3365         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3366         (TestWebKitAPI::TEST):
3367         Add tests for using Ref with Expected.
3368
3369 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3370
3371         [GTK] Expose WebKitSecurityOrigin API
3372         https://bugs.webkit.org/show_bug.cgi?id=166632
3373
3374         Reviewed by Carlos Garcia Campos.
3375
3376         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3377         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
3378         (testSecurityOriginBasicConstructor):
3379         (testSecurityOriginURIConstructor):
3380         (testSecurityOriginDefaultPort):
3381         (testSecurityOriginFileURI):
3382         (testSecurityOriginDataURI):
3383         (beforeAll):
3384         (afterAll):
3385
3386 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3387
3388         [GTK] HTTP auth layout tests are flaky
3389         https://bugs.webkit.org/show_bug.cgi?id=158919
3390
3391         Reviewed by Michael Catanzaro.
3392
3393         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
3394         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
3395         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
3396         missing valac in the bots.
3397
3398 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3399
3400         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
3401         https://bugs.webkit.org/show_bug.cgi?id=165797
3402
3403         Reviewed by Michael Catanzaro.
3404
3405         Move directory ruleset after all exclude rules of Source rulset.
3406
3407         * gtk/manifest.txt.in:
3408
3409 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
3410
3411         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
3412         https://bugs.webkit.org/show_bug.cgi?id=166636
3413
3414         Reviewed by Darin Adler.
3415
3416         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3417         (TestWebKitAPI::TEST):
3418
3419 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
3420
3421         [GTK] WebCore/CSSParser unit test is not being built
3422         https://bugs.webkit.org/show_bug.cgi?id=166492
3423
3424         Reviewed by Michael Catanzaro.
3425
3426         This test was introduced in r175930, but we were not building
3427         it on GTK+ port since r176015.
3428         This patch marks the test to be built again on GTK+.
3429         JFTR, the test is passing right now.
3430
3431         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
3432         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
3433
3434 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
3435
3436         AX: Expose block quote level to iOS API
3437         https://bugs.webkit.org/show_bug.cgi?id=166629
3438         <rdar://problem/29834793>
3439
3440         Reviewed by Darin Adler.
3441
3442         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3443         (AccessibilityUIElement::numberAttributeValue):
3444         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3445         (WTR::AccessibilityUIElement::numberAttributeValue):
3446
3447 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
3448
3449         SecurityOrigin::create triplet constructor does not canonicalize port
3450         https://bugs.webkit.org/show_bug.cgi?id=166624
3451
3452         Reviewed by Daniel Bates.
3453
3454         * TestWebKitAPI/PlatformGTK.cmake:
3455         * TestWebKitAPI/PlatformWin.cmake:
3456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3457         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
3458         (TestWebKitAPI::SecurityOriginTest::SetUp):
3459         (TestWebKitAPI::TEST_F):
3460
3461 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
3462
3463         [GTK] Improve user agent construction
3464         https://bugs.webkit.org/show_bug.cgi?id=142074
3465
3466         Reviewed by Carlos Garcia Campos.
3467
3468         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3469         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
3470         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3471         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
3472         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
3473         (TestWebKitAPI::TEST):
3474
3475 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3476
3477         [GTK] Improve user agent construction
3478         https://bugs.webkit.org/show_bug.cgi?id=142074
3479
3480         Reviewed by Carlos Garcia Campos.
3481
3482         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3483         (TestWebKitAPI::TEST):
3484
3485 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
3486
3487         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
3488         https://bugs.webkit.org/show_bug.cgi?id=166472
3489         rdar://problem/29675551
3490
3491         Reviewed by Tim Horton.
3492
3493         These changes are necessary to allow the mouse to leave the WTR window while
3494         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
3495         (which DRT does); we'd always go through mouseMoved, which hits an early return
3496         in WebViewImpl::mouseMoved() when the point is outside the view.
3497
3498         * WebKitTestRunner/mac/EventSenderProxy.mm:
3499         (WTR::EventSenderProxy::mouseMoveTo):
3500
3501 2016-12-23  Andy Estes  <aestes@apple.com>
3502
3503         [iOS] Fix some crashing webarchive tests
3504         https://bugs.webkit.org/show_bug.cgi?id=166470
3505
3506         Reviewed by Andreas Kling.
3507
3508         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
3509         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
3510         so this change uses that on both platforms.
3511
3512         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
3513         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
3514         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
3515         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
3516         * WebKitTestRunner/PlatformMac.cmake:
3517         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3518         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3519
3520 2016-12-22  Saam Barati  <sbarati@apple.com>
3521
3522         WebAssembly: Silence the output of the spec-tests
3523         https://bugs.webkit.org/show_bug.cgi?id=166417
3524
3525         Reviewed by Mark Lam.
3526
3527         * Scripts/run-jsc-stress-tests:
3528
3529 2016-12-22  Zhuo Li  <zachli@apple.com>
3530
3531         [Cocoa] SPI for setloadsImagesAutomatically.
3532         https://bugs.webkit.org/show_bug.cgi?id=166401.
3533
3534         Reviewed by Darin Adler.
3535
3536         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3537         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3538         _loadsImagesAutomatically returns YES.
3539
3540 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3541
3542         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3543         https://bugs.webkit.org/show_bug.cgi?id=161328
3544         <rdar://problem/28475977>
3545
3546         Reviewed by Darin Adler.
3547
3548         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3549         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3550         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3551         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3552         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3553         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3554         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3555         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3556         we finish running a test and before we load the next test.
3557
3558         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3559         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3560         previous test started zooming and then finished before zooming completed. Since this happens before the next
3561         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3562
3563         * WebKitTestRunner/ios/TestControllerIOS.mm:
3564         (WTR::TestController::platformResetStateToConsistentValues):
3565
3566 2016-12-22  Jer Noble  <jer.noble@apple.com>
3567
3568         Muted media element playback should not interrupt other audio playback
3569         https://bugs.webkit.org/show_bug.cgi?id=166347
3570
3571         Reviewed by Eric Carlson.
3572
3573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3574         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3575         (TestWebKitAPI::TEST):
3576         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3577
3578 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3579
3580         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3581         https://bugs.webkit.org/show_bug.cgi?id=166346
3582
3583         Reviewed by Carlos Garcia Campos.
3584
3585         Enable WebRTC by default to simplify testing.
3586
3587         * MiniBrowser/gtk/main.c:
3588         (main):
3589
3590 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3591
3592         REGRESSION: API test failure: WKWebView.LocalStorageClear
3593         https://bugs.webkit.org/show_bug.cgi?id=166032
3594         <rdar://problem/29758423>
3595
3596         Reviewed by Simon Fraser.
3597
3598         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3599         to ensure that the view is destroyed before the callback fires.
3600
3601         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3602         (TEST):
3603
3604 2016-12-21  Saam Barati  <sbarati@apple.com>
3605
3606         WebAssembly: Import spec tests
3607         https://bugs.webkit.org/show_bug.cgi?id=166395
3608
3609         Rubber stamped by Keith Miller.
3610
3611         * Scripts/run-jsc-stress-tests:
3612
3613 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3614
3615         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3616         https://bugs.webkit.org/show_bug.cgi?id=166033
3617         <rdar://problem/29758428>
3618
3619         Reviewed by Simon Fraser.
3620
3621         Add an @autoreleasepool around the code that allocates the WKWebView, 
3622         so that it can be destroyed by removing the last reference in _downloadDidStart.
3623
3624         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3625         (TEST):
3626
3627 2016-12-21  Daniel Bates  <dabates@apple.com>
3628
3629         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3630         https://bugs.webkit.org/show_bug.cgi?id=166356
3631
3632         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3633         as a means to allow a test to explicit allow an embedding client to open a new windows
3634         such that the default behavior is for the embedding client to forbid such an action.
3635         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3636         it is currently skipped on WebKit2 because questions were raised in the patch for
3637         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3638         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3639         this test.
3640
3641         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3642         (WTR::TestRunner::setCanOpenWindows):
3643
3644 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3645
3646         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3647         https://bugs.webkit.org/show_bug.cgi?id=166031
3648
3649         Reviewed by Tim Horton.
3650         
3651         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3652         to ensure that the view is destroyed before the callback fires.
3653
3654         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3655
3656 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3657
3658         Throw Exception when test doesn't clean up HID Events properly
3659         https://bugs.webkit.org/show_bug.cgi?id=166271
3660
3661         Reviewed by Simon Fraser.
3662
3663         Add in a check when UIScriptController is deleted to make sure that the HID event
3664         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3665         the program to crash without any good information. Crashes are race-y, and will still
3666         happen with malformed test, but the information will be much more helpful. 
3667
3668         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3669         (WTR::UIScriptController::checkForClean):
3670         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3671         (UIScriptContext::~UIScriptContext):
3672         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3673         (WTR::UIScriptController::checkForClean):
3674         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3675         * WebKitTestRunner/ios/HIDEventGenerator.h:
3676         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3677         (-[HIDEventGenerator checkHIDCallbacksClear]):
3678         * WebKitTestRunner/ios/TestControllerIOS.mm:
3679         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3680         (WTR::UIScriptController::checkForClean):
3681
3682 2016-12-20  Andy Estes  <aestes@apple.com>
3683
3684         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3685         https://bugs.webkit.org/show_bug.cgi?id=165992
3686
3687         Reviewed by Brady Eidson.
3688
3689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3690         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3691         (expectException):
3692         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3693         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3694         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3695         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3696         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3697         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3698         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3699         (TEST):
3700         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3701
3702 2016-12-20  Dean Jackson  <dino@apple.com>
3703
3704         Remove INDIE_UI
3705         https://bugs.webkit.org/show_bug.cgi?id=165881
3706         <rdar://problem/29672532>
3707
3708         Reviewed by Simon Fraser.
3709
3710         The Indie UI work has been discontinued.
3711
3712         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3713
3714 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3715
3716         [ES6] Enable ES6 Modules
3717         https://bugs.webkit.org/show_bug.cgi?id=165849
3718
3719         Reviewed by Geoffrey Garen.
3720
3721         * DumpRenderTree/mac/DumpRenderTree.mm:
3722         (resetWebPreferencesToConsistentValues):
3723         * DumpRenderTree/win/DumpRenderTree.cpp:
3724         (resetWebPreferencesToConsistentValues):
3725         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3726         (WTR::InjectedBundle::beginTesting):
3727         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3728         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3729         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3730
3731 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3732
3733         Repurpose bots and clean up dashboard.
3734         https://bugs.webkit.org/show_bug.cgi?id=166045
3735
3736         Reviewed by Lucas Forschler.
3737
3738         * BuildSlaveSupport/build.webkit.org-config/config.json:
3739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3740         (BubbleQueueServer):
3741         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3743         (WebKitBuildbot):
3744         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3745         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3746
3747 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3748
3749         [CMake] TestWebKitAPIBase links to itself
3750         https://bugs.webkit.org/show_bug.cgi?id=165985
3751
3752         Reviewed by Alex Christensen.
3753
3754         Fix CMake warning about a target linking to itself, which makes no sense.
3755
3756         * TestWebKitAPI/CMakeLists.txt:
3757
3758 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3759
3760         [GTK] GtkDoc build should be quieter
3761         https://bugs.webkit.org/show_bug.cgi?id=165994
3762
3763         Reviewed by Carlos Garcia Campos.
3764
3765         Make it not print by default.
3766
3767         * gtk/generate-gtkdoc:
3768         (get_generator_for_config):
3769         (generate_doc):
3770         * gtk/gtkdoc.py:
3771         (GTKDoc._run_command):
3772         (GTKDoc._copy_doc_files_to_output_dir):
3773
3774 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3775
3776         Expose a way for MiniBrowser to simulate header and footer banners
3777         https://bugs.webkit.org/show_bug.cgi?id=166005
3778
3779         Reviewed by Wenson Hsieh.
3780         
3781         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3782         banners. This only works in WebKit2.
3783         
3784         We need to reset these on each navigation, since newly created FrameViews
3785         don't re-fetch the header and footer height stored on Page.
3786         
3787         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3788         as well as fixing webViewWebContentProcessDidTerminate:
3789
3790         * MiniBrowser/mac/SettingsController.h:
3791         * MiniBrowser/mac/SettingsController.m:
3792         (-[SettingsController _populateMenu]):
3793         (-[SettingsController validateMenuItem:]):
3794         (-[SettingsController toggleReserveSpaceForBanners:]):
3795         (-[SettingsController isSpaceReservedForBanners]):
3796         * MiniBrowser/mac/WK2BrowserWindowController.m:
3797         (-[WK2BrowserWindowController didChangeSettings]):
3798         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3799         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3800         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3801         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3802
3803 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3804
3805         Fix iOS test results after r209967.
3806         
3807         Subtracting out the status bar height was erroneously happening for all tests,
3808         not just for flexible viewport tests.
3809         
3810         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3811
3812         * WebKitTestRunner/PlatformWebView.h:
3813         * WebKitTestRunner/TestController.cpp:
3814         (WTR::TestController::resetStateToConsistentValues):
3815         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3816         (WTR::PlatformWebView::resizeTo):
3817         (WTR::PlatformWebView::setWindowFrame):
3818         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3819         (WTR::PlatformWebView::resizeTo):
3820         (WTR::PlatformWebView::setWindowFrame):
3821         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3822         (WTR::PlatformWebView::resizeTo):
3823         (WTR::PlatformWebView::setWindowFrame):
3824         * WebKitTestRunner/ios/TestControllerIOS.mm:
3825         (WTR::TestController::platformConfigureViewForTest):
3826         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3827         (WTR::PlatformWebView::resizeTo):
3828         (WTR::PlatformWebView::setWindowFrame):
3829
3830 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3831
3832         [EFL] bump EFL version to 1.18.4
3833         https://bugs.webkit.org/show_bug.cgi?id=166004
3834
3835         Reviewed by Gyuyoung Kim.
3836
3837         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3838
3839 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3840
3841         Visual viewports: bottom fixed elements disappear behind the keyboard
3842         https://bugs.webkit.org/show_bug.cgi?id=165983
3843         <rdar://problem/29409852>
3844
3845         Reviewed by Simon Fraser.
3846
3847         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3848         the keyboard when it is up.
3849
3850         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3851         (WTR::UIScriptController::inputViewBounds):
3852         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3853         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3854         (WTR::UIScriptController::inputViewBounds):
3855         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3856         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3857         (WTR::viewRectForWindowRect):
3858
3859         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3860         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3861         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3862
3863         (WTR::PlatformWebView::PlatformWebView):
3864         (WTR::PlatformWebView::setWindowFrame):
3865         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3866         (WTR::UIScriptController::inputViewBounds):
3867
3868 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3869
3870         Deleting a character converted from pinyin after an image causes a Safari crash
3871         https://bugs.webkit.org/show_bug.cgi?id=165839
3872         <rdar://problem/27951933>
3873
3874         Reviewed by Wenson Hsieh.
3875
3876         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
3877         while the proposed range contains an image. This should not cause a WebProcess to crash
3878         or send an invalid message to the UIProcess.
3879
3880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3881         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
3882         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
3883         (TestWebKitAPI::didFinishLoadForFrame):
3884         (TestWebKitAPI::processDidCrash):
3885         (TestWebKitAPI::invalidMessageFunction):
3886         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
3887
3888 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3889
3890         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3891         https://bugs.webkit.org/show_bug.cgi?id=165767
3892         <rdar://problem/29602382>
3893
3894         Reviewed by Simon Fraser.
3895
3896         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3897         WebKit2 ChangeLog for more details.
3898
3899         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3900         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3901         (WTR::UIScriptController::textSelectionCaretRect):
3902         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3903         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3904         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3905         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3906         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3907         (WTR::UIScriptController::textSelectionCaretRect):
3908         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3909         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3910         (-[TestRunnerWKWebView _setStableStateOverride:]):
3911
3912         Force the WKWebView to update its visible content rects when changing the stable state override.
3913
3914         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3915         (WTR::toNSDictionary):
3916         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3917         (WTR::UIScriptController::selectionRangeViewRects):
3918         (WTR::UIScriptController::textSelectionCaretRect):
3919         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3920         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3921
3922 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3923
3924         Arguments called in wrong order
3925         https://bugs.webkit.org/show_bug.cgi?id=165923
3926
3927         Reviewed by Simon Fraser.
3928
3929         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3930         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3931
3932         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3933         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3934         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3935
3936 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3937
3938         [EFL] Disable non-srcdir builds for failing libraries
3939         https://bugs.webkit.org/show_bug.cgi?id=165896
3940
3941         Reviewed by Gyuyoung Kim.
3942
3943         * efl/jhbuild.modules: Set non srcdir builds to no
3944
3945 2016-12-15  Daniel Bates  <dabates@apple.com>
3946
3947         check-style should not complain about code in icu directories
3948         https://bugs.webkit.org/show_bug.cgi?id=53929
3949
3950         Reviewed by Darin Adler.
3951
3952         Skip style checking of imported ICU headers to avoid a deluge of style issues
3953         as they do not conform to the WebKit Code Style guideline. We want to preserve
3954         the formatting of these headers so as to make it straightforward to merge
3955         changes to them, if necessary.
3956
3957         * Scripts/webkitpy/style/checker.py:
3958
3959 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3960
3961         Move JSC testers from Yosemite to Sierra
3962         https://bugs.webkit.org/show_bug.cgi?id=165925
3963
3964         Reviewed by Lucas Forschler.
3965
3966         * BuildSlaveSupport/build.webkit.org-config/config.json:
3967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3968         (WebKitBuildbot):
3969
3970 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3971
3972         Add coordinate space to event streams and streamline tests
3973         https://bugs.webkit.org/show_bug.cgi?id=165119
3974
3975         Reviewed by Simon Fraser.
3976
3977         Update event streams to allow for both content and global coordinate space.
3978         Update example script to more accurately show all the available options.
3979
3980         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3981         * WebKitTestRunner/ios/HIDEventGenerator.h:
3982         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3983         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3984         (WTR::convertCoordinates):
3985         (WTR::UIScriptController::sendEventStream):
3986
3987 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
3988
3989         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
3990         https://bugs.webkit.org/show_bug.cgi?id=165855
3991
3992         Reviewed by Philippe Normand.
3993
3994         GStreamer's autogen.sh enables gtk-doc always so we end up building
3995         docs even if we disable them. Use the configure script instead, since
3996         we build from packages and these include it already.
3997
3998         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
3999         upstream gstreamer packages.
4000
4001 2016-12-15  Alex Christensen  <achristensen@webkit.org>
4002
4003         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
4004         https://bugs.webkit.org/show_bug.cgi?id=165885
4005         <rdar://problem/29476917>
4006
4007         Reviewed by Darin Adler.
4008
4009         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4010         (TestWebKitAPI::utf16String): Deleted.
4011         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
4012         (TestWebKitAPI::TEST_F):
4013         * TestWebKitAPI/WTFStringUtilities.h:
4014         (utf16String):
4015         Moved from URLParser to share with other tests.
4016
4017 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
4018
4019         iOS: An element with tabindex is not focusable unless there is no mouse event handler
4020         https://bugs.webkit.org/show_bug.cgi?id=165843
4021
4022         Reviewed by Antti Koivisto.
4023
4024         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
4025         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
4026         and DumpRenderTree's runUIScript would hit an assertion :(
4027
4028         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4029         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4030         (WTR::TestRunner::isWebKit2):
4031
4032 2016-12-14  Brady Eidson  <beidson@apple.com>
4033
4034         IndexedDB 2.0: Massively speedup IDBIndex.get().
4035         https://bugs.webkit.org/show_bug.cgi?id=165802
4036
4037         Reviewed by Alex Christensen.
4038
4039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4040         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
4041         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
4042         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
4043         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
4044
4045 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4046
4047         [GTK][EFL] Update the JHBuild version.
4048         https://bugs.webkit.org/show_bug.cgi?id=165838
4049
4050         Reviewed by Michael Catanzaro.
4051
4052         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
4053         usage of the JHBUILD_MIRROR feature with git repositories.
4054
4055 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4056
4057         [GTK] Yasm is needed for building the JHBuild after r208940
4058         https://bugs.webkit.org/show_bug.cgi?id=165837
4059
4060         Reviewed by Alejandro G. Castro.
4061
4062         * gtk/install-dependencies: Yasm is needed for building libvpx.
4063
4064 2016-12-14  Youenn Fablet  <youenn@apple.com>
4065
4066         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
4067         https://bugs.webkit.org/show_bug.cgi?id=161310
4068
4069         Reviewed by Ryosuke Niwa.
4070
4071         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
4072         When set, WTR and DRT output JS console log in the stderr and not the test output.
4073         This allows removing potentially flaky information while still being able to read it for investigation.
4074
4075         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
4076
4077         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
4078         This test should have this option when fetch API will start logging resource loader errors.
4079
4080         * DumpRenderTree/DumpRenderTree.h:
4081         (TestCommand::TestCommand): Deleted.
4082         * DumpRenderTree/DumpRenderTreeCommon.cpp:
4083         (parseInputLine):
4084         * DumpRenderTree/TestRunner.h:
4085         (TestRunner::setDumpJSConsoleLogInStdErr):
4086         (TestRunner::dumpJSConsoleLogInStdErr):
4087         * DumpRenderTree/mac/DumpRenderTree.mm:
4088         (runTest):
4089         * DumpRenderTree/mac/UIDelegate.mm:
4090         (-[UIDelegate webView:addMessageToConsole:withSource:]):
4091         * DumpRenderTree/win/DumpRenderTree.cpp:
4092         (runTest):
4093         * DumpRenderTree/win/UIDelegate.cpp:
4094         (UIDelegate::webViewAddMessageToConsole):
4095         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4096         (TestExpectationParser._tokenize_line):
4097         * Scripts/webkitpy/port/driver.py:
4098         (Driver._command_from_driver_input):
4099         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4100         (WTR::InjectedBundle::didReceiveMessageToPage):
4101         (WTR::InjectedBundle::dumpToStdErr):
4102         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4103         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
4104         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4105         (WTR::InjectedBundlePage::willAddMessageToConsole):
4106         * WebKitTestRunner/TestController.cpp:
4107         (WTR::parseInputLine):
4108         (WTR::TestController::runTest):
4109         (WTR::TestCommand::TestCommand): Deleted.
4110         * WebKitTestRunner/TestInvocation.cpp:
4111         (WTR::TestInvocation::invoke):
4112         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4113         * WebKitTestRunner/TestInvocation.h:
4114         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
4115
4116
4117 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
4118
4119         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
4120         https://bugs.webkit.org/show_bug.cgi?id=164022
4121
4122         Reviewed by Xabier Rodriguez-Calvar.
4123
4124         * Scripts/webkitperl/FeatureList.pm:
4125           Re-enable MEDIA_SOURCE for the GTK+ port.
4126
4127 2016-12-13  Alex Christensen  <achristensen@webkit.org>
4128
4129         Fix CMake build.
4130
4131         * DumpRenderTree/PlatformMac.cmake:
4132         Define NS_RETURNS_RETAINED as nothing for now.
4133
4134 2016-12-13  Jer Noble  <jer.noble@apple.com>
4135
4136         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
4137         https://bugs.webkit.org/show_bug.cgi?id=165697
4138
4139         Reviewed by Tim Horton.
4140
4141         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
4142         (TestWebKitAPI::TEST):
4143
4144 2016-12-13  Andy Estes  <aestes@apple.com>
4145
4146         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
4147         https://bugs.webkit.org/show_bug.cgi?id=165785
4148         <rdar://problem/26929398>
4149
4150         Reviewed by Darin Adler.
4151
4152         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
4153         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
4154         expectations for the text, range, and action.
4155         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
4156         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
4157         plain-text string to the pasteboard, executed a paste action, and verified that the selected
4158         text in the web view did not change.
4159         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
4160         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
4161         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
4162         parameter.
4163         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
4164         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
4165         and returned the value of _editingDelegateShouldInsertText.
4166         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
4167         -shouldInsertText:replacingRange:givenAction:.
4168
4169 2016-12-13  Chris Dumez  <cdumez@apple.com>
4170
4171         Unreviewed, rolling out r209544.
4172
4173         Looks like r209489 did not cause the performance regression
4174         after all
4175
4176         Reverted changeset:
4177
4178         "Unreviewed, rolling out r209489."
4179         https://bugs.webkit.org/show_bug.cgi?id=165550
4180         http://trac.webkit.org/changeset/209544
4181
4182 2016-12-12  Sam Weinig  <sam@webkit.org>
4183
4184         [WebIDL] Remove use of Dictionary in ApplePaySession
4185         https://bugs.webkit.org/show_bug.cgi?id=165787
4186
4187         Reviewed by Anders Carlsson.
4188
4189         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4190         (WTR::initializeWebViewConfiguration):
4191         (WTR::TestController::platformCreateWebView):
4192         Enable ApplePay for the tests (where supported).
4193
4194 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
4195
4196         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
4197         https://bugs.webkit.org/show_bug.cgi?id=165251
4198
4199         Reviewed by Youenn Fablet.
4200
4201         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
4202         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
4203         the preferences have been set.
4204
4205 2016-12-08  Antti Koivisto  <antti@apple.com>
4206
4207         Enable network cache speculative revalidation in MiniBrowser
4208         https://bugs.webkit.org/show_bug.cgi?id=165616
4209
4210         Reviewed by Darin Adler.
4211
4212         Match Safari. Also add a menu item to disable it.
4213
4214         * MiniBrowser/mac/AppDelegate.m:
4215         (defaultConfiguration):
4216         * MiniBrowser/mac/SettingsController.h:
4217         * MiniBrowser/mac/SettingsController.m:
4218         (-[SettingsController _populateMenu]):
4219         (-[SettingsController validateMenuItem:]):
4220         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
4221         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
4222
4223 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
4224
4225         ChangeLogs become readonly after resolving a conflict
4226         https://bugs.webkit.org/show_bug.cgi?id=165440
4227         rdar://problem/29491002
4228
4229         Reviewed by Darin Adler.
4230
4231         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
4232         moving the file.
4233
4234 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
4235
4236         Re-enable collectContinuously since it doesn't crash anymore
4237
4238         Rubber stamped by Michael Saboff.
4239
4240         * Scripts/run-jsc-stress-tests:
4241
4242 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
4243
4244         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
4245         https://bugs.webkit.org/show_bug.cgi?id=165686
4246
4247         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
4248         so that right config.h comes first in include path.
4249
4250 2016-12-11  Dave Hyatt  <hyatt@apple.com>
4251
4252         [CSS Parser] Make sure content extensions initialize AtomicString
4253         https://bugs.webkit.org/show_bug.cgi?id=165737
4254
4255         Reviewed by Darin Adler.
4256
4257         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4258         (TestWebKitAPI::makeBackend):
4259
4260 2016-12-08  Dave Hyatt  <hyatt@apple.com>
4261
4262         [CSS Parser] Remove the old CSS Parser
4263         https://bugs.webkit.org/show_bug.cgi?id=165645
4264
4265         Reviewed by Daniel Bates.
4266
4267         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
4268         (TestWebKitAPI::TEST):
4269
4270 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
4271
4272         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
4273         https://bugs.webkit.org/show_bug.cgi?id=165686
4274
4275         Reviewed by Michael Catanzaro.
4276
4277         This change reduces duplication of include path lists between modules,
4278         and reduces future need for fixes like r209605 (broken build because of
4279         WebCore header suddenly becoming used in WebKit2).
4280
4281         * DumpRenderTree/CMakeLists.txt:
4282         * DumpRenderTree/PlatformMac.cmake:
4283         * ImageDiff/CMakeLists.txt:
4284         * MiniBrowser/gtk/CMakeLists.txt:
4285         * MiniBrowser/mac/CMakeLists.txt:
4286         * MiniBrowser/win/CMakeLists.txt:
4287         * TestWebKitAPI/CMakeLists.txt:
4288         * TestWebKitAPI/PlatformEfl.cmake:
4289         * TestWebKitAPI/PlatformJSCOnly.cmake:
4290         * TestWebKitAPI/PlatformMac.cmake:
4291         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
4292         * WebKitTestRunner/CMakeLists.txt:
4293         * WebKitTestRunner/PlatformGTK.cmake:
4294         * WebKitTestRunner/PlatformMac.cmake:
4295
4296 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
4297
4298         Unreviewed buildfix after r209630.
4299
4300         * Scripts/build-jsc: Remove building the non-existing testWASM.
4301
4302 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
4303
4304         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
4305         https://bugs.webkit.org/show_bug.cgi?id=165251
4306
4307         Reviewed by Dean Jackson.
4308
4309         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
4310
4311         * DumpRenderTree/mac/DumpRenderTree.mm:
4312         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
4313
4314         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4315         (WTR::InjectedBundle::beginTesting): Ditto.
4316