Fix Yosemite bots' cookie accept policies after r204365.
[WebKit-https.git] / Tools / ChangeLog
1 2016-08-11  Alex Christensen  <achristensen@webkit.org>
2
3         Fix Yosemite bots' cookie accept policies after r204365.
4         https://bugs.webkit.org/show_bug.cgi?id=160758
5
6         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
7         (TEST):
8         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
9         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
10         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
11         causing any problems because there are no other API tests that do anything with cookies.
12         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
13         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
14         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
15
16 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
17
18         EWS should check if the patch is still valid before executing every major step
19         https://bugs.webkit.org/show_bug.cgi?id=160739
20         rdar://problem/27768813
21
22         Reviewed by Alexey Proskuryakov.
23
24         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
25         (CommitQueueTask.run): validate method is now executed in base class.
26         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
27         (EarlyWarningSystemTask.run): validate method is now executed in base class.
28         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
29         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
30         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
31         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
32         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
33         * Scripts/webkitpy/tool/commands/perfalizer.py:
34         (PerfalizerTask.validate): Added.
35         * Scripts/webkitpy/tool/commands/queues_unittest.py:
36         (test_manual_reject_during_processing): Updated test case.
37
38 2016-08-11  Alex Christensen  <achristensen@webkit.org>
39
40         Add URLParser stub
41         https://bugs.webkit.org/show_bug.cgi?id=160770
42
43         Reviewed by Sam Weinig.
44
45         * TestWebKitAPI/PlatformGTK.cmake:
46         * TestWebKitAPI/PlatformWin.cmake:
47         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
48         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
49         (TestWebKitAPI::TEST_F):
50
51 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
52
53         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
54         https://bugs.webkit.org/show_bug.cgi?id=160761
55
56         Reviewed by Tim Horton.
57
58         Give iOS DRT a Launch storyboard.
59
60         Have it use a UIViewController so future forms testing works correctly.
61
62         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
63         can run in iPad mode.
64
65         Remove empty InfoPlist.strings files.
66
67         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
68         * DumpRenderTree/ios/Info.plist:
69         * DumpRenderTree/ios/Launch.storyboard: Added.
70         * DumpRenderTree/mac/DumpRenderTree.mm:
71         (createWebViewAndOffscreenWindow):
72         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
73         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
74         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
75         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
76
77 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
78
79         [Win] Unable to reliably run tests in parallel
80         https://bugs.webkit.org/show_bug.cgi?id=140914
81
82         Reviewed by Brent Fulgham.
83
84         The cygpath utility function can fail badly when running with multiple DumpRenderTree
85         processes. We can use string replacement to convert the Cygwin path to a Windows path
86         instead.
87
88         * Scripts/webkitpy/common/system/path.py:
89         (cygpathFast):
90         * Scripts/webkitpy/port/driver.py:
91         (Driver._command_from_driver_input):
92
93 2016-08-10  Alex Christensen  <achristensen@webkit.org>
94
95         Fix crash when changing cookie accept policy after r204327
96         https://bugs.webkit.org/show_bug.cgi?id=160758
97
98         Reviewed by Simon Fraser.
99
100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
101         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
102         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
103         (TEST):
104         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
105
106 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
107
108         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
109         https://bugs.webkit.org/show_bug.cgi?id=160757
110
111         Reviewed by Tim Horton.
112
113         When programmatically creating the test UIWindow, make a root UIViewController and parent
114         the WKWebView in its view. This makes the app more like a normal UIKit application.
115         
116         Move the WKWebView down 20px to avoid the status bar.
117         
118         Give the UIWindow a gray background so it's obvious where the window and view positioned.
119
120         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
121         
122         Remove duplicate references to Launch.storyboard.
123
124         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
125         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
126         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
127         (-[AppDelegate applicationWillResignActive:]): Deleted.
128         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
129         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
130         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
131         (-[AppDelegate applicationWillTerminate:]): Deleted.
132         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
133         (WTR::viewRectForWindowRect):
134         (WTR::PlatformWebView::PlatformWebView):
135         (WTR::PlatformWebView::setWindowFrame):
136
137 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
138
139         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
140         https://bugs.webkit.org/show_bug.cgi?id=160748
141
142         Reviewed by Tim Horton.
143         
144         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
145         opens the door for tests using other device sizes.
146
147         * WebKitTestRunner/ios/TestControllerIOS.mm:
148         (WTR::TestController::platformConfigureViewForTest):
149
150 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
151
152         Sort the feature flags in the FEATURE_DEFINES lines
153         https://bugs.webkit.org/show_bug.cgi?id=160742
154
155         Reviewed by Anders Carlsson.
156         
157         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
158
159 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
160
161         Logging and other minor improvements to iOS webkitpy
162         https://bugs.webkit.org/show_bug.cgi?id=160722
163
164         Reviewed by Dan Bates.
165
166         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
167         to make it easier to debug launching issues.
168
169         Have reset_preferences() reset the device, rather than just nuking the data
170         directory (which broke some versions of the simulator).
171
172         Make the Simulator.app launch in the background with open -g.
173
174         Wait for the simulator device to be in a known state in some more places.
175
176         * Scripts/webkitpy/port/ios.py:
177         (IOSSimulatorPort.setup_test_run):
178         (IOSSimulatorPort._quit_ios_simulator):
179         (IOSSimulatorPort.clean_up_test_run):
180         (IOSSimulatorPort.setup_environ_for_server):
181         (IOSSimulatorPort.reset_preferences):
182         * Scripts/webkitpy/xcode/simulator.py:
183         (Device.create):
184         (Device.delete):
185         (Device):
186         (Device.reset):
187         (Simulator.wait_until_device_is_booted):
188         (Simulator.wait_until_device_is_in_state):
189         (Simulator):
190         (Simulator.delete_device):
191         (Simulator.reset_device):
192         (Simulator.lookup_or_create_device):
193
194 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
195
196         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
197         https://bugs.webkit.org/show_bug.cgi?id=160697
198
199         Reviewed by Antonio Gomes.
200
201         * Scripts/webkitpy/port/base.py:
202         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
203         list of environment variables to copy.
204
205 2016-08-09  George Ruan  <gruan@apple.com>
206
207         Implement functionality of media capture on iOS
208         https://bugs.webkit.org/show_bug.cgi?id=158945
209         <rdar://problem/26893343>
210
211         Reviewed by Tim Horton.
212
213         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
214         Capture feature on iOS.
215
216 2016-08-09  Saam Barati  <sbarati@apple.com>
217
218         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
219         https://bugs.webkit.org/show_bug.cgi?id=160671
220         <rdar://problem/27756112>
221
222         Reviewed by Mark Lam.
223
224         * Scripts/run-jsc-stress-tests:
225
226 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
227
228         Make directory reading code in iOSSimulatorDevices() more strict
229         https://bugs.webkit.org/show_bug.cgi?id=160702
230
231         Reviewed by Tim Horton.
232
233         * Scripts/webkitdirs.pm:
234         (iOSSimulatorDevices):
235
236 2016-08-06  Sam Weinig  <sam@webkit.org>
237
238         Replace NodeOrString with std::variant<RefPtr<Node>, String>
239         https://bugs.webkit.org/show_bug.cgi?id=160638
240
241         Reviewed by Anders Carlsson.
242
243         * TestWebKitAPI/CMakeLists.txt:
244         * TestWebKitAPI/Tests/WTF/Variant.cpp:
245         Add additional tests for the initial state of std::variant and using
246         makeVisitor for visiting.
247
248 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
249
250         EWS logging should ensure the logging to file is stopped on queue termination
251         https://bugs.webkit.org/show_bug.cgi?id=160698
252         rdar://problem/24464570
253
254         Reviewed by Daniel Bates.
255
256         * Scripts/webkitpy/tool/bot/queueengine.py:
257         (QueueEngine._stopping): Stop logging to file on queue termination.
258         (QueueEngine._begin_logging): Configure the Python logger to log to file.
259         * Scripts/webkitpy/common/system/logutils.py:
260         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
261         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
262         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
263         * Scripts/webkitpy/tool/commands/queues.py:
264         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
265         (AbstractQueue.queue_log_path): Same.
266         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
267         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
268         which moved to QueueEngine now.
269         (PatchProcessingQueue.__init__): Same.
270         (CommitQueue.__init__): Same.
271         (AbstractReviewQueue.__init__): Same.
272         (StyleQueue.__init__): Same.
273         * Scripts/webkitpy/tool/commands/queues_unittest.py:
274         (TestCommitQueue): Removed host parameter.
275         (TestCommitQueue.__init__): Same.
276         (AbstractPatchQueueTest.test_next_patch): Same.
277         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
278         (test_commit_queue_failure): Same.
279         (mock_run_webkit_patch):
280         (MockCommitQueueTask.results_from_patch_test_run): Same.
281         (test_rollout_lands): Same.
282         (test_non_valid_patch): Same.
283         (test_auto_retry): Same.
284         (test_style_queue_with_watch_list_exception): Same.
285         (TestQueue.__init__): Deleted.
286         (TestReviewQueue.__init__): Deleted.
287         (TestFeederQueue.__init__): Deleted.
288
289 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
290
291         webkit-gtk tarball fails to build due to missing files
292         https://bugs.webkit.org/show_bug.cgi?id=160684
293
294         Reviewed by Alex Christensen.
295
296         * gtk/manifest.txt.in: Added back spi directories.
297
298 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
299
300         [GTK] Build the jhbuild with -O2 optimization level by default
301         https://bugs.webkit.org/show_bug.cgi?id=160544
302
303         Reviewed by Michael Catanzaro.
304
305         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
306         which don't increases the required disk space significatively and
307         provides better debug information than no passing it.
308
309 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
310
311         Allow more --cmakeargs option in build-jsc and build-webkit
312         https://bugs.webkit.org/show_bug.cgi?id=160340
313
314         Reviewed by Michael Catanzaro.
315
316         * Scripts/build-jsc:
317         * Scripts/build-webkit:
318
319 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
320
321         Do not check if WebKitLibraries folder exists on EFL and GTK
322         https://bugs.webkit.org/show_bug.cgi?id=160659
323
324         Reviewed by Csaba Osztrogonác.
325
326         Though WebKitLibraries is only needed by mac and win ports,
327         EFL and GTK ports have checked whether it exists.
328
329         * Scripts/build-webkit:
330
331 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
332
333         Some EWS console logs doesn't go to log file
334         https://bugs.webkit.org/show_bug.cgi?id=160585
335         rdar://problem/24464570
336
337         Reviewed by Daniel Bates.
338
339         * Scripts/webkitpy/common/system/logutils.py:
340         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
341         any possible overwriting.
342         * Scripts/webkitpy/common/system/filesystem.py:
343         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
344         * Scripts/webkitpy/common/system/filesystem_mock.py:
345         (MockFileSystem.open_text_file_for_writing): Same.
346         * Scripts/webkitpy/common/system/filesystem_unittest.py:
347         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
348         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
349         * Scripts/webkitpy/tool/commands/queues.py:
350         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
351         This will ensure that all the sub-modules inside webkitpy will log to file.
352
353 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
354
355         Have the iOS platform interit from the Apple platform in webkitpy
356         https://bugs.webkit.org/show_bug.cgi?id=160672
357
358         Reviewed by Dan Bates.
359         
360         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
361         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
362         ApplePort.
363         
364         Since WinPort also inherits from ApplePort, it needs to stub out some things
365         that are unavailable on Windows (leaks, sampling).
366         
367         Some SnowLeopard-related code and the associated test were removed.
368
369         * Scripts/webkitpy/port/apple.py:
370         (ApplePort.__init__):
371         (ApplePort):
372         (ApplePort._make_leak_detector):
373         (ApplePort.default_timeout_ms):
374         (ApplePort.supports_per_test_timeout):
375         (ApplePort.should_retry_crashes):
376         (ApplePort._generate_all_test_configurations):
377         (ApplePort.check_for_leaks):
378         (ApplePort.print_leaks_summary):
379         (ApplePort._path_to_webcore_library):
380         (ApplePort.show_results_html_file):
381         (ApplePort._merge_crash_logs):
382         (ApplePort._look_for_all_crash_logs_in_log_dir):
383         (ApplePort._get_crash_log):
384         (ApplePort.look_for_new_crash_logs):
385         (ApplePort.sample_process):
386         (ApplePort.sample_file_path):
387         (ApplePort.look_for_new_samples):
388         (ApplePort._path_to_helper):
389         (ApplePort.determine_full_port_name): Deleted.
390         * Scripts/webkitpy/port/ios.py:
391         (IOSSimulatorPort):
392         (IOSSimulatorPort.__init__):
393         (IOSSimulatorPort.default_timeout_ms): Deleted.
394         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
395         (IOSSimulatorPort.should_retry_crashes): Deleted.
396         (IOSSimulatorPort.check_for_leaks): Deleted.
397         (IOSSimulatorPort.print_leaks_summary): Deleted.
398         (IOSSimulatorPort._path_to_webcore_library): Deleted.
399         (IOSSimulatorPort.show_results_html_file): Deleted.
400         (IOSSimulatorPort.sample_file_path): Deleted.
401         (IOSSimulatorPort._merge_crash_logs): Deleted.
402         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
403         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
404         (IOSSimulatorPort.look_for_new_samples): Deleted.
405         (IOSSimulatorPort.sample_process): Deleted.
406         (IOSSimulatorPort._path_to_helper): Deleted.
407         (IOSSimulatorPort.make_command): Deleted.
408         * Scripts/webkitpy/port/mac.py:
409         (MacPort.__init__):
410         (MacPort.make_command):
411         (MacPort._build_java_test_support):
412         (MacPort): Deleted.
413         (MacPort.default_timeout_ms): Deleted.
414         (MacPort.supports_per_test_timeout): Deleted.
415         (MacPort.should_retry_crashes): Deleted.
416         (MacPort.default_child_processes): Deleted.
417         (MacPort.check_for_leaks): Deleted.
418         (MacPort.print_leaks_summary): Deleted.
419         (MacPort._path_to_webcore_library): Deleted.
420         (MacPort.show_results_html_file): Deleted.
421         (MacPort.sample_file_path): Deleted.
422         (MacPort._merge_crash_logs): Deleted.
423         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
424         (MacPort.look_for_new_crash_logs): Deleted.
425         (MacPort.look_for_new_samples): Deleted.
426         (MacPort.sample_process): Deleted.
427         (MacPort._path_to_helper): Deleted.
428         * Scripts/webkitpy/port/mac_unittest.py:
429         (MacTest.test_default_child_processes): Deleted.
430         * Scripts/webkitpy/port/win.py:
431         (WinPort.look_for_new_samples):
432         (WinPort):
433         (WinPort.sample_process):
434         (WinPort._make_leak_detector):
435         (WinPort.check_for_leaks):
436         (WinPort.print_leaks_summary):
437         (WinPort._path_to_webcore_library):
438
439 2016-08-08  Matt Baker  <mattbaker@apple.com>
440
441         Unreviewed: moved myself to the reviewers list.
442
443         * Scripts/webkitpy/common/config/contributors.json:
444
445 2016-08-08  Chris Dumez  <cdumez@apple.com>
446
447         Update API tests in mac/SetDocumentURI.mm after r204247
448         https://bugs.webkit.org/show_bug.cgi?id=160660
449
450         Reviewed by Alex Christensen.
451
452         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
453         (TestWebKitAPI::TEST):
454
455 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
456
457         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
458         https://bugs.webkit.org/show_bug.cgi?id=159827
459
460         Reviewed by Daniel Bates.
461
462         This change was spurred by a process hang which occurred between tests and did
463         not produce a meaningful crashlog.
464
465         * Scripts/webkitpy/port/driver.py:
466         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
467
468          * Scripts/webkitpy/port/ios.py:
469         (IOSSimulatorPort):
470         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
471         * Scripts/webkitpy/port/mac.py:
472         (MacPort):
473         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
474
475         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
476         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
477
478         * WebKitTestRunner/TestController.h:
479         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
480         * WebKitTestRunner/TestInvocation.cpp:
481         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
482
483 2016-08-07  Dan Bernstein  <mitz@apple.com>
484
485         [Cocoa] Reply block leaks if the remote object doesn’t call it
486         https://bugs.webkit.org/show_bug.cgi?id=160642
487
488         Reviewed by Sam Weinig.
489
490         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
491         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
492         (TEST): Added a test case that checks that the reply block is released even when it’s not
493           called.
494         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
495         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
496           calling the completion handler.
497
498 2016-08-07  Chris Dumez  <cdumez@apple.com>
499
500         Write API test to cover crash fix in r204135
501         https://bugs.webkit.org/show_bug.cgi?id=160587
502
503         Reviewed by Darin Adler.
504
505         Add API test to cover crash fix in r204135. This reproduces the crash
506         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
507         callback.
508
509         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
510         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
511         (TEST):
512
513 2016-08-06  Chris Dumez  <cdumez@apple.com>
514
515         Unreviewed, rolling out r204226.
516
517         Broke some API tests
518
519         Reverted changeset:
520
521         "Write API test to cover crash fix in r204135"
522         https://bugs.webkit.org/show_bug.cgi?id=160587
523         http://trac.webkit.org/changeset/204226
524
525 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
526
527         EWS Style Queue fails to process patches which fails validation
528         https://bugs.webkit.org/show_bug.cgi?id=160632
529
530         Reviewed by Alexey Proskuryakov.
531
532         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
533         (StyleQueueTask.validate): Add more information about validation failure.
534         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
535         * Scripts/webkitpy/tool/commands/queues_unittest.py:
536         (test_non_valid_patch): Add a unit test to test the above code path.
537
538 2016-08-06  Sam Weinig  <sam@webkit.org>
539
540         WTF needs a variant implementation
541         https://bugs.webkit.org/show_bug.cgi?id=160618
542
543         Reviewed by Darin Adler.
544
545         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
546         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
547         Add tests for the variant implementation.
548
549 2016-08-06  Chris Dumez  <cdumez@apple.com>
550
551         Write API test to cover crash fix in r204135
552         https://bugs.webkit.org/show_bug.cgi?id=160587
553
554         Reviewed by Darin Adler.
555
556         Add API test to cover crash fix in r204135. This reproduces the crash
557         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
558         callback.
559
560         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
561         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
562         (TEST):
563
564 2016-08-05  Tim Horton  <timothy_horton@apple.com>
565
566         run-api-tests should use a headed simulator
567         https://bugs.webkit.org/show_bug.cgi?id=160611
568
569         Reviewed by Sam Weinig.
570
571         CADisplayLink doesn't work in a headless simulator, but is
572         vital for the proper functioning of WebKit2 painting on iOS.
573         So, we should not use a headless simulator.
574
575         * Scripts/run-api-tests:
576         Launch a simulator app, don't just boot the simulator.
577
578         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
579         Re-enable a test that works now.
580
581 2016-08-05  Dan Bernstein  <mitz@apple.com>
582
583         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
584         https://bugs.webkit.org/show_bug.cgi?id=160589
585
586         Reviewed by Tim Horton.
587
588         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
589         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
590           blocks, which wasn’t caught because the test wasn’t run correctly.
591         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
592         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
593           added a test that sends over an NSRange.
594         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
595         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
596           handler with the range‘s location and length.
597
598 2016-08-05  Enrica Casucci  <enrica@apple.com>
599
600         Fixing tests failing after r204175.
601
602         Unreviewed.
603
604         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
605
606 2016-08-05  Enrica Casucci  <enrica@apple.com>
607
608         Build fix after 204053.
609
610         Unreviewed.
611
612         * TestWebKitAPI/Configurations/Base.xcconfig:
613         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
614         (-[MockContentFilterEnabler initWithCoder:]):
615         (-[MockContentFilterEnabler dealloc]):
616
617 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
618
619         Print test name in "Last character read from DRT..." error message.
620         https://bugs.webkit.org/show_bug.cgi?id=160559
621
622         Reviewed by Michael Catanzaro.
623
624         * Scripts/webkitpy/port/driver.py:
625         (Driver.run_test):
626         (Driver._read_first_block):
627         (Driver._read_optional_image_block):
628         (Driver._read_block):
629         * Scripts/webkitpy/port/driver_unittest.py:
630         (DriverTest.test_read_block):
631         (DriverTest.test_read_binary_block):
632         (DriverTest.test_read_base64_block):
633
634 2016-08-05  Commit Queue  <commit-queue@webkit.org>
635
636         Unreviewed, rolling out r204123.
637         https://bugs.webkit.org/show_bug.cgi?id=160597
638
639         Caused layout test timeouts on Windows. (Requested by perarne
640         on #webkit).
641
642         Reverted changeset:
643
644         "[Win] Unable to reliably run tests in parallel"
645         https://bugs.webkit.org/show_bug.cgi?id=140914
646         http://trac.webkit.org/changeset/204123
647
648 2016-08-04  Saam Barati  <sbarati@apple.com>
649
650         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
651         https://bugs.webkit.org/show_bug.cgi?id=151241
652
653         Reviewed by Benjamin Poulain.
654
655         * Scripts/run-jsc-stress-tests:
656
657 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
658
659         UI improvements to Flakiness Dashboard.
660         https://bugs.webkit.org/show_bug.cgi?id=153295
661
662         Reviewed by Alexey Proskuryakov.
663
664         * TestResultServer/static-dashboards/flakiness_dashboard.css:
665         (td.options-container): Center text in most fields.
666         * TestResultServer/static-dashboards/flakiness_dashboard.js:
667         (createBugHTML): Text/Grammar updates.
668         (tableHeaders): Ditto.
669         (htmlForSingleTestRow): Ditto.
670         (headerForTestTableHtml): Ditto.
671         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
672         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
673
674 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
675
676         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
677         https://bugs.webkit.org/show_bug.cgi?id=160518
678
679         Reviewed by Michael Catanzaro.
680
681         * Scripts/webkitpy/thirdparty/__init__.py:
682         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
683         * gtk/install-dependencies:
684
685 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
686
687         Optimize bot watcher's dashboard a little
688         https://bugs.webkit.org/show_bug.cgi?id=160515
689         rdar://problem/26096900
690
691         Reviewed by Lucas Forschler.
692
693         Made re-sorting after loading an iteration more efficient.
694
695         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
696         (BuildbotIteration.prototype._updateWithData):
697         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
698         (BuildbotQueue.prototype.updateIterationPosition):
699
700 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
701
702         [Win] Unable to reliably run tests in parallel
703         https://bugs.webkit.org/show_bug.cgi?id=140914
704
705         Reviewed by Brent Fulgham.
706
707         The cygpath utility function can fail badly when running with multiple DumpRenderTree
708         processes. We can use string replacement to convert the Cygwin path to a Windows path
709         instead.
710  
711         * Scripts/webkitpy/common/system/path.py:
712         (cygpathFast):
713         * Scripts/webkitpy/port/driver.py:
714         (Driver._command_from_driver_input):
715
716 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
717
718         Document instructions for increasing process and file limits
719         https://bugs.webkit.org/show_bug.cgi?id=160528
720         rdar://problem/24777576
721
722         Reviewed by Alexey Proskuryakov.
723
724         * Scripts/webkitpy/port/ios.py:
725         (IOSSimulatorPort.default_child_processes):
726
727 2016-08-03  Anders Carlsson  <andersca@apple.com>
728
729         Remove the Objective-C bindings generator
730         https://bugs.webkit.org/show_bug.cgi?id=160526
731
732         Reviewed by Sam Weinig.
733
734         * Scripts/run-bindings-tests:
735         Update test.
736
737 2016-08-03  Tim Horton  <timothy_horton@apple.com>
738
739         Revise a TestWebKitAPI comment to mention the actual underlying problem
740
741         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
742         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
743
744 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
745
746         Benchmark test content-animation timeouts always
747         https://bugs.webkit.org/show_bug.cgi?id=160057
748
749         Reviewed by Simon Fraser.
750
751         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
752         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
753         (start):
754
755 2016-08-02  Nan Wang  <n_wang@apple.com>
756
757         AX: Simulated touch events are not working on iOS
758         https://bugs.webkit.org/show_bug.cgi?id=160395
759         <rdar://problem/27633597>
760
761         Reviewed by Chris Fleizach.
762
763         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
764         (WTR::AccessibilityUIElement::press):
765         (WTR::AccessibilityUIElement::setSelectedChild):
766
767 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
768
769         run-javascriptcore-tests should accept multiple --extra-tests
770         https://bugs.webkit.org/show_bug.cgi?id=160486
771
772         Reviewed by Saam Barati.
773         
774         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
775         test suites. This does it by using GetOpt::Long's array support.
776
777         * Scripts/run-javascriptcore-tests:
778         (runJSCStressTests):
779
780 2016-08-02  Enrica Casucci  <enrica@apple.com>
781
782         Allow building with content filtering disabled.
783         https://bugs.webkit.org/show_bug.cgi?id=160454
784
785         Reviewed by Simon Fraser.
786
787         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
788
789 2016-08-02  Brady Eidson  <beidson@apple.com>
790
791         Removing IndexedDB WebsiteData can fail for some users.
792         https://bugs.webkit.org/show_bug.cgi?id=160463
793
794         Reviewed by Alex Christensen.
795
796         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
797
798 2016-08-01  Alex Christensen  <achristensen@webkit.org>
799
800         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
801         https://bugs.webkit.org/show_bug.cgi?id=160437
802         <rdar://problem/27578272>
803
804         Reviewed by Brady Eidson.
805
806         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
807         (-[DownloadDelegate _download:didReceiveResponse:]):
808         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
809         (runTest):
810         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
811
812 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
813
814         [Tools] The GDB backtrace report tool don't checks the gdb return code.
815         https://bugs.webkit.org/show_bug.cgi?id=160414
816
817         Reviewed by Michael Catanzaro.
818
819         * Scripts/webkitpy/port/linux_get_crash_log.py:
820         (GDBCrashLogGenerator._wait_for_corefile):
821
822 2016-08-01  Youenn Fablet  <youenn@apple.com>
823
824         Make wpt server generate its certificates in layout test results folder
825         https://bugs.webkit.org/show_bug.cgi?id=160422
826
827         Reviewed by Chris Dumez.
828
829         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
830         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
831
832 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
833
834         Function Call on NULL Object
835         https://bugs.webkit.org/show_bug.cgi?id=160325
836
837         Reviewed by Darin Adler.
838
839         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
840         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
841         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
842
843 2016-08-01  Keith Miller  <keith_miller@apple.com>
844
845         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
846         https://bugs.webkit.org/show_bug.cgi?id=160372
847
848         Rubber stamped by Geoffrey Garen.
849
850         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
851         a new top level directory, JSTests. Having the tests in the Source directory
852         was both confusing an inconvenient for people that just want to checkout the
853         source code of WebKit. Since there is no other obvious place to put all the
854         JavaScript tests a new top level directory seemed the most sensible.
855
856         * Scripts/import-test262-tests:
857         * Scripts/run-javascriptcore-tests:
858         * Scripts/update-javascriptcore-test-res:
859
860 2016-07-31  Nan Wang  <n_wang@apple.com>
861
862         AX: Add a check for touch event listener on iOS accessibility object
863         https://bugs.webkit.org/show_bug.cgi?id=160388
864
865         Reviewed by Chris Fleizach.
866
867         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
868         (AccessibilityUIElement::boolAttributeValue):
869         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
870         (WTR::AccessibilityUIElement::boolAttributeValue):
871
872 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
873
874         Unreviewed: add myself to the reviewers list.
875
876         * Scripts/webkitpy/common/config/contributors.json:
877
878 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
879
880         Undo r203939, and copy over a rule that clips the logos.
881
882         Sierra wasn't the only logo without transparency.
883
884         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
885         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
886         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
887
888 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
889
890         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
891         https://bugs.webkit.org/show_bug.cgi?id=160377
892
893         Reviewed by Brian Weinstein.
894
895         Update assets to remove the white background and use a transparent background instead.
896
897         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
898         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
899
900 2016-07-29  David Kilzer  <ddkilzer@apple.com>
901
902         Ignore most check-webkit-style checks for ANGLE project
903         <https://webkit.org/b/160333>
904
905         Reviewed by Daniel Bates.
906
907         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
908         - No tabs.
909         - No spaces at the end of lines.
910         - No carriage returns (DOS line endings).
911
912 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
913
914         Media controls are not displayed for some autoplaying videos at certain browser dimensions
915         https://bugs.webkit.org/show_bug.cgi?id=160360
916         <rdar://problem/27179484>
917
918         Reviewed by Myles C. Maxfield.
919
920         Adds two tests verifying that videos may be considered main content as long as they
921         are large enough and cover a majority of the mainframe's viewport.
922
923         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
924         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
925         (TestWebKitAPI::TEST):
926         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
927         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
928
929 2016-07-29  Mark Lam  <mark.lam@apple.com>
930
931         Gardening: removed unused variable.
932
933         Not reviewed.
934
935         * TestWebKitAPI/Tests/WTF/StringView.cpp:
936         (TestWebKitAPI::TEST):
937
938 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
939
940         Add TestWebKitAPI support for interacting with media controls
941         https://bugs.webkit.org/show_bug.cgi?id=160342
942         <rdar://problem/27610246>
943
944         Reviewed by Beth Dakin.
945
946         Adds support for testing interaction with some media controls, as well as a basic test
947         verifying that media control teardown after interaction does not result in a crash.
948
949         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
950         (-[WKWebView mouseDownAtPoint:]):
951         (-[WKWebView performAfterLoading:]):
952         (TestWebKitAPI::TEST):
953
954 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
955
956         Crash Log Clobbering on Unbound Crashes
957         https://bugs.webkit.org/show_bug.cgi?id=160198
958         <rdar://problem/27472618>
959
960         Reviewed by Alexey Proskuryakov.
961
962         * Scripts/webkitpy/common/system/crashlogs.py:
963         (CrashLogs): Fix header order.
964         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
965         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
966
967 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
968
969         Update for contributors.json
970         https://bugs.webkit.org/show_bug.cgi?id=160294
971
972         * Scripts/webkitpy/common/config/contributors.json:
973
974 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
975
976         Remove deprecated SPI for video inline / fullscreen controls
977         https://bugs.webkit.org/show_bug.cgi?id=160318
978
979         Reviewed by Tim Horton.
980
981         * DumpRenderTree/mac/DumpRenderTree.mm:
982         (setDefaultsToConsistentValuesForTesting): Deleted.
983         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
984         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
985         * WebKitTestRunner/TestController.cpp:
986         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
987         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
988         (WTR::initializeWebViewConfiguration): Deleted.
989
990 2016-07-28  Daniel Bates  <dabates@apple.com>
991
992         [iOS] TestWebKitAPI bundle targets are not code signed
993         https://bugs.webkit.org/show_bug.cgi?id=160328
994         <rdar://problem/27409246>
995
996         Reviewed by Andy Estes.
997
998         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
999         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
1000         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
1001
1002         * TestWebKitAPI/Configurations/Base.xcconfig:
1003
1004 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1005
1006         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
1007
1008         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1009         (animatedResizeWebView):
1010         (TEST):
1011         This test times out only when run in the WebKit Testing simulator environment,
1012         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
1013
1014 2016-07-28  Tim Horton  <timothy_horton@apple.com>
1015
1016         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
1017         https://bugs.webkit.org/show_bug.cgi?id=160289
1018         <rdar://problem/27553464>
1019
1020         Reviewed by Simon Fraser.
1021
1022         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1023         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1024         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
1025         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
1026         (-[AnimatedResizeWebView _endAnimatedResize]):
1027         (animatedResizeWebView):
1028         (TEST):
1029         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
1030         Add two tests that ensure that hidden-content and animated resizes
1031         don't cause unnecessary synchronous waits. Only the hidden-content
1032         one fails before my patch, but it seemed reasonable to add both anyway.
1033
1034 2016-07-28  David Kilzer  <ddkilzer@apple.com>
1035
1036         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
1037         <https://webkit.org/b/83342>
1038
1039         Reviewed by Ryosuke Niwa.
1040
1041         * Scripts/webkitpy/common/checkout/scm/git.py:
1042         (Git.revisions_changing_file): Remove code to raise an exception
1043         when the file doesn't exist.  If a file was moved or renamed,
1044         then this caused the script to terminate, which was very
1045         frustrating when you wanted a list of reviewers.
1046         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1047         (SCMTest._shared_test_revisions_changing_file): Update test
1048         expectation to return an empty list of revisions.
1049         (test_create_patch_is_full_patch): Drive-by fix when running all
1050         webkitpy tests (including scm tests).
1051         * Scripts/webkitpy/common/checkout/scm/svn.py:
1052         (SVN.revisions_changing_file): Catch ScriptError exceptions and
1053         return an empty array of revisions if this occurs.
1054
1055 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
1056
1057         EWS error message "Error: * did not process patch" should include explanation
1058         https://bugs.webkit.org/show_bug.cgi?id=159903
1059         <rdar://problem/27410788>
1060
1061         Reviewed by Alexey Proskuryakov.
1062
1063         * QueueStatusServer/handlers/statusbubble.py:
1064         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
1065         is not processed.
1066         * QueueStatusServer/handlers/processingtimesjson.py:
1067         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
1068         of the code.
1069         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1070         (CommitQueueTask.validate): Add more information about validation failure.
1071         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
1072         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1073         (EarlyWarningSystemTask.validate): Add more information about validation failure.
1074         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
1075         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1076         (PatchIsNotValid.__init__): Add the failure_message argument.
1077         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1078         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
1079         failure details.
1080         * Scripts/webkitpy/tool/commands/queues.py:
1081         (CommitQueue.process_work_item): Same.
1082         (StyleQueue.review_patch): Same.
1083         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1084         (test_non_valid_patch): Updated test-cases messages to match the above changes.
1085
1086 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
1087
1088         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
1089         https://bugs.webkit.org/show_bug.cgi?id=160262
1090
1091         Reviewed by Daniel Bates.
1092
1093         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1094         (-[LTRelayController installApp]):
1095
1096 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
1097
1098         Disable WebCoreNSURLSessionTest API tests on ios-simulator
1099         https://bugs.webkit.org/show_bug.cgi?id=160225
1100
1101         Reviewed by Alexey Proskuryakov.
1102
1103         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1104
1105 2016-07-27  Miguel Gomez  <magomez@igalia.com>
1106
1107         [GTK] Fix some video/canvas tests that should be passing
1108         https://bugs.webkit.org/show_bug.cgi?id=160023
1109
1110         Reviewed by Carlos Garcia Campos.
1111
1112         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
1113         EFL or GTK platforms.
1114
1115         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1116         (WTR::TestController::platformConfigureViewForTest):
1117         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1118         (WTR::TestController::platformConfigureViewForTest):
1119
1120 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1121
1122         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
1123         https://bugs.webkit.org/show_bug.cgi?id=160247
1124
1125         Reviewed by Michael Catanzaro.
1126
1127         * BuildSlaveSupport/built-product-archive:
1128         (createZip):
1129         (dirContainsdwo):
1130         (archiveBuiltProduct):
1131
1132 2016-07-26  Alex Christensen  <achristensen@webkit.org>
1133
1134         Fix tests after r203743.
1135         https://bugs.webkit.org/show_bug.cgi?id=156947
1136
1137         * WebKitTestRunner/TestController.cpp:
1138         (WTR::TestController::resetStateToConsistentValues):
1139         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
1140
1141 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
1142
1143         [iPhone] Playing a video on tudou.com plays only sound, no video
1144         https://bugs.webkit.org/show_bug.cgi?id=160178
1145         <rdar://problem/27535468>
1146
1147         Reviewed by Dan Bernstein.
1148
1149         * DumpRenderTree/mac/DumpRenderTree.mm:
1150         (setDefaultsToConsistentValuesForTesting):
1151         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1152         (RequiresUserActionForPlaybackTest::SetUp):
1153         * WebKitTestRunner/TestController.cpp:
1154         (WTR::TestController::resetPreferencesToConsistentValues):
1155         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1156         (WTR::initializeWebViewConfiguration):
1157
1158 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
1159
1160         Allow LOG macros to be used outside the namespace, and other logging cleanup
1161         https://bugs.webkit.org/show_bug.cgi?id=160216
1162
1163         Reviewed by Anders Carlsson.
1164         
1165         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
1166
1167         * DumpRenderTree/TestRunner.cpp:
1168         * DumpRenderTree/mac/DumpRenderTree.mm:
1169         (resetWebViewToConsistentStateBeforeTesting):
1170
1171 2016-07-26  David Kilzer <ddkilzer@apple.com>
1172
1173         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
1174         https://bugs.webkit.org/show_bug.cgi?id=156947
1175         <rdar://problem/23325160>
1176
1177         Reviewed by Alex Christensen.
1178
1179         * DumpRenderTree/TestRunner.cpp:
1180         (TestRunner::TestRunner):
1181         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
1182         * DumpRenderTree/TestRunner.h:
1183         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1184         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1185         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1186         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1187         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1188         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1189         (WTR::TestRunner::queueNonLoadingScript):
1190         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1191         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1192         * WebKitTestRunner/TestController.cpp:
1193         (WTR::TestController::didReceiveAuthenticationChallenge):
1194         * WebKitTestRunner/TestController.h:
1195         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1196         * WebKitTestRunner/TestInvocation.cpp:
1197         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1198         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
1199
1200 2016-07-26  David Kilzer  <ddkilzer@apple.com>
1201
1202         check-for-exit-time-destructors should be usable outside Xcode
1203         <https://webkit.org/b/160195>
1204
1205         Reviewed by Darin Adler.
1206
1207         * Scripts/check-for-exit-time-destructors: Update to parse
1208         -h|--help switch, or to take one argument to a binary to check
1209         for exit time destructors on the command-line.  The clang
1210         compiler will find these at compile-time with the
1211         -Wexit-time-destructors switch, but this script will check for
1212         them after-the-fact.
1213
1214 2016-07-26  Lucas Forschler  <lforschler@apple.com>
1215
1216         Test svn.webkit.org functionality after maintenance.
1217
1218 2016-07-25  Brady Eidson  <beidson@apple.com>
1219
1220         Modern IDB: Make sure IndexedDB works from file:// url documents by default
1221         https://bugs.webkit.org/show_bug.cgi?id=153783
1222
1223         Reviewed by Alex Christensen.
1224
1225         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
1226         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
1227         
1228         As of https://trac.webkit.org/changeset/203695 this is no longer required.
1229         
1230         Change the relevant API tests to make sure this continues to be no longer required.
1231
1232         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1233         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1234         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1235         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1236         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
1237         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1238
1239 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1240
1241         Media controls should not be displayed for a video until it starts playing
1242         https://bugs.webkit.org/show_bug.cgi?id=160092
1243         <rdar://problem/26986673>
1244
1245         Reviewed by Beth Dakin.
1246
1247         Verify that multiple videos do or don't show the media controller depending on whether videos
1248         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
1249         passing because we were always showing media controls for large videos with audio, even if they
1250         had not played back yet. This change ensures that large videos with audio show media controls
1251         only after they begin to play back, and not by virtue of being large enough for main content.
1252
1253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1254         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1255         (TestWebKitAPI::TEST):
1256         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
1257         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
1258         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
1259
1260 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1261
1262         Media controls on apple.com don't disappear when movie finishes playing
1263         https://bugs.webkit.org/show_bug.cgi?id=160068
1264         <rdar://problem/26668526>
1265
1266         Reviewed by Darin Adler.
1267
1268         Adds new API tests. Please see WebCore ChangeLog for more details.
1269
1270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1271         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1272         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
1273         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
1274         (TestWebKitAPI::TEST):
1275         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
1276         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
1277         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
1278         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
1279         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
1280
1281 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1282
1283         Unreviewed, fix test-webkitpy after r203674.
1284
1285         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1286         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1287
1288 2016-07-24  Philippe Normand  <pnormand@igalia.com>
1289
1290         Unreviewed, forgot to commit this file in r203674.
1291
1292         * Scripts/process-linux-coredump: Added.
1293         (main):
1294
1295 2016-07-25  Philippe Normand  <pnormand@igalia.com>
1296
1297         Improve GDB backtrace generation for GTK/EFL
1298         https://bugs.webkit.org/show_bug.cgi?id=128928
1299
1300         Reviewed by Carlos Garcia Campos.
1301
1302         The PID of the crashed process is now correctly supplied to the
1303         crash log reporter. The kernel core_pattern needs to be updated
1304         after this change to something like:
1305
1306         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
1307
1308         * Scripts/process-linux-coredump: Added.
1309         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
1310         * Scripts/webkitpy/port/efl.py:
1311         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
1312         * Scripts/webkitpy/port/gtk.py:
1313         (GtkPort._get_crash_log): Ditto.
1314         * Scripts/webkitpy/port/linux_get_crash_log.py:
1315         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
1316         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
1317         (GDBCrashLogGenerator): Deleted.
1318         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1319         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
1320         * WebKitTestRunner/TestController.cpp:
1321         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
1322         (WTR::TestController::databaseProcessDidCrash): Ditto.
1323         (WTR::TestController::processDidCrash): Ditto.
1324
1325 2016-07-23  Youenn Fablet  <youenn@apple.com>
1326
1327         WPT stash server should be kept running when launching wpt server
1328         https://bugs.webkit.org/show_bug.cgi?id=160052
1329
1330         Reviewed by Sam Weinig.
1331
1332         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1333         (main): waiting to read stdin while stash server is started.
1334
1335 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1336
1337         Media controls should be displayed for media in media documents
1338         https://bugs.webkit.org/show_bug.cgi?id=160104
1339         <rdar://problem/27438936>
1340
1341         Reviewed by Myles C. Maxfield.
1342
1343         Verifies that even a small video with audio in a media document gets media controls.
1344
1345         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1346         (TestWebKitAPI::TEST):
1347
1348 2016-07-22  Michael Saboff  <msaboff@apple.com>
1349
1350         REGRESSION(203616): no FTL testing was inadvertently removed
1351         https://bugs.webkit.org/show_bug.cgi?id=160100
1352
1353         Rubber-stamped by Filip Pizlo.
1354
1355         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
1356         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
1357         logic for the runLayout and runNoisy variants to match the run test logic,
1358         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
1359         enabled platforms.
1360
1361         * Scripts/run-jsc-stress-tests:
1362
1363 2016-07-22  Brady Eidson  <beidson@apple.com>
1364
1365         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
1366         https://bugs.webkit.org/show_bug.cgi?id=160089
1367
1368         Reviewed by Darin Adler.
1369
1370         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1371         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
1372         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
1373
1374 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
1375
1376         [GTK] Improved exclusion patterns in make-dist.py manifest.
1377         https://bugs.webkit.org/show_bug.cgi?id=160094
1378
1379         Reviewed by Michael Catanzaro.
1380
1381         * gtk/manifest.txt.in:
1382         Exclude Platform*.cmake files for more ports.
1383         Removed obsolete .gyp and .pro.user patterns.
1384         Exclude 'Configurations' and 'spi' directories.
1385         Exclude CMakeLists.txt.user (Qt Creator IDE).
1386
1387 2016-07-22  Michael Saboff  <msaboff@apple.com>
1388
1389         Don't run FTL related JSC stress tests on non-FTL platforms
1390         https://bugs.webkit.org/show_bug.cgi?id=160033
1391
1392         Reviewed by Mark Lam.
1393
1394         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
1395         Refactored several of the runXXX test methods to always runXXXDefault and made those
1396         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
1397         doesn't cause a problem.
1398
1399         * Scripts/run-jsc-stress-tests:
1400
1401 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
1402
1403         IWebView::mainFrame crashes if called after IWebView::close
1404         https://bugs.webkit.org/show_bug.cgi?id=32868
1405
1406         Reviewed by Brent Fulgham.
1407
1408         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1409         (TestWebKitAPI::TEST_F): Added test.
1410
1411 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1412
1413         [GTK] Enable threaded compositor by default
1414         https://bugs.webkit.org/show_bug.cgi?id=160079
1415
1416         Reviewed by Žan Doberšek.
1417
1418         * Scripts/webkitperl/FeatureList.pm:
1419
1420 2016-07-22  Youenn Fablet  <youenn@apple.com>
1421
1422         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
1423         https://bugs.webkit.org/show_bug.cgi?id=159921
1424
1425         Reviewed by Brian Burg.
1426
1427         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
1428
1429         * Scripts/webkitpy/codegen/main.py:
1430         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
1431         (BuiltinsGeneratorTests):
1432         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
1433         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
1434         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
1435         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
1436
1437 2016-07-21  Dan Bernstein  <mitz@apple.com>
1438
1439         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
1440         https://bugs.webkit.org/show_bug.cgi?id=160072
1441
1442         Reviewed by Andy Estes.
1443
1444         * Scripts/webkitdirs.pm:
1445         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
1446           for old Xcode versions.
1447         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
1448           to readXcodeUserDefault.
1449         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
1450           debugger.
1451         (determineDebugger): Ditto.
1452         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
1453           7.0.
1454         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
1455           switches.
1456         (execMacWebKitAppForDebugging): Removed support for GDB.
1457
1458 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1459
1460         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
1461         https://bugs.webkit.org/show_bug.cgi?id=160066
1462
1463         Reviewed by Dean Jackson.
1464
1465         * DumpRenderTree/mac/DumpRenderTree.mm:
1466         (setDefaultsToConsistentValuesForTesting): Deleted.
1467         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1468         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
1469         * WebKitTestRunner/TestController.cpp:
1470         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
1471         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1472         (WTR::initializeWebViewConfiguration): Deleted.
1473
1474 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
1475
1476         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
1477         https://bugs.webkit.org/show_bug.cgi?id=159980
1478         rdar://problem/27450825
1479
1480         Reviewed by Dan Bernstein.
1481
1482         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1483         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
1484         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
1485         when our delegate has hit -dealloc.
1486         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
1487         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
1488         will not be messaged.
1489
1490 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1491
1492         Follow-up patch to r203520
1493         https://bugs.webkit.org/show_bug.cgi?id=159967
1494         <rdar://problem/26964090>
1495
1496         Unreviewed.
1497
1498         * DumpRenderTree/mac/DumpRenderTree.mm:
1499         (setDefaultsToConsistentValuesForTesting):
1500         * WebKitTestRunner/TestController.cpp:
1501         (WTR::TestController::resetPreferencesToConsistentValues):
1502
1503 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
1504
1505         [iPhone] Playing a video on tudou.com plays only sound, no video
1506         https://bugs.webkit.org/show_bug.cgi?id=159967
1507         <rdar://problem/26964090>
1508
1509         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
1510
1511         Migrate tests to use new SPI.
1512
1513         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1514         (RequiresUserActionForPlaybackTest::SetUp):
1515         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1516         (WTR::initializeWebViewConfiguration):
1517
1518 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
1519
1520         Clarify testing mode names in run-jsc-stress-tests
1521         https://bugs.webkit.org/show_bug.cgi?id=160021
1522
1523         Reviewed by Mark Lam.
1524
1525         Default should mean really default, not default with disabled FTL, renamed
1526         - runMozillaTestDefault to runMozillaTestNoFTL
1527         - runMozillaTestDefaultFTL to runMozillaTestDefault
1528         - runDefault to runNoFTL
1529         - runDefaultFTL to runDefault
1530         - runLayoutTestDefault to runLayoutTestNoFTL
1531         - runLayoutTestDefaultFTL to runLayoutTestDefault
1532         - runNoisyTestDefault to runNoisyTestNoFTL
1533         - runNoisyTestDefaultFTL to runNoisyTestDefault
1534
1535         * Scripts/run-jsc-stress-tests:
1536
1537 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
1538
1539         WebBackForwardList's currentIndex could get out of bounds when filtering items.
1540         https://bugs.webkit.org/show_bug.cgi?id=159986
1541
1542         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
1543         to 0.
1544
1545         Reviewed by Dan Bernstein.
1546
1547         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1548         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
1549         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
1550         (TEST):
1551
1552 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1553
1554         [GTK] Web view background colors don't work in accelerated compositing mode
1555         https://bugs.webkit.org/show_bug.cgi?id=159455
1556
1557         Reviewed by Michael Catanzaro.
1558
1559         Set always RGBA visual to the view widget when setting a background color.
1560
1561         * MiniBrowser/gtk/BrowserWindow.c:
1562         (browser_window_set_background_color):
1563
1564 2016-07-20  Youenn Fablet  <youenn@apple.com>
1565
1566         Bots should run built-ins generator tests
1567         https://bugs.webkit.org/show_bug.cgi?id=159971
1568
1569         Reviewed by Alexey Proskuryakov.
1570
1571         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1572         (RunBuiltinsTests): New step to run built-in generator tests.
1573         (TestFactory.__init__): Adding an additional step for bultin generator tests.
1574         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
1575         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
1576
1577 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1578
1579         Revert temporary fix r203417
1580         https://bugs.webkit.org/show_bug.cgi?id=160001
1581
1582         Reviewed by Alexey Proskuryakov.
1583
1584         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
1585
1586 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
1587
1588         REGRESSION(r148588): ews classes might get garbage collected
1589         https://bugs.webkit.org/show_bug.cgi?id=159990
1590
1591         Reviewed by Ryosuke Niwa.
1592
1593         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
1594         in a variable so that they do not get garbage collected.
1595
1596 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
1597
1598         Add API test for layout constraints after exit fullscreen
1599         https://bugs.webkit.org/show_bug.cgi?id=159900
1600
1601         Reviewed by Jon Lee.
1602
1603         Added Fullscreen.LaytoutConstraints API test. 
1604         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
1605
1606         This test compares layout constraints on the web view before and after fullscreen to make sure 
1607         they are preserved.
1608
1609         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
1610         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
1611         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1612         (TestWebKitAPI::TEST):
1613
1614 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
1615
1616         Disable two failing API tests.
1617
1618         Unreviewed test gardening.
1619
1620         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
1621         (TestWebKitAPI::TEST):
1622
1623 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1624
1625         Unreviewed iOS build fix.
1626
1627         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
1628
1629 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1630
1631         Media controls don't appear when pausing a small autoplaying video
1632         https://bugs.webkit.org/show_bug.cgi?id=159972
1633         <rdar://problem/27180657>
1634
1635         Reviewed by Beth Dakin.
1636
1637         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
1638         for simulating basic user interaction in VideoControlsManager.
1639
1640         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1641         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1642         (-[WKWebView mouseDownAtPoint:]):
1643         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
1644         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
1645         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
1646         (TestWebKitAPI::TEST):
1647         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
1648
1649 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
1650
1651         [Win] MathML fonts are not found.
1652         https://bugs.webkit.org/show_bug.cgi?id=159920
1653
1654         Reviewed by Alex Christensen.
1655
1656         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
1657         for a specific registry key value.
1658
1659         * Scripts/webkitdirs.pm:
1660         (fontExists):
1661
1662 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
1663
1664         Improve prepare-ChangeLog for @media blocks
1665         https://bugs.webkit.org/show_bug.cgi?id=159907
1666
1667         Reviewed by Timothy Hatcher.
1668
1669         * Scripts/prepare-ChangeLog:
1670         (get_selector_line_ranges_for_css):
1671         Get a range for @media blocks just like a selector.
1672             Start Line = line with '{'
1673             End line = line with '}'
1674             Name = "@media ..."
1675
1676         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
1677         Improved error messages for unbalanced portions.
1678
1679         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
1680         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
1681         (.media-query::before):
1682         (@media only screen and (max-width: 980px)):
1683         (.media-query a):
1684         (@media (-webkit-min-device-pixel-ratio: 2)):
1685         (.both a):
1686         (.both b):
1687         (.media-query b):
1688         (.media-query::after):
1689
1690 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
1691
1692         Fix expectedFailErrorHandler in run-jsc-stress-tests
1693         https://bugs.webkit.org/show_bug.cgi?id=159811
1694
1695         Reviewed by Yusuke Suzuki.
1696
1697         * Scripts/run-jsc-stress-tests:
1698
1699 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
1700
1701         Unreviewed Mac cmake buildfix after r203426. Just for fun.
1702
1703         * TestWebKitAPI/PlatformMac.cmake:
1704
1705 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
1706
1707         The default testing mode should not involve disabling the FTL JIT
1708         https://bugs.webkit.org/show_bug.cgi?id=159929
1709
1710         Rubber stamped by Mark Lam and Saam Barati.
1711         
1712         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
1713         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
1714         FTL was not the default. You had to enable it with an option.
1715         
1716         For some reason we have kept this arrangement even though the FTL JIT is now the default on
1717         all of the major ports. This has become a serious pain. For example, it's useful to be able
1718         to say that a test should only run in the default config that is representative of what a
1719         normal user would see if they ran JSC. Clearly, this would be a config that does not
1720         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
1721         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
1722         
1723         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
1724         try to fix it, because:
1725         
1726         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
1727           have the FTL enabled never run any tests that explicitly disable the FTL, since that
1728           doesn't do anything. The code is not really structured to allow this.
1729         
1730         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
1731           disabled in testing. On the other hand there are already build bots that do FTL tests
1732           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
1733           preserving this broken feature, we should create something that (a) acknowledges the fact
1734           that the FTL is the default on those platforms that support it and (b) avoids running
1735           no-ftl tests on precisely those platforms that don't have FTL.
1736         
1737         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
1738           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
1739           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
1740           pretending that the FTL JIT is not the default just because some bots used that as an
1741           optimization.
1742         
1743         This change allows me to speed up some debug tests and paint some bots green.
1744
1745         * Scripts/run-javascriptcore-tests:
1746         (runJSCStressTests):
1747         * Scripts/run-jsc-stress-tests:
1748
1749 2016-07-19  Alex Christensen  <achristensen@webkit.org>
1750
1751         Fix API test after r203426.
1752         https://bugs.webkit.org/show_bug.cgi?id=159949
1753
1754         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1755         (TEST):
1756         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
1757         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
1758
1759 2016-07-19  Andy Estes  <aestes@apple.com>
1760
1761         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
1762         https://bugs.webkit.org/show_bug.cgi?id=159956
1763
1764         Reviewed by Dan Bernstein.
1765
1766         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
1767         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1768         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
1769         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
1770
1771 2016-07-19  Alex Christensen  <achristensen@webkit.org>
1772
1773         Add regression test for r203392
1774         https://bugs.webkit.org/show_bug.cgi?id=159949
1775
1776         Reviewed by Brady Eidson.
1777
1778         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1779         (fileSize):
1780         (swizzledBundleIdentifierWebBookmarksD):
1781         (defaultApplicationCacheDirectory):
1782         (TEST):
1783         (swizzledBundleIdentifierMobileSafari): Deleted.
1784         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
1785         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
1786         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
1787
1788 2016-07-19  Alex Christensen  <achristensen@webkit.org>
1789
1790         Add regression test for r203392
1791         https://bugs.webkit.org/show_bug.cgi?id=159949
1792
1793         Reviewed by Brady Eidson.
1794
1795         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1796         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
1797         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
1798         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
1799         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1800         (TEST):
1801         (fileSize):
1802         (swizzledBundleIdentifierMobileSafari):
1803         (swizzledBundleIdentifierWebBookmarksD):
1804         (defaultApplicationCacheDirectory):
1805         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
1806         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
1807         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
1808         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
1809
1810 2016-07-19  Keith Miller  <keith_miller@apple.com>
1811
1812         Test262 should have a file with the revision and url
1813         https://bugs.webkit.org/show_bug.cgi?id=159937
1814
1815         Reviewed by Mark Lam.
1816
1817         The import script should update the information from
1818         the path to the test262 repository it gets.
1819
1820         * Scripts/import-test262-tests:
1821
1822 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
1823
1824         Temporary workaround for iOS EWS failing after the fix for bug 159539.
1825         To be deleted once the root cause is found and addressed.
1826
1827         * EWSTools/start-queue-mac.sh:
1828
1829 2016-07-19  Frederic Wang  <fwang@igalia.com>
1830
1831         [win] Fixup the register name for STIX Math and Latin Modern Math
1832
1833         Unreviewed follow-up of r203406
1834
1835         * Scripts/webkitdirs.pm:
1836         (checkInstalledTools):
1837
1838 2016-07-19  Frederic Wang  <fwang@igalia.com>
1839
1840         [win] Update the list of MathML fonts
1841         https://bugs.webkit.org/show_bug.cgi?id=156838
1842
1843         The set of recommended math fonts is now described at
1844         https://trac.webkit.org/wiki/MathML/Fonts
1845         We update the Perl script to use the latest list of fonts.
1846
1847         Reviewed by Brent Fulgham.
1848
1849         * Scripts/webkitdirs.pm:
1850         (checkInstalledTools):
1851
1852 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
1853
1854         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
1855         https://bugs.webkit.org/show_bug.cgi?id=159342
1856
1857         Reviewed by Darin Adler.
1858
1859         Implement required functions in event sender.
1860
1861         * DumpRenderTree/PlatformWin.cmake:
1862         * DumpRenderTree/win/EventSender.cpp:
1863         (monitorWheelEvents): Added.
1864         (callAfterScrollingCompletes): Added.
1865
1866 2016-07-19  Youenn Fablet  <youenn@apple.com>
1867
1868         Add new aliases to http test server
1869         https://bugs.webkit.org/show_bug.cgi?id=159878
1870
1871         Reviewed by Darin Adler.
1872
1873         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
1874         Adding explicitly these links to perl script.
1875         Extracting default alias in an aliases.json file.
1876         Reading that file from python scripts to initialize aliases from that file.
1877
1878         Python script changes covered by unit tests and changed layout test.
1879
1880         * Scripts/webkitperl/httpd.pm:
1881         (getDefaultConfigForTestDirectory): Adding 3 new aliases
1882         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
1883         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1884         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
1885         Adding -c directives for each alias.
1886         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1887         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
1888         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1889         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
1890         Adding alias directive for each alias.
1891         (Lighttpd._prepare_config):
1892         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1893         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
1894         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
1895         layout tests directory.
1896         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1897         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
1898         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
1899
1900 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
1901
1902         EWS console logs doesn't go to log file
1903         https://bugs.webkit.org/show_bug.cgi?id=159539
1904         <rdar://problem/24464570>
1905
1906         Reviewed by David Kilzer.
1907
1908         * Scripts/webkitpy/common/system/logutils.py:
1909         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
1910         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
1911         to filesystem. It also supports passing MockFilesystem.
1912         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
1913         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
1914         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1915         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
1916         (_test_ews): Same.
1917         * Scripts/webkitpy/tool/commands/queues.py:
1918         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
1919         (AbstractQueue._log_directory): Using filesystem object instead of os.
1920         (AbstractQueue.queue_log_path): Same.
1921         (AbstractQueue.__init__): Passed host parameter.
1922         (PatchProcessingQueue.__init__): Same.
1923         (CommitQueue.__init__): Same.
1924         (AbstractReviewQueue.__init__): Same.
1925         (StyleQueue.__init__): Same.
1926         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1927         (TestCommitQueue): Passed MockHost() as host.
1928         (TestCommitQueue.__init__): Same.
1929         (TestQueue.__init__): Same.
1930         (TestReviewQueue.__init__): Same.
1931         (TestFeederQueue.__init__): Same.
1932         (AbstractPatchQueueTest.test_next_patch): Same.
1933         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1934         (test_commit_queue_failure): Same.
1935         (MockCommitQueueTask.results_from_patch_test_run): Same.
1936         (test_rollout_lands): Same.
1937         (test_non_valid_patch): Same.
1938         (test_auto_retry): Same.
1939         (test_style_queue_with_watch_list_exception): Same.
1940
1941 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
1942
1943         WTF::Lock should be fair eventually
1944         https://bugs.webkit.org/show_bug.cgi?id=159384
1945
1946         Reviewed by Geoffrey Garen.
1947
1948         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1949
1950 2016-07-17  Sam Weinig  <sam@webkit.org>
1951
1952         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
1953         <rdar://problem/26554137>
1954         https://bugs.webkit.org/show_bug.cgi?id=159856
1955
1956         Reviewed by Dan Bernstein.
1957
1958         * MiniBrowser/mac/WK2BrowserWindowController.m:
1959         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1960         Add basic window.open implementation.
1961
1962         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
1963         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
1964         to open a single non-web URL, all others are dropped.
1965
1966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1967         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
1968         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
1969         Add API for the new SPI.
1970
1971 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
1972
1973         [JSC] Enable test262 module tests
1974         https://bugs.webkit.org/show_bug.cgi?id=159854
1975
1976         Reviewed by Saam Barati.
1977
1978         Use --module-file instead.
1979
1980         * Scripts/run-jsc-stress-tests:
1981
1982 2016-07-16  Chris Dumez  <cdumez@apple.com>
1983
1984         Unreviewed, rolling out r203318.
1985
1986         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
1987         SunSpider)
1988
1989         Reverted changeset:
1990
1991         "[JSC] Change some parameters based on a random search"
1992         https://bugs.webkit.org/show_bug.cgi?id=158514
1993         http://trac.webkit.org/changeset/203318
1994
1995 2016-07-16  Chris Dumez  <cdumez@apple.com>
1996
1997         Add move constructor / assignment operator to ListHashSet
1998         https://bugs.webkit.org/show_bug.cgi?id=159837
1999
2000         Reviewed by Darin Adler.
2001
2002         Add API tests.
2003
2004         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2005         (TestWebKitAPI::TEST):
2006
2007 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
2008
2009         [JSC] Change some parameters based on a random search
2010         https://bugs.webkit.org/show_bug.cgi?id=158514
2011
2012         Reviewed by Saam Barati.
2013
2014         * Scripts/run-jsc-stress-tests:
2015
2016 2016-07-15  Jon Davis  <jond@apple.com>
2017
2018         Changed the start page URL for WebKit Nightly builds.
2019         https://bugs.webkit.org/show_bug.cgi?id=159816
2020
2021         Reviewed by Timothy Hatcher.
2022
2023         * WebKitLauncher/start.html:
2024
2025 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
2026
2027         Uninitialized variable in DIBPixelData can cause a dangerous memory write
2028         https://bugs.webkit.org/show_bug.cgi?id=159414
2029
2030         Reviewed by Brent Fulgham.
2031
2032         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
2033         when the HDC parameter is invalid.
2034
2035         * TestWebKitAPI/PlatformWin.cmake:
2036         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
2037         (TestWebKitAPI::TEST):
2038
2039 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2040
2041         [GTK] Add basic tabs support to MiniBrowser
2042         https://bugs.webkit.org/show_bug.cgi?id=159803
2043
2044         Reviewed by Sergio Villar Senin.
2045
2046         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
2047         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
2048
2049         * MiniBrowser/gtk/BrowserTab.c: Added.
2050         (titleChanged):
2051         (isLoadingChanged):
2052         (decidePolicy):
2053         (removeChildIfInfoBar):
2054         (loadChanged):
2055         (createInfoBarQuestionMessage):
2056         (tlsErrorsDialogResponse):
2057         (loadFailedWithTLSerrors):
2058         (permissionRequestDialogResponse):
2059         (decidePermissionRequest):
2060         (colorChooserRGBAChanged):
2061         (popoverColorClosed):
2062         (colorChooserRequestFinished):
2063         (runColorChooserCallback):
2064         (inspectorOpenedInWindow):
2065         (inspectorClosed):
2066         (browserTabSetProperty):
2067         (browserTabFinalize):
2068         (browser_tab_init):
2069         (browserTabConstructed):
2070         (browser_tab_class_init):
2071         (getInternalURI):
2072         (browser_tab_new):
2073         (browser_tab_get_web_view):
2074         (browser_tab_load_uri):
2075         (browser_tab_get_title_widget):
2076         (browser_tab_set_status_text):
2077         (browser_tab_toggle_inspector):
2078         (browser_tab_start_search):
2079         (browser_tab_stop_search):
2080         (browser_tab_add_accelerators):
2081         (fullScreenMessageTimeoutCallback):
2082         (browser_tab_enter_fullscreen):
2083         (browser_tab_leave_fullscreen):
2084         * MiniBrowser/gtk/BrowserTab.h: Added.
2085         * MiniBrowser/gtk/BrowserWindow.c:
2086         (getExternalURI):
2087         (browserWindowSetStatusText):
2088         (reloadOrStopCallback):
2089         (goBackCallback):
2090         (goForwardCallback):
2091         (settingsCallback):
2092         (webViewURIChanged):
2093         (browserWindowHistoryItemActivated):
2094         (browserWindowUpdateNavigationActions):
2095         (webViewCreate):
2096         (webViewEnterFullScreen):
2097         (webViewLeaveFullScreen):
2098         (webViewDecidePolicy):
2099         (browserWindowCanZoomIn):
2100         (browserWindowCanZoomOut):
2101         (browserWindowZoomIn):
2102         (browserWindowZoomOut):
2103         (scrollEventCallback):
2104         (faviconChanged):
2105         (webViewIsLoadingChanged):
2106         (defaultZoomCallback):
2107         (searchCallback):
2108         (newTabCallback):
2109         (toggleWebInspector):
2110         (reloadPage):
2111         (reloadPageIgnoringCache):
2112         (stopPageLoad):
2113         (loadHomePage):
2114         (editingCommandCallback):
2115         (insertImageCommandCallback):
2116         (insertLinkCommandCallback):
2117         (browserWindowSetupEditorToolbar):
2118         (browserWindowSwitchTab):
2119         (browserWindowTabAddedOrRemoved):
2120         (browser_window_init):
2121         (browserWindowConstructed):
2122         (browserWindowSaveSession):
2123         (browserWindowDeleteEvent):
2124         (browser_window_new):
2125         (browser_window_append_view):
2126         (browser_window_load_uri):
2127         (browser_window_load_session):
2128         (browser_window_set_background_color):
2129         (resetStatusText): Deleted.
2130         (activateUriEntryCallback): Deleted.
2131         (webViewTitleChanged): Deleted.
2132         (resetEntryProgress): Deleted.
2133         (browserWindowCreateBackForwardMenu): Deleted.
2134         (webViewReadyToShow): Deleted.
2135         (webViewLoadFailed): Deleted.
2136         (webViewMouseTargetChanged): Deleted.
2137         (browserWindowUpdateZoomActions): Deleted.
2138         (webViewZoomLevelChanged): Deleted.
2139         (updateUriEntryIcon): Deleted.
2140         (zoomInCallback): Deleted.
2141         (zoomOutCallback): Deleted.
2142         (toggleFullScreen): Deleted.
2143         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
2144         (browserWindowFinalize): Deleted.
2145         (browser_window_class_init): Deleted.
2146         * MiniBrowser/gtk/BrowserWindow.h:
2147         * MiniBrowser/gtk/CMakeLists.txt:
2148         * MiniBrowser/gtk/main.c:
2149         (createBrowserTab):
2150         (aboutURISchemeRequestCallback):
2151         (main):
2152         (parseBackgroundColor): Deleted.
2153
2154 2016-07-14  Alex Christensen  <achristensen@webkit.org>
2155
2156         Allow RefPtrs of const RefCounted types
2157         https://bugs.webkit.org/show_bug.cgi?id=158269
2158
2159         Reviewed by Anders Carlsson.
2160
2161         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2162         (TestWebKitAPI::TEST):
2163         (TestWebKitAPI::ConstRefCounted::create):
2164         (TestWebKitAPI::returnConstRefCountedRef):
2165         (TestWebKitAPI::returnRefCountedRef):
2166
2167 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2168
2169         Test WTF.StringViewIterators is crashing since r203119
2170         https://bugs.webkit.org/show_bug.cgi?id=159710
2171
2172         Reviewed by Darin Adler.
2173
2174         There are two problems in the test case added in r203119. First is that it's testing
2175         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
2176         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
2177         const reference to the string view member of the deleted CodePoints object.
2178
2179         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2180         (TestWebKitAPI::TEST):
2181
2182 2016-07-13  Daniel Bates  <dabates@apple.com>
2183
2184         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
2185         https://bugs.webkit.org/show_bug.cgi?id=159738
2186         <rdar://problem/27304649>
2187
2188         Reviewed by Dan Bernstein.
2189
2190         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
2191         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
2192         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
2193         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
2194
2195         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2196         * WebKitTestRunner/ios/TestControllerIOS.mm:
2197         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
2198         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
2199
2200 2016-07-13  Beth Dakin  <bdakin@apple.com>
2201
2202         Attempted build fix.
2203
2204         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2205
2206 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
2207
2208         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
2209         https://bugs.webkit.org/show_bug.cgi?id=159686
2210
2211         Reviewed by Chris Dumez.
2212
2213         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
2214
2215         * WebKitTestRunner/TestController.cpp:
2216         (WTR::runOpenPanel):
2217         (WTR::TestController::createOtherPage):
2218         (WTR::TestController::createWebViewWithOptions):
2219
2220 2016-07-13  Beth Dakin  <bdakin@apple.com>
2221
2222         Add more candidate tests
2223         https://bugs.webkit.org/show_bug.cgi?id=159730
2224
2225         Reviewed by Tim Horton.
2226
2227         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
2228         two new tests to that file.
2229         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2230         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
2231         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
2232         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
2233         (TestWebKitAPI::TEST):
2234         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
2235
2236 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
2237
2238         AX: [ATK] spinbutton-crash.html fails
2239         https://bugs.webkit.org/show_bug.cgi?id=159723
2240
2241         Reviewed by Chris Fleizach.
2242
2243         Implement support for AXDecrementButton and AXIncrementButton in
2244         ATK's AccessibilityUIElement::uiElementAttributeValue().
2245
2246         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2247         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2248
2249 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2250
2251         [EFL] [GTK] Enable back crypto subtle on development builds.
2252         https://bugs.webkit.org/show_bug.cgi?id=159260
2253
2254         Reviewed by Carlos Garcia Campos.
2255
2256         * Scripts/webkitperl/FeatureList.pm:
2257
2258 2016-07-12  Mark Lam  <mark.lam@apple.com>
2259
2260         We should use different stack limits for stack checks from JS and host code.
2261         https://bugs.webkit.org/show_bug.cgi?id=159442
2262         <rdar://problem/26889188>
2263
2264         Reviewed by Geoffrey Garen.
2265
2266         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
2267         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
2268         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
2269         order to keep the js/regress-139548.html test happy with this patch.
2270
2271         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
2272         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
2273
2274         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2275         (-[LTRelayController _environmentVariables]):
2276         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2277         (main):
2278
2279 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
2280
2281         platformUserPreferredLanguages on Mac should not try to put the region into the language
2282         https://bugs.webkit.org/show_bug.cgi?id=159693
2283
2284         Rubber stamped by Alexey Proskuryakov.
2285         
2286         Revert the test change in r200105.
2287
2288         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2289         (TestWebKitAPI::languageForSystemLanguage):
2290
2291 2016-07-12  Chris Dumez  <cdumez@apple.com>
2292
2293         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
2294         https://bugs.webkit.org/show_bug.cgi?id=159663
2295         <rdar://problem/18995873>
2296
2297         Reviewed by Benjamin Poulain.
2298
2299         Add API test coverage.
2300
2301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2302         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
2303         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
2304         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
2305         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
2306         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
2307         (TEST):
2308
2309 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
2310
2311         Relax ordering requirements on StringView::CodePoints iterator
2312         https://bugs.webkit.org/show_bug.cgi?id=159609
2313
2314         Reviewed by Darin Adler.
2315
2316         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2317         (TestWebKitAPI::TEST):
2318
2319 2016-07-12  Youenn Fablet  <youenn@apple.com>
2320
2321         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
2322         https://bugs.webkit.org/show_bug.cgi?id=159564
2323
2324         Reviewed by Brian Burg.
2325
2326         * Scripts/webkitpy/codegen/main.py:
2327         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
2328
2329 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2330
2331         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
2332         https://bugs.webkit.org/show_bug.cgi?id=159671
2333
2334         Reviewed by Csaba Osztrogonác.
2335
2336         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
2337         https://bugs.webkit.org/show_bug.cgi?id=89235
2338
2339         So this guard can be removed in build scripts.
2340
2341         * Scripts/webkitperl/FeatureList.pm:
2342         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2343
2344 2016-07-11  Jason Marcell  <jmarcell@apple.com>
2345
2346         SVN.create_patch should find svn-create-patch relative to the WebKit root.
2347         https://bugs.webkit.org/show_bug.cgi?id=159652
2348
2349         Reviewed by Daniel Bates.
2350
2351         * Scripts/webkitpy/common/checkout/scm/svn.py:
2352         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
2353
2354 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
2355
2356         Implement grapheme cluster iterator on StringView
2357         https://bugs.webkit.org/show_bug.cgi?id=159598
2358
2359         Reviewed by Anders Carlsson.
2360
2361         This is in preparation for honoring the second argument to FontFaceSet.load().
2362
2363         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2364         (TestWebKitAPI::compareLoopIterations):
2365         (TestWebKitAPI::TEST):
2366
2367 2016-07-11  Nan Wang  <n_wang@apple.com>
2368
2369         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
2370         https://bugs.webkit.org/show_bug.cgi?id=158364
2371
2372         Reviewed by Anders Carlsson.
2373
2374         Added a function in TestRunner so that we can toggle the ignoring viewport
2375         scale limits setting. Also added a test option for that in order to change the 
2376         configuration of the webview in test.
2377
2378         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2379         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2380         (WTR::TestRunner::setNavigationGesturesEnabled):
2381         (WTR::TestRunner::setIgnoresViewportScaleLimits):
2382         (WTR::nextUIScriptCallbackID):
2383         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2384         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
2385         * WebKitTestRunner/TestController.cpp:
2386         (WTR::TestController::resetStateToConsistentValues):
2387         (WTR::updateTestOptionsFromTestHeader):
2388         (WTR::TestController::setNavigationGesturesEnabled):
2389         (WTR::TestController::setIgnoresViewportScaleLimits):
2390         (WTR::TestController::platformWillRunTest):
2391         * WebKitTestRunner/TestController.h:
2392         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
2393         * WebKitTestRunner/TestInvocation.cpp:
2394         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2395         * WebKitTestRunner/TestOptions.h:
2396         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2397         (WTR::TestController::platformCreateWebView):
2398
2399 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
2400
2401         [GTK] install-dependencies should not install packages built by jhbuild.
2402         https://bugs.webkit.org/show_bug.cgi?id=159628
2403
2404         Reviewed by Michael Catanzaro.
2405
2406         * gtk/install-dependencies:
2407         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
2408
2409 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
2410
2411         System proxy settings not used when building deps with jhbuild
2412         https://bugs.webkit.org/show_bug.cgi?id=159567
2413
2414         Reviewed by Michael Catanzaro.
2415
2416         This adds the gsettings-desktop-schemas-devel build dep to enable
2417         the libgiognomeproxy.so gio module in glib-networking, which uses
2418         GSettings on org.gnome.system.proxy.
2419         This is needed to query system proxy settings for Gnome desktops.
2420
2421         dconf can be manually added to jhbuild to build the
2422         libdconfsettings.so gio module for GSettings, so that
2423         libgiognomeproxy.so can access system settings.
2424           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
2425
2426         As an alternative to dconf settings, this commit also adds the
2427         libproxy-devel build dep to enable the libgiolibproxy.so module in
2428         glib-networking (suggested by Fujii Hironori).
2429
2430         It is useful to read proxy settings from environment variables.
2431         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
2432         environment variable to force using the envvar module in libproxy.
2433
2434         * gtk/install-dependencies:
2435
2436 2016-07-11  Mark Lam  <mark.lam@apple.com>
2437
2438         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
2439         https://bugs.webkit.org/show_bug.cgi?id=159524
2440
2441         Reviewed by Michael Saboff.
2442
2443         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
2444         Also fixed up some tests to behave better to work with this new limit.  This
2445         should make stack overflow tests complete sooner.
2446
2447         * Scripts/run-jsc-stress-tests:
2448         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2449         (main):
2450
2451 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2452
2453         [GTK] Whitespace fixes in install-dependencies script
2454
2455         Unreviewed.
2456
2457         * gtk/install-dependencies:
2458
2459 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2460
2461         [GTK] Install missing Fedora dependencies
2462
2463         Unreviewed.
2464
2465         * gtk/install-dependencies:
2466
2467 2016-07-09  Dan Bernstein  <mitz@apple.com>
2468
2469         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
2470         https://bugs.webkit.org/show_bug.cgi?id=159600
2471
2472         Reviewed by Daniel Bates.
2473
2474         * Scripts/git-add-reviewer:
2475         Added the -s|--rubber-stamp option.
2476         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
2477           new option.
2478
2479 2016-07-08  Andy Estes  <aestes@apple.com>
2480
2481         [Content Filtering] Load blocked pages more like other error pages are loaded
2482         https://bugs.webkit.org/show_bug.cgi?id=159485
2483         <rdar://problem/26014076>
2484
2485         Reviewed by Brady Eidson.
2486
2487         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2488         to a content filtering provisional navigation failure is ignored in preference of
2489         ContentFilter's own error page.
2490
2491         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2492         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2493         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2494         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2495         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2496         (loadAlternateTest):
2497         (TEST):
2498         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2499         (-[MockContentFilterEnabler initWithCoder:]):
2500         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2501         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2502         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2503         (TestWebKitAPI::loadAlternateTest):
2504         (TestWebKitAPI::TEST):
2505
2506 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2507
2508         Unreviewed, rolling out r202944.
2509         https://bugs.webkit.org/show_bug.cgi?id=159570
2510
2511         caused some tests to crash under GuardMalloc (Requested by
2512         estes on #webkit).
2513
2514         Reverted changeset:
2515
2516         "[Content Filtering] Load blocked pages more like other error
2517         pages are loaded"
2518         https://bugs.webkit.org/show_bug.cgi?id=159485
2519         http://trac.webkit.org/changeset/202944
2520
2521 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
2522
2523         Remove mrobinson from the MathML watchlist
2524         https://bugs.webkit.org/show_bug.cgi?id=159559
2525
2526         Reviewed by Philippe Normand.
2527
2528         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
2529
2530 2016-07-08  Brady Eidson  <beidson@apple.com>
2531
2532         Clearing LocalStorage doesn't also delete -wal and -shm files.
2533         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
2534
2535         Reviewed by Brent Fulgham.
2536         Also helpfully picked over by Andy "Never Forgets" Estes.
2537
2538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2539         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
2540         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
2541
2542 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
2543
2544         Removed Qt leftovers from Tools.
2545         https://bugs.webkit.org/show_bug.cgi?id=159557
2546
2547         Reviewed by Csaba Osztrogonác.
2548
2549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2550         Removed 'qt' platform config.
2551         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2552         Deleted non-functional e-mail address.
2553
2554 2016-07-08  Commit Queue  <commit-queue@webkit.org>
2555
2556         Unreviewed, rolling out r202967.
2557         https://bugs.webkit.org/show_bug.cgi?id=159556
2558
2559         This patch caused crashes in https tests on Windows (Requested
2560         by perarne on #webkit).
2561
2562         Reverted changeset:
2563
2564         "[Win] The test http/tests/security/contentSecurityPolicy
2565         /upgrade-insecure-requests/basic-upgrade.https.html is
2566         failing."
2567         https://bugs.webkit.org/show_bug.cgi?id=159510
2568         http://trac.webkit.org/changeset/202967
2569
2570 2016-07-08  Youenn Fablet  <youenn@apple.com>
2571
2572         Generate WebCore builtin wrapper files
2573         https://bugs.webkit.org/show_bug.cgi?id=159461
2574
2575         Reviewed by Brian Burg.
2576
2577         * Scripts/webkitpy/codegen/main.py:
2578         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
2579         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
2580
2581 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
2582
2583         [EFL] Fix build when media-stream is enabled.
2584         https://bugs.webkit.org/show_bug.cgi?id=159206
2585
2586         Bump up the openwebrtc to find the correct package.
2587
2588         Reviewed by Gyuyoung Kim.
2589
2590         * efl/jhbuild.modules:
2591         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
2592
2593 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2594
2595         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
2596         https://bugs.webkit.org/show_bug.cgi?id=159510
2597
2598         Reviewed by Brent Fulgham.
2599
2600         Allow any https certificate when running tests.
2601
2602         * DumpRenderTree/win/DumpRenderTree.cpp:
2603         (runTest):
2604
2605 2016-07-07  Beth Dakin  <bdakin@apple.com>
2606
2607         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
2608         https://bugs.webkit.org/show_bug.cgi?id=159532
2609         -and corresponding-
2610         rdar://problem/27177179
2611
2612         Reviewed by Tim Horton.
2613
2614         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
2615         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
2616
2617 2016-07-07  Andy Estes  <aestes@apple.com>
2618
2619         [Content Filtering] Load blocked pages more like other error pages are loaded
2620         https://bugs.webkit.org/show_bug.cgi?id=159485
2621         <rdar://problem/26014076>
2622
2623         Reviewed by Brady Eidson.
2624
2625         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
2626         to a content filtering provisional navigation failure is ignored in preference of
2627         ContentFilter's own error page.
2628
2629         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2630         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2631         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2632         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2633         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
2634         (loadAlternateTest):
2635         (TEST):
2636         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2637         (-[MockContentFilterEnabler initWithCoder:]):
2638         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
2639         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2640         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
2641         (TestWebKitAPI::loadAlternateTest):
2642         (TestWebKitAPI::TEST):
2643
2644 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2645
2646         Unreviewed: add myself to the reviewers list.
2647
2648         * Scripts/webkitpy/common/config/contributors.json:
2649
2650 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
2651
2652         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
2653         https://bugs.webkit.org/show_bug.cgi?id=159509
2654
2655         Reviewed by Alex Christensen.
2656
2657         We should always insert the url in the url map when identifierForInitialRequest
2658         is called. Otherwise we can end up with identifiers not having an entry in the
2659         url map when urls are written to the test output file. 
2660
2661         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2662         (ResourceLoadDelegate::identifierForInitialRequest):
2663
2664 2016-07-06  Tim Horton  <timothy_horton@apple.com>
2665
2666         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
2667         https://bugs.webkit.org/show_bug.cgi?id=159498
2668         <rdar://problem/26719903>
2669
2670         Reviewed by Sam Weinig.
2671
2672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2673         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
2674         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
2675         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
2676         (expectLinkCount):
2677         (TEST):
2678         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
2679         when deciding what to linkify.
2680
2681 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
2682
2683         Build fix - work around rdar://problem/27196668.
2684
2685         * LayoutTestRelay/Configurations/Base.xcconfig:
2686
2687 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
2688
2689         Enhance Windows DRT implementation to support platform scroll wheel events.
2690         https://bugs.webkit.org/show_bug.cgi?id=36002
2691
2692         Reviewed by Brent Fulgham.
2693
2694         Implement function continuousMouseScrollBy in Windows event sender.
2695
2696         * DumpRenderTree/win/EventSender.cpp:
2697         (mouseScrollBy):
2698         (continuousMouseScrollBy):
2699
2700 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
2701
2702         [Sierra] Rebaseline tests to use un-mocked system font metrics
2703         https://bugs.webkit.org/show_bug.cgi?id=159311
2704         <rdar://problem/24138411>
2705
2706         Reviewed in person by Alexey Proskuryakov.
2707
2708         Stop mocking the system font on Sierra.
2709
2710         * DumpRenderTree/mac/DumpRenderTree.mm:
2711         (setDefaultsToConsistentValuesForTesting):
2712         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2713         (WTR::InjectedBundle::platformInitialize):
2714
2715 2016-07-05  Brady Eidson  <beidson@apple.com>
2716
2717         Database process crashes deleting a corrupt SQLite database file (null deref).
2718         https://bugs.webkit.org/show_bug.cgi?id=155506.
2719
2720         Reviewed by Alex Christensen.
2721
2722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2723         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
2724         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
2725         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
2726         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
2727         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
2728
2729 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
2730
2731         run-webkit-tests should print more complete baseline search paths
2732         https://bugs.webkit.org/show_bug.cgi?id=159354
2733
2734         Reviewed by Daniel Bates.
2735
2736         run-webkit-tests used to only print directory names in baseline search paths.
2737         This was ok in basic usage, but quickly got confusing when using
2738         --additional-platform-directory flags.
2739
2740         * Scripts/webkitpy/layout_tests/views/printing.py:
2741         (Printer.print_config):
2742         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2743         (Testprinter.test_print_config):
2744         (Testprinter.test_print_one_line_summary):
2745
2746 2016-07-04  Brady Eidson  <beidson@apple.com>
2747
2748         WebProcesses don't handle DatabaseProcess going away uncleanly..
2749         https://bugs.webkit.org/show_bug.cgi?id=159371
2750
2751         Reviewed by Alex Christensen.
2752
2753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2754         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
2755         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
2756         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
2757         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
2758
2759 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2760
2761         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
2762         https://bugs.webkit.org/show_bug.cgi?id=158141
2763
2764         Rubber-stamped by Michael Catanzaro.
2765
2766         Instead of checking for an specific Ubuntu version, query the apt
2767         database to see which version of PHP is available.
2768
2769         * efl/install-dependencies:
2770         * gtk/install-dependencies:
2771
2772 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
2773
2774         webkit-patch failure-reason always raises TypeError
2775         https://bugs.webkit.org/show_bug.cgi?id=159394
2776
2777         Reviewed by Benjamin Poulain.
2778
2779         In r170637 (Bug 133067), the first and second arguments of
2780         pluralize were swapped.
2781
2782         * Scripts/webkitpy/tool/commands/queries.py:
2783         (FailureReason._builder_to_explain): Swap the first and second
2784         arguments of pluralize.
2785
2786 2016-07-02  Youenn Fablet  <youennf@gmail.com>
2787
2788         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
2789         https://bugs.webkit.org/show_bug.cgi?id=152486
2790
2791         Reviewed by Daniel Bates.
2792
2793         Add launch of web-platform-tests server by run-webkit-httpd.
2794         Add two options to disable starting httpd and web-platform-tests servers.
2795
2796         * Scripts/run-webkit-httpd:
2797         (parse_args):
2798         (main):
2799
2800 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
2801
2802         REGRESSION(r189668): Notification tests are flakey
2803         https://bugs.webkit.org/show_bug.cgi?id=159375
2804         <rdar://problem/22760990>
2805
2806         Reviewed by Alexey Proskuryakov.
2807
2808         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
2809         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
2810         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
2811         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
2812
2813         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
2814         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
2815         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
2816         global notification ID mapping, causing the wrong notification to be investigated.
2817
2818         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
2819         manually perform this same mapping. Luckily, this object already receives callbacks every time a
2820         notification is created or destroyed. However, because this object is implemented outside WebKit,
2821         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
2822         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
2823         WebNotificationProvider can properly map between the different IDs.
2824
2825         * WebKitTestRunner/TestController.cpp:
2826         (WTR::TestController::runTestingServerLoop):
2827         (WTR::TestController::simulateWebNotificationClick):
2828         * WebKitTestRunner/WebNotificationProvider.cpp:
2829         (WTR::WebNotificationProvider::showWebNotification):
2830         (WTR::removeGlobalIDFromIDMap):
2831         (WTR::WebNotificationProvider::closeWebNotification):
2832         (WTR::WebNotificationProvider::removeNotificationManager):
2833         (WTR::WebNotificationProvider::simulateWebNotificationClick):
2834         (WTR::WebNotificationProvider::reset):
2835         * WebKitTestRunner/WebNotificationProvider.h:
2836
2837 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
2838
2839         Simplify LayoutTestRelay
2840         https://bugs.webkit.org/show_bug.cgi?id=159353
2841
2842         Reviewed by Daniel Bates.
2843
2844         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
2845         by name and runtime makes no sense.
2846         2. Removed code to create devices, webkitpy always does this in advance.
2847         3. Don't create copies of testing apps - we can install the same one into
2848         each simulator, now that we don't run multiple tester processes in a single simulator.
2849         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
2850         5. Removed code that kept testing apps alive in the background.
2851         6. Slightly updated coding style in functions that I touched.
2852
2853         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
2854         Updated for what we acually use at this point.
2855
2856         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
2857         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2858         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
2859         (-[LTRelayController ipcIdentifier]):
2860         (-[LTRelayController processName]):
2861         (-[LTRelayController didReceiveStdoutData:]):
2862         (-[LTRelayController didCrashWithMessage:]):
2863         (-[LTRelayController installApp]):
2864         (-[LTRelayController _environmentVariables]):
2865         (-[LTRelayController launchApp]):
2866         (-[LTRelayController start]):
2867         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
2868         (-[LTRelayController uniqueAppPath]): Deleted.
2869         (-[LTRelayController uniqueAppURL]): Deleted.
2870         (-[LTRelayController uniqueAppIdentifier]): Deleted.
2871         (-[LTRelayController createUniqueApp]): Deleted.
2872         * LayoutTestRelay/LayoutTestRelay/main.m:
2873         (usage):
2874         (getRequiredStringArgument):
2875         (main):
2876         (getTestingSimDevice): Deleted.
2877         * Scripts/webkitpy/port/driver.py:
2878         (IOSSimulatorDriver.cmd_line):
2879         * WebKitTestRunner/ios/TestControllerIOS.mm:
2880         (WTR::TestController::platformInitialize):
2881         * WebKitTestRunner/ios/mainIOS.mm:
2882         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
2883         * DumpRenderTree/mac/DumpRenderTree.mm:
2884         (dumpRenderTree):
2885         (-[DumpRenderTree applicationDidEnterBackground:]):
2886
2887 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
2888
2889         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
2890         https://bugs.webkit.org/show_bug.cgi?id=159344
2891
2892         Reviewed by Alex Christensen.
2893
2894         * DumpRenderTree/CMakeLists.txt:
2895
2896 2016-07-01  Youenn Fablet  <youennf@gmail.com>
2897
2898         Add a runtime flag for DOM iterators
2899         https://bugs.webkit.org/show_bug.cgi?id=159300
2900
2901         Reviewed by Alex Christensen.
2902
2903         * DumpRenderTree/mac/DumpRenderTree.mm:
2904         (resetWebPreferencesToConsistentValues):
2905         * DumpRenderTree/win/DumpRenderTree.cpp:
2906         (resetWebPreferencesToConsistentValues):
2907         * Scripts/webkitperl/FeatureList.pm:
2908         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2909         (WTR::InjectedBundle::beginTesting):
2910         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2911         (WTR::TestRunner::setDOMIteratorEnabled):
2912         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2913
2914 2016-06-30  Tina Liu  <iting_liu@apple.com>
2915
2916         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
2917         https://bugs.webkit.org/show_bug.cgi?id=159326
2918
2919         Reviewed by Brady Eidson.
2920
2921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2922         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
2923         (TestWebKitAPI::didFinishLoadForFrame):
2924         (TestWebKitAPI::didChangeBackForwardListForPage):
2925         (TestWebKitAPI::setPageLoaderClient):
2926         Set the page loader client and register for didFinishLoadForFrame and
2927         didChangeBackForwardList callbacks.
2928         (TestWebKitAPI::createSessionStateData):
2929         Load a webpage ("simple.html") and return the session state for this page.
2930         (TestWebKitAPI::TEST):
2931         Restore the page session state with that of "simple.html" without navigation.
2932         Verify that the committed URL is NULL since there's no navigation involved.
2933         Verify that the current item in the back forward list, which should be what
2934         we restored from the session state, has the expected URL.
2935
2936 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
2937
2938         Generators violate bytecode liveness validation
2939         https://bugs.webkit.org/show_bug.cgi?id=159279
2940
2941         Reviewed by Yusuke Suzuki.
2942         
2943         Add Basic to our test harness.
2944
2945         * Scripts/run-javascriptcore-tests:
2946         (runJSCStressTests):
2947
2948 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
2949
2950         [Win][Debug] Assertion fails in TestWTF.
2951         https://bugs.webkit.org/show_bug.cgi?id=159299
2952
2953         Reviewed by Alex Christensen.
2954
2955         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
2956         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
2957         the assertion failure. Since the variable is actually used, there is no need to use the
2958         UNUSED_PARAM macro.
2959
2960         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
2961         (TestWebKitAPI::TEST):
2962
2963 2016-06-30  Youenn Fablet  <youennf@gmail.com>
2964
2965         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
2966         https://bugs.webkit.org/show_bug.cgi?id=159166
2967         <rdar://problem/27051759>
2968
2969         Reviewed by Alexey Proskuryakov.
2970
2971         Setting the certificate directory to the copied config.json.
2972
2973         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2974         (WebPlatformTestServer._copy_webkit_test_files):
2975
2976 2016-06-29  Mark Lam  <mark.lam@apple.com>
2977
2978         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
2979         https://bugs.webkit.org/show_bug.cgi?id=159274
2980
2981         Reviewed by Keith Miller.
2982
2983         * DumpRenderTree/mac/DumpRenderTree.mm:
2984         (DumpRenderTreeMain):
2985
2986 2016-06-29  Alex Christensen  <achristensen@webkit.org>
2987
2988         WKWebView should ask WKNavigationDelegate about bad ssl certificates
2989         https://bugs.webkit.org/show_bug.cgi?id=159176
2990
2991         Reviewed by Sam Weinig.
2992
2993         * MiniBrowser/mac/WK2BrowserWindowController.m:
2994         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2995         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
2996         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2997
2998 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2999
3000         [GTK] Add missing install dependency after r202619
3001         https://bugs.webkit.org/show_bug.cgi?id=156716
3002
3003         Unreviewed.
3004
3005         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
3006
3007 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3008
3009         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
3010         https://bugs.webkit.org/show_bug.cgi?id=156716
3011
3012         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
3013
3014         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
3015         (parse_args):
3016         * Scripts/webkitpy/port/gtk.py:
3017         (GtkPort.__init__):
3018         (GtkPort._driver_class):
3019         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
3020         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
3021         platform directory for storing the wayland specific layout test results and expectations for ${port}.
3022         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
3023         test expectations file on the GTK port when running the tests with the --wayland command line switch.
3024         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
3025         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
3026         (WestonDriver.check_driver):
3027         (WestonDriver.__init__):
3028         (WestonDriver._start):
3029         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
3030         (WestonXvfbDriverDisplayTest):
3031         (WestonXvfbDriverDisplayTest.__init__):
3032         (WestonXvfbDriverDisplayTest._xvfb_run):
3033         (WestonDriverTest.make_driver):
3034         (WestonDriverTest.test_start):
3035         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
3036         or to satisfy the pkg-config check of the new added modules in JHBuild.
3037         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
3038         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
3039         provided by the system are already new enough.
3040         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
3041         It was the only way to get the software EGL rasterizer working without depending on user drivers.
3042         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
3043         feature to avoid building libdrm when the one provided by the system is new enough.
3044         * gtk/jhbuildrc:
3045         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
3046         Xorg had no support for searching the DRI drivers on a custom path at runtime.
3047         This patch implements support for that reusing the same variable that we use with Mesa to set the
3048         custom path for the DRI drivers path.
3049
3050 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
3051
3052         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
3053         https://bugs.webkit.org/show_bug.cgi?id=159256
3054
3055         Reviewed by Philippe Normand.
3056
3057         We need the last fixes in the repository to make the scream queue
3058         work with apprtc.
3059
3060         * gtk/jhbuild.modules:
3061
3062 2016-06-28  Commit Queue  <commit-queue@webkit.org>
3063
3064         Unreviewed, rolling out r202580.
3065         https://bugs.webkit.org/show_bug.cgi?id=159245
3066
3067         Caused all WKTR tests to fail on GuardMalloc and Production
3068         only for unknown reasons, investigating offline. (Requested by
3069         brrian on #webkit).
3070
3071         Reverted changeset:
3072
3073         "RunLoop::Timer should use constructor templates instead of
3074         class templates"
3075         https://bugs.webkit.org/show_bug.cgi?id=159153
3076         http://trac.webkit.org/changeset/202580
3077
3078 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3079
3080         Use a regex to check if a test step is for JavaScriptCore
3081         https://bugs.webkit.org/show_bug.cgi?id=159224
3082
3083         Reviewed by Geoffrey Garen.
3084
3085         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3086         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
3087         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3088         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
3089         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3090         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
3091
3092 2016-06-28  Michael Saboff  <msaboff@apple.com>
3093
3094         btjs no longer accepts optional frame count argument
3095         https://bugs.webkit.org/show_bug.cgi?id=159235
3096
3097         Reviewed by Saam Barati.
3098
3099         Fix the detection of optional backtrace-depth parameter to use the length
3100         of the command.
3101
3102         * lldb/lldb_webkit.py:
3103         (btjs):
3104
3105 2016-06-28  Jon Lee  <jonlee@apple.com>
3106
3107         Update animometer.plan
3108
3109         Rubber-stamped by Said Abou-Hallawa.
3110
3111         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
3112
3113 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
3114
3115         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
3116
3117         * Scripts/run-javascriptcore-tests:
3118         (runJSCStressTests):
3119
3120 2016-06-28  Brian Burg  <bburg@apple.com>
3121
3122         RunLoop::Timer should use constructor templates instead of class templates
3123         https://bugs.webkit.org/show_bug.cgi?id=159153
3124
3125         Reviewed by Alex Christensen.
3126
3127         Remove the RunLoop::Timer class template argument, and pass its constructor
3128         a reference to `this` instead of a pointer to `this`.
3129
3130         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3131         (WTR::TestRunner::TestRunner):
3132         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3133         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3134         (TestWebKitAPI::TEST):
3135
3136 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
3137
3138         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
3139         https://bugs.webkit.org/show_bug.cgi?id=159199
3140
3141         Reviewed by Alexey Proskuryakov.
3142
3143         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
3144
3145         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3146         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
3147         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
3148         an input element getting automatically focused on Mac.
3149
3150 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
3151
3152         [Win] Custom elements tests are failing.
3153         https://bugs.webkit.org/show_bug.cgi?id=159139
3154
3155         Reviewed by Alex Christensen.
3156
3157         Enable custom element API when running tests.
3158
3159         * DumpRenderTree/win/DumpRenderTree.cpp:
3160         (resetWebPreferencesToConsistentValues):
3161
3162 2016-06-27  Lucas Forschler  <lforschler@apple.com>
3163
3164         Test commit. Please ignore.
3165         
3166 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3167
3168         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
3169         https://bugs.webkit.org/show_bug.cgi?id=155073
3170
3171         Reviewed by Daniel Bates.
3172
3173         * Scripts/webkitperl/FeatureList.pm:
3174
3175 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
3176
3177         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3178         https://bugs.webkit.org/show_bug.cgi?id=159077
3179
3180         Reviewed by Tim Horton.
3181
3182         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
3183
3184         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
3185         which is necessary for UI-side compositing.
3186
3187         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
3188         seems to happen for some tests that call window.resizeTo().
3189
3190         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3191         (WTR::InjectedBundlePage::dump): Deleted.
3192         * WebKitTestRunner/TestInvocation.cpp:
3193         (WTR::TestInvocation::dumpResults):
3194         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3195         (WTR::createCGContextFromImage):
3196         (WTR::computeMD5HashStringForContext):
3197         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3198         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3199         (WTR::PlatformWebView::windowSnapshotImage):
3200
3201 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3202
3203         [EFL] Support to build on Debian linux
3204         https://bugs.webkit.org/show_bug.cgi?id=159123
3205
3206         Reviewed by Antonio Gomes.
3207
3208         * efl/install-dependencies: Install libgnutls28-dev.
3209
3210 2016-06-27  Alex Christensen  <achristensen@webkit.org>
3211
3212         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
3213         https://bugs.webkit.org/show_bug.cgi?id=159071
3214
3215         Reviewed by Brady Eidson.
3216
3217         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3218         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3219         (WTR::TestRunner::setHandlesAuthenticationChallenges):
3220         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
3221         (WTR::TestRunner::setAuthenticationUsername):
3222         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3223         * WebKitTestRunner/TestController.cpp:
3224         (WTR::TestController::TestController):
3225         (WTR::TestController::resetStateToConsistentValues):
3226         (WTR::TestController::didFinishNavigation):
3227         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3228         (WTR::TestController::didReceiveAuthenticationChallenge):
3229         (WTR::TestController::didCommitNavigation):
3230         * WebKitTestRunner/TestController.h:
3231         (WTR::TestController::setBlockAllPlugins):
3232         (WTR::TestController::setShouldLogHistoryClientCallbacks):
3233         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
3234         (WTR::TestController::isCurrentInvocation):
3235         * WebKitTestRunner/TestInvocation.cpp:
3236         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3237         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
3238
3239 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
3240
3241         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
3242         https://bugs.webkit.org/show_bug.cgi?id=159129
3243
3244         Reviewed by Alex Christensen.
3245
3246         Implement the function mouseScrollBy in the Windows event sender.
3247
3248         * DumpRenderTree/win/EventSender.cpp:
3249         (mouseScrollBy):
3250         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3251
3252 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
3253
3254         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3255         https://bugs.webkit.org/show_bug.cgi?id=159104
3256
3257         Reviewed by Dan Bernstein.
3258         
3259         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
3260         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
3261
3262         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3263         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
3264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
3265
3266 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
3267
3268         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
3269         https://bugs.webkit.org/show_bug.cgi?id=159086
3270
3271         Reviewed by Alex Christensen.
3272
3273         Implement required wheel event function in event sender.
3274  
3275         * DumpRenderTree/win/EventSender.cpp:
3276         (mouseScrollByWithWheelAndMomentumPhasesCallback):
3277
3278 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
3279
3280         REGRESSION: Weak symbol warning when linking TestWebKitAPI
3281         https://bugs.webkit.org/show_bug.cgi?id=159104
3282
3283         Reviewed by Mark Lam.
3284         
3285         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
3286         WK.
3287
3288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3289
3290 2016-06-24  David Kilzer  <ddkilzer@apple.com>
3291
3292         parser_unittests.pl should not hardcode list of tests
3293         <https://webkit.org/b/159074>
3294
3295         Reviewed by Daniel Bates.
3296
3297         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3298         Update to read the list of tests from the 'resources' directory,
3299         and instead map file extensions to subroutine names.  Switch to
3300         use File::Basename::fileparse() to get basename and file
3301         extension for each test.
3302         (readTestFiles): Added.  Reads files from the directory passed
3303         in and ignores: hidden files, anything that isn't a plain file,
3304         and expected test results files.
3305
3306 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3307
3308         Fix Windows build.
3309
3310         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3311         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3312
3313 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3314
3315         [EFL] Change download path of libxslt
3316
3317         Unreviewed EFL build fix.
3318
3319         In Korea current download path can't be accessed. Change it.
3320
3321         * efl/jhbuild.modules:
3322
3323 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3324
3325         https://bugs.webkit.org/show_bug.cgi?id=159077
3326
3327         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
3328         snapshot the final state of the test in release builds. 
3329
3330         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3331         (WTR::InjectedBundlePage::dump):
3332
3333 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3334
3335         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
3336
3337         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3338         (createBitmapContextFromWebView):
3339         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3340         (WTR::PlatformWebView::windowSnapshotImage):
3341
3342 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
3343
3344         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
3345         https://bugs.webkit.org/show_bug.cgi?id=159077
3346
3347         Reviewed by Tim Horton.
3348
3349         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
3350         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
3351         thus enabling testing of more things.
3352
3353         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3354         (createBitmapContext): Moved to this file to share it.
3355         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3356         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3357         (createBitmapContextFromWebView):
3358         (BitmapContext::createFromUIImage): Deleted.
3359         (BitmapContext::pixelData): Deleted.
3360         (BitmapContext::BitmapContext): Deleted.
3361         (computeMD5HashStringForBitmapContext): Deleted.
3362         (dumpBitmap): Deleted.
3363         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
3364         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3365         (createPagedBitmapContext):
3366         (createBitmapContext): Deleted.
3367         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
3368         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3369         (WTR::InjectedBundlePage::dump): Deleted.
3370         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3371         (WTR::PlatformWebView::windowSnapshotImage):
3372
3373 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3374
3375         [jhbuild] Added libxslt module.
3376         https://bugs.webkit.org/show_bug.cgi?id=159034
3377
3378         Unreviewed, followup for r202373.
3379
3380         * efl/install-dependencies: Removed libxslt 
3381         * gtk/install-dependencies: Ditto.
3382
3383 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3384
3385         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
3386         https://bugs.webkit.org/show_bug.cgi?id=159050
3387
3388         Reviewed by Antonio Gomes.
3389
3390         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
3391
3392         * efl/jhbuild.modules:
3393         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
3394         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
3395
3396 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3397
3398         [jhbuild] Added libxslt module.
3399         https://bugs.webkit.org/show_bug.cgi?id=159034
3400
3401         Reviewed by Michael Catanzaro.
3402
3403         * efl/jhbuild.modules:
3404         * gtk/jhbuild.modules:
3405
3406 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3407
3408         [Win] Use Windows api function to find top level parent.
3409         https://bugs.webkit.org/show_bug.cgi?id=159021
3410
3411         Reviewed by Brent Fulgham.
3412
3413         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
3414  
3415         * DumpRenderTree/win/UIDelegate.cpp:
3416         (UIDelegate::runModal):
3417         (findTopLevelParent): Deleted.
3418         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3419         (PrintWebUIDelegate::runModal):
3420         (findTopLevelParent): Deleted.
3421
3422 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3423
3424         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
3425         https://bugs.webkit.org/show_bug.cgi?id=158934
3426
3427         Reviewed by Brent Fulgham.
3428
3429         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
3430
3431         * DumpRenderTree/win/TestRunnerWin.cpp:
3432         (TestRunner::clearAllDatabases):
3433
3434 2016-06-22  Saam Barati  <sbarati@apple.com>
3435
3436         run-javascriptcore-tests should have some environment variables for commonly used settings
3437         https://bugs.webkit.org/show_bug.cgi?id=159047
3438
3439         Reviewed by Keith Miller.
3440
3441         This patch adds three environment variables that run-javascriptcore-tests
3442         consults:
3443         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
3444           determines if we should run the api tests or not.
3445         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
3446           determines if we will perform a build or not before running the tests.
3447           to set the default should-build setting.
3448         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
3449           a yaml file. If set, we will run the extra tests it refers to.
3450
3451         All the values in these environment variables will be overridden if an
3452         option is explicitly passed in. For example, the following will run
3453         the api tests:
3454         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
3455
3456         * Scripts/run-javascriptcore-tests:
3457
3458 2016-06-22  Saam barati  <sbarati@apple.com>
3459
3460         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
3461         https://bugs.webkit.org/show_bug.cgi?id=159037
3462         <rdar://problem/26935349>
3463
3464         Reviewed by Benjamin Poulain.
3465
3466         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
3467
3468         * Scripts/run-jsc-stress-tests:
3469
3470 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
3471
3472         Fix style issues in webkitpy
3473         https://bugs.webkit.org/show_bug.cgi?id=159019
3474
3475         Reviewed by Daniel Bates.
3476
3477         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
3478         There is no functionality change.
3479         Only affected file names retained below for brevity.
3480
3481         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3482         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3483         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3484         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3485         * Scripts/webkitpy/benchmark_runner/utils.py:
3486         * Scripts/webkitpy/common/checkout/changelog.py:
3487         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3488         * Scripts/webkitpy/common/checkout/checkout.py:
3489         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3490         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3491         * Scripts/webkitpy/common/checkout/commitinfo.py:
3492         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3493         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
3494         * Scripts/webkitpy/common/checkout/scm/scm.py:
3495         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3496         * Scripts/webkitpy/common/config/committers_unittest.py:
3497         * Scripts/webkitpy/common/config/irc.py:
3498         * Scripts/webkitpy/common/config/ports.py:
3499         * Scripts/webkitpy/common/config/ports_unittest.py:
3500         * Scripts/webkitpy/common/config/urls.py:
3501         * Scripts/webkitpy/common/host_mock.py:
3502         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3503         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3504         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3505         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3506         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3507         * Scripts/webkitpy/common/net/credentials_unittest.py:
3508         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3509         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3510         * Scripts/webkitpy/common/net/statusserver.py:
3511         * Scripts/webkitpy/common/system/autoinstall.py:
3512         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3513         * Scripts/webkitpy/common/system/executive.py:
3514         * Scripts/webkitpy/common/system/executive_mock.py:
3515         * Scripts/webkitpy/common/system/executive_unittest.py:
3516         * Scripts/webkitpy/common/system/filesystem_mock.py:
3517         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3518         * Scripts/webkitpy/common/system/logutils_unittest.py:
3519         * Scripts/webkitpy/common/system/path.py:
3520         * Scripts/webkitpy/common/system/path_unittest.py:
3521         * Scripts/webkitpy/common/system/platforminfo.py:
3522         * Scripts/webkitpy/common/system/user.py:
3523         * Scripts/webkitpy/common/system/user_unittest.py:
3524         * Scripts/webkitpy/common/system/workspace_unittest.py:
3525         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
3526         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
3527         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3528         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3529         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3530         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3531         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3532         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3533         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3534         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3535         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3536         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3537         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3538         * Scripts/webkitpy/layout_tests/views/printing.py:
3539         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3540         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3541         * Scripts/webkitpy/port/base_unittest.py:
3542         * Scripts/webkitpy/port/driver.py:
3543         * Scripts/webkitpy/port/driver_unittest.py:
3544         * Scripts/webkitpy/port/factory.py:
3545         * Scripts/webkitpy/port/gtk.py:
3546         * Scripts/webkitpy/port/server_process_unittest.py:
3547         * Scripts/webkitpy/port/test.py:
3548         * Scripts/webkitpy/port/win.py:
3549         * Scripts/webkitpy/style/checker.py:
3550         * Scripts/webkitpy/style/checkers/common_unittest.py:
3551         * Scripts/webkitpy/style/checkers/cpp.py:
3552         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3553         * Scripts/webkitpy/style/checkers/js.py:
3554         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3555         * Scripts/webkitpy/style/checkers/png.py:
3556         * Scripts/webkitpy/style/checkers/text.py:
3557         * Scripts/webkitpy/style/checkers/text_unittest.py:
3558         * Scripts/webkitpy/style/error_handlers.py:
3559         * Scripts/webkitpy/style/filter.py:
3560         * Scripts/webkitpy/style/filter_unittest.py:
3561         * Scripts/webkitpy/style/optparser.py:
3562         * Scripts/webkitpy/style/optparser_unittest.py:
3563         * Scripts/webkitpy/test/main.py:
3564         * Scripts/webkitpy/w3c/test_converter.py:
3565         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3566         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3567         * Scripts/webkitpy/xcode/simulator.py:
3568
3569 2016-06-22  Brady Eidson  <beidson@apple.com>
3570
3571         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
3572         https://bugs.webkit.org/show_bug.cgi?id=158894
3573
3574         Reviewed by Alex Christensen.
3575
3576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3577         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
3578         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
3579         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3580
3581 2016-06-22  Jon Lee  <jonlee@apple.com>
3582
3583         Update animometer.plan
3584         https://bugs.webkit.org/show_bug.cgi?id=159012
3585
3586         Reviewed by Ryosuke Niwa.
3587
3588         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
3589
3590 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3591
3592         W3C test importer should generate files to ignore by WebKit SCM
3593         https://bugs.webkit.org/show_bug.cgi?id=142743
3594
3595         Reviewed by Darin Adler.
3596
3597         TestDownloader generates the .gitignore file according submodules git repository information.
3598         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
3599
3600         * Scripts/webkitpy/w3c/test_downloader.py:
3601         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
3602         * Scripts/webkitpy/w3c/test_importer.py:
3603         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
3604         (TestImporter):
3605         (TestImporter.write_init_py): Writing not empty __init__.py files.
3606         (TestImporter.import_tests): Using  of write_init_py. 
3607         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3608         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
3609         (TestImporterTest):
3610         (TestImporterTest.test_initpy_generation): Added __init__.py test.
3611
3612 2016-06-21  Sam Weinig  <sam@webkit.org>
3613
3614         WKWebView with no WKNavigationDelegate does not follow universal links
3615         <rdar://problem/24374110>
3616         https://bugs.webkit.org/show_bug.cgi?id=158997
3617
3618         Reviewed by Dan Bernstein.
3619
3620         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3621         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
3622         Add a new test that shows that we have a default navigation delegate by swizzling
3623         -[NSWorkspace openURL:]. This will only be called if there is a default client.
3624
3625 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3626
3627         [Win] Implement modal dialog support in MiniBrowser.
3628         https://bugs.webkit.org/show_bug.cgi?id=158976
3629
3630         Reviewed by Brent Fulgham.
3631
3632         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3633         (PrintWebUIDelegate::createWebViewWithRequest):
3634         (getHandleFromWebView):
3635         (PrintWebUIDelegate::webViewClose):
3636         (PrintWebUIDelegate::setFrame):
3637         (PrintWebUIDelegate::webViewFrame):
3638         (PrintWebUIDelegate::canRunModal):
3639         (findTopLevelParent):
3640         (PrintWebUIDelegate::runModal):
3641         (PrintWebUIDelegate::createModalDialog):
3642         * MiniBrowser/win/PrintWebUIDelegate.h:
3643         (PrintWebUIDelegate::webViewClose):
3644         (PrintWebUIDelegate::setFrame):
3645         (PrintWebUIDelegate::webViewFrame):
3646         (PrintWebUIDelegate::canRunModal):
3647         (PrintWebUIDelegate::runModal):
3648
3649 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
3650
3651         window.showModalDialog doesn't work in DumpRenderTree on Windows
3652         https://bugs.webkit.org/show_bug.cgi?id=53675
3653
3654         Reviewed by Brent Fulgham.
3655
3656         Implement modal dialog support in DumpRenderTree.
3657
3658         * DumpRenderTree/win/UIDelegate.cpp:
3659         (UIDelegate::canRunModal):
3660         (getHandleFromWebView):
3661         (UIDelegate::createModalDialog):
3662         (findTopLevelParent):
3663         (UIDelegate::runModal):
3664         (UIDelegate::webViewClose):
3665         * DumpRenderTree/win/UIDelegate.h:
3666
3667 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
3668
3669         Fix formatting issues reported by check-webkit-style
3670         https://bugs.webkit.org/show_bug.cgi?id=159008
3671
3672         Reviewed by Alexey Proskuryakov.
3673
3674         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
3675         There is no functionality change.
3676
3677         * Scripts/webkitpy/tool/bot/irc_command.py:
3678         (Restart.execute):
3679         (Rollout):
3680         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3681         (IRCBotTest.test_exception_during_command):
3682         (IRCBotTest.test_exception_during_command.CommandWithException):
3683         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
3684         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3685         (test_missing_unit_test_results_path):
3686         (test_layout_test_results):
3687         * Scripts/webkitpy/tool/bot/queueengine.py:
3688         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3689         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3690         (AbstractSequencedCommand):
3691         (AbstractSequencedCommand.__init__):
3692         * Scripts/webkitpy/tool/commands/download.py:
3693         (Land):
3694         * Scripts/webkitpy/tool/commands/openbugs.py:
3695         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3696         (OpenBugsTest):
3697         * Scripts/webkitpy/tool/commands/queries.py:
3698         (PatchesToCommitQueue):
3699         (PatchesToCommitQueue.__init__):
3700         (PatchesToCommitQueue._needs_commit_queue):
3701         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3702         (PrintExpectationsTest.test_platform):
3703         (PrintBaselinesTest):
3704         (PrintBaselinesTest.setUp):
3705         * Scripts/webkitpy/tool/commands/queues.py:
3706         (AbstractQueue):
3707         (AbstractQueue.__init__):
3708         (AbstractQueue.execute):
3709         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3710         (test_auto_retry):
3711         * Scripts/webkitpy/tool/commands/rebaseline.py:
3712         (AbstractParallelRebaselineCommand._files_to_add):
3713         (AbstractParallelRebaselineCommand):
3714         (AbstractParallelRebaselineCommand._rebaseline):
3715         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3716         (SetupGitClone):
3717         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3718         * Scripts/webkitpy/tool/commands/stepsequence.py:
3719         * Scripts/webkitpy/tool/commands/upload.py:
3720         (PostCommits._comment_text_for_commit):
3721         (PostCommits):
3722         (PostCommits.execute):
3723         (MarkBugFixed):
3724         (MarkBugFixed.__init__):
3725         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3726         (UploadCommandsTest):
3727         (UploadCommandsTest.test_commit_message_for_current_diff):
3728         * Scripts/webkitpy/tool/grammar_unittest.py:
3729         (GrammarTest):
3730         (GrammarTest.test_join_with_separators):
3731         * Scripts/webkitpy/tool/multicommandtool.py:
3732         (HelpCommand.__init__):
3733         (HelpCommand):
3734         (HelpCommand._help_epilog):
3735         (HelpCommand._remove_help_options):
3736         (MultiCommandTool):
3737         (MultiCommandTool.__init__):
3738         (MultiCommandTool.main):
3739         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
3740         (TrivialCommand):
3741         (TrivialCommand.__init__):
3742         (MultiCommandToolTest):
3743         (MultiCommandToolTest._assert_tool_main_outputs):
3744         (MultiCommandToolTest.test_retry):
3745         (test_command_help):
3746         * Scripts/webkitpy/tool/steps/__init__.py:
3747         * Scripts/webkitpy/tool/steps/abstractstep.py:
3748         * Scripts/webkitpy/tool/steps/applypatch.py:
3749         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
3750         (ApplyPatchWithLocalCommit):
3751         (ApplyPatchWithLocalCommit.options):
3752         * Scripts/webkitpy/tool/steps/build.py:
3753         * Scripts/webkitpy/tool/steps/checkstyle.py:
3754         (CheckStyle):
3755         (CheckStyle.options):
3756         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3757         * Scripts/webkitpy/tool/steps/closebug.py:
3758         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
3759         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
3760         (CloseBugForLandDiffTest):
3761         (CloseBugForLandDiffTest.test_empty_state):
3762         * Scripts/webkitpy/tool/steps/closepatch.py:
3763         * Scripts/webkitpy/tool/steps/commit.py:
3764         (Commit.run):
3765         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3766         * Scripts/webkitpy/tool/steps/editchangelog.py:
3767         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
3768         * Scripts/webkitpy/tool/steps/metastep.py:
3769         (MetaStep):
3770         (MetaStep.__init__):
3771         (MetaStep.run):
3772         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
3773         * Scripts/webkitpy/tool/steps/options.py:
3774         (Options):
3775         * Scripts/webkitpy/tool/steps/postdiff.py:
3776         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
3777         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
3778         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3779         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3780         (PrepareChangeLogTest):
3781         (PrepareChangeLogTest.test_resolve_existing_entry):
3782         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3783         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
3784         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3785         * Scripts/webkitpy/tool/steps/revertrevision.py:
3786         * Scripts/webkitpy/tool/steps/runtests.py:
3787         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3788         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3789         (StepsTest):
3790         (StepsTest._step_options):
3791         * Scripts/webkitpy/tool/steps/update.py:
3792         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3793         (UpdateChangeLogsWithReviewerTest):
3794         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
3795         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3796         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3797
3798 2016-06-21  Chris Dumez  <cdumez@apple.com>
3799
3800         Unreviewed, rolling out r202296.
3801
3802         Broke basic browsing in Safari
3803
3804         Reverted changeset:
3805
3806         "WKWebView with no WKNavigationDelegate does not follow
3807         universal links"
3808         https://bugs.webkit.org/show_bug.cgi?id=158997
3809         http://trac.webkit.org/changeset/202296
3810
3811 2016-06-21  Anders Carlsson  <andersca@apple.com>
3812
3813         Fix build.
3814
3815         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3816
3817 2016-06-21  Anders Carlsson  <andersca@apple.com>
3818
3819         Begin moving the Apple Pay code to the open source repository
3820         https://bugs.webkit.org/show_bug.cgi?id=158998
3821
3822         Reviewed by Tim Horton.
3823
3824         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3825         Add ENABLE_APPLE_PAY.
3826
3827 2016-06-21  Said Abou-Hallawa  <sabouhallawa@apple,com>
3828
3829         Add system tracing points for requestAnimationFrame() workflow
3830         https://bugs.webkit.org/show_bug.cgi?id=158723
3831
3832         Reviewed by Simon Fraser.
3833
3834         Add new plist entries to be used by kdebug_trace() viewing tools.
3835
3836         * Tracing/SystemTracePoints.plist:
3837
3838 2016-06-21  Sam Weinig  <sam@webkit.org>
3839
3840         WKWebView with no WKNavigationDelegate does not follow universal links
3841         <rdar://problem/24374110>
3842         https://bugs.webkit.org/show_bug.cgi?id=158997
3843
3844         Reviewed by Dan Bernstein.
3845
3846         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3847         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
3848         Add a new test that shows that we have a default navigation delegate by swizzling
3849         -[NSWorkspace openURL:]. This will only be called if there is a default client.
3850
3851 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
3852
3853         run-javascriptcore-tests should have flag to skip mozilla tests
3854         https://bugs.webkit.org/show_bug.cgi?id=158963
3855         rdar://problem/25838924
3856
3857         Reviewed by Alexey Proskuryakov.
3858
3859         * Scripts/run-javascriptcore-tests:
3860         (runJSCStressTests): Added flag to skip mozilla tests.
3861
3862 2016-06-20  Commit Queue  <commit-queue@webkit.org>
3863
3864         Unreviewed, rolling out r202136.
3865         https://bugs.webkit.org/show_bug.cgi?id=158932
3866
3867         JSBench wasn't regressed by r202002 and r202111 on iOS after
3868         all (Requested by rniwa_ on #webkit).
3869
3870         Reverted changeset:
3871
3872         "Unreviewed, rolling out r202002 and r202111."
3873         https://bugs.webkit.org/show_bug.cgi?id=158638
3874         http://trac.webkit.org/changeset/202136
3875
3876 2016-06-20  Keith Rollin  <krollin@apple.com>
3877
3878         Remove RefPtr::release() and change calls sites to use WTFMove()
3879         https://bugs.webkit.org/show_bug.cgi?id=158369
3880
3881         Reviewed by Chris Dumez.
3882
3883         RefPtr::release() releases its managed pointer awkwardly. It's more
3884         direct and clearer to use WTFMove to transfer ownership of the managed
3885         pointer.
3886
3887         As part of this cleanup, also change a lot of explicit data types to
3888         'auto'.
3889
3890         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3891         (createBitmapContextFromWebView):
3892         (createPagedBitmapContext):
3893         * DumpRenderTree/mac/TestRunnerMac.mm:
3894         (TestRunner::setMockGeolocationPosition):
3895         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
3896         (TestWebKitAPI::TEST):
3897         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3898         (TestWebKitAPI::TEST):
3899
3900 2016-06-20  Tim Horton  <timothy_horton@apple.com>
3901
3902         Add a API test for *DeferringViewInWindowChanges as fixed in r202230
3903         https://bugs.webkit.org/show_bug.cgi?id=158947
3904
3905         Reviewed by Simon Fraser.
3906
3907         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3908         * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.
3909         (TestWebKitAPI::didFinishLoadForFrame):
3910         (TestWebKitAPI::setPageLoaderClient):
3911         (TestWebKitAPI::TEST):
3912         Add a test ensuring that in-window state changes are deferred when using
3913         the SPI for deferring them, as fixed in r202230.
3914
3915 2016-06-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3916
3917         WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
3918         https://bugs.webkit.org/show_bug.cgi?id=158931
3919
3920         Reviewed by Alexey Proskuryakov.
3921
3922         * WebKitTestRunner/TestInvocation.cpp:
3923         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line.
3924
3925 2016-06-17  Alexey Proskuryakov  <ap@apple.com>
3926
3927         Add test expectations for macOS Sierra
3928         https://bugs.webkit.org/show_bug.cgi?id=158903
3929
3930         Reviewed by Alex Christensen.
3931
3932         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added.
3933         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png: Added.
3934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3935         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3936         Added dashboard support.
3937
3938         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3939         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3940         Trigger the right build queues on check-in.
3941
3942         * Scripts/webkitpy/common/system/platforminfo.py:
3943         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3944         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3945         * Scripts/webkitpy/port/mac.py:
3946         * Scripts/webkitpy/port/mac_unittest.py:
3947         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3948         Added cases for Sierra, and updated tests for new baseline search paths.
3949
3950 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
3951
3952         Another buid fix for master.cfg.
3953
3954         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3955         (CompileWebKit.start):
3956
3957 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
3958
3959         Another buid fix for master.cfg.
3960
3961         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3962         (CompileWebKit.start):
3963
3964 2016-06-19  Lucas Forschler  <lforschler@apple.com>
3965
3966         Fix master.cfg
3967         
3968         Unreviewed build fix.
3969
3970         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3971         (CompileWebKit.start):
3972
3973 2016-06-19  Lucas Forschler  <lforschler@apple.com>
3974
3975         Test another commit.
3976         
3977         Unreviewed.
3978
3979 2016-06-19  Lucas Forschler  <lforschler@apple.com>
3980
3981         Testing fix for trac-mirror.
3982         
3983         Unreviewed.
3984
3985 2016-06-19  Lucas Forschler  <lforschler@apple.com>
3986
3987         Test a commit against the SVN 1.9 server upgrade.
3988         
3989         Unreviewed.
3990         
3991 2016-06-17  Daniel Bates  <dabates@apple.com>
3992
3993         Unreviewed, rolling out r202186.
3994
3995         Broke the Apple Windows, Apple Yosemite, GTK, and WinCairo
3996         builds.
3997
3998         Reverted changeset:
3999
4000         "File scheme should not allow access of a resource on a
4001         different volume."
4002         https://bugs.webkit.org/show_bug.cgi?id=158552
4003         http://trac.webkit.org/changeset/202186
4004
4005 2016-06-17  Pranjal Jumde  <pjumde@apple.com>
4006
4007         File scheme should not allow access of a resource on a different volume.
4008         https://bugs.webkit.org/show_bug.cgi?id=158552
4009         <rdar://problem/15307582>
4010
4011         Reviewed by Brent Fulgham.
4012
4013         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4014         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
4015         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
4016         (-[CrossPartitionFileSchemeAccessNavigationDelegate webView:didFinishNavigation:]):
4017         When the main page load is complete fetch the contents of the document to check if iframe was loaded
4018         (createPartition):
4019         Create a disk image and load the contents of the file.
4020         (cleanUp):
4021         (TestWebKitAPI::TEST):
4022
4023 2016-06-17  Enrique Ocaña González  <eocanha@igalia.com>
4024
4025         Unreviewed. Added myself to the list of committers.
4026
4027         * Scripts/webkitpy/common/config/contributors.json:
4028
4029 2016-06-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4030
4031         [EFL][GTK] LayoutTest doesn't run on Ubuntu 16.04
4032         https://bugs.webkit.org/show_bug.cgi?id=158141
4033
4034         Reviewed by Michael Catanzaro.
4035
4036         * Scripts/webkitpy/port/base.py: Detect php version in system, then use it.
4037         (Port._is_debian_php_version_7):
4038         (Port._debian_php_version):
4039         (Port._apache_config_file_name_for_platform):
4040         * efl/install-dependencies:
4041         * gtk/install-dependencies:
4042
4043 2016-06-16  Filip Pizlo  <fpizlo@apple.com>
4044
4045         Baseline JIT should be concurrent
4046         https://bugs.webkit.org/show_bug.cgi?id=158755
4047
4048         Reviewed by Geoffrey Garen.
4049         
4050         Need to disable concurrent JIT when running profiler tests. We should have been doing this
4051         all along.
4052
4053         * Scripts/run-jsc-stress-tests:
4054
4055 2016-06-16  Per Arne Vollan  <pvollan@apple.com>
4056
4057         [Win] Accessibility implementation unable to recurse through document (sometimes) to find named elements
4058         https://bugs.webkit.org/show_bug.cgi?id=140798
4059
4060         Reviewed by Brent Fulgham.
4061        
4062         Make sure layout is up-to-date before trying to find named elements. 
4063
4064         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4065         (AccessibilityController::rootElement):
4066
4067 2016-06-16  Chris Dumez  <cdumez@apple.com>
4068
4069         Unreviewed, rolling out r202002 and r202111.
4070
4071         Ryosuke says this was a JSBench regression on iOS
4072
4073         Reverted changesets:
4074
4075         "Make HashMap and HashSet work with Refs"
4076         https://bugs.webkit.org/show_bug.cgi?id=158638
4077         http://trac.webkit.org/changeset/202002
4078
4079         "Improve HashMap and HashSet support for Ref"
4080         https://bugs.webkit.org/show_bug.cgi?id=158789
4081         http://trac.webkit.org/changeset/202111
4082
4083 2016-06-15  Simon Fraser  <simon.fraser@apple.com>
4084
4085         [iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location
4086         https://bugs.webkit.org/show_bug.cgi?id=158828
4087
4088         Reviewed by Enrica Casucci.
4089         
4090         Expose "forceIPadStyleZoomOnInputFocus" on UIScriptController, which allows iPad-style
4091         zooming behavior on <input> focus in the iPhone simulator, which is used for testing.
4092
4093         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
4094         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
4095         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
4096         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
4097         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
4098         * WebKitTestRunner/ios/TestControllerIOS.mm:
4099         (WTR::TestController::platformResetStateToConsistentValues):
4100         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4101         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
4102         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
4103
4104 2016-06-15  Sam Weinig  <sam@webkit.org>
4105
4106         Forward/Back keyboard shortcuts need to flip for RTL
4107         https://bugs.webkit.org/show_bug.cgi?id=158823
4108         <rdar://problem/25975359>
4109
4110         Reviewed by Darin Adler.
4111
4112         Add tests for flipping the behavior of command-left and command-right
4113         under RTL mode.
4114
4115         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4116         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Added.
4117         (-[CommandBackForwardOffscreenWindow isKeyWindow]):
4118         (-[CommandBackForwardOffscreenWindow isVisible]):
4119         (simulateCommandArrow):
4120         (WebKit2_CommandBackForwardTest::SetUp):
4121         (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame):
4122         (WebKit2_CommandBackForwardTestWKView::SetUp):
4123         (WebKit2_CommandBackForwardTestWKView::loadFiles):
4124         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]):
4125         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
4126         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
4127
4128 2016-06-15  Tim Horton  <timothy_horton@apple.com>
4129
4130         Expose _shouldExpandContentToViewHeightForAutoLayout SPI on WKWebView
4131         https://bugs.webkit.org/show_bug.cgi?id=158824
4132         <rdar://problem/23713857>
4133
4134         Reviewed by Simon Fraser.
4135
4136         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
4137         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
4138         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
4139         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
4140         (TEST):
4141         Add a test for _shouldExpandContentToViewHeightForAutoLayout.
4142
4143 2016-06-13  Simon Fraser  <simon.fraser@apple.com>
4144
4145         [iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar
4146         https://bugs.webkit.org/show_bug.cgi?id=158714
4147
4148         Reviewed by Enrica Casucci.
4149
4150         Add UIScriptController.keyboardAccessoryBar{Next,Previous} and hook it up to the WKContentView
4151         method that gets called from UIKit.
4152
4153         Add a test that exercises it.
4154
4155         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
4156         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
4157         (WTR::UIScriptController::keyboardAccessoryBarNext):
4158         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
4159         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
4160         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4161         (WTR::UIScriptController::keyboardAccessoryBarNext):
4162         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
4163
4164 2016-06-15  Sam Weinig  <sam@webkit.org>
4165
4166         Improve HashMap and HashSet support for Ref
4167         https://bugs.webkit.org/show_bug.cgi?id=158789
4168
4169         Reviewed by Chris Dumez.
4170
4171         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4172         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4173         Add more cases to WTF_HashMap.Ref_Key, WTF_HashMap.Ref_Value and WTF_HashSet.Ref
4174
4175 2016-06-15  Aakash Jain  <aakash_jain@apple.com>
4176
4177         Too much log data generated during layout-tests on iOS Simulator
4178         https://bugs.webkit.org/show_bug.cgi?id=158751
4179
4180         Reviewed by Alexey Proskuryakov.
4181
4182         * Scripts/webkitpy/port/ios.py:
4183         (IOSSimulatorPort.developer_dir): memoized the property so that it is not called
4184         repeatedly.
4185
4186 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
4187
4188         [Win][CMake] Changes in WebKit options are not reflected in incremental builds.
4189         https://bugs.webkit.org/show_bug.cgi?id=158727
4190
4191         Reviewed by Alex Christensen.
4192
4193         Delete CMake cache file if WebKit options have been modified.
4194
4195         * Scripts/build-webkit:
4196         * Scripts/webkitdirs.pm:
4197         (shouldRemoveCMakeCache):
4198
4199 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
4200
4201         Enabling Shadow DOM for all platforms
4202         https://bugs.webkit.org/show_bug.cgi?id=158738
4203
4204         Reviewed by Ryosuke Niwa.
4205
4206         Removed Shadow DOM from options (enabled by default)
4207
4208         * Scripts/webkitperl/FeatureList.pm:
4209         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4210
4211 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
4212
4213         [Win] The test accessibility/selected-text-range-aria-elements.html is failing.
4214         https://bugs.webkit.org/show_bug.cgi?id=158732
4215
4216         Reviewed by Brent Fulgham.
4217
4218         Implement selectedTextRange() method.
4219
4220         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4221         (AccessibilityUIElement::selectedTextRange):
4222
4223 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
4224
4225         [Win] MiniBrowser is not DPI aware.
4226         https://bugs.webkit.org/show_bug.cgi?id=158733
4227
4228         Reviewed by Brent Fulgham.
4229
4230         Call Win32 api function to let Windows know that we will scale the contents ourselves.
4231
4232         * MiniBrowser/win/WinMain.cpp:
4233         (wWinMain):
4234
4235 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
4236
4237         Unreviewed: add new email address to contributors.json.
4238
4239         * Scripts/webkitpy/common/config/contributors.json:
4240
4241 2016-06-14  Keith Miller  <keith_miller@apple.com>
4242
4243         JSBench should use geometric mean
4244         https://bugs.webkit.org/show_bug.cgi?id=158775
4245
4246         Reviewed by Mark Lam.
4247
4248         For some reason JSBench was using algebraic mean. Since each test
4249         is pretty substantially different it should use geometric mean
4250         instead.
4251
4252         * Scripts/run-jsc-benchmarks:
4253
4254 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
4255
4256         Debug crash logs are not fully symbolicated on Yosemite
4257         https://bugs.webkit.org/show_bug.cgi?id=158760
4258
4259         Reviewed by Darin Adler.
4260
4261         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
4262         for debug builds on Yosemite.
4263
4264 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
4265
4266         Tests don't work in iOS Simulator when ASan is enabled
4267         https://bugs.webkit.org/show_bug.cgi?id=158726
4268
4269         Reviewed by David Kilzer.
4270
4271         * Scripts/webkitpy/port/driver.py:
4272         (Driver._setup_environ_for_driver): Added a FIXME.
4273         * Scripts/webkitpy/port/ios.py:
4274         (IOSSimulatorPort.setup_environ_for_server): Don't try to insert a dylib built for
4275         simulator into LayoutTestRelay, which is a macOS tool.
4276
4277 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
4278
4279         Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly
4280         https://bugs.webkit.org/show_bug.cgi?id=158756
4281
4282         Reviewed by Alexey Proskuryakov.
4283
4284         * Scripts/webkitpy/xcode/simulator.py:
4285         (Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if
4286         the "simulator device" is still in booted state. Since we ensured that simulator device 
428