[ews-build] Reassign bots to queues
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-build] Reassign bots to queues
4
5         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
6
7 2019-04-02  Chris Dumez  <cdumez@apple.com>
8
9         [WK2] Add support for Window's beforeprint / afterprint events
10         https://bugs.webkit.org/show_bug.cgi?id=196478
11
12         Reviewed by Alex Christensen.
13
14         Add minimal implementation for printFrame in WebKitTestRunner.
15
16         * WebKitTestRunner/TestController.cpp:
17         (WTR::printFrame):
18         (WTR::TestController::createOtherPage):
19         (WTR::TestController::createWebViewWithOptions):
20
21 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
22
23         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
24         https://bugs.webkit.org/show_bug.cgi?id=196491
25
26         Reviewed by Lucas Forschler.
27
28         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
29
30 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
31
32         [ews-build] Configure buildbot try credentials in environment variables
33         https://bugs.webkit.org/show_bug.cgi?id=196501
34
35         Reviewed by Lucas Forschler.
36
37         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
38         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
39         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
40
41 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
42
43         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
44         https://bugs.webkit.org/show_bug.cgi?id=196496
45         <rdar://problem/49521634>
46
47         Reviewed by Chris Dumez.
48
49         Add new API tests (see WebKit ChangeLog for more detail).
50
51         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
52         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
53         (TEST):
54
55 2019-04-02  David Kilzer  <ddkilzer@apple.com>
56
57         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
58         <https://webkit.org/b/196499>
59
60         Reviewed by Alexey Proskuryakov.
61
62         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
63         ENABLE_ADDRESS_SANITIZER.
64
65 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
66
67         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
68         https://bugs.webkit.org/show_bug.cgi?id=182757
69
70         Reviewed by Don Olmstead.
71
72         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
73         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
74
75 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
76
77         run-api-tests: Upload test results
78         https://bugs.webkit.org/show_bug.cgi?id=196323
79         <rdar://problem/49356714>
80
81         Reviewed by Lucas Forschler.
82
83         * Scripts/webkitpy/api_tests/manager.py:
84         (Manager):
85         (Manager.run): Upload results to a results database.
86         * Scripts/webkitpy/api_tests/run_api_tests.py:
87         (parse_args): Add upload arguments.
88         * Scripts/webkitpy/port/base.py:
89         (Port):
90         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
91         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
92         with commits from any other associated repositories.
93         * Scripts/webkitpy/port/device.py:
94         (Device):
95         (Device.build_version): Access build_versoin of underlying platform device.
96         * Scripts/webkitpy/port/ios_simulator_unittest.py:
97         (IOSSimulatorTest):
98         (IOSSimulatorTest.test_configuration_for_upload):
99         * Scripts/webkitpy/port/device_port.py:
100         (DevicePort):
101         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
102         the same as the machine uploading results.
103         * Scripts/webkitpy/port/mac.py:
104         (MacPort):
105         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
106         * Scripts/webkitpy/port/mac_unittest.py:
107         (MacTest):
108         (MacTest.test_configuration_for_upload):
109         * Scripts/webkitpy/xcode/simulated_device.py:
110         (SimulatedDeviceManager._create_device_with_runtime):
111         (SimulatedDevice.__init__): Create simulated device with a build_version.
112         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
113         (test_existing_simulator):
114
115 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
116
117         Remove extra newline characters (Follow-up fix to r243707)
118
119         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
120
121 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
122
123         [ews-app] Use API_KEY to accept results data
124         https://bugs.webkit.org/show_bug.cgi?id=196461
125
126         Reviewed by Dewei Zhu.
127
128         * BuildSlaveSupport/ews-app/ews/views/results.py:
129         (Results.post): Validate EWS_API_KEY before accepting any data.
130         * BuildSlaveSupport/ews-build/events.py:
131         (Events.sendData): Send EWS_API_KEY if available along with event data.
132
133 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
134
135         Unable to copy and paste a PDF from Notes into Mail compose body
136         https://bugs.webkit.org/show_bug.cgi?id=196442
137         <rdar://problem/48573098>
138
139         Reviewed by Tim Horton.
140
141         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
142         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
143         to be specified on the item providers.
144
145         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
146         (TestWebKitAPI::mapItemForTesting):
147         (TestWebKitAPI::contactItemForTesting):
148
149 2019-04-01  Tim Horton  <timothy_horton@apple.com>
150
151         Make UIWKDocumentContext rects per-character instead of per-word
152         https://bugs.webkit.org/show_bug.cgi?id=196459
153
154         Reviewed by Wenson Hsieh.
155
156         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
157         (TEST):
158         Adjust test results due to switching to per-character rects.
159
160 2019-04-01  Chris Dumez  <cdumez@apple.com>
161
162         UIProcess crash when a prewarmed process is terminated
163         https://bugs.webkit.org/show_bug.cgi?id=196451
164         <rdar://problem/49245471>
165
166         Reviewed by Geoffrey Garen.
167
168         Add API test coverage.
169
170         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
171         (TEST):
172
173 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
174
175         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
176         https://bugs.webkit.org/show_bug.cgi?id=196449
177
178         Reviewed by Lucas Forschler.
179
180         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
181         (StatusBubble.get_os_details): Method to get OS and Xcode details.
182         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
183         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
184
185 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
186
187         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
188         https://bugs.webkit.org/show_bug.cgi?id=196444
189
190         Reviewed by Lucas Forschler.
191
192         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
193
194 2019-04-01  Alex Christensen  <achristensen@webkit.org>
195
196         Add SPI to canonicalize NSURLs with WTF::URL
197         https://bugs.webkit.org/show_bug.cgi?id=196415
198         <rdar://problem/44980271>
199
200         Reviewed by Darin Adler.
201
202         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
203         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
204         (TestWebKitAPI::TEST):
205
206 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
207
208         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
209         https://bugs.webkit.org/show_bug.cgi?id=196441
210
211         Reviewed by Carlos Garcia Campos.
212
213         Don't cache the wpe_view_backend object that might not exist yet at the
214         time of EventSenderProxy constructor invocation, but instead retrieve
215         that object whenever it's required for event dispatching. This should
216         avoid crashes in this constructor now that it's invoked before any
217         PlatformWindow has been set up (as changed in r243496).
218
219         * WebKitTestRunner/EventSenderProxy.h:
220         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
221         (WTR::viewBackend):
222         (WTR::EventSenderProxy::EventSenderProxy):
223         (WTR::EventSenderProxy::mouseDown):
224         (WTR::EventSenderProxy::mouseUp):
225         (WTR::EventSenderProxy::mouseMoveTo):
226         (WTR::EventSenderProxy::mouseScrollBy):
227         (WTR::EventSenderProxy::keyDown):
228         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
229
230 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
231
232         [Win][WebKit] MiniBrowser should support high DPI display
233         https://bugs.webkit.org/show_bug.cgi?id=196391
234
235         Reviewed by Alex Christensen.
236
237         * MiniBrowser/win/WebKitBrowserWindow.cpp:
238         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
239         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
240         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
241
242 2019-03-31  Sam Weinig  <weinig@apple.com>
243
244         Remove more i386 specific configurations
245         https://bugs.webkit.org/show_bug.cgi?id=196430
246
247         Reviewed by Alexey Proskuryakov.
248
249         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
250         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
251
252 2019-03-31  Andy Estes  <aestes@apple.com>
253
254         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
255         https://bugs.webkit.org/show_bug.cgi?id=196433
256         <rdar://problem/49293305>
257
258         Reviewed by Tim Horton.
259
260         Enhanced API test coverage to include all navigation response policy decisions in both
261         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
262
263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
264         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
265         (TestWebKitAPI::TEST):
266         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
267         (readFile):
268         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
269         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
270         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
271         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
272         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
273         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
274         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
275         (-[QuickLookDelegate _downloadDidStart:]):
276         (-[QuickLookDelegate _download:didReceiveResponse:]):
277         (-[QuickLookDelegate _download:didReceiveData:]):
278         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
279         (-[QuickLookDelegate _downloadDidFinish:]):
280         (-[QuickLookDelegate _download:didFailWithError:]):
281         (-[QuickLookDelegate _downloadDidCancel:]):
282         (-[QuickLookDelegate verifyDownload]):
283         (runTest):
284         (runTestDecideBeforeLoading):
285         (runTestDecideAfterLoading):
286         (TEST):
287         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
288         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
289         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
290         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
291         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
292         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
293         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
294         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
295         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
296         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
297         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
298         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
299         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
300         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
301
302 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
303
304         [CMake] add testdfg as target with build-jsc
305         https://bugs.webkit.org/show_bug.cgi?id=196393
306
307         Reviewed by Saam Barati.
308
309         Added testdfg as one of the targets to build when
310         using CMake.
311
312         * Scripts/build-jsc:
313
314 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
315
316         Delete WebMetal implementation in favor of WebGPU
317         https://bugs.webkit.org/show_bug.cgi?id=195418
318
319         Reviewed by Dean Jackson.
320
321         * DumpRenderTree/mac/DumpRenderTree.mm:
322         (enableExperimentalFeatures):
323         (resetWebPreferencesToConsistentValues):
324         * Scripts/webkitperl/FeatureList.pm:
325         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
327         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
328         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
329         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
330         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
331         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
332         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
333         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
334         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
335         (WTR::InjectedBundle::beginTesting):
336         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
337         (WTR::TestRunner::setWebMetalEnabled): Deleted.
338         * WebKitTestRunner/InjectedBundle/TestRunner.h:
339
340 2019-03-29  Chris Dumez  <cdumez@apple.com>
341
342         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
343         https://bugs.webkit.org/show_bug.cgi?id=196405
344         <rdar://problem/49428130>
345
346         Reviewed by Wenson Hsieh.
347
348         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
349         the popover presentation methods to be no-ops. Use this in the new test added in
350         r243523 so that we do not swizzle those methods for all tests. This is needed because
351         those WatchOS tests rely on the popover getting presented and interactive.
352
353         * WebKitTestRunner/TestController.cpp:
354         (WTR::updateTestOptionsFromTestHeader):
355         * WebKitTestRunner/TestController.h:
356         * WebKitTestRunner/TestOptions.h:
357         (WTR::TestOptions::hasSameInitializationOptions const):
358         * WebKitTestRunner/ios/TestControllerIOS.mm:
359         (WTR::TestController::platformInitialize):
360         (WTR::TestController::platformResetStateToConsistentValues):
361
362 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
363
364         [Curl] Add Server Trust Evaluation Support.
365         https://bugs.webkit.org/show_bug.cgi?id=191646
366
367         Reviewed by Fujii Hironori.
368
369         Implemented MiniBrowser UI for asking if user trusts the server.
370
371         * MiniBrowser/win/Common.cpp:
372         (askServerTrustEvaluation):
373         (replaceString):
374         * MiniBrowser/win/Common.h:
375         * MiniBrowser/win/MiniBrowserLib.rc:
376         * MiniBrowser/win/MiniBrowserLibResource.h:
377         * MiniBrowser/win/WebKitBrowserWindow.cpp:
378         (createPEMString):
379         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
380         (WebKitBrowserWindow::canTrustServerCertificate):
381         * MiniBrowser/win/WebKitBrowserWindow.h:
382
383 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
384
385         Implement ResizeObserver.
386         https://bugs.webkit.org/show_bug.cgi?id=157743
387
388         Reviewed by Simon Fraser.
389
390         Support resizeObserverEnabled webPreferences.
391
392         * DumpRenderTree/TestOptions.cpp:
393         (TestOptions::TestOptions):
394         * DumpRenderTree/TestOptions.h:
395         * DumpRenderTree/mac/DumpRenderTree.mm:
396         (setWebPreferencesForTestOptions):
397         * DumpRenderTree/win/DumpRenderTree.cpp:
398         (enableExperimentalFeatures):
399         * Scripts/webkitperl/FeatureList.pm:
400         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
401
402 2019-03-28  John Wilander  <wilander@apple.com>
403
404         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
405         https://bugs.webkit.org/show_bug.cgi?id=196281
406         <rdar://problem/48938748>
407
408         Reviewed by Alex Christensen.
409
410         This patch adds the function isStatisticsHasLocalStorage() to the
411         TestRunner. With it, the page can query the WebsiteDataStore in the
412         UI process to make sure that it sees LocalStorage.
413
414         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
415         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
416         (WTR::TestRunner::isStatisticsHasLocalStorage):
417         * WebKitTestRunner/InjectedBundle/TestRunner.h:
418         * WebKitTestRunner/TestController.cpp:
419         (WTR::TestController::isStatisticsHasLocalStorage):
420         * WebKitTestRunner/TestController.h:
421         * WebKitTestRunner/TestInvocation.cpp:
422         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
423
424 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
425
426         API::Data::createWithoutCopying should do a null check before calling CFRelease
427         https://bugs.webkit.org/show_bug.cgi?id=196276
428         <rdar://problem/48059859>
429
430         Reviewed by Alex Christensen.
431
432         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
433
434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
435         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
436         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
437         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
438         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
439         (TestWebKitAPI::TEST):
440
441 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
442
443         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
444         https://bugs.webkit.org/show_bug.cgi?id=186276
445
446         Reviewed by Carlos Garcia Campos.
447
448         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
449         (webViewLoadChanged):
450         (testWebResourceGetDataError):
451         (testWebResourceGetDataEmpty):
452         (beforeAll):
453         (webViewloadChanged): Deleted.
454
455 2019-03-27  Andy Estes  <aestes@apple.com>
456
457         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
458         https://bugs.webkit.org/show_bug.cgi?id=196317
459
460         Reviewed by Dan Bernstein.
461
462         package-root copies built products into a staging directory using ditto(1), which does not
463         follow symbolic links as it traverses a directory. Now that the files in
464         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
465         itself, these become broken links when ditto'd into the staging directory.
466
467         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
468
469         * Scripts/package-root:
470
471 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
472
473         [ews-app] Update display text of Submit for ews analysis
474         https://bugs.webkit.org/show_bug.cgi?id=196309
475
476         Reviewed by Dewei Zhu.
477
478         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
479
480 2019-03-27  David Kilzer  <ddkilzer@apple.com>
481
482         run-webkit-tests should check for leaks in WebKit processes
483         <https://webkit.org/b/193772>
484         <rdar://problem/46526680>
485
486         Reviewed by Ryosuke Niwa.
487
488         This works by doing the following:
489         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
490           The list of child processes are returned one per line:
491           process.name: pid
492         - Run the "#LIST CHILD PROCESSES" command just before the
493           "#CHECK FOR WORLD LEAKS" command, and store the list of child
494           processes on the ServerProcess object.
495         - When the `--leaks` switch is handled, run check_for_leaks() on
496           each child process after the main test harness.
497
498         * DumpRenderTree/mac/DumpRenderTree.mm:
499         (handleControlCommand):
500         - Use strncmp() instead of strcmp().
501         - Add support for handling "#LIST CHILD PROCESSES" command.
502
503         * Scripts/webkitpy/port/base.py:
504         (Port.check_for_leaks):
505         * Scripts/webkitpy/port/darwin.py:
506         (DarwinPort.check_for_leaks):
507         - Rename redundant 'process_pid' argument to 'process_id'.
508
509         * Scripts/webkitpy/port/driver.py:
510         (Driver.do_post_tests_work):
511         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
512           longer the only command this sends to WebKitTestRunner.
513         - If the `--leaks` switch is present, send the
514           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
515           result using Port.set_webkit_processes().
516         (Driver._parse_child_processes_output):
517         - Add helper method to parse list of child process names and
518           process IDs returned from WebKitTestRunner.
519
520         * Scripts/webkitpy/port/ios_device.py:
521         (IOSDevicePort.check_for_leaks):
522         - Rename redundant 'process_pid' argument to 'process_id'.
523
524         * Scripts/webkitpy/port/leakdetector.py:
525         (LeakDetector._parse_leaks_output):
526         - Return early if there is no leaks_output.
527         (LeakDetector.check_for_leaks):
528         - Rename redundant 'process_pid' argument to 'process_id'.
529
530         * Scripts/webkitpy/port/server_process.py:
531         (ServerProcess.__init__):
532         (ServerProcess.child_processes):
533         (ServerProcess.set_child_processes):
534         - Add instance variable to Port to store list of child process
535           names and process IDs returned from WebKitTestRunner.
536         (ServerProcess._start):
537         - Clear self._child_processes.
538         (ServerProcess.stop):
539         - If self._child_processes is set, call
540           self._port.check_for_leaks() for each child process.
541
542         * Scripts/webkitpy/port/server_process_unittest.py:
543         (TrivialMockPort.check_for_leaks):
544         - Rename redundant 'process_pid' argument to 'process_id'.
545
546         * Scripts/webkitpy/port/simulator_process.py:
547         (SimulatorProcess.stop):
548         - If self._child_processes is set, call
549           self._port.check_for_leaks() for each child process.
550
551         * Scripts/webkitpy/port/watch_device.py:
552         (WatchDevicePort.check_for_leaks):
553         - Rename redundant 'process_pid' argument to 'process_id'.
554
555         * WebKitTestRunner/TestController.cpp:
556         (WTR::TestController::dumpResponse):
557         - Extract method from findAndDumpWorldLeaks() so that it may be
558           reused by findAndDumpWebKitProcessIdentifiers().
559         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
560         - Add method to output process name and process ID of both the
561           WebContent and Networking processes.
562         (WTR::TestController::findAndDumpWorldLeaks):
563         - Fix missing newline in output when there were no abandoned
564           documents.
565         - Call dumpResponse() for extracted code.
566         (WTR::TestController::handleControlCommand):
567         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
568         - Use strncmp() instead of strcmp().
569         - Call findAndDumpWebKitProcessIdentifiers() when
570           "#LIST CHILD PROCESSES" command is sent.
571         * WebKitTestRunner/TestController.h:
572         (WTR::TestController::dumpResponse):
573         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
574         - Declare methods.
575
576 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
577
578         Unreviewed. Add GLib API test cases after r243434.
579
580         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
581         (testWebViewActiveURI):
582         (serverCallback):
583         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
584         (sendRequestCallback):
585
586 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
587
588         Geolocation request not complete when watch request was started in a different web process
589         https://bugs.webkit.org/show_bug.cgi?id=195996
590
591         Reviewed by Alex Christensen.
592
593         Add a test case.
594
595         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
596         (TestWebKitAPI::runJavaScriptAlert):
597         (TestWebKitAPI::TEST):
598
599 2019-03-26  Keith Rollin  <krollin@apple.com>
600
601         Update the way generate-xcfilelists returns strings from functions
602         https://bugs.webkit.org/show_bug.cgi?id=195975
603         <rdar://problem/49040807>
604
605         Reviewed by Dean Jackson.
606
607         There are places where generate-xcfilelists executes assignments with
608         statements like:
609
610             FOO=$(some_function)
611
612         where "some_function" return a string by echoing it. E.g.
613
614             some_function()
615             {
616                 echo "Hello, World"
617             }
618
619         This is a common idiom, but it has a problem if "some_function" needs
620         to call "exit" in an attempt to halt the entire script right then and
621         there. Since "some_function" is called inside of $(), it's being
622         executed in a sub-shell. Calling exit in that sub-shell simply exits
623         that shell; it doesn't not exit the outer shell in which the main part
624         of the script is still running. As such, the main script keeps
625         executing when the intent was for the script to halt.
626
627         The solution to this is to use a different idiom for returning
628         strings. The one we now is to pass in the name of the variable to
629         receive the string result:
630
631             some_function()
632             {
633                 variable_name=$1
634                 eval $variable_name ="Hello, World"
635             }
636
637         The call site now looks like
638
639             some_function FOO
640
641         Because there's no invocation of a sub-shell, some_function can now
642         call "exit" if it wants to, and the entire script will exit at that
643         point.
644
645         * Scripts/generate-xcfilelists:
646
647 2019-03-26  Chris Dumez  <cdumez@apple.com>
648
649         Add basic layout test coverage for File Picker on iOS
650         https://bugs.webkit.org/show_bug.cgi?id=196265
651
652         Reviewed by Wenson Hsieh.
653
654         Add layout test infrastructure to test the file picker on iOS.
655
656         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
657         (WTR::UIScriptController::dismissFilePicker):
658         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
659         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
660         (WTR::UIScriptController::dismissFilePicker):
661         * TestRunnerShared/UIScriptContext/UIScriptController.h:
662         * WebKitTestRunner/TestController.cpp:
663         (WTR::TestController::createWebViewWithOptions):
664         (WTR::updateTestOptionsFromTestHeader):
665         * WebKitTestRunner/TestOptions.h:
666         (WTR::TestOptions::hasSameInitializationOptions const):
667         * WebKitTestRunner/ios/TestControllerIOS.mm:
668         (overridePresentViewController):
669         (WTR::TestController::platformInitialize):
670         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
671         (WTR::UIScriptController::dismissFilePicker):
672
673 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
674
675         Implement async paste method on UIWKInteractionViewProtocol
676         https://bugs.webkit.org/show_bug.cgi?id=196267
677         <rdar://problem/49236346>
678
679         Reviewed by Tim Horton.
680
681         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
682         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
683         are now a part of all iOS 12 internal SDKs.
684
685         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
686
687         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
688         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
689
690         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
691         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
692         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
693         * TestWebKitAPI/ios/UIKitSPI.h:
694
695 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
696
697         [ews-build] Use PostgreSQL for ews.webkit.org database
698         https://bugs.webkit.org/show_bug.cgi?id=196270
699
700         Reviewed by Lucas Forschler.
701
702         * BuildSlaveSupport/ews-app/ews-app/settings.py:
703
704 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
705
706         [ews] Reset simctl states on reboot
707         https://bugs.webkit.org/show_bug.cgi?id=196260
708
709         Rubber-stamped by Aakash Jain.
710
711         * EWSTools/start-queue-mac.sh:
712
713 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
714
715         [ews-build] Use PostgreSQL for ews-build database
716         https://bugs.webkit.org/show_bug.cgi?id=196229
717
718         Reviewed by Lucas Forschler.
719
720         * BuildSlaveSupport/ews-build/master.cfg:
721
722 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
723
724         [ews-build] Get master_hostname dynamically in master.cfg
725         https://bugs.webkit.org/show_bug.cgi?id=196255
726
727         Reviewed by Lucas Forschler.
728
729         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
730         send events data in test mode.
731
732 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
733
734         [ews-app] Set db_constraint to False for Foreign Keys
735         https://bugs.webkit.org/show_bug.cgi?id=196252
736
737         Reviewed by Lucas Forschler.
738
739         * BuildSlaveSupport/ews-app/ews/models/build.py:
740         * BuildSlaveSupport/ews-app/ews/models/step.py:
741
742 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
743
744         [ews-build] is_test_mode_enabled should default to True
745         https://bugs.webkit.org/show_bug.cgi?id=196248
746
747         Reviewed by Lucas Forschler.
748
749         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
750
751 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
752
753         [ews-app] Add webkitperl to ENABLED_QUEUES
754         https://bugs.webkit.org/show_bug.cgi?id=196253
755
756         Reviewed by Lucas Forschler.
757
758         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
759
760 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
761
762         Address NSWindow sometimes using WebKitTestRunnerEvent too early
763         https://bugs.webkit.org/show_bug.cgi?id=196211
764         rdar://problem/49110552
765
766         Reviewed by Tim Horton.
767
768         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
769         Make sure that EventSenderProxy always exists when running tests. We used to create
770         it when resetting before the first test, which is a bit too late.
771
772         * WebKitTestRunner/TestController.h:
773         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
774         (WTR::TestController::platformCreateWebView):
775         (WTR::TestController::platformCreateOtherPage):
776         (WTR::TestController::finishCreatingPlatformWebView):
777         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
778         (WTR::PlatformWebView::PlatformWebView):
779         Moved some code that made NSWindow use NSEvent during web view creation. We may
780         need to move more if some other case us found, but this is enough for now.
781
782 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
783
784         Unreviewed. Fix typo in GLib geolocation API after r243285.
785
786         gelocation -> geolocation.
787
788         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
789         (testGeolocationManagerWatchPosition):
790
791 2019-03-25  Alex Christensen  <achristensen@webkit.org>
792
793         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
794         https://bugs.webkit.org/show_bug.cgi?id=196213
795
796         Reviewed by Geoff Garen.
797
798         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
799         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
800         (credentialWithIdentityAndKeychainPath):
801         (-[ChallengeDelegate webView:didFinishNavigation:]):
802         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
803         (TestWebKitAPI::TEST):
804
805 2019-03-25  Alex Christensen  <achristensen@webkit.org>
806
807         Expected shouldn't assume its contained types are copyable
808         https://bugs.webkit.org/show_bug.cgi?id=195986
809
810         Reviewed by JF Bastien.
811
812         * TestWebKitAPI/Tests/WTF/Expected.cpp:
813         (TestWebKitAPI::NonCopyable::operator== const):
814         (TestWebKitAPI::NonCopyable::operator!= const):
815         (TestWebKitAPI::TEST):
816
817 2019-03-25  Tim Horton  <timothy_horton@apple.com>
818
819         Remove some now-unnecessary dynamic class lookup
820         https://bugs.webkit.org/show_bug.cgi?id=196237
821
822         Reviewed by Simon Fraser.
823
824         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
825         (makeRequest):
826         (TEST):
827
828 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
829
830         Unreviewed, rolling out r243450.
831
832         AppleWin and WinCairo port builds get broken.
833
834         Reverted changeset:
835
836         "Add test for fix of #196095"
837         https://bugs.webkit.org/show_bug.cgi?id=196097
838         https://trac.webkit.org/changeset/243450
839
840 2019-03-25  Commit Queue  <commit-queue@webkit.org>
841
842         Unreviewed, rolling out r243465.
843         https://bugs.webkit.org/show_bug.cgi?id=196226
844
845         the test doesn't build (Requested by thorton on #webkit).
846
847         Reverted changeset:
848
849         "Do not terminate the NetworkProcess if a third party
850         application sends a NSCredential with a SecIdentityRef"
851         https://bugs.webkit.org/show_bug.cgi?id=196213
852         https://trac.webkit.org/changeset/243465
853
854 2019-03-25  Alex Christensen  <achristensen@webkit.org>
855
856         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
857         https://bugs.webkit.org/show_bug.cgi?id=196213
858
859         Reviewed by Geoff Garen.
860
861         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
862         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
863         (credentialWithIdentityAndKeychainPath):
864         (-[ChallengeDelegate webView:didFinishNavigation:]):
865         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
866         (TestWebKitAPI::TEST):
867
868 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
869
870         [ews-build] Gracefully handle missing patch_id in events
871         https://bugs.webkit.org/show_bug.cgi?id=196216
872
873         Reviewed by Lucas Forschler.
874
875         * BuildSlaveSupport/ews-build/events.py:
876
877 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
878
879         [ews-build] use lz4 compression for improving buildbot performance
880         https://bugs.webkit.org/show_bug.cgi?id=196155
881
882         Reviewed by Lucas Forschler.
883
884         * BuildSlaveSupport/ews-build/master.cfg:
885
886 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
887
888         Pull some API testing helper methods out of TestWKWebView
889         https://bugs.webkit.org/show_bug.cgi?id=196212
890
891         Reviewed by Tim Horton.
892
893         Refactor some more API testing utility methods, so that they can be used in
894         tests that do not use TestWKWebView.
895
896         * TestWebKitAPI/cocoa/TestWKWebView.h:
897         * TestWebKitAPI/cocoa/TestWKWebView.mm:
898         (-[WKWebView loadTestPageNamed:]):
899         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
900         (-[WKWebView synchronouslyLoadHTMLString:]):
901         (-[WKWebView synchronouslyLoadTestPageNamed:]):
902         (-[TestWKWebView loadTestPageNamed:]): Deleted.
903         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
904         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
905         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
906
907 2019-03-25  Jer Noble  <jer.noble@apple.com>
908
909         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
910         https://bugs.webkit.org/show_bug.cgi?id=196097
911
912         Reviewed by Eric Carlson.
913
914         Drive-by bug fix: allow tests to play audio without a user gesture by default.
915
916         * DumpRenderTree/mac/DumpRenderTree.mm:
917         (resetWebPreferencesToConsistentValues):
918         * WebKitTestRunner/TestController.cpp:
919         (WTR::TestController::resetPreferencesToConsistentValues):
920
921 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
922
923         Pull IPadUserInterfaceSwizzler out into a separate header file
924         https://bugs.webkit.org/show_bug.cgi?id=196193
925
926         Reviewed by Anders Carlsson.
927
928         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
929         be used in other API tests.
930
931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
932         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
933         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
934         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
935         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
936         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
937         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
938
939 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
940
941         Remove NavigatorContentUtils in WebCore/Modules
942         https://bugs.webkit.org/show_bug.cgi?id=196070
943
944         Reviewed by Alex Christensen.
945
946         NavigatorContentUtils was to support the custom scheme spec [1].
947         However, in WebKit side, no port has supported the feature in
948         WebKit layer after EFL port was removed. So there has been the
949         only IDL implementation of the NavigatorContentUtils in WebCore.
950         So we don't need to keep the implementation in WebCore anymore.
951
952         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
953
954         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
955
956 2019-03-24  Andy Estes  <aestes@apple.com>
957
958         [watchOS] Remove unused Proximity Networking code
959         https://bugs.webkit.org/show_bug.cgi?id=196188
960
961         Reviewed by Tim Horton.
962
963         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
964         (TEST):
965
966 2019-03-23  Keith Miller  <keith_miller@apple.com>
967
968         Refactor clz/ctz and fix getLSBSet.
969         https://bugs.webkit.org/show_bug.cgi?id=196162
970
971         Reviewed by Saam Barati.
972
973         Add tests for clz, ctz, getLSBSet, and getMSBSet.
974
975         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
976         (TestWebKitAPI::TEST):
977
978 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
979
980         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
981         https://bugs.webkit.org/show_bug.cgi?id=196143
982
983         Reviewed by Michael Catanzaro.
984
985         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
986         directories.
987
988         * Scripts/webkitpy/style/checkers/cpp.py:
989         (check_identifier_name_in_declaration):
990         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
991         (WebKitStyleTest.test_names):
992
993 2019-03-22  Philippe Normand  <pnormand@igalia.com>
994
995         [Flatpak] Manifest expanding fails for qt WPE extension
996         https://bugs.webkit.org/show_bug.cgi?id=196148
997
998         Reviewed by Alex Christensen.
999
1000         * flatpak/flatpakutils.py:
1001         (expand_submodules_recurse): The last recurse manifest expand
1002         iteration might lead to a single module so take it into account
1003         and don't try to recurse further.
1004
1005 2019-03-22  Chris Dumez  <cdumez@apple.com>
1006
1007         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1008         https://bugs.webkit.org/show_bug.cgi?id=195348
1009         <rdar://problem/48622090>
1010
1011         Reviewed by Alex Christensen.
1012
1013         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1014         to NO when test.options().shouldIgnoreMetaViewport is false.
1015
1016         * WebKitTestRunner/ios/TestControllerIOS.mm:
1017         (WTR::TestController::platformConfigureViewForTest):
1018
1019 2019-03-22  Chris Dumez  <cdumez@apple.com>
1020
1021         Prewarmed processes should be usable with any website data store
1022         https://bugs.webkit.org/show_bug.cgi?id=196104
1023
1024         Reviewed by Alex Christensen.
1025
1026         Add API test coverage.
1027
1028         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1029         (runInitialWarmedProcessUsedTest):
1030         (TEST):
1031
1032 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1033
1034         Back out local changes to Alex's Subversion working directory
1035
1036         They were accidentally committed.
1037
1038         * Scripts/webkitpy/common/system/abstractexecutive.py:
1039         (AbstractExecutive.wait_newest):
1040         * Scripts/webkitpy/common/system/executive.py:
1041         (Executive.running_pids):
1042         * Scripts/webkitpy/common/system/executive_mock.py:
1043         (MockExecutive.running_pids):
1044         * Scripts/webkitpy/common/system/executive_unittest.py:
1045         (ExecutiveTest.serial_test_running_pids):
1046         * Scripts/webkitpy/port/darwin.py:
1047         (DarwinPort.check_for_leaks):
1048         * Scripts/webkitpy/port/leakdetector.py:
1049         (LeakDetector.check_for_leaks):
1050         - This was the hack attached to Bug 193772.
1051
1052         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1053         (+[WebKitTestRunnerEvent mouseLocation]):
1054         - This works around a crash on an internal build.
1055
1056 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1057
1058         Fix the build after r243354
1059         https://bugs.webkit.org/show_bug.cgi?id=196138
1060         <rdar://problem/49145951>
1061
1062         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1063         (TEST):
1064         * TestWebKitAPI/ios/UIKitSPI.h:
1065
1066 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1067
1068         Adopt UIWKDocumentContext
1069         https://bugs.webkit.org/show_bug.cgi?id=196040
1070         <rdar://problem/48642440>
1071
1072         Reviewed by Ryosuke Niwa.
1073
1074         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1075         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1076         (makeRequest):
1077         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1078         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1079         (applyStyle):
1080         (TEST):
1081         Add tests for UIWKDocumentContext.
1082
1083         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1084         (TEST):
1085         (recursiveFindWKContentView): Deleted.
1086         * TestWebKitAPI/cocoa/TestWKWebView.h:
1087         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1088         (recursiveFindWKContentView):
1089         (-[TestWKWebView wkContentView]):
1090         * TestWebKitAPI/ios/UIKitSPI.h:
1091         Share the WKContentView finding code between tests.
1092
1093 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1094
1095         [iOS WK2] Turn on async overflow scrolling by default
1096         https://bugs.webkit.org/show_bug.cgi?id=196011
1097         rdar://problem/48453859
1098
1099         Reviewed by Antti Koivisto.
1100         
1101         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1102         since so many basic layout tests have different results when compositing is triggered for
1103         overflow.
1104         
1105         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1106
1107         * WebKitTestRunner/TestController.cpp:
1108         (WTR::TestController::resetPreferencesToConsistentValues):
1109
1110 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1111
1112         [ews-build] Retry API test in case of failures
1113         https://bugs.webkit.org/show_bug.cgi?id=196004
1114
1115         Reviewed by Lucas Forschler.
1116
1117         * BuildSlaveSupport/ews-build/steps.py:
1118         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1119         (CompileWebKitToT.doStepIf): Ditto.
1120         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1121         (ReRunAPITests): Re-run API tests.
1122         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1123         (RunAPITestsWithoutPatch): Run API tests without patch.
1124         (RunAPITestsWithoutPatch.doStepIf):
1125         (RunAPITestsWithoutPatch.hideStepIf):
1126         (RunAPITestsWithoutPatch.evaluateCommand):
1127         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1128         (AnalyzeAPITestsResults.start):
1129         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1130         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1131         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1132         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1133
1134 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1135
1136         [ews-build] Update queues configurations
1137         https://bugs.webkit.org/show_bug.cgi?id=196074
1138
1139         Reviewed by Dewei Zhu.
1140
1141         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1142         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1143
1144 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1145
1146         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1147         https://bugs.webkit.org/show_bug.cgi?id=195680
1148         <rdar://problem/48903534>
1149
1150         Unreviewed infrastructure fix.
1151
1152         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1153         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1154
1155 2019-03-21  Andy Estes  <aestes@apple.com>
1156
1157         [iOS] Apple Pay should be available in documents with no user agent scripts
1158         https://bugs.webkit.org/show_bug.cgi?id=196061
1159         <rdar://problem/48649391>
1160
1161         Reviewed by Brady Eidson.
1162
1163         Added API tests and related infrastructure.
1164
1165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1166         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1167         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1168         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1169         (TestWebKitAPI::TEST):
1170         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1171         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1172         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1173         * TestWebKitAPI/cocoa/TestProtocol.mm:
1174         (-[TestProtocol startLoading]):
1175         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1176         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1177         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1178         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1179
1180 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1181
1182         REGRESSSION (r243297): webkitpy tests broken
1183         https://bugs.webkit.org/show_bug.cgi?id=196108
1184
1185         Reviewed by Aakash Jain.
1186
1187         r243297 updated contributors.json, which broke a few unit tests.
1188
1189         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1190         (IRCCommandTest.test_whois):
1191         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1192
1193 2019-03-21  Chris Dumez  <cdumez@apple.com>
1194
1195         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1196         https://bugs.webkit.org/show_bug.cgi?id=196041
1197         <rdar://problem/49083230>
1198
1199         Reviewed by Alex Christensen.
1200
1201         Add API test coverage.
1202
1203         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1204         (TEST):
1205
1206 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1207
1208         Add SPI to inform applications of WKContentRuleList actions
1209         https://bugs.webkit.org/show_bug.cgi?id=195965
1210         <rdar://problem/42664365>
1211
1212         Reviewed by Geoff Garen.
1213
1214         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1215         (TestWebKitAPI::allActionsForResourceLoad):
1216         (TestWebKitAPI::testRequest):
1217         (TestWebKitAPI::TEST_F):
1218         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1219         (Notification::description):
1220         (Notification::operator== const):
1221         (toVector):
1222         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1223         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1224         (makeContentRuleList):
1225         (TEST):
1226         (makeWarnContentRuleList): Deleted.
1227
1228 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1229
1230         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1231         https://bugs.webkit.org/show_bug.cgi?id=196088
1232
1233         Reviewed by Brian Burg.
1234
1235         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1236         Support checks when only one platform is specified. Also deprecate macosx() and
1237         force the use of macos() instead.
1238
1239         * Scripts/webkitpy/style/checkers/cpp.py:
1240         (check_min_versions_of_wk_api_available):
1241         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1242         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1243
1244 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1245
1246         Update status inactive committers' status to 'contributor'.
1247
1248         * Scripts/webkitpy/common/config/contributors.json:
1249
1250 2019-03-21  Xan Lopez  <xan@igalia.com>
1251
1252         [JSC][x86] Drop support for x87 floating point
1253         https://bugs.webkit.org/show_bug.cgi?id=194853
1254
1255         Reviewed by Don Olmstead.
1256
1257         Force SSE2 on x86/32bit builds.
1258
1259         * Scripts/webkitdirs.pm:
1260         (generateBuildSystemFromCMakeProject):
1261
1262 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1263
1264         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1265         https://bugs.webkit.org/show_bug.cgi?id=196073
1266
1267         Reviewed by Michael Catanzaro.
1268
1269         Add test cases to check functions and constructors with no arguments but receiving user data.
1270
1271         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1272         (checkUserData):
1273         (testJSCFunction):
1274         (fooCreateWithUserData):
1275         (testJSCClass):
1276
1277 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1278
1279         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1280
1281         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1282
1283         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1284
1285 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1286
1287         [GTK][WPE] Add API to provide geolocation information
1288         https://bugs.webkit.org/show_bug.cgi?id=195940
1289
1290         Reviewed by Michael Catanzaro.
1291
1292         Add a new test to check the new API.
1293
1294         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1295         (testGeolocationManagerCurrentPosition):
1296         (testGeolocationManagerWatchPosition):
1297         (beforeAll):
1298         (afterAll):
1299         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1300         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1301         (beforeAll): Ditto.
1302         * TestWebKitAPI/glib/CMakeLists.txt:
1303
1304 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1305
1306         [GLib] Returning G_TYPE_OBJECT from a method does not work
1307         https://bugs.webkit.org/show_bug.cgi?id=195574
1308
1309         Reviewed by Michael Catanzaro.
1310
1311         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1312
1313         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1314         (getGFile):
1315         (getParent):
1316         (createGString):
1317         (getGString):
1318         (getGStringCopyWillRaise):
1319         (getGStringCopy):
1320         (getGStringStr):
1321         (getGStringLen):
1322         (freeGString):
1323         (testJSCClass):
1324
1325 2019-03-20  Saam Barati  <sbarati@apple.com>
1326
1327         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1328         https://bugs.webkit.org/show_bug.cgi?id=195721
1329
1330         Reviewed by Filip Pizlo.
1331
1332         * Scripts/run-javascriptcore-tests:
1333
1334 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1335
1336         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1337         https://bugs.webkit.org/show_bug.cgi?id=196049
1338
1339         Reviewed by Tim Horton.
1340
1341         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1342         overflow scrolling in general, so rename it.
1343
1344         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1345
1346 2019-03-20  Daniel Bates  <dabates@apple.com>
1347
1348         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1349         https://bugs.webkit.org/show_bug.cgi?id=196031
1350         <rdar://problem/49078172>
1351
1352         Reviewed by Tim Horton.
1353
1354         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1355         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1356         same code path used when the Done button is pressed to dismiss the <select> picker.
1357
1358         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1359         (TestWebKitAPI::TEST):
1360
1361 2019-03-20  Chris Dumez  <cdumez@apple.com>
1362
1363         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1364         https://bugs.webkit.org/show_bug.cgi?id=196029
1365         <rdar://problem/48954651>
1366
1367         Reviewed by Tim Horton.
1368
1369         Add API test coverage.
1370
1371         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1372
1373 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1374
1375         [ews-build] Improve failure summary string for ApplyPatch step
1376         https://bugs.webkit.org/show_bug.cgi?id=195995
1377
1378         Reviewed by Alexey Proskuryakov.
1379
1380         * BuildSlaveSupport/ews-build/steps.py:
1381         (ApplyPatch.getResultSummary): Override getResultSummary.
1382
1383 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1384
1385         AX: Implement support for new meter ARIA role
1386         https://bugs.webkit.org/show_bug.cgi?id=195966
1387
1388         Reviewed by Chris Fleizach.
1389
1390         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1391         to AXLevelIndicator.
1392
1393         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1394
1395 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1396
1397         [WebAuthN] Implement FIDO AppID extension
1398         https://bugs.webkit.org/show_bug.cgi?id=143491
1399         <rdar://problem/48298273>
1400
1401         Reviewed by Brent Fulgham.
1402
1403         Add a test that covers the new flag of convertToU2fSignCommand.
1404
1405         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1406         (TestWebKitAPI::TEST):
1407         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1408         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1409         (TestWebKitAPI::TEST):
1410
1411 2019-03-19  Keith Rollin  <krollin@apple.com>
1412
1413         Add support for more platforms to generate-xcfilelists
1414         https://bugs.webkit.org/show_bug.cgi?id=195977
1415
1416         Reviewed by Alexey Proskuryakov.
1417
1418         generate-xcfilelists incorrectly complains when involved with building
1419         WebKit for iphonesimulator:
1420
1421             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1422             …
1423             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1424
1425         Address this by teaching generate-xcfilelists about more platforms.
1426
1427         * Scripts/generate-xcfilelists:
1428
1429 2019-03-19  John Wilander  <wilander@apple.com>
1430
1431         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1432         https://bugs.webkit.org/show_bug.cgi?id=195923
1433         <rdar://problem/49001272>
1434
1435         Reviewed by Alex Christensen.
1436
1437         This patch does the following to the TestRunner:
1438         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1439         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1440         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1441
1442         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1443         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1444         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1445         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1446         * WebKitTestRunner/TestController.cpp:
1447         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1448         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1449         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1450         * WebKitTestRunner/TestController.h:
1451         * WebKitTestRunner/TestInvocation.cpp:
1452         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1453
1454 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1455
1456         [CMake] Support more clang and gcc sanitizers
1457         https://bugs.webkit.org/show_bug.cgi?id=195956
1458
1459         Reviewed by Michael Catanzaro.
1460
1461         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1462
1463 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1464
1465         [ews-build] Improve summary for PrintConfiguration step
1466         https://bugs.webkit.org/show_bug.cgi?id=195945
1467
1468         Reviewed by Lucas Forschler.
1469
1470         * BuildSlaveSupport/ews-build/steps.py:
1471         (PrintConfiguration.getResultSummary): Override getResultSummary.
1472
1473 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1474
1475         [ews-build] Improve summary for CheckOutSource step
1476         https://bugs.webkit.org/show_bug.cgi?id=195963
1477
1478         Reviewed by Lucas Forschler.
1479
1480         * BuildSlaveSupport/ews-build/steps.py:
1481         (CheckOutSource.getResultSummary):
1482
1483 2019-03-19  Daniel Bates  <dabates@apple.com>
1484
1485         [iOS] Focus not preserved when switching between tabs
1486         https://bugs.webkit.org/show_bug.cgi?id=195820
1487         <rdar://problem/43614450>
1488
1489         Reviewed by Brent Fulgham.
1490
1491         Add tests to ensure that we restore focus when resigning and becoming first responder.
1492
1493         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1494         (TestWebKitAPI::TEST):
1495
1496 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1497
1498         Make WTFLogChannelState and WTFLogLevel enum classes
1499         https://bugs.webkit.org/show_bug.cgi?id=195904
1500
1501         Reviewed by Eric Carlson.
1502
1503         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1504         (TestWebKitAPI::TEST_F):
1505
1506 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1507
1508         [GStreamer][EME] Backported mssdemux protection data crash fix
1509         https://bugs.webkit.org/show_bug.cgi?id=195918
1510
1511         Reviewed by Philippe Normand.
1512
1513         * gstreamer/jhbuild.modules:
1514         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1515
1516 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1517
1518         Unreviewed, rolling out r243132.
1519
1520         Broke GTK build
1521
1522         Reverted changeset:
1523
1524         "Make WTFLogChannelState and WTFLogLevel enum classes"
1525         https://bugs.webkit.org/show_bug.cgi?id=195904
1526         https://trac.webkit.org/changeset/243132
1527
1528 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1529
1530         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1531
1532         * Scripts/webkitdirs.pm:
1533         (builtDylibPathForName): Adjust the shared library name that's changed
1534         with the API version bump in r243073.
1535
1536 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1537
1538         Make WTFLogChannelState and WTFLogLevel enum classes
1539         https://bugs.webkit.org/show_bug.cgi?id=195904
1540
1541         Reviewed by Eric Carlson.
1542
1543         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1544         (TestWebKitAPI::TEST_F):
1545
1546 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1547
1548         Disable flaky test added in r2431100
1549         https://webkit.org/b/195785
1550
1551         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1552         (TestWebKitAPI::TEST):
1553         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1554
1555 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1556
1557         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1558         https://bugs.webkit.org/show_bug.cgi?id=195916
1559
1560         Reviewed by Tim Horton.
1561
1562         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1563         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1564
1565 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1566
1567         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1568
1569         * Scripts/webkitpy/common/config/contributors.json:
1570
1571 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1572
1573         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1574         https://bugs.webkit.org/show_bug.cgi?id=195785
1575
1576         Reviewed by Geoffrey Garen.
1577
1578         * TestWebKitAPI/TCPServer.cpp: Added.
1579         (TestWebKitAPI::TCPServer::TCPServer):
1580         (TestWebKitAPI::TCPServer::~TCPServer):
1581         (TestWebKitAPI::TCPServer::socketBindListen):
1582         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1583         * TestWebKitAPI/TCPServer.h: Added.
1584         (TestWebKitAPI::TCPServer::port const):
1585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1586         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1587         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1588         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1589         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1590         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1591         (TestWebKitAPI::respondSlowly):
1592         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1593         (TestWebKitAPI::downloadAtRate):
1594         (TestWebKitAPI::TEST):
1595
1596 2019-03-18  Saam Barati  <sbarati@apple.com>
1597
1598         Add a plan file for JetStream 2
1599         https://bugs.webkit.org/show_bug.cgi?id=190734
1600
1601         Reviewed by Mark Lam.
1602
1603         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1604
1605 2019-03-18  Chris Dumez  <cdumez@apple.com>
1606
1607         Delay WebProcess launch until a load is triggered in a Web view
1608         https://bugs.webkit.org/show_bug.cgi?id=195758
1609         <rdar://problem/48126013>
1610
1611         Reviewed by Geoff Garen.
1612
1613         Add API test coverage. Also update some existing API tests to not expect
1614         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1615
1616         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1617         (TestWebKitAPI::TEST):
1618         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1619         (TestWebKitAPI::TEST):
1620         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1621         (TEST):
1622         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1623         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1624         (TEST):
1625         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1626         (TEST):
1627         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1628
1629 2019-03-18  Xan Lopez  <xan@igalia.com>
1630
1631         [CMake] Prevent potential warning when determining $architecture
1632         https://bugs.webkit.org/show_bug.cgi?id=195891
1633
1634         Reviewed by Michael Catanzaro.
1635
1636         It's possible for generateBuildSystemForCMakeProject to be called
1637         before determineArchitecture() is ever called. This will make the
1638         first eq check with $architecture to be bogus (and print a
1639         warning). Change that to an eq check with architecture(), which
1640         implicitly calls determineArchitecture() if needed, and change all
1641         the other similar cases in the method in the same way to prevent
1642         future bugs like this one.
1643
1644         * Scripts/webkitdirs.pm:
1645         (generateBuildSystemFromCMakeProject):
1646
1647 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1648
1649         [WPE] Tarballs generated with “make dist” cannot build documentation
1650         https://bugs.webkit.org/show_bug.cgi?id=195885
1651
1652         Reviewed by Carlos Garcia Campos.
1653
1654         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1655
1656 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1657
1658         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1659         https://bugs.webkit.org/show_bug.cgi?id=195883
1660
1661         Reviewed by Carlos Garcia Campos.
1662
1663         * gtkdoc/gtkdoc.py:
1664         (GTKDoc._run_command): When commands fail to run, include the full command line for
1665         the program invocation and the output it has generated on the standard error stream.
1666
1667 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1668
1669         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1670         https://bugs.webkit.org/show_bug.cgi?id=195786
1671
1672         Reviewed by Philippe Normand.
1673
1674         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1675         * wpe/jhbuild.modules: Ditto.
1676
1677 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1678
1679         [ews-build] Don't run clean builds on EWS builders
1680         https://bugs.webkit.org/show_bug.cgi?id=195851
1681
1682         Reviewed by Geoffrey Garen.
1683
1684         * BuildSlaveSupport/ews-build/factories.py:
1685
1686 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1687
1688         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1689         https://bugs.webkit.org/show_bug.cgi?id=195849
1690
1691         Reviewed by Chris Dumez.
1692
1693         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1694
1695         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1696         (runWebsiteDataStoreCustomPaths):
1697
1698 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1699
1700         webkitpy: Upload test results
1701         https://bugs.webkit.org/show_bug.cgi?id=195755
1702         <rdar://problem/48896182>
1703
1704         Reviewed by Aakash Jain.
1705
1706         Establish a new format for uploading results that is not tied to layout tests, apply
1707         that format to webkitpy tests.
1708
1709         * Scripts/webkitpy/common/checkout/scm/git.py:
1710         (Git.native_branch): Return what branch the current checkout is on.
1711         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1712         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1713         * Scripts/webkitpy/common/checkout/scm/svn.py:
1714         (SVN.native_branch): Ditto.
1715         * Scripts/webkitpy/common/system/platforminfo.py:
1716         (PlatformInfo.build_version): Return a build version for Mac.
1717         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1718         (MockPlatformInfo.__init__):
1719         (MockPlatformInfo.build_version):
1720         * Scripts/webkitpy/results: Added.
1721         * Scripts/webkitpy/results/__init__.py: Added.
1722         * Scripts/webkitpy/results/options.py: Added.
1723         (upload_options): OptParse list for upload options.
1724         * Scripts/webkitpy/results/upload.py: Added.
1725         (Upload): Class which enforces the upload format expected by the results server.
1726         (Upload.Expectations):
1727         (Upload.create_configuration):
1728         (Upload.create_commit):
1729         (Upload.create_details):
1730         (Upload.create_run_stats):
1731         (Upload.create_test_result):
1732         (Upload.__init__):
1733         (Upload.Encoder): Encode Upload object as json.
1734         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1735         * Scripts/webkitpy/results/upload_unittest.py: Added.
1736         * Scripts/webkitpy/test/main.py:
1737         (Tester._parse_args): Add upload arguments.
1738         (Tester._run_tests): Allow results to be uploaded.
1739         * Scripts/webkitpy/test/runner.py:
1740         (Runner.__init__): Record which tests were run, rather than just counting them.
1741         (Runner.handle):
1742         * Scripts/webkitpy/test/runner_unittest.py:
1743         (RunnerTest.test_run):
1744         * Scripts/webkitpy/thirdparty/__init__.py:
1745         (AutoinstallImportHook.find_module): Add requests auto-install.
1746         (AutoinstallImportHook._install_requests):
1747         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1748         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1749
1750 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1751
1752         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1753         https://bugs.webkit.org/show_bug.cgi?id=195810
1754
1755         Reviewed by Tim Horton.
1756
1757         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1758         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1759         ending certain layout tests.
1760
1761         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1762         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1763         (-[TestRunnerWKWebView dealloc]):
1764         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1765
1766         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1767         helper method when destroying the web view, and when resetting state between tests.
1768
1769         * WebKitTestRunner/ios/TestControllerIOS.mm:
1770         (WTR::TestController::platformResetStateToConsistentValues):
1771
1772         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1773
1774 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1775
1776         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1777         https://bugs.webkit.org/show_bug.cgi?id=190350
1778         <rdar://problem/45089503>
1779
1780         Reviewed by Geoffrey Garen.
1781
1782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1783         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1784         (TEST):
1785         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1786         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1787         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1788         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1789         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1790         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1791         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1792         (runTest):
1793         (createDirectories):
1794         (TEST):
1795         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1796         (TEST):
1797         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1798         (TEST):
1799
1800 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1801
1802         Add support to WebPage for getting the contents as an attributed string.
1803         https://bugs.webkit.org/show_bug.cgi?id=195636
1804         rdar://problem/45055697
1805
1806         Reviewed by Tim Horton.
1807
1808         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1809         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1810
1811 2019-03-15  Chris Dumez  <cdumez@apple.com>
1812
1813         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1814         https://bugs.webkit.org/show_bug.cgi?id=195747
1815
1816         Reviewed by Geoff Garen.
1817
1818         Add API test coverage.
1819
1820         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1821
1822 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1823
1824         Unreviewed, rolling out r242952.
1825
1826         Causing API failures on iOS Simulator
1827
1828         Reverted changeset:
1829
1830         "[PSON] Make sure the WebProcessCache is leverage when
1831         relaunching a process after termination"
1832         https://bugs.webkit.org/show_bug.cgi?id=195747
1833         https://trac.webkit.org/changeset/242952
1834
1835 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1836
1837         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1838         https://bugs.webkit.org/show_bug.cgi?id=195740
1839
1840         Reviewed by Ross Kirsling.
1841
1842         window.open doesn't work for WebKitBrowserWindow because it is not
1843         implemented yet.
1844
1845         1. Implemented createNewPage callback of WKPageUIClient.
1846         2. Changed MainWindow to take a BrowserWindow factory function
1847           instead of BrowserWindowType to be flexible to create
1848           BrowserWindow with extra settings.
1849         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1850           because it is not relevant with MainWindow anymore.
1851
1852         * MiniBrowser/win/Common.cpp:
1853         (parseCommandLine):
1854         * MiniBrowser/win/Common.h:
1855         (CommandLineOptions::CommandLineOptions):
1856         * MiniBrowser/win/MainWindow.cpp:
1857         (MainWindow::MainWindow):
1858         (MainWindow::create):
1859         (MainWindow::init):
1860         (MainWindow::WndProc):
1861         * MiniBrowser/win/MainWindow.h:
1862         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1863         (PrintWebUIDelegate::createWebViewWithRequest):
1864         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1865         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1866         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1867         (WebKitBrowserWindow::updateProxySettings):
1868         (WebKitBrowserWindow::createNewPage):
1869         * MiniBrowser/win/WebKitBrowserWindow.h:
1870         * MiniBrowser/win/WinMain.cpp:
1871         (wWinMain):
1872
1873 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1874
1875         Make it possible to test scrolling tree layer manipulation more easily
1876         https://bugs.webkit.org/show_bug.cgi?id=195780
1877
1878         Reviewed by Tim Horton.
1879         
1880         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1881         cuts off communication of scrolling tree scrolls back to the web process
1882         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1883         allows tests to trigger scrolls which run the scrolling tree layer positioning
1884         logic, but never get another commit from the web process that might mask
1885         scrolling tree bugs.
1886         
1887         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1888         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1889         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1890
1891         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1892         (WTR::UIScriptController::scrollUpdatesDisabled const):
1893         (WTR::UIScriptController::setScrollUpdatesDisabled):
1894         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1895         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1896         (WTR::UIScriptController::scrollUpdatesDisabled const):
1897         (WTR::UIScriptController::setScrollUpdatesDisabled):
1898         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1899         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1900         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1901         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1902         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1903         * WebKitTestRunner/ios/TestControllerIOS.mm:
1904         (WTR::TestController::platformResetStateToConsistentValues):
1905         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1906         (WTR::UIScriptController::scrollUpdatesDisabled const):
1907         (WTR::UIScriptController::setScrollUpdatesDisabled):
1908
1909 2019-03-14  Youenn Fablet  <youenn@apple.com>
1910
1911         Move IDB storage in private browsing mode to NetworkProcess
1912         https://bugs.webkit.org/show_bug.cgi?id=195602
1913
1914         Reviewed by Brady Eidson.
1915
1916         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1917         (TEST):
1918
1919 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1920
1921         [ews-build] Make descriptionDone messages more readable
1922         https://bugs.webkit.org/show_bug.cgi?id=195760
1923
1924         Reviewed by Lucas Forschler.
1925
1926         * BuildSlaveSupport/ews-build/steps.py:
1927         * BuildSlaveSupport/ews-build/steps_unittest.py:
1928
1929 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1930
1931         [ews-build] Generate status-bubble hover-over messages
1932         https://bugs.webkit.org/show_bug.cgi?id=195680
1933
1934         Reviewed by Lucas Forschler.
1935
1936         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1937         (StatusBubble):
1938         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1939         on hover-over.
1940         (StatusBubble._iso_time):
1941         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1942         hover-over message.
1943         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1944
1945 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1946
1947         [ews-app] Gracefully handle the case when state_string is None
1948         https://bugs.webkit.org/show_bug.cgi?id=195753
1949
1950         Reviewed by Lucas Forschler.
1951
1952         * BuildSlaveSupport/ews-app/ews/models/build.py:
1953         * BuildSlaveSupport/ews-app/ews/models/step.py:
1954
1955 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1956
1957         [ews-app] Status bubble display pending for currently running build step
1958         https://bugs.webkit.org/show_bug.cgi?id=195744
1959
1960         Reviewed by Lucas Forschler.
1961
1962         * BuildSlaveSupport/ews-build/events.py:
1963         (Events.stepStarted): If state_string is pending, replace it with step name.
1964
1965 2019-03-14  Chris Dumez  <cdumez@apple.com>
1966
1967         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1968         https://bugs.webkit.org/show_bug.cgi?id=195750
1969
1970         Reviewed by Geoffrey Garen.
1971
1972         Add API test coverage.
1973
1974         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1975         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1976         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1977         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1978
1979 2019-03-14  Chris Dumez  <cdumez@apple.com>
1980
1981         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1982         https://bugs.webkit.org/show_bug.cgi?id=195747
1983
1984         Reviewed by Geoff Garen.
1985
1986         Add API test coverage.
1987
1988         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1989
1990 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1991
1992         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1993         https://bugs.webkit.org/show_bug.cgi?id=195725
1994         <rdar://problem/48545062>
1995
1996         Reviewed by Tim Horton.
1997
1998         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1999         handler is nil.
2000
2001         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2002         (TestWebKitAPI::TEST):
2003
2004 2019-03-13  Sam Weinig  <sam@webkit.org>
2005
2006         Add utility function to allow easy reverse range-based iteration of a container
2007         https://bugs.webkit.org/show_bug.cgi?id=195542
2008
2009         Reviewed by Antti Koivisto.
2010
2011         * TestWebKitAPI/CMakeLists.txt:
2012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2013         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2014         (TestWebKitAPI::TEST):
2015         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2016
2017 2019-03-13  Chris Dumez  <cdumez@apple.com>
2018
2019         Use a ServiceWorker process per registrable domain
2020         https://bugs.webkit.org/show_bug.cgi?id=195649
2021
2022         Reviewed by Youenn Fablet.
2023
2024         Update API test coverage.
2025
2026         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2027
2028 2019-03-13  Chris Dumez  <cdumez@apple.com>
2029
2030         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2031         https://bugs.webkit.org/show_bug.cgi?id=195684
2032         <rdar://problem/48294714>
2033
2034         Reviewed by Antti Koivisto.
2035
2036         Add API test coverage.
2037
2038         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2039
2040 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2041
2042         [ews-app] Remove unused patch view
2043         https://bugs.webkit.org/show_bug.cgi?id=195669
2044
2045         Reviewed by Lucas Forschler.
2046
2047         * BuildSlaveSupport/ews-app/ews/urls.py:
2048         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2049
2050 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2051
2052         [ews-app] Use Buildbot result code variables
2053         https://bugs.webkit.org/show_bug.cgi?id=195668
2054
2055         Reviewed by Alexey Proskuryakov.
2056
2057         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2058         (Buildbot): Added Buildbot result code variables.
2059         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2060         (StatusBubble._build_bubble): Used Buildbot result code variables.
2061
2062 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2063
2064         [Flatpak] Expand submodule recursively
2065         https://bugs.webkit.org/show_bug.cgi?id=195672
2066
2067         Building WPE with flatpak was impossible without that as it was raising an exception.
2068         Also update wpebackend-fdo to match what is built in jhbuild
2069
2070         Reviewed by Philippe Normand.
2071
2072         * flatpak/flatpakutils.py:
2073         (expand_submodules_recurse):
2074         (expand_manifest):
2075         * flatpak/org.webkit.WPEModules.yaml:
2076
2077 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2078
2079         [ews-app] status bubble should be hidden for certain builds
2080         https://bugs.webkit.org/show_bug.cgi?id=194597
2081
2082         Reviewed by Dewei Zhu.
2083
2084         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2085         (StatusBubble._build_bubble):
2086         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2087         because the patch didn't have relevant changes.
2088         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2089         in production yet.
2090
2091 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2092
2093         [Win] Fix a slew of simple clang-cl warnings.
2094         https://bugs.webkit.org/show_bug.cgi?id=195652
2095
2096         Reviewed by Don Olmstead.
2097
2098         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2099         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2100
2101 2019-03-12  Justin Fan  <justin_fan@apple.com>
2102
2103         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2104         https://bugs.webkit.org/show_bug.cgi?id=195518
2105         <rdar://problem/46322356>
2106
2107         Reviewed by Myles C. Maxfield.
2108
2109         * DumpRenderTree/DerivedSources-input.xcfilelist:
2110         * DumpRenderTree/DerivedSources-output.xcfilelist:
2111
2112 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2113
2114         Unreviewed, rolling out r242825.
2115         https://bugs.webkit.org/show_bug.cgi?id=195648
2116
2117         "Broke webkitpy tests with my change to
2118         lldb_dump_class_layout.py" (Requested by rmorisset on
2119         #webkit).
2120
2121         Reverted changeset:
2122
2123         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2124         classes with suspicious padding"
2125         https://bugs.webkit.org/show_bug.cgi?id=195573
2126         https://trac.webkit.org/changeset/242825
2127
2128 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2129
2130         [ews-build] Show status bubbles while the patch is waiting in queue
2131         https://bugs.webkit.org/show_bug.cgi?id=195618
2132
2133         Reviewed by Lucas Forschler.
2134
2135         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2136         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2137         enabled in initial deployment.
2138         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2139         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2140         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2141         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2142         (StatusBubble._build_bubbles_for_patch):
2143
2144 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2145
2146         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2147         https://bugs.webkit.org/show_bug.cgi?id=195573
2148
2149         Reviewed by Simon Fraser.
2150
2151         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2152
2153         * Scripts/dump-class-layout:
2154         (main):
2155         * lldb/lldb_dump_class_layout.py:
2156         (ClassLayout.__init__):
2157         (ClassLayout._compute_padding_recursive):
2158         (LLDBDebuggerInstance.dump_layout_for_classname):
2159         (LLDBDebuggerInstance):
2160         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2161         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2162
2163 2019-03-12  Chris Dumez  <cdumez@apple.com>
2164
2165         Device Orientation access permission should be denied unless explicitly granted by the client
2166         https://bugs.webkit.org/show_bug.cgi?id=195625
2167
2168         Reviewed by Youenn Fablet.
2169
2170         add API test coverage.
2171
2172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2173         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2174         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2175         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2176         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2177         (runDeviceOrientationTest):
2178         (TEST):
2179         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2180         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2181
2182 2019-03-12  Jer Noble  <jer.noble@apple.com>
2183
2184         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2185         https://bugs.webkit.org/show_bug.cgi?id=195137
2186         <rdar://problem/48810307>
2187
2188         Reviewed by Eric Carlson.
2189
2190         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2191         (TestWebKitAPI::TEST):
2192
2193 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2194
2195         [ews-build] Change urls from uat to production
2196         https://bugs.webkit.org/show_bug.cgi?id=195566
2197
2198         Reviewed by Lucas Forschler.
2199
2200         * BuildSlaveSupport/ews-app/ews/config.py:
2201         * BuildSlaveSupport/ews-build/events.py:
2202         * BuildSlaveSupport/ews-build/steps.py:
2203
2204 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2205
2206         [ews-build] change max_builds for local-worker to 1
2207         https://bugs.webkit.org/show_bug.cgi?id=195568
2208
2209         Reviewed by Lucas Forschler.
2210
2211         * BuildSlaveSupport/ews-build/loadConfig.py:
2212
2213 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2214
2215         Fix the build
2216
2217         * TestRunnerShared/spi/PencilKitTestSPI.h:
2218         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2219
2220 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2221
2222         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2223         https://bugs.webkit.org/show_bug.cgi?id=194131
2224
2225         Reviewed by Michael Catanzaro.
2226
2227         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2228         (uriChanged):
2229         (testUnfinishedSubresourceLoad):
2230         (serverCallback):
2231         (beforeAll):
2232
2233 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2234
2235         WTF::Expected should use std::addressof instead of operator&
2236         https://bugs.webkit.org/show_bug.cgi?id=195604
2237
2238         Reviewed by Myles Maxfield.
2239
2240         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2241         (TestWebKitAPI::Unique::Unique):
2242         (TestWebKitAPI::Unique::operator&):
2243         (TestWebKitAPI::TEST):
2244
2245 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2246
2247         Add Optional to Forward.h.
2248         https://bugs.webkit.org/show_bug.cgi?id=195586
2249
2250         Reviewed by Darin Adler.
2251
2252         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2253         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2254         Remove unnecessary includes from headers.
2255
2256 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2257
2258         Add testing API to hit-test and scroll overflow scrollers
2259         https://bugs.webkit.org/show_bug.cgi?id=195278
2260
2261         Reviewed by Antti Koivisto.
2262         
2263         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2264         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2265         
2266         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2267
2268         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2269         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2270         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2271         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2272         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2273         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2274         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2275         (WTR::enclosingScrollViewIncludingSelf):
2276         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2277
2278 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2279
2280         API test WebKit.RequestTextInputContext fails on iOS
2281         https://bugs.webkit.org/show_bug.cgi?id=195585
2282
2283         Reviewed by Wenson Hsieh and Simon Fraser.
2284
2285         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2286         (applyStyle):
2287         (TEST):
2288         Add a viewport, so that the coordinates match up on iOS.
2289         Scroll by moving the UIScrollView's contentOffset.
2290
2291 2019-03-11  Chris Dumez  <cdumez@apple.com>
2292
2293         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2294         https://bugs.webkit.org/show_bug.cgi?id=195506
2295         <rdar://problem/48733477>
2296
2297         Reviewed by Alex Christensen.
2298
2299         Add API test coverage.
2300
2301         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2302
2303 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2304
2305         Adding myself to contributors.json
2306
2307         Unreviewed, addming myself to contributors.json .
2308
2309         * Scripts/webkitpy/common/config/contributors.json:
2310
2311 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2312
2313         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2314         https://bugs.webkit.org/show_bug.cgi?id=195511
2315         <rdar://problem/44873269>
2316
2317         Reviewed by Darin Adler.
2318
2319         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2320         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2321         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2322         (TEST_F):
2323
2324 2019-03-11  Chris Dumez  <cdumez@apple.com>
2325
2326         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2327         https://bugs.webkit.org/show_bug.cgi?id=195561
2328
2329         Reviewed by Youenn Fablet.
2330
2331         Make sure the JS in the test requests for permission to receive device orientation events.
2332
2333         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2334
2335 2019-03-11  Youenn Fablet  <youenn@apple.com>
2336
2337         Allow storage quota increase by default in WTR
2338         https://bugs.webkit.org/show_bug.cgi?id=195541
2339
2340         Reviewed by Geoffrey Garen.
2341
2342         Allow storage quota increase by default in WTR.
2343         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2344         Use this for tests that explicitly need cache increase.
2345
2346         Instead of increasing quota by 2, make sure the next request is
2347         granted by adding all given parameters.
2348
2349         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2350         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2351         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2352         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2353         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2354         * WebKitTestRunner/TestController.cpp:
2355         (WTR::TestController::setAllowStorageQuotaIncrease):
2356         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2357         * WebKitTestRunner/TestController.h:
2358         * WebKitTestRunner/TestInvocation.cpp:
2359         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2360         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2361         (WTR::TestController::cocoaResetStateToConsistentValues):
2362         (WTR::TestController::setAllowStorageQuotaIncrease):
2363         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2364         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2365         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2366
2367 2019-03-11  Xan Lopez  <xan@igalia.com>
2368
2369         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2370         https://bugs.webkit.org/show_bug.cgi?id=194147
2371
2372         Reviewed by Michael Saboff.
2373
2374         To make --32-bit work correctly on Linux/64bit we need to:
2375
2376         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2377         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2378         unfortunately CMake only allows us to do this during
2379         crosscompilation, which is overkill here.
2380         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2381         pkg-config detection module uses the x86 .pc files instead of the
2382         x86_64 ones.
2383         - Set the -m32 flags for the compiler.
2384
2385         * Scripts/webkitdirs.pm:
2386         (generateBuildSystemFromCMakeProject):
2387
2388 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2389
2390         Add MotionMark-1.1 plan file for run-benchmark script.
2391         https://bugs.webkit.org/show_bug.cgi?id=195481
2392
2393         Rubber-stamped by Darin Adler.
2394
2395         Run-benchmark script should support MontionMark-1.1.
2396
2397         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2398
2399 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2400
2401         [ews-app] Add support for submit-to-ews url
2402         https://bugs.webkit.org/show_bug.cgi?id=195477
2403
2404         Reviewed by Lucas Forschler.
2405
2406         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2407         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2408         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2409         * BuildSlaveSupport/ews-app/ews/urls.py:
2410         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2411
2412 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2413
2414         Unreviewed, rolling out r242688, r242643, r242624.
2415
2416         Caused multiple layout test failures and crashes on iOS and macOS.
2417
2418         Reverted changeset:
2419
2420         "requestAnimationFrame should execute before the next frame"
2421         https://bugs.webkit.org/show_bug.cgi?id=177484
2422         https://trac.webkit.org/changeset/242624/webkit
2423
2424         * Tracing/SystemTracePoints.plist:
2425
2426 2019-03-11  John Wilander  <wilander@apple.com>
2427
2428         Resource Load Statistics: Make it possible exclude localhost from classification
2429         https://bugs.webkit.org/show_bug.cgi?id=195474
2430         <rdar://problem/47520577>
2431
2432         Reviewed by Brent Fulgham.
2433
2434         This patch allows for localhost to be excluded from classification and
2435         treatment as a prevalent resource.
2436
2437         The WebKit Tools change adds a new function called
2438         testRunner.setStatisticsIsRunningTest() which can be used to control this
2439         behavior.
2440
2441         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2442         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2443         (WTR::TestRunner::setStatisticsIsRunningTest):
2444         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2445         * WebKitTestRunner/TestController.cpp:
2446         (WTR::TestController::setStatisticsIsRunningTest):
2447         * WebKitTestRunner/TestController.h:
2448         * WebKitTestRunner/TestInvocation.cpp:
2449         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2450
2451 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2452
2453         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2454         https://bugs.webkit.org/show_bug.cgi?id=195560
2455
2456         Reviewed by Lucas Forschler.
2457
2458         * BuildSlaveSupport/ews-build/master.cfg:
2459
2460 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2461
2462         Unreviewed, rolling out r242698.
2463
2464         API test crashes on bots.
2465
2466         Reverted changeset:
2467
2468         "Add a WKContentRuleList variant that uses copied memory
2469         instead of mmap'd shared memory for class A containerized
2470         apps"
2471         https://bugs.webkit.org/show_bug.cgi?id=195511
2472         https://trac.webkit.org/changeset/242698
2473
2474 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2475
2476         [WPE] Enable web process sandbox
2477         https://bugs.webkit.org/show_bug.cgi?id=195169
2478
2479         Reviewed by Daniel Bates.
2480
2481         * wpe/install-dependencies:
2482         * wpe/jhbuild.modules:
2483
2484 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2485
2486         [ews-app] Use port 17000 for worker communication
2487         https://bugs.webkit.org/show_bug.cgi?id=195558
2488
2489         Reviewed by Lucas Forschler.
2490
2491         * BuildSlaveSupport/ews-build/master.cfg:
2492
2493 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2494
2495         [ews-build] unit-tests fail when passwords.json is missing
2496         https://bugs.webkit.org/show_bug.cgi?id=195557
2497
2498         Reviewed by Lucas Forschler.
2499
2500         * BuildSlaveSupport/ews-build/loadConfig.py:
2501         (loadBuilderConfig):
2502         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2503         (ConfigDotJSONTest.test_configuration):
2504         * BuildSlaveSupport/ews-build/master.cfg:
2505
2506 2019-03-11  Truitt Savell  <tsavell@apple.com>
2507
2508         Unreviewed, rolling out r242702.
2509
2510         Broke High Sierra builders.
2511
2512         Reverted changeset:
2513
2514         "Add utility function to allow easy reverse range-based
2515         iteration of a container"
2516         https://bugs.webkit.org/show_bug.cgi?id=195542
2517         https://trac.webkit.org/changeset/242702
2518
2519 2019-03-11  Sam Weinig  <sam@webkit.org>
2520
2521         Add utility function to allow easy reverse range-based iteration of a container
2522         https://bugs.webkit.org/show_bug.cgi?id=195542
2523
2524         Reviewed by Antti Koivisto.
2525
2526         * TestWebKitAPI/CMakeLists.txt:
2527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2528         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2529         (TestWebKitAPI::TEST):
2530         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2531
2532 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2533
2534         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2535         https://bugs.webkit.org/show_bug.cgi?id=195511
2536         <rdar://problem/44873269>
2537
2538         Reviewed by Darin Adler.
2539
2540         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2541         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2542         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2543         (TEST_F):
2544
2545 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2546
2547         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2548         https://bugs.webkit.org/show_bug.cgi?id=195499
2549
2550         Reviewed by Darin Adler.
2551
2552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2553         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2554         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2555         (-[WKWebView synchronouslyFocusTextInputContext:]):
2556         (applyStyle):
2557         (applyIframe):
2558         (TEST):
2559         Add some tests for this SPI.
2560
2561 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2562
2563         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2564         https://bugs.webkit.org/show_bug.cgi?id=181151
2565
2566         Reviewed by Don Olmstead.
2567
2568         * TestWebKitAPI/CMakeLists.txt:
2569         * TestWebKitAPI/PlatformWin.cmake:
2570         Enable TestWTF RunLoop tests in all platforms.
2571
2572         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2573         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2574         (TestWebKitAPI::DerivedOneShotTimer::fired):
2575         (TestWebKitAPI::TEST):
2576         Only a few platforms support nested RunLoop.
2577
2578         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2579         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2580
2581 2019-03-10  David Quesada  <david_quesada@apple.com>
2582
2583         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2584         https://bugs.webkit.org/show_bug.cgi?id=152480
2585
2586         Reviewed by Chris Dumez.
2587
2588         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2589         there are no additional references to the process pool besides the one held by
2590         the download, waits for the download to finish (in the sense that the
2591         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2592         measure, also check that the process pool has been deallocated at the end of the
2593         test. The test wouldn't be meaningful if the process pool were still alive.
2594
2595         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2596         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2597         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2598             The download will be canceled because the delegate does not implement the
2599             method to decide the download's destination, so this is where we know the
2600             DownloadProxyMap is done with the DownloadProxy.
2601         (TEST):
2602
2603 2019-03-08  Chris Dumez  <cdumez@apple.com>
2604
2605         Add support for Device Orientation / Motion permission API
2606         https://bugs.webkit.org/show_bug.cgi?id=195329
2607         <rdar://problem/47645367>
2608
2609         Reviewed by Geoffrey Garen.
2610
2611         Add test infrastructure to help test the Device Orientation / Motion permission API.
2612
2613         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2614         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2615         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2616         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2617         * WebKitTestRunner/TestController.cpp:
2618         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2619         (WTR::TestController::createWebViewWithOptions):
2620         (WTR::TestController::resetStateToConsistentValues):
2621         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2622         * WebKitTestRunner/TestController.h:
2623         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2624         * WebKitTestRunner/TestInvocation.cpp:
2625         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2626
2627 2019-03-08  Saam barati  <sbarati@apple.com>
2628
2629         Add a compare-results script to compare benchmark results
2630         https://bugs.webkit.org/show_bug.cgi?id=195486
2631         <rdar://problem/48723397>
2632
2633         Reviewed by Geoffrey Garen.
2634
2635         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2636         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2637         to extend it to learn about our other benchmarks.
2638
2639         * Scripts/compare-results: Added.
2640         (readJSONFile):
2641         (detectJetStream2):
2642         (JetStream2Results):
2643         (detectSpeedometer2):
2644         (Speedometer2Results):
2645         (detectPLT5):
2646         (PLT5Results):
2647         (detectBenchmark):
2648         (biggerIsBetter):
2649         (ttest):
2650         (getOptions):
2651         (main):
2652
2653 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2654
2655         Ensure old tab state is cleared between iterations of run-benchmark
2656         https://bugs.webkit.org/show_bug.cgi?id=195393
2657         <rdar://problem/46885583>
2658
2659         Reviewed by Dewei Zhu.
2660
2661         a) ensure the default to restore state is not set
2662         b) terminate Safari correctly
2663         c) Set the system default to ignore Persistent State in Safari
2664
2665         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2666         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2667         (OSXBrowserDriver.prepare_env): 
2668         (OSXBrowserDriver.restore_env):
2669         (OSXBrowserDriver.close_browsers):
2670         (OSXBrowserDriver._terminate_processes):
2671         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2672         (OSXChromeDriver):
2673         (OSXChromeCanaryDriver):
2674         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2675         (OSXFirefoxDriver):
2676         (OSXFirefoxNightlyDriver):
2677         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2678         (OSXSafariDriver):
2679         (OSXSafariDriver.prepare_env):
2680
2681 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2682
2683         [GTK] Several InputMethodFilter tests are failing
2684         https://bugs.webkit.org/show_bug.cgi?id=195408
2685
2686         Reviewed by Carlos Garcia Campos.
2687
2688         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2689         Regressed in r241751.
2690         Hexadecimal values of keycodes are expressed now in upper letters.
2691         Composited characters should be cast to UTF8 strings.
2692
2693         (TestWebKitAPI::TEST):
2694
2695 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2696
2697         [GTK] Make Tools/gtkdoc python3 compatible
2698         https://bugs.webkit.org/show_bug.cgi?id=195359
2699
2700         Reviewed by Carlos Garcia Campos.
2701
2702         * gtkdoc/generate-gtkdoc:
2703         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2704         work with Python 2 and 3.
2705         (get_gtkdoc_module_paths):
2706         The iteritems() was removed in Python 3, so let's use items() that's
2707         available in Python 2 and 3.
2708         (get_generator_for_config):
2709         * gtkdoc/gtkdoc.py:
2710         (GTKDoc._run_command):
2711         The sys.stdout.write() is expecting str in Python 3 and not bytes
2712         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2713         for passing the bytes there.
2714
2715 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2716
2717         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2718         https://bugs.webkit.org/show_bug.cgi?id=195346
2719         <rdar://problem/48667048>
2720
2721         Unreviewed build fix for clang-cl.
2722
2723         * DumpRenderTree/win/DumpRenderTree.cpp:
2724         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2725
2726 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2727
2728         requestAnimationFrame should execute before the next frame
2729         https://bugs.webkit.org/show_bug.cgi?id=177484
2730
2731         Reviewed by Simon Fraser.
2732
2733         Add trace points for the page RenderingUpdate.
2734
2735         * Tracing/SystemTracePoints.plist:
2736
2737 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2738
2739         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2740         https://bugs.webkit.org/show_bug.cgi?id=195353
2741         <rdar://problem/48626394>
2742
2743         Reviewed by Simon Fraser.
2744
2745         * WebKitTestRunner/ios/TestControllerIOS.mm:
2746         (WTR::TestController::platformResetPreferencesToConsistentValues):
2747
2748 2019-03-07  John Wilander  <wilander@apple.com>
2749
2750         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2751         https://bugs.webkit.org/show_bug.cgi?id=195383
2752         <rdar://problem/48570136>
2753
2754         Reviewed by Brent Fulgham.
2755
2756         This patch adds test infrastructure to purge only script-accessible cookies,
2757         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2758
2759         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2760         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2761         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2762         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2763         * WebKitTestRunner/TestController.cpp:
2764         (WTR::TestController::statisticsDeleteCookiesForHost):
2765         * WebKitTestRunner/TestController.h:
2766         * WebKitTestRunner/TestInvocation.cpp:
2767         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2768
2769 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2770
2771         Unreviewed, rolling out r242354.
2772         https://bugs.webkit.org/show_bug.cgi?id=195402
2773
2774         breaks layout tests in all configurations (Requested by
2775         zdobersek on #webkit).
2776
2777         Reverted changeset:
2778
2779         "[WPE] Enable web process sandbox"
2780         https://bugs.webkit.org/show_bug.cgi?id=195169
2781         https://trac.webkit.org/changeset/242354
2782
2783 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2784
2785         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2786         https://bugs.webkit.org/show_bug.cgi?id=195346
2787
2788         Reviewed by Fujii Hironori.
2789
2790         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2791         (TestWebKitAPI::TEST):
2792         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2793
2794         * DumpRenderTree/win/DumpRenderTree.cpp:
2795         (findFontFallback):
2796         (addFontFallbackIfPresent):
2797         (removeFontFallbackIfPresent):
2798         (main):
2799         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2800         (TestWebKitAPI::Util::moduleDirectory):
2801         (TestWebKitAPI::Util::createInjectedBundlePath):
2802         Use wchar helpers as needed.
2803
2804 2019-03-06  Rob Buis  <rbuis@igalia.com>
2805
2806         Consider supporting the `referrerpolicy` attribute.
2807         https://bugs.webkit.org/show_bug.cgi?id=179053
2808
2809         Reviewed by Darin Adler.
2810
2811         Add a runtime flag for referrerpolicy attribute.
2812
2813         * DumpRenderTree/mac/DumpRenderTree.mm:
2814         (enableExperimentalFeatures):
2815
2816 2019-03-05  Daniel Bates  <dabates@apple.com>
2817
2818         Update expected API test result following r242379
2819         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2820
2821         Update expected x-coordinate of selection rect now that the left padding of
2822         a textarea is sized in ems (so dependent on the font size) just like the left
2823         padding of a text field.
2824
2825         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2826         (TestWebKitAPI::TEST):
2827
2828 2019-03-05  David Quesada  <david_quesada@apple.com>
2829
2830         [WK2] It should be possible to follow links with 'download' attributes
2831         https://bugs.webkit.org/show_bug.cgi?id=195145
2832         rdar://problem/48462642
2833
2834         Reviewed by Alex Christensen.
2835
2836         Add a unit test to verify that activating links with 'download' attributes now
2837         navigates to the linked resource, rather than starts downloading it. Add another
2838         to verify that it is still possible to explicitly download the link via the
2839         'Download' navigation action policy.
2840
2841         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2842         (-[DownloadAttributeTestDelegate init]):
2843         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2844         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2845         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2846         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2847         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2848         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2849         (TEST):
2850         * WebKitTestRunner/TestController.cpp:
2851         (WTR::TestController::decidePolicyForNavigationAction):
2852         * WebKitTestRunner/TestController.h:
2853
2854 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2855
2856         [Curl] Implement Cookie Accept Policy.
2857         https://bugs.webkit.org/show_bug.cgi?id=191645
2858
2859         Reviewed by Fujii Hironori.
2860
2861         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2862         (TestWebKitAPI::Curl::TEST_F):
2863
2864 2019-03-05  Youenn Fablet  <youenn@apple.com>
2865
2866         Rename requestCacheStorageSpace to requestStorageSpace
2867         https://bugs.webkit.org/show_bug.cgi?id=195282
2868
2869         Reviewed by Chris Dumez.
2870
2871         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2872         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2873         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2874
2875 2019-03-05  Brady Eidson  <beidson@apple.com>
2876
2877         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2878         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2879
2880         Reviewed by Tim Horton.
2881
2882         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2883         different directory into that same WKWebView should work.
2884
2885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2886         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2887
2888 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2889
2890         Add WeakHashSet
2891         https://bugs.webkit.org/show_bug.cgi?id=195152
2892
2893         Reviewed by Antti Koivisto.
2894
2895         Added tests for WeakHashSet.
2896
2897         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2898         (TestWebKitAPI::Base::Base): Moved.
2899         (TestWebKitAPI::Derived::foo): Moved.
2900         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2901         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2902         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2903         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2904
2905 2019-03-04  Chris Dumez  <cdumez@apple.com>
2906
2907         Do not share WebProcesses between private and regular sessions
2908         https://bugs.webkit.org/show_bug.cgi?id=195189
2909         <rdar://problem/48421064>
2910
2911         Reviewed by Alex Christensen.
2912
2913         Add API test coverage.
2914
2915         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2916         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2917
2918 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2919
2920         [WPE] Enable web process sandbox
2921         https://bugs.webkit.org/show_bug.cgi?id=195169
2922
2923         Reviewed by Daniel Bates.
2924
2925         * wpe/install-dependencies:
2926         * wpe/jhbuild.modules:
2927
2928 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2929
2930         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2931         https://bugs.webkit.org/show_bug.cgi?id=195206
2932
2933         Reviewed by Žan Doberšek.
2934
2935         Add a new test case.
2936
2937         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2938         (testJSCClass):
2939
2940 2019-03-04  Charlie Turner  <cturner@igalia.com>
2941
2942         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2943         https://bugs.webkit.org/show_bug.cgi?id=194898
2944
2945         Reviewed by Žan Doberšek.
2946
2947         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2948         a GCC extension that permits arithmetic on void* pointer. Inline
2949         the macro until this issue is fixed upstream.
2950
2951 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2952
2953         Rid the world of WK_API_ENABLED
2954         https://bugs.webkit.org/show_bug.cgi?id=195263
2955
2956         Reviewed by Dan Bernstein.
2957
2958         List of changed files elided because it's useless.
2959
2960 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2961
2962         Unreviewed follow-up to r242292.
2963
2964         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2965
2966         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2967         (TestWebKitAPI::testStrip): Renamed from strip.
2968         (TestWebKitAPI::TEST):
2969
2970 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2971
2972         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2973
2974         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2975         and bug #194272 for details.
2976
2977         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2978
2979 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2980
2981         Remove some more unused 32-bit code
2982         https://bugs.webkit.org/show_bug.cgi?id=195255
2983
2984         Reviewed by Darin Adler.
2985
2986         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2987         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2988         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2989         (NPP_New):
2990         (NPP_HandleEvent):
2991         (handleEventCarbon): Deleted.
2992
2993 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2994
2995         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2996
2997         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2998         (TestWebKitAPI::TEST):
2999
3000 2019-03-01  Darin Adler  <darin@apple.com>
3001
3002         Finish removing String::format
3003         https://bugs.webkit.org/show_bug.cgi?id=194893
3004
3005         Reviewed by Daniel Bates.
3006 '
3007         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3008
3009 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3010
3011         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3012         https://bugs.webkit.org/show_bug.cgi?id=195229
3013         <rdar://problem/48520362>
3014
3015         Reviewed by Chris Dumez.
3016
3017         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3018         (TEST):
3019
3020 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3021
3022         Add a system trace scope for event region building
3023         https://bugs.webkit.org/show_bug.cgi?id=195226
3024
3025         Reviewed by Jon Lee.
3026
3027         This trace scope measures the time spend converting element rects into Region objects,
3028         which can be large on some pages.
3029
3030         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3031
3032         * Tracing/SystemTracePoints.plist:
3033
3034 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3035
3036         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3037         https://bugs.webkit.org/show_bug.cgi?id=194612
3038
3039         Reviewed by Alex Christensen.
3040
3041         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3042         Just test the new string-processing function and don't touch the actual environment.
3043         (Test cases are all as before, but based on operator== instead of strcmp.)
3044
3045 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3046
3047         [ews-app] Update primary keys for handling multiple Buildbot instances
3048         https://bugs.webkit.org/show_bug.cgi?id=195120
3049
3050         Reviewed by Stephanie Lewis.
3051
3052         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3053         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3054         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3055
3056         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3057         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3058         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3059         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3060         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3061         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3062
3063 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3064
3065         [WinCairo] Enable service worker
3066         https://bugs.webkit.org/show_bug.cgi?id=188318
3067
3068         Reviewed by Youenn Fablet.
3069
3070         * DumpRenderTree/DumpRenderTreePrefix.h:
3071         * TestWebKitAPI/PlatformWin.cmake:
3072         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3073         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3074         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3075
3076 2019-03-01  Justin Fan  <justin_fan@apple.com>
3077
3078         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3079         https://bugs.webkit.org/show_bug.cgi?id=195191
3080
3081         Rubber-stamped by Dean Jackson.
3082
3083         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3084
3085         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3086
3087 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3088
3089         Unreviewed, fix lldb webkitpy tests
3090         https://bugs.webkit.org/show_bug.cgi?id=194375
3091
3092         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3093
3094         * lldb/lldb_webkit.py:
3095         (WTFStringImplProvider.is_8bit):
3096
3097 2019-02-28  David Quesada  <david_quesada@apple.com>
3098
3099         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3100         https://bugs.webkit.org/show_bug.cgi?id=195121
3101         rdar://problem/48450302
3102
3103         Reviewed by Alex Christensen.
3104
3105         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3106         configurations where the 'download' attribute is absent, blank, or populated
3107         with a filename, and where the anchor element is same-origin or cross-origin
3108         (meaning the 'download' attribute shouldn't be honored).
3109
3110         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3111         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3112         (-[NavigationActionTestDelegate init]):
3113         (-[NavigationActionTestDelegate navigationAction]):
3114         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3115         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3116         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3117         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3118         (TEST):
3119
3120 2019-02-28  Antoine Quint  <graouts@apple.com>
3121
3122         Enable the Pointer Events runtime flag by default
3123         https://bugs.webkit.org/show_bug.cgi?id=195156
3124
3125         Reviewed by Dean Jackson.
3126
3127         * DumpRenderTree/mac/DumpRenderTree.mm:
3128         (enableExperimentalFeatures):
3129
3130 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3131
3132         Several PasteImage API tests are flaky
3133         https://bugs.webkit.org/show_bug.cgi?id=195160
3134
3135         Reviewed by Tim Horton.
3136
3137         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3138         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3139         listening for a "load" event after image load is already complete.
3140
3141         To address this, make these tests first register a "load" event handler, then run script to insert an image
3142         element into the document, and finally wait until the load event is observed before checking image size.
3143
3144         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3145
3146 2019-02-28  Chris Dumez  <cdumez@apple.com>
3147
3148         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3149         https://bugs.webkit.org/show_bug.cgi?id=195107
3150
3151         Reviewed by Alex Christensen.
3152
3153         Give some time for the zoom level to get restored.
3154
3155         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3156
3157 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3158
3159         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3160         https://bugs.webkit.org/show_bug.cgi?id=194958
3161
3162         Reviewed by Geoffrey Garen.
3163
3164         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3165         (TEST):
3166
3167 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3168
3169         [ews-app] Update method to save build to handle builder_display_name
3170         https://bugs.webkit.org/show_bug.cgi?id=195047
3171
3172         Reviewed by Dewei Zhu.
3173
3174         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3175         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3176
3177 2019-02-28  Justin Fan  <justin_fan@apple.com>
3178
3179         [Web GPU] Enable Web GPU only on 64-bit
3180         https://bugs.webkit.org/show_bug.cgi?id=195139
3181
3182         Because Metal is only supported on 64 bit apps.
3183
3184         Unreviewed build fix.
3185
3186         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3187
3188 2019-02-27  Youenn Fablet  <youenn@apple.com>
3189
3190         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3191         https://bugs.webkit.org/show_bug.cgi?id=194959
3192
3193         Reviewed by Chris Dumez.
3194
3195         Spin loop until getting the condition to remove flakiness.
3196
3197         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3198
3199 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3200
3201         [ews-build] Buildbot should include builder_display_name in the build events
3202         https://bugs.webkit.org/show_bug.cgi?id=195045
3203
3204         Reviewed by Dewei Zhu.
3205
3206         * BuildSlaveSupport/ews-build/events.py:
3207         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3208         buildername to builder_name to be consistent in naming style.
3209         (Events.buildFinished): Ditto.
3210
3211 2019-02-27  Chris Dumez  <cdumez@apple.com>
3212
3213         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3214         https://bugs.webkit.org/show_bug.cgi?id=194480
3215
3216         Reviewed by Brady Eidson.
3217
3218         Update existing API test to make it more likely to reproduce the issue.
3219
3220         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3221
3222 2019-02-27  Brady Eidson  <beidson@apple.com>
3223
3224         Universal links from Google search results pages don't open the app.
3225         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3226
3227         Reviewed by Geoffrey Garen.
3228
3229         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3230         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3231         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3232         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3233
3234 2019-02-27  Chris Dumez  <cdumez@apple.com>
3235
3236         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3237         https://bugs.webkit.org/show_bug.cgi?id=195102
3238
3239         Reviewed by Geoffrey Garen.
3240
3241         If the number of processes is not yet what we expect, wait a bit and check again to give
3242         processes some time to exit.
3243
3244         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3245
3246 2019-02-27  Chris Dumez  <cdumez@apple.com>
3247
3248         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3249         https://bugs.webkit.org/show_bug.cgi?id=194545
3250
3251         Reviewed by Brady Eidson.
3252
3253         Make sure the test navigates forward and then back only once. Previously, navigating
3254         back would trigger a navigation again in a timer.
3255
3256         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3257
3258 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3259
3260         High Sierra Debug JSC test queue should use faster hardware
3261         https://bugs.webkit.org/show_bug.cgi?id=194603
3262
3263         Rubber-stamped by Alexey Proskuryakov.
3264
3265         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3266
3267         * BuildSlaveSupport/build.webkit.org-config/config.json:
3268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3269         (BubbleQueueServer):
3270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3271         (WebKitBuildbot):
3272         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3273         * QueueStatusServer/config/queues.py:
3274         * Scripts/webkitpy/common/config/ews.json:
3275         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3276         (test_ews_name):
3277
3278 2019-02-27  John Wilander  <wilander@apple.com>
3279
3280         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3281         https://bugs.webkit.org/show_bug.cgi?id=195071
3282         <rdar://problem/48417690>
3283
3284         Reviewed by Alex Christensen and Brent Fulgham.
3285
3286         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3287         (TestWebKitAPI::createURL):
3288             Convenience function.
3289         (TestWebKitAPI::TEST):
3290             WebCore::AdClickAttribution now takes a URL when creating Source and
3291             Destination.
3292         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3293         (TestWebKitAPI::TEST):
3294             WebCore::AdClickAttribution now takes a URL when creating Source and
3295             Destination.
3296
3297 2019-02-27  Antoine Quint  <graouts@apple.com>
3298
3299         Support Pointer Events on macOS
3300         https://bugs.webkit.org/show_bug.cgi?id=195008
3301         <rdar://problem/47454419>
3302
3303         Reviewed by Dean Jackson.
3304
3305         * DumpRenderTree/mac/DumpRenderTree.mm:
3306         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3307         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3308
3309 2019-02-26  Mark Lam  <mark.lam@apple.com>
3310
3311         Remove remaining poisoning code.
3312         https://bugs.webkit.org/show_bug.cgi?id=194138
3313
3314         Reviewed by Saam Barati.
3315
3316         * TestWebKitAPI/CMakeLists.txt:
3317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3318         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3319         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3320         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3321         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3322         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3323         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3324
3325 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3326
3327         Move ephemeral local storage from WebProcess to UIProcess
3328         https://bugs.webkit.org/show_bug.cgi?id=195074
3329         <rdar://problem/47937975>
3330
3331         Reviewed by Geoff Garen.
3332
3333         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3334
3335 2019-02-20  Jer Noble  <jer.noble@apple.com>
3336
3337         [Cocoa] Media elements will restart network buffering just before suspending
3338         https://bugs.webkit.org/show_bug.cgi?id=193691
3339
3340         Reviewed by Eric Carlson.
3341
3342         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3343         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3344         (TEST):
3345
3346 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3347
3348         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3349         https://bugs.webkit.org/show_bug.cgi?id=191652
3350
3351         Reviewed by Alex Christensen.
3352
3353         Fix WinCairo MiniBrowser behavior of authentication dialog.
3354
3355         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3356         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3357
3358 2019-02-26  Youenn Fablet  <youenn@apple.com>
3359
3360         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3361         https://bugs.webkit.org/show_bug.cgi?id=195028
3362         <rdar://problem/48243733>
3363
3364         Reviewed by Eric Carlson.
3365
3366         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3367
3368 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3369
3370         [WPE] Add API for webview background color configuration
3371         https://bugs.webkit.org/show_bug.cgi?id=192305
3372
3373         Reviewed by Michael Catanzaro.
3374
3375         * MiniBrowser/wpe/main.cpp:
3376         (main): Add a new option to configure the webview background
3377         color. Example: --bg-color=transparent.
3378         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3379         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3380         (beforeAll): Ditto.
3381
3382 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3383
3384         scalableNativeWebpageParameters() is not preserved on new page navigation.
3385         https://bugs.webkit.org/show_bug.cgi?id=194892
3386         <rdar://problem/47538280>
3387
3388         Reviewed by Wenson Hsieh.
3389         
3390         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3391
3392         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3393         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3394         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3395         (WTR::UIScriptController::allowsViewportShrinkToFit):
3396         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3397         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3398         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3399         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3400         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3401         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3402
3403 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3404
3405         [ews-app] Add model for handling multiple Buildbot instances
3406         https://bugs.webkit.org/show_bug.cgi?id=194863
3407
3408         Reviewed by Stephanie Lewis.
3409
3410         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3411
3412 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3413
3414         [ews-app] Remove BuilderMapping table
3415         https://bugs.webkit.org/show_bug.cgi?id=194961
3416
3417         Reviewed by Stephanie Lewis.
3418
3419         Store builder name directly in build table, instead of having a separate
3420         table for it.
3421
3422         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3423         * BuildSlaveSupport/ews-app/ews/models/build.py:
3424         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3425         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3426
3427 2019-02-25  John Wilander  <wilander@apple.com>
3428
3429         Introduce and adopt new class RegistrableDomain for eTLD+1
3430         https://bugs.webkit.org/show_bug.cgi?id=194791
3431         <rdar://problem/48179240>
3432
3433         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3434
3435         This patch adds an API test and replaces two instances of
3436         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3437
3438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3439         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3440         (TestWebKitAPI::TEST):
3441             Changed two strings to make sure the registrable domains are still considered
3442             invalid and pass the test.
3443         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3444         (TestWebKitAPI::TEST):
3445         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3446         (WTR::InjectedBundle::didReceiveMessageToPage):
3447
3448 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3449
3450         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3451         https://bugs.webkit.org/show_bug.cgi?id=195001
3452
3453         Reviewed by Carlos Garcia Campos.
3454
3455         API version 1.0 always includes the functionality previously guarded with
3456         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3457         unconditionally.
3458
3459         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3460         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3461         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3462         (WebViewTest::showInWindow): Ditto.
3463         (WebViewTest::hideView): Ditto.
3464         * wpe/backends/HeadlessViewBackend.cpp:
3465         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3466         * wpe/backends/ViewBackend.cpp:
3467         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3468         * wpe/backends/WindowViewBackend.cpp:
3469         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3470         WPE_BACKEND_CHECK_VERSION().
3471         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3472
3473 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3474
3475         [Flatpak] Add support for flatpak > 1.1.2
3476         https://bugs.webkit.org/show_bug.cgi?id=194088
3477
3478         Flatpak 1.2 is now out so we need to support that
3479         version now.
3480
3481         Reviewed by Michael Catanzaro.
3482
3483         * flatpak/flatpakutils.py:
3484         (check_flatpak):
3485         (FlatpakPackages.__init__):
3486         (FlatpakPackages.__detect_packages):
3487         (FlatpakPackages.__detect_packages.in):
3488         (FlatpakRepos.update):
3489
3490 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3491
3492         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3493         https://bugs.webkit.org/show_bug.cgi?id=194998
3494
3495         Reviewed by Carlos Garcia Campos.
3496
3497         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3498         to a Git checkout and using the latest commit containing various fixes
3499         and improvements.
3500
3501 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3502
3503         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3504         https://bugs.webkit.org/show_bug.cgi?id=194981
3505
3506         Reviewed by Žan Doberšek.
3507
3508         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3509         (TestWebKitAPI::TEST):
3510
3511 2019-02-23  Keith Miller  <keith_miller@apple.com>
3512
3513         Add new mac target numbers
3514         https://bugs.webkit.org/show_bug.cgi?id=194955
3515
3516         Reviewed by Tim Horton.
3517
3518         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3519         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3520         * MiniBrowser/Configurations/Base.xcconfig:
3521         * TestWebKitAPI/Configurations/Base.xcconfig:
3522         * WebKitTestRunner/Configurations/Base.xcconfig:
3523
3524 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3525
3526         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3527         https://bugs.webkit.org/show_bug.cgi?id=194846
3528
3529         Reviewed by Don Olmstead.
3530
3531         Added _search_paths() and _port_specific_expectations_files() for
3532         WinCairoPort.
3533
3534         * Scripts/webkitpy/port/win.py:
3535         (WinCairoPort.default_baseline_search_path):
3536         (WinCairoPort):
3537         (WinCairoPort._port_specific_expectations_files):
3538         (WinCairoPort._search_paths):
3539
3540 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3541
3542         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3543         https://bugs.webkit.org/show_bug.cgi?id=194963
3544
3545         Reviewed by Dean Jackson.
3546
3547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3548         Do a `contains` check instead of `equals`, because in debug builds we
3549         put the GraphicsLayer pointer in a prefix.
3550
3551 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3552
3553         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3554         https://bugs.webkit.org/show_bug.cgi?id=194873
3555         <rdar://problem/46701974>
3556
3557         Reviewed by Tim Horton.
3558
3559         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3560
3561         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3562         (WTR::UIScriptController::menuRect const):
3563         (WTR::UIScriptController::isShowingMenu const):
3564         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3565         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3566         (WTR::UIScriptController::menuRect const):
3567
3568         Add a function to query the bounds of the callout menu in content coordinates.
3569
3570         (WTR::UIScriptController::isShowingMenu const):
3571
3572         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3573
3574         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3575         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3576         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3577         (WTR::UIScriptController::rectForMenuAction const):
3578         (WTR::UIScriptController::menuRect const):
3579         (WTR::UIScriptController::isShowingMenu const):
3580         (WTR::findViewInHierarchyOfType): Deleted.
3581
3582 2019-02-22  Chris Dumez  <cdumez@apple.com>
3583
3584         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3585         https://bugs.webkit.org/show_bug.cgi?id=194954
3586         <rdar://problem/48127957>
3587
3588         Reviewed by Alex Christensen.
3589
3590         Add API test coverage.
3591
3592         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3593         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3594         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3595         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3596
3597 2019-02-22  Chris Dumez  <cdumez@apple.com>
3598
3599         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3600         https://bugs.webkit.org/show_bug.cgi?id=194924
3601         <rdar://problem/48216125>
3602
3603         Reviewed by Geoffrey Garen.
3604
3605         Add API test coverage.
3606
3607         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3608
3609 2019-02-22  Chris Dumez  <cdumez@apple.com>
3610
3611         Unreviewed, disable API test added in r241928 on iOS.
3612
3613         The cache is not enabled on devices with less than 3GB of RAM.
3614
3615         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3616
3617 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3618
3619         Hardcode Visual Viewports on everywhere except iOS WK1
3620         https://bugs.webkit.org/show_bug.cgi?id=194928
3621
3622         Reviewed by Zalan Bujtas.
3623
3624         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3625         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3626         set it to false. The setting has shipped for several years and there's no need to turn
3627         it off now.
3628
3629         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3630         Visual Viewports are not enabled.
3631         
3632         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3633         that only runs in WK2
3634
3635         * MiniBrowser/mac/SettingsController.h:
3636         * MiniBrowser/mac/SettingsController.m:
3637         (-[SettingsController init]):
3638         (-[SettingsController _populateMenu]):
3639         (-[SettingsController validateMenuItem:]):
3640         (-[SettingsController visualViewportEnabled]): Deleted.
3641         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3642         * MiniBrowser/mac/WK1BrowserWindowController.m:
3643         (-[WK1BrowserWindowController didChangeSettings]):
3644         * MiniBrowser/mac/WK2BrowserWindowController.m:
3645         (-[WK2BrowserWindowController didChangeSettings]):
3646
3647 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3648
3649         Discard cached processes when clearing website data store
3650         https://bugs.webkit.org/show_bug.cgi?id=194894
3651
3652         Reviewed by Chris Dumez.
3653
3654         Added a test case.
3655
3656         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3657         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3658
3659 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3660
3661         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3662         https://bugs.webkit.org/show_bug.cgi?id=194914
3663         <rdar://problem/47586889>
3664
3665         Reviewed by Geoffrey Garen.
3666
3667         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3668         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3669         (TEST):
3670         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3671
3672 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3673
3674         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3675         <https://webkit.org/b/194761>
3676
3677         Reviewed by Myles Maxfield.
3678
3679         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3680         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3681         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3682         to use ARC-compliant cast.
3683         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3684         ARC-compliant cast.
3685         (WTR::installFakeHelvetica): Log `error` to console if
3686         CTFontManagerRegisterFontsForURL() fails, but only on supported
3687         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3688         Call CFRelease() on `error` to fix the leak.  Update to use
3689         ARC-compliant cast.
3690         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3691         cast.
3692
3693 2019-02-21  Chris Dumez  <cdumez@apple.com>
3694
3695         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3696         https://bugs.webkit.org/show_bug.cgi?id=194481
3697
3698         Reviewed by Alex Christensen.
3699
3700         Give the processes a chance to shutdown and wait until we reached the expected number
3701         of processes.
3702
3703         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3704
3705 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3706
3707         Fix the macOS build
3708
3709         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3710
3711 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3712
3713         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3714
3715         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3716         I am a backwards.
3717
3718 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3719
3720         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3721
3722         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3723         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3724         We could force on UI-side compositing, but I feel like the test might be more
3725         valuable exercising the normal path on each platform (though the original
3726         bug was also UI-side specific). Though we can't validate that the overlay
3727         layer was installed successfully, there are layout tests that do that.
3728
3729 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3730
3731         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3732         https://bugs.webkit.org/show_bug.cgi?id=194845
3733         <rdar://problem/47944579>
3734
3735         Reviewed by Antti Koivisto.
3736
3737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3738         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3739
3740 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3741
3742         [LFC][Floats] Add support for placing formatting roots in-between floats.
3743         https://bugs.webkit.org/show_bug.cgi?id=194902
3744
3745         Reviewed by Antti Koivisto.
3746
3747         * LayoutReloaded/misc/LFC-passing-tests.txt:
3748
3749 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3750
3751         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3752         https://bugs.webkit.org/show_bug.cgi?id=194901
3753
3754         Unreviewed build fix.
3755
3756         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3757         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3758         WPEBackend-fdo-0.1 as library name.
3759
3760 2019-02-21  Rob Buis  <rbuis@igalia.com>
3761
3762         Update MIME type parser
3763         https://bugs.webkit.org/show_bug.cgi?id=180526
3764
3765         Reviewed by Darin Adler.
3766
3767         Add tests involving leading and trailing whitespace, non-token
3768         characters and quoted strings.
3769
3770         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3771         (TestWebKitAPI::TEST):
3772
3773 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3774
3775         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3776         https://bugs.webkit.org/show_bug.cgi?id=194884
3777
3778         Reviewed by Michael Catanzaro.
3779
3780         * PlatformWin.cmake:
3781
3782 2019-02-20  Chris Dumez  <cdumez@apple.com>
3783
3784         Add API test for <rdar://problem/47471222>
3785         https://bugs.webkit.org/show_bug.cgi?id=194847
3786
3787         Reviewed by Alex Christensen.
3788
3789         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3790
3791 2019-02-20  Chris Dumez  <cdumez@apple.com>
3792
3793         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3794         https://bugs.webkit.org/show_bug.cgi?id=194872
3795         <rdar://problem/47924500>
3796
3797         Reviewed by Alex Christensen.
3798
3799         Add API test coverage.
3800
3801         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3802
3803 2019-02-20  Jer Noble  <jer.noble@apple.com>
3804
3805         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3806         https://bugs.webkit.org/show_bug.cgi?id=191332
3807
3808         Reviewed by Dean Jackson.
3809
3810         * Scripts/git-is-in-range: Added.
3811
3812 2019-02-20  Andy Estes  <aestes@apple.com>
3813
3814         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3815         https://bugs.webkit.org/show_bug.cgi?id=194869
3816
3817         Rubber-stamped by Jer Noble.
3818
3819         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3820         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3821         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3822         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3823         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3824         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3825
3826 2019-02-20  Chris Dumez  <cdumez@apple.com>
3827
3828         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3829         https://bugs.webkit.org/show_bug.cgi?id=194857
3830         <rdar://problem/47759323>
3831
3832         Reviewed by Alex Christensen.
3833
3834         Add API test coverage.
3835
3836         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3837
3838 2019-02-20  Chris Dumez  <cdumez@apple.com>
3839
3840         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3841         https://bugs.webkit.org/show_bug.cgi?id=194829
3842         <rdar://problem/47889906>
3843
3844         Reviewed by Alexey Proskuryakov.
3845
3846         Every time the TestOptions were changing we were creating both a new Web view and
3847         a new WKContext, which would start a new Network process. In most cases, we only
3848         need to contruct a new Web view and we do can keep reusing the same WKContext.
3849         This patch implements this optimization and thus avoids spinning a lot of new
3850         Network processes while running the layout tests.
3851
3852         * WebKitTestRunner/TestController.cpp:
3853         (WTR::TestController::generateContextConfiguration const):
3854         (WTR::TestController::generatePageConfiguration):
3855         (WTR::TestController::createWebViewWithOptions):
3856         (WTR::TestController::resetPreferencesToConsistentValues):
3857         (WTR::updateTestOptionsFromTestHeader):
3858         * WebKitTestRunner/TestController.h:
3859         * WebKitTestRunner/TestOptions.h:
3860         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3861         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3862         (WTR::TestOptions::hasSameInitializationOptions const):
3863         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3864         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3865         (WTR::TestController::platformAddTestOptions const):
3866
3867 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3868
3869         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3870         https://bugs.webkit.org/show_bug.cgi?id=167941
3871
3872         Reviewed by Carlos Garcia Campos.
3873
3874         * MiniBrowser/gtk/main.c:
3875         (filterSavedCallback): Added.
3876         (main): Support loading a JSON rule set file for content filtering.
3877         * MiniBrowser/wpe/main.cpp:
3878         (filterSavedCallback): Added.
3879         (main): Support loading a JSON rule set file for content filtering.
3880         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3881         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3882         (WTF::derefGPtr): Ditto.
3883         (testEmptyStore):
3884         (testSaveInvalidFilter):
3885         (testSaveLoadFilter):
3886         (testSavedFilterIdentifierMatch):
3887         (testRemoveFilter):
3888         (testSaveMultipleFilters):
3889         (testSaveFilterFromFile):
3890         (testFilterPersistence):
3891         (beforeAll):
3892         (afterAll):
3893         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3894         (removeOldInjectedContentAndResetLists): Also reset content filters.
3895         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3896         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3897         the element affected by the style sheet.
3898         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3899         and returns it to be used by tests.
3900         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3901         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3902         (serverCallback): Add support for serving a CSS style sheet for testing.
3903         (beforeAll): Add call to testUserContentManagerContentFilter().
3904         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3905
3906 2019-02-19  Keith Rollin  <krollin@apple.com>
3907
3908         Add timing information to build output
3909         https://bugs.webkit.org/show_bug.cgi?id=194839
3910         <rdar://problem/48219609>
3911
3912         Reviewed by Alexey Proskuryakov.
3913
3914         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3915         emit each project's build time to its output. E.g.,
3916
3917             ** BUILD SUCCEEDED ** [0.132 sec]
3918
3919         * Scripts/webkitdirs.pm:
3920         (XcodeOptions):
3921
3922 2019-02-19  Truitt Savell  <tsavell@apple.com>
3923
3924         Unreviewed, rolling out r241784.
3925
3926         Broke all OpenSource builds.
3927
3928         Reverted changeset:
3929
3930         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3931         instances view"
3932         https://bugs.webkit.org/show_bug.cgi?id=172848
3933         https://trac.webkit.org/changeset/241784
3934
3935 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3936
3937         [LFC][Floats] Remove redundant intersecting logic
3938         https://bugs.webkit.org/show_bug.cgi?id=194804
3939
3940         Reviewed by Antti Koivisto.
3941
3942         * LayoutReloaded/misc/LFC-passing-tests.txt:
3943
3944 2019-02-19  Dean Jackson  <dino@apple.com>
3945
3946         Clean-up output from generate-xcfilelists so it can be filtered
3947         https://bugs.webkit.org/show_bug.cgi?id=194795
3948
3949         Reviewed by Joseph Pecoraro (and Keith Rollin).
3950
3951         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3952         make a slight tweak to filter-build-webkit so such lines are marked
3953         as plain.
3954
3955         * Scripts/filter-build-webkit:
3956         * Scripts/generate-xcfilelists:
3957
3958 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3959
3960         pytest is not correctly auto-installed
3961         https://bugs.webkit.org/show_bug.cgi?id=194707
3962
3963         Reviewed by Carlos Garcia Campos.
3964
3965         * Scripts/webkitpy/thirdparty/__init__.py:
3966         (AutoinstallImportHook._install_pytest):
3967
3968 2019-02-18  Chris Dumez  <cdumez@apple.com>
3969
3970         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3971         https://bugs.webkit.org/show_bug.cgi?id=194797
3972         <rdar://problem/48055151>
3973
3974         Reviewed by Geoffrey Garen.
3975
3976         Add API test coverage.
3977
3978         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3979
3980 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3981
3982         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3983         https://bugs.webkit.org/show_bug.cgi?id=194670
3984         <rdar://problem/39066529>
3985
3986         Reviewed by Tim Horton.
3987
3988         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3989         pasted in an editable area as attachment elements.
3990
3991         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3992         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3993         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3994         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3995         (TestWebKitAPI::TEST):
3996         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3997         (WTR::InjectedBundlePage::InjectedBundlePage):
3998
3999 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4000
4001         Fix API test after r241728
4002        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4003
4004         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4005         (TEST):
4006         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4007
4008 2019-02-18  Daniel Bates  <dabates@apple.com>
4009
4010         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4011         https://bugs.webkit.org/show_bug.cgi?id=192824
4012         <rdar://problem/47100332>
4013
4014         Reviewed by Wenson Hsieh.
4015
4016         Fix a bug where the wrong usage code was used for F13 thru F24.
4017
4018         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4019         (keyCodeForDOMFunctionKey):
4020
4021 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4022
4023         Bytecode cache should a have a boot-specific validation
4024         https://bugs.webkit.org/show_bug.cgi?id=194769
4025         <rdar://problem/48149509>
4026
4027         Reviewed by Keith Miller.
4028
4029         Add test for WTF::bootSessionUUIDString()
4030
4031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4032         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4033         (TEST):
4034
4035 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4036
4037         Disable safe browsing in WKWebView and remove its WKPreferences API
4038         https://bugs.webkit.org/show_bug.cgi?id=194723
4039         <rdar://problem/48122993>
4040
4041         Reviewed by Geoffrey Garen.
4042
4043         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4044         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4045         (TEST):
4046         (safeBrowsingView):
4047         Make tests use SPI instead of API.
4048
4049 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4050
4051         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4052         https://bugs.webkit.org/show_bug.cgi?id=194586
4053
4054         Reviewed by Ross Kirsling.
4055
4056         * DumpRenderTree/win/DumpRenderTree.cpp:
4057         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4058         * Scripts/webkitpy/port/driver.py:
4059         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4060
4061 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4062
4063         Unreviewed, rolling out r241620.
4064
4065         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4066         (Requested by ddkilzer on #webkit.)
4067
4068         Reverted changeset:
4069
4070         "[WTF] Add environment variable helpers"
4071         https://bugs.webkit.org/show_bug.cgi?id=192405
4072         https://trac.webkit.org/changeset/241620
4073
4074 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4075
4076         [LFC] RenderImage's default intrinsic size is 0.
4077         https://bugs.webkit.org/show_bug.cgi?id=194745
4078
4079         Reviewed by Antti Koivisto.
4080
4081         * LayoutReloaded/misc/LFC-passing-tests.txt:
4082
4083 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4084
4085         [LFC][BFC] Add support for block replaced intrinsic width.
4086         https://bugs.webkit.org/show_bug.cgi?id=194705
4087
4088         Reviewed by Simon Fraser.
4089
4090         * LayoutReloaded/misc/LFC-passing-tests.txt:
4091
4092 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4093
4094         [LFC] Apply min/max width constraints to preferred width computation
4095         https://bugs.webkit.org/show_bug.cgi?id=194739
4096
4097         Reviewed by Simon Fraser.
4098
4099         * LayoutReloaded/misc/LFC-passing-tests.txt:
4100
4101 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
4102
4103         [WTF] Add environment variable helpers
4104         https://bugs.webkit.org/show_bug.cgi?id=192405
4105
4106         Reviewed by Michael Catanzaro.
4107
4108         * DumpRenderTree/mac/DumpRenderTree.mm:
4109         (libraryPathForDumpRenderTree):
4110         * DumpRenderTree/win/DumpRenderTree.cpp:
4111         (libraryPathForDumpRenderTree):
4112         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4113         (setUpIOSLayoutTestCommunication):
4114         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4115         (beforeAll):
4116         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4117         (main):
4118         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4119         (WebKitTestBus::run):
4120         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4121         (WTR::getOutputDir):
4122         (WTR::initializeFontConfigSetting):
4123         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4124         (WTR::InjectedBundle::platformInitialize):
4125         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4126         (WTR::topLevelPath):
4127         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4128         (WTR::topLevelPath):
4129         (WTR::getOutputDir):
4130         (WTR::activateFonts):
4131         * WebKitTestRunner/TestController.cpp:
4132         (WTR::TestController::libraryPathForTesting):
4133         (WTR::TestController::generateContextConfiguration const):
4134         (WTR::TestController::generatePageConfiguration):
4135         (WTR::TestController::decideDestinationWithSuggestedFilename):
4136         (WTR::TestController::platformAdjustContext):
4137         * WebKitTestRunner/TestController.h:
4138         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4139         (WTR::TestController::cocoaPlatformInitialize):
4140         (WTR::TestController::platformAdjustContext):
4141         * WebKitTestRunner/gtk/main.cpp:
4142         (main):
4143         * WebKitTestRunner/mac/TestControllerMac.mm:
4144         (WTR::TestController::configureContentExtensionForTest):
4145         * WebKitTestRunner/wpe/main.cpp:
4146         (main):
4147         Utilize WTF::Environment where possible.
4148
4149 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4150
4151         [iOS] WKWebView callout bar is missing Change Writing Direction item
4152         https://bugs.webkit.org/show_bug.cgi?id=190015
4153         <rdar://problem/44810366>
4154
4155         Reviewed by Tim Horton.
4156
4157         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
4158         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4159
4160         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4161         (TestWebKitAPI::TEST):
4162
4163 2019-02-15  Chris Dumez  <cdumez@apple.com>
4164
4165         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
4166         https://bugs.webkit.org/show_bug.cgi?id=194717
4167         <rdar://problem/47884404>
4168
4169         Reviewed by Brady Eidson.
4170
4171         Add API test coverage.
4172
4173         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4174
4175 2019-02-15  Youenn Fablet  <youenn@apple.com>
4176
4177         Make navigator.mediaDevices SecureContext
4178         https://bugs.webkit.org/show_bug.cgi?id=194666
4179
4180         Reviewed by Eric Carlson.
4181
4182         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4183         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4184         (TEST_F):
4185
4186 2019-02-15  Brian Burg  <bburg@apple.com>
4187
4188         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4189         https://bugs.webkit.org/show_bug.cgi?id=194411
4190         <rdar://problem/47787614>
4191
4192         Reviewed by Joseph Pecoraro.
4193
4194         Remove unnecessary soft linking macro usage.
4195
4196         * DumpRenderTree/mac/TestRunnerMac.mm:
4197         (TestRunner::inspectorTestStubURL):
4198         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4199         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4200         (WTR::TestRunner::inspectorTestStubURL):
4201
4202 2019-02-15  Commit Queue  <commit-queue@webkit.org>
4203
4204         Unreviewed, rolling out r241559 and r241566.
4205         https://bugs.webkit.org/show_bug.cgi?id=194710
4206
4207         Causes layout test crashes under GuardMalloc (Requested by
4208         ryanhaddad on #webkit).
4209
4210         Reverted changesets:
4211
4212         "[WTF] Add environment variable helpers"
4213         https://bugs.webkit.org/show_bug.cgi?id=192405
4214         https://trac.webkit.org/changeset/241559
4215
4216         "Unreviewed build fix for WinCairo Debug after r241559."
4217         https://trac.webkit.org/changeset/241566
4218
4219 2019-02-15  Zalan Bujtas  <zalan@apple.com>
4220
4221         [LFC] Out-of-flow box is never a float box
4222         https://bugs.webkit.org/show_bug.cgi?id=194704
4223
4224         Reviewed by Antti Koivisto.
4225
4226         * LayoutReloaded/misc/LFC-passing-tests.txt:
4227
4228 2019-02-10  Darin Adler  <darin@apple.com>
4229
4230         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
4231         https://bugs.webkit.org/show_bug.cgi?id=194487
4232
4233         Reviewed by Daniel Bates.
4234
4235         * DumpRenderTree/win/DumpRenderTree.cpp:
4236         (applicationId): Use makeString instead of String::format.
4237         (main): Ditto.
4238         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4239         (TestWebKitAPI::Util::createURLForResource): Ditto.
4240         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
4241         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
4242
4243         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4244         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
4245         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
4246         (WTR::createStringWithAttributes): Use appendLiteral.
4247         (WTR::AccessibilityUIElement::helpText const): Ditto.
4248         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
4249         directly instead of using String::format.
4250         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
4251         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
4252
4253 2019-02-15  Truitt Savell  <tsavell@apple.com>
4254
4255         Unreviewed, rolling out r241564.
4256
4257         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
4258
4259         Reverted changeset:
4260
4261         "[Mac] WebInspectorUI.framework does not need to be soft-
4262         linked anymore"
4263         https://bugs.webkit.org/show_bug.cgi?id=194411
4264         https://trac.webkit.org/changeset/241564
4265
4266 2019-02-15  Saam barati  <sbarati@apple.com>
4267
4268         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
4269         https://bugs.webkit.org/show_bug.cgi?id=194036
4270
4271         Reviewed by Yusuke Suzuki.
4272
4273         * Scripts/run-jsc-stress-tests:
4274
4275 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4276
4277         Fix the build.
4278
4279         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4280         (WTR::UIScriptController::drawSquareInEditableImage):
4281         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4282         (TestWebKitAPI::drawSquareInEditableImage):
4283
4284 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4285
4286         Fix the build.
4287
4288         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4289         (WTR::UIScriptController::drawSquareInEditableImage):
4290         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4291         (TestWebKitAPI::drawSquareInEditableImage):
4292
4293 2019-02-14  Brian Burg  <bburg@apple.com>
4294
4295         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4296         https://bugs.webkit.org/show_bug.cgi?id=194411
4297         <rdar://problem/47787614>
4298
4299         Reviewed by Joseph Pecoraro.
4300
4301         Remove unnecessary soft linking macro usage.
4302
4303         * DumpRenderTree/mac/TestRunnerMac.mm:
4304         (TestRunner::inspectorTestStubURL):
4305         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4306         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4307         (WTR::TestRunner::inspectorTestStubURL):
4308
4309 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4310
4311         [ews-app] status bubble should fetch builder name info from BuilderMapping table
4312         https://bugs.webkit.org/show_bug.cgi?id=194599
4313
4314         Reviewed by Lucas Forschler.
4315
4316         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4317         (StatusBubble._build_bubble):
4318
4319 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4320
4321         [ews-app] Set Foreign Key in Django build model
4322         https://bugs.webkit.org/show_bug.cgi?id=194667
4323
4324         Reviewed by Lucas Forschler.
4325
4326         * BuildSlaveSupport/ews-app/ews/models/build.py:
4327         (Build):
4328
4329 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
4330
4331         [WTF] Add environment variable helpers
4332         https://bugs.webkit.org/show_bug.cgi?id=192405
4333
4334         Reviewed by Michael Catanzaro.
4335
4336         * DumpRenderTree/mac/DumpRenderTree.mm:
4337         (libraryPathForDumpRenderTree):
4338         * DumpRenderTree/win/DumpRenderTree.cpp:
4339         (libraryPathForDumpRenderTree):
4340         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4341         (setUpIOSLayoutTestCommunication):
4342         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4343         (TestWebKitAPI::strip):
4344         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4345         (beforeAll):
4346         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4347         (main):
4348         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4349         (WebKitTestBus::run):
4350         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4351         (WTR::getOutputDir):
4352         (WTR::initializeFontConfigSetting):
4353         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4354         (WTR::InjectedBundle::platformInitialize):
4355         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4356         (WTR::topLevelPath):
4357         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4358         (WTR::topLevelPath):
4359         (WTR::getOutputDir):
4360