Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2
3         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
4         https://bugs.webkit.org/show_bug.cgi?id=196629
5
6         Reviewed by Lucas Forschler.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
9
10 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
11
12         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
13         https://bugs.webkit.org/show_bug.cgi?id=196618
14
15         Reviewed by Lucas Forschler.
16
17         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
18         (StatusBubble): Added QUEUE_TRIGGERS.
19         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
20         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
21         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
22         its parent(builder).
23
24 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
25
26         [ews-app] Status-bubble steps are sometimes displayed in reverse order
27         https://bugs.webkit.org/show_bug.cgi?id=196625
28
29         Reviewed by Lucas Forschler.
30
31         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
32         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
33
34 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
35
36         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
37         https://bugs.webkit.org/show_bug.cgi?id=196630
38
39         Reviewed by Wenson Hsieh.
40
41         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
42
43 2019-04-04  Youenn Fablet  <youenn@apple.com>
44
45         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
46         https://bugs.webkit.org/show_bug.cgi?id=196543
47
48         Reviewed by Alex Christensen.
49
50         * WebKitTestRunner/TestController.cpp:
51         (WTR::TestController::generatePageConfiguration):
52
53 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
54
55         [ews-app] Status bubble should not display skipped buildbot steps
56         https://bugs.webkit.org/show_bug.cgi?id=196584
57
58         Reviewed by Lucas Forschler.
59
60         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
61
62 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
63
64         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
65         https://bugs.webkit.org/show_bug.cgi?id=196620
66
67         Reviewed by Lucas Forschler.
68
69         * BuildSlaveSupport/ews-app/ews/config.py:
70
71 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
72
73         [Win] DumpRenderTreeWatchDog.py is not checked into source
74         https://bugs.webkit.org/show_bug.cgi?id=196567
75         <rdar://problem/49525901>
76
77         Reviewed by Lucas Forschler.
78
79         This script is used on Win EWS bots to terminate hanging DRT processes.
80
81         * EWSTools/dumprendertreewatchdog.py: Added.
82
83 2019-04-04  Chris Dumez  <cdumez@apple.com>
84
85         Unreviewed, roll out r243858 which made tests time out.
86
87         Disable new API tests on Windows instead.
88
89         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
90         (TestWebKitAPI::TEST):
91
92 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
93
94         [ATK] Cleanup WebPageAccessibilityObjectAtk
95         https://bugs.webkit.org/show_bug.cgi?id=196537
96
97         Reviewed by Michael Catanzaro.
98
99         Also consider files under atk directories as exceptions for GObject conventions.
100
101         * Scripts/webkitpy/style/checkers/cpp.py:
102         (check_identifier_name_in_declaration):
103
104 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
105
106         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
107         https://bugs.webkit.org/show_bug.cgi?id=196588
108         <rdar://problem/49365787>
109
110         Unreviewed build fix for Windows port.
111
112         error C3861: 'kill': identifier not found
113
114         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
115         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
116
117 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
118
119         [ews-build] Cancel build and similar operations should have authentication
120         https://bugs.webkit.org/show_bug.cgi?id=196520
121
122         Reviewed by Dewei Zhu.
123
124         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
125         environment variables.
126
127 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
128
129         [ews-build] Do not trigger queues which are not in production yet
130         https://bugs.webkit.org/show_bug.cgi?id=196581
131
132         Reviewed by Dewei Zhu.
133
134         * BuildSlaveSupport/ews-build/config.json:
135
136 2019-04-03  Chris Dumez  <cdumez@apple.com>
137
138         Unreviewed, fix typo in the name of API test added in r243848.
139
140         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
141         (TestWebKitAPI::TEST):
142
143 2019-04-03  Chris Dumez  <cdumez@apple.com>
144
145         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
146         https://bugs.webkit.org/show_bug.cgi?id=196588
147         <rdar://problem/49365787>
148
149         Reviewed by Ryosuke Niwa.
150
151         Add API test coverage.
152
153         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
154         (TestWebKitAPI::nullJavaScriptCallback):
155         (TestWebKitAPI::didCrashCheckFrames):
156         (TestWebKitAPI::TEST):
157
158 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
159
160         run-webkit-tests: Upload test results (new results database)
161         https://bugs.webkit.org/show_bug.cgi?id=196577
162         <rdar://problem/34841155>
163
164         Reviewed by Lucas Forschler.
165
166         * Scripts/webkitpy/layout_tests/controllers/manager.py:
167         (Manager.run): Upload results after each device shard, since the configuration will be
168         different for each device.
169         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
170         uploaded to a results database.
171         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
172         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
173
174 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
175
176         -apple-trailing-word is needed for browser detection
177         https://bugs.webkit.org/show_bug.cgi?id=196575
178
179         Unreviewed.
180
181         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
182
183 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
184
185         [CMake][WTF] Mirror XCode header directories
186         https://bugs.webkit.org/show_bug.cgi?id=191662
187
188         Reviewed by Konstantin Tokarev.
189
190         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
191         builds.
192
193         * CMakeLists.txt:
194         * DumpRenderTree/CMakeLists.txt:
195         * DumpRenderTree/PlatformWin.cmake:
196         * MiniBrowser/win/CMakeLists.txt:
197         * TestWebKitAPI/CMakeLists.txt:
198         * TestWebKitAPI/PlatformWin.cmake:
199         * WebKitTestRunner/PlatformGTK.cmake:
200         * WebKitTestRunner/PlatformWin.cmake:
201
202 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
203
204         [ews-app] Status bubble should not display certain infrastructure status messages
205         https://bugs.webkit.org/show_bug.cgi?id=196550
206
207         Reviewed by Lucas Forschler.
208
209         Do not display the steps which are un-needed for end-user. This information is still avaiable
210         if the user click on the bubble and look at the Buildbot build.
211         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
212         (StatusBubble._steps_messages):
213         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
214
215 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
216
217         [ews-build] Use https for sending data to ews-app
218         https://bugs.webkit.org/show_bug.cgi?id=196492
219
220         Reviewed by Lucas Forschler.
221
222         * BuildSlaveSupport/ews-build/events.py:
223
224 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
225
226         Remove support for -apple-trailing-word
227         https://bugs.webkit.org/show_bug.cgi?id=196525
228
229         Reviewed by Zalan Bujtas.
230
231         This CSS property is nonstandard and not used.
232
233         * Scripts/webkitperl/FeatureList.pm:
234         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
235
236 2019-04-03  Youenn Fablet  <youenn@apple.com>
237
238         Add a test for DOMCache on multiple browsing in case of private browsing
239         https://bugs.webkit.org/show_bug.cgi?id=196524
240
241         Reviewed by Alex Christensen.
242
243         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
244         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
245
246 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
247
248         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
249         https://bugs.webkit.org/show_bug.cgi?id=196540
250
251         Reviewed by Aakash Jain.
252
253         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
254
255 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
256
257         Add plumbing for a compatibility mode preference in WebKit
258         https://bugs.webkit.org/show_bug.cgi?id=196005
259
260         Reviewed by Tim Horton.
261
262         Add new API tests.
263
264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
265         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
266
267 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
268
269         [WPE][GTK] Update libsrtp dependency package for Debian
270         https://bugs.webkit.org/show_bug.cgi?id=196528
271
272         Reviewed by Frédéric Wang.
273
274         * gtk/install-dependencies:
275         * wpe/install-dependencies:
276
277 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
278
279         [WK2] Add support for Window's beforeprint / afterprint events
280         https://bugs.webkit.org/show_bug.cgi?id=196478
281         <rdar://problem/49535124>
282
283         Unreviewed build fix for MSVC.
284
285         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
286
287         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
288
289         * WebKitTestRunner/TestController.cpp:
290         (WTR::printFrame): Use int and float literals.
291
292 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
293
294         [ews-build] Reassign bots to queues
295
296         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
297
298 2019-04-02  Chris Dumez  <cdumez@apple.com>
299
300         [WK2] Add support for Window's beforeprint / afterprint events
301         https://bugs.webkit.org/show_bug.cgi?id=196478
302
303         Reviewed by Alex Christensen.
304
305         Add minimal implementation for printFrame in WebKitTestRunner.
306
307         * WebKitTestRunner/TestController.cpp:
308         (WTR::printFrame):
309         (WTR::TestController::createOtherPage):
310         (WTR::TestController::createWebViewWithOptions):
311
312 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
313
314         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
315         https://bugs.webkit.org/show_bug.cgi?id=196491
316
317         Reviewed by Lucas Forschler.
318
319         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
320
321 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
322
323         [ews-build] Configure buildbot try credentials in environment variables
324         https://bugs.webkit.org/show_bug.cgi?id=196501
325
326         Reviewed by Lucas Forschler.
327
328         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
329         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
330         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
331
332 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
333
334         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
335         https://bugs.webkit.org/show_bug.cgi?id=196496
336         <rdar://problem/49521634>
337
338         Reviewed by Chris Dumez.
339
340         Add new API tests (see WebKit ChangeLog for more detail).
341
342         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
343         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
344         (TEST):
345
346 2019-04-02  David Kilzer  <ddkilzer@apple.com>
347
348         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
349         <https://webkit.org/b/196499>
350
351         Reviewed by Alexey Proskuryakov.
352
353         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
354         ENABLE_ADDRESS_SANITIZER.
355
356 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
357
358         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
359         https://bugs.webkit.org/show_bug.cgi?id=182757
360
361         Reviewed by Don Olmstead.
362
363         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
364         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
365
366 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
367
368         run-api-tests: Upload test results
369         https://bugs.webkit.org/show_bug.cgi?id=196323
370         <rdar://problem/49356714>
371
372         Reviewed by Lucas Forschler.
373
374         * Scripts/webkitpy/api_tests/manager.py:
375         (Manager):
376         (Manager.run): Upload results to a results database.
377         * Scripts/webkitpy/api_tests/run_api_tests.py:
378         (parse_args): Add upload arguments.
379         * Scripts/webkitpy/port/base.py:
380         (Port):
381         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
382         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
383         with commits from any other associated repositories.
384         * Scripts/webkitpy/port/device.py:
385         (Device):
386         (Device.build_version): Access build_versoin of underlying platform device.
387         * Scripts/webkitpy/port/ios_simulator_unittest.py:
388         (IOSSimulatorTest):
389         (IOSSimulatorTest.test_configuration_for_upload):
390         * Scripts/webkitpy/port/device_port.py:
391         (DevicePort):
392         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
393         the same as the machine uploading results.
394         * Scripts/webkitpy/port/mac.py:
395         (MacPort):
396         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
397         * Scripts/webkitpy/port/mac_unittest.py:
398         (MacTest):
399         (MacTest.test_configuration_for_upload):
400         * Scripts/webkitpy/xcode/simulated_device.py:
401         (SimulatedDeviceManager._create_device_with_runtime):
402         (SimulatedDevice.__init__): Create simulated device with a build_version.
403         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
404         (test_existing_simulator):
405
406 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
407
408         Remove extra newline characters (Follow-up fix to r243707)
409
410         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
411
412 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
413
414         [ews-app] Use API_KEY to accept results data
415         https://bugs.webkit.org/show_bug.cgi?id=196461
416
417         Reviewed by Dewei Zhu.
418
419         * BuildSlaveSupport/ews-app/ews/views/results.py:
420         (Results.post): Validate EWS_API_KEY before accepting any data.
421         * BuildSlaveSupport/ews-build/events.py:
422         (Events.sendData): Send EWS_API_KEY if available along with event data.
423
424 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
425
426         Unable to copy and paste a PDF from Notes into Mail compose body
427         https://bugs.webkit.org/show_bug.cgi?id=196442
428         <rdar://problem/48573098>
429
430         Reviewed by Tim Horton.
431
432         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
433         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
434         to be specified on the item providers.
435
436         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
437         (TestWebKitAPI::mapItemForTesting):
438         (TestWebKitAPI::contactItemForTesting):
439
440 2019-04-01  Tim Horton  <timothy_horton@apple.com>
441
442         Make UIWKDocumentContext rects per-character instead of per-word
443         https://bugs.webkit.org/show_bug.cgi?id=196459
444
445         Reviewed by Wenson Hsieh.
446
447         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
448         (TEST):
449         Adjust test results due to switching to per-character rects.
450
451 2019-04-01  Chris Dumez  <cdumez@apple.com>
452
453         UIProcess crash when a prewarmed process is terminated
454         https://bugs.webkit.org/show_bug.cgi?id=196451
455         <rdar://problem/49245471>
456
457         Reviewed by Geoffrey Garen.
458
459         Add API test coverage.
460
461         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
462         (TEST):
463
464 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
465
466         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
467         https://bugs.webkit.org/show_bug.cgi?id=196449
468
469         Reviewed by Lucas Forschler.
470
471         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
472         (StatusBubble.get_os_details): Method to get OS and Xcode details.
473         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
474         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
475
476 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
477
478         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
479         https://bugs.webkit.org/show_bug.cgi?id=196444
480
481         Reviewed by Lucas Forschler.
482
483         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
484
485 2019-04-01  Alex Christensen  <achristensen@webkit.org>
486
487         Add SPI to canonicalize NSURLs with WTF::URL
488         https://bugs.webkit.org/show_bug.cgi?id=196415
489         <rdar://problem/44980271>
490
491         Reviewed by Darin Adler.
492
493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
494         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
495         (TestWebKitAPI::TEST):
496
497 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
498
499         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
500         https://bugs.webkit.org/show_bug.cgi?id=196441
501
502         Reviewed by Carlos Garcia Campos.
503
504         Don't cache the wpe_view_backend object that might not exist yet at the
505         time of EventSenderProxy constructor invocation, but instead retrieve
506         that object whenever it's required for event dispatching. This should
507         avoid crashes in this constructor now that it's invoked before any
508         PlatformWindow has been set up (as changed in r243496).
509
510         * WebKitTestRunner/EventSenderProxy.h:
511         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
512         (WTR::viewBackend):
513         (WTR::EventSenderProxy::EventSenderProxy):
514         (WTR::EventSenderProxy::mouseDown):
515         (WTR::EventSenderProxy::mouseUp):
516         (WTR::EventSenderProxy::mouseMoveTo):
517         (WTR::EventSenderProxy::mouseScrollBy):
518         (WTR::EventSenderProxy::keyDown):
519         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
520
521 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
522
523         [Win][WebKit] MiniBrowser should support high DPI display
524         https://bugs.webkit.org/show_bug.cgi?id=196391
525
526         Reviewed by Alex Christensen.
527
528         * MiniBrowser/win/WebKitBrowserWindow.cpp:
529         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
530         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
531         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
532
533 2019-03-31  Sam Weinig  <weinig@apple.com>
534
535         Remove more i386 specific configurations
536         https://bugs.webkit.org/show_bug.cgi?id=196430
537
538         Reviewed by Alexey Proskuryakov.
539
540         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
541         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
542
543 2019-03-31  Andy Estes  <aestes@apple.com>
544
545         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
546         https://bugs.webkit.org/show_bug.cgi?id=196433
547         <rdar://problem/49293305>
548
549         Reviewed by Tim Horton.
550
551         Enhanced API test coverage to include all navigation response policy decisions in both
552         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
553
554         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
555         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
556         (TestWebKitAPI::TEST):
557         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
558         (readFile):
559         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
560         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
561         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
562         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
563         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
564         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
565         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
566         (-[QuickLookDelegate _downloadDidStart:]):
567         (-[QuickLookDelegate _download:didReceiveResponse:]):
568         (-[QuickLookDelegate _download:didReceiveData:]):
569         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
570         (-[QuickLookDelegate _downloadDidFinish:]):
571         (-[QuickLookDelegate _download:didFailWithError:]):
572         (-[QuickLookDelegate _downloadDidCancel:]):
573         (-[QuickLookDelegate verifyDownload]):
574         (runTest):
575         (runTestDecideBeforeLoading):
576         (runTestDecideAfterLoading):
577         (TEST):
578         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
579         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
580         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
581         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
582         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
583         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
584         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
585         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
586         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
587         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
588         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
589         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
590         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
591         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
592
593 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
594
595         [CMake] add testdfg as target with build-jsc
596         https://bugs.webkit.org/show_bug.cgi?id=196393
597
598         Reviewed by Saam Barati.
599
600         Added testdfg as one of the targets to build when
601         using CMake.
602
603         * Scripts/build-jsc:
604
605 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
606
607         Delete WebMetal implementation in favor of WebGPU
608         https://bugs.webkit.org/show_bug.cgi?id=195418
609
610         Reviewed by Dean Jackson.
611
612         * DumpRenderTree/mac/DumpRenderTree.mm:
613         (enableExperimentalFeatures):
614         (resetWebPreferencesToConsistentValues):
615         * Scripts/webkitperl/FeatureList.pm:
616         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
618         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
619         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
620         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
621         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
622         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
623         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
624         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
625         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
626         (WTR::InjectedBundle::beginTesting):
627         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
628         (WTR::TestRunner::setWebMetalEnabled): Deleted.
629         * WebKitTestRunner/InjectedBundle/TestRunner.h:
630
631 2019-03-29  Chris Dumez  <cdumez@apple.com>
632
633         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
634         https://bugs.webkit.org/show_bug.cgi?id=196405
635         <rdar://problem/49428130>
636
637         Reviewed by Wenson Hsieh.
638
639         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
640         the popover presentation methods to be no-ops. Use this in the new test added in
641         r243523 so that we do not swizzle those methods for all tests. This is needed because
642         those WatchOS tests rely on the popover getting presented and interactive.
643
644         * WebKitTestRunner/TestController.cpp:
645         (WTR::updateTestOptionsFromTestHeader):
646         * WebKitTestRunner/TestController.h:
647         * WebKitTestRunner/TestOptions.h:
648         (WTR::TestOptions::hasSameInitializationOptions const):
649         * WebKitTestRunner/ios/TestControllerIOS.mm:
650         (WTR::TestController::platformInitialize):
651         (WTR::TestController::platformResetStateToConsistentValues):
652
653 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
654
655         [Curl] Add Server Trust Evaluation Support.
656         https://bugs.webkit.org/show_bug.cgi?id=191646
657
658         Reviewed by Fujii Hironori.
659
660         Implemented MiniBrowser UI for asking if user trusts the server.
661
662         * MiniBrowser/win/Common.cpp:
663         (askServerTrustEvaluation):
664         (replaceString):
665         * MiniBrowser/win/Common.h:
666         * MiniBrowser/win/MiniBrowserLib.rc:
667         * MiniBrowser/win/MiniBrowserLibResource.h:
668         * MiniBrowser/win/WebKitBrowserWindow.cpp:
669         (createPEMString):
670         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
671         (WebKitBrowserWindow::canTrustServerCertificate):
672         * MiniBrowser/win/WebKitBrowserWindow.h:
673
674 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
675
676         Implement ResizeObserver.
677         https://bugs.webkit.org/show_bug.cgi?id=157743
678
679         Reviewed by Simon Fraser.
680
681         Support resizeObserverEnabled webPreferences.
682
683         * DumpRenderTree/TestOptions.cpp:
684         (TestOptions::TestOptions):
685         * DumpRenderTree/TestOptions.h:
686         * DumpRenderTree/mac/DumpRenderTree.mm:
687         (setWebPreferencesForTestOptions):
688         * DumpRenderTree/win/DumpRenderTree.cpp:
689         (enableExperimentalFeatures):
690         * Scripts/webkitperl/FeatureList.pm:
691         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
692
693 2019-03-28  John Wilander  <wilander@apple.com>
694
695         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
696         https://bugs.webkit.org/show_bug.cgi?id=196281
697         <rdar://problem/48938748>
698
699         Reviewed by Alex Christensen.
700
701         This patch adds the function isStatisticsHasLocalStorage() to the
702         TestRunner. With it, the page can query the WebsiteDataStore in the
703         UI process to make sure that it sees LocalStorage.
704
705         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
706         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
707         (WTR::TestRunner::isStatisticsHasLocalStorage):
708         * WebKitTestRunner/InjectedBundle/TestRunner.h:
709         * WebKitTestRunner/TestController.cpp:
710         (WTR::TestController::isStatisticsHasLocalStorage):
711         * WebKitTestRunner/TestController.h:
712         * WebKitTestRunner/TestInvocation.cpp:
713         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
714
715 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
716
717         API::Data::createWithoutCopying should do a null check before calling CFRelease
718         https://bugs.webkit.org/show_bug.cgi?id=196276
719         <rdar://problem/48059859>
720
721         Reviewed by Alex Christensen.
722
723         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
724
725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
726         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
727         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
728         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
729         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
730         (TestWebKitAPI::TEST):
731
732 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
733
734         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
735         https://bugs.webkit.org/show_bug.cgi?id=186276
736
737         Reviewed by Carlos Garcia Campos.
738
739         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
740         (webViewLoadChanged):
741         (testWebResourceGetDataError):
742         (testWebResourceGetDataEmpty):
743         (beforeAll):
744         (webViewloadChanged): Deleted.
745
746 2019-03-27  Andy Estes  <aestes@apple.com>
747
748         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
749         https://bugs.webkit.org/show_bug.cgi?id=196317
750
751         Reviewed by Dan Bernstein.
752
753         package-root copies built products into a staging directory using ditto(1), which does not
754         follow symbolic links as it traverses a directory. Now that the files in
755         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
756         itself, these become broken links when ditto'd into the staging directory.
757
758         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
759
760         * Scripts/package-root:
761
762 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
763
764         [ews-app] Update display text of Submit for ews analysis
765         https://bugs.webkit.org/show_bug.cgi?id=196309
766
767         Reviewed by Dewei Zhu.
768
769         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
770
771 2019-03-27  David Kilzer  <ddkilzer@apple.com>
772
773         run-webkit-tests should check for leaks in WebKit processes
774         <https://webkit.org/b/193772>
775         <rdar://problem/46526680>
776
777         Reviewed by Ryosuke Niwa.
778
779         This works by doing the following:
780         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
781           The list of child processes are returned one per line:
782           process.name: pid
783         - Run the "#LIST CHILD PROCESSES" command just before the
784           "#CHECK FOR WORLD LEAKS" command, and store the list of child
785           processes on the ServerProcess object.
786         - When the `--leaks` switch is handled, run check_for_leaks() on
787           each child process after the main test harness.
788
789         * DumpRenderTree/mac/DumpRenderTree.mm:
790         (handleControlCommand):
791         - Use strncmp() instead of strcmp().
792         - Add support for handling "#LIST CHILD PROCESSES" command.
793
794         * Scripts/webkitpy/port/base.py:
795         (Port.check_for_leaks):
796         * Scripts/webkitpy/port/darwin.py:
797         (DarwinPort.check_for_leaks):
798         - Rename redundant 'process_pid' argument to 'process_id'.
799
800         * Scripts/webkitpy/port/driver.py:
801         (Driver.do_post_tests_work):
802         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
803           longer the only command this sends to WebKitTestRunner.
804         - If the `--leaks` switch is present, send the
805           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
806           result using Port.set_webkit_processes().
807         (Driver._parse_child_processes_output):
808         - Add helper method to parse list of child process names and
809           process IDs returned from WebKitTestRunner.
810
811         * Scripts/webkitpy/port/ios_device.py:
812         (IOSDevicePort.check_for_leaks):
813         - Rename redundant 'process_pid' argument to 'process_id'.
814
815         * Scripts/webkitpy/port/leakdetector.py:
816         (LeakDetector._parse_leaks_output):
817         - Return early if there is no leaks_output.
818         (LeakDetector.check_for_leaks):
819         - Rename redundant 'process_pid' argument to 'process_id'.
820
821         * Scripts/webkitpy/port/server_process.py:
822         (ServerProcess.__init__):
823         (ServerProcess.child_processes):
824         (ServerProcess.set_child_processes):
825         - Add instance variable to Port to store list of child process
826           names and process IDs returned from WebKitTestRunner.
827         (ServerProcess._start):
828         - Clear self._child_processes.
829         (ServerProcess.stop):
830         - If self._child_processes is set, call
831           self._port.check_for_leaks() for each child process.
832
833         * Scripts/webkitpy/port/server_process_unittest.py:
834         (TrivialMockPort.check_for_leaks):
835         - Rename redundant 'process_pid' argument to 'process_id'.
836
837         * Scripts/webkitpy/port/simulator_process.py:
838         (SimulatorProcess.stop):
839         - If self._child_processes is set, call
840           self._port.check_for_leaks() for each child process.
841
842         * Scripts/webkitpy/port/watch_device.py:
843         (WatchDevicePort.check_for_leaks):
844         - Rename redundant 'process_pid' argument to 'process_id'.
845
846         * WebKitTestRunner/TestController.cpp:
847         (WTR::TestController::dumpResponse):
848         - Extract method from findAndDumpWorldLeaks() so that it may be
849           reused by findAndDumpWebKitProcessIdentifiers().
850         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
851         - Add method to output process name and process ID of both the
852           WebContent and Networking processes.
853         (WTR::TestController::findAndDumpWorldLeaks):
854         - Fix missing newline in output when there were no abandoned
855           documents.
856         - Call dumpResponse() for extracted code.
857         (WTR::TestController::handleControlCommand):
858         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
859         - Use strncmp() instead of strcmp().
860         - Call findAndDumpWebKitProcessIdentifiers() when
861           "#LIST CHILD PROCESSES" command is sent.
862         * WebKitTestRunner/TestController.h:
863         (WTR::TestController::dumpResponse):
864         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
865         - Declare methods.
866
867 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
868
869         Unreviewed. Add GLib API test cases after r243434.
870
871         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
872         (testWebViewActiveURI):
873         (serverCallback):
874         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
875         (sendRequestCallback):
876
877 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
878
879         Geolocation request not complete when watch request was started in a different web process
880         https://bugs.webkit.org/show_bug.cgi?id=195996
881
882         Reviewed by Alex Christensen.
883
884         Add a test case.
885
886         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
887         (TestWebKitAPI::runJavaScriptAlert):
888         (TestWebKitAPI::TEST):
889
890 2019-03-26  Keith Rollin  <krollin@apple.com>
891
892         Update the way generate-xcfilelists returns strings from functions
893         https://bugs.webkit.org/show_bug.cgi?id=195975
894         <rdar://problem/49040807>
895
896         Reviewed by Dean Jackson.
897
898         There are places where generate-xcfilelists executes assignments with
899         statements like:
900
901             FOO=$(some_function)
902
903         where "some_function" return a string by echoing it. E.g.
904
905             some_function()
906             {
907                 echo "Hello, World"
908             }
909
910         This is a common idiom, but it has a problem if "some_function" needs
911         to call "exit" in an attempt to halt the entire script right then and
912         there. Since "some_function" is called inside of $(), it's being
913         executed in a sub-shell. Calling exit in that sub-shell simply exits
914         that shell; it doesn't not exit the outer shell in which the main part
915         of the script is still running. As such, the main script keeps
916         executing when the intent was for the script to halt.
917
918         The solution to this is to use a different idiom for returning
919         strings. The one we now is to pass in the name of the variable to
920         receive the string result:
921
922             some_function()
923             {
924                 variable_name=$1
925                 eval $variable_name ="Hello, World"
926             }
927
928         The call site now looks like
929
930             some_function FOO
931
932         Because there's no invocation of a sub-shell, some_function can now
933         call "exit" if it wants to, and the entire script will exit at that
934         point.
935
936         * Scripts/generate-xcfilelists:
937
938 2019-03-26  Chris Dumez  <cdumez@apple.com>
939
940         Add basic layout test coverage for File Picker on iOS
941         https://bugs.webkit.org/show_bug.cgi?id=196265
942
943         Reviewed by Wenson Hsieh.
944
945         Add layout test infrastructure to test the file picker on iOS.
946
947         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
948         (WTR::UIScriptController::dismissFilePicker):
949         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
950         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
951         (WTR::UIScriptController::dismissFilePicker):
952         * TestRunnerShared/UIScriptContext/UIScriptController.h:
953         * WebKitTestRunner/TestController.cpp:
954         (WTR::TestController::createWebViewWithOptions):
955         (WTR::updateTestOptionsFromTestHeader):
956         * WebKitTestRunner/TestOptions.h:
957         (WTR::TestOptions::hasSameInitializationOptions const):
958         * WebKitTestRunner/ios/TestControllerIOS.mm:
959         (overridePresentViewController):
960         (WTR::TestController::platformInitialize):
961         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
962         (WTR::UIScriptController::dismissFilePicker):
963
964 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
965
966         Implement async paste method on UIWKInteractionViewProtocol
967         https://bugs.webkit.org/show_bug.cgi?id=196267
968         <rdar://problem/49236346>
969
970         Reviewed by Tim Horton.
971
972         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
973         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
974         are now a part of all iOS 12 internal SDKs.
975
976         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
977
978         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
979         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
980
981         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
982         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
983         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
984         * TestWebKitAPI/ios/UIKitSPI.h:
985
986 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
987
988         [ews-build] Use PostgreSQL for ews.webkit.org database
989         https://bugs.webkit.org/show_bug.cgi?id=196270
990
991         Reviewed by Lucas Forschler.
992
993         * BuildSlaveSupport/ews-app/ews-app/settings.py:
994
995 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
996
997         [ews] Reset simctl states on reboot
998         https://bugs.webkit.org/show_bug.cgi?id=196260
999
1000         Rubber-stamped by Aakash Jain.
1001
1002         * EWSTools/start-queue-mac.sh:
1003
1004 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1005
1006         [ews-build] Use PostgreSQL for ews-build database
1007         https://bugs.webkit.org/show_bug.cgi?id=196229
1008
1009         Reviewed by Lucas Forschler.
1010
1011         * BuildSlaveSupport/ews-build/master.cfg:
1012
1013 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1014
1015         [ews-build] Get master_hostname dynamically in master.cfg
1016         https://bugs.webkit.org/show_bug.cgi?id=196255
1017
1018         Reviewed by Lucas Forschler.
1019
1020         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1021         send events data in test mode.
1022
1023 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1024
1025         [ews-app] Set db_constraint to False for Foreign Keys
1026         https://bugs.webkit.org/show_bug.cgi?id=196252
1027
1028         Reviewed by Lucas Forschler.
1029
1030         * BuildSlaveSupport/ews-app/ews/models/build.py:
1031         * BuildSlaveSupport/ews-app/ews/models/step.py:
1032
1033 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1034
1035         [ews-build] is_test_mode_enabled should default to True
1036         https://bugs.webkit.org/show_bug.cgi?id=196248
1037
1038         Reviewed by Lucas Forschler.
1039
1040         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1041
1042 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1043
1044         [ews-app] Add webkitperl to ENABLED_QUEUES
1045         https://bugs.webkit.org/show_bug.cgi?id=196253
1046
1047         Reviewed by Lucas Forschler.
1048
1049         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1050
1051 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1052
1053         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1054         https://bugs.webkit.org/show_bug.cgi?id=196211
1055         rdar://problem/49110552
1056
1057         Reviewed by Tim Horton.
1058
1059         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1060         Make sure that EventSenderProxy always exists when running tests. We used to create
1061         it when resetting before the first test, which is a bit too late.
1062
1063         * WebKitTestRunner/TestController.h:
1064         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1065         (WTR::TestController::platformCreateWebView):
1066         (WTR::TestController::platformCreateOtherPage):
1067         (WTR::TestController::finishCreatingPlatformWebView):
1068         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1069         (WTR::PlatformWebView::PlatformWebView):
1070         Moved some code that made NSWindow use NSEvent during web view creation. We may
1071         need to move more if some other case us found, but this is enough for now.
1072
1073 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1074
1075         Unreviewed. Fix typo in GLib geolocation API after r243285.
1076
1077         gelocation -> geolocation.
1078
1079         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1080         (testGeolocationManagerWatchPosition):
1081
1082 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1083
1084         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1085         https://bugs.webkit.org/show_bug.cgi?id=196213
1086
1087         Reviewed by Geoff Garen.
1088
1089         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1090         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1091         (credentialWithIdentityAndKeychainPath):
1092         (-[ChallengeDelegate webView:didFinishNavigation:]):
1093         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1094         (TestWebKitAPI::TEST):
1095
1096 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1097
1098         Expected shouldn't assume its contained types are copyable
1099         https://bugs.webkit.org/show_bug.cgi?id=195986
1100
1101         Reviewed by JF Bastien.
1102
1103         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1104         (TestWebKitAPI::NonCopyable::operator== const):
1105         (TestWebKitAPI::NonCopyable::operator!= const):
1106         (TestWebKitAPI::TEST):
1107
1108 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1109
1110         Remove some now-unnecessary dynamic class lookup
1111         https://bugs.webkit.org/show_bug.cgi?id=196237
1112
1113         Reviewed by Simon Fraser.
1114
1115         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1116         (makeRequest):
1117         (TEST):
1118
1119 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1120
1121         Unreviewed, rolling out r243450.
1122
1123         AppleWin and WinCairo port builds get broken.
1124
1125         Reverted changeset:
1126
1127         "Add test for fix of #196095"
1128         https://bugs.webkit.org/show_bug.cgi?id=196097
1129         https://trac.webkit.org/changeset/243450
1130
1131 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1132
1133         Unreviewed, rolling out r243465.
1134         https://bugs.webkit.org/show_bug.cgi?id=196226
1135
1136         the test doesn't build (Requested by thorton on #webkit).
1137
1138         Reverted changeset:
1139
1140         "Do not terminate the NetworkProcess if a third party
1141         application sends a NSCredential with a SecIdentityRef"
1142         https://bugs.webkit.org/show_bug.cgi?id=196213
1143         https://trac.webkit.org/changeset/243465
1144
1145 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1146
1147         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1148         https://bugs.webkit.org/show_bug.cgi?id=196213
1149
1150         Reviewed by Geoff Garen.
1151
1152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1153         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1154         (credentialWithIdentityAndKeychainPath):
1155         (-[ChallengeDelegate webView:didFinishNavigation:]):
1156         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1157         (TestWebKitAPI::TEST):
1158
1159 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1160
1161         [ews-build] Gracefully handle missing patch_id in events
1162         https://bugs.webkit.org/show_bug.cgi?id=196216
1163
1164         Reviewed by Lucas Forschler.
1165
1166         * BuildSlaveSupport/ews-build/events.py:
1167
1168 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1169
1170         [ews-build] use lz4 compression for improving buildbot performance
1171         https://bugs.webkit.org/show_bug.cgi?id=196155
1172
1173         Reviewed by Lucas Forschler.
1174
1175         * BuildSlaveSupport/ews-build/master.cfg:
1176
1177 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1178
1179         Pull some API testing helper methods out of TestWKWebView
1180         https://bugs.webkit.org/show_bug.cgi?id=196212
1181
1182         Reviewed by Tim Horton.
1183
1184         Refactor some more API testing utility methods, so that they can be used in
1185         tests that do not use TestWKWebView.
1186
1187         * TestWebKitAPI/cocoa/TestWKWebView.h:
1188         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1189         (-[WKWebView loadTestPageNamed:]):
1190         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1191         (-[WKWebView synchronouslyLoadHTMLString:]):
1192         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1193         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1194         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1195         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1196         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1197
1198 2019-03-25  Jer Noble  <jer.noble@apple.com>
1199
1200         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1201         https://bugs.webkit.org/show_bug.cgi?id=196097
1202
1203         Reviewed by Eric Carlson.
1204
1205         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1206
1207         * DumpRenderTree/mac/DumpRenderTree.mm:
1208         (resetWebPreferencesToConsistentValues):
1209         * WebKitTestRunner/TestController.cpp:
1210         (WTR::TestController::resetPreferencesToConsistentValues):
1211
1212 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1213
1214         Pull IPadUserInterfaceSwizzler out into a separate header file
1215         https://bugs.webkit.org/show_bug.cgi?id=196193
1216
1217         Reviewed by Anders Carlsson.
1218
1219         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1220         be used in other API tests.
1221
1222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1223         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1224         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1225         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1226         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1227         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1228         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1229
1230 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1231
1232         Remove NavigatorContentUtils in WebCore/Modules
1233         https://bugs.webkit.org/show_bug.cgi?id=196070
1234
1235         Reviewed by Alex Christensen.
1236
1237         NavigatorContentUtils was to support the custom scheme spec [1].
1238         However, in WebKit side, no port has supported the feature in
1239         WebKit layer after EFL port was removed. So there has been the
1240         only IDL implementation of the NavigatorContentUtils in WebCore.
1241         So we don't need to keep the implementation in WebCore anymore.
1242
1243         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1244
1245         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1246
1247 2019-03-24  Andy Estes  <aestes@apple.com>
1248
1249         [watchOS] Remove unused Proximity Networking code
1250         https://bugs.webkit.org/show_bug.cgi?id=196188
1251
1252         Reviewed by Tim Horton.
1253
1254         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1255         (TEST):
1256
1257 2019-03-23  Keith Miller  <keith_miller@apple.com>
1258
1259         Refactor clz/ctz and fix getLSBSet.
1260         https://bugs.webkit.org/show_bug.cgi?id=196162
1261
1262         Reviewed by Saam Barati.
1263
1264         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1265
1266         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1267         (TestWebKitAPI::TEST):
1268
1269 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1270
1271         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1272         https://bugs.webkit.org/show_bug.cgi?id=196143
1273
1274         Reviewed by Michael Catanzaro.
1275
1276         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1277         directories.
1278
1279         * Scripts/webkitpy/style/checkers/cpp.py:
1280         (check_identifier_name_in_declaration):
1281         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1282         (WebKitStyleTest.test_names):
1283
1284 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1285
1286         [Flatpak] Manifest expanding fails for qt WPE extension
1287         https://bugs.webkit.org/show_bug.cgi?id=196148
1288
1289         Reviewed by Alex Christensen.
1290
1291         * flatpak/flatpakutils.py:
1292         (expand_submodules_recurse): The last recurse manifest expand
1293         iteration might lead to a single module so take it into account
1294         and don't try to recurse further.
1295
1296 2019-03-22  Chris Dumez  <cdumez@apple.com>
1297
1298         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1299         https://bugs.webkit.org/show_bug.cgi?id=195348
1300         <rdar://problem/48622090>
1301
1302         Reviewed by Alex Christensen.
1303
1304         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1305         to NO when test.options().shouldIgnoreMetaViewport is false.
1306
1307         * WebKitTestRunner/ios/TestControllerIOS.mm:
1308         (WTR::TestController::platformConfigureViewForTest):
1309
1310 2019-03-22  Chris Dumez  <cdumez@apple.com>
1311
1312         Prewarmed processes should be usable with any website data store
1313         https://bugs.webkit.org/show_bug.cgi?id=196104
1314
1315         Reviewed by Alex Christensen.
1316
1317         Add API test coverage.
1318
1319         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1320         (runInitialWarmedProcessUsedTest):
1321         (TEST):
1322
1323 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1324
1325         Back out local changes to Alex's Subversion working directory
1326
1327         They were accidentally committed.
1328
1329         * Scripts/webkitpy/common/system/abstractexecutive.py:
1330         (AbstractExecutive.wait_newest):
1331         * Scripts/webkitpy/common/system/executive.py:
1332         (Executive.running_pids):
1333         * Scripts/webkitpy/common/system/executive_mock.py:
1334         (MockExecutive.running_pids):
1335         * Scripts/webkitpy/common/system/executive_unittest.py:
1336         (ExecutiveTest.serial_test_running_pids):
1337         * Scripts/webkitpy/port/darwin.py:
1338         (DarwinPort.check_for_leaks):
1339         * Scripts/webkitpy/port/leakdetector.py:
1340         (LeakDetector.check_for_leaks):
1341         - This was the hack attached to Bug 193772.
1342
1343         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1344         (+[WebKitTestRunnerEvent mouseLocation]):
1345         - This works around a crash on an internal build.
1346
1347 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1348
1349         Fix the build after r243354
1350         https://bugs.webkit.org/show_bug.cgi?id=196138
1351         <rdar://problem/49145951>
1352
1353         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1354         (TEST):
1355         * TestWebKitAPI/ios/UIKitSPI.h:
1356
1357 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1358
1359         Adopt UIWKDocumentContext
1360         https://bugs.webkit.org/show_bug.cgi?id=196040
1361         <rdar://problem/48642440>
1362
1363         Reviewed by Ryosuke Niwa.
1364
1365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1366         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1367         (makeRequest):
1368         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1369         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1370         (applyStyle):
1371         (TEST):
1372         Add tests for UIWKDocumentContext.
1373
1374         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1375         (TEST):
1376         (recursiveFindWKContentView): Deleted.
1377         * TestWebKitAPI/cocoa/TestWKWebView.h:
1378         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1379         (recursiveFindWKContentView):
1380         (-[TestWKWebView wkContentView]):
1381         * TestWebKitAPI/ios/UIKitSPI.h:
1382         Share the WKContentView finding code between tests.
1383
1384 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1385
1386         [iOS WK2] Turn on async overflow scrolling by default
1387         https://bugs.webkit.org/show_bug.cgi?id=196011
1388         rdar://problem/48453859
1389
1390         Reviewed by Antti Koivisto.
1391         
1392         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1393         since so many basic layout tests have different results when compositing is triggered for
1394         overflow.
1395         
1396         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1397
1398         * WebKitTestRunner/TestController.cpp:
1399         (WTR::TestController::resetPreferencesToConsistentValues):
1400
1401 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1402
1403         [ews-build] Retry API test in case of failures
1404         https://bugs.webkit.org/show_bug.cgi?id=196004
1405
1406         Reviewed by Lucas Forschler.
1407
1408         * BuildSlaveSupport/ews-build/steps.py:
1409         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1410         (CompileWebKitToT.doStepIf): Ditto.
1411         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1412         (ReRunAPITests): Re-run API tests.
1413         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1414         (RunAPITestsWithoutPatch): Run API tests without patch.
1415         (RunAPITestsWithoutPatch.doStepIf):
1416         (RunAPITestsWithoutPatch.hideStepIf):
1417         (RunAPITestsWithoutPatch.evaluateCommand):
1418         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1419         (AnalyzeAPITestsResults.start):
1420         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1421         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1422         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1423         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1424
1425 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1426
1427         [ews-build] Update queues configurations
1428         https://bugs.webkit.org/show_bug.cgi?id=196074
1429
1430         Reviewed by Dewei Zhu.
1431
1432         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1433         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1434
1435 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1436
1437         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1438         https://bugs.webkit.org/show_bug.cgi?id=195680
1439         <rdar://problem/48903534>
1440
1441         Unreviewed infrastructure fix.
1442
1443         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1444         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1445
1446 2019-03-21  Andy Estes  <aestes@apple.com>
1447
1448         [iOS] Apple Pay should be available in documents with no user agent scripts
1449         https://bugs.webkit.org/show_bug.cgi?id=196061
1450         <rdar://problem/48649391>
1451
1452         Reviewed by Brady Eidson.
1453
1454         Added API tests and related infrastructure.
1455
1456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1457         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1458         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1459         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1460         (TestWebKitAPI::TEST):
1461         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1462         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1463         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1464         * TestWebKitAPI/cocoa/TestProtocol.mm:
1465         (-[TestProtocol startLoading]):
1466         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1467         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1468         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1469         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1470
1471 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1472
1473         REGRESSSION (r243297): webkitpy tests broken
1474         https://bugs.webkit.org/show_bug.cgi?id=196108
1475
1476         Reviewed by Aakash Jain.
1477
1478         r243297 updated contributors.json, which broke a few unit tests.
1479
1480         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1481         (IRCCommandTest.test_whois):
1482         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1483
1484 2019-03-21  Chris Dumez  <cdumez@apple.com>
1485
1486         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1487         https://bugs.webkit.org/show_bug.cgi?id=196041
1488         <rdar://problem/49083230>
1489
1490         Reviewed by Alex Christensen.
1491
1492         Add API test coverage.
1493
1494         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1495         (TEST):
1496
1497 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1498
1499         Add SPI to inform applications of WKContentRuleList actions
1500         https://bugs.webkit.org/show_bug.cgi?id=195965
1501         <rdar://problem/42664365>
1502
1503         Reviewed by Geoff Garen.
1504
1505         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1506         (TestWebKitAPI::allActionsForResourceLoad):
1507         (TestWebKitAPI::testRequest):
1508         (TestWebKitAPI::TEST_F):
1509         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1510         (Notification::description):
1511         (Notification::operator== const):
1512         (toVector):
1513         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1514         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1515         (makeContentRuleList):
1516         (TEST):
1517         (makeWarnContentRuleList): Deleted.
1518
1519 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1520
1521         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1522         https://bugs.webkit.org/show_bug.cgi?id=196088
1523
1524         Reviewed by Brian Burg.
1525
1526         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1527         Support checks when only one platform is specified. Also deprecate macosx() and
1528         force the use of macos() instead.
1529
1530         * Scripts/webkitpy/style/checkers/cpp.py:
1531         (check_min_versions_of_wk_api_available):
1532         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1533         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1534
1535 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1536
1537         Update status inactive committers' status to 'contributor'.
1538
1539         * Scripts/webkitpy/common/config/contributors.json:
1540
1541 2019-03-21  Xan Lopez  <xan@igalia.com>
1542
1543         [JSC][x86] Drop support for x87 floating point
1544         https://bugs.webkit.org/show_bug.cgi?id=194853
1545
1546         Reviewed by Don Olmstead.
1547
1548         Force SSE2 on x86/32bit builds.
1549
1550         * Scripts/webkitdirs.pm:
1551         (generateBuildSystemFromCMakeProject):
1552
1553 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1554
1555         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1556         https://bugs.webkit.org/show_bug.cgi?id=196073
1557
1558         Reviewed by Michael Catanzaro.
1559
1560         Add test cases to check functions and constructors with no arguments but receiving user data.
1561
1562         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1563         (checkUserData):
1564         (testJSCFunction):
1565         (fooCreateWithUserData):
1566         (testJSCClass):
1567
1568 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1569
1570         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1571
1572         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1573
1574         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1575
1576 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1577
1578         [GTK][WPE] Add API to provide geolocation information
1579         https://bugs.webkit.org/show_bug.cgi?id=195940
1580
1581         Reviewed by Michael Catanzaro.
1582
1583         Add a new test to check the new API.
1584
1585         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1586         (testGeolocationManagerCurrentPosition):
1587         (testGeolocationManagerWatchPosition):
1588         (beforeAll):
1589         (afterAll):
1590         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1591         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1592         (beforeAll): Ditto.
1593         * TestWebKitAPI/glib/CMakeLists.txt:
1594
1595 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1596
1597         [GLib] Returning G_TYPE_OBJECT from a method does not work
1598         https://bugs.webkit.org/show_bug.cgi?id=195574
1599
1600         Reviewed by Michael Catanzaro.
1601
1602         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1603
1604         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1605         (getGFile):
1606         (getParent):
1607         (createGString):
1608         (getGString):
1609         (getGStringCopyWillRaise):
1610         (getGStringCopy):
1611         (getGStringStr):
1612         (getGStringLen):
1613         (freeGString):
1614         (testJSCClass):
1615
1616 2019-03-20  Saam Barati  <sbarati@apple.com>
1617
1618         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1619         https://bugs.webkit.org/show_bug.cgi?id=195721
1620
1621         Reviewed by Filip Pizlo.
1622
1623         * Scripts/run-javascriptcore-tests:
1624
1625 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1626
1627         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1628         https://bugs.webkit.org/show_bug.cgi?id=196049
1629
1630         Reviewed by Tim Horton.
1631
1632         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1633         overflow scrolling in general, so rename it.
1634
1635         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1636
1637 2019-03-20  Daniel Bates  <dabates@apple.com>
1638
1639         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1640         https://bugs.webkit.org/show_bug.cgi?id=196031
1641         <rdar://problem/49078172>
1642
1643         Reviewed by Tim Horton.
1644
1645         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1646         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1647         same code path used when the Done button is pressed to dismiss the <select> picker.
1648
1649         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1650         (TestWebKitAPI::TEST):
1651
1652 2019-03-20  Chris Dumez  <cdumez@apple.com>
1653
1654         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1655         https://bugs.webkit.org/show_bug.cgi?id=196029
1656         <rdar://problem/48954651>
1657
1658         Reviewed by Tim Horton.
1659
1660         Add API test coverage.
1661
1662         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1663
1664 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1665
1666         [ews-build] Improve failure summary string for ApplyPatch step
1667         https://bugs.webkit.org/show_bug.cgi?id=195995
1668
1669         Reviewed by Alexey Proskuryakov.
1670
1671         * BuildSlaveSupport/ews-build/steps.py:
1672         (ApplyPatch.getResultSummary): Override getResultSummary.
1673
1674 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1675
1676         AX: Implement support for new meter ARIA role
1677         https://bugs.webkit.org/show_bug.cgi?id=195966
1678
1679         Reviewed by Chris Fleizach.
1680
1681         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1682         to AXLevelIndicator.
1683
1684         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1685
1686 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1687
1688         [WebAuthN] Implement FIDO AppID extension
1689         https://bugs.webkit.org/show_bug.cgi?id=143491
1690         <rdar://problem/48298273>
1691
1692         Reviewed by Brent Fulgham.
1693
1694         Add a test that covers the new flag of convertToU2fSignCommand.
1695
1696         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1697         (TestWebKitAPI::TEST):
1698         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1699         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1700         (TestWebKitAPI::TEST):
1701
1702 2019-03-19  Keith Rollin  <krollin@apple.com>
1703
1704         Add support for more platforms to generate-xcfilelists
1705         https://bugs.webkit.org/show_bug.cgi?id=195977
1706
1707         Reviewed by Alexey Proskuryakov.
1708
1709         generate-xcfilelists incorrectly complains when involved with building
1710         WebKit for iphonesimulator:
1711
1712             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1713             …
1714             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1715
1716         Address this by teaching generate-xcfilelists about more platforms.
1717
1718         * Scripts/generate-xcfilelists:
1719
1720 2019-03-19  John Wilander  <wilander@apple.com>
1721
1722         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1723         https://bugs.webkit.org/show_bug.cgi?id=195923
1724         <rdar://problem/49001272>
1725
1726         Reviewed by Alex Christensen.
1727
1728         This patch does the following to the TestRunner:
1729         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1730         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1731         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1732
1733         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1734         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1735         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1736         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1737         * WebKitTestRunner/TestController.cpp:
1738         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1739         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1740         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1741         * WebKitTestRunner/TestController.h:
1742         * WebKitTestRunner/TestInvocation.cpp:
1743         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1744
1745 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1746
1747         [CMake] Support more clang and gcc sanitizers
1748         https://bugs.webkit.org/show_bug.cgi?id=195956
1749
1750         Reviewed by Michael Catanzaro.
1751
1752         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1753
1754 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1755
1756         [ews-build] Improve summary for PrintConfiguration step
1757         https://bugs.webkit.org/show_bug.cgi?id=195945
1758
1759         Reviewed by Lucas Forschler.
1760
1761         * BuildSlaveSupport/ews-build/steps.py:
1762         (PrintConfiguration.getResultSummary): Override getResultSummary.
1763
1764 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1765
1766         [ews-build] Improve summary for CheckOutSource step
1767         https://bugs.webkit.org/show_bug.cgi?id=195963
1768
1769         Reviewed by Lucas Forschler.
1770
1771         * BuildSlaveSupport/ews-build/steps.py:
1772         (CheckOutSource.getResultSummary):
1773
1774 2019-03-19  Daniel Bates  <dabates@apple.com>
1775
1776         [iOS] Focus not preserved when switching between tabs
1777         https://bugs.webkit.org/show_bug.cgi?id=195820
1778         <rdar://problem/43614450>
1779
1780         Reviewed by Brent Fulgham.
1781
1782         Add tests to ensure that we restore focus when resigning and becoming first responder.
1783
1784         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1785         (TestWebKitAPI::TEST):
1786
1787 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1788
1789         Make WTFLogChannelState and WTFLogLevel enum classes
1790         https://bugs.webkit.org/show_bug.cgi?id=195904
1791
1792         Reviewed by Eric Carlson.
1793
1794         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1795         (TestWebKitAPI::TEST_F):
1796
1797 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1798
1799         [GStreamer][EME] Backported mssdemux protection data crash fix
1800         https://bugs.webkit.org/show_bug.cgi?id=195918
1801
1802         Reviewed by Philippe Normand.
1803
1804         * gstreamer/jhbuild.modules:
1805         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1806
1807 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1808
1809         Unreviewed, rolling out r243132.
1810
1811         Broke GTK build
1812
1813         Reverted changeset:
1814
1815         "Make WTFLogChannelState and WTFLogLevel enum classes"
1816         https://bugs.webkit.org/show_bug.cgi?id=195904
1817         https://trac.webkit.org/changeset/243132
1818
1819 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1820
1821         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1822
1823         * Scripts/webkitdirs.pm:
1824         (builtDylibPathForName): Adjust the shared library name that's changed
1825         with the API version bump in r243073.
1826
1827 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1828
1829         Make WTFLogChannelState and WTFLogLevel enum classes
1830         https://bugs.webkit.org/show_bug.cgi?id=195904
1831
1832         Reviewed by Eric Carlson.
1833
1834         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1835         (TestWebKitAPI::TEST_F):
1836
1837 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1838
1839         Disable flaky test added in r2431100
1840         https://webkit.org/b/195785
1841
1842         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1843         (TestWebKitAPI::TEST):
1844         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1845
1846 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1847
1848         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1849         https://bugs.webkit.org/show_bug.cgi?id=195916
1850
1851         Reviewed by Tim Horton.
1852
1853         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1854         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1855
1856 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1857
1858         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1859
1860         * Scripts/webkitpy/common/config/contributors.json:
1861
1862 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1863
1864         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1865         https://bugs.webkit.org/show_bug.cgi?id=195785
1866
1867         Reviewed by Geoffrey Garen.
1868
1869         * TestWebKitAPI/TCPServer.cpp: Added.
1870         (TestWebKitAPI::TCPServer::TCPServer):
1871         (TestWebKitAPI::TCPServer::~TCPServer):
1872         (TestWebKitAPI::TCPServer::socketBindListen):
1873         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1874         * TestWebKitAPI/TCPServer.h: Added.
1875         (TestWebKitAPI::TCPServer::port const):
1876         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1877         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1878         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1879         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1880         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1881         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1882         (TestWebKitAPI::respondSlowly):
1883         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1884         (TestWebKitAPI::downloadAtRate):
1885         (TestWebKitAPI::TEST):
1886
1887 2019-03-18  Saam Barati  <sbarati@apple.com>
1888
1889         Add a plan file for JetStream 2
1890         https://bugs.webkit.org/show_bug.cgi?id=190734
1891
1892         Reviewed by Mark Lam.
1893
1894         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1895
1896 2019-03-18  Chris Dumez  <cdumez@apple.com>
1897
1898         Delay WebProcess launch until a load is triggered in a Web view
1899         https://bugs.webkit.org/show_bug.cgi?id=195758
1900         <rdar://problem/48126013>
1901
1902         Reviewed by Geoff Garen.
1903
1904         Add API test coverage. Also update some existing API tests to not expect
1905         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1906
1907         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1908         (TestWebKitAPI::TEST):
1909         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1910         (TestWebKitAPI::TEST):
1911         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1912         (TEST):
1913         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1914         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1915         (TEST):
1916         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1917         (TEST):
1918         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1919
1920 2019-03-18  Xan Lopez  <xan@igalia.com>
1921
1922         [CMake] Prevent potential warning when determining $architecture
1923         https://bugs.webkit.org/show_bug.cgi?id=195891
1924
1925         Reviewed by Michael Catanzaro.
1926
1927         It's possible for generateBuildSystemForCMakeProject to be called
1928         before determineArchitecture() is ever called. This will make the
1929         first eq check with $architecture to be bogus (and print a
1930         warning). Change that to an eq check with architecture(), which
1931         implicitly calls determineArchitecture() if needed, and change all
1932         the other similar cases in the method in the same way to prevent
1933         future bugs like this one.
1934
1935         * Scripts/webkitdirs.pm:
1936         (generateBuildSystemFromCMakeProject):
1937
1938 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1939
1940         [WPE] Tarballs generated with “make dist” cannot build documentation
1941         https://bugs.webkit.org/show_bug.cgi?id=195885
1942
1943         Reviewed by Carlos Garcia Campos.
1944
1945         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1946
1947 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1948
1949         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1950         https://bugs.webkit.org/show_bug.cgi?id=195883
1951
1952         Reviewed by Carlos Garcia Campos.
1953
1954         * gtkdoc/gtkdoc.py:
1955         (GTKDoc._run_command): When commands fail to run, include the full command line for
1956         the program invocation and the output it has generated on the standard error stream.
1957
1958 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1959
1960         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1961         https://bugs.webkit.org/show_bug.cgi?id=195786
1962
1963         Reviewed by Philippe Normand.
1964
1965         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1966         * wpe/jhbuild.modules: Ditto.
1967
1968 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1969
1970         [ews-build] Don't run clean builds on EWS builders
1971         https://bugs.webkit.org/show_bug.cgi?id=195851
1972
1973         Reviewed by Geoffrey Garen.
1974
1975         * BuildSlaveSupport/ews-build/factories.py:
1976
1977 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1978
1979         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1980         https://bugs.webkit.org/show_bug.cgi?id=195849
1981
1982         Reviewed by Chris Dumez.
1983
1984         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1985
1986         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1987         (runWebsiteDataStoreCustomPaths):
1988
1989 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1990
1991         webkitpy: Upload test results
1992         https://bugs.webkit.org/show_bug.cgi?id=195755
1993         <rdar://problem/48896182>
1994
1995         Reviewed by Aakash Jain.
1996
1997         Establish a new format for uploading results that is not tied to layout tests, apply
1998         that format to webkitpy tests.
1999
2000         * Scripts/webkitpy/common/checkout/scm/git.py:
2001         (Git.native_branch): Return what branch the current checkout is on.
2002         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2003         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2004         * Scripts/webkitpy/common/checkout/scm/svn.py:
2005         (SVN.native_branch): Ditto.
2006         * Scripts/webkitpy/common/system/platforminfo.py:
2007         (PlatformInfo.build_version): Return a build version for Mac.
2008         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2009         (MockPlatformInfo.__init__):
2010         (MockPlatformInfo.build_version):
2011         * Scripts/webkitpy/results: Added.
2012         * Scripts/webkitpy/results/__init__.py: Added.
2013         * Scripts/webkitpy/results/options.py: Added.
2014         (upload_options): OptParse list for upload options.
2015         * Scripts/webkitpy/results/upload.py: Added.
2016         (Upload): Class which enforces the upload format expected by the results server.
2017         (Upload.Expectations):
2018         (Upload.create_configuration):
2019         (Upload.create_commit):
2020         (Upload.create_details):
2021         (Upload.create_run_stats):
2022         (Upload.create_test_result):
2023         (Upload.__init__):
2024         (Upload.Encoder): Encode Upload object as json.
2025         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2026         * Scripts/webkitpy/results/upload_unittest.py: Added.
2027         * Scripts/webkitpy/test/main.py:
2028         (Tester._parse_args): Add upload arguments.
2029         (Tester._run_tests): Allow results to be uploaded.
2030         * Scripts/webkitpy/test/runner.py:
2031         (Runner.__init__): Record which tests were run, rather than just counting them.
2032         (Runner.handle):
2033         * Scripts/webkitpy/test/runner_unittest.py:
2034         (RunnerTest.test_run):
2035         * Scripts/webkitpy/thirdparty/__init__.py:
2036         (AutoinstallImportHook.find_module): Add requests auto-install.
2037         (AutoinstallImportHook._install_requests):
2038         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2039         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2040
2041 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2042
2043         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2044         https://bugs.webkit.org/show_bug.cgi?id=195810
2045
2046         Reviewed by Tim Horton.
2047
2048         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2049         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2050         ending certain layout tests.
2051
2052         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2053         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2054         (-[TestRunnerWKWebView dealloc]):
2055         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2056
2057         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2058         helper method when destroying the web view, and when resetting state between tests.
2059
2060         * WebKitTestRunner/ios/TestControllerIOS.mm:
2061         (WTR::TestController::platformResetStateToConsistentValues):
2062
2063         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2064
2065 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2066
2067         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2068         https://bugs.webkit.org/show_bug.cgi?id=190350
2069         <rdar://problem/45089503>
2070
2071         Reviewed by Geoffrey Garen.
2072
2073         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2074         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2075         (TEST):
2076         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2077         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2078         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2079         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2080         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2081         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2082         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2083         (runTest):
2084         (createDirectories):
2085         (TEST):
2086         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2087         (TEST):
2088         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2089         (TEST):
2090
2091 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2092
2093         Add support to WebPage for getting the contents as an attributed string.
2094         https://bugs.webkit.org/show_bug.cgi?id=195636
2095         rdar://problem/45055697
2096
2097         Reviewed by Tim Horton.
2098
2099         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2100         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2101
2102 2019-03-15  Chris Dumez  <cdumez@apple.com>
2103
2104         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2105         https://bugs.webkit.org/show_bug.cgi?id=195747
2106
2107         Reviewed by Geoff Garen.
2108
2109         Add API test coverage.
2110
2111         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2112
2113 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2114
2115         Unreviewed, rolling out r242952.
2116
2117         Causing API failures on iOS Simulator
2118
2119         Reverted changeset:
2120
2121         "[PSON] Make sure the WebProcessCache is leverage when
2122         relaunching a process after termination"
2123         https://bugs.webkit.org/show_bug.cgi?id=195747
2124         https://trac.webkit.org/changeset/242952
2125
2126 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2127
2128         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2129         https://bugs.webkit.org/show_bug.cgi?id=195740
2130
2131         Reviewed by Ross Kirsling.
2132
2133         window.open doesn't work for WebKitBrowserWindow because it is not
2134         implemented yet.
2135
2136         1. Implemented createNewPage callback of WKPageUIClient.
2137         2. Changed MainWindow to take a BrowserWindow factory function
2138           instead of BrowserWindowType to be flexible to create
2139           BrowserWindow with extra settings.
2140         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2141           because it is not relevant with MainWindow anymore.
2142
2143         * MiniBrowser/win/Common.cpp:
2144         (parseCommandLine):
2145         * MiniBrowser/win/Common.h:
2146         (CommandLineOptions::CommandLineOptions):
2147         * MiniBrowser/win/MainWindow.cpp:
2148         (MainWindow::MainWindow):
2149         (MainWindow::create):
2150         (MainWindow::init):
2151         (MainWindow::WndProc):
2152         * MiniBrowser/win/MainWindow.h:
2153         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2154         (PrintWebUIDelegate::createWebViewWithRequest):
2155         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2156         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2157         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2158         (WebKitBrowserWindow::updateProxySettings):
2159         (WebKitBrowserWindow::createNewPage):
2160         * MiniBrowser/win/WebKitBrowserWindow.h:
2161         * MiniBrowser/win/WinMain.cpp:
2162         (wWinMain):
2163
2164 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2165
2166         Make it possible to test scrolling tree layer manipulation more easily
2167         https://bugs.webkit.org/show_bug.cgi?id=195780
2168
2169         Reviewed by Tim Horton.
2170         
2171         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2172         cuts off communication of scrolling tree scrolls back to the web process
2173         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2174         allows tests to trigger scrolls which run the scrolling tree layer positioning
2175         logic, but never get another commit from the web process that might mask
2176         scrolling tree bugs.
2177         
2178         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2179         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2180         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2181
2182         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2183         (WTR::UIScriptController::scrollUpdatesDisabled const):
2184         (WTR::UIScriptController::setScrollUpdatesDisabled):
2185         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2186         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2187         (WTR::UIScriptController::scrollUpdatesDisabled const):
2188         (WTR::UIScriptController::setScrollUpdatesDisabled):
2189         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2190         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2191         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2192         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2193         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2194         * WebKitTestRunner/ios/TestControllerIOS.mm:
2195         (WTR::TestController::platformResetStateToConsistentValues):
2196         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2197         (WTR::UIScriptController::scrollUpdatesDisabled const):
2198         (WTR::UIScriptController::setScrollUpdatesDisabled):
2199
2200 2019-03-14  Youenn Fablet  <youenn@apple.com>
2201
2202         Move IDB storage in private browsing mode to NetworkProcess
2203         https://bugs.webkit.org/show_bug.cgi?id=195602
2204
2205         Reviewed by Brady Eidson.
2206
2207         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2208         (TEST):
2209
2210 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2211
2212         [ews-build] Make descriptionDone messages more readable
2213         https://bugs.webkit.org/show_bug.cgi?id=195760
2214
2215         Reviewed by Lucas Forschler.
2216
2217         * BuildSlaveSupport/ews-build/steps.py:
2218         * BuildSlaveSupport/ews-build/steps_unittest.py:
2219
2220 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2221
2222         [ews-build] Generate status-bubble hover-over messages
2223         https://bugs.webkit.org/show_bug.cgi?id=195680
2224
2225         Reviewed by Lucas Forschler.
2226
2227         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2228         (StatusBubble):
2229         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2230         on hover-over.
2231         (StatusBubble._iso_time):
2232         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2233         hover-over message.
2234         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2235
2236 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2237
2238         [ews-app] Gracefully handle the case when state_string is None
2239         https://bugs.webkit.org/show_bug.cgi?id=195753
2240
2241         Reviewed by Lucas Forschler.
2242
2243         * BuildSlaveSupport/ews-app/ews/models/build.py:
2244         * BuildSlaveSupport/ews-app/ews/models/step.py:
2245
2246 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2247
2248         [ews-app] Status bubble display pending for currently running build step
2249         https://bugs.webkit.org/show_bug.cgi?id=195744
2250
2251         Reviewed by Lucas Forschler.
2252
2253         * BuildSlaveSupport/ews-build/events.py:
2254         (Events.stepStarted): If state_string is pending, replace it with step name.
2255
2256 2019-03-14  Chris Dumez  <cdumez@apple.com>
2257
2258         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2259         https://bugs.webkit.org/show_bug.cgi?id=195750
2260
2261         Reviewed by Geoffrey Garen.
2262
2263         Add API test coverage.
2264
2265         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2266         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2267         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2268         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2269
2270 2019-03-14  Chris Dumez  <cdumez@apple.com>
2271
2272         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2273         https://bugs.webkit.org/show_bug.cgi?id=195747
2274
2275         Reviewed by Geoff Garen.
2276
2277         Add API test coverage.
2278
2279         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2280
2281 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2282
2283         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2284         https://bugs.webkit.org/show_bug.cgi?id=195725
2285         <rdar://problem/48545062>
2286
2287         Reviewed by Tim Horton.
2288
2289         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2290         handler is nil.
2291
2292         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2293         (TestWebKitAPI::TEST):
2294
2295 2019-03-13  Sam Weinig  <sam@webkit.org>
2296
2297         Add utility function to allow easy reverse range-based iteration of a container
2298         https://bugs.webkit.org/show_bug.cgi?id=195542
2299
2300         Reviewed by Antti Koivisto.
2301
2302         * TestWebKitAPI/CMakeLists.txt:
2303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2304         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2305         (TestWebKitAPI::TEST):
2306         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2307
2308 2019-03-13  Chris Dumez  <cdumez@apple.com>
2309
2310         Use a ServiceWorker process per registrable domain
2311         https://bugs.webkit.org/show_bug.cgi?id=195649
2312
2313         Reviewed by Youenn Fablet.
2314
2315         Update API test coverage.
2316
2317         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2318
2319 2019-03-13  Chris Dumez  <cdumez@apple.com>
2320
2321         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2322         https://bugs.webkit.org/show_bug.cgi?id=195684
2323         <rdar://problem/48294714>
2324
2325         Reviewed by Antti Koivisto.
2326
2327         Add API test coverage.
2328
2329         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2330
2331 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2332
2333         [ews-app] Remove unused patch view
2334         https://bugs.webkit.org/show_bug.cgi?id=195669
2335
2336         Reviewed by Lucas Forschler.
2337
2338         * BuildSlaveSupport/ews-app/ews/urls.py:
2339         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2340
2341 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2342
2343         [ews-app] Use Buildbot result code variables
2344         https://bugs.webkit.org/show_bug.cgi?id=195668
2345
2346         Reviewed by Alexey Proskuryakov.
2347
2348         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2349         (Buildbot): Added Buildbot result code variables.
2350         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2351         (StatusBubble._build_bubble): Used Buildbot result code variables.
2352
2353 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2354
2355         [Flatpak] Expand submodule recursively
2356         https://bugs.webkit.org/show_bug.cgi?id=195672
2357
2358         Building WPE with flatpak was impossible without that as it was raising an exception.
2359         Also update wpebackend-fdo to match what is built in jhbuild
2360
2361         Reviewed by Philippe Normand.
2362
2363         * flatpak/flatpakutils.py:
2364         (expand_submodules_recurse):
2365         (expand_manifest):
2366         * flatpak/org.webkit.WPEModules.yaml:
2367
2368 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2369
2370         [ews-app] status bubble should be hidden for certain builds
2371         https://bugs.webkit.org/show_bug.cgi?id=194597
2372
2373         Reviewed by Dewei Zhu.
2374
2375         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2376         (StatusBubble._build_bubble):
2377         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2378         because the patch didn't have relevant changes.
2379         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2380         in production yet.
2381
2382 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2383
2384         [Win] Fix a slew of simple clang-cl warnings.
2385         https://bugs.webkit.org/show_bug.cgi?id=195652
2386
2387         Reviewed by Don Olmstead.
2388
2389         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2390         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2391
2392 2019-03-12  Justin Fan  <justin_fan@apple.com>
2393
2394         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2395         https://bugs.webkit.org/show_bug.cgi?id=195518
2396         <rdar://problem/46322356>
2397
2398         Reviewed by Myles C. Maxfield.
2399
2400         * DumpRenderTree/DerivedSources-input.xcfilelist:
2401         * DumpRenderTree/DerivedSources-output.xcfilelist:
2402
2403 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2404
2405         Unreviewed, rolling out r242825.
2406         https://bugs.webkit.org/show_bug.cgi?id=195648
2407
2408         "Broke webkitpy tests with my change to
2409         lldb_dump_class_layout.py" (Requested by rmorisset on
2410         #webkit).
2411
2412         Reverted changeset:
2413
2414         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2415         classes with suspicious padding"
2416         https://bugs.webkit.org/show_bug.cgi?id=195573
2417         https://trac.webkit.org/changeset/242825
2418
2419 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2420
2421         [ews-build] Show status bubbles while the patch is waiting in queue
2422         https://bugs.webkit.org/show_bug.cgi?id=195618
2423
2424         Reviewed by Lucas Forschler.
2425
2426         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2427         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2428         enabled in initial deployment.
2429         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2430         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2431         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2432         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2433         (StatusBubble._build_bubbles_for_patch):
2434
2435 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2436
2437         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2438         https://bugs.webkit.org/show_bug.cgi?id=195573
2439
2440         Reviewed by Simon Fraser.
2441
2442         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2443
2444         * Scripts/dump-class-layout:
2445         (main):
2446         * lldb/lldb_dump_class_layout.py:
2447         (ClassLayout.__init__):
2448         (ClassLayout._compute_padding_recursive):
2449         (LLDBDebuggerInstance.dump_layout_for_classname):
2450         (LLDBDebuggerInstance):
2451         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2452         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2453
2454 2019-03-12  Chris Dumez  <cdumez@apple.com>
2455
2456         Device Orientation access permission should be denied unless explicitly granted by the client
2457         https://bugs.webkit.org/show_bug.cgi?id=195625
2458
2459         Reviewed by Youenn Fablet.
2460
2461         add API test coverage.
2462
2463         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2464         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2465         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2466         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2467         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2468         (runDeviceOrientationTest):
2469         (TEST):
2470         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2471         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2472
2473 2019-03-12  Jer Noble  <jer.noble@apple.com>
2474
2475         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2476         https://bugs.webkit.org/show_bug.cgi?id=195137
2477         <rdar://problem/48810307>
2478
2479         Reviewed by Eric Carlson.
2480
2481         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2482         (TestWebKitAPI::TEST):
2483
2484 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2485
2486         [ews-build] Change urls from uat to production
2487         https://bugs.webkit.org/show_bug.cgi?id=195566
2488
2489         Reviewed by Lucas Forschler.
2490
2491         * BuildSlaveSupport/ews-app/ews/config.py:
2492         * BuildSlaveSupport/ews-build/events.py:
2493         * BuildSlaveSupport/ews-build/steps.py:
2494
2495 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2496
2497         [ews-build] change max_builds for local-worker to 1
2498         https://bugs.webkit.org/show_bug.cgi?id=195568
2499
2500         Reviewed by Lucas Forschler.
2501
2502         * BuildSlaveSupport/ews-build/loadConfig.py:
2503
2504 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2505
2506         Fix the build
2507
2508         * TestRunnerShared/spi/PencilKitTestSPI.h:
2509         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2510
2511 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2512
2513         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2514         https://bugs.webkit.org/show_bug.cgi?id=194131
2515
2516         Reviewed by Michael Catanzaro.
2517
2518         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2519         (uriChanged):
2520         (testUnfinishedSubresourceLoad):
2521         (serverCallback):
2522         (beforeAll):
2523
2524 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2525
2526         WTF::Expected should use std::addressof instead of operator&
2527         https://bugs.webkit.org/show_bug.cgi?id=195604
2528
2529         Reviewed by Myles Maxfield.
2530
2531         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2532         (TestWebKitAPI::Unique::Unique):
2533         (TestWebKitAPI::Unique::operator&):
2534         (TestWebKitAPI::TEST):
2535
2536 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2537
2538         Add Optional to Forward.h.
2539         https://bugs.webkit.org/show_bug.cgi?id=195586
2540
2541         Reviewed by Darin Adler.
2542
2543         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2544         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2545         Remove unnecessary includes from headers.
2546
2547 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2548
2549         Add testing API to hit-test and scroll overflow scrollers
2550         https://bugs.webkit.org/show_bug.cgi?id=195278
2551
2552         Reviewed by Antti Koivisto.
2553         
2554         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2555         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2556         
2557         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2558
2559         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2560         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2561         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2562         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2563         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2564         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2565         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2566         (WTR::enclosingScrollViewIncludingSelf):
2567         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2568
2569 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2570
2571         API test WebKit.RequestTextInputContext fails on iOS
2572         https://bugs.webkit.org/show_bug.cgi?id=195585
2573
2574         Reviewed by Wenson Hsieh and Simon Fraser.
2575
2576         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2577         (applyStyle):
2578         (TEST):
2579         Add a viewport, so that the coordinates match up on iOS.
2580         Scroll by moving the UIScrollView's contentOffset.
2581
2582 2019-03-11  Chris Dumez  <cdumez@apple.com>
2583
2584         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2585         https://bugs.webkit.org/show_bug.cgi?id=195506
2586         <rdar://problem/48733477>
2587
2588         Reviewed by Alex Christensen.
2589
2590         Add API test coverage.
2591
2592         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2593
2594 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2595
2596         Adding myself to contributors.json
2597
2598         Unreviewed, addming myself to contributors.json .
2599
2600         * Scripts/webkitpy/common/config/contributors.json:
2601
2602 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2603
2604         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2605         https://bugs.webkit.org/show_bug.cgi?id=195511
2606         <rdar://problem/44873269>
2607
2608         Reviewed by Darin Adler.
2609
2610         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2611         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2612         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2613         (TEST_F):
2614
2615 2019-03-11  Chris Dumez  <cdumez@apple.com>
2616
2617         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2618         https://bugs.webkit.org/show_bug.cgi?id=195561
2619
2620         Reviewed by Youenn Fablet.
2621
2622         Make sure the JS in the test requests for permission to receive device orientation events.
2623
2624         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2625
2626 2019-03-11  Youenn Fablet  <youenn@apple.com>
2627
2628         Allow storage quota increase by default in WTR
2629         https://bugs.webkit.org/show_bug.cgi?id=195541
2630
2631         Reviewed by Geoffrey Garen.
2632
2633         Allow storage quota increase by default in WTR.
2634         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2635         Use this for tests that explicitly need cache increase.
2636
2637         Instead of increasing quota by 2, make sure the next request is
2638         granted by adding all given parameters.
2639
2640         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2641         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2642         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2643         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2644         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2645         * WebKitTestRunner/TestController.cpp:
2646         (WTR::TestController::setAllowStorageQuotaIncrease):
2647         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2648         * WebKitTestRunner/TestController.h:
2649         * WebKitTestRunner/TestInvocation.cpp:
2650         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2651         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2652         (WTR::TestController::cocoaResetStateToConsistentValues):
2653         (WTR::TestController::setAllowStorageQuotaIncrease):
2654         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2655         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2656         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2657
2658 2019-03-11  Xan Lopez  <xan@igalia.com>
2659
2660         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2661         https://bugs.webkit.org/show_bug.cgi?id=194147
2662
2663         Reviewed by Michael Saboff.
2664
2665         To make --32-bit work correctly on Linux/64bit we need to:
2666
2667         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2668         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2669         unfortunately CMake only allows us to do this during
2670         crosscompilation, which is overkill here.
2671         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2672         pkg-config detection module uses the x86 .pc files instead of the
2673         x86_64 ones.
2674         - Set the -m32 flags for the compiler.
2675
2676         * Scripts/webkitdirs.pm:
2677         (generateBuildSystemFromCMakeProject):
2678
2679 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2680
2681         Add MotionMark-1.1 plan file for run-benchmark script.
2682         https://bugs.webkit.org/show_bug.cgi?id=195481
2683
2684         Rubber-stamped by Darin Adler.
2685
2686         Run-benchmark script should support MontionMark-1.1.
2687
2688         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2689
2690 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2691
2692         [ews-app] Add support for submit-to-ews url
2693         https://bugs.webkit.org/show_bug.cgi?id=195477
2694
2695         Reviewed by Lucas Forschler.
2696
2697         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2698         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2699         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2700         * BuildSlaveSupport/ews-app/ews/urls.py:
2701         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2702
2703 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2704
2705         Unreviewed, rolling out r242688, r242643, r242624.
2706
2707         Caused multiple layout test failures and crashes on iOS and macOS.
2708
2709         Reverted changeset:
2710
2711         "requestAnimationFrame should execute before the next frame"
2712         https://bugs.webkit.org/show_bug.cgi?id=177484
2713         https://trac.webkit.org/changeset/242624/webkit
2714
2715         * Tracing/SystemTracePoints.plist:
2716
2717 2019-03-11  John Wilander  <wilander@apple.com>
2718
2719         Resource Load Statistics: Make it possible exclude localhost from classification
2720         https://bugs.webkit.org/show_bug.cgi?id=195474
2721         <rdar://problem/47520577>
2722
2723         Reviewed by Brent Fulgham.
2724
2725         This patch allows for localhost to be excluded from classification and
2726         treatment as a prevalent resource.
2727
2728         The WebKit Tools change adds a new function called
2729         testRunner.setStatisticsIsRunningTest() which can be used to control this
2730         behavior.
2731
2732         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2733         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2734         (WTR::TestRunner::setStatisticsIsRunningTest):
2735         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2736         * WebKitTestRunner/TestController.cpp:
2737         (WTR::TestController::setStatisticsIsRunningTest):
2738         * WebKitTestRunner/TestController.h:
2739         * WebKitTestRunner/TestInvocation.cpp:
2740         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2741
2742 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2743
2744         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2745         https://bugs.webkit.org/show_bug.cgi?id=195560
2746
2747         Reviewed by Lucas Forschler.
2748
2749         * BuildSlaveSupport/ews-build/master.cfg:
2750
2751 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2752
2753         Unreviewed, rolling out r242698.
2754
2755         API test crashes on bots.
2756
2757         Reverted changeset:
2758
2759         "Add a WKContentRuleList variant that uses copied memory
2760         instead of mmap'd shared memory for class A containerized
2761         apps"
2762         https://bugs.webkit.org/show_bug.cgi?id=195511
2763         https://trac.webkit.org/changeset/242698
2764
2765 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2766
2767         [WPE] Enable web process sandbox
2768         https://bugs.webkit.org/show_bug.cgi?id=195169
2769
2770         Reviewed by Daniel Bates.
2771
2772         * wpe/install-dependencies:
2773         * wpe/jhbuild.modules:
2774
2775 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2776
2777         [ews-app] Use port 17000 for worker communication
2778         https://bugs.webkit.org/show_bug.cgi?id=195558
2779
2780         Reviewed by Lucas Forschler.
2781
2782         * BuildSlaveSupport/ews-build/master.cfg:
2783
2784 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2785
2786         [ews-build] unit-tests fail when passwords.json is missing
2787         https://bugs.webkit.org/show_bug.cgi?id=195557
2788
2789         Reviewed by Lucas Forschler.
2790
2791         * BuildSlaveSupport/ews-build/loadConfig.py:
2792         (loadBuilderConfig):
2793         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2794         (ConfigDotJSONTest.test_configuration):
2795         * BuildSlaveSupport/ews-build/master.cfg:
2796
2797 2019-03-11  Truitt Savell  <tsavell@apple.com>
2798
2799         Unreviewed, rolling out r242702.
2800
2801         Broke High Sierra builders.
2802
2803         Reverted changeset:
2804
2805         "Add utility function to allow easy reverse range-based
2806         iteration of a container"
2807         https://bugs.webkit.org/show_bug.cgi?id=195542
2808         https://trac.webkit.org/changeset/242702
2809
2810 2019-03-11  Sam Weinig  <sam@webkit.org>
2811
2812         Add utility function to allow easy reverse range-based iteration of a container
2813         https://bugs.webkit.org/show_bug.cgi?id=195542
2814
2815         Reviewed by Antti Koivisto.
2816
2817         * TestWebKitAPI/CMakeLists.txt:
2818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2819         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2820         (TestWebKitAPI::TEST):
2821         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2822
2823 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2824
2825         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2826         https://bugs.webkit.org/show_bug.cgi?id=195511
2827         <rdar://problem/44873269>
2828
2829         Reviewed by Darin Adler.
2830
2831         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2832         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2833         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2834         (TEST_F):
2835
2836 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2837
2838         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2839         https://bugs.webkit.org/show_bug.cgi?id=195499
2840
2841         Reviewed by Darin Adler.
2842
2843         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2844         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2845         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2846         (-[WKWebView synchronouslyFocusTextInputContext:]):
2847         (applyStyle):
2848         (applyIframe):
2849         (TEST):
2850         Add some tests for this SPI.
2851
2852 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2853
2854         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2855         https://bugs.webkit.org/show_bug.cgi?id=181151
2856
2857         Reviewed by Don Olmstead.
2858
2859         * TestWebKitAPI/CMakeLists.txt:
2860         * TestWebKitAPI/PlatformWin.cmake:
2861         Enable TestWTF RunLoop tests in all platforms.
2862
2863         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2864         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2865         (TestWebKitAPI::DerivedOneShotTimer::fired):
2866         (TestWebKitAPI::TEST):
2867         Only a few platforms support nested RunLoop.
2868
2869         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2870         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2871
2872 2019-03-10  David Quesada  <david_quesada@apple.com>
2873
2874         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2875         https://bugs.webkit.org/show_bug.cgi?id=152480
2876
2877         Reviewed by Chris Dumez.
2878
2879         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2880         there are no additional references to the process pool besides the one held by
2881         the download, waits for the download to finish (in the sense that the
2882         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2883         measure, also check that the process pool has been deallocated at the end of the
2884         test. The test wouldn't be meaningful if the process pool were still alive.
2885
2886         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2887         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2888         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2889             The download will be canceled because the delegate does not implement the
2890             method to decide the download's destination, so this is where we know the
2891             DownloadProxyMap is done with the DownloadProxy.
2892         (TEST):
2893
2894 2019-03-08  Chris Dumez  <cdumez@apple.com>
2895
2896         Add support for Device Orientation / Motion permission API
2897         https://bugs.webkit.org/show_bug.cgi?id=195329
2898         <rdar://problem/47645367>
2899
2900         Reviewed by Geoffrey Garen.
2901
2902         Add test infrastructure to help test the Device Orientation / Motion permission API.
2903
2904         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2905         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2906         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2907         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2908         * WebKitTestRunner/TestController.cpp:
2909         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2910         (WTR::TestController::createWebViewWithOptions):
2911         (WTR::TestController::resetStateToConsistentValues):
2912         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2913         * WebKitTestRunner/TestController.h:
2914         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2915         * WebKitTestRunner/TestInvocation.cpp:
2916         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2917
2918 2019-03-08  Saam barati  <sbarati@apple.com>
2919
2920         Add a compare-results script to compare benchmark results
2921         https://bugs.webkit.org/show_bug.cgi?id=195486
2922         <rdar://problem/48723397>
2923
2924         Reviewed by Geoffrey Garen.
2925
2926         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2927         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2928         to extend it to learn about our other benchmarks.
2929
2930         * Scripts/compare-results: Added.
2931         (readJSONFile):
2932         (detectJetStream2):
2933         (JetStream2Results):
2934         (detectSpeedometer2):
2935         (Speedometer2Results):
2936         (detectPLT5):
2937         (PLT5Results):
2938         (detectBenchmark):
2939         (biggerIsBetter):
2940         (ttest):
2941         (getOptions):
2942         (main):
2943
2944 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2945
2946         Ensure old tab state is cleared between iterations of run-benchmark
2947         https://bugs.webkit.org/show_bug.cgi?id=195393
2948         <rdar://problem/46885583>
2949
2950         Reviewed by Dewei Zhu.
2951
2952         a) ensure the default to restore state is not set
2953         b) terminate Safari correctly
2954         c) Set the system default to ignore Persistent State in Safari
2955
2956         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2957         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2958         (OSXBrowserDriver.prepare_env): 
2959         (OSXBrowserDriver.restore_env):
2960         (OSXBrowserDriver.close_browsers):
2961         (OSXBrowserDriver._terminate_processes):
2962         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2963         (OSXChromeDriver):
2964         (OSXChromeCanaryDriver):
2965         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2966         (OSXFirefoxDriver):
2967         (OSXFirefoxNightlyDriver):
2968         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2969         (OSXSafariDriver):
2970         (OSXSafariDriver.prepare_env):
2971
2972 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2973
2974         [GTK] Several InputMethodFilter tests are failing
2975         https://bugs.webkit.org/show_bug.cgi?id=195408
2976
2977         Reviewed by Carlos Garcia Campos.
2978
2979         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2980         Regressed in r241751.
2981         Hexadecimal values of keycodes are expressed now in upper letters.
2982         Composited characters should be cast to UTF8 strings.
2983
2984         (TestWebKitAPI::TEST):
2985
2986 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2987
2988         [GTK] Make Tools/gtkdoc python3 compatible
2989         https://bugs.webkit.org/show_bug.cgi?id=195359
2990
2991         Reviewed by Carlos Garcia Campos.
2992
2993         * gtkdoc/generate-gtkdoc:
2994         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2995         work with Python 2 and 3.
2996         (get_gtkdoc_module_paths):
2997         The iteritems() was removed in Python 3, so let's use items() that's
2998         available in Python 2 and 3.
2999         (get_generator_for_config):
3000         * gtkdoc/gtkdoc.py:
3001         (GTKDoc._run_command):
3002         The sys.stdout.write() is expecting str in Python 3 and not bytes
3003         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3004         for passing the bytes there.
3005
3006 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3007
3008         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3009         https://bugs.webkit.org/show_bug.cgi?id=195346
3010         <rdar://problem/48667048>
3011
3012         Unreviewed build fix for clang-cl.
3013
3014         * DumpRenderTree/win/DumpRenderTree.cpp:
3015         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3016
3017 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3018
3019         requestAnimationFrame should execute before the next frame
3020         https://bugs.webkit.org/show_bug.cgi?id=177484
3021
3022         Reviewed by Simon Fraser.
3023
3024         Add trace points for the page RenderingUpdate.
3025
3026         * Tracing/SystemTracePoints.plist:
3027
3028 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3029
3030         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3031         https://bugs.webkit.org/show_bug.cgi?id=195353
3032         <rdar://problem/48626394>
3033
3034         Reviewed by Simon Fraser.
3035
3036         * WebKitTestRunner/ios/TestControllerIOS.mm:
3037         (WTR::TestController::platformResetPreferencesToConsistentValues):
3038
3039 2019-03-07  John Wilander  <wilander@apple.com>
3040
3041         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3042         https://bugs.webkit.org/show_bug.cgi?id=195383
3043         <rdar://problem/48570136>
3044
3045         Reviewed by Brent Fulgham.
3046
3047         This patch adds test infrastructure to purge only script-accessible cookies,
3048         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3049
3050         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3051         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3052         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3053         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3054         * WebKitTestRunner/TestController.cpp:
3055         (WTR::TestController::statisticsDeleteCookiesForHost):
3056         * WebKitTestRunner/TestController.h:
3057         * WebKitTestRunner/TestInvocation.cpp:
3058         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3059
3060 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3061
3062         Unreviewed, rolling out r242354.
3063         https://bugs.webkit.org/show_bug.cgi?id=195402
3064
3065         breaks layout tests in all configurations (Requested by
3066         zdobersek on #webkit).
3067
3068         Reverted changeset:
3069
3070         "[WPE] Enable web process sandbox"
3071         https://bugs.webkit.org/show_bug.cgi?id=195169
3072         https://trac.webkit.org/changeset/242354
3073
3074 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3075
3076         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3077         https://bugs.webkit.org/show_bug.cgi?id=195346
3078
3079         Reviewed by Fujii Hironori.
3080
3081         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3082         (TestWebKitAPI::TEST):
3083         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3084
3085         * DumpRenderTree/win/DumpRenderTree.cpp:
3086         (findFontFallback):
3087         (addFontFallbackIfPresent):
3088         (removeFontFallbackIfPresent):
3089         (main):
3090         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3091         (TestWebKitAPI::Util::moduleDirectory):
3092         (TestWebKitAPI::Util::createInjectedBundlePath):
3093         Use wchar helpers as needed.
3094
3095 2019-03-06  Rob Buis  <rbuis@igalia.com>
3096
3097         Consider supporting the `referrerpolicy` attribute.
3098         https://bugs.webkit.org/show_bug.cgi?id=179053
3099
3100         Reviewed by Darin Adler.
3101
3102         Add a runtime flag for referrerpolicy attribute.
3103
3104         * DumpRenderTree/mac/DumpRenderTree.mm:
3105         (enableExperimentalFeatures):
3106
3107 2019-03-05  Daniel Bates  <dabates@apple.com>
3108
3109         Update expected API test result following r242379
3110         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3111
3112         Update expected x-coordinate of selection rect now that the left padding of
3113         a textarea is sized in ems (so dependent on the font size) just like the left
3114         padding of a text field.
3115
3116         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3117         (TestWebKitAPI::TEST):
3118
3119 2019-03-05  David Quesada  <david_quesada@apple.com>
3120
3121         [WK2] It should be possible to follow links with 'download' attributes
3122         https://bugs.webkit.org/show_bug.cgi?id=195145
3123         rdar://problem/48462642
3124
3125         Reviewed by Alex Christensen.
3126
3127         Add a unit test to verify that activating links with 'download' attributes now
3128         navigates to the linked resource, rather than starts downloading it. Add another
3129         to verify that it is still possible to explicitly download the link via the
3130         'Download' navigation action policy.
3131
3132         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3133         (-[DownloadAttributeTestDelegate init]):
3134         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3135         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3136         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3137         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3138         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3139         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3140         (TEST):
3141         * WebKitTestRunner/TestController.cpp:
3142         (WTR::TestController::decidePolicyForNavigationAction):
3143         * WebKitTestRunner/TestController.h:
3144
3145 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3146
3147         [Curl] Implement Cookie Accept Policy.
3148         https://bugs.webkit.org/show_bug.cgi?id=191645
3149
3150         Reviewed by Fujii Hironori.
3151
3152         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3153         (TestWebKitAPI::Curl::TEST_F):
3154
3155 2019-03-05  Youenn Fablet  <youenn@apple.com>
3156
3157         Rename requestCacheStorageSpace to requestStorageSpace
3158         https://bugs.webkit.org/show_bug.cgi?id=195282
3159
3160         Reviewed by Chris Dumez.
3161
3162         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3163         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3164         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3165
3166 2019-03-05  Brady Eidson  <beidson@apple.com>
3167
3168         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3169         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3170
3171         Reviewed by Tim Horton.
3172
3173         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3174         different directory into that same WKWebView should work.
3175
3176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3177         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3178
3179 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3180
3181         Add WeakHashSet
3182         https://bugs.webkit.org/show_bug.cgi?id=195152
3183
3184         Reviewed by Antti Koivisto.
3185
3186         Added tests for WeakHashSet.
3187
3188         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3189         (TestWebKitAPI::Base::Base): Moved.
3190         (TestWebKitAPI::Derived::foo): Moved.
3191         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3192         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3193         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3194         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3195
3196 2019-03-04  Chris Dumez  <cdumez@apple.com>
3197
3198         Do not share WebProcesses between private and regular sessions
3199         https://bugs.webkit.org/show_bug.cgi?id=195189
3200         <rdar://problem/48421064>
3201
3202         Reviewed by Alex Christensen.
3203
3204         Add API test coverage.
3205
3206         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3207         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3208
3209 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3210
3211         [WPE] Enable web process sandbox
3212         https://bugs.webkit.org/show_bug.cgi?id=195169
3213
3214         Reviewed by Daniel Bates.
3215
3216         * wpe/install-dependencies:
3217         * wpe/jhbuild.modules:
3218
3219 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3220
3221         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3222         https://bugs.webkit.org/show_bug.cgi?id=195206
3223
3224         Reviewed by Žan Doberšek.
3225
3226         Add a new test case.
3227
3228         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3229         (testJSCClass):
3230
3231 2019-03-04  Charlie Turner  <cturner@igalia.com>
3232
3233         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3234         https://bugs.webkit.org/show_bug.cgi?id=194898
3235
3236         Reviewed by Žan Doberšek.
3237
3238         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3239         a GCC extension that permits arithmetic on void* pointer. Inline
3240         the macro until this issue is fixed upstream.
3241
3242 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3243
3244         Rid the world of WK_API_ENABLED
3245         https://bugs.webkit.org/show_bug.cgi?id=195263
3246
3247         Reviewed by Dan Bernstein.
3248
3249         List of changed files elided because it's useless.
3250
3251 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3252
3253         Unreviewed follow-up to r242292.
3254
3255         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3256
3257         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3258         (TestWebKitAPI::testStrip): Renamed from strip.
3259         (TestWebKitAPI::TEST):
3260
3261 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3262
3263         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3264
3265         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3266         and bug #194272 for details.
3267
3268         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3269
3270 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3271
3272         Remove some more unused 32-bit code
3273         https://bugs.webkit.org/show_bug.cgi?id=195255
3274
3275         Reviewed by Darin Adler.
3276
3277         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3278         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3279         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3280         (NPP_New):
3281         (NPP_HandleEvent):
3282         (handleEventCarbon): Deleted.
3283
3284 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3285
3286         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3287
3288         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3289         (TestWebKitAPI::TEST):
3290
3291 2019-03-01  Darin Adler  <darin@apple.com>
3292
3293         Finish removing String::format
3294         https://bugs.webkit.org/show_bug.cgi?id=194893
3295
3296         Reviewed by Daniel Bates.
3297 '
3298         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3299
3300 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3301
3302         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3303         https://bugs.webkit.org/show_bug.cgi?id=195229
3304         <rdar://problem/48520362>
3305
3306         Reviewed by Chris Dumez.
3307
3308         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3309         (TEST):
3310
3311 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3312
3313         Add a system trace scope for event region building
3314         https://bugs.webkit.org/show_bug.cgi?id=195226
3315
3316         Reviewed by Jon Lee.
3317
3318         This trace scope measures the time spend converting element rects into Region objects,
3319         which can be large on some pages.
3320
3321         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3322
3323         * Tracing/SystemTracePoints.plist:
3324
3325 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3326
3327         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3328         https://bugs.webkit.org/show_bug.cgi?id=194612
3329
3330         Reviewed by Alex Christensen.
3331
3332         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3333         Just test the new string-processing function and don't touch the actual environment.
3334         (Test cases are all as before, but based on operator== instead of strcmp.)
3335
3336 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3337
3338         [ews-app] Update primary keys for handling multiple Buildbot instances
3339         https://bugs.webkit.org/show_bug.cgi?id=195120
3340
3341         Reviewed by Stephanie Lewis.
3342
3343         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3344         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3345         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3346
3347         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3348         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3349         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3350         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3351         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3352         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3353
3354 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3355
3356         [WinCairo] Enable service worker
3357         https://bugs.webkit.org/show_bug.cgi?id=188318
3358
3359         Reviewed by Youenn Fablet.
3360
3361         * DumpRenderTree/DumpRenderTreePrefix.h:
3362         * TestWebKitAPI/PlatformWin.cmake:
3363         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3364         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3365         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3366
3367 2019-03-01  Justin Fan  <justin_fan@apple.com>
3368
3369         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3370         https://bugs.webkit.org/show_bug.cgi?id=195191
3371
3372         Rubber-stamped by Dean Jackson.
3373
3374         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3375
3376         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3377
3378 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3379
3380         Unreviewed, fix lldb webkitpy tests
3381         https://bugs.webkit.org/show_bug.cgi?id=194375
3382
3383         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3384
3385         * lldb/lldb_webkit.py:
3386         (WTFStringImplProvider.is_8bit):
3387
3388 2019-02-28  David Quesada  <david_quesada@apple.com>
3389
3390         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3391         https://bugs.webkit.org/show_bug.cgi?id=195121
3392         rdar://problem/48450302
3393
3394         Reviewed by Alex Christensen.
3395
3396         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3397         configurations where the 'download' attribute is absent, blank, or populated
3398         with a filename, and where the anchor element is same-origin or cross-origin
3399         (meaning the 'download' attribute shouldn't be honored).
3400
3401         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3402         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3403         (-[NavigationActionTestDelegate init]):
3404         (-[NavigationActionTestDelegate navigationAction]):
3405         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3406         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3407         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3408         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3409         (TEST):
3410
3411 2019-02-28  Antoine Quint  <graouts@apple.com>
3412
3413         Enable the Pointer Events runtime flag by default
3414         https://bugs.webkit.org/show_bug.cgi?id=195156
3415
3416         Reviewed by Dean Jackson.
3417
3418         * DumpRenderTree/mac/DumpRenderTree.mm:
3419         (enableExperimentalFeatures):
3420
3421 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3422
3423         Several PasteImage API tests are flaky
3424         https://bugs.webkit.org/show_bug.cgi?id=195160
3425
3426         Reviewed by Tim Horton.
3427
3428         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3429         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3430         listening for a "load" event after image load is already complete.
3431
3432         To address this, make these tests first register a "load" event handler, then run script to insert an image
3433         element into the document, and finally wait until the load event is observed before checking image size.
3434
3435         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3436
3437 2019-02-28  Chris Dumez  <cdumez@apple.com>
3438
3439         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3440         https://bugs.webkit.org/show_bug.cgi?id=195107
3441
3442         Reviewed by Alex Christensen.
3443
3444         Give some time for the zoom level to get restored.
3445
3446         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3447
3448 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3449
3450         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3451         https://bugs.webkit.org/show_bug.cgi?id=194958
3452
3453         Reviewed by Geoffrey Garen.
3454
3455         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3456         (TEST):
3457
3458 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3459
3460         [ews-app] Update method to save build to handle builder_display_name
3461         https://bugs.webkit.org/show_bug.cgi?id=195047
3462
3463         Reviewed by Dewei Zhu.
3464
3465         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3466         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3467
3468 2019-02-28  Justin Fan  <justin_fan@apple.com>
3469
3470         [Web GPU] Enable Web GPU only on 64-bit
3471         https://bugs.webkit.org/show_bug.cgi?id=195139
3472
3473         Because Metal is only supported on 64 bit apps.
3474
3475         Unreviewed build fix.
3476
3477         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3478
3479 2019-02-27  Youenn Fablet  <youenn@apple.com>
3480
3481         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3482         https://bugs.webkit.org/show_bug.cgi?id=194959
3483
3484         Reviewed by Chris Dumez.
3485
3486         Spin loop until getting the condition to remove flakiness.
3487
3488         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3489
3490 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3491
3492         [ews-build] Buildbot should include builder_display_name in the build events
3493         https://bugs.webkit.org/show_bug.cgi?id=195045
3494
3495         Reviewed by Dewei Zhu.
3496
3497         * BuildSlaveSupport/ews-build/events.py:
3498         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3499         buildername to builder_name to be consistent in naming style.
3500         (Events.buildFinished): Ditto.
3501
3502 2019-02-27  Chris Dumez  <cdumez@apple.com>
3503
3504         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3505         https://bugs.webkit.org/show_bug.cgi?id=194480
3506
3507         Reviewed by Brady Eidson.
3508
3509         Update existing API test to make it more likely to reproduce the issue.
3510
3511         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3512
3513 2019-02-27  Brady Eidson  <beidson@apple.com>
3514
3515         Universal links from Google search results pages don't open the app.
3516         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3517
3518         Reviewed by Geoffrey Garen.
3519
3520         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3521         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3522         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3523         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3524
3525 2019-02-27  Chris Dumez  <cdumez@apple.com>
3526
3527         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3528         https://bugs.webkit.org/show_bug.cgi?id=195102
3529
3530         Reviewed by Geoffrey Garen.
3531
3532         If the number of processes is not yet what we expect, wait a bit and check again to give
3533         processes some time to exit.
3534
3535         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3536
3537 2019-02-27  Chris Dumez  <cdumez@apple.com>
3538
3539         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3540         https://bugs.webkit.org/show_bug.cgi?id=194545
3541
3542         Reviewed by Brady Eidson.
3543
3544         Make sure the test navigates forward and then back only once. Previously, navigating
3545         back would trigger a navigation again in a timer.
3546
3547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3548
3549 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3550
3551         High Sierra Debug JSC test queue should use faster hardware
3552         https://bugs.webkit.org/show_bug.cgi?id=194603
3553
3554         Rubber-stamped by Alexey Proskuryakov.
3555
3556         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3557
3558         * BuildSlaveSupport/build.webkit.org-config/config.json:
3559         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3560         (BubbleQueueServer):
3561         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3562         (WebKitBuildbot):
3563         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3564         * QueueStatusServer/config/queues.py:
3565         * Scripts/webkitpy/common/config/ews.json:
3566         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3567         (test_ews_name):
3568
3569 2019-02-27  John Wilander  <wilander@apple.com>
3570
3571         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3572         https://bugs.webkit.org/show_bug.cgi?id=195071
3573         <rdar://problem/48417690>
3574
3575         Reviewed by Alex Christensen and Brent Fulgham.
3576
3577         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3578         (TestWebKitAPI::createURL):
3579             Convenience function.
3580         (TestWebKitAPI::TEST):
3581             WebCore::AdClickAttribution now takes a URL when creating Source and
3582             Destination.
3583         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3584         (TestWebKitAPI::TEST):
3585             WebCore::AdClickAttribution now takes a URL when creating Source and
3586             Destination.
3587
3588 2019-02-27  Antoine Quint  <graouts@apple.com>
3589
3590         Support Pointer Events on macOS
3591         https://bugs.webkit.org/show_bug.cgi?id=195008
3592         <rdar://problem/47454419>
3593
3594         Reviewed by Dean Jackson.
3595
3596         * DumpRenderTree/mac/DumpRenderTree.mm:
3597         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3598         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3599
3600 2019-02-26  Mark Lam  <mark.lam@apple.com>
3601
3602         Remove remaining poisoning code.
3603         https://bugs.webkit.org/show_bug.cgi?id=194138
3604
3605         Reviewed by Saam Barati.
3606
3607         * TestWebKitAPI/CMakeLists.txt:
3608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3609         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3610         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3611         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3612         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3613         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3614         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3615
3616 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3617
3618         Move ephemeral local storage from WebProcess to UIProcess
3619         https://bugs.webkit.org/show_bug.cgi?id=195074
3620         <rdar://problem/47937975>
3621
3622         Reviewed by Geoff Garen.
3623
3624         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3625
3626 2019-02-20  Jer Noble  <jer.noble@apple.com>
3627
3628         [Cocoa] Media elements will restart network buffering just before suspending
3629         https://bugs.webkit.org/show_bug.cgi?id=193691
3630
3631         Reviewed by Eric Carlson.
3632
3633         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3634         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3635         (TEST):
3636
3637 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3638
3639         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3640         https://bugs.webkit.org/show_bug.cgi?id=191652
3641
3642         Reviewed by Alex Christensen.
3643
3644         Fix WinCairo MiniBrowser behavior of authentication dialog.
3645
3646         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3647         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3648
3649 2019-02-26  Youenn Fablet  <youenn@apple.com>
3650
3651         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3652         https://bugs.webkit.org/show_bug.cgi?id=195028
3653         <rdar://problem/48243733>
3654
3655         Reviewed by Eric Carlson.
3656
3657         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3658
3659 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3660
3661         [WPE] Add API for webview background color configuration
3662         https://bugs.webkit.org/show_bug.cgi?id=192305
3663
3664         Reviewed by Michael Catanzaro.
3665
3666         * MiniBrowser/wpe/main.cpp:
3667         (main): Add a new option to configure the webview background
3668         color. Example: --bg-color=transparent.
3669         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3670         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3671         (beforeAll): Ditto.
3672
3673 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3674
3675         scalableNativeWebpageParameters() is not preserved on new page navigation.
3676         https://bugs.webkit.org/show_bug.cgi?id=194892
3677         <rdar://problem/47538280>
3678
3679         Reviewed by Wenson Hsieh.
3680         
3681         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3682
3683         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3684         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3685         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3686         (WTR::UIScriptController::allowsViewportShrinkToFit):
3687         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3688         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3689         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3690         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3691         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3692         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3693
3694 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3695
3696         [ews-app] Add model for handling multiple Buildbot instances
3697         https://bugs.webkit.org/show_bug.cgi?id=194863
3698
3699         Reviewed by Stephanie Lewis.
3700
3701         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3702
3703 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3704
3705         [ews-app] Remove BuilderMapping table
3706         https://bugs.webkit.org/show_bug.cgi?id=194961
3707
3708         Reviewed by Stephanie Lewis.
3709
3710         Store builder name directly in build table, instead of having a separate
3711         table for it.
3712
3713         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3714         * BuildSlaveSupport/ews-app/ews/models/build.py:
3715         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3716         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3717
3718 2019-02-25  John Wilander  <wilander@apple.com>
3719
3720         Introduce and adopt new class RegistrableDomain for eTLD+1
3721         https://bugs.webkit.org/show_bug.cgi?id=194791
3722         <rdar://problem/48179240>
3723
3724         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3725
3726         This patch adds an API test and replaces two instances of
3727         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3728
3729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3730         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3731         (TestWebKitAPI::TEST):
3732             Changed two strings to make sure the registrable domains are still considered
3733             invalid and pass the test.
3734         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3735         (TestWebKitAPI::TEST):
3736         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3737         (WTR::InjectedBundle::didReceiveMessageToPage):
3738
3739 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3740
3741         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3742         https://bugs.webkit.org/show_bug.cgi?id=195001
3743
3744         Reviewed by Carlos Garcia Campos.
3745
3746         API version 1.0 always includes the functionality previously guarded with
3747         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3748         unconditionally.
3749
3750         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3751         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3752         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3753         (WebViewTest::showInWindow): Ditto.
3754         (WebViewTest::hideView): Ditto.
3755         * wpe/backends/HeadlessViewBackend.cpp:
3756         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3757         * wpe/backends/ViewBackend.cpp:
3758         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3759         * wpe/backends/WindowViewBackend.cpp:
3760         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3761         WPE_BACKEND_CHECK_VERSION().
3762         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3763
3764 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3765
3766         [Flatpak] Add support for flatpak > 1.1.2
3767         https://bugs.webkit.org/show_bug.cgi?id=194088
3768
3769         Flatpak 1.2 is now out so we need to support that
3770         version now.
3771
3772         Reviewed by Michael Catanzaro.
3773
3774         * flatpak/flatpakutils.py:
3775         (check_flatpak):
3776         (FlatpakPackages.__init__):
3777         (FlatpakPackages.__detect_packages):
3778         (FlatpakPackages.__detect_packages.in):
3779         (FlatpakRepos.update):
3780
3781 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3782
3783         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3784         https://bugs.webkit.org/show_bug.cgi?id=194998
3785
3786         Reviewed by Carlos Garcia Campos.
3787
3788         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3789         to a Git checkout and using the latest commit containing various fixes
3790         and improvements.
3791
3792 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3793
3794         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3795         https://bugs.webkit.org/show_bug.cgi?id=194981
3796
3797         Reviewed by Žan Doberšek.
3798
3799         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3800         (TestWebKitAPI::TEST):
3801
3802 2019-02-23  Keith Miller  <keith_miller@apple.com>
3803
3804         Add new mac target numbers
3805         https://bugs.webkit.org/show_bug.cgi?id=194955
3806
3807         Reviewed by Tim Horton.
3808
3809         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3810         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3811         * MiniBrowser/Configurations/Base.xcconfig:
3812         * TestWebKitAPI/Configurations/Base.xcconfig:
3813         * WebKitTestRunner/Configurations/Base.xcconfig:
3814
3815 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3816
3817         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3818         https://bugs.webkit.org/show_bug.cgi?id=194846
3819
3820         Reviewed by Don Olmstead.
3821
3822         Added _search_paths() and _port_specific_expectations_files() for
3823         WinCairoPort.
3824
3825         * Scripts/webkitpy/port/win.py:
3826         (WinCairoPort.default_baseline_search_path):
3827         (WinCairoPort):
3828         (WinCairoPort._port_specific_expectations_files):
3829         (WinCairoPort._search_paths):
3830
3831 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3832
3833         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3834         https://bugs.webkit.org/show_bug.cgi?id=194963
3835
3836         Reviewed by Dean Jackson.
3837
3838         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3839         Do a `contains` check instead of `equals`, because in debug builds we
3840         put the GraphicsLayer pointer in a prefix.
3841
3842 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3843
3844         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3845         https://bugs.webkit.org/show_bug.cgi?id=194873
3846         <rdar://problem/46701974>
3847
3848         Reviewed by Tim Horton.
3849
3850         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3851
3852         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3853         (WTR::UIScriptController::menuRect const):
3854         (WTR::UIScriptController::isShowingMenu const):
3855         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3856         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3857         (WTR::UIScriptController::menuRect const):
3858
3859         Add a function to query the bounds of the callout menu in content coordinates.
3860
3861         (WTR::UIScriptController::isShowingMenu const):
3862
3863         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3864
3865         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3866         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3867         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3868         (WTR::UIScriptController::rectForMenuAction const):
3869         (WTR::UIScriptController::menuRect const):
3870         (WTR::UIScriptController::isShowingMenu const):
3871         (WTR::findViewInHierarchyOfType): Deleted.
3872
3873 2019-02-22  Chris Dumez  <cdumez@apple.com>
3874
3875         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3876         https://bugs.webkit.org/show_bug.cgi?id=194954
3877         <rdar://problem/48127957>
3878
3879         Reviewed by Alex Christensen.
3880
3881         Add API test coverage.
3882
3883         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3884         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3885         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3886         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3887
3888 2019-02-22  Chris Dumez  <cdumez@apple.com>
3889
3890         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3891         https://bugs.webkit.org/show_bug.cgi?id=194924
3892         <rdar://problem/48216125>
3893
3894         Reviewed by Geoffrey Garen.
3895
3896         Add API test coverage.
3897
3898         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3899
3900 2019-02-22  Chris Dumez  <cdumez@apple.com>
3901
3902         Unreviewed, disable API test added in r241928 on iOS.
3903
3904         The cache is not enabled on devices with less than 3GB of RAM.
3905
3906         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3907
3908 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3909
3910         Hardcode Visual Viewports on everywhere except iOS WK1
3911         https://bugs.webkit.org/show_bug.cgi?id=194928
3912
3913         Reviewed by Zalan Bujtas.
3914
3915         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3916         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3917         set it to false. The setting has shipped for several years and there's no need to turn
3918         it off now.
3919
3920         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3921         Visual Viewports are not enabled.
3922         
3923         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3924         that only runs in WK2
3925
3926         * MiniBrowser/mac/SettingsController.h:
3927         * MiniBrowser/mac/SettingsController.m:
3928         (-[SettingsController init]):
3929         (-[SettingsController _populateMenu]):
3930         (-[SettingsController validateMenuItem:]):
3931         (-[SettingsController visualViewportEnabled]): Deleted.
3932         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3933         * MiniBrowser/mac/WK1BrowserWindowController.m:
3934         (-[WK1BrowserWindowController didChangeSettings]):
3935         * MiniBrowser/mac/WK2BrowserWindowController.m:
3936         (-[WK2BrowserWindowController didChangeSettings]):
3937
3938 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3939
3940         Discard cached processes when clearing website data store
3941         https://bugs.webkit.org/show_bug.cgi?id=194894
3942
3943         Reviewed by Chris Dumez.
3944
3945         Added a test case.
3946
3947         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3948         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3949
3950 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3951
3952         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3953         https://bugs.webkit.org/show_bug.cgi?id=194914
3954         <rdar://problem/47586889>
3955
3956         Reviewed by Geoffrey Garen.
3957
3958         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3959         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3960         (TEST):
3961         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3962
3963 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3964
3965         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3966         <https://webkit.org/b/194761>
3967
3968         Reviewed by Myles Maxfield.
3969
3970         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3971         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3972         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3973         to use ARC-compliant cast.
3974         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3975         ARC-compliant cast.
3976         (WTR::installFakeHelvetica): Log `error` to console if
3977         CTFontManagerRegisterFontsForURL() fails, but only on supported
3978         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3979         Call CFRelease() on `error` to fix the leak.  Update to use
3980         ARC-compliant cast.
3981         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3982         cast.
3983
3984 2019-02-21  Chris Dumez  <cdumez@apple.com>
3985
3986         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3987         https://bugs.webkit.org/show_bug.cgi?id=194481
3988
3989         Reviewed by Alex Christensen.
3990
3991         Give the processes a chance to shutdown and wait until we reached the expected number
3992         of processes.
3993
3994         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3995
3996 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3997
3998         Fix the macOS build
3999
4000         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4001
4002 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4003
4004         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4005
4006         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4007         I am a backwards.
4008
4009 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4010
4011         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4012
4013         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4014         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4015         We could force on UI-side compositing, but I feel like the test might be more
4016         valuable exercising the normal path on each platform (though the original
4017         bug was also UI-side specific). Though we can't validate that the overlay
4018         layer was installed successfully, there are layout tests that do that.
4019
4020 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4021
4022         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4023         https://bugs.webkit.org/show_bug.cgi?id=194845
4024         <rdar://problem/47944579>
4025
4026         Reviewed by Antti Koivisto.
4027
4028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4029         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4030
4031 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4032
4033         [LFC][Floats] Add support for placing formatting roots in-between floats.
4034         https://bugs.webkit.org/show_bug.cgi?id=194902
4035
4036         Reviewed by Antti Koivisto.
4037
4038         * LayoutReloaded/misc/LFC-passing-tests.txt:
4039
4040 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4041
4042         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4043         https://bugs.webkit.org/show_bug.cgi?id=194901
4044
4045         Unreviewed build fix.
4046
4047         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4048         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4049         WPEBackend-fdo-0.1 as library name.
4050
4051 2019-02-21  Rob Buis  <rbuis@igalia.com>
4052
4053         Update MIME type parser
4054         https://bugs.webkit.org/show_bug.cgi?id=180526
4055
4056         Reviewed by Darin Adler.
4057
4058         Add tests involving leading and trailing whitespace, non-token
4059         characters and quoted strings.
4060
4061         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4062         (TestWebKitAPI::TEST):
4063
4064 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4065
4066         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4067         https://bugs.webkit.org/show_bug.cgi?id=194884
4068
4069         Reviewed by Michael Catanzaro.
4070
4071         * PlatformWin.cmake:
4072
4073 2019-02-20  Chris Dumez  <cdumez@apple.com>
4074
4075         Add API test for <rdar://problem/47471222>
4076         https://bugs.webkit.org/show_bug.cgi?id=194847
4077
4078         Reviewed by Alex Christensen.
4079
4080         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4081
4082 2019-02-20  Chris Dumez  <cdumez@apple.com>
4083
4084         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4085         https://bugs.webkit.org/show_bug.cgi?id=194872
4086         <rdar://problem/47924500>
4087
4088         Reviewed by Alex Christensen.
4089
4090         Add API test coverage.
4091
4092         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4093
4094 2019-02-20  Jer Noble  <jer.noble@apple.com>
4095
4096         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4097         https://bugs.webkit.org/show_bug.cgi?id=191332
4098
4099         Reviewed by Dean Jackson.
4100
4101         * Scripts/git-is-in-range: Added.
4102
4103 2019-02-20  Andy Estes  <aestes@apple.com>
4104
4105         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4106         https://bugs.webkit.org/show_bug.cgi?id=194869
4107
4108         Rubber-stamped by Jer Noble.
4109
4110         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4111         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4112         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4113         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4114         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4115         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4116
4117 2019-02-20  Chris Dumez  <cdumez@apple.com>
4118
4119         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4120         https://bugs.webkit.org/show_bug.cgi?id=194857
4121         <rdar://problem/47759323>
4122
4123         Reviewed by Alex Christensen.
4124
4125         Add API test coverage.
4126
4127         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4128
4129 2019-02-20  Chris Dumez  <cdumez@apple.com>
4130
4131         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4132         https://bugs.webkit.org/show_bug.cgi?id=194829
4133         <rdar://problem/47889906>
4134
4135         Reviewed by Alexey Proskuryakov.
4136
4137         Every time the TestOptions were changing we were creating both a new Web view and
4138         a new WKContext, which would start a new Network process. In most cases, we only
4139         need to contruct a new Web view and we do can keep reusing the same WKContext.
4140         This patch implements this optimization and thus avoids spinning a lot of new
4141         Network processes while running the layout tests.
4142
4143         * WebKitTestRunner/TestController.cpp:
4144         (WTR::TestController::generateContextConfiguration const):
4145         (WTR::TestController::generatePageConfiguration):
4146         (WTR::TestController::createWebViewWithOptions):
4147         (WTR::TestController::resetPreferencesToConsistentValues):
4148         (WTR::updateTestOptionsFromTestHeader):
4149         * WebKitTestRunner/TestController.h:
4150         * WebKitTestRunner/TestOptions.h:
4151         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4152         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4153         (WTR::TestOptions::hasSameInitializationOptions const):
4154         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4155         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4156         (WTR::TestController::platformAddTestOptions const):
4157
4158 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4159
4160         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4161         https://bugs.webkit.org/show_bug.cgi?id=167941
4162
4163         Reviewed by Carlos Garcia Campos.
4164
4165         * MiniBrowser/gtk/main.c:
4166         (filterSavedCallback): Added.
4167         (main): Support loading a JSON rule set file for content filtering.
4168         * MiniBrowser/wpe/main.cpp:
4169         (filterSavedCallback): Added.
4170         (main): Support loading a JSON rule set file for content filtering.
4171         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4172         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4173         (WTF::derefGPtr): Ditto.
4174         (testEmptyStore):
4175         (testSaveInvalidFilter):
4176         (testSaveLoadFilter):
4177         (testSavedFilterIdentifierMatch):
4178         (testRemoveFilter):
4179         (testSaveMultipleFilters):
4180         (testSaveFilterFromFile):
4181         (testFilterPersistence):
4182         (beforeAll):
4183         (afterAll):
4184         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4185         (removeOldInjectedContentAndResetLists): Also reset content filters.
4186         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4187         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4188         the element affected by the style sheet.
4189         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4190         and returns it to be used by tests.
4191         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4192         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4193         (serverCallback): Add support for serving a CSS style sheet for testing.
4194         (beforeAll): Add call to testUserContentManagerContentFilter().
4195         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4196
4197 2019-02-19  Keith Rollin  <krollin@apple.com>
4198
4199         Add timing information to build output
4200         https://bugs.webkit.org/show_bug.cgi?id=194839
4201         <rdar://problem/48219609>
4202
4203         Reviewed by Alexey Proskuryakov.
4204
4205         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4206         emit each project's build time to its output. E.g.,
4207
4208             ** BUILD SUCCEEDED ** [0.132 sec]
4209
4210         * Scripts/webkitdirs.pm:
4211         (XcodeOptions):
4212
4213 2019-02-19  Truitt Savell  <tsavell@apple.com>
4214
4215         Unreviewed, rolling out r241784.
4216
4217         Broke all OpenSource builds.
4218
4219         Reverted changeset:
4220
4221         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4222         instances view"
4223         https://bugs.webkit.org/show_bug.cgi?id=172848
4224         https://trac.webkit.org/changeset/241784
4225
4226 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4227
4228         [LFC][Floats] Remove redundant intersecting logic
4229         https://bugs.webkit.org/show_bug.cgi?id=194804
4230
4231         Reviewed by Antti Koivisto.
4232
4233         * LayoutReloaded/misc/LFC-passing-tests.txt:
4234
4235 2019-02-19  Dean Jackson  <dino@apple.com>
4236
4237         Clean-up output from generate-xcfilelists so it can be filtered
4238         https://bugs.webkit.org/show_bug.cgi?id=194795
4239
4240         Reviewed by Joseph Pecoraro (and Keith Rollin).
4241
4242         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4243         make a slight tweak to filter-build-webkit so such lines are marked
4244         as plain.
4245
4246         * Scripts/filter-build-webkit:
4247         * Scripts/generate-xcfilelists:
4248
4249 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4250
4251         pytest is not correctly auto-installed
4252         https://bugs.webkit.org/show_bug.cgi?id=194707
4253
4254         Reviewed by Carlos Garcia Campos.
4255
4256         * Scripts/webkitpy/thirdparty/__init__.py:
4257         (AutoinstallImportHook._install_pytest):
4258
4259 2019-02-18  Chris Dumez  <cdumez@apple.com>
4260
4261         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4262         https://bugs.webkit.org/show_bug.cgi?id=194797
4263         <rdar://problem/48055151>
4264
4265         Reviewed by Geoffrey Garen.
4266
4267         Add API test coverage.
4268
4269         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4270
4271 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4272
4273         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4274         https://bugs.webkit.org/show_bug.cgi?id=194670
4275         <rdar://problem/39066529>
4276
4277         Reviewed by Tim Horton.
4278
4279         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4280         pasted in an editable area as attachment elements.
4281
4282         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4283         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4284         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4285         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4286         (TestWebKitAPI::TEST):
4287         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4288         (WTR::InjectedBundlePage::InjectedBundlePage):
4289
4290 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4291
4292         Fix API test after r241728
4293        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4294
4295         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4296         (TEST):
4297         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4298
4299 2019-02-18  Daniel Bates  <dabates@apple.com>
4300
4301         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4302         https://bugs.webkit.org/show_bug.cgi?id=192824
4303         <rdar://problem/47100332>
4304
4305         Reviewed by Wenson Hsieh.
4306
4307         Fix a bug where the wrong usage code was used for F13 thru F24.
4308
4309         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4310         (keyCodeForDOMFunctionKey):
4311
4312 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4313
4314         Bytecode cache should a have a boot-specific validation
4315         https://bugs.webkit.org/show_bug.cgi?id=194769
4316         <rdar://problem/48149509>
4317
4318         Reviewed by Keith Miller.
4319
4320         Add test for WTF::bootSessionUUIDString()
4321
4322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4323         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4324         (TEST):
4325
4326 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4327
4328         Disable safe browsing in WKWebView and remove its WKPreferences API
4329         https://bugs.webkit.org/show_bug.cgi?id=194723
4330         <rdar://problem/48122993>
4331
4332         Reviewed by Geoffrey Garen.
4333
4334         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4335         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4336         (TEST):
4337         (safeBrowsingView):
4338         Make tests use SPI instead of API.
4339
4340 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4341
4342         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4343         https://bugs.webkit.org/show_bug.cgi?id=194586
4344
4345         Reviewed by Ross Kirsling.
4346
4347         * DumpRenderTree/win/DumpRenderTree.cpp:
4348         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4349         * Scripts/webkitpy/port/driver.py:
4350         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4351
4352 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4353
4354         Unreviewed, rolling out r241620.
4355
4356         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4357         (Requested by ddkilzer on #webkit.)
4358
4359         Reverted changeset:
4360
4361         "[WTF] Add environment variable helpers"
4362         https://bugs.webkit.org/show_bug.cgi?id=192405
4363         https://trac.webkit.org/changeset/241620
4364