[Qt][WK2] Removed duplicated code from EventSenderProxy::keyDown
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-21  Marcelo Lira  <marcelo.lira@openbossa.org>
2
3         [Qt][WK2] Removed duplicated code from EventSenderProxy::keyDown
4         https://bugs.webkit.org/show_bug.cgi?id=97235
5
6         Reviewed by Luiz Agostini.
7
8         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
9         (WTR::EventSenderProxy::keyDown):
10
11 2012-09-21  Gergely Kis  <gergely@homejinni.com>
12
13         Add MIPS build slave to build.webkit.org
14         https://bugs.webkit.org/show_bug.cgi?id=96713
15
16         Reviewed by Csaba Osztrogonác.
17
18         Added a build slave for MIPS, and enabled a builder for 
19         Qt Linux MIPS32R2 little-endian release build.
20
21         * BuildSlaveSupport/build.webkit.org-config/config.json:
22
23 2012-09-21  Peter Beverloo  <peter@chromium.org>
24
25         [Chromium] Switch back to a fixed fifo path for Android
26         https://bugs.webkit.org/show_bug.cgi?id=97230
27
28         Reviewed by Tony Chang.
29
30         Because not all external storage cards will be formated using a file
31         system that supports named pipes, Chromium has been changed to creating
32         the pipes in a temporary folder on the internal storage. Adapt this in
33         WebKit so we can continue to run layout tests.
34
35         This also includes an *unreviewed* fix for a breakage in the webkitpy
36         tests I made in r129221. Two lines and related to this code, so I decided
37         to include it in this change.
38
39         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
40         (ChromiumAndroidDriver.__init__):
41         (ChromiumAndroidDriver._setup_test):
42         (ChromiumAndroidDriver._update_version):
43
44 2012-09-20  Peter Beverloo  <peter@chromium.org>
45
46         Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
47         https://bugs.webkit.org/show_bug.cgi?id=97227
48
49         Reviewed by Tony Chang.
50
51         We switched Chromium to using FIFOs in order to achieve better consistency,
52         which was done by Marcus in r157541. Remove all custom WebKit code in
53         favor of Chromium's implementation.
54
55         Remove more FIFO code in the test runner itself, including the code in
56         DumpRenderTree that invoked it. We can now switch to Chromium's brand
57         new FIFO-creating code, which is being set-up for all test targets build
58         for Android, including DumpRenderTree, TestWebKitAPI and webkit_unit_tests.
59
60         This also changes the ChromiumAndroidDriver._remove_all_pipes method to
61         delete the files individually. "rm" would fail if one of the earlier files
62         does not exist, and the "-f" argument doesn't seem to be reliable.
63
64         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
65         * DumpRenderTree/chromium/TestShellAndroid.cpp:
66         (platformInit):
67         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
68         (ChromiumAndroidDriver.__init__):
69         (ChromiumAndroidDriver._setup_test):
70         (ChromiumAndroidDriver._get_external_storage):
71         (ChromiumAndroidDriver._drt_cmd_line):
72         (ChromiumAndroidDriver._remove_all_pipes):
73         (ChromiumAndroidDriver.stop):
74         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
75
76 2012-09-21  Christophe Dumez  <christophe.dumez@intel.com>
77
78         [WK2][WKTR] EventSender needs to implement scheduleAsynchronousClick
79         https://bugs.webkit.org/show_bug.cgi?id=97326
80
81         Reviewed by Kenneth Rohde Christiansen.
82
83         Implement scheduleAsynchronousClick() in WebKitTestRunner's
84         EventSender by sending a "MouseDown" and a "MouseUp" message
85         asynchronously to the WebProcess.
86
87         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
88         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
89         (WTR::createMouseMessageBody):
90         (WTR):
91         (WTR::EventSendingController::mouseDown):
92         (WTR::EventSendingController::mouseUp):
93         (WTR::EventSendingController::scheduleAsynchronousClick):
94         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
95         (EventSendingController):
96         * WebKitTestRunner/TestController.cpp:
97         (WTR::TestController::didReceiveMessageFromInjectedBundle):
98
99 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
100
101         [Qt] Error out early if we don't have ICU available
102
103         Reviewed by Tor Arne Vestbø.
104
105         * qmake/mkspecs/features/configure.prf:
106
107 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
108
109         [Qt] Bail out when trying to build WebKit with Qt != 5
110
111         Reviewed by Tor Arne Vestbø.
112
113         Moved check for Qt version out of default_pre into top-level WebKit.pro,
114         because we never reach default_pre.prf due to the lack of .qmake.conf support
115         in older versions of Qt/QMake.
116
117         * qmake/mkspecs/features/default_pre.prf:
118
119 2012-09-21  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
120
121         WebKitTestRunner needs to print frame load delegate information
122         https://bugs.webkit.org/show_bug.cgi?id=42705
123
124         Reviewed by Kenneth Rohde Christiansen.
125
126         Added missing dumping from WTR::InjectedBundlePage::didFailLoadWithErrorForFrame.
127
128         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
129         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
130
131 2012-09-21  Christophe Dumez  <christophe.dumez@intel.com>
132
133         [EFL] EventSender should mimic CTRL+o emacs shortcut
134         https://bugs.webkit.org/show_bug.cgi?id=97224
135
136         Reviewed by Kenneth Rohde Christiansen.
137
138         Add support for mimicking CTRL+o emacs shortcut in EFL's
139         EventSender in DumpRenderTree and WebKitTestRunner.
140
141         * DumpRenderTree/efl/EventSender.cpp:
142         (sendKeyDown):
143         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
144         (WTR::EventSenderProxy::keyDown):
145
146 2012-09-21  Simon Hausmann  <simon.hausmann@digia.com>
147
148         [Qt] Re-fix clean builds
149
150         Reviewed by Tor Arne Vestbø.
151
152         Re-introduce the sanitization for LIBS when creating a module to use
153         LIBS_PRIVATE and otherwise do _not_ use LIBS_PRIVATE. We decided to
154         continue to use QT, LIBS and PKGCONFIG instead of their _PRIVATE variants
155         throughout the code base, so just using LIBS_PRIVATE in linkAgainstLibrary()
156         causes build issues when depending system libraries end up in LIBS before
157         LIBS_PRIVATE.
158
159         * qmake/mkspecs/features/default_post.prf:
160         * qmake/mkspecs/features/functions.prf:
161
162 2012-09-20  Simon Fraser  <simon.fraser@apple.com>
163
164         Comment out a failing webkitpy unit test until Dirk can fix it.
165
166         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
167         (SemanticTests.test_skip_and_wontfix):
168
169 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
170
171         make Skip, WontFix be the only expectations on a line
172         https://bugs.webkit.org/show_bug.cgi?id=97225
173
174         Reviewed by Ojan Vafai.
175
176         It is now incorrect in the new syntax to have a line like:
177
178             foo.html [ WontFix Crash ]
179
180         This will generate a lint warning and be treated as an invalid
181         line. Fixing this caused a whole bunch of unit tests to need updating
182         to no longer be marked as WontFix :). Also, this patch adjusts
183         the warnings so that missing Bug() identifiers will cause lint
184         warnings but will *not* cause the line to be treated as invalid.
185         Fixing these issues also revealed that test_hung_thread was no
186         longer testing the right logic, so I adjusted the timeouts in
187         test.py to make that test work again.
188
189         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
190         (Worker._run_test_in_another_thread):
191         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
192         (ResultSummaryTest.test_summarized_results_wontfix):
193         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
194         (TestExpectationParser._parse_modifiers):
195         (TestExpectationParser._tokenize_line_using_new_format):
196         (TestExpectationLine.is_invalid):
197         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
198         (BasicTests.test_basic):
199         (test_get_test_set):
200         (test_parse_warning):
201         (test_pixel_tests_flag):
202         (SemanticTests.test_missing_bugid):
203         (SemanticTests):
204         (SemanticTests.test_skip_and_wontfix):
205         * Scripts/webkitpy/layout_tests/port/test.py:
206         (TestDriver.run_test):
207         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
208         (MainTest.test_hung_thread):
209         * Scripts/webkitpy/tool/commands/queries_unittest.py:
210         (PrintExpectationsTest.test_basic):
211         (PrintExpectationsTest.test_multiple):
212         (PrintExpectationsTest.test_full):
213         (PrintExpectationsTest.test_exclude):
214         (PrintExpectationsTest.test_csv):
215
216 2012-09-20  Lucas Forschler  <lforschler@apple.com>
217
218         Unreviewed.  Start running tests on the mac-ews.
219         
220         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
221         (MacEWS):
222
223 2012-09-20  Tony Chang  <tony@chromium.org>
224
225         [chromium] Enable more clang warnings
226         https://bugs.webkit.org/show_bug.cgi?id=97257
227
228         Reviewed by James Robinson.
229
230         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
231         there are lots of violations in these files.
232
233 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
234
235         run-perf-tests should record individual value instead of statistics
236         https://bugs.webkit.org/show_bug.cgi?id=97155
237
238         Reviewed by Hajime Morita.
239
240         Parse the list of individual value reported by tests and include them as "values".
241         We strip "values" from the output JSON when uploading it to the perf-o-matic
242         since it doesn't know how to parse "values" or ignore it.
243
244         * Scripts/webkitpy/performance_tests/perftest.py:
245         (PerfTest):
246         (PerfTest.parse_output): Parse and report "values".
247         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
248         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
249         (MainTest.test_parse_output):
250         (MainTest.test_parse_output_with_failing_line):
251         (TestPageLoadingPerfTest.test_run):
252         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
253         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
254         until we update perf-o-matic.
255         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
256         (test_run_memory_test):
257         (test_run_with_json_output):
258         (test_run_with_description):
259         (test_run_with_slave_config_json):
260         (test_run_with_multiple_repositories):
261
262 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
263
264         [Qt] Fix production builds
265
266         Unreviewed trivial fix: Follow up r129119 and avoid clobbering LIBS through the use of LIBS_PRIVATE.
267
268         Otherwise the libQtWebKit.prl file for example contains -lWebKit1 -lWebCore, etc.
269
270         * qmake/mkspecs/features/functions.prf:
271
272 2012-09-20  Dirk Pranke  <dpranke@chromium.org>
273
274         REGRESSION: layout test results doesn't show diffs
275         https://bugs.webkit.org/show_bug.cgi?id=97182
276
277         Reviewed by Ojan Vafai.
278
279         Go back to storing TEXT, AUDIO, and IMAGE+TEXT in results.json
280         so that results.html (and hopefully garden-o-matic) can
281         determine which things actually failed. However, we keep mapping
282         these results to Failure so that we still only have a single
283         expectation type for them.
284
285         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
286         (JSONLayoutResultsGenerator):
287         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
288         (TestExpectationParser):
289         (TestExpectations):
290         (TestExpectations.result_was_expected):
291         * Scripts/webkitpy/layout_tests/models/test_failures.py:
292         (determine_result_type):
293         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
294         (MainTest.test_missing_and_unexpected_results):
295         (MainTest.test_retrying_and_flaky_tests):
296
297 2012-09-20  Tommy Widenflycht  <tommyw@google.com>
298
299         MediaStream API: Extend UserMediaRequest with a ownerDocument method
300         https://bugs.webkit.org/show_bug.cgi?id=97095
301
302         Reviewed by Adam Barth.
303
304         Extending WebUserMediaClientMock to check that the owning document is valid,
305         and that the document has a frame.
306
307         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
308         (WebKit::WebUserMediaClientMock::requestUserMedia):
309
310 2012-09-20  Stephen Chenney  <schenney@chromium.org>
311
312         [Chromium] DRT does not support --dump-all-pixels flag
313         https://bugs.webkit.org/show_bug.cgi?id=95098
314
315         Reviewed by Dirk Pranke.
316
317         Add support for the --pixel-tests and shorthand -p option in Chromium DumpRenderTree. Use
318         of this flag causes pixel results to be created for all tests, regardless of
319         individual test options. If an individual test provides a pixel hash it will be used,
320         otherwise the hash will be empty. This replaces a previously defined but unused option
321         --dump-all-pixels, and is useful primarily when debugging DRT instances.
322
323         * DumpRenderTree/chromium/DumpRenderTree.cpp:
324         (runTest): Add a parameter and code to force pixel results for the test.
325         (main): Add parameter handling for --pixels-test and -p, and remove --dump-all-pixels.
326
327 2012-09-20  Carlos Garcia Campos  <cgarcia@igalia.com>
328
329         [GTK] run-api-tests should not buffer test stdout
330         https://bugs.webkit.org/show_bug.cgi?id=88474
331
332         Reviewed by Philippe Normand.
333
334         * Scripts/run-gtk-tests:
335         (TestRunner._run_test_command): Use os.forkpty() instead of
336         subprocess.Popen() so that gtest sends the output with colors to
337         stdout. Use common.parse_output_lines() to parse the output and
338         write it to stdout while it's read.
339         (TestRunner._run_test_command.parse_line): Parse the line to get
340         the test pid and write the line to stdout.
341         (TestRunner._run_test_command.waitpid): Helper function to call
342         waitpid handling EINTR.
343         (TestRunner._run_test_command.return_code_from_exit_status):
344         Helper function to convert exit status of test commands to a
345         return code.
346         * gtk/common.py:
347         (parse_output_lines): Helper function that uses select to read
348         the given file descriptor and call the given callback for every
349         line read.
350
351 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
352
353         [Qt] Fix initial build
354
355         Reviewed by Tor Arne Vestbø.
356
357         When building QtWebKit the first time there is no qt_webkit.pri module pri file, and therefore
358         $$QT.webkit.name isn't set and so creating_module isn't set. That has all sorts of implications
359         causing incorrect linking for Makefile.api, etc.
360
361         Fix the determination by simply checking if MODULE is set, which only happens in api.pri.
362
363         * qmake/mkspecs/features/webkit_modules.prf:
364
365 2012-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
366
367         Unreviewed, rolling out r129091.
368         http://trac.webkit.org/changeset/129091
369         https://bugs.webkit.org/show_bug.cgi?id=97205
370
371         It broke perf tests everywhere (Requested by Ossy on #webkit).
372
373         * Scripts/webkitpy/performance_tests/perftest.py:
374         (PerfTest):
375         (PerfTest.parse_output):
376         (PageLoadingPerfTest.run):
377         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
378         (MainTest.test_parse_output):
379         (MainTest.test_parse_output_with_failing_line):
380         (TestPageLoadingPerfTest.test_run):
381         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
382         (PerfTestsRunner._generate_and_show_results):
383         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
384         (test_run_memory_test):
385         (test_run_with_json_output):
386         (test_run_with_description):
387         (test_run_with_slave_config_json):
388         (test_run_with_multiple_repositories):
389
390 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
391
392         [Qt] QtWebKit module header includes private dependencies
393
394         Reviewed by Tor Arne Vestbø.
395
396         * qmake/mkspecs/features/default_post.prf: Don't try to sanitize LIBS, because we can make sure
397         that LIBS_PRIVATE is set from the beginning. Moved the creating_module and PKGCONFIG/QT(_PRIVATE)
398         sanitization into webkit_modules.prf. creating_module determination requires TARGET to be set, so
399         we can't do it in default_pre.
400         * qmake/mkspecs/features/webkit_modules.prf:
401
402 2012-09-20  Simon Hausmann  <simon.hausmann@digia.com>
403
404         [Qt] Fix build with MingW
405
406         Reviewed by Tor Arne Vestbø.
407
408         Don't try to compile WebCore, etc. with debug symbols for production
409         builds, it's just too big.
410
411         * qmake/mkspecs/features/production_build.prf:
412
413 2012-09-20  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
414
415         [EFL][DRT]DumpRenderTree needs to reset focus state when test starts.
416         https://bugs.webkit.org/show_bug.cgi?id=97087
417
418         Reviewed by Gyuyoung Kim.
419
420         Add focusing a main frame on settings reset.
421         After editing/undo/undo-iframe-location-change was executed a frame
422         was left in unfocused state. This caused flakiness in two tests results.
423
424         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
425         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
426
427 2012-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
428
429         [Qt] Add eventSender.gestureTap
430         https://bugs.webkit.org/show_bug.cgi?id=66173
431
432         Reviewed by Kenneth Rohde Christiansen.
433
434         Implement support for sending raw QGesture events.
435
436         * DumpRenderTree/qt/EventSenderQt.cpp:
437         (EventSender::EventSender):
438         (EventSender::gestureTap):
439         * DumpRenderTree/qt/EventSenderQt.h:
440         (EventSender):
441
442 2012-09-19  Sheriff Bot  <webkit.review.bot@gmail.com>
443
444         Unreviewed, rolling out r129007.
445         http://trac.webkit.org/changeset/129007
446         https://bugs.webkit.org/show_bug.cgi?id=97172
447
448         It broke the build on the Qt bots (Requested by Ossy on
449         #webkit).
450
451         * qmake/config.tests/gccdepends/empty.cpp:
452         * qmake/config.tests/gccdepends/gccdepends.pro:
453         * qmake/mkspecs/features/default_pre.prf:
454
455 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
456
457         run-perf-tests should record indivisual value instead of statistics
458         https://bugs.webkit.org/show_bug.cgi?id=97155
459
460         Reviewed by Hajime Morita.
461
462         Parse the list of indivisual value reported by tests and include them as "values".
463         We strip "values" from the output JSON when uploading it to the perf-o-matic
464         since it doesn't know how to parse "values" or ignore it.
465
466         * Scripts/webkitpy/performance_tests/perftest.py:
467         (PerfTest):
468         (PerfTest.parse_output): Parse and report "values".
469         (PageLoadingPerfTest.run): Report indivisual page loading time in "values".
470         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
471         (MainTest.test_parse_output):
472         (MainTest.test_parse_output_with_failing_line):
473         (TestPageLoadingPerfTest.test_run):
474         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
475         (PerfTestsRunner._generate_and_show_results): Strip "values" from each result
476         until we update perf-o-matic.
477         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
478         (test_run_memory_test):
479         (test_run_with_json_output):
480         (test_run_with_description):
481         (test_run_with_slave_config_json):
482         (test_run_with_multiple_repositories):
483
484 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
485
486         Fix regex groups for bug matching in flakiness dashboard.
487         https://bugs.webkit.org/show_bug.cgi?id=97152
488
489         Unreviewed, build fix.
490
491         * TestResultServer/static-dashboards/flakiness_dashboard.js:
492         (htmlForBugs):
493
494 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
495
496         nrwt: print unexpected results using new TestExpectations syntax
497         https://bugs.webkit.org/show_bug.cgi?id=97159
498
499         Unreviewed, build fix.
500
501         Change new-run-webkit-tests to print out failures using the new
502         syntax when there are unexpected results, e.g.:
503
504         52 tests ran as expected, 19 didn't:
505
506
507         Regressions: Unexpected failures : (2)
508           failures/flaky/text.html [ Failure ]
509           failures/unexpected/text-image-checksum.html [ Failure ]
510
511         and so forth
512
513         * Scripts/webkitpy/layout_tests/views/printing.py:
514         (Printer._print_unexpected_results):
515
516 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
517
518         update flakiness dashboard after cutover to new test expectations syntax
519         https://bugs.webkit.org/show_bug.cgi?id=97152
520
521         Unreviewed, build fix.
522
523         Handle (??) the new Bug notations as well. Hopefully we don't
524         still need the old ones.
525
526         * TestResultServer/static-dashboards/flakiness_dashboard.js:
527         (filterBugs):
528         (htmlForBugs):
529         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
530
531 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
532
533         update flakiness dashboard after cutover to new test expectations syntax
534         https://bugs.webkit.org/show_bug.cgi?id=97152
535
536         Reviewed by Ryosuke Niwa.
537
538         This change clones the TestExpectation parsing state machine
539         from python into javascript.
540
541         * TestResultServer/static-dashboards/flakiness_dashboard.js:
542         (parsedExpectations.lines.forEach):
543         (parsedExpectations):
544         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
545
546 2012-09-19  Dana Jansens  <danakj@chromium.org>
547
548         Add backer@chromium.org as contributor
549         https://bugs.webkit.org/show_bug.cgi?id=97150
550
551         * Scripts/webkitpy/common/config/committers.py:
552
553 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
554
555         fix MISSING after TestExpectations conversion
556         https://bugs.webkit.org/show_bug.cgi?id=97148
557
558         Unreviewed, expectations change / build fix.
559
560         * Scripts/convert-test-expectations:
561         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
562         (TestExpectationParser):
563
564 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
565
566         nrwt: convert chromium TestExpectations to the new syntax
567         https://bugs.webkit.org/show_bug.cgi?id=97139
568
569         Reviewed by Ryosuke Niwa.
570     
571         Add in a file temporarily that does the conversion of
572         test expectations formats
573
574         * Tools/Scripts/convert-test-expectations: Added.
575
576 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
577
578         REGRESSION: run-perf-tests no longer reports the total test time
579         https://bugs.webkit.org/show_bug.cgi?id=97138
580
581         Reviewed by Tony Chang.
582
583         Report the finished time as a info-level log as opposed to a debug level log.
584
585         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
586         (PerfTestsRunner._run_single_test):
587         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
588         (MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
589         (test_run_test_pause_before_testing):
590         (test_run_test_set_for_parser_tests):
591         (test_run_memory_test):
592         (_test_run_with_json_output):
593
594 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
595
596         Support new TestExpectations format alongside old one
597         https://bugs.webkit.org/show_bug.cgi?id=96588
598
599         Reviewed by Ojan Vafai.
600
601         This patch adds support for actually reading in lines formatted
602         in the new style, and when we re-serialize/write out the file,
603         all lines will be written in the new style. Note that reading in
604         the old style is still supported, and no updates are being made
605         to the actual TestExpectations files as part of this change.
606
607         This change updates most but not all of the unit tests to use
608         the new syntax. I will update the rest when (or before where
609         possible) I drop support for the old format.
610
611         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
612         (TestExpectationParser):
613         (TestExpectationParser._tokenize_line):
614         (TestExpectationParser._tokenize_line_using_new_format):
615         (TestExpectationLine.to_string):
616         (TestExpectationLine._format_line):
617         (TestExpectations):
618         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
619         (test_parse_warning):
620         (SkippedTests.test_skipped_entry_dont_exist):
621         (NewExpectationSyntaxTests.test_warnings):
622         (RemoveConfigurationsTest.test_remove):
623         (test_remove_line):
624         (RebaseliningTest.test_remove):
625         (RebaseliningTest.test_no_get_rebaselining_failures):
626         (TestExpectationParserTests.test_tokenize_blank):
627         (TestExpectationParserTests.test_tokenize_extra_colon):
628         (TestExpectationParserTests.test_tokenize_missing_equal):
629         (TestExpectationParserTests.test_tokenize_extra_equal):
630         (TestExpectationSerializationTests.test_unparsed_to_string):
631         (TestExpectationSerializationTests.test_unparsed_list_to_string):
632         (TestExpectationSerializationTests.test_parsed_to_string):
633         (TestExpectationSerializationTests.test_format_line):
634         (TestExpectationSerializationTests.test_string_roundtrip):
635         (TestExpectationSerializationTests.test_list_roundtrip):
636         (TestExpectationSerializationTests.test_reconstitute_only_these):
637         (TestExpectationSerializationTests.test_string_whitespace_stripping):
638         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
639         (LintTest.test_lint_test_files__errors):
640         * Scripts/webkitpy/tool/commands/queries_unittest.py:
641         (PrintExpectationsTest.test_basic):
642         (PrintExpectationsTest.test_multiple):
643         (PrintExpectationsTest.test_full):
644         (PrintExpectationsTest.test_exclude):
645         * Scripts/webkitpy/tool/commands/rebaseline.py:
646         (RebaselineExpectations.execute):
647         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
648         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
649         (test_rebaseline_updates_expectations_file):
650         (test_rebaseline_does_not_include_overrides):
651         (test_rebaseline_expectations_noop):
652         (test_overrides_are_included_correctly):
653
654 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
655
656         implement first part of support for the new TestExpectations syntax
657         https://bugs.webkit.org/show_bug.cgi?id=96569
658
659         Reviewed by Ryosuke Niwa.
660
661         This patch implements support for parsing a line of the new
662         format for the TestExpectations file and converting it back into
663         the old format for compatibility. This routine is not yet used
664         by anything.
665
666         The new format is documented at:
667           http://trac.webkit.org/wiki/TestExpectations
668
669         but, in short:
670
671           [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]
672
673         - Comments are indicated with "#" instead of "//"
674         - If no expectations are specified we default to Skip for
675           compatibility with the Skipped files (these two changes make
676           Skipped files a subset of TestExpectations files)
677
678         - All of the tokens are now CamelCase instead of ALLCAPS.
679         - FAIL -> Failure
680         - IMAGE -> ImageOnlyFailure
681         - WONTFIX -> WontFix
682         - modifiers refer to just the platforms and configurations
683           (release/debug) that the line applies to.
684         - WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
685           expectations
686         - expectations will typically be written out in lexicographic order
687         - We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
688           instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
689
690         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
691         (TestExpectationParser):
692         (TestExpectationParser._tokenize_line_using_new_format):
693         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
694         (NewExpectationSyntaxTests):
695         (NewExpectationSyntaxTests.assert_exp):
696         (NewExpectationSyntaxTests.test_bare_name):
697         (NewExpectationSyntaxTests.test_bare_name_and_bugs):
698         (NewExpectationSyntaxTests.test_comments):
699         (NewExpectationSyntaxTests.test_config_modifiers):
700         (NewExpectationSyntaxTests.test_unknown_config):
701         (NewExpectationSyntaxTests.test_unknown_expectation):
702         (NewExpectationSyntaxTests.test_skip):
703         (NewExpectationSyntaxTests.test_slow):
704         (NewExpectationSyntaxTests.test_wontfix):
705         (NewExpectationSyntaxTests.test_blank_line):
706         (NewExpectationSyntaxTests.test_warnings):
707
708 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
709
710         nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
711         https://bugs.webkit.org/show_bug.cgi?id=96845
712
713         Reviewed by Ojan Vafai.
714
715         In preparation for the new TestExpectations syntax, we replace
716         all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
717         make switching to the new syntax lossless (i.e., we lose
718         information now, not then).
719
720         Note that we can still parse in results.json files that have the
721         old data for backwards compatibility.
722         
723
724         * Scripts/webkitpy/common/net/resultsjsonparser.py:
725         (JSONTestResult._failure_types_from_actual_result):
726         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
727         (ResultsJSONParserTest):
728         (test_basic):
729         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
730         (ResultSummaryTest.test_summarized_results_wontfix):
731         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
732         (JSONLayoutResultsGenerator):
733         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
734         (TestExpectations):
735         (TestExpectations.remove_pixel_failures):
736         (TestExpectations.has_pixel_failures):
737         (TestExpectations.suffixes_for_expectations):
738         (TestExpectations.get_rebaselining_failures):
739         (TestExpectations.remove_configuration_from_test):
740         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
741         (assert_bad_expectations):
742         (BasicTests):
743         (BasicTests.test_basic):
744         (MiscTests):
745         (MiscTests.test_multiple_results):
746         (MiscTests.test_result_was_expected):
747         (MiscTests.test_remove_pixel_failures):
748         (MiscTests.test_suffixes_for_expectations):
749         (test_get_expectations_string):
750         (test_parse_warning):
751         (test_error_on_different_platform):
752         (test_error_on_different_build_type):
753         (test_overrides):
754         (test_overrides__directory):
755         (test_overrides__duplicate):
756         (test_pixel_tests_flag):
757         (test_more_specific_override_resets_skip):
758         (SkippedTests.test_skipped_file_overrides_expectations):
759         (SkippedTests.test_skipped_dir_overrides_expectations):
760         (SkippedTests.test_skipped_file_overrides_overrides):
761         (SkippedTests.test_skipped_dir_overrides_overrides):
762         (ExpectationSyntaxTests.test_missing_colon):
763         (ExpectationSyntaxTests.test_too_many_equals_signs):
764         (SemanticTests.test_bug_format):
765         (SemanticTests.test_bad_bugid):
766         (SemanticTests.test_missing_bugid):
767         (SemanticTests.test_rebaseline):
768         (test_missing_file):
769         (test_more_modifiers):
770         (test_order_in_file):
771         (test_macro_overrides):
772         (RemoveConfigurationsTest.test_remove):
773         (test_remove_line):
774         (RebaseliningTest.test_remove):
775         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
776         * Scripts/webkitpy/layout_tests/models/test_failures.py:
777         (determine_result_type):
778         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
779         (test_test_expectations):
780         * Scripts/webkitpy/layout_tests/port/test.py:
781         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
782         (MainTest.test_missing_and_unexpected_results):
783         (MainTest.test_retrying_and_flaky_tests):
784         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
785         (TestExpectationsTestCase.test_valid_expectations):
786         * Scripts/webkitpy/tool/commands/queries_unittest.py:
787         (PrintExpectationsTest.test_basic):
788         (PrintExpectationsTest.test_multiple):
789         (PrintExpectationsTest.test_full):
790         (PrintExpectationsTest.test_exclude):
791         (PrintExpectationsTest.test_csv):
792         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
793         (test_rebaseline_does_not_include_overrides):
794         (test_overrides_are_included_correctly):
795
796 2012-09-19  Dominic Mazzoni  <dmazzoni@google.com>
797
798         AX: A few control types are returning the wrong answer for isReadOnly
799         https://bugs.webkit.org/show_bug.cgi?id=96735
800
801         Reviewed by Chris Fleizach.
802
803         Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
804
805         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
806         (AccessibilityUIElement::AccessibilityUIElement):
807         (AccessibilityUIElement::isReadOnlyGetterCallback):
808         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
809         (AccessibilityUIElement):
810
811 2012-09-19  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
812
813         [WTR] Memory leaks in TestRunner::deliverWebIntent()
814         https://bugs.webkit.org/show_bug.cgi?id=97111
815
816         Reviewed by Kenneth Rohde Christiansen.
817
818         Fix memory leaks in deliverWebIntent() by adopting strings
819         created with WKStringCreateWithUTF8CString().
820
821         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
822         (WTR::TestRunner::deliverWebIntent):
823
824 2012-09-19  Simon Hausmann  <simon.hausmann@digia.com>
825
826         [Qt] Fix incremental builds with all-in-one-files and gccdepends
827
828         Reviewed by Tor Arne Vestbø.
829
830         Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
831         are not only created for header files but also for .cpp files. AllInOne.cpp files
832         include other .cpp files, and when those are removed we need those dummy rules to
833         avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
834
835         * qmake/config.tests/gccdepends/empty.cpp:
836         (main):
837         * qmake/config.tests/gccdepends/gccdepends.pro:
838         * qmake/mkspecs/features/default_pre.prf:
839
840 2012-09-19  Rick Byers  <rbyers@chromium.org>
841
842         Do touch adjustment on GestureTapDown
843         https://bugs.webkit.org/show_bug.cgi?id=96677
844
845         Reviewed by Antonio Gomes.
846
847         Allow radius to be set for GestureTapDown events.
848         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
849         (EventSender::gestureEvent):
850
851 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
852
853         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
854         https://bugs.webkit.org/show_bug.cgi?id=97100
855
856         Reviewed by Gyuyoung Kim.
857
858         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
859         preference, in order to match WebKitTestRunner functionality.
860
861         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
862         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
863         * DumpRenderTree/efl/TestRunnerEfl.cpp:
864         (TestRunner::overridePreference):
865
866 2012-09-18  Kangil Han  <kangil.han@samsung.com>
867
868         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
869         https://bugs.webkit.org/show_bug.cgi?id=96181
870
871         Reviewed by Daniel Bates.
872
873         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
874
875         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
876         (new):
877         (_parseLicenseBlock):
878         (_parseLicenseBlockFromFile):
879         (_defaultLicenseBlock):
880         (_licenseBlock):
881         (_generateHeaderFile):
882         (_generateImplementationFile):
883
884 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
885
886         Title string should be changed when document.title is set to ''.
887         https://bugs.webkit.org/show_bug.cgi?id=96793
888
889         Reviewed by Kenneth Rohde Christiansen.
890
891         Change dump format of dumpTitleChanges more understandable.
892         Uses single quotation marks for the title string.
893
894         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
895         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
896         * DumpRenderTree/chromium/WebViewHost.cpp:
897         (WebViewHost::didReceiveTitle):
898         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
899         (DumpRenderTreeChrome::onFrameTitleChanged):
900         * DumpRenderTree/gtk/DumpRenderTree.cpp:
901         (webViewTitleChanged):
902         * DumpRenderTree/mac/FrameLoadDelegate.mm:
903         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
904         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
905         (WebCore::DumpRenderTree::titleChanged):
906         * DumpRenderTree/win/FrameLoadDelegate.cpp:
907         (FrameLoadDelegate::didReceiveTitle):
908         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
909         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
910         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
911         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
912
913 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
914
915         EWS shouldn't sleep if there are new patches in its queue
916         https://bugs.webkit.org/show_bug.cgi?id=83038
917
918         Reviewed by Eric Seidel.
919
920         EWS tries to process a security patch. Of course it can't, because the EWS isn't
921         the member of the security group. But the problem is that after it can't process
922         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
923         and push the security patch to the end of the queue.
924         Now it stays in the loop until it finds a patch or the queue gets empty.
925
926         * Scripts/webkitpy/tool/commands/queues.py:
927         (AbstractPatchQueue._next_patch):
928         * Scripts/webkitpy/tool/commands/queues_unittest.py:
929         (AbstractPatchQueueTest.test_next_patch):
930
931 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
932
933         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
934         https://bugs.webkit.org/show_bug.cgi?id=97014
935
936         Reviewed by Kenneth Rohde Christiansen.
937
938         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
939         be used for literals rather than WTF::StringBuilder::append().
940
941         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
942         (WTR::InjectedBundle::booleanForKey):
943
944 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
945
946         Update my e-mail address.
947
948         * Scripts/webkitpy/common/config/committers.py:
949
950 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
951
952         Update my e-mail address.
953
954         Unreviewed.
955
956         * Scripts/webkitpy/common/config/committers.py:
957
958 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
959
960         [Qt] qt_webkit.pri should not be listed in Tools.pro
961
962         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
963
964         Since r128751 the module pri file is auto-generated
965         but it was still listed in OTHER_FILES.
966
967         * Tools.pro: Remove unneeded line.
968
969 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
970
971         [Qt] Fix build with some versions of the gold linker
972
973         Reviewed by Tor Arne Vestbø.
974
975         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
976         Instead run a compile/link test first to see if it works.
977
978         * qmake/config.tests/gnuld/gnuld.pro: Added.
979         * qmake/config.tests/gnuld/main.cpp: Added.
980         (main):
981         * qmake/mkspecs/features/unix/default_post.prf:
982
983 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
984
985         [Qt] Remove forced use of gold.
986
987         Reviewed by Tor Arne Vestbø.
988
989         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
990         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
991         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
992
993         * qmake/mkspecs/features/unix/default_post.prf:
994
995 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
996
997         [Qt] Prospective Qt/Windows cross-compiling fix
998
999         Reviewed by Tor Arne Vestbø.
1000
1001         The win32 scope is not set when cross-compiling from Linux to Windows.
1002
1003         * qmake/mkspecs/features/functions.prf:
1004
1005 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
1006
1007         [EFL] Remove background view on EWebLauncher and MiniBrowser
1008         https://bugs.webkit.org/show_bug.cgi?id=96905
1009
1010         Reviewed by Gyuyoung Kim.
1011
1012         The size of webview was changed after adding url bar.
1013         And the background view is not necessary anymore, since it was used for debugging back in the day.
1014
1015         * EWebLauncher/main.c:
1016         (_ELauncher):
1017         (on_ecore_evas_resize):
1018         (browserCreate):
1019         * MiniBrowser/efl/main.c:
1020         (_MiniBrowser):
1021         (on_ecore_evas_resize):
1022         (browserCreate):
1023
1024 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
1025
1026         [GTK] run-webkit-tests unable to find TestExpectations for WK2
1027         https://bugs.webkit.org/show_bug.cgi?id=96998
1028
1029         Reviewed by Philippe Normand.
1030
1031         We should look for TestExpectations files in all the locations where
1032         we currently look for Skipped files. This will allow
1033         run-webkit-tests to look for TestExpectations files in
1034         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
1035
1036         * Scripts/webkitpy/layout_tests/port/gtk.py:
1037         (GtkPort.expectations_files):
1038
1039 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1040
1041         [Qt] Fix build without the QtQuick module
1042
1043         Reviewed by Simon Hausmann.
1044
1045         * qmake/mkspecs/features/features.prf:
1046
1047 2012-09-18  Stephanie Lewis  <slewis@apple.com>
1048
1049         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
1050
1051         Unreviewed.
1052
1053         * DumpRenderTree/mac/DumpRenderTree.mm:
1054         (poseAsClass):
1055
1056 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1057
1058         Unreviewed update of email addresses for Berlin QtWebKit office.
1059
1060         * Scripts/webkitpy/common/config/committers.py:
1061
1062 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
1063
1064         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
1065         https://bugs.webkit.org/show_bug.cgi?id=96899
1066
1067         Reviewed by Martin Robinson.
1068
1069         When overriding the 'WebKitDisplayImageKey' preference, use the
1070         'auto-load-images' property of WebKitWebSettings as the property which
1071         should be updated with the corresponding preference value.
1072
1073         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1074         (resetDefaultsToConsistentValues):
1075         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1076         (TestRunner::overridePreference):
1077
1078 2012-09-17  Pratik Solanki  <psolanki@apple.com>
1079
1080         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
1081         https://bugs.webkit.org/show_bug.cgi?id=96973
1082
1083         Reviewed by Dan Bernstein.
1084
1085         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1086         * WebKitTestRunner/Configurations/Base.xcconfig:
1087         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
1088
1089 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
1090
1091         nrwt: remove "unexpected EOF" warnings
1092         https://bugs.webkit.org/show_bug.cgi?id=96970
1093
1094         Reviewed by Ojan Vafai.
1095
1096         After debugging this a bit, it looks like there aren't any cases
1097         that I can reproduce where a read() of zero indicates something
1098         actually wrong; either it is a prelude to a crash, or a false
1099         negative. So, I'm removing these warnings and adding a comment.
1100
1101         * Scripts/webkitpy/layout_tests/port/server_process.py:
1102         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1103
1104 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
1105
1106         [chromium] ASAN bot is crashing at the end of the run
1107         https://bugs.webkit.org/show_bug.cgi?id=96967
1108
1109         Reviewed by Abhishek Arya.
1110
1111         The ASAN bot is crashing attempting to decode some output into
1112         UTF-8; there's no reason to do this, so let's not do this and
1113         see if something else is going on as well.
1114
1115         * Scripts/webkitpy/layout_tests/port/chromium.py:
1116         (ChromiumPort._get_crash_log):
1117
1118 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
1119
1120         nrwt: --results-directory isn't getting printed properly
1121         https://bugs.webkit.org/show_bug.cgi?id=96965
1122
1123         Reviewed by Ojan Vafai.
1124
1125         options.results_directory isn't actually initialized with the
1126         default values until after we call print_config(), so this
1127         changes things to print the value directly.
1128
1129         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1130         (run):
1131         * Scripts/webkitpy/layout_tests/views/printing.py:
1132         (Printer.print_config):
1133         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1134         (Testprinter.test_print_config):
1135
1136 2012-09-17  Rob Buis  <rbuis@rim.com>
1137
1138         [BlackBerry] Enable VIDEO_TRACK
1139         https://bugs.webkit.org/show_bug.cgi?id=96949
1140
1141         Reviewed by Antonio Gomes.
1142
1143         * Scripts/webkitperl/FeatureList.pm:
1144
1145 2012-09-17  Rick Byers  <rbyers@chromium.org>
1146
1147         Add handling of new GestureTapCancel in DRT
1148
1149         https://bugs.webkit.org/show_bug.cgi?id=96183
1150
1151         Reviewed by Antonio Gomes.
1152
1153         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1154         (TestWebPlugin::handleInputEvent):
1155         * DumpRenderTree/chromium/EventSender.cpp:
1156         (EventSender::gestureTapCancel):
1157
1158 2012-09-17  Philip Rogers  <pdr@google.com>
1159
1160         Teach style checker about preprocessor directive indentation rules
1161         https://bugs.webkit.org/show_bug.cgi?id=96874
1162
1163         Reviewed by Adam Barth.
1164
1165         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
1166         This is not explicit in our style guide but is generally followed in our code.
1167         Searching for violations in our codebase shows these are rarely indented:
1168             #include - indented in 6 files
1169             #ifdef - indented in 0 files
1170             #ifndef - indented in 1 file
1171             #define - indented in 11 files
1172             #if - indented in 7 files
1173
1174         * Scripts/webkitpy/style/checkers/cpp.py:
1175         (check_directive_indentation):
1176
1177             This is the simple test where we look for spaces followed by a #.
1178
1179         (check_style):
1180         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1181
1182             A few tests needed to be modified because they had unintentionally indented
1183             preprocessor directives.
1184
1185         (CppStyleTest.test_build_class.Foo):
1186         (CppStyleTest.test_build_class):
1187         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
1188         (WebKitStyleTest.test_line_breaking):
1189         (WebKitStyleTest.test_directive_indentation):
1190
1191 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1192
1193         [Qt] Auto-generate the module pri file for QtWebKit
1194
1195         Reviewed by Simon Hausmann.
1196
1197         * qmake/qt_webkit.pri: Removed.
1198
1199 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
1200
1201         nrwt: --additional-platform-dir is broken on chromium ports
1202         https://bugs.webkit.org/show_bug.cgi?id=96840
1203
1204         Reviewed by Ojan Vafai.
1205
1206         Looks like I broke this when cleaning things up as part of
1207         adding ML support. Fixing and adding a test.
1208
1209         * Scripts/webkitpy/layout_tests/port/chromium.py:
1210         (ChromiumPort.default_baseline_search_path):
1211         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1212         (ChromiumAndroidPort.default_baseline_search_path):
1213         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1214         (ChromiumLinuxPort.default_baseline_search_path):
1215         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1216         (ChromiumMacPort.__init__):
1217         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1218         (ChromiumWinPort.setup_environ_for_server):
1219         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1220         (test_check_build):
1221         (test_additional_platform_directory):
1222
1223 2012-09-13  Stephanie Lewis  <slewis@apple.com>
1224
1225         mac-future ignores previous platform TestExpectations.
1226         https://bugs.webkit.org/show_bug.cgi?id=96718.
1227
1228         Reviewed by Dirk Pranke.
1229
1230         TestExpectations match an expectation's configuraton against a list of configurations that are 
1231         valid for that port.  That list does not contain mac-future so none of the expectations can be
1232         applied.
1233
1234         * Scripts/webkitpy/layout_tests/port/apple.py:
1235         (ApplePort._generate_all_test_configurations):
1236
1237 2012-09-14  Adam Barth  <abarth@webkit.org>
1238
1239         Remove webkitPostMessage
1240         https://bugs.webkit.org/show_bug.cgi?id=96577
1241
1242         Reviewed by Ojan Vafai.
1243
1244         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
1245
1246         * Scripts/webkitperl/FeatureList.pm:
1247         * qmake/mkspecs/features/features.pri:
1248
1249 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
1250
1251         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
1252         https://bugs.webkit.org/show_bug.cgi?id=96817
1253
1254         Reviewed by Kenneth Rohde Christiansen.
1255
1256         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1257         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
1258         got overlooked when adding logging elsewhere.
1259
1260 2012-09-14  Peter Beverloo  <peter@chromium.org>
1261
1262         [Chromium] Build fix for DumpRenderTree following r128628
1263         https://bugs.webkit.org/show_bug.cgi?id=96808
1264
1265         Reviewed by Tony Chang.
1266
1267         When building DumpRenderTree from the Chromium project, a compile error
1268         shows up because including the header ForwardIOStreamsAndroid.h cannot
1269         be located. TestWebKitAPI does this correctly.
1270
1271         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1272
1273 2012-09-14  Dana Jansens  <danakj@chromium.org>
1274
1275         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
1276         https://bugs.webkit.org/show_bug.cgi?id=96805
1277
1278         Reviewed by Dirk Pranke.
1279
1280         * Scripts/webkitpy/common/config/committers.py:
1281         * Scripts/webkitpy/common/config/watchlist:
1282
1283 2012-09-14  Peter Beverloo  <peter@chromium.org>
1284
1285         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
1286         https://bugs.webkit.org/show_bug.cgi?id=96687
1287
1288         Reviewed by Tony Chang.
1289
1290         Android's DumpRenderTree currently supports these arguments, implemented
1291         as part of TestShellAndroid:
1292         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
1293
1294         They're used by the layout test runner to get the STDOUT and STDERR while
1295         a layout test run is in process, which is a safer alternative to parsing
1296         all the logcat output manually. The implementation can be seen here:
1297         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
1298
1299         This patch generalizes parsing of and applying the effects of these arguments
1300         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
1301         After this patch, this will make it possible to pull out the output-reading
1302         code from Android's layout test port and generalize it so it can be re-used
1303         in the new test-runner for the other two test suites.
1304
1305         This has no effect when compiling and running these tests as part of Chromium
1306         code, which has a much more advanced test-runner that does parse complete log
1307         output, but also directly depends on code licensed under Apache 2.
1308
1309         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1310         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1311         (platformInit):
1312         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1313
1314 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
1315
1316         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
1317         https://bugs.webkit.org/show_bug.cgi?id=96656
1318
1319         Reviewed by Adam Barth.
1320
1321         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
1322         macros in 1 line.
1323
1324         * Scripts/webkitpy/style/checkers/cpp.py:
1325         (check_style.definitions):
1326         (check_style): Add rule.
1327         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1328         (WebKitStyleTest.test_line_breaking): Add unittest.
1329
1330 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1331
1332         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
1333         https://bugs.webkit.org/show_bug.cgi?id=57570
1334
1335         Reviewed by Kenneth Rohde Christiansen.
1336
1337         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
1338         and dump the information expected by the test cases.
1339
1340         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1341         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1342         (WTR::InjectedBundle::beginTesting): Explicitly set the default
1343         database quota.
1344         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1345         (WTR::securityOriginToStr): New convenience function to convert
1346         a security origin to the string expected in test results.
1347         (WTR):
1348         (WTR::InjectedBundlePage::InjectedBundlePage):
1349         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
1350         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
1351         refactoring to share code with didExceedDatabaseQuota.
1352         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1353         (InjectedBundlePage):
1354         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1355         (WTR::TestRunner::TestRunner):
1356         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1357         (WTR::TestRunner::dumpDatabaseCallbacks):
1358         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
1359         (TestRunner):
1360
1361 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1362
1363         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
1364
1365         Rubber-stamped by Simon Hausmann.
1366
1367         * qmake/mkspecs/features/default_post.prf:
1368
1369 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1370
1371         [Qt] Remove old cruft from the qmake build system
1372
1373         Rubber-stamped by Simon Hausmann.
1374
1375         * DumpRenderTree/qt/DumpRenderTree.pro:
1376         * qmake/mkspecs/features/default_post.prf:
1377
1378 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1379
1380         [Qt] Enable force_static_libs_as_shared for development
1381
1382         Not enabled for buildbots or production-builds (part of Qt5)
1383
1384         Reviewed by Simon Hausmann.
1385
1386         * qmake/mkspecs/features/default_post.prf:
1387
1388 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1389
1390         [Qt] Make force_static_libs_as_shared work on Mac OS
1391
1392         We had to move a few LIBS += around that were in the wrong place,
1393         and not caught when everything was just linked into the final
1394         QtWebKit library.
1395
1396         Reviewed by Simon Hausmann.
1397
1398         * qmake/mkspecs/features/default_post.prf:
1399         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
1400
1401 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
1402
1403         [Qt] Fix build of WTR on Windows
1404
1405         Reviewed by Tor Arne Vestbø.
1406
1407         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
1408         With qmake's unix makefile generator as well as with the MingW generator,
1409         the directory where the pro file lives (WTR/) is automatically added to
1410         the include search path, but not so with MSVC. Instead of relying on qmake's
1411         implicit feature here, add WTR/ explicitly to the include search path.
1412
1413         * WebKitTestRunner/Target.pri:
1414
1415 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1416
1417         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
1418         https://bugs.webkit.org/show_bug.cgi?id=42691
1419
1420         Reviewed by Kenneth Rohde Christiansen.
1421
1422         Add implementation for testrunner.setStopProvisionalFrameLoads()
1423         in WebKitTestRunner.
1424
1425         Original patch by Alexey Proskuryakov.
1426
1427         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1428         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1429         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1430         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1431         (WTR::TestRunner::TestRunner):
1432         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1433         (TestRunner):
1434         (WTR::TestRunner::setStopProvisionalFrameLoads):
1435         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
1436
1437 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1438
1439         [Qt] Fix handling of debug/release/debug_and_release/build_all
1440
1441         We now pick up the defaults from Qt, in default_pre (CONFIG already
1442         contains the appropriate values for debug and release). We then let
1443         the command line arguments to qmake, or the project files themselves,
1444         override the configuration, and finally we sanitize the configuration
1445         in default_post.
1446
1447         Reviewed by Simon Hausmann.
1448
1449         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1450         * Scripts/webkitdirs.pm:
1451         (buildQMakeProjects):
1452         * qmake/mkspecs/features/default_post.prf:
1453         * qmake/mkspecs/features/default_pre.prf:
1454         * qmake/mkspecs/features/mac/default_pre.prf:
1455
1456 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1457
1458         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
1459         https://bugs.webkit.org/show_bug.cgi?id=42687
1460
1461         Reviewed by Kenneth Rohde Christiansen.
1462
1463         Implement testRunner.setTabKeyCyclesThroughElements for
1464         WebKitTestRunner.
1465
1466         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1467         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1468         (WTR::InjectedBundle::beginTesting):
1469         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1470         (WTR::TestRunner::setTabKeyCyclesThroughElements):
1471         (WTR):
1472         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1473         (TestRunner):
1474
1475 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1476
1477         EventSendingController::keyDown does not support non-array modifier arguments
1478         https://bugs.webkit.org/show_bug.cgi?id=96727
1479
1480         Reviewed by Kenneth Rohde Christiansen.
1481
1482         Add support for handling a string as modifier argument to
1483         EventSendingController::keyDown.
1484
1485         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1486         (WTR::parseModifierArray):
1487
1488 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1489
1490         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
1491         https://bugs.webkit.org/show_bug.cgi?id=42546
1492
1493         Reviewed by Kenneth Rohde Christiansen.
1494
1495         Exported TestRunner::setCustomPolicyDelegate() method.
1496         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
1497
1498         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1499         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1500         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1501
1502 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
1503
1504         [GTK] Clear application cache between tests in DumpRenderTree
1505         https://bugs.webkit.org/show_bug.cgi?id=96543
1506
1507         Reviewed by Philippe Normand.
1508
1509         Call the new DumpRenderTreeSupportGtk method to clear application cache
1510         after each test in DumpRenderTree.
1511
1512         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1513         as well. It's now being set in XvfbDriver._start so that each driver is assigned
1514         a cache directory that's constructed out of the driver's name and its worker
1515         number. These directories are located in the layout tests results directory.
1516         At least on the builders this ensures a driver-specific empty cache directory
1517         with each test run.
1518
1519         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1520         (runTest):
1521         * Scripts/webkitpy/layout_tests/port/gtk.py:
1522         (GtkPort.setup_environ_for_server):
1523         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1524         (XvfbDriver._start):
1525
1526 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
1527
1528         [Qt] Fix linking on Windows
1529
1530         Reviewed by Tor Arne Vestbø.
1531
1532         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
1533         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
1534         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
1535         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
1536
1537         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
1538         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
1539         after the module. Therefore QT did never contain webkit anymore and we always passed
1540         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
1541
1542         This patch introduces a creating_module configuration that is used to
1543         scope the qt/pkgconfig sanitization.
1544
1545         * qmake/mkspecs/features/default_post.prf:
1546
1547 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
1548
1549         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
1550         https://bugs.webkit.org/show_bug.cgi?id=96740
1551
1552         Reviewed by Kenneth Rohde Christiansen.
1553
1554         Dump information expected by the test cases about the following
1555         frame load callbacks:
1556         "didDisplayInsecureContentForFrame"
1557         "didRunInsecureContentForFrame"
1558         "didDetectXSSForFrame"
1559
1560         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1561         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
1562         as expected by test results by calling pathSuitableForTestResult() instead
1563         of printing raw URL.
1564         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
1565         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
1566         (WTR::InjectedBundlePage::didDetectXSSForFrame):
1567
1568 2012-09-14  Peter Beverloo  <peter@chromium.org>
1569
1570         The runtime/unsigned category should be valid in the cpp style-checker.
1571         https://bugs.webkit.org/show_bug.cgi?id=96748
1572
1573         Reviewed by Csaba Osztrogonác.
1574
1575         This is causing the webkitpy tests to fail because it's not listed in the
1576         category array. Furthermore, change an "int" to "long" because it's
1577         throwing a double error in one of the earlier asserts.
1578
1579         * Scripts/webkitpy/style/checkers/cpp.py:
1580         (CppChecker):
1581         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1582         (WebKitStyleTest.test_names):
1583
1584 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1585
1586         Evas_Object* is a ref'ed structure, so tread it as such
1587         https://bugs.webkit.org/show_bug.cgi?id=96659
1588
1589         Reviewed by Adam Barth.
1590
1591         Replace OwnPtr<Evas_Object> with RefPtr.
1592
1593         * DumpRenderTree/efl/ImageDiff.cpp:
1594         (calculateDifference):
1595         (printImageDifferences):
1596         (readImageFromStdin):
1597         (main):
1598
1599 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1600
1601         Unreviewed, rolling out r128507.
1602         http://trac.webkit.org/changeset/128507
1603         https://bugs.webkit.org/show_bug.cgi?id=96659
1604
1605         Revert. r128507 makes too many crashes in EFL layout test bots.
1606
1607         * DumpRenderTree/efl/ImageDiff.cpp:
1608         (calculateDifference):
1609         (printImageDifferences):
1610         (readImageFromStdin):
1611         (main):
1612
1613 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
1614
1615         Make compile with both OS(WINCE) and PLATFORM(QT) support
1616         https://bugs.webkit.org/show_bug.cgi?id=95536
1617
1618         Reviewed by Simon Hausmann.
1619
1620         Fix wince support in qmake files
1621
1622         * Tools.pro:
1623         * qmake/mkspecs/features/configure.prf:
1624         * qmake/mkspecs/features/default_post.prf:
1625         * qmake/mkspecs/features/features.prf:
1626         * qmake/mkspecs/features/functions.prf:
1627
1628 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
1629
1630         [WK2] Add color picker API support for WebKit2
1631         https://bugs.webkit.org/show_bug.cgi?id=95058
1632
1633         Reviewed by Gyuyoung Kim.
1634
1635         Initialization code for color picker callbacks in UI client.
1636
1637         * MiniBrowser/mac/BrowserWindowController.m:
1638         (-[BrowserWindowController awakeFromNib]):
1639         * MiniBrowser/win/BrowserView.cpp:
1640         (BrowserView::create):
1641         * WebKitTestRunner/TestController.cpp:
1642         (WTR::TestController::createOtherPage):
1643         (WTR::TestController::initialize):
1644
1645 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
1646
1647         Upgrade yutak to reviewer
1648         https://bugs.webkit.org/show_bug.cgi?id=96721
1649
1650         Reviewed by Kent Tamura.
1651
1652         * Scripts/webkitpy/common/config/committers.py:
1653
1654 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1655
1656         Make the style checker report usage of "unsigned int"
1657         https://bugs.webkit.org/show_bug.cgi?id=96693
1658
1659         Reviewed by Dirk Pranke.
1660
1661         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
1662
1663         * Scripts/webkitpy/style/checkers/cpp.py:
1664         (check_language):
1665
1666 2012-09-13  Philip Rogers  <pdr@google.com>
1667
1668         Add gender-neutral form of webkit-patch land-cowboy
1669         https://bugs.webkit.org/show_bug.cgi?id=96709
1670
1671         Reviewed by Adam Barth.
1672
1673         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
1674
1675         * Scripts/webkitpy/tool/commands/download.py:
1676         (LandCowhand):
1677
1678 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
1679
1680         [EFL] Remove some parameters in browserCreate()
1681         https://bugs.webkit.org/show_bug.cgi?id=96499
1682
1683         Reviewed by Kenneth Rohde Christiansen.
1684
1685         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
1686         And I have moved some parameters into User_Arguments.
1687
1688         * EWebLauncher/main.c:
1689         (_User_Arguments):
1690         (_ELauncher):
1691         (on_key_down):
1692         (browserCreate):
1693         (findThemePath):
1694         (parseUserArguments):
1695         (main):
1696
1697 2012-09-13  Mark Lam  <mark.lam@apple.com>
1698
1699         Unreviewed. Adding myself to the committers list.
1700
1701         * Scripts/webkitpy/common/config/committers.py:
1702
1703 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1704
1705         run-perf-tests output cryptic error when the config file is missing.
1706         https://bugs.webkit.org/show_bug.cgi?id=96453
1707
1708         Reviewed by Tony Chang.
1709
1710         Add a special error message when a configuration file is missing.
1711
1712         Also update the help message of --source-json-path to signify the fact it specifies
1713         the configuration file on performance tests bots.
1714
1715         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1716         (PerfTestsRunner._parse_args):
1717         (PerfTestsRunner._generate_and_show_results):
1718         (PerfTestsRunner._merge_slave_config_json):
1719         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1720         (_test_run_with_json_output): Make upload to fail by default and assert the result
1721         in the function so that we can return logs instead.
1722         (_test_run_with_json_output.mock_upload_json):
1723         (test_run_with_json_output):
1724         (test_run_with_description):
1725         (test_run_respects_no_results):
1726         (test_run_with_slave_config_json):
1727         (test_run_with_bad_slave_config_json):
1728         (test_run_with_multiple_repositories):
1729
1730 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1731
1732         Evas_Object* is a ref'ed structure, so tread it as such
1733         https://bugs.webkit.org/show_bug.cgi?id=96659
1734
1735         Reviewed by Adam Barth.
1736
1737         Replace OwnPtr<Evas_Object> with RefPtr.
1738
1739         * DumpRenderTree/efl/ImageDiff.cpp:
1740         (calculateDifference):
1741         (printImageDifferences):
1742         (readImageFromStdin):
1743         (main):
1744
1745 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1746
1747         One more unreviewed trivial fix after r128399.
1748
1749         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
1750
1751 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1752
1753         Unreviewed trivial fix after r128399.
1754
1755         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
1756         (getLatestSVNRevision):
1757         (waitForSVNRevision):
1758
1759 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1760
1761         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
1762         https://bugs.webkit.org/show_bug.cgi?id=96366
1763
1764         Reviewed by Anders Carlsson.
1765
1766         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
1767         by calling shouldClose() on the FrameLoader.
1768
1769         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1770         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1771         (WTR::TestRunner::callShouldCloseOnWebView):
1772         (WTR):
1773         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1774         (TestRunner):
1775
1776 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1777
1778         Unreviewed, rolling out r128453.
1779         http://trac.webkit.org/changeset/128453
1780         https://bugs.webkit.org/show_bug.cgi?id=96681
1781
1782         Having tests use the same appcache directory leads to timeouts
1783         (Requested by zdobersek on #webkit).
1784
1785         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1786         (runTest):
1787         * Scripts/webkitpy/layout_tests/port/gtk.py:
1788         (GtkPort.setup_environ_for_server):
1789
1790 2012-09-13  James Robinson  <jamesr@chromium.org>
1791
1792         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
1793         https://bugs.webkit.org/show_bug.cgi?id=96678
1794
1795         Reviewed by Dirk Pranke.
1796
1797         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1798         (.):
1799
1800 2012-09-13  Rob Buis  <rbuis@rim.com>
1801
1802         Unreviewed changes to watchlist.
1803
1804         - Add myself to BlackBerry bugs
1805
1806         * Scripts/webkitpy/common/config/watchlist:
1807
1808 2012-09-13  Stephen Chenney  <schenney@chromium.org>
1809
1810         Add an SVG entry to the watchlist
1811
1812         Unreviewed config change.
1813
1814         * Scripts/webkitpy/common/config/watchlist:
1815         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
1816         - Added myself and pdr as watchers
1817
1818 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1819
1820         [Qt] Make WebKit2 work on Windows with Qt 5
1821         https://bugs.webkit.org/show_bug.cgi?id=76776
1822
1823         Reviewed by Tor Arne Vestbø.
1824
1825         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
1826         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
1827         that for the GL TextureMapper (it's only built when that feature is set).
1828
1829         * qmake/mkspecs/features/configure.prf:
1830
1831 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1832
1833         [Qt] Ensure that QT is finalized before loading qt_module.prf
1834
1835         As qt_module.prf does dependency tracking based on the content of the
1836         QT variable. The intermediate WebKit modules modify the variable in
1837         their .pri files, so we have to ensure we've loaded all the modules
1838         before loading qt_module.
1839
1840         Reviewed by Tor Arne Vestbø.
1841         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
1842
1843         * qmake/mkspecs/features/default_post.prf:
1844         * qmake/mkspecs/features/webkit_modules.prf: Added.
1845
1846 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1847
1848         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
1849         https://bugs.webkit.org/show_bug.cgi?id=96633
1850
1851         Reviewed by Csaba Osztrogonác.
1852
1853         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
1854         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
1855         It's the usual problem and the usual solution is to rename one of the conflicting files.
1856         This patch chooses to rename DRT instead of WTR and MBR.
1857
1858         Fixed include order at the same time to match style guide.
1859
1860         * DumpRenderTree/qt/DumpRenderTree.pro:
1861         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
1862         (messageHandler):
1863         (isOption):
1864         (takeOptionValue):
1865         (printUsage):
1866         (main):
1867
1868 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1869
1870         The Script run-launcher should support -2 in combination with --efl
1871         https://bugs.webkit.org/show_bug.cgi?id=96639
1872
1873         Reviewed by Simon Hausmann.
1874
1875         Support running the MiniBrowser then supplied -2 as argument.
1876
1877         * Scripts/run-launcher:
1878
1879 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1880
1881         Unreviewed, add my Intel email address to the list.
1882
1883         * Scripts/webkitpy/common/config/committers.py:
1884
1885 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1886
1887         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
1888
1889         Reviewed by Ossy.
1890
1891         * qmake/mkspecs/features/default_post.prf:
1892
1893 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1894
1895         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
1896         https://bugs.webkit.org/show_bug.cgi?id=82294
1897
1898         Reviewed by Gyuyoung Kim.
1899
1900         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
1901
1902         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1903         (TestRunner::layerTreeAsText):
1904
1905 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1906
1907         [GTK] Clear application cache between tests in DumpRenderTree
1908         https://bugs.webkit.org/show_bug.cgi?id=96543
1909
1910         Reviewed by Philippe Normand.
1911
1912         Call the new DumpRenderTreeSupportGtk method to clear application cache
1913         after each test.
1914
1915         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1916         as well. Currently it points to a subdirectory in the layout tests results
1917         directory. At least on the builders this ensures an empty cache directory
1918         with each test run.
1919
1920         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1921         (runTest):
1922         * Scripts/webkitpy/layout_tests/port/gtk.py:
1923         (GtkPort.setup_environ_for_server):
1924
1925 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1926
1927         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
1928
1929         Unless it's actually a dependency of the public QtWebKit API.
1930
1931         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
1932         files with their _PRIVATE equivivalent, but that's likely to break when
1933         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
1934         clean up the variables in default_post.
1935
1936         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
1937         longer needed, as it was a workaround for the intermediate libraries ending
1938         up in the prl file. And, since CONFIG -= staticlib was there to support
1939         the explicitlib option, we can remove that too (as well as the exception
1940         for gprof, since it would be empty). If gprof needs tweaks to always link
1941         statically they should go in gprof.prf.
1942
1943         Reviewed by Simon Hausmann.
1944
1945         * qmake/mkspecs/features/default_post.prf:
1946         * qmake/mkspecs/features/functions.prf:
1947
1948 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
1949
1950         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
1951         https://bugs.webkit.org/show_bug.cgi?id=96632
1952
1953         Reviewed by Carlos Garcia Campos.
1954
1955         Fix this by using atk_object_get_n_accessible_children instead of
1956         calling getChildren() from childCount.
1957
1958         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
1959         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
1960         loop by using atk_object_get_n_accessible_children().
1961
1962 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1963
1964         [Qt][Win] Enable USE(3D_GRAPHICS)
1965         https://bugs.webkit.org/show_bug.cgi?id=90879
1966
1967         Reviewed by Kenneth Rohde Christiansen.
1968
1969         Enable it on Windows as well as on QNX (bug fixed).
1970
1971         * qmake/mkspecs/features/features.prf:
1972
1973 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1974
1975         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
1976         https://bugs.webkit.org/show_bug.cgi?id=96359
1977
1978         Reviewed by Tor Arne Vestbø.
1979
1980         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
1981         lexer. The only viable alternative I could find on Windows that provides
1982         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
1983         so let's use that one instead.
1984
1985         * Scripts/webkitdirs.pm:
1986         (checkRequiredSystemConfig):
1987         * qmake/mkspecs/features/default_pre.prf:
1988
1989 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1990
1991         [Qt] Add configuration for production builds
1992         https://bugs.webkit.org/show_bug.cgi?id=96607
1993
1994         Reviewed by Kenneth Rohde Christiansen.
1995
1996         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
1997         and enable all-in-one-files optimizations.
1998
1999         * qmake/mkspecs/features/production_build.prf: Added.
2000
2001 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
2002
2003         [Qt] GStreamer detection does not work when cross-compiling
2004         https://bugs.webkit.org/show_bug.cgi?id=96608
2005
2006         Reviewed by Kenneth Rohde Christiansen.
2007
2008         When cross-compiling it is not safe to just use system(pkg-config),
2009         because there is a high probability that it will find packages in the
2010         host system instead of in the target one. Instead use qmake's new
2011         packagesExist() function that takes care of this delicate aspect of
2012         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
2013         PKG_CONFIG_LIBDIR accordingly.
2014
2015         * qmake/mkspecs/features/features.prf:
2016
2017 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
2018
2019         [WK2][WTR] More efficient string handling in InjectedBundlePage
2020         https://bugs.webkit.org/show_bug.cgi?id=96609
2021
2022         Reviewed by Kenneth Rohde Christiansen.
2023
2024         Update StringBuilder usage in InjectedBundlePage to follow
2025         the latest recommandations for efficient string handling:
2026         http://trac.webkit.org/wiki/EfficientStrings
2027
2028         This involves using appendLiteral() or appendNumber()
2029         instead of append() whenever possible.
2030
2031         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2032         (WTR::dumpPath):
2033         (WTR::rangeToStr):
2034         (WTR::styleDecToStr):
2035         (WTR::frameToStr):
2036         (WTR::dumpResourceURL):
2037         (WTR):
2038         (WTR::dumpFrameDescriptionSuitableForTestResult):
2039         (WTR::dumpRequestDescriptionSuitableForTestResult):
2040         (WTR::dumpResponseDescriptionSuitableForTestResult):
2041         (WTR::dumpErrorDescriptionSuitableForTestResult):
2042         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
2043         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
2044         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2045         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2046         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2047         (WTR::InjectedBundlePage::didFinishProgress):
2048         (WTR::dumpFrameScrollPosition):
2049         (WTR::dumpFrameText):
2050         (WTR::dumpDescendantFramesText):
2051         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2052         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2053         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
2054         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
2055         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2056         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
2057         (WTR::InjectedBundlePage::willSendRequestForFrame):
2058         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2059         (WTR::InjectedBundlePage::didFinishLoadForResource):
2060         (WTR::InjectedBundlePage::didFailLoadForResource):
2061         (WTR::InjectedBundlePage::shouldCacheResponse):
2062         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2063         (WTR::InjectedBundlePage::willAddMessageToConsole):
2064         (WTR::InjectedBundlePage::willSetStatusbarText):
2065         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2066         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2067         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
2068         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2069         (WTR::InjectedBundlePage::shouldBeginEditing):
2070         (WTR::InjectedBundlePage::shouldEndEditing):
2071         (WTR::InjectedBundlePage::shouldInsertNode):
2072         (WTR::InjectedBundlePage::shouldInsertText):
2073         (WTR::InjectedBundlePage::shouldDeleteRange):
2074         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2075         (WTR::InjectedBundlePage::shouldApplyStyle):
2076         (WTR::InjectedBundlePage::didBeginEditing):
2077         (WTR::InjectedBundlePage::didEndEditing):
2078         (WTR::InjectedBundlePage::didChange):
2079         (WTR::InjectedBundlePage::didChangeSelection):
2080         (WTR::InjectedBundlePage::supportsFullScreen):
2081         (WTR::InjectedBundlePage::enterFullScreenForElement):
2082         (WTR::InjectedBundlePage::exitFullScreenForElement):
2083         (WTR::InjectedBundlePage::beganEnterFullScreen):
2084         (WTR::InjectedBundlePage::beganExitFullScreen):
2085         (WTR::InjectedBundlePage::closeFullScreen):
2086         (WTR::dumpBackForwardListItem):
2087         (WTR::InjectedBundlePage::dumpBackForwardList):
2088
2089 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2090
2091         [Qt][WK2] Memory leaks in Qt's TestRunner
2092         https://bugs.webkit.org/show_bug.cgi?id=96603
2093
2094         Reviewed by Csaba Osztrogonác.
2095
2096         Fix memory leaks in Qt's TestRunner code by adopting WKString
2097         created with WKStringCreateWithUTF8CString().
2098
2099         * WebKitTestRunner/qt/TestControllerQt.cpp:
2100         (WTR::TestController::initializeInjectedBundlePath):
2101         (WTR::TestController::initializeTestPluginDirectory):
2102
2103 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
2104
2105         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
2106         https://bugs.webkit.org/show_bug.cgi?id=96506
2107
2108         Reviewed by Dirk Pranke.
2109
2110         Lower the timeout value to 6 seconds for release configuration and 12 seconds
2111         for debug configuration. These are the same values the Chromium port uses.
2112
2113         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
2114         the layout tests under WebKit2 generally) requires more attention and gardening
2115         than what the current effort produces.
2116
2117         The unit test is updated as well to test these changes.
2118
2119         * Scripts/webkitpy/layout_tests/port/gtk.py:
2120         (GtkPort.default_timeout_ms):
2121         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2122         (GtkPortTest.test_default_timeout_ms):
2123         (GtkPortTest.assertLinesEqual):
2124
2125 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
2126
2127         Add SVN mirror handling feature to build.webkit.org
2128         https://bugs.webkit.org/show_bug.cgi?id=85887
2129
2130         Reviewed by Dirk Pranke.
2131
2132         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
2133         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2134         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
2135         (ConfigureBuild.start):
2136         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
2137         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
2138         (Factory.__init__):
2139         (BuildFactory.__init__):
2140         (TestFactory.__init__):
2141         (BuildAndTestFactory.__init__):
2142         (BuildAndPerfTestFactory.__init__):
2143         (BuildAndPerfTestWebKit2Factory.__init__):
2144         (DownloadAndPerfTestFactory.__init__):
2145         (DownloadAndPerfTestWebKit2Factory.__init__):
2146         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
2147         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2148         (SVNMirrorTest):
2149         (SVNMirrorTest.setUp): Load config.json once at startup.
2150         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
2151         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
2152         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
2153         (getLatestSVNRevision): Get the latest SVN revison from the given server.
2154         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
2155                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
2156
2157 2012-09-12  Kangil Han  <kangil.han@samsung.com>
2158
2159         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
2160         https://bugs.webkit.org/show_bug.cgi?id=81606
2161
2162         Reviewed by Tim Horton.
2163
2164         6 seconds is harsh for some jquery test cases.
2165         Therefore, adjust the value to match DumpRenderTree.
2166
2167         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2168         (WTR):
2169
2170 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
2171
2172         [EFL] Support download attribute feature
2173         https://bugs.webkit.org/show_bug.cgi?id=96462
2174
2175         Reviewed by Gyuyoung Kim.
2176
2177         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
2178         and add "download,request" callback to the DumpRenderTree for EFL.
2179
2180         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2181         (DumpRenderTreeChrome::createView):
2182         (DumpRenderTreeChrome::onDownloadRequest):
2183         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2184         (DumpRenderTreeChrome):
2185         * Scripts/webkitperl/FeatureList.pm:
2186
2187 2012-09-12  Stephanie Lewis  <slewis@apple.com>
2188
2189         Reduce parallism on the wk2 testers.
2190         https://bugs.webkit.org/show_bug.cgi?id=95906
2191
2192         Reviewed by Dirk Pranke.
2193
2194         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
2195         resource contention.  Reducing the number of processes alleviates the issue.  
2196
2197         Starting by reducing 25%.
2198
2199         * Scripts/webkitpy/layout_tests/port/mac.py:
2200         (MacPort.default_child_processes):
2201
2202 2012-09-12  Brady Eidson  <beidson@apple.com>
2203
2204         Assert in NetscapePlugin::destroy() with async plugin init
2205         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
2206
2207         Reviewed by Anders Carlsson.
2208
2209         Expose NPN_Invoke to plug-in tests:
2210         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2211         (PluginTest::NPN_Invoke):
2212         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2213         (PluginTest):
2214
2215         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
2216         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
2217         (InvokeDestroysPluginWithinNPP_New):
2218         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
2219         (InvokeDestroysPluginWithinNPP_New::NPP_New):
2220         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2221
2222 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2223
2224         refactor TestExpectations tokenization slightly in preparation for the new syntax
2225         https://bugs.webkit.org/show_bug.cgi?id=96564
2226
2227         Reviewed by Ojan Vafai.
2228
2229         This change changes how we will tokenize/lex the
2230         TestExpectations files, in preparation for supporting both the
2231         old syntax and the new one. This change by itself should be a
2232         no-op.
2233
2234         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2235         (TestExpectationParser._tokenize_line):
2236         (TestExpectationParser):
2237         (TestExpectationParser._tokenize_line_using_old_format):
2238         (TestExpectationParser._tokenize_line_using_new_format):
2239
2240 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2241
2242         remove unused testexpectations editing code from webkitpy, garden-o-matic
2243         https://bugs.webkit.org/show_bug.cgi?id=96562
2244
2245         Reviewed by Adam Barth.
2246
2247         This code was prototyped but never fully realized. Removing
2248         until it reanimates :).
2249
2250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2252         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
2253         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
2254         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2255         (BuildCoverageExtrapolator.extrapolate_test_configurations):
2256         (GardeningHTTPRequestHandler._run_webkit_patch):
2257         (GardeningHTTPRequestHandler.ping):
2258         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2259         (BuildCoverageExtrapolatorTest.test_extrapolate):
2260         (GardeningServerTest.test_rebaseline_new_port):
2261
2262 2012-09-12  Lucas Forschler  <lforschler@apple.com>
2263
2264         Remove unused bot, apple-xserve-1.
2265         https://bugs.webkit.org/show_bug.cgi?id=96570
2266         
2267         Reviewed by Stephanie Lewis.
2268
2269         * BuildSlaveSupport/build.webkit.org-config/config.json:
2270
2271 2012-09-12  Xan Lopez  <xlopez@igalia.com>
2272
2273         [GTK] We attempt to rebase documentation even if it's not present
2274         https://bugs.webkit.org/show_bug.cgi?id=96553
2275
2276         Reviewed by Martin Robinson.
2277
2278         Do not make the documentation rebase step fatal. This allows make
2279         install to succeed when there's no documentation generated.
2280
2281         * gtk/generate-gtkdoc:
2282
2283 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2284
2285         Respect WEBKITOUTPUTDIR when running EFL tests
2286         https://bugs.webkit.org/show_bug.cgi?id=96528
2287
2288         Reviewed by Dirk Pranke.
2289
2290         Expose user set WEBKITOUTPUTDIR to the web process.
2291
2292         * Scripts/webkitpy/layout_tests/port/driver.py:
2293         (Driver._start): Add WEBKITOUTPUTDIR to the environment
2294         of the web process and its potential jhbuild wrapper.
2295
2296 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
2297
2298         webkitdirs: fix uname version handling for cygwin
2299         https://bugs.webkit.org/show_bug.cgi?id=96436
2300
2301         Reviewed by Jon Honeycutt.
2302
2303         Newer versions of cygwin embed an additional version string
2304         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
2305         Update the code to handle that.
2306
2307         * Scripts/webkitdirs.pm:
2308         (setupAppleWinEnv):
2309
2310 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2311
2312         Regression(r128338): Broke Windows build
2313         https://bugs.webkit.org/show_bug.cgi?id=96537
2314
2315         Unreviewed build fix.
2316
2317         Fix Apple-Win build by allocating array dynamically
2318         since its size is not constant.
2319
2320         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2321         (WTR::stringArrayToJS):
2322
2323 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
2324
2325         [chromium] Add a virtual test suite for fast/hidpi
2326         https://bugs.webkit.org/show_bug.cgi?id=90192
2327
2328         Reviewed by Dirk Pranke.
2329
2330         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
2331         on the hardware accelerated path as the software path.
2332
2333         * DumpRenderTree/chromium/WebPreferences.cpp:
2334         (WebPreferences::applyTo):
2335         * Scripts/webkitpy/layout_tests/port/chromium.py:
2336         (ChromiumPort.virtual_test_suites):
2337
2338 2012-09-12  Adam Klein  <adamk@chromium.org>
2339
2340         [chromium] Add content_browsertests to the flakiness dashboard
2341         https://bugs.webkit.org/show_bug.cgi?id=96535
2342
2343         Reviewed by Ojan Vafai.
2344
2345         * TestResultServer/static-dashboards/dashboard_base.js:
2346
2347 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2348
2349         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
2350         https://bugs.webkit.org/show_bug.cgi?id=96496
2351
2352         Reviewed by Kenneth Rohde Christiansen.
2353
2354         Add implementation for originsWithApplicationCache to
2355         WebKitTestRunner.
2356
2357         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2358         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2359         (WTR::stringArrayToJS):
2360         (WTR):
2361         (WTR::TestRunner::originsWithApplicationCache):
2362         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2363         (TestRunner):
2364
2365 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2366
2367         Fix Qt/Windows build with Python3
2368         https://bugs.webkit.org/show_bug.cgi?id=96473
2369
2370         Reviewed by Csaba Osztrogonác.
2371
2372         In Python 3 print is a real function, so we must use parentheses around
2373         the function parameters. This is backwards compatible with Python 2.
2374
2375         * Scripts/generate-win32-export-forwards:
2376
2377 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2378
2379         Unreviewed trivial build fix for Qt/Windows after bug #96358.
2380
2381         As pointed out by Kevin, we should inject the "set PATH=..." statement
2382         to add the GnuWin32 directory only if that directory actually exists.
2383
2384         * qmake/mkspecs/features/default_post.prf:
2385
2386 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2387
2388         [EFL] [WK2] Memory leaks in TestControllerEfl
2389         https://bugs.webkit.org/show_bug.cgi?id=96525
2390
2391         Reviewed by Kenneth Rohde Christiansen.
2392
2393         Fix memory leaks in EFL's TestRunner code by adopting an allocation
2394         of WKString created with WKStringCreateWithUTF8CString().
2395
2396         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2397         (WTR::TestController::initializeInjectedBundlePath):
2398         (WTR::TestController::initializeTestPluginDirectory):
2399
2400 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2401
2402         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
2403         https://bugs.webkit.org/show_bug.cgi?id=96374
2404
2405         Reviewed by Kenneth Rohde Christiansen.
2406
2407         Implement support for dumpApplicationCacheDelegateCallbacks
2408         and disallowIncreaseForApplicationCacheQuota in
2409         WebKitTestRunner and properly dump the information
2410         expected by the tests.
2411
2412         If the application cache quota is reached for a given
2413         security origin, WebKitTestRunner will reset the quota
2414         to its default value, unless intructed not to via
2415         disallowIncreaseForApplicationCacheQuota().
2416
2417         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2418         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2419         (WTR::InjectedBundlePage::InjectedBundlePage):
2420         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2421         (WTR):
2422         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2423         (InjectedBundlePage):
2424         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2425         (WTR::TestRunner::TestRunner):
2426         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2427         (WTR):
2428         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2429         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2430         (TestRunner):
2431         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2432         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2433
2434 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2435
2436         [chromium] remove deprecated and unused sets import from chromium_android driver
2437         https://bugs.webkit.org/show_bug.cgi?id=96485
2438
2439         Reviewed by Dirk Pranke.
2440
2441         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2442
2443 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
2444
2445         Flakiness dashboard doesn't recognize new Chromium Android test builder
2446         https://bugs.webkit.org/show_bug.cgi?id=96523
2447
2448         Reviewed by Ojan Vafai.
2449
2450         Properly return 'ANDROID' as the Chromium platform for Android builders.
2451
2452         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2453         (chromiumPlatform):
2454         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2455         (test):
2456
2457 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2458
2459         [Qt] Build on Windows requires bison/flex in PATH
2460         https://bugs.webkit.org/show_bug.cgi?id=96358
2461
2462         Reviewed by Tor Arne Vestbø.
2463
2464         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
2465         and Linux that is rarely a problem given how easily available the tools are. On Windows however
2466         a separate installation of various GNU tools is required as the operating system doesn't come with
2467         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
2468         the gnuwin32 directory of the qt5.git top-level repository.
2469
2470         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
2471
2472         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
2473         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
2474         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
2475         updated with the new tool.
2476
2477         * Scripts/webkitdirs.pm:
2478         (checkRequiredSystemConfig):
2479         * qmake/mkspecs/features/default_post.prf:
2480
2481 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2482
2483         [Qt] Update build-jsc after r128174
2484
2485         Reviewed by Ossy.
2486
2487         * Scripts/build-jsc:
2488
2489 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2490
2491         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
2492
2493         By hard-coding the names of the targets we defined we ended up just
2494         redefining the previous target when using addStrictSubdirOrderBetween
2495         more than once in a single project file.
2496
2497         We now embed the two base targets into the target names.
2498
2499         Reviewed by Simon Hausmann.
2500
2501         * qmake/mkspecs/features/functions.prf:
2502
2503 2012-09-12  Philippe Liard  <pliard@google.com>
2504
2505         Depend on {base,net} GYP targets rather than {base,net}_java.
2506         https://bugs.webkit.org/show_bug.cgi?id=95690
2507
2508         Reviewed by Adam Barth.
2509
2510         {base,net}_java became 'private' targets on the Chromium side that
2511         clients should not depend on (see
2512         https://chromiumcodereview.appspot.com/10913083/).
2513         This removes a bunch of trailing white spaces additionally in
2514         TestWebkitAPI.gyp (which includes non-trailing white space changes).
2515
2516         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2517         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2518
2519 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2520
2521         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
2522         https://bugs.webkit.org/show_bug.cgi?id=96494
2523
2524         Reviewed by Tor Arne Vestbø.
2525
2526         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
2527         plugin process feature if we don't have NPAPI.
2528
2529         * qmake/mkspecs/features/features.prf:
2530
2531 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2532
2533         Unreviewed, rolling out r128280.
2534         http://trac.webkit.org/changeset/128280
2535         https://bugs.webkit.org/show_bug.cgi?id=96498
2536
2537         it broke compilation on windows debug bot (Requested by loislo
2538         on #webkit).
2539
2540         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2541         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2542         (WTR::InjectedBundlePage::InjectedBundlePage):
2543         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2544         (InjectedBundlePage):
2545         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2546         (WTR::TestRunner::TestRunner):
2547         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2548         (TestRunner):
2549
2550 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
2551
2552         [Qt] Make it possible to build with "make release" and "make debug" on Windows
2553         https://bugs.webkit.org/show_bug.cgi?id=96488
2554
2555         Reviewed by Tor Arne Vestbø.
2556
2557         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
2558         because there are no such targets. We want the generated sources to be independent from release
2559         or debug build configurations, so it is sufficient to provide fake debug and release targets that
2560         redirect to the same general-purpose target (first) of creating the derived sources.
2561
2562         * qmake/mkspecs/features/default_post.prf:
2563
2564 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2565
2566         [EFL] Make DumpRenderTree smarter at finding the fonts
2567         http://webkit.org/b/96281
2568
2569         Reviewed by Gyuyoung Kim.
2570
2571         Respect WEBKITOUTPUTDIR and expand the font dir from it.
2572         Use CString consistently.
2573
2574         * DumpRenderTree/efl/FontManagement.cpp:
2575         (buildPath):
2576         (getCoreFontFiles):
2577         (addFontDirectory):
2578         (addFontFiles):
2579         (getCustomBuildDir):
2580         (getPlatformFontsPath):
2581         (addFontsToEnvironment):
2582
2583 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2584
2585         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
2586         https://bugs.webkit.org/show_bug.cgi?id=96374
2587
2588         Reviewed by Kenneth Rohde Christiansen.
2589
2590         Implement support for dumpApplicationCacheDelegateCallbacks
2591         and disallowIncreaseForApplicationCacheQuota in
2592         WebKitTestRunner and properly dump the information
2593         expected by the tests.
2594
2595         If the application cache quota is reached for a given
2596         security origin, WebKitTestRunner will reset the quota
2597         to its default value, unless intructed not to via
2598         disallowIncreaseForApplicationCacheQuota().
2599
2600         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2601         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2602         (WTR::InjectedBundlePage::InjectedBundlePage):
2603         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2604         (WTR):
2605         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2606         (InjectedBundlePage):
2607         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2608         (WTR::TestRunner::TestRunner):
2609         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2610         (WTR):
2611         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2612         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2613         (TestRunner):
2614         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2615         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2616
2617 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2618
2619         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
2620         https://bugs.webkit.org/show_bug.cgi?id=96388
2621
2622         Reviewed by Kenneth Rohde Christiansen.
2623
2624         Exported TestRunner.workerThreadCount as readonly attribute.
2625
2626         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2627         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
2628         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
2629         (WTR):
2630         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
2631         (TestRunner):
2632
2633 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2634
2635         [chromium] Consume a user gesture when creating a new view.
2636         https://bugs.webkit.org/show_bug.cgi?id=96373
2637
2638         Reviewed by Adam Barth.
2639
2640         * DumpRenderTree/chromium/WebViewHost.cpp:
2641         (WebViewHost::createView):
2642
2643 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2644
2645         [WK2][WTR] Some of TestRunner special options are not reset before testing
2646         https://bugs.webkit.org/show_bug.cgi?id=96384
2647
2648         Reviewed by Kenneth Rohde Christiansen.
2649
2650         Now values of the following special options are reset:
2651         void setAcceptsEditing(in boolean value);
2652         void setCloseRemainingWindowsWhenComplete(in boolean value);
2653         void setXSSAuditorEnabled(in boolean value);
2654         void setAllowFileAccessFromFileURLs(in boolean value);
2655         void setPluginsEnabled(in boolean value);
2656         void setPopupBlockingEnabled(in boolean value);
2657
2658         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2659         (WTR::InjectedBundle::beginTesting):
2660
2661 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
2662
2663         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
2664         https://bugs.webkit.org/show_bug.cgi?id=96273
2665
2666         Reviewed by Gyuyoung Kim.
2667
2668         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
2669         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
2670
2671         * WebKitTestRunner/CMakeLists.txt:
2672
2673 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
2674
2675         [chromium] rename webkit_resources
2676         https://bugs.webkit.org/show_bug.cgi?id=95874
2677
2678         Reviewed by James Robinson.
2679
2680         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2681
2682 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
2683
2684         [chromium] don't include content shell builders in the garden-o-matic view
2685         https://bugs.webkit.org/show_bug.cgi?id=96418
2686
2687         Reviewed by James Robinson.
2688
2689         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2690
2691 2012-09-11  Adam Klein  <adamk@chromium.org>
2692
2693         Garden-o-matic should ignore a wider variety of warnings in buildbot json
2694         https://bugs.webkit.org/show_bug.cgi?id=96411
2695
2696         Reviewed by Adam Barth.
2697
2698         Previously only the exact string "warning" was treated as a warning
2699         result. This patch treats any string with "warning" as a substring
2700         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
2701
2702         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2703         (.):
2704         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2705
2706 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
2707
2708         Restore original value of mock scrollbars enabled in InternalSettings
2709         https://bugs.webkit.org/show_bug.cgi?id=87680
2710
2711         Reviewed by Adam Barth.
2712
2713         Added backup support for mock scrollbars state in
2714         InternalSettings::Backup, and removed support for these
2715         from Qt's DumpRenderTree.
2716
2717         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2718         (WebCore::WebPage::resetSettings):
2719         * DumpRenderTree/qt/TestRunnerQt.cpp:
2720         (TestRunner::setFrameFlatteningEnabled):
2721         * DumpRenderTree/qt/TestRunnerQt.h:
2722         (TestRunner):
2723
2724 2012-09-11  Dan Bernstein  <mitz@apple.com>
2725
2726         Fixed a bug where kill-old-processes failed to kill clang++.
2727
2728         Rubber-stamped by Alexey Proskuryakov.
2729
2730         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
2731         where it is passed as a regular expression to killall.
2732
2733 2012-09-11  Philippe Liard  <pliard@google.com>
2734
2735         Make sure that md5sum is not setup on non-Chromium Android platforms.
2736         https://bugs.webkit.org/show_bug.cgi?id=96393
2737
2738         Reviewed by Adam Barth.
2739
2740         Previously md5sum was setup in ChromiumAndroidDriver's constructor
2741         which is also invoked on non-Chromium Android platforms. The following patch
2742         moves this logic to _startup_test() which is guaranteed to be invoked
2743         only on Android.
2744
2745         This also updates the prompt unit test in chromium_android_unittest.py.
2746
2747         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2748         (ChromiumAndroidDriver.__init__):
2749         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
2750         (ChromiumAndroidDriver._setup_test):
2751
2752 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
2753
2754         [EFL] Rewrite the EFL-related Find modules
2755         https://bugs.webkit.org/show_bug.cgi?id=95237
2756
2757         Reviewed by Kenneth Rohde Christiansen.
2758
2759         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
2760         property and include all the Enlightenment Foundation Libraries
2761         required by the target.
2762         * EWebLauncher/CMakeLists.txt: Ditto.
2763         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2764         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
2765         now that they are not added implicitly.
2766         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
2767         property.
2768         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
2769         property and include all the Enlightenment Foundation Libraries
2770         required by the target.
2771
2772 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2773
2774         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
2775         https://bugs.webkit.org/show_bug.cgi?id=96379
2776
2777         Reviewed by Kenneth Rohde Christiansen.
2778
2779         Add implementation for setApplicationCacheOriginQuota
2780         to WebKitTestRunner.
2781
2782         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2783         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2784         (WTR::TestRunner::setApplicationCacheOriginQuota):
2785         (WTR):
2786         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2787         (TestRunner):
2788
2789 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
2790
2791         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
2792         https://bugs.webkit.org/show_bug.cgi?id=91988
2793
2794         Reviewed by Kenneth Rohde Christiansen.
2795
2796         Regular key events generated by Qt for the tab key fill both
2797         keyCode and keyText, so we should do the same for our fake events.
2798
2799         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2800         (WTR::EventSenderProxy::keyDown):
2801
2802 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2803
2804         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
2805         https://bugs.webkit.org/show_bug.cgi?id=96269
2806
2807         Reviewed by Kenneth Rohde Christiansen.
2808
2809         Exported missing testRunner.setSpatialNavigationEnabled() method.
2810
2811         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2812         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2813         (WTR::InjectedBundle::beginTesting):
2814         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2815         (WTR::TestRunner::setSpatialNavigationEnabled):
2816         (WTR):
2817         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2818         (TestRunner):
2819
2820 2012-09-11  Philippe Liard  <pliard@chromium.org>
2821
2822         Support LayoutTests on non-rooted devices for Chromium Android.
2823         https://bugs.webkit.org/show_bug.cgi?id=95346
2824
2825         Reviewed by Dirk Pranke.
2826
2827         We were requiring root permissions to sync resource files with the
2828         device by comparing host and device files' timestamp after we
2829         synchronized the device and host clocks.
2830         We now rely on md5sum provided by Chromium to handle data files
2831         synchronization.
2832
2833         * Scripts/webkitpy/layout_tests/port/chromium.py:
2834         (ChromiumPort._check_driver_build_up_to_date):
2835         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2836         (ChromiumAndroidDriver.__init__):
2837         (ChromiumAndroidDriver._setup_test):
2838         (ChromiumAndroidDriver._push_executable):
2839         (ChromiumAndroidDriver._push_test_resources):
2840         (ChromiumAndroidDriver._read_prompt):
2841
2842 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2843
2844         [Qt] Fix output paths on Windows
2845
2846         Reviewed by Tor Arne Vestbø.
2847
2848         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
2849         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
2850         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
2851         incorrect here and instead for the calculation we should use forward slashes.
2852
2853         * qmake/mkspecs/features/default_pre.prf:
2854
2855 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2856
2857         [Qt] Fix passing of defines from the build system
2858
2859         We explicitly have to pass -DENABLE_FOO=0 for every single feature
2860         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
2861         will add it's own defaults if the features are not defined.
2862
2863         At some point we might want to run a configure-test to inspect what
2864         Platform.h will do, so we can sync up the build system's view of
2865         the feature-defines with the compile-time situation.
2866
2867         Reviewed by Simon Hausmann.
2868
2869         * qmake/mkspecs/features/functions.prf:
2870
2871 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2872
2873         [Qt] Fix --qt option to build-webkit
2874
2875         Reviewed by Ossy.
2876
2877         * Scripts/webkitdirs.pm:
2878         (buildQMakeProjects):
2879
2880 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2881
2882         [Qt] Add a configure step to the Qt build system
2883
2884         This allows building the Qt port using just 'qmake WebKit.pro'. Using
2885         the build-webkit script is still supported, and will add slightly more
2886         logic to the build, such as detecting the need for clean or incremental
2887         builds.
2888
2889         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
2890         all things related to configuring the build, such as use/have/enable flags,
2891         and these are translated to defines in default_post. Project files should
2892         no longer check contains(DEFINES,...) to detect features, but use the new
2893         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
2894         options have been translated into WEBKIT_CONFIG options as well, and can
2895         be checked using build?().
2896
2897         Reviewed by Simon Hausmann.
2898
2899         * DumpRenderTree/qt/DumpRenderTree.pro:
2900         * MiniBrowser/qt/MiniBrowser.pro:
2901         * QtTestBrowser/QtTestBrowser.pro:
2902         * Scripts/build-webkit:
2903         * Scripts/webkitdirs.pm:
2904         (qtFeatureDefaults):
2905         (buildQMakeProjects):
2906         * Tools.pro:
2907         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2908         * WebKitTestRunner/InjectedBundle/Target.pri:
2909         * WebKitTestRunner/Target.pri:
2910         * qmake/.qmake.cache: Added.
2911         * qmake/configure.pri: Removed.
2912         * qmake/configure.pro: Removed.
2913         * qmake/dump-features: Added.
2914         * qmake/mkspecs/features/configure.prf: Added.
2915         * qmake/mkspecs/features/default_post.prf:
2916         * qmake/mkspecs/features/default_pre.prf:
2917         * qmake/mkspecs/features/features.prf:
2918         * qmake/mkspecs/features/features.pri:
2919         * qmake/mkspecs/features/functions.prf:
2920         * qmake/mkspecs/features/gprof.prf:
2921         * qmake/mkspecs/features/mac/default_pre.prf:
2922         * qmake/mkspecs/features/win32/default_pre.prf:
2923
2924 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2925
2926         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
2927         https://bugs.webkit.org/show_bug.cgi?id=96372
2928
2929         Reviewed by Kenneth Rohde Christiansen.
2930
2931         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
2932
2933         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2934         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2935         (WTR::TestRunner::clearApplicationCacheForOrigin):
2936         (WTR):
2937         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2938         (TestRunner):
2939
2940 2012-09-11  Peter Beverloo  <peter@chromium.org>
2941
2942         Don't ignore .pak files when making an archive for Android
2943         https://bugs.webkit.org/show_bug.cgi?id=96375
2944
2945         Reviewed by Jochen Eisinger.
2946
2947         The .pak files do need to be pushed to the device, which is currently
2948         preventing the layout test runner from correctly pushing all files.
2949
2950         * BuildSlaveSupport/built-product-archive:
2951         (archiveBuiltProduct):
2952
2953 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2954
2955         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
2956         https://bugs.webkit.org/show_bug.cgi?id=96256
2957
2958         Reviewed by Kenneth Rohde Christiansen.
2959
2960         Exported TestRunner::setMinimumTimerInterval() method.
2961
2962         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2963         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2964         (WTR::InjectedBundle::beginTesting):
2965         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2966         (WTR::TestRunner::setMinimumTimerInterval):
2967         (WTR):
2968         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2969         (TestRunner):
2970
2971 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
2972
2973         MediaStream API: add RTCPeerConnection::onnegotiationneeded
2974         https://bugs.webkit.org/show_bug.cgi?id=96097
2975
2976         Reviewed by Adam Barth.
2977
2978         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2979         (MockWebRTCPeerConnectionHandler::addStream):
2980         (MockWebRTCPeerConnectionHandler::removeStream):
2981
2982 2012-09-11  Peter Beverloo  <peter@chromium.org>
2983
2984         Recognize the "--chromium-android" argument in run-webkit-tests
2985         https://bugs.webkit.org/show_bug.cgi?id=96369
2986
2987         Reviewed by Jochen Eisinger.
2988
2989         Chromium for the Android platform cannot determine the platform based on
2990         the host itself, so we'll use the --chromium-android argument as the build
2991         master passes to run-webkit-tests. Make sure the layout test runner
2992         can pick the right port when doing so.
2993
2994         * Scripts/run-webkit-tests:
2995         * Scripts/webkitpy/layout_tests/port/factory.py:
2996         (port_options):
2997
2998 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2999
3000         [QT] Fix build with newer qmake from Qt 5
3001
3002         Rubber-stamped by Tor Arne Vestbø.
3003
3004         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
3005         it with the use of QT_HOST_DATA/mkspecs.
3006         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
3007
3008         * Scripts/webkitdirs.pm:
3009         (builtDylibPathForName):
3010         (qtMakeCommand):
3011
3012 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3013
3014         [Qt] Remove Qt 4 syncqt, no longer needed
3015
3016         Reviewed by Simon Hausmann.
3017
3018         * qmake/syncqt-4.8: Removed.
3019
3020 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
3021
3022         [Qt][WK2] Fix the build with recent Qt5
3023         https://bugs.webkit.org/show_bug.cgi?id=96283
3024
3025         Reviewed by Simon Hausmann.
3026
3027         We should not use deprecated Qt API because doing that results
3028         in build failure since all the deprecated API was disabled
3029         in qtbase (https://codereview.qt-project.org/#change,24890).
3030
3031         * DumpRenderTree/qt/main.cpp:
3032         (main):
3033         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3034         (MiniBrowserApplication::notify):
3035         * MiniBrowser/qt/raw/View.cpp:
3036         (View::exposeEvent):
3037         (main):
3038
3039 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
3040
3041         WTR needs an implementation of applicationCacheDiskUsageForOrigin
3042         https://bugs.webkit.org/show_bug.cgi?id=87188
3043
3044         Reviewed by Kenneth Rohde Christiansen.
3045
3046         Add implementation for applicationCacheDiskUsageForOrigin()
3047         in WebKitTestRunner.
3048
3049         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3050         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3051         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
3052         (WTR):
3053         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3054         (TestRunner):
3055
3056 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
3057
3058         Properly expose <legend> elements to ATs
3059         https://bugs.webkit.org/show_bug.cgi?id=84137
3060
3061         Reviewed by Chris Fleizach.
3062
3063         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
3064         the expected platform role, ATK_ROLE_LABEL. Also established the needed
3065         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
3066
3067         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3068         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
3069
3070 2012-09-10  Jer Noble  <jer.noble@apple.com>
3071
3072         Unreviewed; rolling out r128081.
3073         http://trac.webkit.org/changeset/128081
3074         https://bugs.webkit.org/show_bug.cgi?id=96134
3075
3076         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
3077
3078         * DumpRenderTree/TestRunner.cpp:
3079         (TestRunner::TestRunner):
3080         (TestRunner::staticFunctions):
3081         * DumpRenderTree/TestRunner.h:
3082         (TestRunner):
3083         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3084         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3085         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3086         (WTR::InjectedBundlePage::InjectedBundlePage):
3087         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3088         (InjectedBundlePage):
3089         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3090         (WTR::TestRunner::TestRunner):
3091         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3092         (TestRunner):
3093
3094 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
3095
3096         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
3097         https://bugs.webkit.org/show_bug.cgi?id=96205
3098
3099         Reviewed by Tony Chang.
3100
3101         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
3102         internally, which means that it would support only 1 TestExpectations file per port. This
3103         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
3104         and efl-wk1 -> efl).
3105
3106         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
3107         instead so that all the ports TestExpectations are recognized. The ports are also
3108         constructed twice, with "webkit_test_runner" option set to True and False so that we
3109         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
3110
3111         * Scripts/webkitpy/style/checkers/test_expectations.py:
3112         (TestExpectationsChecker._determine_port_from_expectations_path):
3113         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
3114         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
3115
3116 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
3117
3118         [WTR] Generated source files should include config.h
3119         https://bugs.webkit.org/show_bug.cgi?id=96254
3120
3121         Reviewed by Benjamin Poulain.
3122
3123         Current coding style has encouraged to include config.h at the first position,
3124         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
3125         this rule.
3126         Therefore, this patch added it.
3127
3128         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3129         (_generateImplementationFile):
3130
3131 2012-09-10  Rick Byers  <rbyers@chromium.org>
3132
3133         Add handling of new GestureTapCancel in DRT
3134         
3135         https://bugs.webkit.org/show_bug.cgi?id=96183
3136
3137         Reviewed by Adam Barth.
3138
3139         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3140         (TestWebPlugin::handleInputEvent):
3141
3142 2012-09-10  Brady Eidson  <beidson@apple.com>
3143
3144         Javascript in foreground tabs should not wait synchronously for plug-ins to load
3145         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
3146
3147         Reviewed by Geoff Garen.
3148
3149         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
3150
3151         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
3152         (PluginObject):
3153         (SlowNPPNew::PluginObject::PluginObject):
3154         (SlowNPPNew::PluginObject::~PluginObject):
3155         (SlowNPPNew::PluginObject::hasProperty):
3156         (SlowNPPNew::PluginObject::getProperty):
3157         (SlowNPPNew::NPP_GetValue):
3158         (SlowNPPNew):
3159
3160 2012-09-10  Tim Horton  <timothy_horton@apple.com>
3161
3162         WKTR often reports an unresponsive WebProcess on Mac bots
3163         https://bugs.webkit.org/show_bug.cgi?id=95906
3164
3165         Reviewed by Dan Bernstein.
3166
3167         Attempt to work around resource contention issues by increasing the NRWT
3168         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
3169
3170         * Scripts/webkitpy/layout_tests/port/base.py:
3171         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
3172         * WebKitTestRunner/TestController.cpp:
3173         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
3174
3175 2012-09-07  Jer Noble  <jer.noble@apple.com>
3176
3177         <audio> and <video> should send Do Not Track when appropriate
3178         https://bugs.webkit.org/show_bug.cgi?id=96134
3179
3180         Reviewed by Eric Carlson.
3181
3182         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
3183         WTR. Add FrameLoaderClient client methods for retrieving that value.
3184
3185         * DumpRenderTree/TestRunner.cpp:
3186         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
3187         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
3188         * DumpRenderTree/TestRunner.h:
3189         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
3190         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
3191         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3192         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
3193             Pass the question on to the TestRunner.
3194         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3195         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3196         (WTR::InjectedBundlePage::InjectedBundlePage):
3197             Add the setShouldSendDoNotTrackHTTPHeader client function.
3198         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
3199             Pass the question on to the TestRunner.
3200         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3201         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3202         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3203         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
3204         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
3205
3206 2012-09-10  Ojan Vafai  <ojan@chromium.org>
3207
3208         Make EFL bots work on the flakiness dashboard
3209         https://bugs.webkit.org/show_bug.cgi?id=96164
3210
3211         Reviewed by Tony Chang.
3212
3213         Also, update outdated unittests that had started failing.
3214
3215         * TestResultServer/static-dashboards/builders.js:
3216         (isWebkitTestRunner):
3217         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3218         (nonChromiumPlatform):
3219         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3220         (test):
3221
3222 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
3223
3224         [chromium] MediaStream API: Remove the Descriptor postfix
3225         https://bugs.webkit.org/show_bug.cgi?id=96268
3226
3227         Reviewed by Adam Barth.
3228
3229         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
3230         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
3231
3232         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3233         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3234         (MockWebRTCPeerConnectionHandler::createOffer):
3235         (MockWebRTCPeerConnectionHandler::createAnswer):
3236         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3237         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3238         (MockWebRTCPeerConnectionHandler::localDescription):
3239         (MockWebRTCPeerConnectionHandler::remoteDescription):
3240         (MockWebRTCPeerConnectionHandler::addICECandidate):
3241         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3242         (MockWebRTCPeerConnectionHandler):
3243
3244 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
3245
3246         [Gtk] failure to build jhbuild dependencies with cups 1.6
3247         https://bugs.webkit.org/show_bug.cgi?id=95991
3248
3249         Reviewed by Gustavo Noronha Silva.
3250
3251         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
3252         building with cups >= 1.6 [GNOME #670373].
3253
3254         * gtk/jhbuild.modules:
3255
3256 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
3257
3258         [EFL][DRT] Encoding issue in printed console messages
3259         https://bugs.webkit.org/show_bug.cgi?id=96263
3260
3261         Reviewed by Kenneth Rohde Christiansen.
3262
3263         Correctly handle CONSOLE messages that contain non-ascii
3264         characters in EFL's DRT. We need to use String::fromUTF8()
3265         to construct a WTF::String from a raw string.
3266
3267         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3268         (onConsoleMessage):
3269
3270 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3271
3272         [WK2][WTR] User style sheet location should be reset before each test
3273         https://bugs.webkit.org/show_bug.cgi?id=96262
3274
3275         Reviewed by Kenneth Rohde Christiansen.
3276
3277         User style sheet location is reset before each test now.
3278
3279         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3280         (WTR::InjectedBundle::beginTesting):
3281
3282 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
3283
3284         Fix build of WTR with Qt on Windows
3285         https://bugs.webkit.org/show_bug.cgi?id=96249
3286
3287         Reviewed by Kenneth Rohde Christiansen.
3288
3289         Windows loves to define min and max as macros, which beautifully
3290         clashes in many places where min and max are used as variable or method
3291         names. It can be convinced not to do this when min and max are already
3292         define as macros (expanding to themselves). We have this kind of
3293         workaround in config.h files all over WebKit and as it turns out when
3294         building WTR with Qt on Windows we do end up with such a clash. Therefore
3295         we need the same workaround.
3296
3297         * WebKitTestRunner/config.h:
3298
3299 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
3300
3301         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
3302         https://bugs.webkit.org/show_bug.cgi?id=95936
3303
3304         Reviewed by Kenneth Rohde Christiansen.
3305
3306         Enable interactive form validation setting in WebKitTestRunner as
3307         we are currently doing in DumpRenderTree. This is needed for some
3308         tests to pass.
3309
3310         * WebKitTestRunner/TestController.cpp:
3311         (WTR::TestController::resetStateToConsistentValues):
3312
3313 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
3314
3315         Clean up the code in XvfbDriver
3316         https://bugs.webkit.org/show_bug.cgi?id=96202
3317
3318         Reviewed by Philippe Normand.
3319
3320         Changes:
3321         - Remove unneeded imports,
3322         - assign the _lock_file member variable when the display number is determined,
3323         - no need for parentheses around a single string format argument,
3324         - use FileSystem.exists method when checking if lock file is present as it
3325         makes the intention much more clearer.
3326
3327         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3328         (XvfbDriver._start):
3329         (XvfbDriver.stop):
3330
3331 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
3332
3333         Make the String initialization on the function side of String::number()
3334         https://bugs.webkit.org/show_bug.cgi?id=95940
3335
3336         Reviewed by Benjamin Poulain.
3337
3338         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
3339         (testBoundaries):
3340         (testNumbers):
3341
3342 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
3343
3344         [WK2] expose element rect for color input type
3345         https://bugs.webkit.org/show_bug.cgi?id=91664
3346
3347         Reviewed by Simon Hausmann.
3348
3349         Update the QML logic in MiniBrowser to take advantage of this.
3350         The picker size is now hardcoded and we try to place it below the
3351         input element if possible.
3352
3353         * MiniBrowser/qt/qml/ColorChooser.qml:
3354
3355 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
3356
3357         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
3358         https://bugs.webkit.org/show_bug.cgi?id=95329
3359
3360         Reviewed by Kenneth Rohde Christiansen.
3361
3362         Explicitely disable TabToLinks setting in WebKitTestRunner.
3363         Tests override the "WebKitTabToLinksPreferenceKey" preference
3364         to enable it.
3365
3366         * WebKitTestRunner/TestController.cpp:
3367         (WTR::TestController::resetStateToConsistentValues):
3368
3369 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
3370
3371         webkit.py gdb pretty printer can't print CString
3372         https://bugs.webkit.org/show_bug.cgi?id=96068
3373
3374         Reviewed by Tony Chang.
3375
3376         Update WTFCStringPrinter to follow r126191.
3377
3378         * gdb/webkit.py:
3379         (WTFCStringPrinter.to_string):
3380
3381 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
3382
3383         Rename the ustring() accessor to string()
3384         https://bugs.webkit.org/show_bug.cgi?id=95919
3385
3386         Reviewed by Geoffrey Garen.
3387
3388         Update EFL's DRT.
3389
3390         Fix some string conversion that have been made useless
3391         with recent changes.
3392
3393         * DumpRenderTree/efl/EventSender.cpp:
3394         (keyPadNameFromJSValue):
3395         (keyNameFromJSValue):
3396         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3397         (TestRunner::queueLoad):
3398         (TestRunner::addOriginAccessWhitelistEntry):
3399         (TestRunner::removeOriginAccessWhitelistEntry):
3400         (TestRunner::setUserStyleSheetLocation):
3401         (TestRunner::setValueForUser):
3402         (TestRunner::elementDoesAutoCompleteForElementWithId):
3403         (TestRunner::execCommand):
3404         (TestRunner::findString):
3405         (TestRunner::isCommandEnabled):
3406         (TestRunner::clearApplicationCacheForOrigin):
3407         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3408         (TestRunner::pauseAnimationAtTimeOnElementWithId):
3409         (TestRunner::pauseTransitionAtTimeOnElementWithId):
3410         (toInt):
3411         (TestRunner::overridePreference):
3412         (TestRunner::addUserScript):
3413         (TestRunner::addUserStyleSheet):
3414         (TestRunner::evaluateInWebInspector):
3415         (TestRunner::evaluateScriptInIsolatedWorld):
3416         (TestRunner::setTextDirection):
3417         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
3418         (LoadItem::invoke):
3419         (LoadHTMLStringItem::invoke):
3420         (ScriptItem::invoke):
3421
3422 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
3423
3424         Extend third-party storage blocking API to optionally allow blocking all storage
3425         https://bugs.webkit.org/show_bug.cgi?id=95915
3426
3427         Reviewed by Brady Eidson.
3428
3429         Modified API test to use new revised API.
3430
3431         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3432         (TestWebKitAPI::TEST):
3433
3434 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
3435
3436         AX: WebCore accessibility roles should be cross-platform
3437         https://bugs.webkit.org/show_bug.cgi?id=94870
3438
3439         Reviewed by Chris Fleizach.
3440
3441         Add debug strings to Chromium for new accessibility roles.
3442
3443         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3444         (roleToString):
3445
3446 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
3447
3448         AX: Chromium needs access to canvasHasFallbackContent
3449         https://bugs.webkit.org/show_bug.cgi?id=96124
3450
3451         Reviewed by Chris Fleizach.
3452
3453         Distinguish between canvas roles with and without fallback
3454         content on Chromium.
3455
3456         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3457         (getRole):
3458
3459 2012-09-07  Ojan Vafai  <ojan@chromium.org>
3460
3461         Handle non-existant TestExpectations files gracefully
3462         https://bugs.webkit.org/show_bug.cgi?id=96149
3463
3464         Reviewed by Eric Seidel.
3465
3466         Even when we get rid of Skipped files, we shouldn't have each port
3467         require a TestExpectations file for each platform if it doesn't
3468         need one.
3469
3470         * Scripts/webkitpy/layout_tests/port/base.py:
3471         (Port.expectations_dict):
3472         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3473         (PortTest.test_nonexistant_expectations):
3474
3475 2012-09-07  Tony Chang  <tony@chromium.org>
3476
3477         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
3478         https://bugs.webkit.org/show_bug.cgi?id=96136
3479
3480         Reviewed by Ojan Vafai.
3481
3482         When we renamed the file to TestExpectations, it was no longer considered a text file so
3483         it was no longer being checked. Since then, test_expectations_overrides() has been removed
3484         from the port object, so I've removed that from the check. I'm not sure what it was
3485         supposed to do.
3486
3487         * Scripts/webkitpy/style/checker.py:
3488         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
3489         * Scripts/webkitpy/style/checkers/test_expectations.py:
3490         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
3491         (TestExpectationsChecker.check): Remove overrides param.
3492         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3493         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
3494
3495 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3496
3497         [EFL] Use same default minimum logical font size in DRT and WTR
3498         https://bugs.webkit.org/show_bug.cgi?id=96116
3499
3500         Reviewed by Martin Robinson.
3501
3502         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3503         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
3504         logical font size to 9 to match the value used in WTR.
3505         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3506         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
3507         logical font size to 9 (default value in WK2)
3508
3509 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
3510
3511         MediaStream API: add RTCPeerConnection::createAnswer
3512         https://bugs.webkit.org/show_bug.cgi?id=96092
3513
3514         Reviewed by Adam Barth.
3515
3516         Expanding and enhancing MockWebRTCPeerConnectionHandler.
3517
3518         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3519         (MockWebRTCPeerConnectionHandler::createOffer):
3520         (MockWebRTCPeerConnectionHandler::createAnswer):
3521         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3522         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3523         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3524         (MockWebRTCPeerConnectionHandler):
3525
3526 2012-09-07  Dean Jackson  <dino@apple.com>
3527
3528         Unreviewed changes to watchlist.
3529
3530         - Add new WebGL and Filters definitions
3531         - Add myself to OpenGL bugs
3532
3533         * Scripts/webkitpy/common/config/watchlist:
3534
3535 2012-09-07  Peter Beverloo  <peter@chromium.org>
3536
3537         Actually trigger the Android Tester
3538         https://bugs.webkit.org/show_bug.cgi?id=96118
3539
3540         Reviewed by Adam Barth.
3541
3542         * BuildSlaveSupport/build.webkit.org-config/config.json:
3543
3544 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
3545
3546         New time input needs accessibility
3547         https://bugs.webkit.org/show_bug.cgi?id=96032
3548
3549         Reviewed by Chris Fleizach.
3550
3551         Add support for valueDescription for testing.
3552
3553         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3554         (getValueDescription):
3555         (AccessibilityUIElement::AccessibilityUIElement):
3556         (AccessibilityUIElement::valueDescriptionGetterCallback):
3557         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
3558         (AccessibilityUIElement):
3559
3560 2012-09-07  Peter Beverloo  <peter@chromium.org>
3561
3562         Add the google-android-tests build slave to the master's config
3563         https://bugs.webkit.org/show_bug.cgi?id=96113
3564
3565         Reviewed by Csaba Osztrogonác.
3566
3567         * BuildSlaveSupport/build.webkit.org-config/config.json:
3568
3569 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3570
3571         [WK2] [EFL] Set theme for WebKit2 API test runner
3572         https://bugs.webkit.org/show_bug.cgi?id=96100
3573
3574         Reviewed by Kenneth Rohde Christiansen.
3575
3576         Set the theme generated by the build for the WebKit2 API test runner.
3577
3578         * TestWebKitAPI/PlatformEfl.cmake:
3579         * TestWebKitAPI/efl/PlatformWebView.cpp:
3580         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3581
3582 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3583
3584         Unreviewed. Add Gábor Ballabás as contributor.
3585
3586         * Scripts/webkitpy/common/config/committers.py:
3587
3588 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
3589
3590         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
3591         https://bugs.webkit.org/show_bug.cgi?id=96078
3592
3593         Reviewed by Tor Arne Vestbø.
3594
3595         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
3596
3597         * qmake/mkspecs/features/default_pre.prf:
3598
3599 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3600
3601         [EFL] Add TestExpectations file for efl-wk1
3602         https://bugs.webkit.org/show_bug.cgi?id=96019
3603
3604         Reviewed by Gyuyoung Kim.
3605
3606         Update TestExpectations cascading for EFL port
3607         so that we use efl-wk1 -> efl search paths
3608         for WebKit1 EFL.
3609
3610         * Scripts/webkitpy/layout_tests/port/efl.py:
3611         (EflPort._search_paths):
3612
3613 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
3614
3615         [NRWT] XvfbDriver should stop the Xvfb more aggressively
3616         https://bugs.webkit.org/show_bug.cgi?id=95097
3617
3618         Reviewed by Dirk Pranke.
3619
3620         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
3621         terminating the process does not always work as expected, leading to timeouts
3622         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
3623         as it's not removed by the killed Xvfb process.
3624
3625         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
3626         is tested in different circumstances - whether pixel tests are enabled or not,
3627         with an arbitrary worker number or with an Xorg process already running on the system.
3628         The stopping of the driver is tested by checking that the Xvfb process is truly killed
3629         and then set to None.
3630
3631         * BuildSlaveSupport/kill-old-processes:
3632         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
3633         is left running, potentially clogging up a display at a certain position.
3634         * Scripts/webkitpy/common/system/executive_mock.py:
3635         (MockExecutive.__init__):
3636         The _running_pids is now a dictionary with process names as keys and pids
3637         as values.
3638         (MockExecutive.check_running_pid):
3639         Check whether the passed-in pid is in the _running_pids dictionary's values.
3640         (MockExecutive):
3641         (MockExecutive.running_pids):
3642         This method returns the list of all the process pids of which the name passes
3643         through the process_name_filter.
3644         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3645         Use the Executive object of the port's host to check for running pids and open
3646         new subprocesses or kill them throughout the class.
3647         (XvfbDriver._start):
3648         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
3649         start the server process after it's created.
3650         (XvfbDriver.stop):
3651         Now kills the Xvfb process instead of terminating it and waiting for it to close.
3652         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
3653         (XvfbDriverTest):
3654         (XvfbDriverTest.make_driver):
3655         (XvfbDriverTest.assertDriverStartSuccessful):
3656         (XvfbDriverTest.test_start_no_pixel_tests):
3657         (XvfbDriverTest.test_start_pixel_tests):
3658         (XvfbDriverTest.test_start_arbitrary_worker_number):
3659         (XvfbDriverTest.test_start_existing_xorg_process):
3660         (XvfbDriverTest.test_stop):
3661         (XvfbDriverTest.test_stop.FakeXvfbProcess):
3662
3663 2012-09-06  Peter Beverloo  <peter@chromium.org>
3664
3665         Introduce the Chromium Android Release (Tests) bot
3666         https://bugs.webkit.org/show_bug.cgi?id=95980
3667
3668         Reviewed by Adam Barth.
3669
3670         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
3671         which will be running layout tests on actual Android devices. Right now,
3672         four Galaxy Nexus phones are attached.
3673
3674         * BuildSlaveSupport/build.webkit.org-config/config.json:
3675
3676 2012-09-06  James Robinson  <jamesr@chromium.org>
3677
3678         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
3679         https://bugs.webkit.org/show_bug.cgi?id=96007
3680
3681         Reviewed by Adrienne Walker.
3682
3683         Fixes initialization / settings code to use WebCompositorSupport.
3684
3685         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3686         (main):
3687         * DumpRenderTree/chromium/TestShell.cpp:
3688         (TestShell::initialize):
3689         (TestShell::setPerTilePaintingEnabled):
3690
3691 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3692
3693         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
3694         https://bugs.webkit.org/show_bug.cgi?id=95995
3695
3696         Reviewed by Kenneth Rohde Christiansen.
3697
3698         Provide proper implementation for PlatformWebView::windowFrame()
3699         in EFL's WebKitTestRunner.
3700
3701         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3702         (WTR::PlatformWebView::windowFrame):
3703
3704 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
3705
3706         Fix WTF.Lrint on 32-bit platforms
3707         https://bugs.webkit.org/show_bug.cgi?id=96003
3708
3709         Reviewed by Benjamin Poulain.
3710
3711         Fixed failing WTF.Lrint test on 32-bit platforms.
3712
3713         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3714         (TestWebKitAPI::TEST):
3715
3716 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
3717
3718         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3719         https://bugs.webkit.org/show_bug.cgi?id=95839
3720
3721         Reviewed by Adam Barth.
3722
3723         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3724         up the task definitions a bit. There was no need to have them in the header file.
3725
3726         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3727         (RTCSessionDescriptionRequestSuccededTask):
3728         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3729         (RTCSessionDescriptionRequestFailedTask):
3730         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3731         (RTCVoidRequestTask):
3732         (RTCVoidRequestTask::RTCVoidRequestTask):
3733         (MockWebRTCPeerConnectionHandler::createOffer):
3734         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3735         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3736         (MockWebRTCPeerConnectionHandler::localDescription):
3737         (MockWebRTCPeerConnectionHandler::remoteDescription):
3738         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3739         (MockWebRTCPeerConnectionHandler):
3740
3741 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3742
3743         [Qt] Fix build on Mac OS X 10.6
3744         https://bugs.webkit.org/show_bug.cgi?id=95200
3745
3746         Reviewed by Tor Arne Vestbø.
3747
3748         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
3749         10.7 and newer.
3750
3751         * qmake/mkspecs/features/features.prf:
3752
3753 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3754
3755         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
3756         https://bugs.webkit.org/show_bug.cgi?id=95973
3757
3758         Reviewed by Kenneth Rohde Christiansen.
3759
3760         Correctly map "addSelectionKey" to "Control" modifier
3761         in WKTR's EventSender on other OSes than Mac OS X,
3762         instead of mapping it to the "Meta" modifier.
3763
3764         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3765         (WTR::parseModifier):
3766
3767 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
3768
3769         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
3770         https://bugs.webkit.org/show_bug.cgi?id=95710
3771
3772         Reviewed by Dirk Pranke.
3773
3774         The stdout / stderr output can be None so make sure
3775         we won't raise an exception in this case.
3776
3777         * Scripts/webkitpy/layout_tests/port/driver.py:
3778         (Driver.run_test):
3779
3780 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3781
3782         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
3783         https://bugs.webkit.org/show_bug.cgi?id=95849
3784
3785         Reviewed by Kenneth Rohde Christiansen.
3786
3787         Sanitize URLs passed by the user as program
3788         argument or typed in the URL bar in order to
3789         be more tolerant.
3790
3791         * EWebLauncher/CMakeLists.txt:
3792         * EWebLauncher/main.c:
3793         (main):
3794         * EWebLauncher/url_bar.c:
3795         (_url_bar_url_get_with_protocol):
3796         (on_urlbar_key_down):
3797         * EWebLauncher/url_utils.c: Added.
3798         (has_scheme):
3799         (url_from_user_input): Add utility function to construct a
3800         URL from user input.
3801         * EWebLauncher/url_utils.h: Added.
3802         * MiniBrowser/efl/CMakeLists.txt:
3803         * MiniBrowser/efl/main.c:
3804         (main):
3805
3806 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3807
3808         [Qt] Various small Windows / MSVC build fixes
3809         https://bugs.webkit.org/show_bug.cgi?id=95934
3810
3811         Reviewed by Kenneth Rohde Christiansen.
3812
3813         setFocus takes a boolean as argument: Don't try to implicitly convert
3814         an enum to a boolean, MSVC doesn't like that. The intent here is to
3815         enable focus, so just pass true.
3816
3817         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3818         (WTR::PlatformWebView::focus):
3819
3820 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3821
3822         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
3823         https://bugs.webkit.org/show_bug.cgi?id=95965
3824
3825         Reviewed by Tor Arne Vestbø.
3826
3827         Add ANGLE as a static library module to the Qt WebKit build system.
3828
3829         * qmake/mkspecs/features/default_post.prf:
3830         * qmake/mkspecs/modules/angle.prf: Added.
3831
3832 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
3833
3834         [WK2] Make [Qt]ViewportHandler cross platform
3835         https://bugs.webkit.org/show_bug.cgi?id=91257
3836
3837         Reviewed by Kenneth Rohde Christiansen.
3838
3839         Remove initial scale from viewport info item since it is
3840         set to -1 after applied thus it does not hold any valuable
3841         information.
3842
3843         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3844
3845 2012-09-05  Tony Chang  <tony@chromium.org>
3846
3847         [chromium] Remove dependency on webkit_user_agent
3848         https://bugs.webkit.org/show_bug.cgi?id=95886
3849
3850         Reviewed by Adam Barth.
3851
3852         The code isn't used by DumpRenderTree.
3853
3854         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3855
3856 2012-09-05  Rick Byers  <rbyers@chromium.org>
3857
3858         Update chromium DumpRenderTree for new WebGestureEvent fields
3859         https://bugs.webkit.org/show_bug.cgi?id=95573
3860
3861         Reviewed by James Robinson.
3862
3863         Update EventSender to write gesture details into the appropriate
3864         type-specific WebGestureEvent fields.
3865         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3866         (EventSender::gestureEvent):
3867         (EventSender::gestureFlingStart):
3868
3869 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
3870
3871         NRWT lies about the number of tests that it's skipping when used with --repeat-each
3872         https://bugs.webkit.org/show_bug.cgi?id=95789
3873
3874         Reviewed by Ojan Vafai.
3875
3876         Fix miscalculation in log message.
3877
3878         * Scripts/webkitpy/layout_tests/views/printing.py:
3879         (Printer.print_found):
3880
3881 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
3882
3883         Unreviewed, rolling out r127612, r127660, and r127664.
3884         http://trac.webkit.org/changeset/127612
3885         http://trac.webkit.org/changeset/127660
3886         http://trac.webkit.org/changeset/127664
3887         https://bugs.webkit.org/show_bug.cgi?id=95920
3888
3889         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3890         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3891         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3892         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3893         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3894         (MockWebRTCPeerConnectionHandler::createOffer):
3895         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3896         (MockWebRTCPeerConnectionHandler):
3897         (SuccessCallbackTask):
3898         (FailureCallbackTask):
3899
3900 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3901
3902         Ignore-metrics includes scroll offsets.
3903         https://bugs.webkit.org/show_bug.cgi?id=95845
3904
3905         Reviewed by Dirk Pranke.
3906
3907         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
3908
3909         * Scripts/old-run-webkit-tests:
3910         (stripMetrics):
3911         * Scripts/webkitpy/layout_tests/port/driver.py:
3912         (DriverOutput):
3913
3914 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
3915
3916         Unreviewed test fix.
3917
3918         Including a plugin source file into the build that was added in r127595.
3919
3920         * GNUmakefile.am:
3921
3922 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
3923
3924         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3925         https://bugs.webkit.org/show_bug.cgi?id=95839
3926
3927         Reviewed by Adam Barth.
3928
3929         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3930         up the task definitions a bit. There was no need to have them in the header file.
3931
3932         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3933         (RTCSessionDescriptionRequestSuccededTask):
3934         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3935         (RTCSessionDescriptionRequestFailedTask):
3936         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3937         (RTCVoidRequestTask):
3938         (RTCVoidRequestTask::RTCVoidRequestTask):
3939         (MockWebRTCPeerConnectionHandler::createOffer):
3940         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3941         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3942         (MockWebRTCPeerConnectionHandler::localDescription):
3943         (MockWebRTCPeerConnectionHandler::remoteDescription):
3944         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3945         (MockWebRTCPeerConnectionHandler):
3946
3947 2012-09-05  Kangil Han  <kangil.han@samsung.com>
3948
3949         [EFL] Remove '+=' usage in String
3950         https://bugs.webkit.org/show_bug.cgi?id=95808
3951
3952         Reviewed by Benjamin Poulain.
3953
3954         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
3955
3956         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3957         (descriptionSuitableForTestResult):
3958
3959 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3960
3961         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
3962         https://bugs.webkit.org/show_bug.cgi?id=95842
3963
3964         Reviewed by Kenneth Rohde Christiansen.
3965
3966         Provide proper implementation for TestRunner::pathToLocalResource()
3967         in EFL WKTR, identical to the one for DumpRenderTree.
3968
3969         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
3970         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
3971         are found my WebKitTestRunner.
3972
3973         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3974         (WTR::TestRunner::pathToLocalResource):
3975
3976 2012-09-05  Brady Eidson  <beidson@apple.com>
3977
3978         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
3979         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
3980
3981         Reviewed by Andy Estes.
3982
3983         Add a plug-in that always fails to initialize:
3984         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
3985         (NPPNewFails):
3986         (NPPNewFails::NPPNewFails):
3987         (NPPNewFails::NPP_New):
3988
3989         Add it to all the project files:
3990         * DumpRenderTree/DumpRenderTree.gypi:
3991         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3992         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3993         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3994         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3995
3996 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3997
3998         [Qt] Fix makefile race condition between derived sources and target
3999
4000         r121966 removed too much of the old qmake logic, including the rule
4001         that ensured that qmake_all would not trigger dual runs of qmake --
4002         one of the derived sources -qmake-all rule, and one for making the
4003         derived sources.
4004
4005         We now follow a similar pattern as before, by introducing a custom
4006         target that explicitly depends on the derived sources' qmake-all before
4007         doing a manual run of make. That ensures a single qmake run for the derived
4008         sources.
4009
4010         https://bugs.webkit.org/show_bug.cgi?id=93847
4011
4012         Reviewed by Csaba Osztrogonác.
4013
4014         * qmake/mkspecs/features/functions.prf:
4015
4016 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
4017
4018         WKTR doesn't implement dumpWillCacheResponse()
4019         https://bugs.webkit.org/show_bug.cgi?id=94607
4020
4021         Reviewed by Kenneth Rohde Christiansen.
4022
4023         Define shouldCacheResponse() callback in resource
4024         load client and provide implementation for
4025         dumpWillCacheResponse() in WebKitTestRunner.
4026
4027         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4028         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4029         (WTR::InjectedBundlePage::InjectedBundlePage):
4030         (WTR::InjectedBundlePage::shouldCacheResponse):
4031         (WTR):
4032         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4033         (InjectedBundlePage):
4034         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4035         (WTR::TestRunner::TestRunner):
4036         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4037         (WTR::TestRunner::dumpWillCacheResponse):
4038         (WTR::TestRunner::shouldDumpWillCacheResponse):
4039         (TestRunner):
4040
4041 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
4042
4043         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
4044         https://bugs.webkit.org/show_bug.cgi?id=92735
4045
4046         Reviewed by Hajime Morita.
4047
4048         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
4049
4050         * DumpRenderTree/TestRunner.cpp:
4051         (TestRunner::staticFunctions):
4052         * DumpRenderTree/TestRunner.h:
4053         (TestRunner):
4054         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
4055         (TestRunner::addUserStyleSheet):
4056         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4057         (DRTTestRunner::DRTTestRunner):
4058         (DRTTestRunner::hasCustomPageSizeStyle):
4059         * DumpRenderTree/chromium/DRTTestRunner.h:
4060         (DRTTestRunner):
4061         * DumpRenderTree/efl/TestRunnerEfl.cpp:
4062         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4063         * DumpRenderTree/mac/TestRunnerMac.mm:
4064         * DumpRenderTree/qt/TestRunnerQt.cpp:
4065         (TestRunner::evaluateScriptInIsolatedWorld):
4066         * DumpRenderTree/qt/TestRunnerQt.h:
4067         (TestRunner):
4068         * DumpRenderTree/win/TestRunnerWin.cpp:
4069         * DumpRenderTree/wx/TestRunnerWx.cpp:
4070         (TestRunner::abortModal):
4071         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4072         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4073         (WTR):
4074         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4075         (TestRunner):
4076
4077 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
4078
4079         [Qt] Automate the use of AllInOne files in the Qt build
4080         https://bugs.webkit.org/show_bug.cgi?id=95837
4081
4082         Reviewed by Tor Arne Vestbø.
4083
4084         New feature file that implements the all-in-one file automation by
4085         adding the requested all-in-one files to SOURCES and removing the files
4086         it includes from SOURCES.
4087
4088         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
4089
4090 2012-09-04  Tim Horton  <timothy_horton@apple.com>
4091
4092         Have NRWT log more output when crash logs are missing
4093         https://bugs.webkit.org/show_bug.cgi?id=95814
4094
4095         Reviewed by Dan Bernstein.
4096
4097         Log the stderr and stdout of the test, in order to provide slightly more
4098         context when the WebProcess times out while running tests.
4099
4100         * Scripts/webkitpy/layout_tests/port/driver.py:
4101         (Driver.run_test):
4102
4103 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
4104
4105         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
4106         https://bugs.webkit.org/show_bug.cgi?id=95770
4107
4108         Reviewed by Adam Barth.
4109
4110         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4111         (ChromiumAndroidDriver.__init__):
4112         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
4113         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
4114         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
4115         (ChromiumAndroidDriver._push_executable):
4116         (ChromiumAndroidDriver._push_fonts):
4117         (ChromiumAndroidDriver._push_test_resources):
4118         (ChromiumAndroidDriver._run_adb_command):
4119         (ChromiumAndroidDriver._get_last_stacktrace):
4120         (ChromiumAndroidDriver._get_crash_log):
4121         (ChromiumAndroidDriver._start):
4122         (ChromiumAndroidDriver._start_once):
4123         (ChromiumAndroidDriver._start_once.deadlock_detector):
4124         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
4125         (ChromiumAndroidDriverTest.test_get_crash_log):
4126
4127 2012-09-04  Satish Sampath  <satish@chromium.org>
4128
4129         Run git commands within the checkout directory
4130         https://bugs.webkit.org/show_bug.cgi?id=95742
4131
4132         Reviewed by Eric Seidel.
4133
4134         git commands run from scm/git.py are sometimes run with cwd set to the
4135         checkout_root and other times with whatever directory was the default cwd.
4136         Instead all these should run with the checkout root set as the cwd
4137         (except where we explicitly need a different path)
4138
4139         * Scripts/webkitpy/common/checkout/scm/git.py:
4140         (Git._run_git):
4141         (Git.find_checkout_root):
4142         (Git.discard_local_commits):
4143         (Git.local_commits):
4144         (Git.working_directory_is_clean):
4145         (Git.clean_working_directory):
4146         (Git.add_list):
4147         (Git.delete_list):
4148         (Git.exists):
4149         (Git._current_branch):
4150         (Git._changes_files_for_commit):
4151         (Git.revisions_changing_file):
4152         (Git.svn_revision):
4153         (Git._run_git_svn_find_rev):
4154         (Git.contents_at_revision):
4155         (Git.diff_for_file):
4156         (Git.show_head):
4157         (Git.committer_email_for_revision):
4158         (Git.apply_reverse_diff):
4159         (Git.revert_files):
4160         (Git.commit_with_message):
4161         (Git._commit_on_branch):
4162         (Git.svn_commit_log):
4163         (Git.last_svn_commit_log):
4164         (Git.svn_blame):
4165         (Git._branch_ref_exists):
4166         (Git.delete_branch):
4167         (Git.remote_merge_base):
4168         (Git.commit_locally_with_message):
4169         (Git.push_local_commits_to_server):
4170         (Git.commit_ids_from_commitish_arguments):
4171         (Git.commit_message_for_local_commit):
4172         (Git.files_changed_summary_for_commit):
4173
4174 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
4175
4176         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
4177         https://bugs.webkit.org/show_bug.cgi?id=95734
4178
4179         Reviewed by Adam Barth.
4180
4181         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
4182         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
4183         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
4184         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
4185         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
4186         (MockWebRTCPeerConnectionHandler::createOffer):
4187         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
4188         (MockWebRTCPeerConnectionHandler):
4189         (MockWebRTCPeerConnectionHandler::taskList):
4190         (SuccessCallbackTask):
4191         (FailureCallbackTask):
4192
4193 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
4194
4195         [Chromium-Android] Output time and thread info in crash log
4196         https://bugs.webkit.org/show_bug.cgi?id=95768
4197
4198         Reviewed by Adam Barth.
4199
4200         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4201         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
4202
4203 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
4204
4205         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
4206         https://bugs.webkit.org/show_bug.cgi?id=95721
4207
4208         Reviewed by Adam Barth.
4209
4210         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
4211         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
4212         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
4213         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
4214         (MockWebMediaStreamCenter):
4215
4216 2012-09-04  Tony Chang  <tony@chromium.org>
4217
4218         Elide test names when running new-run-webkit-tests
4219         https://bugs.webkit.org/show_bug.cgi?id=95626
4220
4221         Reviewed by Dirk Pranke.
4222
4223         When the test name exceeds the number of terminal columns, it leaves
4224         text on the screen. Avoid this by eliding the test name when running
4225         tests. This is similar to what ninja does when compiling.
4226
4227         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
4228         (MeteredStream):
4229         (MeteredStream.number_of_columns): Helper method to get number of
4230         terminal columns. Won't work on Win32 python, but meh.
4231         * Scripts/webkitpy/layout_tests/views/printing.py:
4232         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
4233         because stderr appears to be ascii only.
4234         (Printer.print_started_test): Route through _test_status_line.
4235         (Printer.print_finished_test): Route through _test_status_line.
4236         (Printer._print_test_trace): Route through _test_status_line.
4237         (Printer._print_baseline): Route through _test_status_line.
4238         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4239         (test_test_status_line): Test for _test_status_line.
4240
4241 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
4242
4243         [GTK] Print API missing documentation when generating gtkdoc
4244         https://bugs.webkit.org/show_bug.cgi?id=95703
4245
4246         Reviewed by Carlos Garcia Campos.
4247
4248         Print out API missing documentation when generating gtkdoc. This makes it
4249         easier to fix documentation errors.
4250
4251         * gtk/generate-gtkdoc:
4252         (print_missing_api): Added.
4253         (generate_doc): Inline the rebase step, since it now reports an error
4254         when you try to rebase without generating documentation first.
4255         * gtk/gtkdoc.py:
4256         (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
4257         generating documentation first to enable a small cleanup at the caller.
4258         (GTKDoc.api_missing_documentation): Added.
4259
4260 2012-09-04  Vincent Scheib  <scheib@chromium.org>
4261
4262         [Chromium] Allow asyncronous response of pointer lock requests in layout tests.
4263         https://bugs.webkit.org/show_bug.cgi?id=95628
4264
4265         Reviewed by James Robinson.
4266
4267         Future tests need the ability to respond asynchronously that
4268         pointer lock requests have been accepted or rejected. This patch
4269         adds the following:
4270             testRunner.setPointerLockWillRespondAsynchronously();
4271             testRunner.didAcquirePointerLock();
4272             testRunner.didNotAcquirePointerLock();
4273
4274         Tested in existing test:
4275             pointerlockchange-pointerlockerror-events.html
4276
4277         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4278         (DRTTestRunner::DRTTestRunner):
4279         (DRTTestRunner::didAcquirePointerLock):
4280         (DRTTestRunner::didNotAcquirePointerLock):
4281         (DRTTestRunner::setPointerLockWillRespondAsynchronously):
4282         * DumpRenderTree/chromium/DRTTestRunner.h:
4283         (DRTTestRunner):
4284         * DumpRenderTree/chromium/WebViewHost.cpp:
4285         (WebViewHost::requestPointerLock):
4286         (WebViewHost::didAcquirePointerLock):
4287         (WebViewHost::didNotAcquirePointerLock):
4288         * DumpRenderTree/chromium/WebViewHost.h:
4289         (WebViewHost):
4290         (WebViewHost::setPointerLockWillRespondAsynchronously):
4291
4292 2012-09-04  Ojan Vafai  <ojan@chromium.org>
4293
4294         Move content shell bots to their own builder group
4295         https://bugs.webkit.org/show_bug.cgi?id=95765
4296
4297         Reviewed by Adam Barth.
4298
4299         In their current state of instability, they add too much noise. Once they get more stable,
4300         we can add them back to the regular group or just have them replace the other bots.
4301
4302         Also, fix the filter for Apple Windows bots since some of them are now "Apple Win ...".
4303
4304         * TestResultServer/static-dashboards/builders.js:
4305         (isWebkitTestRunner):
4306         (isChromiumContentShellTestRunner):
4307         (isChromiumWebkitTipOfTreeTestRunner):
4308         (loadBuildersList):
4309
4310 2012-09-03  Ryuan Choi  <ryuan.choi@samsung.com>
4311
4312         [EFL] Change the focus when the web view is clicked in MiniBrowser and EWebLauncher
4313         https://bugs.webkit.org/show_bug.cgi?id=95689
4314
4315         Reviewed by Kenneth Rohde Christiansen.
4316
4317         In Minibrowser & EWebLauncher, the web view loses the focus when url bar is clicked.
4318         So, there are bugs that key events are always generated in url bar although
4319         the user clicked the web view.
4320
4321         This patch recovers the focus of the web view when left button is pressed and
4322         adds for MiniBrowser to toggle the focus when middle button is pressed