[GTK] Add API to get the library version to WebKit2 GTK+
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Add API to get the library version to WebKit2 GTK+
4         https://bugs.webkit.org/show_bug.cgi?id=88426
5
6         Reviewed by Martin Robinson.
7
8         * gtk/generate-gtkdoc:
9         (get_webkit2_options): Add built sources to the list of files, but
10         ignore enum types and marshallers.
11
12 2012-06-07  Vincent Scheib  <scheib@chromium.org>
13
14         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
15         https://bugs.webkit.org/show_bug.cgi?id=88604
16
17         Reviewed by Kent Tamura.
18
19         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
20         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
21
22         * DumpRenderTree/chromium/WebViewHost.cpp:
23         (WebViewHost::requestPointerUnlock):
24
25 2012-06-08  Hans Wennborg  <hans@chromium.org>
26
27         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
28         https://bugs.webkit.org/show_bug.cgi?id=87976
29
30         Reviewed by Kent Tamura.
31
32         Provide a mock implementation of WebSpeechRecognizer for
33         DumpRenderTree. This will allow better testing of the API via layout
34         tests.
35
36         * DumpRenderTree/DumpRenderTree.gypi:
37         * DumpRenderTree/chromium/LayoutTestController.cpp:
38         (LayoutTestController::LayoutTestController):
39         (LayoutTestController::addMockSpeechRecognitionResult):
40         * DumpRenderTree/chromium/LayoutTestController.h:
41         (LayoutTestController):
42         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
43         (MockWebSpeechRecognizer::create):
44         (MockWebSpeechRecognizer::start):
45         (MockWebSpeechRecognizer::stop):
46         (MockWebSpeechRecognizer::abort):
47         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
48         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
49         (MockWebSpeechRecognizer::ResultTask::runIfValid):
50         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
51         (WebKit):
52         (MockWebSpeechRecognizer):
53         (MockWebSpeechRecognizer::addMockResult):
54         (MockWebSpeechRecognizer::taskList):
55         (ClientCallTask):
56         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
57         (ResultTask):
58         (MockWebSpeechRecognizer::ResultTask::ResultTask):
59         (NoMatchTask):
60         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
61         * DumpRenderTree/chromium/WebViewHost.cpp:
62         (WebViewHost::speechRecognizer):
63         * DumpRenderTree/chromium/WebViewHost.h:
64         (WebViewHost):
65         (WebViewHost::mockSpeechRecognizer):
66
67 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
68
69         check-webkit-style needs to be taught about <public/Foo.h>
70         https://bugs.webkit.org/show_bug.cgi?id=88524
71
72         Reviewed by David Levin.
73
74         * Scripts/webkitpy/style/checkers/cpp.py:
75         (_classify_include):
76         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
77         (OrderOfIncludesTest.test_public_primary_header):
78         (OrderOfIncludesTest.test_classify_include):
79
80 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
81
82         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
83         https://bugs.webkit.org/show_bug.cgi?id=67255
84
85         Reviewed by Dirk Pranke.
86
87         Implement pathToLocalResource to redirect file:///tmp URL's to
88         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
89         LayoutTests sub-directory of the WebKit source tree.
90
91         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
92         (LayoutTestController::pathToLocalResource):
93
94 2012-06-07  Tony Payne  <tpayne@chromium.org>
95
96         [chromium] Allow LayoutTests under new git workflow
97         https://bugs.webkit.org/show_bug.cgi?id=88575
98
99         On Windows, chromium indirects through git.bat. Adds the same hack that
100         is currently used for discovering svn.bat to support the new git
101         workflow.
102
103         Reviewed by Dirk Pranke.
104
105         * Scripts/webkitpy/common/checkout/scm/git.py:
106         (Git): Replaces all hard-coded references to 'git' with the class
107         variable executable_name.
108         (Git._check_git_architecture):
109         (Git.in_working_directory):
110         (Git.find_checkout_root):
111         (Git.read_git_config):
112         (Git.discard_local_commits):
113         (Git.local_commits):
114         (Git.working_directory_is_clean):
115         (Git.clean_working_directory):
116         (Git.status_command):
117         (Git.add_list):
118         (Git.delete_list):
119         (Git.exists):
120         (Git._current_branch):
121         (Git.changed_files):
122         (Git._changes_files_for_commit):
123         (Git.revisions_changing_file):
124         (Git.conflicted_files):
125         (Git.svn_revision):
126         (Git.create_patch):
127         (Git._run_git_svn_find_rev):
128         (Git.contents_at_revision):
129         (Git.diff_for_file):
130         (Git.show_head):
131         (Git.committer_email_for_revision):
132         (Git.apply_reverse_diff):
133         (Git.revert_files):
134         (Git.commit_with_message):
135         (Git._commit_on_branch):
136         (Git.svn_commit_log):
137         (Git.last_svn_commit_log):
138         (Git.svn_blame):
139         (Git._branch_ref_exists):
140         (Git.delete_branch):
141         (Git.remote_merge_base):
142         (Git.commit_locally_with_message):
143         (Git.push_local_commits_to_server):
144         (Git.commit_ids_from_commitish_arguments):
145         (Git.commit_message_for_local_commit):
146         (Git.files_changed_summary_for_commit):
147         * Scripts/webkitpy/common/host.py:
148         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
149         that duplicates the logic in the existing 'svn.bat' hack.
150
151 2012-06-07  Ojan Vafai  <ojan@chromium.org>
152
153         Style build architectures like build versions for non-layout test failures
154         https://bugs.webkit.org/show_bug.cgi?id=88590
155
156         Reviewed by Tony Chang.
157
158         Since we show the list of failing tests after the architecture, we want the
159         buildtype and architecture to be grouped together visually.
160
161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
162         (.effects a.failing-builder>span.architecture):
163
164 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
165
166         [Chromium] Remove header dependency of ImageDiff to WTF
167         https://bugs.webkit.org/show_bug.cgi?id=88422
168
169         Reviewed by Ryosuke Niwa.
170
171         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
172         * DumpRenderTree/chromium/ImageDiff.cpp:
173         (untestedCompareImages):
174
175 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
176
177         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
178         https://bugs.webkit.org/show_bug.cgi?id=88491
179
180         Reviewed by Dirk Pranke.
181
182         DRT should enable WebAudio when WebAudio feature is enabled,
183         so that the WebAudio feature could be tested by the Layouttest.
184
185         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
186         (LayoutTestController::overridePreference):
187
188 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
189
190         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
191         https://bugs.webkit.org/show_bug.cgi?id=88581
192
193         Reviewed by Ojan Vafai.
194
195         webkit-paptch rebaseline-expectations was ignoring what the
196         expected results for a test were and pulling down all the result
197         files from a bot. This could lead to us pulling down old,
198         incorrect .txt or .png files. With this patch we will now only
199         pull down expectations of the appropriate file types (so an
200         IMAGE failure will only pull the png and not the txt file).
201
202         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
203         (has_pixel_failures):
204         (suffixes_for_expectations):
205         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
206         (FunctionsTest.test_suffixes_for_expectations):
207         * Scripts/webkitpy/tool/commands/rebaseline.py:
208         (AbstractRebaseliningCommand.__init__):
209         (RebaselineExpectations._is_supported_port):
210         (RebaselineExpectations._update_expectations_file):
211         (RebaselineExpectations._tests_to_rebaseline):
212         (RebaselineExpectations._rebaseline_port):
213         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
214         (test_overrides_are_included_correctly):
215
216 2012-06-07  Ojan Vafai  <ojan@chromium.org>
217
218         Fix recent null pointer error regression in the flakiness dashboard
219         https://bugs.webkit.org/show_bug.cgi?id=88573
220
221         Reviewed by Dirk Pranke.
222
223         * TestResultServer/static-dashboards/builders.js:
224         (requestBuilderList):
225         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
226
227 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
228
229         Add Konrad Piascik to committers.py
230         https://bugs.webkit.org/show_bug.cgi?id=88560
231
232         Unreviewed.
233
234         * Scripts/webkitpy/common/config/committers.py:
235
236 2012-06-07  Tony Chang  <tony@chromium.org>
237
238         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
239         https://bugs.webkit.org/show_bug.cgi?id=77368
240
241         Reviewed by Ojan Vafai.
242
243         It doesn't look like we ever get a rect with width or height of 0.
244         I ran css1, css2.1, fast/forms, and tables without any crashes.
245
246         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
247         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
248
249 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
250
251         run-webkit-tests --lint-test-files gives an error when run on linux
252         https://bugs.webkit.org/show_bug.cgi?id=88551
253
254         Reviewed by Ojan Vafai.
255
256         We weren't mapping the expectations properly for the
257         google-chrome ports.
258
259         * Scripts/webkitpy/layout_tests/port/base.py:
260         (Port.path_to_test_expectations_file):
261         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
262         (TestGoogleChromePort.test_path_to_expectations):
263
264 2012-06-07  Daniel Erat  <derat@chromium.org>
265
266         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
267         https://bugs.webkit.org/show_bug.cgi?id=88263
268
269         Reviewed by Tony Chang.
270
271         * DumpRenderTree/chromium/LayoutTestController.cpp:
272         (LayoutTestController::LayoutTestController):
273         (LayoutTestController::reset):
274         (LayoutTestController::setTextSubpixelPositioning):
275         * DumpRenderTree/chromium/LayoutTestController.h:
276         (LayoutTestController):
277         * DumpRenderTree/chromium/fonts.conf:
278
279 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
280
281         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
282         https://bugs.webkit.org/show_bug.cgi?id=88060
283
284         Reviewed by Martin Robinson.
285
286         Spin the main loop before acquiring the pixel content. This ensures things
287         like late size allocations are finished before calling gtk_widget_draw,
288         avoiding assertions and subsequent empty pixel results.
289
290         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
291         (createBitmapContextFromWebView):
292
293 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
294
295         [Qt] Improve the visual of the viewport info box
296         https://bugs.webkit.org/show_bug.cgi?id=88410
297
298         Reviewed by Tor Arne Vestbø.
299
300         Improve the visual and make it possible to see the content more easy.
301
302         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
303
304 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
305
306         [EFL][WK2] Compile webkit1 and webkit2 by default.
307         https://bugs.webkit.org/show_bug.cgi?id=85041
308
309         Reviewed by Chang Shu.
310
311         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
312         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
313
314         * Scripts/build-webkit:
315
316 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
317
318         Unreviewed, rolling out r119662.
319         http://trac.webkit.org/changeset/119662
320         https://bugs.webkit.org/show_bug.cgi?id=88487
321
322         Broke builds (Requested by rniwa on #webkit).
323
324         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
325         * DumpRenderTree/chromium/ImageDiff.cpp:
326         (untestedCompareImages):
327
328 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
329
330         [Chromium] Remove header dependency of ImageDiff to WTF
331         https://bugs.webkit.org/show_bug.cgi?id=88422
332
333         Reviewed by Adam Barth.
334
335         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
336         * DumpRenderTree/chromium/ImageDiff.cpp:
337         (untestedCompareImages):
338
339 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
340
341         [WebKit] DeviceOrientation cleanup
342         https://bugs.webkit.org/show_bug.cgi?id=88406
343
344         Reviewed by Kent Tamura.
345
346         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
347
348         * DumpRenderTree/chromium/LayoutTestController.cpp:
349         (LayoutTestController::setMockDeviceOrientation):
350
351 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
352
353         webkitpy: add support for an ordered dict of test expectations
354         https://bugs.webkit.org/show_bug.cgi?id=87802
355
356         Reviewed by Ojan Vafai.
357
358         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
359         support a cascaded list of test expectations files. An easy way
360         to think of this is as an ordered dictionary of name -> contents
361         for files, where the name is usually a path on disk (I say
362         usually because we want to support other kinds of expectations
363         like the compile-time skips for unsupported features in
364         webkit.py, and we want to continue to support "in-memory" test
365         expectations that don't require a filesystem).
366
367         Conveniently there is an OrderedDict implementation in Python
368         2.7+ and it is available as a backport, so the first step in
369         adding this support is to use that implementation. Subsequent
370         patches will update the test_expectations.py module (and other
371         callers) to access the dict directly.
372
373         This patch just changes the base internal implementation and
374         provides wrappers for compatibility. The derived ports
375         (WebKitPort, TestPort, etc.) still need to be updated.
376
377         * Scripts/webkitpy/layout_tests/port/base.py:
378         (Port._expectations_dict):
379         (Port.test_expectations):
380         (Port):
381         (Port._expectations_overrides_dict):
382         (Port.test_expectations_overrides):
383         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
384         (PortTestCase.test_expectations_ordering):
385         (PortTestCase):
386         (PortTestCase.test_expectations_overrides_ordering):
387         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
388         (OrderedDict):
389         (OrderedDict.__init__):
390         (OrderedDict.clear):
391         (OrderedDict.__setitem__):
392         (OrderedDict.__delitem__):
393         (OrderedDict.__iter__):
394         (OrderedDict.__reversed__):
395         (OrderedDict.popitem):
396         (OrderedDict.__reduce__):
397         (OrderedDict.__repr__):
398         (OrderedDict.copy):
399         (OrderedDict.fromkeys):
400
401 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
402
403         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
404
405         * gtk/run-api-tests:
406         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
407
408 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
409
410         nrwt should look in 'out' for binaries on chromium win to support ninja
411         https://bugs.webkit.org/show_bug.cgi?id=88273
412
413         Reviewed by Tony Chang.
414
415         This patch standardizes the search algorithm the chromium ports
416         use to figure out which driver to run. We will look in a
417         chromium location before a webkit location (e.g., in
418         Source/WebKit/chromium/out before out/) and we will look in the
419         "legacy" directory (xcodebuild) before the directory ninja uses
420         (out).
421
422         Unfortunately due to the way the test code is set up testing the
423         properly requires some duplication of test code. I will fix that
424         in a followup patch.
425
426         * Scripts/webkitpy/layout_tests/port/chromium.py:
427         (ChromiumPort):
428         (ChromiumPort._static_build_path):
429         (ChromiumPort._build_path):
430         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
431         (ChromiumLinuxPort):
432         (ChromiumLinuxPort._determine_driver_path_statically):
433         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
434         (ChromiumLinuxPortTest.test_build_path):
435         (ChromiumLinuxPortTest):
436         (ChromiumLinuxPortTest.test_driver_name_option):
437         (ChromiumLinuxPortTest.path_to_image_diff):
438         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
439         (ChromiumMacPort):
440         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
441         (ChromiumMacPortTest.test_build_path):
442         (ChromiumMacPortTest):
443         (ChromiumMacPortTest.test_driver_name_option):
444         (ChromiumMacPortTest.path_to_image_diff):
445         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
446         (ChromiumPortTest.test_overrides_and_builder_names):
447         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
448         (ChromiumWinPort):
449         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
450         (ChromiumWinTest.test_build_path):
451         (ChromiumWinTest.test_operating_system):
452         (ChromiumWinTest):
453         (ChromiumWinTest.test_driver_name_option):
454         (ChromiumWinPortTest.path_to_image_diff):
455         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
456         (PortTestCase.assert_build_path):
457
458 2012-06-06  Jessie Berlin  <jberlin@apple.com>
459
460         Remove very red Windows WebKit2 testers
461         https://bugs.webkit.org/show_bug.cgi?id=88452
462
463         Reviewed by Steve Falkenburg.
464
465         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
466         need to focus on getting the WK1 testers green.
467
468         * BuildSlaveSupport/build.webkit.org-config/config.json:
469
470 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
471
472         get rebaselining tools to kinda work with the skia overrides file
473         https://bugs.webkit.org/show_bug.cgi?id=88456
474
475         Reviewed by Ryosuke Niwa.
476
477         Update rebaseline-expectations so that we read in the overrides
478         when looking for tests to rebaseline, but don't read in the
479         overrides when we are writing the expectations file back out.
480         This prevents the overrides from getting written into the main
481         file. This is kind of a hack but will have to do until we
482         support multiple expectations files properly.
483
484         * Scripts/webkitpy/tool/commands/rebaseline.py:
485         (RebaselineExpectations._expectations):
486         (RebaselineExpectations._update_expectations_file):
487         (RebaselineExpectations._tests_to_rebaseline):
488         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
489         (test_overrides_are_included_correctly):
490
491 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
492
493         webkitpy: two manager_worker_broker_unittest tests are broken
494         https://bugs.webkit.org/show_bug.cgi?id=88445
495
496         Reviewed by Ojan Vafai.
497
498         These tests were never updated when we removed the
499         --worker-model argument, and we were passing 'inline' instead of
500         1 (for the number of workers) :(. As a result we were creating
501         multiprocessing queues unnecessarily and that was failing on cygwin.
502
503         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
504         (InterfaceTest.test_managerconnection_is_abstract):
505         (InterfaceTest.test_workerconnection_is_abstract):
506
507 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
508
509         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
510         https://bugs.webkit.org/show_bug.cgi?id=87406
511
512         Reviewed by Dirk Pranke.
513
514         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
515         (TestExpectations.__init__):
516         * Scripts/webkitpy/tool/commands/rebaseline.py:
517         (RebaselineTest._update_expectations_file):
518         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
519         (test_rebaseline_does_not_include_overrides):
520
521 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
522
523         webkitpy: perf tests unit tests fail on chromium win
524         https://bugs.webkit.org/show_bug.cgi?id=88279
525
526         Reviewed by Ryosuke Niwa.
527
528         I'm seeing weird failures running the unit tests in my win32
529         checkout, and we don't really expect webpagereplay to work on
530         win32 anyway, so I'm skipping the import of that module for now
531         and adding a warning.
532
533         * Scripts/run-perf-tests:
534         * Scripts/webkitpy/performance_tests/perftest.py:
535
536 2012-06-06  Yong Li <yoli@rim.com>
537
538         Unreviewed. Update my email address in committers.py.
539
540         * Scripts/webkitpy/common/config/committers.py:
541
542 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
543
544         Add Robert Kroeger  to commiters.py
545         https://bugs.webkit.org/show_bug.cgi?id=88415
546
547         Unreviewed.
548
549         * Scripts/webkitpy/common/config/committers.py:
550
551 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
552
553         [EFL][DRT] http/tests/globalhistory testcases do not pass
554         https://bugs.webkit.org/show_bug.cgi?id=82579
555
556         Reviewed by Csaba Osztrogonác.
557
558         DRT has provided callbacks for ewk_view "global history delegate" signals.
559
560         * DumpRenderTree/efl/DumpRenderTree.cpp:
561         (isGlobalHistoryTest): Aux function to ident global history testcase.
562         (createLayoutTestController):
563         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
564         (DumpRenderTreeChrome::createView):
565         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
566         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
567         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
568         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
569         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
570         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
571         (DumpRenderTreeChrome):
572
573 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
574
575         [Qt] run-qtwebkit-tests hangs with -j1
576         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
577         This could happen due to an uncancelled timer after results were returned. This timer was
578         started only if --timeout was set.
579         https://bugs.webkit.org/show_bug.cgi?id=85475
580
581         Reviewed by Csaba Osztrogonác.
582
583         * Scripts/run-qtwebkit-tests:
584         (run_test):
585
586 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
587
588         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
589         https://bugs.webkit.org/show_bug.cgi?id=88327
590
591         Reviewed by Kenneth Rohde Christiansen.
592
593         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
594         * MiniBrowser/qt/icons/contents_width.png: Added.
595         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
596         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
597
598 2012-06-05  Jon Lee  <jonlee@apple.com>
599
600         Buildbot fix.
601
602         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
603         in the function. Store in a local variable.
604         (loadBuilderConfig):
605
606 2012-06-05  Jon Lee  <jonlee@apple.com>
607
608         Buildbot fix.
609
610         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
611         (loadBuilderConfig):
612
613 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
614
615         webkitpy: clean up win-specific path handling and tests
616         https://bugs.webkit.org/show_bug.cgi?id=88281
617
618         Reviewed by Adam Barth.
619
620         There was a bunch of inconsistent logic for handling path
621         conversions for win32 and cygwin paths due to us sometimes
622         looking at sys.platform and sometimes using mock hosts. This
623         patch cleans everything up so that we are required to pass
624         PlatformInfo objects to the path module and stop trying to do
625         different things when running on cygwin or win32 hosts (except
626         in the path_unittest module itself).
627
628         This may slightly reduce test coverage for the win32 code paths
629         but will be a lot easier to follow and maintain.
630
631         * Scripts/webkitpy/common/system/path.py:
632         (abspath_to_uri):
633         (_convert_path):
634         * Scripts/webkitpy/common/system/path_unittest.py:
635         (AbspathTest.platforminfo):
636         (AbspathTest.test_abspath_to_uri_cygwin):
637         (AbspathTest.test_abspath_to_uri_unixy):
638         (AbspathTest.test_abspath_to_uri_win):
639         (AbspathTest.test_abspath_to_uri_escaping_unixy):
640         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
641         (AbspathTest.test_stop_cygpath_subprocess):
642         * Scripts/webkitpy/common/system/platforminfo.py:
643         (PlatformInfo.__init__):
644         (PlatformInfo.is_cygwin):
645         * Scripts/webkitpy/common/system/platforminfo_mock.py:
646         (MockPlatformInfo.is_cygwin):
647         * Scripts/webkitpy/layout_tests/port/base.py:
648         (Port.to.show_results_html_file):
649         * Scripts/webkitpy/layout_tests/port/driver.py:
650         (Driver.test_to_uri):
651         (Driver.uri_to_test):
652         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
653         (DriverTest.test_test_to_uri):
654         (DriverTest.test_uri_to_test):
655         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
656         (MockDRTPortTest.make_port):
657         (MockDRTTest.input_line):
658         (MockChromiumDRTTest.test_pixeltest__fails):
659         * Scripts/webkitpy/layout_tests/port/test.py:
660         * Scripts/webkitpy/layout_tests/port/win.py:
661         (WinPort.show_results_html_file):
662         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
663         (MainTest.test_unexpected_failures):
664         (MainTest.test_results_directory_absolute):
665         (MainTest.test_results_directory_default):
666         (MainTest.test_results_directory_relative):
667
668 2012-06-05  Jon Lee  <jonlee@apple.com>
669
670         Workaround buildbot bug when merging build requests.
671         https://bugs.webkit.org/show_bug.cgi?id=88158
672
673         Reviewed by Mark Rowe.
674
675         For expediency, we still want testers to pick the latest build to test, but to ensure
676         that the builders are reporting the correct revision number, we should let the building bots
677         run as they normally would. That is, the builder picks the oldest revision, and merges
678         subsequent requests. Because merged requests get appended to the list of changes for a given
679         build, the last change in that list is also the latest change. When we used pickLatestBuild
680         for the builders, this was not the case (it would always report the penultimate change).
681
682         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
683
684         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
685         for all Apple builders.
686         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
687         the latest build to run.
688         (loadBuilderConfig):
689
690 2012-06-05  Jessie Berlin  <jberlin@apple.com>
691
692         [Win] DumpRenderTree should call resetInternalsObject
693         https://bugs.webkit.org/show_bug.cgi?id=88346
694
695         Reviewed by Simon Fraser.
696
697         Invoke it on Windows in the same place it is invoked on Mac.
698
699         * DumpRenderTree/win/DumpRenderTree.cpp:
700         (resetWebViewToConsistentStateBeforeTesting):
701
702 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
703
704         [GTK] Fix two more memory leaks in DRT
705         https://bugs.webkit.org/show_bug.cgi?id=88255
706
707         Reviewed by Martin Robinson.
708
709         Fixed memory leaks in GTK's DRT code.
710
711         * DumpRenderTree/gtk/DumpRenderTree.cpp:
712         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
713         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
714         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
715         (createBitmapContextFromWebView): Free the cairo surface.
716
717 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
718
719         [Qt] Building when a top directory is named Source
720         https://bugs.webkit.org/show_bug.cgi?id=77727
721
722         Reviewed by Tor Arne Vestbø.
723
724         Change regex to only replace the last instance of OUT_PWD.
725
726         * qmake/mkspecs/features/default_pre.prf:
727
728 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
729
730         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
731         https://bugs.webkit.org/show_bug.cgi?id=73176
732
733         Reviewed by Adam Barth.
734
735         Two more APIs are added in Custom Scheme Handler specification.
736         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
737         One is 'isProtocolHandlerRegistered' to query whether the specific URL
738         is registered or not.
739         The other is 'unregisterProtocolHandler' to remove the registered URL.
740
741         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
742
743 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
744
745         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
746         https://bugs.webkit.org/show_bug.cgi?id=83879
747
748         Reviewed by Carlos Garcia Campos.
749
750         Make minibrowser connect to the new 'permission requests' signal
751         to allow users handle the Geolocation permission requests.
752
753         * MiniBrowser/gtk/BrowserWindow.c:
754         (geolocationRequestDialogCallback): Callback for the dialog asking
755         the user for allowing or not geolocation permission requests.
756         (webViewDecidePermissionRequest): Launch a dialog to ask the user
757         whether to allow or deny geolocation permission requests.
758         (browserWindowConstructed): Connect to 'permission-request' signal.
759
760 2012-06-04  Chase Phillips  <cmp@google.com>
761
762         Make a builder group support+expect multiple loads.
763         https://bugs.webkit.org/show_bug.cgi?id=88260
764
765         Change BuilderGroup to allow expecting multiple
766         loads.  This allows merging results for a given set
767         of builders into one group.
768
769         Add a test that verifies that the group count
770         increments correctly based on successful and failed
771         list loads.
772
773         Reviewed by Ojan Vafai.
774
775         * TestResultServer/static-dashboards/builders.js:
776         (BuilderGroup):
777         (BuilderGroup.prototype.setbuilder):
778         (BuilderGroup.prototype.append):
779         (BuilderGroup.prototype.loaded):
780         (requestBuilderList.xhr.onload):
781         (requestBuilderList.xhr.onerror):
782         (onErrorLoadingBuilderList):
783         (loadBuildersList):
784         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
785         (test):
786         * TestResultServer/static-dashboards/run-unittests.html:
787
788 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
789
790         Python test fix attempt for Chromium Windows.
791
792         * Scripts/webkitpy/layout_tests/port/driver.py:
793         (Driver.uri_to_test):
794
795 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
796
797         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
798         https://bugs.webkit.org/show_bug.cgi?id=88243
799
800         Reviewed by Adam Barth.
801
802         * qmake/mkspecs/features/features.prf:
803
804 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
805
806         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
807         https://bugs.webkit.org/show_bug.cgi?id=88280
808
809         Unreviewed, build fix.
810
811         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
812         (TestServerProcess.test_basic):
813
814 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
815
816         test-webkitpy is hanging under cygwin
817         https://bugs.webkit.org/show_bug.cgi?id=88269
818
819         Reviewed by Ryosuke Niwa.
820
821         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
822         so we need to skip any tests that use it.
823
824         * Scripts/webkitpy/common/system/executive.py:
825         (Executive.run_in_parallel):
826         * Scripts/webkitpy/common/system/executive_unittest.py:
827         (ExecutiveTest.test_run_in_parallel):
828
829 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
830
831         test-webkitpy is failing on win32 after r115054
832         https://bugs.webkit.org/show_bug.cgi?id=88264
833
834         Reviewed by Ryosuke Niwa.
835
836         The failing http_server test was improperly suppressed (the
837         tuple was missing a comma, and so wasn't a tuple at all, just a
838         string) and so we were skipping *all* tests on win32. The right
839         way to skip a single test is to disable it inside the test
840         itself.
841
842         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
843         (TestHttpServer.test_start_cmd):
844         * Scripts/webkitpy/test/test_finder.py:
845         (TestFinder._default_names):
846         * Scripts/webkitpy/test/main.py:
847         (Tester.run): Add error message if we don't find any tests to run.
848         * Scripts/webkitpy/test/main_unittest.py:
849             
850
851 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
852
853         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
854         https://bugs.webkit.org/show_bug.cgi?id=88215
855
856         Reviewed by Martin Robinson.
857
858         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
859         for newly allocated strings.
860
861         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
862         (attributeSetToString):
863         (AccessibilityUIElement::allAttributes):
864
865 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
866
867         [GTK] Memory leaks in DumpRenderTree.cpp
868         https://bugs.webkit.org/show_bug.cgi?id=88213
869
870         Reviewed by Martin Robinson.
871
872         Fixed memory leaks in DumpRenderTree.
873
874         * DumpRenderTree/gtk/DumpRenderTree.cpp:
875         (appendString): Accepts const gchar* as the second argument.
876         (dumpFramesAsText): Free the string returned by g_strdup_printf().
877         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
878
879 2012-06-04  David Dorwin  <ddorwin@chromium.org>
880
881         Enable Chromium media player to instantiate a plugin
882         https://bugs.webkit.org/show_bug.cgi?id=87399
883
884         Reviewed by Kent Tamura.
885
886         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
887
888         * DumpRenderTree/chromium/WebViewHost.cpp:
889         (WebViewHost::createPopupMenu):
890
891 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
892
893         [GTK][WK2] Implement geolocation provider for the GTK port
894         https://bugs.webkit.org/show_bug.cgi?id=83877
895
896         Reviewed by Carlos Garcia Campos.
897
898         * gtk/generate-gtkdoc:
899         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
900
901 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
902
903         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
904         https://bugs.webkit.org/show_bug.cgi?id=87668
905
906         Reviewed by Ryosuke Niwa.
907
908         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
909         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
910         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
911
912         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
913         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
914
915 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
916
917         [EFL] Refactor ewk_view_context_paint code.
918         https://bugs.webkit.org/show_bug.cgi?id=85588
919
920         Reviewed by Hajime Morita.
921
922         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
923
924 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
925
926         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
927         https://bugs.webkit.org/show_bug.cgi?id=87869
928
929         Reviewed by Andreas Kling.
930
931         Replace %lld by PRId64 macro to print an int64_t value and silent a
932         compilation warning on 64-Bit.
933
934         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
935         (onExceededApplicationCacheQuota):
936
937 2012-06-03  Varun Jain  <varunjain@google.com>
938
939         [chromium] Add new gesture type (two finger tap) that triggers context menu.
940         https://bugs.webkit.org/show_bug.cgi?id=88173
941
942         Reviewed by Adam Barth.
943
944         * DumpRenderTree/chromium/EventSender.cpp:
945         (EventSender::EventSender):
946         (EventSender::gestureTwoFingerTap):
947         (EventSender::gestureEvent):
948         * DumpRenderTree/chromium/EventSender.h:
949         (EventSender):
950
951 2012-06-02  Zeno Albisser  <zeno@webkit.org>
952
953         Fix and enable WebGL for WebKit2 on Qt.
954         https://bugs.webkit.org/show_bug.cgi?id=86214
955
956         Enable WebGL by default for Qt MiniBrowser.
957
958         Reviewed by Noam Rosenthal.
959
960         * MiniBrowser/qt/qml/BrowserWindow.qml:
961
962 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
963
964         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
965         https://bugs.webkit.org/show_bug.cgi?id=88164
966
967         Reviewed by Kentaro Hara.
968
969         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
970         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
971
972         * Scripts/VCSUtils.pm:
973         (adjustPathForRecentRenamings):
974         (fixChangeLogPatch):
975
976 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
977
978         Rename test_expectations.txt to TestExpectations
979         https://bugs.webkit.org/show_bug.cgi?id=86690
980
981         Reviewed by Dirk Pranke.
982
983         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
984         We can the code to read test_expectations.txt once we've successfully transitioned.
985
986         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
987         (TestExpectationParser._check_path_does_not_exist):
988         (TestExpectationParser._tokenize):
989         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
990         * Scripts/webkitpy/layout_tests/port/base.py:
991         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
992         test_expectations.txt if one exists and the path to TestExpectations otherwise.
993         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
994         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
995         virtual.
996         * Scripts/webkitpy/layout_tests/port/chromium.py:
997         (ChromiumPort.path_from_chromium_base):
998         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
999         (ChromiumAndroidPort.test_expectations):
1000         * Scripts/webkitpy/layout_tests/port/test.py:
1001         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
1002         (TestPort.__init__):
1003         * Scripts/webkitpy/layout_tests/port/webkit.py:
1004         (WebKitPort.baseline_search_path):
1005         (WebKitPort.test_expectations):
1006         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
1007         tests to base as a follow up.
1008         (WebKitPortTest.test_path_to_test_expectations_file):
1009         (test_test_expectations):
1010         (test_legacy_test_expectations):
1011         * Scripts/webkitpy/style/checker.py:
1012         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
1013         with one for TestExpectations.
1014         * Scripts/webkitpy/style/checkers/test_expectations.py:
1015         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
1016         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1017         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
1018         test_expectations.txt.
1019         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1020         (TestExpectationsTestCase.assert_lines_lint):
1021         * Scripts/webkitpy/tool/commands/queries.py:
1022         (PrintExpectations.__init__):
1023         * Scripts/webkitpy/tool/commands/rebaseline.py:
1024         (RebaselineExpectations):
1025         * Scripts/webkitpy/tool/steps/commit.py:
1026         (Commit._check_test_expectations):
1027         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1028         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
1029         (CommitTest.test_check_test_expectations): For TestExpectations.
1030         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
1031         * TestResultServer/static-dashboards/dashboard_base.js:
1032         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
1033         Error only when neither exists.
1034         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1035         (processMissingAndExtraExpectations):
1036         (htmlForTestsWithExpectationsButNoFailures):
1037         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1038
1039 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
1040
1041         Remove dependency from ImageDiff to WTF
1042         https://bugs.webkit.org/show_bug.cgi?id=88147
1043
1044         Reviewed by Adam Barth.
1045
1046         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1047
1048 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1049
1050         NRWT seems to leak (more?) temp dirs
1051         https://bugs.webkit.org/show_bug.cgi?id=88126
1052
1053         Re-land r119297 with chromium fix (weren't calling the
1054         super() method if not in --test-shell mode in start().
1055         Add unit tests to chromium_unittest as well to check.
1056
1057         * Scripts/webkitpy/layout_tests/port/chromium.py:
1058         (ChromiumDriver.start):
1059         * Scripts/webkitpy/layout_tests/port/webkit.py:
1060         (WebKitDriver.__del__):
1061         (WebKitDriver._start):
1062         (WebKitDriver.run_test):
1063         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1064         (WebKitDriverTest.test_check_for_driver_crash):
1065         (WebKitDriverTest.test_stop_cleans_up_properly):
1066         (WebKitDriverTest):
1067         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1068         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1069         (ChromiumDriverTest.test_stop_cleans_up_properly):
1070         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
1071
1072 2012-06-01  Tim Horton  <timothy_horton@apple.com>
1073
1074         Lots of "failed download-built-product" on Apple bots
1075         https://bugs.webkit.org/show_bug.cgi?id=88158
1076
1077         Reviewed by Jessie Berlin.
1078         
1079         Disable mergeRequests on all Apple builders. This is a speculative fix.
1080
1081         * BuildSlaveSupport/build.webkit.org-config/config.json:
1082
1083 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1084
1085         Unreviewed, rolling out r119297.
1086         http://trac.webkit.org/changeset/119297
1087         https://bugs.webkit.org/show_bug.cgi?id=88156
1088
1089         May have broken Chromium bots (Requested by rniwa on #webkit).
1090
1091         * Scripts/webkitpy/layout_tests/port/webkit.py:
1092         (WebKitDriver.__del__):
1093         (WebKitDriver.run_test):
1094         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1095         (WebKitDriverTest.test_check_for_driver_crash):
1096         (WebKitDriverTest.test_stop_cleans_up_properly):
1097
1098 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1099
1100         nrwt seems to leak tmpdirs
1101         https://bugs.webkit.org/show_bug.cgi?id=88126
1102
1103         Reviewed by Ojan Vafai.
1104
1105         Fix leak possibly introduced in r118979 - we now will
1106         make sure we clean up any stale temp directories during the
1107         start routine and attempt to clean up again in __del__. It
1108         turns out that asserting in __del__ logs a message but is
1109         caught by the runtime, so it's mostly useless.
1110
1111         * Scripts/webkitpy/layout_tests/port/webkit.py:
1112         (WebKitDriver.__del__):
1113         (WebKitDriver._start):
1114         (WebKitDriver.run_test):
1115         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1116         (WebKitDriverTest.test_check_for_driver_crash):
1117         (WebKitDriverTest.test_stop_cleans_up_properly):
1118         (WebKitDriverTest):
1119         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1120
1121 2012-06-01  Michael Saboff  <msaboff@apple.com>
1122
1123         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
1124         https://bugs.webkit.org/show_bug.cgi?id=88109
1125
1126         Reviewed by Geoffrey Garen.
1127
1128         Additional test case.
1129
1130         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1131         (TestWebKitAPI::TEST):
1132
1133 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
1134
1135         [Qt] Use -Werror only in developer builds
1136
1137         Rubber-stamped by Tor Arne Vestbø.
1138
1139         In production builds -Werror with custom toolchains and wierd system
1140         headers, -Werror is of no use and just creates confusion. So use it
1141         only if Qt is configured with -developer-build.
1142
1143         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
1144         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
1145         only if qt_developer_build is set.
1146
1147 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
1148
1149         [watchlist] Add myself to loader and v8 bindings changes
1150         https://bugs.webkit.org/show_bug.cgi?id=88112
1151
1152         Reviewed by Adam Barth.
1153
1154         * Scripts/webkitpy/common/config/watchlist:
1155
1156 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
1157
1158         Adding Jacky Jiang to committers.py
1159         https://bugs.webkit.org/show_bug.cgi?id=88122
1160
1161         Reviewed by Rob Buis.
1162
1163         Adding myself to committers.py as a Committer.
1164
1165         * Scripts/webkitpy/common/config/committers.py:
1166
1167 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1168
1169         Fix Windows build.
1170
1171         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1172
1173 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1174
1175         Windows WK2 MouseMoveAfterCrash API test failing
1176         https://bugs.webkit.org/show_bug.cgi?id=69982
1177
1178         Disable the test on Windows to get the bots greener.
1179
1180         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1181         (TestWebKitAPI::TEST):
1182
1183 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1184
1185         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
1186         https://bugs.webkit.org/show_bug.cgi?id=86866
1187
1188         Reviewed by Adam Barth.
1189
1190         Catch new "intent,service,register" signal on the frame and print out
1191         information about the Web Intent service in EFL's DumpRenderTree.
1192
1193         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1194         (DumpRenderTreeChrome::createView):
1195         (DumpRenderTreeChrome::onFrameCreated):
1196         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
1197         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1198         (DumpRenderTreeChrome):
1199
1200 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
1201
1202         The ChangeLog parser cannot handle reviewers with initials in their name
1203         https://bugs.webkit.org/show_bug.cgi?id=87864
1204
1205         Reviewed by Ryosuke Niwa.
1206
1207         Add support in the ChangeLog parser for reviewer names that have
1208         initials in them.
1209
1210         * Scripts/webkitpy/common/checkout/changelog.py:
1211         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
1212         in the replacement string. This allows for matching the word characters before a
1213         period, without totally throwing them away.
1214         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
1215         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1216         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
1217
1218 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1219
1220         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
1221         https://bugs.webkit.org/show_bug.cgi?id=86865
1222
1223         Reviewed by Adam Barth.
1224
1225         Add deliverWebIntent method to LayoutTestController and provide
1226         implementation for EFL port.
1227
1228         * DumpRenderTree/LayoutTestController.cpp:
1229         (deliverWebIntentCallback):
1230         (LayoutTestController::staticFunctions):
1231         * DumpRenderTree/LayoutTestController.h:
1232         (LayoutTestController):
1233         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1234         (LayoutTestController::deliverWebIntent):
1235         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1236         (LayoutTestController::deliverWebIntent):
1237         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1238         (LayoutTestController::deliverWebIntent):
1239         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1240         (LayoutTestController::deliverWebIntent):
1241         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1242         (LayoutTestController::deliverWebIntent):
1243         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1244         (LayoutTestController::deliverWebIntent):
1245
1246 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1247
1248         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
1249
1250         Reviewed by Simon Hausmann.
1251
1252         * Tools.pro:
1253
1254 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1255
1256         Add public page loading performance tests using web-page-replay
1257         https://bugs.webkit.org/show_bug.cgi?id=84008
1258
1259         Reviewed by Dirk Pranke.
1260
1261         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
1262         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
1263         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
1264
1265         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
1266         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
1267         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
1268         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
1269
1270         * Scripts/webkitpy/layout_tests/port/driver.py:
1271         (Driver.is_external_http_test): Added.
1272         * Scripts/webkitpy/layout_tests/port/webkit.py:
1273         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
1274         * Scripts/webkitpy/performance_tests/perftest.py:
1275         (PerfTest.__init__): Takes port.
1276         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
1277         (PerfTest):
1278         (PerfTest.run): Calls run_single.
1279         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
1280         (ChromiumStylePerfTest.__init__):
1281         (PageLoadingPerfTest.__init__):
1282         (PageLoadingPerfTest.run):
1283         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
1284         (ReplayServer.__init__):
1285         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
1286         but it caused a dead lock on some web pages.
1287         (ReplayServer.stop):
1288         (ReplayServer.__del__):
1289         (ReplayPerfTest):
1290         (ReplayPerfTest.__init__):
1291         (ReplayPerfTest._start_replay_server):
1292         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
1293         The subsequent runs of the same test will just use test.wpr.
1294         (ReplayPerfTest.run_single):
1295         (PerfTestFactory):
1296         (PerfTestFactory.create_perf_test):
1297         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1298         (MainTest.test_parse_output):
1299         (MainTest.test_parse_output_with_failing_line):
1300         (TestPageLoadingPerfTest.test_run):
1301         (TestPageLoadingPerfTest.test_run_with_bad_output):
1302         (TestReplayPerfTest):
1303         (TestReplayPerfTest.ReplayTestPort):
1304         (TestReplayPerfTest.ReplayTestPort.__init__):
1305         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
1306         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
1307         (TestReplayPerfTest.ReplayTestPort._driver_class):
1308         (TestReplayPerfTest.MockReplayServer):
1309         (TestReplayPerfTest.MockReplayServer.__init__):
1310         (TestReplayPerfTest.MockReplayServer.stop):
1311         (TestReplayPerfTest._add_file):
1312         (TestReplayPerfTest._setup_test):
1313         (TestReplayPerfTest.test_run_single):
1314         (TestReplayPerfTest.test_run_single.run_test):
1315         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
1316         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
1317         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
1318         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
1319         (TestReplayPerfTest.test_prepare):
1320         (TestReplayPerfTest.test_prepare.run_test):
1321         (TestReplayPerfTest.test_prepare_calls_run_single):
1322         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
1323         (TestPerfTestFactory.test_regular_test):
1324         (TestPerfTestFactory.test_inspector_test):
1325         (TestPerfTestFactory.test_page_loading_test):
1326         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1327         (PerfTestsRunner):
1328         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
1329         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
1330         (PerfTestsRunner._collect_tests._is_test_file):
1331         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
1332         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1333         (create_runner):
1334         (run_test):
1335         (_tests_for_runner):
1336         (test_run_test_set):
1337         (test_run_test_set_kills_drt_per_run):
1338         (test_run_test_pause_before_testing):
1339         (test_run_test_set_for_parser_tests):
1340         (test_run_test_set_with_json_output):
1341         (test_run_test_set_with_json_source):
1342         (test_run_test_set_with_multiple_repositories):
1343         (test_run_with_upload_json):
1344         (test_upload_json):
1345         (test_upload_json.MockFileUploader.upload_single_text_file):
1346         (_add_file):
1347         (test_collect_tests):
1348         (test_collect_tests_with_multile_files):
1349         (test_collect_tests_with_multile_files.add_file):
1350         (test_collect_tests_with_skipped_list):
1351         (test_collect_tests_with_page_load_svg):
1352         (test_collect_tests_should_ignore_replay_tests_by_default):
1353         (test_collect_tests_with_replay_tests):
1354         (test_parse_args):
1355         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
1356         (AutoinstallImportHook.find_module):
1357         (AutoinstallImportHook._install_webpagereplay):
1358
1359 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
1360
1361         Support building the Android port of chromium with Ninja
1362         https://bugs.webkit.org/show_bug.cgi?id=87545
1363
1364         Reviewed by Adam Barth.
1365
1366         Ensures that shared libraries are looked up in a generator-agnostic
1367         way and that output is placed in the correct directory.
1368
1369         Depends on http://codereview.chromium.org/10386188/
1370
1371         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1372
1373 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
1374
1375         [Chromium] Chromium DRT should be able to load external resources
1376         https://bugs.webkit.org/show_bug.cgi?id=87893
1377
1378         Reviewed by Dirk Pranke.
1379
1380         Allow external resources to be loaded when the main frame's URL is also an external resource.
1381         This change is analogous to r118231 for Mac port.
1382
1383         * DumpRenderTree/chromium/WebViewHost.cpp:
1384         (blockRequest):
1385         (isLocalhost):
1386         (hostIsUsedBySomeTestsToGenerateError):
1387         (WebViewHost::willSendRequest):
1388
1389 2012-05-31  Anders Carlsson  <andersca@apple.com>
1390
1391         Build fixes.
1392
1393         Disable the C++11 extensions warning.
1394
1395         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1396         * TestWebKitAPI/Configurations/Base.xcconfig:
1397         * WebKitTestRunner/Configurations/Base.xcconfig:
1398
1399 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
1400
1401         [WK2] window.internals settings are not reset between tests
1402         https://bugs.webkit.org/show_bug.cgi?id=87783
1403
1404         Reviewed by Mihai Parparita.
1405
1406         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1407         (WTR::InjectedBundle::done): Call resetAfterTest().
1408
1409         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1410         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
1411         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
1412         This needs to be done after a tets, because the code assumes that there is an object
1413         with this name in global scope.
1414
1415         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1416
1417 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1418
1419         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
1420         https://bugs.webkit.org/show_bug.cgi?id=85006
1421
1422         Reviewed by Tor Arne Vestbø.
1423
1424         Added navigation_policy_decision implementation for DumpRenderTreeView.
1425         Added LayoutTestController::setCustomPolicyDelegate implementation.
1426         Modified LayoutTestController::waitForPolicyDelegate.
1427
1428         * DumpRenderTree/efl/DumpRenderTree.cpp:
1429         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1430         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1431         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1432         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1433         (navigationTypeToString): aux function
1434         (onNavigationPolicyDecision): navigation_policy_decision implementation
1435         (drtViewAdd):
1436         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1437         (LayoutTestController::setCustomPolicyDelegate):
1438         (LayoutTestController::waitForPolicyDelegate):
1439
1440 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1441
1442         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
1443         https://bugs.webkit.org/show_bug.cgi?id=86195
1444
1445         Reviewed by Gustavo Noronha Silva.
1446
1447         Implement clearApplicationCacheForOrigin in EFL
1448         LayoutTestController.
1449
1450         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1451         (LayoutTestController::clearApplicationCacheForOrigin):
1452
1453 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1454
1455         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
1456         https://bugs.webkit.org/show_bug.cgi?id=87955
1457
1458         Reviewed by Simon Hausmann.
1459
1460         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1461         * DumpRenderTree/qt/EventSenderQt.cpp:
1462         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1463         * DumpRenderTree/qt/main.cpp:
1464         * QtTestBrowser/cookiejar.cpp:
1465         * QtTestBrowser/launcherwindow.cpp:
1466         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1467         * qmake/mkspecs/features/default_post.prf:
1468
1469 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
1470
1471         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
1472
1473         Rubber-stamped by Kenneth Rohde Christiansen.
1474
1475         * qmake/config.tests/libpng/libpng.pro:
1476
1477 2012-05-30  Peter Beverloo  <peter@chromium.org>
1478
1479         [Chromium] Automatically install 64-bit linker for Android
1480         https://bugs.webkit.org/show_bug.cgi?id=79780
1481
1482         Reviewed by Adam Barth.
1483
1484         Change the update-webkit-chromium script to check whether the 64-bit
1485         linker needs to be installed as part of the update process. The actual
1486         code for doing these checks and "installing" it has been added to the
1487         webkitdirs.pm script.
1488
1489         The linker itself is part of the third_party/aosp repository, which
1490         will be pulled in through the DEPS change.
1491
1492         * Scripts/update-webkit-chromium:
1493         * Scripts/webkitdirs.pm:
1494         (chromiumInstall64BitAndroidLinkerIfNeeded):
1495         (chromiumReplaceAndroidLinkerIfNeeded):
1496
1497 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1498
1499         https://bugs.webkit.org/show_bug.cgi?id=87803
1500         Layout tests often fail trying to stat nonexistent logs 
1501
1502         Reviewed by Dirk Pranke.
1503
1504         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
1505         try/catch block around accessing the logs as a precaution.
1506
1507         * Scripts/webkitpy/common/system/crashlogs.py:
1508         (CrashLogs._find_newest_log_darwin):
1509
1510 2012-05-30  Gavin Peters  <gavinp@chromium.org>
1511
1512         Add a LayoutTest for prerender remove after stop.
1513         https://bugs.webkit.org/show_bug.cgi?id=87860
1514
1515         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
1516         can be tested by LayoutTests now.
1517
1518         Reviewed by Adam Barth.
1519
1520         * DumpRenderTree/DumpRenderTree.gypi:
1521         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
1522         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
1523         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
1524         (MockWebPrerenderingSupport::add):
1525         (MockWebPrerenderingSupport::cancel):
1526         (MockWebPrerenderingSupport::abandon):
1527         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
1528         (MockWebPrerenderingSupport):
1529         * DumpRenderTree/chromium/TestShell.cpp:
1530         (TestShell::initialize):
1531         * DumpRenderTree/chromium/TestShell.h:
1532         (TestShell):
1533         * DumpRenderTree/chromium/WebViewHost.cpp:
1534         (WebViewHost::willAddPrerender):
1535         (WebViewHost::setWebWidget):
1536         * DumpRenderTree/chromium/WebViewHost.h:
1537         (WebViewHost):
1538
1539 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1540
1541         https://bugs.webkit.org/show_bug.cgi?id=87717
1542         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
1543
1544         Reviewed by Dirk Pranke.
1545
1546         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
1547         If there isn't a crash log found for the process add a message saying
1548         the process was unresponsive.
1549
1550         * Scripts/webkitpy/layout_tests/port/webkit.py:
1551         (WebKitDriver.__init__):
1552         (WebKitDriver._check_for_driver_crash):
1553         (WebKitDriver.run_test):
1554         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1555         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
1556         (WebKitDriverTest):
1557         (WebKitDriverTest.test_check_for_driver_crash):
1558         * WebKitTestRunner/TestController.cpp:
1559         (WTR):
1560         (WTR::TestController::runTest):
1561
1562 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1563
1564         https://bugs.webkit.org/show_bug.cgi?id=87714
1565         Mac crash logs can take a really long time to be written out.
1566
1567         Reviewed by Dirk Pranke.
1568
1569         Make a second pass looking for crash logs after the tests have completed running.
1570
1571         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1572         (use_trac_links_in_results_html):
1573         (Manager.run):
1574         * Scripts/webkitpy/layout_tests/port/base.py:
1575         (Port.repository_paths):
1576         (Port.look_for_new_crash_logs):
1577         * Scripts/webkitpy/layout_tests/port/mac.py:
1578         (MacPort.look_for_new_crash_logs):
1579         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1580         (test_get_crash_log):
1581         (test_look_for_new_crash_logs):
1582         (test_look_for_new_crash_logs.fake_time_cb):
1583
1584 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1585
1586         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
1587
1588         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1589         (LayoutWebViewEventHandler::OnAlertEvent):
1590         (LayoutWebViewEventHandler::OnConfirmEvent):
1591         (LayoutWebViewEventHandler):
1592         (LayoutWebViewEventHandler::OnPromptEvent):
1593         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1594         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
1595
1596 2012-05-30  Ojan Vafai  <ojan@chromium.org>
1597
1598         Only give lint errors for -expected.png png files that lack a checksum
1599         https://bugs.webkit.org/show_bug.cgi?id=87875
1600
1601         Reviewed by Tony Chang.
1602
1603         We have other pngs in the tree, e.g. for the inspector, that legitimately
1604         lack a checksum.
1605
1606         * Scripts/webkitpy/style/checkers/png.py:
1607         (PNGChecker.check):
1608         * Scripts/webkitpy/style/checkers/png_unittest.py:
1609         (PNGCheckerTest.test_check):
1610
1611 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
1612
1613         nrwt: seems to leak temp dirs
1614         https://bugs.webkit.org/show_bug.cgi?id=87795
1615
1616         Reviewed by Ojan Vafai.
1617
1618         There appears to be a bug where the chromium bots are creating
1619         temporary directories and not cleaning them up that started
1620         after the switch to WebKitDriver. It's possible that __del__
1621         wasn't getting called in a timely manner (or at all), and it's
1622         generally bad style to rely on __del__ being called, so this
1623         code changes things so that we create a temp dir in
1624         driver.start() and remove it in driver.stop(). We could be
1625         paranoid and leave the __del__ code in, but there doesn't seem
1626         to be much advantage to it. If there are bugs that result in
1627         drivers being started but not stopped, we have other problems.
1628
1629         * Scripts/webkitpy/common/system/filesystem_mock.py:
1630         (MockFileSystem.__init__):
1631         (MockFileSystem._mktemp):
1632         (MockFileSystem.mkdtemp):
1633         * Scripts/webkitpy/layout_tests/port/webkit.py:
1634         (WebKitDriver.__init__):
1635         (WebKitDriver._start):
1636         (WebKitDriver.stop):
1637         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1638         (WebKitDriverTest.test_check_for_driver_crash):
1639         (WebKitDriverTest):
1640         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
1641         (WebKitDriverTest.test_stop_cleans_up_properly):
1642
1643 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1644
1645         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
1646         https://bugs.webkit.org/show_bug.cgi?id=86841
1647
1648         Reviewed by Adam Barth.
1649
1650         Print the number of MessagePorts for each new intent in EFL's DRT.
1651         This output is expected by several Web Intents test cases.
1652
1653         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1654         (DumpRenderTreeChrome::onFrameIntentNew):
1655
1656 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1657
1658         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
1659
1660         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1661
1662 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
1663
1664         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
1665         https://bugs.webkit.org/show_bug.cgi?id=87829
1666
1667         Reviewed by Adam Barth.
1668
1669         EFL's LayoutTestController now makes uses of the new helper method in
1670         DumpRenderTreeSupportEfl in order to send the intent response. This is
1671         now needed because the Ewk_Intent_Request postResult / postFailure
1672         methods were made private.
1673
1674         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1675         (LayoutTestController::sendWebIntentResponse):
1676
1677 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
1678
1679         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
1680         https://bugs.webkit.org/show_bug.cgi?id=86296
1681
1682         Reviewed by Tony Chang.
1683
1684         * DumpRenderTree/win/DRTDataObject.cpp: Added.
1685         (cfHDropFormat):
1686         (cfFileNameWFormat):
1687         (cfUrlWFormat):
1688         (WCEnumFormatEtc):
1689         (WCEnumFormatEtc::WCEnumFormatEtc):
1690         (WCEnumFormatEtc::QueryInterface):
1691         (WCEnumFormatEtc::AddRef):
1692         (WCEnumFormatEtc::Release):
1693         (WCEnumFormatEtc::Next):
1694         (WCEnumFormatEtc::Skip):
1695         (WCEnumFormatEtc::Reset):
1696         (WCEnumFormatEtc::Clone):
1697         (DRTDataObject::createInstance):
1698         (DRTDataObject::DRTDataObject):
1699         (DRTDataObject::~DRTDataObject):
1700         (DRTDataObject::QueryInterface):
1701         (DRTDataObject::AddRef):
1702         (DRTDataObject::Release):
1703         (DRTDataObject::GetData):
1704         (DRTDataObject::GetDataHere):
1705         (DRTDataObject::QueryGetData):
1706         (DRTDataObject::GetCanonicalFormatEtc):
1707         (DRTDataObject::SetData):
1708         (DRTDataObject::CopyMedium):
1709         (DRTDataObject::EnumFormatEtc):
1710         (DRTDataObject::DAdvise):
1711         (DRTDataObject::DUnadvise):
1712         (DRTDataObject::EnumDAdvise):
1713         (DRTDataObject::clearData):
1714         * DumpRenderTree/win/DRTDataObject.h: Added.
1715         (DRTDataObject):
1716         * DumpRenderTree/win/DRTDropSource.cpp: Added.
1717         (DRTDropSource::DRTDropSource):
1718         (DRTDropSource::~DRTDropSource):
1719         (DRTDropSource::QueryInterface):
1720         (DRTDropSource::AddRef):
1721         (DRTDropSource::Release):
1722         (DRTDropSource::createInstance):
1723         (DRTDropSource::QueryContinueDrag):
1724         (DRTDropSource::GiveFeedback):
1725         * DumpRenderTree/win/DRTDropSource.h: Added.
1726         (DRTDropSource):
1727         * DumpRenderTree/win/DumpRenderTree.vcproj:
1728         * DumpRenderTree/win/EventSender.cpp:
1729         (beginDragWithFilesCallback):
1730
1731 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
1732
1733         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
1734         https://bugs.webkit.org/show_bug.cgi?id=58593
1735
1736         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
1737         to WebKitTestRunner's LayoutTestController. The flag is modified via the
1738         public C API of the WebProcess.
1739
1740         Reviewed by Darin Adler.
1741
1742         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1743         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1744         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
1745         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
1746         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1747
1748 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1749
1750         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
1751         https://bugs.webkit.org/show_bug.cgi?id=87848
1752
1753         Reviewed by Csaba Osztrogonác.
1754
1755         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
1756         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
1757         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
1758
1759         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1760         (DumpRenderTreeChrome::extraViews):
1761         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1762         (DumpRenderTreeChrome):
1763
1764 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1765
1766         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
1767         https://bugs.webkit.org/show_bug.cgi?id=87833
1768
1769         Reviewed by Tor Arne Vestbø.
1770
1771         Print "postProgressFinishedNotification" message if frame load finished 
1772         to unskip http/tests/loading/progress-finished-callback.html.
1773
1774         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1775         (DumpRenderTreeChrome::onFrameLoadFinished):
1776
1777 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
1778
1779         [EFL][WK2] Fix WebKit2-EFL build
1780         https://bugs.webkit.org/show_bug.cgi?id=83693
1781
1782         Reviewed by Carlos Garcia Campos.
1783
1784         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
1785
1786 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
1787
1788         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
1789         (They only used to check for Skipped in platform/qt-5.0-wk1)
1790         https://bugs.webkit.org/show_bug.cgi?id=87376
1791
1792         Reviewed by Csaba Osztrogonác.
1793
1794         * Scripts/old-run-webkit-tests:
1795         (buildPlatformResultHierarchy):
1796         * Scripts/webkitpy/layout_tests/port/qt.py:
1797         (QtPort.baseline_search_path):
1798
1799 2012-05-29  Ojan Vafai  <ojan@chromium.org>
1800
1801         Add a linter error for pngs that lack an embedded checksum
1802         https://bugs.webkit.org/show_bug.cgi?id=87793
1803
1804         Reviewed by Dirk Pranke.
1805
1806         * Scripts/read-checksum-from-png:
1807         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
1808         (read_checksum):
1809         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
1810         (ReadChecksumFromPngTest):
1811         (ReadChecksumFromPngTest.test_read_checksum):
1812         * Scripts/webkitpy/layout_tests/port/base.py:
1813         * Scripts/webkitpy/style/checkers/png.py:
1814         (PNGChecker.check):
1815         * Scripts/webkitpy/style/checkers/png_unittest.py:
1816         (PNGCheckerTest.test_check):
1817
1818 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1819
1820         https://bugs.webkit.org/show_bug.cgi?id=87720
1821         WebProcess is often killed due to being unresponsive on the bots
1822
1823         Reviewed by Alexey Proskuryakov.
1824
1825         Blind attempt to improve flakiness on the bots by reducing the number
1826         of crashes due to an unresponsive process.  This helped on my personal machine
1827         under stress conditions.  I don't have enough cores to hit the problem
1828         under normal conditions.
1829
1830         * WebKitTestRunner/TestController.cpp:
1831         (WTR):
1832
1833 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1834
1835         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
1836         https://bugs.webkit.org/show_bug.cgi?id=87779
1837
1838         Reviewed by Eric Seidel.
1839
1840         Update output to match the names in scm.py as per
1841         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
1842
1843         * Scripts/webkitpy/tool/commands/rebaseline.py:
1844         (RebaselineTest.execute):
1845         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1846         (test_rebaseline_test_and_print_scm_changes):
1847         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1848         (GardeningServerTest.test_rebaselineall):
1849
1850 2012-05-29  Stephanie Lewis  <slewis@apple.com>
1851
1852         https://bugs.webkit.org/show_bug.cgi?id=87711
1853
1854         Reviewed by Jessie Berlin.
1855
1856         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
1857         are better maintained.
1858
1859         * BuildSlaveSupport/build.webkit.org-config/config.json:
1860
1861 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1862
1863         webkit-patch optimize-baselines should add/delete files in batches from the vcs
1864         https://bugs.webkit.org/show_bug.cgi?id=87538
1865
1866         Reviewed by Ojan Vafai.
1867
1868         Invoking git and svn on one file at a time is kinda slow. We
1869         should batch the add and rm operations together.
1870
1871         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1872         (BaselineOptimizer._move_baselines):
1873
1874 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
1875
1876         garden-o-matic should rebaseline baselines in parallel
1877         https://bugs.webkit.org/show_bug.cgi?id=87451
1878
1879         Reviewed by Ojan Vafai.
1880                                                                                
1881         This modifies garden-o-matic so that we will fetch all                  
1882         of the baselines in parallel from the bots, and then                    
1883         optimize the baselines serially (since that should be fairly            
1884         quick and we get into trouble if we optimize in parallel due            
1885         to concurrent access to the source control system).                     
1886
1887         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
1888         so that the files that need to be modified in the SCM are returned to 
1889         garden-o-matic rather than actually added or removed. This is done so that
1890         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
1891         concurrently). In order to safely return the files (as a JSON dict) I
1892         needed to shift all of the logging in rebaseline-test to use the logging
1893         module (and hence log to stderr).
1894
1895         I also had to stub out a line in chromium.py that would get confused if
1896         the skia overrides file didn't exist in a mock checkout.
1897
1898         * Scripts/webkitpy/common/system/executive.py:
1899         (Executive.popen):
1900         (Executive):
1901         (Executive.run_in_parallel):
1902         (_run_command_thunk):
1903         * Scripts/webkitpy/common/system/executive_mock.py:
1904         (MockExecutive.run_in_parallel):
1905         * Scripts/webkitpy/common/system/executive_unittest.py:
1906         (ExecutiveTest.test_run_in_parallel):
1907         * Scripts/webkitpy/layout_tests/port/chromium.py:
1908         (ChromiumPort._expectations_file_contents):
1909         * Scripts/webkitpy/tool/commands/rebaseline.py:
1910         (AbstractRebaseliningCommand.__init__):
1911         (RebaselineTest.__init__):
1912         (RebaselineTest._copy_existing_baseline):
1913         (RebaselineTest._save_baseline):
1914         (RebaselineTest):
1915         (RebaselineTest._add_to_scm):
1916         (RebaselineTest._rebaseline_test):
1917         (RebaselineTest.execute):
1918         (RebaselineExpectations._rebaseline_port):
1919         (RebaselineExpectations.execute):
1920         (Rebaseline._builder_to_pull_from):
1921         (Rebaseline.execute):
1922         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1923         (test_rebaseline_updates_expectations_file):
1924         (test_rebaseline_test):
1925         (test_rebaseline_test_and_print_scm_changes):
1926         (test_rebaseline_and_copy_test):
1927         (test_rebaseline_and_copy_test_no_existing_result):
1928         (test_rebaseline_and_copy_test_with_lion_result):
1929         (test_rebaseline_and_copy_no_overwrite_test):
1930         (test_rebaseline_expectations):
1931         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1932         (GardeningHTTPRequestHandler._rebaseline_commands):
1933         (GardeningHTTPRequestHandler):
1934         (GardeningHTTPRequestHandler._files_to_add):
1935         (GardeningHTTPRequestHandler._optimize_baselines):
1936         (GardeningHTTPRequestHandler.rebaselineall):
1937         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1938         (GardeningServerTest._post_to_path):
1939         (GardeningServerTest.test_rebaselineall):
1940         (GardeningServerTest.test_rebaselineall.run_command):
1941
1942 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
1943
1944         Fix the type of dispatch_time() offset
1945
1946         Rubber-stamped by Joseph Pecoraro.
1947
1948         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
1949
1950         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1951         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1952
1953 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1954
1955         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
1956
1957         [BlackBerry] OpenGL content is not rendered on simulator
1958         https://bugs.webkit.org/show_bug.cgi?id=87721
1959
1960         Reviewed by George Staikos.
1961
1962         Fixed by enabling GLES2 support in simulator builds.
1963
1964         To experiment with building without OpenGL support, you can set the
1965         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
1966
1967         PR #150695
1968
1969         * Scripts/webkitdirs.pm:
1970         (blackberryCMakeArguments):
1971
1972 2012-05-29  David Barr  <davidbarr@chromium.org>
1973
1974         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
1975         https://bugs.webkit.org/show_bug.cgi?id=87685
1976
1977         Reviewed by Eric Seidel.
1978
1979         Add a configuration option for CSS image-resolution support, disabling it by default.
1980
1981         * Scripts/webkitperl/FeatureList.pm:
1982         * qmake/mkspecs/features/features.pri:
1983
1984 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1985
1986         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
1987
1988         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
1989             valid for C++/ObjC++ but not for C [enabled by default]"
1990
1991         Reviewed by Simon Hausmann.
1992
1993         * qmake/mkspecs/features/unix/default_post.prf:
1994
1995 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1996
1997         [Qt] Sync up favicon-implementation with WebView url changes in r118158
1998
1999         https://bugs.webkit.org/show_bug.cgi?id=87133
2000
2001         We now base64-encode the page url in the image-provider url, so that any
2002         normalization done by QUrl will not mess up the page-url. The logic of
2003         creating and parsing the provider-url has been moved into the image
2004         provider, to keep it in one place.
2005
2006         We were also releasing icons (even ones we hadn't retained), which we can't
2007         do since we don't know when the icon url is no longer in use.
2008
2009         Reviewed-by Simon Hausmann.
2010
2011         * MiniBrowser/qt/icons/favicon.png:
2012         * MiniBrowser/qt/qml/BrowserWindow.qml:
2013
2014 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2015
2016         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
2017         https://bugs.webkit.org/show_bug.cgi?id=87654
2018
2019         Reviewed by Csaba Osztrogonác.
2020
2021         Event sender provides strings for all the key events.
2022         Also KeyEventInfo constructor parameters order was changed to simplify the case when
2023         a key event has empty string.
2024
2025         * DumpRenderTree/efl/EventSender.cpp:
2026         (KeyEventInfo::KeyEventInfo):
2027         (keyPadNameFromJSValue):
2028         (keyNameFromJSValue):
2029
2030 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2031
2032         [Qt] Cancel potential url-edit when going back/forward
2033
2034         Reviewed by Kenneth Rohde Christiansen.
2035
2036         * MiniBrowser/qt/qml/BrowserWindow.qml:
2037
2038 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
2039
2040         [EFL] Compilation warning in DumpRenderTreeView.cpp
2041         https://bugs.webkit.org/show_bug.cgi?id=87636
2042
2043         Reviewed by Filip Pizlo.
2044
2045         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
2046         specifier in printf. Also fix the return type for
2047         onExceededApplicationCacheQuota callback.
2048
2049         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2050         (onExceededApplicationCacheQuota):
2051
2052 2012-05-29  Hironori Bono  <hbono@chromium.org>
2053
2054         Adding Hironori Bono to committers.py.
2055         https://bugs.webkit.org/show_bug.cgi?id=87697
2056
2057         * Scripts/webkitpy/common/config/committers.py:
2058
2059 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
2060
2061         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
2062         https://bugs.webkit.org/show_bug.cgi?id=80135
2063
2064         Reviewed by Rob Buis.
2065
2066         Implemented interface function didReceiveAuthenticationChallenge in class
2067         DumpRenderTree.
2068
2069         Resubmit the patch reverted by r115104 after the digest infinite loop
2070         issue for BlackBerry porting get identified and fixed.
2071
2072         Internally reviewed by Joe Mason <jmason@rim.com>
2073
2074         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2075         (drtCredentialDescription):
2076         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
2077         (WebKit):
2078         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2079         (WebCore):
2080         (DumpRenderTree):
2081
2082 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2083
2084         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
2085         https://bugs.webkit.org/show_bug.cgi?id=42328
2086
2087         Reviewed by Eric Seidel.
2088
2089         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
2090         move to windows.internals.settings.
2091
2092         * DumpRenderTree/LayoutTestController.cpp:
2093         (LayoutTestController::staticFunctions):
2094         * DumpRenderTree/LayoutTestController.h:
2095         (LayoutTestController):
2096         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2097         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2098         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2099         (DRTDevToolsAgent):
2100         * DumpRenderTree/chromium/LayoutTestController.cpp:
2101         (LayoutTestController::LayoutTestController):
2102         * DumpRenderTree/chromium/LayoutTestController.h:
2103         (LayoutTestController):
2104         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2105         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2106         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2107         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2108         * DumpRenderTree/mac/DumpRenderTree.mm:
2109         (resetWebViewToConsistentStateBeforeTesting):
2110         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2111         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2112         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2113         (LayoutTestController):
2114         * DumpRenderTree/win/DumpRenderTree.cpp:
2115         (resetWebViewToConsistentStateBeforeTesting):
2116         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2117         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2118         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2119         (LayoutTestController):
2120
2121 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2122
2123         Move allowRoundingHacks to Internals interface
2124         https://bugs.webkit.org/show_bug.cgi?id=87328
2125
2126         Reviewed by Hajime Morita.
2127
2128         Remove allowRoundingHacks functions, because it is able to work in the
2129         cross-port way through the Internals interface.
2130
2131         * DumpRenderTree/LayoutTestController.cpp:
2132         (LayoutTestController::staticFunctions):
2133         * DumpRenderTree/LayoutTestController.h:
2134         (LayoutTestController):
2135         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2136         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2137         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2138         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2139         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2140         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2141
2142 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
2143
2144         Fix mac build with older XCode by defining NSEC_PER_MSEC.
2145         https://bugs.webkit.org/show_bug.cgi?id=87616
2146
2147         Reviewed by Hajime Morita.
2148
2149         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
2150         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
2151         Patch just adds a #ifndef / #define check.
2152
2153         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2154         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2155
2156 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2157
2158         [EFL] Enable blob support for the EFL port
2159         https://bugs.webkit.org/show_bug.cgi?id=85363
2160
2161         Reviewed by Hajime Morita.
2162
2163         Enable Blob support by default for the EFL port.
2164
2165         * Scripts/webkitperl/FeatureList.pm:
2166
2167 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
2168
2169         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
2170         https://bugs.webkit.org/show_bug.cgi?id=87582
2171
2172         Reviewed by Darin Adler.
2173
2174         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
2175         possible to test pages in a similar way as they are loaded in Browsers.
2176
2177         * DumpRenderTree/LayoutTestController.cpp:
2178         (LayoutTestController::LayoutTestController):
2179         (setUseDeferredFrameLoadingCallback):
2180         (LayoutTestController::staticFunctions):
2181         * DumpRenderTree/LayoutTestController.h:
2182         (LayoutTestController::useDeferredFrameLoading):
2183         (LayoutTestController::setUseDeferredFrameLoading):
2184         (LayoutTestController):
2185         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2186         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2187
2188 2012-05-27  David Barton  <dbarton@mathscribe.com>
2189
2190         [watchlist] Improve MathML rule
2191         https://bugs.webkit.org/show_bug.cgi?id=87592
2192
2193         Reviewed by Adam Barth.
2194
2195         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
2196         but if this changed the rule would be slow. We protect against this, clarify the rule,
2197         and make it more similar to existing rules.
2198
2199         * Scripts/webkitpy/common/config/watchlist:
2200
2201 2012-05-27  David Barton  <dbarton@mathscribe.com>
2202
2203         [watchlist] Add myself & a rule for MathML
2204         https://bugs.webkit.org/show_bug.cgi?id=87586
2205
2206         Reviewed by Adam Barth.
2207
2208         * Scripts/webkitpy/common/config/watchlist:
2209
2210 2012-05-26  David Kilzer  <ddkilzer@apple.com>
2211
2212         Use xcrun to find path to nm for Mac port
2213         <http://webkit.org/b/87588>
2214
2215         Reviewed by Dan Bernstein.
2216
2217         * Scripts/webkitpy/layout_tests/port/mac.py:
2218         (MacPort.nm_command): Add. Tries to find a path for the nm
2219         command using xcrun.  Falls back to returning 'nm'.
2220         * Scripts/webkitpy/layout_tests/port/webkit.py:
2221         (WebKitPort.nm_command): Add. Returns 'nm'.
2222         (WebKitPort._webcore_symbols_string): Call self.nm_command().
2223
2224 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
2225
2226         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
2227
2228         Reviewed by Eric Seidel.
2229
2230         * DumpRenderTree/win/DumpRenderTree.vcproj:
2231         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2232         (FrameLoadDelegate::FrameLoadDelegate):
2233         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2234         * DumpRenderTree/win/FrameLoadDelegate.h:
2235         (FrameLoadDelegate):
2236         * DumpRenderTree/win/TextInputController.cpp: Added.
2237         (setMarkedTextCallback):
2238         (hasMarkedTextCallback):
2239         (unmarkTextCallback):
2240         (markedRangeCallback):
2241         (insertTextCallback):
2242         (firstRectForCharacterRangeCallback):
2243         (selectedRangeCallback):
2244         (TextInputController::makeWindowObject):
2245         (TextInputController::getJSClass):
2246         (TextInputController::staticValues):
2247         (TextInputController::staticFunctions):
2248         * DumpRenderTree/win/TextInputController.h: Added.
2249         (TextInputController):
2250         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
2251         (TextInputController::setMarkedText):
2252         (TextInputController::hasMarkedText):
2253         (TextInputController::unmarkText):
2254         (TextInputController::markedRange):
2255         (TextInputController::insertText):
2256         (TextInputController::firstRectForCharacterRange):
2257         (TextInputController::selectedRange):
2258
2259 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
2260
2261         webkitpy: change scm.add(), scm.delete() to accept multiple paths
2262         https://bugs.webkit.org/show_bug.cgi?id=87528
2263
2264         Reviewed by Ojan Vafai.
2265
2266         launching git or svn for individual files can be slow; this
2267         change will hand multiple paths at once to git and svn so they
2268         can be added in a batch.
2269
2270         * Scripts/webkitpy/common/checkout/scm/git.py:
2271         (Git.add_list):
2272         (Git.delete_list):
2273         * Scripts/webkitpy/common/checkout/scm/scm.py:
2274         (SCM.add):
2275         (SCM):
2276         (SCM.add_list):
2277         (SCM.delete):
2278         (SCM.delete_list):
2279         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2280         (MockSCM.add):
2281         (MockSCM):
2282         (MockSCM.add_list):
2283         (MockSCM.delete):
2284         (MockSCM.delete_list):
2285         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2286         (_shared_test_exists):
2287         (_shared_test_added_files):
2288         (_test_delete_list):
2289         * Scripts/webkitpy/common/checkout/scm/svn.py:
2290         (SVN.add_list):
2291         (SVN.delete_list):
2292
2293 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2294
2295         [NRWT] Add unit testing for perf tests on locked shards
2296         https://bugs.webkit.org/show_bug.cgi?id=87489
2297
2298         Reviewed by Dirk Pranke.
2299
2300         Adding utests that makes sure that perf tests are running in locked
2301         shards and by passing --no-http won't break NRWT (r118421).
2302
2303         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2304         (ShardingTests):
2305         (ShardingTests.test_shard_by_dir):
2306         (ShardingTests.test_shard_every_file):
2307         (ShardingTests.test_shard_in_two):
2308         (ShardingTests.test_multiple_locked_shards):
2309         (LockCheckingManager):
2310         (LockCheckingManager.__init__):
2311         (LockCheckingManager.handle_finished_list):
2312         (ManagerTest.test_http_locking):
2313         (ManagerTest):
2314         (ManagerTest.test_perf_locking):
2315         * Scripts/webkitpy/layout_tests/port/test.py:
2316
2317 2012-05-25  Jessie Berlin  <jberlin@apple.com>
2318
2319         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
2320         https://bugs.webkit.org/show_bug.cgi?id=87511
2321
2322         Reviewed by Alexey Proskuryakov.
2323
2324         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
2325
2326         * DumpRenderTree/win/EventSender.cpp:
2327         (keyDownCallback):
2328
2329 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
2330
2331         Adding Ken Buchanan to committers.py
2332         https://bugs.webkit.org/show_bug.cgi?id=87443
2333
2334         Unreviewed.
2335
2336         Adding self to committers.py as a Committer.
2337
2338         * Scripts/webkitpy/common/config/committers.py:
2339
2340 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2341
2342         [Qt] Buildfix for newer Qt5
2343         https://bugs.webkit.org/show_bug.cgi?id=87257
2344
2345         Reviewed by Simon Hausmann.
2346
2347         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
2348
2349 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2350
2351         [Qt] Unreviewed fix after r118484.
2352
2353         Enable CSS_EXCLUSIONS and CSS_REGIONS.
2354         They were enabled uncoditinally before r118484.
2355
2356         * qmake/mkspecs/features/features.pri:
2357
2358 2012-05-24  Tim Horton  <timothy_horton@apple.com>
2359
2360         Add feature defines for web-facing parts of CSS Regions and Exclusions
2361         https://bugs.webkit.org/show_bug.cgi?id=87442
2362         <rdar://problem/10887709>
2363
2364         Reviewed by Dan Bernstein.
2365
2366         * Scripts/webkitperl/FeatureList.pm:
2367
2368 2012-05-24  Hironori Bono  <hbono@chromium.org>
2369
2370         Enable grammar checking on Chromium when we paste text (Take 2)
2371         https://bugs.webkit.org/show_bug.cgi?id=74393
2372
2373         Reviewed by Ryosuke Niwa.
2374
2375         This change enables grammar checking on Chromium and implements a mock grammar
2376         checker to fix a failing test.
2377
2378         * DumpRenderTree/DumpRenderTree.gypi:
2379         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2380         (MockGrammarCheck::checkGrammarOfString):
2381         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2382         (WebKit):
2383         (MockGrammarCheck):
2384         * DumpRenderTree/chromium/WebViewHost.cpp:
2385         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2386
2387 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2388
2389         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
2390         https://bugs.webkit.org/show_bug.cgi?id=86842
2391
2392         Reviewed by Antonio Gomes.
2393
2394         Add support for overriding the application cache support preference
2395         through EFL's LayoutTestController.
2396
2397         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2398         (LayoutTestController::overridePreference):
2399
2400 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2401
2402         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
2403         https://bugs.webkit.org/show_bug.cgi?id=85209
2404
2405         Reviewed by Antonio Gomes.
2406
2407         Set developer extras setting called twice on the test startup. Hence, removing
2408         an unnecessary extra call which set wrong value. 
2409
2410         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2411         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2412
2413 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2414
2415         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2416         https://bugs.webkit.org/show_bug.cgi?id=86916
2417
2418         Reviewed by Adam Barth.
2419
2420         Note that if release and debug are failing differently, debug
2421         will be ignored ...
2422
2423         Note: also change the use of a fake port name from
2424         "mock-port-name" to "test-mac-leopard" to make it more friendly
2425         to the port factory ("mock" actually is a real port).
2426
2427         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2428         (GardeningHTTPRequestHandler._builders_to_fetch_from):
2429         (GardeningHTTPRequestHandler.rebaselineall):
2430         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2431         (GardeningServerTest.test_rebaselineall):
2432         (GardeningServerTest.test_rebaseline_new_port):
2433
2434 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2435
2436         nrwt: fix baseline search path for official chrome builders
2437         https://bugs.webkit.org/show_bug.cgi?id=87432
2438
2439         Reviewed by Tony Chang.
2440
2441         The official chrome builders need to use the win7 and SL
2442         baseline paths, not the XP and Leopard paths. Linux is correct.
2443
2444         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2445         (GoogleChromeMacPort.determine_full_port_name):
2446         (GoogleChromeWinPort.determine_full_port_name):
2447         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2448         (TestGoogleChromePort._verify_baseline_search_path_startswith):
2449         (TestGoogleChromePort.test_get_google_chrome_port):
2450
2451 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2452
2453         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
2454         https://bugs.webkit.org/show_bug.cgi?id=86800
2455
2456         Reviewed by Dirk Pranke.
2457
2458         Don't launch a HTTP server with lock based only on the existence of
2459         locked shards since we now run perf on locked shards too.
2460
2461         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2462         (Manager._run_tests):
2463
2464 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
2465
2466         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2467         https://bugs.webkit.org/show_bug.cgi?id=87128
2468
2469         Reviewed by Dirk Pranke.
2470
2471         * Scripts/webkitpy/layout_tests/port/base.py:
2472         (Port.driver_name):
2473         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2474         (ChromiumLinuxPort._path_to_driver):
2475         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2476         (ChromiumPortTest.test_driver_name_option):
2477         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2478         (ChromiumWinPort._path_to_driver):
2479         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2480         (parse_args):
2481
2482 2012-05-24  John Mellor  <johnme@chromium.org>
2483
2484         Font Boosting: Add compile flag and runtime setting
2485         https://bugs.webkit.org/show_bug.cgi?id=87394
2486
2487         Reviewed by Adam Barth.
2488
2489         Add ENABLE_FONT_BOOSTING.
2490
2491         * Scripts/webkitperl/FeatureList.pm:
2492         * qmake/mkspecs/features/features.pri:
2493
2494 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2495
2496         [EFL] [DRT] keyboard-related tests do not pass
2497         https://bugs.webkit.org/show_bug.cgi?id=85369
2498
2499         Reviewed by Gustavo Noronha Silva.
2500
2501         Add SHIFT modifier for capital letters as VK_ 
2502         codes do not distinguish between lows and caps and also to be consistent
2503         with other ports which send caps as lowercase letters with the shift key down.
2504
2505         * DumpRenderTree/efl/EventSender.cpp:
2506         (keyNameFromJSValue): 
2507
2508 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
2509
2510         [WK2] Let the client give local files universal access on a case by case basis
2511         https://bugs.webkit.org/show_bug.cgi?id=87174
2512         <rdar://problem/11024330>
2513
2514         Reviewed by Maciej Stachowiak.
2515
2516         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
2517         Added initialization of a new structure member to prevent build failure.
2518
2519 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
2520
2521         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
2522         https://bugs.webkit.org/show_bug.cgi?id=87203
2523
2524         Reviewed by Andreas Kling.
2525
2526         Add the required changes to make
2527         fast/events/keydown-leftright-keys.html pass after r118001.
2528
2529         * DumpRenderTree/efl/EventSender.cpp:
2530         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
2531         into the proper X11 keysym definitions.
2532
2533 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2534
2535         Unreviewed, rolling out r118352.
2536         http://trac.webkit.org/changeset/118352
2537         https://bugs.webkit.org/show_bug.cgi?id=87390
2538
2539         Caused 6 editing/spelling tests crash/fail on chromium in
2540         debug. (Requested by vsevik on #webkit).
2541
2542         * DumpRenderTree/DumpRenderTree.gypi:
2543         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
2544         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
2545         * DumpRenderTree/chromium/WebViewHost.cpp:
2546         (WebViewHost::finishLastTextCheck):
2547
2548 2012-05-24  Peter Beverloo  <peter@chromium.org>
2549
2550         Add John Mellor as a contributor
2551         https://bugs.webkit.org/show_bug.cgi?id=87389
2552
2553         Reviewed by Kenneth Rohde Christiansen.
2554
2555         John will be working on Font Boosting and is very involved with various
2556         web-facing subjects of Chrome for Android, such as viewport.
2557
2558         * Scripts/webkitpy/common/config/committers.py:
2559
2560 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2561
2562         [EFL][DRT] LayoutTestController's setCacheModel() implementation
2563         https://bugs.webkit.org/show_bug.cgi?id=86840
2564
2565         Reviewed by Csaba Osztrogonác.
2566
2567         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2568         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
2569         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2570         (LayoutTestController::setCacheModel): Implementation added.
2571
2572 2012-05-24  Hironori Bono  <hbono@chromium.org>
2573
2574         Enable grammar checking on Chromium when we paste text.
2575         https://bugs.webkit.org/show_bug.cgi?id=74393
2576
2577         Reviewed by Hajime Morita.
2578
2579         This change enables grammar checking on Chromium and implements a mock grammar
2580         checker to fix a failing test.
2581
2582         * DumpRenderTree/DumpRenderTree.gypi:
2583         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2584         (MockGrammarCheck::checkGrammarOfString):
2585         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2586         (WebKit):
2587         (MockGrammarCheck):
2588         * DumpRenderTree/chromium/WebViewHost.cpp:
2589         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2590
2591 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
2592
2593         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
2594
2595         * qmake/mkspecs/features/features.pri:
2596
2597 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2598
2599         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
2600         https://bugs.webkit.org/show_bug.cgi?id=86867
2601
2602         Reviewed by Adam Barth.
2603
2604         Add implementation for sendWebIntentResponse() in EFL's
2605         LayoutTestController and add empty implementation for other ports.
2606
2607         * DumpRenderTree/LayoutTestController.cpp:
2608         (sendWebIntentResponseCallback):
2609         (LayoutTestController::staticFunctions):
2610         * DumpRenderTree/LayoutTestController.h:
2611         (LayoutTestController):
2612         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2613         (LayoutTestController::sendWebIntentResponse):
2614         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2615         (DumpRenderTreeChrome::currentIntentRequest):
2616         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2617         (DumpRenderTreeChrome::onFrameIntentNew):
2618         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2619         (DumpRenderTreeChrome):
2620         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2621         (LayoutTestController::sendWebIntentResponse):
2622         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2623         (LayoutTestController::sendWebIntentResponse):
2624         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2625         (LayoutTestController::sendWebIntentResponse):
2626         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2627         (LayoutTestController::sendWebIntentResponse):
2628         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2629         (LayoutTestController::sendWebIntentResponse):
2630
2631 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2632
2633         [EFL] The EFL port has no support for title directionality
2634         https://bugs.webkit.org/show_bug.cgi?id=86462
2635
2636         Reviewed by Gustavo Noronha Silva.
2637
2638         Update "title,changed" signal handlers in DRT and EWebLauncher to
2639         reflect the change from const char* to Ewk_Text_With_Direction* type
2640         for the title.
2641
2642         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2643         (DumpRenderTreeChrome::onTitleChanged):
2644         * EWebLauncher/main.c:
2645         (title_set):
2646         (on_title_changed):
2647         (on_key_down):
2648
2649 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2650
2651         Change EFL debug build name with more detail one
2652         https://bugs.webkit.org/show_bug.cgi?id=87254
2653
2654         Reviewed by Ryosuke Niwa.
2655
2656         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
2657         In addition, remove efl-linux-debug triggerable since nobody uses it.
2658
2659         * BuildSlaveSupport/build.webkit.org-config/config.json:
2660
2661 2012-05-23  Kangil Han  <kangil.han@samsung.com>
2662
2663         [EFL][DRT] Fix WebCore library path and rebaseline result
2664         https://bugs.webkit.org/show_bug.cgi?id=86355
2665
2666         Reviewed by Dirk Pranke.
2667
2668         Currently EFL DRT uses wrong WebCore library path when running DRT.
2669         Therefore, this patch adjusted the path correctly.
2670
2671         * Scripts/webkitpy/layout_tests/port/efl.py:
2672         (EflPort._path_to_webcore_library):
2673
2674 2012-05-23  Ojan Vafai  <ojan@chromium.org>
2675
2676         add back the ability to disable flexbox
2677         https://bugs.webkit.org/show_bug.cgi?id=87147
2678
2679         Reviewed by Tony Chang.
2680
2681         * Scripts/webkitperl/FeatureList.pm:
2682
2683 2012-05-23  Tony Chang  <tony@chromium.org>
2684
2685         Remove the Chromium Grid Layout bot from the waterfall
2686         https://bugs.webkit.org/show_bug.cgi?id=87311
2687
2688         Reviewed by Ryosuke Niwa.
2689
2690         I removed the compiler define in r117613, so we don't need a separate
2691         bot to compile/test this code.
2692
2693         * BuildSlaveSupport/build.webkit.org-config/config.json:
2694
2695 2012-05-23  Ian Vollick  <vollick@chromium.org>
2696
2697         Add vollick to list of contributors.
2698         https://bugs.webkit.org/show_bug.cgi?id=87305
2699
2700         Reviewed by Adam Barth.
2701
2702         * Scripts/webkitpy/common/config/committers.py:
2703
2704 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2705
2706         [Chromium-Android] Fix chromium_android_unittest
2707         https://bugs.webkit.org/show_bug.cgi?id=87196
2708
2709         Reviewed by Tony Chang.
2710
2711         Update unit tests after ChromiumAndroidPort supported apk based
2712         DumpRenderTree.
2713
2714         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2715         (ChromiumAndroidPortTest):
2716         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
2717         (ChromiumAndroidPortTest.test_get_last_stacktrace):
2718         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
2719         (ChromiumAndroidDriverTest):
2720         (ChromiumAndroidDriverTest.setUp):
2721         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
2722         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
2723
2724 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2725
2726         [watchlist] Add myself and create a watch rule to catch Attribute related patches
2727         https://bugs.webkit.org/show_bug.cgi?id=87303
2728
2729         Reviewed by Alexis Menard.
2730
2731         * Scripts/webkitpy/common/config/watchlist:
2732
2733 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
2734
2735         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2736         https://bugs.webkit.org/show_bug.cgi?id=86916
2737
2738         Reviewed by Adam Barth.
2739
2740         This change pushes all of the logic for rebaselining a cluster
2741         of failures (a list of tests failing a list of suffixes on a
2742         list of bots) onto the server, so there is a single call from
2743         the web page; we will then be able to optimize the performance
2744         of the rebaselining better.
2745
2746         Also remove the 'optimizebaseline' entry point on garden-o-matic
2747         (and the client-side call) since we don't need it any more.
2748
2749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2750         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2751         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2752         (GardeningHTTPRequestHandler.rebaselineall):
2753         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2754
2755 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
2756
2757         Mac DRT should be able to load external URLs for replay performance tests
2758         https://bugs.webkit.org/show_bug.cgi?id=86191
2759
2760         Reviewed by Alexey Proskuryakov.
2761
2762         Let external URL requests go through if the test file is not a local file or hosted at localhost.
2763         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
2764         "DumpRenderTree http://localhost:8000/".
2765
2766         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2767         (isLocalhost):
2768         (hostIsUsedBySomeTestsToGenerateError):
2769         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2770
2771 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
2772
2773         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
2774         debug symbols for easier debugging.
2775         https://bugs.webkit.org/show_bug.cgi?id=87151
2776
2777         Reviewed by Kevin Ollivier.
2778
2779         * waf/build/settings.py:
2780         (common_configure):
2781
2782 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2783
2784         Unreviewed. Move myself to reviewers.
2785
2786         * Scripts/webkitpy/common/config/committers.py:
2787
2788 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
2789
2790         [EFL] Implements the registerProtocolHandler method and option.
2791         https://bugs.webkit.org/show_bug.cgi?id=73638
2792
2793         Reviewed by Andreas Kling.
2794
2795         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
2796
2797 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
2798
2799         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
2800         https://bugs.webkit.org/show_bug.cgi?id=87221
2801
2802         Reviewed by Martin Robinson.
2803
2804         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
2805         rightShift key names into proper GDK key symbols.
2806
2807         * DumpRenderTree/gtk/EventSender.cpp:
2808         (createKeyPressEvent):
2809
2810 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2811
2812         [Qt] Make the web view's url property follow the active url
2813
2814         https://bugs.webkit.org/show_bug.cgi?id=77554
2815
2816         Update  the location bar in the minibrowser to behave
2817         a bit more like normal browsers in terms of when the url will change
2818         and how active focus is handled.
2819
2820         Reviewed by Simon Hausmann.
2821
2822         * MiniBrowser/qt/qml/BrowserWindow.qml:
2823
2824 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2825
2826         [Qt] Remove references to $$QT_SOURCE_TREE
2827
2828         With a modularized Qt, it's ambigious. What we really want is qtbase,
2829         which qtcore is a proxy for (we assume it will always live in qtbase).
2830
2831         Reviewed by Tor Arne Vestbø.
2832
2833         * DumpRenderTree/qt/DumpRenderTree.pro:
2834
2835 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2836
2837         [Qt] Fix qmake conditional for c++-11 compat warnings
2838
2839         Reviewed by Tor Arne Vestbø.
2840
2841         * qmake/mkspecs/features/unix/default_post.prf:
2842
2843 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2844
2845         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
2846         https://bugs.webkit.org/show_bug.cgi?id=85956
2847
2848         Reviewed by Gustavo Noronha Silva.
2849
2850         Catch new "load,provisional,failed" signal and print
2851         didFailProvisionalLoadWithError messages when LayoutTestController's
2852         dumpFrameLoadCallbacks() returns true. Also make sure the
2853         didFailLoadWithError message is not printed in case of provisional
2854         load failure.
2855
2856         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2857         (DumpRenderTreeChrome::createView):
2858         (DumpRenderTreeChrome::onFrameCreated):
2859         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
2860         (DumpRenderTreeChrome::onFrameLoadError):
2861         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2862         (DumpRenderTreeChrome):
2863
2864 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
2865
2866         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
2867         https://bugs.webkit.org/show_bug.cgi?id=86366
2868
2869         Reviewed by Antonio Gomes.
2870
2871         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
2872
2873         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2874         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2875
2876 2012-05-22  Darin Adler  <darin@apple.com>
2877
2878         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
2879         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
2880
2881 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2882
2883         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
2884         https://bugs.webkit.org/show_bug.cgi?id=86922
2885
2886         Because we have new platformInit() in TestShellAndroid.cpp, and
2887         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
2888         is split into TestShellPosix.cpp and TestShellX11.cpp.
2889
2890         Reviewed by Kent Tamura.
2891
2892         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2893         * DumpRenderTree/DumpRenderTree.gypi:
2894         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
2895         (platformInit):
2896         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
2897         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
2898         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
2899         (AlarmHandler):
2900         (TestShell::waitTestFinished):
2901         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
2902         (openStartupDialog): from TestShellGtk.cpp
2903         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
2904         (setupFontconfig):
2905         (platformInit):
2906
2907 2012-05-22  Kangil Han  <kangil.han@samsung.com>
2908
2909         [EFL][DRT] Implement touch event
2910         https://bugs.webkit.org/show_bug.cgi?id=86720
2911
2912         Reviewed by Hajime Morita.
2913
2914         Currently EFL DRT doesn't support touch event.
2915         Therefore, this patch enabled it and implemented some eventSender function callbacks.
2916
2917         * DumpRenderTree/efl/EventSender.cpp:
2918         (TouchEventInfo::TouchEventInfo):
2919         (TouchEventInfo):
2920         (touchPointList):
2921         (sendTouchEvent):
2922         (addTouchPointCallback):
2923         (touchStartCallback):
2924         (updateTouchPointCallback):
2925         (touchMoveCallback):
2926         (cancelTouchPointCallback):
2927         (touchCancelCallback):
2928         (releaseTouchPointCallback):
2929         (touchEndCallback):
2930         (clearTouchPointsCallback):
2931         (setTouchModifierCallback):
2932         * Scripts/webkitperl/FeatureList.pm:
2933
2934 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2935
2936         [Chromium-Android] Fix chromium_android_unittest
2937         https://bugs.webkit.org/show_bug.cgi?id=87196
2938
2939         Not reviewed.
2940         Temporarily disable chromium_android_unittest.
2941
2942         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2943         (ChromiumAndroidPortTest):
2944         (ChromiumAndroidDriverTest):
2945
2946 2012-05-22  Jessie Berlin  <jberlin@apple.com>
2947
2948         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
2949         https://bugs.webkit.org/show_bug.cgi?id=64313
2950
2951         Reviewed by Jon Honeycutt.
2952
2953         Add it.
2954
2955         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2956         Make sure to generate the binding.
2957
2958         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2959         (WTR::LayoutTestController::setDefersLoading):
2960         Call WKBundlePageSetDefersLoading.
2961         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2962
2963 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2964
2965         [Chromium-Android] Run DumpRenderTree as an apk (python part)
2966         https://bugs.webkit.org/show_bug.cgi?id=86923
2967
2968         chromium_android.py is modified to support running DumpRenderTree as
2969         an apk, so that we can run the tests (e.g. video) requiring features
2970         implemented in Java on Android.
2971
2972         Reviewed by Adam Barth.
2973
2974         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2975         (ChromiumAndroidPort.__init__):
2976         (ChromiumAndroidPort.default_child_processes):
2977         (ChromiumAndroidPort.check_wdiff):
2978         (ChromiumAndroidPort.check_build):
2979         (ChromiumAndroidPort.start_helper):
2980         (ChromiumAndroidPort.skipped_layout_tests):
2981         (ChromiumAndroidPort):
2982         (ChromiumAndroidPort._path_to_driver):
2983         (ChromiumAndroidPort._get_crash_log):
2984         (ChromiumAndroidPort._push_executable):
2985         (ChromiumAndroidPort._run_adb_command):
2986         (ChromiumAndroidPort._get_last_stacktrace):
2987         (ChromiumAndroidPort._get_logcat):
2988         (ChromiumAndroidPort._setup_performance):
2989         (ChromiumAndroidDriver):
2990         (ChromiumAndroidDriver.__init__):
2991         (ChromiumAndroidDriver._command_wrapper):
2992         (ChromiumAndroidDriver.cmd_line):
2993         (ChromiumAndroidDriver._file_exists_on_device):
2994         (ChromiumAndroidDriver._deadlock_detector):
2995         (ChromiumAndroidDriver._start):
2996         (ChromiumAndroidDriver.run_test):
2997         (ChromiumAndroidDriver.stop):
2998         (ChromiumAndroidDriver._write_command_and_read_line):
2999         (ChromiumAndroidDriver._output_image):
3000         (ChromiumAndroidDriver._get_stderr):
3001
3002 2012-05-22  Joshua Bell  <jsbell@chromium.org>
3003
3004         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
3005
3006         Unreviewed gardening.
3007
3008         * Scripts/webkitpy/layout_tests/port/base.py:
3009         (Port.driver_name):
3010         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3011         (ChromiumLinuxPort._path_to_driver):
3012         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3013         (ChromiumPortTest.test_overrides_and_builder_names):
3014         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3015         (ChromiumWinPort._path_to_driver):
3016         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3017         (parse_args):
3018
3019 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3020
3021         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
3022         https://bugs.webkit.org/show_bug.cgi?id=87176
3023
3024         Reviewed by Tony Chang.
3025
3026         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3027         * DumpRenderTree/DumpRenderTree.gypi:
3028
3029 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
3030
3031         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
3032         https://bugs.webkit.org/show_bug.cgi?id=87128
3033
3034         Reviewed by Dirk Pranke.
3035
3036         * Scripts/webkitpy/layout_tests/port/base.py:
3037         (Port.driver_name):
3038         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3039         (ChromiumLinuxPort._path_to_driver):
3040         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3041         (ChromiumPortTest.test_driver_name_option):
3042         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3043         (ChromiumWinPort._path_to_driver):
3044         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3045         (parse_args):
3046
3047 2012-05-22  Jessie Berlin  <jberlin@apple.com>
3048
3049         WTR fix after r118001.
3050
3051         Rubber-stamped by Alexey Proskuryakov.
3052
3053         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
3054
3055         * WebKitTestRunner/mac/EventSenderProxy.mm:
3056         (WTR::EventSenderProxy::keyDown):
3057
3058 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
3059
3060         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
3061         https://bugs.webkit.org/show_bug.cgi?id=86684
3062
3063         Reviewed by Darin Fisher.
3064
3065         * DumpRenderTree/chromium/LayoutTestController.cpp:
3066         (LayoutTestController::numberOfPages):
3067         * DumpRenderTree/chromium/WebViewHost.cpp:
3068         (WebViewHost::printPage):
3069
3070 == Rolled over to ChangeLog-2012-05-22 ==