Test sessionStorage in PSON private browsing mode
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
2
3         Test sessionStorage in PSON private browsing mode
4         https://bugs.webkit.org/show_bug.cgi?id=196561
5
6         Reviewed by Alex Christensen.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
9
10 2019-04-05  Commit Queue  <commit-queue@webkit.org>
11
12         Unreviewed, rolling out r243833.
13         https://bugs.webkit.org/show_bug.cgi?id=196645
14
15         This change breaks build of WPE and GTK ports (Requested by
16         annulen on #webkit).
17
18         Reverted changeset:
19
20         "[CMake][WTF] Mirror XCode header directories"
21         https://bugs.webkit.org/show_bug.cgi?id=191662
22         https://trac.webkit.org/changeset/243833
23
24 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
25
26         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
27         https://bugs.webkit.org/show_bug.cgi?id=196635
28
29         Reviewed by Antti Koivisto.
30         
31         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
32         for a test to enable async frame scrolling via:
33             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
34         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
35         
36         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
37
38         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
39         (WTR::InjectedBundle::beginTesting):
40         * WebKitTestRunner/TestController.cpp:
41         (WTR::TestController::resetPreferencesToConsistentValues):
42
43 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
44
45         Use a correct LC_RPATH when building with ASan
46         https://bugs.webkit.org/show_bug.cgi?id=196576
47
48         Reviewed by David Kilzer.
49
50         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
51         so that ../Frameworks is checked. This is simpler and more reliable than updating
52         each SPC service xcconfig.
53
54 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
55
56         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
57         https://bugs.webkit.org/show_bug.cgi?id=196629
58
59         Reviewed by Lucas Forschler.
60
61         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
62
63 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
64
65         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
66         https://bugs.webkit.org/show_bug.cgi?id=196618
67
68         Reviewed by Lucas Forschler.
69
70         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
71         (StatusBubble): Added QUEUE_TRIGGERS.
72         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
73         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
74         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
75         its parent(builder).
76
77 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
78
79         [ews-app] Status-bubble steps are sometimes displayed in reverse order
80         https://bugs.webkit.org/show_bug.cgi?id=196625
81
82         Reviewed by Lucas Forschler.
83
84         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
85         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
86
87 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
88
89         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
90         https://bugs.webkit.org/show_bug.cgi?id=196630
91
92         Reviewed by Wenson Hsieh.
93
94         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
95
96 2019-04-04  Youenn Fablet  <youenn@apple.com>
97
98         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
99         https://bugs.webkit.org/show_bug.cgi?id=196543
100
101         Reviewed by Alex Christensen.
102
103         * WebKitTestRunner/TestController.cpp:
104         (WTR::TestController::generatePageConfiguration):
105
106 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
107
108         [ews-app] Status bubble should not display skipped buildbot steps
109         https://bugs.webkit.org/show_bug.cgi?id=196584
110
111         Reviewed by Lucas Forschler.
112
113         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
114
115 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
116
117         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
118         https://bugs.webkit.org/show_bug.cgi?id=196620
119
120         Reviewed by Lucas Forschler.
121
122         * BuildSlaveSupport/ews-app/ews/config.py:
123
124 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
125
126         [Win] DumpRenderTreeWatchDog.py is not checked into source
127         https://bugs.webkit.org/show_bug.cgi?id=196567
128         <rdar://problem/49525901>
129
130         Reviewed by Lucas Forschler.
131
132         This script is used on Win EWS bots to terminate hanging DRT processes.
133
134         * EWSTools/dumprendertreewatchdog.py: Added.
135
136 2019-04-04  Chris Dumez  <cdumez@apple.com>
137
138         Unreviewed, roll out r243858 which made tests time out.
139
140         Disable new API tests on Windows instead.
141
142         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
143         (TestWebKitAPI::TEST):
144
145 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
146
147         [ATK] Cleanup WebPageAccessibilityObjectAtk
148         https://bugs.webkit.org/show_bug.cgi?id=196537
149
150         Reviewed by Michael Catanzaro.
151
152         Also consider files under atk directories as exceptions for GObject conventions.
153
154         * Scripts/webkitpy/style/checkers/cpp.py:
155         (check_identifier_name_in_declaration):
156
157 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
158
159         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
160         https://bugs.webkit.org/show_bug.cgi?id=196588
161         <rdar://problem/49365787>
162
163         Unreviewed build fix for Windows port.
164
165         error C3861: 'kill': identifier not found
166
167         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
168         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
169
170 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
171
172         [ews-build] Cancel build and similar operations should have authentication
173         https://bugs.webkit.org/show_bug.cgi?id=196520
174
175         Reviewed by Dewei Zhu.
176
177         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
178         environment variables.
179
180 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
181
182         [ews-build] Do not trigger queues which are not in production yet
183         https://bugs.webkit.org/show_bug.cgi?id=196581
184
185         Reviewed by Dewei Zhu.
186
187         * BuildSlaveSupport/ews-build/config.json:
188
189 2019-04-03  Chris Dumez  <cdumez@apple.com>
190
191         Unreviewed, fix typo in the name of API test added in r243848.
192
193         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
194         (TestWebKitAPI::TEST):
195
196 2019-04-03  Chris Dumez  <cdumez@apple.com>
197
198         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
199         https://bugs.webkit.org/show_bug.cgi?id=196588
200         <rdar://problem/49365787>
201
202         Reviewed by Ryosuke Niwa.
203
204         Add API test coverage.
205
206         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
207         (TestWebKitAPI::nullJavaScriptCallback):
208         (TestWebKitAPI::didCrashCheckFrames):
209         (TestWebKitAPI::TEST):
210
211 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
212
213         run-webkit-tests: Upload test results (new results database)
214         https://bugs.webkit.org/show_bug.cgi?id=196577
215         <rdar://problem/34841155>
216
217         Reviewed by Lucas Forschler.
218
219         * Scripts/webkitpy/layout_tests/controllers/manager.py:
220         (Manager.run): Upload results after each device shard, since the configuration will be
221         different for each device.
222         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
223         uploaded to a results database.
224         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
225         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
226
227 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
228
229         -apple-trailing-word is needed for browser detection
230         https://bugs.webkit.org/show_bug.cgi?id=196575
231
232         Unreviewed.
233
234         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
235
236 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
237
238         [CMake][WTF] Mirror XCode header directories
239         https://bugs.webkit.org/show_bug.cgi?id=191662
240
241         Reviewed by Konstantin Tokarev.
242
243         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
244         builds.
245
246         * CMakeLists.txt:
247         * DumpRenderTree/CMakeLists.txt:
248         * DumpRenderTree/PlatformWin.cmake:
249         * MiniBrowser/win/CMakeLists.txt:
250         * TestWebKitAPI/CMakeLists.txt:
251         * TestWebKitAPI/PlatformWin.cmake:
252         * WebKitTestRunner/PlatformGTK.cmake:
253         * WebKitTestRunner/PlatformWin.cmake:
254
255 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
256
257         [ews-app] Status bubble should not display certain infrastructure status messages
258         https://bugs.webkit.org/show_bug.cgi?id=196550
259
260         Reviewed by Lucas Forschler.
261
262         Do not display the steps which are un-needed for end-user. This information is still avaiable
263         if the user click on the bubble and look at the Buildbot build.
264         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
265         (StatusBubble._steps_messages):
266         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
267
268 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
269
270         [ews-build] Use https for sending data to ews-app
271         https://bugs.webkit.org/show_bug.cgi?id=196492
272
273         Reviewed by Lucas Forschler.
274
275         * BuildSlaveSupport/ews-build/events.py:
276
277 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
278
279         Remove support for -apple-trailing-word
280         https://bugs.webkit.org/show_bug.cgi?id=196525
281
282         Reviewed by Zalan Bujtas.
283
284         This CSS property is nonstandard and not used.
285
286         * Scripts/webkitperl/FeatureList.pm:
287         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
288
289 2019-04-03  Youenn Fablet  <youenn@apple.com>
290
291         Add a test for DOMCache on multiple browsing in case of private browsing
292         https://bugs.webkit.org/show_bug.cgi?id=196524
293
294         Reviewed by Alex Christensen.
295
296         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
297         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
298
299 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
300
301         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
302         https://bugs.webkit.org/show_bug.cgi?id=196540
303
304         Reviewed by Aakash Jain.
305
306         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
307
308 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
309
310         Add plumbing for a compatibility mode preference in WebKit
311         https://bugs.webkit.org/show_bug.cgi?id=196005
312
313         Reviewed by Tim Horton.
314
315         Add new API tests.
316
317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
318         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
319
320 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
321
322         [WPE][GTK] Update libsrtp dependency package for Debian
323         https://bugs.webkit.org/show_bug.cgi?id=196528
324
325         Reviewed by Frédéric Wang.
326
327         * gtk/install-dependencies:
328         * wpe/install-dependencies:
329
330 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
331
332         [WK2] Add support for Window's beforeprint / afterprint events
333         https://bugs.webkit.org/show_bug.cgi?id=196478
334         <rdar://problem/49535124>
335
336         Unreviewed build fix for MSVC.
337
338         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
339
340         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
341
342         * WebKitTestRunner/TestController.cpp:
343         (WTR::printFrame): Use int and float literals.
344
345 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
346
347         [ews-build] Reassign bots to queues
348
349         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
350
351 2019-04-02  Chris Dumez  <cdumez@apple.com>
352
353         [WK2] Add support for Window's beforeprint / afterprint events
354         https://bugs.webkit.org/show_bug.cgi?id=196478
355
356         Reviewed by Alex Christensen.
357
358         Add minimal implementation for printFrame in WebKitTestRunner.
359
360         * WebKitTestRunner/TestController.cpp:
361         (WTR::printFrame):
362         (WTR::TestController::createOtherPage):
363         (WTR::TestController::createWebViewWithOptions):
364
365 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
366
367         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
368         https://bugs.webkit.org/show_bug.cgi?id=196491
369
370         Reviewed by Lucas Forschler.
371
372         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
373
374 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
375
376         [ews-build] Configure buildbot try credentials in environment variables
377         https://bugs.webkit.org/show_bug.cgi?id=196501
378
379         Reviewed by Lucas Forschler.
380
381         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
382         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
383         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
384
385 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
386
387         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
388         https://bugs.webkit.org/show_bug.cgi?id=196496
389         <rdar://problem/49521634>
390
391         Reviewed by Chris Dumez.
392
393         Add new API tests (see WebKit ChangeLog for more detail).
394
395         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
396         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
397         (TEST):
398
399 2019-04-02  David Kilzer  <ddkilzer@apple.com>
400
401         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
402         <https://webkit.org/b/196499>
403
404         Reviewed by Alexey Proskuryakov.
405
406         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
407         ENABLE_ADDRESS_SANITIZER.
408
409 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
410
411         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
412         https://bugs.webkit.org/show_bug.cgi?id=182757
413
414         Reviewed by Don Olmstead.
415
416         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
417         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
418
419 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
420
421         run-api-tests: Upload test results
422         https://bugs.webkit.org/show_bug.cgi?id=196323
423         <rdar://problem/49356714>
424
425         Reviewed by Lucas Forschler.
426
427         * Scripts/webkitpy/api_tests/manager.py:
428         (Manager):
429         (Manager.run): Upload results to a results database.
430         * Scripts/webkitpy/api_tests/run_api_tests.py:
431         (parse_args): Add upload arguments.
432         * Scripts/webkitpy/port/base.py:
433         (Port):
434         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
435         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
436         with commits from any other associated repositories.
437         * Scripts/webkitpy/port/device.py:
438         (Device):
439         (Device.build_version): Access build_versoin of underlying platform device.
440         * Scripts/webkitpy/port/ios_simulator_unittest.py:
441         (IOSSimulatorTest):
442         (IOSSimulatorTest.test_configuration_for_upload):
443         * Scripts/webkitpy/port/device_port.py:
444         (DevicePort):
445         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
446         the same as the machine uploading results.
447         * Scripts/webkitpy/port/mac.py:
448         (MacPort):
449         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
450         * Scripts/webkitpy/port/mac_unittest.py:
451         (MacTest):
452         (MacTest.test_configuration_for_upload):
453         * Scripts/webkitpy/xcode/simulated_device.py:
454         (SimulatedDeviceManager._create_device_with_runtime):
455         (SimulatedDevice.__init__): Create simulated device with a build_version.
456         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
457         (test_existing_simulator):
458
459 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
460
461         Remove extra newline characters (Follow-up fix to r243707)
462
463         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
464
465 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
466
467         [ews-app] Use API_KEY to accept results data
468         https://bugs.webkit.org/show_bug.cgi?id=196461
469
470         Reviewed by Dewei Zhu.
471
472         * BuildSlaveSupport/ews-app/ews/views/results.py:
473         (Results.post): Validate EWS_API_KEY before accepting any data.
474         * BuildSlaveSupport/ews-build/events.py:
475         (Events.sendData): Send EWS_API_KEY if available along with event data.
476
477 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
478
479         Unable to copy and paste a PDF from Notes into Mail compose body
480         https://bugs.webkit.org/show_bug.cgi?id=196442
481         <rdar://problem/48573098>
482
483         Reviewed by Tim Horton.
484
485         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
486         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
487         to be specified on the item providers.
488
489         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
490         (TestWebKitAPI::mapItemForTesting):
491         (TestWebKitAPI::contactItemForTesting):
492
493 2019-04-01  Tim Horton  <timothy_horton@apple.com>
494
495         Make UIWKDocumentContext rects per-character instead of per-word
496         https://bugs.webkit.org/show_bug.cgi?id=196459
497
498         Reviewed by Wenson Hsieh.
499
500         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
501         (TEST):
502         Adjust test results due to switching to per-character rects.
503
504 2019-04-01  Chris Dumez  <cdumez@apple.com>
505
506         UIProcess crash when a prewarmed process is terminated
507         https://bugs.webkit.org/show_bug.cgi?id=196451
508         <rdar://problem/49245471>
509
510         Reviewed by Geoffrey Garen.
511
512         Add API test coverage.
513
514         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
515         (TEST):
516
517 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
518
519         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
520         https://bugs.webkit.org/show_bug.cgi?id=196449
521
522         Reviewed by Lucas Forschler.
523
524         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
525         (StatusBubble.get_os_details): Method to get OS and Xcode details.
526         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
527         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
528
529 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
530
531         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
532         https://bugs.webkit.org/show_bug.cgi?id=196444
533
534         Reviewed by Lucas Forschler.
535
536         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
537
538 2019-04-01  Alex Christensen  <achristensen@webkit.org>
539
540         Add SPI to canonicalize NSURLs with WTF::URL
541         https://bugs.webkit.org/show_bug.cgi?id=196415
542         <rdar://problem/44980271>
543
544         Reviewed by Darin Adler.
545
546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
547         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
548         (TestWebKitAPI::TEST):
549
550 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
551
552         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
553         https://bugs.webkit.org/show_bug.cgi?id=196441
554
555         Reviewed by Carlos Garcia Campos.
556
557         Don't cache the wpe_view_backend object that might not exist yet at the
558         time of EventSenderProxy constructor invocation, but instead retrieve
559         that object whenever it's required for event dispatching. This should
560         avoid crashes in this constructor now that it's invoked before any
561         PlatformWindow has been set up (as changed in r243496).
562
563         * WebKitTestRunner/EventSenderProxy.h:
564         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
565         (WTR::viewBackend):
566         (WTR::EventSenderProxy::EventSenderProxy):
567         (WTR::EventSenderProxy::mouseDown):
568         (WTR::EventSenderProxy::mouseUp):
569         (WTR::EventSenderProxy::mouseMoveTo):
570         (WTR::EventSenderProxy::mouseScrollBy):
571         (WTR::EventSenderProxy::keyDown):
572         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
573
574 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
575
576         [Win][WebKit] MiniBrowser should support high DPI display
577         https://bugs.webkit.org/show_bug.cgi?id=196391
578
579         Reviewed by Alex Christensen.
580
581         * MiniBrowser/win/WebKitBrowserWindow.cpp:
582         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
583         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
584         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
585
586 2019-03-31  Sam Weinig  <weinig@apple.com>
587
588         Remove more i386 specific configurations
589         https://bugs.webkit.org/show_bug.cgi?id=196430
590
591         Reviewed by Alexey Proskuryakov.
592
593         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
594         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
595
596 2019-03-31  Andy Estes  <aestes@apple.com>
597
598         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
599         https://bugs.webkit.org/show_bug.cgi?id=196433
600         <rdar://problem/49293305>
601
602         Reviewed by Tim Horton.
603
604         Enhanced API test coverage to include all navigation response policy decisions in both
605         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
606
607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
608         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
609         (TestWebKitAPI::TEST):
610         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
611         (readFile):
612         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
613         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
614         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
615         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
616         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
617         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
618         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
619         (-[QuickLookDelegate _downloadDidStart:]):
620         (-[QuickLookDelegate _download:didReceiveResponse:]):
621         (-[QuickLookDelegate _download:didReceiveData:]):
622         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
623         (-[QuickLookDelegate _downloadDidFinish:]):
624         (-[QuickLookDelegate _download:didFailWithError:]):
625         (-[QuickLookDelegate _downloadDidCancel:]):
626         (-[QuickLookDelegate verifyDownload]):
627         (runTest):
628         (runTestDecideBeforeLoading):
629         (runTestDecideAfterLoading):
630         (TEST):
631         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
632         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
633         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
634         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
635         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
636         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
637         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
638         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
639         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
640         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
641         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
642         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
643         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
644         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
645
646 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
647
648         [CMake] add testdfg as target with build-jsc
649         https://bugs.webkit.org/show_bug.cgi?id=196393
650
651         Reviewed by Saam Barati.
652
653         Added testdfg as one of the targets to build when
654         using CMake.
655
656         * Scripts/build-jsc:
657
658 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
659
660         Delete WebMetal implementation in favor of WebGPU
661         https://bugs.webkit.org/show_bug.cgi?id=195418
662
663         Reviewed by Dean Jackson.
664
665         * DumpRenderTree/mac/DumpRenderTree.mm:
666         (enableExperimentalFeatures):
667         (resetWebPreferencesToConsistentValues):
668         * Scripts/webkitperl/FeatureList.pm:
669         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
671         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
672         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
673         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
674         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
675         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
676         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
677         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
678         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
679         (WTR::InjectedBundle::beginTesting):
680         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
681         (WTR::TestRunner::setWebMetalEnabled): Deleted.
682         * WebKitTestRunner/InjectedBundle/TestRunner.h:
683
684 2019-03-29  Chris Dumez  <cdumez@apple.com>
685
686         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
687         https://bugs.webkit.org/show_bug.cgi?id=196405
688         <rdar://problem/49428130>
689
690         Reviewed by Wenson Hsieh.
691
692         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
693         the popover presentation methods to be no-ops. Use this in the new test added in
694         r243523 so that we do not swizzle those methods for all tests. This is needed because
695         those WatchOS tests rely on the popover getting presented and interactive.
696
697         * WebKitTestRunner/TestController.cpp:
698         (WTR::updateTestOptionsFromTestHeader):
699         * WebKitTestRunner/TestController.h:
700         * WebKitTestRunner/TestOptions.h:
701         (WTR::TestOptions::hasSameInitializationOptions const):
702         * WebKitTestRunner/ios/TestControllerIOS.mm:
703         (WTR::TestController::platformInitialize):
704         (WTR::TestController::platformResetStateToConsistentValues):
705
706 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
707
708         [Curl] Add Server Trust Evaluation Support.
709         https://bugs.webkit.org/show_bug.cgi?id=191646
710
711         Reviewed by Fujii Hironori.
712
713         Implemented MiniBrowser UI for asking if user trusts the server.
714
715         * MiniBrowser/win/Common.cpp:
716         (askServerTrustEvaluation):
717         (replaceString):
718         * MiniBrowser/win/Common.h:
719         * MiniBrowser/win/MiniBrowserLib.rc:
720         * MiniBrowser/win/MiniBrowserLibResource.h:
721         * MiniBrowser/win/WebKitBrowserWindow.cpp:
722         (createPEMString):
723         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
724         (WebKitBrowserWindow::canTrustServerCertificate):
725         * MiniBrowser/win/WebKitBrowserWindow.h:
726
727 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
728
729         Implement ResizeObserver.
730         https://bugs.webkit.org/show_bug.cgi?id=157743
731
732         Reviewed by Simon Fraser.
733
734         Support resizeObserverEnabled webPreferences.
735
736         * DumpRenderTree/TestOptions.cpp:
737         (TestOptions::TestOptions):
738         * DumpRenderTree/TestOptions.h:
739         * DumpRenderTree/mac/DumpRenderTree.mm:
740         (setWebPreferencesForTestOptions):
741         * DumpRenderTree/win/DumpRenderTree.cpp:
742         (enableExperimentalFeatures):
743         * Scripts/webkitperl/FeatureList.pm:
744         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
745
746 2019-03-28  John Wilander  <wilander@apple.com>
747
748         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
749         https://bugs.webkit.org/show_bug.cgi?id=196281
750         <rdar://problem/48938748>
751
752         Reviewed by Alex Christensen.
753
754         This patch adds the function isStatisticsHasLocalStorage() to the
755         TestRunner. With it, the page can query the WebsiteDataStore in the
756         UI process to make sure that it sees LocalStorage.
757
758         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
759         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
760         (WTR::TestRunner::isStatisticsHasLocalStorage):
761         * WebKitTestRunner/InjectedBundle/TestRunner.h:
762         * WebKitTestRunner/TestController.cpp:
763         (WTR::TestController::isStatisticsHasLocalStorage):
764         * WebKitTestRunner/TestController.h:
765         * WebKitTestRunner/TestInvocation.cpp:
766         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
767
768 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
769
770         API::Data::createWithoutCopying should do a null check before calling CFRelease
771         https://bugs.webkit.org/show_bug.cgi?id=196276
772         <rdar://problem/48059859>
773
774         Reviewed by Alex Christensen.
775
776         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
777
778         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
779         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
780         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
781         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
782         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
783         (TestWebKitAPI::TEST):
784
785 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
786
787         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
788         https://bugs.webkit.org/show_bug.cgi?id=186276
789
790         Reviewed by Carlos Garcia Campos.
791
792         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
793         (webViewLoadChanged):
794         (testWebResourceGetDataError):
795         (testWebResourceGetDataEmpty):
796         (beforeAll):
797         (webViewloadChanged): Deleted.
798
799 2019-03-27  Andy Estes  <aestes@apple.com>
800
801         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
802         https://bugs.webkit.org/show_bug.cgi?id=196317
803
804         Reviewed by Dan Bernstein.
805
806         package-root copies built products into a staging directory using ditto(1), which does not
807         follow symbolic links as it traverses a directory. Now that the files in
808         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
809         itself, these become broken links when ditto'd into the staging directory.
810
811         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
812
813         * Scripts/package-root:
814
815 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
816
817         [ews-app] Update display text of Submit for ews analysis
818         https://bugs.webkit.org/show_bug.cgi?id=196309
819
820         Reviewed by Dewei Zhu.
821
822         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
823
824 2019-03-27  David Kilzer  <ddkilzer@apple.com>
825
826         run-webkit-tests should check for leaks in WebKit processes
827         <https://webkit.org/b/193772>
828         <rdar://problem/46526680>
829
830         Reviewed by Ryosuke Niwa.
831
832         This works by doing the following:
833         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
834           The list of child processes are returned one per line:
835           process.name: pid
836         - Run the "#LIST CHILD PROCESSES" command just before the
837           "#CHECK FOR WORLD LEAKS" command, and store the list of child
838           processes on the ServerProcess object.
839         - When the `--leaks` switch is handled, run check_for_leaks() on
840           each child process after the main test harness.
841
842         * DumpRenderTree/mac/DumpRenderTree.mm:
843         (handleControlCommand):
844         - Use strncmp() instead of strcmp().
845         - Add support for handling "#LIST CHILD PROCESSES" command.
846
847         * Scripts/webkitpy/port/base.py:
848         (Port.check_for_leaks):
849         * Scripts/webkitpy/port/darwin.py:
850         (DarwinPort.check_for_leaks):
851         - Rename redundant 'process_pid' argument to 'process_id'.
852
853         * Scripts/webkitpy/port/driver.py:
854         (Driver.do_post_tests_work):
855         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
856           longer the only command this sends to WebKitTestRunner.
857         - If the `--leaks` switch is present, send the
858           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
859           result using Port.set_webkit_processes().
860         (Driver._parse_child_processes_output):
861         - Add helper method to parse list of child process names and
862           process IDs returned from WebKitTestRunner.
863
864         * Scripts/webkitpy/port/ios_device.py:
865         (IOSDevicePort.check_for_leaks):
866         - Rename redundant 'process_pid' argument to 'process_id'.
867
868         * Scripts/webkitpy/port/leakdetector.py:
869         (LeakDetector._parse_leaks_output):
870         - Return early if there is no leaks_output.
871         (LeakDetector.check_for_leaks):
872         - Rename redundant 'process_pid' argument to 'process_id'.
873
874         * Scripts/webkitpy/port/server_process.py:
875         (ServerProcess.__init__):
876         (ServerProcess.child_processes):
877         (ServerProcess.set_child_processes):
878         - Add instance variable to Port to store list of child process
879           names and process IDs returned from WebKitTestRunner.
880         (ServerProcess._start):
881         - Clear self._child_processes.
882         (ServerProcess.stop):
883         - If self._child_processes is set, call
884           self._port.check_for_leaks() for each child process.
885
886         * Scripts/webkitpy/port/server_process_unittest.py:
887         (TrivialMockPort.check_for_leaks):
888         - Rename redundant 'process_pid' argument to 'process_id'.
889
890         * Scripts/webkitpy/port/simulator_process.py:
891         (SimulatorProcess.stop):
892         - If self._child_processes is set, call
893           self._port.check_for_leaks() for each child process.
894
895         * Scripts/webkitpy/port/watch_device.py:
896         (WatchDevicePort.check_for_leaks):
897         - Rename redundant 'process_pid' argument to 'process_id'.
898
899         * WebKitTestRunner/TestController.cpp:
900         (WTR::TestController::dumpResponse):
901         - Extract method from findAndDumpWorldLeaks() so that it may be
902           reused by findAndDumpWebKitProcessIdentifiers().
903         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
904         - Add method to output process name and process ID of both the
905           WebContent and Networking processes.
906         (WTR::TestController::findAndDumpWorldLeaks):
907         - Fix missing newline in output when there were no abandoned
908           documents.
909         - Call dumpResponse() for extracted code.
910         (WTR::TestController::handleControlCommand):
911         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
912         - Use strncmp() instead of strcmp().
913         - Call findAndDumpWebKitProcessIdentifiers() when
914           "#LIST CHILD PROCESSES" command is sent.
915         * WebKitTestRunner/TestController.h:
916         (WTR::TestController::dumpResponse):
917         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
918         - Declare methods.
919
920 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
921
922         Unreviewed. Add GLib API test cases after r243434.
923
924         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
925         (testWebViewActiveURI):
926         (serverCallback):
927         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
928         (sendRequestCallback):
929
930 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
931
932         Geolocation request not complete when watch request was started in a different web process
933         https://bugs.webkit.org/show_bug.cgi?id=195996
934
935         Reviewed by Alex Christensen.
936
937         Add a test case.
938
939         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
940         (TestWebKitAPI::runJavaScriptAlert):
941         (TestWebKitAPI::TEST):
942
943 2019-03-26  Keith Rollin  <krollin@apple.com>
944
945         Update the way generate-xcfilelists returns strings from functions
946         https://bugs.webkit.org/show_bug.cgi?id=195975
947         <rdar://problem/49040807>
948
949         Reviewed by Dean Jackson.
950
951         There are places where generate-xcfilelists executes assignments with
952         statements like:
953
954             FOO=$(some_function)
955
956         where "some_function" return a string by echoing it. E.g.
957
958             some_function()
959             {
960                 echo "Hello, World"
961             }
962
963         This is a common idiom, but it has a problem if "some_function" needs
964         to call "exit" in an attempt to halt the entire script right then and
965         there. Since "some_function" is called inside of $(), it's being
966         executed in a sub-shell. Calling exit in that sub-shell simply exits
967         that shell; it doesn't not exit the outer shell in which the main part
968         of the script is still running. As such, the main script keeps
969         executing when the intent was for the script to halt.
970
971         The solution to this is to use a different idiom for returning
972         strings. The one we now is to pass in the name of the variable to
973         receive the string result:
974
975             some_function()
976             {
977                 variable_name=$1
978                 eval $variable_name ="Hello, World"
979             }
980
981         The call site now looks like
982
983             some_function FOO
984
985         Because there's no invocation of a sub-shell, some_function can now
986         call "exit" if it wants to, and the entire script will exit at that
987         point.
988
989         * Scripts/generate-xcfilelists:
990
991 2019-03-26  Chris Dumez  <cdumez@apple.com>
992
993         Add basic layout test coverage for File Picker on iOS
994         https://bugs.webkit.org/show_bug.cgi?id=196265
995
996         Reviewed by Wenson Hsieh.
997
998         Add layout test infrastructure to test the file picker on iOS.
999
1000         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1001         (WTR::UIScriptController::dismissFilePicker):
1002         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1003         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1004         (WTR::UIScriptController::dismissFilePicker):
1005         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1006         * WebKitTestRunner/TestController.cpp:
1007         (WTR::TestController::createWebViewWithOptions):
1008         (WTR::updateTestOptionsFromTestHeader):
1009         * WebKitTestRunner/TestOptions.h:
1010         (WTR::TestOptions::hasSameInitializationOptions const):
1011         * WebKitTestRunner/ios/TestControllerIOS.mm:
1012         (overridePresentViewController):
1013         (WTR::TestController::platformInitialize):
1014         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1015         (WTR::UIScriptController::dismissFilePicker):
1016
1017 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1018
1019         Implement async paste method on UIWKInteractionViewProtocol
1020         https://bugs.webkit.org/show_bug.cgi?id=196267
1021         <rdar://problem/49236346>
1022
1023         Reviewed by Tim Horton.
1024
1025         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1026         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1027         are now a part of all iOS 12 internal SDKs.
1028
1029         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1030
1031         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1032         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1033
1034         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1035         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1036         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1037         * TestWebKitAPI/ios/UIKitSPI.h:
1038
1039 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1040
1041         [ews-build] Use PostgreSQL for ews.webkit.org database
1042         https://bugs.webkit.org/show_bug.cgi?id=196270
1043
1044         Reviewed by Lucas Forschler.
1045
1046         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1047
1048 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1049
1050         [ews] Reset simctl states on reboot
1051         https://bugs.webkit.org/show_bug.cgi?id=196260
1052
1053         Rubber-stamped by Aakash Jain.
1054
1055         * EWSTools/start-queue-mac.sh:
1056
1057 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1058
1059         [ews-build] Use PostgreSQL for ews-build database
1060         https://bugs.webkit.org/show_bug.cgi?id=196229
1061
1062         Reviewed by Lucas Forschler.
1063
1064         * BuildSlaveSupport/ews-build/master.cfg:
1065
1066 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1067
1068         [ews-build] Get master_hostname dynamically in master.cfg
1069         https://bugs.webkit.org/show_bug.cgi?id=196255
1070
1071         Reviewed by Lucas Forschler.
1072
1073         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1074         send events data in test mode.
1075
1076 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1077
1078         [ews-app] Set db_constraint to False for Foreign Keys
1079         https://bugs.webkit.org/show_bug.cgi?id=196252
1080
1081         Reviewed by Lucas Forschler.
1082
1083         * BuildSlaveSupport/ews-app/ews/models/build.py:
1084         * BuildSlaveSupport/ews-app/ews/models/step.py:
1085
1086 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1087
1088         [ews-build] is_test_mode_enabled should default to True
1089         https://bugs.webkit.org/show_bug.cgi?id=196248
1090
1091         Reviewed by Lucas Forschler.
1092
1093         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1094
1095 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1096
1097         [ews-app] Add webkitperl to ENABLED_QUEUES
1098         https://bugs.webkit.org/show_bug.cgi?id=196253
1099
1100         Reviewed by Lucas Forschler.
1101
1102         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1103
1104 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1105
1106         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1107         https://bugs.webkit.org/show_bug.cgi?id=196211
1108         rdar://problem/49110552
1109
1110         Reviewed by Tim Horton.
1111
1112         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1113         Make sure that EventSenderProxy always exists when running tests. We used to create
1114         it when resetting before the first test, which is a bit too late.
1115
1116         * WebKitTestRunner/TestController.h:
1117         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1118         (WTR::TestController::platformCreateWebView):
1119         (WTR::TestController::platformCreateOtherPage):
1120         (WTR::TestController::finishCreatingPlatformWebView):
1121         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1122         (WTR::PlatformWebView::PlatformWebView):
1123         Moved some code that made NSWindow use NSEvent during web view creation. We may
1124         need to move more if some other case us found, but this is enough for now.
1125
1126 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1127
1128         Unreviewed. Fix typo in GLib geolocation API after r243285.
1129
1130         gelocation -> geolocation.
1131
1132         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1133         (testGeolocationManagerWatchPosition):
1134
1135 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1136
1137         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1138         https://bugs.webkit.org/show_bug.cgi?id=196213
1139
1140         Reviewed by Geoff Garen.
1141
1142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1143         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1144         (credentialWithIdentityAndKeychainPath):
1145         (-[ChallengeDelegate webView:didFinishNavigation:]):
1146         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1147         (TestWebKitAPI::TEST):
1148
1149 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1150
1151         Expected shouldn't assume its contained types are copyable
1152         https://bugs.webkit.org/show_bug.cgi?id=195986
1153
1154         Reviewed by JF Bastien.
1155
1156         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1157         (TestWebKitAPI::NonCopyable::operator== const):
1158         (TestWebKitAPI::NonCopyable::operator!= const):
1159         (TestWebKitAPI::TEST):
1160
1161 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1162
1163         Remove some now-unnecessary dynamic class lookup
1164         https://bugs.webkit.org/show_bug.cgi?id=196237
1165
1166         Reviewed by Simon Fraser.
1167
1168         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1169         (makeRequest):
1170         (TEST):
1171
1172 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1173
1174         Unreviewed, rolling out r243450.
1175
1176         AppleWin and WinCairo port builds get broken.
1177
1178         Reverted changeset:
1179
1180         "Add test for fix of #196095"
1181         https://bugs.webkit.org/show_bug.cgi?id=196097
1182         https://trac.webkit.org/changeset/243450
1183
1184 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1185
1186         Unreviewed, rolling out r243465.
1187         https://bugs.webkit.org/show_bug.cgi?id=196226
1188
1189         the test doesn't build (Requested by thorton on #webkit).
1190
1191         Reverted changeset:
1192
1193         "Do not terminate the NetworkProcess if a third party
1194         application sends a NSCredential with a SecIdentityRef"
1195         https://bugs.webkit.org/show_bug.cgi?id=196213
1196         https://trac.webkit.org/changeset/243465
1197
1198 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1199
1200         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1201         https://bugs.webkit.org/show_bug.cgi?id=196213
1202
1203         Reviewed by Geoff Garen.
1204
1205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1206         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1207         (credentialWithIdentityAndKeychainPath):
1208         (-[ChallengeDelegate webView:didFinishNavigation:]):
1209         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1210         (TestWebKitAPI::TEST):
1211
1212 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1213
1214         [ews-build] Gracefully handle missing patch_id in events
1215         https://bugs.webkit.org/show_bug.cgi?id=196216
1216
1217         Reviewed by Lucas Forschler.
1218
1219         * BuildSlaveSupport/ews-build/events.py:
1220
1221 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1222
1223         [ews-build] use lz4 compression for improving buildbot performance
1224         https://bugs.webkit.org/show_bug.cgi?id=196155
1225
1226         Reviewed by Lucas Forschler.
1227
1228         * BuildSlaveSupport/ews-build/master.cfg:
1229
1230 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1231
1232         Pull some API testing helper methods out of TestWKWebView
1233         https://bugs.webkit.org/show_bug.cgi?id=196212
1234
1235         Reviewed by Tim Horton.
1236
1237         Refactor some more API testing utility methods, so that they can be used in
1238         tests that do not use TestWKWebView.
1239
1240         * TestWebKitAPI/cocoa/TestWKWebView.h:
1241         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1242         (-[WKWebView loadTestPageNamed:]):
1243         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1244         (-[WKWebView synchronouslyLoadHTMLString:]):
1245         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1246         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1247         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1248         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1249         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1250
1251 2019-03-25  Jer Noble  <jer.noble@apple.com>
1252
1253         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1254         https://bugs.webkit.org/show_bug.cgi?id=196097
1255
1256         Reviewed by Eric Carlson.
1257
1258         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1259
1260         * DumpRenderTree/mac/DumpRenderTree.mm:
1261         (resetWebPreferencesToConsistentValues):
1262         * WebKitTestRunner/TestController.cpp:
1263         (WTR::TestController::resetPreferencesToConsistentValues):
1264
1265 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1266
1267         Pull IPadUserInterfaceSwizzler out into a separate header file
1268         https://bugs.webkit.org/show_bug.cgi?id=196193
1269
1270         Reviewed by Anders Carlsson.
1271
1272         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1273         be used in other API tests.
1274
1275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1276         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1277         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1278         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1279         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1280         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1281         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1282
1283 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1284
1285         Remove NavigatorContentUtils in WebCore/Modules
1286         https://bugs.webkit.org/show_bug.cgi?id=196070
1287
1288         Reviewed by Alex Christensen.
1289
1290         NavigatorContentUtils was to support the custom scheme spec [1].
1291         However, in WebKit side, no port has supported the feature in
1292         WebKit layer after EFL port was removed. So there has been the
1293         only IDL implementation of the NavigatorContentUtils in WebCore.
1294         So we don't need to keep the implementation in WebCore anymore.
1295
1296         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1297
1298         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1299
1300 2019-03-24  Andy Estes  <aestes@apple.com>
1301
1302         [watchOS] Remove unused Proximity Networking code
1303         https://bugs.webkit.org/show_bug.cgi?id=196188
1304
1305         Reviewed by Tim Horton.
1306
1307         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1308         (TEST):
1309
1310 2019-03-23  Keith Miller  <keith_miller@apple.com>
1311
1312         Refactor clz/ctz and fix getLSBSet.
1313         https://bugs.webkit.org/show_bug.cgi?id=196162
1314
1315         Reviewed by Saam Barati.
1316
1317         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1318
1319         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1320         (TestWebKitAPI::TEST):
1321
1322 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1323
1324         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1325         https://bugs.webkit.org/show_bug.cgi?id=196143
1326
1327         Reviewed by Michael Catanzaro.
1328
1329         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1330         directories.
1331
1332         * Scripts/webkitpy/style/checkers/cpp.py:
1333         (check_identifier_name_in_declaration):
1334         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1335         (WebKitStyleTest.test_names):
1336
1337 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1338
1339         [Flatpak] Manifest expanding fails for qt WPE extension
1340         https://bugs.webkit.org/show_bug.cgi?id=196148
1341
1342         Reviewed by Alex Christensen.
1343
1344         * flatpak/flatpakutils.py:
1345         (expand_submodules_recurse): The last recurse manifest expand
1346         iteration might lead to a single module so take it into account
1347         and don't try to recurse further.
1348
1349 2019-03-22  Chris Dumez  <cdumez@apple.com>
1350
1351         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1352         https://bugs.webkit.org/show_bug.cgi?id=195348
1353         <rdar://problem/48622090>
1354
1355         Reviewed by Alex Christensen.
1356
1357         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1358         to NO when test.options().shouldIgnoreMetaViewport is false.
1359
1360         * WebKitTestRunner/ios/TestControllerIOS.mm:
1361         (WTR::TestController::platformConfigureViewForTest):
1362
1363 2019-03-22  Chris Dumez  <cdumez@apple.com>
1364
1365         Prewarmed processes should be usable with any website data store
1366         https://bugs.webkit.org/show_bug.cgi?id=196104
1367
1368         Reviewed by Alex Christensen.
1369
1370         Add API test coverage.
1371
1372         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1373         (runInitialWarmedProcessUsedTest):
1374         (TEST):
1375
1376 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1377
1378         Back out local changes to Alex's Subversion working directory
1379
1380         They were accidentally committed.
1381
1382         * Scripts/webkitpy/common/system/abstractexecutive.py:
1383         (AbstractExecutive.wait_newest):
1384         * Scripts/webkitpy/common/system/executive.py:
1385         (Executive.running_pids):
1386         * Scripts/webkitpy/common/system/executive_mock.py:
1387         (MockExecutive.running_pids):
1388         * Scripts/webkitpy/common/system/executive_unittest.py:
1389         (ExecutiveTest.serial_test_running_pids):
1390         * Scripts/webkitpy/port/darwin.py:
1391         (DarwinPort.check_for_leaks):
1392         * Scripts/webkitpy/port/leakdetector.py:
1393         (LeakDetector.check_for_leaks):
1394         - This was the hack attached to Bug 193772.
1395
1396         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1397         (+[WebKitTestRunnerEvent mouseLocation]):
1398         - This works around a crash on an internal build.
1399
1400 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1401
1402         Fix the build after r243354
1403         https://bugs.webkit.org/show_bug.cgi?id=196138
1404         <rdar://problem/49145951>
1405
1406         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1407         (TEST):
1408         * TestWebKitAPI/ios/UIKitSPI.h:
1409
1410 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1411
1412         Adopt UIWKDocumentContext
1413         https://bugs.webkit.org/show_bug.cgi?id=196040
1414         <rdar://problem/48642440>
1415
1416         Reviewed by Ryosuke Niwa.
1417
1418         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1419         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1420         (makeRequest):
1421         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1422         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1423         (applyStyle):
1424         (TEST):
1425         Add tests for UIWKDocumentContext.
1426
1427         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1428         (TEST):
1429         (recursiveFindWKContentView): Deleted.
1430         * TestWebKitAPI/cocoa/TestWKWebView.h:
1431         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1432         (recursiveFindWKContentView):
1433         (-[TestWKWebView wkContentView]):
1434         * TestWebKitAPI/ios/UIKitSPI.h:
1435         Share the WKContentView finding code between tests.
1436
1437 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1438
1439         [iOS WK2] Turn on async overflow scrolling by default
1440         https://bugs.webkit.org/show_bug.cgi?id=196011
1441         rdar://problem/48453859
1442
1443         Reviewed by Antti Koivisto.
1444         
1445         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1446         since so many basic layout tests have different results when compositing is triggered for
1447         overflow.
1448         
1449         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1450
1451         * WebKitTestRunner/TestController.cpp:
1452         (WTR::TestController::resetPreferencesToConsistentValues):
1453
1454 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1455
1456         [ews-build] Retry API test in case of failures
1457         https://bugs.webkit.org/show_bug.cgi?id=196004
1458
1459         Reviewed by Lucas Forschler.
1460
1461         * BuildSlaveSupport/ews-build/steps.py:
1462         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1463         (CompileWebKitToT.doStepIf): Ditto.
1464         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1465         (ReRunAPITests): Re-run API tests.
1466         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1467         (RunAPITestsWithoutPatch): Run API tests without patch.
1468         (RunAPITestsWithoutPatch.doStepIf):
1469         (RunAPITestsWithoutPatch.hideStepIf):
1470         (RunAPITestsWithoutPatch.evaluateCommand):
1471         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1472         (AnalyzeAPITestsResults.start):
1473         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1474         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1475         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1476         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1477
1478 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1479
1480         [ews-build] Update queues configurations
1481         https://bugs.webkit.org/show_bug.cgi?id=196074
1482
1483         Reviewed by Dewei Zhu.
1484
1485         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1486         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1487
1488 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1489
1490         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1491         https://bugs.webkit.org/show_bug.cgi?id=195680
1492         <rdar://problem/48903534>
1493
1494         Unreviewed infrastructure fix.
1495
1496         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1497         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1498
1499 2019-03-21  Andy Estes  <aestes@apple.com>
1500
1501         [iOS] Apple Pay should be available in documents with no user agent scripts
1502         https://bugs.webkit.org/show_bug.cgi?id=196061
1503         <rdar://problem/48649391>
1504
1505         Reviewed by Brady Eidson.
1506
1507         Added API tests and related infrastructure.
1508
1509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1510         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1511         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1512         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1513         (TestWebKitAPI::TEST):
1514         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1515         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1516         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1517         * TestWebKitAPI/cocoa/TestProtocol.mm:
1518         (-[TestProtocol startLoading]):
1519         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1520         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1521         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1522         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1523
1524 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1525
1526         REGRESSSION (r243297): webkitpy tests broken
1527         https://bugs.webkit.org/show_bug.cgi?id=196108
1528
1529         Reviewed by Aakash Jain.
1530
1531         r243297 updated contributors.json, which broke a few unit tests.
1532
1533         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1534         (IRCCommandTest.test_whois):
1535         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1536
1537 2019-03-21  Chris Dumez  <cdumez@apple.com>
1538
1539         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1540         https://bugs.webkit.org/show_bug.cgi?id=196041
1541         <rdar://problem/49083230>
1542
1543         Reviewed by Alex Christensen.
1544
1545         Add API test coverage.
1546
1547         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1548         (TEST):
1549
1550 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1551
1552         Add SPI to inform applications of WKContentRuleList actions
1553         https://bugs.webkit.org/show_bug.cgi?id=195965
1554         <rdar://problem/42664365>
1555
1556         Reviewed by Geoff Garen.
1557
1558         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1559         (TestWebKitAPI::allActionsForResourceLoad):
1560         (TestWebKitAPI::testRequest):
1561         (TestWebKitAPI::TEST_F):
1562         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1563         (Notification::description):
1564         (Notification::operator== const):
1565         (toVector):
1566         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1567         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1568         (makeContentRuleList):
1569         (TEST):
1570         (makeWarnContentRuleList): Deleted.
1571
1572 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1573
1574         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1575         https://bugs.webkit.org/show_bug.cgi?id=196088
1576
1577         Reviewed by Brian Burg.
1578
1579         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1580         Support checks when only one platform is specified. Also deprecate macosx() and
1581         force the use of macos() instead.
1582
1583         * Scripts/webkitpy/style/checkers/cpp.py:
1584         (check_min_versions_of_wk_api_available):
1585         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1586         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1587
1588 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1589
1590         Update status inactive committers' status to 'contributor'.
1591
1592         * Scripts/webkitpy/common/config/contributors.json:
1593
1594 2019-03-21  Xan Lopez  <xan@igalia.com>
1595
1596         [JSC][x86] Drop support for x87 floating point
1597         https://bugs.webkit.org/show_bug.cgi?id=194853
1598
1599         Reviewed by Don Olmstead.
1600
1601         Force SSE2 on x86/32bit builds.
1602
1603         * Scripts/webkitdirs.pm:
1604         (generateBuildSystemFromCMakeProject):
1605
1606 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1607
1608         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1609         https://bugs.webkit.org/show_bug.cgi?id=196073
1610
1611         Reviewed by Michael Catanzaro.
1612
1613         Add test cases to check functions and constructors with no arguments but receiving user data.
1614
1615         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1616         (checkUserData):
1617         (testJSCFunction):
1618         (fooCreateWithUserData):
1619         (testJSCClass):
1620
1621 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1622
1623         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1624
1625         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1626
1627         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1628
1629 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1630
1631         [GTK][WPE] Add API to provide geolocation information
1632         https://bugs.webkit.org/show_bug.cgi?id=195940
1633
1634         Reviewed by Michael Catanzaro.
1635
1636         Add a new test to check the new API.
1637
1638         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1639         (testGeolocationManagerCurrentPosition):
1640         (testGeolocationManagerWatchPosition):
1641         (beforeAll):
1642         (afterAll):
1643         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1644         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1645         (beforeAll): Ditto.
1646         * TestWebKitAPI/glib/CMakeLists.txt:
1647
1648 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1649
1650         [GLib] Returning G_TYPE_OBJECT from a method does not work
1651         https://bugs.webkit.org/show_bug.cgi?id=195574
1652
1653         Reviewed by Michael Catanzaro.
1654
1655         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1656
1657         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1658         (getGFile):
1659         (getParent):
1660         (createGString):
1661         (getGString):
1662         (getGStringCopyWillRaise):
1663         (getGStringCopy):
1664         (getGStringStr):
1665         (getGStringLen):
1666         (freeGString):
1667         (testJSCClass):
1668
1669 2019-03-20  Saam Barati  <sbarati@apple.com>
1670
1671         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1672         https://bugs.webkit.org/show_bug.cgi?id=195721
1673
1674         Reviewed by Filip Pizlo.
1675
1676         * Scripts/run-javascriptcore-tests:
1677
1678 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1679
1680         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1681         https://bugs.webkit.org/show_bug.cgi?id=196049
1682
1683         Reviewed by Tim Horton.
1684
1685         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1686         overflow scrolling in general, so rename it.
1687
1688         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1689
1690 2019-03-20  Daniel Bates  <dabates@apple.com>
1691
1692         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1693         https://bugs.webkit.org/show_bug.cgi?id=196031
1694         <rdar://problem/49078172>
1695
1696         Reviewed by Tim Horton.
1697
1698         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1699         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1700         same code path used when the Done button is pressed to dismiss the <select> picker.
1701
1702         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1703         (TestWebKitAPI::TEST):
1704
1705 2019-03-20  Chris Dumez  <cdumez@apple.com>
1706
1707         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1708         https://bugs.webkit.org/show_bug.cgi?id=196029
1709         <rdar://problem/48954651>
1710
1711         Reviewed by Tim Horton.
1712
1713         Add API test coverage.
1714
1715         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1716
1717 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1718
1719         [ews-build] Improve failure summary string for ApplyPatch step
1720         https://bugs.webkit.org/show_bug.cgi?id=195995
1721
1722         Reviewed by Alexey Proskuryakov.
1723
1724         * BuildSlaveSupport/ews-build/steps.py:
1725         (ApplyPatch.getResultSummary): Override getResultSummary.
1726
1727 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1728
1729         AX: Implement support for new meter ARIA role
1730         https://bugs.webkit.org/show_bug.cgi?id=195966
1731
1732         Reviewed by Chris Fleizach.
1733
1734         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1735         to AXLevelIndicator.
1736
1737         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1738
1739 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1740
1741         [WebAuthN] Implement FIDO AppID extension
1742         https://bugs.webkit.org/show_bug.cgi?id=143491
1743         <rdar://problem/48298273>
1744
1745         Reviewed by Brent Fulgham.
1746
1747         Add a test that covers the new flag of convertToU2fSignCommand.
1748
1749         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1750         (TestWebKitAPI::TEST):
1751         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1752         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1753         (TestWebKitAPI::TEST):
1754
1755 2019-03-19  Keith Rollin  <krollin@apple.com>
1756
1757         Add support for more platforms to generate-xcfilelists
1758         https://bugs.webkit.org/show_bug.cgi?id=195977
1759
1760         Reviewed by Alexey Proskuryakov.
1761
1762         generate-xcfilelists incorrectly complains when involved with building
1763         WebKit for iphonesimulator:
1764
1765             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1766             …
1767             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1768
1769         Address this by teaching generate-xcfilelists about more platforms.
1770
1771         * Scripts/generate-xcfilelists:
1772
1773 2019-03-19  John Wilander  <wilander@apple.com>
1774
1775         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1776         https://bugs.webkit.org/show_bug.cgi?id=195923
1777         <rdar://problem/49001272>
1778
1779         Reviewed by Alex Christensen.
1780
1781         This patch does the following to the TestRunner:
1782         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1783         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1784         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1785
1786         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1787         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1788         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1789         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1790         * WebKitTestRunner/TestController.cpp:
1791         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1792         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1793         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1794         * WebKitTestRunner/TestController.h:
1795         * WebKitTestRunner/TestInvocation.cpp:
1796         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1797
1798 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1799
1800         [CMake] Support more clang and gcc sanitizers
1801         https://bugs.webkit.org/show_bug.cgi?id=195956
1802
1803         Reviewed by Michael Catanzaro.
1804
1805         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1806
1807 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1808
1809         [ews-build] Improve summary for PrintConfiguration step
1810         https://bugs.webkit.org/show_bug.cgi?id=195945
1811
1812         Reviewed by Lucas Forschler.
1813
1814         * BuildSlaveSupport/ews-build/steps.py:
1815         (PrintConfiguration.getResultSummary): Override getResultSummary.
1816
1817 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1818
1819         [ews-build] Improve summary for CheckOutSource step
1820         https://bugs.webkit.org/show_bug.cgi?id=195963
1821
1822         Reviewed by Lucas Forschler.
1823
1824         * BuildSlaveSupport/ews-build/steps.py:
1825         (CheckOutSource.getResultSummary):
1826
1827 2019-03-19  Daniel Bates  <dabates@apple.com>
1828
1829         [iOS] Focus not preserved when switching between tabs
1830         https://bugs.webkit.org/show_bug.cgi?id=195820
1831         <rdar://problem/43614450>
1832
1833         Reviewed by Brent Fulgham.
1834
1835         Add tests to ensure that we restore focus when resigning and becoming first responder.
1836
1837         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1838         (TestWebKitAPI::TEST):
1839
1840 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1841
1842         Make WTFLogChannelState and WTFLogLevel enum classes
1843         https://bugs.webkit.org/show_bug.cgi?id=195904
1844
1845         Reviewed by Eric Carlson.
1846
1847         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1848         (TestWebKitAPI::TEST_F):
1849
1850 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1851
1852         [GStreamer][EME] Backported mssdemux protection data crash fix
1853         https://bugs.webkit.org/show_bug.cgi?id=195918
1854
1855         Reviewed by Philippe Normand.
1856
1857         * gstreamer/jhbuild.modules:
1858         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1859
1860 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1861
1862         Unreviewed, rolling out r243132.
1863
1864         Broke GTK build
1865
1866         Reverted changeset:
1867
1868         "Make WTFLogChannelState and WTFLogLevel enum classes"
1869         https://bugs.webkit.org/show_bug.cgi?id=195904
1870         https://trac.webkit.org/changeset/243132
1871
1872 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1873
1874         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1875
1876         * Scripts/webkitdirs.pm:
1877         (builtDylibPathForName): Adjust the shared library name that's changed
1878         with the API version bump in r243073.
1879
1880 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1881
1882         Make WTFLogChannelState and WTFLogLevel enum classes
1883         https://bugs.webkit.org/show_bug.cgi?id=195904
1884
1885         Reviewed by Eric Carlson.
1886
1887         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1888         (TestWebKitAPI::TEST_F):
1889
1890 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1891
1892         Disable flaky test added in r2431100
1893         https://webkit.org/b/195785
1894
1895         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1896         (TestWebKitAPI::TEST):
1897         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1898
1899 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1900
1901         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1902         https://bugs.webkit.org/show_bug.cgi?id=195916
1903
1904         Reviewed by Tim Horton.
1905
1906         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1907         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1908
1909 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1910
1911         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1912
1913         * Scripts/webkitpy/common/config/contributors.json:
1914
1915 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1916
1917         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1918         https://bugs.webkit.org/show_bug.cgi?id=195785
1919
1920         Reviewed by Geoffrey Garen.
1921
1922         * TestWebKitAPI/TCPServer.cpp: Added.
1923         (TestWebKitAPI::TCPServer::TCPServer):
1924         (TestWebKitAPI::TCPServer::~TCPServer):
1925         (TestWebKitAPI::TCPServer::socketBindListen):
1926         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1927         * TestWebKitAPI/TCPServer.h: Added.
1928         (TestWebKitAPI::TCPServer::port const):
1929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1930         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1931         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1932         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1933         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1934         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1935         (TestWebKitAPI::respondSlowly):
1936         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1937         (TestWebKitAPI::downloadAtRate):
1938         (TestWebKitAPI::TEST):
1939
1940 2019-03-18  Saam Barati  <sbarati@apple.com>
1941
1942         Add a plan file for JetStream 2
1943         https://bugs.webkit.org/show_bug.cgi?id=190734
1944
1945         Reviewed by Mark Lam.
1946
1947         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1948
1949 2019-03-18  Chris Dumez  <cdumez@apple.com>
1950
1951         Delay WebProcess launch until a load is triggered in a Web view
1952         https://bugs.webkit.org/show_bug.cgi?id=195758
1953         <rdar://problem/48126013>
1954
1955         Reviewed by Geoff Garen.
1956
1957         Add API test coverage. Also update some existing API tests to not expect
1958         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1959
1960         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1961         (TestWebKitAPI::TEST):
1962         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1963         (TestWebKitAPI::TEST):
1964         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1965         (TEST):
1966         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1967         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1968         (TEST):
1969         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1970         (TEST):
1971         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1972
1973 2019-03-18  Xan Lopez  <xan@igalia.com>
1974
1975         [CMake] Prevent potential warning when determining $architecture
1976         https://bugs.webkit.org/show_bug.cgi?id=195891
1977
1978         Reviewed by Michael Catanzaro.
1979
1980         It's possible for generateBuildSystemForCMakeProject to be called
1981         before determineArchitecture() is ever called. This will make the
1982         first eq check with $architecture to be bogus (and print a
1983         warning). Change that to an eq check with architecture(), which
1984         implicitly calls determineArchitecture() if needed, and change all
1985         the other similar cases in the method in the same way to prevent
1986         future bugs like this one.
1987
1988         * Scripts/webkitdirs.pm:
1989         (generateBuildSystemFromCMakeProject):
1990
1991 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1992
1993         [WPE] Tarballs generated with “make dist” cannot build documentation
1994         https://bugs.webkit.org/show_bug.cgi?id=195885
1995
1996         Reviewed by Carlos Garcia Campos.
1997
1998         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1999
2000 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2001
2002         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2003         https://bugs.webkit.org/show_bug.cgi?id=195883
2004
2005         Reviewed by Carlos Garcia Campos.
2006
2007         * gtkdoc/gtkdoc.py:
2008         (GTKDoc._run_command): When commands fail to run, include the full command line for
2009         the program invocation and the output it has generated on the standard error stream.
2010
2011 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2012
2013         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2014         https://bugs.webkit.org/show_bug.cgi?id=195786
2015
2016         Reviewed by Philippe Normand.
2017
2018         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2019         * wpe/jhbuild.modules: Ditto.
2020
2021 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2022
2023         [ews-build] Don't run clean builds on EWS builders
2024         https://bugs.webkit.org/show_bug.cgi?id=195851
2025
2026         Reviewed by Geoffrey Garen.
2027
2028         * BuildSlaveSupport/ews-build/factories.py:
2029
2030 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2031
2032         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2033         https://bugs.webkit.org/show_bug.cgi?id=195849
2034
2035         Reviewed by Chris Dumez.
2036
2037         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2038
2039         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2040         (runWebsiteDataStoreCustomPaths):
2041
2042 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2043
2044         webkitpy: Upload test results
2045         https://bugs.webkit.org/show_bug.cgi?id=195755
2046         <rdar://problem/48896182>
2047
2048         Reviewed by Aakash Jain.
2049
2050         Establish a new format for uploading results that is not tied to layout tests, apply
2051         that format to webkitpy tests.
2052
2053         * Scripts/webkitpy/common/checkout/scm/git.py:
2054         (Git.native_branch): Return what branch the current checkout is on.
2055         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2056         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2057         * Scripts/webkitpy/common/checkout/scm/svn.py:
2058         (SVN.native_branch): Ditto.
2059         * Scripts/webkitpy/common/system/platforminfo.py:
2060         (PlatformInfo.build_version): Return a build version for Mac.
2061         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2062         (MockPlatformInfo.__init__):
2063         (MockPlatformInfo.build_version):
2064         * Scripts/webkitpy/results: Added.
2065         * Scripts/webkitpy/results/__init__.py: Added.
2066         * Scripts/webkitpy/results/options.py: Added.
2067         (upload_options): OptParse list for upload options.
2068         * Scripts/webkitpy/results/upload.py: Added.
2069         (Upload): Class which enforces the upload format expected by the results server.
2070         (Upload.Expectations):
2071         (Upload.create_configuration):
2072         (Upload.create_commit):
2073         (Upload.create_details):
2074         (Upload.create_run_stats):
2075         (Upload.create_test_result):
2076         (Upload.__init__):
2077         (Upload.Encoder): Encode Upload object as json.
2078         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2079         * Scripts/webkitpy/results/upload_unittest.py: Added.
2080         * Scripts/webkitpy/test/main.py:
2081         (Tester._parse_args): Add upload arguments.
2082         (Tester._run_tests): Allow results to be uploaded.
2083         * Scripts/webkitpy/test/runner.py:
2084         (Runner.__init__): Record which tests were run, rather than just counting them.
2085         (Runner.handle):
2086         * Scripts/webkitpy/test/runner_unittest.py:
2087         (RunnerTest.test_run):
2088         * Scripts/webkitpy/thirdparty/__init__.py:
2089         (AutoinstallImportHook.find_module): Add requests auto-install.
2090         (AutoinstallImportHook._install_requests):
2091         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2092         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2093
2094 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2095
2096         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2097         https://bugs.webkit.org/show_bug.cgi?id=195810
2098
2099         Reviewed by Tim Horton.
2100
2101         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2102         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2103         ending certain layout tests.
2104
2105         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2106         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2107         (-[TestRunnerWKWebView dealloc]):
2108         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2109
2110         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2111         helper method when destroying the web view, and when resetting state between tests.
2112
2113         * WebKitTestRunner/ios/TestControllerIOS.mm:
2114         (WTR::TestController::platformResetStateToConsistentValues):
2115
2116         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2117
2118 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2119
2120         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2121         https://bugs.webkit.org/show_bug.cgi?id=190350
2122         <rdar://problem/45089503>
2123
2124         Reviewed by Geoffrey Garen.
2125
2126         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2127         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2128         (TEST):
2129         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2130         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2131         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2132         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2133         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2134         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2135         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2136         (runTest):
2137         (createDirectories):
2138         (TEST):
2139         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2140         (TEST):
2141         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2142         (TEST):
2143
2144 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2145
2146         Add support to WebPage for getting the contents as an attributed string.
2147         https://bugs.webkit.org/show_bug.cgi?id=195636
2148         rdar://problem/45055697
2149
2150         Reviewed by Tim Horton.
2151
2152         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2153         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2154
2155 2019-03-15  Chris Dumez  <cdumez@apple.com>
2156
2157         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2158         https://bugs.webkit.org/show_bug.cgi?id=195747
2159
2160         Reviewed by Geoff Garen.
2161
2162         Add API test coverage.
2163
2164         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2165
2166 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2167
2168         Unreviewed, rolling out r242952.
2169
2170         Causing API failures on iOS Simulator
2171
2172         Reverted changeset:
2173
2174         "[PSON] Make sure the WebProcessCache is leverage when
2175         relaunching a process after termination"
2176         https://bugs.webkit.org/show_bug.cgi?id=195747
2177         https://trac.webkit.org/changeset/242952
2178
2179 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2180
2181         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2182         https://bugs.webkit.org/show_bug.cgi?id=195740
2183
2184         Reviewed by Ross Kirsling.
2185
2186         window.open doesn't work for WebKitBrowserWindow because it is not
2187         implemented yet.
2188
2189         1. Implemented createNewPage callback of WKPageUIClient.
2190         2. Changed MainWindow to take a BrowserWindow factory function
2191           instead of BrowserWindowType to be flexible to create
2192           BrowserWindow with extra settings.
2193         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2194           because it is not relevant with MainWindow anymore.
2195
2196         * MiniBrowser/win/Common.cpp:
2197         (parseCommandLine):
2198         * MiniBrowser/win/Common.h:
2199         (CommandLineOptions::CommandLineOptions):
2200         * MiniBrowser/win/MainWindow.cpp:
2201         (MainWindow::MainWindow):
2202         (MainWindow::create):
2203         (MainWindow::init):
2204         (MainWindow::WndProc):
2205         * MiniBrowser/win/MainWindow.h:
2206         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2207         (PrintWebUIDelegate::createWebViewWithRequest):
2208         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2209         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2210         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2211         (WebKitBrowserWindow::updateProxySettings):
2212         (WebKitBrowserWindow::createNewPage):
2213         * MiniBrowser/win/WebKitBrowserWindow.h:
2214         * MiniBrowser/win/WinMain.cpp:
2215         (wWinMain):
2216
2217 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2218
2219         Make it possible to test scrolling tree layer manipulation more easily
2220         https://bugs.webkit.org/show_bug.cgi?id=195780
2221
2222         Reviewed by Tim Horton.
2223         
2224         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2225         cuts off communication of scrolling tree scrolls back to the web process
2226         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2227         allows tests to trigger scrolls which run the scrolling tree layer positioning
2228         logic, but never get another commit from the web process that might mask
2229         scrolling tree bugs.
2230         
2231         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2232         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2233         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2234
2235         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2236         (WTR::UIScriptController::scrollUpdatesDisabled const):
2237         (WTR::UIScriptController::setScrollUpdatesDisabled):
2238         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2239         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2240         (WTR::UIScriptController::scrollUpdatesDisabled const):
2241         (WTR::UIScriptController::setScrollUpdatesDisabled):
2242         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2243         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2244         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2245         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2246         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2247         * WebKitTestRunner/ios/TestControllerIOS.mm:
2248         (WTR::TestController::platformResetStateToConsistentValues):
2249         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2250         (WTR::UIScriptController::scrollUpdatesDisabled const):
2251         (WTR::UIScriptController::setScrollUpdatesDisabled):
2252
2253 2019-03-14  Youenn Fablet  <youenn@apple.com>
2254
2255         Move IDB storage in private browsing mode to NetworkProcess
2256         https://bugs.webkit.org/show_bug.cgi?id=195602
2257
2258         Reviewed by Brady Eidson.
2259
2260         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2261         (TEST):
2262
2263 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2264
2265         [ews-build] Make descriptionDone messages more readable
2266         https://bugs.webkit.org/show_bug.cgi?id=195760
2267
2268         Reviewed by Lucas Forschler.
2269
2270         * BuildSlaveSupport/ews-build/steps.py:
2271         * BuildSlaveSupport/ews-build/steps_unittest.py:
2272
2273 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2274
2275         [ews-build] Generate status-bubble hover-over messages
2276         https://bugs.webkit.org/show_bug.cgi?id=195680
2277
2278         Reviewed by Lucas Forschler.
2279
2280         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2281         (StatusBubble):
2282         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2283         on hover-over.
2284         (StatusBubble._iso_time):
2285         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2286         hover-over message.
2287         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2288
2289 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2290
2291         [ews-app] Gracefully handle the case when state_string is None
2292         https://bugs.webkit.org/show_bug.cgi?id=195753
2293
2294         Reviewed by Lucas Forschler.
2295
2296         * BuildSlaveSupport/ews-app/ews/models/build.py:
2297         * BuildSlaveSupport/ews-app/ews/models/step.py:
2298
2299 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2300
2301         [ews-app] Status bubble display pending for currently running build step
2302         https://bugs.webkit.org/show_bug.cgi?id=195744
2303
2304         Reviewed by Lucas Forschler.
2305
2306         * BuildSlaveSupport/ews-build/events.py:
2307         (Events.stepStarted): If state_string is pending, replace it with step name.
2308
2309 2019-03-14  Chris Dumez  <cdumez@apple.com>
2310
2311         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2312         https://bugs.webkit.org/show_bug.cgi?id=195750
2313
2314         Reviewed by Geoffrey Garen.
2315
2316         Add API test coverage.
2317
2318         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2319         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2320         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2321         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2322
2323 2019-03-14  Chris Dumez  <cdumez@apple.com>
2324
2325         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2326         https://bugs.webkit.org/show_bug.cgi?id=195747
2327
2328         Reviewed by Geoff Garen.
2329
2330         Add API test coverage.
2331
2332         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2333
2334 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2335
2336         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2337         https://bugs.webkit.org/show_bug.cgi?id=195725
2338         <rdar://problem/48545062>
2339
2340         Reviewed by Tim Horton.
2341
2342         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2343         handler is nil.
2344
2345         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2346         (TestWebKitAPI::TEST):
2347
2348 2019-03-13  Sam Weinig  <sam@webkit.org>
2349
2350         Add utility function to allow easy reverse range-based iteration of a container
2351         https://bugs.webkit.org/show_bug.cgi?id=195542
2352
2353         Reviewed by Antti Koivisto.
2354
2355         * TestWebKitAPI/CMakeLists.txt:
2356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2357         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2358         (TestWebKitAPI::TEST):
2359         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2360
2361 2019-03-13  Chris Dumez  <cdumez@apple.com>
2362
2363         Use a ServiceWorker process per registrable domain
2364         https://bugs.webkit.org/show_bug.cgi?id=195649
2365
2366         Reviewed by Youenn Fablet.
2367
2368         Update API test coverage.
2369
2370         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2371
2372 2019-03-13  Chris Dumez  <cdumez@apple.com>
2373
2374         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2375         https://bugs.webkit.org/show_bug.cgi?id=195684
2376         <rdar://problem/48294714>
2377
2378         Reviewed by Antti Koivisto.
2379
2380         Add API test coverage.
2381
2382         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2383
2384 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2385
2386         [ews-app] Remove unused patch view
2387         https://bugs.webkit.org/show_bug.cgi?id=195669
2388
2389         Reviewed by Lucas Forschler.
2390
2391         * BuildSlaveSupport/ews-app/ews/urls.py:
2392         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2393
2394 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2395
2396         [ews-app] Use Buildbot result code variables
2397         https://bugs.webkit.org/show_bug.cgi?id=195668
2398
2399         Reviewed by Alexey Proskuryakov.
2400
2401         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2402         (Buildbot): Added Buildbot result code variables.
2403         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2404         (StatusBubble._build_bubble): Used Buildbot result code variables.
2405
2406 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2407
2408         [Flatpak] Expand submodule recursively
2409         https://bugs.webkit.org/show_bug.cgi?id=195672
2410
2411         Building WPE with flatpak was impossible without that as it was raising an exception.
2412         Also update wpebackend-fdo to match what is built in jhbuild
2413
2414         Reviewed by Philippe Normand.
2415
2416         * flatpak/flatpakutils.py:
2417         (expand_submodules_recurse):
2418         (expand_manifest):
2419         * flatpak/org.webkit.WPEModules.yaml:
2420
2421 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2422
2423         [ews-app] status bubble should be hidden for certain builds
2424         https://bugs.webkit.org/show_bug.cgi?id=194597
2425
2426         Reviewed by Dewei Zhu.
2427
2428         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2429         (StatusBubble._build_bubble):
2430         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2431         because the patch didn't have relevant changes.
2432         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2433         in production yet.
2434
2435 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2436
2437         [Win] Fix a slew of simple clang-cl warnings.
2438         https://bugs.webkit.org/show_bug.cgi?id=195652
2439
2440         Reviewed by Don Olmstead.
2441
2442         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2443         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2444
2445 2019-03-12  Justin Fan  <justin_fan@apple.com>
2446
2447         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2448         https://bugs.webkit.org/show_bug.cgi?id=195518
2449         <rdar://problem/46322356>
2450
2451         Reviewed by Myles C. Maxfield.
2452
2453         * DumpRenderTree/DerivedSources-input.xcfilelist:
2454         * DumpRenderTree/DerivedSources-output.xcfilelist:
2455
2456 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2457
2458         Unreviewed, rolling out r242825.
2459         https://bugs.webkit.org/show_bug.cgi?id=195648
2460
2461         "Broke webkitpy tests with my change to
2462         lldb_dump_class_layout.py" (Requested by rmorisset on
2463         #webkit).
2464
2465         Reverted changeset:
2466
2467         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2468         classes with suspicious padding"
2469         https://bugs.webkit.org/show_bug.cgi?id=195573
2470         https://trac.webkit.org/changeset/242825
2471
2472 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2473
2474         [ews-build] Show status bubbles while the patch is waiting in queue
2475         https://bugs.webkit.org/show_bug.cgi?id=195618
2476
2477         Reviewed by Lucas Forschler.
2478
2479         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2480         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2481         enabled in initial deployment.
2482         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2483         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2484         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2485         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2486         (StatusBubble._build_bubbles_for_patch):
2487
2488 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2489
2490         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2491         https://bugs.webkit.org/show_bug.cgi?id=195573
2492
2493         Reviewed by Simon Fraser.
2494
2495         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2496
2497         * Scripts/dump-class-layout:
2498         (main):
2499         * lldb/lldb_dump_class_layout.py:
2500         (ClassLayout.__init__):
2501         (ClassLayout._compute_padding_recursive):
2502         (LLDBDebuggerInstance.dump_layout_for_classname):
2503         (LLDBDebuggerInstance):
2504         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2505         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2506
2507 2019-03-12  Chris Dumez  <cdumez@apple.com>
2508
2509         Device Orientation access permission should be denied unless explicitly granted by the client
2510         https://bugs.webkit.org/show_bug.cgi?id=195625
2511
2512         Reviewed by Youenn Fablet.
2513
2514         add API test coverage.
2515
2516         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2517         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2518         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2519         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2520         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2521         (runDeviceOrientationTest):
2522         (TEST):
2523         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2524         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2525
2526 2019-03-12  Jer Noble  <jer.noble@apple.com>
2527
2528         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2529         https://bugs.webkit.org/show_bug.cgi?id=195137
2530         <rdar://problem/48810307>
2531
2532         Reviewed by Eric Carlson.
2533
2534         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2535         (TestWebKitAPI::TEST):
2536
2537 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2538
2539         [ews-build] Change urls from uat to production
2540         https://bugs.webkit.org/show_bug.cgi?id=195566
2541
2542         Reviewed by Lucas Forschler.
2543
2544         * BuildSlaveSupport/ews-app/ews/config.py:
2545         * BuildSlaveSupport/ews-build/events.py:
2546         * BuildSlaveSupport/ews-build/steps.py:
2547
2548 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2549
2550         [ews-build] change max_builds for local-worker to 1
2551         https://bugs.webkit.org/show_bug.cgi?id=195568
2552
2553         Reviewed by Lucas Forschler.
2554
2555         * BuildSlaveSupport/ews-build/loadConfig.py:
2556
2557 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2558
2559         Fix the build
2560
2561         * TestRunnerShared/spi/PencilKitTestSPI.h:
2562         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2563
2564 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2565
2566         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2567         https://bugs.webkit.org/show_bug.cgi?id=194131
2568
2569         Reviewed by Michael Catanzaro.
2570
2571         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2572         (uriChanged):
2573         (testUnfinishedSubresourceLoad):
2574         (serverCallback):
2575         (beforeAll):
2576
2577 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2578
2579         WTF::Expected should use std::addressof instead of operator&
2580         https://bugs.webkit.org/show_bug.cgi?id=195604
2581
2582         Reviewed by Myles Maxfield.
2583
2584         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2585         (TestWebKitAPI::Unique::Unique):
2586         (TestWebKitAPI::Unique::operator&):
2587         (TestWebKitAPI::TEST):
2588
2589 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2590
2591         Add Optional to Forward.h.
2592         https://bugs.webkit.org/show_bug.cgi?id=195586
2593
2594         Reviewed by Darin Adler.
2595
2596         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2597         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2598         Remove unnecessary includes from headers.
2599
2600 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2601
2602         Add testing API to hit-test and scroll overflow scrollers
2603         https://bugs.webkit.org/show_bug.cgi?id=195278
2604
2605         Reviewed by Antti Koivisto.
2606         
2607         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2608         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2609         
2610         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2611
2612         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2613         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2614         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2615         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2616         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2617         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2618         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2619         (WTR::enclosingScrollViewIncludingSelf):
2620         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2621
2622 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2623
2624         API test WebKit.RequestTextInputContext fails on iOS
2625         https://bugs.webkit.org/show_bug.cgi?id=195585
2626
2627         Reviewed by Wenson Hsieh and Simon Fraser.
2628
2629         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2630         (applyStyle):
2631         (TEST):
2632         Add a viewport, so that the coordinates match up on iOS.
2633         Scroll by moving the UIScrollView's contentOffset.
2634
2635 2019-03-11  Chris Dumez  <cdumez@apple.com>
2636
2637         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2638         https://bugs.webkit.org/show_bug.cgi?id=195506
2639         <rdar://problem/48733477>
2640
2641         Reviewed by Alex Christensen.
2642
2643         Add API test coverage.
2644
2645         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2646
2647 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2648
2649         Adding myself to contributors.json
2650
2651         Unreviewed, addming myself to contributors.json .
2652
2653         * Scripts/webkitpy/common/config/contributors.json:
2654
2655 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2656
2657         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2658         https://bugs.webkit.org/show_bug.cgi?id=195511
2659         <rdar://problem/44873269>
2660
2661         Reviewed by Darin Adler.
2662
2663         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2664         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2665         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2666         (TEST_F):
2667
2668 2019-03-11  Chris Dumez  <cdumez@apple.com>
2669
2670         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2671         https://bugs.webkit.org/show_bug.cgi?id=195561
2672
2673         Reviewed by Youenn Fablet.
2674
2675         Make sure the JS in the test requests for permission to receive device orientation events.
2676
2677         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2678
2679 2019-03-11  Youenn Fablet  <youenn@apple.com>
2680
2681         Allow storage quota increase by default in WTR
2682         https://bugs.webkit.org/show_bug.cgi?id=195541
2683
2684         Reviewed by Geoffrey Garen.
2685
2686         Allow storage quota increase by default in WTR.
2687         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2688         Use this for tests that explicitly need cache increase.
2689
2690         Instead of increasing quota by 2, make sure the next request is
2691         granted by adding all given parameters.
2692
2693         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2694         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2695         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2696         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2697         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2698         * WebKitTestRunner/TestController.cpp:
2699         (WTR::TestController::setAllowStorageQuotaIncrease):
2700         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2701         * WebKitTestRunner/TestController.h:
2702         * WebKitTestRunner/TestInvocation.cpp:
2703         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2704         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2705         (WTR::TestController::cocoaResetStateToConsistentValues):
2706         (WTR::TestController::setAllowStorageQuotaIncrease):
2707         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2708         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2709         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2710
2711 2019-03-11  Xan Lopez  <xan@igalia.com>
2712
2713         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2714         https://bugs.webkit.org/show_bug.cgi?id=194147
2715
2716         Reviewed by Michael Saboff.
2717
2718         To make --32-bit work correctly on Linux/64bit we need to:
2719
2720         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2721         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2722         unfortunately CMake only allows us to do this during
2723         crosscompilation, which is overkill here.
2724         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2725         pkg-config detection module uses the x86 .pc files instead of the
2726         x86_64 ones.
2727         - Set the -m32 flags for the compiler.
2728
2729         * Scripts/webkitdirs.pm:
2730         (generateBuildSystemFromCMakeProject):
2731
2732 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2733
2734         Add MotionMark-1.1 plan file for run-benchmark script.
2735         https://bugs.webkit.org/show_bug.cgi?id=195481
2736
2737         Rubber-stamped by Darin Adler.
2738
2739         Run-benchmark script should support MontionMark-1.1.
2740
2741         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2742
2743 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2744
2745         [ews-app] Add support for submit-to-ews url
2746         https://bugs.webkit.org/show_bug.cgi?id=195477
2747
2748         Reviewed by Lucas Forschler.
2749
2750         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2751         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2752         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2753         * BuildSlaveSupport/ews-app/ews/urls.py:
2754         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2755
2756 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2757
2758         Unreviewed, rolling out r242688, r242643, r242624.
2759
2760         Caused multiple layout test failures and crashes on iOS and macOS.
2761
2762         Reverted changeset:
2763
2764         "requestAnimationFrame should execute before the next frame"
2765         https://bugs.webkit.org/show_bug.cgi?id=177484
2766         https://trac.webkit.org/changeset/242624/webkit
2767
2768         * Tracing/SystemTracePoints.plist:
2769
2770 2019-03-11  John Wilander  <wilander@apple.com>
2771
2772         Resource Load Statistics: Make it possible exclude localhost from classification
2773         https://bugs.webkit.org/show_bug.cgi?id=195474
2774         <rdar://problem/47520577>
2775
2776         Reviewed by Brent Fulgham.
2777
2778         This patch allows for localhost to be excluded from classification and
2779         treatment as a prevalent resource.
2780
2781         The WebKit Tools change adds a new function called
2782         testRunner.setStatisticsIsRunningTest() which can be used to control this
2783         behavior.
2784
2785         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2786         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2787         (WTR::TestRunner::setStatisticsIsRunningTest):
2788         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2789         * WebKitTestRunner/TestController.cpp:
2790         (WTR::TestController::setStatisticsIsRunningTest):
2791         * WebKitTestRunner/TestController.h:
2792         * WebKitTestRunner/TestInvocation.cpp:
2793         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2794
2795 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2796
2797         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2798         https://bugs.webkit.org/show_bug.cgi?id=195560
2799
2800         Reviewed by Lucas Forschler.
2801
2802         * BuildSlaveSupport/ews-build/master.cfg:
2803
2804 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2805
2806         Unreviewed, rolling out r242698.
2807
2808         API test crashes on bots.
2809
2810         Reverted changeset:
2811
2812         "Add a WKContentRuleList variant that uses copied memory
2813         instead of mmap'd shared memory for class A containerized
2814         apps"
2815         https://bugs.webkit.org/show_bug.cgi?id=195511
2816         https://trac.webkit.org/changeset/242698
2817
2818 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2819
2820         [WPE] Enable web process sandbox
2821         https://bugs.webkit.org/show_bug.cgi?id=195169
2822
2823         Reviewed by Daniel Bates.
2824
2825         * wpe/install-dependencies:
2826         * wpe/jhbuild.modules:
2827
2828 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2829
2830         [ews-app] Use port 17000 for worker communication
2831         https://bugs.webkit.org/show_bug.cgi?id=195558
2832
2833         Reviewed by Lucas Forschler.
2834
2835         * BuildSlaveSupport/ews-build/master.cfg:
2836
2837 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2838
2839         [ews-build] unit-tests fail when passwords.json is missing
2840         https://bugs.webkit.org/show_bug.cgi?id=195557
2841
2842         Reviewed by Lucas Forschler.
2843
2844         * BuildSlaveSupport/ews-build/loadConfig.py:
2845         (loadBuilderConfig):
2846         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2847         (ConfigDotJSONTest.test_configuration):
2848         * BuildSlaveSupport/ews-build/master.cfg:
2849
2850 2019-03-11  Truitt Savell  <tsavell@apple.com>
2851
2852         Unreviewed, rolling out r242702.
2853
2854         Broke High Sierra builders.
2855
2856         Reverted changeset:
2857
2858         "Add utility function to allow easy reverse range-based
2859         iteration of a container"
2860         https://bugs.webkit.org/show_bug.cgi?id=195542
2861         https://trac.webkit.org/changeset/242702
2862
2863 2019-03-11  Sam Weinig  <sam@webkit.org>
2864
2865         Add utility function to allow easy reverse range-based iteration of a container
2866         https://bugs.webkit.org/show_bug.cgi?id=195542
2867
2868         Reviewed by Antti Koivisto.
2869
2870         * TestWebKitAPI/CMakeLists.txt:
2871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2872         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2873         (TestWebKitAPI::TEST):
2874         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2875
2876 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2877
2878         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2879         https://bugs.webkit.org/show_bug.cgi?id=195511
2880         <rdar://problem/44873269>
2881
2882         Reviewed by Darin Adler.
2883
2884         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2885         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2886         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2887         (TEST_F):
2888
2889 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2890
2891         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2892         https://bugs.webkit.org/show_bug.cgi?id=195499
2893
2894         Reviewed by Darin Adler.
2895
2896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2897         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2898         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2899         (-[WKWebView synchronouslyFocusTextInputContext:]):
2900         (applyStyle):
2901         (applyIframe):
2902         (TEST):
2903         Add some tests for this SPI.
2904
2905 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2906
2907         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2908         https://bugs.webkit.org/show_bug.cgi?id=181151
2909
2910         Reviewed by Don Olmstead.
2911
2912         * TestWebKitAPI/CMakeLists.txt:
2913         * TestWebKitAPI/PlatformWin.cmake:
2914         Enable TestWTF RunLoop tests in all platforms.
2915
2916         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2917         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2918         (TestWebKitAPI::DerivedOneShotTimer::fired):
2919         (TestWebKitAPI::TEST):
2920         Only a few platforms support nested RunLoop.
2921
2922         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2923         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2924
2925 2019-03-10  David Quesada  <david_quesada@apple.com>
2926
2927         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2928         https://bugs.webkit.org/show_bug.cgi?id=152480
2929
2930         Reviewed by Chris Dumez.
2931
2932         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2933         there are no additional references to the process pool besides the one held by
2934         the download, waits for the download to finish (in the sense that the
2935         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2936         measure, also check that the process pool has been deallocated at the end of the
2937         test. The test wouldn't be meaningful if the process pool were still alive.
2938
2939         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2940         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2941         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2942             The download will be canceled because the delegate does not implement the
2943             method to decide the download's destination, so this is where we know the
2944             DownloadProxyMap is done with the DownloadProxy.
2945         (TEST):
2946
2947 2019-03-08  Chris Dumez  <cdumez@apple.com>
2948
2949         Add support for Device Orientation / Motion permission API
2950         https://bugs.webkit.org/show_bug.cgi?id=195329
2951         <rdar://problem/47645367>
2952
2953         Reviewed by Geoffrey Garen.
2954
2955         Add test infrastructure to help test the Device Orientation / Motion permission API.
2956
2957         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2958         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2959         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2960         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2961         * WebKitTestRunner/TestController.cpp:
2962         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2963         (WTR::TestController::createWebViewWithOptions):
2964         (WTR::TestController::resetStateToConsistentValues):
2965         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2966         * WebKitTestRunner/TestController.h:
2967         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2968         * WebKitTestRunner/TestInvocation.cpp:
2969         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2970
2971 2019-03-08  Saam barati  <sbarati@apple.com>
2972
2973         Add a compare-results script to compare benchmark results
2974         https://bugs.webkit.org/show_bug.cgi?id=195486
2975         <rdar://problem/48723397>
2976
2977         Reviewed by Geoffrey Garen.
2978
2979         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2980         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2981         to extend it to learn about our other benchmarks.
2982
2983         * Scripts/compare-results: Added.
2984         (readJSONFile):
2985         (detectJetStream2):
2986         (JetStream2Results):
2987         (detectSpeedometer2):
2988         (Speedometer2Results):
2989         (detectPLT5):
2990         (PLT5Results):
2991         (detectBenchmark):
2992         (biggerIsBetter):
2993         (ttest):
2994         (getOptions):
2995         (main):
2996
2997 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2998
2999         Ensure old tab state is cleared between iterations of run-benchmark
3000         https://bugs.webkit.org/show_bug.cgi?id=195393
3001         <rdar://problem/46885583>
3002
3003         Reviewed by Dewei Zhu.
3004
3005         a) ensure the default to restore state is not set
3006         b) terminate Safari correctly
3007         c) Set the system default to ignore Persistent State in Safari
3008
3009         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3010         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3011         (OSXBrowserDriver.prepare_env): 
3012         (OSXBrowserDriver.restore_env):
3013         (OSXBrowserDriver.close_browsers):
3014         (OSXBrowserDriver._terminate_processes):
3015         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3016         (OSXChromeDriver):
3017         (OSXChromeCanaryDriver):
3018         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3019         (OSXFirefoxDriver):
3020         (OSXFirefoxNightlyDriver):
3021         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3022         (OSXSafariDriver):
3023         (OSXSafariDriver.prepare_env):
3024
3025 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3026
3027         [GTK] Several InputMethodFilter tests are failing
3028         https://bugs.webkit.org/show_bug.cgi?id=195408
3029
3030         Reviewed by Carlos Garcia Campos.
3031
3032         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3033         Regressed in r241751.
3034         Hexadecimal values of keycodes are expressed now in upper letters.
3035         Composited characters should be cast to UTF8 strings.
3036
3037         (TestWebKitAPI::TEST):
3038
3039 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3040
3041         [GTK] Make Tools/gtkdoc python3 compatible
3042         https://bugs.webkit.org/show_bug.cgi?id=195359
3043
3044         Reviewed by Carlos Garcia Campos.
3045
3046         * gtkdoc/generate-gtkdoc:
3047         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3048         work with Python 2 and 3.
3049         (get_gtkdoc_module_paths):
3050         The iteritems() was removed in Python 3, so let's use items() that's
3051         available in Python 2 and 3.
3052         (get_generator_for_config):
3053         * gtkdoc/gtkdoc.py:
3054         (GTKDoc._run_command):
3055         The sys.stdout.write() is expecting str in Python 3 and not bytes
3056         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3057         for passing the bytes there.
3058
3059 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3060
3061         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3062         https://bugs.webkit.org/show_bug.cgi?id=195346
3063         <rdar://problem/48667048>
3064
3065         Unreviewed build fix for clang-cl.
3066
3067         * DumpRenderTree/win/DumpRenderTree.cpp:
3068         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3069
3070 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3071
3072         requestAnimationFrame should execute before the next frame
3073         https://bugs.webkit.org/show_bug.cgi?id=177484
3074
3075         Reviewed by Simon Fraser.
3076
3077         Add trace points for the page RenderingUpdate.
3078
3079         * Tracing/SystemTracePoints.plist:
3080
3081 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3082
3083         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3084         https://bugs.webkit.org/show_bug.cgi?id=195353
3085         <rdar://problem/48626394>
3086
3087         Reviewed by Simon Fraser.
3088
3089         * WebKitTestRunner/ios/TestControllerIOS.mm:
3090         (WTR::TestController::platformResetPreferencesToConsistentValues):
3091
3092 2019-03-07  John Wilander  <wilander@apple.com>
3093
3094         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3095         https://bugs.webkit.org/show_bug.cgi?id=195383
3096         <rdar://problem/48570136>
3097
3098         Reviewed by Brent Fulgham.
3099
3100         This patch adds test infrastructure to purge only script-accessible cookies,
3101         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3102
3103         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3104         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3105         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3106         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3107         * WebKitTestRunner/TestController.cpp:
3108         (WTR::TestController::statisticsDeleteCookiesForHost):
3109         * WebKitTestRunner/TestController.h:
3110         * WebKitTestRunner/TestInvocation.cpp:
3111         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3112
3113 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3114
3115         Unreviewed, rolling out r242354.
3116         https://bugs.webkit.org/show_bug.cgi?id=195402
3117
3118         breaks layout tests in all configurations (Requested by
3119         zdobersek on #webkit).
3120
3121         Reverted changeset:
3122
3123         "[WPE] Enable web process sandbox"
3124         https://bugs.webkit.org/show_bug.cgi?id=195169
3125         https://trac.webkit.org/changeset/242354
3126
3127 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3128
3129         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3130         https://bugs.webkit.org/show_bug.cgi?id=195346
3131
3132         Reviewed by Fujii Hironori.
3133
3134         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3135         (TestWebKitAPI::TEST):
3136         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3137
3138         * DumpRenderTree/win/DumpRenderTree.cpp:
3139         (findFontFallback):
3140         (addFontFallbackIfPresent):
3141         (removeFontFallbackIfPresent):
3142         (main):
3143         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3144         (TestWebKitAPI::Util::moduleDirectory):
3145         (TestWebKitAPI::Util::createInjectedBundlePath):
3146         Use wchar helpers as needed.
3147
3148 2019-03-06  Rob Buis  <rbuis@igalia.com>
3149
3150         Consider supporting the `referrerpolicy` attribute.
3151         https://bugs.webkit.org/show_bug.cgi?id=179053
3152
3153         Reviewed by Darin Adler.
3154
3155         Add a runtime flag for referrerpolicy attribute.
3156
3157         * DumpRenderTree/mac/DumpRenderTree.mm:
3158         (enableExperimentalFeatures):
3159
3160 2019-03-05  Daniel Bates  <dabates@apple.com>
3161
3162         Update expected API test result following r242379
3163         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3164
3165         Update expected x-coordinate of selection rect now that the left padding of
3166         a textarea is sized in ems (so dependent on the font size) just like the left
3167         padding of a text field.
3168
3169         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3170         (TestWebKitAPI::TEST):
3171
3172 2019-03-05  David Quesada  <david_quesada@apple.com>
3173
3174         [WK2] It should be possible to follow links with 'download' attributes
3175         https://bugs.webkit.org/show_bug.cgi?id=195145
3176         rdar://problem/48462642
3177
3178         Reviewed by Alex Christensen.
3179
3180         Add a unit test to verify that activating links with 'download' attributes now
3181         navigates to the linked resource, rather than starts downloading it. Add another
3182         to verify that it is still possible to explicitly download the link via the
3183         'Download' navigation action policy.
3184
3185         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3186         (-[DownloadAttributeTestDelegate init]):
3187         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3188         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3189         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3190         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3191         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3192         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3193         (TEST):
3194         * WebKitTestRunner/TestController.cpp:
3195         (WTR::TestController::decidePolicyForNavigationAction):
3196         * WebKitTestRunner/TestController.h:
3197
3198 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3199
3200         [Curl] Implement Cookie Accept Policy.
3201         https://bugs.webkit.org/show_bug.cgi?id=191645
3202
3203         Reviewed by Fujii Hironori.
3204
3205         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3206         (TestWebKitAPI::Curl::TEST_F):
3207
3208 2019-03-05  Youenn Fablet  <youenn@apple.com>
3209
3210         Rename requestCacheStorageSpace to requestStorageSpace
3211         https://bugs.webkit.org/show_bug.cgi?id=195282
3212
3213         Reviewed by Chris Dumez.
3214
3215         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3216         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3217         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3218
3219 2019-03-05  Brady Eidson  <beidson@apple.com>
3220
3221         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3222         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3223
3224         Reviewed by Tim Horton.
3225
3226         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3227         different directory into that same WKWebView should work.
3228
3229         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3230         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3231
3232 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3233
3234         Add WeakHashSet
3235         https://bugs.webkit.org/show_bug.cgi?id=195152
3236
3237         Reviewed by Antti Koivisto.
3238
3239         Added tests for WeakHashSet.
3240
3241         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3242         (TestWebKitAPI::Base::Base): Moved.
3243         (TestWebKitAPI::Derived::foo): Moved.
3244         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3245         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3246         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3247         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3248
3249 2019-03-04  Chris Dumez  <cdumez@apple.com>
3250
3251         Do not share WebProcesses between private and regular sessions
3252         https://bugs.webkit.org/show_bug.cgi?id=195189
3253         <rdar://problem/48421064>
3254
3255         Reviewed by Alex Christensen.
3256
3257         Add API test coverage.
3258
3259         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3260         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3261
3262 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3263
3264         [WPE] Enable web process sandbox
3265         https://bugs.webkit.org/show_bug.cgi?id=195169
3266
3267         Reviewed by Daniel Bates.
3268
3269         * wpe/install-dependencies:
3270         * wpe/jhbuild.modules:
3271
3272 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3273
3274         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3275         https://bugs.webkit.org/show_bug.cgi?id=195206
3276
3277         Reviewed by Žan Doberšek.
3278
3279         Add a new test case.
3280
3281         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3282         (testJSCClass):
3283
3284 2019-03-04  Charlie Turner  <cturner@igalia.com>
3285
3286         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3287         https://bugs.webkit.org/show_bug.cgi?id=194898
3288
3289         Reviewed by Žan Doberšek.
3290
3291         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3292         a GCC extension that permits arithmetic on void* pointer. Inline
3293         the macro until this issue is fixed upstream.
3294
3295 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3296
3297         Rid the world of WK_API_ENABLED
3298         https://bugs.webkit.org/show_bug.cgi?id=195263
3299
3300         Reviewed by Dan Bernstein.
3301
3302         List of changed files elided because it's useless.
3303
3304 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3305
3306         Unreviewed follow-up to r242292.
3307
3308         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3309
3310         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3311         (TestWebKitAPI::testStrip): Renamed from strip.
3312         (TestWebKitAPI::TEST):
3313
3314 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3315
3316         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3317
3318         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3319         and bug #194272 for details.
3320
3321         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3322
3323 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3324
3325         Remove some more unused 32-bit code
3326         https://bugs.webkit.org/show_bug.cgi?id=195255
3327
3328         Reviewed by Darin Adler.
3329
3330         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3331         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3332         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3333         (NPP_New):
3334         (NPP_HandleEvent):
3335         (handleEventCarbon): Deleted.
3336
3337 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3338
3339         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3340
3341         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3342         (TestWebKitAPI::TEST):
3343
3344 2019-03-01  Darin Adler  <darin@apple.com>
3345
3346         Finish removing String::format
3347         https://bugs.webkit.org/show_bug.cgi?id=194893
3348
3349         Reviewed by Daniel Bates.
3350 '
3351         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3352
3353 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3354
3355         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3356         https://bugs.webkit.org/show_bug.cgi?id=195229
3357         <rdar://problem/48520362>
3358
3359         Reviewed by Chris Dumez.
3360
3361         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3362         (TEST):
3363
3364 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3365
3366         Add a system trace scope for event region building
3367         https://bugs.webkit.org/show_bug.cgi?id=195226
3368
3369         Reviewed by Jon Lee.
3370
3371         This trace scope measures the time spend converting element rects into Region objects,
3372         which can be large on some pages.
3373
3374         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3375
3376         * Tracing/SystemTracePoints.plist:
3377
3378 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3379
3380         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3381         https://bugs.webkit.org/show_bug.cgi?id=194612
3382
3383         Reviewed by Alex Christensen.
3384
3385         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3386         Just test the new string-processing function and don't touch the actual environment.
3387         (Test cases are all as before, but based on operator== instead of strcmp.)
3388
3389 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3390
3391         [ews-app] Update primary keys for handling multiple Buildbot instances
3392         https://bugs.webkit.org/show_bug.cgi?id=195120
3393
3394         Reviewed by Stephanie Lewis.
3395
3396         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3397         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3398         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3399
3400         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3401         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3402         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3403         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3404         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3405         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3406
3407 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3408
3409         [WinCairo] Enable service worker
3410         https://bugs.webkit.org/show_bug.cgi?id=188318
3411
3412         Reviewed by Youenn Fablet.
3413
3414         * DumpRenderTree/DumpRenderTreePrefix.h:
3415         * TestWebKitAPI/PlatformWin.cmake:
3416         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3417         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3418         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3419
3420 2019-03-01  Justin Fan  <justin_fan@apple.com>
3421
3422         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3423         https://bugs.webkit.org/show_bug.cgi?id=195191
3424
3425         Rubber-stamped by Dean Jackson.
3426
3427         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3428
3429         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3430
3431 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3432
3433         Unreviewed, fix lldb webkitpy tests
3434         https://bugs.webkit.org/show_bug.cgi?id=194375
3435
3436         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3437
3438         * lldb/lldb_webkit.py:
3439         (WTFStringImplProvider.is_8bit):
3440
3441 2019-02-28  David Quesada  <david_quesada@apple.com>
3442
3443         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3444         https://bugs.webkit.org/show_bug.cgi?id=195121
3445         rdar://problem/48450302
3446
3447         Reviewed by Alex Christensen.
3448
3449         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3450         configurations where the 'download' attribute is absent, blank, or populated
3451         with a filename, and where the anchor element is same-origin or cross-origin
3452         (meaning the 'download' attribute shouldn't be honored).
3453
3454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3455         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3456         (-[NavigationActionTestDelegate init]):
3457         (-[NavigationActionTestDelegate navigationAction]):
3458         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3459         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3460         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3461         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3462         (TEST):
3463
3464 2019-02-28  Antoine Quint  <graouts@apple.com>
3465
3466         Enable the Pointer Events runtime flag by default
3467         https://bugs.webkit.org/show_bug.cgi?id=195156
3468
3469         Reviewed by Dean Jackson.
3470
3471         * DumpRenderTree/mac/DumpRenderTree.mm:
3472         (enableExperimentalFeatures):
3473
3474 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3475
3476         Several PasteImage API tests are flaky
3477         https://bugs.webkit.org/show_bug.cgi?id=195160
3478
3479         Reviewed by Tim Horton.
3480
3481         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3482         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3483         listening for a "load" event after image load is already complete.
3484
3485         To address this, make these tests first register a "load" event handler, then run script to insert an image
3486         element into the document, and finally wait until the load event is observed before checking image size.
3487
3488         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3489
3490 2019-02-28  Chris Dumez  <cdumez@apple.com>
3491
3492         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3493         https://bugs.webkit.org/show_bug.cgi?id=195107
3494
3495         Reviewed by Alex Christensen.
3496
3497         Give some time for the zoom level to get restored.
3498
3499         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3500
3501 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3502
3503         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3504         https://bugs.webkit.org/show_bug.cgi?id=194958
3505
3506         Reviewed by Geoffrey Garen.
3507
3508         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3509         (TEST):
3510
3511 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3512
3513         [ews-app] Update method to save build to handle builder_display_name
3514         https://bugs.webkit.org/show_bug.cgi?id=195047
3515
3516         Reviewed by Dewei Zhu.
3517
3518         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3519         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3520
3521 2019-02-28  Justin Fan  <justin_fan@apple.com>
3522
3523         [Web GPU] Enable Web GPU only on 64-bit
3524         https://bugs.webkit.org/show_bug.cgi?id=195139
3525
3526         Because Metal is only supported on 64 bit apps.
3527
3528         Unreviewed build fix.
3529
3530         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3531
3532 2019-02-27  Youenn Fablet  <youenn@apple.com>
3533
3534         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3535         https://bugs.webkit.org/show_bug.cgi?id=194959
3536
3537         Reviewed by Chris Dumez.
3538
3539         Spin loop until getting the condition to remove flakiness.
3540
3541         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3542
3543 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3544
3545         [ews-build] Buildbot should include builder_display_name in the build events
3546         https://bugs.webkit.org/show_bug.cgi?id=195045
3547
3548         Reviewed by Dewei Zhu.
3549
3550         * BuildSlaveSupport/ews-build/events.py:
3551         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3552         buildername to builder_name to be consistent in naming style.
3553         (Events.buildFinished): Ditto.
3554
3555 2019-02-27  Chris Dumez  <cdumez@apple.com>
3556
3557         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3558         https://bugs.webkit.org/show_bug.cgi?id=194480
3559
3560         Reviewed by Brady Eidson.
3561
3562         Update existing API test to make it more likely to reproduce the issue.
3563
3564         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3565
3566 2019-02-27  Brady Eidson  <beidson@apple.com>
3567
3568         Universal links from Google search results pages don't open the app.
3569         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3570
3571         Reviewed by Geoffrey Garen.
3572
3573         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3574         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3575         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3576         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3577
3578 2019-02-27  Chris Dumez  <cdumez@apple.com>
3579
3580         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3581         https://bugs.webkit.org/show_bug.cgi?id=195102
3582
3583         Reviewed by Geoffrey Garen.
3584
3585         If the number of processes is not yet what we expect, wait a bit and check again to give
3586         processes some time to exit.
3587
3588         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3589
3590 2019-02-27  Chris Dumez  <cdumez@apple.com>
3591
3592         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3593         https://bugs.webkit.org/show_bug.cgi?id=194545
3594
3595         Reviewed by Brady Eidson.
3596
3597         Make sure the test navigates forward and then back only once. Previously, navigating
3598         back would trigger a navigation again in a timer.
3599
3600         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3601
3602 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3603
3604         High Sierra Debug JSC test queue should use faster hardware
3605         https://bugs.webkit.org/show_bug.cgi?id=194603
3606
3607         Rubber-stamped by Alexey Proskuryakov.
3608
3609         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3610
3611         * BuildSlaveSupport/build.webkit.org-config/config.json:
3612         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3613         (BubbleQueueServer):
3614         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3615         (WebKitBuildbot):
3616         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3617         * QueueStatusServer/config/queues.py:
3618         * Scripts/webkitpy/common/config/ews.json:
3619         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3620         (test_ews_name):
3621
3622 2019-02-27  John Wilander  <wilander@apple.com>
3623
3624         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3625         https://bugs.webkit.org/show_bug.cgi?id=195071
3626         <rdar://problem/48417690>
3627
3628         Reviewed by Alex Christensen and Brent Fulgham.
3629
3630         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3631         (TestWebKitAPI::createURL):
3632             Convenience function.
3633         (TestWebKitAPI::TEST):
3634             WebCore::AdClickAttribution now takes a URL when creating Source and
3635             Destination.
3636         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3637         (TestWebKitAPI::TEST):
3638             WebCore::AdClickAttribution now takes a URL when creating Source and
3639             Destination.
3640
3641 2019-02-27  Antoine Quint  <graouts@apple.com>
3642
3643         Support Pointer Events on macOS
3644         https://bugs.webkit.org/show_bug.cgi?id=195008
3645         <rdar://problem/47454419>
3646
3647         Reviewed by Dean Jackson.
3648
3649         * DumpRenderTree/mac/DumpRenderTree.mm:
3650         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3651         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3652
3653 2019-02-26  Mark Lam  <mark.lam@apple.com>
3654
3655         Remove remaining poisoning code.
3656         https://bugs.webkit.org/show_bug.cgi?id=194138
3657
3658         Reviewed by Saam Barati.
3659
3660         * TestWebKitAPI/CMakeLists.txt:
3661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3662         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3663         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3664         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3665         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3666         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3667         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3668
3669 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3670
3671         Move ephemeral local storage from WebProcess to UIProcess
3672         https://bugs.webkit.org/show_bug.cgi?id=195074
3673         <rdar://problem/47937975>
3674
3675         Reviewed by Geoff Garen.
3676
3677         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3678
3679 2019-02-20  Jer Noble  <jer.noble@apple.com>
3680
3681         [Cocoa] Media elements will restart network buffering just before suspending
3682         https://bugs.webkit.org/show_bug.cgi?id=193691
3683
3684         Reviewed by Eric Carlson.
3685
3686         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3687         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3688         (TEST):
3689
3690 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3691
3692         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3693         https://bugs.webkit.org/show_bug.cgi?id=191652
3694
3695         Reviewed by Alex Christensen.
3696
3697         Fix WinCairo MiniBrowser behavior of authentication dialog.
3698
3699         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3700         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3701
3702 2019-02-26  Youenn Fablet  <youenn@apple.com>
3703
3704         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3705         https://bugs.webkit.org/show_bug.cgi?id=195028
3706         <rdar://problem/48243733>
3707
3708         Reviewed by Eric Carlson.
3709
3710         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3711
3712 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3713
3714         [WPE] Add API for webview background color configuration
3715         https://bugs.webkit.org/show_bug.cgi?id=192305
3716
3717         Reviewed by Michael Catanzaro.
3718
3719         * MiniBrowser/wpe/main.cpp:
3720         (main): Add a new option to configure the webview background
3721         color. Example: --bg-color=transparent.
3722         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3723         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3724         (beforeAll): Ditto.
3725
3726 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3727
3728         scalableNativeWebpageParameters() is not preserved on new page navigation.
3729         https://bugs.webkit.org/show_bug.cgi?id=194892
3730         <rdar://problem/47538280>
3731
3732         Reviewed by Wenson Hsieh.
3733         
3734         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3735
3736         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3737         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3738         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3739         (WTR::UIScriptController::allowsViewportShrinkToFit):
3740         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3741         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3742         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3743         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3744         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3745         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3746
3747 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3748
3749         [ews-app] Add model for handling multiple Buildbot instances
3750         https://bugs.webkit.org/show_bug.cgi?id=194863
3751
3752         Reviewed by Stephanie Lewis.
3753
3754         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3755
3756 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3757
3758         [ews-app] Remove BuilderMapping table
3759         https://bugs.webkit.org/show_bug.cgi?id=194961
3760
3761         Reviewed by Stephanie Lewis.
3762
3763         Store builder name directly in build table, instead of having a separate
3764         table for it.
3765
3766         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3767         * BuildSlaveSupport/ews-app/ews/models/build.py:
3768         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3769         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3770
3771 2019-02-25  John Wilander  <wilander@apple.com>
3772
3773         Introduce and adopt new class RegistrableDomain for eTLD+1
3774         https://bugs.webkit.org/show_bug.cgi?id=194791
3775         <rdar://problem/48179240>
3776
3777         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3778
3779         This patch adds an API test and replaces two instances of
3780         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3781
3782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3783         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3784         (TestWebKitAPI::TEST):
3785             Changed two strings to make sure the registrable domains are still considered
3786             invalid and pass the test.
3787         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3788         (TestWebKitAPI::TEST):
3789         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3790         (WTR::InjectedBundle::didReceiveMessageToPage):
3791
3792 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3793
3794         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3795         https://bugs.webkit.org/show_bug.cgi?id=195001
3796
3797         Reviewed by Carlos Garcia Campos.
3798
3799         API version 1.0 always includes the functionality previously guarded with
3800         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3801         unconditionally.
3802
3803         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3804         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3805         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3806         (WebViewTest::showInWindow): Ditto.
3807         (WebViewTest::hideView): Ditto.
3808         * wpe/backends/HeadlessViewBackend.cpp:
3809         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3810         * wpe/backends/ViewBackend.cpp:
3811         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3812         * wpe/backends/WindowViewBackend.cpp:
3813         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3814         WPE_BACKEND_CHECK_VERSION().
3815         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3816
3817 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3818
3819         [Flatpak] Add support for flatpak > 1.1.2
3820         https://bugs.webkit.org/show_bug.cgi?id=194088
3821
3822         Flatpak 1.2 is now out so we need to support that
3823         version now.
3824
3825         Reviewed by Michael Catanzaro.
3826
3827         * flatpak/flatpakutils.py:
3828         (check_flatpak):
3829         (FlatpakPackages.__init__):
3830         (FlatpakPackages.__detect_packages):
3831         (FlatpakPackages.__detect_packages.in):
3832         (FlatpakRepos.update):
3833
3834 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3835
3836         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3837         https://bugs.webkit.org/show_bug.cgi?id=194998
3838
3839         Reviewed by Carlos Garcia Campos.
3840
3841         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3842         to a Git checkout and using the latest commit containing various fixes
3843         and improvements.
3844
3845 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3846
3847         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3848         https://bugs.webkit.org/show_bug.cgi?id=194981
3849
3850         Reviewed by Žan Doberšek.
3851
3852         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3853         (TestWebKitAPI::TEST):
3854
3855 2019-02-23  Keith Miller  <keith_miller@apple.com>
3856
3857         Add new mac target numbers
3858         https://bugs.webkit.org/show_bug.cgi?id=194955
3859
3860         Reviewed by Tim Horton.
3861
3862         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3863         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3864         * MiniBrowser/Configurations/Base.xcconfig:
3865         * TestWebKitAPI/Configurations/Base.xcconfig:
3866         * WebKitTestRunner/Configurations/Base.xcconfig:
3867
3868 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3869
3870         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3871         https://bugs.webkit.org/show_bug.cgi?id=194846
3872
3873         Reviewed by Don Olmstead.
3874
3875         Added _search_paths() and _port_specific_expectations_files() for
3876         WinCairoPort.
3877
3878         * Scripts/webkitpy/port/win.py:
3879         (WinCairoPort.default_baseline_search_path):
3880         (WinCairoPort):
3881         (WinCairoPort._port_specific_expectations_files):
3882         (WinCairoPort._search_paths):
3883
3884 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3885
3886         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3887         https://bugs.webkit.org/show_bug.cgi?id=194963
3888
3889         Reviewed by Dean Jackson.
3890
3891         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3892         Do a `contains` check instead of `equals`, because in debug builds we
3893         put the GraphicsLayer pointer in a prefix.
3894
3895 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3896
3897         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3898         https://bugs.webkit.org/show_bug.cgi?id=194873
3899         <rdar://problem/46701974>
3900
3901         Reviewed by Tim Horton.
3902
3903         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3904
3905         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3906         (WTR::UIScriptController::menuRect const):
3907         (WTR::UIScriptController::isShowingMenu const):
3908         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3909         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3910         (WTR::UIScriptController::menuRect const):
3911
3912         Add a function to query the bounds of the callout menu in content coordinates.
3913
3914         (WTR::UIScriptController::isShowingMenu const):
3915
3916         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3917
3918         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3919         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3920         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3921         (WTR::UIScriptController::rectForMenuAction const):
3922         (WTR::UIScriptController::menuRect const):
3923         (WTR::UIScriptController::isShowingMenu const):
3924         (WTR::findViewInHierarchyOfType): Deleted.
3925
3926 2019-02-22  Chris Dumez  <cdumez@apple.com>
3927
3928         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3929         https://bugs.webkit.org/show_bug.cgi?id=194954
3930         <rdar://problem/48127957>
3931
3932         Reviewed by Alex Christensen.
3933
3934         Add API test coverage.
3935
3936         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3937         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3938         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3939         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3940
3941 2019-02-22  Chris Dumez  <cdumez@apple.com>
3942
3943         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3944         https://bugs.webkit.org/show_bug.cgi?id=194924
3945         <rdar://problem/48216125>
3946
3947         Reviewed by Geoffrey Garen.
3948
3949         Add API test coverage.
3950
3951         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3952
3953 2019-02-22  Chris Dumez  <cdumez@apple.com>
3954
3955         Unreviewed, disable API test added in r241928 on iOS.
3956
3957         The cache is not enabled on devices with less than 3GB of RAM.
3958
3959         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3960
3961 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3962
3963         Hardcode Visual Viewports on everywhere except iOS WK1
3964         https://bugs.webkit.org/show_bug.cgi?id=194928
3965
3966         Reviewed by Zalan Bujtas.
3967
3968         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3969         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3970         set it to false. The setting has shipped for several years and there's no need to turn
3971         it off now.
3972
3973         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3974         Visual Viewports are not enabled.
3975         
3976         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3977         that only runs in WK2
3978
3979         * MiniBrowser/mac/SettingsController.h:
3980         * MiniBrowser/mac/SettingsController.m:
3981         (-[SettingsController init]):
3982         (-[SettingsController _populateMenu]):
3983         (-[SettingsController validateMenuItem:]):
3984         (-[SettingsController visualViewportEnabled]): Deleted.
3985         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3986         * MiniBrowser/mac/WK1BrowserWindowController.m:
3987         (-[WK1BrowserWindowController didChangeSettings]):
3988         * MiniBrowser/mac/WK2BrowserWindowController.m:
3989         (-[WK2BrowserWindowController didChangeSettings]):
3990
3991 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3992
3993         Discard cached processes when clearing website data store
3994         https://bugs.webkit.org/show_bug.cgi?id=194894
3995
3996         Reviewed by Chris Dumez.
3997
3998         Added a test case.
3999
4000         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4001         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
4002
4003 2019-02-21  Alex Christensen  <achristensen@webkit.org>
4004
4005         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
4006         https://bugs.webkit.org/show_bug.cgi?id=194914
4007         <rdar://problem/47586889>
4008
4009         Reviewed by Geoffrey Garen.
4010
4011         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4012         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
4013         (TEST):
4014         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
4015
4016 2019-02-21  David Kilzer  <ddkilzer@apple.com>
4017
4018         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
4019         <https://webkit.org/b/194761>
4020
4021         Reviewed by Myles Maxfield.
4022
4023         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4024         (WTR::activateSystemCoreWebFonts): Log `error` to console if
4025         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
4026         to use ARC-compliant cast.
4027         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
4028         ARC-compliant cast.
4029         (WTR::installFakeHelvetica): Log `error` to console if
4030         CTFontManagerRegisterFontsForURL() fails, but only on supported
4031         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
4032         Call CFRelease() on `error` to fix the leak.  Update to use
4033         ARC-compliant cast.
4034         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
4035         cast.
4036
4037 2019-02-21  Chris Dumez  <cdumez@apple.com>
4038
4039         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
4040         https://bugs.webkit.org/show_bug.cgi?id=194481
4041
4042         Reviewed by Alex Christensen.
4043
4044         Give the processes a chance to shutdown and wait until we reached the expected number
4045         of processes.
4046
4047         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4048
4049 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4050
4051         Fix the macOS build
4052
4053         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4054
4055 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4056
4057         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4058
4059         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4060         I am a backwards.
4061
4062 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4063
4064         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
4065
4066         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4067         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
4068         We could force on UI-side compositing, but I feel like the test might be more
4069         valuable exercising the normal path on each platform (though the original
4070         bug was also UI-side specific). Though we can't validate that the overlay
4071         layer was installed successfully, there are layout tests that do that.
4072
4073 2019-02-21  Tim Horton  <timothy_horton@apple.com>
4074
4075         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
4076         https://bugs.webkit.org/show_bug.cgi?id=194845
4077         <rdar://problem/47944579>
4078
4079         Reviewed by Antti Koivisto.
4080
4081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4082         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4083
4084 2019-02-21  Zalan Bujtas  <zalan@apple.com>
4085
4086         [LFC][Floats] Add support for placing formatting roots in-between floats.
4087         https://bugs.webkit.org/show_bug.cgi?id=194902
4088
4089         Reviewed by Antti Koivisto.
4090
4091         * LayoutReloaded/misc/LFC-passing-tests.txt:
4092
4093 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
4094
4095         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
4096         https://bugs.webkit.org/show_bug.cgi?id=194901
4097
4098         Unreviewed build fix.
4099
4100         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
4101         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
4102         WPEBackend-fdo-0.1 as library name.
4103
4104 2019-02-21  Rob Buis  <rbuis@igalia.com>
4105
4106         Update MIME type parser
4107         https://bugs.webkit.org/show_bug.cgi?id=180526
4108
4109         Reviewed by Darin Adler.
4110
4111         Add tests involving leading and trailing whitespace, non-token
4112         characters and quoted strings.
4113
4114         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4115         (TestWebKitAPI::TEST):
4116
4117 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
4118
4119         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
4120         https://bugs.webkit.org/show_bug.cgi?id=194884
4121
4122         Reviewed by Michael Catanzaro.
4123
4124         * PlatformWin.cmake:
4125
4126 2019-02-20  Chris Dumez  <cdumez@apple.com>
4127
4128         Add API test for <rdar://problem/47471222>
4129         https://bugs.webkit.org/show_bug.cgi?id=194847
4130
4131         Reviewed by Alex Christensen.
4132
4133         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4134
4135 2019-02-20  Chris Dumez  <cdumez@apple.com>
4136
4137         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4138         https://bugs.webkit.org/show_bug.cgi?id=194872
4139         <rdar://problem/47924500>
4140
4141         Reviewed by Alex Christensen.
4142
4143         Add API test coverage.
4144
4145         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4146
4147 2019-02-20  Jer Noble  <jer.noble@apple.com>
4148
4149         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4150         https://bugs.webkit.org/show_bug.cgi?id=191332
4151
4152         Reviewed by Dean Jackson.
4153
4154         * Scripts/git-is-in-range: Added.
4155
4156 2019-02-20  Andy Estes  <aestes@apple.com>
4157
4158         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4159         https://bugs.webkit.org/show_bug.cgi?id=194869
4160
4161         Rubber-stamped by Jer Noble.
4162
4163         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4164         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4165         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4166         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4168         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4169
4170 2019-02-20  Chris Dumez  <cdumez@apple.com>
4171
4172         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4173         https://bugs.webkit.org/show_bug.cgi?id=194857
4174         <rdar://problem/47759323>
4175
4176         Reviewed by Alex Christensen.
4177
4178         Add API test coverage.
4179
4180         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4181
4182 2019-02-20  Chris Dumez  <cdumez@apple.com>
4183
4184         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4185         https://bugs.webkit.org/show_bug.cgi?id=194829
4186         <rdar://problem/47889906>
4187
4188         Reviewed by Alexey Proskuryakov.
4189
4190         Every time the TestOptions were changing we were creating both a new Web view and
4191         a new WKContext, which would start a new Network process. In most cases, we only
4192         need to contruct a new Web view and we do can keep reusing the same WKContext.
4193         This patch implements this optimization and thus avoids spinning a lot of new
4194         Network processes while running the layout tests.
4195
4196         * WebKitTestRunner/TestController.cpp:
4197         (WTR::TestController::generateContextConfiguration const):
4198         (WTR::TestController::generatePageConfiguration):
4199         (WTR::TestController::createWebViewWithOptions):
4200         (WTR::TestController::resetPreferencesToConsistentValues):
4201         (WTR::updateTestOptionsFromTestHeader):
4202         * WebKitTestRunner/TestController.h:
4203         * WebKitTestRunner/TestOptions.h:
4204         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4205         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4206         (WTR::TestOptions::hasSameInitializationOptions const):
4207         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4208         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4209         (WTR::TestController::platformAddTestOptions const):
4210
4211 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4212
4213         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4214         https://bugs.webkit.org/show_bug.cgi?id=167941
4215
4216         Reviewed by Carlos Garcia Campos.
4217
4218         * MiniBrowser/gtk/main.c:
4219         (filterSavedCallback): Added.
4220         (main): Support loading a JSON rule set file for content filtering.
4221         * MiniBrowser/wpe/main.cpp:
4222         (filterSavedCallback): Added.
4223         (main): Support loading a JSON rule set file for content filtering.
4224         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4225         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4226         (WTF::derefGPtr): Ditto.
4227         (testEmptyStore):
4228         (testSaveInvalidFilter):
4229         (testSaveLoadFilter):
4230         (testSavedFilterIdentifierMatch):
4231         (testRemoveFilter):
4232         (testSaveMultipleFilters):
4233         (testSaveFilterFromFile):
4234         (testFilterPersistence):
4235         (beforeAll):
4236         (afterAll):
4237         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4238         (removeOldInjectedContentAndResetLists): Also reset content filters.
4239         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4240         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4241         the element affected by the style sheet.
4242         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4243         and returns it to be used by tests.
4244         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4245         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4246         (serverCallback): Add support for serving a CSS style sheet for testing.
4247         (beforeAll): Add call to testUserContentManagerContentFilter().
4248         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4249
4250 2019-02-19  Keith Rollin  <krollin@apple.com>
4251
4252         Add timing information to build output
4253         https://bugs.webkit.org/show_bug.cgi?id=194839
4254         <rdar://problem/48219609>
4255
4256         Reviewed by Alexey Proskuryakov.
4257
4258         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4259         emit each project's build time to its output. E.g.,
4260
4261             ** BUILD SUCCEEDED ** [0.132 sec]
4262
4263         * Scripts/webkitdirs.pm:
4264         (XcodeOptions):
4265
4266 2019-02-19  Truitt Savell  <tsavell@apple.com>
4267
4268         Unreviewed, rolling out r241784.
4269
4270         Broke all OpenSource builds.
4271
4272         Reverted changeset:
4273
4274         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4275         instances view"
4276         https://bugs.webkit.org/show_bug.cgi?id=172848
4277         https://trac.webkit.org/changeset/241784
4278
4279 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4280
4281         [LFC][Floats] Remove redundant intersecting logic
4282         https://bugs.webkit.org/show_bug.cgi?id=194804
4283
4284         Reviewed by Antti Koivisto.
4285
4286         * LayoutReloaded/misc/LFC-passing-tests.txt:
4287
4288 2019-02-19  Dean Jackson  <dino@apple.com>
4289
4290         Clean-up output from generate-xcfilelists so it can be filtered
4291         https://bugs.webkit.org/show_bug.cgi?id=194795
4292
4293         Reviewed by Joseph Pecoraro (and Keith Rollin).
4294
4295         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4296         make a slight tweak to filter-build-webkit so such lines are marked
4297         as plain.
4298
4299         * Scripts/filter-build-webkit:
4300         * Scripts/generate-xcfilelists:
4301
4302 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4303
4304         pytest is not correctly auto-installed
4305         https://bugs.webkit.org/show_bug.cgi?id=194707
4306
4307         Reviewed by Carlos Garcia Campos.
4308
4309         * Scripts/webkitpy/thirdparty/__init__.py:
4310         (AutoinstallImportHook._install_pytest):
4311
4312 2019-02-18  Chris Dumez  <cdumez@apple.com>
4313
4314         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4315         https://bugs.webkit.org/show_bug.cgi?id=194797
4316         <rdar://problem/48055151>
4317
4318         Reviewed by Geoffrey Garen.
4319
4320         Add API test coverage.
4321
4322         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4323
4324 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4325
4326         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4327         https://bugs.webkit.org/show_bug.cgi?id=194670
4328         <rdar://problem/39066529>
4329
4330         Reviewed by Tim Horton.
4331
4332         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4333         pasted in an editable area as attachment elements.
4334
4335         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4336         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4337         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4338         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4339         (TestWebKitAPI::TEST):
4340         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4341         (WTR::InjectedBundlePage::InjectedBundlePage):
4342
4343 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4344
4345         Fix API test after r241728
4346        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4347
4348         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4349         (TEST):
4350         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4351
4352 2019-02-18  Daniel Bates  <dabates@apple.com>
4353
4354         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4355         https://bugs.webkit.org/show_bug.cgi?id=192824
4356         <rdar://problem/47100332>
4357
4358         Reviewed by Wenson Hsieh.
4359
4360         Fix a bug where the wrong usage code was used for F13 thru F24.
4361
4362         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4363         (keyCodeForDOMFunctionKey):