Fix string concatenation API test after r239920
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2
3         Fix string concatenation API test after r239920
4         https://bugs.webkit.org/show_bug.cgi?id=193551
5         <rdar://problem/47359304>
6
7         Reviewed by Youenn Fablet.
8
9         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
10         (TestWebKitAPI::TEST):
11         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
12         in WebKit's build configuration like it apparently is on Linux.
13
14 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
15
16         [ews-build] validate-patch should handle the case when bug_id is None
17         https://bugs.webkit.org/show_bug.cgi?id=193547
18
19         Reviewed by Lucas Forschler.
20
21         * BuildSlaveSupport/ews-build/steps.py:
22         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
23         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
24
25 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
26
27         [ews-build] Add patch author information in build
28         https://bugs.webkit.org/show_bug.cgi?id=193465
29
30         Reviewed by Lucas Forschler.
31
32         * BuildSlaveSupport/ews-build/steps.py:
33         (ValidatePatch._is_patch_obsolete):
34
35 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
36
37         [ews-build] Pass bug_id to the triggered builds
38         https://bugs.webkit.org/show_bug.cgi?id=193548
39
40         Reviewed by Lucas Forschler.
41
42         * BuildSlaveSupport/ews-build/factories.py:
43         (BuildFactory.propertiesToPassToTriggers):
44
45 2019-01-17  Jer Noble  <jer.noble@apple.com>
46
47         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
48         https://bugs.webkit.org/show_bug.cgi?id=189553
49
50         Reviewed by Tim Horton.
51
52         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
53
54         * ContentExtensionTester/Configurations/Base.xcconfig:
55         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
56         * DumpRenderTree/mac/Configurations/Base.xcconfig:
57         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
58         * ImageDiff/cg/Configurations/Base.xcconfig:
59         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
60         * MiniBrowser/Configurations/Base.xcconfig:
61         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
62         * MobileMiniBrowser/Configurations/Base.xcconfig:
63         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
64         * Scripts/webkitpy/style/checker.py:
65         (_all_categories):
66         (FileType):
67         (CheckerDispatcher._file_type):
68         (CheckerDispatcher._create_checker):
69         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
70         (SDKVariantChecker):
71         (SDKVariantChecker.__init__):
72         (SDKVariantChecker.check):
73         * TestWebKitAPI/Configurations/Base.xcconfig:
74         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
75         * WebEditingTester/Configurations/Base.xcconfig:
76         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
77         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
78         * WebKitTestRunner/Configurations/Base.xcconfig:
79         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
80         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
81         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
82
83 2019-01-17  Zalan Bujtas  <zalan@apple.com>
84
85         [LFC][BFC] An element with transform is a containing block for positioned descendants.
86         https://bugs.webkit.org/show_bug.cgi?id=193534
87
88         Reviewed by Antti Koivisto.
89
90         * LayoutReloaded/misc/LFC-passing-tests.txt:
91
92 2019-01-17  Zalan Bujtas  <zalan@apple.com>
93
94         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
95         https://bugs.webkit.org/show_bug.cgi?id=193528
96
97         Reviewed by Antti Koivisto.
98
99         * LayoutReloaded/misc/LFC-passing-tests.txt:
100
101 2019-01-17  Zalan Bujtas  <zalan@apple.com>
102
103         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
104         https://bugs.webkit.org/show_bug.cgi?id=193520
105
106         Reviewed by Antti Koivisto.
107
108         * LayoutReloaded/misc/LFC-passing-tests.txt:
109
110 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
111
112         [ews-build] unapply-patch step should not update source
113         https://bugs.webkit.org/show_bug.cgi?id=193234
114
115         Reviewed by Lucas Forschler.
116
117         * BuildSlaveSupport/ews-build/steps.py:
118         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
119         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
120
121 2019-01-16  Youenn Fablet  <youenn@apple.com>
122
123         Add a new SPI for controlling getUserMedia
124         https://bugs.webkit.org/show_bug.cgi?id=192793
125
126         Reviewed by Eric Carlson.
127
128         * MiniBrowser/mac/WK2BrowserWindowController.m:
129         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
130         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
131         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
132         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
133         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
134         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
135         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
136         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
137         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
138         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
139         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
140         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
141         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
142         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
143
144 2019-01-16  Zalan Bujtas  <zalan@apple.com>
145
146         [LFC][BFC] Inflow non-replaced used width should not be negative.
147         https://bugs.webkit.org/show_bug.cgi?id=193495
148
149         Reviewed by Antti Koivisto.
150
151         * LayoutReloaded/misc/LFC-passing-tests.txt:
152
153 2019-01-16  Chris Dumez  <cdumez@apple.com>
154
155         Regression(PSON) View becomes blank after click a cross-site download link
156         https://bugs.webkit.org/show_bug.cgi?id=193361
157         <rdar://problem/47099573>
158
159         Reviewed by Geoffrey Garen.
160
161         Add API test coverage.
162
163         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
164         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
165
166 2019-01-16  Zalan Bujtas  <zalan@apple.com>
167
168         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
169         https://bugs.webkit.org/show_bug.cgi?id=193470
170
171         Reviewed by Antti Koivisto.
172
173         * LayoutReloaded/misc/LFC-passing-tests.txt:
174
175 2019-01-16  Zalan Bujtas  <zalan@apple.com>
176
177         [LFC] Adjust margin box verification.
178         https://bugs.webkit.org/show_bug.cgi?id=193482
179
180         Reviewed by Antti Koivisto.
181
182         * LayoutReloaded/misc/LFC-passing-tests.txt:
183
184 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
185
186         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
187         https://bugs.webkit.org/show_bug.cgi?id=193451
188
189         Reviewed by Geoffrey Garen.
190
191         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
192         (TEST):
193         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
194         (runWebsiteDataStoreCustomPaths):
195
196 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
197
198         webkitpy: Support boolean simctl isAvailable
199         https://bugs.webkit.org/show_bug.cgi?id=193472
200         <rdar://problem/47296150>
201
202         Reviewed by Ryosuke Niwa.
203
204         * Scripts/webkitpy/xcode/simulated_device.py:
205         (SimulatedDeviceManager._create_runtimes):
206         (SimulatedDeviceManager._create_device_with_runtime):
207
208 2019-01-15  Chris Dumez  <cdumez@apple.com>
209
210         Unreviewed, rolling out r239993, r239995, r239997, and
211         r239999.
212
213         Caused assertions under
214         ViewGestureController::disconnectFromProcess()
215
216         Reverted changesets:
217
218         "Regression(PSON) View becomes blank after click a cross-site
219         download link"
220         https://bugs.webkit.org/show_bug.cgi?id=193361
221         https://trac.webkit.org/changeset/239993
222
223         "Unreviewed iOS build fix after r239993."
224         https://trac.webkit.org/changeset/239995
225
226         "Fix iOS build after r239993"
227         https://bugs.webkit.org/show_bug.cgi?id=193361
228         https://trac.webkit.org/changeset/239997
229
230         "Unreviewed, revert part of r239997 as it is not needed to fix
231         the build."
232         https://trac.webkit.org/changeset/239999
233
234 2019-01-15  Tim Horton  <timothy_horton@apple.com>
235
236         Cannot tab out of WKWebView on macOS
237         https://bugs.webkit.org/show_bug.cgi?id=161448
238         <rdar://problem/28100085>
239
240         Reviewed by Dean Jackson.
241
242         Add a test that tabbing into and out of WKWebView works correctly.
243
244         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
245         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
246         (WebKit2_CommandBackForwardTest::SetUp):
247         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
248         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
249         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
250         (-[FocusableView canBecomeKeyView]):
251         (TEST):
252         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
253         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
254         (-[OffscreenWindow initWithSize:]):
255         (-[OffscreenWindow isKeyWindow]):
256         (-[OffscreenWindow isVisible]):
257         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
258         (TestWebKitAPI::PlatformWebView::initialize):
259         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
260         (-[ActiveOffscreenWindow isVisible]): Deleted.
261         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
262
263 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
264
265         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
266         https://bugs.webkit.org/show_bug.cgi?id=193459
267
268         Reviewed by Mark Lam.
269
270         * BuildSlaveSupport/build.webkit.org-config/steps.py:
271         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
272
273 2019-01-15  Chris Dumez  <cdumez@apple.com>
274
275         Regression(PSON) View becomes blank after click a cross-site download link
276         https://bugs.webkit.org/show_bug.cgi?id=193361
277         <rdar://problem/47099573>
278
279         Reviewed by Geoff Garen.
280
281         Add API test coverage.
282
283         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
284         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
285
286 2019-01-15  Zalan Bujtas  <zalan@apple.com>
287
288         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
289         https://bugs.webkit.org/show_bug.cgi?id=193448
290
291         Reviewed by Antti Koivisto.
292
293         * LayoutReloaded/misc/LFC-passing-tests.txt:
294
295 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
296
297         webkitpy: Implement device type specific expected results (Part 1)
298         https://bugs.webkit.org/show_bug.cgi?id=192162
299
300         Reviewed by Lucas Forschler.
301
302         Device type specific expected results covers two related ideas. The first (covered by this change)
303         is where to search for -expected.* files. The second is which tests to run based on the
304         TestExpectations.txt file.
305
306         After this change, the baseline search path will be determined by the type of device running a
307         test. Device type will be passed into any function which picks a file based on the baseline search
308         path.
309
310         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
311         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
312         * Scripts/webkitpy/layout_tests/controllers/manager.py:
313         (Manager.run): Print baseline search path for each round of devices.
314         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
315         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
316         (SingleTestRunner._expected_driver_output): Ditto.
317         (SingleTestRunner._driver_input): Ditto.
318         * Scripts/webkitpy/layout_tests/views/printing.py:
319         (Printer.print_config): Move printing of baseline search path to a separate function.
320         (Printer.print_baseline_search_path): Moved from Printer.print_config.
321         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
322         (Testprinter.test_print_config):
323         (Testprinter.test_print_baseline_search_path):
324         * Scripts/webkitpy/port/base.py:
325         (Port.baseline_search_path): Pass device_type through.
326         (Port._expected_baselines_for_suffixes): Ditto.
327         (Port.expected_baselines): Ditto.
328         (Port.expected_filename): Ditto.
329         (Port.expected_checksum): Ditto.
330         (Port.expected_image): Ditto.
331         (Port.expected_audio): Ditto.
332         (Port.expected_text): Ditto.
333         (Port.reference_files): Ditto.
334         (Port.tests): Ditto.
335         (Port._expanded_paths): Ditto.
336         (Port.skipped_layout_tests): Ditto.
337         (Port.expectations_dict): Ditto.
338         (Port._port_specific_expectations_files): Ditto.
339         (Port.expectations_files): Ditto.
340         (Port.test_search_path): Ditto.
341         (Port._tests_for_other_platforms): Ditto.
342         * Scripts/webkitpy/port/base_unittest.py:
343         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
344         (PortTest.test_nonexistant_expectations): Ditto.
345         (test_ref_tests_platform_directory): Ditto.
346         * Scripts/webkitpy/port/darwin.py:
347         (DarwinPort._port_specific_expectations_files): Accept device_type.
348         * Scripts/webkitpy/port/driver.py:
349         (DriverProxy):
350         (DriverProxy.host): Expose _target_host for device_type information.
351         * Scripts/webkitpy/port/gtk.py:
352         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
353         * Scripts/webkitpy/port/ios.py:
354         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
355         * Scripts/webkitpy/port/mac.py:
356         (MacPort. default_baseline_search_path): Ditto.
357         * Scripts/webkitpy/port/port_testcase.py:
358         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
359         * Scripts/webkitpy/port/test.py:
360         * Scripts/webkitpy/port/watch.py:
361         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
362         * Scripts/webkitpy/port/win.py:
363         (WinPort.test_search_path): Accept, but do not use, device_type.
364         * Scripts/webkitpy/port/wpe.py:
365         (WPEPort._port_specific_expectations_files): Ditto.
366         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
367         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
368
369 2019-01-15  Zalan Bujtas  <zalan@apple.com>
370
371         [LFC] Use the containing block's padding box to position out-of-flow elements.
372         https://bugs.webkit.org/show_bug.cgi?id=193431
373
374         Reviewed by Antti Koivisto.
375
376         * LayoutReloaded/misc/LFC-passing-tests.txt:
377
378 2019-01-14  Tim Horton  <timothy_horton@apple.com>
379
380         Move a test implementation file that got misplaced in the Xcode project
381
382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
383
384 2019-01-14  Commit Queue  <commit-queue@webkit.org>
385
386         Unreviewed, rolling out r239901, r239909, r239910, r239912,
387         r239913, and r239914.
388         https://bugs.webkit.org/show_bug.cgi?id=193407
389
390         These revisions caused an internal failure (Requested by
391         Truitt on #webkit).
392
393         Reverted changesets:
394
395         "[Cocoa] Avoid importing directly from subumbrella frameworks"
396         https://bugs.webkit.org/show_bug.cgi?id=186016
397         https://trac.webkit.org/changeset/239901
398
399         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
400         https://trac.webkit.org/changeset/239909
401
402         "Tried to fix the build."
403         https://trac.webkit.org/changeset/239910
404
405         "Fixed iOS builds after r239910."
406         https://trac.webkit.org/changeset/239912
407
408         "More build fixing."
409         https://trac.webkit.org/changeset/239913
410
411         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
412         https://trac.webkit.org/changeset/239914
413
414 2019-01-14  Mark Lam  <mark.lam@apple.com>
415
416         Re-enable ability to build --cloop builds.
417         https://bugs.webkit.org/show_bug.cgi?id=192955
418         <rdar://problem/46882363>
419
420         Reviewed by Saam barati and Keith Miller.
421
422         The --cloop build option was being ignored this whole time since r236381.
423         This patch makes it possible to build CLoop builds again.
424
425         * Scripts/build-jsc:
426         * Scripts/webkitperl/FeatureList.pm:
427         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
428
429 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
430
431         webkitpy: Expose device_type from host-like objects
432         https://bugs.webkit.org/show_bug.cgi?id=193406
433         <rdar://problem/47262305>
434
435         Reviewed by Lucas Forschler.
436
437         Devices should expose device_type. As a result, all host objects should
438         provide a device_type property, even if they do not yet define a device_type.
439
440         * Scripts/webkitpy/common/system/systemhost.py:
441         (SystemHost):
442         (SystemHost.device_type):
443         * Scripts/webkitpy/common/system/systemhost_mock.py:
444         (MockSystemHost):
445         (MockSystemHost.device_type):
446         * Scripts/webkitpy/port/device.py:
447         (Device):
448         (Device.device_type):
449         * Scripts/webkitpy/xcode/simulated_device.py:
450         (SimulatedDeviceManager._find_exisiting_device_for_request):
451         (SimulatedDeviceManager._disambiguate_device_type):
452         (SimulatedDeviceManager._does_fulfill_request):
453         (SimulatedDeviceManager.device_count_for_type):
454         (SimulatedDeviceManager.initialize_devices):
455         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
456         (test_available_devices):
457         (test_swapping_devices):
458
459 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
460
461         webkitpy: Support alternate simctl device list output (Follow-up fix)
462         https://bugs.webkit.org/show_bug.cgi?id=193362
463         <rdar://problem/47122965>
464
465         Rubber-stamped by Lucas Forschler.
466
467         * Scripts/webkitpy/xcode/simulated_device.py:
468         (SimulatedDeviceManager.populate_available_devices):
469
470 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
471
472         [iOS] Expose SPI to access the current sentence boundary and selection state
473         https://bugs.webkit.org/show_bug.cgi?id=193398
474         <rdar://problem/45893108>
475
476         Reviewed by Dean Jackson.
477
478         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
479         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
480         expected.
481
482         * TestWebKitAPI/EditingTestHarness.h:
483         * TestWebKitAPI/EditingTestHarness.mm:
484         (-[EditingTestHarness moveBackward]):
485         (-[EditingTestHarness moveForward]):
486         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
487
488         Add a couple of new helper methods on EditingTestHarness.
489
490         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
491         (-[SelectionChangeObserver initWithWebView:]):
492         (-[SelectionChangeObserver webView]):
493         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
494         (-[SelectionChangeObserver currentSelectionAttributes]):
495
496 2019-01-14  Zalan Bujtas  <zalan@apple.com>
497
498         [LFC][BFC] Add basic box-sizing support.
499         https://bugs.webkit.org/show_bug.cgi?id=193392
500
501         Reviewed by Antti Koivisto.
502
503         * LayoutReloaded/misc/LFC-passing-tests.txt:
504
505 2019-01-14  Charlie Turner  <cturner@igalia.com>
506
507         [WPE] API test gardening
508         https://bugs.webkit.org/show_bug.cgi?id=193319
509
510         Reviewed by Michael Catanzaro.
511
512         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
513         passing tests.
514
515 2019-01-14  Charlie Turner  <cturner@igalia.com>
516
517         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
518         https://bugs.webkit.org/show_bug.cgi?id=192977
519
520         Reviewed by Carlos Garcia Campos.
521
522         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
523         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
524         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
525         (TestWebKitAPI::GStreamerTest::SetUp):
526         (TestWebKitAPI::GStreamerTest::TearDown):
527         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
528         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
529         (TestWebKitAPI::TEST_F):
530
531 2019-01-14  Charlie Turner  <cturner@igalia.com>
532
533         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
534         https://bugs.webkit.org/show_bug.cgi?id=193332
535
536         Reviewed by Michael Catanzaro.
537
538         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
539         defined as a char16_t, which changed in ICU 59, the
540         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
541         unsigned short. This test is relying on the behaviour that
542         UChar=unsigned short, which doesn't hold across platforms and ICU
543         library versions. The full fix would be a special syntax for
544         literal characters so that these ambiguities do not arise. That
545         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
546         (TestWebKitAPI::TEST):
547
548 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
549
550         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
551
552         * Scripts/make-dist:
553         (Distcheck.configure):
554
555 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
556
557         [ews-build] Update macOS queue configurations
558         https://bugs.webkit.org/show_bug.cgi?id=193365
559         <rdar://problem/47221073>
560
561         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
562
563         * BuildSlaveSupport/ews-build/config.json:
564
565 2019-01-13  Zalan Bujtas  <zalan@apple.com>
566
567         [LFC] Adjust assert for statically positioned fixed elements
568         https://bugs.webkit.org/show_bug.cgi?id=193385
569
570         Reviewed by Antti Koivisto.
571
572         * LayoutReloaded/misc/LFC-passing-tests.txt:
573
574 2019-01-13  Philippe Normand  <pnormand@igalia.com>
575
576         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
577         https://bugs.webkit.org/show_bug.cgi?id=193387
578
579         Reviewed by Carlos Garcia Campos.
580
581         * MiniBrowser/wpe/main.cpp:
582         (main):
583
584 2019-01-12  Timothy Hatcher  <timothy@apple.com>
585
586         Have prefers-color-scheme: light always match on macOS versions before Mojave.
587         https://bugs.webkit.org/show_bug.cgi?id=191655
588         rdar://problem/46074680
589
590         Reviewed by Megan Gardner.
591
592         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
593         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
594
595 2019-01-12  Dan Bernstein  <mitz@apple.com>
596
597         [Cocoa] Avoid importing directly from subumbrella frameworks
598         https://bugs.webkit.org/show_bug.cgi?id=186016
599         <rdar://problem/40591038>
600
601         Reviewed by Sam Weinig.
602
603         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
604           LaunchServices header.
605         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
606           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
607         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
608           when using SDKs earlier than 10.13.
609         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
610           and OTHER_CPLUSPLUSFLAGS.
611         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
612           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
613         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
614           LaunchServices header.
615
616 2019-01-11  John Wilander  <wilander@apple.com>
617
618         Compile out Web API Statistics Collection
619         https://bugs.webkit.org/show_bug.cgi?id=193370
620         <rdar://problem/45388584>
621
622         Reviewed by Brent Fulgham.
623
624         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
625             Defined ENABLE_WEB_API_STATISTICS, off by default.
626
627 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
628
629         [WPE] Add gtk-doc
630         https://bugs.webkit.org/show_bug.cgi?id=178900
631
632         Reviewed by Michael Catanzaro.
633
634         Add Tools/gtkdoc to manifest.txt.in files.
635         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
636
637         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
638         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
639
640 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
641
642         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
643         https://bugs.webkit.org/show_bug.cgi?id=193364
644         <rdar://problem/47214117>
645
646         Reviewed by Tim Horton.
647
648         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
649         precise, whereas dragging near the middle of the textarea does.
650
651         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
652         (TestWebKitAPI::TEST):
653
654 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
655
656         webkitpy: Support alternate simctl device list output
657         https://bugs.webkit.org/show_bug.cgi?id=193362
658         <rdar://problem/47122965>
659
660         Reviewed by Lucas Forschler.
661
662         * Scripts/webkitpy/xcode/simulated_device.py:
663         (SimulatedDeviceManager.populate_available_devices):
664
665 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
666
667         [ews-build] Update macOS queue configurations
668         https://bugs.webkit.org/show_bug.cgi?id=193365
669
670         Reviewed by Lucas Forschler.
671
672         * BuildSlaveSupport/ews-build/config.json:
673
674 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
675
676         webkitpy: Incorporate device type into baseline search path
677         https://bugs.webkit.org/show_bug.cgi?id=193356
678         <rdar://problem/47215515>
679
680         Reviewed by Lucas Forschler.
681
682         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
683
684         * Scripts/webkitpy/port/base.py:
685         (Port.default_baseline_search_path): Allow device type to be passed in.
686         * Scripts/webkitpy/port/gtk.py:
687         (GtkPort.default_baseline_search_path): Ignore device type.
688         * Scripts/webkitpy/port/ios.py:
689         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
690         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
691         * Scripts/webkitpy/port/ios_device_unittest.py:
692         (IOSDeviceTest):
693         * Scripts/webkitpy/port/ios_simulator_unittest.py:
694         (IOSSimulatorTest):
695         * Scripts/webkitpy/port/mac.py:
696         (MacPort.default_baseline_search_path): Ignore device type.
697         * Scripts/webkitpy/port/watch.py:
698         (WatchPort.default_baseline_search_path): Ditto.
699         * Scripts/webkitpy/port/win.py:
700         (WinPort.default_baseline_search_path): Ditto.
701         (WinCairoPort.default_baseline_search_path): Ditto.
702         * Scripts/webkitpy/port/wpe.py:
703         (WPEPort.default_baseline_search_path): Ditto.
704
705 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
706
707         webkitpy: Print abbreviated baseline search path that includes only folders that exist
708         https://bugs.webkit.org/show_bug.cgi?id=193352
709         <rdar://problem/47210736>
710
711         Reviewed by Lucas Forschler.
712
713         * Scripts/webkitpy/layout_tests/views/printing.py:
714         (Printer.print_config): Print list on only baseline search paths which exist. 
715         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
716         (Testprinter.test_print_config):
717
718 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
719
720         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
721         https://bugs.webkit.org/show_bug.cgi?id=193340
722
723         Reviewed by David Kilzer.
724
725         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
726         (WTR::InjectedBundle::didReceiveMessageToPage):
727         Pull the strings out into a WKRetainPtr.
728
729         * WebKitTestRunner/WebNotificationProvider.cpp:
730         (WTR::WebNotificationProvider::closeWebNotification):
731         Adopt the created value into the WKRetainPtr.
732
733         * WebKitTestRunner/mac/TestControllerMac.mm:
734         (WTR::generateWhitelist):
735         Immediately adopt a created value to avoid potential mistakes.
736
737 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
738
739         Enable DFG on ARM/Linux again
740         https://bugs.webkit.org/show_bug.cgi?id=192496
741
742         Reviewed by Yusuke Suzuki.
743
744         After changing the bytecode format DFG was disabled on all 32-bit
745         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
746         on ARM by default.
747
748         * Scripts/run-jsc-stress-tests:
749
750 2019-01-11  Timothy Hatcher  <timothy@apple.com>
751
752         Unreviewed, fix #ifdef in API test added in r239851.
753         https://bugs.webkit.org/show_bug.cgi?id=193327
754         rdar://problem/47093222
755
756         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
757
758 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
759
760         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
761         https://bugs.webkit.org/show_bug.cgi?id=193109
762         <rdar://problem/44807048>
763
764         Reviewed by Ryosuke Niwa.
765
766         Introduce and respect a test option to enable the UndoManager API.
767
768         * WebKitTestRunner/TestController.cpp:
769         (WTR::updateTestOptionsFromTestHeader):
770         * WebKitTestRunner/TestOptions.h:
771         (WTR::TestOptions::hasSameInitializationOptions const):
772         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
773         (WTR::TestController::platformCreateWebView):
774
775 2019-01-11  Zalan Bujtas  <zalan@apple.com>
776
777         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
778         https://bugs.webkit.org/show_bug.cgi?id=193346
779
780         Reviewed by Antti Koivisto.
781
782         * LayoutReloaded/misc/LFC-passing-tests.txt:
783
784 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
785
786         Unreviewed, fix typo that breaks dashboard link.
787
788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
789         (WebKitBuildbot):
790
791 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
792
793         Update macOS queue configurations
794         https://bugs.webkit.org/show_bug.cgi?id=193329
795
796         Reviewed by Alexey Proskuryakov.
797
798         * BuildSlaveSupport/build.webkit.org-config/config.json:
799         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
800         (BubbleQueueServer):
801         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
802         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
803         (WebKitBuildbot):
804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
805         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
806         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
807
808 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
809
810         MiniBrowser should be able to navigate to about:blank
811         https://bugs.webkit.org/show_bug.cgi?id=193345
812
813         Reviewed by Simon Fraser.
814
815         * MiniBrowser/mac/BrowserWindowController.m:
816         (-[BrowserWindowController addProtocolIfNecessary:]):
817         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
818
819         * MiniBrowser/mac/WK1BrowserWindowController.m:
820         (-[WK1BrowserWindowController fetch:]):
821         * MiniBrowser/mac/WK2BrowserWindowController.m:
822         (-[WK2BrowserWindowController fetch:]):
823         Clean up the code that uses this to match style.
824
825 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
826
827         Remove MiniBrowser custom "Process Swap" menu item which does not work
828         https://bugs.webkit.org/show_bug.cgi?id=193344
829
830         Reviewed by Simon Fraser.
831
832         There is a menu item under the Experimental menu that does work.
833
834         * MiniBrowser/mac/AppDelegate.m:
835         (defaultConfiguration):
836         * MiniBrowser/mac/SettingsController.h:
837         * MiniBrowser/mac/SettingsController.m:
838         (-[SettingsController _populateMenu]):
839         (-[SettingsController validateMenuItem:]):
840         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
841         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
842
843 2019-01-10  Timothy Hatcher  <timothy@apple.com>
844
845         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
846         https://bugs.webkit.org/show_bug.cgi?id=193327
847         rdar://problem/47093222
848
849         Reviewed by Tim Horton.
850
851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
852         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
853         (TestWebKitAPI::didFinishNavigation):
854         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
855         (TestWebKitAPI::TEST):
856         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
857         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
858         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
859         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
860         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
861
862 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
863
864         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
865         https://bugs.webkit.org/show_bug.cgi?id=193338
866         <rdar://problem/46664774>
867
868         Reviewed by David Kilzer.
869
870         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
871         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
872
873 2019-01-10  Commit Queue  <commit-queue@webkit.org>
874
875         Unreviewed, rolling out r239825.
876         https://bugs.webkit.org/show_bug.cgi?id=193330
877
878         Broke tests on armv7/linux bots (Requested by guijemont on
879         #webkit).
880
881         Reverted changeset:
882
883         "Enable DFG on ARM/Linux again"
884         https://bugs.webkit.org/show_bug.cgi?id=192496
885         https://trac.webkit.org/changeset/239825
886
887 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
888
889         Disable the run-jsc-stress-test remote host key check.
890         https://bugs.webkit.org/show_bug.cgi?id=192988
891
892         Reviewed by Alexey Proskuryakov.
893
894         * Scripts/run-jsc-stress-tests:
895
896 2019-01-10  John Wilander  <wilander@apple.com>
897
898         Override the session configuration for cookieAcceptPolicy
899         https://bugs.webkit.org/show_bug.cgi?id=190925
900         <rdar://problem/45497382>
901
902         Reviewed by Alexey Proskuryakov and Alex Christensen.
903
904         Test infrastructure for setting a first-party-only cookie policy.
905
906         * DumpRenderTree/TestRunner.cpp:
907         (setOnlyAcceptFirstPartyCookiesCallback):
908         (TestRunner::staticFunctions):
909         * DumpRenderTree/TestRunner.h:
910         * DumpRenderTree/mac/TestRunnerMac.mm:
911         (TestRunner::setOnlyAcceptFirstPartyCookies):
912         * DumpRenderTree/win/TestRunnerWin.cpp:
913         (TestRunner::setOnlyAcceptFirstPartyCookies):
914         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
915         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
916         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
917         * WebKitTestRunner/InjectedBundle/TestRunner.h:
918         * WebKitTestRunner/TestInvocation.cpp:
919         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
920
921 2019-01-09  Matt Rajca  <mrajca@apple.com>
922
923         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
924         https://bugs.webkit.org/show_bug.cgi?id=193301
925
926         Reviewed by Jer Noble.
927         
928         Added API tests.
929
930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
931         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
932         (TEST):
933         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
934
935 2019-01-10  Zalan Bujtas  <zalan@apple.com>
936
937         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
938         https://bugs.webkit.org/show_bug.cgi?id=193310
939
940         Reviewed by Antti Koivisto.
941
942         * LayoutReloaded/misc/LFC-passing-tests.txt:
943
944 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
945
946         Enable DFG on ARM/Linux again
947         https://bugs.webkit.org/show_bug.cgi?id=192496
948
949         Reviewed by Yusuke Suzuki.
950
951         After changing the bytecode format DFG was disabled on all 32-bit
952         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
953         on ARM by default.
954
955         * Scripts/run-jsc-stress-tests:
956
957 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
958
959         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
960         https://bugs.webkit.org/show_bug.cgi?id=193271
961
962         Reviewed by Brent Fulgham.
963
964         BSTR is a special data structure created by SysAllocString, not a
965         wchar_t null-terminated string.
966
967         * DumpRenderTree/win/TestRunnerWin.cpp:
968         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
969         * MiniBrowser/win/MiniBrowserWebHost.cpp:
970         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
971         BSTR from wide string literals.
972
973 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
974
975         Tweak wording for build/version_check style checker error
976         https://bugs.webkit.org/show_bug.cgi?id=193256
977
978         Reviewed by Tim Horton.
979
980         * Scripts/webkitpy/style/checkers/cpp.py:
981         (check_os_version_checks):
982         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
983         (WebKitStyleTest.test_os_version_checks):
984
985 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
986
987         [ews-build] Add link to bug along with bug title
988         https://bugs.webkit.org/show_bug.cgi?id=193293
989
990         Reviewed by Lucas Forschler.
991
992         * BuildSlaveSupport/ews-build/steps.py:
993         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
994         (ConfigureBuild.add_bug_id_url): Deleted.
995         (ConfigureBuild.getBugURL): Deleted.
996
997 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
998
999         [ews-build] Use https for ews-build server
1000         https://bugs.webkit.org/show_bug.cgi?id=193193
1001
1002         Reviewed by Lucas Forschler.
1003
1004         * BuildSlaveSupport/ews-build/steps.py:
1005
1006 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1007
1008         [ews-build] Parse and display number of style failures
1009         https://bugs.webkit.org/show_bug.cgi?id=193280
1010
1011         Reviewed by Lucas Forschler.
1012
1013         * BuildSlaveSupport/ews-build/steps.py:
1014         (CheckStyle): Use TestWithFailureCount as base class.
1015         (CheckStyle.countFailures): Count the number of style failures.
1016
1017 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1018
1019         [ews-build] use patch_id instead of ewspatchid
1020         https://bugs.webkit.org/show_bug.cgi?id=193235
1021
1022         Reviewed by Lucas Forschler.
1023
1024         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
1025         * BuildSlaveSupport/ews-build/steps.py: Ditto.
1026         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
1027
1028 2019-01-09  Zalan Bujtas  <zalan@apple.com>
1029
1030         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
1031         https://bugs.webkit.org/show_bug.cgi?id=192625
1032
1033         Reviewed by Antti Koivisto.
1034
1035         * LayoutReloaded/misc/LFC-passing-tests.txt:
1036
1037 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1038
1039         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
1040         https://bugs.webkit.org/show_bug.cgi?id=192841
1041
1042         Reviewed by Carlos Garcia Campos.
1043
1044         There are separate g_assert_*() macros for use in tests, which we use inconsistently
1045         currently. Use them always. We'll get nicer error messages now when tests fail, and the
1046         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
1047
1048         Note that the documentation of g_assert() says that it is not to be used when writing tests.
1049
1050         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1051         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
1052         (WebKitWebEditorTest::testSelectionChanged):
1053         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1054         (WebKitFrameTest::testMainFrame):
1055         (WebKitFrameTest::testURI):
1056         (WebKitFrameTest::testJavaScriptContext):
1057         (WebKitFrameTest::testJavaScriptValues):
1058         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1059         (testWebViewAuthenticationRequest):
1060         (testWebViewAuthenticationLoadCancelled):
1061         (testWebViewAuthenticationFailure):
1062         (testWebViewAuthenticationStorage):
1063         (ProxyAuthenticationTest::ProxyAuthenticationTest):
1064         (testWebViewAuthenticationProxy):
1065         (testWebViewAuthenticationProxyHTTPS):
1066         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1067         (testAutomationSessionRequestSession):
1068         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
1069         (testBackForwardListNavigation):
1070         (testWebKitWebViewSessionState):
1071         (testWebKitWebViewSessionStateWithFormData):
1072         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1073         (ConsoleMessageTest::consoleMessageReceivedCallback):
1074         (testWebKitConsoleMessageConsoleAPI):
1075         (testWebKitConsoleMessageJavaScriptException):
1076         (testWebKitConsoleMessageNetworkError):
1077         (testWebKitConsoleMessageSecurityError):
1078         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1079         (testCookieManagerAcceptPolicy):
1080         (testCookieManagerCookiesChanged):
1081         (testCookieManagerPersistentStorage):
1082         (testCookieManagerPersistentStorageDeleteAll):
1083         (testCookieManagerEphemeral):
1084         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
1085         (testWebKitDOMElementAutoFill):
1086         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1087         (downloadLocalFileSuccessfully):
1088         (createFileAtDestination):
1089         (testDownloadOverwriteDestinationDisallowed):
1090         (testDownloadLocalFileError):
1091         (testDownloadRemoteFile):
1092         (testDownloadRemoteFileError):
1093         (testWebViewDownloadURI):
1094         (testPolicyResponseDownload):
1095         (testPolicyResponseDownloadCancel):
1096         (testDownloadMIMEType):
1097         (contextMenuCallback):
1098         (testContextMenuDownloadActions):
1099         (testBlobDownload):
1100         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
1101         (testWebKitWebEditorSelectionChanged):
1102         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1103         (testWebKitFrameMainFrame):
1104         (testWebKitFrameURI):
1105         (testWebKitFrameJavaScriptContext):
1106         (testWebKitFrameJavaScriptValues):
1107         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1108         (LoadStopTrackingTest::loadFailed):
1109         (testWebViewTitle):
1110         (testURIRequestHTTPHeaders):
1111         (testURIRequestHTTPMethod):
1112         (testURIResponseHTTPHeaders):
1113         (testRedirectToDataURI):
1114         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1115         (testProcessPerWebView):
1116         (testWebProcessLimit):
1117         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1118         (testWebViewResources):
1119         (testWebResourceLoading):
1120         (testWebResourceSuggestedFilename):
1121         (testWebResourceGetData):
1122         (testWebResourceGetDataError):
1123         (testWebViewResourcesHistoryCache):
1124         (testWebResourceSendRequest):
1125         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1126         (testSSL):
1127         (testInsecureContent):
1128         (testTLSErrorsPolicy):
1129         (testTLSErrorsRedirect):
1130         (testTLSErrorsHTTPAuth):
1131         (testLoadFailedWithTLSErrors):
1132         (testSubresourceLoadFailedWithTLSErrors):
1133         (httpsServerCallback):
1134         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1135         (testWebViewCreateNavigationData):
1136         (testWebViewJavaScriptDialogs):
1137         (testWebViewWindowProperties):
1138         (testWebViewMouseTarget):
1139         (testWebViewFileChooserRequest):
1140         (testWebViewColorChooserRequest):
1141         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1142         (testWebExtensionGetTitle):
1143         (testDocumentLoadedSignal):
1144         (testWebKitWebViewProcessCrashed):
1145         (testWebExtensionWindowObjectCleared):
1146         (testWebExtensionIsolatedWorld):
1147         (permissionRequestCallback):
1148         (didAssociateFormControlsCallback):
1149         (testWebExtensionFormControlsAssociated):
1150         (FormSubmissionTest::FormSubmissionTest):
1151         (FormSubmissionTest::testFormSubmissionResult):
1152         (testWebExtensionFormSubmissionSteps):
1153         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1154         (testNotInitialized):
1155         (testClearDatabase):
1156         (testPrivateBrowsing):
1157         (testGetFavicon):
1158         (testWebViewFavicon):
1159         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
1160         (testFindControllerTextFound):
1161         (testFindControllerTextNotFound):
1162         (testFindControllerMatchCount):
1163         (testFindControllerMaxMatchCount):
1164         (testFindControllerNext):
1165         (testFindControllerPrevious):
1166         (testFindControllerCountedMatches):
1167         (testFindControllerOptions):
1168         (testFindControllerHide):
1169         (testFindControllerInstance):
1170         (testFindControllerGetters):
1171         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
1172         (testNavigationPolicy):
1173         (testResponsePolicy):
1174         (testNewWindowPolicy):
1175         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
1176         (testSecurityOriginBasicConstructor):
1177         (testSecurityOriginURIConstructor):
1178         (testSecurityOriginDefaultPort):
1179         (testSecurityOriginFileURI):
1180         (testOpaqueSecurityOrigin):
1181         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1182         (testWebKitSettings):
1183         (testWebKitSettingsNewWithSettings):
1184         (testWebKitSettingsUserAgent):
1185         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1186         (testWebViewNewWithUserContentManager):
1187         (isStyleSheetInjectedForURLAtPath):
1188         (isScriptInjectedForURLAtPath):
1189         (testUserContentManagerInjectedStyleSheet):
1190         (testUserContentManagerInjectedScript):
1191         (UserScriptMessageTest::scriptMessageReceived):
1192         (UserScriptMessageTest::waitUntilMessageReceived):
1193         (UserScriptMessageTest::runJavaScriptFinished):
1194         (testUserContentManagerScriptMessageReceived):
1195         (testUserContentManagerScriptMessageInWorldReceived):
1196         (testUserContentManagerScriptMessageFromDOMBindings):
1197         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1198         (testWebContextDefault):
1199         (testWebContextEphemeral):
1200         (testWebContextGetPlugins):
1201         (testWebContextURIScheme):
1202         (testWebContextSpellChecker):
1203         (testWebContextLanguages):
1204         (consoleMessageReceivedCallback):
1205         (testWebContextSecurityFileXHR):
1206         (ProxyTest::ProxyTest):
1207         (testWebContextProxySettings):
1208         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1209         (testWebViewWebContext):
1210         (testWebViewWebBackend):
1211         (testWebViewEphemeral):
1212         (testWebViewCustomCharset):
1213         (testWebViewSettings):
1214         (testWebViewRunJavaScript):
1215         (testWebViewCanShowMIMEType):
1216         (testWebViewSubmitForm):
1217         (testWebViewSave):
1218         (testWebViewPageVisibility):
1219         (testWebViewSnapshot):
1220         (testWebViewNotification):
1221         (testWebViewNotificationInitialPermissionAllowed):
1222         (testWebViewNotificationInitialPermissionDisallowed):
1223         (testWebViewIsPlayingAudio):
1224         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1225         (WebsiteDataTest::WebsiteDataTest):
1226         (WebsiteDataTest::remove):
1227         (WebsiteDataTest::clear):
1228         (testWebsiteDataConfiguration):
1229         (testWebsiteDataEphemeral):
1230         (testWebsiteDataCache):
1231         (testWebsiteDataStorage):
1232         (testWebsiteDataDatabases):
1233         (testWebsiteDataAppcache):
1234         (testWebsiteDataCookies):
1235         (testWebsiteDataDeviceIdHashSalt):
1236         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1237         (emitDocumentLoaded):
1238         (emitURIChanged):
1239         (sendRequestCallback):
1240         (contextMenuCallback):
1241         (consoleMessageSentCallback):
1242         (emitFormControlsAssociated):
1243         (formControlsAssociatedCallback):
1244         (emitFormSubmissionEvent):
1245         (willSubmitFormCallback):
1246         (windowObjectCleared):
1247         (methodCallCallback):
1248         (registerGResource):
1249         (webkit_web_extension_initialize_with_user_data):
1250         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
1251         (checkLeaks):
1252         (WebProcessTest::create):
1253         (runTest):
1254         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
1255         (AutocleanupsTest::testWebProcessAutocleanups):
1256         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
1257         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
1258         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
1259         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
1260         (WebKitDOMDOMWindowTest::testSignals):
1261         (WebKitDOMDOMWindowTest::testDispatchEvent):
1262         (WebKitDOMDOMWindowTest::testGetComputedStyle):
1263         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
1264         (WebKitDOMNodeFilterTest::testTreeWalker):
1265         (WebKitDOMNodeFilterTest::testNodeIterator):
1266         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
1267         (WebKitDOMNodeTest::testHierarchyNavigation):
1268         (WebKitDOMNodeTest::testInsertion):
1269         (WebKitDOMNodeTest::testTagNamesNodeList):
1270         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1271         (WebKitDOMNodeTest::testDOMCache):
1272         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
1273         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1274         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1275         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1276         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
1277         (testUIProcessAutocleanups):
1278         (testWebProcessAutocleanups):
1279         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1280         (testContextMenuPopulateMenu):
1281         (testContextMenuDismissed):
1282         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
1283         (testWebKitDOMClientRectDivBoundingClientRectPosition):
1284         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
1285         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
1286         (testWebKitDOMDOMWindowSignals):
1287         (testWebKitDOMDOMWindowDispatchEvent):
1288         (testWebKitDOMDOMWindowGetComputedStyle):
1289         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
1290         (testWebKitDOMNodeHierarchyNavigation):
1291         (testWebKitDOMNodeInsertion):
1292         (testWebKitDOMNodeTagNamesNodeList):
1293         (testWebKitDOMNodeTagNamesHTMLCollection):
1294         (testWebKitDOMObjectCache):
1295         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
1296         (testWebKitDOMNodeFilterTreeWalker):
1297         (testWebKitDOMNodeFilterNodeIterator):
1298         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
1299         (testWebKitDOMXPathNSResolverNative):
1300         (testWebKitDOMXPathNSResolverCustom):
1301         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
1302         (testInspectorDefault):
1303         (testInspectorManualAttachDetach):
1304         (testInspectorCustomContainerDestroyed):
1305         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
1306         (startTestServer):
1307         (testInspectorServerPageList):
1308         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
1309         (OptionMenuTest::showOptionMenuCallback):
1310         (OptionMenuTest::menuCloseCallback):
1311         (OptionMenuTest::close):
1312         (OptionMenuTest::activateItem):
1313         (OptionMenuTest::selectItem):
1314         (testOptionMenuSimple):
1315         (testOptionMenuGroups):
1316         (testOptionMenuActivate):
1317         (testOptionMenuSelect):
1318         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
1319         (testPrintOperationPrintSettings):
1320         (webViewPrintCallback):
1321         (testPrintOperationPrint):
1322         (testPrintCustomWidget):
1323         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1324         (checkAtspiAccessible):
1325         (testAtspiBasicHierarchy):
1326         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
1327         (testWebKitCheckVersion):
1328         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
1329         (testWebViewEditorCutCopyPasteNonEditable):
1330         (testWebViewEditorCutCopyPasteEditable):
1331         (testWebViewEditorSelectAllNonEditable):
1332         (testWebViewEditorSelectAllEditable):
1333         (loadContentsAndTryToCutSelection):
1334         (testWebViewEditorNonEditable):
1335         (testWebViewEditorEditable):
1336         (testWebViewEditorEditorStateTypingAttributes):
1337         (testWebViewEditorInsertImage):
1338         (testWebViewEditorCreateLink):
1339         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1340         (loadChangedCallback):
1341         (loadFailedCallback):
1342         (loadFailedWithTLSErrorsCallback):
1343         (LoadTrackingTest::LoadTrackingTest):
1344         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1345         (registerGResource):
1346         (removeNonEmptyDirectory):
1347         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1348         (Test::adoptView):
1349         (Test::~Test):
1350         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1351         (WebKitTestBus::getOrCreateConnection):
1352         (WebKitTestBus::createProxy):
1353         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1354         (WebKitTestServer::getWebSocketURIForPath const):
1355         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1356         (WebViewTest::initializeWebView):
1357         (WebViewTest::loadURI):
1358         (WebViewTest::loadHtml):
1359         (WebViewTest::loadPlainText):
1360         (WebViewTest::loadBytes):
1361         (WebViewTest::loadRequest):
1362         (WebViewTest::loadAlternateHTML):
1363         (WebViewTest::goBack):
1364         (WebViewTest::goForward):
1365         (WebViewTest::goToBackForwardListItem):
1366         (resourceGetDataCallback):
1367         (WebViewTest::mainResourceData):
1368         (WebViewTest::javascriptResultToCString):
1369         (WebViewTest::javascriptResultToNumber):
1370         (WebViewTest::javascriptResultToBoolean):
1371         (WebViewTest::javascriptResultIsNull):
1372         (WebViewTest::javascriptResultIsUndefined):
1373         (onSnapshotReady):
1374         (WebViewTest::runWebProcessTest):
1375         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
1376         (WebViewTest::platformInitializeWebView):
1377         (WebViewTest::showInWindow):
1378         (WebViewTest::showInWindowAndWaitUntilMapped):
1379         (WebViewTest::mouseMoveTo):
1380         (WebViewTest::emitPopupMenuSignal):
1381         (WebViewTest::keyStroke):
1382         (WebViewTest::doMouseButtonEvent):
1383
1384 2019-01-09  Philippe Normand  <pnormand@igalia.com>
1385
1386         [WPE] API tests can't run in flatpak environment
1387         https://bugs.webkit.org/show_bug.cgi?id=193242
1388
1389         Reviewed by Michael Catanzaro.
1390
1391         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
1392         flatpakutils so that it knows which port it's dealing with.
1393         * glib/common.py: Remove build_dir globals so that subsequent
1394         calls actually take args into account.
1395         (library_build_path):
1396         (binary_build_path):
1397
1398 2019-01-08  Dean Jackson  <dino@apple.com>
1399
1400         Blob references for System Previews don't get a correct file extension
1401         https://bugs.webkit.org/show_bug.cgi?id=193268
1402         <rdar://problem/47133037>
1403
1404         Reviewed by Tim Horton.
1405
1406         New test that a Blob download of a USDZ file gets named correctly.
1407
1408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1409         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1410         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1411         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
1412         (TEST):
1413         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
1414
1415 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
1416
1417         [WebAuthN] Support U2F HID Authenticators on macOS
1418         https://bugs.webkit.org/show_bug.cgi?id=191535
1419         <rdar://problem/47102027>
1420
1421         Reviewed by Brent Fulgham.
1422
1423         This patch:
1424         1) adds support for U2F mocking mechanism;
1425         2) updates tests to reflect U2fCommandConstructor changes.
1426
1427         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
1428         (TestWebKitAPI::TEST):
1429         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1430         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1431         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1432
1433 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1434
1435         [iOS] Dispatch a synthetic mousedown event prior to starting drags
1436         https://bugs.webkit.org/show_bug.cgi?id=193229
1437         <rdar://problem/46717097>
1438
1439         Reviewed by Tim Horton.
1440
1441         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
1442         prevents a drag from starting.
1443
1444         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1445         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
1446
1447         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
1448
1449 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
1450   
1451         Layout test will generate a perf metric file to results dir.
1452         https://bugs.webkit.org/show_bug.cgi?id=192030
1453         <rdar://problem/32779516>
1454
1455         Reviewed by Aakash Jain.
1456
1457         Layout test running time will be collected to a perf metric file.
1458         For now, instead of outputing running time of all tests (which is huge),
1459         we aggregate them by test directories which are at most two level deep. 
1460
1461         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1462         (Manager._end_test_run):
1463         (Manager._output_perf_metrics):
1464         (Manager._print_expectation_line_for_test):
1465         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1466         (add_test_perf_metric):
1467         (test_perf_metrics):
1468         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1469         (JSONGeneratorTest.test_test_timings_trie):
1470         (JSONGeneratorTest):
1471         (JSONGeneratorTest.test_test_perf_metrics):
1472         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1473         (RebaselineTest.test_reset_results):
1474         (RebaselineTest.test_missing_results):
1475         (RebaselineTest.test_new_baseline):
1476
1477 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
1478
1479         [WPE][GTK] Add php-json to install-dependencies
1480         https://bugs.webkit.org/show_bug.cgi?id=193233
1481
1482         Reviewed by Michael Catanzaro.
1483
1484         * gtk/install-dependencies:
1485         * wpe/install-dependencies:
1486
1487 2019-01-08  Chris Dumez  <cdumez@apple.com>
1488
1489         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
1490         https://bugs.webkit.org/show_bug.cgi?id=193224
1491         <rdar://problem/47097726>
1492
1493         Reviewed by Alex Christensen.
1494
1495         Add API test coverage.
1496
1497         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1498
1499 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1500
1501         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
1502         <https://webkit.org/b/193222>
1503         <rdar://problem/46862309>
1504
1505         Reviewed by Joseph Pecoraro.
1506
1507         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1508         (WTR::executeCallback): Fix camel case of variable name.
1509         (WTR::EventSendingController::callAfterScrollingCompletes): If
1510         WKBundlePageRegisterScrollOperationCompletionCallback() returns
1511         false, make sure to release the ScrollCompletionCallbackData
1512         object.  This fixes the leak.
1513
1514 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1515
1516         [Win] EWS: wincairo-ews cannot apply a patch with *.png
1517         https://bugs.webkit.org/show_bug.cgi?id=193044
1518
1519         Reviewed by Daniel Bates.
1520
1521         WinCairo EWS bots are using Windows Perl. Binary files should be
1522         opened as binary mode.
1523
1524         * Scripts/svn-apply:
1525         (handleGitBinaryChange): Use 'binmode' for binary file handles.
1526
1527 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
1528
1529         [CMake] Add ENABLE_CSS_TYPED_OM option
1530         https://bugs.webkit.org/show_bug.cgi?id=193216
1531
1532         Reviewed by Michael Catanzaro.
1533
1534         * Scripts/webkitperl/FeatureList.pm:
1535
1536 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1537
1538         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1539         <https://webkit.org/b/193056>
1540
1541         Reviewed by Alex Christensen.
1542
1543         * Scripts/webkitpy/style/checker.py:
1544         - Ignore use of new runtime/retainptr check in
1545           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
1546           contains tests to ensure RetainPtr<NSObject *> is compatible
1547           with RetainPtr<NSObject>.
1548
1549         * Scripts/webkitpy/style/checkers/cpp.py:
1550         (check_language):
1551         (CppChecker):
1552         - Add checker for use of '*' in RetainPtr<> type.  A for loop
1553           was used instead of a single regex so that angle brackets
1554           could be matched up when checking the type contained within
1555           the RetainPtr<> type.
1556
1557         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1558         (CppStyleTest):
1559         - Add unit test for new runtime/retainptr check.
1560
1561         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
1562         * TestWebKitAPI/EditingTestHarness.h:
1563         - Remove '*' from RetainPtr<> type.
1564
1565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1566         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
1567           regressed in r201938.
1568
1569         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1570         (TestWebKitAPI::TEST):
1571         - Update tests to match RetainPtr.mm tests (except for the
1572           `*SimilarNSType` tests since there is no CF equivalent of
1573           RetainPtr<NSString> and RetainPtr<NSString *>).
1574
1575         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1576         (TestWebKitAPI::TEST):
1577         - Update tests to:
1578           - Not conflict by name with equivalent CF tests in
1579             RetainPtr.cpp.
1580           - Add test cases for RetainPtr<NSObject>,
1581             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
1582           - Add `*SimilarNSType` tests for converting between
1583             RetainPtr<NSObject> and RetainPtr<NSObject *>.
1584           - Change `0` to `nil` as appropriate.
1585           - Re-alphabetize the tests by name.
1586           - Add Optional<RetainPtr<>> tests.
1587           - Add retainPtr() tests.
1588
1589         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1590         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1591         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
1592         (TEST):
1593         - Remove '*' from RetainPtr<> type.
1594
1595         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
1596         (TEST(WebKit, JITEnabled)):
1597         - Add missing WTFMove().  Apparently a temporary was being
1598           created before in the argument list due to mismatched
1599           RetainPtr<> types.
1600
1601         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1602         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
1603         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
1604         (TestWebKitAPI::TEST):
1605         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1606         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1607         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1608         (WTR::resourcesDirectoryURL):
1609         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1610         (WTR::InjectedBundle::platformInitialize):
1611         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1612         - Remove '*' from RetainPtr<> type.
1613
1614 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
1615
1616         A MediaTime timescale must never be zero
1617         https://bugs.webkit.org/show_bug.cgi?id=193156
1618         <rdar://problem/32504501>
1619
1620         Reviewed by Jer Noble.
1621
1622         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1623         (TestWebKitAPI::TEST): Add tests for zero timescale.
1624
1625 2019-01-07  Youenn Fablet  <youenn@apple.com>
1626
1627         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
1628         https://bugs.webkit.org/show_bug.cgi?id=193175
1629
1630         Reviewed by Chris Dumez.
1631
1632         Updated API test as we bumped the SW schema to version 4.
1633
1634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1635         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
1636         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1637         (TEST):
1638
1639 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1640
1641         [Win][Clang] Fix compilation warnings of MiniBrowser
1642         https://bugs.webkit.org/show_bug.cgi?id=193029
1643
1644         Reviewed by Ross Kirsling.
1645
1646         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
1647         and m_URLBarFont. Reorder member variables to fix -Wreorder
1648         warning.
1649         * MiniBrowser/win/PageLoadTestClient.cpp:
1650         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
1651         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
1652         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
1653         m_currentURLIndex.
1654         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1655         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
1656         navigationClient with '{ }' to fix the missing field warning.
1657         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1658         (initDocStruct): Changed the argument type docname to const.
1659
1660 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
1661
1662         [WebAuthN] Import U2F command/response converters from Chromium
1663         https://bugs.webkit.org/show_bug.cgi?id=193150
1664         <rdar://problem/47054028>
1665
1666         Reviewed by Brent Fulgham.
1667
1668         Adds API tests.
1669
1670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1671         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
1672         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
1673         (TestWebKitAPI::getTestAuthenticatorDataBytes):
1674         (TestWebKitAPI::getTestAttestationObjectBytes):
1675         (TestWebKitAPI::getTestSignResponse):
1676         (TestWebKitAPI::getTestU2fRegisterResponse):
1677         (TestWebKitAPI::TEST):
1678         (TestWebKitAPI::convertToVector): Deleted.
1679         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1680         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
1681         (TestWebKitAPI::constructMakeCredentialRequest):
1682         (TestWebKitAPI::constructGetAssertionRequest):
1683         (TestWebKitAPI::TEST):
1684
1685 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
1686
1687         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
1688         https://bugs.webkit.org/show_bug.cgi?id=193136
1689
1690         Reviewed by Michael Catanzaro.
1691
1692         * gtk/install-dependencies:
1693         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
1694         they are needed by update-webkitgtk-libs.
1695
1696 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
1697
1698         Unreviewed follow-up fix to r239650
1699         https://bugs.webkit.org/show_bug.cgi?id=193140
1700         <rdar://problem/47063037>
1701
1702         Typecast patch_id to string.
1703
1704         * BuildSlaveSupport/ews-build/steps.py:
1705         (ValidatePatch._is_patch_obsolete):
1706
1707 2019-01-04  Daniel Bates  <dabates@apple.com>
1708
1709         [lldb-webkit]: Add support for pretty-printing raw bitmask types
1710         https://bugs.webkit.org/show_bug.cgi?id=193024
1711
1712         Reviewed by Jer Noble.
1713
1714         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
1715         for the bitmask type WebEventFlags as an example.
1716
1717         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
1718         that can be used to register summary and synthetic child formatters for a bitmask type.
1719         For example, consider the following enum and bitmask typedefs:
1720
1721         typedef enum {
1722             A = 1 << 0,
1723             B = 1 << 1,
1724             C = 1 << 2,
1725         } SpecialFlagValues;
1726         typedef unsigned SpecialFlags;
1727
1728         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
1729         __lldb_init_module():
1730
1731             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
1732                     1 << 0: "A",
1733                     1 << 1: "B",
1734                     1 << 2: "C",
1735             })
1736
1737         * lldb/lldb_webkit.py:
1738         (addSummaryAndSyntheticFormattersForRawBitmaskType):
1739         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
1740         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
1741         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
1742         A convenience function to dynamically creaste a synthetic formatter class and summary
1743         string function for the specified bitmask type and enumerator value to name map. This
1744         function register the dynamically created class and function with LLDB.
1745
1746         (__lldb_init_module):
1747         (FlagEnumerationProvider):
1748         (FlagEnumerationProvider._enumerator_value_to_name_map):
1749         (FlagEnumerationProvider._bitmask):
1750         (FlagEnumerationProvider._update):
1751         (FlagEnumerationProvider.has_children):
1752         (FlagEnumerationProvider.num_children):
1753         (FlagEnumerationProvider.get_child_index):
1754         (FlagEnumerationProvider.get_child_at_index):
1755         (FlagEnumerationProvider.update):
1756         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
1757
1758         (WTFOptionSetProvider):
1759         (WTFOptionSetProvider._enumerator_value_to_name_map):
1760         (WTFOptionSetProvider._bitmask):
1761         (WTFOptionSetProvider._update):
1762         Write in terms of the base class.
1763
1764         (RawBitmaskProviderBase):
1765         (RawBitmaskProviderBase._enumerator_value_to_name_map):
1766         (RawBitmaskProviderBase._bitmask):
1767         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
1768         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
1769         {
1770             1 << 0: "A",
1771             1 << 1: "B",
1772             1 << 2: "C",
1773         }
1774         It is not necessary to instantiate such a derived class directory. Instead use the convenience
1775         function addSummaryAndSyntheticFormattersForRawBitmaskType.
1776
1777         (WTFOptionSetProvider.has_children): Deleted.
1778         (WTFOptionSetProvider.num_children): Deleted.
1779         (WTFOptionSetProvider.get_child_index): Deleted.
1780         (WTFOptionSetProvider.get_child_at_index): Deleted.
1781         (WTFOptionSetProvider.update): Deleted.
1782
1783 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
1784
1785         [ews-build] Add build step to validate the patch before processing it
1786         https://bugs.webkit.org/show_bug.cgi?id=193140
1787
1788         Reviewed by Lucas Forschler.
1789
1790         * BuildSlaveSupport/ews-build/factories.py:
1791         (Factory.__init__): Added ValidatePatch step.
1792         * BuildSlaveSupport/ews-build/steps.py:
1793         (ValidatePatch):
1794         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
1795         (ValidatePatch.get_patch_json): Get patch json data.
1796         (ValidatePatch.get_bug_json): Get bug json data.
1797         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
1798         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
1799         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
1800         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
1801         (ValidatePatch.skip_build): Skip the build.
1802         (ValidatePatch.start):
1803
1804 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1805
1806         Progress towards fixing Mac CMake build
1807         https://bugs.webkit.org/show_bug.cgi?id=193105
1808
1809         Reviewed by Don Olmstead.
1810
1811         * TestWebKitAPI/PlatformMac.cmake:
1812
1813 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1814
1815         Fix API test after r239631
1816         https://bugs.webkit.org/show_bug.cgi?id=193118
1817
1818         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1819         (TestWebKitAPI::TEST):
1820         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
1821         Do the same thing via the API to fix the test.
1822
1823 2019-01-04  Jer Noble  <jer.noble@apple.com>
1824
1825         [WebKitLegacy] Media playback pauses on scroll
1826         https://bugs.webkit.org/show_bug.cgi?id=192829
1827
1828         Reviewed by Eric Carlson.
1829
1830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1831         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
1832         (TestWebKitAPI::TEST):
1833         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
1834         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
1835         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
1836         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
1837         (TestWebKitAPI::TEST):
1838
1839 2019-01-04  Chris Dumez  <cdumez@apple.com>
1840
1841         Add support for toggling device orientation API support per site
1842         https://bugs.webkit.org/show_bug.cgi?id=193143
1843         <rdar://problem/46605724>
1844
1845         Reviewed by Alex Christensen.
1846
1847         Add API test coverage.
1848
1849         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1850         (-[DataMappingSchemeHandler setTaskHandler:]):
1851         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
1852         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
1853         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1854         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
1855
1856 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
1857
1858         [ews-build] use svn-apply script to apply the patches
1859         https://bugs.webkit.org/show_bug.cgi?id=193138
1860
1861         Reviewed by Lucas Forschler.
1862
1863         * BuildSlaveSupport/ews-build/factories.py:
1864         (Factory.__init__): Add the ApplyPatch step.
1865         * BuildSlaveSupport/ews-build/steps.py:
1866         (CheckOutSource): Added step name.
1867         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
1868         (ApplyPatch): Build step to apply patch using svn-apply script.
1869         (UnApplyPatchIfRequired):
1870         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
1871
1872 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1873
1874         Deprecate WKContextCreate
1875         https://bugs.webkit.org/show_bug.cgi?id=193118
1876
1877         Reviewed by Brady Eidson.
1878
1879         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1880         (WebKitBrowserWindow::WebKitBrowserWindow):
1881         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
1882         (TestWebKitAPI::TEST):
1883         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1884         (TestWebKitAPI::TEST):
1885         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1886         (TestWebKitAPI::TEST):
1887         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
1888         (TestWebKitAPI::TEST):
1889         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
1890         (TestWebKitAPI::TEST):
1891         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1892         (TestWebKitAPI::TEST):
1893         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1894         (TestWebKitAPI::TEST):
1895         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1896         (TestWebKitAPI::TEST):
1897         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1898         (TestWebKitAPI::TEST):
1899         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1900         (TestWebKitAPI::TEST):
1901         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1902         (TestWebKitAPI::TEST):
1903         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1904         (TestWebKitAPI::TEST):
1905         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1906         (TestWebKitAPI::TEST):
1907         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1908         (TestWebKitAPI::TEST):
1909         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1910         (TestWebKitAPI::TEST):
1911         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1912         (TestWebKitAPI::TEST):
1913         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1914         (TestWebKitAPI::TEST):
1915         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1916         (TestWebKitAPI::TEST):
1917         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1918         (TestWebKitAPI::loadAlternateHTMLString):
1919         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1920         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1921         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1922         (TestWebKitAPI::buildAndPerformTest):
1923         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1924         (TestWebKitAPI::TEST):
1925         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
1926         (TestWebKitAPI::TEST):
1927         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
1928         (TestWebKitAPI::TEST):
1929         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1930         (TestWebKitAPI::TEST):
1931         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1932         (TestWebKitAPI::TEST):
1933         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1934         (TestWebKitAPI::TEST):
1935         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1936         (TestWebKitAPI::TEST):
1937         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1938         (TestWebKitAPI::TEST):
1939         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1940         (TestWebKitAPI::TEST):
1941         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1942         (TestWebKitAPI::TEST):
1943         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1944         (TestWebKitAPI::TEST):
1945         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1946         (TestWebKitAPI::TEST):
1947         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1948         (TestWebKitAPI::TEST):
1949         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1950         (TestWebKitAPI::TEST):
1951         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1952         (TestWebKitAPI::TEST):
1953         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1954         (TestWebKitAPI::TEST):
1955         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1956         (TestWebKitAPI::TEST):
1957         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1958         (TestWebKitAPI::TEST):
1959         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
1960         (TestWebKitAPI::TEST):
1961         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1962         (TestWebKitAPI::TEST):
1963         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1964         (TestWebKitAPI::TEST):
1965         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1966         (TestWebKitAPI::TEST):
1967         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1968         (TestWebKitAPI::TEST):
1969         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
1970         (TestWebKitAPI::TEST):
1971         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1972         (TestWebKitAPI::TEST):
1973         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1974         (TestWebKitAPI::TEST):
1975         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1976         (WebKit2_CommandBackForwardTestWKView::SetUp):
1977         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1978         (TestWebKitAPI::TEST):
1979         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1980         (TestWebKitAPI::TEST):
1981         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
1982         (TestWebKitAPI::TEST):
1983         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1984         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1985
1986 2019-01-03  Matt Rajca  <mrajca@apple.com>
1987
1988         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
1989         https://bugs.webkit.org/show_bug.cgi?id=193128
1990         rdar://34554231
1991
1992         Reviewed by Jer Noble.
1993
1994         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
1995         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
1996         event along with a flag that indicates whether or not autoplay was actually prevented.
1997
1998         Tests: existing API tests were updated to reflect the new names. New API tests
1999         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
2000
2001         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2002         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
2003         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2004         (TEST):
2005         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
2006         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
2007
2008 2019-01-04  Chris Dumez  <cdumez@apple.com>
2009
2010         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
2011         https://bugs.webkit.org/show_bug.cgi?id=193120
2012
2013         Reviewed by Alex Christensen.
2014
2015         Add API test coverage.
2016
2017         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2018
2019 2019-01-04  Chris Dumez  <cdumez@apple.com>
2020
2021         Crash under WebProcessPool::addSuspendedPage()
2022         https://bugs.webkit.org/show_bug.cgi?id=193110
2023
2024         Reviewed by Youenn Fablet.
2025
2026         Add API test coverage.
2027
2028         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2029
2030 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2031
2032         [ews-build] Check patch relevance before applying the patch
2033         https://bugs.webkit.org/show_bug.cgi?id=193102
2034
2035         Reviewed by Lucas Forschler.
2036
2037         * BuildSlaveSupport/ews-build/factories.py:
2038         (Factory.__init__): Moved CheckPatchRelevance step to base class.
2039
2040 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2041
2042         [ews-build] Check patch relevance step should print patch id
2043         https://bugs.webkit.org/show_bug.cgi?id=193137
2044
2045         Reviewed by Lucas Forschler.
2046
2047         * BuildSlaveSupport/ews-build/steps.py:
2048         (CheckPatchRelevance.start): Update the status to include patch id.
2049
2050 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
2051
2052         webkitpy: Increase simulator teardown timeout
2053         https://bugs.webkit.org/show_bug.cgi?id=193141
2054         <rdar://problem/46174217>
2055
2056         Rubber-stamped by Aakash Jain.
2057
2058         * Scripts/webkitpy/xcode/simulated_device.py:
2059         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
2060
2061 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
2062
2063         test262-runner misbehaves when test file YAML has a trailing space
2064         https://bugs.webkit.org/show_bug.cgi?id=193053
2065
2066         Reviewed by Yusuke Suzuki.
2067
2068         * Scripts/test262/Runner.pm:
2069         (parseData):
2070         Accept trailing space when parsing a test file's YAML block.
2071
2072 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2073
2074         UserMedia test should use WKPageNavigationClient
2075         https://bugs.webkit.org/show_bug.cgi?id=192913
2076
2077         Reviewed by Youenn Fablet.
2078
2079         The test currently uses the deprecated WKPageLoaderClient. It should use
2080         WKPageNavigationClient instead, which provides the same callback under a similar name.
2081
2082         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2083         (TestWebKitAPI::TEST):
2084
2085 2019-01-02  Alex Christensen  <achristensen@webkit.org>
2086
2087         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
2088         https://bugs.webkit.org/show_bug.cgi?id=192944
2089
2090         Reviewed by Tim Horton.
2091
2092         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2093         (TestWebKitAPI::TEST):
2094
2095 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2096
2097         Add support for using the current text selection as the find string on iOS
2098         https://bugs.webkit.org/show_bug.cgi?id=193034
2099         <rdar://problem/45138739>
2100
2101         Reviewed by Tim Horton.
2102
2103         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
2104         _setStringForFind) works as expected.
2105
2106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2107         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
2108
2109 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
2110
2111         [ews-build] Use git on OpenSource EWS bots
2112         https://bugs.webkit.org/show_bug.cgi?id=193092
2113
2114         Reviewed by Lucas Forschler.
2115
2116         * BuildSlaveSupport/ews-build/steps.py:
2117         (CheckOutSource): Use git instead of svn.
2118         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
2119
2120 2019-01-02  Daniel Bates  <dabates@apple.com>
2121
2122         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
2123         https://bugs.webkit.org/show_bug.cgi?id=193023
2124
2125         Reviewed by Simon Fraser.
2126
2127         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
2128         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
2129         enumerator values. We should just remove this code.
2130
2131         * lldb/lldb_webkit.py:
2132         (WTFOptionSetProvider.has_children):
2133         (WTFOptionSetProvider.num_children):
2134         (WTFOptionSetProvider.get_child_index):
2135         (WTFOptionSetProvider.get_child_at_index):
2136
2137 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2138
2139         .ycm_extra_conf.py should handle XXXInlines.h
2140         https://bugs.webkit.org/show_bug.cgi?id=193055
2141
2142         Reviewed by Carlos Garcia Campos.
2143
2144         compile_commands.json database only records flags and options for cpp source files.
2145         So, when we open headers, this database does not have any information for that.
2146         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
2147         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
2148         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
2149         we attempt to find XXX.cpp and use the configuration if it exists.
2150
2151         * gtk/ycm_extra_conf.py:
2152         (getImplementationFilename):
2153         (FlagsForFile):
2154
2155 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2156
2157         Unreviewed. Support PHP 7.3 in Debian.
2158
2159         Add 7.3 to the list of php versions supported in Debian.
2160
2161         * Scripts/webkitpy/port/base.py:
2162         (Port._debian_php_version):
2163
2164 2018-12-27  Alex Christensen  <achristensen@webkit.org>
2165
2166         Resurrect Mac CMake build
2167         https://bugs.webkit.org/show_bug.cgi?id=192658
2168
2169         Reviewed by Yusuke Suzuki.
2170
2171         * DumpRenderTree/PlatformMac.cmake:
2172         * MiniBrowser/mac/CMakeLists.txt:
2173         * TestWebKitAPI/PlatformMac.cmake:
2174
2175 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
2176
2177         [Tools] Remove references to Bison and Flex
2178         https://bugs.webkit.org/show_bug.cgi?id=193033
2179
2180         Reviewed by Michael Catanzaro.
2181
2182         The Bison and Flex tools are not needed anymore since r209883.
2183
2184         * CygwinDownloader/cygwin-downloader.py:
2185         * EWSTools/ubuntu-ews-packages:
2186         * Scripts/filter-build-webkit:
2187         (shouldIgnoreLine):
2188         * gtk/install-dependencies:
2189         * wpe/install-dependencies:
2190
2191 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2192
2193         WebDriver: warn about non existing tests when parsing expectations
2194         https://bugs.webkit.org/show_bug.cgi?id=192979
2195
2196         Reviewed by Michael Catanzaro.
2197
2198         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
2199         renamed.
2200
2201         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2202         (WebDriverTestRunner.__init__):
2203
2204 2018-12-21  Chris Dumez  <cdumez@apple.com>
2205
2206         navigator.userAgent in service workers does not reflect customUserAgent set by client
2207         https://bugs.webkit.org/show_bug.cgi?id=192951
2208
2209         Reviewed by Youenn Fablet.
2210
2211         Extend API test coverage.
2212
2213         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2214         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
2215         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2216         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
2217         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2218
2219 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2220
2221         [WebAuthN] userPresence should always be true
2222         https://bugs.webkit.org/show_bug.cgi?id=192835
2223         <rdar://problem/46538788>
2224
2225         Reviewed by Brent Fulgham.
2226
2227         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2228         (TestWebKitAPI::TEST):
2229
2230 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
2231
2232         Add support to run-benchmark to use non-default copies of the browser apps
2233         https://bugs.webkit.org/show_bug.cgi?id=192905
2234         rdar://problem/46845840
2235
2236         Reviewed by Dewei Zhu.
2237         
2238         Add support for a --browser-path argument to run-benchmark, which allows you to use
2239         a custom app bundle for a given browser (only implemented for Safari at present).
2240
2241         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2242         (BenchmarkRunner.__init__):
2243         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2244         (BrowserDriver.__init__):
2245         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2246         (BrowserDriverFactory.create):
2247         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2248         (OSXBrowserDriver._launch_process):
2249         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
2250         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
2251         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2252         (OSXChromeCanaryDriver.launch_url):
2253         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2254         (OSXFirefoxNightlyDriver.launch_url):
2255         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2256         (OSXSafariDriver.__init__):
2257         (OSXSafariDriver.launch_url):
2258         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2259         (parse_args):
2260         (run_benchmark_plan):
2261         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2262         (WebServerBenchmarkRunner.__init__):
2263         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
2264         (FakeBenchmarkRunner.__init__):
2265
2266 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2267
2268         [WebAuthN] Import an APDU coder from Chromium
2269         https://bugs.webkit.org/show_bug.cgi?id=192949
2270         <rdar://problem/46879933>
2271
2272         Reviewed by Brent Fulgham.
2273
2274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2275         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
2276         (TestWebKitAPI::TEST):
2277
2278 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2279
2280         Setting the file wrapper and content type of an attachment to a PDF should update its image
2281         https://bugs.webkit.org/show_bug.cgi?id=192984
2282         <rdar://problem/46798028>
2283
2284         Reviewed by Tim Horton.
2285
2286         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
2287         PDF data correctly updates the image element.
2288
2289         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2290
2291 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2292
2293         Add JSCOnly to bot dashboard
2294         https://bugs.webkit.org/show_bug.cgi?id=192964
2295
2296         Reviewed by Alexey Proskuryakov.
2297
2298         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
2299         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
2300         useful if they were not so secret, so add them.
2301
2302         There appear to be no build-only bots, so the first column is blank. And of course there are
2303         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
2304         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
2305         and there's plenty of room in the final column for all the bots.
2306
2307         I had a hard time picking a logo to use, because the JavaScript language does not have an
2308         official logo. But I believe I've found one that will be satisfactory.
2309
2310         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
2311
2312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
2313         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
2314         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2315         (BubbleQueueServer):
2316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2317         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2318         (WebKitBuildbot):
2319         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2320         (table.queue-grid tr.platform.linux-jsconly img.logo):
2321
2322 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
2323
2324         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
2325         https://bugs.webkit.org/show_bug.cgi?id=192821
2326
2327         Reviewed by Chris Dumez.
2328
2329         * DumpRenderTree/mac/DumpRenderTree.mm:
2330         (createWebViewAndOffscreenWindow):
2331         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2332
2333 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2334
2335         [Win][Clang] Fix compilation warnings of DumpRenderTree
2336         https://bugs.webkit.org/show_bug.cgi?id=192924
2337
2338         Reviewed by Alex Christensen.
2339
2340         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
2341         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2342         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
2343         * DumpRenderTree/win/DumpRenderTree.cpp:
2344         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
2345         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
2346         object to the argument of setDefaultTextEncodingName instead of a
2347         const string literal.
2348         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
2349         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
2350         (setCacheFolder): Deleted.
2351         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
2352         * DumpRenderTree/win/EditingDelegate.cpp:
2353         (dump): Use %d for int.
2354         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
2355         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2356         (BSTRFromString): Deleted unused function.
2357         * DumpRenderTree/win/TestRunnerWin.cpp:
2358         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
2359         the arguemnt of setQuota instead of const string literal.
2360         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2361         (jsStringRefToWString): Deleted unused function.
2362
2363 2018-12-20  Chris Dumez  <cdumez@apple.com>
2364
2365         Add API test coverage for customUserAgent client setting and service workers
2366         https://bugs.webkit.org/show_bug.cgi?id=192952
2367
2368         Reviewed by Alex Christensen.
2369
2370         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2371         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
2372         (-[SWSchemes webView:startURLSchemeTask:]):
2373         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2374         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2375
2376 2018-12-20  Chris Dumez  <cdumez@apple.com>
2377
2378         Use Optional::hasValue() instead of Optional::has_value()
2379         https://bugs.webkit.org/show_bug.cgi?id=192948
2380
2381         Reviewed by Tim Horton.
2382
2383         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
2384         (TestWebKitAPI::TEST):
2385         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
2386         (TestWebKitAPI::TEST):
2387         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2388         (TestWebKitAPI::TEST_F):
2389
2390 2018-12-20  Chris Dumez  <cdumez@apple.com>
2391
2392         Add style script rule to check for uses of std::optional<>
2393         https://bugs.webkit.org/show_bug.cgi?id=192931
2394
2395         Reviewed by Tim Horton.
2396
2397         * Scripts/webkitpy/style/checkers/cpp.py:
2398         (check_wtf_optional):
2399         (check_style):
2400
2401 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
2402
2403         [WebAuthN] Add a runtime flag for local authenticator
2404         https://bugs.webkit.org/show_bug.cgi?id=192792
2405         <rdar://problem/46798738>
2406
2407         Reviewed by Brent Fulgham.
2408
2409         * DumpRenderTree/TestOptions.cpp:
2410         (TestOptions::TestOptions):
2411         * DumpRenderTree/TestOptions.h:
2412         * DumpRenderTree/mac/DumpRenderTree.mm:
2413         (enableExperimentalFeatures):
2414         (setWebPreferencesForTestOptions):
2415         * WebKitTestRunner/TestController.cpp:
2416         (WTR::TestController::resetPreferencesToConsistentValues):
2417         (WTR::updateTestOptionsFromTestHeader):
2418         * WebKitTestRunner/TestOptions.h:
2419         (WTR::TestOptions::hasSameInitializationOptions const):
2420
2421 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
2422
2423         webkitpy: Autoinstall package URLs have changed
2424         https://bugs.webkit.org/show_bug.cgi?id=192909
2425         <rdar://problem/46860359>
2426
2427         Rubber-stamped by Alexey Proskuryakov.
2428
2429         PyPi urls have been moved around, we need to update our auto-installed packages.
2430
2431         We should check for Selenium before asking PyPi for the latest version.
2432
2433         * Scripts/webkitpy/thirdparty/__init__.py:
2434         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
2435         (AutoinstallImportHook._install_keyring): Ditto.
2436         (AutoinstallImportHook._install_pep8): Ditto.
2437         (AutoinstallImportHook._install_mozlog): Ditto.
2438         (AutoinstallImportHook._install_mozprocess): Ditto.
2439         (AutoinstallImportHook._install_pytest_timeout): Ditto.
2440         (AutoinstallImportHook._install_pytest): Ditto.
2441         (AutoinstallImportHook._install_pylint): Ditto.
2442         (AutoinstallImportHook._install_buildbot): Ditto.
2443         (AutoinstallImportHook._install_coverage): Ditto.
2444         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
2445         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
2446         for new Selenium if the installed version isn't sufficient.
2447         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
2448
2449 2018-12-20  Chris Dumez  <cdumez@apple.com>
2450
2451         Use Optional::valueOr() instead of Optional::value_or()
2452         https://bugs.webkit.org/show_bug.cgi?id=192933
2453
2454         Reviewed by Geoffrey Garen.
2455
2456         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
2457         (TestWebKitAPI::checkURL):
2458         (TestWebKitAPI::checkRelativeURL):
2459         (TestWebKitAPI::checkURLDifferences):
2460         (TestWebKitAPI::checkRelativeURLDifferences):
2461         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
2462         (TestWebKitAPI::checkURL):
2463
2464 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
2465
2466         Unreviewed, rolling out r239417.
2467
2468         Introduced two API test failures on macOS.
2469
2470         Reverted changeset:
2471
2472         "<rdar://problem/46194315> macOS: WebKit1 does not handle
2473         occlusion changes"
2474         https://bugs.webkit.org/show_bug.cgi?id=192821
2475         https://trac.webkit.org/changeset/239417
2476
2477 2018-12-20  Devin Rousso  <drousso@apple.com>
2478
2479         Web Inspector: UIString should take an optional key and description to aid localization
2480         https://bugs.webkit.org/show_bug.cgi?id=153962
2481         <rdar://problem/24542505>
2482
2483         Reviewed by Brian Burg.
2484
2485         * Scripts/extract-localizable-js-strings:
2486
2487 2018-12-20  Tim Horton  <timothy_horton@apple.com>
2488
2489         Unparented WKWebView can't retrieve main resource data for a main frame plugin
2490         https://bugs.webkit.org/show_bug.cgi?id=192923
2491         <rdar://problem/46859068>
2492
2493         Reviewed by Wenson Hsieh.
2494
2495         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2496         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
2497         Add a test ensuring that both parented and unparented WKWebViews can
2498         retrieve main resource data when loading a PDF.
2499
2500 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2501
2502         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
2503         https://bugs.webkit.org/show_bug.cgi?id=192852
2504
2505         Reviewed by Michael Catanzaro.
2506
2507         EmojiOne font was replaced by Noto Color Emoji.
2508
2509         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
2510         * gtk/jhbuild.modules:
2511         * wpe/jhbuild.modules:
2512
2513 2018-12-19  Chris Dumez  <cdumez@apple.com>
2514
2515         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
2516         https://bugs.webkit.org/show_bug.cgi?id=192728
2517         <rdar://problem/46746779>
2518
2519         Reviewed by Geoff Garen.
2520
2521         * DumpRenderTree/*:
2522         * MiniBrowser/*:
2523         * TestRunnerShared/*:
2524         * TestWebKitAPI/*:
2525         * WebGPUAPIStructure/*:
2526         * WebKitTestRunner/*:
2527
2528 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
2529
2530         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
2531         https://bugs.webkit.org/show_bug.cgi?id=192821
2532
2533         Reviewed by Chris Dumez.
2534
2535         * DumpRenderTree/mac/DumpRenderTree.mm:
2536         (createWebViewAndOffscreenWindow):
2537
2538 2018-12-19  Alex Christensen  <achristensen@webkit.org>
2539
2540         Navigations away from the SafeBrowsing interstitial show a flash of old content
2541         https://bugs.webkit.org/show_bug.cgi?id=192676
2542
2543         Reviewed by Chris Dumez.
2544
2545         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2546         (safeBrowsingView):
2547         (TEST):
2548         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
2549
2550 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
2551
2552         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
2553         https://bugs.webkit.org/show_bug.cgi?id=192855
2554
2555         Reviewed by Michael Catanzaro.
2556
2557         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2558         (WTR::TestController::notifyDone): Use the WPE implementation.
2559         (WTR::TestController::platformRunUntil): Use the WPE implementation.
2560         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
2561         (WTR::TestController::platformRunUntil): Honor the condition flag.
2562
2563 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
2564
2565         Allow clients to set the navigator platform
2566         https://bugs.webkit.org/show_bug.cgi?id=192735
2567
2568         Reviewed by Tim Horton.
2569
2570         Add a test for setting a custom navigator platform.
2571
2572         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2573         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2574         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
2575
2576 2018-12-19  Truitt Savell  <tsavell@apple.com>
2577
2578         Unreviewed, rolling out r239358.
2579
2580         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
2581         crash on Debug bots
2582
2583         Reverted changeset:
2584
2585         "Clean up IndexedDB files between tests"
2586         https://bugs.webkit.org/show_bug.cgi?id=192796
2587         https://trac.webkit.org/changeset/239358
2588
2589 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2590
2591         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
2592         https://bugs.webkit.org/show_bug.cgi?id=192842
2593         <rdar://problem/46823586>
2594
2595         Reviewed by Tim Horton.
2596
2597         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
2598         item provider when dragging a rich text selection.
2599
2600         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2601
2602 2018-12-18  David Quesada  <david_quesada@apple.com>
2603
2604         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
2605         https://bugs.webkit.org/show_bug.cgi?id=192810
2606         <rdar://problem/46812536>
2607
2608         Reviewed by Alex Christensen.
2609
2610         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2611         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2612             After releasing our reference to the web view, wait until the next turn of the runloop
2613             before checking that the originatingWebView has been zeroed, since the web view might
2614             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
2615             testing general memory management of WKWebViews, only that _WKDownload does not retain
2616             its web view via the 'originatingWebView' property.
2617
2618 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
2619
2620         Clean up IndexedDB files between tests
2621         https://bugs.webkit.org/show_bug.cgi?id=192796
2622
2623         Reviewed by Geoffrey Garen.
2624
2625         * DumpRenderTree/mac/DumpRenderTree.mm:
2626         (runTest):
2627         * WebKitTestRunner/TestController.cpp:
2628         (WTR::TestController::resetStateToConsistentValues):
2629         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2630         (WTR::RemoveAllIndexedDatabasesCallback):
2631         (WTR::TestController::ClearIndexedDatabases):
2632         * WebKitTestRunner/TestController.h:
2633
2634 2018-12-18  Alex Christensen  <achristensen@webkit.org>
2635
2636         Fix API test introduced in r239339 on iOS.
2637         https://bugs.webkit.org/show_bug.cgi?id=192675
2638
2639         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2640         (TEST):
2641         The iOS implementation of the safe browsing warning is a little different.
2642         It does some element creation when it is added to the window so it knows how big it is.
2643         To test these elements, we need to simulate adding it to the window.
2644         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
2645
2646 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
2647
2648         webkitpy: Ignore device type for test when using --force
2649         https://bugs.webkit.org/show_bug.cgi?id=192786
2650         <rdar://problem/46794894>
2651
2652         Reviewed by Daniel Bates.
2653
2654         It is sometimes the case that a contributor will wish to run a test on a specific device,
2655         despite expectations which indicate a test should not be run on that device.
2656
2657         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2658         (parse_args):
2659         * Scripts/webkitpy/port/device_port.py:
2660         (DevicePort.default_child_processes): Strip device type information when using --force.
2661         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
2662
2663 2018-12-18  Alex Christensen  <achristensen@webkit.org>
2664
2665         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
2666         https://bugs.webkit.org/show_bug.cgi?id=192675
2667
2668         Reviewed by Geoffrey Garen.
2669
2670         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2671         (goBack):
2672         (TEST):
2673         (visitUnsafeSite):
2674         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
2675         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2676
2677 2018-12-18  Chris Dumez  <cdumez@apple.com>
2678
2679         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
2680         https://bugs.webkit.org/show_bug.cgi?id=192772
2681
2682         Reviewed by Antti Koivisto.
2683
2684         Add API test coverage.
2685
2686         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2687
2688 2018-12-18  Philippe Normand  <pnormand@igalia.com>
2689
2690         Unreviewed, JHBuild GTK build fix attempt
2691
2692         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
2693         There's no ninja module either, it should be provided by the
2694         host system.
2695
2696 2018-12-17  Chris Dumez  <cdumez@apple.com>
2697
2698         Allow passing nil as session state to [WKWebView _restoreSessionState:]
2699         https://bugs.webkit.org/show_bug.cgi?id=192789
2700         <rdar://problem/46755277>
2701
2702         Reviewed by Alex Christensen.
2703
2704         Add API test coverage.
2705
2706         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
2707         (TEST):
2708
2709 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
2710
2711         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
2712         https://bugs.webkit.org/show_bug.cgi?id=192780
2713         rdar://problem/43394387
2714
2715         Reviewed by Tim Horton.
2716
2717         No need to set "AppleFontSmoothing" defaults for WK2.
2718
2719         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2720         (WTR::InjectedBundle::platformInitialize):
2721
2722 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
2723
2724         webkitpy: Handle case where stdout and stderr don't accept unicode
2725         https://bugs.webkit.org/show_bug.cgi?id=192775
2726         <rdar://problem/46497303>
2727
2728         Reviewed by Stephanie Lewis.
2729
2730         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2731         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
2732         characters with '?'.
2733         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2734         (RegularTest.test_stream_with_encoding):
2735
2736 2018-12-17  Daniel Bates  <dabates@apple.com>
2737
2738         Support concatenating StringView with other string types
2739         https://bugs.webkit.org/show_bug.cgi?id=177566
2740
2741         Reviewed by Darin Adler.
2742
2743         Add some tests to ensure we do not regress the number of allocations needed when performing
2744         string concatenation with string views.
2745
2746         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2747         (TestWebKitAPI::TEST):
2748
2749 2018-12-17  Commit Queue  <commit-queue@webkit.org>
2750
2751         Unreviewed, rolling out r239265 and r239274.
2752         https://bugs.webkit.org/show_bug.cgi?id=192765
2753
2754         unorm_normalize is deprecated, and broke an internal build
2755         (Requested by Truitt on #webkit).
2756
2757         Reverted changesets:
2758
2759         "[GTK][WPE] Need a function to convert internal URI to display
2760         ("pretty") URI"
2761         https://bugs.webkit.org/show_bug.cgi?id=174816
2762         https://trac.webkit.org/changeset/239265
2763
2764         "Fix the Apple Internal Mac build with a newer SDK"
2765         https://trac.webkit.org/changeset/239274
2766
2767 2018-12-17  Daniel Bates  <dabates@apple.com>
2768
2769         Implement UIScriptController::toggleCapsLock() for iOS
2770         https://bugs.webkit.org/show_bug.cgi?id=191815
2771
2772         Reviewed by Andy Estes.
2773
2774         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
2775
2776         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2777         * WebKitTestRunner/TestController.cpp:
2778         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
2779         before running a test. This ensures that the caps lock state does not persist between
2780         tests should a test enable caps lock and not disable it.
2781         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2782         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
2783         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2784         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
2785         create the event. Also substituted NSString* for const String& as the data type for the first
2786         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
2787         below.
2788         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
2789         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
2790
2791 2018-12-17  Daniel Bates  <dabates@apple.com>
2792
2793         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
2794         https://bugs.webkit.org/show_bug.cgi?id=192633
2795
2796         Reviewed by Wenson Hsieh.
2797
2798         Update code to use the modern initializer.
2799
2800         * DumpRenderTree/mac/EventSendingController.mm:
2801         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2802
2803 2018-12-17  Matt Lewis  <jlewis3@apple.com>
2804
2805         Unreviewed, rolling out r239254.
2806
2807         This broke the Windows 10 Debug build
2808
2809         Reverted changeset:
2810
2811         "Replace many uses of String::format with more type-safe
2812         alternatives"
2813         https://bugs.webkit.org/show_bug.cgi?id=192742
2814         https://trac.webkit.org/changeset/239254
2815
2816 2018-12-17  David Kilzer  <ddkilzer@apple.com>
2817
2818         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
2819         <https://webkit.org/b/192751>
2820         <rdar://problem/46771623>
2821
2822         Reviewed by Daniel Bates.
2823
2824         Change loop variables to const references to avoid unnecessary
2825         copies.
2826
2827         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
2828         (-[LocalPasteboard pasteboardItems]):
2829
2830 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
2831
2832         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2833         https://bugs.webkit.org/show_bug.cgi?id=174816
2834
2835         Reviewed by Michael Catanzaro.
2836
2837         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
2838
2839         * TestWebKitAPI/CMakeLists.txt:
2840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2841         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
2842         (TestWebKitAPI::TEST):
2843         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2844         (testURIForDisplayUnaffected):
2845         (testURIForDisplayAffected):
2846         (beforeAll):
2847         (afterAll):
2848         * TestWebKitAPI/glib/CMakeLists.txt:
2849
2850 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2851
2852         [WPE] Add API to notify about frame displayed view backend callback
2853         https://bugs.webkit.org/show_bug.cgi?id=192224
2854
2855         Reviewed by Michael Catanzaro.
2856
2857         Add a test case to check the new API.
2858
2859         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2860         (testWebViewFrameDisplayed):
2861         (beforeAll):
2862         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
2863
2864 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
2865
2866         Unreviewed build fix after r239253
2867
2868         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
2869
2870 2018-12-15  Darin Adler  <darin@apple.com>
2871
2872         Use warning-ignoring macros more consistently and simply
2873         https://bugs.webkit.org/show_bug.cgi?id=192743
2874
2875         Reviewed by Mark Lam.
2876
2877         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2878         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
2879         * DumpRenderTree/mac/TextInputControllerMac.m:
2880         (-[TextInputController interpretKeyEvents:withSender:]): Use
2881         IGNORE_WARNINGS_BEGIN/END.
2882         * WebKitTestRunner/mac/EventSenderProxy.mm:
2883         (WTR::EventSenderProxy::mouseForceClick): Use
2884         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
2885         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
2886         (WTR::EventSenderProxy::mouseForceDown): Ditto.
2887         (WTR::EventSenderProxy::mouseForceUp): Ditto.
2888         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
2889
2890 2018-12-15  Darin Adler  <darin@apple.com>
2891
2892         Replace many uses of String::format with more type-safe alternatives
2893         https://bugs.webkit.org/show_bug.cgi?id=192742
2894
2895         Reviewed by Mark Lam.
2896
2897         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2898         (WTR::cacheTestRunnerCallback): Use makeString.
2899         * WebKitTestRunner/TestController.cpp:
2900         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2901         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2902
2903 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
2904
2905         [WPE][GTK] Add libpsl to JHBuild module sets
2906         https://bugs.webkit.org/show_bug.cgi?id=192740
2907
2908         Reviewed by Michael Catanzaro.
2909
2910         * gtk/jhbuild.modules: Add libpsl module.
2911         * wpe/jhbuild.modules: Ditto.
2912
2913 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
2914
2915         Add a style checker rule for Xcode version macros use
2916         https://bugs.webkit.org/show_bug.cgi?id=192703
2917
2918         Reviewed by Alex Christensen.
2919
2920         * Scripts/webkitpy/style/checkers/cpp.py:
2921         (check_os_version_checks):
2922         (process_line):
2923         (CppChecker):
2924         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2925         (WebKitStyleTest.test_os_version_checks):
2926
2927 2018-12-14  Chris Dumez  <cdumez@apple.com>
2928
2929         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
2930         https://bugs.webkit.org/show_bug.cgi?id=192704
2931
2932         Reviewed by Geoffrey Garen.
2933
2934         Extend existing API test to reproduce the problem.
2935
2936         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2937
2938 2018-12-14  Chris Dumez  <cdumez@apple.com>
2939
2940         [PSON] WebsitePolicies are lost on process-swap
2941         https://bugs.webkit.org/show_bug.cgi?id=192694
2942         <rdar://problem/46715748>
2943
2944         Reviewed by Brady Eidson.
2945
2946         Extend existing API test to reproduce the issue.
2947
2948         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2949
2950 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
2951
2952         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
2953         https://bugs.webkit.org/show_bug.cgi?id=192678
2954
2955         Reviewed by Carlos Garcia Campos.
2956
2957         Update our ancient versions of libsoup and glib-networking.
2958
2959         * gtk/install-dependencies:
2960         * gtk/jhbuild.modules:
2961         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
2962         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
2963         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
2964         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
2965         * wpe/install-dependencies:
2966         * wpe/jhbuild.modules:
2967         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
2968
2969 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2970
2971         [WPE] Use new view state API from libwpe
2972         https://bugs.webkit.org/show_bug.cgi?id=191906
2973
2974         Reviewed by Žan Doberšek.
2975
2976         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2977         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
2978         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2979         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
2980         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
2981         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
2982         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
2983         wpe_view_activity_state_focused state flags.
2984         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
2985         * wpe/backends/HeadlessViewBackend.cpp:
2986         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
2987         * wpe/backends/WindowViewBackend.cpp:
2988         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
2989         received in configure callback.
2990         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
2991
2992 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
2993
2994         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
2995         https://bugs.webkit.org/show_bug.cgi?id=192688
2996
2997         Reviewed by Ross Kirsling.
2998
2999         * win/DLLLauncher/DLLLauncherMain.cpp:
3000         (copyEnvironmentVariable): Moved.
3001         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
3002         (applePathFromRegistry): Ditto.
3003         (appleApplicationSupportDirectory): Ditto.
3004         (prependPath): Ditto.
3005
3006 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
3007
3008         Unreviewed. Changed my status to a reviewer.
3009
3010         * Scripts/webkitpy/common/config/contributors.json:
3011
3012 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3013
3014         [iOS] Support dropping contact card data (public.vcard) in editable content
3015         https://bugs.webkit.org/show_bug.cgi?id=192570
3016         <rdar://problem/35626913>
3017
3018         Reviewed by Tim Horton.
3019
3020         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3021
3022         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
3023         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
3024         additionally inserts a link).
3025
3026         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3027         (TestWebKitAPI::createMapItemForTesting):
3028         (TestWebKitAPI::createContactItemForTesting):
3029
3030         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
3031         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
3032         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
3033         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
3034         files.
3035
3036 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
3037
3038         Unreviewed -- update my status to "reviewer".
3039
3040         * Scripts/webkitpy/common/config/contributors.json:
3041
3042 2018-12-13  Youenn Fablet  <youenn@apple.com>
3043
3044         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
3045         https://bugs.webkit.org/show_bug.cgi?id=192657
3046
3047         Reviewed by Eric Carlson.
3048
3049         Add a test that loads a page registering ondevicechange,
3050         load another page in the same process, closes the first page.
3051         Ensure that the process does not crash in that case.
3052
3053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3054         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3055         (TestWebKitAPI::TEST):
3056         (TestWebKitAPI::didCrashCallback):
3057         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
3058
3059 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3060
3061         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
3062         https://bugs.webkit.org/show_bug.cgi?id=192643
3063
3064         Reviewed by Philippe Normand.
3065
3066         This problem happens with Arch Linux users which have libfdk-2.0.0
3067         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
3068
3069         The problem has already been solved upstream at
3070         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
3071
3072         Adding patches while this problem is not in a release yet.
3073
3074         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
3075         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
3076         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
3077
3078 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3079
3080         [FreeType] Add initial implementation of variation fonts
3081         https://bugs.webkit.org/show_bug.cgi?id=192151
3082
3083         Reviewed by Michael Catanzaro.
3084
3085         Add cairo patch to avoid crashes.
3086
3087         * gtk/jhbuild.modules:
3088         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3089
3090 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
3091
3092         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
3093         https://bugs.webkit.org/show_bug.cgi?id=192618
3094
3095         Reviewed by Alex Christensen.
3096
3097         * DumpRenderTree/win/DRTDataObject.cpp:
3098         * DumpRenderTree/win/DRTDataObject.h:
3099         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3100         * DumpRenderTree/win/DRTDropSource.h:
3101         * DumpRenderTree/win/EditingDelegate.h:
3102         * DumpRenderTree/win/PolicyDelegate.h:
3103         * DumpRenderTree/win/UIDelegate.h:
3104
3105 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
3106
3107         Make TextInputController.legacyAttributedString take DOM nodes and offsets
3108         https://bugs.webkit.org/show_bug.cgi?id=192653
3109
3110         Reviewed by Wenson Hsieh.
3111
3112         Updated TextInputController.legacyAttributedString to take DOM nodes and offsets instead of
3113         a DOM Range object in preparation to add layout tests for HTMLConverter which crosses
3114         shadow boundaries.
3115
3116         * DumpRenderTree/mac/TextInputControllerMac.m:
3117         (+[TextInputController isSelectorExcludedFromWebScript:]): Updated the selector signature.
3118         (+[TextInputController webScriptNameForSelector:]): Ditto.
3119         (-[TextInputController legacyAttributedString:offset:to:offset:]): Made this function take
3120         start node and offset then end node and offset pairs.
3121
3122 2018-12-12  Alex Christensen  <achristensen@webkit.org>
3123
3124         Implement safe browsing in WebKit on WatchOS
3125         https://bugs.webkit.org/show_bug.cgi?id=192641
3126         <rdar://problem/46376188>
3127
3128         Reviewed by Geoff Garen.
3129
3130         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3131         (-[SafeBrowsingNavigationDelegate _webViewDidShowSafeBrowsingWarning:]):
3132         (safeBrowsingView):
3133         Add a test that the new delegate callback is called.
3134
3135 2018-12-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3136
3137         Unreviewed manual rollout of r239100-r239102 and r239116
3138         https://bugs.webkit.org/show_bug.cgi?id=192151
3139         <rdar://problem/46655586>
3140
3141         * gtk/jhbuild.modules:
3142         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Removed.
3143
3144 2018-12-12  Commit Queue  <commit-queue@webkit.org>
3145
3146         Unreviewed, rolling out r239103.
3147         https://bugs.webkit.org/show_bug.cgi?id=192627
3148
3149         It broke the built because it depends on another patch that
3150         didn't land yet (Requested by KaL on #webkit).
3151
3152         Reverted changeset:
3153
3154         "[WPE] Add API to notify about frame displayed view backend
3155         callback"
3156         https://bugs.webkit.org/show_bug.cgi?id=192224
3157         https://trac.webkit.org/changeset/239103
3158
3159 2018-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3160
3161         [WPE] Add API to notify about frame displayed view backend callback
3162         https://bugs.webkit.org/show_bug.cgi?id=192224
3163
3164         Reviewed by Michael Catanzaro.
3165
3166         Add a test case to check the new API.
3167
3168         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3169         (testWebViewFrameDisplayed):
3170         (beforeAll):
3171
3172 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3173
3174         [FreeType] Add initial implementation of variation fonts
3175         https://bugs.webkit.org/show_bug.cgi?id=192151
3176
3177         Reviewed by Michael Catanzaro.
3178
3179         Add cairo patch to avoid crashes.
3180
3181         * gtk/jhbuild.modules:
3182         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3183
3184 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
3185
3186         Implement feature flag for CSS Typed OM
3187         https://bugs.webkit.org/show_bug.cgi?id=192610
3188
3189         Reviewed by Ryosuke Niwa.
3190
3191         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3192
3193 2018-12-11  Chris Dumez  <cdumez@apple.com>
3194
3195         Unreviewed, fix bad check in API test added in r239080.
3196
3197         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3198
3199 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
3200
3201         [Win][Clang] Fix warning -Wmissing-field-initializers
3202         https://bugs.webkit.org/show_bug.cgi?id=192584
3203
3204         Reviewed by Yusuke Suzuki.
3205
3206         Initialize a struct with '{ }' instead of '= {0}'.
3207
3208         * DumpRenderTree/win/DumpRenderTree.cpp:
3209         (runTest):
3210         * DumpRenderTree/win/EventSender.cpp:
3211         (makeMsg):
3212         (replaySavedEvents):
3213         (beginDragWithFilesCallback):
3214         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3215         (createBitmapContextFromWebView):
3216         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3217         (updateMenuItemForHistoryItem):
3218         * MiniBrowser/win/WinMain.cpp:
3219         (wWinMain):
3220         * TestWebKitAPI/win/HostWindow.cpp:
3221         (TestWebKitAPI::HostWindow::clientRect const):
3222         (TestWebKitAPI::HostWindow::registerWindowClass):
3223         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3224         (TestWebKitAPI::PlatformWebView::registerWindowClass):
3225         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3226         (WTR::registerWindowClass):
3227         (WTR::PlatformWebView::windowFrame):
3228         (WTR::PlatformWebView::windowSnapshotImage):
3229
3230 2018-12-11  Chris Dumez  <cdumez@apple.com>
3231
3232         PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
3233         https://bugs.webkit.org/show_bug.cgi?id=192482
3234         <rdar://problem/46470145>
3235
3236         Reviewed by Antti Koivisto.
3237
3238         Add API test coverage.
3239
3240         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3241
3242 2018-12-11  Andy Estes  <aestes@apple.com>
3243
3244         Introduce makeBlockPtr for lambdas
3245         https://bugs.webkit.org/show_bug.cgi?id=192594
3246
3247         Reviewed by Alex Christensen.
3248
3249         Adopted makeBlockPtr and added API tests.
3250
3251         * DumpRenderTree/TestRunner.cpp:
3252         (TestRunner::callUIScriptCallback):
3253         * TestWebKitAPI/Tests/WTF/BlockPtr.mm:
3254         (TestWebKitAPI::TEST):
3255         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3256         (-[DownloadProgressTestRunner init]):
3257         (-[DownloadProgressTestRunner subscribeAndWaitForProgress]):
3258
3259 2018-12-11  Chris Dumez  <cdumez@apple.com>
3260
3261         REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
3262         https://bugs.webkit.org/show_bug.cgi?id=192361
3263         <rdar://problem/46524903>
3264
3265         Reviewed by Alex Christensen.
3266
3267         Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
3268         fixes the failures for me locally.
3269
3270         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3271
3272 2018-12-11  Philippe Normand  <pnormand@igalia.com>
3273
3274         Unreviewed, WPE build fix after r239028
3275
3276         The FLATPAK_USER_DIR env var is not set early enough, leading to:
3277
3278         Traceback (most recent call last):
3279         File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in <module>
3280           sys.exit(WebkitFlatpak.load_from_args().run())
3281         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 761, in run
3282           if not self.clean_args():
3283         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 574, in clean_args
3284           _log.debug("Using flatpak user dir: %s" % os.environ["FLATPAK_USER_DIR"])
3285         File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
3286           raise KeyError(key)
3287         KeyError: 'FLATPAK_USER_DIR'
3288
3289         * flatpak/flatpakutils.py:
3290         (WebkitFlatpak.clean_args):
3291
3292 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3293
3294         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
3295         https://bugs.webkit.org/show_bug.cgi?id=192573
3296
3297         Reviewed by Simon Fraser.
3298
3299         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3300
3301 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3302
3303         [CMake] Add ENABLE_RESOURCE_LOAD_STATISTICS to WebKitFeatures.cmake
3304         https://bugs.webkit.org/show_bug.cgi?id=192574
3305
3306         Reviewed by Michael Catanzaro.
3307
3308         * Scripts/webkitperl/FeatureList.pm:
3309
3310 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3311
3312         Sync FeatureList.pm
3313         https://bugs.webkit.org/show_bug.cgi?id=192565
3314
3315         Reviewed by Michael Catanzaro.
3316
3317         * Scripts/webkitperl/FeatureList.pm:
3318
3319 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3320
3321         [iOS] Unable to upload data that conforms to "public.item" but not "public.content"
3322         https://bugs.webkit.org/show_bug.cgi?id=192555
3323         <rdar://problem/35204990>
3324
3325         Reviewed by Tim Horton.
3326
3327         Add a test to verify that `.p12` files may be uploaded as files via drag and drop. "com.rsa.pkcs-12" is an
3328         example of a data type that conforms to "public.item", but not "public.content"; before this patch, we would
3329         only support uploading "public.content", so files such as these would not be accepted when dropping into file
3330         inputs, or be exposed as files on DataTransfer.
3331
3332         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3333         (TestWebKitAPI::TEST):
3334
3335 2018-12-10  David Kilzer  <ddkilzer@apple.com>
3336
3337         Injected bundle for WebKitTestRunner leaks WKTypeRef objects
3338         <https://webkit.org/b/192481>
3339         <rdar://problem/46539059>
3340
3341         Follow-up to address Darin's feedback.
3342
3343         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3344         (WTR::TestRunner::shouldDumpPixels const):
3345         (WTR::TestRunner::whatToDump const):
3346         (WTR::TestRunner::shouldWaitUntilDone const):
3347         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
3348         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
3349         (WTR::TestRunner::secureEventInputIsEnabled const):
3350         (WTR::TestRunner::isStatisticsPrevalentResource):
3351         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3352         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3353         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3354         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3355         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3356         (WTR::TestRunner::isStatisticsGrandfathered):
3357         (WTR::TestRunner::hasDOMCache):
3358         (WTR::TestRunner::keyExistsInKeychain):
3359
3360 2018-12-10  Jonathan Bedard  <jbedard@apple.com>
3361
3362         webkitpy: Ref tests don't respect platform specific expectations
3363         https://bugs.webkit.org/show_bug.cgi?id=192515
3364         <rdar://problem/46564839>
3365
3366         Reviewed by Lucas Forschler.
3367
3368         * Scripts/webkitpy/port/base.py:
3369         (Port._expected_baselines_for_suffixes): Accept multiple suffixes so ref tests can use this function.
3370         (Port.expected_baselines): Move implementation to _expected_baselines_for_suffixes.
3371         (Port.expected_filename): Remove irrelevant FIXME, code clean-up.
3372         (Port.reference_files): Instead of just searching a single directory, use _expected_baselines_for_suffixes to
3373         search all platform expectations as well.
3374         * Scripts/webkitpy/port/base_unittest.py:
3375         (test_ref_tests_platform_directory):
3376
3377 2018-12-10  Chris Dumez  <cdumez@apple.com>
3378
3379         Add SPI to allow the client to set the user-agent at main frame level, from the UIProcess
3380         https://bugs.webkit.org/show_bug.cgi?id=192509
3381         <rdar://problem/46500832>
3382
3383         Reviewed by Alex Christensen.
3384
3385         Add API test coverage.
3386
3387         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3388         (-[DataMappingSchemeHandler addMappingFromURLString:toData:]):
3389         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3390         (-[DataMappingSchemeHandler webView:stopURLSchemeTask:]):
3391         (-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3392         (-[CustomUserAgentDelegate webView:didFinishNavigation:]):
3393
3394 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3395
3396         [iOS] Caret is obscured by finger when dragging over an editable element
3397         https://bugs.webkit.org/show_bug.cgi?id=192499
3398         <rdar://problem/46570101>
3399
3400         Reviewed by Tim Horton.
3401
3402         Augment some existing API tests to check that the `precise` flag is either on or off on `UIDropProposal`.
3403
3404         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3405         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3406         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3407         (-[DragAndDropSimulator _resetSimulatedState]):
3408         (-[DragAndDropSimulator lastKnownDropProposal]):
3409
3410         Rename `currentDropProposal` to `lastKnownDropProposal`, and expose it as a readonly property.
3411
3412         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
3413         (-[DragAndDropSimulator _advanceProgress]):
3414         (-[DragAndDropSimulator setShowCustomActionSheetBlock:]):
3415         (-[DragAndDropSimulator showCustomActionSheetBlock]):
3416         (-[DragAndDropSimulator setConvertItemProvidersBlock:]):
3417         (-[DragAndDropSimulator convertItemProvidersBlock]):
3418         (-[DragAndDropSimulator setOverridePerformDropBlock:]):
3419         (-[DragAndDropSimulator overridePerformDropBlock]):
3420         (-[DragAndDropSimulator setOverrideDragUpdateBlock:]):
3421         (-[DragAndDropSimulator overrideDragUpdateBlock]):
3422         (-[DragAndDropSimulator setDropCompletionBlock:]):
3423         (-[DragAndDropSimulator dropCompletionBlock]):
3424
3425         Refactor these properties to return and take normal Objective-C blocks, rather than `BlockPtr`s. However, use
3426         `BlockPtr` instance variables to manage the lifetimes of these blocks.
3427
3428         (-[DragAndDropSimulator _webView:willUpdateDropProposalToProposal:forSession:]):
3429         (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]): Deleted.
3430
3431         Update this to use the new WebKit delegate hook for overriding the drop proposal.
3432
3433 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3434
3435         [WPE][GTK] run-minibrowser improperly creates webkit-flatpak environment
3436         https://bugs.webkit.org/show_bug.cgi?id=190241
3437
3438         Reviewed by Carlos Garcia Campos.
3439
3440         run-minibrowser calls into webkit-flatpak to check if a flatpak environment is available.
3441         Currently this actually creates the directories needed for the flatpak environment. Fix it.
3442
3443         * flatpak/flatpakutils.py:
3444         (WebkitFlatpak.clean_args):
3445         (WebkitFlatpak.run):
3446
3447 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3448
3449         [GTK] Don't use the slice allocator
3450         https://bugs.webkit.org/show_bug.cgi?id=192360
3451
3452         Reviewed by Carlos Garcia Campos.
3453
3454         * MiniBrowser/gtk/main.c:
3455         (aboutDataRequestFree):
3456         (aboutDataRequestNew):
3457
3458 2018-12-10  Tim Horton  <timothy_horton@apple.com>
3459
3460         WKWebView should support custom tintColor
3461         https://bugs.webkit.org/show_bug.cgi?id=192518
3462         <rdar://problem/37243261>
3463
3464         Reviewed by Wenson Hsieh.
3465
3466         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
3467         (TestWebKitAPI::TEST):
3468         Add a test that tintColor affects UITextInputTraits' interaction colors.
3469
3470 2018-12-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3471
3472         [iOS] DragAndDropTests.RespectsExternalSourceFidelityRankings is flaky
3473         https://bugs.webkit.org/show_bug.cgi?id=192524
3474
3475         Reviewed by Ryosuke Niwa.
3476
3477         This test started failing on certain builds of iOS where UIKit now attempts to reveal the selection by scrolling
3478         (see <rdar://problem/28300343>). This API test simulates two drops from external sources, both from the point
3479         (300, 400) to (100, 300) in window coordinates. On these aforementioned builds of iOS, what happens is that the
3480         first drop inserts text that overflows the editable region by an enormous amount, which creates an extremely
3481         wide selection rect and increases the width of the document; revealing this selection causes the web view to
3482         scroll horizontally, such that the second attempt to simulate a drag from (300, 400) to (100, 300) fails, since
3483         these window coordinates no longer correspond to the drop destination element in the document.
3484
3485         To fix this test, we simply mark the drop destination as `overflow: hidden` to ensure that we don't try and
3486         scroll horizontally after the first drop.
3487
3488         * TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html:
3489
3490 2018-12-08  Daniel Bates  <dabates@apple.com>
3491
3492         Fix lldb_webkit.py following r238771
3493         (https://bugs.webkit.org/show_bug.cgi?id=190234)
3494
3495         Substitute WTFURLProvider for WebCoreURLProvider in one call site that was inadvertently
3496         missed in r238771.
3497
3498         * lldb/lldb_webkit.py:
3499         (WebCoreDocumentProvider.url):
3500
3501 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3502
3503         [ews-build] check-patch-relevance failure should not mark the overall build as failure
3504         https://bugs.webkit.org/show_bug.cgi?id=192510
3505
3506         Reviewed by Lucas Forschler.
3507
3508         * BuildSlaveSupport/ews-build/steps.py:
3509         (CheckPatchRelevance.start):
3510
3511 2018-12-07  Chris Dumez  <cdumez@apple.com>
3512
3513         ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
3514         https://bugs.webkit.org/show_bug.cgi?id=192362
3515         <rdar://problem/46460360>
3516
3517         Reviewed by Ryosuke Niwa.
3518
3519         Move the call to _setCookieAcceptPolicy *after* we've constructed a WKWebView and thus
3520         *after* we know for sure we have a network process to communicate the policy to.
3521         This should address the failures on iOS.
3522
3523         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3524
3525 2018-12-07  Jiewen Tan  <jiewen_tan@apple.com>
3526
3527         Add keychain access entitlement to WebKitTestRunnerApp
3528         https://bugs.webkit.org/show_bug.cgi?id=192489
3529         <rdar://problem/45057952>
3530
3531         Reviewed by Alexey Proskuryakov.
3532
3533         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
3534
3535 2018-12-07  Saam Barati  <sbarati@apple.com>
3536
3537         WKWebProcessPlugInLoadDelegate should have API for saying which rendering events it wants to listen for
3538         https://bugs.webkit.org/show_bug.cgi?id=192473
3539
3540         Reviewed by Andy Estes.
3541
3542         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3543         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgress.mm: Added.
3544         (-[DidFirstMeaningfulPaintRemoteObject didFirstMeaningfulPaint]):
3545         (TEST):
3546         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressPlugIn.mm: Added.
3547         (-[RenderingProgressPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3548         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextControllerRenderingProgressEvents:]):
3549         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextController:renderingProgressDidChange:]):
3550         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressProtocol.h: Added.
3551
3552 2018-12-07  Jonathan Bedard  <jbedard@apple.com>
3553
3554         REGRESSION: run-webkit-tests may fail when using booted simulators (Follow-up fix)
3555         https://bugs.webkit.org/show_bug.cgi?id=192470
3556         <rdar://problem/46532001>
3557
3558         Unreviewed infrastructure fix.
3559
3560         * Scripts/webkitpy/port/device_port.py:
3561         (DevicePort.setup_test_run): Check that the number of initialized devices matches the
3562         number of child processes.
3563
3564 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3565
3566         [ews-app] Send bug id as a build property
3567         https://bugs.webkit.org/show_bug.cgi?id=192494
3568
3569         Reviewed by Lucas Forschler.
3570
3571         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3572         (BugzillaPatchFetcher.fetch):
3573
3574 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3575
3576         [ews-build] Builds should have a link to patch and bug
3577         https://bugs.webkit.org/show_bug.cgi?id=192492
3578
3579         Reviewed by Lucas Forschler.
3580
3581         * BuildSlaveSupport/ews-build/steps.py:
3582         (ConfigureBuild.add_patch_id_url): Method to add Patch URL.
3583         (ConfigureBuild.add_bug_id_url): Method to add Bug URL.
3584         (ConfigureBuild.getPatchURL): Method to get Patch URL.
3585         (ConfigureBuild.getBugURL): Method to get Bug URL.
3586
3587 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3588
3589         [ews-app] Configure logfile for ews-app logs
3590         https://bugs.webkit.org/show_bug.cgi?id=192493
3591
3592         Reviewed by Lucas Forschler.
3593
3594         * BuildSlaveSupport/ews-app/ews/__init__.py:
3595
3596 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
3597
3598         Style queue exception on some security bugs
3599         https://bugs.webkit.org/show_bug.cgi?id=190793
3600
3601         Reviewed by Lucas Forschler.
3602
3603         * Scripts/webkitpy/tool/steps/applywatchlist.py:
3604         (ApplyWatchList.run):
3605
3606 2018-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3607
3608         [Attachment Support] Cloned attachment elements lose their unique identifiers
3609         https://bugs.webkit.org/show_bug.cgi?id=192483
3610
3611         Reviewed by Tim Horton.
3612
3613         Introduce a new API test.
3614
3615         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3616         (TestWebKitAPI::TEST):
3617
3618 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
3619
3620         Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903
3621         https://bugs.webkit.org/show_bug.cgi?id=192486
3622
3623         Unreviewed infrastructure fix.
3624
3625         WinCairo bots define WEBKIT_TEST_CHILD_PROCESSES to run less processes due to RAM restrictions.
3626
3627         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3628         (_set_up_derived_options):
3629
3630 2018-12-06  David Kilzer  <ddkilzer@apple.com>
3631
3632         Injected bundle for WebKitTestRunner leaks WKTypeRef objects
3633         <https://webkit.org/b/192481>
3634         <rdar://problem/46539059>
3635
3636         Reviewed by Simon Fraser.
3637
3638         This patch:
3639         - Fixes leaks in various injected bundle methods that return +1
3640           retained WKTypeRef objects via pointer.
3641         - Asserts the returned object is the expected WKTypeRef.
3642         - Replaces 0 with nullptr in many places.
3643
3644         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3645         (WTR::InjectedBundle::didCreatePage):
3646         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3647         (WTR::TestRunner::shouldDumpPixels const):
3648         (WTR::TestRunner::whatToDump const):
3649         (WTR::TestRunner::shouldWaitUntilDone const):
3650         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
3651         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
3652         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
3653         (WTR::TestRunner::secureEventInputIsEnabled const):
3654         (WTR::TestRunner::isStatisticsPrevalentResource):
3655         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3656         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3657         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3658         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3659         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3660         (WTR::TestRunner::isStatisticsGrandfathered):
3661         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
3662         (WTR::TestRunner::statisticsUpdateCookieBlocking):
3663         (WTR::TestRunner::statisticsSubmitTelemetry):
3664         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
3665         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
3666         (WTR::TestRunner::statisticsResetToConsistentState):
3667         (WTR::TestRunner::getAllStorageAccessEntries):
3668         (WTR::TestRunner::hasDOMCache):
3669         (WTR::TestRunner::domCacheSize):
3670         (WTR::TestRunner::injectUserScript):
3671         (WTR::TestRunner::keyExistsInKeychain):
3672
3673 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
3674
3675         REGRESSION: run-webkit-tests may fail when using booted simulators
3676         https://bugs.webkit.org/show_bug.cgi?id=192470
3677         <rdar://problem/46532001>
3678
3679         Reviewed by Lucas Forschler.
3680
3681         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3682         (Manager.run): Logging uses the number of child processes to print out information about how efficiently tests
3683         were sharded after the fact. This number is the most meaningful if it is the maximum number of child processes used.
3684         * Scripts/webkitpy/port/base.py:
3685         (Port.max_child_processes): By default, Ports do not support running on any specific kind of device.
3686         * Scripts/webkitpy/port/device_port.py:
3687         (DevicePort.default_child_processes): Rather than using the currently initialized devices as a proxy for how many
3688         child processes are being used, check the device manager every time. Regardless of which devices are attached or
3689         available, iOS cannot boot watchOS devices and vice-versa. dedicated_simulators is not a known argument to
3690         device_count_for_type, use use_booted_simulator instead.
3691         (DevicePort.max_child_processes): Simulators can boot more devices than what is specified by device_count_for_type,
3692         but, if no devices are available, then max_child_processes should return 0 even for simulators.
3693         * Scripts/webkitpy/port/ios_device_unittest.py:
3694         (IOSDeviceTest):
3695         (IOSDeviceTest.test_max_child_processes):
3696         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3697         (IOSSimulatorTest):
3698         (IOSSimulatorTest.test_max_child_processes):
3699         * Scripts/webkitpy/port/port_testcase.py:
3700         (PortTestCase):
3701         (PortTestCase.test_max_child_processes):
3702         * Scripts/webkitpy/port/watch_simulator_unittest.py:
3703         (WatchSimulatorTest):
3704         (WatchSimulatorTest.test_max_child_processes):
3705
3706 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
3707
3708         webkitpy: Ignore case when comparing device types (Follow-up fix)
3709         https://bugs.webkit.org/show_bug.cgi?id=192409
3710         <rdar://problem/46491558>
3711
3712         Unreviewed typo fix.
3713
3714         * Scripts/webkitpy/xcode/device_type_unittest.py:
3715         (DeviceTypeTest.test_comparison_lower_case):
3716         (DeviceTypeTest.test_comparsion_lower_case): Deleted.
3717
3718 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
3719
3720         webkitpy: Create device given lower-case DeviceType
3721         <https://bugs.webkit.org/show_bug.cgi?id=192472>
3722         <rdar://problem/46532650>
3723
3724         Reviewed by Lucas Forschler.
3725
3726         * Scripts/webkitpy/xcode/simulated_device.py:
3727         (SimulatedDeviceManager._get_device_identifier_for_type): Comparing simctl device identifiers with DeviceTypes
3728         should be letter-case agnostic.
3729         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3730         (test_lower_case_device_type):
3731
3732 2018-12-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3733
3734         [iOS] WKWebView should match UITextView behavior when editing text with an RTL keyboard
3735         https://bugs.webkit.org/show_bug.cgi?id=187554
3736         <rdar://problem/42075638>
3737
3738         Reviewed by Tim Horton.
3739
3740         Add support for simulating the keyboard input mode in layout tests using UIScriptController, as well as a new
3741         `TestOption` to make the web view editable.
3742
3743         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3744         (WTR::UIScriptController::setKeyboardInputModeIdentifier):
3745         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3746         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3747         (WTR::UIScriptController::setKeyboardInputModeIdentifier):
3748         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3749         * WebKitTestRunner/PlatformWebView.h:
3750         * WebKitTestRunner/TestController.cpp:
3751         (WTR::updateTestOptionsFromTestHeader):
3752         * WebKitTestRunner/TestController.h:
3753         (WTR::TestController::overriddenKeyboardInputMode const):
3754         * WebKitTestRunner/TestOptions.h:
3755         (WTR::TestOptions::hasSameInitializationOptions const):
3756         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3757         (WTR::TestController::platformCreateWebView):
3758         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3759         (WTR::PlatformWebView::setEditable):
3760         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3761         (WTR::PlatformWebView::setEditable):
3762         * WebKitTestRunner/ios/TestControllerIOS.mm:
3763         (WTR::TestController::platformResetStateToConsistentValues):
3764         (WTR::swizzleCurrentInputMode):
3765         (WTR::TestController::setKeyboardInputModeIdentifier):
3766
3767         Swizzle out several `UIKeyboardInputModeController` methods in order to convince UIKit that the user has
3768         selected a `UIKeyboardInputMode` corresponding to the given identifier. The call to
3769         `-prepareKeyboardInputModeFromPreferences:` is also necessary on iOS 12 in order to update cached writing
3770         direction state in UIKit.
3771
3772         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3773         (WTR::UIScriptController::setKeyboardInputModeIdentifier):
3774         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3775         (WTR::PlatformWebView::setEditable):
3776         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3777         (WTR::PlatformWebView::setEditable):
3778         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
3779         (WTR::PlatformWebView::setEditable):
3780
3781 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3782
3783         [Cocoa] Share ClassMethodSwizzler and InstanceMethodSwizzler between TestWebKitAPI and WebKitTestRunner
3784         https://bugs.webkit.org/show_bug.cgi?id=192437
3785
3786         Reviewed by Tim Horton.
3787
3788         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3789         * TestRunnerShared/cocoa/ClassMethodSwizzler.h: Renamed from Tools/TestWebKitAPI/ClassMethodSwizzler.h.
3790         * TestRunnerShared/cocoa/ClassMethodSwizzler.mm: Renamed from Tools/TestWebKitAPI/ClassMethodSwizzler.mm.
3791         (ClassMethodSwizzler::ClassMethodSwizzler):
3792         (ClassMethodSwizzler::~ClassMethodSwizzler):
3793         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h: Renamed from Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.h.
3794         * TestRunnerShared/cocoa/InstanceMethodSwizzler.mm: Renamed from Tools/TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm.
3795         (InstanceMethodSwizzler::InstanceMethodSwizzler):
3796         (InstanceMethodSwizzler::~InstanceMethodSwizzler):
3797
3798         Move these swizzling helper classes into TestRunnerShared.
3799
3800         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3801         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
3802         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3803         (safeBrowsingView):
3804         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDefaultNavigationDelegate.mm:
3805         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3806         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3807
3808         Remove namespacing around ClassMethodSwizzler and InstanceMethodSwizzler in a few API tests.
3809
3810         * TestWebKitAPI/mac/TestFontOptions.mm:
3811         * WebKitTestRunner/TestController.h:
3812         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3813         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3814         (WTR::ClassMethodSwizzler::ClassMethodSwizzler): Deleted.
3815         (WTR::ClassMethodSwizzler::~ClassMethodSwizzler): Deleted.
3816
3817         Remove this duplicate implementation of ClassMethodSwizzler in WebKitTestRunner.
3818
3819 2018-12-05  Jonathan Bedard  <jbedard@apple.com>
3820
3821         webkitpy: Clean-up apple_additions
3822         https://bugs.webkit.org/show_bug.cgi?id=192413
3823         <rdar://problem/46493491>
3824
3825         Reviewed by Lucas Forschler.
3826
3827         After the addition of watchOS, some functions which were originally iOS specific were
3828         generalized to include all devices.
3829
3830         * Scripts/webkitpy/port/ios_device.py:
3831         (IOSDevicePort._driver_class): Replace iOS specific call with generalized device call.
3832         (IOSDevicePort.path_to_crash_logs): Ditto.
3833         (IOSDevicePort.clean_up_test_run): Ditto.
3834
3835 2018-12-05  Jonathan Bedard  <jbedard@apple.com>
3836
3837         webkitpy: Ignore case when comparing device types
3838         https://bugs.webkit.org/show_bug.cgi?id=192409
3839         <rdar://problem/46491558>
3840
3841         Reviewed by Lucas Forschler.
3842
3843         This allows DeviceTypes constructed with lowercase strings to correctly compare
3844         against DeviceTypes coming from the simulator runtime.
3845
3846         * Scripts/webkitpy/xcode/device_type.py:
3847         (DeviceType.__eq__):
3848         (DeviceType.__contains__):
3849         * Scripts/webkitpy/xcode/device_type_unittest.py:
3850         (DeviceTypeTest):
3851         (DeviceTypeTest.test_comparsion_lower_case):
3852
3853 2018-12-05  Jonathan Bedard  <jbedard@apple.com>
3854
3855         webkitpy: Sort tests by associated device type
3856         https://bugs.webkit.org/show_bug.cgi?id=192161
3857         <rdar://problem/46345392>
3858
3859         Reviewed by Lucas Forschler.
3860
3861         Sort tests by device type and make an effort to run each specified device type.
3862         Do not run tests if their specified device is not available.
3863
3864         * Scripts/webkitpy/common/system/platforminfo.py:
3865         (PlatformInfo.is_watchos): Add watchos bits to platform info.
3866         (PlatformInfo._determine_os_name): Ditto.
3867         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3868         (Manager.run): Assign each test a device type. Then, generate a list of
3869         device types to sequentially iterate through. Note that a test will run
3870         on the first device which matches.
3871         (Manager._end_test_run): Handle the case where no devices are available and no
3872         tests are run.
3873         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3874         (_set_up_derived_options): Manage child processes in manager.
3875         * Scripts/webkitpy/port/base.py:
3876         (Port):
3877         (Port.default_child_processes): Accept additional arguments.
3878         (Port.max_child_processes): Add upper limit for number of child processes.
3879         * Scripts/webkitpy/port/device_port.py:
3880         (DevicePort):
3881         (DevicePort._device_type_with_version): Adds version to the DeviceType.
3882         (DevicePort.default_child_processes): Allows default_child_processes to be
3883         attached to a device type.
3884         (DevicePort.max_child_processes): Add upper limit to the maximum number of child processes.
3885         (DevicePort.setup_test_run): Use _device_type_with_version.
3886         * Scripts/webkitpy/port/ios_device.py:
3887         (IOSDevicePort):
3888         (IOSDevicePort.default_child_processes): Deleted.
3889         * Scripts/webkitpy/port/ios_simulator.py:
3890         (IOSSimulatorPort.default_child_processes): Deleted.
3891         (IOSSimulatorPort.check_sys_deps): Deleted.
3892         * Scripts/webkitpy/port/mac.py:
3893         (MacPort.default_child_processes): Accept additional arguments.
3894         * Scripts/webkitpy/port/test.py:
3895         * Scripts/webkitpy/port/watch_device.py:
3896         (WatchDevicePort):
3897         (WatchDevicePort.default_child_processes): Deleted.
3898         * Scripts/webkitpy/port/watch_simulator.py:
3899         (WatchSimulatorPort.default_child_processes): Deleted.
3900         (WatchSimulatorPort.check_sys_deps): Deleted.
3901         * Scripts/webkitpy/xcode/simulated_device.py:
3902         (SimulatedDeviceManager):
3903         (SimulatedDeviceManager.device_count_for_type): Count the number of devices
3904         available for a specific device type.
3905
3906 2018-12-05  Devin Rousso  <drousso@apple.com>
3907
3908         Unreviewed, add myself to some watch lists.
3909
3910         * Scripts/webkitpy/common/config/watchlist:
3911
3912 2018-12-05  Alicia Boya García  <aboya@igalia.com>
3913
3914         [MSE][GStreamer] Remove the AppendPipeline state machine
3915         https://bugs.webkit.org/show_bug.cgi?id=192204
3916
3917         Reviewed by Xabier Rodriguez-Calvar.
3918
3919         Updated AbortableTaskQueue tests:
3920
3921         Added test: AbortedBySyncTaskHandler.
3922
3923         Renamed test: AbortDuringSyncTask -> AbortBeforeSyncTaskRun (in
3924         order to avoid confusion with the new test).
3925
3926         Added checks for the correct destruction of response objects.
3927
3928         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
3929         (TestWebKitAPI::FancyResponse::FancyResponse):
3930         (TestWebKitAPI::FancyResponse::~FancyResponse):
3931         (TestWebKitAPI::TEST):
3932
3933 2018-12-04  Chris Dumez  <cdumez@apple.com>
3934
3935         ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
3936         https://bugs.webkit.org/show_bug.cgi?id=192362
3937
3938         Reviewed by Alex Christensen.
3939
3940         Set the cookie policy to Accept to make sure the cookies are saved.
3941
3942         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3943
3944 2018-12-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3945
3946         [WPE][GTK] Update GLib
3947         https://bugs.webkit.org/show_bug.cgi?id=191222
3948
3949         Reviewed by Žan Doberšek.
3950
3951         When I try running API tests locally, they crash with:
3952
3953         GLib-GIO-WARNING **: unknown schema extension 'd'
3954
3955         We need to update our old glib to support the 'd' value type, otherwise schemas that may
3956         exist on the host using this type will cause instant crashes.
3957
3958         Also, switch the GLib build to use meson. This requires updating meson as well.
3959
3960         * gtk/jhbuild.modules:
3961         * gtk/patches/glib-cast-function-type.patch: Removed.
3962         * gtk/patches/glib-gtester-do-not-consider-skipped-tests-as-failures.patch: Removed.
3963         * wpe/jhbuild.modules:
3964         * wpe/patches/glib-cast-function-type.patch: Removed.
3965         * wpe/patches/glib-revert-wakeup-changes.patch: Removed.
3966
3967 2018-12-04  Aakash Jain  <aakash_jain@apple.com>
3968
3969         [ews-app] Run BugzillaPatchFetcher periodically
3970         https://bugs.webkit.org/show_bug.cgi?id=192241
3971
3972         Reviewed by Lucas Forschler.
3973
3974         * BuildSlaveSupport/ews-app/ews/__init__.py:
3975         * BuildSlaveSupport/ews-app/ews/apps.py:
3976         (EwsConfig.ready): This method is called by Django on startup.
3977         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3978         (FetchLoop): Class which invokes BugzillaPatchFetcher every 60s.
3979
3980 2018-12-04  Jonathan Bedard  <jbedard@apple.com>
3981
3982         webkitpy: Support unicode in MeteredStream
3983         https://bugs.webkit.org/show_bug.cgi?id=192260
3984
3985         Reviewed by Aakash Jain.
3986
3987         It's possible that the test runner returns unicode characters to be logged when
3988         running layout tests.
3989
3990         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3991         (MeteredStream.write): Print message without attempting to encode/decode it.
3992         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3993         (RegularTest.test_unicode):
3994
3995 2018-12-04  Keith Rollin  <krollin@apple.com>
3996
3997         Update scripts for generating .xcfilelist files
3998         https://bugs.webkit.org/show_bug.cgi?id=192081
3999         <rdar://problem/46312290>
4000
4001         Reviewed by Brent Fulgham.
4002
4003         The initial pass at generate-xcfilelists (a script for
4004         creating/updating the .xcfilelist files needed for various Generate
4005         Foo Source build phases in Xcode) only generated the .xcfilelist files
4006         that held the output files; it did not generate the list of input
4007         files. As well, for the sources generated by DerivedSources.make
4008         makefiles, the script accomplished this via the implementation of a
4009         convention in the makefile that allowed the printing of these output
4010         files when invoked with the 'print_all_generated_files' target. Use of
4011         this convention is inconvenient and error-prone.
4012
4013         The script is now updated to address both of these issues. First, it
4014         generates for the input and output sets of files. Second, it does away
4015         with the convention in the DerivedSources.make makefiles and instead
4016         works from the dependency output information printed when `make` is
4017         invoked with --debug. This second part is implemented in the new
4018         script extract-dependencies-from-makefile.
4019
4020         * Scripts/extract-dependencies-from-makefile: Added.
4021         (Parser):
4022         (Parser.__init__):
4023         (Parser.nextLine):
4024         (Parser.addTarget):
4025         (Parser.addPrereq):
4026         (Parser.doParse):
4027         (Parser.printInputs):
4028         (Parser.printOutputs):
4029         (parseArgs):
4030         (main):
4031         * Scripts/generate-xcfilelists:
4032
4033 2018-12-04  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4034
4035         [WPE] Add gtk-doc
4036         https://bugs.webkit.org/show_bug.cgi?id=178900
4037
4038         Reviewed by Michael Catanzaro.
4039
4040         Add gtk-doc to WPE port. This patch tries to reuse as much code from
4041         WebKitGTK+ as possible.
4042
4043         * gtkdoc/generate-gtkdoc: Renamed from Tools/gtk/generate-gtkdoc.
4044         (get_gtkdoc_module_paths): Add GDK and GTK only if building for GTK.
4045         (prepare_environment_for_gtkdoc_generation):
4046         (build_gtkdoc_for_wpe): Code to generate doc for WPE.
4047         (build_gtkdoc_for_wkgtk): Code to generate doc for WebKitGTK+. Moved from main.
4048         * gtkdoc/gtkdoc.py: Renamed from Tools/gtk/gtkdoc.py.
4049         (GTKDoc.__init__): Initialized required variables according to pylint.
4050         (GTKDoc.api_missing_documentation):
4051         * wpe/install-dependencies: Add gtkdoc dependency.
4052
4053 2018-12-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4054
4055         [SOUP] Move URLSoup back to WebCore after r238771
4056         https://bugs.webkit.org/show_bug.cgi?id=192306
4057
4058         Reviewed by Michael Catanzaro.
4059
4060         Include GUniquePtrSoup from WebCore again.
4061
4062         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4063
4064 2018-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4065
4066         [GTK] Bump freetype, fontconfig, harfbuzz, cairo and icu in jhbuild
4067         https://bugs.webkit.org/show_bug.cgi?id=192310
4068
4069         Reviewed by Michael Catanzaro.
4070
4071         Update those dependencies to their latest stable versions.
4072
4073         * gtk/jhbuild.modules:
4074
4075 2018-12-03  Tomas Popela  <tpopela@redhat.com>
4076
4077         [GTK] Can't run MiniBrowser due to missing python2-yaml
4078         https://bugs.webkit.org/show_bug.cgi?id=192308
4079
4080         Reviewed by Michael Catanzaro.
4081
4082         * gtk/install-dependencies:
4083
4084 2018-12-03  Chris Dumez  <cdumez@apple.com>
4085
4086         Regression(PSON) Google OAuth is broken in private sessions
4087         https://bugs.webkit.org/show_bug.cgi?id=192337
4088         <rdar://problem/46353558>
4089
4090         Reviewed by Alex Christensen.
4091
4092         Add API test coverage.
4093
4094         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4095         * TestWebKitAPI/Tests/WebKitCocoa/GetSessionCookie.html: Added.
4096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4097         * TestWebKitAPI/Tests/WebKitCocoa/SetSessionCookie.html: Added.
4098
4099 2018-12-03  Chris Dumez  <cdumez@apple.com>
4100
4101         [PSON] Request by the client to process-swap is ignored if the window has an opener
4102         https://bugs.webkit.org/show_bug.cgi?id=192267
4103         <rdar://problem/46386886>
4104
4105         Reviewed by Brady Eidson.
4106
4107         Add API test coverage.
4108
4109         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4110
4111 2018-12-03  Keith Rollin  <krollin@apple.com>
4112
4113         Add .xcfilelist files
4114         https://bugs.webkit.org/show_bug.cgi?id=192082
4115         <rdar://problem/46312533>
4116
4117         Reviewed by Brent Fulgham.
4118
4119         Add .xcfilelist files for Generate Derived Sources and Generate
4120         Unified Sources build phases in Xcode. These are just being staged for
4121         now; they'll be added to the Xcode projects later.
4122
4123         * DumpRenderTree/DerivedSources-input.xcfilelist: Added.
4124         * DumpRenderTree/DerivedSources-output.xcfilelist: Added.
4125         * WebKitTestRunner/DerivedSources-input.xcfilelist: Added.
4126         * WebKitTestRunner/DerivedSources-output.xcfilelist: Added.
4127
4128 2018-12-03  Alex Christensen  <achristensen@webkit.org>
4129
4130         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
4131         https://bugs.webkit.org/show_bug.cgi?id=192272
4132
4133         Reviewed by Brady Eidson.
4134
4135         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
4136         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]):
4137         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
4138
4139 2018-12-03  Wenson Hsieh  <wenson_hsieh@apple.com>
4140
4141         [iOSMac] Unable to upload non-image files using drag and drop in WKWebView
4142         https://bugs.webkit.org/show_bug.cgi?id=192283
4143         <rdar://problem/46399461>
4144
4145         Reviewed by Ryosuke Niwa.
4146
4147         Add a new API test to check that an item provider which contains plain text data and a file URL (but is not
4148         marked as an attachment) is still treated as an attachment upon drop. Furthermore, verify that "text/uri-list"
4149         does not expose the actual file URL written to the item provider.
4150
4151         Additionally, rebaseline an existing API test to remove an extraneous "text/uri-list" type that appears in
4152         `DataTransfer.types`, but whose data is inaccessible via `getData` anyways.
4153
4154         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4155
4156 2018-12-01  Don Olmstead  <don.olmstead@sony.com>
4157
4158         Cleanup WebKit Features
4159         https://bugs.webkit.org/show_bug.cgi?id=192262
4160
4161         Reviewed by Michael Catanzaro.
4162
4163         Removes obsolete ENABLE options and variable names. Syncs the option's
4164         descriptions with what is present in WebKitFeatures.cmake. Sorts the
4165         options based on the associated define.
4166
4167         * Scripts/webkitperl/FeatureList.pm:
4168
4169 2018-12-01  Chris Dumez  <cdumez@apple.com>
4170
4171         [PSON] process-swapping may occur even though opener has handle to openee
4172         https://bugs.webkit.org/show_bug.cgi?id=192277
4173
4174         Reviewed by Antti Koivisto.
4175
4176         Add API test coverage.
4177
4178         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4179
4180 2018-12-01  Jonathan Bedard  <jbedard@apple.com>
4181
4182         Unreviewed, rolling out r238764.
4183
4184         Breaks existing layout tests
4185
4186         Reverted changeset:
4187
4188         "webkitpy: Support unicode in MeteredStream"
4189         https://bugs.webkit.org/show_bug.cgi?id=192260
4190         https://trac.webkit.org/changeset/238764
4191
4192 2018-12-01  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
4193
4194         Move URL tests from TestWebKitAPI to TestWTF
4195         https://bugs.webkit.org/show_bug.cgi?id=192275
4196
4197         Reviewed by Keith Miller.
4198
4199         Since URL is moved from WebCore to WTF, we also move tests for them from TestWebKitAPI (TestWebCore) to TestWTF.
4200         But we still have some tests in TestWebCore since only WebCore implements TextEncoding. That part is now decoupled
4201         from URLParser tests and new URLParserTextEncoding.cpp is created.
4202
4203         * TestWebKitAPI/CMakeLists.txt:
4204         * TestWebKitAPI/PlatformGTK.cmake:
4205         * TestWebKitAPI/PlatformWPE.cmake:
4206         * TestWebKitAPI/PlatformWin.cmake:
4207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4208         * TestWebKitAPI/Tests/WTF/URL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/URL.cpp.
4209         (TestWebKitAPI::TEST_F):
4210         * TestWebKitAPI/Tests/WTF/URLParser.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp.
4211         (TestWebKitAPI::TEST_F):
4212         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm.
4213         (TestWebKitAPI::TEST):
4214         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp: Added.
4215         (TestWebKitAPI::ExpectedParts::isInvalid const):
4216         (TestWebKitAPI::eq):
4217         (TestWebKitAPI::insertTabAtLocation):
4218         (TestWebKitAPI::invalidParts):
4219         (TestWebKitAPI::checkURL):
4220         (TestWebKitAPI::TEST_F):
4221
4222 2018-11-30  Zalan Bujtas  <zalan@apple.com>
4223
4224         Unreviewed LFC passing test list update.
4225
4226         * LayoutReloaded/misc/LFC-passing-tests.txt:
4227
4228 2018-11-30  Alex Christensen  <achristensen@webkit.org>
4229
4230         Move URL from WebCore to WTF
4231         https://bugs.webkit.org/show_bug.cgi?id=190234
4232
4233         Reviewed by Keith Miller.
4234
4235         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4236         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
4237         * TestWebKitAPI/Tests/WebCore/URL.cpp:
4238         (TestWebKitAPI::createURL):
4239         (TestWebKitAPI::TEST_F):
4240         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4241         (TestWebKitAPI::checkURL):
4242         (TestWebKitAPI::checkRelativeURL):
4243         (TestWebKitAPI::checkURLDifferences):
4244         (TestWebKitAPI::checkRelativeURLDifferences):
4245         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4246         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
4247         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
4248         (TestWebKitAPI::originalDataAsString):
4249         (TestWebKitAPI::userVisibleString):
4250         (TestWebKitAPI::literalURL):
4251         (TestWebKitAPI::TEST):
4252         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
4253         (TEST):
4254         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
4255         (literalURL):
4256         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
4257         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
4258         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
4259         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
4260         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4261         (TestWebKitAPI::Util::createURLForResource):
4262         * lldb/lldb_webkit.py:
4263         (__lldb_init_module):
4264         (WTFURL_SummaryProvider):
4265         (WTFURLProvider):
4266         (WebCoreURL_SummaryProvider): Deleted.
4267         (WebCoreURLProvider): Deleted.
4268         (WebCoreURLProvider.__init__): Deleted.
4269         (WebCoreURLProvider.to_string): Deleted.
4270
4271 2018-11-30  Jonathan Bedard  <jbedard@apple.com>
4272
4273         webkitpy: Support unicode in MeteredStream
4274         https://bugs.webkit.org/show_bug.cgi?id=192260
4275
4276         Reviewed by Stephanie Lewis.
4277
4278         It's possible that the test runner returns unicode characters to be logged when
4279         running layout tests.
4280
4281         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
4282         (MeteredStream.write): Message written to metered stream should be unicode.
4283         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
4284         (RegularTest.test_unicode):
4285
4286 2018-11-30  Jonathan Bedard  <jbedard@apple.com>
4287
4288         REGRESSION (r238749): run-api-tests dies with AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS'
4289         https://bugs.webkit.org/show_bug.cgi?id=192257
4290         <rdar://problem/46384671>
4291
4292         Reviewed by Stephanie Lewis.
4293
4294         Follow-up fix for r238749.
4295
4296         * Scripts/webkitpy/api_tests/manager.py:
4297         (Manager._initialize_devices): Use DEFAULT_DEVICE_TYPE instead of DEFAULT_DEVICE_CLASS.
4298