Defer EditorState updates until the next layer tree flush in a few additional circums...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Defer EditorState updates until the next layer tree flush in a few additional circumstances
4         https://bugs.webkit.org/show_bug.cgi?id=197145
5         <rdar://problem/50078170>
6
7         Reviewed by Darin Adler.
8
9         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
10         focus, or showing the font manager.
11
12         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
13         (TestWebKitAPI::TEST):
14         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
15         (TEST):
16         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
17         (TestWebKitAPI::TEST):
18
19 2019-04-21  Brian Burg  <bburg@apple.com>
20
21         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
22         https://bugs.webkit.org/show_bug.cgi?id=197125
23         <rdar://problem/50061468>
24
25         Reviewed by Darin Adler.
26
27         Sometimes I want to run wptserve independently of tests. Make it easier to script that
28         using this class rather than making our own ./wpt serve invocation.
29
30         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
31         (WebDriverW3CWebServer):
32         (WebDriverW3CWebServer.document_root): Expose this to clients.
33         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
34
35         (WebDriverW3CWebServer.__enter__):
36         (WebDriverW3CWebServer.__exit__):
37         Make it possible to use the web server with a 'with' statement.
38
39 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
40
41         [CMake][Win] Use target oriented design for WebKitLegacy
42         https://bugs.webkit.org/show_bug.cgi?id=197112
43
44         Reviewed by Konstantin Tokarev.
45
46         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
47
48         * DumpRenderTree/CMakeLists.txt:
49         * DumpRenderTree/PlatformWin.cmake:
50         * DumpRenderTree/win/EventSender.cpp:
51
52 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
53
54         Update text for old EWS submit button
55         https://bugs.webkit.org/show_bug.cgi?id=197140
56
57         Reviewed by Alexey Proskuryakov.
58
59         * QueueStatusServer/templates/statusbubble.html:
60
61 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
62
63         [ews-app] New EWS should poll bugzilla more frequently
64         https://bugs.webkit.org/show_bug.cgi?id=197138
65
66         Reviewed by Alexey Proskuryakov.
67
68         * BuildSlaveSupport/ews-app/ews/fetcher.py:
69         (FetchLoop.__init__):
70
71 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
72
73         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
74         https://bugs.webkit.org/show_bug.cgi?id=197139
75
76         Reviewed by Alexey Proskuryakov.
77
78         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
79         * QueueStatusServer/templates/statusbubble.html:
80
81 2019-04-20  Chris Dumez  <cdumez@apple.com>
82
83         Unreviewed, fix iOS build with recent SDKs.
84
85         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
86
87 2019-04-19  Keith Miller  <keith_miller@apple.com>
88
89         Add script to merge run_benchmark jsons
90         https://bugs.webkit.org/show_bug.cgi?id=197107
91
92         Reviewed by Michael Saboff.
93
94         The script basically recursively decends through all json objects until it gets
95         to an array or JSON primitive and concats or takes the first value, respectively.
96
97         This patch also adds +x bits to the compare-results script so it
98         can be run directly from the command line. I had to add a new line so that svn
99         will accept the change... yay svn!
100
101         * Scripts/compare-results:
102         * Scripts/merge-result-jsons: Added.
103         (readJSONFile):
104         (deepAppend):
105         (mergeJSONs):
106         (main):
107
108 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
109
110         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
111         https://bugs.webkit.org/show_bug.cgi?id=197079
112
113         Reviewed by Darin Adler.
114
115         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
116
117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
118         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
119
120 2019-04-18  Commit Queue  <commit-queue@webkit.org>
121
122         Unreviewed, rolling out r244434.
123         https://bugs.webkit.org/show_bug.cgi?id=197089
124
125         caused 1 API test failure (Requested by zalan on #webkit).
126
127         Reverted changeset:
128
129         "Regression (r244291): Broken API Test
130         AutoLayoutRenderingProgressRelativeOrdering"
131         https://bugs.webkit.org/show_bug.cgi?id=196948
132         https://trac.webkit.org/changeset/244434
133
134 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
135
136         Add new compatibility mode API on WKNavigation
137         https://bugs.webkit.org/show_bug.cgi?id=197069
138         <rdar://problem/50025800>
139
140         Reviewed by Tim Horton.
141
142         Add a block property for -didCommitNavigation to TestNavigationDelegate.
143
144         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
145         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
146         (-[TestNavigationDelegate webView:didCommitNavigation:]):
147
148 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
149
150         [CMake] Make WebCore headers copies
151         https://bugs.webkit.org/show_bug.cgi?id=182512
152         <rdar://problem/37510435>
153
154         Reviewed by Alex Christensen.
155
156         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
157         ports.
158
159         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
160         of WebCore headers using "*.h" were modified to <WebCore/*.h>
161
162         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
163         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
164         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
165         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
166         * TestWebKitAPI/CMakeLists.txt:
167         * TestWebKitAPI/PlatformWin.cmake:
168         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
169         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
170         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
171
172 2019-04-18  Jer Noble  <jer.noble@apple.com>
173
174         Add support for parsing FairPlayStreaming PSSH boxes.
175         https://bugs.webkit.org/show_bug.cgi?id=197064
176
177         Reviewed by Eric Carlson.
178
179         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
180         (TestWebKitAPI::TEST):
181
182 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
183
184         InjectedBundle parameters often need initialization function called before unarchiving
185         https://bugs.webkit.org/show_bug.cgi?id=189709
186         <rdar://problem/44573653>
187
188         Reviewed by Ryosuke Niwa.
189
190         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
191         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
192
193 2019-04-18  Zalan Bujtas  <zalan@apple.com>
194
195         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
196         https://bugs.webkit.org/show_bug.cgi?id=196948
197         <rdar://problem/49927131>
198
199         Reviewed by Tim Horton.
200
201         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
202         (TEST): 
203         The expected order of incoming events is
204         1. didInvalidateIntrinsicContentSize
205         2. didFirstLayout
206         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
207         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
208         (and remember, all we care about is ordering).
209
210 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
211
212         Unreviewed, rolling out r244299.
213
214         Breaks internal tests.
215
216         Reverted changeset:
217
218         "InjectedBundle parameters often need initialization function
219         called before unarchiving"
220         https://bugs.webkit.org/show_bug.cgi?id=189709
221         https://trac.webkit.org/changeset/244299
222
223 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
224
225         [WTF] StringBuilder should set correct m_is8Bit flag when merging
226         https://bugs.webkit.org/show_bug.cgi?id=197053
227
228         Reviewed by Saam Barati.
229
230         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
231         (TestWebKitAPI::TEST):
232
233 2019-04-17  Tim Horton  <timothy_horton@apple.com>
234
235         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
236         https://bugs.webkit.org/show_bug.cgi?id=197028
237         <rdar://problem/49985290>
238
239         Reviewed by Wenson Hsieh.
240
241         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
242         (TEST):
243         Liberal application of waitForNextPresentationUpdate works around a race
244         where if the page rapidly changes its viewport arguments (or an API client
245         rapidly changes its viewport arguments), we'd get stuck thinking that the
246         user had intentionally zoomed the page, and stop resetting the initial scale.
247         This deserves a separate bug, but no need to keep the test failing while
248         we think about it.
249
250 2019-04-17  Tim Horton  <timothy_horton@apple.com>
251
252         REGRESSION (r241988): Switching tabs is slow
253         https://bugs.webkit.org/show_bug.cgi?id=197037
254         <rdar://problem/49951473>
255
256         Reviewed by Simon Fraser.
257
258         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
259         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
260         (TEST):
261         * TestWebKitAPI/cocoa/TestWKWebView.h:
262         * TestWebKitAPI/cocoa/TestWKWebView.mm:
263         (-[TestWKWebView addToTestWindow]):
264         Add a test that hangs without this fix.
265
266 2019-04-17  Truitt Savell  <tsavell@apple.com>
267
268         Unreviewed, rolling out r244400.
269
270         Caused testing to exit early with assertionon Debug WK2
271
272         Reverted changeset:
273
274         "UI↔Web deadlock when printing with a JavaScript alert
275         visible"
276         https://bugs.webkit.org/show_bug.cgi?id=196839
277         https://trac.webkit.org/changeset/244400
278
279 2019-04-17  Brady Eidson  <beidson@apple.com>
280
281         Link clicks in PDFs shouldn't send referrer headers.
282         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
283
284         Reviewed by Tim Horton.
285
286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
287         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
288         (putPDFBytesCallback):
289         (emptyReleaseInfoCallback):
290         (createPDFWithLinkToURL):
291         (TEST):
292
293 2019-04-17  Tim Horton  <timothy_horton@apple.com>
294
295         UI↔Web deadlock when printing with a JavaScript alert visible
296         https://bugs.webkit.org/show_bug.cgi?id=196839
297         <rdar://problem/49157642>
298
299         Reviewed by Andy Estes.
300
301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
302         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
303         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
304         (TEST):
305
306 2019-04-17  Alex Christensen  <achristensen@webkit.org>
307
308         WKRetainPtr's adoption constructor should be private
309         https://bugs.webkit.org/show_bug.cgi?id=197019
310
311         Reviewed by Tim Horton.
312
313         * DumpRenderTree/mac/DumpRenderTree.mm:
314         (dumpFramesAsText):
315         * TestWebKitAPI/InjectedBundleController.cpp:
316         (TestWebKitAPI::InjectedBundleController::initialize):
317         * TestWebKitAPI/PlatformUtilities.cpp:
318         (TestWebKitAPI::Util::createContextWithInjectedBundle):
319         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
320         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
321         (TestWebKitAPI::Util::toWK):
322         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
323         (TestWebKitAPI::TEST):
324         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
325         (TestWebKitAPI::TEST):
326         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
327         (TestWebKitAPI::TEST):
328         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
329         (TestWebKitAPI::TEST):
330         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
331         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
332         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
333         (TestWebKitAPI::TEST):
334         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
335         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
336         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
337         (TestWebKitAPI::TEST):
338         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
339         (TestWebKitAPI::TEST):
340         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
341         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
342         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
343         (TestWebKitAPI::TEST):
344         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
345         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
346         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
347         (TestWebKitAPI::TEST):
348         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
349         (TestWebKitAPI::TEST):
350         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
351         (TestWebKitAPI::TEST):
352         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
353         (TestWebKitAPI::TEST):
354         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
355         (TestWebKitAPI::TEST):
356         * TestWebKitAPI/Tests/WebKit/Find.cpp:
357         (TestWebKitAPI::TEST):
358         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
359         (TestWebKitAPI::TEST):
360         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
361         (TestWebKitAPI::TEST):
362         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
363         (TestWebKitAPI::TEST):
364         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
365         (TestWebKitAPI::TEST):
366         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
367         (TestWebKitAPI::TEST):
368         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
369         (TestWebKitAPI::TEST):
370         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
371         (TestWebKitAPI::TEST):
372         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
373         (TestWebKitAPI::TEST):
374         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
375         (TestWebKitAPI::TEST):
376         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
377         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
378         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
379         (TestWebKitAPI::TEST):
380         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
381         (TestWebKitAPI::TEST):
382         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
383         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
384         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
385         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
386         (TestWebKitAPI::TEST):
387         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
388         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
389         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
390         (TestWebKitAPI::TEST):
391         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
392         (TestWebKitAPI::TEST):
393         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
394         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
395         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
396         (TestWebKitAPI::TEST):
397         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
398         (TestWebKitAPI::loadAlternateHTMLString):
399         (TestWebKitAPI::TEST):
400         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
401         (TestWebKitAPI::TEST):
402         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
403         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
404         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
405         (TestWebKitAPI::buildAndPerformTest):
406         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
407         (TestWebKitAPI::TEST):
408         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
409         (TestWebKitAPI::TEST):
410         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
411         (TestWebKitAPI::TEST):
412         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
413         (TestWebKitAPI::TEST):
414         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
415         (TestWebKitAPI::TEST):
416         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
417         (TestWebKitAPI::TEST):
418         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
419         (TestWebKitAPI::TEST):
420         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
421         (TestWebKitAPI::TEST):
422         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
423         (TestWebKitAPI::TEST):
424         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
425         (TestWebKitAPI::TEST):
426         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
427         (TestWebKitAPI::TEST):
428         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
429         (TestWebKitAPI::TEST):
430         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
431         (TestWebKitAPI::TEST):
432         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
433         (TestWebKitAPI::TEST):
434         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
435         (TestWebKitAPI::TEST):
436         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
437         (TestWebKitAPI::TEST):
438         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
439         (TestWebKitAPI::TEST):
440         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
441         (TestWebKitAPI::TEST):
442         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
443         (TestWebKitAPI::TEST):
444         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
445         (TestWebKitAPI::TEST):
446         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
447         (TestWebKitAPI::TEST):
448         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
449         (TestWebKitAPI::TEST):
450         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
451         (TestWebKitAPI::TEST):
452         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
453         (TestWebKitAPI::TEST):
454         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
455         (TestWebKitAPI::TEST):
456         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
457         (TestWebKitAPI::TEST):
458         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
459         (TestWebKitAPI::TEST):
460         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
461         (TestWebKitAPI::TEST):
462         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
463         (TestWebKitAPI::TEST):
464         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
465         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
466         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
467         (TestWebKitAPI::TEST):
468         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
469         (TestWebKitAPI::TEST):
470         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
471         (TestWebKitAPI::TEST):
472         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
473         (TestWebKitAPI::TEST):
474         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
475         (TestWebKitAPI::TEST):
476         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
477         (TestWebKitAPI::TEST):
478         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
479         (TestWebKitAPI::TEST):
480         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
481         (TestWebKitAPI::TEST):
482         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
483         (TestWebKitAPI::TEST):
484         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
485         (TestWebKitAPI::TEST):
486         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
487         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
488         (TEST):
489         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
490         (TEST):
491         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
492         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
493         (TEST):
494         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
495         (TestWebKitAPI::TEST):
496         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
497         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
498         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
499         (WTR::getMenuItemTitleCallback):
500         (WTR::createMouseMessageBody):
501         (WTR::EventSendingController::mouseDown):
502         (WTR::EventSendingController::mouseUp):
503         (WTR::EventSendingController::mouseMoveTo):
504         (WTR::EventSendingController::mouseForceClick):
505         (WTR::EventSendingController::startAndCancelMouseForceClick):
506         (WTR::EventSendingController::mouseForceDown):
507         (WTR::EventSendingController::mouseForceUp):
508         (WTR::EventSendingController::mouseForceChanged):
509         (WTR::EventSendingController::leapForward):
510         (WTR::EventSendingController::scheduleAsynchronousClick):
511         (WTR::createKeyDownMessageBody):
512         (WTR::EventSendingController::keyDown):
513         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
514         (WTR::EventSendingController::mouseScrollBy):
515         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
516         (WTR::EventSendingController::continuousMouseScrollBy):
517         (WTR::EventSendingController::addTouchPoint):
518         (WTR::EventSendingController::updateTouchPoint):
519         (WTR::EventSendingController::setTouchModifier):
520         (WTR::EventSendingController::setTouchPointRadius):
521         (WTR::EventSendingController::touchStart):
522         (WTR::EventSendingController::touchMove):
523         (WTR::EventSendingController::touchEnd):
524         (WTR::EventSendingController::touchCancel):
525         (WTR::EventSendingController::clearTouchPoints):
526         (WTR::EventSendingController::releaseTouchPoint):
527         (WTR::EventSendingController::cancelTouchPoint):
528         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
529         (WTR::InjectedBundle::didCreatePage):
530         (WTR::InjectedBundle::didReceiveMessage):
531         (WTR::InjectedBundle::didReceiveMessageToPage):
532         (WTR::InjectedBundle::booleanForKey):
533         (WTR::InjectedBundle::done):
534         (WTR::InjectedBundle::dumpToStdErr):
535         (WTR::InjectedBundle::outputText):
536         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
537         (WTR::InjectedBundle::postAddChromeInputField):
538         (WTR::InjectedBundle::postRemoveChromeInputField):
539         (WTR::InjectedBundle::postFocusWebView):
540         (WTR::InjectedBundle::postSetBackingScaleFactor):
541         (WTR::InjectedBundle::postSetWindowIsKey):
542         (WTR::InjectedBundle::postSetViewSize):
543         (WTR::InjectedBundle::postSimulateWebNotificationClick):
544         (WTR::InjectedBundle::postSetAddsVisitedLinks):
545         (WTR::InjectedBundle::setGeolocationPermission):
546         (WTR::InjectedBundle::setMockGeolocationPosition):
547         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
548         (WTR::InjectedBundle::isGeolocationProviderActive const):
549         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
550         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
551         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
552         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
553         (WTR::InjectedBundle::setCustomPolicyDelegate):
554         (WTR::InjectedBundle::setHidden):
555         (WTR::InjectedBundle::setCacheModel):
556         (WTR::InjectedBundle::shouldProcessWorkQueue const):
557         (WTR::InjectedBundle::processWorkQueue):
558         (WTR::InjectedBundle::queueBackNavigation):
559         (WTR::InjectedBundle::queueForwardNavigation):
560         (WTR::InjectedBundle::queueLoad):
561         (WTR::InjectedBundle::queueLoadHTMLString):
562         (WTR::InjectedBundle::queueReload):
563         (WTR::InjectedBundle::queueLoadingScript):
564         (WTR::InjectedBundle::queueNonLoadingScript):
565         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
566         (WTR::frameToStr):
567         (WTR::InjectedBundlePage::InjectedBundlePage):
568         (WTR::dumpFrameDescriptionSuitableForTestResult):
569         (WTR::dumpFrameScrollPosition):
570         (WTR::dumpDescendantFrameScrollPositions):
571         (WTR::dumpFrameText):
572         (WTR::dumpDescendantFramesText):
573         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
574         (WTR::TestRunner::shouldDumpPixels const):
575         (WTR::TestRunner::setDumpPixels):
576         (WTR::TestRunner::whatToDump const):
577         (WTR::TestRunner::setWhatToDump):
578         (WTR::TestRunner::setWaitUntilDone):
579         (WTR::TestRunner::shouldWaitUntilDone const):
580         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
581         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
582         (WTR::TestRunner::clearAllDatabases):
583         (WTR::TestRunner::setIDBPerOriginQuota):
584         (WTR::TestRunner::originsWithApplicationCache):
585         (WTR::TestRunner::setCanOpenWindows):
586         (WTR::TestRunner::setXSSAuditorEnabled):
587         (WTR::TestRunner::setMediaDevicesEnabled):
588         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
589         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
590         (WTR::TestRunner::setCustomUserAgent):
591         (WTR::TestRunner::setWebAPIStatisticsEnabled):
592         (WTR::TestRunner::setModernMediaControlsEnabled):
593         (WTR::TestRunner::setWebGL2Enabled):
594         (WTR::TestRunner::setWritableStreamAPIEnabled):
595         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
596         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
597         (WTR::TestRunner::setAllowsAnySSLCertificate):
598         (WTR::TestRunner::setPluginsEnabled):
599         (WTR::TestRunner::setValueForUser):
600         (WTR::TestRunner::setAudioResult):
601         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
602         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
603         (WTR::TestRunner::setAlwaysAcceptCookies):
604         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
605         (WTR::TestRunner::isDoingMediaCapture const):
606         (WTR::TestRunner::queueLoad):
607         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
608         (WTR::TestRunner::setHandlesAuthenticationChallenges):
609         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
610         (WTR::TestRunner::setShouldLogDownloadCallbacks):
611         (WTR::TestRunner::setAuthenticationUsername):
612         (WTR::TestRunner::setAuthenticationPassword):
613         (WTR::TestRunner::secureEventInputIsEnabled const):
614         (WTR::TestRunner::setBlockAllPlugins):
615         (WTR::TestRunner::setPluginSupportedMode):
616         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
617         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
618         (WTR::TestRunner::setNavigationGesturesEnabled):
619         (WTR::TestRunner::setIgnoresViewportScaleLimits):
620         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
621         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
622         (WTR::TestRunner::terminateNetworkProcess):
623         (WTR::TestRunner::terminateServiceWorkerProcess):
624         (WTR::TestRunner::runUIScript):
625         (WTR::TestRunner::setStatisticsDebugMode):
626         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
627         (WTR::TestRunner::setStatisticsLastSeen):
628         (WTR::TestRunner::setStatisticsPrevalentResource):
629         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
630         (WTR::TestRunner::dumpResourceLoadStatistics):
631         (WTR::TestRunner::isStatisticsPrevalentResource):
632         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
633         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
634         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
635         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
636         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
637         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
638         (WTR::TestRunner::setStatisticsGrandfathered):
639         (WTR::TestRunner::isStatisticsGrandfathered):
640         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
641         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
642         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
643         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
644         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
645         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
646         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
647         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
648         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
649         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
650         (WTR::TestRunner::statisticsUpdateCookieBlocking):
651         (WTR::TestRunner::statisticsSubmitTelemetry):
652         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
653         (WTR::TestRunner::setStatisticsIsRunningTest):
654         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
655         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
656         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
657         (WTR::TestRunner::setStatisticsGrandfatheringTime):
658         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
659         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
660         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
661         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
662         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
663         (WTR::TestRunner::statisticsDeleteCookiesForHost):
664         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
665         (WTR::TestRunner::statisticsResetToConsistentState):
666         (WTR::TestRunner::setStorageAccessAPIEnabled):
667         (WTR::TestRunner::getAllStorageAccessEntries):
668         (WTR::TestRunner::addMockMediaDevice):
669         (WTR::TestRunner::clearMockMediaDevices):
670         (WTR::TestRunner::removeMockMediaDevice):
671         (WTR::TestRunner::resetMockMediaDevices):
672         (WTR::TestRunner::connectMockGamepad):
673         (WTR::TestRunner::disconnectMockGamepad):
674         (WTR::TestRunner::setMockGamepadDetails):
675         (WTR::TestRunner::setMockGamepadAxisValue):
676         (WTR::TestRunner::setMockGamepadButtonValue):
677         (WTR::TestRunner::removeAllSessionCredentials):
678         (WTR::TestRunner::clearDOMCache):
679         (WTR::TestRunner::clearDOMCaches):
680         (WTR::TestRunner::hasDOMCache):
681         (WTR::TestRunner::domCacheSize):
682         (WTR::TestRunner::setAllowStorageQuotaIncrease):
683         (WTR::TestRunner::getApplicationManifestThen):
684         (WTR::TestRunner::injectUserScript):
685         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
686         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
687         (WTR::TestRunner::addTestKeyToKeychain):
688         (WTR::TestRunner::cleanUpKeychain):
689         (WTR::TestRunner::keyExistsInKeychain):
690         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
691         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
692         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
693         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
694         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
695         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
696         * WebKitTestRunner/TestController.cpp:
697         (WTR::TestController::initialize):
698         (WTR::parseStringTestHeaderValueAsRelativePath):
699         (WTR::updateTestOptionsFromTestHeader):
700         (WTR::TestController::runTest):
701         (WTR::TestController::didReceiveLiveDocumentsList):
702         (WTR::TestController::didReceiveMessageFromInjectedBundle):
703         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
704         (WTR::TestController::didFinishNavigation):
705         (WTR::TestController::didReceiveAuthenticationChallenge):
706         * WebKitTestRunner/TestInvocation.cpp:
707         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
708         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
709         (WTR::TestInvocation::uiScriptDidComplete):
710         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
711         * WebKitTestRunner/WebNotificationProvider.cpp:
712         (WTR::WebNotificationProvider::closeWebNotification):
713         * WebKitTestRunner/WorkQueueManager.cpp:
714         (WTR::ScriptItem::ScriptItem):
715         (WTR::WorkQueueManager::queueLoad):
716         (WTR::WorkQueueManager::queueLoadHTMLString):
717
718 2019-04-17  Alex Christensen  <achristensen@webkit.org>
719
720         Add a comment to make my test from r244139 less mysterious.
721         https://bugs.webkit.org/show_bug.cgi?id=196744
722
723         As suggested by Darin Adler.
724
725         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
726         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
727
728 2019-04-17  Chris Dumez  <cdumez@apple.com>
729
730         Remember device orientation permission for the duration of the browsing session
731         https://bugs.webkit.org/show_bug.cgi?id=196992
732         <rdar://problem/49946067>
733
734         Reviewed by Alex Christensen.
735
736         Add API test coverage.
737
738         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
739         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
740         (TEST):
741
742 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
743
744         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
745         https://bugs.webkit.org/show_bug.cgi?id=196675
746
747         Reviewed by Lucas Forschler.
748
749         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
750         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
751
752 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
753
754         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
755         https://bugs.webkit.org/show_bug.cgi?id=196919
756         <rdar://problem/41630459>
757
758         Reviewed by Tim Horton.
759
760         Add iOS support for several new testing hooks. See below for more detail.
761
762         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
763         (WTR::UIScriptController::isDismissingMenu const):
764
765         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
766         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
767         by UIKit when dismissing the callout bar (i.e. UIMenuController).
768
769         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
770         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
771         (WTR::UIScriptController::isDismissingMenu const):
772         * TestRunnerShared/UIScriptContext/UIScriptController.h:
773         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
774         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
775         (WTR::InjectedBundle::didReceiveMessageToPage):
776         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
777         (WTR::TestRunner::setAllowedMenuActions):
778
779         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
780         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
781         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
782         against the name of the custom action.
783
784         (WTR::TestRunner::installCustomMenuAction):
785
786         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
787         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
788         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
789         triggered.
790
791         (WTR::TestRunner::performCustomMenuAction):
792
793         Invoked when the custom menu action is triggered.
794
795         * WebKitTestRunner/InjectedBundle/TestRunner.h:
796         * WebKitTestRunner/TestController.cpp:
797         (WTR::TestController::installCustomMenuAction):
798         (WTR::TestController::setAllowedMenuActions):
799         * WebKitTestRunner/TestController.h:
800         * WebKitTestRunner/TestInvocation.cpp:
801         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
802         (WTR::TestInvocation::performCustomMenuAction):
803
804         Add plumbing to call back into the injected bundle when performing the custom action.
805
806         * WebKitTestRunner/TestInvocation.h:
807         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
808         (WTR::TestController::installCustomMenuAction):
809         (WTR::TestController::setAllowedMenuActions):
810         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
811         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
812         (-[TestRunnerWKWebView initWithFrame:configuration:]):
813         (-[TestRunnerWKWebView becomeFirstResponder]):
814         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
815
816         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
817         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
818         in the Mail app on iOS.
819
820         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
821         (-[TestRunnerWKWebView setAllowedMenuActions:]):
822         (-[TestRunnerWKWebView resetCustomMenuAction]):
823         (-[TestRunnerWKWebView performCustomAction:]):
824         (-[TestRunnerWKWebView canPerformAction:withSender:]):
825         (-[TestRunnerWKWebView _willHideMenu]):
826         (-[TestRunnerWKWebView _didHideMenu]):
827         * WebKitTestRunner/ios/TestControllerIOS.mm:
828         (WTR::TestController::platformResetStateToConsistentValues):
829
830         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
831         if specified.
832
833         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
834         (WTR::UIScriptController::isDismissingMenu const):
835
836 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
837
838         Allow sharing from imageSheet on an image document
839         https://bugs.webkit.org/show_bug.cgi?id=196891
840         <rdar://problem/25377386>
841
842         Reviewed by Tim Horton.
843
844         Test to make sure that the correct imageURL is extracted from an image element.
845
846         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
847         (TestWebKitAPI::TEST):
848
849 2019-04-16  Alex Christensen  <achristensen@webkit.org>
850
851         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
852         https://bugs.webkit.org/show_bug.cgi?id=196995
853
854         Reviewed by Brady Eidson.
855
856         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
857         (TEST):
858
859 2019-04-16  Chris Dumez  <cdumez@apple.com>
860
861         URL set by document.open() is not communicated to the UIProcess
862         https://bugs.webkit.org/show_bug.cgi?id=196941
863         <rdar://problem/49237544>
864
865         Reviewed by Geoff Garen.
866
867         Add API test coverage.
868
869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
870         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
871         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
872         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
873         (TEST):
874
875 2019-04-16  Commit Queue  <commit-queue@webkit.org>
876
877         Unreviewed, rolling out r244321.
878         https://bugs.webkit.org/show_bug.cgi?id=196968
879
880         Causing all WK2 Debug builds to exit early after Assertion
881         failures. (Requested by ShawnRoberts on #webkit).
882
883         Reverted changeset:
884
885         "URL set by document.open() is not communicated to the
886         UIProcess"
887         https://bugs.webkit.org/show_bug.cgi?id=196941
888         https://trac.webkit.org/changeset/244321
889
890 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
891
892         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
893         https://bugs.webkit.org/show_bug.cgi?id=196948
894
895         Reviewed by Zalan Bujtas.
896
897         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
898         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
899
900 2019-04-15  Chris Dumez  <cdumez@apple.com>
901
902         URL set by document.open() is not communicated to the UIProcess
903         https://bugs.webkit.org/show_bug.cgi?id=196941
904         <rdar://problem/49237544>
905
906         Reviewed by Geoffrey Garen.
907
908         Add API test coverage.
909
910         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
911         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
912         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
913         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
914         (TEST):
915
916 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
917
918         Using Tools/Scripts/clean-webkit should not install requests
919         https://bugs.webkit.org/show_bug.cgi?id=196940
920
921         Reviewed by Lucas Forschler.
922
923         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
924         existing, depending on the path autoinstalled is run through.
925         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
926         needed.
927         (Port.configuration_for_upload):
928         (Port.commits_for_upload):
929
930 2019-04-15  Alex Christensen  <achristensen@webkit.org>
931
932         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
933         https://bugs.webkit.org/show_bug.cgi?id=196773
934
935         Reviewed by Jer Noble.
936
937         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
938         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
939         (TEST):
940
941 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
942
943         ews-build should clearly indicate flaky test failures
944         https://bugs.webkit.org/show_bug.cgi?id=196947
945
946         Reviewed by Lucas Forschler.
947
948         * BuildSlaveSupport/ews-build/steps.py:
949         (AnalyzeAPITestsResults.analyzeResults):
950
951 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
952
953         InjectedBundle parameters often need initialization function called before unarchiving
954         https://bugs.webkit.org/show_bug.cgi?id=189709
955         <rdar://problem/44573653>
956
957         Reviewed by Ryosuke Niwa.
958
959         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
960         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
961
962 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
963
964         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
965         https://bugs.webkit.org/show_bug.cgi?id=196681
966
967         Reviewed by Darin Adler.
968
969         Added tests.
970
971         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
972         (WTF_HashSet.RemoveIf):
973         (WTF_HashSet.RemoveIfShrinkToBestSize):
974
975 2019-04-15  John Wilander  <wilander@apple.com>
976
977         Send delayed Ad Click Attribution conversion requests to the click source
978         https://bugs.webkit.org/show_bug.cgi?id=196838
979         <rdar://problem/47650157>
980
981         Reviewed by Chris Dumez and Youenn Fablet.
982
983         This patch adds test infrastructure to override the default behavior in
984         WebKit::NetworkAdClickAttribution.
985
986         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
987         (TestWebKitAPI::TEST):
988         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
989         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
990         (WTR::TestRunner::dumpAdClickAttribution):
991         (WTR::TestRunner::clearAdClickAttribution):
992         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
993         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
994         * WebKitTestRunner/InjectedBundle/TestRunner.h:
995         * WebKitTestRunner/TestController.cpp:
996         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
997         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
998         * WebKitTestRunner/TestController.h:
999         * WebKitTestRunner/TestInvocation.cpp:
1000         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1001
1002 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1003
1004         [ews-app] status-bubble should display position in queue
1005         https://bugs.webkit.org/show_bug.cgi?id=196607
1006
1007         Reviewed by Lucas Forschler.
1008
1009         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1010         (StatusBubble._build_bubble):
1011         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1012
1013 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1014
1015         [ews-build] Do not run clean build by default on EWS builders
1016         https://bugs.webkit.org/show_bug.cgi?id=196897
1017
1018         Reviewed by Lucas Forschler.
1019
1020         * BuildSlaveSupport/ews-build/steps.py:
1021         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1022         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1023         untracked directories like WebKitBuild).
1024         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1025         untracked files/directories (like WebKitBuild).
1026
1027 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1028
1029         TestRunner::notifyDone() should be safely reentrant
1030         https://bugs.webkit.org/show_bug.cgi?id=196898
1031
1032         Reviewed by Darin Adler.
1033
1034         It is currently possible that TestRunner::notifyDone() will call itself, since
1035         notifyDone() will force a repaint, which can start executing JavaScript, which
1036         may call notifyDone() again. This can lead to test failures and flakiness.
1037         Fix this by setting the m_waitToDump flag before calling the dump() method.
1038
1039         * DumpRenderTree/mac/TestRunnerMac.mm:
1040         (TestRunner::notifyDone):
1041         (TestRunner::forceImmediateCompletion):
1042         * DumpRenderTree/win/TestRunnerWin.cpp:
1043         (TestRunner::notifyDone):
1044         (TestRunner::forceImmediateCompletion):
1045
1046 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1047
1048         [GTK][WPE] Add enable-media websetting
1049         https://bugs.webkit.org/show_bug.cgi?id=196863
1050
1051         Reviewed by Michael Catanzaro.
1052
1053         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1054         (testWebKitSettings): Add test for the enable-media web-setting.
1055
1056 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1057
1058         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1059         https://bugs.webkit.org/show_bug.cgi?id=196905
1060         <rdar://problem/49886096>
1061
1062         Reviewed by Tim Horton.
1063
1064         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1065         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1066         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1067         delay timer, we end up with this sequence of events in the problematic (failure) case:
1068
1069         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1070             ...IPC from UI to web process...
1071         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1072             ...IPC from web to UI process...
1073         (c) [UI]    Invoke completion handler for script #1
1074         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1075             ...IPC from UI to web process...
1076         (e) [Web]   Evaluate script #2 in the web process
1077         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1078
1079         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1080         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1081         #2 is run in step (e).
1082
1083         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1084         the UI process by waiting on a script message posted by the web process, after attachment updates are
1085         dispatched.
1086
1087         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1088         (TestWebKitAPI::TEST):
1089
1090 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1091
1092         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1093         https://bugs.webkit.org/show_bug.cgi?id=196909
1094
1095         Reviewed by Wenson Hsieh.
1096
1097         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1098         (TestWebKitAPI::TEST):
1099
1100 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1101
1102         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1103         https://bugs.webkit.org/show_bug.cgi?id=196880
1104
1105         Reviewed by Yusuke Suzuki.
1106
1107         Add a new function for bytecode cache tests that does not forceDiskCache
1108         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1109         test added in this patch, since the code is invalid and therefore won't be
1110         cached. It should also be useful for tests that evaluate dynamically
1111         generated code.
1112
1113         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1114         * Scripts/run-jsc-stress-tests:
1115
1116 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1117
1118         Update AudioSession route sharing policy
1119         https://bugs.webkit.org/show_bug.cgi?id=196776
1120         <rdar://problem/46501611>
1121
1122         Reviewed by Jer Noble.
1123
1124         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1125         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1126         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1127         (TestWebKitAPI::TEST):
1128
1129 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1130
1131         [iOS] Software keyboard is shown too frequently on some websites
1132         https://bugs.webkit.org/show_bug.cgi?id=195856
1133         <rdar://problem/49191395>
1134
1135         Reviewed by Darin Adler.
1136
1137         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1138
1139         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1140         (WTR::UIScriptController::setHardwareKeyboardAttached):
1141         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1142         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1143         (WTR::UIScriptController::setHardwareKeyboardAttached):
1144         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1145         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1146
1147         Additionally link against GraphicsServices in WebKitTestRunner.
1148
1149         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1150         (WTR::TestController::platformResetStateToConsistentValues):
1151         (WTR::UIScriptController::setHardwareKeyboardAttached):
1152
1153 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1154
1155         [GTK][WPE] Fix pacman install-dependencies packages
1156         https://bugs.webkit.org/show_bug.cgi?id=196817
1157
1158         Reviewed by Žan Doberšek.
1159         
1160         python3-setuptools is called python-setuptools
1161         ruby-highline is only available on AUR
1162         libv4l-devel is incorporated in v4l-utils
1163
1164         * gtk/install-dependencies:
1165         * wpe/install-dependencies:
1166
1167 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1168
1169         [GTK] REGRESSION(r243860): Many tests failing
1170         https://bugs.webkit.org/show_bug.cgi?id=196791
1171
1172         Reviewed by Joanmarie Diggs.
1173
1174         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1175         multiple documents and check that accessibility hierarchy is updated after a navigation.
1176
1177         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1178         (loadChangedCallback):
1179         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1180         (AccessibilityTest::AccessibilityTest):
1181         (AccessibilityTest::~AccessibilityTest):
1182         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1183         (AccessibilityTest::findTestServerApplication):
1184         (AccessibilityTest::findDocumentWeb):
1185         (AccessibilityTest::findRootObject):
1186         (AccessibilityTest::waitUntilChildrenRemoved):
1187         (AccessibilityTest::ensureProxy):
1188         (testAtspiBasicHierarchy):
1189         (beforeAll):
1190         (afterAll):
1191
1192 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1193
1194         [ews-build] Handle bug titles with unicode characters
1195         https://bugs.webkit.org/show_bug.cgi?id=196802
1196
1197         Reviewed by Dewei Zhu.
1198
1199         * BuildSlaveSupport/ews-build/steps.py:
1200         (ValidatePatch._is_bug_closed):
1201
1202 2019-04-11  Michael Saboff  <msaboff@apple.com>
1203
1204         Improve the Inline Cache Stats code
1205         https://bugs.webkit.org/show_bug.cgi?id=196836
1206
1207         Reviewed by Saam Barati.
1208
1209         Added a new script to consolidate and arrange the output of --useICStats option.
1210
1211         This script merges the output from every group into one large table and sorts it from most common to
1212         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1213         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1214         Put together, this is useful to see what property accesses are not getting cached.
1215
1216         * Scripts/ic-stats.py: Added.
1217         (ICStats):
1218         (ICStats.__init__):
1219         (ICStats.parse):
1220         (ICStats.dumpStats):
1221         (usage):
1222
1223 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1224
1225         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1226         https://bugs.webkit.org/show_bug.cgi?id=196809
1227         <rdar://49800762>
1228
1229         Reviewed by Brady Eidson.
1230
1231         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1232         (TEST):
1233
1234 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1235
1236         requestAnimationFrame should execute before the next frame
1237         https://bugs.webkit.org/show_bug.cgi?id=177484
1238
1239         Reviewed by Simon Fraser.
1240
1241         Add trace points for the page RenderingUpdate.
1242
1243         * Tracing/SystemTracePoints.plist:
1244
1245 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1246
1247         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1248         https://bugs.webkit.org/show_bug.cgi?id=196760
1249
1250         Reviewed by Don Olmstead.
1251
1252         vswhere.exe has been bundled since Visual Studio 2017 version
1253         15.2. We shouldn't download vswhere.exe.
1254
1255         * Scripts/build-jsc: Do not call update-vswhere.py.
1256         * Scripts/build-webkit: Ditto.
1257         * Scripts/update-vswhere.py: Removed.
1258         * Scripts/webkitdirs.pm:
1259         (requireModulesForVSWhere): Deleted.
1260         (pickCurrentVisualStudioInstallation): Deleted.
1261         (visualStudioInstallDirVSWhere): Return the latest installed VS
1262         installation path by using the bundled vswhere.exe.
1263         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1264         (visualStudioInstallDirFallback): Removed.
1265
1266 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1267
1268         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1269         https://bugs.webkit.org/show_bug.cgi?id=196780
1270
1271         Reviewed by Alexey Proskuryakov.
1272
1273         * BuildSlaveSupport/ews-build/steps.py:
1274         * BuildSlaveSupport/ews-build/steps_unittest.py:
1275
1276 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1277
1278         Add SPI WKNavigationResponse._downloadAttribute
1279         https://bugs.webkit.org/show_bug.cgi?id=196755
1280         <rdar://49587365>
1281
1282         Reviewed by Brady Eidson.
1283
1284         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1285         (-[NavigationResponseTestDelegate navigationResponse]):
1286         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1287         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1288         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1289         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1290         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1291         (readRequest):
1292         (writeResponse):
1293         (TEST):
1294
1295 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1296
1297         Add modern API for overriding the page's specified viewport configuration
1298         https://bugs.webkit.org/show_bug.cgi?id=167734
1299         <rdar://problem/30331795>
1300
1301         Reviewed by Simon Fraser.
1302
1303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1304         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1305
1306 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1307
1308         Add support for incremental bytecode cache updates
1309         https://bugs.webkit.org/show_bug.cgi?id=195000
1310
1311         Reviewed by Filip Pizlo.
1312
1313         Exit when the initial run to generate bytecode fails.
1314
1315         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1316
1317 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1318
1319         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1320         https://bugs.webkit.org/show_bug.cgi?id=196744
1321         <rdar://49415309>
1322
1323         Reviewed by Chris Dumez.
1324
1325         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1326         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1327
1328 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1329
1330         Add a way to opt into modern compatibility mode in layout tests
1331         https://bugs.webkit.org/show_bug.cgi?id=196770
1332         <rdar://problem/49777550>
1333
1334         Reviewed by Antoine Quint.
1335
1336         Add a new test option to enable modern compatibility mode in layout tests.
1337
1338         * WebKitTestRunner/TestController.cpp:
1339         (WTR::updateTestOptionsFromTestHeader):
1340         * WebKitTestRunner/TestController.h:
1341         * WebKitTestRunner/TestOptions.h:
1342         (WTR::TestOptions::hasSameInitializationOptions const):
1343         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1344         (WTR::TestController::platformCreateWebView):
1345         (WTR::TestController::enableModernCompatibilityMode):
1346
1347 2019-04-10  Andy Estes  <aestes@apple.com>
1348
1349         Try to fix the 32-bit watchOS build.
1350
1351         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1352         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1353
1354 2019-04-10  Antoine Quint  <graouts@apple.com>
1355
1356         Enable Pointer Events on watchOS
1357         https://bugs.webkit.org/show_bug.cgi?id=196771
1358         <rdar://problem/49040909>
1359
1360         Reviewed by Dean Jackson.
1361
1362         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1363
1364 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1365
1366         Unreviewed. Fix WPE accessibility tests after r244059.
1367
1368         We are failing to load the injected bundle due to undefined symbol
1369         AccessibilityUIElement::replaceTextInRange().
1370
1371         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1372         (WTR::AccessibilityUIElement::replaceTextInRange):
1373
1374 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1375
1376         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1377         https://bugs.webkit.org/show_bug.cgi?id=196727
1378
1379         Reviewed by Fujii Hironori.
1380
1381         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1382         (WebKitBrowserWindow::create):
1383
1384 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1385
1386         [ews-build] Add unit tests for PrintConfiguration
1387         https://bugs.webkit.org/show_bug.cgi?id=196752
1388
1389         Reviewed by Dewei Zhu.
1390
1391         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1392
1393 2019-04-09  Keith Rollin  <krollin@apple.com>
1394
1395         Unreviewed build maintenance -- update .xcfilelists.
1396
1397         * DumpRenderTree/DerivedSources-input.xcfilelist:
1398         * DumpRenderTree/DerivedSources-output.xcfilelist:
1399
1400 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1401
1402         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1403         https://bugs.webkit.org/show_bug.cgi?id=196743
1404         <rdar://problem/43897551>
1405
1406         Reviewed by Tim Horton.
1407
1408         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1409         (TEST):
1410
1411 2019-04-09  Youenn Fablet  <youenn@apple.com>
1412
1413         Close service worker database on network process suspension
1414         https://bugs.webkit.org/show_bug.cgi?id=196623
1415         <rdar://problem/48930869>
1416
1417         Reviewed by Alex Christensen.
1418
1419         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1420
1421 2019-04-09  Daniel Bates  <dabates@apple.com>
1422
1423         [iPad] Should open popover when the spacebar is pressed
1424         https://bugs.webkit.org/show_bug.cgi?id=196360
1425         <rdar://problem/49389129>
1426
1427         Reviewed by Brent Fulgham.
1428
1429         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1430
1431         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1432         (WTR::UIScriptController::isShowingPopover const): Added.
1433         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1434         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1435         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1436         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1437         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1438         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1439         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1440         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1441         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1442         (WTR::UIScriptController::isShowingPopover const): Added.
1443         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1444         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1445         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1446         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1447         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1448         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1449         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1450         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1451         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1452         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1453         (WTR::UIScriptController::isShowingPopover const): Added.
1454         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1455         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1456
1457 2019-04-09  Alex Christensen  <achristensen@webkit.org>
1458
1459         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1460         https://bugs.webkit.org/show_bug.cgi?id=196665
1461         <rdar://45115669>
1462
1463         Reviewed by Geoff Garen.
1464
1465         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1466         (goBack):
1467         (+[SimpleLookupContext sharedLookupContext]):
1468         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1469         (TEST):
1470         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1471         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1472
1473 2019-04-09  John Wilander  <wilander@apple.com>
1474
1475         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
1476         https://bugs.webkit.org/show_bug.cgi?id=196558
1477         <rdar://problem/47650245>
1478
1479         Reviewed by Youenn Fablet.
1480
1481         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1482         (TestWebKitAPI::TEST):
1483             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
1484
1485 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
1486
1487         [CMake] Apple builds should use ICU_INCLUDE_DIRS
1488         https://bugs.webkit.org/show_bug.cgi?id=196720
1489
1490         Reviewed by Konstantin Tokarev.
1491
1492         * TestWebKitAPI/PlatformMac.cmake:
1493
1494 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
1495
1496         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
1497         https://bugs.webkit.org/show_bug.cgi?id=196694
1498         <rdar://problem/48388734>
1499
1500         Rubber-stamped by Aakash Jain.
1501
1502         * Scripts/webkitpy/port/image_diff.py:
1503         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
1504         * Scripts/webkitpy/port/server_process.py:
1505         (ServerProcess.has_available_stdout): Check if stdout has data in it.
1506         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1507         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1508         * Scripts/webkitpy/port/server_process_mock.py:
1509         (MockServerProcess.has_available_stdout):
1510         * Scripts/webkitpy/port/server_process_unittest.py:
1511         (TestServerProcess.serial_test_basic):
1512
1513 2019-04-09  Jer Noble  <jer.noble@apple.com>
1514
1515         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1516         https://bugs.webkit.org/show_bug.cgi?id=196097
1517
1518         Reviewed by Eric Carlson.
1519
1520         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1521
1522         * DumpRenderTree/mac/DumpRenderTree.mm:
1523         (resetWebPreferencesToConsistentValues):
1524         * WebKitTestRunner/TestController.cpp:
1525         (WTR::TestController::resetPreferencesToConsistentValues):
1526
1527 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
1528
1529         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
1530         https://bugs.webkit.org/show_bug.cgi?id=196690
1531
1532         Reviewed by Michael Catanzaro.
1533
1534         * QueueStatusServer/config/queues.py:
1535         * Scripts/webkitpy/common/config/ews.json:
1536         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1537         (test_ews_name):
1538
1539 2019-04-09  Chris Dumez  <cdumez@apple.com>
1540
1541         Loads using loadHTMLString() cause flashing when process-swapping
1542         https://bugs.webkit.org/show_bug.cgi?id=196714
1543         <rdar://problem/49637354>
1544
1545         Reviewed by Antti Koivisto.
1546
1547         Add API test coverage.
1548
1549         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1550
1551 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1552
1553         Unreviewed. Fix ATK accessibility tests after r244059.
1554
1555         We are failing to load the injected bundle due to undefined symbol
1556         AccessibilityUIElement::replaceTextInRange().
1557
1558         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1559         (WTR::AccessibilityUIElement::replaceTextInRange):
1560
1561 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1562
1563         AX: Support API: accessibilityReplaceRange:withText
1564         https://bugs.webkit.org/show_bug.cgi?id=196636
1565
1566         Unreviewed build fix for Windows port.
1567
1568         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
1569         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
1570
1571 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
1572
1573         [CMake][WinCairo] Separate copied headers into different directories
1574         https://bugs.webkit.org/show_bug.cgi?id=196655
1575
1576         Reviewed by Michael Catanzaro.
1577
1578         * DumpRenderTree/CMakeLists.txt:
1579         * MiniBrowser/win/CMakeLists.txt:
1580         * TestWebKitAPI/CMakeLists.txt:
1581         * TestWebKitAPI/PlatformWin.cmake:
1582
1583 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
1584
1585         Log stack-trace for run-webkit-tests when interrupted
1586         https://bugs.webkit.org/show_bug.cgi?id=176393
1587         <rdar://problem/34262310>
1588
1589         Reviewed by Lucas Forschler.
1590
1591         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
1592         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
1593         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
1594         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
1595         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
1596         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1597         (main): Set handlers to log stack trace on interruption.
1598
1599 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
1600
1601         AX: Support API: accessibilityReplaceRange:withText
1602         https://bugs.webkit.org/show_bug.cgi?id=196636
1603
1604         Unreviewed build fix for Windows port.
1605
1606         * DumpRenderTree/AccessibilityUIElement.cpp:
1607         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
1608
1609 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1610
1611         [ews-build] Scripts using Buildbot API have CORS error
1612         https://bugs.webkit.org/show_bug.cgi?id=196709
1613
1614         Reviewed by Alexey Proskuryakov.
1615
1616         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
1617
1618 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
1619
1620         AX: Support API: accessibilityReplaceRange:withText
1621         https://bugs.webkit.org/show_bug.cgi?id=196636
1622
1623         Reviewed by Daniel Bates.
1624
1625         * DumpRenderTree/AccessibilityUIElement.cpp:
1626         (replaceTextInRangeCallback):
1627         (AccessibilityUIElement::replaceTextInRange):
1628         (AccessibilityUIElement::getJSClass):
1629         * DumpRenderTree/AccessibilityUIElement.h:
1630         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1631         (AccessibilityUIElement::replaceTextInRange):
1632         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1633         (AccessibilityUIElement::replaceTextInRange):
1634         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1635         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1636         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1637         (WTR::AccessibilityUIElement::replaceTextInRange):
1638         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1639         (WTR::AccessibilityUIElement::replaceTextInRange):
1640
1641 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1642
1643         [iOS] Do not allow starting selection drags when selection views are not visible
1644         https://bugs.webkit.org/show_bug.cgi?id=196686
1645         <rdar://problem/49399192>
1646
1647         Reviewed by Tim Horton.
1648
1649         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
1650         also add some new API tests to cover scenarios where the web view is not first responder.
1651
1652         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1653         (TestWebKitAPI::TEST):
1654         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1655
1656         Add a switch to optionally make the web view first responder when starting the simulated drag.
1657
1658         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1659         (-[DragAndDropSimulator initWithWebView:]):
1660         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1661
1662 2019-04-08  Justin Fan  <justin_fan@apple.com>
1663
1664         [Web GPU] Fix Web GPU experimental feature on iOS
1665         https://bugs.webkit.org/show_bug.cgi?id=196632
1666
1667         Reviewed by Myles C. Maxfield.
1668
1669         Properly make Web GPU available on iOS 11+.
1670
1671         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1672
1673 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
1674
1675         [ews-build] Do not upload archive when Compile Fails
1676         https://bugs.webkit.org/show_bug.cgi?id=196674
1677
1678         Reviewed by Alexey Proskuryakov.
1679
1680         * BuildSlaveSupport/ews-build/factories.py:
1681         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
1682         * BuildSlaveSupport/ews-build/steps.py:
1683         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
1684         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
1685         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
1686
1687 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
1688
1689         Enable DFG on MIPS
1690         https://bugs.webkit.org/show_bug.cgi?id=196689
1691
1692         Reviewed by Žan Doberšek.
1693
1694         Since the bytecode change, we enabled the baseline JIT on mips in
1695         r240432, but DFG is still missing. With this change, all tests are
1696         passing on a ci20 board.
1697
1698         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
1699
1700 2019-04-08  Philippe Normand  <pnormand@igalia.com>
1701
1702         [Flatpak] Second run update-webkitwpe-flatpak fails
1703         https://bugs.webkit.org/show_bug.cgi?id=192702
1704
1705         Reviewed by Carlos Garcia Campos.
1706
1707         * flatpak/flatpakutils.py:
1708         (FlatpakObject.flatpak): Fix typo.
1709         (FlatpakPackage.install): When installing, also update to the configured remote commit.
1710         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
1711
1712 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
1713
1714         [GTK][WPE] outlook.live.com displays old-fashioned UI
1715         https://bugs.webkit.org/show_bug.cgi?id=196642
1716
1717         Reviewed by Carlos Garcia Campos.
1718
1719         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1720         (TestWebKitAPI::TEST): New Mac platform quirk test.
1721
1722 2019-04-07  Commit Queue  <commit-queue@webkit.org>
1723
1724         Unreviewed, rolling out r243956.
1725         https://bugs.webkit.org/show_bug.cgi?id=196688
1726
1727         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
1728         by aakashjain on #webkit).
1729
1730         Reverted changeset:
1731
1732         "Clicking "Go Back" from a safe browsing warning from an
1733         iframe should navigate the WKWebView back to the previous
1734         page"
1735         https://bugs.webkit.org/show_bug.cgi?id=196665
1736         https://trac.webkit.org/changeset/243956
1737
1738 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1739
1740         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
1741         https://bugs.webkit.org/show_bug.cgi?id=196669
1742
1743         Reviewed by Geoffrey Garen.
1744
1745         Added three new unit tests for WeakHashSet.
1746
1747         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1748         (WTF_WeakPtr.WeakHashSetConstObjects):
1749         (WTF_WeakPtr.WeakHashSetComputesEmpty):
1750         (WTF_WeakPtr.WeakHashSetComputeSize):
1751
1752 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1753
1754         Hide next and previous form control buttons when WKWebView is editable
1755         https://bugs.webkit.org/show_bug.cgi?id=196672
1756         <rdar://problem/35625321>
1757
1758         Reviewed by Tim Horton.
1759
1760         Add a new API test.
1761
1762         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1763         (-[TestWKWebView lastTrailingBarButtonGroup]):
1764         (TestWebKitAPI::TEST):
1765         * TestWebKitAPI/ios/UIKitSPI.h:
1766
1767 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
1768
1769         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
1770         https://bugs.webkit.org/show_bug.cgi?id=196077
1771         <rdar://problem/49108202>
1772
1773         Reviewed by Chris Dumez.
1774
1775         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
1776         on new web view.
1777
1778         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1779
1780 2019-04-05  Saam Barati  <sbarati@apple.com>
1781
1782         Make compare-results understand MotionMark
1783         https://bugs.webkit.org/show_bug.cgi?id=196666
1784
1785         Reviewed by Yusuke Suzuki.
1786
1787         * Scripts/compare-results:
1788         (PLT5Results):
1789         (detectMotionMark):
1790         (detectMotionMark1_1):
1791         (motionMarkResults):
1792         (motionMark1_1Results):
1793         (detectBenchmark):
1794         (biggerIsBetter):
1795         (main):
1796
1797 2019-04-05  Alex Christensen  <achristensen@webkit.org>
1798
1799         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
1800         https://bugs.webkit.org/show_bug.cgi?id=196665
1801         <rdar://45115669>
1802
1803         Reviewed by Geoff Garen.
1804
1805         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1806         (goBack):
1807         (+[SimpleLookupContext sharedLookupContext]):
1808         (-[SimpleLookupContext lookUpURL:completionHandler:]):
1809         (TEST):
1810         (+[Simple3LookupContext sharedLookupContext]): Deleted.
1811         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
1812
1813 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
1814
1815         [ews-build] Add configuration and architecture for windows builders
1816         https://bugs.webkit.org/show_bug.cgi?id=196660
1817
1818         Reviewed by Lucas Forschler.
1819
1820         * BuildSlaveSupport/ews-build/config.json:
1821
1822 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
1823
1824         webkitpy: Don't run subsequent rounds if interrupted
1825         https://bugs.webkit.org/show_bug.cgi?id=196646
1826
1827         Reviewed by Aakash Jain.
1828
1829         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1830         (Manager.run): Bail out if interrupted.
1831
1832 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
1833
1834         Test sessionStorage in PSON private browsing mode
1835         https://bugs.webkit.org/show_bug.cgi?id=196561
1836
1837         Reviewed by Alex Christensen.
1838
1839         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1840
1841 2019-04-05  Commit Queue  <commit-queue@webkit.org>
1842
1843         Unreviewed, rolling out r243833.
1844         https://bugs.webkit.org/show_bug.cgi?id=196645
1845
1846         This change breaks build of WPE and GTK ports (Requested by
1847         annulen on #webkit).
1848
1849         Reverted changeset:
1850
1851         "[CMake][WTF] Mirror XCode header directories"
1852         https://bugs.webkit.org/show_bug.cgi?id=191662
1853         https://trac.webkit.org/changeset/243833
1854
1855 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
1856
1857         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
1858         https://bugs.webkit.org/show_bug.cgi?id=196635
1859
1860         Reviewed by Antti Koivisto.
1861         
1862         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
1863         for a test to enable async frame scrolling via:
1864             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
1865         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
1866         
1867         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
1868
1869         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1870         (WTR::InjectedBundle::beginTesting):
1871         * WebKitTestRunner/TestController.cpp:
1872         (WTR::TestController::resetPreferencesToConsistentValues):
1873
1874 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
1875
1876         Use a correct LC_RPATH when building with ASan
1877         https://bugs.webkit.org/show_bug.cgi?id=196576
1878
1879         Reviewed by David Kilzer.
1880
1881         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
1882         so that ../Frameworks is checked. This is simpler and more reliable than updating
1883         each SPC service xcconfig.
1884
1885 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1886
1887         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
1888         https://bugs.webkit.org/show_bug.cgi?id=196629
1889
1890         Reviewed by Lucas Forschler.
1891
1892         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1893
1894 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1895
1896         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
1897         https://bugs.webkit.org/show_bug.cgi?id=196618
1898
1899         Reviewed by Lucas Forschler.
1900
1901         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1902         (StatusBubble): Added QUEUE_TRIGGERS.
1903         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1904         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1905         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1906         its parent(builder).
1907
1908 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1909
1910         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1911         https://bugs.webkit.org/show_bug.cgi?id=196625
1912
1913         Reviewed by Lucas Forschler.
1914
1915         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1916         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1917
1918 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1919
1920         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1921         https://bugs.webkit.org/show_bug.cgi?id=196630
1922
1923         Reviewed by Wenson Hsieh.
1924
1925         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1926
1927 2019-04-04  Youenn Fablet  <youenn@apple.com>
1928
1929         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1930         https://bugs.webkit.org/show_bug.cgi?id=196543
1931
1932         Reviewed by Alex Christensen.
1933
1934         * WebKitTestRunner/TestController.cpp:
1935         (WTR::TestController::generatePageConfiguration):
1936
1937 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1938
1939         [ews-app] Status bubble should not display skipped buildbot steps
1940         https://bugs.webkit.org/show_bug.cgi?id=196584
1941
1942         Reviewed by Lucas Forschler.
1943
1944         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1945
1946 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1947
1948         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1949         https://bugs.webkit.org/show_bug.cgi?id=196620
1950
1951         Reviewed by Lucas Forschler.
1952
1953         * BuildSlaveSupport/ews-app/ews/config.py:
1954
1955 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1956
1957         [Win] DumpRenderTreeWatchDog.py is not checked into source
1958         https://bugs.webkit.org/show_bug.cgi?id=196567
1959         <rdar://problem/49525901>
1960
1961         Reviewed by Lucas Forschler.
1962
1963         This script is used on Win EWS bots to terminate hanging DRT processes.
1964
1965         * EWSTools/dumprendertreewatchdog.py: Added.
1966
1967 2019-04-04  Chris Dumez  <cdumez@apple.com>
1968
1969         Unreviewed, roll out r243858 which made tests time out.
1970
1971         Disable new API tests on Windows instead.
1972
1973         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1974         (TestWebKitAPI::TEST):
1975
1976 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1977
1978         [ATK] Cleanup WebPageAccessibilityObjectAtk
1979         https://bugs.webkit.org/show_bug.cgi?id=196537
1980
1981         Reviewed by Michael Catanzaro.
1982
1983         Also consider files under atk directories as exceptions for GObject conventions.
1984
1985         * Scripts/webkitpy/style/checkers/cpp.py:
1986         (check_identifier_name_in_declaration):
1987
1988 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1989
1990         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1991         https://bugs.webkit.org/show_bug.cgi?id=196588
1992         <rdar://problem/49365787>
1993
1994         Unreviewed build fix for Windows port.
1995
1996         error C3861: 'kill': identifier not found
1997
1998         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1999         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2000
2001 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2002
2003         [ews-build] Cancel build and similar operations should have authentication
2004         https://bugs.webkit.org/show_bug.cgi?id=196520
2005
2006         Reviewed by Dewei Zhu.
2007
2008         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2009         environment variables.
2010
2011 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2012
2013         [ews-build] Do not trigger queues which are not in production yet
2014         https://bugs.webkit.org/show_bug.cgi?id=196581
2015
2016         Reviewed by Dewei Zhu.
2017
2018         * BuildSlaveSupport/ews-build/config.json:
2019
2020 2019-04-03  Chris Dumez  <cdumez@apple.com>
2021
2022         Unreviewed, fix typo in the name of API test added in r243848.
2023
2024         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2025         (TestWebKitAPI::TEST):
2026
2027 2019-04-03  Chris Dumez  <cdumez@apple.com>
2028
2029         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2030         https://bugs.webkit.org/show_bug.cgi?id=196588
2031         <rdar://problem/49365787>
2032
2033         Reviewed by Ryosuke Niwa.
2034
2035         Add API test coverage.
2036
2037         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2038         (TestWebKitAPI::nullJavaScriptCallback):
2039         (TestWebKitAPI::didCrashCheckFrames):
2040         (TestWebKitAPI::TEST):
2041
2042 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2043
2044         run-webkit-tests: Upload test results (new results database)
2045         https://bugs.webkit.org/show_bug.cgi?id=196577
2046         <rdar://problem/34841155>
2047
2048         Reviewed by Lucas Forschler.
2049
2050         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2051         (Manager.run): Upload results after each device shard, since the configuration will be
2052         different for each device.
2053         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2054         uploaded to a results database.
2055         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2056         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2057
2058 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2059
2060         -apple-trailing-word is needed for browser detection
2061         https://bugs.webkit.org/show_bug.cgi?id=196575
2062
2063         Unreviewed.
2064
2065         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2066
2067 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2068
2069         [CMake][WTF] Mirror XCode header directories
2070         https://bugs.webkit.org/show_bug.cgi?id=191662
2071
2072         Reviewed by Konstantin Tokarev.
2073
2074         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2075         builds.
2076
2077         * CMakeLists.txt:
2078         * DumpRenderTree/CMakeLists.txt:
2079         * DumpRenderTree/PlatformWin.cmake:
2080         * MiniBrowser/win/CMakeLists.txt:
2081         * TestWebKitAPI/CMakeLists.txt:
2082         * TestWebKitAPI/PlatformWin.cmake:
2083         * WebKitTestRunner/PlatformGTK.cmake:
2084         * WebKitTestRunner/PlatformWin.cmake:
2085
2086 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2087
2088         [ews-app] Status bubble should not display certain infrastructure status messages
2089         https://bugs.webkit.org/show_bug.cgi?id=196550
2090
2091         Reviewed by Lucas Forschler.
2092
2093         Do not display the steps which are un-needed for end-user. This information is still avaiable
2094         if the user click on the bubble and look at the Buildbot build.
2095         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2096         (StatusBubble._steps_messages):
2097         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2098
2099 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2100
2101         [ews-build] Use https for sending data to ews-app
2102         https://bugs.webkit.org/show_bug.cgi?id=196492
2103
2104         Reviewed by Lucas Forschler.
2105
2106         * BuildSlaveSupport/ews-build/events.py:
2107
2108 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2109
2110         Remove support for -apple-trailing-word
2111         https://bugs.webkit.org/show_bug.cgi?id=196525
2112
2113         Reviewed by Zalan Bujtas.
2114
2115         This CSS property is nonstandard and not used.
2116
2117         * Scripts/webkitperl/FeatureList.pm:
2118         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2119
2120 2019-04-03  Youenn Fablet  <youenn@apple.com>
2121
2122         Add a test for DOMCache on multiple browsing in case of private browsing
2123         https://bugs.webkit.org/show_bug.cgi?id=196524
2124
2125         Reviewed by Alex Christensen.
2126
2127         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2128         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2129
2130 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2131
2132         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2133         https://bugs.webkit.org/show_bug.cgi?id=196540
2134
2135         Reviewed by Aakash Jain.
2136
2137         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2138
2139 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2140
2141         Add plumbing for a compatibility mode preference in WebKit
2142         https://bugs.webkit.org/show_bug.cgi?id=196005
2143
2144         Reviewed by Tim Horton.
2145
2146         Add new API tests.
2147
2148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2149         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2150
2151 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2152
2153         [WPE][GTK] Update libsrtp dependency package for Debian
2154         https://bugs.webkit.org/show_bug.cgi?id=196528
2155
2156         Reviewed by Frédéric Wang.
2157
2158         * gtk/install-dependencies:
2159         * wpe/install-dependencies:
2160
2161 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2162
2163         [WK2] Add support for Window's beforeprint / afterprint events
2164         https://bugs.webkit.org/show_bug.cgi?id=196478
2165         <rdar://problem/49535124>
2166
2167         Unreviewed build fix for MSVC.
2168
2169         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2170
2171         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2172
2173         * WebKitTestRunner/TestController.cpp:
2174         (WTR::printFrame): Use int and float literals.
2175
2176 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2177
2178         [ews-build] Reassign bots to queues
2179
2180         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2181
2182 2019-04-02  Chris Dumez  <cdumez@apple.com>
2183
2184         [WK2] Add support for Window's beforeprint / afterprint events
2185         https://bugs.webkit.org/show_bug.cgi?id=196478
2186
2187         Reviewed by Alex Christensen.
2188
2189         Add minimal implementation for printFrame in WebKitTestRunner.
2190
2191         * WebKitTestRunner/TestController.cpp:
2192         (WTR::printFrame):
2193         (WTR::TestController::createOtherPage):
2194         (WTR::TestController::createWebViewWithOptions):
2195
2196 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2197
2198         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2199         https://bugs.webkit.org/show_bug.cgi?id=196491
2200
2201         Reviewed by Lucas Forschler.
2202
2203         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2204
2205 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2206
2207         [ews-build] Configure buildbot try credentials in environment variables
2208         https://bugs.webkit.org/show_bug.cgi?id=196501
2209
2210         Reviewed by Lucas Forschler.
2211
2212         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2213         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2214         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2215
2216 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2217
2218         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2219         https://bugs.webkit.org/show_bug.cgi?id=196496
2220         <rdar://problem/49521634>
2221
2222         Reviewed by Chris Dumez.
2223
2224         Add new API tests (see WebKit ChangeLog for more detail).
2225
2226         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2227         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2228         (TEST):
2229
2230 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2231
2232         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2233         <https://webkit.org/b/196499>
2234
2235         Reviewed by Alexey Proskuryakov.
2236
2237         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2238         ENABLE_ADDRESS_SANITIZER.
2239
2240 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2241
2242         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2243         https://bugs.webkit.org/show_bug.cgi?id=182757
2244
2245         Reviewed by Don Olmstead.
2246
2247         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2248         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2249
2250 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2251
2252         run-api-tests: Upload test results
2253         https://bugs.webkit.org/show_bug.cgi?id=196323
2254         <rdar://problem/49356714>
2255
2256         Reviewed by Lucas Forschler.
2257
2258         * Scripts/webkitpy/api_tests/manager.py:
2259         (Manager):
2260         (Manager.run): Upload results to a results database.
2261         * Scripts/webkitpy/api_tests/run_api_tests.py:
2262         (parse_args): Add upload arguments.
2263         * Scripts/webkitpy/port/base.py:
2264         (Port):
2265         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2266         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2267         with commits from any other associated repositories.
2268         * Scripts/webkitpy/port/device.py:
2269         (Device):
2270         (Device.build_version): Access build_versoin of underlying platform device.
2271         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2272         (IOSSimulatorTest):
2273         (IOSSimulatorTest.test_configuration_for_upload):
2274         * Scripts/webkitpy/port/device_port.py:
2275         (DevicePort):
2276         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2277         the same as the machine uploading results.
2278         * Scripts/webkitpy/port/mac.py:
2279         (MacPort):
2280         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2281         * Scripts/webkitpy/port/mac_unittest.py:
2282         (MacTest):
2283         (MacTest.test_configuration_for_upload):
2284         * Scripts/webkitpy/xcode/simulated_device.py:
2285         (SimulatedDeviceManager._create_device_with_runtime):
2286         (SimulatedDevice.__init__): Create simulated device with a build_version.
2287         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2288         (test_existing_simulator):
2289
2290 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2291
2292         Remove extra newline characters (Follow-up fix to r243707)
2293
2294         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2295
2296 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2297
2298         [ews-app] Use API_KEY to accept results data
2299         https://bugs.webkit.org/show_bug.cgi?id=196461
2300
2301         Reviewed by Dewei Zhu.
2302
2303         * BuildSlaveSupport/ews-app/ews/views/results.py:
2304         (Results.post): Validate EWS_API_KEY before accepting any data.
2305         * BuildSlaveSupport/ews-build/events.py:
2306         (Events.sendData): Send EWS_API_KEY if available along with event data.
2307
2308 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2309
2310         Unable to copy and paste a PDF from Notes into Mail compose body
2311         https://bugs.webkit.org/show_bug.cgi?id=196442
2312         <rdar://problem/48573098>
2313
2314         Reviewed by Tim Horton.
2315
2316         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2317         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2318         to be specified on the item providers.
2319
2320         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2321         (TestWebKitAPI::mapItemForTesting):
2322         (TestWebKitAPI::contactItemForTesting):
2323
2324 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2325
2326         Make UIWKDocumentContext rects per-character instead of per-word
2327         https://bugs.webkit.org/show_bug.cgi?id=196459
2328
2329         Reviewed by Wenson Hsieh.
2330
2331         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2332         (TEST):
2333         Adjust test results due to switching to per-character rects.
2334
2335 2019-04-01  Chris Dumez  <cdumez@apple.com>
2336
2337         UIProcess crash when a prewarmed process is terminated
2338         https://bugs.webkit.org/show_bug.cgi?id=196451
2339         <rdar://problem/49245471>
2340
2341         Reviewed by Geoffrey Garen.
2342
2343         Add API test coverage.
2344
2345         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2346         (TEST):
2347
2348 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2349
2350         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2351         https://bugs.webkit.org/show_bug.cgi?id=196449
2352
2353         Reviewed by Lucas Forschler.
2354
2355         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2356         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2357         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2358         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2359
2360 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2361
2362         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2363         https://bugs.webkit.org/show_bug.cgi?id=196444
2364
2365         Reviewed by Lucas Forschler.
2366
2367         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2368
2369 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2370
2371         Add SPI to canonicalize NSURLs with WTF::URL
2372         https://bugs.webkit.org/show_bug.cgi?id=196415
2373         <rdar://problem/44980271>
2374
2375         Reviewed by Darin Adler.
2376
2377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2378         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2379         (TestWebKitAPI::TEST):
2380
2381 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2382
2383         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2384         https://bugs.webkit.org/show_bug.cgi?id=196441
2385
2386         Reviewed by Carlos Garcia Campos.
2387
2388         Don't cache the wpe_view_backend object that might not exist yet at the
2389         time of EventSenderProxy constructor invocation, but instead retrieve
2390         that object whenever it's required for event dispatching. This should
2391         avoid crashes in this constructor now that it's invoked before any
2392         PlatformWindow has been set up (as changed in r243496).
2393
2394         * WebKitTestRunner/EventSenderProxy.h:
2395         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2396         (WTR::viewBackend):
2397         (WTR::EventSenderProxy::EventSenderProxy):
2398         (WTR::EventSenderProxy::mouseDown):
2399         (WTR::EventSenderProxy::mouseUp):
2400         (WTR::EventSenderProxy::mouseMoveTo):
2401         (WTR::EventSenderProxy::mouseScrollBy):
2402         (WTR::EventSenderProxy::keyDown):
2403         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2404
2405 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2406
2407         [Win][WebKit] MiniBrowser should support high DPI display
2408         https://bugs.webkit.org/show_bug.cgi?id=196391
2409
2410         Reviewed by Alex Christensen.
2411
2412         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2413         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2414         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2415         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2416
2417 2019-03-31  Sam Weinig  <weinig@apple.com>
2418
2419         Remove more i386 specific configurations
2420         https://bugs.webkit.org/show_bug.cgi?id=196430
2421
2422         Reviewed by Alexey Proskuryakov.
2423
2424         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2425         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2426
2427 2019-03-31  Andy Estes  <aestes@apple.com>
2428
2429         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2430         https://bugs.webkit.org/show_bug.cgi?id=196433
2431         <rdar://problem/49293305>
2432
2433         Reviewed by Tim Horton.
2434
2435         Enhanced API test coverage to include all navigation response policy decisions in both
2436         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2437
2438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2439         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2440         (TestWebKitAPI::TEST):
2441         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2442         (readFile):
2443         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2444         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2445         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2446         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2447         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2448         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2449         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2450         (-[QuickLookDelegate _downloadDidStart:]):
2451         (-[QuickLookDelegate _download:didReceiveResponse:]):
2452         (-[QuickLookDelegate _download:didReceiveData:]):
2453         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2454         (-[QuickLookDelegate _downloadDidFinish:]):
2455         (-[QuickLookDelegate _download:didFailWithError:]):
2456         (-[QuickLookDelegate _downloadDidCancel:]):
2457         (-[QuickLookDelegate verifyDownload]):
2458         (runTest):
2459         (runTestDecideBeforeLoading):
2460         (runTestDecideAfterLoading):
2461         (TEST):
2462         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2463         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2464         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2465         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2466         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2467         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
2468         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2469         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
2470         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
2471         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
2472         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
2473         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
2474         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
2475         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
2476
2477 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
2478
2479         [CMake] add testdfg as target with build-jsc
2480         https://bugs.webkit.org/show_bug.cgi?id=196393
2481
2482         Reviewed by Saam Barati.
2483
2484         Added testdfg as one of the targets to build when
2485         using CMake.
2486
2487         * Scripts/build-jsc:
2488
2489 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
2490
2491         Delete WebMetal implementation in favor of WebGPU
2492         https://bugs.webkit.org/show_bug.cgi?id=195418
2493
2494         Reviewed by Dean Jackson.
2495
2496         * DumpRenderTree/mac/DumpRenderTree.mm:
2497         (enableExperimentalFeatures):
2498         (resetWebPreferencesToConsistentValues):
2499         * Scripts/webkitperl/FeatureList.pm:
2500         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2502         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
2503         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
2504         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
2505         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
2506         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
2507         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
2508         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
2509         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2510         (WTR::InjectedBundle::beginTesting):
2511         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2512         (WTR::TestRunner::setWebMetalEnabled): Deleted.
2513         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2514
2515 2019-03-29  Chris Dumez  <cdumez@apple.com>
2516
2517         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
2518         https://bugs.webkit.org/show_bug.cgi?id=196405
2519         <rdar://problem/49428130>
2520
2521         Reviewed by Wenson Hsieh.
2522
2523         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
2524         the popover presentation methods to be no-ops. Use this in the new test added in
2525         r243523 so that we do not swizzle those methods for all tests. This is needed because
2526         those WatchOS tests rely on the popover getting presented and interactive.
2527
2528         * WebKitTestRunner/TestController.cpp:
2529         (WTR::updateTestOptionsFromTestHeader):
2530         * WebKitTestRunner/TestController.h:
2531         * WebKitTestRunner/TestOptions.h:
2532         (WTR::TestOptions::hasSameInitializationOptions const):
2533         * WebKitTestRunner/ios/TestControllerIOS.mm:
2534         (WTR::TestController::platformInitialize):
2535         (WTR::TestController::platformResetStateToConsistentValues):
2536
2537 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
2538
2539         [Curl] Add Server Trust Evaluation Support.
2540         https://bugs.webkit.org/show_bug.cgi?id=191646
2541
2542         Reviewed by Fujii Hironori.
2543
2544         Implemented MiniBrowser UI for asking if user trusts the server.
2545
2546         * MiniBrowser/win/Common.cpp:
2547         (askServerTrustEvaluation):
2548         (replaceString):
2549         * MiniBrowser/win/Common.h:
2550         * MiniBrowser/win/MiniBrowserLib.rc:
2551         * MiniBrowser/win/MiniBrowserLibResource.h:
2552         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2553         (createPEMString):
2554         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2555         (WebKitBrowserWindow::canTrustServerCertificate):
2556         * MiniBrowser/win/WebKitBrowserWindow.h:
2557
2558 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
2559
2560         Implement ResizeObserver.
2561         https://bugs.webkit.org/show_bug.cgi?id=157743
2562
2563         Reviewed by Simon Fraser.
2564
2565         Support resizeObserverEnabled webPreferences.
2566
2567         * DumpRenderTree/TestOptions.cpp:
2568         (TestOptions::TestOptions):
2569         * DumpRenderTree/TestOptions.h:
2570         * DumpRenderTree/mac/DumpRenderTree.mm:
2571         (setWebPreferencesForTestOptions):
2572         * DumpRenderTree/win/DumpRenderTree.cpp:
2573         (enableExperimentalFeatures):
2574         * Scripts/webkitperl/FeatureList.pm:
2575         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2576
2577 2019-03-28  John Wilander  <wilander@apple.com>
2578
2579         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
2580         https://bugs.webkit.org/show_bug.cgi?id=196281
2581         <rdar://problem/48938748>
2582
2583         Reviewed by Alex Christensen.
2584
2585         This patch adds the function isStatisticsHasLocalStorage() to the
2586         TestRunner. With it, the page can query the WebsiteDataStore in the
2587         UI process to make sure that it sees LocalStorage.
2588
2589         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2590         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2591         (WTR::TestRunner::isStatisticsHasLocalStorage):
2592         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2593         * WebKitTestRunner/TestController.cpp:
2594         (WTR::TestController::isStatisticsHasLocalStorage):
2595         * WebKitTestRunner/TestController.h:
2596         * WebKitTestRunner/TestInvocation.cpp:
2597         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2598
2599 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
2600
2601         API::Data::createWithoutCopying should do a null check before calling CFRelease
2602         https://bugs.webkit.org/show_bug.cgi?id=196276
2603         <rdar://problem/48059859>
2604
2605         Reviewed by Alex Christensen.
2606
2607         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
2608
2609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2610         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
2611         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
2612         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
2613         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2614         (TestWebKitAPI::TEST):
2615
2616 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2617
2618         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
2619         https://bugs.webkit.org/show_bug.cgi?id=186276
2620
2621         Reviewed by Carlos Garcia Campos.
2622
2623         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2624         (webViewLoadChanged):
2625         (testWebResourceGetDataError):
2626         (testWebResourceGetDataEmpty):
2627         (beforeAll):
2628         (webViewloadChanged): Deleted.
2629
2630 2019-03-27  Andy Estes  <aestes@apple.com>
2631
2632         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
2633         https://bugs.webkit.org/show_bug.cgi?id=196317
2634
2635         Reviewed by Dan Bernstein.
2636
2637         package-root copies built products into a staging directory using ditto(1), which does not
2638         follow symbolic links as it traverses a directory. Now that the files in
2639         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
2640         itself, these become broken links when ditto'd into the staging directory.
2641
2642         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
2643
2644         * Scripts/package-root:
2645
2646 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
2647
2648         [ews-app] Update display text of Submit for ews analysis
2649         https://bugs.webkit.org/show_bug.cgi?id=196309
2650
2651         Reviewed by Dewei Zhu.
2652
2653         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2654
2655 2019-03-27  David Kilzer  <ddkilzer@apple.com>
2656
2657         run-webkit-tests should check for leaks in WebKit processes
2658         <https://webkit.org/b/193772>
2659         <rdar://problem/46526680>
2660
2661         Reviewed by Ryosuke Niwa.
2662
2663         This works by doing the following:
2664         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
2665           The list of child processes are returned one per line:
2666           process.name: pid
2667         - Run the "#LIST CHILD PROCESSES" command just before the
2668           "#CHECK FOR WORLD LEAKS" command, and store the list of child
2669           processes on the ServerProcess object.
2670         - When the `--leaks` switch is handled, run check_for_leaks() on
2671           each child process after the main test harness.
2672
2673         * DumpRenderTree/mac/DumpRenderTree.mm:
2674         (handleControlCommand):
2675         - Use strncmp() instead of strcmp().
2676         - Add support for handling "#LIST CHILD PROCESSES" command.
2677
2678         * Scripts/webkitpy/port/base.py:
2679         (Port.check_for_leaks):
2680         * Scripts/webkitpy/port/darwin.py:
2681         (DarwinPort.check_for_leaks):
2682         - Rename redundant 'process_pid' argument to 'process_id'.
2683
2684         * Scripts/webkitpy/port/driver.py:
2685         (Driver.do_post_tests_work):
2686         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
2687           longer the only command this sends to WebKitTestRunner.
2688         - If the `--leaks` switch is present, send the
2689           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
2690           result using Port.set_webkit_processes().
2691         (Driver._parse_child_processes_output):
2692         - Add helper method to parse list of child process names and
2693           process IDs returned from WebKitTestRunner.
2694
2695         * Scripts/webkitpy/port/ios_device.py:
2696         (IOSDevicePort.check_for_leaks):
2697         - Rename redundant 'process_pid' argument to 'process_id'.
2698
2699         * Scripts/webkitpy/port/leakdetector.py:
2700         (LeakDetector._parse_leaks_output):
2701         - Return early if there is no leaks_output.
2702         (LeakDetector.check_for_leaks):
2703         - Rename redundant 'process_pid' argument to 'process_id'.
2704
2705         * Scripts/webkitpy/port/server_process.py:
2706         (ServerProcess.__init__):
2707         (ServerProcess.child_processes):
2708         (ServerProcess.set_child_processes):
2709         - Add instance variable to Port to store list of child process
2710           names and process IDs returned from WebKitTestRunner.
2711         (ServerProcess._start):
2712         - Clear self._child_processes.
2713         (ServerProcess.stop):
2714         - If self._child_processes is set, call
2715           self._port.check_for_leaks() for each child process.
2716
2717         * Scripts/webkitpy/port/server_process_unittest.py:
2718         (TrivialMockPort.check_for_leaks):
2719         - Rename redundant 'process_pid' argument to 'process_id'.
2720
2721         * Scripts/webkitpy/port/simulator_process.py:
2722         (SimulatorProcess.stop):
2723         - If self._child_processes is set, call
2724           self._port.check_for_leaks() for each child process.
2725
2726         * Scripts/webkitpy/port/watch_device.py:
2727         (WatchDevicePort.check_for_leaks):
2728         - Rename redundant 'process_pid' argument to 'process_id'.
2729
2730         * WebKitTestRunner/TestController.cpp:
2731         (WTR::TestController::dumpResponse):
2732         - Extract method from findAndDumpWorldLeaks() so that it may be
2733           reused by findAndDumpWebKitProcessIdentifiers().
2734         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2735         - Add method to output process name and process ID of both the
2736           WebContent and Networking processes.
2737         (WTR::TestController::findAndDumpWorldLeaks):
2738         - Fix missing newline in output when there were no abandoned
2739           documents.
2740         - Call dumpResponse() for extracted code.
2741         (WTR::TestController::handleControlCommand):
2742         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
2743         - Use strncmp() instead of strcmp().
2744         - Call findAndDumpWebKitProcessIdentifiers() when
2745           "#LIST CHILD PROCESSES" command is sent.
2746         * WebKitTestRunner/TestController.h:
2747         (WTR::TestController::dumpResponse):
2748         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
2749         - Declare methods.
2750
2751 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2752
2753         Unreviewed. Add GLib API test cases after r243434.
2754
2755         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2756         (testWebViewActiveURI):
2757         (serverCallback):
2758         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2759         (sendRequestCallback):
2760
2761 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2762
2763         Geolocation request not complete when watch request was started in a different web process
2764         https://bugs.webkit.org/show_bug.cgi?id=195996
2765
2766         Reviewed by Alex Christensen.
2767
2768         Add a test case.
2769
2770         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2771         (TestWebKitAPI::runJavaScriptAlert):
2772         (TestWebKitAPI::TEST):
2773
2774 2019-03-26  Keith Rollin  <krollin@apple.com>
2775
2776         Update the way generate-xcfilelists returns strings from functions
2777         https://bugs.webkit.org/show_bug.cgi?id=195975
2778         <rdar://problem/49040807>
2779
2780         Reviewed by Dean Jackson.
2781
2782         There are places where generate-xcfilelists executes assignments with
2783         statements like:
2784
2785             FOO=$(some_function)
2786
2787         where "some_function" return a string by echoing it. E.g.
2788
2789             some_function()
2790             {
2791                 echo "Hello, World"
2792             }
2793
2794         This is a common idiom, but it has a problem if "some_function" needs
2795         to call "exit" in an attempt to halt the entire script right then and
2796         there. Since "some_function" is called inside of $(), it's being
2797         executed in a sub-shell. Calling exit in that sub-shell simply exits
2798         that shell; it doesn't not exit the outer shell in which the main part
2799         of the script is still running. As such, the main script keeps
2800         executing when the intent was for the script to halt.
2801
2802         The solution to this is to use a different idiom for returning
2803         strings. The one we now is to pass in the name of the variable to
2804         receive the string result:
2805
2806             some_function()
2807             {
2808                 variable_name=$1
2809                 eval $variable_name ="Hello, World"
2810             }
2811
2812         The call site now looks like
2813
2814             some_function FOO
2815
2816         Because there's no invocation of a sub-shell, some_function can now
2817         call "exit" if it wants to, and the entire script will exit at that
2818         point.
2819
2820         * Scripts/generate-xcfilelists:
2821
2822 2019-03-26  Chris Dumez  <cdumez@apple.com>
2823
2824         Add basic layout test coverage for File Picker on iOS
2825         https://bugs.webkit.org/show_bug.cgi?id=196265
2826
2827         Reviewed by Wenson Hsieh.
2828
2829         Add layout test infrastructure to test the file picker on iOS.
2830
2831         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2832         (WTR::UIScriptController::dismissFilePicker):
2833         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2834         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2835         (WTR::UIScriptController::dismissFilePicker):
2836         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2837         * WebKitTestRunner/TestController.cpp:
2838         (WTR::TestController::createWebViewWithOptions):
2839         (WTR::updateTestOptionsFromTestHeader):
2840         * WebKitTestRunner/TestOptions.h:
2841         (WTR::TestOptions::hasSameInitializationOptions const):
2842         * WebKitTestRunner/ios/TestControllerIOS.mm:
2843         (overridePresentViewController):
2844         (WTR::TestController::platformInitialize):
2845         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2846         (WTR::UIScriptController::dismissFilePicker):
2847
2848 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2849
2850         Implement async paste method on UIWKInteractionViewProtocol
2851         https://bugs.webkit.org/show_bug.cgi?id=196267
2852         <rdar://problem/49236346>
2853
2854         Reviewed by Tim Horton.
2855
2856         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
2857         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
2858         are now a part of all iOS 12 internal SDKs.
2859
2860         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2861
2862         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
2863         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
2864
2865         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2866         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2867         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
2868         * TestWebKitAPI/ios/UIKitSPI.h:
2869
2870 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2871
2872         [ews-build] Use PostgreSQL for ews.webkit.org database
2873         https://bugs.webkit.org/show_bug.cgi?id=196270
2874
2875         Reviewed by Lucas Forschler.
2876
2877         * BuildSlaveSupport/ews-app/ews-app/settings.py:
2878
2879 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
2880
2881         [ews] Reset simctl states on reboot
2882         https://bugs.webkit.org/show_bug.cgi?id=196260
2883
2884         Rubber-stamped by Aakash Jain.
2885
2886         * EWSTools/start-queue-mac.sh:
2887
2888 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2889
2890         [ews-build] Use PostgreSQL for ews-build database
2891         https://bugs.webkit.org/show_bug.cgi?id=196229
2892
2893         Reviewed by Lucas Forschler.
2894
2895         * BuildSlaveSupport/ews-build/master.cfg:
2896
2897 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2898
2899         [ews-build] Get master_hostname dynamically in master.cfg
2900         https://bugs.webkit.org/show_bug.cgi?id=196255
2901
2902         Reviewed by Lucas Forschler.
2903
2904         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2905         send events data in test mode.
2906
2907 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2908
2909         [ews-app] Set db_constraint to False for Foreign Keys
2910         https://bugs.webkit.org/show_bug.cgi?id=196252
2911
2912         Reviewed by Lucas Forschler.
2913
2914         * BuildSlaveSupport/ews-app/ews/models/build.py:
2915         * BuildSlaveSupport/ews-app/ews/models/step.py:
2916
2917 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2918
2919         [ews-build] is_test_mode_enabled should default to True
2920         https://bugs.webkit.org/show_bug.cgi?id=196248
2921
2922         Reviewed by Lucas Forschler.
2923
2924         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2925
2926 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2927
2928         [ews-app] Add webkitperl to ENABLED_QUEUES
2929         https://bugs.webkit.org/show_bug.cgi?id=196253
2930
2931         Reviewed by Lucas Forschler.
2932
2933         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2934
2935 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2936
2937         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2938         https://bugs.webkit.org/show_bug.cgi?id=196211
2939         rdar://problem/49110552
2940
2941         Reviewed by Tim Horton.
2942
2943         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2944         Make sure that EventSenderProxy always exists when running tests. We used to create
2945         it when resetting before the first test, which is a bit too late.
2946
2947         * WebKitTestRunner/TestController.h:
2948         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2949         (WTR::TestController::platformCreateWebView):
2950         (WTR::TestController::platformCreateOtherPage):
2951         (WTR::TestController::finishCreatingPlatformWebView):
2952         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2953         (WTR::PlatformWebView::PlatformWebView):
2954         Moved some code that made NSWindow use NSEvent during web view creation. We may
2955         need to move more if some other case us found, but this is enough for now.
2956
2957 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2958
2959         Unreviewed. Fix typo in GLib geolocation API after r243285.
2960
2961         gelocation -> geolocation.
2962
2963         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2964         (testGeolocationManagerWatchPosition):
2965
2966 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2967
2968         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2969         https://bugs.webkit.org/show_bug.cgi?id=196213
2970
2971         Reviewed by Geoff Garen.
2972
2973         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2974         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2975         (credentialWithIdentityAndKeychainPath):
2976         (-[ChallengeDelegate webView:didFinishNavigation:]):
2977         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2978         (TestWebKitAPI::TEST):
2979
2980 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2981
2982         Expected shouldn't assume its contained types are copyable
2983         https://bugs.webkit.org/show_bug.cgi?id=195986
2984
2985         Reviewed by JF Bastien.
2986
2987         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2988         (TestWebKitAPI::NonCopyable::operator== const):
2989         (TestWebKitAPI::NonCopyable::operator!= const):
2990         (TestWebKitAPI::TEST):
2991
2992 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2993
2994         Remove some now-unnecessary dynamic class lookup
2995         https://bugs.webkit.org/show_bug.cgi?id=196237
2996
2997         Reviewed by Simon Fraser.
2998
2999         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3000         (makeRequest):
3001         (TEST):
3002
3003 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3004
3005         Unreviewed, rolling out r243450.
3006
3007         AppleWin and WinCairo port builds get broken.
3008
3009         Reverted changeset:
3010
3011         "Add test for fix of #196095"
3012         https://bugs.webkit.org/show_bug.cgi?id=196097
3013         https://trac.webkit.org/changeset/243450
3014
3015 2019-03-25  Commit Queue  <commit-queue@webkit.org>
3016
3017         Unreviewed, rolling out r243465.
3018         https://bugs.webkit.org/show_bug.cgi?id=196226
3019
3020         the test doesn't build (Requested by thorton on #webkit).
3021
3022         Reverted changeset:
3023
3024         "Do not terminate the NetworkProcess if a third party
3025         application sends a NSCredential with a SecIdentityRef"
3026         https://bugs.webkit.org/show_bug.cgi?id=196213
3027         https://trac.webkit.org/changeset/243465
3028
3029 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3030
3031         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3032         https://bugs.webkit.org/show_bug.cgi?id=196213
3033
3034         Reviewed by Geoff Garen.
3035
3036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3037         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3038         (credentialWithIdentityAndKeychainPath):
3039         (-[ChallengeDelegate webView:didFinishNavigation:]):
3040         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3041         (TestWebKitAPI::TEST):
3042
3043 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3044
3045         [ews-build] Gracefully handle missing patch_id in events
3046         https://bugs.webkit.org/show_bug.cgi?id=196216
3047
3048         Reviewed by Lucas Forschler.
3049
3050         * BuildSlaveSupport/ews-build/events.py:
3051
3052 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3053
3054         [ews-build] use lz4 compression for improving buildbot performance
3055         https://bugs.webkit.org/show_bug.cgi?id=196155
3056
3057         Reviewed by Lucas Forschler.
3058
3059         * BuildSlaveSupport/ews-build/master.cfg:
3060
3061 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3062
3063         Pull some API testing helper methods out of TestWKWebView
3064         https://bugs.webkit.org/show_bug.cgi?id=196212
3065
3066         Reviewed by Tim Horton.
3067
3068         Refactor some more API testing utility methods, so that they can be used in
3069         tests that do not use TestWKWebView.
3070
3071         * TestWebKitAPI/cocoa/TestWKWebView.h:
3072         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3073         (-[WKWebView loadTestPageNamed:]):
3074         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
3075         (-[WKWebView synchronouslyLoadHTMLString:]):
3076         (-[WKWebView synchronouslyLoadTestPageNamed:]):
3077         (-[TestWKWebView loadTestPageNamed:]): Deleted.
3078         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
3079         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
3080         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
3081
3082 2019-03-25  Jer Noble  <jer.noble@apple.com>
3083
3084         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3085         https://bugs.webkit.org/show_bug.cgi?id=196097
3086
3087         Reviewed by Eric Carlson.
3088
3089         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3090
3091         * DumpRenderTree/mac/DumpRenderTree.mm:
3092         (resetWebPreferencesToConsistentValues):
3093         * WebKitTestRunner/TestController.cpp:
3094         (WTR::TestController::resetPreferencesToConsistentValues):
3095
3096 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3097
3098         Pull IPadUserInterfaceSwizzler out into a separate header file
3099         https://bugs.webkit.org/show_bug.cgi?id=196193
3100
3101         Reviewed by Anders Carlsson.
3102
3103         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3104         be used in other API tests.
3105
3106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3107         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3108         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
3109         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
3110         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
3111         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3112         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3113
3114 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3115
3116         Remove NavigatorContentUtils in WebCore/Modules
3117         https://bugs.webkit.org/show_bug.cgi?id=196070
3118
3119         Reviewed by Alex Christensen.
3120
3121         NavigatorContentUtils was to support the custom scheme spec [1].
3122         However, in WebKit side, no port has supported the feature in
3123         WebKit layer after EFL port was removed. So there has been the
3124         only IDL implementation of the NavigatorContentUtils in WebCore.
3125         So we don't need to keep the implementation in WebCore anymore.
3126
3127         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
3128
3129         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3130
3131 2019-03-24  Andy Estes  <aestes@apple.com>
3132
3133         [watchOS] Remove unused Proximity Networking code
3134         https://bugs.webkit.org/show_bug.cgi?id=196188
3135
3136         Reviewed by Tim Horton.
3137
3138         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3139         (TEST):
3140
3141 2019-03-23  Keith Miller  <keith_miller@apple.com>
3142
3143         Refactor clz/ctz and fix getLSBSet.
3144         https://bugs.webkit.org/show_bug.cgi?id=196162
3145
3146         Reviewed by Saam Barati.
3147
3148         Add tests for clz, ctz, getLSBSet, and getMSBSet.
3149
3150         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3151         (TestWebKitAPI::TEST):
3152
3153 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3154
3155         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
3156         https://bugs.webkit.org/show_bug.cgi?id=196143
3157
3158         Reviewed by Michael Catanzaro.
3159
3160         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
3161         directories.
3162
3163         * Scripts/webkitpy/style/checkers/cpp.py:
3164         (check_identifier_name_in_declaration):
3165         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3166         (WebKitStyleTest.test_names):
3167
3168 2019-03-22  Philippe Normand  <pnormand@igalia.com>
3169
3170         [Flatpak] Manifest expanding fails for qt WPE extension
3171         https://bugs.webkit.org/show_bug.cgi?id=196148
3172
3173         Reviewed by Alex Christensen.
3174
3175         * flatpak/flatpakutils.py:
3176         (expand_submodules_recurse): The last recurse manifest expand
3177         iteration might lead to a single module so take it into account
3178         and don't try to recurse further.
3179
3180 2019-03-22  Chris Dumez  <cdumez@apple.com>
3181
3182         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
3183         https://bugs.webkit.org/show_bug.cgi?id=195348
3184         <rdar://problem/48622090>
3185
3186         Reviewed by Alex Christensen.
3187
3188         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
3189         to NO when test.options().shouldIgnoreMetaViewport is false.
3190
3191         * WebKitTestRunner/ios/TestControllerIOS.mm:
3192         (WTR::TestController::platformConfigureViewForTest):
3193
3194 2019-03-22  Chris Dumez  <cdumez@apple.com>
3195
3196         Prewarmed processes should be usable with any website data store
3197         https://bugs.webkit.org/show_bug.cgi?id=196104
3198
3199         Reviewed by Alex Christensen.
3200
3201         Add API test coverage.
3202
3203         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3204         (runInitialWarmedProcessUsedTest):
3205         (TEST):
3206
3207 2019-03-22  David Kilzer  <ddkilzer@apple.com>
3208
3209         Back out local changes to Alex's Subversion working directory
3210
3211         They were accidentally committed.
3212
3213         * Scripts/webkitpy/common/system/abstractexecutive.py:
3214         (AbstractExecutive.wait_newest):
3215         * Scripts/webkitpy/common/system/executive.py:
3216         (Executive.running_pids):
3217         * Scripts/webkitpy/common/system/executive_mock.py:
3218         (MockExecutive.running_pids):
3219         * Scripts/webkitpy/common/system/executive_unittest.py:
3220         (ExecutiveTest.serial_test_running_pids):
3221         * Scripts/webkitpy/port/darwin.py:
3222         (DarwinPort.check_for_leaks):
3223         * Scripts/webkitpy/port/leakdetector.py:
3224         (LeakDetector.check_for_leaks):
3225         - This was the hack attached to Bug 193772.
3226
3227         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
3228         (+[WebKitTestRunnerEvent mouseLocation]):
3229         - This works around a crash on an internal build.
3230
3231 2019-03-22  Tim Horton  <timothy_horton@apple.com>
3232
3233         Fix the build after r243354
3234         https://bugs.webkit.org/show_bug.cgi?id=196138
3235         <rdar://problem/49145951>
3236
3237         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3238         (TEST):
3239         * TestWebKitAPI/ios/UIKitSPI.h:
3240
3241 2019-03-21  Tim Horton  <timothy_horton@apple.com>
3242
3243         Adopt UIWKDocumentContext
3244         https://bugs.webkit.org/show_bug.cgi?id=196040
3245         <rdar://problem/48642440>
3246
3247         Reviewed by Ryosuke Niwa.
3248
3249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3250         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
3251         (makeRequest):
3252         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
3253         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
3254         (applyStyle):
3255         (TEST):
3256         Add tests for UIWKDocumentContext.
3257
3258         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
3259         (TEST):
3260         (recursiveFindWKContentView): Deleted.
3261         * TestWebKitAPI/cocoa/TestWKWebView.h:
3262         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3263         (recursiveFindWKContentView):
3264         (-[TestWKWebView wkContentView]):
3265         * TestWebKitAPI/ios/UIKitSPI.h:
3266         Share the WKContentView finding code between tests.
3267
3268 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
3269
3270         [iOS WK2] Turn on async overflow scrolling by default
3271         https://bugs.webkit.org/show_bug.cgi?id=196011
3272         rdar://problem/48453859
3273
3274         Reviewed by Antti Koivisto.
3275         
3276         Explicitly turn off the async overflow scrolling internal feature for tests by default,
3277         since so many basic layout tests have different results when compositing is triggered for
3278         overflow.
3279         
3280         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
3281
3282         * WebKitTestRunner/TestController.cpp:
3283         (WTR::TestController::resetPreferencesToConsistentValues):
3284
3285 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3286
3287         [ews-build] Retry API test in case of failures
3288         https://bugs.webkit.org/show_bug.cgi?id=196004
3289
3290         Reviewed by Lucas Forschler.
3291
3292         * BuildSlaveSupport/ews-build/steps.py:
3293         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
3294         (CompileWebKitToT.doStepIf): Ditto.
3295         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
3296         (ReRunAPITests): Re-run API tests.
3297         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
3298         (RunAPITestsWithoutPatch): Run API tests without patch.
3299         (RunAPITestsWithoutPatch.doStepIf):
3300         (RunAPITestsWithoutPatch.hideStepIf):
3301         (RunAPITestsWithoutPatch.evaluateCommand):
3302         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
3303         (AnalyzeAPITestsResults.start):
3304         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
3305         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
3306         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
3307         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
3308
3309 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3310
3311         [ews-build] Update queues configurations
3312         https://bugs.webkit.org/show_bug.cgi?id=196074
3313
3314         Reviewed by Dewei Zhu.
3315
3316         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
3317         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
3318
3319 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
3320
3321         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
3322         https://bugs.webkit.org/show_bug.cgi?id=195680
3323         <rdar://problem/48903534>
3324
3325         Unreviewed infrastructure fix.
3326
3327         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3328         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
3329
3330 2019-03-21  Andy Estes  <aestes@apple.com>
3331
3332         [iOS] Apple Pay should be available in documents with no user agent scripts
3333         https://bugs.webkit.org/show_bug.cgi?id=196061
3334         <rdar://problem/48649391>
3335
3336         Reviewed by Brady Eidson.
3337
3338         Added API tests and related infrastructure.
3339
3340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3341         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
3342         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
3343         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
3344         (TestWebKitAPI::TEST):
3345         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
3346         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
3347         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
3348         * TestWebKitAPI/cocoa/TestProtocol.mm:
3349         (-[TestProtocol startLoading]):
3350         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
3351         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
3352         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
3353         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
3354
3355 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
3356
3357         REGRESSSION (r243297): webkitpy tests broken
3358         https://bugs.webkit.org/show_bug.cgi?id=196108
3359
3360         Reviewed by Aakash Jain.
3361
3362         r243297 updated contributors.json, which broke a few unit tests.
3363
3364         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3365         (IRCCommandTest.test_whois):
3366         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3367
3368 2019-03-21  Chris Dumez  <cdumez@apple.com>
3369
3370         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
3371         https://bugs.webkit.org/show_bug.cgi?id=196041
3372         <rdar://problem/49083230>
3373
3374         Reviewed by Alex Christensen.
3375
3376         Add API test coverage.
3377
3378         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
3379         (TEST):
3380
3381 2019-03-21  Alex Christensen  <achristensen@webkit.org>
3382
3383         Add SPI to inform applications of WKContentRuleList actions
3384         https://bugs.webkit.org/show_bug.cgi?id=195965
3385         <rdar://problem/42664365>
3386
3387         Reviewed by Geoff Garen.
3388
3389         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3390         (TestWebKitAPI::allActionsForResourceLoad):
3391         (TestWebKitAPI::testRequest):
3392         (TestWebKitAPI::TEST_F):
3393         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
3394         (Notification::description):
3395         (Notification::operator== const):
3396         (toVector):
3397         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
3398         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
3399         (makeContentRuleList):
3400         (TEST):
3401         (makeWarnContentRuleList): Deleted.
3402
3403 2019-03-21  Timothy Hatcher  <timothy@apple.com>
3404
3405         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
3406         https://bugs.webkit.org/show_bug.cgi?id=196088
3407
3408         Reviewed by Brian Burg.
3409
3410         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
3411         Support checks when only one platform is specified. Also deprecate macosx() and
3412         force the use of macos() instead.
3413
3414         * Scripts/webkitpy/style/checkers/cpp.py:
3415         (check_min_versions_of_wk_api_available):
3416         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3417         (WebKitStyleTest.test_min_versions_of_wk_api_available):
3418
3419 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
3420
3421         Update status inactive committers' status to 'contributor'.
3422
3423         * Scripts/webkitpy/common/config/contributors.json:
3424
3425 2019-03-21  Xan Lopez  <xan@igalia.com>
3426
3427         [JSC][x86] Drop support for x87 floating point
3428         https://bugs.webkit.org/show_bug.cgi?id=194853
3429
3430         Reviewed by Don Olmstead.
3431
3432         Force SSE2 on x86/32bit builds.
3433
3434         * Scripts/webkitdirs.pm:
3435         (generateBuildSystemFromCMakeProject):
3436
3437 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3438
3439         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
3440         https://bugs.webkit.org/show_bug.cgi?id=196073
3441
3442         Reviewed by Michael Catanzaro.
3443
3444         Add test cases to check functions and constructors with no arguments but receiving user data.
3445
3446         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3447         (checkUserData):
3448         (testJSCFunction):
3449         (fooCreateWithUserData):
3450         (testJSCClass):
3451
3452 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3453
3454         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
3455
3456         Add g_assert_cmpfloat_with_epsilon macro if not defined.
3457
3458         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3459
3460 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3461
3462         [GTK][WPE] Add API to provide geolocation information
3463         https://bugs.webkit.org/show_bug.cgi?id=195940
3464
3465         Reviewed by Michael Catanzaro.
3466
3467         Add a new test to check the new API.
3468
3469         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
3470         (testGeolocationManagerCurrentPosition):
3471         (testGeolocationManagerWatchPosition):
3472         (beforeAll):
3473         (afterAll):
3474         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3475         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
3476         (beforeAll): Ditto.
3477         * TestWebKitAPI/glib/CMakeLists.txt:
3478
3479 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3480
3481         [GLib] Returning G_TYPE_OBJECT from a method does not work
3482         https://bugs.webkit.org/show_bug.cgi?id=195574
3483
3484         Reviewed by Michael Catanzaro.
3485
3486         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
3487
3488         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3489         (getGFile):
3490         (getParent):
3491         (createGString):
3492         (getGString):
3493         (getGStringCopyWillRaise):
3494         (getGStringCopy):
3495         (getGStringStr):
3496         (getGStringLen):
3497         (freeGString):
3498         (testJSCClass):
3499
3500 2019-03-20  Saam Barati  <sbarati@apple.com>
3501
3502         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
3503         https://bugs.webkit.org/show_bug.cgi?id=195721
3504
3505         Reviewed by Filip Pizlo.
3506
3507         * Scripts/run-javascriptcore-tests:
3508
3509 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
3510
3511         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
3512         https://bugs.webkit.org/show_bug.cgi?id=196049
3513
3514         Reviewed by Tim Horton.
3515
3516         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
3517         overflow scrolling in general, so rename it.
3518
3519         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3520
3521 2019-03-20  Daniel Bates  <dabates@apple.com>
3522
3523         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
3524         https://bugs.webkit.org/show_bug.cgi?id=196031
3525         <rdar://problem/49078172>
3526
3527         Reviewed by Tim Horton.
3528
3529         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
3530         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
3531         same code path used when the Done button is pressed to dismiss the <select> picker.
3532
3533         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
3534         (TestWebKitAPI::TEST):
3535
3536 2019-03-20  Chris Dumez  <cdumez@apple.com>
3537
3538         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
3539         https://bugs.webkit.org/show_bug.cgi?id=196029
3540         <rdar://problem/48954651>
3541
3542         Reviewed by Tim Horton.
3543
3544         Add API test coverage.
3545
3546         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3547
3548 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
3549
3550         [ews-build] Improve failure summary string for ApplyPatch step
3551         https://bugs.webkit.org/show_bug.cgi?id=195995
3552
3553         Reviewed by Alexey Proskuryakov.
3554
3555         * BuildSlaveSupport/ews-build/steps.py:
3556         (ApplyPatch.getResultSummary): Override getResultSummary.
3557
3558 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
3559
3560         AX: Implement support for new meter ARIA role
3561         https://bugs.webkit.org/show_bug.cgi?id=195966
3562
3563         Reviewed by Chris Fleizach.
3564
3565         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
3566         to AXLevelIndicator.
3567
3568         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3569
3570 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3571
3572         [WebAuthN] Implement FIDO AppID extension
3573         https://bugs.webkit.org/show_bug.cgi?id=143491
3574         <rdar://problem/48298273>
3575
3576         Reviewed by Brent Fulgham.
3577
3578         Add a test that covers the new flag of convertToU2fSignCommand.
3579
3580         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3581         (TestWebKitAPI::TEST):
3582         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3583         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
3584         (TestWebKitAPI::TEST):
3585
3586 2019-03-19  Keith Rollin  <krollin@apple.com>
3587
3588         Add support for more platforms to generate-xcfilelists
3589         https://bugs.webkit.org/show_bug.cgi?id=195977
3590
3591         Reviewed by Alexey Proskuryakov.
3592
3593         generate-xcfilelists incorrectly complains when involved with building
3594         WebKit for iphonesimulator:
3595
3596             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
3597             …
3598             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
3599
3600         Address this by teaching generate-xcfilelists about more platforms.
3601
3602         * Scripts/generate-xcfilelists:
3603
3604 2019-03-19  John Wilander  <wilander@apple.com>
3605
3606         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
3607         https://bugs.webkit.org/show_bug.cgi?id=195923
3608         <rdar://problem/49001272>
3609
3610         Reviewed by Alex Christensen.
3611
3612         This patch does the following to the TestRunner:
3613         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
3614         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
3615         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
3616
3617         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3618         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3619         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
3620         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3621         * WebKitTestRunner/TestController.cpp:
3622         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
3623         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
3624         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
3625         * WebKitTestRunner/TestController.h:
3626         * WebKitTestRunner/TestInvocation.cpp:
3627         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3628
3629 2019-03-19  Christopher Reid  <chris.reid@sony.com>
3630
3631         [CMake] Support more clang and gcc sanitizers
3632         https://bugs.webkit.org/show_bug.cgi?id=195956
3633
3634         Reviewed by Michael Catanzaro.
3635
3636         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
3637
3638 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3639
3640         [ews-build] Improve summary for PrintConfiguration step
3641         https://bugs.webkit.org/show_bug.cgi?id=195945
3642
3643         Reviewed by Lucas Forschler.
3644
3645         * BuildSlaveSupport/ews-build/steps.py:
3646         (PrintConfiguration.getResultSummary): Override getResultSummary.
3647
3648 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
3649
3650         [ews-build] Improve summary for CheckOutSource step
3651         https://bugs.webkit.org/show_bug.cgi?id=195963
3652
3653         Reviewed by Lucas Forschler.
3654
3655         * BuildSlaveSupport/ews-build/steps.py:
3656         (CheckOutSource.getResultSummary):
3657
3658 2019-03-19  Daniel Bates  <dabates@apple.com>
3659
3660         [iOS] Focus not preserved when switching between tabs
3661         https://bugs.webkit.org/show_bug.cgi?id=195820
3662         <rdar://problem/43614450>
3663
3664         Reviewed by Brent Fulgham.
3665
3666         Add tests to ensure that we restore focus when resigning and becoming first responder.
3667
3668         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3669         (TestWebKitAPI::TEST):
3670
3671 2019-03-19  Alex Christensen  <achristensen@webkit.org>
3672
3673         Make WTFLogChannelState and WTFLogLevel enum classes
3674         https://bugs.webkit.org/show_bug.cgi?id=195904
3675
3676         Reviewed by Eric Carlson.
3677
3678         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3679         (TestWebKitAPI::TEST_F):
3680
3681 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3682
3683         [GStreamer][EME] Backported mssdemux protection data crash fix
3684         https://bugs.webkit.org/show_bug.cgi?id=195918
3685
3686         Reviewed by Philippe Normand.
3687
3688         * gstreamer/jhbuild.modules:
3689         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
3690
3691 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3692
3693         Unreviewed, rolling out r243132.
3694
3695         Broke GTK build
3696
3697         Reverted changeset:
3698
3699         "Make WTFLogChannelState and WTFLogLevel enum classes"
3700         https://bugs.webkit.org/show_bug.cgi?id=195904
3701         https://trac.webkit.org/changeset/243132
3702
3703 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
3704
3705         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
3706
3707         * Scripts/webkitdirs.pm:
3708         (builtDylibPathForName): Adjust the shared library name that's changed
3709         with the API version bump in r243073.
3710
3711 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3712
3713         Make WTFLogChannelState and WTFLogLevel enum classes
3714         https://bugs.webkit.org/show_bug.cgi?id=195904
3715
3716         Reviewed by Eric Carlson.
3717
3718         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3719         (TestWebKitAPI::TEST_F):
3720
3721 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3722
3723         Disable flaky test added in r2431100
3724         https://webkit.org/b/195785
3725
3726         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3727         (TestWebKitAPI::TEST):
3728         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
3729
3730 2019-03-18  Timothy Hatcher  <timothy@apple.com>
3731
3732         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
3733         https://bugs.webkit.org/show_bug.cgi?id=195916
3734
3735         Reviewed by Tim Horton.
3736
3737         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3738         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
3739
3740 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
3741
3742         Add a secondary e-mail address for Fujii Hironori to make tools happier.
3743
3744         * Scripts/webkitpy/common/config/contributors.json:
3745
3746 2019-03-18  Alex Christensen  <achristensen@webkit.org>
3747
3748         Implement DownloadMonitor to prevent long-running slow downloads from background apps
3749         https://bugs.webkit.org/show_bug.cgi?id=195785
3750
3751         Reviewed by Geoffrey Garen.
3752
3753         * TestWebKitAPI/TCPServer.cpp: Added.
3754         (TestWebKitAPI::TCPServer::TCPServer):
3755         (TestWebKitAPI::TCPServer::~TCPServer):
3756         (TestWebKitAPI::TCPServer::socketBindListen):
3757         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
3758         * TestWebKitAPI/TCPServer.h: Added.
3759         (TestWebKitAPI::TCPServer::port const):
3760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3761         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3762         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
3763         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
3764         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3765         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
3766         (TestWebKitAPI::respondSlowly):
3767         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
3768         (TestWebKitAPI::downloadAtRate):
3769         (TestWebKitAPI::TEST):
3770
3771 2019-03-18  Saam Barati  <sbarati@apple.com>
3772
3773         Add a plan file for JetStream 2
3774         https://bugs.webkit.org/show_bug.cgi?id=190734
3775
3776         Reviewed by Mark Lam.
3777
3778         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
3779
3780 2019-03-18  Chris Dumez  <cdumez@apple.com>
3781
3782         Delay WebProcess launch until a load is triggered in a Web view
3783         https://bugs.webkit.org/show_bug.cgi?id=195758
3784         <rdar://problem/48126013>
3785
3786         Reviewed by Geoff Garen.
3787
3788         Add API test coverage. Also update some existing API tests to not expect
3789         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
3790
3791         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3792         (TestWebKitAPI::TEST):
3793         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
3794         (TestWebKitAPI::TEST):
3795         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3796         (TEST):
3797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3798         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3799         (TEST):
3800         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3801         (TEST):
3802         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
3803
3804 2019-03-18  Xan Lopez  <xan@igalia.com>
3805
3806         [CMake] Prevent potential warning when determining $architecture
3807         https://bugs.webkit.org/show_bug.cgi?id=195891
3808
3809         Reviewed by Michael Catanzaro.
3810
3811         It's possible for generateBuildSystemForCMakeProject to be called
3812         before determineArchitecture() is ever called. This will make the
3813         first eq check with $architecture to be bogus (and print a
3814         warning). Change that to an eq check with architecture(), which
3815         implicitly calls determineArchitecture() if needed, and change all
3816         the other similar cases in the method in the same way to prevent
3817         future bugs like this one.
3818
3819         * Scripts/webkitdirs.pm:
3820         (generateBuildSystemFromCMakeProject):
3821
3822 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3823
3824         [WPE] Tarballs generated with “make dist” cannot build documentation
3825         https://bugs.webkit.org/show_bug.cgi?id=195885
3826
3827         Reviewed by Carlos Garcia Campos.
3828
3829         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
3830
3831 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3832
3833         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
3834         https://bugs.webkit.org/show_bug.cgi?id=195883
3835
3836         Reviewed by Carlos Garcia Campos.
3837
3838         * gtkdoc/gtkdoc.py:
3839         (GTKDoc._run_command): When commands fail to run, include the full command line for
3840         the program invocation and the output it has generated on the standard error stream.
3841
3842 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
3843
3844         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
3845         https://bugs.webkit.org/show_bug.cgi?id=195786
3846
3847         Reviewed by Philippe Normand.
3848
3849         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
3850         * wpe/jhbuild.modules: Ditto.
3851
3852 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
3853
3854         [ews-build] Don't run clean builds on EWS builders
3855         https://bugs.webkit.org/show_bug.cgi?id=195851
3856
3857         Reviewed by Geoffrey Garen.
3858
3859         * BuildSlaveSupport/ews-build/factories.py:
3860
3861 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
3862
3863         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
3864         https://bugs.webkit.org/show_bug.cgi?id=195849
3865
3866         Reviewed by Chris Dumez.
3867
3868         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
3869
3870         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3871         (runWebsiteDataStoreCustomPaths):
3872
3873 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
3874
3875         webkitpy: Upload test results
3876         https://bugs.webkit.org/show_bug.cgi?id=195755
3877         <rdar://problem/48896182>
3878
3879         Reviewed by Aakash Jain.
3880
3881         Establish a new format for uploading results that is not tied to layout tests, apply
3882         that format to webkitpy tests.
3883
3884         * Scripts/webkitpy/common/checkout/scm/git.py:
3885         (Git.native_branch): Return what branch the current checkout is on.
3886         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3887         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3888         * Scripts/webkitpy/common/checkout/scm/svn.py:
3889         (SVN.native_branch): Ditto.
3890         * Scripts/webkitpy/common/system/platforminfo.py:
3891         (PlatformInfo.build_version): Return a build version for Mac.
3892         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3893         (MockPlatformInfo.__init__):
3894         (MockPlatformInfo.build_version):
3895         * Scripts/webkitpy/results: Added.
3896         * Scripts/webkitpy/results/__init__.py: Added.
3897         * Scripts/webkitpy/results/options.py: Added.
3898         (upload_options): OptParse list for upload options.
3899         * Scripts/webkitpy/results/upload.py: Added.
3900         (Upload): Class which enforces the upload format expected by the results server.
3901         (Upload.Expectations):
3902         (Upload.create_configuration):
3903         (Upload.create_commit):
3904         (Upload.create_details):
3905         (Upload.create_run_stats):
3906         (Upload.create_test_result):
3907         (Upload.__init__):
3908         (Upload.Encoder): Encode Upload object as json.
3909         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3910         * Scripts/webkitpy/results/upload_unittest.py: Added.
3911         * Scripts/webkitpy/test/main.py:
3912         (Tester._parse_args): Add upload arguments.
3913         (Tester._run_tests): Allow results to be uploaded.
3914         * Scripts/webkitpy/test/runner.py:
3915         (Runner.__init__): Record which tests were run, rather than just counting them.
3916         (Runner.handle):
3917         * Scripts/webkitpy/test/runner_unittest.py:
3918         (RunnerTest.test_run):
3919         * Scripts/webkitpy/thirdparty/__init__.py:
3920         (AutoinstallImportHook.find_module): Add requests auto-install.
3921         (AutoinstallImportHook._install_requests):
3922         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3923         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3924
3925 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3926
3927         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3928         https://bugs.webkit.org/show_bug.cgi?id=195810
3929
3930         Reviewed by Tim Horton.
3931
3932         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3933         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3934         ending certain layout tests.
3935
3936         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3937         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3938         (-[TestRunnerWKWebView dealloc]):
3939         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3940
3941         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3942         helper method when destroying the web view, and when resetting state between tests.
3943
3944         * WebKitTestRunner/ios/TestControllerIOS.mm:
3945         (WTR::TestController::platformResetStateToConsistentValues):
3946
3947         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3948
3949 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3950
3951         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3952         https://bugs.webkit.org/show_bug.cgi?id=190350
3953         <rdar://problem/45089503>
3954
3955         Reviewed by Geoffrey Garen.
3956
3957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3958         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3959         (TEST):
3960         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3961         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3962         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3963         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3964         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3965         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3966         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3967         (runTest):
3968         (createDirectories):
3969         (TEST):
3970         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3971         (TEST):
3972         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3973         (TEST):
3974
3975 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3976
3977         Add support to WebPage for getting the contents as an attributed string.
3978         https://bugs.webkit.org/show_bug.cgi?id=195636
3979         rdar://problem/45055697
3980
3981         Reviewed by Tim Horton.
3982
3983         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3984         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3985
3986 2019-03-15  Chris Dumez  <cdumez@apple.com>
3987
3988         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3989         https://bugs.webkit.org/show_bug.cgi?id=195747
3990
3991         Reviewed by Geoff Garen.
3992
3993         Add API test coverage.
3994
3995         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3996
3997 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3998
3999         Unreviewed, rolling out r242952.
4000
4001         Causing API failures on iOS Simulator
4002
4003         Reverted changeset:
4004
4005         "[PSON] Make sure the WebProcessCache is leverage when
4006         relaunching a process after termination"
4007         https://bugs.webkit.org/show_bug.cgi?id=195747
4008         https://trac.webkit.org/changeset/242952
4009
4010 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
4011
4012         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
4013         https://bugs.webkit.org/show_bug.cgi?id=195740
4014
4015         Reviewed by Ross Kirsling.
4016
4017         window.open doesn't work for WebKitBrowserWindow because it is not
4018         implemented yet.
4019
4020         1. Implemented createNewPage callback of WKPageUIClient.
4021         2. Changed MainWindow to take a BrowserWindow factory function
4022           instead of BrowserWindowType to be flexible to create
4023           BrowserWindow with extra settings.
4024         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
4025           because it is not relevant with MainWindow anymore.
4026
4027         * MiniBrowser/win/Common.cpp:
4028         (parseCommandLine):
4029         * MiniBrowser/win/Common.h:
4030         (CommandLineOptions::CommandLineOptions):
4031         * MiniBrowser/win/MainWindow.cpp:
4032         (MainWindow::MainWindow):
4033         (MainWindow::create):
4034         (MainWindow::init):
4035         (MainWindow::WndProc):
4036         * MiniBrowser/win/MainWindow.h:
4037         * MiniBrowser/win/PrintWebUIDelegate.cpp:
4038         (PrintWebUIDelegate::createWebViewWithRequest):
4039         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4040         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
4041         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
4042         (WebKitBrowserWindow::updateProxySettings):
4043         (WebKitBrowserWindow::createNewPage):
4044         * MiniBrowser/win/WebKitBrowserWindow.h:
4045         * MiniBrowser/win/WinMain.cpp:
4046         (wWinMain):
4047
4048 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
4049
4050         Make it possible to test scrolling tree layer manipulation more easily
4051         https://bugs.webkit.org/show_bug.cgi?id=195780
4052
4053         Reviewed by Tim Horton.
4054         
4055         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
4056         cuts off communication of scrolling tree scrolls back to the web process
4057         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
4058         allows tests to trigger scrolls which run the scrolling tree layer positioning
4059         logic, but never get another commit from the web process that might mask
4060         scrolling tree bugs.
4061         
4062         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
4063         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
4064         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
4065
4066         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4067         (WTR::UIScriptController::scrollUpdatesDisabled const):
4068         (WTR::UIScriptController::setScrollUpdatesDisabled):
4069         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4070         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4071         (WTR::UIScriptController::scrollUpdatesDisabled const):
4072         (WTR::UIScriptController::setScrollUpdatesDisabled):
4073         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4074         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4075         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4076         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
4077         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
4078         * WebKitTestRunner/ios/TestControllerIOS.mm:
4079         (WTR::TestController::platformResetStateToConsistentValues):
4080         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4081         (WTR::UIScriptController::scrollUpdatesDisabled const):
4082         (WTR::UIScriptController::setScrollUpdatesDisabled):
4083
4084 2019-03-14  Youenn Fablet  <youenn@apple.com>
4085
4086         Move IDB storage in private browsing mode to NetworkProcess
4087         https://bugs.webkit.org/show_bug.cgi?id=195602
4088
4089         Reviewed by Brady Eidson.
4090
4091         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
4092         (TEST):
4093
4094 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4095
4096         [ews-build] Make descriptionDone messages more readable
4097         https://bugs.webkit.org/show_bug.cgi?id=195760
4098
4099         Reviewed by Lucas Forschler.
4100
4101         * BuildSlaveSupport/ews-build/steps.py:
4102         * BuildSlaveSupport/ews-build/steps_unittest.py:
4103
4104 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4105
4106         [ews-build] Generate status-bubble hover-over messages
4107         https://bugs.webkit.org/show_bug.cgi?id=195680
4108
4109         Reviewed by Lucas Forschler.
4110
4111         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4112         (StatusBubble):
4113         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
4114         on hover-over.
4115         (StatusBubble._iso_time):
4116         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
4117         hover-over message.
4118         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
4119
4120 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4121
4122         [ews-app] Gracefully handle the case when state_string is None
4123         https://bugs.webkit.org/show_bug.cgi?id=195753
4124
4125         Reviewed by Lucas Forschler.
4126
4127         * BuildSlaveSupport/ews-app/ews/models/build.py:
4128         * BuildSlaveSupport/ews-app/ews/models/step.py:
4129
4130 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
4131
4132         [ews-app] Status bubble display pending for currently running build step
4133         https://bugs.webkit.org/show_bug.cgi?id=195744
4134
4135         Reviewed by Lucas Forschler.
4136
4137         * BuildSlaveSupport/ews-build/events.py:
4138         (Events.stepStarted): If state_string is pending, replace it with step name.
4139
4140 2019-03-14  Chris Dumez  <cdumez@apple.com>
4141
4142         Add WebsitePolicy for the client to specify the device orientation & motion access policy
4143         https://bugs.webkit.org/show_bug.cgi?id=195750
4144
4145         Reviewed by Geoffrey Garen.
4146
4147         Add API test coverage.
4148
4149         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4150         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
4151         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4152         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4153
4154 2019-03-14  Chris Dumez  <cdumez@apple.com>
4155
4156         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
4157         https://bugs.webkit.org/show_bug.cgi?id=195747
4158
4159         Reviewed by Geoff Garen.
4160
4161         Add API test coverage.
4162
4163         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4164
4165 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4166
4167         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
4168         https://bugs.webkit.org/show_bug.cgi?id=195725
4169         <rdar://problem/48545062>
4170
4171         Reviewed by Tim Horton.
4172
4173         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
4174         handler is nil.
4175
4176         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4177         (TestWebKitAPI::TEST):
4178
4179 2019-03-13  Sam Weinig  <sam@webkit.org>
4180
4181         Add utility function to allow easy reverse range-based iteration of a container
4182         https://bugs.webkit.org/show_bug.cgi?id=195542
4183
4184         Reviewed by Antti Koivisto.
4185
4186         * TestWebKitAPI/CMakeLists.txt:
4187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4188         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
4189         (TestWebKitAPI::TEST):
4190         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
4191
4192 2019-03-13  Chris Dumez  <cdumez@apple.com>
4193
4194         Use a ServiceWorker process per registrable domain
4195         https://bugs.webkit.org/show_bug.cgi?id=195649
4196
4197         Reviewed by Youenn Fablet.
4198
4199         Update API test coverage.
4200
4201         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4202
4203 2019-03-13  Chris Dumez  <cdumez@apple.com>
4204
4205         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
4206         https://bugs.webkit.org/show_bug.cgi?id=195684
4207         <rdar://problem/48294714>
4208
4209         Reviewed by Antti Koivisto.
4210
4211         Add API test coverage.
4212
4213         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4214
4215 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4216
4217         [ews-app] Remove unused patch view
4218         https://bugs.webkit.org/show_bug.cgi?id=195669
4219
4220         Reviewed by Lucas Forschler.
4221
4222         * BuildSlaveSupport/ews-app/ews/urls.py:
4223         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
4224
4225 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4226
4227         [ews-app] Use Buildbot result code variables
4228         https://bugs.webkit.org/show_bug.cgi?id=195668
4229
4230         Reviewed by Alexey Proskuryakov.
4231
4232         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
4233         (Buildbot): Added Buildbot result code variables.
4234         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4235         (StatusBubble._build_bubble): Used Buildbot result code variables.
4236
4237 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
4238
4239         [Flatpak] Expand submodule recursively
4240         https://bugs.webkit.org/show_bug.cgi?id=195672
4241
4242         Building WPE with flatpak was impossible without that as it was raising an exception.
4243         Also update wpebackend-fdo to match what is built in jhbuild
4244
4245         Reviewed by Philippe Normand.
4246
4247         * flatpak/flatpakutils.py:
4248         (expand_submodules_recurse):
4249         (expand_manifest):
4250         * flatpak/org.webkit.WPEModules.yaml:
4251
4252 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
4253
4254         [ews-app] status bubble should be hidden for certain builds
4255         https://bugs.webkit.org/show_bug.cgi?id=194597
4256
4257         Reviewed by Dewei Zhu.
4258
4259         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4260         (StatusBubble._build_bubble):
4261         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
4262         because the patch didn't have relevant changes.
4263         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
4264         in production yet.
4265
4266 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
4267
4268         [Win] Fix a slew of simple clang-cl warnings.
4269         https://bugs.webkit.org/show_bug.cgi?id=195652
4270
4271         Reviewed by Don Olmstead.
4272
4273         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4274         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
4275
4276 2019-03-12  Justin Fan  <justin_fan@apple.com>
4277
4278         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
4279         https://bugs.webkit.org/show_bug.cgi?id=195518
4280         <rdar://problem/46322356>
4281
4282         Reviewed by Myles C. Maxfield.
4283
4284         * DumpRenderTree/DerivedSources-input.xcfilelist:
4285         * DumpRenderTree/DerivedSources-output.xcfilelist:
4286
4287 2019-03-12  Commit Queue  <commit-queue@webkit.org>
4288
4289         Unreviewed, rolling out r242825.
4290         https://bugs.webkit.org/show_bug.cgi?id=195648
4291
4292         "Broke webkitpy tests with my change to
4293         lldb_dump_class_layout.py" (Requested by rmorisset on
4294         #webkit).
4295
4296         Reverted changeset:
4297
4298         "Alter Tools/Scripts/dump-class-layout to be able to dump all
4299         classes with suspicious padding"
4300         https://bugs.webkit.org/show_bug.cgi?id=195573
4301         https://trac.webkit.org/changeset/242825
4302
4303 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
4304
4305         [ews-build] Show status bubbles while the patch is waiting in queue
4306         https://bugs.webkit.org/show_bug.cgi?id=195618
4307
4308         Reviewed by Lucas Forschler.
4309
4310         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4311         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
4312         enabled in initial deployment.
4313         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
4314         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
4315         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
4316         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
4317         (StatusBubble._build_bubbles_for_patch):
4318
4319 2019-03-12  Robin Morisset  <rmorisset@apple.com>
4320
4321         Alter Tools/Scripts/dump-class-layout to be&nbs