[ews-app] Status bubble hover over message should clearly indicate that build is...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2
3         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
4         https://bugs.webkit.org/show_bug.cgi?id=196491
5
6         Reviewed by Lucas Forschler.
7
8         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
9
10 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
11
12         [ews-build] Configure buildbot try credentials in environment variables
13         https://bugs.webkit.org/show_bug.cgi?id=196501
14
15         Reviewed by Lucas Forschler.
16
17         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
18         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
19         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
20
21 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
22
23         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
24         https://bugs.webkit.org/show_bug.cgi?id=196496
25         <rdar://problem/49521634>
26
27         Reviewed by Chris Dumez.
28
29         Add new API tests (see WebKit ChangeLog for more detail).
30
31         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
32         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
33         (TEST):
34
35 2019-04-02  David Kilzer  <ddkilzer@apple.com>
36
37         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
38         <https://webkit.org/b/196499>
39
40         Reviewed by Alexey Proskuryakov.
41
42         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
43         ENABLE_ADDRESS_SANITIZER.
44
45 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
46
47         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
48         https://bugs.webkit.org/show_bug.cgi?id=182757
49
50         Reviewed by Don Olmstead.
51
52         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
53         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
54
55 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
56
57         run-api-tests: Upload test results
58         https://bugs.webkit.org/show_bug.cgi?id=196323
59         <rdar://problem/49356714>
60
61         Reviewed by Lucas Forschler.
62
63         * Scripts/webkitpy/api_tests/manager.py:
64         (Manager):
65         (Manager.run): Upload results to a results database.
66         * Scripts/webkitpy/api_tests/run_api_tests.py:
67         (parse_args): Add upload arguments.
68         * Scripts/webkitpy/port/base.py:
69         (Port):
70         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
71         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
72         with commits from any other associated repositories.
73         * Scripts/webkitpy/port/device.py:
74         (Device):
75         (Device.build_version): Access build_versoin of underlying platform device.
76         * Scripts/webkitpy/port/ios_simulator_unittest.py:
77         (IOSSimulatorTest):
78         (IOSSimulatorTest.test_configuration_for_upload):
79         * Scripts/webkitpy/port/device_port.py:
80         (DevicePort):
81         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
82         the same as the machine uploading results.
83         * Scripts/webkitpy/port/mac.py:
84         (MacPort):
85         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
86         * Scripts/webkitpy/port/mac_unittest.py:
87         (MacTest):
88         (MacTest.test_configuration_for_upload):
89         * Scripts/webkitpy/xcode/simulated_device.py:
90         (SimulatedDeviceManager._create_device_with_runtime):
91         (SimulatedDevice.__init__): Create simulated device with a build_version.
92         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
93         (test_existing_simulator):
94
95 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
96
97         Remove extra newline characters (Follow-up fix to r243707)
98
99         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
100
101 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
102
103         [ews-app] Use API_KEY to accept results data
104         https://bugs.webkit.org/show_bug.cgi?id=196461
105
106         Reviewed by Dewei Zhu.
107
108         * BuildSlaveSupport/ews-app/ews/views/results.py:
109         (Results.post): Validate EWS_API_KEY before accepting any data.
110         * BuildSlaveSupport/ews-build/events.py:
111         (Events.sendData): Send EWS_API_KEY if available along with event data.
112
113 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
114
115         Unable to copy and paste a PDF from Notes into Mail compose body
116         https://bugs.webkit.org/show_bug.cgi?id=196442
117         <rdar://problem/48573098>
118
119         Reviewed by Tim Horton.
120
121         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
122         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
123         to be specified on the item providers.
124
125         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
126         (TestWebKitAPI::mapItemForTesting):
127         (TestWebKitAPI::contactItemForTesting):
128
129 2019-04-01  Tim Horton  <timothy_horton@apple.com>
130
131         Make UIWKDocumentContext rects per-character instead of per-word
132         https://bugs.webkit.org/show_bug.cgi?id=196459
133
134         Reviewed by Wenson Hsieh.
135
136         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
137         (TEST):
138         Adjust test results due to switching to per-character rects.
139
140 2019-04-01  Chris Dumez  <cdumez@apple.com>
141
142         UIProcess crash when a prewarmed process is terminated
143         https://bugs.webkit.org/show_bug.cgi?id=196451
144         <rdar://problem/49245471>
145
146         Reviewed by Geoffrey Garen.
147
148         Add API test coverage.
149
150         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
151         (TEST):
152
153 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
154
155         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
156         https://bugs.webkit.org/show_bug.cgi?id=196449
157
158         Reviewed by Lucas Forschler.
159
160         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
161         (StatusBubble.get_os_details): Method to get OS and Xcode details.
162         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
163         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
164
165 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
166
167         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
168         https://bugs.webkit.org/show_bug.cgi?id=196444
169
170         Reviewed by Lucas Forschler.
171
172         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
173
174 2019-04-01  Alex Christensen  <achristensen@webkit.org>
175
176         Add SPI to canonicalize NSURLs with WTF::URL
177         https://bugs.webkit.org/show_bug.cgi?id=196415
178         <rdar://problem/44980271>
179
180         Reviewed by Darin Adler.
181
182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
183         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
184         (TestWebKitAPI::TEST):
185
186 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
187
188         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
189         https://bugs.webkit.org/show_bug.cgi?id=196441
190
191         Reviewed by Carlos Garcia Campos.
192
193         Don't cache the wpe_view_backend object that might not exist yet at the
194         time of EventSenderProxy constructor invocation, but instead retrieve
195         that object whenever it's required for event dispatching. This should
196         avoid crashes in this constructor now that it's invoked before any
197         PlatformWindow has been set up (as changed in r243496).
198
199         * WebKitTestRunner/EventSenderProxy.h:
200         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
201         (WTR::viewBackend):
202         (WTR::EventSenderProxy::EventSenderProxy):
203         (WTR::EventSenderProxy::mouseDown):
204         (WTR::EventSenderProxy::mouseUp):
205         (WTR::EventSenderProxy::mouseMoveTo):
206         (WTR::EventSenderProxy::mouseScrollBy):
207         (WTR::EventSenderProxy::keyDown):
208         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
209
210 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
211
212         [Win][WebKit] MiniBrowser should support high DPI display
213         https://bugs.webkit.org/show_bug.cgi?id=196391
214
215         Reviewed by Alex Christensen.
216
217         * MiniBrowser/win/WebKitBrowserWindow.cpp:
218         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
219         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
220         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
221
222 2019-03-31  Sam Weinig  <weinig@apple.com>
223
224         Remove more i386 specific configurations
225         https://bugs.webkit.org/show_bug.cgi?id=196430
226
227         Reviewed by Alexey Proskuryakov.
228
229         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
230         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
231
232 2019-03-31  Andy Estes  <aestes@apple.com>
233
234         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
235         https://bugs.webkit.org/show_bug.cgi?id=196433
236         <rdar://problem/49293305>
237
238         Reviewed by Tim Horton.
239
240         Enhanced API test coverage to include all navigation response policy decisions in both
241         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
242
243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
244         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
245         (TestWebKitAPI::TEST):
246         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
247         (readFile):
248         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
249         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
250         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
251         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
252         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
253         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
254         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
255         (-[QuickLookDelegate _downloadDidStart:]):
256         (-[QuickLookDelegate _download:didReceiveResponse:]):
257         (-[QuickLookDelegate _download:didReceiveData:]):
258         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
259         (-[QuickLookDelegate _downloadDidFinish:]):
260         (-[QuickLookDelegate _download:didFailWithError:]):
261         (-[QuickLookDelegate _downloadDidCancel:]):
262         (-[QuickLookDelegate verifyDownload]):
263         (runTest):
264         (runTestDecideBeforeLoading):
265         (runTestDecideAfterLoading):
266         (TEST):
267         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
268         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
269         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
270         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
271         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
272         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
273         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
274         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
275         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
276         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
277         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
278         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
279         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
280         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
281
282 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
283
284         [CMake] add testdfg as target with build-jsc
285         https://bugs.webkit.org/show_bug.cgi?id=196393
286
287         Reviewed by Saam Barati.
288
289         Added testdfg as one of the targets to build when
290         using CMake.
291
292         * Scripts/build-jsc:
293
294 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
295
296         Delete WebMetal implementation in favor of WebGPU
297         https://bugs.webkit.org/show_bug.cgi?id=195418
298
299         Reviewed by Dean Jackson.
300
301         * DumpRenderTree/mac/DumpRenderTree.mm:
302         (enableExperimentalFeatures):
303         (resetWebPreferencesToConsistentValues):
304         * Scripts/webkitperl/FeatureList.pm:
305         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
307         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
308         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
309         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
310         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
311         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
312         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
313         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
314         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
315         (WTR::InjectedBundle::beginTesting):
316         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
317         (WTR::TestRunner::setWebMetalEnabled): Deleted.
318         * WebKitTestRunner/InjectedBundle/TestRunner.h:
319
320 2019-03-29  Chris Dumez  <cdumez@apple.com>
321
322         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
323         https://bugs.webkit.org/show_bug.cgi?id=196405
324         <rdar://problem/49428130>
325
326         Reviewed by Wenson Hsieh.
327
328         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
329         the popover presentation methods to be no-ops. Use this in the new test added in
330         r243523 so that we do not swizzle those methods for all tests. This is needed because
331         those WatchOS tests rely on the popover getting presented and interactive.
332
333         * WebKitTestRunner/TestController.cpp:
334         (WTR::updateTestOptionsFromTestHeader):
335         * WebKitTestRunner/TestController.h:
336         * WebKitTestRunner/TestOptions.h:
337         (WTR::TestOptions::hasSameInitializationOptions const):
338         * WebKitTestRunner/ios/TestControllerIOS.mm:
339         (WTR::TestController::platformInitialize):
340         (WTR::TestController::platformResetStateToConsistentValues):
341
342 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
343
344         [Curl] Add Server Trust Evaluation Support.
345         https://bugs.webkit.org/show_bug.cgi?id=191646
346
347         Reviewed by Fujii Hironori.
348
349         Implemented MiniBrowser UI for asking if user trusts the server.
350
351         * MiniBrowser/win/Common.cpp:
352         (askServerTrustEvaluation):
353         (replaceString):
354         * MiniBrowser/win/Common.h:
355         * MiniBrowser/win/MiniBrowserLib.rc:
356         * MiniBrowser/win/MiniBrowserLibResource.h:
357         * MiniBrowser/win/WebKitBrowserWindow.cpp:
358         (createPEMString):
359         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
360         (WebKitBrowserWindow::canTrustServerCertificate):
361         * MiniBrowser/win/WebKitBrowserWindow.h:
362
363 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
364
365         Implement ResizeObserver.
366         https://bugs.webkit.org/show_bug.cgi?id=157743
367
368         Reviewed by Simon Fraser.
369
370         Support resizeObserverEnabled webPreferences.
371
372         * DumpRenderTree/TestOptions.cpp:
373         (TestOptions::TestOptions):
374         * DumpRenderTree/TestOptions.h:
375         * DumpRenderTree/mac/DumpRenderTree.mm:
376         (setWebPreferencesForTestOptions):
377         * DumpRenderTree/win/DumpRenderTree.cpp:
378         (enableExperimentalFeatures):
379         * Scripts/webkitperl/FeatureList.pm:
380         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
381
382 2019-03-28  John Wilander  <wilander@apple.com>
383
384         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
385         https://bugs.webkit.org/show_bug.cgi?id=196281
386         <rdar://problem/48938748>
387
388         Reviewed by Alex Christensen.
389
390         This patch adds the function isStatisticsHasLocalStorage() to the
391         TestRunner. With it, the page can query the WebsiteDataStore in the
392         UI process to make sure that it sees LocalStorage.
393
394         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
395         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
396         (WTR::TestRunner::isStatisticsHasLocalStorage):
397         * WebKitTestRunner/InjectedBundle/TestRunner.h:
398         * WebKitTestRunner/TestController.cpp:
399         (WTR::TestController::isStatisticsHasLocalStorage):
400         * WebKitTestRunner/TestController.h:
401         * WebKitTestRunner/TestInvocation.cpp:
402         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
403
404 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
405
406         API::Data::createWithoutCopying should do a null check before calling CFRelease
407         https://bugs.webkit.org/show_bug.cgi?id=196276
408         <rdar://problem/48059859>
409
410         Reviewed by Alex Christensen.
411
412         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
413
414         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
415         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
416         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
417         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
418         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
419         (TestWebKitAPI::TEST):
420
421 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
422
423         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
424         https://bugs.webkit.org/show_bug.cgi?id=186276
425
426         Reviewed by Carlos Garcia Campos.
427
428         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
429         (webViewLoadChanged):
430         (testWebResourceGetDataError):
431         (testWebResourceGetDataEmpty):
432         (beforeAll):
433         (webViewloadChanged): Deleted.
434
435 2019-03-27  Andy Estes  <aestes@apple.com>
436
437         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
438         https://bugs.webkit.org/show_bug.cgi?id=196317
439
440         Reviewed by Dan Bernstein.
441
442         package-root copies built products into a staging directory using ditto(1), which does not
443         follow symbolic links as it traverses a directory. Now that the files in
444         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
445         itself, these become broken links when ditto'd into the staging directory.
446
447         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
448
449         * Scripts/package-root:
450
451 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
452
453         [ews-app] Update display text of Submit for ews analysis
454         https://bugs.webkit.org/show_bug.cgi?id=196309
455
456         Reviewed by Dewei Zhu.
457
458         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
459
460 2019-03-27  David Kilzer  <ddkilzer@apple.com>
461
462         run-webkit-tests should check for leaks in WebKit processes
463         <https://webkit.org/b/193772>
464         <rdar://problem/46526680>
465
466         Reviewed by Ryosuke Niwa.
467
468         This works by doing the following:
469         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
470           The list of child processes are returned one per line:
471           process.name: pid
472         - Run the "#LIST CHILD PROCESSES" command just before the
473           "#CHECK FOR WORLD LEAKS" command, and store the list of child
474           processes on the ServerProcess object.
475         - When the `--leaks` switch is handled, run check_for_leaks() on
476           each child process after the main test harness.
477
478         * DumpRenderTree/mac/DumpRenderTree.mm:
479         (handleControlCommand):
480         - Use strncmp() instead of strcmp().
481         - Add support for handling "#LIST CHILD PROCESSES" command.
482
483         * Scripts/webkitpy/port/base.py:
484         (Port.check_for_leaks):
485         * Scripts/webkitpy/port/darwin.py:
486         (DarwinPort.check_for_leaks):
487         - Rename redundant 'process_pid' argument to 'process_id'.
488
489         * Scripts/webkitpy/port/driver.py:
490         (Driver.do_post_tests_work):
491         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
492           longer the only command this sends to WebKitTestRunner.
493         - If the `--leaks` switch is present, send the
494           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
495           result using Port.set_webkit_processes().
496         (Driver._parse_child_processes_output):
497         - Add helper method to parse list of child process names and
498           process IDs returned from WebKitTestRunner.
499
500         * Scripts/webkitpy/port/ios_device.py:
501         (IOSDevicePort.check_for_leaks):
502         - Rename redundant 'process_pid' argument to 'process_id'.
503
504         * Scripts/webkitpy/port/leakdetector.py:
505         (LeakDetector._parse_leaks_output):
506         - Return early if there is no leaks_output.
507         (LeakDetector.check_for_leaks):
508         - Rename redundant 'process_pid' argument to 'process_id'.
509
510         * Scripts/webkitpy/port/server_process.py:
511         (ServerProcess.__init__):
512         (ServerProcess.child_processes):
513         (ServerProcess.set_child_processes):
514         - Add instance variable to Port to store list of child process
515           names and process IDs returned from WebKitTestRunner.
516         (ServerProcess._start):
517         - Clear self._child_processes.
518         (ServerProcess.stop):
519         - If self._child_processes is set, call
520           self._port.check_for_leaks() for each child process.
521
522         * Scripts/webkitpy/port/server_process_unittest.py:
523         (TrivialMockPort.check_for_leaks):
524         - Rename redundant 'process_pid' argument to 'process_id'.
525
526         * Scripts/webkitpy/port/simulator_process.py:
527         (SimulatorProcess.stop):
528         - If self._child_processes is set, call
529           self._port.check_for_leaks() for each child process.
530
531         * Scripts/webkitpy/port/watch_device.py:
532         (WatchDevicePort.check_for_leaks):
533         - Rename redundant 'process_pid' argument to 'process_id'.
534
535         * WebKitTestRunner/TestController.cpp:
536         (WTR::TestController::dumpResponse):
537         - Extract method from findAndDumpWorldLeaks() so that it may be
538           reused by findAndDumpWebKitProcessIdentifiers().
539         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
540         - Add method to output process name and process ID of both the
541           WebContent and Networking processes.
542         (WTR::TestController::findAndDumpWorldLeaks):
543         - Fix missing newline in output when there were no abandoned
544           documents.
545         - Call dumpResponse() for extracted code.
546         (WTR::TestController::handleControlCommand):
547         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
548         - Use strncmp() instead of strcmp().
549         - Call findAndDumpWebKitProcessIdentifiers() when
550           "#LIST CHILD PROCESSES" command is sent.
551         * WebKitTestRunner/TestController.h:
552         (WTR::TestController::dumpResponse):
553         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
554         - Declare methods.
555
556 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
557
558         Unreviewed. Add GLib API test cases after r243434.
559
560         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
561         (testWebViewActiveURI):
562         (serverCallback):
563         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
564         (sendRequestCallback):
565
566 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
567
568         Geolocation request not complete when watch request was started in a different web process
569         https://bugs.webkit.org/show_bug.cgi?id=195996
570
571         Reviewed by Alex Christensen.
572
573         Add a test case.
574
575         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
576         (TestWebKitAPI::runJavaScriptAlert):
577         (TestWebKitAPI::TEST):
578
579 2019-03-26  Keith Rollin  <krollin@apple.com>
580
581         Update the way generate-xcfilelists returns strings from functions
582         https://bugs.webkit.org/show_bug.cgi?id=195975
583         <rdar://problem/49040807>
584
585         Reviewed by Dean Jackson.
586
587         There are places where generate-xcfilelists executes assignments with
588         statements like:
589
590             FOO=$(some_function)
591
592         where "some_function" return a string by echoing it. E.g.
593
594             some_function()
595             {
596                 echo "Hello, World"
597             }
598
599         This is a common idiom, but it has a problem if "some_function" needs
600         to call "exit" in an attempt to halt the entire script right then and
601         there. Since "some_function" is called inside of $(), it's being
602         executed in a sub-shell. Calling exit in that sub-shell simply exits
603         that shell; it doesn't not exit the outer shell in which the main part
604         of the script is still running. As such, the main script keeps
605         executing when the intent was for the script to halt.
606
607         The solution to this is to use a different idiom for returning
608         strings. The one we now is to pass in the name of the variable to
609         receive the string result:
610
611             some_function()
612             {
613                 variable_name=$1
614                 eval $variable_name ="Hello, World"
615             }
616
617         The call site now looks like
618
619             some_function FOO
620
621         Because there's no invocation of a sub-shell, some_function can now
622         call "exit" if it wants to, and the entire script will exit at that
623         point.
624
625         * Scripts/generate-xcfilelists:
626
627 2019-03-26  Chris Dumez  <cdumez@apple.com>
628
629         Add basic layout test coverage for File Picker on iOS
630         https://bugs.webkit.org/show_bug.cgi?id=196265
631
632         Reviewed by Wenson Hsieh.
633
634         Add layout test infrastructure to test the file picker on iOS.
635
636         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
637         (WTR::UIScriptController::dismissFilePicker):
638         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
639         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
640         (WTR::UIScriptController::dismissFilePicker):
641         * TestRunnerShared/UIScriptContext/UIScriptController.h:
642         * WebKitTestRunner/TestController.cpp:
643         (WTR::TestController::createWebViewWithOptions):
644         (WTR::updateTestOptionsFromTestHeader):
645         * WebKitTestRunner/TestOptions.h:
646         (WTR::TestOptions::hasSameInitializationOptions const):
647         * WebKitTestRunner/ios/TestControllerIOS.mm:
648         (overridePresentViewController):
649         (WTR::TestController::platformInitialize):
650         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
651         (WTR::UIScriptController::dismissFilePicker):
652
653 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
654
655         Implement async paste method on UIWKInteractionViewProtocol
656         https://bugs.webkit.org/show_bug.cgi?id=196267
657         <rdar://problem/49236346>
658
659         Reviewed by Tim Horton.
660
661         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
662         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
663         are now a part of all iOS 12 internal SDKs.
664
665         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
666
667         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
668         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
669
670         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
671         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
672         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
673         * TestWebKitAPI/ios/UIKitSPI.h:
674
675 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
676
677         [ews-build] Use PostgreSQL for ews.webkit.org database
678         https://bugs.webkit.org/show_bug.cgi?id=196270
679
680         Reviewed by Lucas Forschler.
681
682         * BuildSlaveSupport/ews-app/ews-app/settings.py:
683
684 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
685
686         [ews] Reset simctl states on reboot
687         https://bugs.webkit.org/show_bug.cgi?id=196260
688
689         Rubber-stamped by Aakash Jain.
690
691         * EWSTools/start-queue-mac.sh:
692
693 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
694
695         [ews-build] Use PostgreSQL for ews-build database
696         https://bugs.webkit.org/show_bug.cgi?id=196229
697
698         Reviewed by Lucas Forschler.
699
700         * BuildSlaveSupport/ews-build/master.cfg:
701
702 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
703
704         [ews-build] Get master_hostname dynamically in master.cfg
705         https://bugs.webkit.org/show_bug.cgi?id=196255
706
707         Reviewed by Lucas Forschler.
708
709         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
710         send events data in test mode.
711
712 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
713
714         [ews-app] Set db_constraint to False for Foreign Keys
715         https://bugs.webkit.org/show_bug.cgi?id=196252
716
717         Reviewed by Lucas Forschler.
718
719         * BuildSlaveSupport/ews-app/ews/models/build.py:
720         * BuildSlaveSupport/ews-app/ews/models/step.py:
721
722 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
723
724         [ews-build] is_test_mode_enabled should default to True
725         https://bugs.webkit.org/show_bug.cgi?id=196248
726
727         Reviewed by Lucas Forschler.
728
729         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
730
731 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
732
733         [ews-app] Add webkitperl to ENABLED_QUEUES
734         https://bugs.webkit.org/show_bug.cgi?id=196253
735
736         Reviewed by Lucas Forschler.
737
738         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
739
740 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
741
742         Address NSWindow sometimes using WebKitTestRunnerEvent too early
743         https://bugs.webkit.org/show_bug.cgi?id=196211
744         rdar://problem/49110552
745
746         Reviewed by Tim Horton.
747
748         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
749         Make sure that EventSenderProxy always exists when running tests. We used to create
750         it when resetting before the first test, which is a bit too late.
751
752         * WebKitTestRunner/TestController.h:
753         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
754         (WTR::TestController::platformCreateWebView):
755         (WTR::TestController::platformCreateOtherPage):
756         (WTR::TestController::finishCreatingPlatformWebView):
757         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
758         (WTR::PlatformWebView::PlatformWebView):
759         Moved some code that made NSWindow use NSEvent during web view creation. We may
760         need to move more if some other case us found, but this is enough for now.
761
762 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
763
764         Unreviewed. Fix typo in GLib geolocation API after r243285.
765
766         gelocation -> geolocation.
767
768         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
769         (testGeolocationManagerWatchPosition):
770
771 2019-03-25  Alex Christensen  <achristensen@webkit.org>
772
773         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
774         https://bugs.webkit.org/show_bug.cgi?id=196213
775
776         Reviewed by Geoff Garen.
777
778         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
779         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
780         (credentialWithIdentityAndKeychainPath):
781         (-[ChallengeDelegate webView:didFinishNavigation:]):
782         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
783         (TestWebKitAPI::TEST):
784
785 2019-03-25  Alex Christensen  <achristensen@webkit.org>
786
787         Expected shouldn't assume its contained types are copyable
788         https://bugs.webkit.org/show_bug.cgi?id=195986
789
790         Reviewed by JF Bastien.
791
792         * TestWebKitAPI/Tests/WTF/Expected.cpp:
793         (TestWebKitAPI::NonCopyable::operator== const):
794         (TestWebKitAPI::NonCopyable::operator!= const):
795         (TestWebKitAPI::TEST):
796
797 2019-03-25  Tim Horton  <timothy_horton@apple.com>
798
799         Remove some now-unnecessary dynamic class lookup
800         https://bugs.webkit.org/show_bug.cgi?id=196237
801
802         Reviewed by Simon Fraser.
803
804         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
805         (makeRequest):
806         (TEST):
807
808 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
809
810         Unreviewed, rolling out r243450.
811
812         AppleWin and WinCairo port builds get broken.
813
814         Reverted changeset:
815
816         "Add test for fix of #196095"
817         https://bugs.webkit.org/show_bug.cgi?id=196097
818         https://trac.webkit.org/changeset/243450
819
820 2019-03-25  Commit Queue  <commit-queue@webkit.org>
821
822         Unreviewed, rolling out r243465.
823         https://bugs.webkit.org/show_bug.cgi?id=196226
824
825         the test doesn't build (Requested by thorton on #webkit).
826
827         Reverted changeset:
828
829         "Do not terminate the NetworkProcess if a third party
830         application sends a NSCredential with a SecIdentityRef"
831         https://bugs.webkit.org/show_bug.cgi?id=196213
832         https://trac.webkit.org/changeset/243465
833
834 2019-03-25  Alex Christensen  <achristensen@webkit.org>
835
836         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
837         https://bugs.webkit.org/show_bug.cgi?id=196213
838
839         Reviewed by Geoff Garen.
840
841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
842         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
843         (credentialWithIdentityAndKeychainPath):
844         (-[ChallengeDelegate webView:didFinishNavigation:]):
845         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
846         (TestWebKitAPI::TEST):
847
848 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
849
850         [ews-build] Gracefully handle missing patch_id in events
851         https://bugs.webkit.org/show_bug.cgi?id=196216
852
853         Reviewed by Lucas Forschler.
854
855         * BuildSlaveSupport/ews-build/events.py:
856
857 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
858
859         [ews-build] use lz4 compression for improving buildbot performance
860         https://bugs.webkit.org/show_bug.cgi?id=196155
861
862         Reviewed by Lucas Forschler.
863
864         * BuildSlaveSupport/ews-build/master.cfg:
865
866 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
867
868         Pull some API testing helper methods out of TestWKWebView
869         https://bugs.webkit.org/show_bug.cgi?id=196212
870
871         Reviewed by Tim Horton.
872
873         Refactor some more API testing utility methods, so that they can be used in
874         tests that do not use TestWKWebView.
875
876         * TestWebKitAPI/cocoa/TestWKWebView.h:
877         * TestWebKitAPI/cocoa/TestWKWebView.mm:
878         (-[WKWebView loadTestPageNamed:]):
879         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
880         (-[WKWebView synchronouslyLoadHTMLString:]):
881         (-[WKWebView synchronouslyLoadTestPageNamed:]):
882         (-[TestWKWebView loadTestPageNamed:]): Deleted.
883         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
884         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
885         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
886
887 2019-03-25  Jer Noble  <jer.noble@apple.com>
888
889         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
890         https://bugs.webkit.org/show_bug.cgi?id=196097
891
892         Reviewed by Eric Carlson.
893
894         Drive-by bug fix: allow tests to play audio without a user gesture by default.
895
896         * DumpRenderTree/mac/DumpRenderTree.mm:
897         (resetWebPreferencesToConsistentValues):
898         * WebKitTestRunner/TestController.cpp:
899         (WTR::TestController::resetPreferencesToConsistentValues):
900
901 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
902
903         Pull IPadUserInterfaceSwizzler out into a separate header file
904         https://bugs.webkit.org/show_bug.cgi?id=196193
905
906         Reviewed by Anders Carlsson.
907
908         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
909         be used in other API tests.
910
911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
912         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
913         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
914         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
915         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
916         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
917         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
918
919 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
920
921         Remove NavigatorContentUtils in WebCore/Modules
922         https://bugs.webkit.org/show_bug.cgi?id=196070
923
924         Reviewed by Alex Christensen.
925
926         NavigatorContentUtils was to support the custom scheme spec [1].
927         However, in WebKit side, no port has supported the feature in
928         WebKit layer after EFL port was removed. So there has been the
929         only IDL implementation of the NavigatorContentUtils in WebCore.
930         So we don't need to keep the implementation in WebCore anymore.
931
932         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
933
934         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
935
936 2019-03-24  Andy Estes  <aestes@apple.com>
937
938         [watchOS] Remove unused Proximity Networking code
939         https://bugs.webkit.org/show_bug.cgi?id=196188
940
941         Reviewed by Tim Horton.
942
943         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
944         (TEST):
945
946 2019-03-23  Keith Miller  <keith_miller@apple.com>
947
948         Refactor clz/ctz and fix getLSBSet.
949         https://bugs.webkit.org/show_bug.cgi?id=196162
950
951         Reviewed by Saam Barati.
952
953         Add tests for clz, ctz, getLSBSet, and getMSBSet.
954
955         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
956         (TestWebKitAPI::TEST):
957
958 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
959
960         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
961         https://bugs.webkit.org/show_bug.cgi?id=196143
962
963         Reviewed by Michael Catanzaro.
964
965         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
966         directories.
967
968         * Scripts/webkitpy/style/checkers/cpp.py:
969         (check_identifier_name_in_declaration):
970         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
971         (WebKitStyleTest.test_names):
972
973 2019-03-22  Philippe Normand  <pnormand@igalia.com>
974
975         [Flatpak] Manifest expanding fails for qt WPE extension
976         https://bugs.webkit.org/show_bug.cgi?id=196148
977
978         Reviewed by Alex Christensen.
979
980         * flatpak/flatpakutils.py:
981         (expand_submodules_recurse): The last recurse manifest expand
982         iteration might lead to a single module so take it into account
983         and don't try to recurse further.
984
985 2019-03-22  Chris Dumez  <cdumez@apple.com>
986
987         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
988         https://bugs.webkit.org/show_bug.cgi?id=195348
989         <rdar://problem/48622090>
990
991         Reviewed by Alex Christensen.
992
993         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
994         to NO when test.options().shouldIgnoreMetaViewport is false.
995
996         * WebKitTestRunner/ios/TestControllerIOS.mm:
997         (WTR::TestController::platformConfigureViewForTest):
998
999 2019-03-22  Chris Dumez  <cdumez@apple.com>
1000
1001         Prewarmed processes should be usable with any website data store
1002         https://bugs.webkit.org/show_bug.cgi?id=196104
1003
1004         Reviewed by Alex Christensen.
1005
1006         Add API test coverage.
1007
1008         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1009         (runInitialWarmedProcessUsedTest):
1010         (TEST):
1011
1012 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1013
1014         Back out local changes to Alex's Subversion working directory
1015
1016         They were accidentally committed.
1017
1018         * Scripts/webkitpy/common/system/abstractexecutive.py:
1019         (AbstractExecutive.wait_newest):
1020         * Scripts/webkitpy/common/system/executive.py:
1021         (Executive.running_pids):
1022         * Scripts/webkitpy/common/system/executive_mock.py:
1023         (MockExecutive.running_pids):
1024         * Scripts/webkitpy/common/system/executive_unittest.py:
1025         (ExecutiveTest.serial_test_running_pids):
1026         * Scripts/webkitpy/port/darwin.py:
1027         (DarwinPort.check_for_leaks):
1028         * Scripts/webkitpy/port/leakdetector.py:
1029         (LeakDetector.check_for_leaks):
1030         - This was the hack attached to Bug 193772.
1031
1032         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1033         (+[WebKitTestRunnerEvent mouseLocation]):
1034         - This works around a crash on an internal build.
1035
1036 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1037
1038         Fix the build after r243354
1039         https://bugs.webkit.org/show_bug.cgi?id=196138
1040         <rdar://problem/49145951>
1041
1042         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1043         (TEST):
1044         * TestWebKitAPI/ios/UIKitSPI.h:
1045
1046 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1047
1048         Adopt UIWKDocumentContext
1049         https://bugs.webkit.org/show_bug.cgi?id=196040
1050         <rdar://problem/48642440>
1051
1052         Reviewed by Ryosuke Niwa.
1053
1054         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1055         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1056         (makeRequest):
1057         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1058         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1059         (applyStyle):
1060         (TEST):
1061         Add tests for UIWKDocumentContext.
1062
1063         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1064         (TEST):
1065         (recursiveFindWKContentView): Deleted.
1066         * TestWebKitAPI/cocoa/TestWKWebView.h:
1067         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1068         (recursiveFindWKContentView):
1069         (-[TestWKWebView wkContentView]):
1070         * TestWebKitAPI/ios/UIKitSPI.h:
1071         Share the WKContentView finding code between tests.
1072
1073 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1074
1075         [iOS WK2] Turn on async overflow scrolling by default
1076         https://bugs.webkit.org/show_bug.cgi?id=196011
1077         rdar://problem/48453859
1078
1079         Reviewed by Antti Koivisto.
1080         
1081         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1082         since so many basic layout tests have different results when compositing is triggered for
1083         overflow.
1084         
1085         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1086
1087         * WebKitTestRunner/TestController.cpp:
1088         (WTR::TestController::resetPreferencesToConsistentValues):
1089
1090 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1091
1092         [ews-build] Retry API test in case of failures
1093         https://bugs.webkit.org/show_bug.cgi?id=196004
1094
1095         Reviewed by Lucas Forschler.
1096
1097         * BuildSlaveSupport/ews-build/steps.py:
1098         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1099         (CompileWebKitToT.doStepIf): Ditto.
1100         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1101         (ReRunAPITests): Re-run API tests.
1102         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1103         (RunAPITestsWithoutPatch): Run API tests without patch.
1104         (RunAPITestsWithoutPatch.doStepIf):
1105         (RunAPITestsWithoutPatch.hideStepIf):
1106         (RunAPITestsWithoutPatch.evaluateCommand):
1107         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1108         (AnalyzeAPITestsResults.start):
1109         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1110         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1111         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1112         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1113
1114 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1115
1116         [ews-build] Update queues configurations
1117         https://bugs.webkit.org/show_bug.cgi?id=196074
1118
1119         Reviewed by Dewei Zhu.
1120
1121         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1122         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1123
1124 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1125
1126         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1127         https://bugs.webkit.org/show_bug.cgi?id=195680
1128         <rdar://problem/48903534>
1129
1130         Unreviewed infrastructure fix.
1131
1132         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1133         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1134
1135 2019-03-21  Andy Estes  <aestes@apple.com>
1136
1137         [iOS] Apple Pay should be available in documents with no user agent scripts
1138         https://bugs.webkit.org/show_bug.cgi?id=196061
1139         <rdar://problem/48649391>
1140
1141         Reviewed by Brady Eidson.
1142
1143         Added API tests and related infrastructure.
1144
1145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1146         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1147         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1148         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1149         (TestWebKitAPI::TEST):
1150         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1151         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1152         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1153         * TestWebKitAPI/cocoa/TestProtocol.mm:
1154         (-[TestProtocol startLoading]):
1155         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1156         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1157         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1158         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1159
1160 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1161
1162         REGRESSSION (r243297): webkitpy tests broken
1163         https://bugs.webkit.org/show_bug.cgi?id=196108
1164
1165         Reviewed by Aakash Jain.
1166
1167         r243297 updated contributors.json, which broke a few unit tests.
1168
1169         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1170         (IRCCommandTest.test_whois):
1171         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1172
1173 2019-03-21  Chris Dumez  <cdumez@apple.com>
1174
1175         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1176         https://bugs.webkit.org/show_bug.cgi?id=196041
1177         <rdar://problem/49083230>
1178
1179         Reviewed by Alex Christensen.
1180
1181         Add API test coverage.
1182
1183         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1184         (TEST):
1185
1186 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1187
1188         Add SPI to inform applications of WKContentRuleList actions
1189         https://bugs.webkit.org/show_bug.cgi?id=195965
1190         <rdar://problem/42664365>
1191
1192         Reviewed by Geoff Garen.
1193
1194         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1195         (TestWebKitAPI::allActionsForResourceLoad):
1196         (TestWebKitAPI::testRequest):
1197         (TestWebKitAPI::TEST_F):
1198         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1199         (Notification::description):
1200         (Notification::operator== const):
1201         (toVector):
1202         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1203         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1204         (makeContentRuleList):
1205         (TEST):
1206         (makeWarnContentRuleList): Deleted.
1207
1208 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1209
1210         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1211         https://bugs.webkit.org/show_bug.cgi?id=196088
1212
1213         Reviewed by Brian Burg.
1214
1215         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1216         Support checks when only one platform is specified. Also deprecate macosx() and
1217         force the use of macos() instead.
1218
1219         * Scripts/webkitpy/style/checkers/cpp.py:
1220         (check_min_versions_of_wk_api_available):
1221         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1222         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1223
1224 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1225
1226         Update status inactive committers' status to 'contributor'.
1227
1228         * Scripts/webkitpy/common/config/contributors.json:
1229
1230 2019-03-21  Xan Lopez  <xan@igalia.com>
1231
1232         [JSC][x86] Drop support for x87 floating point
1233         https://bugs.webkit.org/show_bug.cgi?id=194853
1234
1235         Reviewed by Don Olmstead.
1236
1237         Force SSE2 on x86/32bit builds.
1238
1239         * Scripts/webkitdirs.pm:
1240         (generateBuildSystemFromCMakeProject):
1241
1242 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1243
1244         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1245         https://bugs.webkit.org/show_bug.cgi?id=196073
1246
1247         Reviewed by Michael Catanzaro.
1248
1249         Add test cases to check functions and constructors with no arguments but receiving user data.
1250
1251         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1252         (checkUserData):
1253         (testJSCFunction):
1254         (fooCreateWithUserData):
1255         (testJSCClass):
1256
1257 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1258
1259         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1260
1261         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1262
1263         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1264
1265 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1266
1267         [GTK][WPE] Add API to provide geolocation information
1268         https://bugs.webkit.org/show_bug.cgi?id=195940
1269
1270         Reviewed by Michael Catanzaro.
1271
1272         Add a new test to check the new API.
1273
1274         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1275         (testGeolocationManagerCurrentPosition):
1276         (testGeolocationManagerWatchPosition):
1277         (beforeAll):
1278         (afterAll):
1279         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1280         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1281         (beforeAll): Ditto.
1282         * TestWebKitAPI/glib/CMakeLists.txt:
1283
1284 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1285
1286         [GLib] Returning G_TYPE_OBJECT from a method does not work
1287         https://bugs.webkit.org/show_bug.cgi?id=195574
1288
1289         Reviewed by Michael Catanzaro.
1290
1291         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1292
1293         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1294         (getGFile):
1295         (getParent):
1296         (createGString):
1297         (getGString):
1298         (getGStringCopyWillRaise):
1299         (getGStringCopy):
1300         (getGStringStr):
1301         (getGStringLen):
1302         (freeGString):
1303         (testJSCClass):
1304
1305 2019-03-20  Saam Barati  <sbarati@apple.com>
1306
1307         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1308         https://bugs.webkit.org/show_bug.cgi?id=195721
1309
1310         Reviewed by Filip Pizlo.
1311
1312         * Scripts/run-javascriptcore-tests:
1313
1314 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1315
1316         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1317         https://bugs.webkit.org/show_bug.cgi?id=196049
1318
1319         Reviewed by Tim Horton.
1320
1321         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1322         overflow scrolling in general, so rename it.
1323
1324         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1325
1326 2019-03-20  Daniel Bates  <dabates@apple.com>
1327
1328         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1329         https://bugs.webkit.org/show_bug.cgi?id=196031
1330         <rdar://problem/49078172>
1331
1332         Reviewed by Tim Horton.
1333
1334         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1335         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1336         same code path used when the Done button is pressed to dismiss the <select> picker.
1337
1338         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1339         (TestWebKitAPI::TEST):
1340
1341 2019-03-20  Chris Dumez  <cdumez@apple.com>
1342
1343         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1344         https://bugs.webkit.org/show_bug.cgi?id=196029
1345         <rdar://problem/48954651>
1346
1347         Reviewed by Tim Horton.
1348
1349         Add API test coverage.
1350
1351         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1352
1353 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1354
1355         [ews-build] Improve failure summary string for ApplyPatch step
1356         https://bugs.webkit.org/show_bug.cgi?id=195995
1357
1358         Reviewed by Alexey Proskuryakov.
1359
1360         * BuildSlaveSupport/ews-build/steps.py:
1361         (ApplyPatch.getResultSummary): Override getResultSummary.
1362
1363 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1364
1365         AX: Implement support for new meter ARIA role
1366         https://bugs.webkit.org/show_bug.cgi?id=195966
1367
1368         Reviewed by Chris Fleizach.
1369
1370         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1371         to AXLevelIndicator.
1372
1373         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1374
1375 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1376
1377         [WebAuthN] Implement FIDO AppID extension
1378         https://bugs.webkit.org/show_bug.cgi?id=143491
1379         <rdar://problem/48298273>
1380
1381         Reviewed by Brent Fulgham.
1382
1383         Add a test that covers the new flag of convertToU2fSignCommand.
1384
1385         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1386         (TestWebKitAPI::TEST):
1387         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1388         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1389         (TestWebKitAPI::TEST):
1390
1391 2019-03-19  Keith Rollin  <krollin@apple.com>
1392
1393         Add support for more platforms to generate-xcfilelists
1394         https://bugs.webkit.org/show_bug.cgi?id=195977
1395
1396         Reviewed by Alexey Proskuryakov.
1397
1398         generate-xcfilelists incorrectly complains when involved with building
1399         WebKit for iphonesimulator:
1400
1401             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1402             …
1403             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1404
1405         Address this by teaching generate-xcfilelists about more platforms.
1406
1407         * Scripts/generate-xcfilelists:
1408
1409 2019-03-19  John Wilander  <wilander@apple.com>
1410
1411         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1412         https://bugs.webkit.org/show_bug.cgi?id=195923
1413         <rdar://problem/49001272>
1414
1415         Reviewed by Alex Christensen.
1416
1417         This patch does the following to the TestRunner:
1418         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1419         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1420         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1421
1422         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1423         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1424         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1425         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1426         * WebKitTestRunner/TestController.cpp:
1427         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1428         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1429         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1430         * WebKitTestRunner/TestController.h:
1431         * WebKitTestRunner/TestInvocation.cpp:
1432         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1433
1434 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1435
1436         [CMake] Support more clang and gcc sanitizers
1437         https://bugs.webkit.org/show_bug.cgi?id=195956
1438
1439         Reviewed by Michael Catanzaro.
1440
1441         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1442
1443 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1444
1445         [ews-build] Improve summary for PrintConfiguration step
1446         https://bugs.webkit.org/show_bug.cgi?id=195945
1447
1448         Reviewed by Lucas Forschler.
1449
1450         * BuildSlaveSupport/ews-build/steps.py:
1451         (PrintConfiguration.getResultSummary): Override getResultSummary.
1452
1453 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1454
1455         [ews-build] Improve summary for CheckOutSource step
1456         https://bugs.webkit.org/show_bug.cgi?id=195963
1457
1458         Reviewed by Lucas Forschler.
1459
1460         * BuildSlaveSupport/ews-build/steps.py:
1461         (CheckOutSource.getResultSummary):
1462
1463 2019-03-19  Daniel Bates  <dabates@apple.com>
1464
1465         [iOS] Focus not preserved when switching between tabs
1466         https://bugs.webkit.org/show_bug.cgi?id=195820
1467         <rdar://problem/43614450>
1468
1469         Reviewed by Brent Fulgham.
1470
1471         Add tests to ensure that we restore focus when resigning and becoming first responder.
1472
1473         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1474         (TestWebKitAPI::TEST):
1475
1476 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1477
1478         Make WTFLogChannelState and WTFLogLevel enum classes
1479         https://bugs.webkit.org/show_bug.cgi?id=195904
1480
1481         Reviewed by Eric Carlson.
1482
1483         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1484         (TestWebKitAPI::TEST_F):
1485
1486 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1487
1488         [GStreamer][EME] Backported mssdemux protection data crash fix
1489         https://bugs.webkit.org/show_bug.cgi?id=195918
1490
1491         Reviewed by Philippe Normand.
1492
1493         * gstreamer/jhbuild.modules:
1494         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1495
1496 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1497
1498         Unreviewed, rolling out r243132.
1499
1500         Broke GTK build
1501
1502         Reverted changeset:
1503
1504         "Make WTFLogChannelState and WTFLogLevel enum classes"
1505         https://bugs.webkit.org/show_bug.cgi?id=195904
1506         https://trac.webkit.org/changeset/243132
1507
1508 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1509
1510         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1511
1512         * Scripts/webkitdirs.pm:
1513         (builtDylibPathForName): Adjust the shared library name that's changed
1514         with the API version bump in r243073.
1515
1516 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1517
1518         Make WTFLogChannelState and WTFLogLevel enum classes
1519         https://bugs.webkit.org/show_bug.cgi?id=195904
1520
1521         Reviewed by Eric Carlson.
1522
1523         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1524         (TestWebKitAPI::TEST_F):
1525
1526 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1527
1528         Disable flaky test added in r2431100
1529         https://webkit.org/b/195785
1530
1531         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1532         (TestWebKitAPI::TEST):
1533         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1534
1535 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1536
1537         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1538         https://bugs.webkit.org/show_bug.cgi?id=195916
1539
1540         Reviewed by Tim Horton.
1541
1542         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1543         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1544
1545 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1546
1547         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1548
1549         * Scripts/webkitpy/common/config/contributors.json:
1550
1551 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1552
1553         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1554         https://bugs.webkit.org/show_bug.cgi?id=195785
1555
1556         Reviewed by Geoffrey Garen.
1557
1558         * TestWebKitAPI/TCPServer.cpp: Added.
1559         (TestWebKitAPI::TCPServer::TCPServer):
1560         (TestWebKitAPI::TCPServer::~TCPServer):
1561         (TestWebKitAPI::TCPServer::socketBindListen):
1562         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1563         * TestWebKitAPI/TCPServer.h: Added.
1564         (TestWebKitAPI::TCPServer::port const):
1565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1566         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1567         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1568         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1569         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1570         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1571         (TestWebKitAPI::respondSlowly):
1572         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1573         (TestWebKitAPI::downloadAtRate):
1574         (TestWebKitAPI::TEST):
1575
1576 2019-03-18  Saam Barati  <sbarati@apple.com>
1577
1578         Add a plan file for JetStream 2
1579         https://bugs.webkit.org/show_bug.cgi?id=190734
1580
1581         Reviewed by Mark Lam.
1582
1583         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1584
1585 2019-03-18  Chris Dumez  <cdumez@apple.com>
1586
1587         Delay WebProcess launch until a load is triggered in a Web view
1588         https://bugs.webkit.org/show_bug.cgi?id=195758
1589         <rdar://problem/48126013>
1590
1591         Reviewed by Geoff Garen.
1592
1593         Add API test coverage. Also update some existing API tests to not expect
1594         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1595
1596         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1597         (TestWebKitAPI::TEST):
1598         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1599         (TestWebKitAPI::TEST):
1600         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1601         (TEST):
1602         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1603         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1604         (TEST):
1605         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1606         (TEST):
1607         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1608
1609 2019-03-18  Xan Lopez  <xan@igalia.com>
1610
1611         [CMake] Prevent potential warning when determining $architecture
1612         https://bugs.webkit.org/show_bug.cgi?id=195891
1613
1614         Reviewed by Michael Catanzaro.
1615
1616         It's possible for generateBuildSystemForCMakeProject to be called
1617         before determineArchitecture() is ever called. This will make the
1618         first eq check with $architecture to be bogus (and print a
1619         warning). Change that to an eq check with architecture(), which
1620         implicitly calls determineArchitecture() if needed, and change all
1621         the other similar cases in the method in the same way to prevent
1622         future bugs like this one.
1623
1624         * Scripts/webkitdirs.pm:
1625         (generateBuildSystemFromCMakeProject):
1626
1627 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1628
1629         [WPE] Tarballs generated with “make dist” cannot build documentation
1630         https://bugs.webkit.org/show_bug.cgi?id=195885
1631
1632         Reviewed by Carlos Garcia Campos.
1633
1634         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1635
1636 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1637
1638         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1639         https://bugs.webkit.org/show_bug.cgi?id=195883
1640
1641         Reviewed by Carlos Garcia Campos.
1642
1643         * gtkdoc/gtkdoc.py:
1644         (GTKDoc._run_command): When commands fail to run, include the full command line for
1645         the program invocation and the output it has generated on the standard error stream.
1646
1647 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1648
1649         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1650         https://bugs.webkit.org/show_bug.cgi?id=195786
1651
1652         Reviewed by Philippe Normand.
1653
1654         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1655         * wpe/jhbuild.modules: Ditto.
1656
1657 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1658
1659         [ews-build] Don't run clean builds on EWS builders
1660         https://bugs.webkit.org/show_bug.cgi?id=195851
1661
1662         Reviewed by Geoffrey Garen.
1663
1664         * BuildSlaveSupport/ews-build/factories.py:
1665
1666 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1667
1668         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1669         https://bugs.webkit.org/show_bug.cgi?id=195849
1670
1671         Reviewed by Chris Dumez.
1672
1673         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1674
1675         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1676         (runWebsiteDataStoreCustomPaths):
1677
1678 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1679
1680         webkitpy: Upload test results
1681         https://bugs.webkit.org/show_bug.cgi?id=195755
1682         <rdar://problem/48896182>
1683
1684         Reviewed by Aakash Jain.
1685
1686         Establish a new format for uploading results that is not tied to layout tests, apply
1687         that format to webkitpy tests.
1688
1689         * Scripts/webkitpy/common/checkout/scm/git.py:
1690         (Git.native_branch): Return what branch the current checkout is on.
1691         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1692         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1693         * Scripts/webkitpy/common/checkout/scm/svn.py:
1694         (SVN.native_branch): Ditto.
1695         * Scripts/webkitpy/common/system/platforminfo.py:
1696         (PlatformInfo.build_version): Return a build version for Mac.
1697         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1698         (MockPlatformInfo.__init__):
1699         (MockPlatformInfo.build_version):
1700         * Scripts/webkitpy/results: Added.
1701         * Scripts/webkitpy/results/__init__.py: Added.
1702         * Scripts/webkitpy/results/options.py: Added.
1703         (upload_options): OptParse list for upload options.
1704         * Scripts/webkitpy/results/upload.py: Added.
1705         (Upload): Class which enforces the upload format expected by the results server.
1706         (Upload.Expectations):
1707         (Upload.create_configuration):
1708         (Upload.create_commit):
1709         (Upload.create_details):
1710         (Upload.create_run_stats):
1711         (Upload.create_test_result):
1712         (Upload.__init__):
1713         (Upload.Encoder): Encode Upload object as json.
1714         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1715         * Scripts/webkitpy/results/upload_unittest.py: Added.
1716         * Scripts/webkitpy/test/main.py:
1717         (Tester._parse_args): Add upload arguments.
1718         (Tester._run_tests): Allow results to be uploaded.
1719         * Scripts/webkitpy/test/runner.py:
1720         (Runner.__init__): Record which tests were run, rather than just counting them.
1721         (Runner.handle):
1722         * Scripts/webkitpy/test/runner_unittest.py:
1723         (RunnerTest.test_run):
1724         * Scripts/webkitpy/thirdparty/__init__.py:
1725         (AutoinstallImportHook.find_module): Add requests auto-install.
1726         (AutoinstallImportHook._install_requests):
1727         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1728         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1729
1730 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1731
1732         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1733         https://bugs.webkit.org/show_bug.cgi?id=195810
1734
1735         Reviewed by Tim Horton.
1736
1737         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1738         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1739         ending certain layout tests.
1740
1741         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1742         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1743         (-[TestRunnerWKWebView dealloc]):
1744         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1745
1746         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1747         helper method when destroying the web view, and when resetting state between tests.
1748
1749         * WebKitTestRunner/ios/TestControllerIOS.mm:
1750         (WTR::TestController::platformResetStateToConsistentValues):
1751
1752         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1753
1754 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1755
1756         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1757         https://bugs.webkit.org/show_bug.cgi?id=190350
1758         <rdar://problem/45089503>
1759
1760         Reviewed by Geoffrey Garen.
1761
1762         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1763         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1764         (TEST):
1765         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1766         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1767         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1768         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1769         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1770         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1771         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1772         (runTest):
1773         (createDirectories):
1774         (TEST):
1775         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1776         (TEST):
1777         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1778         (TEST):
1779
1780 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1781
1782         Add support to WebPage for getting the contents as an attributed string.
1783         https://bugs.webkit.org/show_bug.cgi?id=195636
1784         rdar://problem/45055697
1785
1786         Reviewed by Tim Horton.
1787
1788         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1789         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1790
1791 2019-03-15  Chris Dumez  <cdumez@apple.com>
1792
1793         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1794         https://bugs.webkit.org/show_bug.cgi?id=195747
1795
1796         Reviewed by Geoff Garen.
1797
1798         Add API test coverage.
1799
1800         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1801
1802 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1803
1804         Unreviewed, rolling out r242952.
1805
1806         Causing API failures on iOS Simulator
1807
1808         Reverted changeset:
1809
1810         "[PSON] Make sure the WebProcessCache is leverage when
1811         relaunching a process after termination"
1812         https://bugs.webkit.org/show_bug.cgi?id=195747
1813         https://trac.webkit.org/changeset/242952
1814
1815 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1816
1817         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1818         https://bugs.webkit.org/show_bug.cgi?id=195740
1819
1820         Reviewed by Ross Kirsling.
1821
1822         window.open doesn't work for WebKitBrowserWindow because it is not
1823         implemented yet.
1824
1825         1. Implemented createNewPage callback of WKPageUIClient.
1826         2. Changed MainWindow to take a BrowserWindow factory function
1827           instead of BrowserWindowType to be flexible to create
1828           BrowserWindow with extra settings.
1829         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1830           because it is not relevant with MainWindow anymore.
1831
1832         * MiniBrowser/win/Common.cpp:
1833         (parseCommandLine):
1834         * MiniBrowser/win/Common.h:
1835         (CommandLineOptions::CommandLineOptions):
1836         * MiniBrowser/win/MainWindow.cpp:
1837         (MainWindow::MainWindow):
1838         (MainWindow::create):
1839         (MainWindow::init):
1840         (MainWindow::WndProc):
1841         * MiniBrowser/win/MainWindow.h:
1842         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1843         (PrintWebUIDelegate::createWebViewWithRequest):
1844         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1845         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1846         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1847         (WebKitBrowserWindow::updateProxySettings):
1848         (WebKitBrowserWindow::createNewPage):
1849         * MiniBrowser/win/WebKitBrowserWindow.h:
1850         * MiniBrowser/win/WinMain.cpp:
1851         (wWinMain):
1852
1853 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1854
1855         Make it possible to test scrolling tree layer manipulation more easily
1856         https://bugs.webkit.org/show_bug.cgi?id=195780
1857
1858         Reviewed by Tim Horton.
1859         
1860         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1861         cuts off communication of scrolling tree scrolls back to the web process
1862         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1863         allows tests to trigger scrolls which run the scrolling tree layer positioning
1864         logic, but never get another commit from the web process that might mask
1865         scrolling tree bugs.
1866         
1867         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1868         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1869         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1870
1871         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1872         (WTR::UIScriptController::scrollUpdatesDisabled const):
1873         (WTR::UIScriptController::setScrollUpdatesDisabled):
1874         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1875         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1876         (WTR::UIScriptController::scrollUpdatesDisabled const):
1877         (WTR::UIScriptController::setScrollUpdatesDisabled):
1878         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1879         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1880         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1881         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1882         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1883         * WebKitTestRunner/ios/TestControllerIOS.mm:
1884         (WTR::TestController::platformResetStateToConsistentValues):
1885         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1886         (WTR::UIScriptController::scrollUpdatesDisabled const):
1887         (WTR::UIScriptController::setScrollUpdatesDisabled):
1888
1889 2019-03-14  Youenn Fablet  <youenn@apple.com>
1890
1891         Move IDB storage in private browsing mode to NetworkProcess
1892         https://bugs.webkit.org/show_bug.cgi?id=195602
1893
1894         Reviewed by Brady Eidson.
1895
1896         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1897         (TEST):
1898
1899 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1900
1901         [ews-build] Make descriptionDone messages more readable
1902         https://bugs.webkit.org/show_bug.cgi?id=195760
1903
1904         Reviewed by Lucas Forschler.
1905
1906         * BuildSlaveSupport/ews-build/steps.py:
1907         * BuildSlaveSupport/ews-build/steps_unittest.py:
1908
1909 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1910
1911         [ews-build] Generate status-bubble hover-over messages
1912         https://bugs.webkit.org/show_bug.cgi?id=195680
1913
1914         Reviewed by Lucas Forschler.
1915
1916         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1917         (StatusBubble):
1918         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1919         on hover-over.
1920         (StatusBubble._iso_time):
1921         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1922         hover-over message.
1923         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1924
1925 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1926
1927         [ews-app] Gracefully handle the case when state_string is None
1928         https://bugs.webkit.org/show_bug.cgi?id=195753
1929
1930         Reviewed by Lucas Forschler.
1931
1932         * BuildSlaveSupport/ews-app/ews/models/build.py:
1933         * BuildSlaveSupport/ews-app/ews/models/step.py:
1934
1935 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1936
1937         [ews-app] Status bubble display pending for currently running build step
1938         https://bugs.webkit.org/show_bug.cgi?id=195744
1939
1940         Reviewed by Lucas Forschler.
1941
1942         * BuildSlaveSupport/ews-build/events.py:
1943         (Events.stepStarted): If state_string is pending, replace it with step name.
1944
1945 2019-03-14  Chris Dumez  <cdumez@apple.com>
1946
1947         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1948         https://bugs.webkit.org/show_bug.cgi?id=195750
1949
1950         Reviewed by Geoffrey Garen.
1951
1952         Add API test coverage.
1953
1954         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1955         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1956         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1957         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1958
1959 2019-03-14  Chris Dumez  <cdumez@apple.com>
1960
1961         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1962         https://bugs.webkit.org/show_bug.cgi?id=195747
1963
1964         Reviewed by Geoff Garen.
1965
1966         Add API test coverage.
1967
1968         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1969
1970 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1971
1972         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1973         https://bugs.webkit.org/show_bug.cgi?id=195725
1974         <rdar://problem/48545062>
1975
1976         Reviewed by Tim Horton.
1977
1978         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1979         handler is nil.
1980
1981         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1982         (TestWebKitAPI::TEST):
1983
1984 2019-03-13  Sam Weinig  <sam@webkit.org>
1985
1986         Add utility function to allow easy reverse range-based iteration of a container
1987         https://bugs.webkit.org/show_bug.cgi?id=195542
1988
1989         Reviewed by Antti Koivisto.
1990
1991         * TestWebKitAPI/CMakeLists.txt:
1992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1993         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1994         (TestWebKitAPI::TEST):
1995         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1996
1997 2019-03-13  Chris Dumez  <cdumez@apple.com>
1998
1999         Use a ServiceWorker process per registrable domain
2000         https://bugs.webkit.org/show_bug.cgi?id=195649
2001
2002         Reviewed by Youenn Fablet.
2003
2004         Update API test coverage.
2005
2006         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2007
2008 2019-03-13  Chris Dumez  <cdumez@apple.com>
2009
2010         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2011         https://bugs.webkit.org/show_bug.cgi?id=195684
2012         <rdar://problem/48294714>
2013
2014         Reviewed by Antti Koivisto.
2015
2016         Add API test coverage.
2017
2018         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2019
2020 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2021
2022         [ews-app] Remove unused patch view
2023         https://bugs.webkit.org/show_bug.cgi?id=195669
2024
2025         Reviewed by Lucas Forschler.
2026
2027         * BuildSlaveSupport/ews-app/ews/urls.py:
2028         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2029
2030 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2031
2032         [ews-app] Use Buildbot result code variables
2033         https://bugs.webkit.org/show_bug.cgi?id=195668
2034
2035         Reviewed by Alexey Proskuryakov.
2036
2037         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2038         (Buildbot): Added Buildbot result code variables.
2039         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2040         (StatusBubble._build_bubble): Used Buildbot result code variables.
2041
2042 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2043
2044         [Flatpak] Expand submodule recursively
2045         https://bugs.webkit.org/show_bug.cgi?id=195672
2046
2047         Building WPE with flatpak was impossible without that as it was raising an exception.
2048         Also update wpebackend-fdo to match what is built in jhbuild
2049
2050         Reviewed by Philippe Normand.
2051
2052         * flatpak/flatpakutils.py:
2053         (expand_submodules_recurse):
2054         (expand_manifest):
2055         * flatpak/org.webkit.WPEModules.yaml:
2056
2057 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2058
2059         [ews-app] status bubble should be hidden for certain builds
2060         https://bugs.webkit.org/show_bug.cgi?id=194597
2061
2062         Reviewed by Dewei Zhu.
2063
2064         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2065         (StatusBubble._build_bubble):
2066         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2067         because the patch didn't have relevant changes.
2068         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2069         in production yet.
2070
2071 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2072
2073         [Win] Fix a slew of simple clang-cl warnings.
2074         https://bugs.webkit.org/show_bug.cgi?id=195652
2075
2076         Reviewed by Don Olmstead.
2077
2078         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2079         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2080
2081 2019-03-12  Justin Fan  <justin_fan@apple.com>
2082
2083         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2084         https://bugs.webkit.org/show_bug.cgi?id=195518
2085         <rdar://problem/46322356>
2086
2087         Reviewed by Myles C. Maxfield.
2088
2089         * DumpRenderTree/DerivedSources-input.xcfilelist:
2090         * DumpRenderTree/DerivedSources-output.xcfilelist:
2091
2092 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2093
2094         Unreviewed, rolling out r242825.
2095         https://bugs.webkit.org/show_bug.cgi?id=195648
2096
2097         "Broke webkitpy tests with my change to
2098         lldb_dump_class_layout.py" (Requested by rmorisset on
2099         #webkit).
2100
2101         Reverted changeset:
2102
2103         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2104         classes with suspicious padding"
2105         https://bugs.webkit.org/show_bug.cgi?id=195573
2106         https://trac.webkit.org/changeset/242825
2107
2108 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2109
2110         [ews-build] Show status bubbles while the patch is waiting in queue
2111         https://bugs.webkit.org/show_bug.cgi?id=195618
2112
2113         Reviewed by Lucas Forschler.
2114
2115         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2116         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2117         enabled in initial deployment.
2118         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2119         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2120         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2121         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2122         (StatusBubble._build_bubbles_for_patch):
2123
2124 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2125
2126         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2127         https://bugs.webkit.org/show_bug.cgi?id=195573
2128
2129         Reviewed by Simon Fraser.
2130
2131         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2132
2133         * Scripts/dump-class-layout:
2134         (main):
2135         * lldb/lldb_dump_class_layout.py:
2136         (ClassLayout.__init__):
2137         (ClassLayout._compute_padding_recursive):
2138         (LLDBDebuggerInstance.dump_layout_for_classname):
2139         (LLDBDebuggerInstance):
2140         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2141         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2142
2143 2019-03-12  Chris Dumez  <cdumez@apple.com>
2144
2145         Device Orientation access permission should be denied unless explicitly granted by the client
2146         https://bugs.webkit.org/show_bug.cgi?id=195625
2147
2148         Reviewed by Youenn Fablet.
2149
2150         add API test coverage.
2151
2152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2153         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2154         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2155         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2156         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2157         (runDeviceOrientationTest):
2158         (TEST):
2159         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2160         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2161
2162 2019-03-12  Jer Noble  <jer.noble@apple.com>
2163
2164         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2165         https://bugs.webkit.org/show_bug.cgi?id=195137
2166         <rdar://problem/48810307>
2167
2168         Reviewed by Eric Carlson.
2169
2170         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2171         (TestWebKitAPI::TEST):
2172
2173 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2174
2175         [ews-build] Change urls from uat to production
2176         https://bugs.webkit.org/show_bug.cgi?id=195566
2177
2178         Reviewed by Lucas Forschler.
2179
2180         * BuildSlaveSupport/ews-app/ews/config.py:
2181         * BuildSlaveSupport/ews-build/events.py:
2182         * BuildSlaveSupport/ews-build/steps.py:
2183
2184 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2185
2186         [ews-build] change max_builds for local-worker to 1
2187         https://bugs.webkit.org/show_bug.cgi?id=195568
2188
2189         Reviewed by Lucas Forschler.
2190
2191         * BuildSlaveSupport/ews-build/loadConfig.py:
2192
2193 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2194
2195         Fix the build
2196
2197         * TestRunnerShared/spi/PencilKitTestSPI.h:
2198         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2199
2200 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2201
2202         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2203         https://bugs.webkit.org/show_bug.cgi?id=194131
2204
2205         Reviewed by Michael Catanzaro.
2206
2207         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2208         (uriChanged):
2209         (testUnfinishedSubresourceLoad):
2210         (serverCallback):
2211         (beforeAll):
2212
2213 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2214
2215         WTF::Expected should use std::addressof instead of operator&
2216         https://bugs.webkit.org/show_bug.cgi?id=195604
2217
2218         Reviewed by Myles Maxfield.
2219
2220         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2221         (TestWebKitAPI::Unique::Unique):
2222         (TestWebKitAPI::Unique::operator&):
2223         (TestWebKitAPI::TEST):
2224
2225 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2226
2227         Add Optional to Forward.h.
2228         https://bugs.webkit.org/show_bug.cgi?id=195586
2229
2230         Reviewed by Darin Adler.
2231
2232         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2233         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2234         Remove unnecessary includes from headers.
2235
2236 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2237
2238         Add testing API to hit-test and scroll overflow scrollers
2239         https://bugs.webkit.org/show_bug.cgi?id=195278
2240
2241         Reviewed by Antti Koivisto.
2242         
2243         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2244         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2245         
2246         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2247
2248         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2249         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2250         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2251         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2252         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2253         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2254         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2255         (WTR::enclosingScrollViewIncludingSelf):
2256         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2257
2258 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2259
2260         API test WebKit.RequestTextInputContext fails on iOS
2261         https://bugs.webkit.org/show_bug.cgi?id=195585
2262
2263         Reviewed by Wenson Hsieh and Simon Fraser.
2264
2265         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2266         (applyStyle):
2267         (TEST):
2268         Add a viewport, so that the coordinates match up on iOS.
2269         Scroll by moving the UIScrollView's contentOffset.
2270
2271 2019-03-11  Chris Dumez  <cdumez@apple.com>
2272
2273         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2274         https://bugs.webkit.org/show_bug.cgi?id=195506
2275         <rdar://problem/48733477>
2276
2277         Reviewed by Alex Christensen.
2278
2279         Add API test coverage.
2280
2281         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2282
2283 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2284
2285         Adding myself to contributors.json
2286
2287         Unreviewed, addming myself to contributors.json .
2288
2289         * Scripts/webkitpy/common/config/contributors.json:
2290
2291 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2292
2293         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2294         https://bugs.webkit.org/show_bug.cgi?id=195511
2295         <rdar://problem/44873269>
2296
2297         Reviewed by Darin Adler.
2298
2299         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2300         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2301         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2302         (TEST_F):
2303
2304 2019-03-11  Chris Dumez  <cdumez@apple.com>
2305
2306         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2307         https://bugs.webkit.org/show_bug.cgi?id=195561
2308
2309         Reviewed by Youenn Fablet.
2310
2311         Make sure the JS in the test requests for permission to receive device orientation events.
2312
2313         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2314
2315 2019-03-11  Youenn Fablet  <youenn@apple.com>
2316
2317         Allow storage quota increase by default in WTR
2318         https://bugs.webkit.org/show_bug.cgi?id=195541
2319
2320         Reviewed by Geoffrey Garen.
2321
2322         Allow storage quota increase by default in WTR.
2323         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2324         Use this for tests that explicitly need cache increase.
2325
2326         Instead of increasing quota by 2, make sure the next request is
2327         granted by adding all given parameters.
2328
2329         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2330         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2331         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2332         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2333         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2334         * WebKitTestRunner/TestController.cpp:
2335         (WTR::TestController::setAllowStorageQuotaIncrease):
2336         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2337         * WebKitTestRunner/TestController.h:
2338         * WebKitTestRunner/TestInvocation.cpp:
2339         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2340         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2341         (WTR::TestController::cocoaResetStateToConsistentValues):
2342         (WTR::TestController::setAllowStorageQuotaIncrease):
2343         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2344         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2345         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2346
2347 2019-03-11  Xan Lopez  <xan@igalia.com>
2348
2349         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2350         https://bugs.webkit.org/show_bug.cgi?id=194147
2351
2352         Reviewed by Michael Saboff.
2353
2354         To make --32-bit work correctly on Linux/64bit we need to:
2355
2356         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2357         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2358         unfortunately CMake only allows us to do this during
2359         crosscompilation, which is overkill here.
2360         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2361         pkg-config detection module uses the x86 .pc files instead of the
2362         x86_64 ones.
2363         - Set the -m32 flags for the compiler.
2364
2365         * Scripts/webkitdirs.pm:
2366         (generateBuildSystemFromCMakeProject):
2367
2368 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2369
2370         Add MotionMark-1.1 plan file for run-benchmark script.
2371         https://bugs.webkit.org/show_bug.cgi?id=195481
2372
2373         Rubber-stamped by Darin Adler.
2374
2375         Run-benchmark script should support MontionMark-1.1.
2376
2377         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2378
2379 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2380
2381         [ews-app] Add support for submit-to-ews url
2382         https://bugs.webkit.org/show_bug.cgi?id=195477
2383
2384         Reviewed by Lucas Forschler.
2385
2386         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2387         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2388         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2389         * BuildSlaveSupport/ews-app/ews/urls.py:
2390         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2391
2392 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2393
2394         Unreviewed, rolling out r242688, r242643, r242624.
2395
2396         Caused multiple layout test failures and crashes on iOS and macOS.
2397
2398         Reverted changeset:
2399
2400         "requestAnimationFrame should execute before the next frame"
2401         https://bugs.webkit.org/show_bug.cgi?id=177484
2402         https://trac.webkit.org/changeset/242624/webkit
2403
2404         * Tracing/SystemTracePoints.plist:
2405
2406 2019-03-11  John Wilander  <wilander@apple.com>
2407
2408         Resource Load Statistics: Make it possible exclude localhost from classification
2409         https://bugs.webkit.org/show_bug.cgi?id=195474
2410         <rdar://problem/47520577>
2411
2412         Reviewed by Brent Fulgham.
2413
2414         This patch allows for localhost to be excluded from classification and
2415         treatment as a prevalent resource.
2416
2417         The WebKit Tools change adds a new function called
2418         testRunner.setStatisticsIsRunningTest() which can be used to control this
2419         behavior.
2420
2421         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2422         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2423         (WTR::TestRunner::setStatisticsIsRunningTest):
2424         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2425         * WebKitTestRunner/TestController.cpp:
2426         (WTR::TestController::setStatisticsIsRunningTest):
2427         * WebKitTestRunner/TestController.h:
2428         * WebKitTestRunner/TestInvocation.cpp:
2429         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2430
2431 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2432
2433         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2434         https://bugs.webkit.org/show_bug.cgi?id=195560
2435
2436         Reviewed by Lucas Forschler.
2437
2438         * BuildSlaveSupport/ews-build/master.cfg:
2439
2440 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2441
2442         Unreviewed, rolling out r242698.
2443
2444         API test crashes on bots.
2445
2446         Reverted changeset:
2447
2448         "Add a WKContentRuleList variant that uses copied memory
2449         instead of mmap'd shared memory for class A containerized
2450         apps"
2451         https://bugs.webkit.org/show_bug.cgi?id=195511
2452         https://trac.webkit.org/changeset/242698
2453
2454 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2455
2456         [WPE] Enable web process sandbox
2457         https://bugs.webkit.org/show_bug.cgi?id=195169
2458
2459         Reviewed by Daniel Bates.
2460
2461         * wpe/install-dependencies:
2462         * wpe/jhbuild.modules:
2463
2464 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2465
2466         [ews-app] Use port 17000 for worker communication
2467         https://bugs.webkit.org/show_bug.cgi?id=195558
2468
2469         Reviewed by Lucas Forschler.
2470
2471         * BuildSlaveSupport/ews-build/master.cfg:
2472
2473 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2474
2475         [ews-build] unit-tests fail when passwords.json is missing
2476         https://bugs.webkit.org/show_bug.cgi?id=195557
2477
2478         Reviewed by Lucas Forschler.
2479
2480         * BuildSlaveSupport/ews-build/loadConfig.py:
2481         (loadBuilderConfig):
2482         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2483         (ConfigDotJSONTest.test_configuration):
2484         * BuildSlaveSupport/ews-build/master.cfg:
2485
2486 2019-03-11  Truitt Savell  <tsavell@apple.com>
2487
2488         Unreviewed, rolling out r242702.
2489
2490         Broke High Sierra builders.
2491
2492         Reverted changeset:
2493
2494         "Add utility function to allow easy reverse range-based
2495         iteration of a container"
2496         https://bugs.webkit.org/show_bug.cgi?id=195542
2497         https://trac.webkit.org/changeset/242702
2498
2499 2019-03-11  Sam Weinig  <sam@webkit.org>
2500
2501         Add utility function to allow easy reverse range-based iteration of a container
2502         https://bugs.webkit.org/show_bug.cgi?id=195542
2503
2504         Reviewed by Antti Koivisto.
2505
2506         * TestWebKitAPI/CMakeLists.txt:
2507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2508         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2509         (TestWebKitAPI::TEST):
2510         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2511
2512 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2513
2514         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2515         https://bugs.webkit.org/show_bug.cgi?id=195511
2516         <rdar://problem/44873269>
2517
2518         Reviewed by Darin Adler.
2519
2520         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2521         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2522         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2523         (TEST_F):
2524
2525 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2526
2527         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2528         https://bugs.webkit.org/show_bug.cgi?id=195499
2529
2530         Reviewed by Darin Adler.
2531
2532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2533         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2534         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2535         (-[WKWebView synchronouslyFocusTextInputContext:]):
2536         (applyStyle):
2537         (applyIframe):
2538         (TEST):
2539         Add some tests for this SPI.
2540
2541 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2542
2543         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2544         https://bugs.webkit.org/show_bug.cgi?id=181151
2545
2546         Reviewed by Don Olmstead.
2547
2548         * TestWebKitAPI/CMakeLists.txt:
2549         * TestWebKitAPI/PlatformWin.cmake:
2550         Enable TestWTF RunLoop tests in all platforms.
2551
2552         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2553         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2554         (TestWebKitAPI::DerivedOneShotTimer::fired):
2555         (TestWebKitAPI::TEST):
2556         Only a few platforms support nested RunLoop.
2557
2558         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2559         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2560
2561 2019-03-10  David Quesada  <david_quesada@apple.com>
2562
2563         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2564         https://bugs.webkit.org/show_bug.cgi?id=152480
2565
2566         Reviewed by Chris Dumez.
2567
2568         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2569         there are no additional references to the process pool besides the one held by
2570         the download, waits for the download to finish (in the sense that the
2571         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2572         measure, also check that the process pool has been deallocated at the end of the
2573         test. The test wouldn't be meaningful if the process pool were still alive.
2574
2575         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2576         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2577         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2578             The download will be canceled because the delegate does not implement the
2579             method to decide the download's destination, so this is where we know the
2580             DownloadProxyMap is done with the DownloadProxy.
2581         (TEST):
2582
2583 2019-03-08  Chris Dumez  <cdumez@apple.com>
2584
2585         Add support for Device Orientation / Motion permission API
2586         https://bugs.webkit.org/show_bug.cgi?id=195329
2587         <rdar://problem/47645367>
2588
2589         Reviewed by Geoffrey Garen.
2590
2591         Add test infrastructure to help test the Device Orientation / Motion permission API.
2592
2593         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2594         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2595         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2596         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2597         * WebKitTestRunner/TestController.cpp:
2598         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2599         (WTR::TestController::createWebViewWithOptions):
2600         (WTR::TestController::resetStateToConsistentValues):
2601         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2602         * WebKitTestRunner/TestController.h:
2603         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2604         * WebKitTestRunner/TestInvocation.cpp:
2605         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2606
2607 2019-03-08  Saam barati  <sbarati@apple.com>
2608
2609         Add a compare-results script to compare benchmark results
2610         https://bugs.webkit.org/show_bug.cgi?id=195486
2611         <rdar://problem/48723397>
2612
2613         Reviewed by Geoffrey Garen.
2614
2615         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2616         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2617         to extend it to learn about our other benchmarks.
2618
2619         * Scripts/compare-results: Added.
2620         (readJSONFile):
2621         (detectJetStream2):
2622         (JetStream2Results):
2623         (detectSpeedometer2):
2624         (Speedometer2Results):
2625         (detectPLT5):
2626         (PLT5Results):
2627         (detectBenchmark):
2628         (biggerIsBetter):
2629         (ttest):
2630         (getOptions):
2631         (main):
2632
2633 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2634
2635         Ensure old tab state is cleared between iterations of run-benchmark
2636         https://bugs.webkit.org/show_bug.cgi?id=195393
2637         <rdar://problem/46885583>
2638
2639         Reviewed by Dewei Zhu.
2640
2641         a) ensure the default to restore state is not set
2642         b) terminate Safari correctly
2643         c) Set the system default to ignore Persistent State in Safari
2644
2645         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2646         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2647         (OSXBrowserDriver.prepare_env): 
2648         (OSXBrowserDriver.restore_env):
2649         (OSXBrowserDriver.close_browsers):
2650         (OSXBrowserDriver._terminate_processes):
2651         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2652         (OSXChromeDriver):
2653         (OSXChromeCanaryDriver):
2654         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2655         (OSXFirefoxDriver):
2656         (OSXFirefoxNightlyDriver):
2657         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2658         (OSXSafariDriver):
2659         (OSXSafariDriver.prepare_env):
2660
2661 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2662
2663         [GTK] Several InputMethodFilter tests are failing
2664         https://bugs.webkit.org/show_bug.cgi?id=195408
2665
2666         Reviewed by Carlos Garcia Campos.
2667
2668         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2669         Regressed in r241751.
2670         Hexadecimal values of keycodes are expressed now in upper letters.
2671         Composited characters should be cast to UTF8 strings.
2672
2673         (TestWebKitAPI::TEST):
2674
2675 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2676
2677         [GTK] Make Tools/gtkdoc python3 compatible
2678         https://bugs.webkit.org/show_bug.cgi?id=195359
2679
2680         Reviewed by Carlos Garcia Campos.
2681
2682         * gtkdoc/generate-gtkdoc:
2683         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2684         work with Python 2 and 3.
2685         (get_gtkdoc_module_paths):
2686         The iteritems() was removed in Python 3, so let's use items() that's
2687         available in Python 2 and 3.
2688         (get_generator_for_config):
2689         * gtkdoc/gtkdoc.py:
2690         (GTKDoc._run_command):
2691         The sys.stdout.write() is expecting str in Python 3 and not bytes
2692         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2693         for passing the bytes there.
2694
2695 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2696
2697         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2698         https://bugs.webkit.org/show_bug.cgi?id=195346
2699         <rdar://problem/48667048>
2700
2701         Unreviewed build fix for clang-cl.
2702
2703         * DumpRenderTree/win/DumpRenderTree.cpp:
2704         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2705
2706 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2707
2708         requestAnimationFrame should execute before the next frame
2709         https://bugs.webkit.org/show_bug.cgi?id=177484
2710
2711         Reviewed by Simon Fraser.
2712
2713         Add trace points for the page RenderingUpdate.
2714
2715         * Tracing/SystemTracePoints.plist:
2716
2717 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2718
2719         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2720         https://bugs.webkit.org/show_bug.cgi?id=195353
2721         <rdar://problem/48626394>
2722
2723         Reviewed by Simon Fraser.
2724
2725         * WebKitTestRunner/ios/TestControllerIOS.mm:
2726         (WTR::TestController::platformResetPreferencesToConsistentValues):
2727
2728 2019-03-07  John Wilander  <wilander@apple.com>
2729
2730         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2731         https://bugs.webkit.org/show_bug.cgi?id=195383
2732         <rdar://problem/48570136>
2733
2734         Reviewed by Brent Fulgham.
2735
2736         This patch adds test infrastructure to purge only script-accessible cookies,
2737         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2738
2739         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2740         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2741         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2742         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2743         * WebKitTestRunner/TestController.cpp:
2744         (WTR::TestController::statisticsDeleteCookiesForHost):
2745         * WebKitTestRunner/TestController.h:
2746         * WebKitTestRunner/TestInvocation.cpp:
2747         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2748
2749 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2750
2751         Unreviewed, rolling out r242354.
2752         https://bugs.webkit.org/show_bug.cgi?id=195402
2753
2754         breaks layout tests in all configurations (Requested by
2755         zdobersek on #webkit).
2756
2757         Reverted changeset:
2758
2759         "[WPE] Enable web process sandbox"
2760         https://bugs.webkit.org/show_bug.cgi?id=195169
2761         https://trac.webkit.org/changeset/242354
2762
2763 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2764
2765         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2766         https://bugs.webkit.org/show_bug.cgi?id=195346
2767
2768         Reviewed by Fujii Hironori.
2769
2770         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2771         (TestWebKitAPI::TEST):
2772         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2773
2774         * DumpRenderTree/win/DumpRenderTree.cpp:
2775         (findFontFallback):
2776         (addFontFallbackIfPresent):
2777         (removeFontFallbackIfPresent):
2778         (main):
2779         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2780         (TestWebKitAPI::Util::moduleDirectory):
2781         (TestWebKitAPI::Util::createInjectedBundlePath):
2782         Use wchar helpers as needed.
2783
2784 2019-03-06  Rob Buis  <rbuis@igalia.com>
2785
2786         Consider supporting the `referrerpolicy` attribute.
2787         https://bugs.webkit.org/show_bug.cgi?id=179053
2788
2789         Reviewed by Darin Adler.
2790
2791         Add a runtime flag for referrerpolicy attribute.
2792
2793         * DumpRenderTree/mac/DumpRenderTree.mm:
2794         (enableExperimentalFeatures):
2795
2796 2019-03-05  Daniel Bates  <dabates@apple.com>
2797
2798         Update expected API test result following r242379
2799         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2800
2801         Update expected x-coordinate of selection rect now that the left padding of
2802         a textarea is sized in ems (so dependent on the font size) just like the left
2803         padding of a text field.
2804
2805         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2806         (TestWebKitAPI::TEST):
2807
2808 2019-03-05  David Quesada  <david_quesada@apple.com>
2809
2810         [WK2] It should be possible to follow links with 'download' attributes
2811         https://bugs.webkit.org/show_bug.cgi?id=195145
2812         rdar://problem/48462642
2813
2814         Reviewed by Alex Christensen.
2815
2816         Add a unit test to verify that activating links with 'download' attributes now
2817         navigates to the linked resource, rather than starts downloading it. Add another
2818         to verify that it is still possible to explicitly download the link via the
2819         'Download' navigation action policy.
2820
2821         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2822         (-[DownloadAttributeTestDelegate init]):
2823         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2824         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2825         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2826         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2827         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2828         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2829         (TEST):
2830         * WebKitTestRunner/TestController.cpp:
2831         (WTR::TestController::decidePolicyForNavigationAction):
2832         * WebKitTestRunner/TestController.h:
2833
2834 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2835
2836         [Curl] Implement Cookie Accept Policy.
2837         https://bugs.webkit.org/show_bug.cgi?id=191645
2838
2839         Reviewed by Fujii Hironori.
2840
2841         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2842         (TestWebKitAPI::Curl::TEST_F):
2843
2844 2019-03-05  Youenn Fablet  <youenn@apple.com>
2845
2846         Rename requestCacheStorageSpace to requestStorageSpace
2847         https://bugs.webkit.org/show_bug.cgi?id=195282
2848
2849         Reviewed by Chris Dumez.
2850
2851         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2852         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2853         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2854
2855 2019-03-05  Brady Eidson  <beidson@apple.com>
2856
2857         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2858         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2859
2860         Reviewed by Tim Horton.
2861
2862         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2863         different directory into that same WKWebView should work.
2864
2865         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2866         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2867
2868 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2869
2870         Add WeakHashSet
2871         https://bugs.webkit.org/show_bug.cgi?id=195152
2872
2873         Reviewed by Antti Koivisto.
2874
2875         Added tests for WeakHashSet.
2876
2877         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2878         (TestWebKitAPI::Base::Base): Moved.
2879         (TestWebKitAPI::Derived::foo): Moved.
2880         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2881         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2882         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2883         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2884
2885 2019-03-04  Chris Dumez  <cdumez@apple.com>
2886
2887         Do not share WebProcesses between private and regular sessions
2888         https://bugs.webkit.org/show_bug.cgi?id=195189
2889         <rdar://problem/48421064>
2890
2891         Reviewed by Alex Christensen.
2892
2893         Add API test coverage.
2894
2895         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2896         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2897
2898 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2899
2900         [WPE] Enable web process sandbox
2901         https://bugs.webkit.org/show_bug.cgi?id=195169
2902
2903         Reviewed by Daniel Bates.
2904
2905         * wpe/install-dependencies:
2906         * wpe/jhbuild.modules:
2907
2908 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2909
2910         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2911         https://bugs.webkit.org/show_bug.cgi?id=195206
2912
2913         Reviewed by Žan Doberšek.
2914
2915         Add a new test case.
2916
2917         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2918         (testJSCClass):
2919
2920 2019-03-04  Charlie Turner  <cturner@igalia.com>
2921
2922         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2923         https://bugs.webkit.org/show_bug.cgi?id=194898
2924
2925         Reviewed by Žan Doberšek.
2926
2927         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2928         a GCC extension that permits arithmetic on void* pointer. Inline
2929         the macro until this issue is fixed upstream.
2930
2931 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2932
2933         Rid the world of WK_API_ENABLED
2934         https://bugs.webkit.org/show_bug.cgi?id=195263
2935
2936         Reviewed by Dan Bernstein.
2937
2938         List of changed files elided because it's useless.
2939
2940 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2941
2942         Unreviewed follow-up to r242292.
2943
2944         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2945
2946         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2947         (TestWebKitAPI::testStrip): Renamed from strip.
2948         (TestWebKitAPI::TEST):
2949
2950 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2951
2952         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2953
2954         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2955         and bug #194272 for details.
2956
2957         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2958
2959 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2960
2961         Remove some more unused 32-bit code
2962         https://bugs.webkit.org/show_bug.cgi?id=195255
2963
2964         Reviewed by Darin Adler.
2965
2966         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2967         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2968         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2969         (NPP_New):
2970         (NPP_HandleEvent):
2971         (handleEventCarbon): Deleted.
2972
2973 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2974
2975         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2976
2977         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2978         (TestWebKitAPI::TEST):
2979
2980 2019-03-01  Darin Adler  <darin@apple.com>
2981
2982         Finish removing String::format
2983         https://bugs.webkit.org/show_bug.cgi?id=194893
2984
2985         Reviewed by Daniel Bates.
2986 '
2987         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2988
2989 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2990
2991         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2992         https://bugs.webkit.org/show_bug.cgi?id=195229
2993         <rdar://problem/48520362>
2994
2995         Reviewed by Chris Dumez.
2996
2997         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2998         (TEST):
2999
3000 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3001
3002         Add a system trace scope for event region building
3003         https://bugs.webkit.org/show_bug.cgi?id=195226
3004
3005         Reviewed by Jon Lee.
3006
3007         This trace scope measures the time spend converting element rects into Region objects,
3008         which can be large on some pages.
3009
3010         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3011
3012         * Tracing/SystemTracePoints.plist:
3013
3014 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3015
3016         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3017         https://bugs.webkit.org/show_bug.cgi?id=194612
3018
3019         Reviewed by Alex Christensen.
3020
3021         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3022         Just test the new string-processing function and don't touch the actual environment.
3023         (Test cases are all as before, but based on operator== instead of strcmp.)
3024
3025 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3026
3027         [ews-app] Update primary keys for handling multiple Buildbot instances
3028         https://bugs.webkit.org/show_bug.cgi?id=195120
3029
3030         Reviewed by Stephanie Lewis.
3031
3032         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3033         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3034         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3035
3036         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3037         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3038         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3039         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3040         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3041         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3042
3043 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3044
3045         [WinCairo] Enable service worker
3046         https://bugs.webkit.org/show_bug.cgi?id=188318
3047
3048         Reviewed by Youenn Fablet.
3049
3050         * DumpRenderTree/DumpRenderTreePrefix.h:
3051         * TestWebKitAPI/PlatformWin.cmake:
3052         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3053         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3054         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3055
3056 2019-03-01  Justin Fan  <justin_fan@apple.com>
3057
3058         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3059         https://bugs.webkit.org/show_bug.cgi?id=195191
3060
3061         Rubber-stamped by Dean Jackson.
3062
3063         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3064
3065         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3066
3067 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3068
3069         Unreviewed, fix lldb webkitpy tests
3070         https://bugs.webkit.org/show_bug.cgi?id=194375
3071
3072         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3073
3074         * lldb/lldb_webkit.py:
3075         (WTFStringImplProvider.is_8bit):
3076
3077 2019-02-28  David Quesada  <david_quesada@apple.com>
3078
3079         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3080         https://bugs.webkit.org/show_bug.cgi?id=195121
3081         rdar://problem/48450302
3082
3083         Reviewed by Alex Christensen.
3084
3085         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3086         configurations where the 'download' attribute is absent, blank, or populated
3087         with a filename, and where the anchor element is same-origin or cross-origin
3088         (meaning the 'download' attribute shouldn't be honored).
3089
3090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3091         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3092         (-[NavigationActionTestDelegate init]):
3093         (-[NavigationActionTestDelegate navigationAction]):
3094         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3095         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3096         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3097         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3098         (TEST):
3099
3100 2019-02-28  Antoine Quint  <graouts@apple.com>
3101
3102         Enable the Pointer Events runtime flag by default
3103         https://bugs.webkit.org/show_bug.cgi?id=195156
3104
3105         Reviewed by Dean Jackson.
3106
3107         * DumpRenderTree/mac/DumpRenderTree.mm:
3108         (enableExperimentalFeatures):
3109
3110 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3111
3112         Several PasteImage API tests are flaky
3113         https://bugs.webkit.org/show_bug.cgi?id=195160
3114
3115         Reviewed by Tim Horton.
3116
3117         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3118         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3119         listening for a "load" event after image load is already complete.
3120
3121         To address this, make these tests first register a "load" event handler, then run script to insert an image
3122         element into the document, and finally wait until the load event is observed before checking image size.
3123
3124         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3125
3126 2019-02-28  Chris Dumez  <cdumez@apple.com>
3127
3128         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3129         https://bugs.webkit.org/show_bug.cgi?id=195107
3130
3131         Reviewed by Alex Christensen.
3132
3133         Give some time for the zoom level to get restored.
3134
3135         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3136
3137 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3138
3139         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3140         https://bugs.webkit.org/show_bug.cgi?id=194958
3141
3142         Reviewed by Geoffrey Garen.
3143
3144         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3145         (TEST):
3146
3147 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3148
3149         [ews-app] Update method to save build to handle builder_display_name
3150         https://bugs.webkit.org/show_bug.cgi?id=195047
3151
3152         Reviewed by Dewei Zhu.
3153
3154         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3155         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3156
3157 2019-02-28  Justin Fan  <justin_fan@apple.com>
3158
3159         [Web GPU] Enable Web GPU only on 64-bit
3160         https://bugs.webkit.org/show_bug.cgi?id=195139
3161
3162         Because Metal is only supported on 64 bit apps.
3163
3164         Unreviewed build fix.
3165
3166         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3167
3168 2019-02-27  Youenn Fablet  <youenn@apple.com>
3169
3170         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3171         https://bugs.webkit.org/show_bug.cgi?id=194959
3172
3173         Reviewed by Chris Dumez.
3174
3175         Spin loop until getting the condition to remove flakiness.
3176
3177         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3178
3179 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3180
3181         [ews-build] Buildbot should include builder_display_name in the build events
3182         https://bugs.webkit.org/show_bug.cgi?id=195045
3183
3184         Reviewed by Dewei Zhu.
3185
3186         * BuildSlaveSupport/ews-build/events.py:
3187         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3188         buildername to builder_name to be consistent in naming style.
3189         (Events.buildFinished): Ditto.
3190
3191 2019-02-27  Chris Dumez  <cdumez@apple.com>
3192
3193         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3194         https://bugs.webkit.org/show_bug.cgi?id=194480
3195
3196         Reviewed by Brady Eidson.
3197
3198         Update existing API test to make it more likely to reproduce the issue.
3199
3200         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3201
3202 2019-02-27  Brady Eidson  <beidson@apple.com>
3203
3204         Universal links from Google search results pages don't open the app.
3205         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3206
3207         Reviewed by Geoffrey Garen.
3208
3209         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3210         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3211         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3212         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3213
3214 2019-02-27  Chris Dumez  <cdumez@apple.com>
3215
3216         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3217         https://bugs.webkit.org/show_bug.cgi?id=195102
3218
3219         Reviewed by Geoffrey Garen.
3220
3221         If the number of processes is not yet what we expect, wait a bit and check again to give
3222         processes some time to exit.
3223
3224         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3225
3226 2019-02-27  Chris Dumez  <cdumez@apple.com>
3227
3228         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3229         https://bugs.webkit.org/show_bug.cgi?id=194545
3230
3231         Reviewed by Brady Eidson.
3232
3233         Make sure the test navigates forward and then back only once. Previously, navigating
3234         back would trigger a navigation again in a timer.
3235
3236         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3237
3238 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3239
3240         High Sierra Debug JSC test queue should use faster hardware
3241         https://bugs.webkit.org/show_bug.cgi?id=194603
3242
3243         Rubber-stamped by Alexey Proskuryakov.
3244
3245         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3246
3247         * BuildSlaveSupport/build.webkit.org-config/config.json:
3248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3249         (BubbleQueueServer):
3250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3251         (WebKitBuildbot):
3252         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3253         * QueueStatusServer/config/queues.py:
3254         * Scripts/webkitpy/common/config/ews.json:
3255         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3256         (test_ews_name):
3257
3258 2019-02-27  John Wilander  <wilander@apple.com>
3259
3260         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3261         https://bugs.webkit.org/show_bug.cgi?id=195071
3262         <rdar://problem/48417690>
3263
3264         Reviewed by Alex Christensen and Brent Fulgham.
3265
3266         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3267         (TestWebKitAPI::createURL):
3268             Convenience function.
3269         (TestWebKitAPI::TEST):
3270             WebCore::AdClickAttribution now takes a URL when creating Source and
3271             Destination.
3272         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3273         (TestWebKitAPI::TEST):
3274             WebCore::AdClickAttribution now takes a URL when creating Source and
3275             Destination.
3276
3277 2019-02-27  Antoine Quint  <graouts@apple.com>
3278
3279         Support Pointer Events on macOS
3280         https://bugs.webkit.org/show_bug.cgi?id=195008
3281         <rdar://problem/47454419>
3282
3283         Reviewed by Dean Jackson.
3284
3285         * DumpRenderTree/mac/DumpRenderTree.mm:
3286         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3287         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3288
3289 2019-02-26  Mark Lam  <mark.lam@apple.com>
3290
3291         Remove remaining poisoning code.
3292         https://bugs.webkit.org/show_bug.cgi?id=194138
3293
3294         Reviewed by Saam Barati.
3295
3296         * TestWebKitAPI/CMakeLists.txt:
3297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3298         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3299         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3300         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3301         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3302         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3303         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3304
3305 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3306
3307         Move ephemeral local storage from WebProcess to UIProcess
3308         https://bugs.webkit.org/show_bug.cgi?id=195074
3309         <rdar://problem/47937975>
3310
3311         Reviewed by Geoff Garen.
3312
3313         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3314
3315 2019-02-20  Jer Noble  <jer.noble@apple.com>
3316
3317         [Cocoa] Media elements will restart network buffering just before suspending
3318         https://bugs.webkit.org/show_bug.cgi?id=193691
3319
3320         Reviewed by Eric Carlson.
3321
3322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3323         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3324         (TEST):
3325
3326 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3327
3328         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3329         https://bugs.webkit.org/show_bug.cgi?id=191652
3330
3331         Reviewed by Alex Christensen.
3332
3333         Fix WinCairo MiniBrowser behavior of authentication dialog.
3334
3335         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3336         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3337
3338 2019-02-26  Youenn Fablet  <youenn@apple.com>
3339
3340         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3341         https://bugs.webkit.org/show_bug.cgi?id=195028
3342         <rdar://problem/48243733>
3343
3344         Reviewed by Eric Carlson.
3345
3346         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3347
3348 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3349
3350         [WPE] Add API for webview background color configuration
3351         https://bugs.webkit.org/show_bug.cgi?id=192305
3352
3353         Reviewed by Michael Catanzaro.
3354
3355         * MiniBrowser/wpe/main.cpp:
3356         (main): Add a new option to configure the webview background
3357         color. Example: --bg-color=transparent.
3358         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3359         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3360         (beforeAll): Ditto.
3361
3362 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3363
3364         scalableNativeWebpageParameters() is not preserved on new page navigation.
3365         https://bugs.webkit.org/show_bug.cgi?id=194892
3366         <rdar://problem/47538280>
3367
3368         Reviewed by Wenson Hsieh.
3369         
3370         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3371
3372         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3373         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3374         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3375         (WTR::UIScriptController::allowsViewportShrinkToFit):
3376         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3377         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3378         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3379         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3380         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3381         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3382
3383 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3384
3385         [ews-app] Add model for handling multiple Buildbot instances
3386         https://bugs.webkit.org/show_bug.cgi?id=194863
3387
3388         Reviewed by Stephanie Lewis.
3389
3390         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3391
3392 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3393
3394         [ews-app] Remove BuilderMapping table
3395         https://bugs.webkit.org/show_bug.cgi?id=194961
3396
3397         Reviewed by Stephanie Lewis.
3398
3399         Store builder name directly in build table, instead of having a separate
3400         table for it.
3401
3402         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3403         * BuildSlaveSupport/ews-app/ews/models/build.py:
3404         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3405         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3406
3407 2019-02-25  John Wilander  <wilander@apple.com>
3408
3409         Introduce and adopt new class RegistrableDomain for eTLD+1
3410         https://bugs.webkit.org/show_bug.cgi?id=194791
3411         <rdar://problem/48179240>
3412
3413         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3414
3415         This patch adds an API test and replaces two instances of
3416         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3417
3418         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3419         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3420         (TestWebKitAPI::TEST):
3421             Changed two strings to make sure the registrable domains are still considered
3422             invalid and pass the test.
3423         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3424         (TestWebKitAPI::TEST):
3425         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3426         (WTR::InjectedBundle::didReceiveMessageToPage):
3427
3428 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3429
3430         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3431         https://bugs.webkit.org/show_bug.cgi?id=195001
3432
3433         Reviewed by Carlos Garcia Campos.
3434
3435         API version 1.0 always includes the functionality previously guarded with
3436         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3437         unconditionally.
3438
3439         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3440         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3441         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3442         (WebViewTest::showInWindow): Ditto.
3443         (WebViewTest::hideView): Ditto.
3444         * wpe/backends/HeadlessViewBackend.cpp:
3445         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3446         * wpe/backends/ViewBackend.cpp:
3447         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3448         * wpe/backends/WindowViewBackend.cpp:
3449         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3450         WPE_BACKEND_CHECK_VERSION().
3451         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3452
3453 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3454
3455         [Flatpak] Add support for flatpak > 1.1.2
3456         https://bugs.webkit.org/show_bug.cgi?id=194088
3457
3458         Flatpak 1.2 is now out so we need to support that
3459         version now.
3460
3461         Reviewed by Michael Catanzaro.
3462
3463         * flatpak/flatpakutils.py:
3464         (check_flatpak):
3465         (FlatpakPackages.__init__):
3466         (FlatpakPackages.__detect_packages):
3467         (FlatpakPackages.__detect_packages.in):
3468         (FlatpakRepos.update):
3469
3470 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3471
3472         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3473         https://bugs.webkit.org/show_bug.cgi?id=194998
3474
3475         Reviewed by Carlos Garcia Campos.
3476
3477         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3478         to a Git checkout and using the latest commit containing various fixes
3479         and improvements.
3480
3481 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3482
3483         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3484         https://bugs.webkit.org/show_bug.cgi?id=194981
3485
3486         Reviewed by Žan Doberšek.
3487
3488         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3489         (TestWebKitAPI::TEST):
3490
3491 2019-02-23  Keith Miller  <keith_miller@apple.com>
3492
3493         Add new mac target numbers
3494         https://bugs.webkit.org/show_bug.cgi?id=194955
3495
3496         Reviewed by Tim Horton.
3497
3498         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3499         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3500         * MiniBrowser/Configurations/Base.xcconfig:
3501         * TestWebKitAPI/Configurations/Base.xcconfig:
3502         * WebKitTestRunner/Configurations/Base.xcconfig:
3503
3504 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3505
3506         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3507         https://bugs.webkit.org/show_bug.cgi?id=194846
3508
3509         Reviewed by Don Olmstead.
3510
3511         Added _search_paths() and _port_specific_expectations_files() for
3512         WinCairoPort.
3513
3514         * Scripts/webkitpy/port/win.py:
3515         (WinCairoPort.default_baseline_search_path):
3516         (WinCairoPort):
3517         (WinCairoPort._port_specific_expectations_files):
3518         (WinCairoPort._search_paths):
3519
3520 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3521
3522         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3523         https://bugs.webkit.org/show_bug.cgi?id=194963
3524
3525         Reviewed by Dean Jackson.
3526
3527         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3528         Do a `contains` check instead of `equals`, because in debug builds we
3529         put the GraphicsLayer pointer in a prefix.
3530
3531 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3532
3533         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3534         https://bugs.webkit.org/show_bug.cgi?id=194873
3535         <rdar://problem/46701974>
3536
3537         Reviewed by Tim Horton.
3538
3539         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3540
3541         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3542         (WTR::UIScriptController::menuRect const):
3543         (WTR::UIScriptController::isShowingMenu const):
3544         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3545         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3546         (WTR::UIScriptController::menuRect const):
3547
3548         Add a function to query the bounds of the callout menu in content coordinates.
3549
3550         (WTR::UIScriptController::isShowingMenu const):
3551
3552         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3553
3554         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3555         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3556         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3557         (WTR::UIScriptController::rectForMenuAction const):
3558         (WTR::UIScriptController::menuRect const):
3559         (WTR::UIScriptController::isShowingMenu const):
3560         (WTR::findViewInHierarchyOfType): Deleted.
3561
3562 2019-02-22  Chris Dumez  <cdumez@apple.com>
3563
3564         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3565         https://bugs.webkit.org/show_bug.cgi?id=194954
3566         <rdar://problem/48127957>
3567
3568         Reviewed by Alex Christensen.
3569
3570         Add API test coverage.
3571
3572         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3573         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3574         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3575         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3576
3577 2019-02-22  Chris Dumez  <cdumez@apple.com>
3578
3579         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3580         https://bugs.webkit.org/show_bug.cgi?id=194924
3581         <rdar://problem/48216125>
3582
3583         Reviewed by Geoffrey Garen.
3584
3585         Add API test coverage.
3586
3587         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3588
3589 2019-02-22  Chris Dumez  <cdumez@apple.com>
3590
3591         Unreviewed, disable API test added in r241928 on iOS.
3592
3593         The cache is not enabled on devices with less than 3GB of RAM.
3594
3595         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3596
3597 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3598
3599         Hardcode Visual Viewports on everywhere except iOS WK1
3600         https://bugs.webkit.org/show_bug.cgi?id=194928
3601
3602         Reviewed by Zalan Bujtas.
3603
3604         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3605         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3606         set it to false. The setting has shipped for several years and there's no need to turn
3607         it off now.
3608
3609         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3610         Visual Viewports are not enabled.
3611         
3612         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3613         that only runs in WK2
3614
3615         * MiniBrowser/mac/SettingsController.h:
3616         * MiniBrowser/mac/SettingsController.m:
3617         (-[SettingsController init]):
3618         (-[SettingsController _populateMenu]):
3619         (-[SettingsController validateMenuItem:]):
3620         (-[SettingsController visualViewportEnabled]): Deleted.
3621         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3622         * MiniBrowser/mac/WK1BrowserWindowController.m:
3623         (-[WK1BrowserWindowController didChangeSettings]):
3624         * MiniBrowser/mac/WK2BrowserWindowController.m:
3625         (-[WK2BrowserWindowController didChangeSettings]):
3626
3627 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3628
3629         Discard cached processes when clearing website data store
3630         https://bugs.webkit.org/show_bug.cgi?id=194894
3631
3632         Reviewed by Chris Dumez.
3633
3634         Added a test case.
3635
3636         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3637         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3638
3639 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3640
3641         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3642         https://bugs.webkit.org/show_bug.cgi?id=194914
3643         <rdar://problem/47586889>
3644
3645         Reviewed by Geoffrey Garen.
3646
3647         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3648         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3649         (TEST):
3650         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3651
3652 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3653
3654         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3655         <https://webkit.org/b/194761>
3656
3657         Reviewed by Myles Maxfield.
3658
3659         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3660         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3661         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3662         to use ARC-compliant cast.
3663         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3664         ARC-compliant cast.
3665         (WTR::installFakeHelvetica): Log `error` to console if
3666         CTFontManagerRegisterFontsForURL() fails, but only on supported
3667         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3668         Call CFRelease() on `error` to fix the leak.  Update to use
3669         ARC-compliant cast.
3670         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3671         cast.
3672
3673 2019-02-21  Chris Dumez  <cdumez@apple.com>
3674
3675         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3676         https://bugs.webkit.org/show_bug.cgi?id=194481
3677
3678         Reviewed by Alex Christensen.
3679
3680         Give the processes a chance to shutdown and wait until we reached the expected number
3681         of processes.
3682
3683         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3684
3685 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3686
3687         Fix the macOS build
3688
3689         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3690
3691 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3692
3693         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3694
3695         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3696         I am a backwards.
3697
3698 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3699
3700         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3701
3702         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3703         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3704         We could force on UI-side compositing, but I feel like the test might be more
3705         valuable exercising the normal path on each platform (though the original
3706         bug was also UI-side specific). Though we can't validate that the overlay
3707         layer was installed successfully, there are layout tests that do that.
3708
3709 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3710
3711         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3712         https://bugs.webkit.org/show_bug.cgi?id=194845
3713         <rdar://problem/47944579>
3714
3715         Reviewed by Antti Koivisto.
3716
3717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3718         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3719
3720 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3721
3722         [LFC][Floats] Add support for placing formatting roots in-between floats.
3723         https://bugs.webkit.org/show_bug.cgi?id=194902
3724
3725         Reviewed by Antti Koivisto.
3726
3727         * LayoutReloaded/misc/LFC-passing-tests.txt:
3728
3729 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3730
3731         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3732         https://bugs.webkit.org/show_bug.cgi?id=194901
3733
3734         Unreviewed build fix.
3735
3736         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3737         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3738         WPEBackend-fdo-0.1 as library name.
3739
3740 2019-02-21  Rob Buis  <rbuis@igalia.com>
3741
3742         Update MIME type parser
3743         https://bugs.webkit.org/show_bug.cgi?id=180526
3744
3745         Reviewed by Darin Adler.
3746
3747         Add tests involving leading and trailing whitespace, non-token
3748         characters and quoted strings.
3749
3750         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3751         (TestWebKitAPI::TEST):
3752
3753 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3754
3755         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3756         https://bugs.webkit.org/show_bug.cgi?id=194884
3757
3758         Reviewed by Michael Catanzaro.
3759
3760         * PlatformWin.cmake:
3761
3762 2019-02-20  Chris Dumez  <cdumez@apple.com>
3763
3764         Add API test for <rdar://problem/47471222>
3765         https://bugs.webkit.org/show_bug.cgi?id=194847
3766
3767         Reviewed by Alex Christensen.
3768
3769         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3770
3771 2019-02-20  Chris Dumez  <cdumez@apple.com>
3772
3773         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
3774         https://bugs.webkit.org/show_bug.cgi?id=194872
3775         <rdar://problem/47924500>
3776
3777         Reviewed by Alex Christensen.
3778
3779         Add API test coverage.
3780
3781         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3782
3783 2019-02-20  Jer Noble  <jer.noble@apple.com>
3784
3785         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
3786         https://bugs.webkit.org/show_bug.cgi?id=191332
3787
3788         Reviewed by Dean Jackson.
3789
3790         * Scripts/git-is-in-range: Added.
3791
3792 2019-02-20  Andy Estes  <aestes@apple.com>
3793
3794         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
3795         https://bugs.webkit.org/show_bug.cgi?id=194869
3796
3797         Rubber-stamped by Jer Noble.
3798
3799         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3800         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
3801         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3802         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3804         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3805
3806 2019-02-20  Chris Dumez  <cdumez@apple.com>
3807
3808         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
3809         https://bugs.webkit.org/show_bug.cgi?id=194857
3810         <rdar://problem/47759323>
3811
3812         Reviewed by Alex Christensen.
3813
3814         Add API test coverage.
3815
3816         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3817
3818 2019-02-20  Chris Dumez  <cdumez@apple.com>
3819
3820         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3821         https://bugs.webkit.org/show_bug.cgi?id=194829
3822         <rdar://problem/47889906>
3823
3824         Reviewed by Alexey Proskuryakov.
3825
3826         Every time the TestOptions were changing we were creating both a new Web view and
3827         a new WKContext, which would start a new Network process. In most cases, we only
3828         need to contruct a new Web view and we do can keep reusing the same WKContext.
3829         This patch implements this optimization and thus avoids spinning a lot of new
3830         Network processes while running the layout tests.
3831
3832         * WebKitTestRunner/TestController.cpp:
3833         (WTR::TestController::generateContextConfiguration const):
3834         (WTR::TestController::generatePageConfiguration):
3835         (WTR::TestController::createWebViewWithOptions):
3836         (WTR::TestController::resetPreferencesToConsistentValues):
3837         (WTR::updateTestOptionsFromTestHeader):
3838         * WebKitTestRunner/TestController.h:
3839         * WebKitTestRunner/TestOptions.h:
3840         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3841         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3842         (WTR::TestOptions::hasSameInitializationOptions const):
3843         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3844         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3845         (WTR::TestController::platformAddTestOptions const):
3846
3847 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3848
3849         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3850         https://bugs.webkit.org/show_bug.cgi?id=167941
3851
3852         Reviewed by Carlos Garcia Campos.
3853
3854         * MiniBrowser/gtk/main.c:
3855         (filterSavedCallback): Added.
3856         (main): Support loading a JSON rule set file for content filtering.
3857         * MiniBrowser/wpe/main.cpp:
3858         (filterSavedCallback): Added.
3859         (main): Support loading a JSON rule set file for content filtering.
3860         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3861         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3862         (WTF::derefGPtr): Ditto.
3863         (testEmptyStore):
3864         (testSaveInvalidFilter):
3865         (testSaveLoadFilter):
3866         (testSavedFilterIdentifierMatch):
3867         (testRemoveFilter):
3868         (testSaveMultipleFilters):
3869         (testSaveFilterFromFile):
3870         (testFilterPersistence):
3871         (beforeAll):
3872         (afterAll):
3873         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3874         (removeOldInjectedContentAndResetLists): Also reset content filters.
3875         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3876         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3877         the element affected by the style sheet.
3878         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3879         and returns it to be used by tests.
3880         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3881         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3882         (serverCallback): Add support for serving a CSS style sheet for testing.
3883         (beforeAll): Add call to testUserContentManagerContentFilter().
3884         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3885
3886 2019-02-19  Keith Rollin  <krollin@apple.com>
3887
3888         Add timing information to build output
3889         https://bugs.webkit.org/show_bug.cgi?id=194839
3890         <rdar://problem/48219609>
3891
3892         Reviewed by Alexey Proskuryakov.
3893
3894         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3895         emit each project's build time to its output. E.g.,
3896
3897             ** BUILD SUCCEEDED ** [0.132 sec]
3898
3899         * Scripts/webkitdirs.pm:
3900         (XcodeOptions):
3901
3902 2019-02-19  Truitt Savell  <tsavell@apple.com>
3903
3904         Unreviewed, rolling out r241784.
3905
3906         Broke all OpenSource builds.
3907
3908         Reverted changeset:
3909
3910         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3911         instances view"
3912         https://bugs.webkit.org/show_bug.cgi?id=172848
3913         https://trac.webkit.org/changeset/241784
3914
3915 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3916
3917         [LFC][Floats] Remove redundant intersecting logic
3918         https://bugs.webkit.org/show_bug.cgi?id=194804
3919
3920         Reviewed by Antti Koivisto.
3921
3922         * LayoutReloaded/misc/LFC-passing-tests.txt:
3923
3924 2019-02-19  Dean Jackson  <dino@apple.com>
3925
3926         Clean-up output from generate-xcfilelists so it can be filtered
3927         https://bugs.webkit.org/show_bug.cgi?id=194795
3928
3929         Reviewed by Joseph Pecoraro (and Keith Rollin).
3930
3931         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3932         make a slight tweak to filter-build-webkit so such lines are marked
3933         as plain.
3934
3935         * Scripts/filter-build-webkit:
3936         * Scripts/generate-xcfilelists:
3937
3938 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3939
3940         pytest is not correctly auto-installed
3941         https://bugs.webkit.org/show_bug.cgi?id=194707
3942
3943         Reviewed by Carlos Garcia Campos.
3944
3945         * Scripts/webkitpy/thirdparty/__init__.py:
3946         (AutoinstallImportHook._install_pytest):
3947
3948 2019-02-18  Chris Dumez  <cdumez@apple.com>
3949
3950         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3951         https://bugs.webkit.org/show_bug.cgi?id=194797
3952         <rdar://problem/48055151>
3953
3954         Reviewed by Geoffrey Garen.
3955
3956         Add API test coverage.
3957
3958         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3959
3960 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3961
3962         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3963         https://bugs.webkit.org/show_bug.cgi?id=194670
3964         <rdar://problem/39066529>
3965
3966         Reviewed by Tim Horton.
3967
3968         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3969         pasted in an editable area as attachment elements.
3970
3971         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3972         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3973         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3974         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3975         (TestWebKitAPI::TEST):
3976         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3977         (WTR::InjectedBundlePage::InjectedBundlePage):
3978
3979 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3980
3981         Fix API test after r241728
3982        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3983
3984         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3985         (TEST):
3986         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3987
3988 2019-02-18  Daniel Bates  <dabates@apple.com>
3989
3990         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3991         https://bugs.webkit.org/show_bug.cgi?id=192824
3992         <rdar://problem/47100332>
3993
3994         Reviewed by Wenson Hsieh.
3995
3996         Fix a bug where the wrong usage code was used for F13 thru F24.
3997
3998         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3999         (keyCodeForDOMFunctionKey):
4000
4001 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4002
4003         Bytecode cache should a have a boot-specific validation
4004         https://bugs.webkit.org/show_bug.cgi?id=194769
4005         <rdar://problem/48149509>
4006
4007         Reviewed by Keith Miller.
4008
4009         Add test for WTF::bootSessionUUIDString()
4010
4011         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4012         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4013         (TEST):
4014
4015 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4016
4017         Disable safe browsing in WKWebView and remove its WKPreferences API
4018         https://bugs.webkit.org/show_bug.cgi?id=194723
4019         <rdar://problem/48122993>
4020
4021         Reviewed by Geoffrey Garen.
4022
4023         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4024         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4025         (TEST):
4026         (safeBrowsingView):
4027         Make tests use SPI instead of API.
4028
4029 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4030
4031         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4032         https://bugs.webkit.org/show_bug.cgi?id=194586
4033
4034         Reviewed by Ross Kirsling.
4035
4036         * DumpRenderTree/win/DumpRenderTree.cpp:
4037         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4038         * Scripts/webkitpy/port/driver.py:
4039         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4040
4041 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4042
4043         Unreviewed, rolling out r241620.
4044
4045         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4046         (Requested by ddkilzer on #webkit.)
4047
4048         Reverted changeset:
4049
4050         "[WTF] Add environment variable helpers"
4051         https://bugs.webkit.org/show_bug.cgi?id=192405
4052         https://trac.webkit.org/changeset/241620
4053
4054 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4055
4056         [LFC] RenderImage's default intrinsic size is 0.
4057         https://bugs.webkit.org/show_bug.cgi?id=194745
4058
4059         Reviewed by Antti Koivisto.
4060
4061         * LayoutReloaded/misc/LFC-passing-tests.txt:
4062
4063 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4064
4065         [LFC][BFC] Add support for block replaced intrinsic width.
4066         https://bugs.webkit.org/show_bug.cgi?id=194705
4067
4068         Reviewed by Simon Fraser.
4069
4070         * LayoutReloaded/misc/LFC-passing-tests.txt:
4071
4072 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4073
4074         [LFC] Apply min/max width constraints to preferred width computation
4075         https://bugs.webkit.org/show_bug.cgi?id=194739
4076
4077         Reviewed by Simon Fraser.
4078
4079         * LayoutReloaded/misc/LFC-passing-tests.txt:
4080
4081 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
4082
4083         [WTF] Add environment variable helpers
4084         https://bugs.webkit.org/show_bug.cgi?id=192405
4085
4086         Reviewed by Michael Catanzaro.
4087
4088         * DumpRenderTree/mac/DumpRenderTree.mm:
4089         (libraryPathForDumpRenderTree):
4090         * DumpRenderTree/win/DumpRenderTree.cpp:
4091         (libraryPathForDumpRenderTree):
4092         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4093         (setUpIOSLayoutTestCommunication):
4094         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4095         (beforeAll):
4096         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4097         (main):
4098         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4099         (WebKitTestBus::run):
4100         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4101         (WTR::getOutputDir):
4102         (WTR::initializeFontConfigSetting):
4103         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4104         (WTR::InjectedBundle::platformInitialize):
4105         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4106         (WTR::topLevelPath):
4107         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4108         (WTR::topLevelPath):
4109         (WTR::getOutputDir):
4110         (WTR::activateFonts):
4111         * WebKitTestRunner/TestController.cpp:
4112         (WTR::TestController::libraryPathForTesting):
4113         (WTR::TestController::generateContextConfiguration const):
4114         (WTR::TestController::generatePageConfiguration):
4115         (WTR::TestController::decideDestinationWithSuggestedFilename):
4116         (WTR::TestController::platformAdjustContext):
4117         * WebKitTestRunner/TestController.h:
4118         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4119         (WTR::TestController::cocoaPlatformInitialize):
4120         (WTR::TestController::platformAdjustContext):
4121         * WebKitTestRunner/gtk/main.cpp:
4122         (main):
4123         * WebKitTestRunner/mac/TestControllerMac.mm:
4124         (WTR::TestController::configureContentExtensionForTest):
4125         * WebKitTestRunner/wpe/main.cpp:
4126         (main):
4127         Utilize WTF::Environment where possible.
4128
4129 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4130
4131         [iOS] WKWebView callout bar is missing Change Writing Direction item
4132         https://bugs.webkit.org/show_bug.cgi?id=190015
4133         <rdar://problem/44810366>
4134
4135         Reviewed by Tim Horton.
4136
4137         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
4138         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4139
4140         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4141         (TestWebKitAPI::TEST):
4142
4143 2019-02-15  Chris Dumez  <cdumez@apple.com>
4144
4145         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
4146         https://bugs.webkit.org/show_bug.cgi?id=194717
4147         <rdar://problem/47884404>
4148
4149         Reviewed by Brady Eidson.
4150
4151         Add API test coverage.
4152
4153         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4154
4155 2019-02-15  Youenn Fablet  <youenn@apple.com>
4156
4157         Make navigator.mediaDevices SecureContext
4158         https://bugs.webkit.org/show_bug.cgi?id=194666
4159
4160         Reviewed by Eric Carlson.
4161
4162         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4163         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
4164         (TEST_F):
4165
4166 2019-02-15  Brian Burg  <bburg@apple.com>
4167
4168         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4169         https://bugs.webkit.org/show_bug.cgi?id=194411
4170         <rdar://problem/47787614>
4171
4172         Reviewed by Joseph Pecoraro.
4173
4174         Remove unnecessary soft linking macro usage.
4175
4176         * DumpRenderTree/mac/TestRunnerMac.mm:
4177         (TestRunner::inspectorTestStubURL):
4178         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4179         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4180         (WTR::TestRunner::inspectorTestStubURL):
4181
4182 2019-02-15  Commit Queue  <commit-queue@webkit.org>
4183
4184         Unreviewed, rolling out r241559 and r241566.
4185         https://bugs.webkit.org/show_bug.cgi?id=194710
4186
4187         Causes layout test crashes under GuardMalloc (Requested by
4188         ryanhaddad on #webkit).
4189
4190         Reverted changesets:
4191
4192         "[WTF] Add environment variable helpers"
4193         https://bugs.webkit.org/show_bug.cgi?id=192405
4194         https://trac.webkit.org/changeset/241559
4195
4196         "Unreviewed build fix for WinCairo Debug after r241559."
4197         https://trac.webkit.org/changeset/241566
4198
4199 2019-02-15  Zalan Bujtas  <zalan@apple.com>
4200
4201         [LFC] Out-of-flow box is never a float box
4202         https://bugs.webkit.org/show_bug.cgi?id=194704
4203
4204         Reviewed by Antti Koivisto.
4205
4206         * LayoutReloaded/misc/LFC-passing-tests.txt:
4207
4208 2019-02-10  Darin Adler  <darin@apple.com>
4209
4210         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
4211         https://bugs.webkit.org/show_bug.cgi?id=194487
4212
4213         Reviewed by Daniel Bates.
4214
4215         * DumpRenderTree/win/DumpRenderTree.cpp:
4216         (applicationId): Use makeString instead of String::format.
4217         (main): Ditto.
4218         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4219         (TestWebKitAPI::Util::createURLForResource): Ditto.
4220         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
4221         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
4222
4223         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4224         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
4225         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
4226         (WTR::createStringWithAttributes): Use appendLiteral.
4227         (WTR::AccessibilityUIElement::helpText const): Ditto.
4228         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
4229         directly instead of using String::format.
4230         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
4231         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
4232
4233 2019-02-15  Truitt Savell  <tsavell@apple.com>
4234
4235         Unreviewed, rolling out r241564.
4236
4237         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
4238
4239         Reverted changeset:
4240
4241         "[Mac] WebInspectorUI.framework does not need to be soft-
4242         linked anymore"
4243         https://bugs.webkit.org/show_bug.cgi?id=194411
4244         https://trac.webkit.org/changeset/241564
4245
4246 2019-02-15  Saam barati  <sbarati@apple.com>
4247
4248         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
4249         https://bugs.webkit.org/show_bug.cgi?id=194036
4250
4251         Reviewed by Yusuke Suzuki.
4252
4253         * Scripts/run-jsc-stress-tests:
4254
4255 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4256
4257         Fix the build.
4258
4259         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4260         (WTR::UIScriptController::drawSquareInEditableImage):
4261         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4262         (TestWebKitAPI::drawSquareInEditableImage):
4263
4264 2019-02-14  Tim Horton  <timothy_horton@apple.com>
4265
4266         Fix the build.
4267
4268         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4269         (WTR::UIScriptController::drawSquareInEditableImage):
4270         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4271         (TestWebKitAPI::drawSquareInEditableImage):
4272
4273 2019-02-14  Brian Burg  <bburg@apple.com>
4274
4275         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
4276         https://bugs.webkit.org/show_bug.cgi?id=194411
4277         <rdar://problem/47787614>
4278
4279         Reviewed by Joseph Pecoraro.
4280
4281         Remove unnecessary soft linking macro usage.
4282
4283         * DumpRenderTree/mac/TestRunnerMac.mm:
4284         (TestRunner::inspectorTestStubURL):
4285         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
4286         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
4287         (WTR::TestRunner::inspectorTestStubURL):
4288
4289 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4290
4291         [ews-app] status bubble should fetch builder name info from BuilderMapping table
4292         https://bugs.webkit.org/show_bug.cgi?id=194599
4293
4294         Reviewed by Lucas Forschler.
4295
4296         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4297         (StatusBubble._build_bubble):
4298
4299 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
4300
4301         [ews-app] Set Foreign Key in Django build model
4302         https://bugs.webkit.org/show_bug.cgi?id=194667
4303
4304         Reviewed by Lucas Forschler.
4305
4306         * BuildSlaveSupport/ews-app/ews/models/build.py:
4307         (Build):
4308
4309 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
4310
4311         [WTF] Add environment variable helpers
4312         https://bugs.webkit.org/show_bug.cgi?id=192405
4313
4314         Reviewed by Michael Catanzaro.
4315
4316         * DumpRenderTree/mac/DumpRenderTree.mm:
4317         (libraryPathForDumpRenderTree):
4318         * DumpRenderTree/win/DumpRenderTree.cpp:
4319         (libraryPathForDumpRenderTree):
4320         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4321         (setUpIOSLayoutTestCommunication):
4322         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4323         (TestWebKitAPI::strip):
4324         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4325         (beforeAll):
4326         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4327         (main):
4328         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4329         (WebKitTestBus::run):
4330         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4331         (WTR::getOutputDir):
4332         (WTR::initializeFontConfigSetting):
4333         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4334         (WTR::InjectedBundle::platformInitialize):
4335         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4336         (WTR::topLevelPath):
4337         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4338         (WTR::topLevelPath):
4339         (WTR::getOutputDir):
4340         (WTR::activateFonts):
4341         * WebKitTestRunner/TestController.cpp:
4342         (WTR::TestController::libraryPathForTesting):
4343         (WTR::TestController::generateContextConfiguration const):
4344         (WTR::TestController::generatePageConfiguration):
4345         (WTR::TestController::decideDestinationWithSuggestedFilename):
4346         (WTR::TestController::platformAdjustContext):
4347         * WebKitTestRunner/TestController.h:
4348         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4349         (WTR::TestController::cocoaPlatformInitialize):
4350         (WTR::TestController::platformAdjustContext):
4351         * WebKitTestRunner/gtk/main.cpp:
4352         (main):
4353         * WebKitTestRunner/mac/TestControllerMac.mm:
4354         (WTR::TestController::configureContentExtensionForTest):
4355         * WebKitTestRunner/wpe/main.cpp:
4356         (main):
4357         Utilize WTF::Environment where possible.