[OS X] Main frame scrollbars should appear on the left on RTL systems
[WebKit-https.git] / Tools / ChangeLog
1 2016-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         [OS X] Main frame scrollbars should appear on the left on RTL systems
4         https://bugs.webkit.org/show_bug.cgi?id=155149
5
6         Reviewed by Simon Fraser.
7
8         Setting the volatile default needs to be done early, so it is
9         plumbed through the injected bundle's initialization routine.
10
11         Control of RTL scrollbars is handled by putting the string
12         <!-- webkit-test-runner [ rtlScrollbars=true ] -->
13         on the first line of a test.
14
15         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
16         (WTR::shouldUseRTLScrollbars):
17         (WTR::InjectedBundle::platformInitialize):
18         * WebKitTestRunner/TestController.cpp:
19         (WTR::TestController::generatePageConfiguration):
20         (WTR::updateTestOptionsFromTestHeader):
21         (WTR::TestController::getInjectedBundleInitializationUserData):
22         * WebKitTestRunner/TestController.h:
23         * WebKitTestRunner/TestOptions.h:
24         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
25         (WTR::PlatformWebView::viewSupportsOptions):
26
27 2016-03-08  Jer Noble  <jer.noble@apple.com>
28
29         Add separate WK and WK2 preferences for requiring user gestures for video media, distinct from user gestures for media generally
30         https://bugs.webkit.org/show_bug.cgi?id=155141
31
32         Reviewed by Beth Dakin.
33
34         Set the default values for media preferences unconditionally, not just on PLATFORM(IOS). Set "video requires user gesture"
35         to sane defaults in addition to "audio requires user gesture" and (in the case of DumpREnderTree) instead of "media requires user gesture".
36
37         Add a new test of WK2 user gesture requirement preferences.
38
39         * DumpRenderTree/mac/DumpRenderTree.mm:
40         (resetWebPreferencesToConsistentValues):
41         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
42         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
43         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
44         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm: Added.
45         (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]):
46         (-[RequiresUserActionForPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
47         (RequiresUserActionForPlaybackTest::SetUp):
48         (RequiresUserActionForPlaybackTest::createWebView):
49         (RequiresUserActionForPlaybackTest::testVideoWithAudio):
50         (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
51         (RequiresUserActionForPlaybackTest::testAudioOnly):
52         (TEST_F):
53         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
54         (TEST):
55
56 2016-03-10  Brian Burg  <bburg@apple.com>
57
58         Web Inspector: should be able to run protocol and input generator scripts from any directory
59         https://bugs.webkit.org/show_bug.cgi?id=155307
60
61         Reviewed by Joseph Pecoraro.
62
63         * Scripts/webkitpy/inspector/main.py:
64         (InspectorGeneratorTests.main):
65         * Scripts/webkitpy/replay/main.py:
66         (InputGeneratorTests.main):
67         Compute the current SCM based on the location of the script being executed, not
68         the $CWD which could be anything. There's rarely a good reason to use $CWD.
69
70 2016-03-10  David Kilzer  <ddkilzer@apple.com>
71
72         [iOS] DumpRenderTree crashes when accessing window.testRunner.inspectorTestStubURL
73         <http://webkit.org/b/155295>
74
75         Reviewed by Brent Fulgham.
76
77         * DumpRenderTree/mac/TestRunnerMac.mm:
78         (TestRunner::inspectorTestStubURL): Always return nullptr for
79         PLATFORM(IOS).  This matches what we did in r192604 for
80         WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm.
81
82 2016-03-10  Frederic Wang  <fwang@igalia.com>
83
84         [GTK] Add support for WOFF2
85         https://bugs.webkit.org/show_bug.cgi?id=152616
86
87         Reviewed by Carlos Garcia Campos.
88
89         * Scripts/webkitpy/style/checker.py: Only verify basic style for third party modules brotli and woff2.
90
91 2016-03-09  Ryosuke Niwa  <rniwa@webkit.org>
92
93         Add runtime flags for shadow DOM and custom elements
94         https://bugs.webkit.org/show_bug.cgi?id=155213
95
96         Reviewed by Dean Jackson.
97
98         Always enable shadow DOM and custom elements during testing.
99
100         * DumpRenderTree/mac/DumpRenderTree.mm:
101         (resetWebPreferencesToConsistentValues):
102         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
103         (WTR::InjectedBundle::beginTesting):
104         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
105         (WTR::TestRunner::setShadowDOMEnabled): Added.
106         * WebKitTestRunner/InjectedBundle/TestRunner.h:
107
108 2016-03-09  Brent Fulgham  <bfulgham@apple.com>
109
110         Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes test breakage
111         https://bugs.webkit.org/show_bug.cgi?id=155265
112         <rdar://problem/11101440>
113
114         Reviewed by Andy Estes.
115
116         WK2 localStorage tests need the 'AllowUniversalAccessFromFileURLs' preference set by default.
117         Tests that confirm blocking localStorage manually set the flag to "False" in the test.
118
119         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
120         (WTR::initializeWebViewConfiguration): Set the default state to the correct value.
121
122 2016-03-09  David Kilzer  <ddkilzer@apple.com>
123
124         check-webkit-style: fix false-positive warnings about @try/@catch blocks in Objective-C++ source files
125         <http://webkit.org/b/155273>
126
127         Reviewed by Andy Estes.
128
129         * Scripts/webkitpy/style/checkers/cpp.py:
130         (check_spacing_for_function_call): Ignore @catch lines.
131         (check_braces): Ditto.
132         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
133         (CppStyleTest.test_brace_at_begin_of_line): Add test case.
134
135 2016-03-09  Jason Marcell  <jmarcell@apple.com>
136
137         Removing reference to Dashboard.Repository.Internal.trac from open source unit tests.
138         https://bugs.webkit.org/show_bug.cgi?id=155274
139
140         Reviewed by Alexey Proskuryakov.
141
142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js:
143         (setup): Deleted. In bug 154180 we removed Dashboard.Repository.Internal which was causing an
144         error in the unit tests.
145
146 2016-03-09  Aakash Jain  <aakash_jain@apple.com>
147
148         use ulimit command to check process limit in webkitpy
149         https://bugs.webkit.org/show_bug.cgi?id=155260
150
151         Reviewed by Alexey Proskuryakov.
152
153         * Scripts/webkitpy/port/ios.py:
154         (IOSSimulatorPort.default_child_processes): Use ulimit command output instead of 
155         launchctl limit maxproc command.
156
157 2016-03-09  Alexey Proskuryakov  <ap@apple.com>
158
159         Stop building armv7 on iOS device builders
160         https://bugs.webkit.org/show_bug.cgi?id=155246
161
162         Reviewed by David Kilzer.
163
164         * BuildSlaveSupport/build.webkit.org-config/config.json: Building both armv7 and
165         armv7s makes the bots unnecessarily slow. We can catch super rare v7-only regressions
166         elsewhere.
167
168         * Scripts/webkitpy/common/config/ews.json: Changed EWS to match, as we always want
169         EWS configuration to be verified by buildbot queues.
170
171         * Scripts/webkitdirs.pm:
172         * Scripts/webkitpy/port/ios.py:
173         Changed default to arm64. I think that the default is probably not used in any
174         practical scenarios, but it's nice to make it more sensible.
175
176 2016-03-09  Alexey Proskuryakov  <ap@apple.com>
177
178         Add iOS Simulator EWS to bot watcher's dashboard
179         https://bugs.webkit.org/show_bug.cgi?id=155220
180
181         Reviewed by Lucas Forschler.
182
183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
184
185 2016-03-09  Brent Fulgham  <bfulgham@apple.com>
186
187         Local HTML should be blocked from localStorage access unless "Disable Local File Restrictions" is checked
188         https://bugs.webkit.org/show_bug.cgi?id=155185
189         <rdar://problem/11101440>
190
191         Reviewed by Anders Carlsson.
192
193         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
194         (TestWebKitAPI::TEST): Allow local file accesss to run test.
195         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
196         (TEST): Ditto.
197         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
198         (TEST): Ditto.
199
200 2016-03-09  Tim Horton  <timothy_horton@apple.com>
201
202         Removing and re-adding a script message handler with the same name results in an unusable message handler
203         https://bugs.webkit.org/show_bug.cgi?id=155223
204
205         Reviewed by Sam Weinig.
206
207         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
208         (TEST):
209         Add a test ensuring that it is possible to remove and re-add a script message handler
210         with the same name and still dispatch messages to it.
211
212 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
213
214         Fix iOS Simulator EWS.
215
216         Unreviewed build fix.
217
218         * Scripts/webkitpy/common/config/ports.py:
219
220 2016-03-08  Aakash Jain  <aakash_jain@apple.com>
221
222         Booting multiple iOS simulator parallely fails sometimes
223         https://bugs.webkit.org/show_bug.cgi?id=155208
224         <rdar://problem/25019651>
225
226         Reviewed by Darin Adler.
227
228         * Scripts/webkitpy/port/ios.py:
229         (IOSSimulatorPort.setup_test_run): Increase the time delay between subsequent
230         simulator boot.
231
232 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
233
234         Add iOS debug testers to flakiness dashboard
235         https://bugs.webkit.org/show_bug.cgi?id=155206
236
237         Reviewed by Darin Adler.
238
239         * TestResultServer/static-dashboards/builders.jsonp:
240
241 2016-03-08  Oliver Hunt  <oliver@apple.com>
242
243         Start moving to separated writable and executable mappings in the JIT
244         https://bugs.webkit.org/show_bug.cgi?id=155178
245
246         Reviewed by Fil Pizlo.
247
248         Making run-jsc-benchmarks slightly happier on my machine.
249
250         * Scripts/run-jsc-benchmarks:
251
252 2016-03-08  Anders Carlsson  <andersca@apple.com>
253
254         Use NSUInteger instead of NSWindowStyleMask.
255
256         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
257
258 2016-03-08  Anders Carlsson  <andersca@apple.com>
259
260         Fix build.
261
262         We intentionally don't use AppKitCompatibilityDeclarations.h here, since we want
263         MiniBrowser to build without WTF.
264
265         * MiniBrowser/mac/AppDelegate.m:
266         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
267         * MiniBrowser/mac/BrowserWindowController.m:
268         (-[BrowserWindowController windowDidLoad]):
269         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
270
271 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
272
273         Add iOS simulator EWS that runs tests
274         https://bugs.webkit.org/show_bug.cgi?id=155175
275
276         Reviewed by Lucas Forschler.
277
278         * QueueStatusServer/config/queues.py:
279         * Scripts/webkitpy/common/config/ews.json:
280         * Scripts/webkitpy/common/config/ports.py:
281
282 2016-03-08  Commit Queue  <commit-queue@webkit.org>
283
284         Unreviewed, rolling out r197793 and r197799.
285         https://bugs.webkit.org/show_bug.cgi?id=155195
286
287         something weird happened while landing this and everything
288         broke (Requested by olliej on #webkit).
289
290         Reverted changesets:
291
292         "Start moving to separated writable and executable mappings in
293         the JIT"
294         https://bugs.webkit.org/show_bug.cgi?id=155178
295         http://trac.webkit.org/changeset/197793
296
297         "arm64 build fix after r197793."
298         http://trac.webkit.org/changeset/197799
299
300 2016-03-08  Oliver Hunt  <oliver@apple.com>
301
302         Start moving to separated writable and executable mappings in the JIT
303         https://bugs.webkit.org/show_bug.cgi?id=155178
304
305         Reviewed by Filip Pizlo.
306
307         Making run-jsc-benchmarks slightly happier on my machine.
308
309         * Scripts/run-jsc-benchmarks:
310
311 2016-03-08  Daniel Bates  <dabates@apple.com>
312
313         Support iterating over an OptionSet and checking if it is empty
314         https://bugs.webkit.org/show_bug.cgi?id=154941
315         <rdar://problem/24964187>
316
317         Reviewed by Darin Adler.
318
319         Add tests to ensure that we do not regression both iteration of an OptionSet and
320         determining whether an OptionSet is empty.
321
322         * TestWebKitAPI/Test.h:
323         (TestWebKitAPI::Util::assertStrongEnum): Helper function to assert two strong enum type for equality.
324         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
325         (TestWebKitAPI::TEST):
326
327 2016-03-08  Alexey Proskuryakov  <ap@apple.com>
328
329         Add debug iOS Simulator bots to the dashboard
330         https://bugs.webkit.org/show_bug.cgi?id=155157
331
332         Reviewed by Darin Adler.
333
334         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
335
336 2016-03-08  Alejandro G. Castro  <alex@igalia.com>
337
338         Unreviewed EFL build fix after r197752.
339
340         * Scripts/webkitperl/FeatureList.pm: Avoid MEDIA_STREAM
341         compilation by default until EFL bumps gstreamer to 1.6.
342
343 2016-03-08  Alejandro G. Castro  <alex@igalia.com>
344
345         [GTK] [EFL] Avoid running mediastream tests by default until we compile by default
346         https://bugs.webkit.org/show_bug.cgi?id=153540
347
348         Reviewed by Philippe Normand.
349
350         After bumping gstreamer to 1.6.3 in r196804 we can enable again
351         compilation of mediastream and running the tests.
352
353         * Scripts/run-gtk-tests:
354         (TestRunner): Enable again the UserMedia API test.
355         * Scripts/webkitperl/FeatureList.pm: Enable the compilation of the
356         mediastream by default.
357         * gtk/jhbuild-webrtc.modules: Removed the specific jhbuild modules
358         file.
359         * gtk/jhbuild.modules: Bumped the openwebrtc version to the one we
360         are currently using.
361
362 2016-03-07  Jon Lee  <jonlee@apple.com>
363
364         Update perf bot configuration for Animometer
365         https://bugs.webkit.org/show_bug.cgi?id=155134
366
367         Reviewed by Ryosuke Niwa.
368
369         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Refactor the patch
370         to work with the latest version of the harness.
371         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Bump up the timeout,
372         and use the latest version of the harness.
373
374 2016-03-07  Joanmarie Diggs  <jdiggs@igalia.com>
375
376         [GTK][jhbuild] OpenWebRTC build fails with GCC 6.0
377         https://bugs.webkit.org/show_bug.cgi?id=154839
378
379         Reviewed by Michael Catanzaro.
380
381         Add '-Wno-error' to jhbuildrc; remove it from the module sets for macos.
382
383         * gtk/jhbuild-webrtc.modules:
384         * gtk/jhbuild.modules:
385         * gtk/jhbuildrc:
386
387 2016-03-07  Aakash Jain  <aakash_jain@apple.com>
388
389         webkitpy should verify timestamp from CrashLogs while collecting all crash logs
390         https://bugs.webkit.org/show_bug.cgi?id=155000
391         <rdar://problem/24860219>
392
393         Reviewed by Alexey Proskuryakov.
394
395         * Scripts/webkitpy/common/system/crashlogs.py:
396         (CrashLogs._find_all_logs_darwin): Make sure that crash log timestamp is within expected 
397         time range, because file modification time is not always accurate.
398         (CrashLogs.get_timestamp_from_logs): Parse the timestamp from logs.
399         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
400         (CrashLogsTest.test_get_timestamp_from_logs_darwin): Testcase for above function.
401
402 2016-03-06  Alexey Proskuryakov  <ap@apple.com>
403
404         build-webkit prints an error on iOS simulator bots
405         https://bugs.webkit.org/show_bug.cgi?id=155078
406
407         Reviewed by Dan Bernstein.
408
409         This happens when build-layouttestrelay sets $xcodeSDK to undefined, to use host SDK.
410
411         * Scripts/webkitdirs.pm: (buildXCodeProject): There is no need to pass -sdk, because
412         XcodeOptions() already passes SDKROOT as appropriate.
413
414         * Scripts/build-layouttestrelay: Added a FIXME. Resetting $xcodeSDK doesn't reset
415         any other configuration variables that were derived from its initial value, like $portName.
416
417 2016-03-05  Tim Horton  <timothy_horton@apple.com>
418
419         Create a DOMHTMLVideoElement when wrapping <video> elements
420         https://bugs.webkit.org/show_bug.cgi?id=155084
421         <rdar://problem/24997193>
422
423         Reviewed by Dan Bernstein.
424
425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
426         * TestWebKitAPI/Tests/mac/DOMHTMLVideoElementWrapper.mm: Added.
427         (-[VideoWrapperFrameLoadDelegate webView:didFinishLoadForFrame:]):
428         (TestWebKitAPI::TEST):
429         Add an API test for this behavior.
430
431 2016-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
432
433         [GTK] Fix logging details after r197505 (Run the run-benchmark script on the performance bot.)
434         https://bugs.webkit.org/show_bug.cgi?id=154595
435
436         Unreviewed.
437
438         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
439         (start): Use logging.exception when a test fails in order to get the details about the error.
440
441 2016-03-04  Alexey Proskuryakov  <ap@apple.com>
442
443         Add iOS simulator debug bots
444         https://bugs.webkit.org/show_bug.cgi?id=155053
445
446         Reviewed by Lucas Forschler.
447
448         * BuildSlaveSupport/build.webkit.org-config/config.json:
449
450 2016-03-04  Brent Fulgham  <bfulgham@apple.com>
451
452         [WK2] Gather resource load statistics
453         https://bugs.webkit.org/show_bug.cgi?id=154278
454         <rdar://problem/24702892>
455
456         Reviewed by Andy Estes.
457
458         * MiniBrowser/mac/AppDelegate.m:
459         (defaultConfiguration): Retrieve state of the ResourceLoadStatisticsEnabled setting.
460         * MiniBrowser/mac/SettingsController.m:
461         (-[SettingsController _populateMenu]): Move setting from WK1-only to be
462         universally applicable.
463         * MiniBrowser/mac/WK2BrowserWindowController.m:
464         (-[WK2BrowserWindowController didChangeSettings]): Recognize when the
465         Resource Load Statistics flag has changed.
466
467 2016-03-04  Alex Christensen  <achristensen@webkit.org>
468
469         Remove vcxproj build system
470         https://bugs.webkit.org/show_bug.cgi?id=154388
471
472         Rubber-stamped by Brent Fulgham.
473
474         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree: Removed.
475         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Removed.
476         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Removed.
477         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Removed.
478         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props: Removed.
479         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Removed.
480         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props: Removed.
481         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Removed.
482         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Removed.
483         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props: Removed.
484         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props: Removed.
485         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Removed.
486         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props: Removed.
487         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Removed.
488         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Removed.
489         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Removed.
490         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props: Removed.
491         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Removed.
492         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Removed.
493         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: Removed.
494         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props: Removed.
495         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Removed.
496         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props: Removed.
497         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Removed.
498         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: Removed.
499         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props: Removed.
500         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props: Removed.
501         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Removed.
502         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props: Removed.
503         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPostBuild.cmd: Removed.
504         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd: Removed.
505         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Removed.
506         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props: Removed.
507         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Removed.
508         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: Removed.
509         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: Removed.
510         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: Removed.
511         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props: Removed.
512         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPostBuild.cmd: Removed.
513         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd: Removed.
514         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Removed.
515         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props: Removed.
516         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Removed.
517         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Removed.
518         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Removed.
519         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Removed.
520         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Removed.
521         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Removed.
522         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Removed.
523         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Removed.
524         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Removed.
525         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Removed.
526         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Removed.
527         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Removed.
528         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Removed.
529         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Removed.
530         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Removed.
531         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Removed.
532         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Removed.
533         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Removed.
534         * TestWebKitAPI/TestWebKitAPI.vcxproj: Removed.
535         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Removed.
536         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Removed.
537         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Removed.
538         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Removed.
539         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Removed.
540         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props: Removed.
541         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Removed.
542         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Removed.
543         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Removed.
544         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Removed.
545         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props: Removed.
546         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Removed.
547         * win/AssembleBuildLogs: Removed.
548         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Removed.
549         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Removed.
550         * win/AssembleBuildLogs/AssembleLogs.cmd: Removed.
551         * win/AssembleBuildLogs/README: Removed.
552
553 2016-03-04  Myles C. Maxfield  <mmaxfield@apple.com>
554
555         Whitespace causes font-variant: all-small-caps to synthesize
556         https://bugs.webkit.org/show_bug.cgi?id=155004
557         <rdar://problem/24630796>
558
559         Reviewed by Darin Adler.
560
561         * DumpRenderTree/mac/DumpRenderTree.mm:
562         (allowedFontFamilySet):
563         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
564         (WTR::allowedFontFamilySet):
565         * WebKitTestRunner/mac/TestControllerMac.mm:
566         (WTR::allowedFontFamilySet):
567
568 2016-03-04  Myles C. Maxfield  <mmaxfield@apple.com>
569
570         [iOS] Crash during font loading when injected bundle cancels load
571         https://bugs.webkit.org/show_bug.cgi?id=155001
572
573         Reviewed by Tim Horton.
574
575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
576         * TestWebKitAPI/Tests/WebKit2/Ahem.ttf: Added.
577         * TestWebKitAPI/Tests/WebKit2/webfont.html: Added.
578         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm: Added.
579         (-[Myles webView:didFinishNavigation:]):
580         (TEST):
581         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresourcePlugIn.mm: Added.
582         (-[CancelFontSubresourcePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
583         (-[CancelFontSubresourcePlugIn webProcessPlugInBrowserContextController:frame:willSendRequestForResource:request:redirectResponse:]):
584
585 2016-03-04  Konstantin Tokarev  <annulen@yandex.ru>
586
587         [check-webkit-style] Added checks for redundant virtual specifiers.
588         https://bugs.webkit.org/show_bug.cgi?id=155017
589
590         Reviewed by Darin Adler.
591
592         Added 3 new checks related to virtual, override, and final specifiers:
593
594         1. When "override" is present, "virtual" is redundant.
595         2. When "final" is present, "virtual" is redundant.
596         3. When "final" is present, "override" is redundant.
597
598         * Scripts/webkitpy/style/checkers/cpp.py:
599         (_FunctionState.begin):
600         (_FunctionState.is_virtual):
601         (_check_parameter_name_against_text):
602         (_error_redundant_specifier):
603         (check_function_definition):
604         (CppChecker):
605         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
606         (FunctionDetectionTest.perform_function_detection):
607         (FunctionDetectionTest.test_basic_function_detection):
608         (FunctionDetectionTest.test_function_declaration_detection):
609         (FunctionDetectionTest.test_pure_function_detection):
610         (FunctionDetectionTest.test_override_and_final_function_detection):
611         (FunctionDetectionTest.test_non_functions):
612         (FunctionDetectionTest.test_parameter_list):
613
614 2016-03-03  Darin Adler  <darin@apple.com>
615
616         Followup to:
617         Remove "virtual" from all lines that have both "virtual" and "override".
618         https://bugs.webkit.org/show_bug.cgi?id=155005
619
620         Reviewed by Geoffrey Garen.
621
622         * Scripts/do-webcore-rename: Added more regular expressions to make sure we always
623         use either override or final, not both, and to remove virtual from all lines that
624         have both virtual and final.
625
626 2016-03-03  Darin Adler  <darin@apple.com>
627
628         Remove "virtual" from all lines that have both "virtual" and "override".
629         https://bugs.webkit.org/show_bug.cgi?id=155005
630
631         Reviewed by Geoffrey Garen.
632
633         * Scripts/do-webcore-rename: Added a regular expression to this script to do the job.
634
635 2016-03-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
636
637         [GTK] Unreviewed fix after r197505 (Run the run-benchmark script on the performance bot.)
638         https://bugs.webkit.org/show_bug.cgi?id=154595
639
640         Unreviewed fix after r197505.
641
642         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
643         (RunBenchmarkTests.start):
644
645 2016-03-03  Daniel Bates  <dabates@apple.com>
646
647         Add unit tests for WTF::OptionSet
648         https://bugs.webkit.org/show_bug.cgi?id=154925
649         <rdar://problem/24964211>
650
651         Reviewed by Darin Adler.
652
653         Add tests to ensure that we do not regress the behavior of WTF::OptionSet.
654
655         * TestWebKitAPI/CMakeLists.txt: Add file TestWebKitAPI/Tests/WTF/OptionSet.cpp.
656         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
657         * TestWebKitAPI/Tests/WTF/OptionSet.cpp: Added.
658         (TestWebKitAPI::TEST):
659
660 2016-03-03  Commit Queue  <commit-queue@webkit.org>
661
662         Unreviewed, rolling out r197442.
663         https://bugs.webkit.org/show_bug.cgi?id=154967
664
665         Broke tests, and also uses a wrong approach (Requested by ap
666         on #webkit).
667
668         Reverted changeset:
669
670         "Disable FTL JIT testing on 32-bit JSC tester bots"
671         https://bugs.webkit.org/show_bug.cgi?id=154858
672         http://trac.webkit.org/changeset/197442
673
674 2016-03-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
675
676         [GTK] Run the run-benchmark script on the performance bot.
677         https://bugs.webkit.org/show_bug.cgi?id=154595
678
679         Reviewed by Carlos Garcia Campos.
680
681         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add new RunBenchmarkTests step on the perf bots (only for the GTK+ port at this moment).
682         (RunBenchmarkTests):
683         (RunBenchmarkTests.start):
684         (RunBenchmarkTests.getText):
685         (RunBenchmarkTests.getText2):
686         (BuildAndPerfTestFactory.__init__):
687         (DownloadAndPerfTestFactory.__init__):
688         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add new test for RunBenchmarkTests and update expected steps of GTK+ perf bot.
689         (RunBenchmarkTest):
690         (RunBenchmarkTest.assertResults):
691         (RunBenchmarkTest.test_success):
692         (RunBenchmarkTest.test_tests_failed):
693         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Log both the current iteration as also the total iterations for the current benchmark/plan.
694         (BenchmarkRunner._run_benchmark):
695         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Use python logging also for errors.
696         (GTKMiniBrowserDriver.close_browsers):
697         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Implement support for running all available benchmark plans.
698         (parse_args):
699         (start):
700         (main):
701
702 2016-03-03  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
703
704         [EFL] Remove u-szeged.hu SVN mirror in EFL perf bot
705         https://bugs.webkit.org/show_bug.cgi?id=154960
706
707         Reviewed by Csaba Osztrogonác.
708
709         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove szeged univ's svn mirror.
710         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
711
712 2016-03-03  Frederic Wang  <fwang@igalia.com>
713
714         [jhbuild] Remove LLVM dependency.
715         https://bugs.webkit.org/show_bug.cgi?id=153274
716
717         Reviewed by Carlos Garcia Campos.
718
719         * gtk/jhbuild.modules:
720
721 2016-03-02  Alejandro G. Castro  <alex@igalia.com>
722
723         Unreviewed build fix for media-stream after r197114.
724
725         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
726         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
727
728 2016-03-01  Csaba Osztrogonác  <ossy@webkit.org>
729
730         Disable FTL JIT testing on 32-bit JSC tester bots
731         https://bugs.webkit.org/show_bug.cgi?id=154858
732
733         Reviewed by Saam Barati.
734
735         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
736         (Run32bitJSCTests):
737
738 2016-03-01  Dean Johnson  <dean_johnson@apple.com>
739
740         Fix iOS EWS.
741         https://bugs.webkit.org/show_bug.cgi?id=154880
742
743         Reviewed by Alexey Proskuryakov.
744
745         * Scripts/copy-webkitlibraries-to-product-directory:
746
747 2016-02-29  Chris Dumez  <cdumez@apple.com>
748
749         Have parseHTMLInteger() / parseHTMLNonNegativeInteger() use WTF::Optional
750         https://bugs.webkit.org/show_bug.cgi?id=154845
751
752         Reviewed by Ryosuke Niwa.
753
754         Update API tests accordingly.
755
756         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
757         (TestWebKitAPI::testParseHTMLInteger):
758         (TestWebKitAPI::parseHTMLIntegerFails):
759         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
760         (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
761         (TestWebKitAPI::TEST): Deleted.
762
763 2016-02-29  Simon Fraser  <simon.fraser@apple.com>
764
765         Remove the experimental feature of antialiased font dilation
766         https://bugs.webkit.org/show_bug.cgi?id=154843
767
768         Reviewed by Zalan Bujtas.
769
770         Remove the "antialiased font dilation" code path, and related prefs.
771
772         * DumpRenderTree/mac/DumpRenderTree.mm:
773         (resetWebPreferencesToConsistentValues): Deleted.
774         * WebKitTestRunner/TestController.cpp:
775         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
776
777 2016-02-29  Brady Eidson  <beidson@apple.com>
778
779         Fix timing flakiness in test I added in http://trac.webkit.org/changeset/197372
780
781         Unreviewed.
782
783         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html:
784         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
785         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
786         (TEST): Sometimes a third message from the first html file was leaking through. The message is expected
787           so we should always wait for it and make sure we got it.
788
789 2016-02-29  Brady Eidson  <beidson@apple.com>
790
791         Modern IDB: WebKit 2 IPC layer easily confused about multiple web processes being connected.
792         https://bugs.webkit.org/show_bug.cgi?id=154837
793
794         Reviewed by Alex Christensen.
795
796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
797         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-1.html: Added.
798         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html: Added.
799         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Added.
800
801 2016-02-29  Joanmarie Diggs  <jdiggs@igalia.com>
802
803         [GTK][jhbuild] GLib build fails with GCC 6.0
804         https://bugs.webkit.org/show_bug.cgi?id=154825
805
806         Use the upstream work-around. https://bugzilla.gnome.org/show_bug.cgi?id=761550
807
808         Reviewed by Csaba Osztrogonác.
809
810         * gtk/jhbuild.modules: Apply upstream path.
811         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Added.
812
813 2016-02-29  Filip Pizlo  <fpizlo@apple.com>
814
815         We've been running Octane/regexp all wrong in run-jsc-benchmarks
816         https://bugs.webkit.org/show_bug.cgi?id=154827
817
818         Reviewed by Andreas Kling.
819
820         Octane v.2 and JetStream v.1.1 run this benchmark with warmup. This script was running
821         it without warmup. This patches fixes this by making this script run it with warmup.
822
823         This fix shows that my last patch, which added FTL support for regexp, was actually a 3%
824         speed-up on Octane/regexp, not a slow-down as the ChangeLog claimed.
825
826         It discovered this bug because for each Octane test that I want to debug, I usually make
827         a standalone .js file that contains the whole test along with a miniharness - usually
828         a plain loop - that runs it almost like it would for real but with whatever hacks I'm
829         using for debugging. When I wrote such a thing for regexp, I used a ~20 iteration warmup
830         to match the one second of warmup that this benchmark gets in Octane. To my surprise,
831         this quite faithful regexp runner did not see the regression that run-jsc-benchmarks
832         saw. That's when I found out that run-jsc-benchmarks was running it wrong.
833
834         The reason for the no-warmup slow-down is that the FTL is actually fairly expensive to
835         run on some of these very large functions in the regexp benchmark. I don't think we can
836         do anything about that, and I'd argue that the speed-up we see after the compilation is
837         done suggests that it was worth it.
838
839         * Scripts/run-jsc-benchmarks:
840
841 2016-02-29  Gavin Barraclough  <barraclough@apple.com>
842
843         RefCounter<T>::Event -> RefCounterEvent
844         https://bugs.webkit.org/show_bug.cgi?id=154767
845
846         Reviewed by Darin Adler.
847
848         RefCounter<T>::Event is kinda verbose to use, and there is no need for this
849         to be specific to a particular typeof RefCounter. Move the enum class up to
850         the top level & rename to RefCounterEvent.
851
852         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
853         (TestWebKitAPI::TEST):
854
855 2016-02-29  Csaba Osztrogonác  <ossy@webkit.org>
856
857         Remove more LLVM related cruft
858         https://bugs.webkit.org/show_bug.cgi?id=154821
859
860         Reviewed by Darin Adler.
861
862         * Scripts/build-jsc:
863         * Scripts/build-webkit:
864         * Scripts/copy-webkitlibraries-to-product-directory:
865         * Scripts/export-llvm-build: Removed.
866         * Scripts/run-jsc-stress-tests:
867
868 2016-02-28  Sam Weinig  <sam@webkit.org>
869
870         Reimplement WKPageGroup in terms of WKUserContentController
871         https://bugs.webkit.org/show_bug.cgi?id=154804
872
873         Reviewed by Dan Bernstein.
874
875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
876         * TestWebKitAPI/Tests/WebKit2/PageGroup.cpp: Added.
877
878 2016-02-28  Sam Weinig  <sam@webkit.org>
879
880         Bind _WKUserStyleSheets to WKUserContentWorlds to allow for grouping of user content by associating to a world
881         https://bugs.webkit.org/show_bug.cgi?id=154798
882
883         Reviewed by Dan Bernstein.
884
885         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
886         Add tests for removing _WKUserStyleSheets and WKUserScripts
887
888 2016-02-27  Alexey Proskuryakov  <ap@apple.com>
889
890         Silence leaks under TextCodecICU::registerCodecs
891         https://bugs.webkit.org/show_bug.cgi?id=154737
892
893         Reviewed by Darin Adler.
894
895         * Scripts/webkitpy/port/leakdetector.py:
896         (LeakDetector._callstacks_to_exclude_from_leaks):
897
898 2016-02-26  Michael Catanzaro  <mcatanzaro@igalia.com>
899
900         [GTK] Fix incorrect cast
901
902         Unreviewed.
903
904         * MiniBrowser/gtk/main.c:
905         (createBrowserWindow):
906
907 2016-02-26  Chris Dumez  <cdumez@apple.com>
908
909         Fix the behavior of reflecting IDL attributes of type unsigned long
910         https://bugs.webkit.org/show_bug.cgi?id=154771
911
912         Reviewed by Ryosuke Niwa.
913
914         Update API tests to cover the fixes to the parseHTMLNonNegativeInteger()
915         implementation:
916         - "-0" is parsed as 0.
917         - Range boundaries are now [0; 2147483647].
918
919         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
920         (TestWebKitAPI::TEST):
921
922 2016-02-26  Brady Eidson  <beidson@apple.com>
923
924         Modern IDB: New database versions are never committed to SQLite.
925         <rdar://problem/24860952> and https://bugs.webkit.org/show_bug.cgi?id=154741
926         
927         Modern IDB: If a database handle is not open, files are not actually deleted from disk
928         https://bugs.webkit.org/show_bug.cgi?id=154756
929
930         Reviewed by Alex Christensen.
931
932         This also happens to test the previously untested fix for http://trac.webkit.org/changeset/197190
933
934         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
935         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-1.html: Added.
936         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence-2.html: Added.
937         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm: Added.
938         (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]):
939         (-[IndexedDBMessageHandler userContentController:didReceiveScriptMessage:]):
940         (TEST):
941
942 2016-02-26  Commit Queue  <commit-queue@webkit.org>
943
944         Unreviewed, rolling out r197216.
945         https://bugs.webkit.org/show_bug.cgi?id=154766
946
947         Test simply needs updated result (Requested by litherum on
948         #webkit).
949
950         Reverted changeset:
951
952         "Unreviewed, rolling out r197158."
953         https://bugs.webkit.org/show_bug.cgi?id=154758
954         http://trac.webkit.org/changeset/197216
955
956 2016-02-26  Alexey Proskuryakov  <ap@apple.com>
957
958         [iOS Simulator] Reftests don't work
959         https://bugs.webkit.org/show_bug.cgi?id=154764
960
961         Reviewed by Daniel Bates.
962
963         * Scripts/webkitpy/port/image_diff.py: (IOSSimulatorImageDiffer._start):
964         Use simctl instead of sim.
965
966 2016-02-26  Chris Dumez  <cdumez@apple.com>
967
968         Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger
969         https://bugs.webkit.org/show_bug.cgi?id=154714
970
971         Reviewed by Darin Adler.
972
973         Add API test coverage for parseHTMLInteger / parseHTMLNonNegativeInteger as per:
974         - https://html.spec.whatwg.org/multipage/infrastructure.html#signed-integers
975         - https://html.spec.whatwg.org/multipage/infrastructure.html#non-negative-integers
976
977         * TestWebKitAPI/PlatformEfl.cmake:
978         * TestWebKitAPI/PlatformGTK.cmake:
979         * TestWebKitAPI/PlatformWin.cmake:
980         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
981         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
982         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
983         * TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp: Added.
984         (TestWebKitAPI::testParseHTMLInteger):
985         (TestWebKitAPI::parseHTMLIntegerFails):
986         (TestWebKitAPI::TEST):
987         (TestWebKitAPI::testParseHTMLNonNegativeInteger):
988         (TestWebKitAPI::parseHTMLNonNegativeIntegerFails):
989
990 2016-02-26  Commit Queue  <commit-queue@webkit.org>
991
992         Unreviewed, rolling out r197158.
993         https://bugs.webkit.org/show_bug.cgi?id=154758
994
995         This change did not fix the failing test (Requested by
996         ryanhaddad on #webkit).
997
998         Reverted changeset:
999
1000         "REGRESSION(r195795): [WK2] fast/text/crash-complex-text-
1001         surrogate.html is flakey"
1002         https://bugs.webkit.org/show_bug.cgi?id=154709
1003         http://trac.webkit.org/changeset/197158
1004
1005 2016-02-26  Anders Carlsson  <andersca@apple.com>
1006
1007         WKWebsiteDataStore/WKWebsiteDataRecord needs to provide size information about each type of data
1008         https://bugs.webkit.org/show_bug.cgi?id=154750
1009         rdar://problem/23861395
1010
1011         Reviewed by Tim Horton.
1012
1013         * MiniBrowser/mac/WK2BrowserWindowController.m:
1014         (-[WK2BrowserWindowController fetchWebsiteData:]):
1015         Use the new WKWebsiteDataStore SPI to compute data sizes.
1016
1017 2016-02-25  Gavin Barraclough  <barraclough@apple.com>
1018
1019         RefCounter value changed callback should be called on all changes (not just zero edge).
1020         https://bugs.webkit.org/show_bug.cgi?id=154699
1021
1022         Reviewed by Geoff Garen.
1023
1024         RefCounter currently only triggers a callback when the count goes from zero
1025         to non-zero and vice-versa. Change that, to be useful to more clients.
1026
1027         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1028         (TestWebKitAPI::TEST):
1029             - Updated for change in RefCounter callback siganture & behaviour.
1030
1031 2016-02-25  Sam Weinig  <sam@webkit.org>
1032
1033         Allow WKUserScripts to be run in isolated worlds
1034         https://bugs.webkit.org/show_bug.cgi?id=154701
1035
1036         Reviewed by Anders Carlsson.
1037
1038         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1039         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorld.mm: Added.
1040         (-[SimpleDelegate webView:didFinishNavigation:]):
1041         (-[UserContentWorldRemoteObject didObserveNormalWorld]):
1042         (-[UserContentWorldRemoteObject didObserveWorldWithName:]):
1043         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldPlugIn.mm: Added.
1044         (-[_WKUserContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1045         (-[_WKUserContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
1046         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentWorldProtocol.h: Added.
1047
1048 2016-02-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1049
1050         W3C test importer should have an option to clean the destination directory
1051         https://bugs.webkit.org/show_bug.cgi?id=152685
1052
1053         Reviewed by Darin Adler.
1054
1055         Adding --clean-dest-dir option to W3C test importer.
1056         When this option is set, all files in the destination directory will be deleted
1057         except for WebKit specific files (test expectations, .gitignore...) before new tests import.
1058         Dangling test expectations are removed after tests import.'
1059
1060         Adding unit test and minor refactoring for the other tests.
1061
1062         * Scripts/webkitpy/w3c/test_importer.py:
1063         (parse_args): Add '--clean-dest-dir' option.
1064         (TestImporter.do_import):
1065         (TestImporter._is_baseline): helper routine to capture -expected.txt files.
1066         (TestImporter):
1067         (TestImporter._should_not_keep_when_importing): helper routine to filter files that should not be cleaned before importing.
1068         (TestImporter.clean_destination_directory):
1069         (TestImporter.remove_dangling_expectations):
1070         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1071         (TestImporterTest._parse_options):
1072         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
1073         (TestImporterTest.test_import_dir_with_no_tests):
1074         (TestImporterTest.test_import_dir_with_empty_init_py):
1075         (test_clean_directory_option):
1076
1077 2016-02-25  Myles C. Maxfield  <mmaxfield@apple.com>
1078
1079         REGRESSION(r195795): [WK2] fast/text/crash-complex-text-surrogate.html is flakey
1080         https://bugs.webkit.org/show_bug.cgi?id=154709
1081         <rdar://problem/24483596>
1082
1083         Reviewed by Dan Bernstein.
1084
1085         Force auto-activation rules to a consistent state.
1086
1087         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1088         (WTR::InjectedBundle::platformInitialize):
1089
1090 2016-02-25  Jiewen Tan  <jiewen_tan@apple.com>
1091
1092         Unreivewed build fix for r197150.
1093
1094         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
1095
1096 2016-02-25  Jiewen Tan  <jiewen_tan@apple.com>
1097
1098         Restrict information passed with navigation action which is triggered by untrusted event
1099         https://bugs.webkit.org/show_bug.cgi?id=154571
1100         <rdar://problem/15967937>
1101
1102         Reviewed by Andy Estes.
1103
1104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1105         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm: Added.
1106         (-[WKNavigationActionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1107         (TestWebKitAPI::TEST):
1108         (-[NavigationActionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1109         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.html: Added.
1110
1111 2016-02-25  Gavin Barraclough  <barraclough@apple.com>
1112
1113         Should template RefCounter instead of RefCounter::Token
1114         https://bugs.webkit.org/show_bug.cgi?id=154691
1115
1116         Reviewed by Anders Carlsson.
1117
1118         Mechanical update per RefCounter interface change.
1119
1120         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1121         (TestWebKitAPI::TEST):
1122
1123 2016-02-25  Skachkov Aleksandr  <gskachkov@gmail.com>
1124
1125         Unreviewed: Add Aleksandr Skachkov as a commiter
1126
1127         * Scripts/webkitpy/common/config/contributors.json:
1128
1129 2016-02-25  Sam Weinig  <sam@webkit.org>
1130
1131         HashMap::ensure() should return an AddResult like all the other add-like functions
1132         https://bugs.webkit.org/show_bug.cgi?id=154680
1133
1134         Reviewed by Anders Carlsson.
1135
1136         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1137         (TestWebKitAPI::TEST):
1138         Update tests to use/test the new AddResult result.
1139
1140 2016-02-25  Alexey Proskuryakov  <ap@apple.com>
1141
1142         Enable MallocScribble when detecting leaks
1143         https://bugs.webkit.org/show_bug.cgi?id=154679
1144
1145         Reviewed by Geoffrey Garen.
1146
1147         * Scripts/webkitpy/port/ios.py:
1148         (IOSSimulatorPort.setup_environ_for_server):
1149         * Scripts/webkitpy/port/mac.py:
1150         (MacPort.setup_environ_for_server):
1151         * Scripts/webkitpy/port/mac_unittest.py:
1152         (MacTest.test_setup_environ_for_server):
1153
1154 2016-02-25  Eric Carlson  <eric.carlson@apple.com>
1155
1156         Unreviewed, fix iOS builds after r197114.
1157
1158         * WebKitTestRunner/TestController.cpp:
1159         (WTR::createCanonicalUUIDString):
1160         (WTR::TestController::saltForOrigin):
1161
1162 2016-02-25  Eric Carlson  <eric.carlson@apple.com>
1163
1164         [MediaStream] MediaDeviceInfo deviceId and groupId must be unique to the page's origin
1165         https://bugs.webkit.org/show_bug.cgi?id=153163
1166         <rdar://problem/24334526>
1167
1168         Reviewed by Tim Horton.
1169
1170         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1171         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Take top level document origin.
1172         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1173
1174         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1175         (WTR::TestRunner::setUserMediaPermissionForOrigin): Ditto.
1176         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1177
1178         * WebKitTestRunner/TestController.cpp:
1179         (WTR::decidePolicyForUserMediaPermissionRequest): Pass through top level document origin.
1180         (WTR::checkUserMediaPermissionForOrigin): Ditto.
1181         (WTR::TestController::resetStateToConsistentValues): m_userMediaOriginPermissions -> m_cahcedUserMediaPermissions.
1182         (WTR::originUserVisibleName): Return a String.
1183         (WTR::userMediaOriginHash): Create a hash of the origin plus top level document origin.
1184         (WTR::TestController::saltForOrigin): Return salt for an origin.
1185         (WTR::TestController::setUserMediaPermissionForOrigin): Return permission for an origin.
1186         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1187         (WTR::TestController::handleUserMediaPermissionRequest):
1188         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1189         (WTR::OriginSettings::OriginSettings): New, class to cache settings for an origin.
1190         (WTR::OriginSettings::persistentPermission): Persistent permissions for origin.
1191         (WTR::OriginSettings::setPersistentPermission): Set permissions for origin.
1192         (WTR::OriginSettings::persistentSalt): Return the persistent salt for the origin, if any.
1193         (WTR::OriginSettings::setPersistentSalt): Set the persistent salt for the origin
1194         (WTR::OriginSettings::ephemeralSalts): Return hashmap used to store per-frame salts.
1195         * WebKitTestRunner/TestController.h:
1196
1197         * WebKitTestRunner/TestInvocation.cpp:
1198         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1199
1200 2016-02-24  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
1201
1202         [web-animations] Add AnimationTimeline, DocumentTimeline and add extensions to Document interface
1203         https://bugs.webkit.org/show_bug.cgi?id=151688
1204
1205         Reviewed by Dean Jackson.
1206
1207         Enables the WEB_ANIMATIONS compiler switch by default.
1208
1209         * Scripts/webkitperl/FeatureList.pm:
1210
1211 2016-02-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1212
1213         W3C importer should generate all web-platform-tests submodules descriptions
1214         https://bugs.webkit.org/show_bug.cgi?id=154587
1215
1216         Reviewed by Darin Adler.
1217
1218         Updated submodules description format (removing submodule name as it is the last string of the path really).
1219         Added git subroutines.
1220
1221         * Scripts/webkitpy/common/checkout/scm/git.py:
1222         (Git.origin_url):
1223         (Git):
1224         (Git.init_submodules):
1225         (Git.submodules_status):
1226         (Git.deinit_submodules):
1227         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1228         (WebPlatformTestServer._install_modules): Updated to submodule name removal.
1229         * Scripts/webkitpy/w3c/test_downloader.py:
1230         (TestDownloader._git_submodules_description): Updated to cope with recursive submodules (use of submodule init/deinit).
1231         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1232         (TestImporterTest.test_submodules_generation): Reactivated partially this test.
1233
1234 2016-02-23  Dan Bernstein  <mitz@apple.com>
1235
1236         [Xcode] Linker errors display mangled names, but no longer should
1237         https://bugs.webkit.org/show_bug.cgi?id=154632
1238
1239         Reviewed by Sam Weinig.
1240
1241         * ContentExtensionTester/Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
1242         * DumpRenderTree/mac/Configurations/Base.xcconfig: Ditto.
1243         * LayoutTestRelay/Configurations/Base.xcconfig: Ditto.
1244         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
1245         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1246         * WebEditingTester/Configurations/Base.xcconfig: Ditto.
1247         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1248
1249 2016-02-23  Anders Carlsson  <andersca@apple.com>
1250
1251         WKWebView should implement NSCoding
1252         https://bugs.webkit.org/show_bug.cgi?id=137160
1253
1254         Reviewed by Dan Bernstein.
1255
1256         Add tests.
1257
1258         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
1259         (TEST):
1260
1261 2016-02-23  Anders Carlsson  <andersca@apple.com>
1262
1263         WKProcessPool should conform to NSCoding
1264         https://bugs.webkit.org/show_bug.cgi?id=154608
1265
1266         Reviewed by Sam Weinig.
1267
1268         Add tests.
1269
1270         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
1271         (TEST):
1272
1273 2016-02-23  Anders Carlsson  <andersca@apple.com>
1274
1275         WKWebsiteDataStore should conform to NSCoding
1276         https://bugs.webkit.org/show_bug.cgi?id=154605
1277
1278         Reviewed by Dan Bernstein.
1279
1280         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
1281         (TEST):
1282
1283 2016-02-23  Anders Carlsson  <andersca@apple.com>
1284
1285         WKWebViewConfiguration should conform to NSCoding
1286         https://bugs.webkit.org/show_bug.cgi?id=154602
1287
1288         Reviewed by Beth Dakin.
1289
1290         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
1291         (TEST):
1292
1293 2016-02-23  Anders Carlsson  <andersca@apple.com>
1294
1295         WKPreferences should conform to NSCoding
1296         https://bugs.webkit.org/show_bug.cgi?id=154597
1297
1298         Reviewed by Sam Weinig.
1299
1300         Test encoding and decoding WKPreferences.
1301
1302         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
1303         (encodeAndDecode):
1304         (TEST):
1305
1306 2016-02-23  Anders Carlsson  <andersca@apple.com>
1307
1308         Fix build.
1309
1310         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
1311         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]):
1312
1313 2016-02-23  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1314
1315         [GTK] Allow to run the WebKitGTK+ MiniBrowser with the run-benchmark script.
1316         https://bugs.webkit.org/show_bug.cgi?id=153993
1317
1318         Reviewed by Carlos Garcia Campos.
1319
1320         * MiniBrowser/gtk/main.c:
1321         (createBrowserWindow): Support --geometry argument for MiniBrowser.
1322         We use this on the gtk_minibrowser_driver script to start the MiniBrowser maximized.
1323         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Fix loading of subclasses:
1324         The base class has to be loaded first, otherwise any subclase referencing it will give import error.
1325         In OSX the ordering of os.listdir() causes the base class (browser_driver.py) to be first on the list, but not on Linux.
1326         By specifiying the name of the base class file, we ensure it is always loaded first on any system despite the ordering of listdir.
1327         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
1328         (BrowserDriverFactory.create):
1329         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py: Added.
1330         (GTKBrowserDriver):
1331         (GTKBrowserDriver.prepare_env):
1332         (GTKBrowserDriver.restore_env):
1333         (GTKBrowserDriver.close_browsers):
1334         (GTKBrowserDriver._launch_process):
1335         (GTKBrowserDriver._terminate_processes):
1336         (GTKBrowserDriver._screen_size):
1337         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Added.
1338         (GTKMiniBrowserDriver):
1339         (GTKMiniBrowserDriver.prepare_env):
1340         (GTKMiniBrowserDriver.launch_url):
1341         (GTKMiniBrowserDriver.close_browsers):
1342         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Fix loading of subclasses. See description above.
1343         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1344         (SimpleHTTPServerDriver):
1345         (SimpleHTTPServerDriver.kill_server): Check if the server is still running before trying to terminate it.
1346         Usually the server ends gracefully (no need to terminate it), so this was causing ugly errors on the log.
1347         * Scripts/webkitpy/benchmark_runner/utils.py: Fix loading of subclasses. See description above.
1348         (load_subclasses):
1349
1350 2016-02-23  Alejandro G. Castro  <alex@igalia.com>
1351
1352         [GTK] Missing configuration patch for openh264 compilation
1353         https://bugs.webkit.org/show_bug.cgi?id=154455
1354
1355         This patch is required for the openh264 compilation with the
1356         jhbuild-webrtc.modules. The code was implemented by Alessandro
1357         Decina.
1358
1359         Reviewed by Philippe Normand.
1360
1361         * gtk/patches/openh264-configure.patch: Added.
1362
1363 2016-02-20  Olivier Blin  <olivier.blin@softathome.com>
1364
1365         [cmake] Use ICU include dirs in WebKit2 and WebKitTestRunner
1366         https://bugs.webkit.org/show_bug.cgi?id=154479
1367
1368         Reviewed by Michael Catanzaro.
1369
1370         * WebKitTestRunner/CMakeLists.txt:
1371
1372 2016-02-19  Konstantin Tokarev  <annulen@yandex.ru>
1373
1374         [GTK] Fixed link error when G_DEFINE_AUTOPTR_CLEANUP_FUNC is not defined.
1375         https://bugs.webkit.org/show_bug.cgi?id=154467
1376
1377         Reviewed by Michael Catanzaro.
1378
1379         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp:
1380         (beforeAll):
1381         (afterAll):
1382
1383 2016-02-19  Brady Eidson  <beidson@apple.com>
1384
1385         Add "databaseProcessDidCrash" to the WKContextClient; Adopt it in WKTR.
1386         https://bugs.webkit.org/show_bug.cgi?id=154428
1387
1388         Reviewed by Jer Noble.
1389
1390         * WebKitTestRunner/TestController.cpp:
1391         (WTR::TestController::generatePageConfiguration):
1392         (WTR::TestController::databaseProcessName):
1393         (WTR::TestController::databaseProcessDidCrash):
1394         * WebKitTestRunner/TestController.h:
1395
1396 2016-02-18  Philippe Normand  <pnormand@igalia.com>
1397
1398         [GStreamer] Bump internal jhbuild versions to 1.6.3
1399         https://bugs.webkit.org/show_bug.cgi?id=149594
1400
1401         Reviewed by Michael Catanzaro.
1402
1403         * gtk/jhbuild.modules: Bump to GStreamer 1.6.3.
1404         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
1405         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
1406         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
1407
1408 2016-02-18  Brent Fulgham  <bfulgham@apple.com>
1409
1410         Extend HashCountedSet with a method to efficiently set the count of an entry
1411         https://bugs.webkit.org/show_bug.cgi?id=154352
1412
1413         Reviewed by Geoffrey Garen.
1414
1415         * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
1416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1417         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
1418
1419 2016-02-18  Commit Queue  <commit-queue@webkit.org>
1420
1421         Unreviewed, rolling out r196791.
1422         https://bugs.webkit.org/show_bug.cgi?id=154438
1423
1424         broke windows build (Requested by alexchristensen on #webkit).
1425
1426         Reverted changeset:
1427
1428         "Extend HashCountedSet with a method to efficiently set the
1429         count of an entry"
1430         https://bugs.webkit.org/show_bug.cgi?id=154352
1431         http://trac.webkit.org/changeset/196791
1432
1433 2016-02-18  Brent Fulgham  <bfulgham@apple.com>
1434
1435         Extend HashCountedSet with a method to efficiently set the count of an entry
1436         https://bugs.webkit.org/show_bug.cgi?id=154352
1437
1438         Reviewed by Geoffrey Garen.
1439
1440         * TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
1441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1442         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
1443
1444 2016-02-18  Anders Carlsson  <andersca@apple.com>
1445
1446         Get rid of the --target-web-process and --use-web-process-xpc-service options.
1447
1448         Rubber-stamped by Dan Bernstein.
1449
1450         We now always use XPC, and --target-web-process is no longer supported.
1451
1452         * Scripts/webkitdirs.pm:
1453         (execMacWebKitAppForDebugging):
1454         (shouldTargetWebProcess): Deleted.
1455         (determineShouldTargetWebProcess): Deleted.
1456         (shouldUseXPCServiceForWebProcess): Deleted.
1457         (determineShouldUseXPCServiceForWebProcess): Deleted.
1458         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Deleted.
1459         (argumentsForRunAndDebugMacWebKitApp): Deleted.
1460
1461 2016-02-18  Ryan Haddad  <ryanhaddad@apple.com>
1462
1463         Skip API test WTF_ParkingLot.UnparkOneFiftyThenFiftyAll on ios-simulator
1464         https://bugs.webkit.org/show_bug.cgi?id=153997
1465
1466         Reviewed by Filip Pizlo.
1467
1468         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1469
1470 2016-02-18  Jer Noble  <jer.noble@apple.com>
1471
1472         run-webkit-httpd should use webkitpy to run httpd.
1473         https://bugs.webkit.org/show_bug.cgi?id=154271
1474
1475         Reviewed by Alexey Proskuryakov.
1476
1477         Update run-webkit-httpd to use webkitpy.port to launch httpd. Pass on http_port and http_all_interface
1478         options to match the current run-webkit-httpd (optional) behavior.
1479
1480         * Scripts/run-webkit-httpd:
1481         (parse_args):
1482         (main):
1483         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1484         (LayoutTestApacheHttpd.__init__):
1485         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1486         (Lighttpd._prepare_config):
1487         * Scripts/webkitpy/port/base.py:
1488         (Port.to.start_http_server):
1489
1490 2016-02-18  Filip Pizlo  <fpizlo@apple.com>
1491
1492         Remove remaining references to LLVM, and make sure comments refer to the backend as "B3" not "LLVM"
1493         https://bugs.webkit.org/show_bug.cgi?id=154383
1494
1495         Reviewed by Saam Barati.
1496
1497         * Scripts/run-jsc-stress-tests:
1498
1499 2016-02-17  Filip Pizlo  <fpizlo@apple.com>
1500
1501         Remove LLVM dependencies from WebKit
1502         https://bugs.webkit.org/show_bug.cgi?id=154323
1503
1504         Reviewed by Antti Koivisto and Benjamin Poulain.
1505
1506         * Scripts/copy-webkitlibraries-to-product-directory:
1507         (isContentOfFileEqualToString):
1508         (fileContains): Deleted.
1509         (buildLLVM): Deleted.
1510         (symlinkLLVMLibrariesIfNeeded): Deleted.
1511
1512 2016-02-16  Sam Weinig  <sam@webkit.org>
1513
1514         Add an ensure function on HashMap that takes a key and a function to make the lazy value initialization idiom easier
1515         https://bugs.webkit.org/show_bug.cgi?id=134857
1516
1517         Reviewed by Geoffrey Garen.
1518
1519         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1520         Add tests for HashMap::ensure.
1521
1522 2016-02-17  Nan Wang  <n_wang@apple.com>
1523
1524         AX: Implement sentence related text marker functions using TextIterator
1525         https://bugs.webkit.org/show_bug.cgi?id=154312
1526
1527         Reviewed by Chris Fleizach.
1528
1529         * DumpRenderTree/AccessibilityUIElement.cpp:
1530         (nextParagraphEndTextMarkerForTextMarkerCallback):
1531         (sentenceTextMarkerRangeForTextMarkerCallback):
1532         (previousSentenceStartTextMarkerForTextMarkerCallback):
1533         (nextSentenceEndTextMarkerForTextMarkerCallback):
1534         (setSelectedVisibleTextRangeCallback):
1535         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1536         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
1537         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
1538         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
1539         (AccessibilityUIElement::getJSClass):
1540         * DumpRenderTree/AccessibilityUIElement.h:
1541         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1542         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1543         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
1544         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
1545         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
1546         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1547         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1548         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
1549         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
1550         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
1551         (AccessibilityUIElement::supportedActions):
1552         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1553         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1554         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1555         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1556         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
1557         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
1558         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
1559         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1560         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1561         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1562         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1563         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
1564         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
1565         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
1566         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1567         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1568         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1569         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
1570         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
1571         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
1572         (WTR::_convertMathMultiscriptPairsToString):
1573
1574 2016-02-15  Brent Fulgham  <bfulgham@apple.com>
1575
1576         [Mac] Gather some rudimentary statistics during resource load 
1577         https://bugs.webkit.org/show_bug.cgi?id=153575
1578         <rdar://problem/24075254>
1579
1580         Reviewed by Brady Eidson.
1581
1582         * MiniBrowser/mac/SettingsController.h:
1583         * MiniBrowser/mac/SettingsController.m:
1584         (-[SettingsController _populateMenu]): Add menu item for new debug flag.
1585         (-[SettingsController toggleResourceLoadStatisticsEnabled:]): Added.
1586         (-[SettingsController resourceLoadStatisticsEnabled]): Added.
1587         * MiniBrowser/mac/WK1BrowserWindowController.m:
1588         (-[WK1BrowserWindowController didChangeSettings]): React to changes in
1589         users's desire to track resource load statistics.
1590
1591 2016-02-15  Csaba Osztrogonác  <ossy@webkit.org>
1592
1593         [EFL] Update Tools/efl/install-dependencies
1594         https://bugs.webkit.org/show_bug.cgi?id=154239
1595
1596         Reviewed by Michael Catanzaro.
1597
1598         * efl/install-dependencies:
1599
1600 2016-02-15  Alex Christensen  <achristensen@webkit.org>
1601
1602         Fix internal Windows build of projects built after WebKit
1603         https://bugs.webkit.org/show_bug.cgi?id=154249
1604         rdar://problem/24644805
1605
1606         Reviewed by Chris Dumez.
1607
1608         * DumpRenderTree/PlatformWin.cmake:
1609         * MiniBrowser/win/CMakeLists.txt:
1610         Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
1611         more like projects built internally after WebKit.  They should only need to use what
1612         is in ForwardingHeaders/WebKit.
1613
1614 2016-02-12  Nan Wang  <n_wang@apple.com>
1615
1616         AX: Implement paragraph related text marker functions using TextIterator
1617         https://bugs.webkit.org/show_bug.cgi?id=154098
1618         <rdar://problem/24269675>
1619
1620         Reviewed by Chris Fleizach.
1621
1622         * DumpRenderTree/AccessibilityUIElement.cpp:
1623         (nextWordEndTextMarkerForTextMarkerCallback):
1624         (paragraphTextMarkerRangeForTextMarkerCallback):
1625         (previousParagraphStartTextMarkerForTextMarkerCallback):
1626         (nextParagraphEndTextMarkerForTextMarkerCallback):
1627         (setSelectedVisibleTextRangeCallback):
1628         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1629         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1630         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1631         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1632         (AccessibilityUIElement::getJSClass):
1633         * DumpRenderTree/AccessibilityUIElement.h:
1634         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1635         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1636         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1637         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1638         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1639         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1640         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1641         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1642         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1643         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1644         (AccessibilityUIElement::supportedActions):
1645         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1646         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1647         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1648         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1649         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1650         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1651         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1652         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1653         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1654         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1655         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1656         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1657         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1658         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1659         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1660         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1661         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1662         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
1663         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
1664         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
1665         (WTR::_convertMathMultiscriptPairsToString):
1666
1667 2016-02-12  Jason Marcell  <jmarcell@apple.com>
1668
1669         Open source bot watcher's dashboard fails assertion in BuildbotQueue.prototype.compareIterationsByRevisions
1670         https://bugs.webkit.org/show_bug.cgi?id=154180
1671
1672         Reviewed by Alexey Proskuryakov.
1673
1674         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Remove reference to Internal
1675         repository.
1676
1677 2016-02-12  Jer Noble  <jer.noble@apple.com>
1678
1679         [Mac] Adopt MediaResourceLoader (instead of CachedResourceLoader) in WebCoreNSURLSession.
1680         https://bugs.webkit.org/show_bug.cgi?id=154136
1681
1682         Reviewed by Alex Christensen.
1683
1684         Use a MediaResourceLoader instead of a CachedResourceLoader for WebCoreNSURLSession.
1685
1686         Drive-by fix: generate USE and ENABLE macros for TestWebKitAPI by adding FEATURE_DEFINES
1687         to GCC_PREPROCESSOR_DEFINES.
1688
1689         * TestWebKitAPI/Configurations/Base.xcconfig:
1690         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1691         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
1692         (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
1693         (TestWebKitAPI::TEST_F):
1694
1695 2016-02-11  Dana Burkart  <dburkart@apple.com>
1696
1697         Large logs can bring down the webkit master
1698         https://bugs.webkit.org/show_bug.cgi?id=122112
1699
1700         Reviewed by Lucas Forschler.
1701
1702         Implement the suggested fix of throwing away stdout / stderr.
1703
1704         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1705         (RunWebKit1LeakTests):
1706
1707 2016-02-10  Jason Marcell  <jmarcell@apple.com>
1708
1709         Remove calls to parseInt in order to work with non-integer revisions
1710         https://bugs.webkit.org/show_bug.cgi?id=153820
1711
1712         Reviewed by Daniel Bates.
1713
1714         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1715         (BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer
1716         revisions.
1717         (BuildbotIteration.prototype._parseData): Ditto.
1718         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1719         (BuildbotQueue.prototype.update): Ditto.
1720         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:
1721         (MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code.
1722         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
1723         (MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto.
1724         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
1725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto.
1726
1727 2016-02-10  Jason Marcell  <jmarcell@apple.com>
1728
1729         Teach dashboard code to compare non-integer revisions
1730         https://bugs.webkit.org/show_bug.cgi?id=152345
1731
1732         Reviewed by Daniel Bates.
1733
1734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1735         (BuildbotQueue.prototype.compareIterationsByRevisions): Compare non-integer revisions.
1736         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1737         (BuildbotQueueView.prototype._appendPendingRevisionCount): Use Trac.indexOfRevision in order to compare non-integer
1738         revisions. Also uses new Trac.commitsOnBranchLaterThanRevision method.
1739         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Ditto.
1740         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Use Trac.indexOfRevision in order to compare non-integer
1741         revisions. Also uses new Trac.nextRevision method to calculate a revision range.
1742         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1743         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1744         (Trac.prototype._commitsOnBranch): Renamed this to indicate that it should be a private method used by the latter two new
1745         methods.
1746         (Trac.prototype.commitsOnBranchLaterThanRevision): Finds revisions on a branch later than the specified revision.
1747         (Trac.prototype.commitsOnBranchInRevisionRange): Finds revisions on a branch within a specified range.
1748         (Trac.prototype.nextRevision): Finds the next revision after a given revision on a specific branch.
1749         (Trac.prototype.indexOfRevision): Finds the index of a given revision within the recordedCommits array.
1750         (Trac.prototype.commitsOnBranch): Deleted. Renamed to _commitsOnBranch.
1751         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests.
1752
1753 2016-02-09  Nan Wang  <n_wang@apple.com>
1754
1755         AX: Implement word related text marker functions using TextIterator
1756         https://bugs.webkit.org/show_bug.cgi?id=153939
1757         <rdar://problem/24269605>
1758
1759         Reviewed by Chris Fleizach.
1760
1761         * DumpRenderTree/AccessibilityUIElement.cpp:
1762         (endTextMarkerCallback):
1763         (leftWordTextMarkerRangeForTextMarkerCallback):
1764         (rightWordTextMarkerRangeForTextMarkerCallback):
1765         (previousWordStartTextMarkerForTextMarkerCallback):
1766         (nextWordEndTextMarkerForTextMarkerCallback):
1767         (setSelectedVisibleTextRangeCallback):
1768         (AccessibilityUIElement::setSelectedVisibleTextRange):
1769         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1770         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1771         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1772         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1773         (AccessibilityUIElement::getJSClass):
1774         * DumpRenderTree/AccessibilityUIElement.h:
1775         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1776         (AccessibilityUIElement::setSelectedVisibleTextRange):
1777         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1778         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1779         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1780         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1781         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1782         (AccessibilityUIElement::setSelectedVisibleTextRange):
1783         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1784         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1785         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1786         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1787         (AccessibilityUIElement::supportedActions):
1788         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1789         (WTR::AccessibilityUIElement::setBoolAttributeValue):
1790         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1791         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1792         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1793         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1794         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1795         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1796         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1797         (WTR::AccessibilityUIElement::endTextMarker):
1798         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1799         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1800         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1801         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1802         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1803         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1804         (WTR::AccessibilityUIElement::endTextMarker):
1805         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
1806         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
1807         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
1808         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
1809         (WTR::_convertMathMultiscriptPairsToString):
1810
1811 2016-02-09  Csaba Osztrogonác  <ossy@webkit.org>
1812
1813         [EFL] Remove eail related cruft after r195725
1814         https://bugs.webkit.org/show_bug.cgi?id=154030
1815
1816         Reviewed by Alex Christensen.
1817
1818         * efl/jhbuildrc:
1819
1820 2016-02-09  Csaba Osztrogonác  <ossy@webkit.org>
1821
1822         [EFL] Remove LLVM related cruft after r196077
1823         https://bugs.webkit.org/show_bug.cgi?id=154031
1824
1825         Reviewed by Alex Christensen.
1826
1827         * efl/jhbuild.modules:
1828         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
1829         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
1830         * efl/patches/llvm-version-arm64.patch: Removed.
1831
1832 2016-02-05  Aakash Jain  <aakash_jain@apple.com>
1833
1834         tests fail if display sleeps while run-webkit-tests is running
1835         https://bugs.webkit.org/show_bug.cgi?id=153919
1836
1837         Reviewed by Alexey Proskuryakov.
1838
1839         * DumpRenderTree/mac/LayoutTestHelper.m:
1840         (addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off.
1841         (releaseDisplaySleepAssertion): Release the DisplaySleep Assertion.
1842         (simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt.
1843
1844 2016-02-05  Alex Christensen  <achristensen@webkit.org>
1845
1846         Fix iOS API tests after r196082
1847         https://bugs.webkit.org/show_bug.cgi?id=153900
1848
1849         Reviewed by Jer Noble.
1850
1851         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1852         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
1853         [WebView initialize] doesn't call JSC::initializeThreading on iOS.
1854
1855 2016-02-04  Jason Marcell  <jmarcell@apple.com>
1856
1857         The status message for passing combined builder queues should say "all builds succeeded" when expanded.
1858         https://bugs.webkit.org/show_bug.cgi?id=153882
1859
1860         Reviewed by Alexey Proskuryakov.
1861
1862         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1863         (BuildbotCombinedQueueView.prototype.update): Set status to "all builds succeeded" for combined builder queues
1864         when expanded.
1865
1866 2016-02-03  Filip Pizlo  <fpizlo@apple.com>
1867
1868         run-jsc-stress-tests should be better at telling you details about test failures
1869         https://bugs.webkit.org/show_bug.cgi?id=153845
1870
1871         Reviewed by Geoffrey Garen.
1872
1873         Here's an example of the contents of results/resultsByFamily, one of the new files that this
1874         generates, for some local testing I'm doing.  Notice how it groups families of tests together.
1875
1876         You won't see this unless you cat results/resultsByFamily.
1877
1878         regress.yaml/Regress/radar-24289839.js:
1879             regress.yaml/Regress/radar-24289839.js.default: PASS
1880             regress.yaml/Regress/radar-24289839.js.ftl: PASS
1881             regress.yaml/Regress/radar-24289839.js.ftl-no-cjit: FAIL
1882             regress.yaml/Regress/radar-24289839.js.ftl-eager-no-cjit: FAIL
1883         
1884         regress.yaml/Regress/radar-24290639.js:
1885             regress.yaml/Regress/radar-24290639.js.default: PASS
1886             regress.yaml/Regress/radar-24290639.js.ftl: PASS
1887             regress.yaml/Regress/radar-24290639.js.ftl-no-cjit: PASS
1888             regress.yaml/Regress/radar-24290639.js.ftl-eager-no-cjit: FAIL
1889         
1890         regress.yaml/Regress/radar-24290670.js: FAILED
1891         
1892         * Scripts/run-jsc-stress-tests:
1893
1894 2016-02-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1895
1896         [WTR] Crash in EventSendingController::contextClick() when context menu event is not handled
1897         https://bugs.webkit.org/show_bug.cgi?id=153835
1898
1899         Reviewed by Martin Robinson.
1900
1901         WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when
1902         the context menu event is not handled, but we are using the
1903         returned value without null checking it.
1904
1905         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1906         (WTR::EventSendingController::contextClick):
1907
1908 2016-02-03  Jason Marcell  <jmarcell@apple.com>
1909
1910         Format revisions for display according to repository type
1911         https://bugs.webkit.org/show_bug.cgi?id=153818
1912
1913         Reviewed by Alexey Proskuryakov.
1914
1915         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1916         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according
1917         to repository type.
1918         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1919         (BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type.
1920         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new
1921         _formatRevisionForDisplay function.
1922
1923 2016-02-03  Aakash Jain  <aakash_jain@apple.com>
1924
1925         Logs/CoreSimulator filling up OS disk on WebKit testers
1926         https://bugs.webkit.org/show_bug.cgi?id=153853
1927         <rdar://problem/24496003>
1928
1929         Reviewed by Alexey Proskuryakov.
1930
1931         * Scripts/webkitpy/port/ios.py:
1932         (IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.
1933
1934 2016-02-03  Brian Burg  <bburg@apple.com>
1935
1936         git-add-reviewer should work when run from a subdirectory within the repository
1937         https://bugs.webkit.org/show_bug.cgi?id=153842
1938
1939         Reviewed by David Kilzer.
1940
1941         There are two problems that needed to be fixed:
1942
1943          - We can't assume .git is in $PWD/.git
1944          - We can't specify absolute paths to `git commit`
1945
1946         Fix these problems using the helpers in VCSUtils that were added to
1947         fix this same issue for prepare-changeCogs.
1948
1949         * Scripts/VCSUtils.pm: Export gitDirectory()
1950         * Scripts/git-add-reviewer:
1951         (nonInteractive): Cache gitDirectory() result.
1952         (addReviewer):
1953         (commit):
1954         (changeLogsForCommit): Make paths relative.
1955
1956 2016-02-03  Jer Noble  <jer.noble@apple.com>
1957
1958         Yet another Yosemite build fix.
1959
1960         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1961
1962 2016-02-03  Jer Noble  <jer.noble@apple.com>
1963
1964         iOS build fix after Yosemite build fix broke iOS build.
1965
1966         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1967
1968 2016-02-03  Jer Noble  <jer.noble@apple.com>
1969
1970         Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior.
1971
1972         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
1973
1974 2016-02-03  Joonghun Park  <jh718.park@samsung.com>
1975
1976         [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
1977         https://bugs.webkit.org/show_bug.cgi?id=153827
1978
1979         Reviewed by Michael Catanzaro.
1980
1981         When an array is passed to subroutines as argument in perl,
1982         a list containing its element is returned from the array.
1983         Currently @$ arguments are being passed, then it is going to be one list
1984         including all the elements not only from @ but also from $.
1985         As a result, --cmakeargs option's value is included in @cmakeArgs
1986         at generateBuildSystemFromCMakeProject subroutine,
1987         so $additionalCMakeArgs doesn't needed anymore.
1988
1989         * Scripts/webkitdirs.pm:
1990         (generateBuildSystemFromCMakeProject):
1991
1992 2016-02-03  Jer Noble  <jer.noble@apple.com>
1993
1994         [Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks
1995         https://bugs.webkit.org/show_bug.cgi?id=153669
1996
1997         Reviewed by Alex Christensen.
1998
1999         Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including
2000         calling appropriate NSURLSessionDelegate callbacks.
2001
2002         Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI.  Without this, the ENABLE macros in WebCore
2003         header files will not match the one used when compiling WebCore, leading to strange crashes and weird
2004         inconsistencies when calling, e.g., inline methods.
2005
2006         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added.
2007         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2008         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2009         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added.
2010         (-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]):
2011         (-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]):
2012         (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
2013         (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveData:]):
2014         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2015         (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
2016         (TestWebKitAPI::TEST_F):
2017
2018 2016-02-03  Konstantin Tokarev  <annulen@yandex.ru>
2019
2020         [webkitdirs] Clarify logic behind is{PortName} functions.
2021         https://bugs.webkit.org/show_bug.cgi?id=153554
2022
2023         Reviewed by Michael Catanzaro.
2024
2025         * Scripts/webkitdirs.pm:
2026         (prohibitUnknownPort): This function makes determinePortName()
2027         failure fatal.
2028         (determinePortName): Added new function which decides which port are
2029         we building based on command line switches and platform defaults.
2030         (portName): Added getter for determined $portName.
2031         (isEfl): Modified to use portName().
2032         (isGtk): Ditto.
2033         (isWinCairo): Ditto.
2034         (isAppleMacWebKit): Ditto.
2035         (isAppleWinWebKit): Ditto.
2036         (isIOSWebKit): Ditto.
2037         (cmakeBasedPortName): Return portName() with capitalized first letter.
2038         (determineIsEfl): Deleted.
2039         (determineIsGtk): Deleted.
2040         (determineIsWinCairo): Deleted.
2041
2042         * Scripts/build-jsc: Call prohibitUnknownPort().
2043         * Scripts/run-minibrowser: Ditto.
2044         * Scripts/webkitperl/FeatureList.pm: Ditto.
2045         * Scripts/update-webkit: Call determinePortName() instead of
2046         determineIsWinCairo().
2047
2048 2016-02-02  Dan Bernstein  <mitz@apple.com>
2049
2050         Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
2051         https://bugs.webkit.org/show_bug.cgi?id=153683
2052
2053         Reviewed by Darin Adler.
2054
2055         * Scripts/webkitpy/port/driver.py:
2056         (Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not
2057           used by any code in the Web Content process. If that ever changed, we should send it over
2058           as a bundle parameter.
2059
2060         * Scripts/webkitpy/port/ios.py:
2061         (IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013.
2062
2063         * Scripts/webkitpy/port/mac.py:
2064         (MacPort.setup_environ_for_server): Ditto.
2065
2066         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2067         (WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process
2068           environment. This is early enough that libxml2 has not been initialized yet.
2069
2070         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2071         (WTR::InjectedBundle::platformInitialize): Ditto.
2072
2073 2016-02-02  Dan Bernstein  <mitz@apple.com>
2074
2075         Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
2076         https://bugs.webkit.org/show_bug.cgi?id=153683
2077
2078         Reviewed by Alexey Proskuryakov.
2079
2080         Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well.
2081
2082         * Scripts/webkitpy/port/driver.py:
2083         (Driver._setup_environ_for_driver): Also set __XPC_DUMPRENDERTREE_TEMP.
2084         * Scripts/webkitpy/port/ios.py:
2085         (IOSSimulatorPort.setup_environ_for_server): Set __XPC_XML_CATALOG_FILES.
2086         * Scripts/webkitpy/port/mac.py:
2087         (MacPort.setup_environ_for_server): Ditto.
2088
2089 2016-01-29 Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2090
2091         [EFL] Virtual Keyboard overlaps MiniBrowser's WebView
2092         https://bugs.webkit.org/show_bug.cgi?id=153009
2093
2094         Reviewed by Gyuyoung Kim.
2095
2096         On mobile, virtual keyboard represented by ecore_imf module appears on
2097         the top of application layer usually covering bottom part of the screen.
2098         If the web page contains the editable content on the bottom of the page
2099         it will be overlapped by keyboard which prevents user from seeing the
2100         typed text.
2101
2102         Pack MiniBrowser layout into conformant widget to allow EFL to guess
2103         the space that will be required by the keyboard, finally resizing it
2104         to the desired size. As a result, webview gets resized and scrolled
2105         into focused elements which makes the editable elements visible while
2106         typing.
2107
2108         More details about elm_conformant widger can be found at:
2109         https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
2110         https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
2111
2112         * MiniBrowser/efl/main.c:
2113         (window_create): pack a box into conformant widget.
2114
2115 2016-02-02  Alejandro G. Castro  <alex@igalia.com>
2116
2117         [GTK][EFL] Upgrade OpenWebRTC dependency
2118         https://bugs.webkit.org/show_bug.cgi?id=153489
2119
2120         Reviewed by Philippe Normand.
2121
2122         * Scripts/run-gtk-tests:
2123         (TestRunner): Avoid running the mediastream API test.
2124         * Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by
2125         default for gtk and efl.
2126         * gtk/jhbuild-webrtc.modules: Added modules files with
2127         dependencies required to compile and test the mediastream.
2128
2129 2016-02-01  Jason Marcell  <jmarcell@apple.com>
2130
2131         Add code to parse the git branches out of the Trac RSS feed
2132         https://bugs.webkit.org/show_bug.cgi?id=153624
2133
2134         Reviewed by Daniel Bates.
2135
2136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2137         (Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
2138         (Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
2139         "branches" and updated the code to work with an array instead of a string.
2140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
2141         (MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.
2142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test
2143         fixture that contains XML with a Git branch.
2144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git
2145         branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.
2146
2147 2016-02-01  Brady Eidson  <beidson@apple.com>
2148
2149         Add command line flag to DRT to output the number of tests completed in server mode.
2150         https://bugs.webkit.org/show_bug.cgi?id=153750
2151
2152         Reviewed by Darin Adler.
2153
2154         * DumpRenderTree/mac/DumpRenderTree.mm:
2155         (initializeGlobalsFromCommandLineOptions):
2156         (runTestingServerLoop):
2157
2158 2016-02-01  Jason Marcell  <jmarcell@apple.com>
2159
2160         Improvements to botwatcher's dashboard unit tests.
2161         https://bugs.webkit.org/show_bug.cgi?id=153621
2162
2163         Reviewed by Darin Adler.
2164
2165         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
2166         (PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
2167         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
2168         (MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
2169         _popoverLinesForCommitRange have to traverse commits from different branches.
2170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
2171         in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
2172         _revisionContentWithPopoverForIteration.
2173
2174 2016-02-01  Jason Marcell  <jmarcell@apple.com>
2175
2176         Refactor to add event listeners and start periodic updates for all trac instances.
2177         https://bugs.webkit.org/show_bug.cgi?id=153609
2178
2179         Reviewed by Darin Adler.
2180
2181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2182         (BuildbotQueueView): Adding event listeners for all trac instances.
2183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates
2184         for all trac instances.
2185
2186 2016-01-31  Darin Adler  <darin@apple.com>
2187
2188         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
2189         https://bugs.webkit.org/show_bug.cgi?id=153639
2190
2191         Reviewed by Filip Pizlo.
2192
2193         * Scripts/do-webcore-rename: Use script to do this rename.
2194
2195 2016-01-30  Commit Queue  <commit-queue@webkit.org>
2196
2197         Unreviewed, rolling out r195911.
2198         https://bugs.webkit.org/show_bug.cgi?id=153723
2199
2200         Caused frequent assertion failures on bots (Requested by ap on
2201         #webkit).
2202
2203         Reverted changeset:
2204
2205         "Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
2206         https://bugs.webkit.org/show_bug.cgi?id=153639
2207         http://trac.webkit.org/changeset/195911
2208
2209 2016-01-30  Darin Adler  <darin@apple.com>
2210
2211         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
2212         https://bugs.webkit.org/show_bug.cgi?id=153639
2213
2214         Reviewed by Filip Pizlo.
2215
2216         * Scripts/do-webcore-rename: Use script to do this rename.
2217
2218 2016-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2219
2220         TouchList should be retargeted
2221         https://bugs.webkit.org/show_bug.cgi?id=149592
2222
2223         Reviewed by Antti Koivisto.
2224
2225         Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
2226         multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.
2227
2228         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2229         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2230         (WTR::UIScriptController::touchDownAtPoint): Added.
2231         (WTR::UIScriptController::liftUpAtPoint): Added.
2232         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2233         * WebKitTestRunner/ios/HIDEventGenerator.h:
2234         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2235         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
2236         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.
2237         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2238         (WTR::UIScriptController::touchDownAtPoint): Added.
2239         (WTR::UIScriptController::liftUpAtPoint): Added.
2240
2241 2016-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2242
2243         Enable SamplingProfiler on POSIX environment
2244         https://bugs.webkit.org/show_bug.cgi?id=153584
2245
2246         Reviewed by Michael Saboff.
2247
2248         * Scripts/run-jsc-stress-tests:
2249
2250 2016-01-29  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
2251
2252         update-webkit-dependency fails to fetch updates through firewall on Windows
2253         https://bugs.webkit.org/show_bug.cgi?id=153619
2254
2255         Reviewed by Myles C. Maxfield.
2256
2257         On Windows, when a firewall is present we need to read proxy settings
2258         from environment variables.
2259
2260         This patch relies on the following environment variables being set:
2261         HTTP_PROXY
2262         HTTPS_PROXY
2263
2264         * Scripts/update-webkit-dependency:
2265
2266 2016-01-28  Dan Bernstein  <mitz@apple.com>
2267
2268         [Cocoa] Use the non-Development variants of XPC services for development
2269         https://bugs.webkit.org/show_bug.cgi?id=152545
2270
2271         Reviewed by Darin Adler.
2272
2273         * Scripts/webkitdirs.pm:
2274         (setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
2275
2276         * Scripts/webkitpy/port/driver.py:
2277         (Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
2278           set in the XPC services as well.
2279
2280         * Scripts/webkitpy/port/ios.py:
2281         (IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
2282           Guard Malloc are enabled in XPC services as well.
2283
2284         * Scripts/webkitpy/port/mac.py:
2285         (MacPort.setup_environ_for_server): Ditto.
2286
2287 2016-01-28  Csaba Osztrogonác  <ossy@webkit.org>
2288
2289         Unreviewed buildfix after r195743.
2290
2291         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2292         (WTR::AccessibilityUIElement::isPressActionSupported):
2293
2294 2016-01-12  Jer Noble  <jer.noble@apple.com>
2295
2296         Custom protocol loading through AVFoundation does not support byte-range requests.
2297         https://bugs.webkit.org/show_bug.cgi?id=152919
2298         <rdar://problem/23664657>
2299
2300         Reviewed by Alex Christensen.
2301
2302         Add tests for new ParsedContntRange class.
2303
2304         * TestWebKitAPI/PlatformWin.cmake:
2305         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2306         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2308         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
2309         (TestWebKitAPI::TEST):
2310
2311 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
2312
2313         Use isAnyWindows() instead of isCygwin() || isWindows() in Perl scripts.
2314         https://bugs.webkit.org/show_bug.cgi?id=153594
2315
2316         Reviewed by Alex Christensen.
2317
2318         * Scripts/webkitdirs.pm:
2319         (determineNumberOfCPUs):
2320         (jscPath):
2321         (checkFrameworks):
2322         (setupCygwinEnv):
2323         (wrapperPrefixIfNeeded):
2324         (cmakeGeneratedBuildfile):
2325         (generateBuildSystemFromCMakeProject):
2326         * Scripts/webkitperl/features.pm:
2327         (libraryContainsSymbol):
2328
2329 2016-01-28  Chris Dumez  <cdumez@apple.com>
2330
2331         Unreviewed, rolling out r195742.
2332
2333         Broke EWS
2334
2335         Reverted changeset:
2336
2337         "[webkitdirs] Clarify logic behind is{PortName} functions."
2338         https://bugs.webkit.org/show_bug.cgi?id=153554
2339         http://trac.webkit.org/changeset/195742
2340
2341 2016-01-28  Darin Adler  <darin@apple.com>
2342
2343         Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
2344         https://bugs.webkit.org/show_bug.cgi?id=153411
2345
2346         Reviewed by Ryosuke Niwa.
2347
2348         * Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
2349         have removed the function instead.
2350
2351         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2352         (TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
2353         added overloads for const char*.
2354
2355         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2356         (WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
2357         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2358         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
2359         (WTR::testPathFromURL): Ditto.
2360
2361 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
2362
2363         [webkitdirs] Clarify logic behind is{PortName} functions.
2364         https://bugs.webkit.org/show_bug.cgi?id=153554
2365
2366         Reviewed by Darin Adler.
2367
2368         * Scripts/webkitdirs.pm:
2369         (determinePortName): Added new function which decides which port are
2370         we building based on command line switches and platform defaults.
2371         (portName): Added getter for determined $portName.
2372         (isEfl): Modified to use portName().
2373         (isGtk): Ditto.
2374         (isWinCairo): Ditto.
2375         (isAppleMacWebKit): Ditto.
2376         (isAppleWinWebKit): Ditto.
2377         (isIOSWebKit): Ditto.
2378         (cmakeBasedPortName): Code replaced with portName() call.
2379         (determineIsEfl): Deleted.
2380         (determineIsGtk): Deleted.
2381         (determineIsWinCairo): Deleted.
2382
2383 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
2384
2385         [webkitdirs] Don't pass cmakeBasedPortName around.
2386         https://bugs.webkit.org/show_bug.cgi?id=153589
2387
2388         Reviewed by Darin Adler.
2389
2390         It should be local function of webkitdirs.pm instead.
2391
2392         * Scripts/build-jsc: Don't pass cmakeBasedPortName to
2393         buildCMakeProjectOrExit().
2394         * Scripts/build-webkit: Don't pass cmakeBasedPortName to
2395         buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
2396         * Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
2397         generateBuildSystemFromCMakeProject().
2398         * Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
2399         (generateBuildSystemFromCMakeProject): Removed $port argument as we
2400         can get it from cmakeBasedPortName().
2401         (buildCMakeProjectOrExit): Ditto.
2402
2403 2016-01-28  Gwang Yoon Hwang  <yoon@igalia.com>
2404
2405         [GStreamer] Clean up includes and headers related with GStreamerGL
2406         https://bugs.webkit.org/show_bug.cgi?id=153590
2407
2408         Reviewed by Philippe Normand.
2409
2410         * Scripts/webkitpy/style/checker.py: Skips
2411         include_order check for MediaPlayerPrivateGStreamerBase.cpp
2412         Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
2413
2414 2016-01-27  Krzysztof Czech  <k.czech@samsung.com>
2415
2416         [EFL] Remove unused accessibility related code
2417         https://bugs.webkit.org/show_bug.cgi?id=153543
2418
2419         Reviewed by Darin Adler.
2420
2421         Removed reference to EAIL library.
2422         It not going to be support anymore. There have been changes in
2423         EFL/Elementary in terms of the accessibility and we should
2424         follow those.
2425
2426         * efl/jhbuild-optional.modules:
2427
2428 2016-01-27  Daniel Bates  <dabates@apple.com>
2429
2430         Remove WebKitSystemInterface for iOS SDK < 9
2431         https://bugs.webkit.org/show_bug.cgi?id=153570
2432
2433         Reviewed by Andy Estes.
2434
2435         * Scripts/copy-webkitlibraries-to-product-directory:
2436
2437 2016-01-27  Jason Marcell  <jmarcell@apple.com>
2438
2439         Fix bugs caused by incorrect usage of "branch" vs. "branchName".
2440         https://bugs.webkit.org/show_bug.cgi?id=153330
2441
2442         Reviewed by Daniel Bates.
2443
2444         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
2445         "branchName" implies that the variable or property in question is simply a string. We fixed some
2446         inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
2447         spotted in BuildbotQueueView.js.
2448
2449         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2450         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
2451         Changed branchName to branch.name in call to commitsOnBranch.
2452         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
2453         _popoverLinesForCommitRange.
2454         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
2455         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
2456         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
2457         fix.
2458
2459 2016-01-27  Ryosuke Niwa  <rniwa@webkit.org>
2460
2461         Add API to access closed shadowRoot in InjectedBundle
2462         https://bugs.webkit.org/show_bug.cgi?id=153533
2463
2464         Reviewed by Antti Koivisto.
2465
2466         Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
2467
2468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2469         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
2470         (TestWebKitAPI::runJavaScriptAlert):
2471         (TestWebKitAPI::TEST):
2472         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
2473         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
2474         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
2475
2476 2016-01-27  Jason Marcell  <jmarcell@apple.com>
2477
2478         Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
2479         https://bugs.webkit.org/show_bug.cgi?id=153332
2480
2481         Reviewed by Alexey Proskuryakov.
2482
2483         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2484         (Trac.prototype._xmlTimelineURL): Uses new function.
2485         (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
2486         logic for parsing git hashes.
2487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
2488         Trac._parseRevisionFromURL.
2489
2490 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
2491
2492         Remove Mavericks from the flakiness dashboard
2493         https://bugs.webkit.org/show_bug.cgi?id=153521
2494
2495         Reviewed by Dan Bernstein.
2496
2497         * TestResultServer/static-dashboards/builders.jsonp:
2498         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2499
2500 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
2501
2502         Remove ENABLE_CURRENTSRC
2503         https://bugs.webkit.org/show_bug.cgi?id=153545
2504
2505         Reviewed by Simon Fraser.
2506
2507         * Scripts/webkitperl/FeatureList.pm:
2508
2509 2016-01-26  Jason Marcell  <jmarcell@apple.com>
2510
2511         Sort incoming commits via date instead of revision number.
2512         https://bugs.webkit.org/show_bug.cgi?id=153467
2513
2514         Reviewed by Alexey Proskuryakov.
2515
2516         Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
2517         for sorting revisions. Instead we use the commit date to sort revisions chronologically.
2518
2519         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2520         (Trac.prototype._loaded): Sort via date instead of revision number.
2521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
2522         (MockTrac): Fix up the mock data to look more like real-world data.
2523         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
2524         Fake RSS feed that adds three more commits.
2525         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
2526         Trac._loaded().
2527
2528 2016-01-26  I-Ting Liu  <iting_liu@apple.com>
2529
2530         Add a test for WebKit::stringMatchesWildcardString.
2531         https://bugs.webkit.org/show_bug.cgi?id=153090
2532
2533         Reviewed by Darin Adler.
2534
2535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2536         Add the file to the project.
2537
2538         * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
2539         (TestWebKitAPI::TEST):
2540         Test that a string matches another string that may contain wildcard characters.
2541
2542 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
2543
2544         [webkitdirs] Removed check for bison, gperf, and flex.
2545         https://bugs.webkit.org/show_bug.cgi?id=153496
2546
2547         Reviewed by Alex Christensen.
2548
2549         This prerequisites are checked in WebKitCommon.cmake and don't
2550         have to be in $PATH.
2551
2552         * Scripts/webkitdirs.pm:
2553         (checkRequiredSystemConfig):
2554
2555 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
2556
2557         [webkitdirs] isCMakeBuild should be true by default
2558         https://bugs.webkit.org/show_bug.cgi?id=153497
2559
2560         Reviewed by Michael Catanzaro.
2561
2562         * Scripts/webkitdirs.pm:
2563         (isCMakeBuild):
2564
2565 2016-01-26  Daniel Bates  <dabates@apple.com>
2566
2567         Add WebKitSystemInterface for iOS 9.2
2568         https://bugs.webkit.org/show_bug.cgi?id=153355
2569
2570         Rubber-stamped by David Kilzer.
2571
2572         * Scripts/copy-webkitlibraries-to-product-directory:
2573
2574 2016-01-26  Daniel Bates  <dabates@apple.com>
2575
2576         WebKitTestRunner: Credential cache is not cleared between tests
2577         https://bugs.webkit.org/show_bug.cgi?id=153407
2578         <rdar://problem/24280834>
2579
2580         Reviewed by Alexey Proskuryakov.
2581
2582         * WebKitTestRunner/TestController.cpp:
2583         (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
2584         to clear cached credentials.
2585
2586 2016-01-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2587
2588         kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
2589         https://bugs.webkit.org/show_bug.cgi?id=153483
2590
2591         Reviewed by Csaba Osztrogonác.
2592
2593         * BuildSlaveSupport/kill-old-processes:
2594         (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
2595
2596 2016-01-25  Simon Fraser  <simon.fraser@apple.com>
2597
2598         Give the layout test results file a <title> showing the date and time the tests were run
2599         https://bugs.webkit.org/show_bug.cgi?id=153187
2600
2601         Reviewed by Darin Adler.
2602         
2603         Include a 'date' property in the JSON with the date and time the tests completed.
2604
2605         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2606         (summarize_results):
2607
2608 2016-01-25  Commit Queue  <commit-queue@webkit.org>
2609
2610         Unreviewed, rolling out r195543.
2611         https://bugs.webkit.org/show_bug.cgi?id=153451
2612
2613         regressed performance of test bots by ~6% (Requested by dydz
2614         on #webkit).
2615
2616         Reverted changeset:
2617
2618         "WebKitTestRunner: Credential cache is not cleared between
2619         tests"
2620         https://bugs.webkit.org/show_bug.cgi?id=153407
2621         http://trac.webkit.org/changeset/195543
2622
2623 2016-01-25  Aakash Jain  <aakash_jain@apple.com>
2624
2625         Failing to upload to flakiness dashboard should not be a hard error
2626         https://bugs.webkit.org/show_bug.cgi?id=153444
2627         <rdar://problem/22146294>
2628
2629         Reviewed by Alexey Proskuryakov.
2630
2631         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2632         (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
2633
2634 2016-01-25  Daniel Bates  <dabates@apple.com>
2635
2636         WebKitTestRunner: Credential cache is not cleared between tests
2637         https://bugs.webkit.org/show_bug.cgi?id=153407
2638         <rdar://problem/24280834>
2639
2640         Reviewed by Brady Eidson.
2641
2642         * WebKitTestRunner/TestController.cpp:
2643         (WTR::TestController::resetStateToConsistentValues): Reset testing network session
2644         to clear cached credentials.
2645
2646 2016-01-24  Dan Bernstein  <mitz@apple.com>
2647
2648         Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
2649
2650         * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
2651
2652 2016-01-22  Enrica Casucci  <enrica@apple.com>
2653
2654         Unreviewed build fix after http://trac.webkit.org/changeset/195474.
2655
2656         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2657         (WTR::TestController::platformCreateWebView):
2658
2659 2016-01-22  Tim Horton  <timothy_horton@apple.com>
2660
2661         Add a test for iOS arrow-key repeat
2662         https://bugs.webkit.org/show_bug.cgi?id=152857
2663         <rdar://problem/24017380>
2664
2665         Reviewed by Darin Adler.
2666
2667         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2668         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2669         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
2670         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
2671         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2672         * WebKitTestRunner/ios/HIDEventGenerator.h:
2673         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2674         (-[HIDEventGenerator keyPress:completionBlock:]):
2675         (-[HIDEventGenerator keyDown:completionBlock:]):
2676         (-[HIDEventGenerator keyUp:completionBlock:]):
2677         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2678         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
2679         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
2680         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
2681         Make it possible to independently send keyUp/keyDown, instead of just paired.
2682
2683 2016-01-22  Tim Horton  <timothy_horton@apple.com>
2684
2685         Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
2686         https://bugs.webkit.org/show_bug.cgi?id=153193
2687         <rdar://problem/24222034>
2688
2689         Reviewed by Darin Adler.
2690
2691         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2692         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
2693         (TEST):
2694         Add a test that exhibits the problems we're fixing here.
2695         Before, it would both log and assert in debug, and crash in release.
2696         Now it runs happily to completion.
2697
2698 2016-01-22  Enrica Casucci  <enrica@apple.com>
2699
2700         Add support for testing data detection.
2701         https://bugs.webkit.org/show_bug.cgi?id=153360
2702
2703         Reviewed by Tim Horton.
2704
2705         Adding a new testing option (useDataDetection) to turn on
2706         data detection when running the a test.
2707
2708         * WebKitTestRunner/TestController.cpp:
2709         (WTR::updateTestOptionsFromTestHeader):
2710         * WebKitTestRunner/TestOptions.h:
2711         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2712         (WTR::TestController::platformCreateWebView):
2713
2714 2016-01-21  Simon Fraser  <simon.fraser@apple.com>
2715
2716         Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
2717         https://bugs.webkit.org/show_bug.cgi?id=153334
2718
2719         Reviewed by Zalan Bujtas.
2720         
2721         Evaluating expressions in the LayoutUnit summary provider seems to cause
2722         re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
2723         denominator to 64.
2724
2725         * lldb/lldb_webkit.py:
2726         (WebCoreLayoutUnitProvider.to_string):
2727
2728 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
2729
2730         display-profiler-output should be able to display code blocks sorted by machine counts
2731         https://bugs.webkit.org/show_bug.cgi?id=153298
2732
2733         Reviewed by Oliver Hunt.
2734
2735         * Scripts/display-profiler-output:
2736
2737 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
2738
2739         Ensure to use compatible liborc version with wanted gstreamer version
2740         https://bugs.webkit.org/show_bug.cgi?id=153276
2741
2742         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
2743         The user may have a very recent liborc installed on his system.
2744
2745         Reviewed by Philippe Normand.
2746
2747         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
2748         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
2749
2750 2016-01-21  Nan Wang  <n_wang@apple.com>
2751
2752         AX: [IOS] Implement next/previous text marker functions using TextIterator
2753         https://bugs.webkit.org/show_bug.cgi?id=153292
2754         <rdar://problem/24268243>
2755
2756         Reviewed by Chris Fleizach.
2757
2758         Made text marker tests available on iOS.
2759
2760         * DumpRenderTree/AccessibilityTextMarker.h:
2761         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2762         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
2763         (AccessibilityTextMarker::AccessibilityTextMarker):
2764         (AccessibilityTextMarker::~AccessibilityTextMarker):
2765         (AccessibilityTextMarker::isEqual):
2766         (AccessibilityTextMarker::platformTextMarker):
2767         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2768         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2769         (AccessibilityTextMarkerRange::isEqual):
2770         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2771         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2772         (AccessibilityUIElement::pathDescription):
2773         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2774         (AccessibilityUIElement::textMarkerRangeForElement):
2775         (AccessibilityUIElement::selectedTextMarkerRange):
2776         (AccessibilityUIElement::resetSelectedTextMarkerRange):
2777         (AccessibilityUIElement::textMarkerRangeLength):
2778         (AccessibilityUIElement::textMarkerRangeForMarkers):
2779         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2780         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2781         (AccessibilityUIElement::accessibilityElementForTextMarker):
2782         (AccessibilityUIElement::endTextMarkerForBounds):
2783         (AccessibilityUIElement::startTextMarkerForBounds):
2784         (AccessibilityUIElement::textMarkerForPoint):
2785         (AccessibilityUIElement::previousTextMarker):
2786         (AccessibilityUIElement::nextTextMarker):
2787         (AccessibilityUIElement::stringForTextMarkerRange):
2788         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2789         (AccessibilityUIElement::indexForTextMarker):
2790         (AccessibilityUIElement::isTextMarkerValid):
2791         (AccessibilityUIElement::textMarkerForIndex):
2792         (AccessibilityUIElement::startTextMarker):
2793         (AccessibilityUIElement::endTextMarker):
2794         (AccessibilityUIElement::setSelectedVisibleTextRange):
2795         (AccessibilityUIElement::getLinkedUIElements):
2796         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2797         (AccessibilityTextMarkerRange::platformTextMarkerRange):
2798         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2799         (AccessibilityUIElement::removeSelection):
2800         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2801         (AccessibilityUIElement::setSelectedVisibleTextRange):
2802         (AccessibilityUIElement::supportedActions):
2803         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2804         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2805         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2806         (WTR::AccessibilityUIElement::previousTextMarker):
2807         (WTR::AccessibilityUIElement::nextTextMarker):
2808         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2809         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2810         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2811         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2812         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
2813         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2814         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2815
2816 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
2817
2818         Unreviewed, revert accidental unreviewed commit.
2819
2820         * Scripts/display-profiler-output:
2821
2822 2016-01-20  Jason Marcell  <jmarcell@apple.com>
2823
2824         Refactor compareIterations to remove duplicate code.
2825         https://bugs.webkit.org/show_bug.cgi?id=152913
2826
2827         Reviewed by Daniel Bates.
2828
2829         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2830         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
2831         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
2832         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
2833         the same behavior before and after refactor.
2834
2835 2016-01-20  Dana Burkart  <dburkart@apple.com>
2836
2837         Botwatcher's dashboard should show an 'X' when the build is broken
2838         https://bugs.webkit.org/show_bug.cgi?id=152507
2839
2840         Reviewed by David Kilzer.
2841
2842         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2843         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
2844         (BuildbotStaticAnalyzerQueueView.prototype.update):
2845
2846 2016-01-19  Jason Marcell  <jmarcell@apple.com>
2847
2848         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
2849         https://bugs.webkit.org/show_bug.cgi?id=153262
2850
2851         Reviewed by Alexey Proskuryakov.
2852
2853         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
2854         such cases this revisionContentForIteration method does not have any content to return, thus the
2855         assertion fails.
2856
2857         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2858         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
2859
2860 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2861
2862         [GTK] Runtime critical warnings when loading a URL after a session restore
2863         https://bugs.webkit.org/show_bug.cgi?id=153233
2864
2865         Reviewed by Michael Catanzaro.
2866
2867         Add new test case.
2868
2869         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
2870         (viewLoadChanged):
2871         (testWebKitWebViewNavigationAfterSessionRestore):
2872         (beforeAll):
2873
2874 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2875
2876         [GTK] Remove jhbuild-optional.modules
2877         https://bugs.webkit.org/show_bug.cgi?id=152964
2878
2879         Reviewed by Alex Christensen.
2880
2881         * gtk/jhbuild-optional.modules: Removed.
2882         * gtk/jhbuild.modules:
2883
2884 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2885
2886         [GTK] Add support to load/save session in MiniBrowser
2887         https://bugs.webkit.org/show_bug.cgi?id=153201
2888
2889         Reviewed by Michael Catanzaro.
2890
2891         It makes it easier to test the new WebView session API.
2892
2893         * MiniBrowser/gtk/BrowserWindow.c:
2894         (browserWindowFinalize): Free the session file path.
2895         (browserWindowSaveSession): Save the current WebView session if
2896         there's a session file path.
2897         (browserWindowDeleteEvent): Call browserWindowSaveSession().
2898         (browser_window_load_session): Try to load the session from the
2899         given file path, otherwise fall back to homepage and keep the
2900         session file to save the session on window close.
2901         * MiniBrowser/gtk/BrowserWindow.h:
2902         * MiniBrowser/gtk/main.c:
2903         (createBrowserWindow): Pass the given session file path when
2904         shouldLoadSession is TRUE.
2905         (main): Only allow to restore/save session when MiniBrowser is
2906         launched without URL arguments.
2907
2908 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2909
2910         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
2911
2912         Geolocation is no longer allowed for unique origins after r195075.
2913
2914         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2915         (testWebViewGeolocationPermissionRequests):
2916
2917 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2918
2919         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
2920         https://bugs.webkit.org/show_bug.cgi?id=153216
2921
2922         Reviewed by Michael Catanzaro.
2923
2924         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
2925         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
2926
2927 2016-01-18  Nan Wang  <n_wang@apple.com>
2928
2929         AX: [Mac] Implement next/previous text marker functions using TextIterator
2930         https://bugs.webkit.org/show_bug.cgi?id=152728
2931
2932         Reviewed by Chris Fleizach.
2933
2934         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2935         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2936
2937 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
2938
2939         [cmake] Add testair to the build system
2940         https://bugs.webkit.org/show_bug.cgi?id=153126
2941
2942         Reviewed by Michael Catanzaro.
2943
2944         * Scripts/build-jsc:
2945
2946 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
2947
2948         Remove TextRun::allowsRoundingHacks()
2949         https://bugs.webkit.org/show_bug.cgi?id=153185
2950
2951         Reviewed by Simon Fraser.
2952
2953         * DumpRenderTree/mac/DumpRenderTree.mm:
2954         (resetWebViewToConsistentStateBeforeTesting): Deleted.
2955
2956 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
2957
2958         [webkitdirs] Avoid list form of open because it broke WinCairo
2959         https://bugs.webkit.org/show_bug.cgi?id=153106
2960
2961         Reviewed by Alex Christensen.
2962
2963         * Scripts/webkitdirs.pm:
2964         (determineArchitecture):
2965
2966 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
2967
2968         Add kdebug_trace signposts for a few WebCore operations
2969         https://bugs.webkit.org/show_bug.cgi?id=153136
2970         rdar://problem/24208487
2971
2972         Reviewed by Sam Weinig.
2973         
2974         Plist used by kdebug_trace() viewing tools.
2975
2976         * Tracing/SystemTracePoints.plist: Added.
2977
2978 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
2979
2980         [webkitdirs] Replaced grep invocation with perl code
2981         https://bugs.webkit.org/show_bug.cgi?id=153106
2982
2983         Reviewed by Alex Christensen.
2984
2985         * Scripts/webkitdirs.pm:
2986         (determineArchitecture):
2987
2988 2016-01-14  Brian Burg  <bburg@apple.com>
2989
2990         prepare-changelog does not read paths containing spaces properly
2991         https://bugs.webkit.org/show_bug.cgi?id=137982
2992
2993         Reviewed by Joseph Pecoraro.
2994
2995         Escape whitespace in filenames before passing the file path to other functions.
2996
2997         * Scripts/prepare-ChangeLog:
2998         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
2999
3000 2016-01-14  Jason Marcell  <jmarcell@apple.com>
3001
3002         Standardize the usage of "branch" vs. "branchName".
3003         https://bugs.webkit.org/show_bug.cgi?id=152982
3004
3005         Reviewed by Daniel Bates.
3006
3007         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
3008         "branchName" implies that the variable or property in question is simply a string.
3009
3010         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3011         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
3012         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
3013         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
3014         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3015         (Trac.prototype.commitsOnBranch): Change branch to branchName.
3016         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
3017         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
3018         (MockTrac): Ditto.
3019
3020 2016-01-14  Jason Marcell  <jmarcell@apple.com>
3021
3022         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
3023         https://bugs.webkit.org/show_bug.cgi?id=152910
3024
3025         Reviewed by Daniel Bates.
3026
3027         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
3028         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
3029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
3030         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
3031         the need to talk to a real Buildbot server.
3032         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
3033         without the need to talk to a real Buildbot server.
3034         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
3035         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
3036         server.
3037         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
3038         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
3039         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
3040         trying to talk to Trac.
3041         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
3042         QUnit unit tests.
3043         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
3044
3045 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
3046
3047         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
3048         https://bugs.webkit.org/show_bug.cgi?id=132599
3049
3050         Reviewed by Michael Catanzaro.
3051
3052         Check if cmake Ninja generators are installed.
3053
3054         * Scripts/webkitdirs.pm:
3055         (canUseNinjaGenerator):
3056         (canUseEclipseNinjaGenerator):
3057         (generateBuildSystemFromCMakeProject):
3058         (canUseEclipse): Deleted.
3059
3060 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
3061
3062         [Cocoa] Testing with font family name "System Font" is unused
3063         https://bugs.webkit.org/show_bug.cgi?id=153073
3064         <rdar://problem/24091683>
3065
3066         Reviewed by Brent Fulgham.
3067
3068         * DumpRenderTree/mac/DumpRenderTree.mm:
3069         (allowedFontFamilySet): Deleted.
3070         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3071         (WTR::allowedFontFamilySet): Deleted.
3072         * WebKitTestRunner/mac/TestControllerMac.mm:
3073         (WTR::allowedFontFamilySet): Deleted.
3074
3075 2016-01-13  Daniel Bates  <dabates@apple.com>
3076
3077         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
3078         https://bugs.webkit.org/show_bug.cgi?id=152871
3079
3080         Reviewed by Brent Fulgham.
3081
3082         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
3083         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
3084
3085         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
3086
3087 2016-01-08  Andy Estes  <aestes@apple.com>
3088
3089         [Content Filtering] Lazily load platform frameworks
3090         https://bugs.webkit.org/show_bug.cgi?id=152881
3091         rdar://problem/23270886
3092
3093         Reviewed by Brady Eidson.
3094
3095         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
3096         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
3097         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
3098         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
3099         is loaded after an HTTPS request.
3100
3101         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
3102         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
3103         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
3104         also re-enabled on iOS after mistakenly being disabled by r188892.
3105
3106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3107         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3108         (TestWebKitAPI::TEST):
3109         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
3110         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
3111         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3112         (TEST):
3113         (downloadTest):
3114         (-[LazilyLoadPlatformFrameworksController init]):
3115         (-[LazilyLoadPlatformFrameworksController webView]):
3116         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
3117         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
3118         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3119         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3120         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
3121         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
3122         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3123         (TestWebKitAPI::TEST):
3124         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3125         (TestWebKitAPI::TEST): Deleted.
3126         * TestWebKitAPI/cocoa/TestProtocol.h:
3127         * TestWebKitAPI/cocoa/TestProtocol.mm:
3128         (+[TestProtocol registerWithScheme:]):
3129         (+[TestProtocol unregister]):
3130
3131 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
3132
3133         Fix the Sunpider converage in slow device.
3134         https://bugs.webkit.org/show_bug.cgi?id=152938
3135         <rdar://problem/22511411>
3136
3137         Reviewed by Ryosuke Niwa.
3138
3139         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
3140
3141         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
3142
3143 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
3144
3145         Add a build flag for custom element
3146         https://bugs.webkit.org/show_bug.cgi?id=153005
3147
3148         Reviewed by Alex Christensen.
3149
3150         Added --custom-elements option to enable custom elements support.
3151
3152         * Scripts/webkitperl/FeatureList.pm:
3153
3154 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
3155
3156         [JSC] Add a help message when run-jsc-stress-tests fails
3157         https://bugs.webkit.org/show_bug.cgi?id=153014
3158
3159         Reviewed by Csaba Osztrogonác.
3160
3161         * Scripts/run-jsc-stress-tests:
3162
3163 2016-01-11  Saam barati  <sbarati@apple.com>
3164
3165         run-jsc-stress-tests should try to figure out a JSC path
3166         https://bugs.webkit.org/show_bug.cgi?id=152971
3167
3168         Reviewed by Yusuke Suzuki.
3169
3170         This patch now allows run-jsc-stress-tests to be run
3171         without a "--jsc <jsc-path>" argument. It tries
3172         to take its best guess at a <jsc-path> automagically.
3173         
3174         This makes it much easier to just run run-jsc-stress-tests
3175         with a directory or a yaml file as an argument.
3176         You now just do this:
3177         `run-jsc-stress-tests <path-to-yaml>`
3178         or
3179         `run-jsc-stress-tests <path-to-directory-of-js-files>`
3180         
3181         I wrote this patch because I'd often find myself hacking the 
3182         run-javascriptcore-tests file just to run a particular subset of tests.
3183         Because I always forget the arguments to run-jsc-stress-tests (which means
3184         I always forgot to provide a --jsc argument), I always found it easier to 
3185         just hack on that file instead of calling run-jsc-stress-tests directly.
3186         No longer is this true!
3187
3188         * Scripts/run-jsc-stress-tests:
3189
3190 2016-01-09  Andy Estes  <aestes@apple.com>
3191
3192         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
3193         https://bugs.webkit.org/show_bug.cgi?id=152950
3194         rdar://problem/24066652
3195
3196         Reviewed by Tim Horton.
3197
3198         Added an API test.
3199
3200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3201         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
3202         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
3203         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
3204         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
3205         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
3206         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
3207         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
3208         (TEST):
3209
3210 2016-01-11  Commit Queue  <commit-queue@webkit.org>
3211
3212         Unreviewed, rolling out r194866.
3213         https://bugs.webkit.org/show_bug.cgi?id=152986
3214
3215         This change broke the mac build (Requested by ryanhaddad on
3216         #webkit).
3217
3218         Reverted changeset:
3219
3220         "[Cocoa] Add SPI to opt out a URL scheme from the memory
3221         cache"
3222         https://bugs.webkit.org/show_bug.cgi?id=152950
3223         http://trac.webkit.org/changeset/194866
3224
3225 2016-01-11  Andy Estes  <aestes@apple.com>
3226
3227         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
3228         https://bugs.webkit.org/show_bug.cgi?id=152950
3229         rdar://problem/24066652
3230
3231         Reviewed by Tim Horton.
3232
3233         Added an API test.
3234
3235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3236         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
3237         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
3238         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
3239         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
3240         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
3241         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
3242         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
3243         (TEST):
3244
3245 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
3246
3247         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
3248         https://bugs.webkit.org/show_bug.cgi?id=152959
3249
3250         Reviewed by Brent Fulgham.
3251
3252         * Scripts/webkitdirs.pm:
3253         (determineArchitecture):
3254
3255 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3256
3257         [GTK] W3C CSS2.1 anonymous table tests are failing
3258         https://bugs.webkit.org/show_bug.cgi?id=152455
3259
3260         Reviewed by Mario Sanchez Prada.
3261
3262         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
3263         tests. Add upstream patches to fix detection of XHTML files.
3264
3265         * gtk/jhbuild.modules:
3266         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
3267         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
3268
3269 2016-01-10  Saam barati  <sbarati@apple.com>
3270
3271         Implement a sampling profiler
3272         https://bugs.webkit.org/show_bug.cgi?id=151713
3273
3274         Reviewed by Filip Pizlo.
3275
3276         * Scripts/run-jsc-stress-tests:
3277
3278 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
3279
3280         [webkitdirs] Try arch and uname commands on non-windows OS
3281         https://bugs.webkit.org/show_bug.cgi?id=152958
3282
3283         Reviewed by Michael Catanzaro.
3284
3285         Right now, determineArchitecture()  uses `arch` and `uname -m`
3286         commands to determine architecture in case of condition (isGtk() ||
3287         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
3288         instead, because this code is applicable to any non-windows OS WebKit
3289         supports (even Haiku which once was supported is moderately
3290         POSIX-compliant and has uname command).
3291
3292         * Scripts/webkitdirs.pm:
3293         (determineArchitecture):
3294
3295 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
3296
3297         run-webkit-tests mis-counts totals when there are other crashes
3298         https://bugs.webkit.org/show_bug.cgi?id=152894
3299         <rdar://problem/24098697>
3300
3301         Reviewed by Alexey Proskuryakov.
3302
3303         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3304         (TestRunResults.add): Do not update result counters for other crashes.
3305
3306 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3307
3308         webkit-patch build-and-test should have an option to iterate over new tests
3309         https://bugs.webkit.org/show_bug.cgi?id=143093
3310
3311         Reviewed by Michael Catanzaro.
3312
3313         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
3314         It allows running run-webkit-tests on modified or new paths in LayoutTests.
3315         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
3316         It implements the translation of -expected.* paths to their related tests.
3317         It also implements the removal of skipped tests.
3318
3319         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3320         (LayoutTestFinder.find_touched_tests):
3321         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
3322         (MockPort):
3323         (MockPort.__init__):
3324         (MockPort.tests):
3325         (LayoutTestFinderTests):
3326         (LayoutTestFinderTests.touched_files):
3327         (LayoutTestFinderTests.test_touched_test):
3328         (LayoutTestFinderTests.test_expected_touched_test):
3329         (LayoutTestFinderTests.test_platform_expected_touched_test):
3330         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
3331         (LayoutTestFinderTests.test_touched_but_skipped_test):
3332         * Scripts/webkitpy/port/base.py:
3333         (Port.potential_test_names_from_expected_file):
3334         * Scripts/webkitpy/tool/commands/download_unittest.py:
3335         (DownloadCommandsTest._default_options):
3336         * Scripts/webkitpy/tool/steps/options.py:
3337         (Options):
3338         * Scripts/webkitpy/tool/steps/runtests.py:
3339         (RunTests.options):
3340         (RunTests.run):
3341         (RunTests):
3342         (RunTests._new_or_modified_tests):
3343         (RunTests._run_webkit_tests):
3344         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3345         (RunTestsTest.test_webkit_run_unit_tests):
3346         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3347         (StepsTest._step_options):
3348
3349 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
3350
3351         prepare-ChangeLog should include radar number
3352         https://bugs.webkit.org/show_bug.cgi?id=152839
3353         <rdar://problem/24093563>
3354
3355         Reviewed by Daniel Bates.
3356
3357         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
3358         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
3359         in the ChangeLog description after the bug URL.
3360
3361         * Scripts/prepare-ChangeLog:
3362         (main): Update signatures.
3363         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
3364         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
3365         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
3366         (generateNewChangeLogs): Include radar URL if we found one.
3367
3368         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
3369         Tests for the radar URL extraction.
3370
3371 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
3372
3373         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
3374         https://bugs.webkit.org/show_bug.cgi?id=152390
3375         <rdar://problem/23948321>
3376
3377         Reviewed by Simon Fraser.
3378
3379         Fix two use-after-frees.
3380
3381         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
3382         but we may have already progressed to another test by the time the callback fires,
3383         having destroyed the TestInvocation.
3384         2. UIScriptController is a RefCounted object, but it has a raw pointer to
3385         UIScriptContext which has the same lifetime as a TestInvocation.
3386         As a result, completion blocks of UIScriptController actions would use a destroyed
3387         TestInvocation.
3388
3389         * WebKitTestRunner/TestInvocation.cpp:
3390         (WTR::TestInvocation::~TestInvocation):
3391         (WTR::TestInvocation::url):
3392         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3393         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
3394         (WTR::TestInvocation::runUISideScript):
3395         * WebKitTestRunner/TestInvocation.h:
3396         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
3397         (UIScriptContext::UIScriptContext):
3398         (UIScriptContext::~UIScriptContext):
3399         (UIScriptContext::runUIScript):
3400         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
3401         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3402         (WTR::UIScriptController::UIScriptController):
3403         (WTR::UIScriptController::contextDestroyed):
3404         (WTR::UIScriptController::makeWindowObject):
3405         (WTR::UIScriptController::setWillBeginZoomingCallback):
3406         (WTR::UIScriptController::willBeginZoomingCallback):
3407         (WTR::UIScriptController::setDidEndZoomingCallback):
3408         (WTR::UIScriptController::didEndZoomingCallback):
3409         (WTR::UIScriptController::setDidEndScrollingCallback):
3410         (WTR::UIScriptController::didEndScrollingCallback):
3411         (WTR::UIScriptController::setDidShowKeyboardCallback):
3412         (WTR::UIScriptController::didShowKeyboardCallback):
3413         (WTR::UIScriptController::setDidHideKeyboardCallback):
3414         (WTR::UIScriptController::didHideKeyboardCallback):
3415         (WTR::UIScriptController::uiScriptComplete):
3416         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3417         (WTR::UIScriptController::create):
3418         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3419         (WTR::UIScriptController::doAsyncTask):
3420         (WTR::UIScriptController::zoomToScale):
3421         (WTR::UIScriptController::singleTapAtPoint):
3422         (WTR::UIScriptController::doubleTapAtPoint):
3423         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
3424         (WTR::UIScriptController::contentVisibleRect):
3425         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
3426         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
3427         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
3428         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
3429         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
3430         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3431         (WTR::UIScriptController::doAsyncTask):
3432
3433 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3434
3435         [buildbot] clean-build script should remove untracked files and revert local changes too
3436         https://bugs.webkit.org/show_bug.cgi?id=142400
3437
3438         Reviewed by Ryosuke Niwa.
3439
3440         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
3441         A helper routine SCM.discard_untracked_files is added for that purpose.
3442
3443         * BuildSlaveSupport/clean-build:
3444         (main): Making call to Scripts/clean-webkit
3445         * Scripts/clean-webkit: Added.
3446         (main): Revert changes and delete untracked files.
3447         * Scripts/webkitpy/common/checkout/scm/scm.py:
3448         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
3449         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3450         (SCMTest._shared_test_discard_untracked_files):
3451         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
3452
3453 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
3454
3455         Add a setting and preferences to enable display-list drawing. Does nothing yet.
3456         https://bugs.webkit.org/show_bug.cgi?id=152807
3457
3458         Reviewed by Zalan Bujtas.
3459         
3460         Add an item to the Settings menu to toggle display-list drawing.
3461
3462         * MiniBrowser/mac/SettingsController.h:
3463         * MiniBrowser/mac/SettingsController.m:
3464         (-[SettingsController _populateMenu]):
3465         (-[SettingsController validateMenuItem:]):
3466         (-[SettingsController toggleDisplayListDrawingEnabled:]):
3467         (-[SettingsController displayListDrawingEnabled]):
3468         * MiniBrowser/mac/WK2BrowserWindowController.m:
3469         (-[WK2BrowserWindowController didChangeSettings]):
3470
3471 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3472
3473         Python SCM should be able to retrieve untracked files - Add GIT support
3474         https://bugs.webkit.org/show_bug.cgi?id=143135
3475
3476         Reviewed by Michael Catanzaro.
3477
3478         * Scripts/webkitpy/common/checkout/scm/git.py:
3479         (Git.untracked_files): Adding support for git.
3480         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3481         (GitTest.setUp):
3482         (GitTest.test_untracked_files): Adding test.
3483
3484 2016-01-05  Mark Lam  <mark.lam@apple.com>
3485
3486         Rename badly named JSC_timeout env var to JSCTEST_timeout.
3487         https://bugs.webkit.org/show_bug.cgi?id=152748
3488
3489         Reviewed by Geoffrey Garen.
3490
3491         Now that we validate JSC options, the badly named JSC_timeout env var causes the
3492         bots to have a bad time.
3493
3494         * Scripts/run-javascriptcore-tests:
3495         * Scripts/run-jsc-stress-tests:
3496
3497 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3498
3499         [GTK] Allow to save and restore session
3500         https://bugs.webkit.org/show_bug.cgi?id=115600
3501
3502         Reviewed by Michael Catanzaro.
3503
3504         Add test case to check the new session API.
3505
3506         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
3507         (testWebKitWebViewSessionState):
3508         (testWebKitWebViewSessionStateWithFormData):
3509         (beforeAll):
3510
3511 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
3512
3513         [EFL] Bump EFL version to 1.16.1
3514         https://bugs.webkit.org/show_bug.cgi?id=152688
3515
3516         Reviewed by Gyuyoung Kim.
3517
3518         * efl/jhbuild.modules:
3519
3520 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
3521
3522         error running layout tests on iOS simulator on latest build
3523         https://bugs.webkit.org/show_bug.cgi?id=152719
3524         <rdar://problem/24009549>
3525
3526         Reviewed by Alexey Proskuryakov.
3527
3528         * Scripts/webkitpy/xcode/simulator.py:
3529         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
3530           before running simctl spawn command.
3531
3532 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3533
3534         Unreviewed, move Frédéric Wang to committers list
3535
3536         He seems to be on the contributors list by accident. He has been landing his own commits for
3537         about two years now.
3538
3539         * Scripts/webkitpy/common/config/contributors.json:
3540
3541 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3542
3543         Unreviewed, move Sebastian Dröge to committers list harder
3544
3545         He accidentally added himself to the reviewers list because the file is confusing. Then I
3546         accidentially moved him to the contributors list because the file is confusing, even though
3547         I knew the contributors list existed in this file and was attempting to add him to the
3548         committers list. Really move him to the committers list now.
3549
3550         * Scripts/webkitpy/common/config/contributors.json:
3551
3552 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3553
3554         Python SCM should be able to retrieve untracked files - Add SVN support
3555         https://bugs.webkit.org/show_bug.cgi?id=152546
3556
3557         Reviewed by Michael Catanzaro.
3558
3559         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3560         (test_untracked_files): Activating test for SVN.
3561         * Scripts/webkitpy/common/checkout/scm/svn.py:
3562         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
3563
3564 2015-12-31  Andy Estes  <aestes@apple.com>
3565
3566         Replace WTF::move with WTFMove
3567         https://bugs.webkit.org/show_bug.cgi?id=152601
3568
3569         Reviewed by Brady Eidson.
3570
3571         * DumpRenderTree/TestRunner.h:
3572         (TestRunner::setAllowedHosts):
3573         * DumpRenderTree/win/DRTDataObject.cpp:
3574         (DRTDataObject::SetData):
3575         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3576         (TestWebKitAPI::TEST):
3577         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3578         (TestWebKitAPI::TEST):
3579         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3580         (TestWebKitAPI::TEST):
3581         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
3582         (TestWebKitAPI::TEST):
3583         * TestWebKitAPI/Tests/WTF/Ref.cpp:
3584         (TestWebKitAPI::passWithRef):
3585         (TestWebKitAPI::TEST):
3586         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3587         (TestWebKitAPI::TEST):
3588         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3589         (TestWebKitAPI::TEST):
3590         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3591         (TestWebKitAPI::TEST):
3592         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3593         (TestWebKitAPI::TEST):
3594         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
3595         (TestWebKitAPI::createTestValue):
3596         (TestWebKitAPI::TEST):
3597         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3598         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3599         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
3600         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
3601         (TestWebKitAPI::createNFAs):
3602         (TestWebKitAPI::TEST_F):
3603         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
3604         (TestWebKitAPI::combine):
3605         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
3606         (TestWebKitAPI::createNFAs):
3607         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
3608         (TEST):
3609         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3610         (WebProcessTest::add):
3611
3612 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
3613
3614         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
3615         https://bugs.webkit.org/show_bug.cgi?id=152634
3616
3617         Reviewed by Carlos Garcia Campos.
3618
3619         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
3620         (testLoadFromGResource): Added test.
3621         (beforeAll):
3622         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3623         (registerGResource): Added.
3624         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
3625         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
3626         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
3627
3628 2015-12-31  David Kilzer  <ddkilzer@apple.com>
3629
3630         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
3631         <https://bugs.webkit.org/show_bug.cgi?id=152601>
3632
3633         Ignore unknown pragmas on older clangs.  Fixes the following
3634         build failure:
3635
3636             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
3637             #pragma clang diagnostic ignored "-Wself-move"
3638                                              ^
3639             1 error generated.
3640
3641         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
3642         (TestWebKitAPI::TEST):
3643         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3644         (TestWebKitAPI::TEST):
3645
3646 2015-12-31  Andy Estes  <aestes@apple.com>
3647
3648         Update the style checker to advise using WTFMove() instead of WTF::move()
3649         https://bugs.webkit.org/show_bug.cgi?id=152601
3650
3651         Reviewed by Daniel Bates.
3652
3653         * Scripts/webkitpy/style/checkers/cpp.py:
3654         (check_wtf_move):
3655         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3656         (WebKitStyleTest.test_wtf_move):
3657
3658 2015-12-31  Andy Estes  <aestes@apple.com>
3659
3660         Fix warnings uncovered by migrating to WTF_MOVE
3661         https://bugs.webkit.org/show_bug.cgi?id=152601
3662
3663         Reviewed by Daniel Bates.
3664
3665         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
3666         self-move, even if doing so would trigger a warning.
3667
3668         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
3669         (TestWebKitAPI::TEST):
3670         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3671         (TestWebKitAPI::TEST):
3672
3673 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
3674
3675         [GTK] The install-dependencies script has a syntax error
3676         https://bugs.webkit.org/show_bug.cgi?id=152613
3677
3678         Reviewed by Michael Catanzaro.
3679
3680         * gtk/install-dependencies: Add the missing 'then.'
3681
3682 2015-12-30  Philippe Normand  <pnormand@igalia.com>
3683
3684         [Mac][GTK] Jhbuild support for OSX
3685         https://bugs.webkit.org/show_bug.cgi?id=150799
3686
3687         Reviewed by Michael Catanzaro.
3688
3689         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
3690         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
3691         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
3692         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
3693
3694 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3695
3696         Unreviewed, move Sebastian Dröge to committers list
3697
3698         He accidentally added himself to the reviewers list because the file is confusing.
3699
3700         * Scripts/webkitpy/common/config/contributors.json:
3701
3702 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
3703
3704         Remove the unused #define _USE_MATH_DEFINES
3705         https://bugs.webkit.org/show_bug.cgi?id=152034
3706
3707         Reviewed by Tim Horton.
3708         
3709         Update this test to use piDouble from MathExtras.h, and
3710         std::numeric_limits<>.
3711
3712         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3713
3714 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3715
3716         Python SCM should be able to retrieve untracked files - Generic changes
3717         https://bugs.webkit.org/show_bug.cgi?id=152536
3718
3719         Reviewed by Brent Fulgham.
3720
3721         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
3722         No support is yet added to GIT and SVN specific implementations.
3723
3724         * Scripts/webkitpy/common/checkout/scm/scm.py:
3725         (SCM.untracked_files):
3726         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3727         (SCMTest._shared_test_untracked_files):
3728
3729 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
3730
3731         SVN checkout used by RunBenchmark should be non-interactive
3732         https://bugs.webkit.org/show_bug.cgi?id=152542
3733
3734         Reviewed by Ryosuke Niwa.
3735
3736         RunBenchmark should not require user interaction while running.
3737
3738         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
3739         (BenchmarkBuilder._checkout_with_subversion):
3740
3741 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
3742
3743         Web Inspector: add support for running protocol-test.js tests on Windows
3744         https://bugs.webkit.org/show_bug.cgi?id=148037
3745         <rdar://problem/22292237>
3746
3747         Reviewed by Simon Fraser.
3748
3749         * DumpRenderTree/win/TestRunnerWin.cpp:
3750         (TestRunner::inspectorTestStubURL): Provide implementation.
3751
3752 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
3753
3754         [MediaStream] MediaDeviceInfo.label must be empty in some situations
3755         https://bugs.webkit.org/show_bug.cgi?id=152000
3756
3757         Reviewed by Brent Fulgham.
3758
3759         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3760         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3761         (WTR::InjectedBundle::setUserMediaPermission):
3762         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
3763         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3764
3765         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3766         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
3767         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3768
3769         * WebKitTestRunner/TestController.cpp:
3770         (WTR::TestController::setUserMediaPermissionForOrigin):
3771         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
3772         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
3773           persistent permission for origin, that can be done from script now.
3774         * WebKitTestRunner/TestController.h:
3775
3776         * WebKitTestRunner/TestInvocation.cpp:
3777         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
3778           SetUserMediaPermissionForOrigin.
3779
3780 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
3781
3782         [Win] Unreviewed build fix: Recognize Windows 10 variants.
3783
3784         * Scripts/webkitpy/common/system/platforminfo.py:
3785         (PlatformInfo._determine_win_version):
3786
3787 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
3788
3789         Content blockers should be able to promote http to https
3790         https://bugs.webkit.org/show_bug.cgi?id=148966
3791
3792         Reviewed by Benjamin Poulain.
3793
3794         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3795         (WebCore::ContentExtensions::operator<<):
3796         (TestWebKitAPI::TEST_F):
3797
3798 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
3799
3800         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
3801         https://bugs.webkit.org/show_bug.cgi?id=152516
3802
3803         Reviewed by Gyuyoung Kim.
3804
3805         * MiniBrowser/efl/main.c:
3806
3807 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
3808
3809         Unreviewed: Add John Wilander as a contributor.
3810
3811         * Scripts/webkitpy/common/config/contributors.json:
3812
3813 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
3814
3815         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
3816         https://bugs.webkit.org/show_bug.cgi?id=152482
3817
3818         Reviewed by Brent Fulgham.
3819
3820         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
3821         for the same property. On WK2, the element returned will not be valid, but is still present and
3822         that can lead to looping.
3823
3824         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3825         (AccessibilityUIElement::horizontalScrollbar):
3826         (AccessibilityUIElement::verticalScrollbar):
3827         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3828         (WTR::AccessibilityUIElement::horizontalScrollbar):
3829         (WTR::AccessibilityUIElement::verticalScrollbar):
3830
3831 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3832
3833         Unreviewed.
3834
3835         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
3836
3837 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
3838
3839         [EFL] test_ewk2_context failed after r192808
3840         https://bugs.webkit.org/show_bug.cgi?id=151846
3841
3842         Reviewed by Gyuyoung Kim.
3843
3844         Used the added ewk_context_web_process_count_limit_set api
3845         instead of the deprecated ewk_context_process_model_set.
3846
3847         * MiniBrowser/efl/main.c:
3848         (elm_main):
3849
3850 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3851
3852         Unreviewed, move myself to reviewer list.
3853
3854         * Scripts/webkitpy/common/config/contributors.json:
3855
3856 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
3857
3858         Unreviewed, add myself to the committers list.
3859
3860         * Scripts/webkitpy/common/config/contributors.json:
3861
3862 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3863
3864         [GTK] jquery.min.js violates DFSG
3865         https://bugs.webkit.org/show_bug.cgi?id=152428
3866
3867         Reviewed by Joseph Pecoraro.
3868
3869         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
3870         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
3871
3872         * gtk/manifest.txt.in:
3873
3874 2015-12-19  Dan Bernstein  <mitz@apple.com>
3875
3876         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
3877         https://bugs.webkit.org/show_bug.cgi?id=152462
3878
3879         Reviewed by Alexey Proskuryakov.
3880
3881         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
3882           OS X 10.9:
3883
3884         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3885         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3886         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3887         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3888         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3889
3890         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
3891           never getting compiled:
3892
3893         * DumpRenderTree/mac/TextInputController.m:
3894         * MiniBrowser/mac/BrowserWindowController.m:
3895         * TestWebKitAPI/Tests/mac/AttributedString.mm:
3896         * WebKitTestRunner/mac/EventSenderProxy.mm:
3897
3898 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
3899
3900         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
3901
3902         This is to make it easy to CC it on Bugzilla.
3903
3904         * Scripts/webkitpy/common/config/contributors.json:
3905
3906 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
3907
3908         Pasteboard get messed up after running kill-old-processes
3909         https://bugs.webkit.org/show_bug.cgi?id=152426
3910
3911         Reviewed by Alexey Proskuryakov.
3912
3913         * BuildSlaveSupport/kill-old-processes:
3914         (main): Do not kill pasteboard anymore.
3915
3916 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
3917
3918         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
3919         https://bugs.webkit.org/show_bug.cgi?id=152157
3920         <rdar://problem/23851817>
3921
3922         Reviewed by Alexey Proskuryakov.
3923
3924         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3925         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
3926         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3927         (Manager._get_test_inputs): Common method to calculate test_inputs.
3928         (Manager._update_worker_count): Calculate and update required number of workers.
3929
3930 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
3931
3932         run-webkit-tests fails to delete Simulator device during cleanup
3933         https://bugs.webkit.org/show_bug.cgi?id=152363
3934
3935         Reviewed by Alexey Proskuryakov.
3936
3937         * Scripts/webkitpy/xcode/simulator.py:
3938         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
3939
3940 2015-12-16  Tim Horton  <timothy_horton@apple.com>
3941
3942         [mac-wk2] fast/events force click tests crashing
3943         https://bugs.webkit.org/show_bug.cgi?id=152339
3944
3945         Reviewed by Beth Dakin.
3946
3947         * WebKitTestRunner/mac/EventSenderProxy.mm:
3948         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
3949         Set the NSEvent's _type member in addition to overriding -type,
3950         because there are assertions in touch event handling code that depend on it.
3951
3952 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3953
3954         Enforce temporarily bots to sync WebKit and WPT testharness.js
3955         https://bugs.webkit.org/show_bug.cgi?id=152334
3956
3957         Reviewed by Darin Adler.
3958
3959         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3960         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
3961
3962 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3963
3964         [Fetch API] Add fetch API compile time flag
3965         https://bugs.webkit.org/show_bug.cgi?id=152254
3966
3967         Reviewed by Darin Adler.
3968
3969         * Scripts/webkitperl/FeatureList.pm:
3970
3971 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3972
3973         Unreviewed.
3974
3975         Added files that have impact in building Streams API to the watchlist.
3976
3977         * Scripts/webkitpy/common/config/watchlist:
3978
3979 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3980
3981         Unreviewed.
3982
3983         Added imported tests to Streams API watchlist.
3984
3985         * Scripts/webkitpy/common/config/watchlist:
3986
3987 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3988
3989         Remove default copy of wpt testharness.js when launching wpt server
3990         https://bugs.webkit.org/show_bug.cgi?id=152298
3991
3992         Reviewed by Darin Adler.
3993
3994         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3995         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
3996
3997 2015-12-15  David Kilzer  <ddkilzer@apple.com>
3998
3999         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
4000         <http://webkit.org/b/152314>
4001
4002         Reviewed by Daniel Bates.
4003
4004         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
4005         code path to exit immediately when calling main().
4006         Unfortunately, DumpRenderTreeMain.mm was used for both
4007         DumpRenderTree command-line binary and DumpRenderTree.app, which
4008         meant that the app would exit immediately with no error code
4009         when run!
4010
4011         The workaround is to introduce a separate source file called
4012         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
4013         already does.
4014
4015         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
4016         DumpRenderTreeAppMain.mm to the project.  Make it the only
4017         compiled source for the DumpRenderTree.app target.
4018         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
4019         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
4020         case someone tries mistakenly to use the app.
4021         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
4022         Link to JavaScriptCore.framework on iOS for the assert.
4023         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
4024         Link to JavaScriptCore.framework on OS X for the assert.  Remove
4025         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
4026         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
4027         (main): Add assert for iOS so that a crash occurs if someone
4028         tries to run the wrong command.
4029
4030 2015-12-14  Tim Horton  <timothy_horton@apple.com>
4031
4032         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
4033         https://bugs.webkit.org/show_bug.cgi?id=152266
4034         <rdar://problem/22092676>
4035
4036         Reviewed by Simon Fraser.
4037
4038         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4039         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
4040         Add a test that crashed before this change, and doesn't crash after.
4041
4042 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
4043
4044         AX: iOS: Text field variations do not have the correct traits
4045         https://bugs.webkit.org/show_bug.cgi?id=152237
4046
4047         Reviewed by Mario Sanchez Prada.
4048
4049         Add iOS calls for determing if an object is a search field or a text area.
4050
4051         * DumpRenderTree/AccessibilityUIElement.cpp:
4052         (getIsSearchFieldCallback):
4053         (getIsTextAreaCallback):
4054         (stringForSelectionCallback):
4055         (AccessibilityUIElement::getJSClass):
4056         * DumpRenderTree/AccessibilityUIElement.h:
4057         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4058         (AccessibilityUIElement::identifier):
4059         (AccessibilityUIElement::isTextArea):
4060         (AccessibilityUIElement::isSearchField):
4061         (AccessibilityUIElement::traits):
4062         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4063         (WTR::AccessibilityUIElement::scrollPageRight):
4064         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
4065         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
4066         (WTR::AccessibilityUIElement::isSearchField):
4067         (WTR::AccessibilityUIElement::isTextArea):
4068         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4069         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4070         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4071         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
4072         (WTR::AccessibilityUIElement::isTextArea):
4073         (WTR::AccessibilityUIElement::isSearchField):
4074         (WTR::AccessibilityUIElement::rowCount):
4075
4076 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4077
4078         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
4079         https://bugs.webkit.org/show_bug.cgi?id=152252
4080
4081         Reviewed by Sergio Villar Senin.
4082
4083         * gtk/install-dependencies: Add libtool-bin to the list of packages required
4084         for building the JHBuild on Debian systems.
4085
4086 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
4087
4088         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
4089         https://bugs.webkit.org/show_bug.cgi?id=152156
4090
4091         Reviewed by Dan Bernstein.
4092
4093         Our frameworks should appropriately prefix all ObjC classes,
4094         not just external symbols.
4095
4096         * Scripts/check-for-inappropriate-objc-class-names:
4097         Remove the -g switch to check all ObjC class names.
4098
4099 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
4100
4101         [MediaStream] Expose media capture devices persistent permissions to WebCore
4102         https://bugs.webkit.org/show_bug.cgi?id=152087
4103
4104         Add support for the new user media permission checker page UI client method.
4105
4106         Reviewed by Chris Dumez.
4107
4108         * WebKitTestRunner/TestController.cpp:
4109         (WTR::decidePolicyForUserMediaPermissionRequest):
4110         (WTR::checkUserMediaPermissionForOrigin):
4111         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
4112         (WTR::TestController::createWebViewWithOptions): Ditto.
4113         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
4114         (WTR::originUserVisibleName): New, create a string for the origin.
4115         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
4116           according to the state of the origin permission map.
4117         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
4118           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
4119         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
4120           origin permission map.
4121         * WebKitTestRunner/TestController.h:
4122
4123 2015-12-10  Alex Christensen  <achristensen@webkit.org>
4124
4125         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
4126         https://bugs.webkit.org/show_bug.cgi?id=152022
4127         rdar://problem/23763584
4128
4129         Reviewed by Darin Adler.
4130
4131         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4132         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4133         (WTR::InjectedBundlePage::willSendRequestForFrame):
4134         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4135         (WTR::TestRunner::setWillSendRequestReturnsNull):
4136         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
4137         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
4138         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
4139         (WTR::TestRunner::willSendRequestHTTPBody):
4140         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
4141
4142 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
4143
4144         Remove additional simulator checks before running layout-tests
4145         https://bugs.webkit.org/show_bug.cgi?id=152146
4146
4147         Reviewed by Darin Adler.
4148
4149         * Scripts/webkitpy/port/ios.py:
4150         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
4151         * Scripts/webkitpy/xcode/simulator.py:
4152         (Simulator._boot_and_shutdown_simulator_device): Deleted.
4153         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
4154
4155 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
4156
4157         Run atleast one simulator even if max process limit is low
4158         https://bugs.webkit.org/show_bug.cgi?id=152081
4159         <rdar://problem/23819694>
4160
4161         Reviewed by Alexey Proskuryakov.
4162
4163 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
4164
4165         [GTK] Crash in WebProcess when loading large content with custom URI schemes
4166         https://bugs.webkit.org/show_bug.cgi?id=144262
4167
4168         Reviewed by Carlos Garcia Campos.
4169
4170         Added new unit test to check the additional scenarios we now
4171         handle for custom URI schemes.
4172
4173         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
4174         (generateHTMLContent): New helper function to generate big enough content.
4175         (testWebContextURIScheme): New unit test.
4176
4177 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
4178
4179         [EFL] Fix unhandled web process message when launching MiniBrowser
4180         https://bugs.webkit.org/show_bug.cgi?id=152048
4181
4182         Reviewed by Gyuyoung Kim.
4183
4184         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
4185         (TestWebKitAPI::TEST):
4186
4187 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
4188
4189         [GTK] Add API to handle beforeunload events
4190         https://bugs.webkit.org/show_bug.cgi?id=139090
4191
4192         Reviewed by Gustavo Noronha Silva.
4193
4194         * MiniBrowser/gtk/BrowserWindow.c:
4195         (browserWindowConstructed):
4196         (browserWindowDeleteEvent):
4197         (browser_window_class_init):
4198         Handle delete-event to prevent the window from being closed when
4199         the page has beforeunload handlers. Use
4200         webkit_web_view_try_close() when the window is requested to be
4201         closed.
4202         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
4203         (testWebViewJavaScriptDialogs):
4204         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
4205         script dialog type.
4206
4207 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
4208
4209         Refactored initialization code in LoadTrackingTest.
4210
4211         Rubber-stamped by Carlos Garcia Campos.
4212
4213         Small refactoring to make sure that the state of a LoadTrackingTest
4214         gets properly reset before loading new web content.
4215
4216         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
4217         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
4218         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
4219         functions and reset the remaining local variables.
4220         (LoadTrackingTest::loadURI): Call reset();
4221         (LoadTrackingTest::loadHtml): Ditto.
4222         (LoadTrackingTest::loadPlainText): Ditto.
4223         (LoadTrackingTest::loadBytes): Ditto.
4224         (LoadTrackingTest::loadRequest): Ditto.
4225         (LoadTrackingTest::reload): Ditto.
4226         (LoadTrackingTest::goBack): Ditto.
4227         (LoadTrackingTest::goForward): Ditto.
4228
4229 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
4230
4231         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
4232         https://bugs.webkit.org/show_bug.cgi?id=151942
4233
4234         Reviewed by Darin Adler.
4235
4236         * MiniBrowser/efl/main.c:
4237         (window_create): Enable offline web application cache feature on MiniBrowser.
4238         (elm_main):
4239
4240 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
4241
4242         https://bugs.webkit.org/show_bug.cgi?id=151243
4243         <rdar://problem/22955197>
4244
4245         Reviewed by Alexey Proskuryakov.
4246
4247         * LayoutTestRelay/LayoutTestRelay/main.m:
4248         (getTestingSimDevice): Use separate testing device for each worker.
4249         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4250         (Manager.run): Perform cleanup even if setup fails.
4251         * Scripts/webkitpy/port/ios.py:
4252         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
4253         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
4254         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
4255         (IOSSimulatorPort._quit_ios_simulator): Same
4256         (IOSSimulatorPort.clean_up_test_run): Same
4257         (IOSSimulatorPort.check_sys_deps): Same
4258         (IOSSimulatorPort.testing_device): Same
4259         (IOSSimulatorPort.reset_preferences): Same
4260         (IOSSimulatorPort.get_simulator_path): Return simulator path.
4261         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
4262         * Scripts/webkitpy/xcode/simulator.py:
4263         (Device.delete): Delete the simulator device.
4264         (Simulator.delete_device): Same
4265         (Simulator.wait_until_device_is_booted): Wait for device booting.
4266
4267 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
4268
4269         [EFL] Add API to provide preferences before creating ewk_view
4270         https://bugs.webkit.org/show_bug.cgi?id=151587
4271
4272         Reviewed by Gyuyoung Kim.
4273
4274         * MiniBrowser/efl/main.c:
4275         (on_key_down):