Clicking "Go Back" from a safe browsing warning from an iframe should navigate the...
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2
3         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
4         https://bugs.webkit.org/show_bug.cgi?id=196665
5         <rdar://45115669>
6
7         Reviewed by Geoff Garen.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
10         (goBack):
11         (+[SimpleLookupContext sharedLookupContext]):
12         (-[SimpleLookupContext lookUpURL:completionHandler:]):
13         (TEST):
14         (+[Simple3LookupContext sharedLookupContext]): Deleted.
15         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
16
17 2019-04-09  John Wilander  <wilander@apple.com>
18
19         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
20         https://bugs.webkit.org/show_bug.cgi?id=196558
21         <rdar://problem/47650245>
22
23         Reviewed by Youenn Fablet.
24
25         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
26         (TestWebKitAPI::TEST):
27             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
28
29 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
30
31         [CMake] Apple builds should use ICU_INCLUDE_DIRS
32         https://bugs.webkit.org/show_bug.cgi?id=196720
33
34         Reviewed by Konstantin Tokarev.
35
36         * TestWebKitAPI/PlatformMac.cmake:
37
38 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
39
40         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
41         https://bugs.webkit.org/show_bug.cgi?id=196694
42         <rdar://problem/48388734>
43
44         Rubber-stamped by Aakash Jain.
45
46         * Scripts/webkitpy/port/image_diff.py:
47         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
48         * Scripts/webkitpy/port/server_process.py:
49         (ServerProcess.has_available_stdout): Check if stdout has data in it.
50         (ServerProcess._wait_for_data_and_update_buffers_using_select):
51         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
52         * Scripts/webkitpy/port/server_process_mock.py:
53         (MockServerProcess.has_available_stdout):
54         * Scripts/webkitpy/port/server_process_unittest.py:
55         (TestServerProcess.serial_test_basic):
56
57 2019-04-09  Jer Noble  <jer.noble@apple.com>
58
59         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
60         https://bugs.webkit.org/show_bug.cgi?id=196097
61
62         Reviewed by Eric Carlson.
63
64         Drive-by bug fix: allow tests to play audio without a user gesture by default.
65
66         * DumpRenderTree/mac/DumpRenderTree.mm:
67         (resetWebPreferencesToConsistentValues):
68         * WebKitTestRunner/TestController.cpp:
69         (WTR::TestController::resetPreferencesToConsistentValues):
70
71 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
72
73         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
74         https://bugs.webkit.org/show_bug.cgi?id=196690
75
76         Reviewed by Michael Catanzaro.
77
78         * QueueStatusServer/config/queues.py:
79         * Scripts/webkitpy/common/config/ews.json:
80         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
81         (test_ews_name):
82
83 2019-04-09  Chris Dumez  <cdumez@apple.com>
84
85         Loads using loadHTMLString() cause flashing when process-swapping
86         https://bugs.webkit.org/show_bug.cgi?id=196714
87         <rdar://problem/49637354>
88
89         Reviewed by Antti Koivisto.
90
91         Add API test coverage.
92
93         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
94
95 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
96
97         Unreviewed. Fix ATK accessibility tests after r244059.
98
99         We are failing to load the injected bundle due to undefined symbol
100         AccessibilityUIElement::replaceTextInRange().
101
102         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
103         (WTR::AccessibilityUIElement::replaceTextInRange):
104
105 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
106
107         AX: Support API: accessibilityReplaceRange:withText
108         https://bugs.webkit.org/show_bug.cgi?id=196636
109
110         Unreviewed build fix for Windows port.
111
112         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
113         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
114
115 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
116
117         [CMake][WinCairo] Separate copied headers into different directories
118         https://bugs.webkit.org/show_bug.cgi?id=196655
119
120         Reviewed by Michael Catanzaro.
121
122         * DumpRenderTree/CMakeLists.txt:
123         * MiniBrowser/win/CMakeLists.txt:
124         * TestWebKitAPI/CMakeLists.txt:
125         * TestWebKitAPI/PlatformWin.cmake:
126
127 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
128
129         Log stack-trace for run-webkit-tests when interrupted
130         https://bugs.webkit.org/show_bug.cgi?id=176393
131         <rdar://problem/34262310>
132
133         Reviewed by Lucas Forschler.
134
135         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
136         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
137         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
138         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
139         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
140         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
141         (main): Set handlers to log stack trace on interruption.
142
143 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
144
145         AX: Support API: accessibilityReplaceRange:withText
146         https://bugs.webkit.org/show_bug.cgi?id=196636
147
148         Unreviewed build fix for Windows port.
149
150         * DumpRenderTree/AccessibilityUIElement.cpp:
151         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
152
153 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
154
155         [ews-build] Scripts using Buildbot API have CORS error
156         https://bugs.webkit.org/show_bug.cgi?id=196709
157
158         Reviewed by Alexey Proskuryakov.
159
160         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
161
162 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
163
164         AX: Support API: accessibilityReplaceRange:withText
165         https://bugs.webkit.org/show_bug.cgi?id=196636
166
167         Reviewed by Daniel Bates.
168
169         * DumpRenderTree/AccessibilityUIElement.cpp:
170         (replaceTextInRangeCallback):
171         (AccessibilityUIElement::replaceTextInRange):
172         (AccessibilityUIElement::getJSClass):
173         * DumpRenderTree/AccessibilityUIElement.h:
174         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
175         (AccessibilityUIElement::replaceTextInRange):
176         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
177         (AccessibilityUIElement::replaceTextInRange):
178         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
179         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
180         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
181         (WTR::AccessibilityUIElement::replaceTextInRange):
182         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
183         (WTR::AccessibilityUIElement::replaceTextInRange):
184
185 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
186
187         [iOS] Do not allow starting selection drags when selection views are not visible
188         https://bugs.webkit.org/show_bug.cgi?id=196686
189         <rdar://problem/49399192>
190
191         Reviewed by Tim Horton.
192
193         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
194         also add some new API tests to cover scenarios where the web view is not first responder.
195
196         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
197         (TestWebKitAPI::TEST):
198         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
199
200         Add a switch to optionally make the web view first responder when starting the simulated drag.
201
202         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
203         (-[DragAndDropSimulator initWithWebView:]):
204         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
205
206 2019-04-08  Justin Fan  <justin_fan@apple.com>
207
208         [Web GPU] Fix Web GPU experimental feature on iOS
209         https://bugs.webkit.org/show_bug.cgi?id=196632
210
211         Reviewed by Myles C. Maxfield.
212
213         Properly make Web GPU available on iOS 11+.
214
215         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
216
217 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
218
219         [ews-build] Do not upload archive when Compile Fails
220         https://bugs.webkit.org/show_bug.cgi?id=196674
221
222         Reviewed by Alexey Proskuryakov.
223
224         * BuildSlaveSupport/ews-build/factories.py:
225         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
226         * BuildSlaveSupport/ews-build/steps.py:
227         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
228         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
229         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
230
231 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
232
233         Enable DFG on MIPS
234         https://bugs.webkit.org/show_bug.cgi?id=196689
235
236         Reviewed by Žan Doberšek.
237
238         Since the bytecode change, we enabled the baseline JIT on mips in
239         r240432, but DFG is still missing. With this change, all tests are
240         passing on a ci20 board.
241
242         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
243
244 2019-04-08  Philippe Normand  <pnormand@igalia.com>
245
246         [Flatpak] Second run update-webkitwpe-flatpak fails
247         https://bugs.webkit.org/show_bug.cgi?id=192702
248
249         Reviewed by Carlos Garcia Campos.
250
251         * flatpak/flatpakutils.py:
252         (FlatpakObject.flatpak): Fix typo.
253         (FlatpakPackage.install): When installing, also update to the configured remote commit.
254         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
255
256 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
257
258         [GTK][WPE] outlook.live.com displays old-fashioned UI
259         https://bugs.webkit.org/show_bug.cgi?id=196642
260
261         Reviewed by Carlos Garcia Campos.
262
263         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
264         (TestWebKitAPI::TEST): New Mac platform quirk test.
265
266 2019-04-07  Commit Queue  <commit-queue@webkit.org>
267
268         Unreviewed, rolling out r243956.
269         https://bugs.webkit.org/show_bug.cgi?id=196688
270
271         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
272         by aakashjain on #webkit).
273
274         Reverted changeset:
275
276         "Clicking "Go Back" from a safe browsing warning from an
277         iframe should navigate the WKWebView back to the previous
278         page"
279         https://bugs.webkit.org/show_bug.cgi?id=196665
280         https://trac.webkit.org/changeset/243956
281
282 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
283
284         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
285         https://bugs.webkit.org/show_bug.cgi?id=196669
286
287         Reviewed by Geoffrey Garen.
288
289         Added three new unit tests for WeakHashSet.
290
291         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
292         (WTF_WeakPtr.WeakHashSetConstObjects):
293         (WTF_WeakPtr.WeakHashSetComputesEmpty):
294         (WTF_WeakPtr.WeakHashSetComputeSize):
295
296 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
297
298         Hide next and previous form control buttons when WKWebView is editable
299         https://bugs.webkit.org/show_bug.cgi?id=196672
300         <rdar://problem/35625321>
301
302         Reviewed by Tim Horton.
303
304         Add a new API test.
305
306         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
307         (-[TestWKWebView lastTrailingBarButtonGroup]):
308         (TestWebKitAPI::TEST):
309         * TestWebKitAPI/ios/UIKitSPI.h:
310
311 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
312
313         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
314         https://bugs.webkit.org/show_bug.cgi?id=196077
315         <rdar://problem/49108202>
316
317         Reviewed by Chris Dumez.
318
319         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
320         on new web view.
321
322         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
323
324 2019-04-05  Saam Barati  <sbarati@apple.com>
325
326         Make compare-results understand MotionMark
327         https://bugs.webkit.org/show_bug.cgi?id=196666
328
329         Reviewed by Yusuke Suzuki.
330
331         * Scripts/compare-results:
332         (PLT5Results):
333         (detectMotionMark):
334         (detectMotionMark1_1):
335         (motionMarkResults):
336         (motionMark1_1Results):
337         (detectBenchmark):
338         (biggerIsBetter):
339         (main):
340
341 2019-04-05  Alex Christensen  <achristensen@webkit.org>
342
343         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
344         https://bugs.webkit.org/show_bug.cgi?id=196665
345         <rdar://45115669>
346
347         Reviewed by Geoff Garen.
348
349         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
350         (goBack):
351         (+[SimpleLookupContext sharedLookupContext]):
352         (-[SimpleLookupContext lookUpURL:completionHandler:]):
353         (TEST):
354         (+[Simple3LookupContext sharedLookupContext]): Deleted.
355         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
356
357 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
358
359         [ews-build] Add configuration and architecture for windows builders
360         https://bugs.webkit.org/show_bug.cgi?id=196660
361
362         Reviewed by Lucas Forschler.
363
364         * BuildSlaveSupport/ews-build/config.json:
365
366 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
367
368         webkitpy: Don't run subsequent rounds if interrupted
369         https://bugs.webkit.org/show_bug.cgi?id=196646
370
371         Reviewed by Aakash Jain.
372
373         * Scripts/webkitpy/layout_tests/controllers/manager.py:
374         (Manager.run): Bail out if interrupted.
375
376 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
377
378         Test sessionStorage in PSON private browsing mode
379         https://bugs.webkit.org/show_bug.cgi?id=196561
380
381         Reviewed by Alex Christensen.
382
383         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
384
385 2019-04-05  Commit Queue  <commit-queue@webkit.org>
386
387         Unreviewed, rolling out r243833.
388         https://bugs.webkit.org/show_bug.cgi?id=196645
389
390         This change breaks build of WPE and GTK ports (Requested by
391         annulen on #webkit).
392
393         Reverted changeset:
394
395         "[CMake][WTF] Mirror XCode header directories"
396         https://bugs.webkit.org/show_bug.cgi?id=191662
397         https://trac.webkit.org/changeset/243833
398
399 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
400
401         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
402         https://bugs.webkit.org/show_bug.cgi?id=196635
403
404         Reviewed by Antti Koivisto.
405         
406         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
407         for a test to enable async frame scrolling via:
408             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
409         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
410         
411         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
412
413         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
414         (WTR::InjectedBundle::beginTesting):
415         * WebKitTestRunner/TestController.cpp:
416         (WTR::TestController::resetPreferencesToConsistentValues):
417
418 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
419
420         Use a correct LC_RPATH when building with ASan
421         https://bugs.webkit.org/show_bug.cgi?id=196576
422
423         Reviewed by David Kilzer.
424
425         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
426         so that ../Frameworks is checked. This is simpler and more reliable than updating
427         each SPC service xcconfig.
428
429 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
430
431         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
432         https://bugs.webkit.org/show_bug.cgi?id=196629
433
434         Reviewed by Lucas Forschler.
435
436         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
437
438 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
439
440         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
441         https://bugs.webkit.org/show_bug.cgi?id=196618
442
443         Reviewed by Lucas Forschler.
444
445         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
446         (StatusBubble): Added QUEUE_TRIGGERS.
447         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
448         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
449         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
450         its parent(builder).
451
452 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
453
454         [ews-app] Status-bubble steps are sometimes displayed in reverse order
455         https://bugs.webkit.org/show_bug.cgi?id=196625
456
457         Reviewed by Lucas Forschler.
458
459         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
460         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
461
462 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
463
464         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
465         https://bugs.webkit.org/show_bug.cgi?id=196630
466
467         Reviewed by Wenson Hsieh.
468
469         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
470
471 2019-04-04  Youenn Fablet  <youenn@apple.com>
472
473         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
474         https://bugs.webkit.org/show_bug.cgi?id=196543
475
476         Reviewed by Alex Christensen.
477
478         * WebKitTestRunner/TestController.cpp:
479         (WTR::TestController::generatePageConfiguration):
480
481 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
482
483         [ews-app] Status bubble should not display skipped buildbot steps
484         https://bugs.webkit.org/show_bug.cgi?id=196584
485
486         Reviewed by Lucas Forschler.
487
488         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
489
490 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
491
492         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
493         https://bugs.webkit.org/show_bug.cgi?id=196620
494
495         Reviewed by Lucas Forschler.
496
497         * BuildSlaveSupport/ews-app/ews/config.py:
498
499 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
500
501         [Win] DumpRenderTreeWatchDog.py is not checked into source
502         https://bugs.webkit.org/show_bug.cgi?id=196567
503         <rdar://problem/49525901>
504
505         Reviewed by Lucas Forschler.
506
507         This script is used on Win EWS bots to terminate hanging DRT processes.
508
509         * EWSTools/dumprendertreewatchdog.py: Added.
510
511 2019-04-04  Chris Dumez  <cdumez@apple.com>
512
513         Unreviewed, roll out r243858 which made tests time out.
514
515         Disable new API tests on Windows instead.
516
517         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
518         (TestWebKitAPI::TEST):
519
520 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
521
522         [ATK] Cleanup WebPageAccessibilityObjectAtk
523         https://bugs.webkit.org/show_bug.cgi?id=196537
524
525         Reviewed by Michael Catanzaro.
526
527         Also consider files under atk directories as exceptions for GObject conventions.
528
529         * Scripts/webkitpy/style/checkers/cpp.py:
530         (check_identifier_name_in_declaration):
531
532 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
533
534         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
535         https://bugs.webkit.org/show_bug.cgi?id=196588
536         <rdar://problem/49365787>
537
538         Unreviewed build fix for Windows port.
539
540         error C3861: 'kill': identifier not found
541
542         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
543         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
544
545 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
546
547         [ews-build] Cancel build and similar operations should have authentication
548         https://bugs.webkit.org/show_bug.cgi?id=196520
549
550         Reviewed by Dewei Zhu.
551
552         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
553         environment variables.
554
555 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
556
557         [ews-build] Do not trigger queues which are not in production yet
558         https://bugs.webkit.org/show_bug.cgi?id=196581
559
560         Reviewed by Dewei Zhu.
561
562         * BuildSlaveSupport/ews-build/config.json:
563
564 2019-04-03  Chris Dumez  <cdumez@apple.com>
565
566         Unreviewed, fix typo in the name of API test added in r243848.
567
568         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
569         (TestWebKitAPI::TEST):
570
571 2019-04-03  Chris Dumez  <cdumez@apple.com>
572
573         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
574         https://bugs.webkit.org/show_bug.cgi?id=196588
575         <rdar://problem/49365787>
576
577         Reviewed by Ryosuke Niwa.
578
579         Add API test coverage.
580
581         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
582         (TestWebKitAPI::nullJavaScriptCallback):
583         (TestWebKitAPI::didCrashCheckFrames):
584         (TestWebKitAPI::TEST):
585
586 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
587
588         run-webkit-tests: Upload test results (new results database)
589         https://bugs.webkit.org/show_bug.cgi?id=196577
590         <rdar://problem/34841155>
591
592         Reviewed by Lucas Forschler.
593
594         * Scripts/webkitpy/layout_tests/controllers/manager.py:
595         (Manager.run): Upload results after each device shard, since the configuration will be
596         different for each device.
597         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
598         uploaded to a results database.
599         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
600         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
601
602 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
603
604         -apple-trailing-word is needed for browser detection
605         https://bugs.webkit.org/show_bug.cgi?id=196575
606
607         Unreviewed.
608
609         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
610
611 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
612
613         [CMake][WTF] Mirror XCode header directories
614         https://bugs.webkit.org/show_bug.cgi?id=191662
615
616         Reviewed by Konstantin Tokarev.
617
618         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
619         builds.
620
621         * CMakeLists.txt:
622         * DumpRenderTree/CMakeLists.txt:
623         * DumpRenderTree/PlatformWin.cmake:
624         * MiniBrowser/win/CMakeLists.txt:
625         * TestWebKitAPI/CMakeLists.txt:
626         * TestWebKitAPI/PlatformWin.cmake:
627         * WebKitTestRunner/PlatformGTK.cmake:
628         * WebKitTestRunner/PlatformWin.cmake:
629
630 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
631
632         [ews-app] Status bubble should not display certain infrastructure status messages
633         https://bugs.webkit.org/show_bug.cgi?id=196550
634
635         Reviewed by Lucas Forschler.
636
637         Do not display the steps which are un-needed for end-user. This information is still avaiable
638         if the user click on the bubble and look at the Buildbot build.
639         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
640         (StatusBubble._steps_messages):
641         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
642
643 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
644
645         [ews-build] Use https for sending data to ews-app
646         https://bugs.webkit.org/show_bug.cgi?id=196492
647
648         Reviewed by Lucas Forschler.
649
650         * BuildSlaveSupport/ews-build/events.py:
651
652 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
653
654         Remove support for -apple-trailing-word
655         https://bugs.webkit.org/show_bug.cgi?id=196525
656
657         Reviewed by Zalan Bujtas.
658
659         This CSS property is nonstandard and not used.
660
661         * Scripts/webkitperl/FeatureList.pm:
662         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
663
664 2019-04-03  Youenn Fablet  <youenn@apple.com>
665
666         Add a test for DOMCache on multiple browsing in case of private browsing
667         https://bugs.webkit.org/show_bug.cgi?id=196524
668
669         Reviewed by Alex Christensen.
670
671         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
672         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
673
674 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
675
676         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
677         https://bugs.webkit.org/show_bug.cgi?id=196540
678
679         Reviewed by Aakash Jain.
680
681         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
682
683 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
684
685         Add plumbing for a compatibility mode preference in WebKit
686         https://bugs.webkit.org/show_bug.cgi?id=196005
687
688         Reviewed by Tim Horton.
689
690         Add new API tests.
691
692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
693         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
694
695 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
696
697         [WPE][GTK] Update libsrtp dependency package for Debian
698         https://bugs.webkit.org/show_bug.cgi?id=196528
699
700         Reviewed by Frédéric Wang.
701
702         * gtk/install-dependencies:
703         * wpe/install-dependencies:
704
705 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
706
707         [WK2] Add support for Window's beforeprint / afterprint events
708         https://bugs.webkit.org/show_bug.cgi?id=196478
709         <rdar://problem/49535124>
710
711         Unreviewed build fix for MSVC.
712
713         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
714
715         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
716
717         * WebKitTestRunner/TestController.cpp:
718         (WTR::printFrame): Use int and float literals.
719
720 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
721
722         [ews-build] Reassign bots to queues
723
724         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
725
726 2019-04-02  Chris Dumez  <cdumez@apple.com>
727
728         [WK2] Add support for Window's beforeprint / afterprint events
729         https://bugs.webkit.org/show_bug.cgi?id=196478
730
731         Reviewed by Alex Christensen.
732
733         Add minimal implementation for printFrame in WebKitTestRunner.
734
735         * WebKitTestRunner/TestController.cpp:
736         (WTR::printFrame):
737         (WTR::TestController::createOtherPage):
738         (WTR::TestController::createWebViewWithOptions):
739
740 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
741
742         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
743         https://bugs.webkit.org/show_bug.cgi?id=196491
744
745         Reviewed by Lucas Forschler.
746
747         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
748
749 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
750
751         [ews-build] Configure buildbot try credentials in environment variables
752         https://bugs.webkit.org/show_bug.cgi?id=196501
753
754         Reviewed by Lucas Forschler.
755
756         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
757         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
758         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
759
760 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
761
762         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
763         https://bugs.webkit.org/show_bug.cgi?id=196496
764         <rdar://problem/49521634>
765
766         Reviewed by Chris Dumez.
767
768         Add new API tests (see WebKit ChangeLog for more detail).
769
770         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
771         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
772         (TEST):
773
774 2019-04-02  David Kilzer  <ddkilzer@apple.com>
775
776         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
777         <https://webkit.org/b/196499>
778
779         Reviewed by Alexey Proskuryakov.
780
781         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
782         ENABLE_ADDRESS_SANITIZER.
783
784 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
785
786         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
787         https://bugs.webkit.org/show_bug.cgi?id=182757
788
789         Reviewed by Don Olmstead.
790
791         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
792         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
793
794 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
795
796         run-api-tests: Upload test results
797         https://bugs.webkit.org/show_bug.cgi?id=196323
798         <rdar://problem/49356714>
799
800         Reviewed by Lucas Forschler.
801
802         * Scripts/webkitpy/api_tests/manager.py:
803         (Manager):
804         (Manager.run): Upload results to a results database.
805         * Scripts/webkitpy/api_tests/run_api_tests.py:
806         (parse_args): Add upload arguments.
807         * Scripts/webkitpy/port/base.py:
808         (Port):
809         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
810         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
811         with commits from any other associated repositories.
812         * Scripts/webkitpy/port/device.py:
813         (Device):
814         (Device.build_version): Access build_versoin of underlying platform device.
815         * Scripts/webkitpy/port/ios_simulator_unittest.py:
816         (IOSSimulatorTest):
817         (IOSSimulatorTest.test_configuration_for_upload):
818         * Scripts/webkitpy/port/device_port.py:
819         (DevicePort):
820         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
821         the same as the machine uploading results.
822         * Scripts/webkitpy/port/mac.py:
823         (MacPort):
824         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
825         * Scripts/webkitpy/port/mac_unittest.py:
826         (MacTest):
827         (MacTest.test_configuration_for_upload):
828         * Scripts/webkitpy/xcode/simulated_device.py:
829         (SimulatedDeviceManager._create_device_with_runtime):
830         (SimulatedDevice.__init__): Create simulated device with a build_version.
831         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
832         (test_existing_simulator):
833
834 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
835
836         Remove extra newline characters (Follow-up fix to r243707)
837
838         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
839
840 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
841
842         [ews-app] Use API_KEY to accept results data
843         https://bugs.webkit.org/show_bug.cgi?id=196461
844
845         Reviewed by Dewei Zhu.
846
847         * BuildSlaveSupport/ews-app/ews/views/results.py:
848         (Results.post): Validate EWS_API_KEY before accepting any data.
849         * BuildSlaveSupport/ews-build/events.py:
850         (Events.sendData): Send EWS_API_KEY if available along with event data.
851
852 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
853
854         Unable to copy and paste a PDF from Notes into Mail compose body
855         https://bugs.webkit.org/show_bug.cgi?id=196442
856         <rdar://problem/48573098>
857
858         Reviewed by Tim Horton.
859
860         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
861         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
862         to be specified on the item providers.
863
864         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
865         (TestWebKitAPI::mapItemForTesting):
866         (TestWebKitAPI::contactItemForTesting):
867
868 2019-04-01  Tim Horton  <timothy_horton@apple.com>
869
870         Make UIWKDocumentContext rects per-character instead of per-word
871         https://bugs.webkit.org/show_bug.cgi?id=196459
872
873         Reviewed by Wenson Hsieh.
874
875         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
876         (TEST):
877         Adjust test results due to switching to per-character rects.
878
879 2019-04-01  Chris Dumez  <cdumez@apple.com>
880
881         UIProcess crash when a prewarmed process is terminated
882         https://bugs.webkit.org/show_bug.cgi?id=196451
883         <rdar://problem/49245471>
884
885         Reviewed by Geoffrey Garen.
886
887         Add API test coverage.
888
889         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
890         (TEST):
891
892 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
893
894         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
895         https://bugs.webkit.org/show_bug.cgi?id=196449
896
897         Reviewed by Lucas Forschler.
898
899         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
900         (StatusBubble.get_os_details): Method to get OS and Xcode details.
901         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
902         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
903
904 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
905
906         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
907         https://bugs.webkit.org/show_bug.cgi?id=196444
908
909         Reviewed by Lucas Forschler.
910
911         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
912
913 2019-04-01  Alex Christensen  <achristensen@webkit.org>
914
915         Add SPI to canonicalize NSURLs with WTF::URL
916         https://bugs.webkit.org/show_bug.cgi?id=196415
917         <rdar://problem/44980271>
918
919         Reviewed by Darin Adler.
920
921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
922         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
923         (TestWebKitAPI::TEST):
924
925 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
926
927         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
928         https://bugs.webkit.org/show_bug.cgi?id=196441
929
930         Reviewed by Carlos Garcia Campos.
931
932         Don't cache the wpe_view_backend object that might not exist yet at the
933         time of EventSenderProxy constructor invocation, but instead retrieve
934         that object whenever it's required for event dispatching. This should
935         avoid crashes in this constructor now that it's invoked before any
936         PlatformWindow has been set up (as changed in r243496).
937
938         * WebKitTestRunner/EventSenderProxy.h:
939         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
940         (WTR::viewBackend):
941         (WTR::EventSenderProxy::EventSenderProxy):
942         (WTR::EventSenderProxy::mouseDown):
943         (WTR::EventSenderProxy::mouseUp):
944         (WTR::EventSenderProxy::mouseMoveTo):
945         (WTR::EventSenderProxy::mouseScrollBy):
946         (WTR::EventSenderProxy::keyDown):
947         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
948
949 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
950
951         [Win][WebKit] MiniBrowser should support high DPI display
952         https://bugs.webkit.org/show_bug.cgi?id=196391
953
954         Reviewed by Alex Christensen.
955
956         * MiniBrowser/win/WebKitBrowserWindow.cpp:
957         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
958         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
959         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
960
961 2019-03-31  Sam Weinig  <weinig@apple.com>
962
963         Remove more i386 specific configurations
964         https://bugs.webkit.org/show_bug.cgi?id=196430
965
966         Reviewed by Alexey Proskuryakov.
967
968         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
969         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
970
971 2019-03-31  Andy Estes  <aestes@apple.com>
972
973         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
974         https://bugs.webkit.org/show_bug.cgi?id=196433
975         <rdar://problem/49293305>
976
977         Reviewed by Tim Horton.
978
979         Enhanced API test coverage to include all navigation response policy decisions in both
980         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
981
982         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
983         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
984         (TestWebKitAPI::TEST):
985         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
986         (readFile):
987         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
988         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
989         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
990         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
991         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
992         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
993         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
994         (-[QuickLookDelegate _downloadDidStart:]):
995         (-[QuickLookDelegate _download:didReceiveResponse:]):
996         (-[QuickLookDelegate _download:didReceiveData:]):
997         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
998         (-[QuickLookDelegate _downloadDidFinish:]):
999         (-[QuickLookDelegate _download:didFailWithError:]):
1000         (-[QuickLookDelegate _downloadDidCancel:]):
1001         (-[QuickLookDelegate verifyDownload]):
1002         (runTest):
1003         (runTestDecideBeforeLoading):
1004         (runTestDecideAfterLoading):
1005         (TEST):
1006         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1007         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1008         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1009         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1010         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1011         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1012         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1013         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1014         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1015         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1016         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1017         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1018         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1019         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1020
1021 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1022
1023         [CMake] add testdfg as target with build-jsc
1024         https://bugs.webkit.org/show_bug.cgi?id=196393
1025
1026         Reviewed by Saam Barati.
1027
1028         Added testdfg as one of the targets to build when
1029         using CMake.
1030
1031         * Scripts/build-jsc:
1032
1033 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1034
1035         Delete WebMetal implementation in favor of WebGPU
1036         https://bugs.webkit.org/show_bug.cgi?id=195418
1037
1038         Reviewed by Dean Jackson.
1039
1040         * DumpRenderTree/mac/DumpRenderTree.mm:
1041         (enableExperimentalFeatures):
1042         (resetWebPreferencesToConsistentValues):
1043         * Scripts/webkitperl/FeatureList.pm:
1044         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1045         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1046         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1047         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1048         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1049         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1050         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1051         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1052         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1053         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1054         (WTR::InjectedBundle::beginTesting):
1055         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1056         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1057         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1058
1059 2019-03-29  Chris Dumez  <cdumez@apple.com>
1060
1061         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1062         https://bugs.webkit.org/show_bug.cgi?id=196405
1063         <rdar://problem/49428130>
1064
1065         Reviewed by Wenson Hsieh.
1066
1067         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1068         the popover presentation methods to be no-ops. Use this in the new test added in
1069         r243523 so that we do not swizzle those methods for all tests. This is needed because
1070         those WatchOS tests rely on the popover getting presented and interactive.
1071
1072         * WebKitTestRunner/TestController.cpp:
1073         (WTR::updateTestOptionsFromTestHeader):
1074         * WebKitTestRunner/TestController.h:
1075         * WebKitTestRunner/TestOptions.h:
1076         (WTR::TestOptions::hasSameInitializationOptions const):
1077         * WebKitTestRunner/ios/TestControllerIOS.mm:
1078         (WTR::TestController::platformInitialize):
1079         (WTR::TestController::platformResetStateToConsistentValues):
1080
1081 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1082
1083         [Curl] Add Server Trust Evaluation Support.
1084         https://bugs.webkit.org/show_bug.cgi?id=191646
1085
1086         Reviewed by Fujii Hironori.
1087
1088         Implemented MiniBrowser UI for asking if user trusts the server.
1089
1090         * MiniBrowser/win/Common.cpp:
1091         (askServerTrustEvaluation):
1092         (replaceString):
1093         * MiniBrowser/win/Common.h:
1094         * MiniBrowser/win/MiniBrowserLib.rc:
1095         * MiniBrowser/win/MiniBrowserLibResource.h:
1096         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1097         (createPEMString):
1098         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1099         (WebKitBrowserWindow::canTrustServerCertificate):
1100         * MiniBrowser/win/WebKitBrowserWindow.h:
1101
1102 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1103
1104         Implement ResizeObserver.
1105         https://bugs.webkit.org/show_bug.cgi?id=157743
1106
1107         Reviewed by Simon Fraser.
1108
1109         Support resizeObserverEnabled webPreferences.
1110
1111         * DumpRenderTree/TestOptions.cpp:
1112         (TestOptions::TestOptions):
1113         * DumpRenderTree/TestOptions.h:
1114         * DumpRenderTree/mac/DumpRenderTree.mm:
1115         (setWebPreferencesForTestOptions):
1116         * DumpRenderTree/win/DumpRenderTree.cpp:
1117         (enableExperimentalFeatures):
1118         * Scripts/webkitperl/FeatureList.pm:
1119         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1120
1121 2019-03-28  John Wilander  <wilander@apple.com>
1122
1123         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1124         https://bugs.webkit.org/show_bug.cgi?id=196281
1125         <rdar://problem/48938748>
1126
1127         Reviewed by Alex Christensen.
1128
1129         This patch adds the function isStatisticsHasLocalStorage() to the
1130         TestRunner. With it, the page can query the WebsiteDataStore in the
1131         UI process to make sure that it sees LocalStorage.
1132
1133         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1134         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1135         (WTR::TestRunner::isStatisticsHasLocalStorage):
1136         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1137         * WebKitTestRunner/TestController.cpp:
1138         (WTR::TestController::isStatisticsHasLocalStorage):
1139         * WebKitTestRunner/TestController.h:
1140         * WebKitTestRunner/TestInvocation.cpp:
1141         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1142
1143 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1144
1145         API::Data::createWithoutCopying should do a null check before calling CFRelease
1146         https://bugs.webkit.org/show_bug.cgi?id=196276
1147         <rdar://problem/48059859>
1148
1149         Reviewed by Alex Christensen.
1150
1151         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1152
1153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1154         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1155         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1156         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1157         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1158         (TestWebKitAPI::TEST):
1159
1160 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1161
1162         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1163         https://bugs.webkit.org/show_bug.cgi?id=186276
1164
1165         Reviewed by Carlos Garcia Campos.
1166
1167         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1168         (webViewLoadChanged):
1169         (testWebResourceGetDataError):
1170         (testWebResourceGetDataEmpty):
1171         (beforeAll):
1172         (webViewloadChanged): Deleted.
1173
1174 2019-03-27  Andy Estes  <aestes@apple.com>
1175
1176         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1177         https://bugs.webkit.org/show_bug.cgi?id=196317
1178
1179         Reviewed by Dan Bernstein.
1180
1181         package-root copies built products into a staging directory using ditto(1), which does not
1182         follow symbolic links as it traverses a directory. Now that the files in
1183         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1184         itself, these become broken links when ditto'd into the staging directory.
1185
1186         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1187
1188         * Scripts/package-root:
1189
1190 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1191
1192         [ews-app] Update display text of Submit for ews analysis
1193         https://bugs.webkit.org/show_bug.cgi?id=196309
1194
1195         Reviewed by Dewei Zhu.
1196
1197         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1198
1199 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1200
1201         run-webkit-tests should check for leaks in WebKit processes
1202         <https://webkit.org/b/193772>
1203         <rdar://problem/46526680>
1204
1205         Reviewed by Ryosuke Niwa.
1206
1207         This works by doing the following:
1208         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1209           The list of child processes are returned one per line:
1210           process.name: pid
1211         - Run the "#LIST CHILD PROCESSES" command just before the
1212           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1213           processes on the ServerProcess object.
1214         - When the `--leaks` switch is handled, run check_for_leaks() on
1215           each child process after the main test harness.
1216
1217         * DumpRenderTree/mac/DumpRenderTree.mm:
1218         (handleControlCommand):
1219         - Use strncmp() instead of strcmp().
1220         - Add support for handling "#LIST CHILD PROCESSES" command.
1221
1222         * Scripts/webkitpy/port/base.py:
1223         (Port.check_for_leaks):
1224         * Scripts/webkitpy/port/darwin.py:
1225         (DarwinPort.check_for_leaks):
1226         - Rename redundant 'process_pid' argument to 'process_id'.
1227
1228         * Scripts/webkitpy/port/driver.py:
1229         (Driver.do_post_tests_work):
1230         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1231           longer the only command this sends to WebKitTestRunner.
1232         - If the `--leaks` switch is present, send the
1233           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1234           result using Port.set_webkit_processes().
1235         (Driver._parse_child_processes_output):
1236         - Add helper method to parse list of child process names and
1237           process IDs returned from WebKitTestRunner.
1238
1239         * Scripts/webkitpy/port/ios_device.py:
1240         (IOSDevicePort.check_for_leaks):
1241         - Rename redundant 'process_pid' argument to 'process_id'.
1242
1243         * Scripts/webkitpy/port/leakdetector.py:
1244         (LeakDetector._parse_leaks_output):
1245         - Return early if there is no leaks_output.
1246         (LeakDetector.check_for_leaks):
1247         - Rename redundant 'process_pid' argument to 'process_id'.
1248
1249         * Scripts/webkitpy/port/server_process.py:
1250         (ServerProcess.__init__):
1251         (ServerProcess.child_processes):
1252         (ServerProcess.set_child_processes):
1253         - Add instance variable to Port to store list of child process
1254           names and process IDs returned from WebKitTestRunner.
1255         (ServerProcess._start):
1256         - Clear self._child_processes.
1257         (ServerProcess.stop):
1258         - If self._child_processes is set, call
1259           self._port.check_for_leaks() for each child process.
1260
1261         * Scripts/webkitpy/port/server_process_unittest.py:
1262         (TrivialMockPort.check_for_leaks):
1263         - Rename redundant 'process_pid' argument to 'process_id'.
1264
1265         * Scripts/webkitpy/port/simulator_process.py:
1266         (SimulatorProcess.stop):
1267         - If self._child_processes is set, call
1268           self._port.check_for_leaks() for each child process.
1269
1270         * Scripts/webkitpy/port/watch_device.py:
1271         (WatchDevicePort.check_for_leaks):
1272         - Rename redundant 'process_pid' argument to 'process_id'.
1273
1274         * WebKitTestRunner/TestController.cpp:
1275         (WTR::TestController::dumpResponse):
1276         - Extract method from findAndDumpWorldLeaks() so that it may be
1277           reused by findAndDumpWebKitProcessIdentifiers().
1278         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1279         - Add method to output process name and process ID of both the
1280           WebContent and Networking processes.
1281         (WTR::TestController::findAndDumpWorldLeaks):
1282         - Fix missing newline in output when there were no abandoned
1283           documents.
1284         - Call dumpResponse() for extracted code.
1285         (WTR::TestController::handleControlCommand):
1286         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1287         - Use strncmp() instead of strcmp().
1288         - Call findAndDumpWebKitProcessIdentifiers() when
1289           "#LIST CHILD PROCESSES" command is sent.
1290         * WebKitTestRunner/TestController.h:
1291         (WTR::TestController::dumpResponse):
1292         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1293         - Declare methods.
1294
1295 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1296
1297         Unreviewed. Add GLib API test cases after r243434.
1298
1299         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1300         (testWebViewActiveURI):
1301         (serverCallback):
1302         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1303         (sendRequestCallback):
1304
1305 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1306
1307         Geolocation request not complete when watch request was started in a different web process
1308         https://bugs.webkit.org/show_bug.cgi?id=195996
1309
1310         Reviewed by Alex Christensen.
1311
1312         Add a test case.
1313
1314         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1315         (TestWebKitAPI::runJavaScriptAlert):
1316         (TestWebKitAPI::TEST):
1317
1318 2019-03-26  Keith Rollin  <krollin@apple.com>
1319
1320         Update the way generate-xcfilelists returns strings from functions
1321         https://bugs.webkit.org/show_bug.cgi?id=195975
1322         <rdar://problem/49040807>
1323
1324         Reviewed by Dean Jackson.
1325
1326         There are places where generate-xcfilelists executes assignments with
1327         statements like:
1328
1329             FOO=$(some_function)
1330
1331         where "some_function" return a string by echoing it. E.g.
1332
1333             some_function()
1334             {
1335                 echo "Hello, World"
1336             }
1337
1338         This is a common idiom, but it has a problem if "some_function" needs
1339         to call "exit" in an attempt to halt the entire script right then and
1340         there. Since "some_function" is called inside of $(), it's being
1341         executed in a sub-shell. Calling exit in that sub-shell simply exits
1342         that shell; it doesn't not exit the outer shell in which the main part
1343         of the script is still running. As such, the main script keeps
1344         executing when the intent was for the script to halt.
1345
1346         The solution to this is to use a different idiom for returning
1347         strings. The one we now is to pass in the name of the variable to
1348         receive the string result:
1349
1350             some_function()
1351             {
1352                 variable_name=$1
1353                 eval $variable_name ="Hello, World"
1354             }
1355
1356         The call site now looks like
1357
1358             some_function FOO
1359
1360         Because there's no invocation of a sub-shell, some_function can now
1361         call "exit" if it wants to, and the entire script will exit at that
1362         point.
1363
1364         * Scripts/generate-xcfilelists:
1365
1366 2019-03-26  Chris Dumez  <cdumez@apple.com>
1367
1368         Add basic layout test coverage for File Picker on iOS
1369         https://bugs.webkit.org/show_bug.cgi?id=196265
1370
1371         Reviewed by Wenson Hsieh.
1372
1373         Add layout test infrastructure to test the file picker on iOS.
1374
1375         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1376         (WTR::UIScriptController::dismissFilePicker):
1377         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1378         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1379         (WTR::UIScriptController::dismissFilePicker):
1380         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1381         * WebKitTestRunner/TestController.cpp:
1382         (WTR::TestController::createWebViewWithOptions):
1383         (WTR::updateTestOptionsFromTestHeader):
1384         * WebKitTestRunner/TestOptions.h:
1385         (WTR::TestOptions::hasSameInitializationOptions const):
1386         * WebKitTestRunner/ios/TestControllerIOS.mm:
1387         (overridePresentViewController):
1388         (WTR::TestController::platformInitialize):
1389         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1390         (WTR::UIScriptController::dismissFilePicker):
1391
1392 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1393
1394         Implement async paste method on UIWKInteractionViewProtocol
1395         https://bugs.webkit.org/show_bug.cgi?id=196267
1396         <rdar://problem/49236346>
1397
1398         Reviewed by Tim Horton.
1399
1400         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1401         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1402         are now a part of all iOS 12 internal SDKs.
1403
1404         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1405
1406         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1407         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1408
1409         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1410         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1411         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1412         * TestWebKitAPI/ios/UIKitSPI.h:
1413
1414 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1415
1416         [ews-build] Use PostgreSQL for ews.webkit.org database
1417         https://bugs.webkit.org/show_bug.cgi?id=196270
1418
1419         Reviewed by Lucas Forschler.
1420
1421         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1422
1423 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1424
1425         [ews] Reset simctl states on reboot
1426         https://bugs.webkit.org/show_bug.cgi?id=196260
1427
1428         Rubber-stamped by Aakash Jain.
1429
1430         * EWSTools/start-queue-mac.sh:
1431
1432 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1433
1434         [ews-build] Use PostgreSQL for ews-build database
1435         https://bugs.webkit.org/show_bug.cgi?id=196229
1436
1437         Reviewed by Lucas Forschler.
1438
1439         * BuildSlaveSupport/ews-build/master.cfg:
1440
1441 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1442
1443         [ews-build] Get master_hostname dynamically in master.cfg
1444         https://bugs.webkit.org/show_bug.cgi?id=196255
1445
1446         Reviewed by Lucas Forschler.
1447
1448         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1449         send events data in test mode.
1450
1451 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1452
1453         [ews-app] Set db_constraint to False for Foreign Keys
1454         https://bugs.webkit.org/show_bug.cgi?id=196252
1455
1456         Reviewed by Lucas Forschler.
1457
1458         * BuildSlaveSupport/ews-app/ews/models/build.py:
1459         * BuildSlaveSupport/ews-app/ews/models/step.py:
1460
1461 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1462
1463         [ews-build] is_test_mode_enabled should default to True
1464         https://bugs.webkit.org/show_bug.cgi?id=196248
1465
1466         Reviewed by Lucas Forschler.
1467
1468         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1469
1470 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1471
1472         [ews-app] Add webkitperl to ENABLED_QUEUES
1473         https://bugs.webkit.org/show_bug.cgi?id=196253
1474
1475         Reviewed by Lucas Forschler.
1476
1477         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1478
1479 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1480
1481         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1482         https://bugs.webkit.org/show_bug.cgi?id=196211
1483         rdar://problem/49110552
1484
1485         Reviewed by Tim Horton.
1486
1487         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1488         Make sure that EventSenderProxy always exists when running tests. We used to create
1489         it when resetting before the first test, which is a bit too late.
1490
1491         * WebKitTestRunner/TestController.h:
1492         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1493         (WTR::TestController::platformCreateWebView):
1494         (WTR::TestController::platformCreateOtherPage):
1495         (WTR::TestController::finishCreatingPlatformWebView):
1496         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1497         (WTR::PlatformWebView::PlatformWebView):
1498         Moved some code that made NSWindow use NSEvent during web view creation. We may
1499         need to move more if some other case us found, but this is enough for now.
1500
1501 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1502
1503         Unreviewed. Fix typo in GLib geolocation API after r243285.
1504
1505         gelocation -> geolocation.
1506
1507         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1508         (testGeolocationManagerWatchPosition):
1509
1510 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1511
1512         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1513         https://bugs.webkit.org/show_bug.cgi?id=196213
1514
1515         Reviewed by Geoff Garen.
1516
1517         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1518         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1519         (credentialWithIdentityAndKeychainPath):
1520         (-[ChallengeDelegate webView:didFinishNavigation:]):
1521         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1522         (TestWebKitAPI::TEST):
1523
1524 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1525
1526         Expected shouldn't assume its contained types are copyable
1527         https://bugs.webkit.org/show_bug.cgi?id=195986
1528
1529         Reviewed by JF Bastien.
1530
1531         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1532         (TestWebKitAPI::NonCopyable::operator== const):
1533         (TestWebKitAPI::NonCopyable::operator!= const):
1534         (TestWebKitAPI::TEST):
1535
1536 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1537
1538         Remove some now-unnecessary dynamic class lookup
1539         https://bugs.webkit.org/show_bug.cgi?id=196237
1540
1541         Reviewed by Simon Fraser.
1542
1543         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1544         (makeRequest):
1545         (TEST):
1546
1547 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1548
1549         Unreviewed, rolling out r243450.
1550
1551         AppleWin and WinCairo port builds get broken.
1552
1553         Reverted changeset:
1554
1555         "Add test for fix of #196095"
1556         https://bugs.webkit.org/show_bug.cgi?id=196097
1557         https://trac.webkit.org/changeset/243450
1558
1559 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1560
1561         Unreviewed, rolling out r243465.
1562         https://bugs.webkit.org/show_bug.cgi?id=196226
1563
1564         the test doesn't build (Requested by thorton on #webkit).
1565
1566         Reverted changeset:
1567
1568         "Do not terminate the NetworkProcess if a third party
1569         application sends a NSCredential with a SecIdentityRef"
1570         https://bugs.webkit.org/show_bug.cgi?id=196213
1571         https://trac.webkit.org/changeset/243465
1572
1573 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1574
1575         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1576         https://bugs.webkit.org/show_bug.cgi?id=196213
1577
1578         Reviewed by Geoff Garen.
1579
1580         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1581         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1582         (credentialWithIdentityAndKeychainPath):
1583         (-[ChallengeDelegate webView:didFinishNavigation:]):
1584         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1585         (TestWebKitAPI::TEST):
1586
1587 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1588
1589         [ews-build] Gracefully handle missing patch_id in events
1590         https://bugs.webkit.org/show_bug.cgi?id=196216
1591
1592         Reviewed by Lucas Forschler.
1593
1594         * BuildSlaveSupport/ews-build/events.py:
1595
1596 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1597
1598         [ews-build] use lz4 compression for improving buildbot performance
1599         https://bugs.webkit.org/show_bug.cgi?id=196155
1600
1601         Reviewed by Lucas Forschler.
1602
1603         * BuildSlaveSupport/ews-build/master.cfg:
1604
1605 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1606
1607         Pull some API testing helper methods out of TestWKWebView
1608         https://bugs.webkit.org/show_bug.cgi?id=196212
1609
1610         Reviewed by Tim Horton.
1611
1612         Refactor some more API testing utility methods, so that they can be used in
1613         tests that do not use TestWKWebView.
1614
1615         * TestWebKitAPI/cocoa/TestWKWebView.h:
1616         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1617         (-[WKWebView loadTestPageNamed:]):
1618         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1619         (-[WKWebView synchronouslyLoadHTMLString:]):
1620         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1621         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1622         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1623         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1624         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1625
1626 2019-03-25  Jer Noble  <jer.noble@apple.com>
1627
1628         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1629         https://bugs.webkit.org/show_bug.cgi?id=196097
1630
1631         Reviewed by Eric Carlson.
1632
1633         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1634
1635         * DumpRenderTree/mac/DumpRenderTree.mm:
1636         (resetWebPreferencesToConsistentValues):
1637         * WebKitTestRunner/TestController.cpp:
1638         (WTR::TestController::resetPreferencesToConsistentValues):
1639
1640 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1641
1642         Pull IPadUserInterfaceSwizzler out into a separate header file
1643         https://bugs.webkit.org/show_bug.cgi?id=196193
1644
1645         Reviewed by Anders Carlsson.
1646
1647         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1648         be used in other API tests.
1649
1650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1651         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1652         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1653         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1654         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1655         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1656         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1657
1658 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1659
1660         Remove NavigatorContentUtils in WebCore/Modules
1661         https://bugs.webkit.org/show_bug.cgi?id=196070
1662
1663         Reviewed by Alex Christensen.
1664
1665         NavigatorContentUtils was to support the custom scheme spec [1].
1666         However, in WebKit side, no port has supported the feature in
1667         WebKit layer after EFL port was removed. So there has been the
1668         only IDL implementation of the NavigatorContentUtils in WebCore.
1669         So we don't need to keep the implementation in WebCore anymore.
1670
1671         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1672
1673         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1674
1675 2019-03-24  Andy Estes  <aestes@apple.com>
1676
1677         [watchOS] Remove unused Proximity Networking code
1678         https://bugs.webkit.org/show_bug.cgi?id=196188
1679
1680         Reviewed by Tim Horton.
1681
1682         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1683         (TEST):
1684
1685 2019-03-23  Keith Miller  <keith_miller@apple.com>
1686
1687         Refactor clz/ctz and fix getLSBSet.
1688         https://bugs.webkit.org/show_bug.cgi?id=196162
1689
1690         Reviewed by Saam Barati.
1691
1692         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1693
1694         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1695         (TestWebKitAPI::TEST):
1696
1697 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1698
1699         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1700         https://bugs.webkit.org/show_bug.cgi?id=196143
1701
1702         Reviewed by Michael Catanzaro.
1703
1704         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1705         directories.
1706
1707         * Scripts/webkitpy/style/checkers/cpp.py:
1708         (check_identifier_name_in_declaration):
1709         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1710         (WebKitStyleTest.test_names):
1711
1712 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1713
1714         [Flatpak] Manifest expanding fails for qt WPE extension
1715         https://bugs.webkit.org/show_bug.cgi?id=196148
1716
1717         Reviewed by Alex Christensen.
1718
1719         * flatpak/flatpakutils.py:
1720         (expand_submodules_recurse): The last recurse manifest expand
1721         iteration might lead to a single module so take it into account
1722         and don't try to recurse further.
1723
1724 2019-03-22  Chris Dumez  <cdumez@apple.com>
1725
1726         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1727         https://bugs.webkit.org/show_bug.cgi?id=195348
1728         <rdar://problem/48622090>
1729
1730         Reviewed by Alex Christensen.
1731
1732         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1733         to NO when test.options().shouldIgnoreMetaViewport is false.
1734
1735         * WebKitTestRunner/ios/TestControllerIOS.mm:
1736         (WTR::TestController::platformConfigureViewForTest):
1737
1738 2019-03-22  Chris Dumez  <cdumez@apple.com>
1739
1740         Prewarmed processes should be usable with any website data store
1741         https://bugs.webkit.org/show_bug.cgi?id=196104
1742
1743         Reviewed by Alex Christensen.
1744
1745         Add API test coverage.
1746
1747         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1748         (runInitialWarmedProcessUsedTest):
1749         (TEST):
1750
1751 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1752
1753         Back out local changes to Alex's Subversion working directory
1754
1755         They were accidentally committed.
1756
1757         * Scripts/webkitpy/common/system/abstractexecutive.py:
1758         (AbstractExecutive.wait_newest):
1759         * Scripts/webkitpy/common/system/executive.py:
1760         (Executive.running_pids):
1761         * Scripts/webkitpy/common/system/executive_mock.py:
1762         (MockExecutive.running_pids):
1763         * Scripts/webkitpy/common/system/executive_unittest.py:
1764         (ExecutiveTest.serial_test_running_pids):
1765         * Scripts/webkitpy/port/darwin.py:
1766         (DarwinPort.check_for_leaks):
1767         * Scripts/webkitpy/port/leakdetector.py:
1768         (LeakDetector.check_for_leaks):
1769         - This was the hack attached to Bug 193772.
1770
1771         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1772         (+[WebKitTestRunnerEvent mouseLocation]):
1773         - This works around a crash on an internal build.
1774
1775 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1776
1777         Fix the build after r243354
1778         https://bugs.webkit.org/show_bug.cgi?id=196138
1779         <rdar://problem/49145951>
1780
1781         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1782         (TEST):
1783         * TestWebKitAPI/ios/UIKitSPI.h:
1784
1785 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1786
1787         Adopt UIWKDocumentContext
1788         https://bugs.webkit.org/show_bug.cgi?id=196040
1789         <rdar://problem/48642440>
1790
1791         Reviewed by Ryosuke Niwa.
1792
1793         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1794         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1795         (makeRequest):
1796         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1797         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1798         (applyStyle):
1799         (TEST):
1800         Add tests for UIWKDocumentContext.
1801
1802         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1803         (TEST):
1804         (recursiveFindWKContentView): Deleted.
1805         * TestWebKitAPI/cocoa/TestWKWebView.h:
1806         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1807         (recursiveFindWKContentView):
1808         (-[TestWKWebView wkContentView]):
1809         * TestWebKitAPI/ios/UIKitSPI.h:
1810         Share the WKContentView finding code between tests.
1811
1812 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1813
1814         [iOS WK2] Turn on async overflow scrolling by default
1815         https://bugs.webkit.org/show_bug.cgi?id=196011
1816         rdar://problem/48453859
1817
1818         Reviewed by Antti Koivisto.
1819         
1820         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1821         since so many basic layout tests have different results when compositing is triggered for
1822         overflow.
1823         
1824         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1825
1826         * WebKitTestRunner/TestController.cpp:
1827         (WTR::TestController::resetPreferencesToConsistentValues):
1828
1829 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1830
1831         [ews-build] Retry API test in case of failures
1832         https://bugs.webkit.org/show_bug.cgi?id=196004
1833
1834         Reviewed by Lucas Forschler.
1835
1836         * BuildSlaveSupport/ews-build/steps.py:
1837         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1838         (CompileWebKitToT.doStepIf): Ditto.
1839         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1840         (ReRunAPITests): Re-run API tests.
1841         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1842         (RunAPITestsWithoutPatch): Run API tests without patch.
1843         (RunAPITestsWithoutPatch.doStepIf):
1844         (RunAPITestsWithoutPatch.hideStepIf):
1845         (RunAPITestsWithoutPatch.evaluateCommand):
1846         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1847         (AnalyzeAPITestsResults.start):
1848         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1849         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1850         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1851         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1852
1853 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1854
1855         [ews-build] Update queues configurations
1856         https://bugs.webkit.org/show_bug.cgi?id=196074
1857
1858         Reviewed by Dewei Zhu.
1859
1860         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1861         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1862
1863 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1864
1865         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1866         https://bugs.webkit.org/show_bug.cgi?id=195680
1867         <rdar://problem/48903534>
1868
1869         Unreviewed infrastructure fix.
1870
1871         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1872         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1873
1874 2019-03-21  Andy Estes  <aestes@apple.com>
1875
1876         [iOS] Apple Pay should be available in documents with no user agent scripts
1877         https://bugs.webkit.org/show_bug.cgi?id=196061
1878         <rdar://problem/48649391>
1879
1880         Reviewed by Brady Eidson.
1881
1882         Added API tests and related infrastructure.
1883
1884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1885         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1886         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1887         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1888         (TestWebKitAPI::TEST):
1889         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1890         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1891         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1892         * TestWebKitAPI/cocoa/TestProtocol.mm:
1893         (-[TestProtocol startLoading]):
1894         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1895         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1896         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1897         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1898
1899 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1900
1901         REGRESSSION (r243297): webkitpy tests broken
1902         https://bugs.webkit.org/show_bug.cgi?id=196108
1903
1904         Reviewed by Aakash Jain.
1905
1906         r243297 updated contributors.json, which broke a few unit tests.
1907
1908         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1909         (IRCCommandTest.test_whois):
1910         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1911
1912 2019-03-21  Chris Dumez  <cdumez@apple.com>
1913
1914         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1915         https://bugs.webkit.org/show_bug.cgi?id=196041
1916         <rdar://problem/49083230>
1917
1918         Reviewed by Alex Christensen.
1919
1920         Add API test coverage.
1921
1922         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1923         (TEST):
1924
1925 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1926
1927         Add SPI to inform applications of WKContentRuleList actions
1928         https://bugs.webkit.org/show_bug.cgi?id=195965
1929         <rdar://problem/42664365>
1930
1931         Reviewed by Geoff Garen.
1932
1933         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1934         (TestWebKitAPI::allActionsForResourceLoad):
1935         (TestWebKitAPI::testRequest):
1936         (TestWebKitAPI::TEST_F):
1937         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1938         (Notification::description):
1939         (Notification::operator== const):
1940         (toVector):
1941         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1942         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1943         (makeContentRuleList):
1944         (TEST):
1945         (makeWarnContentRuleList): Deleted.
1946
1947 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1948
1949         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1950         https://bugs.webkit.org/show_bug.cgi?id=196088
1951
1952         Reviewed by Brian Burg.
1953
1954         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1955         Support checks when only one platform is specified. Also deprecate macosx() and
1956         force the use of macos() instead.
1957
1958         * Scripts/webkitpy/style/checkers/cpp.py:
1959         (check_min_versions_of_wk_api_available):
1960         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1961         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1962
1963 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1964
1965         Update status inactive committers' status to 'contributor'.
1966
1967         * Scripts/webkitpy/common/config/contributors.json:
1968
1969 2019-03-21  Xan Lopez  <xan@igalia.com>
1970
1971         [JSC][x86] Drop support for x87 floating point
1972         https://bugs.webkit.org/show_bug.cgi?id=194853
1973
1974         Reviewed by Don Olmstead.
1975
1976         Force SSE2 on x86/32bit builds.
1977
1978         * Scripts/webkitdirs.pm:
1979         (generateBuildSystemFromCMakeProject):
1980
1981 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1982
1983         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1984         https://bugs.webkit.org/show_bug.cgi?id=196073
1985
1986         Reviewed by Michael Catanzaro.
1987
1988         Add test cases to check functions and constructors with no arguments but receiving user data.
1989
1990         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1991         (checkUserData):
1992         (testJSCFunction):
1993         (fooCreateWithUserData):
1994         (testJSCClass):
1995
1996 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1997
1998         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1999
2000         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2001
2002         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2003
2004 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2005
2006         [GTK][WPE] Add API to provide geolocation information
2007         https://bugs.webkit.org/show_bug.cgi?id=195940
2008
2009         Reviewed by Michael Catanzaro.
2010
2011         Add a new test to check the new API.
2012
2013         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2014         (testGeolocationManagerCurrentPosition):
2015         (testGeolocationManagerWatchPosition):
2016         (beforeAll):
2017         (afterAll):
2018         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2019         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2020         (beforeAll): Ditto.
2021         * TestWebKitAPI/glib/CMakeLists.txt:
2022
2023 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2024
2025         [GLib] Returning G_TYPE_OBJECT from a method does not work
2026         https://bugs.webkit.org/show_bug.cgi?id=195574
2027
2028         Reviewed by Michael Catanzaro.
2029
2030         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2031
2032         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2033         (getGFile):
2034         (getParent):
2035         (createGString):
2036         (getGString):
2037         (getGStringCopyWillRaise):
2038         (getGStringCopy):
2039         (getGStringStr):
2040         (getGStringLen):
2041         (freeGString):
2042         (testJSCClass):
2043
2044 2019-03-20  Saam Barati  <sbarati@apple.com>
2045
2046         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2047         https://bugs.webkit.org/show_bug.cgi?id=195721
2048
2049         Reviewed by Filip Pizlo.
2050
2051         * Scripts/run-javascriptcore-tests:
2052
2053 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2054
2055         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2056         https://bugs.webkit.org/show_bug.cgi?id=196049
2057
2058         Reviewed by Tim Horton.
2059
2060         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2061         overflow scrolling in general, so rename it.
2062
2063         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2064
2065 2019-03-20  Daniel Bates  <dabates@apple.com>
2066
2067         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2068         https://bugs.webkit.org/show_bug.cgi?id=196031
2069         <rdar://problem/49078172>
2070
2071         Reviewed by Tim Horton.
2072
2073         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2074         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2075         same code path used when the Done button is pressed to dismiss the <select> picker.
2076
2077         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2078         (TestWebKitAPI::TEST):
2079
2080 2019-03-20  Chris Dumez  <cdumez@apple.com>
2081
2082         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2083         https://bugs.webkit.org/show_bug.cgi?id=196029
2084         <rdar://problem/48954651>
2085
2086         Reviewed by Tim Horton.
2087
2088         Add API test coverage.
2089
2090         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2091
2092 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2093
2094         [ews-build] Improve failure summary string for ApplyPatch step
2095         https://bugs.webkit.org/show_bug.cgi?id=195995
2096
2097         Reviewed by Alexey Proskuryakov.
2098
2099         * BuildSlaveSupport/ews-build/steps.py:
2100         (ApplyPatch.getResultSummary): Override getResultSummary.
2101
2102 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2103
2104         AX: Implement support for new meter ARIA role
2105         https://bugs.webkit.org/show_bug.cgi?id=195966
2106
2107         Reviewed by Chris Fleizach.
2108
2109         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2110         to AXLevelIndicator.
2111
2112         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2113
2114 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2115
2116         [WebAuthN] Implement FIDO AppID extension
2117         https://bugs.webkit.org/show_bug.cgi?id=143491
2118         <rdar://problem/48298273>
2119
2120         Reviewed by Brent Fulgham.
2121
2122         Add a test that covers the new flag of convertToU2fSignCommand.
2123
2124         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2125         (TestWebKitAPI::TEST):
2126         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2127         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2128         (TestWebKitAPI::TEST):
2129
2130 2019-03-19  Keith Rollin  <krollin@apple.com>
2131
2132         Add support for more platforms to generate-xcfilelists
2133         https://bugs.webkit.org/show_bug.cgi?id=195977
2134
2135         Reviewed by Alexey Proskuryakov.
2136
2137         generate-xcfilelists incorrectly complains when involved with building
2138         WebKit for iphonesimulator:
2139
2140             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2141             …
2142             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2143
2144         Address this by teaching generate-xcfilelists about more platforms.
2145
2146         * Scripts/generate-xcfilelists:
2147
2148 2019-03-19  John Wilander  <wilander@apple.com>
2149
2150         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2151         https://bugs.webkit.org/show_bug.cgi?id=195923
2152         <rdar://problem/49001272>
2153
2154         Reviewed by Alex Christensen.
2155
2156         This patch does the following to the TestRunner:
2157         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2158         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2159         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2160
2161         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2162         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2163         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2164         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2165         * WebKitTestRunner/TestController.cpp:
2166         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2167         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2168         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2169         * WebKitTestRunner/TestController.h:
2170         * WebKitTestRunner/TestInvocation.cpp:
2171         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2172
2173 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2174
2175         [CMake] Support more clang and gcc sanitizers
2176         https://bugs.webkit.org/show_bug.cgi?id=195956
2177
2178         Reviewed by Michael Catanzaro.
2179
2180         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2181
2182 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2183
2184         [ews-build] Improve summary for PrintConfiguration step
2185         https://bugs.webkit.org/show_bug.cgi?id=195945
2186
2187         Reviewed by Lucas Forschler.
2188
2189         * BuildSlaveSupport/ews-build/steps.py:
2190         (PrintConfiguration.getResultSummary): Override getResultSummary.
2191
2192 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2193
2194         [ews-build] Improve summary for CheckOutSource step
2195         https://bugs.webkit.org/show_bug.cgi?id=195963
2196
2197         Reviewed by Lucas Forschler.
2198
2199         * BuildSlaveSupport/ews-build/steps.py:
2200         (CheckOutSource.getResultSummary):
2201
2202 2019-03-19  Daniel Bates  <dabates@apple.com>
2203
2204         [iOS] Focus not preserved when switching between tabs
2205         https://bugs.webkit.org/show_bug.cgi?id=195820
2206         <rdar://problem/43614450>
2207
2208         Reviewed by Brent Fulgham.
2209
2210         Add tests to ensure that we restore focus when resigning and becoming first responder.
2211
2212         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2213         (TestWebKitAPI::TEST):
2214
2215 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2216
2217         Make WTFLogChannelState and WTFLogLevel enum classes
2218         https://bugs.webkit.org/show_bug.cgi?id=195904
2219
2220         Reviewed by Eric Carlson.
2221
2222         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2223         (TestWebKitAPI::TEST_F):
2224
2225 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2226
2227         [GStreamer][EME] Backported mssdemux protection data crash fix
2228         https://bugs.webkit.org/show_bug.cgi?id=195918
2229
2230         Reviewed by Philippe Normand.
2231
2232         * gstreamer/jhbuild.modules:
2233         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2234
2235 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2236
2237         Unreviewed, rolling out r243132.
2238
2239         Broke GTK build
2240
2241         Reverted changeset:
2242
2243         "Make WTFLogChannelState and WTFLogLevel enum classes"
2244         https://bugs.webkit.org/show_bug.cgi?id=195904
2245         https://trac.webkit.org/changeset/243132
2246
2247 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2248
2249         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2250
2251         * Scripts/webkitdirs.pm:
2252         (builtDylibPathForName): Adjust the shared library name that's changed
2253         with the API version bump in r243073.
2254
2255 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2256
2257         Make WTFLogChannelState and WTFLogLevel enum classes
2258         https://bugs.webkit.org/show_bug.cgi?id=195904
2259
2260         Reviewed by Eric Carlson.
2261
2262         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2263         (TestWebKitAPI::TEST_F):
2264
2265 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2266
2267         Disable flaky test added in r2431100
2268         https://webkit.org/b/195785
2269
2270         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2271         (TestWebKitAPI::TEST):
2272         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2273
2274 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2275
2276         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2277         https://bugs.webkit.org/show_bug.cgi?id=195916
2278
2279         Reviewed by Tim Horton.
2280
2281         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2282         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2283
2284 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2285
2286         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2287
2288         * Scripts/webkitpy/common/config/contributors.json:
2289
2290 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2291
2292         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2293         https://bugs.webkit.org/show_bug.cgi?id=195785
2294
2295         Reviewed by Geoffrey Garen.
2296
2297         * TestWebKitAPI/TCPServer.cpp: Added.
2298         (TestWebKitAPI::TCPServer::TCPServer):
2299         (TestWebKitAPI::TCPServer::~TCPServer):
2300         (TestWebKitAPI::TCPServer::socketBindListen):
2301         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2302         * TestWebKitAPI/TCPServer.h: Added.
2303         (TestWebKitAPI::TCPServer::port const):
2304         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2305         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2306         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2307         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2308         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2309         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2310         (TestWebKitAPI::respondSlowly):
2311         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2312         (TestWebKitAPI::downloadAtRate):
2313         (TestWebKitAPI::TEST):
2314
2315 2019-03-18  Saam Barati  <sbarati@apple.com>
2316
2317         Add a plan file for JetStream 2
2318         https://bugs.webkit.org/show_bug.cgi?id=190734
2319
2320         Reviewed by Mark Lam.
2321
2322         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2323
2324 2019-03-18  Chris Dumez  <cdumez@apple.com>
2325
2326         Delay WebProcess launch until a load is triggered in a Web view
2327         https://bugs.webkit.org/show_bug.cgi?id=195758
2328         <rdar://problem/48126013>
2329
2330         Reviewed by Geoff Garen.
2331
2332         Add API test coverage. Also update some existing API tests to not expect
2333         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2334
2335         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2336         (TestWebKitAPI::TEST):
2337         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2338         (TestWebKitAPI::TEST):
2339         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2340         (TEST):
2341         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2342         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2343         (TEST):
2344         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2345         (TEST):
2346         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2347
2348 2019-03-18  Xan Lopez  <xan@igalia.com>
2349
2350         [CMake] Prevent potential warning when determining $architecture
2351         https://bugs.webkit.org/show_bug.cgi?id=195891
2352
2353         Reviewed by Michael Catanzaro.
2354
2355         It's possible for generateBuildSystemForCMakeProject to be called
2356         before determineArchitecture() is ever called. This will make the
2357         first eq check with $architecture to be bogus (and print a
2358         warning). Change that to an eq check with architecture(), which
2359         implicitly calls determineArchitecture() if needed, and change all
2360         the other similar cases in the method in the same way to prevent
2361         future bugs like this one.
2362
2363         * Scripts/webkitdirs.pm:
2364         (generateBuildSystemFromCMakeProject):
2365
2366 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2367
2368         [WPE] Tarballs generated with “make dist” cannot build documentation
2369         https://bugs.webkit.org/show_bug.cgi?id=195885
2370
2371         Reviewed by Carlos Garcia Campos.
2372
2373         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2374
2375 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2376
2377         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2378         https://bugs.webkit.org/show_bug.cgi?id=195883
2379
2380         Reviewed by Carlos Garcia Campos.
2381
2382         * gtkdoc/gtkdoc.py:
2383         (GTKDoc._run_command): When commands fail to run, include the full command line for
2384         the program invocation and the output it has generated on the standard error stream.
2385
2386 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2387
2388         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2389         https://bugs.webkit.org/show_bug.cgi?id=195786
2390
2391         Reviewed by Philippe Normand.
2392
2393         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2394         * wpe/jhbuild.modules: Ditto.
2395
2396 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2397
2398         [ews-build] Don't run clean builds on EWS builders
2399         https://bugs.webkit.org/show_bug.cgi?id=195851
2400
2401         Reviewed by Geoffrey Garen.
2402
2403         * BuildSlaveSupport/ews-build/factories.py:
2404
2405 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2406
2407         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2408         https://bugs.webkit.org/show_bug.cgi?id=195849
2409
2410         Reviewed by Chris Dumez.
2411
2412         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2413
2414         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2415         (runWebsiteDataStoreCustomPaths):
2416
2417 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2418
2419         webkitpy: Upload test results
2420         https://bugs.webkit.org/show_bug.cgi?id=195755
2421         <rdar://problem/48896182>
2422
2423         Reviewed by Aakash Jain.
2424
2425         Establish a new format for uploading results that is not tied to layout tests, apply
2426         that format to webkitpy tests.
2427
2428         * Scripts/webkitpy/common/checkout/scm/git.py:
2429         (Git.native_branch): Return what branch the current checkout is on.
2430         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2431         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2432         * Scripts/webkitpy/common/checkout/scm/svn.py:
2433         (SVN.native_branch): Ditto.
2434         * Scripts/webkitpy/common/system/platforminfo.py:
2435         (PlatformInfo.build_version): Return a build version for Mac.
2436         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2437         (MockPlatformInfo.__init__):
2438         (MockPlatformInfo.build_version):
2439         * Scripts/webkitpy/results: Added.
2440         * Scripts/webkitpy/results/__init__.py: Added.
2441         * Scripts/webkitpy/results/options.py: Added.
2442         (upload_options): OptParse list for upload options.
2443         * Scripts/webkitpy/results/upload.py: Added.
2444         (Upload): Class which enforces the upload format expected by the results server.
2445         (Upload.Expectations):
2446         (Upload.create_configuration):
2447         (Upload.create_commit):
2448         (Upload.create_details):
2449         (Upload.create_run_stats):
2450         (Upload.create_test_result):
2451         (Upload.__init__):
2452         (Upload.Encoder): Encode Upload object as json.
2453         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2454         * Scripts/webkitpy/results/upload_unittest.py: Added.
2455         * Scripts/webkitpy/test/main.py:
2456         (Tester._parse_args): Add upload arguments.
2457         (Tester._run_tests): Allow results to be uploaded.
2458         * Scripts/webkitpy/test/runner.py:
2459         (Runner.__init__): Record which tests were run, rather than just counting them.
2460         (Runner.handle):
2461         * Scripts/webkitpy/test/runner_unittest.py:
2462         (RunnerTest.test_run):
2463         * Scripts/webkitpy/thirdparty/__init__.py:
2464         (AutoinstallImportHook.find_module): Add requests auto-install.
2465         (AutoinstallImportHook._install_requests):
2466         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2467         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2468
2469 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2470
2471         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2472         https://bugs.webkit.org/show_bug.cgi?id=195810
2473
2474         Reviewed by Tim Horton.
2475
2476         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2477         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2478         ending certain layout tests.
2479
2480         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2481         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2482         (-[TestRunnerWKWebView dealloc]):
2483         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2484
2485         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2486         helper method when destroying the web view, and when resetting state between tests.
2487
2488         * WebKitTestRunner/ios/TestControllerIOS.mm:
2489         (WTR::TestController::platformResetStateToConsistentValues):
2490
2491         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2492
2493 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2494
2495         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2496         https://bugs.webkit.org/show_bug.cgi?id=190350
2497         <rdar://problem/45089503>
2498
2499         Reviewed by Geoffrey Garen.
2500
2501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2502         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2503         (TEST):
2504         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2505         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2506         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2507         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2508         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2509         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2510         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2511         (runTest):
2512         (createDirectories):
2513         (TEST):
2514         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2515         (TEST):
2516         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2517         (TEST):
2518
2519 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2520
2521         Add support to WebPage for getting the contents as an attributed string.
2522         https://bugs.webkit.org/show_bug.cgi?id=195636
2523         rdar://problem/45055697
2524
2525         Reviewed by Tim Horton.
2526
2527         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2528         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2529
2530 2019-03-15  Chris Dumez  <cdumez@apple.com>
2531
2532         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2533         https://bugs.webkit.org/show_bug.cgi?id=195747
2534
2535         Reviewed by Geoff Garen.
2536
2537         Add API test coverage.
2538
2539         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2540
2541 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2542
2543         Unreviewed, rolling out r242952.
2544
2545         Causing API failures on iOS Simulator
2546
2547         Reverted changeset:
2548
2549         "[PSON] Make sure the WebProcessCache is leverage when
2550         relaunching a process after termination"
2551         https://bugs.webkit.org/show_bug.cgi?id=195747
2552         https://trac.webkit.org/changeset/242952
2553
2554 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2555
2556         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2557         https://bugs.webkit.org/show_bug.cgi?id=195740
2558
2559         Reviewed by Ross Kirsling.
2560
2561         window.open doesn't work for WebKitBrowserWindow because it is not
2562         implemented yet.
2563
2564         1. Implemented createNewPage callback of WKPageUIClient.
2565         2. Changed MainWindow to take a BrowserWindow factory function
2566           instead of BrowserWindowType to be flexible to create
2567           BrowserWindow with extra settings.
2568         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2569           because it is not relevant with MainWindow anymore.
2570
2571         * MiniBrowser/win/Common.cpp:
2572         (parseCommandLine):
2573         * MiniBrowser/win/Common.h:
2574         (CommandLineOptions::CommandLineOptions):
2575         * MiniBrowser/win/MainWindow.cpp:
2576         (MainWindow::MainWindow):
2577         (MainWindow::create):
2578         (MainWindow::init):
2579         (MainWindow::WndProc):
2580         * MiniBrowser/win/MainWindow.h:
2581         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2582         (PrintWebUIDelegate::createWebViewWithRequest):
2583         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2584         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2585         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2586         (WebKitBrowserWindow::updateProxySettings):
2587         (WebKitBrowserWindow::createNewPage):
2588         * MiniBrowser/win/WebKitBrowserWindow.h:
2589         * MiniBrowser/win/WinMain.cpp:
2590         (wWinMain):
2591
2592 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2593
2594         Make it possible to test scrolling tree layer manipulation more easily
2595         https://bugs.webkit.org/show_bug.cgi?id=195780
2596
2597         Reviewed by Tim Horton.
2598         
2599         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2600         cuts off communication of scrolling tree scrolls back to the web process
2601         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2602         allows tests to trigger scrolls which run the scrolling tree layer positioning
2603         logic, but never get another commit from the web process that might mask
2604         scrolling tree bugs.
2605         
2606         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2607         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2608         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2609
2610         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2611         (WTR::UIScriptController::scrollUpdatesDisabled const):
2612         (WTR::UIScriptController::setScrollUpdatesDisabled):
2613         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2614         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2615         (WTR::UIScriptController::scrollUpdatesDisabled const):
2616         (WTR::UIScriptController::setScrollUpdatesDisabled):
2617         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2618         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2619         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2620         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2621         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2622         * WebKitTestRunner/ios/TestControllerIOS.mm:
2623         (WTR::TestController::platformResetStateToConsistentValues):
2624         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2625         (WTR::UIScriptController::scrollUpdatesDisabled const):
2626         (WTR::UIScriptController::setScrollUpdatesDisabled):
2627
2628 2019-03-14  Youenn Fablet  <youenn@apple.com>
2629
2630         Move IDB storage in private browsing mode to NetworkProcess
2631         https://bugs.webkit.org/show_bug.cgi?id=195602
2632
2633         Reviewed by Brady Eidson.
2634
2635         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2636         (TEST):
2637
2638 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2639
2640         [ews-build] Make descriptionDone messages more readable
2641         https://bugs.webkit.org/show_bug.cgi?id=195760
2642
2643         Reviewed by Lucas Forschler.
2644
2645         * BuildSlaveSupport/ews-build/steps.py:
2646         * BuildSlaveSupport/ews-build/steps_unittest.py:
2647
2648 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2649
2650         [ews-build] Generate status-bubble hover-over messages
2651         https://bugs.webkit.org/show_bug.cgi?id=195680
2652
2653         Reviewed by Lucas Forschler.
2654
2655         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2656         (StatusBubble):
2657         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2658         on hover-over.
2659         (StatusBubble._iso_time):
2660         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2661         hover-over message.
2662         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2663
2664 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2665
2666         [ews-app] Gracefully handle the case when state_string is None
2667         https://bugs.webkit.org/show_bug.cgi?id=195753
2668
2669         Reviewed by Lucas Forschler.
2670
2671         * BuildSlaveSupport/ews-app/ews/models/build.py:
2672         * BuildSlaveSupport/ews-app/ews/models/step.py:
2673
2674 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2675
2676         [ews-app] Status bubble display pending for currently running build step
2677         https://bugs.webkit.org/show_bug.cgi?id=195744
2678
2679         Reviewed by Lucas Forschler.
2680
2681         * BuildSlaveSupport/ews-build/events.py:
2682         (Events.stepStarted): If state_string is pending, replace it with step name.
2683
2684 2019-03-14  Chris Dumez  <cdumez@apple.com>
2685
2686         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2687         https://bugs.webkit.org/show_bug.cgi?id=195750
2688
2689         Reviewed by Geoffrey Garen.
2690
2691         Add API test coverage.
2692
2693         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2694         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2695         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2696         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2697
2698 2019-03-14  Chris Dumez  <cdumez@apple.com>
2699
2700         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2701         https://bugs.webkit.org/show_bug.cgi?id=195747
2702
2703         Reviewed by Geoff Garen.
2704
2705         Add API test coverage.
2706
2707         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2708
2709 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2710
2711         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2712         https://bugs.webkit.org/show_bug.cgi?id=195725
2713         <rdar://problem/48545062>
2714
2715         Reviewed by Tim Horton.
2716
2717         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2718         handler is nil.
2719
2720         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2721         (TestWebKitAPI::TEST):
2722
2723 2019-03-13  Sam Weinig  <sam@webkit.org>
2724
2725         Add utility function to allow easy reverse range-based iteration of a container
2726         https://bugs.webkit.org/show_bug.cgi?id=195542
2727
2728         Reviewed by Antti Koivisto.
2729
2730         * TestWebKitAPI/CMakeLists.txt:
2731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2732         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2733         (TestWebKitAPI::TEST):
2734         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2735
2736 2019-03-13  Chris Dumez  <cdumez@apple.com>
2737
2738         Use a ServiceWorker process per registrable domain
2739         https://bugs.webkit.org/show_bug.cgi?id=195649
2740
2741         Reviewed by Youenn Fablet.
2742
2743         Update API test coverage.
2744
2745         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2746
2747 2019-03-13  Chris Dumez  <cdumez@apple.com>
2748
2749         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2750         https://bugs.webkit.org/show_bug.cgi?id=195684
2751         <rdar://problem/48294714>
2752
2753         Reviewed by Antti Koivisto.
2754
2755         Add API test coverage.
2756
2757         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2758
2759 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2760
2761         [ews-app] Remove unused patch view
2762         https://bugs.webkit.org/show_bug.cgi?id=195669
2763
2764         Reviewed by Lucas Forschler.
2765
2766         * BuildSlaveSupport/ews-app/ews/urls.py:
2767         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2768
2769 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2770
2771         [ews-app] Use Buildbot result code variables
2772         https://bugs.webkit.org/show_bug.cgi?id=195668
2773
2774         Reviewed by Alexey Proskuryakov.
2775
2776         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2777         (Buildbot): Added Buildbot result code variables.
2778         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2779         (StatusBubble._build_bubble): Used Buildbot result code variables.
2780
2781 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2782
2783         [Flatpak] Expand submodule recursively
2784         https://bugs.webkit.org/show_bug.cgi?id=195672
2785
2786         Building WPE with flatpak was impossible without that as it was raising an exception.
2787         Also update wpebackend-fdo to match what is built in jhbuild
2788
2789         Reviewed by Philippe Normand.
2790
2791         * flatpak/flatpakutils.py:
2792         (expand_submodules_recurse):
2793         (expand_manifest):
2794         * flatpak/org.webkit.WPEModules.yaml:
2795
2796 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2797
2798         [ews-app] status bubble should be hidden for certain builds
2799         https://bugs.webkit.org/show_bug.cgi?id=194597
2800
2801         Reviewed by Dewei Zhu.
2802
2803         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2804         (StatusBubble._build_bubble):
2805         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2806         because the patch didn't have relevant changes.
2807         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2808         in production yet.
2809
2810 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2811
2812         [Win] Fix a slew of simple clang-cl warnings.
2813         https://bugs.webkit.org/show_bug.cgi?id=195652
2814
2815         Reviewed by Don Olmstead.
2816
2817         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2818         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2819
2820 2019-03-12  Justin Fan  <justin_fan@apple.com>
2821
2822         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2823         https://bugs.webkit.org/show_bug.cgi?id=195518
2824         <rdar://problem/46322356>
2825
2826         Reviewed by Myles C. Maxfield.
2827
2828         * DumpRenderTree/DerivedSources-input.xcfilelist:
2829         * DumpRenderTree/DerivedSources-output.xcfilelist:
2830
2831 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2832
2833         Unreviewed, rolling out r242825.
2834         https://bugs.webkit.org/show_bug.cgi?id=195648
2835
2836         "Broke webkitpy tests with my change to
2837         lldb_dump_class_layout.py" (Requested by rmorisset on
2838         #webkit).
2839
2840         Reverted changeset:
2841
2842         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2843         classes with suspicious padding"
2844         https://bugs.webkit.org/show_bug.cgi?id=195573
2845         https://trac.webkit.org/changeset/242825
2846
2847 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2848
2849         [ews-build] Show status bubbles while the patch is waiting in queue
2850         https://bugs.webkit.org/show_bug.cgi?id=195618
2851
2852         Reviewed by Lucas Forschler.
2853
2854         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2855         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2856         enabled in initial deployment.
2857         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2858         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2859         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2860         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2861         (StatusBubble._build_bubbles_for_patch):
2862
2863 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2864
2865         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2866         https://bugs.webkit.org/show_bug.cgi?id=195573
2867
2868         Reviewed by Simon Fraser.
2869
2870         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2871
2872         * Scripts/dump-class-layout:
2873         (main):
2874         * lldb/lldb_dump_class_layout.py:
2875         (ClassLayout.__init__):
2876         (ClassLayout._compute_padding_recursive):
2877         (LLDBDebuggerInstance.dump_layout_for_classname):
2878         (LLDBDebuggerInstance):
2879         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2880         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2881
2882 2019-03-12  Chris Dumez  <cdumez@apple.com>
2883
2884         Device Orientation access permission should be denied unless explicitly granted by the client
2885         https://bugs.webkit.org/show_bug.cgi?id=195625
2886
2887         Reviewed by Youenn Fablet.
2888
2889         add API test coverage.
2890
2891         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2892         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2893         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2894         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2895         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2896         (runDeviceOrientationTest):
2897         (TEST):
2898         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2899         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2900
2901 2019-03-12  Jer Noble  <jer.noble@apple.com>
2902
2903         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2904         https://bugs.webkit.org/show_bug.cgi?id=195137
2905         <rdar://problem/48810307>
2906
2907         Reviewed by Eric Carlson.
2908
2909         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2910         (TestWebKitAPI::TEST):
2911
2912 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2913
2914         [ews-build] Change urls from uat to production
2915         https://bugs.webkit.org/show_bug.cgi?id=195566
2916
2917         Reviewed by Lucas Forschler.
2918
2919         * BuildSlaveSupport/ews-app/ews/config.py:
2920         * BuildSlaveSupport/ews-build/events.py:
2921         * BuildSlaveSupport/ews-build/steps.py:
2922
2923 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2924
2925         [ews-build] change max_builds for local-worker to 1
2926         https://bugs.webkit.org/show_bug.cgi?id=195568
2927
2928         Reviewed by Lucas Forschler.
2929
2930         * BuildSlaveSupport/ews-build/loadConfig.py:
2931
2932 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2933
2934         Fix the build
2935
2936         * TestRunnerShared/spi/PencilKitTestSPI.h:
2937         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2938
2939 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2940
2941         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2942         https://bugs.webkit.org/show_bug.cgi?id=194131
2943
2944         Reviewed by Michael Catanzaro.
2945
2946         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2947         (uriChanged):
2948         (testUnfinishedSubresourceLoad):
2949         (serverCallback):
2950         (beforeAll):
2951
2952 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2953
2954         WTF::Expected should use std::addressof instead of operator&
2955         https://bugs.webkit.org/show_bug.cgi?id=195604
2956
2957         Reviewed by Myles Maxfield.
2958
2959         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2960         (TestWebKitAPI::Unique::Unique):
2961         (TestWebKitAPI::Unique::operator&):
2962         (TestWebKitAPI::TEST):
2963
2964 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2965
2966         Add Optional to Forward.h.
2967         https://bugs.webkit.org/show_bug.cgi?id=195586
2968
2969         Reviewed by Darin Adler.
2970
2971         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2972         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2973         Remove unnecessary includes from headers.
2974
2975 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2976
2977         Add testing API to hit-test and scroll overflow scrollers
2978         https://bugs.webkit.org/show_bug.cgi?id=195278
2979
2980         Reviewed by Antti Koivisto.
2981         
2982         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2983         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2984         
2985         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2986
2987         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2988         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2989         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2990         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2991         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2992         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2993         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2994         (WTR::enclosingScrollViewIncludingSelf):
2995         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2996
2997 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2998
2999         API test WebKit.RequestTextInputContext fails on iOS
3000         https://bugs.webkit.org/show_bug.cgi?id=195585
3001
3002         Reviewed by Wenson Hsieh and Simon Fraser.
3003
3004         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3005         (applyStyle):
3006         (TEST):
3007         Add a viewport, so that the coordinates match up on iOS.
3008         Scroll by moving the UIScrollView's contentOffset.
3009
3010 2019-03-11  Chris Dumez  <cdumez@apple.com>
3011
3012         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3013         https://bugs.webkit.org/show_bug.cgi?id=195506
3014         <rdar://problem/48733477>
3015
3016         Reviewed by Alex Christensen.
3017
3018         Add API test coverage.
3019
3020         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3021
3022 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3023
3024         Adding myself to contributors.json
3025
3026         Unreviewed, addming myself to contributors.json .
3027
3028         * Scripts/webkitpy/common/config/contributors.json:
3029
3030 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3031
3032         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3033         https://bugs.webkit.org/show_bug.cgi?id=195511
3034         <rdar://problem/44873269>
3035
3036         Reviewed by Darin Adler.
3037
3038         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3039         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3040         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3041         (TEST_F):
3042
3043 2019-03-11  Chris Dumez  <cdumez@apple.com>
3044
3045         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3046         https://bugs.webkit.org/show_bug.cgi?id=195561
3047
3048         Reviewed by Youenn Fablet.
3049
3050         Make sure the JS in the test requests for permission to receive device orientation events.
3051
3052         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3053
3054 2019-03-11  Youenn Fablet  <youenn@apple.com>
3055
3056         Allow storage quota increase by default in WTR
3057         https://bugs.webkit.org/show_bug.cgi?id=195541
3058
3059         Reviewed by Geoffrey Garen.
3060
3061         Allow storage quota increase by default in WTR.
3062         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3063         Use this for tests that explicitly need cache increase.
3064
3065         Instead of increasing quota by 2, make sure the next request is
3066         granted by adding all given parameters.
3067
3068         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3069         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3070         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3071         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3072         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3073         * WebKitTestRunner/TestController.cpp:
3074         (WTR::TestController::setAllowStorageQuotaIncrease):
3075         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3076         * WebKitTestRunner/TestController.h:
3077         * WebKitTestRunner/TestInvocation.cpp:
3078         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3079         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3080         (WTR::TestController::cocoaResetStateToConsistentValues):
3081         (WTR::TestController::setAllowStorageQuotaIncrease):
3082         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3083         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3084         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3085
3086 2019-03-11  Xan Lopez  <xan@igalia.com>
3087
3088         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3089         https://bugs.webkit.org/show_bug.cgi?id=194147
3090
3091         Reviewed by Michael Saboff.
3092
3093         To make --32-bit work correctly on Linux/64bit we need to:
3094
3095         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3096         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3097         unfortunately CMake only allows us to do this during
3098         crosscompilation, which is overkill here.
3099         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3100         pkg-config detection module uses the x86 .pc files instead of the
3101         x86_64 ones.
3102         - Set the -m32 flags for the compiler.
3103
3104         * Scripts/webkitdirs.pm:
3105         (generateBuildSystemFromCMakeProject):
3106
3107 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3108
3109         Add MotionMark-1.1 plan file for run-benchmark script.
3110         https://bugs.webkit.org/show_bug.cgi?id=195481
3111
3112         Rubber-stamped by Darin Adler.
3113
3114         Run-benchmark script should support MontionMark-1.1.
3115
3116         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3117
3118 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3119
3120         [ews-app] Add support for submit-to-ews url
3121         https://bugs.webkit.org/show_bug.cgi?id=195477
3122
3123         Reviewed by Lucas Forschler.
3124
3125         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3126         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3127         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3128         * BuildSlaveSupport/ews-app/ews/urls.py:
3129         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3130
3131 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3132
3133         Unreviewed, rolling out r242688, r242643, r242624.
3134
3135         Caused multiple layout test failures and crashes on iOS and macOS.
3136
3137         Reverted changeset:
3138
3139         "requestAnimationFrame should execute before the next frame"
3140         https://bugs.webkit.org/show_bug.cgi?id=177484
3141         https://trac.webkit.org/changeset/242624/webkit
3142
3143         * Tracing/SystemTracePoints.plist:
3144
3145 2019-03-11  John Wilander  <wilander@apple.com>
3146
3147         Resource Load Statistics: Make it possible exclude localhost from classification
3148         https://bugs.webkit.org/show_bug.cgi?id=195474
3149         <rdar://problem/47520577>
3150
3151         Reviewed by Brent Fulgham.
3152
3153         This patch allows for localhost to be excluded from classification and
3154         treatment as a prevalent resource.
3155
3156         The WebKit Tools change adds a new function called
3157         testRunner.setStatisticsIsRunningTest() which can be used to control this
3158         behavior.
3159
3160         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3161         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3162         (WTR::TestRunner::setStatisticsIsRunningTest):
3163         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3164         * WebKitTestRunner/TestController.cpp:
3165         (WTR::TestController::setStatisticsIsRunningTest):
3166         * WebKitTestRunner/TestController.h:
3167         * WebKitTestRunner/TestInvocation.cpp:
3168         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3169
3170 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3171
3172         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3173         https://bugs.webkit.org/show_bug.cgi?id=195560
3174
3175         Reviewed by Lucas Forschler.
3176
3177         * BuildSlaveSupport/ews-build/master.cfg:
3178
3179 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3180
3181         Unreviewed, rolling out r242698.
3182
3183         API test crashes on bots.
3184
3185         Reverted changeset:
3186
3187         "Add a WKContentRuleList variant that uses copied memory
3188         instead of mmap'd shared memory for class A containerized
3189         apps"
3190         https://bugs.webkit.org/show_bug.cgi?id=195511
3191         https://trac.webkit.org/changeset/242698
3192
3193 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3194
3195         [WPE] Enable web process sandbox
3196         https://bugs.webkit.org/show_bug.cgi?id=195169
3197
3198         Reviewed by Daniel Bates.
3199
3200         * wpe/install-dependencies:
3201         * wpe/jhbuild.modules:
3202
3203 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3204
3205         [ews-app] Use port 17000 for worker communication
3206         https://bugs.webkit.org/show_bug.cgi?id=195558
3207
3208         Reviewed by Lucas Forschler.
3209
3210         * BuildSlaveSupport/ews-build/master.cfg:
3211
3212 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3213
3214         [ews-build] unit-tests fail when passwords.json is missing
3215         https://bugs.webkit.org/show_bug.cgi?id=195557
3216
3217         Reviewed by Lucas Forschler.
3218
3219         * BuildSlaveSupport/ews-build/loadConfig.py:
3220         (loadBuilderConfig):
3221         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3222         (ConfigDotJSONTest.test_configuration):
3223         * BuildSlaveSupport/ews-build/master.cfg:
3224
3225 2019-03-11  Truitt Savell  <tsavell@apple.com>
3226
3227         Unreviewed, rolling out r242702.
3228
3229         Broke High Sierra builders.
3230
3231         Reverted changeset:
3232
3233         "Add utility function to allow easy reverse range-based
3234         iteration of a container"
3235         https://bugs.webkit.org/show_bug.cgi?id=195542
3236         https://trac.webkit.org/changeset/242702
3237
3238 2019-03-11  Sam Weinig  <sam@webkit.org>
3239
3240         Add utility function to allow easy reverse range-based iteration of a container
3241         https://bugs.webkit.org/show_bug.cgi?id=195542
3242
3243         Reviewed by Antti Koivisto.
3244
3245         * TestWebKitAPI/CMakeLists.txt:
3246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3247         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3248         (TestWebKitAPI::TEST):
3249         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3250
3251 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3252
3253         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3254         https://bugs.webkit.org/show_bug.cgi?id=195511
3255         <rdar://problem/44873269>
3256
3257         Reviewed by Darin Adler.
3258
3259         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3260         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3261         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3262         (TEST_F):
3263
3264 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3265
3266         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3267         https://bugs.webkit.org/show_bug.cgi?id=195499
3268
3269         Reviewed by Darin Adler.
3270
3271         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3272         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3273         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3274         (-[WKWebView synchronouslyFocusTextInputContext:]):
3275         (applyStyle):
3276         (applyIframe):
3277         (TEST):
3278         Add some tests for this SPI.
3279
3280 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3281
3282         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3283         https://bugs.webkit.org/show_bug.cgi?id=181151
3284
3285         Reviewed by Don Olmstead.
3286
3287         * TestWebKitAPI/CMakeLists.txt:
3288         * TestWebKitAPI/PlatformWin.cmake:
3289         Enable TestWTF RunLoop tests in all platforms.
3290
3291         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3292         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3293         (TestWebKitAPI::DerivedOneShotTimer::fired):
3294         (TestWebKitAPI::TEST):
3295         Only a few platforms support nested RunLoop.
3296
3297         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3298         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3299
3300 2019-03-10  David Quesada  <david_quesada@apple.com>
3301
3302         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3303         https://bugs.webkit.org/show_bug.cgi?id=152480
3304
3305         Reviewed by Chris Dumez.
3306
3307         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3308         there are no additional references to the process pool besides the one held by
3309         the download, waits for the download to finish (in the sense that the
3310         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3311         measure, also check that the process pool has been deallocated at the end of the
3312         test. The test wouldn't be meaningful if the process pool were still alive.
3313
3314         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3315         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3316         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3317             The download will be canceled because the delegate does not implement the
3318             method to decide the download's destination, so this is where we know the
3319             DownloadProxyMap is done with the DownloadProxy.
3320         (TEST):
3321
3322 2019-03-08  Chris Dumez  <cdumez@apple.com>
3323
3324         Add support for Device Orientation / Motion permission API
3325         https://bugs.webkit.org/show_bug.cgi?id=195329
3326         <rdar://problem/47645367>
3327
3328         Reviewed by Geoffrey Garen.
3329
3330         Add test infrastructure to help test the Device Orientation / Motion permission API.
3331
3332         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3333         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3334         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3335         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3336         * WebKitTestRunner/TestController.cpp:
3337         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3338         (WTR::TestController::createWebViewWithOptions):
3339         (WTR::TestController::resetStateToConsistentValues):
3340         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3341         * WebKitTestRunner/TestController.h:
3342         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3343         * WebKitTestRunner/TestInvocation.cpp:
3344         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3345
3346 2019-03-08  Saam barati  <sbarati@apple.com>
3347
3348         Add a compare-results script to compare benchmark results
3349         https://bugs.webkit.org/show_bug.cgi?id=195486
3350         <rdar://problem/48723397>
3351
3352         Reviewed by Geoffrey Garen.
3353
3354         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3355         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3356         to extend it to learn about our other benchmarks.
3357
3358         * Scripts/compare-results: Added.
3359         (readJSONFile):
3360         (detectJetStream2):
3361         (JetStream2Results):
3362         (detectSpeedometer2):
3363         (Speedometer2Results):
3364         (detectPLT5):
3365         (PLT5Results):
3366         (detectBenchmark):
3367         (biggerIsBetter):
3368         (ttest):
3369         (getOptions):
3370         (main):
3371
3372 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3373
3374         Ensure old tab state is cleared between iterations of run-benchmark
3375         https://bugs.webkit.org/show_bug.cgi?id=195393
3376         <rdar://problem/46885583>
3377
3378         Reviewed by Dewei Zhu.
3379
3380         a) ensure the default to restore state is not set
3381         b) terminate Safari correctly
3382         c) Set the system default to ignore Persistent State in Safari
3383
3384         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3385         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3386         (OSXBrowserDriver.prepare_env): 
3387         (OSXBrowserDriver.restore_env):
3388         (OSXBrowserDriver.close_browsers):
3389         (OSXBrowserDriver._terminate_processes):
3390         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3391         (OSXChromeDriver):
3392         (OSXChromeCanaryDriver):
3393         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3394         (OSXFirefoxDriver):
3395         (OSXFirefoxNightlyDriver):
3396         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3397         (OSXSafariDriver):
3398         (OSXSafariDriver.prepare_env):
3399
3400 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3401
3402         [GTK] Several InputMethodFilter tests are failing
3403         https://bugs.webkit.org/show_bug.cgi?id=195408
3404
3405         Reviewed by Carlos Garcia Campos.
3406
3407         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3408         Regressed in r241751.
3409         Hexadecimal values of keycodes are expressed now in upper letters.
3410         Composited characters should be cast to UTF8 strings.
3411
3412         (TestWebKitAPI::TEST):
3413
3414 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3415
3416         [GTK] Make Tools/gtkdoc python3 compatible
3417         https://bugs.webkit.org/show_bug.cgi?id=195359
3418
3419         Reviewed by Carlos Garcia Campos.
3420
3421         * gtkdoc/generate-gtkdoc:
3422         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3423         work with Python 2 and 3.
3424         (get_gtkdoc_module_paths):
3425         The iteritems() was removed in Python 3, so let's use items() that's
3426         available in Python 2 and 3.
3427         (get_generator_for_config):
3428         * gtkdoc/gtkdoc.py:
3429         (GTKDoc._run_command):
3430         The sys.stdout.write() is expecting str in Python 3 and not bytes
3431         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3432         for passing the bytes there.
3433
3434 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3435
3436         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3437         https://bugs.webkit.org/show_bug.cgi?id=195346
3438         <rdar://problem/48667048>
3439
3440         Unreviewed build fix for clang-cl.
3441
3442         * DumpRenderTree/win/DumpRenderTree.cpp:
3443         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3444
3445 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3446
3447         requestAnimationFrame should execute before the next frame
3448         https://bugs.webkit.org/show_bug.cgi?id=177484
3449
3450         Reviewed by Simon Fraser.
3451
3452         Add trace points for the page RenderingUpdate.
3453
3454         * Tracing/SystemTracePoints.plist:
3455
3456 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3457
3458         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3459         https://bugs.webkit.org/show_bug.cgi?id=195353
3460         <rdar://problem/48626394>
3461
3462         Reviewed by Simon Fraser.
3463
3464         * WebKitTestRunner/ios/TestControllerIOS.mm:
3465         (WTR::TestController::platformResetPreferencesToConsistentValues):
3466
3467 2019-03-07  John Wilander  <wilander@apple.com>
3468
3469         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3470         https://bugs.webkit.org/show_bug.cgi?id=195383
3471         <rdar://problem/48570136>
3472
3473         Reviewed by Brent Fulgham.
3474
3475         This patch adds test infrastructure to purge only script-accessible cookies,
3476         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3477
3478         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3479         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3480         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3481         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3482         * WebKitTestRunner/TestController.cpp:
3483         (WTR::TestController::statisticsDeleteCookiesForHost):
3484         * WebKitTestRunner/TestController.h:
3485         * WebKitTestRunner/TestInvocation.cpp:
3486         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3487
3488 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3489
3490         Unreviewed, rolling out r242354.
3491         https://bugs.webkit.org/show_bug.cgi?id=195402
3492
3493         breaks layout tests in all configurations (Requested by
3494         zdobersek on #webkit).
3495
3496         Reverted changeset:
3497
3498         "[WPE] Enable web process sandbox"
3499         https://bugs.webkit.org/show_bug.cgi?id=195169
3500         https://trac.webkit.org/changeset/242354
3501
3502 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3503
3504         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3505         https://bugs.webkit.org/show_bug.cgi?id=195346
3506
3507         Reviewed by Fujii Hironori.
3508
3509         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3510         (TestWebKitAPI::TEST):
3511         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3512
3513         * DumpRenderTree/win/DumpRenderTree.cpp:
3514         (findFontFallback):
3515         (addFontFallbackIfPresent):
3516         (removeFontFallbackIfPresent):
3517         (main):
3518         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3519         (TestWebKitAPI::Util::moduleDirectory):
3520         (TestWebKitAPI::Util::createInjectedBundlePath):
3521         Use wchar helpers as needed.
3522
3523 2019-03-06  Rob Buis  <rbuis@igalia.com>
3524
3525         Consider supporting the `referrerpolicy` attribute.
3526         https://bugs.webkit.org/show_bug.cgi?id=179053
3527
3528         Reviewed by Darin Adler.
3529
3530         Add a runtime flag for referrerpolicy attribute.
3531
3532         * DumpRenderTree/mac/DumpRenderTree.mm:
3533         (enableExperimentalFeatures):
3534
3535 2019-03-05  Daniel Bates  <dabates@apple.com>
3536
3537         Update expected API test result following r242379
3538         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3539
3540         Update expected x-coordinate of selection rect now that the left padding of
3541         a textarea is sized in ems (so dependent on the font size) just like the left
3542         padding of a text field.
3543
3544         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3545         (TestWebKitAPI::TEST):
3546
3547 2019-03-05  David Quesada  <david_quesada@apple.com>
3548
3549         [WK2] It should be possible to follow links with 'download' attributes
3550         https://bugs.webkit.org/show_bug.cgi?id=195145
3551         rdar://problem/48462642
3552
3553         Reviewed by Alex Christensen.
3554
3555         Add a unit test to verify that activating links with 'download' attributes now
3556         navigates to the linked resource, rather than starts downloading it. Add another
3557         to verify that it is still possible to explicitly download the link via the
3558         'Download' navigation action policy.
3559
3560         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3561         (-[DownloadAttributeTestDelegate init]):
3562         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3563         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3564         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3565         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3566         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3567         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3568         (TEST):
3569         * WebKitTestRunner/TestController.cpp:
3570         (WTR::TestController::decidePolicyForNavigationAction):
3571         * WebKitTestRunner/TestController.h:
3572
3573 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3574
3575         [Curl] Implement Cookie Accept Policy.
3576         https://bugs.webkit.org/show_bug.cgi?id=191645
3577
3578         Reviewed by Fujii Hironori.
3579
3580         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3581         (TestWebKitAPI::Curl::TEST_F):
3582
3583 2019-03-05  Youenn Fablet  <youenn@apple.com>
3584
3585         Rename requestCacheStorageSpace to requestStorageSpace
3586         https://bugs.webkit.org/show_bug.cgi?id=195282
3587
3588         Reviewed by Chris Dumez.
3589
3590         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3591         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3592         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3593
3594 2019-03-05  Brady Eidson  <beidson@apple.com>
3595
3596         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3597         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3598
3599         Reviewed by Tim Horton.
3600
3601         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3602         different directory into that same WKWebView should work.
3603
3604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3605         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3606
3607 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3608
3609         Add WeakHashSet
3610         https://bugs.webkit.org/show_bug.cgi?id=195152
3611
3612         Reviewed by Antti Koivisto.
3613
3614         Added tests for WeakHashSet.
3615
3616         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3617         (TestWebKitAPI::Base::Base): Moved.
3618         (TestWebKitAPI::Derived::foo): Moved.
3619         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3620         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3621         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3622         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3623
3624 2019-03-04  Chris Dumez  <cdumez@apple.com>
3625
3626         Do not share WebProcesses between private and regular sessions
3627         https://bugs.webkit.org/show_bug.cgi?id=195189
3628         <rdar://problem/48421064>
3629
3630         Reviewed by Alex Christensen.
3631
3632         Add API test coverage.
3633
3634         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3635         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3636
3637 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3638
3639         [WPE] Enable web process sandbox
3640         https://bugs.webkit.org/show_bug.cgi?id=195169
3641
3642         Reviewed by Daniel Bates.
3643
3644         * wpe/install-dependencies:
3645         * wpe/jhbuild.modules:
3646
3647 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3648
3649         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3650         https://bugs.webkit.org/show_bug.cgi?id=195206
3651
3652         Reviewed by Žan Doberšek.
3653
3654         Add a new test case.
3655
3656         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3657         (testJSCClass):
3658
3659 2019-03-04  Charlie Turner  <cturner@igalia.com>
3660
3661         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3662         https://bugs.webkit.org/show_bug.cgi?id=194898
3663
3664         Reviewed by Žan Doberšek.
3665
3666         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3667         a GCC extension that permits arithmetic on void* pointer. Inline
3668         the macro until this issue is fixed upstream.
3669
3670 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3671
3672         Rid the world of WK_API_ENABLED
3673         https://bugs.webkit.org/show_bug.cgi?id=195263
3674
3675         Reviewed by Dan Bernstein.
3676
3677         List of changed files elided because it's useless.
3678
3679 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3680
3681         Unreviewed follow-up to r242292.
3682
3683         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3684
3685         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3686         (TestWebKitAPI::testStrip): Renamed from strip.
3687         (TestWebKitAPI::TEST):
3688
3689 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3690
3691         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3692
3693         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3694         and bug #194272 for details.
3695
3696         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3697
3698 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3699
3700         Remove some more unused 32-bit code
3701         https://bugs.webkit.org/show_bug.cgi?id=195255
3702
3703         Reviewed by Darin Adler.
3704
3705         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3706         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3707         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3708         (NPP_New):
3709         (NPP_HandleEvent):
3710         (handleEventCarbon): Deleted.
3711
3712 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3713
3714         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3715
3716         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3717         (TestWebKitAPI::TEST):
3718
3719 2019-03-01  Darin Adler  <darin@apple.com>
3720
3721         Finish removing String::format
3722         https://bugs.webkit.org/show_bug.cgi?id=194893
3723
3724         Reviewed by Daniel Bates.
3725 '
3726         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3727
3728 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3729
3730         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3731         https://bugs.webkit.org/show_bug.cgi?id=195229
3732         <rdar://problem/48520362>
3733
3734         Reviewed by Chris Dumez.
3735
3736         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3737         (TEST):
3738
3739 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3740
3741         Add a system trace scope for event region building
3742         https://bugs.webkit.org/show_bug.cgi?id=195226
3743
3744         Reviewed by Jon Lee.
3745
3746         This trace scope measures the time spend converting element rects into Region objects,
3747         which can be large on some pages.
3748
3749         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3750
3751         * Tracing/SystemTracePoints.plist:
3752
3753 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3754
3755         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3756         https://bugs.webkit.org/show_bug.cgi?id=194612
3757
3758         Reviewed by Alex Christensen.
3759
3760         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3761         Just test the new string-processing function and don't touch the actual environment.
3762         (Test cases are all as before, but based on operator== instead of strcmp.)
3763
3764 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3765
3766         [ews-app] Update primary keys for handling multiple Buildbot instances
3767         https://bugs.webkit.org/show_bug.cgi?id=195120
3768
3769         Reviewed by Stephanie Lewis.
3770
3771         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3772         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3773         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3774
3775         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3776         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3777         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3778         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3779         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3780         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3781
3782 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3783
3784         [WinCairo] Enable service worker
3785         https://bugs.webkit.org/show_bug.cgi?id=188318
3786
3787         Reviewed by Youenn Fablet.
3788
3789         * DumpRenderTree/DumpRenderTreePrefix.h:
3790         * TestWebKitAPI/PlatformWin.cmake:
3791         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3792         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3793         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3794
3795 2019-03-01  Justin Fan  <justin_fan@apple.com>
3796
3797         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3798         https://bugs.webkit.org/show_bug.cgi?id=195191
3799
3800         Rubber-stamped by Dean Jackson.
3801
3802         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3803
3804         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3805
3806 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3807
3808         Unreviewed, fix lldb webkitpy tests
3809         https://bugs.webkit.org/show_bug.cgi?id=194375
3810
3811         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3812
3813         * lldb/lldb_webkit.py:
3814         (WTFStringImplProvider.is_8bit):
3815
3816 2019-02-28  David Quesada  <david_quesada@apple.com>
3817
3818         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3819         https://bugs.webkit.org/show_bug.cgi?id=195121
3820         rdar://problem/48450302
3821
3822         Reviewed by Alex Christensen.
3823
3824         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3825         configurations where the 'download' attribute is absent, blank, or populated
3826         with a filename, and where the anchor element is same-origin or cross-origin
3827         (meaning the 'download' attribute shouldn't be honored).
3828
3829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3830         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3831         (-[NavigationActionTestDelegate init]):
3832         (-[NavigationActionTestDelegate navigationAction]):
3833         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3834         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3835         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3836         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3837         (TEST):
3838
3839 2019-02-28  Antoine Quint  <graouts@apple.com>
3840
3841         Enable the Pointer Events runtime flag by default
3842         https://bugs.webkit.org/show_bug.cgi?id=195156
3843
3844         Reviewed by Dean Jackson.
3845
3846         * DumpRenderTree/mac/DumpRenderTree.mm:
3847         (enableExperimentalFeatures):
3848
3849 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3850
3851         Several PasteImage API tests are flaky
3852         https://bugs.webkit.org/show_bug.cgi?id=195160
3853
3854         Reviewed by Tim Horton.
3855
3856         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3857         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3858         listening for a "load" event after image load is already complete.
3859
3860         To address this, make these tests first register a "load" event handler, then run script to insert an image
3861         element into the document, and finally wait until the load event is observed before checking image size.
3862
3863         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3864
3865 2019-02-28  Chris Dumez  <cdumez@apple.com>
3866
3867         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3868         https://bugs.webkit.org/show_bug.cgi?id=195107
3869
3870         Reviewed by Alex Christensen.
3871
3872         Give some time for the zoom level to get restored.
3873
3874         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3875
3876 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3877
3878         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3879         https://bugs.webkit.org/show_bug.cgi?id=194958
3880
3881         Reviewed by Geoffrey Garen.
3882
3883         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3884         (TEST):
3885
3886 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3887
3888         [ews-app] Update method to save build to handle builder_display_name
3889         https://bugs.webkit.org/show_bug.cgi?id=195047
3890
3891         Reviewed by Dewei Zhu.
3892
3893         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3894         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3895
3896 2019-02-28  Justin Fan  <justin_fan@apple.com>
3897
3898         [Web GPU] Enable Web GPU only on 64-bit
3899         https://bugs.webkit.org/show_bug.cgi?id=195139
3900
3901         Because Metal is only supported on 64 bit apps.
3902
3903         Unreviewed build fix.
3904
3905         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3906
3907 2019-02-27  Youenn Fablet  <youenn@apple.com>
3908
3909         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3910         https://bugs.webkit.org/show_bug.cgi?id=194959
3911
3912         Reviewed by Chris Dumez.
3913
3914         Spin loop until getting the condition to remove flakiness.
3915
3916         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3917
3918 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3919
3920         [ews-build] Buildbot should include builder_display_name in the build events
3921         https://bugs.webkit.org/show_bug.cgi?id=195045
3922
3923         Reviewed by Dewei Zhu.
3924
3925         * BuildSlaveSupport/ews-build/events.py:
3926         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3927         buildername to builder_name to be consistent in naming style.
3928         (Events.buildFinished): Ditto.
3929
3930 2019-02-27  Chris Dumez  <cdumez@apple.com>
3931
3932         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3933         https://bugs.webkit.org/show_bug.cgi?id=194480
3934
3935         Reviewed by Brady Eidson.
3936
3937         Update existing API test to make it more likely to reproduce the issue.
3938
3939         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3940
3941 2019-02-27  Brady Eidson  <beidson@apple.com>
3942
3943         Universal links from Google search results pages don't open the app.
3944         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3945
3946         Reviewed by Geoffrey Garen.
3947
3948         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3949         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3950         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3951         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3952
3953 2019-02-27  Chris Dumez  <cdumez@apple.com>
3954
3955         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3956         https://bugs.webkit.org/show_bug.cgi?id=195102
3957
3958         Reviewed by Geoffrey Garen.
3959
3960         If the number of processes is not yet what we expect, wait a bit and check again to give
3961         processes some time to exit.
3962
3963         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3964
3965 2019-02-27  Chris Dumez  <cdumez@apple.com>
3966
3967         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3968         https://bugs.webkit.org/show_bug.cgi?id=194545
3969
3970         Reviewed by Brady Eidson.
3971
3972         Make sure the test navigates forward and then back only once. Previously, navigating
3973         back would trigger a navigation again in a timer.
3974
3975         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3976
3977 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3978
3979         High Sierra Debug JSC test queue should use faster hardware
3980         https://bugs.webkit.org/show_bug.cgi?id=194603
3981
3982         Rubber-stamped by Alexey Proskuryakov.
3983
3984         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3985
3986         * BuildSlaveSupport/build.webkit.org-config/config.json:
3987         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3988         (BubbleQueueServer):
3989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3990         (WebKitBuildbot):
3991         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3992         * QueueStatusServer/config/queues.py:
3993         * Scripts/webkitpy/common/config/ews.json:
3994         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3995         (test_ews_name):
3996
3997 2019-02-27  John Wilander  <wilander@apple.com>
3998
3999         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4000         https://bugs.webkit.org/show_bug.cgi?id=195071
4001         <rdar://problem/48417690>
4002
4003         Reviewed by Alex Christensen and Brent Fulgham.
4004
4005         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4006         (TestWebKitAPI::createURL):
4007             Convenience function.
4008         (TestWebKitAPI::TEST):
4009             WebCore::AdClickAttribution now takes a URL when creating Source and
4010             Destination.
4011         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4012         (TestWebKitAPI::TEST):
4013             WebCore::AdClickAttribution now takes a URL when creating Source and
4014             Destination.
4015
4016 2019-02-27  Antoine Quint  <graouts@apple.com>
4017
4018         Support Pointer Events on macOS
4019         https://bugs.webkit.org/show_bug.cgi?id=195008
4020         <rdar://problem/47454419>
4021
4022         Reviewed by Dean Jackson.
4023
4024         * DumpRenderTree/mac/DumpRenderTree.mm:
4025         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4026         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4027
4028 2019-02-26  Mark Lam  <mark.lam@apple.com>
4029
4030         Remove remaining poisoning code.
4031         https://bugs.webkit.org/show_bug.cgi?id=194138
4032
4033         Reviewed by Saam Barati.
4034
4035         * TestWebKitAPI/CMakeLists.txt:
4036         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4037         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4038         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4039         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4040         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4041         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4042         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4043
4044 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4045
4046         Move ephemeral local storage from WebProcess to UIProcess
4047         https://bugs.webkit.org/show_bug.cgi?id=195074
4048         <rdar://problem/47937975>
4049
4050         Reviewed by Geoff Garen.
4051
4052         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4053
4054 2019-02-20  Jer Noble  <jer.noble@apple.com>
4055
4056         [Cocoa] Media elements will restart network buffering just before suspending
4057         https://bugs.webkit.org/show_bug.cgi?id=193691
4058
4059         Reviewed by Eric Carlson.
4060
4061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4062         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4063         (TEST):
4064
4065 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4066
4067         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
4068         https://bugs.webkit.org/show_bug.cgi?id=191652
4069
4070         Reviewed by Alex Christensen.
4071
4072         Fix WinCairo MiniBrowser behavior of authentication dialog.
4073
4074         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4075         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
4076
4077 2019-02-26  Youenn Fablet  <youenn@apple.com>
4078
4079         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
4080         https://bugs.webkit.org/show_bug.cgi?id=195028
4081         <rdar://problem/48243733>
4082
4083         Reviewed by Eric Carlson.
4084
4085         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4086
4087 2019-02-26  Philippe Normand  <pnormand@igalia.com>
4088
4089         [WPE] Add API for webview background color configuration
4090         https://bugs.webkit.org/show_bug.cgi?id=192305
4091
4092         Reviewed by Michael Catanzaro.
4093
4094         * MiniBrowser/wpe/main.cpp:
4095         (main): Add a new option to configure the webview background
4096         color. Example: --bg-color=transparent.
4097         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
4098         (testWebViewBackgroundColor): Enable background color API tests for WPE.
4099         (beforeAll): Ditto.
4100
4101 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
4102
4103         scalableNativeWebpageParameters() is not preserved on new page navigation.
4104         https://bugs.webkit.org/show_bug.cgi?id=194892
4105         <rdar://problem/47538280>
4106
4107         Reviewed by Wenson Hsieh.
4108         
4109         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
4110
4111         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4112         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4113         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4114         (WTR::UIScriptController::allowsViewportShrinkToFit):
4115         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4116         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4117         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4118         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4119         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4120         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
4121
4122 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4123
4124         [ews-app] Add model for handling multiple Buildbot instances
4125         https://bugs.webkit.org/show_bug.cgi?id=194863
4126
4127         Reviewed by Stephanie Lewis.
4128
4129         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
4130
4131 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
4132
4133         [ews-app] Remove BuilderMapping table
4134         https://bugs.webkit.org/show_bug.cgi?id=194961
4135
4136         Reviewed by Stephanie Lewis.
4137
4138         Store builder name directly in build table, instead of having a separate
4139         table for it.
4140
4141         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
4142         * BuildSlaveSupport/ews-app/ews/models/build.py:
4143         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
4144         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4145
4146 2019-02-25  John Wilander  <wilander@apple.com>
4147
4148         Introduce and adopt new class RegistrableDomain for eTLD+1
4149         https://bugs.webkit.org/show_bug.cgi?id=194791
4150         <rdar://problem/48179240>
4151
4152         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
4153
4154         This patch adds an API test and replaces two instances of
4155         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
4156
4157         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4158         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4159         (TestWebKitAPI::TEST):
4160             Changed two strings to make sure the registrable domains are still considered
4161             invalid and pass the test.
4162         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
4163         (TestWebKitAPI::TEST):
4164         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4165         (WTR::InjectedBundle::didReceiveMessageToPage):
4166
4167 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
4168
4169         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
4170         https://bugs.webkit.org/show_bug.cgi?id=195001
4171
4172         Reviewed by Carlos Garcia Campos.
4173
4174         API version 1.0 always includes the functionality previously guarded with
4175         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
4176         unconditionally.
4177
4178         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
4179         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
4180         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
4181         (WebViewTest::showInWindow): Ditto.
4182         (WebViewTest::hideView): Ditto.
4183         * wpe/backends/HeadlessViewBackend.cpp:
4184         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
4185         * wpe/backends/ViewBackend.cpp:
4186         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
4187         * wpe/backends/WindowViewBackend.cpp:
4188         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
4189         WPE_BACKEND_CHECK_VERSION().
4190         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
4191
4192 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
4193
4194         [Flatpak] Add support for flatpak > 1.1.2
4195         https://bugs.webkit.org/show_bug.cgi?id=194088
4196
4197         Flatpak 1.2 is now out so we need to support that
4198         version now.
4199
4200         Reviewed by Michael Catanzaro.
4201
4202         * flatpak/flatpakutils.py:
4203         (check_flatpak):
4204         (FlatpakPackages.__init__):
4205         (FlatpakPackages.__detect_packages):
4206         (FlatpakPackages.__detect_packages.in):
4207         (FlatpakRepos.update):
4208
4209 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
4210
4211         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
4212         https://bugs.webkit.org/show_bug.cgi?id=194998
4213
4214         Reviewed by Carlos Garcia Campos.
4215
4216         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
4217         to a Git checkout and using the latest commit containing various fixes
4218         and improvements.
4219
4220 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4221
4222         [WPE][GTK] Remove user agent quirk for washingtonpost.com
4223         https://bugs.webkit.org/show_bug.cgi?id=194981
4224
4225         Reviewed by Žan Doberšek.
4226
4227         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4228         (TestWebKitAPI::TEST):
4229
4230 2019-02-23  Keith Miller  <keith_miller@apple.com>
4231
4232         Add new mac target numbers
4233         https://bugs.webkit.org/show_bug.cgi?id=194955
4234
4235         Reviewed by Tim Horton.
4236
4237         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4238         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4239         * MiniBrowser/Configurations/Base.xcconfig:
4240         * TestWebKitAPI/Configurations/Base.xcconfig:
4241         * WebKitTestRunner/Configurations/Base.xcconfig:
4242
4243 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4244
4245         [WinCairo] Enable wk1/wk2 suffix for platform search path.
4246         https://bugs.webkit.org/show_bug.cgi?id=194846
4247
4248         Reviewed by Don Olmstead.
4249
4250         Added _search_paths() and _port_specific_expectations_files() for
4251         WinCairoPort.
4252
4253         * Scripts/webkitpy/port/win.py:
4254         (WinCairoPort.default_baseline_search_path):
4255         (WinCairoPort):
4256         (WinCairoPort._port_specific_expectations_files):
4257         (WinCairoPort._search_paths):
4258
4259 2019-02-22  Tim Horton  <timothy_horton@apple.com>
4260
4261         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
4262         https://bugs.webkit.org/show_bug.cgi?id=194963
4263
4264         Reviewed by Dean Jackson.
4265
4266         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4267         Do a `contains` check instead of `equals`, because in debug builds we
4268         put the GraphicsLayer pointer in a prefix.
4269
4270 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4271
4272         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
4273         https://bugs.webkit.org/show_bug.cgi?id=194873
4274         <rdar://problem/46701974>
4275
4276         Reviewed by Tim Horton.
4277
4278         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
4279
4280         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4281         (WTR::UIScriptController::menuRect const):
4282         (WTR::UIScriptController::isShowingMenu const):
4283         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4284         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4285         (WTR::UIScriptController::menuRect const):
4286
4287         Add a function to query the bounds of the callout menu in content coordinates.
4288
4289         (WTR::UIScriptController::isShowingMenu const):
4290
4291         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
4292
4293         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4294         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
4295         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4296         (WTR::UIScriptController::rectForMenuAction const):
4297         (WTR::UIScriptController::menuRect const):
4298         (WTR::UIScriptController::isShowingMenu const):
4299         (WTR::findViewInHierarchyOfType): Deleted.
4300
4301 2019-02-22  Chris Dumez  <cdumez@apple.com>
4302
4303         Regression(PSON) Unable to preview password-protected documents on iCloud.com
4304         https://bugs.webkit.org/show_bug.cgi?id=194954
4305         <rdar://problem/48127957>
4306
4307         Reviewed by Alex Christensen.
4308
4309         Add API test coverage.
4310
4311         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4312         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
4313         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
4314         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
4315
4316 2019-02-22  Chris Dumez  <cdumez@apple.com>
4317
4318         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
4319         https://bugs.webkit.org/show_bug.cgi?id=194924
4320         <rdar://problem/48216125>
4321
4322         Reviewed by Geoffrey Garen.
4323
4324         Add API test coverage.
4325
4326         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4327
4328 2019-02-22  Chris Dumez  <cdumez@apple.com>
4329
4330         Unreviewed, disable API test added in r241928 on iOS.
4331
4332         The cache is not enabled on devices with less than 3GB of RAM.
4333
4334         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4335
4336 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
4337
4338         Hardcode Visual Viewports on everywhere except iOS WK1
4339         https://bugs.webkit.org/show_bug.cgi?id=194928
4340
4341         Reviewed by Zalan Bujtas.
4342
4343         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
4344         change the default value of the Setting to 'true', and hardcode WebView on iOS to
4345         set it to false. The setting has shipped for several years and there's no need to turn
4346         it off now.
4347
4348         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
4349         Visual Viewports are not enabled.
4350         
4351         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
4352         that only runs in WK2
4353
4354         * MiniBrowser/mac/SettingsController.h:
4355         * MiniBrowser/mac/SettingsController.m:
4356         (-[SettingsController init]):
4357         (-[SettingsController _populateMenu]):
4358         (-[SettingsController validateMenuItem:]):
4359         (-[SettingsController visualViewportEnabled]): Deleted.
4360         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
4361         * MiniBrowser/mac/WK1BrowserWindowController.m:
4362         (-[WK1BrowserWindowController didChangeSettings]):
4363         * MiniBrowser/mac/WK2BrowserWindowController.m:
4364         (-[WK2BrowserWindowController didChangeSettings]):
4365
4366 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
4367
4368         Discard cached