Store Ad Click Attribution requests in the network process
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-13  John Wilander  <wilander@apple.com>
2
3         Store Ad Click Attribution requests in the network process
4         https://bugs.webkit.org/show_bug.cgi?id=194510
5         <rdar://problem/47650118>
6
7         Reviewed by Alex Christensen and Daniel Bates.
8
9         This patch adds two TestRunner functions:
10         - dumpAdClickAttribution()
11         - clearAdClickAttribution()
12
13         They call into the network process to dump and clear Ad Click
14         Attribution state, respectively.
15
16         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
17         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
18         (WTR::TestRunner::dumpAdClickAttribution):
19         (WTR::TestRunner::clearAdClickAttribution):
20         * WebKitTestRunner/InjectedBundle/TestRunner.h:
21         * WebKitTestRunner/TestController.cpp:
22         (WTR::TestController::resetStateToConsistentValues):
23         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
24         (WTR::adClickAttributionStringResultCallback):
25         (WTR::TestController::dumpAdClickAttribution):
26         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
27         (WTR::adClickAttributionVoidCallback):
28         (WTR::TestController::clearAdClickAttribution):
29         * WebKitTestRunner/TestController.h:
30         * WebKitTestRunner/TestInvocation.cpp:
31         (WTR::TestInvocation::dumpResults):
32         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
33         (WTR::TestInvocation::dumpAdClickAttribution):
34         * WebKitTestRunner/TestInvocation.h:
35
36 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
37
38         [ews-app] Generate status-bubble
39         https://bugs.webkit.org/show_bug.cgi?id=194572
40
41         Reviewed by Lucas Forschler.
42
43         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
44         (StatusBubble._build_bubble):
45         (StatusBubble._should_show_bubble_for):
46         (StatusBubble._build_bubbles_for_patch):
47
48 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
49
50         [ews-app] Add status bubble html template
51         https://bugs.webkit.org/show_bug.cgi?id=194571
52
53         Reviewed by Lucas Forschler.
54
55         * BuildSlaveSupport/ews-app/ews/templates: Added.
56         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
57
58 2019-02-12  Chris Dumez  <cdumez@apple.com>
59
60         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
61         https://bugs.webkit.org/show_bug.cgi?id=194568
62         <rdar://problem/47944490>
63
64         Reviewed by Ryosuke Niwa.
65
66         Add API test coverage.
67
68         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
69         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
70
71 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
72
73         webkitpy: Remove bug_dummy from parsed test expectations
74         https://bugs.webkit.org/show_bug.cgi?id=194562
75         <rdar://problem/47853999>
76
77         Reviewed by Lucas Forschler.
78
79         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
80         (TestExpectationParser):
81         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
82         skipped tests.
83         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
84
85 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
86
87         [ews-app] Add method to fetch patch
88         https://bugs.webkit.org/show_bug.cgi?id=194518
89
90         Reviewed by Lucas Forschler.
91
92         * BuildSlaveSupport/ews-app/ews/models/patch.py:
93         (Patch.get_patch):
94
95 2019-02-12  Zalan Bujtas  <zalan@apple.com>
96
97         [LFC] Expand tests coverage (60 new tests -> 860)
98
99         Unreviewed test gardening (run-singly, --child-processes=1).
100
101         * LayoutReloaded/misc/LFC-passing-tests.txt:
102
103 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
104
105         Allow pages to trigger programmatic paste from script on iOS
106         https://bugs.webkit.org/show_bug.cgi?id=194271
107         <rdar://problem/47808810>
108
109         Reviewed by Tim Horton.
110
111         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
112
113         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
114         (WTR::UIScriptController::platformSetDidShowMenuCallback):
115         (WTR::UIScriptController::platformSetDidHideMenuCallback):
116         (WTR::UIScriptController::rectForMenuAction const):
117
118         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
119         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
120         for when the menu is shown or hidden.
121
122         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
123         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
124         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
125         (WTR::UIScriptController::setDidShowMenuCallback):
126         (WTR::UIScriptController::didShowMenuCallback const):
127         (WTR::UIScriptController::setDidHideMenuCallback):
128         (WTR::UIScriptController::didHideMenuCallback const):
129         (WTR::UIScriptController::platformSetDidShowMenuCallback):
130         (WTR::UIScriptController::platformSetDidHideMenuCallback):
131         (WTR::UIScriptController::rectForMenuAction const):
132         * TestRunnerShared/UIScriptContext/UIScriptController.h:
133         * WebKitTestRunner/TestController.cpp:
134         (WTR::TestController::resetPreferencesToConsistentValues):
135         (WTR::updateTestOptionsFromTestHeader):
136         * WebKitTestRunner/TestOptions.h:
137
138         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
139         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
140
141         (WTR::TestOptions::hasSameInitializationOptions const):
142         * WebKitTestRunner/UIScriptControllerCocoa.mm:
143         (WTR::UIScriptController::calendarType const):
144         (WTR::UIScriptController::platformUndoManager const):
145         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
146         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
147         (-[TestRunnerWKWebView initWithFrame:configuration:]):
148         (-[TestRunnerWKWebView dealloc]):
149         (-[TestRunnerWKWebView _didShowMenu]):
150         (-[TestRunnerWKWebView _didHideMenu]):
151
152         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
153
154         * WebKitTestRunner/ios/TestControllerIOS.mm:
155         (WTR::handleMenuWillHideNotification):
156         (WTR::handleMenuDidHideNotification):
157         (WTR::TestController::platformInitialize):
158         (WTR::TestController::platformDestroy):
159         (WTR::TestController::platformResetStateToConsistentValues):
160
161         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
162         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
163
164         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
165         (WTR::forEachViewInHierarchy):
166         (WTR::findViewInHierarchyOfType):
167
168         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
169         functions that dig through a given view's hierarchy in search of a view of a given class.
170
171         (WTR::UIScriptController::selectionStartGrabberViewRect const):
172         (WTR::UIScriptController::selectionEndGrabberViewRect const):
173         (WTR::UIScriptController::selectionCaretViewRect const):
174         (WTR::UIScriptController::selectionRangeViewRects const):
175         (WTR::UIScriptController::platformSetDidShowMenuCallback):
176         (WTR::UIScriptController::platformSetDidHideMenuCallback):
177
178         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
179
180         (WTR::UIScriptController::rectForMenuAction const):
181
182         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
183         callout bar) whose label matches the given string.
184
185         (WTR::UIScriptController::platformContentView const):
186
187         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
188         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
189         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
190
191         (WTR::UIScriptController::platformUndoManager const): Deleted.
192         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
193         (WTR::UIScriptController::platformContentView const):
194         (WTR::UIScriptController::platformUndoManager const): Deleted.
195
196 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
197
198         webkitpy: No option to only show unexpected failures in results.html for iPad
199         https://bugs.webkit.org/show_bug.cgi?id=194554
200         <rdar://problem/47922442>
201
202         Rubber-stamped by Aakash Jain.
203
204         Just because a TestExpecations file does not exist for a specific platform does not mean that
205         TestExpecations are not being used, given that platforms inherit test expectations.
206
207         * Scripts/webkitpy/port/base.py:
208         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
209         * Scripts/webkitpy/port/base_unittest.py:
210         (PortTest.test_uses_test_expectations_file):
211
212 2019-02-12  Alex Christensen  <achristensen@webkit.org>
213
214         Remove setDefersLoading infrastructure from WebKit2
215         https://bugs.webkit.org/show_bug.cgi?id=194506
216
217         Reviewed by Brady Eidson.
218
219         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
220         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
221         (WTR::TestRunner::setDefersLoading): Deleted.
222         * WebKitTestRunner/InjectedBundle/TestRunner.h:
223
224 2019-02-12  Alex Christensen  <achristensen@webkit.org>
225
226         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
227         https://bugs.webkit.org/show_bug.cgi?id=194522
228         <rdar://problem/47789393>
229
230         Reviewed by Chris Dumez.
231
232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
233         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
234         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
235         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
236
237 2019-02-12  Andy Estes  <aestes@apple.com>
238
239         [iOSMac] Enable Parental Controls Content Filtering
240         https://bugs.webkit.org/show_bug.cgi?id=194521
241         <rdar://39732376>
242
243         Reviewed by Tim Horton.
244
245         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
246
247 2019-02-12  Zalan Bujtas  <zalan@apple.com>
248
249         [LFC][IFC] Add intrinsic width support for float boxes.
250         https://bugs.webkit.org/show_bug.cgi?id=194528
251
252         Reviewed by Antti Koivisto.
253
254         Expand tests coverage (2 new tests -> 800).
255         (This is the correct test ordering --runs-singly --child-processes=1)
256
257         * LayoutReloaded/misc/LFC-passing-tests.txt:
258
259 2019-02-12  Rob Buis  <rbuis@igalia.com>
260
261         Implement serializing in MIME type parser
262         https://bugs.webkit.org/show_bug.cgi?id=193909
263
264         Reviewed by Darin Adler.
265
266         Add various tests involving upper case, non-ASCII, control/null characters,
267         various HTTP whitespace, single quotes and an unpaired surrogate.
268
269         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
270         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
271         (TestWebKitAPI::serializeIfValid):
272         (TestWebKitAPI::TEST):
273
274 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
275
276         [Cocoa] Ask platform for generic font family mappings
277         https://bugs.webkit.org/show_bug.cgi?id=187723
278         <rdar://problem/41892438>
279
280         Reviewed by Brent Fulgham.
281
282         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
283
284         * DumpRenderTree/mac/DumpRenderTree.mm:
285         (allowedFontFamilySet):
286         * WebKitTestRunner/mac/TestControllerMac.mm:
287         (WTR::allowedFontFamilySet):
288
289 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
290
291         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
292         https://bugs.webkit.org/show_bug.cgi?id=193622
293
294         Reviewed by Michael Catanzaro.
295
296         This adds support for loading content extension rule sets from the JSON files which
297         accompany the corresponding layout test, using the C API. The Cocoa specific parts
298         of WKTR for this could be removed, but that is left for a follow-up patch with
299         cleanups.
300
301         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
302         * WebKitTestRunner/TestController.cpp:
303         (WTR::testPath): Subtract one from the length when constructing the result std::string to
304         avoid having the null-terminator copied into the result.
305         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
306         part of the preparations to run a test.
307         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
308         (WTR::contentExtensionStoreCallback): Added.
309         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
310         used for content extensions test.
311         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
312         extensions and compiling the JSON rule set for tests involving content extensions.
313         (WTR::TestController::resetContentExtensions): Removes the content extension built for
314         testing and disables content extensions.
315         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
316         resetContentExtensions().
317         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
318         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
319         configureContentExtensionForTest(), and userContentController().
320
321 2019-02-11  Daniel Bates  <dabates@apple.com>
322
323         [iOS] Mouse/Touch/Pointer events are missing modifier keys
324         https://bugs.webkit.org/show_bug.cgi?id=191446
325         <rdar://problem/45929460>
326
327         Reviewed by Tim Horton.
328
329         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
330
331         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
332         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
333         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
334         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
335         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
336         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
337         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
338         * TestRunnerShared/UIScriptContext/UIScriptController.h:
339         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
340         (WTR::arrayLength):
341         (WTR::parseModifierArray):
342         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
343         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
344         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
345         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
346
347 2019-02-11  Commit Queue  <commit-queue@webkit.org>
348
349         Unreviewed, rolling out r241272 and r241276.
350         https://bugs.webkit.org/show_bug.cgi?id=194514
351
352         Broke the Apple Internal build and the fix requires human
353         intervention :( (Requested by dydz on #webkit).
354
355         Reverted changesets:
356
357         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
358         https://bugs.webkit.org/show_bug.cgi?id=191446
359         https://trac.webkit.org/changeset/241272
360
361         "Fix internal iOS build after r241272"
362         https://bugs.webkit.org/show_bug.cgi?id=191446
363         https://trac.webkit.org/changeset/241276
364
365 2019-02-11  Truitt Savell  <tsavell@apple.com>
366
367         Unreviewed, rolling out r241269.
368
369         Caused 5 layout tests crashes on Mac WK1
370
371         Reverted changeset:
372
373         "DumpRenderTree should report unknown options"
374         https://bugs.webkit.org/show_bug.cgi?id=191303
375         https://trac.webkit.org/changeset/241269
376
377 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
378
379         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
380         https://bugs.webkit.org/show_bug.cgi?id=194313
381
382         Reviewed by Tim Horton.
383
384         Add a helper to determine whether the web view is presenting modal UI.
385
386         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
387         (WTR::UIScriptController::isPresentingModally const):
388         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
389         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
390         (WTR::UIScriptController::isPresentingModally const):
391         * TestRunnerShared/UIScriptContext/UIScriptController.h:
392         * WebKitTestRunner/UIScriptControllerCocoa.mm:
393         (WTR::UIScriptController::calendarType const): Deleted.
394         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
395         (WTR::UIScriptController::isPresentingModally const):
396         (WTR::UIScriptController::calendarType const):
397         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
398         (WTR::UIScriptController::calendarType const):
399
400 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
401
402         GCHeapInspector: Show the retained sizes in more places
403         https://bugs.webkit.org/show_bug.cgi?id=194464
404
405         Reviewed by Simon Fraser.
406
407         * GCHeapInspector/gc-heap-inspector.html:
408         * GCHeapInspector/script/interface.js:
409         (HeapInspectorUtils.humanReadableSize):
410         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
411         (HeapInspectorUtils.spanForNode.span.span):
412         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
413         (HeapSnapshotInspector.prototype.buildRoots):
414
415 2019-02-11  Daniel Bates  <dabates@apple.com>
416
417         [iOS] Mouse/Touch/Pointer events are missing modifier keys
418         https://bugs.webkit.org/show_bug.cgi?id=191446
419         <rdar://problem/45929460>
420
421         Reviewed by Tim Horton.
422
423         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
424
425         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
426         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
427         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
428         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
429         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
430         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
431         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
432         * TestRunnerShared/UIScriptContext/UIScriptController.h:
433         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
434         (WTR::arrayLength):
435         (WTR::parseModifierArray):
436         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
437         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
438         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
439         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
440
441 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
442
443         DumpRenderTree should report unknown options
444         https://bugs.webkit.org/show_bug.cgi?id=191303
445
446         Reviewed by Frédéric Wang.
447
448         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
449         to report unknown options.
450         Added and assigned test options which are currently used in tests.
451
452         * DumpRenderTree/TestOptions.cpp:
453         (TestOptions::TestOptions):
454
455 2019-02-11  Truitt Savell  <tsavell@apple.com>
456
457         Unreviewed, rolling out r241229.
458
459         Revision broke internal builds for watchOS.
460
461         Reverted changeset:
462
463         "[Cocoa] Ask platform for generic font family mappings"
464         https://bugs.webkit.org/show_bug.cgi?id=187723
465         https://trac.webkit.org/changeset/241229
466
467 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
468
469         [WinCairo][MiniBrowser] Basic authentication always fails.
470         https://bugs.webkit.org/show_bug.cgi?id=194496
471
472         Reviewed by Don Olmstead.
473
474         * MiniBrowser/win/DialogHelper.h:
475         (Dialog::getText):
476
477 2019-02-11  Philippe Normand  <pnormand@igalia.com>
478
479         [GStreamer] GstMappedBuffer testsuite build fails
480         https://bugs.webkit.org/show_bug.cgi?id=194495
481
482         Reviewed by Carlos Garcia Campos.
483
484         Fix the build by explicitely adding the gstreamer1.0-audio include
485         directories to the include path.
486
487         * TestWebKitAPI/PlatformGTK.cmake:
488         * TestWebKitAPI/PlatformWPE.cmake:
489
490 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
491
492         [GTK][WPE] Add enable-javascript-markup setting
493         https://bugs.webkit.org/show_bug.cgi?id=193439
494
495         Reviewed by Michael Catanzaro.
496
497         Add test cases to check the new setting.
498
499         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
500         (testWebKitSettings):
501         (testWebKitSettingsJavaScriptMarkup):
502         (beforeAll):
503
504 2019-02-10  Darin Adler  <darin@apple.com>
505
506         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
507         https://bugs.webkit.org/show_bug.cgi?id=194485
508
509         Reviewed by Daniel Bates.
510
511         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
512
513 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
514
515         Add more tests for clampTo<>()
516         https://bugs.webkit.org/show_bug.cgi?id=194462
517
518         Reviewed by Geoffrey Garen.
519
520         Darin suggested to test the very last floating point number
521         at the boundaries when truncating to integer.
522         I added test for max/min and max-1/min-1.
523
524         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
525         (TestWebKitAPI::TEST):
526
527 2019-02-09  Darin Adler  <darin@apple.com>
528
529         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
530         https://bugs.webkit.org/show_bug.cgi?id=194021
531
532         Reviewed by Geoffrey Garen.
533
534         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
535         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
536         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
537
538 2019-02-09  Zalan Bujtas  <zalan@apple.com>
539
540         [LFC][IFC] Add intrinsic width support for basic inline containers
541         https://bugs.webkit.org/show_bug.cgi?id=194473
542
543         Reviewed by Antti Koivisto.
544
545         Expand tests coverage (11 new tests -> 798)
546
547         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
548
549 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
550
551         Fix MiniBrowser's entitlements
552         https://bugs.webkit.org/show_bug.cgi?id=192431
553
554         Reviewed by Joseph Pecoraro.
555
556         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
557         files, making it impossible to load any extension.
558
559         * MiniBrowser/MiniBrowser.entitlements:
560
561 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
562
563         [Cocoa] Ask platform for generic font family mappings
564         https://bugs.webkit.org/show_bug.cgi?id=187723
565         <rdar://problem/41892438>
566
567         Reviewed by Brent Fulgham.
568
569         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
570
571         * DumpRenderTree/mac/DumpRenderTree.mm:
572         (allowedFontFamilySet):
573         * WebKitTestRunner/mac/TestControllerMac.mm:
574         (WTR::allowedFontFamilySet):
575
576 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
577
578         [GTK] Implement back/forward touchpad gesture
579         https://bugs.webkit.org/show_bug.cgi?id=193919
580
581         Reviewed by Michael Catanzaro.
582
583         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
584         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
585
586 2019-02-08  Alex Christensen  <achristensen@webkit.org>
587
588         Add SPI to use networking daemon instead of XPC service
589         https://bugs.webkit.org/show_bug.cgi?id=194427
590
591         Reviewed by Geoffrey Garen
592
593         * MiniBrowser/MiniBrowser.entitlements:
594
595 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
596
597         [ews-build] Ensure that every builder in config.json has short name
598         https://bugs.webkit.org/show_bug.cgi?id=194461
599
600         Reviewed by Lucas Forschler.
601
602         * BuildSlaveSupport/ews-build/loadConfig.py:
603         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
604
605 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
606
607         [ews-build] Add short name to config.json
608         https://bugs.webkit.org/show_bug.cgi?id=194456
609
610         Reviewed by Lucas Forschler.
611
612         * BuildSlaveSupport/ews-build/config.json: Added short name.
613         * BuildSlaveSupport/ews-build/loadConfig.py:
614         (loadBuilderConfig): Set the short name as the builder description.
615
616 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
617
618         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
619         https://bugs.webkit.org/show_bug.cgi?id=194418
620
621         Reviewed by Lucas Forschler.
622
623         Do not include errors trying when finding crashlogs at the end of
624         a run-webkit-tests run since we don't process those errors.
625
626         * Scripts/webkitpy/port/darwin.py:
627         (DarwinPort._look_for_all_crash_logs_in_log_dir):
628         * Scripts/webkitpy/port/ios_device.py:
629         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
630         * Scripts/webkitpy/port/watch_device.py:
631         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
632
633 2019-02-08  Beth Dakin  <bdakin@apple.com>
634
635         Add afterScreenUpdates to WKSnapshotConfiguration
636         https://bugs.webkit.org/show_bug.cgi?id=194362
637         -and corresponding-
638         <rdar://problem/40655528> Please add an "after screen updates" property to 
639         WKSnapshotConfiguration (to solve blank snapshots)
640
641         Reviewed by Tim Horton.
642
643         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
644         (TEST):
645
646 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
647
648         clampTo(): do not convert the input to double when dealing with integers
649         https://bugs.webkit.org/show_bug.cgi?id=194263
650         <rdar://problem/47692312>
651
652         Reviewed by Darin Adler.
653
654         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
655         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
656         (TestWebKitAPI::testClampFloatingPointToInteger):
657         (TestWebKitAPI::testClampSameSignIntegers):
658         (TestWebKitAPI::testClampUnsignedToSigned):
659         (TestWebKitAPI::testClampSignedToUnsigned):
660
661 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
662
663         webkitpy: Respect --dedicated-simulators flag
664         https://bugs.webkit.org/show_bug.cgi?id=194416
665         <rdar://problem/47894722>
666
667         Reviewed by Lucas Forschler.
668
669         * Scripts/webkitpy/port/device_port.py:
670         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
671         available devices can be safely ignored.
672
673 2019-02-07  Keith Rollin  <krollin@apple.com>
674
675         Remove extra copy of 100x100-red.tga
676         https://bugs.webkit.org/show_bug.cgi?id=194371
677         <rdar://problem/47873465>
678
679         Reviewed by Said Abou-Hallawa.
680
681         In order to help it pass its tests, Bug 194190 added a second copy of
682         the file 100x100-red.tga. However, it turns out that this additional
683         file wasn't actually needed, and that that sole previous copy was
684         sufficient. At the same time, this second copy -- which was copied to
685         the same location in the build output as the first copy -- now caused
686         XCBuild to complain because there were two production rules for the
687         same output file. Address this by removing the newly-added extra copy.
688
689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
690         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
691
692 2019-02-07  Alex Christensen  <achristensen@webkit.org>
693
694         Deprecate WKBundlePageSetDefersLoading
695         https://bugs.webkit.org/show_bug.cgi?id=191394
696
697         Reviewed by Dean Jackson.
698
699         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
700         (WTR::TestRunner::setDefersLoading):
701
702 2019-02-07  Zalan Bujtas  <zalan@apple.com>
703
704         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
705         https://bugs.webkit.org/show_bug.cgi?id=194391
706
707         Reviewed by Antti Koivisto.
708
709         * LayoutReloaded/misc/LFC-passing-tests.txt:
710
711 2019-02-06  Keith Rollin  <krollin@apple.com>
712
713         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
714         https://bugs.webkit.org/show_bug.cgi?id=193975
715         <rdar://problem/47643306>
716
717         Reviewed by Tim Horton.
718
719         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
720         the Info.plist file into the bundle. This step is not necessary as the
721         implicit "bundle up all the build products into a framework" build
722         phase does this already. Having the Copy Bundle Resources phase do
723         this causes a conflict under XCBuild, which objects to two build
724         phases producing the same file (Info.plist). Address this by removing
725         Info.plist from the Copy Bundle Resources phase.
726
727         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
728
729 2019-02-06  Keith Rollin  <krollin@apple.com>
730
731         Really enable the automatic checking and regenerations of .xcfilelists during builds
732         https://bugs.webkit.org/show_bug.cgi?id=194357
733         <rdar://problem/47861231>
734
735         Reviewed by Chris Dumez.
736
737         Bug 194124 was supposed to enable the automatic checking and
738         regenerating of .xcfilelist files during the build. While related
739         changes were included in that patch, the change to actually enable the
740         operation somehow was omitted. This patch actually enables the
741         operation. The check-xcfilelist.sh scripts now check
742         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
743         from the checking.
744
745         * DumpRenderTree/Scripts/check-xcfilelists.sh:
746         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
747
748 2019-02-06  David Kilzer  <ddkilzer@apple.com>
749
750         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
751         <https://webkit.org/b/194286>
752         <rdar://problem/47815558>
753
754         Reviewed by Alexey Proskuryakov.
755
756         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
757         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
758         WKRetainPtr<> to avoid leaking the WKDataRef.
759
760 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
761
762         Unreviewed, fix a typo
763
764         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
765
766 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
767
768         [GTK][WPE] force libpsl build to use ICU in jhbuild
769         https://bugs.webkit.org/show_bug.cgi?id=194288
770
771         Reviewed by Carlos Garcia Campos.
772
773         * gtk/jhbuild.modules:
774         Require ICU for libpsl build in jhbuild, like done in WPE.
775
776 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
777
778         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
779         https://bugs.webkit.org/show_bug.cgi?id=194209
780
781         Reviewed by Carlos Garcia Campos.
782
783         Enhance TestCookieManager to ensure this doesn't happen again.
784
785         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
786         (testCookieManagerPersistentStorage):
787         (beforeAll):
788
789 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
790
791         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
792         https://bugs.webkit.org/show_bug.cgi?id=194324
793
794         Reviewed by Andy Estes.
795
796         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
797         part of the name is already implicit, since this is in testing code in TestOptions.
798
799         * WebKitTestRunner/TestController.cpp:
800         (WTR::TestController::generateContextConfiguration const):
801         (WTR::updateTestOptionsFromTestHeader):
802         * WebKitTestRunner/TestOptions.h:
803         (WTR::TestOptions::hasSameInitializationOptions const):
804
805 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
806
807         [ews-build] Allow * as platform for builders and workers
808         https://bugs.webkit.org/show_bug.cgi?id=188533
809
810         Reviewed by Lucas Forschler.
811
812         * BuildSlaveSupport/ews-build/loadConfig.py:
813         (checkWorkersAndBuildersForConsistency):
814
815 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
816
817         [ews-build] Add few bots to config.json
818         https://bugs.webkit.org/show_bug.cgi?id=194304
819
820         Reviewed by Lucas Forschler.
821
822         * BuildSlaveSupport/ews-build/config.json:
823
824 2019-02-05  Keith Rollin  <krollin@apple.com>
825
826         Enable the automatic checking and regenerations of .xcfilelists during builds
827         https://bugs.webkit.org/show_bug.cgi?id=194124
828         <rdar://problem/47721277>
829
830         Reviewed by Tim Horton.
831
832         Bug 193790 add a facility for checking -- during build time -- that
833         any needed .xcfilelist files are up-to-date and for updating them if
834         they are not. This facility was initially opt-in by setting
835         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
836         the process seemed robust. Its now time to enable this facility and
837         make it opt-out. If there is a need to disable this facility, set and
838         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
839         running `make` or `build-webkit`, or before running Xcode from the
840         command line.
841
842         Additionally, remove the step that generates a list of source files
843         going into the UnifiedSources build step. It's only necessarily to
844         specify Sources.txt and SourcesCocoa.txt as inputs.
845
846         * Scripts/generate-xcfilelists:
847
848 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
849
850         [GTK][WPE] force libpsl build to use ICU in jhbuild
851         https://bugs.webkit.org/show_bug.cgi?id=194288
852
853         Reviewed by Philippe Normand.
854
855         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
856         This can cause build failures if libidn is detected but libunistring is not available.
857
858         Make sure that ICU is used for runtime and builtin PSL data.
859
860         * gtk/jhbuild.modules:
861         * wpe/jhbuild.modules:
862
863 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
864
865         [ews-app] Modified timestamp should be updated on updating data
866         https://bugs.webkit.org/show_bug.cgi?id=194295
867
868         Reviewed by Lucas Forschler.
869
870         * BuildSlaveSupport/ews-app/ews/models/build.py:
871         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
872         * BuildSlaveSupport/ews-app/ews/models/step.py:
873
874 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
875
876         Unreviewed, rolling out r240742.
877
878         Causes crashes on iOS simulator.
879
880         Reverted changeset:
881
882         "[iOS] Keyups for non-modifier keys identified as "Dead" when
883         not focused in a content-editable element"
884         https://bugs.webkit.org/show_bug.cgi?id=192824
885         https://trac.webkit.org/changeset/240742
886
887 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
888
889         run-webkit-tests emits message "...running None" when running tests
890         https://bugs.webkit.org/show_bug.cgi?id=194133
891         <rdar://problem/47724738>
892
893         Reviewed by Lucas Forschler.
894
895         * Scripts/webkitpy/xcode/device_type.py:
896         (DeviceType.__str__): Use both version mapping tables and use just the variant
897         name if no version name is available.
898         * Scripts/webkitpy/xcode/device_type_unittest.py:
899         (DeviceTypeTest):
900         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
901         an associated named.
902
903 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
904
905         [WPE] require python3-setuptools for meson build in jhbuild
906         https://bugs.webkit.org/show_bug.cgi?id=194287
907
908         Reviewed by Philippe Normand.
909
910         python3-setuptools is needed to build meson in jhbuild.
911         It is already required by the GTK port.
912
913         * wpe/install-dependencies:
914
915 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
916
917         [ews-app] Add method to save BuilderMapping to database
918         https://bugs.webkit.org/show_bug.cgi?id=194264
919
920         Reviewed by Lucas Forschler.
921
922         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
923         (BuilderMapping.__str__):
924         (BuilderMapping):
925         (BuilderMapping.save_mapping):
926         (BuilderMapping.update_mapping):
927         (BuilderMapping.get_existing_mapping):
928         (BuilderMapping.is_valid_mapping):
929
930 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
931
932         [ews-app] Add timestamp fields for BuilderMappings
933         https://bugs.webkit.org/show_bug.cgi?id=194266
934
935         Reviewed by Lucas Forschler.
936
937         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
938         (BuilderMapping):
939
940 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
941
942         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
943         https://bugs.webkit.org/show_bug.cgi?id=174816
944
945         Reviewed by Michael Catanzaro.
946
947         Add tests for webkit_uri_for_display().
948
949         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
950         (testURIForDisplayUnaffected):
951         (testURIForDisplayAffected):
952         (beforeAll):
953         (afterAll):
954         * TestWebKitAPI/glib/CMakeLists.txt:
955
956 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
957
958         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
959         https://bugs.webkit.org/show_bug.cgi?id=194158
960         <rdar://problem/47737268>
961
962         Rubber-stamped by Aakash Jain.
963
964         * Scripts/webkitpy/port/device_port.py:
965         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
966
967 2019-02-04  Said Abou-Hallawa  <said@apple.com>
968
969         [CG] Enable setAdditionalSupportedImageTypes for WK1
970         https://bugs.webkit.org/show_bug.cgi?id=194190
971
972         Reviewed by Tim Horton.
973
974         Add a test similar to the one under WebKit Cocoa but make it create a
975         WebView instead of a WKWebView.
976
977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
978         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
979         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
980         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
981         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
982         (TestWebKitAPI::runTest):
983         (TestWebKitAPI::TEST):
984
985 2019-02-04  Zalan Bujtas  <zalan@apple.com>
986
987         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
988         https://bugs.webkit.org/show_bug.cgi?id=194168
989
990         Reviewed by Simon Fraser.
991
992         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
993
994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
995         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
996         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
997         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
998         (TEST):
999         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1000         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1001
1002 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1003
1004         REGRESSION (r237269): webkit-patch what-broke is broken 
1005         https://bugs.webkit.org/show_bug.cgi?id=193025
1006
1007         Reviewed by Aakash Jain.
1008
1009         * Scripts/webkitpy/common/host.py:
1010         (Host.buildbot):
1011         (Host.bugzilla): Renamed to 'buildbot'.
1012
1013 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1014
1015         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1016         https://bugs.webkit.org/show_bug.cgi?id=194207
1017
1018         Reviewed by Tim Horton.
1019
1020         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1021         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1022         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1023         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1024         start and delete forwards to remove the original attachment.
1025
1026         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1027         (TestWebKitAPI::TEST):
1028
1029 2019-02-04  Youenn Fablet  <youenn@apple.com>
1030
1031         Capture state should be managed consistently when doing process swapping
1032         https://bugs.webkit.org/show_bug.cgi?id=194122
1033         <rdar://problem/47609293>
1034
1035         Reviewed by Eric Carlson.
1036
1037         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1038         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1039         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1040         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1041         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1042         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1043         (WTR::TestRunner::isDoingMediaCapture const):
1044         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1045         * WebKitTestRunner/TestController.cpp:
1046         (WTR::TestController::isDoingMediaCapture const):
1047         * WebKitTestRunner/TestController.h:
1048         * WebKitTestRunner/TestInvocation.cpp:
1049         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1050         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1051         (WTR::TestController::isDoingMediaCapture const):
1052
1053 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1054
1055         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1056         https://bugs.webkit.org/show_bug.cgi?id=194142
1057
1058         Reviewed by Ross Kirsling.
1059
1060         There three 'separator' variables in TestController.cpp. Renamed
1061         it 'pathSeparator', and unified them.
1062
1063         * WebKitTestRunner/TestController.cpp:
1064         (WTR::TestController::generateContextConfiguration const):
1065         (WTR::createTestURL):
1066         (WTR::TestController::platformAdjustContext):
1067
1068 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1069
1070         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1071         https://bugs.webkit.org/show_bug.cgi?id=194198
1072
1073         Reviewed by Antti Koivisto.
1074
1075         No need to set the banner heights on navigation now, since Page stores them.
1076
1077         * MiniBrowser/mac/WK2BrowserWindowController.m:
1078         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1079
1080 2019-02-03  John Wilander  <wilander@apple.com>
1081
1082         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1083         https://bugs.webkit.org/show_bug.cgi?id=194104
1084         <rdar://problem/47649991>
1085
1086         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1087
1088         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1089         (TestWebKitAPI::TEST):
1090             Changed numeric types from unsigned short to uint32_t.
1091
1092 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1093
1094         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1095         <https://webkit.org/b/194178>
1096         <rdar://problem/47753473>
1097
1098         Reviewed by Alexey Proskuryakov.
1099
1100         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1101         (WTR::uninstallFakeHelvetica): Pass nullptr into
1102         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1103
1104 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1105
1106         [LFC] Initialize ICB's style with fixed width/height.
1107         https://bugs.webkit.org/show_bug.cgi?id=194188
1108
1109         Reviewed by Antti Koivisto.
1110
1111         * LayoutReloaded/misc/LFC-passing-tests.txt:
1112
1113 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1114
1115         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1116         https://bugs.webkit.org/show_bug.cgi?id=194185
1117
1118         Reviewed by Antti Koivisto.
1119
1120         * LayoutReloaded/misc/LFC-passing-tests.txt:
1121
1122 2018-12-16  Darin Adler  <darin@apple.com>
1123
1124         Convert additional String::format clients to alternative approaches
1125         https://bugs.webkit.org/show_bug.cgi?id=192746
1126
1127         Reviewed by Alexey Proskuryakov.
1128
1129         * WebKitTestRunner/TestController.cpp:
1130         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1131         as an intermediate in code that ultimately constructs a WTF::String.
1132         (WTR::userMediaOriginHash): Use makeString.
1133         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1134         (WTR::TestController::didPerformClientRedirect): Ditto.
1135         (WTR::TestController::didPerformServerRedirect): Ditto.
1136         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1137
1138 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1139
1140         [ews-build] Add unit test to verify builder keys
1141         https://bugs.webkit.org/show_bug.cgi?id=194152
1142
1143         Reviewed by Lucas Forschler.
1144
1145         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1146         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1147
1148 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1149
1150         [LFC] Expand tests coverage (12 new tests -> 787)
1151
1152         Unreviewed test gardening.
1153
1154         * LayoutReloaded/misc/LFC-passing-tests.txt:
1155
1156 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1157
1158         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1159         https://bugs.webkit.org/show_bug.cgi?id=194163
1160
1161         Reviewed by Simon Fraser.
1162
1163         775
1164
1165         * LayoutReloaded/misc/LFC-passing-tests.txt:
1166
1167 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1168
1169         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1170         https://bugs.webkit.org/show_bug.cgi?id=194140
1171         <rdar://problem/47728098>
1172
1173         Reviewed by Tim Horton.
1174
1175         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1176         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1177         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1178
1179         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1180         test to induce an IPC deadlock when presenting a modal alert during touch start.
1181
1182         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1183         * WebKitTestRunner/TestController.cpp:
1184         (WTR::runJavaScriptAlert):
1185
1186         Add a client callback function for running JavaScript alerts.
1187
1188         (WTR::TestController::createOtherPage):
1189         (WTR::TestController::generateContextConfiguration const):
1190
1191         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1192         the fix in this patch.
1193
1194         (WTR::TestController::createWebViewWithOptions):
1195
1196         Plumb TestOptions to generateContextConfiguration.
1197
1198         (WTR::TestController::resetPreferencesToConsistentValues):
1199         (WTR::TestController::resetStateToConsistentValues):
1200         (WTR::updateTestOptionsFromTestHeader):
1201         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1202         (WTR::TestController::handleJavaScriptAlert):
1203         * WebKitTestRunner/TestController.h:
1204         * WebKitTestRunner/TestInvocation.cpp:
1205         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1206         * WebKitTestRunner/TestOptions.h:
1207         (WTR::TestOptions::hasSameInitializationOptions const):
1208
1209 2019-02-01  Chris Dumez  <cdumez@apple.com>
1210
1211         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1212         https://bugs.webkit.org/show_bug.cgi?id=193740
1213         <rdar://problem/47527267>
1214
1215         Reviewed by Alex Christensen.
1216
1217         Add API test coverage.
1218
1219         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1220
1221 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1222
1223         [ews-app] Add display name field to BuilderMapping model
1224         https://bugs.webkit.org/show_bug.cgi?id=194153
1225
1226         Reviewed by Lucas Forschler.
1227
1228         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1229         (BuilderMapping):
1230
1231 2019-02-01  Youenn Fablet  <youenn@apple.com>
1232
1233         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1234         https://bugs.webkit.org/show_bug.cgi?id=194155
1235
1236         Reviewed by Eric Carlson.
1237
1238         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1239         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1240         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1241
1242 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1243
1244         [LFC] Adjust replaced element's intrinsic ratio
1245         https://bugs.webkit.org/show_bug.cgi?id=194154
1246
1247         Reviewed by Antti Koivisto.
1248
1249         761
1250
1251         * LayoutReloaded/misc/LFC-passing-tests.txt:
1252
1253 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1254
1255         [WPE] Show test results in minibrowser
1256         https://bugs.webkit.org/show_bug.cgi?id=194150
1257
1258         Reviewed by Žan Doberšek.
1259
1260         * Scripts/webkitpy/port/wpe.py:
1261         (WPEPort.show_results_html_file):
1262
1263 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1264
1265         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1266         https://bugs.webkit.org/show_bug.cgi?id=194151
1267
1268         Reviewed by Žan Doberšek.
1269
1270         ALT + <- go back
1271         ALT + -> go forward
1272
1273         * MiniBrowser/wpe/main.cpp:
1274         (main):
1275
1276 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1277
1278         [LFC] Set intrinsic size on Layout::Replaced
1279         https://bugs.webkit.org/show_bug.cgi?id=194139
1280
1281         Reviewed by Antti Koivisto.
1282
1283         744
1284
1285         * LayoutReloaded/misc/LFC-passing-tests.txt:
1286
1287 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1288
1289         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1290         https://bugs.webkit.org/show_bug.cgi?id=194146
1291
1292         Reviewed by Xabier Rodriguez-Calvar.
1293
1294         It allows to open relative paths.
1295
1296         * MiniBrowser/wpe/main.cpp:
1297         (main):
1298
1299 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1300
1301         Update flakiness dashboard configuration after recent queue changes
1302         https://bugs.webkit.org/show_bug.cgi?id=194127
1303
1304         Rubber-stamped by Aakash Jain.
1305
1306         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1307
1308         * TestResultServer/static-dashboards/builders.jsonp:
1309
1310 2019-01-31  Youenn Fablet  <youenn@apple.com>
1311
1312         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1313         https://bugs.webkit.org/show_bug.cgi?id=194106
1314         <rdar://problem/47676333>
1315
1316         Reviewed by Ryosuke Niwa.
1317
1318         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1319         (TestWebKitAPI::didFinishNavigation):
1320         (TestWebKitAPI::TEST):
1321         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1322
1323 2019-01-31  Chris Dumez  <cdumez@apple.com>
1324
1325         Page zoom level is lost after a process swap or a crash
1326         https://bugs.webkit.org/show_bug.cgi?id=194105
1327         <rdar://problem/47610781>
1328
1329         Reviewed by Alex Christensen.
1330
1331         Add API test coverage.
1332
1333         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1334         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1335
1336 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1337
1338         Revert r238819 which is unneeded and caused a performance regression.
1339         https://bugs.webkit.org/show_bug.cgi?id=192272
1340         <rdar://problem/46664625>
1341
1342         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1343         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1344         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1345
1346 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1347
1348         Formalize WebKitAdditions mechanism of LoadOptimizer
1349         https://bugs.webkit.org/show_bug.cgi?id=193886
1350         <rdar://problem/47696809>
1351
1352         Reviewed by Brent Fulgham.
1353
1354         * MiniBrowser/MiniBrowser.entitlements:
1355         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1356
1357 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1358
1359         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1360         https://bugs.webkit.org/show_bug.cgi?id=194090
1361
1362         Reviewed by Antti Koivisto.
1363
1364         * LayoutReloaded/misc/LFC-passing-tests.txt:
1365
1366 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1367
1368         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1369         https://bugs.webkit.org/show_bug.cgi?id=194074
1370
1371         Reviewed by Antti Koivisto.
1372
1373         * LayoutReloaded/misc/LFC-passing-tests.txt:
1374
1375 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1376
1377         [LFC][BFC] Add support for block level replaced box.
1378         https://bugs.webkit.org/show_bug.cgi?id=194071
1379
1380         Reviewed by Antti Koivisto.
1381
1382         * LayoutReloaded/misc/LFC-passing-tests.txt:
1383
1384 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1385
1386         Fix WebKitTestRunner's testPath with Windows full paths
1387         https://bugs.webkit.org/show_bug.cgi?id=194012
1388
1389         Reviewed by Alex Christensen.
1390
1391         updateTestOptionsFromTestHeader failed to open test files because
1392         testPath returned wrong file paths. It returned a path "/C:/..."
1393         if a URL "file:///C:/..." was given.
1394
1395         * WebKitTestRunner/TestController.cpp:
1396         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1397
1398 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1399
1400         [WPE] Bump font related dependencies to match the GTK+ port
1401         https://bugs.webkit.org/show_bug.cgi?id=194017
1402
1403         Reviewed by Žan Doberšek.
1404
1405         * wpe/jhbuild.modules:
1406         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1407         * wpe/patches/icudata-stdlibs.patch: Added.
1408
1409 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1410
1411         Enable swipe tests on iOS
1412         https://bugs.webkit.org/show_bug.cgi?id=194076
1413
1414         Reviewed by Geoffrey Garen.
1415
1416         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1417         it causes a debug assertion failure in runUIScript.
1418
1419         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1420         (WTR::UIScriptController::beginBackSwipe):
1421         (WTR::UIScriptController::completeBackSwipe):
1422
1423 2019-01-30  Keith Rollin  <krollin@apple.com>
1424
1425         Use correct printf format specifier
1426         https://bugs.webkit.org/show_bug.cgi?id=194062
1427         <rdar://problem/47686167>
1428
1429         Reviewed by Alexey Proskuryakov.
1430
1431         LayoutTestSpellChecker.mm is trying to format a variable of type
1432         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1433         actually an unsigned long long. Fix this by formatting with %llu.
1434
1435         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1436         (-[LayoutTestTextCheckingResult description]):
1437
1438 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1439
1440         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1441         https://bugs.webkit.org/show_bug.cgi?id=193979
1442
1443         Reviewed by Wenson Hsieh.
1444
1445         Fix the test for iOS. Make the test work with iOS UA string.
1446
1447         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1448
1449 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1450
1451         Replace High Sierra LLINT CLoop bot due to hardware failure
1452         https://bugs.webkit.org/show_bug.cgi?id=194066
1453
1454         Reviewed by Aakash Jain.
1455
1456         * BuildSlaveSupport/build.webkit.org-config/config.json:
1457
1458 2019-01-30  Keith Rollin  <krollin@apple.com>
1459
1460         [NSDragItem init] is unavailable
1461         https://bugs.webkit.org/show_bug.cgi?id=194059
1462         <rdar://problem/47685715>
1463
1464         Reviewed by Wenson Hsieh.
1465
1466         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1467         DumpRenderTree and TestWebKitAPI, which both try to create an
1468         NSDragItem in a manner that invokes this method. Address this by using
1469         -initWithPasteboardWriter instead.
1470
1471         Note that the parameter passed to initWithPasteboardWriter is likely
1472         incorrect. In both cases, the object passed does not conform to
1473         NSPasteboardWriting. However, with this fix, we're no worse off than
1474         before, and can now perform builds with newer compilers and SDKs until
1475         a real fix can be crafted. That work is tracked in
1476         https://bugs.webkit.org/show_bug.cgi?id=194060
1477
1478         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1479         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1480         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1481         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1482
1483 2019-01-30  Daniel Bates  <dabates@apple.com>
1484
1485         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1486         https://bugs.webkit.org/show_bug.cgi?id=192824
1487         <rdar://problem/47100332>
1488
1489         Reviewed by Wenson Hsieh.
1490
1491         Fix a bug where the wrong usage code was used for F13 thru F24.
1492
1493         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1494         (keyCodeForDOMFunctionKey):
1495
1496 2019-01-30  Chris Dumez  <cdumez@apple.com>
1497
1498         Regression(PSON) Load hang can occur on history navigation
1499         https://bugs.webkit.org/show_bug.cgi?id=194030
1500         <rdar://problem/47656939>
1501
1502         Reviewed by Antti Koivisto.
1503
1504         Add API test coverage.
1505
1506         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1507
1508 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1509
1510         [LFC] Expand tests coverage.
1511
1512         Unreviewed test gardening.
1513
1514         * LayoutReloaded/misc/LFC-passing-tests.txt:
1515
1516 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1517
1518         [Flatpak] Add openjpeg support
1519         https://bugs.webkit.org/show_bug.cgi?id=194019
1520
1521         Reviewed by Michael Catanzaro.
1522
1523         * flatpak/org.webkit.CommonModules.yaml:
1524
1525 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1526
1527         Unreviewed, rolling out r240708.
1528         https://bugs.webkit.org/show_bug.cgi?id=194022
1529
1530         It broke WPE build (Requested by KaL on #webkit).
1531
1532         Reverted changeset:
1533
1534         "[WPE] Bump font related dependencies to match the GTK+ port"
1535         https://bugs.webkit.org/show_bug.cgi?id=194017
1536         https://trac.webkit.org/changeset/240708
1537
1538 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1539
1540         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1541         https://bugs.webkit.org/show_bug.cgi?id=194001
1542
1543         Reviewed by Antti Koivisto.
1544
1545         * LayoutReloaded/misc/LFC-passing-tests.txt:
1546
1547 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1548
1549         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1550         https://bugs.webkit.org/show_bug.cgi?id=194020
1551
1552         Reviewed by Antti Koivisto.
1553
1554         * LayoutReloaded/misc/LFC-passing-tests.txt:
1555
1556 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1557
1558         AX: Support color well on iOS
1559         https://bugs.webkit.org/show_bug.cgi?id=194010
1560
1561         Reviewed by Joanmarie Diggs.
1562
1563         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1564         (WTR::AccessibilityUIElement::stringAttributeValue):
1565
1566 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1567
1568         [WPE] Bump font related dependencies to match the GTK+ port
1569         https://bugs.webkit.org/show_bug.cgi?id=194017
1570
1571         Reviewed by Žan Doberšek.
1572
1573         * wpe/jhbuild.modules:
1574         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1575         * wpe/patches/icudata-stdlibs.patch: Added.
1576
1577 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
1578
1579         [Mac] Update window scale API usage
1580         https://bugs.webkit.org/show_bug.cgi?id=193991
1581         rdar://problem/47614795
1582
1583         Reviewed by Tim Horton.
1584
1585         * DumpRenderTree/mac/DumpRenderTree.mm:
1586         (changeWindowScaleIfNeeded):
1587         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1588         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1589         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1590
1591 2019-01-29  Chris Dumez  <cdumez@apple.com>
1592
1593         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
1594         https://bugs.webkit.org/show_bug.cgi?id=193977
1595         <rdar://problem/47643716>
1596
1597         Reviewed by Geoff Garen.
1598
1599         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
1600         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
1601         to the previous provisional committing *before* we make the last load. 
1602
1603         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1604
1605 2019-01-29  Youenn Fablet  <youenn@apple.com>
1606
1607         Adopt new SPI to evaluate server certificate trust
1608         https://bugs.webkit.org/show_bug.cgi?id=193355
1609
1610         Reviewed by Alex Christensen.
1611
1612         Add infrastructure to handle HTTPS server trust evaluation testing.
1613
1614         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1615         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1616         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1617         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1618         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1619         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1620         * WebKitTestRunner/TestController.cpp:
1621         (WTR::TestController::resetPreferencesToConsistentValues):
1622         (WTR::TestController::didReceiveAuthenticationChallenge):
1623         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1624         * WebKitTestRunner/TestController.h:
1625         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
1626         * WebKitTestRunner/TestInvocation.cpp:
1627         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1628         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1629         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
1630
1631 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1632
1633         [ews-build] Add build step to print bot Configuration
1634         https://bugs.webkit.org/show_bug.cgi?id=193887
1635
1636         Reviewed by Lucas Forschler.
1637
1638         * BuildSlaveSupport/ews-build/steps.py:
1639         (PrintConfiguration): Build step to print configuration.
1640         * BuildSlaveSupport/ews-build/factories.py:
1641
1642 2019-01-29  Chris Dumez  <cdumez@apple.com>
1643
1644         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1645         https://bugs.webkit.org/show_bug.cgi?id=193967
1646         <rdar://problem/47635348>
1647
1648         Reviewed by Alex Christensen.
1649
1650         Add API test coverage.
1651
1652         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1653         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1654
1655 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1656
1657         [ews-app] Handle incoming results data
1658         https://bugs.webkit.org/show_bug.cgi?id=193973
1659
1660         Reviewed by Lucas Forschler.
1661
1662         * BuildSlaveSupport/ews-app/ews/views/results.py:
1663
1664 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1665
1666         [ews-app] Make the results url generic
1667         https://bugs.webkit.org/show_bug.cgi?id=193928
1668
1669         Reviewed by Lucas Forschler.
1670
1671         * BuildSlaveSupport/ews-app/ews/urls.py:
1672
1673 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1674
1675         [ews-build] Configure buildbot to send events to ews-app
1676         https://bugs.webkit.org/show_bug.cgi?id=193968
1677
1678         Reviewed by Lucas Forschler.
1679
1680         * BuildSlaveSupport/ews-build/events.py: Added.
1681         * BuildSlaveSupport/ews-build/master.cfg:
1682
1683 2019-01-29  Keith Rollin  <krollin@apple.com>
1684
1685         Add .xcfilelists to Run Script build phases
1686         https://bugs.webkit.org/show_bug.cgi?id=193792
1687         <rdar://problem/47201785>
1688
1689         Reviewed by Alex Christensen.
1690
1691         As part of supporting XCBuild, update the necessary Run Script build
1692         phases in their Xcode projects to refer to their associated
1693         .xcfilelist files.
1694
1695         Note that the addition of these files bumps the Xcode project version
1696         number to something that's Xcode 10 compatible. This change means that
1697         older versions of the Xcode IDE can't read these projects. Nor can it
1698         fully load workspaces that refer to these projects (the updated
1699         projects are shown as non-expandable placeholders). `xcodebuild` can
1700         still build these projects; it's just that the IDE can't open them.
1701
1702         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1703         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1704
1705 2019-01-29  John Wilander  <wilander@apple.com>
1706
1707         Add data abstraction and validation for Ad Click Attribution
1708         https://bugs.webkit.org/show_bug.cgi?id=193916
1709         <rdar://problem/47603481>
1710
1711         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1712
1713         Ad click attribution has two steps. First, the storage of an ad
1714         campaign ID for a click that takes the user to a destination
1715         site. Second, a conversion on the destination site that can be
1716         attributed to the ad click.
1717
1718         This patch adds a class that represents a request for ad click
1719         attribution. Validation makes sure that the bits of entropy
1720         reported through this mechanism is limited.
1721
1722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1723         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1724         (TestWebKitAPI::TEST):
1725
1726 2019-01-29  Chris Dumez  <cdumez@apple.com>
1727
1728         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1729         https://bugs.webkit.org/show_bug.cgi?id=193932
1730         <rdar://problem/47598947>
1731
1732         Reviewed by Brady Eidson.
1733
1734         Add API test coverage.
1735
1736         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1737
1738 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1739
1740         Adding new passing LFC tests.
1741
1742         Unreviewed test gardening.
1743
1744         * LayoutReloaded/misc/LFC-passing-tests.txt:
1745
1746 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1747
1748         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1749         https://bugs.webkit.org/show_bug.cgi?id=193964
1750
1751         Reviewed by Antti Koivisto.
1752
1753         * LayoutReloaded/misc/LFC-passing-tests.txt:
1754
1755 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1756
1757         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1758         https://bugs.webkit.org/show_bug.cgi?id=193954
1759
1760         Reviewed by Antti Koivisto.
1761
1762         * LayoutReloaded/misc/LFC-passing-tests.txt:
1763
1764 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1765
1766         WebDriver: add support for running subtests
1767         https://bugs.webkit.org/show_bug.cgi?id=193904
1768
1769         Reviewed by Michael Catanzaro.
1770
1771         pytest already supports it by passing test.py::subtest, so we can do the same.
1772
1773         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1774         (get_item_name): Made this global.
1775         (CollectRecorder.__init__): Receive the parameter to ignore.
1776         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1777         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1778         (collect): Add parameter to ignore.
1779         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1780         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1781         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1782         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1783         (WebDriverTestRunnerSelenium.run): Ditto.
1784         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1785         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1786         (WebDriverTestRunnerW3C.run): Ditto.
1787
1788 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1789
1790         User agent string override for navigator.userAgent should be site specific quirks
1791         https://bugs.webkit.org/show_bug.cgi?id=193950
1792
1793         Reviewed by Brent Fulgham.
1794
1795         Updated per the _WKWebsitePolicies rename.
1796
1797         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1798         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1799
1800 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1801
1802         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1803         https://bugs.webkit.org/show_bug.cgi?id=193941
1804
1805         Reviewed by Alex Christensen.
1806
1807         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1808         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1809         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1810         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1811         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1812         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1813         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1814         * TestWebKitAPI/Tests/WTF/Time.cpp:
1815         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1816         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1817         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1818         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1819
1820 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1821
1822         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1823
1824         * Scripts/webkitpy/common/config/contributors.json:
1825
1826 2019-01-28  Andy Estes  <aestes@apple.com>
1827
1828         [watchOS] Enable Parental Controls content filtering
1829         https://bugs.webkit.org/show_bug.cgi?id=193939
1830         <rdar://problem/46641912>
1831
1832         Reviewed by Ryosuke Niwa.
1833
1834         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1835
1836 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1837
1838         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1839         <https://webkit.org/b/193884>
1840
1841         Reviewed by Jiewen Tan.
1842
1843         * Scripts/webkitpy/style/checkers/cpp.py:
1844         (check_language): Add LocalAuthentication to
1845         `frameworks_with_soft_links`.
1846
1847 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1848
1849         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1850         https://bugs.webkit.org/show_bug.cgi?id=193891
1851
1852         Reviewed by Ross Kirsling.
1853
1854         There were three problems in window sizes of WebView and the host window.
1855         1. The sizes of pixel image output were incorrect.
1856         2. The host window is going to appear after window.resize was invoked.
1857         3. window.resize resized only the host window, not WebView.
1858
1859         This change solves them with a following approach.
1860         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1861         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1862            as well as DumpRenderTree in order to match the client area and the window area.
1863         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1864         d. PlatformWebView::setWindowFrame changes both window sizes.
1865         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1866
1867         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1868         (WTR::PlatformWebView::PlatformWebView): Create the host window
1869         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1870         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1871         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1872
1873 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1874
1875         [ews-app] Add method to save Step data to database
1876         https://bugs.webkit.org/show_bug.cgi?id=193890
1877
1878         Reviewed by Lucas Forschler.
1879
1880         * BuildSlaveSupport/ews-app/ews/models/step.py:
1881         (Step.save_step): Method to save step data.
1882         (Step.update_step): Method to update step data.
1883         (Step.get_existing_step): Method to fetch existing step from database.
1884         (Step.is_valid_result): Method to validate valid step result.
1885
1886 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1887
1888         [ews-app] Add method to save Build data to database
1889         https://bugs.webkit.org/show_bug.cgi?id=193735
1890
1891         Reviewed by Lucas Forschler.
1892
1893         * BuildSlaveSupport/ews-app/ews/models/build.py:
1894         (Build.save_build): Method to save build information to database.
1895         (Build.get_existing_build): Method to fetch existing build from database.
1896         (Build.is_valid_result): Method to validate build result.
1897         * BuildSlaveSupport/ews-app/ews/common/util.py:
1898         (is_valid_int_id): Method to validate valid id.
1899
1900 2019-01-28  Chris Dumez  <cdumez@apple.com>
1901
1902         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1903         https://bugs.webkit.org/show_bug.cgi?id=193915
1904         <rdar://problem/47560907>
1905
1906         Reviewed by Alex Christensen.
1907
1908         Add API test coverage.
1909
1910         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1911
1912 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1913
1914         [ews-app] Rename id variables
1915         https://bugs.webkit.org/show_bug.cgi?id=193883
1916
1917         Reviewed by Lucas Forschler.
1918
1919         * BuildSlaveSupport/ews-app/ews/models/build.py:
1920         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1921         * BuildSlaveSupport/ews-app/ews/models/step.py:
1922         * BuildSlaveSupport/ews-app/ews/urls.py:
1923         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1924         * BuildSlaveSupport/ews-app/ews/views/results.py:
1925         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1926
1927 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1928
1929         [ews-app] Allow certain fields to be empty
1930         https://bugs.webkit.org/show_bug.cgi?id=193892
1931
1932         Reviewed by Lucas Forschler.
1933
1934         * BuildSlaveSupport/ews-app/ews/models/build.py:
1935         * BuildSlaveSupport/ews-app/ews/models/step.py:
1936
1937 2019-01-28  Rob Buis  <rbuis@igalia.com>
1938
1939         Update MIME type parser
1940         https://bugs.webkit.org/show_bug.cgi?id=180526
1941
1942         Reviewed by Frédéric Wang.
1943
1944         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1945         (TestWebKitAPI::TEST):
1946
1947 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1948
1949         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1950         https://bugs.webkit.org/show_bug.cgi?id=193896
1951
1952         Reviewed by Antti Koivisto.
1953
1954         * LayoutReloaded/misc/LFC-passing-tests.txt:
1955
1956 2018-12-15  Darin Adler  <darin@apple.com>
1957
1958         Replace many uses of String::format with more type-safe alternatives
1959         https://bugs.webkit.org/show_bug.cgi?id=192742
1960
1961         Reviewed by Mark Lam.
1962
1963         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1964         (WTR::cacheTestRunnerCallback): Use makeString.
1965         * WebKitTestRunner/TestController.cpp:
1966         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1967         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1968
1969 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1970
1971         Use a load optimizer for some sites
1972         https://bugs.webkit.org/show_bug.cgi?id=193881
1973         <rdar://problem/46325455>
1974
1975         Reviewed by Brent Fulgham.
1976
1977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1978         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1979
1980 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1981
1982         AX: Introduce a static accessibility tree
1983         https://bugs.webkit.org/show_bug.cgi?id=193348
1984         <rdar://problem/47203295>
1985
1986         Reviewed by Ryosuke Niwa.
1987
1988         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1989
1990 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1991
1992         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1993         https://bugs.webkit.org/show_bug.cgi?id=193867
1994
1995         Reviewed by Antti Koivisto.
1996
1997         * LayoutReloaded/misc/LFC-passing-tests.txt:
1998
1999 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2000
2001         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2002         https://bugs.webkit.org/show_bug.cgi?id=193865
2003
2004         Reviewed by Antti Koivisto.
2005
2006         * LayoutReloaded/misc/LFC-passing-tests.txt:
2007
2008 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2009
2010         Need a mechanism to override navigator.userAgent
2011         https://bugs.webkit.org/show_bug.cgi?id=193762
2012         <rdar://problem/47504939>
2013
2014         Reviewed by Brent Fulgham.
2015
2016         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2017
2018         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2019         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2020         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2021
2022 2019-01-25  Dean Jackson  <dino@apple.com>
2023
2024         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2025         https://bugs.webkit.org/show_bug.cgi?id=193831
2026         <rdar://problem/47399263>
2027
2028         Reviewed by Chris Dumez.
2029
2030         Two new tests that exercise cross-origin and same-origin System
2031         Previews.
2032
2033         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2034
2035 2019-01-25  Keith Rollin  <krollin@apple.com>
2036
2037         Update Xcode projects with "Check .xcfilelists" build phase
2038         https://bugs.webkit.org/show_bug.cgi?id=193790
2039         <rdar://problem/47201374>
2040
2041         Reviewed by Alex Christensen.
2042
2043         Support for XCBuild includes specifying inputs and outputs to various
2044         Run Script build phases. These inputs and outputs are specified as
2045         .xcfilelist files. Once created, these .xcfilelist files need to be
2046         kept up-to-date. In order to check that they are up-to-date or not,
2047         add an Xcode build step that invokes an external script that performs
2048         the checking. If the .xcfilelists are found to be out-of-date, update
2049         them, halt the build, and instruct the developer to restart the build
2050         with up-to-date files.
2051
2052         At this time, the checking and regenerating is performed only if the
2053         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2054         who want to use this facility can set this variable and test out the
2055         checking/regenerating. Once it seems like there are no egregious
2056         issues that upset a developer's workflow, we'll unconditionally enable
2057         this facility.
2058
2059         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2060         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2061         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2062         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2063
2064 2019-01-25  Keith Rollin  <krollin@apple.com>
2065
2066         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2067         https://bugs.webkit.org/show_bug.cgi?id=193781
2068         <rdar://problem/47201153>
2069
2070         Reviewed by Alex Christensen.
2071
2072         Part of generating the .xcfilelists used as part of adopting XCBuild
2073         includes running `make DerivedSources.make` from a standalone script.
2074         It’s important for this invocation to have the same environment as
2075         when the actual build invokes `make DerivedSources.make`. If the
2076         environments are different, then the two invocations will provide
2077         different results. In order to get the same environment in the
2078         standalone script, have the script launch xcodebuild targeting the
2079         "Apply Configuration to XCFileLists" build target, which will then
2080         re-invoke our standalone script. The script is now running again, this
2081         time in an environment with all workspace, project, target, xcconfig
2082         and other environment variables established.
2083
2084         The "Apply Configuration to XCFileLists" build target accomplishes
2085         this task via a small embedded shell script that consists only of:
2086
2087             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2088
2089         The process that invokes "Apply Configuration to XCFileLists" first
2090         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2091         evaluated and exports it into the shell environment. When xcodebuild
2092         is invoked, it inherits the value of this variable and can `eval` the
2093         contents of that variable. Our external standalone script can then set
2094         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2095         of command-line parameters needed to restart itself in the appropriate
2096         state.
2097
2098         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2099         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2100
2101 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2102
2103         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2104         https://bugs.webkit.org/show_bug.cgi?id=193802
2105         <rdar://problem/46010580>
2106
2107         Reviewed by Andy Estes.
2108
2109         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2110         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2111         (TEST):
2112
2113 2019-01-25  Daniel Bates  <dabates@apple.com>
2114
2115         [iOS] uiController.keyDown() does not translate Control modified key
2116         https://bugs.webkit.org/show_bug.cgi?id=192898
2117
2118         Reviewed by Wenson Hsieh.
2119
2120         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2121         key translation, as applicable. Among other cases, key translation occurs when performing
2122         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2123         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2124         human pressing down and releasing key(s) using a hardware keyboard.
2125
2126         * WebKitTestRunner/ios/HIDEventGenerator.h:
2127         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2128         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2129
2130         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2131         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2132         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2133         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2134         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2135         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2136         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2137         (-[HIDEventGenerator longPress:completionBlock:]):
2138         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2139         Update code for above renaming.
2140
2141         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2142         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2143
2144         (-[HIDEventGenerator keyDown:]): Added.
2145         (-[HIDEventGenerator keyUp:]): Added.
2146         (-[HIDEventGenerator keyPress:completionBlock:]):
2147         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2148         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2149         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2150         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2151         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2152         (WTR::parseModifier): Deleted.
2153
2154 2019-01-25  Keith Rollin  <krollin@apple.com>
2155
2156         Complete the implementation of generate-xcfilelists
2157         https://bugs.webkit.org/show_bug.cgi?id=193782
2158
2159         Reviewed by Alex Christensen.
2160
2161         A preliminary version of generate-xcfilelists was added in r238008.
2162         This patch updates that script in order to:
2163
2164         - Support checking of .xcfilelists
2165         - Perform better execution of `make DerivedSources.make` by
2166           relaunching generate-xcfilelists under xcodebuild
2167         - Support incremental generation and checking of .xcfilelists
2168         - Support supplementary .xcfilelists files from WebKitAdditions
2169         - Support being wrapped by parallel version of generate-xcfilelists in
2170           Internal that adds support for (re)generating WebKit projects in
2171           that repo.
2172         - Support builds that have been performed in WebKitBuild as well as
2173           ~/Library/Developer/code/DerivedData
2174         - Increase robustness and debugging facilities.
2175
2176         * Scripts/generate-xcfilelists:
2177
2178 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2179
2180         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2181         https://bugs.webkit.org/show_bug.cgi?id=193297
2182         <rdar://problem/47158841>
2183
2184         Unreviewed test case fix.
2185
2186         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2187         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2188
2189         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2190         (TEST):
2191
2192 2019-01-25  Keith Rollin  <krollin@apple.com>
2193
2194         Update existing .xcfilelists
2195         https://bugs.webkit.org/show_bug.cgi?id=193791
2196         <rdar://problem/47201706>
2197
2198         Reviewed by Alex Christensen.
2199
2200         Many .xcfilelist files were added in r238824 in order to support
2201         XCBuild. Update these with recent changes to the set of build files
2202         and with the current generate-xcfilelist script.
2203
2204         * DumpRenderTree/DerivedSources-input.xcfilelist:
2205         * DumpRenderTree/DerivedSources-output.xcfilelist:
2206         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2207         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2208
2209 2019-01-25  Keith Rollin  <krollin@apple.com>
2210
2211         Fix missing dependencies in extract-dependencies-from-makefile
2212         https://bugs.webkit.org/show_bug.cgi?id=193783
2213         <rdar://problem/47201571>
2214
2215         Reviewed by Alex Christensen.
2216
2217         The extract-dependencies-from-makefile script generates .xcfilelists
2218         for XCBuild by invoking a makefile in --debug mode, parsing the
2219         dependency information in the output, and extracting information
2220         regarding targets and dependents. However, the way `make` emits this
2221         dependency information is not rigorous, and so we need to determine
2222         what lines to look for and parse by trial and error. This approach
2223         didn't coriginally atch all the information we needed to collect, so
2224         update the script to look for the additional lines we now know to look
2225         for.
2226
2227         * Scripts/extract-dependencies-from-makefile:
2228         (Parser):
2229         (Parser.addTarget):
2230         (Parser.addPrereq):
2231         (Parser.doParse):
2232
2233 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2234
2235         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2236         https://bugs.webkit.org/show_bug.cgi?id=193297
2237         <rdar://problem/47158841>
2238
2239         Reviewed by Alex Christensen.
2240
2241         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2242             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2243         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2244         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2245         activating the message used to trigger the callback when it is set.
2246
2247 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2248
2249         WKWebView.goBack should reload if there is a safe browsing warning
2250         https://bugs.webkit.org/show_bug.cgi?id=193805
2251         <rdar://problem/46908216>
2252
2253         Reviewed by Geoff Garen.
2254
2255         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2256         (+[Simple3LookupContext sharedLookupContext]):
2257         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2258         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2259         (TEST):
2260
2261 2019-01-25  Chris Dumez  <cdumez@apple.com>
2262
2263         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2264         https://bugs.webkit.org/show_bug.cgi?id=193788
2265         <rdar://problem/47531231>
2266
2267         Reviewed by Alex Christensen.
2268
2269         Add API test coverage.
2270
2271         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2272         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2273
2274 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2275
2276         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2277         https://bugs.webkit.org/show_bug.cgi?id=193771
2278
2279         Unreviewed infrastructure fix.
2280
2281         * Scripts/webkitpy/port/darwin.py:
2282         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2283
2284 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2285
2286         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2287
2288 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2289
2290         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2291
2292         * Scripts/webkitpy/common/config/contributors.json:
2293
2294 2019-01-25  Chris Dumez  <cdumez@apple.com>
2295
2296         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2297         https://bugs.webkit.org/show_bug.cgi?id=193779
2298         <rdar://problem/46170903>
2299
2300         Reviewed by Antti Koivisto.
2301
2302         Add API test that quickly navigates forward to a previous process without waiting for it to
2303         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2304         the process' previous page when reconnecting the it for the forward navigation.
2305
2306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2307
2308 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2309
2310         Need a way for JavaScript (or bundle) code to participate in undo
2311         https://bugs.webkit.org/show_bug.cgi?id=190009
2312         <rdar://problem/44807048>
2313
2314         Reviewed by Ryosuke Niwa.
2315
2316         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2317         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2318
2319         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2320         (WTR::UIScriptController::lastUndoLabel const):
2321         (WTR::UIScriptController::firstRedoLabel const):
2322         (WTR::UIScriptController::platformUndoManager const):
2323         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2324         (WTR::UIScriptController::lastUndoLabel const):
2325         (WTR::UIScriptController::firstRedoLabel const):
2326         (WTR::UIScriptController::platformUndoManager const):
2327         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2328         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2329         (WTR::UIScriptController::lastUndoLabel const):
2330         (WTR::UIScriptController::firstRedoLabel const):
2331         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2332         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2333         (WTR::UIScriptController::lastUndoLabel const):
2334         (WTR::UIScriptController::firstRedoLabel const):
2335         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2336         (WTR::UIScriptController::platformUndoManager const):
2337         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2338         (WTR::UIScriptController::platformUndoManager const):
2339
2340 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2341
2342         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2343         https://bugs.webkit.org/show_bug.cgi?id=193824
2344
2345         Reviewed by Antti Koivisto.
2346
2347         * LayoutReloaded/misc/LFC-passing-tests.txt:
2348
2349 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2350
2351         Update macOS JSC bot configurations
2352         https://bugs.webkit.org/show_bug.cgi?id=193739
2353
2354         Reviewed by Alexey Proskuryakov.
2355
2356         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2358         (BubbleQueueServer): Move JSC EWS to Mojave section.
2359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2360         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2361         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2362
2363 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2364
2365         [Win][WebKitTestRunner] Implement EventSenderProxy
2366         https://bugs.webkit.org/show_bug.cgi?id=193755
2367
2368         Reviewed by Don Olmstead.
2369
2370         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2371         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2372         (WTR::EventSenderProxy::dispatchMessage):
2373         (WTR::EventSenderProxy::EventSenderProxy):
2374         (WTR::EventSenderProxy::mouseDown):
2375         (WTR::EventSenderProxy::mouseUp):
2376         (WTR::EventSenderProxy::mouseMoveTo):
2377         (WTR::EventSenderProxy::mouseScrollBy):
2378         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2379
2380 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2381
2382         Unreviewed fix for API test failure after r240437.
2383
2384         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2385
2386         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2387
2388 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2389
2390         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2391         https://bugs.webkit.org/show_bug.cgi?id=193787
2392         <rdar://problem/47497634>
2393
2394         Reviewed by Alexey Proskuryakov.
2395
2396         * Scripts/webkitdirs.pm:
2397         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2398
2399 2019-01-24  Truitt Savell  <tsavell@apple.com>
2400
2401         Unreviewed, rolling out r240446.
2402
2403         Casued 5 API failures
2404
2405         Reverted changeset:
2406
2407         "Activate the WebResourceLoadStatisticsStore in the
2408         NetworkProcess and deactivate it in the UIProcess."
2409         https://bugs.webkit.org/show_bug.cgi?id=193297
2410         https://trac.webkit.org/changeset/240446
2411
2412 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2413
2414         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2415         https://bugs.webkit.org/show_bug.cgi?id=193741
2416         <rdar://problem/47135030>
2417
2418         Reviewed by Antti Koivisto and Simon Fraser.
2419
2420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2421         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2422         (TestWebKitAPI::TEST):
2423
2424 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2425
2426         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2427         https://bugs.webkit.org/show_bug.cgi?id=193297
2428         <rdar://problem/47158841>
2429
2430         Reviewed by Alex Christensen.
2431
2432         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2433         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2434         activating the message used to trigger the callback when it is set.
2435
2436 2019-01-24  John Wilander  <wilander@apple.com>
2437
2438         Add Ad Click Attribution as an internal/experimental feature
2439         https://bugs.webkit.org/show_bug.cgi?id=193685
2440         <rdar://problem/47450399>
2441
2442         Reviewed by Brent Fulgham.
2443
2444         Added test option adClickAttributionEnabled.
2445
2446         * DumpRenderTree/TestOptions.cpp:
2447         (TestOptions::TestOptions):
2448         * DumpRenderTree/TestOptions.h:
2449         * DumpRenderTree/mac/DumpRenderTree.mm:
2450         (setWebPreferencesForTestOptions):
2451
2452 2019-01-24  Antti Koivisto  <antti@apple.com>
2453
2454         [PSON] Flash on back navigation on Mac
2455         https://bugs.webkit.org/show_bug.cgi?id=193716
2456         <rdar://problem/47148458>
2457
2458         Reviewed by Chris Dumez.
2459
2460         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2461
2462         Closing of the previous page is delayed so waiting for didFinishNavigation is
2463         not sufficient to guarantee we have received all the messages. Wait for them.
2464
2465 2019-01-24  Chris Dumez  <cdumez@apple.com>
2466
2467         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2468         https://bugs.webkit.org/show_bug.cgi?id=193761
2469         <rdar://problem/47456405>
2470
2471         Reviewed by Alex Christensen.
2472
2473         Add API test coverage.
2474
2475         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2476
2477 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2478
2479         webkitpy: Missing PID in crashlog name should not be fatal
2480         https://bugs.webkit.org/show_bug.cgi?id=193771
2481
2482         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2483         of raising an exception.
2484
2485         Reviewed by Lucas Forschler.
2486
2487         * Scripts/webkitpy/port/darwin.py:
2488         (DarwinPort._merge_crash_logs):
2489
2490 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2491
2492         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2493         https://bugs.webkit.org/show_bug.cgi?id=193746
2494
2495         Reviewed by Youenn Fablet.
2496
2497         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2498         so we'd best just not call it.
2499
2500         * Scripts/webkitpy/w3c/test_exporter.py:
2501         (WebPlatformTestExporter.create_branch_with_patch):
2502
2503 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2504
2505         Move FileSystem to WTF
2506         https://bugs.webkit.org/show_bug.cgi?id=193602
2507
2508         Reviewed by Yusuke Suzuki.
2509
2510         * DumpRenderTree/win/DumpRenderTree.cpp:
2511         * TestWebKitAPI/CMakeLists.txt:
2512         * TestWebKitAPI/PlatformGTK.cmake:
2513         * TestWebKitAPI/PlatformJSCOnly.cmake:
2514         * TestWebKitAPI/PlatformPlayStation.cmake:
2515         * TestWebKitAPI/PlatformWPE.cmake:
2516         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2517         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2518         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2519         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2520         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2521         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2522         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2523         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2524         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2525         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2526
2527 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2528
2529         [WPE] Remove hard dependency on subprocess32 for the API tests
2530
2531         Rubber-stamped by Carlos Garcia Campos.
2532
2533         * glib/api_test_runner.py:
2534         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2535         its presence only when running WPEQt tests.
2536
2537 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2538
2539         [GLIB] Expose JavaScriptCore options in GLib public API
2540         https://bugs.webkit.org/show_bug.cgi?id=188742
2541
2542         Reviewed by Michael Catanzaro.
2543
2544         Add a test for the new API.
2545
2546         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2547         (testsJSCOptions):
2548         (main):
2549
2550 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2551
2552         [GTK][WPE] Support JPEG 2000 images
2553         https://bugs.webkit.org/show_bug.cgi?id=186272
2554
2555         Reviewed by Žan Doberšek.
2556
2557         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2558
2559         * gtk/jhbuild.modules:
2560         * wpe/jhbuild.modules:
2561
2562 2019-01-23  David Kilzer  <ddkilzer@apple.com>
2563
2564         check-webkit-style should warn when using soft-linking macros in a header
2565         <https://webkit.org/b/193750>
2566
2567         Reviewed by Darin Adler.
2568
2569         * Scripts/webkitpy/style/checkers/cpp.py:
2570         (check_language): Add softlink/header check by refactoring the
2571         softlink/framework check.
2572         (CppChecker): Enable softlink/header check by default.
2573         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2574         (CppStyleTest.test_softlink_framework): Rename from
2575         CppStyleTest.test_softlink() and change test framework name in
2576         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
2577         files. Set file_name for macros that only appear in headers.
2578         (CppStyleTest.test_softlink_header): Add tests for using
2579         soft-link macros in headers.
2580
2581 2019-01-23  Chris Dumez  <cdumez@apple.com>
2582
2583         Deprecate API to limit the maximum number of WebProcesses
2584         https://bugs.webkit.org/show_bug.cgi?id=193725
2585         <rdar://problem/47464879>
2586
2587         Reviewed by Geoff Garen.
2588
2589         Update existing API tests to stop using deprecated API.
2590
2591         * MiniBrowser/mac/AppDelegate.m:
2592         (defaultConfiguration):
2593         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2594         (TestWebKitAPI::TEST):
2595         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
2596         (TestWebKitAPI::TEST):
2597         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2598         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2599         (TEST):
2600         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2601         (TEST):
2602
2603 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2604
2605         [ews-app] Rename ews model buildermappings to buildermapping
2606         https://bugs.webkit.org/show_bug.cgi?id=193729
2607
2608         Reviewed by Lucas Forschler.
2609
2610         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
2611         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
2612         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
2613
2614 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2615
2616         [ews-app] Rename ews model steps to step
2617         https://bugs.webkit.org/show_bug.cgi?id=193697
2618
2619         Reviewed by Lucas Forschler.
2620
2621         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
2622         (Step): Renamed Steps to Step.
2623
2624 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
2625
2626         Clean up IndexedDB files between tests
2627         https://bugs.webkit.org/show_bug.cgi?id=192796
2628         <rdar://problem/46824999>
2629
2630         Reviewed by Geoffrey Garen.
2631
2632         * DumpRenderTree/mac/DumpRenderTree.mm:
2633         (runTest):
2634         * WebKitTestRunner/TestController.cpp:
2635         (WTR::TestController::resetStateToConsistentValues):
2636         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
2637         (WTR::RemoveAllIndexedDatabasesCallback):
2638         (WTR::TestController::ClearIndexedDatabases):
2639         * WebKitTestRunner/TestController.h:
2640         * WebKitTestRunner/TestInvocation.cpp:
2641         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2642
2643 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
2644
2645         [ews-app] Rename ews model Builds to Build
2646         https://bugs.webkit.org/show_bug.cgi?id=193695
2647
2648         Reviewed by Lucas Forschler.
2649
2650         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2651         (Build): Renamed Builds to Build.
2652
2653 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2654
2655         webkitpy: Wait longer when launching WebKitTestRunner
2656         https://bugs.webkit.org/show_bug.cgi?id=193734
2657
2658         Reviewed by Aakash Jain.
2659
2660         * Scripts/webkitpy/port/simulator_process.py:
2661         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2662
2663 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2664
2665         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2666         https://bugs.webkit.org/show_bug.cgi?id=193182
2667         <rdar://problem/47452154>
2668
2669         Reviewed by Tim Horton.
2670
2671         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2672         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2673         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2674
2675         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2676         preventing later tests from recognizing gestures.
2677
2678         * WebKitTestRunner/ios/TestControllerIOS.mm:
2679         (WTR::TestController::platformResetStateToConsistentValues):
2680
2681         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2682
2683 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2684
2685         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2686         https://bugs.webkit.org/show_bug.cgi?id=193722
2687         <rdar://problem/47481475>
2688
2689         Reviewed by Lucas Forschler.
2690
2691         iPhone and iPad ports should both use the iOS config.
2692
2693         * Scripts/webkitpy/port/ios_simulator.py:
2694         (IPhoneSimulatorPort.__init__):
2695         (IPadSimulatorPort.__init__):
2696
2697 2019-01-23  Rob Buis  <rbuis@igalia.com>
2698
2699         Update MIME type parser
2700         https://bugs.webkit.org/show_bug.cgi?id=180526
2701
2702         Reviewed by Frédéric Wang.
2703
2704         Add unit tests for both parse modes of ParsedContentType.
2705
2706         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2707         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2708         (TestWebKitAPI::TEST):
2709
2710 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2711
2712         [ews-app] fetch loop should not stop on network issues
2713         https://bugs.webkit.org/show_bug.cgi?id=193666
2714
2715         Reviewed by Lucas Forschler.
2716
2717         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2718         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2719
2720 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2721
2722         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2723         https://bugs.webkit.org/show_bug.cgi?id=189165
2724         <rdar://problem/47433765>
2725
2726         Reviewed by Tim Horton.
2727
2728         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2729         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2730         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2731         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2732         would make its way to the UI process by the time the layer tree commit is finished.
2733
2734         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2735         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2736         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2737         will fail because it asks for -_autofillContext too early.
2738
2739         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2740         is handled in the UI process.
2741
2742         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2743
2744         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2745         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2746         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2747         input session.
2748
2749         (-[AutofillTestView textInputHasAutofillContext]):
2750
2751         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2752
2753         * TestWebKitAPI/cocoa/TestWKWebView.h:
2754         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2755         (nextInputSessionChangeCount):
2756
2757         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2758         This includes changing the focused element from one to another.
2759
2760         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2761         (-[TestWKWebView didStartFormControlInteraction]):
2762         (-[TestWKWebView didEndFormControlInteraction]):
2763         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2764
2765         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2766         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2767         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2768         that doesn't require an input session to one that doesn't.
2769
2770 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2771
2772         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2773         <https://webkit.org/b/193676>
2774
2775         Reviewed by Alexey Proskuryakov.
2776
2777         * Scripts/webkitpy/style/checkers/cpp.py:
2778         (check_member_initialization_list):
2779         - Don't report missing whitespace around colon if the colon at
2780           the start of the line is formatted correctly.
2781         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2782         (WebKitStyleTest.test_member_initialization_list):
2783         - Add a test for a missing permutation of existing tests.
2784         - Add a test this false-positive.
2785         - Add blank lines between subtests to make them easier to read.
2786
2787 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2788
2789         [build.webkit.org] Unit-test failure after r237113
2790         https://bugs.webkit.org/show_bug.cgi?id=193669
2791
2792         Reviewed by Michael Catanzaro.
2793
2794         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2795         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2796         multiple or zero flags.
2797
2798 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2799
2800         Cache bytecode to disk
2801         https://bugs.webkit.org/show_bug.cgi?id=192782
2802         <rdar://problem/46084932>
2803
2804         Reviewed by Keith Miller.
2805
2806         Add test helper to execute bytecode-cache tests: it executes each test
2807         twice, the first with JSC_diskCachePath set to a temporary directory
2808         and second with JSC_forceDiskCache=true (in addition to the cache path)
2809         to guarantee that only the disk cache is being used and no new
2810         UnlinkedCodeBlocks are being created.
2811
2812         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2813         * Scripts/run-jsc-stress-tests:
2814
2815 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2816
2817         [css-logical] Implement flow-relative margin, padding and border shorthands
2818         https://bugs.webkit.org/show_bug.cgi?id=188697
2819
2820         Reviewed by Simon Fraser and Antti Koivisto.
2821
2822         * DumpRenderTree/TestOptions.cpp:
2823         (TestOptions::TestOptions):
2824         * DumpRenderTree/TestOptions.h:
2825         * DumpRenderTree/mac/DumpRenderTree.mm:
2826         (setWebPreferencesForTestOptions):
2827         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2828
2829         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2830         (JSONCSSPropertiesChecker.check_codegen_properties):
2831         Allow CSS property definitions to have a 'runtime-flag' parameter which
2832         disables the property when the specified runtime flag is disabled.
2833
2834 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2835
2836         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2837         https://bugs.webkit.org/show_bug.cgi?id=193643
2838
2839         Reviewed by Michael Catanzaro.
2840
2841         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2842         * wpe/jhbuild.modules: Ditto.
2843
2844 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2845
2846         [LFC][Floats] Take float top position into account when computing containing block height.
2847         https://bugs.webkit.org/show_bug.cgi?id=193655
2848
2849         Reviewed by Antti Koivisto.
2850
2851         * LayoutReloaded/misc/LFC-passing-tests.txt:
2852
2853 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2854
2855         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2856         <https://webkit.org/b/193645>
2857         <rdar://problem/47421574>
2858
2859         Reviewed by Alex Christensen.
2860
2861         - Now checks for local soft-linking of all frameworks that have
2862           their own *SoftLinking.{cpp,h,mm} files.
2863         - Changes softlink/uikit warning to softlink/framework.
2864
2865         * Scripts/webkitpy/style/checkers/cpp.py:
2866         (check_language):
2867         (CppChecker):
2868         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2869         (CppStyleTest):
2870
2871 2019-01-20  Saam Barati  <sbarati@apple.com>
2872
2873         Rollout r240210: It broke tests on iOS
2874         https://bugs.webkit.org/show_bug.cgi?id=193640
2875
2876         Unreviewed.
2877
2878         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2879         * Scripts/run-jsc-stress-tests:
2880
2881 2019-01-20  chris fleizach  <cfleizach@apple.com>
2882
2883         AX: Support returning relative frames for accessibility
2884         https://bugs.webkit.org/show_bug.cgi?id=193414
2885         <rdar://problem/47268501>
2886
2887         Reviewed by Zalan Bujtas.
2888
2889         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2890         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2891         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2892         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2893         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2894         (WTR::attributesOfElement):
2895         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2896
2897 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2898
2899         Unreviewed, add my new email address
2900
2901         * Scripts/webkitpy/common/config/contributors.json:
2902
2903 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2904
2905         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2906         https://bugs.webkit.org/show_bug.cgi?id=193617
2907
2908         Reviewed by Antti Koivisto.
2909
2910         * LayoutReloaded/misc/LFC-passing-tests.txt:
2911
2912 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2913
2914         Unreviewed, rolling out r240209.
2915
2916         Broke GTK/WPE injected bundle
2917
2918         Reverted changeset:
2919
2920         "AX: Support returning relative frames for accessibility"
2921         https://bugs.webkit.org/show_bug.cgi?id=193414
2922         https://trac.webkit.org/changeset/240209
2923
2924 2019-01-12  Dan Bernstein  <mitz@apple.com>
2925
2926         [Cocoa] Avoid importing directly from subumbrella frameworks
2927         https://bugs.webkit.org/show_bug.cgi?id=186016
2928         <rdar://problem/40591038>
2929
2930         Reviewed by Sam Weinig.
2931
2932         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2933           LaunchServices header.
2934         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2935           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2936         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2937           when using SDKs earlier than 10.13.
2938         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2939           and OTHER_CPLUSPLUSFLAGS.
2940         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2941           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2942         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2943           LaunchServices header.
2944
2945 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2946
2947         Cache bytecode to disk
2948         https://bugs.webkit.org/show_bug.cgi?id=192782
2949         <rdar://problem/46084932>
2950
2951         Reviewed by Keith Miller.
2952
2953         Add test helper to execute bytecode-cache tests: it executes each test
2954         twice, the first with JSC_diskCachePath set to a temporary directory
2955         and second with JSC_forceDiskCache=true (in addition to the cache path)
2956         to guarantee that only the disk cache is being used and no new
2957         UnlinkedCodeBlocks are being created.
2958
2959         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2960         * Scripts/run-jsc-stress-tests:
2961
2962 2019-01-20  chris fleizach  <cfleizach@apple.com>
2963
2964         AX: Support returning relative frames for accessibility
2965         https://bugs.webkit.org/show_bug.cgi?id=193414
2966         <rdar://problem/47268501>
2967
2968         Reviewed by Zalan Bujtas.
2969
2970         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2971         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2972         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2973         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2974         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2975         (WTR::attributesOfElement):
2976         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2977
2978 2019-01-20  Antoine Quint  <graouts@apple.com>
2979
2980         Add a POINTER_EVENTS feature flag
2981         https://bugs.webkit.org/show_bug.cgi?id=193577
2982         <rdar://problem/47408511>
2983
2984         Unreviewed. Also enable Pointer Events for iosmac.
2985
2986         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2987
2988 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2989
2990         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2991         https://bugs.webkit.org/show_bug.cgi?id=193613
2992
2993         Reviewed by Antti Koivisto.
2994
2995         * LayoutReloaded/misc/LFC-passing-tests.txt:
2996
2997 2019-01-19  Antoine Quint  <graouts@apple.com>
2998
2999         Add a POINTER_EVENTS feature flag
3000         https://bugs.webkit.org/show_bug.cgi?id=193577
3001
3002         Reviewed by Dean Jackson.
3003
3004         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3005
3006 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3007
3008         Disable the run-jsc-stress-test remote host key check [second round].
3009         https://bugs.webkit.org/show_bug.cgi?id=192988
3010
3011         Reviewed by Dewei Zhu.
3012
3013         * Scripts/run-jsc-stress-tests:
3014
3015 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3016
3017         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3018         https://bugs.webkit.org/show_bug.cgi?id=193597
3019
3020         Reviewed by Lucas Forschler.
3021
3022         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3023
3024 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3025
3026         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3027         https://bugs.webkit.org/show_bug.cgi?id=193595
3028
3029         Reviewed by Lucas Forschler.
3030
3031         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3032         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3033         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3034
3035 2019-01-18  Chris Dumez  <cdumez@apple.com>
3036
3037         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3038         https://bugs.webkit.org/show_bug.cgi?id=193588
3039         <rdar://problem/47131566>
3040
3041         Reviewed by Alex Christensen.
3042
3043         Add layout test coverage.
3044
3045         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3046
3047 2019-01-18  Jer Noble  <jer.noble@apple.com>
3048
3049         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3050         https://bugs.webkit.org/show_bug.cgi?id=189553
3051
3052         Reviewed by Tim Horton.
3053
3054         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3055
3056         * ContentExtensionTester/Configurations/Base.xcconfig:
3057         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3058         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3059         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3060         * ImageDiff/cg/Configurations/Base.xcconfig:
3061         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3062         * MiniBrowser/Configurations/Base.xcconfig:
3063         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3064         * MobileMiniBrowser/Configurations/Base.xcconfig:
3065         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3066         * Scripts/webkitpy/style/checker.py:
3067         (_all_categories):
3068         (FileType):
3069         (CheckerDispatcher._file_type):
3070         (CheckerDispatcher._create_checker):
3071         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3072         (SDKVariantChecker):
3073         (SDKVariantChecker.__init__):
3074         (SDKVariantChecker.check):
3075         * TestWebKitAPI/Configurations/Base.xcconfig:
3076         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3077         * WebEditingTester/Configurations/Base.xcconfig:
3078         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3079         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3080         * WebKitTestRunner/Configurations/Base.xcconfig:
3081         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3082         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3083         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3084
3085 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3086
3087         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3088         <https://webkit.org/b/193568>
3089         <rdar://problem/47381130>
3090
3091         Reviewed by Alex Christensen.
3092
3093         Make sure no one re-introduces UIKit soft-linking by adding a
3094         style rule.
3095
3096         * Scripts/webkitpy/style/checkers/cpp.py:
3097         (check_language): Add softlink/uikit check.
3098         (CppChecker): Enable softlink/uikit check.
3099         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3100         (CppStyleTest): Add test for softlink/uikit.
3101
3102 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3103
3104         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3105         https://bugs.webkit.org/show_bug.cgi?id=193584
3106
3107         Change "-dev" to "-devel".
3108
3109         Reviewed by Michael Catanzaro.
3110
3111         * gtk/install-dependencies:
3112
3113 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3114
3115         webkitpy: Add iPhone and iPad ports
3116         https://bugs.webkit.org/show_bug.cgi?id=193537
3117         <rdar://problem/47353390>
3118
3119         Reviewed by Lucas Forschler.
3120
3121         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3122         ports. Note that this separation is optional, the --ios-simulator command remains.
3123
3124         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3125         (RunTest.test_device_type_test_division): Drive-by fix.
3126         (RunTest.test_device_type_specific_listing): Ditto.
3127         (RunTest.test_ipad_test_division):
3128         (RunTest):
3129         (RunTest.test_ipad_listing):
3130         * Scripts/webkitpy/port/factory.py:
3131         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3132         (PortFactory):
3133         * Scripts/webkitpy/port/ios_simulator.py:
3134         (IPhoneSimulatorPort):
3135         (IPadSimulatorPort):
3136
3137 2019-01-18  Chris Dumez  <cdumez@apple.com>
3138
3139         Regression(PSON) Scroll position is not always restored properly when navigating back
3140         https://bugs.webkit.org/show_bug.cgi?id=193578
3141         <rdar://problem/47386331>
3142
3143         Reviewed by Tim Horton.
3144
3145         Add API test coverage.
3146
3147         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3148
3149 2019-01-18  Youenn Fablet  <youenn@apple.com>
3150
3151         Add a new SPI to request for cache storage quota increase
3152         https://bugs.webkit.org/show_bug.cgi?id=193323
3153
3154         Reviewed by Alex Christensen.
3155
3156         Implement WebsiteDataStore quota delegate to handle quota requests.
3157         By default, do not update quota.
3158         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3159
3160         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3161         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3162         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3163         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3164         * WebKitTestRunner/TestController.cpp:
3165         (WTR::TestController::allowCacheStorageQuotaIncrease):
3166         * WebKitTestRunner/TestController.h:
3167         * WebKitTestRunner/TestInvocation.cpp:
3168         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3169         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3170         (-[CacheStorageQuotaManager init]):
3171         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3172         (WTR::initializeWebViewConfiguration):
3173         (WTR::TestController::cocoaResetStateToConsistentValues):
3174         (WTR::TestController::allowCacheStorageQuotaIncrease):
3175
3176 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3177
3178         [ews-build] Pass owner to the triggered builds
3179         https://bugs.webkit.org/show_bug.cgi?id=193574
3180
3181         Reviewed by Lucas Forschler.
3182
3183         * BuildSlaveSupport/ews-build/factories.py:
3184         (BuildFactory.propertiesToPassToTriggers):
3185
3186 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3187
3188         [ews-app] Send patch author as a build property
3189         https://bugs.webkit.org/show_bug.cgi?id=193560
3190
3191         Reviewed by Lucas Forschler.
3192
3193         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3194         (BugzillaPatchFetcher.fetch):
3195
3196 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3197
3198         webkitpy: Implement device type specific expected results (Follow-up fix)
3199         https://bugs.webkit.org/show_bug.cgi?id=192162
3200         <rdar://problem/46345449>
3201
3202         Unreviewed infrastructure fix.
3203
3204         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3205         (Manager.run): Don't boot a device if no tests are available to run on it.
3206
3207 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3208
3209         webkitpy: Implement device type specific expected results (Follow-up fix)
3210         https://bugs.webkit.org/show_bug.cgi?id=192162
3211         <rdar://problem/46345449>
3212
3213         Unreviewed infrastructure fix.
3214
3215         * Scripts/webkitpy/api_tests/manager.py:
3216         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3217
3218 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3219
3220         webkitpy: Implement device type specific expected results (Part 2)
3221         https://bugs.webkit.org/show_bug.cgi?id=192162
3222         <rdar://problem/46345449>
3223
3224         Rubber-stamped by Aakash Jain.
3225
3226         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3227         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3228         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3229
3230         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3231         (LayoutTestFinder.find_tests): Pass device_type through.
3232         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3233         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3234         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3235         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3236         (Manager._collect_tests): Pass device type to test finder.
3237         (Manager._needs_web_platform_test):
3238         (Manager._prepare_lists): Index _expectations by device type.
3239         (Manager._test_input_for_file):
3240         (Manager._test_is_slow): Ditto.
3241         (Manager._test_should_dump_jsconsolelog_in_stderr):
3242         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3243         (Manager._get_test_inputs):
3244         (Manager._update_worker_count):
3245         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3246         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3247         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3248         the one which runs the test.
3249         (Manager._run_test_subset):
3250         (Manager._run_tests): Index _expectations by current_device_type.
3251         (Manager._print_expectation_line_for_test): Ditto.
3252         (Manager._print_expectations_for_subset): Ditto.
3253         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3254         Unlike run, this function will behave the same regardless of what devices are available.
3255         (Manager._custom_device_for_test): Deleted.
3256         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3257         (ManagerTest.test_uses_custom_device): Deleted.
3258         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3259         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3260         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3261         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3262         all of the expectations.
3263         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3264         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3265         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3266         (TestExpectations.__init__): Allow device_type to be passed through.
3267         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3268         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3269         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3270         (summarize_results):
3271         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3272         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3273         a test ran with, one must check all expectations to find the first non-skip expectation.
3274         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3275         (RunTest.test_device_type_test_division):
3276         (RunTest):
3277         (RunTest.test_device_type_specific_listing):
3278         * Scripts/webkitpy/port/base.py:
3279         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3280         (Port.supported_device_types): The result of this function will change based on what devices are available.
3281         * Scripts/webkitpy/port/device_port.py:
3282         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3283         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3284         can be used.
3285         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3286         any, or the DEFAULT_DEVICE_TYPES of the port.
3287         * Scripts/webkitpy/port/ios.py:
3288         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3289         * Scripts/webkitpy/port/ios_simulator.py:
3290         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3291         * Scripts/webkitpy/port/watch.py:
3292         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3293         * Scripts/webkitpy/port/watch_simulator.py:
3294         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3295         * Scripts/webkitpy/xcode/device_type.py:
3296         (DeviceType):
3297         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3298
3299 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3300
3301         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3302         https://bugs.webkit.org/show_bug.cgi?id=193575
3303
3304         Reviewed by Michael Catanzaro.
3305
3306         Allow the script to run without explicit port argument because
3307         it's specific to the WPE port anyway.
3308
3309         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3310         and simplify the rest of the code accordingly.
3311
3312 2019-01-18  Charlie Turner  <cturner@igalia.com>
3313
3314         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3315         https://bugs.webkit.org/show_bug.cgi?id=192229
3316
3317         Reviewed by Xabier Rodriguez-Calvar.
3318
3319         * MiniBrowser/wpe/main.cpp:
3320         (main): Enable encrypted-media by default.
3321
3322 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3323
3324         [Flatpak] Missing KeyboardInterrupt exception handler
3325         https://bugs.webkit.org/show_bug.cgi?id=193570
3326
3327         Reviewed by Michael Catanzaro.
3328
3329         * flatpak/flatpakutils.py:
3330         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3331
3332 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3333
3334         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3335         https://bugs.webkit.org/show_bug.cgi?id=193564
3336
3337         Reviewed by Antti Koivisto.
3338
3339         * LayoutReloaded/misc/LFC-passing-tests.txt:
3340
3341 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3342
3343         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3344         https://bugs.webkit.org/show_bug.cgi?id=193562
3345
3346         Reviewed by Antti Koivisto.
3347
3348         * LayoutReloaded/misc/LFC-passing-tests.txt:
3349
3350 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3351
3352         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3353         https://bugs.webkit.org/show_bug.cgi?id=193555
3354
3355         Reviewed by Antti Koivisto.
3356
3357         * LayoutReloaded/misc/LFC-passing-tests.txt:
3358
3359 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3360
3361         [WPE] Add Qt extension
3362         https://bugs.webkit.org/show_bug.cgi?id=191464
3363
3364         Reviewed by Carlos Garcia Campos.
3365
3366         MiniBrowser and API tests for the WPE Qt API. To run the
3367         MiniBrowser a new script is introduced. Example invocation:
3368
3369         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3370
3371         Also note-worthy is the introduction of the python2-subprocess32
3372         dependency to run the GLib API tests.
3373
3374         * MiniBrowser/wpe/CMakeLists.txt:
3375         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3376         * MiniBrowser/wpe/qt/main.cpp: Added.
3377         (main):
3378         * MiniBrowser/wpe/qt/main.qml: Added.
3379         * MiniBrowser/wpe/qt/qml.qrc: Added.
3380         * Scripts/run-gtk-tests:
3381         (GtkTestRunner.is_google_test):
3382         (GtkTestRunner):
3383         (GtkTestRunner.is_qt_test):
3384         * Scripts/run-qt-wpe-minibrowser: Added.
3385         * Scripts/run-wpe-tests:
3386         (WPETestRunner):
3387         (WPETestRunner.is_google_test):
3388         (WPETestRunner.is_qt_test):
3389         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3390         (TestLoad::main):
3391         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3392         (TestLoadHtml::main):
3393         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3394         (TestLoadRequest::main):
3395         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3396         (TestRunJavaScript::main):
3397         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3398         (waitForSignal):
3399         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3400         (LoadSpy::LoadSpy):
3401         (LoadSpy::~LoadSpy):
3402         (LoadSpy::onLoadingChanged):
3403         (LoadStartedCatcher::LoadStartedCatcher):
3404         (LoadStartedCatcher::~LoadStartedCatcher):
3405         (LoadStartedCatcher::onLoadingChanged):
3406         (waitForLoadSucceeded):
3407         (waitForLoadFailed):
3408         * TestWebKitAPI/glib/CMakeLists.txt:
3409         * flatpak/flatpakutils.py:
3410         (WebkitFlatpak.load_from_args):
3411         (WebkitFlatpak.__init__):
3412         (WebkitFlatpak.clean_args):
3413         (WebkitFlatpak.run_in_sandbox):
3414         * flatpak/org.webkit.CommonModules.yaml:
3415         * flatpak/org.webkit.WPE.yaml:
3416         * flatpak/org.webkit.WPEModules.yaml:
3417         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3418         * flatpak/org.webkit.WebKit.yaml:
3419         * glib/api_test_runner.py:
3420         (TestRunner._run_test_qt):
3421         (TestRunner.is_qt_test):
3422         (TestRunner._run_test):
3423
3424 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3425
3426         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3427         https://bugs.webkit.org/show_bug.cgi?id=193494
3428         <rdar://problem/46859627>
3429
3430         Reviewed by Simon Fraser and Tim Horton.
3431
3432         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3433         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3434
3435         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3436         (WTR::UIScriptController::contentOffsetX const):
3437         (WTR::UIScriptController::contentOffsetY const):
3438         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3439         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3440         (WTR::UIScriptController::contentOffsetX const):
3441         (WTR::UIScriptController::contentOffsetY const):
3442         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3443
3444         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3445
3446         * WebKitTestRunner/TestController.cpp:
3447         (WTR::updateTestOptionsFromTestHeader):
3448         * WebKitTestRunner/TestOptions.h:
3449         (WTR::TestOptions::hasSameInitializationOptions const):
3450         * WebKitTestRunner/ios/TestControllerIOS.mm:
3451         (WTR::TestController::platformResetStateToConsistentValues):
3452         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3453         (WTR::UIScriptController::contentOffsetX const):
3454         (WTR::UIScriptController::contentOffsetY const):
3455
3456 2019-01-17  Truitt Savell  <tsavell@apple.com>
3457
3458         Unreviewed, rolling out r240124.
3459
3460         This commit broke an internal build.
3461
3462         Reverted changeset:
3463
3464         "SDK_VARIANT build destinations should be separate from non-
3465         SDK_VARIANT builds"
3466         https://bugs.webkit.org/show_bug.cgi?id=189553
3467         https://trac.webkit.org/changeset/240124
3468
3469 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3470
3471         Fix string concatenation API test after r239920
3472         https://bugs.webkit.org/show_bug.cgi?id=193551
3473         <rdar://problem/47359304>
3474
3475         Reviewed by Youenn Fablet.
3476
3477         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3478         (TestWebKitAPI::TEST):
3479         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3480         in WebKit's build configuration like it apparently is on Linux.
3481
3482 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3483
3484         [ews-build] validate-patch should handle the case when bug_id is None
3485         https://bugs.webkit.org/show_bug.cgi?id=193547
3486
3487         Reviewed by Lucas Forschler.
3488
3489         * BuildSlaveSupport/ews-build/steps.py:
3490         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3491         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3492
3493 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3494
3495         [ews-build] Add patch author information in build
3496         https://bugs.webkit.org/show_bug.cgi?id=193465
3497
3498         Reviewed by Lucas Forschler.
3499
3500         * BuildSlaveSupport/ews-build/steps.py:
3501         (ValidatePatch._is_patch_obsolete):
3502
3503 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3504
3505         [ews-build] Pass bug_id to the triggered builds
3506         https://bugs.webkit.org/show_bug.cgi?id=193548
3507
3508         Reviewed by Lucas Forschler.
3509
3510         * BuildSlaveSupport/ews-build/factories.py:
3511         (BuildFactory.propertiesToPassToTriggers):
3512
3513 2019-01-17  Jer Noble  <jer.noble@apple.com>
3514
3515         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3516         https://bugs.webkit.org/show_bug.cgi?id=189553
3517
3518         Reviewed by Tim Horton.
3519
3520         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3521
3522         * ContentExtensionTester/Configurations/Base.xcconfig:
3523         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3524         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3525         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3526         * ImageDiff/cg/Configurations/Base.xcconfig:
3527         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3528         * MiniBrowser/Configurations/Base.xcconfig:
3529         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3530         * MobileMiniBrowser/Configurations/Base.xcconfig:
3531         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3532         * Scripts/webkitpy/style/checker.py:
3533         (_all_categories):
3534         (FileType):
3535         (CheckerDispatcher._file_type):
3536         (CheckerDispatcher._create_checker):
3537         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3538         (SDKVariantChecker):
3539         (SDKVariantChecker.__init__):
3540         (SDKVariantChecker.check):
3541         * TestWebKitAPI/Configurations/Base.xcconfig:
3542         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3543         * WebEditingTester/Configurations/Base.xcconfig:
3544         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3545         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3546         * WebKitTestRunner/Configurations/Base.xcconfig:
3547         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3548         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3549         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3550
3551 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3552
3553         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3554         https://bugs.webkit.org/show_bug.cgi?id=193534
3555
3556         Reviewed by Antti Koivisto.
3557
3558         * LayoutReloaded/misc/LFC-passing-tests.txt:
3559
3560 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3561
3562         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
3563         https://bugs.webkit.org/show_bug.cgi?id=193528
3564
3565         Reviewed by Antti Koivisto.
3566
3567         * LayoutReloaded/misc/LFC-passing-tests.txt:
3568
3569 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3570
3571         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
3572         https://bugs.webkit.org/show_bug.cgi?id=193520
3573
3574         Reviewed by Antti Koivisto.
3575
3576         * LayoutReloaded/misc/LFC-passing-tests.txt:
3577
3578 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3579
3580         [ews-build] unapply-patch step should not update source
3581         https://bugs.webkit.org/show_bug.cgi?id=193234
3582
3583         Reviewed by Lucas Forschler.
3584
3585         * BuildSlaveSupport/ews-build/steps.py:
3586         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
3587         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
3588
3589 2019-01-16  Youenn Fablet  <youenn@apple.com>
3590
3591         Add a new SPI for controlling getUserMedia
3592         https://bugs.webkit.org/show_bug.cgi?id=192793
3593
3594         Reviewed by Eric Carlson.
3595
3596         * MiniBrowser/mac/WK2BrowserWindowController.m:
3597         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
3598         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3599         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
3600         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3601         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3602         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3603         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
3604         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3605         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3606         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3607         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3608         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
3609         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
3610         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
3611
3612 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3613
3614         [LFC][BFC] Inflow non-replaced used width should not be negative.
3615         https://bugs.webkit.org/show_bug.cgi?id=193495
3616
3617         Reviewed by Antti Koivisto.
3618
3619         * LayoutReloaded/misc/LFC-passing-tests.txt:
3620
3621 2019-01-16  Chris Dumez  <cdumez@apple.com>
3622
3623         Regression(PSON) View becomes blank after click a cross-site download link
3624         https://bugs.webkit.org/show_bug.cgi?id=193361
3625         <rdar://problem/47099573>
3626
3627         Reviewed by Geoffrey Garen.
3628
3629         Add API test coverage.
3630
3631         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3632         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3633
3634 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3635
3636         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
3637         https://bugs.webkit.org/show_bug.cgi?id=193470
3638
3639         Reviewed by Antti Koivisto.
3640
3641         * LayoutReloaded/misc/LFC-passing-tests.txt:
3642
3643 2019-01-16  Zalan Bujtas  <zalan@apple.com>
3644
3645         [LFC] Adjust margin box verification.
3646         https://bugs.webkit.org/show_bug.cgi?id=193482
3647
3648         Reviewed by Antti Koivisto.
3649
3650         * LayoutReloaded/misc/LFC-passing-tests.txt:
3651
3652 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3653
3654         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3655         https://bugs.webkit.org/show_bug.cgi?id=193451
3656
3657         Reviewed by Geoffrey Garen.
3658
3659         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3660         (TEST):
3661         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3662         (runWebsiteDataStoreCustomPaths):
3663
3664 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3665
3666         webkitpy: Support boolean simctl isAvailable
3667         https://bugs.webkit.org/show_bug.cgi?id=193472
3668         <rdar://problem/47296150>
3669
3670         Reviewed by Ryosuke Niwa.
3671
3672         * Scripts/webkitpy/xcode/simulated_device.py:
3673         (SimulatedDeviceManager._create_runtimes):
3674         (SimulatedDeviceManager._create_device_with_runtime):
3675
3676 2019-01-15  Chris Dumez  <cdumez@apple.com>
3677
3678         Unreviewed, rolling out r239993, r239995, r239997, and
3679         r239999.
3680
3681         Caused assertions under
3682         ViewGestureController::disconnectFromProcess()
3683
3684         Reverted changesets:
3685
3686         "Regression(PSON) View becomes blank after click a cross-site
3687         download link"
3688         https://bugs.webkit.org/show_bug.cgi?id=193361
3689         https://trac.webkit.org/changeset/239993
3690
3691         "Unreviewed iOS build fix after r239993."
3692         https://trac.webkit.org/changeset/239995
3693
3694         "Fix iOS build after r239993"
3695         https://bugs.webkit.org/show_bug.cgi?id=193361
3696         https://trac.webkit.org/changeset/239997
3697
3698         "Unreviewed, revert part of r239997 as it is not needed to fix
3699         the build."
3700         https://trac.webkit.org/changeset/239999
3701
3702 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3703
3704         Cannot tab out of WKWebView on macOS
3705         https://bugs.webkit.org/show_bug.cgi?id=161448
3706         <rdar://problem/28100085>
3707
3708         Reviewed by Dean Jackson.
3709
3710         Add a test that tabbing into and out of WKWebView works correctly.
3711
3712         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3713         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3714         (WebKit2_CommandBackForwardTest::SetUp):
3715         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3716         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3717         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3718         (-[FocusableView canBecomeKeyView]):
3719         (TEST):
3720         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3721         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3722         (-[OffscreenWindow initWithSize:]):
3723         (-[OffscreenWindow isKeyWindow]):
3724         (-[OffscreenWindow isVisible]):
3725         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3726         (TestWebKitAPI::PlatformWebView::initialize):
3727         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3728         (-[ActiveOffscreenWindow isVisible]): Deleted.
3729         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3730
3731 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3732
3733         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3734         https://bugs.webkit.org/show_bug.cgi?id=193459
3735
3736         Reviewed by Mark Lam.
3737
3738         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3739         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3740
3741 2019-01-15  Chris Dumez  <cdumez@apple.com>
3742
3743         Regression(PSON) View becomes blank after click a cross-site download link
3744         https://bugs.webkit.org/show_bug.cgi?id=193361
3745         <rdar://problem/47099573>
3746
3747         Reviewed by Geoff Garen.
3748
3749         Add API test coverage.
3750
3751         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3752         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3753
3754 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3755
3756         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3757         https://bugs.webkit.org/show_bug.cgi?id=193448
3758
3759         Reviewed by Antti Koivisto.
3760
3761         * LayoutReloaded/misc/LFC-passing-tests.txt:
3762
3763 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3764
3765         webkitpy: Implement device type specific expected results (Part 1)
3766         https://bugs.webkit.org/show_bug.cgi?id=192162
3767
3768         Reviewed by Lucas Forschler.
3769
3770         Device type specific expected results covers two related ideas. The first (covered by this change)
3771         is where to search for -expected.* files. The second is which tests to run based on the
3772         TestExpectations.txt file.
3773
3774         After this change, the baseline search path will be determined by the type of device running a
3775         test. Device type will be passed into any function which picks a file based on the baseline search
3776         path.
3777
3778         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3779         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3780         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3781         (Manager.run): Print baseline search path for each round of devices.
3782         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3783         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3784         (SingleTestRunner._expected_driver_output): Ditto.
3785         (SingleTestRunner._driver_input): Ditto.
3786         * Scripts/webkitpy/layout_tests/views/printing.py:
3787         (Printer.print_config): Move printing of baseline search path to a separate function.
3788         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3789         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3790         (Testprinter.test_print_config):
3791         (Testprinter.test_print_baseline_search_path):
3792         * Scripts/webkitpy/port/base.py:
3793         (Port.baseline_search_path): Pass device_type through.
3794         (Port._expected_baselines_for_suffixes): Ditto.
3795         (Port.expected_baselines): Ditto.
3796         (Port.expected_filename): Ditto.
3797         (Port.expected_checksum): Ditto.
3798         (Port.expected_image): Ditto.
3799         (Port.expected_audio): Ditto.
3800         (Port.expected_text): Ditto.
3801         (Port.reference_files): Ditto.
3802         (Port.tests): Ditto.
3803         (Port._expanded_paths): Ditto.
3804         (Port.skipped_layout_tests): Ditto.
3805         (Port.expectations_dict): Ditto.
3806         (Port._port_specific_expectations_files): Ditto.
3807         (Port.expectations_files): Ditto.
3808         (Port.test_search_path): Ditto.
3809         (Port._tests_for_other_platforms): Ditto.
3810         * Scripts/webkitpy/port/base_unittest.py:
3811         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3812         (PortTest.test_nonexistant_expectations): Ditto.
3813         (test_ref_tests_platform_directory): Ditto.
3814         * Scripts/webkitpy/port/darwin.py:
3815         (DarwinPort._port_specific_expectations_files): Accept device_type.
3816         * Scripts/webkitpy/port/driver.py:
3817         (DriverProxy):
3818         (DriverProxy.host): Expose _target_host for device_type information.
3819         * Scripts/webkitpy/port/gtk.py:
3820         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3821         * Scripts/webkitpy/port/ios.py:
3822         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3823         * Scripts/webkitpy/port/mac.py:
3824         (MacPort. default_baseline_search_path): Ditto.
3825         * Scripts/webkitpy/port/port_testcase.py:
3826         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3827         * Scripts/webkitpy/port/test.py:
3828         * Scripts/webkitpy/port/watch.py:
3829         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3830         * Scripts/webkitpy/port/win.py:
3831         (WinPort.test_search_path): Accept, but do not use, device_type.
3832         * Scripts/webkitpy/port/wpe.py:
3833         (WPEPort._port_specific_expectations_files): Ditto.
3834         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3835         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3836
3837 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3838
3839         [LFC] Use the containing block's padding box to position out-of-flow elements.
3840         https://bugs.webkit.org/show_bug.cgi?id=193431
3841
3842         Reviewed by Antti Koivisto.
3843
3844         * LayoutReloaded/misc/LFC-passing-tests.txt:
3845
3846 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3847
3848         Move a test implementation file that got misplaced in the Xcode project
3849
3850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3851
3852 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3853
3854         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3855         r239913, and r239914.
3856         https://bugs.webkit.org/show_bug.cgi?id=193407
3857
3858         These revisions caused an internal failure (Requested by
3859         Truitt on #webkit).
3860
3861         Reverted changesets:
3862
3863         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3864         https://bugs.webkit.org/show_bug.cgi?id=186016
3865         https://trac.webkit.org/changeset/239901
3866
3867         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3868         https://trac.webkit.org/changeset/239909
3869
3870         "Tried to fix the build."
3871         https://trac.webkit.org/changeset/239910
3872
3873         "Fixed iOS builds after r239910."
3874         https://trac.webkit.org/changeset/239912
3875
3876         "More build fixing."
3877         https://trac.webkit.org/changeset/239913
3878
3879         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3880         https://trac.webkit.org/changeset/239914
3881
3882 2019-01-14  Mark Lam  <mark.lam@apple.com>
3883
3884         Re-enable ability to build --cloop builds.
3885         https://bugs.webkit.org/show_bug.cgi?id=192955
3886         <rdar://problem/46882363>
3887
3888         Reviewed by Saam barati and Keith Miller.
3889
3890         The --cloop build option was being ignored this whole time since r236381.
3891         This patch makes it possible to build CLoop builds again.
3892
3893         * Scripts/build-jsc:
3894         * Scripts/webkitperl/FeatureList.pm:
3895         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3896
3897 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3898
3899         webkitpy: Expose device_type from host-like objects
3900         https://bugs.webkit.org/show_bug.cgi?id=193406
3901         <rdar://problem/47262305>
3902
3903         Reviewed by Lucas Forschler.
3904
3905         Devices should expose device_type. As a result, all host objects should
3906         provide a device_type property, even if they do not yet define a device_type.
3907
3908         * Scripts/webkitpy/common/system/systemhost.py:
3909         (SystemHost):
3910         (SystemHost.device_type):
3911         * Scripts/webkitpy/common/system/systemhost_mock.py:
3912         (MockSystemHost):
3913         (MockSystemHost.device_type):
3914         * Scripts/webkitpy/port/device.py:
3915         (Device):
3916         (Device.device_type):
3917         * Scripts/webkitpy/xcode/simulated_device.py:
3918         (SimulatedDeviceManager._find_exisiting_device_for_request):
3919         (SimulatedDeviceManager._disambiguate_device_type):
3920         (SimulatedDeviceManager._does_fulfill_request):
3921         (SimulatedDeviceManager.device_count_for_type):
3922         (SimulatedDeviceManager.initialize_devices):
3923         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3924         (test_available_devices):
3925         (test_swapping_devices):
3926
3927 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3928
3929         webkitpy: Support alternate simctl device list output (Follow-up fix)
3930         https://bugs.webkit.org/show_bug.cgi?id=193362
3931         <rdar://problem/47122965>
3932
3933         Rubber-stamped by Lucas Forschler.
3934
3935         * Scripts/webkitpy/xcode/simulated_device.py:
3936         (SimulatedDeviceManager.populate_available_devices):
3937
3938 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3939
3940         [iOS] Expose SPI to access the current sentence boundary and selection state
3941         https://bugs.webkit.org/show_bug.cgi?id=193398
3942         <rdar://problem/45893108>
3943
3944         Reviewed by Dean Jackson.
3945
3946         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3947         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3948         expected.
3949
3950         * TestWebKitAPI/EditingTestHarness.h:
3951         * TestWebKitAPI/EditingTestHarness.mm:
3952         (-[EditingTestHarness moveBackward]):
3953         (-[EditingTestHarness moveForward]):
3954         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3955
3956         Add a couple of new helper methods on EditingTestHarness.
3957
3958         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3959         (-[SelectionChangeObserver initWithWebView:]):
3960         (-[SelectionChangeObserver webView]):
3961         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3962         (-[SelectionChangeObserver currentSelectionAttributes]):
3963
3964 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3965
3966         [LFC][BFC] Add basic box-sizing support.
3967         https://bugs.webkit.org/show_bug.cgi?id=193392
3968
3969         Reviewed by Antti Koivisto.
3970
3971         * LayoutReloaded/misc/LFC-passing-tests.txt:
3972
3973 2019-01-14  Charlie Turner  <cturner@igalia.com>
3974
3975         [WPE] API test gardening
3976         https://bugs.webkit.org/show_bug.cgi?id=193319
3977
3978         Reviewed by Michael Catanzaro.
3979
3980         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3981         passing tests.
3982
3983 2019-01-14  Charlie Turner  <cturner@igalia.com>
3984
3985         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3986         https://bugs.webkit.org/show_bug.cgi?id=192977
3987
3988         Reviewed by Carlos Garcia Campos.
3989
3990         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3991         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3992         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3993         (TestWebKitAPI::GStreamerTest::SetUp):
3994         (TestWebKitAPI::GStreamerTest::TearDown):
3995         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3996         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3997         (TestWebKitAPI::TEST_F):
3998
3999 2019-01-14  Charlie Turner  <cturner@igalia.com>
4000
4001         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
4002         https://bugs.webkit.org/show_bug.cgi?id=193332
4003
4004         Reviewed by Michael Catanzaro.
4005
4006         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
4007         defined as a char16_t, which changed in ICU 59, the
4008         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
4009         unsigned short. This test is relying on the behaviour that
4010         UChar=unsigned short, which doesn't hold across platforms and ICU
4011         library versions. The full fix would be a special syntax for
4012         literal characters so that these ambiguities do not arise. That
4013         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
4014         (TestWebKitAPI::TEST):
4015
4016 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
4017
4018         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
4019
4020         * Scripts/make-dist:
4021         (Distcheck.configure):
4022
4023 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
4024
4025         [ews-build] Update macOS queue configurations
4026         https://bugs.webkit.org/show_bug.cgi?id=193365
4027         <rdar://problem/47221073>
4028
4029         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
4030
4031         * BuildSlaveSupport/ews-build/config.json:
4032
4033 2019-01-13  Zalan Bujtas  <zalan@apple.com>
4034
4035         [LFC] Adjust assert for statically positioned fixed elements
4036         https://bugs.webkit.org/show_bug.cgi?id=193385
4037
4038         Reviewed by Antti Koivisto.
4039
4040         * LayoutReloaded/misc/LFC-passing-tests.txt:
4041
4042 2019-01-13  Philippe Normand  <pnormand@igalia.com>
4043
4044         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
4045         https://bugs.webkit.org/show_bug.cgi?id=193387
4046
4047         Reviewed by Carlos Garcia Campos.
4048
4049         * MiniBrowser/wpe/main.cpp:
4050         (main):
4051
4052 2019-01-12  Timothy Hatcher  <timothy@apple.com>
4053
4054         Have prefers-color-scheme: light always match on macOS versions before Mojave.
4055         https://bugs.webkit.org/show_bug.cgi?id=191655
4056         rdar://problem/46074680
4057
4058         Reviewed by Megan Gardner.
4059
4060         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
4061         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
4062
4063 2019-01-12  Dan Bernstein  <mitz@apple.com>
4064
4065         [Cocoa] Avoid importing directly from subumbrella frameworks
4066         https://bugs.webkit.org/show_bug.cgi?id=186016
4067         <rdar://problem/40591038>
4068
4069         Reviewed by Sam Weinig.
4070
4071         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
4072           LaunchServices header.
4073         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4074           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4075         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
4076           when using SDKs earlier than 10.13.
4077         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
4078           and OTHER_CPLUSPLUSFLAGS.
4079         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
4080           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
4081         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
4082           LaunchServices header.
4083
4084 2019-01-11  John Wilander  <wilander@apple.com>
4085
4086         Compile out Web API Statistics Collection
4087         https://bugs.webkit.org/show_bug.cgi?id=193370
4088         <rdar://problem/45388584>
4089
4090         Reviewed by Brent Fulgham.
4091
4092         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4093             Defined ENABLE_WEB_API_STATISTICS, off by default.
4094
4095 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
4096
4097         [WPE] Add gtk-doc
4098         https://bugs.webkit.org/show_bug.cgi?id=178900
4099
4100         Reviewed by Michael Catanzaro.
4101
4102         Add Tools/gtkdoc to manifest.txt.in files.
4103         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
4104
4105         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
4106         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
4107
4108 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4109
4110         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
4111         https://bugs.webkit.org/show_bug.cgi?id=193364
4112         <rdar://problem/47214117>
4113
4114         Reviewed by Tim Horton.
4115
4116         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
4117         precise, whereas dragging near the middle of the textarea does.
4118
4119         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4120         (TestWebKitAPI::TEST):
4121
4122 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4123
4124         webkitpy: Support alternate simctl device list output
4125         https://bugs.webkit.org/show_bug.cgi?id=193362
4126         <rdar://problem/47122965>
4127
4128         Reviewed by Lucas Forschler.
4129
4130         * Scripts/webkitpy/xcode/simulated_device.py:
4131         (SimulatedDeviceManager.populate_available_devices):
4132
4133 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
4134
4135         [ews-build] Update macOS queue configurations
4136         https://bugs.webkit.org/show_bug.cgi?id=193365
4137
4138         Reviewed by Lucas Forschler.
4139
4140         * BuildSlaveSupport/ews-build/config.json:
4141
4142 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4143
4144         webkitpy: Incorporate device type into baseline search path
4145         https://bugs.webkit.org/show_bug.cgi?id=193356
4146         <rdar://problem/47215515>
4147
4148         Reviewed by Lucas Forschler.
4149
4150         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
4151
4152         * Scripts/webkitpy/port/base.py:
4153         (Port.default_baseline_search_path): Allow device type to be passed in.
4154         * Scripts/webkitpy/port/gtk.py:
4155         (GtkPort.default_baseline_search_path): Ignore device type.
4156         * Scripts/webkitpy/port/ios.py:
4157         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
4158         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
4159         * Scripts/webkitpy/port/ios_device_unittest.py:
4160         (IOSDeviceTest):
4161         * Scripts/webkitpy/port/ios_simulator_unittest.py:
4162         (IOSSimulatorTest):
4163         * Scripts/webkitpy/port/mac.py:
4164         (MacPort.default_baseline_search_path): Ignore device type.
4165         * Scripts/webkitpy/port/watch.py:
4166         (WatchPort.default_baseline_search_path): Ditto.
4167         * Scripts/webkitpy/port/win.py:
4168         (WinPort.default_baseline_search_path): Ditto.
4169         (WinCairoPort.default_baseline_search_path): Ditto.
4170         * Scripts/webkitpy/port/wpe.py:
4171         (WPEPort.default_baseline_search_path): Ditto.
4172
4173 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
4174
4175         webkitpy: Print abbreviated baseline search path that includes only folders that exist
4176         https://bugs.webkit.org/show_bug.cgi?id=193352
4177         <rdar://problem/47210736>
4178
4179         Reviewed by Lucas Forschler.
4180
4181         * Scripts/webkitpy/layout_tests/views/printing.py:
4182         (Printer.print_config): Print list on only baseline search paths which exist. 
4183         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4184         (Testprinter.test_print_config):
4185
4186 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
4187
4188         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
4189         https://bugs.webkit.org/show_bug.cgi?id=193340
4190
4191         Reviewed by David Kilzer.
4192
4193         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4194         (WTR::InjectedBundle::didReceiveMessageToPage):
4195         Pull the strings out into a WKRetainPtr.
4196
4197         * WebKitTestRunner/WebNotificationProvider.cpp:
4198         (WTR::WebNotificationProvider::closeWebNotification):
4199         Adopt the created value into the WKRetainPtr.
4200
4201         * WebKitTestRunner/mac/TestControllerMac.mm:
4202         (WTR::generateWhitelist):
4203         Immediately adopt a created value to avoid potential mistakes.
4204
4205 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
4206
4207         Enable DFG on ARM/Linux again
4208         https://bugs.webkit.org/show_bug.cgi?id=192496
4209
4210         Reviewed by Yusuke Suzuki.
4211
4212         After changing the bytecode format DFG was disabled on all 32-bit
4213         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
4214         on ARM by default.
4215
4216         * Scripts/run-jsc-stress-tests:
4217
4218 2019-01-11  Timothy Hatcher  <timothy@apple.com>
4219
4220         Unreviewed, fix #ifdef in API test added in r239851.
4221         https://bugs.webkit.org/show_bug.cgi?id=193327
4222         rdar://problem/47093222
4223
4224         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
4225
4226 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4227
4228         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
4229         https://bugs.webkit.org/show_bug.cgi?id=193109
4230         <rdar://problem/44807048>
4231
4232         Reviewed by Ryosuke Niwa.
4233
4234         Introduce and respect a test option to enable the UndoManager API.
4235
4236         * WebKitTestRunner/TestController.cpp:
4237         (WTR::updateTestOptionsFromTestHeader):
4238         * WebKitTestRunner/TestOptions.h:
4239         (WTR::TestOptions::hasSameInitializationOptions const):
4240         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4241         (WTR::TestController::platformCreateWebView):
4242
4243 2019-01-11  Zalan Bujtas  <zalan@apple.com>
4244
4245         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
4246         https://bugs.webkit.org/show_bug.cgi?id=193346
4247
4248         Reviewed by Antti Koivisto.
4249
4250         * LayoutReloaded/misc/LFC-passing-tests.txt:
4251
4252 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
4253
4254         Unreviewed, fix typo that breaks dashboard link.
4255
4256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4257         (WebKitBuildbot):
4258
4259 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
4260
4261         Update macOS queue configurations
4262         https://bugs.webkit.org/show_bug.cgi?id=193329
4263
4264         Reviewed by Alexey Proskuryakov.
4265
4266         * BuildSlaveSupport/build.webkit.org-config/config.json:
4267         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4268         (BubbleQueueServer):
4269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4271         (WebKitBuildbot):
4272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4273         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
4274         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4275
4276 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4277
4278         MiniBrowser should be able to navigate to about:blank
4279         https://bugs.webkit.org/show_bug.cgi?id=193345
4280
4281         Reviewed by Simon Fraser.
4282
4283         * MiniBrowser/mac/BrowserWindowController.m:
4284         (-[BrowserWindowController addProtocolIfNecessary:]):
4285         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
4286
4287         * MiniBrowser/mac/WK1BrowserWindowController.m:
4288         (-[WK1BrowserWindowController fetch:]):
4289         * MiniBrowser/mac/WK2BrowserWindowController.m:
4290         (-[WK2BrowserWindowController fetch:]):
4291         Clean up the code that uses this to match style.
4292
4293 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
4294
4295         Remove MiniBrowser custom "Process Swap" menu item which does not work
4296         https://bugs.webkit.org/show_bug.cgi?id=193344
4297
4298         Reviewed by Simon Fraser.
4299
4300         There is a menu item under the Experimental menu that does work.
4301
4302         * MiniBrowser/mac/AppDelegate.m:
4303         (defaultConfiguration):
4304         * MiniBrowser/mac/SettingsController.h:
4305         * MiniBrowser/mac/SettingsController.m:
4306         (-[SettingsController _populateMenu]):
4307         (-[SettingsController validateMenuItem:]):
4308         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
4309         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
4310
4311 2019-01-10  Timothy Hatcher  <timothy@apple.com>
4312
4313         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
4314         https://bugs.webkit.org/show_bug.cgi?id=193327
4315         rdar://problem/47093222
4316
4317         Reviewed by Tim Horton.
4318
4319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4320         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
4321         (TestWebKitAPI::didFinishNavigation):
4322         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4323         (TestWebKitAPI::TEST):
4324         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
4325         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
4326         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):