[LFC][Floats] Take float top position into account when computing containing block...
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2
3         [LFC][Floats] Take float top position into account when computing containing block height.
4         https://bugs.webkit.org/show_bug.cgi?id=193655
5
6         Reviewed by Antti Koivisto.
7
8         * LayoutReloaded/misc/LFC-passing-tests.txt:
9
10 2019-01-21  David Kilzer  <ddkilzer@apple.com>
11
12         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
13         <https://webkit.org/b/193645>
14         <rdar://problem/47421574>
15
16         Reviewed by Alex Christensen.
17
18         - Now checks for local soft-linking of all frameworks that have
19           their own *SoftLinking.{cpp,h,mm} files.
20         - Changes softlink/uikit warning to softlink/framework.
21
22         * Scripts/webkitpy/style/checkers/cpp.py:
23         (check_language):
24         (CppChecker):
25         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
26         (CppStyleTest):
27
28 2019-01-20  Saam Barati  <sbarati@apple.com>
29
30         Rollout r240210: It broke tests on iOS
31         https://bugs.webkit.org/show_bug.cgi?id=193640
32
33         Unreviewed.
34
35         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
36         * Scripts/run-jsc-stress-tests:
37
38 2019-01-20  chris fleizach  <cfleizach@apple.com>
39
40         AX: Support returning relative frames for accessibility
41         https://bugs.webkit.org/show_bug.cgi?id=193414
42         <rdar://problem/47268501>
43
44         Reviewed by Zalan Bujtas.
45
46         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
47         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
48         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
49         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
50         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
51         (WTR::attributesOfElement):
52         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
53
54 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
55
56         Unreviewed, add my new email address
57
58         * Scripts/webkitpy/common/config/contributors.json:
59
60 2019-01-19  Zalan Bujtas  <zalan@apple.com>
61
62         [LFC][BFC] <body>'s overflow property value is propagated to viewport
63         https://bugs.webkit.org/show_bug.cgi?id=193617
64
65         Reviewed by Antti Koivisto.
66
67         * LayoutReloaded/misc/LFC-passing-tests.txt:
68
69 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
70
71         Unreviewed, rolling out r240209.
72
73         Broke GTK/WPE injected bundle
74
75         Reverted changeset:
76
77         "AX: Support returning relative frames for accessibility"
78         https://bugs.webkit.org/show_bug.cgi?id=193414
79         https://trac.webkit.org/changeset/240209
80
81 2019-01-12  Dan Bernstein  <mitz@apple.com>
82
83         [Cocoa] Avoid importing directly from subumbrella frameworks
84         https://bugs.webkit.org/show_bug.cgi?id=186016
85         <rdar://problem/40591038>
86
87         Reviewed by Sam Weinig.
88
89         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
90           LaunchServices header.
91         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
92           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
93         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
94           when using SDKs earlier than 10.13.
95         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
96           and OTHER_CPLUSPLUSFLAGS.
97         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
98           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
99         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
100           LaunchServices header.
101
102 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
103
104         Cache bytecode to disk
105         https://bugs.webkit.org/show_bug.cgi?id=192782
106         <rdar://problem/46084932>
107
108         Reviewed by Keith Miller.
109
110         Add test helper to execute bytecode-cache tests: it executes each test
111         twice, the first with JSC_diskCachePath set to a temporary directory
112         and second with JSC_forceDiskCache=true (in addition to the cache path)
113         to guarantee that only the disk cache is being used and no new
114         UnlinkedCodeBlocks are being created.
115
116         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
117         * Scripts/run-jsc-stress-tests:
118
119 2019-01-20  chris fleizach  <cfleizach@apple.com>
120
121         AX: Support returning relative frames for accessibility
122         https://bugs.webkit.org/show_bug.cgi?id=193414
123         <rdar://problem/47268501>
124
125         Reviewed by Zalan Bujtas.
126
127         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
128         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
129         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
130         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
131         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
132         (WTR::attributesOfElement):
133         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
134
135 2019-01-20  Antoine Quint  <graouts@apple.com>
136
137         Add a POINTER_EVENTS feature flag
138         https://bugs.webkit.org/show_bug.cgi?id=193577
139         <rdar://problem/47408511>
140
141         Unreviewed. Also enable Pointer Events for iosmac.
142
143         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
144
145 2019-01-19  Zalan Bujtas  <zalan@apple.com>
146
147         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
148         https://bugs.webkit.org/show_bug.cgi?id=193613
149
150         Reviewed by Antti Koivisto.
151
152         * LayoutReloaded/misc/LFC-passing-tests.txt:
153
154 2019-01-19  Antoine Quint  <graouts@apple.com>
155
156         Add a POINTER_EVENTS feature flag
157         https://bugs.webkit.org/show_bug.cgi?id=193577
158
159         Reviewed by Dean Jackson.
160
161         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
162
163 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
164
165         Disable the run-jsc-stress-test remote host key check [second round].
166         https://bugs.webkit.org/show_bug.cgi?id=192988
167
168         Reviewed by Dewei Zhu.
169
170         * Scripts/run-jsc-stress-tests:
171
172 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
173
174         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
175         https://bugs.webkit.org/show_bug.cgi?id=193597
176
177         Reviewed by Lucas Forschler.
178
179         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
180
181 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
182
183         [build.webkit.org] api tests failures are incorrectly named as unit test failures
184         https://bugs.webkit.org/show_bug.cgi?id=193595
185
186         Reviewed by Lucas Forschler.
187
188         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
189         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
190         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
191
192 2019-01-18  Chris Dumez  <cdumez@apple.com>
193
194         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
195         https://bugs.webkit.org/show_bug.cgi?id=193588
196         <rdar://problem/47131566>
197
198         Reviewed by Alex Christensen.
199
200         Add layout test coverage.
201
202         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
203
204 2019-01-18  Jer Noble  <jer.noble@apple.com>
205
206         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
207         https://bugs.webkit.org/show_bug.cgi?id=189553
208
209         Reviewed by Tim Horton.
210
211         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
212
213         * ContentExtensionTester/Configurations/Base.xcconfig:
214         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
215         * DumpRenderTree/mac/Configurations/Base.xcconfig:
216         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
217         * ImageDiff/cg/Configurations/Base.xcconfig:
218         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
219         * MiniBrowser/Configurations/Base.xcconfig:
220         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
221         * MobileMiniBrowser/Configurations/Base.xcconfig:
222         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
223         * Scripts/webkitpy/style/checker.py:
224         (_all_categories):
225         (FileType):
226         (CheckerDispatcher._file_type):
227         (CheckerDispatcher._create_checker):
228         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
229         (SDKVariantChecker):
230         (SDKVariantChecker.__init__):
231         (SDKVariantChecker.check):
232         * TestWebKitAPI/Configurations/Base.xcconfig:
233         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
234         * WebEditingTester/Configurations/Base.xcconfig:
235         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
236         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
237         * WebKitTestRunner/Configurations/Base.xcconfig:
238         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
239         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
240         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
241
242 2019-01-18  David Kilzer  <ddkilzer@apple.com>
243
244         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
245         <https://webkit.org/b/193568>
246         <rdar://problem/47381130>
247
248         Reviewed by Alex Christensen.
249
250         Make sure no one re-introduces UIKit soft-linking by adding a
251         style rule.
252
253         * Scripts/webkitpy/style/checkers/cpp.py:
254         (check_language): Add softlink/uikit check.
255         (CppChecker): Enable softlink/uikit check.
256         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
257         (CppStyleTest): Add test for softlink/uikit.
258
259 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
260
261         [GTK] install-dependencies tool looks for libunistring-dev for dnf
262         https://bugs.webkit.org/show_bug.cgi?id=193584
263
264         Change "-dev" to "-devel".
265
266         Reviewed by Michael Catanzaro.
267
268         * gtk/install-dependencies:
269
270 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
271
272         webkitpy: Add iPhone and iPad ports
273         https://bugs.webkit.org/show_bug.cgi?id=193537
274         <rdar://problem/47353390>
275
276         Reviewed by Lucas Forschler.
277
278         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
279         ports. Note that this separation is optional, the --ios-simulator command remains.
280
281         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
282         (RunTest.test_device_type_test_division): Drive-by fix.
283         (RunTest.test_device_type_specific_listing): Ditto.
284         (RunTest.test_ipad_test_division):
285         (RunTest):
286         (RunTest.test_ipad_listing):
287         * Scripts/webkitpy/port/factory.py:
288         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
289         (PortFactory):
290         * Scripts/webkitpy/port/ios_simulator.py:
291         (IPhoneSimulatorPort):
292         (IPadSimulatorPort):
293
294 2019-01-18  Chris Dumez  <cdumez@apple.com>
295
296         Regression(PSON) Scroll position is not always restored properly when navigating back
297         https://bugs.webkit.org/show_bug.cgi?id=193578
298         <rdar://problem/47386331>
299
300         Reviewed by Tim Horton.
301
302         Add API test coverage.
303
304         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
305
306 2019-01-18  Youenn Fablet  <youenn@apple.com>
307
308         Add a new SPI to request for cache storage quota increase
309         https://bugs.webkit.org/show_bug.cgi?id=193323
310
311         Reviewed by Alex Christensen.
312
313         Implement WebsiteDataStore quota delegate to handle quota requests.
314         By default, do not update quota.
315         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
316
317         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
318         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
319         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
320         * WebKitTestRunner/InjectedBundle/TestRunner.h:
321         * WebKitTestRunner/TestController.cpp:
322         (WTR::TestController::allowCacheStorageQuotaIncrease):
323         * WebKitTestRunner/TestController.h:
324         * WebKitTestRunner/TestInvocation.cpp:
325         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
326         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
327         (-[CacheStorageQuotaManager init]):
328         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
329         (WTR::initializeWebViewConfiguration):
330         (WTR::TestController::cocoaResetStateToConsistentValues):
331         (WTR::TestController::allowCacheStorageQuotaIncrease):
332
333 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
334
335         [ews-build] Pass owner to the triggered builds
336         https://bugs.webkit.org/show_bug.cgi?id=193574
337
338         Reviewed by Lucas Forschler.
339
340         * BuildSlaveSupport/ews-build/factories.py:
341         (BuildFactory.propertiesToPassToTriggers):
342
343 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
344
345         [ews-app] Send patch author as a build property
346         https://bugs.webkit.org/show_bug.cgi?id=193560
347
348         Reviewed by Lucas Forschler.
349
350         * BuildSlaveSupport/ews-app/ews/fetcher.py:
351         (BugzillaPatchFetcher.fetch):
352
353 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
354
355         webkitpy: Implement device type specific expected results (Follow-up fix)
356         https://bugs.webkit.org/show_bug.cgi?id=192162
357         <rdar://problem/46345449>
358
359         Unreviewed infrastructure fix.
360
361         * Scripts/webkitpy/layout_tests/controllers/manager.py:
362         (Manager.run): Don't boot a device if no tests are available to run on it.
363
364 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
365
366         webkitpy: Implement device type specific expected results (Follow-up fix)
367         https://bugs.webkit.org/show_bug.cgi?id=192162
368         <rdar://problem/46345449>
369
370         Unreviewed infrastructure fix.
371
372         * Scripts/webkitpy/api_tests/manager.py:
373         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
374
375 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
376
377         webkitpy: Implement device type specific expected results (Part 2)
378         https://bugs.webkit.org/show_bug.cgi?id=192162
379         <rdar://problem/46345449>
380
381         Rubber-stamped by Aakash Jain.
382
383         This change uses device_type to select a different set of TestExpectation files based on the type of device running
384         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
385         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
386
387         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
388         (LayoutTestFinder.find_tests): Pass device_type through.
389         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
390         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
391         * Scripts/webkitpy/layout_tests/controllers/manager.py:
392         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
393         (Manager._collect_tests): Pass device type to test finder.
394         (Manager._needs_web_platform_test):
395         (Manager._prepare_lists): Index _expectations by device type.
396         (Manager._test_input_for_file):
397         (Manager._test_is_slow): Ditto.
398         (Manager._test_should_dump_jsconsolelog_in_stderr):
399         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
400         (Manager._get_test_inputs):
401         (Manager._update_worker_count):
402         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
403         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
404         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
405         the one which runs the test.
406         (Manager._run_test_subset):
407         (Manager._run_tests): Index _expectations by current_device_type.
408         (Manager._print_expectation_line_for_test): Ditto.
409         (Manager._print_expectations_for_subset): Ditto.
410         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
411         Unlike run, this function will behave the same regardless of what devices are available.
412         (Manager._custom_device_for_test): Deleted.
413         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
414         (ManagerTest.test_uses_custom_device): Deleted.
415         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
416         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
417         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
418         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
419         all of the expectations.
420         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
421         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
422         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
423         (TestExpectations.__init__): Allow device_type to be passed through.
424         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
425         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
426         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
427         (summarize_results):
428         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
429         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
430         a test ran with, one must check all expectations to find the first non-skip expectation.
431         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
432         (RunTest.test_device_type_test_division):
433         (RunTest):
434         (RunTest.test_device_type_specific_listing):
435         * Scripts/webkitpy/port/base.py:
436         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
437         (Port.supported_device_types): The result of this function will change based on what devices are available.
438         * Scripts/webkitpy/port/device_port.py:
439         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
440         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
441         can be used.
442         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
443         any, or the DEFAULT_DEVICE_TYPES of the port.
444         * Scripts/webkitpy/port/ios.py:
445         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
446         * Scripts/webkitpy/port/ios_simulator.py:
447         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
448         * Scripts/webkitpy/port/watch.py:
449         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
450         * Scripts/webkitpy/port/watch_simulator.py:
451         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
452         * Scripts/webkitpy/xcode/device_type.py:
453         (DeviceType):
454         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
455
456 2019-01-18  Philippe Normand  <pnormand@igalia.com>
457
458         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
459         https://bugs.webkit.org/show_bug.cgi?id=193575
460
461         Reviewed by Michael Catanzaro.
462
463         Allow the script to run without explicit port argument because
464         it's specific to the WPE port anyway.
465
466         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
467         and simplify the rest of the code accordingly.
468
469 2019-01-18  Charlie Turner  <cturner@igalia.com>
470
471         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
472         https://bugs.webkit.org/show_bug.cgi?id=192229
473
474         Reviewed by Xabier Rodriguez-Calvar.
475
476         * MiniBrowser/wpe/main.cpp:
477         (main): Enable encrypted-media by default.
478
479 2019-01-18  Philippe Normand  <pnormand@igalia.com>
480
481         [Flatpak] Missing KeyboardInterrupt exception handler
482         https://bugs.webkit.org/show_bug.cgi?id=193570
483
484         Reviewed by Michael Catanzaro.
485
486         * flatpak/flatpakutils.py:
487         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
488
489 2019-01-18  Zalan Bujtas  <zalan@apple.com>
490
491         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
492         https://bugs.webkit.org/show_bug.cgi?id=193564
493
494         Reviewed by Antti Koivisto.
495
496         * LayoutReloaded/misc/LFC-passing-tests.txt:
497
498 2019-01-18  Zalan Bujtas  <zalan@apple.com>
499
500         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
501         https://bugs.webkit.org/show_bug.cgi?id=193562
502
503         Reviewed by Antti Koivisto.
504
505         * LayoutReloaded/misc/LFC-passing-tests.txt:
506
507 2019-01-18  Zalan Bujtas  <zalan@apple.com>
508
509         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
510         https://bugs.webkit.org/show_bug.cgi?id=193555
511
512         Reviewed by Antti Koivisto.
513
514         * LayoutReloaded/misc/LFC-passing-tests.txt:
515
516 2019-01-18  Philippe Normand  <pnormand@igalia.com>
517
518         [WPE] Add Qt extension
519         https://bugs.webkit.org/show_bug.cgi?id=191464
520
521         Reviewed by Carlos Garcia Campos.
522
523         MiniBrowser and API tests for the WPE Qt API. To run the
524         MiniBrowser a new script is introduced. Example invocation:
525
526         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
527
528         Also note-worthy is the introduction of the python2-subprocess32
529         dependency to run the GLib API tests.
530
531         * MiniBrowser/wpe/CMakeLists.txt:
532         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
533         * MiniBrowser/wpe/qt/main.cpp: Added.
534         (main):
535         * MiniBrowser/wpe/qt/main.qml: Added.
536         * MiniBrowser/wpe/qt/qml.qrc: Added.
537         * Scripts/run-gtk-tests:
538         (GtkTestRunner.is_google_test):
539         (GtkTestRunner):
540         (GtkTestRunner.is_qt_test):
541         * Scripts/run-qt-wpe-minibrowser: Added.
542         * Scripts/run-wpe-tests:
543         (WPETestRunner):
544         (WPETestRunner.is_google_test):
545         (WPETestRunner.is_qt_test):
546         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
547         (TestLoad::main):
548         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
549         (TestLoadHtml::main):
550         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
551         (TestLoadRequest::main):
552         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
553         (TestRunJavaScript::main):
554         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
555         (waitForSignal):
556         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
557         (LoadSpy::LoadSpy):
558         (LoadSpy::~LoadSpy):
559         (LoadSpy::onLoadingChanged):
560         (LoadStartedCatcher::LoadStartedCatcher):
561         (LoadStartedCatcher::~LoadStartedCatcher):
562         (LoadStartedCatcher::onLoadingChanged):
563         (waitForLoadSucceeded):
564         (waitForLoadFailed):
565         * TestWebKitAPI/glib/CMakeLists.txt:
566         * flatpak/flatpakutils.py:
567         (WebkitFlatpak.load_from_args):
568         (WebkitFlatpak.__init__):
569         (WebkitFlatpak.clean_args):
570         (WebkitFlatpak.run_in_sandbox):
571         * flatpak/org.webkit.CommonModules.yaml:
572         * flatpak/org.webkit.WPE.yaml:
573         * flatpak/org.webkit.WPEModules.yaml:
574         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
575         * flatpak/org.webkit.WebKit.yaml:
576         * glib/api_test_runner.py:
577         (TestRunner._run_test_qt):
578         (TestRunner.is_qt_test):
579         (TestRunner._run_test):
580
581 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
582
583         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
584         https://bugs.webkit.org/show_bug.cgi?id=193494
585         <rdar://problem/46859627>
586
587         Reviewed by Simon Fraser and Tim Horton.
588
589         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
590         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
591
592         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
593         (WTR::UIScriptController::contentOffsetX const):
594         (WTR::UIScriptController::contentOffsetY const):
595         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
596         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
597         (WTR::UIScriptController::contentOffsetX const):
598         (WTR::UIScriptController::contentOffsetY const):
599         * TestRunnerShared/UIScriptContext/UIScriptController.h:
600
601         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
602
603         * WebKitTestRunner/TestController.cpp:
604         (WTR::updateTestOptionsFromTestHeader):
605         * WebKitTestRunner/TestOptions.h:
606         (WTR::TestOptions::hasSameInitializationOptions const):
607         * WebKitTestRunner/ios/TestControllerIOS.mm:
608         (WTR::TestController::platformResetStateToConsistentValues):
609         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
610         (WTR::UIScriptController::contentOffsetX const):
611         (WTR::UIScriptController::contentOffsetY const):
612
613 2019-01-17  Truitt Savell  <tsavell@apple.com>
614
615         Unreviewed, rolling out r240124.
616
617         This commit broke an internal build.
618
619         Reverted changeset:
620
621         "SDK_VARIANT build destinations should be separate from non-
622         SDK_VARIANT builds"
623         https://bugs.webkit.org/show_bug.cgi?id=189553
624         https://trac.webkit.org/changeset/240124
625
626 2019-01-17  Alex Christensen  <achristensen@webkit.org>
627
628         Fix string concatenation API test after r239920
629         https://bugs.webkit.org/show_bug.cgi?id=193551
630         <rdar://problem/47359304>
631
632         Reviewed by Youenn Fablet.
633
634         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
635         (TestWebKitAPI::TEST):
636         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
637         in WebKit's build configuration like it apparently is on Linux.
638
639 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
640
641         [ews-build] validate-patch should handle the case when bug_id is None
642         https://bugs.webkit.org/show_bug.cgi?id=193547
643
644         Reviewed by Lucas Forschler.
645
646         * BuildSlaveSupport/ews-build/steps.py:
647         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
648         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
649
650 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
651
652         [ews-build] Add patch author information in build
653         https://bugs.webkit.org/show_bug.cgi?id=193465
654
655         Reviewed by Lucas Forschler.
656
657         * BuildSlaveSupport/ews-build/steps.py:
658         (ValidatePatch._is_patch_obsolete):
659
660 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
661
662         [ews-build] Pass bug_id to the triggered builds
663         https://bugs.webkit.org/show_bug.cgi?id=193548
664
665         Reviewed by Lucas Forschler.
666
667         * BuildSlaveSupport/ews-build/factories.py:
668         (BuildFactory.propertiesToPassToTriggers):
669
670 2019-01-17  Jer Noble  <jer.noble@apple.com>
671
672         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
673         https://bugs.webkit.org/show_bug.cgi?id=189553
674
675         Reviewed by Tim Horton.
676
677         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
678
679         * ContentExtensionTester/Configurations/Base.xcconfig:
680         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
681         * DumpRenderTree/mac/Configurations/Base.xcconfig:
682         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
683         * ImageDiff/cg/Configurations/Base.xcconfig:
684         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
685         * MiniBrowser/Configurations/Base.xcconfig:
686         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
687         * MobileMiniBrowser/Configurations/Base.xcconfig:
688         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
689         * Scripts/webkitpy/style/checker.py:
690         (_all_categories):
691         (FileType):
692         (CheckerDispatcher._file_type):
693         (CheckerDispatcher._create_checker):
694         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
695         (SDKVariantChecker):
696         (SDKVariantChecker.__init__):
697         (SDKVariantChecker.check):
698         * TestWebKitAPI/Configurations/Base.xcconfig:
699         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
700         * WebEditingTester/Configurations/Base.xcconfig:
701         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
702         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
703         * WebKitTestRunner/Configurations/Base.xcconfig:
704         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
705         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
706         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
707
708 2019-01-17  Zalan Bujtas  <zalan@apple.com>
709
710         [LFC][BFC] An element with transform is a containing block for positioned descendants.
711         https://bugs.webkit.org/show_bug.cgi?id=193534
712
713         Reviewed by Antti Koivisto.
714
715         * LayoutReloaded/misc/LFC-passing-tests.txt:
716
717 2019-01-17  Zalan Bujtas  <zalan@apple.com>
718
719         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
720         https://bugs.webkit.org/show_bug.cgi?id=193528
721
722         Reviewed by Antti Koivisto.
723
724         * LayoutReloaded/misc/LFC-passing-tests.txt:
725
726 2019-01-17  Zalan Bujtas  <zalan@apple.com>
727
728         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
729         https://bugs.webkit.org/show_bug.cgi?id=193520
730
731         Reviewed by Antti Koivisto.
732
733         * LayoutReloaded/misc/LFC-passing-tests.txt:
734
735 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
736
737         [ews-build] unapply-patch step should not update source
738         https://bugs.webkit.org/show_bug.cgi?id=193234
739
740         Reviewed by Lucas Forschler.
741
742         * BuildSlaveSupport/ews-build/steps.py:
743         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
744         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
745
746 2019-01-16  Youenn Fablet  <youenn@apple.com>
747
748         Add a new SPI for controlling getUserMedia
749         https://bugs.webkit.org/show_bug.cgi?id=192793
750
751         Reviewed by Eric Carlson.
752
753         * MiniBrowser/mac/WK2BrowserWindowController.m:
754         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
755         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
756         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
757         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
758         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
759         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
760         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
761         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
762         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
763         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
764         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
765         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
766         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
767         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
768
769 2019-01-16  Zalan Bujtas  <zalan@apple.com>
770
771         [LFC][BFC] Inflow non-replaced used width should not be negative.
772         https://bugs.webkit.org/show_bug.cgi?id=193495
773
774         Reviewed by Antti Koivisto.
775
776         * LayoutReloaded/misc/LFC-passing-tests.txt:
777
778 2019-01-16  Chris Dumez  <cdumez@apple.com>
779
780         Regression(PSON) View becomes blank after click a cross-site download link
781         https://bugs.webkit.org/show_bug.cgi?id=193361
782         <rdar://problem/47099573>
783
784         Reviewed by Geoffrey Garen.
785
786         Add API test coverage.
787
788         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
789         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
790
791 2019-01-16  Zalan Bujtas  <zalan@apple.com>
792
793         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
794         https://bugs.webkit.org/show_bug.cgi?id=193470
795
796         Reviewed by Antti Koivisto.
797
798         * LayoutReloaded/misc/LFC-passing-tests.txt:
799
800 2019-01-16  Zalan Bujtas  <zalan@apple.com>
801
802         [LFC] Adjust margin box verification.
803         https://bugs.webkit.org/show_bug.cgi?id=193482
804
805         Reviewed by Antti Koivisto.
806
807         * LayoutReloaded/misc/LFC-passing-tests.txt:
808
809 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
810
811         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
812         https://bugs.webkit.org/show_bug.cgi?id=193451
813
814         Reviewed by Geoffrey Garen.
815
816         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
817         (TEST):
818         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
819         (runWebsiteDataStoreCustomPaths):
820
821 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
822
823         webkitpy: Support boolean simctl isAvailable
824         https://bugs.webkit.org/show_bug.cgi?id=193472
825         <rdar://problem/47296150>
826
827         Reviewed by Ryosuke Niwa.
828
829         * Scripts/webkitpy/xcode/simulated_device.py:
830         (SimulatedDeviceManager._create_runtimes):
831         (SimulatedDeviceManager._create_device_with_runtime):
832
833 2019-01-15  Chris Dumez  <cdumez@apple.com>
834
835         Unreviewed, rolling out r239993, r239995, r239997, and
836         r239999.
837
838         Caused assertions under
839         ViewGestureController::disconnectFromProcess()
840
841         Reverted changesets:
842
843         "Regression(PSON) View becomes blank after click a cross-site
844         download link"
845         https://bugs.webkit.org/show_bug.cgi?id=193361
846         https://trac.webkit.org/changeset/239993
847
848         "Unreviewed iOS build fix after r239993."
849         https://trac.webkit.org/changeset/239995
850
851         "Fix iOS build after r239993"
852         https://bugs.webkit.org/show_bug.cgi?id=193361
853         https://trac.webkit.org/changeset/239997
854
855         "Unreviewed, revert part of r239997 as it is not needed to fix
856         the build."
857         https://trac.webkit.org/changeset/239999
858
859 2019-01-15  Tim Horton  <timothy_horton@apple.com>
860
861         Cannot tab out of WKWebView on macOS
862         https://bugs.webkit.org/show_bug.cgi?id=161448
863         <rdar://problem/28100085>
864
865         Reviewed by Dean Jackson.
866
867         Add a test that tabbing into and out of WKWebView works correctly.
868
869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
870         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
871         (WebKit2_CommandBackForwardTest::SetUp):
872         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
873         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
874         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
875         (-[FocusableView canBecomeKeyView]):
876         (TEST):
877         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
878         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
879         (-[OffscreenWindow initWithSize:]):
880         (-[OffscreenWindow isKeyWindow]):
881         (-[OffscreenWindow isVisible]):
882         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
883         (TestWebKitAPI::PlatformWebView::initialize):
884         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
885         (-[ActiveOffscreenWindow isVisible]): Deleted.
886         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
887
888 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
889
890         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
891         https://bugs.webkit.org/show_bug.cgi?id=193459
892
893         Reviewed by Mark Lam.
894
895         * BuildSlaveSupport/build.webkit.org-config/steps.py:
896         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
897
898 2019-01-15  Chris Dumez  <cdumez@apple.com>
899
900         Regression(PSON) View becomes blank after click a cross-site download link
901         https://bugs.webkit.org/show_bug.cgi?id=193361
902         <rdar://problem/47099573>
903
904         Reviewed by Geoff Garen.
905
906         Add API test coverage.
907
908         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
909         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
910
911 2019-01-15  Zalan Bujtas  <zalan@apple.com>
912
913         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
914         https://bugs.webkit.org/show_bug.cgi?id=193448
915
916         Reviewed by Antti Koivisto.
917
918         * LayoutReloaded/misc/LFC-passing-tests.txt:
919
920 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
921
922         webkitpy: Implement device type specific expected results (Part 1)
923         https://bugs.webkit.org/show_bug.cgi?id=192162
924
925         Reviewed by Lucas Forschler.
926
927         Device type specific expected results covers two related ideas. The first (covered by this change)
928         is where to search for -expected.* files. The second is which tests to run based on the
929         TestExpectations.txt file.
930
931         After this change, the baseline search path will be determined by the type of device running a
932         test. Device type will be passed into any function which picks a file based on the baseline search
933         path.
934
935         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
936         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
937         * Scripts/webkitpy/layout_tests/controllers/manager.py:
938         (Manager.run): Print baseline search path for each round of devices.
939         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
940         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
941         (SingleTestRunner._expected_driver_output): Ditto.
942         (SingleTestRunner._driver_input): Ditto.
943         * Scripts/webkitpy/layout_tests/views/printing.py:
944         (Printer.print_config): Move printing of baseline search path to a separate function.
945         (Printer.print_baseline_search_path): Moved from Printer.print_config.
946         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
947         (Testprinter.test_print_config):
948         (Testprinter.test_print_baseline_search_path):
949         * Scripts/webkitpy/port/base.py:
950         (Port.baseline_search_path): Pass device_type through.
951         (Port._expected_baselines_for_suffixes): Ditto.
952         (Port.expected_baselines): Ditto.
953         (Port.expected_filename): Ditto.
954         (Port.expected_checksum): Ditto.
955         (Port.expected_image): Ditto.
956         (Port.expected_audio): Ditto.
957         (Port.expected_text): Ditto.
958         (Port.reference_files): Ditto.
959         (Port.tests): Ditto.
960         (Port._expanded_paths): Ditto.
961         (Port.skipped_layout_tests): Ditto.
962         (Port.expectations_dict): Ditto.
963         (Port._port_specific_expectations_files): Ditto.
964         (Port.expectations_files): Ditto.
965         (Port.test_search_path): Ditto.
966         (Port._tests_for_other_platforms): Ditto.
967         * Scripts/webkitpy/port/base_unittest.py:
968         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
969         (PortTest.test_nonexistant_expectations): Ditto.
970         (test_ref_tests_platform_directory): Ditto.
971         * Scripts/webkitpy/port/darwin.py:
972         (DarwinPort._port_specific_expectations_files): Accept device_type.
973         * Scripts/webkitpy/port/driver.py:
974         (DriverProxy):
975         (DriverProxy.host): Expose _target_host for device_type information.
976         * Scripts/webkitpy/port/gtk.py:
977         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
978         * Scripts/webkitpy/port/ios.py:
979         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
980         * Scripts/webkitpy/port/mac.py:
981         (MacPort. default_baseline_search_path): Ditto.
982         * Scripts/webkitpy/port/port_testcase.py:
983         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
984         * Scripts/webkitpy/port/test.py:
985         * Scripts/webkitpy/port/watch.py:
986         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
987         * Scripts/webkitpy/port/win.py:
988         (WinPort.test_search_path): Accept, but do not use, device_type.
989         * Scripts/webkitpy/port/wpe.py:
990         (WPEPort._port_specific_expectations_files): Ditto.
991         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
992         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
993
994 2019-01-15  Zalan Bujtas  <zalan@apple.com>
995
996         [LFC] Use the containing block's padding box to position out-of-flow elements.
997         https://bugs.webkit.org/show_bug.cgi?id=193431
998
999         Reviewed by Antti Koivisto.
1000
1001         * LayoutReloaded/misc/LFC-passing-tests.txt:
1002
1003 2019-01-14  Tim Horton  <timothy_horton@apple.com>
1004
1005         Move a test implementation file that got misplaced in the Xcode project
1006
1007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1008
1009 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1010
1011         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1012         r239913, and r239914.
1013         https://bugs.webkit.org/show_bug.cgi?id=193407
1014
1015         These revisions caused an internal failure (Requested by
1016         Truitt on #webkit).
1017
1018         Reverted changesets:
1019
1020         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1021         https://bugs.webkit.org/show_bug.cgi?id=186016
1022         https://trac.webkit.org/changeset/239901
1023
1024         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1025         https://trac.webkit.org/changeset/239909
1026
1027         "Tried to fix the build."
1028         https://trac.webkit.org/changeset/239910
1029
1030         "Fixed iOS builds after r239910."
1031         https://trac.webkit.org/changeset/239912
1032
1033         "More build fixing."
1034         https://trac.webkit.org/changeset/239913
1035
1036         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1037         https://trac.webkit.org/changeset/239914
1038
1039 2019-01-14  Mark Lam  <mark.lam@apple.com>
1040
1041         Re-enable ability to build --cloop builds.
1042         https://bugs.webkit.org/show_bug.cgi?id=192955
1043         <rdar://problem/46882363>
1044
1045         Reviewed by Saam barati and Keith Miller.
1046
1047         The --cloop build option was being ignored this whole time since r236381.
1048         This patch makes it possible to build CLoop builds again.
1049
1050         * Scripts/build-jsc:
1051         * Scripts/webkitperl/FeatureList.pm:
1052         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1053
1054 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1055
1056         webkitpy: Expose device_type from host-like objects
1057         https://bugs.webkit.org/show_bug.cgi?id=193406
1058         <rdar://problem/47262305>
1059
1060         Reviewed by Lucas Forschler.
1061
1062         Devices should expose device_type. As a result, all host objects should
1063         provide a device_type property, even if they do not yet define a device_type.
1064
1065         * Scripts/webkitpy/common/system/systemhost.py:
1066         (SystemHost):
1067         (SystemHost.device_type):
1068         * Scripts/webkitpy/common/system/systemhost_mock.py:
1069         (MockSystemHost):
1070         (MockSystemHost.device_type):
1071         * Scripts/webkitpy/port/device.py:
1072         (Device):
1073         (Device.device_type):
1074         * Scripts/webkitpy/xcode/simulated_device.py:
1075         (SimulatedDeviceManager._find_exisiting_device_for_request):
1076         (SimulatedDeviceManager._disambiguate_device_type):
1077         (SimulatedDeviceManager._does_fulfill_request):
1078         (SimulatedDeviceManager.device_count_for_type):
1079         (SimulatedDeviceManager.initialize_devices):
1080         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1081         (test_available_devices):
1082         (test_swapping_devices):
1083
1084 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
1085
1086         webkitpy: Support alternate simctl device list output (Follow-up fix)
1087         https://bugs.webkit.org/show_bug.cgi?id=193362
1088         <rdar://problem/47122965>
1089
1090         Rubber-stamped by Lucas Forschler.
1091
1092         * Scripts/webkitpy/xcode/simulated_device.py:
1093         (SimulatedDeviceManager.populate_available_devices):
1094
1095 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1096
1097         [iOS] Expose SPI to access the current sentence boundary and selection state
1098         https://bugs.webkit.org/show_bug.cgi?id=193398
1099         <rdar://problem/45893108>
1100
1101         Reviewed by Dean Jackson.
1102
1103         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
1104         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
1105         expected.
1106
1107         * TestWebKitAPI/EditingTestHarness.h:
1108         * TestWebKitAPI/EditingTestHarness.mm:
1109         (-[EditingTestHarness moveBackward]):
1110         (-[EditingTestHarness moveForward]):
1111         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
1112
1113         Add a couple of new helper methods on EditingTestHarness.
1114
1115         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1116         (-[SelectionChangeObserver initWithWebView:]):
1117         (-[SelectionChangeObserver webView]):
1118         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
1119         (-[SelectionChangeObserver currentSelectionAttributes]):
1120
1121 2019-01-14  Zalan Bujtas  <zalan@apple.com>
1122
1123         [LFC][BFC] Add basic box-sizing support.
1124         https://bugs.webkit.org/show_bug.cgi?id=193392
1125
1126         Reviewed by Antti Koivisto.
1127
1128         * LayoutReloaded/misc/LFC-passing-tests.txt:
1129
1130 2019-01-14  Charlie Turner  <cturner@igalia.com>
1131
1132         [WPE] API test gardening
1133         https://bugs.webkit.org/show_bug.cgi?id=193319
1134
1135         Reviewed by Michael Catanzaro.
1136
1137         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
1138         passing tests.
1139
1140 2019-01-14  Charlie Turner  <cturner@igalia.com>
1141
1142         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
1143         https://bugs.webkit.org/show_bug.cgi?id=192977
1144
1145         Reviewed by Carlos Garcia Campos.
1146
1147         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
1148         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1149         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
1150         (TestWebKitAPI::GStreamerTest::SetUp):
1151         (TestWebKitAPI::GStreamerTest::TearDown):
1152         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
1153         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
1154         (TestWebKitAPI::TEST_F):
1155
1156 2019-01-14  Charlie Turner  <cturner@igalia.com>
1157
1158         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
1159         https://bugs.webkit.org/show_bug.cgi?id=193332
1160
1161         Reviewed by Michael Catanzaro.
1162
1163         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
1164         defined as a char16_t, which changed in ICU 59, the
1165         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
1166         unsigned short. This test is relying on the behaviour that
1167         UChar=unsigned short, which doesn't hold across platforms and ICU
1168         library versions. The full fix would be a special syntax for
1169         literal characters so that these ambiguities do not arise. That
1170         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
1171         (TestWebKitAPI::TEST):
1172
1173 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1174
1175         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
1176
1177         * Scripts/make-dist:
1178         (Distcheck.configure):
1179
1180 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
1181
1182         [ews-build] Update macOS queue configurations
1183         https://bugs.webkit.org/show_bug.cgi?id=193365
1184         <rdar://problem/47221073>
1185
1186         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
1187
1188         * BuildSlaveSupport/ews-build/config.json:
1189
1190 2019-01-13  Zalan Bujtas  <zalan@apple.com>
1191
1192         [LFC] Adjust assert for statically positioned fixed elements
1193         https://bugs.webkit.org/show_bug.cgi?id=193385
1194
1195         Reviewed by Antti Koivisto.
1196
1197         * LayoutReloaded/misc/LFC-passing-tests.txt:
1198
1199 2019-01-13  Philippe Normand  <pnormand@igalia.com>
1200
1201         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
1202         https://bugs.webkit.org/show_bug.cgi?id=193387
1203
1204         Reviewed by Carlos Garcia Campos.
1205
1206         * MiniBrowser/wpe/main.cpp:
1207         (main):
1208
1209 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1210
1211         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1212         https://bugs.webkit.org/show_bug.cgi?id=191655
1213         rdar://problem/46074680
1214
1215         Reviewed by Megan Gardner.
1216
1217         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1218         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1219
1220 2019-01-12  Dan Bernstein  <mitz@apple.com>
1221
1222         [Cocoa] Avoid importing directly from subumbrella frameworks
1223         https://bugs.webkit.org/show_bug.cgi?id=186016
1224         <rdar://problem/40591038>
1225
1226         Reviewed by Sam Weinig.
1227
1228         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1229           LaunchServices header.
1230         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1231           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1232         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1233           when using SDKs earlier than 10.13.
1234         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1235           and OTHER_CPLUSPLUSFLAGS.
1236         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1237           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1238         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1239           LaunchServices header.
1240
1241 2019-01-11  John Wilander  <wilander@apple.com>
1242
1243         Compile out Web API Statistics Collection
1244         https://bugs.webkit.org/show_bug.cgi?id=193370
1245         <rdar://problem/45388584>
1246
1247         Reviewed by Brent Fulgham.
1248
1249         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1250             Defined ENABLE_WEB_API_STATISTICS, off by default.
1251
1252 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1253
1254         [WPE] Add gtk-doc
1255         https://bugs.webkit.org/show_bug.cgi?id=178900
1256
1257         Reviewed by Michael Catanzaro.
1258
1259         Add Tools/gtkdoc to manifest.txt.in files.
1260         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
1261
1262         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
1263         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
1264
1265 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1266
1267         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
1268         https://bugs.webkit.org/show_bug.cgi?id=193364
1269         <rdar://problem/47214117>
1270
1271         Reviewed by Tim Horton.
1272
1273         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
1274         precise, whereas dragging near the middle of the textarea does.
1275
1276         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1277         (TestWebKitAPI::TEST):
1278
1279 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1280
1281         webkitpy: Support alternate simctl device list output
1282         https://bugs.webkit.org/show_bug.cgi?id=193362
1283         <rdar://problem/47122965>
1284
1285         Reviewed by Lucas Forschler.
1286
1287         * Scripts/webkitpy/xcode/simulated_device.py:
1288         (SimulatedDeviceManager.populate_available_devices):
1289
1290 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
1291
1292         [ews-build] Update macOS queue configurations
1293         https://bugs.webkit.org/show_bug.cgi?id=193365
1294
1295         Reviewed by Lucas Forschler.
1296
1297         * BuildSlaveSupport/ews-build/config.json:
1298
1299 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1300
1301         webkitpy: Incorporate device type into baseline search path
1302         https://bugs.webkit.org/show_bug.cgi?id=193356
1303         <rdar://problem/47215515>
1304
1305         Reviewed by Lucas Forschler.
1306
1307         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
1308
1309         * Scripts/webkitpy/port/base.py:
1310         (Port.default_baseline_search_path): Allow device type to be passed in.
1311         * Scripts/webkitpy/port/gtk.py:
1312         (GtkPort.default_baseline_search_path): Ignore device type.
1313         * Scripts/webkitpy/port/ios.py:
1314         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
1315         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
1316         * Scripts/webkitpy/port/ios_device_unittest.py:
1317         (IOSDeviceTest):
1318         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1319         (IOSSimulatorTest):
1320         * Scripts/webkitpy/port/mac.py:
1321         (MacPort.default_baseline_search_path): Ignore device type.
1322         * Scripts/webkitpy/port/watch.py:
1323         (WatchPort.default_baseline_search_path): Ditto.
1324         * Scripts/webkitpy/port/win.py:
1325         (WinPort.default_baseline_search_path): Ditto.
1326         (WinCairoPort.default_baseline_search_path): Ditto.
1327         * Scripts/webkitpy/port/wpe.py:
1328         (WPEPort.default_baseline_search_path): Ditto.
1329
1330 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
1331
1332         webkitpy: Print abbreviated baseline search path that includes only folders that exist
1333         https://bugs.webkit.org/show_bug.cgi?id=193352
1334         <rdar://problem/47210736>
1335
1336         Reviewed by Lucas Forschler.
1337
1338         * Scripts/webkitpy/layout_tests/views/printing.py:
1339         (Printer.print_config): Print list on only baseline search paths which exist. 
1340         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1341         (Testprinter.test_print_config):
1342
1343 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
1344
1345         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
1346         https://bugs.webkit.org/show_bug.cgi?id=193340
1347
1348         Reviewed by David Kilzer.
1349
1350         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1351         (WTR::InjectedBundle::didReceiveMessageToPage):
1352         Pull the strings out into a WKRetainPtr.
1353
1354         * WebKitTestRunner/WebNotificationProvider.cpp:
1355         (WTR::WebNotificationProvider::closeWebNotification):
1356         Adopt the created value into the WKRetainPtr.
1357
1358         * WebKitTestRunner/mac/TestControllerMac.mm:
1359         (WTR::generateWhitelist):
1360         Immediately adopt a created value to avoid potential mistakes.
1361
1362 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
1363
1364         Enable DFG on ARM/Linux again
1365         https://bugs.webkit.org/show_bug.cgi?id=192496
1366
1367         Reviewed by Yusuke Suzuki.
1368
1369         After changing the bytecode format DFG was disabled on all 32-bit
1370         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1371         on ARM by default.
1372
1373         * Scripts/run-jsc-stress-tests:
1374
1375 2019-01-11  Timothy Hatcher  <timothy@apple.com>
1376
1377         Unreviewed, fix #ifdef in API test added in r239851.
1378         https://bugs.webkit.org/show_bug.cgi?id=193327
1379         rdar://problem/47093222
1380
1381         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
1382
1383 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1384
1385         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
1386         https://bugs.webkit.org/show_bug.cgi?id=193109
1387         <rdar://problem/44807048>
1388
1389         Reviewed by Ryosuke Niwa.
1390
1391         Introduce and respect a test option to enable the UndoManager API.
1392
1393         * WebKitTestRunner/TestController.cpp:
1394         (WTR::updateTestOptionsFromTestHeader):
1395         * WebKitTestRunner/TestOptions.h:
1396         (WTR::TestOptions::hasSameInitializationOptions const):
1397         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1398         (WTR::TestController::platformCreateWebView):
1399
1400 2019-01-11  Zalan Bujtas  <zalan@apple.com>
1401
1402         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
1403         https://bugs.webkit.org/show_bug.cgi?id=193346
1404
1405         Reviewed by Antti Koivisto.
1406
1407         * LayoutReloaded/misc/LFC-passing-tests.txt:
1408
1409 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1410
1411         Unreviewed, fix typo that breaks dashboard link.
1412
1413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1414         (WebKitBuildbot):
1415
1416 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1417
1418         Update macOS queue configurations
1419         https://bugs.webkit.org/show_bug.cgi?id=193329
1420
1421         Reviewed by Alexey Proskuryakov.
1422
1423         * BuildSlaveSupport/build.webkit.org-config/config.json:
1424         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1425         (BubbleQueueServer):
1426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1427         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1428         (WebKitBuildbot):
1429         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1430         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
1431         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1432
1433 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1434
1435         MiniBrowser should be able to navigate to about:blank
1436         https://bugs.webkit.org/show_bug.cgi?id=193345
1437
1438         Reviewed by Simon Fraser.
1439
1440         * MiniBrowser/mac/BrowserWindowController.m:
1441         (-[BrowserWindowController addProtocolIfNecessary:]):
1442         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
1443
1444         * MiniBrowser/mac/WK1BrowserWindowController.m:
1445         (-[WK1BrowserWindowController fetch:]):
1446         * MiniBrowser/mac/WK2BrowserWindowController.m:
1447         (-[WK2BrowserWindowController fetch:]):
1448         Clean up the code that uses this to match style.
1449
1450 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1451
1452         Remove MiniBrowser custom "Process Swap" menu item which does not work
1453         https://bugs.webkit.org/show_bug.cgi?id=193344
1454
1455         Reviewed by Simon Fraser.
1456
1457         There is a menu item under the Experimental menu that does work.
1458
1459         * MiniBrowser/mac/AppDelegate.m:
1460         (defaultConfiguration):
1461         * MiniBrowser/mac/SettingsController.h:
1462         * MiniBrowser/mac/SettingsController.m:
1463         (-[SettingsController _populateMenu]):
1464         (-[SettingsController validateMenuItem:]):
1465         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
1466         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
1467
1468 2019-01-10  Timothy Hatcher  <timothy@apple.com>
1469
1470         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
1471         https://bugs.webkit.org/show_bug.cgi?id=193327
1472         rdar://problem/47093222
1473
1474         Reviewed by Tim Horton.
1475
1476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1477         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
1478         (TestWebKitAPI::didFinishNavigation):
1479         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1480         (TestWebKitAPI::TEST):
1481         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
1482         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
1483         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
1484         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
1485         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
1486
1487 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
1488
1489         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
1490         https://bugs.webkit.org/show_bug.cgi?id=193338
1491         <rdar://problem/46664774>
1492
1493         Reviewed by David Kilzer.
1494
1495         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1496         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1497
1498 2019-01-10  Commit Queue  <commit-queue@webkit.org>
1499
1500         Unreviewed, rolling out r239825.
1501         https://bugs.webkit.org/show_bug.cgi?id=193330
1502
1503         Broke tests on armv7/linux bots (Requested by guijemont on
1504         #webkit).
1505
1506         Reverted changeset:
1507
1508         "Enable DFG on ARM/Linux again"
1509         https://bugs.webkit.org/show_bug.cgi?id=192496
1510         https://trac.webkit.org/changeset/239825
1511
1512 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
1513
1514         Disable the run-jsc-stress-test remote host key check.
1515         https://bugs.webkit.org/show_bug.cgi?id=192988
1516
1517         Reviewed by Alexey Proskuryakov.
1518
1519         * Scripts/run-jsc-stress-tests:
1520
1521 2019-01-10  John Wilander  <wilander@apple.com>
1522
1523         Override the session configuration for cookieAcceptPolicy
1524         https://bugs.webkit.org/show_bug.cgi?id=190925
1525         <rdar://problem/45497382>
1526
1527         Reviewed by Alexey Proskuryakov and Alex Christensen.
1528
1529         Test infrastructure for setting a first-party-only cookie policy.
1530
1531         * DumpRenderTree/TestRunner.cpp:
1532         (setOnlyAcceptFirstPartyCookiesCallback):
1533         (TestRunner::staticFunctions):
1534         * DumpRenderTree/TestRunner.h:
1535         * DumpRenderTree/mac/TestRunnerMac.mm:
1536         (TestRunner::setOnlyAcceptFirstPartyCookies):
1537         * DumpRenderTree/win/TestRunnerWin.cpp:
1538         (TestRunner::setOnlyAcceptFirstPartyCookies):
1539         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1540         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1541         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1542         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1543         * WebKitTestRunner/TestInvocation.cpp:
1544         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1545
1546 2019-01-09  Matt Rajca  <mrajca@apple.com>
1547
1548         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
1549         https://bugs.webkit.org/show_bug.cgi?id=193301
1550
1551         Reviewed by Jer Noble.
1552         
1553         Added API tests.
1554
1555         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1556         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1557         (TEST):
1558         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
1559
1560 2019-01-10  Zalan Bujtas  <zalan@apple.com>
1561
1562         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
1563         https://bugs.webkit.org/show_bug.cgi?id=193310
1564
1565         Reviewed by Antti Koivisto.
1566
1567         * LayoutReloaded/misc/LFC-passing-tests.txt:
1568
1569 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
1570
1571         Enable DFG on ARM/Linux again
1572         https://bugs.webkit.org/show_bug.cgi?id=192496
1573
1574         Reviewed by Yusuke Suzuki.
1575
1576         After changing the bytecode format DFG was disabled on all 32-bit
1577         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
1578         on ARM by default.
1579
1580         * Scripts/run-jsc-stress-tests:
1581
1582 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1583
1584         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
1585         https://bugs.webkit.org/show_bug.cgi?id=193271
1586
1587         Reviewed by Brent Fulgham.
1588
1589         BSTR is a special data structure created by SysAllocString, not a
1590         wchar_t null-terminated string.
1591
1592         * DumpRenderTree/win/TestRunnerWin.cpp:
1593         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
1594         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1595         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
1596         BSTR from wide string literals.
1597
1598 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
1599
1600         Tweak wording for build/version_check style checker error
1601         https://bugs.webkit.org/show_bug.cgi?id=193256
1602
1603         Reviewed by Tim Horton.
1604
1605         * Scripts/webkitpy/style/checkers/cpp.py:
1606         (check_os_version_checks):
1607         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1608         (WebKitStyleTest.test_os_version_checks):
1609
1610 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1611
1612         [ews-build] Add link to bug along with bug title
1613         https://bugs.webkit.org/show_bug.cgi?id=193293
1614
1615         Reviewed by Lucas Forschler.
1616
1617         * BuildSlaveSupport/ews-build/steps.py:
1618         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
1619         (ConfigureBuild.add_bug_id_url): Deleted.
1620         (ConfigureBuild.getBugURL): Deleted.
1621
1622 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1623
1624         [ews-build] Use https for ews-build server
1625         https://bugs.webkit.org/show_bug.cgi?id=193193
1626
1627         Reviewed by Lucas Forschler.
1628
1629         * BuildSlaveSupport/ews-build/steps.py:
1630
1631 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1632
1633         [ews-build] Parse and display number of style failures
1634         https://bugs.webkit.org/show_bug.cgi?id=193280
1635
1636         Reviewed by Lucas Forschler.
1637
1638         * BuildSlaveSupport/ews-build/steps.py:
1639         (CheckStyle): Use TestWithFailureCount as base class.
1640         (CheckStyle.countFailures): Count the number of style failures.
1641
1642 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
1643
1644         [ews-build] use patch_id instead of ewspatchid
1645         https://bugs.webkit.org/show_bug.cgi?id=193235
1646
1647         Reviewed by Lucas Forschler.
1648
1649         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
1650         * BuildSlaveSupport/ews-build/steps.py: Ditto.
1651         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
1652
1653 2019-01-09  Zalan Bujtas  <zalan@apple.com>
1654
1655         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
1656         https://bugs.webkit.org/show_bug.cgi?id=192625
1657
1658         Reviewed by Antti Koivisto.
1659
1660         * LayoutReloaded/misc/LFC-passing-tests.txt:
1661
1662 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1663
1664         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
1665         https://bugs.webkit.org/show_bug.cgi?id=192841
1666
1667         Reviewed by Carlos Garcia Campos.
1668
1669         There are separate g_assert_*() macros for use in tests, which we use inconsistently
1670         currently. Use them always. We'll get nicer error messages now when tests fail, and the
1671         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
1672
1673         Note that the documentation of g_assert() says that it is not to be used when writing tests.
1674
1675         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1676         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
1677         (WebKitWebEditorTest::testSelectionChanged):
1678         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1679         (WebKitFrameTest::testMainFrame):
1680         (WebKitFrameTest::testURI):
1681         (WebKitFrameTest::testJavaScriptContext):
1682         (WebKitFrameTest::testJavaScriptValues):
1683         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
1684         (testWebViewAuthenticationRequest):
1685         (testWebViewAuthenticationLoadCancelled):
1686         (testWebViewAuthenticationFailure):
1687         (testWebViewAuthenticationStorage):
1688         (ProxyAuthenticationTest::ProxyAuthenticationTest):
1689         (testWebViewAuthenticationProxy):
1690         (testWebViewAuthenticationProxyHTTPS):
1691         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1692         (testAutomationSessionRequestSession):
1693         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
1694         (testBackForwardListNavigation):
1695         (testWebKitWebViewSessionState):
1696         (testWebKitWebViewSessionStateWithFormData):
1697         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1698         (ConsoleMessageTest::consoleMessageReceivedCallback):
1699         (testWebKitConsoleMessageConsoleAPI):
1700         (testWebKitConsoleMessageJavaScriptException):
1701         (testWebKitConsoleMessageNetworkError):
1702         (testWebKitConsoleMessageSecurityError):
1703         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1704         (testCookieManagerAcceptPolicy):
1705         (testCookieManagerCookiesChanged):
1706         (testCookieManagerPersistentStorage):
1707         (testCookieManagerPersistentStorageDeleteAll):
1708         (testCookieManagerEphemeral):
1709         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
1710         (testWebKitDOMElementAutoFill):
1711         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1712         (downloadLocalFileSuccessfully):
1713         (createFileAtDestination):
1714         (testDownloadOverwriteDestinationDisallowed):
1715         (testDownloadLocalFileError):
1716         (testDownloadRemoteFile):
1717         (testDownloadRemoteFileError):
1718         (testWebViewDownloadURI):
1719         (testPolicyResponseDownload):
1720         (testPolicyResponseDownloadCancel):
1721         (testDownloadMIMEType):
1722         (contextMenuCallback):
1723         (testContextMenuDownloadActions):
1724         (testBlobDownload):
1725         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
1726         (testWebKitWebEditorSelectionChanged):
1727         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1728         (testWebKitFrameMainFrame):
1729         (testWebKitFrameURI):
1730         (testWebKitFrameJavaScriptContext):
1731         (testWebKitFrameJavaScriptValues):
1732         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1733         (LoadStopTrackingTest::loadFailed):
1734         (testWebViewTitle):
1735         (testURIRequestHTTPHeaders):
1736         (testURIRequestHTTPMethod):
1737         (testURIResponseHTTPHeaders):
1738         (testRedirectToDataURI):
1739         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1740         (testProcessPerWebView):
1741         (testWebProcessLimit):
1742         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1743         (testWebViewResources):
1744         (testWebResourceLoading):
1745         (testWebResourceSuggestedFilename):
1746         (testWebResourceGetData):
1747         (testWebResourceGetDataError):
1748         (testWebViewResourcesHistoryCache):
1749         (testWebResourceSendRequest):
1750         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1751         (testSSL):
1752         (testInsecureContent):
1753         (testTLSErrorsPolicy):
1754         (testTLSErrorsRedirect):
1755         (testTLSErrorsHTTPAuth):
1756         (testLoadFailedWithTLSErrors):
1757         (testSubresourceLoadFailedWithTLSErrors):
1758         (httpsServerCallback):
1759         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1760         (testWebViewCreateNavigationData):
1761         (testWebViewJavaScriptDialogs):
1762         (testWebViewWindowProperties):
1763         (testWebViewMouseTarget):
1764         (testWebViewFileChooserRequest):
1765         (testWebViewColorChooserRequest):
1766         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1767         (testWebExtensionGetTitle):
1768         (testDocumentLoadedSignal):
1769         (testWebKitWebViewProcessCrashed):
1770         (testWebExtensionWindowObjectCleared):
1771         (testWebExtensionIsolatedWorld):
1772         (permissionRequestCallback):
1773         (didAssociateFormControlsCallback):
1774         (testWebExtensionFormControlsAssociated):
1775         (FormSubmissionTest::FormSubmissionTest):
1776         (FormSubmissionTest::testFormSubmissionResult):
1777         (testWebExtensionFormSubmissionSteps):
1778         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1779         (testNotInitialized):
1780         (testClearDatabase):
1781         (testPrivateBrowsing):
1782         (testGetFavicon):
1783         (testWebViewFavicon):
1784         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
1785         (testFindControllerTextFound):
1786         (testFindControllerTextNotFound):
1787         (testFindControllerMatchCount):
1788         (testFindControllerMaxMatchCount):
1789         (testFindControllerNext):
1790         (testFindControllerPrevious):
1791         (testFindControllerCountedMatches):
1792         (testFindControllerOptions):
1793         (testFindControllerHide):
1794         (testFindControllerInstance):
1795         (testFindControllerGetters):
1796         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
1797         (testNavigationPolicy):
1798         (testResponsePolicy):
1799         (testNewWindowPolicy):
1800         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
1801         (testSecurityOriginBasicConstructor):
1802         (testSecurityOriginURIConstructor):
1803         (testSecurityOriginDefaultPort):
1804         (testSecurityOriginFileURI):
1805         (testOpaqueSecurityOrigin):
1806         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1807         (testWebKitSettings):
1808         (testWebKitSettingsNewWithSettings):
1809         (testWebKitSettingsUserAgent):
1810         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1811         (testWebViewNewWithUserContentManager):
1812         (isStyleSheetInjectedForURLAtPath):
1813         (isScriptInjectedForURLAtPath):
1814         (testUserContentManagerInjectedStyleSheet):
1815         (testUserContentManagerInjectedScript):
1816         (UserScriptMessageTest::scriptMessageReceived):
1817         (UserScriptMessageTest::waitUntilMessageReceived):
1818         (UserScriptMessageTest::runJavaScriptFinished):
1819         (testUserContentManagerScriptMessageReceived):
1820         (testUserContentManagerScriptMessageInWorldReceived):
1821         (testUserContentManagerScriptMessageFromDOMBindings):
1822         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1823         (testWebContextDefault):
1824         (testWebContextEphemeral):
1825         (testWebContextGetPlugins):
1826         (testWebContextURIScheme):
1827         (testWebContextSpellChecker):
1828         (testWebContextLanguages):
1829         (consoleMessageReceivedCallback):
1830         (testWebContextSecurityFileXHR):
1831         (ProxyTest::ProxyTest):
1832         (testWebContextProxySettings):
1833         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1834         (testWebViewWebContext):
1835         (testWebViewWebBackend):
1836         (testWebViewEphemeral):
1837         (testWebViewCustomCharset):
1838         (testWebViewSettings):
1839         (testWebViewRunJavaScript):
1840         (testWebViewCanShowMIMEType):
1841         (testWebViewSubmitForm):
1842         (testWebViewSave):
1843         (testWebViewPageVisibility):
1844         (testWebViewSnapshot):
1845         (testWebViewNotification):
1846         (testWebViewNotificationInitialPermissionAllowed):
1847         (testWebViewNotificationInitialPermissionDisallowed):
1848         (testWebViewIsPlayingAudio):
1849         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1850         (WebsiteDataTest::WebsiteDataTest):
1851         (WebsiteDataTest::remove):
1852         (WebsiteDataTest::clear):
1853         (testWebsiteDataConfiguration):
1854         (testWebsiteDataEphemeral):
1855         (testWebsiteDataCache):
1856         (testWebsiteDataStorage):
1857         (testWebsiteDataDatabases):
1858         (testWebsiteDataAppcache):
1859         (testWebsiteDataCookies):
1860         (testWebsiteDataDeviceIdHashSalt):
1861         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1862         (emitDocumentLoaded):
1863         (emitURIChanged):
1864         (sendRequestCallback):
1865         (contextMenuCallback):
1866         (consoleMessageSentCallback):
1867         (emitFormControlsAssociated):
1868         (formControlsAssociatedCallback):
1869         (emitFormSubmissionEvent):
1870         (willSubmitFormCallback):
1871         (windowObjectCleared):
1872         (methodCallCallback):
1873         (registerGResource):
1874         (webkit_web_extension_initialize_with_user_data):
1875         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
1876         (checkLeaks):
1877         (WebProcessTest::create):
1878         (runTest):
1879         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
1880         (AutocleanupsTest::testWebProcessAutocleanups):
1881         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
1882         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
1883         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
1884         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
1885         (WebKitDOMDOMWindowTest::testSignals):
1886         (WebKitDOMDOMWindowTest::testDispatchEvent):
1887         (WebKitDOMDOMWindowTest::testGetComputedStyle):
1888         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
1889         (WebKitDOMNodeFilterTest::testTreeWalker):
1890         (WebKitDOMNodeFilterTest::testNodeIterator):
1891         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
1892         (WebKitDOMNodeTest::testHierarchyNavigation):
1893         (WebKitDOMNodeTest::testInsertion):
1894         (WebKitDOMNodeTest::testTagNamesNodeList):
1895         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1896         (WebKitDOMNodeTest::testDOMCache):
1897         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
1898         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1899         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1900         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1901         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
1902         (testUIProcessAutocleanups):
1903         (testWebProcessAutocleanups):
1904         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1905         (testContextMenuPopulateMenu):
1906         (testContextMenuDismissed):
1907         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
1908         (testWebKitDOMClientRectDivBoundingClientRectPosition):
1909         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
1910         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
1911         (testWebKitDOMDOMWindowSignals):
1912         (testWebKitDOMDOMWindowDispatchEvent):
1913         (testWebKitDOMDOMWindowGetComputedStyle):
1914         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
1915         (testWebKitDOMNodeHierarchyNavigation):
1916         (testWebKitDOMNodeInsertion):
1917         (testWebKitDOMNodeTagNamesNodeList):
1918         (testWebKitDOMNodeTagNamesHTMLCollection):
1919         (testWebKitDOMObjectCache):
1920         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
1921         (testWebKitDOMNodeFilterTreeWalker):
1922         (testWebKitDOMNodeFilterNodeIterator):
1923         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
1924         (testWebKitDOMXPathNSResolverNative):
1925         (testWebKitDOMXPathNSResolverCustom):
1926         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
1927         (testInspectorDefault):
1928         (testInspectorManualAttachDetach):
1929         (testInspectorCustomContainerDestroyed):
1930         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
1931         (startTestServer):
1932         (testInspectorServerPageList):
1933         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
1934         (OptionMenuTest::showOptionMenuCallback):
1935         (OptionMenuTest::menuCloseCallback):
1936         (OptionMenuTest::close):
1937         (OptionMenuTest::activateItem):
1938         (OptionMenuTest::selectItem):
1939         (testOptionMenuSimple):
1940         (testOptionMenuGroups):
1941         (testOptionMenuActivate):
1942         (testOptionMenuSelect):
1943         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
1944         (testPrintOperationPrintSettings):
1945         (webViewPrintCallback):
1946         (testPrintOperationPrint):
1947         (testPrintCustomWidget):
1948         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1949         (checkAtspiAccessible):
1950         (testAtspiBasicHierarchy):
1951         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
1952         (testWebKitCheckVersion):
1953         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
1954         (testWebViewEditorCutCopyPasteNonEditable):
1955         (testWebViewEditorCutCopyPasteEditable):
1956         (testWebViewEditorSelectAllNonEditable):
1957         (testWebViewEditorSelectAllEditable):
1958         (loadContentsAndTryToCutSelection):
1959         (testWebViewEditorNonEditable):
1960         (testWebViewEditorEditable):
1961         (testWebViewEditorEditorStateTypingAttributes):
1962         (testWebViewEditorInsertImage):
1963         (testWebViewEditorCreateLink):
1964         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1965         (loadChangedCallback):
1966         (loadFailedCallback):
1967         (loadFailedWithTLSErrorsCallback):
1968         (LoadTrackingTest::LoadTrackingTest):
1969         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1970         (registerGResource):
1971         (removeNonEmptyDirectory):
1972         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1973         (Test::adoptView):
1974         (Test::~Test):
1975         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1976         (WebKitTestBus::getOrCreateConnection):
1977         (WebKitTestBus::createProxy):
1978         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1979         (WebKitTestServer::getWebSocketURIForPath const):
1980         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1981         (WebViewTest::initializeWebView):
1982         (WebViewTest::loadURI):
1983         (WebViewTest::loadHtml):
1984         (WebViewTest::loadPlainText):
1985         (WebViewTest::loadBytes):
1986         (WebViewTest::loadRequest):
1987         (WebViewTest::loadAlternateHTML):
1988         (WebViewTest::goBack):
1989         (WebViewTest::goForward):
1990         (WebViewTest::goToBackForwardListItem):
1991         (resourceGetDataCallback):
1992         (WebViewTest::mainResourceData):
1993         (WebViewTest::javascriptResultToCString):
1994         (WebViewTest::javascriptResultToNumber):
1995         (WebViewTest::javascriptResultToBoolean):
1996         (WebViewTest::javascriptResultIsNull):
1997         (WebViewTest::javascriptResultIsUndefined):
1998         (onSnapshotReady):
1999         (WebViewTest::runWebProcessTest):
2000         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
2001         (WebViewTest::platformInitializeWebView):
2002         (WebViewTest::showInWindow):
2003         (WebViewTest::showInWindowAndWaitUntilMapped):
2004         (WebViewTest::mouseMoveTo):
2005         (WebViewTest::emitPopupMenuSignal):
2006         (WebViewTest::keyStroke):
2007         (WebViewTest::doMouseButtonEvent):
2008
2009 2019-01-09  Philippe Normand  <pnormand@igalia.com>
2010
2011         [WPE] API tests can't run in flatpak environment
2012         https://bugs.webkit.org/show_bug.cgi?id=193242
2013
2014         Reviewed by Michael Catanzaro.
2015
2016         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
2017         flatpakutils so that it knows which port it's dealing with.
2018         * glib/common.py: Remove build_dir globals so that subsequent
2019         calls actually take args into account.
2020         (library_build_path):
2021         (binary_build_path):
2022
2023 2019-01-08  Dean Jackson  <dino@apple.com>
2024
2025         Blob references for System Previews don't get a correct file extension
2026         https://bugs.webkit.org/show_bug.cgi?id=193268
2027         <rdar://problem/47133037>
2028
2029         Reviewed by Tim Horton.
2030
2031         New test that a Blob download of a USDZ file gets named correctly.
2032
2033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2034         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2035         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2036         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
2037         (TEST):
2038         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
2039
2040 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
2041
2042         [WebAuthN] Support U2F HID Authenticators on macOS
2043         https://bugs.webkit.org/show_bug.cgi?id=191535
2044         <rdar://problem/47102027>
2045
2046         Reviewed by Brent Fulgham.
2047
2048         This patch:
2049         1) adds support for U2F mocking mechanism;
2050         2) updates tests to reflect U2fCommandConstructor changes.
2051
2052         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2053         (TestWebKitAPI::TEST):
2054         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2055         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2056         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2057
2058 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2059
2060         [iOS] Dispatch a synthetic mousedown event prior to starting drags
2061         https://bugs.webkit.org/show_bug.cgi?id=193229
2062         <rdar://problem/46717097>
2063
2064         Reviewed by Tim Horton.
2065
2066         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
2067         prevents a drag from starting.
2068
2069         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2070         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
2071
2072         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
2073
2074 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
2075   
2076         Layout test will generate a perf metric file to results dir.
2077         https://bugs.webkit.org/show_bug.cgi?id=192030
2078         <rdar://problem/32779516>
2079
2080         Reviewed by Aakash Jain.
2081
2082         Layout test running time will be collected to a perf metric file.
2083         For now, instead of outputing running time of all tests (which is huge),
2084         we aggregate them by test directories which are at most two level deep. 
2085
2086         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2087         (Manager._end_test_run):
2088         (Manager._output_perf_metrics):
2089         (Manager._print_expectation_line_for_test):
2090         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2091         (add_test_perf_metric):
2092         (test_perf_metrics):
2093         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2094         (JSONGeneratorTest.test_test_timings_trie):
2095         (JSONGeneratorTest):
2096         (JSONGeneratorTest.test_test_perf_metrics):
2097         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2098         (RebaselineTest.test_reset_results):
2099         (RebaselineTest.test_missing_results):
2100         (RebaselineTest.test_new_baseline):
2101
2102 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
2103
2104         [WPE][GTK] Add php-json to install-dependencies
2105         https://bugs.webkit.org/show_bug.cgi?id=193233
2106
2107         Reviewed by Michael Catanzaro.
2108
2109         * gtk/install-dependencies:
2110         * wpe/install-dependencies:
2111
2112 2019-01-08  Chris Dumez  <cdumez@apple.com>
2113
2114         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
2115         https://bugs.webkit.org/show_bug.cgi?id=193224
2116         <rdar://problem/47097726>
2117
2118         Reviewed by Alex Christensen.
2119
2120         Add API test coverage.
2121
2122         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2123
2124 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2125
2126         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
2127         <https://webkit.org/b/193222>
2128         <rdar://problem/46862309>
2129
2130         Reviewed by Joseph Pecoraro.
2131
2132         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2133         (WTR::executeCallback): Fix camel case of variable name.
2134         (WTR::EventSendingController::callAfterScrollingCompletes): If
2135         WKBundlePageRegisterScrollOperationCompletionCallback() returns
2136         false, make sure to release the ScrollCompletionCallbackData
2137         object.  This fixes the leak.
2138
2139 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2140
2141         [Win] EWS: wincairo-ews cannot apply a patch with *.png
2142         https://bugs.webkit.org/show_bug.cgi?id=193044
2143
2144         Reviewed by Daniel Bates.
2145
2146         WinCairo EWS bots are using Windows Perl. Binary files should be
2147         opened as binary mode.
2148
2149         * Scripts/svn-apply:
2150         (handleGitBinaryChange): Use 'binmode' for binary file handles.
2151
2152 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
2153
2154         [CMake] Add ENABLE_CSS_TYPED_OM option
2155         https://bugs.webkit.org/show_bug.cgi?id=193216
2156
2157         Reviewed by Michael Catanzaro.
2158
2159         * Scripts/webkitperl/FeatureList.pm:
2160
2161 2019-01-07  David Kilzer  <ddkilzer@apple.com>
2162
2163         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
2164         <https://webkit.org/b/193056>
2165
2166         Reviewed by Alex Christensen.
2167
2168         * Scripts/webkitpy/style/checker.py:
2169         - Ignore use of new runtime/retainptr check in
2170           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
2171           contains tests to ensure RetainPtr<NSObject *> is compatible
2172           with RetainPtr<NSObject>.
2173
2174         * Scripts/webkitpy/style/checkers/cpp.py:
2175         (check_language):
2176         (CppChecker):
2177         - Add checker for use of '*' in RetainPtr<> type.  A for loop
2178           was used instead of a single regex so that angle brackets
2179           could be matched up when checking the type contained within
2180           the RetainPtr<> type.
2181
2182         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2183         (CppStyleTest):
2184         - Add unit test for new runtime/retainptr check.
2185
2186         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
2187         * TestWebKitAPI/EditingTestHarness.h:
2188         - Remove '*' from RetainPtr<> type.
2189
2190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2191         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
2192           regressed in r201938.
2193
2194         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2195         (TestWebKitAPI::TEST):
2196         - Update tests to match RetainPtr.mm tests (except for the
2197           `*SimilarNSType` tests since there is no CF equivalent of
2198           RetainPtr<NSString> and RetainPtr<NSString *>).
2199
2200         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2201         (TestWebKitAPI::TEST):
2202         - Update tests to:
2203           - Not conflict by name with equivalent CF tests in
2204             RetainPtr.cpp.
2205           - Add test cases for RetainPtr<NSObject>,
2206             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
2207           - Add `*SimilarNSType` tests for converting between
2208             RetainPtr<NSObject> and RetainPtr<NSObject *>.
2209           - Change `0` to `nil` as appropriate.
2210           - Re-alphabetize the tests by name.
2211           - Add Optional<RetainPtr<>> tests.
2212           - Add retainPtr() tests.
2213
2214         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2215         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2216         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
2217         (TEST):
2218         - Remove '*' from RetainPtr<> type.
2219
2220         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
2221         (TEST(WebKit, JITEnabled)):
2222         - Add missing WTFMove().  Apparently a temporary was being
2223           created before in the argument list due to mismatched
2224           RetainPtr<> types.
2225
2226         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2227         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
2228         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
2229         (TestWebKitAPI::TEST):
2230         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2231         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2232         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2233         (WTR::resourcesDirectoryURL):
2234         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2235         (WTR::InjectedBundle::platformInitialize):
2236         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2237         - Remove '*' from RetainPtr<> type.
2238
2239 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
2240
2241         A MediaTime timescale must never be zero
2242         https://bugs.webkit.org/show_bug.cgi?id=193156
2243         <rdar://problem/32504501>
2244
2245         Reviewed by Jer Noble.
2246
2247         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2248         (TestWebKitAPI::TEST): Add tests for zero timescale.
2249
2250 2019-01-07  Youenn Fablet  <youenn@apple.com>
2251
2252         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
2253         https://bugs.webkit.org/show_bug.cgi?id=193175
2254
2255         Reviewed by Chris Dumez.
2256
2257         Updated API test as we bumped the SW schema to version 4.
2258
2259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2260         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
2261         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2262         (TEST):
2263
2264 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2265
2266         [Win][Clang] Fix compilation warnings of MiniBrowser
2267         https://bugs.webkit.org/show_bug.cgi?id=193029
2268
2269         Reviewed by Ross Kirsling.
2270
2271         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
2272         and m_URLBarFont. Reorder member variables to fix -Wreorder
2273         warning.
2274         * MiniBrowser/win/PageLoadTestClient.cpp:
2275         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
2276         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
2277         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
2278         m_currentURLIndex.
2279         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2280         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
2281         navigationClient with '{ }' to fix the missing field warning.
2282         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2283         (initDocStruct): Changed the argument type docname to const.
2284
2285 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
2286
2287         [WebAuthN] Import U2F command/response converters from Chromium
2288         https://bugs.webkit.org/show_bug.cgi?id=193150
2289         <rdar://problem/47054028>
2290
2291         Reviewed by Brent Fulgham.
2292
2293         Adds API tests.
2294
2295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2296         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
2297         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
2298         (TestWebKitAPI::getTestAuthenticatorDataBytes):
2299         (TestWebKitAPI::getTestAttestationObjectBytes):
2300         (TestWebKitAPI::getTestSignResponse):
2301         (TestWebKitAPI::getTestU2fRegisterResponse):
2302         (TestWebKitAPI::TEST):
2303         (TestWebKitAPI::convertToVector): Deleted.
2304         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2305         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
2306         (TestWebKitAPI::constructMakeCredentialRequest):
2307         (TestWebKitAPI::constructGetAssertionRequest):
2308         (TestWebKitAPI::TEST):
2309
2310 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
2311
2312         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
2313         https://bugs.webkit.org/show_bug.cgi?id=193136
2314
2315         Reviewed by Michael Catanzaro.
2316
2317         * gtk/install-dependencies:
2318         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
2319         they are needed by update-webkitgtk-libs.
2320
2321 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
2322
2323         Unreviewed follow-up fix to r239650
2324         https://bugs.webkit.org/show_bug.cgi?id=193140
2325         <rdar://problem/47063037>
2326
2327         Typecast patch_id to string.
2328
2329         * BuildSlaveSupport/ews-build/steps.py:
2330         (ValidatePatch._is_patch_obsolete):
2331
2332 2019-01-04  Daniel Bates  <dabates@apple.com>
2333
2334         [lldb-webkit]: Add support for pretty-printing raw bitmask types
2335         https://bugs.webkit.org/show_bug.cgi?id=193024
2336
2337         Reviewed by Jer Noble.
2338
2339         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
2340         for the bitmask type WebEventFlags as an example.
2341
2342         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
2343         that can be used to register summary and synthetic child formatters for a bitmask type.
2344         For example, consider the following enum and bitmask typedefs:
2345
2346         typedef enum {
2347             A = 1 << 0,
2348             B = 1 << 1,
2349             C = 1 << 2,
2350         } SpecialFlagValues;
2351         typedef unsigned SpecialFlags;
2352
2353         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
2354         __lldb_init_module():
2355
2356             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
2357                     1 << 0: "A",
2358                     1 << 1: "B",
2359                     1 << 2: "C",
2360             })
2361
2362         * lldb/lldb_webkit.py:
2363         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2364         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
2365         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
2366         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
2367         A convenience function to dynamically creaste a synthetic formatter class and summary
2368         string function for the specified bitmask type and enumerator value to name map. This
2369         function register the dynamically created class and function with LLDB.
2370
2371         (__lldb_init_module):
2372         (FlagEnumerationProvider):
2373         (FlagEnumerationProvider._enumerator_value_to_name_map):
2374         (FlagEnumerationProvider._bitmask):
2375         (FlagEnumerationProvider._update):
2376         (FlagEnumerationProvider.has_children):
2377         (FlagEnumerationProvider.num_children):
2378         (FlagEnumerationProvider.get_child_index):
2379         (FlagEnumerationProvider.get_child_at_index):
2380         (FlagEnumerationProvider.update):
2381         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
2382
2383         (WTFOptionSetProvider):
2384         (WTFOptionSetProvider._enumerator_value_to_name_map):
2385         (WTFOptionSetProvider._bitmask):
2386         (WTFOptionSetProvider._update):
2387         Write in terms of the base class.
2388
2389         (RawBitmaskProviderBase):
2390         (RawBitmaskProviderBase._enumerator_value_to_name_map):
2391         (RawBitmaskProviderBase._bitmask):
2392         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
2393         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
2394         {
2395             1 << 0: "A",
2396             1 << 1: "B",
2397             1 << 2: "C",
2398         }
2399         It is not necessary to instantiate such a derived class directory. Instead use the convenience
2400         function addSummaryAndSyntheticFormattersForRawBitmaskType.
2401
2402         (WTFOptionSetProvider.has_children): Deleted.
2403         (WTFOptionSetProvider.num_children): Deleted.
2404         (WTFOptionSetProvider.get_child_index): Deleted.
2405         (WTFOptionSetProvider.get_child_at_index): Deleted.
2406         (WTFOptionSetProvider.update): Deleted.
2407
2408 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2409
2410         [ews-build] Add build step to validate the patch before processing it
2411         https://bugs.webkit.org/show_bug.cgi?id=193140
2412
2413         Reviewed by Lucas Forschler.
2414
2415         * BuildSlaveSupport/ews-build/factories.py:
2416         (Factory.__init__): Added ValidatePatch step.
2417         * BuildSlaveSupport/ews-build/steps.py:
2418         (ValidatePatch):
2419         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
2420         (ValidatePatch.get_patch_json): Get patch json data.
2421         (ValidatePatch.get_bug_json): Get bug json data.
2422         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
2423         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
2424         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
2425         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
2426         (ValidatePatch.skip_build): Skip the build.
2427         (ValidatePatch.start):
2428
2429 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2430
2431         Progress towards fixing Mac CMake build
2432         https://bugs.webkit.org/show_bug.cgi?id=193105
2433
2434         Reviewed by Don Olmstead.
2435
2436         * TestWebKitAPI/PlatformMac.cmake:
2437
2438 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2439
2440         Fix API test after r239631
2441         https://bugs.webkit.org/show_bug.cgi?id=193118
2442
2443         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2444         (TestWebKitAPI::TEST):
2445         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
2446         Do the same thing via the API to fix the test.
2447
2448 2019-01-04  Jer Noble  <jer.noble@apple.com>
2449
2450         [WebKitLegacy] Media playback pauses on scroll
2451         https://bugs.webkit.org/show_bug.cgi?id=192829
2452
2453         Reviewed by Eric Carlson.
2454
2455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2456         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
2457         (TestWebKitAPI::TEST):
2458         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
2459         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
2460         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
2461         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
2462         (TestWebKitAPI::TEST):
2463
2464 2019-01-04  Chris Dumez  <cdumez@apple.com>
2465
2466         Add support for toggling device orientation API support per site
2467         https://bugs.webkit.org/show_bug.cgi?id=193143
2468         <rdar://problem/46605724>
2469
2470         Reviewed by Alex Christensen.
2471
2472         Add API test coverage.
2473
2474         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2475         (-[DataMappingSchemeHandler setTaskHandler:]):
2476         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
2477         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
2478         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2479         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
2480
2481 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2482
2483         [ews-build] use svn-apply script to apply the patches
2484         https://bugs.webkit.org/show_bug.cgi?id=193138
2485
2486         Reviewed by Lucas Forschler.
2487
2488         * BuildSlaveSupport/ews-build/factories.py:
2489         (Factory.__init__): Add the ApplyPatch step.
2490         * BuildSlaveSupport/ews-build/steps.py:
2491         (CheckOutSource): Added step name.
2492         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
2493         (ApplyPatch): Build step to apply patch using svn-apply script.
2494         (UnApplyPatchIfRequired):
2495         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
2496
2497 2019-01-04  Alex Christensen  <achristensen@webkit.org>
2498
2499         Deprecate WKContextCreate
2500         https://bugs.webkit.org/show_bug.cgi?id=193118
2501
2502         Reviewed by Brady Eidson.
2503
2504         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2505         (WebKitBrowserWindow::WebKitBrowserWindow):
2506         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
2507         (TestWebKitAPI::TEST):
2508         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2509         (TestWebKitAPI::TEST):
2510         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
2511         (TestWebKitAPI::TEST):
2512         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
2513         (TestWebKitAPI::TEST):
2514         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
2515         (TestWebKitAPI::TEST):
2516         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
2517         (TestWebKitAPI::TEST):
2518         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
2519         (TestWebKitAPI::TEST):
2520         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
2521         (TestWebKitAPI::TEST):
2522         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
2523         (TestWebKitAPI::TEST):
2524         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
2525         (TestWebKitAPI::TEST):
2526         * TestWebKitAPI/Tests/WebKit/Find.cpp:
2527         (TestWebKitAPI::TEST):
2528         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
2529         (TestWebKitAPI::TEST):
2530         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
2531         (TestWebKitAPI::TEST):
2532         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
2533         (TestWebKitAPI::TEST):
2534         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
2535         (TestWebKitAPI::TEST):
2536         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
2537         (TestWebKitAPI::TEST):
2538         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
2539         (TestWebKitAPI::TEST):
2540         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2541         (TestWebKitAPI::TEST):
2542         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2543         (TestWebKitAPI::loadAlternateHTMLString):
2544         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
2545         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2546         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
2547         (TestWebKitAPI::buildAndPerformTest):
2548         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2549         (TestWebKitAPI::TEST):
2550         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
2551         (TestWebKitAPI::TEST):
2552         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
2553         (TestWebKitAPI::TEST):
2554         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
2555         (TestWebKitAPI::TEST):
2556         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2557         (TestWebKitAPI::TEST):
2558         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
2559         (TestWebKitAPI::TEST):
2560         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
2561         (TestWebKitAPI::TEST):
2562         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2563         (TestWebKitAPI::TEST):
2564         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
2565         (TestWebKitAPI::TEST):
2566         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2567         (TestWebKitAPI::TEST):
2568         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
2569         (TestWebKitAPI::TEST):
2570         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
2571         (TestWebKitAPI::TEST):
2572         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
2573         (TestWebKitAPI::TEST):
2574         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
2575         (TestWebKitAPI::TEST):
2576         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
2577         (TestWebKitAPI::TEST):
2578         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
2579         (TestWebKitAPI::TEST):
2580         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
2581         (TestWebKitAPI::TEST):
2582         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2583         (TestWebKitAPI::TEST):
2584         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
2585         (TestWebKitAPI::TEST):
2586         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
2587         (TestWebKitAPI::TEST):
2588         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
2589         (TestWebKitAPI::TEST):
2590         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
2591         (TestWebKitAPI::TEST):
2592         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
2593         (TestWebKitAPI::TEST):
2594         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
2595         (TestWebKitAPI::TEST):
2596         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2597         (TestWebKitAPI::TEST):
2598         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
2599         (TestWebKitAPI::TEST):
2600         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2601         (WebKit2_CommandBackForwardTestWKView::SetUp):
2602         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
2603         (TestWebKitAPI::TEST):
2604         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
2605         (TestWebKitAPI::TEST):
2606         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
2607         (TestWebKitAPI::TEST):
2608         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2609         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2610
2611 2019-01-03  Matt Rajca  <mrajca@apple.com>
2612
2613         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
2614         https://bugs.webkit.org/show_bug.cgi?id=193128
2615         rdar://34554231
2616
2617         Reviewed by Jer Noble.
2618
2619         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
2620         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
2621         event along with a flag that indicates whether or not autoplay was actually prevented.
2622
2623         Tests: existing API tests were updated to reflect the new names. New API tests
2624         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
2625
2626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2627         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
2628         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2629         (TEST):
2630         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
2631         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
2632
2633 2019-01-04  Chris Dumez  <cdumez@apple.com>
2634
2635         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
2636         https://bugs.webkit.org/show_bug.cgi?id=193120
2637
2638         Reviewed by Alex Christensen.
2639
2640         Add API test coverage.
2641
2642         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2643
2644 2019-01-04  Chris Dumez  <cdumez@apple.com>
2645
2646         Crash under WebProcessPool::addSuspendedPage()
2647         https://bugs.webkit.org/show_bug.cgi?id=193110
2648
2649         Reviewed by Youenn Fablet.
2650
2651         Add API test coverage.
2652
2653         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2654
2655 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2656
2657         [ews-build] Check patch relevance before applying the patch
2658         https://bugs.webkit.org/show_bug.cgi?id=193102
2659
2660         Reviewed by Lucas Forschler.
2661
2662         * BuildSlaveSupport/ews-build/factories.py:
2663         (Factory.__init__): Moved CheckPatchRelevance step to base class.
2664
2665 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
2666
2667         [ews-build] Check patch relevance step should print patch id
2668         https://bugs.webkit.org/show_bug.cgi?id=193137
2669
2670         Reviewed by Lucas Forschler.
2671
2672         * BuildSlaveSupport/ews-build/steps.py:
2673         (CheckPatchRelevance.start): Update the status to include patch id.
2674
2675 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
2676
2677         webkitpy: Increase simulator teardown timeout
2678         https://bugs.webkit.org/show_bug.cgi?id=193141
2679         <rdar://problem/46174217>
2680
2681         Rubber-stamped by Aakash Jain.
2682
2683         * Scripts/webkitpy/xcode/simulated_device.py:
2684         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
2685
2686 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
2687
2688         test262-runner misbehaves when test file YAML has a trailing space
2689         https://bugs.webkit.org/show_bug.cgi?id=193053
2690
2691         Reviewed by Yusuke Suzuki.
2692
2693         * Scripts/test262/Runner.pm:
2694         (parseData):
2695         Accept trailing space when parsing a test file's YAML block.
2696
2697 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2698
2699         UserMedia test should use WKPageNavigationClient
2700         https://bugs.webkit.org/show_bug.cgi?id=192913
2701
2702         Reviewed by Youenn Fablet.
2703
2704         The test currently uses the deprecated WKPageLoaderClient. It should use
2705         WKPageNavigationClient instead, which provides the same callback under a similar name.
2706
2707         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2708         (TestWebKitAPI::TEST):
2709
2710 2019-01-02  Alex Christensen  <achristensen@webkit.org>
2711
2712         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
2713         https://bugs.webkit.org/show_bug.cgi?id=192944
2714
2715         Reviewed by Tim Horton.
2716
2717         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2718         (TestWebKitAPI::TEST):
2719
2720 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2721
2722         Add support for using the current text selection as the find string on iOS
2723         https://bugs.webkit.org/show_bug.cgi?id=193034
2724         <rdar://problem/45138739>
2725
2726         Reviewed by Tim Horton.
2727
2728         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
2729         _setStringForFind) works as expected.
2730
2731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2732         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
2733
2734 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
2735
2736         [ews-build] Use git on OpenSource EWS bots
2737         https://bugs.webkit.org/show_bug.cgi?id=193092
2738
2739         Reviewed by Lucas Forschler.
2740
2741         * BuildSlaveSupport/ews-build/steps.py:
2742         (CheckOutSource): Use git instead of svn.
2743         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
2744
2745 2019-01-02  Daniel Bates  <dabates@apple.com>
2746
2747         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
2748         https://bugs.webkit.org/show_bug.cgi?id=193023
2749
2750         Reviewed by Simon Fraser.
2751
2752         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
2753         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
2754         enumerator values. We should just remove this code.
2755
2756         * lldb/lldb_webkit.py:
2757         (WTFOptionSetProvider.has_children):
2758         (WTFOptionSetProvider.num_children):
2759         (WTFOptionSetProvider.get_child_index):
2760         (WTFOptionSetProvider.get_child_at_index):
2761
2762 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2763
2764         .ycm_extra_conf.py should handle XXXInlines.h
2765         https://bugs.webkit.org/show_bug.cgi?id=193055
2766
2767         Reviewed by Carlos Garcia Campos.
2768
2769         compile_commands.json database only records flags and options for cpp source files.
2770         So, when we open headers, this database does not have any information for that.
2771         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
2772         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
2773         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
2774         we attempt to find XXX.cpp and use the configuration if it exists.
2775
2776         * gtk/ycm_extra_conf.py:
2777         (getImplementationFilename):
2778         (FlagsForFile):
2779
2780 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2781
2782         Unreviewed. Support PHP 7.3 in Debian.
2783
2784         Add 7.3 to the list of php versions supported in Debian.
2785
2786         * Scripts/webkitpy/port/base.py:
2787         (Port._debian_php_version):
2788
2789 2018-12-27  Alex Christensen  <achristensen@webkit.org>
2790
2791         Resurrect Mac CMake build
2792         https://bugs.webkit.org/show_bug.cgi?id=192658
2793
2794         Reviewed by Yusuke Suzuki.
2795
2796         * DumpRenderTree/PlatformMac.cmake:
2797         * MiniBrowser/mac/CMakeLists.txt:
2798         * TestWebKitAPI/PlatformMac.cmake:
2799
2800 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
2801
2802         [Tools] Remove references to Bison and Flex
2803         https://bugs.webkit.org/show_bug.cgi?id=193033
2804
2805         Reviewed by Michael Catanzaro.
2806
2807         The Bison and Flex tools are not needed anymore since r209883.
2808
2809         * CygwinDownloader/cygwin-downloader.py:
2810         * EWSTools/ubuntu-ews-packages:
2811         * Scripts/filter-build-webkit:
2812         (shouldIgnoreLine):
2813         * gtk/install-dependencies:
2814         * wpe/install-dependencies:
2815
2816 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2817
2818         WebDriver: warn about non existing tests when parsing expectations
2819         https://bugs.webkit.org/show_bug.cgi?id=192979
2820
2821         Reviewed by Michael Catanzaro.
2822
2823         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
2824         renamed.
2825
2826         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2827         (WebDriverTestRunner.__init__):
2828
2829 2018-12-21  Chris Dumez  <cdumez@apple.com>
2830
2831         navigator.userAgent in service workers does not reflect customUserAgent set by client
2832         https://bugs.webkit.org/show_bug.cgi?id=192951
2833
2834         Reviewed by Youenn Fablet.
2835
2836         Extend API test coverage.
2837
2838         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2839         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
2840         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2841         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
2842         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
2843
2844 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2845
2846         [WebAuthN] userPresence should always be true
2847         https://bugs.webkit.org/show_bug.cgi?id=192835
2848         <rdar://problem/46538788>
2849
2850         Reviewed by Brent Fulgham.
2851
2852         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2853         (TestWebKitAPI::TEST):
2854
2855 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
2856
2857         Add support to run-benchmark to use non-default copies of the browser apps
2858         https://bugs.webkit.org/show_bug.cgi?id=192905
2859         rdar://problem/46845840
2860
2861         Reviewed by Dewei Zhu.
2862         
2863         Add support for a --browser-path argument to run-benchmark, which allows you to use
2864         a custom app bundle for a given browser (only implemented for Safari at present).
2865
2866         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2867         (BenchmarkRunner.__init__):
2868         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2869         (BrowserDriver.__init__):
2870         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2871         (BrowserDriverFactory.create):
2872         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2873         (OSXBrowserDriver._launch_process):
2874         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
2875         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
2876         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2877         (OSXChromeCanaryDriver.launch_url):
2878         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2879         (OSXFirefoxNightlyDriver.launch_url):
2880         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2881         (OSXSafariDriver.__init__):
2882         (OSXSafariDriver.launch_url):
2883         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2884         (parse_args):
2885         (run_benchmark_plan):
2886         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2887         (WebServerBenchmarkRunner.__init__):
2888         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
2889         (FakeBenchmarkRunner.__init__):
2890
2891 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
2892
2893         [WebAuthN] Import an APDU coder from Chromium
2894         https://bugs.webkit.org/show_bug.cgi?id=192949
2895         <rdar://problem/46879933>
2896
2897         Reviewed by Brent Fulgham.
2898
2899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2900         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
2901         (TestWebKitAPI::TEST):
2902
2903 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2904
2905         Setting the file wrapper and content type of an attachment to a PDF should update its image
2906         https://bugs.webkit.org/show_bug.cgi?id=192984
2907         <rdar://problem/46798028>
2908
2909         Reviewed by Tim Horton.
2910
2911         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
2912         PDF data correctly updates the image element.
2913
2914         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2915
2916 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2917
2918         Add JSCOnly to bot dashboard
2919         https://bugs.webkit.org/show_bug.cgi?id=192964
2920
2921         Reviewed by Alexey Proskuryakov.
2922
2923         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
2924         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
2925         useful if they were not so secret, so add them.
2926
2927         There appear to be no build-only bots, so the first column is blank. And of course there are
2928         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
2929         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
2930         and there's plenty of room in the final column for all the bots.
2931
2932         I had a hard time picking a logo to use, because the JavaScript language does not have an
2933         official logo. But I believe I've found one that will be satisfactory.
2934
2935         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
2936
2937         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
2938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
2939         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2940         (BubbleQueueServer):
2941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2942         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2943         (WebKitBuildbot):
2944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2945         (table.queue-grid tr.platform.linux-jsconly img.logo):
2946
2947 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
2948
2949         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
2950         https://bugs.webkit.org/show_bug.cgi?id=192821
2951
2952         Reviewed by Chris Dumez.
2953
2954         * DumpRenderTree/mac/DumpRenderTree.mm:
2955         (createWebViewAndOffscreenWindow):
2956         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2957
2958 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2959
2960         [Win][Clang] Fix compilation warnings of DumpRenderTree
2961         https://bugs.webkit.org/show_bug.cgi?id=192924
2962
2963         Reviewed by Alex Christensen.
2964
2965         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
2966         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2967         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
2968         * DumpRenderTree/win/DumpRenderTree.cpp:
2969         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
2970         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
2971         object to the argument of setDefaultTextEncodingName instead of a
2972         const string literal.
2973         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
2974         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
2975         (setCacheFolder): Deleted.
2976         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
2977         * DumpRenderTree/win/EditingDelegate.cpp:
2978         (dump): Use %d for int.
2979         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
2980         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2981         (BSTRFromString): Deleted unused function.
2982         * DumpRenderTree/win/TestRunnerWin.cpp:
2983         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
2984         the arguemnt of setQuota instead of const string literal.
2985         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2986         (jsStringRefToWString): Deleted unused function.
2987
2988 2018-12-20  Chris Dumez  <cdumez@apple.com>
2989
2990         Add API test coverage for customUserAgent client setting and service workers
2991         https://bugs.webkit.org/show_bug.cgi?id=192952
2992
2993         Reviewed by Alex Christensen.
2994
2995         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2996         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
2997         (-[SWSchemes webView:startURLSchemeTask:]):
2998         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2999         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3000
3001 2018-12-20  Chris Dumez  <cdumez@apple.com>
3002
3003         Use Optional::hasValue() instead of Optional::has_value()
3004         https://bugs.webkit.org/show_bug.cgi?id=192948
3005
3006         Reviewed by Tim Horton.
3007
3008         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
3009         (TestWebKitAPI::TEST):
3010         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
3011         (TestWebKitAPI::TEST):
3012         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
3013         (TestWebKitAPI::TEST_F):
3014
3015 2018-12-20  Chris Dumez  <cdumez@apple.com>
3016
3017         Add style script rule to check for uses of std::optional<>
3018         https://bugs.webkit.org/show_bug.cgi?id=192931
3019
3020         Reviewed by Tim Horton.
3021
3022         * Scripts/webkitpy/style/checkers/cpp.py:
3023         (check_wtf_optional):
3024         (check_style):
3025
3026 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
3027
3028         [WebAuthN] Add a runtime flag for local authenticator
3029         https://bugs.webkit.org/show_bug.cgi?id=192792
3030         <rdar://problem/46798738>
3031
3032         Reviewed by Brent Fulgham.
3033
3034         * DumpRenderTree/TestOptions.cpp:
3035         (TestOptions::TestOptions):
3036         * DumpRenderTree/TestOptions.h:
3037         * DumpRenderTree/mac/DumpRenderTree.mm:
3038         (enableExperimentalFeatures):
3039         (setWebPreferencesForTestOptions):
3040         * WebKitTestRunner/TestController.cpp:
3041         (WTR::TestController::resetPreferencesToConsistentValues):
3042         (WTR::updateTestOptionsFromTestHeader):
3043         * WebKitTestRunner/TestOptions.h:
3044         (WTR::TestOptions::hasSameInitializationOptions const):
3045
3046 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
3047
3048         webkitpy: Autoinstall package URLs have changed
3049         https://bugs.webkit.org/show_bug.cgi?id=192909
3050         <rdar://problem/46860359>
3051
3052         Rubber-stamped by Alexey Proskuryakov.
3053
3054         PyPi urls have been moved around, we need to update our auto-installed packages.
3055
3056         We should check for Selenium before asking PyPi for the latest version.
3057
3058         * Scripts/webkitpy/thirdparty/__init__.py:
3059         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
3060         (AutoinstallImportHook._install_keyring): Ditto.
3061         (AutoinstallImportHook._install_pep8): Ditto.
3062         (AutoinstallImportHook._install_mozlog): Ditto.
3063         (AutoinstallImportHook._install_mozprocess): Ditto.
3064         (AutoinstallImportHook._install_pytest_timeout): Ditto.
3065         (AutoinstallImportHook._install_pytest): Ditto.
3066         (AutoinstallImportHook._install_pylint): Ditto.
3067         (AutoinstallImportHook._install_buildbot): Ditto.
3068         (AutoinstallImportHook._install_coverage): Ditto.
3069         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
3070         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
3071         for new Selenium if the installed version isn't sufficient.
3072         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
3073
3074 2018-12-20  Chris Dumez  <cdumez@apple.com>
3075
3076         Use Optional::valueOr() instead of Optional::value_or()
3077         https://bugs.webkit.org/show_bug.cgi?id=192933
3078
3079         Reviewed by Geoffrey Garen.
3080
3081         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
3082         (TestWebKitAPI::checkURL):
3083         (TestWebKitAPI::checkRelativeURL):
3084         (TestWebKitAPI::checkURLDifferences):
3085         (TestWebKitAPI::checkRelativeURLDifferences):
3086         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3087         (TestWebKitAPI::checkURL):
3088
3089 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
3090
3091         Unreviewed, rolling out r239417.
3092
3093         Introduced two API test failures on macOS.
3094
3095         Reverted changeset:
3096
3097         "<rdar://problem/46194315> macOS: WebKit1 does not handle
3098         occlusion changes"
3099         https://bugs.webkit.org/show_bug.cgi?id=192821
3100         https://trac.webkit.org/changeset/239417
3101
3102 2018-12-20  Devin Rousso  <drousso@apple.com>
3103
3104         Web Inspector: UIString should take an optional key and description to aid localization
3105         https://bugs.webkit.org/show_bug.cgi?id=153962
3106         <rdar://problem/24542505>
3107
3108         Reviewed by Brian Burg.
3109
3110         * Scripts/extract-localizable-js-strings:
3111
3112 2018-12-20  Tim Horton  <timothy_horton@apple.com>
3113
3114         Unparented WKWebView can't retrieve main resource data for a main frame plugin
3115         https://bugs.webkit.org/show_bug.cgi?id=192923
3116         <rdar://problem/46859068>
3117
3118         Reviewed by Wenson Hsieh.
3119
3120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3121         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
3122         Add a test ensuring that both parented and unparented WKWebViews can
3123         retrieve main resource data when loading a PDF.
3124
3125 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3126
3127         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
3128         https://bugs.webkit.org/show_bug.cgi?id=192852
3129
3130         Reviewed by Michael Catanzaro.
3131
3132         EmojiOne font was replaced by Noto Color Emoji.
3133
3134         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
3135         * gtk/jhbuild.modules:
3136         * wpe/jhbuild.modules:
3137
3138 2018-12-19  Chris Dumez  <cdumez@apple.com>
3139
3140         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
3141         https://bugs.webkit.org/show_bug.cgi?id=192728
3142         <rdar://problem/46746779>
3143
3144         Reviewed by Geoff Garen.
3145
3146         * DumpRenderTree/*:
3147         * MiniBrowser/*:
3148         * TestRunnerShared/*:
3149         * TestWebKitAPI/*:
3150         * WebGPUAPIStructure/*:
3151         * WebKitTestRunner/*:
3152
3153 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
3154
3155         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3156         https://bugs.webkit.org/show_bug.cgi?id=192821
3157
3158         Reviewed by Chris Dumez.
3159
3160         * DumpRenderTree/mac/DumpRenderTree.mm:
3161         (createWebViewAndOffscreenWindow):
3162
3163 2018-12-19  Alex Christensen  <achristensen@webkit.org>
3164
3165         Navigations away from the SafeBrowsing interstitial show a flash of old content
3166         https://bugs.webkit.org/show_bug.cgi?id=192676
3167
3168         Reviewed by Chris Dumez.
3169
3170         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3171         (safeBrowsingView):
3172         (TEST):
3173         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
3174
3175 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
3176
3177         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
3178         https://bugs.webkit.org/show_bug.cgi?id=192855
3179
3180         Reviewed by Michael Catanzaro.
3181
3182         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3183         (WTR::TestController::notifyDone): Use the WPE implementation.
3184         (WTR::TestController::platformRunUntil): Use the WPE implementation.
3185         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
3186         (WTR::TestController::platformRunUntil): Honor the condition flag.
3187
3188 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
3189
3190         Allow clients to set the navigator platform
3191         https://bugs.webkit.org/show_bug.cgi?id=192735
3192
3193         Reviewed by Tim Horton.
3194
3195         Add a test for setting a custom navigator platform.
3196
3197         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3198         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3199         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
3200
3201 2018-12-19  Truitt Savell  <tsavell@apple.com>
3202
3203         Unreviewed, rolling out r239358.
3204
3205         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
3206         crash on Debug bots
3207
3208         Reverted changeset:
3209
3210         "Clean up IndexedDB files between tests"
3211         https://bugs.webkit.org/show_bug.cgi?id=192796
3212         https://trac.webkit.org/changeset/239358
3213
3214 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3215
3216         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
3217         https://bugs.webkit.org/show_bug.cgi?id=192842
3218         <rdar://problem/46823586>
3219
3220         Reviewed by Tim Horton.
3221
3222         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
3223         item provider when dragging a rich text selection.
3224
3225         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3226
3227 2018-12-18  David Quesada  <david_quesada@apple.com>
3228
3229         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
3230         https://bugs.webkit.org/show_bug.cgi?id=192810
3231         <rdar://problem/46812536>
3232
3233         Reviewed by Alex Christensen.
3234
3235         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3236         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
3237             After releasing our reference to the web view, wait until the next turn of the runloop
3238             before checking that the originatingWebView has been zeroed, since the web view might
3239             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
3240             testing general memory management of WKWebViews, only that _WKDownload does not retain
3241             its web view via the 'originatingWebView' property.
3242
3243 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
3244
3245         Clean up IndexedDB files between tests
3246         https://bugs.webkit.org/show_bug.cgi?id=192796
3247
3248         Reviewed by Geoffrey Garen.
3249
3250         * DumpRenderTree/mac/DumpRenderTree.mm:
3251         (runTest):
3252         * WebKitTestRunner/TestController.cpp:
3253         (WTR::TestController::resetStateToConsistentValues):
3254         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3255         (WTR::RemoveAllIndexedDatabasesCallback):
3256         (WTR::TestController::ClearIndexedDatabases):
3257         * WebKitTestRunner/TestController.h:
3258
3259 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3260
3261         Fix API test introduced in r239339 on iOS.
3262         https://bugs.webkit.org/show_bug.cgi?id=192675
3263
3264         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3265         (TEST):
3266         The iOS implementation of the safe browsing warning is a little different.
3267         It does some element creation when it is added to the window so it knows how big it is.
3268         To test these elements, we need to simulate adding it to the window.
3269         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
3270
3271 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
3272
3273         webkitpy: Ignore device type for test when using --force
3274         https://bugs.webkit.org/show_bug.cgi?id=192786
3275         <rdar://problem/46794894>
3276
3277         Reviewed by Daniel Bates.
3278
3279         It is sometimes the case that a contributor will wish to run a test on a specific device,
3280         despite expectations which indicate a test should not be run on that device.
3281
3282         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3283         (parse_args):
3284         * Scripts/webkitpy/port/device_port.py:
3285         (DevicePort.default_child_processes): Strip device type information when using --force.
3286         (DevicePort.setup_test_run): Only allow incomplete match when using --force.
3287
3288 2018-12-18  Alex Christensen  <achristensen@webkit.org>
3289
3290         WKWebView has old URL while displaying SafeBrowsing interstitial, for link-click navigations
3291         https://bugs.webkit.org/show_bug.cgi?id=192675
3292
3293         Reviewed by Geoffrey Garen.
3294
3295         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3296         (goBack):
3297         (TEST):
3298         (visitUnsafeSite):
3299         (-[SafeBrowsingHelper observeValueForKeyPath:ofObject:change:context:]):
3300         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3301
3302 2018-12-18  Chris Dumez  <cdumez@apple.com>
3303
3304         Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken
3305         https://bugs.webkit.org/show_bug.cgi?id=192772
3306
3307         Reviewed by Antti Koivisto.
3308
3309         Add API test coverage.
3310
3311         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3312
3313 2018-12-18  Philippe Normand  <pnormand@igalia.com>
3314
3315         Unreviewed, JHBuild GTK build fix attempt
3316
3317         * gtk/jhbuild.modules: There's no libffi in this moduleset anymore.
3318         There's no ninja module either, it should be provided by the
3319         host system.
3320
3321 2018-12-17  Chris Dumez  <cdumez@apple.com>
3322
3323         Allow passing nil as session state to [WKWebView _restoreSessionState:]
3324         https://bugs.webkit.org/show_bug.cgi?id=192789
3325         <rdar://problem/46755277>
3326
3327         Reviewed by Alex Christensen.
3328
3329         Add API test coverage.
3330
3331         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
3332         (TEST):
3333
3334 2018-12-17  Simon Fraser  <simon.fraser@apple.com>
3335
3336         Don't use more expensive layer backing store formats when subpixel text antialiasing is not enabled
3337         https://bugs.webkit.org/show_bug.cgi?id=192780
3338         rdar://problem/43394387
3339
3340         Reviewed by Tim Horton.
3341
3342         No need to set "AppleFontSmoothing" defaults for WK2.
3343
3344         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3345         (WTR::InjectedBundle::platformInitialize):
3346
3347 2018-12-17  Jonathan Bedard  <jbedard@apple.com>
3348
3349         webkitpy: Handle case where stdout and stderr don't accept unicode
3350         https://bugs.webkit.org/show_bug.cgi?id=192775
3351         <rdar://problem/46497303>
3352
3353         Reviewed by Stephanie Lewis.
3354
3355         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3356         (MeteredStream.write): If unicode cannot be written to the stream, replace unicode
3357         characters with '?'.
3358         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3359         (RegularTest.test_stream_with_encoding):
3360
3361 2018-12-17  Daniel Bates  <dabates@apple.com>
3362
3363         Support concatenating StringView with other string types
3364         https://bugs.webkit.org/show_bug.cgi?id=177566
3365
3366         Reviewed by Darin Adler.
3367
3368         Add some tests to ensure we do not regress the number of allocations needed when performing
3369         string concatenation with string views.
3370
3371         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3372         (TestWebKitAPI::TEST):
3373
3374 2018-12-17  Commit Queue  <commit-queue@webkit.org>
3375
3376         Unreviewed, rolling out r239265 and r239274.
3377         https://bugs.webkit.org/show_bug.cgi?id=192765
3378
3379         unorm_normalize is deprecated, and broke an internal build
3380         (Requested by Truitt on #webkit).
3381
3382         Reverted changesets:
3383
3384         "[GTK][WPE] Need a function to convert internal URI to display
3385         ("pretty") URI"
3386         https://bugs.webkit.org/show_bug.cgi?id=174816
3387         https://trac.webkit.org/changeset/239265
3388
3389         "Fix the Apple Internal Mac build with a newer SDK"
3390         https://trac.webkit.org/changeset/239274
3391
3392 2018-12-17  Daniel Bates  <dabates@apple.com>
3393
3394         Implement UIScriptController::toggleCapsLock() for iOS
3395         https://bugs.webkit.org/show_bug.cgi?id=191815
3396
3397         Reviewed by Andy Estes.
3398
3399         Add support for toggling the caps lock state in WebKitTestRunner on iOS.
3400
3401         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3402         * WebKitTestRunner/TestController.cpp:
3403         (WTR::TestController::resetStateToConsistentValues): Clear the current modifier state
3404         before running a test. This ensures that the caps lock state does not persist between
3405         tests should a test enable caps lock and not disable it.
3406         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3407         (hidUsageCodeForCharacter): Map "capsLock" to the Caps Lock key usage code.
3408         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3409         (WTR::createUIPhysicalKeyboardEvent): Modified to take the keyboard input flags to use to
3410         create the event. Also substituted NSString* for const String& as the data type for the first
3411         two parameters to avoid conversions in the implementation of UIScriptController::toggleCapsLock()
3412         below.
3413         (WTR::UIScriptController::keyDown): Update as needed due to changes to prototype of createUIPhysicalKeyboardEvent().
3414         (WTR::UIScriptController::toggleCapsLock): Dispatch a UIEvent to toggle caps lock.
3415
3416 2018-12-17  Daniel Bates  <dabates@apple.com>
3417
3418         [iOS] Remove -[WebEvent initWithKeyEventType:...:characterSet:]
3419         https://bugs.webkit.org/show_bug.cgi?id=192633
3420
3421         Reviewed by Wenson Hsieh.
3422
3423         Update code to use the modern initializer.
3424
3425         * DumpRenderTree/mac/EventSendingController.mm:
3426         (-[EventSendingController keyDown:withModifiers:withLocation:]):
3427
3428 2018-12-17  Matt Lewis  <jlewis3@apple.com>
3429
3430         Unreviewed, rolling out r239254.
3431
3432         This broke the Windows 10 Debug build
3433
3434         Reverted changeset:
3435
3436         "Replace many uses of String::format with more type-safe
3437         alternatives"
3438         https://bugs.webkit.org/show_bug.cgi?id=192742
3439         https://trac.webkit.org/changeset/239254
3440
3441 2018-12-17  David Kilzer  <ddkilzer@apple.com>
3442
3443         clang-tidy: loop variable is copied but only used as const reference in WebCore, WebKit, Tools
3444         <https://webkit.org/b/192751>
3445         <rdar://problem/46771623>
3446
3447         Reviewed by Daniel Bates.
3448
3449         Change loop variables to const references to avoid unnecessary
3450         copies.
3451
3452         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
3453         (-[LocalPasteboard pasteboardItems]):
3454
3455 2018-12-17  Ms2ger  <Ms2ger@igalia.com>
3456
3457         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3458         https://bugs.webkit.org/show_bug.cgi?id=174816
3459
3460         Reviewed by Michael Catanzaro.
3461
3462         Add tests for userVisibleString() and (for GTK and WPE) webkit_uri_for_display().
3463
3464         * TestWebKitAPI/CMakeLists.txt:
3465         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3466         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Added.
3467         (TestWebKitAPI::TEST):
3468         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3469         (testURIForDisplayUnaffected):
3470         (testURIForDisplayAffected):
3471         (beforeAll):
3472         (afterAll):
3473         * TestWebKitAPI/glib/CMakeLists.txt:
3474
3475 2018-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3476
3477         [WPE] Add API to notify about frame displayed view backend callback
3478         https://bugs.webkit.org/show_bug.cgi?id=192224
3479
3480         Reviewed by Michael Catanzaro.
3481
3482         Add a test case to check the new API.
3483
3484         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3485         (testWebViewFrameDisplayed):
3486         (beforeAll):
3487         * wpe/jhbuild.modules: Bump WPEBackend-fdo to 1.1.0.
3488
3489 2018-12-16  Adrian Perez de Castro  <aperez@igalia.com>
3490
3491         Unreviewed build fix after r239253
3492
3493         * gtk/jhbuild.modules: Fix typo in libpsl dependency name.
3494
3495 2018-12-15  Darin Adler  <darin@apple.com>
3496
3497         Use warning-ignoring macros more consistently and simply
3498         https://bugs.webkit.org/show_bug.cgi?id=192743
3499
3500         Reviewed by Mark Lam.
3501
3502         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3503         (handleEventCarbon): Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
3504         * DumpRenderTree/mac/TextInputControllerMac.m:
3505         (-[TextInputController interpretKeyEvents:withSender:]): Use
3506         IGNORE_WARNINGS_BEGIN/END.
3507         * WebKitTestRunner/mac/EventSenderProxy.mm:
3508         (WTR::EventSenderProxy::mouseForceClick): Use
3509         IGNORE_NULL_CHECK_WARNINGS_BEGIN/END.
3510         (WTR::EventSenderProxy::startAndCancelMouseForceClick): Ditto.
3511         (WTR::EventSenderProxy::mouseForceDown): Ditto.
3512         (WTR::EventSenderProxy::mouseForceUp): Ditto.
3513         (WTR::EventSenderProxy::mouseForceChanged): Ditto.
3514
3515 2018-12-15  Darin Adler  <darin@apple.com>
3516
3517         Replace many uses of String::format with more type-safe alternatives
3518         https://bugs.webkit.org/show_bug.cgi?id=192742
3519
3520         Reviewed by Mark Lam.
3521
3522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3523         (WTR::cacheTestRunnerCallback): Use makeString.
3524         * WebKitTestRunner/TestController.cpp:
3525         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3526         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3527
3528 2018-12-15  Adrian Perez de Castro  <aperez@igalia.com>
3529
3530         [WPE][GTK] Add libpsl to JHBuild module sets
3531         https://bugs.webkit.org/show_bug.cgi?id=192740
3532
3533         Reviewed by Michael Catanzaro.
3534
3535         * gtk/jhbuild.modules: Add libpsl module.
3536         * wpe/jhbuild.modules: Ditto.
3537
3538 2018-12-14  Alexey Proskuryakov  <ap@apple.com>
3539
3540         Add a style checker rule for Xcode version macros use
3541         https://bugs.webkit.org/show_bug.cgi?id=192703
3542
3543         Reviewed by Alex Christensen.
3544
3545         * Scripts/webkitpy/style/checkers/cpp.py:
3546         (check_os_version_checks):
3547         (process_line):
3548         (CppChecker):
3549         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3550         (WebKitStyleTest.test_os_version_checks):
3551
3552 2018-12-14  Chris Dumez  <cdumez@apple.com>
3553
3554         [PSON] Process-swapping on a loadHTMLString causes duplicate decidePolicyForNavigationAction delegate calls
3555         https://bugs.webkit.org/show_bug.cgi?id=192704
3556
3557         Reviewed by Geoffrey Garen.
3558
3559         Extend existing API test to reproduce the problem.
3560
3561         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3562
3563 2018-12-14  Chris Dumez  <cdumez@apple.com>
3564
3565         [PSON] WebsitePolicies are lost on process-swap
3566         https://bugs.webkit.org/show_bug.cgi?id=192694
3567         <rdar://problem/46715748>
3568
3569         Reviewed by Brady Eidson.
3570
3571         Extend existing API test to reproduce the issue.
3572
3573         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3574
3575 2018-12-14  Michael Catanzaro  <mcatanzaro@igalia.com>
3576
3577         [GTK] Error writing data to TLS socket in some sites when using the jhbuild
3578         https://bugs.webkit.org/show_bug.cgi?id=192678
3579
3580         Reviewed by Carlos Garcia Campos.
3581
3582         Update our ancient versions of libsoup and glib-networking.
3583
3584         * gtk/install-dependencies:
3585         * gtk/jhbuild.modules:
3586         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Removed.
3587         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Removed.
3588         * gtk/patches/libsoup-soup-message-io-Do-not-fail-when-there-s-no-empty-li.patch: Removed.
3589         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3590         * wpe/install-dependencies:
3591         * wpe/jhbuild.modules:
3592         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Removed.
3593
3594 2018-12-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3595
3596         [WPE] Use new view state API from libwpe
3597         https://bugs.webkit.org/show_bug.cgi?id=191906
3598
3599         Reviewed by Žan Doberšek.
3600
3601         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3602         (beforeAll): Enable /webkit/WebKitWebView/page-visibility in WPE.
3603         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3604         (Test::createWebViewBackend): Make the view initially hidden for consistency with GTK+ tests.
3605         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3606         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3607         (WebViewTest::showInWindow): Add wpe_view_activity_state_visible, wpe_view_activity_state_in_window and
3608         wpe_view_activity_state_focused state flags.
3609         (WebViewTest::hideView): Remove wpe_view_activity_state_visible and wpe_view_activity_state_focused state flags.
3610         * wpe/backends/HeadlessViewBackend.cpp:
3611         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Assume view is always visible, focused and in window.
3612         * wpe/backends/WindowViewBackend.cpp:
3613         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Update the view state flags depending on state
3614         received in configure callback.
3615         * wpe/jhbuild.modules: Bump libwpe to 1.1.0
3616
3617 2018-12-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3618
3619         [WinCairo][Clang] DLLLauncherMain.cpp: warning: unused function 'prependPath' and 'appleApplicationSupportDirectory'
3620         https://bugs.webkit.org/show_bug.cgi?id=192688
3621
3622         Reviewed by Ross Kirsling.
3623
3624         * win/DLLLauncher/DLLLauncherMain.cpp:
3625         (copyEnvironmentVariable): Moved.
3626         (getStringValue): Enclosed with #if !defined(WIN_CAIRO).
3627         (applePathFromRegistry): Ditto.
3628         (appleApplicationSupportDirectory): Ditto.
3629         (prependPath): Ditto.
3630
3631 2018-12-13  Don Olmstead  <don.olmstead@sony.com>
3632
3633         Unreviewed. Changed my status to a reviewer.
3634
3635         * Scripts/webkitpy/common/config/contributors.json:
3636
3637 2018-12-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3638
3639         [iOS] Support dropping contact card data (public.vcard) in editable content
3640         https://bugs.webkit.org/show_bug.cgi?id=192570
3641         <rdar://problem/35626913>
3642
3643         Reviewed by Tim Horton.
3644
3645         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3646
3647         Add API tests to verify that registering `MKMapItem`s and `CNContact`s to item providers and dropping them in
3648         attachment-enabled rich text editable areas inserts attachment elements (and in the case of `MKMapItem`,
3649         additionally inserts a link).
3650
3651         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3652         (TestWebKitAPI::createMapItemForTesting):
3653         (TestWebKitAPI::createContactItemForTesting):
3654
3655         Add API tests to verify that dropping map items and contact items into rich and plain editable areas behaves as
3656         expected (in the case where a URL is present, e.g. dropping a map item, we insert the URL as an anchor, and when
3657         there is no other suitable representation in the item provider, we do nothing at all, which is the case for the
3658         dropped `CNContact`). Also, add a test to verify that drag and drop can be used to upload these items as .vcf
3659         files.
3660
3661 2018-12-13  Ross Kirsling  <ross.kirsling@sony.com>
3662
3663         Unreviewed -- update my status to "reviewer".
3664
3665         * Scripts/webkitpy/common/config/contributors.json:
3666
3667 2018-12-13  Youenn Fablet  <youenn@apple.com>
3668
3669         On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early
3670         https://bugs.webkit.org/show_bug.cgi?id=192657
3671
3672         Reviewed by Eric Carlson.
3673
3674         Add a test that loads a page registering ondevicechange,
3675         load another page in the same process, closes the first page.
3676         Ensure that the process does not crash in that case.
3677
3678         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3679         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3680         (TestWebKitAPI::TEST):
3681         (TestWebKitAPI::didCrashCallback):
3682         * TestWebKitAPI/Tests/WebKit/ondevicechange.html: Added.
3683
3684 2018-12-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3685
3686         [GStreamer][JHBuild] update-webkit{gtk,wpe}-libs fails with libfdk-2.0.0
3687         https://bugs.webkit.org/show_bug.cgi?id=192643
3688
3689         Reviewed by Philippe Normand.
3690
3691         This problem happens with Arch Linux users which have libfdk-2.0.0
3692         installed (which is anybody with gst-plugins-bad 1.14.4 installed).
3693
3694         The problem has already been solved upstream at
3695         https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/77.
3696
3697         Adding patches while this problem is not in a release yet.
3698
3699         * gstreamer/jhbuild.modules: Add patches to fix build of gst-plugins-bad with libfdk-2.0.0.
3700         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Added.
3701         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Added.
3702
3703 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3704
3705         [FreeType] Add initial implementation of variation fonts
3706         https://bugs.webkit.org/show_bug.cgi?id=192151
3707
3708         Reviewed by Michael Catanzaro.
3709
3710         Add cairo patch to avoid crashes.
3711
3712         * gtk/jhbuild.modules:
3713         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3714
3715 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
3716
3717         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
3718         https://bugs.webkit.org/show_bug.cgi?id=192618
3719
3720         Reviewed by Alex Christensen.
3721
3722         * DumpRenderTree/win/DRTDataObject.cpp:
3723         * DumpRenderTree/win/DRTDataObject.h:
3724         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3725         * DumpRenderTree/win/DRTDropSource.h:
3726         * DumpRenderTree/win/EditingDelegate.h:
3727         * DumpRenderTree/win/PolicyDelegate.h:
3728         * DumpRenderTree/win/UIDelegate.h:
3729
3730 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
3731
3732         Make TextInputController.legacyAttributedString take DOM nodes and offsets
3733         https://bugs.webkit.org/show_bug.cgi?id=192653
3734
3735         Reviewed by Wenson Hsieh.
3736
3737         Updated TextInputController.legacyAttributedString to take DOM nodes and offsets instead of
3738         a DOM Range object in preparation to add layout tests for HTMLConverter which crosses
3739         shadow boundaries.
3740
3741         * DumpRenderTree/mac/TextInputControllerMac.m:
3742         (+[TextInputController isSelectorExcludedFromWebScript:]): Updated the selector signature.
3743         (+[TextInputController webScriptNameForSelector:]): Ditto.
3744         (-[TextInputController legacyAttributedString:offset:to:offset:]): Made this function take
3745         start node and offset then end node and offset pairs.
3746
3747 2018-12-12  Alex Christensen  <achristensen@webkit.org>
3748
3749         Implement safe browsing in WebKit on WatchOS
3750         https://bugs.webkit.org/show_bug.cgi?id=192641
3751         <rdar://problem/46376188>
3752
3753         Reviewed by Geoff Garen.
3754
3755         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3756         (-[SafeBrowsingNavigationDelegate _webViewDidShowSafeBrowsingWarning:]):
3757         (safeBrowsingView):
3758         Add a test that the new delegate callback is called.
3759
3760 2018-12-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3761
3762         Unreviewed manual rollout of r239100-r239102 and r239116
3763         https://bugs.webkit.org/show_bug.cgi?id=192151
3764         <rdar://problem/46655586>
3765
3766         * gtk/jhbuild.modules:
3767         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Removed.
3768
3769 2018-12-12  Commit Queue  <commit-queue@webkit.org>
3770
3771         Unreviewed, rolling out r239103.
3772         https://bugs.webkit.org/show_bug.cgi?id=192627
3773
3774         It broke the built because it depends on another patch that
3775         didn't land yet (Requested by KaL on #webkit).
3776
3777         Reverted changeset:
3778
3779         "[WPE] Add API to notify about frame displayed view backend
3780         callback"
3781         https://bugs.webkit.org/show_bug.cgi?id=192224
3782         https://trac.webkit.org/changeset/239103
3783
3784 2018-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3785
3786         [WPE] Add API to notify about frame displayed view backend callback
3787         https://bugs.webkit.org/show_bug.cgi?id=192224
3788
3789         Reviewed by Michael Catanzaro.
3790
3791         Add a test case to check the new API.
3792
3793         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3794         (testWebViewFrameDisplayed):
3795         (beforeAll):
3796
3797 2018-12-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3798
3799         [FreeType] Add initial implementation of variation fonts
3800         https://bugs.webkit.org/show_bug.cgi?id=192151
3801
3802         Reviewed by Michael Catanzaro.
3803
3804         Add cairo patch to avoid crashes.
3805
3806         * gtk/jhbuild.modules:
3807         * gtk/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3808
3809 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
3810
3811         Implement feature flag for CSS Typed OM
3812         https://bugs.webkit.org/show_bug.cgi?id=192610
3813
3814         Reviewed by Ryosuke Niwa.
3815
3816         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3817
3818 2018-12-11  Chris Dumez  <cdumez@apple.com>
3819
3820         Unreviewed, fix bad check in API test added in r239080.
3821
3822         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3823
3824 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
3825
3826         [Win][Clang] Fix warning -Wmissing-field-initializers
3827         https://bugs.webkit.org/show_bug.cgi?id=192584
3828
3829         Reviewed by Yusuke Suzuki.
3830
3831         Initialize a struct with '{ }' instead of '= {0}'.
3832
3833         * DumpRenderTree/win/DumpRenderTree.cpp:
3834         (runTest):
3835         * DumpRenderTree/win/EventSender.cpp:
3836         (makeMsg):
3837         (replaySavedEvents):
3838         (beginDragWithFilesCallback):
3839         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3840         (createBitmapContextFromWebView):
3841         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3842         (updateMenuItemForHistoryItem):
3843         * MiniBrowser/win/WinMain.cpp:
3844         (wWinMain):
3845         * TestWebKitAPI/win/HostWindow.cpp:
3846         (TestWebKitAPI::HostWindow::clientRect const):
3847         (TestWebKitAPI::HostWindow::registerWindowClass):
3848         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3849         (TestWebKitAPI::PlatformWebView::registerWindowClass):
3850         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3851         (WTR::registerWindowClass):
3852         (WTR::PlatformWebView::windowFrame):
3853         (WTR::PlatformWebView::windowSnapshotImage):
3854
3855 2018-12-11  Chris Dumez  <cdumez@apple.com>
3856
3857         PSON logic gets confused by concurrent decidePolicyForNavigationAction requests
3858         https://bugs.webkit.org/show_bug.cgi?id=192482
3859         <rdar://problem/46470145>
3860
3861         Reviewed by Antti Koivisto.
3862
3863         Add API test coverage.
3864
3865         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3866
3867 2018-12-11  Andy Estes  <aestes@apple.com>
3868
3869         Introduce makeBlockPtr for lambdas
3870         https://bugs.webkit.org/show_bug.cgi?id=192594
3871
3872         Reviewed by Alex Christensen.
3873
3874         Adopted makeBlockPtr and added API tests.
3875
3876         * DumpRenderTree/TestRunner.cpp:
3877         (TestRunner::callUIScriptCallback):
3878         * TestWebKitAPI/Tests/WTF/BlockPtr.mm:
3879         (TestWebKitAPI::TEST):
3880         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3881         (-[DownloadProgressTestRunner init]):
3882         (-[DownloadProgressTestRunner subscribeAndWaitForProgress]):
3883
3884 2018-12-11  Chris Dumez  <cdumez@apple.com>
3885
3886         REGRESSION (r238764-238783): TestWTF.WTF.StringOperators is failing
3887         https://bugs.webkit.org/show_bug.cgi?id=192361
3888         <rdar://problem/46524903>
3889
3890         Reviewed by Alex Christensen.
3891
3892         Compile StringOperators.cpp with -O1 optimization level instead of -Os. This
3893         fixes the failures for me locally.
3894
3895         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3896
3897 2018-12-11  Philippe Normand  <pnormand@igalia.com>
3898
3899         Unreviewed, WPE build fix after r239028
3900
3901         The FLATPAK_USER_DIR env var is not set early enough, leading to:
3902
3903         Traceback (most recent call last):
3904         File "/home/phil/WebKit/Tools/Scripts/webkit-flatpak", line 28, in <module>
3905           sys.exit(WebkitFlatpak.load_from_args().run())
3906         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 761, in run
3907           if not self.clean_args():
3908         File "/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 574, in clean_args
3909           _log.debug("Using flatpak user dir: %s" % os.environ["FLATPAK_USER_DIR"])
3910         File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
3911           raise KeyError(key)
3912         KeyError: 'FLATPAK_USER_DIR'
3913
3914         * flatpak/flatpakutils.py:
3915         (WebkitFlatpak.clean_args):
3916
3917 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3918
3919         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
3920         https://bugs.webkit.org/show_bug.cgi?id=192573
3921
3922         Reviewed by Simon Fraser.
3923
3924         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3925
3926 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3927
3928         [CMake] Add ENABLE_RESOURCE_LOAD_STATISTICS to WebKitFeatures.cmake
3929         https://bugs.webkit.org/show_bug.cgi?id=192574
3930
3931         Reviewed by Michael Catanzaro.
3932
3933         * Scripts/webkitperl/FeatureList.pm:
3934
3935 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
3936
3937         Sync FeatureList.pm
3938         https://bugs.webkit.org/show_bug.cgi?id=192565
3939
3940         Reviewed by Michael Catanzaro.
3941
3942         * Scripts/webkitperl/FeatureList.pm:
3943
3944 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
3945
3946         [iOS] Unable to upload data that conforms to "public.item" but not "public.content"
3947         https://bugs.webkit.org/show_bug.cgi?id=192555
3948         <rdar://problem/35204990>
3949
3950         Reviewed by Tim Horton.
3951
3952         Add a test to verify that `.p12` files may be uploaded as files via drag and drop. "com.rsa.pkcs-12" is an
3953         example of a data type that conforms to "public.item", but not "public.content"; before this patch, we would
3954         only support uploading "public.content", so files such as these would not be accepted when dropping into file
3955         inputs, or be exposed as files on DataTransfer.
3956
3957         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3958         (TestWebKitAPI::TEST):
3959
3960 2018-12-10  David Kilzer  <ddkilzer@apple.com>
3961
3962         Injected bundle for WebKitTestRunner leaks WKTypeRef objects
3963         <https://webkit.org/b/192481>
3964         <rdar://problem/46539059>
3965
3966         Follow-up to address Darin's feedback.
3967
3968         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3969         (WTR::TestRunner::shouldDumpPixels const):
3970         (WTR::TestRunner::whatToDump const):
3971         (WTR::TestRunner::shouldWaitUntilDone const):
3972         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
3973         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
3974         (WTR::TestRunner::secureEventInputIsEnabled const):
3975         (WTR::TestRunner::isStatisticsPrevalentResource):
3976         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
3977         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
3978         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
3979         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
3980         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
3981         (WTR::TestRunner::isStatisticsGrandfathered):
3982         (WTR::TestRunner::hasDOMCache):
3983         (WTR::TestRunner::keyExistsInKeychain):
3984
3985 2018-12-10  Jonathan Bedard  <jbedard@apple.com>
3986
3987         webkitpy: Ref tests don't respect platform specific expectations
3988         https://bugs.webkit.org/show_bug.cgi?id=192515
3989         <rdar://problem/46564839>
3990
3991         Reviewed by Lucas Forschler.
3992
3993         * Scripts/webkitpy/port/base.py:
3994         (Port._expected_baselines_for_suffixes): Accept multiple suffixes so ref tests can use this function.
3995         (Port.expected_baselines): Move implementation to _expected_baselines_for_suffixes.
3996         (Port.expected_filename): Remove irrelevant FIXME, code clean-up.
3997         (Port.reference_files): Instead of just searching a single directory, use _expected_baselines_for_suffixes to
3998         search all platform expectations as well.
3999         * Scripts/webkitpy/port/base_unittest.py:
4000         (test_ref_tests_platform_directory):
4001
4002 2018-12-10  Chris Dumez  <cdumez@apple.com>
4003
4004         Add SPI to allow the client to set the user-agent at main frame level, from the UIProcess
4005         https://bugs.webkit.org/show_bug.cgi?id=192509
4006         <rdar://problem/46500832>
4007
4008         Reviewed by Alex Christensen.
4009
4010         Add API test coverage.
4011
4012         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4013         (-[DataMappingSchemeHandler addMappingFromURLString:toData:]):
4014         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
4015         (-[DataMappingSchemeHandler webView:stopURLSchemeTask:]):
4016         (-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4017         (-[CustomUserAgentDelegate webView:didFinishNavigation:]):
4018
4019 2018-12-10  Wenson Hsieh  <wenson_hsieh@apple.com>
4020
4021         [iOS] Caret is obscured by finger when dragging over an editable element
4022         https://bugs.webkit.org/show_bug.cgi?id=192499
4023         <rdar://problem/46570101>
4024
4025         Reviewed by Tim Horton.
4026
4027         Augment some existing API tests to check that the `precise` flag is either on or off on `UIDropProposal`.
4028
4029         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4030         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
4031         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4032         (-[DragAndDropSimulator _resetSimulatedState]):
4033         (-[DragAndDropSimulator lastKnownDropProposal]):
4034
4035         Rename `currentDropProposal` to `lastKnownDropProposal`, and expose it as a readonly property.
4036
4037         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
4038         (-[DragAndDropSimulator _advanceProgress]):
4039         (-[DragAndDropSimulator setShowCustomActionSheetBlock:]):
4040         (-[DragAndDropSimulator showCustomActionSheetBlock]):
4041         (-[DragAndDropSimulator setConvertItemProvidersBlock:]):
4042         (-[DragAndDropSimulator convertItemProvidersBlock]):
4043         (-[DragAndDropSimulator setOverridePerformDropBlock:]):
4044         (-[DragAndDropSimulator overridePerformDropBlock]):
4045         (-[DragAndDropSimulator setOverrideDragUpdateBlock:]):
4046         (-[DragAndDropSimulator overrideDragUpdateBlock]):
4047         (-[DragAndDropSimulator setDropCompletionBlock:]):
4048         (-[DragAndDropSimulator dropCompletionBlock]):
4049
4050         Refactor these properties to return and take normal Objective-C blocks, rather than `BlockPtr`s. However, use
4051         `BlockPtr` instance variables to manage the lifetimes of these blocks.
4052
4053         (-[DragAndDropSimulator _webView:willUpdateDropProposalToProposal:forSession:]):
4054         (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]): Deleted.
4055
4056         Update this to use the new WebKit delegate hook for overriding the drop proposal.
4057
4058 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
4059
4060         [WPE][GTK] run-minibrowser improperly creates webkit-flatpak environment
4061         https://bugs.webkit.org/show_bug.cgi?id=190241
4062
4063         Reviewed by Carlos Garcia Campos.
4064
4065         run-minibrowser calls into webkit-flatpak to check if a flatpak environment is available.
4066         Currently this actually creates the directories needed for the flatpak environment. Fix it.
4067
4068         * flatpak/flatpakutils.py:
4069         (WebkitFlatpak.clean_args):
4070         (WebkitFlatpak.run):
4071
4072 2018-12-10  Michael Catanzaro  <mcatanzaro@igalia.com>
4073
4074         [GTK] Don't use the slice allocator
4075         https://bugs.webkit.org/show_bug.cgi?id=192360
4076
4077         Reviewed by Carlos Garcia Campos.
4078
4079         * MiniBrowser/gtk/main.c:
4080         (aboutDataRequestFree):
4081         (aboutDataRequestNew):
4082
4083 2018-12-10  Tim Horton  <timothy_horton@apple.com>
4084
4085         WKWebView should support custom tintColor
4086         https://bugs.webkit.org/show_bug.cgi?id=192518
4087         <rdar://problem/37243261>
4088
4089         Reviewed by Wenson Hsieh.
4090
4091         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
4092         (TestWebKitAPI::TEST):
4093         Add a test that tintColor affects UITextInputTraits' interaction colors.
4094
4095 2018-12-09  Wenson Hsieh  <wenson_hsieh@apple.com>
4096
4097         [iOS] DragAndDropTests.RespectsExternalSourceFidelityRankings is flaky
4098         https://bugs.webkit.org/show_bug.cgi?id=192524
4099
4100         Reviewed by Ryosuke Niwa.
4101
4102         This test started failing on certain builds of iOS where UIKit now attempts to reveal the selection by scrolling
4103         (see <rdar://problem/28300343>). This API test simulates two drops from external sources, both from the point
4104         (300, 400) to (100, 300) in window coordinates. On these aforementioned builds of iOS, what happens is that the
4105         first drop inserts text that overflows the editable region by an enormous amount, which creates an extremely
4106         wide selection rect and increases the width of the document; revealing this selection causes the web view to
4107         scroll horizontally, such that the second attempt to simulate a drag from (300, 400) to (100, 300) fails, since
4108         these window coordinates no longer correspond to the drop destination element in the document.
4109
4110         To fix this test, we simply mark the drop destination as `overflow: hidden` to ensure that we don't try and
4111         scroll horizontally after the first drop.
4112
4113         * TestWebKitAPI/Tests/WebKitCocoa/autofocus-contenteditable.html:
4114
4115 2018-12-08  Daniel Bates  <dabates@apple.com>
4116
4117         Fix lldb_webkit.py following r238771
4118         (https://bugs.webkit.org/show_bug.cgi?id=190234)
4119
4120         Substitute WTFURLProvider for WebCoreURLProvider in one call site that was inadvertently
4121         missed in r238771.
4122
4123         * lldb/lldb_webkit.py:
4124         (WebCoreDocumentProvider.url):
4125
4126 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4127
4128         [ews-build] check-patch-relevance failure should not mark the overall build as failure
4129         https://bugs.webkit.org/show_bug.cgi?id=192510
4130
4131         Reviewed by Lucas Forschler.
4132
4133         * BuildSlaveSupport/ews-build/steps.py:
4134         (CheckPatchRelevance.start):
4135
4136 2018-12-07  Chris Dumez  <cdumez@apple.com>
4137
4138         ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
4139         https://bugs.webkit.org/show_bug.cgi?id=192362
4140         <rdar://problem/46460360>
4141
4142         Reviewed by Ryosuke Niwa.
4143
4144         Move the call to _setCookieAcceptPolicy *after* we've constructed a WKWebView and thus
4145         *after* we know for sure we have a network process to communicate the policy to.
4146         This should address the failures on iOS.
4147
4148         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4149
4150 2018-12-07  Jiewen Tan  <jiewen_tan@apple.com>
4151
4152         Add keychain access entitlement to WebKitTestRunnerApp
4153         https://bugs.webkit.org/show_bug.cgi?id=192489
4154         <rdar://problem/45057952>
4155
4156         Reviewed by Alexey Proskuryakov.
4157
4158         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements:
4159
4160 2018-12-07  Saam Barati  <sbarati@apple.com>
4161
4162         WKWebProcessPlugInLoadDelegate should have API for saying which rendering events it wants to listen for
4163         https://bugs.webkit.org/show_bug.cgi?id=192473
4164
4165         Reviewed by Andy Estes.
4166
4167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4168         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgress.mm: Added.
4169         (-[DidFirstMeaningfulPaintRemoteObject didFirstMeaningfulPaint]):
4170         (TEST):
4171         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressPlugIn.mm: Added.
4172         (-[RenderingProgressPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4173         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextControllerRenderingProgressEvents:]):
4174         (-[RenderingProgressPlugIn webProcessPlugInBrowserContextController:renderingProgressDidChange:]):
4175         * TestWebKitAPI/Tests/WebKitCocoa/RenderingProgressProtocol.h: Added.
4176
4177 2018-12-07  Jonathan Bedard  <jbedard@apple.com>
4178
4179         REGRESSION: run-webkit-tests may fail when using booted simulators (Follow-up fix)
4180         https://bugs.webkit.org/show_bug.cgi?id=192470
4181         <rdar://problem/46532001>
4182
4183         Unreviewed infrastructure fix.
4184
4185         * Scripts/webkitpy/port/device_port.py:
4186         (DevicePort.setup_test_run): Check that the number of initialized devices matches the
4187         number of child processes.
4188
4189 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4190
4191         [ews-app] Send bug id as a build property
4192         https://bugs.webkit.org/show_bug.cgi?id=192494
4193
4194         Reviewed by Lucas Forschler.
4195
4196         * BuildSlaveSupport/ews-app/ews/fetcher.py:
4197         (BugzillaPatchFetcher.fetch):
4198
4199 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4200
4201         [ews-build] Builds should have a link to patch and bug
4202         https://bugs.webkit.org/show_bug.cgi?id=192492
4203
4204         Reviewed by Lucas Forschler.
4205
4206         * BuildSlaveSupport/ews-build/steps.py:
4207         (ConfigureBuild.add_patch_id_url): Method to add Patch URL.
4208         (ConfigureBuild.add_bug_id_url): Method to add Bug URL.
4209         (ConfigureBuild.getPatchURL): Method to get Patch URL.
4210         (ConfigureBuild.getBugURL): Method to get Bug URL.
4211
4212 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4213
4214         [ews-app] Configure logfile for ews-app logs
4215         https://bugs.webkit.org/show_bug.cgi?id=192493
4216
4217         Reviewed by Lucas Forschler.
4218
4219         * BuildSlaveSupport/ews-app/ews/__init__.py:
4220
4221 2018-12-07  Aakash Jain  <aakash_jain@apple.com>
4222
4223         Style queue exception on some security bugs
4224         https://bugs.webkit.org/show_bug.cgi?id=190793
4225
4226         Reviewed by Lucas Forschler.
4227
4228         * Scripts/webkitpy/tool/steps/applywatchlist.py:
4229         (ApplyWatchList.run):
4230
4231 2018-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
4232
4233         [Attachment Support] Cloned attachment elements lose their unique identifiers
4234         https://bugs.webkit.org/show_bug.cgi?id=192483
4235
4236         Reviewed by Tim Horton.
4237
4238         Introduce a new API test.
4239
4240         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4241         (TestWebKitAPI::TEST):
4242
4243 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
4244
4245         Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903
4246         https://bugs.webkit.org/show_bug.cgi?id=192486
4247
4248         Unreviewed infrastructure fix.
4249
4250         WinCairo bots define WEBKIT_TEST_CHILD_PROCESSES to run less processes due to RAM restrictions.
4251
4252         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4253         (_set_up_derived_options):
4254
4255 2018-12-06  David Kilzer  <ddkilzer@apple.com>
4256
4257         Injected bundle for WebKitTestRunner leaks WKTypeRef objects
4258         <https://webkit.org/b/192481>
4259         <rdar://problem/46539059>
4260
4261         Reviewed by Simon Fraser.
4262
4263         This patch:
4264         - Fixes leaks in various injected bundle methods that return +1
4265           retained WKTypeRef objects via pointer.
4266         - Asserts the returned object is the expected WKTypeRef.
4267         - Replaces 0 with nullptr in many places.
4268
4269         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4270         (WTR::InjectedBundle::didCreatePage):
4271         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4272         (WTR::TestRunner::shouldDumpPixels const):
4273         (WTR::TestRunner::whatToDump const):
4274         (WTR::TestRunner::shouldWaitUntilDone const):
4275         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
4276         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
4277         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
4278         (WTR::TestRunner::secureEventInputIsEnabled const):
4279         (WTR::TestRunner::isStatisticsPrevalentResource):
4280         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
4281         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
4282         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
4283         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
4284         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
4285         (WTR::TestRunner::isStatisticsGrandfathered):
4286         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
4287         (WTR::TestRunner::statisticsUpdateCookieBlocking):
4288         (WTR::TestRunner::statisticsSubmitTelemetry):
4289         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
4290         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
4291         (WTR::TestRunner::statisticsResetToConsistentState):
4292         (WTR::TestRunner::getAllStorageAccessEntries):
4293         (WTR::TestRunner::hasDOMCache):
4294         (WTR::TestRunner::domCacheSize):
4295         (WTR::TestRunner::injectUserScript):
4296         (WTR::TestRunner::keyExistsInKeychain):
4297
4298 2018-12-06  Jonathan Bedard  <jbedard@apple.com>
4299
4300         REGRESSION: run-webkit-tests may fail when using booted simulators
4301         https://bugs.webkit.org/show_bug.cgi?id=192470
4302         <rdar://problem/46532001>