Web Replay: remove some unused code
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-03  Brian Burg  <bburg@apple.com>
2
3         Web Replay: remove some unused code
4         https://bugs.webkit.org/show_bug.cgi?id=173903
5
6         Rubber-stamped by Joseph Pecoraro.
7
8         * Scripts/run-input-generator-tests: Removed.
9         * Scripts/webkitpy/replay/__init__.py: Removed.
10         * Scripts/webkitpy/replay/main.py: Removed.
11
12 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
13
14         [WPE] Fix layout test baseline and TestExpectations hierarchy
15         https://bugs.webkit.org/show_bug.cgi?id=174092
16
17         Reviewed by Michael Catanzaro.
18
19         Like for the GTK+ port, override the default_baseline_search_path() and
20         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
21         Both methods operate on a short list of search paths that defaults to 'wpe' and
22         'wk2', along with any other user-specified platform directory.
23
24         The test_expectations_file_position() method is overridden for testing purposes,
25         and relevant unit tests are added.
26
27         * Scripts/webkitpy/port/wpe.py:
28         (WPEPort._search_paths):
29         (WPEPort):
30         (WPEPort.default_baseline_search_path):
31         (WPEPort._port_specific_expectations_files):
32         (WPEPort.test_expectations_file_position):
33         * Scripts/webkitpy/port/wpe_unittest.py:
34         (WPEPortTest.test_default_baseline_search_path):
35         (WPEPortTest):
36         (WPEPortTest.test_port_specific_expectations_files):
37
38 2017-07-10  Chris Dumez  <cdumez@apple.com>
39
40         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
41         https://bugs.webkit.org/show_bug.cgi?id=174301
42
43         Reviewed by Brent Fulgham.
44
45         Rename some of the testRunner API for clarity and to better match what it calls
46         internally.
47
48         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
49         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
50         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
51         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
52         * WebKitTestRunner/InjectedBundle/TestRunner.h:
53         * WebKitTestRunner/TestController.cpp:
54         (WTR::TestController::statisticsUpdateCookiePartitioning):
55         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
56         * WebKitTestRunner/TestController.h:
57         * WebKitTestRunner/TestInvocation.cpp:
58         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
59         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
60         (WTR::TestController::statisticsUpdateCookiePartitioning):
61         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
62
63 2017-07-10  Charlie Turner  <cturner@igalia.com>
64
65         [GStreamer] Live twitch.tv videos do not play
66         https://bugs.webkit.org/show_bug.cgi?id=174222
67
68         Reviewed by Michael Catanzaro.
69
70         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
71         fixes videos not playing on twitch.tv.
72
73         * gtk/jhbuild.modules:
74
75 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
76
77         Add WebGL2 configuration option to build-webkit
78         https://bugs.webkit.org/show_bug.cgi?id=174251
79
80         Reviewed by Michael Catanzaro.
81
82         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
83         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
84         is marked as enabled for the Apple Cocoa ports.
85
86 2017-07-08  Chris Dumez  <cdumez@apple.com>
87
88         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
89         https://bugs.webkit.org/show_bug.cgi?id=174290
90
91         Reviewed by Brent Fulgham.
92
93         Rename testRunner API to match the new internal API names.
94
95         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
96         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
97         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
98         (WTR::TestRunner::statisticsSubmitTelemetry):
99         * WebKitTestRunner/InjectedBundle/TestRunner.h:
100         * WebKitTestRunner/TestController.cpp:
101         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
102         (WTR::TestController::statisticsSubmitTelemetry):
103         * WebKitTestRunner/TestController.h:
104         * WebKitTestRunner/TestInvocation.cpp:
105         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
106         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
107         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
108         (WTR::TestController::statisticsSubmitTelemetry):
109
110 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
111
112         Drop NOSNIFF compile flag
113         https://bugs.webkit.org/show_bug.cgi?id=174289
114
115         Reviewed by Michael Catanzaro.
116
117         * Scripts/webkitperl/FeatureList.pm:
118         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
119
120 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
121
122         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
123         https://bugs.webkit.org/show_bug.cgi?id=174219
124         <rdar://problem/32083177>
125
126         Reviewed by Ryosuke Niwa.
127
128         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
129         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
130         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
131         place.
132
133         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
134         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
135         no action is taken when dropping.
136
137         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
138         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
139         (TestWebKitAPI::TEST):
140         * TestWebKitAPI/ios/DataInteractionSimulator.h:
141         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
142         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
143         (-[MockDragDropSession allowsMoveOperation]):
144         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
145         (-[MockDataInteractionSession initWithWindow:allowMove:]):
146         (-[DataInteractionSimulator initWithWebView:]):
147         (-[DataInteractionSimulator runFrom:to:]):
148         (-[DataInteractionSimulator _advanceProgress]):
149         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
150         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
151         (-[MockDataInteractionSession initWithWindow:]): Deleted.
152
153 2017-07-07  Commit Queue  <commit-queue@webkit.org>
154
155         Unreviewed, rolling out r219238, r219239, and r219241.
156         https://bugs.webkit.org/show_bug.cgi?id=174265
157
158         "fast/workers/dedicated-worker-lifecycle.html is flaky"
159         (Requested by yusukesuzuki on #webkit).
160
161         Reverted changesets:
162
163         "[WTF] Implement WTF::ThreadGroup"
164         https://bugs.webkit.org/show_bug.cgi?id=174081
165         http://trac.webkit.org/changeset/219238
166
167         "Unreviewed, build fix after r219238"
168         https://bugs.webkit.org/show_bug.cgi?id=174081
169         http://trac.webkit.org/changeset/219239
170
171         "Unreviewed, CLoop build fix after r219238"
172         https://bugs.webkit.org/show_bug.cgi?id=174081
173         http://trac.webkit.org/changeset/219241
174
175 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
176
177         [GTK][WPE] Enable X-Content-Type-Options: nosniff
178         https://bugs.webkit.org/show_bug.cgi?id=174250
179
180         Reviewed by Carlos Alberto Lopez Perez.
181
182         * Scripts/webkitperl/FeatureList.pm:
183
184 2017-07-07  Charlie Turner  <cturner@igalia.com>
185         [GStreamer] vid.me videos do not play
186         https://bugs.webkit.org/show_bug.cgi?id=172240
187
188         Reviewed by Xabier Rodriguez-Calvar.
189
190         Build httpsoupsrc again for use in adaptive streaming pipelines, and
191         have the existing libsoup build against GNOME to avoid header drift
192         against GStreamer's linked Soup library.
193
194         * gtk/jhbuild.modules:
195
196 2017-07-06  Lucas Forschler  <lforschler@apple.com>
197
198         Write a support script to enable buildbot to upload to S3
199         https://bugs.webkit.org/show_bug.cgi?id=174196
200         
201         Reviewed by Stephanie Lewis.
202
203         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
204         (uploadToS3):
205         (archiveExists):
206
207 2017-07-06  Lucas Forschler  <lforschler@apple.com>
208
209         Enabling uploading archives to S3.
210         https://bugs.webkit.org/show_bug.cgi?id=174198
211         
212         Reviewed by Stephanie Lewis.
213
214         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
215         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
216         (UploadMinifiedBuiltProduct): Upload minified archive to build master
217         (TransferToS3): Transfer full and minified archives to S3
218
219 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
220
221         [WTF] Implement WTF::ThreadGroup
222         https://bugs.webkit.org/show_bug.cgi?id=174081
223
224         Reviewed by Mark Lam.
225
226         Add WTF::ThreadGroup tests.
227
228         * TestWebKitAPI/CMakeLists.txt:
229         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
230         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
231         (TestWebKitAPI::TEST):
232
233 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
234
235         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
236         https://bugs.webkit.org/show_bug.cgi?id=174150
237
238         Reviewed by Mark Lam.
239
240         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
241         (TestWebKitAPI::TEST):
242         * TestWebKitAPI/TestsController.cpp:
243         (TestWebKitAPI::TestsController::TestsController):
244
245 2017-07-06  Lucas Forschler  <lforschler@apple.com>
246
247         Enabling uploading archives to S3.
248         https://bugs.webkit.org/show_bug.cgi?id=174198
249         
250         Reviewed by Lucas Forschler.
251
252         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
253         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
254         (UploadMinifiedBuiltProduct): Upload minified archive to build master
255         (TransferToS3): Transfer full and minified archives to S3
256
257 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
258
259         [GTK][WPE] kill-old-process should kill more webkit related process
260         https://bugs.webkit.org/show_bug.cgi?id=174220
261
262         Reviewed by Michael Catanzaro.
263
264         Generate list of possible webkit-related process names and add
265         them to the list of process to kill.
266         Also update the possible system related process for GTK+/WPE.
267
268         * BuildSlaveSupport/kill-old-processes:
269         (listAllWebKitPrograms):
270         (main):
271
272 2017-07-06  Chris Dumez  <cdumez@apple.com>
273
274         FileMonitor should not be ref counted
275         https://bugs.webkit.org/show_bug.cgi?id=174166
276
277         Reviewed by Brent Fulgham.
278
279         Update the API tests to reflect the API change.
280
281         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
282         (TestWebKitAPI::TEST_F):
283
284 2017-07-06  Commit Queue  <commit-queue@webkit.org>
285
286         Unreviewed, rolling out r219194.
287         https://bugs.webkit.org/show_bug.cgi?id=174207
288
289         it broke some layout tests (Requested by clopez on #webkit).
290
291         Reverted changeset:
292
293         "[GStreamer] vid.me videos do not play"
294         https://bugs.webkit.org/show_bug.cgi?id=172240
295         http://trac.webkit.org/changeset/219194
296
297 2017-07-06  Matt Lewis  <jlewis3@apple.com>
298
299         Unreviewed, rolling out r219178.
300
301         This caused a consistent failure with the API test
302         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
303
304         Reverted changeset:
305
306         "[WTF] Clean up StringStatics.cpp by using
307         LazyNeverDestroyed<> for Atoms"
308         https://bugs.webkit.org/show_bug.cgi?id=174150
309         http://trac.webkit.org/changeset/219178
310
311 2017-07-06  Alicia Boya García  <aboya@igalia.com>
312
313         Add CWD to Perl library path (no longer the default since 5.26.0)
314         https://bugs.webkit.org/show_bug.cgi?id=174200
315
316         Reviewed by Michael Catanzaro.
317
318         * Scripts/webkitpy/tool/commands/setupgitclone.py:
319         (SetupGitClone._get_username_and_email):
320
321 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
322
323         Unreviewed, update my email address.
324
325         * Scripts/webkitpy/common/config/contributors.json:
326
327 2017-07-06  Charlie Turner  <cturner@igalia.com>
328         [GStreamer] vid.me videos do not play
329         https://bugs.webkit.org/show_bug.cgi?id=172240
330
331         Reviewed by Xabier Rodriguez-Calvar.
332
333         Build httpsoupsrc again for use in adaptive streaming pipelines, and
334         have the existing libsoup build against GNOME to avoid header drift
335         against GStreamer's linked Soup library.
336
337         * gtk/jhbuild.modules:
338
339 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
340
341         [WTF] Move SoftLinking.h into WTF
342         https://bugs.webkit.org/show_bug.cgi?id=174000
343
344         Reviewed by Alex Christensen.
345
346         * DumpRenderTree/mac/TestRunnerMac.mm:
347         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
348         (test_primary_header):
349         (ErrorCollector.__init__): Deleted.
350         (ErrorCollector.__call__): Deleted.
351         (ErrorCollector.results): Deleted.
352         (ErrorCollector.result_list): Deleted.
353         (ErrorCollector.verify_all_categories_are_seen): Deleted.
354         (MockIo.open): Deleted.
355         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
356         (CppFunctionsTest.test_create_acronym): Deleted.
357         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
358         (CppFunctionsTest.test_parameter): Deleted.
359         (CppFunctionsTest.test_single_line_view): Deleted.
360         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
361         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
362         (CppFunctionsTest.test_parameter_list): Deleted.
363         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
364         (CppStyleTestBase.process_file_data): Deleted.
365         (CppStyleTestBase.perform_lint): Deleted.
366         (CppStyleTestBase.perform_single_line_lint): Deleted.
367         (CppStyleTestBase.perform_multi_line_lint): Deleted.
368         (CppStyleTestBase.perform_language_rules_check): Deleted.
369         (CppStyleTestBase.perform_function_lengths_check): Deleted.
370         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
371         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
372         (CppStyleTestBase.perform_include_what_you_use): Deleted.
373         (CppStyleTestBase.perform_header_guard_check): Deleted.
374         (CppStyleTestBase.assert_lint): Deleted.
375         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
376         (CppStyleTestBase.assert_multi_line_lint): Deleted.
377         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
378         (CppStyleTestBase.assert_language_rules_check): Deleted.
379         (CppStyleTestBase.assert_include_what_you_use): Deleted.
380         (CppStyleTestBase.assert_header_guard): Deleted.
381         (CppStyleTestBase.assert_blank_lines_check): Deleted.
382         (CppStyleTestBase.assert_positions_equal): Deleted.
383         (FunctionDetectionTest.test_basic_function_detection): Deleted.
384         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
385         (FunctionDetectionTest.test_pure_function_detection): Deleted.
386         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
387         (FunctionDetectionTest.test_ignore_macros): Deleted.
388         (FunctionDetectionTest.test_non_functions): Deleted.
389         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
390         (FunctionDetectionTest.test_parameter_list): Deleted.
391         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
392         (CppStyleTest.test_asm_lines_ignored): Deleted.
393         (CppStyleTest.test_get_line_width): Deleted.
394         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
395         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
396         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
397         (CppStyleTest.test_position): Deleted.
398         (CppStyleTest.test_rfind_in_lines): Deleted.
399         (CppStyleTest.test_close_expression): Deleted.
400         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
401         (CppStyleTest.test_cstyle_cast): Deleted.
402         (CppStyleTest.test_runtime_casting): Deleted.
403         (CppStyleTest.test_runtime_selfinit): Deleted.
404         (CppStyleTest.test_runtime_rtti): Deleted.
405         (CppStyleTest.test_static_cast_readability): Deleted.
406         (CppStyleTest.test_check_for_unnamed_params): Deleted.
407         (CppStyleTest.void): Deleted.
408         (CppStyleTest.test_deprecated_cast): Deleted.
409         (CppStyleTest.test_mock_method): Deleted.
410         (CppStyleTest.test_sizeof_type): Deleted.
411         (CppStyleTest.cases): Deleted.
412         (CppStyleTest.for): Deleted.
413         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
414         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
415         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
416         (CppStyleTest.test_include_what_you_use): Deleted.
417         (CppStyleTest.test_files_belong_to_same_module): Deleted.
418         (CppStyleTest.test_cleanse_line): Deleted.
419         (CppStyleTest.test_multi_line_comments): Deleted.
420         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
421         (CppStyleTest.test_multiline_strings): Deleted.
422         (CppStyleTest.test_platformh_comments): Deleted.
423         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
424         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
425         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
426         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
427         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
428         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
429         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
430         (CppStyleTest.test_check_posix_threading): Deleted.
431         (CppStyleTest.test_insecure_string_operations): Deleted.
432         (CppStyleTest.test_format_strings): Deleted.
433         (CppStyleTest.test_insecure_temp_file): Deleted.
434         (CppStyleTest.test_variable_length_array_detection): Deleted.
435         (CppStyleTest.test_braces): Deleted.
436         (CppStyleTest.test_check_check): Deleted.
437         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
438         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
439         (CppStyleTest.test_spacing_for_fncall): Deleted.
440         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
441         (CppStyleTest.test_spacing_before_braces): Deleted.
442         (CppStyleTest.test_spacing_between_braces): Deleted.
443         (CppStyleTest.test_spacing_before_brackets): Deleted.
444         (CppStyleTest.test_cpp_lambda_functions): Deleted.
445         (CppStyleTest.test_objective_c_block): Deleted.
446         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
447         (CppStyleTest.test_spacing_around_else): Deleted.
448         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
449         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
450         (CppStyleTest.test_operator_methods): Deleted.
451         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
452         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
453         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
454         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
455         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
456         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
457         (CppStyleTest.test_space_after_comment_marker): Deleted.
458         (CppStyleTest.test_newline_at_eof): Deleted.
459         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
460         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
461         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
462         (CppStyleTest.test_invalid_utf8): Deleted.
463         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
464         (CppStyleTest.test_is_blank_line): Deleted.
465         (CppStyleTest.test_blank_lines_check): Deleted.
466         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
467         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
468         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
469         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
470         (CppStyleTest.test_comma): Deleted.
471         (CppStyleTest.test_declaration): Deleted.
472         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
473         (CppStyleTest.test_indent): Deleted.
474         (CppStyleTest.test_indent.Foo): Deleted.
475         (CppStyleTest.test_not_alabel): Deleted.
476         (CppStyleTest.test_tab): Deleted.
477         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
478         (CppStyleTest.test_build_class): Deleted.
479         (CppStyleTest.test_build_class.definitions): Deleted.
480         (CppStyleTest.test_build_class.Foo): Deleted.
481         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
482         (CppStyleTest.test_build_end_comment): Deleted.
483         (CppStyleTest.test_build_forward_decl): Deleted.
484         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
485         (CppStyleTest.test_build_header_guard): Deleted.
486         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
487         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
488         (CppStyleTest.test_build_printf_format): Deleted.
489         (CppStyleTest.test_runtime_printf_format): Deleted.
490         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
491         (CppStyleTest.test_build_storage_class): Deleted.
492         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
493         (CppStyleTest.test_build_storage_class.declaration): Deleted.
494         (CppStyleTest.test_build_storage_class.after): Deleted.
495         (CppStyleTest.test_build_storage_class.is): Deleted.
496         (CppStyleTest.test_legal_copyright): Deleted.
497         (CppStyleTest.test_invalid_increment): Deleted.
498         (CppStyleTest.test_enum_bitfields): Deleted.
499         (CppStyleTest.test_plain_integral_bitfields): Deleted.
500         (CleansedLinesTest.test_init_empty): Deleted.
501         (CleansedLinesTest.test_collapse_strings): Deleted.
502         (OrderOfIncludesTest.tearDown): Deleted.
503         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
504         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
505         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
506         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
507         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
508         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
509         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
510         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
511         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
512         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
513         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
514         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
515         (OrderOfIncludesTest.test_primary_header): Deleted.
516         (OrderOfIncludesTest.test_public_primary_header): Deleted.
517         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
518         (OrderOfIncludesTest.test_classify_include): Deleted.
519         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
520         (CheckForFunctionLengthsTest.tearDown): Deleted.
521         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
522         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
523         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
524         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
525         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
526         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
527         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
528         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
529         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
530         (CheckForFunctionLengthsTest.function_body): Deleted.
531         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
532         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
533         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
534         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
535         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
536         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
537         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
538         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
539         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
540         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
541         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
542         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
543         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
544         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
545         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
546         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
547         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
548         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
549         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
550         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
551         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
552         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
553         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
554         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
555         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
556         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
557         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
558         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
559         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
560         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
561         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
562         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
563         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
564         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
565         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
566         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
567         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
568         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
569         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
570         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
571         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
572         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
573         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
574         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
575         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
576         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
577         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
578         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
579         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
580         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
581         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
582         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
583         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
584         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
585         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
586         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
587         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
588         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
589         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
590         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
591         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
592         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
593         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
594         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
595         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
596         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
597         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
598         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
599         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
600         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
601         (LeakyPatternTest.test_get_dc): Deleted.
602         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
603         (LeakyPatternTest.test_own_get_dc): Deleted.
604         (LeakyPatternTest.test_create_dc): Deleted.
605         (LeakyPatternTest.test_create_compatible_dc): Deleted.
606         (WebKitStyleTest.test_indentation): Deleted.
607         (WebKitStyleTest.test_indentation.Foo): Deleted.
608         (WebKitStyleTest.test_indentation.Document): Deleted.
609         (WebKitStyleTest.test_spacing): Deleted.
610         (WebKitStyleTest.test_line_breaking): Deleted.
611         (WebKitStyleTest.test_braces): Deleted.
612         (WebKitStyleTest.test_braces.MyClass): Deleted.
613         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
614         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
615         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
616         (WebKitStyleTest.test_null_false_zero): Deleted.
617         (WebKitStyleTest.test_directive_indentation): Deleted.
618         (WebKitStyleTest.test_using_std): Deleted.
619         (WebKitStyleTest.test_using_namespace): Deleted.
620         (WebKitStyleTest.test_max_macro): Deleted.
621         (WebKitStyleTest.test_min_macro): Deleted.
622         (WebKitStyleTest.test_wtf_move): Deleted.
623         (WebKitStyleTest.test_ctype_fucntion): Deleted.
624         (WebKitStyleTest.test_names): Deleted.
625         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
626         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
627         (WebKitStyleTest.test_names.declarations): Deleted.
628         (WebKitStyleTest.test_names.struct): Deleted.
629         (WebKitStyleTest.test_names.VectorType): Deleted.
630         (WebKitStyleTest.test_parameter_names): Deleted.
631         (WebKitStyleTest.test_comments): Deleted.
632         (WebKitStyleTest.test_webkit_export_check): Deleted.
633         (WebKitStyleTest.test_member_initialization_list): Deleted.
634         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
635         (WebKitStyleTest.test_other): Deleted.
636         (CppCheckerTest.mock_handle_style_error): Deleted.
637         (CppCheckerTest._checker): Deleted.
638         (CppCheckerTest.test_init): Deleted.
639         (CppCheckerTest.test_eq): Deleted.
640         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
641         (CppCheckerTest.test_ne): Deleted.
642         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
643         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
644         * TestWebKitAPI/cocoa/TestWKWebView.mm:
645         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
646         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
647         * WebKitTestRunner/ios/HIDEventGenerator.mm:
648
649 2017-07-05  Saam Barati  <sbarati@apple.com>
650
651         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
652         https://bugs.webkit.org/show_bug.cgi?id=174188
653         <rdar://problem/30581423>
654
655         Reviewed by Mark Lam.
656
657         * Scripts/run-jsc-stress-tests:
658
659 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
660
661         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
662         https://bugs.webkit.org/show_bug.cgi?id=174150
663
664         Reviewed by Mark Lam.
665
666         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
667         (TestWebKitAPI::TEST):
668
669 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
670
671         Remove copy of ICU headers from WebKit
672         https://bugs.webkit.org/show_bug.cgi?id=116407
673
674         Reviewed by Alex Christensen.
675
676         * DumpRenderTree/mac/Configurations/Base.xcconfig:
677         * TestWebKitAPI/Configurations/Base.xcconfig:
678         * WebKitTestRunner/Configurations/Base.xcconfig:
679
680 2017-07-05  Chris Dumez  <cdumez@apple.com>
681
682         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
683         https://bugs.webkit.org/show_bug.cgi?id=174163
684         <rdar://problem/33067518>
685
686         Reviewed by Alex Christensen.
687
688         Add API test coverage.
689
690         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
691         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
692         (TEST):
693
694 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
695
696         When dragging a selection, clearing the selection in dragstart should not crash the web process
697         https://bugs.webkit.org/show_bug.cgi?id=174142
698         <rdar://problem/33067501>
699
700         Reviewed by Tim Horton.
701
702         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
703         drag is starting up.
704
705         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
706         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
707         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
708         (TestWebKitAPI::TEST):
709
710 2017-07-05  Daniel Bates  <dabates@apple.com>
711
712         Do not pass API::FrameInfo for source frame or clear out page of target frame on
713         API navigation
714         https://bugs.webkit.org/show_bug.cgi?id=174170
715         <rdar://problem/33140328>
716
717         Reviewed by Brady Eidson.
718
719         Update tests as needed for the behavior change.
720
721         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
722         (TEST):
723
724 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
725
726         Add WebKitPrivateFrameworkStubs for iOS 11
727         https://bugs.webkit.org/show_bug.cgi?id=173988
728
729         Reviewed by David Kilzer.
730
731         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
732         should use the same directory for private framework stubs.
733         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
734
735 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
736
737         [MediaStream] Protect request and web view during gUM client callback
738         https://bugs.webkit.org/show_bug.cgi?id=174096
739         <rdar://problem/32833102>
740
741         Reviewed by Youenn Fablet.
742
743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
744         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
745
746 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
747
748         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
749
750         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
751
752 2017-07-05  Matt Lewis  <jlewis3@apple.com>
753
754         Unreviewed, rolling out r219128.
755
756         Spoke with engineer who originally submitted, Patch for APi
757         test to follow.
758
759         Reverted changeset:
760
761         "Unreviewed, rolling out r219070."
762         https://bugs.webkit.org/show_bug.cgi?id=174082
763         http://trac.webkit.org/changeset/219128
764
765 2017-07-05  Matt Lewis  <jlewis3@apple.com>
766
767         Unreviewed, rolling out r219070.
768
769         This revision caused consistent failures of the API test
770         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
771
772         Reverted changeset:
773
774         "Pasting single words copied to UIPasteboard inserts URLs in
775         editable areas"
776         https://bugs.webkit.org/show_bug.cgi?id=174082
777         http://trac.webkit.org/changeset/219070
778
779 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
780
781         Remove unused EFL logo from bot watcher dashboard
782         https://bugs.webkit.org/show_bug.cgi?id=174136
783
784         Reviewed by Alexey Proskuryakov.
785
786         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
787         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
788
789 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
790
791         [GTK] Add more GTK bots to dashboard
792         https://bugs.webkit.org/show_bug.cgi?id=174129
793
794         Reviewed by Carlos Alberto Lopez Perez.
795
796         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
797         them.
798
799         This also changes the sort order to put WPE above GTK so that it's not buried under all the
800         less-essential GTK bots.
801
802         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
803         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
804         (WebKitBuildbot):
805
806 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
807
808         [WPE] Add WPE to bot watcher dashboard
809         https://bugs.webkit.org/show_bug.cgi?id=174119
810
811         Reviewed by Alexey Proskuryakov.
812
813         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
814         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
815         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
817         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
818         (WebKitBuildbot):
819         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
820         (table.queue-grid tr.platform.linux-wpe img.logo):
821
822 2017-07-03  Lucas Forschler  <lforschler@apple.com>
823
824         https://bugs.webkit.org/show_bug.cgi?id=174105
825         
826         Reviewed by Stephanie Lewis.
827
828         * BuildSlaveSupport/built-product-archive:
829         (main): Add a -minify parser option
830         (createZip): Pass along the optional Minify argument if requested
831         (minifySource): This will trim down archives, logic limited to Mac platform.
832
833 2017-07-03  Matt Rajca  <mrajca@apple.com>
834
835         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
836         https://bugs.webkit.org/show_bug.cgi?id=174103
837
838         Reviewed by Alex Christensen.
839
840         Added an API test.
841
842         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
843         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
844         (TEST): Added test.
845         * TestWebKitAPI/cocoa/TestWKWebView.h:
846         * TestWebKitAPI/cocoa/TestWKWebView.mm:
847         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
848
849 2017-07-03  Matt Lewis  <jlewis3@apple.com>
850
851         Unreviewed, rolling out r219103.
852
853         Caused multiple build failures.
854
855         Reverted changeset:
856
857         "Remove copy of ICU headers from WebKit"
858         https://bugs.webkit.org/show_bug.cgi?id=116407
859         http://trac.webkit.org/changeset/219103
860
861 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
862
863         Remove copy of ICU headers from WebKit
864         https://bugs.webkit.org/show_bug.cgi?id=116407
865
866         Reviewed by Alex Christensen.
867
868         Use WTF's copy of ICU headers.
869
870         * DumpRenderTree/mac/Configurations/Base.xcconfig:
871         * TestWebKitAPI/Configurations/Base.xcconfig:
872         * WebKitTestRunner/Configurations/Base.xcconfig:
873
874 2017-07-03  Brady Eidson  <beidson@apple.com>
875
876         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
877         https://bugs.webkit.org/show_bug.cgi?id=174073
878
879         Reviewed by Andy Estes.
880
881         * DumpRenderTree/mac/TestRunnerMac.mm:
882         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
883
884         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
885         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
886
887 2017-07-03  Matt Lewis  <jlewis3@apple.com>
888
889         Unreviewed, rolling out r219083.
890
891         The revision caused an API failure on all testing platforms.
892
893         Reverted changeset:
894
895         "[MediaStream] Protect request and web view during gUM client
896         callback"
897         https://bugs.webkit.org/show_bug.cgi?id=174096
898         http://trac.webkit.org/changeset/219083
899
900 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
901
902         webkitpy: Properly number duplicated crashlogs
903         https://bugs.webkit.org/show_bug.cgi?id=172002
904
905         Reviewed by Aakash Jain.
906
907         * Scripts/webkitpy/common/system/crashlogs.py:
908         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
909         an increasing integer.
910         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
911         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
912         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
913         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
914
915 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
916
917         WebContent processes crash when the network process crashes with pending connection requests
918         https://bugs.webkit.org/show_bug.cgi?id=174065
919         <rdar://problem/30359835>
920
921         Reviewed by Tim Horton.
922
923         Add a API to ensure UI process tries to relaunch a new network process when the network process
924         crashes with pending network connection requests.
925
926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
927         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
928         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
929         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
930         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
931
932 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
933
934         [MediaStream] Protect request and web view during gUM client callback
935         https://bugs.webkit.org/show_bug.cgi?id=174096
936         <rdar://problem/32833102>
937
938         Reviewed by Youenn Fablet.
939
940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
941         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
942
943 2017-07-03  Andy Estes  <aestes@apple.com>
944
945         [Xcode] Add an experimental setting to build with ccache
946         https://bugs.webkit.org/show_bug.cgi?id=173875
947
948         Reviewed by Tim Horton.
949
950         On systems that already have ccache(1) installed, this patch adds experimental support for
951         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
952
953         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
954         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
955         find the toolchain from which to run clang, and then invokes ccache with the required
956         arguments.
957
958         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
959         precompiled headers to work properly [1].
960
961         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
962         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
963         during linking.
964         
965         [1] https://ccache.samba.org/manual.html#_precompiled_headers
966
967         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
968         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
969         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
970         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
971         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
972         * ccache/README.md: Added.
973         * ccache/ccache-clang: Added.
974         * ccache/ccache-clang++: Added.
975         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
976
977 2017-07-03  Alex Christensen  <achristensen@webkit.org>
978
979         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
980         https://bugs.webkit.org/show_bug.cgi?id=174051
981
982         Reviewed by Tim Horton.
983
984         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
985         (TestWebKitAPI::TEST_F):
986
987 2017-07-03  Matt Lewis  <jlewis3@apple.com>
988
989         Unreviewed, rolling out r219024.
990
991         This patch cause 3 didferent test to fail.
992
993         Reverted changeset:
994
995         "REGRESSION(r215096) Queries of URLs with non-special schemes
996         should not percent-encode single quotes"
997         https://bugs.webkit.org/show_bug.cgi?id=174051
998         http://trac.webkit.org/changeset/219024
999
1000 2017-07-03  Chris Dumez  <cdumez@apple.com>
1001
1002         Drop ResourceLoadStatisticsStore's statisticsLock
1003         https://bugs.webkit.org/show_bug.cgi?id=174080
1004
1005         Reviewed by Brent Fulgham.
1006
1007         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
1008
1009         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1010         (WTR::TestController::isStatisticsPrevalentResource):
1011         (WTR::TestController::isStatisticsHasHadUserInteraction):
1012         (WTR::TestController::isStatisticsGrandfathered):
1013
1014 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1015
1016         Pasting single words copied to UIPasteboard inserts URLs in editable areas
1017         https://bugs.webkit.org/show_bug.cgi?id=174082
1018         <rdar://problem/33046992>
1019
1020         Reviewed by Tim Horton.
1021
1022         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
1023
1024         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1025         (TestWebKitAPI::setUpWebViewForPasteboardTests):
1026         (TestWebKitAPI::TEST):
1027
1028 2017-07-02  Brady Eidson  <beidson@apple.com>
1029
1030         Add API test for all parts of WebKit1 API related to favicons.
1031         https://bugs.webkit.org/show_bug.cgi?id=174069
1032
1033         Reviewed by Andy Estes.
1034
1035         These two API tests cover all WebKit1 API related to icons.
1036         
1037         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1038         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
1039         (mainResourceData):
1040         (defaultFaviconData):
1041         (customFaviconData):
1042         (imageFromData):
1043         (+[IconLoadingProtocol canInitWithRequest:]):
1044         (+[IconLoadingProtocol canonicalRequestForRequest:]):
1045         (-[IconLoadingProtocol startLoading]):
1046         (-[IconLoadingProtocol stopLoading]):
1047         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1048         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
1049         (TestWebKitAPI::TEST):
1050
1051 2017-07-01  Dan Bernstein  <mitz@apple.com>
1052
1053         [iOS] Remove code only needed when building for iOS 9.x
1054         https://bugs.webkit.org/show_bug.cgi?id=174068
1055
1056         Reviewed by Tim Horton.
1057
1058         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1059         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1060         (WTR::initializeWebViewConfiguration):
1061         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1062         (-[HIDEventGenerator _createIOHIDEventType:]):
1063
1064 2017-07-01  Brady Eidson  <beidson@apple.com>
1065
1066         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
1067         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
1068
1069         Reviewed by Alex Christensen.
1070
1071         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1072
1073 2017-07-01  Dan Bernstein  <mitz@apple.com>
1074
1075         [macOS] Remove code only needed when building for OS X Yosemite
1076         https://bugs.webkit.org/show_bug.cgi?id=174067
1077
1078         Reviewed by Tim Horton.
1079
1080         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1081         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1082         * DumpRenderTree/mac/DumpRenderTree.mm:
1083         (setDefaultsToConsistentValuesForTesting):
1084         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1085         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
1086         * MiniBrowser/Configurations/Base.xcconfig:
1087         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1088         * TestWebKitAPI/Configurations/Base.xcconfig:
1089         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1090         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1091         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1092         (TestWebKitAPI::TEST_F):
1093         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
1094         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
1095         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1096         (TestWebKitAPI::TEST_F):
1097         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1098         (TestWebKitAPI::TEST):
1099         * WebKitTestRunner/Configurations/Base.xcconfig:
1100         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1101         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1102         (WTR::InjectedBundle::platformInitialize):
1103         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1104         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
1105
1106 2017-07-01  Chris Dumez  <cdumez@apple.com>
1107
1108         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
1109         https://bugs.webkit.org/show_bug.cgi?id=174060
1110
1111         Reviewed by Brent Fulgham.
1112
1113         Port WebKitTestRunner over to the new Cocoa SPI.
1114
1115         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1116         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1117         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1118         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
1119         no-ops since this code runs in the WebContent process, not the
1120         UIProcess.
1121
1122         * WebKitTestRunner/TestController.cpp:
1123         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1124
1125 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
1126
1127         Unreviewed mac build fix.
1128
1129         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1130         (TestWebKitAPI::TEST):
1131
1132 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
1133
1134         Add API to get WKActivatedElementInfo
1135         https://bugs.webkit.org/show_bug.cgi?id=174001
1136         <rdar://problem/29165518>
1137         
1138         Tests for now SPI to get activatedElementInfo.
1139
1140         Reviewed by Tim Horton.
1141
1142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1143         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
1144         (TestWebKitAPI::TEST):
1145
1146 2017-06-30  Chris Dumez  <cdumez@apple.com>
1147
1148         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
1149         https://bugs.webkit.org/show_bug.cgi?id=174038
1150
1151         Reviewed by Brent Fulgham.
1152
1153         Fix typo in API name.
1154
1155         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1156         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1157         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1158         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1159         * WebKitTestRunner/TestController.cpp:
1160         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1161         * WebKitTestRunner/TestController.h:
1162         * WebKitTestRunner/TestInvocation.cpp:
1163         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1164
1165 2017-06-30  Alex Christensen  <achristensen@webkit.org>
1166
1167         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
1168         https://bugs.webkit.org/show_bug.cgi?id=174051
1169         <rdar://problem/33002846>
1170
1171         Reviewed by Tim Horton.
1172
1173         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1174         (TestWebKitAPI::TEST_F):
1175
1176 2017-06-30  Daniel Bates  <dabates@apple.com>
1177
1178         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
1179         https://bugs.webkit.org/show_bug.cgi?id=165160
1180         <rdar://problem/29451999>
1181
1182         Reviewed by Brady Eidson.
1183
1184         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
1185         for navigations and window creation.
1186
1187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1188         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
1189         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
1190         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
1191         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1192         (TEST):
1193
1194 2017-06-29  Jer Noble  <jer.noble@apple.com>
1195
1196         Make Legacy EME API controlled by RuntimeEnabled setting.
1197         https://bugs.webkit.org/show_bug.cgi?id=173994
1198
1199         Reviewed by Sam Weinig.
1200
1201         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1202
1203 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
1204
1205         Follow-up fix for r218996
1206
1207         Unreviewed infrastructure fix.
1208
1209         Repeated calls to 'ios_version' make the log noisy, memoize the function.
1210
1211         * Scripts/webkitpy/port/ios_simulator.py:
1212         (IOSSimulatorPort): Memoize ios_version().
1213
1214 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1215
1216         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
1217         https://bugs.webkit.org/show_bug.cgi?id=174017
1218         <rdar://problem/32959782>
1219
1220         Reviewed by Simon Fraser.
1221
1222         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
1223         changes, the caret would appear outside of the iframe.
1224
1225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1226         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
1227         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1228         (checkDragCaretRectIsContainedInRect):
1229         (TestWebKitAPI::TEST):
1230         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1231         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1232         (-[DataInteractionSimulator _resetSimulatedState]):
1233         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
1234         (-[DataInteractionSimulator _advanceProgress]):
1235         (-[DataInteractionSimulator lastKnownDragCaretRect]):
1236
1237 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
1238
1239         Add support for different versions of iOS when loading test expectations
1240         https://bugs.webkit.org/show_bug.cgi?id=173774
1241         <rdar://problem/32951132>
1242
1243         Rubber-stamped by Aakash Jain.
1244
1245         When running layout tests, we should support multiple version of iOS the same way we do Mac.
1246
1247         * Scripts/webkitpy/port/ios.py:
1248         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
1249         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
1250         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
1251         * Scripts/webkitpy/port/ios_device.py:
1252         (IOSDevicePort.ios_version): Ask connected devices for implementation.
1253         * Scripts/webkitpy/port/ios_device_unittest.py:
1254         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
1255         (IOSDeviceTest.test_baseline_searchpath): Ditto.
1256         (IOSDeviceTest.test_expectations_ordering): Ditto.
1257         * Scripts/webkitpy/port/ios_simulator.py:
1258         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
1259         ask the platform.
1260
1261 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
1262
1263         Fontconfig build breaks with glibc 2.15+
1264         https://bugs.webkit.org/show_bug.cgi?id=174019
1265
1266         Reviewed by Carlos Alberto Lopez Perez.
1267
1268         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
1269
1270         * wpe/jhbuild.modules:
1271         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
1272
1273 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1274
1275         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
1276         https://bugs.webkit.org/show_bug.cgi?id=174010
1277         <rdar://problem/32597802>
1278
1279         Reviewed by Tim Horton.
1280
1281         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
1282         snapshot fails for any reason.
1283
1284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1285         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
1286         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1287         (TestWebKitAPI::TEST):
1288
1289 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
1290
1291         AX: Cannot call setValue() on contenteditable or ARIA text controls
1292         https://bugs.webkit.org/show_bug.cgi?id=173520
1293
1294         Reviewed by Ryosuke Niwa.
1295
1296         Add setValue() method to WKTR (already existed in DRT).
1297
1298         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1299         (WTR::AccessibilityUIElement::setValue):
1300         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1301         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1302         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1303         (WTR::AccessibilityUIElement::setValue):
1304
1305 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
1306
1307         getBoundingClientRect returns wrong value for combination of page zoom and scroll
1308         https://bugs.webkit.org/show_bug.cgi?id=173841
1309         rdar://problem/32983841
1310
1311         Reviewed by Dean Jackson.
1312
1313         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
1314         always did text zooming.
1315
1316         * MiniBrowser/mac/WK1BrowserWindowController.m:
1317         (-[WK1BrowserWindowController zoomIn:]):
1318         (-[WK1BrowserWindowController zoomOut:]):
1319         (-[WK1BrowserWindowController canResetZoom]):
1320         (-[WK1BrowserWindowController resetZoom:]):
1321
1322 2017-06-29  John Wilander  <wilander@apple.com>
1323
1324         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
1325         https://bugs.webkit.org/show_bug.cgi?id=173940
1326         <rdar://problem/33018125>
1327
1328         Reviewed by Brent Fulgham.
1329
1330         This change allows the TestController to turn off
1331         regular resource load statistics telemetry submission
1332         and to manually control when telemetry is calculated
1333         and submitted.
1334
1335         * WebKitTestRunner/TestController.cpp:
1336         (WTR::TestController::initialize):
1337             Turns off automatic resource load statistics telemetry submission.
1338
1339 2017-06-29  Commit Queue  <commit-queue@webkit.org>
1340
1341         Unreviewed, rolling out r218512.
1342         https://bugs.webkit.org/show_bug.cgi?id=173981
1343
1344         "It changes the behavior of the JS API's JSEvaluateScript
1345         which breaks TurboTax" (Requested by saamyjoon on #webkit).
1346
1347         Reverted changeset:
1348
1349         "test262: Completion values for control flow do not match the
1350         spec"
1351         https://bugs.webkit.org/show_bug.cgi?id=171265
1352         http://trac.webkit.org/changeset/218512
1353
1354 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
1355
1356         Add WebKitSystemInterface for iOS 11
1357         https://bugs.webkit.org/show_bug.cgi?id=173936
1358
1359         Reviewed by Lucas Forschler.
1360
1361         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
1362
1363 2017-06-28  Keith Miller  <keith_miller@apple.com>
1364
1365         VMTraps has some races
1366         https://bugs.webkit.org/show_bug.cgi?id=173941
1367
1368         Reviewed by Michael Saboff.
1369
1370         Add new testing mode for testing the Watchdog with our stress
1371         tests.
1372
1373         * Scripts/run-jsc-stress-tests:
1374
1375 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1376
1377         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
1378         https://bugs.webkit.org/show_bug.cgi?id=173877
1379
1380         Reviewed by Brady Eidson.
1381
1382         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
1383         the next tests.
1384
1385         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1386         (testGetFavicon):
1387
1388 2017-06-28  Tim Horton  <timothy_horton@apple.com>
1389
1390         MobileSafari was constantly using 10-15% CPU viewing a PDF
1391         https://bugs.webkit.org/show_bug.cgi?id=173944
1392         <rdar://problem/33039910>
1393
1394         Reviewed by Simon Fraser.
1395
1396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1397         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
1398         Add a test that we ever call the stable presentation update callback
1399         when we have a WKPDFView up, instead of infinitely looping.
1400
1401 2017-06-28  Alex Christensen  <achristensen@webkit.org>
1402
1403         Prevent displaying URLs with small capital letters
1404         https://bugs.webkit.org/show_bug.cgi?id=173949
1405         <rdar://problem/32952058>
1406
1407         Reviewed by Brent Fulgham.
1408
1409         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1410         (TestWebKitAPI::TEST):
1411
1412 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
1413
1414         Unreviewed test fix.
1415
1416         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
1417
1418         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
1419
1420 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
1421
1422         Teach ResourceLoadStatistics to recognize changes in the file system
1423         https://bugs.webkit.org/show_bug.cgi?id=173800
1424         <rdar://problem/32937842>
1425
1426         Reviewed by Chris Dumez.
1427
1428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1429         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
1430         (TestWebKitAPI::FileMonitorTest::tempFilePath):
1431         (TestWebKitAPI::handleFileModification):
1432         (TestWebKitAPI::handleFileDeletion):
1433         (TestWebKitAPI::resetTestState):
1434         (TestWebKitAPI::TEST_F):
1435
1436 2017-06-28  Brady Eidson  <beidson@apple.com>
1437
1438         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
1439         https://bugs.webkit.org/show_bug.cgi?id=173874
1440
1441         Reviewed by Alex Christensen.
1442
1443         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1444
1445 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
1446
1447         Unreviewed, adding Don Olmstead to contributors.json
1448
1449         * Scripts/webkitpy/common/config/contributors.json:
1450
1451 2017-06-28  Alex Christensen  <achristensen@webkit.org>
1452
1453         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
1454         https://bugs.webkit.org/show_bug.cgi?id=173886
1455         <rdar://problem/32543191>
1456
1457         Reviewed by Andy Estes.
1458
1459         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1460         (ParsedRange::ParsedRange):
1461         (-[TestSchemeHandler initWithVideoData:]):
1462         (-[TestSchemeHandler webView:startURLSchemeTask:]):
1463         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
1464         (TEST):
1465
1466 2017-06-27  JF Bastien  <jfbastien@apple.com>
1467
1468         WebAssembly: running out of executable memory should throw OoM
1469         https://bugs.webkit.org/show_bug.cgi?id=171537
1470         <rdar://problem/32963338>
1471
1472         Reviewed by Saam Barati.
1473
1474         * Scripts/run-jsc-stress-tests: add a configuration which runs the
1475         tests under limited executable memory and avoids non-WebAssembly
1476         code generation so that we more reliably run out of executable
1477         memory in WebAssembly.
1478
1479 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1480
1481         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
1482         https://bugs.webkit.org/show_bug.cgi?id=173854
1483         <rdar://problem/32236827>
1484
1485         Reviewed by Ryosuke Niwa and Tim Horton.
1486
1487         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
1488
1489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1490         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
1491         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1492         (TestWebKitAPI::TEST):
1493
1494 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
1495
1496         [PAL] Add symbol export macros for PAL
1497         https://bugs.webkit.org/show_bug.cgi?id=171519
1498
1499         Reviewed by Konstantin Tokarev.
1500
1501         * DumpRenderTree/config.h:
1502         * TestWebKitAPI/CMakeLists.txt:
1503         * TestWebKitAPI/config.h:
1504         * WebKitTestRunner/config.h:
1505
1506 2017-06-27  John Wilander  <wilander@apple.com>
1507
1508         Resource Load Statistics: Add telemetry
1509         https://bugs.webkit.org/show_bug.cgi?id=173499
1510         <rdar://problem/32826094>
1511
1512         Reviewed by Brent Fulgham.
1513
1514         Adds three new testRunner functions:
1515         - installStatisticsDidRunTelemetryCallback()
1516         - statisticsFireTelemetryHandler()
1517         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
1518
1519         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1520         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1521         (WTR::InjectedBundle::didReceiveMessageToPage):
1522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1523         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
1524         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
1525         (WTR::TestRunner::statisticsFireTelemetryHandler):
1526         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1527         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1528         * WebKitTestRunner/TestController.cpp:
1529         (WTR::TestController::resetStateToConsistentValues):
1530         (WTR::TestController::statisticsFireTelemetryHandler):
1531         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1532         * WebKitTestRunner/TestController.h:
1533         * WebKitTestRunner/TestInvocation.cpp:
1534         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1535
1536 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
1537
1538         Add missing includes to fix compilation error on FreeBSD
1539         https://bugs.webkit.org/show_bug.cgi?id=172919
1540
1541         Reviewed by Mark Lam.
1542
1543         * ImageDiff/cairo/PlatformImageCairo.cpp:
1544
1545 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
1546
1547         Unreviewed, rolling out r218783.
1548
1549         Causing accessibility/mac/setting-attributes-is-
1550         asynchronous.html to crash consistently on mac-wk2 Debug
1551
1552         Reverted changeset:
1553
1554         "AX: Cannot call setValue() on contenteditable or ARIA text
1555         controls"
1556         https://bugs.webkit.org/show_bug.cgi?id=173520
1557         http://trac.webkit.org/changeset/218783
1558
1559 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1560
1561         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
1562         https://bugs.webkit.org/show_bug.cgi?id=173825
1563
1564         Reviewed by Saam Barati.
1565
1566         * DumpRenderTree/JavaScriptThreading.cpp:
1567         (runJavaScriptThread):
1568         (startJavaScriptThreads):
1569         * DumpRenderTree/mac/DumpRenderTree.mm:
1570         (runThread):
1571         (runPthread):
1572         (testThreadIdentifierMap):
1573
1574 2017-06-26  David Kilzer  <ddkilzer@apple.com>
1575
1576         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
1577         <https://webkit.org/b/173837>
1578
1579         Reviewed by Geoffrey Garen.
1580
1581         The clang static analyzer can't reason about objects that are
1582         assigned to a delegate as +1 retained, and then released
1583         later in a different method when the delegate is cleared.
1584
1585         Instead, use a common idiom where the object setting the
1586         delegate retains it as an instance variable on initialization.
1587         Then the same object clears the delegate and releases its
1588         instance variable during teardown.
1589
1590         Also add EXPECT_TRUE() tests to make sure the delegate objects
1591         match before teardown.
1592
1593         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1594         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1595         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
1596         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1597         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
1598         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
1599
1600 2017-06-26  David Kilzer  <ddkilzer@apple.com>
1601
1602         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
1603         <https://webkit.org/b/173836>
1604
1605         Reviewed by Brady Eidson.
1606
1607         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1608         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
1609         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
1610         objects in this test.
1611
1612 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
1613
1614         [ATK] Add support for aria-details and aria-errormessage
1615         https://bugs.webkit.org/show_bug.cgi?id=172588
1616
1617         Reviewed by Chris Fleizach.
1618
1619         Add additional methods to test ARIA properties which are exposed via
1620         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
1621         to versions which support the details and error-message relation types.
1622
1623         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1624         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
1625         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
1626         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
1627         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
1628         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1629         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1630         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
1631         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
1632         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
1633         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
1634         * gtk/jhbuild.modules:
1635
1636 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1637
1638         Unreviewed. Add libfii to GTK+ install dependencies script.
1639
1640         * gtk/install-dependencies:
1641
1642 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1643
1644         Unreviewed, rolling out r215190.
1645
1646         Broke product select element on GNOME Bugzilla
1647
1648         Reverted changeset:
1649
1650         "[GTK] Misplaced right click menu on web page due to
1651         deprecated gtk_menu_popup()"
1652         https://bugs.webkit.org/show_bug.cgi?id=170553
1653         http://trac.webkit.org/changeset/215190
1654
1655 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
1656
1657         Remove Reflect.enumerate
1658         https://bugs.webkit.org/show_bug.cgi?id=173806
1659
1660         Reviewed by Yusuke Suzuki.
1661
1662         * Scripts/run-jsc-stress-tests:
1663
1664 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
1665
1666         AX: Cannot call setValue() on contenteditable or ARIA text controls
1667         https://bugs.webkit.org/show_bug.cgi?id=173520
1668
1669         Reviewed by Ryosuke Niwa.
1670
1671         Add setValue() method to WKTR (already existed in DRT).
1672
1673         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1674         (WTR::AccessibilityUIElement::setValue):
1675         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1676         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1677         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1678         (WTR::AccessibilityUIElement::setValue):
1679
1680 2017-06-23  Keith Miller  <keith_miller@apple.com>
1681
1682         Switch VMTraps to use halt instructions rather than breakpoint instructions
1683         https://bugs.webkit.org/show_bug.cgi?id=173677
1684
1685         Reviewed by JF Bastien.
1686
1687         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1688         (TEST):
1689
1690 2017-06-23  Youenn Fablet  <youenn@apple.com>
1691
1692         Set getUserMedia permission to true by default on WTR
1693         https://bugs.webkit.org/show_bug.cgi?id=173610
1694
1695         Reviewed by Alex Christensen.
1696
1697         Adding a way to reset the getUserMedia permission to pending.
1698
1699         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1700         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1701         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
1702         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1703         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1704         (WTR::TestRunner::setUserMediaPermissionAsUnset):
1705         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1706         * WebKitTestRunner/TestController.cpp:
1707         (WTR::TestController::resetStateToConsistentValues):
1708         (WTR::TestController::setUserMediaPermissionAsUnset):
1709         * WebKitTestRunner/TestController.h:
1710         * WebKitTestRunner/TestInvocation.cpp:
1711         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1712
1713 2017-06-23  Alex Christensen  <achristensen@webkit.org>
1714
1715         Add SPI to WKURLSchemeTask for redirection
1716         https://bugs.webkit.org/show_bug.cgi?id=173730
1717
1718         Reviewed by Brady Eidson.
1719
1720         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1721         (-[SchemeHandler webView:startURLSchemeTask:]):
1722         (-[SchemeHandler webView:stopURLSchemeTask:]):
1723         (TEST):
1724         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
1725         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
1726         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
1727         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
1728         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
1729
1730 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1731
1732         [WPE] Use JSC API to send script messages from web extension in tests
1733         https://bugs.webkit.org/show_bug.cgi?id=173757
1734
1735         Reviewed by Žan Doberšek.
1736
1737         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
1738         to run postMessage().
1739
1740         Fixes: /wpe/WebKitSecurityManager/file-xhr
1741                /wpe/WebKitConsoleMessage/console-api
1742                /wpe/WebKitConsoleMessage/js-exception
1743                /wpe/WebKitConsoleMessage/network-error
1744                /wpe/WebKitConsoleMessage/security-error
1745
1746         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1747         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
1748         (beforeAll): Ditto.
1749         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1750         (testWebContextSecurityFileXHR): Ditto.
1751         (beforeAll): Ditto.
1752         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1753         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
1754         (pageCreatedCallback): Remove ifdefs.
1755
1756 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1757
1758         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
1759
1760         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
1761         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
1762         doesn't exist yet in WPE.
1763
1764         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1765         (testWebViewJavaScriptDialogs):
1766         (testWebViewWindowProperties):
1767
1768 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1769
1770         [GTK] Upgrade pixman and cairo in jhbuild
1771         https://bugs.webkit.org/show_bug.cgi?id=173710
1772
1773         Reviewed by Carlos Alberto Lopez Perez.
1774
1775         * gtk/jhbuild.modules:
1776
1777 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1778
1779         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
1780         https://bugs.webkit.org/show_bug.cgi?id=173711
1781
1782         Reviewed by Carlos Alberto Lopez Perez.
1783
1784         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
1785         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
1786
1787         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1788         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
1789
1790 2017-06-22  David Kilzer  <ddkilzer@apple.com>
1791
1792         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
1793         <https://webkit.org/b/173721>
1794
1795         Reviewed by Joseph Pecoraro.
1796
1797         Use RetainPtr<> to create NSMutableDictionary and NSNumber
1798         objects to fix leaks and to avoid the autoreleasepool.
1799
1800         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
1801         (TEST):
1802
1803 2017-06-22  Matt Lewis  <jlewis3@apple.com>
1804
1805         Unreviewed, rolling out r218633.
1806
1807         The test is failing frequently on Sierra Debug and Windows
1808
1809         Reverted changeset:
1810
1811         "AX: Cannot call setValue() on contenteditable or ARIA text
1812         controls"
1813         https://bugs.webkit.org/show_bug.cgi?id=173520
1814         http://trac.webkit.org/changeset/218633
1815
1816 2017-06-22  David Kilzer  <ddkilzer@apple.com>
1817
1818         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
1819         <https://webkit.org/b/173690>
1820
1821         Reviewed by Chris Dumez.
1822
1823         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
1824         ownership of malloc()-ed memory, then frees it when it's
1825         released.  These tests were passing global variables into the
1826         method, which is not malloc()-ed memory, which violates the API
1827         contract.
1828
1829         The fix is to switch to use
1830         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
1831         NO for the last argument.
1832
1833         Caught by the clang static analyzer.
1834
1835         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1836         (TEST):
1837         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1838         (TEST):
1839
1840 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1841
1842         [GTK] Upgrade Harfbuzz to version 1.4.2
1843         https://bugs.webkit.org/show_bug.cgi?id=173592
1844
1845         Reviewed by Carlos Alberto Lopez Perez.
1846
1847         * gtk/jhbuild.modules:
1848
1849 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1850
1851         [WPE] Update WPEBackend-mesa
1852         https://bugs.webkit.org/show_bug.cgi?id=173705
1853
1854         Reviewed by Carlos Alberto Lopez Perez.
1855
1856         A crash has been fixed, needed for unit tests to work.
1857
1858         * wpe/jhbuild.modules:
1859
1860 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1861
1862         Remove unused coordinated graphics C API
1863         https://bugs.webkit.org/show_bug.cgi?id=173706
1864
1865         Reviewed by Žan Doberšek.
1866
1867         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
1868         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
1869         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
1870         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
1871         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
1872         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
1873
1874 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1875
1876         [WPE] Build glib API tests
1877         https://bugs.webkit.org/show_bug.cgi?id=173702
1878
1879         Reviewed by Žan Doberšek.
1880
1881         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
1882         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
1883         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
1884         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
1885         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
1886         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
1887         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
1888         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
1889         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
1890         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
1891         and implement the missing features.
1892
1893         * CMakeLists.txt:
1894         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
1895         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1896         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1897         (testAutomationSessionRequestSession):
1898         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
1899         (testWebKitWebViewSessionState):
1900         (testWebKitWebViewSessionStateWithFormData):
1901         (testWebKitWebViewNavigationAfterSessionRestore):
1902         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1903         (beforeAll):
1904         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1905         (testCookieManagerEphemeral):
1906         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1907         (testBlobDownload):
1908         (beforeAll):
1909         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1910         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1911         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1912         (testProcessPerWebView):
1913         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1914         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1915         (testWebViewCreateNavigationData):
1916         (testWebViewJavaScriptDialogs):
1917         (testWebViewWindowProperties):
1918         (testWebViewMouseTarget):
1919         (testWebViewGeolocationPermissionRequests):
1920         (testWebViewUserMediaPermissionRequests):
1921         (testWebViewAudioOnlyUserMediaPermissionRequests):
1922         (testWebViewFileChooserRequest):
1923         (beforeAll):
1924         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1925         (beforeAll):
1926         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1927         (testPrivateBrowsing):
1928         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
1929         (testFindControllerHide):
1930         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
1931         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1932         (testWebKitSettings):
1933         (beforeAll):
1934         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1935         (testWebViewNewWithUserContentManager):
1936         (beforeAll):
1937         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1938         (testWebContextEphemeral):
1939         (testWebContextProxySettings):
1940         (beforeAll):
1941         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1942         (testWebViewWebContext):
1943         (testWebViewWebContextLifetime):
1944         (testWebViewEphemeral):
1945         (testWebViewSettings):
1946         (testWebViewCanShowMIMEType):
1947         (testWebViewPageVisibility):
1948         (testWebViewIsPlayingAudio):
1949         (beforeAll):
1950         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1951         (testWebsiteDataEphemeral):
1952         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1953         (documentLoadedCallback):
1954         (pageCreatedCallback):
1955         (methodCallCallback):
1956         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
1957         * TestWebKitAPI/glib/CMakeLists.txt:
1958         * TestWebKitAPI/glib/PlatformGTK.cmake:
1959         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1960         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1961         (main):
1962         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1963         (Test::adoptView):
1964         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1965         (WebKitTestBus::run):
1966         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1967         (WebViewTest::~WebViewTest):
1968         (WebViewTest::initializeWebView):
1969         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
1970         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
1971         (WebViewTest::platformDestroy):
1972         (WebViewTest::platformInitializeWebView):
1973         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
1974         (WebViewTest::resizeView):
1975         (WebViewTest::hideView):
1976         (parentWindowMapped):
1977         (WebViewTest::showInWindow):
1978         (WebViewTest::showInWindowAndWaitUntilMapped):
1979         (WebViewTest::mouseMoveTo):
1980         (WebViewTest::clickMouseButton):
1981         (WebViewTest::emitPopupMenuSignal):
1982         (WebViewTest::keyStroke):
1983         (WebViewTest::doMouseButtonEvent):
1984         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
1985         (WebViewTest::platformDestroy):
1986         (WebViewTest::platformInitializeWebView):
1987         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
1988         (WebViewTest::resizeView):
1989         (WebViewTest::hideView):
1990         (WebViewTest::mouseMoveTo):
1991         (WebViewTest::clickMouseButton):
1992         (WebViewTest::keyStroke):
1993
1994 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1995
1996         [GTK] Move WebKit2 GLib API tests to glib directories
1997         https://bugs.webkit.org/show_bug.cgi?id=173642
1998
1999         Reviewed by Žan Doberšek.
2000
2001         * CMakeLists.txt:
2002         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
2003         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
2004         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
2005         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
2006         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
2007         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
2008         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
2009         (testWebKitConsoleMessageNetworkError):
2010         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
2011         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
2012         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
2013         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
2014         (testLoadFromGResource):
2015         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
2016         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
2017         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
2018         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
2019         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
2020         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
2021         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
2022         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
2023         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
2024         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
2025         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
2026         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
2027         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
2028         (testWebViewRunJavaScript):
2029         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
2030         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
2031         (registerGResource):
2032         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
2033         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
2034         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
2035         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
2036         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
2037         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
2038         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
2039         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
2040         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
2041         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
2042         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
2043         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
2044         * TestWebKitAPI/glib/CMakeLists.txt: Added.
2045         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
2046         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
2047         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
2048         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
2049         (registerGResource):
2050         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
2051         (Test::getResourcesDir):
2052         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
2053         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
2054         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
2055         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
2056         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
2057         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
2058
2059 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2060
2061         [WPE] Add initial web extensions API
2062         https://bugs.webkit.org/show_bug.cgi?id=173640
2063
2064         Reviewed by Žan Doberšek.
2065
2066         Add style checker exceptions for WPE web extensions API files.
2067
2068         * Scripts/webkitpy/style/checker.py:
2069
2070 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2071
2072         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
2073         https://bugs.webkit.org/show_bug.cgi?id=173659
2074         <rdar://problem/32879788>
2075
2076         Reviewed by Tim Horton.
2077
2078         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
2079
2080         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
2081
2082         Augment this test page to log dragend and dragstart events on the drag source as well.
2083
2084         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2085         (checkStringArraysAreEqual):
2086         (TestWebKitAPI::TEST):
2087
2088 2017-06-21  Antoine Quint  <graouts@apple.com>
2089
2090         Ensure DRT always logs rAF suspension debugging code
2091         https://bugs.webkit.org/show_bug.cgi?id=173681
2092
2093         Reviewed by Tim "Mr. T" Horton.
2094
2095         * DumpRenderTree/mac/DumpRenderTree.mm:
2096         (resetWebPreferencesToConsistentValues):
2097
2098 2017-06-21  Chris Dumez  <cdumez@apple.com>
2099
2100         Allow constructing a WTF:Function from a function pointer
2101         https://bugs.webkit.org/show_bug.cgi?id=173660
2102
2103         Reviewed by Alex Christensen.
2104
2105         Add API test coverage.
2106
2107         * TestWebKitAPI/Tests/WTF/Function.cpp:
2108         (TestWebKitAPI::returnThree):
2109         (TestWebKitAPI::returnFour):
2110         (TestWebKitAPI::returnPassedValue):
2111         (TestWebKitAPI::TEST):
2112
2113 2017-06-21  Antoine Quint  <graouts@apple.com>
2114
2115         Add logging to identify when the Page suspends scripted animations
2116         https://bugs.webkit.org/show_bug.cgi?id=173626
2117
2118         Reviewed by Tim Horton.
2119
2120         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
2121
2122         * DumpRenderTree/mac/DumpRenderTree.mm:
2123         (resetWebPreferencesToConsistentValues):
2124
2125 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
2126
2127         AX: Cannot call setValue() on contenteditable or ARIA text controls
2128         https://bugs.webkit.org/show_bug.cgi?id=173520
2129
2130         Reviewed by Ryosuke Niwa.
2131
2132         Add setValue() method to WKTR (already existed in DRT).
2133
2134         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2135         (WTR::AccessibilityUIElement::setValue):
2136         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2137         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2138         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2139         (WTR::AccessibilityUIElement::setValue):
2140
2141 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
2142
2143         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
2144         as one of the dependencies required to build the product.
2145
2146         Rubber-stamped by Carlos Garcia Campos.
2147
2148         * gtk/install-dependencies:
2149         * wpe/install-dependencies:
2150
2151 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
2152
2153         Disable font variations on macOS Sierra and iOS 10
2154         https://bugs.webkit.org/show_bug.cgi?id=173618
2155         <rdar://problem/32879164>
2156
2157         Reviewed by Jon Lee.
2158
2159         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2160
2161 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
2162
2163         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
2164         https://bugs.webkit.org/show_bug.cgi?id=173578
2165         <rdar://problem/32825028>
2166
2167         Reviewed by Tim Horton.
2168
2169         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
2170         a custom popover does not cause dragging to fail when the popover is presented.
2171
2172         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2173         (-[DataInteractionSimulator _advanceProgress]):
2174
2175 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2176
2177         [WPE] Add initial implementation of glib API
2178         https://bugs.webkit.org/show_bug.cgi?id=173546
2179
2180         Reviewed by Žan Doberšek.
2181
2182         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
2183         include WPE glib API files.
2184
2185         * Scripts/webkitperl/FeatureList.pm:
2186         * Scripts/webkitpy/style/checker.py:
2187         * Scripts/webkitpy/style/checkers/cpp.py:
2188         (check_identifier_name_in_declaration):
2189
2190 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2191
2192         [GTK] Upgrade to ICU to version 57.1
2193         https://bugs.webkit.org/show_bug.cgi?id=173538
2194
2195         Reviewed by Žan Doberšek.
2196
2197         * gtk/jhbuild.modules:
2198
2199 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2200
2201         [GTK] Remove unneeded modules from the jhbuild
2202         https://bugs.webkit.org/show_bug.cgi?id=170540
2203
2204         Reviewed by Michael Catanzaro.
2205
2206         We are building libxslt and libffi that we don't really need to build from sources.
2207
2208         * gtk/jhbuild.modules:
2209
2210 2017-06-19  Frederic Wang  <fwang@igalia.com>
2211
2212         [Mac] Add an experimental feature setting for async frame scrolling
2213         https://bugs.webkit.org/show_bug.cgi?id=173359
2214
2215         Reviewed by Simon Fraser.
2216
2217         * DumpRenderTree/mac/DumpRenderTree.mm:
2218         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
2219         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
2220         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2221         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
2222
2223 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
2224
2225         Unreviewed, adding myself to contributors.json
2226
2227         * Scripts/webkitpy/common/config/contributors.json:
2228
2229 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
2230
2231         test262: Completion values for control flow do not match the spec
2232         https://bugs.webkit.org/show_bug.cgi?id=171265
2233
2234         Reviewed by Saam Barati.
2235
2236         * Scripts/run-jsc-stress-tests:
2237         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
2238
2239 2017-06-19  Zalan Bujtas  <zalan@apple.com>
2240
2241         Opening certain mails brings up a mail that grows indefinitely.
2242         https://bugs.webkit.org/show_bug.cgi?id=173562
2243         <rdar://problem/32766579>
2244
2245         Reviewed by Tim Horton.
2246
2247         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2248         (TEST):
2249
2250 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2251
2252         [iOS DnD] Support .zip archives for file uploads via drag and drop
2253         https://bugs.webkit.org/show_bug.cgi?id=173511
2254         <rdar://problem/32521025>
2255
2256         Reviewed by Tim Horton.
2257
2258         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
2259         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
2260
2261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2262         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
2263         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2264         (testZIPArchive):
2265         (TestWebKitAPI::TEST):
2266
2267 2017-06-18  Darin Adler  <darin@apple.com>
2268
2269         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
2270         https://bugs.webkit.org/show_bug.cgi?id=173526
2271
2272         Reviewed by Sam Weinig.
2273
2274         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
2275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2276
2277         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
2278         tests for assignment before destruction ones.
2279
2280         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
2281         as a function, so it can be used in WTF::Function tests.
2282
2283         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
2284         Added tests for swap and for assignment before deref.
2285
2286         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
2287         to inline everything. Also removed the unnecessary clearing of the log every time
2288         the DerivedRefLogger constructor is called.
2289         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
2290
2291         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
2292         Added tests for assignment before deref and similar for releaseNonNull.
2293
2294 2017-06-19  Sam Weinig  <sam@webkit.org>
2295
2296         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
2297         https://bugs.webkit.org/show_bug.cgi?id=173513
2298
2299         Reviewed by Alex Christensen.
2300
2301         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2302         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2303         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
2304
2305 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
2306
2307         [Win] fast/dom/assign-to-window-status.html is flaky.
2308         https://bugs.webkit.org/show_bug.cgi?id=173512
2309
2310         Reviewed by Alex Christensen.
2311
2312         We should not dump status callbacks when test is done.
2313
2314         * DumpRenderTree/win/UIDelegate.cpp:
2315         (UIDelegate::setStatusText):
2316
2317 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2318
2319         [WPE][JHBuild] Update WPEBackend-mesa
2320         https://bugs.webkit.org/show_bug.cgi?id=173433
2321
2322         Unreviewed.
2323
2324         Update WPEBackend-mesa back (like it was done originally in r218344)
2325         after fixing the issue with the DISPLAY environment variables that
2326         caused the crashes.
2327
2328         * wpe/jhbuild.modules:
2329
2330 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2331
2332         Rename unit test file after r218482
2333         https://bugs.webkit.org/show_bug.cgi?id=173483
2334
2335         Unreviewed.
2336
2337         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
2338
2339 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2340
2341         Unreviewed. Fix wrong style checker condition added in r218487.
2342
2343         * Scripts/webkitpy/style/checkers/cpp.py:
2344         (check_identifier_name_in_declaration):
2345
2346 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
2347
2348         Missing <functional> includes make builds fail with GCC 7.x
2349         https://bugs.webkit.org/show_bug.cgi?id=173544
2350
2351         Unreviewed gardening.
2352
2353         Fix compilation with GCC 7.
2354
2355         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2356         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2357
2358 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2359
2360         [GTK] Move GTK+ API files that could be shared to glib dirs
2361         https://bugs.webkit.org/show_bug.cgi?id=173545
2362
2363         Reviewed by Žan Doberšek.
2364
2365         Update paths of GTK+ API in watchlist and style checker.
2366
2367         * Scripts/webkitpy/common/config/watchlist:
2368         * Scripts/webkitpy/style/checker.py:
2369         * Scripts/webkitpy/style/checkers/cpp.py:
2370         (check_identifier_name_in_declaration):
2371
2372 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2373
2374         Port setup_environ_for_server should not set environment variables related with the driver.
2375         https://bugs.webkit.org/show_bug.cgi?id=173483
2376
2377         Reviewed by Carlos Garcia Campos.
2378
2379         The port setup_environ_for_server() should not set environment variables
2380         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
2381         This varibles should be only set on the driver setup_environ_for_test().
2382
2383         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
2384         into the test environment even when running the tests with a driver
2385         that is not the Xorg or Xvfb one.
2386
2387         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
2388         (Port.to.setup_environ_for_server):
2389         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
2390         (Driver._setup_environ_for_driver):
2391         * Scripts/webkitpy/port/driver_unittest.py:
2392         (DriverTest.test_setup_environ_for_test):
2393         (DriverTest):
2394         (DriverTest.test_setup_environ_base_vars):
2395         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
2396         (GtkPort.setup_environ_for_server):
2397         * Scripts/webkitpy/port/wayland_unittest.py: Added.
2398         (WaylandDriverTest):
2399         (WaylandDriverTest.make_driver):
2400         (WaylandDriverTest.make_environment):
2401         (WaylandDriverTest.test_checkdriver):
2402         (WaylandDriverTest.test_environment_needed_variables):
2403         (WaylandDriverTest.test_environment_forbidden_variables):
2404         (WaylandDriverTest.test_environment_optional_variables):
2405         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
2406         (WaylandDriver.check_driver):
2407         (WaylandDriver._setup_environ_for_test):
2408         * Scripts/webkitpy/port/xorgdriver.py:
2409         (XorgDriver.check_driver):
2410         (XorgDriver._setup_environ_for_test):
2411         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
2412         (XorgDriverTest):
2413         (XorgDriverTest.make_driver):
2414         (XorgDriverTest.make_environment):
2415         (XorgDriverTest.test_checkdriver):
2416         (XorgDriverTest.test_environment_needed_variables):
2417         (XorgDriverTest.test_environment_forbidden_variables):
2418         (XorgDriverTest.test_environment_optional_variables):
2419         * Scripts/webkitpy/port/xvfbdriver.py:
2420         (XvfbDriver._setup_environ_for_test):
2421         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2422         (XvfbDriverTest.assertDriverStartSuccessful):
2423
2424
2425 2017-05-14 Frederic Wang  <fwang@igalia.com>
2426
2427         Add heuristic to avoid flattening "fullscreen" iframes
2428         https://bugs.webkit.org/show_bug.cgi?id=171914
2429
2430         Reviewed by Simon Fraser.
2431
2432         * DumpRenderTree/mac/DumpRenderTree.mm:
2433         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
2434
2435 2017-06-18  Chris Dumez  <cdumez@apple.com>
2436
2437         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
2438         https://bugs.webkit.org/show_bug.cgi?id=173522
2439         <rdar://problem/31185739>
2440
2441         Reviewed by Darin Adler.
2442
2443         Add API test for re-entering Function's assignment operators.
2444
2445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2446         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
2447         (TestWebKitAPI::TestObject::TestObject):
2448         (TestWebKitAPI::TestObject::~TestObject):
2449         (TestWebKitAPI::TestObject::operator()):
2450         (TestWebKitAPI::TEST):
2451
2452 2017-06-16  Dan Bernstein  <mitz@apple.com>
2453
2454         [Cocoa] Some declarations have missing or incorrect availability attributes
2455         https://bugs.webkit.org/show_bug.cgi?id=173508
2456
2457         Reviewed by Tim Horton.
2458
2459         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
2460         (TestWebKitAPI::TEST): Updated for renames.
2461
2462 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2463
2464         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
2465         https://bugs.webkit.org/show_bug.cgi?id=173366
2466         <rdar://problem/32767014>
2467
2468         Reviewed by Tim Horton.
2469
2470         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
2471         change in behavior.
2472
2473         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2475         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
2476         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
2477         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
2478         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
2479         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
2480         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
2481         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
2482         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
2483         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
2484         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
2485         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
2486         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
2487         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2488         (-[MockDragDropSession initWithItems:location:window:]):
2489         (-[MockDragDropSession allowsMoveOperation]):
2490         (-[MockDragDropSession isRestrictedToDraggingApplication]):
2491         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
2492         (-[MockDragDropSession canLoadObjectsOfClass:]):
2493         (-[MockDragDropSession canLoadObjectsOfClasses:]):
2494         (-[MockDragDropSession items]):
2495         (-[MockDragDropSession setItems:]):
2496         (-[MockDragDropSession locationInView:]):
2497         (-[MockDataOperationSession initWithProviders:location:window:]):
2498         (-[MockDataOperationSession session]):
2499         (-[MockDataOperationSession isLocal]):
2500         (-[MockDataOperationSession progress]):
2501         (-[MockDataOperationSession setProgressIndicatorStyle:]):
2502         (-[MockDataOperationSession progressIndicatorStyle]):
2503         (-[MockDataOperationSession operationMask]):
2504         (-[MockDataOperationSession localDragSession]):
2505         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
2506         (-[MockDataOperationSession canCreateItemsOfClass:]):
2507         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
2508         (-[MockDataInteractionSession initWithWindow:]):
2509         (-[MockDataInteractionSession localOperationMask]):
2510         (-[MockDataInteractionSession externalOperationMask]):
2511         (-[MockDataInteractionSession session]):
2512         (-[DataInteractionSimulator _advanceProgress]):
2513
2514 2017-06-16  Alex Christensen  <achristensen@webkit.org>
2515
2516         Show punycode to user if a URL has dotless i or j followed by diacritic dot
2517         https://bugs.webkit.org/show_bug.cgi?id=173431
2518
2519         Reviewed by Darin Adler.
2520
2521         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2522         (TestWebKitAPI::TEST):
2523
2524 2017-06-16  Chris Dumez  <cdumez@apple.com>
2525
2526         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
2527         https://bugs.webkit.org/show_bug.cgi?id=173472
2528         <rdar://problem/28858817>
2529
2530         Reviewed by Brady Eidson.
2531
2532         Add API test coverage.
2533
2534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2535         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
2536         (TEST):
2537
2538 2017-06-16  Brady Eidson  <beidson@apple.com>
2539
2540         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
2541         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
2542
2543         Reviewed by Daniel Bates.
2544
2545         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2546
2547 2017-06-16  Chris Dumez  <cdumez@apple.com>
2548
2549         DRT fails to reset page visibility between tests
2550         https://bugs.webkit.org/show_bug.cgi?id=173485
2551
2552         Reviewed by Alexey Proskuryakov.
2553
2554         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
2555         Fix this to address flakiness.
2556
2557         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
2558         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
2559         The test became flaky without the DRT change and was no longer flaky with the DRT
2560         change.
2561
2562         WebKitTestRunner already does this.
2563
2564         * DumpRenderTree/mac/DumpRenderTree.mm:
2565         (resetWebViewToConsistentStateBeforeTesting):
2566
2567 2017-06-16  Alex Christensen  <achristensen@webkit.org>
2568
2569         Implement basic authentication in MiniBrowser
2570         https://bugs.webkit.org/show_bug.cgi?id=173443
2571
2572         Reviewed by Tim Horton.
2573
2574         * MiniBrowser/mac/WK2BrowserWindowController.m:
2575         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
2576
2577 2017-06-16  Jer Noble  <jer.noble@apple.com>
2578
2579         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
2580         https://bugs.webkit.org/show_bug.cgi?id=173398
2581         <rdar://problem/32592961>
2582
2583         Reviewed by Eric Carlson.
2584
2585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2586         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
2587         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2588         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2589         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
2590         (TestWebKitAPI::TEST):
2591         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
2592
2593 2017-06-16  Matt Lewis  <jlewis3@apple.com>
2594
2595         Unreviewed, rolling out r218375.
2596
2597         The API test MediaStreamTrackDetached is still timing out
2598         after the patch
2599
2600         Reverted changeset:
2601
2602         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
2603         reports no recording to WebKit clients"
2604         https://bugs.webkit.org/show_bug.cgi?id=173398
2605         http://trac.webkit.org/changeset/218375
2606
2607 2017-06-15  Jer Noble  <jer.noble@apple.com>
2608
2609         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
2610         https://bugs.webkit.org/show_bug.cgi?id=173398
2611         <rdar://problem/32592961>
2612
2613         Reviewed by Eric Carlson.
2614
2615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2616         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
2617         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2618         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2619         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
2620         (TestWebKitAPI::TEST):
2621         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
2622
2623 2017-06-15  Matt Lewis  <jlewis3@apple.com>
2624
2625         Unreviewed, rolling out r218365.
2626
2627         The revision caused API timeouts on all builds.
2628
2629         Reverted changeset:
2630
2631         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
2632         reports no recording to WebKit clients"
2633         https://bugs.webkit.org/show_bug.cgi?id=173398
2634         http://trac.webkit.org/changeset/218365
2635
2636 2017-06-15  Jer Noble  <jer.noble@apple.com>
2637
2638         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
2639         https://bugs.webkit.org/show_bug.cgi?id=173398
2640         <rdar://problem/32592961>
2641
2642         Reviewed by Eric Carlson.
2643
2644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2645         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
2646         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2647         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2648         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
2649         (TestWebKitAPI::TEST):
2650         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
2651
2652 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2653
2654         REGRESSION(r218344): [WPE] Thousands of layout test crashes
2655         https://bugs.webkit.org/show_bug.cgi?id=173433
2656
2657         Unreviewed.
2658
2659         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
2660
2661 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2662
2663         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
2664         https://bugs.webkit.org/show_bug.cgi?id=173061
2665
2666         Reviewed by Žan Doberšek.
2667
2668         Launch dyz <https://github.com/Igalia/dyz> with the script
2669         run-minibrowser for the wpe port. It is now built as part of the
2670         WPE dependencies with JHBuild.
2671
2672         * Scripts/run-minibrowser:
2673         * Scripts/webkitdirs.pm:
2674         (launcherPath):
2675         (launcherName):
2676         * wpe/install-dependencies: Luajit is needed for building dyz.
2677         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
2678
2679 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2680
2681         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
2682         https://bugs.webkit.org/show_bug.cgi?id=173338
2683         <rdar://problem/32777720>
2684
2685         Reviewed by Tim Horton.
2686
2687         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
2688         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
2689         these remaining items on drop.
2690
2691         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2692         (TestWebKitAPI::TEST):
2693         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2694         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2695
2696         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
2697
2698         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
2699
2700 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
2701
2702         [Win] Crash in accessibility layout test.
2703         https://bugs.webkit.org/show_bug.cgi?id=173401
2704
2705         Reviewed by Brent Fulgham.
2706
2707         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
2708         member will be automatically released when the _variant_t object goes out of scope if the vt member
2709         does not equal VT_UNKNOWN | VT_BYREF.
2710         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
2711
2712         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2713         (AccessibilityUIElement::titleUIElement):
2714
2715 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2716
2717         [GTK] Add API to allow overriding popup menus
2718         https://bugs.webkit.org/show_bug.cgi?id=172905
2719
2720         Reviewed by Michael Catanzaro.
2721
2722         Add a unit test to check the new API.
2723
2724         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2725         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
2726         (OptionMenuTest::OptionMenuTest):
2727         (OptionMenuTest::~OptionMenuTest):
2728         (OptionMenuTest::destroyMenu):
2729         (OptionMenuTest::showOptionMenuCallback):
2730         (OptionMenuTest::menuCloseCallback):
2731         (OptionMenuTest::showOptionMenu):
2732         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
2733         (OptionMenuTest::close):
2734         (OptionMenuTest::activateItem):
2735         (OptionMenuTest::selectItem):
2736         (testOptionMenuSimple):
2737         (testOptionMenuGroups):
2738         (testOptionMenuActivate):
2739         (testOptionMenuSelect):
2740         (beforeAll):
2741         (afterAll):
2742
2743 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
2744
2745         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
2746         https://bugs.webkit.org/show_bug.cgi?id=173399
2747
2748         Reviewed by Per Arne Vollan.
2749
2750         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
2751         Curl port needs to do nothing because libcurl doesn't have disk cache.
2752
2753         * DumpRenderTree/win/DumpRenderTree.cpp:
2754         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
2755         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
2756
2757 2017-06-14  Tomas Popela  <tpopela@redhat.com>
2758
2759         [GTK] integer expression expected if running Tools/gtk/install-dependencies
2760         https://bugs.webkit.org/show_bug.cgi?id=173356
2761
2762         Reviewed by Michael Catanzaro.
2763
2764         Use the correct operator to compare the strings.
2765
2766         * gtk/install-dependencies:
2767
2768 2017-06-14  Commit Queue  <commit-queue@webkit.org>
2769
2770         Unreviewed, rolling out r218285.
2771         https://bugs.webkit.org/show_bug.cgi?id=173391
2772
2773         API test fails on iOS (Requested by alexchristensen on
2774         #webkit).
2775
2776         Reverted changeset:
2777
2778         "Add SPI for immediate injection of user scripts"
2779         https://bugs.webkit.org/show_bug.cgi?id=173342
2780         http://trac.webkit.org/changeset/218285
2781
2782 2017-06-14  Chris Dumez  <cdumez@apple.com>
2783
2784         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
2785         https://bugs.webkit.org/show_bug.cgi?id=173384
2786         <rdar://problem/32723779>
2787
2788         Reviewed by Dan Bernstein.
2789
2790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2791         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
2792         Add API test coverage.
2793
2794         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2795         (TestWebKitAPI::Util::sleep):
2796         Update implementation of Util::sleep() so that we actually run the run loop.
2797         Otherwise, we don't process events while sleeping.
2798
2799 2017-06-14  Alex Christensen  <achristensen@webkit.org>
2800
2801         Add SPI for immediate injection of user scripts
2802         https://bugs.webkit.org/show_bug.cgi?id=173342
2803         <rdar://problem/29202285>
2804
2805         Reviewed by Brady Eidson.
2806
2807         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2808         (waitForMessage):
2809         (TEST):
2810
2811 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
2812
2813         Add WPE to the flakiness dashboard
2814         https://bugs.webkit.org/show_bug.cgi?id=173365
2815
2816         Reviewed by Carlos Alberto Lopez Perez.
2817
2818         * TestResultServer/static-dashboards/builders.jsonp:
2819         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2820         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2821         (resetGlobals):
2822         * TestResultServer/static-dashboards/loader_unittests.js:
2823
2824 2017-06-14  Brady Eidson  <beidson@apple.com>
2825
2826         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
2827         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
2828
2829         Reviewed by Alex Christensen.
2830
2831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2832         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
2833         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
2834         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
2835         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
2836         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
2837         (TEST):
2838
2839 2017-06-14  Tim Horton  <timothy_horton@apple.com>
2840
2841         WKContentViewEditingActions API test always fails
2842         https://bugs.webkit.org/show_bug.cgi?id=173374
2843
2844         Reviewed by Wenson Hsieh.
2845
2846         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
2847         (TEST):
2848         selectAll isn't working, because canPerformAction for selectAll returns NO
2849         if selectionIsNone (which is true in the non-contenteditable case).
2850         Instead, make use of r218180's test page, which knows how to select itself.
2851         Also, reset the pasteboard at the beginning of the test to reduce confusion
2852         (I landed the test broken because my simulator had the correct text
2853         stuck in its pasteboard).
2854
2855 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
2856
2857         Configure screen scale for running layout tests on plus devices
2858         https://bugs.webkit.org/show_bug.cgi?id=173319
2859
2860         Reviewed by Tim Horton.
2861
2862         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
2863         * DumpRenderTree/mac/DumpRenderTree.mm:
2864         (dumpRenderTree): Set screen scale to 2.0.
2865         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
2866         add _setScale for UIScreen.
2867         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
2868         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
2869         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
2870         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
2871         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
2872         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
2873         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
2874         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
2875         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
2876         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
2877
2878 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
2879
2880         Add iOS 11 support to the bot watcher's dashboard
2881         https://bugs.webkit.org/show_bug.cgi?id=173369
2882
2883         Reviewed by Lucas Forschler.
2884
2885         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
2886         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
2887         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
2888         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
2889         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2890         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2891
2892 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2893
2894         [GTK][WPE] Raise the timeout values for layout tests
2895         https://bugs.webkit.org/show_bug.cgi?id=173368
2896
2897         Reviewed by Carlos Garcia Campos.
2898
2899         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
2900         When running under valgrind a 10x multiplier is applied.
2901
2902         * Scripts/webkitpy/port/gtk.py:
2903         (GtkPort.default_timeout_ms):
2904         * Scripts/webkitpy/port/gtk_unittest.py:
2905         (GtkPortTest.test_default_timeout_ms):
2906         * Scripts/webkitpy/port/wpe.py:
2907         (WPEPort.default_timeout_ms):
2908         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
2909         (WPEPortTest):
2910         (WPEPortTest.make_port):
2911         (WPEPortTest.test_default_timeout_ms):
2912         (WPEPortTest.test_get_crash_log):
2913
2914 2017-06-14  Alex Christensen  <achristensen@webkit.org>
2915
2916         Test persistent WKHTTPCookieStorages on iOS.
2917         https://bugs.webkit.org/show_bug.cgi?id=173284
2918
2919         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2920         (TEST):
2921         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
2922
2923 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
2924
2925         [Win] DRT should not use disk cache.
2926         https://bugs.webkit.org/show_bug.cgi?id=173361
2927
2928         Reviewed by Darin Adler.
2929
2930         Like on macOS/iOS, DRT on Windows should only use memory cache.
2931
2932         * DumpRenderTree/win/DumpRenderTree.cpp:
2933         (setDefaultsToConsistentValuesForTesting):
2934         (prepareConsistentTestingEnvironment):
2935
2936 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
2937
2938         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
2939         https://bugs.webkit.org/show_bug.cgi?id=171668
2940
2941         Reviewed by Jer Noble.
2942
2943         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
2944         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
2945         Infinity when the double value passed as argument is greater than 2^64.
2946
2947         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
2948         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
2949         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
2950         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
2951         method. No behavior change for rational MediaTime.
2952
2953         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
2954         (TestWebKitAPI::TEST):
2955
2956 2017-06-13  Alex Christensen  <achristensen@webkit.org>
2957
2958         Test persistent WKHTTPCookieStorages on iOS
2959         https://bugs.webkit.org/show_bug.cgi?id=173284
2960         <rdar://problem/32260156>
2961
2962         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2963         (TEST):
2964
2965 2017-06-13  Matt Rajca  <mrajca@apple.com>
2966
2967         WebsitePolicies: let clients select specific autoplay quirks
2968         https://bugs.webkit.org/show_bug.cgi?id=173343
2969
2970         Reviewed by Alex Christensen.
2971
2972         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2973         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2974         (TEST): Updated tests.
2975
2976 2017-06-13  Daniel Bates  <dabates@apple.com>
2977
2978         Implement W3C Secure Contexts Draft Specification
2979         https://bugs.webkit.org/show_bug.cgi?id=158121
2980         <rdar://problem/26012994>
2981
2982         Reviewed by Brent Fulgham.
2983
2984         Part 4
2985
2986         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
2987         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
2988         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
2989
2990         * DumpRenderTree/TestOptions.h:
2991         * DumpRenderTree/TestOptions.mm:
2992         (TestOptions::TestOptions):
2993         * DumpRenderTree/mac/DumpRenderTree.mm:
2994         (setWebPreferencesForTestOptions):
2995         * DumpRenderTree/win/DumpRenderTree.cpp:
2996         (enableExperimentalFeatures):
2997         * WebKitTestRunner/TestController.cpp:
2998         (WTR::TestController::resetPreferencesToConsistentValues):
2999         (WTR::updateTestOptionsFromTestHeader):
3000         * WebKitTestRunner/TestOptions.h:
3001         (WTR::TestOptions::hasSameInitializationOptions):
3002
3003 2017-06-13  Alex Christensen  <achristensen@webkit.org>
3004
3005         Test persistent WKHTTPCookieStorages on iOS
3006         https://bugs.webkit.org/show_bug.cgi?id=173284
3007         <rdar://problem/32260156>
3008
3009         Reviewed by Alexey Proskuryakov.
3010
3011         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3012         (TEST):
3013
3014 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3015
3016         [GTK] Blob download doesn't work
3017         https://bugs.webkit.org/show_bug.cgi?id=172442
3018
3019         Reviewed by Carlos Alberto Lopez Perez.
3020
3021         Add a unit test to check blob downloads.
3022
3023         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3024         (testBlobDownload):
3025         (beforeAll):
3026
3027 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3028
3029         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
3030         https://bugs.webkit.org/show_bug.cgi?id=173316
3031
3032         Reviewed by Alex Christensen.
3033
3034         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
3035
3036         * gtk/manifest.txt.in:
3037
3038 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
3039
3040         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
3041         https://bugs.webkit.org/show_bug.cgi?id=173315
3042
3043         Reviewed by Darin Adler.
3044
3045         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
3046         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
3047         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
3048         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
3049         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
3050         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
3051         WKGeolocationManagerRef is not destroyed.
3052
3053         * WebKitTestRunner/GeolocationProviderMock.cpp:
3054         (WTR::GeolocationProviderMock::GeolocationProviderMock):
3055         * WebKitTestRunner/GeolocationProviderMock.h:
3056
3057 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3058
3059         Unable to paste text that was copied from a page into the universal search field
3060         https://bugs.webkit.org/show_bug.cgi?id=173293
3061         <rdar://problem/32440918>
3062
3063         Reviewed by Ryosuke Niwa.
3064
3065         Adds 2 new unit tests for copying plain and rich selected web content.
3066         See WebCore and WebKit ChangeLogs for more detail.
3067
3068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3069         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
3070         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
3071         (TestWebKitAPI::dataForPasteboardType):
3072         (TestWebKitAPI::setUpWebViewForPasteboardTests):
3073         (TestWebKitAPI::TEST):
3074
3075 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
3076
3077         AX: [ATK] Implement missing AtkRelation types
3078         https://bugs.webkit.org/show_bug.cgi?id=155494
3079
3080         Reviewed by Darin Adler.
3081
3082         Add additional methods to test ARIA properties which are exposed via
3083         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
3084
3085         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3086         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
3087         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
3088         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
3089         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
3090         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
3091         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
3092         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
3093         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3094         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3095         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
3096         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
3097         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
3098         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
3099         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
3100         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
3101         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
3102         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
3103
3104 2017-06-12  Daniel Bates  <dabates@apple.com>
3105
3106         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
3107         https://bugs.webkit.org/show_bug.cgi?id=173286
3108         <rdar://problem/32726102>
3109
3110         Reviewed by Brent Fulgham.
3111
3112         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3113         (TestWebKitAPI::TEST_F):
3114
3115 2017-06-12  Lucas Forschler  <lforschler@apple.com>
3116
3117         <rdar://problem/32683422>
3118         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
3119
3120         Reviewed by Conrad Schultz.
3121
3122         * Scripts/copy-webkitlibraries-to-product-directory:
3123
3124 2017-06-12  Tim Horton  <timothy_horton@apple.com>
3125
3126         [iOS] Cmd-C doesn't copy text from WKWebView
3127         https://bugs.webkit.org/show_bug.cgi?id=173277
3128         <rdar://problem/32396742>
3129
3130         Reviewed by Dan Bernstein.
3131
3132         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3133         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
3134         Add a test ensuring that -copy on WKContentView will cause text to be copied.
3135
3136 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
3137
3138         [WebCrypto] Remove experimental feature flag of SubtleCrypto
3139         https://bugs.webkit.org/show_bug.cgi?id=173197
3140         <rdar://problem/32688148>
3141
3142         Reviewed by Brent Fulgham.
3143
3144         * DumpRenderTree/mac/DumpRenderTree.mm:
3145         (enableExperimentalFeatures):
3146         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3147         (WTR::InjectedBundle::beginTesting):
3148         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3149         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
3150         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3151
3152 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3153
3154         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
3155         https://bugs.webkit.org/show_bug.cgi?id=173238
3156         <rdar://problem/31943370>
3157
3158         Reviewed by Ryosuke Niwa and Tim Horton.
3159
3160         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
3161         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
3162         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
3163
3164         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3165         (TestWebKitAPI::TEST):
3166         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3167         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3168         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
3169         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
3170
3171 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3172
3173         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
3174         https://bugs.webkit.org/show_bug.cgi?id=173225
3175         <rdar://problem/32713144>
3176
3177         Reviewed by Tim Horton.
3178
3179         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
3180         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
3181
3182         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3183         (TestWebKitAPI::TEST):
3184
3185 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
3186
3187         Return correct process names for iOS on-device testing
3188         https://bugs.webkit.org/show_bug.cgi?id=173263
3189
3190         Reviewed by Alex Christensen.
3191
3192         When running tests on iOS devices, process names do not end with '.Development'
3193         as they do on Mac and iOS simulator.
3194
3195         * WebKitTestRunner/TestController.cpp:
3196         (WTR::TestController::webProcessName): Return correct process name without '.Development'
3197         for iOS on-device testing.
3198         (WTR::TestController::networkProcessName): Ditto.
3199         (WTR::TestController::databaseProcessName): Ditto.
3200
3201 2017-06-12  Chris Dumez  <cdumez@apple.com>
3202
3203         Regression(r217867): Legacy SessionHistoryEntryData format should not change
3204         https://bugs.webkit.org/show_bug.cgi?id=173267
3205         <rdar://problem/32701257>
3206
3207         Reviewed by Simon Fraser.
3208
3209         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
3210         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
3211         though as this covers the crash that r217867 was fixing.
3212
3213         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
3214         (TestWebKitAPI::createSessionStateData):
3215         (TestWebKitAPI::TEST):
3216         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
3217
3218 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3219
3220         [GTK] Stop dismissing menus attached to the web view for every injected event
3221         https://bugs.webkit.org/show_bug.cgi?id=172708
3222
3223         Reviewed by Alex Christensen.
3224
3225         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
3226         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
3227         events while the menu is open.
3228
3229         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3230         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
3231         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3232         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
3233
3234 2017-06-12  Miguel Gomez  <magomez@igalia.com>
3235
3236         [GTK][WPE] Enable GStreamer GL on development builds
3237         https://bugs.webkit.org/show_bug.cgi?id=173248
3238
3239         Enable GStreamer GL for GTK and WPE.
3240
3241         Reviewed by Carlos Garcia Campos.
3242
3243         * Scripts/webkitperl/FeatureList.pm:
3244
3245 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3246
3247         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
3248
3249         Notifications are no longer cleared on page navigation.
3250
3251         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3252         (testWebViewNotification):
3253
3254 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3255
3256         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
3257
3258         DBus interface and object path names were updated in r217831.
3259
3260         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
3261
3262 2017-06-10  Dan Bernstein  <mitz@apple.com>
3263
3264         Reverted r218056 because it made the IDE reindex constantly.
3265
3266         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3267         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3268         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
3269         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3270         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
3271         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3272         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3273         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3274
3275 2017-06-10  Dan Bernstein  <mitz@apple.com>
3276
3277         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
3278         https://bugs.webkit.org/show_bug.cgi?id=173223
3279
3280         Reviewed by Sam Weinig.
3281
3282         The rebuilds were happening due to a difference in the compiler options that the IDE and
3283         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
3284         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
3285         specify an appropriate path in CLANG_INDEX_STORE_PATH.
3286
3287         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3288         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3289         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
3290         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3291         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
3292         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3293         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3294         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3295
3296 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
3297
3298         webkitpy: Reduce polling in ServerProcess
3299         https://bugs.webkit.org/show_bug.cgi?id=173116
3300
3301         Reviewed by Ryosuke Niwa.
3302
3303         We should be smarter about polling. We do not need to poll every time a line is read from
3304         stdout and stderr since lines are usually read from cached data. We should only poll
3305         when extracting that cached data from stdout and stderr.
3306
3307         * Scripts/webkitpy/port/driver.py:
3308         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
3309         and on ServerProcess to poll the process if not data is available in stdout and stderr.
3310         * Scripts/webkitpy/port/driver_unittest.py:
3311         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
3312         ServerProcess.
3313         * Scripts/webkitpy/port/server_process.py:
3314         (ServerProcess._read): Allow for data to be read from _output even if the process has
3315         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
3316         * Scripts/webkitpy/port/server_process_mock.py:
3317         (MockServerProcess): Add number_of_times_polled.
3318         (MockServerProcess.poll): Increment number_of_times_polled.
3319         (MockServerProcess.has_crashed): Poll before returning crash state.
3320         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
3321         just like a ServerProcess would.
3322         (MockServerProcess.read_stdout): Ditto.
3323         * Scripts/webkitpy/port/server_process_unittest.py:
3324         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
3325         process from ending before stdout and stderr are read. This is the reason this test was flakey.
3326         (TestServerProcess):
3327         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
3328         the processes is polled.
3329         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
3330         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
3331
3332 2017-06-10  Andy Estes  <aestes@apple.com>
3333
3334         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
3335         https://bugs.webkit.org/show_bug.cgi?id=173190
3336         <rdar://problem/31360659>
3337
3338         Reviewed by Brady Eidson.
3339         
3340         Added a release assert that tries to create a proper test failure if the web process crashes.
3341
3342         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
3343         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
3344
3345 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3346
3347         [iOS DnD] Add a hook to perform two-step drops in editable content
3348         https://bugs.webkit.org/show_bug.cgi?id=172992
3349         <rdar://problem/32590174>
3350
3351         Reviewed by Tim Horton.
3352
3353         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
3354         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
3355                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
3356
3357         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
3358         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3359         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
3360
3361         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
3362         be overridden. Currently, this is overridden to just return true.
3363
3364         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3365         (TestWebKitAPI::TEST):
3366         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3367         (WTR::InjectedBundlePage::InjectedBundlePage):
3368
3369 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
3370
3371         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
3372         https://bugs.webkit.org/show_bug.cgi?id=173103
3373
3374         Reviewed by Xabier Rodriguez-Calvar.
3375
3376         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
3377         when building the WPE port through build-webkit.
3378
3379 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
3380
3381         [WPE] Enable MEDIA_SOURCE for build-webkit builds
3382         https://bugs.webkit.org/show_bug.cgi?id=173136
3383
3384         Reviewed by Xabier Rodriguez-Calvar.
3385
3386         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
3387
3388 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3389
3390         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
3391         https://bugs.webkit.org/show_bug.cgi?id=173098
3392
3393         Reviewed by Žan Doberšek.
3394
3395         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
3396         assuming that all tests containing forms define ids for the form elements like
3397         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
3398
3399         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3400         (formControlsAssociatedCallback):
3401
3402 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
3403
3404         webkitpy: Run sample/spindump on iOS devices
3405         https://bugs.webkit.org/show_bug.cgi?id=171881
3406         <rdar://problem/32084602>
3407
3408         Reviewed by Daniel Bates.
3409
3410         * Scripts/webkitpy/port/darwin.py:
3411         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
3412         requires sudo to run spindump.
3413         * Scripts/webkitpy/port/ios_device.py:
3414         (IOSDevicePort.look_for_new_samples): Deleted.
3415         (IOSDevicePort.sample_process): Deleted.
3416         * Scripts/webkitpy/port/ios_device_unittest.py:
3417         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
3418         (IOSDeviceTest.test_spindump):
3419         (IOSDeviceTest.test_sample_process):
3420         (IOSDeviceTest.test_sample_process_exception):
3421         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3422         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
3423
3424 2017-06-08  Keith Miller  <keith_miller@apple.com>
3425
3426         WebAssembly: We should only create wrappers for functions that can be exported
3427         https://bugs.webkit.org/show_bug.cgi?id=173088
3428
3429         Reviewed by Saam Barati.
3430
3431         Add quick mode for wasm tests.
3432
3433         * Scripts/run-jsc-stress-tests:
3434
3435 2017-06-08  Darin Adler  <darin@apple.com>
3436
3437         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
3438         https://bugs.webkit.org/show_bug.cgi?id=173106
3439
3440         Reviewed by Sam Weinig.
3441
3442         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
3443         destroyed last.
3444         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
3445         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
3446
3447 2017-06-07  Dan Bernstein  <mitz@apple.com>
3448
3449         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
3450         https://bugs.webkit.org/show_bug.cgi?id=173086
3451
3452         Reviewed by Andy Estes.
3453
3454         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
3455         (TEST):
3456
3457 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
3458
3459         Add High Sierra support to WebKit tools
3460         https://bugs.webkit.org/show_bug.cgi?id=173080
3461
3462         Rubber-stamped by Daniel Bates.
3463
3464         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
3465         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
3466         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3467         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3468         Added dashboard support.
3469
3470         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3471         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3472         Trigger the right build queues on check-in.
3473
3474         * Scripts/webkitpy/common/system/platforminfo.py:
3475         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3476         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3477         * Scripts/webkitpy/port/mac.py:
3478         * Scripts/webkitpy/port/mac_unittest.py:
3479         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3480         Added cases for Sierra, and updated tests for new baseline search paths.
3481
3482 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
3483
3484         Unreviewed, rolling out r217902.
3485
3486         This change appears to have caused imported/w3c/web-platform-
3487         tests/fetch/api/cors tests to fail on El Capitan.
3488
3489         Reverted changeset:
3490
3491         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
3492         https://bugs.webkit.org/show_bug.cgi?id=172930
3493         http://trac.webkit.org/changeset/217902
3494
3495 2017-06-07  Daniel Bates  <dabates@apple.com>
3496
3497         Teach run-webkit-tests how to run HTTPS Web Platform Tests
3498         https://bugs.webkit.org/show_bug.cgi?id=172930
3499         <rdar://problem/32570201>
3500
3501         Reviewed by Youenn Fablet.
3502
3503         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
3504         that is conditioned on the page being delivered over a secure protocol. One example of such
3505         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
3506
3507         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
3508         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
3509         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
3510
3511         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3512         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
3513         to the Web Platform Tests HTTPS server.
3514         * Scripts/webkitpy/port/base.py:
3515         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
3516         * Scripts/webkitpy/port/driver.py:
3517         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
3518         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
3519         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
3520         indicate that they should be considered private instance variables.
3521         (Driver.is_web_platform_test): Update code for renamed instance variables.
3522         (Driver):
3523         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
3524         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
3525         determine the base URL to use to access the test.
3526         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
3527         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
3528
3529 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
3530
3531         Support removal of authentication data through the Website data store API.
3532         https://bugs.webkit.org/show_bug.cgi?id=171217
3533
3534         Reviewed by Brady Eidson.
3535
3536         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3537         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3538         (WTR::InjectedBundle::didReceiveMessageToPage):
3539         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3540         (WTR::TestRunner::removeAllSessionCredentials):
3541         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
3542         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3543         * WebKitTestRunner/TestController.h:
3544         * WebKitTestRunner/TestInvocation.cpp:
3545         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3546         (WTR::TestInvocation::didRemoveAllSessionCredentials):
3547         * WebKitTestRunner/TestInvocation.h:
3548         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3549         (WTR::TestController::removeAllSessionCredentials):
3550
3551 2017-06-07  Charlie Turner  <cturner@igalia.com>
3552
3553         Add Charlie Turner as contributor
3554         https://bugs.webkit.org/show_bug.cgi?id=173055
3555
3556         Reviewed by Carlos Alberto Lopez Perez.
3557
3558         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
3559         of webkit-patch upload, which reordered some fields and removed a newline.
3560
3561         * Scripts/webkitpy/common/config/contributors.json:
3562
3563 2017-06-06  Chris Dumez  <cdumez@apple.com>
3564
3565         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
3566         https://bugs.webkit.org/show_bug.cgi?id=173033
3567         <rdar://problem/32591099>
3568
3569         Reviewed by Simon Fraser.
3570
3571         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
3572         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
3573
3574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3575         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
3576         (TestWebKitAPI::didFinishLoadForFrame):
3577         (TestWebKitAPI::setPageLoaderClient):
3578         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
3579         (TestWebKitAPI::TEST):
3580
3581 2017-06-06  Andy Estes  <aestes@apple.com>
3582
3583         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
3584         https://bugs.webkit.org/show_bug.cgi?id=172849
3585         <rdar://problem/32567454>
3586
3587         Reviewed by Darin Adler.
3588
3589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3590         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
3591         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3592         (TestWebKitAPI::TEST):
3593
3594 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
3595
3596         [preload] Conditional support for media preloading and align media `as` values.
3597         https://bugs.webkit.org/show_bug.cgi?id=172501
3598
3599         Reviewed by Dean Jackson.
3600
3601         Turn on media preloading preference for tests.
3602
3603         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
3604         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
3605         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
3606
3607 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
3608
3609         webkitpy: Return correct process names from SimulatorProcess
3610         https://bugs.webkit.org/show_bug.cgi?id=172940
3611
3612         Reviewed by Aakash Jain.
3613
3614         * Scripts/webkitpy/port/darwin.py:
3615         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
3616         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
3617         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
3618         * Scripts/webkitpy/port/driver.py:
3619         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
3620         _server_process.name() will not return the correct process name for iOS.
3621         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
3622         (Driver._read_block): Ditto.
3623         * Scripts/webkitpy/port/driver_unittest.py:
3624         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
3625         process_name() instead of name().
3626         * Scripts/webkitpy/port/server_process.py:
3627         (ServerProcess._start): Use process_name() instead of name().
3628         (ServerProcess.stop): Ditto.
3629         (ServerProcess.name): Deleted.
3630         * Scripts/webkitpy/port/simulator_process.py:
3631         (SimulatorProcess.process_name): Check the provided bundle for the process name.
3632
3633 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
3634
3635         test-webkitpy: stop forking unsafely from within a spawned process
3636         https://bugs.webkit.org/show_bug.cgi?id=172774
3637
3638         Reviewed by Darin Adler.
3639
3640         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3641         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
3642         it's going to be used.
3643         (Builder.force_build):
3644
3645 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
3646
3647         webkitpy: Process crash-logs for iOS devices
3648         https://bugs.webkit.org/show_bug.cgi?id=171976
3649         <rdar://problem/32134551>
3650
3651         Reviewed by David Kilzer.
3652
3653         When running layout tests on an iOS device, crash logs should be processed.
3654         Implement crash log searching and parsing for iOS devices.
3655
3656         * Scripts/webkitpy/common/system/crashlogs.py:
3657         (CrashLogs): Moved process regular expression for Darwin to class variable.
3658         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
3659         (CrashLogs.find_newest_log): Add iOS as a potential platform.
3660         (CrashLogs.find_all_logs): Ditto.
3661         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
3662         Do not assume that a Darwin crash log starts with the process.
3663         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
3664         shared code for parsing Darwin crash logs.
3665         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
3666         object so that crash logs already on the system before testing are not parsed.
3667         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
3668         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
3669         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
3670         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3671         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
3672         * Scripts/webkitpy/common/system/systemhost.py:
3673         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
3674         systems is just the crashlog, use this behavior by default.
3675         * Scripts/webkitpy/common/system/systemhost_mock.py:
3676         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
3677         systems is just the crashlog, use this behavior by default.
3678         * Scripts/webkitpy/port/apple.py:
3679         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
3680         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
3681         the system before testing begins
3682         * Scripts/webkitpy/port/base.py:
3683         (Port._get_crash_log): Pass optional target host when getting crash logs.
3684         * Scripts/webkitpy/port/darwin.py:
3685         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
3686         CrashLogs object.
3687         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
3688         logs to be skipped to CrashLogs object.
3689         * Scripts/webkitpy/port/darwin_testcase.py:
3690         (DarwinTest.test_get_crash_log): Removed unused local function.
3691         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
3692         * Scripts/webkitpy/port/device.py:
3693         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
3694         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
3695         * Scripts/webkitpy/port/driver.py:
3696         (Driver._get_crash_log): Pass optional target host when getting crash logs.
3697         * Scripts/webkitpy/port/gtk.py:
3698         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
3699         * Scripts/webkitpy/port/ios.py: Ditto.
3700         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
3701         to be skipped for each host.
3702         * Scripts/webkitpy/port/ios_device.py:
3703         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
3704         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
3705         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
3706         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
3707         host is specified. Else, search all connected devices for the specified crash-log.
3708         (IOSDevicePort.look_for_new_crash_logs): Deleted.
3709         * Scripts/webkitpy/port/ios_device_unittest.py:
3710         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
3711         (IOSDeviceTest.test_get_crash_log): Ditto.
3712         * Scripts/webkitpy/port/simulator_process.py:
3713         (SimulatorProcess.process_name): Check the provided bundle for the process name.
3714         * Scripts/webkitpy/port/win.py:
3715         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
3716         logs to be skipped to CrashLogs object.
3717         * Scripts/webkitpy/port/wpe.py:
3718         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
3719
3720 2017-06-06  David Kilzer  <ddkilzer@apple.com>
3721
3722         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
3723         <https://webkit.org/b/172804>
3724
3725         Reviewed by Darin Adler.
3726
3727         WTF_ATTRIBUTE_PRINTF() only works outside the current
3728         compilation unit if it's on the declaration, not the
3729         implementation, of a function or class method.
3730
3731         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3732         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3733         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3734         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3735         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
3736         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3737         - Remove redundant CRASH() macro definition.  Use the one from
3738           <wtf/Assertions.h> instead.
3739
3740 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
3741
3742         Move Resource Timing / User Timing from experimental features into main preferences
3743         https://bugs.webkit.org/show_bug.cgi?id=172950
3744
3745         Reviewed by Darin Adler.
3746
3747         * DumpRenderTree/mac/DumpRenderTree.mm:
3748         (enableExperimentalFeatures):
3749         (resetWebPreferencesToConsistentValues):
3750         * DumpRenderTree/win/DumpRenderTree.cpp:
3751         (enableExperimentalFeatures):
3752         (resetWebPreferencesToConsistentValues):
3753         * WebKitTestRunner/TestController.cpp:
3754         (WTR::TestController::resetPreferencesToConsistentValues):
3755         Move out no longer experimental features to the main list.
3756
3757 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3758
3759         [WPE] Add an install-dependencies script
3760         https://bugs.webkit.org/show_bug.cgi?id=172948
3761
3762         Reviewed by Žan Doberšek.
3763
3764         It is based on the gtk/install-dependencies script.
3765         Includes support for Debian based distrubutions, Fedora and Arch.
3766         It has been tested on a minimal Debian 9 chroot.
3767
3768         * wpe/install-dependencies: Added.
3769
3770 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3771
3772         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
3773         https://bugs.webkit.org/show_bug.cgi?id=172891
3774         <rdar://problem/32204540>
3775
3776         Reviewed by Darin Adler.
3777
3778         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
3779         contenteditable. See WebCore ChangeLog for more details.
3780
3781         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3782         (TestWebKitAPI::TEST):
3783
3784 2017-06-05  Daniel Bates  <dabates@apple.com>
3785
3786         webkitpy: Abstract Executive class
3787         https://bugs.webkit.org/show_bug.cgi?id=172928
3788         <rdar://problem/32569531>
3789
3790         Reviewed by Ryosuke Niwa.
3791
3792         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
3793         This will make it straightforward to create additional derived classes that
3794         adhere to the same interface, say for iOS on-device testing.
3795
3796         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
3797         (AbstractExecutive):
3798         (AbstractExecutive.run_and_throw_if_fail):
3799         (AbstractExecutive.cpu_count):
3800         (AbstractExecutive.interpreter_for_script):
3801         (AbstractExecutive.shell_command_for_script):
3802         (AbstractExecutive.kill_process):
3803         (AbstractExecutive.check_running_pid):
3804         (AbstractExecutive.running_pids):
3805         (AbstractExecutive.wait_newest):
3806         (AbstractExecutive.wait_limited):
3807         (AbstractExecutive.interrupt):
3808         (AbstractExecutive.default_error_handler):
3809         (AbstractExecutive.ignore_error):
3810         (AbstractExecutive._stringify_args):
3811         (AbstractExecutive.command_for_printing):
3812         (AbstractExecutive.run_command):
3813         (AbstractExecutive.popen):
3814         (AbstractExecutive.run_in_parallel):
3815         * Scripts/webkitpy/common/system/executive.py:
3816         (Executive):
3817         (Executive.cpu_count):
3818         (Executive.running_pids):
3819         (Executive.kill_all):
3820         (Executive._compute_stdin):
3821         (Executive.interpreter_for_script): Deleted.
3822         (Executive.shell_command_for_script): Deleted.
3823         (Executive.wait_newest): Deleted.
3824         (Executive.wait_limited): Deleted.
3825         (Executive.default_error_handler): Deleted.
3826         (Executive.ignore_error): Deleted.
3827         (Executive.command_for_printing): Deleted.
3828
3829 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
3830
3831         webkitpy: Add iOS to platform
3832         https://bugs.webkit.org/show_bug.cgi?id=172931
3833
3834         Reviewed by Daniel Bates.
3835
3836         * Scripts/webkitpy/common/system/platforminfo.py:
3837         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
3838         (PlatformInfo.is_ios): Added.
3839         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
3840         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3841         (MockPlatformInfo.is_ios): Added.
3842
3843 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3844
3845         [WPE][JHBuild] Switch github repository from git:// to https://
3846         https://bugs.webkit.org/show_bug.cgi?id=172921
3847
3848         Reviewed by Alex Christensen.
3849
3850         * wpe/jhbuild.modules:
3851
3852 2017-06-05  Tim Horton  <timothy_horton@apple.com>
3853
3854         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
3855         https://bugs.webkit.org/show_bug.cgi?id=172887
3856         <rdar://problem/32546061>
3857
3858         Reviewed by Sam Weinig.
3859
3860         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3861         (WTR::UIScriptController::applyAutocorrection):
3862         applyAutocorrection can call its completion handler synchronously,
3863         which makes UIScriptController unhappy (see bug 172884).
3864
3865 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
3866
3867         webkitpy: Add contextmanager to disable logging for a block
3868         https://bugs.webkit.org/show_bug.cgi?id=172876
3869
3870         Reviewed by Daniel Bates.
3871
3872         Add a context manager which will use an OutputCapture object to capture logging
3873         in a block and hold it in a variable.
3874
3875         * Scripts/webkitpy/common/system/outputcapture.py:
3876         (OutputCaptureScope):
3877         (OutputCaptureScope.__init__): Construct with OutputCapture object.
3878         (OutputCaptureScope.__enter__): Begin capturing output. 
3879         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
3880         output and retain the resulting log.
3881         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
3882         (OutputCaptureTest.test_output_capture_scope): Added.
3883
3884 2017-06-02  Zalan Bujtas  <zalan@apple.com>
3885
3886         Cleanup FrameView::autoSizeIfEnabled.
3887         https://bugs.webkit.org/show_bug.cgi?id=172889
3888         <rdar://problem/32550783>
3889
3890         Reviewed by Tim Horton.
3891
3892         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3893         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
3894         (TEST):
3895
3896 2017-06-02  Chris Dumez  <cdumez@apple.com>
3897
3898         ResourceLoadStatistics are not using unique paths during test runs
3899         https://bugs.webkit.org/show_bug.cgi?id=172861
3900         <rdar://problem/32442251>
3901
3902         Reviewed by Darin Adler.
3903
3904         Make sure WebKitTestRunner sets a temporary path for saving resource
3905         load statistics.
3906
3907         * WebKitTestRunner/TestController.cpp:
3908         (WTR::TestController::generateContextConfiguration):
3909
3910 2017-06-02  Brady Eidson  <beidson@apple.com>
3911
3912         Prevent scheme handlers from handling all built-in URL schemes.
3913         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
3914
3915         Reviewed by Andy Estes.
3916
3917         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3918
3919 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
3920
3921         [JSCOnly] Build static jsc.exe on Windows
3922         https://bugs.webkit.org/show_bug.cgi?id=172833
3923
3924         Reviewed by Konstantin Tokarev.
3925
3926         * CMakeLists.txt:
3927         * Scripts/build-jsc:
3928
3929 2017-06-02  Zalan Bujtas  <zalan@apple.com>
3930
3931         Disable ViewportSizeForViewportUnits tests on iOS.
3932         https://bugs.webkit.org/show_bug.cgi?id=172872
3933
3934         Reviewed by Tim Horton.
3935
3936         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
3937
3938 2017-06-02  Zalan Bujtas  <zalan@apple.com>
3939
3940         Allow clients to override viewport size for CSS viewport units.
3941         https://bugs.webkit.org/show_bug.cgi?id=172838
3942         <rdar://problem/32523441>
3943
3944         Reviewed by Tim Horton.
3945
3946         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3947         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
3948         (TEST):
3949
3950 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
3951
3952         Get <chrono> out of StdLibExtras.h
3953         https://bugs.webkit.org/show_bug.cgi?id=172744
3954
3955         Reviewed by Zalan Bujtas.
3956
3957         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3958
3959 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
3960
3961         [WPE] Enable SUBTLE_CRYPTO
3962         https://bugs.webkit.org/show_bug.cgi?id=172756
3963
3964         Reviewed by Michael Catanzaro.
3965
3966         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
3967         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
3968         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
3969         exhausting entropy when running the crypto layout tests.
3970
3971 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3972
3973         [GTK] Bump GTK+ and its dependencies in jhbuild
3974         https://bugs.webkit.org/show_bug.cgi?id=171918
3975
3976         Reviewed by Carlos Alberto Lopez Perez.
3977
3978         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3979         (WTR::initializeGtkSettings):
3980         * gtk/jhbuild.modules:
3981         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
3982         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
3983
3984 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3985
3986         [GTK] Bump wayland and weston in jhbuild
3987         https://bugs.webkit.org/show_bug.cgi?id=171921
3988
3989         Reviewed by Carlos Alberto Lopez Perez.
3990
3991         * gtk/jhbuild.modules:
3992         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
3993
3994 2017-06-01  Andy Estes  <aestes@apple.com>
3995
3996         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
3997         https://bugs.webkit.org/show_bug.cgi?id=172828
3998
3999         Reviewed by Beth Dakin.
4000
4001         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4002
4003 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
4004
4005         webkitpy: Remove unneeded simulator teardown
4006         https://bugs.webkit.org/show_bug.cgi?id=171891
4007
4008         Reviewed by Aakash Jain.
4009
4010         * Scripts/webkitpy/port/ios_simulator.py:
4011         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
4012         for communication between Python and WebKitTestRunner/DumpRenderTree.
4013
4014 2017-06-01  Keith Miller  <keith_miller@apple.com>
4015
4016         Undo rollout in r217638 with bug fix
4017         https://bugs.webkit.org/show_bug.cgi?id=172824
4018
4019         Unreviewed, reland patch with unused set_state code removed.
4020
4021         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
4022         (runThreadMessageTest):
4023         (TEST):
4024
4025 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
4026
4027         webkitpy: Do not send 0 or -1 as a pid to kill_process
4028         https://bugs.webkit.org/show_bug.cgi?id=172818
4029
4030         Reviewed by Darin Adler.
4031
4032         Sending a signal to process 0 will result in all processes in the group receiving 
4033         the signal. Sending a signal to process -1 will result in all non-system processes
4034         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
4035         should consider these cases
4036
4037         * Scripts/webkitpy/common/system/executive.py:
4038         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
4039         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
4040         never be running, although os.kill may succeed.
4041         * Scripts/webkitpy/port/simulator_process.py:
4042         (SimulatorProcess.stop): Do not kill process if it is undefined.
4043
4044 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
4045
4046         JSC EWS bot does not run on WTF only patches
4047         https://bugs.webkit.org/show_bug.cgi?id=172777
4048         rdar://problem/32495975
4049
4050         Reviewed by Aakash Jain.
4051
4052         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
4053         (CheckPatchRelevance): Add a missing comma.
4054
4055 2017-05-31  Commit Queue  <commit-queue@webkit.org>
4056
4057         Unreviewed, rolling out r217611 and r217631.
4058         https://bugs.webkit.org/show_bug.cgi?id=172785
4059
4060         "caused wasm-hashset-many.html to become flaky." (Requested by
4061         keith_miller on #webkit).
4062
4063         Reverted changesets:
4064
4065         "Reland r216808, underlying lldb bug has been fixed."
4066         https://bugs.webkit.org/show_bug.cgi?id=172759
4067         http://trac.webkit.org/changeset/217611
4068
4069         "Use dispatch queues for mach exceptions"
4070         https://bugs.webkit.org/show_bug.cgi?id=172775
4071         http://trac.webkit.org/changeset/217631
4072
4073 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
4074
4075         EWS bots should reboot themselves more frequently
4076         https://bugs.webkit.org/show_bug.cgi?id=172402
4077
4078         Reviewed by Alexey Proskuryakov.
4079
4080         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
4081
4082         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
4083
4084 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
4085
4086         Reallocate hardware for iOS bots.
4087         https://bugs.webkit.org/show_bug.cgi?id=172657
4088
4089         Reviewed by Alexey Proskuryakov.
4090
4091         * BuildSlaveSupport/build.webkit.org-config/config.json:
4092
4093 2017-05-31  Andy Estes  <aestes@apple.com>
4094
4095         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
4096         https://bugs.webkit.org/show_bug.cgi?id=172366
4097
4098         Reviewed by Daniel Bates.
4099
4100         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4101
4102 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
4103
4104         Unreviewed, add Jiewen Tan as a reviewer
4105
4106         * Scripts/webkitpy/common/config/contributors.json:
4107
4108 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
4109
4110         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
4111         https://bugs.webkit.org/show_bug.cgi?id=172770
4112
4113         Reviewed by Michael Catanzaro.
4114
4115         * MiniBrowser/gtk/BrowserWindow.c:
4116         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
4117         which caused the body of the if-clause to be accidentally empty.
4118
4119 2017-05-31  Keith Miller  <keith_miller@apple.com>
4120
4121         Reland r216808, underlying lldb bug has been fixed.
4122         https://bugs.webkit.org/show_bug.cgi?id=172759
4123
4124         Unreviewed, relanding old patch. See: rdar://problem/31183352
4125
4126         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
4127         (runThreadMessageTest):
4128         (TEST):
4129
4130 2017-05-31  Matt Lewis  <jlewis3@apple.com>
4131
4132         Unreviewed, rolling out r217603.
4133
4134         This patch broke the internal builds.
4135
4136         Reverted changeset:
4137
4138         "Get <chrono> out of StdLibExtras.h"
4139         https://bugs.webkit.org/show_bug.cgi?id=172744
4140         http://trac.webkit.org/changeset/217603
4141
4142 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
4143
4144         Make ResourceLoadStatistics testing more reliable
4145         https://bugs.webkit.org/show_bug.cgi?id=172730
4146         <rdar://problem/32028373>
4147
4148         Reviewed by Andy Estes.
4149
4150         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
4151         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
4152
4153         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4154         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
4155
4156 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4157
4158         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
4159         https://bugs.webkit.org/show_bug.cgi?id=172757
4160
4161         Reviewed by Xabier Rodriguez-Calvar.
4162
4163         When needed, add the jhbuild wrapper at the beginning of the array
4164         that will be invoked to execute the run-jsc-stress-test or testapi
4165         commands.
4166
4167         * Scripts/run-javascriptcore-tests:
4168         (runJSCStressTests):
4169         * Scripts/webkitdirs.pm:
4170         (shouldUseJhbuild):
4171
4172 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
4173
4174         Get <chrono> out of StdLibExtras.h
4175         https://bugs.webkit.org/show_bug.cgi?id=172744
4176
4177         Reviewed by Saam Barati.
4178
4179         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
4180
4181 2017-05-30  Tim Horton  <timothy_horton@apple.com>
4182
4183         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
4184         https://bugs.webkit.org/show_bug.cgi?id=172735
4185         <rdar://problem/32015977>
4186
4187         Reviewed by Enrica Casucci.
4188
4189         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4190         (WTR::UIScriptController::applyAutocorrection):
4191         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4192         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4193         (WTR::UIScriptController::applyAutocorrection):
4194         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4195         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4196         (WTR::UIScriptController::applyAutocorrection):
4197         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
4198         because I don't know how to tap the button in the autocorrection bar from a test.
4199
4200 2017-05-30  Daniel Bates  <dabates@apple.com>
4201
4202         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
4203         https://bugs.webkit.org/show_bug.cgi?id=172671
4204
4205         Reviewed by Alex Christensen.
4206
4207         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
4208         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
4209
4210         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
4211         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
4212         to trigger a navigation to test it.
4213         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
4214         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
4215
4216 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
4217
4218         webkitpy: Start servers before setting-up for testing
4219         https://bugs.webkit.org/show_bug.cgi?id=172176
4220         <rdar://problem/32225538>
4221
4222         Reviewed by Alexey Proskuryakov.
4223
4224         On-device testing requires that servers are started before ports set-up their
4225         test environments.
4226
4227         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4228         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
4229         Servers are unconditionally stopped on exit.
4230         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
4231         Manager now stops servers.
4232         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
4233         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
4234         * Scripts/webkitpy/layout_tests/controllers/manager.py: