Unbreak api tests
[WebKit-https.git] / Tools / ChangeLog
1 2013-03-12  Oliver Hunt  <oliver@apple.com>
2
3         Unbreak api tests
4
5         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
6         (TestWebKitAPI):
7
8 2013-03-12  Tim Horton  <timothy_horton@apple.com>
9
10         Unreviewed, disabling tests for Win EWS.
11
12         win-ews obviously cannot keep up with running tests, it's >300 behind.
13         Probably doesn't help that its (likely) running tests serially.
14
15         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
16         (WinEWS):
17
18 2013-03-12  Tim Horton  <timothy_horton@apple.com>
19
20         Add a --build-directory argument to delete-stale-build-files
21         https://bugs.webkit.org/show_bug.cgi?id=112198
22
23         Reviewed by Ryosuke Niwa.
24
25         * BuildSlaveSupport/delete-stale-build-files:
26         (main): Add --build-directory argument.
27
28 2013-03-12  Oliver Hunt  <oliver@apple.com>
29
30         Appease MSVC
31
32         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
33         (TestWebKitAPI):
34
35 2013-03-12  Oliver Hunt  <oliver@apple.com>
36
37         Add more Checked<> tests
38         https://bugs.webkit.org/show_bug.cgi?id=112190
39
40         Reviewed by Geoffrey Garen.
41
42         Tests!
43
44         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
45         (TestWebKitAPI):
46
47 2013-03-12  Julie Parent  <jparent@chromium.org>
48
49         Cleanup: Move loading complete function into callback, rather than global.
50         https://bugs.webkit.org/show_bug.cgi?id=112167
51
52         Reviewed by Dirk Pranke.
53         
54         Stop calling global functions, pass in proper handler to Loader
55         constructor. Note that the callback is optional, as tests, and
56         some potential dashboards, do not need one.
57
58         * TestResultServer/static-dashboards/dashboard_base.js:
59         * TestResultServer/static-dashboards/loader.js:
60         (.):
61         * TestResultServer/static-dashboards/loader_unittests.js:
62
63 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
64
65         [EFL][WK2] Add popup menu support to MiniBrowser
66         https://bugs.webkit.org/show_bug.cgi?id=108934
67
68         Reviewed by Kenneth Rohde Christiansen.
69
70         Implement popup menu support in MiniBrowser by handling popup_menu_show
71         and popup_menu_hide smart functions on the view and using the Ewk popup
72         menu API.
73
74         * MiniBrowser/efl/main.c:
75         (_Browser_Window):
76         (on_popup_menu_discarded):
77         (on_popup_menu_item_clicked):
78         (popup_menu_populate):
79         (on_popup_menu_show):
80         (on_popup_menu_hide):
81         (window_create): Use calloc() instead of malloc() to allocate memory for
82         Browser_Window. This makes sure all the structs members are initialized
83         to 0 (such as the new elm_popup_menu pointer).
84
85 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
86
87         [GTK] Set up the libPlatformGtk.la library
88         https://bugs.webkit.org/show_bug.cgi?id=111738
89
90         Reviewed by Martin Robinson.
91
92         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
93         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
94         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
95
96 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
97
98         [GTK] Enable Web Audio in development builds
99         https://bugs.webkit.org/show_bug.cgi?id=111831
100
101         Reviewed by Philippe Normand.
102
103         Web Audio is already quite well supported on the GTK port but still has a few issues
104         that must be addressed before it is enabled by default. Despite that it should be enabled
105         in development builds just so we are up-to-date with future feature infrastructure changes.
106         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
107         that's an obvious goal before enabling the feature in release builds.
108
109         * Scripts/webkitperl/FeatureList.pm:
110
111 2013-03-11  Andreas Kling  <akling@apple.com>
112
113         [Mac][WK1] Add support for alert() in MiniBrowser.
114         <http://webkit.org/b/112090>
115
116         Reviewed by Anders Carlsson.
117
118         * MiniBrowser/mac/WK1BrowserWindowController.m:
119         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
120
121 2013-03-11  Julie Parent  <jparent@chromium.org>
122
123         Dashboard cleanup: Create ui.Errors
124         https://bugs.webkit.org/show_bug.cgi?id=111785
125
126         Reviewed by Ojan Vafai.
127         
128         Create ui.Errors for handling errors the dashboards
129         encounter. Loader now has a Error object that it can add to,
130         and individual dashboards can show errors when desired.
131         Currently, only flakiness_db shows errors, but this is 
132         generic and there is no reason why other dbs wouldn't want to
133         show errors.
134
135         * TestResultServer/static-dashboards/dashboard_base.js:
136         (resourceLoadingComplete):
137         * TestResultServer/static-dashboards/flakiness_dashboard.js:
138         (generatePage):
139         * TestResultServer/static-dashboards/loader.js:
140         (.):
141         * TestResultServer/static-dashboards/ui.js:
142         (.):
143
144 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
145
146         Some StringHasher tests are broken because of missing null termination
147         https://bugs.webkit.org/show_bug.cgi?id=111284
148
149         Reviewed by Darin Adler.
150
151         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
152         (TestWebKitAPI): Added null termination since C strings are null-terminated.
153         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
154         the bug caught by it is now fixed.
155
156 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
157
158         Unreviewed, rolling out r145200.
159         http://trac.webkit.org/changeset/145200
160         https://bugs.webkit.org/show_bug.cgi?id=112063
161
162         Broke a couple of unit tests (Requested by zdobersek on
163         #webkit).
164
165         * Scripts/webkitperl/FeatureList.pm:
166
167 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
168
169         [GTK] WebKit2-only build fails
170         https://bugs.webkit.org/show_bug.cgi?id=112033
171
172         Reviewed by Gustavo Noronha Silva.
173
174         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
175         generic part, WebKit1-specific part and WebKit2-specific part.
176         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
177         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
178         directly.
179
180 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
181
182         Adding myself to the committers list.
183
184         Unreviewed.
185
186         * Scripts/webkitpy/common/config/committers.py:
187
188 2013-03-11  Jeff Rogers  <jrogers@rim.com>
189
190         [BlackBerry] Disable MathML support
191         https://bugs.webkit.org/show_bug.cgi?id=111929
192
193         Reviewed by Rob Buis.
194
195         * Scripts/webkitperl/FeatureList.pm:
196
197 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
198
199         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
200         https://bugs.webkit.org/show_bug.cgi?id=111970
201
202         Reviewed by Chris Fleizach.
203
204         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
205         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
206         undefined symbol.
207
208         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
209         (WTR::AccessibilityUIElement::supportedActions):
210         (WTR):
211
212 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
213
214         [chromium] Android apk targets should depend directly on Java library targets
215         https://bugs.webkit.org/show_bug.cgi?id=111746
216
217         Reviewed by Eric Seidel.
218
219         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
220         Make DumpRenderTree_apk depend directly on base_java and net_java.
221         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
222         Make TestWebKitAPI_apk depend directly on base_java.
223
224 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
225
226         [chromium] remove obsolete user gesture methods from WebFrame
227         https://bugs.webkit.org/show_bug.cgi?id=111696
228
229         Reviewed by Adam Barth.
230
231         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
232         (WebTestRunner::TestPlugin::handleInputEvent):
233         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
234
235 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
236
237         Unreviewed, add myself to commiters.py.
238
239         * Scripts/webkitpy/common/config/committers.py:
240
241 2013-03-08  Julie Parent  <jparent@chromium.org>
242
243         Cleanup: Remove dead code.
244         https://bugs.webkit.org/show_bug.cgi?id=111900
245
246         Reviewed by Dirk Pranke.
247         
248         Treemap overrides a global function that used to be in 
249         dashboard_base, but was removed months ago in
250         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
251         no caller. 
252
253         * TestResultServer/static-dashboards/treemap.html:
254
255 2013-03-08  Harald Alvestrand  <hta@chromium.org>
256
257         Implemented new API for RTCStatsReport object.
258         https://bugs.webkit.org/show_bug.cgi?id=110333
259
260         Reviewed by Adam Barth.
261
262         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
263         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
264
265 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
266
267         [chromium] use custom freetype on linux asan builds again
268         https://bugs.webkit.org/show_bug.cgi?id=111884
269
270         Reviewed by Tony Chang.
271
272         We no longer need the workaround after chromium r186540.
273
274         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
275
276 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
277
278         Warning about the user not having edit rights on Bugzilla is confusing new contributors
279         https://bugs.webkit.org/show_bug.cgi?id=111798
280
281         Reviewed by Dirk Pranke.
282
283         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
284
285         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
286
287 2013-03-08  James Robinson  <jamesr@chromium.org>
288
289         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
290         https://bugs.webkit.org/show_bug.cgi?id=111632
291
292         Reviewed by Adrienne Walker.
293
294         * DumpRenderTree/chromium/WebViewHost.cpp:
295         (WebViewHost::initializeLayerTreeView):
296         * DumpRenderTree/chromium/WebViewHost.h:
297         (WebViewHost):
298
299 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
300
301         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
302         https://bugs.webkit.org/show_bug.cgi?id=111297
303
304         Reviewed by Kenneth Rohde Christiansen.
305
306         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
307         (WTR::TestRunner::setViewModeMediaFeature):
308
309 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
310
311         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
312         https://bugs.webkit.org/show_bug.cgi?id=111814
313
314         Reviewed by Ryosuke Niwa.
315
316         Add the needed supportedActions() attribute to WKTestRunner.
317
318         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
319         (WTR::AccessibilityUIElement::supportedActions):
320         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
321         (AccessibilityUIElement):
322         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
323         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
324         (WTR::AccessibilityUIElement::supportedActions):
325
326 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
327
328         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
329         https://bugs.webkit.org/show_bug.cgi?id=111851
330
331         Reviewed by Kenneth Rohde Christiansen.
332
333         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
334         (TestWebKitAPI::TEST):
335
336             Fixed WKURLRef instance leaking.
337
338 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
339
340         [EFL] [WK2] Some authentication tests fail in WebKit2
341         https://bugs.webkit.org/show_bug.cgi?id=106407
342
343         Reviewed by Kenneth Rohde Christiansen.
344
345         Add patch from upstream for libsoup 2.40 to fix several authentication
346         test cases.
347
348         * efl/jhbuild.modules:
349         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
350
351 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
352
353         [GTK] Enable Web Audio in development builds
354         https://bugs.webkit.org/show_bug.cgi?id=111831
355
356         Reviewed by Philippe Normand.
357
358         Web Audio is already quite well supported on the GTK port but still has a few issues
359         that must be addressed before it is enabled by default. Despite that it should be enabled
360         in development builds just so we are up-to-date with future feature infrastructure changes.
361         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
362         that's an obvious goal before enabling the feature in release builds.
363
364         * Scripts/webkitperl/FeatureList.pm:
365
366 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
367
368         [chromium] delay clearing the TestRunners until the main view was deleted
369         https://bugs.webkit.org/show_bug.cgi?id=111823
370
371         Reviewed by Eric Seidel.
372
373         During WebViewHost::shutdown, we navigate the WebView to about:blank.
374         This may call into the test runners which assume that the delegate is
375         always non-NULL.
376
377         * DumpRenderTree/chromium/TestShell.cpp:
378         (TestShell::~TestShell):
379
380 2013-03-07  Alan Cutter  <alancutter@chromium.org>
381
382         Sheriffbot whois command can't search by full name
383         https://bugs.webkit.org/show_bug.cgi?id=111825
384
385         Reviewed by Eric Seidel.
386
387         Allowed multiple arguments to Sheriffbot's whois command.
388         Updated test expectations.
389
390         * Scripts/webkitpy/tool/bot/irc_command.py:
391         (Whois.execute):
392         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
393         (IRCCommandTest.test_whois):
394
395 2013-03-07  Nils Barth  <nbarth@chromium.org>
396
397         Add Nils Barth and Koji Hara to committers.py
398         https://bugs.webkit.org/show_bug.cgi?id=111806
399
400         Reviewed by Eric Seidel.
401
402         * Scripts/webkitpy/common/config/committers.py:
403
404 2013-03-07  Glenn Adams  <glenn@skynav.com>
405
406         run-pert-tests should have a --test-runner-count option
407         https://bugs.webkit.org/show_bug.cgi?id=111726
408
409         Reviewed by Ryosuke Niwa.
410
411         Add --test-runner-count option to run-perf-tests, with default value of 4.
412         This option allows command line configuration of the number of times to invoke
413         the test runner (serially, not in parallel) when running a specific test in
414         a test set.
415
416         * Scripts/webkitpy/performance_tests/perftest.py:
417         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
418         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
419         (PerfTest.run): Rename process_run_count to test_runner_count.
420         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
421         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
422         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
423         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
424         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
425         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
426         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
427         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
428         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
429         (MainTest.test_run_with_repeat):
430         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
431         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
432         (MainTest.test_default_args): Add test for default option argument values.
433         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
434
435 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
436
437         Add myself to reviewers.py
438         https://bugs.webkit.org/show_bug.cgi?id=111757
439
440         Reviewed by Eric Seidel.
441
442         * Scripts/webkitpy/common/config/committers.py:
443
444 2013-03-07  Glenn Adams  <glenn@skynav.com>
445
446         run-perf-tests should have a --repeat option
447         https://bugs.webkit.org/show_bug.cgi?id=100030
448
449         Reviewed by Ryosuke Niwa.
450
451         Add --repeat option to run-perf-tests, with default value of 1. When greater
452         than 1, runs test set specified number of times. Note that multiple runs are
453         not aggregated for statistical purposes.
454
455         Incidentally fixed typo: s/suceeds/succeeds/.
456
457         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
458         (PerfTestsRunner._parse_args): Add repeat option.
459         (PerfTestsRunner.run): Add outer repeat loop.
460         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
461         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
462         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
463         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
464         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
465         (MainTest.test_run_with_json_output): Fix typo.
466         (MainTest.test_run_with_description): Fix typo.
467         (MainTest.test_run_respects_no_results): Fix typo.
468         (MainTest.test_run_with_slave_config_json): Fix typo.
469         (MainTest.test_run_with_multiple_repositories): Fix typo.
470         (MainTest.test_run_with_upload_json): Fix typo.
471         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
472         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
473         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
474         (MainTest.test_parse_args): Add test for repeat option parsing.
475
476 2013-03-07  Julie Parent  <jparent@chromium.org>
477
478         showAllRuns checkbox no longer works on the stats dashboard
479         https://bugs.webkit.org/show_bug.cgi?id=111673
480
481         Reviewed by Ojan Vafai.
482
483         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
484         so we were trying to index into an undefined object.
485         
486         * TestResultServer/static-dashboards/dashboard_base.js:
487         (invalidateQueryParameters):
488
489 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
490
491         [Chromium] Update #include for WebStorageNamespace.h
492         https://bugs.webkit.org/show_bug.cgi?id=111748
493
494         Reviewed by Adam Barth.
495
496         In anticipation of removing
497         WK/chromium/public/WebStorageNamespace.h (once downstream
498         references have been updated)
499
500         * DumpRenderTree/chromium/WebViewHost.cpp:
501
502 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
503
504         run-perf-tests fails due to svn_revision not working on a pure git clone
505         https://bugs.webkit.org/show_bug.cgi?id=110839
506
507         Reviewed by Ryosuke Niwa.
508
509         Previously we would call git svn find-rev to look up the commit for
510         a given revision, and that'll hang in a pure git checkout.
511
512         This patch changes the way we look up svn revisions in a git
513         repository to use git log --grep 'git-svn-id', which is much faster
514         than grepping ourselves. It also renames timestamp_of_latest_commit()
515         to timestamp_of_revision() in order to accurately reflect what
516         the method is doing. Note that this patch only changes the logic
517         inside latest_revision() and svn_revision(). I'll file a separate
518         bug to change git_commit_from_svn_revision().
519
520         This patch also contains some fixes to unit tests that had bit-rotted
521         or were otherwise fragile, so that test-webkitpy --all would pass
522         cleanly, and a fix to outputcapture so that
523         test-webkitpy -p would work correctly again.
524
525         * Scripts/webkitpy/common/checkout/scm/git.py:
526         (Git.svn_revision):
527         (Git.timestamp_of_revision):
528         * Scripts/webkitpy/common/checkout/scm/scm.py:
529         (SCM.svn_revision):
530         (SCM.timestamp_of_revision):
531         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
532         (MockSCM.timestamp_of_revision):
533         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
534         (_shared_test_commit_with_message):
535         (test_commit_without_authorization):
536         (test_timestamp_of_revision):
537         * Scripts/webkitpy/common/checkout/scm/svn.py:
538         (SVN.timestamp_of_revision):
539         * Scripts/webkitpy/common/system/outputcapture.py:
540           Importing unittest2 directly may not be safe if this module is
541           imported before the autoinstaller gets a chance to set things up
542           properly. We don't actually need unittest2 here.
543         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
544         (PerfTestsRunner._generate_results_dict):
545
546 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
547
548         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
549         https://bugs.webkit.org/show_bug.cgi?id=111756
550
551         Reviewed by Kenneth Rohde Christiansen.
552
553         Bump libsoup to v2.40.3 to fix the regressions introduced by
554         previous v2.40.0 bump.
555
556         * efl/jhbuild.modules:
557
558 2013-03-07  Roger Fong  <roger_fong@apple.com>
559
560         Re-enable Win EWS tests.
561
562         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
563         (WinEWS):
564
565 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
566
567         [nrwt] handle corrupt http server pid files cleanly
568         https://bugs.webkit.org/show_bug.cgi?id=111628
569
570         Reviewed by Eric Seidel.
571
572         If the pid file from a previous http server is corrupt for some
573         reason, NRWT will just raise errors and not clean it up or recover.
574         This patch fixes that to at least delete the pid file and
575         not throw; not that we may still have stale http servers left on
576         the system, since there's no way to know which pid to kill if
577         the file was corrupted.
578
579         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
580         (HttpServerBase.start):
581         (HttpServerBase.stop):
582         (HttpServerBase._remove_pid_file):
583         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
584         (TestHttpServerBase):
585         (TestHttpServerBase.test_corrupt_pid_file):
586
587 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
588
589         AX: Can't activate links with VoiceOver in Safari
590         https://bugs.webkit.org/show_bug.cgi?id=111755
591
592         Reviewed by Tim Horton.
593
594         * DumpRenderTree/AccessibilityUIElement.cpp:
595         (supportedActionsCallback):
596         (AccessibilityUIElement::getJSClass):
597         * DumpRenderTree/AccessibilityUIElement.h:
598         (AccessibilityUIElement):
599         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
600         (AccessibilityUIElement::supportedActions):
601
602 2013-03-07  Roger Fong  <roger_fong@apple.com>
603
604         Windows debug layout tests are crashing like crazy again.
605         Disable tests on Win EWS bots temporarily.
606
607         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
608         (WinEWS):
609
610 2013-03-07  Roger Fong  <roger_fong@apple.com>
611
612         Make EWS bots build and test in release.
613
614         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
615         (WinEWS):
616         * Scripts/webkitpy/tool/steps/runtests.py:
617         (RunTests.run):
618
619 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
620
621         [chromium] don't track the top loading frame if no layout test is currently running
622         https://bugs.webkit.org/show_bug.cgi?id=111716
623
624         Reviewed by Kentaro Hara.
625
626         In DRT, we synchronously stop the test and start loading the next test
627         URL. However, in content_shell, this happens asynchronously. It's
628         important that the top loading frame is not changed due to stray
629         navigation events before the next test starts.
630
631         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
632         (WebTestRunner::TestRunner::setTopLoadingFrame):
633
634 2013-03-06  Julie Parent  <jparent@chromium.org>
635
636         Dashboard cleanup: Move all dashboard ui related code into ui.js.
637         https://bugs.webkit.org/show_bug.cgi?id=111621
638
639         Reviewed by Ojan Vafai.
640         
641         Creates ui.js, a package for the common UI code the various
642         dashboards use. HTML generation is now in the ui.html namespace
643         and popup handling is in ui.popup.
644         Also moves the event listening for popups to ui.popup.show and
645         removes it on ui.popup.hid rather than having listener always
646         around.
647
648         * TestResultServer/static-dashboards/aggregate_results.html:
649         * TestResultServer/static-dashboards/dashboard_base.js:
650         * TestResultServer/static-dashboards/flakiness_dashboard.html:
651         * TestResultServer/static-dashboards/flakiness_dashboard.js:
652         (showPopupForBuild):
653         (htmlForNavBar):
654         (generatePageForIndividualTests.if):
655         (generatePageForIndividualTests):
656         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
657         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
658         * TestResultServer/static-dashboards/run-embedded-unittests.html:
659         * TestResultServer/static-dashboards/run-unittests.html:
660         * TestResultServer/static-dashboards/timeline_explorer.html:
661         * TestResultServer/static-dashboards/treemap.html:
662         * TestResultServer/static-dashboards/ui.js: Added.
663         (.):
664
665 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
666
667         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
668         https://bugs.webkit.org/show_bug.cgi?id=110584
669
670         Reviewed by Gyuyoung Kim.
671
672         Adds missing implementation of AccessibilityControllerEfl
673         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
674         so that it can make accessibilityController as a js object.
675
676         * DumpRenderTree/AccessibilityController.h:
677         (AccessibilityController):
678         * DumpRenderTree/AccessibilityUIElement.h:
679         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
680         (AccessibilityController::childElementById): Moved declaration to base class.
681         Implementation can be shared among other ports.
682         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
683         (AccessibilityController::focusedElement):
684         (AccessibilityController::rootElement):
685         (AccessibilityController::accessibleElementById):
686         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
687         (AccessibilityUIElement::helpText):
688         * DumpRenderTree/efl/CMakeLists.txt:
689         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
690         (DumpRenderTreeChrome::DumpRenderTreeChrome):
691         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
692         (DumpRenderTreeChrome::onWindowObjectCleared):
693         (DumpRenderTreeChrome::accessibilityController):
694         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
695         (DumpRenderTreeChrome):
696         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
697
698 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
699
700         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
701         https://bugs.webkit.org/show_bug.cgi?id=42696
702
703         Reviewed by Andreas Kling.
704
705         * DumpRenderTree/TestRunner.cpp:
706         (TestRunner::staticFunctions):
707         * DumpRenderTree/TestRunner.h:
708         (TestRunner):
709         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
710         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
711         (WebTestRunner::TestRunner::TestRunner):
712         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
713         (TestRunner):
714         * DumpRenderTree/efl/TestRunnerEfl.cpp:
715         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
716         * DumpRenderTree/mac/TestRunnerMac.mm:
717         * DumpRenderTree/qt/TestRunnerQt.cpp:
718         * DumpRenderTree/qt/TestRunnerQt.h:
719         (TestRunnerQt):
720         * DumpRenderTree/win/TestRunnerWin.cpp:
721         * DumpRenderTree/wx/TestRunnerWx.cpp:
722
723 2013-03-06  Roger Fong  <roger_fong@apple.com>
724
725         Re-enable WinEWS test and decrease iterations before clean build back to 10.
726
727         * EWSTools/start-queue-win.sh:
728         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
729         (WinEWS):
730
731 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
732
733         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
734         https://bugs.webkit.org/show_bug.cgi?id=82866
735
736         Reviewed by Martin Robinson.
737
738         * Scripts/run-gtk-tests:
739         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
740         it is passing now.
741
742 2013-03-06  Julie Parent  <jparent@chromium.org>
743
744         Dashboard cleanup: remove dashboard time logging.
745         https://bugs.webkit.org/show_bug.cgi?id=111608
746
747         Reviewed by Dirk Pranke.
748
749         Remove logTime.  It was never accurate, and the dev tools
750         have better ways to measure this if anyone cares to look
751         into dashboard perf.
752         
753         * TestResultServer/static-dashboards/dashboard_base.js:
754         * TestResultServer/static-dashboards/flakiness_dashboard.js:
755         (processTestRunsForBuilder):
756         (appendHTML):
757
758 2013-03-06  Tony Chang  <tony@chromium.org>
759
760         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
761         https://bugs.webkit.org/show_bug.cgi?id=111509
762
763         Reviewed by Dirk Pranke.
764
765         Add DumpRenderTree.pak to DumpRenderTree.app again.
766
767         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
768
769 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
770
771         [chromium] introduce WebUserGestureIndicator
772         https://bugs.webkit.org/show_bug.cgi?id=111531
773
774         Reviewed by Adam Barth.
775
776         * DumpRenderTree/chromium/WebViewHost.cpp:
777         (WebViewHost::createView):
778
779 2013-03-06  Alan Cutter  <alancutter@chromium.org>
780
781         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
782         https://bugs.webkit.org/show_bug.cgi?id=73482
783
784         Reviewed by Ryosuke Niwa.
785
786         Added input checking to the UpdateChromiumDEPS step.
787         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
788
789         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
790         (RollChromiumDEPS):
791         (RollChromiumDEPS._parse_args):
792         (RollChromiumDEPS.execute):
793         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
794         (IRCCommandTest.test_roll_chromium_deps):
795         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
796         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
797         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
798         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
799         (UpdateChromiumDEPS._fetch_last_known_good_revision):
800         (UpdateChromiumDEPS):
801         (UpdateChromiumDEPS._parse_revision_number):
802         (UpdateChromiumDEPS._validate_revisions):
803         (UpdateChromiumDEPS.run):
804         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
805         (UpdateChromiumDEPSTest):
806         (UpdateChromiumDEPSTest.test_parse_revision_number):
807         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
808         (RollChromiumDEPS):
809         (PostChromiumDEPSRoll):
810
811 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
812
813         [Qt][MiniBrowser] Touch mocking broken for chained getures
814         https://bugs.webkit.org/show_bug.cgi?id=111430
815
816         Reviewed by Jocelyn Turcotte.
817
818         Make it possible again to use touch mocking to test gesture chains
819         like pan->pinch->pan->pinch without lifting the primary "finger".
820         For this to work we need to track the pressed mouse buttons and
821         only synthesize touch release events when the ctrl key is released
822         if no mouse button is pressed. Else the pressed mouse button(s)
823         should result in a stationary touch point in a touch update event.
824         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
825         to check for the state of the ctrl key modifier instead of getting
826         it from the mouse events.
827
828         * MiniBrowser/qt/MiniBrowserApplication.cpp:
829         (MiniBrowserApplication::MiniBrowserApplication):
830         (MiniBrowserApplication::notify):
831
832 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
833
834         [chromium] don't use custom freetype on linux asan for now
835         https://bugs.webkit.org/show_bug.cgi?id=111516
836
837         Unreviewed, build fix.
838
839         Turns out the custom lib is getting picked up by other binaries
840         on our bot, which is bad.
841
842         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
843
844 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
845
846         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
847         https://bugs.webkit.org/show_bug.cgi?id=111509
848
849         Unreviewed, build fix.
850
851         Actually comment out the flag :(.
852
853         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
854
855 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
856
857         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
858         https://bugs.webkit.org/show_bug.cgi?id=111509
859
860         Unreviewed, build fix.
861
862         r144863 appears to have broken the xcode build; I'm temporarily
863         trying this instead, and if this doesn't work, I'll revert the
864         other changes.
865
866         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
867
868 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
869
870         [chromium] build a DumpRenderTree.pak even on windows
871         https://bugs.webkit.org/show_bug.cgi?id=111504
872
873         Reviewed by Tony Chang.
874
875         The Chromium Aura build uses the default theme to draw
876         controls, and that theme requires the ui ResourceBundle
877         to be initialized. On every other platform, we build
878         a DumpRenderTree.pak that works for this, but on Windows we
879         still compile the resources directly into DRT. As a first step,
880         let's build the pak file. I will then need to land a patch
881         in Chromium to actually load it. Then I can go back and move
882         the resources over to just use the .pak file and no longer need
883         the .rc's.
884
885         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
886
887 2013-03-05  Julie Parent  <jparent@chromium.org>
888         Dashboard cleanup: move string utilities into their own namespace.
889         
890         https://bugs.webkit.org/show_bug.cgi?id=111485
891
892         Reviewed by Ojan Vafai.
893         
894         One of many pieces to clean up dashboard_base.
895         
896         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
897
898         * TestResultServer/static-dashboards/aggregate_results.html:
899         * TestResultServer/static-dashboards/dashboard_base.js:
900         (isTreeMap):
901         (isFlakinessDashboard):
902         * TestResultServer/static-dashboards/flakiness_dashboard.html:
903         * TestResultServer/static-dashboards/flakiness_dashboard.js:
904         (determineWKPlatform):
905         (chromiumPlatform):
906         (platformAndBuildType):
907         (substringList):
908         (individualTestsForSubstringList):
909         (filterBugs):
910         (populateExpectationsData):
911         (processMissingTestsWithExpectations):
912         (processMissingAndExtraExpectations):
913         (htmlForSingleTestRow):
914         (.dummyNode.onload):
915         (expectationsTitle):
916         * TestResultServer/static-dashboards/run-embedded-unittests.html:
917         * TestResultServer/static-dashboards/run-unittests.html:
918         * TestResultServer/static-dashboards/string.js: Added.
919         * TestResultServer/static-dashboards/timeline_explorer.html:
920         * TestResultServer/static-dashboards/treemap.html:
921
922 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
923
924         [EFL] Build break with latest EFL libraries
925         https://bugs.webkit.org/show_bug.cgi?id=111028
926
927         Reviewed by Dirk Pranke.
928
929         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
930         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
931         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
932
933 2013-03-05  Roger Fong  <roger_fong@apple.com>
934
935         Increase number of WinEWS iterations to 20.
936         Don't reboot after each iteration set.
937         Make EWS bots just build temporarily so that the queue catches up again.
938
939         * EWSTools/start-queue-win.sh:
940         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
941         (WinEWS):
942
943 2013-03-04  James Robinson  <jamesr@chromium.org>
944
945         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
946         https://bugs.webkit.org/show_bug.cgi?id=111386
947
948         Reviewed by Adrienne Walker.
949
950         * DumpRenderTree/chromium/TestShell.cpp:
951         (TestShell::initialize):
952
953 2013-03-05  Min Qin  <qinmin@chromium.org>
954
955         Copy dictionary to the external storage before running layout test on android
956         https://bugs.webkit.org/show_bug.cgi?id=111480
957
958         Reviewed by Adam Barth.
959
960         TestWebKitPlatformSupport now needs to read an external dictionary file.
961         This file does not exist on the device. We need to copy it before running layout tests.
962
963         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
964         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
965         (ChromiumAndroidDriver._push_platform_resources):
966
967 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
968
969         [chromium] DRT crashes in an Aura/Win build
970         https://bugs.webkit.org/show_bug.cgi?id=111394
971
972         Reviewed by Tony Chang.
973
974         When building (and running) with use_aura=1, we assume that
975         we're using the default theme engine, but DRT creates the
976         DRTWin theme engine and overwrites the default, leading to crashes
977         in basically every test from the mismatch.
978
979         This fix gets us down to at least "lots of crashes" :).
980
981         * DumpRenderTree/chromium/TestShellWin.cpp:
982         (platformInit):
983
984 2013-03-05  Eric Seidel  <eric@webkit.org>
985
986         Add html-parser-threaded perf test now that the threaded parser is enabled by default
987         https://bugs.webkit.org/show_bug.cgi?id=111200
988
989         Reviewed by Ryosuke Niwa.
990
991         Had to teach run-perf-tests to ignore one more warning.
992
993         * Scripts/webkitpy/performance_tests/perftest.py:
994         (PerfTest):
995
996 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
997
998         Update list of builders for test results server
999         https://bugs.webkit.org/show_bug.cgi?id=111166
1000
1001         Reviewed by Ojan Vafai.
1002
1003         * TestResultServer/static-dashboards/builders.jsonp:
1004
1005 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
1006
1007         [GTK] Move basic dependency installation to a script
1008         https://bugs.webkit.org/show_bug.cgi?id=110692
1009
1010         Reviewed by Gustavo Noronha Silva.
1011
1012         * gtk/install-dependencies: Added. A Script which installs all dependencies
1013         necessary for building for Debian-based distributions and Fedora.
1014
1015 2013-03-05  James Robinson  <jamesr@chromium.org>
1016
1017         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
1018         https://bugs.webkit.org/show_bug.cgi?id=111440
1019
1020         Reviewed by Adrienne Walker.
1021
1022         Remove unnecessary WebCompositorSupport::shutdown call
1023
1024         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1025         (main):
1026
1027 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
1028
1029         Unreviewed build fix.
1030
1031         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
1032
1033 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
1034
1035         [Qt][MiniBrowser] Improve the update of touch indicators
1036         https://bugs.webkit.org/show_bug.cgi?id=111429
1037
1038         Reviewed by Jocelyn Turcotte.
1039
1040         MiniBrowserApplication::sendTouchEvent sends an empty list
1041         to BrowserWindow::updateVisualMockTouchPoints if the control
1042         button is released, in which case the touch indicators should
1043         be hidden so that we never end up with a leftover indicator
1044         sticking on the screen.
1045         This patch also simplifies the lookup of the indicator items by
1046         replacing the findChild search in the item tree with a QHash
1047         that stores the touch ID's and the pointers to the corresponding
1048         indicator items.
1049
1050         * MiniBrowser/qt/BrowserWindow.cpp:
1051         (BrowserWindow::updateVisualMockTouchPoints):
1052         * MiniBrowser/qt/BrowserWindow.h:
1053         (BrowserWindow):
1054
1055 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1056
1057         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
1058         https://bugs.webkit.org/show_bug.cgi?id=81042
1059
1060         Reviewed by Enrica Casucci.
1061
1062         Add setAsynchronousSpellCheckingEnabled implementation for
1063         WebKitTestRunner to have the possibility to test asynchronous
1064         spell checking implementation from bug 109577.
1065
1066         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1067         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1068         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
1069         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1070         * WebKitTestRunner/TestController.cpp:
1071         (WTR::TestController::resetStateToConsistentValues):
1072
1073 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
1074
1075         MediaStream API: Add the getStreamById method on RTCPeerConnection
1076         https://bugs.webkit.org/show_bug.cgi?id=111311
1077
1078         Reviewed by Adam Barth.
1079
1080         Changing mocks to be more realistic.
1081
1082         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
1083         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
1084         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
1085         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
1086         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
1087
1088 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
1089
1090         Add content shell bots to garden-o-matic for general failurse
1091         https://bugs.webkit.org/show_bug.cgi?id=111168
1092
1093         Reviewed by Adam Barth.
1094
1095         All but the WebKit (Content Shell) Android bot is stable enough. While
1096         they're not green yet, there must not be any non-layout test failures on
1097         them.
1098
1099         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1100         (.):
1101
1102 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1103
1104         [chromium] remove deprecated WebTestRunner::setFocus API
1105         https://bugs.webkit.org/show_bug.cgi?id=111354
1106
1107         Reviewed by James Robinson.
1108
1109         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1110         (WebTestDelegate):
1111
1112 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1113
1114         Run the bindings generation tests on EWS and CQ bots
1115         https://bugs.webkit.org/show_bug.cgi?id=111358
1116
1117         Reviewed by Adam Barth.
1118
1119         The tests are super fast and not flaky.
1120
1121         * Scripts/webkitpy/common/config/ports.py:
1122         (DeprecatedPort.run_bindings_tests_command):
1123         * Scripts/webkitpy/common/config/ports_mock.py:
1124         (MockPort.run_webkit_tests_command):
1125         (MockPort):
1126         (MockPort.run_bindings_tests_command):
1127         * Scripts/webkitpy/tool/commands/download_unittest.py:
1128         * Scripts/webkitpy/tool/steps/runtests.py:
1129         (RunTests.run):
1130         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1131         (RunTestsTest.test_webkit_run_unit_tests):
1132         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1133
1134 2013-03-04  Eric Seidel  <eric@webkit.org>
1135
1136         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
1137         https://bugs.webkit.org/show_bug.cgi?id=111384
1138
1139         Reviewed by Ryosuke Niwa.
1140
1141         Sometimes I want to know why various LayoutTests are slow
1142         without having to convert them into PerformanceTests in order
1143         to use our fancy profiling.  The Driver already knows how to
1144         do the right thing, we just need to expose the options to the user.
1145
1146         Handling of these options is already unittested in the perftests_unittest.
1147
1148         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1149         (parse_args):
1150
1151 2013-03-04  Alan Cutter  <alancutter@chromium.org>
1152
1153         check-webkit-style says "Have to enable auto props in the subversion config file"
1154         https://bugs.webkit.org/show_bug.cgi?id=107724
1155
1156         Reviewed by Tony Chang.
1157
1158         Added a standard svn config file for WebKit developers to use.
1159         Updated the style and commit queue bot build scripts to load this file.
1160
1161         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1162         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1163         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1164         * svn-config: Added.
1165
1166 2013-03-04  James Robinson  <jamesr@chromium.org>
1167
1168         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
1169         https://bugs.webkit.org/show_bug.cgi?id=111285
1170
1171         Reviewed by Adrienne Walker.
1172
1173         This removes the need for WebCompositorSupport::initialize and exposes
1174         slightly fewer entry points across the repository boundary.
1175
1176         * DumpRenderTree/chromium/TestShell.cpp:
1177         (TestShell::initialize):
1178         * DumpRenderTree/chromium/TestShell.h:
1179         (TestShell::webCompositorThread):
1180         (TestShell):
1181         * DumpRenderTree/chromium/WebViewHost.cpp:
1182         (WebViewHost::initializeLayerTreeView):
1183
1184 2013-03-04  Roger Fong  <roger_fong@apple.com>
1185
1186         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
1187
1188         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
1189
1190 2013-03-04  David Kilzer  <ddkilzer@apple.com>
1191
1192         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
1193
1194             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
1195                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
1196                                         ^         ~~~~~~~~~~~~~~~~~~~~~
1197             1 error generated.
1198
1199         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
1200         AccessibilityCommonMac.h.
1201
1202 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1203
1204         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
1205         https://bugs.webkit.org/show_bug.cgi?id=109828
1206
1207         Reviewed by Kenneth Rohde Christiansen.
1208
1209         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
1210         callbacks.
1211
1212         * TestWebKitAPI/CMakeLists.txt:
1213
1214             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
1215             considered.
1216
1217         * TestWebKitAPI/PlatformEfl.cmake:
1218         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
1219         (TestWebKitAPI):
1220         (TestWebKitAPI::didFinishLoadForFrame):
1221         (TestWebKitAPI::setPageLoaderClient):
1222         (TestWebKitAPI::webProcessCrashed):
1223         (TestWebKitAPI::webProcessDidRelaunch):
1224         (TestWebKitAPI::setViewClient):
1225         (TestWebKitAPI::TEST):
1226
1227 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
1228
1229         AX: Upstream iOS Accessibility DumpRenderTree changes
1230         https://bugs.webkit.org/show_bug.cgi?id=111220
1231
1232         Reviewed by David Kilzer.
1233
1234         Upstream the iOS changes for accessibility in DumpRenderTree.
1235
1236         * DumpRenderTree/AccessibilityUIElement.cpp:
1237         (headerElementAtIndexCallback):
1238         (linkedElementCallback):
1239         (elementsForRangeCallback):
1240         (increaseTextSelectionCallback):
1241         (decreaseTextSelectionCallback):
1242         (assistiveTechnologySimulatedFocusCallback):
1243         (stringForSelectionCallback):
1244         (getIPhoneLabelCallback):
1245         (getIPhoneHintCallback):
1246         (getIPhoneValueCallback):
1247         (getIPhoneIdentifierCallback):
1248         (getIPhoneTraitsCallback):
1249         (getIPhoneIsElementCallback):
1250         (getIPhoneElementTextPositionCallback):
1251         (getIPhoneElementTextLengthCallback):
1252         (AccessibilityUIElement::getJSClass):
1253         * DumpRenderTree/AccessibilityUIElement.h:
1254         (AccessibilityUIElement):
1255         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1256         * DumpRenderTree/ios: Added.
1257         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
1258         (AccessibilityController::AccessibilityController):
1259         (AccessibilityController::~AccessibilityController):
1260         (AccessibilityController::elementAtPoint):
1261         (AccessibilityController::focusedElement):
1262         (AccessibilityController::rootElement):
1263         (findAccessibleObjectById):
1264         (AccessibilityController::accessibleElementById):
1265         (AccessibilityController::setLogFocusEvents):
1266         (AccessibilityController::setLogScrollingStartEvents):
1267         (AccessibilityController::setLogValueChangeEvents):
1268         (AccessibilityController::setLogAccessibilityEvents):
1269         (AccessibilityController::addNotificationListener):
1270         (AccessibilityController::removeNotificationListener):
1271         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
1272         (AccessibilityUIElement::AccessibilityUIElement):
1273         (AccessibilityUIElement::~AccessibilityUIElement):
1274         (concatenateAttributeAndValue):
1275         (AccessibilityUIElement::iphoneLabel):
1276         (AccessibilityUIElement::iphoneHint):
1277         (AccessibilityUIElement::iphoneValue):
1278         (AccessibilityUIElement::iphoneIdentifier):
1279         (AccessibilityUIElement::iphoneTraits):
1280         (AccessibilityUIElement::iphoneIsElement):
1281         (AccessibilityUIElement::iphoneElementTextPosition):
1282         (AccessibilityUIElement::iphoneElementTextLength):
1283         (AccessibilityUIElement::url):
1284         (AccessibilityUIElement::x):
1285         (AccessibilityUIElement::y):
1286         (AccessibilityUIElement::width):
1287         (AccessibilityUIElement::height):
1288         (AccessibilityUIElement::clickPointX):
1289         (AccessibilityUIElement::clickPointY):
1290         (AccessibilityUIElement::getChildren):
1291         (AccessibilityUIElement::getChildrenWithRange):
1292         (AccessibilityUIElement::childrenCount):
1293         (AccessibilityUIElement::elementAtPoint):
1294         (AccessibilityUIElement::indexOfChild):
1295         (AccessibilityUIElement::getChildAtIndex):
1296         (AccessibilityUIElement::headerElementAtIndex):
1297         (AccessibilityUIElement::linkedElement):
1298         (AccessibilityUIElement::linkedUIElementAtIndex):
1299         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1300         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1301         (AccessibilityUIElement::disclosedRowAtIndex):
1302         (AccessibilityUIElement::selectedRowAtIndex):
1303         (AccessibilityUIElement::rowAtIndex):
1304         (AccessibilityUIElement::titleUIElement):
1305         (AccessibilityUIElement::parentElement):
1306         (AccessibilityUIElement::disclosedByRow):
1307         (AccessibilityUIElement::increaseTextSelection):
1308         (AccessibilityUIElement::decreaseTextSelection):
1309         (AccessibilityUIElement::stringForSelection):
1310         (AccessibilityUIElement::stringForRange):
1311         (AccessibilityUIElement::attributedStringForRange):
1312         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1313         (AccessibilityUIElement::elementsForRange):
1314         (AccessibilityUIElement::getLinkedUIElements):
1315         (AccessibilityUIElement::getDocumentLinks):
1316         (AccessibilityUIElement::attributesOfLinkedUIElements):
1317         (AccessibilityUIElement::attributesOfDocumentLinks):
1318         (AccessibilityUIElement::attributesOfChildren):
1319         (AccessibilityUIElement::allAttributes):
1320         (AccessibilityUIElement::stringAttributeValue):
1321         (AccessibilityUIElement::isPressActionSupported):
1322         (AccessibilityUIElement::isIncrementActionSupported):
1323         (AccessibilityUIElement::isDecrementActionSupported):
1324         (AccessibilityUIElement::boolAttributeValue):
1325         (AccessibilityUIElement::isAttributeSettable):
1326         (AccessibilityUIElement::isAttributeSupported):
1327         (AccessibilityUIElement::parameterizedAttributeNames):
1328         (AccessibilityUIElement::role):
1329         (AccessibilityUIElement::subrole):
1330         (AccessibilityUIElement::roleDescription):
1331         (AccessibilityUIElement::title):
1332         (AccessibilityUIElement::description):
1333         (AccessibilityUIElement::orientation):
1334         (AccessibilityUIElement::stringValue):
1335         (AccessibilityUIElement::language):
1336         (AccessibilityUIElement::helpText):
1337         (AccessibilityUIElement::intValue):
1338         (AccessibilityUIElement::minValue):
1339         (AccessibilityUIElement::maxValue):
1340         (AccessibilityUIElement::valueDescription):
1341         (AccessibilityUIElement::insertionPointLineNumber):
1342         (AccessibilityUIElement::isEnabled):
1343         (AccessibilityUIElement::isRequired):
1344         (AccessibilityUIElement::isFocused):
1345         (AccessibilityUIElement::isSelected):
1346         (AccessibilityUIElement::isExpanded):
1347         (AccessibilityUIElement::isChecked):
1348         (AccessibilityUIElement::hierarchicalLevel):
1349         (AccessibilityUIElement::ariaIsGrabbed):
1350         (AccessibilityUIElement::ariaDropEffects):
1351         (AccessibilityUIElement::lineForIndex):
1352         (AccessibilityUIElement::boundsForRange):
1353         (AccessibilityUIElement::attributesOfColumnHeaders):
1354         (AccessibilityUIElement::attributesOfRowHeaders):
1355         (AccessibilityUIElement::attributesOfColumns):
1356         (AccessibilityUIElement::attributesOfRows):
1357         (AccessibilityUIElement::attributesOfVisibleCells):
1358         (AccessibilityUIElement::attributesOfHeader):
1359         (AccessibilityUIElement::rowCount):
1360         (AccessibilityUIElement::columnCount):
1361         (AccessibilityUIElement::indexInTable):
1362         (AccessibilityUIElement::rowIndexRange):
1363         (AccessibilityUIElement::columnIndexRange):
1364         (AccessibilityUIElement::cellForColumnAndRow):
1365         (AccessibilityUIElement::selectedTextRange):
1366         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1367         (AccessibilityUIElement::setSelectedTextRange):
1368         (AccessibilityUIElement::increment):
1369         (AccessibilityUIElement::decrement):
1370         (AccessibilityUIElement::showMenu):
1371         (AccessibilityUIElement::press):
1372         (AccessibilityUIElement::accessibilityValue):
1373         (AccessibilityUIElement::documentEncoding):
1374         (AccessibilityUIElement::documentURI):
1375         (_accessibilityNotificationCallback):
1376         (AccessibilityUIElement::addNotificationListener):
1377         (AccessibilityUIElement::removeNotificationListener):
1378         (AccessibilityUIElement::isFocusable):
1379         (AccessibilityUIElement::isSelectable):
1380         (AccessibilityUIElement::isMultiSelectable):
1381         (AccessibilityUIElement::isSelectedOptionActive):
1382         (AccessibilityUIElement::isVisible):
1383         (AccessibilityUIElement::isOffScreen):
1384         (AccessibilityUIElement::isCollapsed):
1385         (AccessibilityUIElement::isIgnored):
1386         (AccessibilityUIElement::hasPopup):
1387         (AccessibilityUIElement::takeFocus):
1388         (AccessibilityUIElement::takeSelection):
1389         (AccessibilityUIElement::addSelection):
1390         (AccessibilityUIElement::removeSelection):
1391         (AccessibilityUIElement::uiElementForSearchPredicate):
1392         (AccessibilityUIElement::numberAttributeValue):
1393
1394 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1395
1396         [chromium] pass all focus handling methods through the WebTestDelegate
1397         https://bugs.webkit.org/show_bug.cgi?id=111328
1398
1399         Reviewed by Nico Weber.
1400
1401         In content_shell, the focus handling is asynchronous. To allow for
1402         switching the focus synchronously between WebViews, we need to intercept
1403         didFocus and didBlur and forward it to the WebTestDelegate.
1404
1405         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1406         (WebTestDelegate):
1407         (WebTestRunner::WebTestDelegate::setFocus):
1408         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1409         (WebTestRunner::WebTestProxy::didFocus):
1410         (WebTestRunner::WebTestProxy::didBlur):
1411         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1412         (WebTestRunner::TestRunner::setWindowIsKey):
1413         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1414         (WebTestRunner::WebTestProxyBase::didFocus):
1415         (WebTestRunner):
1416         (WebTestRunner::WebTestProxyBase::didBlur):
1417         * DumpRenderTree/chromium/WebViewHost.cpp:
1418         (WebViewHost::didFocus):
1419         (WebViewHost::didBlur):
1420         (WebViewHost::setFocus):
1421         * DumpRenderTree/chromium/WebViewHost.h:
1422         (WebViewHost):
1423
1424 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
1425
1426         [GTK] No need to manually add system paths to jhbuildrc
1427         https://bugs.webkit.org/show_bug.cgi?id=110850
1428
1429         Reviewed by Gustavo Noronha Silva.
1430
1431         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
1432         already takes care of.
1433
1434 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
1435
1436         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
1437         https://bugs.webkit.org/show_bug.cgi?id=111284
1438
1439         Disabling the failing two tests on Android.
1440
1441         Reviewed by Jochen Eisinger.
1442
1443         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1444         (TestWebKitAPI):
1445         (TestWebKitAPI::TEST):
1446
1447 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
1448
1449         Add build flag for FontLoader
1450         https://bugs.webkit.org/show_bug.cgi?id=111289
1451
1452         Reviewed by Benjamin Poulain.
1453
1454         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
1455
1456         * Scripts/webkitperl/FeatureList.pm:
1457         * qmake/mkspecs/features/features.pri:
1458
1459 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
1460
1461         [Mac] Get rid of a useless method from DOMHTMLInputElement
1462         https://bugs.webkit.org/show_bug.cgi?id=111279
1463
1464         Reviewed by Sam Weinig.
1465
1466         * DumpRenderTree/mac/TestRunnerMac.mm:
1467         (TestRunner::setValueForUser):
1468         The method _setValueForUser: was added for testing. This feature is already
1469         exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
1470         in real use cases. Get rid of the method created for testing, use the real thing
1471         instead.
1472
1473 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1474
1475         Some perf. tests have variances that differ greatly between runs
1476         https://bugs.webkit.org/show_bug.cgi?id=97510
1477
1478         Reviewed by Benjamin Poulain.
1479
1480         Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
1481         environment on test results (we run each instance after one another, not in parallel).
1482
1483         We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
1484         iterations as it was done previously in single process. These values are hard-coded in perftest.py
1485         and runner.js but they are to be configurable in the future.
1486
1487         Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
1488         metric now reports an array of the length 4 with each element containing an array of 5 iteration
1489         values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
1490
1491         Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
1492         and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
1493         as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
1494
1495         * Scripts/webkitpy/performance_tests/perftest.py:
1496         (PerfTestMetric.append_group): Renamed from append.
1497         (PerfTestMetric.grouped_iteration_values): Added.
1498         (PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
1499
1500         (PerfTest.__init__): Takes the number of processes (drivers) to run tests with.
1501         This parameter is only used by SingleProcessPerfTest.
1502
1503         (PerfTest.run): Repeat tests using different driver processes.
1504         (PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
1505         since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
1506         We instead use _ensure_metrics to obtain the matched metrics and store the data there.
1507         (PerfTest._ensure_metrics): Added.
1508
1509         (SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
1510         instances of DumpRenderTree/WebKitTestRunner takes too long.
1511         (SingleProcessPerfTest.__init__):
1512
1513         (ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
1514
1515         (PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
1516
1517         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
1518         _run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
1519         the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
1520
1521         (TestPerfTestMetric.test_append): Updated per name and added some test cases for
1522         grouped_iteration_values.
1523
1524         (TestPerfTest._assert_results_are_correct):
1525
1526         (TestSingleProcessPerfTest): Added.
1527         (TestSingleProcessPerfTest.test_use_only_one_process):
1528         (TestSingleProcessPerfTest.test_use_only_one_process.run_single):
1529
1530         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1531         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1532
1533         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
1534         sample standard deviations since we're now running tests 4 times.
1535         (MainTest._test_run_with_json_output.mock_upload_json):
1536         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1537
1538 2013-03-03  Alexandre Elias  <aelias@chromium.org>
1539
1540         [chromium] Remove WebLayerTreeView::setViewportSize call
1541         https://bugs.webkit.org/show_bug.cgi?id=110727
1542
1543         Reviewed by James Robinson.
1544
1545         After https://codereview.chromium.org/12328080 lands,
1546         setViewportSize is called from the Chromium side. The multiplication
1547         by deviceScaleFactor here was prone to off-by-one errors.
1548         The layoutSize() function was only used here so delete it as well.
1549
1550         DumpRenderTree WebViewHost must now call this method as well.
1551
1552         * DumpRenderTree/chromium/WebViewHost.cpp:
1553         (WebViewHost::initializeLayerTreeView):
1554         (WebViewHost::setWindowRect):
1555         (WebViewHost::setDeviceScaleFactor):
1556         (WebViewHost::updateViewportSize):
1557         * DumpRenderTree/chromium/WebViewHost.h:
1558         (WebViewHost):
1559
1560 2013-02-27  Darin Adler  <darin@apple.com>
1561
1562         StringHasher functions require alignment that call sites do not all guarantee
1563         https://bugs.webkit.org/show_bug.cgi?id=110171
1564
1565         Reviewed by Benjamin Poulain.
1566
1567         * TestWebKitAPI/CMakeLists.txt:
1568         * TestWebKitAPI/GNUmakefile.am:
1569         * TestWebKitAPI/TestWebKitAPI.gypi:
1570         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1571         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1572         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1573         * TestWebKitAPI/Tests/WTF/WTF.pro:
1574         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1575         Added the StringHasher.cpp file.
1576
1577         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
1578         for the functions in the StringHasher class.
1579
1580 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
1581
1582         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
1583         https://bugs.webkit.org/show_bug.cgi?id=109772
1584
1585         Reviewed by Andreas Kling.
1586
1587         * DumpRenderTree/TestRunner.cpp:
1588         (TestRunner::staticFunctions):
1589         * DumpRenderTree/TestRunner.h:
1590         (TestRunner):
1591         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1592         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1593         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1594         * DumpRenderTree/mac/TestRunnerMac.mm:
1595         * DumpRenderTree/qt/TestRunnerQt.cpp:
1596         * DumpRenderTree/qt/TestRunnerQt.h:
1597         (TestRunner):
1598         * DumpRenderTree/win/TestRunnerWin.cpp:
1599         * DumpRenderTree/wx/TestRunnerWx.cpp:
1600         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1601         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1602         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1603         (TestRunner):
1604
1605 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
1606
1607         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
1608         https://bugs.webkit.org/show_bug.cgi?id=110943
1609
1610         Reviewed by Yury Semikhatsky.
1611
1612         Unfortunately in many cases raw pointer may point to an object that has been deleted.
1613         There is no working solution to solve this problem in general.
1614         It could be solved only on case by case basis.
1615
1616         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1617         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
1618         (TestWebKitAPI::TEST):
1619
1620 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
1621
1622         Move markerTextForListItem from TestRunner to Internals
1623         https://bugs.webkit.org/show_bug.cgi?id=110939
1624
1625         Reviewed by Benjamin Poulain.
1626
1627         * DumpRenderTree/TestRunner.cpp:
1628         (TestRunner::staticFunctions):
1629         * DumpRenderTree/TestRunner.h:
1630         (TestRunner):
1631         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1632         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1633         (WebTestRunner::TestRunner::TestRunner):
1634         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1635         (TestRunner):
1636         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1637         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1638         * DumpRenderTree/mac/TestRunnerMac.mm:
1639         * DumpRenderTree/qt/TestRunnerQt.cpp:
1640         * DumpRenderTree/qt/TestRunnerQt.h:
1641         (TestRunnerQt):
1642         * DumpRenderTree/win/TestRunnerWin.cpp:
1643         * DumpRenderTree/wx/TestRunnerWx.cpp:
1644         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1645         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1646         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1647         (TestRunner):
1648
1649 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1650
1651         Don't use legacy test names when returning results from PerfTest.run
1652         https://bugs.webkit.org/show_bug.cgi?id=111148
1653
1654         Reviewed by Dirk Pranke.
1655
1656         * Scripts/webkitpy/performance_tests/perftest.py:
1657         (PerfTestMetric.name): Renamed from metric.
1658         (PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
1659         (PerfTest.run): Use metric name instead of the legacy name to store iteration values.
1660         (ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
1661
1662         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1663         (TestPerfTestMetric.test_init_set_time_metric):
1664         (TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
1665         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1666         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1667
1668         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1669         (PerfTestsRunner.__init__):
1670         (PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
1671         to obtain the trac URL instead of hard coding it.
1672         (PerfTestsRunner._run_tests_set):
1673
1674 2013-03-01  Roger Fong  <roger_fong@apple.com>
1675
1676         Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
1677         https://bugs.webkit.org/show_bug.cgi?id=111202
1678
1679         This is useful for running VCExpress builds from command line because there is
1680         no unified solution output, only per project build logs.
1681         The project will be run as the last project in the solution.
1682
1683         * win/AssembleBuildLogs: Added.
1684         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
1685         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
1686         * win/AssembleBuildLogs/AssembleLogs.cmd: Added.
1687         * win/AssembleBuildLogs/README: Added.
1688
1689 2013-03-01  Roger Fong  <roger_fong@apple.com>
1690
1691         Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
1692
1693         * EWSTools/start-queue-win.sh:
1694
1695 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1696
1697         Don't return statistics in PerfTest.run
1698         https://bugs.webkit.org/show_bug.cgi?id=111145
1699
1700         Reviewed by Dirk Pranke.
1701
1702         Simply return a list of values obtained in each iteration from PerfTest.run.
1703         Also simplify various methods as needed.
1704
1705         * Scripts/webkitpy/performance_tests/perftest.py:
1706         (PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
1707         as needed from PerfTestsRunner._generate_results_dict.
1708
1709         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
1710         that we don't have to worry about the backward compatibility here.
1711
1712         (PerfTestMetric.iteration_values): Added.
1713         (PerfTestMetric.unit): Added.
1714         (PerfTestMetric.metric_to_unit):
1715         (PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
1716
1717         (PerfTest.run):
1718         (PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
1719
1720         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1721         (TestPerfTestMetric.test_init_set_missing_unit):
1722         (TestPerfTestMetric.test_init_set_time_metric): Added.
1723         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
1724         (TestPerfTestMetric.test_append):
1725         (TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
1726         test cases and it's not critical to keep math right as they're not used in output JSON anymore.
1727         (TestPerfTest._assert_results_are_correct):
1728         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1729         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1730
1731         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1732         (PerfTestsRunner._generate_results_dict):
1733
1734         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1735         (EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
1736         (SomeParserTestData): Ditto.
1737         (MemoryTestData): Ditto.
1738
1739 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1740
1741         [Qt] Enable LINK_PREFETCH
1742         https://bugs.webkit.org/show_bug.cgi?id=111158
1743
1744         Reviewed by Simon Hausmann.
1745
1746         * qmake/mkspecs/features/features.pri:
1747
1748 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1749
1750         [Qt] Update features.pri with new features
1751         https://bugs.webkit.org/show_bug.cgi?id=111157
1752
1753         Reviewed by Jocelyn Turcotte.
1754
1755         * qmake/mkspecs/features/features.pri:
1756
1757 2013-03-01  Jochen Eisinger  <jochen@chromium.org>
1758
1759         [chromium] put WebTestProxy::scheduleComposite back in place
1760         https://bugs.webkit.org/show_bug.cgi?id=111146
1761
1762         Reviewed by Nico Weber.
1763
1764         The call was removed in http://trac.webkit.org/changeset/144398 because
1765         DRT doesn't need it. However, content shell depends on this call.
1766
1767         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1768         (WebTestRunner::WebTestProxy::scheduleComposite):
1769
1770 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1771
1772         Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
1773         https://bugs.webkit.org/show_bug.cgi?id=111142
1774
1775         Reviewed by Adam Barth.
1776
1777         Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
1778
1779         Also removed _print_status since it's never used anywhere.
1780
1781         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1782         (PerfTestsRunner.run):
1783         (PerfTestsRunner._run_tests_set):
1784         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1785         (MainTest.run_test):
1786         (MainTest.test_run_test_set):
1787         (MainTest.test_run_test_set_kills_drt_per_run):
1788         (MainTest.test_run_test_set_for_parser_tests):
1789
1790 2013-02-28  Kiran Muppala  <cmuppala@apple.com>
1791
1792         Disable window occlusion detection for WebKitTestRunner Web View on Mac
1793         https://bugs.webkit.org/show_bug.cgi?id=111116
1794
1795         Reviewed by Simon Fraser.
1796
1797         Window occlusion notifications were causing WebKitTestRunner's Web View
1798         to be detected as occluded and causing a few JavaScript timer layout
1799         tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
1800         by initializing the page visibility to "visible" after creating the view.
1801         But a better solution is to disable window occlusion detection, so that
1802         not only the page but also the view is treated as visible.
1803
1804         * WebKitTestRunner/TestController.cpp:
1805         (WTR::TestController::createWebViewWithOptions): Remove call to
1806         setVisibilityState, since it is no longer necessary.
1807         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1808         (WTR::PlatformWebView::PlatformWebView): Disable window occlusion
1809         detection for the created WKView.
1810
1811 2013-02-28  Li Yin  <li.yin@intel.com>
1812
1813         [chromium] Events can't be triggered on MediaStreamTrack
1814         https://bugs.webkit.org/show_bug.cgi?id=110930
1815
1816         Reviewed by Kentaro Hara.
1817
1818         Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
1819
1820         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
1821         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
1822
1823 2013-02-27  James Robinson  <jamesr@chromium.org>
1824
1825         [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
1826         https://bugs.webkit.org/show_bug.cgi?id=111017
1827
1828         Reviewed by Adam Barth.
1829
1830         This decouples DumpRenderTree from WebLayerTreeViewClient.
1831
1832         * DumpRenderTree/chromium/WebViewHost.cpp:
1833         (WebViewHostDRTLayerTreeViewClient):
1834         (WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
1835         (WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
1836         (WebViewHostDRTLayerTreeViewClient::Layout):
1837         (WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
1838         (WebViewHost::initializeLayerTreeView):
1839         * DumpRenderTree/chromium/WebViewHost.h:
1840         (webkit_support):
1841         (WebViewHost):
1842
1843 2013-02-28  Ryuan Choi  <ryuan.choi@samsung.com>
1844
1845         Unreviewed, add my secondary email address to the list.
1846
1847         * Scripts/webkitpy/common/config/committers.py:
1848
1849 2013-02-28  Philip Rogers  <pdr@google.com>
1850
1851         Add Philip Rogers as a reviewer.
1852
1853         Unreviewed update of committers.py.
1854
1855         * Scripts/webkitpy/common/config/committers.py:
1856
1857 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1858
1859         Merge more methods on PerfTest
1860         https://bugs.webkit.org/show_bug.cgi?id=111030
1861
1862         Reviewed by Dirk Pranke.
1863
1864         Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
1865         and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
1866
1867         This makes the control flow a lot more comprehensible.
1868
1869         * Scripts/webkitpy/performance_tests/perftest.py:
1870         (PerfTest._run_with_driver):
1871         (PerfTest._should_ignore_line):
1872         (PerfTest._filter_output):
1873
1874         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1875         (TestPerfTest._assert_results_are_correct):
1876         (test_ignored_stderr_lines):
1877
1878 2013-02-28  Robert Hogan  <robert@webkit.org>
1879
1880         Update my IRC nick
1881
1882         Unreviewed.
1883
1884         * Scripts/webkitpy/common/config/committers.py:
1885
1886 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1887
1888         [Qt] Enable thin archives before parsing the project files
1889
1890         Rubber-stamped by Simon Hausmann.
1891
1892         The targetSubDir() function can be called before default_post.prf has been
1893         parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
1894         which is parsed before the main project file.
1895         This issue was revealed by r144299 and fixes the clean build.
1896
1897         * qmake/mkspecs/features/default_post.prf:
1898         * qmake/mkspecs/features/default_pre.prf:
1899
1900 2013-02-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1901
1902         [Qt] Enable CANVAS_PATH flag
1903         https://bugs.webkit.org/show_bug.cgi?id=108508
1904
1905         Reviewed by Simon Hausmann.
1906
1907         Also enable CANVAS_PATH flag for Qt.
1908
1909         * qmake/mkspecs/features/features.pri:
1910
1911 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1912
1913         [Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
1914
1915         Rubber-stamped by Csaba Osztrogonác.
1916
1917         Besides suppressing a warning about the non-existing function this
1918         fixes the build if there is a subdirectory (eg. debug-and-release).
1919
1920         * TestWebKitAPI/InjectedBundle.pri:
1921         * TestWebKitAPI/TestWebKitAPI.pri:
1922
1923 2013-02-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1924
1925         [EFL][WTR] WTR cannot load injected bundle
1926         https://bugs.webkit.org/show_bug.cgi?id=111063
1927
1928         Reviewed by Csaba Osztrogonác.
1929
1930         WTR was not able to load injected bundle because of undefined 
1931         symbols for AccessibilityUIElement::scrollToMakeVisible(). 
1932         Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
1933         solves the problem.
1934
1935         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1936         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1937
1938 2013-02-28  Alberto Garcia  <albgarcia@rim.com>
1939
1940         [BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
1941         https://bugs.webkit.org/show_bug.cgi?id=110464
1942
1943         Reviewed by Rob Buis.
1944
1945         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1946
1947 2013-02-28  Xan Lopez  <xlopez@rim.com>
1948
1949         [BlackBerry] DumpRenderTreeSupport: update the set position methods
1950         https://bugs.webkit.org/show_bug.cgi?id=110578
1951
1952         Reviewed by Rob Buis.
1953
1954         TestRunner::setMockGeolocationPosition() changed in r130416:
1955         http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
1956
1957         DumpRenderTreeSupport::setMockGeolocationError() was renamed to
1958         setMockGeolocationPositionUnavailableError() in r129444:
1959         http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
1960
1961         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1962         (TestRunner::setMockGeolocationPosition):
1963         (TestRunner::setMockGeolocationPositionUnavailableError):
1964
1965 2013-02-28  Xan Lopez  <xlopez@rim.com>
1966
1967         [BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
1968         https://bugs.webkit.org/show_bug.cgi?id=110465
1969
1970         Reviewed by Rob Buis.
1971
1972         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1973         (LoadItem::invoke):
1974
1975 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1976
1977         PerfTestRunner doesn't need _needs_http and _has_http_lock
1978         https://bugs.webkit.org/show_bug.cgi?id=111037
1979
1980         Reviewed by Adam Barth.
1981
1982         Delete these variables in favor of using a local variable.
1983
1984         Member variables are like global variables. They introduce implicit dependencies
1985         between member functions.
1986
1987         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1988         (PerfTestsRunner.__init__):
1989         (PerfTestsRunner._start_http_servers):
1990         (PerfTestsRunner):
1991         (PerfTestsRunner._stop_http_servers):
1992         (PerfTestsRunner.run):
1993
1994 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1995
1996         Unreviewed, rolling out r144224.
1997         http://trac.webkit.org/changeset/144224
1998         https://bugs.webkit.org/show_bug.cgi?id=111045
1999
2000         Caused plugins/pass-different-npp-struct.html to time out
2001         (Requested by abarth on #webkit).
2002
2003         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2004         (PassDifferentNPPStruct::NPP_SetWindow):
2005         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2006         (NPP_SetWindow):
2007
2008 2013-02-27  Adam Barth  <abarth@webkit.org>
2009
2010         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
2011         https://bugs.webkit.org/show_bug.cgi?id=110907
2012
2013         Reviewed by Eric Seidel.
2014
2015         This patch changes --enable-threaded-html-parser into
2016         --disable-threaded-html-parser and thereby enables the threaded HTML
2017         parser by default for the Chromium port.
2018
2019         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2020         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2021         (WebTestRunner::WebPreferences::reset):
2022         * DumpRenderTree/chromium/TestShell.cpp:
2023         (TestShell::TestShell):
2024
2025 2013-02-27  Kiran Muppala  <cmuppala@apple.com>
2026
2027         Initialize page visibility after creating WebKitTestRunner WebView on Mac
2028         https://bugs.webkit.org/show_bug.cgi?id=111025
2029
2030         Reviewed by Simon Fraser.
2031
2032         Set page visibility to "visible" after creating WebView to override
2033         visibility state inferred from window occlusion notifications on Mac.
2034
2035         * WebKitTestRunner/TestController.cpp:
2036         (WTR::TestController::createWebViewWithOptions): Add call to
2037         setVisibilityState.
2038
2039 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2040
2041         Merge PageLoadingPerfTest into ReplayPerfTest
2042         https://bugs.webkit.org/show_bug.cgi?id=111027
2043
2044         Reviewed by Dirk Pranke.
2045
2046         Merged two classes.
2047
2048         We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
2049         part of ReplayPerfTest.
2050
2051         * Scripts/webkitpy/performance_tests/perftest.py:
2052         (ReplayPerfTest): Moved _FORCE_GC_FILE here.
2053         (ReplayPerfTest.__init__):
2054         (ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
2055         (ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
2056         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2057         (TestReplayPerfTest):
2058         (TestReplayPerfTest.test_run_single.run_test):
2059         (TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
2060         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
2061         TestPageLoadingPerfTest.test_run.
2062         (TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
2063         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
2064         TestPageLoadingPerfTest.test_run_with_memory_output
2065         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
2066         (TestReplayPerfTest.test_prepare_calls_run_single):
2067
2068 2013-02-27  Eric Seidel  <eric@webkit.org>
2069
2070         Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
2071         https://bugs.webkit.org/show_bug.cgi?id=111021
2072
2073         Reviewed by Dirk Pranke.
2074
2075         The underlying code (which is shared with run-webkit-tests)
2076         already knew how to support this option, it just wasn't exposed
2077         via the run-perf-tests front-end.  This patch fixes that.
2078
2079         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2080         (PerfTestsRunner._parse_args):
2081
2082 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2083
2084         Stop uploading results to webkit-perf.appspot.com
2085         https://bugs.webkit.org/show_bug.cgi?id=110954
2086
2087         Reviewed by Benjamin Poulain.
2088
2089         Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
2090
2091         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2092         (RunAndUploadPerfTests):
2093
2094 2013-02-27  James Simonsen  <simonjam@chromium.org>
2095
2096         [chromium] Lower priority of preloaded images
2097         https://bugs.webkit.org/show_bug.cgi?id=110527
2098
2099         Plumb the didChangePriority signal into DRT so it can be tested.
2100
2101         Reviewed by Nate Chapin.
2102
2103         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2104         (WebKit):
2105         (WebTestRunner::WebTestProxy::didChangeResourcePriority):
2106         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2107         (WebTestRunner::TestRunner::TestRunner):
2108         (WebTestRunner::TestRunner::reset):
2109         (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
2110         (WebTestRunner):
2111         (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
2112         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2113         (TestRunner):
2114         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2115         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
2116         (WebTestRunner::WebTestProxyBase::willSendRequest):
2117         (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
2118         (WebTestRunner):
2119
2120 2013-02-27  Chris Fleizach  <cfleizach@apple.com>
2121
2122         AX: Mac platform should support ability to scroll an element into visible
2123         https://bugs.webkit.org/show_bug.cgi?id=109860
2124
2125         Reviewed by Beth Dakin.
2126
2127         * DumpRenderTree/AccessibilityUIElement.cpp:
2128         (scrollToMakeVisibleCallback):
2129         (AccessibilityUIElement::getJSClass):
2130         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2131         (AccessibilityUIElement::scrollToMakeVisible):
2132         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2133         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2134         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2135         (AccessibilityUIElement):
2136         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2137         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2138         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2139         (WTR):
2140
2141 2013-02-27  John Bauman  <jbauman@chromium.org>
2142
2143         Plugin in iframe may not display
2144         https://bugs.webkit.org/show_bug.cgi?id=109879
2145
2146         Reviewed by Simon Fraser.
2147
2148         LogNPPSetWindow will be used with other ports as well.
2149
2150         * DumpRenderTree/DumpRenderTree.gypi:
2151         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2152
2153 2013-02-27  Jochen Eisinger  <jochen@chromium.org>
2154
2155         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2156         https://bugs.webkit.org/show_bug.cgi?id=110973
2157
2158         Reviewed by Adam Barth.
2159
2160         There is nothing that ensures that the log messages from the plugin
2161         come in before the layout test finished loading.
2162
2163         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2164         (PassDifferentNPPStruct::NPP_SetWindow):
2165         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2166         (NPP_SetWindow):
2167
2168 2013-02-27  Glenn Adams  <glenn@skynav.com>
2169
2170         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
2171         https://bugs.webkit.org/show_bug.cgi?id=110944
2172
2173         Reviewed by Dean Jackson.
2174
2175         * Scripts/webkitperl/FeatureList.pm:
2176         * qmake/mkspecs/features/features.pri:
2177
2178 2013-02-27  Yong Li  <yong.li.webkit@outlook.com>
2179
2180         Unreviewed. Remove myself from watchlist.
2181
2182         * Scripts/webkitpy/common/config/watchlist:
2183
2184 2013-02-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2185
2186         Switch QtWebKit to GStreamer 1.0.
2187         https://bugs.webkit.org/show_bug.cgi?id=106669.
2188
2189         Original patch by Sebastian Dröge.
2190         Reviewed by Csaba Osztrogonác.
2191
2192         Build with GStreamer 1.0 if available, but support GStreamer 0.10 
2193         temporarily to make upgrading easy and the patch suitable for Qt5.
2194
2195         * qmake/mkspecs/features/features.prf:
2196
2197 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
2198
2199         Unreviewed. Added myself to committers.py
2200
2201         * Scripts/webkitpy/common/config/committers.py:
2202
2203 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2204
2205         Unreviewed, rolling out r144192.
2206         http://trac.webkit.org/changeset/144192
2207         https://bugs.webkit.org/show_bug.cgi?id=110984
2208
2209         Stored svn password on wrong computer (Requested by kkristof
2210         on #webkit).
2211
2212         * Scripts/webkitpy/common/config/committers.py:
2213
2214 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
2215
2216         Unreviewed. Added myself to committers.py
2217
2218         * Scripts/webkitpy/common/config/committers.py:
2219
2220 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2221
2222         Build fix after r144155. The report page is located at /api/report, not /api/test/report.
2223
2224         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2225         (PerfTestsRunner._upload_json):
2226
2227 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2228
2229         Stop uploading results to webkit-perf.appspot.com
2230         https://bugs.webkit.org/show_bug.cgi?id=110954
2231
2232         Reviewed by Benjamin Poulain.
2233
2234         When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
2235         Also, always use the new JSON format. Removed the code to generate the old format.
2236
2237         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2238         (PerfTestsRunner._generate_and_show_results):
2239         (PerfTestsRunner._generate_results_dict):
2240         (PerfTestsRunner._merge_slave_config_json):
2241         (PerfTestsRunner._generate_output_files):
2242
2243 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2244
2245         Unreviewed, rolling out r144136, r144143, and r144147.
2246         http://trac.webkit.org/changeset/144136
2247         http://trac.webkit.org/changeset/144143
2248         http://trac.webkit.org/changeset/144147
2249         https://bugs.webkit.org/show_bug.cgi?id=110950
2250
2251         Caused some timeouts and flaky crashes (Requested by abarth on
2252         #webkit).
2253
2254         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2255         (main):
2256         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2257         (WebTestRunner::WebPreferences::reset):
2258         * DumpRenderTree/chromium/TestShell.cpp:
2259         (TestShell::TestShell):
2260
2261 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2262
2263         Use perf.webkit.org JSON format in results page
2264         https://bugs.webkit.org/show_bug.cgi?id=110842
2265
2266         Reviewed by Benjamin Poulain.
2267
2268         Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
2269
2270         A whole bunch of integration tests have been updated to use the new JSON format.
2271
2272         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2273         (PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
2274         and legacy_output_json_path respectively.
2275         (PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
2276         (PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
2277         JSON file and the results page out of perf_webkit_output instead of legacy_output.
2278
2279         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2280         (MainTest.test_run_memory_test):
2281         (MainTest._test_run_with_json_output.mock_upload_json):
2282         (MainTest):
2283         (MainTest.test_run_with_json_output):
2284         (MainTest.test_run_with_description):
2285         (MainTest.test_run_generates_json_by_default):
2286         (MainTest.test_run_merges_output_by_default):
2287         (MainTest.test_run_respects_reset_results):
2288         (MainTest.test_run_generates_and_show_results_page):
2289         (MainTest.test_run_with_slave_config_json):
2290         (MainTest.test_run_with_multiple_repositories):
2291         (MainTest.test_run_with_upload_json):
2292         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
2293
2294 2013-02-26  Adam Barth  <abarth@webkit.org>
2295
2296         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
2297         https://bugs.webkit.org/show_bug.cgi?id=110907
2298
2299         Reviewed by Eric Seidel.
2300
2301         This patch changes --enable-threaded-html-parser into
2302         --disable-threaded-html-parser and thereby enables the threaded HTML
2303         parser by default for the Chromium port.
2304
2305         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2306         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2307         (WebTestRunner::WebPreferences::reset):
2308         * DumpRenderTree/chromium/TestShell.cpp:
2309         (TestShell::TestShell):
2310
2311 2013-02-26  Dirk Pranke  <dpranke@chromium.org>
2312
2313         [chromium] Re-enable the fixed version of freetype on linux
2314         https://bugs.webkit.org/show_bug.cgi?id=110542
2315
2316         Reviewed by Tony Chang.
2317
2318         Re-land the change in r143794 to switch to building with a fixed
2319         version of FreeType for just DumpRenderTree. This allows us to share
2320         one version of pixel baselines for both Lucid and Precise, and run the
2321         layout tests in a stock Precise install (instead of a Lucid chroot).
2322         Going forward, this approach isolates us from os-level changes to the
2323         version of FreeType. Note that Chromium itself still uses the system
2324         FreeType and is unaffected by this change.
2325         
2326         This setting can still be turned off (at compile/gyp-time) by
2327         manually setting use_custom_freetype=0.
2328
2329         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2330
2331 2013-02-26  Nico Weber  <thakis@chromium.org>
2332
2333         [chromium] content shell drt: Enable WebKit::setLayoutTestMode()
2334         https://bugs.webkit.org/show_bug.cgi?id=110890
2335
2336         Reviewed by Jochen Eisinger.
2337
2338         Several functions in webkit check that bit to change rendering
2339         in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
2340         disables font smoothing in this mode. TestShell and DRT both set
2341         this flag, so content shell drt should set it too.
2342
2343         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2344         (WebTestRunner::TestInterfaces::TestInterfaces):
2345
2346 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
2347
2348         new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
2349         https://bugs.webkit.org/show_bug.cgi?id=110884
2350
2351         Reviewed by Csaba Osztrogonác.
2352
2353         Adding the missing spaces before ':' in the unit test.
2354
2355         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2356
2357 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
2358
2359         new-commit-bot: Some IRC clients doesn't linkify rollout messages
2360         https://bugs.webkit.org/show_bug.cgi?id=110861
2361
2362         Reviewed by Ryosuke Niwa.
2363
2364         Adding the space before ':' in order to fix the links shown for the rollout message.
2365
2366         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2367         (NewCommitBot._summarize_commit_log):
2368
2369 2013-02-26  Joone Hur  <joone.hur@intel.com>
2370
2371         [GTK] Add Clutter to jhbuild
2372         https://bugs.webkit.org/show_bug.cgi?id=110245
2373
2374         Reviewed by Martin Robinson.
2375
2376         Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
2377         This allows to build WebKitGtk+ with clutter as an acceleration backend
2378         within the jhbuild environment. 
2379
2380         * gtk/jhbuild-optional.modules:
2381
2382 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2383
2384         Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
2385
2386         * Scripts/webkitpy/common/checkout/scm/svn.py:
2387         (SVN.value_from_svn_info):
2388
2389 2013-02-25  Alan Cutter  <alancutter@chromium.org>
2390
2391         GCE EWS bots failing intermittently on HTTP 502 error while updating their status
2392         https://bugs.webkit.org/show_bug.cgi?id=110845
2393
2394         Unreviewed EWS bot fix.
2395
2396         Switch the Queue Status Server address the EWS bots use to a more direct URL that
2397         doesn't seem to be having problems from GCE like queues.webkit.org.
2398
2399         * Scripts/webkitpy/common/net/statusserver.py:
2400         (StatusServer):
2401
2402 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
2403
2404         Forgot to delete a no-longer-needed unit test after r143980.
2405
2406         Unreviewed, build fix.
2407
2408         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2409         (ChromiumWinTest.test_path_to_image_diff):
2410
2411 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2412
2413         Build fix. run-perf-tests was reporting with revision numbers ending with \r.
2414         Don't include \r at the end of svn info lines on Windows.
2415
2416         This is similar to r143839.
2417
2418         * Scripts/webkitpy/common/checkout/scm/svn.py:
2419         (SVN.value_from_svn_info):
2420
2421 2013-02-25  James Simonsen  <simonjam@chromium.org>
2422
2423         [Resource Timing] Update test suite so it can be exported to the W3C
2424         https://bugs.webkit.org/show_bug.cgi?id=107343
2425
2426         Reviewed by Tony Gentilcore.
2427
2428         * Scripts/export-w3c-performance-wg-tests: Clean up output.
2429         * Scripts/import-w3c-performance-wg-tests:
2430
2431 2013-02-25  Anders Carlsson  <andersca@apple.com>
2432
2433         Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
2434         https://bugs.webkit.org/show_bug.cgi?id=110821
2435         <rdar://problem/13265303>
2436
2437         Reviewed by Beth Dakin.
2438
2439         Update for WebKit2 changes.
2440
2441         * MiniBrowser/mac/WK2BrowserWindowController.m:
2442         (-[WK2BrowserWindowController awakeFromNib]):
2443         * WebKitTestRunner/TestController.cpp:
2444         (WTR::TestController::createOtherPage):
2445         (WTR::TestController::createWebViewWithOptions):
2446         (WTR::TestController::unavailablePluginButtonClicked):
2447         * WebKitTestRunner/TestController.h:
2448         (TestController):
2449
2450 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
2451
2452         Optionally partition cache to prevent using cache for tracking
2453         https://bugs.webkit.org/show_bug.cgi?id=110269
2454
2455         Reviewed by Maciej Stachowiak.
2456
2457         Add test suite for public suffix functions on Mac.
2458
2459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2460         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
2461         (TestWebKitAPI):
2462         (TestWebKitAPI::TEST_F):
2463
2464 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
2465
2466         nrwt: reenable multiple http shards on chromium win
2467         https://bugs.webkit.org/show_bug.cgi?id=110814
2468
2469         Reviewed by Tony Chang.
2470
2471         The underlying bug in DumpRenderTree that was causing us to look for a
2472         pac file and timeout under load was fixed a while ago.
2473
2474         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2475         (ChromiumWinPort.relative_test_filename):
2476
2477 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
2478
2479         Make ninja the default w/ build-webkit --chromium on windows.
2480         https://bugs.webkit.org/show_bug.cgi?id=110731
2481
2482         Unreviewed - TBR'ing thakis :).
2483
2484         * Scripts/update-webkit-chromium:
2485
2486 2013-02-25  Anders Carlsson  <andersca@apple.com>
2487
2488         Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
2489         https://bugs.webkit.org/show_bug.cgi?id=110793
2490         <rdar://problem/13265303>
2491
2492         Reviewed by Sam Weinig.
2493
2494         Update for WebKit2 API changes.
2495
2496         * MiniBrowser/mac/WK2BrowserWindowController.m:
2497         (-[WK2BrowserWindowController awakeFromNib]):
2498         * WebKitTestRunner/TestController.cpp:
2499         (WTR::TestController::createWebViewWithOptions):
2500
2501 2013-02-25  Nico Weber  <thakis@chromium.org>
2502
2503         Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
2504         https://bugs.webkit.org/show_bug.cgi?id=110775
2505
2506         Unreviewed, basically a rebaseline.
2507
2508         * Scripts/webkitpy/common/config/watchlist:
2509
2510 2013-02-25  Nico Weber  <thakis@chromium.org>
2511
2512         [chromium] Try to get the webkit builder to use msvs again
2513         https://bugs.webkit.org/show_bug.cgi?id=110771
2514
2515         Reviewed by Eric Seidel.
2516
2517         The msvs gyp generator apparently doesn't write the sln file on every
2518         run, so check the vcxproj file instead.
2519
2520         * Scripts/webkitdirs.pm:
2521         (determineIsChromiumNinja):
2522
2523 2013-02-25  Nico Weber  <thakis@chromium.org>
2524
2525         [chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
2526         https://bugs.webkit.org/show_bug.cgi?id=110767
2527
2528         Reviewed by Eric Seidel.
2529
2530         The tester runs gyp, which generates out/Release/build.ninja. The bot
2531         scripts use existence (and timestamp) of that file to decide if the
2532         current build is supposed to be ninja or xcodebuild. The file exists,
2533         so the snapshot is extracted to out/Release. The snapshot doesn't
2534         contain build.ninja however due to
2535         http://trac.webkit.org/changeset/140375 , so after extracting the
2536         snapshot the scripts think that this is an xcodebuild build. So remove
2537         the part of that revision that removed ninja files from the archive,
2538         and the bots should be happy again.
2539
2540         * BuildSlaveSupport/built-product-archive:
2541         (archiveBuiltProduct):
2542
2543 2013-02-25  Nico Weber  <thakis@chromium.org>
2544
2545         Fix tests after r143910
2546         https://bugs.webkit.org/show_bug.cgi?id=110757
2547
2548         Reviewed by Andreas Kling.
2549
2550         While here, also add a test for the bug r143910 fixed.
2551
2552         * Scripts/webkitpy/common/system/executive_unittest.py:
2553         (ScriptErrorTest.test_message_with_output):
2554         (ScriptErrorTest):
2555         (ScriptErrorTest.test_message_with_tuple):
2556
2557 2013-02-25  Nico Weber  <thakis@chromium.org>
2558
2559         [chromium] Apparently built-product-archive is written in Python, not Perl :-/
2560         https://bugs.webkit.org/show_bug.cgi?id=110755
2561
2562         Reviewed by Jochen Eisinger.
2563
2564         * BuildSlaveSupport/built-product-archive:
2565         (archiveBuiltProduct):
2566         (extractBuiltProduct):
2567
2568 2013-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2569
2570         Unreviewed, rolling out r143895.
2571         http://trac.webkit.org/changeset/143895
2572         https://bugs.webkit.org/show_bug.cgi?id=110758
2573
2574         broke a bunch of tests (Requested by thakis__ on #webkit).
2575
2576         * Scripts/update-webkit-chromium:
2577
2578 2013-02-25  Andreas Kling  <akling@apple.com>
2579
2580         Unreviewed, fix simple mistake in r143903.
2581         <http://webkit.org/b/110746>
2582
2583         Reviewed by Andreas Kling.
2584
2585         Pass git revision, not svn revision, to git shell command.
2586
2587         * Scripts/webkitpy/common/checkout/scm/git.py:
2588         (Git.timestamp_of_latest_commit):
2589
2590 2013-02-25  Nico Weber  <thakis@chromium.org>
2591
2592         [chromium] Let built-product-archive log which directory it's archiving from and extracting to
2593         https://bugs.webkit.org/show_bug.cgi?id=110748
2594
2595         Reviewed by Jochen Eisinger.
2596
2597         One of the mac testers runs DRT from out/ but WebKitUnitTests from
2598         xcodebuild. I'm trying to understand what's going on.
2599
2600         * BuildSlaveSupport/built-product-archive:
2601         (archiveBuiltProduct):
2602         (extractBuiltProduct):
2603
2604 2013-02-23  Ilya Tikhonovsky  <loislo@chromium.org>
2605
2606         Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
2607         https://bugs.webkit.org/show_bug.cgi?id=110599
2608
2609         Reviewed by Yury Semikhatsky.
2610
2611         Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
2612         that were given us via MemoryInstrumentation calls.
2613         So I extended client api with registerString method that pushes the strings
2614         down to the serializer.
2615
2616         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2617         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
2618         (TestWebKitAPI::Helper::Helper):
2619         (Helper):
2620         (TestWebKitAPI::Helper::addNode):
2621         (TestWebKitAPI::TEST):
2622
2623 2013-02-25  Nico Weber  <thakis@chromium.org>
2624
2625         Make ScriptError not crash when args is a tuple
2626         https://bugs.webkit.org/show_bug.cgi?id=110747
2627
2628         Reviewed by Jochen Eisinger.
2629
2630         I'm trying to understand the error on
2631         http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
2632         better. I'll likely have to revert the ninja switch on windows, but
2633         having error reporting code that doesn't itself crash sounds like a
2634         good thing to have anyways.
2635
2636         The problem is that '%s' % (1, 2) errors out, and args is sometimes a
2637         tuple not a list.
2638
2639         * Scripts/run-chromium-webkit-unit-tests:
2640         * Scripts/webkitpy/common/system/executive.py:
2641         (ScriptError.__init__):
2642
2643 2013-02-25  Laszlo Gombos  <l.gombos@samsung.com>
2644
2645         [EFL] Align feature defaults
2646         https://bugs.webkit.org/show_bug.cgi?id=110715
2647
2648         Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
2649         OptionsEfl.cmake.
2650
2651         Reviewed by Gyuyoung Kim.
2652
2653         * Scripts/webkitperl/FeatureList.pm:
2654
2655 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2656
2657         run-perf-tests reports wrong commit time
2658         https://bugs.webkit.org/show_bug.cgi?id=110746
2659
2660         Reviewed by Andreas Kling.
2661
2662         The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
2663         of when the subdirectory was last modified.
2664
2665         Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
2666         insufficient since running "svn log -r <revision>" on a partial checkout only returns
2667         an empty result if the revision didn't modify the subdirectory.
2668
2669         For git, there is no partial checkout, so we just need to pass in "-r" option to keep
2670         the interface compatible with svn.
2671
2672         * Scripts/webkitpy/common/checkout/scm/git.py:
2673         (Git.timestamp_of_latest_commit):
2674         * Scripts/webkitpy/common/checkout/scm/scm.py:
2675         (SCM.timestamp_of_latest_commit):
2676         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2677         (MockSCM.timestamp_of_latest_commit):
2678         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2679         (test_timestamp_of_latest_commit):
2680         * Scripts/webkitpy/common/checkout/scm/svn.py:
2681         (SVN.timestamp_of_latest_commit):
2682         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2683         (PerfTestsRunner._generate_results_dict):
2684
2685 2013-02-25  Jochen Eisinger  <jochen@chromium.org>
2686
2687         [chromium] move WebRuntimeFeatures configuration to TestRunner library
2688         https://bugs.webkit.org/show_bug.cgi?id=110712
2689
2690         Reviewed by Nico Weber.
2691
2692         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2693         (WebTestRunner::TestInterfaces::TestInterfaces):
2694         * DumpRenderTree/chromium/TestShell.cpp:
2695         (TestShell::TestShell):
2696
2697 2013-02-25  Nico Weber  <thakis@chromium.org>
2698
2699         Make ninja the default build system for build-webkit --chromium on windows
2700         https://bugs.webkit.org/show_bug.cgi?id=110731
2701
2702         Reviewed by Jochen Eisinger.
2703
2704         With http://crbug.com/169945 fixed, this should now work.
2705
2706         * Scripts/update-webkit-chromium:
2707
2708 2013-02-24  Gustavo Noronha Silva  <gns@gnome.org>
2709
2710         [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
2711         https://bugs.webkit.org/show_bug.cgi?id=110702
2712
2713         Reviewed by Martin Robinson.
2714
2715         * GtkLauncher/main.c: include autotoolsconfig.h.
2716         * Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
2717         the include ordering check, since it uses autotoolsconfig.h which needs to
2718         come first.
2719
2720 2013-02-24  Hajime Morrita  <morrita@google.com>
2721
2722         [Custom Elements] Implement bare-bone document.register()
2723         https://bugs.webkit.org/show_bug.cgi?id=100229
2724
2725         Reviewed by Adam Barth.
2726
2727         Added enableCustomDOMElements flag.
2728
2729         * DumpRenderTree/chromium/TestShell.cpp:
2730         (TestShell::TestShell):
2731
2732 2013-02-23  Mark Pilgrim  <pilgrim@chromium.org>
2733
2734         [Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
2735         https://bugs.webkit.org/show_bug.cgi?id=110606
2736
2737         Reviewed by Adam Barth.
2738
2739         Part of a larger refactoring series; see tracking bug 82948.
2740
2741         * DumpRenderTree/DumpRenderTree.gypi:
2742         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2743         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
2744         (WebKitSupportTestEnvironment::mockPlatform):
2745         (WebKitSupportTestEnvironment):
2746         * DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
2747         (MockPlatform::create):
2748         (MockPlatform::MockPlatform):
2749         (MockPlatform::~MockPlatform):
2750         (MockPlatform::setInterfaces):
2751         (MockPlatform::cryptographicallyRandomValues):
2752         (MockPlatform::createMediaStreamCenter):
2753         (MockPlatform::createRTCPeerConnectionHandler):
2754         * DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
2755         (MockPlatform):
2756         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
2757         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
2758         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2759         (WebTestDelegate):
2760         * DumpRenderTree/chromium/TestShell.cpp:
2761         (TestShell::initialize):
2762         * DumpRenderTree/chromium/TestShell.h:
2763         (TestShell):
2764
2765 2013-02-23  Ryosuke Niwa  <rniwa@webkit.org>
2766
2767         Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
2768
2769         * Scripts/webkitpy/common/checkout/scm/svn.py:
2770         (SVN.timestamp_of_latest_commit):
2771
2772 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
2773
2774         Move setAutofilled from TestRunner to WebCore
2775         https://bugs.webkit.org/show_bug.cgi?id=110521
2776
2777         Reviewed by Benjamin Poulain.
2778
2779         * DumpRenderTree/TestRunner.cpp:
2780         (TestRunner::staticFunctions):
2781         * DumpRenderTree/TestRunner.h:
2782         (TestRunner):
2783         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2784         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2785         (WebTestRunner::TestRunner::TestRunner):
2786         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2787         (TestRunner):
2788         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2789         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2790         * DumpRenderTree/mac/TestRunnerMac.mm:
2791         * DumpRenderTree/qt/TestRunnerQt.cpp:
2792         * DumpRenderTree/qt/TestRunnerQt.h:
2793         (TestRunnerQt):
2794         * DumpRenderTree/win/TestRunnerWin.cpp:
2795         * DumpRenderTree/wx/TestRunnerWx.cpp:
2796
2797 2013-02-22  Ryosuke Niwa  <rniwa@webkit.org>
2798
2799         Upload results to perf.webkit.org in addition to the one specified by --test-results-server
2800         https://bugs.webkit.org/show_bug.cgi?id=108577
2801
2802         Reviewed by Dirk Pranke.
2803
2804         Upload results to perf.webkit.org using new JSON format as well as the host specified by
2805         --test-results-server. The new format is needed to provide extra information perf.webkit.org
2806         need such as the subversion commit time and test URLs. This is a temporarily measure until
2807         we complete the transition and the old JSON format and the code to upload results to
2808         webkit-perf.appspot.com can be deleted.
2809
2810         This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
2811         in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
2812         so that the app can sort performance test results based on the timestamp of the last commit.
2813
2814         It also changes the repository names returned by port objects to be properly capitalized
2815         human readable names such as WebKit instead of lowercased names such as webkit since these names
2816         are displayed on perf.webkit.org for humans. Several users of this feature has been updated
2817         to explicitly lowercase the names.
2818
2819
2820         * Scripts/webkitpy/common/checkout/scm/git.py:
2821         (Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
2822         git's timestamp granularity is seconds so we're losing some information compared to using a regular
2823         subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
2824         UTC so we're going to manually fiddle with timezone.
2825
2826         * Scripts/webkitpy/common/checkout/scm/scm.py:
2827         (SCM.timestamp_of_latest_commit): Added.
2828
2829         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2830         (MockSCM.timestamp_of_latest_commit): Added.
2831
2832         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2833         (test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.
2834
2835         * Scripts/webkitpy/common/checkout/scm/svn.py:
2836         (SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
2837         the timestamp which is always in UTC.
2838
2839         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2840         (JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
2841         'chromium' needs to be substituted by 'chrome' for historical reasons.
2842
2843         * Scripts/webkitpy/layout_tests/port/base.py:
2844         (Port.repository_paths): Return WebKit instead of webkit as noted above.
2845
2846         * Scripts/webkitpy/layout_tests/port/chromium.py:
2847         (ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.
2848
2849         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2850         (PerfTestsRunner.__init__): Store the current time in UTC as well as in local time.
2851         (PerfTestsRunner._collect_tests):
2852
2853         (PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
2854         and upload them appropriately.
2855
2856         (PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
2857         in revisions_for_perf_webkit and construct an output for perf.webkit.org.
2858
2859         (PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.
2860
2861         (PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
2862         and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
2863         e.g. "processor" would be renamed to "builderProcessor".
2864
2865         (PerfTestsRunner._generate_output_files):
2866
2867         (PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
2868         on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
2869         to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
2870         webkit-perf.appspot.com which spits out a plaintext response.
2871
2872         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2873         (MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
2874         (MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
2875         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.
2876
2877         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2878         (MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
2879         cases to parse JSON responses.
2880         (MainTest.test_upload_json.MockFileUploader): Refactored.
2881         (MainTest.test_upload_json.MockFileUploader.reset): Added.
2882         (MainTest.test_upload_json.MockFileUploader.__init__):
2883         (MainTest.test_upload_json.MockFileUploader.upload_single_text_file):
2884
2885 2013-02-22  Roger Fong  <roger_fong@apple.com>
2886
2887         Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.
2888
2889         * BuildSlaveSupport/build.webkit.org-config/config.json:
2890
2891 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2892
2893         Unreviewed, rolling out r143794.
2894         http://trac.webkit.org/changeset/143794
2895         https://bugs.webkit.org/show_bug.cgi?id=110542
2896
2897         debug linux builds broken?
2898
2899         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2900
2901 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2902
2903         [chromium] enable the fixed version of freetype on linux
2904         https://bugs.webkit.org/show_bug.cgi?id=110542
2905
2906         Reviewed by Tony Chang.
2907
2908         Switch to building with a fixed version of FreeType for
2909         just DumpRenderTree. This allows us to share one version
2910         of pixel baselines for both Lucid and Precise, and run
2911         the layout tests in a stock Precise install (instead of a Lucid
2912         chroot). Going forward, this approach isolates us from os-level
2913         changes to the version of FreeType. Note that Chromium itself
2914         still uses the system FreeType and is unaffected by this change.
2915         
2916         This setting can still be turned off (at compile/gyp-time) by
2917         manually setting use_custom_freetype=0.
2918
2919         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2920
2921 2013-02-22  Anders Carlsson  <andersca@apple.com>
2922
2923         Move pluginLoadPolicy to the page loader client
2924         https://bugs.webkit.org/show_bug.cgi?id=110635
2925
2926         Reviewed by Sam Weinig.
2927
2928         * MiniBrowser/mac/WK2BrowserWindowController.m:
2929         (-[WK2BrowserWindowController awakeFromNib]):
2930         * WebKitTestRunner/TestController.cpp:
2931         (WTR::TestController::createOtherPage):
2932         (WTR::TestController::createWebViewWithOptions):
2933
2934 2013-02-22  Kenneth Russell  <kbr@google.com>
2935
2936         Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.
2937
2938         * Scripts/webkitpy/common/config/committers.py:
2939
2940 2013-02-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2941
2942         [WTR] Do not dump information about empty subframes.
2943         https://bugs.webkit.org/show_bug.cgi?id=110585
2944
2945         Reviewed by Simon Fraser.
2946
2947         Follow DumpRenderTree more closely by skipping empty frames
2948         (frames which have no document). We are not really interested in
2949         showing anything about them.
2950
2951         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2952         (WTR::dumpDescendantFramesText): Do not print subframe names when they
2953         have no associated Document.
2954
2955 2013-02-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2956
2957         [EFL][DRT] Do not dump empty frames.
2958         https://bugs.webkit.org/show_bug.cgi?id=110474
2959
2960         Reviewed by Kenneth Rohde Christiansen.
2961
2962         Follow the original Mac implementation more closely by skipping
2963         empty frames (frames which have no document). We are not really
2964         interested in showing anything about them.
2965
2966         * DumpRenderTree/efl/DumpRenderTree.cpp:
2967         (dumpFramesAsText):
2968
2969 2013-02-21  Dirk Pranke  <dpranke@chromium.org>
2970
2971         [chromium] support the lucid version of freetype on precise in DRT
2972         https://bugs.webkit.org/show_bug.cgi?id=107338
2973
2974         Reviewed by Tony Chang.
2975
2976         Modify the DRT build so that we can optionally link against
2977         a fixed version of Freetype2. This allows us to share pixel test
2978         results across multiple versions of Ubuntu without having to
2979         worry about differences in font rendering.
2980
2981         At the moment this feature is off by default. Eventually it will
2982         be on by default on linux.
2983
2984         Note that this only affects DRT; the regular Chromium binary
2985         (and, for now, content_shell) will still use the system version
2986         of Freetype.
2987
2988         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2989
2990 2013-02-21  Rouslan Solomakhin  <rouslan@chromium.org>
2991
2992         [Chromium] Remove the word "cheher" from the list of misspelled words
2993         https://bugs.webkit.org/show_bug.cgi?id=110447
2994
2995         Reviewed by Tony Chang.
2996
2997         Other platforms do not mark "cheher" as a misspelled word in layout tests.
2998         This change is to bring Chromium platform in line with the rest of the
2999         platforms.
3000
3001         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
3002         (WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
3003         (WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
3004         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.
3005
3006 2013-02-21  Jochen Eisinger  <jochen@chromium.org>
3007
3008         [chromium] document WebTestDelegate and WebTestRunner interfaces
3009         https://bugs.webkit.org/show_bug.cgi?id=110472
3010
3011         Reviewed by Adam Barth.
3012
3013         Also remove the default implementation of the remaining WebTestDelegate
3014         methods now that all embedders provide this interface.
3015
3016         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3017         (WebTestDelegate):
3018         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3019         (WebTestRunner):
3020
3021 2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
3022
3023         Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
3024         https://bugs.webkit.org/show_bug.cgi?id=106059
3025
3026         Reviewed by Geoffrey Garen.
3027
3028         Added new tests for the WebKit API portion of the JSC Objective-C API.
3029
3030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3031         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
3032         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
3033         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.
3034         (-[MyConsole log:]):
3035         (-[MyConsole printHelloWorld]):
3036         (-[MyConsole add:to:]):
3037         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
3038         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
3039         (TestWebKitAPI):
3040         (TestWebKitAPI::TEST):
3041
3042 2013-02-21  Stephen Chenney  <schenney@chromium.org>
3043
3044         Unreviewed, add myself as a reviewer
3045
3046         * Scripts/webkitpy/common/config/committers.py:
3047
3048 2013-02-21  Jer Noble  <jer.noble@apple.com>
3049
3050         Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.
3051
3052         * Scripts/webkitpy/common/config/committers.py:
3053         * Scripts/webkitpy/common/config/watchlist:
3054
3055 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
3056
3057         gtk/DumpRenderTree.cpp is missing <locale.h> include
3058         https://bugs.webkit.org/show_bug.cgi?id=109386
3059
3060         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build
3061         by include locale.h when we use setlocale.
3062
3063 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
3064
3065         [GTK] Move feature overriding to the configure phase
3066         https://bugs.webkit.org/show_bug.cgi?id=110293
3067
3068         Reviewed by Gustavo Noronha Silva.
3069
3070         * Scripts/webkitdirs.pm:
3071         (runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
3072         WebKitFeatureOverrides.txt to better match the other filenames used in
3073         the new feature processing.
3074         * gtk/generate-feature-defines-files: Added. A script which takes as an argument
3075         the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
3076         and writes WebKitFeatures.txt and WebKitFeatures.h.
3077         * gtk/override-feature-defines: Removed.
3078
3079 2013-02-21  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3080
3081         [Qt] Remove obsolete DEPENDPATH assignment
3082
3083         Reviewed by Simon Hausmann
3084
3085         qmake now adds CONFIG+=depend_includepath by default, making manual
3086         DEPENDPATH setup unnecessary.
3087
3088         * qmake/mkspecs/features/default_post.prf:
3089
3090 2013-02-20  Vivek Galatage  <vivekg@webkit.org>
3091
3092         Unreviewed. Changing primary email id.
3093
3094         * Scripts/webkitpy/common/config/committers.py:
3095
3096 2013-02-14  James Robinson  <jamesr@chromium.org>
3097
3098         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
3099         https://bugs.webkit.org/show_bug.cgi?id=109634
3100
3101         Reviewed by Adrienne Walker.
3102
3103         * DumpRenderTree/chromium/WebViewHost.cpp:
3104         (WebViewHost::createOutputSurface):
3105         (WebViewHost::initializeLayerTreeView):
3106
3107 2013-02-20  Martin Robinson  <mrobinson@igalia.com>
3108
3109         [GTK] Re-enable 3D CSS transforms when using build-webkit
3110         https://bugs.webkit.org/show_bug.cgi?id=110402
3111
3112         Reviewed by Xan Lopez.
3113
3114         * Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
3115         when building WebKitGTK+.
3116
3117 2013-02-20  Roger Fong  <roger_fong@apple.com>
3118
3119         Get VS2010 Solution B&I ready.
3120         <rdar://problem/1322988>
3121
3122         Rubberstamped by Timothy Horton.        
3123         
3124         Add Production configurations.
3125         
3126         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3127         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3128         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Added.
3129         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3130         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Added.
3131         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3132         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3133         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3134         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Added.
3135         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3136         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Added.
3137         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3138         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3139         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Added.
3140         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3141         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3142         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Added.
3143         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3144         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3145         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3146         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Added.
3147         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3148         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Added.
3149         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3150         * win/record-memory/record-memory.vcxproj:
3151         * win/record-memory/record-memoryProduction.props: Added.
3152         * win/record-memory/record-memoryRelease.props:
3153
3154 2013-02-20  Dirk Schulze  <krit@webkit.org>
3155
3156         Enable CANVAS_PATH flag
3157         https://bugs.webkit.org/show_bug.cgi?id=108508
3158
3159         Reviewed by Simon Fraser.
3160
3161         Enable CANVAS_PATH flag on trunk.
3162
3163         * Scripts/webkitperl/FeatureList.pm:
3164
3165 2013-02-20  Tony Chang  <tony@chromium.org>
3166
3167         Parse author names with commas in ChangeLogs
3168         https://bugs.webkit.org/show_bug.cgi?id=110356
3169
3170         Reviewed by Dirk Pranke.
3171
3172         Paweł's name has a comma in it, which was confusing the ChangeLog parser.
3173
3174         * Scripts/webkitpy/common/checkout/changelog.py:
3175         (ChangeLogEntry): Move name splitting regexp into a constant.
3176         (ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
3177         (ChangeLogEntry._split_reviewer_names): Rename to be more specific.
3178         (ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
3179         (ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
3180         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3181         (test_parse_authors): Test case with Paweł's name.
3182
3183 2013-02-15  Dirk Schulze  <krit@webkit.org>
3184
3185         [Chromium] Add runtime flag for CanvasPath
3186         https://bugs.webkit.org/show_bug.cgi?id=109997
3187
3188         Reviewed by Adam Barth.
3189
3190         Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
3191         the constructor for Path on DOMWindow would never be activatable, since the script
3192         is running after creating the DOMWindow object.
3193
3194         * DumpRenderTree/chromium/TestShell.cpp:
3195         (TestShell::TestShell):
3196
3197 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
3198
3199         [chromium] use a WebTestProxyBase pointer to identify the window we need the history for
3200         https://bugs.webkit.org/show_bug.cgi?id=110346
3201
3202         Reviewed by Adam Barth.
3203
3204         Using an index is very brittle, as the TestRunner API does not define
3205         any ordering of windows.
3206
3207         Also, make TestRunner::shouldDumpBackForwardList() so content shell can
3208         trigger the capturing in the browser process before generating the
3209         text dump.
3210
3211         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3212         (WebTestRunner):
3213         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
3214         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3215         (WebTestRunner):
3216         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3217         (TestRunner):
3218         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3219         (WebTestRunner::WebTestProxyBase::captureTree):
3220         * DumpRenderTree/chromium/WebViewHost.cpp:
3221         (WebViewHost::captureHistoryForWindow):
3222         * DumpRenderTree/chromium/WebViewHost.h:
3223         (WebViewHost):
3224
3225 2013-02-19  Rouslan Solomakhin  <rouslan@chromium.org>
3226
3227         [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
3228         https://bugs.webkit.org/show_bug.cgi?id=109220
3229
3230         Reviewed by Tony Chang.
3231
3232         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
3233         (WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
3234         (WebTestRunner):
3235         (WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
3236         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.
3237         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
3238         (MockSpellCheck):
3239         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
3240         (WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.
3241
3242 2013-02-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3243
3244         [Gtk] HTML5 Media controls require a design refresh
3245         https://bugs.webkit.org/show_bug.cgi?id=83869
3246
3247         Reviewed by Philippe Normand.
3248
3249         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3250         (initializeGtkFontSettings): Added gnome as default icon theme for
3251         the DRT.
3252         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3253         (WTR::initializeGtkSettings): Added gnome as default icon theme for
3254         the WTR.
3255         * gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external
3256         dependency.
3257
3258 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
3259
3260         [chromium] move most of the remaining mocks to TestRunner library
3261         https://bugs.webkit.org/show_bug.cgi?id=110217
3262
3263         Reviewed by Nico Weber.
3264
3265         While most of the functionality provided by these mocks is also
3266         available in the content module, there is no straight forward way to
3267         inject the mock results required for layout tests.
3268
3269         * DumpRenderTree/DumpRenderTree.gypi:
3270         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3271         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3272         (WebKit):
3273         (WebTestRunner):
3274         (WebTestRunner::WebTestProxy::geolocationClient):
3275         (WebTestRunner::WebTestProxy::speechInputController):
3276         (WebTestRunner::WebTestProxy::speechRecognizer):
3277         (WebTestRunner::WebTestProxy::deviceOrientationClient):
3278         (WebTestRunner::WebTestProxy::requestPointerLock):
3279         (WebTestRunner::WebTestProxy::requestPointerUnlock):
3280         (WebTestRunner::WebTestProxy::isPointerLocked):
3281         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
3282         (WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
3283         (WebTestRunner):
3284         (WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
3285         (WebTestRunner::MockWebSpeechInputController::setDelegate):
3286         (WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
3287         (WebTestRunner::MockWebSpeechInputController::setDumpRect):
3288         (WebTestRunner::MockWebSpeechInputController::clearResults):
3289         (WebTestRunner::MockWebSpeechInputController::startRecognition):
3290         (WebTestRunner::MockWebSpeechInputController::cancelRecognition):
3291         (WebTestRunner::MockWebSpeechInputController::stopRecording):
3292         (WebTestRunner::MockWebSpeechInputController::speechTaskFired):
3293         (WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
3294         (WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
3295         (WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
3296         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
3297         (WebKit):
3298         (WebTestRunner):
3299         (MockWebSpeechInputController):
3300         (WebTestRunner::MockWebSpeechInputController::taskList):
3301         (SpeechTask):
3302         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
3303         (WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
3304         (WebTestRunner):
3305         (WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
3306         (WebTestRunner::MockWebSpeechRecognizer::setDelegate):
3307         (WebTestRunner::MockWebSpeechRecognizer::start):
3308         (WebTestRunner::MockWebSpeechRecognizer::stop):
3309         (WebTestRunner::MockWebSpeechRecognizer::abort):
3310         (WebTestRunner::MockWebSpeechRecognizer::addMockResult):
3311         (WebTestRunner::MockWebSpeechRecognizer::setError):
3312         (WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
3313         (WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
3314         (WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
3315         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
3316         (WebKit):
3317         (WebTestRunner):
3318         (MockWebSpeechRecognizer):
3319         (WebTestRunner::MockWebSpeechRecognizer::wasAborted):
3320         (WebTestRunner::MockWebSpeechRecognizer::client):
3321         (WebTestRunner::MockWebSpeechRecognizer::handle):
3322         (WebTestRunner::MockWebSpeechRecognizer::taskList):
3323         (Task):
3324         (WebTestRunner::MockWebSpeechRecognizer::Task::Task):
3325         (WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
3326         (StepTask):
3327         (WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
3328         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3329         (WebTestRunner::TestInterfaces::TestInterfaces):
3330         (WebTestRunner::TestInterfaces::windowOpened):
3331         (WebTestRunner):
3332         (WebTestRunner::TestInterfaces::windowClosed):
3333         (WebTestRunner::TestInterfaces::windowList):
3334         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3335         (TestInterfaces):
3336         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3337         (WebTestRunner::TestRunner::TestRunner):
3338         (WebTestRunner::TestRunner::reset):
3339         (WebTestRunner::TestRunner::requestPointerLock):
3340         (WebTestRunner):
3341         (WebTestRunner::TestRunner::requestPointerUnlock):
3342         (WebTestRunner::TestRunner::isPointerLocked):
3343         (WebTestRunner::TestRunner::didAcquirePointerLockInternal):
3344         (WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
3345         (WebTestRunner::TestRunner::didLosePointerLockInternal):
3346         (WebTestRunner::TestRunner::windowCount):
3347         (WebTestRunner::TestRunner::setMockDeviceOrientation):
3348         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
3349         (WebTestRunner::TestRunner::setGeolocationPermission):
3350         (WebTestRunner::TestRunner::setMockGeolocationPosition):
3351         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
3352         (WebTestRunner::TestRunner::addMockSpeechInputResult):
3353         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
3354         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
3355         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
3356         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
3357         (WebTestRunner::TestRunner::didAcquirePointerLock):
3358         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
3359         (WebTestRunner::TestRunner::didLosePointerLock):
3360         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
3361         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
3362         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3363         (WebTestRunner):
3364         (TestRunner):
3365         (HostMethodTask):
3366         (WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
3367         (WebTestRunner::TestRunner::HostMethodTask::runIfValid):
3368         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3369         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
3370         (WebTestRunner::WebTestProxyBase::setInterfaces):
3371         (WebTestRunner::WebTestProxyBase::setDelegate):
3372         (WebTestRunner::WebTestProxyBase::reset):
3373         (WebTestRunner::WebTestProxyBase::captureTree):
3374         (WebTestRunner::WebTestProxyBase::geolocationClientMock):
3375         (WebTestRunner):
3376         (WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
3377         (WebTestRunner::WebTestProxyBase::speechInputControllerMock):
3378         (WebTestRunner::WebTestProxyBase::speechRecognizerMock):
3379         (WebTestRunner::WebTestProxyBase::geolocationClient):
3380         (WebTestRunner::WebTestProxyBase::speechInputController):
3381         (WebTestRunner::WebTestProxyBase::speechRecognizer):
3382         (WebTestRunner::WebTestProxyBase::deviceOrientationClient):
3383         (WebTestRunner::WebTestProxyBase::requestPointerLock):
3384         (WebTestRunner::WebTestProxyBase::requestPointerUnlock):
3385         (WebTestRunner::WebTestProxyBase::isPointerLocked):
3386         * DumpRenderTree/chromium/WebViewHost.cpp:
3387         (WebViewHost::reset):
3388         * DumpRenderTree/chromium/WebViewHost.h:
3389         (WebKit):
3390         (WebViewHost):
3391
3392 2013-02-20  Andras Becsi  <andras.becsi@digia.com>
3393
3394         [Qt] Make debug builds possible on 32bit Linux
3395         https://bugs.webkit.org/show_bug.cgi?id=110231
3396
3397         Reviewed by Tor Arne Vestbø.
3398
3399         Use the stabs format for debug builds to make the object files
3400         a bit smaller so that they can be linked on a 32bit system.
3401
3402         * qmake/mkspecs/features/unix/default_post.prf:
3403
3404 2013-02-20  Takashi Toyoshima  <toyoshim@chromium.org>
3405
3406         Unreviewed. Add myself to watch lists.
3407
3408         * Scripts/webkitpy/common/config/committers.py:
3409         * Scripts/webkitpy/common/config/watchlist:
3410
3411 2013-02-19  Joshua Bell  <jsbell@chromium.org>
3412
3413         Remove warning from run-bindings-tests
3414         https://bugs.webkit.org/show_bug.cgi?id=110285
3415
3416         Reviewed by Kentaro Hara.
3417
3418         Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
3419         "Unknown option: idlattributesfile". That option was removed from
3420         bindings/scripts/preprocess-idls.pl but was still being passed by
3421         the test script. Remove it.
3422
3423         * Scripts/webkitpy/bindings/main.py:
3424         (BindingsTests.generate_supplemental_dependency): Remove unused arg.
3425
3426 2013-02-19  Elliott Sprehn  <esprehn@chromium.org>
3427
3428         Unreviewed. Add myself to watch lists.
3429
3430         * Scripts/webkitpy/common/config/committers.py:
3431         * Scripts/webkitpy/common/config/watchlist:
3432
3433 2013-02-19  Hans Muller  <hmuller@adobe.com>
3434
3435         Unreviewed, corrected primary email.
3436
3437         * Scripts/webkitpy/common/config/committers.py:
3438
3439 2013-02-19  Hans Muller  <hmuller@adobe.com>
3440
3441         Unreviewed. Adding myself as a committer.
3442
3443         * Scripts/webkitpy/common/config/committers.py:
3444
3445 2013-02-19  Pravin D  <pravind@webkit.org>
3446
3447         Unreviewed, changing primary email.
3448
3449         * Scripts/webkitpy/common/config/committers.py:
3450
3451 2013-02-19  Alan Cutter  <alancutter@chromium.org>
3452
3453         REGRESSION: Sheriffbot is failing to process rollout requests
3454         https://bugs.webkit.org/show_bug.cgi?id=106945
3455
3456         Reviewed by Adam Barth.
3457
3458         Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
3459         This resolves problems when Sheriffbot attempts to perform a rollout request.
3460
3461         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3462         * EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
3463         * EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
3464
3465 2013-02-19  Claudio Saavedra  <csaavedra@igalia.com>
3466
3467         Unreviewed build fix.
3468
3469         * efl/jhbuild.modules:
3470         * gtk/jhbuild.modules:
3471
3472         Bump harfbuzz module to 0.9.7. See related bug 110145.
3473
3474 2013-02-19  Simon Hausmann  <simon.hausmann@digia.com>
3475
3476         [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
3477         https://bugs.webkit.org/show_bug.cgi?id=110215
3478
3479         Reviewed by Tor Arne Vestbø.
3480
3481         Check that gperf, python, ruby, perl, bison and flex are in the PATH before
3482         continuing the build. Otherwise skip with an error message explaining which
3483         programs are missing from the build.
3484
3485         * qmake/mkspecs/features/configure.prf:
3486         * qmake/mkspecs/features/functions.prf:
3487
3488 2013-02-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3489
3490         Unreviewed, rolling out r143319.
3491         http://trac.webkit.org/changeset/143319
3492         https://bugs.webkit.org/show_bug.cgi?id=110214
3493
3494         Causes build issues on win32 (Requested by carewolf on
3495         #webkit).
3496
3497         * qmake/mkspecs/features/features.pri:
3498
3499 2013-02-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3500
3501         [Qt] Enable MathML
3502         https://bugs.webkit.org/show_bug.cgi?id=110205
3503
3504         Reviewed by Simon Hausmann.
3505
3506         * qmake/mkspecs/features/features.pri:
3507
3508 2013-02-17  Andrei Bucur  <abucur@adobe.com>
3509
3510         Unreviewed. Adding myself as a committer.
3511
3512         * Scripts/webkitpy/common/config/committers.py:
3513
3514 2013-02-19  Hajime Morrita  <morrita@google.com>
3515
3516         Unreviewed, updated spelling of my name.
3517
3518         * Scripts/webkitpy/common/config/committers.py:
3519
3520 2013-02-18  Ilya Tikhonovsky  <loislo@chromium.org>
3521
3522         Unreviewed. Adjust expectations.
3523
3524         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
3525         (TestWebKitAPI::TEST):
3526
3527 2013-02-18  Zan Dobersek  <zdobersek@igalia.com>
3528
3529         Unreviewed GTK gardening.
3530
3531         * Scripts/run-gtk-tests:
3532         (TestRunner): Skipped the ReloadPageAfterCrash unit test as it is flakily timing out.
3533
3534 2013-02-18  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3535
3536         [Qt][WK2] Remove duped test name and append new test in project file
3537         https://bugs.webkit.org/show_bug.cgi?id=110117
3538
3539         A new WK2 API test has landed recently (ResizeWindowAfterCrash), this patch will
3540         add this test into the runnable test suite and remove a duped test in project file.
3541
3542         Reviewed by Jocelyn Turcotte.
3543
3544         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
3545
3546 2013-02-18  Jochen Eisinger  <jochen@chromium.org>
3547
3548         [chromium] remove log spew from dumpAllBackForwardLists
3549         https://bugs.webkit.org/show_bug.cgi?id=110108
3550
3551         Reviewed by Nico Weber.
3552
3553         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3554
3555 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3556
3557         [EFL][WK2] Disable failing API tests
3558         https://bugs.webkit.org/show_bug.cgi?id=110081
3559
3560         Reviewed by Kenneth Rohde Christiansen.
3561
3562         Disable DOMWindowExtensionBasic WK2 test on EFL port as it times out.
3563
3564         * TestWebKitAPI/PlatformEfl.cmake:
3565
3566 2013-02-18  Simon Hausmann  <simon.hausmann@digia.com>
3567
3568         [Qt] Disable the build if certain configure checks fail
3569         https://bugs.webkit.org/show_bug.cgi?id=110094
3570
3571         Reviewed by Tor Arne Vestbø.
3572
3573         Allow for the build to be skipped (clear out SUBDIRS) if certain
3574         configure conditions aren't met.
3575
3576         * qmake/mkspecs/features/configure.prf:
3577
3578 2013-02-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3579
3580         [Qt][WK2] Support WK2 API tests
3581         https://bugs.webkit.org/show_bug.cgi?id=109843
3582
3583         Reviewed by Jocelyn Turcotte.
3584
3585         * TestWebKitAPI/DerivedSources.pri: Added.
3586         * TestWebKitAPI/InjectedBundle.pri: Added.
3587         * TestWebKitAPI/PlatformWebView.h:
3588         * TestWebKitAPI/TestWebKitAPI.pri:
3589         * TestWebKitAPI/TestWebKitAPI.pro:
3590         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Added.
3591         * TestWebKitAPI/Tests/WTF/WTF.pro:
3592         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Added.
3593         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp:
3594         (TestWebKitAPI::Util::sleep):
3595         (TestWebKitAPI::Util::createInjectedBundlePath):
3596         (TestWebKitAPI::Util::createURLForResource):
3597         (TestWebKitAPI::Util::isKeyDown):
3598         (Util):
3599         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Added.
3600         (TestWebKitAPI):
3601         (WrapperWindow):
3602         (TestWebKitAPI::WrapperWindow::WrapperWindow):
3603         (TestWebKitAPI::WrapperWindow::handleStatusChanged):
3604         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3605         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3606         (TestWebKitAPI::PlatformWebView::resizeTo):
3607         (TestWebKitAPI::PlatformWebView::page):
3608         (TestWebKitAPI::PlatformWebView::focus):
3609         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3610         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
3611         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3612         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3613         * TestWebKitAPI/qt/main.cpp:
3614         (addQtWebProcessToPath):
3615         (main):
3616
3617 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3618
3619         [EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API
3620         https://bugs.webkit.org/show_bug.cgi?id=108598
3621
3622         Reviewed by Kenneth Rohde Christiansen.
3623
3624         Update EFL's MiniBrowser to make use of new Ewk_Favicon API.
3625
3626         * MiniBrowser/efl/main.c:
3627         (update_view_favicon):
3628         (on_view_favicon_changed):
3629         (window_create):
3630
3631 2013-02-18  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
3632
3633         Unreviewed. Add myself as a committer.
3634
3635         * Scripts/webkitpy/common/config/committers.py:
3636
3637 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
3638
3639         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
3640         https://bugs.webkit.org/show_bug.cgi?id=109554
3641
3642         In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
3643         can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
3644
3645         Drive by fix: I introduced a client interface for the HeapGraphSerializer.
3646         It helps me to do the tests for the serializer.
3647
3648         Reviewed by Yury Semikhatsky.
3649
3650         It is covered by newly added tests in TestWebKitAPI.
3651
3652         * TestWebKitAPI/TestWebKitAPI.gypi:
3653         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
3654         (TestWebKitAPI):
3655         (HeapGraphReceiver):
3656         (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
3657         (TestWebKitAPI::HeapGraphReceiver::printGraph):
3658         (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
3659         (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
3660         (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
3661         (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
3662         (TestWebKitAPI::HeapGraphReceiver::serializer):
3663         (TestWebKitAPI::HeapGraphReceiver::chunkPart):
3664         (TestWebKitAPI::HeapGraphReceiver::dumpPart):
3665         (TestWebKitAPI::HeapGraphReceiver::stringValue):
3666         (TestWebKitAPI::HeapGraphReceiver::intValue):
3667         (TestWebKitAPI::HeapGraphReceiver::nodeToString):
3668         (TestWebKitAPI::HeapGraphReceiver::edgeToString):
3669         (TestWebKitAPI::HeapGraphReceiver::printNode):
3670         (Helper):
3671         (TestWebKitAPI::Helper::Helper):
3672         (TestWebKitAPI::Helper::addNode):
3673         (TestWebKitAPI::Helper::addEdge):
3674         (TestWebKitAPI::Helper::done):
3675         (Object):
3676         (TestWebKitAPI::Helper::Object::Object):
3677         (TestWebKitAPI::TEST):
3678         (Owner):
3679         (TestWebKitAPI::Owner::Owner):
3680         (TestWebKitAPI::Owner::reportMemoryUsage):
3681
3682 2013-02-18  Ryosuke Niwa  <rniwa@webkit.org>
3683
3684         WKR build fix. Always use ascii since irclib/ircbot doesn't support unicode.
3685
3686         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3687         (NewCommitBot.next_work_item):
3688
3689 2013-02-17  Kangil Han  <kangil.han@samsung.com>
3690
3691         Unreviewed. Add myself as a committer.
3692
3693         * Scripts/webkitpy/common/config/committers.py:
3694
3695 2013-02-17  Alan Cutter  <alancutter@chromium.org>
3696
3697         GCE EWS bots are all offline
3698         https://bugs.webkit.org/show_bug.cgi?id=110069
3699
3700         Reviewed by Eric Seidel.
3701
3702         Updated GCE EWS build scripts to use the gcel-10-04-v20130104 image instead of the obsoleted ubuntu-10-04-v20120621.
3703         This changed the ephemeral disk path to /dev/sdb and required /etc/hosts to be chmodded to 644.
3704
3705         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3706         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3707         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
3708         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3709         * EWSTools/build-vm.sh:
3710         * EWSTools/start-queue.sh:
3711
3712 2013-02-18  Eugene Klyuchnikov  <eustas@chromium.org>
3713
3714         Unreviewed, add myself to commiters.py.
3715
3716         * Scripts/webkitpy/common/config/committers.py:
3717
3718 2013-02-17  Dongwoo Joshua Im  <dw.im@samsung.com>
3719
3720         Unreviewed. Add myself as a committer.
3721
3722         * Scripts/webkitpy/common/config/committers.py:
3723
3724 2013-02-17  Roger Fong  <roger_fong@apple.com>
3725
3726         Unreviewed. Fix typo in script.
3727
3728         * EWSTools/start-queue-win.sh:
3729
3730 2013-02-15  Roger Fong  <roger_fong@apple.com>
3731
3732         Pass in bot name as parameter to start-queue-win script.
3733         https://bugs.webkit.org/show_bug.cgi?id=109998.
3734
3735         Reviewed by Darin Adler.
3736
3737         * EWSTools/start-queue-win.sh:
3738
3739 2013-02-18  Byungwoo Lee  <bw80.lee@samsung.com>
3740
3741         Unreviewed. Add myself as a committer.
3742
3743         * Scripts/webkitpy/common/config/committers.py:
3744
3745 2013-02-17  Ryosuke Niwa  <rniwa@webkit.org>
3746
3747         Rename new-commit-bot to WKR to disambiguate it from commit-queue.
3748
3749         Rubber-stamped by Andreas Kling.
3750
3751         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3752         (NewCommitBot.begin_work_queue):
3753
3754 2013-02-16  Glenn Adams  <glenn@skynav.com>
3755
3756         Unreviewed. Add myself as a committer.
3757
3758         * Scripts/webkitpy/common/config/committers.py:
3759
3760 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
3761
3762         new-commit-bot should report the full name of committer and reviewer instead of just nicks
3763         https://bugs.webkit.org/show_bug.cgi?id=110040
3764
3765         Reviewed by Darin Adler.
3766
3767         Have it report names like "Ryosuke Niwa (rniwa)" instead of just "rniwa".
3768
3769         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3770         (NewCommitBot):
3771         (NewCommitBot._summarize_commit_log):
3772         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3773
3774 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
3775
3776         We need a CIA replacement
3777         https://bugs.webkit.org/show_bug.cgi?id=110008
3778
3779         Reviewed by Andreas Kling.
3780
3781         Added new-commit-bot.
3782
3783         * Scripts/webkitpy/tool/bot/queueengine.py:
3784         (QueueEngine.__init__):
3785         (QueueEngine): Made the sleep tiem configurable.
3786         (QueueEngine._sleep_message):
3787         (QueueEngine._sleep):
3788         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3789         (QueueEngineTest.test_sleep_message):
3790         * Scripts/webkitpy/tool/commands/__init__.py:
3791         * Scripts/webkitpy/tool/commands/newcommitbot.py: Added.
3792         (PingPong): Added. Implements the ping pong protocol.
3793         (NewCommitBot):
3794         (NewCommitBot.begin_work_queue):
3795         (NewCommitBot.work_item_log_path):
3796         (NewCommitBot.next_work_item): Update SVN revision and report any new commits made since
3797         the last time we checked the head SVN revision.
3798         (NewCommitBot.process_work_item):
3799         (NewCommitBot._update_checkout): svn up.
3800         (NewCommitBot._new_svn_revisions): Returns a range of new revisions.
3801         (NewCommitBot._summarize_commit_log): Summarize a commit log to be posted on IRC.
3802         (NewCommitBot.handle_unexpected_error):
3803         (NewCommitBot.handle_script_error):
3804         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Added.
3805         (NewCommitBotTest.test_summarize_commit_log_basic): Tests for summarizing non-rollout commits.
3806         (NewCommitBotTest.test_summarize_commit_log_rollout): Tests for summarizing rollouts.
3807         * Scripts/webkitpy/tool/commands/queues.py:
3808         (AbstractQueue.execute):
3809         * Scripts/webkitpy/tool/commands/queuestest.py:
3810         (MockQueueEngine.__init__):
3811         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3812         (SheriffBotTest.test_command_aliases):
3813         * Scripts/webkitpy/tool/main.py:
3814         (WebKitPatch):
3815
3816 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
3817
3818         [chromium] initialize all variables of TestRunner classes
3819         https://bugs.webkit.org/show_bug.cgi?id=110013
3820
3821         Reviewed by Adam Barth.
3822
3823         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3824         (WebTestRunner::TestInterfaces::TestInterfaces):
3825         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3826         (WebTestRunner::TestRunner::TestRunner):
3827
3828 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
3829
3830         [chromium] destroy the TestPlugin when the destroy() method is invoked.
3831         https://bugs.webkit.org/show_bug.cgi?id=110012
3832
3833         Reviewed by Adam Barth.
3834
3835         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3836         (WebTestRunner::TestPlugin::destroy):
3837
3838 2013-02-15  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3839
3840         [WK2] Write a test to simulate crashed WebProcess followed by Window resize
3841         https://bugs.webkit.org/show_bug.cgi?id=109842
3842
3843         Reviewed by Benjamin Poulain.
3844
3845         This new test will kill WebProcess, followed by next resizing the Window. It helps to
3846         identify if the port is testing for WebPageProxy data members state (e.g. DrawingArea, Frames)
3847         before making calls into them.
3848
3849         * TestWebKitAPI/GNUmakefile.am:
3850         * TestWebKitAPI/PlatformEfl.cmake:
3851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3852         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Added.
3853         (TestWebKitAPI):
3854         (TestWebKitAPI::didFinishLoad):
3855         (TestWebKitAPI::didCrash):
3856         (TestWebKitAPI::TEST):
3857
3858 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3859
3860         Add CString operators for comparison with const char*
3861         https://bugs.webkit.org/show_bug.cgi?id=109947
3862
3863         Reviewed by Darin Adler.
3864
3865         Add tests for WTF::CString's comparison operators.
3866
3867         * TestWebKitAPI/Tests/WTF/CString.cpp:
3868         (TEST):
3869
3870 2013-02-15  Zan Dobersek  <zdobersek@igalia.com>
3871
3872         webkit-patch suggest-reviewers should limit itself to 5 reviewers
3873         https://bugs.webkit.org/show_bug.cgi?id=107528
3874
3875         Reviewed by Eric Seidel.
3876
3877         * Scripts/webkitpy/common/checkout/checkout.py:
3878         (Checkout.suggested_reviewers): Iterate through the sorted commit info list,
3879         scraping reviewers from the commit information and in the end producing a list
3880         of reviewers that's sorted from the most to least recent activity of any reviewer
3881         that has reviewed or authored patches for the changed files.
3882         * Scripts/webkitpy/tool/commands/queries.py:
3883         (SuggestReviewers): Use the SuggestReviewers step instead of reimplementing much of
3884         the same logic.
3885         (SuggestReviewers._prepare_state): Force the reviewer suggestion because the option
3886         defaults to False.
3887         * Scripts/webkitpy/tool/steps/suggestreviewers.py:
3888         (SuggestReviewers.run): Only list the first five suggested reviewers, now printed out
3889         on a single line.  Only ask for CC-ing the suggested reviewers to the bug if the
3890         bug ID is located in the command's state.
3891
3892 2013-02-15  Pablo Flouret  <pablof@motorola.com>
3893
3894         Unreviewed. Add myself as a committer.
3895
3896         * Scripts/webkitpy/common/config/committers.py:
3897
3898 2013-02-15  Roger Fong  <roger_fong@apple.com>
3899
3900         Get Win EWS startup script checked into tree so we can make changes to all the EWS bots more easily.
3901
3902         * EWSTools/start-queue-win.sh: Added.
3903
3904 2013-02-15  Andreas Kling  <akling@apple.com>
3905
3906         Unbreak webkit-patch -- can't have both Committer and Contributor entry with same e-mail address.
3907
3908         * Scripts/webkitpy/common/config/committers.py:
3909
3910 2013-02-15  Joanmarie Diggs  <jdiggs@igalia.com>
3911
3912         Unreviewed. Add myself as a committer.
3913
3914         * Scripts/webkitpy/common/config/committers.py:
3915
3916 2013-02-15  Ryosuke Niwa  <rniwa@webkit.org>
3917
3918         NRWT: ML Debug Test bot is timing out after cleaning up ports
3919         https://bugs.webkit.org/show_bug.cgi?id=109912
3920
3921         Reviewed by Simon Fraser.
3922
3923         Added more debug messgaes to diagnose the issue.
3924
3925         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3926         (Manager.run):
3927
3928 2013-02-15  Claudio Saavedra  <csaavedra@igalia.com>
3929
3930         Unreviewed. Add myself as a committer.
3931
3932         * Scripts/webkitpy/common/config/committers.py:
3933
3934 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3935
3936         Unreviewed. Update Yi Shen, Antonio Gomes and Laszlo Gombos'
3937         emails on their behalf.
3938
3939         * Scripts/webkitpy/common/config/committers.py:
3940
3941 2013-02-15  Andrey Lushnikov  <lushnikov@chromium.org>
3942
3943         Web Inspector: implement smart braces functionality
3944         https://bugs.webkit.org/show_bug.cgi?id=109200
3945
3946         Reviewed by Pavel Feldman.
3947
3948         Fix eventSender.keyDown implementation to correctly process opening
3949         round brace symbol.
3950
3951         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3952         (WebTestRunner):
3953         (WebTestRunner::EventSender::keyDown):
3954
3955 2013-02-15  Jochen Eisinger  <jochen@chromium.org>
3956
3957         Speculative build fix for chromium-win.
3958
3959         Unreviewed build fix.
3960
3961         Add declarations of the copy constructor and assignment operator to
3962         WebTestProxyBase, so VS doesn't try to generate them.
3963
3964         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3965
3966 2013-02-15  Simon Hausmann  <simon.hausmann@digia.com>
3967
3968         [Qt] Port GCController to JSC C API
3969         https://bugs.webkit.org/show_bug.cgi?id=109690
3970
3971         Reviewed by Benjamin Poulain.
3972
3973         Rename TestRunner to TestRunnerQt to avoid conflict when
3974         including TestRunner.h in the future.
3975
3976         Replaced QObject based GCController implementation with JSC C API
3977         based one.
3978
3979         * DumpRenderTree/qt/DumpRenderTree.pro:
3980         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3981         (WebCore::DumpRenderTree::DumpRenderTree):
3982         (WebCore::DumpRenderTree::open):
3983         (WebCore::DumpRenderTree::initJSObjects):
3984         (WebCore::methodNameStringForFailedTest):
3985         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3986         (WebCore::DumpRenderTree::testRunner):
3987         (DumpRenderTree):
3988         * DumpRenderTree/qt/GCControllerQt.cpp:
3989         (GCController::getJSObjectCount):
3990         * DumpRenderTree/qt/GCControllerQt.h: Removed.
3991         * DumpRenderTree/qt/TestRunnerQt.cpp:
3992         (TestRunnerQt::TestRunnerQt):
3993         (TestRunnerQt::reset):
3994         (TestRunnerQt::dumpNotifications):
3995         (TestRunnerQt::processWork):
3996         (TestRunnerQt::maybeDump):
3997         (TestRunnerQt::dumpAsText):
3998         (TestRunnerQt::waitUntilDone):
3999         (TestRunnerQt::setViewModeMediaFeature):
4000         (TestRunnerQt::webHistoryItemCount):
4001         (TestRunnerQt::keepWebHistory):
4002         (TestRunnerQt::notifyDone):
4003         (TestRunnerQt::windowCount):
4004         (TestRunnerQt::grantWebNotificationPermission):
4005         (TestRunnerQt::ignoreLegacyWebNotificationPermissionRequests):
4006         (TestRunnerQt::denyWebNotificationPermission):
4007         (TestRunnerQt::removeAllWebNotificationPermissions):
4008         (TestRunnerQt::simulateWebNotificationClick):
4009         (TestRunnerQt::simulateLegacyWebNotificationClick):
4010         (TestRunnerQt::display):
4011         (TestRunnerQt::displayInvalidatedRegion):
4012         (TestRunnerQt::clearBackForwardList):
4013         (TestRunnerQt::pathToLocalResource):
4014         (TestRunnerQt::dumpEditingCallbacks):
4015         (TestRunnerQt::dumpFrameLoadCallbacks):
4016         (TestRunnerQt::dumpProgressFinishedCallback):
4017         (TestRunnerQt::dumpUserGestureInFrameLoadCallbacks):
4018         (TestRunnerQt::dumpResourceLoadCallbacks):
4019         (TestRunnerQt::dumpResourceResponseMIMETypes):
4020         (TestRunnerQt::dumpWillCacheResponse):
4021         (TestRunnerQt::dumpHistoryCallbacks):
4022         (TestRunnerQt::setWillSendRequestReturnsNullOnRedirect):
4023         (TestRunnerQt::setWillSendRequestReturnsNull):
4024         (TestRunnerQt::setWillSendRequestClearHeader):
4025         (TestRunnerQt::setDeferMainResourceDataLoad):
4026         (TestRunnerQt::queueBackNavigation):
4027         (TestRunnerQt::queueForwardNavigation):
4028         (TestRunnerQt::queueLoad):
4029         (TestRunnerQt::queueLoadHTMLString):
4030         (TestRunnerQt::queueReload):
4031         (TestRunnerQt::queueLoadingScript):
4032         (TestRunnerQt::queueNonLoadingScript):
4033         (TestRunnerQt::provisionalLoad):
4034         (TestRunnerQt::timerEvent):
4035         (TestRunnerQt::encodeHostName):
4036         (TestRunnerQt::decodeHostName):
4037         (TestRunnerQt::closeWebInspector):
4038         (TestRunnerQt::setDeveloperExtrasEnabled):
4039         (TestRunnerQt::setAsynchronousSpellCheckingEnabled):
4040         (TestRunnerQt::showWebInspector):
4041         (TestRunnerQt::evaluateInWebInspector):
4042         (TestRunnerQt::goBack):
4043         (TestRunnerQt::setDefersLoading):
4044         (TestRunnerQt::setAllowUniversalAccessFromFileURLs):
4045         (TestRunnerQt::setAllowFileAccessFromFileURLs):
4046         (TestRunnerQt::setAppCacheMaximumSize):
4047         (TestRunnerQt::setAutofilled):
4048         (TestRunnerQt::setValueForUser):
4049         (TestRunnerQt::setFixedContentsSize):
4050         (TestRunnerQt::setPrivateBrowsingEnabled):
4051         (TestRunnerQt::setSpatialNavigationEnabled):
4052         (TestRunnerQt::setPopupBlockingEnabled):
4053         (TestRunnerQt::setPluginsEnabled):
4054         (TestRunnerQt::setPOSIXLocale):
4055         (TestRunnerQt::setWindowIsKey):
4056         (TestRunnerQt::setMainFrameIsFirstResponder):
4057         (TestRunnerQt::setJavaScriptCanAccessClipboard):
4058         (TestRunnerQt::setXSSAuditorEnabled):
4059         (TestRunnerQt::dispatchPendingLoadRequests):
4060         (TestRunnerQt::clearAllApplicationCaches):
4061         (TestRunnerQt::clearApplicationCacheForOrigin):
4062         (TestRunnerQt::localStorageDiskUsageForOrigin):
4063         (TestRunnerQt::setApplicationCacheOriginQuota):
4064         (TestRunnerQt::applicationCacheDiskUsageForOrigin):
4065         (TestRunnerQt::originsWithApplicationCache):
4066         (TestRunnerQt::setCacheModel):
4067         (TestRunnerQt::setDatabaseQuota):
4068         (TestRunnerQt::clearAllDatabases):
4069         (TestRunnerQt::addOriginAccessWhitelistEntry):
4070         (TestRunnerQt::removeOriginAccessWhitelistEntry):
4071         (TestRunnerQt::setCustomPolicyDelegate):
4072         (TestRunnerQt::waitForPolicyDelegate):
4073         (TestRunnerQt::overridePreference):
4074         (TestRunnerQt::setUserStyleSheetLocation):
4075         (TestRunnerQt::setCaretBrowsingEnabled):
4076         (TestRunnerQt::setAuthorAndUserStylesEnabled):
4077         (TestRunnerQt::setUserStyleSheetEnabled):
4078         (TestRunnerQt::setDomainRelaxationForbiddenForURLScheme):
4079         (TestRunnerQt::callShouldCloseOnWebView):
4080         (TestRunnerQt::setScrollbarPolicy):
4081         (TestRunnerQt::setSmartInsertDeleteEnabled):
4082         (TestRunnerQt::setSelectTrailingWhitespaceEnabled):
4083         (TestRunnerQt::execCommand):
4084         (TestRunnerQt::isCommandEnabled):
4085         (TestRunnerQt::findString):
4086         (TestRunnerQt::markerTextForListItem):
4087         (TestRunnerQt::computedStyleIncludingVisitedInfo):
4088         (TestRunnerQt::elementDoesAutoCompleteForElementWithId):
4089         (TestRunnerQt::authenticateSession):
4090         (TestRunnerQt::setIconDatabaseEnabled):
4091         (TestRunnerQt::setMockDeviceOrientation):
4092         (TestRunnerQt::setGeolocationPermission):
4093         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
4094         (TestRunnerQt::setGeolocationPermissionCommon):
4095         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
4096         (TestRunnerQt::setMockGeolocationPosition):
4097         (TestRunnerQt::addMockSpeechInputResult):
4098         (TestRunnerQt::setMockSpeechInputDumpRect):
4099         (TestRunnerQt::startSpeechInput):
4100         (TestRunnerQt::evaluateScriptInIsolatedWorldAndReturnValue):
4101         (TestRunnerQt::evaluateScriptInIsolatedWorld):
4102         (TestRunnerQt::addUserStyleSheet):
4103         (TestRunnerQt::removeAllVisitedLinks):
4104         (TestRunnerQt::addURLToRedirect):
4105         (TestRunnerQt::originsWithLocalStorage):
4106         (TestRunnerQt::deleteAllLocalStorage):
4107         (TestRunnerQt::deleteLocalStorageForOrigin):
4108         (TestRunnerQt::observeStorageTrackerNotifications):
4109         (TestRunnerQt::syncLocalStorage):
4110         (TestRunnerQt::resetPageVisibility):
4111         (TestRunnerQt::setPageVisibility):
4112         (TestRunnerQt::setAutomaticLinkDetectionEnabled):
4113         (TestRunnerQt::setTextDirection):
4114         (TestRunnerQt::setAlwaysAcceptCookies):
4115         (TestRunnerQt::setAlwaysBlockCookies):
4116         (TestRunnerQt::setAudioData):
4117         * DumpRenderTree/qt/TestRunnerQt.h:
4118         (TestRunnerQt):
4119
4120 2013-02-14  Karen Grunberg  <kareng@chromium.org>
4121
4122         adding myself as a committer
4123
4124         * Scripts/webkitpy/common/config/committers.py:
4125
4126 2013-02-14  Glenn Adams  <glenn@skynav.com>
4127
4128         new-run-webkit-tests needs a shared TestExpectations between all WebKit ports
4129         https://bugs.webkit.org/show_bug.cgi?id=37565
4130
4131         Introduce generic TestExpectations file that applies as a fallback for all ports, the location of which
4132         is LayoutTests/TestExpectations.
4133
4134         Reviewed by Dirk Pranke.
4135
4136         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
4137         (FakePort.path_to_generic_test_expectations_file):
4138         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4139         (TestExpectations.__init__):
4140         * Scripts/webkitpy/layout_tests/port/base.py:
4141         (Port.path_to_generic_test_expectations_file):
4142         (Port):
4143         (Port._port_specific_expectations_files):
4144         (Port.expectations_files):
4145         * Scripts/webkitpy/layout_tests/port/chromium.py:
4146         (ChromiumPort._port_specific_expectations_files):
4147         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4148         (ChromiumAndroidPort._port_specific_expectations_files):
4149         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
4150         (ChromiumPortTestCase.test_expectations_files):
4151         * Scripts/webkitpy/layout_tests/port/efl.py:
4152         (EflPort._port_specific_expectations_files):
4153         * Scripts/webkitpy/layout_tests/port/gtk.py:
4154         (GtkPort._port_specific_expectations_files):
4155         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
4156         (GtkPortTest.test_expectations_files):
4157         * Scripts/webkitpy/layout_tests/port/mac.py:
4158         (MacPort._port_specific_expectations_files):
4159         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4160         (PortTestCase.test_expectations_ordering):
4161         (test_expectations_files):
4162         * Scripts/webkitpy/layout_tests/port/qt.py:
4163         (QtPort._port_specific_expectations_files):
4164         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4165         (QtPortTest.test_expectations_files):
4166         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4167         (WinPortTest.test_expectations_files):
4168         * Scripts/webkitpy/tool/commands/queries_unittest.py:
4169         (PrintExpectationsTest.test_paths):
4170         * Scripts/webkitpy/tool/commands/rebaseline.py:
4171         (RebaselineTest._update_expectations_file):
4172
4173 2013-02-14  Jochen Eisinger  <jochen@chromium.org>
4174
4175         [chromium] move pixel generation logic to TestRunner library
4176         https://bugs.webkit.org/show_bug.cgi?id=109686
4177
4178         Reviewed by Stephen White.
4179
4180         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4181         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
4182         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
4183         (WebTestRunner):
4184         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4185         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
4186         (WebTestRunner):
4187         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4188         (WebTestRunner::TestInterfaces::~TestInterfaces):
4189         (WebTestRunner::TestInterfaces::setWebView):
4190         (WebTestRunner::TestInterfaces::proxy):
4191         (WebTestRunner):
4192         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
4193         (WebTestRunner):
4194         (TestInterfaces):
4195         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4196         (WebTestRunner::TestRunner::setWebView):
4197         (WebTestRunner):
4198         (WebTestRunner::TestRunner::setBackingScaleFactor):
4199         (WebTestRunner::TestRunner::display):
4200         (WebTestRunner::TestRunner::displayInvalidatedRegion):
4201         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4202         (WebTestRunner):
4203         (TestRunner):
4204         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
4205         (WebTestRunner::WebTestInterfaces::setWebView):
4206         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4207         (WebTestRunner::WebTestProxyBase::reset):
4208         (WebTestRunner::WebTestProxyBase::capturePixels):
4209         (WebTestRunner):
4210         (WebTestRunner::WebTestProxyBase::paintRect):
4211         (WebTestRunner::WebTestProxyBase::paintInvalidatedRegion):
4212         (WebTestRunner::WebTestProxyBase::paintPagesWithBoundaries):
4213         (WebTestRunner::WebTestProxyBase::canvas):
4214         (WebTestRunner::WebTestProxyBase::displayRepaintMask):
4215         (WebTestRunner::WebTestProxyBase::display):
4216         (WebTestRunner::WebTestProxyBase::displayInvalidatedRegion):
4217         (WebTestRunner::WebTestProxyBase::discardBackingStore):
4218         (WebTestRunner::WebTestProxyBase::setWindowRect):
4219         (WebTestRunner::WebTestProxyBase::userMediaClient):
4220         * DumpRenderTree/chromium/TestShell.cpp:
4221         (TestShell::createMainWindow):
4222         (TestShell::~TestShell):
4223         (TestShell::showDevTools):
4224         (TestShell::closeDevTools):
4225         (TestShell::dump):
4226         * DumpRenderTree/chromium/WebViewHost.cpp:
4227         (WebViewHost::setWindowRect):
4228         (WebViewHost::setDeviceScaleFactor):
4229         (WebViewHost::reset):
4230         * DumpRenderTree/chromium/WebViewHost.h:
4231         (WebViewHost):
4232
4233 2013-02-14  Tony Chang  <tony@chromium.org>
4234
4235         Unreviewed, set svn:eol-style native for .sln, .vcproj, and .vsprops files.
4236         https://bugs.webkit.org/show_bug.cgi?id=96934
4237
4238         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
4239         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
4240         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added property svn:eol-style.
4241         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added property svn:eol-style.
4242         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added property svn:eol-style.
4243         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
4244         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added property svn:eol-style.
4245         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added property svn:eol-style.
4246         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
4247         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added property svn:eol-style.
4248         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added property svn:eol-style.
4249         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added property svn:eol-style.
4250         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
4251         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added property svn:eol-style.
4252         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added property svn:eol-style.
4253         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
4254         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added property svn:eol-style.
4255         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
4256         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added property svn:eol-style.
4257         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added property svn:eol-style.
4258         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added property svn:eol-style.
4259         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
4260         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added property svn:eol-style.
4261         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added property svn:eol-style.
4262         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
4263         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added property svn:eol-style.
4264         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added property svn:eol-style.
4265         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added property svn:eol-style.
4266         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added property svn:eol-style.
4267         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added property svn:eol-style.
4268         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added property svn:eol-style.
4269         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added property svn:eol-style.
4270         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added property svn:eol-style.
4271         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
4272         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added property svn:eol-style.
4273         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added property svn:eol-style.
4274         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added property svn:eol-style.
4275         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
4276         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added property svn:eol-style.
4277         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added property svn:eol-style.
4278         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
4279         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added property svn:eol-style.
4280         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added property svn:eol-style.
4281         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added property svn:eol-style.
4282         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added property svn:eol-style.
4283         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added property svn:eol-style.
4284         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added property svn:eol-style.
4285         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added property svn:eol-style.
4286
4287 2013-02-14  Tony Chang  <tony@chromium.org>
4288
4289         Unreviewed, set svn:eol-style CRLF for .sln files.
4290
4291         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
4292         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
4293         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-