[Win][WebKitTestRunner] Error: test and reference images have different sizes. Test...
[WebKit-https.git] / Tools / ChangeLog
1 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
4         https://bugs.webkit.org/show_bug.cgi?id=193891
5
6         Reviewed by Ross Kirsling.
7
8         There were three problems in window sizes of WebView and the host window.
9         1. The sizes of pixel image output were incorrect.
10         2. The host window is going to appear after window.resize was invoked.
11         3. window.resize resized only the host window, not WebView.
12
13         This change solves them with a following approach.
14         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
15         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
16            as well as DumpRenderTree in order to match the client area and the window area.
17         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
18         d. PlatformWebView::setWindowFrame changes both window sizes.
19         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
20
21         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
22         (WTR::PlatformWebView::PlatformWebView): Create the host window
23         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
24         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
25         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
26
27 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
28
29         [ews-app] Add method to save Step data to database
30         https://bugs.webkit.org/show_bug.cgi?id=193890
31
32         Reviewed by Lucas Forschler.
33
34         * BuildSlaveSupport/ews-app/ews/models/step.py:
35         (Step.save_step): Method to save step data.
36         (Step.update_step): Method to update step data.
37         (Step.get_existing_step): Method to fetch existing step from database.
38         (Step.is_valid_result): Method to validate valid step result.
39
40 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
41
42         [ews-app] Add method to save Build data to database
43         https://bugs.webkit.org/show_bug.cgi?id=193735
44
45         Reviewed by Lucas Forschler.
46
47         * BuildSlaveSupport/ews-app/ews/models/build.py:
48         (Build.save_build): Method to save build information to database.
49         (Build.get_existing_build): Method to fetch existing build from database.
50         (Build.is_valid_result): Method to validate build result.
51         * BuildSlaveSupport/ews-app/ews/common/util.py:
52         (is_valid_int_id): Method to validate valid id.
53
54 2019-01-28  Chris Dumez  <cdumez@apple.com>
55
56         Regression(PSON) Crash under WebPageProxy::didStartProgress()
57         https://bugs.webkit.org/show_bug.cgi?id=193915
58         <rdar://problem/47560907>
59
60         Reviewed by Alex Christensen.
61
62         Add API test coverage.
63
64         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
65
66 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
67
68         [ews-app] Rename id variables
69         https://bugs.webkit.org/show_bug.cgi?id=193883
70
71         Reviewed by Lucas Forschler.
72
73         * BuildSlaveSupport/ews-app/ews/models/build.py:
74         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
75         * BuildSlaveSupport/ews-app/ews/models/step.py:
76         * BuildSlaveSupport/ews-app/ews/urls.py:
77         * BuildSlaveSupport/ews-app/ews/views/patch.py:
78         * BuildSlaveSupport/ews-app/ews/views/results.py:
79         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
80
81 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
82
83         [ews-app] Allow certain fields to be empty
84         https://bugs.webkit.org/show_bug.cgi?id=193892
85
86         Reviewed by Lucas Forschler.
87
88         * BuildSlaveSupport/ews-app/ews/models/build.py:
89         * BuildSlaveSupport/ews-app/ews/models/step.py:
90
91 2019-01-28  Rob Buis  <rbuis@igalia.com>
92
93         Update MIME type parser
94         https://bugs.webkit.org/show_bug.cgi?id=180526
95
96         Reviewed by Frédéric Wang.
97
98         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
99         (TestWebKitAPI::TEST):
100
101 2019-01-28  Zalan Bujtas  <zalan@apple.com>
102
103         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
104         https://bugs.webkit.org/show_bug.cgi?id=193896
105
106         Reviewed by Antti Koivisto.
107
108         * LayoutReloaded/misc/LFC-passing-tests.txt:
109
110 2018-12-15  Darin Adler  <darin@apple.com>
111
112         Replace many uses of String::format with more type-safe alternatives
113         https://bugs.webkit.org/show_bug.cgi?id=192742
114
115         Reviewed by Mark Lam.
116
117         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
118         (WTR::cacheTestRunnerCallback): Use makeString.
119         * WebKitTestRunner/TestController.cpp:
120         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
121         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
122
123 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
124
125         Use a load optimizer for some sites
126         https://bugs.webkit.org/show_bug.cgi?id=193881
127         <rdar://problem/46325455>
128
129         Reviewed by Brent Fulgham.
130
131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
132         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
133
134 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
135
136         AX: Introduce a static accessibility tree
137         https://bugs.webkit.org/show_bug.cgi?id=193348
138         <rdar://problem/47203295>
139
140         Reviewed by Ryosuke Niwa.
141
142         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
143
144 2019-01-26  Zalan Bujtas  <zalan@apple.com>
145
146         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
147         https://bugs.webkit.org/show_bug.cgi?id=193867
148
149         Reviewed by Antti Koivisto.
150
151         * LayoutReloaded/misc/LFC-passing-tests.txt:
152
153 2019-01-26  Zalan Bujtas  <zalan@apple.com>
154
155         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
156         https://bugs.webkit.org/show_bug.cgi?id=193865
157
158         Reviewed by Antti Koivisto.
159
160         * LayoutReloaded/misc/LFC-passing-tests.txt:
161
162 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
163
164         Need a mechanism to override navigator.userAgent
165         https://bugs.webkit.org/show_bug.cgi?id=193762
166         <rdar://problem/47504939>
167
168         Reviewed by Brent Fulgham.
169
170         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
171
172         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
173         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
174         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
175
176 2019-01-25  Dean Jackson  <dino@apple.com>
177
178         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
179         https://bugs.webkit.org/show_bug.cgi?id=193831
180         <rdar://problem/47399263>
181
182         Reviewed by Chris Dumez.
183
184         Two new tests that exercise cross-origin and same-origin System
185         Previews.
186
187         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
188
189 2019-01-25  Keith Rollin  <krollin@apple.com>
190
191         Update Xcode projects with "Check .xcfilelists" build phase
192         https://bugs.webkit.org/show_bug.cgi?id=193790
193         <rdar://problem/47201374>
194
195         Reviewed by Alex Christensen.
196
197         Support for XCBuild includes specifying inputs and outputs to various
198         Run Script build phases. These inputs and outputs are specified as
199         .xcfilelist files. Once created, these .xcfilelist files need to be
200         kept up-to-date. In order to check that they are up-to-date or not,
201         add an Xcode build step that invokes an external script that performs
202         the checking. If the .xcfilelists are found to be out-of-date, update
203         them, halt the build, and instruct the developer to restart the build
204         with up-to-date files.
205
206         At this time, the checking and regenerating is performed only if the
207         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
208         who want to use this facility can set this variable and test out the
209         checking/regenerating. Once it seems like there are no egregious
210         issues that upset a developer's workflow, we'll unconditionally enable
211         this facility.
212
213         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
214         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
215         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
216         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
217
218 2019-01-25  Keith Rollin  <krollin@apple.com>
219
220         Update Xcode projects with "Apply Configuration to XCFileLists" build target
221         https://bugs.webkit.org/show_bug.cgi?id=193781
222         <rdar://problem/47201153>
223
224         Reviewed by Alex Christensen.
225
226         Part of generating the .xcfilelists used as part of adopting XCBuild
227         includes running `make DerivedSources.make` from a standalone script.
228         It’s important for this invocation to have the same environment as
229         when the actual build invokes `make DerivedSources.make`. If the
230         environments are different, then the two invocations will provide
231         different results. In order to get the same environment in the
232         standalone script, have the script launch xcodebuild targeting the
233         "Apply Configuration to XCFileLists" build target, which will then
234         re-invoke our standalone script. The script is now running again, this
235         time in an environment with all workspace, project, target, xcconfig
236         and other environment variables established.
237
238         The "Apply Configuration to XCFileLists" build target accomplishes
239         this task via a small embedded shell script that consists only of:
240
241             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
242
243         The process that invokes "Apply Configuration to XCFileLists" first
244         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
245         evaluated and exports it into the shell environment. When xcodebuild
246         is invoked, it inherits the value of this variable and can `eval` the
247         contents of that variable. Our external standalone script can then set
248         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
249         of command-line parameters needed to restart itself in the appropriate
250         state.
251
252         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
253         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
254
255 2019-01-25  Alex Christensen  <achristensen@webkit.org>
256
257         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
258         https://bugs.webkit.org/show_bug.cgi?id=193802
259         <rdar://problem/46010580>
260
261         Reviewed by Andy Estes.
262
263         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
264         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
265         (TEST):
266
267 2019-01-25  Daniel Bates  <dabates@apple.com>
268
269         [iOS] uiController.keyDown() does not translate Control modified key
270         https://bugs.webkit.org/show_bug.cgi?id=192898
271
272         Reviewed by Wenson Hsieh.
273
274         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
275         key translation, as applicable. Among other cases, key translation occurs when performing
276         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
277         also makes the behavior of uiController.keyDown() more closely match the behavior of a
278         human pressing down and releasing key(s) using a hardware keyboard.
279
280         * WebKitTestRunner/ios/HIDEventGenerator.h:
281         * WebKitTestRunner/ios/HIDEventGenerator.mm:
282         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
283
284         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
285         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
286         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
287         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
288         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
289         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
290         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
291         (-[HIDEventGenerator longPress:completionBlock:]):
292         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
293         Update code for above renaming.
294
295         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
296         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
297
298         (-[HIDEventGenerator keyDown:]): Added.
299         (-[HIDEventGenerator keyUp:]): Added.
300         (-[HIDEventGenerator keyPress:completionBlock:]):
301         (-[HIDEventGenerator eventDispatchThreadEntry:]):
302         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
303         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
304         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
305         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
306         (WTR::parseModifier): Deleted.
307
308 2019-01-25  Keith Rollin  <krollin@apple.com>
309
310         Complete the implementation of generate-xcfilelists
311         https://bugs.webkit.org/show_bug.cgi?id=193782
312
313         Reviewed by Alex Christensen.
314
315         A preliminary version of generate-xcfilelists was added in r238008.
316         This patch updates that script in order to:
317
318         - Support checking of .xcfilelists
319         - Perform better execution of `make DerivedSources.make` by
320           relaunching generate-xcfilelists under xcodebuild
321         - Support incremental generation and checking of .xcfilelists
322         - Support supplementary .xcfilelists files from WebKitAdditions
323         - Support being wrapped by parallel version of generate-xcfilelists in
324           Internal that adds support for (re)generating WebKit projects in
325           that repo.
326         - Support builds that have been performed in WebKitBuild as well as
327           ~/Library/Developer/code/DerivedData
328         - Increase robustness and debugging facilities.
329
330         * Scripts/generate-xcfilelists:
331
332 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
333
334         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
335         https://bugs.webkit.org/show_bug.cgi?id=193297
336         <rdar://problem/47158841>
337
338         Unreviewed test case fix.
339
340         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
341         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
342
343         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
344         (TEST):
345
346 2019-01-25  Keith Rollin  <krollin@apple.com>
347
348         Update existing .xcfilelists
349         https://bugs.webkit.org/show_bug.cgi?id=193791
350         <rdar://problem/47201706>
351
352         Reviewed by Alex Christensen.
353
354         Many .xcfilelist files were added in r238824 in order to support
355         XCBuild. Update these with recent changes to the set of build files
356         and with the current generate-xcfilelist script.
357
358         * DumpRenderTree/DerivedSources-input.xcfilelist:
359         * DumpRenderTree/DerivedSources-output.xcfilelist:
360         * WebKitTestRunner/DerivedSources-input.xcfilelist:
361         * WebKitTestRunner/DerivedSources-output.xcfilelist:
362
363 2019-01-25  Keith Rollin  <krollin@apple.com>
364
365         Fix missing dependencies in extract-dependencies-from-makefile
366         https://bugs.webkit.org/show_bug.cgi?id=193783
367         <rdar://problem/47201571>
368
369         Reviewed by Alex Christensen.
370
371         The extract-dependencies-from-makefile script generates .xcfilelists
372         for XCBuild by invoking a makefile in --debug mode, parsing the
373         dependency information in the output, and extracting information
374         regarding targets and dependents. However, the way `make` emits this
375         dependency information is not rigorous, and so we need to determine
376         what lines to look for and parse by trial and error. This approach
377         didn't coriginally atch all the information we needed to collect, so
378         update the script to look for the additional lines we now know to look
379         for.
380
381         * Scripts/extract-dependencies-from-makefile:
382         (Parser):
383         (Parser.addTarget):
384         (Parser.addPrereq):
385         (Parser.doParse):
386
387 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
388
389         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
390         https://bugs.webkit.org/show_bug.cgi?id=193297
391         <rdar://problem/47158841>
392
393         Reviewed by Alex Christensen.
394
395         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
396             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
397         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
398         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
399         activating the message used to trigger the callback when it is set.
400
401 2019-01-25  Alex Christensen  <achristensen@webkit.org>
402
403         WKWebView.goBack should reload if there is a safe browsing warning
404         https://bugs.webkit.org/show_bug.cgi?id=193805
405         <rdar://problem/46908216>
406
407         Reviewed by Geoff Garen.
408
409         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
410         (+[Simple3LookupContext sharedLookupContext]):
411         (-[Simple3LookupContext lookUpURL:completionHandler:]):
412         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
413         (TEST):
414
415 2019-01-25  Chris Dumez  <cdumez@apple.com>
416
417         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
418         https://bugs.webkit.org/show_bug.cgi?id=193788
419         <rdar://problem/47531231>
420
421         Reviewed by Alex Christensen.
422
423         Add API test coverage.
424
425         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
426         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
427
428 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
429
430         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
431         https://bugs.webkit.org/show_bug.cgi?id=193771
432
433         Unreviewed infrastructure fix.
434
435         * Scripts/webkitpy/port/darwin.py:
436         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
437
438 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
439
440         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
441
442 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
443
444         Add contributors.json entries for Ling Ho and for a new bot watchers group.
445
446         * Scripts/webkitpy/common/config/contributors.json:
447
448 2019-01-25  Chris Dumez  <cdumez@apple.com>
449
450         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
451         https://bugs.webkit.org/show_bug.cgi?id=193779
452         <rdar://problem/46170903>
453
454         Reviewed by Antti Koivisto.
455
456         Add API test that quickly navigates forward to a previous process without waiting for it to
457         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
458         the process' previous page when reconnecting the it for the forward navigation.
459
460         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
461
462 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
463
464         Need a way for JavaScript (or bundle) code to participate in undo
465         https://bugs.webkit.org/show_bug.cgi?id=190009
466         <rdar://problem/44807048>
467
468         Reviewed by Ryosuke Niwa.
469
470         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
471         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
472
473         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
474         (WTR::UIScriptController::lastUndoLabel const):
475         (WTR::UIScriptController::firstRedoLabel const):
476         (WTR::UIScriptController::platformUndoManager const):
477         * DumpRenderTree/mac/UIScriptControllerMac.mm:
478         (WTR::UIScriptController::lastUndoLabel const):
479         (WTR::UIScriptController::firstRedoLabel const):
480         (WTR::UIScriptController::platformUndoManager const):
481         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
482         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
483         (WTR::UIScriptController::lastUndoLabel const):
484         (WTR::UIScriptController::firstRedoLabel const):
485         * TestRunnerShared/UIScriptContext/UIScriptController.h:
486         * WebKitTestRunner/UIScriptControllerCocoa.mm:
487         (WTR::UIScriptController::lastUndoLabel const):
488         (WTR::UIScriptController::firstRedoLabel const):
489         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
490         (WTR::UIScriptController::platformUndoManager const):
491         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
492         (WTR::UIScriptController::platformUndoManager const):
493
494 2019-01-25  Zalan Bujtas  <zalan@apple.com>
495
496         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
497         https://bugs.webkit.org/show_bug.cgi?id=193824
498
499         Reviewed by Antti Koivisto.
500
501         * LayoutReloaded/misc/LFC-passing-tests.txt:
502
503 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
504
505         Update macOS JSC bot configurations
506         https://bugs.webkit.org/show_bug.cgi?id=193739
507
508         Reviewed by Alexey Proskuryakov.
509
510         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
511         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
512         (BubbleQueueServer): Move JSC EWS to Mojave section.
513         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
514         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
515         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
516
517 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
518
519         [Win][WebKitTestRunner] Implement EventSenderProxy
520         https://bugs.webkit.org/show_bug.cgi?id=193755
521
522         Reviewed by Don Olmstead.
523
524         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
525         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
526         (WTR::EventSenderProxy::dispatchMessage):
527         (WTR::EventSenderProxy::EventSenderProxy):
528         (WTR::EventSenderProxy::mouseDown):
529         (WTR::EventSenderProxy::mouseUp):
530         (WTR::EventSenderProxy::mouseMoveTo):
531         (WTR::EventSenderProxy::mouseScrollBy):
532         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
533
534 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
535
536         Unreviewed fix for API test failure after r240437.
537
538         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
539
540         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
541
542 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
543
544         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
545         https://bugs.webkit.org/show_bug.cgi?id=193787
546         <rdar://problem/47497634>
547
548         Reviewed by Alexey Proskuryakov.
549
550         * Scripts/webkitdirs.pm:
551         (iosSimulatorApplicationsPath): Pick from available runtime directories.
552
553 2019-01-24  Truitt Savell  <tsavell@apple.com>
554
555         Unreviewed, rolling out r240446.
556
557         Casued 5 API failures
558
559         Reverted changeset:
560
561         "Activate the WebResourceLoadStatisticsStore in the
562         NetworkProcess and deactivate it in the UIProcess."
563         https://bugs.webkit.org/show_bug.cgi?id=193297
564         https://trac.webkit.org/changeset/240446
565
566 2019-01-24  Zalan Bujtas  <zalan@apple.com>
567
568         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
569         https://bugs.webkit.org/show_bug.cgi?id=193741
570         <rdar://problem/47135030>
571
572         Reviewed by Antti Koivisto and Simon Fraser.
573
574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
575         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
576         (TestWebKitAPI::TEST):
577
578 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
579
580         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
581         https://bugs.webkit.org/show_bug.cgi?id=193297
582         <rdar://problem/47158841>
583
584         Reviewed by Alex Christensen.
585
586         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
587         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
588         activating the message used to trigger the callback when it is set.
589
590 2019-01-24  John Wilander  <wilander@apple.com>
591
592         Add Ad Click Attribution as an internal/experimental feature
593         https://bugs.webkit.org/show_bug.cgi?id=193685
594         <rdar://problem/47450399>
595
596         Reviewed by Brent Fulgham.
597
598         Added test option adClickAttributionEnabled.
599
600         * DumpRenderTree/TestOptions.cpp:
601         (TestOptions::TestOptions):
602         * DumpRenderTree/TestOptions.h:
603         * DumpRenderTree/mac/DumpRenderTree.mm:
604         (setWebPreferencesForTestOptions):
605
606 2019-01-24  Antti Koivisto  <antti@apple.com>
607
608         [PSON] Flash on back navigation on Mac
609         https://bugs.webkit.org/show_bug.cgi?id=193716
610         <rdar://problem/47148458>
611
612         Reviewed by Chris Dumez.
613
614         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
615
616         Closing of the previous page is delayed so waiting for didFinishNavigation is
617         not sufficient to guarantee we have received all the messages. Wait for them.
618
619 2019-01-24  Chris Dumez  <cdumez@apple.com>
620
621         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
622         https://bugs.webkit.org/show_bug.cgi?id=193761
623         <rdar://problem/47456405>
624
625         Reviewed by Alex Christensen.
626
627         Add API test coverage.
628
629         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
630
631 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
632
633         webkitpy: Missing PID in crashlog name should not be fatal
634         https://bugs.webkit.org/show_bug.cgi?id=193771
635
636         If we can't determine the PID of a crashlog, just ignore the crashlog instead
637         of raising an exception.
638
639         Reviewed by Lucas Forschler.
640
641         * Scripts/webkitpy/port/darwin.py:
642         (DarwinPort._merge_crash_logs):
643
644 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
645
646         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
647         https://bugs.webkit.org/show_bug.cgi?id=193746
648
649         Reviewed by Youenn Fablet.
650
651         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
652         so we'd best just not call it.
653
654         * Scripts/webkitpy/w3c/test_exporter.py:
655         (WebPlatformTestExporter.create_branch_with_patch):
656
657 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
658
659         Move FileSystem to WTF
660         https://bugs.webkit.org/show_bug.cgi?id=193602
661
662         Reviewed by Yusuke Suzuki.
663
664         * DumpRenderTree/win/DumpRenderTree.cpp:
665         * TestWebKitAPI/CMakeLists.txt:
666         * TestWebKitAPI/PlatformGTK.cmake:
667         * TestWebKitAPI/PlatformJSCOnly.cmake:
668         * TestWebKitAPI/PlatformPlayStation.cmake:
669         * TestWebKitAPI/PlatformWPE.cmake:
670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
671         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
672         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
673         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
674         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
675         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
676         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
677         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
678         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
679         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
680
681 2019-01-24  Philippe Normand  <pnormand@igalia.com>
682
683         [WPE] Remove hard dependency on subprocess32 for the API tests
684
685         Rubber-stamped by Carlos Garcia Campos.
686
687         * glib/api_test_runner.py:
688         (TestRunner._run_test_qt): Lazily import subprocess32 and check
689         its presence only when running WPEQt tests.
690
691 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
692
693         [GLIB] Expose JavaScriptCore options in GLib public API
694         https://bugs.webkit.org/show_bug.cgi?id=188742
695
696         Reviewed by Michael Catanzaro.
697
698         Add a test for the new API.
699
700         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
701         (testsJSCOptions):
702         (main):
703
704 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
705
706         [GTK][WPE] Support JPEG 2000 images
707         https://bugs.webkit.org/show_bug.cgi?id=186272
708
709         Reviewed by Žan Doberšek.
710
711         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
712
713         * gtk/jhbuild.modules:
714         * wpe/jhbuild.modules:
715
716 2019-01-23  David Kilzer  <ddkilzer@apple.com>
717
718         check-webkit-style should warn when using soft-linking macros in a header
719         <https://webkit.org/b/193750>
720
721         Reviewed by Darin Adler.
722
723         * Scripts/webkitpy/style/checkers/cpp.py:
724         (check_language): Add softlink/header check by refactoring the
725         softlink/framework check.
726         (CppChecker): Enable softlink/header check by default.
727         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
728         (CppStyleTest.test_softlink_framework): Rename from
729         CppStyleTest.test_softlink() and change test framework name in
730         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
731         files. Set file_name for macros that only appear in headers.
732         (CppStyleTest.test_softlink_header): Add tests for using
733         soft-link macros in headers.
734
735 2019-01-23  Chris Dumez  <cdumez@apple.com>
736
737         Deprecate API to limit the maximum number of WebProcesses
738         https://bugs.webkit.org/show_bug.cgi?id=193725
739         <rdar://problem/47464879>
740
741         Reviewed by Geoff Garen.
742
743         Update existing API tests to stop using deprecated API.
744
745         * MiniBrowser/mac/AppDelegate.m:
746         (defaultConfiguration):
747         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
748         (TestWebKitAPI::TEST):
749         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
750         (TestWebKitAPI::TEST):
751         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
752         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
753         (TEST):
754         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
755         (TEST):
756
757 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
758
759         [ews-app] Rename ews model buildermappings to buildermapping
760         https://bugs.webkit.org/show_bug.cgi?id=193729
761
762         Reviewed by Lucas Forschler.
763
764         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
765         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
766         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
767
768 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
769
770         [ews-app] Rename ews model steps to step
771         https://bugs.webkit.org/show_bug.cgi?id=193697
772
773         Reviewed by Lucas Forschler.
774
775         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
776         (Step): Renamed Steps to Step.
777
778 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
779
780         Clean up IndexedDB files between tests
781         https://bugs.webkit.org/show_bug.cgi?id=192796
782         <rdar://problem/46824999>
783
784         Reviewed by Geoffrey Garen.
785
786         * DumpRenderTree/mac/DumpRenderTree.mm:
787         (runTest):
788         * WebKitTestRunner/TestController.cpp:
789         (WTR::TestController::resetStateToConsistentValues):
790         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
791         (WTR::RemoveAllIndexedDatabasesCallback):
792         (WTR::TestController::ClearIndexedDatabases):
793         * WebKitTestRunner/TestController.h:
794         * WebKitTestRunner/TestInvocation.cpp:
795         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
796
797 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
798
799         [ews-app] Rename ews model Builds to Build
800         https://bugs.webkit.org/show_bug.cgi?id=193695
801
802         Reviewed by Lucas Forschler.
803
804         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
805         (Build): Renamed Builds to Build.
806
807 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
808
809         webkitpy: Wait longer when launching WebKitTestRunner
810         https://bugs.webkit.org/show_bug.cgi?id=193734
811
812         Reviewed by Aakash Jain.
813
814         * Scripts/webkitpy/port/simulator_process.py:
815         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
816
817 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
818
819         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
820         https://bugs.webkit.org/show_bug.cgi?id=193182
821         <rdar://problem/47452154>
822
823         Reviewed by Tim Horton.
824
825         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
826         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
827         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
828
829         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
830         preventing later tests from recognizing gestures.
831
832         * WebKitTestRunner/ios/TestControllerIOS.mm:
833         (WTR::TestController::platformResetStateToConsistentValues):
834
835         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
836
837 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
838
839         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
840         https://bugs.webkit.org/show_bug.cgi?id=193722
841         <rdar://problem/47481475>
842
843         Reviewed by Lucas Forschler.
844
845         iPhone and iPad ports should both use the iOS config.
846
847         * Scripts/webkitpy/port/ios_simulator.py:
848         (IPhoneSimulatorPort.__init__):
849         (IPadSimulatorPort.__init__):
850
851 2019-01-23  Rob Buis  <rbuis@igalia.com>
852
853         Update MIME type parser
854         https://bugs.webkit.org/show_bug.cgi?id=180526
855
856         Reviewed by Frédéric Wang.
857
858         Add unit tests for both parse modes of ParsedContentType.
859
860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
861         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
862         (TestWebKitAPI::TEST):
863
864 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
865
866         [ews-app] fetch loop should not stop on network issues
867         https://bugs.webkit.org/show_bug.cgi?id=193666
868
869         Reviewed by Lucas Forschler.
870
871         * BuildSlaveSupport/ews-app/ews/fetcher.py:
872         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
873
874 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
875
876         [iOS] Multiple WKWebViewAutofillTests are flaky failures
877         https://bugs.webkit.org/show_bug.cgi?id=189165
878         <rdar://problem/47433765>
879
880         Reviewed by Tim Horton.
881
882         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
883         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
884         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
885         process in sufficient to ensure that any previous action that blurred the focused element in the web process
886         would make its way to the UI process by the time the layer tree commit is finished.
887
888         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
889         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
890         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
891         will fail because it asks for -_autofillContext too early.
892
893         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
894         is handled in the UI process.
895
896         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
897
898         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
899         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
900         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
901         input session.
902
903         (-[AutofillTestView textInputHasAutofillContext]):
904
905         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
906
907         * TestWebKitAPI/cocoa/TestWKWebView.h:
908         * TestWebKitAPI/cocoa/TestWKWebView.mm:
909         (nextInputSessionChangeCount):
910
911         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
912         This includes changing the focused element from one to another.
913
914         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
915         (-[TestWKWebView didStartFormControlInteraction]):
916         (-[TestWKWebView didEndFormControlInteraction]):
917         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
918
919         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
920         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
921         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
922         that doesn't require an input session to one that doesn't.
923
924 2019-01-22  David Kilzer  <ddkilzer@apple.com>
925
926         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
927         <https://webkit.org/b/193676>
928
929         Reviewed by Alexey Proskuryakov.
930
931         * Scripts/webkitpy/style/checkers/cpp.py:
932         (check_member_initialization_list):
933         - Don't report missing whitespace around colon if the colon at
934           the start of the line is formatted correctly.
935         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
936         (WebKitStyleTest.test_member_initialization_list):
937         - Add a test for a missing permutation of existing tests.
938         - Add a test this false-positive.
939         - Add blank lines between subtests to make them easier to read.
940
941 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
942
943         [build.webkit.org] Unit-test failure after r237113
944         https://bugs.webkit.org/show_bug.cgi?id=193669
945
946         Reviewed by Michael Catanzaro.
947
948         * BuildSlaveSupport/build.webkit.org-config/factories.py:
949         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
950         multiple or zero flags.
951
952 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
953
954         Cache bytecode to disk
955         https://bugs.webkit.org/show_bug.cgi?id=192782
956         <rdar://problem/46084932>
957
958         Reviewed by Keith Miller.
959
960         Add test helper to execute bytecode-cache tests: it executes each test
961         twice, the first with JSC_diskCachePath set to a temporary directory
962         and second with JSC_forceDiskCache=true (in addition to the cache path)
963         to guarantee that only the disk cache is being used and no new
964         UnlinkedCodeBlocks are being created.
965
966         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
967         * Scripts/run-jsc-stress-tests:
968
969 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
970
971         [css-logical] Implement flow-relative margin, padding and border shorthands
972         https://bugs.webkit.org/show_bug.cgi?id=188697
973
974         Reviewed by Simon Fraser and Antti Koivisto.
975
976         * DumpRenderTree/TestOptions.cpp:
977         (TestOptions::TestOptions):
978         * DumpRenderTree/TestOptions.h:
979         * DumpRenderTree/mac/DumpRenderTree.mm:
980         (setWebPreferencesForTestOptions):
981         Allow tests to enable the CSSLogicalEnabled flag in WK1.
982
983         * Scripts/webkitpy/style/checkers/jsonchecker.py:
984         (JSONCSSPropertiesChecker.check_codegen_properties):
985         Allow CSS property definitions to have a 'runtime-flag' parameter which
986         disables the property when the specified runtime flag is disabled.
987
988 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
989
990         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
991         https://bugs.webkit.org/show_bug.cgi?id=193643
992
993         Reviewed by Michael Catanzaro.
994
995         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
996         * wpe/jhbuild.modules: Ditto.
997
998 2019-01-21  Zalan Bujtas  <zalan@apple.com>
999
1000         [LFC][Floats] Take float top position into account when computing containing block height.
1001         https://bugs.webkit.org/show_bug.cgi?id=193655
1002
1003         Reviewed by Antti Koivisto.
1004
1005         * LayoutReloaded/misc/LFC-passing-tests.txt:
1006
1007 2019-01-21  David Kilzer  <ddkilzer@apple.com>
1008
1009         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
1010         <https://webkit.org/b/193645>
1011         <rdar://problem/47421574>
1012
1013         Reviewed by Alex Christensen.
1014
1015         - Now checks for local soft-linking of all frameworks that have
1016           their own *SoftLinking.{cpp,h,mm} files.
1017         - Changes softlink/uikit warning to softlink/framework.
1018
1019         * Scripts/webkitpy/style/checkers/cpp.py:
1020         (check_language):
1021         (CppChecker):
1022         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1023         (CppStyleTest):
1024
1025 2019-01-20  Saam Barati  <sbarati@apple.com>
1026
1027         Rollout r240210: It broke tests on iOS
1028         https://bugs.webkit.org/show_bug.cgi?id=193640
1029
1030         Unreviewed.
1031
1032         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
1033         * Scripts/run-jsc-stress-tests:
1034
1035 2019-01-20  chris fleizach  <cfleizach@apple.com>
1036
1037         AX: Support returning relative frames for accessibility
1038         https://bugs.webkit.org/show_bug.cgi?id=193414
1039         <rdar://problem/47268501>
1040
1041         Reviewed by Zalan Bujtas.
1042
1043         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1044         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1045         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1046         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1047         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1048         (WTR::attributesOfElement):
1049         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1050
1051 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1052
1053         Unreviewed, add my new email address
1054
1055         * Scripts/webkitpy/common/config/contributors.json:
1056
1057 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1058
1059         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1060         https://bugs.webkit.org/show_bug.cgi?id=193617
1061
1062         Reviewed by Antti Koivisto.
1063
1064         * LayoutReloaded/misc/LFC-passing-tests.txt:
1065
1066 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1067
1068         Unreviewed, rolling out r240209.
1069
1070         Broke GTK/WPE injected bundle
1071
1072         Reverted changeset:
1073
1074         "AX: Support returning relative frames for accessibility"
1075         https://bugs.webkit.org/show_bug.cgi?id=193414
1076         https://trac.webkit.org/changeset/240209
1077
1078 2019-01-12  Dan Bernstein  <mitz@apple.com>
1079
1080         [Cocoa] Avoid importing directly from subumbrella frameworks
1081         https://bugs.webkit.org/show_bug.cgi?id=186016
1082         <rdar://problem/40591038>
1083
1084         Reviewed by Sam Weinig.
1085
1086         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1087           LaunchServices header.
1088         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1089           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1090         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1091           when using SDKs earlier than 10.13.
1092         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1093           and OTHER_CPLUSPLUSFLAGS.
1094         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1095           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1096         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1097           LaunchServices header.
1098
1099 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
1100
1101         Cache bytecode to disk
1102         https://bugs.webkit.org/show_bug.cgi?id=192782
1103         <rdar://problem/46084932>
1104
1105         Reviewed by Keith Miller.
1106
1107         Add test helper to execute bytecode-cache tests: it executes each test
1108         twice, the first with JSC_diskCachePath set to a temporary directory
1109         and second with JSC_forceDiskCache=true (in addition to the cache path)
1110         to guarantee that only the disk cache is being used and no new
1111         UnlinkedCodeBlocks are being created.
1112
1113         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
1114         * Scripts/run-jsc-stress-tests:
1115
1116 2019-01-20  chris fleizach  <cfleizach@apple.com>
1117
1118         AX: Support returning relative frames for accessibility
1119         https://bugs.webkit.org/show_bug.cgi?id=193414
1120         <rdar://problem/47268501>
1121
1122         Reviewed by Zalan Bujtas.
1123
1124         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1125         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1126         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1127         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1128         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1129         (WTR::attributesOfElement):
1130         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1131
1132 2019-01-20  Antoine Quint  <graouts@apple.com>
1133
1134         Add a POINTER_EVENTS feature flag
1135         https://bugs.webkit.org/show_bug.cgi?id=193577
1136         <rdar://problem/47408511>
1137
1138         Unreviewed. Also enable Pointer Events for iosmac.
1139
1140         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1141
1142 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1143
1144         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
1145         https://bugs.webkit.org/show_bug.cgi?id=193613
1146
1147         Reviewed by Antti Koivisto.
1148
1149         * LayoutReloaded/misc/LFC-passing-tests.txt:
1150
1151 2019-01-19  Antoine Quint  <graouts@apple.com>
1152
1153         Add a POINTER_EVENTS feature flag
1154         https://bugs.webkit.org/show_bug.cgi?id=193577
1155
1156         Reviewed by Dean Jackson.
1157
1158         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1159
1160 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
1161
1162         Disable the run-jsc-stress-test remote host key check [second round].
1163         https://bugs.webkit.org/show_bug.cgi?id=192988
1164
1165         Reviewed by Dewei Zhu.
1166
1167         * Scripts/run-jsc-stress-tests:
1168
1169 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1170
1171         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
1172         https://bugs.webkit.org/show_bug.cgi?id=193597
1173
1174         Reviewed by Lucas Forschler.
1175
1176         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1177
1178 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1179
1180         [build.webkit.org] api tests failures are incorrectly named as unit test failures
1181         https://bugs.webkit.org/show_bug.cgi?id=193595
1182
1183         Reviewed by Lucas Forschler.
1184
1185         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
1186         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
1187         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
1188
1189 2019-01-18  Chris Dumez  <cdumez@apple.com>
1190
1191         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
1192         https://bugs.webkit.org/show_bug.cgi?id=193588
1193         <rdar://problem/47131566>
1194
1195         Reviewed by Alex Christensen.
1196
1197         Add layout test coverage.
1198
1199         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1200
1201 2019-01-18  Jer Noble  <jer.noble@apple.com>
1202
1203         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1204         https://bugs.webkit.org/show_bug.cgi?id=189553
1205
1206         Reviewed by Tim Horton.
1207
1208         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1209
1210         * ContentExtensionTester/Configurations/Base.xcconfig:
1211         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1212         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1213         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1214         * ImageDiff/cg/Configurations/Base.xcconfig:
1215         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1216         * MiniBrowser/Configurations/Base.xcconfig:
1217         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1218         * MobileMiniBrowser/Configurations/Base.xcconfig:
1219         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1220         * Scripts/webkitpy/style/checker.py:
1221         (_all_categories):
1222         (FileType):
1223         (CheckerDispatcher._file_type):
1224         (CheckerDispatcher._create_checker):
1225         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1226         (SDKVariantChecker):
1227         (SDKVariantChecker.__init__):
1228         (SDKVariantChecker.check):
1229         * TestWebKitAPI/Configurations/Base.xcconfig:
1230         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1231         * WebEditingTester/Configurations/Base.xcconfig:
1232         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1233         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1234         * WebKitTestRunner/Configurations/Base.xcconfig:
1235         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1236         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1237         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1238
1239 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1240
1241         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1242         <https://webkit.org/b/193568>
1243         <rdar://problem/47381130>
1244
1245         Reviewed by Alex Christensen.
1246
1247         Make sure no one re-introduces UIKit soft-linking by adding a
1248         style rule.
1249
1250         * Scripts/webkitpy/style/checkers/cpp.py:
1251         (check_language): Add softlink/uikit check.
1252         (CppChecker): Enable softlink/uikit check.
1253         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1254         (CppStyleTest): Add test for softlink/uikit.
1255
1256 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
1257
1258         [GTK] install-dependencies tool looks for libunistring-dev for dnf
1259         https://bugs.webkit.org/show_bug.cgi?id=193584
1260
1261         Change "-dev" to "-devel".
1262
1263         Reviewed by Michael Catanzaro.
1264
1265         * gtk/install-dependencies:
1266
1267 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1268
1269         webkitpy: Add iPhone and iPad ports
1270         https://bugs.webkit.org/show_bug.cgi?id=193537
1271         <rdar://problem/47353390>
1272
1273         Reviewed by Lucas Forschler.
1274
1275         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
1276         ports. Note that this separation is optional, the --ios-simulator command remains.
1277
1278         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1279         (RunTest.test_device_type_test_division): Drive-by fix.
1280         (RunTest.test_device_type_specific_listing): Ditto.
1281         (RunTest.test_ipad_test_division):
1282         (RunTest):
1283         (RunTest.test_ipad_listing):
1284         * Scripts/webkitpy/port/factory.py:
1285         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
1286         (PortFactory):
1287         * Scripts/webkitpy/port/ios_simulator.py:
1288         (IPhoneSimulatorPort):
1289         (IPadSimulatorPort):
1290
1291 2019-01-18  Chris Dumez  <cdumez@apple.com>
1292
1293         Regression(PSON) Scroll position is not always restored properly when navigating back
1294         https://bugs.webkit.org/show_bug.cgi?id=193578
1295         <rdar://problem/47386331>
1296
1297         Reviewed by Tim Horton.
1298
1299         Add API test coverage.
1300
1301         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1302
1303 2019-01-18  Youenn Fablet  <youenn@apple.com>
1304
1305         Add a new SPI to request for cache storage quota increase
1306         https://bugs.webkit.org/show_bug.cgi?id=193323
1307
1308         Reviewed by Alex Christensen.
1309
1310         Implement WebsiteDataStore quota delegate to handle quota requests.
1311         By default, do not update quota.
1312         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
1313
1314         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1315         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1316         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
1317         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1318         * WebKitTestRunner/TestController.cpp:
1319         (WTR::TestController::allowCacheStorageQuotaIncrease):
1320         * WebKitTestRunner/TestController.h:
1321         * WebKitTestRunner/TestInvocation.cpp:
1322         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1323         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1324         (-[CacheStorageQuotaManager init]):
1325         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1326         (WTR::initializeWebViewConfiguration):
1327         (WTR::TestController::cocoaResetStateToConsistentValues):
1328         (WTR::TestController::allowCacheStorageQuotaIncrease):
1329
1330 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1331
1332         [ews-build] Pass owner to the triggered builds
1333         https://bugs.webkit.org/show_bug.cgi?id=193574
1334
1335         Reviewed by Lucas Forschler.
1336
1337         * BuildSlaveSupport/ews-build/factories.py:
1338         (BuildFactory.propertiesToPassToTriggers):
1339
1340 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
1341
1342         [ews-app] Send patch author as a build property
1343         https://bugs.webkit.org/show_bug.cgi?id=193560
1344
1345         Reviewed by Lucas Forschler.
1346
1347         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1348         (BugzillaPatchFetcher.fetch):
1349
1350 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1351
1352         webkitpy: Implement device type specific expected results (Follow-up fix)
1353         https://bugs.webkit.org/show_bug.cgi?id=192162
1354         <rdar://problem/46345449>
1355
1356         Unreviewed infrastructure fix.
1357
1358         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1359         (Manager.run): Don't boot a device if no tests are available to run on it.
1360
1361 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1362
1363         webkitpy: Implement device type specific expected results (Follow-up fix)
1364         https://bugs.webkit.org/show_bug.cgi?id=192162
1365         <rdar://problem/46345449>
1366
1367         Unreviewed infrastructure fix.
1368
1369         * Scripts/webkitpy/api_tests/manager.py:
1370         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
1371
1372 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
1373
1374         webkitpy: Implement device type specific expected results (Part 2)
1375         https://bugs.webkit.org/show_bug.cgi?id=192162
1376         <rdar://problem/46345449>
1377
1378         Rubber-stamped by Aakash Jain.
1379
1380         This change uses device_type to select a different set of TestExpectation files based on the type of device running
1381         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
1382         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
1383
1384         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1385         (LayoutTestFinder.find_tests): Pass device_type through.
1386         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
1387         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
1388         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1389         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
1390         (Manager._collect_tests): Pass device type to test finder.
1391         (Manager._needs_web_platform_test):
1392         (Manager._prepare_lists): Index _expectations by device type.
1393         (Manager._test_input_for_file):
1394         (Manager._test_is_slow): Ditto.
1395         (Manager._test_should_dump_jsconsolelog_in_stderr):
1396         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
1397         (Manager._get_test_inputs):
1398         (Manager._update_worker_count):
1399         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
1400         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
1401         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
1402         the one which runs the test.
1403         (Manager._run_test_subset):
1404         (Manager._run_tests): Index _expectations by current_device_type.
1405         (Manager._print_expectation_line_for_test): Ditto.
1406         (Manager._print_expectations_for_subset): Ditto.
1407         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
1408         Unlike run, this function will behave the same regardless of what devices are available.
1409         (Manager._custom_device_for_test): Deleted.
1410         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1411         (ManagerTest.test_uses_custom_device): Deleted.
1412         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
1413         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1414         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
1415         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
1416         all of the expectations.
1417         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1418         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
1419         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1420         (TestExpectations.__init__): Allow device_type to be passed through.
1421         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
1422         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
1423         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1424         (summarize_results):
1425         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1426         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
1427         a test ran with, one must check all expectations to find the first non-skip expectation.
1428         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1429         (RunTest.test_device_type_test_division):
1430         (RunTest):
1431         (RunTest.test_device_type_specific_listing):
1432         * Scripts/webkitpy/port/base.py:
1433         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
1434         (Port.supported_device_types): The result of this function will change based on what devices are available.
1435         * Scripts/webkitpy/port/device_port.py:
1436         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
1437         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
1438         can be used.
1439         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
1440         any, or the DEFAULT_DEVICE_TYPES of the port.
1441         * Scripts/webkitpy/port/ios.py:
1442         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1443         * Scripts/webkitpy/port/ios_simulator.py:
1444         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
1445         * Scripts/webkitpy/port/watch.py:
1446         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
1447         * Scripts/webkitpy/port/watch_simulator.py:
1448         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
1449         * Scripts/webkitpy/xcode/device_type.py:
1450         (DeviceType):
1451         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
1452
1453 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1454
1455         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
1456         https://bugs.webkit.org/show_bug.cgi?id=193575
1457
1458         Reviewed by Michael Catanzaro.
1459
1460         Allow the script to run without explicit port argument because
1461         it's specific to the WPE port anyway.
1462
1463         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
1464         and simplify the rest of the code accordingly.
1465
1466 2019-01-18  Charlie Turner  <cturner@igalia.com>
1467
1468         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
1469         https://bugs.webkit.org/show_bug.cgi?id=192229
1470
1471         Reviewed by Xabier Rodriguez-Calvar.
1472
1473         * MiniBrowser/wpe/main.cpp:
1474         (main): Enable encrypted-media by default.
1475
1476 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1477
1478         [Flatpak] Missing KeyboardInterrupt exception handler
1479         https://bugs.webkit.org/show_bug.cgi?id=193570
1480
1481         Reviewed by Michael Catanzaro.
1482
1483         * flatpak/flatpakutils.py:
1484         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
1485
1486 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1487
1488         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
1489         https://bugs.webkit.org/show_bug.cgi?id=193564
1490
1491         Reviewed by Antti Koivisto.
1492
1493         * LayoutReloaded/misc/LFC-passing-tests.txt:
1494
1495 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1496
1497         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
1498         https://bugs.webkit.org/show_bug.cgi?id=193562
1499
1500         Reviewed by Antti Koivisto.
1501
1502         * LayoutReloaded/misc/LFC-passing-tests.txt:
1503
1504 2019-01-18  Zalan Bujtas  <zalan@apple.com>
1505
1506         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
1507         https://bugs.webkit.org/show_bug.cgi?id=193555
1508
1509         Reviewed by Antti Koivisto.
1510
1511         * LayoutReloaded/misc/LFC-passing-tests.txt:
1512
1513 2019-01-18  Philippe Normand  <pnormand@igalia.com>
1514
1515         [WPE] Add Qt extension
1516         https://bugs.webkit.org/show_bug.cgi?id=191464
1517
1518         Reviewed by Carlos Garcia Campos.
1519
1520         MiniBrowser and API tests for the WPE Qt API. To run the
1521         MiniBrowser a new script is introduced. Example invocation:
1522
1523         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
1524
1525         Also note-worthy is the introduction of the python2-subprocess32
1526         dependency to run the GLib API tests.
1527
1528         * MiniBrowser/wpe/CMakeLists.txt:
1529         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
1530         * MiniBrowser/wpe/qt/main.cpp: Added.
1531         (main):
1532         * MiniBrowser/wpe/qt/main.qml: Added.
1533         * MiniBrowser/wpe/qt/qml.qrc: Added.
1534         * Scripts/run-gtk-tests:
1535         (GtkTestRunner.is_google_test):
1536         (GtkTestRunner):
1537         (GtkTestRunner.is_qt_test):
1538         * Scripts/run-qt-wpe-minibrowser: Added.
1539         * Scripts/run-wpe-tests:
1540         (WPETestRunner):
1541         (WPETestRunner.is_google_test):
1542         (WPETestRunner.is_qt_test):
1543         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
1544         (TestLoad::main):
1545         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
1546         (TestLoadHtml::main):
1547         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
1548         (TestLoadRequest::main):
1549         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
1550         (TestRunJavaScript::main):
1551         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
1552         (waitForSignal):
1553         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
1554         (LoadSpy::LoadSpy):
1555         (LoadSpy::~LoadSpy):
1556         (LoadSpy::onLoadingChanged):
1557         (LoadStartedCatcher::LoadStartedCatcher):
1558         (LoadStartedCatcher::~LoadStartedCatcher):
1559         (LoadStartedCatcher::onLoadingChanged):
1560         (waitForLoadSucceeded):
1561         (waitForLoadFailed):
1562         * TestWebKitAPI/glib/CMakeLists.txt:
1563         * flatpak/flatpakutils.py:
1564         (WebkitFlatpak.load_from_args):
1565         (WebkitFlatpak.__init__):
1566         (WebkitFlatpak.clean_args):
1567         (WebkitFlatpak.run_in_sandbox):
1568         * flatpak/org.webkit.CommonModules.yaml:
1569         * flatpak/org.webkit.WPE.yaml:
1570         * flatpak/org.webkit.WPEModules.yaml:
1571         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
1572         * flatpak/org.webkit.WebKit.yaml:
1573         * glib/api_test_runner.py:
1574         (TestRunner._run_test_qt):
1575         (TestRunner.is_qt_test):
1576         (TestRunner._run_test):
1577
1578 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1579
1580         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
1581         https://bugs.webkit.org/show_bug.cgi?id=193494
1582         <rdar://problem/46859627>
1583
1584         Reviewed by Simon Fraser and Tim Horton.
1585
1586         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
1587         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
1588
1589         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1590         (WTR::UIScriptController::contentOffsetX const):
1591         (WTR::UIScriptController::contentOffsetY const):
1592         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1593         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1594         (WTR::UIScriptController::contentOffsetX const):
1595         (WTR::UIScriptController::contentOffsetY const):
1596         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1597
1598         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
1599
1600         * WebKitTestRunner/TestController.cpp:
1601         (WTR::updateTestOptionsFromTestHeader):
1602         * WebKitTestRunner/TestOptions.h:
1603         (WTR::TestOptions::hasSameInitializationOptions const):
1604         * WebKitTestRunner/ios/TestControllerIOS.mm:
1605         (WTR::TestController::platformResetStateToConsistentValues):
1606         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1607         (WTR::UIScriptController::contentOffsetX const):
1608         (WTR::UIScriptController::contentOffsetY const):
1609
1610 2019-01-17  Truitt Savell  <tsavell@apple.com>
1611
1612         Unreviewed, rolling out r240124.
1613
1614         This commit broke an internal build.
1615
1616         Reverted changeset:
1617
1618         "SDK_VARIANT build destinations should be separate from non-
1619         SDK_VARIANT builds"
1620         https://bugs.webkit.org/show_bug.cgi?id=189553
1621         https://trac.webkit.org/changeset/240124
1622
1623 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1624
1625         Fix string concatenation API test after r239920
1626         https://bugs.webkit.org/show_bug.cgi?id=193551
1627         <rdar://problem/47359304>
1628
1629         Reviewed by Youenn Fablet.
1630
1631         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1632         (TestWebKitAPI::TEST):
1633         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
1634         in WebKit's build configuration like it apparently is on Linux.
1635
1636 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1637
1638         [ews-build] validate-patch should handle the case when bug_id is None
1639         https://bugs.webkit.org/show_bug.cgi?id=193547
1640
1641         Reviewed by Lucas Forschler.
1642
1643         * BuildSlaveSupport/ews-build/steps.py:
1644         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
1645         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
1646
1647 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1648
1649         [ews-build] Add patch author information in build
1650         https://bugs.webkit.org/show_bug.cgi?id=193465
1651
1652         Reviewed by Lucas Forschler.
1653
1654         * BuildSlaveSupport/ews-build/steps.py:
1655         (ValidatePatch._is_patch_obsolete):
1656
1657 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1658
1659         [ews-build] Pass bug_id to the triggered builds
1660         https://bugs.webkit.org/show_bug.cgi?id=193548
1661
1662         Reviewed by Lucas Forschler.
1663
1664         * BuildSlaveSupport/ews-build/factories.py:
1665         (BuildFactory.propertiesToPassToTriggers):
1666
1667 2019-01-17  Jer Noble  <jer.noble@apple.com>
1668
1669         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1670         https://bugs.webkit.org/show_bug.cgi?id=189553
1671
1672         Reviewed by Tim Horton.
1673
1674         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
1675
1676         * ContentExtensionTester/Configurations/Base.xcconfig:
1677         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
1678         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1679         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
1680         * ImageDiff/cg/Configurations/Base.xcconfig:
1681         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
1682         * MiniBrowser/Configurations/Base.xcconfig:
1683         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1684         * MobileMiniBrowser/Configurations/Base.xcconfig:
1685         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
1686         * Scripts/webkitpy/style/checker.py:
1687         (_all_categories):
1688         (FileType):
1689         (CheckerDispatcher._file_type):
1690         (CheckerDispatcher._create_checker):
1691         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
1692         (SDKVariantChecker):
1693         (SDKVariantChecker.__init__):
1694         (SDKVariantChecker.check):
1695         * TestWebKitAPI/Configurations/Base.xcconfig:
1696         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
1697         * WebEditingTester/Configurations/Base.xcconfig:
1698         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
1699         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
1700         * WebKitTestRunner/Configurations/Base.xcconfig:
1701         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
1702         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1703         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
1704
1705 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1706
1707         [LFC][BFC] An element with transform is a containing block for positioned descendants.
1708         https://bugs.webkit.org/show_bug.cgi?id=193534
1709
1710         Reviewed by Antti Koivisto.
1711
1712         * LayoutReloaded/misc/LFC-passing-tests.txt:
1713
1714 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1715
1716         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
1717         https://bugs.webkit.org/show_bug.cgi?id=193528
1718
1719         Reviewed by Antti Koivisto.
1720
1721         * LayoutReloaded/misc/LFC-passing-tests.txt:
1722
1723 2019-01-17  Zalan Bujtas  <zalan@apple.com>
1724
1725         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
1726         https://bugs.webkit.org/show_bug.cgi?id=193520
1727
1728         Reviewed by Antti Koivisto.
1729
1730         * LayoutReloaded/misc/LFC-passing-tests.txt:
1731
1732 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
1733
1734         [ews-build] unapply-patch step should not update source
1735         https://bugs.webkit.org/show_bug.cgi?id=193234
1736
1737         Reviewed by Lucas Forschler.
1738
1739         * BuildSlaveSupport/ews-build/steps.py:
1740         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
1741         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
1742
1743 2019-01-16  Youenn Fablet  <youenn@apple.com>
1744
1745         Add a new SPI for controlling getUserMedia
1746         https://bugs.webkit.org/show_bug.cgi?id=192793
1747
1748         Reviewed by Eric Carlson.
1749
1750         * MiniBrowser/mac/WK2BrowserWindowController.m:
1751         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
1752         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1753         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
1754         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1755         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
1756         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1757         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
1758         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1759         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1760         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1761         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1762         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1763         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
1764         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
1765
1766 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1767
1768         [LFC][BFC] Inflow non-replaced used width should not be negative.
1769         https://bugs.webkit.org/show_bug.cgi?id=193495
1770
1771         Reviewed by Antti Koivisto.
1772
1773         * LayoutReloaded/misc/LFC-passing-tests.txt:
1774
1775 2019-01-16  Chris Dumez  <cdumez@apple.com>
1776
1777         Regression(PSON) View becomes blank after click a cross-site download link
1778         https://bugs.webkit.org/show_bug.cgi?id=193361
1779         <rdar://problem/47099573>
1780
1781         Reviewed by Geoffrey Garen.
1782
1783         Add API test coverage.
1784
1785         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1786         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1787
1788 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1789
1790         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
1791         https://bugs.webkit.org/show_bug.cgi?id=193470
1792
1793         Reviewed by Antti Koivisto.
1794
1795         * LayoutReloaded/misc/LFC-passing-tests.txt:
1796
1797 2019-01-16  Zalan Bujtas  <zalan@apple.com>
1798
1799         [LFC] Adjust margin box verification.
1800         https://bugs.webkit.org/show_bug.cgi?id=193482
1801
1802         Reviewed by Antti Koivisto.
1803
1804         * LayoutReloaded/misc/LFC-passing-tests.txt:
1805
1806 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
1807
1808         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
1809         https://bugs.webkit.org/show_bug.cgi?id=193451
1810
1811         Reviewed by Geoffrey Garen.
1812
1813         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
1814         (TEST):
1815         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1816         (runWebsiteDataStoreCustomPaths):
1817
1818 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1819
1820         webkitpy: Support boolean simctl isAvailable
1821         https://bugs.webkit.org/show_bug.cgi?id=193472
1822         <rdar://problem/47296150>
1823
1824         Reviewed by Ryosuke Niwa.
1825
1826         * Scripts/webkitpy/xcode/simulated_device.py:
1827         (SimulatedDeviceManager._create_runtimes):
1828         (SimulatedDeviceManager._create_device_with_runtime):
1829
1830 2019-01-15  Chris Dumez  <cdumez@apple.com>
1831
1832         Unreviewed, rolling out r239993, r239995, r239997, and
1833         r239999.
1834
1835         Caused assertions under
1836         ViewGestureController::disconnectFromProcess()
1837
1838         Reverted changesets:
1839
1840         "Regression(PSON) View becomes blank after click a cross-site
1841         download link"
1842         https://bugs.webkit.org/show_bug.cgi?id=193361
1843         https://trac.webkit.org/changeset/239993
1844
1845         "Unreviewed iOS build fix after r239993."
1846         https://trac.webkit.org/changeset/239995
1847
1848         "Fix iOS build after r239993"
1849         https://bugs.webkit.org/show_bug.cgi?id=193361
1850         https://trac.webkit.org/changeset/239997
1851
1852         "Unreviewed, revert part of r239997 as it is not needed to fix
1853         the build."
1854         https://trac.webkit.org/changeset/239999
1855
1856 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1857
1858         Cannot tab out of WKWebView on macOS
1859         https://bugs.webkit.org/show_bug.cgi?id=161448
1860         <rdar://problem/28100085>
1861
1862         Reviewed by Dean Jackson.
1863
1864         Add a test that tabbing into and out of WKWebView works correctly.
1865
1866         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1867         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1868         (WebKit2_CommandBackForwardTest::SetUp):
1869         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
1870         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
1871         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
1872         (-[FocusableView canBecomeKeyView]):
1873         (TEST):
1874         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
1875         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
1876         (-[OffscreenWindow initWithSize:]):
1877         (-[OffscreenWindow isKeyWindow]):
1878         (-[OffscreenWindow isVisible]):
1879         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1880         (TestWebKitAPI::PlatformWebView::initialize):
1881         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
1882         (-[ActiveOffscreenWindow isVisible]): Deleted.
1883         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
1884
1885 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
1886
1887         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
1888         https://bugs.webkit.org/show_bug.cgi?id=193459
1889
1890         Reviewed by Mark Lam.
1891
1892         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1893         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
1894
1895 2019-01-15  Chris Dumez  <cdumez@apple.com>
1896
1897         Regression(PSON) View becomes blank after click a cross-site download link
1898         https://bugs.webkit.org/show_bug.cgi?id=193361
1899         <rdar://problem/47099573>
1900
1901         Reviewed by Geoff Garen.
1902
1903         Add API test coverage.
1904
1905         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1906         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1907
1908 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1909
1910         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
1911         https://bugs.webkit.org/show_bug.cgi?id=193448
1912
1913         Reviewed by Antti Koivisto.
1914
1915         * LayoutReloaded/misc/LFC-passing-tests.txt:
1916
1917 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
1918
1919         webkitpy: Implement device type specific expected results (Part 1)
1920         https://bugs.webkit.org/show_bug.cgi?id=192162
1921
1922         Reviewed by Lucas Forschler.
1923
1924         Device type specific expected results covers two related ideas. The first (covered by this change)
1925         is where to search for -expected.* files. The second is which tests to run based on the
1926         TestExpectations.txt file.
1927
1928         After this change, the baseline search path will be determined by the type of device running a
1929         test. Device type will be passed into any function which picks a file based on the baseline search
1930         path.
1931
1932         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1933         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
1934         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1935         (Manager.run): Print baseline search path for each round of devices.
1936         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1937         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
1938         (SingleTestRunner._expected_driver_output): Ditto.
1939         (SingleTestRunner._driver_input): Ditto.
1940         * Scripts/webkitpy/layout_tests/views/printing.py:
1941         (Printer.print_config): Move printing of baseline search path to a separate function.
1942         (Printer.print_baseline_search_path): Moved from Printer.print_config.
1943         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1944         (Testprinter.test_print_config):
1945         (Testprinter.test_print_baseline_search_path):
1946         * Scripts/webkitpy/port/base.py:
1947         (Port.baseline_search_path): Pass device_type through.
1948         (Port._expected_baselines_for_suffixes): Ditto.
1949         (Port.expected_baselines): Ditto.
1950         (Port.expected_filename): Ditto.
1951         (Port.expected_checksum): Ditto.
1952         (Port.expected_image): Ditto.
1953         (Port.expected_audio): Ditto.
1954         (Port.expected_text): Ditto.
1955         (Port.reference_files): Ditto.
1956         (Port.tests): Ditto.
1957         (Port._expanded_paths): Ditto.
1958         (Port.skipped_layout_tests): Ditto.
1959         (Port.expectations_dict): Ditto.
1960         (Port._port_specific_expectations_files): Ditto.
1961         (Port.expectations_files): Ditto.
1962         (Port.test_search_path): Ditto.
1963         (Port._tests_for_other_platforms): Ditto.
1964         * Scripts/webkitpy/port/base_unittest.py:
1965         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
1966         (PortTest.test_nonexistant_expectations): Ditto.
1967         (test_ref_tests_platform_directory): Ditto.
1968         * Scripts/webkitpy/port/darwin.py:
1969         (DarwinPort._port_specific_expectations_files): Accept device_type.
1970         * Scripts/webkitpy/port/driver.py:
1971         (DriverProxy):
1972         (DriverProxy.host): Expose _target_host for device_type information.
1973         * Scripts/webkitpy/port/gtk.py:
1974         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
1975         * Scripts/webkitpy/port/ios.py:
1976         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1977         * Scripts/webkitpy/port/mac.py:
1978         (MacPort. default_baseline_search_path): Ditto.
1979         * Scripts/webkitpy/port/port_testcase.py:
1980         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
1981         * Scripts/webkitpy/port/test.py:
1982         * Scripts/webkitpy/port/watch.py:
1983         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
1984         * Scripts/webkitpy/port/win.py:
1985         (WinPort.test_search_path): Accept, but do not use, device_type.
1986         * Scripts/webkitpy/port/wpe.py:
1987         (WPEPort._port_specific_expectations_files): Ditto.
1988         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1989         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
1990
1991 2019-01-15  Zalan Bujtas  <zalan@apple.com>
1992
1993         [LFC] Use the containing block's padding box to position out-of-flow elements.
1994         https://bugs.webkit.org/show_bug.cgi?id=193431
1995
1996         Reviewed by Antti Koivisto.
1997
1998         * LayoutReloaded/misc/LFC-passing-tests.txt:
1999
2000 2019-01-14  Tim Horton  <timothy_horton@apple.com>
2001
2002         Move a test implementation file that got misplaced in the Xcode project
2003
2004         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2005
2006 2019-01-14  Commit Queue  <commit-queue@webkit.org>
2007
2008         Unreviewed, rolling out r239901, r239909, r239910, r239912,
2009         r239913, and r239914.
2010         https://bugs.webkit.org/show_bug.cgi?id=193407
2011
2012         These revisions caused an internal failure (Requested by
2013         Truitt on #webkit).
2014
2015         Reverted changesets:
2016
2017         "[Cocoa] Avoid importing directly from subumbrella frameworks"
2018         https://bugs.webkit.org/show_bug.cgi?id=186016
2019         https://trac.webkit.org/changeset/239901
2020
2021         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
2022         https://trac.webkit.org/changeset/239909
2023
2024         "Tried to fix the build."
2025         https://trac.webkit.org/changeset/239910
2026
2027         "Fixed iOS builds after r239910."
2028         https://trac.webkit.org/changeset/239912
2029
2030         "More build fixing."
2031         https://trac.webkit.org/changeset/239913
2032
2033         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
2034         https://trac.webkit.org/changeset/239914
2035
2036 2019-01-14  Mark Lam  <mark.lam@apple.com>
2037
2038         Re-enable ability to build --cloop builds.
2039         https://bugs.webkit.org/show_bug.cgi?id=192955
2040         <rdar://problem/46882363>
2041
2042         Reviewed by Saam barati and Keith Miller.
2043
2044         The --cloop build option was being ignored this whole time since r236381.
2045         This patch makes it possible to build CLoop builds again.
2046
2047         * Scripts/build-jsc:
2048         * Scripts/webkitperl/FeatureList.pm:
2049         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2050
2051 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2052
2053         webkitpy: Expose device_type from host-like objects
2054         https://bugs.webkit.org/show_bug.cgi?id=193406
2055         <rdar://problem/47262305>
2056
2057         Reviewed by Lucas Forschler.
2058
2059         Devices should expose device_type. As a result, all host objects should
2060         provide a device_type property, even if they do not yet define a device_type.
2061
2062         * Scripts/webkitpy/common/system/systemhost.py:
2063         (SystemHost):
2064         (SystemHost.device_type):
2065         * Scripts/webkitpy/common/system/systemhost_mock.py:
2066         (MockSystemHost):
2067         (MockSystemHost.device_type):
2068         * Scripts/webkitpy/port/device.py:
2069         (Device):
2070         (Device.device_type):
2071         * Scripts/webkitpy/xcode/simulated_device.py:
2072         (SimulatedDeviceManager._find_exisiting_device_for_request):
2073         (SimulatedDeviceManager._disambiguate_device_type):
2074         (SimulatedDeviceManager._does_fulfill_request):
2075         (SimulatedDeviceManager.device_count_for_type):
2076         (SimulatedDeviceManager.initialize_devices):
2077         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2078         (test_available_devices):
2079         (test_swapping_devices):
2080
2081 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2082
2083         webkitpy: Support alternate simctl device list output (Follow-up fix)
2084         https://bugs.webkit.org/show_bug.cgi?id=193362
2085         <rdar://problem/47122965>
2086
2087         Rubber-stamped by Lucas Forschler.
2088
2089         * Scripts/webkitpy/xcode/simulated_device.py:
2090         (SimulatedDeviceManager.populate_available_devices):
2091
2092 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2093
2094         [iOS] Expose SPI to access the current sentence boundary and selection state
2095         https://bugs.webkit.org/show_bug.cgi?id=193398
2096         <rdar://problem/45893108>
2097
2098         Reviewed by Dean Jackson.
2099
2100         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
2101         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
2102         expected.
2103
2104         * TestWebKitAPI/EditingTestHarness.h:
2105         * TestWebKitAPI/EditingTestHarness.mm:
2106         (-[EditingTestHarness moveBackward]):
2107         (-[EditingTestHarness moveForward]):
2108         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
2109
2110         Add a couple of new helper methods on EditingTestHarness.
2111
2112         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2113         (-[SelectionChangeObserver initWithWebView:]):
2114         (-[SelectionChangeObserver webView]):
2115         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
2116         (-[SelectionChangeObserver currentSelectionAttributes]):
2117
2118 2019-01-14  Zalan Bujtas  <zalan@apple.com>
2119
2120         [LFC][BFC] Add basic box-sizing support.
2121         https://bugs.webkit.org/show_bug.cgi?id=193392
2122
2123         Reviewed by Antti Koivisto.
2124
2125         * LayoutReloaded/misc/LFC-passing-tests.txt:
2126
2127 2019-01-14  Charlie Turner  <cturner@igalia.com>
2128
2129         [WPE] API test gardening
2130         https://bugs.webkit.org/show_bug.cgi?id=193319
2131
2132         Reviewed by Michael Catanzaro.
2133
2134         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
2135         passing tests.
2136
2137 2019-01-14  Charlie Turner  <cturner@igalia.com>
2138
2139         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
2140         https://bugs.webkit.org/show_bug.cgi?id=192977
2141
2142         Reviewed by Carlos Garcia Campos.
2143
2144         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
2145         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2146         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
2147         (TestWebKitAPI::GStreamerTest::SetUp):
2148         (TestWebKitAPI::GStreamerTest::TearDown):
2149         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
2150         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
2151         (TestWebKitAPI::TEST_F):
2152
2153 2019-01-14  Charlie Turner  <cturner@igalia.com>
2154
2155         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
2156         https://bugs.webkit.org/show_bug.cgi?id=193332
2157
2158         Reviewed by Michael Catanzaro.
2159
2160         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
2161         defined as a char16_t, which changed in ICU 59, the
2162         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
2163         unsigned short. This test is relying on the behaviour that
2164         UChar=unsigned short, which doesn't hold across platforms and ICU
2165         library versions. The full fix would be a special syntax for
2166         literal characters so that these ambiguities do not arise. That
2167         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
2168         (TestWebKitAPI::TEST):
2169
2170 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2171
2172         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
2173
2174         * Scripts/make-dist:
2175         (Distcheck.configure):
2176
2177 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
2178
2179         [ews-build] Update macOS queue configurations
2180         https://bugs.webkit.org/show_bug.cgi?id=193365
2181         <rdar://problem/47221073>
2182
2183         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
2184
2185         * BuildSlaveSupport/ews-build/config.json:
2186
2187 2019-01-13  Zalan Bujtas  <zalan@apple.com>
2188
2189         [LFC] Adjust assert for statically positioned fixed elements
2190         https://bugs.webkit.org/show_bug.cgi?id=193385
2191
2192         Reviewed by Antti Koivisto.
2193
2194         * LayoutReloaded/misc/LFC-passing-tests.txt:
2195
2196 2019-01-13  Philippe Normand  <pnormand@igalia.com>
2197
2198         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
2199         https://bugs.webkit.org/show_bug.cgi?id=193387
2200
2201         Reviewed by Carlos Garcia Campos.
2202
2203         * MiniBrowser/wpe/main.cpp:
2204         (main):
2205
2206 2019-01-12  Timothy Hatcher  <timothy@apple.com>
2207
2208         Have prefers-color-scheme: light always match on macOS versions before Mojave.
2209         https://bugs.webkit.org/show_bug.cgi?id=191655
2210         rdar://problem/46074680
2211
2212         Reviewed by Megan Gardner.
2213
2214         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
2215         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
2216
2217 2019-01-12  Dan Bernstein  <mitz@apple.com>
2218
2219         [Cocoa] Avoid importing directly from subumbrella frameworks
2220         https://bugs.webkit.org/show_bug.cgi?id=186016
2221         <rdar://problem/40591038>
2222
2223         Reviewed by Sam Weinig.
2224
2225         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2226           LaunchServices header.
2227         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2228           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2229         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2230           when using SDKs earlier than 10.13.
2231         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2232           and OTHER_CPLUSPLUSFLAGS.
2233         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2234           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2235         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2236           LaunchServices header.
2237
2238 2019-01-11  John Wilander  <wilander@apple.com>
2239
2240         Compile out Web API Statistics Collection
2241         https://bugs.webkit.org/show_bug.cgi?id=193370
2242         <rdar://problem/45388584>
2243
2244         Reviewed by Brent Fulgham.
2245
2246         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2247             Defined ENABLE_WEB_API_STATISTICS, off by default.
2248
2249 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
2250
2251         [WPE] Add gtk-doc
2252         https://bugs.webkit.org/show_bug.cgi?id=178900
2253
2254         Reviewed by Michael Catanzaro.
2255
2256         Add Tools/gtkdoc to manifest.txt.in files.
2257         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
2258
2259         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
2260         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
2261
2262 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2263
2264         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
2265         https://bugs.webkit.org/show_bug.cgi?id=193364
2266         <rdar://problem/47214117>
2267
2268         Reviewed by Tim Horton.
2269
2270         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
2271         precise, whereas dragging near the middle of the textarea does.
2272
2273         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2274         (TestWebKitAPI::TEST):
2275
2276 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2277
2278         webkitpy: Support alternate simctl device list output
2279         https://bugs.webkit.org/show_bug.cgi?id=193362
2280         <rdar://problem/47122965>
2281
2282         Reviewed by Lucas Forschler.
2283
2284         * Scripts/webkitpy/xcode/simulated_device.py:
2285         (SimulatedDeviceManager.populate_available_devices):
2286
2287 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
2288
2289         [ews-build] Update macOS queue configurations
2290         https://bugs.webkit.org/show_bug.cgi?id=193365
2291
2292         Reviewed by Lucas Forschler.
2293
2294         * BuildSlaveSupport/ews-build/config.json:
2295
2296 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2297
2298         webkitpy: Incorporate device type into baseline search path
2299         https://bugs.webkit.org/show_bug.cgi?id=193356
2300         <rdar://problem/47215515>
2301
2302         Reviewed by Lucas Forschler.
2303
2304         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
2305
2306         * Scripts/webkitpy/port/base.py:
2307         (Port.default_baseline_search_path): Allow device type to be passed in.
2308         * Scripts/webkitpy/port/gtk.py:
2309         (GtkPort.default_baseline_search_path): Ignore device type.
2310         * Scripts/webkitpy/port/ios.py:
2311         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
2312         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
2313         * Scripts/webkitpy/port/ios_device_unittest.py:
2314         (IOSDeviceTest):
2315         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2316         (IOSSimulatorTest):
2317         * Scripts/webkitpy/port/mac.py:
2318         (MacPort.default_baseline_search_path): Ignore device type.
2319         * Scripts/webkitpy/port/watch.py:
2320         (WatchPort.default_baseline_search_path): Ditto.
2321         * Scripts/webkitpy/port/win.py:
2322         (WinPort.default_baseline_search_path): Ditto.
2323         (WinCairoPort.default_baseline_search_path): Ditto.
2324         * Scripts/webkitpy/port/wpe.py:
2325         (WPEPort.default_baseline_search_path): Ditto.
2326
2327 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
2328
2329         webkitpy: Print abbreviated baseline search path that includes only folders that exist
2330         https://bugs.webkit.org/show_bug.cgi?id=193352
2331         <rdar://problem/47210736>
2332
2333         Reviewed by Lucas Forschler.
2334
2335         * Scripts/webkitpy/layout_tests/views/printing.py:
2336         (Printer.print_config): Print list on only baseline search paths which exist. 
2337         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2338         (Testprinter.test_print_config):
2339
2340 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
2341
2342         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
2343         https://bugs.webkit.org/show_bug.cgi?id=193340
2344
2345         Reviewed by David Kilzer.
2346
2347         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2348         (WTR::InjectedBundle::didReceiveMessageToPage):
2349         Pull the strings out into a WKRetainPtr.
2350
2351         * WebKitTestRunner/WebNotificationProvider.cpp:
2352         (WTR::WebNotificationProvider::closeWebNotification):
2353         Adopt the created value into the WKRetainPtr.
2354
2355         * WebKitTestRunner/mac/TestControllerMac.mm:
2356         (WTR::generateWhitelist):
2357         Immediately adopt a created value to avoid potential mistakes.
2358
2359 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
2360
2361         Enable DFG on ARM/Linux again
2362         https://bugs.webkit.org/show_bug.cgi?id=192496
2363
2364         Reviewed by Yusuke Suzuki.
2365
2366         After changing the bytecode format DFG was disabled on all 32-bit
2367         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2368         on ARM by default.
2369
2370         * Scripts/run-jsc-stress-tests:
2371
2372 2019-01-11  Timothy Hatcher  <timothy@apple.com>
2373
2374         Unreviewed, fix #ifdef in API test added in r239851.
2375         https://bugs.webkit.org/show_bug.cgi?id=193327
2376         rdar://problem/47093222
2377
2378         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2379
2380 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2381
2382         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
2383         https://bugs.webkit.org/show_bug.cgi?id=193109
2384         <rdar://problem/44807048>
2385
2386         Reviewed by Ryosuke Niwa.
2387
2388         Introduce and respect a test option to enable the UndoManager API.
2389
2390         * WebKitTestRunner/TestController.cpp:
2391         (WTR::updateTestOptionsFromTestHeader):
2392         * WebKitTestRunner/TestOptions.h:
2393         (WTR::TestOptions::hasSameInitializationOptions const):
2394         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2395         (WTR::TestController::platformCreateWebView):
2396
2397 2019-01-11  Zalan Bujtas  <zalan@apple.com>
2398
2399         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
2400         https://bugs.webkit.org/show_bug.cgi?id=193346
2401
2402         Reviewed by Antti Koivisto.
2403
2404         * LayoutReloaded/misc/LFC-passing-tests.txt:
2405
2406 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2407
2408         Unreviewed, fix typo that breaks dashboard link.
2409
2410         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2411         (WebKitBuildbot):
2412
2413 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2414
2415         Update macOS queue configurations
2416         https://bugs.webkit.org/show_bug.cgi?id=193329
2417
2418         Reviewed by Alexey Proskuryakov.
2419
2420         * BuildSlaveSupport/build.webkit.org-config/config.json:
2421         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2422         (BubbleQueueServer):
2423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2424         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2425         (WebKitBuildbot):
2426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2427         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
2428         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2429
2430 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2431
2432         MiniBrowser should be able to navigate to about:blank
2433         https://bugs.webkit.org/show_bug.cgi?id=193345
2434
2435         Reviewed by Simon Fraser.
2436
2437         * MiniBrowser/mac/BrowserWindowController.m:
2438         (-[BrowserWindowController addProtocolIfNecessary:]):
2439         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
2440
2441         * MiniBrowser/mac/WK1BrowserWindowController.m:
2442         (-[WK1BrowserWindowController fetch:]):
2443         * MiniBrowser/mac/WK2BrowserWindowController.m:
2444         (-[WK2BrowserWindowController fetch:]):
2445         Clean up the code that uses this to match style.
2446
2447 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2448
2449         Remove MiniBrowser custom "Process Swap" menu item which does not work
2450         https://bugs.webkit.org/show_bug.cgi?id=193344
2451
2452         Reviewed by Simon Fraser.
2453
2454         There is a menu item under the Experimental menu that does work.
2455
2456         * MiniBrowser/mac/AppDelegate.m:
2457         (defaultConfiguration):
2458         * MiniBrowser/mac/SettingsController.h:
2459         * MiniBrowser/mac/SettingsController.m:
2460         (-[SettingsController _populateMenu]):
2461         (-[SettingsController validateMenuItem:]):
2462         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
2463         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
2464
2465 2019-01-10  Timothy Hatcher  <timothy@apple.com>
2466
2467         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
2468         https://bugs.webkit.org/show_bug.cgi?id=193327
2469         rdar://problem/47093222
2470
2471         Reviewed by Tim Horton.
2472
2473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2474         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
2475         (TestWebKitAPI::didFinishNavigation):
2476         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2477         (TestWebKitAPI::TEST):
2478         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
2479         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
2480         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
2481         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2482         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
2483
2484 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
2485
2486         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
2487         https://bugs.webkit.org/show_bug.cgi?id=193338
2488         <rdar://problem/46664774>
2489
2490         Reviewed by David Kilzer.
2491
2492         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2493         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2494
2495 2019-01-10  Commit Queue  <commit-queue@webkit.org>
2496
2497         Unreviewed, rolling out r239825.
2498         https://bugs.webkit.org/show_bug.cgi?id=193330
2499
2500         Broke tests on armv7/linux bots (Requested by guijemont on
2501         #webkit).
2502
2503         Reverted changeset:
2504
2505         "Enable DFG on ARM/Linux again"
2506         https://bugs.webkit.org/show_bug.cgi?id=192496
2507         https://trac.webkit.org/changeset/239825
2508
2509 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
2510
2511         Disable the run-jsc-stress-test remote host key check.
2512         https://bugs.webkit.org/show_bug.cgi?id=192988
2513
2514         Reviewed by Alexey Proskuryakov.
2515
2516         * Scripts/run-jsc-stress-tests:
2517
2518 2019-01-10  John Wilander  <wilander@apple.com>
2519
2520         Override the session configuration for cookieAcceptPolicy
2521         https://bugs.webkit.org/show_bug.cgi?id=190925
2522         <rdar://problem/45497382>
2523
2524         Reviewed by Alexey Proskuryakov and Alex Christensen.
2525
2526         Test infrastructure for setting a first-party-only cookie policy.
2527
2528         * DumpRenderTree/TestRunner.cpp:
2529         (setOnlyAcceptFirstPartyCookiesCallback):
2530         (TestRunner::staticFunctions):
2531         * DumpRenderTree/TestRunner.h:
2532         * DumpRenderTree/mac/TestRunnerMac.mm:
2533         (TestRunner::setOnlyAcceptFirstPartyCookies):
2534         * DumpRenderTree/win/TestRunnerWin.cpp:
2535         (TestRunner::setOnlyAcceptFirstPartyCookies):
2536         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2537         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2538         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
2539         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2540         * WebKitTestRunner/TestInvocation.cpp:
2541         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2542
2543 2019-01-09  Matt Rajca  <mrajca@apple.com>
2544
2545         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
2546         https://bugs.webkit.org/show_bug.cgi?id=193301
2547
2548         Reviewed by Jer Noble.
2549         
2550         Added API tests.
2551
2552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2553         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2554         (TEST):
2555         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
2556
2557 2019-01-10  Zalan Bujtas  <zalan@apple.com>
2558
2559         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
2560         https://bugs.webkit.org/show_bug.cgi?id=193310
2561
2562         Reviewed by Antti Koivisto.
2563
2564         * LayoutReloaded/misc/LFC-passing-tests.txt:
2565
2566 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
2567
2568         Enable DFG on ARM/Linux again
2569         https://bugs.webkit.org/show_bug.cgi?id=192496
2570
2571         Reviewed by Yusuke Suzuki.
2572
2573         After changing the bytecode format DFG was disabled on all 32-bit
2574         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
2575         on ARM by default.
2576
2577         * Scripts/run-jsc-stress-tests:
2578
2579 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2580
2581         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
2582         https://bugs.webkit.org/show_bug.cgi?id=193271
2583
2584         Reviewed by Brent Fulgham.
2585
2586         BSTR is a special data structure created by SysAllocString, not a
2587         wchar_t null-terminated string.
2588
2589         * DumpRenderTree/win/TestRunnerWin.cpp:
2590         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
2591         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2592         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
2593         BSTR from wide string literals.
2594
2595 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
2596
2597         Tweak wording for build/version_check style checker error
2598         https://bugs.webkit.org/show_bug.cgi?id=193256
2599
2600         Reviewed by Tim Horton.
2601
2602         * Scripts/webkitpy/style/checkers/cpp.py:
2603         (check_os_version_checks):
2604         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2605         (WebKitStyleTest.test_os_version_checks):
2606
2607 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2608
2609         [ews-build] Add link to bug along with bug title
2610         https://bugs.webkit.org/show_bug.cgi?id=193293
2611
2612         Reviewed by Lucas Forschler.
2613
2614         * BuildSlaveSupport/ews-build/steps.py:
2615         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
2616         (ConfigureBuild.add_bug_id_url): Deleted.
2617         (ConfigureBuild.getBugURL): Deleted.
2618
2619 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2620
2621         [ews-build] Use https for ews-build server
2622         https://bugs.webkit.org/show_bug.cgi?id=193193
2623
2624         Reviewed by Lucas Forschler.
2625
2626         * BuildSlaveSupport/ews-build/steps.py:
2627
2628 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2629
2630         [ews-build] Parse and display number of style failures
2631         https://bugs.webkit.org/show_bug.cgi?id=193280
2632
2633         Reviewed by Lucas Forschler.
2634
2635         * BuildSlaveSupport/ews-build/steps.py:
2636         (CheckStyle): Use TestWithFailureCount as base class.
2637         (CheckStyle.countFailures): Count the number of style failures.
2638
2639 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
2640
2641         [ews-build] use patch_id instead of ewspatchid
2642         https://bugs.webkit.org/show_bug.cgi?id=193235
2643
2644         Reviewed by Lucas Forschler.
2645
2646         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
2647         * BuildSlaveSupport/ews-build/steps.py: Ditto.
2648         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
2649
2650 2019-01-09  Zalan Bujtas  <zalan@apple.com>
2651
2652         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
2653         https://bugs.webkit.org/show_bug.cgi?id=192625
2654
2655         Reviewed by Antti Koivisto.
2656
2657         * LayoutReloaded/misc/LFC-passing-tests.txt:
2658
2659 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2660
2661         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
2662         https://bugs.webkit.org/show_bug.cgi?id=192841
2663
2664         Reviewed by Carlos Garcia Campos.
2665
2666         There are separate g_assert_*() macros for use in tests, which we use inconsistently
2667         currently. Use them always. We'll get nicer error messages now when tests fail, and the
2668         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
2669
2670         Note that the documentation of g_assert() says that it is not to be used when writing tests.
2671
2672         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2673         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
2674         (WebKitWebEditorTest::testSelectionChanged):
2675         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
2676         (WebKitFrameTest::testMainFrame):
2677         (WebKitFrameTest::testURI):
2678         (WebKitFrameTest::testJavaScriptContext):
2679         (WebKitFrameTest::testJavaScriptValues):
2680         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2681         (testWebViewAuthenticationRequest):
2682         (testWebViewAuthenticationLoadCancelled):
2683         (testWebViewAuthenticationFailure):
2684         (testWebViewAuthenticationStorage):
2685         (ProxyAuthenticationTest::ProxyAuthenticationTest):
2686         (testWebViewAuthenticationProxy):
2687         (testWebViewAuthenticationProxyHTTPS):
2688         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2689         (testAutomationSessionRequestSession):
2690         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
2691         (testBackForwardListNavigation):
2692         (testWebKitWebViewSessionState):
2693         (testWebKitWebViewSessionStateWithFormData):
2694         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2695         (ConsoleMessageTest::consoleMessageReceivedCallback):
2696         (testWebKitConsoleMessageConsoleAPI):
2697         (testWebKitConsoleMessageJavaScriptException):
2698         (testWebKitConsoleMessageNetworkError):
2699         (testWebKitConsoleMessageSecurityError):
2700         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2701         (testCookieManagerAcceptPolicy):
2702         (testCookieManagerCookiesChanged):
2703         (testCookieManagerPersistentStorage):
2704         (testCookieManagerPersistentStorageDeleteAll):
2705         (testCookieManagerEphemeral):
2706         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
2707         (testWebKitDOMElementAutoFill):
2708         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2709         (downloadLocalFileSuccessfully):
2710         (createFileAtDestination):
2711         (testDownloadOverwriteDestinationDisallowed):
2712         (testDownloadLocalFileError):
2713         (testDownloadRemoteFile):
2714         (testDownloadRemoteFileError):
2715         (testWebViewDownloadURI):
2716         (testPolicyResponseDownload):
2717         (testPolicyResponseDownloadCancel):
2718         (testDownloadMIMEType):
2719         (contextMenuCallback):
2720         (testContextMenuDownloadActions):
2721         (testBlobDownload):
2722         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
2723         (testWebKitWebEditorSelectionChanged):
2724         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
2725         (testWebKitFrameMainFrame):
2726         (testWebKitFrameURI):
2727         (testWebKitFrameJavaScriptContext):
2728         (testWebKitFrameJavaScriptValues):
2729         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2730         (LoadStopTrackingTest::loadFailed):
2731         (testWebViewTitle):
2732         (testURIRequestHTTPHeaders):
2733         (testURIRequestHTTPMethod):
2734         (testURIResponseHTTPHeaders):
2735         (testRedirectToDataURI):
2736         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
2737         (testProcessPerWebView):
2738         (testWebProcessLimit):
2739         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2740         (testWebViewResources):
2741         (testWebResourceLoading):
2742         (testWebResourceSuggestedFilename):
2743         (testWebResourceGetData):
2744         (testWebResourceGetDataError):
2745         (testWebViewResourcesHistoryCache):
2746         (testWebResourceSendRequest):
2747         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
2748         (testSSL):
2749         (testInsecureContent):
2750         (testTLSErrorsPolicy):
2751         (testTLSErrorsRedirect):
2752         (testTLSErrorsHTTPAuth):
2753         (testLoadFailedWithTLSErrors):
2754         (testSubresourceLoadFailedWithTLSErrors):
2755         (httpsServerCallback):
2756         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2757         (testWebViewCreateNavigationData):
2758         (testWebViewJavaScriptDialogs):
2759         (testWebViewWindowProperties):
2760         (testWebViewMouseTarget):
2761         (testWebViewFileChooserRequest):
2762         (testWebViewColorChooserRequest):
2763         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2764         (testWebExtensionGetTitle):
2765         (testDocumentLoadedSignal):
2766         (testWebKitWebViewProcessCrashed):
2767         (testWebExtensionWindowObjectCleared):
2768         (testWebExtensionIsolatedWorld):
2769         (permissionRequestCallback):
2770         (didAssociateFormControlsCallback):
2771         (testWebExtensionFormControlsAssociated):
2772         (FormSubmissionTest::FormSubmissionTest):
2773         (FormSubmissionTest::testFormSubmissionResult):
2774         (testWebExtensionFormSubmissionSteps):
2775         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2776         (testNotInitialized):
2777         (testClearDatabase):
2778         (testPrivateBrowsing):
2779         (testGetFavicon):
2780         (testWebViewFavicon):
2781         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
2782         (testFindControllerTextFound):
2783         (testFindControllerTextNotFound):
2784         (testFindControllerMatchCount):
2785         (testFindControllerMaxMatchCount):
2786         (testFindControllerNext):
2787         (testFindControllerPrevious):
2788         (testFindControllerCountedMatches):
2789         (testFindControllerOptions):
2790         (testFindControllerHide):
2791         (testFindControllerInstance):
2792         (testFindControllerGetters):
2793         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
2794         (testNavigationPolicy):
2795         (testResponsePolicy):
2796         (testNewWindowPolicy):
2797         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
2798         (testSecurityOriginBasicConstructor):
2799         (testSecurityOriginURIConstructor):
2800         (testSecurityOriginDefaultPort):
2801         (testSecurityOriginFileURI):
2802         (testOpaqueSecurityOrigin):
2803         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2804         (testWebKitSettings):
2805         (testWebKitSettingsNewWithSettings):
2806         (testWebKitSettingsUserAgent):
2807         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2808         (testWebViewNewWithUserContentManager):
2809         (isStyleSheetInjectedForURLAtPath):
2810         (isScriptInjectedForURLAtPath):
2811         (testUserContentManagerInjectedStyleSheet):
2812         (testUserContentManagerInjectedScript):
2813         (UserScriptMessageTest::scriptMessageReceived):
2814         (UserScriptMessageTest::waitUntilMessageReceived):
2815         (UserScriptMessageTest::runJavaScriptFinished):
2816         (testUserContentManagerScriptMessageReceived):
2817         (testUserContentManagerScriptMessageInWorldReceived):
2818         (testUserContentManagerScriptMessageFromDOMBindings):
2819         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2820         (testWebContextDefault):
2821         (testWebContextEphemeral):
2822         (testWebContextGetPlugins):
2823         (testWebContextURIScheme):
2824         (testWebContextSpellChecker):
2825         (testWebContextLanguages):
2826         (consoleMessageReceivedCallback):
2827         (testWebContextSecurityFileXHR):
2828         (ProxyTest::ProxyTest):
2829         (testWebContextProxySettings):
2830         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2831         (testWebViewWebContext):
2832         (testWebViewWebBackend):
2833         (testWebViewEphemeral):
2834         (testWebViewCustomCharset):
2835         (testWebViewSettings):
2836         (testWebViewRunJavaScript):
2837         (testWebViewCanShowMIMEType):
2838         (testWebViewSubmitForm):
2839         (testWebViewSave):
2840         (testWebViewPageVisibility):
2841         (testWebViewSnapshot):
2842         (testWebViewNotification):
2843         (testWebViewNotificationInitialPermissionAllowed):
2844         (testWebViewNotificationInitialPermissionDisallowed):
2845         (testWebViewIsPlayingAudio):
2846         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2847         (WebsiteDataTest::WebsiteDataTest):
2848         (WebsiteDataTest::remove):
2849         (WebsiteDataTest::clear):
2850         (testWebsiteDataConfiguration):
2851         (testWebsiteDataEphemeral):
2852         (testWebsiteDataCache):
2853         (testWebsiteDataStorage):
2854         (testWebsiteDataDatabases):
2855         (testWebsiteDataAppcache):
2856         (testWebsiteDataCookies):
2857         (testWebsiteDataDeviceIdHashSalt):
2858         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2859         (emitDocumentLoaded):
2860         (emitURIChanged):
2861         (sendRequestCallback):
2862         (contextMenuCallback):
2863         (consoleMessageSentCallback):
2864         (emitFormControlsAssociated):
2865         (formControlsAssociatedCallback):
2866         (emitFormSubmissionEvent):
2867         (willSubmitFormCallback):
2868         (windowObjectCleared):
2869         (methodCallCallback):
2870         (registerGResource):
2871         (webkit_web_extension_initialize_with_user_data):
2872         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2873         (checkLeaks):
2874         (WebProcessTest::create):
2875         (runTest):
2876         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
2877         (AutocleanupsTest::testWebProcessAutocleanups):
2878         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
2879         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
2880         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
2881         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2882         (WebKitDOMDOMWindowTest::testSignals):
2883         (WebKitDOMDOMWindowTest::testDispatchEvent):
2884         (WebKitDOMDOMWindowTest::testGetComputedStyle):
2885         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
2886         (WebKitDOMNodeFilterTest::testTreeWalker):
2887         (WebKitDOMNodeFilterTest::testNodeIterator):
2888         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
2889         (WebKitDOMNodeTest::testHierarchyNavigation):
2890         (WebKitDOMNodeTest::testInsertion):
2891         (WebKitDOMNodeTest::testTagNamesNodeList):
2892         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2893         (WebKitDOMNodeTest::testDOMCache):
2894         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
2895         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2896         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2897         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2898         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
2899         (testUIProcessAutocleanups):
2900         (testWebProcessAutocleanups):
2901         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
2902         (testContextMenuPopulateMenu):
2903         (testContextMenuDismissed):
2904         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
2905         (testWebKitDOMClientRectDivBoundingClientRectPosition):
2906         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
2907         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
2908         (testWebKitDOMDOMWindowSignals):
2909         (testWebKitDOMDOMWindowDispatchEvent):
2910         (testWebKitDOMDOMWindowGetComputedStyle):
2911         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
2912         (testWebKitDOMNodeHierarchyNavigation):
2913         (testWebKitDOMNodeInsertion):
2914         (testWebKitDOMNodeTagNamesNodeList):
2915         (testWebKitDOMNodeTagNamesHTMLCollection):
2916         (testWebKitDOMObjectCache):
2917         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
2918         (testWebKitDOMNodeFilterTreeWalker):
2919         (testWebKitDOMNodeFilterNodeIterator):
2920         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
2921         (testWebKitDOMXPathNSResolverNative):
2922         (testWebKitDOMXPathNSResolverCustom):
2923         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
2924         (testInspectorDefault):
2925         (testInspectorManualAttachDetach):
2926         (testInspectorCustomContainerDestroyed):
2927         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
2928         (startTestServer):
2929         (testInspectorServerPageList):
2930         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
2931         (OptionMenuTest::showOptionMenuCallback):
2932         (OptionMenuTest::menuCloseCallback):
2933         (OptionMenuTest::close):
2934         (OptionMenuTest::activateItem):
2935         (OptionMenuTest::selectItem):
2936         (testOptionMenuSimple):
2937         (testOptionMenuGroups):
2938         (testOptionMenuActivate):
2939         (testOptionMenuSelect):
2940         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
2941         (testPrintOperationPrintSettings):
2942         (webViewPrintCallback):
2943         (testPrintOperationPrint):
2944         (testPrintCustomWidget):
2945         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2946         (checkAtspiAccessible):
2947         (testAtspiBasicHierarchy):
2948         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
2949         (testWebKitCheckVersion):
2950         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2951         (testWebViewEditorCutCopyPasteNonEditable):
2952         (testWebViewEditorCutCopyPasteEditable):
2953         (testWebViewEditorSelectAllNonEditable):
2954         (testWebViewEditorSelectAllEditable):
2955         (loadContentsAndTryToCutSelection):
2956         (testWebViewEditorNonEditable):
2957         (testWebViewEditorEditable):
2958         (testWebViewEditorEditorStateTypingAttributes):
2959         (testWebViewEditorInsertImage):
2960         (testWebViewEditorCreateLink):
2961         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
2962         (loadChangedCallback):
2963         (loadFailedCallback):
2964         (loadFailedWithTLSErrorsCallback):
2965         (LoadTrackingTest::LoadTrackingTest):
2966         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2967         (registerGResource):
2968         (removeNonEmptyDirectory):
2969         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2970         (Test::adoptView):
2971         (Test::~Test):
2972         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2973         (WebKitTestBus::getOrCreateConnection):
2974         (WebKitTestBus::createProxy):
2975         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
2976         (WebKitTestServer::getWebSocketURIForPath const):
2977         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
2978         (WebViewTest::initializeWebView):
2979         (WebViewTest::loadURI):
2980         (WebViewTest::loadHtml):
2981         (WebViewTest::loadPlainText):
2982         (WebViewTest::loadBytes):
2983         (WebViewTest::loadRequest):
2984         (WebViewTest::loadAlternateHTML):
2985         (WebViewTest::goBack):
2986         (WebViewTest::goForward):
2987         (WebViewTest::goToBackForwardListItem):
2988         (resourceGetDataCallback):
2989         (WebViewTest::mainResourceData):
2990         (WebViewTest::javascriptResultToCString):
2991         (WebViewTest::javascriptResultToNumber):
2992         (WebViewTest::javascriptResultToBoolean):
2993         (WebViewTest::javascriptResultIsNull):
2994         (WebViewTest::javascriptResultIsUndefined):
2995         (onSnapshotReady):
2996         (WebViewTest::runWebProcessTest):
2997         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
2998         (WebViewTest::platformInitializeWebView):
2999         (WebViewTest::showInWindow):
3000         (WebViewTest::showInWindowAndWaitUntilMapped):
3001         (WebViewTest::mouseMoveTo):
3002         (WebViewTest::emitPopupMenuSignal):
3003         (WebViewTest::keyStroke):
3004         (WebViewTest::doMouseButtonEvent):
3005
3006 2019-01-09  Philippe Normand  <pnormand@igalia.com>
3007
3008         [WPE] API tests can't run in flatpak environment
3009         https://bugs.webkit.org/show_bug.cgi?id=193242
3010
3011         Reviewed by Michael Catanzaro.
3012
3013         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
3014         flatpakutils so that it knows which port it's dealing with.
3015         * glib/common.py: Remove build_dir globals so that subsequent
3016         calls actually take args into account.
3017         (library_build_path):
3018         (binary_build_path):
3019
3020 2019-01-08  Dean Jackson  <dino@apple.com>
3021
3022         Blob references for System Previews don't get a correct file extension
3023         https://bugs.webkit.org/show_bug.cgi?id=193268
3024         <rdar://problem/47133037>
3025
3026         Reviewed by Tim Horton.
3027
3028         New test that a Blob download of a USDZ file gets named correctly.
3029
3030         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3031         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3032         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3033         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
3034         (TEST):
3035         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
3036
3037 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
3038
3039         [WebAuthN] Support U2F HID Authenticators on macOS
3040         https://bugs.webkit.org/show_bug.cgi?id=191535
3041         <rdar://problem/47102027>
3042
3043         Reviewed by Brent Fulgham.
3044
3045         This patch:
3046         1) adds support for U2F mocking mechanism;
3047         2) updates tests to reflect U2fCommandConstructor changes.
3048
3049         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3050         (TestWebKitAPI::TEST):
3051         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3052         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3053         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3054
3055 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3056
3057         [iOS] Dispatch a synthetic mousedown event prior to starting drags
3058         https://bugs.webkit.org/show_bug.cgi?id=193229
3059         <rdar://problem/46717097>
3060
3061         Reviewed by Tim Horton.
3062
3063         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
3064         prevents a drag from starting.
3065
3066         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3067         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
3068
3069         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
3070
3071 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
3072   
3073         Layout test will generate a perf metric file to results dir.
3074         https://bugs.webkit.org/show_bug.cgi?id=192030
3075         <rdar://problem/32779516>
3076
3077         Reviewed by Aakash Jain.
3078
3079         Layout test running time will be collected to a perf metric file.
3080         For now, instead of outputing running time of all tests (which is huge),
3081         we aggregate them by test directories which are at most two level deep. 
3082
3083         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3084         (Manager._end_test_run):
3085         (Manager._output_perf_metrics):
3086         (Manager._print_expectation_line_for_test):
3087         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3088         (add_test_perf_metric):
3089         (test_perf_metrics):
3090         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3091         (JSONGeneratorTest.test_test_timings_trie):
3092         (JSONGeneratorTest):
3093         (JSONGeneratorTest.test_test_perf_metrics):
3094         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3095         (RebaselineTest.test_reset_results):
3096         (RebaselineTest.test_missing_results):
3097         (RebaselineTest.test_new_baseline):
3098
3099 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
3100
3101         [WPE][GTK] Add php-json to install-dependencies
3102         https://bugs.webkit.org/show_bug.cgi?id=193233
3103
3104         Reviewed by Michael Catanzaro.
3105
3106         * gtk/install-dependencies:
3107         * wpe/install-dependencies:
3108
3109 2019-01-08  Chris Dumez  <cdumez@apple.com>
3110
3111         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
3112         https://bugs.webkit.org/show_bug.cgi?id=193224
3113         <rdar://problem/47097726>
3114
3115         Reviewed by Alex Christensen.
3116
3117         Add API test coverage.
3118
3119         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3120
3121 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3122
3123         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
3124         <https://webkit.org/b/193222>
3125         <rdar://problem/46862309>
3126
3127         Reviewed by Joseph Pecoraro.
3128
3129         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3130         (WTR::executeCallback): Fix camel case of variable name.
3131         (WTR::EventSendingController::callAfterScrollingCompletes): If
3132         WKBundlePageRegisterScrollOperationCompletionCallback() returns
3133         false, make sure to release the ScrollCompletionCallbackData
3134         object.  This fixes the leak.
3135
3136 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3137
3138         [Win] EWS: wincairo-ews cannot apply a patch with *.png
3139         https://bugs.webkit.org/show_bug.cgi?id=193044
3140
3141         Reviewed by Daniel Bates.
3142
3143         WinCairo EWS bots are using Windows Perl. Binary files should be
3144         opened as binary mode.
3145
3146         * Scripts/svn-apply:
3147         (handleGitBinaryChange): Use 'binmode' for binary file handles.
3148
3149 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
3150
3151         [CMake] Add ENABLE_CSS_TYPED_OM option
3152         https://bugs.webkit.org/show_bug.cgi?id=193216
3153
3154         Reviewed by Michael Catanzaro.
3155
3156         * Scripts/webkitperl/FeatureList.pm:
3157
3158 2019-01-07  David Kilzer  <ddkilzer@apple.com>
3159
3160         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
3161         <https://webkit.org/b/193056>
3162
3163         Reviewed by Alex Christensen.
3164
3165         * Scripts/webkitpy/style/checker.py:
3166         - Ignore use of new runtime/retainptr check in
3167           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
3168           contains tests to ensure RetainPtr<NSObject *> is compatible
3169           with RetainPtr<NSObject>.
3170
3171         * Scripts/webkitpy/style/checkers/cpp.py:
3172         (check_language):
3173         (CppChecker):
3174         - Add checker for use of '*' in RetainPtr<> type.  A for loop
3175           was used instead of a single regex so that angle brackets
3176           could be matched up when checking the type contained within
3177           the RetainPtr<> type.
3178
3179         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3180         (CppStyleTest):
3181         - Add unit test for new runtime/retainptr check.
3182
3183         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
3184         * TestWebKitAPI/EditingTestHarness.h:
3185         - Remove '*' from RetainPtr<> type.
3186
3187         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3188         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
3189           regressed in r201938.
3190
3191         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3192         (TestWebKitAPI::TEST):
3193         - Update tests to match RetainPtr.mm tests (except for the
3194           `*SimilarNSType` tests since there is no CF equivalent of
3195           RetainPtr<NSString> and RetainPtr<NSString *>).
3196
3197         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3198         (TestWebKitAPI::TEST):
3199         - Update tests to:
3200           - Not conflict by name with equivalent CF tests in
3201             RetainPtr.cpp.
3202           - Add test cases for RetainPtr<NSObject>,
3203             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
3204           - Add `*SimilarNSType` tests for converting between
3205             RetainPtr<NSObject> and RetainPtr<NSObject *>.
3206           - Change `0` to `nil` as appropriate.
3207           - Re-alphabetize the tests by name.
3208           - Add Optional<RetainPtr<>> tests.
3209           - Add retainPtr() tests.
3210
3211         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3212         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3213         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
3214         (TEST):
3215         - Remove '*' from RetainPtr<> type.
3216
3217         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
3218         (TEST(WebKit, JITEnabled)):
3219         - Add missing WTFMove().  Apparently a temporary was being
3220           created before in the argument list due to mismatched
3221           RetainPtr<> types.
3222
3223         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3224         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
3225         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
3226         (TestWebKitAPI::TEST):
3227         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3228         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3229         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3230         (WTR::resourcesDirectoryURL):
3231         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3232         (WTR::InjectedBundle::platformInitialize):
3233         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3234         - Remove '*' from RetainPtr<> type.
3235
3236 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
3237
3238         A MediaTime timescale must never be zero
3239         https://bugs.webkit.org/show_bug.cgi?id=193156
3240         <rdar://problem/32504501>
3241
3242         Reviewed by Jer Noble.
3243
3244         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3245         (TestWebKitAPI::TEST): Add tests for zero timescale.
3246
3247 2019-01-07  Youenn Fablet  <youenn@apple.com>
3248
3249         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
3250         https://bugs.webkit.org/show_bug.cgi?id=193175
3251
3252         Reviewed by Chris Dumez.
3253
3254         Updated API test as we bumped the SW schema to version 4.
3255
3256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3257         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
3258         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3259         (TEST):
3260
3261 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3262
3263         [Win][Clang] Fix compilation warnings of MiniBrowser
3264         https://bugs.webkit.org/show_bug.cgi?id=193029
3265
3266         Reviewed by Ross Kirsling.
3267
3268         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
3269         and m_URLBarFont. Reorder member variables to fix -Wreorder
3270         warning.
3271         * MiniBrowser/win/PageLoadTestClient.cpp:
3272         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
3273         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
3274         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
3275         m_currentURLIndex.
3276         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3277         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
3278         navigationClient with '{ }' to fix the missing field warning.
3279         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3280         (initDocStruct): Changed the argument type docname to const.
3281
3282 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
3283
3284         [WebAuthN] Import U2F command/response converters from Chromium
3285         https://bugs.webkit.org/show_bug.cgi?id=193150
3286         <rdar://problem/47054028>
3287
3288         Reviewed by Brent Fulgham.
3289
3290         Adds API tests.
3291
3292         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3293         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3294         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
3295         (TestWebKitAPI::getTestAuthenticatorDataBytes):
3296         (TestWebKitAPI::getTestAttestationObjectBytes):
3297         (TestWebKitAPI::getTestSignResponse):
3298         (TestWebKitAPI::getTestU2fRegisterResponse):
3299         (TestWebKitAPI::TEST):
3300         (TestWebKitAPI::convertToVector): Deleted.
3301         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3302         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
3303         (TestWebKitAPI::constructMakeCredentialRequest):
3304         (TestWebKitAPI::constructGetAssertionRequest):
3305         (TestWebKitAPI::TEST):
3306
3307 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
3308
3309         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
3310         https://bugs.webkit.org/show_bug.cgi?id=193136
3311
3312         Reviewed by Michael Catanzaro.
3313
3314         * gtk/install-dependencies:
3315         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
3316         they are needed by update-webkitgtk-libs.
3317
3318 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
3319
3320         Unreviewed follow-up fix to r239650
3321         https://bugs.webkit.org/show_bug.cgi?id=193140
3322         <rdar://problem/47063037>
3323
3324         Typecast patch_id to string.
3325
3326         * BuildSlaveSupport/ews-build/steps.py:
3327         (ValidatePatch._is_patch_obsolete):
3328
3329 2019-01-04  Daniel Bates  <dabates@apple.com>
3330
3331         [lldb-webkit]: Add support for pretty-printing raw bitmask types
3332         https://bugs.webkit.org/show_bug.cgi?id=193024
3333
3334         Reviewed by Jer Noble.
3335
3336         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
3337         for the bitmask type WebEventFlags as an example.
3338
3339         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
3340         that can be used to register summary and synthetic child formatters for a bitmask type.
3341         For example, consider the following enum and bitmask typedefs:
3342
3343         typedef enum {
3344             A = 1 << 0,
3345             B = 1 << 1,
3346             C = 1 << 2,
3347         } SpecialFlagValues;
3348         typedef unsigned SpecialFlags;
3349
3350         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
3351         __lldb_init_module():
3352
3353             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
3354                     1 << 0: "A",
3355                     1 << 1: "B",
3356                     1 << 2: "C",
3357             })
3358
3359         * lldb/lldb_webkit.py:
3360         (addSummaryAndSyntheticFormattersForRawBitmaskType):
3361         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
3362         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
3363         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
3364         A convenience function to dynamically creaste a synthetic formatter class and summary
3365         string function for the specified bitmask type and enumerator value to name map. This
3366         function register the dynamically created class and function with LLDB.
3367
3368         (__lldb_init_module):
3369         (FlagEnumerationProvider):
3370         (FlagEnumerationProvider._enumerator_value_to_name_map):
3371         (FlagEnumerationProvider._bitmask):
3372         (FlagEnumerationProvider._update):
3373         (FlagEnumerationProvider.has_children):
3374         (FlagEnumerationProvider.num_children):
3375         (FlagEnumerationProvider.get_child_index):
3376         (FlagEnumerationProvider.get_child_at_index):
3377         (FlagEnumerationProvider.update):
3378         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
3379
3380         (WTFOptionSetProvider):
3381         (WTFOptionSetProvider._enumerator_value_to_name_map):
3382         (WTFOptionSetProvider._bitmask):
3383         (WTFOptionSetProvider._update):
3384         Write in terms of the base class.
3385
3386         (RawBitmaskProviderBase):
3387         (RawBitmaskProviderBase._enumerator_value_to_name_map):
3388         (RawBitmaskProviderBase._bitmask):
3389         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
3390         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
3391         {
3392             1 << 0: "A",
3393             1 << 1: "B",
3394             1 << 2: "C",
3395         }
3396         It is not necessary to instantiate such a derived class directory. Instead use the convenience
3397         function addSummaryAndSyntheticFormattersForRawBitmaskType.
3398
3399         (WTFOptionSetProvider.has_children): Deleted.
3400         (WTFOptionSetProvider.num_children): Deleted.
3401         (WTFOptionSetProvider.get_child_index): Deleted.
3402         (WTFOptionSetProvider.get_child_at_index): Deleted.
3403         (WTFOptionSetProvider.update): Deleted.
3404
3405 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3406
3407         [ews-build] Add build step to validate the patch before processing it
3408         https://bugs.webkit.org/show_bug.cgi?id=193140
3409
3410         Reviewed by Lucas Forschler.
3411
3412         * BuildSlaveSupport/ews-build/factories.py:
3413         (Factory.__init__): Added ValidatePatch step.
3414         * BuildSlaveSupport/ews-build/steps.py:
3415         (ValidatePatch):
3416         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
3417         (ValidatePatch.get_patch_json): Get patch json data.
3418         (ValidatePatch.get_bug_json): Get bug json data.
3419         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
3420         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
3421         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
3422         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
3423         (ValidatePatch.skip_build): Skip the build.
3424         (ValidatePatch.start):
3425
3426 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3427
3428         Progress towards fixing Mac CMake build
3429         https://bugs.webkit.org/show_bug.cgi?id=193105
3430
3431         Reviewed by Don Olmstead.
3432
3433         * TestWebKitAPI/PlatformMac.cmake:
3434
3435 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3436
3437         Fix API test after r239631
3438         https://bugs.webkit.org/show_bug.cgi?id=193118
3439
3440         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3441         (TestWebKitAPI::TEST):
3442         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.
3443         Do the same thing via the API to fix the test.
3444
3445 2019-01-04  Jer Noble  <jer.noble@apple.com>
3446
3447         [WebKitLegacy] Media playback pauses on scroll
3448         https://bugs.webkit.org/show_bug.cgi?id=192829
3449
3450         Reviewed by Eric Carlson.
3451
3452         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3453         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm: Added.
3454         (TestWebKitAPI::TEST):
3455         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: Added.
3456         (-[ScrollingDoesNotPauseMediaDelegate webViewDidFinishLoad:]):
3457         (-[ScrollingDoesNotPauseMediaDelegate uiWebView:didCommitLoadForFrame:]):
3458         (-[ScrollingDoesNotPauseMediaDelegate handleEvent:]):
3459         (TestWebKitAPI::TEST):
3460
3461 2019-01-04  Chris Dumez  <cdumez@apple.com>
3462
3463         Add support for toggling device orientation API support per site
3464         https://bugs.webkit.org/show_bug.cgi?id=193143
3465         <rdar://problem/46605724>
3466
3467         Reviewed by Alex Christensen.
3468
3469         Add API test coverage.
3470
3471         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3472         (-[DataMappingSchemeHandler setTaskHandler:]):
3473         (-[DataMappingSchemeHandler webView:startURLSchemeTask:]):
3474         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationEventEnabled:]):
3475         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3476         (-[WebsitePoliciesDeviceOrientationDelegate webView:didFinishNavigation:]):
3477
3478 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3479
3480         [ews-build] use svn-apply script to apply the patches
3481         https://bugs.webkit.org/show_bug.cgi?id=193138
3482
3483         Reviewed by Lucas Forschler.
3484
3485         * BuildSlaveSupport/ews-build/factories.py:
3486         (Factory.__init__): Add the ApplyPatch step.
3487         * BuildSlaveSupport/ews-build/steps.py:
3488         (CheckOutSource): Added step name.
3489         (CheckOutSource.__init__): Used alwaysUseLatest so that it doesn't apply patch.
3490         (ApplyPatch): Build step to apply patch using svn-apply script.
3491         (UnApplyPatchIfRequired):
3492         (UnApplyPatchIfRequired.__init__): Deleted, since the alwaysUseLatest parameter is now in base class.
3493
3494 2019-01-04  Alex Christensen  <achristensen@webkit.org>
3495
3496         Deprecate WKContextCreate
3497         https://bugs.webkit.org/show_bug.cgi?id=193118
3498
3499         Reviewed by Brady Eidson.
3500
3501         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3502         (WebKitBrowserWindow::WebKitBrowserWindow):
3503         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
3504         (TestWebKitAPI::TEST):
3505         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3506         (TestWebKitAPI::TEST):
3507         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3508         (TestWebKitAPI::TEST):
3509         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
3510         (TestWebKitAPI::TEST):
3511         * TestWebKitAPI/Tests/WebKit/DownloadDecideDestinationCrash.cpp:
3512         (TestWebKitAPI::TEST):
3513         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3514         (TestWebKitAPI::TEST):
3515         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3516         (TestWebKitAPI::TEST):
3517         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3518         (TestWebKitAPI::TEST):
3519         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3520         (TestWebKitAPI::TEST):
3521         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3522         (TestWebKitAPI::TEST):
3523         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3524         (TestWebKitAPI::TEST):
3525         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3526         (TestWebKitAPI::TEST):
3527         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3528         (TestWebKitAPI::TEST):
3529         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3530         (TestWebKitAPI::TEST):
3531         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3532         (TestWebKitAPI::TEST):
3533         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3534         (TestWebKitAPI::TEST):
3535         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3536         (TestWebKitAPI::TEST):
3537         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3538         (TestWebKitAPI::TEST):
3539         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3540         (TestWebKitAPI::loadAlternateHTMLString):
3541         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3542         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3543         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3544         (TestWebKitAPI::buildAndPerformTest):
3545         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3546         (TestWebKitAPI::TEST):
3547         * TestWebKitAPI/Tests/WebKit/NavigationClientDefaultCrypto.cpp:
3548         (TestWebKitAPI::TEST):
3549         * TestWebKitAPI/Tests/WebKit/PageGroup.cpp:
3550         (TestWebKitAPI::TEST):
3551         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3552         (TestWebKitAPI::TEST):
3553         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3554         (TestWebKitAPI::TEST):
3555         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3556         (TestWebKitAPI::TEST):
3557         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3558         (TestWebKitAPI::TEST):
3559         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3560         (TestWebKitAPI::TEST):
3561         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3562         (TestWebKitAPI::TEST):
3563         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3564         (TestWebKitAPI::TEST):
3565         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3566         (TestWebKitAPI::TEST):
3567         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
3568         (TestWebKitAPI::TEST):
3569         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
3570         (TestWebKitAPI::TEST):
3571         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
3572         (TestWebKitAPI::TEST):
3573         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
3574         (TestWebKitAPI::TEST):
3575         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
3576         (TestWebKitAPI::TEST):
3577         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
3578         (TestWebKitAPI::TEST):
3579         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3580         (TestWebKitAPI::TEST):
3581         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
3582         (TestWebKitAPI::TEST):
3583         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
3584         (TestWebKitAPI::TEST):
3585         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
3586         (TestWebKitAPI::TEST):
3587         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
3588         (TestWebKitAPI::TEST):
3589         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
3590         (TestWebKitAPI::TEST):
3591         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp:
3592         (TestWebKitAPI::TEST):
3593         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
3594         (TestWebKitAPI::TEST):
3595         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
3596         (TestWebKitAPI::TEST):
3597         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3598         (WebKit2_CommandBackForwardTestWKView::SetUp):
3599         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
3600         (TestWebKitAPI::TEST):
3601         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3602         (TestWebKitAPI::TEST):
3603         * TestWebKitAPI/Tests/WebKitCocoa/SchemeRegistry.mm:
3604         (TestWebKitAPI::TEST):
3605         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3606         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3607
3608 2019-01-03  Matt Rajca  <mrajca@apple.com>
3609
3610         Make DidPlayMediaPreventedFromPlaying autoplay event more generic.
3611         https://bugs.webkit.org/show_bug.cgi?id=193128
3612         rdar://34554231
3613
3614         Reviewed by Jer Noble.
3615
3616         Today, the "DidPlayMediaPreventedFromPlaying" autoplay event is only sent for
3617         media prevented from autoplaying. It could be generalized to a "DidPlayMediaWithUserGesture"
3618         event along with a flag that indicates whether or not autoplay was actually prevented.
3619
3620         Tests: existing API tests were updated to reflect the new names. New API tests
3621         were added for the new case in which the "DidPlayMediaWithUserGesture" event is sent.
3622
3623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3624         * TestWebKitAPI/Tests/WebKit/long-test.mp4: Added.
3625         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3626         (TEST):
3627         * TestWebKitAPI/Tests/WebKitCocoa/audio-with-play-button.html: Added.
3628         * TestWebKitAPI/Tests/WebKitCocoa/video-with-play-button.html: Added.
3629
3630 2019-01-04  Chris Dumez  <cdumez@apple.com>
3631
3632         [PSON] Calling history.back() from inside the load event handler prevents process-swapping
3633         https://bugs.webkit.org/show_bug.cgi?id=193120
3634
3635         Reviewed by Alex Christensen.
3636
3637         Add API test coverage.
3638
3639         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3640
3641 2019-01-04  Chris Dumez  <cdumez@apple.com>
3642
3643         Crash under WebProcessPool::addSuspendedPage()
3644         https://bugs.webkit.org/show_bug.cgi?id=193110
3645
3646         Reviewed by Youenn Fablet.
3647
3648         Add API test coverage.
3649
3650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3651
3652 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3653
3654         [ews-build] Check patch relevance before applying the patch
3655         https://bugs.webkit.org/show_bug.cgi?id=193102
3656
3657         Reviewed by Lucas Forschler.
3658
3659         * BuildSlaveSupport/ews-build/factories.py:
3660         (Factory.__init__): Moved CheckPatchRelevance step to base class.
3661
3662 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
3663
3664         [ews-build] Check patch relevance step should print patch id
3665         https://bugs.webkit.org/show_bug.cgi?id=193137
3666
3667         Reviewed by Lucas Forschler.
3668
3669         * BuildSlaveSupport/ews-build/steps.py:
3670         (CheckPatchRelevance.start): Update the status to include patch id.
3671
3672 2019-01-04  Jonathan Bedard  <jbedard@apple.com>
3673
3674         webkitpy: Increase simulator teardown timeout
3675         https://bugs.webkit.org/show_bug.cgi?id=193141
3676         <rdar://problem/46174217>
3677
3678         Rubber-stamped by Aakash Jain.
3679
3680         * Scripts/webkitpy/xcode/simulated_device.py:
3681         (SimulatedDeviceManager.tear_down): Use SIMULATOR_BOOT_TIMEOUT.
3682
3683 2019-01-03  Ross Kirsling  <ross.kirsling@sony.com>
3684
3685         test262-runner misbehaves when test file YAML has a trailing space
3686         https://bugs.webkit.org/show_bug.cgi?id=193053
3687
3688         Reviewed by Yusuke Suzuki.
3689
3690         * Scripts/test262/Runner.pm:
3691         (parseData):
3692         Accept trailing space when parsing a test file's YAML block.
3693
3694 2019-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3695
3696         UserMedia test should use WKPageNavigationClient
3697         https://bugs.webkit.org/show_bug.cgi?id=192913
3698
3699         Reviewed by Youenn Fablet.
3700
3701         The test currently uses the deprecated WKPageLoaderClient. It should use
3702         WKPageNavigationClient instead, which provides the same callback under a similar name.
3703
3704         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3705         (TestWebKitAPI::TEST):
3706
3707 2019-01-02  Alex Christensen  <achristensen@webkit.org>
3708
3709         Homograph with LATIN SMALL LETTER R WITH FISHHOOK
3710         https://bugs.webkit.org/show_bug.cgi?id=192944
3711
3712         Reviewed by Tim Horton.
3713
3714         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3715         (TestWebKitAPI::TEST):
3716
3717 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3718
3719         Add support for using the current text selection as the find string on iOS
3720         https://bugs.webkit.org/show_bug.cgi?id=193034
3721         <rdar://problem/45138739>
3722
3723         Reviewed by Tim Horton.
3724
3725         Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
3726         _setStringForFind) works as expected.
3727
3728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3729         * TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
3730
3731 2019-01-02  Aakash Jain  <aakash_jain@apple.com>
3732
3733         [ews-build] Use git on OpenSource EWS bots
3734         https://bugs.webkit.org/show_bug.cgi?id=193092
3735
3736         Reviewed by Lucas Forschler.
3737
3738         * BuildSlaveSupport/ews-build/steps.py:
3739         (CheckOutSource): Use git instead of svn.
3740         (CheckOutSource.__init__): Use timeout of 2 hours since the initial checkout might take a long time.
3741
3742 2019-01-02  Daniel Bates  <dabates@apple.com>
3743
3744         [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
3745         https://bugs.webkit.org/show_bug.cgi?id=193023
3746
3747         Reviewed by Simon Fraser.
3748
3749         The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
3750         not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
3751         enumerator values. We should just remove this code.
3752
3753         * lldb/lldb_webkit.py:
3754         (WTFOptionSetProvider.has_children):
3755         (WTFOptionSetProvider.num_children):
3756         (WTFOptionSetProvider.get_child_index):
3757         (WTFOptionSetProvider.get_child_at_index):
3758
3759 2018-12-29  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3760
3761         .ycm_extra_conf.py should handle XXXInlines.h
3762         https://bugs.webkit.org/show_bug.cgi?id=193055
3763
3764         Reviewed by Carlos Garcia Campos.
3765
3766         compile_commands.json database only records flags and options for cpp source files.
3767         So, when we open headers, this database does not have any information for that.
3768         Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
3769         But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
3770         This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
3771         we attempt to find XXX.cpp and use the configuration if it exists.
3772
3773         * gtk/ycm_extra_conf.py:
3774         (getImplementationFilename):
3775         (FlagsForFile):
3776
3777 2018-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3778
3779         Unreviewed. Support PHP 7.3 in Debian.
3780
3781         Add 7.3 to the list of php versions supported in Debian.
3782
3783         * Scripts/webkitpy/port/base.py:
3784         (Port._debian_php_version):
3785
3786 2018-12-27  Alex Christensen  <achristensen@webkit.org>
3787
3788         Resurrect Mac CMake build
3789         https://bugs.webkit.org/show_bug.cgi?id=192658
3790
3791         Reviewed by Yusuke Suzuki.
3792
3793         * DumpRenderTree/PlatformMac.cmake:
3794         * MiniBrowser/mac/CMakeLists.txt:
3795         * TestWebKitAPI/PlatformMac.cmake:
3796
3797 2018-12-26  Adrian Perez de Castro  <aperez@igalia.com>
3798
3799         [Tools] Remove references to Bison and Flex
3800         https://bugs.webkit.org/show_bug.cgi?id=193033
3801
3802         Reviewed by Michael Catanzaro.
3803
3804         The Bison and Flex tools are not needed anymore since r209883.
3805
3806         * CygwinDownloader/cygwin-downloader.py:
3807         * EWSTools/ubuntu-ews-packages:
3808         * Scripts/filter-build-webkit:
3809         (shouldIgnoreLine):
3810         * gtk/install-dependencies:
3811         * wpe/install-dependencies:
3812
3813 2018-12-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3814
3815         WebDriver: warn about non existing tests when parsing expectations
3816         https://bugs.webkit.org/show_bug.cgi?id=192979
3817
3818         Reviewed by Michael Catanzaro.
3819
3820         It's common to update web driver tests and forget updating the test expectations in case of tests removed or
3821         renamed.
3822
3823         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
3824         (WebDriverTestRunner.__init__):
3825
3826 2018-12-21  Chris Dumez  <cdumez@apple.com>
3827
3828         navigator.userAgent in service workers does not reflect customUserAgent set by client
3829         https://bugs.webkit.org/show_bug.cgi?id=192951
3830
3831         Reviewed by Youenn Fablet.
3832
3833         Extend API test coverage.
3834
3835         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3836         (-[SWCustomUserAgentDelegate initWithUserAgent:]):
3837         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3838         (-[SWUserAgentMessageHandler initWithExpectedMessage:]):
3839         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3840
3841 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3842
3843         [WebAuthN] userPresence should always be true
3844         https://bugs.webkit.org/show_bug.cgi?id=192835
3845         <rdar://problem/46538788>
3846
3847         Reviewed by Brent Fulgham.
3848
3849         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
3850         (TestWebKitAPI::TEST):
3851
3852 2018-12-19  Simon Fraser  <simon.fraser@apple.com>
3853
3854         Add support to run-benchmark to use non-default copies of the browser apps
3855         https://bugs.webkit.org/show_bug.cgi?id=192905
3856         rdar://problem/46845840
3857
3858         Reviewed by Dewei Zhu.
3859         
3860         Add support for a --browser-path argument to run-benchmark, which allows you to use
3861         a custom app bundle for a given browser (only implemented for Safari at present).
3862
3863         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3864         (BenchmarkRunner.__init__):
3865         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3866         (BrowserDriver.__init__):
3867         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
3868         (BrowserDriverFactory.create):
3869         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3870         (OSXBrowserDriver._launch_process):
3871         (OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
3872         (OSXBrowserDriver._launch_process_with_caffinate): Deleted.
3873         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3874         (OSXChromeCanaryDriver.launch_url):
3875         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3876         (OSXFirefoxNightlyDriver.launch_url):
3877         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3878         (OSXSafariDriver.__init__):
3879         (OSXSafariDriver.launch_url):
3880         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3881         (parse_args):
3882         (run_benchmark_plan):
3883         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
3884         (WebServerBenchmarkRunner.__init__):
3885         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
3886         (FakeBenchmarkRunner.__init__):
3887
3888 2018-12-21  Jiewen Tan  <jiewen_tan@apple.com>
3889
3890         [WebAuthN] Import an APDU coder from Chromium
3891         https://bugs.webkit.org/show_bug.cgi?id=192949
3892         <rdar://problem/46879933>
3893
3894         Reviewed by Brent Fulgham.
3895
3896         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3897         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.
3898         (TestWebKitAPI::TEST):
3899
3900 2018-12-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3901
3902         Setting the file wrapper and content type of an attachment to a PDF should update its image
3903         https://bugs.webkit.org/show_bug.cgi?id=192984
3904         <rdar://problem/46798028>
3905
3906         Reviewed by Tim Horton.
3907
3908         Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
3909         PDF data correctly updates the image element.
3910
3911         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3912
3913 2018-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3914
3915         Add JSCOnly to bot dashboard
3916         https://bugs.webkit.org/show_bug.cgi?id=192964
3917
3918         Reviewed by Alexey Proskuryakov.
3919
3920         Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
3921         good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
3922         useful if they were not so secret, so add them.
3923
3924         There appear to be no build-only bots, so the first column is blank. And of course there are
3925         no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
3926         blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
3927         and there's plenty of room in the final column for all the bots.
3928
3929         I had a hard time picking a logo to use, because the JavaScript language does not have an
3930         official logo. But I believe I've found one that will be satisfactory.
3931
3932         I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.
3933
3934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
3935         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
3936         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3937         (BubbleQueueServer):
3938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3939         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3940         (WebKitBuildbot):
3941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3942         (table.queue-grid tr.platform.linux-jsconly img.logo):
3943
3944 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
3945
3946         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
3947         https://bugs.webkit.org/show_bug.cgi?id=192821
3948
3949         Reviewed by Chris Dumez.
3950
3951         * DumpRenderTree/mac/DumpRenderTree.mm:
3952         (createWebViewAndOffscreenWindow):
3953         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3954
3955 2018-12-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3956
3957         [Win][Clang] Fix compilation warnings of DumpRenderTree
3958         https://bugs.webkit.org/show_bug.cgi?id=192924
3959
3960         Reviewed by Alex Christensen.
3961
3962         * DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
3963         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3964         (AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.
3965         * DumpRenderTree/win/DumpRenderTree.cpp:
3966         (dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
3967         (resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
3968         object to the argument of setDefaultTextEncodingName instead of a
3969         const string literal.
3970         (createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
3971         (main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
3972         (setCacheFolder): Deleted.
3973         * DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
3974         * DumpRenderTree/win/EditingDelegate.cpp:
3975         (dump): Use %d for int.
3976         * DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
3977         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3978         (BSTRFromString): Deleted unused function.
3979         * DumpRenderTree/win/TestRunnerWin.cpp:
3980         (TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
3981         the arguemnt of setQuota instead of const string literal.
3982         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3983         (jsStringRefToWString): Deleted unused function.
3984
3985 2018-12-20  Chris Dumez  <cdumez@apple.com>
3986
3987         Add API test coverage for customUserAgent client setting and service workers
3988         https://bugs.webkit.org/show_bug.cgi?id=192952
3989
3990         Reviewed by Alex Christensen.
3991
3992         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3993         (-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
3994         (-[SWSchemes webView:startURLSchemeTask:]):
3995         (-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3996         (-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):
3997
3998 2018-12-20  Chris Dumez  <cdumez@apple.com>
3999
4000         Use Optional::hasValue() instead of Optional::has_value()
4001         https://bugs.webkit.org/show_bug.cgi?id=192948
4002
4003         Reviewed by Tim Horton.
4004
4005         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
4006         (TestWebKitAPI::TEST):
4007         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:
4008         (TestWebKitAPI::TEST):
4009         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
4010         (TestWebKitAPI::TEST_F):
4011
4012 2018-12-20  Chris Dumez  <cdumez@apple.com>
4013
4014         Add style script rule to check for uses of std::optional<>
4015         https://bugs.webkit.org/show_bug.cgi?id=192931
4016
4017         Reviewed by Tim Horton.
4018
4019         * Scripts/webkitpy/style/checkers/cpp.py:
4020         (check_wtf_optional):
4021         (check_style):
4022
4023 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
4024
4025         [WebAuthN] Add a runtime flag for local authenticator
4026         https://bugs.webkit.org/show_bug.cgi?id=192792
4027         <rdar://problem/46798738>
4028
4029         Reviewed by Brent Fulgham.
4030
4031         * DumpRenderTree/TestOptions.cpp:
4032         (TestOptions::TestOptions):
4033         * DumpRenderTree/TestOptions.h:
4034         * DumpRenderTree/mac/DumpRenderTree.mm:
4035         (enableExperimentalFeatures):
4036         (setWebPreferencesForTestOptions):
4037         * WebKitTestRunner/TestController.cpp:
4038         (WTR::TestController::resetPreferencesToConsistentValues):
4039         (WTR::updateTestOptionsFromTestHeader):
4040         * WebKitTestRunner/TestOptions.h:
4041         (WTR::TestOptions::hasSameInitializationOptions const):
4042
4043 2018-12-20  Jonathan Bedard  <jbedard@apple.com>
4044
4045         webkitpy: Autoinstall package URLs have changed
4046         https://bugs.webkit.org/show_bug.cgi?id=192909
4047         <rdar://problem/46860359>
4048
4049         Rubber-stamped by Alexey Proskuryakov.
4050
4051         PyPi urls have been moved around, we need to update our auto-installed packages.
4052
4053         We should check for Selenium before asking PyPi for the latest version.
4054
4055         * Scripts/webkitpy/thirdparty/__init__.py:
4056         (AutoinstallImportHook._install_mechanize): Update with new pypi url.
4057         (AutoinstallImportHook._install_keyring): Ditto.
4058         (AutoinstallImportHook._install_pep8): Ditto.
4059         (AutoinstallImportHook._install_mozlog): Ditto.
4060         (AutoinstallImportHook._install_mozprocess): Ditto.
4061         (AutoinstallImportHook._install_pytest_timeout): Ditto.
4062         (AutoinstallImportHook._install_pytest): Ditto.
4063         (AutoinstallImportHook._install_pylint): Ditto.
4064         (AutoinstallImportHook._install_buildbot): Ditto.
4065         (AutoinstallImportHook._install_coverage): Ditto.
4066         (AutoinstallImportHook._install_twisted_15_5_0): Ditto.
4067         (AutoinstallImportHook._install_selenium): Update with new pypi url, only check
4068         for new Selenium if the installed version isn't sufficient.
4069         (AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.
4070
4071 2018-12-20  Chris Dumez  <cdumez@apple.com>
4072
4073         Use Optional::valueOr() instead of Optional::value_or()
4074         https://bugs.webkit.org/show_bug.cgi?id=192933
4075
4076         Reviewed by Geoffrey Garen.
4077
4078         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
4079         (TestWebKitAPI::checkURL):
4080         (TestWebKitAPI::checkRelativeURL):
4081         (TestWebKitAPI::checkURLDifferences):
4082         (TestWebKitAPI::checkRelativeURLDifferences):
4083         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
4084         (TestWebKitAPI::checkURL):
4085
4086 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
4087
4088         Unreviewed, rolling out r239417.
4089
4090         Introduced two API test failures on macOS.
4091
4092         Reverted changeset:
4093
4094         "<rdar://problem/46194315> macOS: WebKit1 does not handle
4095         occlusion changes"
4096         https://bugs.webkit.org/show_bug.cgi?id=192821
4097         https://trac.webkit.org/changeset/239417
4098
4099 2018-12-20  Devin Rousso  <drousso@apple.com>
4100
4101         Web Inspector: UIString should take an optional key and description to aid localization
4102         https://bugs.webkit.org/show_bug.cgi?id=153962
4103         <rdar://problem/24542505>
4104
4105         Reviewed by Brian Burg.
4106
4107         * Scripts/extract-localizable-js-strings:
4108
4109 2018-12-20  Tim Horton  <timothy_horton@apple.com>
4110
4111         Unparented WKWebView can't retrieve main resource data for a main frame plugin
4112         https://bugs.webkit.org/show_bug.cgi?id=192923
4113         <rdar://problem/46859068>
4114
4115         Reviewed by Wenson Hsieh.
4116
4117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4118         * TestWebKitAPI/WebKitCocoa/GetResourceData.mm:
4119         Add a test ensuring that both parented and unparented WKWebViews can
4120         retrieve main resource data when loading a PDF.
4121
4122 2018-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
4123
4124         [GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
4125         https://bugs.webkit.org/show_bug.cgi?id=192852
4126
4127         Reviewed by Michael Catanzaro.
4128
4129         EmojiOne font was replaced by Noto Color Emoji.
4130
4131         * WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
4132         * gtk/jhbuild.modules:
4133         * wpe/jhbuild.modules:
4134
4135 2018-12-19  Chris Dumez  <cdumez@apple.com>
4136
4137         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
4138         https://bugs.webkit.org/show_bug.cgi?id=192728
4139         <rdar://problem/46746779>
4140
4141         Reviewed by Geoff Garen.
4142
4143         * DumpRenderTree/*:
4144         * MiniBrowser/*:
4145         * TestRunnerShared/*:
4146         * TestWebKitAPI/*:
4147         * WebGPUAPIStructure/*:
4148         * WebKitTestRunner/*:
4149
4150 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
4151
4152         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
4153         https://bugs.webkit.org/show_bug.cgi?id=192821
4154
4155         Reviewed by Chris Dumez.
4156
4157         * DumpRenderTree/mac/DumpRenderTree.mm:
4158         (createWebViewAndOffscreenWindow):
4159
4160 2018-12-19  Alex Christensen  <achristensen@webkit.org>
4161
4162         Navigations away from the SafeBrowsing interstitial show a flash of old content
4163         https://bugs.webkit.org/show_bug.cgi?id=192676
4164
4165         Reviewed by Chris Dumez.
4166
4167         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4168         (safeBrowsingView):
4169         (TEST):
4170         (-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
4171
4172 2018-12-19  Adrian Perez de Castro  <aperez@igalia.com>
4173
4174         [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
4175         https://bugs.webkit.org/show_bug.cgi?id=192855
4176
4177         Reviewed by Michael Catanzaro.
4178
4179         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4180         (WTR::TestController::notifyDone): Use the WPE implementation.
4181         (WTR::TestController::platformRunUntil): Use the WPE implementation.
4182         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
4183         (WTR::TestController::platformRunUntil): Honor the condition flag.
4184
4185 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
4186
4187         Allow clients to set the navigator platform
4188         https://bugs.webkit.org/show_bug.cgi?id=192735
4189
4190         Reviewed by Tim Horton.
4191
4192         Add a test for setting a custom navigator platform.
4193
4194         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4195         (-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
4196         (-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):
4197
4198 2018-12-19  Truitt Savell  <tsavell@apple.com>
4199
4200         Unreviewed, rolling out r239358.
4201
4202         Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
4203         crash on Debug bots
4204
4205         Reverted changeset:
4206
4207         "Clean up IndexedDB files between tests"
4208         https://bugs.webkit.org/show_bug.cgi?id=192796
4209         https://trac.webkit.org/changeset/239358
4210
4211 2018-12-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4212
4213         [iOS] A copied text selection is pasted as a web archive attachment in the entry view in Messages
4214         https://bugs.webkit.org/show_bug.cgi?id=192842
4215         <rdar://problem/46823586>
4216
4217         Reviewed by Tim Horton.
4218
4219         Adjusts an existing API test to verify that "com.apple.webarchive" is not one of the types registered to the
4220         item provider when dragging a rich text selection.
4221
4222         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
4223
4224 2018-12-18  David Quesada  <david_quesada@apple.com>
4225
4226         REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
4227         https://bugs.webkit.org/show_bug.cgi?id=192810
4228         <rdar://problem/46812536>
4229
4230         Reviewed by Alex Christensen.
4231
4232         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
4233         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
4234             After releasing our reference to the web view, wait until the next turn of the runloop
4235             before checking that the originatingWebView has been zeroed, since the web view might
4236             still be referenced in the autorelease pool. This _WKDownload unit test isn't about
4237             testing general memory management of WKWebViews, only that _WKDownload does not retain
4238             its web view via the 'originatingWebView' property.
4239
4240 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
4241
4242         Clean up IndexedDB files between tests
4243         https://bugs.webkit.org/show_bug.cgi?id=192796
4244
4245         Reviewed by Geoffrey Garen.
4246
4247         * DumpRenderTree/mac/DumpRenderTree.mm:
4248         (runTest):
4249         * WebKitTestRunner/TestController.cpp:
4250         (WTR::TestController::resetStateToConsistentValues):
4251         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
4252         (WTR::RemoveAllIndexedDatabasesCallback):
4253         (WTR::TestController::ClearIndexedDatabases):
4254         * WebKitTestRunner/TestController.h:
4255
4256 2018-12-18  Alex Christensen  <achristensen@webkit.org>
4257
4258         Fix API test introduced in r239339 on iOS.
4259         https://bugs.webkit.org/show_bug.cgi?id=192675
4260
4261         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4262         (TEST):
4263         The iOS implementation of the safe browsing warning is a little different.
4264         It does some element creation when it is added to the window so it knows how big it is.
4265         To test these elements, we need to simulate adding it to the window.
4266         A similar technique is done in other iOS API tests, such as SafeBrowsing.ShowWarningSPI.
4267
4268 2018-12-18  Jonathan Bedard  <jbedard@apple.com>
4269
4270         webkitpy: Ignore device type for test when using --force
4271         https://bugs.webkit.org/show_bug.cgi?id=192786
4272         <rdar://problem/46794894>
4273
4274         Reviewed by Daniel Bates.
4275
4276         It is sometimes the case that a contributor will wish to run a test on a specific device,
4277         despite expectations which indicate a test should not be run on that device.
4278
4279         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4280         (parse_args):
4281         * Scripts/webkitpy/port/device_port.py: