Remove EFL-specific files in Tools.
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-16  Alex Christensen  <achristensen@webkit.org>
2
3         Remove EFL-specific files in Tools.
4
5         Rubber-stamped by Anders Carlsson.
6
7         * ImageDiff/efl: Removed.
8         * ImageDiff/efl/ImageDiff.cpp: Removed.
9         * MiniBrowser/efl: Removed.
10         * MiniBrowser/efl/CMakeLists.txt: Removed.
11         * MiniBrowser/efl/main.c: Removed.
12         * Scripts/run-efl-tests: Removed.
13         * Scripts/update-webkitefl-libs: Removed.
14         * Scripts/webkitpy/port/efl.py: Removed.
15         * Scripts/webkitpy/port/efl_unittest.py: Removed.
16         * TestWebKitAPI/Tests/WebKit2/efl: Removed.
17         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
18         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
19         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
20         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
21         * TestWebKitAPI/efl: Removed.
22         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
23         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
24         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
25         * TestWebKitAPI/efl/main.cpp: Removed.
26         * WebKitTestRunner/InjectedBundle/efl: Removed.
27         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
28         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
29         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
30         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
31         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
32         * WebKitTestRunner/efl: Removed.
33         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
34         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
35         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
36         * WebKitTestRunner/efl/main.cpp: Removed.
37         * efl: Removed.
38         * efl/install-dependencies: Removed.
39         * efl/jhbuild-optional.modules: Removed.
40         * efl/jhbuild.modules: Removed.
41         * efl/jhbuildrc: Removed.
42         * efl/patches: Removed.
43         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
44         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
45         * efl/patches/gst-libav.patch: Removed.
46         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
47         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
48         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
49         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
50
51 2017-02-16  Myles C. Maxfield  <mmaxfield@apple.com>
52
53         font-weight in @font-face can cause a font to be downloaded even when it's not used
54         https://bugs.webkit.org/show_bug.cgi?id=168114
55         <rdar://problem/30301317>
56
57         Reviewed by Darin Adler.
58
59         LastResort needs to be usable in tests.
60
61         * DumpRenderTree/mac/DumpRenderTree.mm:
62         (allowedFontFamilySet):
63         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
64         (WTR::allowedFontFamilySet):
65         * WebKitTestRunner/mac/TestControllerMac.mm:
66         (WTR::allowedFontFamilySet):
67
68 2017-02-16  Alex Christensen  <achristensen@webkit.org>
69
70         Remove old URL parser
71         https://bugs.webkit.org/show_bug.cgi?id=168483
72
73         Reviewed by Tim Horton.
74
75         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
76         (TestWebKitAPI::checkURL):
77         (TestWebKitAPI::checkRelativeURL):
78         (TestWebKitAPI::checkURLDifferences):
79         (TestWebKitAPI::checkRelativeURLDifferences):
80
81 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
82
83         [WK2] Add additional test infrastructure and unit tests for data interaction
84         https://bugs.webkit.org/show_bug.cgi?id=168439
85         <rdar://problem/30557942>
86
87         Reviewed by Tim Horton.
88
89         Adds test support for additional data interaction scenarios that we currently cannot test, and also adds 7 new
90         test cases to DataInteractionTests. Most of the changes here refactor and augment DataInteractionSimulator to
91         support data interaction from  See per-method descriptions below for more details.
92
93         * Configurations/TestWebKitAPI.xcconfig:
94
95         Add MobileCoreServices to the list of additional frameworks to link against on iOS.
96
97         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
98
99         Add a new build phase that copies additional resources from WebKitAdditions/Resources/TestWebKitAPI and dumps
100         them into TestWebKitAPI.resources/ in the build directory, if the WebKitAdditions folder exists.
101
102         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
103         (-[TestWKWebView editorContainsImageElement]):
104         (-[TestWKWebView editorValue]):
105
106         New helper methods for querying information from the "editor" element in a test page.
107
108         (TestWebKitAPI::TEST):
109         (TestWebKitAPI::runTestsExpectingToObserveEvents): Deleted.
110
111         Moves logic for capturing events during a simulated data interaction run from the test file to
112         DataInteractionSimulator. See -[DataInteractionSimulator observedEventNames].
113
114         * TestWebKitAPI/cocoa/TestWKWebView.h:
115         * TestWebKitAPI/cocoa/TestWKWebView.mm:
116         (-[TestMessageHandler removeMessage:]):
117         (-[TestWKWebView clearMessageHandlers:]):
118
119         Add the ability to clear message handlers from the TestWKWebView.
120
121         * TestWebKitAPI/ios/DataInteractionSimulator.h:
122         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
123         (dataInteractionEventNames):
124         (-[DataInteractionSimulator initWithWebView:]):
125         (-[DataInteractionSimulator _resetSimulatedState]):
126
127         Moves logic to clear test harness state from any previous runs into a helper. Called at the beginning when
128         simulating data interaction.
129
130         (-[DataInteractionSimulator observedEventNames]):
131
132         Returns a list of the names of events relevant to data interaction that were observed over the course of the
133         most recent run.
134
135         (-[DataInteractionSimulator runFrom:to:]):
136
137         Changes -run to -runFrom:to:, which takes window-relative start and end locations. This allows the test harness
138         to run the same data interaction for multiple simulated gestures.
139
140         (-[DataInteractionSimulator _advanceProgress]):
141         (-[DataInteractionSimulator _finishDataInteraction]):
142         (-[DataInteractionSimulator externalItemProvider]):
143         (-[DataInteractionSimulator setExternalItemProvider:]):
144
145         Adds the -externalItemProvider property to DataInteractionSimulator. Setting this skips the gesture recognition
146         phase of a test run.
147
148         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
149         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
150         (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]):
151         (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]):
152
153         While a request to start data interaction is in flight, put the remainder of the test on hold until the web
154         process returns. Then continue the test by scheduling a progress advance call. This addresses a race condition
155         wherein the the web process might take longer than usual to process the request to start data interaction, and
156         in the meantime, DataInteractionSimulator would end up completing the rest of the test before a response from
157         the web process is received, which then causes no simulated delegate methods to be fired.
158
159         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): Deleted.
160         (-[DataInteractionSimulator run]): Deleted.
161
162 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
163
164         Remove unused test pages in TestWebKitAPI
165         https://bugs.webkit.org/show_bug.cgi?id=168462
166
167         Reviewed by Anders Carlsson.
168
169         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
170         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
171         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
172         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
173         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
174         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
175
176 2017-02-16  Alex Christensen  <achristensen@webkit.org>
177
178         Special URLs without a host are invalid
179         https://bugs.webkit.org/show_bug.cgi?id=168461
180
181         Reviewed by Tim Horton.
182
183         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
184         (TestWebKitAPI::TEST_F):
185
186 2017-02-10  Filip Pizlo  <fpizlo@apple.com>
187
188         The collector thread should only start when the mutator doesn't have heap access
189         https://bugs.webkit.org/show_bug.cgi?id=167737
190
191         Reviewed by Keith Miller.
192         
193         Make more tests collect continuously.
194
195         * Scripts/run-jsc-stress-tests:
196
197 2017-02-16  Tim Horton  <timothy_horton@apple.com>
198
199         WKWebView inside a UICollectionView flashes when items are inserted above it
200         https://bugs.webkit.org/show_bug.cgi?id=168376
201         <rdar://problem/29322051>
202
203         Reviewed by Simon Fraser.
204
205         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
206         (-[TestRunnerWKWebView _setStableStateOverride:]):
207         Update the one external caller of this internal method...
208
209         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
210         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
211         * DumpRenderTree/mac/UIScriptControllerMac.mm:
212         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
213         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
214         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
215         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
216         * TestRunnerShared/UIScriptContext/UIScriptController.h:
217         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
218         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
219         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
220         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
221         Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called
222         back after we dispatch a visible content rect update from the UI process
223         to the Web Content process, so any messages sent from the block will arrive
224         after the visible content rect update.
225
226 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
227
228         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS.
229         https://bugs.webkit.org/show_bug.cgi?id=168321
230
231         This bots should be added to the trunk build scheduler.
232         Unreviewed fix after r212429.
233
234         * BuildSlaveSupport/build.webkit.org-config/config.json:
235
236 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
237
238         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS
239         https://bugs.webkit.org/show_bug.cgi?id=168321
240
241         Reviewed by Michael Catanzaro.
242
243         The additionalArgument --default-cmake-features is used both to
244         skip the JHBuild (InstallGtkDependencies) build step and to build
245         with the default features from the CMake config.
246
247         * BuildSlaveSupport/build.webkit.org-config/config.json:
248         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
249         (Factory.__init__):
250         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
251
252 2017-02-15  Lucas Forschler  <lforschler@apple.com>
253
254         https://bugs.webkit.org/show_bug.cgi?id=168386
255         Remove EFL from build.webkit.org
256
257         Reviewed by Alex Christensen
258
259         * BuildSlaveSupport/build.webkit.org-config/config.json:
260         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
261         (DeleteStaleBuildFiles.start):
262         (appendCustomBuildFlags):
263         (RunWebKitTests.start):
264         (RunBuiltinsTests):
265         (Factory.__init__):
266         (TestFactory.__init__):
267         (loadBuilderConfig):
268         (InstallEflDependencies): Deleted.
269         (RunEflAPITests): Deleted.
270         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
271         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
273         (BubbleQueueServer):
274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
275         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
276         (Analyzer.prototype._triggeringQueue):
277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
278         (WebKitBuildbot):
279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
280         (table.queue-grid tr.platform.linux-efl img.logo): Deleted.
281         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
282         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
283         (_should_file_trigger_build):
284
285 2017-02-15  Alex Christensen  <achristensen@webkit.org>
286
287         Unreviewed, rolling out r212169.
288
289         Broke iOS WebInspector
290
291         Reverted changeset:
292
293         "WebInspector: refactor RemoteInspector to move cocoa specific
294         code to their own files"
295         https://bugs.webkit.org/show_bug.cgi?id=166681
296         http://trac.webkit.org/changeset/212169
297
298 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
299
300         webkitpy: Fix DarwinPort._get_crash_log()
301         https://bugs.webkit.org/show_bug.cgi?id=168372
302         <rdar://problem/30535156>
303
304         Reviewed by Daniel Bates.
305
306         Callers of _get_crash_log expect a pair to be returned and do not check it's return value.  
307         DarwinPort should return the expected return value for _get_crash_log.
308
309         * Scripts/webkitpy/port/darwin.py:
310         (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
311
312 2017-02-15  Chris Dumez  <cdumez@apple.com>
313
314         [iOS] Form Validation Bubble should be sensitive to Dynamic Type
315         https://bugs.webkit.org/show_bug.cgi?id=168291
316         <rdar://problem/30508593>
317
318         Reviewed by Tim Horton.
319
320         Drop overridePreference() implementation in iOS's UIScriptController
321         as it was only used for the minimum font size setting and this setting
322         is not exposed on iOS.
323
324         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
325         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
326         (WTR::UIScriptController::overridePreference):
327         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
328
329 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
330
331         webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
332         https://bugs.webkit.org/show_bug.cgi?id=168329
333         <rdar://problem/30518832>
334
335         Reviewed by Daniel Bates.
336
337         When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
338         never change given the same input arguments.  Memoize function for efficiency.
339
340         * Scripts/webkitpy/port/darwin.py: Add memoized import.
341         (DarwinPort):
342         (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
343         
344
345 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
346
347         webkitpy: Remove unused import from darwin.py
348         https://bugs.webkit.org/show_bug.cgi?id=168371
349
350         Reviewed by Alex Christensen.
351
352         * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
353
354 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
355
356         [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
357         https://bugs.webkit.org/show_bug.cgi?id=168364
358
359         Reviewed by Michael Catanzaro.
360
361         This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
362         credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
363         patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
364
365         Fixes: http/tests/security/credentials-from-different-domains.html
366                http/tests/xmlhttprequest/cross-origin-no-authorization.html
367
368         * gtk/jhbuild.modules:
369         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
370         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
371
372 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
373
374         [GTK] Update cookie manager API to properly work with ephemeral sessions
375         https://bugs.webkit.org/show_bug.cgi?id=168230
376
377         Reviewed by Michael Catanzaro.
378
379         Update unit tests and add new cases for the new API.
380
381         * MiniBrowser/gtk/main.c:
382         (gotWebsiteDataCallback):
383         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
384         (testCookieManagerEphemeral):
385         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
386         (testWebContextEphemeral):
387         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
388         (testWebViewEphemeral):
389         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
390         (serverCallback):
391         (testWebsiteDataEphemeral):
392         (testWebsiteDataCookies):
393         (beforeAll):
394
395 2017-02-14  Wenson Hsieh  <wenson_hsieh@apple.com>
396
397         [WK2] Support data interaction on links
398         https://bugs.webkit.org/show_bug.cgi?id=168331
399         <rdar://problem/30200837>
400
401         Reviewed by Tim Horton.
402
403         Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
404         editable area results in the link URL being inserted.
405
406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
407         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
408         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
409         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
410         (TestWebKitAPI::TEST):
411
412 2017-02-14  Jason Rinn  <jrinn@apple.com>
413
414         Add a test for new WebKit Cocoa API, _getContentsAsString.
415         https://bugs.webkit.org/show_bug.cgi?id=168147
416         <rdar://problem/30502539>
417
418         Reviewed by Tim Horton.
419
420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
421         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
422         (TEST):
423
424 2017-02-14  Matt Rajca  <mrajca@apple.com>
425
426         Website policies: iframes should respect the autoplay policy of the top-level document
427         https://bugs.webkit.org/show_bug.cgi?id=168333
428
429         Reviewed by Alex Christensen.
430
431         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
432         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
433         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
434         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
435         (TEST):
436
437 2017-02-14  Chris Dumez  <cdumez@apple.com>
438
439         HTML Form Validation bubble should take minimum font size setting into consideration
440         https://bugs.webkit.org/show_bug.cgi?id=168271
441         <rdar://problem/29869869>
442
443         Reviewed by Simon Fraser.
444
445         Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
446         font size of the validation bubble.
447
448         Add an overridePreference() method to UIScriptController. This is currently
449         used to override the value of the minimumFontSize setting. testRunner's
450         overridePreference() is not usable on WK2 because it does not update the
451         value of the preference on the UIProcess side.
452
453         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
454         (WTR::UIScriptController::overridePreference):
455         * DumpRenderTree/mac/UIScriptControllerMac.mm:
456         (WTR::UIScriptController::overridePreference):
457         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
458         * TestRunnerShared/UIScriptContext/UIScriptController.h:
459         * WebKitTestRunner/TestController.cpp:
460         (WTR::TestController::resetPreferencesToConsistentValues):
461         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
462         (WTR::UIScriptController::overridePreference):
463         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
464         (WTR::UIScriptController::contentsOfUserInterfaceItem):
465         (WTR::UIScriptController::overridePreference):
466
467 2017-02-14  Florian Bruhin  <git@the-compiler.org>
468
469         Use a set instead of a list for tests when parsing expectations
470         https://bugs.webkit.org/show_bug.cgi?id=168304
471
472         In _collect_matching_tests, a lot of membership tests are done on a giant list
473         of strings. By making it a set instead, we can make those much faster, and
474         there's no reason for it to be a list.
475
476         With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
477         to 3s on my machine.
478
479         Reviewed by Ryosuke Niwa.
480
481         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
482         (TestExpectationParser.__init__):
483         (TestExpectationParser._collect_matching_tests):
484
485 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
486
487         Unreviewed build-fix after r212297.
488
489         * Scripts/webkitpy/port/simulator_process.py:
490         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
491
492 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
493
494         [CMake] build-webkit should allow building with the default cmake configuration
495         https://bugs.webkit.org/show_bug.cgi?id=168323
496
497         Reviewed by Michael Catanzaro.
498
499         Add a --default-cmake-features switch that makes the script pass
500         no value for any of the features defined by build-webkit, that
501         way the default values from the port cmake config will be used.
502
503         * Scripts/build-webkit:
504         (cMakeArgsFromFeatures):
505
506 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
507
508         Unreviewed build-fix after r212297.
509
510         * Scripts/webkitpy/port/simulator_process.py:
511         (SimulatorProcess.stop): Handle case where there is no process to kill.
512
513 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
514
515         [CMake] build-webkit should print the cmake command executed
516         https://bugs.webkit.org/show_bug.cgi?id=168318
517
518         Reviewed by Michael Catanzaro.
519
520         Run the cmake commands to configure or start the build through
521         a wrapper that prints the command before executing it.
522
523         * Scripts/webkitdirs.pm:
524         (systemVerbose):
525         (generateBuildSystemFromCMakeProject):
526         (buildCMakeGeneratedProject):
527         (cleanCMakeGeneratedProject):
528
529 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
530
531         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
532         https://bugs.webkit.org/show_bug.cgi?id=168150
533
534         Reviewed by Alexey Proskuryakov.
535
536         * Scripts/webkitpy/port/simulator_process.py:
537         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
538         (SimulatorProcess._kill): Move closing of app into stop().
539         * Scripts/webkitpy/xcode/simulator.py:
540         (Device.launch_app):
541         (Device.terminate_app): Deleted.
542
543 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
544
545         REGRESSION(r212192): [GTK] Broke downloads API tests
546         https://bugs.webkit.org/show_bug.cgi?id=168193
547
548         Unreviewed. Update test expectations after r212192.
549
550         The suggested filename now includes a file extensions if the MIME type is known.
551
552         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
553         (testDownloadRemoteFile):
554         (testDownloadMIMEType):
555
556 2017-02-14  Commit Queue  <commit-queue@webkit.org>
557
558         Unreviewed, rolling out r212237.
559         https://bugs.webkit.org/show_bug.cgi?id=168298
560
561         This was a wrong fix (Requested by rniwa on #webkit).
562
563         Reverted changeset:
564
565         "Nwtr unexpectedly passes mismatch ref test if the hashes
566         doesn't match but no diff"
567         https://bugs.webkit.org/show_bug.cgi?id=168221
568         http://trac.webkit.org/changeset/212237
569
570 2017-02-13  Alex Christensen  <achristensen@webkit.org>
571
572         URLs with an invalid IPv4 address should be invalid
573         https://bugs.webkit.org/show_bug.cgi?id=168260
574
575         Reviewed by Tim Horton.
576
577         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
578         (TestWebKitAPI::TEST_F):
579         Update tests to reflect new correct behavior.
580
581 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
582
583         [WinCairo] Add Build Slave
584         https://bugs.webkit.org/show_bug.cgi?id=168263
585
586         Reviewed by Lucas Forschler.
587
588         * BuildSlaveSupport/build.webkit.org-config/config.json:
589
590 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
591
592         Fix the build after r212254
593
594         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
595         (-[DataInteractionSimulator _currentLocation]):
596
597 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
598
599         [WK2] Add test infrastructure and unit tests for data interaction
600         https://bugs.webkit.org/show_bug.cgi?id=168159
601         <rdar://problem/30477634>
602
603         Reviewed by Tim Horton.
604
605         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
606         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
607         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
608         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
609         gesture has already been recognized) at regular intervals over the course of the test.
610
611         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
612         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
613         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
614         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
615
616         New test pages for data interaction.
617
618         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
619         (TestWebKitAPI::runTestsExpectingToObserveEvents):
620         (TestWebKitAPI::TEST):
621         * TestWebKitAPI/cocoa/TestWKWebView.mm:
622         (-[TestWKWebView stringByEvaluatingJavaScript:]):
623         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
624         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
625         (-[MockLongPressGestureRecognizer initWithWindow:]):
626         (-[MockLongPressGestureRecognizer locationInView:]):
627         (-[MockLongPressGestureRecognizer state]):
628         (-[MockLongPressGestureRecognizer numberOfTouches]):
629         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
630         (-[DataInteractionSimulator dealloc]):
631         (-[DataInteractionSimulator run]):
632
633         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
634         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
635         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
636
637         (-[DataInteractionSimulator _advanceProgress]):
638
639         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
640         completed, and calls _finishDataInteraction when progress is at 1.
641
642         (-[DataInteractionSimulator _finishDataInteraction]):
643         (-[DataInteractionSimulator _currentLocation]):
644         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
645         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
646         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
647         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
648         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
649
650 2017-02-13  Alex Christensen  <achristensen@webkit.org>
651
652         Percent should be allowed in non-special URL hosts
653         https://bugs.webkit.org/show_bug.cgi?id=168255
654
655         Reviewed by Tim Horton.
656
657         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
658         (TestWebKitAPI::TEST_F):
659
660 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
661
662         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
663         https://bugs.webkit.org/show_bug.cgi?id=168221
664
665         Reviewed by Ryosuke Niwa.
666
667         There is a logic error in comparing mismatch ref test images. In
668         mismatch ref tests, it should be failed if two images has no diff.
669         But, if the hashes are different, nwtr unexpectedly pass the
670         mismatch ref test.
671
672         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
673         (SingleTestRunner._compare_output_with_reference): Fail the
674         mismatch ref test if hashes of two images are equal. Invoke
675         ImageDiff if the hashes don't match.
676
677 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
678
679         Update custom line breaking iterators to the latest version of Unicode
680         https://bugs.webkit.org/show_bug.cgi?id=168182
681
682         Reviewed by Zalan Bujtas.
683
684         Treat the system's ICU as the source of truth to compare breaking positions against.
685
686         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
687         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
688         (generateJavaScriptForTest):
689         (breakingLocationsFromICU):
690         (testAFewStrings):
691         (TEST):
692         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
693         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
694
695 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
696
697         [GTK] Several failing WebViewEditor API tests
698         https://bugs.webkit.org/show_bug.cgi?id=161608
699
700         Reviewed by Carlos Garcia Campos.
701
702         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
703         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
704         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
705         except the first one, which is still broken due to unrelated bug #151654.
706
707         * Scripts/run-gtk-tests:
708         (TestRunner):
709         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
710
711 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
712
713         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
714
715         * Scripts/run-gtk-tests:
716         (TestRunner):
717
718 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
719
720         Unreviewed, skip flaky form-controls-associated-signal test
721
722         * Scripts/run-gtk-tests:
723         (TestRunner):
724
725 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
726
727         [GTK] Handle caps lock indicator in event modifiers
728         https://bugs.webkit.org/show_bug.cgi?id=168186
729
730         Reviewed by Michael Catanzaro.
731
732         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
733         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
734
735 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
736
737         MiniBrowser WK1 fails to update URL for within-page navigations
738         https://bugs.webkit.org/show_bug.cgi?id=168173
739
740         Reviewed by Tim Horton.
741         
742         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
743         anchors updates the URL field.
744
745         * MiniBrowser/mac/WK1BrowserWindowController.m:
746         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
747
748 2017-02-10  John Wilander  <wilander@apple.com>
749
750         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
751         https://bugs.webkit.org/show_bug.cgi?id=167474
752         <rdar://problem/24681808>
753         <rdar://problem/24703286>
754         <rdar://problem/30290270>
755
756         This patch adds test infrastructure to allow testing 
757         of the various rules in place for data records removal.
758
759         Reviewed by Andy Estes.
760
761         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
762         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
763         (WTR::InjectedBundle::didReceiveMessageToPage):
764             Callback mechanism to tell pages that a website data store
765             scan has happened.
766         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
767         (WTR::TestRunner::setStatisticsPrevalentResource):
768         (WTR::TestRunner::isStatisticsPrevalentResource):
769         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
770         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
771         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
772         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
773         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
774         (WTR::TestRunner::statisticsFireDataModificationHandler):
775         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
776         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
777         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
778         (WTR::TestRunner::statisticsResetToConsistentState):
779         * WebKitTestRunner/InjectedBundle/TestRunner.h:
780         * WebKitTestRunner/TestController.cpp:
781         (WTR::TestController::setStatisticsPrevalentResource):
782         (WTR::TestController::isStatisticsPrevalentResource):
783         (WTR::TestController::setStatisticsHasHadUserInteraction):
784         (WTR::TestController::isStatisticsHasHadUserInteraction):
785         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
786         (WTR::TestController::statisticsFireDataModificationHandler):
787         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
788         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
789         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
790         (WTR::TestController::statisticsResetToConsistentState):
791         * WebKitTestRunner/TestController.h:
792             These are all configuration and test functions.
793         * WebKitTestRunner/TestInvocation.cpp:
794         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
795
796 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
797
798         REGRESSION(r182916) run-perf-tests never timeouts
799         https://bugs.webkit.org/show_bug.cgi?id=167626
800
801         Reviewed by Ryosuke Niwa.
802
803         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
804         was beeing ignored because the driver was created with no_timeout=True
805         unconditionally.
806         This adds a new parameter --no-timeout (disabled by default), that
807         allows to use the driver with the expected timeout values.
808         It also passes --no-timeout to DRT/WTR to ensure that timeouts
809         are always controlled by the Python Driver.
810
811         * Scripts/webkitpy/performance_tests/perftest.py:
812         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
813         (PerfTest.run): Disabling timeout should be done when the Driver is created.
814         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
815         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
816         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
817         (_run_tests_set): Pass the no-timeout parameter.
818         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
819         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
820         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
821         (MainTest.test_parse_args): Test that the argument no-timeout.
822
823 2017-02-10  Daniel Bates  <dabates@apple.com>
824
825         Detach frame from document when entering page cache
826         https://bugs.webkit.org/show_bug.cgi?id=166774
827         <rdar://problem/29904368>
828
829         Reviewed by Chris Dumez.
830
831         * DumpRenderTree/mac/DumpRenderTree.mm:
832         (resetWebPreferencesToConsistentValues):
833         * DumpRenderTree/win/DumpRenderTree.cpp:
834         (resetWebPreferencesToConsistentValues):
835         * WebKitTestRunner/TestController.cpp:
836         (WTR::TestController::resetPreferencesToConsistentValues):
837
838 2017-02-10  Tim Horton  <timothy_horton@apple.com>
839
840         Infinite UI process hang under ensurePositionInformationIsUpToDate
841         https://bugs.webkit.org/show_bug.cgi?id=168154
842         <rdar://problem/30428673>
843
844         Reviewed by Simon Fraser.
845
846         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
847         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
848         (recursiveFindHighlightLongPressRecognizer):
849         (TEST):
850         Add a somewhat nasty test that does an async interaction information update, but
851         kills the Web process before it arrives, and then does a sync interaction
852         information update, which will wait for the oustanding async interaction
853         information update if we still think it's coming. Before the patch, this
854         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
855
856 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
857
858         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
859         https://bugs.webkit.org/show_bug.cgi?id=168127
860         rdar://problem/30467120
861
862         Reviewed by Tim Horton.
863
864         Reparent the web view before we try to fetch it via:
865             [[[window contentView] subviews] objectAtIndex:0];
866         which would throw an exception if the test unparented it.
867
868         * DumpRenderTree/mac/DumpRenderTree.mm:
869         (resetWebViewToConsistentStateBeforeTesting):
870         (runTest):
871
872 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
873
874         [Resource Timing] Enable Resource Timing by default in Tests
875         https://bugs.webkit.org/show_bug.cgi?id=168145
876
877         Reviewed by Ryosuke Niwa.
878
879         * DumpRenderTree/mac/DumpRenderTree.mm:
880         (resetWebPreferencesToConsistentValues):
881         * DumpRenderTree/win/DumpRenderTree.cpp:
882         (resetWebPreferencesToConsistentValues):
883         * WebKitTestRunner/TestController.cpp:
884         (WTR::TestController::resetPreferencesToConsistentValues):
885
886 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
887
888         Removing LayoutTestRelay
889         https://bugs.webkit.org/show_bug.cgi?id=165927
890
891         Reviewed by Daniel Bates.
892         Part 2
893
894         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
895         simulators through simctl (iOS 10 and later), use this functionality instead.
896
897         * BuildSlaveSupport/built-product-archive:
898         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
899         Added a FIXME that we will need to implement similar archiving machinery once we build
900         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
901         * BuildSlaveSupport/kill-old-processes:
902         (main): Remove LayoutTestRelay from list of processes.
903         * LayoutTestRelay: Removed LayoutTestRelay.
904         * Makefile:
905         * Scripts/build-layouttestrelay: Removed.
906         * Scripts/build-webkit: Removed LayoutTestRelay references.
907
908 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
909
910         [WebCrypto] Add WebCryptoAPI to watchlist
911         https://bugs.webkit.org/show_bug.cgi?id=168138
912
913         Reviewed by Youenn Fablet.
914
915         * Scripts/webkitpy/common/config/watchlist:
916
917 2017-02-10  Brady Eidson  <beidson@apple.com>
918
919         Replace all WebKit Library Version checks in WK2 with SDK version checks.
920         https://bugs.webkit.org/show_bug.cgi?id=168124
921
922         Reviewed by Geoffrey Garen.
923
924         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
925         
926         * MiniBrowser/mac/main.m:
927         (main):
928         * MobileMiniBrowser/MobileMiniBrowser/main.m:
929         (main):
930         * TestWebKitAPI/ios/mainIOS.mm:
931         (main):
932         * TestWebKitAPI/mac/mainMac.mm:
933         (main):
934         * WebKitTestRunner/ios/mainIOS.mm:
935         (main):
936         * WebKitTestRunner/mac/main.mm:
937         (setDefaultsToConsistentValuesForTesting):
938
939 2017-02-10  Alex Christensen  <achristensen@webkit.org>
940
941         Fix El Capitan build.
942
943         * Scripts/build-webkit:
944         Don't build libwebrtc anywhere for now.
945
946 2017-02-10  Andy Estes  <aestes@apple.com>
947
948         Move two MiniBrowserBundle settings out of the .pbxproj
949         https://bugs.webkit.org/show_bug.cgi?id=168106
950
951         Reviewed by Tim Horton.
952
953         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
954         the project file. This removes the project file override.
955
956         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
957
958         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
959         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
960
961 2017-02-10  Alex Christensen  <achristensen@webkit.org>
962
963         Fix 32-and-64-bit build on El Capitan.
964
965         * Scripts/build-webkit:
966         Somebody's building with something like this:
967         build-webkit ARCHS="i386 x86_64"
968         We want this to also not build libwebrtc for now.
969
970 2017-02-10  Alex Christensen  <achristensen@webkit.org>
971
972         Fix 32-bit build on El Capitan.
973
974         * Scripts/build-webkit:
975         The bot uses ARCHS=i386 instead of --32-bit.
976         This is a hack, but it should fix the bot until I can do a better fix in the morning.
977
978 2017-02-10  Alex Christensen  <achristensen@webkit.org>
979
980         Fix 32-bit build on El Capitan.
981
982         * Scripts/build-webkit:
983         Don't build i386 libwebrtc.
984
985 2017-02-09  Alex Christensen  <achristensen@webkit.org>
986
987         Unreviewed, rolling out r212040.
988
989         Broke build.  I'm not surprised
990
991         Reverted changeset:
992
993         "[WebRTC][Mac] Activate libwebrtc"
994         https://bugs.webkit.org/show_bug.cgi?id=167293
995         http://trac.webkit.org/changeset/212040
996
997 2017-02-09  Alex Christensen  <achristensen@webkit.org>
998
999         Build libwebrtc on bots without using it yet
1000         https://bugs.webkit.org/show_bug.cgi?id=168062
1001
1002         Reviewed by Brent Fulgham.
1003
1004         * Scripts/build-webkit:
1005
1006 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1007
1008         Don't build libwebrtc.
1009
1010         * Scripts/build-webkit:
1011         Not ready yet.  It broke El Capitan and iOS.
1012
1013 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1014
1015         Build libwebrtc on bots without using it yet
1016         https://bugs.webkit.org/show_bug.cgi?id=168062
1017
1018         Reviewed by Brent Fulgham.
1019
1020         * Scripts/build-webkit:
1021
1022 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1023
1024         Rename isAppleMacWebKit to isAppleCocoaWebKit
1025         https://bugs.webkit.org/show_bug.cgi?id=168075
1026
1027         Reviewed by Geoffrey Garen.
1028
1029         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
1030
1031         * Scripts/build-api-tests:
1032         * Scripts/build-dumprendertree:
1033         * Scripts/build-jsc:
1034         (buildMyProject):
1035         * Scripts/build-layouttestrelay:
1036         * Scripts/build-webkit:
1037         * Scripts/build-webkittestrunner:
1038         * Scripts/run-api-tests:
1039         (isSupportedPlatform):
1040         (runTest):
1041         (listAllTests):
1042         (prepareEnvironmentForRunningTestTool):
1043         * Scripts/run-content-extension-tester:
1044         * Scripts/run-javascriptcore-tests:
1045         * Scripts/run-minibrowser:
1046         * Scripts/show-pretty-diff:
1047         * Scripts/webkitdirs.pm:
1048         (determineBaseProductDir):
1049         (determineArchitecture):
1050         (determinePassedArchitecture):
1051         (safariPath):
1052         (builtDylibPathForName):
1053         (checkFrameworks):
1054         (isAppleWebKit):
1055         (isAppleCocoaWebKit):
1056         (determineNmPath):
1057         (launcherName):
1058         (wrapperPrefixIfNeeded):
1059         (isCMakeBuild):
1060         (mobileSafariBundle):
1061         (debugSafari):
1062         (runSafari):
1063         (runMiniBrowser):
1064         (debugMiniBrowser):
1065         (runWebKitTestRunner):
1066         (debugWebKitTestRunner):
1067         (isAppleMacWebKit): Deleted.
1068         * Scripts/webkitperl/FeatureList.pm:
1069
1070 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1071
1072         Revert r211991
1073         https://bugs.webkit.org/show_bug.cgi?id=168062
1074
1075         * Scripts/build-webkit:
1076         Not quite ready yet.
1077
1078 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1079
1080         Build libwebrtc on bots without using it yet
1081         https://bugs.webkit.org/show_bug.cgi?id=168062
1082
1083         Reviewed by Brent Fulgham.
1084
1085         * Scripts/build-webkit:
1086         Build libwebrtc on Mac when we build ANGLE.
1087
1088 2017-02-09  Youenn Fablet  <youenn@apple.com>
1089
1090         Improve W3C importer command line options
1091         https://bugs.webkit.org/show_bug.cgi?id=167448
1092
1093         Reviewed by Ryosuke Niwa.
1094
1095         Making the list of test paths to import the main arguments of the script.
1096         Allow passing the source directory to import as a -s option.
1097         Adding a warning when given test paths are skipped by default in ImportExpectations.
1098
1099         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
1100         Link conversion rules do not change when imported tests are downloaded by the script.
1101
1102         * Scripts/webkitpy/w3c/test_importer.py:
1103         (main):
1104         (parse_args):
1105         (TestImporter.__init__):
1106         (TestImporter.do_import):
1107         (TestImporter):
1108         (TestImporter.check_imported_expectations):
1109
1110 2017-02-08  Chris Dumez  <cdumez@apple.com>
1111
1112         Update web-platform-tests resources
1113         https://bugs.webkit.org/show_bug.cgi?id=168026
1114
1115         Reviewed by Youenn Fablet.
1116
1117         Stop copying testharness.js from resources/ to web-platform-tests/resources.
1118
1119         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1120         (WebPlatformTestServer._copy_webkit_test_files):
1121
1122 2017-02-08  Andy Estes  <aestes@apple.com>
1123
1124         Custom protocols should not continue loading after a network process crash
1125         https://bugs.webkit.org/show_bug.cgi?id=168028
1126         <rdar://problem/27607520>
1127
1128         Reviewed by Brady Eidson.
1129
1130         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1131         (processGroup):
1132         (-[CloseWhileStartingProtocol startLoading]):
1133         (-[CloseWhileStartingProtocol stopLoading]):
1134         (TestWebKitAPI::runTest):
1135         (TestWebKitAPI::TEST):
1136
1137 2017-02-08  Dan Bernstein  <mitz@apple.com>
1138
1139         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
1140         https://bugs.webkit.org/show_bug.cgi?id=168031
1141
1142         Reviewed by Tim Horton.
1143
1144         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1145         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1146         (TEST):
1147         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1148         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
1149
1150 2017-02-08  Chris Dumez  <cdumez@apple.com>
1151
1152         Use smaller tiles in windows that are not active to facilitate App Napping
1153         https://bugs.webkit.org/show_bug.cgi?id=167997
1154         <rdar://problem/30358835>
1155
1156         Reviewed by Simon Fraser.
1157
1158         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1159         (WTR::PlatformWebView::setWindowIsKey):
1160         Actually update windowIsKey state of NSWindow so the WebView
1161         properly updates its activity state.
1162
1163 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1164
1165         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
1166         https://bugs.webkit.org/show_bug.cgi?id=167942
1167         <rdar://problem/30315079>
1168
1169         Reviewed by Tim Horton.
1170
1171         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
1172         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
1173         contenteditable in these cases.
1174
1175         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
1176         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
1177         performDragOperation:) directly.
1178
1179         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1180         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
1181         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1182         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1183         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1184         (-[DragSource draggingSourceOperationMaskForLocal:]):
1185         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1186         (-[DragInfo lastMousePosition]):
1187         (-[DragInfo setLastMousePosition:]):
1188         (-[DragInfo draggingDestinationWindow]):
1189         (-[DragInfo draggingSourceOperationMask]):
1190         (-[DragInfo draggingLocation]):
1191         (-[DragInfo draggedImageLocation]):
1192         (-[DragInfo draggedImage]):
1193         (-[DragInfo draggingPasteboard]):
1194         (-[DragInfo draggingSource]):
1195         (-[DragInfo draggingSequenceNumber]):
1196         (-[DragInfo slideDraggedImageTo:]):
1197         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1198         (-[DragInfo draggingFormation]):
1199         (-[DragInfo setDraggingFormation:]):
1200         (-[DragInfo animatesToDestination]):
1201         (-[DragInfo setAnimatesToDestination:]):
1202         (-[DragInfo numberOfValidItemsForDrop]):
1203         (-[DragInfo setNumberOfValidItemsForDrop:]):
1204         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1205         (-[DragInfo springLoadingHighlight]):
1206         (-[DragInfo resetSpringLoading]):
1207         (TestWebKitAPI::getTestImage):
1208         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1209         (TestWebKitAPI::TEST):
1210         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
1211
1212 2017-02-08  Jer Noble  <jer.noble@apple.com>
1213
1214         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
1215         https://bugs.webkit.org/show_bug.cgi?id=168007
1216
1217         Reviewed by Alex Christensen.
1218
1219         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1220         (didFinishLoadForFrame):
1221         (TestWebKitAPI::TEST):
1222
1223 2017-02-08  Commit Queue  <commit-queue@webkit.org>
1224
1225         Unreviewed, rolling out r211873.
1226         https://bugs.webkit.org/show_bug.cgi?id=168001
1227
1228         It's in jhbuild for consistent layout tests (Requested by
1229         mcatanzaro on #webkit).
1230
1231         Reverted changeset:
1232
1233         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
1234         https://bugs.webkit.org/show_bug.cgi?id=167993
1235         http://trac.webkit.org/changeset/211873
1236
1237 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
1238
1239         [GTK] Add icu packages to Tools/gtk/install-dependencies
1240         https://bugs.webkit.org/show_bug.cgi?id=167993
1241
1242         Reviewed by Michael Catanzaro.
1243
1244         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
1245         depending in the GNU/Linux distribution)
1246
1247 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1248
1249         Update flakiness dashboard configuration.
1250         https://bugs.webkit.org/show_bug.cgi?id=167957
1251
1252         Reviewed by Alexey Proskuryakov.
1253
1254         * TestResultServer/static-dashboards/builders.jsonp:
1255
1256 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1257
1258         Replace a bot that has an incorrect configuration.
1259         https://bugs.webkit.org/show_bug.cgi?id=167747
1260
1261         Rubber-stamped by Alexey Proskuryakov.
1262
1263         * BuildSlaveSupport/build.webkit.org-config/config.json:
1264
1265 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
1266
1267         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
1268         https://bugs.webkit.org/show_bug.cgi?id=167927
1269
1270         Reviewed by Brent Fulgham.
1271
1272         Enable ComplexTextController API tests on the Win and GTK ports.
1273
1274         * TestWebKitAPI/PlatformGTK.cmake:
1275         * TestWebKitAPI/PlatformWin.cmake:
1276
1277 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
1278
1279         File index appended to previous file in svn-create-patch with SVN 1.9
1280         https://bugs.webkit.org/show_bug.cgi?id=167903
1281         <rdar://problem/30387395>
1282
1283         Reviewed by Daniel Bates.
1284
1285         * Scripts/VCSUtils.pm:
1286         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
1287         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
1288         trailing newline character from the expected result before comparing it to the actual result.
1289
1290 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
1291
1292         [webkitdirs] remove unused host_processor variable in determineArchitecture()
1293         https://bugs.webkit.org/show_bug.cgi?id=167936
1294
1295         Reviewed by Michael Catanzaro.
1296
1297         * Scripts/webkitdirs.pm:
1298         (determineArchitecture):
1299         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
1300         since r195083.
1301
1302 2017-02-07  Youenn Fablet  <youenn@apple.com>
1303
1304         Use a JSON file to define which WPT files/folders to import
1305         https://bugs.webkit.org/show_bug.cgi?id=167923
1306
1307         Reviewed by Alex Christensen.
1308
1309         * Scripts/webkitpy/w3c/test_downloader.py:
1310         (TestDownloader.__init__):
1311         (TestDownloader._init_paths_from_expectations):
1312         * Scripts/webkitpy/w3c/test_importer.py:
1313         (parse_args):
1314         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1315
1316 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1317
1318         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
1319         https://bugs.webkit.org/show_bug.cgi?id=167916
1320
1321         Reviewed by Carlos Garcia Campos.
1322
1323         URL of mesa-11.0.6.tar.xz has been moved.
1324
1325         * gtk/jhbuild.modules: Fix the module path.
1326
1327 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
1328
1329         Static Analyzer: Address some leaks in MiniBrowser
1330         https://bugs.webkit.org/show_bug.cgi?id=167897
1331
1332         Reviewed by Alexey Proskuryakov.
1333
1334         * MiniBrowser/mac/BrowserWindowController.m:
1335         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1336         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1337         (-[ExtensionManagerWindowController add:]):
1338         (-[ExtensionManagerWindowController remove:]):
1339         * MiniBrowser/mac/SettingsController.m:
1340         (-[SettingsController _populateMenu]):
1341         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
1342         Address obvious leaks caught by the static analyzer.
1343
1344 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
1345
1346         Migrate ComplexTextController to use platform-independent types
1347         https://bugs.webkit.org/show_bug.cgi?id=167833
1348
1349         Reviewed by Brent Fulgham.
1350
1351         Migrate tests away from platform-dependent types.
1352
1353         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1354         (TestWebKitAPI::TEST_F):
1355
1356 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
1357
1358         Correct File Path Handling in SecurityOrigin and FileSystem
1359         https://bugs.webkit.org/show_bug.cgi?id=167894
1360         <rdar://problem/30380080>
1361
1362         Reviewed by Alexey Proskuryakov.
1363
1364         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
1365         and perform same-volume checks using filesystem-compatible paths.        
1366         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
1367         filesystem paths, and perform validation of same-volume checks.
1368         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
1369         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
1370         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
1371         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
1372
1373 2017-02-06  Jer Noble  <jer.noble@apple.com>
1374
1375         Playback stalls when a SourceBuffer append causes frame eviction
1376         https://bugs.webkit.org/show_bug.cgi?id=167834
1377
1378         Reviewed by Eric Carlson.
1379
1380         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
1381         for the WTF::MediaTime class.
1382
1383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1384         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1385         (TestWebKitAPI::TEST):
1386         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
1387         (WTF::operator<<):
1388         (TestWebKitAPI::TestSample::create):
1389         (TestWebKitAPI::TestSample::TestSample):
1390         (TestWebKitAPI::TEST_F):
1391
1392 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
1393
1394         Change capitalization in platform name after r211735.
1395
1396         Unreviewed dashboard fix.
1397
1398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1399         (WebKitBuildbot):
1400
1401 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
1402
1403         Move the Leaks bot to Sierra
1404         https://bugs.webkit.org/show_bug.cgi?id=167886
1405
1406         Reviewed by Daniel Bates.
1407
1408         * BuildSlaveSupport/build.webkit.org-config/config.json:
1409         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1410         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1411         (LeaksViewer._displayURLPrompt):
1412         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1413         (WebKitBuildbot):
1414
1415 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
1416
1417         Prevent app crash on launch during simctl install workaround
1418         https://bugs.webkit.org/show_bug.cgi?id=167685
1419
1420         Reviewed by Daniel Bates.
1421
1422         * Scripts/webkitpy/port/simulator_process.py:
1423         (SimulatorProcess.__init__): Pass environment to install.
1424         * Scripts/webkitpy/xcode/simulator.py:
1425         (Device.install_app): Accept environment, pass environment to launch.
1426
1427 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1428
1429         Rebase API tests after r211638
1430         https://bugs.webkit.org/show_bug.cgi?id=167779
1431
1432         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1433         (TestWebKitAPI::TEST_F):
1434         URLs with non-special schemes and characters like % in the host now fail to parse,
1435         more like their special counterparts and according to spec.
1436
1437 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
1438
1439         Unreviewed trivial fix after r211697.
1440         https://bugs.webkit.org/show_bug.cgi?id=167863
1441
1442         * Scripts/run-javascriptcore-tests:
1443         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
1444
1445 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
1446
1447         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
1448         https://bugs.webkit.org/show_bug.cgi?id=167850
1449
1450         Reviewed by Tim Horton.
1451
1452         * DumpRenderTree/TestRunner.cpp:
1453         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
1454
1455 2017-02-04  Andreas Kling  <akling@apple.com>
1456
1457         Plug some leaks in TestController and UIScriptContext.
1458         <https://webkit.org/b/167839>
1459
1460         Reviewed by Alexey Proskuryakov.
1461
1462         Fix a couple of the leaks seen on the leaks bot.
1463
1464         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1465         (UIScriptContext::runUIScript):
1466         * WebKitTestRunner/TestController.cpp:
1467         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1468         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1469
1470 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
1471
1472         WK1 mouse events are missing movementX and movementY for pointerlock.
1473         https://bugs.webkit.org/show_bug.cgi?id=167775
1474         rdar://problem/30343810
1475
1476         Reviewed by Alexey Proskuryakov.
1477
1478         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
1479
1480         * DumpRenderTree/mac/EventSendingController.mm:
1481         (-[EventSendingController mouseMoveToX:Y:]):
1482         * WebKitTestRunner/mac/EventSenderProxy.mm:
1483         (WTR::EventSenderProxy::mouseMoveTo):
1484
1485 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
1486
1487         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
1488         https://bugs.webkit.org/show_bug.cgi?id=167774
1489
1490         Reviewed by Tim Horton.
1491
1492         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
1493         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
1494         web process are async, so the callback fires after the web process gets the new state.
1495
1496         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1497         (WTR::UIScriptController::removeViewFromWindow):
1498         (WTR::UIScriptController::addViewToWindow):
1499         * DumpRenderTree/mac/DumpRenderTree.mm:
1500         (createWebViewAndOffscreenWindow):
1501         (resetWebViewToConsistentStateBeforeTesting):
1502         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1503         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1504         (WTR::UIScriptController::removeViewFromWindow):
1505         (WTR::UIScriptController::addViewToWindow):
1506         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1507         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1508         (WTR::UIScriptController::removeViewFromWindow):
1509         (WTR::UIScriptController::addViewToWindow):
1510         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1511         * WebKitTestRunner/PlatformWebView.h:
1512         * WebKitTestRunner/TestController.cpp:
1513         (WTR::TestController::resetStateToConsistentValues):
1514         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1515         (WTR::PlatformWebView::removeFromWindow):
1516         (WTR::PlatformWebView::addToWindow):
1517         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1518         (WTR::UIScriptController::removeViewFromWindow):
1519         (WTR::UIScriptController::addViewToWindow):
1520         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1521         (WTR::PlatformWebView::removeFromWindow):
1522         (WTR::PlatformWebView::addToWindow):
1523         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1524         (WTR::UIScriptController::removeViewFromWindow):
1525         (WTR::UIScriptController::addViewToWindow):
1526
1527 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
1528
1529         Remove check for SkipSafariExecutableEntitlementChecks
1530         https://bugs.webkit.org/show_bug.cgi?id=167762
1531
1532         Reviewed by Dan Bernstein.
1533
1534         Follow-up fix: don't break internal behavior.
1535
1536         * Scripts/webkitdirs.pm:
1537         (safariPath):
1538         (executableHasEntitlements): Deleted.
1539         (safariPathFromSafariBundle): Deleted.
1540         (installedSafariPath): Deleted.
1541
1542 2017-02-03  Daniel Bates  <dabates@apple.com>
1543
1544         [Mac][WK2] Add SPI to override the Content Security Policy of a page
1545         https://bugs.webkit.org/show_bug.cgi?id=167810
1546         <rdar://problem/30102568>
1547
1548         Reviewed by Anders Carlsson.
1549
1550         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
1551
1552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1553         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
1554         (TEST):
1555         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1556         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1557         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1558         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1559
1560 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1561
1562         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1563         https://bugs.webkit.org/show_bug.cgi?id=167773
1564         <rdar://problem/30221102>
1565
1566         Reviewed by Ryosuke Niwa.
1567
1568         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1569         (TestWebKitAPI::TEST_F):
1570
1571 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
1572
1573         Remove check for SkipSafariExecutableEntitlementChecks
1574         https://bugs.webkit.org/show_bug.cgi?id=167762
1575         rdar://problem/22480673
1576
1577         Reviewed by Dan Bernstein.
1578
1579         * Scripts/webkitdirs.pm:
1580         (safariPathFromSafariBundle):
1581         (skipSafariExecutableEntitlementChecks): Deleted.
1582
1583 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
1584
1585         Undefined subroutine in svn-create-patch
1586         https://bugs.webkit.org/show_bug.cgi?id=167742
1587
1588         Unreviewed build-fix after r211543.
1589
1590         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1591
1592 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1593
1594         Unreviewed. Fix jhbuild dependencies build.
1595
1596         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1597         Patch updated.
1598
1599 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1600
1601         [EME][GStreamer] Fixed decryptor selection
1602         https://bugs.webkit.org/show_bug.cgi?id=167588
1603
1604         Reviewed by Žan Doberšek.
1605
1606         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1607
1608         * gtk/jhbuild.modules: Added patches to gstreamer and
1609         gst-plugins-good packages.
1610         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1611         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1612
1613 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1614
1615         Make run-benchmark script supports 'config' key in test plan.
1616         https://bugs.webkit.org/show_bug.cgi?id=167715
1617
1618         Reviewed by Ryosuke Niwa.
1619
1620         Add support for 'config' key in test paln.
1621         'config' key is a dictionary that specifies environment configurations while test is running.
1622         Specifies orientation to be portrait in MotionMark benchmark.
1623
1624         * Scripts/webkitpy/benchmark_runner/README.md:
1625         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1626         (BenchmarkRunner.__init__):
1627         (BenchmarkRunner._run_benchmark):
1628         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1629         (BrowserDriver.prepare_env):
1630         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1631         (LinuxBrowserDriver.prepare_env):
1632         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1633         (OSXBrowserDriver.prepare_env):
1634         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1635         (OSXSafariDriver.prepare_env):
1636         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1637
1638 2017-02-01  Daniel Bates  <dabates@apple.com>
1639
1640         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1641         https://bugs.webkit.org/show_bug.cgi?id=167169
1642
1643         Reviewed by David Kilzer.
1644
1645         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1646         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1647         header from the output of "svn diff" on a file that was copied or moved.
1648
1649         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1650         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1651         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1652         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1653         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1654         of a file with only a property change also does not contain any chunk range lines. Therefore
1655         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1656         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1657         we should directly test for the presence of a leading SVN diff header with an empty body and
1658         remove such lines from the diff.
1659
1660         * Scripts/VCSUtils.pm:
1661         (fixSVNPatchForAdditionWithHistory): Added.
1662         * Scripts/svn-create-patch:
1663         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1664         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1665         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1666
1667 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1668
1669         [Mac] Update CARingBuffer class
1670         https://bugs.webkit.org/show_bug.cgi?id=167656
1671
1672         Reviewed by Jer Noble.
1673
1674         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1675         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1676         (TestWebKitAPI::CARingBufferTest::SetUp):
1677         (TestWebKitAPI::CARingBufferTest::setup):
1678         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1679         (TestWebKitAPI::CARingBufferTest::description):
1680         (TestWebKitAPI::CARingBufferTest::bufferList):
1681         (TestWebKitAPI::CARingBufferTest::ringBuffer):
1682         (TestWebKitAPI::CARingBufferTest::capacity):
1683         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
1684         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
1685         (TestWebKitAPI::TEST_F):
1686         (TestWebKitAPI::MixingTest::run):
1687
1688 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
1689
1690         [Mac] TestWebKitAPI includes system frameworks incorrectly
1691         https://bugs.webkit.org/show_bug.cgi?id=167703
1692         rdar://problem/30301498
1693
1694         Reviewed by Ryosuke Niwa.
1695
1696         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
1697         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
1698
1699         Also, reduced the number of subframework search paths, looks like we only need one now.
1700
1701         * TestWebKitAPI/Configurations/Base.xcconfig:
1702
1703 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
1704
1705         Correct "filesHaveSameVolume" predicate
1706         https://bugs.webkit.org/show_bug.cgi?id=167696
1707         <rdar://problem/30298722>
1708
1709         Reviewed by David Kilzer.
1710
1711         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
1712         percent-escaped path inputs.
1713
1714         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
1715         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
1716         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
1717         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
1718         (TestWebKitAPI::TEST_F):
1719
1720 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1721
1722         Unreviewed. Fix coding style in MiniBrowser
1723
1724         * MiniBrowser/gtk/BrowserWindow.c:
1725         (editingCommandCallback):
1726         (insertImageCommandCallback):
1727         (insertLinkCommandCallback):
1728
1729 2017-02-01  Tomas Popela  <tpopela@redhat.com>
1730
1731         [GTK] Add an API to add a custom tab into the print dialog
1732         https://bugs.webkit.org/show_bug.cgi?id=151998
1733
1734         Reviewed by Carlos Garcia Campos.
1735
1736         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
1737         that is testing a newly added API.
1738
1739         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1740         (testPrintCustomWidget):
1741         (beforeAll):
1742
1743 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
1744
1745         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
1746         https://bugs.webkit.org/show_bug.cgi?id=166529
1747
1748         Reviewed by Xabier Rodriguez-Calvar.
1749
1750         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
1751         New patch version accepted in GStreamer upstream.
1752
1753 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1754
1755         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
1756         https://bugs.webkit.org/show_bug.cgi?id=167498
1757
1758         Reviewed by Carlos Garcia Campos.
1759
1760         Depending on the distro version you can need either libxfont1-dev
1761         or libfont-dev to build with jhbuild.
1762
1763         * gtk/install-dependencies:
1764
1765 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1766
1767         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
1768         https://bugs.webkit.org/show_bug.cgi?id=167594
1769
1770         Unreviewed test gardening.
1771
1772         Disabling this test while we investigate the cause of a timeout on ios-simulator.
1773
1774         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1775         (TEST):
1776
1777 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
1778
1779         Move slow-running microbenchmarks out of JSTests/microbenchmarks
1780         https://bugs.webkit.org/show_bug.cgi?id=167676
1781
1782         Reviewed by Saam Barati.
1783
1784         * Scripts/run-javascriptcore-tests:
1785         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
1786
1787 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
1788
1789         Make Dump Render Tree not crash
1790         https://bugs.webkit.org/show_bug.cgi?id=167667
1791
1792         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
1793         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
1794         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
1795         This does not fix any tests, it just fixes the crash.
1796         
1797         Reviewed by Simon Fraser.
1798
1799         * DumpRenderTree/TestRunner.cpp:
1800         (TestRunner::callUIScriptCallback):
1801
1802 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1803
1804         Workaround for simctl install failing to report install failure
1805         https://bugs.webkit.org/show_bug.cgi?id=167654
1806
1807         Reviewed by Daniel Bates.
1808
1809         simctl install will sometimes report success even though install has failed.
1810         To workaround this bug, we attempt an app launch after install to ensure
1811         install has succeeded.
1812
1813         * Scripts/webkitpy/xcode/simulator.py:
1814         (Device.install_app): Attempt app launch after install, retry install if launch fails.
1815         (Device.launch_app): Correct comment.
1816
1817 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
1818
1819         Unreviewed webkitpy fix after r211405.
1820
1821         * Scripts/webkitpy/xcode/simulator.py:
1822         (Device.launch_app): Remove @staticmethod on _log_debug_error.
1823
1824 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1825
1826         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
1827
1828         * gtk/manifest.txt.in:
1829
1830 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
1831
1832         AX: enable search predication for iOS
1833         https://bugs.webkit.org/show_bug.cgi?id=167558
1834         <rdar://problem/30251367>
1835
1836         Reviewed by Joanmarie Diggs.
1837
1838         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1839         (AccessibilityUIElement::uiElementForSearchPredicate):
1840         * DumpRenderTree/mac/AccessibilityCommonMac.h:
1841         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1842         (searchPredicateParameterizedAttributeForSearchCriteria):
1843         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1844         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1845         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1846         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1847         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1848         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
1849         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1850         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1851         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1852         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
1853         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1854
1855 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1856
1857         Workaround for simctl launch bug
1858         https://bugs.webkit.org/show_bug.cgi?id=167613
1859
1860         Reviewed by Daniel Bates.
1861
1862         simctl launch will sometimes fail because of a race condition when many
1863         simulators are being run simultaneously. These failures will always have
1864         an exit code of 1. This change attempts to launch an app multiple times
1865         before reporting a failure to workaround this bug.
1866
1867         * Scripts/webkitpy/xcode/simulator.py:
1868         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
1869
1870 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
1871
1872         Commit queue fails to look at real name aliases for the reviewer
1873         https://bugs.webkit.org/show_bug.cgi?id=167422
1874
1875         Reviewed by Joseph Pecoraro.
1876
1877         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1878         (test_has_valid_reviewer): Added tests.
1879
1880         * Scripts/webkitpy/common/config/committers.py:
1881         (CommitterList._name_to_contributor_map):
1882         Made _name_to_contributor_map include alias names.
1883
1884         * Scripts/webkitpy/common/config/committers_unittest.py:
1885         (CommittersTest.test_contributors_by_fuzzy_match):
1886         Removed subtests that are now obsolete, as these matches are strict. It is not
1887         obvious if distance based fuzzy matching for names is useful at all, but we can
1888         look into that some other time.
1889
1890 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
1891
1892         QueueStatusServer should have an explicit timeout for _fetch_url
1893         https://bugs.webkit.org/show_bug.cgi?id=167467
1894
1895         Reviewed by Alexey Proskuryakov.
1896
1897         * Scripts/webkitpy/common/net/statusserver.py:
1898         (StatusServer._fetch_url): Add an explicit timeout of 300s.
1899
1900 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
1901
1902         Add support for Trac instances that host multiple projects.
1903         https://bugs.webkit.org/show_bug.cgi?id=167524
1904
1905         Reviewed by Alexey Proskuryakov.
1906
1907         When multiple projects are hosted on a single Trac instance, the current
1908         behavior will retrieve changesets from all tracked projects.
1909         This patch teaches Trac.js to get project-specific changesets from Trac.
1910         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
1911         when querying the Trac timeline.
1912
1913         To tell Trac to be aware of multi-project instances we leverage the 
1914         `options` parameter when creating a new instance: 
1915
1916             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
1917
1918         If this option is not provided, the original behaviour will prevail.
1919         Additionally, add corresponding tests.
1920
1921         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1922         (Trac): Reason about new optional parameter 'projectIdentifier'.
1923         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
1924         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
1925         replace default parameter `changeset=on` with `repo-projectname=on`.
1926         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
1927         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
1928         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
1929         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1930         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
1931         Add the following tests:
1932             test("revisionURL")
1933             test("revisionURL with Trac Identifier")
1934             test("_xmlTimelineURL")
1935             test("_xmlTimelineURL with Trac Identifier")
1936         (this.view._latestProductiveIteration): Fix missing ';'.
1937
1938 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
1939
1940         Correct spacing regression on inter-element complex path shaping on some fonts
1941         https://bugs.webkit.org/show_bug.cgi?id=166013
1942
1943         Reviewed by Simon Fraser.
1944
1945         Unskip existing tests and make some new tests:
1946         - Testing complex text with no origins
1947         - Testing initial expansions
1948         - Testing the sign of vertical advances
1949
1950         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1951         (TestWebKitAPI::TEST_F):
1952
1953 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1954
1955         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
1956         https://bugs.webkit.org/show_bug.cgi?id=167596
1957
1958         Reviewed by Daniel Bates.
1959
1960         We avoid needing a thin directory by invoking the zip program with
1961         the list of directories from the build directory to be zipped,
1962         and by using the zip feature to exclude files matching a pattern.
1963
1964         * BuildSlaveSupport/built-product-archive:
1965         (copyBuildFiles):
1966         (createZipFromList):
1967         (archiveBuiltProduct):
1968
1969 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
1970
1971         Use simctl instead of LayoutTestRelay
1972         https://bugs.webkit.org/show_bug.cgi?id=165927
1973
1974         Reviewed by Daniel Bates.
1975
1976         Part 1
1977
1978         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1979         simulators through simctl (iOS 10 and later), use this functionality instead.
1980
1981         * Scripts/webkitpy/port/base.py:
1982         (Port.__init__): Added _test_runner_process_constructor.
1983         * Scripts/webkitpy/port/darwin.py:
1984         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
1985         * Scripts/webkitpy/port/driver.py:
1986         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
1987         (IOSSimulatorDriver): Deleted.
1988         * Scripts/webkitpy/port/driver_unittest.py:
1989         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
1990         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
1991         (DriverTest.test_start_actually_starts): Ditto.
1992         * Scripts/webkitpy/port/ios.py:
1993         (IOSSimulatorPort): Remove relay_name.
1994         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
1995         (IOSSimulatorPort._create_simulators): Formatting change.
1996         (IOSSimulatorPort.relay_path): Deleted.
1997         (IOSSimulatorPort._check_relay): Deleted.
1998         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
1999         (IOSSimulatorPort._build_relay): Deleted.
2000         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
2001         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
2002         * Scripts/webkitpy/port/ios_unittest.py:
2003         (iosTest.test_32bit): Update test.
2004         (iosTest.test_64bit): Update test.
2005         * Scripts/webkitpy/port/server_process.py:
2006         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
2007         (ServerProcess._set_file_nonblocking): Added to share common code.
2008         * Scripts/webkitpy/port/server_process_mock.py:
2009         (MockServerProcess.__init__): Added argument worker_number.
2010         * Scripts/webkitpy/port/simulator_process.py: Added.
2011         (SimulatorProcess): Added.
2012         (SimulatorProcess.Popen): Added.
2013         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
2014         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
2015         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
2016         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
2017         (SimulatorProcess._reset): Added. Unlink fifos.
2018         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
2019         (SimulatorProcess._kill): Added. Shutdown app on simulator.
2020         * Scripts/webkitpy/xcode/simulator.py:
2021         (Device.__init__): Accept host to run install/launch/terminate.
2022         (Device.install_app): Install app to target Device.
2023         (Device.launch_app): Launch app on target Device.
2024         (Device.terminate_app): Shutdown app on target Device.
2025         (Simulator._parse_devices): Pass host to Device.
2026
2027 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2028
2029         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
2030         https://bugs.webkit.org/show_bug.cgi?id=167411
2031
2032         Reviewed by Michael Catanzaro.
2033
2034         Disable the ARM iwMMXt fast path for pixman, because it triggers
2035         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
2036
2037         * gtk/jhbuild.modules:
2038
2039 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2040
2041         [GTK] Add API to handle the accelerated compositing policy
2042         https://bugs.webkit.org/show_bug.cgi?id=167509
2043
2044         Reviewed by Michael Catanzaro.
2045
2046         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
2047         as a special case. Also add test cases to the get/set API.
2048
2049         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2050         (hardwareAccelerationPolicyToString):
2051         (stringToHardwareAccelerationPolicy):
2052         (cellRendererChanged):
2053         (browserSettingsDialogConstructed):
2054         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2055         (testWebKitSettings):
2056
2057 2017-01-29  Andy Estes  <aestes@apple.com>
2058
2059         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
2060         https://bugs.webkit.org/show_bug.cgi?id=167563
2061         <rdar://problem/30253207>
2062
2063         Reviewed by Andreas Kling.
2064
2065         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2066         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2067         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2068         (runTest):
2069         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2070         (TEST):
2071
2072 2017-01-29  Dan Bernstein  <mitz@apple.com>
2073
2074         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
2075         https://bugs.webkit.org/show_bug.cgi?id=167565
2076
2077         Reviewed by Sam Weinig.
2078
2079         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2080         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
2081         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
2082         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
2083         (TEST):
2084         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
2085         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2086         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2087         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
2088
2089 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2090
2091         Add Link Preload as an off-by-default experimental feature menu item.
2092         https://bugs.webkit.org/show_bug.cgi?id=167201
2093
2094         Reviewed by Ryosuke Niwa.
2095
2096         * DumpRenderTree/mac/DumpRenderTree.mm:
2097         (resetWebPreferencesToConsistentValues):
2098         * DumpRenderTree/win/DumpRenderTree.cpp:
2099         (resetWebPreferencesToConsistentValues):
2100
2101 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2102
2103         Add User Timing Experimental Feature
2104         https://bugs.webkit.org/show_bug.cgi?id=167542
2105         <rdar://problem/22746307>
2106
2107         Reviewed by Ryosuke Niwa.
2108
2109         * DumpRenderTree/mac/DumpRenderTree.mm:
2110         (enableExperimentalFeatures):
2111         (resetWebPreferencesToConsistentValues):
2112         * DumpRenderTree/win/DumpRenderTree.cpp:
2113         (enableExperimentalFeatures):
2114
2115 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2116
2117         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
2118         https://bugs.webkit.org/show_bug.cgi?id=167519
2119
2120         Reviewed by Ryosuke Niwa.
2121
2122         * QueueStatusServer/templates/statusbubble.html:
2123         To measure the bubbleContainer's width, it must not be wrapping based
2124         on its parent container. So when measuring the width temporarily set
2125         the parent to a very large width so as to not artificially wrap us.
2126         Restore the parent's width after measuring.
2127
2128 2017-01-27  Andy Estes  <aestes@apple.com>
2129
2130         [iOS] Add a test for _WKNSFileManagerExtras
2131         https://bugs.webkit.org/show_bug.cgi?id=167478
2132
2133         Reviewed by Andreas Kling.
2134
2135         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2136         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
2137         (expectAttributes):
2138         (TEST):
2139
2140 2017-01-27  Keith Miller  <keith_miller@apple.com>
2141
2142         run-benchmarks should make sure it passes the test url to the right application
2143         https://bugs.webkit.org/show_bug.cgi?id=167533
2144
2145         Reviewed by Joseph Pecoraro.
2146
2147         This fixes an issue when trying to run-benchmark script with the
2148         system default browser set to STP. Previously, it would run
2149         the test in STP rather than the provided build. Now, it should run
2150         in the provided build.
2151
2152         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2153         (OSXSafariDriver.launch_url):
2154
2155 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2156
2157         [Cocoa] Prepare ComplexTextController for unit testing
2158         https://bugs.webkit.org/show_bug.cgi?id=167493
2159
2160         Reviewed by Simon Fraser.
2161
2162         Addressing post-review comments from Simon Fraser.
2163
2164         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2165         (TestWebKitAPI::TEST_F):
2166
2167 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2168
2169         [Cocoa] Prepare ComplexTextController for unit testing
2170         https://bugs.webkit.org/show_bug.cgi?id=167493
2171
2172         Reviewed by Dean Jackson.
2173
2174         Create four unit tests.
2175
2176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2177         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
2178         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2179         (TestWebKitAPI::TEST_F):
2180
2181 2017-01-26  Chris Dumez  <cdumez@apple.com>
2182
2183         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2184         https://bugs.webkit.org/show_bug.cgi?id=167421
2185         <rdar://problem/30188490>
2186
2187         Reviewed by Darin Adler.
2188
2189         Add a new setting allowing layout tests to enable PageCache in a window
2190         that has an opener, for convenience.
2191
2192         * DumpRenderTree/mac/DumpRenderTree.mm:
2193         (resetWebPreferencesToConsistentValues):
2194         * DumpRenderTree/win/DumpRenderTree.cpp:
2195         (resetWebPreferencesToConsistentValues):
2196         * WebKitTestRunner/TestController.cpp:
2197         (WTR::TestController::resetPreferencesToConsistentValues):
2198
2199 2017-01-26  Keith Miller  <keith_miller@apple.com>
2200
2201         classInfo should take a VM so it is not materialized from the object on each call
2202         https://bugs.webkit.org/show_bug.cgi?id=167424
2203
2204         Rubber Stamped by Michael Saboff.
2205
2206         Previously, classInfo() would get the VM from the target's
2207         MarkedBlock.  Most callers already have a VM on hand, so it is
2208         wasteful to compute the VM from the marked block every time. This
2209         patch refactors some of the most common callers of classInfo(),
2210         jsDynamicCast and inherits to take a VM as well.
2211
2212         * DumpRenderTree/TestRunner.cpp:
2213         (setAudioResultCallback):
2214
2215 2017-01-26  Jer Noble  <jer.noble@apple.com>
2216
2217         Autoplay muted videos stop playback of any streaming app in the background
2218         https://bugs.webkit.org/show_bug.cgi?id=163993
2219         <rdar://problem/29020431>
2220
2221         Reviewed by Eric Carlson.
2222
2223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2224         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2225         (TestWebKitAPI::TEST):
2226         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
2227
2228 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
2229
2230         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
2231         https://bugs.webkit.org/show_bug.cgi?id=167466
2232
2233         Unreviewed test gardening.
2234
2235         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2236         (TEST):
2237
2238 2017-01-26  Matt Rajca  <mrajca@apple.com>
2239
2240         Notify clients when the user plays media otherwise prevented from autoplaying
2241         https://bugs.webkit.org/show_bug.cgi?id=167390
2242
2243         Reviewed by Alex Christensen.
2244
2245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2246         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2247         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2248         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2249         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2250         (TEST):
2251         * TestWebKitAPI/cocoa/TestWKWebView.h:
2252         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2253         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2254         (-[TestWKWebView waitForLoad]):
2255         (-[TestWKWebView mouseUpAtPoint:]):
2256         * WebKitTestRunner/TestController.cpp:
2257         (WTR::TestController::createOtherPage):
2258         (WTR::TestController::createWebViewWithOptions):
2259
2260 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2261
2262         Crash when setting custom scale factor.
2263         https://bugs.webkit.org/show_bug.cgi?id=167369
2264
2265         Reviewed by Sam Weinig.
2266
2267         Added API test.
2268
2269         * TestWebKitAPI/PlatformWin.cmake:
2270         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
2271         (TestWebKitAPI::WebKitCreateInstance):
2272         (TestWebKitAPI::ScaleWebView::SetUp):
2273         (TestWebKitAPI::ScaleWebView::TearDown):
2274         (TestWebKitAPI::TEST_F):
2275
2276 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2277
2278         run-benchmark nests MotionMark results by the suite name twice
2279         https://bugs.webkit.org/show_bug.cgi?id=164948
2280
2281         Reviewed by Said Abou-Hallawa.
2282
2283         Use a single level MotionMark now that this is the name of the benchmark,
2284         and we no longer have tests that aren't part of the MotionMark suite.
2285
2286         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
2287
2288 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2289
2290         Unreviewed, rolling out r211193.
2291
2292         This change broke internal builds.
2293
2294         Reverted changeset:
2295
2296         "Notify clients when the user plays media otherwise prevented
2297         from autoplaying"
2298         https://bugs.webkit.org/show_bug.cgi?id=167390
2299         http://trac.webkit.org/changeset/211193
2300
2301 2017-01-25  Matt Rajca  <mrajca@apple.com>
2302
2303         Notify clients when the user plays media otherwise prevented from autoplaying
2304         https://bugs.webkit.org/show_bug.cgi?id=167390
2305
2306         Reviewed by Alex Christensen.
2307
2308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2309         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2310         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2311         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2312         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2313         (TEST):
2314         * TestWebKitAPI/cocoa/TestWKWebView.h:
2315         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2316         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2317         (-[TestWKWebView waitForLoad]):
2318         (-[TestWKWebView mouseUpAtPoint:]):
2319         * WebKitTestRunner/TestController.cpp:
2320         (WTR::TestController::createOtherPage):
2321         (WTR::TestController::createWebViewWithOptions):
2322
2323 2017-01-25  Matt Rajca  <mrajca@apple.com>
2324
2325         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
2326         https://bugs.webkit.org/show_bug.cgi?id=167385
2327
2328         Reviewed by Alex Christensen.
2329
2330         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
2331         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
2332         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2333         (TEST): Allow inline (rather than full screen) media playback on iOS.
2334
2335 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2336
2337         [GTK] Icon Database should be in private browsing mode for ephemeral web views
2338         https://bugs.webkit.org/show_bug.cgi?id=167414
2339
2340         Reviewed by Michael Catanzaro.
2341
2342         Add a test case to check ephemeral web views don't write favicons to the database.
2343
2344         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2345         (ephemeralViewLoadChanged):
2346         (testPrivateBrowsing):
2347         (testFaviconDatabase):
2348
2349 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2350
2351         [GTK] Add a private browsing mode to MiniBrowser
2352         https://bugs.webkit.org/show_bug.cgi?id=167413
2353
2354         Reviewed by Michael Catanzaro.
2355
2356         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
2357         private windows, even on non-private instances.
2358
2359         * MiniBrowser/gtk/BrowserWindow.c:
2360         (webViewTitleChanged): Add [Private] to title window for private windows.
2361         (webViewCreate): Pass web context to browser_window_new.
2362         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
2363         (browserWindowFinalize): Disconnect web context signal handlers.
2364         (browser_window_init): Add shortcut for opening private window.
2365         (browser_window_new): It now receives the context and connect to download-started here.
2366         (browser_window_get_web_context): Return the context.
2367         * MiniBrowser/gtk/BrowserWindow.h:
2368         * MiniBrowser/gtk/main.c:
2369         (createBrowserTab): Create the web view for the window web context.
2370         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
2371         (aboutDataHandleRequest): Ditto.
2372         (aboutURISchemeRequestCallback): Ditto.
2373         (main): Create ephemeral web context if private command line option is used.
2374
2375 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2376
2377         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
2378         https://bugs.webkit.org/show_bug.cgi?id=167409
2379
2380         Reviewed by Antti Koivisto.
2381
2382         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
2383         as well as tests for the newly added matchingElementInFlatTree.
2384
2385         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
2386         (TestWebKitAPI::runJavaScriptAlert):
2387         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2388         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2389         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
2390
2391 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2392
2393         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
2394         https://bugs.webkit.org/show_bug.cgi?id=167370
2395
2396         Reviewed by Michael Catanzaro.
2397
2398         Add several test cases of ephemeral web views.
2399
2400         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2401         (testWebViewAuthenticationStorage):
2402         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2403         (ephemeralViewloadChanged):
2404         (testCookieManagerEphemeral):
2405         (beforeAll):
2406         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2407         (testWebKitSettings):
2408         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2409         (testWebContextEphemeral):
2410         (ephemeralViewloadChanged):
2411         (testWebContextProxySettings):
2412         (beforeAll):
2413         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2414         (ephemeralViewloadChanged):
2415         (testWebViewEphemeral):
2416         (beforeAll):
2417         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
2418         (ephemeralViewloadChanged):
2419         (testWebsiteDataEphemeral):
2420         (beforeAll):
2421
2422 2017-01-24  Alex Christensen  <achristensen@webkit.org>
2423
2424         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
2425         https://bugs.webkit.org/show_bug.cgi?id=167402
2426
2427         Reviewed by Ryosuke Niwa.
2428
2429         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2430         (TestWebKitAPI::TEST):
2431
2432 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2433
2434         Add simple line layout toggle to MiniBrowser
2435         https://bugs.webkit.org/show_bug.cgi?id=167405
2436
2437         Reviewed by Andreas Kling.
2438
2439         * MiniBrowser/mac/SettingsController.h:
2440         * MiniBrowser/mac/SettingsController.m:
2441         (-[SettingsController _populateMenu]):
2442         (-[SettingsController validateMenuItem:]):
2443         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
2444         (-[SettingsController simpleLineLayoutEnabled]):
2445         * MiniBrowser/mac/WK1BrowserWindowController.m:
2446         (-[WK1BrowserWindowController didChangeSettings]):
2447         * MiniBrowser/mac/WK2BrowserWindowController.m:
2448         (-[WK2BrowserWindowController didChangeSettings]):
2449
2450 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2451
2452         WKR does not include my nick when commit-queue lands my patch
2453         https://bugs.webkit.org/show_bug.cgi?id=167388
2454
2455         Reviewed by Ryosuke Niwa.
2456
2457         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2458         (NewCommitBot._summarize_commit_log):
2459         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2460         Perform nickname insertion before grabbing "Patch by" details.
2461         This way we can include the nickname with the full name.
2462
2463 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2464
2465         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2466         https://bugs.webkit.org/show_bug.cgi?id=167394
2467
2468         Reviewed by Ryosuke Niwa.
2469
2470         * Scripts/webkitperl/FeatureList.pm:
2471         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2472
2473 2017-01-24  Youenn Fablet  <youenn@apple.com>
2474
2475         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
2476         https://bugs.webkit.org/show_bug.cgi?id=167353
2477
2478         Reviewed by Alex Christensen.
2479
2480         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2481         (CMakeGenerator.initialize_targets):
2482
2483 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2484
2485         WKR should not confuse Miguel Gomez with Andres Gomez
2486         https://bugs.webkit.org/show_bug.cgi?id=167389
2487
2488         Reviewed by Lucas Forschler.
2489
2490         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
2491         "mAndres Gomez". Fix this.
2492
2493         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2494         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
2495         space on each side of the email address, so expect both spaces to be there before
2496         considering the email for replacement.
2497         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
2498
2499 2017-01-24  Matt Rajca  <mrajca@apple.com>
2500
2501         Pass down website autoplay policies to media elements
2502         https://bugs.webkit.org/show_bug.cgi?id=167355
2503
2504         Reviewed by Alex Christensen.
2505
2506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2507         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
2508         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
2509         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
2510         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2511         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2512         (TEST):
2513
2514 2017-01-24  Nan Wang  <n_wang@apple.com>
2515
2516         AX: Speak Selection does not work in an iframe
2517         https://bugs.webkit.org/show_bug.cgi?id=166794
2518         <rdar://problem/29913013>
2519
2520         Reviewed by Chris Fleizach.
2521
2522         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2523         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2524         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2525         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2526         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2527         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2528         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2529         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2530         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2531         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2532         (-[TestRunnerWKWebView dealloc]):
2533         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
2534         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
2535         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2536         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2537         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2538
2539 2017-01-24  Daniel Bates  <dabates@apple.com>
2540
2541         StringView.split() should use an iterator design pattern instead of allocating a Vector
2542         https://bugs.webkit.org/show_bug.cgi?id=163225
2543
2544         Reviewed by Darin Adler.
2545
2546         Add unit tests for StringView.split().
2547
2548         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2549         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
2550         used in the StringView.split() unit tests.
2551         (TestWebKitAPI::stringViewFromUTF8): Ditto.
2552         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
2553         object to a Vector of String objects.
2554         (TestWebKitAPI::TEST): Added the following tests:
2555             - WTF.StringViewSplitEmptyAndNullStrings
2556             - WTF.StringViewSplitBasic
2557             - WTF.StringViewSplitWithConsecutiveSeparators
2558
2559 2017-01-23  Anders Carlsson  <andersca@apple.com>
2560
2561         The Score Esports crashes on launch
2562         https://bugs.webkit.org/show_bug.cgi?id=167338
2563         rdar://problem/29948645
2564
2565         Reviewed by Dan Bernstein.
2566
2567         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2568         (TestWebKitAPI::TEST):
2569         Add a test.
2570
2571 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2572
2573         [GTK] Add API to WebKitWebsiteDataManager to handle website data
2574         https://bugs.webkit.org/show_bug.cgi?id=146589
2575
2576         Reviewed by Michael Catanzaro.
2577
2578         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
2579         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
2580
2581         * MiniBrowser/gtk/BrowserWindow.c:
2582         (webViewDecidePolicy):
2583         (newTabCallback):
2584         * MiniBrowser/gtk/main.c:
2585         (createBrowserTab):
2586         (aboutDataRequestFree):
2587         (aboutDataRequestNew):
2588         (aboutDataRequestForView):
2589         (websiteDataRemovedCallback):
2590         (websiteDataClearedCallback):
2591         (aboutDataScriptMessageReceivedCallback):
2592         (domainListFree):
2593         (aboutDataFillTable):
2594         (gotWebsiteDataCallback):
2595         (aboutDataHandleRequest):
2596         (aboutURISchemeRequestCallback):
2597         (main):
2598         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2599         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2600         (serverCallback):
2601         (beforeAll):
2602         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2603         (serverCallback):
2604         (WebsiteDataTest::WebsiteDataTest):
2605         (WebsiteDataTest::~WebsiteDataTest):
2606         (WebsiteDataTest::fetch):
2607         (WebsiteDataTest::remove):
2608         (WebsiteDataTest::clear):
2609         (testWebsiteDataConfiguration):
2610         (testWebsiteDataCache):
2611         (testWebsiteDataStorage):
2612         (testWebsiteDataDatabases):
2613         (testWebsiteDataAppcache):
2614         (beforeAll):
2615         (afterAll):
2616
2617 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2618
2619         Unreviewed, rolling out r211062.
2620         https://bugs.webkit.org/show_bug.cgi?id=167354
2621
2622         broke API tests (Requested by alexchristensen on #webkit).
2623
2624         Reverted changeset:
2625
2626         "Pass down website autoplay policies to media elements"
2627         https://bugs.webkit.org/show_bug.cgi?id=167132
2628         http://trac.webkit.org/changeset/211062
2629
2630 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2631
2632         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2633         https://bugs.webkit.org/show_bug.cgi?id=167330
2634
2635         Reviewed by Tim Horton.
2636
2637         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2638         (TestWebKitAPI::TEST_F):
2639
2640 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2641
2642         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2643         https://bugs.webkit.org/show_bug.cgi?id=167317
2644
2645         Reviewed by Sam Weinig.
2646
2647         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2648         (TestWebKitAPI::TEST_F):
2649
2650 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2651
2652         svn-create-patch should emit properties when files are moved or copied
2653         https://bugs.webkit.org/show_bug.cgi?id=167264
2654
2655         Reviewed by Daniel Bates.
2656
2657         * Scripts/svn-create-patch:
2658         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2659
2660 2017-01-23  Youenn Fablet  <youenn@apple.com>
2661
2662         [WebRTC] Filter libwebrtc link flags
2663         https://bugs.webkit.org/show_bug.cgi?id=167287
2664
2665         Reviewed by Alex Christensen.
2666
2667         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2668         (CMakeGenerator._compute_link_flags):
2669         (CMakeGenerator._compute_link_flags.keep_flag):
2670         (CMakeGenerator._generate_compile_target_options):
2671
2672 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2673
2674         [WebRTC] Make VP8 optional in libwebrtc
2675         https://bugs.webkit.org/show_bug.cgi?id=167257
2676
2677         Reviewed by Darin Adler.
2678
2679         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2680         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
2681
2682 2017-01-23  Jer Noble  <jer.noble@apple.com>
2683
2684         Video details does not apear and missing scrubber in Control Center
2685         https://bugs.webkit.org/show_bug.cgi?id=167233
2686
2687         Reviewed by Alex Christensen.
2688
2689         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
2690         NowPlayingControlTests for iOS.
2691
2692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2693         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2694         (-[NowPlayingTestWebView setWindowVisible:]):
2695         (TestWebKitAPI::TEST):
2696         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2697         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2698         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2699         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
2700         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
2701         (SOFT_LINK_CLASS):
2702         (-[TestMessageHandler addMessage:withHandler:]):
2703         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
2704         (__simulated_forceClickAssociatedEventsMask):
2705         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
2706         (-[TestWKWebViewHostWindow isKeyWindow]):
2707         (-[TestWKWebViewHostWindow makeKeyWindow]):
2708         (-[TestWKWebViewHostWindow resignKeyWindow]):
2709         (-[TestWKWebView initWithFrame:]):
2710         (-[TestWKWebView initWithFrame:configuration:]):
2711         (-[TestWKWebView _setUpTestWindow:]):
2712         (-[TestWKWebView performAfterReceivingMessage:action:]):
2713         (-[TestWKWebView loadTestPageNamed:]):
2714         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2715         (-[TestWKWebView stringByEvaluatingJavaScript:]):
2716         (-[TestWKWebView waitForMessage:]):
2717         (-[TestWKWebView performAfterLoading:]):
2718         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
2719         (-[TestWKWebView typeCharacter:]):
2720
2721 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2722
2723         Unreviewed. Bring back gtk-doc error messages after r209981.
2724
2725         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
2726         impossible to know what's wrong.
2727
2728         * gtk/gtkdoc.py:
2729         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
2730
2731 2017-01-20  Youenn Fablet  <youennf@gmail.com>
2732
2733         [WebRTC] Update build system to make G711 optional in libwebrtc
2734         https://bugs.webkit.org/show_bug.cgi?id=167256
2735
2736         Reviewed by Alex Christensen.
2737
2738         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2739         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
2740
2741 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2742
2743         Cleanup RuntimeEnabledFeatures
2744         https://bugs.webkit.org/show_bug.cgi?id=167228
2745
2746         Reviewed by Simon Fraser.
2747
2748         * DumpRenderTree/mac/DumpRenderTree.mm:
2749         (enableExperimentalFeatures):
2750         (resetWebPreferencesToConsistentValues):
2751         (setWebPreferencesForTestOptions):
2752         (resetWebViewToConsistentStateBeforeTesting):
2753         * DumpRenderTree/win/DumpRenderTree.cpp:
2754         (enableExperimentalFeatures):
2755         (resetWebPreferencesToConsistentValues):
2756         More closely match WebKitTestRunner initialization of preferences
2757         for experimental features.
2758
2759 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2760
2761         Build Fix for Windows DumpRenderTree after r210976
2762         https://bugs.webkit.org/show_bug.cgi?id=167115
2763
2764         * DumpRenderTree/win/DumpRenderTree.cpp:
2765         (resetWebPreferencesToConsistentValues):
2766
2767 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2768
2769         Remove outdated ENABLE(CSP_NEXT) build flag
2770         https://bugs.webkit.org/show_bug.cgi?id=167252
2771
2772         Reviewed by Brent Fulgham.
2773
2774         * Scripts/webkitperl/FeatureList.pm:
2775         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2776
2777 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2778
2779         Build Fix for Windows DumpRenderTree after r210976
2780
2781         * DumpRenderTree/win/DumpRenderTree.cpp:
2782         (resetWebPreferencesToConsistentValues):
2783
2784 2017-01-20  Antoine Quint  <graouts@apple.com>
2785
2786         Web Animations should be off by default and enabled as an experimental feature
2787         https://bugs.webkit.org/show_bug.cgi?id=167115
2788         <rdar://problem/30048963>
2789
2790         Reviewed by Joseph Pecoraro.
2791
2792         Turn Web Animations on in DRT.
2793
2794         * DumpRenderTree/mac/DumpRenderTree.mm:
2795         (resetWebPreferencesToConsistentValues):
2796         * DumpRenderTree/win/DumpRenderTree.cpp:
2797         (resetWebPreferencesToConsistentValues):
2798
2799 2017-01-20  Youenn Fablet  <youenn@apple.com>
2800
2801         [WebRTC] Add libwebrtc build infrastructure
2802         https://bugs.webkit.org/show_bug.cgi?id=167207
2803
2804         Reviewed by Alex Christensen.
2805
2806         Adding a script doing the libwebrtc project json to CMake file conversion.
2807
2808         * Scripts/generate-libwebrtc-cmake: Added.
2809         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
2810         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
2811
2812 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2813
2814         Mini Browser: Show tooltip for Experimental Features
2815         https://bugs.webkit.org/show_bug.cgi?id=167225
2816
2817         Reviewed by Alex Christensen.
2818
2819         * MiniBrowser/mac/SettingsController.m:
2820         (-[SettingsController _populateMenu]):
2821         Include the full details string as a tooltip.
2822
2823 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
2824
2825         [Win] Test output results should not be written twice.
2826         https://bugs.webkit.org/show_bug.cgi?id=167197
2827
2828         Reviewed by Brent Fulgham.
2829
2830         Prevent test output from being written twice by returning early from
2831         the dump() function, if it already has been called.
2832         This patch also adds a missing newline to a test output line. 
2833         
2834         * DumpRenderTree/win/DumpRenderTree.cpp:
2835         (dump):
2836
2837 2017-01-20  Antoine Quint  <graouts@apple.com>
2838
2839         [Modern Media Controls] Turn modern media controls on by default
2840         https://bugs.webkit.org/show_bug.cgi?id=165668
2841
2842         Reviewed by Dean Jackson.
2843
2844         Enabled modern media controls by default in test runners.
2845
2846         * DumpRenderTree/TestOptions.h:
2847         * WebKitTestRunner/TestOptions.h:
2848
2849 2017-01-19  Chris Dumez  <cdumez@apple.com>
2850
2851         iterable<> should be enabled on WK1
2852         https://bugs.webkit.org/show_bug.cgi?id=167221
2853         <rdar://problem/30108531>
2854
2855         Reviewed by Youenn Fablet.
2856
2857         * DumpRenderTree/mac/DumpRenderTree.mm:
2858         (resetWebPreferencesToConsistentValues):
2859         * DumpRenderTree/win/DumpRenderTree.cpp:
2860         (resetWebPreferencesToConsistentValues):
2861         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2862         (WTR::InjectedBundle::beginTesting):
2863         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2864         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
2865         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2866
2867 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
2868
2869         Ensure status server logs go to log file
2870         https://bugs.webkit.org/show_bug.cgi?id=167210
2871
2872         Reviewed by Alexey Proskuryakov.
2873
2874         * Scripts/webkitpy/common/net/statusserver.py:
2875         (StatusServer.next_work_item): Change log level from debug to info in
2876         order to facilitate deubgging issues.
2877         (StatusServer.update_work_items): Same.
2878
2879 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
2880
2881         Additional selection tests and interpolation fix
2882         https://bugs.webkit.org/show_bug.cgi?id=167171
2883
2884         Reviewed by Simon Fraser.
2885
2886         We weren't adding the final event when interpolating event streams.
2887
2888         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2889         (-[HIDEventGenerator interpolatedEvents:]):
2890
2891 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
2892
2893         [Cocoa] Variation fonts are erroneously disabled on iOS
2894         https://bugs.webkit.org/show_bug.cgi?id=167172
2895
2896         Reviewed by Simon Fraser.
2897
2898         OpenSource builders don't seem to understand sdk=embedded*.
2899
2900         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2901
2902 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2903
2904         Unreviewed. Fix GTK+ unit tests failing since r210531.
2905
2906         Avoid using paths to files that don't actually exist.
2907
2908         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2909         (testWebKitConsoleMessageNetworkError):
2910         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2911         (testContextMenuDefaultMenu):
2912         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
2913         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
2914         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
2915
2916 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2917
2918         [GTK] Provide API to set proxy settings
2919         https://bugs.webkit.org/show_bug.cgi?id=128674
2920
2921         Reviewed by Michael Catanzaro.
2922
2923         Add tests for new proxy settings API.
2924
2925         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2926         (serverCallback):
2927         (ProxyTest::ProxyTest):
2928         (ProxyTest::~ProxyTest):
2929         (ProxyTest::loadURIAndGetMainResourceData):
2930         (ProxyTest::proxyServerPortAsString):
2931         (testWebContextProxySettings):
2932         (beforeAll):
2933
2934 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2935
2936         Add back my old email address so old commits will still match it.
2937
2938         * Scripts/webkitpy/common/config/contributors.json:
2939
2940 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
2941
2942         Remove my old email address from contributors.json and watchlist.
2943
2944         * Scripts/validate-committer-lists:
2945         (CommitterListFromGit): Change the mapping to the correct email.
2946         * Scripts/webkitpy/common/config/contributors.json:
2947         * Scripts/webkitpy/common/config/watchlist:
2948
2949 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2950
2951         Unreviewed, rolling out r210848.
2952
2953         This change introduced media-related LayoutTest failures and
2954         crashes on macOS.
2955
2956         Reverted changeset:
2957
2958         "[Modern Media Controls] Turn modern media controls on by
2959         default"
2960         https://bugs.webkit.org/show_bug.cgi?id=165668
2961         http://trac.webkit.org/changeset/210848
2962
2963 2017-01-18  Andreas Kling  <akling@apple.com>
2964
2965         Document::securityOrigin() should return a reference.
2966         <https://webkit.org/b/167124>
2967
2968         Reviewed by Sam Weinig.
2969
2970         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2971         (TestWebKitAPI::TEST_F):
2972
2973 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
2974
2975         [Win] Clipboard tests are flaky.
2976         https://bugs.webkit.org/show_bug.cgi?id=167088
2977
2978         Reviewed by Brent Fulgham.
2979
2980         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
2981         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
2982
2983         * DumpRenderTree/win/DumpRenderTree.cpp:
2984         (main):
2985
2986 2017-01-18  Antoine Quint  <graouts@apple.com>
2987
2988         [Modern Media Controls] Turn modern media controls on by default
2989         https://bugs.webkit.org/show_bug.cgi?id=165668
2990
2991         Reviewed by Dean Jackson.
2992
2993         Enabled modern media controls by default in test runners. 
2994
2995         * DumpRenderTree/TestOptions.h:
2996         * WebKitTestRunner/TestOptions.h:
2997
2998 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2999
3000         Unreviewed, rolling out r210834
3001         https://bugs.webkit.org/show_bug.cgi?id=165668
3002
3003         It introduced dozens of test timeouts.
3004
3005         Reverted changeset:
3006         "[Modern Media Controls] Turn modern media controls on by default"
3007         https://bugs.webkit.org/show_bug.cgi?id=165668
3008         http://trac.webkit.org/changeset/210834
3009
3010 2017-01-17  Antoine Quint  <graouts@apple.com>
3011
3012         [Modern Media Controls] Turn modern media controls on by default
3013         https://bugs.webkit.org/show_bug.cgi?id=165668
3014
3015         Reviewed by Dean Jackson.
3016
3017         Enabled modern media controls by default in test runners. 
3018
3019         * DumpRenderTree/TestOptions.h:
3020         * WebKitTestRunner/TestOptions.h:
3021
3022 2017-01-17  Chris Dumez  <cdumez@apple.com>
3023
3024         Document title changed twice when setting document.title
3025         https://bugs.webkit.org/show_bug.cgi?id=167065
3026
3027         Reviewed by Darin Adler.
3028
3029         Add WebKit2GTK API test that was written by Michael Catanzaro.
3030
3031         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3032         (testWebViewTitleChange):
3033         (beforeAll):
3034
3035 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
3036
3037         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
3038         https://bugs.webkit.org/show_bug.cgi?id=116551
3039         <rdar://problem/13949830>
3040
3041         Reviewed by Alex Christensen.
3042
3043         * Scripts/webkitperl/FeatureList.pm:
3044         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
3045         that is part of the existing WEB_TIMING feature.
3046
3047         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3048
3049 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
3050
3051         'webkit-patch post' no longer works with moved/copied files
3052         https://bugs.webkit.org/show_bug.cgi?id=166914
3053         <rdar://problem/29979707>
3054
3055         Reviewed by Daniel Bates.
3056
3057         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
3058         file outputs only the "Index:" line with an empty body.  This workaround
3059         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
3060         public email list tracking this bug is below.
3061         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
3062         
3063
3064         * Scripts/svn-create-patch:
3065         (generateDiff): Ignore an "Index:" line with an empty body.
3066
3067 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
3068
3069         Remove the REQUEST_ANIMATION_FRAME flag
3070         https://bugs.webkit.org/show_bug.cgi?id=156980
3071         <rdar://problem/25906849>
3072
3073         Reviewed by Simon Fraser.
3074
3075         * Scripts/webkitperl/FeatureList.pm:
3076         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3077
3078 2017-01-15  Sam Weinig  <sam@webkit.org>
3079
3080         Add the ability to use numbers in makeString()
3081         https://bugs.webkit.org/show_bug.cgi?id=167087
3082
3083         Reviewed by Darin Adler.
3084
3085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3086         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
3087         Add tests for StringConcatenate, focusing on new numeric additions.
3088
3089 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3090
3091         Unreviewed, remove stale comment.
3092
3093         This test was fixed by r163173.
3094
3095         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3096
3097 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3098
3099         Annotate large string tests with largeHeap
3100         https://bugs.webkit.org/show_bug.cgi?id=167054
3101
3102         Reviewed by Filip Pizlo.
3103
3104         * Scripts/run-javascriptcore-tests:
3105         * Scripts/run-jsc-stress-tests:
3106
3107 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
3108
3109         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
3110         https://bugs.webkit.org/show_bug.cgi?id=167043
3111
3112         Reviewed by Darin Adler.
3113
3114         * Scripts/webkitperl/FeatureList.pm:
3115
3116 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
3117
3118         Remove ENABLE(DETAILS_ELEMENT) guards
3119         https://bugs.webkit.org/show_bug.cgi?id=167042
3120
3121         Reviewed by Alex Christensen.
3122
3123         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3124
3125 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
3126
3127         26 MotionMark performance tests failing
3128         https://bugs.webkit.org/show_bug.cgi?id=166854
3129
3130         Reviewed by Ryosuke Niwa.
3131
3132         Unrelated change. This is the last place that we need to rename Animometer
3133         to MotionMark.
3134
3135         * Scripts/webkitpy/common/config/watchlist:
3136
3137 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
3138
3139         run-jsc-benchmarks' echo should have -e option
3140         https://bugs.webkit.org/show_bug.cgi?id=167009
3141
3142         Reviewed by Sam Weinig.
3143
3144         echo requires `-e` option to use escape sequence.
3145         Without it, in some environment (in my Fedora 25), the escape sequence is not
3146         recognized and just dumped as `\c` etc.
3147
3148         * Scripts/run-jsc-benchmarks:
3149
3150 2017-01-12  Chris Dumez  <cdumez@apple.com>
3151
3152         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3153         https://bugs.webkit.org/show_bug.cgi?id=166995
3154
3155         Reviewed by Jer Noble.
3156
3157         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3158         as some people are having trouble building without it.
3159
3160         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3161
3162 2017-01-12  Sam Weinig  <sam@webkit.org>
3163
3164         Add the ability to filter the set of bindings tests you want to run
3165         https://bugs.webkit.org/show_bug.cgi?id=166977
3166
3167         Reviewed by Tim Horton.
3168
3169         Allows doing things like:
3170             run-bindings-tests TestObj* TestCEReactions*
3171         
3172         to run only those tests that match the patterns.
3173
3174         * Scripts/run-bindings-tests:
3175         (main):
3176         Switch to using optparse and pass the remaining args as the filters.
3177
3178         * Scripts/webkitpy/bindings/main.py:
3179         (BindingsTests.__init__):
3180         Store the pattens.
3181
3182         (BindingsTests.test_matches_patterns):
3183         Add helper predicate to determine if a test should be run. When no
3184         patterns are present, all tests should run.
3185
3186         (BindingsTests.run_tests):
3187         Filter tests using the passed in patterns.
3188
3189 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
3190
3191         Followup fix after r210503.
3192         https://bugs.webkit.org/show_bug.cgi?id=166887
3193
3194         Reviewed by Alex Christensen.
3195
3196         After <http://trac.webkit.org/changeset/210503>, test results are written to a
3197         duplicated file handle on Windows. This patch fixes the remaining call sites.
3198
3199         * DumpRenderTree/PixelDumpSupport.cpp:
3200         * DumpRenderTree/TestRunner.cpp:
3201         (TestRunner::waitToDumpWatchdogTimerFired):
3202         * DumpRenderTree/TestRunner.h:
3203         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3204         * DumpRenderTree/win/DumpRenderTree.cpp:
3205         * DumpRenderTree/win/DumpRenderTreeWin.h:
3206         * DumpRenderTree/win/TestRunnerWin.cpp:
3207         (TestRunner::setSpellCheckerLoggingEnabled):
3208
3209 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
3210
3211         Add committer status for Megan
3212         https://bugs.webkit.org/show_bug.cgi?id=166954
3213
3214         Reviewed by Tim Horton.
3215
3216         Add committer status for Megan Gardner
3217
3218         * Scripts/webkitpy/common/config/contributors.json:
3219
3220 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3221
3222         Unreviewed test fix after r210599.
3223
3224         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3225         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
3226
3227 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3228
3229         Unreviewed build fix after r210599.
3230
3231         Add missing files.
3232
3233         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3234         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3235
3236 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3237
3238         File scheme should not allow access of a resource on a different volume.
3239         https://bugs.webkit.org/show_bug.cgi?id=158552
3240         <rdar://problem/15307582>
3241
3242         Reviewed by Alex Christensen.
3243
3244         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3245         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3246         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3247
3248 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
3249
3250         Unreviewed, rolling out r210571.
3251
3252         This change broke the 32-bit macOS build and caused LayoutTest
3253         failures.
3254
3255         Reverted changeset:
3256
3257         "File scheme should not allow access of a resource on a
3258         different volume."
3259         https://bugs.webkit.org/show_bug.cgi?id=158552
3260         http://trac.webkit.org/changeset/210571
3261
3262 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3263
3264         [GTK] install-dependencies script misses gdb
3265         https://bugs.webkit.org/show_bug.cgi?id=166917
3266
3267         Reviewed by Michael Catanzaro.
3268
3269         gdb is needed for generating the crash logs.
3270
3271         * gtk/install-dependencies:
3272
3273 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3274
3275         [GTK] No way for applications to set notification permissions without waiting for permission request
3276         https://bugs.webkit.org/show_bug.cgi?id=163366
3277
3278         Reviewed by Carlos Garcia Campos.
3279
3280         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3281         (testWebViewNotification):
3282         (setInitialNotificationPermissionsAllowedCallback):
3283         (setInitialNotificationPermissionsDisallowedCallback):
3284         (testWebViewNotificationInitialPermissionAllowed):
3285         (testWebViewNotificationInitialPermissionDisallowed):
3286         (beforeAll):
3287         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3288         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3289         (WebViewTest::WebViewTest):
3290         (WebViewTest::initializeWebView):
3291         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3292
3293 2017-01-10  Tim Horton  <timothy_horton@apple.com>
3294
3295         MobileMiniBrowser tests don't work by default
3296         https://bugs.webkit.org/show_bug.cgi?id=166910
3297
3298         Reviewed by Alex Christensen.
3299
3300         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
3301         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
3302
3303 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
3304
3305         File scheme should not allow access of a resource on a different volume.
3306         https://bugs.webkit.org/show_bug.cgi?id=158552
3307         <rdar://problem/15307582>
3308
3309         Reviewed by Alex Christensen.
3310
3311         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3312         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3313         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3314
3315 2017-01-10  Mark Lam  <mark.lam@apple.com>
3316
3317         Reverting run-jsc-stress-tests' $buildType to use string values.
3318         https://bugs.webkit.org/show_bug.cgi?id=166912
3319
3320         Rubber stamped by Filip Pizlo.
3321
3322         This is so that we can test for it in the tests e.g.
3323         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
3324
3325         * Scripts/run-jsc-stress-tests:
3326
3327 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3328
3329         Temporarily add back the file removed in r210463 to unbreak internal bots.
3330
3331         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3332
3333 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
3334
3335         svn-apply failed to apply a patch (deleting file with svn property)
3336         https://bugs.webkit.org/show_bug.cgi?id=165953
3337
3338         Reviewed by Daniel Bates.
3339
3340         * Scripts/VCSUtils.pm:
3341         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
3342         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
3343
3344 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3345
3346         Update flakiness dashboard configuration.
3347         https://bugs.webkit.org/show_bug.cgi?id=166869
3348
3349         Reviewed by Alexey Proskuryakov.
3350
3351         * TestResultServer/static-dashboards/builders.jsonp:
3352         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3353
3354 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3355
3356         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
3357         https://bugs.webkit.org/show_bug.cgi?id=165232
3358
3359         Unreviewed follow-up patch after r210539 and r210523.
3360
3361         Instead of using that environment variable, the argument
3362         --display-server=xorg should be passed now.
3363
3364         The GTK+ performance bot was the only bot using this, and is
3365         already passing --display-server=xorg after r210539.
3366
3367         * Scripts/webkitpy/port/gtk.py:
3368         (GtkPort._driver_class):
3369
3370 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3371
3372         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
3373         https://bugs.webkit.org/show_bug.cgi?id=166872
3374
3375         Reviewed by Michael Catanzaro.
3376
3377         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
3378         Define the required "--display-server=driver" in the bot additionalArguments config entry.
3379         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
3380         The step RunWebKitTests already has support for it.
3381
3382         * BuildSlaveSupport/build.webkit.org-config/config.json:
3383         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3384         (RunGtkAPITests.start):
3385         (RunAndUploadPerfTests.start):
3386         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3387
3388 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
3389
3390         Unreviewed, rolling out r210531.
3391
3392         This change broke the 32-bit macOS build and caused LayoutTest
3393         failures.
3394
3395         Reverted changeset:
3396
3397         "File scheme should not allow access of a resource on a
3398         different volume."
3399         https://bugs.webkit.org/show_bug.cgi?id=158552
3400         http://trac.webkit.org/changeset/210531
3401
3402 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
3403
3404         File scheme should not allow access of a resource on a different volume.
3405         https://bugs.webkit.org/show_bug.cgi?id=158552
3406         <rdar://problem/15307582>
3407
3408         Reviewed by Alex Christensen.
3409
3410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3411         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3412         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3413
3414 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3415
3416         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
3417         https://bugs.webkit.org/show_bug.cgi?id=165232
3418
3419         Reviewed by Michael Catanzaro.
3420
3421         Add a new WaylandDriver to run the tests in the user current wayland session.
3422
3423         Also merge all the configuration options for selecting the display server inside one
3424         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
3425
3426         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
3427
3428         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
3429         (TestRunner._create_driver):
3430         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3431         (parse_args):
3432         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3433         (PerfTestsRunner._parse_args):
3434         * Scripts/webkitpy/port/gtk.py:
3435         (GtkPort.__init__):
3436         (GtkPort._driver_class):
3437         (GtkPort._search_paths):
3438         * Scripts/webkitpy/port/waylanddriver.py: Added.
3439         (WaylandDriver):
3440         (WaylandDriver.check_driver):
3441         (WaylandDriver._setup_environ_for_test):
3442         (WaylandDriver._start):
3443
3444 2017-01-09  Andy Estes  <aestes@apple.com>
3445
3446         [QuickLook] Add a layout test for webkit.org/b/135651
3447         https://bugs.webkit.org/show_bug.cgi?id=166855
3448
3449         Reviewed by Andreas Kling.
3450
3451         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3452         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
3453         errors with code WebKitErrorCannotShowURL.
3454         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3455         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
3456         not specific to WebKit2 error codes.
3457
3458 2017-01-09  Antoine Quint  <graouts@apple.com>
3459
3460         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
3461         https://bugs.webkit.org/show_bug.cgi?id=166837
3462
3463         Reviewed by Alex Christensen.
3464
3465         We now correctly handle the --absolutePath argument in DumpRenderTree and use
3466         the provided value when trying to determine the path to the test file. Failing
3467         that, we use the computed URL or the raw path provided to cover all cases.
3468         
3469         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
3470         by applying this patch and seeing the number test failures dramatically reduced
3471         with WK1 due to the option to turn modern media controls off for older media controls
3472         tests.
3473
3474         * DumpRenderTree/DumpRenderTree.h:
3475         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3476         (parseInputLine):
3477         * DumpRenderTree/TestOptions.h:
3478         * DumpRenderTree/TestOptions.mm:
3479         (TestOptions::TestOptions):
3480         * DumpRenderTree/mac/DumpRenderTree.mm:
3481         (runTest):
3482
3483 2017-01-09  Milan Crha  <mcrha@redhat.com>
3484
3485         prepare-ChangeLog: Correct help string for --style option
3486         https://bugs.webkit.org/show_bug.cgi?id=166725
3487
3488         Reviewed by Alexey Proskuryakov.
3489
3490         * Scripts/prepare-ChangeLog:
3491         (main):
3492
3493 2017-01-09  Lucas Forschler  <lforschler@apple.com>
3494
3495         https://bugs.webkit.org/show_bug.cgi?id=166839
3496         Add php7 support for macOS.
3497         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
3498
3499         Reviewed by Alexey Proskuryakov.
3500
3501         * Scripts/webkitpy/port/base.py:
3502         (Port._is_darwin_php_version_7):
3503         (Port._debian_php_version):
3504         (Port):
3505         (Port._darwin_php_version):
3506         (Port._apache_config_file_name_for_platform):
3507
3508 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3509
3510         [GTK] Should support key and code properties on keyboard events
3511         https://bugs.webkit.org/show_bug.cgi?id=166759
3512
3513         Reviewed by Carlos Garcia Campos.
3514
3515         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3516         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
3517         on tests.
3518
3519 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
3520
3521         [Win] Some tests are flaky because certain DLLs are writing to stdout.
3522         https://bugs.webkit.org/show_bug.cgi?id=166760
3523
3524         Reviewed by Darin Adler.
3525
3526         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
3527         We can work around that by duplicating and redirecting stdout.
3528
3529         * DumpRenderTree/PixelDumpSupport.cpp:
3530         (dumpWebViewAsPixelsAndCompareWithExpected):
3531         (printPNG):
3532         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3533         (logEventProc):
3534         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3535         (DRTDesktopNotificationPresenter::showDesktopNotification):
3536         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
3537         (DRTDesktopNotificationPresenter::requestNotificationPermission):
3538         * DumpRenderTree/win/DumpRenderTree.cpp:
3539         (dumpFrameScrollPosition):
3540         (dumpHistoryItem):
3541         (dumpBackForwardList):
3542         (dump):
3543         (runTest):
3544         (main):
3545         * DumpRenderTree/win/DumpRenderTreeWin.h:
3546         * DumpRenderTree/win/EditingDelegate.cpp:
3547         (EditingDelegate::shouldBeginEditingInDOMRange):
3548         (EditingDelegate::shouldEndEditingInDOMRange):
3549         (EditingDelegate::shouldInsertNode):
3550         (EditingDelegate::shouldInsertText):
3551         (EditingDelegate::shouldDeleteDOMRange):
3552         (EditingDelegate::shouldChangeSelectedDOMRange):
3553         (EditingDelegate::shouldApplyStyle):
3554         (EditingDelegate::shouldChangeTypingStyle):
3555         (EditingDelegate::doPlatformCommand):
3556         (EditingDelegate::webViewDidBeginEditing):
3557         (EditingDelegate::webViewDidChange):
3558         (EditingDelegate::webViewDidEndEditing):
3559         (EditingDelegate::webViewDidChangeTypingStyle):
3560         (EditingDelegate::webViewDidChangeSelection):
3561         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3562         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3563         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
3564         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
3565         (FrameLoadDelegate::didFailProvisionalLoadWithError):
3566         (FrameLoadDelegate::didCommitLoadForFrame):
3567         (FrameLoadDelegate::didReceiveTitle):
3568         (FrameLoadDelegate::didFinishLoadForFrame):
3569         (FrameLoadDelegate::didFailLoadWithError):
3570         (FrameLoadDelegate::willPerformClientRedirectToURL):
3571         (FrameLoadDelegate::didCancelClientRedirectForFrame):
3572         (FrameLoadDelegate::windowScriptObjectAvailable):
3573         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3574         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
3575         (FrameLoadDelegate::didDisplayInsecureContent):
3576         (FrameLoadDelegate::didRunInsecureContent):
3577         (FrameLoadDelegate::webViewProgressFinishedNotification):
3578         * DumpRenderTree/win/HistoryDelegate.cpp:
3579         (HistoryDelegate::didNavigateWithNavigationData):
3580         (HistoryDelegate::didPerformClientRedirectFromURL):
3581         (HistoryDelegate::didPerformServerRedirectFromURL):
3582         (HistoryDelegate::updateHistoryTitle):
3583         (HistoryDelegate::populateVisitedLinksForWebView):
3584         * DumpRenderTree/win/PolicyDelegate.cpp:
3585         (PolicyDelegate::decidePolicyForNavigationAction):
3586         (PolicyDelegate::unableToImplementPolicyWithError):
3587         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3588         (ResourceLoadDelegate::willSendRequest):
3589         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3590         (ResourceLoadDelegate::didReceiveResponse):
3591         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3592         (ResourceLoadDelegate::didFailLoadingWithError):
3593         * DumpRenderTree/win/TestRunnerWin.cpp:
3594         (TestRunner::addDisallowedURL):
3595         (TestRunner::originsWithApplicationCache):
3596         (TestRunner::setStorageDatabaseIdleInterval):
3597         (TestRunner::closeIdleLocalStorageDatabases):
3598         (TestRunner::copyDecodedHostName):
3599         (TestRunner::copyEncodedHostName):
3600         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3601         (TestRunner::isGeolocationProviderActive):
3602         (TestRunner::pathToLocalResource):
3603         (TestRunner::setMockDeviceOrientation):
3604         (TestRunner::setMockGeolocationPosition):
3605         (TestRunner::setMockGeolocationPositionUnavailableError):
3606         (TestRunner::setSpatialNavigationEnabled):
3607         (TestRunner::setAutomaticLinkDetectionEnabled):
3608         (TestRunner::isCommandEnabled):
3609         (TestRunner::authenticateSession):
3610         (TestRunner::addChromeInputField):
3611         (TestRunner::removeChromeInputField):
3612         (TestRunner::focusWebView):
3613         (TestRunner::grantWebNotificationPermission):
3614         (TestRunner::denyWebNotificationPermission):
3615         (TestRunner::removeAllWebNotificationPermissions):
3616         (TestRunner::simulateWebNotificationClick):
3617         (TestRunner::imageCountInGeneralPasteboard):
3618         * DumpRenderTree/win/UIDelegate.cpp:
3619         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3620         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3621         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3622         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3623         (UIDelegate::webViewAddMessageToConsole):
3624         (UIDelegate::exceededDatabaseQuota):
3625         (UIDelegate::setStatusText):
3626         (UIDelegate::didPressMissingPluginButton):
3627
3628 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3629
3630         Add a setting to create editable MiniBrowser windows by default
3631         https://bugs.webkit.org/show_bug.cgi?id=166806
3632
3633         Reviewed by Beth Dakin.
3634
3635         * MiniBrowser/mac/AppDelegate.m:
3636         (-[BrowserAppDelegate createBrowserWindowController:]):
3637         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3638         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3639         * MiniBrowser/mac/SettingsController.h:
3640         * MiniBrowser/mac/SettingsController.m:
3641         (-[SettingsController _populateMenu]):
3642         (-[SettingsController validateMenuItem:]):
3643         (-[SettingsController toggleCreateEditorByDefault:]):
3644         (-[SettingsController createEditorByDefault]):
3645         Add a setting and update the key equivalents accordingly.
3646         Also make sure to make the right kind of window on launch.
3647
3648 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3649
3650         Fix the 32-bit build.
3651
3652         * MiniBrowser/mac/BrowserWindowController.h:
3653         * MiniBrowser/mac/BrowserWindowController.m:
3654
3655 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3656
3657         Fix the 32-bit build.
3658
3659         * MiniBrowser/mac/BrowserWindowController.m:
3660
3661 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3662
3663         Make it possible to drop HTML files on the MiniBrowser icon
3664         https://bugs.webkit.org/show_bug.cgi?id=166802
3665
3666         Reviewed by Simon Fraser.
3667
3668         * MiniBrowser/mac/AppDelegate.m:
3669         (-[BrowserAppDelegate application:openFile:]):
3670         * MiniBrowser/mac/Info.plist:
3671         If you're using an editable window, the usual trick of dropping on the
3672         window doesn't work anymore (it makes an <attachment> instead).
3673
3674 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3675
3676         MiniBrowser window gets smaller each time it is instantiated
3677         https://bugs.webkit.org/show_bug.cgi?id=166807
3678
3679         Reviewed by Andy Estes.
3680
3681         * MiniBrowser/mac/BrowserWindowController.m:
3682         (-[BrowserWindowController windowDidLoad]):
3683         * MiniBrowser/mac/BrowserWindow.xib:
3684         Turn on full-window content view support with IB, instead of waiting
3685         until after the views have been loaded. This seems to resolve the
3686         longstanding ever-shrinking-window problem.
3687
3688 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3689
3690         Add indent/outdent items to MiniBrowser's new format menu
3691         https://bugs.webkit.org/show_bug.cgi?id=166805
3692
3693         Reviewed by Dan Bernstein.
3694
3695         * MiniBrowser/mac/MainMenu.xib:
3696
3697 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3698
3699         Add a stock Format menu to MiniBrowser
3700         https://bugs.webkit.org/show_bug.cgi?id=166804
3701
3702         Reviewed by Andy Estes.
3703
3704         * MiniBrowser/mac/MainMenu.xib:
3705         Many of the features automatically work with editable web views.
3706         However, this seems to expose a bug where none of the font-related features
3707         (Cmd-B, for example) work until the first time the font panel is shown,
3708         per process, which will need to be investigated separately.
3709
3710 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3711
3712         Remove unused applicationWillTerminate methods from MiniBrowser
3713         https://bugs.webkit.org/show_bug.cgi?id=166803
3714
3715         Reviewed by Andy Estes.
3716
3717         * MiniBrowser/mac/AppDelegate.m:
3718         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
3719         * MiniBrowser/mac/BrowserWindowController.h:
3720         * MiniBrowser/mac/BrowserWindowController.m:
3721         (-[BrowserWindowController applicationTerminating]): Deleted.
3722         * MiniBrowser/mac/WK1BrowserWindowController.m:
3723         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
3724         * MiniBrowser/mac/WK2BrowserWindowController.m:
3725         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
3726
3727 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3728
3729         Add the ability to create empty contentEditable windows in MiniBrowser
3730         https://bugs.webkit.org/show_bug.cgi?id=166801
3731
3732         Reviewed by Wenson Hsieh.
3733
3734         * MiniBrowser/mac/AppDelegate.h:
3735         * MiniBrowser/mac/AppDelegate.m:
3736         (-[BrowserAppDelegate createBrowserWindowController:]):
3737         (-[BrowserAppDelegate newWindow:]):
3738         (-[BrowserAppDelegate newEditorWindow:]):
3739         (-[BrowserAppDelegate openDocument:]):
3740         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3741         * MiniBrowser/mac/BrowserWindowController.h:
3742         * MiniBrowser/mac/BrowserWindowController.m:
3743         (-[BrowserWindowController loadHTMLString:]):
3744         (-[BrowserWindowController toggleEditable:]):
3745         * MiniBrowser/mac/MainMenu.xib:
3746         * MiniBrowser/mac/WK1BrowserWindowController.m:
3747         (-[WK1BrowserWindowController awakeFromNib]):
3748         (-[WK1BrowserWindowController loadHTMLString:]):
3749         (-[WK1BrowserWindowController validateMenuItem:]):
3750         (-[WK1BrowserWindowController setEditable:]):
3751         (-[WK1BrowserWindowController updateTitle:]):
3752         * MiniBrowser/mac/WK2BrowserWindowController.m:
3753         (-[WK2BrowserWindowController awakeFromNib]):
3754         (-[WK2BrowserWindowController validateMenuItem:]):
3755         (-[WK2BrowserWindowController setEditable:]):
3756         (-[WK2BrowserWindowController updateTitle:]):
3757         (-[WK2BrowserWindowController loadHTMLString:]):
3758         Merge more functionality from WebEditingTester.
3759         Add two menu items for creating empty editable WebKit1/2 windows.
3760         Add a menu item to the Edit menu to toggle editability on any window.
3761
3762 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3763
3764         Implement find-in-page in MiniBrowser
3765         https://bugs.webkit.org/show_bug.cgi?id=166799
3766
3767         Reviewed by Andy Estes.
3768
3769         * MiniBrowser/mac/BrowserWindow.xib:
3770         * MiniBrowser/mac/BrowserWindowController.h:
3771         * MiniBrowser/mac/BrowserWindowController.m:
3772         (-[BrowserWindowController find:]): Deleted.
3773         * MiniBrowser/mac/MainMenu.xib:
3774         * MiniBrowser/mac/WK1BrowserWindowController.m:
3775         (-[WK1BrowserWindowController toggleShrinkToFit:]):
3776         (-[WK1BrowserWindowController find:]): Deleted.
3777         * MiniBrowser/mac/WK2BrowserWindowController.m:
3778         (-[WK2BrowserWindowController awakeFromNib]):
3779         (-[WK2BrowserWindowController dealloc]):
3780         (-[WK2BrowserWindowController validateMenuItem:]):
3781         (-[WK2BrowserWindowController performTextFinderAction:]):
3782         (-[WK2BrowserWindowController findBarView]):
3783         (-[WK2BrowserWindowController setFindBarView:]):
3784         (-[WK2BrowserWindowController isFindBarVisible]):
3785         (-[WK2BrowserWindowController setFindBarVisible:]):
3786         (-[WK2BrowserWindowController contentView]):
3787         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
3788         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
3789         (-[WK2BrowserWindowController find:]): Deleted.
3790         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
3791         protocol. At first glance, it's pretty broken, but vaguely works.
3792
3793 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3794
3795         Share the implementation of MiniBrowser view hiding functionality
3796         https://bugs.webkit.org/show_bug.cgi?id=166800
3797
3798         Reviewed by Andy Estes.
3799
3800         * MiniBrowser/mac/BrowserWindowController.m:
3801         (-[BrowserWindowController showHideWebView:]):
3802         (-[BrowserWindowController removeReinsertWebView:]):
3803         * MiniBrowser/mac/WK1BrowserWindowController.m:
3804         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
3805         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
3806         * MiniBrowser/mac/WK2BrowserWindowController.m:
3807         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
3808         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
3809         Move the implementation of these two things to the shared superclass,
3810         since they don't depend on WebKit-specific things.
3811         Also, there was no reason to retain the (WK)WebView while it was unparented,
3812         as the BrowserWindowController maintains a reference the entire time.
3813
3814 2017-01-06  Andy Estes  <aestes@apple.com>
3815
3816         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
3817         https://bugs.webkit.org/show_bug.cgi?id=166789
3818
3819         Reviewed by Alex Christensen.
3820
3821         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3822         * DumpRenderTree/PlatformMac.cmake:
3823         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
3824         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
3825         * DumpRenderTree/mac/DumpRenderTree.mm:
3826         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3827         createXMLStringFromWebArchiveData().
3828         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
3829         * WebKitTestRunner/Configurations/Base.xcconfig:
3830         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
3831         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3832         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3833         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
3834         createXMLStringFromWebArchiveData().
3835         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
3836         * WebKitTestRunner/PlatformMac.cmake:
3837         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3838         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
3839
3840 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3841
3842         Minor cleanups to IndentOutdentCommand and related code
3843         https://bugs.webkit.org/show_bug.cgi?id=166791
3844
3845         Reviewed by Simon Fraser.
3846
3847         * WebEditingTester/EditingOperations.m:
3848         (editingOperations):
3849         Add the outdent operation to WebEditingTester.
3850
3851 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3852
3853         Create a plan and a patch files for MotionMark and delete the Animometer's ones
3854         https://bugs.webkit.org/show_bug.cgi?id=166785
3855
3856         Reviewed by Ryosuke Niwa.
3857
3858         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3859         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
3860
3861 2017-01-06  Antoine Quint  <graouts@apple.com>
3862
3863         Support webkit-test-runner key-value pairs in http tests
3864         https://bugs.webkit.org/show_bug.cgi?id=149812
3865
3866         Reviewed by Alex Christensen.
3867
3868         We pass the absolute path for a test through to WKTR so that we can parse
3869         tests that are running as URLs for webkit-test-runner options.
3870
3871         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3872         (parseInputLine):
3873
3874         Explicitly skip the --absolute-path option in DRT or else we'd crash.
3875
3876         * Scripts/webkitpy/port/driver.py:
3877         (Driver._command_from_driver_input):
3878
3879         Pass the absolute path to the file through the CLI.
3880
3881         * WebKitTestRunner/TestController.cpp:
3882         (WTR::updateTestOptionsFromTestHeader):
3883         (WTR::TestController::testOptionsForTest):
3884         (WTR::parseInputLine):
3885         (WTR::TestController::runTest):
3886         * WebKitTestRunner/TestController.h:
3887
3888 2017-01-06  Tim Horton  <timothy_horton@apple.com>
3889
3890         Warning about unconnectable outlets when opening a MiniBrowser window
3891         https://bugs.webkit.org/show_bug.cgi?id=166756
3892
3893         Reviewed by Dan Bernstein.
3894
3895         * MiniBrowser/mac/BrowserWindow.xib:
3896         When launching MiniBrowser, it says:
3897         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
3898             (MBToolbarItem): missing setter or instance variable
3899         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
3900             (NSButtonCell): missing setter or instance variable.
3901
3902         It looks like someone added the connection from the share button
3903         to the BrowserWindowController three times; only one of the connections
3904         is valid. Remove the other two.
3905
3906 2017-01-05  Keith Rollin  <krollin@apple.com>
3907
3908         Add WebCore::URL::protocolHostAndPort
3909         https://bugs.webkit.org/show_bug.cgi?id=166426
3910
3911         Reviewed by Alex Christensen.
3912
3913         Add test for protocolHostAndPort.
3914
3915         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3916         (TestWebKitAPI::TEST_F):
3917
3918 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
3919
3920         [Win] Archive test result is failing.
3921         https://bugs.webkit.org/show_bug.cgi?id=166720
3922
3923         Reviewed by Alex Christensen.
3924
3925         Deleting the layout test result folder is sometimes failing
3926         on Windows. This is not a critical error.
3927
3928         * BuildSlaveSupport/test-result-archive:
3929         (archiveTestResults):
3930
3931 2017-01-04  Tomas Popela  <tpopela@redhat.com>
3932
3933         [GTK] Minibrowser: Add printing support
3934         https://bugs.webkit.org/show_bug.cgi?id=165298
3935
3936         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
3937         an error during the print, it's printed on the console.
3938
3939         Reviewed by Michael Catanzaro.
3940
3941         * MiniBrowser/gtk/BrowserWindow.c:
3942         (webKitPrintOperationFailedCallback):
3943         (printPage):
3944         (browser_window_init):
3945
3946 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
3947
3948         [css-grid] Fix crash clamping grid lines
3949         https://bugs.webkit.org/show_bug.cgi?id=166637
3950
3951         Reviewed by Darin Adler.
3952
3953         Creates new unit test to verify that the maximum tracks limit
3954         is used in GridPosition too.
3955
3956         * TestWebKitAPI/PlatformEfl.cmake:
3957         * TestWebKitAPI/PlatformGTK.cmake:
3958         * TestWebKitAPI/PlatformWin.cmake:
3959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3960         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
3961         (TestWebKitAPI::TEST):
3962
3963 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3964
3965         Move editing history scripts to WebCore PrivateHeaders
3966         https://bugs.webkit.org/show_bug.cgi?id=166709
3967         <rdar://problem/29876612>
3968
3969         Reviewed by Dan Bernstein.
3970
3971         Update references to editing script files in WebCore that were moved.
3972
3973         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
3974
3975 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3976
3977         Unreviewed, build fix after r210313 part 2
3978         https://bugs.webkit.org/show_bug.cgi?id=166676
3979
3980         Add 'U' suffix.
3981
3982         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3983         (TestWebKitAPI::TEST):
3984         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3985         (TestWebKitAPI::TEST):
3986
3987 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3988
3989         Limit thread name appropriately
3990         https://bugs.webkit.org/show_bug.cgi?id=166676
3991
3992         Reviewed by Sam Weinig.
3993
3994         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3995         (TestWebKitAPI::TEST):
3996         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3997         (TestWebKitAPI::TEST):
3998
3999 2017-01-04  Andy Estes  <aestes@apple.com>
4000
4001         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
4002         https://bugs.webkit.org/show_bug.cgi?id=166696
4003
4004         Reviewed by Tim Horton.
4005
4006         * TestWebKitAPI/PlatformGTK.cmake:
4007         * TestWebKitAPI/PlatformWin.cmake:
4008         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4009         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
4010         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
4011         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
4012         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
4013         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
4014         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
4015
4016 2017-01-03  Brian Burg  <bburg@apple.com>
4017
4018         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
4019         https://bugs.webkit.org/show_bug.cgi?id=166003
4020         <rdar://problem/28718990>
4021
4022         Reviewed by Joseph Pecoraro.
4023
4024         Teach run-inspector-generator-tests to generate test output using the platform name
4025         derived from the directory that the test is in. For example, tests in the /generic/
4026         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
4027
4028         * Scripts/webkitpy/inspector/main.py:
4029         (InspectorGeneratorTests.generate_from_json):
4030         (InspectorGeneratorTests.run_tests):
4031         (InspectorGeneratorTests.main):
4032
4033 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
4034
4035         Unreviewed cmake buildfix after r210266.
4036
4037         * DumpRenderTree/PlatformMac.cmake:
4038
4039 2017-01-04  Tim Horton  <timothy_horton@apple.com>
4040
4041         Provide a setting for clients to always prefer low-power WebGL
4042         https://bugs.webkit.org/show_bug.cgi?id=166675
4043         <rdar://problem/29834093>
4044
4045         Reviewed by Dan Bernstein.
4046
4047         * MiniBrowser/mac/Info.plist:
4048         Have MiniBrowser claim to be a modern app that supports
4049         automatic graphics switching. WebKit needs to support automatic
4050         graphics switching, so our test app might as well. Without this
4051         Info.plist parameter, this change has no effect, and bringing up
4052         a WebGL context still brings up the discrete GPU (also true of the
4053         existing web-exposed preferLowPowerToHighPerformance API).
4054
4055 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
4056
4057         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
4058         https://bugs.webkit.org/show_bug.cgi?id=166645
4059
4060         Reviewed by Carlos Garcia Campos.
4061
4062         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
4063         (TestWebKitAPI::TEST):
4064
4065 2017-01-03  Andy Estes  <aestes@apple.com>
4066
4067         Place all the Cocoa WebCore API tests in the same directory
4068         https://bugs.webkit.org/show_bug.cgi?id=166673
4069
4070         Reviewed by Michael Catanzaro.
4071
4072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4073         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
4074         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
4075         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
4076
4077 2017-01-03  Tim Horton  <timothy_horton@apple.com>
4078
4079         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
4080         https://bugs.webkit.org/show_bug.cgi?id=166450
4081         <rdar://problem/29447824>
4082
4083         Reviewed by Darin Adler.
4084
4085         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4086         * DumpRenderTree/TestRunner.cpp:
4087         (TestRunner::staticFunctions):
4088         * DumpRenderTree/mac/TestRunnerMac.mm:
4089         (setSpellCheckerLoggingEnabledCallback):
4090         * DumpRenderTree/win/TestRunnerWin.cpp:
4091         (setSpellCheckerLoggingEnabledCallback):
4092         * DumpRenderTree/mac/DumpRenderTree.mm:
4093         (resetWebViewToConsistentStateBeforeTesting):
4094         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
4095         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
4096         (stringForCorrectionResponse):
4097         (drt_NSSpellChecker_recordResponseToCorrection):
4098         (swizzleNSSpellCheckerMethodsIfNeeded):
4099         (setSpellCheckerLoggingEnabled):
4100         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
4101         set to true, logs to stdout (which ends up in the test result) whenever
4102         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
4103         is called, and then calls the original method. It is reset to false between tests.
4104
4105 2017-01-03  Sam Weinig  <sam@webkit.org>
4106
4107         Make WTF::Expected support Ref template parameters
4108         https://bugs.webkit.org/show_bug.cgi?id=166662
4109
4110         Reviewed by Alex Christensen.
4111
4112         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4113         (TestWebKitAPI::TEST):
4114         Add tests for using Ref with Expected.
4115
4116 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
4117
4118         [GTK] Expose WebKitSecurityOrigin API
4119         https://bugs.webkit.org/show_bug.cgi?id=166632
4120
4121         Reviewed by Carlos Garcia Campos.
4122
4123         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
4124         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
4125         (testSecurityOriginBasicConstructor):
4126         (testSecurityOriginURIConstructor):
4127         (testSecurityOriginDefaultPort):
4128         (testSecurityOriginFileURI):
4129         (testSecurityOriginDataURI):
4130         (beforeAll):
4131         (afterAll):
4132
4133 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4134
4135         [GTK] HTTP auth layout tests are flaky
4136         https://bugs.webkit.org/show_bug.cgi?id=158919
4137
4138         Reviewed by Michael Catanzaro.
4139
4140         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
4141         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
4142         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
4143         missing valac in the bots.
4144
4145 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
4146
4147         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
4148         https://bugs.webkit.org/show_bug.cgi?id=165797
4149
4150         Reviewed by Michael Catanzaro.
4151
4152         Move directory ruleset after all exclude rules of Source rulset.
4153
4154         * gtk/manifest.txt.in:
4155
4156 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
4157
4158         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
4159         https://bugs.webkit.org/show_bug.cgi?id=166636
4160
4161         Reviewed by Darin Adler.
4162
4163         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4164         (TestWebKitAPI::TEST):
4165
4166 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
4167
4168         [GTK] WebCore/CSSParser unit test is not being built
4169         https://bugs.webkit.org/show_bug.cgi?id=166492
4170
4171         Reviewed by Michael Catanzaro.
4172
4173         This test was introduced in r175930, but we were not building
4174         it on GTK+ port since r176015.
4175         This patch marks the test to be built again on GTK+.
4176         JFTR, the test is passing right now.
4177
4178         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
4179         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
4180
4181 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
4182
4183         AX: Expose block quote level to iOS API
4184         https://bugs.webkit.org/show_bug.cgi?id=166629
4185         <rdar://problem/29834793>
4186
4187         Reviewed by Darin Adler.
4188
4189         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4190         (AccessibilityUIElement::numberAttributeValue):
4191         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4192         (WTR::AccessibilityUIElement::numberAttributeValue):
4193
4194 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
4195
4196         SecurityOrigin::create triplet constructor does not canonicalize port
4197         https://bugs.webkit.org/show_bug.cgi?id=166624
4198
4199         Reviewed by Daniel Bates.
4200
4201         * TestWebKitAPI/PlatformGTK.cmake:
4202         * TestWebKitAPI/PlatformWin.cmake:
4203         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4204         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
4205         (TestWebKitAPI::SecurityOriginTest::SetUp):
4206         (TestWebKitAPI::TEST_F):
4207
4208 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
4209
4210         [GTK] Improve user agent construction
4211         https://bugs.webkit.org/show_bug.cgi?id=142074
4212
4213         Reviewed by Carlos Garcia Campos.
4214
4215         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4216         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
4217         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
4218         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
4219         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
4220         (TestWebKitAPI::TEST):
4221
4222 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
4223
4224         [GTK] Improve user agent construction
4225         https://bugs.webkit.org/show_bug.cgi?id=142074
4226
4227         Reviewed by Carlos Garcia Campos.
4228
4229         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
4230         (TestWebKitAPI::TEST):
4231
4232 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
4233
4234         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
4235         https://bugs.webkit.org/show_bug.cgi?id=166472
4236         rdar://problem/29675551
4237
4238         Reviewed by Tim Horton.
4239
4240         These changes are necessary to allow the mouse to leave the WTR window while
4241         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
4242         (which DRT does); we'd always go through mouseMoved, which hits an early return
4243         in WebViewImpl::mouseMoved() when the point is outside the view.
4244
4245         * WebKitTestRunner/mac/EventSenderProxy.mm:
4246         (WTR::EventSenderProxy::mouseMoveTo):
4247
4248 2016-12-23  Andy Estes  <aestes@apple.com>
4249
4250         [iOS] Fix some crashing webarchive tests
4251         https://bugs.webkit.org/show_bug.cgi?id=166470
4252
4253         Reviewed by Andreas Kling.
4254
4255         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
4256         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
4257         so this change uses that on both platforms.
4258
4259         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
4260         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
4261         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
4262         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
4263         * WebKitTestRunner/PlatformMac.cmake:
4264         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4265         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
4266
4267 2016-12-22  Saam Barati  <sbarati@apple.com>
4268
4269         WebAssembly: Silence the output of the spec-tests
4270         https://bugs.webkit.org/show_bug.cgi?id=166417
4271
4272         Reviewed by Mark Lam.
4273
4274         * Scripts/run-jsc-stress-tests:
4275
4276 2016-12-22  Zhuo Li  <zachli@apple.com>
4277
4278         [Cocoa] SPI for setloadsImagesAutomatically.
4279         https://bugs.webkit.org/show_bug.cgi?id=166401.
4280
4281         Reviewed by Darin Adler.
4282
4283         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
4284         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
4285         _loadsImagesAutomatically returns YES.
4286
4287 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4288
4289         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
4290         https://bugs.webkit.org/show_bug.cgi?id=161328
4291         <rdar://problem/28475977>
4292
4293         Reviewed by Darin Adler.
4294
4295         Running a test that scales the viewport and listens to a didEndZooming callback (such as
4296         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
4297         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
4298         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
4299         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
4300         load, should prevent this from happening, but from reading documentation and code inspection, this is not
4301         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
4302         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
4303         we finish running a test and before we load the next test.
4304
4305         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
4306         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
4307         previous test started zooming and then finished before zooming completed. Since this happens before the next
4308         tes