[GTK][WPE] Fix pacman install-dependencies packages
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2
3         [GTK][WPE] Fix pacman install-dependencies packages
4         https://bugs.webkit.org/show_bug.cgi?id=196817
5
6         Reviewed by Žan Doberšek.
7         
8         python3-setuptools is called python-setuptools
9         ruby-highline is only available on AUR
10         libv4l-devel is incorporated in v4l-utils
11
12         * gtk/install-dependencies:
13         * wpe/install-dependencies:
14
15 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
16
17         [GTK] REGRESSION(r243860): Many tests failing
18         https://bugs.webkit.org/show_bug.cgi?id=196791
19
20         Reviewed by Joanmarie Diggs.
21
22         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
23         multiple documents and check that accessibility hierarchy is updated after a navigation.
24
25         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
26         (loadChangedCallback):
27         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
28         (AccessibilityTest::AccessibilityTest):
29         (AccessibilityTest::~AccessibilityTest):
30         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
31         (AccessibilityTest::findTestServerApplication):
32         (AccessibilityTest::findDocumentWeb):
33         (AccessibilityTest::findRootObject):
34         (AccessibilityTest::waitUntilChildrenRemoved):
35         (AccessibilityTest::ensureProxy):
36         (testAtspiBasicHierarchy):
37         (beforeAll):
38         (afterAll):
39
40 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
41
42         [ews-build] Handle bug titles with unicode characters
43         https://bugs.webkit.org/show_bug.cgi?id=196802
44
45         Reviewed by Dewei Zhu.
46
47         * BuildSlaveSupport/ews-build/steps.py:
48         (ValidatePatch._is_bug_closed):
49
50 2019-04-11  Michael Saboff  <msaboff@apple.com>
51
52         Improve the Inline Cache Stats code
53         https://bugs.webkit.org/show_bug.cgi?id=196836
54
55         Reviewed by Saam Barati.
56
57         Added a new script to consolidate and arrange the output of --useICStats option.
58
59         This script merges the output from every group into one large table and sorts it from most common to
60         least common.  It also counts the slow path GetById and PutById variants and then calculates the
61         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
62         Put together, this is useful to see what property accesses are not getting cached.
63
64         * Scripts/ic-stats.py: Added.
65         (ICStats):
66         (ICStats.__init__):
67         (ICStats.parse):
68         (ICStats.dumpStats):
69         (usage):
70
71 2019-04-10  Alex Christensen  <achristensen@webkit.org>
72
73         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
74         https://bugs.webkit.org/show_bug.cgi?id=196809
75         <rdar://49800762>
76
77         Reviewed by Brady Eidson.
78
79         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
80         (TEST):
81
82 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
83
84         requestAnimationFrame should execute before the next frame
85         https://bugs.webkit.org/show_bug.cgi?id=177484
86
87         Reviewed by Simon Fraser.
88
89         Add trace points for the page RenderingUpdate.
90
91         * Tracing/SystemTracePoints.plist:
92
93 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
94
95         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
96         https://bugs.webkit.org/show_bug.cgi?id=196760
97
98         Reviewed by Don Olmstead.
99
100         vswhere.exe has been bundled since Visual Studio 2017 version
101         15.2. We shouldn't download vswhere.exe.
102
103         * Scripts/build-jsc: Do not call update-vswhere.py.
104         * Scripts/build-webkit: Ditto.
105         * Scripts/update-vswhere.py: Removed.
106         * Scripts/webkitdirs.pm:
107         (requireModulesForVSWhere): Deleted.
108         (pickCurrentVisualStudioInstallation): Deleted.
109         (visualStudioInstallDirVSWhere): Return the latest installed VS
110         installation path by using the bundled vswhere.exe.
111         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
112         (visualStudioInstallDirFallback): Removed.
113
114 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
115
116         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
117         https://bugs.webkit.org/show_bug.cgi?id=196780
118
119         Reviewed by Alexey Proskuryakov.
120
121         * BuildSlaveSupport/ews-build/steps.py:
122         * BuildSlaveSupport/ews-build/steps_unittest.py:
123
124 2019-04-10  Alex Christensen  <achristensen@webkit.org>
125
126         Add SPI WKNavigationResponse._downloadAttribute
127         https://bugs.webkit.org/show_bug.cgi?id=196755
128         <rdar://49587365>
129
130         Reviewed by Brady Eidson.
131
132         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
133         (-[NavigationResponseTestDelegate navigationResponse]):
134         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
135         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
136         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
137         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
138         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
139         (readRequest):
140         (writeResponse):
141         (TEST):
142
143 2019-04-10  Tim Horton  <timothy_horton@apple.com>
144
145         Add modern API for overriding the page's specified viewport configuration
146         https://bugs.webkit.org/show_bug.cgi?id=167734
147         <rdar://problem/30331795>
148
149         Reviewed by Simon Fraser.
150
151         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
152         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
153
154 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
155
156         Add support for incremental bytecode cache updates
157         https://bugs.webkit.org/show_bug.cgi?id=195000
158
159         Reviewed by Filip Pizlo.
160
161         Exit when the initial run to generate bytecode fails.
162
163         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
164
165 2019-04-10  Alex Christensen  <achristensen@webkit.org>
166
167         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
168         https://bugs.webkit.org/show_bug.cgi?id=196744
169         <rdar://49415309>
170
171         Reviewed by Chris Dumez.
172
173         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
174         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
175
176 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
177
178         Add a way to opt into modern compatibility mode in layout tests
179         https://bugs.webkit.org/show_bug.cgi?id=196770
180         <rdar://problem/49777550>
181
182         Reviewed by Antoine Quint.
183
184         Add a new test option to enable modern compatibility mode in layout tests.
185
186         * WebKitTestRunner/TestController.cpp:
187         (WTR::updateTestOptionsFromTestHeader):
188         * WebKitTestRunner/TestController.h:
189         * WebKitTestRunner/TestOptions.h:
190         (WTR::TestOptions::hasSameInitializationOptions const):
191         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
192         (WTR::TestController::platformCreateWebView):
193         (WTR::TestController::enableModernCompatibilityMode):
194
195 2019-04-10  Andy Estes  <aestes@apple.com>
196
197         Try to fix the 32-bit watchOS build.
198
199         * TestWebKitAPI/cocoa/TestWKWebView.mm:
200         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
201
202 2019-04-10  Antoine Quint  <graouts@apple.com>
203
204         Enable Pointer Events on watchOS
205         https://bugs.webkit.org/show_bug.cgi?id=196771
206         <rdar://problem/49040909>
207
208         Reviewed by Dean Jackson.
209
210         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
211
212 2019-04-10  Philippe Normand  <pnormand@igalia.com>
213
214         Unreviewed. Fix WPE accessibility tests after r244059.
215
216         We are failing to load the injected bundle due to undefined symbol
217         AccessibilityUIElement::replaceTextInRange().
218
219         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
220         (WTR::AccessibilityUIElement::replaceTextInRange):
221
222 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
223
224         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
225         https://bugs.webkit.org/show_bug.cgi?id=196727
226
227         Reviewed by Fujii Hironori.
228
229         * MiniBrowser/win/WebKitBrowserWindow.cpp:
230         (WebKitBrowserWindow::create):
231
232 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
233
234         [ews-build] Add unit tests for PrintConfiguration
235         https://bugs.webkit.org/show_bug.cgi?id=196752
236
237         Reviewed by Dewei Zhu.
238
239         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
240
241 2019-04-09  Keith Rollin  <krollin@apple.com>
242
243         Unreviewed build maintenance -- update .xcfilelists.
244
245         * DumpRenderTree/DerivedSources-input.xcfilelist:
246         * DumpRenderTree/DerivedSources-output.xcfilelist:
247
248 2019-04-09  Zalan Bujtas  <zalan@apple.com>
249
250         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
251         https://bugs.webkit.org/show_bug.cgi?id=196743
252         <rdar://problem/43897551>
253
254         Reviewed by Tim Horton.
255
256         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
257         (TEST):
258
259 2019-04-09  Youenn Fablet  <youenn@apple.com>
260
261         Close service worker database on network process suspension
262         https://bugs.webkit.org/show_bug.cgi?id=196623
263         <rdar://problem/48930869>
264
265         Reviewed by Alex Christensen.
266
267         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
268
269 2019-04-09  Daniel Bates  <dabates@apple.com>
270
271         [iPad] Should open popover when the spacebar is pressed
272         https://bugs.webkit.org/show_bug.cgi?id=196360
273         <rdar://problem/49389129>
274
275         Reviewed by Brent Fulgham.
276
277         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
278
279         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
280         (WTR::UIScriptController::isShowingPopover const): Added.
281         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
282         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
283         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
284         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
285         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
286         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
287         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
288         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
289         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
290         (WTR::UIScriptController::isShowingPopover const): Added.
291         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
292         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
293         * TestRunnerShared/UIScriptContext/UIScriptController.h:
294         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
295         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
296         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
297         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
298         (-[TestRunnerWKWebView _willPresentPopover]): Added.
299         (-[TestRunnerWKWebView _didDismissPopover]): Added.
300         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
301         (WTR::UIScriptController::isShowingPopover const): Added.
302         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
303         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
304
305 2019-04-09  Alex Christensen  <achristensen@webkit.org>
306
307         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
308         https://bugs.webkit.org/show_bug.cgi?id=196665
309         <rdar://45115669>
310
311         Reviewed by Geoff Garen.
312
313         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
314         (goBack):
315         (+[SimpleLookupContext sharedLookupContext]):
316         (-[SimpleLookupContext lookUpURL:completionHandler:]):
317         (TEST):
318         (+[Simple3LookupContext sharedLookupContext]): Deleted.
319         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
320
321 2019-04-09  John Wilander  <wilander@apple.com>
322
323         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
324         https://bugs.webkit.org/show_bug.cgi?id=196558
325         <rdar://problem/47650245>
326
327         Reviewed by Youenn Fablet.
328
329         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
330         (TestWebKitAPI::TEST):
331             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
332
333 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
334
335         [CMake] Apple builds should use ICU_INCLUDE_DIRS
336         https://bugs.webkit.org/show_bug.cgi?id=196720
337
338         Reviewed by Konstantin Tokarev.
339
340         * TestWebKitAPI/PlatformMac.cmake:
341
342 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
343
344         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
345         https://bugs.webkit.org/show_bug.cgi?id=196694
346         <rdar://problem/48388734>
347
348         Rubber-stamped by Aakash Jain.
349
350         * Scripts/webkitpy/port/image_diff.py:
351         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
352         * Scripts/webkitpy/port/server_process.py:
353         (ServerProcess.has_available_stdout): Check if stdout has data in it.
354         (ServerProcess._wait_for_data_and_update_buffers_using_select):
355         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
356         * Scripts/webkitpy/port/server_process_mock.py:
357         (MockServerProcess.has_available_stdout):
358         * Scripts/webkitpy/port/server_process_unittest.py:
359         (TestServerProcess.serial_test_basic):
360
361 2019-04-09  Jer Noble  <jer.noble@apple.com>
362
363         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
364         https://bugs.webkit.org/show_bug.cgi?id=196097
365
366         Reviewed by Eric Carlson.
367
368         Drive-by bug fix: allow tests to play audio without a user gesture by default.
369
370         * DumpRenderTree/mac/DumpRenderTree.mm:
371         (resetWebPreferencesToConsistentValues):
372         * WebKitTestRunner/TestController.cpp:
373         (WTR::TestController::resetPreferencesToConsistentValues):
374
375 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
376
377         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
378         https://bugs.webkit.org/show_bug.cgi?id=196690
379
380         Reviewed by Michael Catanzaro.
381
382         * QueueStatusServer/config/queues.py:
383         * Scripts/webkitpy/common/config/ews.json:
384         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
385         (test_ews_name):
386
387 2019-04-09  Chris Dumez  <cdumez@apple.com>
388
389         Loads using loadHTMLString() cause flashing when process-swapping
390         https://bugs.webkit.org/show_bug.cgi?id=196714
391         <rdar://problem/49637354>
392
393         Reviewed by Antti Koivisto.
394
395         Add API test coverage.
396
397         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
398
399 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
400
401         Unreviewed. Fix ATK accessibility tests after r244059.
402
403         We are failing to load the injected bundle due to undefined symbol
404         AccessibilityUIElement::replaceTextInRange().
405
406         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
407         (WTR::AccessibilityUIElement::replaceTextInRange):
408
409 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
410
411         AX: Support API: accessibilityReplaceRange:withText
412         https://bugs.webkit.org/show_bug.cgi?id=196636
413
414         Unreviewed build fix for Windows port.
415
416         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
417         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
418
419 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
420
421         [CMake][WinCairo] Separate copied headers into different directories
422         https://bugs.webkit.org/show_bug.cgi?id=196655
423
424         Reviewed by Michael Catanzaro.
425
426         * DumpRenderTree/CMakeLists.txt:
427         * MiniBrowser/win/CMakeLists.txt:
428         * TestWebKitAPI/CMakeLists.txt:
429         * TestWebKitAPI/PlatformWin.cmake:
430
431 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
432
433         Log stack-trace for run-webkit-tests when interrupted
434         https://bugs.webkit.org/show_bug.cgi?id=176393
435         <rdar://problem/34262310>
436
437         Reviewed by Lucas Forschler.
438
439         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
440         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
441         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
442         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
443         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
444         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
445         (main): Set handlers to log stack trace on interruption.
446
447 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
448
449         AX: Support API: accessibilityReplaceRange:withText
450         https://bugs.webkit.org/show_bug.cgi?id=196636
451
452         Unreviewed build fix for Windows port.
453
454         * DumpRenderTree/AccessibilityUIElement.cpp:
455         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
456
457 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
458
459         [ews-build] Scripts using Buildbot API have CORS error
460         https://bugs.webkit.org/show_bug.cgi?id=196709
461
462         Reviewed by Alexey Proskuryakov.
463
464         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
465
466 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
467
468         AX: Support API: accessibilityReplaceRange:withText
469         https://bugs.webkit.org/show_bug.cgi?id=196636
470
471         Reviewed by Daniel Bates.
472
473         * DumpRenderTree/AccessibilityUIElement.cpp:
474         (replaceTextInRangeCallback):
475         (AccessibilityUIElement::replaceTextInRange):
476         (AccessibilityUIElement::getJSClass):
477         * DumpRenderTree/AccessibilityUIElement.h:
478         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
479         (AccessibilityUIElement::replaceTextInRange):
480         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
481         (AccessibilityUIElement::replaceTextInRange):
482         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
483         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
484         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
485         (WTR::AccessibilityUIElement::replaceTextInRange):
486         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
487         (WTR::AccessibilityUIElement::replaceTextInRange):
488
489 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
490
491         [iOS] Do not allow starting selection drags when selection views are not visible
492         https://bugs.webkit.org/show_bug.cgi?id=196686
493         <rdar://problem/49399192>
494
495         Reviewed by Tim Horton.
496
497         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
498         also add some new API tests to cover scenarios where the web view is not first responder.
499
500         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
501         (TestWebKitAPI::TEST):
502         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
503
504         Add a switch to optionally make the web view first responder when starting the simulated drag.
505
506         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
507         (-[DragAndDropSimulator initWithWebView:]):
508         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
509
510 2019-04-08  Justin Fan  <justin_fan@apple.com>
511
512         [Web GPU] Fix Web GPU experimental feature on iOS
513         https://bugs.webkit.org/show_bug.cgi?id=196632
514
515         Reviewed by Myles C. Maxfield.
516
517         Properly make Web GPU available on iOS 11+.
518
519         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
520
521 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
522
523         [ews-build] Do not upload archive when Compile Fails
524         https://bugs.webkit.org/show_bug.cgi?id=196674
525
526         Reviewed by Alexey Proskuryakov.
527
528         * BuildSlaveSupport/ews-build/factories.py:
529         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
530         * BuildSlaveSupport/ews-build/steps.py:
531         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
532         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
533         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
534
535 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
536
537         Enable DFG on MIPS
538         https://bugs.webkit.org/show_bug.cgi?id=196689
539
540         Reviewed by Žan Doberšek.
541
542         Since the bytecode change, we enabled the baseline JIT on mips in
543         r240432, but DFG is still missing. With this change, all tests are
544         passing on a ci20 board.
545
546         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
547
548 2019-04-08  Philippe Normand  <pnormand@igalia.com>
549
550         [Flatpak] Second run update-webkitwpe-flatpak fails
551         https://bugs.webkit.org/show_bug.cgi?id=192702
552
553         Reviewed by Carlos Garcia Campos.
554
555         * flatpak/flatpakutils.py:
556         (FlatpakObject.flatpak): Fix typo.
557         (FlatpakPackage.install): When installing, also update to the configured remote commit.
558         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
559
560 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
561
562         [GTK][WPE] outlook.live.com displays old-fashioned UI
563         https://bugs.webkit.org/show_bug.cgi?id=196642
564
565         Reviewed by Carlos Garcia Campos.
566
567         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
568         (TestWebKitAPI::TEST): New Mac platform quirk test.
569
570 2019-04-07  Commit Queue  <commit-queue@webkit.org>
571
572         Unreviewed, rolling out r243956.
573         https://bugs.webkit.org/show_bug.cgi?id=196688
574
575         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
576         by aakashjain on #webkit).
577
578         Reverted changeset:
579
580         "Clicking "Go Back" from a safe browsing warning from an
581         iframe should navigate the WKWebView back to the previous
582         page"
583         https://bugs.webkit.org/show_bug.cgi?id=196665
584         https://trac.webkit.org/changeset/243956
585
586 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
587
588         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
589         https://bugs.webkit.org/show_bug.cgi?id=196669
590
591         Reviewed by Geoffrey Garen.
592
593         Added three new unit tests for WeakHashSet.
594
595         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
596         (WTF_WeakPtr.WeakHashSetConstObjects):
597         (WTF_WeakPtr.WeakHashSetComputesEmpty):
598         (WTF_WeakPtr.WeakHashSetComputeSize):
599
600 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
601
602         Hide next and previous form control buttons when WKWebView is editable
603         https://bugs.webkit.org/show_bug.cgi?id=196672
604         <rdar://problem/35625321>
605
606         Reviewed by Tim Horton.
607
608         Add a new API test.
609
610         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
611         (-[TestWKWebView lastTrailingBarButtonGroup]):
612         (TestWebKitAPI::TEST):
613         * TestWebKitAPI/ios/UIKitSPI.h:
614
615 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
616
617         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
618         https://bugs.webkit.org/show_bug.cgi?id=196077
619         <rdar://problem/49108202>
620
621         Reviewed by Chris Dumez.
622
623         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
624         on new web view.
625
626         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
627
628 2019-04-05  Saam Barati  <sbarati@apple.com>
629
630         Make compare-results understand MotionMark
631         https://bugs.webkit.org/show_bug.cgi?id=196666
632
633         Reviewed by Yusuke Suzuki.
634
635         * Scripts/compare-results:
636         (PLT5Results):
637         (detectMotionMark):
638         (detectMotionMark1_1):
639         (motionMarkResults):
640         (motionMark1_1Results):
641         (detectBenchmark):
642         (biggerIsBetter):
643         (main):
644
645 2019-04-05  Alex Christensen  <achristensen@webkit.org>
646
647         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
648         https://bugs.webkit.org/show_bug.cgi?id=196665
649         <rdar://45115669>
650
651         Reviewed by Geoff Garen.
652
653         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
654         (goBack):
655         (+[SimpleLookupContext sharedLookupContext]):
656         (-[SimpleLookupContext lookUpURL:completionHandler:]):
657         (TEST):
658         (+[Simple3LookupContext sharedLookupContext]): Deleted.
659         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
660
661 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
662
663         [ews-build] Add configuration and architecture for windows builders
664         https://bugs.webkit.org/show_bug.cgi?id=196660
665
666         Reviewed by Lucas Forschler.
667
668         * BuildSlaveSupport/ews-build/config.json:
669
670 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
671
672         webkitpy: Don't run subsequent rounds if interrupted
673         https://bugs.webkit.org/show_bug.cgi?id=196646
674
675         Reviewed by Aakash Jain.
676
677         * Scripts/webkitpy/layout_tests/controllers/manager.py:
678         (Manager.run): Bail out if interrupted.
679
680 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
681
682         Test sessionStorage in PSON private browsing mode
683         https://bugs.webkit.org/show_bug.cgi?id=196561
684
685         Reviewed by Alex Christensen.
686
687         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
688
689 2019-04-05  Commit Queue  <commit-queue@webkit.org>
690
691         Unreviewed, rolling out r243833.
692         https://bugs.webkit.org/show_bug.cgi?id=196645
693
694         This change breaks build of WPE and GTK ports (Requested by
695         annulen on #webkit).
696
697         Reverted changeset:
698
699         "[CMake][WTF] Mirror XCode header directories"
700         https://bugs.webkit.org/show_bug.cgi?id=191662
701         https://trac.webkit.org/changeset/243833
702
703 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
704
705         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
706         https://bugs.webkit.org/show_bug.cgi?id=196635
707
708         Reviewed by Antti Koivisto.
709         
710         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
711         for a test to enable async frame scrolling via:
712             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
713         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
714         
715         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
716
717         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
718         (WTR::InjectedBundle::beginTesting):
719         * WebKitTestRunner/TestController.cpp:
720         (WTR::TestController::resetPreferencesToConsistentValues):
721
722 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
723
724         Use a correct LC_RPATH when building with ASan
725         https://bugs.webkit.org/show_bug.cgi?id=196576
726
727         Reviewed by David Kilzer.
728
729         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
730         so that ../Frameworks is checked. This is simpler and more reliable than updating
731         each SPC service xcconfig.
732
733 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
734
735         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
736         https://bugs.webkit.org/show_bug.cgi?id=196629
737
738         Reviewed by Lucas Forschler.
739
740         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
741
742 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
743
744         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
745         https://bugs.webkit.org/show_bug.cgi?id=196618
746
747         Reviewed by Lucas Forschler.
748
749         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
750         (StatusBubble): Added QUEUE_TRIGGERS.
751         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
752         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
753         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
754         its parent(builder).
755
756 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
757
758         [ews-app] Status-bubble steps are sometimes displayed in reverse order
759         https://bugs.webkit.org/show_bug.cgi?id=196625
760
761         Reviewed by Lucas Forschler.
762
763         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
764         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
765
766 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
767
768         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
769         https://bugs.webkit.org/show_bug.cgi?id=196630
770
771         Reviewed by Wenson Hsieh.
772
773         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
774
775 2019-04-04  Youenn Fablet  <youenn@apple.com>
776
777         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
778         https://bugs.webkit.org/show_bug.cgi?id=196543
779
780         Reviewed by Alex Christensen.
781
782         * WebKitTestRunner/TestController.cpp:
783         (WTR::TestController::generatePageConfiguration):
784
785 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
786
787         [ews-app] Status bubble should not display skipped buildbot steps
788         https://bugs.webkit.org/show_bug.cgi?id=196584
789
790         Reviewed by Lucas Forschler.
791
792         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
793
794 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
795
796         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
797         https://bugs.webkit.org/show_bug.cgi?id=196620
798
799         Reviewed by Lucas Forschler.
800
801         * BuildSlaveSupport/ews-app/ews/config.py:
802
803 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
804
805         [Win] DumpRenderTreeWatchDog.py is not checked into source
806         https://bugs.webkit.org/show_bug.cgi?id=196567
807         <rdar://problem/49525901>
808
809         Reviewed by Lucas Forschler.
810
811         This script is used on Win EWS bots to terminate hanging DRT processes.
812
813         * EWSTools/dumprendertreewatchdog.py: Added.
814
815 2019-04-04  Chris Dumez  <cdumez@apple.com>
816
817         Unreviewed, roll out r243858 which made tests time out.
818
819         Disable new API tests on Windows instead.
820
821         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
822         (TestWebKitAPI::TEST):
823
824 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
825
826         [ATK] Cleanup WebPageAccessibilityObjectAtk
827         https://bugs.webkit.org/show_bug.cgi?id=196537
828
829         Reviewed by Michael Catanzaro.
830
831         Also consider files under atk directories as exceptions for GObject conventions.
832
833         * Scripts/webkitpy/style/checkers/cpp.py:
834         (check_identifier_name_in_declaration):
835
836 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
837
838         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
839         https://bugs.webkit.org/show_bug.cgi?id=196588
840         <rdar://problem/49365787>
841
842         Unreviewed build fix for Windows port.
843
844         error C3861: 'kill': identifier not found
845
846         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
847         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
848
849 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
850
851         [ews-build] Cancel build and similar operations should have authentication
852         https://bugs.webkit.org/show_bug.cgi?id=196520
853
854         Reviewed by Dewei Zhu.
855
856         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
857         environment variables.
858
859 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
860
861         [ews-build] Do not trigger queues which are not in production yet
862         https://bugs.webkit.org/show_bug.cgi?id=196581
863
864         Reviewed by Dewei Zhu.
865
866         * BuildSlaveSupport/ews-build/config.json:
867
868 2019-04-03  Chris Dumez  <cdumez@apple.com>
869
870         Unreviewed, fix typo in the name of API test added in r243848.
871
872         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
873         (TestWebKitAPI::TEST):
874
875 2019-04-03  Chris Dumez  <cdumez@apple.com>
876
877         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
878         https://bugs.webkit.org/show_bug.cgi?id=196588
879         <rdar://problem/49365787>
880
881         Reviewed by Ryosuke Niwa.
882
883         Add API test coverage.
884
885         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
886         (TestWebKitAPI::nullJavaScriptCallback):
887         (TestWebKitAPI::didCrashCheckFrames):
888         (TestWebKitAPI::TEST):
889
890 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
891
892         run-webkit-tests: Upload test results (new results database)
893         https://bugs.webkit.org/show_bug.cgi?id=196577
894         <rdar://problem/34841155>
895
896         Reviewed by Lucas Forschler.
897
898         * Scripts/webkitpy/layout_tests/controllers/manager.py:
899         (Manager.run): Upload results after each device shard, since the configuration will be
900         different for each device.
901         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
902         uploaded to a results database.
903         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
904         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
905
906 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
907
908         -apple-trailing-word is needed for browser detection
909         https://bugs.webkit.org/show_bug.cgi?id=196575
910
911         Unreviewed.
912
913         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
914
915 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
916
917         [CMake][WTF] Mirror XCode header directories
918         https://bugs.webkit.org/show_bug.cgi?id=191662
919
920         Reviewed by Konstantin Tokarev.
921
922         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
923         builds.
924
925         * CMakeLists.txt:
926         * DumpRenderTree/CMakeLists.txt:
927         * DumpRenderTree/PlatformWin.cmake:
928         * MiniBrowser/win/CMakeLists.txt:
929         * TestWebKitAPI/CMakeLists.txt:
930         * TestWebKitAPI/PlatformWin.cmake:
931         * WebKitTestRunner/PlatformGTK.cmake:
932         * WebKitTestRunner/PlatformWin.cmake:
933
934 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
935
936         [ews-app] Status bubble should not display certain infrastructure status messages
937         https://bugs.webkit.org/show_bug.cgi?id=196550
938
939         Reviewed by Lucas Forschler.
940
941         Do not display the steps which are un-needed for end-user. This information is still avaiable
942         if the user click on the bubble and look at the Buildbot build.
943         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
944         (StatusBubble._steps_messages):
945         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
946
947 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
948
949         [ews-build] Use https for sending data to ews-app
950         https://bugs.webkit.org/show_bug.cgi?id=196492
951
952         Reviewed by Lucas Forschler.
953
954         * BuildSlaveSupport/ews-build/events.py:
955
956 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
957
958         Remove support for -apple-trailing-word
959         https://bugs.webkit.org/show_bug.cgi?id=196525
960
961         Reviewed by Zalan Bujtas.
962
963         This CSS property is nonstandard and not used.
964
965         * Scripts/webkitperl/FeatureList.pm:
966         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
967
968 2019-04-03  Youenn Fablet  <youenn@apple.com>
969
970         Add a test for DOMCache on multiple browsing in case of private browsing
971         https://bugs.webkit.org/show_bug.cgi?id=196524
972
973         Reviewed by Alex Christensen.
974
975         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
976         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
977
978 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
979
980         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
981         https://bugs.webkit.org/show_bug.cgi?id=196540
982
983         Reviewed by Aakash Jain.
984
985         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
986
987 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
988
989         Add plumbing for a compatibility mode preference in WebKit
990         https://bugs.webkit.org/show_bug.cgi?id=196005
991
992         Reviewed by Tim Horton.
993
994         Add new API tests.
995
996         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
997         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
998
999 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1000
1001         [WPE][GTK] Update libsrtp dependency package for Debian
1002         https://bugs.webkit.org/show_bug.cgi?id=196528
1003
1004         Reviewed by Frédéric Wang.
1005
1006         * gtk/install-dependencies:
1007         * wpe/install-dependencies:
1008
1009 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1010
1011         [WK2] Add support for Window's beforeprint / afterprint events
1012         https://bugs.webkit.org/show_bug.cgi?id=196478
1013         <rdar://problem/49535124>
1014
1015         Unreviewed build fix for MSVC.
1016
1017         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1018
1019         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1020
1021         * WebKitTestRunner/TestController.cpp:
1022         (WTR::printFrame): Use int and float literals.
1023
1024 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1025
1026         [ews-build] Reassign bots to queues
1027
1028         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1029
1030 2019-04-02  Chris Dumez  <cdumez@apple.com>
1031
1032         [WK2] Add support for Window's beforeprint / afterprint events
1033         https://bugs.webkit.org/show_bug.cgi?id=196478
1034
1035         Reviewed by Alex Christensen.
1036
1037         Add minimal implementation for printFrame in WebKitTestRunner.
1038
1039         * WebKitTestRunner/TestController.cpp:
1040         (WTR::printFrame):
1041         (WTR::TestController::createOtherPage):
1042         (WTR::TestController::createWebViewWithOptions):
1043
1044 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1045
1046         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1047         https://bugs.webkit.org/show_bug.cgi?id=196491
1048
1049         Reviewed by Lucas Forschler.
1050
1051         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1052
1053 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1054
1055         [ews-build] Configure buildbot try credentials in environment variables
1056         https://bugs.webkit.org/show_bug.cgi?id=196501
1057
1058         Reviewed by Lucas Forschler.
1059
1060         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1061         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1062         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1063
1064 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1065
1066         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1067         https://bugs.webkit.org/show_bug.cgi?id=196496
1068         <rdar://problem/49521634>
1069
1070         Reviewed by Chris Dumez.
1071
1072         Add new API tests (see WebKit ChangeLog for more detail).
1073
1074         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1075         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1076         (TEST):
1077
1078 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1079
1080         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1081         <https://webkit.org/b/196499>
1082
1083         Reviewed by Alexey Proskuryakov.
1084
1085         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1086         ENABLE_ADDRESS_SANITIZER.
1087
1088 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1089
1090         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1091         https://bugs.webkit.org/show_bug.cgi?id=182757
1092
1093         Reviewed by Don Olmstead.
1094
1095         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1096         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1097
1098 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1099
1100         run-api-tests: Upload test results
1101         https://bugs.webkit.org/show_bug.cgi?id=196323
1102         <rdar://problem/49356714>
1103
1104         Reviewed by Lucas Forschler.
1105
1106         * Scripts/webkitpy/api_tests/manager.py:
1107         (Manager):
1108         (Manager.run): Upload results to a results database.
1109         * Scripts/webkitpy/api_tests/run_api_tests.py:
1110         (parse_args): Add upload arguments.
1111         * Scripts/webkitpy/port/base.py:
1112         (Port):
1113         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1114         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1115         with commits from any other associated repositories.
1116         * Scripts/webkitpy/port/device.py:
1117         (Device):
1118         (Device.build_version): Access build_versoin of underlying platform device.
1119         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1120         (IOSSimulatorTest):
1121         (IOSSimulatorTest.test_configuration_for_upload):
1122         * Scripts/webkitpy/port/device_port.py:
1123         (DevicePort):
1124         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1125         the same as the machine uploading results.
1126         * Scripts/webkitpy/port/mac.py:
1127         (MacPort):
1128         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1129         * Scripts/webkitpy/port/mac_unittest.py:
1130         (MacTest):
1131         (MacTest.test_configuration_for_upload):
1132         * Scripts/webkitpy/xcode/simulated_device.py:
1133         (SimulatedDeviceManager._create_device_with_runtime):
1134         (SimulatedDevice.__init__): Create simulated device with a build_version.
1135         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1136         (test_existing_simulator):
1137
1138 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1139
1140         Remove extra newline characters (Follow-up fix to r243707)
1141
1142         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1143
1144 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1145
1146         [ews-app] Use API_KEY to accept results data
1147         https://bugs.webkit.org/show_bug.cgi?id=196461
1148
1149         Reviewed by Dewei Zhu.
1150
1151         * BuildSlaveSupport/ews-app/ews/views/results.py:
1152         (Results.post): Validate EWS_API_KEY before accepting any data.
1153         * BuildSlaveSupport/ews-build/events.py:
1154         (Events.sendData): Send EWS_API_KEY if available along with event data.
1155
1156 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1157
1158         Unable to copy and paste a PDF from Notes into Mail compose body
1159         https://bugs.webkit.org/show_bug.cgi?id=196442
1160         <rdar://problem/48573098>
1161
1162         Reviewed by Tim Horton.
1163
1164         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1165         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1166         to be specified on the item providers.
1167
1168         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1169         (TestWebKitAPI::mapItemForTesting):
1170         (TestWebKitAPI::contactItemForTesting):
1171
1172 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1173
1174         Make UIWKDocumentContext rects per-character instead of per-word
1175         https://bugs.webkit.org/show_bug.cgi?id=196459
1176
1177         Reviewed by Wenson Hsieh.
1178
1179         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1180         (TEST):
1181         Adjust test results due to switching to per-character rects.
1182
1183 2019-04-01  Chris Dumez  <cdumez@apple.com>
1184
1185         UIProcess crash when a prewarmed process is terminated
1186         https://bugs.webkit.org/show_bug.cgi?id=196451
1187         <rdar://problem/49245471>
1188
1189         Reviewed by Geoffrey Garen.
1190
1191         Add API test coverage.
1192
1193         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1194         (TEST):
1195
1196 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1197
1198         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1199         https://bugs.webkit.org/show_bug.cgi?id=196449
1200
1201         Reviewed by Lucas Forschler.
1202
1203         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1204         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1205         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1206         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1207
1208 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1209
1210         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1211         https://bugs.webkit.org/show_bug.cgi?id=196444
1212
1213         Reviewed by Lucas Forschler.
1214
1215         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1216
1217 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1218
1219         Add SPI to canonicalize NSURLs with WTF::URL
1220         https://bugs.webkit.org/show_bug.cgi?id=196415
1221         <rdar://problem/44980271>
1222
1223         Reviewed by Darin Adler.
1224
1225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1226         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1227         (TestWebKitAPI::TEST):
1228
1229 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1230
1231         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1232         https://bugs.webkit.org/show_bug.cgi?id=196441
1233
1234         Reviewed by Carlos Garcia Campos.
1235
1236         Don't cache the wpe_view_backend object that might not exist yet at the
1237         time of EventSenderProxy constructor invocation, but instead retrieve
1238         that object whenever it's required for event dispatching. This should
1239         avoid crashes in this constructor now that it's invoked before any
1240         PlatformWindow has been set up (as changed in r243496).
1241
1242         * WebKitTestRunner/EventSenderProxy.h:
1243         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1244         (WTR::viewBackend):
1245         (WTR::EventSenderProxy::EventSenderProxy):
1246         (WTR::EventSenderProxy::mouseDown):
1247         (WTR::EventSenderProxy::mouseUp):
1248         (WTR::EventSenderProxy::mouseMoveTo):
1249         (WTR::EventSenderProxy::mouseScrollBy):
1250         (WTR::EventSenderProxy::keyDown):
1251         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1252
1253 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1254
1255         [Win][WebKit] MiniBrowser should support high DPI display
1256         https://bugs.webkit.org/show_bug.cgi?id=196391
1257
1258         Reviewed by Alex Christensen.
1259
1260         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1261         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1262         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1263         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1264
1265 2019-03-31  Sam Weinig  <weinig@apple.com>
1266
1267         Remove more i386 specific configurations
1268         https://bugs.webkit.org/show_bug.cgi?id=196430
1269
1270         Reviewed by Alexey Proskuryakov.
1271
1272         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1273         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1274
1275 2019-03-31  Andy Estes  <aestes@apple.com>
1276
1277         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1278         https://bugs.webkit.org/show_bug.cgi?id=196433
1279         <rdar://problem/49293305>
1280
1281         Reviewed by Tim Horton.
1282
1283         Enhanced API test coverage to include all navigation response policy decisions in both
1284         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1285
1286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1287         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1288         (TestWebKitAPI::TEST):
1289         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1290         (readFile):
1291         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1292         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1293         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1294         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1295         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1296         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1297         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1298         (-[QuickLookDelegate _downloadDidStart:]):
1299         (-[QuickLookDelegate _download:didReceiveResponse:]):
1300         (-[QuickLookDelegate _download:didReceiveData:]):
1301         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1302         (-[QuickLookDelegate _downloadDidFinish:]):
1303         (-[QuickLookDelegate _download:didFailWithError:]):
1304         (-[QuickLookDelegate _downloadDidCancel:]):
1305         (-[QuickLookDelegate verifyDownload]):
1306         (runTest):
1307         (runTestDecideBeforeLoading):
1308         (runTestDecideAfterLoading):
1309         (TEST):
1310         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1311         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1312         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1313         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1314         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1315         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1316         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1317         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1318         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1319         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1320         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1321         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1322         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1323         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1324
1325 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1326
1327         [CMake] add testdfg as target with build-jsc
1328         https://bugs.webkit.org/show_bug.cgi?id=196393
1329
1330         Reviewed by Saam Barati.
1331
1332         Added testdfg as one of the targets to build when
1333         using CMake.
1334
1335         * Scripts/build-jsc:
1336
1337 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1338
1339         Delete WebMetal implementation in favor of WebGPU
1340         https://bugs.webkit.org/show_bug.cgi?id=195418
1341
1342         Reviewed by Dean Jackson.
1343
1344         * DumpRenderTree/mac/DumpRenderTree.mm:
1345         (enableExperimentalFeatures):
1346         (resetWebPreferencesToConsistentValues):
1347         * Scripts/webkitperl/FeatureList.pm:
1348         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1350         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1351         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1352         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1353         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1354         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1355         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1356         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1357         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1358         (WTR::InjectedBundle::beginTesting):
1359         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1360         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1361         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1362
1363 2019-03-29  Chris Dumez  <cdumez@apple.com>
1364
1365         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1366         https://bugs.webkit.org/show_bug.cgi?id=196405
1367         <rdar://problem/49428130>
1368
1369         Reviewed by Wenson Hsieh.
1370
1371         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1372         the popover presentation methods to be no-ops. Use this in the new test added in
1373         r243523 so that we do not swizzle those methods for all tests. This is needed because
1374         those WatchOS tests rely on the popover getting presented and interactive.
1375
1376         * WebKitTestRunner/TestController.cpp:
1377         (WTR::updateTestOptionsFromTestHeader):
1378         * WebKitTestRunner/TestController.h:
1379         * WebKitTestRunner/TestOptions.h:
1380         (WTR::TestOptions::hasSameInitializationOptions const):
1381         * WebKitTestRunner/ios/TestControllerIOS.mm:
1382         (WTR::TestController::platformInitialize):
1383         (WTR::TestController::platformResetStateToConsistentValues):
1384
1385 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1386
1387         [Curl] Add Server Trust Evaluation Support.
1388         https://bugs.webkit.org/show_bug.cgi?id=191646
1389
1390         Reviewed by Fujii Hironori.
1391
1392         Implemented MiniBrowser UI for asking if user trusts the server.
1393
1394         * MiniBrowser/win/Common.cpp:
1395         (askServerTrustEvaluation):
1396         (replaceString):
1397         * MiniBrowser/win/Common.h:
1398         * MiniBrowser/win/MiniBrowserLib.rc:
1399         * MiniBrowser/win/MiniBrowserLibResource.h:
1400         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1401         (createPEMString):
1402         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1403         (WebKitBrowserWindow::canTrustServerCertificate):
1404         * MiniBrowser/win/WebKitBrowserWindow.h:
1405
1406 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1407
1408         Implement ResizeObserver.
1409         https://bugs.webkit.org/show_bug.cgi?id=157743
1410
1411         Reviewed by Simon Fraser.
1412
1413         Support resizeObserverEnabled webPreferences.
1414
1415         * DumpRenderTree/TestOptions.cpp:
1416         (TestOptions::TestOptions):
1417         * DumpRenderTree/TestOptions.h:
1418         * DumpRenderTree/mac/DumpRenderTree.mm:
1419         (setWebPreferencesForTestOptions):
1420         * DumpRenderTree/win/DumpRenderTree.cpp:
1421         (enableExperimentalFeatures):
1422         * Scripts/webkitperl/FeatureList.pm:
1423         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1424
1425 2019-03-28  John Wilander  <wilander@apple.com>
1426
1427         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1428         https://bugs.webkit.org/show_bug.cgi?id=196281
1429         <rdar://problem/48938748>
1430
1431         Reviewed by Alex Christensen.
1432
1433         This patch adds the function isStatisticsHasLocalStorage() to the
1434         TestRunner. With it, the page can query the WebsiteDataStore in the
1435         UI process to make sure that it sees LocalStorage.
1436
1437         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1438         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1439         (WTR::TestRunner::isStatisticsHasLocalStorage):
1440         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1441         * WebKitTestRunner/TestController.cpp:
1442         (WTR::TestController::isStatisticsHasLocalStorage):
1443         * WebKitTestRunner/TestController.h:
1444         * WebKitTestRunner/TestInvocation.cpp:
1445         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1446
1447 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1448
1449         API::Data::createWithoutCopying should do a null check before calling CFRelease
1450         https://bugs.webkit.org/show_bug.cgi?id=196276
1451         <rdar://problem/48059859>
1452
1453         Reviewed by Alex Christensen.
1454
1455         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1456
1457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1458         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1459         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1460         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1461         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1462         (TestWebKitAPI::TEST):
1463
1464 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1465
1466         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1467         https://bugs.webkit.org/show_bug.cgi?id=186276
1468
1469         Reviewed by Carlos Garcia Campos.
1470
1471         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1472         (webViewLoadChanged):
1473         (testWebResourceGetDataError):
1474         (testWebResourceGetDataEmpty):
1475         (beforeAll):
1476         (webViewloadChanged): Deleted.
1477
1478 2019-03-27  Andy Estes  <aestes@apple.com>
1479
1480         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1481         https://bugs.webkit.org/show_bug.cgi?id=196317
1482
1483         Reviewed by Dan Bernstein.
1484
1485         package-root copies built products into a staging directory using ditto(1), which does not
1486         follow symbolic links as it traverses a directory. Now that the files in
1487         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1488         itself, these become broken links when ditto'd into the staging directory.
1489
1490         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1491
1492         * Scripts/package-root:
1493
1494 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1495
1496         [ews-app] Update display text of Submit for ews analysis
1497         https://bugs.webkit.org/show_bug.cgi?id=196309
1498
1499         Reviewed by Dewei Zhu.
1500
1501         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1502
1503 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1504
1505         run-webkit-tests should check for leaks in WebKit processes
1506         <https://webkit.org/b/193772>
1507         <rdar://problem/46526680>
1508
1509         Reviewed by Ryosuke Niwa.
1510
1511         This works by doing the following:
1512         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1513           The list of child processes are returned one per line:
1514           process.name: pid
1515         - Run the "#LIST CHILD PROCESSES" command just before the
1516           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1517           processes on the ServerProcess object.
1518         - When the `--leaks` switch is handled, run check_for_leaks() on
1519           each child process after the main test harness.
1520
1521         * DumpRenderTree/mac/DumpRenderTree.mm:
1522         (handleControlCommand):
1523         - Use strncmp() instead of strcmp().
1524         - Add support for handling "#LIST CHILD PROCESSES" command.
1525
1526         * Scripts/webkitpy/port/base.py:
1527         (Port.check_for_leaks):
1528         * Scripts/webkitpy/port/darwin.py:
1529         (DarwinPort.check_for_leaks):
1530         - Rename redundant 'process_pid' argument to 'process_id'.
1531
1532         * Scripts/webkitpy/port/driver.py:
1533         (Driver.do_post_tests_work):
1534         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1535           longer the only command this sends to WebKitTestRunner.
1536         - If the `--leaks` switch is present, send the
1537           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1538           result using Port.set_webkit_processes().
1539         (Driver._parse_child_processes_output):
1540         - Add helper method to parse list of child process names and
1541           process IDs returned from WebKitTestRunner.
1542
1543         * Scripts/webkitpy/port/ios_device.py:
1544         (IOSDevicePort.check_for_leaks):
1545         - Rename redundant 'process_pid' argument to 'process_id'.
1546
1547         * Scripts/webkitpy/port/leakdetector.py:
1548         (LeakDetector._parse_leaks_output):
1549         - Return early if there is no leaks_output.
1550         (LeakDetector.check_for_leaks):
1551         - Rename redundant 'process_pid' argument to 'process_id'.
1552
1553         * Scripts/webkitpy/port/server_process.py:
1554         (ServerProcess.__init__):
1555         (ServerProcess.child_processes):
1556         (ServerProcess.set_child_processes):
1557         - Add instance variable to Port to store list of child process
1558           names and process IDs returned from WebKitTestRunner.
1559         (ServerProcess._start):
1560         - Clear self._child_processes.
1561         (ServerProcess.stop):
1562         - If self._child_processes is set, call
1563           self._port.check_for_leaks() for each child process.
1564
1565         * Scripts/webkitpy/port/server_process_unittest.py:
1566         (TrivialMockPort.check_for_leaks):
1567         - Rename redundant 'process_pid' argument to 'process_id'.
1568
1569         * Scripts/webkitpy/port/simulator_process.py:
1570         (SimulatorProcess.stop):
1571         - If self._child_processes is set, call
1572           self._port.check_for_leaks() for each child process.
1573
1574         * Scripts/webkitpy/port/watch_device.py:
1575         (WatchDevicePort.check_for_leaks):
1576         - Rename redundant 'process_pid' argument to 'process_id'.
1577
1578         * WebKitTestRunner/TestController.cpp:
1579         (WTR::TestController::dumpResponse):
1580         - Extract method from findAndDumpWorldLeaks() so that it may be
1581           reused by findAndDumpWebKitProcessIdentifiers().
1582         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1583         - Add method to output process name and process ID of both the
1584           WebContent and Networking processes.
1585         (WTR::TestController::findAndDumpWorldLeaks):
1586         - Fix missing newline in output when there were no abandoned
1587           documents.
1588         - Call dumpResponse() for extracted code.
1589         (WTR::TestController::handleControlCommand):
1590         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1591         - Use strncmp() instead of strcmp().
1592         - Call findAndDumpWebKitProcessIdentifiers() when
1593           "#LIST CHILD PROCESSES" command is sent.
1594         * WebKitTestRunner/TestController.h:
1595         (WTR::TestController::dumpResponse):
1596         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1597         - Declare methods.
1598
1599 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1600
1601         Unreviewed. Add GLib API test cases after r243434.
1602
1603         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1604         (testWebViewActiveURI):
1605         (serverCallback):
1606         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1607         (sendRequestCallback):
1608
1609 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1610
1611         Geolocation request not complete when watch request was started in a different web process
1612         https://bugs.webkit.org/show_bug.cgi?id=195996
1613
1614         Reviewed by Alex Christensen.
1615
1616         Add a test case.
1617
1618         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1619         (TestWebKitAPI::runJavaScriptAlert):
1620         (TestWebKitAPI::TEST):
1621
1622 2019-03-26  Keith Rollin  <krollin@apple.com>
1623
1624         Update the way generate-xcfilelists returns strings from functions
1625         https://bugs.webkit.org/show_bug.cgi?id=195975
1626         <rdar://problem/49040807>
1627
1628         Reviewed by Dean Jackson.
1629
1630         There are places where generate-xcfilelists executes assignments with
1631         statements like:
1632
1633             FOO=$(some_function)
1634
1635         where "some_function" return a string by echoing it. E.g.
1636
1637             some_function()
1638             {
1639                 echo "Hello, World"
1640             }
1641
1642         This is a common idiom, but it has a problem if "some_function" needs
1643         to call "exit" in an attempt to halt the entire script right then and
1644         there. Since "some_function" is called inside of $(), it's being
1645         executed in a sub-shell. Calling exit in that sub-shell simply exits
1646         that shell; it doesn't not exit the outer shell in which the main part
1647         of the script is still running. As such, the main script keeps
1648         executing when the intent was for the script to halt.
1649
1650         The solution to this is to use a different idiom for returning
1651         strings. The one we now is to pass in the name of the variable to
1652         receive the string result:
1653
1654             some_function()
1655             {
1656                 variable_name=$1
1657                 eval $variable_name ="Hello, World"
1658             }
1659
1660         The call site now looks like
1661
1662             some_function FOO
1663
1664         Because there's no invocation of a sub-shell, some_function can now
1665         call "exit" if it wants to, and the entire script will exit at that
1666         point.
1667
1668         * Scripts/generate-xcfilelists:
1669
1670 2019-03-26  Chris Dumez  <cdumez@apple.com>
1671
1672         Add basic layout test coverage for File Picker on iOS
1673         https://bugs.webkit.org/show_bug.cgi?id=196265
1674
1675         Reviewed by Wenson Hsieh.
1676
1677         Add layout test infrastructure to test the file picker on iOS.
1678
1679         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1680         (WTR::UIScriptController::dismissFilePicker):
1681         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1682         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1683         (WTR::UIScriptController::dismissFilePicker):
1684         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1685         * WebKitTestRunner/TestController.cpp:
1686         (WTR::TestController::createWebViewWithOptions):
1687         (WTR::updateTestOptionsFromTestHeader):
1688         * WebKitTestRunner/TestOptions.h:
1689         (WTR::TestOptions::hasSameInitializationOptions const):
1690         * WebKitTestRunner/ios/TestControllerIOS.mm:
1691         (overridePresentViewController):
1692         (WTR::TestController::platformInitialize):
1693         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1694         (WTR::UIScriptController::dismissFilePicker):
1695
1696 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1697
1698         Implement async paste method on UIWKInteractionViewProtocol
1699         https://bugs.webkit.org/show_bug.cgi?id=196267
1700         <rdar://problem/49236346>
1701
1702         Reviewed by Tim Horton.
1703
1704         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1705         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1706         are now a part of all iOS 12 internal SDKs.
1707
1708         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1709
1710         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1711         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1712
1713         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1714         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1715         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1716         * TestWebKitAPI/ios/UIKitSPI.h:
1717
1718 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1719
1720         [ews-build] Use PostgreSQL for ews.webkit.org database
1721         https://bugs.webkit.org/show_bug.cgi?id=196270
1722
1723         Reviewed by Lucas Forschler.
1724
1725         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1726
1727 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1728
1729         [ews] Reset simctl states on reboot
1730         https://bugs.webkit.org/show_bug.cgi?id=196260
1731
1732         Rubber-stamped by Aakash Jain.
1733
1734         * EWSTools/start-queue-mac.sh:
1735
1736 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1737
1738         [ews-build] Use PostgreSQL for ews-build database
1739         https://bugs.webkit.org/show_bug.cgi?id=196229
1740
1741         Reviewed by Lucas Forschler.
1742
1743         * BuildSlaveSupport/ews-build/master.cfg:
1744
1745 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1746
1747         [ews-build] Get master_hostname dynamically in master.cfg
1748         https://bugs.webkit.org/show_bug.cgi?id=196255
1749
1750         Reviewed by Lucas Forschler.
1751
1752         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
1753         send events data in test mode.
1754
1755 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1756
1757         [ews-app] Set db_constraint to False for Foreign Keys
1758         https://bugs.webkit.org/show_bug.cgi?id=196252
1759
1760         Reviewed by Lucas Forschler.
1761
1762         * BuildSlaveSupport/ews-app/ews/models/build.py:
1763         * BuildSlaveSupport/ews-app/ews/models/step.py:
1764
1765 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1766
1767         [ews-build] is_test_mode_enabled should default to True
1768         https://bugs.webkit.org/show_bug.cgi?id=196248
1769
1770         Reviewed by Lucas Forschler.
1771
1772         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
1773
1774 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1775
1776         [ews-app] Add webkitperl to ENABLED_QUEUES
1777         https://bugs.webkit.org/show_bug.cgi?id=196253
1778
1779         Reviewed by Lucas Forschler.
1780
1781         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1782
1783 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
1784
1785         Address NSWindow sometimes using WebKitTestRunnerEvent too early
1786         https://bugs.webkit.org/show_bug.cgi?id=196211
1787         rdar://problem/49110552
1788
1789         Reviewed by Tim Horton.
1790
1791         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
1792         Make sure that EventSenderProxy always exists when running tests. We used to create
1793         it when resetting before the first test, which is a bit too late.
1794
1795         * WebKitTestRunner/TestController.h:
1796         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1797         (WTR::TestController::platformCreateWebView):
1798         (WTR::TestController::platformCreateOtherPage):
1799         (WTR::TestController::finishCreatingPlatformWebView):
1800         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1801         (WTR::PlatformWebView::PlatformWebView):
1802         Moved some code that made NSWindow use NSEvent during web view creation. We may
1803         need to move more if some other case us found, but this is enough for now.
1804
1805 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1806
1807         Unreviewed. Fix typo in GLib geolocation API after r243285.
1808
1809         gelocation -> geolocation.
1810
1811         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
1812         (testGeolocationManagerWatchPosition):
1813
1814 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1815
1816         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1817         https://bugs.webkit.org/show_bug.cgi?id=196213
1818
1819         Reviewed by Geoff Garen.
1820
1821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1822         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1823         (credentialWithIdentityAndKeychainPath):
1824         (-[ChallengeDelegate webView:didFinishNavigation:]):
1825         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1826         (TestWebKitAPI::TEST):
1827
1828 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1829
1830         Expected shouldn't assume its contained types are copyable
1831         https://bugs.webkit.org/show_bug.cgi?id=195986
1832
1833         Reviewed by JF Bastien.
1834
1835         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1836         (TestWebKitAPI::NonCopyable::operator== const):
1837         (TestWebKitAPI::NonCopyable::operator!= const):
1838         (TestWebKitAPI::TEST):
1839
1840 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1841
1842         Remove some now-unnecessary dynamic class lookup
1843         https://bugs.webkit.org/show_bug.cgi?id=196237
1844
1845         Reviewed by Simon Fraser.
1846
1847         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1848         (makeRequest):
1849         (TEST):
1850
1851 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1852
1853         Unreviewed, rolling out r243450.
1854
1855         AppleWin and WinCairo port builds get broken.
1856
1857         Reverted changeset:
1858
1859         "Add test for fix of #196095"
1860         https://bugs.webkit.org/show_bug.cgi?id=196097
1861         https://trac.webkit.org/changeset/243450
1862
1863 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1864
1865         Unreviewed, rolling out r243465.
1866         https://bugs.webkit.org/show_bug.cgi?id=196226
1867
1868         the test doesn't build (Requested by thorton on #webkit).
1869
1870         Reverted changeset:
1871
1872         "Do not terminate the NetworkProcess if a third party
1873         application sends a NSCredential with a SecIdentityRef"
1874         https://bugs.webkit.org/show_bug.cgi?id=196213
1875         https://trac.webkit.org/changeset/243465
1876
1877 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1878
1879         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1880         https://bugs.webkit.org/show_bug.cgi?id=196213
1881
1882         Reviewed by Geoff Garen.
1883
1884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1885         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1886         (credentialWithIdentityAndKeychainPath):
1887         (-[ChallengeDelegate webView:didFinishNavigation:]):
1888         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1889         (TestWebKitAPI::TEST):
1890
1891 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1892
1893         [ews-build] Gracefully handle missing patch_id in events
1894         https://bugs.webkit.org/show_bug.cgi?id=196216
1895
1896         Reviewed by Lucas Forschler.
1897
1898         * BuildSlaveSupport/ews-build/events.py:
1899
1900 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1901
1902         [ews-build] use lz4 compression for improving buildbot performance
1903         https://bugs.webkit.org/show_bug.cgi?id=196155
1904
1905         Reviewed by Lucas Forschler.
1906
1907         * BuildSlaveSupport/ews-build/master.cfg:
1908
1909 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1910
1911         Pull some API testing helper methods out of TestWKWebView
1912         https://bugs.webkit.org/show_bug.cgi?id=196212
1913
1914         Reviewed by Tim Horton.
1915
1916         Refactor some more API testing utility methods, so that they can be used in
1917         tests that do not use TestWKWebView.
1918
1919         * TestWebKitAPI/cocoa/TestWKWebView.h:
1920         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1921         (-[WKWebView loadTestPageNamed:]):
1922         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1923         (-[WKWebView synchronouslyLoadHTMLString:]):
1924         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1925         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1926         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1927         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1928         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1929
1930 2019-03-25  Jer Noble  <jer.noble@apple.com>
1931
1932         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1933         https://bugs.webkit.org/show_bug.cgi?id=196097
1934
1935         Reviewed by Eric Carlson.
1936
1937         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1938
1939         * DumpRenderTree/mac/DumpRenderTree.mm:
1940         (resetWebPreferencesToConsistentValues):
1941         * WebKitTestRunner/TestController.cpp:
1942         (WTR::TestController::resetPreferencesToConsistentValues):
1943
1944 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1945
1946         Pull IPadUserInterfaceSwizzler out into a separate header file
1947         https://bugs.webkit.org/show_bug.cgi?id=196193
1948
1949         Reviewed by Anders Carlsson.
1950
1951         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1952         be used in other API tests.
1953
1954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1955         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1956         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1957         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1958         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1959         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1960         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1961
1962 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1963
1964         Remove NavigatorContentUtils in WebCore/Modules
1965         https://bugs.webkit.org/show_bug.cgi?id=196070
1966
1967         Reviewed by Alex Christensen.
1968
1969         NavigatorContentUtils was to support the custom scheme spec [1].
1970         However, in WebKit side, no port has supported the feature in
1971         WebKit layer after EFL port was removed. So there has been the
1972         only IDL implementation of the NavigatorContentUtils in WebCore.
1973         So we don't need to keep the implementation in WebCore anymore.
1974
1975         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1976
1977         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1978
1979 2019-03-24  Andy Estes  <aestes@apple.com>
1980
1981         [watchOS] Remove unused Proximity Networking code
1982         https://bugs.webkit.org/show_bug.cgi?id=196188
1983
1984         Reviewed by Tim Horton.
1985
1986         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1987         (TEST):
1988
1989 2019-03-23  Keith Miller  <keith_miller@apple.com>
1990
1991         Refactor clz/ctz and fix getLSBSet.
1992         https://bugs.webkit.org/show_bug.cgi?id=196162
1993
1994         Reviewed by Saam Barati.
1995
1996         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1997
1998         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1999         (TestWebKitAPI::TEST):
2000
2001 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2002
2003         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2004         https://bugs.webkit.org/show_bug.cgi?id=196143
2005
2006         Reviewed by Michael Catanzaro.
2007
2008         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2009         directories.
2010
2011         * Scripts/webkitpy/style/checkers/cpp.py:
2012         (check_identifier_name_in_declaration):
2013         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2014         (WebKitStyleTest.test_names):
2015
2016 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2017
2018         [Flatpak] Manifest expanding fails for qt WPE extension
2019         https://bugs.webkit.org/show_bug.cgi?id=196148
2020
2021         Reviewed by Alex Christensen.
2022
2023         * flatpak/flatpakutils.py:
2024         (expand_submodules_recurse): The last recurse manifest expand
2025         iteration might lead to a single module so take it into account
2026         and don't try to recurse further.
2027
2028 2019-03-22  Chris Dumez  <cdumez@apple.com>
2029
2030         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2031         https://bugs.webkit.org/show_bug.cgi?id=195348
2032         <rdar://problem/48622090>
2033
2034         Reviewed by Alex Christensen.
2035
2036         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2037         to NO when test.options().shouldIgnoreMetaViewport is false.
2038
2039         * WebKitTestRunner/ios/TestControllerIOS.mm:
2040         (WTR::TestController::platformConfigureViewForTest):
2041
2042 2019-03-22  Chris Dumez  <cdumez@apple.com>
2043
2044         Prewarmed processes should be usable with any website data store
2045         https://bugs.webkit.org/show_bug.cgi?id=196104
2046
2047         Reviewed by Alex Christensen.
2048
2049         Add API test coverage.
2050
2051         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2052         (runInitialWarmedProcessUsedTest):
2053         (TEST):
2054
2055 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2056
2057         Back out local changes to Alex's Subversion working directory
2058
2059         They were accidentally committed.
2060
2061         * Scripts/webkitpy/common/system/abstractexecutive.py:
2062         (AbstractExecutive.wait_newest):
2063         * Scripts/webkitpy/common/system/executive.py:
2064         (Executive.running_pids):
2065         * Scripts/webkitpy/common/system/executive_mock.py:
2066         (MockExecutive.running_pids):
2067         * Scripts/webkitpy/common/system/executive_unittest.py:
2068         (ExecutiveTest.serial_test_running_pids):
2069         * Scripts/webkitpy/port/darwin.py:
2070         (DarwinPort.check_for_leaks):
2071         * Scripts/webkitpy/port/leakdetector.py:
2072         (LeakDetector.check_for_leaks):
2073         - This was the hack attached to Bug 193772.
2074
2075         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2076         (+[WebKitTestRunnerEvent mouseLocation]):
2077         - This works around a crash on an internal build.
2078
2079 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2080
2081         Fix the build after r243354
2082         https://bugs.webkit.org/show_bug.cgi?id=196138
2083         <rdar://problem/49145951>
2084
2085         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2086         (TEST):
2087         * TestWebKitAPI/ios/UIKitSPI.h:
2088
2089 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2090
2091         Adopt UIWKDocumentContext
2092         https://bugs.webkit.org/show_bug.cgi?id=196040
2093         <rdar://problem/48642440>
2094
2095         Reviewed by Ryosuke Niwa.
2096
2097         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2098         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2099         (makeRequest):
2100         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2101         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2102         (applyStyle):
2103         (TEST):
2104         Add tests for UIWKDocumentContext.
2105
2106         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2107         (TEST):
2108         (recursiveFindWKContentView): Deleted.
2109         * TestWebKitAPI/cocoa/TestWKWebView.h:
2110         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2111         (recursiveFindWKContentView):
2112         (-[TestWKWebView wkContentView]):
2113         * TestWebKitAPI/ios/UIKitSPI.h:
2114         Share the WKContentView finding code between tests.
2115
2116 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2117
2118         [iOS WK2] Turn on async overflow scrolling by default
2119         https://bugs.webkit.org/show_bug.cgi?id=196011
2120         rdar://problem/48453859
2121
2122         Reviewed by Antti Koivisto.
2123         
2124         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2125         since so many basic layout tests have different results when compositing is triggered for
2126         overflow.
2127         
2128         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2129
2130         * WebKitTestRunner/TestController.cpp:
2131         (WTR::TestController::resetPreferencesToConsistentValues):
2132
2133 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2134
2135         [ews-build] Retry API test in case of failures
2136         https://bugs.webkit.org/show_bug.cgi?id=196004
2137
2138         Reviewed by Lucas Forschler.
2139
2140         * BuildSlaveSupport/ews-build/steps.py:
2141         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2142         (CompileWebKitToT.doStepIf): Ditto.
2143         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2144         (ReRunAPITests): Re-run API tests.
2145         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2146         (RunAPITestsWithoutPatch): Run API tests without patch.
2147         (RunAPITestsWithoutPatch.doStepIf):
2148         (RunAPITestsWithoutPatch.hideStepIf):
2149         (RunAPITestsWithoutPatch.evaluateCommand):
2150         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2151         (AnalyzeAPITestsResults.start):
2152         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2153         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2154         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2155         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2156
2157 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2158
2159         [ews-build] Update queues configurations
2160         https://bugs.webkit.org/show_bug.cgi?id=196074
2161
2162         Reviewed by Dewei Zhu.
2163
2164         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2165         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2166
2167 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2168
2169         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2170         https://bugs.webkit.org/show_bug.cgi?id=195680
2171         <rdar://problem/48903534>
2172
2173         Unreviewed infrastructure fix.
2174
2175         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2176         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2177
2178 2019-03-21  Andy Estes  <aestes@apple.com>
2179
2180         [iOS] Apple Pay should be available in documents with no user agent scripts
2181         https://bugs.webkit.org/show_bug.cgi?id=196061
2182         <rdar://problem/48649391>
2183
2184         Reviewed by Brady Eidson.
2185
2186         Added API tests and related infrastructure.
2187
2188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2189         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2190         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2191         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2192         (TestWebKitAPI::TEST):
2193         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2194         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2195         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2196         * TestWebKitAPI/cocoa/TestProtocol.mm:
2197         (-[TestProtocol startLoading]):
2198         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2199         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2200         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2201         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2202
2203 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2204
2205         REGRESSSION (r243297): webkitpy tests broken
2206         https://bugs.webkit.org/show_bug.cgi?id=196108
2207
2208         Reviewed by Aakash Jain.
2209
2210         r243297 updated contributors.json, which broke a few unit tests.
2211
2212         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2213         (IRCCommandTest.test_whois):
2214         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2215
2216 2019-03-21  Chris Dumez  <cdumez@apple.com>
2217
2218         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2219         https://bugs.webkit.org/show_bug.cgi?id=196041
2220         <rdar://problem/49083230>
2221
2222         Reviewed by Alex Christensen.
2223
2224         Add API test coverage.
2225
2226         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2227         (TEST):
2228
2229 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2230
2231         Add SPI to inform applications of WKContentRuleList actions
2232         https://bugs.webkit.org/show_bug.cgi?id=195965
2233         <rdar://problem/42664365>
2234
2235         Reviewed by Geoff Garen.
2236
2237         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2238         (TestWebKitAPI::allActionsForResourceLoad):
2239         (TestWebKitAPI::testRequest):
2240         (TestWebKitAPI::TEST_F):
2241         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2242         (Notification::description):
2243         (Notification::operator== const):
2244         (toVector):
2245         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2246         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2247         (makeContentRuleList):
2248         (TEST):
2249         (makeWarnContentRuleList): Deleted.
2250
2251 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2252
2253         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2254         https://bugs.webkit.org/show_bug.cgi?id=196088
2255
2256         Reviewed by Brian Burg.
2257
2258         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2259         Support checks when only one platform is specified. Also deprecate macosx() and
2260         force the use of macos() instead.
2261
2262         * Scripts/webkitpy/style/checkers/cpp.py:
2263         (check_min_versions_of_wk_api_available):
2264         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2265         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2266
2267 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2268
2269         Update status inactive committers' status to 'contributor'.
2270
2271         * Scripts/webkitpy/common/config/contributors.json:
2272
2273 2019-03-21  Xan Lopez  <xan@igalia.com>
2274
2275         [JSC][x86] Drop support for x87 floating point
2276         https://bugs.webkit.org/show_bug.cgi?id=194853
2277
2278         Reviewed by Don Olmstead.
2279
2280         Force SSE2 on x86/32bit builds.
2281
2282         * Scripts/webkitdirs.pm:
2283         (generateBuildSystemFromCMakeProject):
2284
2285 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2286
2287         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2288         https://bugs.webkit.org/show_bug.cgi?id=196073
2289
2290         Reviewed by Michael Catanzaro.
2291
2292         Add test cases to check functions and constructors with no arguments but receiving user data.
2293
2294         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2295         (checkUserData):
2296         (testJSCFunction):
2297         (fooCreateWithUserData):
2298         (testJSCClass):
2299
2300 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2301
2302         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2303
2304         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2305
2306         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2307
2308 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2309
2310         [GTK][WPE] Add API to provide geolocation information
2311         https://bugs.webkit.org/show_bug.cgi?id=195940
2312
2313         Reviewed by Michael Catanzaro.
2314
2315         Add a new test to check the new API.
2316
2317         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2318         (testGeolocationManagerCurrentPosition):
2319         (testGeolocationManagerWatchPosition):
2320         (beforeAll):
2321         (afterAll):
2322         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2323         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2324         (beforeAll): Ditto.
2325         * TestWebKitAPI/glib/CMakeLists.txt:
2326
2327 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2328
2329         [GLib] Returning G_TYPE_OBJECT from a method does not work
2330         https://bugs.webkit.org/show_bug.cgi?id=195574
2331
2332         Reviewed by Michael Catanzaro.
2333
2334         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2335
2336         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2337         (getGFile):
2338         (getParent):
2339         (createGString):
2340         (getGString):
2341         (getGStringCopyWillRaise):
2342         (getGStringCopy):
2343         (getGStringStr):
2344         (getGStringLen):
2345         (freeGString):
2346         (testJSCClass):
2347
2348 2019-03-20  Saam Barati  <sbarati@apple.com>
2349
2350         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2351         https://bugs.webkit.org/show_bug.cgi?id=195721
2352
2353         Reviewed by Filip Pizlo.
2354
2355         * Scripts/run-javascriptcore-tests:
2356
2357 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2358
2359         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2360         https://bugs.webkit.org/show_bug.cgi?id=196049
2361
2362         Reviewed by Tim Horton.
2363
2364         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2365         overflow scrolling in general, so rename it.
2366
2367         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2368
2369 2019-03-20  Daniel Bates  <dabates@apple.com>
2370
2371         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2372         https://bugs.webkit.org/show_bug.cgi?id=196031
2373         <rdar://problem/49078172>
2374
2375         Reviewed by Tim Horton.
2376
2377         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2378         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2379         same code path used when the Done button is pressed to dismiss the <select> picker.
2380
2381         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2382         (TestWebKitAPI::TEST):
2383
2384 2019-03-20  Chris Dumez  <cdumez@apple.com>
2385
2386         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2387         https://bugs.webkit.org/show_bug.cgi?id=196029
2388         <rdar://problem/48954651>
2389
2390         Reviewed by Tim Horton.
2391
2392         Add API test coverage.
2393
2394         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2395
2396 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2397
2398         [ews-build] Improve failure summary string for ApplyPatch step
2399         https://bugs.webkit.org/show_bug.cgi?id=195995
2400
2401         Reviewed by Alexey Proskuryakov.
2402
2403         * BuildSlaveSupport/ews-build/steps.py:
2404         (ApplyPatch.getResultSummary): Override getResultSummary.
2405
2406 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2407
2408         AX: Implement support for new meter ARIA role
2409         https://bugs.webkit.org/show_bug.cgi?id=195966
2410
2411         Reviewed by Chris Fleizach.
2412
2413         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2414         to AXLevelIndicator.
2415
2416         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2417
2418 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2419
2420         [WebAuthN] Implement FIDO AppID extension
2421         https://bugs.webkit.org/show_bug.cgi?id=143491
2422         <rdar://problem/48298273>
2423
2424         Reviewed by Brent Fulgham.
2425
2426         Add a test that covers the new flag of convertToU2fSignCommand.
2427
2428         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2429         (TestWebKitAPI::TEST):
2430         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2431         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2432         (TestWebKitAPI::TEST):
2433
2434 2019-03-19  Keith Rollin  <krollin@apple.com>
2435
2436         Add support for more platforms to generate-xcfilelists
2437         https://bugs.webkit.org/show_bug.cgi?id=195977
2438
2439         Reviewed by Alexey Proskuryakov.
2440
2441         generate-xcfilelists incorrectly complains when involved with building
2442         WebKit for iphonesimulator:
2443
2444             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2445             …
2446             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2447
2448         Address this by teaching generate-xcfilelists about more platforms.
2449
2450         * Scripts/generate-xcfilelists:
2451
2452 2019-03-19  John Wilander  <wilander@apple.com>
2453
2454         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2455         https://bugs.webkit.org/show_bug.cgi?id=195923
2456         <rdar://problem/49001272>
2457
2458         Reviewed by Alex Christensen.
2459
2460         This patch does the following to the TestRunner:
2461         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2462         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2463         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2464
2465         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2466         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2467         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2468         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2469         * WebKitTestRunner/TestController.cpp:
2470         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2471         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2472         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2473         * WebKitTestRunner/TestController.h:
2474         * WebKitTestRunner/TestInvocation.cpp:
2475         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2476
2477 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2478
2479         [CMake] Support more clang and gcc sanitizers
2480         https://bugs.webkit.org/show_bug.cgi?id=195956
2481
2482         Reviewed by Michael Catanzaro.
2483
2484         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2485
2486 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2487
2488         [ews-build] Improve summary for PrintConfiguration step
2489         https://bugs.webkit.org/show_bug.cgi?id=195945
2490
2491         Reviewed by Lucas Forschler.
2492
2493         * BuildSlaveSupport/ews-build/steps.py:
2494         (PrintConfiguration.getResultSummary): Override getResultSummary.
2495
2496 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2497
2498         [ews-build] Improve summary for CheckOutSource step
2499         https://bugs.webkit.org/show_bug.cgi?id=195963
2500
2501         Reviewed by Lucas Forschler.
2502
2503         * BuildSlaveSupport/ews-build/steps.py:
2504         (CheckOutSource.getResultSummary):
2505
2506 2019-03-19  Daniel Bates  <dabates@apple.com>
2507
2508         [iOS] Focus not preserved when switching between tabs
2509         https://bugs.webkit.org/show_bug.cgi?id=195820
2510         <rdar://problem/43614450>
2511
2512         Reviewed by Brent Fulgham.
2513
2514         Add tests to ensure that we restore focus when resigning and becoming first responder.
2515
2516         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2517         (TestWebKitAPI::TEST):
2518
2519 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2520
2521         Make WTFLogChannelState and WTFLogLevel enum classes
2522         https://bugs.webkit.org/show_bug.cgi?id=195904
2523
2524         Reviewed by Eric Carlson.
2525
2526         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2527         (TestWebKitAPI::TEST_F):
2528
2529 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2530
2531         [GStreamer][EME] Backported mssdemux protection data crash fix
2532         https://bugs.webkit.org/show_bug.cgi?id=195918
2533
2534         Reviewed by Philippe Normand.
2535
2536         * gstreamer/jhbuild.modules:
2537         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2538
2539 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2540
2541         Unreviewed, rolling out r243132.
2542
2543         Broke GTK build
2544
2545         Reverted changeset:
2546
2547         "Make WTFLogChannelState and WTFLogLevel enum classes"
2548         https://bugs.webkit.org/show_bug.cgi?id=195904
2549         https://trac.webkit.org/changeset/243132
2550
2551 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2552
2553         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2554
2555         * Scripts/webkitdirs.pm:
2556         (builtDylibPathForName): Adjust the shared library name that's changed
2557         with the API version bump in r243073.
2558
2559 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2560
2561         Make WTFLogChannelState and WTFLogLevel enum classes
2562         https://bugs.webkit.org/show_bug.cgi?id=195904
2563
2564         Reviewed by Eric Carlson.
2565
2566         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2567         (TestWebKitAPI::TEST_F):
2568
2569 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2570
2571         Disable flaky test added in r2431100
2572         https://webkit.org/b/195785
2573
2574         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2575         (TestWebKitAPI::TEST):
2576         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2577
2578 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2579
2580         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2581         https://bugs.webkit.org/show_bug.cgi?id=195916
2582
2583         Reviewed by Tim Horton.
2584
2585         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2586         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2587
2588 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2589
2590         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2591
2592         * Scripts/webkitpy/common/config/contributors.json:
2593
2594 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2595
2596         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2597         https://bugs.webkit.org/show_bug.cgi?id=195785
2598
2599         Reviewed by Geoffrey Garen.
2600
2601         * TestWebKitAPI/TCPServer.cpp: Added.
2602         (TestWebKitAPI::TCPServer::TCPServer):
2603         (TestWebKitAPI::TCPServer::~TCPServer):
2604         (TestWebKitAPI::TCPServer::socketBindListen):
2605         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2606         * TestWebKitAPI/TCPServer.h: Added.
2607         (TestWebKitAPI::TCPServer::port const):
2608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2609         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2610         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2611         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2612         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2613         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2614         (TestWebKitAPI::respondSlowly):
2615         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2616         (TestWebKitAPI::downloadAtRate):
2617         (TestWebKitAPI::TEST):
2618
2619 2019-03-18  Saam Barati  <sbarati@apple.com>
2620
2621         Add a plan file for JetStream 2
2622         https://bugs.webkit.org/show_bug.cgi?id=190734
2623
2624         Reviewed by Mark Lam.
2625
2626         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2627
2628 2019-03-18  Chris Dumez  <cdumez@apple.com>
2629
2630         Delay WebProcess launch until a load is triggered in a Web view
2631         https://bugs.webkit.org/show_bug.cgi?id=195758
2632         <rdar://problem/48126013>
2633
2634         Reviewed by Geoff Garen.
2635
2636         Add API test coverage. Also update some existing API tests to not expect
2637         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2638
2639         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2640         (TestWebKitAPI::TEST):
2641         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2642         (TestWebKitAPI::TEST):
2643         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2644         (TEST):
2645         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2646         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2647         (TEST):
2648         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2649         (TEST):
2650         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2651
2652 2019-03-18  Xan Lopez  <xan@igalia.com>
2653
2654         [CMake] Prevent potential warning when determining $architecture
2655         https://bugs.webkit.org/show_bug.cgi?id=195891
2656
2657         Reviewed by Michael Catanzaro.
2658
2659         It's possible for generateBuildSystemForCMakeProject to be called
2660         before determineArchitecture() is ever called. This will make the
2661         first eq check with $architecture to be bogus (and print a
2662         warning). Change that to an eq check with architecture(), which
2663         implicitly calls determineArchitecture() if needed, and change all
2664         the other similar cases in the method in the same way to prevent
2665         future bugs like this one.
2666
2667         * Scripts/webkitdirs.pm:
2668         (generateBuildSystemFromCMakeProject):
2669
2670 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2671
2672         [WPE] Tarballs generated with “make dist” cannot build documentation
2673         https://bugs.webkit.org/show_bug.cgi?id=195885
2674
2675         Reviewed by Carlos Garcia Campos.
2676
2677         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2678
2679 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2680
2681         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2682         https://bugs.webkit.org/show_bug.cgi?id=195883
2683
2684         Reviewed by Carlos Garcia Campos.
2685
2686         * gtkdoc/gtkdoc.py:
2687         (GTKDoc._run_command): When commands fail to run, include the full command line for
2688         the program invocation and the output it has generated on the standard error stream.
2689
2690 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2691
2692         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2693         https://bugs.webkit.org/show_bug.cgi?id=195786
2694
2695         Reviewed by Philippe Normand.
2696
2697         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2698         * wpe/jhbuild.modules: Ditto.
2699
2700 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2701
2702         [ews-build] Don't run clean builds on EWS builders
2703         https://bugs.webkit.org/show_bug.cgi?id=195851
2704
2705         Reviewed by Geoffrey Garen.
2706
2707         * BuildSlaveSupport/ews-build/factories.py:
2708
2709 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2710
2711         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2712         https://bugs.webkit.org/show_bug.cgi?id=195849
2713
2714         Reviewed by Chris Dumez.
2715
2716         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2717
2718         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2719         (runWebsiteDataStoreCustomPaths):
2720
2721 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2722
2723         webkitpy: Upload test results
2724         https://bugs.webkit.org/show_bug.cgi?id=195755
2725         <rdar://problem/48896182>
2726
2727         Reviewed by Aakash Jain.
2728
2729         Establish a new format for uploading results that is not tied to layout tests, apply
2730         that format to webkitpy tests.
2731
2732         * Scripts/webkitpy/common/checkout/scm/git.py:
2733         (Git.native_branch): Return what branch the current checkout is on.
2734         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2735         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2736         * Scripts/webkitpy/common/checkout/scm/svn.py:
2737         (SVN.native_branch): Ditto.
2738         * Scripts/webkitpy/common/system/platforminfo.py:
2739         (PlatformInfo.build_version): Return a build version for Mac.
2740         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2741         (MockPlatformInfo.__init__):
2742         (MockPlatformInfo.build_version):
2743         * Scripts/webkitpy/results: Added.
2744         * Scripts/webkitpy/results/__init__.py: Added.
2745         * Scripts/webkitpy/results/options.py: Added.
2746         (upload_options): OptParse list for upload options.
2747         * Scripts/webkitpy/results/upload.py: Added.
2748         (Upload): Class which enforces the upload format expected by the results server.
2749         (Upload.Expectations):
2750         (Upload.create_configuration):
2751         (Upload.create_commit):
2752         (Upload.create_details):
2753         (Upload.create_run_stats):
2754         (Upload.create_test_result):
2755         (Upload.__init__):
2756         (Upload.Encoder): Encode Upload object as json.
2757         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
2758         * Scripts/webkitpy/results/upload_unittest.py: Added.
2759         * Scripts/webkitpy/test/main.py:
2760         (Tester._parse_args): Add upload arguments.
2761         (Tester._run_tests): Allow results to be uploaded.
2762         * Scripts/webkitpy/test/runner.py:
2763         (Runner.__init__): Record which tests were run, rather than just counting them.
2764         (Runner.handle):
2765         * Scripts/webkitpy/test/runner_unittest.py:
2766         (RunnerTest.test_run):
2767         * Scripts/webkitpy/thirdparty/__init__.py:
2768         (AutoinstallImportHook.find_module): Add requests auto-install.
2769         (AutoinstallImportHook._install_requests):
2770         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2771         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
2772
2773 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2774
2775         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
2776         https://bugs.webkit.org/show_bug.cgi?id=195810
2777
2778         Reviewed by Tim Horton.
2779
2780         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
2781         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
2782         ending certain layout tests.
2783
2784         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2785         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2786         (-[TestRunnerWKWebView dealloc]):
2787         (-[TestRunnerWKWebView resetInteractionCallbacks]):
2788
2789         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
2790         helper method when destroying the web view, and when resetting state between tests.
2791
2792         * WebKitTestRunner/ios/TestControllerIOS.mm:
2793         (WTR::TestController::platformResetStateToConsistentValues):
2794
2795         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
2796
2797 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
2798
2799         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
2800         https://bugs.webkit.org/show_bug.cgi?id=190350
2801         <rdar://problem/45089503>
2802
2803         Reviewed by Geoffrey Garen.
2804
2805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2806         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2807         (TEST):
2808         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
2809         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
2810         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
2811         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
2812         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
2813         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2814         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2815         (runTest):
2816         (createDirectories):
2817         (TEST):
2818         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2819         (TEST):
2820         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2821         (TEST):
2822
2823 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2824
2825         Add support to WebPage for getting the contents as an attributed string.
2826         https://bugs.webkit.org/show_bug.cgi?id=195636
2827         rdar://problem/45055697
2828
2829         Reviewed by Tim Horton.
2830
2831         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2832         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2833
2834 2019-03-15  Chris Dumez  <cdumez@apple.com>
2835
2836         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2837         https://bugs.webkit.org/show_bug.cgi?id=195747
2838
2839         Reviewed by Geoff Garen.
2840
2841         Add API test coverage.
2842
2843         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2844
2845 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2846
2847         Unreviewed, rolling out r242952.
2848
2849         Causing API failures on iOS Simulator
2850
2851         Reverted changeset:
2852
2853         "[PSON] Make sure the WebProcessCache is leverage when
2854         relaunching a process after termination"
2855         https://bugs.webkit.org/show_bug.cgi?id=195747
2856         https://trac.webkit.org/changeset/242952
2857
2858 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2859
2860         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2861         https://bugs.webkit.org/show_bug.cgi?id=195740
2862
2863         Reviewed by Ross Kirsling.
2864
2865         window.open doesn't work for WebKitBrowserWindow because it is not
2866         implemented yet.
2867
2868         1. Implemented createNewPage callback of WKPageUIClient.
2869         2. Changed MainWindow to take a BrowserWindow factory function
2870           instead of BrowserWindowType to be flexible to create
2871           BrowserWindow with extra settings.
2872         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2873           because it is not relevant with MainWindow anymore.
2874
2875         * MiniBrowser/win/Common.cpp:
2876         (parseCommandLine):
2877         * MiniBrowser/win/Common.h:
2878         (CommandLineOptions::CommandLineOptions):
2879         * MiniBrowser/win/MainWindow.cpp:
2880         (MainWindow::MainWindow):
2881         (MainWindow::create):
2882         (MainWindow::init):
2883         (MainWindow::WndProc):
2884         * MiniBrowser/win/MainWindow.h:
2885         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2886         (PrintWebUIDelegate::createWebViewWithRequest):
2887         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2888         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2889         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2890         (WebKitBrowserWindow::updateProxySettings):
2891         (WebKitBrowserWindow::createNewPage):
2892         * MiniBrowser/win/WebKitBrowserWindow.h:
2893         * MiniBrowser/win/WinMain.cpp:
2894         (wWinMain):
2895
2896 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2897
2898         Make it possible to test scrolling tree layer manipulation more easily
2899         https://bugs.webkit.org/show_bug.cgi?id=195780
2900
2901         Reviewed by Tim Horton.
2902         
2903         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2904         cuts off communication of scrolling tree scrolls back to the web process
2905         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2906         allows tests to trigger scrolls which run the scrolling tree layer positioning
2907         logic, but never get another commit from the web process that might mask
2908         scrolling tree bugs.
2909         
2910         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2911         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2912         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2913
2914         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2915         (WTR::UIScriptController::scrollUpdatesDisabled const):
2916         (WTR::UIScriptController::setScrollUpdatesDisabled):
2917         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2918         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2919         (WTR::UIScriptController::scrollUpdatesDisabled const):
2920         (WTR::UIScriptController::setScrollUpdatesDisabled):
2921         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2922         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2923         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2924         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2925         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2926         * WebKitTestRunner/ios/TestControllerIOS.mm:
2927         (WTR::TestController::platformResetStateToConsistentValues):
2928         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2929         (WTR::UIScriptController::scrollUpdatesDisabled const):
2930         (WTR::UIScriptController::setScrollUpdatesDisabled):
2931
2932 2019-03-14  Youenn Fablet  <youenn@apple.com>
2933
2934         Move IDB storage in private browsing mode to NetworkProcess
2935         https://bugs.webkit.org/show_bug.cgi?id=195602
2936
2937         Reviewed by Brady Eidson.
2938
2939         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2940         (TEST):
2941
2942 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2943
2944         [ews-build] Make descriptionDone messages more readable
2945         https://bugs.webkit.org/show_bug.cgi?id=195760
2946
2947         Reviewed by Lucas Forschler.
2948
2949         * BuildSlaveSupport/ews-build/steps.py:
2950         * BuildSlaveSupport/ews-build/steps_unittest.py:
2951
2952 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2953
2954         [ews-build] Generate status-bubble hover-over messages
2955         https://bugs.webkit.org/show_bug.cgi?id=195680
2956
2957         Reviewed by Lucas Forschler.
2958
2959         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2960         (StatusBubble):
2961         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2962         on hover-over.
2963         (StatusBubble._iso_time):
2964         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2965         hover-over message.
2966         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2967
2968 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2969
2970         [ews-app] Gracefully handle the case when state_string is None
2971         https://bugs.webkit.org/show_bug.cgi?id=195753
2972
2973         Reviewed by Lucas Forschler.
2974
2975         * BuildSlaveSupport/ews-app/ews/models/build.py:
2976         * BuildSlaveSupport/ews-app/ews/models/step.py:
2977
2978 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2979
2980         [ews-app] Status bubble display pending for currently running build step
2981         https://bugs.webkit.org/show_bug.cgi?id=195744
2982
2983         Reviewed by Lucas Forschler.
2984
2985         * BuildSlaveSupport/ews-build/events.py:
2986         (Events.stepStarted): If state_string is pending, replace it with step name.
2987
2988 2019-03-14  Chris Dumez  <cdumez@apple.com>
2989
2990         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2991         https://bugs.webkit.org/show_bug.cgi?id=195750
2992
2993         Reviewed by Geoffrey Garen.
2994
2995         Add API test coverage.
2996
2997         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2998         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2999         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3000         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3001
3002 2019-03-14  Chris Dumez  <cdumez@apple.com>
3003
3004         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3005         https://bugs.webkit.org/show_bug.cgi?id=195747
3006
3007         Reviewed by Geoff Garen.
3008
3009         Add API test coverage.
3010
3011         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3012
3013 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3014
3015         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3016         https://bugs.webkit.org/show_bug.cgi?id=195725
3017         <rdar://problem/48545062>
3018
3019         Reviewed by Tim Horton.
3020
3021         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3022         handler is nil.
3023
3024         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3025         (TestWebKitAPI::TEST):
3026
3027 2019-03-13  Sam Weinig  <sam@webkit.org>
3028
3029         Add utility function to allow easy reverse range-based iteration of a container
3030         https://bugs.webkit.org/show_bug.cgi?id=195542
3031
3032         Reviewed by Antti Koivisto.
3033
3034         * TestWebKitAPI/CMakeLists.txt:
3035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3036         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3037         (TestWebKitAPI::TEST):
3038         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3039
3040 2019-03-13  Chris Dumez  <cdumez@apple.com>
3041
3042         Use a ServiceWorker process per registrable domain
3043         https://bugs.webkit.org/show_bug.cgi?id=195649
3044
3045         Reviewed by Youenn Fablet.
3046
3047         Update API test coverage.
3048
3049         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3050
3051 2019-03-13  Chris Dumez  <cdumez@apple.com>
3052
3053         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3054         https://bugs.webkit.org/show_bug.cgi?id=195684
3055         <rdar://problem/48294714>
3056
3057         Reviewed by Antti Koivisto.
3058
3059         Add API test coverage.
3060
3061         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3062
3063 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3064
3065         [ews-app] Remove unused patch view
3066         https://bugs.webkit.org/show_bug.cgi?id=195669
3067
3068         Reviewed by Lucas Forschler.
3069
3070         * BuildSlaveSupport/ews-app/ews/urls.py:
3071         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3072
3073 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3074
3075         [ews-app] Use Buildbot result code variables
3076         https://bugs.webkit.org/show_bug.cgi?id=195668
3077
3078         Reviewed by Alexey Proskuryakov.
3079
3080         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3081         (Buildbot): Added Buildbot result code variables.
3082         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3083         (StatusBubble._build_bubble): Used Buildbot result code variables.
3084
3085 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3086
3087         [Flatpak] Expand submodule recursively
3088         https://bugs.webkit.org/show_bug.cgi?id=195672
3089
3090         Building WPE with flatpak was impossible without that as it was raising an exception.
3091         Also update wpebackend-fdo to match what is built in jhbuild
3092
3093         Reviewed by Philippe Normand.
3094
3095         * flatpak/flatpakutils.py:
3096         (expand_submodules_recurse):
3097         (expand_manifest):
3098         * flatpak/org.webkit.WPEModules.yaml:
3099
3100 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3101
3102         [ews-app] status bubble should be hidden for certain builds
3103         https://bugs.webkit.org/show_bug.cgi?id=194597
3104
3105         Reviewed by Dewei Zhu.
3106
3107         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3108         (StatusBubble._build_bubble):
3109         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3110         because the patch didn't have relevant changes.
3111         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3112         in production yet.
3113
3114 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3115
3116         [Win] Fix a slew of simple clang-cl warnings.
3117         https://bugs.webkit.org/show_bug.cgi?id=195652
3118
3119         Reviewed by Don Olmstead.
3120
3121         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3122         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3123
3124 2019-03-12  Justin Fan  <justin_fan@apple.com>
3125
3126         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3127         https://bugs.webkit.org/show_bug.cgi?id=195518
3128         <rdar://problem/46322356>
3129
3130         Reviewed by Myles C. Maxfield.
3131
3132         * DumpRenderTree/DerivedSources-input.xcfilelist:
3133         * DumpRenderTree/DerivedSources-output.xcfilelist:
3134
3135 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3136
3137         Unreviewed, rolling out r242825.
3138         https://bugs.webkit.org/show_bug.cgi?id=195648
3139
3140         "Broke webkitpy tests with my change to
3141         lldb_dump_class_layout.py" (Requested by rmorisset on
3142         #webkit).
3143
3144         Reverted changeset:
3145
3146         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3147         classes with suspicious padding"
3148         https://bugs.webkit.org/show_bug.cgi?id=195573
3149         https://trac.webkit.org/changeset/242825
3150
3151 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3152
3153         [ews-build] Show status bubbles while the patch is waiting in queue
3154         https://bugs.webkit.org/show_bug.cgi?id=195618
3155
3156         Reviewed by Lucas Forschler.
3157
3158         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3159         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3160         enabled in initial deployment.
3161         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3162         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3163         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3164         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3165         (StatusBubble._build_bubbles_for_patch):
3166
3167 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3168
3169         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3170         https://bugs.webkit.org/show_bug.cgi?id=195573
3171
3172         Reviewed by Simon Fraser.
3173
3174         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3175
3176         * Scripts/dump-class-layout:
3177         (main):
3178         * lldb/lldb_dump_class_layout.py:
3179         (ClassLayout.__init__):
3180         (ClassLayout._compute_padding_recursive):
3181         (LLDBDebuggerInstance.dump_layout_for_classname):
3182         (LLDBDebuggerInstance):
3183         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3184         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3185
3186 2019-03-12  Chris Dumez  <cdumez@apple.com>
3187
3188         Device Orientation access permission should be denied unless explicitly granted by the client
3189         https://bugs.webkit.org/show_bug.cgi?id=195625
3190
3191         Reviewed by Youenn Fablet.
3192
3193         add API test coverage.
3194
3195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3196         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3197         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3198         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3199         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3200         (runDeviceOrientationTest):
3201         (TEST):
3202         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3203         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3204
3205 2019-03-12  Jer Noble  <jer.noble@apple.com>
3206
3207         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3208         https://bugs.webkit.org/show_bug.cgi?id=195137
3209         <rdar://problem/48810307>
3210
3211         Reviewed by Eric Carlson.
3212
3213         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3214         (TestWebKitAPI::TEST):
3215
3216 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3217
3218         [ews-build] Change urls from uat to production
3219         https://bugs.webkit.org/show_bug.cgi?id=195566
3220
3221         Reviewed by Lucas Forschler.
3222
3223         * BuildSlaveSupport/ews-app/ews/config.py:
3224         * BuildSlaveSupport/ews-build/events.py:
3225         * BuildSlaveSupport/ews-build/steps.py:
3226
3227 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3228
3229         [ews-build] change max_builds for local-worker to 1
3230         https://bugs.webkit.org/show_bug.cgi?id=195568
3231
3232         Reviewed by Lucas Forschler.
3233
3234         * BuildSlaveSupport/ews-build/loadConfig.py:
3235
3236 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3237
3238         Fix the build
3239
3240         * TestRunnerShared/spi/PencilKitTestSPI.h:
3241         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3242
3243 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3244
3245         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3246         https://bugs.webkit.org/show_bug.cgi?id=194131
3247
3248         Reviewed by Michael Catanzaro.
3249
3250         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3251         (uriChanged):
3252         (testUnfinishedSubresourceLoad):
3253         (serverCallback):
3254         (beforeAll):
3255
3256 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3257
3258         WTF::Expected should use std::addressof instead of operator&
3259         https://bugs.webkit.org/show_bug.cgi?id=195604
3260
3261         Reviewed by Myles Maxfield.
3262
3263         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3264         (TestWebKitAPI::Unique::Unique):
3265         (TestWebKitAPI::Unique::operator&):
3266         (TestWebKitAPI::TEST):
3267
3268 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3269
3270         Add Optional to Forward.h.
3271         https://bugs.webkit.org/show_bug.cgi?id=195586
3272
3273         Reviewed by Darin Adler.
3274
3275         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3276         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3277         Remove unnecessary includes from headers.
3278
3279 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3280
3281         Add testing API to hit-test and scroll overflow scrollers
3282         https://bugs.webkit.org/show_bug.cgi?id=195278
3283
3284         Reviewed by Antti Koivisto.
3285         
3286         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3287         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3288         
3289         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3290
3291         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3292         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3293         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3294         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3295         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3296         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3297         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3298         (WTR::enclosingScrollViewIncludingSelf):
3299         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3300
3301 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3302
3303         API test WebKit.RequestTextInputContext fails on iOS
3304         https://bugs.webkit.org/show_bug.cgi?id=195585
3305
3306         Reviewed by Wenson Hsieh and Simon Fraser.
3307
3308         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3309         (applyStyle):
3310         (TEST):
3311         Add a viewport, so that the coordinates match up on iOS.
3312         Scroll by moving the UIScrollView's contentOffset.
3313
3314 2019-03-11  Chris Dumez  <cdumez@apple.com>
3315
3316         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3317         https://bugs.webkit.org/show_bug.cgi?id=195506
3318         <rdar://problem/48733477>
3319
3320         Reviewed by Alex Christensen.
3321
3322         Add API test coverage.
3323
3324         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3325
3326 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3327
3328         Adding myself to contributors.json
3329
3330         Unreviewed, addming myself to contributors.json .
3331
3332         * Scripts/webkitpy/common/config/contributors.json:
3333
3334 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3335
3336         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3337         https://bugs.webkit.org/show_bug.cgi?id=195511
3338         <rdar://problem/44873269>
3339
3340         Reviewed by Darin Adler.
3341
3342         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3343         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3344         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3345         (TEST_F):
3346
3347 2019-03-11  Chris Dumez  <cdumez@apple.com>
3348
3349         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3350         https://bugs.webkit.org/show_bug.cgi?id=195561
3351
3352         Reviewed by Youenn Fablet.
3353
3354         Make sure the JS in the test requests for permission to receive device orientation events.
3355
3356         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3357
3358 2019-03-11  Youenn Fablet  <youenn@apple.com>
3359
3360         Allow storage quota increase by default in WTR
3361         https://bugs.webkit.org/show_bug.cgi?id=195541
3362
3363         Reviewed by Geoffrey Garen.
3364
3365         Allow storage quota increase by default in WTR.
3366         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3367         Use this for tests that explicitly need cache increase.
3368
3369         Instead of increasing quota by 2, make sure the next request is
3370         granted by adding all given parameters.
3371
3372         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3373         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3374         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3375         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3376         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3377         * WebKitTestRunner/TestController.cpp:
3378         (WTR::TestController::setAllowStorageQuotaIncrease):
3379         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3380         * WebKitTestRunner/TestController.h:
3381         * WebKitTestRunner/TestInvocation.cpp:
3382         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3383         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3384         (WTR::TestController::cocoaResetStateToConsistentValues):
3385         (WTR::TestController::setAllowStorageQuotaIncrease):
3386         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3387         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3388         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3389
3390 2019-03-11  Xan Lopez  <xan@igalia.com>
3391
3392         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3393         https://bugs.webkit.org/show_bug.cgi?id=194147
3394
3395         Reviewed by Michael Saboff.
3396
3397         To make --32-bit work correctly on Linux/64bit we need to:
3398
3399         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3400         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3401         unfortunately CMake only allows us to do this during
3402         crosscompilation, which is overkill here.
3403         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3404         pkg-config detection module uses the x86 .pc files instead of the
3405         x86_64 ones.
3406         - Set the -m32 flags for the compiler.
3407
3408         * Scripts/webkitdirs.pm:
3409         (generateBuildSystemFromCMakeProject):
3410
3411 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3412
3413         Add MotionMark-1.1 plan file for run-benchmark script.
3414         https://bugs.webkit.org/show_bug.cgi?id=195481
3415
3416         Rubber-stamped by Darin Adler.
3417
3418         Run-benchmark script should support MontionMark-1.1.
3419
3420         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3421
3422 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3423
3424         [ews-app] Add support for submit-to-ews url
3425         https://bugs.webkit.org/show_bug.cgi?id=195477
3426
3427         Reviewed by Lucas Forschler.
3428
3429         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3430         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3431         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3432         * BuildSlaveSupport/ews-app/ews/urls.py:
3433         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3434
3435 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3436
3437         Unreviewed, rolling out r242688, r242643, r242624.
3438
3439         Caused multiple layout test failures and crashes on iOS and macOS.
3440
3441         Reverted changeset:
3442
3443         "requestAnimationFrame should execute before the next frame"
3444         https://bugs.webkit.org/show_bug.cgi?id=177484
3445         https://trac.webkit.org/changeset/242624/webkit
3446
3447         * Tracing/SystemTracePoints.plist:
3448
3449 2019-03-11  John Wilander  <wilander@apple.com>
3450
3451         Resource Load Statistics: Make it possible exclude localhost from classification
3452         https://bugs.webkit.org/show_bug.cgi?id=195474
3453         <rdar://problem/47520577>
3454
3455         Reviewed by Brent Fulgham.
3456
3457         This patch allows for localhost to be excluded from classification and
3458         treatment as a prevalent resource.
3459
3460         The WebKit Tools change adds a new function called
3461         testRunner.setStatisticsIsRunningTest() which can be used to control this
3462         behavior.
3463
3464         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3465         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3466         (WTR::TestRunner::setStatisticsIsRunningTest):
3467         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3468         * WebKitTestRunner/TestController.cpp:
3469         (WTR::TestController::setStatisticsIsRunningTest):
3470         * WebKitTestRunner/TestController.h:
3471         * WebKitTestRunner/TestInvocation.cpp:
3472         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3473
3474 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3475
3476         [ews-build] Disable waterfall and console view for ews-build.webkit.org
3477         https://bugs.webkit.org/show_bug.cgi?id=195560
3478
3479         Reviewed by Lucas Forschler.
3480
3481         * BuildSlaveSupport/ews-build/master.cfg:
3482
3483 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3484
3485         Unreviewed, rolling out r242698.
3486
3487         API test crashes on bots.
3488
3489         Reverted changeset:
3490
3491         "Add a WKContentRuleList variant that uses copied memory
3492         instead of mmap'd shared memory for class A containerized
3493         apps"
3494         https://bugs.webkit.org/show_bug.cgi?id=195511
3495         https://trac.webkit.org/changeset/242698
3496
3497 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
3498
3499         [WPE] Enable web process sandbox
3500         https://bugs.webkit.org/show_bug.cgi?id=195169
3501
3502         Reviewed by Daniel Bates.
3503
3504         * wpe/install-dependencies:
3505         * wpe/jhbuild.modules:
3506
3507 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3508
3509         [ews-app] Use port 17000 for worker communication
3510         https://bugs.webkit.org/show_bug.cgi?id=195558
3511
3512         Reviewed by Lucas Forschler.
3513
3514         * BuildSlaveSupport/ews-build/master.cfg:
3515
3516 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3517
3518         [ews-build] unit-tests fail when passwords.json is missing
3519         https://bugs.webkit.org/show_bug.cgi?id=195557
3520
3521         Reviewed by Lucas Forschler.
3522
3523         * BuildSlaveSupport/ews-build/loadConfig.py:
3524         (loadBuilderConfig):
3525         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3526         (ConfigDotJSONTest.test_configuration):
3527         * BuildSlaveSupport/ews-build/master.cfg:
3528
3529 2019-03-11  Truitt Savell  <tsavell@apple.com>
3530
3531         Unreviewed, rolling out r242702.
3532
3533         Broke High Sierra builders.
3534
3535         Reverted changeset:
3536
3537         "Add utility function to allow easy reverse range-based
3538         iteration of a container"
3539         https://bugs.webkit.org/show_bug.cgi?id=195542
3540         https://trac.webkit.org/changeset/242702
3541
3542 2019-03-11  Sam Weinig  <sam@webkit.org>
3543
3544         Add utility function to allow easy reverse range-based iteration of a container
3545         https://bugs.webkit.org/show_bug.cgi?id=195542
3546
3547         Reviewed by Antti Koivisto.
3548
3549         * TestWebKitAPI/CMakeLists.txt:
3550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3551         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3552         (TestWebKitAPI::TEST):
3553         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3554
3555 2019-03-10  Alex Christensen  <achristensen@webkit.org>
3556
3557         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3558         https://bugs.webkit.org/show_bug.cgi?id=195511
3559         <rdar://problem/44873269>
3560
3561         Reviewed by Darin Adler.
3562
3563         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3564         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3565         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3566         (TEST_F):
3567
3568 2019-03-10  Tim Horton  <timothy_horton@apple.com>
3569
3570         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
3571         https://bugs.webkit.org/show_bug.cgi?id=195499
3572
3573         Reviewed by Darin Adler.
3574
3575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3576         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
3577         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
3578         (-[WKWebView synchronouslyFocusTextInputContext:]):
3579         (applyStyle):
3580         (applyIframe):
3581         (TEST):
3582         Add some tests for this SPI.
3583
3584 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
3585
3586         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
3587         https://bugs.webkit.org/show_bug.cgi?id=181151
3588
3589         Reviewed by Don Olmstead.
3590
3591         * TestWebKitAPI/CMakeLists.txt:
3592         * TestWebKitAPI/PlatformWin.cmake:
3593         Enable TestWTF RunLoop tests in all platforms.
3594
3595         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
3596         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
3597         (TestWebKitAPI::DerivedOneShotTimer::fired):
3598         (TestWebKitAPI::TEST):
3599         Only a few platforms support nested RunLoop.
3600
3601         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
3602         (TestWebKitAPI::DerivedRepeatingTimer::fired):
3603
3604 2019-03-10  David Quesada  <david_quesada@apple.com>
3605
3606         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
3607         https://bugs.webkit.org/show_bug.cgi?id=152480
3608
3609         Reviewed by Chris Dumez.
3610
3611         Add a unit test based on Daniel Bates's test case that starts a download, ensures
3612         there are no additional references to the process pool besides the one held by
3613         the download, waits for the download to finish (in the sense that the
3614         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
3615         measure, also check that the process pool has been deallocated at the end of the
3616         test. The test wouldn't be meaningful if the process pool were still alive.
3617
3618         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3619         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
3620         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
3621             The download will be canceled because the delegate does not implement the
3622             method to decide the download's destination, so this is where we know the
3623             DownloadProxyMap is done with the DownloadProxy.
3624         (TEST):
3625
3626 2019-03-08  Chris Dumez  <cdumez@apple.com>
3627
3628         Add support for Device Orientation / Motion permission API
3629         https://bugs.webkit.org/show_bug.cgi?id=195329
3630         <rdar://problem/47645367>
3631
3632         Reviewed by Geoffrey Garen.
3633
3634         Add test infrastructure to help test the Device Orientation / Motion permission API.
3635
3636         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3637         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3638         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
3639         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3640         * WebKitTestRunner/TestController.cpp:
3641         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
3642         (WTR::TestController::createWebViewWithOptions):
3643         (WTR::TestController::resetStateToConsistentValues):
3644         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
3645         * WebKitTestRunner/TestController.h:
3646         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
3647         * WebKitTestRunner/TestInvocation.cpp:
3648         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3649
3650 2019-03-08  Saam barati  <sbarati@apple.com>
3651
3652         Add a compare-results script to compare benchmark results
3653         https://bugs.webkit.org/show_bug.cgi?id=195486
3654         <rdar://problem/48723397>
3655
3656         Reviewed by Geoffrey Garen.
3657
3658         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
3659         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
3660         to extend it to learn about our other benchmarks.
3661
3662         * Scripts/compare-results: Added.
3663         (readJSONFile):
3664         (detectJetStream2):
3665         (JetStream2Results):
3666         (detectSpeedometer2):
3667         (Speedometer2Results):
3668         (detectPLT5):
3669         (PLT5Results):
3670         (detectBenchmark):
3671         (biggerIsBetter):
3672         (ttest):
3673         (getOptions):
3674         (main):
3675
3676 2019-03-08  Stephanie Lewis  <slewis@apple.com>
3677
3678         Ensure old tab state is cleared between iterations of run-benchmark
3679         https://bugs.webkit.org/show_bug.cgi?id=195393
3680         <rdar://problem/46885583>
3681
3682         Reviewed by Dewei Zhu.
3683
3684         a) ensure the default to restore state is not set
3685         b) terminate Safari correctly
3686         c) Set the system default to ignore Persistent State in Safari
3687
3688         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3689         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
3690         (OSXBrowserDriver.prepare_env): 
3691         (OSXBrowserDriver.restore_env):
3692         (OSXBrowserDriver.close_browsers):
3693         (OSXBrowserDriver._terminate_processes):
3694         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
3695         (OSXChromeDriver):
3696         (OSXChromeCanaryDriver):
3697         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
3698         (OSXFirefoxDriver):
3699         (OSXFirefoxNightlyDriver):
3700         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
3701         (OSXSafariDriver):
3702         (OSXSafariDriver.prepare_env):
3703
3704 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
3705
3706         [GTK] Several InputMethodFilter tests are failing
3707         https://bugs.webkit.org/show_bug.cgi?id=195408
3708
3709         Reviewed by Carlos Garcia Campos.
3710
3711         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
3712         Regressed in r241751.
3713         Hexadecimal values of keycodes are expressed now in upper letters.
3714         Composited characters should be cast to UTF8 strings.
3715
3716         (TestWebKitAPI::TEST):
3717
3718 2019-03-07  Tomas Popela  <tpopela@redhat.com>
3719
3720         [GTK] Make Tools/gtkdoc python3 compatible
3721         https://bugs.webkit.org/show_bug.cgi?id=195359
3722
3723         Reviewed by Carlos Garcia Campos.
3724
3725         * gtkdoc/generate-gtkdoc:
3726         ConfigParser was reworked in Python 3.2 so we have adapt the code to
3727         work with Python 2 and 3.
3728         (get_gtkdoc_module_paths):
3729         The iteritems() was removed in Python 3, so let's use items() that's
3730         available in Python 2 and 3.
3731         (get_generator_for_config):
3732         * gtkdoc/gtkdoc.py:
3733         (GTKDoc._run_command):
3734         The sys.stdout.write() is expecting str in Python 3 and not bytes
3735         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
3736         for passing the bytes there.
3737
3738 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3739
3740         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3741         https://bugs.webkit.org/show_bug.cgi?id=195346
3742         <rdar://problem/48667048>
3743
3744         Unreviewed build fix for clang-cl.
3745
3746         * DumpRenderTree/win/DumpRenderTree.cpp:
3747         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
3748
3749 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
3750
3751         requestAnimationFrame should execute before the next frame
3752         https://bugs.webkit.org/show_bug.cgi?id=177484
3753
3754         Reviewed by Simon Fraser.
3755
3756         Add trace points for the page RenderingUpdate.
3757
3758         * Tracing/SystemTracePoints.plist:
3759
3760 2019-03-07  Zalan Bujtas  <zalan@apple.com>
3761
3762         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
3763         https://bugs.webkit.org/show_bug.cgi?id=195353
3764         <rdar://problem/48626394>
3765
3766         Reviewed by Simon Fraser.
3767
3768         * WebKitTestRunner/ios/TestControllerIOS.mm:
3769         (WTR::TestController::platformResetPreferencesToConsistentValues):
3770
3771 2019-03-07  John Wilander  <wilander@apple.com>
3772
3773         Resource Load Statistics: Make it possible to purge only script-accessible cookies
3774         https://bugs.webkit.org/show_bug.cgi?id=195383
3775         <rdar://problem/48570136>
3776
3777         Reviewed by Brent Fulgham.
3778
3779         This patch adds test infrastructure to purge only script-accessible cookies,
3780         including a new testRunner function called statisticsDeleteCookiesForHost().git a
3781
3782         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3783         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3784         (WTR::TestRunner::statisticsDeleteCookiesForHost):
3785         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3786         * WebKitTestRunner/TestController.cpp:
3787         (WTR::TestController::statisticsDeleteCookiesForHost):
3788         * WebKitTestRunner/TestController.h:
3789         * WebKitTestRunner/TestInvocation.cpp:
3790         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3791
3792 2019-03-07  Commit Queue  <commit-queue@webkit.org>
3793
3794         Unreviewed, rolling out r242354.
3795         https://bugs.webkit.org/show_bug.cgi?id=195402
3796
3797         breaks layout tests in all configurations (Requested by
3798         zdobersek on #webkit).
3799
3800         Reverted changeset:
3801
3802         "[WPE] Enable web process sandbox"
3803         https://bugs.webkit.org/show_bug.cgi?id=195169
3804         https://trac.webkit.org/changeset/242354
3805
3806 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
3807
3808         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
3809         https://bugs.webkit.org/show_bug.cgi?id=195346
3810
3811         Reviewed by Fujii Hironori.
3812
3813         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3814         (TestWebKitAPI::TEST):
3815         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3816
3817         * DumpRenderTree/win/DumpRenderTree.cpp:
3818         (findFontFallback):
3819         (addFontFallbackIfPresent):
3820         (removeFontFallbackIfPresent):
3821         (main):
3822         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3823         (TestWebKitAPI::Util::moduleDirectory):
3824         (TestWebKitAPI::Util::createInjectedBundlePath):
3825         Use wchar helpers as needed.
3826
3827 2019-03-06  Rob Buis  <rbuis@igalia.com>
3828
3829         Consider supporting the `referrerpolicy` attribute.
3830         https://bugs.webkit.org/show_bug.cgi?id=179053
3831
3832         Reviewed by Darin Adler.
3833
3834         Add a runtime flag for referrerpolicy attribute.
3835
3836         * DumpRenderTree/mac/DumpRenderTree.mm:
3837         (enableExperimentalFeatures):
3838
3839 2019-03-05  Daniel Bates  <dabates@apple.com>
3840
3841         Update expected API test result following r242379
3842         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3843
3844         Update expected x-coordinate of selection rect now that the left padding of
3845         a textarea is sized in ems (so dependent on the font size) just like the left
3846         padding of a text field.
3847
3848         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3849         (TestWebKitAPI::TEST):
3850
3851 2019-03-05  David Quesada  <david_quesada@apple.com>
3852
3853         [WK2] It should be possible to follow links with 'download' attributes
3854         https://bugs.webkit.org/show_bug.cgi?id=195145
3855         rdar://problem/48462642
3856
3857         Reviewed by Alex Christensen.
3858
3859         Add a unit test to verify that activating links with 'download' attributes now
3860         navigates to the linked resource, rather than starts downloading it. Add another
3861         to verify that it is still possible to explicitly download the link via the
3862         'Download' navigation action policy.
3863
3864         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3865         (-[DownloadAttributeTestDelegate init]):
3866         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3867         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3868         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3869         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3870         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3871         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3872         (TEST):
3873         * WebKitTestRunner/TestController.cpp:
3874         (WTR::TestController::decidePolicyForNavigationAction):
3875         * WebKitTestRunner/TestController.h:
3876
3877 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3878
3879         [Curl] Implement Cookie Accept Policy.
3880         https://bugs.webkit.org/show_bug.cgi?id=191645
3881
3882         Reviewed by Fujii Hironori.
3883
3884         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3885         (TestWebKitAPI::Curl::TEST_F):
3886
3887 2019-03-05  Youenn Fablet  <youenn@apple.com>
3888
3889         Rename requestCacheStorageSpace to requestStorageSpace
3890         https://bugs.webkit.org/show_bug.cgi?id=195282
3891
3892         Reviewed by Chris Dumez.
3893
3894         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3895         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3896         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3897
3898 2019-03-05  Brady Eidson  <beidson@apple.com>
3899
3900         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3901         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3902
3903         Reviewed by Tim Horton.
3904
3905         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3906         different directory into that same WKWebView should work.
3907
3908         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3909         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3910
3911 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3912
3913         Add WeakHashSet
3914         https://bugs.webkit.org/show_bug.cgi?id=195152
3915
3916         Reviewed by Antti Koivisto.
3917
3918         Added tests for WeakHashSet.
3919
3920         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3921         (TestWebKitAPI::Base::Base): Moved.
3922         (TestWebKitAPI::Derived::foo): Moved.
3923         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3924         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3925         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3926         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3927
3928 2019-03-04  Chris Dumez  <cdumez@apple.com>
3929
3930         Do not share WebProcesses between private and regular sessions
3931         https://bugs.webkit.org/show_bug.cgi?id=195189
3932         <rdar://problem/48421064>
3933
3934         Reviewed by Alex Christensen.
3935
3936         Add API test coverage.
3937
3938         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3939         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3940
3941 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3942
3943         [WPE] Enable web process sandbox
3944         https://bugs.webkit.org/show_bug.cgi?id=195169
3945
3946         Reviewed by Daniel Bates.
3947
3948         * wpe/install-dependencies:
3949         * wpe/jhbuild.modules:
3950
3951 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3952
3953         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3954         https://bugs.webkit.org/show_bug.cgi?id=195206
3955
3956         Reviewed by Žan Doberšek.
3957
3958         Add a new test case.
3959
3960         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3961         (testJSCClass):
3962
3963 2019-03-04  Charlie Turner  <cturner@igalia.com>
3964
3965         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3966         https://bugs.webkit.org/show_bug.cgi?id=194898
3967
3968         Reviewed by Žan Doberšek.
3969
3970         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3971         a GCC extension that permits arithmetic on void* pointer. Inline
3972         the macro until this issue is fixed upstream.
3973
3974 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3975
3976         Rid the world of WK_API_ENABLED
3977         https://bugs.webkit.org/show_bug.cgi?id=195263
3978
3979         Reviewed by Dan Bernstein.
3980
3981         List of changed files elided because it's useless.
3982
3983 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3984
3985         Unreviewed follow-up to r242292.
3986
3987         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3988
3989         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3990         (TestWebKitAPI::testStrip): Renamed from strip.
3991         (TestWebKitAPI::TEST):
3992
3993 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3994
3995         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3996
3997         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3998         and bug #194272 for details.
3999
4000         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
4001
4002 2019-03-03  Tim Horton  <timothy_horton@apple.com>
4003
4004         Remove some more unused 32-bit code
4005         https://bugs.webkit.org/show_bug.cgi?id=195255
4006
4007         Reviewed by Darin Adler.
4008
4009         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4010         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
4011         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4012         (NPP_New):
4013         (NPP_HandleEvent):
4014         (handleEventCarbon): Deleted.
4015
4016 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
4017
4018         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
4019
4020         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4021         (TestWebKitAPI::TEST):
4022
4023 2019-03-01  Darin Adler  <darin@apple.com>
4024
4025         Finish removing String::format
4026         https://bugs.webkit.org/show_bug.cgi?id=194893
4027
4028         Reviewed by Daniel Bates.
4029 '
4030         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
4031
4032 2019-03-01  Alex Christensen  <achristensen@webkit.org>
4033
4034         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
4035         https://bugs.webkit.org/show_bug.cgi?id=195229
4036         <rdar://problem/48520362>
4037
4038         Reviewed by Chris Dumez.
4039
4040         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4041         (TEST):
4042
4043 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
4044
4045         Add a system trace scope for event region building
4046         https://bugs.webkit.org/show_bug.cgi?id=195226
4047
4048         Reviewed by Jon Lee.
4049
4050         This trace scope measures the time spend converting element rects into Region objects,
4051         which can be large on some pages.
4052
4053         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
4054
4055         * Tracing/SystemTracePoints.plist:
4056
4057 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
4058
4059         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
4060         https://bugs.webkit.org/show_bug.cgi?id=194612
4061
4062         Reviewed by Alex Christensen.
4063
4064         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
4065         Just test the new string-processing function and don't touch the actual environment.
4066         (Test cases are all as before, but based on operator== instead of strcmp.)
4067
4068 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
4069
4070         [ews-app] Update primary keys for handling multiple Buildbot instances
4071         https://bugs.webkit.org/show_bug.cgi?id=195120
4072
4073         Reviewed by Stephanie Lewis.
4074
4075         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
4076         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
4077         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
4078
4079         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
4080         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
4081         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
4082         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
4083         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
4084         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
4085
4086 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
4087
4088         [WinCairo] Enable service worker
4089         https://bugs.webkit.org/show_bug.cgi?id=188318
4090
4091         Reviewed by Youenn Fablet.
4092
4093         * DumpRenderTree/DumpRenderTreePrefix.h:
4094         * TestWebKitAPI/PlatformWin.cmake:
4095         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
4096         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
4097         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
4098
4099 2019-03-01  Justin Fan  <justin_fan@apple.com>
4100
4101         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
4102         https://bugs.webkit.org/show_bug.cgi?id=195191
4103
4104         Rubber-stamped by Dean Jackson.
4105
4106         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
4107
4108         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4109
4110 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
4111
4112         Unreviewed, fix lldb webkitpy tests
4113         https://bugs.webkit.org/show_bug.cgi?id=194375
4114
4115         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
4116
4117         * lldb/lldb_webkit.py:
4118         (WTFStringImplProvider.is_8bit):
4119
4120 2019-02-28  David Quesada  <david_quesada@apple.com>
4121
4122         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
4123         https://bugs.webkit.org/show_bug.cgi?id=195121
4124         rdar://problem/48450302
4125
4126         Reviewed by Alex Christensen.
4127
4128         Add API tests for -WKNavigationAction._shouldPerformDownload in various
4129         configurations where the 'download' attribute is absent, blank, or populated
4130         with a filename, and where the anchor element is same-origin or cross-origin
4131         (meaning the 'download' attribute shouldn't be honored).
4132
4133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4134         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
4135         (-[NavigationActionTestDelegate init]):
4136         (-[NavigationActionTestDelegate navigationAction]):
4137         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
4138         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
4139         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4140         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
4141         (TEST):
4142
4143 2019-02-28  Antoine Quint  <graouts@apple.com>
4144
4145         Enable the Pointer Events runtime flag by default
4146         https://bugs.webkit.org/show_bug.cgi?id=195156
4147
4148         Reviewed by Dean Jackson.
4149
4150         * DumpRenderTree/mac/DumpRenderTree.mm:
4151         (enableExperimentalFeatures):
4152
4153 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
4154
4155         Several PasteImage API tests are flaky
4156         https://bugs.webkit.org/show_bug.cgi?id=195160
4157
4158         Reviewed by Tim Horton.
4159
4160         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
4161         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
4162         listening for a "load" event after image load is already complete.
4163
4164         To address this, make these tests first register a "load" event handler, then run script to insert an image
4165         element into the document, and finally wait until the load event is observed before checking image size.
4166
4167         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
4168
4169 2019-02-28  Chris Dumez  <cdumez@apple.com>
4170
4171         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
4172         https://bugs.webkit.org/show_bug.cgi?id=195107
4173
4174         Reviewed by Alex Christensen.
4175
4176         Give some time for the zoom level to get restored.
4177
4178         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4179
4180 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
4181
4182         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
4183         https://bugs.webkit.org/show_bug.cgi?id=194958
4184
4185         Reviewed by Geoffrey Garen.
4186
4187         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
4188         (TEST):
4189
4190 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
4191
4192         [ews-app] Update method to save build to handle builder_display_name
4193         https://bugs.webkit.org/show_bug.cgi?id=195047
4194
4195         Reviewed by Dewei Zhu.
4196
4197         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
4198         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
4199
4200 2019-02-28  Justin Fan  <justin_fan@apple.com>
4201
4202         [Web GPU] Enable Web GPU only on 64-bit
4203         https://bugs.webkit.org/show_bug.cgi?id=195139
4204
4205         Because Metal is only supported on 64 bit apps.
4206
4207         Unreviewed build fix.
4208
4209         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4210
4211 2019-02-27  Youenn Fablet  <youenn@apple.com>
4212
4213         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
4214         https://bugs.webkit.org/show_bug.cgi?id=194959
4215
4216         Reviewed by Chris Dumez.
4217
4218         Spin loop until getting the condition to remove flakiness.
4219
4220         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4221
4222 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
4223
4224         [ews-build] Buildbot should include builder_display_name in the build events
4225         https://bugs.webkit.org/show_bug.cgi?id=195045
4226
4227         Reviewed by Dewei Zhu.
4228
4229         * BuildSlaveSupport/ews-build/events.py:
4230         (Events.buildStarted): Included builder_display_name in event data. Also renamed
4231         buildername to builder_name to be consistent in naming style.
4232         (Events.buildFinished): Ditto.
4233
4234 2019-02-27  Chris Dumez  <cdumez@apple.com>
4235
4236         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
4237         https://bugs.webkit.org/show_bug.cgi?id=194480
4238
4239         Reviewed by Brady Eidson.
4240
4241         Update existing API test to make it more likely to reproduce the issue.
4242
4243         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4244
4245 2019-02-27  Brady Eidson  <beidson@apple.com>
4246
4247         Universal links from Google search results pages don't open the app.
4248         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
4249
4250         Reviewed by Geoffrey Garen.
4251
4252         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
4253         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
4254         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
4255         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4256
4257 2019-02-27  Chris Dumez  <cdumez@apple.com>
4258
4259         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
4260         https://bugs.webkit.org/show_bug.cgi?id=195102
4261
4262         Reviewed by Geoffrey Garen.
4263
4264         If the number of processes is not yet what we expect, wait a bit and check again to give
4265         processes some time to exit.
4266
4267         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4268
4269 2019-02-27  Chris Dumez  <cdumez@apple.com>
4270
4271         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
4272         https://bugs.webkit.org/show_bug.cgi?id=194545
4273
4274         Reviewed by Brady Eidson.
4275
4276         Make sure the test navigates forward and then back only once. Previously, navigating
4277         back would trigger a navigation again in a timer.
4278
4279         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4280
4281 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
4282
4283         High Sierra Debug JSC test queue should use faster hardware
4284         https://bugs.webkit.org/show_bug.cgi?id=194603
4285
4286         Rubber-stamped by Alexey Proskuryakov.
4287
4288         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
4289
4290         * BuildSlaveSupport/build.webkit.org-config/config.json:
4291         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4292         (BubbleQueueServer):
4293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4294         (WebKitBuildbot):
4295         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4296         * QueueStatusServer/config/queues.py:
4297         * Scripts/webkitpy/common/config/ews.json:
4298         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4299         (test_ews_name):
4300
4301 2019-02-27  John Wilander  <wilander@apple.com>
4302
4303         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
4304         https://bugs.webkit.org/show_bug.cgi?id=195071
4305         <rdar://problem/48417690>
4306
4307         Reviewed by Alex Christensen and Brent Fulgham.
4308
4309         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
4310         (TestWebKitAPI::createURL):
4311             Convenience function.
4312         (TestWebKitAPI::TEST):
4313             WebCore::AdClickAttribution now takes a URL when creating Source and
4314             Destination.
4315         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
4316         (TestWebKitAPI::TEST):
4317             WebCore::AdClickAttribution now takes a URL when creating Source and
4318             Destination.
4319
4320 2019-02-27  Antoine Quint  <graouts@apple.com>
4321
4322         Support Pointer Events on macOS
4323         https://bugs.webkit.org/show_bug.cgi?id=195008
4324         <rdar://problem/47454419>
4325
4326         Reviewed by Dean Jackson.
4327
4328         * DumpRenderTree/mac/DumpRenderTree.mm:
4329         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
4330         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4331
4332 2019-02-26  Mark Lam  <mark.lam@apple.com>
4333
4334         Remove remaining poisoning code.
4335         https://bugs.webkit.org/show_bug.cgi?id=194138
4336
4337         Reviewed by Saam Barati.
4338
4339         * TestWebKitAPI/CMakeLists.txt:
4340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4341         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
4342         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
4343         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
4344         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
4345         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
4346         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
4347
4348 2019-02-26  Alex Christensen  <achristensen@webkit.org>
4349
4350         Move ephemeral local storage from WebProcess to UIProcess
4351         https://bugs.webkit.org/show_bug.cgi?id=195074
4352         <rdar://problem/47937975>
4353
4354         Reviewed by Geoff Garen.
4355
4356         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4357
4358 2019-02-20  Jer Noble  <jer.noble@apple.com>
4359
4360         [Cocoa] Media elements will restart network buffering just before suspending
4361         https://bugs.webkit.org/show_bug.cgi?id=193691
4362
4363         Reviewed by Eric Carlson.
4364
4365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4366         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
4367         (TEST):
4368
4369 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
4370
4371         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.