Use CSS4 image-rendering to determing image scaling quality
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2
3         Use CSS4 image-rendering to determing image scaling quality
4         https://bugs.webkit.org/show_bug.cgi?id=113405
5
6         Reviewed by Simon Fraser.
7
8         Introduce new flag to enable experimental support for CSS4 Images.
9
10         * Scripts/webkitperl/FeatureList.pm:
11
12 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
13
14         Remove code for Chromium from wkbuild.py
15         https://bugs.webkit.org/show_bug.cgi?id=114423
16
17         Reviewed by Benjamin Poulain.
18
19         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
20         (_should_file_trigger_build):
21         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
22         (ShouldBuildTest):
23
24 2013-04-11  Philippe Normand  <pnormand@igalia.com>
25
26         Unreviewed, update my IRC nickname.
27
28         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
29
30 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
31
32         Remove the rest of Chromium code from webkitpy
33         https://bugs.webkit.org/show_bug.cgi?id=114420
34
35         Reviewed by Benjamin Poulain.
36
37         * Scripts/webkitpy/common/config/urls.py:
38         (view_revision_url):
39         * Scripts/webkitpy/common/host.py:
40         (Host._engage_awesome_locale_hacks):
41         (Host.initialize_scm):
42         (Host):
43         * Scripts/webkitpy/common/host_mock.py:
44         (MockHost.__init__):
45         (MockHost.checkout):
46         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
47         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
48         (JSONResultsGeneratorBase._insert_generic_metadata):
49         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
50         (TestExpectationParser._tokenize_line):
51         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
52         (ExpectationSyntaxTests.test_bare_name_and_bugs):
53         (ExpectationSyntaxTests.test_warnings):
54         * Scripts/webkitpy/layout_tests/port/base.py:
55         (Port.skips_perf_test):
56         (Port.path_to_test_expectations_file):
57         (Port._port_flag_for_scripts):
58         * Scripts/webkitpy/style/checkers/cpp.py:
59         (check_function_definition):
60         (check_include_line):
61         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
62         (OrderOfIncludesTest.test_check_wtf_includes):
63         (WebKitStyleTest.test_webkit_export_check):
64         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
65         (TestExpectationsTestCase.test_valid_expectations):
66         * Scripts/webkitpy/tool/bot/irc_command.py:
67         (Rollout.execute):
68         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
69         (IRCCommandTest.test_whois):
70         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
71         (IRCBotTest.test_help):
72         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
73         (SheriffBotTest.test_command_aliases):
74
75 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
76
77         roll-chromium-deps doesn't roll DEPS
78         https://bugs.webkit.org/show_bug.cgi?id=114421
79
80         Reviewed by Antti Koivisto.
81
82         Roll DEPS. Rolling DEPS. Rolled DEPS.
83
84         * Scripts/webkitpy/tool/bot/irc_command.py:
85         (RollChromiumDEPS.execute):
86
87 2013-04-11  Glenn Adams  <glenn@skynav.com>
88
89         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
90         https://bugs.webkit.org/show_bug.cgi?id=114418
91
92         Reviewed by Ryosuke Niwa.
93
94         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
95         (MockSCM.add): Remove optional remove_exit_code argument.
96         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
97         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
98         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
99         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
100
101 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
102
103         Fix roll-chromium-deps and hi.
104
105         * Scripts/webkitpy/tool/bot/irc_command.py:
106         (Hi.execute):
107         (RollChromiumDEPS.execute):
108
109 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
110
111         Remove webkitpy code to roll Chromium DEPS
112         https://bugs.webkit.org/show_bug.cgi?id=114415
113
114         Reviewed by Benjamin Poulain.
115
116         Removed the code to roll Chromium DEPS in WebKit.
117
118         * Scripts/webkitpy/common/checkout/checkout.py:
119         (Checkout.bug_id_for_this_commit):
120         * Scripts/webkitpy/common/checkout/checkout_mock.py:
121         (MockCheckout.commit_message_for_this_commit):
122         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
123         (CheckoutTest.test_suggested_reviewers):
124         * Scripts/webkitpy/common/checkout/deps.py: Removed.
125         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
126         * Scripts/webkitpy/tool/bot/irc_command.py:
127         (RollChromiumDEPS): Teach webkitbot a sense of humor.
128         (RollChromiumDEPS.execute):
129         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
130         (IRCCommandTest.test_create_bug):
131         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
132         (IRCBotTest.test_revert):
133         * Scripts/webkitpy/tool/bot/sheriff.py:
134         (Sheriff.post_rollout_patch):
135         * Scripts/webkitpy/tool/commands/__init__.py:
136         * Scripts/webkitpy/tool/commands/roll.py: Removed.
137         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
138         * Scripts/webkitpy/tool/steps/__init__.py:
139         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
140         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
141         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
142
143 2013-04-11  Glenn Adams  <glenn@skynav.com>
144
145         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
146         https://bugs.webkit.org/show_bug.cgi?id=114386
147
148         Reviewed by Benjamin Poulain.
149
150         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
151         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
152         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
153         by default and to return exit code 1 if a file/dir had already been added.
154
155         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
156         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
157         * Scripts/webkitpy/common/checkout/scm/svn.py:
158         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
159
160 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
161
162         Unreviewed.
163
164         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
165
166 2013-04-10  Glenn Adams  <glenn@skynav.com>
167
168         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
169         https://bugs.webkit.org/show_bug.cgi?id=114410
170
171         Reviewed by Ryosuke Niwa.
172
173         * Scripts/webkitpy/common/checkout/scm/git.py:
174         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
175         * Scripts/webkitpy/common/checkout/scm/scm.py:
176         (SCM.add): Remove optional return_exit_code argument.
177         (SCM.add_list): Remove optional return_exit_code argument.
178         * Scripts/webkitpy/common/checkout/scm/svn.py:
179         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
180
181 2013-04-10  Eric Seidel  <eric@webkit.org>
182
183         Remove myself from the watchlists, I'm getting too much bug mail. :)
184
185         * Scripts/webkitpy/common/config/watchlist:
186
187 2013-04-10  Commit Queue  <rniwa@webkit.org>
188
189         Unreviewed, rolling out r148158.
190         http://trac.webkit.org/changeset/148158
191         https://bugs.webkit.org/show_bug.cgi?id=114405
192
193         We need to migrate status data (Requested by rniwa on
194         #webkit).
195
196         * Scripts/webkitpy/common/net/statusserver.py:
197         (StatusServer):
198
199 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
200
201         Mass remove all the empty directories
202
203         Rubberstamped by Ryosuke Niwa.
204
205         * BuildSlaveSupport/gtk/crashmon/log: Removed.
206         * BuildSlaveSupport/gtk/xvfb/log: Removed.
207         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
208         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
209         * MiniBrowser/gtk/WebBundle: Removed.
210         * MiniBrowser/win: Removed.
211         * QtTestPlatformPlugin/mac: Removed.
212         * Scripts/webkitpy/tool/bot/testdata: Removed.
213         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
214         * efl/ImageDiff: Removed.
215         * iExploder/htdocs: Removed.
216         * iExploder/iexploder-1.7.2/output: Removed.
217         * iExploder/tools: Removed.
218         * qmake/config.tests/libexecdir: Removed.
219         * qmake/config.tests/libjpeg: Removed.
220         * qmake/config.tests/libpng: Removed.
221
222 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
223
224         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
225         https://bugs.webkit.org/show_bug.cgi?id=114397
226
227         Reviewed by Benjamin Poulain.
228
229         * Scripts/webkitpy/common/net/statusserver.py:
230         (StatusServer):
231
232 2013-04-10  Adam Barth  <abarth@webkit.org>
233
234         Remove abarth from watchlists
235         https://bugs.webkit.org/show_bug.cgi?id=114390
236
237         Reviewed by Ryosuke Niwa.
238
239         I'm trying to cut down on the amount of bugmail I get so that I'll have
240         more of a chance to notice a piece of bugmail directed at me.
241
242         * Scripts/webkitpy/common/config/watchlist:
243
244 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
245
246         webkit-test-results.appspot.com loads the dashboard for Chromium by default
247         https://bugs.webkit.org/show_bug.cgi?id=114381
248
249         Reviewed by Benjamin Poulain.
250
251         Changed the defaults.
252
253         * TestResultServer/static-dashboards/builders.js:
254         * TestResultServer/static-dashboards/dashboard_base.js:
255         (currentBuilderGroupCategory):
256
257 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
258
259         Remove Chromium EWS bots from the queue status server
260         https://bugs.webkit.org/show_bug.cgi?id=113988
261
262         Reviewed by Benjamin Poulain.
263
264         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
265
266         * QueueStatusServer/app.yaml:
267         * QueueStatusServer/config/queues.py:
268         * QueueStatusServer/model/queues.py:
269         (Queue.short_name):
270         (Queue.display_name):
271         * QueueStatusServer/model/queues_unittest.py:
272         (QueueTest.test_short_name):
273         (QueueTest.test_display_name):
274         (QueueTest.test_name_with_underscores):
275         * QueueStatusServer/templates/activebots.html:
276
277 2013-04-10  Ojan Vafai  <ojan@chromium.org>
278
279         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
280         https://bugs.webkit.org/show_bug.cgi?id=114370
281
282         Reviewed by Ryosuke Niwa.
283
284         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
285         Unfortunately, there's no way to test this until this is committed and there is
286         a master restart.
287
288         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
289         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
290         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
291         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
294         * TestResultServer/generate_builders_json.py:
295         * TestResultServer/static-dashboards/dashboard_base.js:
296         * TestResultServer/static-dashboards/loader.js:
297
298 2013-04-10  Glenn Adams  <glenn@skynav.com>
299
300         [Qt] Fix regression to test-webkitpy.
301         https://bugs.webkit.org/show_bug.cgi?id=114368
302
303         Reviewed by Ryosuke Niwa.
304
305         * Scripts/webkitpy/layout_tests/port/factory.py:
306         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
307         (PortFactory.get): Remove obsolete chromium port related code.
308         * Scripts/webkitpy/layout_tests/port/mac.py:
309         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
310
311 2013-04-10  Anders Carlsson  <andersca@apple.com>
312
313         Remove unneeded headers from FrameLoader.h
314         https://bugs.webkit.org/show_bug.cgi?id=114223
315
316         Reviewed by Geoffrey Garen.
317
318         Add back headers implicitly included by other headers.
319
320         * WebKitTestRunner/WorkQueueManager.cpp:
321
322 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
323
324         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
325         https://bugs.webkit.org/show_bug.cgi?id=114365
326
327         Reviewed by Martin Robinson.
328
329         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
330         The patch addresses crashes in the tally_event_reply method. It is already committed into the
331         at-spi2-atk source tree and will be available with the next stable release, after which the
332         patch should be removed and the dependency version bumped.
333
334         * gtk/jhbuild.modules:
335         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
336
337 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
338
339         [WinCairo] Unreviewed build fix. Correct DropBox download link.
340
341         * Scripts/update-webkit-wincairo-libs: Revise download URL to
342         match change in DropBox server behavior.
343
344 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
345
346         Removed an annoying message from svn-create-patch
347         https://bugs.webkit.org/show_bug.cgi?id=114332
348
349         Reviewed by Alexey Proskuryakov.
350
351         I see this message basically every time I write a patch, so it must not
352         be true.
353
354         * Scripts/svn-create-patch:
355         (generateDiff):
356
357 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
358
359         [GTK] Add support for Page Visibility
360         https://bugs.webkit.org/show_bug.cgi?id=97324
361
362         Reviewed by Sam Weinig.
363
364         Implemented test runner API for page visibility layout tests.
365
366         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
367         (TestRunner::resetPageVisibility):
368         (TestRunner::setPageVisibility):
369         * Scripts/webkitperl/FeatureList.pm:
370
371 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
372
373         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
374         https://bugs.webkit.org/show_bug.cgi?id=114342
375
376         Reviewed by Gyuyoung Kim.
377
378         Commit 148033 only added an implementation for the Mac port, which made
379         other ports fail most tests since loading the injected bundle failed
380         with a missing symbol.
381
382         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
383         (WTR::AccessibilityUIElement::pathDescription):
384
385 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
386
387         [EFL] Add spell checking option to MiniBrowser
388         https://bugs.webkit.org/show_bug.cgi?id=114282
389
390         Reviewed by Ryosuke Niwa.
391
392         Spell checking is enabled by adding a flag (t/text-checking)
393         with launching MiniBrowser.
394
395         * MiniBrowser/efl/main.c:
396         (window_create):
397         (elm_main):
398
399 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
400
401         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
402         https://bugs.webkit.org/show_bug.cgi?id=113281
403
404         Reviewed by Darin Adler.
405
406         * Scripts/run-gtk-tests:
407         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
408
409 2013-04-09  Glenn Adams  <glenn@skynav.com>
410
411         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
412
413         Unreviewed.
414
415         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
416         (RunTest.test_build_check):
417
418 2013-04-09  Glenn Adams  <glenn@skynav.com>
419
420         [webkitpy] Remove chromium ports.
421         https://bugs.webkit.org/show_bug.cgi?id=114326
422
423         Reviewed by Dirk Pranke.
424
425         As a side effect, also:
426
427         - remove chromium builders from webkitpy.layout_tests.port.builders
428         - remove chromium builders from rebaseline
429         - rewrite chromium dependent tests in rebaseline_unittest
430         - remove chromium platform from garden-o-matic
431         - select apple platform as default platform in garden-o-matic
432         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
433
434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
436         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
437         (BaselineOptimizerTest.test_move_baselines):
438         (BaselineOptimizerTest.test_efl):
439         (BaselineOptimizerTest.test_no_add_mac_future):
440         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
441         (BaselineOptimizerTest.test_common_directory_includes_root):
442         (BaselineOptimizerTest.test_complex_shadowing):
443         (BaselineOptimizerTest.test_virtual_ports_filtered):
444         * Scripts/webkitpy/layout_tests/port/builders.py:
445         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
446         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
447         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
448         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
449         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
450         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
451         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
452         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
453         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
454         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
455         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
456         * Scripts/webkitpy/layout_tests/port/factory.py:
457         (platform_options):
458         (PortFactory):
459         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
460         (FactoryTest.test_qt):
461         (FactoryTest.test_get_from_builder_name):
462         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
463         (RunTest.test_build_check):
464         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
465         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
466         * Scripts/webkitpy/tool/commands/rebaseline.py:
467         (Rebaseline._builders_to_pull_from):
468         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
469         (_BaseTestCase):
470         (_BaseTestCase.setUp):
471         (TestRebaselineTest.setUp):
472         (TestRebaselineTest.test_baseline_directory):
473         (test_rebaseline_updates_expectations_file):
474         (test_rebaseline_does_not_include_overrides):
475         (test_rebaseline_test):
476         (test_rebaseline_test_and_print_scm_changes):
477         (test_rebaseline_and_copy_test):
478         (test_rebaseline_and_copy_test_no_existing_result):
479         (test_rebaseline_and_copy_test_with_lion_result):
480         (test_rebaseline_and_copy_no_overwrite_test):
481         (TestRebaselineExpectations.test_rebaseline_expectations):
482
483 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
484
485         newcommitbot (WKR) requires a subversion checkout
486         https://bugs.webkit.org/show_bug.cgi?id=114309
487
488         Reviewed by Benjamin Poulain.
489
490         Directly talk to the subversion server instead of relying on a local checkout.
491         This allows us to run WKR off of a git clone.
492
493         * Scripts/webkitpy/tool/commands/newcommitbot.py:
494         (NewCommitBot.next_work_item):
495         (NewCommitBot.process_work_item):
496
497 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
498
499         webkitbot refers to sheriffbot in help
500         https://bugs.webkit.org/show_bug.cgi?id=114307
501
502         Reviewed by Benjamin Poulain.
503
504         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
505
506         * Scripts/webkitpy/tool/bot/irc_command.py:
507         (Help):
508         (Help.execute):
509         (RollChromiumDEPS.execute):
510         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
511         (IRCBotTest.test_help):
512         * Scripts/webkitpy/tool/bot/sheriff.py:
513         (Sheriff.name):
514
515 2013-04-06  Roger Fong  <roger_fong@apple.com>
516
517         Kill old processes between runs on WinEWS bots.
518         Temporarily disable tests to let bots catch up again.
519
520         * EWSTools/start-queue-win.sh:
521         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
522         (WinEWS):
523
524 2013-04-09  Glenn Adams  <glenn@skynav.com>
525
526         [webkitpy] Remove chromium deprecated port support.
527         https://bugs.webkit.org/show_bug.cgi?id=114228
528
529         Reviewed by Ryosuke Niwa.
530
531         * Scripts/webkitpy/common/config/ports.py:
532         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
533         (ChromiumPort): Removed.
534         (ChromiumAndroidPort): Removed.
535         (ChromiumXVFBPort): Removed.
536         * Scripts/webkitpy/common/config/ports_unittest.py:
537         (DeprecatedPortTest.test_chromium_port): Removed.
538         (DeprecatedPortTest.test_chromium_android_port): Removed.
539         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
540         * Scripts/webkitpy/tool/steps/update_unittest.py:
541         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
542         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
543
544 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
545
546         AX: The bounding paths should be made available through accessibility
547         https://bugs.webkit.org/show_bug.cgi?id=113817
548
549         Reviewed by David Kilzer.
550
551         Add a pathDescription property for testing so that it's possible
552         to verify that a path is being returned correctly.
553
554         * DumpRenderTree/AccessibilityUIElement.cpp:
555         (getPathDescriptionCallback):
556         (AccessibilityUIElement::pathDescription):
557         (AccessibilityUIElement::getJSClass):
558         * DumpRenderTree/AccessibilityUIElement.h:
559         (AccessibilityUIElement):
560         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
561         (_CGPathEnumerationIteration):
562         (AccessibilityUIElement::pathDescription):
563         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
564         (AccessibilityUIElement::pathDescription):
565         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
566         (WTR::AccessibilityUIElement::pathDescription):
567         (WTR):
568         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
569         (AccessibilityUIElement):
570         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
571         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
572         (WTR::AccessibilityUIElement::pathDescription):
573         (WTR):
574
575 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
576
577         [EFL] Declare TEST_THEME_DIR in a single place.
578         https://bugs.webkit.org/show_bug.cgi?id=114285
579
580         Reviewed by Anders Carlsson.
581
582         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
583
584         * DumpRenderTree/efl/CMakeLists.txt:
585         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
586         (DumpRenderTreeChrome::createView):
587         (DumpRenderTreeChrome::createInspectorView):
588         (DumpRenderTreeChrome::initialize):
589         (DumpRenderTreeChrome::onDownloadRequest):
590         * EWebLauncher/CMakeLists.txt:
591         * EWebLauncher/main.c:
592         (findThemePath):
593         * EWebLauncher/url_bar.c:
594         (url_bar_add):
595         * MiniBrowser/efl/CMakeLists.txt:
596         * MiniBrowser/efl/main.c:
597         (window_create):
598         * TestWebKitAPI/PlatformEfl.cmake:
599         * TestWebKitAPI/efl/PlatformWebView.cpp:
600         (TestWebKitAPI::PlatformWebView::PlatformWebView):
601         * WebKitTestRunner/PlatformEfl.cmake:
602         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
603         (WTR::PlatformWebView::PlatformWebView):
604
605 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
606
607         [GTK][AC] upversion of clutter and its dependecy
608         https://bugs.webkit.org/show_bug.cgi?id=114016
609
610         Reviewed by Gustavo Noronha Silva.
611
612         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
613
614         * gtk/jhbuild-optional.modules:
615
616 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
617
618         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
619         https://bugs.webkit.org/show_bug.cgi?id=89875
620
621         Reviewed by Maciej Stachowiak.
622
623         Add unit tests to verify if the handling of the open, openat, creat syscall
624         is being done right. We check if the Read/Write/ReadAndWrite permissions
625         are respected, if the canonical path is being resolved and if
626         the permissions are falling back to the topmost parent directory with a
627         policy set when the directory being opened has no policy.
628
629         We also test if any attempt of blocking SIGSYS is silently ignored.
630         SIGSYS cannot be blocked because in it's handler is where we hook
631         syscalls to the broker process.
632
633         Also added libseccomp to EFL's jhbuild to make the life of developers
634         willing to help easier.
635
636         * Scripts/webkitperl/FeatureList.pm:
637         * TestWebKitAPI/PlatformEfl.cmake:
638         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
639         (TestWebKitAPI):
640         (SeccompEnvironment):
641         (TestWebKitAPI::SeccompEnvironment::SetUp):
642         (TestWebKitAPI::SeccompEnvironment::TearDown):
643         (TestWebKitAPI::dummyHandler):
644         (TestWebKitAPI::TEST):
645         (TestWebKitAPI::stressTest):
646         * efl/jhbuild.modules:
647         * qmake/mkspecs/features/features.pri:
648
649 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
650
651         REGRESSION: Autocorrection doesn't work in DumpRenderTree
652         https://bugs.webkit.org/show_bug.cgi?id=113846
653
654         Reviewed by Alexey Proskuryakov.
655
656         The problem was that we were replacing NSSpellCheck's dictionary with our own
657         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
658
659         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
660         and "would" respectively in DumpRenderTree.
661
662         * DumpRenderTree/mac/DumpRenderTree.mm:
663         (resetDefaultsToConsistentValues):
664
665 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
666
667         Remove the gyp files for Tools
668         https://bugs.webkit.org/show_bug.cgi?id=114248
669
670         Reviewed by Ryosuke Niwa.
671
672         * DumpRenderTree/DumpRenderTree.gyp: Removed.
673         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
674         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
675         * DumpRenderTree/DumpRenderTree.gypi: Removed.
676         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
677         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
678         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
679         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
680
681 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
682
683         WKR (new-commit-bot) is too slow
684         https://bugs.webkit.org/show_bug.cgi?id=110087
685
686         Reviewed by Geoffrey Garen.
687
688         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
689         Just run "svn log -r <revision>" instead to cut down the delay.
690
691         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
692
693         * Scripts/webkitpy/tool/commands/newcommitbot.py:
694         (NewCommitBot):
695         (NewCommitBot.next_work_item):
696         (NewCommitBot._is_empty_log):
697         (NewCommitBot._update_checkout):
698
699 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
700
701         Build fix. Can't remove appendCustomBuildFlags.
702
703         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
704         (appendCustomBuildFlags):
705
706 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
707
708         Remove Chromium builders from build.webkit.org
709         https://bugs.webkit.org/show_bug.cgi?id=113990
710
711         Reviewed by Benjamin Poulain.
712
713         Removed.
714
715         * BuildSlaveSupport/build.webkit.org-config/config.json:
716         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
717         (InstallGtkDependencies):
718         (RunUnitTests.start):
719         (RunWebKit2Tests.start):
720         (Factory.__init__):
721         (unitTestsSupported):
722         (TestFactory.__init__):
723         (BuildAndTestFactory.__init__):
724         (BuildAndPerfTestFactory.__init__):
725         (BuildAndPerfTestWebKit2Factory.__init__):
726         (DownloadAndPerfTestFactory.__init__):
727         (loadBuilderConfig):
728         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
729
730 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
731
732         Remove HTML Notification
733         https://bugs.webkit.org/show_bug.cgi?id=114231
734
735         Reviewed by Ryosuke Niwa.
736
737         * qmake/mkspecs/features/features.pri:
738
739 2013-04-08  Glenn Adams  <glenn@skynav.com>
740
741         Remove chromium EWS support, and fix broken test.
742         https://bugs.webkit.org/show_bug.cgi?id=114221
743
744         Reviewed by Ryosuke Niwa.
745
746         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
747         (AbstractChromiumEWS): Removed.
748         (ChromiumLinuxEWS): Removed.
749         (ChromiumLinuxDebugEWS): Removed.
750         (ChromiumWindowsEWS): Removed.
751         (ChromiumAndroidEWS): Removed.
752         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
753         (EarlyWarningSystemTest): Fix misspelled class name.
754         (test_ewses): Fix entry point name to ensure test is run.
755
756 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
757
758         [WIN] Remove WebKit2 source code
759         https://bugs.webkit.org/show_bug.cgi?id=114096
760
761         Reviewed by Anders Carlsson.
762
763         Remove the windows specific parts of the MiniBrowser.
764
765         * MiniBrowser/MiniBrowser.vcproj: Removed.
766         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
767         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
768         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
769         * MiniBrowser/win/BrowserView.cpp: Removed.
770         * MiniBrowser/win/BrowserView.h: Removed.
771         * MiniBrowser/win/BrowserWindow.cpp: Removed.
772         * MiniBrowser/win/BrowserWindow.h: Removed.
773         * MiniBrowser/win/MiniBrowser.cpp: Removed.
774         * MiniBrowser/win/MiniBrowser.h: Removed.
775         * MiniBrowser/win/MiniBrowser.rc: Removed.
776         * MiniBrowser/win/main.cpp: Removed.
777         * MiniBrowser/win/resource.h: Removed.
778         * MiniBrowser/win/stdafx.cpp: Removed.
779         * MiniBrowser/win/stdafx.h: Removed.
780
781 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
782
783         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
784
785         * Scripts/webkitpy/common/config/irc.py:
786
787 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
788
789         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
790         https://bugs.webkit.org/show_bug.cgi?id=113139
791
792         Reviewed by Anders Carlsson.
793
794         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
795         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
796         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
797         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
798         (ToStringAndValueOfObject):
799         (ToStringAndValueOfObject::ToStringAndValueOfObject):
800         (ScriptableObject):
801         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
802         (ToStringAndValueOfObject::ScriptableObject::invoke):
803         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
804         (ToStringAndValueOfObject::NPP_GetValue):
805         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
806         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
807         * GNUmakefile.am:
808
809 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
810
811         [GTK] Bump gnome-themes-standard to 3.6.0
812         https://bugs.webkit.org/show_bug.cgi?id=114155
813
814         Reviewed by Martin Robinson.
815
816         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
817         dependency of gnome-themes-standard accordingly.
818
819 2013-04-08  David Levin  <levin@chromium.org>
820
821         Remove my watchlist entries.
822         https://bugs.webkit.org/show_bug.cgi?id=114180
823
824         Reviewed by Adam Barth.
825
826         * Scripts/webkitpy/common/config/committers.py:
827         * Scripts/webkitpy/common/config/watchlist:
828
829 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
830
831         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
832         https://bugs.webkit.org/show_bug.cgi?id=114161
833
834         Reviewed by Gyuyoung Kim.
835
836         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
837         as it is crashing due to Bug 111074.
838
839         * TestWebKitAPI/PlatformEfl.cmake:
840
841 2013-04-07  David Kilzer  <ddkilzer@apple.com>
842
843         Remove the rest of SVG_DOM_OBJC_BINDINGS
844         <http://webkit.org/b/114112>
845
846         Reviewed by Geoffrey Garen.
847
848         * Scripts/webkitperl/FeatureList.pm:
849         - Remove --svg-dom-objc-bindings switch.
850         * qmake/mkspecs/features/features.pri:
851         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
852
853 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
854
855         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
856         https://bugs.webkit.org/show_bug.cgi?id=114089
857
858         Reviewed by Chris Fleizach.
859
860         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
861         * DumpRenderTree/AccessibilityController.cpp:
862         * DumpRenderTree/AccessibilityUIElement.cpp:
863         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
864         (DumpRenderTreeChrome::DumpRenderTreeChrome):
865         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
866         (DumpRenderTreeChrome):
867
868 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
869
870         Build fix after r147857, remove remaining USE(JSC) guards.
871
872         Unreviewed.
873
874         * DumpRenderTree/config.h:
875         * TestWebKitAPI/config.h:
876         * WebKitTestRunner/config.h:
877
878 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
879
880         Rename sheriffbot to webkitbot
881         https://bugs.webkit.org/show_bug.cgi?id=114109
882
883         Reviewed by Benjamin Poulain.
884
885         Renamed since sheriffbot will be used in Blink.
886
887         * Scripts/webkitpy/tool/commands/sheriffbot.py:
888         (SheriffBot):
889         (SheriffBot.begin_work_queue):
890
891 2013-04-06  Oliver Hunt  <oliver@apple.com>
892
893         Unify the many and varied stack trace mechanisms, and make the result sane.
894         https://bugs.webkit.org/show_bug.cgi?id=114072
895
896         Reviewed by Filip Pizlo.
897
898         The commandline jsc executable no longer requires arguments, so
899         I've made run-jsc work without them.
900
901         * Scripts/run-jsc:
902
903 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
904
905         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
906         https://bugs.webkit.org/show_bug.cgi?id=114086
907
908         Reviewed by Tim Horton.
909
910         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
911
912 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
913
914         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
915         https://bugs.webkit.org/show_bug.cgi?id=114083
916
917         Reviewed by Ryosuke Niwa.
918
919         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
920         in TestWebKitAPI and WebKitTestRunner.
921
922         * TestWebKitAPI/config.h:
923         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
924         (TestWebKitAPI::InjectedBundleController::platformInitialize):
925         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
926         (WTR::InjectedBundle::platformInitialize):
927
928 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
929
930         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
931         https://bugs.webkit.org/show_bug.cgi?id=114094
932
933         Reviewed by Anders Carlsson.
934
935         * Scripts/run-jsc:
936
937 2013-04-05  Ojan Vafai  <ojan@chromium.org>
938
939         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
940         https://bugs.webkit.org/show_bug.cgi?id=114080
941
942         Reviewed by Ryosuke Niwa.
943
944         This way, the WebKit and Blink dashboard code can change as appropriate without
945         needing to consider the other project's needs. This still doesn't update the
946         buildbots to upload to the new location, or the dashboard code to pull the
947         results.json files from the new location, but it at least allows for changing the
948         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
949
950         * TestResultServer/app.yaml:
951
952 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
953
954         Re-enable testing on the commit queue
955         https://bugs.webkit.org/show_bug.cgi?id=114078
956
957         Reviewed by Darin Adler.
958
959         Re-enabled the feature and the associated tests.
960
961         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
962         (CommitQueueTask.run):
963         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
964         (CommitQueueTaskTest._run_through_task):
965         * Scripts/webkitpy/tool/commands/queues_unittest.py:
966         (CommitQueueTest._mock_test_result):
967
968 2013-04-05  Oliver Hunt  <oliver@apple.com>
969
970         Unify the many and varied stack trace mechanisms, and make the result sane.
971         https://bugs.webkit.org/show_bug.cgi?id=114072
972
973         Reviewed by Filip Pizlo.
974
975         The commandline jsc executable no longer requires arguments, so
976         I've made run-jsc work without them.
977
978         * Scripts/run-jsc:
979
980 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
981
982         AX: Make SVG Group containers accessible elements
983         https://bugs.webkit.org/show_bug.cgi?id=113939
984
985         Reviewed by Simon Fraser.
986
987         Implement axController.elementAtPoint for iOS.
988         Implement a correct version of clickPoint for iOS.
989
990         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
991         (AccessibilityController::elementAtPoint):
992         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
993         (AccessibilityUIElement::clickPointX):
994         (AccessibilityUIElement::clickPointY):
995
996 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
997
998         Unreviewed, rolling out r147773 and r147774.
999         http://trac.webkit.org/changeset/147773
1000         http://trac.webkit.org/changeset/147774
1001         https://bugs.webkit.org/show_bug.cgi?id=114056
1002
1003         Causing some exceptions on AppEngine I don't understand
1004         (Requested by rniwa on #webkit).
1005
1006         * QueueStatusServer/config/queues.py:
1007         * QueueStatusServer/model/queues.py:
1008         (Queue.short_name):
1009         (Queue.display_name):
1010         * QueueStatusServer/model/queues_unittest.py:
1011         (QueueTest.test_short_name):
1012         (QueueTest.test_display_name):
1013         (QueueTest.test_name_with_underscores):
1014
1015 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
1016
1017         Fixed run-bindings-tests by removing V8
1018         https://bugs.webkit.org/show_bug.cgi?id=114053
1019
1020         Reviewed by Benjamin Poulain.
1021
1022         * Scripts/run-bindings-tests:
1023         (main):
1024
1025 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1026
1027         Build fix.
1028
1029         * QueueStatusServer/model/queues.py:
1030         (Queue.short_name):
1031         (Queue.display_name):
1032
1033 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1034
1035         Remove Chromium EWS bots from the queue status server
1036         https://bugs.webkit.org/show_bug.cgi?id=113988
1037
1038         Reviewed by Benjamin Poulain.
1039
1040         Removed Chromium EWS bots.
1041
1042         * QueueStatusServer/config/queues.py:
1043         * QueueStatusServer/model/queues.py:
1044         (Queue.short_name):
1045         (Queue.display_name):
1046         * QueueStatusServer/model/queues_unittest.py:
1047         (QueueTest.test_short_name):
1048         (QueueTest.test_display_name):
1049         (QueueTest.test_name_with_underscores):
1050
1051 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1052
1053         [EFL] Enable indexed database
1054         https://bugs.webkit.org/show_bug.cgi?id=107248
1055
1056         Reviewed by Alexis Menard.
1057
1058         * Scripts/webkitperl/FeatureList.pm:
1059
1060 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1061
1062         Remove vestiges of Chromium bits from watchlists.
1063         https://bugs.webkit.org/show_bug.cgi?id=114047
1064
1065         Reviewed by Ryosuke Niwa.
1066
1067         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1068
1069 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1070
1071         Add James Craig to the contributors list.
1072
1073         * Scripts/webkitpy/common/config/committers.py:
1074
1075 2013-04-04  Kent Tamura  <tkent@chromium.org>
1076
1077         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1078
1079         * Scripts/webkitpy/common/config/watchlist:
1080
1081 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1082
1083         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1084         https://bugs.webkit.org/show_bug.cgi?id=113997
1085
1086         Reviewed by Ryosuke Niwa.
1087
1088         Disable the tests until Ryosuke gets the time and hardware to have
1089         a testing commit-queue.
1090
1091         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1092         (CommitQueueTaskTest):
1093         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1094         (CommitQueueTest):
1095
1096 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1097
1098         Remove Chromium builders from build.webkit.org
1099         https://bugs.webkit.org/show_bug.cgi?id=113990
1100
1101         Reviewed by Benjamin Poulain.
1102
1103         Land the part to disable triggering of Chromium builders first so that we may start
1104         deleting more Chromium code that breaks the update step.
1105
1106         * BuildSlaveSupport/build.webkit.org-config/config.json:
1107
1108 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1109
1110         Remove Chromium's DumpRenderTree
1111         https://bugs.webkit.org/show_bug.cgi?id=113989
1112
1113         Reviewed by Kent Tamura.
1114
1115         On second thought, let's not go to Camelot. It is a silly place.
1116
1117         * DumpRenderTree/mac/DumpRenderTree.mm:
1118         (resetDefaultsToConsistentValues):
1119
1120 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1121
1122         Nixed the defunct chromium folder from DumpRenderTree
1123         https://bugs.webkit.org/show_bug.cgi?id=113993
1124
1125         Reviewed by Ryosuke Niwa.
1126
1127         * DumpRenderTree/chromium: Removed.
1128         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1129         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1130         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1131         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1132         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1133         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1134         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1135         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1136         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1137         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1138         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1139         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1140         * DumpRenderTree/chromium/Task.cpp: Removed.
1141         * DumpRenderTree/chromium/Task.h: Removed.
1142         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1143         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1144         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1145         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1146         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1147         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1148         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1149         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1150         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1151         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1152         * DumpRenderTree/chromium/TestRunner: Removed.
1153         * DumpRenderTree/chromium/TestRunner/public: Removed.
1154         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1155         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1156         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1157         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1158         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1159         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1160         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1161         * DumpRenderTree/chromium/TestRunner/src: Removed.
1162         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1163         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1164         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1165         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1166         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1167         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1168         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1169         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1170         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1171         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1172         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1173         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1174         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1175         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1176         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1177         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1178         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1179         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1180         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1181         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1182         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1183         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1184         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1185         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1186         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1187         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1188         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1189         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1190         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1191         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1192         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1193         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1194         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1195         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1196         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1197         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1198         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1199         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1200         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1201         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1202         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1203         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1204         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1205         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1206         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1207         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1208         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1209         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1210         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1211         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1212         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1213         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1214         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1215         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1216         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1217         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1218         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1219         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1220         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1221         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1222         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1223         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1224         * DumpRenderTree/chromium/TestShell.h: Removed.
1225         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1226         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1227         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1228         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1229         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1230         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1231         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1232         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1233         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1234         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1235         * DumpRenderTree/chromium/config.h: Removed.
1236         * DumpRenderTree/chromium/fonts.conf: Removed.
1237
1238 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1239
1240         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1241
1242         Rubber stamped by Benjamin Poulain.
1243
1244         * RebaselineQueueServer: Removed.
1245         * RebaselineQueueServer/app.yaml: Removed.
1246         * RebaselineQueueServer/handlers: Removed.
1247         * RebaselineQueueServer/handlers/__init__.py: Removed.
1248         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1249         * RebaselineQueueServer/handlers/pages.py: Removed.
1250         * RebaselineQueueServer/index.yaml: Removed.
1251         * RebaselineQueueServer/main.py: Removed.
1252         * RebaselineQueueServer/model: Removed.
1253         * RebaselineQueueServer/model/__init__.py: Removed.
1254         * RebaselineQueueServer/model/queueentry.py: Removed.
1255         * RebaselineQueueServer/static: Removed.
1256         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1257         * RebaselineQueueServer/static/styles.css: Removed.
1258         * RebaselineQueueServer/templates: Removed.
1259         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1260         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1261         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1262         * RebaselineQueueServer/templates/home.html: Removed.
1263
1264 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1265
1266         Fix setup-commit-queue and temporarily disable testing on commit-queue
1267         https://bugs.webkit.org/show_bug.cgi?id=113979
1268
1269         Reviewed by Benjamin Poulain.
1270
1271         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1272         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1273
1274         * EWSTools/setup-commit-queue.sh:
1275         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1276         (CommitQueueTask.run):
1277
1278 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1279
1280         temporarily make flakiness dashboard work again webkit.org bots
1281         https://bugs.webkit.org/show_bug.cgi?id=113972
1282
1283         Reviewed by Ojan Vafai.
1284
1285         This patch disables the chromium.org layout test bots TestExpectations
1286         parsing temporarily until we can work out the right way to split into
1287         two instances for webkit.org and chromium.org and figure out which
1288         code to delete where :).
1289
1290         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1291
1292 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1293
1294         Fix webkitpy tests after r147678.
1295
1296         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1297         (CommitQueueTest.test_commit_queue):
1298         (test_manual_reject_during_processing):
1299
1300 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1301
1302         The commit queue should use Mac MountainLion port
1303         https://bugs.webkit.org/show_bug.cgi?id=113971
1304
1305         Reviewed by Lucas Forschler.
1306
1307         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1308         * Scripts/webkitpy/tool/commands/queues.py:
1309         (CommitQueue):
1310
1311 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1312
1313         turn off running tests on chromium linux EWS bots
1314         https://bugs.webkit.org/show_bug.cgi?id=113959
1315
1316         Reviewed by Geoffrey Garen.
1317
1318         Now that the Chromium port is no longer being maintained
1319         there's little point in running the tests. Soon we should
1320         just shut this bot off altogether.
1321
1322         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1323         (ChromiumLinuxEWS):
1324
1325 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1326
1327         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1328
1329         * Scripts/webkitpy/common/config/watchlist:
1330
1331 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1332
1333         Indentation fix to get webkit-patch working again after r147625
1334
1335         Unreviewed.
1336
1337         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1338         (MacEWS):
1339         (MacWK2EWS):
1340
1341 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1342
1343         Turn tests back on for Mac WK1/WK2 EWS.
1344         
1345         Unreviewed.
1346         
1347         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1348         (MacEWS):
1349         (MacWK2EWS):
1350
1351 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1352
1353         [GTK][WK2] MiniBrowser custom URI scheme support
1354         https://bugs.webkit.org/show_bug.cgi?id=112419
1355
1356         Reviewed by Carlos Garcia Campos.
1357
1358         Add support for about URIs in MiniBrowser. An example about page is show
1359         with URI "about:minibrowser", the rest of the cases it will show a
1360         proper message explaining that the about page didn't exist.
1361
1362         Internally it uses "minibrowser-about" prefix instead of "about", but
1363         from the user point of view it works with "about" prefix.
1364
1365         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1366         (getInternalURI): Method to convert URIs from "about" prefix to
1367         "minibrowser-about".
1368         (getExternalURI): Opposite method.
1369         (webViewURIChanged): Use "about" prefix to show the URI to users.
1370         (webViewEnterFullScreen): Ditto.
1371         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1372         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1373         (aboutURISchemeRequestCallback): Callback to manage about calls.
1374         (main): Register the URI scheme to manage about URIs.
1375
1376 2013-04-03  Roger Fong  <roger_fong@apple.com>
1377
1378         Re-enable WinEWS tests.
1379
1380         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1381         (WinEWS):
1382
1383 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1384
1385         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1386         https://bugs.webkit.org/show_bug.cgi?id=113883
1387
1388         Reviewed by Martin Robinson.
1389
1390         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1391         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1392         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1393
1394 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1395
1396         [GTK] Include Pango in jhbuild-optional.modules
1397         https://bugs.webkit.org/show_bug.cgi?id=113878
1398
1399         Reviewed by Martin Robinson.
1400
1401         Since r147547 Pango 1.32.0 is required. Including the module in the
1402         JHBuild optional moduleset.
1403
1404         * gtk/jhbuild-optional.modules: Add Pango module.
1405
1406 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1407
1408         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1409         https://bugs.webkit.org/show_bug.cgi?id=113864
1410
1411         Moving setDefersLoading from TestRunnerQt to TestRunner
1412         requires access to the non-Qt TestRunner.
1413         As long as we instantiate both TestRunner and TestRunnerQt,
1414         we need a separate getter for the non-Qt TestRunner instance.
1415
1416         Reviewed by Simon Hausmann.
1417
1418         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1419         (WebPage::resetSettings):
1420         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1421         (DumpRenderTree::jscTestRunner):
1422         * DumpRenderTree/qt/TestRunnerQt.cpp:
1423         (TestRunner::setDefersLoading):
1424             Moving setDefersLoading from TestRunnerQt
1425             to TestRunner.
1426         * DumpRenderTree/qt/TestRunnerQt.h:
1427         (TestRunnerQt):
1428
1429 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1430
1431         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1432         https://bugs.webkit.org/show_bug.cgi?id=104779
1433
1434         Reviewed by Carlos Garcia Campos.
1435
1436         * Scripts/run-gtk-tests:
1437         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1438         passing in current trunk.
1439
1440 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1441
1442         Fix HAVE(QTTESTSUPPORT) logic
1443
1444         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1445         resulting in HAVE(QTTESTSUPPORT) never being true.
1446         Move that logic down in sanitizeFeatures.
1447
1448         Rubber-stamped by Tor Arne Vestbø.
1449
1450         * qmake/mkspecs/features/features.prf:
1451
1452 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1453
1454         [GTK] Bump required versions of some dependencies
1455         https://bugs.webkit.org/show_bug.cgi?id=113282
1456
1457         Reviewed by Martin Robinson.
1458
1459         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1460
1461 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1462
1463         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1464         https://bugs.webkit.org/show_bug.cgi?id=113809
1465
1466         Reviewed by Philippe Normand.
1467
1468         Newer Linux kernels have removed some deprecated macros from v4l2
1469         headers, causing gst-plugins-good's build to break. We don't need it
1470         right now, so just disable it.
1471
1472         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1473
1474 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1475
1476         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1477         https://bugs.webkit.org/show_bug.cgi?id=113535
1478
1479         Reviewed by Simon Hausmann.
1480
1481         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1482
1483         * qmake/mkspecs/features/features.prf:
1484
1485 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1486
1487         [Qt] Move logic of simple forwarding functions to TestRunner.
1488         https://bugs.webkit.org/show_bug.cgi?id=113863
1489
1490         Reviewed by Simon Hausmann.
1491
1492         * DumpRenderTree/qt/TestRunnerQt.cpp:
1493         (TestRunner::setTextDirection):
1494         (TestRunner::goBack):
1495         (TestRunner::evaluateScriptInIsolatedWorld):
1496         (TestRunner::addUserStyleSheet):
1497         * DumpRenderTree/qt/TestRunnerQt.h:
1498         (TestRunnerQt):
1499
1500 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1501
1502         [Qt] Disable media support using QuickTime if deployment target != SDK
1503
1504         We link to a single libWebKitSystemInterface static lib, so unless the
1505         deployment target matches the SDK let's not pretend like we'll be able
1506         to run on anything lower than the SDK version.
1507
1508         Reviewed by Simon Hausmann.
1509
1510         * qmake/mkspecs/features/features.prf:
1511
1512 2013-04-02  James Craig  <james@cookiecrook.com>
1513
1514         AXRoleDescripton for DL is "list"; should be "description list"
1515         https://bugs.webkit.org/show_bug.cgi?id=111665
1516
1517         Reviewed by Chris Fleizach.
1518
1519         Defining the role and description strings.
1520
1521         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1522
1523 2013-04-02  Roger Fong  <roger_fong@apple.com>
1524
1525         Unreviewed. Disable running tests on Win EWS queue.
1526
1527         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1528         (WinEWS):
1529
1530 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1531
1532         Disable running tests on the MAC WK2 EWS queue.
1533         
1534         Unreviewed.
1535         
1536         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1537         (MacWK2EWS):
1538
1539 2013-04-02  Julie Parent  <jparent@chromium.org>
1540
1541         Dashboard refactor: Move dashboard specific history related features to History.
1542         https://bugs.webkit.org/show_bug.cgi?id=113717
1543
1544         Reviewed by Ojan Vafai.
1545         
1546         Each dashboard now creates its own History object, with a custom
1547         configuration. This changes from just overriding global functions
1548         to passing in callbacks for generatePage, handleValidHashParameter,
1549         and handleQueryParameterChange. Same with passing in defaultStateValues
1550         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1551         variables.
1552         
1553         All functions related to these features are now (mostly) private
1554         function on History. 
1555         
1556         Loader no longer needs a loadingComplete callback, since it can just
1557         initialize the history object itself.
1558
1559         * TestResultServer/static-dashboards/aggregate_results.js:
1560         (handleValidHashParameter):
1561         * TestResultServer/static-dashboards/dashboard_base.js:
1562         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1563         (generatePage):
1564         (.switch.return):
1565         (handleQueryParameterChange):
1566         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1567         (resetGlobals):
1568         * TestResultServer/static-dashboards/history.js:
1569         (.):
1570         * TestResultServer/static-dashboards/loader.js:
1571         (.):
1572         * TestResultServer/static-dashboards/loader_unittests.js:
1573         * TestResultServer/static-dashboards/timeline_explorer.js:
1574         (generatePage):
1575         (initCurrentBuilderTestResults):
1576         * TestResultServer/static-dashboards/treemap.js:
1577         (generatePage):
1578         (.switch.return):
1579         (handleQueryParameterChange):
1580
1581 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1582
1583         Unreviewed, rolling out r147401.
1584         http://trac.webkit.org/changeset/147401
1585         https://bugs.webkit.org/show_bug.cgi?id=113767
1586
1587         The patch makes it extremely hard to set up the dependencies
1588         properly on the GTK builders (Requested by zdobersek on
1589         #webkit).
1590
1591         * gtk/jhbuild.modules:
1592
1593 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1594
1595         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1596         https://bugs.webkit.org/show_bug.cgi?id=113382
1597
1598         Reviewed by Gyuyoung Kim.
1599
1600         Do not show the empty tooltip box if the text is null.
1601
1602         * MiniBrowser/efl/main.c:
1603         (popup_menu_populate):
1604
1605 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1606
1607         [GTK] Bump required versions of some dependencies
1608         https://bugs.webkit.org/show_bug.cgi?id=113282
1609
1610         Reviewed by Martin Robinson.
1611
1612         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1613
1614 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1615
1616         Unreviewed, rolling out r147319.
1617         http://trac.webkit.org/changeset/147319
1618         https://bugs.webkit.org/show_bug.cgi?id=113707
1619
1620         The unit test is still failing on the buildbot (Requested by
1621         zdobersek on #webkit).
1622
1623         * Scripts/run-gtk-tests:
1624         (TestRunner):
1625
1626 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1627
1628         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1629         https://bugs.webkit.org/show_bug.cgi?id=104779
1630
1631         Reviewed by Carlos Garcia Campos.
1632
1633         * Scripts/run-gtk-tests:
1634         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1635         passing in current trunk.
1636
1637 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1638
1639         Unreviewed, rolling out r147289.
1640         http://trac.webkit.org/changeset/147289
1641         https://bugs.webkit.org/show_bug.cgi?id=113678
1642
1643         broke Win7 (dbg) build (Requested by shinyak|gardener on
1644         #webkit).
1645
1646         * DumpRenderTree/DumpRenderTree.gypi:
1647         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1648         (WebTestRunner):
1649         (WebUserMediaClientMock):
1650         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1651         (WebTestRunner::WebUserMediaClientMock::taskList):
1652         * Scripts/webkitpy/style/checkers/cpp.py:
1653         (check_function_definition):
1654
1655 2013-03-31  Adam Barth  <abarth@webkit.org>
1656
1657         configure-svn-config.sh fails
1658         https://codereview.chromium.org/13392007/
1659
1660         Reviewed by Eric Seidel.
1661
1662         This script was trying to use "svn checkout" to dowload a file from
1663         svn.webkit.org, but "svn checkout" only works with directories.
1664         Instead, we should use "svn export".
1665
1666         * EWSTools/configure-svn-config.sh:
1667
1668 2013-03-31  Wei Jia  <wjia@chromium.org>
1669
1670         Allow WebUserMediaClientMock to be used by client
1671         https://bugs.webkit.org/show_bug.cgi?id=113633
1672
1673         Reviewed by Adam Barth.
1674
1675         Export WebUserMediaClientMock.
1676         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1677
1678         * DumpRenderTree/DumpRenderTree.gypi:
1679         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1680         (WebUserMediaClientMock):
1681         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1682         * Scripts/webkitpy/style/checkers/cpp.py:
1683         (check_function_definition):
1684
1685 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1686
1687         Expose FeatureObserver data to WebKit clients
1688         https://bugs.webkit.org/show_bug.cgi?id=113613
1689
1690         Reviewed by Sam Weinig.
1691
1692         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1693         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1694
1695 2013-03-29  Greg Hughes  <ghughes@apple.com>
1696
1697         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1698         https://bugs.webkit.org/show_bug.cgi?id=112276
1699
1700         Reviewed by Chris Fleizach.
1701
1702         Added support to test accessibility search predicates with multiple keys.  
1703
1704         * DumpRenderTree/AccessibilityUIElement.cpp:
1705         (uiElementForSearchPredicateCallback):
1706         * DumpRenderTree/AccessibilityUIElement.h:
1707         (AccessibilityUIElement):
1708         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1709         (AccessibilityUIElement::uiElementForSearchPredicate):
1710         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1711         (AccessibilityUIElement::uiElementForSearchPredicate):
1712         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1713         (AccessibilityUIElement::uiElementForSearchPredicate):
1714         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1715         (AccessibilityUIElement::uiElementForSearchPredicate):
1716         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1717         (AccessibilityUIElement::uiElementForSearchPredicate):
1718         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1719         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1720         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1721         (AccessibilityUIElement):
1722         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1723         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1724         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1725         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1726         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1727
1728 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1729
1730         Fix a typo in r147147 to fix Mac EWS.
1731
1732         * Scripts/webkitpy/tool/commands/queues.py:
1733         (PatchProcessingQueue._new_port_name_from_old):
1734
1735 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1736
1737         [EFL] Build break with latest EFL libraries after r146265
1738         https://bugs.webkit.org/show_bug.cgi?id=113558
1739
1740         Unreviewed build fix.
1741
1742         * TestWebKitAPI/PlatformWebView.h:
1743         * WebKitTestRunner/PlatformWebView.h:
1744
1745 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1746
1747         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1748
1749         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1750         in libgcrypt build.
1751
1752 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1753
1754         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1755
1756         Unreviewed.
1757
1758         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1759         (MacEWS):
1760
1761 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1762
1763         Use the right OS name on Mac EWS instead of mac-future.
1764
1765         Rubber-stamped by Dirk Pranke.
1766
1767         * Scripts/webkitpy/tool/commands/queues.py:
1768         (PatchProcessingQueue._new_port_name_from_old):
1769         (PatchProcessingQueue.begin_work_queue):
1770         (PatchProcessingQueue._upload_results_archive_for_patch):
1771
1772 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1773
1774         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1775         https://bugs.webkit.org/show_bug.cgi?id=112546
1776
1777         Reviewed by Martin Robinson.
1778
1779         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1780         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1781
1782 2013-03-28  Ming Xie  <mxie@blackberry.com>
1783
1784         [BlackBerry] Committer Email Updates
1785         https://bugs.webkit.org/show_bug.cgi?id=113435
1786
1787         Reviewed by Rob Buis.
1788
1789         Add the @blackberry.com email address for all our BlackBerry
1790         WebKit committers. This is the first step for our email address
1791         migration.
1792
1793         * Scripts/webkitpy/common/config/committers.py:
1794
1795 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1796
1797         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1798         https://bugs.webkit.org/show_bug.cgi?id=113508
1799
1800         Reviewed by Martin Robinson.
1801
1802         Prevent the GStreamer plugin scanner to load system-wide
1803         plugins. Only the ones built in JHBuild should be loaded and used
1804         at runtime.
1805
1806         * efl/jhbuildrc:
1807         * gtk/jhbuildrc:
1808
1809 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1810
1811         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1812         https://bugs.webkit.org/show_bug.cgi?id=113386
1813
1814         Reviewed by Carlos Garcia Campos.
1815
1816         * Scripts/webkitdirs.pm:
1817         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1818         version to 3.0. Reflect this change so the builtDylibPathForName
1819         function doesn't fail to report the library as found.
1820
1821 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1822
1823         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1824         https://bugs.webkit.org/show_bug.cgi?id=113484
1825
1826         Unreviewed build fix.
1827
1828         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1829
1830         * TestWebKitAPI/CMakeLists.txt:
1831         * WebKitTestRunner/CMakeLists.txt:
1832
1833 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1834
1835         Revision for the internal jhbuild is too old
1836         https://bugs.webkit.org/show_bug.cgi?id=113324
1837
1838         Reviewed by Martin Robinson.
1839
1840         Update the minimum required version to a point where jhbuild won't
1841         fail installing packages when trying to remove a symlink to a directory.
1842
1843         * jhbuild/jhbuild-wrapper: Updated revision.
1844
1845 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1846
1847         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1848         https://bugs.webkit.org/show_bug.cgi?id=113203
1849
1850         Reviewed by Philippe Normand.
1851
1852         We build our libsoup without GNOME support. gst-plugins-good does separate
1853         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1854         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1855         build failures as the headers of those diverge. We do not use souphttpsrc, so
1856         disable it when building gst-plugins-good.
1857
1858         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1859
1860 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1861
1862         Build fix after r146852. Please another reference to the Lion leaks builder.
1863
1864         * BuildSlaveSupport/build.webkit.org-config/config.json:
1865
1866 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1867
1868         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1869         https://bugs.webkit.org/show_bug.cgi?id=113421
1870
1871         Reviewed by Dirk Pranke.
1872
1873         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1874         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1875         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1876         in the GTK-specific TestExpectations files.
1877
1878         To avoid this only enable the warnings only when not using WKTR.
1879
1880         * Scripts/webkitpy/layout_tests/port/gtk.py:
1881         (GtkPort.warn_if_bug_missing_in_test_expectations):
1882
1883 2013-03-27  Antti Koivisto  <antti@apple.com>
1884
1885         Fix Zalan's email.
1886
1887         * Scripts/webkitpy/common/config/committers.py:
1888
1889 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1890
1891         master.cfg cleanup
1892         https://bugs.webkit.org/show_bug.cgi?id=113195
1893
1894         Reviewed by Ryosuke Niwa.
1895
1896         * BuildSlaveSupport/build.webkit.org-config/config.json:
1897         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1898
1899 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1900
1901         master.cfg fine-tuning for Qt Mountain Lion Release bot
1902         https://bugs.webkit.org/show_bug.cgi?id=113191
1903
1904         Reviewed by Ryosuke Niwa.
1905
1906         * BuildSlaveSupport/build.webkit.org-config/config.json:
1907           - Rename the slave due to its location change.
1908           - Update the platform of the slave.
1909         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1910         (RunQtAPITests): Enable running WK2 API tests on Qt.
1911         (RunQtAPITests.start):
1912         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1913         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1914
1915 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1916
1917         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1918         https://bugs.webkit.org/show_bug.cgi?id=113403
1919
1920         Reviewed by Kenneth Rohde Christiansen.
1921
1922         As of Evas 1.7.5, when Wayland is detected on the system, support for
1923         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1924         The code, however, seems to depend on a few other flags which must be
1925         explicitly enabled.
1926
1927         If those additional GL-related options are passed, we end up
1928         having issues on the WebKit side, so disable Wayland support for
1929         now.
1930
1931         * efl/jhbuild.modules:
1932
1933 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1934
1935         Unreviewed, rolling out r146864.
1936         http://trac.webkit.org/changeset/146864
1937         https://bugs.webkit.org/show_bug.cgi?id=113391
1938
1939         causes crashes on Wk2 EFL release bot (Requested by drott on
1940         #webkit).
1941
1942         * Scripts/webkitperl/FeatureList.pm:
1943
1944 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1945
1946         [jhbuild] Correctly specify an alternate number of make jobs.
1947         https://bugs.webkit.org/show_bug.cgi?id=113396
1948
1949         Reviewed by Philippe Normand.
1950
1951         So far, we were using the `MAKEFLAGS' environment variable to pass the
1952         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1953         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1954
1955         We now behave more closely to the rest of the WebKit tools by first
1956         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1957         not set, just letting jhbuild itself figure out how many jobs to use.
1958
1959         * efl/jhbuildrc:
1960         * gtk/jhbuildrc:
1961
1962 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1963
1964         [Qt] Remove Qt specific WorkQueueItem definitions.
1965         https://bugs.webkit.org/show_bug.cgi?id=112891
1966
1967         This patch is preparation work for removing
1968         WorkQueue related code from TestRunnerQt and
1969         replacing it with generic TestRunner code.
1970
1971         Reviewed by Benjamin Poulain.
1972
1973         * DumpRenderTree/qt/TestRunnerQt.cpp:
1974         (TestRunnerQt::queueBackNavigation):
1975         (TestRunnerQt::queueForwardNavigation):
1976         (TestRunnerQt::queueLoadHTMLString):
1977         (TestRunnerQt::queueReload):
1978         (TestRunnerQt::queueLoadingScript):
1979         (TestRunnerQt::queueNonLoadingScript):
1980         (TestRunner::queueLoad):
1981         * DumpRenderTree/qt/TestRunnerQt.h:
1982         (TestRunnerQt):
1983         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1984         (LoadItem::invoke):
1985         (LoadHTMLStringItem::invoke):
1986         (LoadAlternateHTMLStringItem::invoke):
1987         (ReloadItem::invoke):
1988         (ScriptItem::invoke):
1989         (BackForwardItem::invoke):
1990         * DumpRenderTree/qt/WorkQueueItemQt.h:
1991         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1992         (LoadAlternateHTMLStringItem):
1993
1994 2013-03-26  Julie Parent  <jparent@chromium.org>
1995
1996         Flakiness dashboard: simplify logic around which tests to show.
1997         https://bugs.webkit.org/show_bug.cgi?id=113250
1998
1999         Reviewed by Ojan Vafai.
2000         
2001         The different filters for showing results are only used for layout
2002         tests, otherwise, we show everything.
2003         
2004         Change the defaults to false (what layout tests used), and only
2005         look at the values when viewing layout tests.
2006
2007         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2008         (htmlForTestsWithExpectationsButNoFailures):
2009         (shouldHideTest):
2010
2011 2013-03-26  Isaac Levy  <ilevy@google.com>
2012
2013         Update bots on test-results.appspot
2014         https://bugs.webkit.org/show_bug.cgi?id=113333
2015
2016         Reviewed by Ojan Vafai.
2017
2018         * TestResultServer/static-dashboards/builders.jsonp:
2019
2020 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2021
2022         Unreviewed GTK gardening.
2023
2024         * Scripts/run-gtk-tests:
2025         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2026
2027 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2028
2029         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2030         https://bugs.webkit.org/show_bug.cgi?id=113287
2031
2032         Reviewed by Jocelyn Turcotte.
2033
2034         * Scripts/run-qtwebkit-tests:
2035         (Options.__init__):
2036
2037 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2038
2039         [EFL] Enable IndexedDB by default
2040         https://bugs.webkit.org/show_bug.cgi?id=107248
2041
2042         Reviewed by Laszlo Gombos.
2043
2044         * Scripts/webkitperl/FeatureList.pm:
2045         Enable IndexedDB by default on EFL.
2046
2047 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2048
2049         Sheriffbot should explain rollout failures in a human readable form.
2050         https://bugs.webkit.org/show_bug.cgi?id=107092
2051
2052         Reviewed by Ryosuke Niwa.
2053
2054         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2055
2056         * Scripts/webkitpy/tool/bot/irc_command.py:
2057         (Rollout._check_diff_failure):
2058         (Rollout.execute):
2059         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2060         (IRCCommandTest.test_rollout):
2061
2062 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2063
2064         Unreviewed GTK gardening.
2065
2066         * Scripts/run-gtk-tests:
2067         (TestRunner): Skipping a failing unit test after r146518.
2068
2069 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2070
2071         Remove Lion leaks builder
2072         https://bugs.webkit.org/show_bug.cgi?id=113252
2073
2074         Reviewed by Andreas Kling.
2075
2076         Removed.
2077
2078         * BuildSlaveSupport/build.webkit.org-config/config.json:
2079
2080 2013-03-25  Kent Tamura  <tkent@chromium.org>
2081
2082         Rename ENABLE_INPUT_TYPE_DATETIME
2083         https://bugs.webkit.org/show_bug.cgi?id=113254
2084
2085         Reviewed by Kentaro Hara.
2086
2087         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2088         Actually I'd like to remove the code, but we shouldn't remove it yet
2089         because we shipped products with it on some platforms.
2090
2091         * Scripts/webkitperl/FeatureList.pm:
2092         * qmake/mkspecs/features/features.pri:
2093
2094 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2095
2096         Remove one more line that was intended to be removed in r146657.
2097
2098         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2099         (summarize_results):
2100
2101 2013-03-25  Roger Fong  <roger_fong@apple.com>
2102
2103         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2104         Re-enable WinEWS tests.
2105
2106         * Scripts/webkitpy/common/config/ports.py:
2107         (WinPort.run_bindings_tests_command):
2108         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2109         (WinEWS):
2110
2111 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2112
2113         Unreviewed, rolling out r146793.
2114         http://trac.webkit.org/changeset/146793
2115         https://bugs.webkit.org/show_bug.cgi?id=113248
2116
2117         Fix did not work (Requested by rfong on #webkit).
2118
2119         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2120         (WinEWS):
2121
2122 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2123
2124         REGRESSION(r146657): Test failures reported incorrectly
2125         https://bugs.webkit.org/show_bug.cgi?id=113223
2126
2127         Reviewed by Dirk Pranke.
2128
2129         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2130
2131         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2132         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2133
2134         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2135         (Manager.run):
2136
2137         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2138         (RunDetails.__init__):
2139         (summarize_results): Remove the line I intended to remove in r146657.
2140
2141         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2142         (logging_run): Return details instead of the exit code.
2143         (run_and_capture): Ditto.
2144
2145         (RunTest.test_full_results_html):
2146         (RunTest.test_hung_thread):
2147         (RunTest.test_no_tests_found):
2148         (RunTest.test_no_tests_found_2):
2149         (RunTest.test_repeat_each_iterations_num_tests):
2150         (RunTest.test_run_singly_actually_runs_tests):
2151         (RunTest.test_test_list):
2152         (RunTest.test_missing_and_unexpected_results):
2153         (RunTest.test_pixel_test_directories):
2154         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2155         (RunTest.test_crash_with_stderr):
2156         (RunTest.test_no_image_failure_with_image_diff):
2157         (RunTest.test_crash_log):
2158         (RunTest.test_exit_after_n_failures_upload):
2159         (RunTest.test_results_directory_absolute):
2160         (RunTest.test_results_directory_relative):
2161         (RunTest.test_retrying_and_flaky_tests):
2162         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2163         (RunTest.test_retrying_uses_retries_directory):
2164         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2165         (RunTest.test_output_diffs):
2166         (EndToEndTest.test_reftest_with_two_notrefs):
2167         (RebaselineTest.test_reset_results):
2168         (RebaselineTest.test_missing_results):
2169         (RebaselineTest.test_new_baseline):
2170
2171         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2172         (BuildBotPrinter.print_results):
2173         (BuildBotPrinter.print_unexpected_results):
2174         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2175         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2176
2177 2013-03-25  Julie Parent  <jparent@chromium.org>
2178
2179         Dashboard refactor: Move cross dashboard history related code into history.js.
2180         https://bugs.webkit.org/show_bug.cgi?id=113104
2181
2182         Reviewed by Ojan Vafai.
2183
2184         All functions relating to cross dashboard behavior move from being
2185         globals to methods on the history.History object. Names stay the same,
2186         except many are made private, ones that should have been constants now
2187         are, and the long standing TODO to change "currentState" to 
2188         dashboardSpecificState is done.
2189         
2190         We now create a global history object in dashboard_base, as an 
2191         intermediate measure.  Once the dashboard specific code is
2192         added to history, each DB will need to create its own, and this
2193         global will be eliminated.
2194         
2195         * TestResultServer/static-dashboards/aggregate_results.js:
2196         (handleValidHashParameter):
2197         (htmlForBuilder):
2198         (rawValuesHTML):
2199         * TestResultServer/static-dashboards/dashboard_base.js:
2200         (parseDashboardSpecificParameters):
2201         (defaultValue):
2202         (currentBuilderGroupCategory):
2203         (currentBuilderGroupName):
2204         (handleLocationChange):
2205         (expectationsMap):
2206         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2207         (generatePage):
2208         (.switch.return):
2209         (platformAndBuildType):
2210         (individualTests):
2211         (substringList):
2212         (processMissingAndExtraExpectations):
2213         (pathToFailureLog):
2214         (showPopupForBuild):
2215         (htmlForTestsWithExpectationsButNoFailures):
2216         (shouldHideTest):
2217         (isCrossBuilderView):
2218         (tableHeaders):
2219         (htmlForSingleTestRow):
2220         (htmlForTableColumnHeader):
2221         (generatePageForExpectationsUpdate):
2222         (handleUpdate):
2223         (nextUpdate):
2224         (setUpdateIndex):
2225         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2226         (.appendExpectationsItem):
2227         (loadExpectations):
2228         (.dummyNode.onload):
2229         (loadExpectationsLayoutTests):
2230         (appendExpectations):
2231         (htmlForNavBar):
2232         (checkBoxToToggleState):
2233         (linkHTMLToToggleState):
2234         (generatePageForBuilder):
2235         (isInvalidKeyForCrossBuilderView):
2236         (handleQueryParameterChange):
2237         (showLegend):
2238         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2239         (resetGlobals):
2240         (test):
2241         * TestResultServer/static-dashboards/history.js:
2242         (.):
2243         * TestResultServer/static-dashboards/history_unittests.js:
2244         * TestResultServer/static-dashboards/loader.js:
2245         (.):
2246         * TestResultServer/static-dashboards/loader_unittests.js:
2247         * TestResultServer/static-dashboards/timeline_explorer.js:
2248         (generatePage):
2249         (initCurrentBuilderTestResults):
2250         (selectBuild):
2251         (showResultsDelta):
2252         * TestResultServer/static-dashboards/treemap.js:
2253         (generatePage):
2254         (.switch.return):
2255         (handleFocus):
2256         * TestResultServer/static-dashboards/ui.js:
2257
2258 2013-03-25  Roger Fong  <roger_fong@apple.com>
2259
2260         Unreviewed. Enable WinEWS tests again.
2261
2262         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2263         (WinEWS):
2264
2265 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2266
2267         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2268         https://bugs.webkit.org/show_bug.cgi?id=112166
2269
2270         HarfBuzz 0.9.14 merged my patch for icu detection without
2271         pkg-config files, as needed by for example Ubuntu 12.04.
2272         This obsoletes our local workaround. Removed it for GTK and EFL.
2273
2274         Reviewed by Martin Robinson.
2275
2276         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2277         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2278         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2279         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2280
2281 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2282
2283         Unreviewed.  Move self from contributor to committer list.
2284
2285         * Scripts/webkitpy/common/config/committers.py:
2286
2287 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2288
2289         EWS should use a human readable port name when uploading layout test archives
2290         https://bugs.webkit.org/show_bug.cgi?id=113099
2291
2292         Reviewed by Dirk Pranke.
2293
2294         Use new port's object's name() method to report human readable port names.
2295         This will also help us resolving the bug to apply layout test results posted by EWS.
2296
2297         * Scripts/webkitpy/tool/bot/botinfo.py:
2298         (BotInfo.__init__): Take port's name.
2299         (BotInfo.summary_text):
2300
2301         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2302         (BotInfoTest.test_summary_text):
2303
2304         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2305         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2306
2307         * Scripts/webkitpy/tool/commands/queues.py:
2308         (PatchProcessingQueue.__init__): Initialize self._port.
2309         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2310         and use that for the attachment filename and the comment posted.
2311
2312         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2313         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2314         "mac-snowleopard" as expected for TestPort.
2315
2316 2013-03-22  Roger Fong  <roger_fong@apple.com>
2317
2318         Unreviewed. Turn off EWS test on Win again.
2319         The battle continues.
2320
2321         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2322         (WinEWS):
2323
2324 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2325
2326         NRWT: Enable pixel tests when retrying tests
2327         https://bugs.webkit.org/show_bug.cgi?id=112898
2328
2329         Reviewed by Dirk Pranke.
2330
2331         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2332         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2333         if we've forced pixel tests in the retry.
2334         (Manager._run_tests):
2335         (Manager._clean_up_run): Fixed the capitalizations.
2336         (Manager._force_pixel_tests_if_needed): Added.
2337
2338         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2339         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2340         'image_diff_percent' if it doesn't already exist.
2341
2342         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2343         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2344         treat this as a regular regression instead of a flakiness.
2345
2346         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2347         run had image diffs.
2348
2349         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2350         (summarized_results):
2351
2352         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2353         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2354         Also removed some dead code.
2355
2356         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2357         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2358         is set and pixel_tests_enabled is set to false.
2359         (EndToEndTest.test_reftest_with_two_notrefs):
2360
2361 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2362
2363         Make it possible to run layout tests on Retina MBP
2364         https://bugs.webkit.org/show_bug.cgi?id=93673
2365
2366         Reviewed by Ryosuke Niwa.
2367
2368         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2369         windows on 2x machines still run at 1x.
2370
2371         * DumpRenderTree/mac/DumpRenderTree.mm:
2372         (createWebViewAndOffscreenWindow):
2373         Reset the window resolution to 1x on creation.
2374         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2375         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2376         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2377         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2378         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2379         (WTR::PlatformWebView::PlatformWebView):
2380         Add NSWindow details, reset the window resolution to 1x on creation.
2381
2382 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2383
2384         Leak bots shouldn't build
2385         https://bugs.webkit.org/show_bug.cgi?id=112774
2386
2387         Reviewed by Simon Fraser.
2388
2389         Since leak bots use regular debug builds, there is no need to build on these bots.
2390         Simply downloading builds will dramatically improve the cycle time of these bots.
2391
2392         * BuildSlaveSupport/build.webkit.org-config/config.json:
2393         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2394         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2395         TestFactory instead of BuildAndTestFactory.
2396
2397 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2398
2399         [Qt] Fix the TestWebKitAPI build
2400         https://bugs.webkit.org/show_bug.cgi?id=113044
2401
2402         Reviewed by Tor Arne Vestbø.
2403
2404         The generate-forwarding-headers script would only be run
2405         after the targets in InjectedBundle.pri since the second
2406         addStrictSubdirOrderBetween call in
2407         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2408         the derived_sources -> injected_bundle order in SUBDIRS.
2409
2410         Fix it by only moving the dependent target at the end of
2411         SUBDIRS, don't touch its dependency.
2412
2413         * qmake/mkspecs/features/functions.prf:
2414
2415 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2416
2417         [EFL][WK2] View is not focused when fullscreen mode toggled
2418         https://bugs.webkit.org/show_bug.cgi?id=113009
2419
2420         Reviewed by Laszlo Gombos.
2421
2422         Set focus on view when fullscreen mode enabled/disabled
2423         by FullScreen API.
2424
2425         * MiniBrowser/efl/main.c:
2426         (on_fullscreen_accept):
2427         (on_fullscreen_deny):
2428
2429 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2430
2431         nrwt is no longer saving retry results in the retries/ subdirectory
2432         https://bugs.webkit.org/show_bug.cgi?id=112995
2433
2434         Reviewed by Ojan Vafai.
2435
2436         I think this has been broken a long time, unfortunately. This
2437         patch should fix that.
2438
2439         In order to do so, I had to pass the directory to use from
2440         the Worker object through the SingleTestWriter to the
2441         TestResultWriter. While I was plumbing that through, I rationalized
2442         the order of the parameter arguments a bit ...
2443
2444         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2445         (Worker._run_single_test):
2446         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2447         (run_single_test):
2448         (SingleTestRunner.__init__):
2449         (SingleTestRunner._run_compare_test):
2450         (SingleTestRunner._run_rebaseline):
2451         (SingleTestRunner._run_reftest):
2452         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2453         (write_test_result):
2454         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2455         (TestResultWriterTest.test_reftest_diff_image):
2456         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2457         (RunTest.test_retrying_uses_retries_directory):
2458
2459 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2460
2461         JSC profiler should have an at-a-glance report of the success of DFG optimization
2462         https://bugs.webkit.org/show_bug.cgi?id=112988
2463
2464         Reviewed by Geoffrey Garen.
2465
2466         * Scripts/display-profiler-output:
2467
2468 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2469
2470         [chromium] Linux ASAN WebKit canary is running out of memory
2471         https://bugs.webkit.org/show_bug.cgi?id=112978
2472
2473         Reviewed by Tony Chang.
2474
2475         Running the AddressSanitizer on a crash takes a lot of
2476         memory, so we should serialize access to it to avoid running
2477         out of memory on a machine.
2478
2479         * Scripts/webkitpy/layout_tests/port/chromium.py:
2480         (ChromiumPort._get_crash_log):
2481         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2482         (HttpLock.__init__):
2483         (HttpLock.wait_for_httpd_lock):
2484
2485 2013-03-21  Min Qin  <qinmin@chromium.org>
2486
2487         Cleanup android media layout test code
2488         https://bugs.webkit.org/show_bug.cgi?id=112944
2489
2490         Reviewed by Adam Barth.
2491
2492         Chromium change: https://codereview.chromium.org/12892010/
2493         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2494         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2495         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2496         Instead, we should switch to use content shell for layout tests.
2497
2498         * DumpRenderTree/chromium/TestShell.cpp:
2499         (TestShell::resetTestController):
2500
2501 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2502
2503         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2504         https://bugs.webkit.org/show_bug.cgi?id=112953
2505
2506         Reviewed by Tony Chang.
2507
2508         When I created the DumpRenderTree_resources target in r144863 I
2509         forgot to declare the needed dependencies on the other resource
2510         targets. Due to a quirk of ordering, this appears to have been fine
2511         w/ ninja but not w/ Xcode (which is still being used on the chromium
2512         mac valgrind bots). Declaring the dependencies fixes the build
2513         failures.
2514
2515         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2516
2517 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2518
2519         [WinCairo] Correct assert in Empty BitmapImage Test.
2520         https://bugs.webkit.org/show_bug.cgi?id=112934
2521
2522         Reviewed by Tim Horton.
2523
2524         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2525         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2526         to avoid ref counting assertion when leaving test scope.
2527
2528 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2529
2530         [GTK] generate-feature-defines-files is incompatible with Python3
2531         https://bugs.webkit.org/show_bug.cgi?id=112956
2532
2533         Reviewed by Martin Robinson.
2534
2535         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2536         method on the dictionary objects when iterating through said dictionaries.
2537
2538         * gtk/generate-feature-defines-files:
2539         (write_feature_defines_header):
2540         (write_flattened_feature_defines_file):
2541
2542 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2543
2544         kill-old-processes spits out error messages on Mac
2545         https://bugs.webkit.org/show_bug.cgi?id=112878
2546
2547         Reviewed by Jessie Berlin.
2548
2549         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2550         included in the list of options grep --help shows.
2551
2552         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2553
2554         * BuildSlaveSupport/kill-old-processes:
2555         (main):
2556
2557 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2558
2559         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2560         https://bugs.webkit.org/show_bug.cgi?id=112597
2561
2562         Reviewed by Xan Lopez.
2563
2564         These were introduced for the Chromium port in r105295. We need
2565         dummy implementations in order to compile the BlackBerry port.
2566
2567         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2568         (AccessibilityUIElement::scrollToMakeVisible):
2569         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2570         (AccessibilityUIElement::scrollToGlobalPoint):
2571
2572 2013-03-21  Roger Fong  <roger_fong@apple.com>
2573
2574         Re-enable WinEWS tests following r146376.
2575
2576         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2577         (WinEWS):
2578
2579 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2580
2581         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2582
2583         * Scripts/webkitpy/common/config/committers.py:
2584
2585 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2586
2587         [GTK] Missing atk in install-dependencies script
2588         https://bugs.webkit.org/show_bug.cgi?id=112272
2589
2590         Reviewed by Gustavo Noronha Silva.
2591
2592         * gtk/install-dependencies: Add missing atk dependency.
2593
2594 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2595
2596         [GTK] Missing backslash in install-dependencies script
2597         https://bugs.webkit.org/show_bug.cgi?id=112907
2598
2599         Reviewed by Philippe Normand.
2600
2601         * gtk/install-dependencies: Add missing backslash to dependencies
2602         list.
2603
2604 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2605
2606         EWS bots have stopped uploading results to bugzilla
2607         https://bugs.webkit.org/show_bug.cgi?id=101091
2608
2609         Reviewed by Adam Barth.
2610
2611         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2612         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2613         this relative file path resoled to a file inside a non-existent directory for "zip".
2614
2615         Fixed the bug by resolving both test results directory and zip archive paths in
2616         LayoutTestResultsReader.archive.
2617
2618         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2619         in the future.
2620
2621         * Scripts/webkitpy/common/system/filesystem_mock.py:
2622         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2623
2624         * Scripts/webkitpy/common/system/workspace.py:
2625         (Workspace.create_zip): Log the source path when "zip" failed.
2626
2627         * Scripts/webkitpy/common/system/workspace_mock.py:
2628         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2629
2630         * Scripts/webkitpy/common/system/workspace_unittest.py:
2631         (WorkspaceTest.test_create_zip_exception): Test that.
2632
2633         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2634         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2635         This is the actual bug fix.
2636
2637         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2638         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2639
2640 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2641
2642         [chromium] move WebThemeEngine implementations to TestRunner library
2643         https://bugs.webkit.org/show_bug.cgi?id=112751
2644
2645         Reviewed by Adam Barth.
2646
2647         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2648         * DumpRenderTree/DumpRenderTree.gypi:
2649         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2650         (WebKit):
2651         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2652         (WebTestRunner::TestInterfaces::themeEngine):
2653         (WebTestRunner):
2654         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2655         (WebKit):
2656         (TestInterfaces):
2657         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2658         (WebTestRunner::WebTestInterfaces::themeEngine):
2659         (WebTestRunner):
2660         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2661         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2662         (WebTestRunner):
2663         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2664         (WebTestRunner::WebTestThemeControlWin::box):
2665         (WebTestRunner::WebTestThemeControlWin::line):
2666         (WebTestRunner::WebTestThemeControlWin::triangle):
2667         (WebTestRunner::WebTestThemeControlWin::roundRect):
2668         (WebTestRunner::WebTestThemeControlWin::oval):
2669         (WebTestRunner::WebTestThemeControlWin::circle):
2670         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2671         (WebTestRunner::WebTestThemeControlWin::markState):
2672         (WebTestRunner::WebTestThemeControlWin::draw):
2673         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2674         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2675         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2676         (WebTestRunner):
2677         (WebTestThemeControlWin):
2678         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2679         (WebTestRunner):
2680         (WebTestThemeEngineMac):
2681         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2682         (+[FakeActiveWindow alwaysActiveWindow]):
2683         (+[FakeActiveWindow alwaysInactiveWindow]):
2684         (-[FakeActiveWindow initWithActiveControls:]):
2685         (-[FakeActiveWindow _hasActiveControls]):
2686         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2687         (WebTestRunner):
2688         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2689         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2690         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2691         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2692         (WebTestRunner):
2693         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2694         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2695         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2696         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2697         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2698         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2699         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2700         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2701         (WebTestRunner::WebTestThemeEngineWin::getSize):
2702         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2703         (WebTestRunner):
2704         (WebTestThemeEngineWin):
2705         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2706         * DumpRenderTree/chromium/TestShell.cpp:
2707         (TestShell::initialize):
2708         * DumpRenderTree/chromium/TestShell.h:
2709         (WebKit):
2710         * DumpRenderTree/chromium/TestShellMac.mm:
2711         (platformInit):
2712         * DumpRenderTree/chromium/TestShellWin.cpp:
2713         (platformInit):
2714         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2715
2716 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2717
2718         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2719
2720         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2721         New property sheet that does not link against CoreFoundation and
2722         CFNetwork.
2723         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2724         Use new TestWebKitAPICommonWinCairo property sheet.
2725         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2726         Ditto.
2727
2728 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2729
2730         [WinCairo] Unreviewed build fix for VS2010.
2731
2732         Had to add WinCairo-specific property sheets to deal with some
2733         library and path differences with the main Apple port.
2734
2735         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2736         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2737         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2738         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2739         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2740         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2741
2742 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2743
2744         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2745         https://bugs.webkit.org/show_bug.cgi?id=112849
2746
2747         Reviewed by Sam Weinig.
2748
2749         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2750         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2751         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2752
2753 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2754
2755         [WinCairo] Build WebKit Tools under VS2010
2756         https://bugs.webkit.org/show_bug.cgi?id=112821
2757
2758         Reviewed by Tim Horton.
2759
2760         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2761         Add WinCairo-specific build target.
2762         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2763         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2764         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2765         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2766         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2767         Add WinCairo-specific build target.
2768         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2769         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2770         Add WinCairo-specific build target.
2771         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2772         WinCairo-specific build target.
2773         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2774         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2775         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2776         specific build target.
2777         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2778         WinCairo-specific build target.
2779         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2780         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2781         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2782
2783 2013-03-20  Roger Fong  <roger_fong@apple.com>
2784
2785         API test gardening AppleWin port.
2786
2787         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2788
2789         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2790         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2791
2792 2013-03-20  Roger Fong  <roger_fong@apple.com>
2793
2794         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2795
2796         * EWSTools/start-queue-win.sh:
2797
2798 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2799
2800         Unreviewed, add myself to committers.py.
2801
2802 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2803
2804         Unreviewed. Adding another email for me.
2805
2806         * Scripts/webkitpy/common/config/committers.py:
2807
2808 2013-03-20  Justin Novosad  <junov@google.com>
2809
2810         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2811         https://bugs.webkit.org/show_bug.cgi?id=112605
2812
2813         Reviewed by James Robinson.
2814
2815         Deleting all the code that was used for propagating and supporting
2816         the Chromium setting for disabling deferred 2d canvas rendering.
2817
2818         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2819         (main):
2820         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2821         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2822         (WebTestRunner::WebPreferences::reset):
2823         (WebTestRunner::WebPreferences::applyTo):
2824         * DumpRenderTree/chromium/TestShell.cpp:
2825         (TestShell::TestShell):
2826         (TestShell::resetWebSettings):
2827         (TestShell::runFileTest):
2828         * DumpRenderTree/chromium/TestShell.h:
2829         (TestShell):
2830
2831 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2832
2833         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2834         https://bugs.webkit.org/show_bug.cgi?id=112699.
2835
2836         Reviewed by Adam Barth.
2837
2838         * Scripts/webkitpy/layout_tests/port/qt.py:
2839         (QtPort._search_paths):
2840         (QtPort._port_specific_expectations_files):
2841         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2842         (QtPortTest):
2843         (QtPortTest._assert_search_path):
2844         (QtPortTest._assert_expectations_files):
2845
2846 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2847
2848         [Qt] Enable kerning by default
2849         https://bugs.webkit.org/show_bug.cgi?id=112704
2850
2851         Reviewed by Jocelyn Turcotte.
2852
2853         Disable kerning by default, since some reference test expectations
2854         expect kerning to be default off.
2855
2856         * DumpRenderTree/qt/TestRunnerQt.cpp:
2857         (TestRunnerQt::reset):
2858         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2859         (WTR::activateFonts):
2860
2861 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2862
2863         [Qt] Remove empty function stubs from TestRunnerQt.
2864         https://bugs.webkit.org/show_bug.cgi?id=112799
2865
2866         We are reducing the code in TestRunnerQt step by step,
2867         in order to finally replace all of it with the generic
2868         TestRunner implementation.
2869         This patch removes several simple function stubs that
2870         currently do not implement any actual functionality.
2871
2872         Reviewed by Kenneth Rohde Christiansen.
2873
2874         * DumpRenderTree/qt/TestRunnerQt.cpp:
2875         * DumpRenderTree/qt/TestRunnerQt.h:
2876         (TestRunnerQt):
2877
2878 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2879
2880         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2881         https://bugs.webkit.org/show_bug.cgi?id=112687
2882
2883         Reviewed by Kenneth Rohde Christiansen.
2884
2885         Hide the SearchBar by default on window creation.
2886
2887         * MiniBrowser/efl/main.c:
2888         (window_create):
2889
2890 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2891
2892         Unreviewed, rolling out r146304.
2893         http://trac.webkit.org/changeset/146304
2894         https://bugs.webkit.org/show_bug.cgi?id=112788
2895
2896         to many expectations to update (Requested by antonm on
2897         #webkit).
2898
2899         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2900         * DumpRenderTree/DumpRenderTree.gypi:
2901         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2902         (WebKit):
2903         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2904         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2905         (TestInterfaces):
2906         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2907         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2908         * DumpRenderTree/chromium/TestShell.cpp:
2909         (TestShell::initialize):
2910         * DumpRenderTree/chromium/TestShell.h:
2911         (WebKit):
2912         * DumpRenderTree/chromium/TestShellMac.mm:
2913         (platformInit):
2914         * DumpRenderTree/chromium/TestShellWin.cpp:
2915         (platformInit):
2916         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2917         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2918         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2919         (WebThemeControlDRTWin::box):
2920         (WebThemeControlDRTWin::line):
2921         (WebThemeControlDRTWin::triangle):
2922         (WebThemeControlDRTWin::roundRect):
2923         (WebThemeControlDRTWin::oval):
2924         (WebThemeControlDRTWin::circle):
2925         (WebThemeControlDRTWin::nestedBoxes):
2926         (WebThemeControlDRTWin::markState):
2927         (WebThemeControlDRTWin::draw):
2928         (WebThemeControlDRTWin::drawTextField):
2929         (WebThemeControlDRTWin::drawProgressBar):
2930         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2931         (WebThemeControlDRTWin):
2932         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2933         (WebThemeEngineDRTMac):
2934         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2935         (+[FakeActiveWindow alwaysActiveWindow]):
2936         (+[FakeActiveWindow alwaysInactiveWindow]):
2937         (-[FakeActiveWindow initWithActiveControls:]):
2938         (-[FakeActiveWindow _hasActiveControls]):
2939         (WebThemeEngineDRTMac::paintScrollbarThumb):
2940         (stateToHIEnableState):
2941         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2942         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2943         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2944         (webRectToSkIRect):
2945         (drawControl):
2946         (drawTextField):
2947         (drawProgressBar):
2948         (WebThemeEngineDRTWin::paintButton):
2949         (WebThemeEngineDRTWin::paintMenuList):
2950         (WebThemeEngineDRTWin::paintScrollbarArrow):
2951         (WebThemeEngineDRTWin::paintScrollbarThumb):
2952         (WebThemeEngineDRTWin::paintScrollbarTrack):
2953         (WebThemeEngineDRTWin::paintSpinButton):
2954         (WebThemeEngineDRTWin::paintTextField):
2955         (WebThemeEngineDRTWin::paintTrackbar):
2956         (WebThemeEngineDRTWin::paintProgressBar):
2957         (WebThemeEngineDRTWin::getSize):
2958         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2959         (WebThemeEngineDRTWin):
2960         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2961
2962 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2963
2964         [Qt] Support -webkit-font-smoothing
2965         https://bugs.webkit.org/show_bug.cgi?id=106009
2966
2967         Reviewed by Jocelyn Turcotte.
2968
2969         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2970
2971         * DumpRenderTree/qt/TestRunnerQt.cpp:
2972         (TestRunnerQt::reset):
2973
2974 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2975
2976         [GTK] accessibility/aria-scrollbar-role.html is failing
2977         https://bugs.webkit.org/show_bug.cgi?id=98358
2978
2979         Reviewed by Martin Robinson.
2980
2981         Adds support for checking accessibility object's orientation.
2982         Orientation is checked by retrieving proper state of accessibility object.
2983
2984         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2985         (checkElementState):
2986         (AccessibilityUIElement::orientation):
2987         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2988         (WTR::AccessibilityUIElement::orientation):
2989
2990 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2991
2992         [chromium] move WebThemeEngine implementations to TestRunner library
2993         https://bugs.webkit.org/show_bug.cgi?id=112751
2994
2995         Reviewed by Adam Barth.
2996
2997         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2998         * DumpRenderTree/DumpRenderTree.gypi:
2999         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3000         (WebKit):
3001         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3002         (WebTestRunner::TestInterfaces::themeEngine):
3003         (WebTestRunner):
3004         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3005         (WebKit):
3006         (TestInterfaces):
3007         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3008         (WebTestRunner::WebTestInterfaces::themeEngine):
3009         (WebTestRunner):
3010         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3011         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3012         (WebTestRunner):
3013         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3014         (WebTestRunner::WebTestThemeControlWin::box):
3015         (WebTestRunner::WebTestThemeControlWin::line):
3016         (WebTestRunner::WebTestThemeControlWin::triangle):
3017         (WebTestRunner::WebTestThemeControlWin::roundRect):
3018         (WebTestRunner::WebTestThemeControlWin::oval):
3019         (WebTestRunner::WebTestThemeControlWin::circle):
3020         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3021         (WebTestRunner::WebTestThemeControlWin::markState):
3022         (WebTestRunner::WebTestThemeControlWin::draw):
3023         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3024         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3025         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3026         (WebTestRunner):
3027         (WebTestThemeControlWin):
3028         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3029         (WebTestRunner):
3030         (WebTestThemeEngineMac):
3031         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3032         (+[FakeActiveWindow alwaysActiveWindow]):
3033         (+[FakeActiveWindow alwaysInactiveWindow]):
3034         (-[FakeActiveWindow initWithActiveControls:]):
3035         (-[FakeActiveWindow _hasActiveControls]):
3036         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3037         (WebTestRunner):
3038         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3039         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3040         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3041         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3042         (WebTestRunner):
3043         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3044         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3045         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3046         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3047         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3048         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3049         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3050         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3051         (WebTestRunner::WebTestThemeEngineWin::getSize):
3052         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3053         (WebTestRunner):
3054         (WebTestThemeEngineWin):
3055         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3056         * DumpRenderTree/chromium/TestShell.cpp:
3057         (TestShell::initialize):
3058         * DumpRenderTree/chromium/TestShell.h:
3059         (WebKit):
3060         * DumpRenderTree/chromium/TestShellMac.mm:
3061         (platformInit):
3062         * DumpRenderTree/chromium/TestShellWin.cpp:
3063         (platformInit):
3064         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3065
3066 2013-03-19  Tony Chang  <tony@chromium.org>
3067
3068         Move testRunner.setTouchDragDropEnabled to internals.settings
3069         https://bugs.webkit.org/show_bug.cgi?id=112739
3070
3071         Reviewed by Adam Barth.
3072
3073         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3074         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
3075         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3076         (TestRunner): Remove unnecessary code.
3077         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3078         (WebTestRunner::WebPreferences::reset):
3079         (WebTestRunner::WebPreferences::applyTo): Always set to false.
3080
3081 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
3082
3083         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3084         https://bugs.webkit.org/show_bug.cgi?id=112754
3085
3086         Reviewed by Darin Fisher.
3087
3088         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3089         now that it's always defined.
3090
3091         * DumpRenderTree/chromium/WebViewHost.cpp:
3092         * DumpRenderTree/chromium/WebViewHost.h:
3093         (WebViewHost):
3094
3095 2013-03-19  Kenneth Russell  <kbr@google.com>
3096
3097         Unreviewed, rolling out r146290.
3098         http://trac.webkit.org/changeset/146290
3099         https://bugs.webkit.org/show_bug.cgi?id=112751
3100
3101         Broke Chromium Mac build.
3102
3103         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3104         * DumpRenderTree/DumpRenderTree.gypi:
3105         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3106         (WebKit):
3107         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3108         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3109         (TestInterfaces):
3110         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3111         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3112         * DumpRenderTree/chromium/TestShell.cpp:
3113         (TestShell::initialize):
3114         * DumpRenderTree/chromium/TestShell.h:
3115         (WebKit):
3116         * DumpRenderTree/chromium/TestShellMac.mm:
3117         (platformInit):
3118         * DumpRenderTree/chromium/TestShellWin.cpp:
3119         (platformInit):
3120         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3121         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3122         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3123         (WebThemeControlDRTWin::box):
3124         (WebThemeControlDRTWin::line):
3125         (WebThemeControlDRTWin::triangle):
3126         (WebThemeControlDRTWin::roundRect):
3127         (WebThemeControlDRTWin::oval):
3128         (WebThemeControlDRTWin::circle):
3129         (WebThemeControlDRTWin::nestedBoxes):
3130         (WebThemeControlDRTWin::markState):
3131         (WebThemeControlDRTWin::draw):
3132         (WebThemeControlDRTWin::drawTextField):
3133         (WebThemeControlDRTWin::drawProgressBar):
3134         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3135         (WebThemeControlDRTWin):
3136         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3137         (WebThemeEngineDRTMac):
3138         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3139         (+[FakeActiveWindow alwaysActiveWindow]):
3140         (+[FakeActiveWindow alwaysInactiveWindow]):
3141         (-[FakeActiveWindow initWithActiveControls:]):
3142         (-[FakeActiveWindow _hasActiveControls]):
3143         (WebThemeEngineDRTMac::paintScrollbarThumb):
3144         (stateToHIEnableState):
3145         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3146         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3147         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3148         (webRectToSkIRect):
3149         (drawControl):
3150         (drawTextField):
3151         (drawProgressBar):
3152         (WebThemeEngineDRTWin::paintButton):
3153         (WebThemeEngineDRTWin::paintMenuList):
3154         (WebThemeEngineDRTWin::paintScrollbarArrow):
3155         (WebThemeEngineDRTWin::paintScrollbarThumb):
3156         (WebThemeEngineDRTWin::paintScrollbarTrack):
3157         (WebThemeEngineDRTWin::paintSpinButton):
3158         (WebThemeEngineDRTWin::paintTextField):
3159         (WebThemeEngineDRTWin::paintTrackbar):
3160         (WebThemeEngineDRTWin::paintProgressBar):
3161         (WebThemeEngineDRTWin::getSize):
3162         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3163         (WebThemeEngineDRTWin):
3164         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3165
3166 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3167
3168         [EFL] canvas-fallback-content.html is failing
3169         https://bugs.webkit.org/show_bug.cgi?id=111998
3170
3171         Reviewed by Chris Fleizach.
3172
3173         Adds support for getting platform name.
3174
3175         * DumpRenderTree/TestRunner.cpp:
3176         (TestRunner::staticValues):
3177         * DumpRenderTree/TestRunner.h:
3178         (TestRunner):
3179         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3180         (TestRunner::platformName):
3181
3182 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3183
3184         [chromium] move WebThemeEngine implementations to TestRunner library
3185         https://bugs.webkit.org/show_bug.cgi?id=112751
3186
3187         Reviewed by Adam Barth.
3188
3189         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3190         * DumpRenderTree/DumpRenderTree.gypi:
3191         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3192         (WebKit):
3193         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3194         (WebTestRunner::TestInterfaces::themeEngine):
3195         (WebTestRunner):
3196         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3197         (WebKit):
3198         (TestInterfaces):
3199         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3200         (WebTestRunner::WebTestInterfaces::themeEngine):
3201         (WebTestRunner):
3202         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3203         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3204         (WebTestRunner):
3205         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3206         (WebTestRunner::WebTestThemeControlWin::box):
3207         (WebTestRunner::WebTestThemeControlWin::line):
3208         (WebTestRunner::WebTestThemeControlWin::triangle):
3209         (WebTestRunner::WebTestThemeControlWin::roundRect):
3210         (WebTestRunner::WebTestThemeControlWin::oval):
3211         (WebTestRunner::WebTestThemeControlWin::circle):
3212         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3213         (WebTestRunner::WebTestThemeControlWin::markState):
3214         (WebTestRunner::WebTestThemeControlWin::draw):
3215         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3216         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3217         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3218         (WebTestRunner):
3219         (WebTestThemeControlWin):
3220         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3221         (WebTestRunner):
3222         (WebTestThemeEngineMac):
3223         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3224         (+[FakeActiveWindow alwaysActiveWindow]):
3225         (+[FakeActiveWindow alwaysInactiveWindow]):
3226         (-[FakeActiveWindow initWithActiveControls:]):
3227         (-[FakeActiveWindow _hasActiveControls]):
3228         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3229         (WebTestRunner):
3230         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3231         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3232         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3233         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3234         (WebTestRunner):
3235         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3236         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3237         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3238         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3239         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3240         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3241         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3242         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3243         (WebTestRunner::WebTestThemeEngineWin::getSize):
3244         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3245         (WebTestRunner):
3246         (WebTestThemeEngineWin):
3247         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3248         * DumpRenderTree/chromium/TestShell.cpp:
3249         (TestShell::initialize):
3250         * DumpRenderTree/chromium/TestShell.h:
3251         (WebKit):
3252         * DumpRenderTree/chromium/TestShellMac.mm:
3253         (platformInit):
3254         * DumpRenderTree/chromium/TestShellWin.cpp:
3255         (platformInit):
3256         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3257
3258 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3259
3260         [EFL][WK2] Separate WebView further from EwkView
3261         https://bugs.webkit.org/show_bug.cgi?id=111591
3262
3263         Reviewed by Caio Marcelo de Oliveira Filho.
3264
3265         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3266         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3267         since we can afford it having EWKViewGetWKView() private API to access WKView.
3268
3269         * TestWebKitAPI/PlatformWebView.h:
3270         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3271         (TestWebKitAPI::TEST):
3272         * TestWebKitAPI/efl/PlatformWebView.cpp:
3273         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3274         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3275         (TestWebKitAPI::PlatformWebView::resizeTo):
3276         (TestWebKitAPI::PlatformWebView::page):
3277         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3278         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3279         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3280         * WebKitTestRunner/PlatformWebView.h:
3281         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3282         (WTR::EventSenderProxy::dispatchEvent):
3283         (WTR::EventSenderProxy::keyDown):
3284         (WTR::EventSenderProxy::sendTouchEvent):
3285         (WTR::EventSenderProxy::setTouchModifier):
3286         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3287         (WTR::PlatformWebView::PlatformWebView):
3288         (WTR::PlatformWebView::~PlatformWebView):
3289         (WTR::PlatformWebView::resizeTo):
3290         (WTR::PlatformWebView::page):
3291         (WTR::PlatformWebView::focus):
3292         (WTR::PlatformWebView::windowSnapshotImage):
3293
3294 2013-03-19  Roger Fong  <roger_fong@apple.com>
3295
3296         Changes to VS2010 project files should only trigger builds on Windows bots.
3297         https://bugs.webkit.org/show_bug.cgi?id=112731
3298
3299         Reviewed by Timothy Horton.
3300
3301         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3302         (_should_file_trigger_build):
3303
3304 2013-03-19  Roger Fong  <roger_fong@apple.com>
3305
3306         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3307
3308         * Scripts/webkitpy/tool/steps/runtests.py:
3309         (RunTests.run):
3310         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3311         (RunTestsTest.test_webkit_run_unit_tests):
3312
3313 2013-03-19  Julie Parent  <jparent@chromium.org>
3314
3315         Dashboards: Introduce history namespace and unit tests.
3316         https://bugs.webkit.org/show_bug.cgi?id=112645
3317
3318         Reviewed by Ojan Vafai.
3319         
3320         Laying the framework for introducing the new history object and
3321         namespace.  This moves only static functions into the history
3322         namespace, and moves corresponding unit tests into seperate
3323         unit test file.
3324
3325         * TestResultServer/static-dashboards/aggregate_results.html:
3326         * TestResultServer/static-dashboards/dashboard_base.js:
3327         (parseCrossDashboardParameters):
3328         (parseDashboardSpecificParameters):
3329         (parseParameters):
3330         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3331         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3332         (.switch.return):
3333         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3334         * TestResultServer/static-dashboards/history.js: Added.
3335         * TestResultServer/static-dashboards/history_unittests.js: Added.
3336         * TestResultServer/static-dashboards/loader.js:
3337         (.):
3338         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3339         * TestResultServer/static-dashboards/run-unittests.html:
3340         * TestResultServer/static-dashboards/timeline_explorer.html:
3341         * TestResultServer/static-dashboards/timeline_explorer.js:
3342         * TestResultServer/static-dashboards/treemap.html:
3343         * TestResultServer/static-dashboards/treemap.js:
3344         (.switch.return):
3345         * TestResultServer/static-dashboards/ui.js:
3346
3347 2013-03-19  Daniel Bates  <dbates@webkit.org>
3348
3349         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3350         https://bugs.webkit.org/show_bug.cgi?id=112732
3351
3352         Reviewed by Eric Seidel.
3353
3354         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3355         of an existing file cannot be applied.
3356
3357         In particular, svn-{apply, unapply} compensate for differences in line endings
3358         by converting the line endings in a diff to match the line endings in the target
3359         file. The diff(1) command precedes the last line of a diff that adds a newline
3360         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3361         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3362         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3363         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3364         the newline characters in this special character sequence to match the line endings
3365         in the target file.
3366
3367         * Scripts/VCSUtils.pm:
3368         (parseDiff):
3369         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3370         Added tests:
3371             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3372             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3373             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3374             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3375         (escapeNewLineCharacters): Added.
3376         (toMacLineEndings): Added.
3377
3378 2013-03-19  James Robinson  <jamesr@chromium.org>
3379
3380         [chromium] Remove compositor settings that don't go through WebKit
3381         https://bugs.webkit.org/show_bug.cgi?id=112718
3382
3383         Reviewed by Adam Barth.
3384
3385         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3386         (main):
3387         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3388         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3389         (WebTestRunner::WebPreferences::reset):
3390         (WebTestRunner::WebPreferences::applyTo):
3391         * DumpRenderTree/chromium/TestShell.cpp:
3392         (TestShell::TestShell):
3393         (TestShell::resetWebSettings):
3394         * DumpRenderTree/chromium/TestShell.h:
3395         (TestShell):
3396
3397 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3398
3399         Unreviewed, rolling out r146101.
3400         https://bugs.webkit.org/show_bug.cgi?id=111884
3401
3402         re-enable custom freetype on asan; this needs to be on
3403         now that the bot is running lucid.
3404
3405         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3406
3407 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3408
3409         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3410         https://bugs.webkit.org/show_bug.cgi?id=112365
3411
3412         Reviewed by Benjamin Poulain.
3413
3414         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3415         harcoding it in wtf/Platform.h
3416
3417         * Scripts/webkitperl/FeatureList.pm:
3418
3419 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3420
3421         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3422         https://bugs.webkit.org/show_bug.cgi?id=94782
3423
3424         Based on patch by Csaba Osztrogonác.
3425         Reviewed by Jocelyn Turcotte.
3426
3427         The diff image is generated with bright red indicating errors, but letting the base image
3428         shine through so the context of the error-pixel can be identified.
3429
3430         * DumpRenderTree/qt/ImageDiff.cpp:
3431         (main):
3432
3433 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3434
3435         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3436
3437         Rubber-stamped by Csaba Osztrogonác.
3438
3439         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3440         since the latter might not cover the former.
3441
3442         * QtTestBrowser/launcherwindow.cpp:
3443         (LauncherWindow::print):
3444
3445 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3446
3447         Style tweeks to default.css.
3448         
3449         Rubber-stamped by David Kilzer.
3450         
3451         Give visited links a different color to other links, so you can
3452         see which builds you've viewed.
3453         
3454         Make the <small> text less tiny.
3455
3456         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3457         (small):
3458         (a:link,a:visited,a:active):
3459         (a:visited):
3460
3461 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3462
3463         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3464         https://bugs.webkit.org/show_bug.cgi?id=112494
3465
3466         Reviewed by Dirk Pranke.
3467
3468         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3469         Also merged two pairs of methods to cleanup the code.
3470
3471         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3472         (PerfTestsRunner.run): Merged _upload_and_show_results.
3473         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3474
3475 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3476
3477         [chromium] build xdisplaycheck when building DRT
3478         https://bugs.webkit.org/show_bug.cgi?id=112636
3479
3480         Reviewed by Tony Chang.
3481
3482         It appears that we need xdisplaycheck to be built in order for
3483         Xvfb to be started correctly on the bots, and DRT was missing
3484         a dependency on it. This may be the cause of the ASAN bot not
3485         starting up properly (it only builds DRT).
3486
3487         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3488
3489 2013-03-18  David Levin  <levin@chromium.org>
3490
3491         Implement icon change notification dump for Chromium's test shell.
3492         https://bugs.webkit.org/show_bug.cgi?id=112614
3493
3494         This was previously implemented for some other platforms in r58111
3495         and r116547.
3496
3497         In r122806, fast/dom/icon-url-property.html stopped using it, but
3498         it is useful for tests, so I plan to re-add it to that test again.
3499
3500         Reviewed by Jochen Eisinger.
3501
3502         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3503         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3504          icon change notifications from WebKit may be logged in test output.
3505         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3506         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3507         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3508         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3509         (WebTestRunner):
3510         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3511         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3512         (TestRunner):
3513         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3514         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3515         (WebTestRunner):
3516         * DumpRenderTree/chromium/WebViewHost.cpp:
3517         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3518         * DumpRenderTree/chromium/WebViewHost.h:
3519         (WebViewHost):
3520
3521 2013-03-18  Julie Parent  <jparent@chromium.org>
3522
3523         Cleanup: Move js for treemap and aggregate_results into own js files.
3524         https://bugs.webkit.org/show_bug.cgi?id=112618
3525
3526         Reviewed by Dirk Pranke.
3527         
3528         No functional changes, just moving the code into separate js file
3529         rather than inlined in the html, so we can test it, make it more
3530         modular, etc.  Other dashboard types are already done this way.
3531
3532         * TestResultServer/static-dashboards/aggregate_results.html:
3533         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3534         (generatePage):
3535         (handleValidHashParameter):
3536         (htmlForBuilder):
3537         (rawValuesHTML):
3538         (chartHTML):
3539         (filteredValues):
3540         (chart):
3541         (htmlForRevisionRows):
3542         (wrapHTMLInTable):
3543         (htmlForSummaryTable):
3544         (valuesPerExpectation):
3545         (htmlForTestType):
3546         (htmlForTableRow):
3547         (extendedEncode):
3548         * TestResultServer/static-dashboards/treemap.html:
3549         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3550         (humanReadableTime):
3551         (convertToWebTreemapFormat):
3552         (reverseSortByAverage):
3553         (generatePage):
3554         (focusPath):
3555         (.switch.return):
3556         (handleQueryParameterChange):
3557         (extractName):
3558         (fullName):
3559         (handleFocus.):
3560         (handleFocus):
3561
3562 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3563
3564         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3565         https://bugs.webkit.org/show_bug.cgi?id=112622
3566
3567         Reviewed by Dirk Pranke.
3568
3569         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3570         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3571
3572 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3573
3574         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3575         https://bugs.webkit.org/show_bug.cgi?id=112619
3576
3577         Reviewed by Dirk Pranke.
3578
3579         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3580         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3581
3582         * Scripts/webkitpy/layout_tests/port/gtk.py:
3583         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3584         Port._webkit_baseline_path method.
3585         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3586         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3587         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3588         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3589         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3590         that are expected based on the builder name.
3591
3592 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3593
3594         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3595         https://bugs.webkit.org/show_bug.cgi?id=112571
3596
3597         Reviewed by Adam Barth.
3598
3599         Update function declarations for new WebFileSystemType enum. (All
3600         changes are behind an #ifdef so we can sync required changes in embedders.)
3601
3602         * DumpRenderTree/chromium/WebViewHost.cpp:
3603         (WebViewHost::openFileSystem):
3604         (WebViewHost::deleteFileSystem):
3605         * DumpRenderTree/chromium/WebViewHost.h:
3606         (WebViewHost):
3607
3608 2013-03-18  Julie Parent  <jparent@chromium.org>
3609
3610         Cleanup: Move timeline_exporer js out of html file into js.
3611         https://bugs.webkit.org/show_bug.cgi?id=112188
3612
3613         Reviewed by Dirk Pranke.
3614         
3615         Moves the javascript out of the html file and into a new js file.
3616         This follows the format of flakiness_dashboard.{html|js}.
3617         
3618         Also moves code from dashboard_base that is used only by this one
3619         dashboard, and makes it private to the dashboard.
3620
3621         * TestResultServer/static-dashboards/dashboard_base.js:
3622         * TestResultServer/static-dashboards/timeline_explorer.html:
3623         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3624         (generatePage):
3625         (initCurrentBuilderTestResults):
3626         (shouldShowWebKitRevisionsOnly):
3627         (updateTimelineForBuilder.):
3628         (updateTimelineForBuilder):
3629         (selectBuild):
3630         (updateBuildIndicator):
3631         (.addRow):
3632         (.addNumberRow):
3633         (.inspectorNode.getElementsByTagName.0.onclick):
3634         (.inspectorNode.getElementsByTagName.1.onclick):
3635         (.inspectorNode.getElementsByTagName.2.onclick):
3636         (updateBuildInspector):
3637         (showResultsDelta):
3638         (decompressResults.addFlakyDelta):
3639         (decompressResults):
3640
3641 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3642
3643         Unreviewed, rolling out r145272.
3644         http://trac.webkit.org/changeset/145272
3645         https://bugs.webkit.org/show_bug.cgi?id=111884
3646
3647         Turns out the ASAN build is still broken; possibly there's
3648         something still setting LD_LIBRARY_PATH, or possibly there's
3649         something else wrong. In the meantime, we need it to work again.
3650
3651         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3652
3653 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3654
3655         delete-stale-build-files is too aggressive
3656         https://bugs.webkit.org/show_bug.cgi?id=112595
3657
3658         Reviewed by Tim Horton.
3659
3660         It appears that whitelisting file extensions to keep is not a good idea.
3661         Blacklist files to delete instead, and only delete .o files for now.
3662         We can add more file extensions as needed.
3663
3664         * BuildSlaveSupport/delete-stale-build-files:
3665
3666 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3667
3668         Disable accessibility notifications after each test
3669         https://bugs.webkit.org/show_bug.cgi?id=112579
3670
3671         Reviewed by Tim Horton.
3672         
3673         In WebKitTestRunner, if any tests triggered accessibility notifications,
3674         the global notification handler would thereafter be active, and fire
3675         notifications for all subsequent tests.
3676         
3677         Fix by implementing AccessibilityController::resetToConsistentState() for
3678         Mac, and using it to clear the global notification handler.
3679
3680         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3681         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3682         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3683         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3684         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3685         (e.g. because of -autorelease).
3686         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3687         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3688         if there is one.
3689         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3690         Add -stopObserving
3691         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3692         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3693         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3694         center.
3695
3696 2013-03-18  Dana Jansens  <danakj@chromium.org>
3697
3698         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3699         https://bugs.webkit.org/show_bug.cgi?id=112392
3700
3701         Reviewed by James Robinson.
3702
3703         Removes the command line flag option from DRT.
3704
3705         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3706         (main):
3707
3708 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3709
3710         [GTK] plugins/plugin-clip-subframe.html is failing
3711         https://bugs.webkit.org/show_bug.cgi?id=112570
3712
3713         Reviewed by Martin Robinson.
3714
3715         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3716
3717 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3718
3719         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3720         https://bugs.webkit.org/show_bug.cgi?id=112442
3721
3722         Reviewed by Gustavo Noronha Silva.
3723
3724         * GtkLauncher/main.c:
3725         (reloadCb):
3726         (createToolbar):
3727         (createWindow):
3728
3729 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3730
3731         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3732         https://bugs.webkit.org/show_bug.cgi?id=112205
3733
3734         Disable this API test until Geoff can fix it.
3735
3736         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3737         (TestWebKitAPI::TEST):
3738
3739 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3740
3741         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3742         https://bugs.webkit.org/show_bug.cgi?id=112478
3743
3744         Reviewed by Tony Chang.
3745
3746         There is nothing that ensures that the log messages from the plugin
3747         come in before the layout test finished loading.
3748
3749         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3750         (PassDifferentNPPStruct::NPP_SetWindow):
3751         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3752         (NPP_SetWindow):
3753
3754 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3755
3756         Have the mac port support per_test_timeout in webkitpy
3757         https://bugs.webkit.org/show_bug.cgi?id=112466
3758
3759         Reviewed by Dirk Pranke.
3760         
3761         Both WTR and DRT handle --timeout arguments, so we can
3762         have the scripts pass the timeout values down to the tools.
3763
3764         * Scripts/webkitpy/layout_tests/port/mac.py:
3765         (MacPort.supports_per_test_timeout):
3766
3767 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3768
3769         Remove setAsynchronousSpellCheckingEnabled from test runners
3770         https://bugs.webkit.org/show_bug.cgi?id=112362
3771
3772         Reviewed by Tony Chang.
3773
3774         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3775         in internals.settings, so all ports can share it.
3776
3777         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3778         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3779         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3780         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3781         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3782         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3783         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3784         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3785         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3786         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3787         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3788         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3789
3790 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3791
3792         Fix the stupid unit tests.
3793
3794         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3795         (test_sample_process):
3796
3797 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3798
3799         Collect samples for unresponsive web processes
3800         https://bugs.webkit.org/show_bug.cgi?id=112409
3801
3802         Reviewed by Tim Horton.
3803         
3804         When we detect that a subprocess was unresponsive, run the 'sample'
3805         tool on that process, for the Mac port.
3806         
3807         The sample will be linked to from the results.html page, next
3808         to the crash log link.
3809
3810         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3811         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3812         look for samples on disk.
3813         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3814         (TestResultWriter):
3815         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3816         -sample.txt files, and have it copy their contents to a new file
3817         next to the test that spawned them (as we do for crash logs).
3818         * Scripts/webkitpy/layout_tests/port/base.py:
3819         (Port.look_for_new_samples): Base class does nothing for sampling.
3820         * Scripts/webkitpy/layout_tests/port/driver.py:
3821         (Driver._check_for_driver_crash): Kick off a sample if we detected
3822         that the subprocess was unresponsive.
3823         * Scripts/webkitpy/layout_tests/port/mac.py:
3824         (MacPort.sample_file_path): Utility to generate the file path
3825         to the generated sample files at the top level of layout-test-results.
3826         (MacPort.look_for_new_crash_logs): Fix typo
3827         (MacPort.look_for_new_samples): New function to find sample files.
3828         (MacPort.sample_process): Use the utility function to get the file path.
3829
3830 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3831
3832         [Qt] Remove simple getters and setters from TestRunnerQt
3833         https://bugs.webkit.org/show_bug.cgi?id=112343
3834
3835         Reviewed by Benjamin Poulain.
3836
3837         The removed functions and boolean members
3838         are being replaced by the implementations in the
3839         generic TestRunner.h.
3840
3841         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3842         (DumpRenderTree::dumpFrameScrollPosition):
3843         (DumpRenderTree::dumpFramesAsText):
3844         (DumpRenderTree::dump):
3845         (DumpRenderTree::titleChanged):
3846         (DumpRenderTree::dumpDatabaseQuota):
3847         (DumpRenderTree::dumpApplicationCacheQuota):
3848         (DumpRenderTree::statusBarMessage):
3849         (DumpRenderTree::createWindow):
3850         * DumpRenderTree/qt/TestRunnerQt.cpp:
3851         (TestRunnerQt::reset):
3852         * DumpRenderTree/qt/TestRunnerQt.h:
3853         (TestRunnerQt):
3854
3855 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
3856
3857         Update the link on build.webkit.org to refer to perf.webkit.org
3858         https://bugs.webkit.org/show_bug.cgi?id=112416
3859
3860         Reviewed by Philip Rogers.
3861
3862         Updated the link. Also updated the template to use HTML5 DOCTYPE.
3863
3864         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3865
3866 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
3867
3868         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
3869         https://bugs.webkit.org/show_bug.cgi?id=112394
3870
3871         Reviewed by Philippe Normand.
3872
3873         * GtkLauncher/main.c:
3874         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
3875
3876 2013-03-14  Andreas Kling  <akling@apple.com>
3877
3878         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
3879         <http://webkit.org/b/111815>
3880         <rdar://problem/13380145>
3881
3882         Reviewed by Anders Carlsson.
3883
3884         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
3885         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
3886         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
3887
3888         * WebKitTestRunner/PlatformWebView.h:
3889         (PlatformWebView):
3890         * WebKitTestRunner/TestController.cpp:
3891         (WTR::TestController::createOtherPage):
3892         (WTR::TestController::createWebViewWithOptions):
3893         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3894         (WTR::PlatformWebView::didInitializeClients):
3895
3896 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3897
3898         [EFL][MiniBrowser] Add a search field to the MiniBrowser
3899         https://bugs.webkit.org/show_bug.cgi?id=112122
3900
3901         Reviewed by Kenneth Rohde Christiansen.
3902
3903         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
3904
3905         * MiniBrowser/efl/main.c:
3906         (_Browser_Window):
3907         (search_box_show):
3908         (search_box_hide):
3909         (on_key_down):
3910         (on_url_changed):
3911         (on_search_field_aborted):
3912         (on_search_field_activated):
3913         (on_search_field_clicked):
3914         (on_search_backward_button_clicked):
3915         (on_search_forward_button_clicked):
3916         (window_create):
3917
3918 2013-03-14  Julie Parent  <jparent@chromium.org>
3919
3920         Cleanup: Remove g_resourceLoader.
3921         https://bugs.webkit.org/show_bug.cgi?id=112305
3922
3923         Reviewed by Dirk Pranke.
3924         
3925         Removing another global.
3926         
3927         Now, each dashboard creates its own loader, rather than having
3928         a general global one.
3929         
3930         Remove usage of g_resourceLoader.isLoadingComplete from 
3931         handleLocationChange by ensuring that handleLocationChange is
3932         never called before the loader is done.  It was called in two
3933         places before: 1 was from the callback when the loader is done,
3934         so that was obviously true, and the other was from onhashchange,
3935         where it would just return rather than running.  Instead, lets
3936         only register the onhashchange handler once the loader is
3937         setup, so the check is no longer necessary.
3938         
3939         Remove isLoadingComplete since it is now unused.
3940         
3941         Callback for loader is now initializeHistory, rather than just
3942         handleLocationChange which will set up the hashchange handler now.
3943         This will all eventually be moving to a new History object.
3944
3945         * TestResultServer/static-dashboards/aggregate_results.html:
3946         * TestResultServer/static-dashboards/dashboard_base.js:
3947         (handleLocationChange):
3948         (intializeHistory):
3949         (decompressResults):
3950         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3951         (generatePage):
3952         * TestResultServer/static-dashboards/loader.js:
3953         (.):
3954         * TestResultServer/static-dashboards/loader_unittests.js:
3955         * TestResultServer/static-dashboards/timeline_explorer.html:
3956         * TestResultServer/static-dashboards/treemap.html:
3957
3958 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
3959
3960         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
3961         https://bugs.webkit.org/show_bug.cgi?id=109404
3962
3963         Reviewed by Tony Chang.
3964
3965         Removes all the code related to smartInsertDeleteEnabled and
3966         selectTrailingWhitespaceEnabled settings as they will be managed from
3967         internals from now on.
3968
3969         * DumpRenderTree/TestRunner.cpp:
3970         (TestRunner::staticFunctions):
3971         * DumpRenderTree/TestRunner.h:
3972         (TestRunner):
3973         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3974         (WebKit):
3975         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3976         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3977         (DumpRenderTree):
3978         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3979         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3980         (WebTestRunner::WebTestProxy::didStopLoading):
3981         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3982         (WebTestRunner::TestRunner::TestRunner):
3983         (WebTestRunner::TestRunner::reset):
3984         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3985         (TestRunner):
3986         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3987         (WebTestRunner::WebPreferences::applyTo): Set default values for
3988         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
3989         Chromium DRT default values are different from Chromium browser.
3990         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3991         * DumpRenderTree/chromium/WebViewHost.cpp:
3992         * DumpRenderTree/chromium/WebViewHost.h:
3993         (WebViewHost):
3994         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3995         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3996         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3997         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3998         (resetDefaultsToConsistentValues):
3999         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
4000         * DumpRenderTree/mac/DumpRenderTree.mm:
4001         (resetWebViewToConsistentStateBeforeTesting):
4002         * DumpRenderTree/mac/TestRunnerMac.mm:
4003         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4004         (WebCore::WebPage::resetSettings):
4005         * DumpRenderTree/qt/TestRunnerQt.cpp:
4006         * DumpRenderTree/qt/TestRunnerQt.h:
4007         (TestRunnerQt):
4008         * DumpRenderTree/win/DumpRenderTree.cpp:
4009         (resetWebViewToConsistentStateBeforeTesting):
4010         * DumpRenderTree/win/TestRunnerWin.cpp:
4011         * DumpRenderTree/wx/TestRunnerWx.cpp:
4012
4013 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4014
4015         [Qt] Disable DRT on Windows
4016
4017         Reviewed by Jocelyn Turcotte.
4018
4019         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
4020
4021         * qmake/mkspecs/features/configure.prf:
4022
4023 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
4024
4025         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
4026         https://bugs.webkit.org/show_bug.cgi?id=110728
4027
4028         Reviewed by Gyuyoung Kim.
4029
4030         Use the page group to create the view object.
4031
4032         * MiniBrowser/efl/main.c:
4033         (window_create):
4034
4035 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
4036
4037         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
4038
4039         Reviewed by Tor Arne Vestbø.
4040
4041         The mock versions of these web facing features should be instantiated when
4042         running in DumpRenderTree only. In order for them to work, no extra Qt modules
4043         such as QtLocation are actually needed.
4044
4045         This patch decouples enabling device orientation/motion and geolocation from
4046         the underlying Qt modules and makes them available in developer builds
4047         (!production_build) and backed by mock backends when running in drt.
4048
4049         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
4050         developers the web facing features are always enabled (although requests will
4051         time out) and the mock backends are enabled inside DRT, allowing for the layout
4052         tests to run with less dependencies.
4053
4054         In addition this also enables the mock device motion client, which was
4055         previously never instantiated.
4056
4057         * qmake/mkspecs/features/features.prf:
4058
4059 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4060
4061         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
4062         https://bugs.webkit.org/show_bug.cgi?id=112340
4063
4064         Reviewed by Simon Hausmann.
4065
4066         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4067         (DumpRenderTree::dump):
4068             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
4069         (DumpRenderTree::dumpApplicationCacheQuota):
4070         * DumpRenderTree/qt/TestRunnerQt.cpp:
4071         (TestRunnerQt::reset):
4072         * DumpRenderTree/qt/TestRunnerQt.h:
4073         (TestRunnerQt):
4074
4075 2013-03-14  Zeno Albisser  <zeno@webkit.org>
4076
4077         [Qt] Port DRT to use TestRunner::dumpAsText()
4078         https://bugs.webkit.org/show_bug.cgi?id=112260
4079
4080         Reviewed by Benjamin Poulain.
4081
4082         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4083         (WebCore::DumpRenderTree::open):
4084         (WebCore::methodNameStringForFailedTest):
4085             Change parameter from type TestRunnerQt* to TestRunner*.
4086         (WebCore::DumpRenderTree::dump):
4087             TestRunnerQt::shouldDumpPixels() always returned true in our case.
4088             Instead we should rely on TestRunner::generatePixelResults().
4089         * DumpRenderTree/qt/TestRunnerQt.cpp:
4090         (TestRunnerQt::reset):
4091         * DumpRenderTree/qt/TestRunnerQt.h:
4092         (TestRunnerQt):
4093
4094 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
4095
4096         Implement FontLoader interface
4097         https://bugs.webkit.org/show_bug.cgi?id=98395
4098
4099         Reviewed by Eric Seidel.
4100
4101         Enable FontLoadEvents runtime flag for TestShell.
4102
4103         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4104         (WebTestRunner::TestInterfaces::TestInterfaces):
4105
4106 2013-03-13  Julie Parent  <jparent@chromium.org>
4107
4108         CLeanup: remove unnecessary call to parseParameters.
4109         https://bugs.webkit.org/show_bug.cgi?id=112309
4110
4111         Reviewed by Ojan Vafai.
4112         
4113         We call parseCrossDashboardParameters when the dashboard initially
4114         loads to set the state required for loadBuildersList, and then we
4115         call it again once we are fully done with loading, so there is no
4116         reason to call it in the middle of the loading process here.
4117
4118         * TestResultServer/static-dashboards/loader.js:
4119         (.):
4120
4121 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
4122
4123         Unreviewed. Now I'm a reviewer :)
4124
4125         * Scripts/webkitpy/common/config/committers.py:
4126
4127 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
4128
4129         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
4130         https://bugs.webkit.org/show_bug.cgi?id=112277
4131
4132         Reviewed by Adam Barth.
4133
4134         * Scripts/webkitperl/FeatureList.pm:
4135         * qmake/mkspecs/features/features.pri:
4136
4137 2013-03-13  Adam Barth  <abarth@webkit.org>
4138
4139         run-perf-tests should support content_shell
4140         https://bugs.webkit.org/show_bug.cgi?id=112291
4141
4142         Reviewed by Eric Seidel.
4143
4144         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4145         (PerfTestsRunner._parse_args):
4146
4147 2013-03-13  Oliver Hunt  <oliver@apple.com>
4148
4149         Simplify Checked<> multiplication
4150         https://bugs.webkit.org/show_bug.cgi?id=112286
4151
4152         Reviewed by James Robinson.
4153
4154         Add tests for multiplication by zero and max to ensure we don't
4155         mess them up should we ever make changes to Checked<> in future.
4156
4157         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4158         (TestWebKitAPI):
4159
4160 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4161
4162         [Qt] Unreviewed prospective Windows build fix
4163
4164         Do the usual thing, include the moc generated code in the .cpp file instead
4165         of compiling it standalone, to ensure that config.h is included, too, and
4166         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
4167
4168         * DumpRenderTree/qt/EventSenderQt.cpp:
4169
4170 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4171
4172         [Qt] Port TestRunner::findString to shared interface
4173         https://bugs.webkit.org/show_bug.cgi?id=112147
4174
4175         Reviewed by Jocelyn Turcotte.
4176
4177         This patch also removes DumpRenderTree and some other helper classes from
4178         the WebCore namespace, to which they do not really belong.
4179
4180         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4181         (main):
4182         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4183         (DumpRenderTree::DumpRenderTree):
4184         (DumpRenderTree::~DumpRenderTree):
4185         (DumpRenderTree::instance):
4186         (DumpRenderTree::setShouldTimeout):
4187         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4188         (DumpRenderTree):
4189         * DumpRenderTree/qt/EventSenderQt.cpp:
4190         (EventSender::contextClick):
4191         (EventSender::sendEvent):
4192         (EventSender::postEvent):
4193         * DumpRenderTree/qt/EventSenderQt.h:
4194         (EventSender::isGraphicsBased):
4195         * DumpRenderTree/qt/TestRunnerQt.cpp:
4196         (TestRunnerQt::TestRunnerQt):
4197         (TestRunner::findString):
4198         (TestRunnerQt::setMockDeviceOrientation):
4199         (TestRunnerQt::setGeolocationPermission):
4200         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
4201         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
4202         (TestRunnerQt::setMockGeolocationPosition):
4203         * DumpRenderTree/qt/TestRunnerQt.h:
4204         (TestRunnerQt):
4205
4206 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
4207
4208         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
4209         https://bugs.webkit.org/show_bug.cgi?id=112129
4210
4211         Reviewed by Adam Barth.
4212
4213         Following Chromium
4214         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
4215         this is being renamed to better explain what it does.
4216
4217         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4218
4219 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
4220
4221         [Qt] Unreviewed trivial typo fix
4222
4223         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
4224         TextRunner.h. Thanks Zeno :)
4225
4226 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
4227
4228         [Qt] Prepare DRT for transition to shared TestRunner interface
4229         https://bugs.webkit.org/show_bug.cgi?id=112144
4230
4231         Reviewed by Benjamin Poulain.
4232
4233         Prepare Qt's DRT for a transition from the QObject based TestRunner to
4234         the JSC C API based one.
4235
4236         This is impplemented by instantiating the QObject based testRunner in
4237         the global object, then instantiating the JSC C based TestRunner
4238         separately and placing it "behind" the QObject based testRunner through
4239         injection of the individual functions through proxies. (prototype
4240         chaining doesn't work due to the this object and Function.prototype.bind
4241         doesn't work due to the native function)
4242
4243         This allows for porting over method by method by removing the method
4244         from the QObject TestRunnerQt and implementing it in the JSC C based
4245         TestRunner.
4246
4247         In order for this to link and run dummy implementations of all the
4248         necessary TestRunner functions are provided.
4249
4250         * DumpRenderTree/qt/DumpRenderTree.pro:
4251         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
4252         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4253         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4254         (WebCore::DumpRenderTree::initJSObjects):
4255         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4256         (DumpRenderTree):
4257         * DumpRenderTree/qt/TestRunnerQt.cpp:
4258         (TestRunner::~TestRunner):
4259         (TestRunner::addDisallowedURL):
4260         (TestRunner::queueLoad):
4261         (TestRunner::removeAllVisitedLinks):
4262         (TestRunner::setAcceptsEditing):
4263         (TestRunner::simulateLegacyWebNotificationClick):
4264         (TestRunner::setWindowIsKey):
4265         (TestRunner::setAlwaysAcceptCookies):
4266         (TestRunner::addOriginAccessWhitelistEntry):
4267         (TestRunner::setWebViewEditable):
4268         (TestRunner::clearAllApplicationCaches):
4269         (TestRunner::setTextDirection):
4270         (TestRunner::notifyDone):
4271         (TestRunner::numberOfPendingGeolocationPermissionRequests):
4272         (TestRunner::overridePreference):
4273         (TestRunner::pathToLocalResource):
4274         (TestRunner::removeAllWebNotificationPermissions):
4275         (TestRunner::simulateWebNotificationClick):
4276         (TestRunner::closeIdleLocalStorageDatabases):
4277         (TestRunner::focusWebView):
4278         (TestRunner::setBackingScaleFactor):
4279         (TestRunner::removeChromeInputField):
4280         (TestRunner::addChromeInputField):
4281         (TestRunner::originsWithLocalStorage):
4282         (TestRunner::deleteAllLocalStorage):
4283         (TestRunner::deleteLocalStorageForOrigin):
4284         (TestRunner::observeStorageTrackerNotifications):
4285         (TestRunner::syncLocalStorage):
4286         (TestRunner::windowCount):
4287         (TestRunner::setWaitToDump):
4288         (TestRunner::waitForPolicyDelegate):
4289         (TestRunner::webHistoryItemCount):
4290         (TestRunner::showWebInspector):